From xen-devel-bounces@lists.xenproject.org Mon May 01 02:05:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 02:05:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.527919.820530 (Exim 4.92) (envelope-from ) id 1ptIuB-0004Fa-HU; Mon, 01 May 2023 02:04:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 527919.820530; Mon, 01 May 2023 02:04:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptIuB-0004FG-BV; Mon, 01 May 2023 02:04:43 +0000 Received: by outflank-mailman (input) for mailman id 527919; Mon, 01 May 2023 02:04:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptIu9-0004F6-SL; Mon, 01 May 2023 02:04:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptIu9-0005Bi-IV; Mon, 01 May 2023 02:04:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptIu9-0008R5-02; Mon, 01 May 2023 02:04:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ptIu8-000347-Vx; Mon, 01 May 2023 02:04:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MCsuZLpjSHay1yPzhRisZK7v858VGeFvg6FhF3GFmog=; b=OYm8PiiBfj7J2HIhWv/pHlwzt7 7VWcHFvKvVHqqkb8VMaq769hIbrYQvmjgeqlX9kb7gsiSiT/6ame+ZYF3GFQ0xaYVo9RL9OBrNbgv pCZIsy2YlLToygW78wgay7C41CR/IPRpt990AHPYAmauwdGd6DSwdaagEDtKMJx5oZyA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180489: regressions - FAIL X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-examine:reboot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=825a0714d2b3883d4f8ff64f6933fb73ee3f1834 X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Mon, 01 May 2023 02:04:40 +0000 flight 180489 linux-linus real [real] flight 180491 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180489/ http://logs.test-lab.xenproject.org/osstest/logs/180491/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 180278 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-raw 8 xen-boot fail like 180278 test-armhf-armhf-xl-credit2 8 xen-boot fail like 180278 test-armhf-armhf-libvirt 8 xen-boot fail like 180278 test-armhf-armhf-xl-vhd 8 xen-boot fail like 180278 test-armhf-armhf-xl-arndale 8 xen-boot fail like 180278 test-armhf-armhf-examine 8 reboot fail like 180278 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180278 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail like 180278 test-armhf-armhf-xl-rtds 8 xen-boot fail like 180278 test-armhf-armhf-xl-multivcpu 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 825a0714d2b3883d4f8ff64f6933fb73ee3f1834 baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 14 days Failing since 180281 2023-04-17 06:24:36 Z 13 days 23 attempts Testing same since 180486 2023-04-30 05:33:05 Z 0 days 2 attempts ------------------------------------------------------------ 2087 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 247816 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 01 09:42:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 09:42:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.527994.820557 (Exim 4.92) (envelope-from ) id 1ptQ3L-0002Fo-8s; Mon, 01 May 2023 09:42:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 527994.820557; Mon, 01 May 2023 09:42:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptQ3L-0002Fh-4Y; Mon, 01 May 2023 09:42:39 +0000 Received: by outflank-mailman (input) for mailman id 527994; Mon, 01 May 2023 09:42:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptQ3J-0002Fb-CX for xen-devel@lists.xenproject.org; Mon, 01 May 2023 09:42:37 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7eca9566-e804-11ed-8611-37d641c3527e; Mon, 01 May 2023 11:42:34 +0200 (CEST) Received: from mail-mw2nam12lp2048.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.48]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 01 May 2023 05:42:23 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MN2PR03MB5357.namprd03.prod.outlook.com (2603:10b6:208:1e0::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Mon, 1 May 2023 09:42:20 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb%4]) with mapi id 15.20.6340.030; Mon, 1 May 2023 09:42:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7eca9566-e804-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1682934154; h=message-id:date:subject:to:references:from:in-reply-to: content-transfer-encoding:mime-version; bh=TNw1JkG/WJ6X19gEA6XgkNzFyZFAGhk3BSAduUwCFLA=; b=OUygsJlZb2OGP34PelYcMqv62nQgyVIorh7WCyjJTcgS30QZjGxa8gIa D35G8qephknyB/ZhuMxkgs3N5jEUKGLbTgL1K85uF4DpWI8uKrV6BY55y IYrHmmuuykJpFsGLeHi86uEXRxmerzT/zbJbts7s/NIjLqbQR5cZVe9jh 0=; X-IronPort-RemoteIP: 104.47.66.48 X-IronPort-MID: 107315830 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:LefeaqM23laoNljvrR2JlsFynXyQoLVcMsEvi/4bfWQNrUog1TADn GMdCmiBO/uDNDT3fI0jYdyz9U5VuJPQnIMxTAto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvPrRC9H5qyo42tE5QRmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0uMmHktC9 PgWFGwUYErEuaW28pGaTeY506zPLOGzVG8ekldJ6GiDSNMZG9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+/Rxvzi7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prraXwniiBdJJTNVU8NZTg1ap/DIDSyFGTEqhn9ap1HeFA5F2f hl8Fi0G6PJaGFaQZtz0RRixunOHlh8aRdtLEuc+5R2Ny6zb+AKQDC4PSTspQMwrsoo6SCIn0 neNnsj1Hnp/vbuNU3Wf+7yI6zSoNkAowXQqYCYFSU4A/IPlqYRq1BbXFI4/QOiyk8H/Hiz2z 3aSti8iir4PjMkNkaKm4VTAhDHqrZ/MJuIo2jjqsquexlsRTOaYi0aAuTA3Md4owF6lc2S8 IronPort-HdrOrdr: A9a23:1RlYg6kaLAPRKYGHzhHrmyUxfj3pDfNMiWdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5VoMkmskaKdhrNhR4tKPTOWw1dASbsP0WKM+UyCJ8STzJ8l6U 4kSdkHNDSSNykEsS+Z2mmF+r8bqbHokZxAx92uqUuFJTsaF52IhD0JbzpzfHcGIzWuSaBJdq Z1saF81kedkDksH7KGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftxK/mHwOe1hI+VSoK5bs562 DKnyHw+63m6piAu1Xh/l6Wy64TtMrqy9NFCsDJos8JKg/0ggLtSJV9V6aEtDUVpvjqzFoxit HDrzopIsw2wXLMeWOepwfrxmDboX0Twk6n7WXdrWrooMT/Sj5/I81dhbhBeh+cz0Y7ptlz3I 9Cwmrc7vNsfFv9tRW4w+KNewBhl0Kyr3ZnuekPj0ZHWY9bTLNKt4QQ8G5cDZ9FNiPn74IMFv VoEajnlb9rWGLfS0qcknhkwdSqUHh2NhCaQnIassjQ6DRSlGAR9Tps+OUv2lM7sL4tQZhN4O rJdo5ykqtVc8MQZaVhQM8cXMqeEAX2MFzxGVPXBW6iOLAMOnrLpZKyyq4y/vuWdJsBy4Z3sI jdUWlfqXU5dyvVeIKzNaVwg1DwqViGLHfQIpk03ek6hlS8fsumDcS7ciFuryP6yM9vR/EyWJ 6ISeBr6rHYXC/T8L1yrn3DsqlpWAcjufIuy6cGsnK107b2w97Rx5vmWceWAobROhAZfU66Kk c/fVHIVbZ9BwaQKzLFvCQ= X-Talos-CUID: 9a23:NvnFq2Hwf08Fi97pqmJipVE+FsEhfEGB1XmKZHH/CVRKabqaHAo= X-Talos-MUID: =?us-ascii?q?9a23=3A/r2sqg/3KID5L3VsUU3pQtqQf/5r6J6UVlBOrcU?= =?us-ascii?q?fqtO6GjwuAgzFzx3iFw=3D=3D?= X-IronPort-AV: E=Sophos;i="5.99,239,1677560400"; d="scan'208";a="107315830" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kXzP6HIFMQPBp74qp/G4GHvduk45yOCKN9kVp+vTZTP2WVRSelQeKaBsfzA88usjBXjMRW6WK/8He/i5XPp19ncpljmTmaMbsiYEGXzAJXQk97Fh6+s1dz2eb70fe9FS3Yu7eAanGQTfHKJdPybhJWTvD/3TqhgtFhzo6yLySZSqDn+JitjBJjPaTy70tq/U6Rf1+xoG+Z//cFd1wAZLofS4XckGzpIqVsXkc64AITY/iP7dBonPlzoHMC5QwOlnODZlieNozzylsuJcpwz505f3sxHfgv5b2IirduOx7NLG2EkOGTe3RQDnjBiNHOSA1OXiadkcv7/f0oo50Ivgqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5PXg4EtINe7QjykmwunbB7ueYRJ0hS8xhvdoz9Z7xrA=; b=ZND+0D7vGQ4pwQtCuPIBqX+fRuvS3lOb5vGkpsk0UN35ofLrSvte8LIg26UP6odQCajvxgbj4mCXAg2zskjQ95vSyfYQ3CFcsGXn/OJ7K6IYc37kc+1QTuDREh98b0G4YRSJZCRLhtV0KIghhUM9yRpNVTm87SWLqsW+awm84fmKQbpNjT8KRba4zBggzdYphqRVxRtKsMJYP6D1tWh/AHdRLLXEVN4cfAfNI48Zt6gXm7i4o+b36DdCI5F42sIG3R64xmPxmcmNDofaxGI4nQtDP4MjJVaFaO2Ok9GJv7CDSMYfvjcs1MwxPjtDhZJIy0TE6+Iw+KDetvP57Jun2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5PXg4EtINe7QjykmwunbB7ueYRJ0hS8xhvdoz9Z7xrA=; b=e2Luj439KGL8n+PQTY3QGsLZ0GtiA+hONQMbyn5XxUGAnJo440qnyhQ+LaeLaIC60IlSvRswlAUVARH4Z9BLiOFknr0pbPOVPDYKq/BOGFYzmLAiNUymoKVW7YvG+SqGxHpYc/ZxdcFjlvpo1CiIGAuw7SdjQlH0f+SrWVixUEk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <5b17e7c8-3c52-799f-f995-73b3b30ee5ad@citrix.com> Date: Mon, 1 May 2023 10:42:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 0/2] automation: optimize build jobs order Content-Language: en-GB To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel@lists.xenproject.org References: From: Andrew Cooper In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0157.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c7::14) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|MN2PR03MB5357:EE_ X-MS-Office365-Filtering-Correlation-Id: 2bbad587-85e4-4a41-4b2c-08db4a285a51 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6F0Fgp40QCF8U47O73UbS1fKAca3kFpqyAiCjS0+kpLxpl4K102WiAh3dLPov5mitMW3c0k+vDL+ArZwUeQh4kYgYCBssuqQ2rdgkYqYRCuSs0lcOnnOyAuLBd16UYLcaZipsdW1XzzweOP7kNjS+zSaz8JO5DRrOOhjT2wx0AzBdMJRwjyuev1suXlX5thhKOldZNj4eJ+h/EAEpyfsu6L6dPTefDAiyWv0Z9VtCLbsxKbatSLAAcvoEro+CD+HLKniMXtmvf2Sgylom5i4zZuN8k8Hs286oYlgehh/fal89e+bEsvvUlrE19SYd3v4z5FotmJIMPHWC227cFCGDj7ragXz3AhyURYA8s2TxN7n7Oqw+UbNTkhE5QZwprJbL1qyY6M64jVhxUc6OJ+xR/oGZ467ApUHlRVzsC8MyHJEMaDz/bdkHK42exnEafvspn6Yqd6eHoGjJ4d5NDTbdMshRmSJCPyB7TaOcD/Jr/5TWZpCTx0QKEKAal6GDwN8qcEkDowoxFJB6NHF2P/7sjIGpJN+GezQ99OViSDE247bleBY8PTt70+O4mXaUoGEUI6LRHWIVHtcA1944DNe8+riSwo/CnOTJjPWg0EZYZNmPNW27kcvU33WPGinRyhI5BHVlCQzxG7NrC8caac4VA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(136003)(366004)(376002)(346002)(451199021)(31686004)(31696002)(86362001)(36756003)(82960400001)(38100700002)(66574015)(83380400001)(2616005)(6512007)(6506007)(26005)(186003)(53546011)(6486002)(6666004)(478600001)(66946007)(66476007)(66556008)(41300700001)(8936002)(316002)(8676002)(5660300002)(4744005)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RXFCMWNKYng3STV5NmlXcks3OUZHcTdJSUFiRk1ZWEdIZ0VZbGlrVFdCMmVp?= =?utf-8?B?Und0N2VFY2pDNUIwN0x4ZFgyRWhINGl3cXFUZVg5UFV6Vm1UdWcwTDFPM0lw?= =?utf-8?B?T1d5a1NrcGRSSWUvL3kzbTY2UkVCS1pLRGlodGxFaUVQU3VZODFzSzRGVUlk?= =?utf-8?B?K2R3NlRUcWxLZ1dKd2IzckoyUU5KT2hleUg2aHJlQ3VCdXQ4Y1RoK21uQTg4?= =?utf-8?B?L1k1Z2lQeE5xcGk5S2w1bnhVbE5oNHpvaXJxWTN0TVBFaUJPeUhYRlVOZ3BK?= =?utf-8?B?V21lQnVmZVZhMk9iR0Y0N3BXZ1QvaHdjSXpSczZWVlpLbUZSWVZGMDV1RVdN?= =?utf-8?B?Y2Z5b1V6NDd2b29IYWNpaVdpNjhYYWtlcXA2SksxMS9aNUFkZWlMdUFlSm5W?= =?utf-8?B?a1hBKzQrWXdjMU5WSFlUQnYrSFN4MTRaOUY2cFJONUJTMFBhVE5sZlZ4S2s5?= =?utf-8?B?WnZYZm1LRERQa0MraXpnenphbFB4QWFDekVwU1JoS1duTXlLdE1OMFZxNkZQ?= =?utf-8?B?SmdSdVVmUVZnb1J2UHRnTW5aRGcvdFlSay84b1BWa2NEeFcxVjYwZ2owNHB1?= =?utf-8?B?VDZyQzFHcGxQanZ0YnpRam9IaUh6STFrOGd1ZkVRNlNRcDVudHp3RVE1SjJk?= =?utf-8?B?WHJOM1RRM2ZQUmgyemlrV1lIUlJjd0VTS1Y0SHg2QTErenZvdFRkSkNad3hI?= =?utf-8?B?WUNMQXJmQUc1WmhnRjRGVCtCWllaY1UzcksvanJORkVpNFdDS3o2eDI2NDJY?= =?utf-8?B?VEJVdENGUnp5TzlTR3kyV01YV040bWwwV0h4UWpwOU0zcHJCeEJFLzdoWXl5?= =?utf-8?B?cjVqcmhNVVBTQW9FSCtBOE0xVEEvQjNyTDIxTElJNkZMbTdnWDlDa3ZxeTdZ?= =?utf-8?B?SXFCcGNsRDBaMk9Gb2hhZVlMZlZmMHd5eVVuMHB2QXVsVFhjcFFpZWIrb0Y4?= =?utf-8?B?bkpsV3p3bVFEbGpqcFFySWVpMTgxVUdmMXIxM0VlNm9lc2RwN3BySGlzOXFu?= =?utf-8?B?T2IzOTFKdWZjY0NDUXpvZXMvcmlmbnI0RVpkME1tdlNRQnozUmQ5YzZZeDI4?= =?utf-8?B?NitqVTFNQzIyWXk2dStoV0xJVnBFUm8yM0svWHJjb0pmWE1nWHA3ZU9lMnR2?= =?utf-8?B?OWdCTnpnSnY5SnhSTTVkekVFZmh3UVU0MkVYbWJFbFNZTDJwRDE0LzB1aXUz?= =?utf-8?B?c0x6RFh3aU0ybGhYY0dTdE1hdWpaRHFzdGF0a09KSGVOd2VNWE5aTXlUL0h3?= =?utf-8?B?bGVMUmRuUlZEZFdmNnFVM1hpeUFpeGlHNmpBME0vZlVUVWF4Nk45bnhmL2Nx?= =?utf-8?B?SHB1ZW1QazAySVB3OVFBQzFwdWo0V2ZETlJ0dWR3RHFTVmxLbzBrTzJ4RWFj?= =?utf-8?B?YkxVZnNYQUl6RS9sK3krZWFaNmRlekZWUUFEVDlzc0QvUVZBakxyNzg0b3JL?= =?utf-8?B?MVlyVGdPTEl6VzUrMHcrdnpibzBpcnpsQVUwMVZ0TDhhRXpvaVJob1RHYUZE?= =?utf-8?B?YUFoOWV4U3FjblhNVnBQb2hmRkRVd1Z2ODNQL3hWN3Q3ZkZNaWFLNWZhWjlV?= =?utf-8?B?M0w0ekhoVTI0aFZNdC9GYWNVbWtBWjRWUUcvYi9Wdmd2Q2RQSklDNXVNV1RL?= =?utf-8?B?bXJWSTZNeXErY1JGdHVaNkdNR09QeEdOV1gwQ1BSOWNVWW0wUTFrNHlPZWFk?= =?utf-8?B?MmJDQlhYeGxZYnE5Z0xlREtmUHN3cXRub2F5MUNqaVI5MGNnc0xLYU5NNi95?= =?utf-8?B?WGlEYXZxOHhjeXhvOElweDlvWVRxclJxV0RSdlRyNEh1L0pJT2hNTjI3ZVRk?= =?utf-8?B?OE1PZk85NVBRTUlZZ2hpVGp4Ry96VDBzUkJtR2NBdmVpcXBSOGRpcTViTjNw?= =?utf-8?B?MnkwakFRYTZKc2dQS25TVTliSE54UWU0azVMQmxuQjY1amlXOWlnYzR6ZGlr?= =?utf-8?B?TGtiYVRMMEVtay9wWFdVNlBxaEVVd1hXRFN2TEhLSmVZaFZaY1B6U0pHMmxI?= =?utf-8?B?eG5MVUluNWVMZEllNm1SRHJGTnpEaHI5eEJ1R1JJcURPTWtuamFuM2xOaVpY?= =?utf-8?B?N0JJVEFCY3hHaGY1TlZhdExrbUdwRktpeFErcVB6U3dJZ1N0NTREdjRpckUy?= =?utf-8?B?RVR0Y3k3a1hCcW1DT2tPVTd3d2hOcTNaUFNhT25MWFNzWHVYOXA3SDlGa1hN?= =?utf-8?B?eXc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: j9os9VWauS7GfRIUZpNWEDhvWvgiHrwXCNS6CsZRXi0HW+Zy7/QPKsgmywoJbqpXMIE//tprJyEkGomJA8j6gcgZexWHCUiCQpsXQWUvbpkCkigH7r3SZKqX/Js5osJuNIBeFliRexiYt5kq14glWChi0AdrWMa2ctkQaNkcJ+wleCmTmY1eAyX/IvoCssFFcBlptIBR3vXHWBVuW/haHooPPuhXGkwsSkwVQZ0c4YYgd5OiAwzRipCDyyX30TkRRsqYDo8AXzpq5NcYux+nxCLILyZcejdno19GJGD3wGOj/DA4ClsMxMJoclgo9BlxOhm+2s5ACSktudwCID8UlaqBD8Ei5baHSXTnKYcsA/Ayijd8/PHaOc1hwX0HyxrC4OZAxYnofHdIr32aFW5szP57MxJAUGbU0XZ9rf3UQr6FRkLvvGrkeOChSyK1sZ9f+LBiqwzQYAOQ2vxTRxBLL8D1lFPxZnFZiKDCpA8RYiyAWDTQKaLnX5ncOe94xALt8Gca/czUp5nm7CjVChX16vp6Mf54fyrd0QF6EFSzirPZa5nV9PhsUFi9LJ/fmyKc/HxJH+BTQqqJc2/mwPB0ekfFTMCcYZ0s4OJUuytylhA5TRRriat6OcqB1ud4wX0EvMoEZlIEANX8tO/nKm/cyYZiY6OgT1d5u6DIVQQEaOzzjdtIZouOkSyWeVWMOiJuwki6EZ2T76KQyfLlr6svQd9k7wCPKrxCPzK4A9q+CAR/kjq/VnIf4Y/gy/h/OWNGYnzZuc8MK2amOm3LQYVQGcdsNUT06yFAK7N7RG2HVVr0AanqAez9MmuXH1A9Js/AijteJstDf9G/6H1Vdov3cQ== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2bbad587-85e4-4a41-4b2c-08db4a285a51 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2023 09:42:18.4194 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Cw7dsPwLTS2lwrO4RnOjQ8NcOEmMfAs6z3RJHeE1R2yWzaSbMS1ZD3o2++mQaqv03dWML/rF2hopjHuzvu4+qdHFucOLD4oow4jdPmvCItk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5357 On 30/04/2023 11:42 pm, Marek Marczykowski-Górecki wrote: > This made the pipeline to complete within 45 minutes. This isn't big > improvement on its own, but should make adding more runners more > beneficial. While looking at it in real time, most jobs were really > waiting for available runners and not stuck on dependencies anymore. > > Marek Marczykowski-Górecki (2): > automation: move test artifacts jobs to the top > automation: optimize build jobs order Much easier to follow.  Thanks. Reviewed-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Mon May 01 10:06:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 10:06:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.527998.820567 (Exim 4.92) (envelope-from ) id 1ptQQS-0004tC-3g; Mon, 01 May 2023 10:06:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 527998.820567; Mon, 01 May 2023 10:06:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptQQS-0004t5-0J; Mon, 01 May 2023 10:06:32 +0000 Received: by outflank-mailman (input) for mailman id 527998; Mon, 01 May 2023 10:06:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptQQP-0004su-Qg; Mon, 01 May 2023 10:06:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptQQP-0001ZE-Fo; Mon, 01 May 2023 10:06:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptQQO-0005Wj-VP; Mon, 01 May 2023 10:06:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ptQQO-0000JG-V0; Mon, 01 May 2023 10:06:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MOrsYD36vFgY3q15wNpKNU6adowB2fcfAjCDaP+KNsU=; b=Yr9I9WTmUAUvR4UK1NGGwjczRZ g+DwqzUbtAuBJsC2Pwc/V2pMAQ42KY0ipNt5l7/t1E+O+IXYux9NLBrXnai2FZLZZICHicuDTVtdo Rjt52aAdhDfoWJaGOd3k4sbpXU4QuG2vRJf6Qq/jFzeU03wTcK2w+iqazmqHHt29A9ao=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180492: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:windows-install:fail:heisenbug xen-unstable:test-amd64-i386-freebsd10-i386:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=6a47ba2f7855f8fc094ec4f837e71a34ededb77b X-Osstest-Versions-That: xen=6a47ba2f7855f8fc094ec4f837e71a34ededb77b From: osstest service owner Date: Mon, 01 May 2023 10:06:28 +0000 flight 180492 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/180492/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-win7-amd64 12 windows-install fail in 180484 pass in 180492 test-amd64-i386-freebsd10-i386 7 xen-install fail pass in 180484 Tests which did not succeed, but are not blocking: test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail in 180484 like 180481 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail like 180481 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180481 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180484 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180484 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180484 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180484 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180484 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180484 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 180484 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 180484 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180484 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 180484 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180484 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: xen 6a47ba2f7855f8fc094ec4f837e71a34ededb77b baseline version: xen 6a47ba2f7855f8fc094ec4f837e71a34ededb77b Last test of basis 180492 2023-05-01 01:52:02 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon May 01 13:26:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 13:26:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528024.820577 (Exim 4.92) (envelope-from ) id 1ptTXm-0007zv-Bx; Mon, 01 May 2023 13:26:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528024.820577; Mon, 01 May 2023 13:26:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptTXm-0007zo-8L; Mon, 01 May 2023 13:26:18 +0000 Received: by outflank-mailman (input) for mailman id 528024; Mon, 01 May 2023 13:26:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptTXl-0007zd-Bp; Mon, 01 May 2023 13:26:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptTXk-0005wH-V4; Mon, 01 May 2023 13:26:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptTXk-0001jN-B6; Mon, 01 May 2023 13:26:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ptTXk-0001bK-Ag; Mon, 01 May 2023 13:26:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=33eSr4Ud25s2d+ZXDV+Y0W/bwEw4xfk8MfQ9ZDWE3xA=; b=cCuakuRSJjBXdUljjJnmVvRpCt SjJEJqzcSycPNr2wIJAmszNbvlqW53ODj2Qu+1SngrckFafHcfFstNhF1vsTX6ABEGFyMfEEX0mxe i8fvZ7i4yZbdVzo1j6XPeuJiXEmF1Z09RRXGtnsHVt6HHcp4L+j8Q4W5aeACHnMMKAaI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180493: regressions - FAIL X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:guest-start/debian.repeat:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:heisenbug linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-examine:reboot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=58390c8ce1bddb6c623f62e7ed36383e7fa5c02f X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Mon, 01 May 2023 13:26:16 +0000 flight 180493 linux-linus real [real] flight 180495 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180493/ http://logs.test-lab.xenproject.org/osstest/logs/180495/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-vhd 21 guest-start/debian.repeat fail REGR. vs. 180278 Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-vhd 8 xen-boot fail pass in 180495-retest Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-vhd 14 migrate-support-check fail in 180495 never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 180495 never pass test-armhf-armhf-xl-credit2 8 xen-boot fail like 180278 test-armhf-armhf-libvirt 8 xen-boot fail like 180278 test-armhf-armhf-xl-vhd 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-raw 8 xen-boot fail like 180278 test-armhf-armhf-xl-arndale 8 xen-boot fail like 180278 test-armhf-armhf-examine 8 reboot fail like 180278 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180278 test-armhf-armhf-xl 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180278 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail like 180278 test-armhf-armhf-xl-rtds 8 xen-boot fail like 180278 test-armhf-armhf-xl-multivcpu 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass version targeted for testing: linux 58390c8ce1bddb6c623f62e7ed36383e7fa5c02f baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 14 days Failing since 180281 2023-04-17 06:24:36 Z 14 days 24 attempts Testing same since 180493 2023-05-01 02:06:50 Z 0 days 1 attempts ------------------------------------------------------------ 2116 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 254448 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 01 13:33:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 13:33:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528029.820587 (Exim 4.92) (envelope-from ) id 1ptTeJ-00012b-4u; Mon, 01 May 2023 13:33:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528029.820587; Mon, 01 May 2023 13:33:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptTeJ-00012U-0T; Mon, 01 May 2023 13:33:03 +0000 Received: by outflank-mailman (input) for mailman id 528029; Mon, 01 May 2023 13:33:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptTeH-00012K-Ul; Mon, 01 May 2023 13:33:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptTeH-0006Cf-N1; Mon, 01 May 2023 13:33:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptTeG-0001s6-M5; Mon, 01 May 2023 13:33:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ptTeG-0002wR-Lc; Mon, 01 May 2023 13:33:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GlPNhGj+SkdjHwGhzQrq+rLTdRazIYKTKdlQi5SL95Y=; b=4HSQQXPKQkhexbbV2p8bIb2zKz hrtyGv/WKr0ffmL5yOqJPULp5fW+QCdqyX8fDsXG89ilHwyCYqUkBHpKHU/UAqZkkq7WvYUdsTLRT M4GWq1P0pMglXRL8yzsW3ZzFRHue3yp6Kk7VUW4SESp3PeCl4l0Op33pQ5qwnrh8aVds=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 180494: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=ef841d2a2377f5297add27e637b725426bb4840a X-Osstest-Versions-That: xen=6a47ba2f7855f8fc094ec4f837e71a34ededb77b From: osstest service owner Date: Mon, 01 May 2023 13:33:00 +0000 flight 180494 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/180494/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen ef841d2a2377f5297add27e637b725426bb4840a baseline version: xen 6a47ba2f7855f8fc094ec4f837e71a34ededb77b Last test of basis 180471 2023-04-28 15:02:00 Z 2 days Testing same since 180494 2023-05-01 11:03:16 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Marek Marczykowski-Górecki jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 6a47ba2f78..ef841d2a23 ef841d2a2377f5297add27e637b725426bb4840a -> smoke From xen-devel-bounces@lists.xenproject.org Mon May 01 15:10:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 15:10:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528042.820596 (Exim 4.92) (envelope-from ) id 1ptVAK-0002uJ-7Z; Mon, 01 May 2023 15:10:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528042.820596; Mon, 01 May 2023 15:10:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptVAK-0002uC-4i; Mon, 01 May 2023 15:10:12 +0000 Received: by outflank-mailman (input) for mailman id 528042; Mon, 01 May 2023 15:10:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptVAJ-0002u3-5M for xen-devel@lists.xenproject.org; Mon, 01 May 2023 15:10:11 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 420b0a69-e832-11ed-b225-6b7b168915f2; Mon, 01 May 2023 17:10:08 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-650-aITlDNxzPOCmk1dkEKuuzA-1; Mon, 01 May 2023 11:09:45 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 32042381459C; Mon, 1 May 2023 15:09:38 +0000 (UTC) Received: from localhost (unknown [10.39.192.118]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3B641405DBBC; Mon, 1 May 2023 15:09:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 420b0a69-e832-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682953807; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QPwbHvw4ANoG38uZDcwsHmZDGENhR6tztyBUqhJj/1o=; b=djXZWchKCi8PMRevZ9+gcZE/8i9jp69nQKiYLXQPPoa5kWHecxH+/L/N8X4LyJqlrjlp3C IwEQqQT4c/QRW0V08TMf0QfZtUGUXThrNZirUCMBRRmEY4xU+nRCkRuOYj/D99nmHYtaqZ De7RlyQGxtd4rXo+zKW4ydVwPlFD+7c= X-MC-Unique: aITlDNxzPOCmk1dkEKuuzA-1 Date: Mon, 1 May 2023 11:09:34 -0400 From: Stefan Hajnoczi To: Kevin Wolf Cc: qemu-devel@nongnu.org, Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Juan Quintela , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Richard Henderson , Fam Zheng , "Michael S. Tsirkin" , Coiby Xu , David Woodhouse , Marcel Apfelbaum , Peter Lieven , Paul Durrant , "Richard W.M. Jones" , qemu-block@nongnu.org, Stefano Garzarella , Anthony Perard , Stefan Weil , Xie Yongji , Paolo Bonzini , Aarushi Mehta , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Eduardo Habkost , Stefano Stabellini , Hanna Reitz , Ronnie Sahlberg , Zhengui Li , Daniil Tatianin Subject: Re: [PATCH v4 04/20] virtio-scsi: stop using aio_disable_external() during unplug Message-ID: <20230501150934.GA14869@fedora> References: <20230425172716.1033562-1-stefanha@redhat.com> <20230425172716.1033562-5-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="afWx/qHB+Kz1LRw/" Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 --afWx/qHB+Kz1LRw/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 28, 2023 at 04:22:55PM +0200, Kevin Wolf wrote: > Am 25.04.2023 um 19:27 hat Stefan Hajnoczi geschrieben: > > This patch is part of an effort to remove the aio_disable_external() > > API because it does not fit in a multi-queue block layer world where > > many AioContexts may be submitting requests to the same disk. > >=20 > > The SCSI emulation code is already in good shape to stop using > > aio_disable_external(). It was only used by commit 9c5aad84da1c > > ("virtio-scsi: fixed virtio_scsi_ctx_check failed when detaching scsi > > disk") to ensure that virtio_scsi_hotunplug() works while the guest > > driver is submitting I/O. > >=20 > > Ensure virtio_scsi_hotunplug() is safe as follows: > >=20 > > 1. qdev_simple_device_unplug_cb() -> qdev_unrealize() -> > > device_set_realized() calls qatomic_set(&dev->realized, false) so > > that future scsi_device_get() calls return NULL because they exclude > > SCSIDevices with realized=3Dfalse. > >=20 > > That means virtio-scsi will reject new I/O requests to this > > SCSIDevice with VIRTIO_SCSI_S_BAD_TARGET even while > > virtio_scsi_hotunplug() is still executing. We are protected against > > new requests! > >=20 > > 2. Add a call to scsi_device_purge_requests() from scsi_unrealize() so > > that in-flight requests are cancelled synchronously. This ensures > > that no in-flight requests remain once qdev_simple_device_unplug_cb() > > returns. > >=20 > > Thanks to these two conditions we don't need aio_disable_external() > > anymore. > >=20 > > Cc: Zhengui Li > > Reviewed-by: Paolo Bonzini > > Reviewed-by: Daniil Tatianin > > Signed-off-by: Stefan Hajnoczi >=20 > qemu-iotests 040 starts failing for me after this patch, with what looks > like a use-after-free error of some kind. >=20 > (gdb) bt > #0 0x000055b6e3e1f31c in job_type (job=3D0xe3e3e3e3e3e3e3e3) at ../job.c= :238 > #1 0x000055b6e3e1cee5 in is_block_job (job=3D0xe3e3e3e3e3e3e3e3) at ../b= lockjob.c:41 > #2 0x000055b6e3e1ce7d in block_job_next_locked (bjob=3D0x55b6e72b7570) a= t ../blockjob.c:54 > #3 0x000055b6e3df6370 in blockdev_mark_auto_del (blk=3D0x55b6e74af0a0) a= t ../blockdev.c:157 > #4 0x000055b6e393e23b in scsi_qdev_unrealize (qdev=3D0x55b6e7c04d40) at = =2E./hw/scsi/scsi-bus.c:303 > #5 0x000055b6e3db0d0e in device_set_realized (obj=3D0x55b6e7c04d40, valu= e=3Dfalse, errp=3D0x55b6e497c918 ) at ../hw/core/qdev.c:599 > #6 0x000055b6e3dba36e in property_set_bool (obj=3D0x55b6e7c04d40, v=3D0x= 55b6e7d7f290, name=3D0x55b6e41bd6d8 "realized", opaque=3D0x55b6e7246d20, er= rp=3D0x55b6e497c918 ) > at ../qom/object.c:2285 > #7 0x000055b6e3db7e65 in object_property_set (obj=3D0x55b6e7c04d40, name= =3D0x55b6e41bd6d8 "realized", v=3D0x55b6e7d7f290, errp=3D0x55b6e497c918 ) at ../qom/object.c:1420 > #8 0x000055b6e3dbd84a in object_property_set_qobject (obj=3D0x55b6e7c04d= 40, name=3D0x55b6e41bd6d8 "realized", value=3D0x55b6e74c1890, errp=3D0x55b6= e497c918 ) > at ../qom/qom-qobject.c:28 > #9 0x000055b6e3db8570 in object_property_set_bool (obj=3D0x55b6e7c04d40,= name=3D0x55b6e41bd6d8 "realized", value=3Dfalse, errp=3D0x55b6e497c918 ) at ../qom/object.c:1489 > #10 0x000055b6e3daf2b5 in qdev_unrealize (dev=3D0x55b6e7c04d40) at ../hw/= core/qdev.c:306 > #11 0x000055b6e3db509d in qdev_simple_device_unplug_cb (hotplug_dev=3D0x5= 5b6e81c3630, dev=3D0x55b6e7c04d40, errp=3D0x7ffec5519200) at ../hw/core/qde= v-hotplug.c:72 > #12 0x000055b6e3c520f9 in virtio_scsi_hotunplug (hotplug_dev=3D0x55b6e81c= 3630, dev=3D0x55b6e7c04d40, errp=3D0x7ffec5519200) at ../hw/scsi/virtio-scs= i.c:1065 > #13 0x000055b6e3db4dec in hotplug_handler_unplug (plug_handler=3D0x55b6e8= 1c3630, plugged_dev=3D0x55b6e7c04d40, errp=3D0x7ffec5519200) at ../hw/core/= hotplug.c:56 > #14 0x000055b6e3a28f84 in qdev_unplug (dev=3D0x55b6e7c04d40, errp=3D0x7ff= ec55192e0) at ../softmmu/qdev-monitor.c:935 > #15 0x000055b6e3a290fa in qmp_device_del (id=3D0x55b6e74c1760 "scsi0", er= rp=3D0x7ffec55192e0) at ../softmmu/qdev-monitor.c:955 > #16 0x000055b6e3fb0a5f in qmp_marshal_device_del (args=3D0x7f61cc005eb0, = ret=3D0x7f61d5a8ae38, errp=3D0x7f61d5a8ae40) at qapi/qapi-commands-qdev.c:1= 14 > #17 0x000055b6e3fd52e1 in do_qmp_dispatch_bh (opaque=3D0x7f61d5a8ae08) at= ../qapi/qmp-dispatch.c:128 > #18 0x000055b6e4007b9e in aio_bh_call (bh=3D0x55b6e7dea730) at ../util/as= ync.c:155 > #19 0x000055b6e4007d2e in aio_bh_poll (ctx=3D0x55b6e72447c0) at ../util/a= sync.c:184 > #20 0x000055b6e3fe3b45 in aio_dispatch (ctx=3D0x55b6e72447c0) at ../util/= aio-posix.c:421 > #21 0x000055b6e4009544 in aio_ctx_dispatch (source=3D0x55b6e72447c0, call= back=3D0x0, user_data=3D0x0) at ../util/async.c:326 > #22 0x00007f61ddc14c7f in g_main_dispatch (context=3D0x55b6e7244b20) at .= =2E/glib/gmain.c:3454 > #23 g_main_context_dispatch (context=3D0x55b6e7244b20) at ../glib/gmain.c= :4172 > #24 0x000055b6e400a7e8 in glib_pollfds_poll () at ../util/main-loop.c:290 > #25 0x000055b6e400a0c2 in os_host_main_loop_wait (timeout=3D0) at ../util= /main-loop.c:313 > #26 0x000055b6e4009fa2 in main_loop_wait (nonblocking=3D0) at ../util/mai= n-loop.c:592 > #27 0x000055b6e3a3047b in qemu_main_loop () at ../softmmu/runstate.c:731 > #28 0x000055b6e3dab27d in qemu_default_main () at ../softmmu/main.c:37 > #29 0x000055b6e3dab2b8 in main (argc=3D24, argv=3D0x7ffec55196a8) at ../s= oftmmu/main.c:48 > (gdb) p jobs > $4 =3D {lh_first =3D 0x0} I wasn't able to reproduce this with gcc 13.1.1 or clang 16.0.1: $ tests/qemu-iotests/check -qcow2 040 Any suggestions on how to reproduce the issue? Thanks, Stefan --afWx/qHB+Kz1LRw/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmRP1i4ACgkQnKSrs4Gr c8jU8gf7Bsg/kploFAmdPvcQ5QvmehPNQbyu4ORQkGh9WjEiJ4fROi0dXYB9yyU6 EZMpHv+mxn82F2lSoWcqD6HuuxeUJn+LVEHUzrDgcy4z9KWY8pNQmC5tijEAWnh3 0Q9G6WC9F+3GFly99ED34Ip8UJhz7IetXKMlZ+/cD8rm8YNa17cXEzZ/nHq8+aa0 SUAcymqkoOEQ9fRPQKx5TK2PW5AsZmgQE8dlmWh2c4zaWyjmZdLjE6Dap5e4l5U8 +fR9RbHAl9hMd/+SZNGzkVvZDSYMnZ8qdoEbvQ8YaxlXXaXP9gh4Mv4UBxHlOIAS Af2CAk1ye+2jhy7jM1N0qxVg5pu/oQ== =v+9M -----END PGP SIGNATURE----- --afWx/qHB+Kz1LRw/-- From xen-devel-bounces@lists.xenproject.org Mon May 01 19:21:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:21:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528061.820606 (Exim 4.92) (envelope-from ) id 1ptZ4v-0002o2-Uf; Mon, 01 May 2023 19:20:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528061.820606; Mon, 01 May 2023 19:20:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZ4v-0002nv-S0; Mon, 01 May 2023 19:20:53 +0000 Received: by outflank-mailman (input) for mailman id 528061; Mon, 01 May 2023 19:20:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZ4u-0002np-SC for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:20:52 +0000 Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [2607:f8b0:4864:20::f32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 48818f38-e855-11ed-b225-6b7b168915f2; Mon, 01 May 2023 21:20:51 +0200 (CEST) Received: by mail-qv1-xf32.google.com with SMTP id 6a1803df08f44-61aecee26feso6514226d6.2 for ; Mon, 01 May 2023 12:20:51 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id x20-20020a0ce0d4000000b0061927ddb043sm2012307qvk.80.2023.05.01.12.20.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:20:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 48818f38-e855-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682968850; x=1685560850; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=LIDXD1rjydJmaXqYe1USNeTaj7ndwcTzSDSXNcX5Wmw=; b=fCxjw0fDJEhIoYwSMnKGFnxE1HSttRshqhiOS3w37Ymm5azocp8ZcNWwc4m2a3q4lA 7G5/PEesUyxFiNELjSeaoGBP+tpUMFV+R3oKoHxgqjPWHfaN3f7AN4VmtQEeDBvF5JZ3 utMi/4V7/QqXcOsIpxj76V7gfchy0TGcr1G1pWO/sqatWzSXU36Bwad+npRXA2nVrLEH cDC+f9NFhQxXhjc+lXNI8wyFVbeVP7T3deuGAQzvSuNsnlIWiUazz6k0IEff0E/BHTiG X7Ff0yXKJhE4WMWBXeKHfnVLSExxKK34N1Jja+pgktNUbBwbu/ZeuJXYvCoBKuzJpl1C xTQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682968850; x=1685560850; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LIDXD1rjydJmaXqYe1USNeTaj7ndwcTzSDSXNcX5Wmw=; b=dXxGQmp/0mkLuiTFFqNBAhjJ8fUKeyEKJgV+LSpodgMs7doKmYNOXcrtZQlas4uNsA TXjP5RXgeoGYixHKnkMKq1Qwm2P69H8ocYkUn4qFnuL3yk+R2/rwgSNgcQsGM2v8niwc CZjati7jLT8YpIWYHDSxiErlLrjhuD4vqAH0VeJhNwxDXyGT80dFkPPGpqOsO4t+Uz+Y ZmrnRA7JR9Arlmy+9GqyuZU6+VRQI2UXQXjV7lRRWvtP6zUXJNbzc+E+dwzpaakTmLEn oQs9T9ZjkX53BZZPhOQRUXkgNpBbkw4SKKdI+oeTGhHpSsBI10qtY/j/PANfjW+EHnAC iuPA== X-Gm-Message-State: AC+VfDwsGGLY3iRf5lf81Tl4nWZBiweOKgB8mBKR9HU+53wdw+JcU8QT 3ZbD5Bl2oCX1vhMefxqRowQ= X-Google-Smtp-Source: ACHHUZ6KZb0pidqm5YN+GDCFc/grr88J90LhZQaVORRfrc+BGNPLFyX2X74VvD2xoxTzjJ5RzX3NkQ== X-Received: by 2002:ad4:5e8d:0:b0:56f:52ba:cce6 with SMTP id jl13-20020ad45e8d000000b0056f52bacce6mr1779909qvb.19.1682968849783; Mon, 01 May 2023 12:20:49 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproj, xen-devel@lists.xenproject.org Cc: Jason Andryuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Anthony PERARD , Juergen Gross , Henry Wang , Community Manager Subject: [PATCH v3 00/14] Intel Hardware P-States (HWP) support Date: Mon, 1 May 2023 15:20:31 -0400 Message-Id: <20230501192045.87377-1-jandryuk@gmail.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi, This patch series adds Hardware-Controlled Performance States (HWP) for Intel processors to Xen. v2 was only partially reviewed, so v3 is mostly a reposting of v2. In v2 & v3, I think I addressed all comments for v1. I kept patch 11 "xenpm: Factor out a non-fatal cpuid_parse variant", with a v2 comment explaining why I keep it. v3 adds "xen/x86: Tweak PDC bits when using HWP". Qubes testing revealed an issue where enabling HWP can crash firwmare code (maybe SMM). This requires a Linux change to get the PDC bits from Xen and pass them to ACPI. Roger has a patch [0] to set the PDC bits. Roger's 3 patch series was tested with "xen/x86: Tweak PDC bits when using HWP" on affected hardware and allowed proper operation. Previous cover letter: With HWP, the processor makes its own determinations for frequency selection, though users can set some parameters and preferences. There is also Turbo Boost which dynamically pushes the max frequency if possible. The existing governors don't work with HWP since they select frequencies and HWP doesn't expose those. Therefore a dummy hwp-interal governor is used that doesn't do anything. xenpm get-cpufreq-para is extended to show HWP parameters, and set-cpufreq-hwp is added to set them. A lightly loaded OpenXT laptop showed ~1W power savings according to powertop. A mostly idle Fedora system (dom0 only) showed a more modest power savings. This for for a 10th gen 6-core 1600 MHz base 4900 MHZ max cpu. In the default balance mode, Turbo Boost doesn't exceed 4GHz. Tweaking the energy_perf preference with `xenpm set-cpufreq-hwp balance ene:64`, I've seen the CPU hit 4.7GHz before throttling down and bouncing around between 4.3 and 4.5 GHz. Curiously the other cores read ~4GHz when turbo boost takes affect. This was done after pinning all dom0 cores, and using taskset to pin to vCPU/pCPU 11 and running a bash tightloop. HWP defaults to disabled and running with the existing HWP configuration - it doesn't reconfigure by default. It can be enabled with cpufreq=xen:hwp. Hardware Duty Cycling (HDC) is another feature to autonomously powerdown things. It defaults to enabled when HWP is enabled, but HDC can be disabled on the command line. cpufreq=xen:hwp,no-hdc I've only tested on 8th gen and 10th gen systems with activity window and energy_perf support. So the pathes for CPUs lacking those features are untested. Fast MSR support was removed in v2. The model specific checking was not done properly, and I don't have hardware to test with. Since writes are expected to be infrequent, I just removed the code. This changes the systcl_pm_op hypercall, so that wants review. Regards, Jason [0] https://lore.kernel.org/xen-devel/20221121102113.41893-3-roger.pau@citrix.com/ Jason Andryuk (14): cpufreq: Allow restricting to internal governors only cpufreq: Add perf_freq to cpuinfo cpufreq: Export intel_feature_detect cpufreq: Add Hardware P-State (HWP) driver xenpm: Change get-cpufreq-para output for internal xen/x86: Tweak PDC bits when using HWP cpufreq: Export HWP parameters to userspace libxc: Include hwp_para in definitions xenpm: Print HWP parameters xen: Add SET_CPUFREQ_HWP xen_sysctl_pm_op libxc: Add xc_set_cpufreq_hwp xenpm: Factor out a non-fatal cpuid_parse variant xenpm: Add set-cpufreq-hwp subcommand CHANGELOG: Add Intel HWP entry CHANGELOG.md | 1 + docs/misc/xen-command-line.pandoc | 8 +- tools/include/xenctrl.h | 6 + tools/libs/ctrl/xc_pm.c | 18 + tools/misc/xenpm.c | 355 +++++++++++- xen/arch/x86/acpi/cpufreq/Makefile | 1 + xen/arch/x86/acpi/cpufreq/cpufreq.c | 15 +- xen/arch/x86/acpi/cpufreq/hwp.c | 633 ++++++++++++++++++++++ xen/arch/x86/acpi/lib.c | 5 + xen/arch/x86/cpu/mcheck/mce_intel.c | 6 + xen/arch/x86/include/asm/cpufeature.h | 13 +- xen/arch/x86/include/asm/msr-index.h | 14 + xen/drivers/acpi/pmstat.c | 23 + xen/drivers/cpufreq/cpufreq.c | 40 ++ xen/drivers/cpufreq/utility.c | 1 + xen/include/acpi/cpufreq/cpufreq.h | 14 + xen/include/acpi/cpufreq/processor_perf.h | 4 + xen/include/acpi/pdc_intel.h | 1 + xen/include/public/sysctl.h | 57 ++ 19 files changed, 1187 insertions(+), 28 deletions(-) create mode 100644 xen/arch/x86/acpi/cpufreq/hwp.c -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:21:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:21:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528062.820617 (Exim 4.92) (envelope-from ) id 1ptZ56-00034r-75; Mon, 01 May 2023 19:21:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528062.820617; Mon, 01 May 2023 19:21:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZ56-00034k-3J; Mon, 01 May 2023 19:21:04 +0000 Received: by outflank-mailman (input) for mailman id 528062; Mon, 01 May 2023 19:21:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZ55-0002np-CQ for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:21:03 +0000 Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [2607:f8b0:4864:20::730]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4f87efd6-e855-11ed-b225-6b7b168915f2; Mon, 01 May 2023 21:21:02 +0200 (CEST) Received: by mail-qk1-x730.google.com with SMTP id af79cd13be357-75131c2997bso1448687285a.1 for ; Mon, 01 May 2023 12:21:02 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id x20-20020a0ce0d4000000b0061927ddb043sm2012307qvk.80.2023.05.01.12.21.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:21:01 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f87efd6-e855-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682968862; x=1685560862; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7VFwxnOVM/nUJWo2+kFJfbzF53GX8dfaVA+R5Uyazpc=; b=fxt+FrecoN8NG22EJ/cAh7e8No5T6QNfq9reDEVzQ7EdqNL/B6JjLggYYDL8/2v9gw rqD/WLcw8nkbQ1SUKcI+20o+Tu/W9Uiz5MTfrNtY9z5uam7qXqGBya8azNCJXqFE08Xk kbLvDoQ58GUkDwEw8Oc527I9EEPhPMQfZU+xCLzjQ1YGwAqpbGUbQaOEkMYGsHJIXH1L ySUDH5HHSwLUWEP9aC89yK74HssrIkNPdaGDzaXZuAOB0Sej6K3TDScZC/zTqYlii53O rIDA4MvVDlT7jnNZ9kdGxQgRPZdyo56FQJRUOrLxOE1Wr3NdZYkx/ZvxbQriRsaVfWG3 ku3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682968862; x=1685560862; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7VFwxnOVM/nUJWo2+kFJfbzF53GX8dfaVA+R5Uyazpc=; b=ZIfSwEFvebKWOzBAKg16cOISPs987j4sF+asXIsJaX/a5mlyTPTWd+X8ZoA6SrYOWf RzfId430GKKBf3oLhNDV5YfRkXqf77NBIu/Bk6zjHlia6YmFOCPiFds5Us1Ep95BS+xw MrJ3JFpv/RnpYAUowWU86riJkJjaf/u/oc6NXicqFwfGmb+q9VhC/P2uWoWcYpf7nj13 Jzdq6TYSz+tTbxcwAozk6lwaVv86Q1qh4XeRezihMiXXUi35K++sCcabjuaE1migZfoF SGGEvtQPZVcTY993ZxjD8CD7JnUHGLqTTi7WMWzzto1b/cgQ6iIdwzZx+amYYGzgGwm6 m+Qg== X-Gm-Message-State: AC+VfDyN6RQlOMvETukC083AAehwduDtpfEQDdC9aKGyygQh2JdYznoE GYqNURPzOfOg9nGzTv3iYR4= X-Google-Smtp-Source: ACHHUZ7GV+m0SaqcaVilE9mZSkNpsz96YrsDMORzgTpHu95CZ/am2ZJKlVW9lI3rEQAcEmBuuBN5wQ== X-Received: by 2002:a05:6214:c8c:b0:5ef:512d:2d47 with SMTP id r12-20020a0562140c8c00b005ef512d2d47mr1231450qvr.19.1682968861656; Mon, 01 May 2023 12:21:01 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproj, xen-devel@lists.xenproject.org Cc: Jason Andryuk , Jan Beulich Subject: [PATCH v3 01/14] cpufreq: Allow restricting to internal governors only Date: Mon, 1 May 2023 15:20:32 -0400 Message-Id: <20230501192045.87377-2-jandryuk@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230501192045.87377-1-jandryuk@gmail.com> References: <20230501192045.87377-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit For hwp, the standard governors are not usable, and only the internal one is applicable. Add the cpufreq_governor_internal boolean to indicate when an internal governor, like hwp-internal, will be used. This is set during presmp_initcall, so that it can suppress governor registration during initcall. Only a governor with a name containing "-internal" will be allowed in that case. This way, the unuseable governors are not registered, so the internal one is the only one returned to userspace. This means incompatible governors won't be advertised to userspace. Signed-off-by: Jason Andryuk Acked-by: Jan Beulich --- v3: Switch to initdata Add Jan Acked-by Commit message s/they/the/ typo Don't register hwp-internal when running non-hwp - Marek v2: Switch to "-internal" Add blank line in header --- xen/drivers/cpufreq/cpufreq.c | 8 ++++++++ xen/include/acpi/cpufreq/cpufreq.h | 2 ++ 2 files changed, 10 insertions(+) diff --git a/xen/drivers/cpufreq/cpufreq.c b/xen/drivers/cpufreq/cpufreq.c index 2321c7dd07..7bd81680da 100644 --- a/xen/drivers/cpufreq/cpufreq.c +++ b/xen/drivers/cpufreq/cpufreq.c @@ -56,6 +56,7 @@ struct cpufreq_dom { }; static LIST_HEAD_READ_MOSTLY(cpufreq_dom_list_head); +bool __initdata cpufreq_governor_internal; struct cpufreq_governor *__read_mostly cpufreq_opt_governor; LIST_HEAD_READ_MOSTLY(cpufreq_governor_list); @@ -121,6 +122,13 @@ int __init cpufreq_register_governor(struct cpufreq_governor *governor) if (!governor) return -EINVAL; + if (cpufreq_governor_internal && + strstr(governor->name, "-internal") == NULL) + return -EINVAL; + + if (!cpufreq_governor_internal && strstr(governor->name, "-internal")) + return -EINVAL; + if (__find_governor(governor->name) != NULL) return -EEXIST; diff --git a/xen/include/acpi/cpufreq/cpufreq.h b/xen/include/acpi/cpufreq/cpufreq.h index 35dcf21e8f..0da32ef519 100644 --- a/xen/include/acpi/cpufreq/cpufreq.h +++ b/xen/include/acpi/cpufreq/cpufreq.h @@ -114,6 +114,8 @@ extern struct cpufreq_governor cpufreq_gov_userspace; extern struct cpufreq_governor cpufreq_gov_performance; extern struct cpufreq_governor cpufreq_gov_powersave; +extern bool cpufreq_governor_internal; + extern struct list_head cpufreq_governor_list; extern int cpufreq_register_governor(struct cpufreq_governor *governor); -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:21:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:21:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528063.820627 (Exim 4.92) (envelope-from ) id 1ptZ5A-0003MU-D4; Mon, 01 May 2023 19:21:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528063.820627; Mon, 01 May 2023 19:21:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZ5A-0003ML-AI; Mon, 01 May 2023 19:21:08 +0000 Received: by outflank-mailman (input) for mailman id 528063; Mon, 01 May 2023 19:21:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZ58-0002np-O4 for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:21:06 +0000 Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [2607:f8b0:4864:20::730]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 518ff36a-e855-11ed-b225-6b7b168915f2; Mon, 01 May 2023 21:21:06 +0200 (CEST) Received: by mail-qk1-x730.google.com with SMTP id af79cd13be357-74fb8677a36so133678885a.0 for ; Mon, 01 May 2023 12:21:06 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id x20-20020a0ce0d4000000b0061927ddb043sm2012307qvk.80.2023.05.01.12.21.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:21:04 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 518ff36a-e855-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682968865; x=1685560865; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=txBzmZlgf2a5ZApasbIDD2P8VUrWanxh/ZCZKapkSd4=; b=hnzzQkqw6iB4TnpMVolsM/d8tA0cLpu0rYq2RmzA5nHVBJa6VHBWbPjqIW0uCmQTUp sTHTPdiaSED7oKPvQeLQsKAATgCljdsn+MCz/RG6kH2ypD7ZqbfMoY6R0HGTi4r8sbJa vLXsFsL7O59YaDIhrpdY8gTEK7MrfC07APLJ70wAJkXqatxHLhrAJYYx5RT+v3jM+9mF 9rPC6jdrwvxBkIzcvDFk0czEXPAxtnVqYbEwo01XNdS6hA8AhE7gWz0u4GUIzitKoSib slFFJidmyr7rrVuZnj5teD6sjEbvDofZD+sEdBlTlhwKt1Ce80m/sho+QJMXIot4qpnK l7sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682968865; x=1685560865; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=txBzmZlgf2a5ZApasbIDD2P8VUrWanxh/ZCZKapkSd4=; b=V8vp370i1PknhVmIhkzfuvNks4vnELh2lTUgXZVLmBlvtvuGO6lL8vZLUmez9X2CT6 2Vf54AU+OJhx1xUUySHYqZSrVBCn4OGXYIxaP5hAIJbJTpIb4pFfBYY9Mo7OEllaMAZc Tx5gAFITi17+vSIu5NAt4VNtsEEJjvLMlRzueRxVb59RU/WQ1cQZq1N4SnCf5hRiK4L3 442dV7SbSJRs4uldLLv31Tx+UYFfUuvG8jHGJyp77jV5V9Xx8DNfOUPUjt7+86JCTDwy PcYYcMc8BgNCQZ/XFhg2B2rlXygXyraPU5S5MLz9yxFhAwUL7g3MBT6snvLI8IBTLemp 6IAQ== X-Gm-Message-State: AC+VfDwluYVv3DIRT/UivgmMNO+rRj8OeSLjyF5l6jSsZ3OBWjzFWqi/ TsAwtVnwhLWdbAcI079ZKQI= X-Google-Smtp-Source: ACHHUZ417cxCd/vqsbSp93kURkQVEsMZjpcjAt0WtKYiNB7H5wmUcdd/cQhBwm4ZtrgjNj2q+ozWzw== X-Received: by 2002:a05:6214:c4c:b0:5ef:83cf:91c2 with SMTP id r12-20020a0562140c4c00b005ef83cf91c2mr1729663qvj.45.1682968865210; Mon, 01 May 2023 12:21:05 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproj, xen-devel@lists.xenproject.org Cc: Jason Andryuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v3 02/14] cpufreq: Add perf_freq to cpuinfo Date: Mon, 1 May 2023 15:20:33 -0400 Message-Id: <20230501192045.87377-3-jandryuk@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230501192045.87377-1-jandryuk@gmail.com> References: <20230501192045.87377-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit acpi-cpufreq scales the aperf/mperf measurements by max_freq, but HWP needs to scale by base frequency. Settings max_freq to base_freq "works" but the code is not obvious, and returning values to userspace is tricky. Add an additonal perf_freq member which is used for scaling aperf/mperf measurements. Signed-off-by: Jason Andryuk Acked-by: Jan Beulich --- v3: Add Jan's Ack I don't like this, but it seems the best way to re-use the common aperf/mperf code. The other option would be to add wrappers that then do the acpi vs. hwp scaling. --- xen/arch/x86/acpi/cpufreq/cpufreq.c | 2 +- xen/drivers/cpufreq/utility.c | 1 + xen/include/acpi/cpufreq/cpufreq.h | 3 +++ 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/acpi/cpufreq/cpufreq.c b/xen/arch/x86/acpi/cpufreq/cpufreq.c index 2e0067fbe5..6c70d04395 100644 --- a/xen/arch/x86/acpi/cpufreq/cpufreq.c +++ b/xen/arch/x86/acpi/cpufreq/cpufreq.c @@ -316,7 +316,7 @@ unsigned int get_measured_perf(unsigned int cpu, unsigned int flag) else perf_percent = 0; - return policy->cpuinfo.max_freq * perf_percent / 100; + return policy->cpuinfo.perf_freq * perf_percent / 100; } static unsigned int cf_check get_cur_freq_on_cpu(unsigned int cpu) diff --git a/xen/drivers/cpufreq/utility.c b/xen/drivers/cpufreq/utility.c index 9eb7ecedcd..6831f62851 100644 --- a/xen/drivers/cpufreq/utility.c +++ b/xen/drivers/cpufreq/utility.c @@ -236,6 +236,7 @@ int cpufreq_frequency_table_cpuinfo(struct cpufreq_policy *policy, policy->min = policy->cpuinfo.min_freq = min_freq; policy->max = policy->cpuinfo.max_freq = max_freq; + policy->cpuinfo.perf_freq = max_freq; policy->cpuinfo.second_max_freq = second_max_freq; if (policy->min == ~0) diff --git a/xen/include/acpi/cpufreq/cpufreq.h b/xen/include/acpi/cpufreq/cpufreq.h index 0da32ef519..a06aa92f62 100644 --- a/xen/include/acpi/cpufreq/cpufreq.h +++ b/xen/include/acpi/cpufreq/cpufreq.h @@ -37,6 +37,9 @@ extern struct acpi_cpufreq_data *cpufreq_drv_data[NR_CPUS]; struct cpufreq_cpuinfo { unsigned int max_freq; unsigned int second_max_freq; /* P1 if Turbo Mode is on */ + unsigned int perf_freq; /* Scaling freq for aperf/mpref. + acpi-cpufreq uses max_freq, but HWP uses + base_freq.*/ unsigned int min_freq; unsigned int transition_latency; /* in 10^(-9) s = nanoseconds */ }; -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:21:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:21:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528064.820637 (Exim 4.92) (envelope-from ) id 1ptZ5D-0003eO-Nh; Mon, 01 May 2023 19:21:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528064.820637; Mon, 01 May 2023 19:21:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZ5D-0003eF-K7; Mon, 01 May 2023 19:21:11 +0000 Received: by outflank-mailman (input) for mailman id 528064; Mon, 01 May 2023 19:21:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZ5C-0002np-B7 for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:21:10 +0000 Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [2607:f8b0:4864:20::735]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 53a88cf9-e855-11ed-b225-6b7b168915f2; Mon, 01 May 2023 21:21:09 +0200 (CEST) Received: by mail-qk1-x735.google.com with SMTP id af79cd13be357-7515631b965so673368285a.0 for ; Mon, 01 May 2023 12:21:09 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id x20-20020a0ce0d4000000b0061927ddb043sm2012307qvk.80.2023.05.01.12.21.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:21:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 53a88cf9-e855-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682968869; x=1685560869; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H9MXL508WAYhYYKIHs8d77jkKwZyoTe/WztjxZedAQ8=; b=rq0DvyOB5DfwmfNuwRvzir/PEUW4Q7Y7tqorFvzYUK9HQUsaW9yTveOdaSqHQszeGL jiHsrz5gRbbu3FwfmQLHNbPYDkloR8iXpYmZVMUNv2hNSzj2hJXttzAZO8x07fI705gn jEjQ0VogRFH3rkilyFMTeqorC6HRMiwrrdxRzNpgb/+UO1MRDIOj5z9QG6Z4oXYiBO19 pjtMBMhUGnFJh8mxInOdnvtei4CDIzG9sBwjryXnb6D0yA5/VK4QjvlalXEMDkEC8QcR LDYdb/AzkiKUFK1+YA8RUoc8TmDoG93/ulnV+j4qPQ5kzJhPSQCdGnQXYqSlLZjtIUXl Qzeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682968869; x=1685560869; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H9MXL508WAYhYYKIHs8d77jkKwZyoTe/WztjxZedAQ8=; b=U0ezniXveMf1m1cRbCjB7AkO45yWgq1pvxcN7SuYUWKwpXLcAtAaY1g9hyikCgNUi/ dF0vqvLQyxeUvQXK3nlRyxMnQr157eU4/xRetceDVFptrZfjHY66M3SjHajrXCvqjle8 DIC8pvOFxbY9+vhTd2+qxMPFZ1k6Az4nkDNpWVz9rnqwKunBpmYSCg3xrYXh+0j3YZBQ 6vwVGpS1ejaRZVw6KV2mY8q+HRxoIqsV/TJHulx46RJJJvDW1xXlgzUwcMyShQ1a8x/K N+UXwH9C0Ca5UmWhfu7Ush7FmaVc6bMMhxIAkTdwfS7nPTIziAB+H/ku0Ru1zSDX99FB I0Zg== X-Gm-Message-State: AC+VfDxvdOinF02xc+MIvacBMiF9feDAUoDYFTTTXtNMAwSd6bBNkhZV WpOfR5ekxOLY4jg3G0SquUo= X-Google-Smtp-Source: ACHHUZ52fJMB7p3+z00UEHeNT6H5lQjNgXa9HJUz0dTy7X0df51pnNMHSDMMqDjFDxxrpToBKZMY8g== X-Received: by 2002:a05:6214:23cc:b0:572:6e81:ae9c with SMTP id hr12-20020a05621423cc00b005726e81ae9cmr1857350qvb.1.1682968868683; Mon, 01 May 2023 12:21:08 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproj, xen-devel@lists.xenproject.org Cc: Jason Andryuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v3 03/14] cpufreq: Export intel_feature_detect Date: Mon, 1 May 2023 15:20:34 -0400 Message-Id: <20230501192045.87377-4-jandryuk@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230501192045.87377-1-jandryuk@gmail.com> References: <20230501192045.87377-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Export feature_detect as intel_feature_detect so it can be re-used by HWP. Signed-off-by: Jason Andryuk --- v3: Remove void * cast when calling intel_feature_detect v2: export intel_feature_detect with typed pointer Move intel_feature_detect to acpi/cpufreq/cpufreq.h since the declaration now contains struct cpufreq_policy *. --- xen/arch/x86/acpi/cpufreq/cpufreq.c | 8 ++++++-- xen/include/acpi/cpufreq/cpufreq.h | 2 ++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/acpi/cpufreq/cpufreq.c b/xen/arch/x86/acpi/cpufreq/cpufreq.c index 6c70d04395..f1cc473b4f 100644 --- a/xen/arch/x86/acpi/cpufreq/cpufreq.c +++ b/xen/arch/x86/acpi/cpufreq/cpufreq.c @@ -339,9 +339,8 @@ static unsigned int cf_check get_cur_freq_on_cpu(unsigned int cpu) return extract_freq(get_cur_val(cpumask_of(cpu)), data); } -static void cf_check feature_detect(void *info) +void intel_feature_detect(struct cpufreq_policy *policy) { - struct cpufreq_policy *policy = info; unsigned int eax; eax = cpuid_eax(6); @@ -353,6 +352,11 @@ static void cf_check feature_detect(void *info) } } +static void cf_check feature_detect(void *info) +{ + intel_feature_detect(info); +} + static unsigned int check_freqs(const cpumask_t *mask, unsigned int freq, struct acpi_cpufreq_data *data) { diff --git a/xen/include/acpi/cpufreq/cpufreq.h b/xen/include/acpi/cpufreq/cpufreq.h index a06aa92f62..0f334d2a43 100644 --- a/xen/include/acpi/cpufreq/cpufreq.h +++ b/xen/include/acpi/cpufreq/cpufreq.h @@ -243,4 +243,6 @@ int write_userspace_scaling_setspeed(unsigned int cpu, unsigned int freq); void cpufreq_dbs_timer_suspend(void); void cpufreq_dbs_timer_resume(void); +void intel_feature_detect(struct cpufreq_policy *policy); + #endif /* __XEN_CPUFREQ_PM_H__ */ -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:21:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:21:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528065.820647 (Exim 4.92) (envelope-from ) id 1ptZ5K-00041W-2F; Mon, 01 May 2023 19:21:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528065.820647; Mon, 01 May 2023 19:21:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZ5J-00041N-TM; Mon, 01 May 2023 19:21:17 +0000 Received: by outflank-mailman (input) for mailman id 528065; Mon, 01 May 2023 19:21:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZ5I-0003yM-91 for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:21:16 +0000 Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [2607:f8b0:4864:20::f2d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 559e417b-e855-11ed-8611-37d641c3527e; Mon, 01 May 2023 21:21:13 +0200 (CEST) Received: by mail-qv1-xf2d.google.com with SMTP id 6a1803df08f44-61b5a6865dfso8720006d6.3 for ; Mon, 01 May 2023 12:21:13 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id x20-20020a0ce0d4000000b0061927ddb043sm2012307qvk.80.2023.05.01.12.21.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:21:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 559e417b-e855-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682968872; x=1685560872; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Hym2Jx5Z8r7rrhqAfu+8xxIV/nnrCdXHwFgph7V69FQ=; b=fGoIO+6qsbtKMFPSgN0i4Zavvb5MTnhhdqp8CeKrIMwrWVUoGzsS5GUMU3+Vf/BqaK vwExJ3rn+DHp4vhn7EgJIimziO/yBOwa9nYWdkh9s2/iGTkofXrSa2J3+pJQVNEi70vQ 9NoO/vP3pduE9AZow9+Q+ioOJRnST09uH6SvlQQOhIftyDKMET4CLUxaeV0aQPuOYnHW JByxXuaAkZf8rc6KIGViImcm3TCKJwiKT/wjVmLGWLl4npF/XU3/cPhAo3jQTwctqHfj XAeyll9kEcP3rK6l0/CWTUG24Y3NObIfxdL0RryyhEGH41d8fWxJ+/xDoXWUs3qOj3ux 1qkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682968872; x=1685560872; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Hym2Jx5Z8r7rrhqAfu+8xxIV/nnrCdXHwFgph7V69FQ=; b=eLUNg4WDMCt7yT6IdEEbWtdKHNXmPUOZRmtqnsm7MCn+qZm3U+rTyyXXQBAKtbNOUH IWBL2WqgEbHaGK45z55iqv4vFctMC0YrgcZmlaUvxgXAeomHoxQrJK9LFTGl07TCJ9+i n4LJ1gLlvoKKmTjP1FJRVD/n9oqjvDLyhSHZOfn/cy+5vGOVRpm8TyEFui74vWzbs/pq Qvune/P06c7AHGuwrPlIvrlt6gjBY0BWySQARKY71byPzgM3/RuG/lg4nrK1lA3XrPdX p1i/kB2RToR44Pj0jExsiuRxE9Lut3CF8Oz8C4lXKkRnPxEU6ppmb6xmFli64n+3pc5D GFbQ== X-Gm-Message-State: AC+VfDxLNGdowL6tHAhU5RdiRVqmcDCJNfA/uWZxkyfZA/Q0EtqRci7g RMMAk7boPh/OnXejiq3qhPQ= X-Google-Smtp-Source: ACHHUZ681CkprnN+PnfFwou1vy3oW/3SYrpP7yKOkM9VljtTjTR/9pSDCq4Yp2i9BWpKWV0sPzdLVQ== X-Received: by 2002:ad4:5aeb:0:b0:61a:43f0:7305 with SMTP id c11-20020ad45aeb000000b0061a43f07305mr1682385qvh.35.1682968871742; Mon, 01 May 2023 12:21:11 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproj, xen-devel@lists.xenproject.org Cc: Jason Andryuk , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v3 04/14] cpufreq: Add Hardware P-State (HWP) driver Date: Mon, 1 May 2023 15:20:35 -0400 Message-Id: <20230501192045.87377-5-jandryuk@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230501192045.87377-1-jandryuk@gmail.com> References: <20230501192045.87377-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit >From the Intel SDM: "Hardware-Controlled Performance States (HWP), which autonomously selects performance states while utilizing OS supplied performance guidance hints." Enable HWP to run in autonomous mode by poking the correct MSRs. cpufreq=xen:hwp enables and cpufreq=xen:hwp=0 disables. The same for hdc. There is no interface to configure - xen_sysctl_pm_op/xenpm will be to be extended to configure in subsequent patches. It will run with the default values, which should be the default 0x80 (out of 0x0-0xff) energy/performance preference. Unscientific powertop measurement of an mostly idle, customized OpenXT install: A 10th gen 6-core laptop showed battery discharge drop from ~9.x to ~7.x watts. A 8th gen 4-core laptop dropped from ~10 to ~9 Power usage depends on many factors, especially display brightness, but this does show an power saving in balanced mode when CPU utilization is low. HWP isn't compatible with an external governor - it doesn't take explicit frequency requests. Therefore a minimal internal governor, hwp-internal, is also added as a placeholder. While adding to the xen-command-line.pandoc entry, un-nest verbose from minfreq. They are independent. Signed-off-by: Jason Andryuk --- We disable on cpuid_level < 0x16. cpuid(0x16) is used to get the cpu frequencies for calculating the APERF/MPERF. Without it, things would still work, but the averge cpufrequency output would be wrong. My 8th & 10th gen test systems both report: (XEN) HWP: 1 notify: 1 act_window: 1 energy_perf: 1 pkg_level: 0 peci: 0 (XEN) HWP: Hardware Duty Cycling (HDC) supported (XEN) HWP: HW_FEEDBACK not supported IA32_ENERGY_PERF_BIAS has not been tested. For cpufreq=xen:hwp, placing the option inside the governor wouldn't work. Users would have to select the hwp-internal governor to turn off hwp support. hwp-internal isn't usable without hwp, and users wouldn't be able to select a different governor. That doesn't matter while hwp defaults off, but it would if or when hwp defaults to enabled. We can't use parse_boolean() since it requires a single name=val string and cpufreq_handle_common_option is provided two strings. Use parse_bool() and manual handle no-hwp. Write to disable the interrupt - the linux pstate driver does this. We don't use the interrupts, so we can just turn them off. We aren't ready to handle them, so we don't want any. Unclear if this is necessary. SDM says it's default disabled. FAST_IA32_HWP_REQUEST was removed in v2. The check in v1 was wrong, it's a model specific feature and the CPUID bit is only available after enabling via the MSR. Support was untested since I don't have hardware with the feature. Writes are expected to be infrequent, so just leave it out. --- v2: Alphabetize headers Re-work driver registration name hwp_drv_data anonymous union "hw" Drop hwp_verbose_cont style cleanups Condense hwp_governor switch hwp_cpufreq_target remove .raw from hwp_req assignment Use typed-pointer in a few functions Pass type to xzalloc Add HWP_ENERGY_PERF_BALANCE/IA32_ENERGY_BIAS_BALANCE defines Add XEN_HWP_GOVERNOR define for "hwp-internal" Capitalize CPUID and MSR defines Change '_' to '-' for energy-perf & act-window Read-modify-write MSRs updates Use FAST_IA32_HWP_REQUEST_MSR_ENABLE define constify pointer in hwp_set_misc_turbo Add space after non-fallthrough break in governor switch Add IA32_ENERGY_BIAS_MASK define Check CPUID_PM_LEAK for energy bias when needed Fail initialization with curr_req = -1 Fold hwp_read_capabilities into hwp_init_msrs Add command line cpufreq=xen:hwp Add command line cpufreq=xen:hdc Use per_cpu for hwp_drv_data pointers Move hwp_energy_perf_bias call into hwp_write_request energy_perf 0 is valid, so hwp_energy_perf_bias cannot be skipped Ensure we don't generate interrupts Remove Fast Write of Uncore MSR Initialize hwp_drv_data from curr_req Use SPDX line instead of license text in hwp.c v3: Add cf_check to cpufreq_gov_hwp_init() - Marek Print cpuid_level with %#x - Marek --- docs/misc/xen-command-line.pandoc | 8 +- xen/arch/x86/acpi/cpufreq/Makefile | 1 + xen/arch/x86/acpi/cpufreq/cpufreq.c | 5 +- xen/arch/x86/acpi/cpufreq/hwp.c | 506 ++++++++++++++++++++++ xen/arch/x86/include/asm/cpufeature.h | 13 +- xen/arch/x86/include/asm/msr-index.h | 13 + xen/drivers/cpufreq/cpufreq.c | 32 ++ xen/include/acpi/cpufreq/cpufreq.h | 3 + xen/include/acpi/cpufreq/processor_perf.h | 3 + xen/include/public/sysctl.h | 1 + 10 files changed, 581 insertions(+), 4 deletions(-) create mode 100644 xen/arch/x86/acpi/cpufreq/hwp.c diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index e0b89b7d33..aaa31f444b 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -499,7 +499,7 @@ If set, force use of the performance counters for oprofile, rather than detectin available support. ### cpufreq -> `= none | {{ | xen } [:[powersave|performance|ondemand|userspace][,][,[][,[verbose]]]]} | dom0-kernel` +> `= none | {{ | xen } [:[powersave|performance|ondemand|userspace][,][,[]][,[]][,[]][,[verbose]]]} | dom0-kernel` > Default: `xen` @@ -510,6 +510,12 @@ choice of `dom0-kernel` is deprecated and not supported by all Dom0 kernels. * `` and `` are integers which represent max and min processor frequencies respectively. * `verbose` option can be included as a string or also as `verbose=` +* `` is a boolean to enable Hardware-Controlled Performance States (HWP) + on supported Intel hardware. HWP is a Skylake+ feature which provides better + CPU power management. The default is disabled. +* `` is a boolean to enable Hardware Duty Cycling (HDC). HDC enables the + processor to autonomously force physical package components into idle state. + The default is enabled, but the option only applies when `` is enabled. ### cpuid (x86) > `= List of comma separated booleans` diff --git a/xen/arch/x86/acpi/cpufreq/Makefile b/xen/arch/x86/acpi/cpufreq/Makefile index f75da9b9ca..db83aa6b14 100644 --- a/xen/arch/x86/acpi/cpufreq/Makefile +++ b/xen/arch/x86/acpi/cpufreq/Makefile @@ -1,2 +1,3 @@ obj-y += cpufreq.o +obj-y += hwp.o obj-y += powernow.o diff --git a/xen/arch/x86/acpi/cpufreq/cpufreq.c b/xen/arch/x86/acpi/cpufreq/cpufreq.c index f1cc473b4f..56816b1aee 100644 --- a/xen/arch/x86/acpi/cpufreq/cpufreq.c +++ b/xen/arch/x86/acpi/cpufreq/cpufreq.c @@ -642,7 +642,10 @@ static int __init cf_check cpufreq_driver_init(void) switch ( boot_cpu_data.x86_vendor ) { case X86_VENDOR_INTEL: - ret = cpufreq_register_driver(&acpi_cpufreq_driver); + if ( hwp_available() ) + ret = hwp_register_driver(); + else + ret = cpufreq_register_driver(&acpi_cpufreq_driver); break; case X86_VENDOR_AMD: diff --git a/xen/arch/x86/acpi/cpufreq/hwp.c b/xen/arch/x86/acpi/cpufreq/hwp.c new file mode 100644 index 0000000000..57f13867d3 --- /dev/null +++ b/xen/arch/x86/acpi/cpufreq/hwp.c @@ -0,0 +1,506 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * hwp.c cpufreq driver to run Intel Hardware P-States (HWP) + * + * Copyright (C) 2021 Jason Andryuk + */ + +#include +#include +#include +#include +#include +#include +#include + +static bool feature_hwp; +static bool feature_hwp_notification; +static bool feature_hwp_activity_window; +static bool feature_hwp_energy_perf; +static bool feature_hwp_pkg_level_ctl; +static bool feature_hwp_peci; + +static bool feature_hdc; + +__initdata bool opt_cpufreq_hwp = false; +__initdata bool opt_cpufreq_hdc = true; + +#define HWP_ENERGY_PERF_BALANCE 0x80 +#define IA32_ENERGY_BIAS_BALANCE 0x7 +#define IA32_ENERGY_BIAS_MAX_POWERSAVE 0xf +#define IA32_ENERGY_BIAS_MASK 0xf + +union hwp_request +{ + struct + { + uint64_t min_perf:8; + uint64_t max_perf:8; + uint64_t desired:8; + uint64_t energy_perf:8; + uint64_t activity_window:10; + uint64_t package_control:1; + uint64_t reserved:16; + uint64_t activity_window_valid:1; + uint64_t energy_perf_valid:1; + uint64_t desired_valid:1; + uint64_t max_perf_valid:1; + uint64_t min_perf_valid:1; + }; + uint64_t raw; +}; + +struct hwp_drv_data +{ + union + { + uint64_t hwp_caps; + struct + { + uint64_t highest:8; + uint64_t guaranteed:8; + uint64_t most_efficient:8; + uint64_t lowest:8; + uint64_t reserved:32; + } hw; + }; + union hwp_request curr_req; + uint16_t activity_window; + uint8_t minimum; + uint8_t maximum; + uint8_t desired; + uint8_t energy_perf; +}; +DEFINE_PER_CPU_READ_MOSTLY(struct hwp_drv_data *, hwp_drv_data); + +#define hwp_err(...) printk(XENLOG_ERR __VA_ARGS__) +#define hwp_info(...) printk(XENLOG_INFO __VA_ARGS__) +#define hwp_verbose(...) \ +({ \ + if ( cpufreq_verbose ) \ + printk(XENLOG_DEBUG __VA_ARGS__); \ +}) + +static int cf_check hwp_governor(struct cpufreq_policy *policy, + unsigned int event) +{ + int ret; + + if ( policy == NULL ) + return -EINVAL; + + switch ( event ) + { + case CPUFREQ_GOV_START: + case CPUFREQ_GOV_LIMITS: + ret = 0; + break; + + case CPUFREQ_GOV_STOP: + default: + ret = -EINVAL; + break; + } + + return ret; +} + +static struct cpufreq_governor hwp_cpufreq_governor = +{ + .name = XEN_HWP_GOVERNOR, + .governor = hwp_governor, +}; + +static int __init cf_check cpufreq_gov_hwp_init(void) +{ + return cpufreq_register_governor(&hwp_cpufreq_governor); +} +__initcall(cpufreq_gov_hwp_init); + +bool __init hwp_available(void) +{ + unsigned int eax, ecx, unused; + bool use_hwp; + + if ( boot_cpu_data.cpuid_level < CPUID_PM_LEAF ) + { + hwp_verbose("cpuid_level (%#x) lacks HWP support\n", + boot_cpu_data.cpuid_level); + return false; + } + + if ( boot_cpu_data.cpuid_level < 0x16 ) + { + hwp_info("HWP disabled: cpuid_level %#x < 0x16 lacks CPU freq info\n", + boot_cpu_data.cpuid_level); + return false; + } + + cpuid(CPUID_PM_LEAF, &eax, &unused, &ecx, &unused); + + if ( !(eax & CPUID6_EAX_HWP_ENERGY_PERFORMANCE_PREFERENCE) && + !(ecx & CPUID6_ECX_IA32_ENERGY_PERF_BIAS) ) + { + hwp_verbose("HWP disabled: No energy/performance preference available"); + return false; + } + + feature_hwp = eax & CPUID6_EAX_HWP; + feature_hwp_notification = eax & CPUID6_EAX_HWP_NOTIFICATION; + feature_hwp_activity_window = eax & CPUID6_EAX_HWP_ACTIVITY_WINDOW; + feature_hwp_energy_perf = + eax & CPUID6_EAX_HWP_ENERGY_PERFORMANCE_PREFERENCE; + feature_hwp_pkg_level_ctl = eax & CPUID6_EAX_HWP_PACKAGE_LEVEL_REQUEST; + feature_hwp_peci = eax & CPUID6_EAX_HWP_PECI; + + hwp_verbose("HWP: %d notify: %d act-window: %d energy-perf: %d pkg-level: %d peci: %d\n", + feature_hwp, feature_hwp_notification, + feature_hwp_activity_window, feature_hwp_energy_perf, + feature_hwp_pkg_level_ctl, feature_hwp_peci); + + if ( !feature_hwp ) + return false; + + feature_hdc = eax & CPUID6_EAX_HDC; + + hwp_verbose("HWP: Hardware Duty Cycling (HDC) %ssupported%s\n", + feature_hdc ? "" : "not ", + feature_hdc ? opt_cpufreq_hdc ? ", enabled" : ", disabled" + : ""); + + feature_hdc = feature_hdc && opt_cpufreq_hdc; + + hwp_verbose("HWP: HW_FEEDBACK %ssupported\n", + (eax & CPUID6_EAX_HW_FEEDBACK) ? "" : "not "); + + use_hwp = feature_hwp && opt_cpufreq_hwp; + cpufreq_governor_internal = use_hwp; + + if ( use_hwp ) + hwp_info("Using HWP for cpufreq\n"); + + return use_hwp; +} + +static void hdc_set_pkg_hdc_ctl(bool val) +{ + uint64_t msr; + + if ( rdmsr_safe(MSR_IA32_PKG_HDC_CTL, msr) ) + { + hwp_err("error rdmsr_safe(MSR_IA32_PKG_HDC_CTL)\n"); + + return; + } + + if ( val ) + msr |= IA32_PKG_HDC_CTL_HDC_PKG_ENABLE; + else + msr &= ~IA32_PKG_HDC_CTL_HDC_PKG_ENABLE; + + if ( wrmsr_safe(MSR_IA32_PKG_HDC_CTL, msr) ) + hwp_err("error wrmsr_safe(MSR_IA32_PKG_HDC_CTL): %016lx\n", msr); +} + +static void hdc_set_pm_ctl1(bool val) +{ + uint64_t msr; + + if ( rdmsr_safe(MSR_IA32_PM_CTL1, msr) ) + { + hwp_err("error rdmsr_safe(MSR_IA32_PM_CTL1)\n"); + + return; + } + + if ( val ) + msr |= IA32_PM_CTL1_HDC_ALLOW_BLOCK; + else + msr &= ~IA32_PM_CTL1_HDC_ALLOW_BLOCK; + + if ( wrmsr_safe(MSR_IA32_PM_CTL1, msr) ) + hwp_err("error wrmsr_safe(MSR_IA32_PM_CTL1): %016lx\n", msr); +} + +static void hwp_get_cpu_speeds(struct cpufreq_policy *policy) +{ + uint32_t base_khz, max_khz, bus_khz, edx; + + cpuid(0x16, &base_khz, &max_khz, &bus_khz, &edx); + + /* aperf/mperf scales base. */ + policy->cpuinfo.perf_freq = base_khz * 1000; + policy->cpuinfo.min_freq = base_khz * 1000; + policy->cpuinfo.max_freq = max_khz * 1000; + policy->min = base_khz * 1000; + policy->max = max_khz * 1000; + policy->cur = 0; +} + +static void cf_check hwp_init_msrs(void *info) +{ + struct cpufreq_policy *policy = info; + struct hwp_drv_data *data = this_cpu(hwp_drv_data); + uint64_t val; + + /* + * Package level MSR, but we don't have a good idea of packages here, so + * just do it everytime. + */ + if ( rdmsr_safe(MSR_IA32_PM_ENABLE, val) ) + { + hwp_err("CPU%u: error rdmsr_safe(MSR_IA32_PM_ENABLE)\n", policy->cpu); + data->curr_req.raw = -1; + return; + } + + /* Ensure we don't generate interrupts */ + if ( feature_hwp_notification ) + wrmsr_safe(MSR_IA32_HWP_INTERRUPT, 0); + + hwp_verbose("CPU%u: MSR_IA32_PM_ENABLE: %016lx\n", policy->cpu, val); + if ( !(val & IA32_PM_ENABLE_HWP_ENABLE) ) + { + val |= IA32_PM_ENABLE_HWP_ENABLE; + if ( wrmsr_safe(MSR_IA32_PM_ENABLE, val) ) + { + hwp_err("CPU%u: error wrmsr_safe(MSR_IA32_PM_ENABLE, %lx)\n", + policy->cpu, val); + data->curr_req.raw = -1; + return; + } + } + + if ( rdmsr_safe(MSR_IA32_HWP_CAPABILITIES, data->hwp_caps) ) + { + hwp_err("CPU%u: error rdmsr_safe(MSR_IA32_HWP_CAPABILITIES)\n", + policy->cpu); + data->curr_req.raw = -1; + return; + } + + if ( rdmsr_safe(MSR_IA32_HWP_REQUEST, data->curr_req.raw) ) + { + hwp_err("CPU%u: error rdmsr_safe(MSR_IA32_HWP_REQUEST)\n", policy->cpu); + data->curr_req.raw = -1; + return; + } + + if ( !feature_hwp_energy_perf ) { + if ( rdmsr_safe(MSR_IA32_ENERGY_PERF_BIAS, val) ) + { + hwp_err("error rdmsr_safe(MSR_IA32_ENERGY_PERF_BIAS)\n"); + data->curr_req.raw = -1; + + return; + } + + data->energy_perf = val & IA32_ENERGY_BIAS_MASK; + } + + /* + * Check for APERF/MPERF support in hardware + * also check for boost/turbo support + */ + intel_feature_detect(policy); + + if ( feature_hdc ) + { + hdc_set_pkg_hdc_ctl(true); + hdc_set_pm_ctl1(true); + } + + hwp_get_cpu_speeds(policy); +} + +static int cf_check hwp_cpufreq_verify(struct cpufreq_policy *policy) +{ + struct hwp_drv_data *data = per_cpu(hwp_drv_data, policy->cpu); + + if ( !feature_hwp_energy_perf && data->energy_perf ) + { + if ( data->energy_perf > IA32_ENERGY_BIAS_MAX_POWERSAVE ) + { + hwp_err("energy_perf %d exceeds IA32_ENERGY_PERF_BIAS range 0-15\n", + data->energy_perf); + + return -EINVAL; + } + } + + if ( !feature_hwp_activity_window && data->activity_window ) + { + hwp_err("HWP activity window not supported\n"); + + return -EINVAL; + } + + return 0; +} + +/* val 0 - highest performance, 15 - maximum energy savings */ +static void hwp_energy_perf_bias(const struct hwp_drv_data *data) +{ + uint64_t msr; + uint8_t val = data->energy_perf; + + ASSERT(val <= IA32_ENERGY_BIAS_MAX_POWERSAVE); + + if ( rdmsr_safe(MSR_IA32_ENERGY_PERF_BIAS, msr) ) + { + hwp_err("error rdmsr_safe(MSR_IA32_ENERGY_PERF_BIAS)\n"); + + return; + } + + msr &= ~IA32_ENERGY_BIAS_MASK; + msr |= val; + + if ( wrmsr_safe(MSR_IA32_ENERGY_PERF_BIAS, msr) ) + hwp_err("error wrmsr_safe(MSR_IA32_ENERGY_PERF_BIAS): %016lx\n", msr); +} + +static void cf_check hwp_write_request(void *info) +{ + struct cpufreq_policy *policy = info; + struct hwp_drv_data *data = this_cpu(hwp_drv_data); + union hwp_request hwp_req = data->curr_req; + + BUILD_BUG_ON(sizeof(union hwp_request) != sizeof(uint64_t)); + if ( wrmsr_safe(MSR_IA32_HWP_REQUEST, hwp_req.raw) ) + { + hwp_err("CPU%u: error wrmsr_safe(MSR_IA32_HWP_REQUEST, %lx)\n", + policy->cpu, hwp_req.raw); + rdmsr_safe(MSR_IA32_HWP_REQUEST, data->curr_req.raw); + } + + if ( !feature_hwp_energy_perf ) + hwp_energy_perf_bias(data); + +} + +static int cf_check hwp_cpufreq_target(struct cpufreq_policy *policy, + unsigned int target_freq, + unsigned int relation) +{ + unsigned int cpu = policy->cpu; + struct hwp_drv_data *data = per_cpu(hwp_drv_data, cpu); + /* Zero everything to ensure reserved bits are zero... */ + union hwp_request hwp_req = { .raw = 0 }; + + /* .. and update from there */ + hwp_req.min_perf = data->minimum; + hwp_req.max_perf = data->maximum; + hwp_req.desired = data->desired; + if ( feature_hwp_energy_perf ) + hwp_req.energy_perf = data->energy_perf; + if ( feature_hwp_activity_window ) + hwp_req.activity_window = data->activity_window; + + if ( hwp_req.raw == data->curr_req.raw ) + return 0; + + data->curr_req = hwp_req; + + hwp_verbose("CPU%u: wrmsr HWP_REQUEST %016lx\n", cpu, hwp_req.raw); + on_selected_cpus(cpumask_of(cpu), hwp_write_request, policy, 1); + + return 0; +} + +static int cf_check hwp_cpufreq_cpu_init(struct cpufreq_policy *policy) +{ + unsigned int cpu = policy->cpu; + struct hwp_drv_data *data; + + data = xzalloc(struct hwp_drv_data); + if ( !data ) + return -ENOMEM; + + if ( cpufreq_opt_governor ) + printk(XENLOG_WARNING + "HWP: governor \"%s\" is incompatible with hwp. Using default \"%s\"\n", + cpufreq_opt_governor->name, hwp_cpufreq_governor.name); + policy->governor = &hwp_cpufreq_governor; + + per_cpu(hwp_drv_data, cpu) = data; + + on_selected_cpus(cpumask_of(cpu), hwp_init_msrs, policy, 1); + + if ( data->curr_req.raw == -1 ) + { + hwp_err("CPU%u: Could not initialize HWP properly\n", cpu); + XFREE(per_cpu(hwp_drv_data, cpu)); + return -ENODEV; + } + + data->minimum = data->curr_req.min_perf; + data->maximum = data->curr_req.max_perf; + data->desired = data->curr_req.desired; + /* the !feature_hwp_energy_perf case was handled in hwp_init_msrs(). */ + if ( feature_hwp_energy_perf ) + data->energy_perf = data->curr_req.energy_perf; + + hwp_verbose("CPU%u: IA32_HWP_CAPABILITIES: %016lx\n", cpu, data->hwp_caps); + + hwp_verbose("CPU%u: rdmsr HWP_REQUEST %016lx\n", cpu, data->curr_req.raw); + + return 0; +} + +static int cf_check hwp_cpufreq_cpu_exit(struct cpufreq_policy *policy) +{ + XFREE(per_cpu(hwp_drv_data, policy->cpu)); + + return 0; +} + +/* + * The SDM reads like turbo should be disabled with MSR_IA32_PERF_CTL and + * PERF_CTL_TURBO_DISENGAGE, but that does not seem to actually work, at least + * with my HWP testing. MSR_IA32_MISC_ENABLE and MISC_ENABLE_TURBO_DISENGAGE + * is what Linux uses and seems to work. + */ +static void cf_check hwp_set_misc_turbo(void *info) +{ + const struct cpufreq_policy *policy = info; + uint64_t msr; + + if ( rdmsr_safe(MSR_IA32_MISC_ENABLE, msr) ) + { + hwp_err("CPU%u: error rdmsr_safe(MSR_IA32_MISC_ENABLE)\n", policy->cpu); + + return; + } + + if ( policy->turbo == CPUFREQ_TURBO_ENABLED ) + msr &= ~MSR_IA32_MISC_ENABLE_TURBO_DISENGAGE; + else + msr |= MSR_IA32_MISC_ENABLE_TURBO_DISENGAGE; + + if ( wrmsr_safe(MSR_IA32_MISC_ENABLE, msr) ) + hwp_err("CPU%u: error wrmsr_safe(MSR_IA32_MISC_ENABLE): %016lx\n", + policy->cpu, msr); +} + +static int cf_check hwp_cpufreq_update(int cpuid, struct cpufreq_policy *policy) +{ + on_selected_cpus(cpumask_of(cpuid), hwp_set_misc_turbo, policy, 1); + + return 0; +} + +static const struct cpufreq_driver __initconstrel hwp_cpufreq_driver = +{ + .name = "hwp-cpufreq", + .verify = hwp_cpufreq_verify, + .target = hwp_cpufreq_target, + .init = hwp_cpufreq_cpu_init, + .exit = hwp_cpufreq_cpu_exit, + .update = hwp_cpufreq_update, +}; + +int __init hwp_register_driver(void) +{ + return cpufreq_register_driver(&hwp_cpufreq_driver); +} diff --git a/xen/arch/x86/include/asm/cpufeature.h b/xen/arch/x86/include/asm/cpufeature.h index 4140ec0938..f2ff1d5fde 100644 --- a/xen/arch/x86/include/asm/cpufeature.h +++ b/xen/arch/x86/include/asm/cpufeature.h @@ -46,8 +46,17 @@ extern struct cpuinfo_x86 boot_cpu_data; #define cpu_has(c, bit) test_bit(bit, (c)->x86_capability) #define boot_cpu_has(bit) test_bit(bit, boot_cpu_data.x86_capability) -#define CPUID_PM_LEAF 6 -#define CPUID6_ECX_APERFMPERF_CAPABILITY 0x1 +#define CPUID_PM_LEAF 6 +#define CPUID6_EAX_HWP (_AC(1, U) << 7) +#define CPUID6_EAX_HWP_NOTIFICATION (_AC(1, U) << 8) +#define CPUID6_EAX_HWP_ACTIVITY_WINDOW (_AC(1, U) << 9) +#define CPUID6_EAX_HWP_ENERGY_PERFORMANCE_PREFERENCE (_AC(1, U) << 10) +#define CPUID6_EAX_HWP_PACKAGE_LEVEL_REQUEST (_AC(1, U) << 11) +#define CPUID6_EAX_HDC (_AC(1, U) << 13) +#define CPUID6_EAX_HWP_PECI (_AC(1, U) << 16) +#define CPUID6_EAX_HW_FEEDBACK (_AC(1, U) << 19) +#define CPUID6_ECX_APERFMPERF_CAPABILITY 0x1 +#define CPUID6_ECX_IA32_ENERGY_PERF_BIAS 0x8 /* CPUID level 0x00000001.edx */ #define cpu_has_fpu 1 diff --git a/xen/arch/x86/include/asm/msr-index.h b/xen/arch/x86/include/asm/msr-index.h index fa771ed0b5..a2a22339e4 100644 --- a/xen/arch/x86/include/asm/msr-index.h +++ b/xen/arch/x86/include/asm/msr-index.h @@ -151,6 +151,13 @@ #define MSR_PKRS 0x000006e1 +#define MSR_IA32_PM_ENABLE 0x00000770 +#define IA32_PM_ENABLE_HWP_ENABLE (_AC(1, ULL) << 0) + +#define MSR_IA32_HWP_CAPABILITIES 0x00000771 +#define MSR_IA32_HWP_INTERRUPT 0x00000773 +#define MSR_IA32_HWP_REQUEST 0x00000774 + #define MSR_X2APIC_FIRST 0x00000800 #define MSR_X2APIC_LAST 0x000008ff @@ -165,6 +172,11 @@ #define PASID_PASID_MASK 0x000fffff #define PASID_VALID (_AC(1, ULL) << 31) +#define MSR_IA32_PKG_HDC_CTL 0x00000db0 +#define IA32_PKG_HDC_CTL_HDC_PKG_ENABLE (_AC(1, ULL) << 0) +#define MSR_IA32_PM_CTL1 0x00000db1 +#define IA32_PM_CTL1_HDC_ALLOW_BLOCK (_AC(1, ULL) << 0) + #define MSR_UARCH_MISC_CTRL 0x00001b01 #define UARCH_CTRL_DOITM (_AC(1, ULL) << 0) @@ -500,6 +512,7 @@ #define MSR_IA32_MISC_ENABLE_LIMIT_CPUID (1<<22) #define MSR_IA32_MISC_ENABLE_XTPR_DISABLE (1<<23) #define MSR_IA32_MISC_ENABLE_XD_DISABLE (1ULL << 34) +#define MSR_IA32_MISC_ENABLE_TURBO_DISENGAGE (1ULL << 38) #define MSR_IA32_TSC_DEADLINE 0x000006E0 #define MSR_IA32_ENERGY_PERF_BIAS 0x000001b0 diff --git a/xen/drivers/cpufreq/cpufreq.c b/xen/drivers/cpufreq/cpufreq.c index 7bd81680da..9470eb7230 100644 --- a/xen/drivers/cpufreq/cpufreq.c +++ b/xen/drivers/cpufreq/cpufreq.c @@ -565,6 +565,38 @@ static void cpufreq_cmdline_common_para(struct cpufreq_policy *new_policy) static int __init cpufreq_handle_common_option(const char *name, const char *val) { + if (!strcmp(name, "hdc")) { + if (val) { + int ret = parse_bool(val, NULL); + if (ret != -1) { + opt_cpufreq_hdc = ret; + return 1; + } + } else { + opt_cpufreq_hdc = true; + return 1; + } + } else if (!strcmp(name, "no-hdc")) { + opt_cpufreq_hdc = false; + return 1; + } + + if (!strcmp(name, "hwp")) { + if (val) { + int ret = parse_bool(val, NULL); + if (ret != -1) { + opt_cpufreq_hwp = ret; + return 1; + } + } else { + opt_cpufreq_hwp = true; + return 1; + } + } else if (!strcmp(name, "no-hwp")) { + opt_cpufreq_hwp = false; + return 1; + } + if (!strcmp(name, "maxfreq") && val) { usr_max_freq = simple_strtoul(val, NULL, 0); return 1; diff --git a/xen/include/acpi/cpufreq/cpufreq.h b/xen/include/acpi/cpufreq/cpufreq.h index 0f334d2a43..29a712a4f1 100644 --- a/xen/include/acpi/cpufreq/cpufreq.h +++ b/xen/include/acpi/cpufreq/cpufreq.h @@ -245,4 +245,7 @@ void cpufreq_dbs_timer_resume(void); void intel_feature_detect(struct cpufreq_policy *policy); +extern bool opt_cpufreq_hwp; +extern bool opt_cpufreq_hdc; + #endif /* __XEN_CPUFREQ_PM_H__ */ diff --git a/xen/include/acpi/cpufreq/processor_perf.h b/xen/include/acpi/cpufreq/processor_perf.h index d8a1ba68a6..b751ca4937 100644 --- a/xen/include/acpi/cpufreq/processor_perf.h +++ b/xen/include/acpi/cpufreq/processor_perf.h @@ -7,6 +7,9 @@ #define XEN_PX_INIT 0x80000000 +bool hwp_available(void); +int hwp_register_driver(void); + int powernow_cpufreq_init(void); unsigned int powernow_register_driver(void); unsigned int get_measured_perf(unsigned int cpu, unsigned int flag); diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h index 2b24d6bfd0..b448f13b75 100644 --- a/xen/include/public/sysctl.h +++ b/xen/include/public/sysctl.h @@ -292,6 +292,7 @@ struct xen_ondemand { uint32_t up_threshold; }; +#define XEN_HWP_GOVERNOR "hwp-internal" /* * cpufreq para name of this structure named * same as sysfs file name of native linux -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:21:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:21:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528066.820656 (Exim 4.92) (envelope-from ) id 1ptZ5L-0004K9-Ej; Mon, 01 May 2023 19:21:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528066.820656; Mon, 01 May 2023 19:21:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZ5L-0004Jy-Bi; Mon, 01 May 2023 19:21:19 +0000 Received: by outflank-mailman (input) for mailman id 528066; Mon, 01 May 2023 19:21:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZ5J-0003yM-Vk for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:21:17 +0000 Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [2607:f8b0:4864:20::732]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 57a16940-e855-11ed-8611-37d641c3527e; Mon, 01 May 2023 21:21:16 +0200 (CEST) Received: by mail-qk1-x732.google.com with SMTP id af79cd13be357-74cebbb7bc5so275654785a.3 for ; Mon, 01 May 2023 12:21:16 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id x20-20020a0ce0d4000000b0061927ddb043sm2012307qvk.80.2023.05.01.12.21.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:21:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57a16940-e855-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682968875; x=1685560875; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hA8U/InM9EEJxsTtEJ4pQE8Dle8MV2Sm7m6DjaGLFBw=; b=alyW1WnDxf9gWpn/iywDsDjWYtiNrb58353i+DD9++Cpa7YDvVl5EOnhjOr7qgZ6B0 RWo7oakWLr32hdtu25e0yXhddgGem81Abc9u1tiXk5BSZKu9Wn4LnZnWqohDt7U0OIRP 1Vwij9eGmo0DPTDjtZAwVPzsmENXo5NCzFBn/pjPxkfGWiKoaKf2iMk1WNC0jNaA7qWV 5fkIkwLkHB2hIGp6CrRnnNLwyp+Sw/3+BpQifdRz+2gZsR4C4IEGgAwG74R7Qe73+Joe 6nZzkXBWog45V7Zpne/TjUOKDbRKSCzjxi67JcYxqhIWy/iklXt+xS1d0TB15rJvRp0s 7//A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682968875; x=1685560875; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hA8U/InM9EEJxsTtEJ4pQE8Dle8MV2Sm7m6DjaGLFBw=; b=TV5WbagDmYG46TWa0zSQzYbBrHe77J89qcyOIBUz0gUDwJktRj9fNkg5SHYC5b7a0Q TtaRRqW2TtQ58O0ffKPQAVeasdCM93z4H9EOtUIRLxxHgpDFDbvvYWURkhYTiI86FvAb tt6SnTSa0oPWgp5yCD/0qObyhzYT/i3dCyKL6FlEqGHkrczypp8M91JyYpn9Ac7PQDyQ TVUezSWCS73RjRt/GK2Wi9bSbQ0nLvUjyx9rLkuzsuH1KOlVh7/1GV+T0KE7ap3w2o5G 1SXPdD5wh/0JGamIYlzogbnmWs0D2w9R6vmdZZE+h9u4obiAbsA3Fvu2C12X7GlCVTt4 SVBg== X-Gm-Message-State: AC+VfDx9ah8A7JlM4jEGXY8MXpgaz980oA3gO4S4uDmAgGUqJEdSFAu3 uEwnBK6uzL5rLubheIVipRQ= X-Google-Smtp-Source: ACHHUZ7Si1N+KuQIyeuzpeF6TE80Hpb0MgsDrxMePO6KWSxcK6U33V2aUW4c9/8oenuaGAK3spl/eQ== X-Received: by 2002:a05:6214:2a49:b0:5f5:51c4:fca5 with SMTP id jf9-20020a0562142a4900b005f551c4fca5mr1614591qvb.49.1682968875262; Mon, 01 May 2023 12:21:15 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproj, xen-devel@lists.xenproject.org Cc: Jason Andryuk , Wei Liu , Anthony PERARD Subject: [PATCH v3 05/14] xenpm: Change get-cpufreq-para output for internal Date: Mon, 1 May 2023 15:20:36 -0400 Message-Id: <20230501192045.87377-6-jandryuk@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230501192045.87377-1-jandryuk@gmail.com> References: <20230501192045.87377-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When using HWP, some of the returned data is not applicable. In that case, we should just omit it to avoid confusing the user. So switch to printing the base and turbo frequencies since those are relevant to HWP. Similarly, stop printing the CPU frequencies since those do not apply. Signed-off-by: Jason Andryuk --- v2: Use full governor name XEN_HWP_GOVERNOR to change output Style fixes --- tools/misc/xenpm.c | 41 +++++++++++++++++++++++++---------------- 1 file changed, 25 insertions(+), 16 deletions(-) diff --git a/tools/misc/xenpm.c b/tools/misc/xenpm.c index 1bb6187e56..ce8d7644d0 100644 --- a/tools/misc/xenpm.c +++ b/tools/misc/xenpm.c @@ -711,6 +711,7 @@ void start_gather_func(int argc, char *argv[]) /* print out parameters about cpu frequency */ static void print_cpufreq_para(int cpuid, struct xc_get_cpufreq_para *p_cpufreq) { + bool internal = strstr(p_cpufreq->scaling_governor, XEN_HWP_GOVERNOR); int i; printf("cpu id : %d\n", cpuid); @@ -720,10 +721,15 @@ static void print_cpufreq_para(int cpuid, struct xc_get_cpufreq_para *p_cpufreq) printf(" %d", p_cpufreq->affected_cpus[i]); printf("\n"); - printf("cpuinfo frequency : max [%u] min [%u] cur [%u]\n", - p_cpufreq->cpuinfo_max_freq, - p_cpufreq->cpuinfo_min_freq, - p_cpufreq->cpuinfo_cur_freq); + if ( internal ) + printf("cpuinfo frequency : base [%u] turbo [%u]\n", + p_cpufreq->cpuinfo_min_freq, + p_cpufreq->cpuinfo_max_freq); + else + printf("cpuinfo frequency : max [%u] min [%u] cur [%u]\n", + p_cpufreq->cpuinfo_max_freq, + p_cpufreq->cpuinfo_min_freq, + p_cpufreq->cpuinfo_cur_freq); printf("scaling_driver : %s\n", p_cpufreq->scaling_driver); @@ -750,19 +756,22 @@ static void print_cpufreq_para(int cpuid, struct xc_get_cpufreq_para *p_cpufreq) p_cpufreq->u.ondemand.up_threshold); } - printf("scaling_avail_freq :"); - for ( i = 0; i < p_cpufreq->freq_num; i++ ) - if ( p_cpufreq->scaling_available_frequencies[i] == - p_cpufreq->scaling_cur_freq ) - printf(" *%d", p_cpufreq->scaling_available_frequencies[i]); - else - printf(" %d", p_cpufreq->scaling_available_frequencies[i]); - printf("\n"); + if ( !internal ) + { + printf("scaling_avail_freq :"); + for ( i = 0; i < p_cpufreq->freq_num; i++ ) + if ( p_cpufreq->scaling_available_frequencies[i] == + p_cpufreq->scaling_cur_freq ) + printf(" *%d", p_cpufreq->scaling_available_frequencies[i]); + else + printf(" %d", p_cpufreq->scaling_available_frequencies[i]); + printf("\n"); - printf("scaling frequency : max [%u] min [%u] cur [%u]\n", - p_cpufreq->scaling_max_freq, - p_cpufreq->scaling_min_freq, - p_cpufreq->scaling_cur_freq); + printf("scaling frequency : max [%u] min [%u] cur [%u]\n", + p_cpufreq->scaling_max_freq, + p_cpufreq->scaling_min_freq, + p_cpufreq->scaling_cur_freq); + } printf("turbo mode : %s\n", p_cpufreq->turbo_enabled ? "enabled" : "disabled or n/a"); -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:28:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:28:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528079.820666 (Exim 4.92) (envelope-from ) id 1ptZCQ-0006Ff-83; Mon, 01 May 2023 19:28:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528079.820666; Mon, 01 May 2023 19:28:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCQ-0006FY-53; Mon, 01 May 2023 19:28:38 +0000 Received: by outflank-mailman (input) for mailman id 528079; Mon, 01 May 2023 19:28:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCP-0006FS-8Q for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:28:37 +0000 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [2607:f8b0:4864:20::42e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5d40efeb-e856-11ed-b225-6b7b168915f2; Mon, 01 May 2023 21:28:36 +0200 (CEST) Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-63b5c4c76aaso2032564b3a.2 for ; Mon, 01 May 2023 12:28:36 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.28.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:28:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d40efeb-e856-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969314; x=1685561314; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ipls6koA+AeH8J6j2WxgUhcq4mmw5a3NH+J2RY9iS6I=; b=eztCo5uQgzZ++c4nibUBiIDXpS2LGO24+qSzaafIbpKx+1BibUdX3vQLCCvqCM9QaK k2szVsQtO5BsNtu2gEbwQ2R1Cp8SZWTwumicPfkwsEEQtcvZx+KCA7E9E8yQbBLG/+U1 YuKydYrLelSrUvEFcJOenbExJISoaZaYCzUq7BQHSqP3uoPFqEPYIMH3FrftdGe1VnOk 18/QJSaB/qqzmIXnj9u6ae7JwxuEe1M8it5S+Q9K46yajD+0ZkqBf7KewtfRcvygNDOo LlI0LPcK+WO/JxG3p9SD85FYmZExm1luEC4PEkLlS1jz538f0/tapw7EjRytIfe2E8ce OeqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969314; x=1685561314; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ipls6koA+AeH8J6j2WxgUhcq4mmw5a3NH+J2RY9iS6I=; b=KEq7r/fiVwRVpze8Askz1PFxUICXoM21VphjKTszh/jZgSJavPjyuoR6cXZlXQH+D7 mXswhcMwIO7lOM5yI4EAvsyMZicI57/64IKPAz3SmDHEo3mU8G/0p/OInt/ARjISUOsU 8Kp7C0sM0N42KgAtmIk+eOvfioKbWZgi8fTIuvr6jl02diG4z8ipSbGMKLDc97+WiMXI XJRbAsyPzsPdErLr9B3wJMkdoKJNSEKuuF4h3jBEvU/Hsw0X5H9Dse9K6lvbNu+pOstc luDtJf9ZhUPT7twtsPNw9mFe9bZSVLzyEEQmLgBaPx3xGrVcytnva7wIUhgYNEu+xUEN 6PDA== X-Gm-Message-State: AC+VfDy4XVkdykWiUNVWKkFNrR6R+eVPTnTyB/NZlij7f8Hq6IhdLjz1 EKpn1eLTOd350AFhXWLYgbo= X-Google-Smtp-Source: ACHHUZ4EtcVpfh2GrxC12spi0fGVMtR6JEHjWCZcT25vgipN1a5chaj6S10yX1bBKRrgSrOQ8bpQcQ== X-Received: by 2002:a17:903:2310:b0:1a6:54ce:4311 with SMTP id d16-20020a170903231000b001a654ce4311mr18428090plh.43.1682969314058; Mon, 01 May 2023 12:28:34 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" , Catalin Marinas , Huacai Chen , Geert Uytterhoeven , Thomas Bogendoerfer , Dinh Nguyen , Jonas Bonn , David Hildenbrand , Claudio Imbrenda , Paul Walmsley , "David S. Miller" , Richard Weinberger , Yoshinori Sato , Dave Hansen , Arnd Bergmann Subject: [PATCH v2 00/34] Split ptdesc from struct page Date: Mon, 1 May 2023 12:27:55 -0700 Message-Id: <20230501192829.17086-1-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The MM subsystem is trying to shrink struct page. This patchset introduces a memory descriptor for page table tracking - struct ptdesc. This patchset introduces ptdesc, splits ptdesc from struct page, and converts many callers of page table constructor/destructors to use ptdescs. Ptdesc is a foundation to further standardize page tables, and eventually allow for dynamic allocation of page tables independent of struct page. However, the use of pages for page table tracking is quite deeply ingrained and varied across archictectures, so there is still a lot of work to be done before that can happen. This is rebased on next-20230428. v2: Fix a lot of compiler warning/errors Moved definition of ptdesc to outside CONFIG_MMU Revert commit 7e25de77bc5ea which had gmap use pmd_pgtable_page() Allow functions to preserve const-ness where applicable Define folio equivalents for PAGE_TYPE_OPS page functions Vishal Moola (Oracle) (34): mm: Add PAGE_TYPE_OP folio functions s390: Use _pt_s390_gaddr for gmap address tracking s390: Use pt_frag_refcount for pagetables pgtable: Create struct ptdesc mm: add utility functions for ptdesc mm: Convert pmd_pgtable_page() to pmd_ptdesc() mm: Convert ptlock_alloc() to use ptdescs mm: Convert ptlock_ptr() to use ptdescs mm: Convert pmd_ptlock_init() to use ptdescs mm: Convert ptlock_init() to use ptdescs mm: Convert pmd_ptlock_free() to use ptdescs mm: Convert ptlock_free() to use ptdescs mm: Create ptdesc equivalents for pgtable_{pte,pmd}_page_{ctor,dtor} powerpc: Convert various functions to use ptdescs x86: Convert various functions to use ptdescs s390: Convert various gmap functions to use ptdescs s390: Convert various pgalloc functions to use ptdescs mm: Remove page table members from struct page pgalloc: Convert various functions to use ptdescs arm: Convert various functions to use ptdescs arm64: Convert various functions to use ptdescs csky: Convert __pte_free_tlb() to use ptdescs hexagon: Convert __pte_free_tlb() to use ptdescs loongarch: Convert various functions to use ptdescs m68k: Convert various functions to use ptdescs mips: Convert various functions to use ptdescs nios2: Convert __pte_free_tlb() to use ptdescs openrisc: Convert __pte_free_tlb() to use ptdescs riscv: Convert alloc_{pmd, pte}_late() to use ptdescs sh: Convert pte_free_tlb() to use ptdescs sparc64: Convert various functions to use ptdescs sparc: Convert pgtable_pte_page_{ctor, dtor}() to ptdesc equivalents um: Convert {pmd, pte}_free_tlb() to use ptdescs mm: Remove pgtable_{pmd, pte}_page_{ctor, dtor}() wrappers Documentation/mm/split_page_table_lock.rst | 12 +- .../zh_CN/mm/split_page_table_lock.rst | 14 +- arch/arm/include/asm/tlb.h | 12 +- arch/arm/mm/mmu.c | 6 +- arch/arm64/include/asm/tlb.h | 14 +- arch/arm64/mm/mmu.c | 7 +- arch/csky/include/asm/pgalloc.h | 4 +- arch/hexagon/include/asm/pgalloc.h | 8 +- arch/loongarch/include/asm/pgalloc.h | 27 ++- arch/loongarch/mm/pgtable.c | 7 +- arch/m68k/include/asm/mcf_pgalloc.h | 41 ++-- arch/m68k/include/asm/sun3_pgalloc.h | 8 +- arch/m68k/mm/motorola.c | 4 +- arch/mips/include/asm/pgalloc.h | 31 +-- arch/mips/mm/pgtable.c | 7 +- arch/nios2/include/asm/pgalloc.h | 8 +- arch/openrisc/include/asm/pgalloc.h | 8 +- arch/powerpc/mm/book3s64/mmu_context.c | 10 +- arch/powerpc/mm/book3s64/pgtable.c | 32 +-- arch/powerpc/mm/pgtable-frag.c | 46 ++-- arch/riscv/include/asm/pgalloc.h | 8 +- arch/riscv/mm/init.c | 16 +- arch/s390/include/asm/pgalloc.h | 4 +- arch/s390/include/asm/tlb.h | 4 +- arch/s390/mm/gmap.c | 222 +++++++++++------- arch/s390/mm/pgalloc.c | 126 +++++----- arch/sh/include/asm/pgalloc.h | 9 +- arch/sparc/mm/init_64.c | 17 +- arch/sparc/mm/srmmu.c | 5 +- arch/um/include/asm/pgalloc.h | 18 +- arch/x86/mm/pgtable.c | 46 ++-- arch/x86/xen/mmu_pv.c | 2 +- include/asm-generic/pgalloc.h | 62 +++-- include/asm-generic/tlb.h | 11 + include/linux/mm.h | 138 +++++++---- include/linux/mm_types.h | 14 -- include/linux/page-flags.h | 20 +- include/linux/pgtable.h | 61 +++++ mm/memory.c | 8 +- 39 files changed, 648 insertions(+), 449 deletions(-) -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:28:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:28:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528081.820687 (Exim 4.92) (envelope-from ) id 1ptZCU-0006m7-NJ; Mon, 01 May 2023 19:28:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528081.820687; Mon, 01 May 2023 19:28:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCU-0006ly-KR; Mon, 01 May 2023 19:28:42 +0000 Received: by outflank-mailman (input) for mailman id 528081; Mon, 01 May 2023 19:28:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCS-0006PY-Jr for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:28:40 +0000 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [2607:f8b0:4864:20::62f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5f278727-e856-11ed-8611-37d641c3527e; Mon, 01 May 2023 21:28:38 +0200 (CEST) Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1aafa41116fso8341125ad.1 for ; Mon, 01 May 2023 12:28:38 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.28.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:28:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5f278727-e856-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969317; x=1685561317; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=M8hiVfs4v+/D1xXViLOX+gYSSXi/GMS2KWwieBJlAWc=; b=AY7R5i89uxro5jd56WDlKU8Fja36ryrUk0S6Q16X+U0ZmNOWNsYwM9UD5V7eDDQ7CL 2Tp8zG1LpWxUjW4nysKBNDYzREXSeT3FlM9ngsN5B+/pdzX19qHXjQsHi+3L0FpuArC6 DX51z91UL4SAH0JFTTT8iwQUyEwSGDC+CwqD9d2dvVW7YCy7XaJzjb77A+6boEThDAuR yo/RflA9LSDAu/9t9COb7jqY02Est+ouWn7H3Pdtze5JZEAvjpVjvI8vLLYbYiOL7/Bq zRTj3vIBIMrvJGHdN6ZHUGjTTTFWg+U9ypFlp6tV+iF0iJAPNZuT4obK8hP4ZcyyaPpG zH0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969317; x=1685561317; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M8hiVfs4v+/D1xXViLOX+gYSSXi/GMS2KWwieBJlAWc=; b=ImwDrM8Z9+Awy0nlSj55dU86LsBTKk/Bw4LzY71tD8h2j/TfeaFh1X7OgHkPJTB6Va YVN1Fsy2LtWg7kCPVd4/SlC/AEVc5IW/M+PeH+44E+Br1DSmzeSyhOZnXLdH72gGdPQ/ iPZtBiF9uqHXnlM42iUTYfgK8DMehFEkI7ucEzjn69oNjSwAwZTMVP6IWh4lLAflBZMh HMHUGteNTK0ahqC+pZ3W0XID2ZHFgpJxXfDZh3dGK46+yWIHE5rFmjfgD6WUKPsMoGdB Ijm2/82cT6XyJoJ+npUe0VytlAMlGLdAleKwB8cfUxWewp5sjqqwmbpzL+Fyg+gG8nZ0 zncA== X-Gm-Message-State: AC+VfDyuSr1EQ3aX2QohvrgS4SCHtye70lQc2CkfjNj+SJVNuAzvUGXc 7QdENA6oDdV8jV3Vw5hZ0B8= X-Google-Smtp-Source: ACHHUZ4Ql//l/srSqMxjTIGMvYKmafNUcwRHhPOehsj6F0oVzwyh2L3O7KuPKaj/60mvEgHluv+34Q== X-Received: by 2002:a17:902:9347:b0:1a6:e564:6046 with SMTP id g7-20020a170902934700b001a6e5646046mr15359610plp.46.1682969317238; Mon, 01 May 2023 12:28:37 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" , David Hildenbrand , Claudio Imbrenda Subject: [PATCH v2 02/34] s390: Use _pt_s390_gaddr for gmap address tracking Date: Mon, 1 May 2023 12:27:57 -0700 Message-Id: <20230501192829.17086-3-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit s390 uses page->index to keep track of page tables for the guest address space. In an attempt to consolidate the usage of page fields in s390, replace _pt_pad_2 with _pt_s390_gaddr to replace page->index in gmap. This will help with the splitting of struct ptdesc from struct page, as well as allow s390 to use _pt_frag_refcount for fragmented page table tracking. Since page->_pt_s390_gaddr aliases with mapping, ensure its set to NULL before freeing the pages as well. This also reverts commit 7e25de77bc5ea ("s390/mm: use pmd_pgtable_page() helper in __gmap_segment_gaddr()") which had s390 use pmd_pgtable_page() to get a gmap page table, as pmd_pgtable_page() should be used for more generic process page tables. Signed-off-by: Vishal Moola (Oracle) --- arch/s390/mm/gmap.c | 56 +++++++++++++++++++++++++++------------- include/linux/mm_types.h | 2 +- 2 files changed, 39 insertions(+), 19 deletions(-) diff --git a/arch/s390/mm/gmap.c b/arch/s390/mm/gmap.c index dfe905c7bd8e..a9e8b1805894 100644 --- a/arch/s390/mm/gmap.c +++ b/arch/s390/mm/gmap.c @@ -70,7 +70,7 @@ static struct gmap *gmap_alloc(unsigned long limit) page = alloc_pages(GFP_KERNEL_ACCOUNT, CRST_ALLOC_ORDER); if (!page) goto out_free; - page->index = 0; + page->_pt_s390_gaddr = 0; list_add(&page->lru, &gmap->crst_list); table = page_to_virt(page); crst_table_init(table, etype); @@ -187,16 +187,20 @@ static void gmap_free(struct gmap *gmap) if (!(gmap_is_shadow(gmap) && gmap->removed)) gmap_flush_tlb(gmap); /* Free all segment & region tables. */ - list_for_each_entry_safe(page, next, &gmap->crst_list, lru) + list_for_each_entry_safe(page, next, &gmap->crst_list, lru) { + page->_pt_s390_gaddr = 0; __free_pages(page, CRST_ALLOC_ORDER); + } gmap_radix_tree_free(&gmap->guest_to_host); gmap_radix_tree_free(&gmap->host_to_guest); /* Free additional data for a shadow gmap */ if (gmap_is_shadow(gmap)) { /* Free all page tables. */ - list_for_each_entry_safe(page, next, &gmap->pt_list, lru) + list_for_each_entry_safe(page, next, &gmap->pt_list, lru) { + page->_pt_s390_gaddr = 0; page_table_free_pgste(page); + } gmap_rmap_radix_tree_free(&gmap->host_to_rmap); /* Release reference to the parent */ gmap_put(gmap->parent); @@ -318,12 +322,14 @@ static int gmap_alloc_table(struct gmap *gmap, unsigned long *table, list_add(&page->lru, &gmap->crst_list); *table = __pa(new) | _REGION_ENTRY_LENGTH | (*table & _REGION_ENTRY_TYPE_MASK); - page->index = gaddr; + page->_pt_s390_gaddr = gaddr; page = NULL; } spin_unlock(&gmap->guest_table_lock); - if (page) + if (page) { + page->_pt_s390_gaddr = 0; __free_pages(page, CRST_ALLOC_ORDER); + } return 0; } @@ -336,12 +342,14 @@ static int gmap_alloc_table(struct gmap *gmap, unsigned long *table, static unsigned long __gmap_segment_gaddr(unsigned long *entry) { struct page *page; - unsigned long offset; + unsigned long offset, mask; offset = (unsigned long) entry / sizeof(unsigned long); offset = (offset & (PTRS_PER_PMD - 1)) * PMD_SIZE; - page = pmd_pgtable_page((pmd_t *) entry); - return page->index + offset; + mask = ~(PTRS_PER_PMD * sizeof(pmd_t) - 1); + page = virt_to_page((void *)((unsigned long) entry & mask)); + + return page->_pt_s390_gaddr + offset; } /** @@ -1351,6 +1359,7 @@ static void gmap_unshadow_pgt(struct gmap *sg, unsigned long raddr) /* Free page table */ page = phys_to_page(pgt); list_del(&page->lru); + page->_pt_s390_gaddr = 0; page_table_free_pgste(page); } @@ -1379,6 +1388,7 @@ static void __gmap_unshadow_sgt(struct gmap *sg, unsigned long raddr, /* Free page table */ page = phys_to_page(pgt); list_del(&page->lru); + page->_pt_s390_gaddr = 0; page_table_free_pgste(page); } } @@ -1409,6 +1419,7 @@ static void gmap_unshadow_sgt(struct gmap *sg, unsigned long raddr) /* Free segment table */ page = phys_to_page(sgt); list_del(&page->lru); + page->_pt_s390_gaddr = 0; __free_pages(page, CRST_ALLOC_ORDER); } @@ -1437,6 +1448,7 @@ static void __gmap_unshadow_r3t(struct gmap *sg, unsigned long raddr, /* Free segment table */ page = phys_to_page(sgt); list_del(&page->lru); + page->_pt_s390_gaddr = 0; __free_pages(page, CRST_ALLOC_ORDER); } } @@ -1467,6 +1479,7 @@ static void gmap_unshadow_r3t(struct gmap *sg, unsigned long raddr) /* Free region 3 table */ page = phys_to_page(r3t); list_del(&page->lru); + page->_pt_s390_gaddr = 0; __free_pages(page, CRST_ALLOC_ORDER); } @@ -1495,6 +1508,7 @@ static void __gmap_unshadow_r2t(struct gmap *sg, unsigned long raddr, /* Free region 3 table */ page = phys_to_page(r3t); list_del(&page->lru); + page->_pt_s390_gaddr = 0; __free_pages(page, CRST_ALLOC_ORDER); } } @@ -1525,6 +1539,7 @@ static void gmap_unshadow_r2t(struct gmap *sg, unsigned long raddr) /* Free region 2 table */ page = phys_to_page(r2t); list_del(&page->lru); + page->_pt_s390_gaddr = 0; __free_pages(page, CRST_ALLOC_ORDER); } @@ -1557,6 +1572,7 @@ static void __gmap_unshadow_r1t(struct gmap *sg, unsigned long raddr, /* Free region 2 table */ page = phys_to_page(r2t); list_del(&page->lru); + page->_pt_s390_gaddr = 0; __free_pages(page, CRST_ALLOC_ORDER); } } @@ -1762,9 +1778,9 @@ int gmap_shadow_r2t(struct gmap *sg, unsigned long saddr, unsigned long r2t, page = alloc_pages(GFP_KERNEL_ACCOUNT, CRST_ALLOC_ORDER); if (!page) return -ENOMEM; - page->index = r2t & _REGION_ENTRY_ORIGIN; + page->_pt_s390_gaddr = r2t & _REGION_ENTRY_ORIGIN; if (fake) - page->index |= GMAP_SHADOW_FAKE_TABLE; + page->_pt_s390_gaddr |= GMAP_SHADOW_FAKE_TABLE; s_r2t = page_to_phys(page); /* Install shadow region second table */ spin_lock(&sg->guest_table_lock); @@ -1814,6 +1830,7 @@ int gmap_shadow_r2t(struct gmap *sg, unsigned long saddr, unsigned long r2t, return rc; out_free: spin_unlock(&sg->guest_table_lock); + page->_pt_s390_gaddr = 0; __free_pages(page, CRST_ALLOC_ORDER); return rc; } @@ -1846,9 +1863,9 @@ int gmap_shadow_r3t(struct gmap *sg, unsigned long saddr, unsigned long r3t, page = alloc_pages(GFP_KERNEL_ACCOUNT, CRST_ALLOC_ORDER); if (!page) return -ENOMEM; - page->index = r3t & _REGION_ENTRY_ORIGIN; + page->_pt_s390_gaddr = r3t & _REGION_ENTRY_ORIGIN; if (fake) - page->index |= GMAP_SHADOW_FAKE_TABLE; + page->_pt_s390_gaddr |= GMAP_SHADOW_FAKE_TABLE; s_r3t = page_to_phys(page); /* Install shadow region second table */ spin_lock(&sg->guest_table_lock); @@ -1898,6 +1915,7 @@ int gmap_shadow_r3t(struct gmap *sg, unsigned long saddr, unsigned long r3t, return rc; out_free: spin_unlock(&sg->guest_table_lock); + page->_pt_s390_gaddr = 0; __free_pages(page, CRST_ALLOC_ORDER); return rc; } @@ -1930,9 +1948,9 @@ int gmap_shadow_sgt(struct gmap *sg, unsigned long saddr, unsigned long sgt, page = alloc_pages(GFP_KERNEL_ACCOUNT, CRST_ALLOC_ORDER); if (!page) return -ENOMEM; - page->index = sgt & _REGION_ENTRY_ORIGIN; + page->_pt_s390_gaddr = sgt & _REGION_ENTRY_ORIGIN; if (fake) - page->index |= GMAP_SHADOW_FAKE_TABLE; + page->_pt_s390_gaddr |= GMAP_SHADOW_FAKE_TABLE; s_sgt = page_to_phys(page); /* Install shadow region second table */ spin_lock(&sg->guest_table_lock); @@ -1982,6 +2000,7 @@ int gmap_shadow_sgt(struct gmap *sg, unsigned long saddr, unsigned long sgt, return rc; out_free: spin_unlock(&sg->guest_table_lock); + page->_pt_s390_gaddr = 0; __free_pages(page, CRST_ALLOC_ORDER); return rc; } @@ -2014,9 +2033,9 @@ int gmap_shadow_pgt_lookup(struct gmap *sg, unsigned long saddr, if (table && !(*table & _SEGMENT_ENTRY_INVALID)) { /* Shadow page tables are full pages (pte+pgste) */ page = pfn_to_page(*table >> PAGE_SHIFT); - *pgt = page->index & ~GMAP_SHADOW_FAKE_TABLE; + *pgt = page->_pt_s390_gaddr & ~GMAP_SHADOW_FAKE_TABLE; *dat_protection = !!(*table & _SEGMENT_ENTRY_PROTECT); - *fake = !!(page->index & GMAP_SHADOW_FAKE_TABLE); + *fake = !!(page->_pt_s390_gaddr & GMAP_SHADOW_FAKE_TABLE); rc = 0; } else { rc = -EAGAIN; @@ -2054,9 +2073,9 @@ int gmap_shadow_pgt(struct gmap *sg, unsigned long saddr, unsigned long pgt, page = page_table_alloc_pgste(sg->mm); if (!page) return -ENOMEM; - page->index = pgt & _SEGMENT_ENTRY_ORIGIN; + page->_pt_s390_gaddr = pgt & _SEGMENT_ENTRY_ORIGIN; if (fake) - page->index |= GMAP_SHADOW_FAKE_TABLE; + page->_pt_s390_gaddr |= GMAP_SHADOW_FAKE_TABLE; s_pgt = page_to_phys(page); /* Install shadow page table */ spin_lock(&sg->guest_table_lock); @@ -2101,6 +2120,7 @@ int gmap_shadow_pgt(struct gmap *sg, unsigned long saddr, unsigned long pgt, return rc; out_free: spin_unlock(&sg->guest_table_lock); + page->_pt_s390_gaddr = 0; page_table_free_pgste(page); return rc; diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h index 306a3d1a0fa6..6161fe1ae5b8 100644 --- a/include/linux/mm_types.h +++ b/include/linux/mm_types.h @@ -144,7 +144,7 @@ struct page { struct { /* Page table pages */ unsigned long _pt_pad_1; /* compound_head */ pgtable_t pmd_huge_pte; /* protected by page->ptl */ - unsigned long _pt_pad_2; /* mapping */ + unsigned long _pt_s390_gaddr; /* mapping */ union { struct mm_struct *pt_mm; /* x86 pgds only */ atomic_t pt_frag_refcount; /* powerpc */ -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:28:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:28:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528080.820677 (Exim 4.92) (envelope-from ) id 1ptZCS-0006V7-FV; Mon, 01 May 2023 19:28:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528080.820677; Mon, 01 May 2023 19:28:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCS-0006Uy-CV; Mon, 01 May 2023 19:28:40 +0000 Received: by outflank-mailman (input) for mailman id 528080; Mon, 01 May 2023 19:28:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCR-0006PY-34 for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:28:39 +0000 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [2607:f8b0:4864:20::42c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5e33d582-e856-11ed-8611-37d641c3527e; Mon, 01 May 2023 21:28:37 +0200 (CEST) Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-63b51fd2972so1993042b3a.3 for ; Mon, 01 May 2023 12:28:37 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.28.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:28:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5e33d582-e856-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969316; x=1685561316; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9i6mX6BOTgb2TGO86QCloW3rCrq78sBOKu0dxXwRHVs=; b=pYnEspIgQ/94L4B7QgE7HxUaLyMe6HQnu5gVv7XKe7wrHmtTwaLadWDte57s2SBwdQ 8bePLJ5Ai3/AmYhH4RiAfK8IjGb+8BxlohLn4+W6ycJ9Pg3WMvHLkkZOviW7YYTD/mmK GtZnk734H4mZvUq9Iut38ZejJnfrw2oYgWeCZ6PRbVlgoGyBpRA67FKhICj+7yH7j8HF a3LIP2IDGGOTftrbrsZRq8EQiQ5R1WymqweCw9yu0t92fclq88jf6kqwtf3FextynpJY IncHO/7Qw6ErlKR7f7HeTzuXXgCmLczBJBgXHLIbesev1rm2mkGmxXqiRqgTqpx3oce1 ZBnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969316; x=1685561316; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9i6mX6BOTgb2TGO86QCloW3rCrq78sBOKu0dxXwRHVs=; b=jO2Y331sc6XE+lr0s6rvDbUuy+l8h49ZoORwGByQG2XkBC6dPc7ksnrfjOpp+4D4u3 lg2mzuBL4+17G0EsmSwZuWUytazyHETIcMH4BIh+ebCn5EmwBDPTl3AlQPs5nDpDJ3UD CSbQTL+1IpZhf2dWIC6P7DU9gN6/y8YRqMysa9bA/Z0WWacrVLJ68qpNrrXp/OrSGaHj 5bGa9qcLz6x+2L9btERh3HqE4qLugZrs0HzpJQMqV9Zc5YGXUQN8fKjg1JsGhp6pJR+B EVfc2CKGfp68qEdHOT2aXPk/xPMGRURr0BFn6dh+/fl/GudJGAZ3Fyo3XlLdPNapoXVF JT5g== X-Gm-Message-State: AC+VfDxxpxJCQYTqCmMZiVJUbD/dwNSh5VyMLf133NznVPa+qGQsnFSA CeruaxMILdCZfnQiXIJA4CQ= X-Google-Smtp-Source: ACHHUZ4H6i4St7ld1wD0WuHlGapRQhff/8tSAzzBd7XutE+/MiRiNA1zmkp/wHjGquMcgELZnMsxdQ== X-Received: by 2002:a17:903:1c3:b0:1a9:80a0:47dc with SMTP id e3-20020a17090301c300b001a980a047dcmr15039374plh.3.1682969315645; Mon, 01 May 2023 12:28:35 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" Subject: [PATCH v2 01/34] mm: Add PAGE_TYPE_OP folio functions Date: Mon, 1 May 2023 12:27:56 -0700 Message-Id: <20230501192829.17086-2-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit No folio equivalents for page type operations have been defined, so define them for later folio conversions. Also changes the Page##uname macros to take in const struct page* since we only read the memory here. Signed-off-by: Vishal Moola (Oracle) --- include/linux/page-flags.h | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h index 1c68d67b832f..607b495d1b57 100644 --- a/include/linux/page-flags.h +++ b/include/linux/page-flags.h @@ -902,6 +902,8 @@ static inline bool is_page_hwpoison(struct page *page) #define PageType(page, flag) \ ((page->page_type & (PAGE_TYPE_BASE | flag)) == PAGE_TYPE_BASE) +#define folio_test_type(folio, flag) \ + ((folio->page.page_type & (PAGE_TYPE_BASE | flag)) == PAGE_TYPE_BASE) static inline int page_type_has_type(unsigned int page_type) { @@ -914,20 +916,34 @@ static inline int page_has_type(struct page *page) } #define PAGE_TYPE_OPS(uname, lname) \ -static __always_inline int Page##uname(struct page *page) \ +static __always_inline int Page##uname(const struct page *page) \ { \ return PageType(page, PG_##lname); \ } \ +static __always_inline int folio_test_##lname(const struct folio *folio)\ +{ \ + return folio_test_type(folio, PG_##lname); \ +} \ static __always_inline void __SetPage##uname(struct page *page) \ { \ VM_BUG_ON_PAGE(!PageType(page, 0), page); \ page->page_type &= ~PG_##lname; \ } \ +static __always_inline void __folio_set_##lname(struct folio *folio) \ +{ \ + VM_BUG_ON_FOLIO(!folio_test_type(folio, 0), folio); \ + folio->page.page_type &= ~PG_##lname; \ +} \ static __always_inline void __ClearPage##uname(struct page *page) \ { \ VM_BUG_ON_PAGE(!Page##uname(page), page); \ page->page_type |= PG_##lname; \ -} +} \ +static __always_inline void __folio_clear_##lname(struct folio *folio) \ +{ \ + VM_BUG_ON_FOLIO(!folio_test_##lname(folio), folio); \ + folio->page.page_type |= PG_##lname; \ +} \ /* * PageBuddy() indicates that the page is free and in the buddy system -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:28:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:28:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528082.820693 (Exim 4.92) (envelope-from ) id 1ptZCV-0006pt-52; Mon, 01 May 2023 19:28:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528082.820693; Mon, 01 May 2023 19:28:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCU-0006p9-TO; Mon, 01 May 2023 19:28:42 +0000 Received: by outflank-mailman (input) for mailman id 528082; Mon, 01 May 2023 19:28:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCS-0006FS-U7 for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:28:40 +0000 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [2607:f8b0:4864:20::436]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6002b4cd-e856-11ed-b225-6b7b168915f2; Mon, 01 May 2023 21:28:40 +0200 (CEST) Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-63b5465fc13so2109652b3a.3 for ; Mon, 01 May 2023 12:28:40 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.28.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:28:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6002b4cd-e856-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969319; x=1685561319; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bmbsS8DkaHNij/v9bdafzBlktB7f+f7NAeK2Q02GvbI=; b=B4azYqsU+PZdNT5sPYRuRynEP/yG+nnQZzCwWNiJuBYZMp7zK7WPiFNkyYATyiWLs9 KXu3O4UXjROzHmg5BH+SgHHBIK4HaE73RnqEPc9ZoVRSl4Uh4CCXlTE9MpnCo1Ir9cR5 1tT0IRumxWPV12suNOkG+VwHWOIH3Na7v0j8RESqGnAScgYPrOMUDDIHfUYdpmcQFIY7 vF1i0igsbLRBnZPi2HEPlzfFt+R0Rd+c2dVX9RoHx/GLiWbMDfrtbVlk0iN4TeEGJT4d 1bO8trvKRg+pq0Q4NgCg3JPagFS7MkJj/4qfBc8P2r4TUch12xgUcUg4F69rFfadNKuw 8vIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969319; x=1685561319; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bmbsS8DkaHNij/v9bdafzBlktB7f+f7NAeK2Q02GvbI=; b=YDyIjqtPwkXaf/Su4Y2scYaL76uyY6jRVZxhFW6wKY/GmFWzS0Wb2gGlflWEqsxAdr /+vYXPTKJ9XfH03f5tfMMpbhPXbSWqFm5ZGG9FK3BA0QZNbVyAVJL/53JJJN0yuhjgcP okHH5Jxe76qKyOW0P3GTV5VWiVXj1lO5xKykUVxwlhnfypPgNM9lE1ciIWNMo5O0BwI4 qLYhFgtScBHQQyP7oFXhJsSU/ZV+isphtEdSxs4KPY7+VQCtSj8o7DgAUqIfya5x3pgx g2KG1PJQsFH9P1BxvlgnA5oBn/88DwYlSR49xowbN0K9RM7LGqPz2GabKC4LYvDb00vZ Rhog== X-Gm-Message-State: AC+VfDw7hiV/MlpVWw4LVvZj/HlqHHGzJPcLUiHyLMDeDjYeY9YaHNm2 knhQc44ukAkVRL7VpX+DoQQ= X-Google-Smtp-Source: ACHHUZ4E/JVh2DFvUW/bEZgIHPiMJ+Zfpw7pvXWZYNeWA42FHZxnOhQrWiIO3kxV0xxzCmUatMgqYw== X-Received: by 2002:a17:902:8c91:b0:1a9:2b7f:a594 with SMTP id t17-20020a1709028c9100b001a92b7fa594mr13894676plo.29.1682969318714; Mon, 01 May 2023 12:28:38 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" , David Hildenbrand , Claudio Imbrenda Subject: [PATCH v2 03/34] s390: Use pt_frag_refcount for pagetables Date: Mon, 1 May 2023 12:27:58 -0700 Message-Id: <20230501192829.17086-4-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit s390 currently uses _refcount to identify fragmented page tables. The page table struct already has a member pt_frag_refcount used by powerpc, so have s390 use that instead of the _refcount field as well. This improves the safety for _refcount and the page table tracking. This also allows us to simplify the tracking since we can once again use the lower byte of pt_frag_refcount instead of the upper byte of _refcount. Signed-off-by: Vishal Moola (Oracle) --- arch/s390/mm/pgalloc.c | 38 +++++++++++++++----------------------- 1 file changed, 15 insertions(+), 23 deletions(-) diff --git a/arch/s390/mm/pgalloc.c b/arch/s390/mm/pgalloc.c index 66ab68db9842..6b99932abc66 100644 --- a/arch/s390/mm/pgalloc.c +++ b/arch/s390/mm/pgalloc.c @@ -182,20 +182,17 @@ void page_table_free_pgste(struct page *page) * As follows from the above, no unallocated or fully allocated parent * pages are contained in mm_context_t::pgtable_list. * - * The upper byte (bits 24-31) of the parent page _refcount is used + * The lower byte (bits 0-7) of the parent page pt_frag_refcount is used * for tracking contained 2KB-pgtables and has the following format: * * PP AA - * 01234567 upper byte (bits 24-31) of struct page::_refcount + * 01234567 upper byte (bits 0-7) of struct page::pt_frag_refcount * || || * || |+--- upper 2KB-pgtable is allocated * || +---- lower 2KB-pgtable is allocated * |+------- upper 2KB-pgtable is pending for removal * +-------- lower 2KB-pgtable is pending for removal * - * (See commit 620b4e903179 ("s390: use _refcount for pgtables") on why - * using _refcount is possible). - * * When 2KB-pgtable is allocated the corresponding AA bit is set to 1. * The parent page is either: * - added to mm_context_t::pgtable_list in case the second half of the @@ -243,11 +240,12 @@ unsigned long *page_table_alloc(struct mm_struct *mm) if (!list_empty(&mm->context.pgtable_list)) { page = list_first_entry(&mm->context.pgtable_list, struct page, lru); - mask = atomic_read(&page->_refcount) >> 24; + mask = atomic_read(&page->pt_frag_refcount); /* * The pending removal bits must also be checked. * Failure to do so might lead to an impossible - * value of (i.e 0x13 or 0x23) written to _refcount. + * value of (i.e 0x13 or 0x23) written to + * pt_frag_refcount. * Such values violate the assumption that pending and * allocation bits are mutually exclusive, and the rest * of the code unrails as result. That could lead to @@ -259,8 +257,8 @@ unsigned long *page_table_alloc(struct mm_struct *mm) bit = mask & 1; /* =1 -> second 2K */ if (bit) table += PTRS_PER_PTE; - atomic_xor_bits(&page->_refcount, - 0x01U << (bit + 24)); + atomic_xor_bits(&page->pt_frag_refcount, + 0x01U << bit); list_del(&page->lru); } } @@ -281,12 +279,12 @@ unsigned long *page_table_alloc(struct mm_struct *mm) table = (unsigned long *) page_to_virt(page); if (mm_alloc_pgste(mm)) { /* Return 4K page table with PGSTEs */ - atomic_xor_bits(&page->_refcount, 0x03U << 24); + atomic_xor_bits(&page->pt_frag_refcount, 0x03U); memset64((u64 *)table, _PAGE_INVALID, PTRS_PER_PTE); memset64((u64 *)table + PTRS_PER_PTE, 0, PTRS_PER_PTE); } else { /* Return the first 2K fragment of the page */ - atomic_xor_bits(&page->_refcount, 0x01U << 24); + atomic_xor_bits(&page->pt_frag_refcount, 0x01U); memset64((u64 *)table, _PAGE_INVALID, 2 * PTRS_PER_PTE); spin_lock_bh(&mm->context.lock); list_add(&page->lru, &mm->context.pgtable_list); @@ -323,22 +321,19 @@ void page_table_free(struct mm_struct *mm, unsigned long *table) * will happen outside of the critical section from this * function or from __tlb_remove_table() */ - mask = atomic_xor_bits(&page->_refcount, 0x11U << (bit + 24)); - mask >>= 24; + mask = atomic_xor_bits(&page->pt_frag_refcount, 0x11U << bit); if (mask & 0x03U) list_add(&page->lru, &mm->context.pgtable_list); else list_del(&page->lru); spin_unlock_bh(&mm->context.lock); - mask = atomic_xor_bits(&page->_refcount, 0x10U << (bit + 24)); - mask >>= 24; + mask = atomic_xor_bits(&page->pt_frag_refcount, 0x10U << bit); if (mask != 0x00U) return; half = 0x01U << bit; } else { half = 0x03U; - mask = atomic_xor_bits(&page->_refcount, 0x03U << 24); - mask >>= 24; + mask = atomic_xor_bits(&page->pt_frag_refcount, 0x03U); } page_table_release_check(page, table, half, mask); @@ -368,8 +363,7 @@ void page_table_free_rcu(struct mmu_gather *tlb, unsigned long *table, * outside of the critical section from __tlb_remove_table() or from * page_table_free() */ - mask = atomic_xor_bits(&page->_refcount, 0x11U << (bit + 24)); - mask >>= 24; + mask = atomic_xor_bits(&page->pt_frag_refcount, 0x11U << bit); if (mask & 0x03U) list_add_tail(&page->lru, &mm->context.pgtable_list); else @@ -391,14 +385,12 @@ void __tlb_remove_table(void *_table) return; case 0x01U: /* lower 2K of a 4K page table */ case 0x02U: /* higher 2K of a 4K page table */ - mask = atomic_xor_bits(&page->_refcount, mask << (4 + 24)); - mask >>= 24; + mask = atomic_xor_bits(&page->pt_frag_refcount, mask << 4); if (mask != 0x00U) return; break; case 0x03U: /* 4K page table with pgstes */ - mask = atomic_xor_bits(&page->_refcount, 0x03U << 24); - mask >>= 24; + mask = atomic_xor_bits(&page->pt_frag_refcount, 0x03U); break; } -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:28:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:28:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528083.820701 (Exim 4.92) (envelope-from ) id 1ptZCV-00073I-Ov; Mon, 01 May 2023 19:28:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528083.820701; Mon, 01 May 2023 19:28:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCV-000705-F8; Mon, 01 May 2023 19:28:43 +0000 Received: by outflank-mailman (input) for mailman id 528083; Mon, 01 May 2023 19:28:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCU-0006FS-4M for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:28:42 +0000 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [2607:f8b0:4864:20::430]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 60cc3f41-e856-11ed-b225-6b7b168915f2; Mon, 01 May 2023 21:28:41 +0200 (CEST) Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-63b7b54642cso2058874b3a.0 for ; Mon, 01 May 2023 12:28:41 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.28.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:28:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 60cc3f41-e856-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969320; x=1685561320; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=B0Od9Inc5y6h3dSbsHmdGR20xSLs7HxIKZ/fFcl7OHg=; b=BSfSX498+nRsOwkOZCv/c3TfiIzHvFrBHqOPXzZnUzdOTpraA1SFYJQ7S9OlNSy+oo SgKJwDZ3qC6C//XEAcYljRcEjgHnyeaNoyhEAyOx7Ys6/3k09Ik8CgCQWIiXukHyuWI8 JqooqMgdLQ1gpcR/L/mcYK+KZEjEg+InGInQqZs8g+xQwi3fiMtnPj+o8uf54dHCG0nD x8PpX8tpE3nfYMsr6vBPGSrBk7IqcdW9rAQJxVfKMF33+mjDorfNig4J/P1XioZbWwxD uXByeI5tsaD8qrYP2W7mncKrp6aQydR1tjw1T6sz0jLjo8cvDXE3/58iahOtRXOU+sGT jXsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969320; x=1685561320; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B0Od9Inc5y6h3dSbsHmdGR20xSLs7HxIKZ/fFcl7OHg=; b=b5tAbdM7h1XPki587llQvmhrUefAIRRLA8nqPUv2w26QJ4inEkJyAhesY8a+7eolFi 0pPE9bo4E+e63zMElTs8nM05PQdJKUAlUUqo8kvWDLEpWf5O7kHXRqq1FoMlj2WHyigw mzEpq2ccpMsw/jv19njxNQT6GDgY8EUH3ULpMsHJ4TGY56nOuiFdvhpv/hyUM6/noONs 19dfA8wYFluS0giTk1sgyVLB7W+OrVd4z7oSd/s+jiyWUNo1+w2YXMJBPL/jOvgBfNp5 iNbeL+hPSj8ay/7ISm4gYSvmhPJovUrJ4jOOl3KS3oE8IGeHS/H4XsrsEtdX41E0bJnO ATkQ== X-Gm-Message-State: AC+VfDwyYrTNdvTJtRUyt0j7fE+n4IJQghaLDpDFQ6EYZ3cQNarh+ubf Njuzr0grhYPsQMZtcFUNr9I= X-Google-Smtp-Source: ACHHUZ5c/2Ko6MMnlJILdIHFSiqsi7woH2pp9LXJUwyBETBH//ZWHg6e+tUlm1aX3nzTckKQE2QL/Q== X-Received: by 2002:a17:902:d2cf:b0:1aa:ffe1:de13 with SMTP id n15-20020a170902d2cf00b001aaffe1de13mr2810716plc.5.1682969320162; Mon, 01 May 2023 12:28:40 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" Subject: [PATCH v2 04/34] pgtable: Create struct ptdesc Date: Mon, 1 May 2023 12:27:59 -0700 Message-Id: <20230501192829.17086-5-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently, page table information is stored within struct page. As part of simplifying struct page, create struct ptdesc for page table information. Signed-off-by: Vishal Moola (Oracle) --- include/linux/pgtable.h | 52 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 52 insertions(+) diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h index 023918666dd4..5e0f51308724 100644 --- a/include/linux/pgtable.h +++ b/include/linux/pgtable.h @@ -989,6 +989,58 @@ static inline void ptep_modify_prot_commit(struct vm_area_struct *vma, #endif /* __HAVE_ARCH_PTEP_MODIFY_PROT_TRANSACTION */ #endif /* CONFIG_MMU */ + +/** + * struct ptdesc - Memory descriptor for page tables. + * @__page_flags: Same as page flags. Unused for page tables. + * @pt_list: List of used page tables. Used for s390 and x86. + * @_pt_pad_1: Padding that aliases with page's compound head. + * @pmd_huge_pte: Protected by ptdesc->ptl, used for THPs. + * @_pt_s390_gaddr: Aliases with page's mapping. Used for s390 gmap only. + * @pt_mm: Used for x86 pgds. + * @pt_frag_refcount: For fragmented page table tracking. Powerpc and s390 only. + * @ptl: Lock for the page table. + * + * This struct overlays struct page for now. Do not modify without a good + * understanding of the issues. + */ +struct ptdesc { + unsigned long __page_flags; + + union { + struct list_head pt_list; + struct { + unsigned long _pt_pad_1; + pgtable_t pmd_huge_pte; + }; + }; + unsigned long _pt_s390_gaddr; + + union { + struct mm_struct *pt_mm; + atomic_t pt_frag_refcount; + unsigned long index; + }; + +#if ALLOC_SPLIT_PTLOCKS + spinlock_t *ptl; +#else + spinlock_t ptl; +#endif +}; + +#define TABLE_MATCH(pg, pt) \ + static_assert(offsetof(struct page, pg) == offsetof(struct ptdesc, pt)) +TABLE_MATCH(flags, __page_flags); +TABLE_MATCH(compound_head, pt_list); +TABLE_MATCH(compound_head, _pt_pad_1); +TABLE_MATCH(pmd_huge_pte, pmd_huge_pte); +TABLE_MATCH(mapping, _pt_s390_gaddr); +TABLE_MATCH(pt_mm, pt_mm); +TABLE_MATCH(ptl, ptl); +#undef TABLE_MATCH +static_assert(sizeof(struct ptdesc) <= sizeof(struct page)); + /* * No-op macros that just return the current protection value. Defined here * because these macros can be used even if CONFIG_MMU is not defined. -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:28:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:28:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528084.820716 (Exim 4.92) (envelope-from ) id 1ptZCX-0007XI-27; Mon, 01 May 2023 19:28:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528084.820716; Mon, 01 May 2023 19:28:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCW-0007Vs-U1; Mon, 01 May 2023 19:28:44 +0000 Received: by outflank-mailman (input) for mailman id 528084; Mon, 01 May 2023 19:28:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCV-0006FS-Je for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:28:43 +0000 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [2607:f8b0:4864:20::62f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 61a6acfa-e856-11ed-b225-6b7b168915f2; Mon, 01 May 2023 21:28:43 +0200 (CEST) Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1a6762fd23cso23588215ad.3 for ; Mon, 01 May 2023 12:28:42 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.28.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:28:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 61a6acfa-e856-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969321; x=1685561321; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AVVNU1/Z0e3e15xLpxnmg1YI8sj9yavBZMAv1HCyq4s=; b=LLYF3e7E/amT0QC9X83jr8STEh2LEyhiKwXOflj4vOGUUQ80STkux/B3tsBPRR+iZs Z8PEklKtnrf1ANY0yS+7B3mEyOHWcYHngOK95uUUv6xkoIQMHojULkOYhoKI4Ni0FrP2 S5NHFGXLQHvwvsG30gws5NVKvTRiKsyEh3YkA8qvjSZ3/KlMdDYEuevU5tP8u4iNYhu8 1xlMd7KFd1vYjOGrW/3tOSP+nbu4BvTDU3KzWxrFnBRpLAae4H3q3HG2nt2iYhftpMs0 U6/yXrewj3zrB5xufQ+HtnH4MYxc4pcXaT4tSeTPWcq6jVXUA+PWNym9caGo+Q16VqPL FcqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969321; x=1685561321; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AVVNU1/Z0e3e15xLpxnmg1YI8sj9yavBZMAv1HCyq4s=; b=BKnhzzmvCN/Amaj/D9Nt0ZySP6FnPX53PaBviAcESuScggmKPzvQUAfvVxn38nL9Q6 hgbfus573AFC7/X593C6Gkx93mueeEc4hDOG7istpgeV2mXQaYe/ZvYI8QwuveIvn9NI O17ZjXPOR6eitKLagHdzcVdJdIjQNVwKJHFN4wm1lbMwCtBj44tNJmiYWhI+KOX2RII/ ZGjELyhu+5nY0pAkp/lEhkjt3YZ3zCz6LMVqZ2kEX+fup+vnJ6QL8KkCtNT3zVrH0a4+ eAskB6BCcNjQX4CzQYqnyAxSL4ZP2RUxGMOH9wGwZcBNkLqE1Ny7jdzRGyrvbHK4V/k3 uh8Q== X-Gm-Message-State: AC+VfDztfPtpebbzDkZ0uz2WIHW+jsVa9KR6ECrHJMfCM9H0f+p2izv0 q++dWIAa8oixpgr4wLhgZJ0= X-Google-Smtp-Source: ACHHUZ5YKwOgPLgh0+tsSaYrcdi28QhyEeU0Z2KklUkfZ7L+H63PFxAPQAkXwR8Vmhp1bd6sZvpxeg== X-Received: by 2002:a17:902:f814:b0:1a0:50bd:31a8 with SMTP id ix20-20020a170902f81400b001a050bd31a8mr14734719plb.26.1682969321461; Mon, 01 May 2023 12:28:41 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" Subject: [PATCH v2 05/34] mm: add utility functions for ptdesc Date: Mon, 1 May 2023 12:28:00 -0700 Message-Id: <20230501192829.17086-6-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Introduce utility functions setting the foundation for ptdescs. These will also assist in the splitting out of ptdesc from struct page. ptdesc_alloc() is defined to allocate new ptdesc pages as compound pages. This is to standardize ptdescs by allowing for one allocation and one free function, in contrast to 2 allocation and 2 free functions. Signed-off-by: Vishal Moola (Oracle) --- include/asm-generic/tlb.h | 11 ++++++++++ include/linux/mm.h | 44 +++++++++++++++++++++++++++++++++++++++ include/linux/pgtable.h | 12 +++++++++++ 3 files changed, 67 insertions(+) diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h index b46617207c93..6bade9e0e799 100644 --- a/include/asm-generic/tlb.h +++ b/include/asm-generic/tlb.h @@ -481,6 +481,17 @@ static inline void tlb_remove_page(struct mmu_gather *tlb, struct page *page) return tlb_remove_page_size(tlb, page, PAGE_SIZE); } +static inline void tlb_remove_ptdesc(struct mmu_gather *tlb, void *pt) +{ + tlb_remove_table(tlb, pt); +} + +/* Like tlb_remove_ptdesc, but for page-like page directories. */ +static inline void tlb_remove_page_ptdesc(struct mmu_gather *tlb, struct ptdesc *pt) +{ + tlb_remove_page(tlb, ptdesc_page(pt)); +} + static inline void tlb_change_page_size(struct mmu_gather *tlb, unsigned int page_size) { diff --git a/include/linux/mm.h b/include/linux/mm.h index b18848ae7e22..258f3b730359 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2744,6 +2744,45 @@ static inline pmd_t *pmd_alloc(struct mm_struct *mm, pud_t *pud, unsigned long a } #endif /* CONFIG_MMU */ +static inline struct ptdesc *virt_to_ptdesc(const void *x) +{ + return page_ptdesc(virt_to_head_page(x)); +} + +static inline void *ptdesc_to_virt(const struct ptdesc *pt) +{ + return page_to_virt(ptdesc_page(pt)); +} + +static inline void *ptdesc_address(const struct ptdesc *pt) +{ + return folio_address(ptdesc_folio(pt)); +} + +static inline bool ptdesc_is_reserved(struct ptdesc *pt) +{ + return folio_test_reserved(ptdesc_folio(pt)); +} + +static inline struct ptdesc *ptdesc_alloc(gfp_t gfp, unsigned int order) +{ + struct page *page = alloc_pages(gfp | __GFP_COMP, order); + + return page_ptdesc(page); +} + +static inline void ptdesc_free(struct ptdesc *pt) +{ + struct page *page = ptdesc_page(pt); + + __free_pages(page, compound_order(page)); +} + +static inline void ptdesc_clear(void *x) +{ + clear_page(x); +} + #if USE_SPLIT_PTE_PTLOCKS #if ALLOC_SPLIT_PTLOCKS void __init ptlock_cache_init(void); @@ -2970,6 +3009,11 @@ static inline void mark_page_reserved(struct page *page) adjust_managed_page_count(page, -1); } +static inline void free_reserved_ptdesc(struct ptdesc *pt) +{ + free_reserved_page(ptdesc_page(pt)); +} + /* * Default method to free all the __init memory into the buddy system. * The freed pages will be poisoned with pattern "poison" if it's within diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h index 5e0f51308724..b067ac10f3dd 100644 --- a/include/linux/pgtable.h +++ b/include/linux/pgtable.h @@ -1041,6 +1041,18 @@ TABLE_MATCH(ptl, ptl); #undef TABLE_MATCH static_assert(sizeof(struct ptdesc) <= sizeof(struct page)); +#define ptdesc_page(pt) (_Generic((pt), \ + const struct ptdesc *: (const struct page *)(pt), \ + struct ptdesc *: (struct page *)(pt))) + +#define ptdesc_folio(pt) (_Generic((pt), \ + const struct ptdesc *: (const struct folio *)(pt), \ + struct ptdesc *: (struct folio *)(pt))) + +#define page_ptdesc(p) (_Generic((p), \ + const struct page *: (const struct ptdesc *)(p), \ + struct page *: (struct ptdesc *)(p))) + /* * No-op macros that just return the current protection value. Defined here * because these macros can be used even if CONFIG_MMU is not defined. -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:28:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:28:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528085.820727 (Exim 4.92) (envelope-from ) id 1ptZCY-0007rl-EP; Mon, 01 May 2023 19:28:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528085.820727; Mon, 01 May 2023 19:28:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCY-0007rb-Ak; Mon, 01 May 2023 19:28:46 +0000 Received: by outflank-mailman (input) for mailman id 528085; Mon, 01 May 2023 19:28:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCW-0006FS-Qz for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:28:44 +0000 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [2607:f8b0:4864:20::636]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6270271e-e856-11ed-b225-6b7b168915f2; Mon, 01 May 2023 21:28:44 +0200 (CEST) Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1aaf91ae451so11829955ad.1 for ; Mon, 01 May 2023 12:28:44 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.28.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:28:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6270271e-e856-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969323; x=1685561323; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0Ii9PvRdhTMRqBop+JFdKAWa6G/XpZkmB9p8iHmrwUc=; b=lFLswDg0HvrPkF+dtbJhg/asaCBgi3e00w4opfv2mri4GHWG5ahGHxm9sLAnqC4qbq cQ+9MPTjwHhlk51h4w8lOE5zFHDICMVPmNnmwWW2l0krumAZ2PDeWC1WEjJOX3LShLcV g0uvqMJBbig8RslrcZc6EAJCiGxazADIIfKt9bAt8yGDMo+5nIH4mdhXs+LaHQV1OVik U1EjmbMLOLA/7Pwt5TKTUK+w95+W73jVDYdL+HuxsLXipLy8KET4HB50FeUWTlZzXbc3 qFSctTNSvV8Q7v0NapgoBkUZ/cCAkZoFPz8ver9uL6iYj4+bfmoOnnABcA11qHjnQcrq /yHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969323; x=1685561323; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0Ii9PvRdhTMRqBop+JFdKAWa6G/XpZkmB9p8iHmrwUc=; b=SgrQb5ed8EXUqfeBjnrlY8KNetBLwNG92i12AEztZMKx2YEZCFv5+0PdyT+NLFrCUD xW7oVXy4J4j67VFoF0RmEL8Gjd/5yLRPoMA1T/R1QkxiAb52V6RZlv2cKE8+dGl1h5bu iIJGhrk56PzAI1/hRRiffzQrTdOwY2HSUHsiET2umF9sjxYubGn72NnYky0aMV5fjoNO 10aZSlcygCQKeFZ4azDhEppGPR3HrhsyKi3i0tVkKx9nmmWyHw45UPOmS5odIxBobA/v PDgeevov+JdyNE7Cu46q8gqajcbVux2wWyJUNpzXXQiGGbcSKNjPkIe3Hcs1WwawCJwC 9sLQ== X-Gm-Message-State: AC+VfDxtWc5NoG8KDquUEPZWw44CSMjGKqwEIKl7+nOXFxtuPyXlW6tW OAetJDRRPYpMw/xnLpqGfhM= X-Google-Smtp-Source: ACHHUZ4gWlsAH/48zhDdvicQeallszzZORdrHEFL4BiABQ6zj3x4/LHvqIQGrX0uRjqorCk+ulIxBg== X-Received: by 2002:a17:902:e805:b0:1aa:f6c3:ba24 with SMTP id u5-20020a170902e80500b001aaf6c3ba24mr5259994plg.4.1682969322807; Mon, 01 May 2023 12:28:42 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" Subject: [PATCH v2 06/34] mm: Convert pmd_pgtable_page() to pmd_ptdesc() Date: Mon, 1 May 2023 12:28:01 -0700 Message-Id: <20230501192829.17086-7-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Converts pmd_pgtable_page() to pmd_ptdesc() and all its callers. This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Signed-off-by: Vishal Moola (Oracle) --- include/linux/mm.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 258f3b730359..62c1635a9d44 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2892,15 +2892,15 @@ static inline void pgtable_pte_page_dtor(struct page *page) #if USE_SPLIT_PMD_PTLOCKS -static inline struct page *pmd_pgtable_page(pmd_t *pmd) +static inline struct ptdesc *pmd_ptdesc(pmd_t *pmd) { unsigned long mask = ~(PTRS_PER_PMD * sizeof(pmd_t) - 1); - return virt_to_page((void *)((unsigned long) pmd & mask)); + return virt_to_ptdesc((void *)((unsigned long) pmd & mask)); } static inline spinlock_t *pmd_lockptr(struct mm_struct *mm, pmd_t *pmd) { - return ptlock_ptr(pmd_pgtable_page(pmd)); + return ptlock_ptr(ptdesc_page(pmd_ptdesc(pmd))); } static inline bool pmd_ptlock_init(struct page *page) @@ -2919,7 +2919,7 @@ static inline void pmd_ptlock_free(struct page *page) ptlock_free(page); } -#define pmd_huge_pte(mm, pmd) (pmd_pgtable_page(pmd)->pmd_huge_pte) +#define pmd_huge_pte(mm, pmd) (pmd_ptdesc(pmd)->pmd_huge_pte) #else -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:28:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:28:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528086.820737 (Exim 4.92) (envelope-from ) id 1ptZCb-0008Ec-0T; Mon, 01 May 2023 19:28:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528086.820737; Mon, 01 May 2023 19:28:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCa-0008EM-SH; Mon, 01 May 2023 19:28:48 +0000 Received: by outflank-mailman (input) for mailman id 528086; Mon, 01 May 2023 19:28:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCZ-0006PY-7Y for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:28:47 +0000 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [2607:f8b0:4864:20::636]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 633ee4c7-e856-11ed-8611-37d641c3527e; Mon, 01 May 2023 21:28:45 +0200 (CEST) Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1aaf70676b6so9588205ad.3 for ; Mon, 01 May 2023 12:28:45 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.28.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:28:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 633ee4c7-e856-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969324; x=1685561324; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+5AaOHEPf+h0pPpRdylr/G5bcmt7vW9RVYKqYfsRH1I=; b=roKi10VJs9dRiilqVeW0uT+zBJLQBRTUlVbgvCysCoLkLcBaFtSDJFWEbNs2bywIGo H3vsreWJ1ZpYCtBmz7ULTfsdWW+yedXBXQs/IwteaEsgFryEWzy4p352hRLq6aefxJE1 6kRZZ9T8eU7cXFjWBj8Pc1GfIk6+0XR5y+mT0ED8uGwr4lyimQw2Z0aiiwvL0/TUCnLz 1YAzhf+9hpLKk/t8M1Z7w1Ox1h7cTnYF1yo9NW5nVgHqgkVIivMOhZpN29c9g57SmIug sEztd2i0kQBJZgz4HOMkQSUf4qdi6lxWXkVGt+hsJgx7i60d4BQr0JdQ/AyxEv6LKtIb /zeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969324; x=1685561324; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+5AaOHEPf+h0pPpRdylr/G5bcmt7vW9RVYKqYfsRH1I=; b=Myj+F+dUyBf1v8Fii5xxIGvNRrna+BUMNmxg2Hd8mIq9c0gK07Qr2U8Suvgllt/285 Be9bgp2qhaU9XbigIRze2mtPariYjKapyktuoaFdZFNi5S8B2Zkn5OfnLdEczQ28NJ2o YGhACrOqxg4q5pgHxD9OPftyc2yzWqAl1IwtSn4/H1a5WBaJaLMeUybk+pTID+B3j+Ki BLLeXugq4AnQNXTqjfiBDCcC/zOUhU7zdBs+9D5THIau5ogkwx1QC+u6GB70VeLtNCgy aDsDcwp8kwxlWzn6zYlUP59XbaYS8xqmL9LgvrtpOAYVeAIjbcY7jpkMYPqh9Ar+kbJ+ CJ2Q== X-Gm-Message-State: AC+VfDzM0njJXwerqMGN+Fo9hEcNvQPHApTYITwaZwXzbzXK1j6aOGb/ x72MERJhR33F7LqsTvFtXg4= X-Google-Smtp-Source: ACHHUZ4PPvDcr1ZSfGKsFuoX96n8X09PGID8nEMj55TFVd8R4rz9suoKbv6A+ENi8FZ5wQLN727S7w== X-Received: by 2002:a17:902:ca0d:b0:1a6:5274:c1b0 with SMTP id w13-20020a170902ca0d00b001a65274c1b0mr12751445pld.60.1682969324101; Mon, 01 May 2023 12:28:44 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" Subject: [PATCH v2 07/34] mm: Convert ptlock_alloc() to use ptdescs Date: Mon, 1 May 2023 12:28:02 -0700 Message-Id: <20230501192829.17086-8-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Signed-off-by: Vishal Moola (Oracle) --- include/linux/mm.h | 6 +++--- mm/memory.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 62c1635a9d44..565da5f39376 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2786,7 +2786,7 @@ static inline void ptdesc_clear(void *x) #if USE_SPLIT_PTE_PTLOCKS #if ALLOC_SPLIT_PTLOCKS void __init ptlock_cache_init(void); -extern bool ptlock_alloc(struct page *page); +bool ptlock_alloc(struct ptdesc *ptdesc); extern void ptlock_free(struct page *page); static inline spinlock_t *ptlock_ptr(struct page *page) @@ -2798,7 +2798,7 @@ static inline void ptlock_cache_init(void) { } -static inline bool ptlock_alloc(struct page *page) +static inline bool ptlock_alloc(struct ptdesc *ptdesc) { return true; } @@ -2828,7 +2828,7 @@ static inline bool ptlock_init(struct page *page) * slab code uses page->slab_cache, which share storage with page->ptl. */ VM_BUG_ON_PAGE(*(unsigned long *)&page->ptl, page); - if (!ptlock_alloc(page)) + if (!ptlock_alloc(page_ptdesc(page))) return false; spin_lock_init(ptlock_ptr(page)); return true; diff --git a/mm/memory.c b/mm/memory.c index 5e2c6b1fc00e..ba0dd1b2d616 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -5939,14 +5939,14 @@ void __init ptlock_cache_init(void) SLAB_PANIC, NULL); } -bool ptlock_alloc(struct page *page) +bool ptlock_alloc(struct ptdesc *ptdesc) { spinlock_t *ptl; ptl = kmem_cache_alloc(page_ptl_cachep, GFP_KERNEL); if (!ptl) return false; - page->ptl = ptl; + ptdesc->ptl = ptl; return true; } -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:28:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:28:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528087.820743 (Exim 4.92) (envelope-from ) id 1ptZCb-0008KS-Jl; Mon, 01 May 2023 19:28:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528087.820743; Mon, 01 May 2023 19:28:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCb-0008Ip-9O; Mon, 01 May 2023 19:28:49 +0000 Received: by outflank-mailman (input) for mailman id 528087; Mon, 01 May 2023 19:28:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCa-0006PY-Jj for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:28:48 +0000 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [2607:f8b0:4864:20::62f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6416506e-e856-11ed-8611-37d641c3527e; Mon, 01 May 2023 21:28:47 +0200 (CEST) Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1aafa03f541so12193395ad.0 for ; Mon, 01 May 2023 12:28:47 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.28.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:28:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6416506e-e856-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969325; x=1685561325; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dsNph+IH8G9kAdlfpPDvdsVRvR3y4GWwc24n4bCHoNE=; b=ORzYAt4fgaepA0jj/nxqG5QCQUnwh7Hd86B8NHpvgQ9XS5bxCw6FjAddYAhSWVBGhs RguloM+rsX2sX5k8L8jQmcK3uoCnItaXGukxO2sNFKQkHNbJapaDcmG0iMAuRZwI8f8t xe4tIz8OOyBZAi/AlwagFAtmsldgUDQdHIa2vdidJh9lpo3fAW1D+2jPZJhQXOxhvdZs c4hk+WfixJsxNAANDMRcuNKXIxHiA6rEY6QaL0IGeoKtL1JoS6dBJBARbulTJ6NVKxdj 8lac9J2KQ3hHBoBfb7fQ//alN+wtsMCP7K7b5tVdh9EZXnnMD2pBGWAPXyEldDpkm7ax zAvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969325; x=1685561325; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dsNph+IH8G9kAdlfpPDvdsVRvR3y4GWwc24n4bCHoNE=; b=ZaiErvj8TPLWpxsSqn9Dgzlq/HirYyxLyNcGFr8PQvMHYRGG8yrgNCecvT11dSLtsd pK5OuzCwzI3JhZXo98VzwVqLhi1bRMa67P7mxybf2cqaNm2cxjSAFy3eXD/oCd6YierZ yV7NsQGbOSPLan0UwWAytGFNhymXdLGMXnBfE7eDRHVHBWwJiiOUl9QqsU1LWKtxkHf9 CKF4WvTjdo+oQRcbDqgDBObqz9f3ouyBB88ajY8iFLLxeJ8tYxhk/fm0qsLMbqR45uzL vQWlTykP1pC4+9ROj5rnVwrqhLxIHppgJZrW01qQWrKO0xtfwZXWGV+R57UG8X/DDTQO sX+Q== X-Gm-Message-State: AC+VfDz845i7BpAdJX4TFQSS7VMFvjEPbvq4r03d0QAM9Dh2IC8Cwwx9 DPHeqjufSKa2kcgUI3xXXtg= X-Google-Smtp-Source: ACHHUZ6Hyp/uTZNVOfbVle27YVii8Y9q7eyatfM6y5VDboeAGhZWSkyjhlYeOczpnOUzLbM+Y5y88w== X-Received: by 2002:a17:902:da90:b0:1a9:b902:84b9 with SMTP id j16-20020a170902da9000b001a9b90284b9mr18090785plx.24.1682969325399; Mon, 01 May 2023 12:28:45 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" , Dave Hansen Subject: [PATCH v2 08/34] mm: Convert ptlock_ptr() to use ptdescs Date: Mon, 1 May 2023 12:28:03 -0700 Message-Id: <20230501192829.17086-9-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Signed-off-by: Vishal Moola (Oracle) --- arch/x86/xen/mmu_pv.c | 2 +- include/linux/mm.h | 14 +++++++------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c index fdc91deece7e..a1c9f8dcbb5a 100644 --- a/arch/x86/xen/mmu_pv.c +++ b/arch/x86/xen/mmu_pv.c @@ -651,7 +651,7 @@ static spinlock_t *xen_pte_lock(struct page *page, struct mm_struct *mm) spinlock_t *ptl = NULL; #if USE_SPLIT_PTE_PTLOCKS - ptl = ptlock_ptr(page); + ptl = ptlock_ptr(page_ptdesc(page)); spin_lock_nest_lock(ptl, &mm->page_table_lock); #endif diff --git a/include/linux/mm.h b/include/linux/mm.h index 565da5f39376..49fdc1199bd4 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2789,9 +2789,9 @@ void __init ptlock_cache_init(void); bool ptlock_alloc(struct ptdesc *ptdesc); extern void ptlock_free(struct page *page); -static inline spinlock_t *ptlock_ptr(struct page *page) +static inline spinlock_t *ptlock_ptr(struct ptdesc *ptdesc) { - return page->ptl; + return ptdesc->ptl; } #else /* ALLOC_SPLIT_PTLOCKS */ static inline void ptlock_cache_init(void) @@ -2807,15 +2807,15 @@ static inline void ptlock_free(struct page *page) { } -static inline spinlock_t *ptlock_ptr(struct page *page) +static inline spinlock_t *ptlock_ptr(struct ptdesc *ptdesc) { - return &page->ptl; + return &ptdesc->ptl; } #endif /* ALLOC_SPLIT_PTLOCKS */ static inline spinlock_t *pte_lockptr(struct mm_struct *mm, pmd_t *pmd) { - return ptlock_ptr(pmd_page(*pmd)); + return ptlock_ptr(page_ptdesc(pmd_page(*pmd))); } static inline bool ptlock_init(struct page *page) @@ -2830,7 +2830,7 @@ static inline bool ptlock_init(struct page *page) VM_BUG_ON_PAGE(*(unsigned long *)&page->ptl, page); if (!ptlock_alloc(page_ptdesc(page))) return false; - spin_lock_init(ptlock_ptr(page)); + spin_lock_init(ptlock_ptr(page_ptdesc(page))); return true; } @@ -2900,7 +2900,7 @@ static inline struct ptdesc *pmd_ptdesc(pmd_t *pmd) static inline spinlock_t *pmd_lockptr(struct mm_struct *mm, pmd_t *pmd) { - return ptlock_ptr(ptdesc_page(pmd_ptdesc(pmd))); + return ptlock_ptr(pmd_ptdesc(pmd)); } static inline bool pmd_ptlock_init(struct page *page) -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:28:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:28:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528088.820748 (Exim 4.92) (envelope-from ) id 1ptZCc-0008Sh-42; Mon, 01 May 2023 19:28:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528088.820748; Mon, 01 May 2023 19:28:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCb-0008Rj-TB; Mon, 01 May 2023 19:28:49 +0000 Received: by outflank-mailman (input) for mailman id 528088; Mon, 01 May 2023 19:28:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCa-0006FS-M8 for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:28:48 +0000 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [2607:f8b0:4864:20::436]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 64bdc27d-e856-11ed-b225-6b7b168915f2; Mon, 01 May 2023 21:28:48 +0200 (CEST) Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-63b4bf2d74aso1995444b3a.2 for ; Mon, 01 May 2023 12:28:48 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.28.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:28:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 64bdc27d-e856-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969327; x=1685561327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Qr6GrFg3nf2tpOD8Orpodgx1J1bZoReYY/j4MOttH8M=; b=UIGt4Rxs2HkrsHutpAYaiWsjpykN6YUUd9E7lUyM0xl9pxC5slr+PivAMCf0kJWRtN +uixoPZwp4Vkl4YHEUToQjjzNjvIathQteky2ye14eE7NbHDFgUdPJKRNVXQAhEugOmA SnKo0+DWLOVbHHUZvAiFOaLnHaj2/1PYZhJmFGNiABpmjR+0nby25eJKrDAKj84VfLsp mCPKXur9uRrX02YRe2GBv91KFh4j6FQNTVZMtFBm8+b26dYihW/DQX+FZ7CAta9Gp4QP rZEIiymi83HRxeSWeuBi69l3Fo9OQWMSSxYcww0ZzqBAzl9SsUUSi153JEf/pt3dBwk3 OFrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969327; x=1685561327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Qr6GrFg3nf2tpOD8Orpodgx1J1bZoReYY/j4MOttH8M=; b=mBDn8X5cnHuoFXjjcT8BsjiLmWtWg+ByKxzF6EUM+fSRwMQDuO4CS/rjVKUbh2ItGZ a7Wc6b3cxy4t3fcsypcmjaP5IoKADDpqZ80DClLJ6I/NnxwssAdqmDhtkTb3GCIaPfFr LeFUPm5jWv6uPBds+UKJADXhEiIgD5tP992zbl0wJZzKV+Ts0RXR/o4p5VrAJ36YrDBm 7ze0WfDMlikksEsf72DFemxeB0bxwrdNFxiC83YKYRkti+NsP4s1Tfpp/FWTQgne6L44 qw9JkIMw+TJeI8SLRniyRKY5RQowN/+W4Fw0S7iLwMcorV5XZfOW5XPtNRU88XxzVzub c/yw== X-Gm-Message-State: AC+VfDwb2Oqs9t/6QfBA50tLhUOh0ELrfhF+sMsNGvou5e00mmnRcy/d kNHrLqfPxy37ZNDt9BrDvCQ= X-Google-Smtp-Source: ACHHUZ7U6exPykPvKxCgekHmX9KTHTAx49eIcN0vG+aTw+3qX+uTyRXMYpekTZ9RZqGTjPxZ9ZewtA== X-Received: by 2002:a17:902:ecca:b0:1a6:4127:857 with SMTP id a10-20020a170902ecca00b001a641270857mr17426348plh.5.1682969326811; Mon, 01 May 2023 12:28:46 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" Subject: [PATCH v2 09/34] mm: Convert pmd_ptlock_init() to use ptdescs Date: Mon, 1 May 2023 12:28:04 -0700 Message-Id: <20230501192829.17086-10-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Signed-off-by: Vishal Moola (Oracle) --- include/linux/mm.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 49fdc1199bd4..044c9f874b47 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2903,12 +2903,12 @@ static inline spinlock_t *pmd_lockptr(struct mm_struct *mm, pmd_t *pmd) return ptlock_ptr(pmd_ptdesc(pmd)); } -static inline bool pmd_ptlock_init(struct page *page) +static inline bool pmd_ptlock_init(struct ptdesc *ptdesc) { #ifdef CONFIG_TRANSPARENT_HUGEPAGE - page->pmd_huge_pte = NULL; + ptdesc->pmd_huge_pte = NULL; #endif - return ptlock_init(page); + return ptlock_init(ptdesc_page(ptdesc)); } static inline void pmd_ptlock_free(struct page *page) @@ -2928,7 +2928,7 @@ static inline spinlock_t *pmd_lockptr(struct mm_struct *mm, pmd_t *pmd) return &mm->page_table_lock; } -static inline bool pmd_ptlock_init(struct page *page) { return true; } +static inline bool pmd_ptlock_init(struct ptdesc *ptdesc) { return true; } static inline void pmd_ptlock_free(struct page *page) {} #define pmd_huge_pte(mm, pmd) ((mm)->pmd_huge_pte) @@ -2944,7 +2944,7 @@ static inline spinlock_t *pmd_lock(struct mm_struct *mm, pmd_t *pmd) static inline bool pgtable_pmd_page_ctor(struct page *page) { - if (!pmd_ptlock_init(page)) + if (!pmd_ptlock_init(page_ptdesc(page))) return false; __SetPageTable(page); inc_lruvec_page_state(page, NR_PAGETABLE); -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:28:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:28:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528089.820763 (Exim 4.92) (envelope-from ) id 1ptZCd-0000X6-U5; Mon, 01 May 2023 19:28:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528089.820763; Mon, 01 May 2023 19:28:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCd-0000VZ-Iy; Mon, 01 May 2023 19:28:51 +0000 Received: by outflank-mailman (input) for mailman id 528089; Mon, 01 May 2023 19:28:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCc-0006FS-4y for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:28:50 +0000 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [2607:f8b0:4864:20::633]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6592313f-e856-11ed-b225-6b7b168915f2; Mon, 01 May 2023 21:28:49 +0200 (CEST) Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1aaec6f189cso12397105ad.3 for ; Mon, 01 May 2023 12:28:49 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.28.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:28:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6592313f-e856-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969328; x=1685561328; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wHprEtJ9ence/xzqPBz4IJf2z5UW2zl5tMMosQGe/i0=; b=PY19zV8eUjDo/XMGG1Fc34r7BzCEZH74vj9MdJuOaMu+i1F5EHabpfUbH5/UkV5r7u xDPodd9s+AIKUKlEgX8AIGrVTqPfTCCV19VkI5iB53+1hWJANYdEVCUSRnMghYWfpO7M cjlz4mTJKg6lVp3kGic5xzqQRsLBSUE+d02rlXiSiKdYRR/2g0lktCdvpXk87E+WP0bW PyWsq2WmVkZLx+/D9I3aZnTNSq5u2Ks8EcfSEB3bP53mV0saqVpK3cKwl8Vm7ptPZTKs sMCaD1Y/vK3rtRXkw0c64x6M8sUBtgZ+i4WFX1gLvu6Qtr7y6/c6crVIx9ttRb0VBr94 CwWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969328; x=1685561328; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wHprEtJ9ence/xzqPBz4IJf2z5UW2zl5tMMosQGe/i0=; b=KXyuKi4bo/iCqBPVF8ZCJGKSGjpRpl1vCadgEPYiKguLrX69jnD/aDP2BkgnyusoFd 5mOWc1ArvHAqZSINYzz6j/wR3c5i9usJdyVuuPFzjz8nAHrpqm0MIeapW+aiorH9xiIB ZcKif6SbLDmqUqlLtkRy4ERv9gmGqa6xrycjcLlbRuRHKotNLZ+CSm9ydgfHvWQZfRdM kfcPUWb4So32O4isg2IrHVc4tSJnZdJVr6wokrQeTbuNPgSCAfIkNMEeWb/bwjR6z1u1 GEktbBnDjfwYSyOmKX0V0qkITXTU2QsjATcRyNIGtjvGwnM7Oe4MMszLrfwkpAYCqRf+ zKmQ== X-Gm-Message-State: AC+VfDxeQXuNopKQ9iEmfMRh87PvxaSfCur+0z89v6dtogbJsWGABBQ/ NaY0jDL6br606Ykj9vAvGKM= X-Google-Smtp-Source: ACHHUZ7Z//gnFWu5Wh7IVebCi2ECb1TkUFb7V74C+bMLVwpZ6jGbtiv1kPkjLZLQcQGCrs+Dltn26Q== X-Received: by 2002:a17:902:c745:b0:1a6:6fe3:df91 with SMTP id q5-20020a170902c74500b001a66fe3df91mr11845223plq.50.1682969328214; Mon, 01 May 2023 12:28:48 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" Subject: [PATCH v2 10/34] mm: Convert ptlock_init() to use ptdescs Date: Mon, 1 May 2023 12:28:05 -0700 Message-Id: <20230501192829.17086-11-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Signed-off-by: Vishal Moola (Oracle) --- include/linux/mm.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 044c9f874b47..bbd44f43e375 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2818,7 +2818,7 @@ static inline spinlock_t *pte_lockptr(struct mm_struct *mm, pmd_t *pmd) return ptlock_ptr(page_ptdesc(pmd_page(*pmd))); } -static inline bool ptlock_init(struct page *page) +static inline bool ptlock_init(struct ptdesc *ptdesc) { /* * prep_new_page() initialize page->private (and therefore page->ptl) @@ -2827,10 +2827,10 @@ static inline bool ptlock_init(struct page *page) * It can happen if arch try to use slab for page table allocation: * slab code uses page->slab_cache, which share storage with page->ptl. */ - VM_BUG_ON_PAGE(*(unsigned long *)&page->ptl, page); - if (!ptlock_alloc(page_ptdesc(page))) + VM_BUG_ON_PAGE(*(unsigned long *)&ptdesc->ptl, ptdesc_page(ptdesc)); + if (!ptlock_alloc(ptdesc)) return false; - spin_lock_init(ptlock_ptr(page_ptdesc(page))); + spin_lock_init(ptlock_ptr(ptdesc)); return true; } @@ -2843,13 +2843,13 @@ static inline spinlock_t *pte_lockptr(struct mm_struct *mm, pmd_t *pmd) return &mm->page_table_lock; } static inline void ptlock_cache_init(void) {} -static inline bool ptlock_init(struct page *page) { return true; } +static inline bool ptlock_init(struct ptdesc *ptdesc) { return true; } static inline void ptlock_free(struct page *page) {} #endif /* USE_SPLIT_PTE_PTLOCKS */ static inline bool pgtable_pte_page_ctor(struct page *page) { - if (!ptlock_init(page)) + if (!ptlock_init(page_ptdesc(page))) return false; __SetPageTable(page); inc_lruvec_page_state(page, NR_PAGETABLE); @@ -2908,7 +2908,7 @@ static inline bool pmd_ptlock_init(struct ptdesc *ptdesc) #ifdef CONFIG_TRANSPARENT_HUGEPAGE ptdesc->pmd_huge_pte = NULL; #endif - return ptlock_init(ptdesc_page(ptdesc)); + return ptlock_init(ptdesc); } static inline void pmd_ptlock_free(struct page *page) -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:28:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:28:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528090.820777 (Exim 4.92) (envelope-from ) id 1ptZCg-0001BU-Bc; Mon, 01 May 2023 19:28:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528090.820777; Mon, 01 May 2023 19:28:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCg-0001A9-3s; Mon, 01 May 2023 19:28:54 +0000 Received: by outflank-mailman (input) for mailman id 528090; Mon, 01 May 2023 19:28:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCe-0006PY-IW for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:28:52 +0000 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [2607:f8b0:4864:20::62f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 66769ded-e856-11ed-8611-37d641c3527e; Mon, 01 May 2023 21:28:51 +0200 (CEST) Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1aaf706768cso10981755ad.0 for ; Mon, 01 May 2023 12:28:51 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.28.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:28:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 66769ded-e856-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969329; x=1685561329; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qTcYn70jypAxoGiZWNhXW/f3wJ7PRfT+UBBqvcdtR7Y=; b=lB3Z6fcbmN3PCDkgSSAUdLyGGv/N+aWg88Xq/3YBAOLHjjeKvsEOyPJ7qOvQJsTwm/ r41UWIzlQ/5Ax+ha7xRNy8kdIkTNxjA3q1QX8n9bXAh3z/8wB6GEn84UnvlT4jKe1qmu sQyc9OGXZjTePH+r4Y6e6ozh0UMlJ+VYjsnu2YRncxwQaVJ+Cf7Nqth6cXAsabwTRyMX v6eeeBBdHDjqYX6OiT4X4zQkg5l42dCb/DNQDsMWC1atimcSE8JSmejQfjKp+N8Ip6uu zd2ZsR9jcfUX1/JB5xCLWPO6fdSMIACYocvg6A/MPAxkpU5nLiRN3WCB2A8Uz52//cN+ kz+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969329; x=1685561329; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qTcYn70jypAxoGiZWNhXW/f3wJ7PRfT+UBBqvcdtR7Y=; b=CHyRK/wx8jeHpdFXyIRmr/Wovzk2W1cxA2z6GMP/HyrEGKcf4VRhpScUDUK9JcP6AY q3a9H82+Y/KzV0n2dpO+DDdK6hLuQTPmqTdAlN+d3nfEYNcNudOQ9oN73f/8spaBMZNe TfRHcEjT+6bZ5tSXq+YcCX9SsgelYhyM8SwdchCxzPMMF45XUVMc5aYvmaUyxdwo/hg0 D+6gS0NQiFw/zyG1l53NaMPzbX4mJyaJsvBZUGC7pn5TrEQ579/66B6xx5xPtufOcy71 fs6rxGEBxZU+OW0+xTO2M4PGcj4meHAugB9/IVcLvfB60eRcWntH182G0evw/49pk0hJ CICA== X-Gm-Message-State: AC+VfDwuO6MNGd4F/dsO2Ew6uGt/FBh7xWxwhvZynkf+OQUGA32qaXkC VJrd2EBOvIQSEwDoaABqOUw= X-Google-Smtp-Source: ACHHUZ6RkKtjORSVVTbvqSb/nEXqQaQ9JTIasvSEW6m9mcivHjmudekwdvS8zsaYUeAaqoCEzf8v6w== X-Received: by 2002:a17:903:24c:b0:1a6:4a64:4d27 with SMTP id j12-20020a170903024c00b001a64a644d27mr17386318plh.40.1682969329458; Mon, 01 May 2023 12:28:49 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" Subject: [PATCH v2 11/34] mm: Convert pmd_ptlock_free() to use ptdescs Date: Mon, 1 May 2023 12:28:06 -0700 Message-Id: <20230501192829.17086-12-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Signed-off-by: Vishal Moola (Oracle) --- include/linux/mm.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index bbd44f43e375..a2a1bca84ada 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2911,12 +2911,12 @@ static inline bool pmd_ptlock_init(struct ptdesc *ptdesc) return ptlock_init(ptdesc); } -static inline void pmd_ptlock_free(struct page *page) +static inline void pmd_ptlock_free(struct ptdesc *ptdesc) { #ifdef CONFIG_TRANSPARENT_HUGEPAGE - VM_BUG_ON_PAGE(page->pmd_huge_pte, page); + VM_BUG_ON_PAGE(ptdesc->pmd_huge_pte, ptdesc_page(ptdesc)); #endif - ptlock_free(page); + ptlock_free(ptdesc_page(ptdesc)); } #define pmd_huge_pte(mm, pmd) (pmd_ptdesc(pmd)->pmd_huge_pte) @@ -2929,7 +2929,7 @@ static inline spinlock_t *pmd_lockptr(struct mm_struct *mm, pmd_t *pmd) } static inline bool pmd_ptlock_init(struct ptdesc *ptdesc) { return true; } -static inline void pmd_ptlock_free(struct page *page) {} +static inline void pmd_ptlock_free(struct ptdesc *ptdesc) {} #define pmd_huge_pte(mm, pmd) ((mm)->pmd_huge_pte) @@ -2953,7 +2953,7 @@ static inline bool pgtable_pmd_page_ctor(struct page *page) static inline void pgtable_pmd_page_dtor(struct page *page) { - pmd_ptlock_free(page); + pmd_ptlock_free(page_ptdesc(page)); __ClearPageTable(page); dec_lruvec_page_state(page, NR_PAGETABLE); } -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:28:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:28:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528091.820782 (Exim 4.92) (envelope-from ) id 1ptZCh-0001In-3W; Mon, 01 May 2023 19:28:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528091.820782; Mon, 01 May 2023 19:28:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCg-0001HT-NY; Mon, 01 May 2023 19:28:54 +0000 Received: by outflank-mailman (input) for mailman id 528091; Mon, 01 May 2023 19:28:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCe-0006FS-S4 for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:28:52 +0000 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [2607:f8b0:4864:20::436]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 67394254-e856-11ed-b225-6b7b168915f2; Mon, 01 May 2023 21:28:52 +0200 (CEST) Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-64115e652eeso29038905b3a.0 for ; Mon, 01 May 2023 12:28:52 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.28.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:28:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 67394254-e856-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969331; x=1685561331; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Mt3HE6L47sPJBYnAKPMz0/DxNRKvA6oRz72+XbjGX9E=; b=bRmqBPTZgCa5IrhecvrTPyLDuab4M/2pWmm67Ij9kB88cqyNYvHpKZf2c822tlLINs V7g4wokwjyA5yoaxqgkTwqtzjgfghwoIfl0NbPXtXdg2Gw3C4PIS2FYz/KLko7etiChc s5Y++dzV39ZBew8o5WYNHoWZR+E9Lx1p8UATOni2Z3kTd3MdcR3ji+KJhcCE5jLMM79j 4rcgjvbB4U2t2rwTpoiUyWgvBTuTWbg65E+Konk9GYsk7NMgNhoUvQ9jMEmXFDz/6lzW 5y5R3ETL6C6d8IdLyMxau5jgOeNqS9ewzuT1HexEBx4VHGUimuQrmfTb2llKzaIBnzUu BV2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969331; x=1685561331; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Mt3HE6L47sPJBYnAKPMz0/DxNRKvA6oRz72+XbjGX9E=; b=ffSG/0GCjz3zNdpHkJ+G7LNMN/+dvWjxSkdN4x5RiI+r/2S+eMtgsl3TQp1RyOtiLe hg8g6ucqu5VfHXT/25A57f+zzWMiS+Xf75vQm/3T2WvtcQ5KpioDt8DY63qDOX3QEDbV X0AYWmzTZILiglR/ay9LPdG2h9dIo/yOE00IOYbftmb1TM8LJIXjs1s5lG/qQeGu9DFS HA21nB/uHrVXBniNFKG3h61zDj3Yow/ewgu6kZxqBZh+HpCXeMMh43iO/dPjhmBMZWwN 5GkAPeCG2zLq6V9cbOJ4+c7jdoRog47YQiusHCAxaNxMytlY+z0L7Ze8G0+Kn90xlN2I +NyA== X-Gm-Message-State: AC+VfDzBTqFrUT3Lx7SRF6c6cst6CUfVfX+Y6PGos6vPRotq5tWvaCDk fMNHSu2T8pM1C5S53UklrGQ= X-Google-Smtp-Source: ACHHUZ6xNyoMsdtkeuJYwr4JFA16W7bSDCfft0wt/spwymptVQy+yHqySIROmads3b5d2VYC5oAliA== X-Received: by 2002:a17:902:ced1:b0:1a9:3c1d:66de with SMTP id d17-20020a170902ced100b001a93c1d66demr18699403plg.15.1682969330907; Mon, 01 May 2023 12:28:50 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" Subject: [PATCH v2 12/34] mm: Convert ptlock_free() to use ptdescs Date: Mon, 1 May 2023 12:28:07 -0700 Message-Id: <20230501192829.17086-13-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Signed-off-by: Vishal Moola (Oracle) --- include/linux/mm.h | 10 +++++----- mm/memory.c | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index a2a1bca84ada..58c911341a33 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2787,7 +2787,7 @@ static inline void ptdesc_clear(void *x) #if ALLOC_SPLIT_PTLOCKS void __init ptlock_cache_init(void); bool ptlock_alloc(struct ptdesc *ptdesc); -extern void ptlock_free(struct page *page); +void ptlock_free(struct ptdesc *ptdesc); static inline spinlock_t *ptlock_ptr(struct ptdesc *ptdesc) { @@ -2803,7 +2803,7 @@ static inline bool ptlock_alloc(struct ptdesc *ptdesc) return true; } -static inline void ptlock_free(struct page *page) +static inline void ptlock_free(struct ptdesc *ptdesc) { } @@ -2844,7 +2844,7 @@ static inline spinlock_t *pte_lockptr(struct mm_struct *mm, pmd_t *pmd) } static inline void ptlock_cache_init(void) {} static inline bool ptlock_init(struct ptdesc *ptdesc) { return true; } -static inline void ptlock_free(struct page *page) {} +static inline void ptlock_free(struct ptdesc *ptdesc) {} #endif /* USE_SPLIT_PTE_PTLOCKS */ static inline bool pgtable_pte_page_ctor(struct page *page) @@ -2858,7 +2858,7 @@ static inline bool pgtable_pte_page_ctor(struct page *page) static inline void pgtable_pte_page_dtor(struct page *page) { - ptlock_free(page); + ptlock_free(page_ptdesc(page)); __ClearPageTable(page); dec_lruvec_page_state(page, NR_PAGETABLE); } @@ -2916,7 +2916,7 @@ static inline void pmd_ptlock_free(struct ptdesc *ptdesc) #ifdef CONFIG_TRANSPARENT_HUGEPAGE VM_BUG_ON_PAGE(ptdesc->pmd_huge_pte, ptdesc_page(ptdesc)); #endif - ptlock_free(ptdesc_page(ptdesc)); + ptlock_free(ptdesc); } #define pmd_huge_pte(mm, pmd) (pmd_ptdesc(pmd)->pmd_huge_pte) diff --git a/mm/memory.c b/mm/memory.c index ba0dd1b2d616..7a0b36560e28 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -5950,8 +5950,8 @@ bool ptlock_alloc(struct ptdesc *ptdesc) return true; } -void ptlock_free(struct page *page) +void ptlock_free(struct ptdesc *ptdesc) { - kmem_cache_free(page_ptl_cachep, page->ptl); + kmem_cache_free(page_ptl_cachep, ptdesc->ptl); } #endif -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:28:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:28:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528092.820794 (Exim 4.92) (envelope-from ) id 1ptZCj-0001wY-Gp; Mon, 01 May 2023 19:28:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528092.820794; Mon, 01 May 2023 19:28:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCj-0001uS-33; Mon, 01 May 2023 19:28:57 +0000 Received: by outflank-mailman (input) for mailman id 528092; Mon, 01 May 2023 19:28:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCg-0006FS-PO for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:28:54 +0000 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [2607:f8b0:4864:20::62f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 68d01922-e856-11ed-b225-6b7b168915f2; Mon, 01 May 2023 21:28:54 +0200 (CEST) Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1a6762fd23cso23590835ad.3 for ; Mon, 01 May 2023 12:28:54 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.28.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:28:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 68d01922-e856-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969333; x=1685561333; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZNft63XW9H/x5zK6HuCJK1zZ20bn1woHqcJTdinQF34=; b=B5BQ0PUPuJOe03g2Zj4SmcYFdZoHhvQEhjHjXIrDV/cPLgWmHOnGLph27PMtDy+gUk vrb8aMyrjxs7+rH+bt4rcFQy1jeum2KTcgeZne4eID9YQx0p8xFIvsQDPlXa9T02F5bm XDuuEHyhAFLF/N4HXmu9lHkWjBlAxtCK794Vd1UTAVcPxs1s/UJDMyYjBVgG5TX0KFIE Ex1W8v+MyjG1XFcX2NmMKnrKsIeNEQB+OMbajwZPymWFDvUYoyj1bmkkKVL9eBJZnPmo n2i7pNy6eK/amTh+JnM4F05ImhBvIH/eExR134Xtgm68Uv7no3ItCNvBtZlMVAsp6dYE 5mrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969333; x=1685561333; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZNft63XW9H/x5zK6HuCJK1zZ20bn1woHqcJTdinQF34=; b=GJRWvVXqAfm2Q3W6BrbcOXznaet/bQRSDTNp+s1ufU6N0PY2IIIsMLTyImcRrscl2J 7YdOhzS0vXYS9IPptz6/hbUOBpY4lC0tdE/qBeT7EaUvdJMMCu/hr3PhS8HvZ1Hqb9Fy i6yg+CfnKrAdMOEfkcy82zUAhMfMOiNRadoItvyWusYLDz0ehuQ1ihe0Vqb8k1FSUSSa kesfoEC/xymiM15VebVNGfU+j1MpAI+31+BSgdU2yXGQDN5POk8pMfVzW/wgns8a+qut N38dkRKTpoOHOLgEDnKtJfR84/RSoDmXUAlC8TtkYLey+lWSJ3piiNx0hYxj45Vmc/GI fqQQ== X-Gm-Message-State: AC+VfDwURP2mL+gOsyuOSBKfuVvlR8vlFxA1aOFfnaZoCqXGSngItES7 UZW73UxQFUvAskYfx8m42xM= X-Google-Smtp-Source: ACHHUZ5/VRaG2onpIf15XR/3p6i4VphUhlpU8l14iUMmxT/o+LeZ6COrGbtS8DM/yhDOMNorlLAd2g== X-Received: by 2002:a17:902:d48b:b0:1a6:ef75:3c53 with SMTP id c11-20020a170902d48b00b001a6ef753c53mr18457119plg.11.1682969333517; Mon, 01 May 2023 12:28:53 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" Subject: [PATCH v2 14/34] powerpc: Convert various functions to use ptdescs Date: Mon, 1 May 2023 12:28:09 -0700 Message-Id: <20230501192829.17086-15-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In order to split struct ptdesc from struct page, convert various functions to use ptdescs. Signed-off-by: Vishal Moola (Oracle) --- arch/powerpc/mm/book3s64/mmu_context.c | 10 +++--- arch/powerpc/mm/book3s64/pgtable.c | 32 +++++++++--------- arch/powerpc/mm/pgtable-frag.c | 46 +++++++++++++------------- 3 files changed, 44 insertions(+), 44 deletions(-) diff --git a/arch/powerpc/mm/book3s64/mmu_context.c b/arch/powerpc/mm/book3s64/mmu_context.c index c766e4c26e42..b22ad2839897 100644 --- a/arch/powerpc/mm/book3s64/mmu_context.c +++ b/arch/powerpc/mm/book3s64/mmu_context.c @@ -246,15 +246,15 @@ static void destroy_contexts(mm_context_t *ctx) static void pmd_frag_destroy(void *pmd_frag) { int count; - struct page *page; + struct ptdesc *ptdesc; - page = virt_to_page(pmd_frag); + ptdesc = virt_to_ptdesc(pmd_frag); /* drop all the pending references */ count = ((unsigned long)pmd_frag & ~PAGE_MASK) >> PMD_FRAG_SIZE_SHIFT; /* We allow PTE_FRAG_NR fragments from a PTE page */ - if (atomic_sub_and_test(PMD_FRAG_NR - count, &page->pt_frag_refcount)) { - pgtable_pmd_page_dtor(page); - __free_page(page); + if (atomic_sub_and_test(PMD_FRAG_NR - count, &ptdesc->pt_frag_refcount)) { + ptdesc_pmd_dtor(ptdesc); + ptdesc_free(ptdesc); } } diff --git a/arch/powerpc/mm/book3s64/pgtable.c b/arch/powerpc/mm/book3s64/pgtable.c index 85c84e89e3ea..da46e3efc66c 100644 --- a/arch/powerpc/mm/book3s64/pgtable.c +++ b/arch/powerpc/mm/book3s64/pgtable.c @@ -306,22 +306,22 @@ static pmd_t *get_pmd_from_cache(struct mm_struct *mm) static pmd_t *__alloc_for_pmdcache(struct mm_struct *mm) { void *ret = NULL; - struct page *page; + struct ptdesc *ptdesc; gfp_t gfp = GFP_KERNEL_ACCOUNT | __GFP_ZERO; if (mm == &init_mm) gfp &= ~__GFP_ACCOUNT; - page = alloc_page(gfp); - if (!page) + ptdesc = ptdesc_alloc(gfp, 0); + if (!ptdesc) return NULL; - if (!pgtable_pmd_page_ctor(page)) { - __free_pages(page, 0); + if (!ptdesc_pmd_ctor(ptdesc)) { + ptdesc_free(ptdesc); return NULL; } - atomic_set(&page->pt_frag_refcount, 1); + atomic_set(&ptdesc->pt_frag_refcount, 1); - ret = page_address(page); + ret = ptdesc_address(ptdesc); /* * if we support only one fragment just return the * allocated page. @@ -331,12 +331,12 @@ static pmd_t *__alloc_for_pmdcache(struct mm_struct *mm) spin_lock(&mm->page_table_lock); /* - * If we find pgtable_page set, we return + * If we find ptdesc_page set, we return * the allocated page with single fragment * count. */ if (likely(!mm->context.pmd_frag)) { - atomic_set(&page->pt_frag_refcount, PMD_FRAG_NR); + atomic_set(&ptdesc->pt_frag_refcount, PMD_FRAG_NR); mm->context.pmd_frag = ret + PMD_FRAG_SIZE; } spin_unlock(&mm->page_table_lock); @@ -357,15 +357,15 @@ pmd_t *pmd_fragment_alloc(struct mm_struct *mm, unsigned long vmaddr) void pmd_fragment_free(unsigned long *pmd) { - struct page *page = virt_to_page(pmd); + struct ptdesc *ptdesc = virt_to_ptdesc(pmd); - if (PageReserved(page)) - return free_reserved_page(page); + if (ptdesc_is_reserved(ptdesc)) + return free_reserved_ptdesc(ptdesc); - BUG_ON(atomic_read(&page->pt_frag_refcount) <= 0); - if (atomic_dec_and_test(&page->pt_frag_refcount)) { - pgtable_pmd_page_dtor(page); - __free_page(page); + BUG_ON(atomic_read(&ptdesc->pt_frag_refcount) <= 0); + if (atomic_dec_and_test(&ptdesc->pt_frag_refcount)) { + ptdesc_pmd_dtor(ptdesc); + ptdesc_free(ptdesc); } } diff --git a/arch/powerpc/mm/pgtable-frag.c b/arch/powerpc/mm/pgtable-frag.c index 20652daa1d7e..b53e18fab74a 100644 --- a/arch/powerpc/mm/pgtable-frag.c +++ b/arch/powerpc/mm/pgtable-frag.c @@ -18,15 +18,15 @@ void pte_frag_destroy(void *pte_frag) { int count; - struct page *page; + struct ptdesc *ptdesc; - page = virt_to_page(pte_frag); + ptdesc = virt_to_ptdesc(pte_frag); /* drop all the pending references */ count = ((unsigned long)pte_frag & ~PAGE_MASK) >> PTE_FRAG_SIZE_SHIFT; /* We allow PTE_FRAG_NR fragments from a PTE page */ - if (atomic_sub_and_test(PTE_FRAG_NR - count, &page->pt_frag_refcount)) { - pgtable_pte_page_dtor(page); - __free_page(page); + if (atomic_sub_and_test(PTE_FRAG_NR - count, &ptdesc->pt_frag_refcount)) { + ptdesc_pte_dtor(ptdesc); + ptdesc_free(ptdesc); } } @@ -55,25 +55,25 @@ static pte_t *get_pte_from_cache(struct mm_struct *mm) static pte_t *__alloc_for_ptecache(struct mm_struct *mm, int kernel) { void *ret = NULL; - struct page *page; + struct ptdesc *ptdesc; if (!kernel) { - page = alloc_page(PGALLOC_GFP | __GFP_ACCOUNT); - if (!page) + ptdesc = ptdesc_alloc(PGALLOC_GFP | __GFP_ACCOUNT, 0); + if (!ptdesc) return NULL; - if (!pgtable_pte_page_ctor(page)) { - __free_page(page); + if (!ptdesc_pte_ctor(ptdesc)) { + ptdesc_free(ptdesc); return NULL; } } else { - page = alloc_page(PGALLOC_GFP); - if (!page) + ptdesc = ptdesc_alloc(PGALLOC_GFP, 0); + if (!ptdesc) return NULL; } - atomic_set(&page->pt_frag_refcount, 1); + atomic_set(&ptdesc->pt_frag_refcount, 1); - ret = page_address(page); + ret = ptdesc_address(ptdesc); /* * if we support only one fragment just return the * allocated page. @@ -82,12 +82,12 @@ static pte_t *__alloc_for_ptecache(struct mm_struct *mm, int kernel) return ret; spin_lock(&mm->page_table_lock); /* - * If we find pgtable_page set, we return + * If we find ptdesc_page set, we return * the allocated page with single fragment * count. */ if (likely(!pte_frag_get(&mm->context))) { - atomic_set(&page->pt_frag_refcount, PTE_FRAG_NR); + atomic_set(&ptdesc->pt_frag_refcount, PTE_FRAG_NR); pte_frag_set(&mm->context, ret + PTE_FRAG_SIZE); } spin_unlock(&mm->page_table_lock); @@ -108,15 +108,15 @@ pte_t *pte_fragment_alloc(struct mm_struct *mm, int kernel) void pte_fragment_free(unsigned long *table, int kernel) { - struct page *page = virt_to_page(table); + struct ptdesc *ptdesc = virt_to_ptdesc(table); - if (PageReserved(page)) - return free_reserved_page(page); + if (ptdesc_is_reserved(ptdesc)) + return free_reserved_ptdesc(ptdesc); - BUG_ON(atomic_read(&page->pt_frag_refcount) <= 0); - if (atomic_dec_and_test(&page->pt_frag_refcount)) { + BUG_ON(atomic_read(&ptdesc->pt_frag_refcount) <= 0); + if (atomic_dec_and_test(&ptdesc->pt_frag_refcount)) { if (!kernel) - pgtable_pte_page_dtor(page); - __free_page(page); + ptdesc_pte_dtor(ptdesc); + ptdesc_free(ptdesc); } } -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:28:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:28:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528093.820800 (Exim 4.92) (envelope-from ) id 1ptZCk-0002Aw-80; Mon, 01 May 2023 19:28:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528093.820800; Mon, 01 May 2023 19:28:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCj-00027g-Tu; Mon, 01 May 2023 19:28:57 +0000 Received: by outflank-mailman (input) for mailman id 528093; Mon, 01 May 2023 19:28:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCh-0006PY-Am for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:28:55 +0000 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [2607:f8b0:4864:20::42b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 680fa245-e856-11ed-8611-37d641c3527e; Mon, 01 May 2023 21:28:53 +0200 (CEST) Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-64115eef620so29038012b3a.1 for ; Mon, 01 May 2023 12:28:53 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.28.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:28:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 680fa245-e856-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969332; x=1685561332; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=L/HbzXYZlFs8Glr3mCgcQ6yZjaq6zFAfxmTJm9brDXY=; b=YU74FvpHQCK1VqAuVX8r2BjduNpUerOh1yATlR8mKQ/tJLpS2WI1LKB7NUnPZev+ku rfgntGzBluAMKuHfK/jms2NgctRzUuZHcxtFDuNiPPeXkbQ7Z48v/aLnoLGhmcKi5okk NTHNilz0HthKY/XHg97rKwZvMnLAYPI7U1eBqYo3DUIS7zYhW0tg5v9W5kNg2nZAJHx+ 0W0xkqlDIUsVkMuesra65fGttpYRxCYfqsHDDsc8zlGh06W2A2UnpmXTtrAlRE/I54n/ 9b61gxsFscmWDNDgpJxss4pOhFtz/pn5R4Qs2mfASivX3bx3H5gbzbMc69UUOvWi91zv pr8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969332; x=1685561332; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L/HbzXYZlFs8Glr3mCgcQ6yZjaq6zFAfxmTJm9brDXY=; b=WZDCwAS8xBgIuJCEK4N3WVf5afNcrTU0AXu6zk/hHJJT6rosFUsGnutOKmr3ROh10H nnOAs5tWWE9SrfUY5oizOyqg+KYOlUwWYnM43v0DqY8cMx38t8t/9j4kcLWjgoXfUNEX NoV52KXTY38WRv87tw72XNhPiBO+WJKnt+BPo66PIZr2I8B3VIAjz35VkrZbrKghwAph NUrFgSeXUShksc9FGob6BVkC1d43yJIiSxDlpNEfhV/pmYGw0YYk+9NLhkU0vkFtM3VD GLUQNNd1GTcTvelqj4ONAEKHJjrFfG9pYXf72RrqdkddFr27ExR0TV1qjs5hlWmYrzKU Oeyg== X-Gm-Message-State: AC+VfDwwY+seaNk1o5lNspdnvcwx206zlIqJgtLITgrovFTAhJb5sj1H aA6cQfQSLwpoaFhygEIXmFs= X-Google-Smtp-Source: ACHHUZ5tlVMWyUaJdG9fqFVZnpLPEvgTINU205p9ECnUgFr/jtV6hdVvJcRfvr33OgCYwfP6dTnMLg== X-Received: by 2002:a17:902:c94f:b0:19a:727e:d4f3 with SMTP id i15-20020a170902c94f00b0019a727ed4f3mr22987004pla.5.1682969332204; Mon, 01 May 2023 12:28:52 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" Subject: [PATCH v2 13/34] mm: Create ptdesc equivalents for pgtable_{pte,pmd}_page_{ctor,dtor} Date: Mon, 1 May 2023 12:28:08 -0700 Message-Id: <20230501192829.17086-14-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Creates ptdesc_pte_ctor(), ptdesc_pmd_ctor(), ptdesc_pte_dtor(), and ptdesc_pmd_dtor() and make the original pgtable constructor/destructors wrappers. Signed-off-by: Vishal Moola (Oracle) --- include/linux/mm.h | 56 ++++++++++++++++++++++++++++++++++------------ 1 file changed, 42 insertions(+), 14 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 58c911341a33..dc61aeca9077 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2847,20 +2847,34 @@ static inline bool ptlock_init(struct ptdesc *ptdesc) { return true; } static inline void ptlock_free(struct ptdesc *ptdesc) {} #endif /* USE_SPLIT_PTE_PTLOCKS */ -static inline bool pgtable_pte_page_ctor(struct page *page) +static inline bool ptdesc_pte_ctor(struct ptdesc *ptdesc) { - if (!ptlock_init(page_ptdesc(page))) + struct folio *folio = ptdesc_folio(ptdesc); + + if (!ptlock_init(ptdesc)) return false; - __SetPageTable(page); - inc_lruvec_page_state(page, NR_PAGETABLE); + __folio_set_table(folio); + lruvec_stat_add_folio(folio, NR_PAGETABLE); return true; } +static inline bool pgtable_pte_page_ctor(struct page *page) +{ + return ptdesc_pte_ctor(page_ptdesc(page)); +} + +static inline void ptdesc_pte_dtor(struct ptdesc *ptdesc) +{ + struct folio *folio = ptdesc_folio(ptdesc); + + ptlock_free(ptdesc); + __folio_clear_table(folio); + lruvec_stat_sub_folio(folio, NR_PAGETABLE); +} + static inline void pgtable_pte_page_dtor(struct page *page) { - ptlock_free(page_ptdesc(page)); - __ClearPageTable(page); - dec_lruvec_page_state(page, NR_PAGETABLE); + ptdesc_pte_dtor(page_ptdesc(page)); } #define pte_offset_map_lock(mm, pmd, address, ptlp) \ @@ -2942,20 +2956,34 @@ static inline spinlock_t *pmd_lock(struct mm_struct *mm, pmd_t *pmd) return ptl; } -static inline bool pgtable_pmd_page_ctor(struct page *page) +static inline bool ptdesc_pmd_ctor(struct ptdesc *ptdesc) { - if (!pmd_ptlock_init(page_ptdesc(page))) + struct folio *folio = ptdesc_folio(ptdesc); + + if (!pmd_ptlock_init(ptdesc)) return false; - __SetPageTable(page); - inc_lruvec_page_state(page, NR_PAGETABLE); + __folio_set_table(folio); + lruvec_stat_add_folio(folio, NR_PAGETABLE); return true; } +static inline bool pgtable_pmd_page_ctor(struct page *page) +{ + return ptdesc_pmd_ctor(page_ptdesc(page)); +} + +static inline void ptdesc_pmd_dtor(struct ptdesc *ptdesc) +{ + struct folio *folio = ptdesc_folio(ptdesc); + + pmd_ptlock_free(ptdesc); + __folio_clear_table(folio); + lruvec_stat_sub_folio(folio, NR_PAGETABLE); +} + static inline void pgtable_pmd_page_dtor(struct page *page) { - pmd_ptlock_free(page_ptdesc(page)); - __ClearPageTable(page); - dec_lruvec_page_state(page, NR_PAGETABLE); + ptdesc_pmd_dtor(page_ptdesc(page)); } /* -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:29:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:29:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528094.820810 (Exim 4.92) (envelope-from ) id 1ptZCm-0002lX-FN; Mon, 01 May 2023 19:29:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528094.820810; Mon, 01 May 2023 19:29:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCl-0002je-SJ; Mon, 01 May 2023 19:28:59 +0000 Received: by outflank-mailman (input) for mailman id 528094; Mon, 01 May 2023 19:28:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCk-0006PY-7V for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:28:58 +0000 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [2607:f8b0:4864:20::635]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 69c3c029-e856-11ed-8611-37d641c3527e; Mon, 01 May 2023 21:28:56 +0200 (CEST) Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1aad5245632so16554975ad.3 for ; Mon, 01 May 2023 12:28:56 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.28.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:28:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 69c3c029-e856-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969335; x=1685561335; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/Q5rpHIbLtPdsxzDzaO3buqXOd2yqrT0Z007lfiZkpI=; b=AxAga4aoXPNlXE7+DeUiTXETzfeeCHbm4zGppPqr1MDTZFxhWAViYrGbWyE6GLWt+9 IB0rpQEMaD7N9ypKiOPbsaINcslUNsYjGQTG5q5vWeCnFZgA7dcIKUsRPd84RGXai5h1 l16CjSDmsfosD9KMmdT6xq8VRCXKZ9G6YKbNHAZjIZoU/NfYHkwEKIBnMm9mpAHGxSXg 2woYY+DxDFTOnXL4g3fftw/6LCcjY+gzdniMaWURcfFDuyLcW5IhoWI0SL4yBh+tQBiv tdoOcx5iHNlwMY/jUOXeVBpbt3BPtJyBIMif2r3nZba5xvX4tcuGQGviD0d/uLbj9ohj JJbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969335; x=1685561335; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/Q5rpHIbLtPdsxzDzaO3buqXOd2yqrT0Z007lfiZkpI=; b=iIDxCuXmkCtevPZmrt/SpgfbY2BurQRE/8Ac/hZroXM0zFPO5b/szZ0/rwmQrgIDZZ VAG9QaqiWBSipFB7JokAaaL4R8D5al4GXJgcHmCN4bcforAd1mCD9JNbt2/SQa/QxY04 9oqH3pjLsGoFc08Wi4r/yxzDW0fnQxyWqEp59HwsoxyhQsisQSbbbqfiV9pKUmbCANtF 2ZaiBAYybP3MxiIYoOSwJjmj/vCYIayQTefMuhAXiDHZMLqCQU7gldZrAgOwQ9pcmdki sa8I9ao21QUHS53ZEiovlUmTrO/h/8Kjm8hw7D+nO9f75pD29l587nBKyxHC5mMr77cb Kq8w== X-Gm-Message-State: AC+VfDwsby8YXMbikQLVUKvh7muDEZzigsprrSxxoQiClz9FhBOk+baL eN8M4919d0BTCOOYpU0PwfM= X-Google-Smtp-Source: ACHHUZ70tPtnwybaj+jIE0QGoYPcdHCYjv99qqOX/zc6uUXZ1o0XGtKwgumEUC29ZoX/UBhdbXOt+g== X-Received: by 2002:a17:903:41d0:b0:1ab:12a:bd2e with SMTP id u16-20020a17090341d000b001ab012abd2emr2887995ple.37.1682969334945; Mon, 01 May 2023 12:28:54 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" , Dave Hansen Subject: [PATCH v2 15/34] x86: Convert various functions to use ptdescs Date: Mon, 1 May 2023 12:28:10 -0700 Message-Id: <20230501192829.17086-16-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In order to split struct ptdesc from struct page, convert various functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use ptdesc_alloc() and ptdesc_address() instead to help standardize page tables further. Signed-off-by: Vishal Moola (Oracle) --- arch/x86/mm/pgtable.c | 46 +++++++++++++++++++++++++------------------ 1 file changed, 27 insertions(+), 19 deletions(-) diff --git a/arch/x86/mm/pgtable.c b/arch/x86/mm/pgtable.c index afab0bc7862b..9b6f81c8eb32 100644 --- a/arch/x86/mm/pgtable.c +++ b/arch/x86/mm/pgtable.c @@ -52,7 +52,7 @@ early_param("userpte", setup_userpte); void ___pte_free_tlb(struct mmu_gather *tlb, struct page *pte) { - pgtable_pte_page_dtor(pte); + ptdesc_pte_dtor(page_ptdesc(pte)); paravirt_release_pte(page_to_pfn(pte)); paravirt_tlb_remove_table(tlb, pte); } @@ -60,7 +60,7 @@ void ___pte_free_tlb(struct mmu_gather *tlb, struct page *pte) #if CONFIG_PGTABLE_LEVELS > 2 void ___pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmd) { - struct page *page = virt_to_page(pmd); + struct ptdesc *ptdesc = virt_to_ptdesc(pmd); paravirt_release_pmd(__pa(pmd) >> PAGE_SHIFT); /* * NOTE! For PAE, any changes to the top page-directory-pointer-table @@ -69,8 +69,8 @@ void ___pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmd) #ifdef CONFIG_X86_PAE tlb->need_flush_all = 1; #endif - pgtable_pmd_page_dtor(page); - paravirt_tlb_remove_table(tlb, page); + ptdesc_pmd_dtor(ptdesc); + paravirt_tlb_remove_table(tlb, ptdesc_page(ptdesc)); } #if CONFIG_PGTABLE_LEVELS > 3 @@ -92,16 +92,16 @@ void ___p4d_free_tlb(struct mmu_gather *tlb, p4d_t *p4d) static inline void pgd_list_add(pgd_t *pgd) { - struct page *page = virt_to_page(pgd); + struct ptdesc *ptdesc = virt_to_ptdesc(pgd); - list_add(&page->lru, &pgd_list); + list_add(&ptdesc->pt_list, &pgd_list); } static inline void pgd_list_del(pgd_t *pgd) { - struct page *page = virt_to_page(pgd); + struct ptdesc *ptdesc = virt_to_ptdesc(pgd); - list_del(&page->lru); + list_del(&ptdesc->pt_list); } #define UNSHARED_PTRS_PER_PGD \ @@ -112,12 +112,12 @@ static inline void pgd_list_del(pgd_t *pgd) static void pgd_set_mm(pgd_t *pgd, struct mm_struct *mm) { - virt_to_page(pgd)->pt_mm = mm; + virt_to_ptdesc(pgd)->pt_mm = mm; } struct mm_struct *pgd_page_get_mm(struct page *page) { - return page->pt_mm; + return page_ptdesc(page)->pt_mm; } static void pgd_ctor(struct mm_struct *mm, pgd_t *pgd) @@ -213,11 +213,14 @@ void pud_populate(struct mm_struct *mm, pud_t *pudp, pmd_t *pmd) static void free_pmds(struct mm_struct *mm, pmd_t *pmds[], int count) { int i; + struct ptdesc *ptdesc; for (i = 0; i < count; i++) if (pmds[i]) { - pgtable_pmd_page_dtor(virt_to_page(pmds[i])); - free_page((unsigned long)pmds[i]); + ptdesc = virt_to_ptdesc(pmds[i]); + + ptdesc_pmd_dtor(ptdesc); + ptdesc_free(ptdesc); mm_dec_nr_pmds(mm); } } @@ -232,16 +235,21 @@ static int preallocate_pmds(struct mm_struct *mm, pmd_t *pmds[], int count) gfp &= ~__GFP_ACCOUNT; for (i = 0; i < count; i++) { - pmd_t *pmd = (pmd_t *)__get_free_page(gfp); - if (!pmd) + pmd_t *pmd = NULL; + struct ptdesc *ptdesc = ptdesc_alloc(gfp, 0); + + if (!ptdesc) failed = true; - if (pmd && !pgtable_pmd_page_ctor(virt_to_page(pmd))) { - free_page((unsigned long)pmd); - pmd = NULL; + if (ptdesc && !ptdesc_pmd_ctor(ptdesc)) { + ptdesc_free(ptdesc); + ptdesc = NULL; failed = true; } - if (pmd) + if (ptdesc) { mm_inc_nr_pmds(mm); + pmd = (pmd_t *)ptdesc_address(ptdesc); + } + pmds[i] = pmd; } @@ -838,7 +846,7 @@ int pud_free_pmd_page(pud_t *pud, unsigned long addr) free_page((unsigned long)pmd_sv); - pgtable_pmd_page_dtor(virt_to_page(pmd)); + ptdesc_pmd_dtor(virt_to_ptdesc(pmd)); free_page((unsigned long)pmd); return 1; -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:29:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:29:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528096.820817 (Exim 4.92) (envelope-from ) id 1ptZCn-00032u-F9; Mon, 01 May 2023 19:29:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528096.820817; Mon, 01 May 2023 19:29:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCn-0002yS-0A; Mon, 01 May 2023 19:29:01 +0000 Received: by outflank-mailman (input) for mailman id 528096; Mon, 01 May 2023 19:28:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCl-0006FS-FY for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:28:59 +0000 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [2607:f8b0:4864:20::436]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6b82f5ab-e856-11ed-b225-6b7b168915f2; Mon, 01 May 2023 21:28:58 +0200 (CEST) Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-63b5465fc13so2109913b3a.3 for ; Mon, 01 May 2023 12:28:58 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.28.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:28:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6b82f5ab-e856-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969338; x=1685561338; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DfBzvZT8j9y8kX+XY5vccXNkzfj+khuHcHL5hyCh86c=; b=ZGC4cCywpFatHbTovw1WlKjZ1/JpIzLm49ZnB+qALtN8+uBzAmOEyQhoqTiZAL9Lov 1//5Ifkg8A25NAtuG/zaT6BZSC/OxKKSrYkP8TeZX+kUNfD8Xntdlqk4M/TUk6HLakv1 nCrmIlVJ/lAy/lFljijZzj8/LpWBCQqPALZ1y/GGQ8i7Rpm01GpW0tHuORtTXujkRAt2 duA4cTRp6tLOiXSxedEuorGvbfQ8keU9JobrzJ6OWtv8cF/fNSyFKrwRMOsU31de5FQU 2Q0V2AuDWJPTZbnRyTcSGfBvM15PDA9NYPwDO/VpLGYUHfCtfkvJIisembrIccrMdBVE w3TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969338; x=1685561338; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DfBzvZT8j9y8kX+XY5vccXNkzfj+khuHcHL5hyCh86c=; b=Wv/XwDEef3LPDk5YaGOjjMdaUwg57u2+VDj74qCNa/Ckzps6P4WwjG4Zs5XHYA+nIU JY+0QbUVTEEWbhomN5XGYW4mQM97fn+wp9WEWk8jMa6sm5MzN3qMidXur80UTLF3XS5c IGEAzWqKjxGSSRxWRPeotuhhqG/lnuvuuiBscWsVHNYLibs9kma3+bOFmeKrLf7bOSuE HlFlIBbbcUmuuKP824R+HREaqizF8ZP/cPdO76PiIRjNbGhVq64tTjPlaBP1SQ/DiC8V QyJbOEq1SQnncp659YkGvgKVVjHLCEQ4bcrMZ6pqhX37mpS74kiSMgdN+JFelF5/7cBR hAlA== X-Gm-Message-State: AC+VfDwuj1vsxxVS55fislnj035r7V/ChTDAvwnk5kq7+q+6jXq8fBkC JsAY1xsQeaw9VoRVvhY+JjE= X-Google-Smtp-Source: ACHHUZ6bNcHkqBfUbTar64QETUpHtB7bbYe1QXkuNIjeJUzlYTez90IJdWZAdk9hI9pBXzKuPuEYjw== X-Received: by 2002:a17:902:ea09:b0:1a9:79e7:2ba with SMTP id s9-20020a170902ea0900b001a979e702bamr18843060plg.23.1682969338010; Mon, 01 May 2023 12:28:58 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" , David Hildenbrand , Claudio Imbrenda Subject: [PATCH v2 17/34] s390: Convert various pgalloc functions to use ptdescs Date: Mon, 1 May 2023 12:28:12 -0700 Message-Id: <20230501192829.17086-18-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use ptdesc_alloc() and ptdesc_address() instead to help standardize page tables further. Signed-off-by: Vishal Moola (Oracle) --- arch/s390/include/asm/pgalloc.h | 4 +- arch/s390/include/asm/tlb.h | 4 +- arch/s390/mm/pgalloc.c | 108 ++++++++++++++++---------------- 3 files changed, 59 insertions(+), 57 deletions(-) diff --git a/arch/s390/include/asm/pgalloc.h b/arch/s390/include/asm/pgalloc.h index 17eb618f1348..9841481560ae 100644 --- a/arch/s390/include/asm/pgalloc.h +++ b/arch/s390/include/asm/pgalloc.h @@ -86,7 +86,7 @@ static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, unsigned long vmaddr) if (!table) return NULL; crst_table_init(table, _SEGMENT_ENTRY_EMPTY); - if (!pgtable_pmd_page_ctor(virt_to_page(table))) { + if (!ptdesc_pmd_ctor(virt_to_ptdesc(table))) { crst_table_free(mm, table); return NULL; } @@ -97,7 +97,7 @@ static inline void pmd_free(struct mm_struct *mm, pmd_t *pmd) { if (mm_pmd_folded(mm)) return; - pgtable_pmd_page_dtor(virt_to_page(pmd)); + ptdesc_pmd_dtor(virt_to_ptdesc(pmd)); crst_table_free(mm, (unsigned long *) pmd); } diff --git a/arch/s390/include/asm/tlb.h b/arch/s390/include/asm/tlb.h index b91f4a9b044c..1388c819b467 100644 --- a/arch/s390/include/asm/tlb.h +++ b/arch/s390/include/asm/tlb.h @@ -89,12 +89,12 @@ static inline void pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmd, { if (mm_pmd_folded(tlb->mm)) return; - pgtable_pmd_page_dtor(virt_to_page(pmd)); + ptdesc_pmd_dtor(virt_to_ptdesc(pmd)); __tlb_adjust_range(tlb, address, PAGE_SIZE); tlb->mm->context.flush_mm = 1; tlb->freed_tables = 1; tlb->cleared_puds = 1; - tlb_remove_table(tlb, pmd); + tlb_remove_ptdesc(tlb, pmd); } /* diff --git a/arch/s390/mm/pgalloc.c b/arch/s390/mm/pgalloc.c index 6b99932abc66..e740b4c76665 100644 --- a/arch/s390/mm/pgalloc.c +++ b/arch/s390/mm/pgalloc.c @@ -43,17 +43,17 @@ __initcall(page_table_register_sysctl); unsigned long *crst_table_alloc(struct mm_struct *mm) { - struct page *page = alloc_pages(GFP_KERNEL, CRST_ALLOC_ORDER); + struct ptdesc *ptdesc = ptdesc_alloc(GFP_KERNEL, CRST_ALLOC_ORDER); - if (!page) + if (!ptdesc) return NULL; - arch_set_page_dat(page, CRST_ALLOC_ORDER); - return (unsigned long *) page_to_virt(page); + arch_set_page_dat(ptdesc_page(ptdesc), CRST_ALLOC_ORDER); + return (unsigned long *) ptdesc_to_virt(ptdesc); } void crst_table_free(struct mm_struct *mm, unsigned long *table) { - free_pages((unsigned long)table, CRST_ALLOC_ORDER); + ptdesc_free(virt_to_ptdesc(table)); } static void __crst_table_upgrade(void *arg) @@ -140,21 +140,21 @@ static inline unsigned int atomic_xor_bits(atomic_t *v, unsigned int bits) struct page *page_table_alloc_pgste(struct mm_struct *mm) { - struct page *page; + struct ptdesc *ptdesc; u64 *table; - page = alloc_page(GFP_KERNEL); - if (page) { - table = (u64 *)page_to_virt(page); + ptdesc = ptdesc_alloc(GFP_KERNEL, 0); + if (ptdesc) { + table = (u64 *)ptdesc_to_virt(ptdesc); memset64(table, _PAGE_INVALID, PTRS_PER_PTE); memset64(table + PTRS_PER_PTE, 0, PTRS_PER_PTE); } - return page; + return ptdesc_page(ptdesc); } void page_table_free_pgste(struct page *page) { - __free_page(page); + ptdesc_free(page_ptdesc(page)); } #endif /* CONFIG_PGSTE */ @@ -230,7 +230,7 @@ void page_table_free_pgste(struct page *page) unsigned long *page_table_alloc(struct mm_struct *mm) { unsigned long *table; - struct page *page; + struct ptdesc *ptdesc; unsigned int mask, bit; /* Try to get a fragment of a 4K page as a 2K page table */ @@ -238,9 +238,9 @@ unsigned long *page_table_alloc(struct mm_struct *mm) table = NULL; spin_lock_bh(&mm->context.lock); if (!list_empty(&mm->context.pgtable_list)) { - page = list_first_entry(&mm->context.pgtable_list, - struct page, lru); - mask = atomic_read(&page->pt_frag_refcount); + ptdesc = list_first_entry(&mm->context.pgtable_list, + struct ptdesc, pt_list); + mask = atomic_read(&ptdesc->pt_frag_refcount); /* * The pending removal bits must also be checked. * Failure to do so might lead to an impossible @@ -253,13 +253,13 @@ unsigned long *page_table_alloc(struct mm_struct *mm) */ mask = (mask | (mask >> 4)) & 0x03U; if (mask != 0x03U) { - table = (unsigned long *) page_to_virt(page); + table = (unsigned long *) ptdesc_to_virt(ptdesc); bit = mask & 1; /* =1 -> second 2K */ if (bit) table += PTRS_PER_PTE; - atomic_xor_bits(&page->pt_frag_refcount, + atomic_xor_bits(&ptdesc->pt_frag_refcount, 0x01U << bit); - list_del(&page->lru); + list_del(&ptdesc->pt_list); } } spin_unlock_bh(&mm->context.lock); @@ -267,27 +267,27 @@ unsigned long *page_table_alloc(struct mm_struct *mm) return table; } /* Allocate a fresh page */ - page = alloc_page(GFP_KERNEL); - if (!page) + ptdesc = ptdesc_alloc(GFP_KERNEL, 0); + if (!ptdesc) return NULL; - if (!pgtable_pte_page_ctor(page)) { - __free_page(page); + if (!ptdesc_pte_ctor(ptdesc)) { + ptdesc_free(ptdesc); return NULL; } - arch_set_page_dat(page, 0); + arch_set_page_dat(ptdesc_page(ptdesc), 0); /* Initialize page table */ - table = (unsigned long *) page_to_virt(page); + table = (unsigned long *) ptdesc_to_virt(ptdesc); if (mm_alloc_pgste(mm)) { /* Return 4K page table with PGSTEs */ - atomic_xor_bits(&page->pt_frag_refcount, 0x03U); + atomic_xor_bits(&ptdesc->pt_frag_refcount, 0x03U); memset64((u64 *)table, _PAGE_INVALID, PTRS_PER_PTE); memset64((u64 *)table + PTRS_PER_PTE, 0, PTRS_PER_PTE); } else { /* Return the first 2K fragment of the page */ - atomic_xor_bits(&page->pt_frag_refcount, 0x01U); + atomic_xor_bits(&ptdesc->pt_frag_refcount, 0x01U); memset64((u64 *)table, _PAGE_INVALID, 2 * PTRS_PER_PTE); spin_lock_bh(&mm->context.lock); - list_add(&page->lru, &mm->context.pgtable_list); + list_add(&ptdesc->pt_list, &mm->context.pgtable_list); spin_unlock_bh(&mm->context.lock); } return table; @@ -309,9 +309,8 @@ static void page_table_release_check(struct page *page, void *table, void page_table_free(struct mm_struct *mm, unsigned long *table) { unsigned int mask, bit, half; - struct page *page; + struct ptdesc *ptdesc = virt_to_ptdesc(table); - page = virt_to_page(table); if (!mm_alloc_pgste(mm)) { /* Free 2K page table fragment of a 4K page */ bit = ((unsigned long) table & ~PAGE_MASK)/(PTRS_PER_PTE*sizeof(pte_t)); @@ -321,39 +320,38 @@ void page_table_free(struct mm_struct *mm, unsigned long *table) * will happen outside of the critical section from this * function or from __tlb_remove_table() */ - mask = atomic_xor_bits(&page->pt_frag_refcount, 0x11U << bit); + mask = atomic_xor_bits(&ptdesc->pt_frag_refcount, 0x11U << bit); if (mask & 0x03U) - list_add(&page->lru, &mm->context.pgtable_list); + list_add(&ptdesc->pt_list, &mm->context.pgtable_list); else - list_del(&page->lru); + list_del(&ptdesc->pt_list); spin_unlock_bh(&mm->context.lock); - mask = atomic_xor_bits(&page->pt_frag_refcount, 0x10U << bit); + mask = atomic_xor_bits(&ptdesc->pt_frag_refcount, 0x10U << bit); if (mask != 0x00U) return; half = 0x01U << bit; } else { half = 0x03U; - mask = atomic_xor_bits(&page->pt_frag_refcount, 0x03U); + mask = atomic_xor_bits(&ptdesc->pt_frag_refcount, 0x03U); } - page_table_release_check(page, table, half, mask); - pgtable_pte_page_dtor(page); - __free_page(page); + page_table_release_check(ptdesc_page(ptdesc), table, half, mask); + ptdesc_pte_dtor(ptdesc); + ptdesc_free(ptdesc); } void page_table_free_rcu(struct mmu_gather *tlb, unsigned long *table, unsigned long vmaddr) { struct mm_struct *mm; - struct page *page; unsigned int bit, mask; + struct ptdesc *ptdesc = virt_to_ptdesc(table); mm = tlb->mm; - page = virt_to_page(table); if (mm_alloc_pgste(mm)) { gmap_unlink(mm, table, vmaddr); table = (unsigned long *) ((unsigned long)table | 0x03U); - tlb_remove_table(tlb, table); + tlb_remove_ptdesc(tlb, table); return; } bit = ((unsigned long) table & ~PAGE_MASK) / (PTRS_PER_PTE*sizeof(pte_t)); @@ -363,11 +361,11 @@ void page_table_free_rcu(struct mmu_gather *tlb, unsigned long *table, * outside of the critical section from __tlb_remove_table() or from * page_table_free() */ - mask = atomic_xor_bits(&page->pt_frag_refcount, 0x11U << bit); + mask = atomic_xor_bits(&ptdesc->pt_frag_refcount, 0x11U << bit); if (mask & 0x03U) - list_add_tail(&page->lru, &mm->context.pgtable_list); + list_add_tail(&ptdesc->pt_list, &mm->context.pgtable_list); else - list_del(&page->lru); + list_del(&ptdesc->pt_list); spin_unlock_bh(&mm->context.lock); table = (unsigned long *) ((unsigned long) table | (0x01U << bit)); tlb_remove_table(tlb, table); @@ -377,7 +375,7 @@ void __tlb_remove_table(void *_table) { unsigned int mask = (unsigned long) _table & 0x03U, half = mask; void *table = (void *)((unsigned long) _table ^ mask); - struct page *page = virt_to_page(table); + struct ptdesc *ptdesc = virt_to_ptdesc(table); switch (half) { case 0x00U: /* pmd, pud, or p4d */ @@ -385,18 +383,18 @@ void __tlb_remove_table(void *_table) return; case 0x01U: /* lower 2K of a 4K page table */ case 0x02U: /* higher 2K of a 4K page table */ - mask = atomic_xor_bits(&page->pt_frag_refcount, mask << 4); + mask = atomic_xor_bits(&ptdesc->pt_frag_refcount, mask << 4); if (mask != 0x00U) return; break; case 0x03U: /* 4K page table with pgstes */ - mask = atomic_xor_bits(&page->pt_frag_refcount, 0x03U); + mask = atomic_xor_bits(&ptdesc->pt_frag_refcount, 0x03U); break; } - page_table_release_check(page, table, half, mask); - pgtable_pte_page_dtor(page); - __free_page(page); + page_table_release_check(ptdesc_page(ptdesc), table, half, mask); + ptdesc_pte_dtor(ptdesc); + ptdesc_free(ptdesc); } /* @@ -424,16 +422,20 @@ static void base_pgt_free(unsigned long *table) static unsigned long *base_crst_alloc(unsigned long val) { unsigned long *table; + struct ptdesc *ptdesc; - table = (unsigned long *)__get_free_pages(GFP_KERNEL, CRST_ALLOC_ORDER); - if (table) - crst_table_init(table, val); + ptdesc = ptdesc_alloc(GFP_KERNEL, CRST_ALLOC_ORDER); + if (!ptdesc) + return NULL; + table = ptdesc_address(ptdesc); + + crst_table_init(table, val); return table; } static void base_crst_free(unsigned long *table) { - free_pages((unsigned long)table, CRST_ALLOC_ORDER); + ptdesc_free(virt_to_ptdesc(table)); } #define BASE_ADDR_END_FUNC(NAME, SIZE) \ -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:29:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:29:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528097.820831 (Exim 4.92) (envelope-from ) id 1ptZCr-00040s-4Z; Mon, 01 May 2023 19:29:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528097.820831; Mon, 01 May 2023 19:29:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCq-0003sz-Ap; Mon, 01 May 2023 19:29:04 +0000 Received: by outflank-mailman (input) for mailman id 528097; Mon, 01 May 2023 19:29:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCo-0006PY-Ld for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:29:02 +0000 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [2607:f8b0:4864:20::634]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6c740127-e856-11ed-8611-37d641c3527e; Mon, 01 May 2023 21:29:01 +0200 (CEST) Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-1ab032d9266so6158805ad.0 for ; Mon, 01 May 2023 12:29:01 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.28.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:28:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6c740127-e856-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969339; x=1685561339; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mrqntkjJd8BO8YfASMnosk0HIl+t/0EXXW8sSx0dJVg=; b=YynIc3MWOn+7eKGjmZARCn/IjCANfe8gTHKhI/1ubKTs4ZbiubHG1P9aimD9KzNrIR eunJCIzqiXfZGl0CCMrWEsO+nwpbu9UTA+2coBncf0PpX1ohouYsG2DEdDJZPuTXi/ir yR5oJPT4K2awb6eBfuzacZRfwPXKDUNKWynDv8oNvVCBXhLYj3JhwMiPBRO+Fg6hjdSs FM9xgZDHU6Sc+urW7voaFKEt/7m6LjDuxZZp6qL4zZI9dwEcGtT8oaSDqFIY7TNV4Oop NDnPsASY2UskW6usELO5k/OqVJv807YApzHQHt4bSD2BLXySmWIPAbRFeQIxlm3YwdkY qcpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969339; x=1685561339; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mrqntkjJd8BO8YfASMnosk0HIl+t/0EXXW8sSx0dJVg=; b=KDGHEdTMGScv5ImkdHYZA5CK74uIGtCrxIv4hXFxwr9ZkycUjbi/whn3tflEetbYPE ATu3n2Pl1oWLmPZNqAzPzVWm0rqS4xD0veeQqG4awStEnMTKeqH2SNxDK0GLbxTMeDS4 G93JkLX1IZY+19nsStYzucTLiCxp4K2nmtKV2KbqIBzDJ6VzqB5BRThx2oQI+QUOvm8B oYrFk1j9W2cGR2AUq4Z1ZcbFRTMITn/lKSd7RHxyqpNt/Sql9XCQLLuJXAontzzEmQ+e Y2DpYyVSjXqIc2rfoULgvIgyAnzfJ6tJ7CV9PQeePXgsSG0/1TiDmjxPuiytvId4ZZyW V1hQ== X-Gm-Message-State: AC+VfDw2riYNBT5BqyDE1ECCexdIksoRI0f8z35IxBytBLYb6PZOf8jt /jqvI/btTxvg91/HUOYGaHg= X-Google-Smtp-Source: ACHHUZ77ujqEA4Fn1OLOb7e5ecCGVNnJtAoTp2B3mAkadiAfSXyelwvqP5mlNEo41vojA+MW1rmqbg== X-Received: by 2002:a17:902:ce8e:b0:1aa:efad:f2d4 with SMTP id f14-20020a170902ce8e00b001aaefadf2d4mr5633464plg.63.1682969339499; Mon, 01 May 2023 12:28:59 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" Subject: [PATCH v2 18/34] mm: Remove page table members from struct page Date: Mon, 1 May 2023 12:28:13 -0700 Message-Id: <20230501192829.17086-19-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The page table members are now split out into their own ptdesc struct. Remove them from struct page. Signed-off-by: Vishal Moola (Oracle) --- include/linux/mm_types.h | 14 -------------- include/linux/pgtable.h | 3 --- 2 files changed, 17 deletions(-) diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h index 6161fe1ae5b8..31ffa1be21d0 100644 --- a/include/linux/mm_types.h +++ b/include/linux/mm_types.h @@ -141,20 +141,6 @@ struct page { struct { /* Tail pages of compound page */ unsigned long compound_head; /* Bit zero is set */ }; - struct { /* Page table pages */ - unsigned long _pt_pad_1; /* compound_head */ - pgtable_t pmd_huge_pte; /* protected by page->ptl */ - unsigned long _pt_s390_gaddr; /* mapping */ - union { - struct mm_struct *pt_mm; /* x86 pgds only */ - atomic_t pt_frag_refcount; /* powerpc */ - }; -#if ALLOC_SPLIT_PTLOCKS - spinlock_t *ptl; -#else - spinlock_t ptl; -#endif - }; struct { /* ZONE_DEVICE pages */ /** @pgmap: Points to the hosting device page map. */ struct dev_pagemap *pgmap; diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h index b067ac10f3dd..90fa73a896db 100644 --- a/include/linux/pgtable.h +++ b/include/linux/pgtable.h @@ -1034,10 +1034,7 @@ struct ptdesc { TABLE_MATCH(flags, __page_flags); TABLE_MATCH(compound_head, pt_list); TABLE_MATCH(compound_head, _pt_pad_1); -TABLE_MATCH(pmd_huge_pte, pmd_huge_pte); TABLE_MATCH(mapping, _pt_s390_gaddr); -TABLE_MATCH(pt_mm, pt_mm); -TABLE_MATCH(ptl, ptl); #undef TABLE_MATCH static_assert(sizeof(struct ptdesc) <= sizeof(struct page)); -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:29:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:29:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528099.820845 (Exim 4.92) (envelope-from ) id 1ptZCt-0004t2-L2; Mon, 01 May 2023 19:29:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528099.820845; Mon, 01 May 2023 19:29:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCt-0004rw-BG; Mon, 01 May 2023 19:29:07 +0000 Received: by outflank-mailman (input) for mailman id 528099; Mon, 01 May 2023 19:29:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCq-0006PY-Mg for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:29:04 +0000 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [2607:f8b0:4864:20::62f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6d8d0f37-e856-11ed-8611-37d641c3527e; Mon, 01 May 2023 21:29:02 +0200 (CEST) Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1aaf706768cso10983245ad.0 for ; Mon, 01 May 2023 12:29:01 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.28.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:29:00 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6d8d0f37-e856-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969341; x=1685561341; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dfen1Ya6fa7BCRlN1BPOcmTNp3Sy/DALCm51X/wHZX4=; b=NGlfJzK3SLIyrzVeCW+cy/LENuF7AIYcpLjneyCln8/dN8tsSa+TUgx6Zs0xZt09V/ AUoO/9vVboMIkkiAJKzWw3zNTkXyZHbg5i+Uv3Zqtu+rX4tuOiaEx2sdsDxoZuaBDGgr vod9dLgUvGamVrCZ2EGOCdE8ToYnRSXk/vhm78x+dP7MR2nyb1QcOC5STzovq8Qe7Hqo h0w/rTHUO6l4DW/cRdBZ54cZqeORpVG+YoPGSUP9GNzfvkM/15zFtG0hwm7rzS97mp6T 8K3nb/fOTHh3fKdVDbkoQtqh9GEw5zSK4hVf63htcA2MUZQPuMJk5JXlIyYiKdaNTnZr +1fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969341; x=1685561341; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dfen1Ya6fa7BCRlN1BPOcmTNp3Sy/DALCm51X/wHZX4=; b=dQANMYcFTypk+0dw2i8Pr8QpO5rIvlzvisICD9U11IGWs8UWTA22JUzbvfUU68M6fS CJ1bJyg7L/sppHsJHAIjRfamfauXi4rVuGlWU7xGQDBNRYoxGy3Ekndeuax7iS+oOxJL kkOt/FJg9+bmb8KF83pkhO5sEn+eTnSzqb/sHd0b9duCO/i1TdZP4xlUesl/jGyT3Mlz 6Ix3bN9v8bwCvZTFi+UARLTId7v0yee12DvBEhD4ioYR+W9ycNvJWSB6bMHLZKirFfUF CL2HWRCOFtYFI3fBOQV4qlX6ueyUg4Bfmiz/ZjZ3XM6s/SB5oyMdIuTLSgG4SNRXrI50 g/ow== X-Gm-Message-State: AC+VfDyPcafaDaxArqUqHxJ9qnZdUALzzhKZ/fJMTbYQXy8u2VihkMdc 13w4LoPTFj2sa0ot1wFpVt4= X-Google-Smtp-Source: ACHHUZ4bym3aGkcEwh3pzEy9AQ1AIJMbPocjKSt/BA7y0pQIbB80eZOWxLwavvxYdF9801tFQUA10w== X-Received: by 2002:a17:903:124b:b0:1a2:8c7e:f315 with SMTP id u11-20020a170903124b00b001a28c7ef315mr17565749plh.21.1682969341343; Mon, 01 May 2023 12:29:01 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" , Arnd Bergmann Subject: [PATCH v2 19/34] pgalloc: Convert various functions to use ptdescs Date: Mon, 1 May 2023 12:28:14 -0700 Message-Id: <20230501192829.17086-20-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use ptdesc_alloc() and ptdesc_address() instead to help standardize page tables further. Signed-off-by: Vishal Moola (Oracle) --- include/asm-generic/pgalloc.h | 62 +++++++++++++++++++++-------------- 1 file changed, 37 insertions(+), 25 deletions(-) diff --git a/include/asm-generic/pgalloc.h b/include/asm-generic/pgalloc.h index a7cf825befae..7d4a1f5d3c17 100644 --- a/include/asm-generic/pgalloc.h +++ b/include/asm-generic/pgalloc.h @@ -18,7 +18,11 @@ */ static inline pte_t *__pte_alloc_one_kernel(struct mm_struct *mm) { - return (pte_t *)__get_free_page(GFP_PGTABLE_KERNEL); + struct ptdesc *ptdesc = ptdesc_alloc(GFP_PGTABLE_KERNEL, 0); + + if (!ptdesc) + return NULL; + return (pte_t *)ptdesc_address(ptdesc); } #ifndef __HAVE_ARCH_PTE_ALLOC_ONE_KERNEL @@ -41,7 +45,7 @@ static inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm) */ static inline void pte_free_kernel(struct mm_struct *mm, pte_t *pte) { - free_page((unsigned long)pte); + ptdesc_free(virt_to_ptdesc(pte)); } /** @@ -49,7 +53,7 @@ static inline void pte_free_kernel(struct mm_struct *mm, pte_t *pte) * @mm: the mm_struct of the current context * @gfp: GFP flags to use for the allocation * - * Allocates a page and runs the pgtable_pte_page_ctor(). + * Allocates a ptdesc and runs the ptdesc_pte_ctor(). * * This function is intended for architectures that need * anything beyond simple page allocation or must have custom GFP flags. @@ -58,17 +62,17 @@ static inline void pte_free_kernel(struct mm_struct *mm, pte_t *pte) */ static inline pgtable_t __pte_alloc_one(struct mm_struct *mm, gfp_t gfp) { - struct page *pte; + struct ptdesc *ptdesc; - pte = alloc_page(gfp); - if (!pte) + ptdesc = ptdesc_alloc(gfp, 0); + if (!ptdesc) return NULL; - if (!pgtable_pte_page_ctor(pte)) { - __free_page(pte); + if (!ptdesc_pte_ctor(ptdesc)) { + ptdesc_free(ptdesc); return NULL; } - return pte; + return ptdesc_page(ptdesc); } #ifndef __HAVE_ARCH_PTE_ALLOC_ONE @@ -76,7 +80,7 @@ static inline pgtable_t __pte_alloc_one(struct mm_struct *mm, gfp_t gfp) * pte_alloc_one - allocate a page for PTE-level user page table * @mm: the mm_struct of the current context * - * Allocates a page and runs the pgtable_pte_page_ctor(). + * Allocates a ptdesc and runs the ptdesc_pte_ctor(). * * Return: `struct page` initialized as page table or %NULL on error */ @@ -98,8 +102,10 @@ static inline pgtable_t pte_alloc_one(struct mm_struct *mm) */ static inline void pte_free(struct mm_struct *mm, struct page *pte_page) { - pgtable_pte_page_dtor(pte_page); - __free_page(pte_page); + struct ptdesc *ptdesc = page_ptdesc(pte_page); + + ptdesc_pte_dtor(ptdesc); + ptdesc_free(ptdesc); } @@ -110,7 +116,7 @@ static inline void pte_free(struct mm_struct *mm, struct page *pte_page) * pmd_alloc_one - allocate a page for PMD-level page table * @mm: the mm_struct of the current context * - * Allocates a page and runs the pgtable_pmd_page_ctor(). + * Allocates a ptdesc and runs the ptdesc_pmd_ctor(). * Allocations use %GFP_PGTABLE_USER in user context and * %GFP_PGTABLE_KERNEL in kernel context. * @@ -118,28 +124,30 @@ static inline void pte_free(struct mm_struct *mm, struct page *pte_page) */ static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, unsigned long addr) { - struct page *page; + struct ptdesc *ptdesc; gfp_t gfp = GFP_PGTABLE_USER; if (mm == &init_mm) gfp = GFP_PGTABLE_KERNEL; - page = alloc_page(gfp); - if (!page) + ptdesc = ptdesc_alloc(gfp, 0); + if (!ptdesc) return NULL; - if (!pgtable_pmd_page_ctor(page)) { - __free_page(page); + if (!ptdesc_pmd_ctor(ptdesc)) { + ptdesc_free(ptdesc); return NULL; } - return (pmd_t *)page_address(page); + return (pmd_t *)ptdesc_address(ptdesc); } #endif #ifndef __HAVE_ARCH_PMD_FREE static inline void pmd_free(struct mm_struct *mm, pmd_t *pmd) { + struct ptdesc *ptdesc = virt_to_ptdesc(pmd); + BUG_ON((unsigned long)pmd & (PAGE_SIZE-1)); - pgtable_pmd_page_dtor(virt_to_page(pmd)); - free_page((unsigned long)pmd); + ptdesc_pmd_dtor(ptdesc); + ptdesc_free(ptdesc); } #endif @@ -149,11 +157,15 @@ static inline void pmd_free(struct mm_struct *mm, pmd_t *pmd) static inline pud_t *__pud_alloc_one(struct mm_struct *mm, unsigned long addr) { - gfp_t gfp = GFP_PGTABLE_USER; + gfp_t gfp = GFP_PGTABLE_USER | __GFP_ZERO; + struct ptdesc *ptdesc; if (mm == &init_mm) gfp = GFP_PGTABLE_KERNEL; - return (pud_t *)get_zeroed_page(gfp); + ptdesc = ptdesc_alloc(gfp, 0); + if (!ptdesc) + return NULL; + return (pud_t *)ptdesc_address(ptdesc); } #ifndef __HAVE_ARCH_PUD_ALLOC_ONE @@ -175,7 +187,7 @@ static inline pud_t *pud_alloc_one(struct mm_struct *mm, unsigned long addr) static inline void __pud_free(struct mm_struct *mm, pud_t *pud) { BUG_ON((unsigned long)pud & (PAGE_SIZE-1)); - free_page((unsigned long)pud); + ptdesc_free(virt_to_ptdesc(pud)); } #ifndef __HAVE_ARCH_PUD_FREE @@ -190,7 +202,7 @@ static inline void pud_free(struct mm_struct *mm, pud_t *pud) #ifndef __HAVE_ARCH_PGD_FREE static inline void pgd_free(struct mm_struct *mm, pgd_t *pgd) { - free_page((unsigned long)pgd); + ptdesc_free(virt_to_ptdesc(pgd)); } #endif -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:30:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:30:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528101.820857 (Exim 4.92) (envelope-from ) id 1ptZER-0000mt-91; Mon, 01 May 2023 19:30:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528101.820857; Mon, 01 May 2023 19:30:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZER-0000mm-5e; Mon, 01 May 2023 19:30:43 +0000 Received: by outflank-mailman (input) for mailman id 528101; Mon, 01 May 2023 19:30:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZEP-0000m4-9y for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:30:41 +0000 Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [2607:f8b0:4864:20::831]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a7c2d785-e856-11ed-b225-6b7b168915f2; Mon, 01 May 2023 21:30:40 +0200 (CEST) Received: by mail-qt1-x831.google.com with SMTP id d75a77b69052e-3ef6e8493ebso14045741cf.2 for ; Mon, 01 May 2023 12:30:40 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id d6-20020ac80606000000b003bf9f9f1844sm9351784qth.71.2023.05.01.12.30.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:30:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a7c2d785-e856-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969438; x=1685561438; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=J4I9pwZJc+JjJXrrhRllN1qzGBzavb5IgPCBPwFplUc=; b=fmiPSYc2nGsg78ceE6+kbaB+qUy1PF1cvWxSlRh2fDCshuHC0BS7N7CUoDCcKsUWNI d3qriqn5pdIkDU3LuxpIjij2MwV09x7y7mk1aOtTW2/4tuFmYPTSpknyx+8ASI3Kzhex Nm8AHOMc5dViFo+xWPkFnMLzYT5hZ3SDOH3sH18iQuvRDgrP7nKV7c7Xg7Y5jaxqqZBg H4I7v+SMWoVXGDasH1UTZnVj9C0UWEpNlUkqwmJD0mn7go6wgLCkn5dGaD3M2P5dK2A8 PHTHrwO7yBQh0uxa0ka3Fdoy9HovpfZCViu5tV2DutmBJ63X0eNKV2aI3fZHndCBEvZQ YaQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969438; x=1685561438; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=J4I9pwZJc+JjJXrrhRllN1qzGBzavb5IgPCBPwFplUc=; b=AkwP21x1YMHz+VDLjyXWd8TYSwJAFfHE/le+wxlnZH4Z/+BxCM4mSJoF7yDNQpM4o1 Yx2Y2c0TZSR+lqstxRXbxfrAAZX2dZHe+xaQ0M9hWkiK+NPezLtVfmdjz21VZz7FbwNp 87IKrmaUTXA1U0zTN8cTFBB9ukaxDSYLMl/xDgy7WJhc+KHDe7PmE5XBxGI8aKO17VvZ yVh8aff8ZQAh+CyFd7nMajNkocoOGv1QWpg6XSusYyAbkjdzIMpRGq5rVqkMT6W8MidC CamCeibj3MFFYtapovFoN2RhM01DE6OldzGOFs14tUpjtBEP6ae/UjnvW1VJaexKI5b6 EvGQ== X-Gm-Message-State: AC+VfDxL6NsLG1fagJBnwdkcaegE+M7uwg3rdIGfZD4snFyz4v4gYTh5 rz5Fb05apbPKSOE+0bxKyz+HxaLYgSo= X-Google-Smtp-Source: ACHHUZ6JC6uoyLOBqmP1EpZkLhQWLiit8irznw5BGejX4UnZK6DMIMe/egnWLI5OCWF/y+K3B+ujnQ== X-Received: by 2002:ac8:5846:0:b0:3ef:3511:f494 with SMTP id h6-20020ac85846000000b003ef3511f494mr24788647qth.16.1682969438585; Mon, 01 May 2023 12:30:38 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Anthony PERARD , Juergen Gross , Henry Wang , Community Manager Subject: [PATCH v3 00/14 RESEND] Intel Hardware P-States (HWP) support Date: Mon, 1 May 2023 15:30:20 -0400 Message-Id: <20230501193034.88575-1-jandryuk@gmail.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi, Resending since I messed up the To: line. Sorry about that. This patch series adds Hardware-Controlled Performance States (HWP) for Intel processors to Xen. v2 was only partially reviewed, so v3 is mostly a reposting of v2. In v2 & v3, I think I addressed all comments for v1. I kept patch 11 "xenpm: Factor out a non-fatal cpuid_parse variant", with a v2 comment explaining why I keep it. v3 adds "xen/x86: Tweak PDC bits when using HWP". Qubes testing revealed an issue where enabling HWP can crash firwmare code (maybe SMM). This requires a Linux change to get the PDC bits from Xen and pass them to ACPI. Roger has a patch [0] to set the PDC bits. Roger's 3 patch series was tested with "xen/x86: Tweak PDC bits when using HWP" on affected hardware and allowed proper operation. Previous cover letter: With HWP, the processor makes its own determinations for frequency selection, though users can set some parameters and preferences. There is also Turbo Boost which dynamically pushes the max frequency if possible. The existing governors don't work with HWP since they select frequencies and HWP doesn't expose those. Therefore a dummy hwp-interal governor is used that doesn't do anything. xenpm get-cpufreq-para is extended to show HWP parameters, and set-cpufreq-hwp is added to set them. A lightly loaded OpenXT laptop showed ~1W power savings according to powertop. A mostly idle Fedora system (dom0 only) showed a more modest power savings. This for for a 10th gen 6-core 1600 MHz base 4900 MHZ max cpu. In the default balance mode, Turbo Boost doesn't exceed 4GHz. Tweaking the energy_perf preference with `xenpm set-cpufreq-hwp balance ene:64`, I've seen the CPU hit 4.7GHz before throttling down and bouncing around between 4.3 and 4.5 GHz. Curiously the other cores read ~4GHz when turbo boost takes affect. This was done after pinning all dom0 cores, and using taskset to pin to vCPU/pCPU 11 and running a bash tightloop. HWP defaults to disabled and running with the existing HWP configuration - it doesn't reconfigure by default. It can be enabled with cpufreq=xen:hwp. Hardware Duty Cycling (HDC) is another feature to autonomously powerdown things. It defaults to enabled when HWP is enabled, but HDC can be disabled on the command line. cpufreq=xen:hwp,no-hdc I've only tested on 8th gen and 10th gen systems with activity window and energy_perf support. So the pathes for CPUs lacking those features are untested. Fast MSR support was removed in v2. The model specific checking was not done properly, and I don't have hardware to test with. Since writes are expected to be infrequent, I just removed the code. This changes the systcl_pm_op hypercall, so that wants review. Regards, Jason [0] https://lore.kernel.org/xen-devel/20221121102113.41893-3-roger.pau@citrix.com/ Jason Andryuk (14): cpufreq: Allow restricting to internal governors only cpufreq: Add perf_freq to cpuinfo cpufreq: Export intel_feature_detect cpufreq: Add Hardware P-State (HWP) driver xenpm: Change get-cpufreq-para output for internal xen/x86: Tweak PDC bits when using HWP cpufreq: Export HWP parameters to userspace libxc: Include hwp_para in definitions xenpm: Print HWP parameters xen: Add SET_CPUFREQ_HWP xen_sysctl_pm_op libxc: Add xc_set_cpufreq_hwp xenpm: Factor out a non-fatal cpuid_parse variant xenpm: Add set-cpufreq-hwp subcommand CHANGELOG: Add Intel HWP entry CHANGELOG.md | 1 + docs/misc/xen-command-line.pandoc | 8 +- tools/include/xenctrl.h | 6 + tools/libs/ctrl/xc_pm.c | 18 + tools/misc/xenpm.c | 355 +++++++++++- xen/arch/x86/acpi/cpufreq/Makefile | 1 + xen/arch/x86/acpi/cpufreq/cpufreq.c | 15 +- xen/arch/x86/acpi/cpufreq/hwp.c | 633 ++++++++++++++++++++++ xen/arch/x86/acpi/lib.c | 5 + xen/arch/x86/cpu/mcheck/mce_intel.c | 6 + xen/arch/x86/include/asm/cpufeature.h | 13 +- xen/arch/x86/include/asm/msr-index.h | 14 + xen/drivers/acpi/pmstat.c | 23 + xen/drivers/cpufreq/cpufreq.c | 40 ++ xen/drivers/cpufreq/utility.c | 1 + xen/include/acpi/cpufreq/cpufreq.h | 14 + xen/include/acpi/cpufreq/processor_perf.h | 4 + xen/include/acpi/pdc_intel.h | 1 + xen/include/public/sysctl.h | 57 ++ 19 files changed, 1187 insertions(+), 28 deletions(-) create mode 100644 xen/arch/x86/acpi/cpufreq/hwp.c -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:30:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:30:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528102.820866 (Exim 4.92) (envelope-from ) id 1ptZEX-00015W-GU; Mon, 01 May 2023 19:30:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528102.820866; Mon, 01 May 2023 19:30:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZEX-00015P-Dp; Mon, 01 May 2023 19:30:49 +0000 Received: by outflank-mailman (input) for mailman id 528102; Mon, 01 May 2023 19:30:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZEW-000149-0Q for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:30:48 +0000 Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [2607:f8b0:4864:20::731]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ab36cae7-e856-11ed-8611-37d641c3527e; Mon, 01 May 2023 21:30:46 +0200 (CEST) Received: by mail-qk1-x731.google.com with SMTP id af79cd13be357-74e0180b7d3so129184485a.2 for ; Mon, 01 May 2023 12:30:46 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id d6-20020ac80606000000b003bf9f9f1844sm9351784qth.71.2023.05.01.12.30.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:30:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab36cae7-e856-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969444; x=1685561444; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7VFwxnOVM/nUJWo2+kFJfbzF53GX8dfaVA+R5Uyazpc=; b=r9j9BPVz3/laZA8dsDmxZe7TRv0yNCtj/Xbsb4WpqDXgx/fA0HOTxNUrvpQf+C4t2T YNYN206A0eGrKe1qAym9I5p7tG8XdEGiJaLW8/t6JkTJFkIT0pzBFXS/iIkCO56wJn3J pUjquCuW3n9+l6STbY/dk/Ilm9zT/scjBTbtK0COm2KbSl8FAiXw+kNZWbpx0W2WhcG0 xkKJVYBUTb1RNwa7L8EPhULHZE9DzKHmCK095rERWUvFMoy1jZyxhh3f0Ve6Bc7Dd9u0 RXDpYSvLxEtoWzrauTp25svhJmvdF5OfkwS+uKrmB1iBB7Lcit4b94RhLAlA38eqUI8l eUEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969444; x=1685561444; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7VFwxnOVM/nUJWo2+kFJfbzF53GX8dfaVA+R5Uyazpc=; b=e5YLgoL599yP+Xdv0THAgss77WW4BQBhNDGUt27NFu/yV8d6Hk2Xd9U7aftqQ9dfzF oxkCghMUyRzel1clzQJRcVM5vahCRhg5CezxVDGDhNsiIXrczwnAnja7up9ZnNSqsirz Xk0Vz8cjOfJwbJDcv0EbU8WPQS4pz0PV5AmBG55CQXJwBZo4R77v1SRPl7B8hHOGyuux fW7j/gmJRqw+qC1Kd8bmqB+lyEOOsb8WaTgPQNv/o086SviJ2xaEg6yIef5ubaSMo0/4 rYTqB6y/H3gTJVZ2si5QbqwIoOXZfqyUHXaWgQ8j2LM2Pri5RCygi/gtiVwLfOhr2+Op pcqA== X-Gm-Message-State: AC+VfDwFiDMZoBVws863mnqB/YZLQslfknsbY4EPLNA1QijkGfK4cKVZ 0hNoj1dGBrCCfasguw8ZeKCvACa/Zlk= X-Google-Smtp-Source: ACHHUZ73X7XhEV+VKk/WhUuhmrdce/HnekpsrCHDFejO2dmdia7/TP7F2pse7XFmNwI5RC0Ffs/PlA== X-Received: by 2002:ac8:7c50:0:b0:3f0:df4d:40b7 with SMTP id o16-20020ac87c50000000b003f0df4d40b7mr24378132qtv.7.1682969444425; Mon, 01 May 2023 12:30:44 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Jan Beulich Subject: [PATCH v3 01/14 RESEND] cpufreq: Allow restricting to internal governors only Date: Mon, 1 May 2023 15:30:21 -0400 Message-Id: <20230501193034.88575-2-jandryuk@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230501193034.88575-1-jandryuk@gmail.com> References: <20230501193034.88575-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit For hwp, the standard governors are not usable, and only the internal one is applicable. Add the cpufreq_governor_internal boolean to indicate when an internal governor, like hwp-internal, will be used. This is set during presmp_initcall, so that it can suppress governor registration during initcall. Only a governor with a name containing "-internal" will be allowed in that case. This way, the unuseable governors are not registered, so the internal one is the only one returned to userspace. This means incompatible governors won't be advertised to userspace. Signed-off-by: Jason Andryuk Acked-by: Jan Beulich --- v3: Switch to initdata Add Jan Acked-by Commit message s/they/the/ typo Don't register hwp-internal when running non-hwp - Marek v2: Switch to "-internal" Add blank line in header --- xen/drivers/cpufreq/cpufreq.c | 8 ++++++++ xen/include/acpi/cpufreq/cpufreq.h | 2 ++ 2 files changed, 10 insertions(+) diff --git a/xen/drivers/cpufreq/cpufreq.c b/xen/drivers/cpufreq/cpufreq.c index 2321c7dd07..7bd81680da 100644 --- a/xen/drivers/cpufreq/cpufreq.c +++ b/xen/drivers/cpufreq/cpufreq.c @@ -56,6 +56,7 @@ struct cpufreq_dom { }; static LIST_HEAD_READ_MOSTLY(cpufreq_dom_list_head); +bool __initdata cpufreq_governor_internal; struct cpufreq_governor *__read_mostly cpufreq_opt_governor; LIST_HEAD_READ_MOSTLY(cpufreq_governor_list); @@ -121,6 +122,13 @@ int __init cpufreq_register_governor(struct cpufreq_governor *governor) if (!governor) return -EINVAL; + if (cpufreq_governor_internal && + strstr(governor->name, "-internal") == NULL) + return -EINVAL; + + if (!cpufreq_governor_internal && strstr(governor->name, "-internal")) + return -EINVAL; + if (__find_governor(governor->name) != NULL) return -EEXIST; diff --git a/xen/include/acpi/cpufreq/cpufreq.h b/xen/include/acpi/cpufreq/cpufreq.h index 35dcf21e8f..0da32ef519 100644 --- a/xen/include/acpi/cpufreq/cpufreq.h +++ b/xen/include/acpi/cpufreq/cpufreq.h @@ -114,6 +114,8 @@ extern struct cpufreq_governor cpufreq_gov_userspace; extern struct cpufreq_governor cpufreq_gov_performance; extern struct cpufreq_governor cpufreq_gov_powersave; +extern bool cpufreq_governor_internal; + extern struct list_head cpufreq_governor_list; extern int cpufreq_register_governor(struct cpufreq_governor *governor); -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:31:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:31:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528103.820877 (Exim 4.92) (envelope-from ) id 1ptZEa-0001Nv-Ou; Mon, 01 May 2023 19:30:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528103.820877; Mon, 01 May 2023 19:30:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZEa-0001NW-Lb; Mon, 01 May 2023 19:30:52 +0000 Received: by outflank-mailman (input) for mailman id 528103; Mon, 01 May 2023 19:30:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZEZ-0000m4-Bd for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:30:51 +0000 Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [2607:f8b0:4864:20::836]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id adfbb034-e856-11ed-b225-6b7b168915f2; Mon, 01 May 2023 21:30:50 +0200 (CEST) Received: by mail-qt1-x836.google.com with SMTP id d75a77b69052e-3ef302a642eso13479981cf.1 for ; Mon, 01 May 2023 12:30:50 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id d6-20020ac80606000000b003bf9f9f1844sm9351784qth.71.2023.05.01.12.30.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:30:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: adfbb034-e856-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969449; x=1685561449; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=txBzmZlgf2a5ZApasbIDD2P8VUrWanxh/ZCZKapkSd4=; b=ruWWxubqxWEfgknzCeHfuioXix3neQCmP3+a25TdXUf2lY/OXFPt8Fw7bOACTmeMj9 W6lzbRO4CQm8VUxPYOZhHZE9MAixtoaCcKrnatX2CtjIGctgcqhiDy42JfMp7IiwQsJ2 pJORAvC5p1oFLI9ZU2fPomLTuylha83HfbB0PRFixRqg6vC0BYsOt3O8hjTzKeInVEdB xETcc6syUMfOhifQLASnke2KU3HfyTwJkOGtQEYC2WBE1K5fATNr2/dHtxgsu261Kbce +eSDtdfkJ8r4k8f/c73OadVqX97fNky9tSHYk/+MBR2Gh0dmKpPjUK3U/1WOM4cjGqT8 qyEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969449; x=1685561449; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=txBzmZlgf2a5ZApasbIDD2P8VUrWanxh/ZCZKapkSd4=; b=lRDxUe0u80tEBUo92bxCtRWM89Hy/Fw3aGEIRyMdP2PTUrIr2heCD6Tw0J1ELx2T+k kvzOWfk7ttslKi9QWHDo17AiiosT1bsSntJo1bjoA9d/M7UH9ItDYQf60f+qtFKtQfBJ a1sUADMWndydb1dJS44dp6IdNuPVzkmFshlM1JUM4MSQCDDoq6OyIPR4btn9Rsja0vUU TmWsF3DWL6kgbprf/92dHaQaifLGalJ3WXJ380y8hthwzRKi7Uhukrq+llE5lhGWYUMx 3LI0cKVLhbRJwBWb3VZuvoDju4ALAyYcbpj6q64dLqyRBgOMWnaZXnIWcB26PyJMCMTo DNZQ== X-Gm-Message-State: AC+VfDz2ZyXgNv5NVJHbm+h+AJUvo12iPoBEfAROIVdOAPKtibh8Xq7Q E1q2aR2C8nus3W2KoD2ACU8ntOmiLfQ= X-Google-Smtp-Source: ACHHUZ6w3eawFGc/l9nZiVmnOOvz/C0aG06cvY9N0n+NkCEj6Vg7LQZ4xbldKhhvalrOwWvRbT6aDw== X-Received: by 2002:ac8:7c50:0:b0:3f0:df4d:40b7 with SMTP id o16-20020ac87c50000000b003f0df4d40b7mr24378669qtv.7.1682969449211; Mon, 01 May 2023 12:30:49 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v3 02/14 RESEND] cpufreq: Add perf_freq to cpuinfo Date: Mon, 1 May 2023 15:30:22 -0400 Message-Id: <20230501193034.88575-3-jandryuk@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230501193034.88575-1-jandryuk@gmail.com> References: <20230501193034.88575-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit acpi-cpufreq scales the aperf/mperf measurements by max_freq, but HWP needs to scale by base frequency. Settings max_freq to base_freq "works" but the code is not obvious, and returning values to userspace is tricky. Add an additonal perf_freq member which is used for scaling aperf/mperf measurements. Signed-off-by: Jason Andryuk Acked-by: Jan Beulich --- v3: Add Jan's Ack I don't like this, but it seems the best way to re-use the common aperf/mperf code. The other option would be to add wrappers that then do the acpi vs. hwp scaling. --- xen/arch/x86/acpi/cpufreq/cpufreq.c | 2 +- xen/drivers/cpufreq/utility.c | 1 + xen/include/acpi/cpufreq/cpufreq.h | 3 +++ 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/acpi/cpufreq/cpufreq.c b/xen/arch/x86/acpi/cpufreq/cpufreq.c index 2e0067fbe5..6c70d04395 100644 --- a/xen/arch/x86/acpi/cpufreq/cpufreq.c +++ b/xen/arch/x86/acpi/cpufreq/cpufreq.c @@ -316,7 +316,7 @@ unsigned int get_measured_perf(unsigned int cpu, unsigned int flag) else perf_percent = 0; - return policy->cpuinfo.max_freq * perf_percent / 100; + return policy->cpuinfo.perf_freq * perf_percent / 100; } static unsigned int cf_check get_cur_freq_on_cpu(unsigned int cpu) diff --git a/xen/drivers/cpufreq/utility.c b/xen/drivers/cpufreq/utility.c index 9eb7ecedcd..6831f62851 100644 --- a/xen/drivers/cpufreq/utility.c +++ b/xen/drivers/cpufreq/utility.c @@ -236,6 +236,7 @@ int cpufreq_frequency_table_cpuinfo(struct cpufreq_policy *policy, policy->min = policy->cpuinfo.min_freq = min_freq; policy->max = policy->cpuinfo.max_freq = max_freq; + policy->cpuinfo.perf_freq = max_freq; policy->cpuinfo.second_max_freq = second_max_freq; if (policy->min == ~0) diff --git a/xen/include/acpi/cpufreq/cpufreq.h b/xen/include/acpi/cpufreq/cpufreq.h index 0da32ef519..a06aa92f62 100644 --- a/xen/include/acpi/cpufreq/cpufreq.h +++ b/xen/include/acpi/cpufreq/cpufreq.h @@ -37,6 +37,9 @@ extern struct acpi_cpufreq_data *cpufreq_drv_data[NR_CPUS]; struct cpufreq_cpuinfo { unsigned int max_freq; unsigned int second_max_freq; /* P1 if Turbo Mode is on */ + unsigned int perf_freq; /* Scaling freq for aperf/mpref. + acpi-cpufreq uses max_freq, but HWP uses + base_freq.*/ unsigned int min_freq; unsigned int transition_latency; /* in 10^(-9) s = nanoseconds */ }; -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:31:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:31:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528104.820886 (Exim 4.92) (envelope-from ) id 1ptZEe-0001iY-1N; Mon, 01 May 2023 19:30:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528104.820886; Mon, 01 May 2023 19:30:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZEd-0001iM-U2; Mon, 01 May 2023 19:30:55 +0000 Received: by outflank-mailman (input) for mailman id 528104; Mon, 01 May 2023 19:30:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZEd-000149-7d for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:30:55 +0000 Received: from mail-qt1-x82b.google.com (mail-qt1-x82b.google.com [2607:f8b0:4864:20::82b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id afbb5f8e-e856-11ed-8611-37d641c3527e; Mon, 01 May 2023 21:30:53 +0200 (CEST) Received: by mail-qt1-x82b.google.com with SMTP id d75a77b69052e-3ee339e8c2fso12897371cf.0 for ; Mon, 01 May 2023 12:30:53 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id d6-20020ac80606000000b003bf9f9f1844sm9351784qth.71.2023.05.01.12.30.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:30:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: afbb5f8e-e856-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969452; x=1685561452; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H9MXL508WAYhYYKIHs8d77jkKwZyoTe/WztjxZedAQ8=; b=CxdCiWP1SUv+Yp9hcpkzl92fy/yJPA8ybi4F68aLbr7SImDVwdbkjA8fYrnKQtXs+V pyIBxunNJdDUmJu3GU08SVoJY6+AUIzlYw8Hp/YQNccxMy5ld9JuVsWUxj5x49H+ujHO VIieK+/4WpGVxK+rnYj1gYs2kAL8VpqO7ajvJjsKCiAZUeKosYnkXATmvGwpKqOi5mx6 COc3zbTQyMnNL4+dvc51sNW/sIZgrauQWsGX/+84BZCDmKNjVqvNfj1VCJo+X01cSs32 pAT8wfI6COmTC1J5jd8FIwODj9GF/tVGjc1pKqiQ8bgdYYRdSKgJeaG6kECUY3aWLl2j bwQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969452; x=1685561452; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H9MXL508WAYhYYKIHs8d77jkKwZyoTe/WztjxZedAQ8=; b=epUQ+HPRXrzEXbAqQbc+o/XsL9i7CUbgvGl+IgjQMp1ZpotUerBNXs1DdNq2iF2cEc a6ozq+PnBexrR5+OFSKztpOFa7T0ejWrrhMK/nezT5DwLrwK8/G7HCaW6+NZ4AghBlba 1d1ZUHfTBovnkM8JwtayqRZfqc1aTpPjkvWgyFvvUPUJyh921R0LFiJuFXX6/o7TeU1P 8jjlrQ9p5wxMZKx1PVal+s71elFTKmAGVm9ou5RNdL6syiPmAz0UO0/d2OALP35GaKVm 1TMblTve55P+1EQae2MfiZ4CmBd7KhKD2c42sD1MSqCrrwvZlF4oHKPXKzDi4fWDTdAR g7YA== X-Gm-Message-State: AC+VfDyqOUuNo9XQTsPtnA31+l+MJGd9w/hQBW0ytFVLfd/uvpZp56UG mPcFNF+96U+vtgJ2M0MjM4loGWCsvVI= X-Google-Smtp-Source: ACHHUZ61Lw9FNIzq0S8Unejn3bdDcd2bR/GRbFtZ1Rd6OIkz4KwanSmye/RkOvAVRjQPpb2hLgwA8Q== X-Received: by 2002:ac8:5d89:0:b0:3e8:1903:ab05 with SMTP id d9-20020ac85d89000000b003e81903ab05mr22968522qtx.64.1682969452035; Mon, 01 May 2023 12:30:52 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v3 03/14 RESEND] cpufreq: Export intel_feature_detect Date: Mon, 1 May 2023 15:30:23 -0400 Message-Id: <20230501193034.88575-4-jandryuk@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230501193034.88575-1-jandryuk@gmail.com> References: <20230501193034.88575-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Export feature_detect as intel_feature_detect so it can be re-used by HWP. Signed-off-by: Jason Andryuk --- v3: Remove void * cast when calling intel_feature_detect v2: export intel_feature_detect with typed pointer Move intel_feature_detect to acpi/cpufreq/cpufreq.h since the declaration now contains struct cpufreq_policy *. --- xen/arch/x86/acpi/cpufreq/cpufreq.c | 8 ++++++-- xen/include/acpi/cpufreq/cpufreq.h | 2 ++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/acpi/cpufreq/cpufreq.c b/xen/arch/x86/acpi/cpufreq/cpufreq.c index 6c70d04395..f1cc473b4f 100644 --- a/xen/arch/x86/acpi/cpufreq/cpufreq.c +++ b/xen/arch/x86/acpi/cpufreq/cpufreq.c @@ -339,9 +339,8 @@ static unsigned int cf_check get_cur_freq_on_cpu(unsigned int cpu) return extract_freq(get_cur_val(cpumask_of(cpu)), data); } -static void cf_check feature_detect(void *info) +void intel_feature_detect(struct cpufreq_policy *policy) { - struct cpufreq_policy *policy = info; unsigned int eax; eax = cpuid_eax(6); @@ -353,6 +352,11 @@ static void cf_check feature_detect(void *info) } } +static void cf_check feature_detect(void *info) +{ + intel_feature_detect(info); +} + static unsigned int check_freqs(const cpumask_t *mask, unsigned int freq, struct acpi_cpufreq_data *data) { diff --git a/xen/include/acpi/cpufreq/cpufreq.h b/xen/include/acpi/cpufreq/cpufreq.h index a06aa92f62..0f334d2a43 100644 --- a/xen/include/acpi/cpufreq/cpufreq.h +++ b/xen/include/acpi/cpufreq/cpufreq.h @@ -243,4 +243,6 @@ int write_userspace_scaling_setspeed(unsigned int cpu, unsigned int freq); void cpufreq_dbs_timer_suspend(void); void cpufreq_dbs_timer_resume(void); +void intel_feature_detect(struct cpufreq_policy *policy); + #endif /* __XEN_CPUFREQ_PM_H__ */ -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:31:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:31:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528105.820897 (Exim 4.92) (envelope-from ) id 1ptZEi-0002AI-Ce; Mon, 01 May 2023 19:31:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528105.820897; Mon, 01 May 2023 19:31:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZEi-0002A1-8b; Mon, 01 May 2023 19:31:00 +0000 Received: by outflank-mailman (input) for mailman id 528105; Mon, 01 May 2023 19:30:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZEg-0000m4-EJ for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:30:58 +0000 Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [2607:f8b0:4864:20::736]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b1a01d17-e856-11ed-b225-6b7b168915f2; Mon, 01 May 2023 21:30:56 +0200 (CEST) Received: by mail-qk1-x736.google.com with SMTP id af79cd13be357-7515631b965so676444985a.0 for ; Mon, 01 May 2023 12:30:56 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id d6-20020ac80606000000b003bf9f9f1844sm9351784qth.71.2023.05.01.12.30.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:30:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b1a01d17-e856-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969455; x=1685561455; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Hym2Jx5Z8r7rrhqAfu+8xxIV/nnrCdXHwFgph7V69FQ=; b=eFLLq7533G3AnlY/uK7JfettQ+iRAVTRvVGoCC70QyQnroXyxJDlomnil6MLU0E2DA jhQTA/f36QeSqDRdqwjwFcxcqn4JCYAQkwHADfatxLrVUFBiDC+/w78PmV+e7fs7jzJT FNxKneHnD7iFgYBzeJc8Cg4MxNqtOBNDA+1+2FQGd737UubPzGypVrZ18DfT02/HqgNu GVN1Nf9WZVBrPbiAfuRkiETrycnYVgCKKBo9wWVsx4Huq9l2oroPhemhECPYaBplzCT3 Hh1OOYVk78PzWfR+CEZTvVDb9pcGrar29yGM8SyXw2Fogtp0xoASga9uWVcqCr+dERqD IBUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969455; x=1685561455; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Hym2Jx5Z8r7rrhqAfu+8xxIV/nnrCdXHwFgph7V69FQ=; b=O78QZNNAzyIBvRSi66VQB3uMnz2d1zEWIsJJNglMeh0rkKGAa7llo11z4r5vQKBWZd gLnd1x89gMxGYdr1s2dmu2nTf2spBT8Rtxm/sEBdNI6WK8VsaONnEU3L+V9Z2LHN+R39 mG6s6VoVm9Yyb0etDXeXdb7rvLIlCc0qn3kB1nydN/FOYV//J2qHliRaZJmN+qEO9Ywc 9rWLBw7tH1L0IxPXgAUnCEVeXh/wF3BvDDp6yjF+GsTOWcEvz5R+LPpq7rYcURTb7gkt iAcWPM4PzVjVhaSXMDWbnenj7i4p+byA2rmR+Vip4t/rcsOpw3r5g4krm5TyT4YSTgzx RMRQ== X-Gm-Message-State: AC+VfDzplqNVmnRYhCmpDBbWfBb0MUQm815JOD1LQ3m7PxZtrABzIPt2 ywRNCX91rsgqUuwIhgr6UFNUONdWDNk= X-Google-Smtp-Source: ACHHUZ6QbNWTkiVCscld5Z5s1zw5gwOZxJEuSKsuwgvQq7Nmmk/GhBWAz0RBbxsfRy3SwJJxRchdFA== X-Received: by 2002:ac8:5c85:0:b0:3e8:e986:b20a with SMTP id r5-20020ac85c85000000b003e8e986b20amr30735751qta.16.1682969455231; Mon, 01 May 2023 12:30:55 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v3 04/14 RESEND] cpufreq: Add Hardware P-State (HWP) driver Date: Mon, 1 May 2023 15:30:24 -0400 Message-Id: <20230501193034.88575-5-jandryuk@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230501193034.88575-1-jandryuk@gmail.com> References: <20230501193034.88575-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit >From the Intel SDM: "Hardware-Controlled Performance States (HWP), which autonomously selects performance states while utilizing OS supplied performance guidance hints." Enable HWP to run in autonomous mode by poking the correct MSRs. cpufreq=xen:hwp enables and cpufreq=xen:hwp=0 disables. The same for hdc. There is no interface to configure - xen_sysctl_pm_op/xenpm will be to be extended to configure in subsequent patches. It will run with the default values, which should be the default 0x80 (out of 0x0-0xff) energy/performance preference. Unscientific powertop measurement of an mostly idle, customized OpenXT install: A 10th gen 6-core laptop showed battery discharge drop from ~9.x to ~7.x watts. A 8th gen 4-core laptop dropped from ~10 to ~9 Power usage depends on many factors, especially display brightness, but this does show an power saving in balanced mode when CPU utilization is low. HWP isn't compatible with an external governor - it doesn't take explicit frequency requests. Therefore a minimal internal governor, hwp-internal, is also added as a placeholder. While adding to the xen-command-line.pandoc entry, un-nest verbose from minfreq. They are independent. Signed-off-by: Jason Andryuk --- We disable on cpuid_level < 0x16. cpuid(0x16) is used to get the cpu frequencies for calculating the APERF/MPERF. Without it, things would still work, but the averge cpufrequency output would be wrong. My 8th & 10th gen test systems both report: (XEN) HWP: 1 notify: 1 act_window: 1 energy_perf: 1 pkg_level: 0 peci: 0 (XEN) HWP: Hardware Duty Cycling (HDC) supported (XEN) HWP: HW_FEEDBACK not supported IA32_ENERGY_PERF_BIAS has not been tested. For cpufreq=xen:hwp, placing the option inside the governor wouldn't work. Users would have to select the hwp-internal governor to turn off hwp support. hwp-internal isn't usable without hwp, and users wouldn't be able to select a different governor. That doesn't matter while hwp defaults off, but it would if or when hwp defaults to enabled. We can't use parse_boolean() since it requires a single name=val string and cpufreq_handle_common_option is provided two strings. Use parse_bool() and manual handle no-hwp. Write to disable the interrupt - the linux pstate driver does this. We don't use the interrupts, so we can just turn them off. We aren't ready to handle them, so we don't want any. Unclear if this is necessary. SDM says it's default disabled. FAST_IA32_HWP_REQUEST was removed in v2. The check in v1 was wrong, it's a model specific feature and the CPUID bit is only available after enabling via the MSR. Support was untested since I don't have hardware with the feature. Writes are expected to be infrequent, so just leave it out. --- v2: Alphabetize headers Re-work driver registration name hwp_drv_data anonymous union "hw" Drop hwp_verbose_cont style cleanups Condense hwp_governor switch hwp_cpufreq_target remove .raw from hwp_req assignment Use typed-pointer in a few functions Pass type to xzalloc Add HWP_ENERGY_PERF_BALANCE/IA32_ENERGY_BIAS_BALANCE defines Add XEN_HWP_GOVERNOR define for "hwp-internal" Capitalize CPUID and MSR defines Change '_' to '-' for energy-perf & act-window Read-modify-write MSRs updates Use FAST_IA32_HWP_REQUEST_MSR_ENABLE define constify pointer in hwp_set_misc_turbo Add space after non-fallthrough break in governor switch Add IA32_ENERGY_BIAS_MASK define Check CPUID_PM_LEAK for energy bias when needed Fail initialization with curr_req = -1 Fold hwp_read_capabilities into hwp_init_msrs Add command line cpufreq=xen:hwp Add command line cpufreq=xen:hdc Use per_cpu for hwp_drv_data pointers Move hwp_energy_perf_bias call into hwp_write_request energy_perf 0 is valid, so hwp_energy_perf_bias cannot be skipped Ensure we don't generate interrupts Remove Fast Write of Uncore MSR Initialize hwp_drv_data from curr_req Use SPDX line instead of license text in hwp.c v3: Add cf_check to cpufreq_gov_hwp_init() - Marek Print cpuid_level with %#x - Marek --- docs/misc/xen-command-line.pandoc | 8 +- xen/arch/x86/acpi/cpufreq/Makefile | 1 + xen/arch/x86/acpi/cpufreq/cpufreq.c | 5 +- xen/arch/x86/acpi/cpufreq/hwp.c | 506 ++++++++++++++++++++++ xen/arch/x86/include/asm/cpufeature.h | 13 +- xen/arch/x86/include/asm/msr-index.h | 13 + xen/drivers/cpufreq/cpufreq.c | 32 ++ xen/include/acpi/cpufreq/cpufreq.h | 3 + xen/include/acpi/cpufreq/processor_perf.h | 3 + xen/include/public/sysctl.h | 1 + 10 files changed, 581 insertions(+), 4 deletions(-) create mode 100644 xen/arch/x86/acpi/cpufreq/hwp.c diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index e0b89b7d33..aaa31f444b 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -499,7 +499,7 @@ If set, force use of the performance counters for oprofile, rather than detectin available support. ### cpufreq -> `= none | {{ | xen } [:[powersave|performance|ondemand|userspace][,][,[][,[verbose]]]]} | dom0-kernel` +> `= none | {{ | xen } [:[powersave|performance|ondemand|userspace][,][,[]][,[]][,[]][,[verbose]]]} | dom0-kernel` > Default: `xen` @@ -510,6 +510,12 @@ choice of `dom0-kernel` is deprecated and not supported by all Dom0 kernels. * `` and `` are integers which represent max and min processor frequencies respectively. * `verbose` option can be included as a string or also as `verbose=` +* `` is a boolean to enable Hardware-Controlled Performance States (HWP) + on supported Intel hardware. HWP is a Skylake+ feature which provides better + CPU power management. The default is disabled. +* `` is a boolean to enable Hardware Duty Cycling (HDC). HDC enables the + processor to autonomously force physical package components into idle state. + The default is enabled, but the option only applies when `` is enabled. ### cpuid (x86) > `= List of comma separated booleans` diff --git a/xen/arch/x86/acpi/cpufreq/Makefile b/xen/arch/x86/acpi/cpufreq/Makefile index f75da9b9ca..db83aa6b14 100644 --- a/xen/arch/x86/acpi/cpufreq/Makefile +++ b/xen/arch/x86/acpi/cpufreq/Makefile @@ -1,2 +1,3 @@ obj-y += cpufreq.o +obj-y += hwp.o obj-y += powernow.o diff --git a/xen/arch/x86/acpi/cpufreq/cpufreq.c b/xen/arch/x86/acpi/cpufreq/cpufreq.c index f1cc473b4f..56816b1aee 100644 --- a/xen/arch/x86/acpi/cpufreq/cpufreq.c +++ b/xen/arch/x86/acpi/cpufreq/cpufreq.c @@ -642,7 +642,10 @@ static int __init cf_check cpufreq_driver_init(void) switch ( boot_cpu_data.x86_vendor ) { case X86_VENDOR_INTEL: - ret = cpufreq_register_driver(&acpi_cpufreq_driver); + if ( hwp_available() ) + ret = hwp_register_driver(); + else + ret = cpufreq_register_driver(&acpi_cpufreq_driver); break; case X86_VENDOR_AMD: diff --git a/xen/arch/x86/acpi/cpufreq/hwp.c b/xen/arch/x86/acpi/cpufreq/hwp.c new file mode 100644 index 0000000000..57f13867d3 --- /dev/null +++ b/xen/arch/x86/acpi/cpufreq/hwp.c @@ -0,0 +1,506 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * hwp.c cpufreq driver to run Intel Hardware P-States (HWP) + * + * Copyright (C) 2021 Jason Andryuk + */ + +#include +#include +#include +#include +#include +#include +#include + +static bool feature_hwp; +static bool feature_hwp_notification; +static bool feature_hwp_activity_window; +static bool feature_hwp_energy_perf; +static bool feature_hwp_pkg_level_ctl; +static bool feature_hwp_peci; + +static bool feature_hdc; + +__initdata bool opt_cpufreq_hwp = false; +__initdata bool opt_cpufreq_hdc = true; + +#define HWP_ENERGY_PERF_BALANCE 0x80 +#define IA32_ENERGY_BIAS_BALANCE 0x7 +#define IA32_ENERGY_BIAS_MAX_POWERSAVE 0xf +#define IA32_ENERGY_BIAS_MASK 0xf + +union hwp_request +{ + struct + { + uint64_t min_perf:8; + uint64_t max_perf:8; + uint64_t desired:8; + uint64_t energy_perf:8; + uint64_t activity_window:10; + uint64_t package_control:1; + uint64_t reserved:16; + uint64_t activity_window_valid:1; + uint64_t energy_perf_valid:1; + uint64_t desired_valid:1; + uint64_t max_perf_valid:1; + uint64_t min_perf_valid:1; + }; + uint64_t raw; +}; + +struct hwp_drv_data +{ + union + { + uint64_t hwp_caps; + struct + { + uint64_t highest:8; + uint64_t guaranteed:8; + uint64_t most_efficient:8; + uint64_t lowest:8; + uint64_t reserved:32; + } hw; + }; + union hwp_request curr_req; + uint16_t activity_window; + uint8_t minimum; + uint8_t maximum; + uint8_t desired; + uint8_t energy_perf; +}; +DEFINE_PER_CPU_READ_MOSTLY(struct hwp_drv_data *, hwp_drv_data); + +#define hwp_err(...) printk(XENLOG_ERR __VA_ARGS__) +#define hwp_info(...) printk(XENLOG_INFO __VA_ARGS__) +#define hwp_verbose(...) \ +({ \ + if ( cpufreq_verbose ) \ + printk(XENLOG_DEBUG __VA_ARGS__); \ +}) + +static int cf_check hwp_governor(struct cpufreq_policy *policy, + unsigned int event) +{ + int ret; + + if ( policy == NULL ) + return -EINVAL; + + switch ( event ) + { + case CPUFREQ_GOV_START: + case CPUFREQ_GOV_LIMITS: + ret = 0; + break; + + case CPUFREQ_GOV_STOP: + default: + ret = -EINVAL; + break; + } + + return ret; +} + +static struct cpufreq_governor hwp_cpufreq_governor = +{ + .name = XEN_HWP_GOVERNOR, + .governor = hwp_governor, +}; + +static int __init cf_check cpufreq_gov_hwp_init(void) +{ + return cpufreq_register_governor(&hwp_cpufreq_governor); +} +__initcall(cpufreq_gov_hwp_init); + +bool __init hwp_available(void) +{ + unsigned int eax, ecx, unused; + bool use_hwp; + + if ( boot_cpu_data.cpuid_level < CPUID_PM_LEAF ) + { + hwp_verbose("cpuid_level (%#x) lacks HWP support\n", + boot_cpu_data.cpuid_level); + return false; + } + + if ( boot_cpu_data.cpuid_level < 0x16 ) + { + hwp_info("HWP disabled: cpuid_level %#x < 0x16 lacks CPU freq info\n", + boot_cpu_data.cpuid_level); + return false; + } + + cpuid(CPUID_PM_LEAF, &eax, &unused, &ecx, &unused); + + if ( !(eax & CPUID6_EAX_HWP_ENERGY_PERFORMANCE_PREFERENCE) && + !(ecx & CPUID6_ECX_IA32_ENERGY_PERF_BIAS) ) + { + hwp_verbose("HWP disabled: No energy/performance preference available"); + return false; + } + + feature_hwp = eax & CPUID6_EAX_HWP; + feature_hwp_notification = eax & CPUID6_EAX_HWP_NOTIFICATION; + feature_hwp_activity_window = eax & CPUID6_EAX_HWP_ACTIVITY_WINDOW; + feature_hwp_energy_perf = + eax & CPUID6_EAX_HWP_ENERGY_PERFORMANCE_PREFERENCE; + feature_hwp_pkg_level_ctl = eax & CPUID6_EAX_HWP_PACKAGE_LEVEL_REQUEST; + feature_hwp_peci = eax & CPUID6_EAX_HWP_PECI; + + hwp_verbose("HWP: %d notify: %d act-window: %d energy-perf: %d pkg-level: %d peci: %d\n", + feature_hwp, feature_hwp_notification, + feature_hwp_activity_window, feature_hwp_energy_perf, + feature_hwp_pkg_level_ctl, feature_hwp_peci); + + if ( !feature_hwp ) + return false; + + feature_hdc = eax & CPUID6_EAX_HDC; + + hwp_verbose("HWP: Hardware Duty Cycling (HDC) %ssupported%s\n", + feature_hdc ? "" : "not ", + feature_hdc ? opt_cpufreq_hdc ? ", enabled" : ", disabled" + : ""); + + feature_hdc = feature_hdc && opt_cpufreq_hdc; + + hwp_verbose("HWP: HW_FEEDBACK %ssupported\n", + (eax & CPUID6_EAX_HW_FEEDBACK) ? "" : "not "); + + use_hwp = feature_hwp && opt_cpufreq_hwp; + cpufreq_governor_internal = use_hwp; + + if ( use_hwp ) + hwp_info("Using HWP for cpufreq\n"); + + return use_hwp; +} + +static void hdc_set_pkg_hdc_ctl(bool val) +{ + uint64_t msr; + + if ( rdmsr_safe(MSR_IA32_PKG_HDC_CTL, msr) ) + { + hwp_err("error rdmsr_safe(MSR_IA32_PKG_HDC_CTL)\n"); + + return; + } + + if ( val ) + msr |= IA32_PKG_HDC_CTL_HDC_PKG_ENABLE; + else + msr &= ~IA32_PKG_HDC_CTL_HDC_PKG_ENABLE; + + if ( wrmsr_safe(MSR_IA32_PKG_HDC_CTL, msr) ) + hwp_err("error wrmsr_safe(MSR_IA32_PKG_HDC_CTL): %016lx\n", msr); +} + +static void hdc_set_pm_ctl1(bool val) +{ + uint64_t msr; + + if ( rdmsr_safe(MSR_IA32_PM_CTL1, msr) ) + { + hwp_err("error rdmsr_safe(MSR_IA32_PM_CTL1)\n"); + + return; + } + + if ( val ) + msr |= IA32_PM_CTL1_HDC_ALLOW_BLOCK; + else + msr &= ~IA32_PM_CTL1_HDC_ALLOW_BLOCK; + + if ( wrmsr_safe(MSR_IA32_PM_CTL1, msr) ) + hwp_err("error wrmsr_safe(MSR_IA32_PM_CTL1): %016lx\n", msr); +} + +static void hwp_get_cpu_speeds(struct cpufreq_policy *policy) +{ + uint32_t base_khz, max_khz, bus_khz, edx; + + cpuid(0x16, &base_khz, &max_khz, &bus_khz, &edx); + + /* aperf/mperf scales base. */ + policy->cpuinfo.perf_freq = base_khz * 1000; + policy->cpuinfo.min_freq = base_khz * 1000; + policy->cpuinfo.max_freq = max_khz * 1000; + policy->min = base_khz * 1000; + policy->max = max_khz * 1000; + policy->cur = 0; +} + +static void cf_check hwp_init_msrs(void *info) +{ + struct cpufreq_policy *policy = info; + struct hwp_drv_data *data = this_cpu(hwp_drv_data); + uint64_t val; + + /* + * Package level MSR, but we don't have a good idea of packages here, so + * just do it everytime. + */ + if ( rdmsr_safe(MSR_IA32_PM_ENABLE, val) ) + { + hwp_err("CPU%u: error rdmsr_safe(MSR_IA32_PM_ENABLE)\n", policy->cpu); + data->curr_req.raw = -1; + return; + } + + /* Ensure we don't generate interrupts */ + if ( feature_hwp_notification ) + wrmsr_safe(MSR_IA32_HWP_INTERRUPT, 0); + + hwp_verbose("CPU%u: MSR_IA32_PM_ENABLE: %016lx\n", policy->cpu, val); + if ( !(val & IA32_PM_ENABLE_HWP_ENABLE) ) + { + val |= IA32_PM_ENABLE_HWP_ENABLE; + if ( wrmsr_safe(MSR_IA32_PM_ENABLE, val) ) + { + hwp_err("CPU%u: error wrmsr_safe(MSR_IA32_PM_ENABLE, %lx)\n", + policy->cpu, val); + data->curr_req.raw = -1; + return; + } + } + + if ( rdmsr_safe(MSR_IA32_HWP_CAPABILITIES, data->hwp_caps) ) + { + hwp_err("CPU%u: error rdmsr_safe(MSR_IA32_HWP_CAPABILITIES)\n", + policy->cpu); + data->curr_req.raw = -1; + return; + } + + if ( rdmsr_safe(MSR_IA32_HWP_REQUEST, data->curr_req.raw) ) + { + hwp_err("CPU%u: error rdmsr_safe(MSR_IA32_HWP_REQUEST)\n", policy->cpu); + data->curr_req.raw = -1; + return; + } + + if ( !feature_hwp_energy_perf ) { + if ( rdmsr_safe(MSR_IA32_ENERGY_PERF_BIAS, val) ) + { + hwp_err("error rdmsr_safe(MSR_IA32_ENERGY_PERF_BIAS)\n"); + data->curr_req.raw = -1; + + return; + } + + data->energy_perf = val & IA32_ENERGY_BIAS_MASK; + } + + /* + * Check for APERF/MPERF support in hardware + * also check for boost/turbo support + */ + intel_feature_detect(policy); + + if ( feature_hdc ) + { + hdc_set_pkg_hdc_ctl(true); + hdc_set_pm_ctl1(true); + } + + hwp_get_cpu_speeds(policy); +} + +static int cf_check hwp_cpufreq_verify(struct cpufreq_policy *policy) +{ + struct hwp_drv_data *data = per_cpu(hwp_drv_data, policy->cpu); + + if ( !feature_hwp_energy_perf && data->energy_perf ) + { + if ( data->energy_perf > IA32_ENERGY_BIAS_MAX_POWERSAVE ) + { + hwp_err("energy_perf %d exceeds IA32_ENERGY_PERF_BIAS range 0-15\n", + data->energy_perf); + + return -EINVAL; + } + } + + if ( !feature_hwp_activity_window && data->activity_window ) + { + hwp_err("HWP activity window not supported\n"); + + return -EINVAL; + } + + return 0; +} + +/* val 0 - highest performance, 15 - maximum energy savings */ +static void hwp_energy_perf_bias(const struct hwp_drv_data *data) +{ + uint64_t msr; + uint8_t val = data->energy_perf; + + ASSERT(val <= IA32_ENERGY_BIAS_MAX_POWERSAVE); + + if ( rdmsr_safe(MSR_IA32_ENERGY_PERF_BIAS, msr) ) + { + hwp_err("error rdmsr_safe(MSR_IA32_ENERGY_PERF_BIAS)\n"); + + return; + } + + msr &= ~IA32_ENERGY_BIAS_MASK; + msr |= val; + + if ( wrmsr_safe(MSR_IA32_ENERGY_PERF_BIAS, msr) ) + hwp_err("error wrmsr_safe(MSR_IA32_ENERGY_PERF_BIAS): %016lx\n", msr); +} + +static void cf_check hwp_write_request(void *info) +{ + struct cpufreq_policy *policy = info; + struct hwp_drv_data *data = this_cpu(hwp_drv_data); + union hwp_request hwp_req = data->curr_req; + + BUILD_BUG_ON(sizeof(union hwp_request) != sizeof(uint64_t)); + if ( wrmsr_safe(MSR_IA32_HWP_REQUEST, hwp_req.raw) ) + { + hwp_err("CPU%u: error wrmsr_safe(MSR_IA32_HWP_REQUEST, %lx)\n", + policy->cpu, hwp_req.raw); + rdmsr_safe(MSR_IA32_HWP_REQUEST, data->curr_req.raw); + } + + if ( !feature_hwp_energy_perf ) + hwp_energy_perf_bias(data); + +} + +static int cf_check hwp_cpufreq_target(struct cpufreq_policy *policy, + unsigned int target_freq, + unsigned int relation) +{ + unsigned int cpu = policy->cpu; + struct hwp_drv_data *data = per_cpu(hwp_drv_data, cpu); + /* Zero everything to ensure reserved bits are zero... */ + union hwp_request hwp_req = { .raw = 0 }; + + /* .. and update from there */ + hwp_req.min_perf = data->minimum; + hwp_req.max_perf = data->maximum; + hwp_req.desired = data->desired; + if ( feature_hwp_energy_perf ) + hwp_req.energy_perf = data->energy_perf; + if ( feature_hwp_activity_window ) + hwp_req.activity_window = data->activity_window; + + if ( hwp_req.raw == data->curr_req.raw ) + return 0; + + data->curr_req = hwp_req; + + hwp_verbose("CPU%u: wrmsr HWP_REQUEST %016lx\n", cpu, hwp_req.raw); + on_selected_cpus(cpumask_of(cpu), hwp_write_request, policy, 1); + + return 0; +} + +static int cf_check hwp_cpufreq_cpu_init(struct cpufreq_policy *policy) +{ + unsigned int cpu = policy->cpu; + struct hwp_drv_data *data; + + data = xzalloc(struct hwp_drv_data); + if ( !data ) + return -ENOMEM; + + if ( cpufreq_opt_governor ) + printk(XENLOG_WARNING + "HWP: governor \"%s\" is incompatible with hwp. Using default \"%s\"\n", + cpufreq_opt_governor->name, hwp_cpufreq_governor.name); + policy->governor = &hwp_cpufreq_governor; + + per_cpu(hwp_drv_data, cpu) = data; + + on_selected_cpus(cpumask_of(cpu), hwp_init_msrs, policy, 1); + + if ( data->curr_req.raw == -1 ) + { + hwp_err("CPU%u: Could not initialize HWP properly\n", cpu); + XFREE(per_cpu(hwp_drv_data, cpu)); + return -ENODEV; + } + + data->minimum = data->curr_req.min_perf; + data->maximum = data->curr_req.max_perf; + data->desired = data->curr_req.desired; + /* the !feature_hwp_energy_perf case was handled in hwp_init_msrs(). */ + if ( feature_hwp_energy_perf ) + data->energy_perf = data->curr_req.energy_perf; + + hwp_verbose("CPU%u: IA32_HWP_CAPABILITIES: %016lx\n", cpu, data->hwp_caps); + + hwp_verbose("CPU%u: rdmsr HWP_REQUEST %016lx\n", cpu, data->curr_req.raw); + + return 0; +} + +static int cf_check hwp_cpufreq_cpu_exit(struct cpufreq_policy *policy) +{ + XFREE(per_cpu(hwp_drv_data, policy->cpu)); + + return 0; +} + +/* + * The SDM reads like turbo should be disabled with MSR_IA32_PERF_CTL and + * PERF_CTL_TURBO_DISENGAGE, but that does not seem to actually work, at least + * with my HWP testing. MSR_IA32_MISC_ENABLE and MISC_ENABLE_TURBO_DISENGAGE + * is what Linux uses and seems to work. + */ +static void cf_check hwp_set_misc_turbo(void *info) +{ + const struct cpufreq_policy *policy = info; + uint64_t msr; + + if ( rdmsr_safe(MSR_IA32_MISC_ENABLE, msr) ) + { + hwp_err("CPU%u: error rdmsr_safe(MSR_IA32_MISC_ENABLE)\n", policy->cpu); + + return; + } + + if ( policy->turbo == CPUFREQ_TURBO_ENABLED ) + msr &= ~MSR_IA32_MISC_ENABLE_TURBO_DISENGAGE; + else + msr |= MSR_IA32_MISC_ENABLE_TURBO_DISENGAGE; + + if ( wrmsr_safe(MSR_IA32_MISC_ENABLE, msr) ) + hwp_err("CPU%u: error wrmsr_safe(MSR_IA32_MISC_ENABLE): %016lx\n", + policy->cpu, msr); +} + +static int cf_check hwp_cpufreq_update(int cpuid, struct cpufreq_policy *policy) +{ + on_selected_cpus(cpumask_of(cpuid), hwp_set_misc_turbo, policy, 1); + + return 0; +} + +static const struct cpufreq_driver __initconstrel hwp_cpufreq_driver = +{ + .name = "hwp-cpufreq", + .verify = hwp_cpufreq_verify, + .target = hwp_cpufreq_target, + .init = hwp_cpufreq_cpu_init, + .exit = hwp_cpufreq_cpu_exit, + .update = hwp_cpufreq_update, +}; + +int __init hwp_register_driver(void) +{ + return cpufreq_register_driver(&hwp_cpufreq_driver); +} diff --git a/xen/arch/x86/include/asm/cpufeature.h b/xen/arch/x86/include/asm/cpufeature.h index 4140ec0938..f2ff1d5fde 100644 --- a/xen/arch/x86/include/asm/cpufeature.h +++ b/xen/arch/x86/include/asm/cpufeature.h @@ -46,8 +46,17 @@ extern struct cpuinfo_x86 boot_cpu_data; #define cpu_has(c, bit) test_bit(bit, (c)->x86_capability) #define boot_cpu_has(bit) test_bit(bit, boot_cpu_data.x86_capability) -#define CPUID_PM_LEAF 6 -#define CPUID6_ECX_APERFMPERF_CAPABILITY 0x1 +#define CPUID_PM_LEAF 6 +#define CPUID6_EAX_HWP (_AC(1, U) << 7) +#define CPUID6_EAX_HWP_NOTIFICATION (_AC(1, U) << 8) +#define CPUID6_EAX_HWP_ACTIVITY_WINDOW (_AC(1, U) << 9) +#define CPUID6_EAX_HWP_ENERGY_PERFORMANCE_PREFERENCE (_AC(1, U) << 10) +#define CPUID6_EAX_HWP_PACKAGE_LEVEL_REQUEST (_AC(1, U) << 11) +#define CPUID6_EAX_HDC (_AC(1, U) << 13) +#define CPUID6_EAX_HWP_PECI (_AC(1, U) << 16) +#define CPUID6_EAX_HW_FEEDBACK (_AC(1, U) << 19) +#define CPUID6_ECX_APERFMPERF_CAPABILITY 0x1 +#define CPUID6_ECX_IA32_ENERGY_PERF_BIAS 0x8 /* CPUID level 0x00000001.edx */ #define cpu_has_fpu 1 diff --git a/xen/arch/x86/include/asm/msr-index.h b/xen/arch/x86/include/asm/msr-index.h index fa771ed0b5..a2a22339e4 100644 --- a/xen/arch/x86/include/asm/msr-index.h +++ b/xen/arch/x86/include/asm/msr-index.h @@ -151,6 +151,13 @@ #define MSR_PKRS 0x000006e1 +#define MSR_IA32_PM_ENABLE 0x00000770 +#define IA32_PM_ENABLE_HWP_ENABLE (_AC(1, ULL) << 0) + +#define MSR_IA32_HWP_CAPABILITIES 0x00000771 +#define MSR_IA32_HWP_INTERRUPT 0x00000773 +#define MSR_IA32_HWP_REQUEST 0x00000774 + #define MSR_X2APIC_FIRST 0x00000800 #define MSR_X2APIC_LAST 0x000008ff @@ -165,6 +172,11 @@ #define PASID_PASID_MASK 0x000fffff #define PASID_VALID (_AC(1, ULL) << 31) +#define MSR_IA32_PKG_HDC_CTL 0x00000db0 +#define IA32_PKG_HDC_CTL_HDC_PKG_ENABLE (_AC(1, ULL) << 0) +#define MSR_IA32_PM_CTL1 0x00000db1 +#define IA32_PM_CTL1_HDC_ALLOW_BLOCK (_AC(1, ULL) << 0) + #define MSR_UARCH_MISC_CTRL 0x00001b01 #define UARCH_CTRL_DOITM (_AC(1, ULL) << 0) @@ -500,6 +512,7 @@ #define MSR_IA32_MISC_ENABLE_LIMIT_CPUID (1<<22) #define MSR_IA32_MISC_ENABLE_XTPR_DISABLE (1<<23) #define MSR_IA32_MISC_ENABLE_XD_DISABLE (1ULL << 34) +#define MSR_IA32_MISC_ENABLE_TURBO_DISENGAGE (1ULL << 38) #define MSR_IA32_TSC_DEADLINE 0x000006E0 #define MSR_IA32_ENERGY_PERF_BIAS 0x000001b0 diff --git a/xen/drivers/cpufreq/cpufreq.c b/xen/drivers/cpufreq/cpufreq.c index 7bd81680da..9470eb7230 100644 --- a/xen/drivers/cpufreq/cpufreq.c +++ b/xen/drivers/cpufreq/cpufreq.c @@ -565,6 +565,38 @@ static void cpufreq_cmdline_common_para(struct cpufreq_policy *new_policy) static int __init cpufreq_handle_common_option(const char *name, const char *val) { + if (!strcmp(name, "hdc")) { + if (val) { + int ret = parse_bool(val, NULL); + if (ret != -1) { + opt_cpufreq_hdc = ret; + return 1; + } + } else { + opt_cpufreq_hdc = true; + return 1; + } + } else if (!strcmp(name, "no-hdc")) { + opt_cpufreq_hdc = false; + return 1; + } + + if (!strcmp(name, "hwp")) { + if (val) { + int ret = parse_bool(val, NULL); + if (ret != -1) { + opt_cpufreq_hwp = ret; + return 1; + } + } else { + opt_cpufreq_hwp = true; + return 1; + } + } else if (!strcmp(name, "no-hwp")) { + opt_cpufreq_hwp = false; + return 1; + } + if (!strcmp(name, "maxfreq") && val) { usr_max_freq = simple_strtoul(val, NULL, 0); return 1; diff --git a/xen/include/acpi/cpufreq/cpufreq.h b/xen/include/acpi/cpufreq/cpufreq.h index 0f334d2a43..29a712a4f1 100644 --- a/xen/include/acpi/cpufreq/cpufreq.h +++ b/xen/include/acpi/cpufreq/cpufreq.h @@ -245,4 +245,7 @@ void cpufreq_dbs_timer_resume(void); void intel_feature_detect(struct cpufreq_policy *policy); +extern bool opt_cpufreq_hwp; +extern bool opt_cpufreq_hdc; + #endif /* __XEN_CPUFREQ_PM_H__ */ diff --git a/xen/include/acpi/cpufreq/processor_perf.h b/xen/include/acpi/cpufreq/processor_perf.h index d8a1ba68a6..b751ca4937 100644 --- a/xen/include/acpi/cpufreq/processor_perf.h +++ b/xen/include/acpi/cpufreq/processor_perf.h @@ -7,6 +7,9 @@ #define XEN_PX_INIT 0x80000000 +bool hwp_available(void); +int hwp_register_driver(void); + int powernow_cpufreq_init(void); unsigned int powernow_register_driver(void); unsigned int get_measured_perf(unsigned int cpu, unsigned int flag); diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h index 2b24d6bfd0..b448f13b75 100644 --- a/xen/include/public/sysctl.h +++ b/xen/include/public/sysctl.h @@ -292,6 +292,7 @@ struct xen_ondemand { uint32_t up_threshold; }; +#define XEN_HWP_GOVERNOR "hwp-internal" /* * cpufreq para name of this structure named * same as sysfs file name of native linux -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:31:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:31:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528107.820907 (Exim 4.92) (envelope-from ) id 1ptZEl-0002dr-Tn; Mon, 01 May 2023 19:31:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528107.820907; Mon, 01 May 2023 19:31:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZEl-0002dg-OU; Mon, 01 May 2023 19:31:03 +0000 Received: by outflank-mailman (input) for mailman id 528107; Mon, 01 May 2023 19:31:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZEk-000149-UP for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:31:02 +0000 Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [2607:f8b0:4864:20::833]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b44a29e3-e856-11ed-8611-37d641c3527e; Mon, 01 May 2023 21:31:01 +0200 (CEST) Received: by mail-qt1-x833.google.com with SMTP id d75a77b69052e-3ef64d8b2b4so13236131cf.2 for ; Mon, 01 May 2023 12:31:01 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id d6-20020ac80606000000b003bf9f9f1844sm9351784qth.71.2023.05.01.12.30.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:30:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b44a29e3-e856-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969460; x=1685561460; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hA8U/InM9EEJxsTtEJ4pQE8Dle8MV2Sm7m6DjaGLFBw=; b=cqYdElAgv017E/RPw2IfPj2RWa7HBP5wPUoivkXxfKl7Wcrhcl0iwOuzZphMkXGrmq wXCkHA8JltP+awApYh8wW61giM/5P2zyNIoHj3q9YmwRfaTUXFVZakg8TrC8FV/WoDGZ mo9IaeB6VUPChzAspWP9VcAsfV+TlO8Y/3cNML4q+Pu36JsDdpapVSvhvzxmzur3X5kb iYsf3odUJqBk7a9Ou/Bf4vu/nG3w22mo0+ol5vCDLc5dYSOaknjfd3TwNd4KjydszEDR jyy1FovHqAsAjtuqX9giS6oKxRxgZXnd68neZX3LzXl3USX2N/zFujA6OIMOGGjtAGZz xCkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969460; x=1685561460; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hA8U/InM9EEJxsTtEJ4pQE8Dle8MV2Sm7m6DjaGLFBw=; b=lymf5mbhwTrLPRooCSX7O3oPwZlGnMHiAdCT5aleAen8xbkQ3ahlWEqgWp2HASkWKZ Tf6aTDH/6VnBlmZG1Oum6xHimWPpMW9AulbOs+TJXMfpxhg8Rps/oM6HPJdJGmoOLd5W zJ1iXp6Wg2/4P9chlZD0SfusTNpqEDDLhRbBmnrUEFQML//lMBmgrfnmRBNlNCgz8A7J 10htRuiX5GmIJMtq9fDJinNlyt69NjVjb4GOsGOHKfuH4z5KPvZfvA0iRIy9v4F9oZ57 wxlxmvF/1yjJL192Hmt0oG+DXa+q48XuDm1tVUerdQ9A0Dt6Lxxo6D6HJBzX409YbeO7 zIDw== X-Gm-Message-State: AC+VfDxn7qAj80dvYOzVdxfsbUfBEGwBYyBRr4iwtY5XgUxrH4NivQVW MVKSSioemicMgE0WJBn/SdZg6aIbCPA= X-Google-Smtp-Source: ACHHUZ56JSvdUTnYPJIqqSMnTeyqiLw1eNi/3MYuwdvmwUt+ZTaf7S1mFfukjjdCf4lp2bgDkUEqQQ== X-Received: by 2002:ac8:5f54:0:b0:3e4:3f79:9d7b with SMTP id y20-20020ac85f54000000b003e43f799d7bmr23571957qta.55.1682969459739; Mon, 01 May 2023 12:30:59 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Wei Liu , Anthony PERARD Subject: [PATCH v3 05/14 RESEND] xenpm: Change get-cpufreq-para output for internal Date: Mon, 1 May 2023 15:30:25 -0400 Message-Id: <20230501193034.88575-6-jandryuk@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230501193034.88575-1-jandryuk@gmail.com> References: <20230501193034.88575-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When using HWP, some of the returned data is not applicable. In that case, we should just omit it to avoid confusing the user. So switch to printing the base and turbo frequencies since those are relevant to HWP. Similarly, stop printing the CPU frequencies since those do not apply. Signed-off-by: Jason Andryuk --- v2: Use full governor name XEN_HWP_GOVERNOR to change output Style fixes --- tools/misc/xenpm.c | 41 +++++++++++++++++++++++++---------------- 1 file changed, 25 insertions(+), 16 deletions(-) diff --git a/tools/misc/xenpm.c b/tools/misc/xenpm.c index 1bb6187e56..ce8d7644d0 100644 --- a/tools/misc/xenpm.c +++ b/tools/misc/xenpm.c @@ -711,6 +711,7 @@ void start_gather_func(int argc, char *argv[]) /* print out parameters about cpu frequency */ static void print_cpufreq_para(int cpuid, struct xc_get_cpufreq_para *p_cpufreq) { + bool internal = strstr(p_cpufreq->scaling_governor, XEN_HWP_GOVERNOR); int i; printf("cpu id : %d\n", cpuid); @@ -720,10 +721,15 @@ static void print_cpufreq_para(int cpuid, struct xc_get_cpufreq_para *p_cpufreq) printf(" %d", p_cpufreq->affected_cpus[i]); printf("\n"); - printf("cpuinfo frequency : max [%u] min [%u] cur [%u]\n", - p_cpufreq->cpuinfo_max_freq, - p_cpufreq->cpuinfo_min_freq, - p_cpufreq->cpuinfo_cur_freq); + if ( internal ) + printf("cpuinfo frequency : base [%u] turbo [%u]\n", + p_cpufreq->cpuinfo_min_freq, + p_cpufreq->cpuinfo_max_freq); + else + printf("cpuinfo frequency : max [%u] min [%u] cur [%u]\n", + p_cpufreq->cpuinfo_max_freq, + p_cpufreq->cpuinfo_min_freq, + p_cpufreq->cpuinfo_cur_freq); printf("scaling_driver : %s\n", p_cpufreq->scaling_driver); @@ -750,19 +756,22 @@ static void print_cpufreq_para(int cpuid, struct xc_get_cpufreq_para *p_cpufreq) p_cpufreq->u.ondemand.up_threshold); } - printf("scaling_avail_freq :"); - for ( i = 0; i < p_cpufreq->freq_num; i++ ) - if ( p_cpufreq->scaling_available_frequencies[i] == - p_cpufreq->scaling_cur_freq ) - printf(" *%d", p_cpufreq->scaling_available_frequencies[i]); - else - printf(" %d", p_cpufreq->scaling_available_frequencies[i]); - printf("\n"); + if ( !internal ) + { + printf("scaling_avail_freq :"); + for ( i = 0; i < p_cpufreq->freq_num; i++ ) + if ( p_cpufreq->scaling_available_frequencies[i] == + p_cpufreq->scaling_cur_freq ) + printf(" *%d", p_cpufreq->scaling_available_frequencies[i]); + else + printf(" %d", p_cpufreq->scaling_available_frequencies[i]); + printf("\n"); - printf("scaling frequency : max [%u] min [%u] cur [%u]\n", - p_cpufreq->scaling_max_freq, - p_cpufreq->scaling_min_freq, - p_cpufreq->scaling_cur_freq); + printf("scaling frequency : max [%u] min [%u] cur [%u]\n", + p_cpufreq->scaling_max_freq, + p_cpufreq->scaling_min_freq, + p_cpufreq->scaling_cur_freq); + } printf("turbo mode : %s\n", p_cpufreq->turbo_enabled ? "enabled" : "disabled or n/a"); -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:31:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:31:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528109.820917 (Exim 4.92) (envelope-from ) id 1ptZEp-00036m-5I; Mon, 01 May 2023 19:31:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528109.820917; Mon, 01 May 2023 19:31:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZEp-00036X-1N; Mon, 01 May 2023 19:31:07 +0000 Received: by outflank-mailman (input) for mailman id 528109; Mon, 01 May 2023 19:31:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZEo-000149-3A for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:31:06 +0000 Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [2607:f8b0:4864:20::82f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b61e0f36-e856-11ed-8611-37d641c3527e; Mon, 01 May 2023 21:31:04 +0200 (CEST) Received: by mail-qt1-x82f.google.com with SMTP id d75a77b69052e-3ef38bea86aso13223701cf.3 for ; Mon, 01 May 2023 12:31:04 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id d6-20020ac80606000000b003bf9f9f1844sm9351784qth.71.2023.05.01.12.31.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:31:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b61e0f36-e856-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969463; x=1685561463; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AClKrOg8M97t4+1HhqAtzZODxTQ5H9SUOQWpW1JlGKM=; b=YaGuiAS9skGtNqMMYIs2izeJbZk9tjGRToKR7izraEPPKc5z3vDnPbYPZTMX9SPIu2 9hEoyC+hQrBI0Au9ULyOsD0lzBzqhfpe3fmOUvtwsKoqOyiyRWgcObksuugY0iJ/6oJo Gr2bq0+Qr7BpDyDnjjtIaOqmt+9IImpmB/tmGF3TWsDBKlNezlhRfW5UV6vIAOF420WE K+ll91Lxlyg8ArMyp5vI/yJi3DnXpPzdn3IEmd4Xpp6BBLZCDpX5lPNO2kh1XAl2iheK /NBX+Vgt+eOocF/A2c26q8nSO5AerNn+zRDoWvx8Ptzxx08z1cJ6vk8JpTjfJXFP3xLA 1Brg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969463; x=1685561463; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AClKrOg8M97t4+1HhqAtzZODxTQ5H9SUOQWpW1JlGKM=; b=JQzUmKQCSJEEMvwUz/pBRyC3rWy0SooUxZfQOsmzq78sB0DNGnstGgUcK4ZvhKpE6v RwNwYzaRcJDHwYBxp7ZaCCMMVzxdEGNAi5Fksz8pjbRFcjux9pdkpwaUNZv0qDyh/vOq jcnhi5Oxjhd5mvtLG5WCwZg6TLXuWzwHRwLK91kLiZ/dvzQIhVH82+AmVMGOASXdyDim 4F6WWOZke0sutPS/ZqgXLGbzwcmv3ufBWxZu54iIa+F1AZ0Q+eaxZ0XnXM4lTYIFL/X1 VzCS+Rr4YUWa4cI80KZzmelrAU4UU9FBxNtBFRpp7uu1S3RtNuSuygaZHTABq51vSe9/ 52xQ== X-Gm-Message-State: AC+VfDy0j+9cdFFfsGn6qypEnAf4IS7d6+rCvHmk8VQTPyW3QOk1M0B6 2K2LI5Ium/ZBSfxOelbyczUIVxXCLiA= X-Google-Smtp-Source: ACHHUZ5cQ2cgJdSAh0zgGf+/+ZF/Ml22GYGgHkn6nhGuZflecOxzamQB3CxZ4cxbFlh83Usj9WeWAw== X-Received: by 2002:a05:622a:199d:b0:3ef:3bad:6d12 with SMTP id u29-20020a05622a199d00b003ef3bad6d12mr20428194qtc.5.1682969462760; Mon, 01 May 2023 12:31:02 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v3 06/14 RESEND] xen/x86: Tweak PDC bits when using HWP Date: Mon, 1 May 2023 15:30:26 -0400 Message-Id: <20230501193034.88575-7-jandryuk@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230501193034.88575-1-jandryuk@gmail.com> References: <20230501193034.88575-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Qubes testing of HWP support had a report of a laptop, Thinkpad X1 Carbon Gen 4 with a Skylake processor, locking up during boot when HWP is enabled. A user found a kernel bug that seems to be the same issue: https://bugzilla.kernel.org/show_bug.cgi?id=110941. That bug was fixed by Linux commit a21211672c9a ("ACPI / processor: Request native thermal interrupt handling via _OSC"). The tl;dr is SMM crashes when it receives thermal interrupts, so Linux calls the ACPI _OSC method to take over interrupt handling. The Linux fix looks at the CPU features to decide whether or not to call _OSC with bit 12 set to take over native interrupt handling. Xen needs some way to communicate HWP to Dom0 for making an equivalent call. Xen exposes modified PDC bits via the platform_op set_pminfo hypercall. Expand that to set bit 12 when HWP is present and in use. Any generated interrupt would be handled by Xen's thermal drive, which clears the status. Bit 12 isn't named in the linux header and is open coded in Linux's usage. This will need a corresponding linux patch to pick up and apply the PDC bits. Signed-off-by: Jason Andryuk --- New in v3 xen/arch/x86/acpi/cpufreq/hwp.c | 16 +++++++++++----- xen/arch/x86/acpi/lib.c | 5 +++++ xen/arch/x86/cpu/mcheck/mce_intel.c | 6 ++++++ xen/arch/x86/include/asm/msr-index.h | 1 + xen/include/acpi/cpufreq/processor_perf.h | 1 + xen/include/acpi/pdc_intel.h | 1 + 6 files changed, 25 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/acpi/cpufreq/hwp.c b/xen/arch/x86/acpi/cpufreq/hwp.c index 57f13867d3..f84abe1386 100644 --- a/xen/arch/x86/acpi/cpufreq/hwp.c +++ b/xen/arch/x86/acpi/cpufreq/hwp.c @@ -13,6 +13,8 @@ #include #include +static bool hwp_in_use; + static bool feature_hwp; static bool feature_hwp_notification; static bool feature_hwp_activity_window; @@ -117,10 +119,14 @@ static int __init cf_check cpufreq_gov_hwp_init(void) } __initcall(cpufreq_gov_hwp_init); +bool hwp_active(void) +{ + return hwp_in_use; +} + bool __init hwp_available(void) { unsigned int eax, ecx, unused; - bool use_hwp; if ( boot_cpu_data.cpuid_level < CPUID_PM_LEAF ) { @@ -173,13 +179,13 @@ bool __init hwp_available(void) hwp_verbose("HWP: HW_FEEDBACK %ssupported\n", (eax & CPUID6_EAX_HW_FEEDBACK) ? "" : "not "); - use_hwp = feature_hwp && opt_cpufreq_hwp; - cpufreq_governor_internal = use_hwp; + hwp_in_use = feature_hwp && opt_cpufreq_hwp; + cpufreq_governor_internal = hwp_in_use; - if ( use_hwp ) + if ( hwp_in_use ) hwp_info("Using HWP for cpufreq\n"); - return use_hwp; + return hwp_in_use; } static void hdc_set_pkg_hdc_ctl(bool val) diff --git a/xen/arch/x86/acpi/lib.c b/xen/arch/x86/acpi/lib.c index 43831b92d1..20d6115ba9 100644 --- a/xen/arch/x86/acpi/lib.c +++ b/xen/arch/x86/acpi/lib.c @@ -26,6 +26,8 @@ #include #include +#include + u32 __read_mostly acpi_smi_cmd; u8 __read_mostly acpi_enable_value; u8 __read_mostly acpi_disable_value; @@ -140,5 +142,8 @@ int arch_acpi_set_pdc_bits(u32 acpi_id, u32 *pdc, u32 mask) !(ecx & CPUID5_ECX_INTERRUPT_BREAK)) pdc[2] &= ~(ACPI_PDC_C_C1_FFH | ACPI_PDC_C_C2C3_FFH); + if (hwp_active()) + pdc[2] |= ACPI_PDC_CPPC_NTV_INT; + return 0; } diff --git a/xen/arch/x86/cpu/mcheck/mce_intel.c b/xen/arch/x86/cpu/mcheck/mce_intel.c index 2f23f02923..d430342924 100644 --- a/xen/arch/x86/cpu/mcheck/mce_intel.c +++ b/xen/arch/x86/cpu/mcheck/mce_intel.c @@ -15,6 +15,9 @@ #include #include #include + +#include + #include "mce.h" #include "x86_mca.h" #include "barrier.h" @@ -64,6 +67,9 @@ static void cf_check intel_thermal_interrupt(struct cpu_user_regs *regs) ack_APIC_irq(); + if ( hwp_active() ) + wrmsr_safe(MSR_IA32_HWP_STATUS, 0); + if ( NOW() < per_cpu(next, cpu) ) return; diff --git a/xen/arch/x86/include/asm/msr-index.h b/xen/arch/x86/include/asm/msr-index.h index a2a22339e4..f5269022da 100644 --- a/xen/arch/x86/include/asm/msr-index.h +++ b/xen/arch/x86/include/asm/msr-index.h @@ -157,6 +157,7 @@ #define MSR_IA32_HWP_CAPABILITIES 0x00000771 #define MSR_IA32_HWP_INTERRUPT 0x00000773 #define MSR_IA32_HWP_REQUEST 0x00000774 +#define MSR_IA32_HWP_STATUS 0x00000777 #define MSR_X2APIC_FIRST 0x00000800 #define MSR_X2APIC_LAST 0x000008ff diff --git a/xen/include/acpi/cpufreq/processor_perf.h b/xen/include/acpi/cpufreq/processor_perf.h index b751ca4937..dd8ec36ba7 100644 --- a/xen/include/acpi/cpufreq/processor_perf.h +++ b/xen/include/acpi/cpufreq/processor_perf.h @@ -8,6 +8,7 @@ #define XEN_PX_INIT 0x80000000 bool hwp_available(void); +bool hwp_active(void); int hwp_register_driver(void); int powernow_cpufreq_init(void); diff --git a/xen/include/acpi/pdc_intel.h b/xen/include/acpi/pdc_intel.h index 4fb719d6f5..e8332898fc 100644 --- a/xen/include/acpi/pdc_intel.h +++ b/xen/include/acpi/pdc_intel.h @@ -17,6 +17,7 @@ #define ACPI_PDC_C_C1_FFH (0x0100) #define ACPI_PDC_C_C2C3_FFH (0x0200) #define ACPI_PDC_SMP_P_HWCOORD (0x0800) +#define ACPI_PDC_CPPC_NTV_INT (0x1000) #define ACPI_PDC_EST_CAPABILITY_SMP (ACPI_PDC_SMP_C1PT | \ ACPI_PDC_C_C1_HALT | \ -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:31:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:31:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528111.820927 (Exim 4.92) (envelope-from ) id 1ptZEs-0003ZG-Fd; Mon, 01 May 2023 19:31:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528111.820927; Mon, 01 May 2023 19:31:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZEs-0003Z5-C5; Mon, 01 May 2023 19:31:10 +0000 Received: by outflank-mailman (input) for mailman id 528111; Mon, 01 May 2023 19:31:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZEq-000149-Vx for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:31:08 +0000 Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [2607:f8b0:4864:20::734]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b7cb34ef-e856-11ed-8611-37d641c3527e; Mon, 01 May 2023 21:31:07 +0200 (CEST) Received: by mail-qk1-x734.google.com with SMTP id af79cd13be357-74e12e93384so121163085a.3 for ; Mon, 01 May 2023 12:31:07 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id d6-20020ac80606000000b003bf9f9f1844sm9351784qth.71.2023.05.01.12.31.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:31:04 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b7cb34ef-e856-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969465; x=1685561465; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dJbA+BcuMsWkD5WxDhYLUpTvdE3qh/C4Qmxcz85bGeo=; b=nPWlTQA1AjIKcrvqph4r2lWQaecwmL0x3jr52qhY18Eh/tj6AwisM64Uf5AQI6tDP6 +SHB6kT3hgPFzYFuPSiZdnezeuvRqRWklk6JbJwPnYXYJbiqijAAN73gfC6F2KQ72EM6 S/WRuCg+Qj79DNx629ZznAmgIMCLFtAaTKnc/saoTH6BdXF/uSDpTQLtAL19IYtku7Qr TfzVmWYYvO2v2vCS6L9GfUYjTluKmU+tKekrWsmI0v37A1B6cVvfI5NwNK4xxvxBpOt8 BlRjgQ7IhaWZBBqlScTZy3R7VDxW6QfZxKvbgKIcen7kq3fhlMEwWUIHssUGtO3tUD4/ FUSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969465; x=1685561465; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dJbA+BcuMsWkD5WxDhYLUpTvdE3qh/C4Qmxcz85bGeo=; b=cQx7lRyvtUz+bVqmhLqdnDXUM6eiKzVugVDf1Hcc8mqD0sJKGxtISdyegXLIGi9LT/ egKYG4eKcRb0BNrBPoNBmvPt7OqWq+yTzbFoq5G90dnCERGupYN8tYhXGGdIe0CzBJ0T 5UTEWvoRVmvg4Ii3ouaoeK5E8s8WIrgvrMEwU95iHdBjPeEN5mf6ckd+HzDmoHJvR/Mn gGc5aaBtbytUqEFedN3sg+HPTZGmLPgkSvDslA2ajeLiQvg+O3BEO4q7FE8w7cex9xrv JDilodbUH/M7JwiQyPum3O7tntvxqFyRtl8IfIAX+xh415bviSXs8JqaglpJGtVKhVBH LUsg== X-Gm-Message-State: AC+VfDyVNDBtQv17JRHMam2wb/9ykLhrIk1dgkggIoSVtv8ezS7te8hG a5PZBod1xAPZlDIQk4kzU+nvnpAjTGA= X-Google-Smtp-Source: ACHHUZ4yIAxtLHY8htulS6SPC+QNZq8i1LbhxAtAihfEzMKjPNr6hbZgwyHOFtp1cGuiuvKuMhWGew== X-Received: by 2002:ac8:5e10:0:b0:3ef:34e1:d380 with SMTP id h16-20020ac85e10000000b003ef34e1d380mr24529806qtx.11.1682969465465; Mon, 01 May 2023 12:31:05 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v3 07/14 RESEND] cpufreq: Export HWP parameters to userspace Date: Mon, 1 May 2023 15:30:27 -0400 Message-Id: <20230501193034.88575-8-jandryuk@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230501193034.88575-1-jandryuk@gmail.com> References: <20230501193034.88575-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Extend xen_get_cpufreq_para to return hwp parameters. These match the hardware rather closely. We need the features bitmask to indicated fields supported by the actual hardware. The use of uint8_t parameters matches the hardware size. uint32_t entries grows the sysctl_t past the build assertion in setup.c. The uint8_t ranges are supported across multiple generations, so hopefully they won't change. Signed-off-by: Jason Andryuk --- v2: Style fixes Don't bump XEN_SYSCTL_INTERFACE_VERSION Drop cpufreq.h comment divider Expand xen_hwp_para comment Add HWP activity window mantissa/exponent defines Handle union rename Add const to get_hwp_para Remove hw_ prefix from xen_hwp_para members Use XEN_HWP_GOVERNOR Use per_cpu for hwp_drv_data --- xen/arch/x86/acpi/cpufreq/hwp.c | 25 +++++++++++++++++++++++++ xen/drivers/acpi/pmstat.c | 5 +++++ xen/include/acpi/cpufreq/cpufreq.h | 2 ++ xen/include/public/sysctl.h | 26 ++++++++++++++++++++++++++ 4 files changed, 58 insertions(+) diff --git a/xen/arch/x86/acpi/cpufreq/hwp.c b/xen/arch/x86/acpi/cpufreq/hwp.c index f84abe1386..cb52918799 100644 --- a/xen/arch/x86/acpi/cpufreq/hwp.c +++ b/xen/arch/x86/acpi/cpufreq/hwp.c @@ -506,6 +506,31 @@ static const struct cpufreq_driver __initconstrel hwp_cpufreq_driver = .update = hwp_cpufreq_update, }; +int get_hwp_para(const struct cpufreq_policy *policy, + struct xen_hwp_para *hwp_para) +{ + unsigned int cpu = policy->cpu; + const struct hwp_drv_data *data = per_cpu(hwp_drv_data, cpu); + + if ( data == NULL ) + return -EINVAL; + + hwp_para->features = + (feature_hwp_activity_window ? XEN_SYSCTL_HWP_FEAT_ACT_WINDOW : 0) | + (feature_hwp_energy_perf ? XEN_SYSCTL_HWP_FEAT_ENERGY_PERF : 0); + hwp_para->lowest = data->hw.lowest; + hwp_para->most_efficient = data->hw.most_efficient; + hwp_para->guaranteed = data->hw.guaranteed; + hwp_para->highest = data->hw.highest; + hwp_para->minimum = data->minimum; + hwp_para->maximum = data->maximum; + hwp_para->energy_perf = data->energy_perf; + hwp_para->activity_window = data->activity_window; + hwp_para->desired = data->desired; + + return 0; +} + int __init hwp_register_driver(void) { return cpufreq_register_driver(&hwp_cpufreq_driver); diff --git a/xen/drivers/acpi/pmstat.c b/xen/drivers/acpi/pmstat.c index 1bae635101..67fd9dabd4 100644 --- a/xen/drivers/acpi/pmstat.c +++ b/xen/drivers/acpi/pmstat.c @@ -290,6 +290,11 @@ static int get_cpufreq_para(struct xen_sysctl_pm_op *op) &op->u.get_para.u.ondemand.sampling_rate, &op->u.get_para.u.ondemand.up_threshold); } + + if ( !strncasecmp(op->u.get_para.scaling_governor, XEN_HWP_GOVERNOR, + CPUFREQ_NAME_LEN) ) + ret = get_hwp_para(policy, &op->u.get_para.u.hwp_para); + op->u.get_para.turbo_enabled = cpufreq_get_turbo_status(op->cpuid); return ret; diff --git a/xen/include/acpi/cpufreq/cpufreq.h b/xen/include/acpi/cpufreq/cpufreq.h index 29a712a4f1..92b4c7e79c 100644 --- a/xen/include/acpi/cpufreq/cpufreq.h +++ b/xen/include/acpi/cpufreq/cpufreq.h @@ -247,5 +247,7 @@ void intel_feature_detect(struct cpufreq_policy *policy); extern bool opt_cpufreq_hwp; extern bool opt_cpufreq_hdc; +int get_hwp_para(const struct cpufreq_policy *policy, + struct xen_hwp_para *hwp_para); #endif /* __XEN_CPUFREQ_PM_H__ */ diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h index b448f13b75..bf7e6594a7 100644 --- a/xen/include/public/sysctl.h +++ b/xen/include/public/sysctl.h @@ -292,6 +292,31 @@ struct xen_ondemand { uint32_t up_threshold; }; +struct xen_hwp_para { + /* + * bits 6:0 - 7bit mantissa + * bits 9:7 - 3bit base-10 exponent + * btis 15:10 - Unused - must be 0 + */ +#define HWP_ACT_WINDOW_MANTISSA_MASK 0x7f +#define HWP_ACT_WINDOW_EXPONENT_MASK 0x7 +#define HWP_ACT_WINDOW_EXPONENT_SHIFT 7 + uint16_t activity_window; + /* energy_perf range 0-255 if 1. Otherwise 0-15 */ +#define XEN_SYSCTL_HWP_FEAT_ENERGY_PERF (1 << 0) + /* activity_window supported if 1 */ +#define XEN_SYSCTL_HWP_FEAT_ACT_WINDOW (1 << 1) + uint8_t features; /* bit flags for features */ + uint8_t lowest; + uint8_t most_efficient; + uint8_t guaranteed; + uint8_t highest; + uint8_t minimum; + uint8_t maximum; + uint8_t desired; + uint8_t energy_perf; +}; + #define XEN_HWP_GOVERNOR "hwp-internal" /* * cpufreq para name of this structure named @@ -324,6 +349,7 @@ struct xen_get_cpufreq_para { union { struct xen_userspace userspace; struct xen_ondemand ondemand; + struct xen_hwp_para hwp_para; } u; int32_t turbo_enabled; -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:31:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:31:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528113.820937 (Exim 4.92) (envelope-from ) id 1ptZEu-0003zl-Qb; Mon, 01 May 2023 19:31:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528113.820937; Mon, 01 May 2023 19:31:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZEu-0003zc-M2; Mon, 01 May 2023 19:31:12 +0000 Received: by outflank-mailman (input) for mailman id 528113; Mon, 01 May 2023 19:31:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZEt-000149-19 for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:31:11 +0000 Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [2607:f8b0:4864:20::836]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b922eb57-e856-11ed-8611-37d641c3527e; Mon, 01 May 2023 21:31:09 +0200 (CEST) Received: by mail-qt1-x836.google.com with SMTP id d75a77b69052e-3eab1f2ba18so13396801cf.0 for ; Mon, 01 May 2023 12:31:09 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id d6-20020ac80606000000b003bf9f9f1844sm9351784qth.71.2023.05.01.12.31.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:31:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b922eb57-e856-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969468; x=1685561468; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7SMitIr3/lPLI3ESf+JT4clE3jKHCc578aryTjCi/TM=; b=fiGDFAOgA/yRwd4eCcCOYq1b+8La77hlcXxxVYY11Jk3ndSYohpbOgDWzMc+ef2i7y MZUw4a2bVpYlLbvPg0AkKIkzn/jZOC0/fSkrMmVCbF5iNv+gD5CzIpL9eKIXO4A4IWOY zO5I+Gppui1NvJrXDFx5WHy4gH9DsTROqREvqQVl0rpr2FiWZ8JRj9AD29fcdwqL7mOu UenAFx6F2pAc7I+Z0qFd2qyUwx2BXVG4ZsRItUDTqLk6dI9yNwsqHk3OWC0hmzQW/cDz klfjzF7uS9KkQhdVoDE3D2XHzi//AoVJg5Gt783IE/hqKELm00ios7PJhaABv269uSGX nNlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969468; x=1685561468; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7SMitIr3/lPLI3ESf+JT4clE3jKHCc578aryTjCi/TM=; b=Jin5OuPOQdz8Jh887hbY6gzPZGH5y9Cc095NUQiEse0T7JJLcMiOnGZj+ZVgIx75Ke 6MedX/5QdFyFcUiftjLOMjR6w8Dahp9PLyNjygRya4Tdb9U1ym0JcSTJKUHkpl3lu6rl QmU8gVvrFuqtVbVur1E32AzCR8S3P90g4cVVdsncJw0Qt+N1jAkA359EwHv+ZD80XIaW oRdCim4VZ4fycer0ZphWR5XkSr8/jPjpHVz2jUyr2BCFcMDEWz04qrGG1LYduza7pF88 db8F+zcTViI+amomQkJLr9pLrpyUOWeQk6i1aHd8D3Wv6kJzm4ZhhHtCazPmdzmLsqsT De8Q== X-Gm-Message-State: AC+VfDzdwcu5opoyq/xs7T86F7RJgDc8HIq1+aQba8XAHRQ6IlwPVyHO iba1AHNuw+Ka7hQNk1ahK8IjsqBkC2g= X-Google-Smtp-Source: ACHHUZ4zfsPnNVWoI6gOx5jVThON5YPlKizbp+7vW0T78d3g1rUxzlLc/WN/8uL2RyHM2Eexervnuw== X-Received: by 2002:a05:622a:1a8c:b0:3a8:a84:7ffa with SMTP id s12-20020a05622a1a8c00b003a80a847ffamr24778833qtc.57.1682969467897; Mon, 01 May 2023 12:31:07 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH v3 08/14 RESEND] libxc: Include hwp_para in definitions Date: Mon, 1 May 2023 15:30:28 -0400 Message-Id: <20230501193034.88575-9-jandryuk@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230501193034.88575-1-jandryuk@gmail.com> References: <20230501193034.88575-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Expose the hwp_para fields through libxc. Signed-off-by: Jason Andryuk --- tools/include/xenctrl.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index 05967ecc92..437001d713 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -1903,6 +1903,7 @@ int xc_smt_disable(xc_interface *xch); */ typedef struct xen_userspace xc_userspace_t; typedef struct xen_ondemand xc_ondemand_t; +typedef struct xen_hwp_para xc_hwp_para_t; struct xc_get_cpufreq_para { /* IN/OUT variable */ @@ -1930,6 +1931,7 @@ struct xc_get_cpufreq_para { union { xc_userspace_t userspace; xc_ondemand_t ondemand; + xc_hwp_para_t hwp_para; } u; int32_t turbo_enabled; -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:31:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:31:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528115.820947 (Exim 4.92) (envelope-from ) id 1ptZEw-0004Nk-DC; Mon, 01 May 2023 19:31:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528115.820947; Mon, 01 May 2023 19:31:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZEw-0004Md-73; Mon, 01 May 2023 19:31:14 +0000 Received: by outflank-mailman (input) for mailman id 528115; Mon, 01 May 2023 19:31:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZEu-000149-Vf for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:31:12 +0000 Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [2607:f8b0:4864:20::836]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bab86444-e856-11ed-8611-37d641c3527e; Mon, 01 May 2023 21:31:11 +0200 (CEST) Received: by mail-qt1-x836.google.com with SMTP id d75a77b69052e-3eab1f2ba18so13397041cf.0 for ; Mon, 01 May 2023 12:31:11 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id d6-20020ac80606000000b003bf9f9f1844sm9351784qth.71.2023.05.01.12.31.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:31:09 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bab86444-e856-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969470; x=1685561470; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eu+1+LIcVcy6gjOVYvjWRf1phVWRYdUosVQFp9Yv6+Y=; b=ql4ZCfHL4hQ0YAqSbKsTQKwnIs1cococeDaD457Nd/sfN5/9p3XqlZSXQSmhYvdmBP W7yppqkFqdkjvLPtUOedeKRhze+niKiPC42xH8rLzDf/TDD9lhegO79YtMMwfXGQ3iwR 5ZIQu0fUlo+SGW4BCPKFqLK9ZeNE4ntJZrtDe8B2UGjfD9ViFOSsQmWsesd0/Ag6TOuu ryHfod/UGi6YB9XTT8mlVX2YJGkndLYiBrAyEJO3/P92P4qKqWpUGoCRGSVjuNSNPPfR GoijsvrKi55fyZrP9J0BYmDW6CFG3rS3pA9ysF+snUGXJjIOq4jupDAkynLScU7AaUAQ jpXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969470; x=1685561470; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eu+1+LIcVcy6gjOVYvjWRf1phVWRYdUosVQFp9Yv6+Y=; b=KVsx/qHi083GcvYFA+XFXNhb1GbDqJmB8x6KuPxeLc/TydkvfAjkYzRlv5Z0Q2DJrP DwD2xTHERN9bmliu94BHjsU90jQsvc7zqIn8Wj8Ze0whcYB4isCoDLA4sZljYX1Ksp9w qGIj8mWUnG0fIcM6+LoAE8FXsAO+d+q/Mjkh9YjxghkQAc7/kAUqQ8hI+gWL7y+92WVP 8YRZh8+E6s8BZH+Vpzc/yrTYlZZP6Yr9C7oMy2NkuMlVglZhmmtH6L2eK5+l8YK8TkUv ABOyE5IXAhe9zNiYt3tc/jRGPuIghjpUidB/mIYeVp95hkIrJxd6/CSbCl2hiyqveVY3 NxOQ== X-Gm-Message-State: AC+VfDyh/+midfWynqigiu/+cviRjgubegJM7Hl97EWRcyJ81oSAGLiD KzGIbfC1smZYySf0DKhI3JIqianQDLc= X-Google-Smtp-Source: ACHHUZ75umoQyE6/G5AilWu+IH7PSPRSc9wk3YctqTMZOoMg4HPknC2FZ+DYgYcgnIQ1PIyrcoZ8AA== X-Received: by 2002:a05:622a:646:b0:3eb:9b03:b5ba with SMTP id a6-20020a05622a064600b003eb9b03b5bamr23146173qtb.37.1682969470417; Mon, 01 May 2023 12:31:10 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Wei Liu , Anthony PERARD Subject: [PATCH v3 09/14 RESEND] xenpm: Print HWP parameters Date: Mon, 1 May 2023 15:30:29 -0400 Message-Id: <20230501193034.88575-10-jandryuk@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230501193034.88575-1-jandryuk@gmail.com> References: <20230501193034.88575-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Print HWP-specific parameters. Some are always present, but others depend on hardware support. Signed-off-by: Jason Andryuk --- v2: Style fixes Declare i outside loop Replace repearted hardware/configured limits with spaces Fixup for hw_ removal Use XEN_HWP_GOVERNOR Use HWP_ACT_WINDOW_EXPONENT_* Remove energy_perf hw autonomous - 0 doesn't mean autonomous --- tools/misc/xenpm.c | 65 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 65 insertions(+) diff --git a/tools/misc/xenpm.c b/tools/misc/xenpm.c index ce8d7644d0..b2defde0d4 100644 --- a/tools/misc/xenpm.c +++ b/tools/misc/xenpm.c @@ -708,6 +708,44 @@ void start_gather_func(int argc, char *argv[]) pause(); } +static void calculate_hwp_activity_window(const xc_hwp_para_t *hwp, + unsigned int *activity_window, + const char **units) +{ + unsigned int mantissa = hwp->activity_window & HWP_ACT_WINDOW_MANTISSA_MASK; + unsigned int exponent = + (hwp->activity_window >> HWP_ACT_WINDOW_EXPONENT_SHIFT) & + HWP_ACT_WINDOW_EXPONENT_MASK; + unsigned int multiplier = 1; + unsigned int i; + + if ( hwp->activity_window == 0 ) + { + *units = "hardware selected"; + *activity_window = 0; + + return; + } + + if ( exponent >= 6 ) + { + *units = "s"; + exponent -= 6; + } + else if ( exponent >= 3 ) + { + *units = "ms"; + exponent -= 3; + } + else + *units = "us"; + + for ( i = 0; i < exponent; i++ ) + multiplier *= 10; + + *activity_window = mantissa * multiplier; +} + /* print out parameters about cpu frequency */ static void print_cpufreq_para(int cpuid, struct xc_get_cpufreq_para *p_cpufreq) { @@ -773,6 +811,33 @@ static void print_cpufreq_para(int cpuid, struct xc_get_cpufreq_para *p_cpufreq) p_cpufreq->scaling_cur_freq); } + if ( strcmp(p_cpufreq->scaling_governor, XEN_HWP_GOVERNOR) == 0 ) + { + const xc_hwp_para_t *hwp = &p_cpufreq->u.hwp_para; + + printf("hwp variables :\n"); + printf(" hardware limits : lowest [%u] most_efficient [%u]\n", + hwp->lowest, hwp->most_efficient); + printf(" : guaranteed [%u] highest [%u]\n", + hwp->guaranteed, hwp->highest); + printf(" configured limits : min [%u] max [%u] energy_perf [%u]\n", + hwp->minimum, hwp->maximum, hwp->energy_perf); + + if ( hwp->features & XEN_SYSCTL_HWP_FEAT_ACT_WINDOW ) + { + unsigned int activity_window; + const char *units; + + calculate_hwp_activity_window(hwp, &activity_window, &units); + printf(" : activity_window [%u %s]\n", + activity_window, units); + } + + printf(" : desired [%u%s]\n", + hwp->desired, + hwp->desired ? "" : " hw autonomous"); + } + printf("turbo mode : %s\n", p_cpufreq->turbo_enabled ? "enabled" : "disabled or n/a"); printf("\n"); -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:31:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:31:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528117.820957 (Exim 4.92) (envelope-from ) id 1ptZEy-0004nF-QO; Mon, 01 May 2023 19:31:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528117.820957; Mon, 01 May 2023 19:31:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZEy-0004mj-Jh; Mon, 01 May 2023 19:31:16 +0000 Received: by outflank-mailman (input) for mailman id 528117; Mon, 01 May 2023 19:31:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZEx-0000m4-7L for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:31:15 +0000 Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [2607:f8b0:4864:20::834]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bc136e52-e856-11ed-b225-6b7b168915f2; Mon, 01 May 2023 21:31:14 +0200 (CEST) Received: by mail-qt1-x834.google.com with SMTP id d75a77b69052e-3ef588dcf7aso30763471cf.1 for ; Mon, 01 May 2023 12:31:14 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id d6-20020ac80606000000b003bf9f9f1844sm9351784qth.71.2023.05.01.12.31.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:31:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bc136e52-e856-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969473; x=1685561473; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YO0WsYuSOYLWQPRYhV/xiXSnog1IJZfbXjjJjaPzhyY=; b=p6B+B6XpWfwKWnoxvpW5gtX5oGjDvEZdCLriLQQadIJV+J3ljmoPJcH4bPIuL2ucfz mtHlnETg0UUF5jByhu/mM9kCyYkjt9P0hrQo1BqQXzxoyHqAN/zU/4cLUegdhqJGFW3t QztH/fVaAxhlryJfCG8yyT2BR+q8MjaDHQ1k8RBkJvq7VwlkvwAzt64TqlMQRtaJLSlX B9OciZJscFFBbj8sJxWeij9ItpbyraeDBE61NstR0lmm+WYl7PVusJFMbrY+siLj8pf9 Ra5w3MhcVc+FspJuTOmCPDMSjYTp6lK70LZtyG2s2KTPyCZWrz8TqB30M8y+BTPNtocN BQzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969473; x=1685561473; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YO0WsYuSOYLWQPRYhV/xiXSnog1IJZfbXjjJjaPzhyY=; b=QpuBVmnais08zJSPDCUqVlgC/Hx8zXpAmue0WlvQCqLNznlb47OM5qWwpvtHhJKgI3 pNDIu5QQM5CZHmZV3zPIaAxs72097gv3hm9V/mMg8YO70MtNHHE7VJ16zpQBayUWkJf2 wqYOcH7phRpoVtDvYEUeCqYruaVFGkKlCrSTIAXa2dBArn9H6lbKzTA8JtBkVRjiQV7I W05zriV0EnE09HlAoU5K58Ba9BMUrw+d7XiVXv8HhwF6b8Xo984uv722mJxNVoX1v6K6 sy1ePIFiAeIONA0US/X9ZV0nffTXvml64BP8530FXkSbbzYxS4TXLgZi19kuxzvaKtPX DNaw== X-Gm-Message-State: AC+VfDxcJS26HCAvfpwbsNFu1ysfH3FWzlwba98dHqpLmrzDOfv3NicB DOaBH6h6IRhYu4h37lRpPKWMuMHN0hE= X-Google-Smtp-Source: ACHHUZ6b2qw5XxkOLyjOcqjlFfogIYKVNHV7rj6p+aoYwVx36V4SPAB0ZWkXmKy5FGmMsIXEVVUykQ== X-Received: by 2002:a05:622a:13cc:b0:3ef:6c09:edcc with SMTP id p12-20020a05622a13cc00b003ef6c09edccmr23837085qtk.22.1682969472810; Mon, 01 May 2023 12:31:12 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v3 10/14 RESEND] xen: Add SET_CPUFREQ_HWP xen_sysctl_pm_op Date: Mon, 1 May 2023 15:30:30 -0400 Message-Id: <20230501193034.88575-11-jandryuk@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230501193034.88575-1-jandryuk@gmail.com> References: <20230501193034.88575-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add SET_CPUFREQ_HWP xen_sysctl_pm_op to set HWP parameters. The sysctl supports setting multiple values simultaneously as indicated by the set_params bits. This allows atomically applying new HWP configuration via a single wrmsr. XEN_SYSCTL_HWP_SET_PRESET_BALANCE/PERFORMANCE/POWERSAVE provide three common presets. Setting them depends on hardware limits which the hypervisor is already caching. So using them allows skipping a hypercall to query the limits (lowest/highest) to then set those same values. The code is organized to allow a preset to be refined with additional stuff if desired. "most_efficient" and "guaranteed" could be additional presets in the future, but the are not added now. Those levels can change at runtime, but we don't have code in place to monitor and update for those events. Signed-off-by: Jason Andryuk --- v3: Remove cpufreq_governor_internal from set_cpufreq_hwp v2: Update for naming anonymous union Drop hwp_err for invalid input in set_hwp_para() Drop uint16_t cast in XEN_SYSCTL_HWP_SET_PARAM_MASK Drop parens for HWP_SET_PRESET defines Reference activity_window format comment Place SET_CPUFREQ_HWP after SET_CPUFREQ_PARA Add {HWP,IA32}_ENERGY_PERF_MAX_{PERFORMANCE,POWERSAVE} defines Order defines before fields in sysctl.h Use XEN_HWP_GOVERNOR Use per_cpu for hwp_drv_data --- xen/arch/x86/acpi/cpufreq/hwp.c | 96 ++++++++++++++++++++++++++++++ xen/drivers/acpi/pmstat.c | 18 ++++++ xen/include/acpi/cpufreq/cpufreq.h | 2 + xen/include/public/sysctl.h | 30 ++++++++++ 4 files changed, 146 insertions(+) diff --git a/xen/arch/x86/acpi/cpufreq/hwp.c b/xen/arch/x86/acpi/cpufreq/hwp.c index cb52918799..3d15875dc1 100644 --- a/xen/arch/x86/acpi/cpufreq/hwp.c +++ b/xen/arch/x86/acpi/cpufreq/hwp.c @@ -27,7 +27,9 @@ static bool feature_hdc; __initdata bool opt_cpufreq_hwp = false; __initdata bool opt_cpufreq_hdc = true; +#define HWP_ENERGY_PERF_MAX_PERFORMANCE 0 #define HWP_ENERGY_PERF_BALANCE 0x80 +#define HWP_ENERGY_PERF_MAX_POWERSAVE 0xff #define IA32_ENERGY_BIAS_BALANCE 0x7 #define IA32_ENERGY_BIAS_MAX_POWERSAVE 0xf #define IA32_ENERGY_BIAS_MASK 0xf @@ -531,6 +533,100 @@ int get_hwp_para(const struct cpufreq_policy *policy, return 0; } +int set_hwp_para(struct cpufreq_policy *policy, + struct xen_set_hwp_para *set_hwp) +{ + unsigned int cpu = policy->cpu; + struct hwp_drv_data *data = per_cpu(hwp_drv_data, cpu); + + if ( data == NULL ) + return -EINVAL; + + /* Validate all parameters first */ + if ( set_hwp->set_params & ~XEN_SYSCTL_HWP_SET_PARAM_MASK ) + return -EINVAL; + + if ( set_hwp->activity_window & ~XEN_SYSCTL_HWP_ACT_WINDOW_MASK ) + return -EINVAL; + + if ( !feature_hwp_energy_perf && + (set_hwp->set_params & XEN_SYSCTL_HWP_SET_ENERGY_PERF) && + set_hwp->energy_perf > IA32_ENERGY_BIAS_MAX_POWERSAVE ) + return -EINVAL; + + if ( (set_hwp->set_params & XEN_SYSCTL_HWP_SET_DESIRED) && + set_hwp->desired != 0 && + (set_hwp->desired < data->hw.lowest || + set_hwp->desired > data->hw.highest) ) + return -EINVAL; + + /* + * minimum & maximum are not validated as hardware doesn't seem to care + * and the SDM says CPUs will clip internally. + */ + + /* Apply presets */ + switch ( set_hwp->set_params & XEN_SYSCTL_HWP_SET_PRESET_MASK ) + { + case XEN_SYSCTL_HWP_SET_PRESET_POWERSAVE: + data->minimum = data->hw.lowest; + data->maximum = data->hw.lowest; + data->activity_window = 0; + if ( feature_hwp_energy_perf ) + data->energy_perf = HWP_ENERGY_PERF_MAX_POWERSAVE; + else + data->energy_perf = IA32_ENERGY_BIAS_MAX_POWERSAVE; + data->desired = 0; + break; + + case XEN_SYSCTL_HWP_SET_PRESET_PERFORMANCE: + data->minimum = data->hw.highest; + data->maximum = data->hw.highest; + data->activity_window = 0; + data->energy_perf = HWP_ENERGY_PERF_MAX_PERFORMANCE; + data->desired = 0; + break; + + case XEN_SYSCTL_HWP_SET_PRESET_BALANCE: + data->minimum = data->hw.lowest; + data->maximum = data->hw.highest; + data->activity_window = 0; + if ( feature_hwp_energy_perf ) + data->energy_perf = HWP_ENERGY_PERF_BALANCE; + else + data->energy_perf = IA32_ENERGY_BIAS_BALANCE; + data->desired = 0; + break; + + case XEN_SYSCTL_HWP_SET_PRESET_NONE: + break; + + default: + return -EINVAL; + } + + /* Further customize presets if needed */ + if ( set_hwp->set_params & XEN_SYSCTL_HWP_SET_MINIMUM ) + data->minimum = set_hwp->minimum; + + if ( set_hwp->set_params & XEN_SYSCTL_HWP_SET_MAXIMUM ) + data->maximum = set_hwp->maximum; + + if ( set_hwp->set_params & XEN_SYSCTL_HWP_SET_ENERGY_PERF ) + data->energy_perf = set_hwp->energy_perf; + + if ( set_hwp->set_params & XEN_SYSCTL_HWP_SET_DESIRED ) + data->desired = set_hwp->desired; + + if ( set_hwp->set_params & XEN_SYSCTL_HWP_SET_ACT_WINDOW ) + data->activity_window = set_hwp->activity_window & + XEN_SYSCTL_HWP_ACT_WINDOW_MASK; + + hwp_cpufreq_target(policy, 0, 0); + + return 0; +} + int __init hwp_register_driver(void) { return cpufreq_register_driver(&hwp_cpufreq_driver); diff --git a/xen/drivers/acpi/pmstat.c b/xen/drivers/acpi/pmstat.c index 67fd9dabd4..12c76f5e57 100644 --- a/xen/drivers/acpi/pmstat.c +++ b/xen/drivers/acpi/pmstat.c @@ -398,6 +398,20 @@ static int set_cpufreq_para(struct xen_sysctl_pm_op *op) return ret; } +static int set_cpufreq_hwp(struct xen_sysctl_pm_op *op) +{ + struct cpufreq_policy *policy = per_cpu(cpufreq_cpu_policy, op->cpuid); + + if ( !policy || !policy->governor ) + return -EINVAL; + + if ( strncasecmp(policy->governor->name, XEN_HWP_GOVERNOR, + CPUFREQ_NAME_LEN) ) + return -EINVAL; + + return set_hwp_para(policy, &op->u.set_hwp); +} + int do_pm_op(struct xen_sysctl_pm_op *op) { int ret = 0; @@ -470,6 +484,10 @@ int do_pm_op(struct xen_sysctl_pm_op *op) break; } + case SET_CPUFREQ_HWP: + ret = set_cpufreq_hwp(op); + break; + case GET_CPUFREQ_AVGFREQ: { op->u.get_avgfreq = cpufreq_driver_getavg(op->cpuid, USR_GETAVG); diff --git a/xen/include/acpi/cpufreq/cpufreq.h b/xen/include/acpi/cpufreq/cpufreq.h index 92b4c7e79c..b8831b2cd3 100644 --- a/xen/include/acpi/cpufreq/cpufreq.h +++ b/xen/include/acpi/cpufreq/cpufreq.h @@ -249,5 +249,7 @@ extern bool opt_cpufreq_hwp; extern bool opt_cpufreq_hdc; int get_hwp_para(const struct cpufreq_policy *policy, struct xen_hwp_para *hwp_para); +int set_hwp_para(struct cpufreq_policy *policy, + struct xen_set_hwp_para *set_hwp); #endif /* __XEN_CPUFREQ_PM_H__ */ diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h index bf7e6594a7..3242472cbe 100644 --- a/xen/include/public/sysctl.h +++ b/xen/include/public/sysctl.h @@ -317,6 +317,34 @@ struct xen_hwp_para { uint8_t energy_perf; }; +/* set multiple values simultaneously when set_args bit is set */ +struct xen_set_hwp_para { +#define XEN_SYSCTL_HWP_SET_DESIRED (1U << 0) +#define XEN_SYSCTL_HWP_SET_ENERGY_PERF (1U << 1) +#define XEN_SYSCTL_HWP_SET_ACT_WINDOW (1U << 2) +#define XEN_SYSCTL_HWP_SET_MINIMUM (1U << 3) +#define XEN_SYSCTL_HWP_SET_MAXIMUM (1U << 4) +#define XEN_SYSCTL_HWP_SET_PRESET_MASK 0xf000 +#define XEN_SYSCTL_HWP_SET_PRESET_NONE 0x0000 +#define XEN_SYSCTL_HWP_SET_PRESET_BALANCE 0x1000 +#define XEN_SYSCTL_HWP_SET_PRESET_POWERSAVE 0x2000 +#define XEN_SYSCTL_HWP_SET_PRESET_PERFORMANCE 0x3000 +#define XEN_SYSCTL_HWP_SET_PARAM_MASK ( \ + XEN_SYSCTL_HWP_SET_PRESET_MASK | \ + XEN_SYSCTL_HWP_SET_DESIRED | \ + XEN_SYSCTL_HWP_SET_ENERGY_PERF | \ + XEN_SYSCTL_HWP_SET_ACT_WINDOW | \ + XEN_SYSCTL_HWP_SET_MINIMUM | \ + XEN_SYSCTL_HWP_SET_MAXIMUM ) + uint16_t set_params; /* bitflags for valid values */ +#define XEN_SYSCTL_HWP_ACT_WINDOW_MASK 0x03ff + uint16_t activity_window; /* See comment in struct xen_hwp_para */ + uint8_t minimum; + uint8_t maximum; + uint8_t desired; + uint8_t energy_perf; /* 0-255 or 0-15 depending on HW support */ +}; + #define XEN_HWP_GOVERNOR "hwp-internal" /* * cpufreq para name of this structure named @@ -379,6 +407,7 @@ struct xen_sysctl_pm_op { #define SET_CPUFREQ_GOV (CPUFREQ_PARA | 0x02) #define SET_CPUFREQ_PARA (CPUFREQ_PARA | 0x03) #define GET_CPUFREQ_AVGFREQ (CPUFREQ_PARA | 0x04) + #define SET_CPUFREQ_HWP (CPUFREQ_PARA | 0x05) /* set/reset scheduler power saving option */ #define XEN_SYSCTL_pm_op_set_sched_opt_smt 0x21 @@ -405,6 +434,7 @@ struct xen_sysctl_pm_op { struct xen_get_cpufreq_para get_para; struct xen_set_cpufreq_gov set_gov; struct xen_set_cpufreq_para set_para; + struct xen_set_hwp_para set_hwp; uint64_aligned_t get_avgfreq; uint32_t set_sched_opt_smt; #define XEN_SYSCTL_CX_UNLIMITED 0xffffffff -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:31:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:31:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528120.820966 (Exim 4.92) (envelope-from ) id 1ptZF2-0005Mw-4d; Mon, 01 May 2023 19:31:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528120.820966; Mon, 01 May 2023 19:31:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZF2-0005MZ-1F; Mon, 01 May 2023 19:31:20 +0000 Received: by outflank-mailman (input) for mailman id 528120; Mon, 01 May 2023 19:31:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZF0-000149-N3 for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:31:18 +0000 Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [2607:f8b0:4864:20::82c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bd953b45-e856-11ed-8611-37d641c3527e; Mon, 01 May 2023 21:31:17 +0200 (CEST) Received: by mail-qt1-x82c.google.com with SMTP id d75a77b69052e-3ef38864360so32531821cf.2 for ; Mon, 01 May 2023 12:31:17 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id d6-20020ac80606000000b003bf9f9f1844sm9351784qth.71.2023.05.01.12.31.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:31:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bd953b45-e856-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969475; x=1685561475; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0JAKWHRmes/OZ2QqxthbDdVSth+8gV1gmiT1eY6OQAU=; b=agUYa27f+iQLWMNxlFEc2K+VW9/TDwM3m+jQfvXTxvXZbmzGAjWm0wsvu8JqtR207U t1t5hRwO5XCaNJeBc88seuaxK9iWobMhqaMFalduGXrSd1fuN4jpHX1uq0hiw73GxLxa QbJ0eOzdWZOowX39nQau708W4gepwI7smAEBwsHyb73JAshCTh2+k0inXyBLfFQROQjn kVZLmA8d83RtY1EFNGFyqPmD8NoRnV7padsi+zu+hjkMVIvAnO4R1lui3cpMG8T7Y8DP FqjAkbwmR1Ss3yV18+dB6lolo03B2Ai2r90qUQENivonfb8k4P3/JMrwXX/E19b/M6vA YtxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969475; x=1685561475; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0JAKWHRmes/OZ2QqxthbDdVSth+8gV1gmiT1eY6OQAU=; b=UlaklaRnKMH45rH2nnOqbKi5d+lnyRb0FeK2gNj7bSMajod8f/mQ29nKj5PAhsOB8k 4CePo6DrzAjDo0DVPvQcKhMiulxc/uIuGRf0aXI5Prq4HOLVSrpX5iTxYrBGatHRW/bK X6APhppKC6Lnfd/Jj9HouwnH6yLs9hNij2buwRLX2S6qNl5Lb6djIxcgvr+K8GAoLPSW nO6A2AXanDtZOaLgSVxtHudXr4WUFXiVikWssmeG1MxKoU1zuBiEK5ZNkWWktcX+sI5Y 7Xp+2t91IaVMhz3azgV4TSfyeNtEa+4dTqdZlcFQm1XgGU8Qva5nTpBmuhaQe9BRJ5rd V0SQ== X-Gm-Message-State: AC+VfDx45hYpx6vN6LN+G7gg5A2qoI+uqewsi5UXTQcy/BWmlJstqCgt d7FAT32sa+7T5HlYEdmPRXHdTtLleIw= X-Google-Smtp-Source: ACHHUZ7q7E2b3NRT8r2PP7bqWrRHuqumQRwO8VPJV/bucabXWhGvM2lctIFgM6saOuOeuyBtdclxKQ== X-Received: by 2002:ac8:5c08:0:b0:3ef:7975:99d0 with SMTP id i8-20020ac85c08000000b003ef797599d0mr24307476qti.31.1682969475143; Mon, 01 May 2023 12:31:15 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH v3 11/14 RESEND] libxc: Add xc_set_cpufreq_hwp Date: Mon, 1 May 2023 15:30:31 -0400 Message-Id: <20230501193034.88575-12-jandryuk@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230501193034.88575-1-jandryuk@gmail.com> References: <20230501193034.88575-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add xc_set_cpufreq_hwp to allow calling xen_systctl_pm_op SET_CPUFREQ_HWP. Signed-off-by: Jason Andryuk --- v2: Mark xc_set_hwp_para_t const --- tools/include/xenctrl.h | 4 ++++ tools/libs/ctrl/xc_pm.c | 18 ++++++++++++++++++ 2 files changed, 22 insertions(+) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index 437001d713..cd367d9d8f 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -1937,11 +1937,15 @@ struct xc_get_cpufreq_para { int32_t turbo_enabled; }; +typedef struct xen_set_hwp_para xc_set_hwp_para_t; + int xc_get_cpufreq_para(xc_interface *xch, int cpuid, struct xc_get_cpufreq_para *user_para); int xc_set_cpufreq_gov(xc_interface *xch, int cpuid, char *govname); int xc_set_cpufreq_para(xc_interface *xch, int cpuid, int ctrl_type, int ctrl_value); +int xc_set_cpufreq_hwp(xc_interface *xch, int cpuid, + const xc_set_hwp_para_t *set_hwp); int xc_get_cpufreq_avgfreq(xc_interface *xch, int cpuid, int *avg_freq); int xc_set_sched_opt_smt(xc_interface *xch, uint32_t value); diff --git a/tools/libs/ctrl/xc_pm.c b/tools/libs/ctrl/xc_pm.c index c3a9864bf7..a747ab053c 100644 --- a/tools/libs/ctrl/xc_pm.c +++ b/tools/libs/ctrl/xc_pm.c @@ -330,6 +330,24 @@ int xc_set_cpufreq_para(xc_interface *xch, int cpuid, return xc_sysctl(xch, &sysctl); } +int xc_set_cpufreq_hwp(xc_interface *xch, int cpuid, + const xc_set_hwp_para_t *set_hwp) +{ + DECLARE_SYSCTL; + + if ( !xch ) + { + errno = EINVAL; + return -1; + } + sysctl.cmd = XEN_SYSCTL_pm_op; + sysctl.u.pm_op.cmd = SET_CPUFREQ_HWP; + sysctl.u.pm_op.cpuid = cpuid; + sysctl.u.pm_op.u.set_hwp = *set_hwp; + + return xc_sysctl(xch, &sysctl); +} + int xc_get_cpufreq_avgfreq(xc_interface *xch, int cpuid, int *avg_freq) { int ret = 0; -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:39:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:39:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528136.820977 (Exim 4.92) (envelope-from ) id 1ptZMY-0007qg-UN; Mon, 01 May 2023 19:39:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528136.820977; Mon, 01 May 2023 19:39:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZMY-0007qX-RK; Mon, 01 May 2023 19:39:06 +0000 Received: by outflank-mailman (input) for mailman id 528136; Mon, 01 May 2023 19:39:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZDH-0006PY-PU for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:29:31 +0000 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [2607:f8b0:4864:20::62d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7864ac7c-e856-11ed-8611-37d641c3527e; Mon, 01 May 2023 21:29:20 +0200 (CEST) Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1aaea3909d1so17755805ad.2 for ; Mon, 01 May 2023 12:29:20 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.29.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:29:19 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7864ac7c-e856-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969359; x=1685561359; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uIsUNYOwSPNxjYFxvF4LgB4Ah8JH2T7Nmtlw8Cz+gsw=; b=JvPLlmC/XzUWqdECLyDwvfeLFLPFT450E92A3QXyvZyOZFiHjs0SqrfxeBMPzeb8LI K2VYtEv3r+e+UcHKuqN8TTRgEDMk5QiHg2w8LWe4aiFQNNV8Hh6df9gt7z6D8qxOouWJ wLPmS/k/ifaj+fNqHq4KBrLkalomexLgsPcDr4xMzpwyPwPn0hyVLwNcBBGjvlXZkwRl lPtqWGJrBs3wn3DJU9zWYI2bb/1KFvoVhNYahmv1oY0+idoipKM5ABGGY8tIdglpIS4E WqBtNig6OCJrivJLAJr7mSv5nUheWG1j4pFaa5KN6zFjtfYkKhLunWXNp9G65rPn/E55 zhpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969359; x=1685561359; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uIsUNYOwSPNxjYFxvF4LgB4Ah8JH2T7Nmtlw8Cz+gsw=; b=fuovOtMeRxE3+1W0Hee6wxwIlrpb4uUU5MkUD2lhnrUKD0PpjdPUu6F3gHm5uniYNh P6tIc4sy2YLUpH3fD/kRrU2RHfGbfQdxHoxPBgWCLxRd2UR8F70KEfg9j46VvkYQMAHr PUIPywKWf6FAWgMtS2dfv9yYhG9b5By1NCfpc1h/GLARy9RnCmPuvb7fKYXsrjnip5sM ZPhIWoEh17jTEcV1Ln2DnyvNmwvKcKmgYwY19f8wngEA/J9sHScGE0TWVPeaYi3h9PCd ugkqW3DAZZTKJkXmEWKEJD1uxqbhG5uMgO553esVSrSp6bhG763OfnSeupeZXShA1roT /mdg== X-Gm-Message-State: AC+VfDyx5cnbZztC5QeKkjjVJ+9Q/D17zXLudHKXATehKf6JfHTiwLNX Kk8kkAHpnoWLyA2rnTQKsJClzwfoMfO8nhMc X-Google-Smtp-Source: ACHHUZ4XGLMgkIB9Q6wCsJwFAYUMJfuCSptJDhnDjc9kz87hQFDk4CAG77uXolw+VTSUtUndXFrgrA== X-Received: by 2002:a17:903:120c:b0:1aa:f53a:5e45 with SMTP id l12-20020a170903120c00b001aaf53a5e45mr5020547plh.39.1682969359666; Mon, 01 May 2023 12:29:19 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" , "David S. Miller" Subject: [PATCH v2 31/34] sparc64: Convert various functions to use ptdescs Date: Mon, 1 May 2023 12:28:26 -0700 Message-Id: <20230501192829.17086-32-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Signed-off-by: Vishal Moola (Oracle) --- arch/sparc/mm/init_64.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c index 04f9db0c3111..eedb3e03b1fe 100644 --- a/arch/sparc/mm/init_64.c +++ b/arch/sparc/mm/init_64.c @@ -2893,14 +2893,15 @@ pte_t *pte_alloc_one_kernel(struct mm_struct *mm) pgtable_t pte_alloc_one(struct mm_struct *mm) { - struct page *page = alloc_page(GFP_KERNEL | __GFP_ZERO); - if (!page) + struct ptdesc *ptdesc = ptdesc_alloc(GFP_KERNEL | __GFP_ZERO, 0); + + if (!ptdesc) return NULL; - if (!pgtable_pte_page_ctor(page)) { - __free_page(page); + if (!ptdesc_pte_ctor(ptdesc)) { + ptdesc_free(ptdesc); return NULL; } - return (pte_t *) page_address(page); + return (pte_t *) ptdesc_address(ptdesc); } void pte_free_kernel(struct mm_struct *mm, pte_t *pte) @@ -2910,10 +2911,10 @@ void pte_free_kernel(struct mm_struct *mm, pte_t *pte) static void __pte_free(pgtable_t pte) { - struct page *page = virt_to_page(pte); + struct ptdesc *ptdesc = virt_to_ptdesc(pte); - pgtable_pte_page_dtor(page); - __free_page(page); + ptdesc_pte_dtor(ptdesc); + ptdesc_free(ptdesc); } void pte_free(struct mm_struct *mm, pgtable_t pte) -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:39:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:39:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528139.820987 (Exim 4.92) (envelope-from ) id 1ptZMa-00086X-8U; Mon, 01 May 2023 19:39:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528139.820987; Mon, 01 May 2023 19:39:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZMa-00086Q-52; Mon, 01 May 2023 19:39:08 +0000 Received: by outflank-mailman (input) for mailman id 528139; Mon, 01 May 2023 19:39:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCm-0006FS-Fl for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:29:00 +0000 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [2607:f8b0:4864:20::535]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6aa9bdc0-e856-11ed-b225-6b7b168915f2; Mon, 01 May 2023 21:28:58 +0200 (CEST) Received: by mail-pg1-x535.google.com with SMTP id 41be03b00d2f7-52c3ffc8d13so158497a12.2 for ; Mon, 01 May 2023 12:28:58 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.28.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:28:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6aa9bdc0-e856-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969337; x=1685561337; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ij5AkRCa+yootiVPqcVahGB0vu642P/kX8VFrblz4TQ=; b=UkuGYyJfBaWkUOY2u3PlvKhnoh02w7kKy6Yo+3jgJq0jrvHddqf+dLyHTj9abI3kjB +3BvMKKzDVLKdOt8tjDXhylN3ftFB2Dv4naACQiv7JfxIAQ+eWqFsM2f729a64J6CKIo OlCeiwuLQwZBmOQ0K2+KuoVUh+iT8KM5gemKLrwEoCjwq4V7nKjRwu9ccr7I3jE8KUCP /cwHlob/NeEwLBmBQ0+XtF7e7T+SHAaH9GHToGx8cp5jdfXxZIxid4S+cFW1MgiFv2tg PqSj02mK1VvkeR5635etrkR82//haDgUAAf4WRjR+9CVW5EPPVO9DB3jlHc5FET3LbQo Yxrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969337; x=1685561337; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ij5AkRCa+yootiVPqcVahGB0vu642P/kX8VFrblz4TQ=; b=d3z5tjHMAXE/De1vW79ylUciwSrskYULH4/E0fVFzHOvH+JSVGdo0iD6uoSEv+hG1j qZFgM3lQpLzwAdhV6/liSq0+JIVMK9AP5Wlxc/10g8HgLeRX4LaMvmElg0lrVBm9Tmpi 0nLjt7aSxWuf/cfxZIBGsOR/kx2t47HSsfEZ5XWFCj3oUrIeex3Pb111AEMH9vfy2GYT CC8FU2/QkmBmdWwOeeAEI90klqJ7KVY9H1EuJYGM32HgMxy2P1StOlqwEGtkIR71eYNe WixwIbdsDlrVzAefXSYQQJQZh6NMTZh2hfyk41er8QXOE+QT9rtv9BcAySkmFApabXbe ZWnw== X-Gm-Message-State: AC+VfDzpMwWmaXKKZ5RQDiYgl+NuiXSnCx+Y6TFEGsdU6mQcKT3jRy/E rpq1oONPb6D0/AkW8UvH7fM= X-Google-Smtp-Source: ACHHUZ56JMfJkN+zfbveEwGUizMU0dJC7BXLEE13YfG4Ba6DaXws7RlJ55LFBdOT1As72Xg5aIUi5g== X-Received: by 2002:a17:903:2343:b0:1a6:b971:faf8 with SMTP id c3-20020a170903234300b001a6b971faf8mr18128456plh.53.1682969336571; Mon, 01 May 2023 12:28:56 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" Subject: [PATCH v2 16/34] s390: Convert various gmap functions to use ptdescs Date: Mon, 1 May 2023 12:28:11 -0700 Message-Id: <20230501192829.17086-17-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In order to split struct ptdesc from struct page, convert various functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use ptdesc_alloc() and ptdesc_address() instead to help standardize page tables further. Signed-off-by: Vishal Moola (Oracle) --- arch/s390/mm/gmap.c | 230 ++++++++++++++++++++++++-------------------- 1 file changed, 128 insertions(+), 102 deletions(-) diff --git a/arch/s390/mm/gmap.c b/arch/s390/mm/gmap.c index a9e8b1805894..e833a7e81fbd 100644 --- a/arch/s390/mm/gmap.c +++ b/arch/s390/mm/gmap.c @@ -34,7 +34,7 @@ static struct gmap *gmap_alloc(unsigned long limit) { struct gmap *gmap; - struct page *page; + struct ptdesc *ptdesc; unsigned long *table; unsigned long etype, atype; @@ -67,12 +67,12 @@ static struct gmap *gmap_alloc(unsigned long limit) spin_lock_init(&gmap->guest_table_lock); spin_lock_init(&gmap->shadow_lock); refcount_set(&gmap->ref_count, 1); - page = alloc_pages(GFP_KERNEL_ACCOUNT, CRST_ALLOC_ORDER); - if (!page) + ptdesc = ptdesc_alloc(GFP_KERNEL_ACCOUNT, CRST_ALLOC_ORDER); + if (!ptdesc) goto out_free; - page->_pt_s390_gaddr = 0; - list_add(&page->lru, &gmap->crst_list); - table = page_to_virt(page); + ptdesc->_pt_s390_gaddr = 0; + list_add(&ptdesc->pt_list, &gmap->crst_list); + table = ptdesc_to_virt(ptdesc); crst_table_init(table, etype); gmap->table = table; gmap->asce = atype | _ASCE_TABLE_LENGTH | @@ -181,25 +181,25 @@ static void gmap_rmap_radix_tree_free(struct radix_tree_root *root) */ static void gmap_free(struct gmap *gmap) { - struct page *page, *next; + struct ptdesc *ptdesc, *next; /* Flush tlb of all gmaps (if not already done for shadows) */ if (!(gmap_is_shadow(gmap) && gmap->removed)) gmap_flush_tlb(gmap); /* Free all segment & region tables. */ - list_for_each_entry_safe(page, next, &gmap->crst_list, lru) { - page->_pt_s390_gaddr = 0; - __free_pages(page, CRST_ALLOC_ORDER); + list_for_each_entry_safe(ptdesc, next, &gmap->crst_list, pt_list) { + ptdesc->_pt_s390_gaddr = 0; + ptdesc_free(ptdesc); } gmap_radix_tree_free(&gmap->guest_to_host); gmap_radix_tree_free(&gmap->host_to_guest); /* Free additional data for a shadow gmap */ if (gmap_is_shadow(gmap)) { - /* Free all page tables. */ - list_for_each_entry_safe(page, next, &gmap->pt_list, lru) { - page->_pt_s390_gaddr = 0; - page_table_free_pgste(page); + /* Free all ptdesc tables. */ + list_for_each_entry_safe(ptdesc, next, &gmap->pt_list, pt_list) { + ptdesc->_pt_s390_gaddr = 0; + page_table_free_pgste(ptdesc_page(ptdesc)); } gmap_rmap_radix_tree_free(&gmap->host_to_rmap); /* Release reference to the parent */ @@ -308,27 +308,27 @@ EXPORT_SYMBOL_GPL(gmap_get_enabled); static int gmap_alloc_table(struct gmap *gmap, unsigned long *table, unsigned long init, unsigned long gaddr) { - struct page *page; + struct ptdesc *ptdesc; unsigned long *new; /* since we dont free the gmap table until gmap_free we can unlock */ - page = alloc_pages(GFP_KERNEL_ACCOUNT, CRST_ALLOC_ORDER); - if (!page) + ptdesc = ptdesc_alloc(GFP_KERNEL_ACCOUNT, CRST_ALLOC_ORDER); + if (!ptdesc) return -ENOMEM; - new = page_to_virt(page); + new = ptdesc_to_virt(ptdesc); crst_table_init(new, init); spin_lock(&gmap->guest_table_lock); if (*table & _REGION_ENTRY_INVALID) { - list_add(&page->lru, &gmap->crst_list); + list_add(&ptdesc->pt_list, &gmap->crst_list); *table = __pa(new) | _REGION_ENTRY_LENGTH | (*table & _REGION_ENTRY_TYPE_MASK); - page->_pt_s390_gaddr = gaddr; - page = NULL; + ptdesc->_pt_s390_gaddr = gaddr; + ptdesc = NULL; } spin_unlock(&gmap->guest_table_lock); - if (page) { - page->_pt_s390_gaddr = 0; - __free_pages(page, CRST_ALLOC_ORDER); + if (ptdesc) { + ptdesc->_pt_s390_gaddr = 0; + ptdesc_free(ptdesc); } return 0; } @@ -341,15 +341,15 @@ static int gmap_alloc_table(struct gmap *gmap, unsigned long *table, */ static unsigned long __gmap_segment_gaddr(unsigned long *entry) { - struct page *page; + struct ptdesc *ptdesc; unsigned long offset, mask; offset = (unsigned long) entry / sizeof(unsigned long); offset = (offset & (PTRS_PER_PMD - 1)) * PMD_SIZE; mask = ~(PTRS_PER_PMD * sizeof(pmd_t) - 1); - page = virt_to_page((void *)((unsigned long) entry & mask)); + ptdesc = virt_to_ptdesc((void *)((unsigned long) entry & mask)); - return page->_pt_s390_gaddr + offset; + return ptdesc->_pt_s390_gaddr + offset; } /** @@ -1345,6 +1345,7 @@ static void gmap_unshadow_pgt(struct gmap *sg, unsigned long raddr) unsigned long *ste; phys_addr_t sto, pgt; struct page *page; + struct ptdesc *ptdesc; BUG_ON(!gmap_is_shadow(sg)); ste = gmap_table_walk(sg, raddr, 1); /* get segment pointer */ @@ -1358,9 +1359,11 @@ static void gmap_unshadow_pgt(struct gmap *sg, unsigned long raddr) __gmap_unshadow_pgt(sg, raddr, __va(pgt)); /* Free page table */ page = phys_to_page(pgt); - list_del(&page->lru); - page->_pt_s390_gaddr = 0; - page_table_free_pgste(page); + + ptdesc = page_ptdesc(page); + list_del(&ptdesc->pt_list); + ptdesc->_pt_s390_gaddr = 0; + page_table_free_pgste(ptdesc_page(ptdesc)); } /** @@ -1374,9 +1377,10 @@ static void gmap_unshadow_pgt(struct gmap *sg, unsigned long raddr) static void __gmap_unshadow_sgt(struct gmap *sg, unsigned long raddr, unsigned long *sgt) { - struct page *page; phys_addr_t pgt; int i; + struct page *page; + struct ptdesc *ptdesc; BUG_ON(!gmap_is_shadow(sg)); for (i = 0; i < _CRST_ENTRIES; i++, raddr += _SEGMENT_SIZE) { @@ -1387,9 +1391,11 @@ static void __gmap_unshadow_sgt(struct gmap *sg, unsigned long raddr, __gmap_unshadow_pgt(sg, raddr, __va(pgt)); /* Free page table */ page = phys_to_page(pgt); - list_del(&page->lru); - page->_pt_s390_gaddr = 0; - page_table_free_pgste(page); + + ptdesc = page_ptdesc(page); + list_del(&ptdesc->pt_list); + ptdesc->_pt_s390_gaddr = 0; + page_table_free_pgste(ptdesc_page(ptdesc)); } } @@ -1405,6 +1411,7 @@ static void gmap_unshadow_sgt(struct gmap *sg, unsigned long raddr) unsigned long r3o, *r3e; phys_addr_t sgt; struct page *page; + struct ptdesc *ptdesc; BUG_ON(!gmap_is_shadow(sg)); r3e = gmap_table_walk(sg, raddr, 2); /* get region-3 pointer */ @@ -1418,9 +1425,11 @@ static void gmap_unshadow_sgt(struct gmap *sg, unsigned long raddr) __gmap_unshadow_sgt(sg, raddr, __va(sgt)); /* Free segment table */ page = phys_to_page(sgt); - list_del(&page->lru); - page->_pt_s390_gaddr = 0; - __free_pages(page, CRST_ALLOC_ORDER); + + ptdesc = page_ptdesc(page); + list_del(&ptdesc->pt_list); + ptdesc->_pt_s390_gaddr = 0; + ptdesc_free(ptdesc); } /** @@ -1434,9 +1443,10 @@ static void gmap_unshadow_sgt(struct gmap *sg, unsigned long raddr) static void __gmap_unshadow_r3t(struct gmap *sg, unsigned long raddr, unsigned long *r3t) { - struct page *page; phys_addr_t sgt; int i; + struct page *page; + struct ptdesc *ptdesc; BUG_ON(!gmap_is_shadow(sg)); for (i = 0; i < _CRST_ENTRIES; i++, raddr += _REGION3_SIZE) { @@ -1447,9 +1457,11 @@ static void __gmap_unshadow_r3t(struct gmap *sg, unsigned long raddr, __gmap_unshadow_sgt(sg, raddr, __va(sgt)); /* Free segment table */ page = phys_to_page(sgt); - list_del(&page->lru); - page->_pt_s390_gaddr = 0; - __free_pages(page, CRST_ALLOC_ORDER); + + ptdesc = page_ptdesc(page); + list_del(&ptdesc->pt_list); + ptdesc->_pt_s390_gaddr = 0; + ptdesc_free(ptdesc); } } @@ -1465,6 +1477,7 @@ static void gmap_unshadow_r3t(struct gmap *sg, unsigned long raddr) unsigned long r2o, *r2e; phys_addr_t r3t; struct page *page; + struct ptdesc *ptdesc; BUG_ON(!gmap_is_shadow(sg)); r2e = gmap_table_walk(sg, raddr, 3); /* get region-2 pointer */ @@ -1478,9 +1491,11 @@ static void gmap_unshadow_r3t(struct gmap *sg, unsigned long raddr) __gmap_unshadow_r3t(sg, raddr, __va(r3t)); /* Free region 3 table */ page = phys_to_page(r3t); - list_del(&page->lru); - page->_pt_s390_gaddr = 0; - __free_pages(page, CRST_ALLOC_ORDER); + + ptdesc = page_ptdesc(page); + list_del(&ptdesc->pt_list); + ptdesc->_pt_s390_gaddr = 0; + ptdesc_free(ptdesc); } /** @@ -1495,8 +1510,9 @@ static void __gmap_unshadow_r2t(struct gmap *sg, unsigned long raddr, unsigned long *r2t) { phys_addr_t r3t; - struct page *page; int i; + struct page *page; + struct ptdesc *ptdesc; BUG_ON(!gmap_is_shadow(sg)); for (i = 0; i < _CRST_ENTRIES; i++, raddr += _REGION2_SIZE) { @@ -1507,9 +1523,11 @@ static void __gmap_unshadow_r2t(struct gmap *sg, unsigned long raddr, __gmap_unshadow_r3t(sg, raddr, __va(r3t)); /* Free region 3 table */ page = phys_to_page(r3t); - list_del(&page->lru); - page->_pt_s390_gaddr = 0; - __free_pages(page, CRST_ALLOC_ORDER); + + ptdesc = page_ptdesc(page); + list_del(&ptdesc->pt_list); + ptdesc->_pt_s390_gaddr = 0; + ptdesc_free(ptdesc); } } @@ -1525,6 +1543,7 @@ static void gmap_unshadow_r2t(struct gmap *sg, unsigned long raddr) unsigned long r1o, *r1e; struct page *page; phys_addr_t r2t; + struct ptdesc *ptdesc; BUG_ON(!gmap_is_shadow(sg)); r1e = gmap_table_walk(sg, raddr, 4); /* get region-1 pointer */ @@ -1538,9 +1557,11 @@ static void gmap_unshadow_r2t(struct gmap *sg, unsigned long raddr) __gmap_unshadow_r2t(sg, raddr, __va(r2t)); /* Free region 2 table */ page = phys_to_page(r2t); - list_del(&page->lru); - page->_pt_s390_gaddr = 0; - __free_pages(page, CRST_ALLOC_ORDER); + + ptdesc = page_ptdesc(page); + list_del(&ptdesc->pt_list); + ptdesc->_pt_s390_gaddr = 0; + ptdesc_free(ptdesc); } /** @@ -1558,6 +1579,7 @@ static void __gmap_unshadow_r1t(struct gmap *sg, unsigned long raddr, struct page *page; phys_addr_t r2t; int i; + struct ptdesc *ptdesc; BUG_ON(!gmap_is_shadow(sg)); asce = __pa(r1t) | _ASCE_TYPE_REGION1; @@ -1571,9 +1593,11 @@ static void __gmap_unshadow_r1t(struct gmap *sg, unsigned long raddr, r1t[i] = _REGION1_ENTRY_EMPTY; /* Free region 2 table */ page = phys_to_page(r2t); - list_del(&page->lru); - page->_pt_s390_gaddr = 0; - __free_pages(page, CRST_ALLOC_ORDER); + + ptdesc = page_ptdesc(page); + list_del(&ptdesc->pt_list); + ptdesc->_pt_s390_gaddr = 0; + ptdesc_free(ptdesc); } } @@ -1770,18 +1794,18 @@ int gmap_shadow_r2t(struct gmap *sg, unsigned long saddr, unsigned long r2t, unsigned long raddr, origin, offset, len; unsigned long *table; phys_addr_t s_r2t; - struct page *page; + struct ptdesc *ptdesc; int rc; BUG_ON(!gmap_is_shadow(sg)); /* Allocate a shadow region second table */ - page = alloc_pages(GFP_KERNEL_ACCOUNT, CRST_ALLOC_ORDER); - if (!page) + ptdesc = ptdesc_alloc(GFP_KERNEL_ACCOUNT, CRST_ALLOC_ORDER); + if (!ptdesc) return -ENOMEM; - page->_pt_s390_gaddr = r2t & _REGION_ENTRY_ORIGIN; + ptdesc->_pt_s390_gaddr = r2t & _REGION_ENTRY_ORIGIN; if (fake) - page->_pt_s390_gaddr |= GMAP_SHADOW_FAKE_TABLE; - s_r2t = page_to_phys(page); + ptdesc->_pt_s390_gaddr |= GMAP_SHADOW_FAKE_TABLE; + s_r2t = page_to_phys(ptdesc_page(ptdesc)); /* Install shadow region second table */ spin_lock(&sg->guest_table_lock); table = gmap_table_walk(sg, saddr, 4); /* get region-1 pointer */ @@ -1802,7 +1826,7 @@ int gmap_shadow_r2t(struct gmap *sg, unsigned long saddr, unsigned long r2t, _REGION_ENTRY_TYPE_R1 | _REGION_ENTRY_INVALID; if (sg->edat_level >= 1) *table |= (r2t & _REGION_ENTRY_PROTECT); - list_add(&page->lru, &sg->crst_list); + list_add(&ptdesc->pt_list, &sg->crst_list); if (fake) { /* nothing to protect for fake tables */ *table &= ~_REGION_ENTRY_INVALID; @@ -1830,8 +1854,8 @@ int gmap_shadow_r2t(struct gmap *sg, unsigned long saddr, unsigned long r2t, return rc; out_free: spin_unlock(&sg->guest_table_lock); - page->_pt_s390_gaddr = 0; - __free_pages(page, CRST_ALLOC_ORDER); + ptdesc->_pt_s390_gaddr = 0; + ptdesc_free(ptdesc); return rc; } EXPORT_SYMBOL_GPL(gmap_shadow_r2t); @@ -1855,18 +1879,18 @@ int gmap_shadow_r3t(struct gmap *sg, unsigned long saddr, unsigned long r3t, unsigned long raddr, origin, offset, len; unsigned long *table; phys_addr_t s_r3t; - struct page *page; + struct ptdesc *ptdesc; int rc; BUG_ON(!gmap_is_shadow(sg)); /* Allocate a shadow region second table */ - page = alloc_pages(GFP_KERNEL_ACCOUNT, CRST_ALLOC_ORDER); - if (!page) + ptdesc = ptdesc_alloc(GFP_KERNEL_ACCOUNT, CRST_ALLOC_ORDER); + if (!ptdesc) return -ENOMEM; - page->_pt_s390_gaddr = r3t & _REGION_ENTRY_ORIGIN; + ptdesc->_pt_s390_gaddr = r3t & _REGION_ENTRY_ORIGIN; if (fake) - page->_pt_s390_gaddr |= GMAP_SHADOW_FAKE_TABLE; - s_r3t = page_to_phys(page); + ptdesc->_pt_s390_gaddr |= GMAP_SHADOW_FAKE_TABLE; + s_r3t = page_to_phys(ptdesc_page(ptdesc)); /* Install shadow region second table */ spin_lock(&sg->guest_table_lock); table = gmap_table_walk(sg, saddr, 3); /* get region-2 pointer */ @@ -1887,7 +1911,7 @@ int gmap_shadow_r3t(struct gmap *sg, unsigned long saddr, unsigned long r3t, _REGION_ENTRY_TYPE_R2 | _REGION_ENTRY_INVALID; if (sg->edat_level >= 1) *table |= (r3t & _REGION_ENTRY_PROTECT); - list_add(&page->lru, &sg->crst_list); + list_add(&ptdesc->pt_list, &sg->crst_list); if (fake) { /* nothing to protect for fake tables */ *table &= ~_REGION_ENTRY_INVALID; @@ -1915,8 +1939,8 @@ int gmap_shadow_r3t(struct gmap *sg, unsigned long saddr, unsigned long r3t, return rc; out_free: spin_unlock(&sg->guest_table_lock); - page->_pt_s390_gaddr = 0; - __free_pages(page, CRST_ALLOC_ORDER); + ptdesc->_pt_s390_gaddr = 0; + ptdesc_free(ptdesc); return rc; } EXPORT_SYMBOL_GPL(gmap_shadow_r3t); @@ -1940,18 +1964,18 @@ int gmap_shadow_sgt(struct gmap *sg, unsigned long saddr, unsigned long sgt, unsigned long raddr, origin, offset, len; unsigned long *table; phys_addr_t s_sgt; - struct page *page; + struct ptdesc *ptdesc; int rc; BUG_ON(!gmap_is_shadow(sg) || (sgt & _REGION3_ENTRY_LARGE)); /* Allocate a shadow segment table */ - page = alloc_pages(GFP_KERNEL_ACCOUNT, CRST_ALLOC_ORDER); - if (!page) + ptdesc = ptdesc_alloc(GFP_KERNEL_ACCOUNT, CRST_ALLOC_ORDER); + if (!ptdesc) return -ENOMEM; - page->_pt_s390_gaddr = sgt & _REGION_ENTRY_ORIGIN; + ptdesc->_pt_s390_gaddr = sgt & _REGION_ENTRY_ORIGIN; if (fake) - page->_pt_s390_gaddr |= GMAP_SHADOW_FAKE_TABLE; - s_sgt = page_to_phys(page); + ptdesc->_pt_s390_gaddr |= GMAP_SHADOW_FAKE_TABLE; + s_sgt = page_to_phys(ptdesc_page(ptdesc)); /* Install shadow region second table */ spin_lock(&sg->guest_table_lock); table = gmap_table_walk(sg, saddr, 2); /* get region-3 pointer */ @@ -1972,7 +1996,7 @@ int gmap_shadow_sgt(struct gmap *sg, unsigned long saddr, unsigned long sgt, _REGION_ENTRY_TYPE_R3 | _REGION_ENTRY_INVALID; if (sg->edat_level >= 1) *table |= sgt & _REGION_ENTRY_PROTECT; - list_add(&page->lru, &sg->crst_list); + list_add(&ptdesc->pt_list, &sg->crst_list); if (fake) { /* nothing to protect for fake tables */ *table &= ~_REGION_ENTRY_INVALID; @@ -2000,8 +2024,8 @@ int gmap_shadow_sgt(struct gmap *sg, unsigned long saddr, unsigned long sgt, return rc; out_free: spin_unlock(&sg->guest_table_lock); - page->_pt_s390_gaddr = 0; - __free_pages(page, CRST_ALLOC_ORDER); + ptdesc->_pt_s390_gaddr = 0; + ptdesc_free(ptdesc); return rc; } EXPORT_SYMBOL_GPL(gmap_shadow_sgt); @@ -2024,8 +2048,9 @@ int gmap_shadow_pgt_lookup(struct gmap *sg, unsigned long saddr, int *fake) { unsigned long *table; - struct page *page; int rc; + struct page *page; + struct ptdesc *ptdesc; BUG_ON(!gmap_is_shadow(sg)); spin_lock(&sg->guest_table_lock); @@ -2033,9 +2058,10 @@ int gmap_shadow_pgt_lookup(struct gmap *sg, unsigned long saddr, if (table && !(*table & _SEGMENT_ENTRY_INVALID)) { /* Shadow page tables are full pages (pte+pgste) */ page = pfn_to_page(*table >> PAGE_SHIFT); - *pgt = page->_pt_s390_gaddr & ~GMAP_SHADOW_FAKE_TABLE; + ptdesc = page_ptdesc(page); + *pgt = ptdesc->_pt_s390_gaddr & ~GMAP_SHADOW_FAKE_TABLE; *dat_protection = !!(*table & _SEGMENT_ENTRY_PROTECT); - *fake = !!(page->_pt_s390_gaddr & GMAP_SHADOW_FAKE_TABLE); + *fake = !!(ptdesc->_pt_s390_gaddr & GMAP_SHADOW_FAKE_TABLE); rc = 0; } else { rc = -EAGAIN; @@ -2064,19 +2090,19 @@ int gmap_shadow_pgt(struct gmap *sg, unsigned long saddr, unsigned long pgt, { unsigned long raddr, origin; unsigned long *table; - struct page *page; + struct ptdesc *ptdesc; phys_addr_t s_pgt; int rc; BUG_ON(!gmap_is_shadow(sg) || (pgt & _SEGMENT_ENTRY_LARGE)); /* Allocate a shadow page table */ - page = page_table_alloc_pgste(sg->mm); - if (!page) + ptdesc = page_ptdesc(page_table_alloc_pgste(sg->mm)); + if (!ptdesc) return -ENOMEM; - page->_pt_s390_gaddr = pgt & _SEGMENT_ENTRY_ORIGIN; + ptdesc->_pt_s390_gaddr = pgt & _SEGMENT_ENTRY_ORIGIN; if (fake) - page->_pt_s390_gaddr |= GMAP_SHADOW_FAKE_TABLE; - s_pgt = page_to_phys(page); + ptdesc->_pt_s390_gaddr |= GMAP_SHADOW_FAKE_TABLE; + s_pgt = page_to_phys(ptdesc_page(ptdesc)); /* Install shadow page table */ spin_lock(&sg->guest_table_lock); table = gmap_table_walk(sg, saddr, 1); /* get segment pointer */ @@ -2094,7 +2120,7 @@ int gmap_shadow_pgt(struct gmap *sg, unsigned long saddr, unsigned long pgt, /* mark as invalid as long as the parent table is not protected */ *table = (unsigned long) s_pgt | _SEGMENT_ENTRY | (pgt & _SEGMENT_ENTRY_PROTECT) | _SEGMENT_ENTRY_INVALID; - list_add(&page->lru, &sg->pt_list); + list_add(&ptdesc->pt_list, &sg->pt_list); if (fake) { /* nothing to protect for fake tables */ *table &= ~_SEGMENT_ENTRY_INVALID; @@ -2120,8 +2146,8 @@ int gmap_shadow_pgt(struct gmap *sg, unsigned long saddr, unsigned long pgt, return rc; out_free: spin_unlock(&sg->guest_table_lock); - page->_pt_s390_gaddr = 0; - page_table_free_pgste(page); + ptdesc->_pt_s390_gaddr = 0; + page_table_free_pgste(ptdesc_page(ptdesc)); return rc; } @@ -2814,11 +2840,11 @@ EXPORT_SYMBOL_GPL(__s390_uv_destroy_range); */ void s390_unlist_old_asce(struct gmap *gmap) { - struct page *old; + struct ptdesc *old; - old = virt_to_page(gmap->table); + old = virt_to_ptdesc(gmap->table); spin_lock(&gmap->guest_table_lock); - list_del(&old->lru); + list_del(&old->pt_list); /* * Sometimes the topmost page might need to be "removed" multiple * times, for example if the VM is rebooted into secure mode several @@ -2833,7 +2859,7 @@ void s390_unlist_old_asce(struct gmap *gmap) * pointers, so list_del can work (and do nothing) without * dereferencing stale or invalid pointers. */ - INIT_LIST_HEAD(&old->lru); + INIT_LIST_HEAD(&old->pt_list); spin_unlock(&gmap->guest_table_lock); } EXPORT_SYMBOL_GPL(s390_unlist_old_asce); @@ -2851,15 +2877,15 @@ EXPORT_SYMBOL_GPL(s390_unlist_old_asce); int s390_replace_asce(struct gmap *gmap) { unsigned long asce; - struct page *page; + struct ptdesc *ptdesc; void *table; s390_unlist_old_asce(gmap); - page = alloc_pages(GFP_KERNEL_ACCOUNT, CRST_ALLOC_ORDER); - if (!page) + ptdesc = ptdesc_alloc(GFP_KERNEL_ACCOUNT, CRST_ALLOC_ORDER); + if (!ptdesc) return -ENOMEM; - table = page_to_virt(page); + table = ptdesc_to_virt(ptdesc); memcpy(table, gmap->table, 1UL << (CRST_ALLOC_ORDER + PAGE_SHIFT)); /* @@ -2868,7 +2894,7 @@ int s390_replace_asce(struct gmap *gmap) * it will be freed when the VM is torn down. */ spin_lock(&gmap->guest_table_lock); - list_add(&page->lru, &gmap->crst_list); + list_add(&ptdesc->pt_list, &gmap->crst_list); spin_unlock(&gmap->guest_table_lock); /* Set new table origin while preserving existing ASCE control bits */ -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:39:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:39:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528141.820991 (Exim 4.92) (envelope-from ) id 1ptZMa-00089n-JE; Mon, 01 May 2023 19:39:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528141.820991; Mon, 01 May 2023 19:39:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZMa-00089T-Dx; Mon, 01 May 2023 19:39:08 +0000 Received: by outflank-mailman (input) for mailman id 528141; Mon, 01 May 2023 19:39:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZDL-0006PY-Q6 for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:29:35 +0000 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [2607:f8b0:4864:20::635]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7ae1c1cf-e856-11ed-8611-37d641c3527e; Mon, 01 May 2023 21:29:24 +0200 (CEST) Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1aad5245632so16558095ad.3 for ; Mon, 01 May 2023 12:29:24 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.29.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:29:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7ae1c1cf-e856-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969364; x=1685561364; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tVP5uHyitpWmGyZGGmBmuGVwAuiqA5RrNeRETZrKFQk=; b=l3gNIC841LsuGqQQ2UpVF+XnHjZ+kiBXZeZy4GTzDMbWbXaEiG5ArSl/ydDvotE01/ fGJ2+A5T8Q0iCPtlIlo1cxl3Uf1AxNVghNXp2wCgxamPWRN0f7NM89uS/eqg02SKiRak np/AOUUvT9Iq32lA1ArHNRu1TUuWBGP97diP1cbyLES/I8a8uq904CtHM5VcyBKmIx8g ULh11nFUApu/c5GfuUXZpzFhh6lYLhMsU4hm7q2aFdXWAxNpZKe/ScDOD1gC9EPME0aI 4wA9wQgJ9NzOXeiB1g9JMqcyyqFI/8Wvj0CTUQfo5zcTDuOrG/ytNAkFcETgxxSn2sbl hW5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969364; x=1685561364; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tVP5uHyitpWmGyZGGmBmuGVwAuiqA5RrNeRETZrKFQk=; b=a1EpmSRxzkAtGNwNr9tSZfplIvuedRQ4tUUA02wQwbVRYlA+vSsP+VAHKvqgCzvSjO 5+b1XfA8aZplzPmn6s5WqyQxFv17r9ZkqXwPvt88pPXMfnXapYXM/72QFE29LyTJADtS 7zvFvyl6mdhHj8VnwNf9fFUnu+FBvLeLplzEy/ltWWwY11qHZPOzhsRNqEDcsN8Ji1Jc Hhe7m8H/WDUyiPp9WnRu+GjItHWVe54ZNXSNZBAFt292WjjcZmWd06PVifksCk/L56lk tWAGmcKaRl1VXKcw8gkpKeVSsYxhci2WL6HQD480ctY0GbDGfaHqEgv9kpxoZCj4POcL SvCQ== X-Gm-Message-State: AC+VfDxZgJT/Fl861g0Ucj82a+yoKSHrcVNMu+pxJsZLRvadz1F7Gq7k 7HDuCOXwcat8SQ8BzBjLHXo= X-Google-Smtp-Source: ACHHUZ4QjkMy1fp/+Rin9A48k0WWuHM3fOzsdnkuixAb5bcQScYzyO713qNNM5COHanOuLDMosv4jg== X-Received: by 2002:a17:902:db07:b0:1aa:f203:781c with SMTP id m7-20020a170902db0700b001aaf203781cmr5844122plx.44.1682969363711; Mon, 01 May 2023 12:29:23 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" Subject: [PATCH v2 34/34] mm: Remove pgtable_{pmd, pte}_page_{ctor, dtor}() wrappers Date: Mon, 1 May 2023 12:28:29 -0700 Message-Id: <20230501192829.17086-35-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit These functions are no longer necessary. Remove them and cleanup Documentation referencing them. Signed-off-by: Vishal Moola (Oracle) --- Documentation/mm/split_page_table_lock.rst | 12 +++++------ .../zh_CN/mm/split_page_table_lock.rst | 14 ++++++------- include/linux/mm.h | 20 ------------------- 3 files changed, 13 insertions(+), 33 deletions(-) diff --git a/Documentation/mm/split_page_table_lock.rst b/Documentation/mm/split_page_table_lock.rst index 50ee0dfc95be..b3c612183135 100644 --- a/Documentation/mm/split_page_table_lock.rst +++ b/Documentation/mm/split_page_table_lock.rst @@ -53,7 +53,7 @@ Support of split page table lock by an architecture =================================================== There's no need in special enabling of PTE split page table lock: everything -required is done by pgtable_pte_page_ctor() and pgtable_pte_page_dtor(), which +required is done by ptdesc_pte_ctor() and ptdesc_pte_dtor(), which must be called on PTE table allocation / freeing. Make sure the architecture doesn't use slab allocator for page table @@ -63,8 +63,8 @@ This field shares storage with page->ptl. PMD split lock only makes sense if you have more than two page table levels. -PMD split lock enabling requires pgtable_pmd_page_ctor() call on PMD table -allocation and pgtable_pmd_page_dtor() on freeing. +PMD split lock enabling requires ptdesc_pmd_ctor() call on PMD table +allocation and ptdesc_pmd_dtor() on freeing. Allocation usually happens in pmd_alloc_one(), freeing in pmd_free() and pmd_free_tlb(), but make sure you cover all PMD table allocation / freeing @@ -72,7 +72,7 @@ paths: i.e X86_PAE preallocate few PMDs on pgd_alloc(). With everything in place you can set CONFIG_ARCH_ENABLE_SPLIT_PMD_PTLOCK. -NOTE: pgtable_pte_page_ctor() and pgtable_pmd_page_ctor() can fail -- it must +NOTE: ptdesc_pte_ctor() and ptdesc_pmd_ctor() can fail -- it must be handled properly. page->ptl @@ -92,7 +92,7 @@ trick: split lock with enabled DEBUG_SPINLOCK or DEBUG_LOCK_ALLOC, but costs one more cache line for indirect access; -The spinlock_t allocated in pgtable_pte_page_ctor() for PTE table and in -pgtable_pmd_page_ctor() for PMD table. +The spinlock_t allocated in ptdesc_pte_ctor() for PTE table and in +ptdesc_pmd_ctor() for PMD table. Please, never access page->ptl directly -- use appropriate helper. diff --git a/Documentation/translations/zh_CN/mm/split_page_table_lock.rst b/Documentation/translations/zh_CN/mm/split_page_table_lock.rst index 4fb7aa666037..a3323eb9dc40 100644 --- a/Documentation/translations/zh_CN/mm/split_page_table_lock.rst +++ b/Documentation/translations/zh_CN/mm/split_page_table_lock.rst @@ -56,16 +56,16 @@ Hugetlb特定的辅助函数: 架构对分页表锁的支持 ==================== -没有必要特别启用PTE分页表锁：所有需要的东西都由pgtable_pte_page_ctor() -和pgtable_pte_page_dtor()完成，它们必须在PTE表分配/释放时被调用。 +没有必要特别启用PTE分页表锁：所有需要的东西都由ptdesc_pte_ctor() +和ptdesc_pte_dtor()完成，它们必须在PTE表分配/释放时被调用。 确保架构不使用slab分配器来分配页表：slab使用page->slab_cache来分配其页 面。这个区域与page->ptl共享存储。 PMD分页锁只有在你有两个以上的页表级别时才有意义。 -启用PMD分页锁需要在PMD表分配时调用pgtable_pmd_page_ctor()，在释放时调 -用pgtable_pmd_page_dtor()。 +启用PMD分页锁需要在PMD表分配时调用ptdesc_pmd_ctor()，在释放时调 +用ptdesc_pmd_dtor()。 分配通常发生在pmd_alloc_one()中，释放发生在pmd_free()和pmd_free_tlb() 中，但要确保覆盖所有的PMD表分配/释放路径：即X86_PAE在pgd_alloc()中预先 @@ -73,7 +73,7 @@ PMD分页锁只有在你有两个以上的页表级别时才有意义。 一切就绪后，你可以设置CONFIG_ARCH_ENABLE_SPLIT_PMD_PTLOCK。 -注意：pgtable_pte_page_ctor()和pgtable_pmd_page_ctor()可能失败--必 +注意：ptdesc_pte_ctor()和ptdesc_pmd_ctor()可能失败--必 须正确处理。 page->ptl @@ -90,7 +90,7 @@ page->ptl用于访问分割页表锁，其中'page'是包含该表的页面struc 的指针并动态分配它。这允许在启用DEBUG_SPINLOCK或DEBUG_LOCK_ALLOC的 情况下使用分页锁，但由于间接访问而多花了一个缓存行。 -PTE表的spinlock_t分配在pgtable_pte_page_ctor()中，PMD表的spinlock_t -分配在pgtable_pmd_page_ctor()中。 +PTE表的spinlock_t分配在ptdesc_pte_ctor()中，PMD表的spinlock_t +分配在ptdesc_pmd_ctor()中。 请不要直接访问page->ptl - -使用适当的辅助函数。 diff --git a/include/linux/mm.h b/include/linux/mm.h index dc61aeca9077..dfa3e202099a 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2858,11 +2858,6 @@ static inline bool ptdesc_pte_ctor(struct ptdesc *ptdesc) return true; } -static inline bool pgtable_pte_page_ctor(struct page *page) -{ - return ptdesc_pte_ctor(page_ptdesc(page)); -} - static inline void ptdesc_pte_dtor(struct ptdesc *ptdesc) { struct folio *folio = ptdesc_folio(ptdesc); @@ -2872,11 +2867,6 @@ static inline void ptdesc_pte_dtor(struct ptdesc *ptdesc) lruvec_stat_sub_folio(folio, NR_PAGETABLE); } -static inline void pgtable_pte_page_dtor(struct page *page) -{ - ptdesc_pte_dtor(page_ptdesc(page)); -} - #define pte_offset_map_lock(mm, pmd, address, ptlp) \ ({ \ spinlock_t *__ptl = pte_lockptr(mm, pmd); \ @@ -2967,11 +2957,6 @@ static inline bool ptdesc_pmd_ctor(struct ptdesc *ptdesc) return true; } -static inline bool pgtable_pmd_page_ctor(struct page *page) -{ - return ptdesc_pmd_ctor(page_ptdesc(page)); -} - static inline void ptdesc_pmd_dtor(struct ptdesc *ptdesc) { struct folio *folio = ptdesc_folio(ptdesc); @@ -2981,11 +2966,6 @@ static inline void ptdesc_pmd_dtor(struct ptdesc *ptdesc) lruvec_stat_sub_folio(folio, NR_PAGETABLE); } -static inline void pgtable_pmd_page_dtor(struct page *page) -{ - ptdesc_pmd_dtor(page_ptdesc(page)); -} - /* * No scalability reason to split PUD locks yet, but follow the same pattern * as the PMD locks to make it easier if we decide to. The VM should not be -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:39:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:39:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528144.820999 (Exim 4.92) (envelope-from ) id 1ptZMb-0008L6-4Z; Mon, 01 May 2023 19:39:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528144.820999; Mon, 01 May 2023 19:39:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZMa-0008Jy-W8; Mon, 01 May 2023 19:39:08 +0000 Received: by outflank-mailman (input) for mailman id 528144; Mon, 01 May 2023 19:39:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCz-0006PY-Nh for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:29:13 +0000 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [2607:f8b0:4864:20::630]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 70f6f602-e856-11ed-8611-37d641c3527e; Mon, 01 May 2023 21:29:08 +0200 (CEST) Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-1ab01bf474aso6107295ad.1 for ; Mon, 01 May 2023 12:29:08 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.29.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:29:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 70f6f602-e856-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969347; x=1685561347; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=apg836Gn0N7QExyyhUUGNgc2fd2r3iyoAghRwsUjc2o=; b=WbTJO1ayjn3HXL/iQMZCmT2+RnFSF2O5WG+VKbNfOxDU8NvbfSgz+Wjs4UVgNNQcMr uLj57ayYRa/f+rOhAVP0jHM/2f33b+TbcsUuT8OausfFIQuWjGI50HrH5E0KiKkIgQwa 0uM85OALkALC3dGk5nJ/tYYANgKg4uu8cRvFIwQEiY4YzwHIJvVidPyhHtwxmNKQYA0W tAWz4vl42KgoRYKzs8w7tUocWedsU0Shw+kefBEmySvrYYB7bH8pThcvpYZ6Dpmw316z icjhKqrruYJxczjDCcNsGgrwDrViIcKW8h7/U3ESAg45ipYAB08luKD04Ylpo9b00Q6j cFOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969347; x=1685561347; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=apg836Gn0N7QExyyhUUGNgc2fd2r3iyoAghRwsUjc2o=; b=BsN4KJFQnQgvdpxeGHifI4nYxUqKcgCYB+C3akbEzi9E/HJGpEpk8Rjm4sIM6FFVyT LnUD1X1I8pBM5NQeo4YDDP3DXk8mRBjRtMTID0kYDTZZPGqbTrBHMzF9sYDWgcArrE7F JGT20/NZc9dBHbTnuObriv6KrDEV3Y3CKYFlI4ttVNHMeRLChV/ve5Hxl6Dt8Up/JtSN wHFBcHH0kwCWAOGzAGvhgfqy/X3Ba/oq7oVF8dnfFdeFO62AJ/T4Vq4P253baN3S2LI7 5Uv4SQBKH9QFat+XIgOJgjqHRlCI8AZaoONxaiCD9FA2+XCicYgUYtgmEpT0xY137g5S l/GQ== X-Gm-Message-State: AC+VfDw90YHZHVbe3X4kmLf3QWuT53JG298vChN/pZewv2sWPj8sKwhc HWqVV6KpQTdUMH7XhveDfcQ= X-Google-Smtp-Source: ACHHUZ6JhHSCQpD21/kJ78iavglhPlPTqvuf+3JEce/L0R67tH5klQ2MwjR0kPXU/JMC0Y1BeGjoZA== X-Received: by 2002:a17:902:c94b:b0:1a8:626:6d9d with SMTP id i11-20020a170902c94b00b001a806266d9dmr19271440pla.62.1682969347146; Mon, 01 May 2023 12:29:07 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" Subject: [PATCH v2 23/34] hexagon: Convert __pte_free_tlb() to use ptdescs Date: Mon, 1 May 2023 12:28:18 -0700 Message-Id: <20230501192829.17086-24-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Signed-off-by: Vishal Moola (Oracle) --- arch/hexagon/include/asm/pgalloc.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/hexagon/include/asm/pgalloc.h b/arch/hexagon/include/asm/pgalloc.h index f0c47e6a7427..0f8432430e68 100644 --- a/arch/hexagon/include/asm/pgalloc.h +++ b/arch/hexagon/include/asm/pgalloc.h @@ -87,10 +87,10 @@ static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, max_kernel_seg = pmdindex; } -#define __pte_free_tlb(tlb, pte, addr) \ -do { \ - pgtable_pte_page_dtor((pte)); \ - tlb_remove_page((tlb), (pte)); \ +#define __pte_free_tlb(tlb, pte, addr) \ +do { \ + ptdesc_pte_dtor((page_ptdesc(pte))); \ + tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); \ } while (0) #endif -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:39:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:39:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528145.821017 (Exim 4.92) (envelope-from ) id 1ptZMl-0000ij-CV; Mon, 01 May 2023 19:39:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528145.821017; Mon, 01 May 2023 19:39:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZMl-0000iY-8B; Mon, 01 May 2023 19:39:19 +0000 Received: by outflank-mailman (input) for mailman id 528145; Mon, 01 May 2023 19:39:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZF1-0000m4-81 for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:31:19 +0000 Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [2607:f8b0:4864:20::732]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id be9f0d3b-e856-11ed-b225-6b7b168915f2; Mon, 01 May 2023 21:31:18 +0200 (CEST) Received: by mail-qk1-x732.google.com with SMTP id af79cd13be357-75131c2997bso1451854885a.1 for ; Mon, 01 May 2023 12:31:18 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id d6-20020ac80606000000b003bf9f9f1844sm9351784qth.71.2023.05.01.12.31.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:31:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be9f0d3b-e856-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969477; x=1685561477; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Bnmwx4JL4zzfpoAgNv41/x6mI5Sl5Tvy0no2deSD0O4=; b=CbOoWqTSk3uKbjzelG8yqnld5byWglvqESK7A5ayA7t7shLwdOeyy9pYr2h0dHZ4sw Ioebaoj5c+mUhs5R428HbAlgESy36wct7HvPU+oF2sighIIgNW2S/bMhrwz2G2bU7eAR PzmvfvNi5zQlFQbN2MU0tjZW9ZGQ2YrqYPpfUK353KT9AyIsPVIIWXUt0bf5KdeuKy4r 7ttyjdCx983mA5YglTw1av0sK693taU4SPfn7jm3Xk/tPYsgPA/bWeAXUDACZE5DCRsI HPGPu/bDWsw9EvYxBiodD1s8ObxO8fmcp+DI9gRq0PdosiMcfYJh0fkyFQCSwdkoHQTx BOCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969477; x=1685561477; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Bnmwx4JL4zzfpoAgNv41/x6mI5Sl5Tvy0no2deSD0O4=; b=OQI8i/AibKzefLly3forRo3Vn51hGG72o0vOyamOejU3/TDG5XhHc/VckUYbFj6Bxv v8uxi9H0XekL3O/e6pp31yt9jUCNMTUfHrFrFSr0HjLtCJTMkphOD3KYegnLjsd/XkOL Cjz5nBe+yZb7BFLKEYugoUkhXIKNqpuMJR2qgrIPUdWBhbIVZV0sjN1X6zadsi21a8p0 ffbfONklGA45eTuerewA3aylN8sENt2PdwN/vsvdOCjsrTFcU+rU0ID4Q2l/zIGy4RkI rj8z37aEQXLYAiVr1Ljg5aoZ61XxrH/mpf3z0a5PSyexZ78aepW28FmtqeOFAFUwIubi t2ig== X-Gm-Message-State: AC+VfDwQjYN7BdUfKRbPznmeI2FGNy7z7uN618QopAZwL/Rwe7Qiy5Bc 5RK/Xg1qig/bZkFkPFO3DlAosfsSEks= X-Google-Smtp-Source: ACHHUZ7BLXGnIebUIbZnncmPO+ryFBqQfenJ7JOTBDj0u5O37zFK/qjVSkLkOTcSG87sWV42QOYX7Q== X-Received: by 2002:ac8:4e4c:0:b0:3d4:17dc:3fcf with SMTP id e12-20020ac84e4c000000b003d417dc3fcfmr27298811qtw.5.1682969477226; Mon, 01 May 2023 12:31:17 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Wei Liu , Anthony PERARD Subject: [PATCH v3 12/14 RESEND] xenpm: Factor out a non-fatal cpuid_parse variant Date: Mon, 1 May 2023 15:30:32 -0400 Message-Id: <20230501193034.88575-13-jandryuk@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230501193034.88575-1-jandryuk@gmail.com> References: <20230501193034.88575-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Allow cpuid_parse to be re-used without terminating xenpm. HWP will re-use it to optionally parse a cpuid. Unlike other uses of cpuid_parse, parse_hwp_opts will take a variable number of arguments and cannot just check argc. Signed-off-by: Jason Andryuk --- v2: Retained because cpuid_parse handles numeric cpu numbers and "all". --- tools/misc/xenpm.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/tools/misc/xenpm.c b/tools/misc/xenpm.c index b2defde0d4..6e74606970 100644 --- a/tools/misc/xenpm.c +++ b/tools/misc/xenpm.c @@ -79,17 +79,26 @@ void help_func(int argc, char *argv[]) show_help(); } -static void parse_cpuid(const char *arg, int *cpuid) +static int parse_cpuid_non_fatal(const char *arg, int *cpuid) { if ( sscanf(arg, "%d", cpuid) != 1 || *cpuid < 0 ) { if ( strcasecmp(arg, "all") ) - { - fprintf(stderr, "Invalid CPU identifier: '%s'\n", arg); - exit(EINVAL); - } + return -1; + *cpuid = -1; } + + return 0; +} + +static void parse_cpuid(const char *arg, int *cpuid) +{ + if ( parse_cpuid_non_fatal(arg, cpuid) ) + { + fprintf(stderr, "Invalid CPU identifier: '%s'\n", arg); + exit(EINVAL); + } } static void parse_cpuid_and_int(int argc, char *argv[], -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:39:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:39:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528147.821027 (Exim 4.92) (envelope-from ) id 1ptZMo-0001KK-Nh; Mon, 01 May 2023 19:39:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528147.821027; Mon, 01 May 2023 19:39:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZMo-0001K4-Ht; Mon, 01 May 2023 19:39:22 +0000 Received: by outflank-mailman (input) for mailman id 528147; Mon, 01 May 2023 19:39:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCr-0006FS-G0 for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:29:05 +0000 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [2607:f8b0:4864:20::633]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6f497be2-e856-11ed-b225-6b7b168915f2; Mon, 01 May 2023 21:29:05 +0200 (CEST) Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1aaec6f189cso12398745ad.3 for ; Mon, 01 May 2023 12:29:04 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.29.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:29:04 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f497be2-e856-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969344; x=1685561344; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oJJ/5JNaAhhn0BtCWyESRHZW29NfaaBB7RT6Dtpfjog=; b=dujVT07hfeADlXP8VLeHzHZos19FRJjW/aMFZqcOyBAO37TIyuOPUD4cjiEOtYecqR Tiwbs3Jgtkq4Kww3BZLsfUeYGH01HRped6BHBhotJFQfLn1orwI/QFojUqd07/woILZm IdwKD4oQO46zQ5FUSiD0ClypRdGvF7AHFnh12n9hs1VGHXuzfiiaf8+D2bQL3TQLnlID aypLmgidYgZS67oc/+3avE+c7doqeOxXcTi5kAqysB/3bLqLAcTPHmeArfdREDSIi+5K 85L7sVL9riiLJDbWejHR83t0dYjCRXFIJ1/0gZmctdGxqkiAMg4Ak+2alOu75j8lTMAw rYkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969344; x=1685561344; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oJJ/5JNaAhhn0BtCWyESRHZW29NfaaBB7RT6Dtpfjog=; b=R+RhZb0vFRSt4YtjISBkUGwPCbBgRzL0FBJIDWUBVxJGuVLP7TH6W3Q030fUEgPTp6 xDJpeLlr+6rO64nLZJkUuoBdvsj/IQ3VG7AjQ2FNp5gJi8g/AZ5Q8NsEzaUa7NW+sbFV rASAMDWNx9FgGqIx6mgyV/cJJAv/S9w2dLkIJKKXOl5aPa/edOLIyRd7W0K7bYK7Umkr XrzKkOXTQWWpzLYLQD7gzkq4US16H0WZQrJKeotniURb7tF/U8507EKd8lNCUkqZ10PM FFoKAsBgRTtGYJpwDz1njCFTP6i9GS+07MmMBFy6NsyphuqManDOiHz69C8mb7rNPAzA gSIw== X-Gm-Message-State: AC+VfDxydXdzRTR7fqKakz322VeQbMsOkfp5UCjZS+sG6sKt5K6buCpm xkkTtqN/LDBejlNQgFfqi+Y= X-Google-Smtp-Source: ACHHUZ4ZEnjwtlgm3inm4fu27SXTrMWZSABNUt55ss8dOEDonQf7mUoqMAdyKodh48zsDDd3raB2eg== X-Received: by 2002:a17:902:f68b:b0:1a9:2e3d:fca2 with SMTP id l11-20020a170902f68b00b001a92e3dfca2mr18382952plg.33.1682969344394; Mon, 01 May 2023 12:29:04 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" , Catalin Marinas Subject: [PATCH v2 21/34] arm64: Convert various functions to use ptdescs Date: Mon, 1 May 2023 12:28:16 -0700 Message-Id: <20230501192829.17086-22-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Signed-off-by: Vishal Moola (Oracle) --- arch/arm64/include/asm/tlb.h | 14 ++++++++------ arch/arm64/mm/mmu.c | 7 ++++--- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/arch/arm64/include/asm/tlb.h b/arch/arm64/include/asm/tlb.h index c995d1f4594f..6cb70c247e30 100644 --- a/arch/arm64/include/asm/tlb.h +++ b/arch/arm64/include/asm/tlb.h @@ -75,18 +75,20 @@ static inline void tlb_flush(struct mmu_gather *tlb) static inline void __pte_free_tlb(struct mmu_gather *tlb, pgtable_t pte, unsigned long addr) { - pgtable_pte_page_dtor(pte); - tlb_remove_table(tlb, pte); + struct ptdesc *ptdesc = page_ptdesc(pte); + + ptdesc_pte_dtor(ptdesc); + tlb_remove_ptdesc(tlb, ptdesc); } #if CONFIG_PGTABLE_LEVELS > 2 static inline void __pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmdp, unsigned long addr) { - struct page *page = virt_to_page(pmdp); + struct ptdesc *ptdesc = virt_to_ptdesc(pmdp); - pgtable_pmd_page_dtor(page); - tlb_remove_table(tlb, page); + ptdesc_pmd_dtor(ptdesc); + tlb_remove_ptdesc(tlb, ptdesc); } #endif @@ -94,7 +96,7 @@ static inline void __pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmdp, static inline void __pud_free_tlb(struct mmu_gather *tlb, pud_t *pudp, unsigned long addr) { - tlb_remove_table(tlb, virt_to_page(pudp)); + tlb_remove_ptdesc(tlb, virt_to_ptdesc(pudp)); } #endif diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c index af6bc8403ee4..5ba005fd607e 100644 --- a/arch/arm64/mm/mmu.c +++ b/arch/arm64/mm/mmu.c @@ -426,6 +426,7 @@ static phys_addr_t __pgd_pgtable_alloc(int shift) static phys_addr_t pgd_pgtable_alloc(int shift) { phys_addr_t pa = __pgd_pgtable_alloc(shift); + struct ptdesc *ptdesc = page_ptdesc(phys_to_page(pa)); /* * Call proper page table ctor in case later we need to @@ -433,12 +434,12 @@ static phys_addr_t pgd_pgtable_alloc(int shift) * this pre-allocated page table. * * We don't select ARCH_ENABLE_SPLIT_PMD_PTLOCK if pmd is - * folded, and if so pgtable_pmd_page_ctor() becomes nop. + * folded, and if so ptdesc_pte_dtor() becomes nop. */ if (shift == PAGE_SHIFT) - BUG_ON(!pgtable_pte_page_ctor(phys_to_page(pa))); + BUG_ON(!ptdesc_pte_dtor(ptdesc)); else if (shift == PMD_SHIFT) - BUG_ON(!pgtable_pmd_page_ctor(phys_to_page(pa))); + BUG_ON(!ptdesc_pte_dtor(ptdesc)); return pa; } -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:39:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:39:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528151.821037 (Exim 4.92) (envelope-from ) id 1ptZMs-0001oL-V6; Mon, 01 May 2023 19:39:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528151.821037; Mon, 01 May 2023 19:39:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZMs-0001o9-RD; Mon, 01 May 2023 19:39:26 +0000 Received: by outflank-mailman (input) for mailman id 528151; Mon, 01 May 2023 19:39:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZD1-0006FS-LH for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:29:15 +0000 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [2607:f8b0:4864:20::636]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 74c83574-e856-11ed-b225-6b7b168915f2; Mon, 01 May 2023 21:29:14 +0200 (CEST) Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1aaf91ae451so11836335ad.1 for ; Mon, 01 May 2023 12:29:14 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.29.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:29:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 74c83574-e856-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969354; x=1685561354; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tniPUuVL526Jec1TVIaHRLAUx7OruO8jRIKlA5wqt8Q=; b=sCYdFD4O8Had2jReQPDULWIb6jXMWTBVOP1xIsSQDJFrjK4Unzq4xPir2vv9xD60ba KhnmERHxh4wjne9PTfzHFe7mUKtGQVGSRxsSTI7oGHQc7fKexIRwy4BhAuhQWGLGw+L4 jhaBOvefDEjvTltxe1zcg9AOJCenWnwtbQvW8h9UKrmrEmLrYzROLydP0XMIyNyplCDF ksvZ9Q2L1rfMSznCSwk+WHikKvzxa7zVAjndA+MUieyvTGKh0Hnkx2VWar6ZLI/SEpj3 zJ2Emm1btVtqn0B7TpGayRWt9h4mLeUHtWruxn5Hxr1lyas/Ibpq/YOzX0vO1bUnoNNT ju/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969354; x=1685561354; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tniPUuVL526Jec1TVIaHRLAUx7OruO8jRIKlA5wqt8Q=; b=YfoqjohuJkwH/jk3dm0c34FzWmudsx602spF/NN/rcr7AS/1vkCitNDdxcpxwGOmJj OT9GG5Iip9tk3YfYP2XomWqI//HJTm7LcAxzJcSIOQXEs2h5dXWxh99xSbOr+RFxDmcQ 6z7EfHpIHbggm2Gcjzpd7LkOWI405GS+1zQ4LdhCV6oRA5fDMczWagnMJQhJRJqT6NlY kK47FPt2ayFfQegSXhIr6wU5gNrNIvGtH4uuquQQi4Y/JsV6I5xtKdgbhUZcueXWQ2an ygFXii0G3F1QceYVqF5mp+Y/z5TBaA1KTxeGj7SuvfD/eZCv+80BY0YIVHv6pR4Dnu6I E4gA== X-Gm-Message-State: AC+VfDxeLjT15jXz6A42hvx2aLIXyJwcfSG51uPXdCOyug76Tcs7EFh5 90sMuSqwJGBZt+jf9k/xCbQ= X-Google-Smtp-Source: ACHHUZ6fkDxKllaaORZgzXEjR5COvh0uqYIPMfHZHm801Tjdn3OT0QOppKb8hXtDeBwjumbd6cc2Pw== X-Received: by 2002:a17:902:c411:b0:19c:d309:4612 with SMTP id k17-20020a170902c41100b0019cd3094612mr20785827plk.6.1682969353666; Mon, 01 May 2023 12:29:13 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" , Dinh Nguyen Subject: [PATCH v2 27/34] nios2: Convert __pte_free_tlb() to use ptdescs Date: Mon, 1 May 2023 12:28:22 -0700 Message-Id: <20230501192829.17086-28-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Signed-off-by: Vishal Moola (Oracle) --- arch/nios2/include/asm/pgalloc.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/nios2/include/asm/pgalloc.h b/arch/nios2/include/asm/pgalloc.h index ecd1657bb2ce..ed868f4c0ca9 100644 --- a/arch/nios2/include/asm/pgalloc.h +++ b/arch/nios2/include/asm/pgalloc.h @@ -28,10 +28,10 @@ static inline void pmd_populate(struct mm_struct *mm, pmd_t *pmd, extern pgd_t *pgd_alloc(struct mm_struct *mm); -#define __pte_free_tlb(tlb, pte, addr) \ - do { \ - pgtable_pte_page_dtor(pte); \ - tlb_remove_page((tlb), (pte)); \ +#define __pte_free_tlb(tlb, pte, addr) \ + do { \ + ptdesc_pte_dtor(page_ptdesc(pte)); \ + tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); \ } while (0) #endif /* _ASM_NIOS2_PGALLOC_H */ -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:39:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:39:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528152.821040 (Exim 4.92) (envelope-from ) id 1ptZMt-0001qn-8V; Mon, 01 May 2023 19:39:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528152.821040; Mon, 01 May 2023 19:39:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZMt-0001qN-54; Mon, 01 May 2023 19:39:27 +0000 Received: by outflank-mailman (input) for mailman id 528152; Mon, 01 May 2023 19:39:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCs-0006PY-NB for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:29:06 +0000 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [2607:f8b0:4864:20::630]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6e774797-e856-11ed-8611-37d641c3527e; Mon, 01 May 2023 21:29:04 +0200 (CEST) Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-1aae5c2423dso20954225ad.3 for ; Mon, 01 May 2023 12:29:04 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.29.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:29:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e774797-e856-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969343; x=1685561343; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gfpIRfFq9zSU9T7uNfhlcYr/W6dIxhZkZgP28wF3SDA=; b=Qau1TBSyVipNmef8PNT07M/JoK5y55d5cqgZDlN4vhhP79tr9yaRETSYXvwSfxkzpQ 1wzTUy/T5LzAEZJEeUbvFZuE+VickGgRQkGj6paYz1jDOFsUn9ZCDLvNYYI/Zyr2RUmg bm3l9m5jLCH0toRw7+aEb6gYmXflBLWLMpuQeA0OVXisZ1A5osNX02KzemiZmkdGT+6d H7+k3mn0V3HtUXPo/S8coTYf23tz7uGdOWK0nFPfjqqe58njMrJom/cuk3n4mMysX8dy jTZaIlbFQNlLjrIuXwQgtdhVp6dM9pTxTSdYHIHgZYka1AJxhJpIcTRf9fC09oM2h4fK Ax0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969343; x=1685561343; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gfpIRfFq9zSU9T7uNfhlcYr/W6dIxhZkZgP28wF3SDA=; b=kHUc4Hj2Dhsbn2oMdm/AQm20tiMvonMm8unQZzyrbrKlhdAYbTk5im9wlkAdE6N5sS HU6sXg37mwT2AwCXHrG3QTso91us/ih2aEF+yozLfDluEcNY7ZGDA6fzk9OaAX6RFBIx fBR5DHjW3bODdXyB63rIEScNAho95MaVmGeh2/lhpWeWMEH1c1iI91PKwqJ+yPHvfT0T A+PySmSpmEAIi53KEDXjbQwiFaz9ZTtMPZotRuHpaHqsHY4P2KCSTpCX2niDepiAy9mn KD/daGp7ghr5yjq6EKEcNSzj06W6Gfs8TLN1Ah5dVbnp5aiWWvBU1aORvwurELCTi8nk aH1A== X-Gm-Message-State: AC+VfDxEbUVQVfTm7HSFzMv9UfBOB5CTnWCl1giBurkgBDNVTZ0jHvfg u0vYiL9fZmZ1WKhpzm56ZUY= X-Google-Smtp-Source: ACHHUZ7gDAee3JEsjrpH2Z6atN7OAzqWZ2l6e0m4gqF7AbuDA0ihHMvj1UGUNCCunfz91CTNrFO0iw== X-Received: by 2002:a17:902:e547:b0:1ab:8f4:af3a with SMTP id n7-20020a170902e54700b001ab08f4af3amr217267plf.39.1682969342957; Mon, 01 May 2023 12:29:02 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" , Catalin Marinas Subject: [PATCH v2 20/34] arm: Convert various functions to use ptdescs Date: Mon, 1 May 2023 12:28:15 -0700 Message-Id: <20230501192829.17086-21-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. late_alloc() also uses the __get_free_pages() helper function. Convert this to use ptdesc_alloc() and ptdesc_address() instead to help standardize page tables further. Signed-off-by: Vishal Moola (Oracle) --- arch/arm/include/asm/tlb.h | 12 +++++++----- arch/arm/mm/mmu.c | 6 +++--- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/arch/arm/include/asm/tlb.h b/arch/arm/include/asm/tlb.h index b8cbe03ad260..9ab8a6929d35 100644 --- a/arch/arm/include/asm/tlb.h +++ b/arch/arm/include/asm/tlb.h @@ -39,7 +39,9 @@ static inline void __tlb_remove_table(void *_table) static inline void __pte_free_tlb(struct mmu_gather *tlb, pgtable_t pte, unsigned long addr) { - pgtable_pte_page_dtor(pte); + struct ptdesc *ptdesc = page_ptdesc(pte); + + ptdesc_pte_dtor(ptdesc); #ifndef CONFIG_ARM_LPAE /* @@ -50,17 +52,17 @@ __pte_free_tlb(struct mmu_gather *tlb, pgtable_t pte, unsigned long addr) __tlb_adjust_range(tlb, addr - PAGE_SIZE, 2 * PAGE_SIZE); #endif - tlb_remove_table(tlb, pte); + tlb_remove_ptdesc(tlb, ptdesc); } static inline void __pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmdp, unsigned long addr) { #ifdef CONFIG_ARM_LPAE - struct page *page = virt_to_page(pmdp); + struct ptdesc *ptdesc = virt_to_ptdesc(pmdp); - pgtable_pmd_page_dtor(page); - tlb_remove_table(tlb, page); + ptdesc_pmd_dtor(ptdesc); + tlb_remove_ptdesc(tlb, ptdesc); #endif } diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c index 463fc2a8448f..7add505bd797 100644 --- a/arch/arm/mm/mmu.c +++ b/arch/arm/mm/mmu.c @@ -737,11 +737,11 @@ static void __init *early_alloc(unsigned long sz) static void *__init late_alloc(unsigned long sz) { - void *ptr = (void *)__get_free_pages(GFP_PGTABLE_KERNEL, get_order(sz)); + void *ptdesc = ptdesc_alloc(GFP_PGTABLE_KERNEL, get_order(sz)); - if (!ptr || !pgtable_pte_page_ctor(virt_to_page(ptr))) + if (!ptdesc || !ptdesc_pte_ctor(ptdesc)) BUG(); - return ptr; + return ptdesc; } static pte_t * __init arm_pte_alloc(pmd_t *pmd, unsigned long addr, -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:39:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:39:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528153.821048 (Exim 4.92) (envelope-from ) id 1ptZMt-0001yd-RG; Mon, 01 May 2023 19:39:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528153.821048; Mon, 01 May 2023 19:39:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZMt-0001vv-IA; Mon, 01 May 2023 19:39:27 +0000 Received: by outflank-mailman (input) for mailman id 528153; Mon, 01 May 2023 19:39:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZCv-0006PY-NM for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:29:09 +0000 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [2607:f8b0:4864:20::62d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7022b5c1-e856-11ed-8611-37d641c3527e; Mon, 01 May 2023 21:29:07 +0200 (CEST) Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1aaea3909d1so17752805ad.2 for ; Mon, 01 May 2023 12:29:07 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.29.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:29:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7022b5c1-e856-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969346; x=1685561346; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WInZHFLF0E37CPvH/fyQuQmpONrFi7mPGahLu3Z9gNY=; b=q4na0YpY6+HIdR7eCjpOfgl3pLZKXaYPSEQBquag8z/68f0H1ARrXFU5GHdi9YxK8/ rB/VLGJXy6D4ZufE/2LOOEwnretxgWAB++ZlGVRxVIYCoUOlMN8apcsmkHtbQevtOOJx LNKiQlcElPDsuGjD80MSn3zT41r1jijBtepWy2itQQP8kPb/qbuR3Nu9du37XsuFat5b tY9vSCaH65FZJZYGzqq6Sev5FEiEarceFI+PkCB4zysu+TPDmYzeupQ3qWrtewRiW+Ef pPbEC2E+2Gu9odmO4zWHfrgw5vSTXCdgYdvlBNlEJqZMmLFOH+elBEgtadEGjmhbbSeV twkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969346; x=1685561346; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WInZHFLF0E37CPvH/fyQuQmpONrFi7mPGahLu3Z9gNY=; b=VduIuFvKOXAydoDzd1DVCpZmEjA+SFree7Zz66sH7I296trGPa7gES+Z0BCrj5J8NV Eb2nNZ+tuUWPAMHRUVDnpY36ixZBj78IgPB+Zwf+zFU9DEBFdT0h/f+czgPzyYdKn4/i R6AfDW5794QW6PX5HWmB/hZx1TThXPcEErd13sPbFpv1YdB1UWkQycnaZIbfwjf7JUJs BO76r+9pckbcef3bZO8nJARMQWh26GG3m9WPakH/39ev+gVTtIiHim5La2pFnA43CLHf txthxPBCTjkd9w7mCPdZDYPhd8HUXhbbIRufCglBQXWY0z+WqiV+miRmWCeCpF0GtCw9 uLPA== X-Gm-Message-State: AC+VfDy9HNVgNrd1QOpZl6R6l1HN7NQ0I09FphW8NUIqdJqnn75w93uv fKCzS0v1TaXd2EMAtIkAzww= X-Google-Smtp-Source: ACHHUZ4G7uSDpj0Az+Rf76NPdw6reyXbUYX/RD5L7uNUC8eMCewkmfrtYB+I6yNLHyDYyReDKoyXCw== X-Received: by 2002:a17:902:c947:b0:1ab:8f4:af21 with SMTP id i7-20020a170902c94700b001ab08f4af21mr235908pla.42.1682969345737; Mon, 01 May 2023 12:29:05 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" Subject: [PATCH v2 22/34] csky: Convert __pte_free_tlb() to use ptdescs Date: Mon, 1 May 2023 12:28:17 -0700 Message-Id: <20230501192829.17086-23-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Signed-off-by: Vishal Moola (Oracle) --- arch/csky/include/asm/pgalloc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/csky/include/asm/pgalloc.h b/arch/csky/include/asm/pgalloc.h index 7d57e5da0914..af26f1191b43 100644 --- a/arch/csky/include/asm/pgalloc.h +++ b/arch/csky/include/asm/pgalloc.h @@ -63,8 +63,8 @@ static inline pgd_t *pgd_alloc(struct mm_struct *mm) #define __pte_free_tlb(tlb, pte, address) \ do { \ - pgtable_pte_page_dtor(pte); \ - tlb_remove_page(tlb, pte); \ + ptdesc_pte_dtor(page_ptdesc(pte)); \ + tlb_remove_page_ptdesc(tlb, page_ptdesc(pte)); \ } while (0) extern void pagetable_init(void); -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:39:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:39:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528159.821067 (Exim 4.92) (envelope-from ) id 1ptZMw-0002m0-GA; Mon, 01 May 2023 19:39:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528159.821067; Mon, 01 May 2023 19:39:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZMw-0002lc-9Z; Mon, 01 May 2023 19:39:30 +0000 Received: by outflank-mailman (input) for mailman id 528159; Mon, 01 May 2023 19:39:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZD4-0006PY-Oa for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:29:18 +0000 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [2607:f8b0:4864:20::636]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 730680a3-e856-11ed-8611-37d641c3527e; Mon, 01 May 2023 21:29:11 +0200 (CEST) Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1aaf70676b6so9592365ad.3 for ; Mon, 01 May 2023 12:29:11 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.29.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:29:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 730680a3-e856-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969350; x=1685561350; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4OtNgWOkZ3LfZLHJ8GzTdJkHLxMJcmtHKM1yrsNlf/Q=; b=Z7q9x2Xo+R2VkP+SAoL4No5SPSbkqDSqv1O/IrhmxSJUfCVapYFLSqvpVv77DdaaNp 7xLFfeVlS+/Z0T5loFjBwxXBtJMOL0SomvnLpxrMgUE0H3Z2NwMVPWqjWZZaWw/Xtz9H bXhAt7jaDl6TAQEvatyLSYOokashb8FOV+mCaWLsgTEKm8FhtMTj/edGzjuLKaTQnJVx 0eZhRzcKCCgmZxOyeAj8qE7Nk7KdCTP6wyrMnmtMZ4gp104XnMq6z3YcmLmYurGQiyUb qQCTGhNGKLl+87vhFPVut1PJmPE/0ePjlrtCLEgAAJx+RTgFbaFyPCMZ3prXkkSGna7E KEcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969350; x=1685561350; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4OtNgWOkZ3LfZLHJ8GzTdJkHLxMJcmtHKM1yrsNlf/Q=; b=Ovv59nhvdFcq84lTwAVBkI4cVibM9bWtFdL33hN8CmYXeYDBr2hIIboEFjVipz/Hkd 9nigqoRzmsJLT7UNHpQFFrOTO7lVasOjJ3yKupwYYBuGg7xkAXRjkzuBGwZu0RdkbZ7a ejOSXqtPjoFrKr4X3+HDNvFwNuSP5BFMpOcLZtcTIOGCUGZhwMbxtL6Us6MoGOymynYA pEEAnGPNf7vIRVNskMuwOd75wX50fWoqTddRSZW2eoH6dOg36882cvqmTAvndaAqqgFS jiZFBW1tdXNHNILtcaLLQvtG70lAd8SsZ84iYsvKz9/VojpP/xymwsVWN+iNCHSqkhPH T77Q== X-Gm-Message-State: AC+VfDxG0AX1GtMTnEEoJ0LL7AxURdKj/aQXror3BxJwLGxAtr+X/mmf MAyLKyMZ+/4Dx7IIqp8HkrlMgyaFieLiVW+c X-Google-Smtp-Source: ACHHUZ6ZQG7EefBUYeumgjpKENexw5lTdMP6ZEhxCncdw/ecXlC+vhc9H9rF3r/Lw9bkiQ71uazgBQ== X-Received: by 2002:a17:902:a516:b0:1a6:6b9d:5e0f with SMTP id s22-20020a170902a51600b001a66b9d5e0fmr14561274plq.17.1682969350547; Mon, 01 May 2023 12:29:10 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" , Geert Uytterhoeven Subject: [PATCH v2 25/34] m68k: Convert various functions to use ptdescs Date: Mon, 1 May 2023 12:28:20 -0700 Message-Id: <20230501192829.17086-26-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use ptdesc_alloc() and ptdesc_address() instead to help standardize page tables further. Signed-off-by: Vishal Moola (Oracle) --- arch/m68k/include/asm/mcf_pgalloc.h | 41 ++++++++++++++-------------- arch/m68k/include/asm/sun3_pgalloc.h | 8 +++--- arch/m68k/mm/motorola.c | 4 +-- 3 files changed, 27 insertions(+), 26 deletions(-) diff --git a/arch/m68k/include/asm/mcf_pgalloc.h b/arch/m68k/include/asm/mcf_pgalloc.h index 5c2c0a864524..b0e909e23e14 100644 --- a/arch/m68k/include/asm/mcf_pgalloc.h +++ b/arch/m68k/include/asm/mcf_pgalloc.h @@ -7,20 +7,19 @@ extern inline void pte_free_kernel(struct mm_struct *mm, pte_t *pte) { - free_page((unsigned long) pte); + ptdesc_free(virt_to_ptdesc(pte)); } extern const char bad_pmd_string[]; extern inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm) { - unsigned long page = __get_free_page(GFP_DMA); + struct ptdesc *ptdesc = ptdesc_alloc(GFP_DMA | __GFP_ZERO, 0); - if (!page) + if (!ptdesc) return NULL; - memset((void *)page, 0, PAGE_SIZE); - return (pte_t *) (page); + return (pte_t *) (ptdesc_address(ptdesc)); } extern inline pmd_t *pmd_alloc_kernel(pgd_t *pgd, unsigned long address) @@ -35,36 +34,36 @@ extern inline pmd_t *pmd_alloc_kernel(pgd_t *pgd, unsigned long address) static inline void __pte_free_tlb(struct mmu_gather *tlb, pgtable_t pgtable, unsigned long address) { - struct page *page = virt_to_page(pgtable); + struct ptdesc *ptdesc = virt_to_ptdesc(pgtable); - pgtable_pte_page_dtor(page); - __free_page(page); + ptdesc_pte_dtor(ptdesc); + ptdesc_free(ptdesc); } static inline pgtable_t pte_alloc_one(struct mm_struct *mm) { - struct page *page = alloc_pages(GFP_DMA, 0); + struct ptdesc *ptdesc = ptdesc_alloc(GFP_DMA, 0); pte_t *pte; - if (!page) + if (!ptdesc) return NULL; - if (!pgtable_pte_page_ctor(page)) { - __free_page(page); + if (!ptdesc_pte_ctor(ptdesc)) { + ptdesc_free(ptdesc); return NULL; } - pte = page_address(page); - clear_page(pte); + pte = ptdesc_address(ptdesc); + ptdesc_clear(pte); return pte; } static inline void pte_free(struct mm_struct *mm, pgtable_t pgtable) { - struct page *page = virt_to_page(pgtable); + struct ptdesc *ptdesc = virt_to_ptdesc(ptdesc); - pgtable_pte_page_dtor(page); - __free_page(page); + ptdesc_pte_dtor(ptdesc); + ptdesc_free(ptdesc); } /* @@ -75,16 +74,18 @@ static inline void pte_free(struct mm_struct *mm, pgtable_t pgtable) static inline void pgd_free(struct mm_struct *mm, pgd_t *pgd) { - free_page((unsigned long) pgd); + ptdesc_free(virt_to_ptdesc(pgd)); } static inline pgd_t *pgd_alloc(struct mm_struct *mm) { pgd_t *new_pgd; + struct ptdesc *ptdesc = ptdesc_alloc(GFP_DMA | GFP_NOWARN, 0); - new_pgd = (pgd_t *)__get_free_page(GFP_DMA | __GFP_NOWARN); - if (!new_pgd) + if (!ptdesc) return NULL; + new_pgd = (pgd_t *) ptdesc_address(ptdesc); + memcpy(new_pgd, swapper_pg_dir, PTRS_PER_PGD * sizeof(pgd_t)); memset(new_pgd, 0, PAGE_OFFSET >> PGDIR_SHIFT); return new_pgd; diff --git a/arch/m68k/include/asm/sun3_pgalloc.h b/arch/m68k/include/asm/sun3_pgalloc.h index 198036aff519..013d375fc239 100644 --- a/arch/m68k/include/asm/sun3_pgalloc.h +++ b/arch/m68k/include/asm/sun3_pgalloc.h @@ -17,10 +17,10 @@ extern const char bad_pmd_string[]; -#define __pte_free_tlb(tlb,pte,addr) \ -do { \ - pgtable_pte_page_dtor(pte); \ - tlb_remove_page((tlb), pte); \ +#define __pte_free_tlb(tlb, pte, addr) \ +do { \ + ptdesc_pte_dtor(page_ptdesc(pte)); \ + tlb_remove_page_ptdesc((tlb), page_ptdesc(pte)); \ } while (0) static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, pte_t *pte) diff --git a/arch/m68k/mm/motorola.c b/arch/m68k/mm/motorola.c index 911301224078..f7adb86b37fb 100644 --- a/arch/m68k/mm/motorola.c +++ b/arch/m68k/mm/motorola.c @@ -161,7 +161,7 @@ void *get_pointer_table(int type) * m68k doesn't have SPLIT_PTE_PTLOCKS for not having * SMP. */ - pgtable_pte_page_ctor(virt_to_page(page)); + ptdesc_pte_ctor(virt_to_ptdesc(page)); } mmu_page_ctor(page); @@ -201,7 +201,7 @@ int free_pointer_table(void *table, int type) list_del(dp); mmu_page_dtor((void *)page); if (type == TABLE_PTE) - pgtable_pte_page_dtor(virt_to_page(page)); + ptdesc_pte_dtor(virt_to_ptdesc((void *)page)); free_page (page); return 1; } else if (ptable_list[type].next != dp) { -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:39:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:39:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528188.821077 (Exim 4.92) (envelope-from ) id 1ptZNF-0004VH-R9; Mon, 01 May 2023 19:39:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528188.821077; Mon, 01 May 2023 19:39:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZNF-0004V6-Nl; Mon, 01 May 2023 19:39:49 +0000 Received: by outflank-mailman (input) for mailman id 528188; Mon, 01 May 2023 19:39:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZD3-0006FS-D8 for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:29:17 +0000 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [2607:f8b0:4864:20::532]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 75db82fb-e856-11ed-b225-6b7b168915f2; Mon, 01 May 2023 21:29:16 +0200 (CEST) Received: by mail-pg1-x532.google.com with SMTP id 41be03b00d2f7-517c01edaaaso1819418a12.3 for ; Mon, 01 May 2023 12:29:16 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.29.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:29:15 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 75db82fb-e856-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969355; x=1685561355; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=M2PCFvKq9JWcIC4Exd9oDYO0v0PQOHyXRap+yEgbOb4=; b=pbOgq641Q1VbKkWYpSKEOBTaJbK7N+gn3tPQxAnQMHVxsbuYS7d6gCFZWWRyAoJPvd QWBoalX7ztTkXy1/S77S44wUsaYiw+c9l0pjoAvj83RwanS2FHVDTD9b5yLt3dvSiRkC Y6FbuRkXeTez8mU8JwqFdJ8q3udPbLVyCGPniHNdmE3Bvis2G1N5Cf54GBHK19m19dh2 ECy1qDfhwNI4K2KlZeZKdUsb//pSuTNjtcr9BAZz+ZE7jjtZb0g8W7o+eLshkW2fWRhk rjbBHucvZ06kdc4e0Uijz1mCvV4V1RY1P7Hdmh8XbAUQYZvgzIuSpNmzClPaEZvw/eBL VKvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969355; x=1685561355; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M2PCFvKq9JWcIC4Exd9oDYO0v0PQOHyXRap+yEgbOb4=; b=hz/KyNhYBED8qd+/giVzthLgrntYWj0NGtqsCZEfx3EFuQwWXzbw++LUxEipbXyQcx 6flNl9UHeotwDEBUbsam9nIrfvzhow0K4I688xHu5LfJ0++FqY5nrsRB4tcUETE++Ij6 R+x8X4Ru5F10T9BodXZVb/4sqmEJ16KnGwmrcXoppGBMKATm71IUReBtX2jerDqnHqc5 dzvToWkcBZ3zx0N35malvmru+6OzPf0EEIvKuOxMKDtOElE66cLhuRdbBN5XNlZwSsxy vOg5PavotJFOUYEGsYVeA0du58l0F4c8J1xQ5HvJ4CaAaWZhRhAgs1Ma6dPz7XY56z+o Z2Nw== X-Gm-Message-State: AC+VfDy3cd6qYtBCCh65FoW0YeplIukOlmPyUxXIK3vR8hikWoHCKMvl IVshxyMz56s7Ztib54djUUI= X-Google-Smtp-Source: ACHHUZ5aUwQpmXFq62IOwkeTiJiFUSz6Wt9PaXTxNdRH/kylJwLUJvf08r71LifeGRMo3EYnyRIKBw== X-Received: by 2002:a17:902:dacb:b0:1a8:d7a:9255 with SMTP id q11-20020a170902dacb00b001a80d7a9255mr17869996plx.54.1682969355424; Mon, 01 May 2023 12:29:15 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" , Jonas Bonn Subject: [PATCH v2 28/34] openrisc: Convert __pte_free_tlb() to use ptdescs Date: Mon, 1 May 2023 12:28:23 -0700 Message-Id: <20230501192829.17086-29-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Signed-off-by: Vishal Moola (Oracle) --- arch/openrisc/include/asm/pgalloc.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/openrisc/include/asm/pgalloc.h b/arch/openrisc/include/asm/pgalloc.h index b7b2b8d16fad..14e641686281 100644 --- a/arch/openrisc/include/asm/pgalloc.h +++ b/arch/openrisc/include/asm/pgalloc.h @@ -66,10 +66,10 @@ extern inline pgd_t *pgd_alloc(struct mm_struct *mm) extern pte_t *pte_alloc_one_kernel(struct mm_struct *mm); -#define __pte_free_tlb(tlb, pte, addr) \ -do { \ - pgtable_pte_page_dtor(pte); \ - tlb_remove_page((tlb), (pte)); \ +#define __pte_free_tlb(tlb, pte, addr) \ +do { \ + ptdesc_pte_dtor(page_ptdesc(pte)); \ + tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); \ } while (0) #endif -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:39:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:39:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528189.821083 (Exim 4.92) (envelope-from ) id 1ptZNG-0004aD-6T; Mon, 01 May 2023 19:39:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528189.821083; Mon, 01 May 2023 19:39:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZNG-0004Zt-1F; Mon, 01 May 2023 19:39:50 +0000 Received: by outflank-mailman (input) for mailman id 528189; Mon, 01 May 2023 19:39:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZD2-0006PY-OK for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:29:16 +0000 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [2607:f8b0:4864:20::62e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7215b18d-e856-11ed-8611-37d641c3527e; Mon, 01 May 2023 21:29:10 +0200 (CEST) Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1aaec9ad820so16454975ad.0 for ; Mon, 01 May 2023 12:29:10 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.29.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:29:08 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7215b18d-e856-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969349; x=1685561349; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Pf7K/iFMD6od7/SRYpuPsYcodkkXMgOdjXv5YJvZldk=; b=Ln4mDR/5PqhQgedxrHvQljALDEWoa3b+hRIGv35D/XEQopkojKeYky16q/KJiQP190 gOXMLkWlsxRYt/qNbMMHduRgO5rwSHkWxXdTawxJdNC4w4aAhizbEp/u5yJIFvo+hvkC CzCza/yOOV7wQ3CRXlPMEZ6eMm1zhczAF9AJlp92How5r4l3oEpl8xhmNNQZ5IRuQriJ 5iq8Jlorps05Qifajbp6RIvsWCW3JV3LIBqvQ7RLXCzoWQn8RP/izc4h1lgdgQ7smZ+o cGeex+nu9iv1OEbJv0WRRlF1TRZ+PJHxnItl8vKiR8iqu8w5u+UliAsQ4ZVuON7yHbns fmHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969349; x=1685561349; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Pf7K/iFMD6od7/SRYpuPsYcodkkXMgOdjXv5YJvZldk=; b=KhZtg5sjhEFLZeizPlqdgud7VhP47V8DLrB0V/lGqvKm1ehWVsuguphCTLXFRrIDvc hWzgrrVCofJTVSIyERppe9fz6zdyC2uzyX+MbC9NPCa7xfUes4why3JN7VsFJmntbD9r 5nG7afGhRDpnTs3iStct+b/HscbyALIqB1kUNp04PImtOFSDG+4MSnO8Sb0zZXxCbAX7 drh+R+kurgzvA4lFmGuSbmyTg5Gc9HwYmWAxfYMcBeEnr6f0ECZHeFt+t5yJFmbrFEJJ yheCLbiNoBrmH8u0JBFQu4pB+a99ZGrnGZodlEhLxOIr+69LXFK4dX0Dn5uc/Wyn9zOG LcGA== X-Gm-Message-State: AC+VfDybrLnsXvHEtnIsYpYBg1+GzSpLDycKVuiXi1C4s/6hlsOi2tWG CuSqUfkcx2AbK53XMKo10o2g2Krei6drKeSA X-Google-Smtp-Source: ACHHUZ4pGEgDP0ct3SBtbJjK9qWlsOBNKoJkb8hPo4/muNsqGBXZA1NHW06v64HPJmj4Ckit7F5PBA== X-Received: by 2002:a17:903:2352:b0:1aa:ed6f:29c2 with SMTP id c18-20020a170903235200b001aaed6f29c2mr6827893plh.11.1682969349038; Mon, 01 May 2023 12:29:09 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" , Huacai Chen Subject: [PATCH v2 24/34] loongarch: Convert various functions to use ptdescs Date: Mon, 1 May 2023 12:28:19 -0700 Message-Id: <20230501192829.17086-25-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use ptdesc_alloc() and ptdesc_address() instead to help standardize page tables further. Signed-off-by: Vishal Moola (Oracle) --- arch/loongarch/include/asm/pgalloc.h | 27 +++++++++++++++------------ arch/loongarch/mm/pgtable.c | 7 ++++--- 2 files changed, 19 insertions(+), 15 deletions(-) diff --git a/arch/loongarch/include/asm/pgalloc.h b/arch/loongarch/include/asm/pgalloc.h index af1d1e4a6965..1fe074f85b6b 100644 --- a/arch/loongarch/include/asm/pgalloc.h +++ b/arch/loongarch/include/asm/pgalloc.h @@ -45,9 +45,9 @@ extern void pagetable_init(void); extern pgd_t *pgd_alloc(struct mm_struct *mm); #define __pte_free_tlb(tlb, pte, address) \ -do { \ - pgtable_pte_page_dtor(pte); \ - tlb_remove_page((tlb), pte); \ +do { \ + ptdesc_pte_dtor(page_ptdesc(pte)); \ + tlb_remove_page_ptdesc((tlb), page_ptdesc(pte)); \ } while (0) #ifndef __PAGETABLE_PMD_FOLDED @@ -55,18 +55,18 @@ do { \ static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, unsigned long address) { pmd_t *pmd; - struct page *pg; + struct ptdesc *ptdesc; - pg = alloc_page(GFP_KERNEL_ACCOUNT); - if (!pg) + ptdesc = ptdesc_alloc(GFP_KERNEL_ACCOUNT, 0); + if (!ptdesc) return NULL; - if (!pgtable_pmd_page_ctor(pg)) { - __free_page(pg); + if (!ptdesc_pmd_ctor(ptdesc)) { + ptdesc_free(ptdesc); return NULL; } - pmd = (pmd_t *)page_address(pg); + pmd = (pmd_t *)ptdesc_address(ptdesc); pmd_init(pmd); return pmd; } @@ -80,10 +80,13 @@ static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, unsigned long address) static inline pud_t *pud_alloc_one(struct mm_struct *mm, unsigned long address) { pud_t *pud; + struct ptdesc *ptdesc = ptdesc_alloc(GFP_KERNEL, 0); - pud = (pud_t *) __get_free_page(GFP_KERNEL); - if (pud) - pud_init(pud); + if (!ptdesc) + return NULL; + pud = (pud_t *)ptdesc_address(ptdesc); + + pud_init(pud); return pud; } diff --git a/arch/loongarch/mm/pgtable.c b/arch/loongarch/mm/pgtable.c index 36a6dc0148ae..ff07b8f1ef30 100644 --- a/arch/loongarch/mm/pgtable.c +++ b/arch/loongarch/mm/pgtable.c @@ -11,10 +11,11 @@ pgd_t *pgd_alloc(struct mm_struct *mm) { - pgd_t *ret, *init; + pgd_t *init, *ret = NULL; + struct ptdesc *ptdesc = ptdesc_alloc(GFP_KERNEL, 0); - ret = (pgd_t *) __get_free_page(GFP_KERNEL); - if (ret) { + if (ptdesc) { + ret = (pgd_t *)ptdesc_address(ptdesc); init = pgd_offset(&init_mm, 0UL); pgd_init(ret); memcpy(ret + USER_PTRS_PER_PGD, init + USER_PTRS_PER_PGD, -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:39:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:39:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528192.821089 (Exim 4.92) (envelope-from ) id 1ptZNG-0004iB-NZ; Mon, 01 May 2023 19:39:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528192.821089; Mon, 01 May 2023 19:39:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZNG-0004hC-Ei; Mon, 01 May 2023 19:39:50 +0000 Received: by outflank-mailman (input) for mailman id 528192; Mon, 01 May 2023 19:39:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZDB-0006FS-Oh for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:29:25 +0000 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [2607:f8b0:4864:20::633]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 79e204dc-e856-11ed-b225-6b7b168915f2; Mon, 01 May 2023 21:29:22 +0200 (CEST) Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1aaec6f189cso12402295ad.3 for ; Mon, 01 May 2023 12:29:22 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.29.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:29:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 79e204dc-e856-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969362; x=1685561362; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=m8/b+eKq2obnq3wrn4AaChyOhPXbZKipyE2UTOB7XHg=; b=Q3jl6YttJDwUuWKyn1dVs6I8W94SFWxxciTJdLpT/LELBYCeGyev+ExIC9w29x2Yt1 zXHIDz5du52vN2frCHR+hIpcwuJ6c3WNhfC/Gsy1nS14RuXHFXtXj5G9xq8KbaH8upCB hoZ+KR9ZQITjkQA540sZmLX6PX4iGNe7NpnWG1G2AsO+NZdypSRuEfFuzqh0wPvQQaGw 4XpO3Q1D/iCtA92s97XY1Or0L7GqG2SHJxpwKx0yuxfIbjPslNXarskrtkCCtU8UwW5x DSxt7iwfG4oFpxWasaAVqe2jz7cH5xxqomQxklMjhuQacqvGLIa7+5cde3ROrtfKL2NP oDNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969362; x=1685561362; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m8/b+eKq2obnq3wrn4AaChyOhPXbZKipyE2UTOB7XHg=; b=P4LA8mL83iGpVPZCMEul+Jt+u50RS0EsV5MtSc1aTqjRnUWWEIiBqyQVVN+a0663xB hL7h8nD+zrA3egyVVlfG6WQtjO9EZey0sZdjtyvSKCbgOQoPIeb/jy98bEz2HX6mq7dP 45tiNu8DI421+Kb08fdzejl1BFaoHoVpDkUKu5I3W3Hi+8Rx2ocAyxXftV1N7wwL1slf bP343e1MXwOmWrcTcLcllTMPhUuv6+hmtJtERgYkWqOdB3cWnlhwDB9viHe8kv1jy73x sR/h7Xk0F+SFzNVhILsMzF84ttfETUs1OIqRs5NyJga7EQ6o54ZKoMxyliwDELBpDAfy zX4w== X-Gm-Message-State: AC+VfDz9Jlg/ZWgIzmFzkC+6c/P/I+6hRNS03ZSfRJFnkqbnnGLZHLnS 1NJ59Ky4/TGr8uTWo+0rIBw= X-Google-Smtp-Source: ACHHUZ7SACaylL3/aSyKhkx7S2g1HYBvFG08B1pme9nPnu6u4pSNBbJS188a/Kq3fbmOV3eKOsv72w== X-Received: by 2002:a17:902:db0b:b0:1aa:e5cd:647a with SMTP id m11-20020a170902db0b00b001aae5cd647amr7875588plx.23.1682969362180; Mon, 01 May 2023 12:29:22 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" , Richard Weinberger Subject: [PATCH v2 33/34] um: Convert {pmd, pte}_free_tlb() to use ptdescs Date: Mon, 1 May 2023 12:28:28 -0700 Message-Id: <20230501192829.17086-34-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Also cleans up some spacing issues. Signed-off-by: Vishal Moola (Oracle) --- arch/um/include/asm/pgalloc.h | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/arch/um/include/asm/pgalloc.h b/arch/um/include/asm/pgalloc.h index 8ec7cd46dd96..760b029505c1 100644 --- a/arch/um/include/asm/pgalloc.h +++ b/arch/um/include/asm/pgalloc.h @@ -25,19 +25,19 @@ */ extern pgd_t *pgd_alloc(struct mm_struct *); -#define __pte_free_tlb(tlb,pte, address) \ -do { \ - pgtable_pte_page_dtor(pte); \ - tlb_remove_page((tlb),(pte)); \ +#define __pte_free_tlb(tlb, pte, address) \ +do { \ + ptdesc_pte_dtor(page_ptdesc(pte)); \ + tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); \ } while (0) #ifdef CONFIG_3_LEVEL_PGTABLES -#define __pmd_free_tlb(tlb, pmd, address) \ -do { \ - pgtable_pmd_page_dtor(virt_to_page(pmd)); \ - tlb_remove_page((tlb),virt_to_page(pmd)); \ -} while (0) \ +#define __pmd_free_tlb(tlb, pmd, address) \ +do { \ + ptdesc_pmd_dtor(virt_to_ptdesc(pmd)); \ + tlb_remove_page_ptdesc((tlb), virt_to_ptdesc(pmd)); \ +} while (0) #endif -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:39:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:39:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528202.821107 (Exim 4.92) (envelope-from ) id 1ptZNJ-0005Oj-5S; Mon, 01 May 2023 19:39:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528202.821107; Mon, 01 May 2023 19:39:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZNJ-0005OU-2T; Mon, 01 May 2023 19:39:53 +0000 Received: by outflank-mailman (input) for mailman id 528202; Mon, 01 May 2023 19:39:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZD8-0006PY-Oh for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:29:22 +0000 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [2607:f8b0:4864:20::635]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 73d8f659-e856-11ed-8611-37d641c3527e; Mon, 01 May 2023 21:29:13 +0200 (CEST) Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1aad5245571so16972035ad.1 for ; Mon, 01 May 2023 12:29:13 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.29.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:29:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 73d8f659-e856-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969352; x=1685561352; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kyicI3UFSJTH3R33HGjLFGEyUDrTPXlIkqJCgIfzdrc=; b=bIC3wiMrkZ043YRG29tisEfS2j+UeOAsmyII3EDzrldtjEb8icghvzgUTYdQYM4doj vdu0JKDKQcL03t0/j67MJsK3EMdVvlx3Lc/9NrJJJYh+5KdPrYzRKBiHtTGqpBRhkA5a ZboUsEenHMS9VrUn3gKI66CrCL9Z8GCruZLIMyl89zj2oR4Tg7uJGI/BsPQUk9uXq4w7 IEqVWzOt4YqC8i9AxlAbu1JP49n5XnekAOLER4FSWBBd0M0ka47bttpu+oGYYPDkowKQ ep35YwloCTCGYeII4Pobz7D0t4NcJCq50AMppyxrvfN/Wt0IBRqMUSxoDgh1JHSYp5Pm g50g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969352; x=1685561352; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kyicI3UFSJTH3R33HGjLFGEyUDrTPXlIkqJCgIfzdrc=; b=FitvQea9s9nu065KvmRCz5AWJvOUpPS8WkEl+3BAjmo92H3mvX9J41C3JVOMuQke/h FlTGk4hT2FRi8vZB7nPgX8TA6xJOZySNS0CnyhAGbSsAZRQONchWaRefojRkBvtGU7j5 fBlZgXIpd+qSSUxp3bYYVR1TSV8hZWkM+FSEVxdu2+OiiJTQ6CxveukDWKgFApblfkAO nV1aqU7HhnowR0G1lXVys6x46e/To9Qu1TDkL0fgsen6/BVScJSfbBuujHeL5DJq03wQ IzWDBGyNQhDkQwyjm/3wcLOwejXWVvUyEfAA+wKepzUcBanX3JKNAAp1R/6/1Uly3XVg 2d0g== X-Gm-Message-State: AC+VfDyAQK0tPFtFavPq6l0hc5PdSHvLlibf7m1K8YjWVS7vEELaIA7n THuHl3ZB7MiVKPMU27Kam7U= X-Google-Smtp-Source: ACHHUZ6JGwiASceIv2N+eQzagLfWHlR6lj5LsM9PIBmbvfqlnJYs1oK6NLyKl7E/zGC8k10AZHOifw== X-Received: by 2002:a17:902:ea0b:b0:1a6:3b9c:7fea with SMTP id s11-20020a170902ea0b00b001a63b9c7feamr19311944plg.36.1682969351902; Mon, 01 May 2023 12:29:11 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" , Thomas Bogendoerfer Subject: [PATCH v2 26/34] mips: Convert various functions to use ptdescs Date: Mon, 1 May 2023 12:28:21 -0700 Message-Id: <20230501192829.17086-27-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use ptdesc_alloc() and ptdesc_address() instead to help standardize page tables further. Signed-off-by: Vishal Moola (Oracle) --- arch/mips/include/asm/pgalloc.h | 31 +++++++++++++++++-------------- arch/mips/mm/pgtable.c | 7 ++++--- 2 files changed, 21 insertions(+), 17 deletions(-) diff --git a/arch/mips/include/asm/pgalloc.h b/arch/mips/include/asm/pgalloc.h index f72e737dda21..7f7cc3140b27 100644 --- a/arch/mips/include/asm/pgalloc.h +++ b/arch/mips/include/asm/pgalloc.h @@ -51,13 +51,13 @@ extern pgd_t *pgd_alloc(struct mm_struct *mm); static inline void pgd_free(struct mm_struct *mm, pgd_t *pgd) { - free_pages((unsigned long)pgd, PGD_TABLE_ORDER); + ptdesc_free(virt_to_ptdesc(pgd)); } -#define __pte_free_tlb(tlb,pte,address) \ -do { \ - pgtable_pte_page_dtor(pte); \ - tlb_remove_page((tlb), pte); \ +#define __pte_free_tlb(tlb, pte, address) \ +do { \ + ptdesc_pte_dtor(page_ptdesc(pte)); \ + tlb_remove_page_ptdesc((tlb), page_ptdesc(pte)); \ } while (0) #ifndef __PAGETABLE_PMD_FOLDED @@ -65,18 +65,18 @@ do { \ static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, unsigned long address) { pmd_t *pmd; - struct page *pg; + struct ptdesc *ptdesc; - pg = alloc_pages(GFP_KERNEL_ACCOUNT, PMD_TABLE_ORDER); - if (!pg) + ptdesc = ptdesc_alloc(GFP_KERNEL_ACCOUNT, PMD_TABLE_ORDER); + if (!ptdesc) return NULL; - if (!pgtable_pmd_page_ctor(pg)) { - __free_pages(pg, PMD_TABLE_ORDER); + if (!ptdesc_pmd_ctor(ptdesc)) { + ptdesc_free(ptdesc); return NULL; } - pmd = (pmd_t *)page_address(pg); + pmd = (pmd_t *)ptdesc_address(ptdesc); pmd_init(pmd); return pmd; } @@ -90,10 +90,13 @@ static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, unsigned long address) static inline pud_t *pud_alloc_one(struct mm_struct *mm, unsigned long address) { pud_t *pud; + struct ptdesc *ptdesc = ptdesc_alloc(GFP_KERNEL, PUD_TABLE_ORDER); - pud = (pud_t *) __get_free_pages(GFP_KERNEL, PUD_TABLE_ORDER); - if (pud) - pud_init(pud); + if (!ptdesc) + return NULL; + pud = (pud_t *)ptdesc_address(ptdesc); + + pud_init(pud); return pud; } diff --git a/arch/mips/mm/pgtable.c b/arch/mips/mm/pgtable.c index b13314be5d0e..d626db9ac224 100644 --- a/arch/mips/mm/pgtable.c +++ b/arch/mips/mm/pgtable.c @@ -10,10 +10,11 @@ pgd_t *pgd_alloc(struct mm_struct *mm) { - pgd_t *ret, *init; + pgd_t *init, *ret = NULL; + struct ptdesc *ptdesc = ptdesc_alloc(GFP_KERNEL, PGD_TABLE_ORDER); - ret = (pgd_t *) __get_free_pages(GFP_KERNEL, PGD_TABLE_ORDER); - if (ret) { + if (ptdesc) { + ret = (pgd_t *) ptdesc_address(ptdesc); init = pgd_offset(&init_mm, 0UL); pgd_init(ret); memcpy(ret + USER_PTRS_PER_PGD, init + USER_PTRS_PER_PGD, -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:39:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:39:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528205.821117 (Exim 4.92) (envelope-from ) id 1ptZNP-0005x0-HW; Mon, 01 May 2023 19:39:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528205.821117; Mon, 01 May 2023 19:39:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZNP-0005wp-9m; Mon, 01 May 2023 19:39:59 +0000 Received: by outflank-mailman (input) for mailman id 528205; Mon, 01 May 2023 19:39:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZDJ-0006PY-Pw for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:29:33 +0000 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [2607:f8b0:4864:20::62e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7925230b-e856-11ed-8611-37d641c3527e; Mon, 01 May 2023 21:29:22 +0200 (CEST) Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1a9253d4551so21243575ad.0 for ; Mon, 01 May 2023 12:29:22 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.29.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:29:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7925230b-e856-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969361; x=1685561361; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CSVYEUhM0zGHlDR1yqa5KIpwwPynV1rh1Z3AvIT239o=; b=YCg1YMo/xitXPr8EH+7i7/M0wYddD4PRgw+Xim9LG20m92WUdC9kOQT3fMeSkFJ8bz 2xW9Qv874by/73QMdHiVk+wqz4B7HUYL6Uj2zbe5cOYZkoH3JAXPoFdQlYFWToTwzHn7 dFfF9W+SZdFlY3dKNimMml0EcpIP5K8qP91gmqtjuJ3sBzpu94RZheVZlyc0ZtXP5Kh9 Ho0HyuApLfDJnfV0KIWHGVL4xeGycAgKdLMplPIR2oWrmLtc//uxDTAq/yAuqmVSMzMJ fvK8MGrkhlBYA+kuhjIoxK7FCwuGLTfgfMGFdrbgTVFBoKNwWCi+6p4VuuSzDnIOEdqU o3Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969361; x=1685561361; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CSVYEUhM0zGHlDR1yqa5KIpwwPynV1rh1Z3AvIT239o=; b=FW2ILUMdVZEfzO9OyBRhGxo/gVudi1oOXYpMrhc4eQ9XumZCoxaqyKV/FlZv2WEbyn w0AY09n0BEG4RdTEfU+DbkkJJXB7wwQpM1BT8gH3eyXc2gKE2pYs4/UxJz/dUyxM7Z8x /VzqSCjUyEOsUpM/qtC06yFVA8qpH9y2+MLqQp9zlPcQTaUQxbB40aT45lHD2hP0aH6n g+7sk5dOja970DfiZVe42JWHwTAuqMChtQJ8EUqCXuPtqYRIp4mQGoXVRiCyacrl0Hr3 76QHqXmsb5u355AzA2LavwuwMmhy1JUhnZxh0M3xOdcXKav+MB2u0/Mw7wQ6OmYibl1a 603g== X-Gm-Message-State: AC+VfDwg/pEZWM7m/YJETQHyudZsCLRohmjTiMGV7N3HbkfNH1S4AsF/ F1+eSKAMpYUygl+yjKGuW/A= X-Google-Smtp-Source: ACHHUZ6yreaxJl7mf5rX62OpE7ktDECZCzzaxE5NqOb8jR7RBUIdxZHYmi631H3wh4Z5BZGAmm3BhA== X-Received: by 2002:a17:902:c712:b0:1ab:3ba:d2c1 with SMTP id p18-20020a170902c71200b001ab03bad2c1mr1428915plp.44.1682969360924; Mon, 01 May 2023 12:29:20 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" , "David S. Miller" Subject: [PATCH v2 32/34] sparc: Convert pgtable_pte_page_{ctor, dtor}() to ptdesc equivalents Date: Mon, 1 May 2023 12:28:27 -0700 Message-Id: <20230501192829.17086-33-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Part of the conversions to replace pgtable pte constructor/destructors with ptdesc equivalents. Signed-off-by: Vishal Moola (Oracle) --- arch/sparc/mm/srmmu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/sparc/mm/srmmu.c b/arch/sparc/mm/srmmu.c index 13f027afc875..964938aa7b88 100644 --- a/arch/sparc/mm/srmmu.c +++ b/arch/sparc/mm/srmmu.c @@ -355,7 +355,8 @@ pgtable_t pte_alloc_one(struct mm_struct *mm) return NULL; page = pfn_to_page(__nocache_pa((unsigned long)ptep) >> PAGE_SHIFT); spin_lock(&mm->page_table_lock); - if (page_ref_inc_return(page) == 2 && !pgtable_pte_page_ctor(page)) { + if (page_ref_inc_return(page) == 2 && + !ptdesc_pte_ctor(page_ptdesc(page))) { page_ref_dec(page); ptep = NULL; } @@ -371,7 +372,7 @@ void pte_free(struct mm_struct *mm, pgtable_t ptep) page = pfn_to_page(__nocache_pa((unsigned long)ptep) >> PAGE_SHIFT); spin_lock(&mm->page_table_lock); if (page_ref_dec_return(page) == 1) - pgtable_pte_page_dtor(page); + ptdesc_pte_dtor(page_ptdesc(page)); spin_unlock(&mm->page_table_lock); srmmu_free_nocache(ptep, SRMMU_PTE_TABLE_SIZE); -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:40:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:40:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528211.821121 (Exim 4.92) (envelope-from ) id 1ptZNP-00060Y-Sx; Mon, 01 May 2023 19:39:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528211.821121; Mon, 01 May 2023 19:39:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZNP-00060G-ME; Mon, 01 May 2023 19:39:59 +0000 Received: by outflank-mailman (input) for mailman id 528211; Mon, 01 May 2023 19:39:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZD4-0006FS-2c for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:29:18 +0000 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [2607:f8b0:4864:20::633]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 76b9d1fe-e856-11ed-b225-6b7b168915f2; Mon, 01 May 2023 21:29:17 +0200 (CEST) Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1aaec6f189cso12401465ad.3 for ; Mon, 01 May 2023 12:29:17 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.29.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:29:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 76b9d1fe-e856-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969357; x=1685561357; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=l1ckLKbyzk3TycCfORfJ/TBkh9kewWK+wgbsmWovkLc=; b=QOhINfLsJScPCSo/IfeyIyqWMqeIs48D8yaoqlS6ttjMbmNZXsD0pl2iRSwsAXqRrv zUUJOXK9c/ejP/aK8PhIumKGyTM6wx4FMhZyB9B20DcTQunSql+VvjSwHErAI8TxAw4R Y99zvhqhTYwxHGbhjSdsPxRy9B+yD0izY9vTuFFo+4wz8Jz2C37zAT+8c8EYp2fDz24U oGrB6CUieeF0SbwTG14XhJhloKyt3nzbHvCyZJJU6u4aL5aKMUavEI+jK4qMtp6ZB84A TmLf+lTqOkVGEF+wZ1coiBesyT5OIE5Gk6hWNsWKJwTKVv0S28KrIjiosst3fU+17ZhU 2bkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969357; x=1685561357; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l1ckLKbyzk3TycCfORfJ/TBkh9kewWK+wgbsmWovkLc=; b=MIL6ONcp6uYLKp3Vakgn64BKNtu+LlgND4f0nSfanXLzKJoRZg7miN07WtxtL5iIpr NgMDa3r0ltD9qVSPqwf5jW6NCsOwyZqJUa1MOWWCsi6YrgpNnx8FIIMnEJ2VTIFrEBPg gCnD2uAoCx8NYCCi/sM3pB7niEfeWdFMA+88R4OLqwMQYWqBXVTKvzbd5xjHgPPL4dja YO6gS4G7gnICIQYsP/glP+rcohFNJXVKBCNFnhBxjotwiQHQsxWZClZd94ZSbw+Ca1JZ FyLM3j5YCq5MmHKtPt7Sbjfr/9J129VPmsqY4P8W4jAVKoOT/ViyK4OF0eQhF0EoHtw5 mQbA== X-Gm-Message-State: AC+VfDzmhaxaXB5+JArra+RRrj7QQKUjZ1/7W019bq335zSCXyaRyDCx cPJNFkoGujtfFK98CCND1Pg= X-Google-Smtp-Source: ACHHUZ5ad9gvhcfa1XbL+pCFsXQ41wyEuU00A0VqKiT0180mGKgTi8tTwjBbR7r20yn6kHE8l0iQaQ== X-Received: by 2002:a17:902:ce91:b0:1aa:ef83:34be with SMTP id f17-20020a170902ce9100b001aaef8334bemr6350222plg.47.1682969356855; Mon, 01 May 2023 12:29:16 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" , Paul Walmsley Subject: [PATCH v2 29/34] riscv: Convert alloc_{pmd, pte}_late() to use ptdescs Date: Mon, 1 May 2023 12:28:24 -0700 Message-Id: <20230501192829.17086-30-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use ptdesc_alloc() and ptdesc_address() instead to help standardize page tables further. Signed-off-by: Vishal Moola (Oracle) --- arch/riscv/include/asm/pgalloc.h | 8 ++++---- arch/riscv/mm/init.c | 16 ++++++---------- 2 files changed, 10 insertions(+), 14 deletions(-) diff --git a/arch/riscv/include/asm/pgalloc.h b/arch/riscv/include/asm/pgalloc.h index 59dc12b5b7e8..cb5536403bd8 100644 --- a/arch/riscv/include/asm/pgalloc.h +++ b/arch/riscv/include/asm/pgalloc.h @@ -153,10 +153,10 @@ static inline pgd_t *pgd_alloc(struct mm_struct *mm) #endif /* __PAGETABLE_PMD_FOLDED */ -#define __pte_free_tlb(tlb, pte, buf) \ -do { \ - pgtable_pte_page_dtor(pte); \ - tlb_remove_page((tlb), pte); \ +#define __pte_free_tlb(tlb, pte, buf) \ +do { \ + ptdesc_pte_dtor(page_ptdesc(pte)); \ + tlb_remove_page_ptdesc((tlb), page_ptdesc(pte));\ } while (0) #endif /* CONFIG_MMU */ diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c index eb8173a91ce3..8f1982664687 100644 --- a/arch/riscv/mm/init.c +++ b/arch/riscv/mm/init.c @@ -353,12 +353,10 @@ static inline phys_addr_t __init alloc_pte_fixmap(uintptr_t va) static phys_addr_t __init alloc_pte_late(uintptr_t va) { - unsigned long vaddr; - - vaddr = __get_free_page(GFP_KERNEL); - BUG_ON(!vaddr || !pgtable_pte_page_ctor(virt_to_page(vaddr))); + struct ptdesc *ptdesc = ptdesc_alloc(GFP_KERNEL, 0); - return __pa(vaddr); + BUG_ON(!ptdesc || !ptdesc_pte_ctor(ptdesc)); + return __pa((pte_t *)ptdesc_address(ptdesc)); } static void __init create_pte_mapping(pte_t *ptep, @@ -436,12 +434,10 @@ static phys_addr_t __init alloc_pmd_fixmap(uintptr_t va) static phys_addr_t __init alloc_pmd_late(uintptr_t va) { - unsigned long vaddr; - - vaddr = __get_free_page(GFP_KERNEL); - BUG_ON(!vaddr || !pgtable_pmd_page_ctor(virt_to_page(vaddr))); + struct ptdesc *ptdesc = ptdesc_alloc(GFP_KERNEL, 0); - return __pa(vaddr); + BUG_ON(!ptdesc || !ptdesc_pmd_ctor(ptdesc)); + return __pa((pmd_t *)ptdesc_address(ptdesc)); } static void __init create_pmd_mapping(pmd_t *pmdp, -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:40:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:40:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528216.821145 (Exim 4.92) (envelope-from ) id 1ptZNV-0007K6-0K; Mon, 01 May 2023 19:40:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528216.821145; Mon, 01 May 2023 19:40:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZNU-0007II-PJ; Mon, 01 May 2023 19:40:04 +0000 Received: by outflank-mailman (input) for mailman id 528216; Mon, 01 May 2023 19:40:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZF7-0000m4-8s for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:31:25 +0000 Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [2607:f8b0:4864:20::72d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c1497016-e856-11ed-b225-6b7b168915f2; Mon, 01 May 2023 21:31:23 +0200 (CEST) Received: by mail-qk1-x72d.google.com with SMTP id af79cd13be357-74e1745356dso122713385a.0 for ; Mon, 01 May 2023 12:31:23 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id d6-20020ac80606000000b003bf9f9f1844sm9351784qth.71.2023.05.01.12.31.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:31:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c1497016-e856-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969481; x=1685561481; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/Y4+dyjBVr8IC4wKpAH33RVK4Uwk38u6mRfHXdnUc88=; b=El+j9CYH92/VkKvU0xX/iezFblXzbQBrsLh2hY6wa/mKGGMU40Uw1TuWpMCuy0pgxJ 5j25wvX86m18bmSl4JWCZOcYJgk4pkihBGHshqS6ZFUQ3VIwp5N3Sx3TYb8/S1ZWaUXX gi9MXhzcIjciT/IIbb4Y2gqBo4BOTJvuvt1CgX8wloUt0Cha3xzpy4q068L65lQYB+0O goNpAjrDRmeJjVeFBsddApKCxJ5eMSmOy5WS24SN7q1UKc5j3TwAvJKKYLQod5Fyz23R p0iYFyedNbgM2llrYVboI5n03letvmTsNNr+ABaInQsOGR85gbcJJeGWwNcalW1N833h C7FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969481; x=1685561481; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/Y4+dyjBVr8IC4wKpAH33RVK4Uwk38u6mRfHXdnUc88=; b=cQEWzQZcnc3tyGx2ESF2u1OO5bHyg7fA220AhbA1id46OJ1SZnzdWq8bncFcmOEOXJ SY73NsjvdjD2G+uSabkXcTmQYMeh+g+MsPxIAWSQLgxa/RDhxBc+gfZ9iDH369VRACT/ 5Qn8KPOAWV5o8y+OlYWcPGLVqn9g8h/R9hO6DpJ6Wve2jcNs89byEcPsGHKOO3/C7imO LNJHu0JRd52Ht6l7Jtr+P1EC2k3XJLkS4RlqMojsUEcpM9Rk/bXBq7/abh2p3JgqynPB oVZrdyHx+D/tqQmaCBGnaBkQLhS/O+fvQbiBLWxtXNHTHZzaoLUiJ5XdTdJOxHWFakEG VsAA== X-Gm-Message-State: AC+VfDwdl+hoM7Bsspho8fSWT16oionsMF0VrdstzPl/jE4x3U2w7U6V Hyu7LDggm3APUEAIyuEsJvbaSPCqByQ= X-Google-Smtp-Source: ACHHUZ7oF2OrgJXKm39RGRVXI1vKWuuYqbfsPQUZk89HXKREDFLA2mFb9YF3y3DhBgK9OOK1C/WqCg== X-Received: by 2002:ac8:5747:0:b0:3f2:1f2f:dc80 with SMTP id 7-20020ac85747000000b003f21f2fdc80mr6028725qtx.9.1682969481554; Mon, 01 May 2023 12:31:21 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Henry Wang , Community Manager Subject: [PATCH v3 14/14 RESEND] CHANGELOG: Add Intel HWP entry Date: Mon, 1 May 2023 15:30:34 -0400 Message-Id: <20230501193034.88575-15-jandryuk@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230501193034.88575-1-jandryuk@gmail.com> References: <20230501193034.88575-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Jason Andryuk Acked-by: Henry Wang --- v3: Position under existing Added section Add Henry's Ack v2: Add blank line --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5dbf8b06d7..2eb9e2cfd0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - Bus-lock detection, used by Xen to mitigate (by rate-limiting) the system wide impact of a guest misusing atomic instructions. - xl/libxl can customize SMBIOS strings for HVM guests. + - Add Intel Hardware P-States (HWP) cpufreq driver. ## [4.17.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE-4.17.0) - 2022-12-12 -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:40:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:40:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528215.821137 (Exim 4.92) (envelope-from ) id 1ptZNT-0006tx-9U; Mon, 01 May 2023 19:40:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528215.821137; Mon, 01 May 2023 19:40:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZNT-0006tV-1S; Mon, 01 May 2023 19:40:03 +0000 Received: by outflank-mailman (input) for mailman id 528215; Mon, 01 May 2023 19:40:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZF5-0000m4-8M for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:31:23 +0000 Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [2607:f8b0:4864:20::835]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c00e31df-e856-11ed-b225-6b7b168915f2; Mon, 01 May 2023 21:31:21 +0200 (CEST) Received: by mail-qt1-x835.google.com with SMTP id d75a77b69052e-3ef3ce7085bso12846761cf.2 for ; Mon, 01 May 2023 12:31:21 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id d6-20020ac80606000000b003bf9f9f1844sm9351784qth.71.2023.05.01.12.31.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:31:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c00e31df-e856-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969479; x=1685561479; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8XlrjFSqYpzQJQGdwHcwomspneq906r3odg2YJyUcgo=; b=ZIuYdu87cYcvUsSs9yRHdMP3Pm5GSwQX7w9kuI8lr30khecKw3o+OlElMPhyvABnrJ gmluE6uLnPxk7UG7YCcfHZ09VskA++s/5lNwNcL8uBI0ygSsE2yd/FAs/L4wPA/dADmj mz/pSaazJpvVfYBRmBPkf3yQIsyEtzTmHyiK6wFKzQIoUuy0eFTX95lH4LryFdZ8QlGc mpUhuxMhCZdalTvv135QKyZ5RBBJvgLVLI3EnjIJvrmqcrxpG5dAjwH1fRJm8b+q/mio DbsTwq7u5gfWM34SXiQxaAhatFXAMrRKNliQleEENClFijB/4MxYCoKTnPiDtgNawdSN yMIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969479; x=1685561479; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8XlrjFSqYpzQJQGdwHcwomspneq906r3odg2YJyUcgo=; b=BIz8e8BYpRK/c0MmjhLaisW85pkMujWutMchCow0M7by8mI/HpOY0xlmWmESh4jOq+ j+gL8zqXgX6gXoANRfccvJwB8Z1/xqt6vU8AB2SaFD0MPZvjGxtxZ0NC4VZFhFKLorCH wYU5bzQEEbpDranua9UUv2vDehJuIN1JI5qRN/C/YYBocqFsEqq56wchzPlUQt7PmSkr 56tfKTl7Rx0E8FYlEzxcQZsLdzy2LK4QQSMyT6cU7gag7fnpKf//NENPR5Ps7kXtubL6 rWtLRD0cyi/nUXnh17jaw5vSIuCe4FJ666nunpdo+ctDuh2KqX1XoNI6vLR1W0AmH2Er 1C6g== X-Gm-Message-State: AC+VfDxre9MGUTBmyXcDwfddT5WW4Xxh3VcUZFa4QwQRWFTU78zg2w22 Foh1aqqiskBsBx2WCEFr7ayGo/kZaF4= X-Google-Smtp-Source: ACHHUZ6s7TAWu0GGiaRBOmaYwJA7QeeEcnz3hfdXYDb9SCnyiJRNs+k3LepojJZ5B4tKUB1oeC0+xQ== X-Received: by 2002:ac8:5a54:0:b0:3ef:380a:d7bc with SMTP id o20-20020ac85a54000000b003ef380ad7bcmr22971561qta.54.1682969479398; Mon, 01 May 2023 12:31:19 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Wei Liu , Anthony PERARD Subject: [PATCH v3 13/14 RESEND] xenpm: Add set-cpufreq-hwp subcommand Date: Mon, 1 May 2023 15:30:33 -0400 Message-Id: <20230501193034.88575-14-jandryuk@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230501193034.88575-1-jandryuk@gmail.com> References: <20230501193034.88575-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit set-cpufreq-hwp allows setting the Hardware P-State (HWP) parameters. It can be run on all or just a single cpu. There are presets of balance, powersave & performance. Those can be further tweaked by param:val arguments as explained in the usage description. Parameter names are just checked to the first 3 characters to shorten typing. Some options are hardware dependent, and ranges can be found in get-cpufreq-para. Signed-off-by: Jason Andryuk --- v2: Compare provided parameter name and not just 3 characters. Use "-" in parameter names Remove hw_ Replace sscanf with strchr & strtoul. Remove toplevel error message with lower level ones. Help text s/127/128/ Help text mention truncation. Avoid some truncation rounding down by adding 5 before division. Help test mention default microseconds Also comment the limit check written to avoid overflow. --- tools/misc/xenpm.c | 230 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 230 insertions(+) diff --git a/tools/misc/xenpm.c b/tools/misc/xenpm.c index 6e74606970..8d99c78670 100644 --- a/tools/misc/xenpm.c +++ b/tools/misc/xenpm.c @@ -16,6 +16,7 @@ */ #define MAX_NR_CPU 512 +#include #include #include #include @@ -67,6 +68,27 @@ void show_help(void) " set-max-cstate |'unlimited' [|'unlimited']\n" " set the C-State limitation ( >= 0) and\n" " optionally the C-sub-state limitation ( >= 0)\n" + " set-cpufreq-hwp [cpuid] [balance|performance|powersave] *\n" + " set Hardware P-State (HWP) parameters\n" + " optionally a preset of one of\n" + " balance|performance|powersave\n" + " an optional list of param:val arguments\n" + " minimum:N lowest ... highest\n" + " maximum:N lowest ... highest\n" + " desired:N lowest ... highest\n" + " Set explicit performance target.\n" + " non-zero disables auto-HWP mode.\n" + " energy-perf:0-255 (or 0-15)\n" + " energy/performance hint\n" + " lower - favor performance\n" + " higher - favor powersave\n" + " 128 (or 7) - balance\n" + " act-window:N{,m,u}s range 1us-1270s\n" + " window for internal calculations.\n" + " Defaults to us without units.\n" + " Truncates un-representable values.\n" + " 0 lets the hardware decide.\n" + " get-cpufreq-para returns lowest/highest.\n" " start [seconds] start collect Cx/Px statistics,\n" " output after CTRL-C or SIGINT or several seconds.\n" " enable-turbo-mode [cpuid] enable Turbo Mode for processors that support it.\n" @@ -1299,6 +1321,213 @@ void disable_turbo_mode(int argc, char *argv[]) errno, strerror(errno)); } +/* + * Parse activity_window:NNN{us,ms,s} and validate range. + * + * Activity window is a 7bit mantissa (0-127) with a 3bit exponent (0-7) base + * 10 in microseconds. So the range is 1 microsecond to 1270 seconds. A value + * of 0 lets the hardware autonomously select the window. + * + * Return 0 on success + * -1 on error + */ +static int parse_activity_window(xc_set_hwp_para_t *set_hwp, unsigned long u, + const char *suffix) +{ + unsigned int exponent = 0; + unsigned int multiplier = 1; + + if ( suffix && suffix[0] ) + { + if ( strcasecmp(suffix, "s") == 0 ) + { + multiplier = 1000 * 1000; + exponent = 6; + } + else if ( strcasecmp(suffix, "ms") == 0 ) + { + multiplier = 1000; + exponent = 3; + } + else if ( strcasecmp(suffix, "us") == 0 ) + { + multiplier = 1; + exponent = 0; + } + else + { + fprintf(stderr, "invalid activity window units: \"%s\"\n", suffix); + + return -1; + } + } + + /* u * multipler > 1270 * 1000 * 1000 transformed to avoid overflow. */ + if ( u > 1270 * 1000 * 1000 / multiplier ) + { + fprintf(stderr, "activity window is too large\n"); + + return -1; + } + + /* looking for 7 bits of mantissa and 3 bits of exponent */ + while ( u > 127 ) + { + u += 5; /* Round up to mitigate truncation rounding down + e.g. 128 -> 120 vs 128 -> 130. */ + u /= 10; + exponent += 1; + } + + set_hwp->activity_window = (exponent & HWP_ACT_WINDOW_EXPONENT_MASK) << + HWP_ACT_WINDOW_EXPONENT_SHIFT | + (u & HWP_ACT_WINDOW_MANTISSA_MASK); + set_hwp->set_params |= XEN_SYSCTL_HWP_SET_ACT_WINDOW; + + return 0; +} + +static int parse_hwp_opts(xc_set_hwp_para_t *set_hwp, int *cpuid, + int argc, char *argv[]) +{ + int i = 0; + + if ( argc < 1 ) { + fprintf(stderr, "Missing arguments\n"); + return -1; + } + + if ( parse_cpuid_non_fatal(argv[i], cpuid) == 0 ) + { + i++; + } + + if ( i == argc ) { + fprintf(stderr, "Missing arguments\n"); + return -1; + } + + if ( strcasecmp(argv[i], "powersave") == 0 ) + { + set_hwp->set_params = XEN_SYSCTL_HWP_SET_PRESET_POWERSAVE; + i++; + } + else if ( strcasecmp(argv[i], "performance") == 0 ) + { + set_hwp->set_params = XEN_SYSCTL_HWP_SET_PRESET_PERFORMANCE; + i++; + } + else if ( strcasecmp(argv[i], "balance") == 0 ) + { + set_hwp->set_params = XEN_SYSCTL_HWP_SET_PRESET_BALANCE; + i++; + } + + for ( ; i < argc; i++) + { + unsigned long val; + char *param = argv[i]; + char *value; + char *suffix; + int ret; + + value = strchr(param, ':'); + if ( value == NULL ) + { + fprintf(stderr, "\"%s\" is an invalid hwp parameter\n", argv[i]); + return -1; + } + + value[0] = '\0'; + value++; + + errno = 0; + val = strtoul(value, &suffix, 10); + if ( (errno && val == ULONG_MAX) || value == suffix ) + { + fprintf(stderr, "Could not parse number \"%s\"\n", value); + return -1; + } + + if ( strncasecmp(param, "act-window", strlen(param)) == 0 ) + { + ret = parse_activity_window(set_hwp, val, suffix); + if (ret) + return -1; + + continue; + } + + if ( val > 255 ) + { + fprintf(stderr, "\"%s\" value \"%lu\" is out of range\n", param, + val); + return -1; + } + + if ( suffix && suffix[0] ) + { + fprintf(stderr, "Suffix \"%s\" is invalid\n", suffix); + return -1; + } + + if ( strncasecmp(param, "minimum", MAX(2, strlen(param))) == 0 ) + { + set_hwp->minimum = val; + set_hwp->set_params |= XEN_SYSCTL_HWP_SET_MINIMUM; + } + else if ( strncasecmp(param, "maximum", MAX(2, strlen(param))) == 0 ) + { + set_hwp->maximum = val; + set_hwp->set_params |= XEN_SYSCTL_HWP_SET_MAXIMUM; + } + else if ( strncasecmp(param, "desired", strlen(param)) == 0 ) + { + set_hwp->desired = val; + set_hwp->set_params |= XEN_SYSCTL_HWP_SET_DESIRED; + } + else if ( strncasecmp(param, "energy-perf", strlen(param)) == 0 ) + { + set_hwp->energy_perf = val; + set_hwp->set_params |= XEN_SYSCTL_HWP_SET_ENERGY_PERF; + } + else + { + fprintf(stderr, "\"%s\" is an invalid parameter\n", param); + return -1; + } + } + + if ( set_hwp->set_params == 0 ) + { + fprintf(stderr, "No parameters set in request\n"); + return -1; + } + + return 0; +} + +static void hwp_set_func(int argc, char *argv[]) +{ + xc_set_hwp_para_t set_hwp = {}; + int cpuid = -1; + int i = 0; + + if ( parse_hwp_opts(&set_hwp, &cpuid, argc, argv) ) + exit(EINVAL); + + if ( cpuid != -1 ) + { + i = cpuid; + max_cpu_nr = i + 1; + } + + for ( ; i < max_cpu_nr; i++ ) + if ( xc_set_cpufreq_hwp(xc_handle, i, &set_hwp) ) + fprintf(stderr, "[CPU%d] failed to set hwp params (%d - %s)\n", + i, errno, strerror(errno)); +} + struct { const char *name; void (*function)(int argc, char *argv[]); @@ -1309,6 +1538,7 @@ struct { { "get-cpufreq-average", cpufreq_func }, { "start", start_gather_func }, { "get-cpufreq-para", cpufreq_para_func }, + { "set-cpufreq-hwp", hwp_set_func }, { "set-scaling-maxfreq", scaling_max_freq_func }, { "set-scaling-minfreq", scaling_min_freq_func }, { "set-scaling-governor", scaling_governor_func }, -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Mon May 01 19:40:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 19:40:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528226.821157 (Exim 4.92) (envelope-from ) id 1ptZNf-0000i3-90; Mon, 01 May 2023 19:40:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528226.821157; Mon, 01 May 2023 19:40:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZNf-0000hr-50; Mon, 01 May 2023 19:40:15 +0000 Received: by outflank-mailman (input) for mailman id 528226; Mon, 01 May 2023 19:40:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZDG-0006PY-PR for xen-devel@lists.xenproject.org; Mon, 01 May 2023 19:29:30 +0000 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [2607:f8b0:4864:20::42b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 779418c1-e856-11ed-8611-37d641c3527e; Mon, 01 May 2023 21:29:18 +0200 (CEST) Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-64115eef620so29041064b3a.1 for ; Mon, 01 May 2023 12:29:18 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:644:937f:7f20::9a2c]) by smtp.googlemail.com with ESMTPSA id u8-20020a170902bf4800b0019c13d032d8sm18175622pls.253.2023.05.01.12.29.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 12:29:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 779418c1-e856-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682969358; x=1685561358; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5aCjEZJk/he0B507v8WHbAo+ayyw9u0whNe5hSh1Qc0=; b=AK+jJQIndwyipvZ3j74RRrDCnGWb55RfRTFZCAj1QjfEP6JtcEnkxab8VHfUxlnJqD nzyDIYAX6jvOrQqc9g/TswPCkcqNA0B0b+SVKLMEmNApHkelPozzZarkoTrP2UobldQU E6NqDV1CfueV3wQaPICMNftiMflroUHircwtbGv3hyeRwqO/KqZCxi3BNAP0dk8lYID7 5OwqBACQpi+nvrf0goZMdOfhVuRwRiXsUHvkFH+vRl0eIOaoeix6IqEc2ZJsYZWlONhr qoO4S8rXijotpMJHxa1FWYbjKdY7R5WGEGDzLNmBq3rOIwjAHcvHuIBKVpOdfgv+tSJ1 RDOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682969358; x=1685561358; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5aCjEZJk/he0B507v8WHbAo+ayyw9u0whNe5hSh1Qc0=; b=Lwm2/iKMyBKzWHFDNT6CQbT9wNIicJcXr9GFV6oipIRBsFPN8R2qwceOk3GDbzvpuQ WmvCpykB0c0dgcUhmLcv52tpOH1bUCdbCn53cvy/KZJusFiLvWgpb29VCUukRknAMrFC nm5eTm7DtHVWrf2ngjXqqjlNNawv2+HmdplDgDE+iR/TvThw74/rkTOlYmp7BXAo5DU3 1qxu1ZZkIoJwUfhoJBggXznvm5xkg6pjgSODZUiRUmI0kEF+VnPzTE64vLyKqgGZWHwM +Wxci3lrkutYk8P/j5J4NlAYMTaCFnNZu1CBFe8w5lmYdrKRJOAVK9JeIapTftwk9zgX IYIQ== X-Gm-Message-State: AC+VfDz+folEUK9Hc4TJqDjDFc5V9SfY+0DgA2EWzbNc4xwWE+kNeibH xjGlR4RNbYlNAh8n7bQc55Q= X-Google-Smtp-Source: ACHHUZ6t8R71ld5pjw9YJiJ63m1PjvmCLBjw2ONvK02V0vikRtqecj56I+goZm4GypngOeaNmv5J/w== X-Received: by 2002:a17:903:2307:b0:19a:96ea:3850 with SMTP id d7-20020a170903230700b0019a96ea3850mr18111173plh.17.1682969358236; Mon, 01 May 2023 12:29:18 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" , Yoshinori Sato Subject: [PATCH v2 30/34] sh: Convert pte_free_tlb() to use ptdescs Date: Mon, 1 May 2023 12:28:25 -0700 Message-Id: <20230501192829.17086-31-vishal.moola@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501192829.17086-1-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Also cleans up some spacing issues. Signed-off-by: Vishal Moola (Oracle) --- arch/sh/include/asm/pgalloc.h | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/sh/include/asm/pgalloc.h b/arch/sh/include/asm/pgalloc.h index a9e98233c4d4..ce2ba99dbd84 100644 --- a/arch/sh/include/asm/pgalloc.h +++ b/arch/sh/include/asm/pgalloc.h @@ -2,6 +2,7 @@ #ifndef __ASM_SH_PGALLOC_H #define __ASM_SH_PGALLOC_H +#include #include #define __HAVE_ARCH_PMD_ALLOC_ONE @@ -31,10 +32,10 @@ static inline void pmd_populate(struct mm_struct *mm, pmd_t *pmd, set_pmd(pmd, __pmd((unsigned long)page_address(pte))); } -#define __pte_free_tlb(tlb,pte,addr) \ -do { \ - pgtable_pte_page_dtor(pte); \ - tlb_remove_page((tlb), (pte)); \ +#define __pte_free_tlb(tlb, pte, addr) \ +do { \ + ptdesc_pte_dtor(page_ptdesc(pte)); \ + tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); \ } while (0) #endif /* __ASM_SH_PGALLOC_H */ -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon May 01 20:03:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 20:03:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528260.821176 (Exim 4.92) (envelope-from ) id 1ptZkC-0005IF-Bg; Mon, 01 May 2023 20:03:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528260.821176; Mon, 01 May 2023 20:03:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZkC-0005I8-8d; Mon, 01 May 2023 20:03:32 +0000 Received: by outflank-mailman (input) for mailman id 528260; Mon, 01 May 2023 20:03:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZkA-000525-Hn for xen-devel@lists.xenproject.org; Mon, 01 May 2023 20:03:30 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on20601.outbound.protection.outlook.com [2a01:111:f400:7e8a::601]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3d35e810-e85b-11ed-b225-6b7b168915f2; Mon, 01 May 2023 22:03:29 +0200 (CEST) Received: from MW4PR03CA0268.namprd03.prod.outlook.com (2603:10b6:303:b4::33) by PH0PR12MB5646.namprd12.prod.outlook.com (2603:10b6:510:143::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.26; Mon, 1 May 2023 20:03:26 +0000 Received: from CO1NAM11FT032.eop-nam11.prod.protection.outlook.com (2603:10b6:303:b4:cafe::2) by MW4PR03CA0268.outlook.office365.com (2603:10b6:303:b4::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31 via Frontend Transport; Mon, 1 May 2023 20:03:25 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT032.mail.protection.outlook.com (10.13.174.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.20 via Frontend Transport; Mon, 1 May 2023 20:03:25 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 1 May 2023 15:03:24 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 1 May 2023 15:03:24 -0500 Received: from ubuntu.mshome.net (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 1 May 2023 15:03:23 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3d35e810-e85b-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AqZ/4rh6XbSxYd/ji14LZGcdeDQm7k1Zf5I2jMgWISTCJQ6bOv/XM8vfQah/68DnRhSTvLxCc7W3vokeXrigee51mGOsPEshKNjiwG+eAeoey/MPhBLz6ZBtqUgGBkBLvpIrnuAznADUZuIBvsZsLgCBzaetN7XN7aNi1jUzpFJ6ohzNCVegBqXs6jklO0ZtD4KiG66P03HDUGzpfsGkTW4oQ4P7xJLsEzewlmzmbLSkFLcif/QLNXW273pwYQcFC/ACw7Flxk5sQBioJ3JgfnbpZAfUulSnIsP5XQKICWp7Rm09vfmfAD20JePEEadsPUdpxNm/4Kfw4f7g6AlCUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EAeerVBnHarRbBFzP8eA8mfPIPjOdFnbNXDV9Rw/NiY=; b=QKTFOr2+L6TT9LmB24VAx/aWHmqldaT3JSeJXYWsdZHO7R69uV27VtM2MUpQg+8eZr9yvGW2ZshF2E9SGG1VegUn/Bw4JV7FGHshBhWw71a11ts884Q1urNRq+ZMBHuXUpExRbAeLNzN6H+oJG+bK6oeNc16g+46Y0ab4Wc0WZnDLAweC2nrnLezZir7PxbAt5Coei5rwT7lqlGT3s74XN//E29UzWltuIsfw6YebLMPtknMXMkbik9lBB6P87scy9LdBYjtskVBLzjE2QtGQ/us7gb1IMsuZZ2RGioJY9kjZcNwLGpVClxAC5+3ituUgsHFZPBtTbPtKs2Zt81FBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EAeerVBnHarRbBFzP8eA8mfPIPjOdFnbNXDV9Rw/NiY=; b=J+gcXbHaoFZ2ByEWu0VdephSDtAPkF9GFpgvRlAYX+/c1laSPCC0xs0skpQ25VZZgpZpI9BEm1AbB2XJrgfWVRQ55arblnYE/Qrqx/6JwaAP34aZDx7JtOfbqJ2QYUaeY4/wr1SQY+tGnX7Zcx1veKlHWy4GcBD/o5eiRMZLDWs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Stewart Hildebrand To: CC: Oleksandr Tyshchenko , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Rahul Singh , Stewart Hildebrand Subject: [PATCH v1 1/6] xen/arm: Move is_protected flag to struct device Date: Mon, 1 May 2023 16:03:00 -0400 Message-ID: <20230501200305.168058-2-stewart.hildebrand@amd.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230501200305.168058-1-stewart.hildebrand@amd.com> References: <20230501200305.168058-1-stewart.hildebrand@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT032:EE_|PH0PR12MB5646:EE_ X-MS-Office365-Filtering-Correlation-Id: 893b28b4-cda2-406b-784b-08db4a7f1f8b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xdwpARfOl4Si5U24LX0KjYnqGjOBU6slMV5yPGtgU+00+WO8ucRcbsYJEzqWnOBWOzn2GtuwgKgqz82us3QSlrcrT7EQ68Ju2iYj427m2kVjTHekKlTDBsGb9zrRIggi3SSyCLaHYPX6O0Q4CB9xrnvIpEo4x9UI5TNyNa12bIPnknuqIiim94vREsajHTBP11NN8uHnp5YE2IZrXRajtGrrem7g9Fv6rVYKJn3aCi/Fx8tsvE29MvS/Ym07YWuWntsiuS5zkZCutGBBDzrsE4kDocgXXt2R1MR0K3dh0V3VpVDlsIV+I1fVMBtwu3B1NGDIY6GKSlk7FvynXEP+OwODXS8uaXfAlD3Rt0XQ3pFg3kma9oiNX00l1udfv0fUGgbyTlZo51Q2ZFXnEQ3Lu3eJ4Uy2LVtdTNMt87zIMuX0T+oMl+XAurCqySEJVmgH5BCld7/qB2efZiLXUEByPAXejZF9Z5cMWMeXa717K22QlFnDWY6BVVqJZsQ3aUhNtUZ4aEYw6i5sNiztEHYyS0hOl/6ZPWZN+GUbH6oePU9jxDiJVu8plJdE0DOFfl7hsQktn8wHy+LTGZeEFVqvoQkFc1B4laWI0ZOSpfe5rULMGetqeU2nblAiDBgkH6e+09/A6EJif3mxUUmOusE5NiX7y7WWCe6npL5FHO/EKrkApUNNfmGgC8f0lCzGHUqi2mQ7uReD/tHruIXmAbLDMz0Pm6SVGCBgzq4alRGjH7Y= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(39860400002)(376002)(136003)(451199021)(46966006)(40470700004)(36840700001)(70586007)(2906002)(70206006)(44832011)(2616005)(336012)(86362001)(5660300002)(82310400005)(4326008)(8936002)(40460700003)(36756003)(6666004)(41300700001)(6916009)(54906003)(478600001)(316002)(8676002)(40480700001)(356005)(26005)(81166007)(1076003)(966005)(82740400003)(47076005)(426003)(186003)(83380400001)(36860700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2023 20:03:25.2187 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 893b28b4-cda2-406b-784b-08db4a7f1f8b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT032.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5646 From: Oleksandr Tyshchenko This flag will be re-used for PCI devices by the subsequent patches. Signed-off-by: Oleksandr Tyshchenko Signed-off-by: Stewart Hildebrand --- downstream->v1: * rebase * s/dev_node->is_protected/dev_node->dev.is_protected/ in smmu.c * s/dt_device_set_protected(dev_to_dt(dev))/device_set_protected(dev)/ in smmu-v3.c * remove redundant device_is_protected checks in smmu-v3.c/ipmmu-vmsa.c (cherry picked from commit 59753aac77528a584d3950936b853ebf264b68e7 from the downstream branch poc/pci-passthrough from https://gitlab.com/xen-project/people/bmarquis/xen-arm-poc.git) --- xen/arch/arm/domain_build.c | 4 ++-- xen/arch/arm/include/asm/device.h | 13 +++++++++++++ xen/common/device_tree.c | 2 +- xen/drivers/passthrough/arm/ipmmu-vmsa.c | 8 +------- xen/drivers/passthrough/arm/smmu-v3.c | 7 +------ xen/drivers/passthrough/arm/smmu.c | 2 +- xen/drivers/passthrough/device_tree.c | 15 +++++++++------ xen/include/xen/device_tree.h | 13 ------------- 8 files changed, 28 insertions(+), 36 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index f80fdd1af206..106f92c65a61 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -2507,7 +2507,7 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev, return res; } - if ( dt_device_is_protected(dev) ) + if ( device_is_protected(dt_to_dev(dev)) ) { dt_dprintk("%s setup iommu\n", dt_node_full_name(dev)); res = iommu_assign_dt_device(d, dev); @@ -3007,7 +3007,7 @@ static int __init handle_passthrough_prop(struct kernel_info *kinfo, return res; /* If xen_force, we allow assignment of devices without IOMMU protection. */ - if ( xen_force && !dt_device_is_protected(node) ) + if ( xen_force && !device_is_protected(dt_to_dev(node)) ) return 0; return iommu_assign_dt_device(kinfo->d, node); diff --git a/xen/arch/arm/include/asm/device.h b/xen/arch/arm/include/asm/device.h index b5d451e08776..086dde13eb6b 100644 --- a/xen/arch/arm/include/asm/device.h +++ b/xen/arch/arm/include/asm/device.h @@ -1,6 +1,8 @@ #ifndef __ASM_ARM_DEVICE_H #define __ASM_ARM_DEVICE_H +#include + enum device_type { DEV_DT, @@ -20,6 +22,7 @@ struct device #endif struct dev_archdata archdata; struct iommu_fwspec *iommu_fwspec; /* per-device IOMMU instance data */ + bool is_protected; /* Shows that device is protected by IOMMU */ }; typedef struct device device_t; @@ -94,6 +97,16 @@ int device_init(struct dt_device_node *dev, enum device_class class, */ enum device_class device_get_class(const struct dt_device_node *dev); +static inline void device_set_protected(struct device *device) +{ + device->is_protected = true; +} + +static inline bool device_is_protected(const struct device *device) +{ + return device->is_protected; +} + #define DT_DEVICE_START(_name, _namestr, _class) \ static const struct device_desc __dev_desc_##_name __used \ __section(".dev.info") = { \ diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index 6c9712ab7bda..1d5d7cb5f01b 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -1874,7 +1874,7 @@ static unsigned long __init unflatten_dt_node(const void *fdt, /* By default dom0 owns the device */ np->used_by = 0; /* By default the device is not protected */ - np->is_protected = false; + np->dev.is_protected = false; INIT_LIST_HEAD(&np->domain_list); if ( new_format ) diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c b/xen/drivers/passthrough/arm/ipmmu-vmsa.c index 091f09b21752..039212a3a990 100644 --- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c +++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c @@ -1288,14 +1288,8 @@ static int ipmmu_add_device(u8 devfn, struct device *dev) if ( !to_ipmmu(dev) ) return -ENODEV; - if ( dt_device_is_protected(dev_to_dt(dev)) ) - { - dev_err(dev, "Already added to IPMMU\n"); - return -EEXIST; - } - /* Let Xen know that the master device is protected by an IOMMU. */ - dt_device_set_protected(dev_to_dt(dev)); + device_set_protected(dev); dev_info(dev, "Added master device (IPMMU %s micro-TLBs %u)\n", dev_name(fwspec->iommu_dev), fwspec->num_ids); diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index bfdb62b395ad..4b452e6fdd00 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -1521,13 +1521,8 @@ static int arm_smmu_add_device(u8 devfn, struct device *dev) */ arm_smmu_enable_pasid(master); - if (dt_device_is_protected(dev_to_dt(dev))) { - dev_err(dev, "Already added to SMMUv3\n"); - return -EEXIST; - } - /* Let Xen know that the master device is protected by an IOMMU. */ - dt_device_set_protected(dev_to_dt(dev)); + device_set_protected(dev); dev_info(dev, "Added master device (SMMUv3 %s StreamIds %u)\n", dev_name(fwspec->iommu_dev), fwspec->num_ids); diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c index 0a514821b336..5b6024d579a8 100644 --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -838,7 +838,7 @@ static int arm_smmu_dt_add_device_legacy(struct arm_smmu_device *smmu, master->of_node = dev_node; /* Xen: Let Xen know that the device is protected by an SMMU */ - dt_device_set_protected(dev_node); + device_set_protected(dev); for (i = 0; i < fwspec->num_ids; ++i) { if (!(smmu->features & ARM_SMMU_FEAT_STREAM_MATCH) && diff --git a/xen/drivers/passthrough/device_tree.c b/xen/drivers/passthrough/device_tree.c index 1c32d7b50cce..b5bd13393b56 100644 --- a/xen/drivers/passthrough/device_tree.c +++ b/xen/drivers/passthrough/device_tree.c @@ -34,7 +34,7 @@ int iommu_assign_dt_device(struct domain *d, struct dt_device_node *dev) if ( !is_iommu_enabled(d) ) return -EINVAL; - if ( !dt_device_is_protected(dev) ) + if ( !device_is_protected(dt_to_dev(dev)) ) return -EINVAL; spin_lock(&dtdevs_lock); @@ -65,7 +65,7 @@ int iommu_deassign_dt_device(struct domain *d, struct dt_device_node *dev) if ( !is_iommu_enabled(d) ) return -EINVAL; - if ( !dt_device_is_protected(dev) ) + if ( !device_is_protected(dt_to_dev(dev)) ) return -EINVAL; spin_lock(&dtdevs_lock); @@ -87,7 +87,7 @@ static bool_t iommu_dt_device_is_assigned(const struct dt_device_node *dev) { bool_t assigned = 0; - if ( !dt_device_is_protected(dev) ) + if ( !device_is_protected(dt_to_dev(dev)) ) return 0; spin_lock(&dtdevs_lock); @@ -141,12 +141,15 @@ int iommu_add_dt_device(struct dt_device_node *np) return -EINVAL; /* - * The device may already have been registered. As there is no harm in - * it just return success early. + * This is needed in case a device has both the iommus property and + * also appears in the mmu-masters list. */ - if ( dev_iommu_fwspec_get(dev) ) + if ( device_is_protected(dev) ) return 0; + if ( dev_iommu_fwspec_get(dev) ) + return -EEXIST; + /* * According to the Documentation/devicetree/bindings/iommu/iommu.txt * from Linux. diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index 19a74909cece..c1e4751a581f 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -90,9 +90,6 @@ struct dt_device_node { struct dt_device_node *next; /* TODO: Remove it. Only use to know the last children */ struct dt_device_node *allnext; - /* IOMMU specific fields */ - bool is_protected; - /* HACK: Remove this if there is a need of space */ bool_t static_evtchn_created; @@ -302,16 +299,6 @@ static inline domid_t dt_device_used_by(const struct dt_device_node *device) return device->used_by; } -static inline void dt_device_set_protected(struct dt_device_node *device) -{ - device->is_protected = true; -} - -static inline bool dt_device_is_protected(const struct dt_device_node *device) -{ - return device->is_protected; -} - static inline bool_t dt_property_name_is_equal(const struct dt_property *pp, const char *name) { -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon May 01 20:03:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 20:03:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528259.821167 (Exim 4.92) (envelope-from ) id 1ptZk7-00052I-3I; Mon, 01 May 2023 20:03:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528259.821167; Mon, 01 May 2023 20:03:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZk6-00052B-WD; Mon, 01 May 2023 20:03:27 +0000 Received: by outflank-mailman (input) for mailman id 528259; Mon, 01 May 2023 20:03:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZk5-000525-M9 for xen-devel@lists.xenproject.org; Mon, 01 May 2023 20:03:25 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2060d.outbound.protection.outlook.com [2a01:111:f400:7e8a::60d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 39bd0846-e85b-11ed-b225-6b7b168915f2; Mon, 01 May 2023 22:03:23 +0200 (CEST) Received: from MW3PR05CA0005.namprd05.prod.outlook.com (2603:10b6:303:2b::10) by IA1PR12MB8465.namprd12.prod.outlook.com (2603:10b6:208:457::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Mon, 1 May 2023 20:03:20 +0000 Received: from CO1NAM11FT057.eop-nam11.prod.protection.outlook.com (2603:10b6:303:2b:cafe::6) by MW3PR05CA0005.outlook.office365.com (2603:10b6:303:2b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.19 via Frontend Transport; Mon, 1 May 2023 20:03:20 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT057.mail.protection.outlook.com (10.13.174.205) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.19 via Frontend Transport; Mon, 1 May 2023 20:03:19 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 1 May 2023 15:03:17 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 1 May 2023 15:03:17 -0500 Received: from ubuntu.mshome.net (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 1 May 2023 15:03:16 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 39bd0846-e85b-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QQOsvCMqYd8qQjX0QFmzLrSvL9+DDAv4jeMzHToQMYI8CGlCdFDaOahp3pi0Qs5wTYCw2NB4iic//VMqT7mipmTD3VHhGU+wmazb6G7efiTIKt5kgrbE6muiqwNA2Vj+ePz+S/5TTPuLrnU4VwugTBnejlOelCOIn1h5Qu5Ezt7RGse3C+6JI9X3H0Pt2w3Mx0zewYfuRaC36DWt9tlX9WtAS1/pb3O+xoNSr6kTOPOp5L+ctLabSUV8qSjLy0SO2IlyHVjii381WdXHI7s7CyE2QyG1mfECsdLmhfi4soRafxRMVGvbcSR27rb4diXKAtrlfpxGXJ7TynORa09qwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6GirXXEDtjoXkR1fOhQzNZVltrkp/AltBpvuxHRBipc=; b=Vbh3HA4PQFKPVxWgMTHavXQecjpUWeTnKhCpDlZpsqnNdskA1ndcxQ/VCR0gB+SopsxT48iM/HUD+Jh/FXF7vWM118oMs6KSHPd5UoFZYAqJ42sI0qDEjCUiy5dCI2CrxhSjgS0ykjA30sSi6oH8/+lxWNCWIvCyZoQkY2EZe+WHRg21ysWM7stB81LTGf9W6VJ0d1UnIXLGX5DYfv6kKCxtTs4MYUgGpUWazGSWCDATE4Ve9YpCbDvz88G+ppAKo+1r5LlLIPajOaaPcR8vagW95WiLgB0DYAeGn7rXX10l9ERCIOy1er8PGyXmlWQpnHRCV4dUuexSs9OLJutmkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6GirXXEDtjoXkR1fOhQzNZVltrkp/AltBpvuxHRBipc=; b=wnzxJZE9oSTKtjJVF02QvcRTFBSLq2xhdq/qhYhwRclNtktYCy0vMPlAf2G1tjJJUKeyKgjqPVf4s2/DmPYgred8oQ0RLGUbb0w5n57nguQUl0zwJInxciQUBYpeGrpbLSgOFiJTKoBrhtcvK0UhAvyRj4T7MUFIgsouV3gfa+E= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Stewart Hildebrand To: CC: Stewart Hildebrand , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Rahul Singh , Jan Beulich , "Paul Durrant" , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v1 0/6] SMMU handling for PCIe Passthrough on ARM Date: Mon, 1 May 2023 16:02:59 -0400 Message-ID: <20230501200305.168058-1-stewart.hildebrand@amd.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT057:EE_|IA1PR12MB8465:EE_ X-MS-Office365-Filtering-Correlation-Id: dcc40ebc-cf7f-4ede-478e-08db4a7f1c4c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GffGYe5j4IS26DKLP1tkkPygp9s995dyvMsZ0d96T184J2bCdhBmwtjtggEV8uQmVMMok/8kP3/gScPTB2C+EpLYCdaMTeL12H3myegyHbC3v/p1d7morXWTsnwQSXckL080iHWxeQiq/8k8/5TtPyNr9jklkiJ+YfcunzWKlciszxeKUhQSJ1zbrZ5ew8+FxZG/Kd9kmDw9Vkp8r6mR6zDE1Shfq4mNyz3dc/D2p0WuZWbXA9urQBmcgKLdDH8wjepa5/iCuHH59tpx7Tf02fxk3mwsPpF0T/0f886bbjxL/Twf4lA+K6cok1rsIRrE2FJ8dYUF+VO+gqd/VN/0kMrZL7yhI0QEflnjuyqfkd0FDwilrHIIc58yqOYcOXd2o1Kofef/UbLN06KKr6OU9KauXWlBMc5pZ+cjL6oanTDm7A4iBV+zqFbK+RO8Vn0rwDDqZSVhPSu+KvhxjtQqDX28wBWSSg8sx8aycFHh4CyGyV1NYag4ll5dz47X56uWnB0x+UoEPqRxw16K++vt5cAqdUxVvrryThR3FB//l5/h/E/zuf9Pn69nBuhQj4TVs0in7ywlF6KW4MPBgguroVUayOWFI7qY1uZxyx2qejrVGDfPgUhqhm9UkP7vuwcrz6pPokuNgB2in/KQGnPgvsVXkY4j1IO89Jq4LhErE1GzlQxzx6+tXcoI6G6zM1t7nGxQ8yPMazSWhCXqs/b4+xOECIrGnFxmkVbSz9ybbZk= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(346002)(39860400002)(376002)(451199021)(40470700004)(36840700001)(46966006)(2616005)(336012)(426003)(2906002)(36860700001)(26005)(1076003)(8936002)(41300700001)(81166007)(5660300002)(83380400001)(44832011)(8676002)(47076005)(316002)(82740400003)(40460700003)(6916009)(4326008)(70586007)(70206006)(356005)(186003)(36756003)(86362001)(54906003)(40480700001)(6666004)(478600001)(82310400005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2023 20:03:19.7557 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dcc40ebc-cf7f-4ede-478e-08db4a7f1c4c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT057.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8465 This series introduces SMMU handling for PCIe passthrough on ARM. These patches are independent from (and don't depend on) the vPCI reference counting/locking work in progress, and should be able to be upstreamed independently. I have cherry-picked them from various downstream branches, rebased, and made minor changes since the cherry-pick. Details are in the individual patches. The changes are designated with "downstream->v1" even though this is the first time the patches appear on the list. Oleksandr Andrushchenko (1): xen/arm: smmuv2: Add PCI devices support for SMMUv2 Oleksandr Tyshchenko (4): xen/arm: Move is_protected flag to struct device iommu/arm: Add iommu_dt_xlate() iommu/arm: Introduce iommu_add_dt_pci_device API pci/arm: Use iommu_add_dt_pci_device() instead of arch hook Rahul Singh (1): xen/arm: smmuv3: Add PCI devices support for SMMUv3 xen/arch/arm/domain_build.c | 4 +- xen/arch/arm/include/asm/device.h | 13 ++ xen/common/device_tree.c | 2 +- xen/drivers/passthrough/arm/ipmmu-vmsa.c | 8 +- xen/drivers/passthrough/arm/smmu-v3.c | 73 +++++++- xen/drivers/passthrough/arm/smmu.c | 109 +++++++++--- xen/drivers/passthrough/device_tree.c | 202 ++++++++++++++++++++--- xen/drivers/passthrough/pci.c | 19 ++- xen/include/xen/device_tree.h | 38 +++-- xen/include/xen/iommu.h | 6 +- 10 files changed, 395 insertions(+), 79 deletions(-) -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon May 01 20:03:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 20:03:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528261.821187 (Exim 4.92) (envelope-from ) id 1ptZkJ-0005cr-Pz; Mon, 01 May 2023 20:03:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528261.821187; Mon, 01 May 2023 20:03:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZkJ-0005ci-MW; Mon, 01 May 2023 20:03:39 +0000 Received: by outflank-mailman (input) for mailman id 528261; Mon, 01 May 2023 20:03:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZkI-000525-PU for xen-devel@lists.xenproject.org; Mon, 01 May 2023 20:03:38 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2062f.outbound.protection.outlook.com [2a01:111:f400:fe5a::62f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 41eb799f-e85b-11ed-b225-6b7b168915f2; Mon, 01 May 2023 22:03:37 +0200 (CEST) Received: from BN8PR16CA0024.namprd16.prod.outlook.com (2603:10b6:408:4c::37) by CO6PR12MB5409.namprd12.prod.outlook.com (2603:10b6:5:357::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Mon, 1 May 2023 20:03:34 +0000 Received: from BN8NAM11FT091.eop-nam11.prod.protection.outlook.com (2603:10b6:408:4c:cafe::db) by BN8PR16CA0024.outlook.office365.com (2603:10b6:408:4c::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30 via Frontend Transport; Mon, 1 May 2023 20:03:34 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT091.mail.protection.outlook.com (10.13.176.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.20 via Frontend Transport; Mon, 1 May 2023 20:03:33 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 1 May 2023 15:03:33 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 1 May 2023 13:03:33 -0700 Received: from ubuntu.mshome.net (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 1 May 2023 15:03:32 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 41eb799f-e85b-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LV0L+cf9/+6ujJZdLT8zIve3cMVi3MpH41QJrGA7CHEm4Q4bUgznShMOcJt80isbi9oScwHO1tQ1yyN3pIDsqUe+E7XujEyBxWcPnls5z+p9VQWlKlB70yRnCYYzwqn871TmJIxOy5oJAD66NMnTqB9khf4gHY9KBMLyvXp4XL5Ee1wlPhyptlXCJShRqGTkbLEf8GdJDo9mTysBEVa+lLk38YgZS1ro4EHmMkSO9NBNVvo7m1Fm50VriNcN/N166twvnQqR8dfTvRfX+bv71eowKXkprixLgMQDcnAqoFplhmJD96R7otYw+YqwGqEZyPyOyN5DRxs/iuZLJQGgOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FH3cbOq7w4Ry4gUimwrCXWO3YUo9mU/EEVtFtBj29+A=; b=Twdih1oH9w/ylQfYLwykufELuND7MvGz+L/nnqynK0t/AHIlrRbSbnnDENCuAAxSoEjoypXDVhFIttZhiDZLBETdIcTw6nO0TnVwRpa9jkKPWZW4DCKwl1wjZMpKibXe7M8eAM+MJKUk1FYPGQNs6JksM9ikY26W3FebZPogpwDfAtZgYYAkeNnJDHykR6pIUIaaEmyCr49zLoQ0t5MVim3EKe4TrYcvlOo73xznYS6t7HDiMWvpJb4wOde5rfFMv6YiQOsEX7EIAeXoOhCvGsfAzXmo1aEhxF58RSkQ0ndqxKfkdAy6P9UBNxOqc3BfqeBiRos0SyPNOZEToalGKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FH3cbOq7w4Ry4gUimwrCXWO3YUo9mU/EEVtFtBj29+A=; b=gb1DePfI6A2wEm5sog39kHFHnEzCTWnFg/y79Tfmwd7O9JC+dexz5WD0EsN0L/u8sVvH8KofezLyqcwpLE8qO91o7KxMBBkDCsIyLBGw2t5HgjJm+krxhwy1KoPEjXQAaBhMp3tWIBHwnj45KRfvobpb7zEt3gXCtG99yI2ZRys= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Stewart Hildebrand To: CC: Oleksandr Tyshchenko , Stefano Stabellini , Julien Grall , Stewart Hildebrand Subject: [PATCH v1 2/6] iommu/arm: Add iommu_dt_xlate() Date: Mon, 1 May 2023 16:03:01 -0400 Message-ID: <20230501200305.168058-3-stewart.hildebrand@amd.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230501200305.168058-1-stewart.hildebrand@amd.com> References: <20230501200305.168058-1-stewart.hildebrand@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT091:EE_|CO6PR12MB5409:EE_ X-MS-Office365-Filtering-Correlation-Id: 8cebc486-355f-4c39-d618-08db4a7f24ac X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: haDaEyABepE2+Gd97f0WweYm957fdnjDqu1y9Tqk61FEjA6lT5xKt7LwNaydMWmDZ7I77xuy/Eucn1nzrilsG0x2MRPlZ6GUNpGtsMeapI+R0MoHXR3v4yg5xJqQueT06qoj833NWBAwI62BrhrxtNdOHfto+V82EP0/L/v2ZuytWl7rlVhtXb5byFjLVkqE/KxDbi7zuysm+xt8CvtwkHcoMTWcoypxKsz4vv7NeDQHM5vqtM/+pOwZ7AsqhX3Ny6GugI6iHPgOmNAqZVSCB7x2Z2HFeDhqkfmYy19JhxAcWpRxvc0xIgmPLQhAu88/hP8/U0ThVo73FAtloxfAO5lwm0JcyJCwHnehxPrnAdqyEKkeLbdgG26ng5sro0C/Yt4490vxFu9bsyRG1dhnPYZM+7iG/lB6WcAHLMI2VnJHIZkR9nLJWlqCAkP4a11l3Y/blD/UUAP6avM1NlzZp3hldQIKacjtEzL5HCfdqCV3XztBx2fogf5qh2q+Rq+OEU9nl0jh1fJNf5UOJQi6/3y2crM5H9gQYArHlJlHZynt/H9se1LT72kJtXhog26qf1OZoCGRwLC1whvSvosNTBqOenFL7jlzrr8PY6KFwBbrMJbFV2QrlssW9NUmz/GY5kr/8IaE+0BJuDAzBdRWxPlCk5DmC/vcNQ1jRuHbXBVeLPQhh9Hi6B3i4oTNk231YaSN2ECcCmHuILieZvkqmzW1Fj9Sk6Ec301LZWjMIIo= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(136003)(346002)(376002)(451199021)(46966006)(36840700001)(40470700004)(40480700001)(82310400005)(40460700003)(316002)(2616005)(4326008)(1076003)(336012)(426003)(70586007)(41300700001)(47076005)(83380400001)(36860700001)(26005)(478600001)(54906003)(70206006)(6916009)(6666004)(966005)(186003)(356005)(82740400003)(2906002)(36756003)(81166007)(86362001)(44832011)(8936002)(8676002)(5660300002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2023 20:03:33.9197 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8cebc486-355f-4c39-d618-08db4a7f24ac X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT091.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5409 From: Oleksandr Tyshchenko Move code for processing DT IOMMU specifier to a separate helper. This helper will be re-used for adding PCI devices by the subsequent patches as we will need exact the same actions for processing DT PCI-IOMMU specifier. While at it introduce NO_IOMMU to avoid magic "1". Signed-off-by: Oleksandr Tyshchenko Signed-off-by: Stewart Hildebrand # rename --- downstream->v1: * trivial rebase * s/dt_iommu_xlate/iommu_dt_xlate/ (cherry picked from commit c26bab0415ca303df86aba1d06ef8edc713734d3 from the downstream branch poc/pci-passthrough from https://gitlab.com/xen-project/people/bmarquis/xen-arm-poc.git) --- xen/drivers/passthrough/device_tree.c | 42 +++++++++++++++++---------- 1 file changed, 27 insertions(+), 15 deletions(-) diff --git a/xen/drivers/passthrough/device_tree.c b/xen/drivers/passthrough/device_tree.c index b5bd13393b56..1b50f4670944 100644 --- a/xen/drivers/passthrough/device_tree.c +++ b/xen/drivers/passthrough/device_tree.c @@ -127,15 +127,39 @@ int iommu_release_dt_devices(struct domain *d) return 0; } +/* This correlation must not be altered */ +#define NO_IOMMU 1 + +static int iommu_dt_xlate(struct device *dev, + struct dt_phandle_args *iommu_spec) +{ + const struct iommu_ops *ops = iommu_get_ops(); + int rc; + + if ( !dt_device_is_available(iommu_spec->np) ) + return NO_IOMMU; + + rc = iommu_fwspec_init(dev, &iommu_spec->np->dev); + if ( rc ) + return rc; + + /* + * Provide DT IOMMU specifier which describes the IOMMU master + * interfaces of that device (device IDs, etc) to the driver. + * The driver is responsible to decide how to interpret them. + */ + return ops->dt_xlate(dev, iommu_spec); +} + int iommu_add_dt_device(struct dt_device_node *np) { const struct iommu_ops *ops = iommu_get_ops(); struct dt_phandle_args iommu_spec; struct device *dev = dt_to_dev(np); - int rc = 1, index = 0; + int rc = NO_IOMMU, index = 0; if ( !iommu_enabled ) - return 1; + return NO_IOMMU; if ( !ops ) return -EINVAL; @@ -164,19 +188,7 @@ int iommu_add_dt_device(struct dt_device_node *np) if ( !ops->add_device || !ops->dt_xlate ) return -EINVAL; - if ( !dt_device_is_available(iommu_spec.np) ) - break; - - rc = iommu_fwspec_init(dev, &iommu_spec.np->dev); - if ( rc ) - break; - - /* - * Provide DT IOMMU specifier which describes the IOMMU master - * interfaces of that device (device IDs, etc) to the driver. - * The driver is responsible to decide how to interpret them. - */ - rc = ops->dt_xlate(dev, &iommu_spec); + rc = iommu_dt_xlate(dev, &iommu_spec); if ( rc ) break; -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon May 01 20:03:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 20:03:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528264.821197 (Exim 4.92) (envelope-from ) id 1ptZkX-0006HD-2d; Mon, 01 May 2023 20:03:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528264.821197; Mon, 01 May 2023 20:03:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZkW-0006H5-W9; Mon, 01 May 2023 20:03:52 +0000 Received: by outflank-mailman (input) for mailman id 528264; Mon, 01 May 2023 20:03:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZkV-000525-Du for xen-devel@lists.xenproject.org; Mon, 01 May 2023 20:03:51 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on20627.outbound.protection.outlook.com [2a01:111:f400:7e8a::627]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 492ecb6f-e85b-11ed-b225-6b7b168915f2; Mon, 01 May 2023 22:03:49 +0200 (CEST) Received: from MW4P223CA0027.NAMP223.PROD.OUTLOOK.COM (2603:10b6:303:80::32) by DM4PR12MB8497.namprd12.prod.outlook.com (2603:10b6:8:180::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Mon, 1 May 2023 20:03:46 +0000 Received: from CO1NAM11FT049.eop-nam11.prod.protection.outlook.com (2603:10b6:303:80:cafe::d8) by MW4P223CA0027.outlook.office365.com (2603:10b6:303:80::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30 via Frontend Transport; Mon, 1 May 2023 20:03:45 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT049.mail.protection.outlook.com (10.13.175.50) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.20 via Frontend Transport; Mon, 1 May 2023 20:03:44 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 1 May 2023 15:03:43 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 1 May 2023 13:03:43 -0700 Received: from ubuntu.mshome.net (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 1 May 2023 15:03:42 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 492ecb6f-e85b-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=itY6LV+fQEhdFUOO4+G6drQvRa474rhgPkD3dElQ0n/CBoSn8ViLrJrFWXL0XthXLcqkYQa4m/3lQeMxjBTXOFk45z2VajOni1UCp732CiKiGaTby8K7KeWqVO2xHu+krlZz+goTIIyTXhNBAcrGp0BQAHLb+InkVvU0efz/ydHGhM4UlwII2d2ZwPSMzNqzKjI+SK422/dSJ9qiJR7EKNCWNUNACoDZsH76dL8ABNjQj94+Gw6gOWAMexnLLfFaqWaX0J7untUGwARtqAz0HAJJwfmYRaAIn77UFHJjg9BGWaP8c2EnagZ5yM8FT0VL/l12GEyQp40dIcJ0WmhaAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tPTXU+0KLiFp2//TpisX/eYI6MvOPIIjwmGHW7rytQA=; b=SCNFZJ+Em/zIOeUhRJtm8k7cfah0bZqbMPBJuS0C8mxSAZydfHaDhI5FTp02ltEQ9QZuR5ijMBtTrTYNeZhn6wo5tuPFmHDFS4ogn9ELo8Dl7qs5qV0dow/bpkMG/LwYgi7bTARS+fhF9QZQCNAF7qufAxusRw9W3lNBk54cWHJrj2S5Z3TCys6Mj8q0xCWJvRA2hdRZMf0IHW0Yz3dPuj9wNiHTUdS6qlLCgigpInM/QAp49sF/vTMG8DW5jDKzfXDCwomhNeL6TyGX0OunrJtUPLAKHUSbNt2Jn8Htz1TgrZGpGjubApSmx7Z5SV4F5MtPzDN/FoBRri1x8RMQKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tPTXU+0KLiFp2//TpisX/eYI6MvOPIIjwmGHW7rytQA=; b=jNewda7fLrpIonms0NAPfIMB+Z/unDJRI/jFgpuewQo+7kr+Wxp+YpQVJhBtUKHry0KPItf/CDe3kdm6JcTvwq8uLRwTRxba1hvi01bgtncVEnUj2h3S0XSULc8bfTz7NDDxldtMPNx9FFe+Ztvt50Npabv6+E23nvRJhvMJLdc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Stewart Hildebrand To: CC: Oleksandr Tyshchenko , Stefano Stabellini , Julien Grall , Jan Beulich , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , "Stewart Hildebrand" Subject: [PATCH v1 3/6] iommu/arm: Introduce iommu_add_dt_pci_device API Date: Mon, 1 May 2023 16:03:02 -0400 Message-ID: <20230501200305.168058-4-stewart.hildebrand@amd.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230501200305.168058-1-stewart.hildebrand@amd.com> References: <20230501200305.168058-1-stewart.hildebrand@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT049:EE_|DM4PR12MB8497:EE_ X-MS-Office365-Filtering-Correlation-Id: 47adc05a-10e5-4517-7712-08db4a7f2b49 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zETcY6KrC2KwwoH7dFvA7/l0iOb8nsC9CPbbncqRqnkpP6ZYaumC5eRjNFJsaBg+7QwQBFb3n8gHlmr/VJRW2zHNeYWHDJjauwprvXR9kW59I31UxauinjSppIWrZqdvpXCwyXs99UGC98/0XjvJMHMf9OWTl9DyyQKKwLmKxh8QiZ46WgXI10Xo4kdV+KBukgyuXgMj2D4+CFOpeJNbGyUbmRgCwqvLG6fuphV7D5MYHzLw9biDZNTvvR0sKTz2aCZELbgYSHHUuxIFxHlgL66/61mhQD+swFhY9mDXWNuehZkQJIn5zsL3ZQWmyrrR63DrsJD+xH7KCpXJ9Eky88x6s/Kv+mzZl0XwfKmGnJ6Ys80RxFRm7W+Qv6mIgFjkSbAOhQS3jE+L3AJDhu6w/QnPlJmBxkJs+O5PKyeDhOxTaxPfx/c3wy+LmPjmWex5mIVFqFYqeXfgOQyJq31McKkQs2tnw0PIcojYlPVegi61BKuA3tJ6mRqtYYzGd+hTy9g20Z/e191wRRQPw0AI79O1ckbQ/d0mi+i0JpfMmjnMY8Ys4U/B3BsTAzw/eYCQR2NfLQcALrnnxrm5Q9MlSnd0B6VINEF9oSwsByv68zE9yEHxvromlyH+ty8GcxPzDg7BuFnMMdtaXKZtKThOLQywjQter5XpjUlh1YnvGTNAN3uoGMQ7ScYtOQV+1/LO0b9UeGinCtMg3+56aRaNPEBP66TI+6X6rOcGNgsNM4Kr4WMCU/JQHhYZPRPA2zA8RNVUX5Lc75jf/3WoefU3qsYbWHUO0EpQQ/C3LaaLJkQ= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(396003)(346002)(136003)(451199021)(40470700004)(36840700001)(46966006)(356005)(81166007)(8936002)(82310400005)(478600001)(8676002)(82740400003)(6916009)(86362001)(40480700001)(4326008)(70586007)(70206006)(41300700001)(36756003)(54906003)(316002)(40460700003)(36860700001)(2906002)(83380400001)(47076005)(44832011)(966005)(186003)(1076003)(26005)(426003)(336012)(2616005)(5660300002)(6666004)(21314003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2023 20:03:44.9031 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 47adc05a-10e5-4517-7712-08db4a7f2b49 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT049.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB8497 From: Oleksandr Tyshchenko The main purpose of this patch is to add a way to register PCI device (which is behind the IOMMU) using the generic PCI-IOMMU DT bindings [1] before assigning that device to a domain. This behaves in almost the same way as existing iommu_add_dt_device API, the difference is in devices to handle and DT bindings to use. The function of_map_id to translate an ID through a downstream mapping (which is also suitable for mapping Requester ID) was borrowed from Linux (v5.10-rc6) and updated according to the Xen code base. XXX: I don't port pci_for_each_dma_alias from Linux which is a part of PCI-IOMMU bindings infrastucture as I don't have a good understanding for how it is expected to work in Xen environment. Also it is not completely clear whether we need to distinguish between different PCI types here (DEV_TYPE_PCI, DEV_TYPE_PCI_HOST_BRIDGE, etc). For example, how we should behave here if the host bridge doesn't have a stream ID (so not described in iommu-map property) just simple fail or bypasses translation? [1] https://www.kernel.org/doc/Documentation/devicetree/bindings/pci/pci-iommu.txt Signed-off-by: Oleksandr Tyshchenko Signed-off-by: Stewart Hildebrand --- downstream->v1: * rebase * add const qualifier to struct dt_device_node *np arg in dt_map_id() * add const qualifier to struct dt_device_node *np declaration in iommu_add_pci_device() * use stdint.h types instead of u8/u32/etc... * rename functions: s/dt_iommu_xlate/iommu_dt_xlate/ s/dt_map_id/iommu_dt_pci_map_id/ s/iommu_add_pci_device/iommu_add_dt_pci_device/ * add device_is_protected check in iommu_add_dt_pci_device * wrap prototypes in CONFIG_HAS_PCI (cherry picked from commit 734e3bf6ee77e7947667ab8fa96c25b349c2e1da from the downstream branch poc/pci-passthrough from https://gitlab.com/xen-project/people/bmarquis/xen-arm-poc.git) --- xen/drivers/passthrough/device_tree.c | 145 ++++++++++++++++++++++++++ xen/include/xen/device_tree.h | 25 +++++ xen/include/xen/iommu.h | 6 +- 3 files changed, 175 insertions(+), 1 deletion(-) diff --git a/xen/drivers/passthrough/device_tree.c b/xen/drivers/passthrough/device_tree.c index 1b50f4670944..ef98f343eef2 100644 --- a/xen/drivers/passthrough/device_tree.c +++ b/xen/drivers/passthrough/device_tree.c @@ -151,6 +151,151 @@ static int iommu_dt_xlate(struct device *dev, return ops->dt_xlate(dev, iommu_spec); } +#ifdef CONFIG_HAS_PCI +int iommu_dt_pci_map_id(const struct dt_device_node *np, uint32_t id, + const char *map_name, const char *map_mask_name, + struct dt_device_node **target, uint32_t *id_out) +{ + uint32_t map_mask, masked_id, map_len; + const __be32 *map = NULL; + + if ( !np || !map_name || (!target && !id_out) ) + return -EINVAL; + + map = dt_get_property(np, map_name, &map_len); + if ( !map ) + { + if ( target ) + return -ENODEV; + /* Otherwise, no map implies no translation */ + *id_out = id; + return 0; + } + + if ( !map_len || map_len % (4 * sizeof(*map)) ) + { + printk(XENLOG_ERR "%pOF: Error: Bad %s length: %d\n", np, + map_name, map_len); + return -EINVAL; + } + + /* The default is to select all bits. */ + map_mask = 0xffffffff; + + /* + * Can be overridden by "{iommu,msi}-map-mask" property. + * If of_property_read_u32() fails, the default is used. + */ + if ( map_mask_name ) + dt_property_read_u32(np, map_mask_name, &map_mask); + + masked_id = map_mask & id; + for ( ; (int)map_len > 0; map_len -= 4 * sizeof(*map), map += 4 ) + { + struct dt_device_node *phandle_node; + uint32_t id_base = be32_to_cpup(map + 0); + uint32_t phandle = be32_to_cpup(map + 1); + uint32_t out_base = be32_to_cpup(map + 2); + uint32_t id_len = be32_to_cpup(map + 3); + + if ( id_base & ~map_mask ) + { + printk(XENLOG_ERR "%pOF: Invalid %s translation - %s-mask (0x%x) ignores id-base (0x%x)\n", + np, map_name, map_name, map_mask, id_base); + return -EFAULT; + } + + if ( masked_id < id_base || masked_id >= id_base + id_len ) + continue; + + phandle_node = dt_find_node_by_phandle(phandle); + if ( !phandle_node ) + return -ENODEV; + + if ( target ) + { + if ( !*target ) + *target = phandle_node; + + if ( *target != phandle_node ) + continue; + } + + if ( id_out ) + *id_out = masked_id - id_base + out_base; + + printk(XENLOG_DEBUG "%pOF: %s, using mask %08x, id-base: %08x, out-base: %08x, length: %08x, id: %08x -> %08x\n", + np, map_name, map_mask, id_base, out_base, id_len, id, + masked_id - id_base + out_base); + return 0; + } + + printk(XENLOG_ERR "%pOF: no %s translation for id 0x%x on %pOF\n", + np, map_name, id, target && *target ? *target : NULL); + + /* + * NOTE: Linux bypasses translation without returning an error here, + * but should we behave in the same way on Xen? Restrict for now. + */ + return -EFAULT; +} + +int iommu_add_dt_pci_device(uint8_t devfn, struct pci_dev *pdev) +{ + const struct iommu_ops *ops = iommu_get_ops(); + struct dt_phandle_args iommu_spec = { .args_count = 1 }; + struct device *dev = pci_to_dev(pdev); + const struct dt_device_node *np; + int rc = NO_IOMMU; + + if ( !iommu_enabled ) + return NO_IOMMU; + + if ( !ops ) + return -EINVAL; + + if ( device_is_protected(dev) ) + return 0; + + if ( dev_iommu_fwspec_get(dev) ) + return -EEXIST; + + np = pci_find_host_bridge_node(pdev); + if ( !np ) + return -ENODEV; + + /* + * According to the Documentation/devicetree/bindings/pci/pci-iommu.txt + * from Linux. + */ + rc = iommu_dt_pci_map_id(np, PCI_BDF(pdev->bus, devfn), "iommu-map", + "iommu-map-mask", &iommu_spec.np, iommu_spec.args); + if ( rc ) + return rc == -ENODEV ? NO_IOMMU : rc; + + /* + * The driver which supports generic PCI-IOMMU DT bindings must have + * these callback implemented. + */ + if ( !ops->add_device || !ops->dt_xlate ) + return -EINVAL; + + rc = iommu_dt_xlate(dev, &iommu_spec); + + /* + * Add master device to the IOMMU if latter is present and available. + * The driver is responsible to mark that device as protected. + */ + if ( !rc ) + rc = ops->add_device(devfn, dev); + + if ( rc < 0 ) + iommu_fwspec_free(dev); + + return rc; +} +#endif /* CONFIG_HAS_PCI */ + int iommu_add_dt_device(struct dt_device_node *np) { const struct iommu_ops *ops = iommu_get_ops(); diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index c1e4751a581f..dc40fdfb9231 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -852,6 +852,31 @@ int dt_count_phandle_with_args(const struct dt_device_node *np, */ int dt_get_pci_domain_nr(struct dt_device_node *node); +#ifdef CONFIG_HAS_PCI +/** + * iommu_dt_pci_map_id - Translate an ID through a downstream mapping. + * @np: root complex device node. + * @id: device ID to map. + * @map_name: property name of the map to use. + * @map_mask_name: optional property name of the mask to use. + * @target: optional pointer to a target device node. + * @id_out: optional pointer to receive the translated ID. + * + * Given a device ID, look up the appropriate implementation-defined + * platform ID and/or the target device which receives transactions on that + * ID, as per the "iommu-map" and "msi-map" bindings. Either of @target or + * @id_out may be NULL if only the other is required. If @target points to + * a non-NULL device node pointer, only entries targeting that node will be + * matched; if it points to a NULL value, it will receive the device node of + * the first matching target phandle, with a reference held. + * + * Return: 0 on success or a standard error code on failure. + */ +int iommu_dt_pci_map_id(const struct dt_device_node *np, uint32_t id, + const char *map_name, const char *map_mask_name, + struct dt_device_node **target, uint32_t *id_out); +#endif /* CONFIG_HAS_PCI */ + struct dt_device_node *dt_find_node_by_phandle(dt_phandle handle); #ifdef CONFIG_DEVICE_TREE_DEBUG diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h index 405db59971c5..d1b91ec13056 100644 --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -219,7 +219,8 @@ int iommu_dt_domain_init(struct domain *d); int iommu_release_dt_devices(struct domain *d); /* - * Helper to add master device to the IOMMU using generic IOMMU DT bindings. + * Helpers to add master device to the IOMMU using generic (PCI-)IOMMU + * DT bindings. * * Return values: * 0 : device is protected by an IOMMU @@ -228,6 +229,9 @@ int iommu_release_dt_devices(struct domain *d); * (IOMMU is not enabled/present or device is not connected to it). */ int iommu_add_dt_device(struct dt_device_node *np); +#ifdef CONFIG_HAS_PCI +int iommu_add_dt_pci_device(uint8_t devfn, struct pci_dev *pdev); +#endif int iommu_do_dt_domctl(struct xen_domctl *, struct domain *, XEN_GUEST_HANDLE_PARAM(xen_domctl_t)); -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon May 01 20:03:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 20:03:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528267.821206 (Exim 4.92) (envelope-from ) id 1ptZkd-0006ht-BY; Mon, 01 May 2023 20:03:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528267.821206; Mon, 01 May 2023 20:03:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZkd-0006hf-8Y; Mon, 01 May 2023 20:03:59 +0000 Received: by outflank-mailman (input) for mailman id 528267; Mon, 01 May 2023 20:03:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZkb-000525-TZ for xen-devel@lists.xenproject.org; Mon, 01 May 2023 20:03:57 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20621.outbound.protection.outlook.com [2a01:111:f400:fe5b::621]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4da851d7-e85b-11ed-b225-6b7b168915f2; Mon, 01 May 2023 22:03:57 +0200 (CEST) Received: from MW4PR03CA0347.namprd03.prod.outlook.com (2603:10b6:303:dc::22) by PH7PR12MB6762.namprd12.prod.outlook.com (2603:10b6:510:1ac::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Mon, 1 May 2023 20:03:54 +0000 Received: from CO1NAM11FT009.eop-nam11.prod.protection.outlook.com (2603:10b6:303:dc:cafe::6f) by MW4PR03CA0347.outlook.office365.com (2603:10b6:303:dc::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30 via Frontend Transport; Mon, 1 May 2023 20:03:53 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT009.mail.protection.outlook.com (10.13.175.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.20 via Frontend Transport; Mon, 1 May 2023 20:03:53 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 1 May 2023 15:03:52 -0500 Received: from ubuntu.mshome.net (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 1 May 2023 15:03:51 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4da851d7-e85b-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kROiZiIA4cLY5yWmMHra6ZecDER05QnXBno6CzGvKXzhwDgCyKrGVlEPPgn/rNBwAgR1jrCnRxA2hQQOWonC+FtQCrJGCHlGXs6pznkhTTM5jiY6TtIwXK7w8uC8PgowZKMEchEkURt7km7cZs/lDfuZh3PMUiq1VO6/XkxD5HiirYAqh1GN3NDD72RnW7WkhZ4uEnAVKu2FYBl1TavXZNNGLskiOks0LbTYnevVJzklDh6np18XRLv0qm4Xj2Xzavk8pFWVgd4/h5s0et2N6Umxn2gML0nGqzxKxdk/9SkOMwPViUZNlj962I4soEyAcO0DquBlHo5IxPvUcuVz9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eCX9DqGe9db1MXdGpEVHFk+gaS1vUShIki9NWo1vZU8=; b=XO7Yk9gqBVOU/nHgCjzj2TFvEhNxvXbSdpfvjGNIgyuCp0TF/Z7ULuNkGAZqor4CUMI9bAt0QR0C4EAL30I5vDnD6adLd+P2NZCW1X0mQaD5NW/7xzab9Lsscv3JcRVEk22CgbmM6rzrPvTOo3juMicDJKU4slGdTMcsQSE/3KtQ+BxLCpEF+MW7MFJUg1KxXhivuwbezGodE/UIpM07M10SuQ4xKE3f1FvCpP6XHyKJNor3AVrfQ+qk5B2LbmK0bO2NrD9IUtSkX4yyigj9EKxyyOQp+DvYSzajyrj+UuRkdk7G5Eweg+f6N5WKfvetMzbo2O7gSWn08PtDelfsVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eCX9DqGe9db1MXdGpEVHFk+gaS1vUShIki9NWo1vZU8=; b=u6LVLwI4G8an8UAnAZJc5KrGq37sRtf2keRD7tgB68K13JORbuPahCiJNZ6Ad9RhA0Feglb28tXME2tbuPOJy3ypGAdzflHQx8fWEilft0to8nrEo+78umjhBK8W7CKthmZeAFjagIGilBKXkpZEwnIacYug4vOBoxGGKgpJLnE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Stewart Hildebrand To: CC: Oleksandr Tyshchenko , Jan Beulich , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , "Stewart Hildebrand" Subject: [PATCH v1 4/6] pci/arm: Use iommu_add_dt_pci_device() instead of arch hook Date: Mon, 1 May 2023 16:03:03 -0400 Message-ID: <20230501200305.168058-5-stewart.hildebrand@amd.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230501200305.168058-1-stewart.hildebrand@amd.com> References: <20230501200305.168058-1-stewart.hildebrand@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT009:EE_|PH7PR12MB6762:EE_ X-MS-Office365-Filtering-Correlation-Id: 0ca6b476-853d-4ff2-67e4-08db4a7f304c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7g/OblPUtzx8aUQCo+wrnlELHWK8d/3yT/7x8z4fxDDsK6vZilApLcJcT1ONO5Xd36v6KASu6wpfvxrxTHAxnKr8jr99rlNe0xqiOOIexd1PYYUU80stkiJL+eevWuQCTTRCt/2qeVIB0VA+DpSvdxfNiCXkxx64MpjaJ/JwO3tNXNOQmk07zDkS0wdNpv/T2u45o3YnX/2BelJFF/DmVQzCYk43H4ygqUGshEmtRax/1fA5DPXXQ+4MShljL6k8ze+OZDwYb25jJH5n/wEfXZC3Tje2q5/LfKahoH31IXJkg7EnAj907GcBe8gTgpDP7bYSZhmn++zi1ksBozYDaGfyfPHDxpc3MPdzj/7DdbnuHVcfBQ9ZFY+GWbxA6A8a8Vcgjla27SC4iLaMDJflgEsV9jowhF9eC3wcWLBJ9cu+77OojR2MsCE6mtEfF9cqXDuDVDS+dEnueYdLUyjvzyt+VWaMxZIR/omB9qIrvAhO2b/Rvvnlc+yxFSHCprelCo2BCIE033BQkrsECbMPew88JsshxhThwu5yb0FMUmfIO8sH8TgxXQ5jrC8OdXsMAtmazRH+8Ho2M+zY25Gkew2slxPNyVXPQfRwC4a7zVPqeCIp9rY/TWV8yOZfJ+riT0ehFfgbmywyk2YSdQo1VsvRiNAHMuXKSrPx202NDqU+5eRRNUwI3zYKwsIrhMMpX5oRCZKWSF1WL25N8LAnlZq+4WvGtnE80/xeXHi92Zk= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(136003)(396003)(39860400002)(451199021)(46966006)(36840700001)(40470700004)(86362001)(36756003)(81166007)(82740400003)(356005)(8676002)(5660300002)(8936002)(41300700001)(4326008)(70206006)(316002)(6916009)(44832011)(2906002)(40480700001)(70586007)(82310400005)(336012)(2616005)(47076005)(426003)(40460700003)(36860700001)(6666004)(966005)(54906003)(478600001)(186003)(83380400001)(1076003)(26005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2023 20:03:53.3266 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0ca6b476-853d-4ff2-67e4-08db4a7f304c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT009.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6762 From: Oleksandr Tyshchenko On Arm we need to parse DT PCI-IOMMU specifier and provide it to the driver (for describing the relationship between PCI devices and IOMMUs) before adding a device to it. Also clarify the check of the return value as iommu_add_pci_device can return >0 if a device doesn't need to be protected by the IOMMU and print a warning if iommu_add_pci_device failed. Signed-off-by: Oleksandr Tyshchenko Signed-off-by: Stewart Hildebrand --- downstream->v1: * rebase * add __maybe_unused attribute to const struct domain_iommu *hd; * Rename: s/iommu_add_pci_device/iommu_add_dt_pci_device/ * guard iommu_add_dt_pci_device call with CONFIG_HAS_DEVICE_TREE instead of CONFIG_ARM (cherry picked from commit 2b9d26badab8b24b5a80d028c4499a5022817213 from the downstream branch poc/pci-passthrough from https://gitlab.com/xen-project/people/bmarquis/xen-arm-poc.git) --- xen/drivers/passthrough/pci.c | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c index b42acb8d7c09..ed5a6ede7847 100644 --- a/xen/drivers/passthrough/pci.c +++ b/xen/drivers/passthrough/pci.c @@ -1305,7 +1305,7 @@ __initcall(setup_dump_pcidevs); static int iommu_add_device(struct pci_dev *pdev) { - const struct domain_iommu *hd; + const struct domain_iommu *hd __maybe_unused; int rc; unsigned int devfn = pdev->devfn; @@ -1318,17 +1318,30 @@ static int iommu_add_device(struct pci_dev *pdev) if ( !is_iommu_enabled(pdev->domain) ) return 0; +#ifdef CONFIG_HAS_DEVICE_TREE + rc = iommu_add_dt_pci_device(devfn, pdev); +#else rc = iommu_call(hd->platform_ops, add_device, devfn, pci_to_dev(pdev)); - if ( rc || !pdev->phantom_stride ) +#endif + if ( rc < 0 || !pdev->phantom_stride ) + { + if ( rc < 0 ) + printk(XENLOG_WARNING "IOMMU: add %pp failed (%d)\n", + &pdev->sbdf, rc); return rc; + } for ( ; ; ) { devfn += pdev->phantom_stride; if ( PCI_SLOT(devfn) != PCI_SLOT(pdev->devfn) ) return 0; +#ifdef CONFIG_HAS_DEVICE_TREE + rc = iommu_add_dt_pci_device(devfn, pdev); +#else rc = iommu_call(hd->platform_ops, add_device, devfn, pci_to_dev(pdev)); - if ( rc ) +#endif + if ( rc < 0 ) printk(XENLOG_WARNING "IOMMU: add %pp failed (%d)\n", &PCI_SBDF(pdev->seg, pdev->bus, devfn), rc); } -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon May 01 20:04:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 20:04:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528269.821217 (Exim 4.92) (envelope-from ) id 1ptZkl-0007EO-R2; Mon, 01 May 2023 20:04:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528269.821217; Mon, 01 May 2023 20:04:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZkl-0007EB-Ni; Mon, 01 May 2023 20:04:07 +0000 Received: by outflank-mailman (input) for mailman id 528269; Mon, 01 May 2023 20:04:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZkl-000525-2K for xen-devel@lists.xenproject.org; Mon, 01 May 2023 20:04:07 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2060a.outbound.protection.outlook.com [2a01:111:f400:7eaa::60a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 52e8df08-e85b-11ed-b225-6b7b168915f2; Mon, 01 May 2023 22:04:06 +0200 (CEST) Received: from MW4PR04CA0113.namprd04.prod.outlook.com (2603:10b6:303:83::28) by MW4PR12MB8611.namprd12.prod.outlook.com (2603:10b6:303:1ed::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Mon, 1 May 2023 20:04:02 +0000 Received: from CO1NAM11FT094.eop-nam11.prod.protection.outlook.com (2603:10b6:303:83:cafe::eb) by MW4PR04CA0113.outlook.office365.com (2603:10b6:303:83::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30 via Frontend Transport; Mon, 1 May 2023 20:04:02 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT094.mail.protection.outlook.com (10.13.174.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.20 via Frontend Transport; Mon, 1 May 2023 20:04:02 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 1 May 2023 15:04:01 -0500 Received: from ubuntu.mshome.net (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 1 May 2023 15:04:00 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52e8df08-e85b-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZOVMIRE2X7DPxKGPPVVzf7wJDjSP53mki8qz8xlrnp5JOFFthx4rcshJAdot3F2v8sraPYe6ZTyzYNF+DXw7GyeEth/skLrL3MSTQhLi4P1ByfBifMQdyMEM0orS0DCijZcriPoSooiyp7c8dAYxiAfvF+KobmA22oVi3PY7dhmzjoibJip1ITuFpRWGqd2a0UiOfG7+89fQa86ZUctZX8DX/kvfc1a7dlnnq7mJjssbnnzzPiOUsSeoPKpwr8lqOk1QvX5N3iHuaRBPgeBDx7u6W8lo5G9dH2yR5jRxNEJ/DR3Ya5CQjiPfsBJ+y6CwEIuWu33EjsvQVQarYxRCGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kw1Pv3wUj5s9KFrgoBEyVCO4rA7mTJkBr2g4lQl2H8w=; b=EYGB6wIAiZ9jLGggDl6UEyNcXjvDUmK119KnWwRtAeFoYhlRd3kdoxJGliaklqmMabLqrk3Ks4MQKN+WYzcBpXdf0PToK7Q50kA/4/lV7kc302Z/2nnYJfA0RG+yThRWtlkL3ZPwR2wnUXn/RbrQjdEVjR6MTtO9s0Ym6/8O+ziANJtf+fhQJQOABAKANcWApT6wLsnXotcjVKwvCH/aIW7h3f1wk7fW+N+6az8pAuIbGX6w4qDjck04HGrP6dDeXnjws5Oo1Yg+drdvfhDVnUiOMuBapkvWYHYrmOARp0nyRJblCqK2yPzs1j5L+F6DseDCTFIsoIJLhJhGnQKG5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kw1Pv3wUj5s9KFrgoBEyVCO4rA7mTJkBr2g4lQl2H8w=; b=I38jmhxkLb05puhi8QlR6wZNDFyOaw+N1ZD7/elqOyzmNG/cWCNJEXk27AM45lHr7boYHJ14PwP2IJUDgio1r6e2YRUqbZLhIqEDmFcU+KcUf6Ly4nA7g/yAAfWpnwcUW1e1cD1tNGnZ1szY7Vvlemau4UPx3gYZmjFvW3SAEXg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Stewart Hildebrand To: CC: Oleksandr Andrushchenko , Julien Grall , Rahul Singh , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Oleksandr Tyshchenko , Stewart Hildebrand Subject: [PATCH v1 5/6] xen/arm: smmuv2: Add PCI devices support for SMMUv2 Date: Mon, 1 May 2023 16:03:04 -0400 Message-ID: <20230501200305.168058-6-stewart.hildebrand@amd.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230501200305.168058-1-stewart.hildebrand@amd.com> References: <20230501200305.168058-1-stewart.hildebrand@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT094:EE_|MW4PR12MB8611:EE_ X-MS-Office365-Filtering-Correlation-Id: ed2ed5ad-8a9a-413d-094a-08db4a7f35af X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +ZUzcqKSKb3/OI8rYGlrEmYKUZY8tcNjGtQFCxHTOLyAGpS6qYwFdkOuL5xEmiDaIC2/OBSuQq8Eo+olxWxjMg5Z/qETCyJi9SoCY/ggxZuCty/Eq8/JziUP97iIPffxLASYoGSachstTALfjB3ZLEoAqgFk11dgWIxLjWayvKpn3u3vmhulbijKxOdeWN2jYaDDJ9PT8KDHc0pfNf9kshGQL3jy+fru5srpfrhlUxKEukpkJfneyl9XUcMr8gEsXVgptqDkn712vFmhdTUJecfLc7HAd/HzX/dnQu8W9pGm7IMq6mSph5gCMbxealJ3jit53ZrAGzbTDtGTgS4y+A/c9om+OG34XGg4K/wPP9foXxE9//4mPvVTe2xf1ShDgFQWAjXlXhuURUvXftraPkYvWJlM0/kAyB9M3t2MMyBUxRLCJj6BZzURVmAMDr8gX+w01V5+HwWX8clRlfoljYBQDMnYWYOz37TkRTLci6O+aMDjnoyx7uetEY1hlTcVc+xRi8lauClr2wXpqf5oE87CM1tyUQm+vqACIoGyPTljpu+1GMgyGF9vHtvKc1OHdLa9U9luW3X3jSLqErARM8l0F0iDdS40QupU7YIZPML3n5XYCKJVq7fwYr5Lx+7zyhPEUr53pthe1RqkGY/cyt/odC2ihj2K5JjZySs/pNMv74yshT5czVNSram4dcDnAXXJMJvQVrW+k3oQiZeqeLwH3toGERurUYlXDbQVwqIMttN/jTwPfdASIQvYfHe3acku1MMWSH/VxEvbS0VCs34pyJtTYcO85n6BdgXWv/E= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(136003)(39860400002)(376002)(451199021)(36840700001)(46966006)(40470700004)(4326008)(6916009)(82740400003)(186003)(5660300002)(36756003)(316002)(70586007)(70206006)(2906002)(41300700001)(356005)(81166007)(966005)(86362001)(83380400001)(47076005)(478600001)(426003)(336012)(54906003)(2616005)(1076003)(26005)(8936002)(82310400005)(36860700001)(40460700003)(8676002)(40480700001)(44832011)(21314003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2023 20:04:02.3460 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ed2ed5ad-8a9a-413d-094a-08db4a7f35af X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT094.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB8611 From: Oleksandr Andrushchenko Signed-off-by: Oleksandr Tyshchenko Signed-off-by: Oleksandr Andrushchenko Signed-off-by: Stewart Hildebrand --- downstream->v1: * wrap unused function in #ifdef 0 * remove the remove_device() stub since it was submitted separately to the list [XEN][PATCH v5 07/17] xen/smmu: Add remove_device callback for smmu_iommu ops https://lists.xenproject.org/archives/html/xen-devel/2023-04/msg00432.html * arm_smmu_(de)assign_dev: return error instead of crashing system * update condition in arm_smmu_reassign_dev * style fixup * add && !is_hardware_domain(d) into condition in arm_smmu_assign_dev() (cherry picked from commit 0c11a7f65f044c26d87d1e27ac6283ef1f9cfb7a from the downstream branch spider-master from https://github.com/xen-troops/xen.git) --- This is a file imported from Linux with modifications for Xen. What should be the coding style for Xen modifications? --- xen/drivers/passthrough/arm/smmu.c | 107 +++++++++++++++++++++++------ 1 file changed, 86 insertions(+), 21 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c index 5b6024d579a8..c33f583f424a 100644 --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -134,8 +134,20 @@ typedef enum irqreturn irqreturn_t; /* Device logger functions * TODO: Handle PCI */ -#define dev_print(dev, lvl, fmt, ...) \ - printk(lvl "smmu: %s: " fmt, dt_node_full_name(dev_to_dt(dev)), ## __VA_ARGS__) +#ifndef CONFIG_HAS_PCI +#define dev_print(dev, lvl, fmt, ...) \ + printk(lvl "smmu: %s: " fmt, dev_name(dev), ## __VA_ARGS__) +#else +#define dev_print(dev, lvl, fmt, ...) ({ \ + if ( !dev_is_pci((dev)) ) \ + printk(lvl "smmu: %s: " fmt, dev_name((dev)), ## __VA_ARGS__); \ + else \ + { \ + struct pci_dev *pdev = dev_to_pci((dev)); \ + printk(lvl "smmu: %pp: " fmt, &pdev->sbdf, ## __VA_ARGS__); \ + } \ +}) +#endif #define dev_dbg(dev, fmt, ...) dev_print(dev, XENLOG_DEBUG, fmt, ## __VA_ARGS__) #define dev_notice(dev, fmt, ...) dev_print(dev, XENLOG_INFO, fmt, ## __VA_ARGS__) @@ -187,6 +199,7 @@ static void __iomem *devm_ioremap_resource(struct device *dev, * Xen: PCI functions * TODO: It should be implemented when PCI will be supported */ +#if 0 /* unused */ #define to_pci_dev(dev) (NULL) static inline int pci_for_each_dma_alias(struct pci_dev *pdev, int (*fn) (struct pci_dev *pdev, @@ -196,6 +209,7 @@ static inline int pci_for_each_dma_alias(struct pci_dev *pdev, BUG(); return 0; } +#endif /* Xen: misc */ #define PHYS_MASK_SHIFT PADDR_BITS @@ -632,7 +646,7 @@ struct arm_smmu_master_cfg { for (i = 0; idx = cfg->smendx[i], i < num; ++i) struct arm_smmu_master { - struct device_node *of_node; + struct device *dev; struct rb_node node; struct arm_smmu_master_cfg cfg; }; @@ -724,7 +738,7 @@ arm_smmu_get_fwspec(struct arm_smmu_master_cfg *cfg) { struct arm_smmu_master *master = container_of(cfg, struct arm_smmu_master, cfg); - return dev_iommu_fwspec_get(&master->of_node->dev); + return dev_iommu_fwspec_get(master->dev); } static void parse_driver_options(struct arm_smmu_device *smmu) @@ -757,7 +771,7 @@ static struct device_node *dev_get_dev_node(struct device *dev) } static struct arm_smmu_master *find_smmu_master(struct arm_smmu_device *smmu, - struct device_node *dev_node) + struct device *dev) { struct rb_node *node = smmu->masters.rb_node; @@ -766,9 +780,9 @@ static struct arm_smmu_master *find_smmu_master(struct arm_smmu_device *smmu, master = container_of(node, struct arm_smmu_master, node); - if (dev_node < master->of_node) + if (dev < master->dev) node = node->rb_left; - else if (dev_node > master->of_node) + else if (dev > master->dev) node = node->rb_right; else return master; @@ -803,9 +817,9 @@ static int insert_smmu_master(struct arm_smmu_device *smmu, = container_of(*new, struct arm_smmu_master, node); parent = *new; - if (master->of_node < this->of_node) + if (master->dev < this->dev) new = &((*new)->rb_left); - else if (master->of_node > this->of_node) + else if (master->dev > this->dev) new = &((*new)->rb_right); else return -EEXIST; @@ -824,18 +838,18 @@ static int arm_smmu_dt_add_device_legacy(struct arm_smmu_device *smmu, struct arm_smmu_master *master; struct device_node *dev_node = dev_get_dev_node(dev); - master = find_smmu_master(smmu, dev_node); + master = find_smmu_master(smmu, dev); if (master) { dev_err(dev, "rejecting multiple registrations for master device %s\n", - dev_node->name); + dev_node ? dev_node->name : ""); return -EBUSY; } master = devm_kzalloc(dev, sizeof(*master), GFP_KERNEL); if (!master) return -ENOMEM; - master->of_node = dev_node; + master->dev = dev; /* Xen: Let Xen know that the device is protected by an SMMU */ device_set_protected(dev); @@ -845,7 +859,7 @@ static int arm_smmu_dt_add_device_legacy(struct arm_smmu_device *smmu, (fwspec->ids[i] >= smmu->num_mapping_groups)) { dev_err(dev, "stream ID for master device %s greater than maximum allowed (%d)\n", - dev_node->name, smmu->num_mapping_groups); + dev_node ? dev_node->name : "", smmu->num_mapping_groups); return -ERANGE; } master->cfg.smendx[i] = INVALID_SMENDX; @@ -912,11 +926,10 @@ static struct arm_smmu_device *find_smmu_for_device(struct device *dev) { struct arm_smmu_device *smmu; struct arm_smmu_master *master = NULL; - struct device_node *dev_node = dev_get_dev_node(dev); spin_lock(&arm_smmu_devices_lock); list_for_each_entry(smmu, &arm_smmu_devices, list) { - master = find_smmu_master(smmu, dev_node); + master = find_smmu_master(smmu, dev); if (master) break; } @@ -2006,6 +2019,7 @@ static bool arm_smmu_capable(enum iommu_cap cap) } #endif +#if 0 /* Not used */ static int __arm_smmu_get_pci_sid(struct pci_dev *pdev, u16 alias, void *data) { *((u16 *)data) = alias; @@ -2016,6 +2030,7 @@ static void __arm_smmu_release_pci_iommudata(void *data) { kfree(data); } +#endif static int arm_smmu_add_device(struct device *dev) { @@ -2023,12 +2038,13 @@ static int arm_smmu_add_device(struct device *dev) struct arm_smmu_master_cfg *cfg; struct iommu_group *group; void (*releasefn)(void *) = NULL; - int ret; smmu = find_smmu_for_device(dev); if (!smmu) return -ENODEV; + /* There is no need to distinguish here, thanks to PCI-IOMMU DT bindings */ +#if 0 if (dev_is_pci(dev)) { struct pci_dev *pdev = to_pci_dev(dev); struct iommu_fwspec *fwspec; @@ -2053,10 +2069,12 @@ static int arm_smmu_add_device(struct device *dev) &fwspec->ids[0]); releasefn = __arm_smmu_release_pci_iommudata; cfg->smmu = smmu; - } else { + } else +#endif + { struct arm_smmu_master *master; - master = find_smmu_master(smmu, dev->of_node); + master = find_smmu_master(smmu, dev); if (!master) { return -ENODEV; } @@ -2724,6 +2742,31 @@ static int arm_smmu_assign_dev(struct domain *d, u8 devfn, return -ENOMEM; } +#ifdef CONFIG_HAS_PCI + if ( dev_is_pci(dev) && !is_hardware_domain(d) ) + { + struct pci_dev *pdev = dev_to_pci(dev); + + printk(XENLOG_INFO "Assigning device %04x:%02x:%02x.%u to dom%d\n", + pdev->seg, pdev->bus, PCI_SLOT(devfn), PCI_FUNC(devfn), + d->domain_id); + + /* + * XXX What would be the proper behavior? This could happen if + * pdev->phantom_stride > 0 + */ + if ( devfn != pdev->devfn ) + return -EOPNOTSUPP; + + list_move(&pdev->domain_list, &d->pdev_list); + pdev->domain = d; + + /* dom_io is used as a sentinel for quarantined devices */ + if ( d == dom_io ) + return 0; + } +#endif + if (!dev_iommu_group(dev)) { ret = arm_smmu_add_device(dev); if (ret) @@ -2773,11 +2816,33 @@ out: return ret; } -static int arm_smmu_deassign_dev(struct domain *d, struct device *dev) +static int arm_smmu_deassign_dev(struct domain *d, u8 devfn, struct device *dev) { struct iommu_domain *domain = dev_iommu_domain(dev); struct arm_smmu_xen_domain *xen_domain; +#ifdef CONFIG_HAS_PCI + if ( dev_is_pci(dev) ) + { + struct pci_dev *pdev = dev_to_pci(dev); + + printk(XENLOG_INFO "Deassigning device %04x:%02x:%02x.%u from dom%d\n", + pdev->seg, pdev->bus, PCI_SLOT(devfn), PCI_FUNC(devfn), + d->domain_id); + + /* + * XXX What would be the proper behavior? This could happen if + * pdev->phantom_stride > 0 + */ + if ( devfn != pdev->devfn ) + return -EOPNOTSUPP; + + /* dom_io is used as a sentinel for quarantined devices */ + if ( d == dom_io ) + return 0; + } +#endif + xen_domain = dom_iommu(d)->arch.priv; if (!domain || domain->priv->cfg.domain != d) { @@ -2805,13 +2870,13 @@ static int arm_smmu_reassign_dev(struct domain *s, struct domain *t, int ret = 0; /* Don't allow remapping on other domain than hwdom */ - if ( t && !is_hardware_domain(t) ) + if ( t && !is_hardware_domain(t) && t != dom_io ) return -EPERM; if (t == s) return 0; - ret = arm_smmu_deassign_dev(s, dev); + ret = arm_smmu_deassign_dev(s, devfn, dev); if (ret) return ret; -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon May 01 20:10:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 20:10:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528279.821227 (Exim 4.92) (envelope-from ) id 1ptZqJ-00008g-GQ; Mon, 01 May 2023 20:09:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528279.821227; Mon, 01 May 2023 20:09:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZqJ-00008Z-Cv; Mon, 01 May 2023 20:09:51 +0000 Received: by outflank-mailman (input) for mailman id 528279; Mon, 01 May 2023 20:09:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZl1-000525-Ba for xen-devel@lists.xenproject.org; Mon, 01 May 2023 20:04:23 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20601.outbound.protection.outlook.com [2a01:111:f400:7eae::601]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5caaf7b0-e85b-11ed-b225-6b7b168915f2; Mon, 01 May 2023 22:04:22 +0200 (CEST) Received: from MW4PR03CA0166.namprd03.prod.outlook.com (2603:10b6:303:8d::21) by DS7PR12MB6262.namprd12.prod.outlook.com (2603:10b6:8:96::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Mon, 1 May 2023 20:04:18 +0000 Received: from CO1NAM11FT016.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8d:cafe::7b) by MW4PR03CA0166.outlook.office365.com (2603:10b6:303:8d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30 via Frontend Transport; Mon, 1 May 2023 20:04:18 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT016.mail.protection.outlook.com (10.13.175.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.20 via Frontend Transport; Mon, 1 May 2023 20:04:18 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 1 May 2023 15:04:17 -0500 Received: from ubuntu.mshome.net (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 1 May 2023 15:04:16 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5caaf7b0-e85b-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jNexJhQ/NuhFiX0DyBzMSeOq62USE0QEjAanpnrNFaavCs7HvVvReW2YWYXN4b4leT+2o9MBbHn14UANlFt5+Jk9Z5LF05ii8SkX2NNDp/iwzhoPif08QRS+OarFwkSJ+jZffXiJ+nzEjDOtuwzZLmQSNtje51xKWLwQZYw/bdN/Bzz5NL+KojeX56qihL6V2x69euXFSOTwTwUhfqe57g7SA5qBBMwKnkvt0QaQpmJ1uH+hwphYsuwZw5+24UjLGIanmLVQYN4WCyKmVnXfUoHWx2MNxepSb6t+CUsw1zFsFurrP9HKaSCKVFLR/klhHVBqZYN/OEpBMiDuN7WS7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0XJhPVciLUzEu7aYbf6zQpM/bkxm9q36IA+36Y75kWQ=; b=iQCskHVZ4giy13gN7Swm67lRuzEkZzgjJVWTw5k6BaNUiKI/UJps7CBtUc4tx9bJPZ9qVsN9awRebpiUIm3DBR8izhIaIeo1pPYMdEmAGZTIK7ye65W/h9FVeYI86J/Hc283Ek9K7QlbG8YPyhBpE3Xbdgx7/eiboOKq66wvmzf2t8GQM1xyMDy66ffUhZgvDXy4fICZUYcbXhJ7aAeYjXhxsl2uU2H7EhDuZF3p3+pAgfQ0NQvfFPZ7Qno5Ajs8hjCwJV/PIT4mE6i7tORRtstYBApHjcDL/W/mhgA8jsZOQKbk18C6GxnqqJksA/xiy/MDblBF7zvnRjLor1qUcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0XJhPVciLUzEu7aYbf6zQpM/bkxm9q36IA+36Y75kWQ=; b=QdlfoD2li1KtoqoJdGnQKPbex1ZfI1cViutgN1oMCJL1kxO9Wf1gU3FnYxEao8MKtW8sHu42CC8KUMoTWqdN2uBz4LnrbkeccIi7c1PCH4K9buMCxYgkwuQ2oCMlbRC3hCxHNhCA99LUrJZH2FTCb8RqLyqtvMRbIzqtcFOaJHU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Stewart Hildebrand To: CC: Rahul Singh , Bertrand Marquis , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Stewart Hildebrand Subject: [PATCH v1 6/6] xen/arm: smmuv3: Add PCI devices support for SMMUv3 Date: Mon, 1 May 2023 16:03:05 -0400 Message-ID: <20230501200305.168058-7-stewart.hildebrand@amd.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230501200305.168058-1-stewart.hildebrand@amd.com> References: <20230501200305.168058-1-stewart.hildebrand@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT016:EE_|DS7PR12MB6262:EE_ X-MS-Office365-Filtering-Correlation-Id: cd0b89df-c04d-4fda-e7fa-08db4a7f3f45 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lHPtqGOP4XC2D/KGuxYseWc2nAyihzMlfG4W1jUl61eKikVKGiiGoZ1iQlhn//G8O8dcCRMRcjA8mRAClYScapDW8t9ETdy10lsXiwRTjjWYOQ9aQ04Q9i4KipxdfewBDxC/W536GYT2JTV0i3o6OfVPQQbQZTZhNKyvmolt/YtxKmGT5PRYocKldF/FUgg9e292RYdkGckuxZzFJ3N8PPsXMsuY0OHNBnlquPgIv3TAZOQK/AbvU/RKqVaSYmnCcJlCDMrEupm0nk+VR0wjwLyf7rDBghKjqzMKcUiUUBVPvUBDU6cxR0OL9I+P1mC8WI18Hj9CfIn8Epo2Z3t2puwsf/zXVjlXN7PSaX0y0CGsWs+xXJx5uCeGgtsUC67sIN4i4LkElMNFU/UTducWV5aAAqKXCk1pFjeOAoGBvjitldGae4rwCu56WSWb7qOHVRkVdHT7ubhA26QSzslPQzSiaj7ZyRVJB8PDIjL6ZJoOL2h3a4VNi51b2/o1NH+bqPIJCudhaUDR1TwAqp/EcOgBRq/pWpuWGYQ7i6X9b3dPS813hf22wv5qas/g+4Nxs1/4VGmdINsRrv381B/D7yMxFe35uOhnvhpDl4++LpdYH44NPNkobZcOCPShuA1jhqlTXTxuySXjjRLkB57R9jBSDyUoiMUNIeM/six4iQYjbmoX4UZ7P91pDFp7QSLQJuioWFEXfbG+r/QFbg0PBx1tevMItVotL214WAWfPRpMzRgXWbszuw+Jc3hmRUhR X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(376002)(136003)(396003)(451199021)(40470700004)(36840700001)(46966006)(82310400005)(40460700003)(8936002)(8676002)(36860700001)(26005)(2616005)(1076003)(44832011)(478600001)(5660300002)(186003)(40480700001)(36756003)(316002)(82740400003)(2906002)(54906003)(426003)(336012)(86362001)(83380400001)(70586007)(4326008)(6916009)(6666004)(41300700001)(70206006)(47076005)(966005)(81166007)(356005)(21314003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2023 20:04:18.4498 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cd0b89df-c04d-4fda-e7fa-08db4a7f3f45 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT016.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6262 From: Rahul Singh Signed-off-by: Rahul Singh Signed-off-by: Stewart Hildebrand --- downstream->v1: * rebase * move 2 replacements of s/dt_device_set_protected(dev_to_dt(dev))/device_set_protected(dev)/ from this commit to ("xen/arm: Move is_protected flag to struct device") so as to not break ability to bisect * adjust patch title (remove stray space) * arm_smmu_(de)assign_dev: return error instead of crashing system * remove arm_smmu_remove_device() stub * update condition in arm_smmu_reassign_dev * style fixup (cherry picked from commit 7ed6c3ab250d899fe6e893a514278e406a2893e8 from the downstream branch poc/pci-passthrough from https://gitlab.com/xen-project/people/bmarquis/xen-arm-poc.git) --- This is a file imported from Linux with modifications for Xen. What should be the coding style used for Xen modifications? --- xen/drivers/passthrough/arm/smmu-v3.c | 66 +++++++++++++++++++++++++-- 1 file changed, 63 insertions(+), 3 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index 4b452e6fdd00..481a35a8b8d4 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -1469,6 +1469,8 @@ static bool arm_smmu_sid_in_range(struct arm_smmu_device *smmu, u32 sid) } /* Forward declaration */ static struct arm_smmu_device *arm_smmu_get_by_dev(struct device *dev); +static int arm_smmu_assign_dev(struct domain *d, u8 devfn, + struct device *dev, u32 flag); static int arm_smmu_add_device(u8 devfn, struct device *dev) { @@ -1527,6 +1529,17 @@ static int arm_smmu_add_device(u8 devfn, struct device *dev) dev_info(dev, "Added master device (SMMUv3 %s StreamIds %u)\n", dev_name(fwspec->iommu_dev), fwspec->num_ids); +#ifdef CONFIG_HAS_PCI + if ( dev_is_pci(dev) ) + { + struct pci_dev *pdev = dev_to_pci(dev); + + ret = arm_smmu_assign_dev(pdev->domain, devfn, dev, 0); + if (ret) + goto err_free_master; + } +#endif + return 0; err_free_master: @@ -2607,6 +2620,31 @@ static int arm_smmu_assign_dev(struct domain *d, u8 devfn, struct arm_smmu_domain *smmu_domain; struct arm_smmu_xen_domain *xen_domain = dom_iommu(d)->arch.priv; +#ifdef CONFIG_HAS_PCI + if ( dev_is_pci(dev) && !is_hardware_domain(d) ) + { + struct pci_dev *pdev = dev_to_pci(dev); + + printk(XENLOG_INFO "Assigning device %04x:%02x:%02x.%u to dom%d\n", + pdev->seg, pdev->bus, PCI_SLOT(devfn), + PCI_FUNC(devfn), d->domain_id); + + /* + * XXX What would be the proper behavior? This could happen if + * pdev->phantom_stride > 0 + */ + if ( devfn != pdev->devfn ) + return -EOPNOTSUPP; + + list_move(&pdev->domain_list, &d->pdev_list); + pdev->domain = d; + + /* dom_io is used as a sentinel for quarantined devices */ + if ( d == dom_io ) + return 0; + } +#endif + spin_lock(&xen_domain->lock); /* @@ -2640,7 +2678,7 @@ out: return ret; } -static int arm_smmu_deassign_dev(struct domain *d, struct device *dev) +static int arm_smmu_deassign_dev(struct domain *d, uint8_t devfn, struct device *dev) { struct iommu_domain *io_domain = arm_smmu_get_domain(d, dev); struct arm_smmu_xen_domain *xen_domain = dom_iommu(d)->arch.priv; @@ -2652,6 +2690,28 @@ static int arm_smmu_deassign_dev(struct domain *d, struct device *dev) return -ESRCH; } +#ifdef CONFIG_HAS_PCI + if ( dev_is_pci(dev) ) + { + struct pci_dev *pdev = dev_to_pci(dev); + + printk(XENLOG_INFO "Deassigning device %04x:%02x:%02x.%u from dom%d\n", + pdev->seg, pdev->bus, PCI_SLOT(devfn), + PCI_FUNC(devfn), d->domain_id); + + /* + * XXX What would be the proper behavior? This could happen if + * pdev->phantom_stride > 0 + */ + if ( devfn != pdev->devfn ) + return -EOPNOTSUPP; + + /* dom_io is used as a sentinel for quarantined devices */ + if ( d == dom_io ) + return 0; + } +#endif + spin_lock(&xen_domain->lock); arm_smmu_detach_dev(master); @@ -2671,13 +2731,13 @@ static int arm_smmu_reassign_dev(struct domain *s, struct domain *t, int ret = 0; /* Don't allow remapping on other domain than hwdom */ - if ( t && !is_hardware_domain(t) ) + if ( t && !is_hardware_domain(t) && (t != dom_io) ) return -EPERM; if (t == s) return 0; - ret = arm_smmu_deassign_dev(s, dev); + ret = arm_smmu_deassign_dev(s, devfn, dev); if (ret) return ret; -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon May 01 20:10:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 20:10:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528280.821237 (Exim 4.92) (envelope-from ) id 1ptZqM-0000PC-O1; Mon, 01 May 2023 20:09:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528280.821237; Mon, 01 May 2023 20:09:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZqM-0000P5-LS; Mon, 01 May 2023 20:09:54 +0000 Received: by outflank-mailman (input) for mailman id 528280; Mon, 01 May 2023 20:09:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptZqL-0000Of-TV for xen-devel@lists.xenproject.org; Mon, 01 May 2023 20:09:53 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2061e.outbound.protection.outlook.com [2a01:111:f400:7e8a::61e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 21b20385-e85c-11ed-b225-6b7b168915f2; Mon, 01 May 2023 22:09:52 +0200 (CEST) Received: from MW4PR04CA0323.namprd04.prod.outlook.com (2603:10b6:303:82::28) by DM4PR12MB6038.namprd12.prod.outlook.com (2603:10b6:8:ab::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Mon, 1 May 2023 20:09:50 +0000 Received: from CO1NAM11FT067.eop-nam11.prod.protection.outlook.com (2603:10b6:303:82:cafe::44) by MW4PR04CA0323.outlook.office365.com (2603:10b6:303:82::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30 via Frontend Transport; Mon, 1 May 2023 20:09:49 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT067.mail.protection.outlook.com (10.13.174.212) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.19 via Frontend Transport; Mon, 1 May 2023 20:09:49 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 1 May 2023 15:09:49 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 1 May 2023 15:09:48 -0500 Received: from ubuntu.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 1 May 2023 15:09:47 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 21b20385-e85c-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RD3OwduzSOZw9pVYmJqz5vhD8oFwIil30HgUTqOGpE/EV9XjgSsHVo2Eyi0yJtfyyGzEiJod49SLv+8sKRZETj8Ahf9MPf3KijWKjK0lvgnDugGQSHbSUf3ikJH62BXbEQrkKQ/jkxmGYA+YzgihUNFbf4ha1TlaKnBMiHaRWbonuhDfh/5nhv8Szk977fsDjrbWDaGEz7DnoG8xuA/2GVKOtc2aE/In72CT97uLMW4l6j8mkf7ptC/hcgEGkCjAkACMhhiyEEAVm1ZkE4qX0fHrMZfvSsFrlZZawjZSST7N/hYybeZ/XnTQNUizUSYg4nOOr65auJZu5CRfqLDmEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0XJhPVciLUzEu7aYbf6zQpM/bkxm9q36IA+36Y75kWQ=; b=loBGtN6HImwO0TelplfgEoHq25dQ+HuRjGjWDUhFTIL2EvvCkcL5SH15jJRJQOejm0nx5eb81snfNK7MxlAV9Rxu+JVpEqfOYNeqgPc8vAZ9Ue+BCaUgcVTgHuF7+BqZSSIVOVXQkXm84q9CteSl3qG3JH24VJhfSF++WifF6mKatVKG+rwQ4UgpEqE56+7dB6svbEBGAjxKTXEcQIWEdbJd/XvE7djf0od+kai7Zecsb0enLMYsGsemkdfzm7IsliLS4IQ28k2m+08E5MkAGjTBJHbZMSu/R/xRBSw+1duO7GU7jb+ozjHSEas8Hy9LY0lszj1VzL8fVNy5YWeqfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0XJhPVciLUzEu7aYbf6zQpM/bkxm9q36IA+36Y75kWQ=; b=0slI8cl+LqjDqadGUBE5m95+adcNqO6T9TVhZfCNoplQ6uN+DrJiKm0wyGb4PrLopego0mOmxDTFyAvLfEw399H9uXQMdTIAQ9Q4IUjRj1NKUmgoUhPiURvgI80BCAoKw6ELLQY5YhHYmZQGd0IvMMwYwHTR/F/Cu9OIp2+vrnI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Stewart Hildebrand To: CC: Rahul Singh , Bertrand Marquis , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Stewart Hildebrand Subject: [PATCH v1 6/6] xen/arm: smmuv3: Add PCI devices support for SMMUv3 Date: Mon, 1 May 2023 16:09:42 -0400 Message-ID: <20230501200942.168105-1-stewart.hildebrand@amd.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230501200305.168058-1-stewart.hildebrand@amd.com> References: <20230501200305.168058-1-stewart.hildebrand@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT067:EE_|DM4PR12MB6038:EE_ X-MS-Office365-Filtering-Correlation-Id: 3a3272d9-79e4-4a75-ca3b-08db4a800482 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AYbOBjwjju28o+61rCE+w9k0H0/ZRJqJopCvwEl4QGMqHtNwsWGsDzPWCZcmr3cRCFHzCxOy5RGRthnSLLEzjlSPhg2IXy1qAhPBYDES5PQemCtNDwHYC06FwXclLRIBABAPoSLijsC9TbjZYafmwNbDc7O87Qc+2x7niTjjJbGcr6lsJk3CzIV+YazJUboqO3lvJvN10LKbqDYTJxUu9ok8ZaCO6z6j6XmkZe5qsqpmOBV3L3oK3LFRzNTj3FWg2wVv4IjYwGISy4GevbyLTbN8yM2fBw6O/Wjnjk83CZjvP5lD/z27Mn436uK+F3fE88BloLZ3473dn8gUzzXrLZ9v2KnNnoNr6tqJKRJXuqISudAUudZZMoz6jib1vxs6aGE3ZkgrGEgpgULlXBjasoH15vslF+RCLER/1zTQPL2xEKQAJ7L0PJx6oN5Y49PA/l8rEVRI7OylvSMpg8tp2x/Ka85tiRoNAphprAFJ+BAR1owYULnIiIuPEOfgGK7Qw7d+Gz1cl8pQ/YOymeezkyH+rWwcT7HTb8EypernyyScKj93xMvJ7V5/LB+gJpOCITAYSi5bmaGfIqVmLeMIviURG7xUUboaKaBWdC3v++7UDAxfVCQ5Gh3h90MIny6wcNEYEew9dqdx/awKIOaz5miCdUcEVOAK8sFds1ph4rdSJ0/RkBFko4uAVjfYrgxsuz56Ev8q8A/peJ3zZfvJqrYiX4aMAdZaq89Gmihv9RrHIJ8L3RJnVN7NlMVvXfcs X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(396003)(136003)(346002)(451199021)(40470700004)(36840700001)(46966006)(5660300002)(82310400005)(44832011)(86362001)(336012)(2616005)(83380400001)(1076003)(47076005)(36860700001)(82740400003)(186003)(356005)(966005)(81166007)(426003)(26005)(40460700003)(6666004)(8936002)(478600001)(316002)(54906003)(8676002)(36756003)(40480700001)(6916009)(41300700001)(4326008)(70206006)(70586007)(2906002)(21314003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2023 20:09:49.3600 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3a3272d9-79e4-4a75-ca3b-08db4a800482 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT067.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6038 From: Rahul Singh Signed-off-by: Rahul Singh Signed-off-by: Stewart Hildebrand --- downstream->v1: * rebase * move 2 replacements of s/dt_device_set_protected(dev_to_dt(dev))/device_set_protected(dev)/ from this commit to ("xen/arm: Move is_protected flag to struct device") so as to not break ability to bisect * adjust patch title (remove stray space) * arm_smmu_(de)assign_dev: return error instead of crashing system * remove arm_smmu_remove_device() stub * update condition in arm_smmu_reassign_dev * style fixup (cherry picked from commit 7ed6c3ab250d899fe6e893a514278e406a2893e8 from the downstream branch poc/pci-passthrough from https://gitlab.com/xen-project/people/bmarquis/xen-arm-poc.git) --- This is a file imported from Linux with modifications for Xen. What should be the coding style used for Xen modifications? --- xen/drivers/passthrough/arm/smmu-v3.c | 66 +++++++++++++++++++++++++-- 1 file changed, 63 insertions(+), 3 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index 4b452e6fdd00..481a35a8b8d4 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -1469,6 +1469,8 @@ static bool arm_smmu_sid_in_range(struct arm_smmu_device *smmu, u32 sid) } /* Forward declaration */ static struct arm_smmu_device *arm_smmu_get_by_dev(struct device *dev); +static int arm_smmu_assign_dev(struct domain *d, u8 devfn, + struct device *dev, u32 flag); static int arm_smmu_add_device(u8 devfn, struct device *dev) { @@ -1527,6 +1529,17 @@ static int arm_smmu_add_device(u8 devfn, struct device *dev) dev_info(dev, "Added master device (SMMUv3 %s StreamIds %u)\n", dev_name(fwspec->iommu_dev), fwspec->num_ids); +#ifdef CONFIG_HAS_PCI + if ( dev_is_pci(dev) ) + { + struct pci_dev *pdev = dev_to_pci(dev); + + ret = arm_smmu_assign_dev(pdev->domain, devfn, dev, 0); + if (ret) + goto err_free_master; + } +#endif + return 0; err_free_master: @@ -2607,6 +2620,31 @@ static int arm_smmu_assign_dev(struct domain *d, u8 devfn, struct arm_smmu_domain *smmu_domain; struct arm_smmu_xen_domain *xen_domain = dom_iommu(d)->arch.priv; +#ifdef CONFIG_HAS_PCI + if ( dev_is_pci(dev) && !is_hardware_domain(d) ) + { + struct pci_dev *pdev = dev_to_pci(dev); + + printk(XENLOG_INFO "Assigning device %04x:%02x:%02x.%u to dom%d\n", + pdev->seg, pdev->bus, PCI_SLOT(devfn), + PCI_FUNC(devfn), d->domain_id); + + /* + * XXX What would be the proper behavior? This could happen if + * pdev->phantom_stride > 0 + */ + if ( devfn != pdev->devfn ) + return -EOPNOTSUPP; + + list_move(&pdev->domain_list, &d->pdev_list); + pdev->domain = d; + + /* dom_io is used as a sentinel for quarantined devices */ + if ( d == dom_io ) + return 0; + } +#endif + spin_lock(&xen_domain->lock); /* @@ -2640,7 +2678,7 @@ out: return ret; } -static int arm_smmu_deassign_dev(struct domain *d, struct device *dev) +static int arm_smmu_deassign_dev(struct domain *d, uint8_t devfn, struct device *dev) { struct iommu_domain *io_domain = arm_smmu_get_domain(d, dev); struct arm_smmu_xen_domain *xen_domain = dom_iommu(d)->arch.priv; @@ -2652,6 +2690,28 @@ static int arm_smmu_deassign_dev(struct domain *d, struct device *dev) return -ESRCH; } +#ifdef CONFIG_HAS_PCI + if ( dev_is_pci(dev) ) + { + struct pci_dev *pdev = dev_to_pci(dev); + + printk(XENLOG_INFO "Deassigning device %04x:%02x:%02x.%u from dom%d\n", + pdev->seg, pdev->bus, PCI_SLOT(devfn), + PCI_FUNC(devfn), d->domain_id); + + /* + * XXX What would be the proper behavior? This could happen if + * pdev->phantom_stride > 0 + */ + if ( devfn != pdev->devfn ) + return -EOPNOTSUPP; + + /* dom_io is used as a sentinel for quarantined devices */ + if ( d == dom_io ) + return 0; + } +#endif + spin_lock(&xen_domain->lock); arm_smmu_detach_dev(master); @@ -2671,13 +2731,13 @@ static int arm_smmu_reassign_dev(struct domain *s, struct domain *t, int ret = 0; /* Don't allow remapping on other domain than hwdom */ - if ( t && !is_hardware_domain(t) ) + if ( t && !is_hardware_domain(t) && (t != dom_io) ) return -EPERM; if (t == s) return 0; - ret = arm_smmu_deassign_dev(s, dev); + ret = arm_smmu_deassign_dev(s, devfn, dev); if (ret) return ret; -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon May 01 20:31:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 20:31:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528289.821247 (Exim 4.92) (envelope-from ) id 1ptaAi-0004GW-KM; Mon, 01 May 2023 20:30:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528289.821247; Mon, 01 May 2023 20:30:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptaAi-0004GP-Hb; Mon, 01 May 2023 20:30:56 +0000 Received: by outflank-mailman (input) for mailman id 528289; Mon, 01 May 2023 20:30:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptaAh-0004GJ-DN for xen-devel@lists.xenproject.org; Mon, 01 May 2023 20:30:55 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20600.outbound.protection.outlook.com [2a01:111:f400:fe5b::600]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 10c6ba00-e85f-11ed-b225-6b7b168915f2; Mon, 01 May 2023 22:30:53 +0200 (CEST) Received: from DS7PR05CA0077.namprd05.prod.outlook.com (2603:10b6:8:57::17) by SA3PR12MB7784.namprd12.prod.outlook.com (2603:10b6:806:317::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Mon, 1 May 2023 20:30:50 +0000 Received: from DS1PEPF0000E649.namprd02.prod.outlook.com (2603:10b6:8:57:cafe::8f) by DS7PR05CA0077.outlook.office365.com (2603:10b6:8:57::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.20 via Frontend Transport; Mon, 1 May 2023 20:30:49 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DS1PEPF0000E649.mail.protection.outlook.com (10.167.18.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6340.16 via Frontend Transport; Mon, 1 May 2023 20:30:49 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 1 May 2023 15:30:48 -0500 Received: from ubuntu.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 1 May 2023 15:30:48 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 10c6ba00-e85f-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mdMwMeBAzJ0YwgoD90WE9JrbR91We36xi7QeZHVwiTKiWY7A5Khhoc6nxeuWihek56vzUcJ4DYkKLLzo+5NjJzHfrKOBzkwl/OZCzsEo69HEpT7pOMq8zsGZq7G/QMStnhSt0IIZsYOqxvyH93aiZ9uYxH+vTry9AV0SzEpYpnOM4Sw5YN7vFcPeATrl5XHbglJP6134JQJB1/Un9urouybQ+u4i/59HhF3U0GKL0Ladsck8qt4oS8/nSIt/DsxwGICZPvkIevoZntQskET84Yi/uMHDRpnwZZoY3KKmYKunJ0H6Lt35aAwg15DNw4I65z2vW/zLWO1x7pzihh+AbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CSFUIv+vA4xvYLSDbnANA0FJUUKynik5M6lLpry0LHk=; b=Wtg8XHCEFG0n5SqdcJqZqvWykMifHxVRV8SzZ2zrQnrZ1rgOMJLeyOZmVxhk98oWI7HSmsAkaRpNjogWAwshBJgiDQRS6n2o8YyxljzVzLJaVuw7h1LqgnQ2nfctTxMcuJOHLVDdP8UpPs0881sIvUZpd5q6nGa3BoDyLxFy4yDo/rBWjqlWsEE/gS0Z93Iu7ftVBVYh4SttaJFB19LJpuhjZOUcUbGpexwqGJJ1qUGvSruhSXxcZpj+AQrUZtFXjDzcx/oMhxP3hR87Tp1aYeraWnlO+5igDc2o/mvS/GWPZhf3diisk7jSYmnK+Jn/til7tVSYhCpwhipAau+bEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CSFUIv+vA4xvYLSDbnANA0FJUUKynik5M6lLpry0LHk=; b=BUhgGeyjVq9n2YOjlMMUkiY94U8LkxXF2vt1Gl8le2Gmj5XQ8qU8R4ahXKwGNO39SHPC+QkcoLIdeHdwczECLuXGUS4yjwu05hY+7qUk1qnaAIlXNPqsBU+R8KH2OrGKegyHY3kTrHjt8KB3Mmirdk940T/Xjr2gThhp63wq+K8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Stewart Hildebrand To: CC: Stewart Hildebrand , George Dunlap , Dario Faggioli , "Juergen Gross" Subject: [PATCH v1] xen/sched/null: avoid crash after failed domU creation Date: Mon, 1 May 2023 16:30:46 -0400 Message-ID: <20230501203046.168856-1-stewart.hildebrand@amd.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0000E649:EE_|SA3PR12MB7784:EE_ X-MS-Office365-Filtering-Correlation-Id: d80ca6cd-7382-4db1-4971-08db4a82f387 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9rasoY0u2wUFDqhcqLDQc8UUGjWTGuBZITehAW1/NmIt5BgArjh6Rk829Z5ywuuBV8Tg+1Uo2iKcV+B74EwPql8Vj/x1HlIv5ZpSMr9wxcBIRhvOc/JQUr4NJkP9BOphqSrsTQOVI8/p5g2VfDS/N76QwVxeKAnKsalWpfzlS+XZJmGvBfwpT+ZRgyBt4nv3GGujpNxPL1kNJkiIw6CHdTFtEcFOb0JwME6srJSjm4GsJEB9HmnwA8v0gpzilKBMAnmD8Wm3tbvAiqaf+IBUNxYBVd77bBtAk9Di7NW2UdhSbFI9u3hFPg6At1I2SVdGHbsi8oWCSfaGxWQF57ukrFJL0D9XemCGTXTsHLjXohBcw2tbtKU91hbR93u/Sm8S5jeaZ2WWT7TU8brRNDi3LLIay+0xA3zU/0dgpVUaKcqxr2SfA2B4f8iWYeAiJsnUZdOJi5QrCBxYRNUP57rUBtEmG2jZwIGgU0UEQvGnTXsAEHp5FFlLaC2jBiGxqTEE0uTW97Jplj+kk0LMRojLRCpj7KZXYmK7OrZ9c0temJPa17BAXu9DP/bmY2GeJxJVlaqkb2a/NCVzXbxwhdPBvHY/+uQfkoJAIdLuJ5UQdDjTQyXdCpWvh9zRcq4o01EeLUvD4OpzNpMsE2fd94tL26hJPIo2ZRulJSSyy0ta82bMYvmHMeR6GtH7JJ7aBn92psuvWlNFaMuVnbjVievHU0/fZq8gFkfv9YxJ+x6dDDc= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(136003)(346002)(376002)(451199021)(36840700001)(46966006)(40470700004)(40480700001)(40460700003)(316002)(1076003)(82310400005)(26005)(426003)(336012)(41300700001)(2616005)(47076005)(83380400001)(186003)(478600001)(70206006)(36860700001)(54906003)(70586007)(4326008)(966005)(6916009)(356005)(82740400003)(81166007)(36756003)(2906002)(5660300002)(86362001)(8936002)(8676002)(44832011)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2023 20:30:49.4209 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d80ca6cd-7382-4db1-4971-08db4a82f387 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0000E649.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7784 When creating a domU, but the creation fails, there is a corner case that may lead to a crash in the null scheduler when running a debug build of Xen. (XEN) **************************************** (XEN) Panic on CPU 0: (XEN) Assertion 'npc->unit == unit' failed at common/sched/null.c:379 (XEN) **************************************** The events leading to the crash are: * null_unit_insert() was invoked with the unit offline. Since the unit was offline, unit_assign() was not called, and null_unit_insert() returned. * Later during domain creation, the unit was onlined * Eventually, domain creation failed due to bad configuration * null_unit_remove() was invoked with the unit still online. Since the unit was online, it called unit_deassign() and triggered an ASSERT. To fix this, only call unit_deassign() when npc->unit is non-NULL in null_unit_remove. Signed-off-by: Stewart Hildebrand --- RFC->v1 * Follow Juergen's suggested fix Link to RFC [1] [1] https://lists.xenproject.org/archives/html/xen-devel/2023-04/msg01387.html --- xen/common/sched/null.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/xen/common/sched/null.c b/xen/common/sched/null.c index 65a0a6c5312d..2091337fcd06 100644 --- a/xen/common/sched/null.c +++ b/xen/common/sched/null.c @@ -522,6 +522,8 @@ static void cf_check null_unit_remove( { struct null_private *prv = null_priv(ops); struct null_unit *nvc = null_unit(unit); + struct null_pcpu *npc; + unsigned int cpu; spinlock_t *lock; ASSERT(!is_idle_unit(unit)); @@ -531,8 +533,6 @@ static void cf_check null_unit_remove( /* If offline, the unit shouldn't be assigned, nor in the waitqueue */ if ( unlikely(!is_unit_online(unit)) ) { - struct null_pcpu *npc; - npc = unit->res->sched_priv; ASSERT(npc->unit != unit); ASSERT(list_empty(&nvc->waitq_elem)); @@ -549,7 +549,10 @@ static void cf_check null_unit_remove( goto out; } - unit_deassign(prv, unit); + cpu = sched_unit_master(unit); + npc = get_sched_res(cpu)->sched_priv; + if ( npc->unit ) + unit_deassign(prv, unit); out: unit_schedule_unlock_irq(lock, unit); -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon May 01 20:59:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 20:59:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528297.821257 (Exim 4.92) (envelope-from ) id 1ptacM-0006tf-TB; Mon, 01 May 2023 20:59:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528297.821257; Mon, 01 May 2023 20:59:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptacM-0006tY-PF; Mon, 01 May 2023 20:59:30 +0000 Received: by outflank-mailman (input) for mailman id 528297; Mon, 01 May 2023 20:59:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptacL-0006tS-Cl for xen-devel@lists.xenproject.org; Mon, 01 May 2023 20:59:29 +0000 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [2607:f8b0:4864:20::429]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0ea585df-e863-11ed-b225-6b7b168915f2; Mon, 01 May 2023 22:59:27 +0200 (CEST) Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-63b57c49c4cso2218322b3a.3 for ; Mon, 01 May 2023 13:59:27 -0700 (PDT) Received: from localhost ([50.221.140.188]) by smtp.gmail.com with ESMTPSA id x3-20020a628603000000b0063d666566d1sm20322681pfd.72.2023.05.01.13.59.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 13:59:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0ea585df-e863-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20221208.gappssmtp.com; s=20221208; t=1682974766; x=1685566766; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=56zwdsQPzBA4Fq57F7zZq8xm3cbpRSpnOmcnA0Dh+zY=; b=dhuoKYDmXvVL9rcvID9l7RqV772Z8lTC+U0WXQUi0tYJbLE9a48GrmSzQs7bEghGbC JAz8rXoL1w4B9KKuEwX7POjH3Ox3r6V4zpIxvsvZpSsylQJD8ptmZ7+Vz+V8jAHJj04w T6FV37TSFDDCD7el69cwAEuuEXi6g8EgNvIcALlfkGBQgAio2kQ2a6bJAUGpYJRLsZzz ZNQyL545JSX++O1LCUyCJsybjwMgrDioUAedrjXfVSqEM2lGIt3XAkC5ujMjWrYDbKAU lx6fFu18ULaY/km5rliSpJC6ISEyi513He8uKlna726VX+0Zf3a2zrJJ6SJgvgEWorgq velw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682974766; x=1685566766; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=56zwdsQPzBA4Fq57F7zZq8xm3cbpRSpnOmcnA0Dh+zY=; b=JCXzJUkuVZtrvn6Psj2eIf+22uAXBp98t4QtFNxeY3RxUUs1hufwNi+3VH60Rgy8hr gFOV+yiilTc3yDlVqE46AjIXyg7qHTt91f4rWwD3IFYgDXA64q8AYdO98q+/DhhKawRm /AMSnVNmN8fO0GE8b5SXnddh9WY7km7QzvB3LAnL8bXbxIM8eWjRGFGfSKw2DFoHPePa g+NrEFm9rtaTLmCrBfRx3Ai+MbS4+2X+6Qmgx4O1pmKm6GtFIrP32hDscejSn/fz/A5R ada9QyVpEV/PqJxYs9PBdBA5Uo/pin3vD1UrH98ErXsIbIltBlWCPbyRPGd3a60U9+G7 K85A== X-Gm-Message-State: AC+VfDwQmMJUhDrcVvZKIhwyVhs/zA4F2gZ5rBYRXu2d9xfCfWs00M7P KXXqslO83U9cKkNZJrb6iJKNwFfR/ihVT66jsy7+Nw== X-Google-Smtp-Source: ACHHUZ7NRh0XptQx7EX4B/2U8oMa1VyQthNvjC4nK5qetnlZ9yiAEbyNISqPVXEejwWKpBkEgu1KUQ== X-Received: by 2002:a05:6a00:1301:b0:63d:27a1:d578 with SMTP id j1-20020a056a00130100b0063d27a1d578mr19620776pfu.20.1682974765524; Mon, 01 May 2023 13:59:25 -0700 (PDT) Date: Mon, 01 May 2023 13:59:24 -0700 (PDT) X-Google-Original-Date: Mon, 01 May 2023 13:59:09 PDT (-0700) Subject: Re: [PATCH v2 29/34] riscv: Convert alloc_{pmd, pte}_late() to use ptdescs In-Reply-To: <20230501192829.17086-30-vishal.moola@gmail.com> CC: akpm@linux-foundation.org, willy@infradead.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, vishal.moola@gmail.com, Paul Walmsley From: Palmer Dabbelt To: vishal.moola@gmail.com Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On Mon, 01 May 2023 12:28:24 PDT (-0700), vishal.moola@gmail.com wrote: > As part of the conversions to replace pgtable constructor/destructors with > ptdesc equivalents, convert various page table functions to use ptdescs. > > Some of the functions use the *get*page*() helper functions. Convert > these to use ptdesc_alloc() and ptdesc_address() instead to help > standardize page tables further. > > Signed-off-by: Vishal Moola (Oracle) > --- > arch/riscv/include/asm/pgalloc.h | 8 ++++---- > arch/riscv/mm/init.c | 16 ++++++---------- > 2 files changed, 10 insertions(+), 14 deletions(-) > > diff --git a/arch/riscv/include/asm/pgalloc.h b/arch/riscv/include/asm/pgalloc.h > index 59dc12b5b7e8..cb5536403bd8 100644 > --- a/arch/riscv/include/asm/pgalloc.h > +++ b/arch/riscv/include/asm/pgalloc.h > @@ -153,10 +153,10 @@ static inline pgd_t *pgd_alloc(struct mm_struct *mm) > > #endif /* __PAGETABLE_PMD_FOLDED */ > > -#define __pte_free_tlb(tlb, pte, buf) \ > -do { \ > - pgtable_pte_page_dtor(pte); \ > - tlb_remove_page((tlb), pte); \ > +#define __pte_free_tlb(tlb, pte, buf) \ > +do { \ > + ptdesc_pte_dtor(page_ptdesc(pte)); \ > + tlb_remove_page_ptdesc((tlb), page_ptdesc(pte));\ > } while (0) > #endif /* CONFIG_MMU */ > > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c > index eb8173a91ce3..8f1982664687 100644 > --- a/arch/riscv/mm/init.c > +++ b/arch/riscv/mm/init.c > @@ -353,12 +353,10 @@ static inline phys_addr_t __init alloc_pte_fixmap(uintptr_t va) > > static phys_addr_t __init alloc_pte_late(uintptr_t va) > { > - unsigned long vaddr; > - > - vaddr = __get_free_page(GFP_KERNEL); > - BUG_ON(!vaddr || !pgtable_pte_page_ctor(virt_to_page(vaddr))); > + struct ptdesc *ptdesc = ptdesc_alloc(GFP_KERNEL, 0); > > - return __pa(vaddr); > + BUG_ON(!ptdesc || !ptdesc_pte_ctor(ptdesc)); > + return __pa((pte_t *)ptdesc_address(ptdesc)); > } > > static void __init create_pte_mapping(pte_t *ptep, > @@ -436,12 +434,10 @@ static phys_addr_t __init alloc_pmd_fixmap(uintptr_t va) > > static phys_addr_t __init alloc_pmd_late(uintptr_t va) > { > - unsigned long vaddr; > - > - vaddr = __get_free_page(GFP_KERNEL); > - BUG_ON(!vaddr || !pgtable_pmd_page_ctor(virt_to_page(vaddr))); > + struct ptdesc *ptdesc = ptdesc_alloc(GFP_KERNEL, 0); > > - return __pa(vaddr); > + BUG_ON(!ptdesc || !ptdesc_pmd_ctor(ptdesc)); > + return __pa((pmd_t *)ptdesc_address(ptdesc)); > } > > static void __init create_pmd_mapping(pmd_t *pmdp, Acked-by: Palmer Dabbelt From xen-devel-bounces@lists.xenproject.org Mon May 01 22:05:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 22:05:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528300.821267 (Exim 4.92) (envelope-from ) id 1ptbe9-0005mS-QJ; Mon, 01 May 2023 22:05:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528300.821267; Mon, 01 May 2023 22:05:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptbe9-0005mL-MM; Mon, 01 May 2023 22:05:25 +0000 Received: by outflank-mailman (input) for mailman id 528300; Mon, 01 May 2023 22:05:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptbe8-0005mB-C5; Mon, 01 May 2023 22:05:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptbe8-0004ei-1Z; Mon, 01 May 2023 22:05:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptbe7-0000E9-LP; Mon, 01 May 2023 22:05:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ptbe7-00067R-Iu; Mon, 01 May 2023 22:05:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Pxdd1GoEDGF9UOeAEK7HxyTadRVBlQ2tPGVxbXwJhaE=; b=Sjt9GUiuTnbiagBRBdCEyN8zpy 5NOa/VnKqoAOFC3neV50KJ4MLKqJa9C39AQCMBjCxSnnD/CCzpU/uXKRgL9CaAHtSjkIYVu7SqYr0 9YG9xARQtYyK0bwOjactL/XMyjRG6JpUtBZ/CRKBJWTvpCnmAoJzj0SsZKxTOcZvHWoo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180496: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=ef841d2a2377f5297add27e637b725426bb4840a X-Osstest-Versions-That: xen=6a47ba2f7855f8fc094ec4f837e71a34ededb77b From: osstest service owner Date: Mon, 01 May 2023 22:05:23 +0000 flight 180496 xen-unstable real [real] flight 180498 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180496/ http://logs.test-lab.xenproject.org/osstest/logs/180498/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 180498-retest test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail pass in 180498-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180492 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180492 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180492 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180492 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180492 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180492 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail like 180492 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 180492 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 180492 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180492 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 180492 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180492 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180492 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: xen ef841d2a2377f5297add27e637b725426bb4840a baseline version: xen 6a47ba2f7855f8fc094ec4f837e71a34ededb77b Last test of basis 180492 2023-05-01 01:52:02 Z 0 days Testing same since 180496 2023-05-01 13:38:33 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Marek Marczykowski-Górecki jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 6a47ba2f78..ef841d2a23 ef841d2a2377f5297add27e637b725426bb4840a -> master From xen-devel-bounces@lists.xenproject.org Mon May 01 23:56:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 May 2023 23:56:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528312.821285 (Exim 4.92) (envelope-from ) id 1ptdNB-00006a-UP; Mon, 01 May 2023 23:56:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528312.821285; Mon, 01 May 2023 23:56:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptdNB-00006T-Pg; Mon, 01 May 2023 23:56:01 +0000 Received: by outflank-mailman (input) for mailman id 528312; Mon, 01 May 2023 23:56:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptdNA-00006N-Bx for xen-devel@lists.xenproject.org; Mon, 01 May 2023 23:56:00 +0000 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [2607:f8b0:4864:20::430]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b6056f9c-e87b-11ed-8611-37d641c3527e; Tue, 02 May 2023 01:55:57 +0200 (CEST) Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-63b8b19901fso3667234b3a.3 for ; Mon, 01 May 2023 16:55:56 -0700 (PDT) Received: from localhost ([50.221.140.188]) by smtp.gmail.com with ESMTPSA id t2-20020a628102000000b0063b1e7ffc5fsm20413877pfd.39.2023.05.01.16.55.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 16:55:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b6056f9c-e87b-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20221208.gappssmtp.com; s=20221208; t=1682985354; x=1685577354; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=QuwyJlMhOzHc7pD19rcBJm7YGGdkgt4st5TSnBpxtCA=; b=u7Fbet5GsM/a+tKDG1jIQjylhg8yDIGsEfB3R3METzXxmxTlMfZIrKJcjG1Eg5BKJj MlFOPCIdB1Kzok6k4VO3kofHLnjOICQw4gU2tuQOBg05zhDbFsggy6hJcjAmZMRGAXf0 rUtZb8K8J1C2NtGocYCnTuPL/7q8UuOvuWeleHqtXMOc3hyp4VTgoMKde+PprRxEq3U9 3NCfHp5mczh1hPm51YYXtT/w0nBzMFK+Xv4D4Xzjfds97FS7WzOT/O5styDeQpozCahx aw/N9G2On9yOd5m0BdC1sLbhcBfoO3yIW/1WaAekonzfxEBWX3WbGIXs9NTSCve1lAj1 n8sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682985354; x=1685577354; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QuwyJlMhOzHc7pD19rcBJm7YGGdkgt4st5TSnBpxtCA=; b=AXjVAAOy36CR1B9sJotdZBON9iZBAFosUpB+ZJY1hlIPrzYddyMErlpIm4cSlSMjbL cFp4vgqFMD7iO0wKXWKoQLtJwHnkgRKZcNScQVZ01tV3O3S/H7poU2MrXcL39teWSn9X 9RIf/Ri+pceUMGRyFWJKETAHuqzGr4neA1BswUWsNG1JFurwMnP3523scI1h++gEwVww 1cuLjEtBRXQ8B6qzlhL0XgouJMLSyiB3Lx3iR6lopyy/U9uzGUOY8n7/F6z6w2CYfn/x DtvDLT+zkfWYq0WROgp6vex6YtJo2iQ5BKfTitZkOTAGEG0lTRDVGh7ABJoC884bYLEA Tt0w== X-Gm-Message-State: AC+VfDx+UWpUCP362lultdJX8cp/ZFj2clph+p7ovK17s1psBNpeWVZN xAksnb/Xs5NHrlu2Ux4dBDTUmA== X-Google-Smtp-Source: ACHHUZ4SgBzSoTxFJ9j/mzMx+FBKsdjE/IfAfq6NZWT2hwrYFJsUY4cczelg66bWFkmYBXKaJT4LqQ== X-Received: by 2002:a05:6a20:6f03:b0:f8:b39b:b24e with SMTP id gt3-20020a056a206f0300b000f8b39bb24emr16225285pzb.11.1682985354255; Mon, 01 May 2023 16:55:54 -0700 (PDT) Date: Mon, 01 May 2023 16:55:53 -0700 (PDT) X-Google-Original-Date: Mon, 01 May 2023 16:55:31 PDT (-0700) Subject: Re: [patch 26/37] riscv: Switch to hotplug core state synchronization In-Reply-To: <20230414232310.817955867@linutronix.de> CC: linux-kernel@vger.kernel.org, x86@kernel.org, dwmw@infradead.org, andrew.cooper3@citrix.com, brgerst@gmail.com, arjan@linux.intel.com, pbonzini@redhat.com, paulmck@kernel.org, thomas.lendacky@amd.com, seanjc@google.com, oleksandr@natalenko.name, pmenzel@molgen.mpg.de, gpiccoli@igalia.com, lucjan.lucjanov@gmail.com, Paul Walmsley , linux-riscv@lists.infradead.org, dwmw@amazon.co.uk, usama.arif@bytedance.com, jgross@suse.com, boris.ostrovsky@oracle.com, xen-devel@lists.xenproject.org, linux@armlinux.org.uk, Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , guoren@kernel.org, linux-csky@vger.kernel.org, tsbogend@alpha.franken.de, linux-mips@vger.kernel.org, James.Bottomley@HansenPartnership.com, deller@gmx.de, linux-parisc@vger.kernel.org, Mark Rutland , sabrapan@amazon.com From: Palmer Dabbelt To: tglx@linutronix.de Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On Fri, 14 Apr 2023 16:44:55 PDT (-0700), tglx@linutronix.de wrote: > Switch to the CPU hotplug core state tracking and synchronization > mechanim. No functional change intended. > > Signed-off-by: Thomas Gleixner > Cc: Paul Walmsley > Cc: Palmer Dabbelt > Cc: linux-riscv@lists.infradead.org > --- > arch/riscv/Kconfig | 1 + > arch/riscv/include/asm/smp.h | 2 +- > arch/riscv/kernel/cpu-hotplug.c | 14 +++++++------- > 3 files changed, 9 insertions(+), 8 deletions(-) > > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -116,6 +116,7 @@ config RISCV > select HAVE_RSEQ > select HAVE_STACKPROTECTOR > select HAVE_SYSCALL_TRACEPOINTS > + select HOTPLUG_CORE_SYNC_DEAD if HOTPLUG_CPU > select IRQ_DOMAIN > select IRQ_FORCED_THREADING > select MODULES_USE_ELF_RELA if MODULES > --- a/arch/riscv/include/asm/smp.h > +++ b/arch/riscv/include/asm/smp.h > @@ -64,7 +64,7 @@ asmlinkage void smp_callin(void); > > #if defined CONFIG_HOTPLUG_CPU > int __cpu_disable(void); > -void __cpu_die(unsigned int cpu); > +static inline void __cpu_die(unsigned int cpu) { } > #endif /* CONFIG_HOTPLUG_CPU */ > > #else > --- a/arch/riscv/kernel/cpu-hotplug.c > +++ b/arch/riscv/kernel/cpu-hotplug.c > @@ -8,6 +8,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -48,17 +49,15 @@ int __cpu_disable(void) > return ret; > } > > +#ifdef CONFIG_HOTPLUG_CPU > /* > - * Called on the thread which is asking for a CPU to be shutdown. > + * Called on the thread which is asking for a CPU to be shutdown, if the > + * CPU reported dead to the hotplug core. > */ > -void __cpu_die(unsigned int cpu) > +void arch_cpuhp_cleanup_dead_cpu(unsigned int cpu) > { > int ret = 0; > > - if (!cpu_wait_death(cpu, 5)) { > - pr_err("CPU %u: didn't die\n", cpu); > - return; > - } > pr_notice("CPU%u: off\n", cpu); > > /* Verify from the firmware if the cpu is really stopped*/ > @@ -75,9 +74,10 @@ void arch_cpu_idle_dead(void) > { > idle_task_exit(); > > - (void)cpu_report_death(); > + cpuhp_ap_report_dead(); > > cpu_ops[smp_processor_id()]->cpu_stop(); > /* It should never reach here */ > BUG(); > } > +#endif Acked-by: Palmer Dabbelt From xen-devel-bounces@lists.xenproject.org Tue May 02 01:38:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 01:38:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528317.821295 (Exim 4.92) (envelope-from ) id 1pteyC-0002zt-Ov; Tue, 02 May 2023 01:38:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528317.821295; Tue, 02 May 2023 01:38:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pteyC-0002zl-Jv; Tue, 02 May 2023 01:38:20 +0000 Received: by outflank-mailman (input) for mailman id 528317; Tue, 02 May 2023 01:38:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pteyB-0002zb-L5; Tue, 02 May 2023 01:38:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pteyB-0002Iw-9F; Tue, 02 May 2023 01:38:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pteyA-0004zy-Oe; Tue, 02 May 2023 01:38:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pteyA-0004qW-OC; Tue, 02 May 2023 01:38:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=EPxiEZMMtbDkJW73s34MdUe8otFQddET4f+3KSho4yo=; b=YKY40jSd28FN0QRtQO38ph+sUb 8Y4OGRUPZZ6334KADf0ZLIqwVmXw/5hPRUjhc4ZslwALErlLzhfiJVNV1kY68DIXoyNZ0UFUzbouQ VPIU5vf3n/23fW5zfuYJWw/+rkCW6f136s96CvXqJkp0tK+UT4r9OR0AZL9QwW8DAm4o=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180497: regressions - FAIL X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:guest-start/debian.repeat:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-examine:reboot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=58390c8ce1bddb6c623f62e7ed36383e7fa5c02f X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Tue, 02 May 2023 01:38:18 +0000 flight 180497 linux-linus real [real] flight 180499 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180497/ http://logs.test-lab.xenproject.org/osstest/logs/180499/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-vhd 21 guest-start/debian.repeat fail REGR. vs. 180278 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 8 xen-boot fail like 180278 test-armhf-armhf-libvirt 8 xen-boot fail like 180278 test-armhf-armhf-xl-vhd 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-raw 8 xen-boot fail like 180278 test-armhf-armhf-xl-arndale 8 xen-boot fail like 180278 test-armhf-armhf-examine 8 reboot fail like 180278 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180278 test-armhf-armhf-xl 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180278 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail like 180278 test-armhf-armhf-xl-rtds 8 xen-boot fail like 180278 test-armhf-armhf-xl-multivcpu 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 58390c8ce1bddb6c623f62e7ed36383e7fa5c02f baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 15 days Failing since 180281 2023-04-17 06:24:36 Z 14 days 25 attempts Testing same since 180493 2023-05-01 02:06:50 Z 0 days 2 attempts ------------------------------------------------------------ 2116 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 254448 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 02 01:49:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 01:49:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528322.821306 (Exim 4.92) (envelope-from ) id 1ptf96-0004Vm-QD; Tue, 02 May 2023 01:49:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528322.821306; Tue, 02 May 2023 01:49:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptf96-0004Vf-LS; Tue, 02 May 2023 01:49:36 +0000 Received: by outflank-mailman (input) for mailman id 528322; Tue, 02 May 2023 01:49:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptf95-0004VZ-Eq for xen-devel@lists.xenproject.org; Tue, 02 May 2023 01:49:35 +0000 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9431b320-e88b-11ed-8611-37d641c3527e; Tue, 02 May 2023 03:49:32 +0200 (CEST) Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 May 2023 18:49:25 -0700 Received: from lkp-server01.sh.intel.com (HELO e3434d64424d) ([10.239.97.150]) by fmsmga007.fm.intel.com with ESMTP; 01 May 2023 18:49:20 -0700 Received: from kbuild by e3434d64424d with local (Exim 4.96) (envelope-from ) id 1ptf8q-0000ke-0J; Tue, 02 May 2023 01:49:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9431b320-e88b-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682992172; x=1714528172; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=atYvzhPCCZ/tytx2DE7s23i4jWidElWSRjsH6cc5aEY=; b=Dw7biiOHIg+GLNRuChMal0jdKqSwMg8kLWn6ilfwftkDGxLQABrpFYSu SjZVqpFslipAljPqIg8E8x7ozL/4sgdnfcpLA4hFRR777CnMcpP+uKPeU 5VEYiBBgnQk4DASs2EqV/BOe71eHiKhA5eKPYsLJt3U9/iJEbyyvoDKxh JTDpVFn3BFRpwOIjQ0UdUHh20OkxUKJWUU7cSD2/vwpiSCJ1K/VZ7Q7zB 32qLl/eUZlBXuJclleFmghqGPXkGVJduJWK/cNoa2SQ5W53gBUyaH/+g0 /nXmO3esuerp7Ka86tPeKJg2t3LYI6ZbCWHhyulx0QPAEClQwO6yhgEUk w==; X-IronPort-AV: E=McAfee;i="6600,9927,10697"; a="328651235" X-IronPort-AV: E=Sophos;i="5.99,242,1677571200"; d="scan'208";a="328651235" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10697"; a="698763727" X-IronPort-AV: E=Sophos;i="5.99,242,1677571200"; d="scan'208";a="698763727" Date: Tue, 2 May 2023 09:48:46 +0800 From: kernel test robot To: "Vishal Moola (Oracle)" , Andrew Morton , Matthew Wilcox Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" , Catalin Marinas Subject: Re: [PATCH v2 21/34] arm64: Convert various functions to use ptdescs Message-ID: <202305020914.OGRWcEG1-lkp@intel.com> References: <20230501192829.17086-22-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230501192829.17086-22-vishal.moola@gmail.com> Hi Vishal, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] [also build test ERROR on linus/master next-20230428] [cannot apply to s390/features powerpc/next powerpc/fixes geert-m68k/for-next geert-m68k/for-linus v6.3] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Vishal-Moola-Oracle/mm-Add-PAGE_TYPE_OP-folio-functions/20230502-033042 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20230501192829.17086-22-vishal.moola%40gmail.com patch subject: [PATCH v2 21/34] arm64: Convert various functions to use ptdescs config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20230502/202305020914.OGRWcEG1-lkp@intel.com/config) compiler: aarch64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/8e9481b63b5773d7c914836dcd7fbec2449902bc git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Vishal-Moola-Oracle/mm-Add-PAGE_TYPE_OP-folio-functions/20230502-033042 git checkout 8e9481b63b5773d7c914836dcd7fbec2449902bc # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash arch/arm64/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202305020914.OGRWcEG1-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from include/linux/build_bug.h:5, from include/linux/bits.h:21, from include/linux/bitops.h:6, from arch/arm64/include/asm/cache.h:39, from include/linux/cache.h:6, from arch/arm64/mm/mmu.c:9: arch/arm64/mm/mmu.c: In function 'pgd_pgtable_alloc': >> arch/arm64/mm/mmu.c:440:24: error: invalid use of void expression 440 | BUG_ON(!ptdesc_pte_dtor(ptdesc)); | ^ include/linux/compiler.h:78:45: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ arch/arm64/mm/mmu.c:440:17: note: in expansion of macro 'BUG_ON' 440 | BUG_ON(!ptdesc_pte_dtor(ptdesc)); | ^~~~~~ arch/arm64/mm/mmu.c:442:24: error: invalid use of void expression 442 | BUG_ON(!ptdesc_pte_dtor(ptdesc)); | ^ include/linux/compiler.h:78:45: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ arch/arm64/mm/mmu.c:442:17: note: in expansion of macro 'BUG_ON' 442 | BUG_ON(!ptdesc_pte_dtor(ptdesc)); | ^~~~~~ vim +440 arch/arm64/mm/mmu.c 425 426 static phys_addr_t pgd_pgtable_alloc(int shift) 427 { 428 phys_addr_t pa = __pgd_pgtable_alloc(shift); 429 struct ptdesc *ptdesc = page_ptdesc(phys_to_page(pa)); 430 431 /* 432 * Call proper page table ctor in case later we need to 433 * call core mm functions like apply_to_page_range() on 434 * this pre-allocated page table. 435 * 436 * We don't select ARCH_ENABLE_SPLIT_PMD_PTLOCK if pmd is 437 * folded, and if so ptdesc_pte_dtor() becomes nop. 438 */ 439 if (shift == PAGE_SHIFT) > 440 BUG_ON(!ptdesc_pte_dtor(ptdesc)); 441 else if (shift == PMD_SHIFT) 442 BUG_ON(!ptdesc_pte_dtor(ptdesc)); 443 444 return pa; 445 } 446 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests From xen-devel-bounces@lists.xenproject.org Tue May 02 02:22:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 02:22:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528327.821314 (Exim 4.92) (envelope-from ) id 1ptfeh-0000pY-Cw; Tue, 02 May 2023 02:22:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528327.821314; Tue, 02 May 2023 02:22:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptfeh-0000pR-AP; Tue, 02 May 2023 02:22:15 +0000 Received: by outflank-mailman (input) for mailman id 528327; Tue, 02 May 2023 02:22:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptfef-0000pL-Ka for xen-devel@lists.xenproject.org; Tue, 02 May 2023 02:22:13 +0000 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2312a6a7-e890-11ed-8611-37d641c3527e; Tue, 02 May 2023 04:22:10 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 May 2023 19:22:06 -0700 Received: from lkp-server01.sh.intel.com (HELO e3434d64424d) ([10.239.97.150]) by orsmga003.jf.intel.com with ESMTP; 01 May 2023 19:22:01 -0700 Received: from kbuild by e3434d64424d with local (Exim 4.96) (envelope-from ) id 1ptfeS-0000m8-1s; Tue, 02 May 2023 02:22:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2312a6a7-e890-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682994130; x=1714530130; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=85LkbDK+KApuWepVvTrNKkbkOtRXRZZHLuh2xgotSTc=; b=nwqKegsP0FYwI/O9UMptNhx52Qh6ZPwaTrFShYhU0H4Nplhblc+73R80 EbYgIKzfGc4eAj7nFxt1Ro9/zkD8PhgGx1av99XrR8u3ZNVWRPX8UihoY rNq6+0VOx9j6ORnr5qUOA2K4szy0KIdtjdD5/FVZ0Qd+NzDHF3xRlutRv Xp8DP7t90hfIXfTzDh/ZR6RPyXvacARY8tcmEo9iYV7T/wtQgsYrL6/gI /UAQy+ZNunZz85iubO6aXtvtCeu3eoOAj6xHA3rHNGQDfxz2u5F0LDG09 Nsvaq9F0Zr13eZfMvwvoqRM+Zfp8j4CS79wFM1yapWv/VWq+7I+mgn9eL A==; X-IronPort-AV: E=McAfee;i="6600,9927,10697"; a="376342299" X-IronPort-AV: E=Sophos;i="5.99,242,1677571200"; d="scan'208";a="376342299" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10697"; a="646346632" X-IronPort-AV: E=Sophos;i="5.99,242,1677571200"; d="scan'208";a="646346632" Date: Tue, 2 May 2023 10:21:30 +0800 From: kernel test robot To: "Vishal Moola (Oracle)" , Andrew Morton , Matthew Wilcox Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, "Vishal Moola (Oracle)" , Catalin Marinas Subject: Re: [PATCH v2 21/34] arm64: Convert various functions to use ptdescs Message-ID: <202305021038.c9jfVDsv-lkp@intel.com> References: <20230501192829.17086-22-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230501192829.17086-22-vishal.moola@gmail.com> Hi Vishal, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] [also build test ERROR on linus/master next-20230428] [cannot apply to s390/features powerpc/next powerpc/fixes geert-m68k/for-next geert-m68k/for-linus v6.3] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Vishal-Moola-Oracle/mm-Add-PAGE_TYPE_OP-folio-functions/20230502-033042 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20230501192829.17086-22-vishal.moola%40gmail.com patch subject: [PATCH v2 21/34] arm64: Convert various functions to use ptdescs config: arm64-randconfig-r023-20230430 (https://download.01.org/0day-ci/archive/20230502/202305021038.c9jfVDsv-lkp@intel.com/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project b1465cd49efcbc114a75220b153f5a055ce7911f) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm64 cross compiling tool for clang build # apt-get install binutils-aarch64-linux-gnu # https://github.com/intel-lab-lkp/linux/commit/8e9481b63b5773d7c914836dcd7fbec2449902bc git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Vishal-Moola-Oracle/mm-Add-PAGE_TYPE_OP-folio-functions/20230502-033042 git checkout 8e9481b63b5773d7c914836dcd7fbec2449902bc # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash arch/arm64/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202305021038.c9jfVDsv-lkp@intel.com/ All errors (new ones prefixed by >>): >> arch/arm64/mm/mmu.c:440:10: error: invalid argument type 'void' to unary expression BUG_ON(!ptdesc_pte_dtor(ptdesc)); ^~~~~~~~~~~~~~~~~~~~~~~~ include/asm-generic/bug.h:71:45: note: expanded from macro 'BUG_ON' #define BUG_ON(condition) do { if (unlikely(condition)) BUG(); } while (0) ^~~~~~~~~ include/linux/compiler.h:78:42: note: expanded from macro 'unlikely' # define unlikely(x) __builtin_expect(!!(x), 0) ^ arch/arm64/mm/mmu.c:442:10: error: invalid argument type 'void' to unary expression BUG_ON(!ptdesc_pte_dtor(ptdesc)); ^~~~~~~~~~~~~~~~~~~~~~~~ include/asm-generic/bug.h:71:45: note: expanded from macro 'BUG_ON' #define BUG_ON(condition) do { if (unlikely(condition)) BUG(); } while (0) ^~~~~~~~~ include/linux/compiler.h:78:42: note: expanded from macro 'unlikely' # define unlikely(x) __builtin_expect(!!(x), 0) ^ 2 errors generated. vim +/void +440 arch/arm64/mm/mmu.c 425 426 static phys_addr_t pgd_pgtable_alloc(int shift) 427 { 428 phys_addr_t pa = __pgd_pgtable_alloc(shift); 429 struct ptdesc *ptdesc = page_ptdesc(phys_to_page(pa)); 430 431 /* 432 * Call proper page table ctor in case later we need to 433 * call core mm functions like apply_to_page_range() on 434 * this pre-allocated page table. 435 * 436 * We don't select ARCH_ENABLE_SPLIT_PMD_PTLOCK if pmd is 437 * folded, and if so ptdesc_pte_dtor() becomes nop. 438 */ 439 if (shift == PAGE_SHIFT) > 440 BUG_ON(!ptdesc_pte_dtor(ptdesc)); 441 else if (shift == PMD_SHIFT) 442 BUG_ON(!ptdesc_pte_dtor(ptdesc)); 443 444 return pa; 445 } 446 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests From xen-devel-bounces@lists.xenproject.org Tue May 02 03:59:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 03:59:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528330.821325 (Exim 4.92) (envelope-from ) id 1pthAv-0001pJ-A2; Tue, 02 May 2023 03:59:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528330.821325; Tue, 02 May 2023 03:59:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pthAv-0001pC-7E; Tue, 02 May 2023 03:59:37 +0000 Received: by outflank-mailman (input) for mailman id 528330; Tue, 02 May 2023 03:59:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pthAu-0001p6-2Y for xen-devel@lists.xenproject.org; Tue, 02 May 2023 03:59:36 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bdb2bdd0-e89d-11ed-8611-37d641c3527e; Tue, 02 May 2023 05:59:32 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 399EC618FE; Tue, 2 May 2023 03:59:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E4C1C433D2; Tue, 2 May 2023 03:59:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bdb2bdd0-e89d-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682999969; bh=pmCTwM5JeS/nROPQdqbvEVzgt5qKVs7zZy9Af5KBrC0=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=LpV7prXFLMFtaEZrhSeYwjhaMrErPjwtYqkH1CkPrNmwpXPJS3FOOvEFyONbjilRG 9N5bgQCO04Mr9HUip9M1I98h/8mi8ArU/EmTRqWi++UzLM+t+fw8J//1huirwUCMoh QCsttQxykjd/PjYjpQKAgcPdeR5wJjpNZYSzaOFaWvsBg0iswwNr5JkUWX0wm1Mw7K 7SKRLdMHdjojXXVRa9q1dXgnd3GL3LpAQdg2Fy8zS1ROFvb4bbPgs3tawVFJPnpONL GHgZRSAzatM1T09iHkbRKh9rs1Ef2EaHelrMoKYPRmxWlz0KE8EFv71DUICe7cmwbO 9NcVX/7JCmkRQ== Date: Mon, 1 May 2023 20:59:26 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Stefano Stabellini cc: andrew.cooper3@citrix.com, alejandro.vallejo@cloud.com, committers@xenproject.org, michal.orzel@amd.com, xen-devel@lists.xenproject.org Subject: Re: xen | Failed pipeline for staging | 6a47ba2f In-Reply-To: Message-ID: References: <644bfbc6939d8_2a49bbb403253f4@gitlab-sidekiq-catchall-v2-78885c497-qxnp2.mail> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Sat, 29 Apr 2023, Stefano Stabellini wrote: > Your guess was correct. I have done more bisecting today. The culprit is > the following commit (I reverted only this commit and ran 25 tests > successfully, usually it fails in less than 5): > > e522c98c3 tools: Refactor console/io.c to avoid using xc_domain_getinfo() I did more debugging. One problem seems to be that XEN_SYSCTL_getdomaininfolist is buggy in the hypervisor. The field u.getdomaininfolist.num_domains is not copied back to the guest. It doesn't look like the hypercall would behave well for more than 1 guest. I am appending the fix. This is not sufficient to fix the failure. On a hunch, I made this change: /* Fetch info on every valid domain except for dom0 */ - ret = xc_domain_getinfolist(xc, 1, DOMID_FIRST_RESERVED - 1, domaininfo); + ret = xc_domain_getinfolist(xc, 1, 10, domaininfo); if (ret < 0) return; With it, everything works. I have run out of time today for my investigation. I would like to take the opportunity to highlight that gitlab-ci did a very good job spotting an issue. I am glad we are starting to reap the benefits of all the hard work we put into it. Cheers, Stefano --- xen: fix broken XEN_SYSCTL_getdomaininfolist hypercall XEN_SYSCTL_getdomaininfolist doesn't actually update the guest num_domains field, only its local copy. Fix that. Signed-off-by: Stefano Stabellini diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c index 02505ab044..0e1097be96 100644 --- a/xen/common/sysctl.c +++ b/xen/common/sysctl.c @@ -107,10 +107,8 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl) rcu_read_unlock(&domlist_read_lock); - if ( ret != 0 ) - break; - op->u.getdomaininfolist.num_domains = num_domains; + __copy_field_to_guest(u_sysctl, op, u.getdomaininfolist.num_domains); } break; From xen-devel-bounces@lists.xenproject.org Tue May 02 05:43:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 05:43:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528335.821336 (Exim 4.92) (envelope-from ) id 1ptimk-0004wK-Ub; Tue, 02 May 2023 05:42:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528335.821336; Tue, 02 May 2023 05:42:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptimk-0004wD-Pp; Tue, 02 May 2023 05:42:46 +0000 Received: by outflank-mailman (input) for mailman id 528335; Tue, 02 May 2023 05:42:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptimi-0004w6-DA for xen-devel@lists.xenproject.org; Tue, 02 May 2023 05:42:44 +0000 Received: from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de [81.169.146.163]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 27b03e94-e8ac-11ed-b225-6b7b168915f2; Tue, 02 May 2023 07:42:42 +0200 (CEST) Received: from sender by smtp.strato.de (RZmta 49.4.0 AUTH) with ESMTPSA id x6987cz425gTaRK (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Tue, 2 May 2023 07:42:29 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 27b03e94-e8ac-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1683006149; cv=none; d=strato.com; s=strato-dkim-0002; b=hz4P2fYHoTAGVQJxiYF1+wg1eGX4s1T6oLiKnz3J9ijpYzkt+pHRrYGLY9KNIi5wSc vwk/W94SFCc5885n0F3vIjEqHm4jdMyEIuOjtwJ+Q2OzZMvSkhkaBQVZ3PZfoFFfnvj9 yVglKOzNQ1C3ZTIrTqiU9/kQCfkwQxLqKirs/13YydPRb/4Prq4LQMCfKMZJOkzqX9cs vhQCqLLL4j6Ja2EtuiQ4kGvrWcd79kVJ38awktFQ68ZExXFNvhIZYzPETIXNvrYVSK6v FMxBeC55j1VchQhPXE5KspldBUVi/fpvbjx9Eg7HqWG6EVgkhqEltyoP6ti3RtH9qCHw Yw8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1683006149; s=strato-dkim-0002; d=strato.com; h=Message-Id:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=GhE5fBfcNwMLwxUGqEDocKD//uK7BAVcWCZfFlhjFms=; b=Gde1FB+GfQETrwt+XkxjfOrvcybPN0VAQeR9m+K2cd4mfnDYlxtOnOSquEVUbYxevI Dds1Z3Oy2vNgHTeUIyGnMRvxyHDDMYN6mYqmPISUsSWnjeZPE2HZQJHJQumZU47MW4G4 grW5N/u6w44/Z88lRmrldU4FBErCS1InX/4tTtthsj0ByTWjPvc3908biRdZ2T9Jo3RN B88jXkKE0L97zI+vkLcaK/Yh3HhdWw4v9a/NKsxidkF+oVhMHe09wRrYEa3pxrOCuyxW t65iRbILnc09mZfd2a6CAEONc+UWobZvMO2OFGn74iAZzPB1bqrw8v1MSEGX6biEw07Y cU3A== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1683006149; s=strato-dkim-0002; d=aepfle.de; h=Message-Id:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=GhE5fBfcNwMLwxUGqEDocKD//uK7BAVcWCZfFlhjFms=; b=PS3ttY3jAhpm4VF4UrTquU3/BxHgUGsP9e4yt/292Jn9arpNz90rNGgsDIq0qG6hIj xVb0cdSgiY3CvTSmatDIM9U6dqOAOrYxLxMaq+t9dGgrkb4Rc68DpVamAt9JpVRtJ4pw qaoaDOh6cozDCLuhDVzIxtGV+V/y+jMeupUw8sTqtzWz8mDnNG2ayw8gzIf3nXf4dqfr 4wUZCT6JXwl1/1av7ceNyPfmRRQVP24LQV2dI6oKGWpetZ3IXJb3bheITpjIQ8wgRRYT a22FzeGFw3Z23t1Ty6w5LzK04dxDFwCXMi8IvwnEur7/zjUKgamIoea5Heoz8e1hElKN hxPA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1683006149; s=strato-dkim-0003; d=aepfle.de; h=Message-Id:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=GhE5fBfcNwMLwxUGqEDocKD//uK7BAVcWCZfFlhjFms=; b=jce+kKB9N9Yw3D4ke3LWxnftnI7FNN8KoVsLRzyBG4JD1+RhZ4FP33vzSxtCde+Uap VdFO+886OfHYvfQLSEDA== X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg4wqVv7FZ8tH5EUSbMVU80kUr7f4QlYaI60OjHt/Q==" From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini Subject: [PATCH v1] automation: provide diffutils and ghostscript in opensuse images Date: Tue, 2 May 2023 05:42:18 +0000 Message-Id: <20230502054218.15303-1-olaf@aepfle.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="us-ascii" The diffutils package is a hard requirement for building xen. It was dropped from the Tumbleweed base image in the past 12 months. Building with --enable-docs does now require the gs tool. Add both packages to the suse dockerfiles. Signed-off-by: Olaf Hering --- automation/build/suse/opensuse-leap.dockerfile | 2 ++ automation/build/suse/opensuse-tumbleweed.dockerfile | 2 ++ 2 files changed, 4 insertions(+) diff --git a/automation/build/suse/opensuse-leap.dockerfile b/automation/build/suse/opensuse-leap.dockerfile index bac9385412..c7973dd6ab 100644 --- a/automation/build/suse/opensuse-leap.dockerfile +++ b/automation/build/suse/opensuse-leap.dockerfile @@ -18,11 +18,13 @@ RUN zypper install -y --no-recommends \ clang \ cmake \ dev86 \ + diffutils \ discount \ flex \ gcc \ gcc-c++ \ git \ + ghostscript \ glib2-devel \ glibc-devel \ # glibc-devel-32bit for Xen < 4.15 diff --git a/automation/build/suse/opensuse-tumbleweed.dockerfile b/automation/build/suse/opensuse-tumbleweed.dockerfile index 3e5771fccd..7e5f22acef 100644 --- a/automation/build/suse/opensuse-tumbleweed.dockerfile +++ b/automation/build/suse/opensuse-tumbleweed.dockerfile @@ -18,11 +18,13 @@ RUN zypper install -y --no-recommends \ clang \ cmake \ dev86 \ + diffutils \ discount \ flex \ gcc \ gcc-c++ \ git \ + ghostscript \ glib2-devel \ glibc-devel \ # glibc-devel-32bit for Xen < 4.15 From xen-devel-bounces@lists.xenproject.org Tue May 02 05:49:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 05:49:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528339.821345 (Exim 4.92) (envelope-from ) id 1ptisz-0005ZZ-JY; Tue, 02 May 2023 05:49:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528339.821345; Tue, 02 May 2023 05:49:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptisz-0005ZS-Fl; Tue, 02 May 2023 05:49:13 +0000 Received: by outflank-mailman (input) for mailman id 528339; Tue, 02 May 2023 05:49:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptisy-0005ZM-14 for xen-devel@lists.xenproject.org; Tue, 02 May 2023 05:49:12 +0000 Received: from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de [81.169.146.219]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0fbe4ac5-e8ad-11ed-b225-6b7b168915f2; Tue, 02 May 2023 07:49:11 +0200 (CEST) Received: from sender by smtp.strato.de (RZmta 49.4.0 AUTH) with ESMTPSA id x6987cz425nAaSe (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate) for ; Tue, 2 May 2023 07:49:10 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0fbe4ac5-e8ad-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1683006550; cv=none; d=strato.com; s=strato-dkim-0002; b=f+QlJylNgM5LghQjiXyqVyI+qwXVrI44uqcb0hsqHsizeLa/cH85IV4Jb9KoS1F6jc f0sqtpTKBWXIsfCommQDn5AY1HNLP0jlASwtjG6IFBmbfx0I9ECfgCwTC0Bhd+9UfzWC oRUaLi8HIkcp4Qu11PQvYinXcaAN/1qyHpHSu5ytNX/ntjdepcEu0Q7FOQjqoGACT1De T21/tLTEC/G77ivz2/wkfWrCQwGCGifYVtvGyUIT6NOn3VBKe2F4zGCmAU+L3c/LOUsS 7g4mDiFpNaacogTYJ2dq2UJP07NzzICxbadiiISEPnPGubnyiD4Um7/QgTqabL+CrJK0 jsIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1683006550; s=strato-dkim-0002; d=strato.com; h=Message-ID:Subject:To:From:Date:Cc:Date:From:Subject:Sender; bh=98qYXeKcPqrWVbf2mQ/Ey9QiiyRrTjLYLEEwS8i5Dso=; b=Fkt+ljJpvJh4mYjNgiEBTAxVtmgp8w7mGgtHdGSy6n4Y2rMygslWOEjUgHxjlmYDv+ Fd+/3j8lo4KeEf4giy7z3kF572B5NsrMkWG0OLDK0B8AYEvAexPUaxdtsV8MzYjJmviP PbQ9Q0RNLjVkPKnWWbfpMcPV/CTBHFhUFHcmWuh87jvScWpFQuLY0XVGlz6kUVWR9Di6 zNVmuvSOBN21e6j0SvMezv28JyNO8CDYZJ15v45U95T3mMiN2iRE6S1fwITg/teCYakw tGa3f1huIiKryD3PvfY33zppuOddCm9fWIFnnHmTGifXcK4piV6lnis4DLUTwscJE70w 9yZQ== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1683006550; s=strato-dkim-0002; d=aepfle.de; h=Message-ID:Subject:To:From:Date:Cc:Date:From:Subject:Sender; bh=98qYXeKcPqrWVbf2mQ/Ey9QiiyRrTjLYLEEwS8i5Dso=; b=n0pjWuG8dTEZua1BSIDkzictqoaJOZCkusNR225/oYRUqVtLqt2guxtC04rrjYLkkg TE9P4fenN45pfzHZhv6PEzNK2jQY1LlyVev2pfYEPDIQhStWV1uBHi4fSNex1RUJAHrO gAqRd7i5uh2tugSUdFe77fO5FZVo4ZurApEcZZFqhzLJFbN6oU3ZDEqY5rKna47kqUEc 9qtfIKLpNTBOipc06ekhUlWj5lUs+qGjSFKPq93a9Z9m9ZsCeVHYhSzqVsYzh093Hu5I /Yd8UvAkmzyXd16geme5j+TIMP3bejWbrEVJ2vsibiJG4dL3t7ORdE5RMKgjpQXK3TVL MZcw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1683006550; s=strato-dkim-0003; d=aepfle.de; h=Message-ID:Subject:To:From:Date:Cc:Date:From:Subject:Sender; bh=98qYXeKcPqrWVbf2mQ/Ey9QiiyRrTjLYLEEwS8i5Dso=; b=wrJmCI7pkFXzpmEWrquKXphK6J3COdOJufzhdOJvpvfBVGU1h2QtHFmJ6gKiVoripN 73NrW+GFjSHOgP2QK+DA== X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisR5BxOIbBnsc1fym1gFvNQ7EzMpH+yFJc4aADp/8Q==" Date: Tue, 2 May 2023 07:48:53 +0200 From: Olaf Hering To: xen-devel@lists.xenproject.org Subject: HAS_CC_CET_IBT misdetected Message-ID: <20230502074853.7cd10ee3.olaf@aepfle.de> X-Mailer: Claws Mail 20220819T065813.516423bc hat ein Softwareproblem, kann man nichts machen. MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/wxBthHcgG/WUfQyJhujuOEU"; protocol="application/pgp-signature"; micalg=pgp-sha256 Content-Transfer-Encoding: 7bit --Sig_/wxBthHcgG/WUfQyJhujuOEU Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable The next push to xen.git#staging will trigger a build failure in the refres= hed Leap docker image. For some reason HAS_CC_CET_IBT will evaluate to true. I think the significa= nt change is the binutils upgrade from 2.37 to 2.39 in November 2022. The comment indicates the combination of gcc7 and binutils 2.39 is supposed= to evaluate HAS_CC_CET_IBT to false. Olaf --Sig_/wxBthHcgG/WUfQyJhujuOEU Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmRQpEUACgkQ86SN7mm1 DoDcZRAAkbewwB0xogP4GGHk8EbSNS98gAt4lceiXyk3zK7g0ig4LqppH1TVNXqv a1Iz07Vw7RLGj/oQMMkR7oi+fMw6yHnc9Me6yjEGK/EoHaNEVRIL/Qu/nphr9Q/G Hm2L+X3aYOC1k38lAgu1WFUoarbwdSJMc+5PKmwH/o5AbMgvWQHcIXtzkYaT4JN/ mBNnihgHMa/t9TGkFltz8lRdYe7LMTn2EezFIbSDarjy7oFwqaOS7VlM4A9OJY5Z 14iY8CKV9m/r+vk4+CTY6uIdhP5wl9VkI5IKR+pDebfBsomK68K7YqhsWMPYILJc BS4Lm8YcSo4c6BLn6r9ARjMoA7ST1QHmzdouOLrp8Q4f7JralPyNJIjqgmtSEgtU /jJY49RTsad+3Pb30zx0XB0KwhrYYhZWSDD4Pwl7dWdovAIfXyk/66G0NT59qRFM pnfzAAjEwLFZduRDUZ5Jlb9SP+KSsKeIEx66ruyys+GSX0Iiur/PkY//b1ai/L9E nJXCiPjqECPnvL8yJDHSZ+9DTaKw2ArdPYiozZNNJg5NbRrpWf7YgdutWD+Ng3f8 eQY0Hy2n2yXiKxF39sjMVU0GeqDEHKjzkqnJG8+5rGOP/HwZhh3gA5k/FlCd2ZfV Yf/KLoYGU4isCM3OM1mAe+nA8dv6oChhmXXOpHfwE4+PSI1mZLE= =RLv9 -----END PGP SIGNATURE----- --Sig_/wxBthHcgG/WUfQyJhujuOEU-- From xen-devel-bounces@lists.xenproject.org Tue May 02 06:00:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 06:00:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528343.821355 (Exim 4.92) (envelope-from ) id 1ptj3w-000865-IO; Tue, 02 May 2023 06:00:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528343.821355; Tue, 02 May 2023 06:00:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptj3w-00085y-FQ; Tue, 02 May 2023 06:00:32 +0000 Received: by outflank-mailman (input) for mailman id 528343; Tue, 02 May 2023 06:00:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptj3u-00085s-P4 for xen-devel@lists.xenproject.org; Tue, 02 May 2023 06:00:31 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2085.outbound.protection.outlook.com [40.107.7.85]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a4191ef1-e8ae-11ed-b225-6b7b168915f2; Tue, 02 May 2023 08:00:29 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by GV1PR04MB9149.eurprd04.prod.outlook.com (2603:10a6:150:24::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 05:59:58 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6340.030; Tue, 2 May 2023 05:59:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a4191ef1-e8ae-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hmBzpeFU5yhVNK2nG3nUwqCaQ9wAtkOdDP7XjUpVNmAxmYX5rjZfd8M2NCy4utLq2w79ffgelFSTivHvQjwTLEpdiNs920d0VaNGQbZgGqKuqNzqQRpabM+E2Yft8CG7MYFAWJb+K36rICMxwIesPCuW2Xx7rFuM96HLmHeGdczpJRXFjJN2mk/dSMHtsKFbBl/CTleh8ORbU0r5fcLI5/EfnkkyQlHBe9d1VGJ7S5bT8JrUyvfqJ4zRD2I+hsnrGWNAMuHjD4rjcR4DMrV7jnHVAalkxgHJkFb5J6oYmvzUvPPMpF0WQN1gFN5McQ4L6wiFDrwNYX8nYfnIQXjquQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UqUDT48TZ44wEPoY2YLLLr65qaAbK6lEv81awHVxLKE=; b=UesVRjxai+9smaFUJa/clDWj6iOI5t+HZrsl6GU4jAcaj2yddayF1w+IEU0y0zitnt0Oo5s/TSF8Z0Z++lPP1eoeC4f2pdEf8kEMmBBrYfRAoPsafsQggX6Krq8+gLV4l3PYGyWlmYNoxW71tDqzDf+s+iPwYOh6OjsTuKlNli7ll5J41aXWVNENaLHCx8C115rS9lYCU2gncavV7p8UwPzORTAMN3nzDnOGAVw3X1Whh9kw+FS9fn92jqbYHD5bcwe5/d7H/u7xNN9XXqkuSAR2JiLn8zaFqOYre5gX1HIKD97Dv/wx2DR8lmudAAgIS9xM7t/49Rb3B+eWlO6FVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UqUDT48TZ44wEPoY2YLLLr65qaAbK6lEv81awHVxLKE=; b=KZDEwZuVNYbydsBXnsQpDm0SxNSB1sJeUh2OKAhiaW0oqgXBrh+WTeSNedjqni5iWS64ewA8sOqyugp77VptoIblb+f1+n8/pVzKW9fbQP62/ZA2RBzvffU1RG/DHZdhY42h6Xx+PBrpkgdHLzFySl1pIBqTgmG8TftZgbRCGMmqevGr/juqT+4cFo/kjCRcOTyTN8PxF2yzn9pHAlB29vajaJQ2DTfpElcYks/qG8bc/2hXuEu0ekNGEu9xR4T39V2R8fx6htW/ZXw9k3WgCky0M+e3BrtISaLXPEcKIQzspp2UU5xxS//vFJQZekk/m2rVOfyW8Ew7T1l+Vk6Y7g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <211ad193-07d3-2e9b-2215-c31858b854f2@suse.com> Date: Tue, 2 May 2023 07:59:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [BUG] x2apic broken with current AMD hardware To: Elliott Mitchell Cc: xen-devel@lists.xenproject.org References: <21436010-8212-7b09-a577-09d3f57156bf@suse.com> Content-Language: en-US From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0211.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ac::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|GV1PR04MB9149:EE_ X-MS-Office365-Filtering-Correlation-Id: 449bc788-c9cb-4930-6828-08db4ad27580 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JgJYAeKkDKBpjlZ3zqwp9ORsnCrZTbI5x8Ad3xTLN+eDZZYYJTzZ5QD9iaTTzwDmXU6D1RatC9yRyUr3CHNzqy1vvsNuI+F3fRkY6cHrsonlwOl9ISwDdvSAF/5UBoxosK+SldFCfA4m+lIlU3qOUl8uyPTzRcLCHLN/CpzI3l2SFiiU49j01tlHJXr3QH+EokvLO7KK1wDv4wMg6IW172RHOuRDn0o7UnLqH8dwnJSxAUqWwQ2KGvXOTM7l8v9YNPKVjAxxKfMMLQY4G73Upp7PuCBfJ2W5YZFYbg85bLkslMwTQki6/0urQk+W0vduOHMqZakSlCkdFB1mU/itMLJ2HUoZxS8bBpd92Tx99wuEEc4EsPhORV5EOhC6FVo7ErAuIlHRPpfYQAKQpX7ZNknfvQWW7fX7gqcEOhlq2EW5gjjgfstm4MBSq5jgVG46yEojE2gyjYliSn2BYeIPFPV6RAn856AcEOk9gNXTy/R6nADm5r/fk0pVYp4vBp56nYBa3RHQqM7nw0NIBYs1ymdz83TZKK90YLh6kr53h3cZbo7GbpsurMR3UMkP9/JHSTuSlXb5hhX38MZWZ95bQDdUilSZJRDPIOHcITaUIeF0oYP+RPrujiW1nCR0+A08Vi1fvM1S8gzsYjrULn9G4Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(376002)(396003)(39860400002)(346002)(136003)(451199021)(2616005)(83380400001)(478600001)(53546011)(31696002)(6486002)(26005)(6512007)(6506007)(66946007)(66476007)(66556008)(316002)(4326008)(186003)(31686004)(41300700001)(8676002)(5660300002)(8936002)(38100700002)(2906002)(86362001)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cmxuNDVlcjVoQktUODh4RzZRSXRrWVpJMFZDL2hVMW5vRkVmWEZtNVdsaU43?= =?utf-8?B?cHhNbGFQUm1PN2ZSeDdMdzhLRko2WFhocE1POERJM0ZlOXR6U3ZqLzNRdWRz?= =?utf-8?B?YnlaVzBZWmlBMXNpa1pleGhBQnVWYU14ajZOVnZKempUTUJYQnVMYmw5bC9V?= =?utf-8?B?cVQvVjFUVlQxY0VFQi9SdzcvOFZBaWZMNnpZM2JXUGt3M1V0Z0NWUG1ibVZ4?= =?utf-8?B?OGoyM0p1N1NEY0hJTXFmd0dUcnhpUDdMdWpRUUJCeDdaclpRc2V2QXlaTi96?= =?utf-8?B?TG1SZ1psbXZ5SWd5NlZ3Y0p6ME94aHRJT1RCUXo3dzJmVG9sK2VqcHJUSWlD?= =?utf-8?B?OGdyU3Bhck1ZSEJOT1FVemhuRmk5Vmd6aU5Hdnh1MHpKTm1WSVJWeUJkSGNj?= =?utf-8?B?emE4Q3YxWm11K0Q0Y2t5OElJSGFWYitleHBkbk1sR1VueXVVM3BzYk9zOGpL?= =?utf-8?B?VmQ3cjY1RW9lT2ROd0hDeW9IUGQ5Q3dUdDZjajc5VmdIU2xFdWlPYWVlWmNs?= =?utf-8?B?MEcydWpZaGk4cjFwVTV5NWoxWU1zaDNYTVBzYVB2b01hRWNJdWFXNHVjc3g3?= =?utf-8?B?U1BlVDY1MXJGQmhTSXRVNDQzOEFwdkdCbzdSMUwzZmx3Vm84RlBQMU1obkhq?= =?utf-8?B?ZFNrVm9KS2J6ZzlkU1RyNzlISjVKdTJVcC8vNVljSncza0p0REpiZU9KZyt6?= =?utf-8?B?ejdiVlpYVVhFaUFabXFjbDg0Vlg5V2VQaFNtZS9Fb2UybU5wUVRtNnNzNDYr?= =?utf-8?B?Ny9LMVZObkw0c3hVNUxYZlMwdndVaTlHM21XcFduREN1TWFUQzZnU25mbmQw?= =?utf-8?B?a1FQV0NGN1pESUk5L2owL1FIcis0VXVMY2RYUXdMLy9qZy8za28zUVlCZnds?= =?utf-8?B?K3Y4S1BVRllRQkI0NXR6ay92WWFOa1p5cXNyNjF3OHQrZlFONkNyN2tsNFpU?= =?utf-8?B?RDZOdyt6c1pFNWNQa2xPMGJ5Q25WYjZLTU1vQmlldHFQazRrVUx1ZDRCTHR3?= =?utf-8?B?NWEybm1SbU5LSkhyMWRaNVlTdThMNWtGcVhLNUIwMXh5cVhuWjYxOHRsOWpH?= =?utf-8?B?L0FrQkhTeEtvSVdQQ3R0dnhVMU45djJHV1BaQ1BFdTJVN1o1QmtXRi9xV0V5?= =?utf-8?B?YTBxWC9ScDk5VU5wemNtTnB2djhPYnBvT2RrYlkyVFQybDZmOCtnT3grNmFl?= =?utf-8?B?OGhKVXluTlFuZ0srdWNwYWVyaEY1V0VadlE3Yno5ZU00VEhWazFNOWVSWHZ0?= =?utf-8?B?WCtEZG5RemJvNmRSZy9wUTdJUjk3SktiU1B0MjB1dFZOd3dVNXdxRmV6c0h6?= =?utf-8?B?NDFvRklLQlc2Y1N4Sk1TNnBrd2ZxQlppZk9rTzk3SEtXTlkvT2gzM25uUlRT?= =?utf-8?B?TGkwZk04ZEVKcXN1Q09hT1E0ZWlNQjJWbkZtV2JZaFVmZUxDVUp2SFpnM0xJ?= =?utf-8?B?bEt3Wkkza1ZkSUkvWUE1b0VEN29Tc09wODI4MHZoWHYveHNZWERlaEpWbVZR?= =?utf-8?B?akJTU1R4bVF2RkFETE5aQVhyZGRJczVPVVpJMDZmelFnT3d1QlpJaUI4OFJz?= =?utf-8?B?ckhzMHd2MU5PMlhGMG5BOEp6MUFEWHFnME1GQW9IdXIrY0lxTWI5amlEeC9s?= =?utf-8?B?a1RMejd3MjBUM2Z6bmh5SEFuUnBJdnBRbDFnYW1RcVF2UjBFSDRTS3JsSldz?= =?utf-8?B?emVneXBWK1FmWXBXNUhlWlRxWmNIMUthNEtpZzMzMEl4eXEzNC9OOE9odmVj?= =?utf-8?B?aDd5d1pVZjJ2RlFpYndWYXBweURubmxwZXVJWDhRQ3JaVEpyZHh0TjFSbHF1?= =?utf-8?B?VFpWT1U4K1JGc2V3cnRyWks5TDRiT3JWQ1RIalB2dy9LWk9HMEZ1THZ2dkpD?= =?utf-8?B?eWliRHhNcU5reGJMeHh0YkZwSnRGM2ExVWFoVU9nUldiQWR0ZDlGbFZGYjNM?= =?utf-8?B?eVcrNDVjWkIwck4zSFFreGhvSS9kckw0eHNMVWNrczh6Uk9pak95QXBtVWFT?= =?utf-8?B?UXZ2RnlmU2lNQWovTlhsMmNQTVB4SFp1OUUreWpNdHByUXNrNGk0bTAyclFs?= =?utf-8?B?UE9pWi9tdHM1dU1IRFhsSkUycHA3WDhPM3dVSUM1d2NhdC9IQlRTU3plRXBn?= =?utf-8?Q?XGtixyIqmTZ5EXcF1SeQeCwHZ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 449bc788-c9cb-4930-6828-08db4ad27580 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 05:59:58.0233 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xGt4dYGuEVT4xri3+6/MtU0EppJg+5wr6l0E8jloxUNuw7uEUaqC3EgNJUIvHU5ut3P/PO7oN3ht2xBBz9D09A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9149 On 30.04.2023 19:16, Elliott Mitchell wrote: > On Mon, Mar 20, 2023 at 09:28:20AM +0100, Jan Beulich wrote: >> On 20.03.2023 09:14, Jan Beulich wrote: >>> On 17.03.2023 18:26, Elliott Mitchell wrote: >>>> On Fri, Mar 17, 2023 at 09:22:09AM +0100, Jan Beulich wrote: >>>>> On 16.03.2023 23:03, Elliott Mitchell wrote: >>>>>> On Mon, Mar 13, 2023 at 08:01:02AM +0100, Jan Beulich wrote: >>>>>>> On 11.03.2023 01:09, Elliott Mitchell wrote: >>>>>>>> On Thu, Mar 09, 2023 at 10:03:23AM +0100, Jan Beulich wrote: >>>>>>>>> >>>>>>>>> In any event you will want to collect a serial log at maximum verbosity. >>>>>>>>> It would also be of interest to know whether turning off the IOMMU avoids >>>>>>>>> the issue as well (on the assumption that your system has less than 255 >>>>>>>>> CPUs). >>>>>>>> >>>>>>>> I think I might have figured out the situation in a different fashion. >>>>>>>> >>>>>>>> I was taking a look at the BIOS manual for this motherboard and noticed >>>>>>>> a mention of a "Local APIC Mode" setting. Four values are listed >>>>>>>> "Compatibility", "xAPIC", "x2APIC", and "Auto". >>>>>>>> >>>>>>>> That is the sort of setting I likely left at "Auto" and that may well >>>>>>>> result in x2 functionality being disabled. Perhaps the x2APIC >>>>>>>> functionality on AMD is detecting whether the hardware is present, and >>>>>>>> failing to test whether it has been enabled? (could be useful to output >>>>>>>> a message suggesting enabling the hardware feature) >>>>>>> >>>>>>> Can we please move to a little more technical terms here? What is "present" >>>>>>> and "enabled" in your view? I don't suppose you mean the CPUID bit (which >>>>>>> we check) and the x2APIC-mode-enable one (which we drive as needed). It's >>>>>>> also left unclear what the four modes of BIOS operation evaluate to. Even >>>>>>> if we knew that, overriding e.g. "Compatibility" (which likely means some >>>>>>> form of "disabled" / "hidden") isn't normally an appropriate thing to do. >>>>>>> In "Auto" mode Xen likely should work - the only way I could interpret the >>>>>>> the other modes are "xAPIC" meaning no x2APIC ACPI tables entries (and >>>>>>> presumably the CPUID bit also masked), "x2APIC" meaning x2APIC mode pre- >>>>>>> enabled by firmware, and "Auto" leaving it to the OS to select. Yet that's >>>>>>> speculation on my part ... >>>>>> >>>>>> I provided the information I had discovered. There is a setting for this >>>>>> motherboard (likely present on some similar motherboards) which /may/ >>>>>> effect the issue. I doubt I've tried "compatibility", but none of the >>>>>> values I've tried have gotten the system to boot without "x2apic=false" >>>>>> on Xen's command-line. >>>>>> >>>>>> When setting to "x2APIC" just after "(XEN) AMD-Vi: IOMMU Extended Features:" >>>>>> I see the line "(XEN) - x2APIC". Later is the line >>>>>> "(XEN) x2APIC mode is already enabled by BIOS." I'll guess "Auto" >>>>>> leaves the x2APIC turned off since neither line is present. >>>>> >>>>> When "(XEN) - x2APIC" is absent the IOMMU can't be switched into x2APIC >>>>> mode. Are you sure that's the case when using "Auto"? >>>> >>>> grep -eAPIC\ driver -e-\ x2APIC: >>>> >>>> "Auto": >>>> (XEN) Using APIC driver default >>>> (XEN) Overriding APIC driver with bigsmp >>>> (XEN) Switched to APIC driver x2apic_cluster >>>> >>>> "x2APIC": >>>> (XEN) Using APIC driver x2apic_cluster >>>> (XEN) - x2APIC >>>> >>>> Yes, I'm sure. >>> >>> Okay, this then means we're running in a mode we don't mean to run >>> in: When the IOMMU claims to not support x2APIC mode (which is odd in >>> the first place when at the same time the CPU reports x2APIC mode as >>> supported), amd_iommu_prepare() is intended to switch interrupt >>> remapping mode to "restricted" (which in turn would force x2APIC mode >>> to "physical", not "clustered"). I notice though that there are a >>> number of error paths in the function which bypass this setting. Could >>> you add a couple of printk()s to understand which path is taken (each >>> time; the function can be called more than once)? >> >> I think I've spotted at least one issue. Could you give the patch below >> a try please? (Patch is fine for master and 4.17 but would need context >> adjustment for 4.16.) > > Given the patch didn't fix the problem, that wasn't the issue. I did > though manage to try another variant of BIOS settings for this > motherboard. Setting "Local APIC Mode" to "x2APIC" in the BIOS neither > breaks anything additional, nor fixes issues. What was in Xen's dmesg > did change slightly and looks likely better for my purposes. Some more > snippets from 4.17 Xen dmesg, with "x2apic_phys=true": > > (XEN) AMD-Vi: IOMMU Extended Features: > (XEN) - Peripheral Page Service Request > (XEN) - x2APIC > (XEN) - NX bit > (XEN) - Guest APIC Physical Processor Interrupt > (XEN) - Invalidate All Command > (XEN) - Guest APIC > (XEN) - Performance Counters > (XEN) - Host Address Translation Size: 0x2 > (XEN) - Guest Address Translation Size: 0 > (XEN) - Guest CR3 Root Table Level: 0x1 > (XEN) - Maximum PASID: 0xf > (XEN) - SMI Filter Register: 0x1 > (XEN) - SMI Filter Register Count: 0x1 > (XEN) - Guest Virtual APIC Modes: 0x1 > (XEN) - Dual PPR Log: 0x2 > (XEN) - Dual Event Log: 0x2 > (XEN) - Secure ATS > (XEN) - User / Supervisor Page Protection > (XEN) - Device Table Segmentation: 0x3 > (XEN) - PPR Log Overflow Early Warning > (XEN) - PPR Automatic Response > (XEN) - Memory Access Routing and Control: 0x1 > (XEN) - Block StopMark Message > (XEN) - Performance Optimization > (XEN) - MSI Capability MMIO Access > (XEN) - Guest I/O Protection > (XEN) - Enhanced PPR Handling > (XEN) - Invalidate IOTLB Type > (XEN) - VM Table Size: 0x2 > (XEN) - Guest Access Bit Update Disable > (XEN) AMD-Vi: Disabled HAP memory map sharing with IOMMU > (XEN) AMD-Vi: IOMMU 0 Enabled. > > > (XEN) I/O virtualisation enabled > (XEN) - Dom0 mode: Relaxed > (XEN) Interrupt remapping enabled > (XEN) nr_sockets: 1 > (XEN) Enabled directed EOI with ioapic_ack_old on! > (XEN) Enabling APIC mode: Physical. Using 2 I/O APICs > (XEN) ENABLING IO-APIC IRQs > (XEN) -> Using old ACK method > > > (XEN) SVM: Supported advanced features: > (XEN) - Nested Page Tables (NPT) > (XEN) - Last Branch Record (LBR) Virtualisation > (XEN) - Next-RIP Saved on #VMEXIT > (XEN) - VMCB Clean Bits > (XEN) - DecodeAssists > (XEN) - Virtual VMLOAD/VMSAVE > (XEN) - Virtual GIF > (XEN) - Pause-Intercept Filter > (XEN) - Pause-Intercept Filter Threshold > (XEN) - TSC Rate MSR > (XEN) - NPT Supervisor Shadow Stack > (XEN) - MSR_SPEC_CTRL virtualisation > (XEN) HVM: SVM enabled > > If I'm reading that correctly, everything is there for x2APIC. As such > there seem to be 1 or 2 bugs: > > The definite bug is the x2apic_cluster APIC driver fails on recent AMD > processors. > > I'm unsure whether selecting the x2apic_cluster APIC driver is correct or > not. Capabilities you used to only find a multi-socket server > motherboards are now being found on desktop motherboards. My > understanding is this processor does NUMA on a single die, not merely a > single-socket. As such it may well need the features of x2apic_cluster, > perhaps the driver assumes nr_socket > 1 which is untrue here? Just to answer this one (I don't think there's much more I can do at this point, without further information): No, there certainly isn't such an assumption. Iirc the x2APIC code also predates the existence of the nr_sockets variable (and the respective log line) by quite a bit. Jan > Does appear "x2apic_phys=true" plus "tsc_mode = 'always_emulate'" are > adaquate workarounds all the way back to 4.14. Now for the second > correct bugfix. > > From xen-devel-bounces@lists.xenproject.org Tue May 02 06:09:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 06:09:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528348.821365 (Exim 4.92) (envelope-from ) id 1ptjCm-0000Mq-L6; Tue, 02 May 2023 06:09:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528348.821365; Tue, 02 May 2023 06:09:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptjCm-0000Mj-IP; Tue, 02 May 2023 06:09:40 +0000 Received: by outflank-mailman (input) for mailman id 528348; Tue, 02 May 2023 06:09:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptjCl-0000Md-Hm for xen-devel@lists.xenproject.org; Tue, 02 May 2023 06:09:39 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on062b.outbound.protection.outlook.com [2a01:111:f400:fe02::62b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ea8afc85-e8af-11ed-8611-37d641c3527e; Tue, 02 May 2023 08:09:37 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6980.eurprd04.prod.outlook.com (2603:10a6:208:17e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 06:09:34 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6340.030; Tue, 2 May 2023 06:09:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea8afc85-e8af-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HpgS0IdSxkR6dJoK6CWdJbwlLbRN/cwMh37o44u/t5+p4fDHfW8BrOc3XdFDHv1QQPlAO5tA1NgkXHaVk9nPXvlNy4WzIe+us1vsUBjHd1fle6HtwV9qbIHGnujBKBY+Q7ZV5aPmJSxJ3VYTpjG+jOAbHox5JcmQ/KOga4qLgLEHVjZmANM/4uLyCdtn32sNMWNHA2HyeVlvoVxA5Y65wnjhDDOey469tbBFHyOTdRsh3TlkKckYE9STJsScbucAl70gRYFVrDMFF8fl3MkySn/9s6fCk9ZYo85DMh35kB4iTTN4JZjZy2RZGWBrc8Mls44xKc3h8Qa6oG8jxL76Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PdlqNXxo5ZGgTvs/sF34dAjMHKHhoq8d9qTIJr7mB+4=; b=jIMF5SR1qM4S1N5pJbjHNNZIxHY0zTj57AxOUI7Oc07T0njG8Ssx6zlrrVvdDngb2EO0HjpLy5NtA9pcEyXVYprVCj4AHNjyuw4/gyjB9SdX/vPip/fhCe2XChTcy5fuSc+ebNH2eFHEHgiuVKVDsCPu0XZJE8K0dkG1J793MGh04AcKg1FWk4GoSROcbZQ8tR5zWegZKD1VpQatsipAJli4vtIREHzGq38pvtc1gGAlqBjKizH1RUyhdAzB3gt1JjL0UtnpS4Ww2oSSwdBKhgP4qtKLW8nBDKvW6aABGFhy0hF4wWHWQQwhST/51GhOBX2TqVt6gv2IrAoiBUGDaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PdlqNXxo5ZGgTvs/sF34dAjMHKHhoq8d9qTIJr7mB+4=; b=saZRC4PGRXEOhQDCqtJENtdzPJcG+A16tlEzmZyvctIyVVXCKn5KoeVcya3kU7URnlMM7AtrKsTFVuHZGrVKlZFYPizMRLD1cAJrFeg0mXuz6226lKPXbkNR8AV2xWFGCWhiWw/PYCvqv+alRFPEmPKwVeTmgdjYUkckX/tsVjM8guxu+Pi+gKqpE1oWkjCPJcQ9RV7bB2BZ+4Wr3KBBfJf4eGgVCmBLlVwpYNseV5v8UWhzoCWGlCyc5QgPLFm3rqTtmQHAJ0DZciTEhp+1+zvRDTv/0DK7V+yinG3ubfCugJibvv7ML1FGuXQaP0wbr8DbZDRZ/l7/zJYnEd5RjQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <322276ce-2586-4b26-cf1e-ee1b467d3ebc@suse.com> Date: Tue, 2 May 2023 08:09:36 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v5 1/4] xen/riscv: add VM space layout Content-Language: en-US To: Oleksii Cc: Andrew Cooper , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall References: <34f032df-cbfc-7a97-9a1f-2fa1ce574281@suse.com> <509ba3a2-0b85-d758-6915-7975d31a3437@suse.com> <5176b0bc-3727-e939-9776-ee4bfd732e32@xen.org> <016a95e8cc1be45ce1821aba0570ff87973c4c35.camel@gmail.com> From: Jan Beulich In-Reply-To: <016a95e8cc1be45ce1821aba0570ff87973c4c35.camel@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0219.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ac::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB6980:EE_ X-MS-Office365-Filtering-Correlation-Id: cf742a4a-5952-4f14-c154-08db4ad3ccdb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: L+On3FYj2wlTuzcDAKKLmvJNWuhEvpqHdroQw+a0f5T0dKMesYXFFO5kmf7Vv1zlPsH4cOBZdyWgkyiAejPOy3+YSOnDt7FCZmr/HH1t9tZW8a8tdSPhMSxvKw5xDMLOI6SdJsYIj/kpmTJCIkLXSrJcWKKerV7ekCkG4o+h2DKZ/PWuk/FcPwtbO1OQ/CxX5HXQ5BXqsHisYM30ZTM8MewuHD8ovbvZZpeSFcTOeDc9jYPHYFMeJMeuLJMXtgwIpJ+jXgsbaQNLo/LOJrAGzagEJ2j8rRCsDvAjlHjzcV4pj8ipb0au/E4uYs/eBb80HBV2zfG4bb/+5mHzDBzMJTHRlrc8P6Tbgx/B7mZV5+HlqIH2qMJrw7RfE6pcsmBa7iw+CN8ZavJgxPwWOfLPEJZb8uYtt+X10MXAqvDYd2B3eZ7WdUui2/FPpp+KVa65QjT1tL9nFjh5Z6OchNH5zSDPtrJ53gtOh9xZKPyQ3q2uDxfqichbm4vWSKndsrFROvMt6nk8Yj8E0cNXoP8KW8zefUhKY7sedBzkDWQWgdGbt0uUXNzB3Imu6ybGuGOfwUr0VXuoJik/lFf7NI1V8aq7ihRIqr9ZmLEv2dCEKTmgo4tbgx7Shd7qEkjADZ8qUlLNnSxTnTsCjNRSB8P52A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(366004)(396003)(39860400002)(346002)(376002)(451199021)(4326008)(6916009)(66556008)(5660300002)(66476007)(66946007)(31686004)(2906002)(4744005)(316002)(41300700001)(8936002)(8676002)(478600001)(54906003)(6486002)(53546011)(36756003)(6512007)(186003)(2616005)(26005)(6506007)(38100700002)(31696002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b2djK2dXWi90OTY3N0trT1pGdFVNRlZXV0l0bGJHaHJkdktDRmZRcGlGaUZH?= =?utf-8?B?dFFNdDZQQ095VzBFeGhjbXE2ODIrWTlhUU0weldyU3pYMkdBZTQ2M1cxQWt1?= =?utf-8?B?cThkZGxvaXJaYWIvbXNGRHFSVExNdTd3YWlYcGdNT25ialMyRFBkVjZmdXdK?= =?utf-8?B?WXV5a0l6Z0gxajRjQ2tqOEplak5aZU14NXJNZGdnaldRVlBoTDYzNWF5SDQ3?= =?utf-8?B?am51azhDTE5PN3g0aHVWSTg3Z2VHNzlRTS8wV25ZMkF0SGJFdGRLL2RlbXp2?= =?utf-8?B?WlNRNjE3OGFwVUJlNnMxa2dGWXZSSnovZmxJc0pHOUtGN3U5U2dZcFMxZlFz?= =?utf-8?B?K0U1OXYvdFpHcUpqQVdNMTQ2anpqNGR6WmVYSDZMTFd4QjZrQzVGaTgxZTVP?= =?utf-8?B?VUxnYnhUWVBSK2pXVHVGNkwxdytVc2VMV3BmM2dGaU9NT09Ec0JtNDUzTmM1?= =?utf-8?B?M0pMYUoxeEZpSFVqZEZPeTVqaUZYME91Y2V6ZHNmck5Nd0hWT0lGbzVXWGYv?= =?utf-8?B?d1I1WkFWL0U2R0ZLYWVzbzFqTjJWVm80U2hoUFJGWWYzRlBIOVRhL1lqdExN?= =?utf-8?B?SkNzdnlpeVY0aXkzcGJxeWxrbENnU0o4V3NrcHlnMGFGQ0QrRnVwVmJEM0ZN?= =?utf-8?B?RGI4Y2hTems1bkNpR24zdG9xZ1J1eWxpWDJBN0JkTXdub1pQQVYyMEVTLzFq?= =?utf-8?B?ZFA2KzgrSCtXZk5sWVVydnZ4Z0tjb09UZmFhdStyaVROWWxZcFNZOCtLeFdC?= =?utf-8?B?YnhzTmFwemx5aU1tM1VLbEIraFVmSHlhUnVBTEtCc2IxaG5yUmF5WTBHbW9q?= =?utf-8?B?OUROdlRVZE1wd0R1S3lSaTR4cTRDRWpvUjNUcTBOeHFpeGJXb0lkeE1WbjA2?= =?utf-8?B?bGxMOGw4UDVtMHc0SDdPcEJnSFBXN0V6UGFXeXJwYjhBNzZIS0UyRXJucnZ5?= =?utf-8?B?QUlhTzRDWkt4L1c3Vkk5eldGN1lydVZ6MEhkNDJueXBYWWxkN0wwcUFhTTBk?= =?utf-8?B?ay9RQmlJWkFuSkQrQ2hXY2cvQjEwWTVENGNkaFBpQy9kM3poN1dYQ1pyVjMx?= =?utf-8?B?aUZUaWZTRFdhSTNrekJaLzliTGdGSllOSk1qM0xrNnhTTUtsU1lHb241bGdJ?= =?utf-8?B?bFZTZVZLbHVBZmxuZTVZbCtwa3RrbVJCYTRNVEZXNEhDMmJOOUdNSmthZFMr?= =?utf-8?B?OHN3NVBwb0MrQ0hZSjQ1NkIzWitlR0FFTzZ0OWRVY201VkYzV0tPZWo3eFQr?= =?utf-8?B?K0tTNnRjNTRkT2I3REtpWVc4cWhOMGNsM3ZvSzBhSnlZVCtMRHU2VnFMV3dL?= =?utf-8?B?WGp5clhXRnlkRUFSVXNnSENWVzNoOFhBemJpRndGRmNMUWNSL1NJUkM1TDNT?= =?utf-8?B?UU5BMHVxM1lhaGs1RUFBUGxIdEkwenpNNmxFRHpJNU5RTjc5SkREcVJPQXlP?= =?utf-8?B?bXRRaU53UHVnY04xTWI3VDN5Q0RvdEgrRkhxUU1FL1RkWFVraFV2T3JqaTNO?= =?utf-8?B?Q1NLQTcvRVdJaWNlWmZvYTcvZFRkR001SEhuMU8rTk1GQWR6MGFzWkN6ZnVl?= =?utf-8?B?Ykl6cDRSRklUbzlVMjN4NnFzdHIwOTFMM2JSZkcwVVhBM01MTXBoUjNtOHJn?= =?utf-8?B?OTVuUkJxUjBHbUpwNzBlTkxNTzNYTTVnZGRWL3FUY0c4bVkwTy9ZNGc3Z2hO?= =?utf-8?B?YjdOb2gyeEMzVEhUb09DYlpiM29KWE5pRW0wNEI2bkxSbHNFdG5TUUZ2UHlT?= =?utf-8?B?YlJMSHJuTTMxekczNlFTR2VtU1FlbFluUk5KR0hBZ3cvaDZ1R1N4Q1ZJVVZ2?= =?utf-8?B?amtmbDFoT3o2Tm1OazVXMXVVSkVqcHdqN3NnTG5ENmhMWkJyR0ZQajVBZndO?= =?utf-8?B?dllNZ3dzZE9CYnZUY3BnQUxrMUlIbm53OVdjZHduNGZTV2xvUUNUMHF5Zm1i?= =?utf-8?B?Um5wRjVnR1hzRUk0aktGV01udDZrMnk0bmo3ODh6LzNzWU5lWGsvUmZJdm9Q?= =?utf-8?B?S0tuT09YYkp1enJ2OERpcGhVSUZhNnBCOVdUTWw3dkYvRTNnVDB5R1UrZHpX?= =?utf-8?B?ZnlxMkFDODZQaUxUa2tTaW9Uek9Ia3BvNU1YZFJBS1VZOFAxK3BzSVZaSit5?= =?utf-8?Q?KhfplRuEJHUyVYlw5AFpT/FfD?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf742a4a-5952-4f14-c154-08db4ad3ccdb X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 06:09:34.0106 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wF8F//uxxDFB7Q15Ad5+AIgncd4BE2lW2TgdAF7714JR99w4bqNAg7pRfIfKClV6g9RvLs+AlwTyp1mkIAmV/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6980 On 29.04.2023 12:05, Oleksii wrote: >>>> For >>>> RISC-V, I would recommend to make sure the struct page_info will >>>> never >>>> cross a cache boundary. > Do you mean that size(struct page_info) <= cache line size? I don't think that's what was meant. Instead I expect the goal is for no struct page_info instance to ever cross a cache line boundary. IOW one of sizeof(struct page_info) % cachelinesize == 0 or cachelinesize % sizeof(struct page_info) == 0, or in yet different terms (with the expectation that cache lines are always a power of two in size) sizeof(struct page_info) == 2**n. Yet unless you're able to fit everything in 32 bytes, that'll mean more overhead than strictly necessary. Jan From xen-devel-bounces@lists.xenproject.org Tue May 02 06:16:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 06:16:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528352.821374 (Exim 4.92) (envelope-from ) id 1ptjIo-0001q5-9z; Tue, 02 May 2023 06:15:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528352.821374; Tue, 02 May 2023 06:15:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptjIo-0001py-7M; Tue, 02 May 2023 06:15:54 +0000 Received: by outflank-mailman (input) for mailman id 528352; Tue, 02 May 2023 06:15:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptjIm-0001ps-41 for xen-devel@lists.xenproject.org; Tue, 02 May 2023 06:15:52 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on062d.outbound.protection.outlook.com [2a01:111:f400:fe0e::62d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c855e62b-e8b0-11ed-8611-37d641c3527e; Tue, 02 May 2023 08:15:49 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6980.eurprd04.prod.outlook.com (2603:10a6:208:17e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 06:15:47 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6340.030; Tue, 2 May 2023 06:15:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c855e62b-e8b0-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S73vx3jv+I3zZIewPLdwXxwL5Aq+E0BKkejpZnLnCQUCIebL3U9nqGJlBFlL3uZ0wyV2g9O4tiOG3PA+J7yR+gudvO8412CtM9smOizWAHsrMW22QsPisn5NudrHgDKB2r82DHg14DhMTRjm+E0aDYndDPf0mb5DwQ0som4TtGl7Ryjo3t5MoLCQucULrTKhygXezoakFMkhxOx1bvo5m0AbAISl0nq2BK4ZeQ06dYJK/fm25fHZBbQO0M6pSYCER6QMvoKg6cuv7txi1M32Ldhf2INfMO0qB8NI6ObpVq0/9jOfaVl4DSkJaLgQqcqwBXvWYpV+nuh7Wo394LEkrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tYW6Ju3/WGY+WAhCKayIV6c3SHWrtO97t72yOJ0NzeY=; b=J6bX0SUIIzm2dmPEFEJImyqW/FB+pFbbkGOuTseFfKqt7uw964HbLJMAGcY4yPUYvOFbdu7jt0BVncsBm6FLuv+HHQqI4VuwYuQO6EAPCkSkKJceBu+tcg+NeeLTsYRq195OxLTyiSY9DWxPP2uNiSz0+lIzP6f0dw8NIqnakCloRGuBFO5pCrtii4ugune34RnjaG+vhW40MQtXDAqYn/CjWniZkOBXp6Y0vGPHpqToEqZIQ43NEfGPb2t+2qGkaiThFJrNmBtdTbL8yR5tN4ozOz32SqcyD++EoIOQG2RWDNkwmGWeCg7RjjTK3UeDTjvK68U65RCb2/Mtscqkfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tYW6Ju3/WGY+WAhCKayIV6c3SHWrtO97t72yOJ0NzeY=; b=Jdv5Ce3ECq1X3GCU8phbXmAQe861HQXy+tRjU6rra1L4XRhB/Gp/qlraWFMVpRxj7mtWxkZVvs4dv1MQbwq5qQiEkGLcMuOt4HadGyF5zIdjhH8u3MRthYYYg8rzNditQrbJU34GvRnTNTurq+E/spbq28Ztmxl0qk3IuH/Ykr/ixUB1Toqsnh+UtMjq7d+IodeacRsU5PWWqyyBxerWge9gDzPTTICGT53MXB7sUcOFbF87zQIvuJzkG4QP1rznVRzZ/ZW8Q5wLpADXQbKwQHlsMvd1Pta2usRXvZiye1Y34f50bhNhnjTFTnG+FwyUNSmC/oYb+MNr1cLI6DWK5A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6e03a33b-f5df-391a-8c70-ebe4294e6fe6@suse.com> Date: Tue, 2 May 2023 08:15:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v5 2/4] xen/riscv: introduce setup_initial_pages Content-Language: en-US To: Oleksii , Alistair Francis , Bob Eshleman Cc: Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Connor Davis , xen-devel@lists.xenproject.org References: <5b27693bcdf6d64381314aeef72cfe03dee8d73a.1681918194.git.oleksii.kurochko@gmail.com> <67d8574f-2e0d-4eb6-19aa-67fe7645e35a@suse.com> <53257ae8-d306-8c7e-35ff-f3bc3947849b@suse.com> <3d440048717892fe5d3ed7fe3255dc8c9f5d38a3.camel@gmail.com> <2c424759-3072-cd07-913d-c45ae6791ce2@suse.com> <5316859bf081d2c00dae784e6700f55747a6635d.camel@gmail.com> From: Jan Beulich In-Reply-To: <5316859bf081d2c00dae784e6700f55747a6635d.camel@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0094.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9b::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB6980:EE_ X-MS-Office365-Filtering-Correlation-Id: da6376f7-a144-4f30-e057-08db4ad4ab5f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ll7wMgtoyjyzanHg9MO198TJFt2Qjymz7qOnusWeKbZZOqqg5lo+cdJ+M0gLxU+gTlO5cyWOdEGLlLLCl8NoSAiTS65KWaoxUemfvbj42F45QuicVtertWZuoFMlP7mVzvmdlxApVGtfNaN4Wx0qcLp1P5k58yLoHLTfv8j65GUvTxUUlJCafpWloOKmL5FI1GuMrZAaNYiR5+fenT0SxEiSGR7a3Gg00wQ06IOw8MbfDbtY6OAwHbW3yU+s6NaA+NSnI+C3JTVhPKlxJcfMUTHTBUzpBEdYsakr53SjuCpnLz8XuwAYlivHLQ/rlkcKtOl0vU8NC38SuVrmzXYJp2PSw7RFh4Zyes0+LRoHyMe8ZLzaSbXcGsiMDoG3xdINhdheVT7KOc79mfuIfVKqnkZETSeVl7owqw6c39k9jsUAOHE6LCRPgt36IgxD5QYsAErYhf5ZPujGgwR2zBZLX/YuG3j4632DqADg4pLKNLsCbT+jDncRrDBWg6LhkCeWlPVT4AEzpoTJLXGWRbYjJkC3TcDv0lRki6R5p8N5JDQf+rUYR6DfF1HVAI+R9mA1JmAY1paoi2jUnBlz/qt56cLOTaNZn+w+pDkd3rBpUrvHxLA7UnevMSW9NkESn1pYlmITFJwcC2xzk1vbU7cMUg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(366004)(396003)(39860400002)(346002)(376002)(451199021)(4326008)(66556008)(5660300002)(66476007)(66946007)(31686004)(2906002)(316002)(41300700001)(110136005)(8936002)(8676002)(478600001)(83380400001)(54906003)(6486002)(53546011)(36756003)(6512007)(186003)(2616005)(26005)(6506007)(38100700002)(31696002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OGVFbFZ3OG9jd01GOU9lbVVISUpsZkJQZnpUdHBFUVRuODlOR1pjakJ1cW8r?= =?utf-8?B?OHhOaUFjcDBuTXovdHpXcUo1OUlHdlNVVFkyT2RhVUxiRkVhbGpjM3NtYnFE?= =?utf-8?B?b2xpUHFlNHZwbmdrdHFJTitWNldKb1UxMnRZenFXaXg5djdnaFllU3g2a0VF?= =?utf-8?B?S2VIQnRLcnk3WXBlcm9pNXlxY1lsMmd3UVZoQUxBWnIrTHhwbm5YUFN1OFlY?= =?utf-8?B?WEJQTFBPNE5iUSsrYzNCTW9hdzJoZTl6c3hZeTllU2w5Y3RNREM3a3pGN09F?= =?utf-8?B?VEVkMVNKTGtCMXpOSVpPOWRQMU9PbU02N3BzZE9EaCt5ZzRFcTczbzRxeXdW?= =?utf-8?B?dVNwVUltc3FzeWJpeExVWTBNRTVLSy9qOTBTY0pHNmFPejRkanVUNWRXa29a?= =?utf-8?B?M3Q4Y0sxbnZGNy92WjhCTFJHakxwdkh4WW5aVzl3K0phWklZVFJHbjVJU2V2?= =?utf-8?B?aU45VUV6dmpCcnBMTUxGVHVyQ0lEZEhsY0tUVmVSeEp6dEVFbjNaU1ZnN2lH?= =?utf-8?B?RDlYdXhhL3R3Q3FRbnB2Y0pyRUd1UmdvaFR3OElISmtFelRuY2JCY01NSERy?= =?utf-8?B?L0RKUzJMV1lQUG54Y0JRaER0alFLR01DWStFcUJSUktNRUowK25HRzhJZDlu?= =?utf-8?B?RStmaE1NeU9oQ2hicnEwYlJCWkY1eklOeXpzaVVaU0dOei9QeVNBdUxwb2dy?= =?utf-8?B?S0Jvd2FkTWcwYjc2Mkl5L2wyM0FvQXEyVktFc3ZYbHZya3BYUFZOMU03ODNK?= =?utf-8?B?MFNoSGhSaFF0R3ltNkZwTi9oUHlzb2IvOTYvdEY2VnFDUUwySlQ4b09ZL3R3?= =?utf-8?B?ZDNhVnZuSVdncjJwTFUzeXQycUNlT3h2NFkyVERCRmEyZ0NZWFJMaXFmbjZk?= =?utf-8?B?ZTZSR0c2WmJuTFpqOElaaUF5ZUpWRkxrSnpHQ2xFVS9UZVBEWFJvUmw0RWh1?= =?utf-8?B?RU5BNkJaL05vMndvSkkrajhBSDBwamVZdXh2UFhTNm9iWWdkZVRJcFRQMUJZ?= =?utf-8?B?cG5jZ2toRXpXc2huRWFkU2RENVg0M0hDdmxFNDZjMWJEMmdXbXVCNWlYZ2JP?= =?utf-8?B?MDNVSE54OXdhM0J4K2t2bWNYdUJicTZKQkNPcEovYXdldm16MWR6MUJKOCtz?= =?utf-8?B?ZDllVHF5ckpxaG9JVTl4aFE1aldpQXFwNWhFdDFhaUlpM0hYaldFMEN3NlZD?= =?utf-8?B?K3VvcHhCbHcxT3dVL3hNdEZuTUZLMG9QOFZVa2taVGdyQUpRMVV3RTh0UzJ0?= =?utf-8?B?RVRzMG5IVFhCKzYyLzV5ZXdFNmxsQ2lHMWVMVlhWRXgrcEZMS21uMmdsVjNW?= =?utf-8?B?b3E5dkZXRHpEVVJyT1pvVGFHTVA5alVOcTRBYnh2QWJxZGtaYnkrTXppOTEw?= =?utf-8?B?S2RLZnI4andJSnVvY1ViZXJZaEYzbCsveEY0UytIUFV5Z0ZSQlkvaDdlaXZi?= =?utf-8?B?QldzdHdwUzNrZi9lbjMwcjJpR3ZYSUdWd3h6SDFGRFU0cVlHOHNtSzI3RzUv?= =?utf-8?B?ZG05dGRWdDNtWlBQNEN0WitpNDZBcmREMGphUzViS0pDNUtVQTNNY3hsS09G?= =?utf-8?B?RDNOdEFrRXZvb2hMS3UvNSs5MThVNlp2UC9NUVF1MUt6d2kzT09pUGJ3TWFq?= =?utf-8?B?VWp2bGxzNnQ3MTlrTGhNM01adU1sQ1RRS2dKVDJDYUNOVTd4MXNkOWVkOXdi?= =?utf-8?B?KzVkUXRxNGNNdktRRmE3U1ZiZ2Zid2NpYXFBbGlJbXNjdG45N0hGNWtxd3B4?= =?utf-8?B?U3pOVmlwbDRJYWdZczVkdGQ4TzY3K3hNS2RwaDRnMEswMU1nTEkvWTBtQXRP?= =?utf-8?B?Nm1SOTZEMXVlSGl5U3h1TWt1dG53K3ZqYlhab3pDNkJoMDdWVUN0Q05aeGow?= =?utf-8?B?NmR5WUdWZGxBcHNQM0NWdmRud2YxQzlYSFJ0ZFE3eUFjOGV0NEZPd25LeVUx?= =?utf-8?B?ZWJHdjdiRXVSajAza1h0QkVjNVBabnY0bi8yNVR0UkJ3OWJCa0dyMlY4R3RC?= =?utf-8?B?MGgrQ2NZcXY2aFNyNThmcG9XSERSRG9XUGd5NVhyTmhYNHZnc0lmcllPRGlh?= =?utf-8?B?WTlFT0VxWStlMDdkdDJVdVlyMHU5T0ExMVFTbVpmRWlPRUdhWmdBSDdIM3Ru?= =?utf-8?Q?6H6ak164D21bQYgYyTNPSI6NI?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: da6376f7-a144-4f30-e057-08db4ad4ab5f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 06:15:47.3983 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kD+C9xJSh4wHYIcicNpEDAfHylgmPqvWHTyabzJx5tf9tSpBpKmRq3bRy0EAk6s5Il/3CwSVKDglkCcr62+cAQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6980 On 28.04.2023 22:05, Oleksii wrote: > Hi Jan, > > On Mon, 2023-04-24 at 17:35 +0200, Jan Beulich wrote: >> On 24.04.2023 17:16, Oleksii wrote: >>> On Mon, 2023-04-24 at 12:18 +0200, Jan Beulich wrote: >>>> On 21.04.2023 18:01, Oleksii wrote: >>>>> On Thu, 2023-04-20 at 16:36 +0200, Jan Beulich wrote: >>>>>> On 19.04.2023 17:42, Oleksii Kurochko wrote: >>>>>>> +    csr_write(CSR_SATP, >>>>>>> +              ((unsigned long)stage1_pgtbl_root >> >>>>>>> PAGE_SHIFT) >>>>>>>> >>>>>>> +              satp_mode << SATP_MODE_SHIFT); >>>>>>> + >>>>>>> +    if ( (csr_read(CSR_SATP) >> SATP_MODE_SHIFT) == >>>>>>> satp_mode >>>>>>> ) >>>>>>> +        is_mode_supported = true; >>>>>>> + >>>>>>> +    /* Clean MMU root page table and disable MMU */ >>>>>>> +    stage1_pgtbl_root[index] = paddr_to_pte(0x0, 0x0); >>>>>>> + >>>>>>> +    csr_write(CSR_SATP, 0); >>>>>>> +    asm volatile("sfence.vma"); >>>>>> >>>>>> I guess what you do in this function could do with some more >>>>>> comments. >>>>>> Looks like you're briefly enabling the MMU to check that what >>>>>> you >>>>>> wrote >>>>>> to SATP you can also read back. (Isn't there a register >>>>>> reporting >>>>>> whether the feature is available?) >>>>> I supposed that it has to be but I couldn't find a register in >>>>> docs. >>>> >>>> Well, yes, interestingly the register is marked WARL, so >>>> apparently >>>> intended to by used for probing like you do. (I find the >>>> definition >>>> of >>>> WARL a little odd though, as such writes supposedly aren't >>>> necessarily >>>> value preserving. For SATP this might mean that translation is >>>> enabled >>>> by a write of an unsupported mode, with a different number of >>>> levels. >>>> This isn't going to work very well, I'm afraid.) >>> Agree. It will be an issue in case of a different number of levels. >>> >>> Then it looks there is no way to check if SATP mode is supported. >>> >>> So we have to rely on the fact that the developer specified >>> RV_STAGE1_MODE correctly in the config file. >> >> Well, maybe the spec could be clarified in this regard. That WARL >> behavior may be okay for some registers, but as said I think it isn't >> enough of a guarantee for SATP probing. Alistair, Bob - any thoughts? > I've re-read the manual regarding CSR_SATP and the code of detecting > SATP mode will work fine. > From the manual ( 4.1.11 > Supervisor Address Translation and Protection (satp) Register ): > “Implementations are not required to support all MODE settings, and if > satp is written with an unsupported MODE, the entire write has no > effect; no fields in satp are modified.” Ah, I see. That's the sentence I had overlooked (and that's unhelpfully not only not implied to be that way, but actively implied to be different by figures 4.11 and 4.12 naming [all] the individual fields as WARL). Jan From xen-devel-bounces@lists.xenproject.org Tue May 02 06:53:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 06:53:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528355.821385 (Exim 4.92) (envelope-from ) id 1ptjtK-00067d-2y; Tue, 02 May 2023 06:53:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528355.821385; Tue, 02 May 2023 06:53:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptjtK-00067W-0G; Tue, 02 May 2023 06:53:38 +0000 Received: by outflank-mailman (input) for mailman id 528355; Tue, 02 May 2023 06:53:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptjtJ-00067O-7s for xen-devel@lists.xenproject.org; Tue, 02 May 2023 06:53:37 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20605.outbound.protection.outlook.com [2a01:111:f400:7e1a::605]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0d014f29-e8b6-11ed-8611-37d641c3527e; Tue, 02 May 2023 08:53:32 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB7166.eurprd04.prod.outlook.com (2603:10a6:800:121::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Tue, 2 May 2023 06:53:29 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6340.030; Tue, 2 May 2023 06:53:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0d014f29-e8b6-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nNp8q5CcnOl/0AUeIHGQ+6W6OpdVzdWScnUcpbXQ4dKoGbMYaEA7XH14J/fQMonyo+j3YlYRyF0WczBn8N8BzAOAk3GxjqVYPGy8MtpxDWdH6yEYWx482zCoJhIeGDY8i4tsXUGKgIemF/p4knCLlvIxvNPCNONCLcZyzSYKfgGNGtlEAcIQM6kfD0/NlZTy0tP5XdqSCLGJ2p0ttUV6yvqs5iOCKW7QJIuR/5PGIQ4iHPg36l1BGIjizACY5vex0pIRwt5mC0iZ0aEYwFb438CJL1p0TOidAMg7+QrYgg2sLkHw911bABEqStO+DKSsubjSSzrDZEeasu5GFENqng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KrLqDwXogvWTiVrkF8oSNrFfbNIE+diqB/eY+7SfAGE=; b=BdiNKGBJiP10df1M7B4H4J+kt4HNcLKqiRV52JZAJEkMQQpTGRGpuehAWmge6JIMywD/bjfjlwgUlV5zUmGG3PFz+2EH3s5/JHt0reV+rQv8rO560zOLdsiGKbB1cIHvU1TA6HpphMlTabzDPtlErDb+9F050E5vXR2j3S1a7vVG6lN4zZ6IfSx0LpTBp+DnlJH0qP4LvIjh8HJCW10o174bvoDR7myE7wwVEHBd6atnjFWGi8u8GNWhz/O9f0FiElbjlgC9wHhM7qLwxVNpaWX5FQeYPBKA12DOzBlA4Rw5kKGcuEZ+1gq2c3CMEIAZg5JNmNbg8g7ROiHqJtSByw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KrLqDwXogvWTiVrkF8oSNrFfbNIE+diqB/eY+7SfAGE=; b=W8Ix5nkC79R46Gd/R4FxCjtMd7XQox70KmM/ikPWTICEfc/tTDQE36j7wvhvVmhXEfvWawECz0iCwsdlGmgH4TnaMVGoBZMpQT6FuEZvlp7RQwvVZcNyUr2fBpEOPvVMOYI0yaSzje44+aRqea6BqUJsPzVnCft4l42WmbpARvqu+If8Tm2tIKrtatbr48QlXgnRD3Otzqem/cKFCIv0XSOk03LXL4c0P4vFDVhoAhWo/61t/4tIOCID0LO0n+clE/Zl+WoQArzbAKIczR7SXJlzgkZTVAOinkfLOLcAuZ3bT0rknYKNcHpp1xR5txJIB8aJ8/jwCj3EC0UpcJFrsA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <333df991-58a8-f4e0-b46c-9f480cd34213@suse.com> Date: Tue, 2 May 2023 08:53:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: xen | Failed pipeline for staging | 6a47ba2f Content-Language: en-US To: Stefano Stabellini Cc: andrew.cooper3@citrix.com, alejandro.vallejo@cloud.com, committers@xenproject.org, michal.orzel@amd.com, xen-devel@lists.xenproject.org References: <644bfbc6939d8_2a49bbb403253f4@gitlab-sidekiq-catchall-v2-78885c497-qxnp2.mail> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FRYP281CA0006.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB7166:EE_ X-MS-Office365-Filtering-Correlation-Id: 9d591166-a79b-49f1-547b-08db4ad9ef95 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qbzQPVavKnYfdLUSE/vmpkMy5tBAX1AUAwG2Irw/ovXSkC8TzL4pSFKLHXprPTgkjagt1/yeGTe6P+8EqeYIN2lUZdDykh3WtxfmmLvM8UgzEUoG6iAEPdiSr7lnBPIRfYrC312x9VO/pe/hzkInvWldH7ygZxhs1onYP2N5Ko/igtG0yDPVOii1FGvD1vbic7jXGslqyC3hcpXn7iGxKSfoWcg4FVFYthvKqZOs1FUyqZyQP4HC+cAfFR7eHe91VOf6dpsNW12uSHU37+pCA2WyABTxs0+evlQN+l2RCwygiZt4NUkOTIBRA5xHBpaq/vxHSZtljqd3gUkNvxoQb5o4WACJJpDGafiNay71wryb9lkx25VHjyDmmaRDg6TUElzn4UhawxhO4ACBNH4fKmTwGNBRL8RZP0qpj/bpL/6QHd+GCJYE4SBVm+wxsRKKaLVAgmfG1UgN7tTVLTTbMfyhagchvwA4tdvgsRSmsd0GkdyGz5c30TiQbTyuPEAsFu/73UuxLvdi/QVO3QqP3rY8lXvD+SbK68VeXXnfT4J6CoTs6R5xVox9M1bVR+h6x2zd+iZwWtYXSH9u1BapuKLT7ECz8hrRbhehcm/cXOUNKp5ZLwyTHnGFy2C9WSwN3mPRkXiWWSLW+KHttCQXUQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(366004)(346002)(39850400004)(376002)(396003)(451199021)(31686004)(316002)(2616005)(53546011)(6512007)(4326008)(6506007)(8936002)(8676002)(31696002)(86362001)(5660300002)(478600001)(83380400001)(26005)(41300700001)(2906002)(36756003)(6916009)(6486002)(66946007)(38100700002)(66556008)(186003)(66476007)(6666004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Qy85dzQvU3F6ZkZsenFCZVg3ZHZkd3k1MForRlJpMXZxV2F2eURmQWxHN2Mv?= =?utf-8?B?blhnQUlveW5majlBcWh5dERKOGRIZnhlN3UvWmcxQkhJQWZ5SnVpRzliSHZM?= =?utf-8?B?QWdKVFlISUJ6emIzMlRSZmNtaEt0dXFsV0xNUkRkWnR3Z0dlMFMwYU5DSWVV?= =?utf-8?B?MUxoanRVSjNuMk4vWWZwcDNNR21CRm9sT2luUnZobE4wNGZ0b2xBZ1JBK1hm?= =?utf-8?B?YXlMTW9EQ3FjRUNUajI5ZHBFeW5ROGpWMWRrK3QwTElkY2UwYkpzcjNwTHln?= =?utf-8?B?MGhibVExWHpxOURNY2w2cHBVWjJlcSsyc09saXp4dzkvaEhUdEtzUW9ON0Zp?= =?utf-8?B?MmtVNmRWNEpLMmJONlNwZUdLaFdlUVU0R0FVaEN6SHovTk9ZQ2dJNmNOcmp4?= =?utf-8?B?QlBjZFF2akl1djdnajNuREp3UnF2U2pJSFIxejh3SHl0RXhLd0hFckYrdDhP?= =?utf-8?B?c0pTVjBvOTkrRlo1d3VyL2xBTGxGZFhXcnFBZ0JOQTV3SXkrWWpGdjQ2dG1F?= =?utf-8?B?Rk5idmwvZE42YUVCZ2xuaVROT2x6VEo3d003N1lZK1I4WmN5VERMV0Vvck9N?= =?utf-8?B?Q01Gb3BnOTdKK1dMVUMxWEJxdXZvMjgvVjk3c0puVndWU3BkbUY4Wkk4WERZ?= =?utf-8?B?Rm12QlZ1b0RtZGRIRUhMc0lRemErcXdZbjliMTgxMmQrWkJKRkxwN1RQV3l0?= =?utf-8?B?YnRjS1pYSlZvc1FsbGRKc1kyWTlWUHF0Y0pYVnhlQTdKVjJpZ3ROcXB3Z2JJ?= =?utf-8?B?VWE1UkpCaVZMeDArMVQ0QmhBbjFvcHVrWVdXdGxlMXFqK1lZbmxBUUVQRzhr?= =?utf-8?B?SmNabUJWR0Q5amppTXA3bHRIRkUxd0phSjFYMjhjaEltK1Y0UnN2ZmM1Nm9k?= =?utf-8?B?UnRVaXAvOHZnWVVyL09CQVJ6UXhpSEtZVWNhMStucmVtQ1grWFVqZ0hsOHRI?= =?utf-8?B?aytZcHpnaFdoUk1Rdi9oVzF2ZEpuMmJEU3d0L1ZxK3dYMVd0cmpiSUdlelg0?= =?utf-8?B?RFBVOVJQU3VpVmtpZHFoNDcvTUpxK2I0bEwrYUlLSXY3YkpRajgwL1U1MUJK?= =?utf-8?B?ZzFxNzlZMFNnUzFlNEhreUN2U0I0L3BpRzdIdGJMenkvOUJyYVhLKzF4VElo?= =?utf-8?B?bTFmbjZOYkF4NVNra2dybW5oR0Q3UjJZZDZ5bHYwa1ppQjFScEtxbm1OV0JV?= =?utf-8?B?cDM0dEUvczhBc1gwOEp3eU5LZWZkeGpzU0JWc3Z3TnF6QVdwUHA3Qi9tblJB?= =?utf-8?B?Zlg1aTR2dnFOU21nRVFzZy9lRXBBc25uVytxcUM2MlVFbytCUHNsYnFRTDI0?= =?utf-8?B?alBCbWpJU1hxamp5UzJuM242YlpFTVkvWXhWb3RXQU5kWWI3UXloTmpFeHV6?= =?utf-8?B?UFE1cmhSMmJDQ1lHL2ZjNDJENHZZdnh4dWlrdlNydjBncU9Ed0UrM29GYzla?= =?utf-8?B?TWVKeG5WdkV0ZUgxV1QveHJYN2ZWUEFqWXNzek0xSjc4VTQ0UW5GY3hISHdL?= =?utf-8?B?QXZ5aGl2bmVNLzVRS0cyWUEzYzNqNWxmMHBpd2lqaXNyc1dBa0xHVFlYR3Vh?= =?utf-8?B?SXRadmgzSTdZK3FiRFp4Zk5wOHNFNTNGSEZycFhDVUpCQllPWjd0YW4wcldS?= =?utf-8?B?WVQwVEZWeHlsWDdvMWV1T3lNZ2RCRFNkSWdhTU5wZnlHb3d5ait0QVU1MTZl?= =?utf-8?B?NE4wc3VtdjFiWW9FUEgyNVVEMXFrdjc0UURJSTlLMk1HOGc3VEpKdzI0NEpz?= =?utf-8?B?UUJTbVFGbk9QZTlycWRaRUJJY2dic21pdWlxZE5ESnVFTWhwQUJFYjJpeTNZ?= =?utf-8?B?WTh1RUkweGo1dGcycFRnMWZWWi83TmRHeUkwUW8rVVhLU09vTG5rWTlkSi9Q?= =?utf-8?B?UTFSbHFVMUp5c3d5NjZwVjJBMW1XVTNreVFyczZpMGdwUmNhZVZOZDlqaW10?= =?utf-8?B?R0x5ZTBLbEx5WHg2N29POW9ENVpGT05MSEVOdWFzeUN5VkNza1BqdXo0YVlH?= =?utf-8?B?SlZhZDlHYzBod0x4OGxJVDYyQlNCdFhyS3NoakxlQytmMkNnNTZRc2x5VUNR?= =?utf-8?B?V3dXVnVIMjM2THZaYlpKc3NhM2dteUhwbnQyT2FGbWtXTE96RkdkNW9rVE9S?= =?utf-8?Q?T1v9GXQBq8vRJO0oE+EkKiOOF?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9d591166-a79b-49f1-547b-08db4ad9ef95 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 06:53:29.2757 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: z5jsHjRA6JGkxWYJpi5s7LiWBjhryPWew13PHDaH1HQhzXvwmD4QMadDZK3PmPWbWmoxeViZEy51e6KnQj+FQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7166 On 02.05.2023 05:59, Stefano Stabellini wrote: > xen: fix broken XEN_SYSCTL_getdomaininfolist hypercall > > XEN_SYSCTL_getdomaininfolist doesn't actually update the guest > num_domains field, only its local copy. Fix that. This isn't true, at least not always / unconditionally. "copyback" is what controls copying back of the entire struct, and in the success case this looks to be happening fine. Yet for the failure case it's unclear whether any copying back is actually intended. (If the op was to return merely the number of active domains, I think that ought to be restricted to max_domains == 0 and the handle also being a null one. I'm also having a hard time seeing what failure case the test ended up encountering: There are only two errors which can occur - one from the XSM hook (which is mishandled, and I'll make a separate patch for that) and the other from failing to copy back the info for the domain being looked at. I hope we can exclude the former, so are you suggesting the info struct copy-back is failing in your case? > Signed-off-by: Stefano Stabellini In any event, if anything needs fixing here, a Fixes: tag would be nice. Jan > diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c > index 02505ab044..0e1097be96 100644 > --- a/xen/common/sysctl.c > +++ b/xen/common/sysctl.c > @@ -107,10 +107,8 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl) > > rcu_read_unlock(&domlist_read_lock); > > - if ( ret != 0 ) > - break; > - > op->u.getdomaininfolist.num_domains = num_domains; > + __copy_field_to_guest(u_sysctl, op, u.getdomaininfolist.num_domains); > } > break; > From xen-devel-bounces@lists.xenproject.org Tue May 02 07:18:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 07:18:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528362.821395 (Exim 4.92) (envelope-from ) id 1ptkHI-0000LK-4t; Tue, 02 May 2023 07:18:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528362.821395; Tue, 02 May 2023 07:18:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptkHI-0000LD-2G; Tue, 02 May 2023 07:18:24 +0000 Received: by outflank-mailman (input) for mailman id 528362; Tue, 02 May 2023 07:18:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptkHG-0000L7-Kt for xen-devel@lists.xenproject.org; Tue, 02 May 2023 07:18:22 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2052.outbound.protection.outlook.com [40.107.7.52]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 83772843-e8b9-11ed-8611-37d641c3527e; Tue, 02 May 2023 09:18:19 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by GVXPR04MB10072.eurprd04.prod.outlook.com (2603:10a6:150:117::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 07:17:50 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6340.030; Tue, 2 May 2023 07:17:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 83772843-e8b9-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YoFzm8fmaDDVP9+IUvOGemPkdB0WBIVdceOi1jg63jmurBJRS04BupVc9AnPlF0k7IOrdk9j3JdpkBJbWj5C1uHAll/U9oM1XeQZRffloDcTgi4G5xjwMS52rVTsh4sXjUuRG0QwPY8RyryfzEh3SpEE04661mrXliVtiJeVjLmQtlDb+DuHPDQ54L5D0EumU7hR8/y9Nzcse/7BoOudtCIofcZFkQ3MCWHMKAuy4fdGqA0TwymtsLSZGXm5ZvhlaoeQrLlfIcvshhMXNkFQCoheZCJfkZVTrHTM46TNhAPTh0aCC6VSExLEpeIrjqfSzvyWWhx9PrsgLdXRVtVhLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mJOXKJhqj0dCvMwJodrI7VMwHJWDODfDJZHptDaJKnA=; b=cQwgf+HFCB71gNmwOwTc32kr0vD6apx8wsnQTFmfgPtLakoBpY2J0FP4Ip/tYNUogGDADU13g+Z444CsvAKMzvkpewNFKcFicZmZL0ls0SzptRX5ZGWq+SPOUW5IfQ0GkhjG4TXsWRKcB4d2bgp7XU6QqeYvRlfWPITreZUa7jRpY5CnCN0DR7vUvhlFK7upre5Kt+GHD0uicR1/RjcOlbYpC9CHDCPzpJHaOlz6Jm66aiF9VGr8e/yNwboHwVXMI8MbVjZ9fEzWaK6IrjyO6hgD6QEmYp62v/LXfePtd5MHQHoMX+j/fY4JDCm589ADJWKe8OHEr3jRRh5dpRoL2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mJOXKJhqj0dCvMwJodrI7VMwHJWDODfDJZHptDaJKnA=; b=TW+ANcAzg1QYKZs6gvuJXde2Srh2KXjRR9MPzOGydwGa7xnTfwBkFh1ADlUqI5rX7Cwv0cwvxpGmLodyLCiOHjtZkX0Rsasop8LBoVS9dmE6yzyYx0zuNs3vk1/NLz5rbtEplqbN9Iap2TEUY+5pgQaORnsWDDnwMemibyD+57Y/En/m4v7U3W8S0ikKe7IXGmf2GlnES3nSJVmCO4fDU/5n/0rvlCrGn8ZBXDDvQyvsxbFRVerteekE68uwmgCMZN1j2xhXgbnTI62wtY8tlaf5IZCv/CVz2OodLHGEBR8/1RXXvHieVojeA207U3MDTWm38Qay6g55Wu/WW85FvA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <26064a5a-423d-ded5-745e-61abb0fa601c@suse.com> Date: Tue, 2 May 2023 09:17:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu From: Jan Beulich Subject: [PATCH] sysctl: XSM hook should not cause XEN_SYSCTL_getdomaininfolist to (appear to) fail Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0141.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|GVXPR04MB10072:EE_ X-MS-Office365-Filtering-Correlation-Id: 7d484f16-dd8e-4ca2-bcba-08db4add5695 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Gs8EetnGNi98b48zVs7nSu+d8jNxf6h2QCcIQP9R1XuLAEXeOdiKW2OlfU6wEooRH4BtM9nFAPd1+Cao56kilEg3dAz4r1llEvmGPks1To55o2672TUVjvrFoCZbIuujkunYdENBxNC4XSB+WFdnERbWW0UPKe5xfFWUpP6wsUFy4efM+NU3pTw+dSRk9z3tkkX3G998+8EIM9JdByc42jarY9OTTFVbkDxgONSyAkZglnRte1BduYF67y1JCrcZDzrVaMOyzxenSOareoz4z1cgzXMn0xf98rUv1yogGEN0F6KZGaAJf7GEevnAFcP4IP19EzNcYGINhrULsk4xG5CY1C8m8Ccgyv6lgfdSpP8AABEorOAAqtxIWij9VS39Pjw/7gy9zidzevFEdGZCHw+2KT9Dop6hrh2+qkSiphQhzXRWVB4/o4xSyx0Cwqm6iz+oiGEaGtXufuhukh1vEZL92Lh4aCsPDfRtHob+DZ2WUxPtJ4StbnkPtuO/Fjg3SR1GSfYQZwtEwJwfq/GUGUCD31rTSgoM+5tTVAJPsT64u3r/ni8oU1ldh1Lw6uPd3lhQi2EnbjgQWQm4g/Ny2W/mY5SPg3GAEa9YdXL9HiUPXL7bMB2CLwZtsS2TKheQ90IzzkCRwSD8dZXZ9O4IHg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(366004)(136003)(396003)(39860400002)(346002)(451199021)(31686004)(86362001)(4326008)(6916009)(66476007)(66556008)(66946007)(6506007)(6512007)(41300700001)(36756003)(8676002)(8936002)(5660300002)(6486002)(316002)(2906002)(31696002)(54906003)(478600001)(38100700002)(26005)(186003)(2616005)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cGtvcmF2ZHozUjRtK3BWRkJVY1FoSXpBNzZCSWJRc3NMZzk2dlhQa3QvNHRF?= =?utf-8?B?Y2hMdHl6L1YwVWdvWWR0SzJkc0NxMnk3c3oydmZxK1pFNVZwTG1Vb1B3Zk9j?= =?utf-8?B?R3RSWHdDQ2sxNzY1dUkwT0NmZlExdW96ZlVyRSs4aUdRWUxzNlZ4VC8xYm01?= =?utf-8?B?MU56Z0EvZkFDSVUrTTdIcndVM0RFRjgzWG9QQVBRUWNNT3ltWHpkQWhMQW1N?= =?utf-8?B?eVZBUldpZFErd2xjQnpwUXFzR2pucEhOU1hvKzNORVFLREZPR2h4MGYyZlR0?= =?utf-8?B?NERZSWU2MmFoWjRjdVQ0dkVPVytiazRRT203YUJaR1NIK21DcHRUZFoxL0pM?= =?utf-8?B?cHdDS00zUkUwdlhKakZDdUlGNVhMWHBMTzRORk1rSUhvS1h0S3FBeWxqdXdM?= =?utf-8?B?VlpNVndUNW1lcFA5ZTVZQUI1ZkZ4aEFvbytOMy9DZXBoSFZ1dmxQdnhrVjdU?= =?utf-8?B?VG9tUVNSVDQvYVJvQk90MkpUOU9DblpwNTF0YnprVU5vdFJPdG9EcWhHVWRD?= =?utf-8?B?OUE3WGc1VndGMHp4a3d1VE5ldWZGV1RCTStrbGtrai9YYlZKRUlzTWEweGxX?= =?utf-8?B?TmpDcmZDempqSFNWem5uN080eWlNRDVHRnNCVlFvaWpzVXVhckNlVGsyaE4r?= =?utf-8?B?QVl6VXQ5S0VDeVlsWi9rT1NhY2Q0NVorVUtXdnZFajBRL2ZacXQ2UHZjbXdS?= =?utf-8?B?N2s0Wm5ubjlJM0NkV2xYU2xiNWJpeDZBMTdxTTg2WWxya2dJRGQzMmVhc296?= =?utf-8?B?aGp3NG1wMktjTERGR2VPOGUrNzRESlRTaFpIbkZUOHZsaXBHOTlLaEgrMzRF?= =?utf-8?B?RFpIY1lwRDhVNU4zUFMxWXcwZ084OElRYXFoam1Tb1FZdk9JRThoZlUxNEZ2?= =?utf-8?B?V0xnTVBDdTQzWEczbDBwcFpXMHVuUk1HYk1XRDJCenhmUjYyS0pEaTEwNEgr?= =?utf-8?B?eTBZTWFjRmVpS2hxNTh1RVM5QWh3QmczSE9KS1l1emViTTluVTVINXlsKzU1?= =?utf-8?B?YWlFcXhTTkllQXpNT3BDd2p5VjV0Umk2a0NtRW5oellnV3k1NXJwT3JKM2I3?= =?utf-8?B?QXhKZkVpYU1XOHRjSG9oRWFEZnNnb0M4ZE41dzZEN1RhRGZjalUxZVhHYmJ1?= =?utf-8?B?UDVrYlVSRUhPMWNjTXhVcTl4ZE16dEdMZGNTRzdjUVpnemQ4TDRwMnhsNXh2?= =?utf-8?B?OHVzeEJYR0htWEQzK01JWkw3d2dMZ0VoSXV2cFJDdUZ3ZDdCMGVkemxEaWlN?= =?utf-8?B?dzQ1eUJRallKdXZETFFralJIYjF1SlpGcjRaaVpqVVNBNzFGcWlBbklpaGQ5?= =?utf-8?B?WFZTQlRSSC92ekxHZXJWcWw4bDlHbkdiVTJzSFJLQXBVSGlBc0VkYkhmZXFy?= =?utf-8?B?Y2FBSFRqeXlMWnVMMVNqYXkrNXRkQUltY1NxN0xmRWNhYktWMUNKc2JYMkw5?= =?utf-8?B?ejdjN21idWpCNGM1ZnpRbVQ4eWE4KzE5bUVBZGFCd001WkZPR2RNaTFyN2sy?= =?utf-8?B?bkUvQk1YUmZVWVExMzZQN2tJc29aSFgwVmcwNWNCaVhwL1AxaGQwaHhPOHZ3?= =?utf-8?B?S2VJTk4zeUVzbDBRYjdZYi9ZdEpWWndnQnJRSktwN3NWMWkwV3kwcFVlOUpR?= =?utf-8?B?NUpjbEJDaHIwSTN2MzdaK0FCbHhSRnhRVG14elhGVnMrNDBvOFpDVXhoaWRQ?= =?utf-8?B?eUlCbDBnREdVa0F4NjR3NGhVQUdaaEkyK0N5djgwUGNWVzFpc1pISkRObVE5?= =?utf-8?B?c3lsVEQ4TFlVWEdNeTlnbUs2V2cvWEx2ZklBODMrVkdYVUwwUTYrOEQyeGEy?= =?utf-8?B?aVVoMTc4dzdhVDhrWk1PcmxoNW11dHllTEVNTDhoaXpOM04vTUN5WGh5d3gx?= =?utf-8?B?RmVCM3ZFUWtqcTVIWEZ2Y3RYaUFjZTNnVklPdzB1K3RlMUYybWQzd1dqbldi?= =?utf-8?B?TmN0bGg0WEx6aXhVQkYzOVNKM05OaXdGam9IVXhrcHZtM3FsUmVhRG91U3cr?= =?utf-8?B?UTZCYU5RVHU2Umx4Q0dSR1FoMU9EcC9IZ3BuVlJDTktWWmZkYTlSOFZXcU93?= =?utf-8?B?a25HbGFnSjlGeG1RTzc5VzhoUnJLUWRSOWF6VitOT0hBL1Y4NTJtMnhZcFBo?= =?utf-8?Q?9GgplJLyUkuB5NtN4Ozeny0zz?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d484f16-dd8e-4ca2-bcba-08db4add5695 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 07:17:50.5780 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xawX4/7HxFajo9aw1K0PWV8Bey8UTunv4MBbFItVn+IBfu3Dr6PMuJz9uXjRh0DB+HboQ/qxXDU6zZi8nYG3wQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB10072 Unlike for XEN_DOMCTL_getdomaininfo, where the XSM check is intended to cause the operation to fail, in the loop here it ought to merely determine whether information for the domain at hand may be reported back. Therefore if on the last iteration the hook results in denial, this should not affect the sub-op's return value. Fixes: d046f361dc93 ("Xen Security Modules: XSM") Signed-off-by: Jan Beulich --- The hook being able to deny access to data for certain domains means that no caller can assume to have a system-wide picture when holding the results. Wouldn't it make sense to permit the function to merely "count" domains? While racy in general (including in its present, "normal" mode of operation), within a tool stack this could be used as long as creation of new domains is suppressed between obtaining the count and then using it. In XEN_DOMCTL_getpageframeinfo2 said commit had introduced a 2nd such issue, but luckily that sub-op and xsm_getpageframeinfo() are long gone. --- a/xen/common/sysctl.c +++ b/xen/common/sysctl.c @@ -89,8 +89,7 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xe if ( num_domains == op->u.getdomaininfolist.max_domains ) break; - ret = xsm_getdomaininfo(XSM_HOOK, d); - if ( ret ) + if ( xsm_getdomaininfo(XSM_HOOK, d) ) continue; getdomaininfo(d, &info); From xen-devel-bounces@lists.xenproject.org Tue May 02 07:20:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 07:20:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528365.821405 (Exim 4.92) (envelope-from ) id 1ptkJI-0001kK-Gi; Tue, 02 May 2023 07:20:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528365.821405; Tue, 02 May 2023 07:20:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptkJI-0001kD-Dt; Tue, 02 May 2023 07:20:28 +0000 Received: by outflank-mailman (input) for mailman id 528365; Tue, 02 May 2023 07:20:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptkJG-0001k5-Sh for xen-devel@lists.xenproject.org; Tue, 02 May 2023 07:20:26 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2072.outbound.protection.outlook.com [40.107.7.72]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cecac40a-e8b9-11ed-b225-6b7b168915f2; Tue, 02 May 2023 09:20:25 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by GVXPR04MB10072.eurprd04.prod.outlook.com (2603:10a6:150:117::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 07:19:57 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6340.030; Tue, 2 May 2023 07:19:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cecac40a-e8b9-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bIgnX4Su5oMzTFIjPaDeciXZi6yPfjLIv4l2JxSENMTrlEfskPrHELiL33m7WcJrRTsjWOvNziMn5cDyef+t18cMm0koQ1m1nC2pJjvkemwidO5NuDAydqSGcV4V8WacEzXk3Ni8HMm4CzyJdICm2mpu+RWTT2O6xOT9KU/lm2onRFmALcixsT5Gwq//Jvto+Naey69aT5F3+hHj2jPjiALYoiyvwXEmlCnu7LjOGIF4HBUKA0xTDVJoJN/sa5ftE27lkCkwH/ApJRdT9WTT4rP8xqrTXQnSiER1CK1bYRXNzlvEdqbrzQEVLok4AIvYtirwzizpwf1Z/5JfYbV+2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ge+zmYmWwl76Lvy1vCFAkPgqQs+CeCMIZ3C1bhjNBu4=; b=kQRXUKz/nct7A/y1z5cxFiZWGXFm7XFGRfJtklbFb5F1nnM4GSreQD9KDrK2GZ6TR0UnayKKuoEbgJRrXmqnXJ4c8oxtX0GTYws02w/4kE13iCIq8V7wqSj3mcO7PKBmHz71rjmsG+UYuagJIrXZWqDBjXtfTu4hMe3U6dynPb2EO4SpfUobsvTNok4YVCuUdOf19LOm25oyG84B3pqM2BiONwYAj5G7WIMMcy97M03BTNw1vNaC97g3fpSvL1NiIcE5bTR17srrhiy5cqYyeSVIB/4YX8zK/DbLnncmphygUudjfAU8GTOVLA5eypTrVXQJZTIPWuEKV5B662iMaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ge+zmYmWwl76Lvy1vCFAkPgqQs+CeCMIZ3C1bhjNBu4=; b=i0Dj0Myrp9pvA1UsRaEkuRiPvS5/ovi7pQ2P2Wt2YFE325qgOHF3kpJeQyjPiI5B40poXV34nCM4Zx71ujxouXnRUwnRCb7CmZDB4hNbnYlxdnxJvLUUZ8Tu8yNVcbFFcqQcQm+N+2XPfxNaJpaBNbvLHSekgqTuEvJeyIjn4w3WWcLA4cXCcw6ICAmKkvcsTvWAnxHPgRQ6scixyvw28KqohUgJjafej7COZYhRVK8cbKipCepSjhgs8Y5iCMYCfOWnbVDO/K1c86XizEs8Ta/MfUYp4bUxcyIckqz4z8itwcCrXqE5t9PTfY8uqOZXYQo9PqNUuse2hmMfwgbvcA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 2 May 2023 09:19:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH] xen/sysctl: fix XEN_SYSCTL_getdomaininfolist handling with XSM Content-Language: en-US To: Juergen Gross Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20230430144646.13624-1-jgross@suse.com> From: Jan Beulich In-Reply-To: <20230430144646.13624-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0025.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|GVXPR04MB10072:EE_ X-MS-Office365-Filtering-Correlation-Id: 9c97f6c0-4eb8-403d-552f-08db4adda22f X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pItcUnFHYD93FNMHgtH5v7fe//3hS9B4ogemegJqfFles5P+12S5+w3WGSxEgmlrbjChX3yjGRJxcg/aMnfrbRoCfWHIuPQfY6u3KYdkvalVv6S7c7XNsh0XBo6rom9HTb3ZzaYjEnoB3NtC6mDTt2VIscnq1iQoXUk5Wo6005bUAtfuvEIEHP1zf4k74O93HZzgqrp7LqctzOe0okRpTjH+7NJpD43L5sZrCHo9PamGbBLb2EPszwFn2aDB9EFjUVUJ8ZViipXh0t4QAp9wq6GURviQGGgdvvbOiIY5uIevcA/lnYKM+s4jx2QAh7ftyO4LyhsedABZZskHNP5kpLV0M1TrjlrLoX+UNBdawNZSnQpd1NqL7qNmn9a07csQIMo/FRYHk+MPgxkpu7XjKXppOUmj2BoSRnxs6kxfgxOWSKs101fOmZJFCfnSnBa2rnp8oeLtQzs3lGN8p1HCjTT692MCqdwKD0roDJYDVTqeUWFqSIXkkN8V2GGvSQ/3sHsIpUM36ZJHurct34KrnJH67rK8DQwLzdf7Vou30kBI16Wa3OHksP6agtSvrh8u+zS9Uarmy8nVRuElhXG/Qj0MZ86DUrQptJRmNsLfg4zE2Vcx1h0BAnFHd/XD67llLO9BehLGk+SW+TjoPsM6lQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(366004)(136003)(396003)(39860400002)(346002)(451199021)(31686004)(86362001)(4326008)(6636002)(66476007)(66556008)(66946007)(6506007)(6512007)(41300700001)(36756003)(8676002)(8936002)(5660300002)(6862004)(6486002)(316002)(2906002)(4744005)(37006003)(31696002)(54906003)(478600001)(38100700002)(26005)(53546011)(186003)(2616005)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NEJhaHkyMDk0cXZ4K2RwcDFJSGZEQXR6OS9xV09qS1ZFZ1AyZG5zM2lBeDlu?= =?utf-8?B?ZHJMam5EQkhIMWgxV20yRUpBR2hNaktkVDB4bU5mNGZwY0MyOEttK3hPd3dU?= =?utf-8?B?Nm1lZkxCYVQ4cEN2WnBsOVFBQndmZEMwUWJGUzZnZ0NmY3pyMWlycXgyV2tm?= =?utf-8?B?QmdwNkVzczZ3c3lBaGw4TXMzYmlJN0p5UTQxRDZmZ3d2cTdHTGl3WlYxYzRT?= =?utf-8?B?VjRHN3dMTGhCR3VFRTRWNGtiNmx5aVl3ZzJJTk9xdWNsMlpTR1UyMXAraTNz?= =?utf-8?B?Z0pSb3crS0RPTFhLdlRldUpDYWpqRGpDTzNMK2s4SlhvUHVKN2R6QUYwZUNo?= =?utf-8?B?TDBib1ArY3JjUmppN0plMHdWL09BK0x5Z0gyUVRvbjBlSUp0cUU3Q1JxU0xC?= =?utf-8?B?WVk3c21JdHRrbW8xNkllVE9WOEViY0Vzb0llMEFQN1VydDBVM1NJbUgxWXNi?= =?utf-8?B?aW9XQ04zdTIzbUNDNW4rK1Q2N3gwOW93YW5tVnFEMU54ZmlnamR5MXc1YlRJ?= =?utf-8?B?NG95S1hGc21uWk9VMTVBN2FKbkx3UEpHOVN0ZE5JRWFKZUpGQzJzRGU2M25m?= =?utf-8?B?RmsraThmOGlBb1Bpc2tVd01aNTVkL0F6WnVqYzdXT2VlNGx6S3kxejE3S3ov?= =?utf-8?B?WWZZWjRDR3ZTc3ZaWndsTmgzNm1TaHdPVUd1aUJmbitGaUJ4b3BsK2ptcDlO?= =?utf-8?B?b2F4S3FIcGFyaDV2RXNMdUFnTU5tWEJXaDlYSWVCdytOR1VvcG1GUm5XVXo0?= =?utf-8?B?QXhyS0Rtd1hiNkFhOUJYMzB2WFcxSXFDbUFTcG5EeW1tVFpVYWhRck8rbklJ?= =?utf-8?B?L1labzJZbi9mNDkvQTlsWVpzN29vSlhxTGpkcnFjanpZaEVHSG1xS1pLcGVX?= =?utf-8?B?K0pYZFhRa0p2bHY5QW1PZHRGbm95cmJnaS9qcFBNQ2h3d0loT0tjclh5U3hv?= =?utf-8?B?THFxSlo5ZU9NbkhqWVVROG9FeDM4WFE1ZncwM1VhNVdHR3pDYUtBRE9GVDM3?= =?utf-8?B?WkNTTGE1SW5qOWlPM2lWN01sTFFnbDBkR2FTekd2eURidXZIS3VRTWRSeU4y?= =?utf-8?B?alI5ejN5VkpsbllDTWdhdWEwK21XTnptWHhtZ3NLb3F0VCtzaUdJMXAvR29C?= =?utf-8?B?M1NDU1E3NE5EMnp2dTZ2T0pTazNDVVp0YWNVZjB3UUtJa0I1eFpXMU0zUHc3?= =?utf-8?B?eDRWcjJTc3JjMGl2R2oydTIrb3RQVG9wYkYzVEl6T0I1WDQ1T0oxMnJYd0lh?= =?utf-8?B?Yjh2eldmVktxQ3lDcThjelRKeDFnK05RQzJrblByQnRSN2p0c09KSDNUcXly?= =?utf-8?B?bGhYNVZoV0hOOFphSFFVR2xOUDh4eXhPYmVBWGhvWDl0eC9EUmd2VS9Jdzkx?= =?utf-8?B?OHk0bWpRSzBkYTFKcnkvT1BWYWhhRFJrZFhPZS9nTkpwa2xrdkowWW01bUFD?= =?utf-8?B?c3NpcWh3c3NaM3gwanZXWjVKQzZnR2diWGc3bmhrTVM5ZW14d2ZkWmVodENS?= =?utf-8?B?c3JIUlNFZm9GQXVaSFFIU0FkaTFwU2RBNW4zZi8wRVE4VEN6ZFZTN3F6b1lt?= =?utf-8?B?SE1UZ1Vud0UvVldUZTFFT2JqdDN6VUx2N2VWRWFHYWNOdU5CL2x5RDQzUXQ4?= =?utf-8?B?RXNlN2tXd1R4ck16aS9Yc3ZvUVNBczBaVUcxUy9kNU9HOXUrTHhDQlFyZEVO?= =?utf-8?B?ck1WS3BudHh4N0tXbkdXZWlyK3JmazM0ejNOY2xPcUxYa3l4WFV6NWg3eXJN?= =?utf-8?B?Vm1sbDZrbXVPQVBjWHMyWFdKejZ5bDlxRzdhL0FCRm5rUzMwb3phcnAyaTRz?= =?utf-8?B?bERDakw2NGVHcHM1Wlh5SGhGMGtEc2hqbjBWSWhLbi90R3E1Y3dRSG9aY2dH?= =?utf-8?B?bW5PbVV0Z05MZXZBZENlMVNsRDlSKzN0Vm45Ym83aDBxUmFjL3NwbndDeGdJ?= =?utf-8?B?MlUwbVlXT3U5S0RaOEdocVB0dWxIT3FpOHQyVGw1OFNqWVVPVnRnQUtDcUI4?= =?utf-8?B?TUtUUS9ndmM4NDhHVWV1a2U3L25DQWNYR3dyK0VDdTNoYVl0VUI0REwxRzh4?= =?utf-8?B?ZEZvT0wwUTVjelJxRDFNYWdKc3dkVlF1VCtHdmNzNFZIUk1CT250TFljVkRJ?= =?utf-8?Q?rzaFI4WEproGI7vpjMXbGna/A?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9c97f6c0-4eb8-403d-552f-08db4adda22f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 07:19:57.4287 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3VdPxRBuF0fybvU7H6m+DeZgnngmhJR7YjZpTQ14LtVLBQFwCznGEoDfYRK9x2vlROlFGRHuqj7c8Gtw6Me9Mw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB10072 On 30.04.2023 16:46, Juergen Gross wrote: > In case XSM is active, the handling of XEN_SYSCTL_getdomaininfolist > can fail if the last domain scanned isn't allowed to be accessed by > the calling domain (i.e. xsm_getdomaininfo(XSM_HOOK, d) is failing). > > Fix that by just ignoring scanned domains where xsm_getdomaininfo() > is returning an error, like it is effectively done when such a > situation occurs for a domain not being the last one scanned. > > Fixes: d046f361dc93 ("Xen Security Modules: XSM") > Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich Should have finished reading the list first, before sending the same patch again ... Jan From xen-devel-bounces@lists.xenproject.org Tue May 02 07:32:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 07:32:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528368.821415 (Exim 4.92) (envelope-from ) id 1ptkUR-0003Ix-G4; Tue, 02 May 2023 07:31:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528368.821415; Tue, 02 May 2023 07:31:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptkUR-0003Iq-Ck; Tue, 02 May 2023 07:31:59 +0000 Received: by outflank-mailman (input) for mailman id 528368; Tue, 02 May 2023 07:31:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptkUQ-0003Ik-SS for xen-devel@lists.xenproject.org; Tue, 02 May 2023 07:31:58 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0618.outbound.protection.outlook.com [2a01:111:f400:fe0c::618]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 69f37921-e8bb-11ed-8611-37d641c3527e; Tue, 02 May 2023 09:31:55 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8186.eurprd04.prod.outlook.com (2603:10a6:10:25f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 07:31:53 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6340.030; Tue, 2 May 2023 07:31:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 69f37921-e8bb-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VZZE+F/eoqt3NpzStDOYzo5CExw18lv9QMwoWWIb3uS7CBoD/0XDT4IsdadcUzQAKB8xAuaPgFhCuCpbX0J+opiDcQwK4dNq+M6W1vr2pjOIOp6QRN4nHcpU9IZJZG17KgEU/2gzg2/9MPvIls/w+SJdJIWyJlbnyOwl0j+H2cBkwYuoUbEY6MAr0KMyYNln83CxLkXOgqS1NKDc4Q00pXq00iZ61gJWGm/hpTvJ3KdahyF0vmYacSzvLxQIHnCHZPA7mrR6AjQKqaGQVVHTWpgqBw1Qdhflr9v1zYPzD998AZybnWxA/vdMBLAIwMV/cRVQKFTl58b03Qixzd3Xjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2YMiXAnfAKMyQKqJ13W90DOmfzJnHkhJukbcKuVvems=; b=ACbunt98dQnFWJnpOTUkBUJrIWx/uLao/4bN/OIlGP64CKL9srpljmfpV9dCQDgalkF0SzfIBS040xBtQCgYHvk8n467flDpBFEX3OgnPZH/qbiq77hbfnpXQ+YxIJc/IsKeoGqs7qY47wBaBAAKGVquXp3EZyfypE1ACUTx/gCX0SZtgx2JrKExzW8uyXC2EyHpT8FcakZlvyx6stxw+kktqA975TTTExQmFYwkJVODZgvyO2TqVbCQsauC8QOM0wM/NZaxgwqpNwe3dutjVmeEC4I5L+aO3a4OLeO3CMf/eTBuX1IoMOrr8T2WhnwOlWGyn1AA+aAGrsJIQDNL0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2YMiXAnfAKMyQKqJ13W90DOmfzJnHkhJukbcKuVvems=; b=34oHAdLWujbDxYjar2Qku9BdAJPWLg2eBjKvHq23js6JxiJYfD/jtgf+twC7FJ2D/CSMqdToTFet2lGxqIW2HNsSGXHqDIQNOjzC+dfjhMrplo9uiN0+Idn2mcv8BCzMyIxQQLdcJrcPVCgwvPKiBzwRSPXs5lo4TSOxSx6267oxntB9TjTijUPqOFEenGjUUWhfXdz7XKqeTtO05M/Kjahb9PJnI3yacBZtRZ1s4NUtJL1dU4F5Sz3+LKQMVDwVus8qmOm7s4sGrQg9KUJPCtbYvhPfYrbIL1LpBgST4QaCZfIJh2c+U0L3hePiTp4MMVPkYc9oAjAqW9pfctpoKg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <43b1c214-4248-a735-6f8c-9e08bdd2eaf6@suse.com> Date: Tue, 2 May 2023 09:31:56 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: HAS_CC_CET_IBT misdetected Content-Language: en-US To: Olaf Hering References: <20230502074853.7cd10ee3.olaf@aepfle.de> Cc: xen-devel@lists.xenproject.org From: Jan Beulich In-Reply-To: <20230502074853.7cd10ee3.olaf@aepfle.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0086.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8186:EE_ X-MS-Office365-Filtering-Correlation-Id: cf157e7a-1395-4e2e-4420-08db4adf4d18 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gVTOrYPAarPQbZLQY0XGKyWfZ6+cx6KV6XZaq3Ivi0RKxhBGg+n0AfeUIpHGic731khyUBoGjW3qbh5iYWLePvmk5Sfqfg7mvf+CjYjntoalOj4UKlSyTeK0+uo03mZqhmvdMzXkd0QC4aq0MEk2DsEa5GdiDMwjfG7TngbPrqKquclcWHrnMhzTYfATqXhG5+BpSLmdet9TzwcEYSamPYJkIVgcBNo44ecHQYYIH3VXux0+nkwq0vFHesbXqb5bo8ClbLBehkt6Kw4n3fSctzVuahg1ULqR/MIY33saJAvOFfrkHtKT1IFGoDpNxFlXXQtVlYbEk5NYImcsf5nijPbUimrTIi2ZCYZ2QRKY8FyugRe6Dy6Z8ar3jkRgG3vuwaHCjD6nuGjqvGXEqzH4L6kGU2cEXcrl9Q4/BAZ0wCCtqaudC5WLzSd8fnSEbHY+XEJaC4823sgIr4E3juxD6bb6NV+DEu9Axjo3yr9XdFt1kBzomvFzPC1O5ICNDXBra5W+UFUdlCWQuyi9RPaMJrc9oWgf+ymF+c+UJoL/MprySwHPo5a3wA6yuSaMv0cwQ4yEcVtq+LW5yUaXi3Y4eh/lzW42Poi2mri3aSfaL18i/tsMBioQwnDOeuHaJMW8O0PU3j0SRBFj8m1GmtFXfg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(376002)(346002)(396003)(136003)(366004)(451199021)(478600001)(26005)(6512007)(6506007)(53546011)(6486002)(83380400001)(186003)(31686004)(2616005)(4326008)(38100700002)(66556008)(6916009)(66476007)(66946007)(41300700001)(8676002)(8936002)(5660300002)(7116003)(316002)(86362001)(31696002)(4744005)(2906002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dW56Qm5Mc1dFQ0FSOTF2b3VNcUZjL3dOcllFcUZkSFRCVWcxbkk0RnhvNzFE?= =?utf-8?B?ZDZLUitDQ25CZ1BXeUNzdnREeHJUb1cwKzV1dlRFbStwaGpTUmFYeWowUmJH?= =?utf-8?B?MExub1pZTUdUY05sWXUzRis0QlcwQytVRDczZUluM0JCRGZhcmJmeEVwTjVx?= =?utf-8?B?TmkvWHlHV0x2ZFovUjNzdThWRzhoZURraW5YbmtpYkhYRi9RK2dibEVRYUlk?= =?utf-8?B?dEZqTEFvMHVjVWYxVW5RQ0Z2M1pEaTFnNUZjNHo4bmJRelYzbno3L2d6enVu?= =?utf-8?B?SEVDQkFLN1dRTWpqaEZUZkpuNUh2bFVOUld2YitUcUFieVBxMlU3RXBDdFlJ?= =?utf-8?B?ZGNhSDRpTVFySzJrU3dkYlJUQ20ySjRzMjlONllKYjFGdHhEc0l4YVAvenRC?= =?utf-8?B?NjBobEJVLy91MjVZNW5WWjg5c3YvczRmTjF4UDl4eUtuNUNJay9MaG1wRlZD?= =?utf-8?B?eHVCOHVEYjRmVW5ycy83Q0YzVllZSkRTbTNmSjdhNHNJZkZWZGJqNVgrMnhw?= =?utf-8?B?Nkw4Qzh6MHh0UVJlTnFOdkt2Y0cvMFRLOEhacFRoWkhrYzV0RlVGYUQ2cGV3?= =?utf-8?B?YjhyT0hOc0VyNzQ5OW0vYUpLWUtTQ1NHVTBYMjhTVWk4TXJBZk9GTnhDWXhB?= =?utf-8?B?cHlsc0pnK0VvWlZtRTM5enpvamZSSlQzTFh5dFpMcktOZjRiSU9DaVk1ekh1?= =?utf-8?B?RXVtK3FOUnVaNVo1MGdpNWhPN3BIaG41d3lJSEU5eUxRQUoyMmJzclYwRVVM?= =?utf-8?B?VlNtYTVrM3VwNlhPcjVmQzJ3WXRzTk9PbjFGZG9Kbk1zRUkrWEpzL0ZTSFhH?= =?utf-8?B?MnFDVk5Ed1Bqd2ZMUHhZaWFINURESG9mM0ZmZFdnZnZJeXo0YkppZ1VUci9p?= =?utf-8?B?WDZxMjh3TU1Xc1VzQUpFVGNqK2J6WGhjYjRjSHkxMExwY0R1a25Ec2E3a21t?= =?utf-8?B?ZWdVWW8wYUR3cmhzWjRaWW83MUxzUnk2aGpEQng4NHB0ZFBBYlpCRVh2dUU1?= =?utf-8?B?OC9lSytaV0dTZlEwZWFXV3Jab1g5SE1QWklqT0trRTJ5RnYwT2RaSzgyamhZ?= =?utf-8?B?YjZxcUd0T25OK1ZZbGF4KzMwMXRNUHF6TVNmd0FzTVVwaXY0T0pHRUdJRnFM?= =?utf-8?B?QWlQV3d2M0Z0WUNya3VFTzdSVGRhOVBzOFBoM3NYS0UwcWpyTkNTOSs4U2da?= =?utf-8?B?QmR6RVUrYkRyL1MzZFB1eVZ2elgza0dsTEZPU244bjBUSnBFcUExMVJ2bmdj?= =?utf-8?B?MjRrMFQ5UFNaV0lJdmYwM05GRU40S0lNY1M4ck0vKzRWcGdiZGxib2hrUUJy?= =?utf-8?B?R3pVeTJSSVRMeGg3RjBTdjVCNWJJeFlSWGZmcHMrdmVOMXBPWGlyQUZDSzRv?= =?utf-8?B?eVFhV1lsSkduOGFOeWRhUXBBYTJrTjI3RkRERi9zN0R0dzVobG1lVlFkNGVV?= =?utf-8?B?S3gzK3JqeWlvN0JMcHN5bDIvby9EeGJERThrNjFCZmxZdEhhRytNRTZxYVpE?= =?utf-8?B?RzJhS05YSGRpWmVUWll6MmRJSmp3ck9QbHZKUUNyZXYybkwrbEtndjNEbkFD?= =?utf-8?B?S1hmSllPZ0VYSWZ5K1dNeGJIMU02ZURYNmpidVdxMzdTZVdCSE42Nk9KV1dH?= =?utf-8?B?YXFNZEIyb1B0Z0JJaE9pKzJsdm9JK2ZCZFliRzI4UEFYMzBEN1FUSVFTd2FK?= =?utf-8?B?YzRIUmNzSmFhTEhzZVd2SzR4ZDdRU0kxUUFGM0xkc2p1ZXpSbDZBWTlrbEwy?= =?utf-8?B?MlB5dUNRTXk1OGtmQWZ4ZWt2c3oyRFdNQXdWZjV2RHdmVU9CNUNUSjlKQ3c5?= =?utf-8?B?eWVheXVleFRkaTZSQ29WQWZWbC90S0YxZ2xVMGxhMUdheWRGTDZxb2E3bGpX?= =?utf-8?B?NW92M3BXSkV6eE9GbjlhV2QrdUV6OW0zTkd2QzlRZ2NkRVluTXVqRjVid2dU?= =?utf-8?B?TEtSL2QzUHRYQ0N2dndreXA5MzMwb21iVmc3anJrMlZ4cU1GdTlPb2p5Z243?= =?utf-8?B?UmZjeUlGQ3MzK1ZPRXl2VTA0cDdxQ1d5SGIyUWl1alVOSkFGemU1eUNJQmNN?= =?utf-8?B?SHJGallnMDVaaXRXdndNeHF4K0dveDc1c3V5SFM5RXIrM0I0Q1Q0dEtBTzg4?= =?utf-8?Q?hMDCie1SWvc05Cy8Bh24qs/Tb?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf157e7a-1395-4e2e-4420-08db4adf4d18 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 07:31:53.7087 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rb3Urt6N2fVGBlQ9cihH0sP/Eto7BcZa55DdHO15bCMljOAD3XY7bL1NVb4DxxMfei3vozS845f/oBJbvaEa6g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8186 On 02.05.2023 07:48, Olaf Hering wrote: > The next push to xen.git#staging will trigger a build failure in the refreshed Leap docker image. > > For some reason HAS_CC_CET_IBT will evaluate to true. I think the significant change is the binutils upgrade from 2.37 to 2.39 in November 2022. > > The comment indicates the combination of gcc7 and binutils 2.39 is supposed to evaluate HAS_CC_CET_IBT to false. How does 2.37 vs 2.39 matter? CET-IBT support is present in gas as of 2.29. IOW I think it all ought to be tied to gcc being 7.x when 9.x is the supposed minimum. Did you / could you check which of the three options (-fcf-protection=branch -mmanual-endbr -mindirect-branch=thunk-extern) is/are possibly recognized by the (likely also updated) gcc7 there? That may provide a hint at what's going wrong ... Jan From xen-devel-bounces@lists.xenproject.org Tue May 02 07:34:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 07:34:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528373.821424 (Exim 4.92) (envelope-from ) id 1ptkWx-0003vp-V5; Tue, 02 May 2023 07:34:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528373.821424; Tue, 02 May 2023 07:34:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptkWx-0003vi-ST; Tue, 02 May 2023 07:34:35 +0000 Received: by outflank-mailman (input) for mailman id 528373; Tue, 02 May 2023 07:34:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptkWw-0003vY-BF for xen-devel@lists.xenproject.org; Tue, 02 May 2023 07:34:34 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0616.outbound.protection.outlook.com [2a01:111:f400:fe02::616]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c81e4d64-e8bb-11ed-b225-6b7b168915f2; Tue, 02 May 2023 09:34:33 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8967.eurprd04.prod.outlook.com (2603:10a6:10:2e2::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 07:34:32 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6340.030; Tue, 2 May 2023 07:34:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c81e4d64-e8bb-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f7l6SR0ZPOs+u3/kb3E0YxSfxQW8inxOhqW6x23N2JC26Lw/DUAOig7CJ0PH+qwSzIhezzm6FhNP4byfIQl/pz4zJ4XrfQ7vIdAueczcRiwYiHlNVKDj9QOlOvDb+thQz45jhdScBYpnNxarEoQiRcAwkX1Hnw4XfQ/mVjib9e19GjUWW1bFK+rK6r9mIbgV+8qq2JbNN7sYdiNgAOlcr8RGY0MFVCyW71f9oU8hVsL6MpFgmbxGTUzV9RIiAgb7s+fXM0KEbPJh7dkDij8CsPWRq+0XQh80xjOFTaztMUr7yVDyQKV35c5TziA9Cnej9vx/Rpyd6+H+rVCpimIOQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GQnUS/XI/DAbV78nBE3hwMbN1l5XLfaE3ZjQSab4SE0=; b=cfJMZsdXRomUyD1lXSGxYqt4y96W7hGV/6QhU2DJA3mKn0Blt2AsMqa/UhdmYlH0/OAIeS5yJzSDRZgrxLjcswlAmnhN3Ohz4A50v6uzMrPseozC/w1C6y5ROsFj/Jf4HIvdWfRh8VdwBjW+V9UTPxn+bSj2PqeuupldlUORARVY17iQizdeMzV9FF/P5tCnvdhzae1ChrCwXgdZTecQyEQQrEv7AIlAfOGxXi/jFkC5AxCSdZm4zVNnP2USB5rnSSlQd303MjGiolbmco+ej9eU78IwLD05XmL0k1AaygmWTX+Ws2lTQqgAXs3V1/bbd3/p418gK7EWVJiJdRq/vg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GQnUS/XI/DAbV78nBE3hwMbN1l5XLfaE3ZjQSab4SE0=; b=Uu0nWfQo1KSxFvDXKYFT2OS6/6PA/shbPplEe7ll+SS98GamSgcOIe1cKzi1QuZgLRXCpPg8lnCfp7hPQmwhgciUnr92UZKi9QF2kXYWVORsR2OamEupFdwFvVykvoFYX/vgHGD/hsnHJYwUal8RxgotvyvBoJskuUe0U2H8g+a4lhMWS4bMzsJ0j1Yc+F3NCiMKv10d1/2Gv7nNZOYSigBkMb+oti2H0q6ER0vH0myBPcXOAAfEHwsfPmaMUlVaeaxdxpf0sF6Xzbxh4vm1upWnIf/2LKy70tWrJC0H6LTGLCJlWJPnLTYSJEJ8iTlLrH5elZybhbk4r4F+OSBHRw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 2 May 2023 09:34:34 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: HAS_CC_CET_IBT misdetected Content-Language: en-US From: Jan Beulich To: Olaf Hering Cc: xen-devel@lists.xenproject.org References: <20230502074853.7cd10ee3.olaf@aepfle.de> <43b1c214-4248-a735-6f8c-9e08bdd2eaf6@suse.com> In-Reply-To: <43b1c214-4248-a735-6f8c-9e08bdd2eaf6@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0159.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:99::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8967:EE_ X-MS-Office365-Filtering-Correlation-Id: adb3385d-2178-4675-b128-08db4adfab75 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yi1RI/idzBCe7/bsuVg100wZc4lc0SbeuhPtzMkIQ6WlT1i0+tUdbfZm++G8WH1uFncxkowySqvS3wGJQWsUJfLDM/C3vppALfPv1IywrvR3bvF78hKgCZev2btDyFceDJ37Pc1qutZ3kdPgwCz2aKFcbGPI2TxMf9551/OfVIHADOfw4Tx60jme7Ubop6CRM3Iz297fKaCH101hrixEBWtUJuyzhsDALwADUlbnCnkndMBdQokpZks3xB4efDahWVSLIkHtHBh7B2twUN14192t7N0WZfBgs+/Vzn46TCroqum4lBGxI0RvetqGNgOcfswHLB28z+CfgfA4u9JR7VMyALzUzAFquGRL4ERW9D/89/ibI0yKAzFWYuFxTQ7y9//Zs1/T3Pv1IFLoHn0zpt9WXBbcUhTrL4S7iWXHML4HflIJPd66FNk6nt06ZMaiwJsL6JtTTU8fv9hq2P7SeD371d2WabyD09ek9FFf6bCPMBIsXJbXlUC6nP6K+hWEtV5Z3HEtWAZ6cGwfR+LHz3Sj56tJGyL6LI6A+bZSttRDTyPBv3ZDawPynVmVHZbUe9Lg/9I5wseylGH5mSl9IQcoSdR99wwDooqzA5mLYPFQ99VqS3lmqwdxxhM/xMhGXv5Z/MEo5NufVXmho6c8vA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39850400004)(346002)(136003)(366004)(396003)(376002)(451199021)(2906002)(6506007)(6512007)(26005)(53546011)(186003)(38100700002)(86362001)(31696002)(2616005)(36756003)(83380400001)(478600001)(5660300002)(316002)(6486002)(41300700001)(4326008)(6916009)(66476007)(66556008)(8936002)(8676002)(66946007)(31686004)(7116003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R0I1Y0dOYlFnSkRXZmJ4ZlN4L0VPS1RZdERnSndqdlN0ekxzSVhpbVJpdGZI?= =?utf-8?B?dm5yL1pvbjd4WkxqSWdPZm9jUzZoMERqMW1uWG82TFlvVnkwQ0t1VDV3eHhI?= =?utf-8?B?OUpZanZzMjhUd0UyU1NxYzFReWVFanlGYXFVQk9yR1JTcENSMkJUZ1FBMHEv?= =?utf-8?B?dy9Ya0VnOS9KZUFDNnZHSzJkTTNDdEhKeHRuU0hhcmF1TjlDYlhLbnFwQWxB?= =?utf-8?B?NzZLWERWZlFjaFpIc24xb0JscVF1TXFZR1Zob0VjNVF6d054S1lhcTRmaVgv?= =?utf-8?B?aXcwSUp2aFNNVnpGNU1vTmxPYmE0WkZHWGk2WmhCK1RpdlRwK2xoeUdKOVhT?= =?utf-8?B?MHBUTzNIUHdQWTREeTFxRnM5cDdvQ2ZXZ1Zhb1dqY3FKR1Y0RUxwN3VIeFov?= =?utf-8?B?R2RweVlyUE54UWJQUWNiYXRTUUN1TmMxTXhlbCsvUzlMWkZKbUExdXF0WjBZ?= =?utf-8?B?WHdaQUtvb2F0VWVUVHZURG9EV3NMMGVyOU5FNS9OV3RWM09reXZlV3RraVY2?= =?utf-8?B?SGtkTEpnNW5vZWhtZm1wY2pKQUQ3RHR3Y2tKOEJsUURsTjFXU3NhWjNzM2pi?= =?utf-8?B?RkZxbUw0TlA0NmNVZU41VGU5QUllRjQzZnVLeElqMWNFcHFIU2puTUl0M0hG?= =?utf-8?B?MWQrOFp1RFI3QTdYUHkxekdTS0wxNTAxWGNsQmcreUNlMDlBek5ES3lRTlpa?= =?utf-8?B?V1FpU1VLMDJ3REUxaWJQK0RKM1l0aHRxUVNKMUdCSHpNUTR0eWR6MXJneG9u?= =?utf-8?B?cExNYktvRklTdGYxSUxjV0VRYUh2aGI1WiswZmZ2UzhYRkd0bHRjSXE3UXYw?= =?utf-8?B?K0xIVE9rUUhiNjE0UUxYcG9kNjVMT1pSYjlORDJubTQxZzQvYWFJTHlvVDJD?= =?utf-8?B?eHNWOVdUWGNXUUJ6ckZkdkhTcEE4dHdPem8zclZQYmY5Z3Y1QSsweGVGVGV4?= =?utf-8?B?Qlg1cWlnVExvNXRVMWJkaEd0QU9SeWtvMFRQdU9OVVZiM2RqSFQ1N2NHRldl?= =?utf-8?B?RFVRdkxVc00reFArR0NyRWczeE1yeWFGTDBNUzZRazJOWitKWUh0VHVkbDli?= =?utf-8?B?OEhYVDJRTGVybFBEL2JSZ0JIUERPbmZ3VVR5bTlDak5KaHJPamxMc3oyeVZJ?= =?utf-8?B?a25mNFlkYis1c2tialdPM3BNVXh1dzMxSFM4YjVabkFlWlFxYVNGTldlSVps?= =?utf-8?B?a2Z3UzBNNW4wSU9XOHZuQWdpcjRmTjJJbDRqYkpqajk3TFAvVG5PUTAxdkRm?= =?utf-8?B?cVFtbE8walY2MWZSQ1QzN3BSTW8ydmtWZE5zWTR2T1VXUGtMVnIvMUF4K1Jz?= =?utf-8?B?emZIcHpQT3ZOYlNjQ3ZKZ0lzdVp5KzNRajRqckdLUTFwb2dQL3BuOWdQSFlZ?= =?utf-8?B?TWN3MG5QQ3lvSGdnelF1elR1d1hBVVlqNFFtS3QreHBFRW8xSUd2K3VJVkJH?= =?utf-8?B?cTN0MXcxaUlGQ3Y5R3p0RUR2ajYzMHZpeXY0eGxxdEowYmRwcGZrU0orNXQ2?= =?utf-8?B?ZTZMTEZyOE9POE1uZGZicmExWnpldjFxbGNaQnBPOGxJWE5yTE5jL2ppT0Jh?= =?utf-8?B?SGJiVjdxLzlrQWhFTXNtcldRMCtaSDJrSGU4eUJ3VkdsNGxOKzlFWE9PS1Jw?= =?utf-8?B?ZjJSVUgxVDY4ek9IT0ZHMy9Mb1pFWURzS01PVnNrRkZBak9FN3ZtTVNuS01L?= =?utf-8?B?Z3JpNlRNWWVSdTRrQXBoeTBoNThhMGNYK2lPNS93WmVCN2FUdkFqeTZUUk1i?= =?utf-8?B?QzVuYWZjakZJU3pWRmtKN0VQZTdIZG1uUXpDZFI2Z3FJMi8wYS9ieFhtTmVs?= =?utf-8?B?RTVBN29tTDZpSVNEZjgwTGRDN0FrcjVseHpmUDNhN0xhLzdCVjdLSUpZRWFK?= =?utf-8?B?SVVzTmZDWnJtRjhSTUhkL2RCQi9QKy9SYmRMWW81MVFObmdaa0p6OVBWTW5t?= =?utf-8?B?NlJuM1ZqK1NlSUlOQ3p4T0w5TjcycFdwUlFoSjFhT0k0QnpsNG9ZbWJtNnk3?= =?utf-8?B?SDRKQ1ZJTXNNQmJ1UGgyb01aNkNMbGZuTTg4NHM3OTFtZWxBK3NQR2s0OXBo?= =?utf-8?B?VFlhUyttU0hpRjExNlNIWWNwZE5CTG9NdmNPTXdtS0JOR3lzanNtRmZwQTF2?= =?utf-8?Q?T+IvlYpjtIr8wlIT/ENTaX2dI?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: adb3385d-2178-4675-b128-08db4adfab75 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 07:34:31.9167 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IbVXx5nVin7kT0/7bjnAxTDJuU7syFwqzyHEA0TZONLcQDN9iVp4JI3tH6Z6KAw6ki4GjPFRDp4sEGV68Cq4kA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8967 On 02.05.2023 09:31, Jan Beulich wrote: > On 02.05.2023 07:48, Olaf Hering wrote: >> The next push to xen.git#staging will trigger a build failure in the refreshed Leap docker image. >> >> For some reason HAS_CC_CET_IBT will evaluate to true. I think the significant change is the binutils upgrade from 2.37 to 2.39 in November 2022. >> >> The comment indicates the combination of gcc7 and binutils 2.39 is supposed to evaluate HAS_CC_CET_IBT to false. > > How does 2.37 vs 2.39 matter? CET-IBT support is present in gas as of 2.29. > IOW I think it all ought to be tied to gcc being 7.x when 9.x is the > supposed minimum. Did you / could you check which of the three options > (-fcf-protection=branch -mmanual-endbr -mindirect-branch=thunk-extern) > is/are possibly recognized by the (likely also updated) gcc7 there? That > may provide a hint at what's going wrong ... Oh, it might further be relevant that Kconfig's cc-option passes -E to the compiler, yet none of the options actually affect pre-processing (and hence might not tried to be evaluated with -E). Jan From xen-devel-bounces@lists.xenproject.org Tue May 02 07:44:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 07:44:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528376.821435 (Exim 4.92) (envelope-from ) id 1ptkgL-0005Rb-Si; Tue, 02 May 2023 07:44:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528376.821435; Tue, 02 May 2023 07:44:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptkgL-0005RU-PK; Tue, 02 May 2023 07:44:17 +0000 Received: by outflank-mailman (input) for mailman id 528376; Tue, 02 May 2023 07:44:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptkgK-0005RO-8v for xen-devel@lists.xenproject.org; Tue, 02 May 2023 07:44:16 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2062e.outbound.protection.outlook.com [2a01:111:f400:7eaf::62e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 22f6fece-e8bd-11ed-b225-6b7b168915f2; Tue, 02 May 2023 09:44:15 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8325.eurprd04.prod.outlook.com (2603:10a6:20b:3f6::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 07:44:14 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6340.030; Tue, 2 May 2023 07:44:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 22f6fece-e8bd-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X0MkeRvdBlHcdeXBcm35bwRiLFQPmolCJds6+9mWx3r1nXKu/kRdd90R1j3eENd8HrOqILcnVkUKeneMOFnSwlsDaI0CJcViI9iLwzTGMvb0E9GfmU+aRhFq6VM15RfUZSR5+FH/iAbrocdQPGrsJyIy9DgvhjeG1/0AnOCImfMKyTPkkuoQsc1waUWNy7/3WPgcuh6fxtAj2+1sT7UbXCEteYSwx3pQBdgBknupc6fiZv0qwGtOlZlf5MYJgyJ/8nMgknfbjrsyBPXJ0P7jRFwR+mNtgF9jFmBgMaEJIkrDy4cLr9X/WiJh8QU4PGnuJL8JiiEXe9yNntolXLpxHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IZhG623XH/gq2heft254aHJTyUmLp/RiNpLTQb7PQSA=; b=QNr1C77pYQ1NecvL8LjmdFvoBlb65WbXRgIIktTvGLJah9K/zuzg8OoICWB3FtuLzGc5OINwIXDl1JydzToifnoO0b5EZIlKZvqYTIqhJaxNM8ijnJJyFDY0vSsVcsdJ+QuF9vkJ8pAgJGebQM/W9OYMxiVmmhrHvBHyAGdy6gkOV/23vuuuwl8Xx9an7Qx40nCT1iYSMT13honr5tJ85JqgYw0VT/R7jpZpOelTUwpyTtNdttPlSCoNB/toA/LH0Jt226TnIN2I9IGvvg5vzFwomfK7gOP43/ObTjy/cBPnshzDhnciLQxn4QXty+RXvEh5nkAUK/XkHKSK92zyOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IZhG623XH/gq2heft254aHJTyUmLp/RiNpLTQb7PQSA=; b=JJQAdrVqcfrqN7+eW+q1MJ3sTvKNFz2/krgCg1INt+R8YHP59n1F6p+BdXB8Z+MGC+ImKybsfiIuP7Vg/IAYwIFlc01J8Oso+JULQy43eQG3XVxEywAZHVZWBKGQguFGmbtVs/d7SU93egXBYg/wp/AV7on/Pskti4d4Bo+ZjmciAqpIzLL1PDZjTuWH8CBB8Wu4gXrBbrMkD8B+4c8HLfGoMeLkI7oPgWC4vKoHBkO8q51KgV2JKxSdyMWkplc+dMqPhgALJsLDMQ97f//CVDVMU6tYrHZDLWV1z8tj1bOHKY8hubcMN/I2CWhYG75ingM8UQ9sStr/oRnQKGjecw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0e7404fe-e249-7b3f-0628-b8b8b1925765@suse.com> Date: Tue, 2 May 2023 09:44:15 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v1 3/6] iommu/arm: Introduce iommu_add_dt_pci_device API Content-Language: en-US To: Stewart Hildebrand Cc: Oleksandr Tyshchenko , Stefano Stabellini , Julien Grall , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20230501200305.168058-1-stewart.hildebrand@amd.com> <20230501200305.168058-4-stewart.hildebrand@amd.com> From: Jan Beulich In-Reply-To: <20230501200305.168058-4-stewart.hildebrand@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0185.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9f::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8325:EE_ X-MS-Office365-Filtering-Correlation-Id: ee445cf3-ff33-4ee4-e0dc-08db4ae1060e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eJVoQSUjT/NrKyKs5xm1/ByNJALAHqyeHMEbWwshn7nKDJaxy1bXCqsM0XFMx/Z+eJ2SbJ3jnojYbBfsnk456ROw7lyNsjvuWiryiDa/u+FmRm8VkqyPho7PZzhU17reNWo0+xYzEtONS8219UOYgPjzDtBBWid1iML4CPcD2VIQUMVzdLMIXyxf8Ljup8g7mj6B/m4VjBVXcmp2KZMvp9Dg0DKl455Yj3JJP1ZsAjMZY5LOGAomAXUEpRA6g88rYWva7f1sFvOUW9kYI3dTTsVlTU2s6Pf8qSi7pX9pOkLpeCKO51YsZ3xR9pcSYj9GReSF+qLkGQrpKmCf1CjxYKelTpyjTU+1TQk7OImHYQyhG1xjWHP1TiOnpQyXOZAmMjAfkRry4CNl3OItKoTkyE3mD62cCVIVhYuFuMqXP4jU0frf64bxILY52oZUiEUKZ28BfGI0qlW975cW6u0pFNq/8ftpCuIMoypqOkVfZkEu4KHXKZtcLDGY8XfmOUhOJXruPnecDQJWgiX6f9G2qojNKiEtYUyYPgYTRiyCnfsh3lODAw7KoW/U2EAfLHRm7w1g2hvWM3sYBE3vVREGs//oPl8ff5iIJgkaFbEDj6jcBFIEL+D9VrhX0yiSUrm2JY2YMOAJJeNI8w7DcF3G8A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(396003)(346002)(136003)(39860400002)(366004)(451199021)(38100700002)(8676002)(8936002)(5660300002)(316002)(2906002)(66476007)(36756003)(66946007)(66556008)(6916009)(4326008)(41300700001)(4744005)(86362001)(31696002)(6486002)(478600001)(6506007)(6512007)(53546011)(26005)(186003)(2616005)(31686004)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eUp6dGNIMUtDWmMvY3lEa2VmYnZ1Vy9RRUJneVpKQ25VK0VROXZZTDI3b0gw?= =?utf-8?B?Zi9ZN0Z5WGZFQ0JFdSsyT0hacnFLR0d5bmh0L3ljR04zK3R3RGZuTSsxMnFB?= =?utf-8?B?Tk1kTFlLVFI4NmsyN25mZ0kwSjJZK015VGQ0aXJleDh4Z3NHWGJydDBINTZS?= =?utf-8?B?Y255NlY2VllkajdpWWl2NTlGSFJyZm5EdnBGVUlpb1psbkFUT2t5dCsxZVRS?= =?utf-8?B?Qlp6bUwrSitUMzB6Z1dsU3hJRUtlbU54K3NvK2M2Wmd5Um1EaFpld3I4Sm1I?= =?utf-8?B?cmoyaVlNRlM5YnZZS2l0OFV5UnFDaXhOTG15b1ZNZHlyNXhXYXljbkdWYVlM?= =?utf-8?B?bDd6UXdETU85R2x4STExR3I3WEl0QjBWcURsOFdEWFFxdnNWcmpCVVlaUkZ6?= =?utf-8?B?VHYvOTlGbnJoeERxa28vOGpzUEpLZUgrUzB5YStkTndad3dMTzhqNFcrblNU?= =?utf-8?B?SmlHcXlpTUR4L29LY2NUcFpSS2ZJMzZTT2RmdHZ5aXUrcXEvZDVCaG9kNE9q?= =?utf-8?B?YTFmMW9rTll5YkVxRno4YUl5MzRoT0dWM25XcS9iR0FoQVFEYmZnaXNWbDNq?= =?utf-8?B?ajNjNnJFQWhFNlY1bHFaMkJGSENBUWV6QkRyM2dIWCs2S0lDTlA0SGcwaE5L?= =?utf-8?B?eWMya1oxc3ZpU2s0L0hpKzZRdnBWZUU5ZGVjVDc1dFIwakp0Wks0cGdEckFq?= =?utf-8?B?cDJVVmhSS1ZKamo0VlREUDVKWDc1dHBvMlROTzlsd2Qyak4yS1RiWHFaK2U2?= =?utf-8?B?SVRodEw4R1J4RDg0aUxTUG5oclJNNGpJK3FwUGZmdjdHZHNFam1lc2hYalZW?= =?utf-8?B?TmdNZWpoQy9lY0p3SHpQSVdseXM4dGloZHhwNkIrTlZlMTZNRjlNUXViTyty?= =?utf-8?B?L253VHpINW9ZQ2RyS0R1ZU5Ob0ZaRnVmbGdUWDNSNnRVQWQ5K1N6S3U2c01w?= =?utf-8?B?YVNiRjNCUitLU2l6YkNSSUpHd2ZKVVJqa2tSQmNUakVpYlpucEVGUEt5L09n?= =?utf-8?B?UDJRUFJkbU45Nm1rUmdBdG1jUHZiMGFmWWFnRjBSZDVNb1FQU3FrRDJxeTFm?= =?utf-8?B?RGMyeGVtZFJzaFVaWlNPak1hR2hOQVp5Qy9iQW1TbldwZXJMSEt5ZElHT283?= =?utf-8?B?Mk9XZDYwbHByemNiTm1Lbk12N1NLRjRXay9FWUdMMHlyWURmUXR6aDg3Smxq?= =?utf-8?B?Ync4UDMrT1RVby82VDJYK0MzL0tTUmFXZTRFbmsxUFQyQWZ1Z3BlU3NvYVBm?= =?utf-8?B?eUxtN3FkUFNVNFJsTjQ0aGx0dUcyMy9rSUVZN3ZjQXFUNEd3MlBkTHdHemFU?= =?utf-8?B?Y2VEK1l3RGRBclVocndWNWZ0eDRNVStTVm9DeWVTMVNwNG9mZ3VpeXpqcEd1?= =?utf-8?B?a2toMURkSmI3WFpGb3U4c2ZzQ1g0N1NuZW5EQXhvdkNnTnFFTE1ieXp4MWxQ?= =?utf-8?B?V1IxbDNqeHFYbzNkMkhvcGdtVXc3YkI4MDhSZDVLUE91QStmN2V2Vzd1MGRi?= =?utf-8?B?Rk52SWxvaE9oM1doNENWaHVVZFpEZUZ4SktCSysvK1l2RjMweDhHYTdMNmk5?= =?utf-8?B?cmNVS0pMZ21jRmdTTnZOeEZ1RmU5TGcwT2UyNndTTjBoMkh3NjJwNkkvd0or?= =?utf-8?B?Q2IzeFhUYVhuSGdhVHRkdUlveTR0UVlWeU9tWlZXWUFBNzFEbDBVRkgyR3g1?= =?utf-8?B?djZiV2hESVRlRUZWUEJTUGJDLzBkYkxXSUtZdUw5Q0lrWUZ4NittVm5nd21s?= =?utf-8?B?c1RpM2JSaGllSGRPempoaWxHQVBacTVVZmhUNUlHOUdWUS9RMXhFcXZlMmNl?= =?utf-8?B?ZTYvbE9SK0J3SzdJSkkyY2tpeTN4VDNVOVAvb1JvTkhVZDZJTmE0enRIZ1Rx?= =?utf-8?B?WjJTNW8rNllwRnBWcG5SL2xTV0V1RFluVDFIR2szcHJ3R1F2c1JLZWNpT3ZG?= =?utf-8?B?QWdBWHRib2JLRk9xekFmQVYyZkIwNXBQcDh6RDYxVGEvSm5lSUtkcUt0blQ2?= =?utf-8?B?VEZzeTJpLzIrcUI5T1RmNzFsY09ad2Z2ZURxNlVJQUk3QUlCVDI1T3hjWER5?= =?utf-8?B?RTA1TmRqT3B5N3VkT2JzUHBZTjR0czRDNi9SNkdMQkJVbmVTU3hlTGQ0MXlG?= =?utf-8?Q?j3BmGSBzG7hwoyg+DOSK8Ks9I?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee445cf3-ff33-4ee4-e0dc-08db4ae1060e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 07:44:13.9106 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4wQ59Car2FuT4GBCUGY0YY70YjDnLJhTf8t8T+pRb1TdfAxoboHpsJvXQSmn4nm9mvL2nKu4FWXfKDrI1mfZ3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8325 On 01.05.2023 22:03, Stewart Hildebrand wrote: > @@ -228,6 +229,9 @@ int iommu_release_dt_devices(struct domain *d); > * (IOMMU is not enabled/present or device is not connected to it). > */ > int iommu_add_dt_device(struct dt_device_node *np); > +#ifdef CONFIG_HAS_PCI > +int iommu_add_dt_pci_device(uint8_t devfn, struct pci_dev *pdev); > +#endif Why the first parameter? Doesn't the 2nd one describe the device in full? If this is about phantom devices, then I'd expect the function to take care of those (like iommu_add_device() does), rather than its caller. Jan From xen-devel-bounces@lists.xenproject.org Tue May 02 07:50:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 07:50:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528379.821445 (Exim 4.92) (envelope-from ) id 1ptklw-0006eL-I1; Tue, 02 May 2023 07:50:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528379.821445; Tue, 02 May 2023 07:50:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptklw-0006df-Dn; Tue, 02 May 2023 07:50:04 +0000 Received: by outflank-mailman (input) for mailman id 528379; Tue, 02 May 2023 07:50:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptklv-0006KK-9K for xen-devel@lists.xenproject.org; Tue, 02 May 2023 07:50:03 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2060d.outbound.protection.outlook.com [2a01:111:f400:7e1a::60d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f1c08b63-e8bd-11ed-b225-6b7b168915f2; Tue, 02 May 2023 09:50:02 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8377.eurprd04.prod.outlook.com (2603:10a6:10:25c::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 07:50:00 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6340.030; Tue, 2 May 2023 07:50:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f1c08b63-e8bd-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RxgGpEdCxhX8SEPQ22d/9zZfV8TsALWT/TM8iN0kTAkzpMBiS9BcL7exV3exbiYVH1d+4U0U1rn68sIxOxtHGY97K5LxhFeDJ2FVvhgZM/yYGscsFKImsllbqw86gInNBdQW11QNQ6ZGwN6U20GsZ20QAgTa7GVPivYLQHKNqwc99arKuVy+ICSS7fgKBV64yIfpmzHmwiSJ/2xAghhrj7rNeQpMJLWW1qjPN/Zli4tfRhCUfghIMPwafLYOuN6YyEH+XFmi2WIZQGXqazPKsAHYJqr+/nD/1MVUVGnYozRbdAu6mOqWQts0uYfZkUoYe/VF1i48m5ZM++Fvc5ocgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=slYW9KRkZUY7iZeaVQfzOkx3O2g9GRcyd0agbY3CAwQ=; b=dry7INdnYsNVFGnMPxY12sJLAHSTp++OBkX3gBIgfRaCBlpt3x7oIseGbTx525u2SZuLkmFSq5mv8M0LZsP7lGIT7pleNBld5auNM1To6ewqx0zg1Cg4Dwlpd0YDiShq6x4Lkd9FzX/xP6ua/nXcdp26HOfb0H6AgHO+FCElmDLMSd0Ac7gVtKFx1g7OobifQEeC/2xSyp4V1kMOUfehm+wihdV3EndPxmBsZi1EVF0CrUHW6WrpJRCOOTf2YPaYelaO4mLoBWkIIZMhC9W4GAhpfw3uQ/oHNISESgESTlgmD3HfV9OynqP6KBXpLIrZfVSgzhl3pI4VQBW7uGJy2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=slYW9KRkZUY7iZeaVQfzOkx3O2g9GRcyd0agbY3CAwQ=; b=2M9zENVKb7XiwhIMqu22II2wIzReOCr3BNOKv0OWMYSMa+N4gDdL6zM6HD0Qtu4WsCevwgYosrNrn0z8eL+BJbjuLUbnhrtb/LFTqep2ZRWahAjm8rEvg38Vtk1vaqYIF4LAM3ZCUcKVupON83I3dXXo9XDa1tNY1m7YMcgC02/a8xpoINgM1YfUHNxsxfitrzh1Si4aY2uWDsWrXbcs3Cr9zL4rSUbLn5PjvQ8RVktDJzrjJbzmclomGvfkN13+Pqq8bgW7dHII42IrIo+jJeiUMQSoLHnAYn+h12cgk6kP/3qfdH6ZRsC4945nhhudetuyKx2EWxh3GP4GJP6XpA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 2 May 2023 09:50:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v1 4/6] pci/arm: Use iommu_add_dt_pci_device() instead of arch hook Content-Language: en-US To: Stewart Hildebrand Cc: Oleksandr Tyshchenko , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20230501200305.168058-1-stewart.hildebrand@amd.com> <20230501200305.168058-5-stewart.hildebrand@amd.com> From: Jan Beulich In-Reply-To: <20230501200305.168058-5-stewart.hildebrand@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0164.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:99::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8377:EE_ X-MS-Office365-Filtering-Correlation-Id: 100cf02a-9e75-46d9-dd56-08db4ae1d471 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GwzwlViAGMP/4wKofkhTrxVgfxOYFxfwsH1TrXlyY6ezXvenOolS2ggkANjLUMOSGtXdRHo/SeuoXkD2DcMb7UNjlSvOkjR1KAeBLkAFQELcS9C7bcXbt7QeGaHM3Vb8Uhgn4XENow/kbYOaF3iu/fTV45RtwK8CzRbD+6xA6lc6xbqZPHoRFBN+y1g7chl0zslbGRJTjiuloxA5ckdY6uugDCS0fVXOZmeZd27iA4sqdoaRe06EFpxu2NeFiRwhe5xE7ZCI9xjn89qZ16vNp1d6UHmpAnRAeKtJMbZKN1uxOoqHh6fmbJq14F2kunsVXv2/bIVjTfNsApbxrxxvbqXzyunFdeYLvFLw6Ws84W9B2moMm+h3tyGlsCX5wwvn3FnQ2ekK9dZ3CnPrqihK0uYTb+eL2g63Q1YEMyWnJCp4JwhJWwfT8b4TrGh2bbm50cDqzA2QlGsZD4h3jFFg0ZS1AWSVy93hQ4eeZj/KLs0OU3Ud7UKB+EU4w4xFd94Nc153YRlJJGXIr3Vlemea7+C7/9i+9op0FqrgAtRUbbgCnaCvKE8s0UgXTiwAGpmvzUV+mCZtHSJsyHAGia73vgCC/g6F2nS5AoHUje7C6vT50UMhIxUIWr2jEFEavzIqqeKngxwAu7qjYLc1LSmvxQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(376002)(366004)(346002)(39860400002)(136003)(451199021)(31686004)(6486002)(54906003)(316002)(4326008)(6916009)(5660300002)(478600001)(36756003)(31696002)(86362001)(41300700001)(66476007)(66556008)(66946007)(26005)(186003)(2616005)(6506007)(38100700002)(2906002)(8676002)(8936002)(6512007)(53546011)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NWxTcGxvQWJtbE9SRy9tN0xVUkh3bWt0bjhyRDVLaEUrbUJuVGxrWGV2aDE1?= =?utf-8?B?eGR3UzRuSDkrYjFvWlJub1NUUFNXUkpJb0JJSEhtdEhRcDBIek5NZ2FFR09D?= =?utf-8?B?SWdlOTZ6Wm5WVFZPajBZMy9xc2pycnVFUDY4NVZjWUF4dk80K3V3MkFjTjdv?= =?utf-8?B?T2FSMDFaL09uQmNaRE5ETndEeVUwYVRSQ3hnelpodklBRGJRMGh0SEY0L002?= =?utf-8?B?eTRtM2ZaQkNmTTJKYW1mMlpHZEFtSUpXV1ZWV0dySnJjN0xYYU4zVUd1Tk1I?= =?utf-8?B?VHk2eUpjTk51Q0QzbVUyY290cDdML21PL1M2MGg4VzRiRll0dm9LckpOeC84?= =?utf-8?B?ZUpkeUI4WWFMaEdZVUtvZVV3aDgrNk5URzFCSzdkcjlnZnBwZUNkczl5VWZ0?= =?utf-8?B?aXBwYW9HempMVm5vTFJxbnhVK3pOTkErbXlieUQvRXA1ekVNaGFsdUlKbE5a?= =?utf-8?B?emZRZlo5NkZCaHl0MWU0aU81MEE2U2tIVlU0bTd5SkxZa2xVdTQ2MFM4SUp1?= =?utf-8?B?ZzVWSjhCbng5UXE5c04vNGM0OWpaN1ZBN09aZnhGclBjMXhuK0NldzVCZ0c5?= =?utf-8?B?YUs4RWtYNUlHbGpNSGhFQzhLMTlTR3pVblcwVmlJWXM3V1lLS0RvTENkSFpO?= =?utf-8?B?Qm9OWVMxQlFzNWxEMkNiUHN3TFl1bUtnN3Z5Z3VPN3kzMDdFWHdqQXRlbHVV?= =?utf-8?B?OThUUTJlRnZoZDljTGsrYURxN1pJc0hzWS9LYWRjUk9vaytyblQ2L09OUjRn?= =?utf-8?B?Wm0rdVlUelNqck5GQXhYKzVBa1RGOFlQR0VIRXNac3NTQzhmd2pjaXJMQ0Vp?= =?utf-8?B?bWtMelQyTStMK05EaFFCQVdNcmFjQ1dkVTd5eE81N016aFU1Z21sMnZZeHJH?= =?utf-8?B?eU0wK3dnVjQrdTlpUy9JeHYvNmxjMngwaWNUUFE3RTAwQ25na2JzVGtsaDBS?= =?utf-8?B?ZVJWYVNQLzJrazk3UDJRZm9aV3NwTElxWEoraTQrUXJkWnlxa2twcWdSbkZS?= =?utf-8?B?NkY0QTVNSlZJNzRsVEJvaCtJS012YnZINk5ha0x4YXF0amlkdUhNK2NoM3Z5?= =?utf-8?B?M3JhbXdPMEpWVE5JdGhZbWExdWh1OG1rQTgrMXdYQTd4alJWQnlGc0pCczg2?= =?utf-8?B?SUtIM2Y4QmVRSjlOcHhCcmQ1cHFqZDBQL1NtKzVSdE93MEUySXhOb3B4SFhM?= =?utf-8?B?T1J4UFpkaWNBSTF5alpYUmVPOXUzUm1KNklNWkV6a3dEWHp5Qk14eWtRSzhz?= =?utf-8?B?TE52THN4djl5NVczNXJMdTE5bXUzYURGUmxHTEhGSURrRzBTOVJhTzk3dlNx?= =?utf-8?B?d1R4Z0JvOW5MQU9SbE9WTkxSTVRZdVdQZkFyKzNvdzQrK2swZE5RTDBEUTJG?= =?utf-8?B?dEhSbW9CQ1dZVklqd21vK3BlUi9JVFd3ZFEzM3FqY2JyckNCZjhrOVAzbjRB?= =?utf-8?B?R09jUHVScUlEbWFWUHY4VkFCNUNxQmFHWm0xbmlDNVBQQnNIU0M4K1RTL2Np?= =?utf-8?B?MHNlQzEvR3pYa3NGSkdMNGNWWWcwMU1ZSm8wdDl0WGJwYm9KUWZKVmJmV25D?= =?utf-8?B?MHVZcGFxb2UvanZ3MVJSMFk5b3hMM1NZMlkrQ2oyZ25CdW5WUk5ZWEdlVHdo?= =?utf-8?B?RzZnb2tOUEd3em9nMTRXWTNBeEMvUXdoeFRnR2J3SlBkczZWNkUxYWd6ekhh?= =?utf-8?B?VHFPdUticjVuSGI3UVorZUkrWWxJc280STY5WVlpQ05ZbkJ3cjl0SWt1ejgw?= =?utf-8?B?ejhMQ0ZUMDhDS0FkZ3Z5TWNXUTB4d1ZZdFd4aUg1MmQ3SDBoNy9nakZDcVZ5?= =?utf-8?B?M2RheWV4d0d1L28yVDJ6RzlENGppUUFkMmlKSjNtVFBVZ05pWEhzR2tPNjQ3?= =?utf-8?B?dXhKaDlYOEdrYzUvUkJJNEEyVWVVQVVTaGs5ektKUkRUZHBvWnR5aW84Tk94?= =?utf-8?B?WTlUanhCY1ZaUmJSeWU0bWFDdElpWHpzY21XL01PWWU3dy9yUXV2Z3RUWXZK?= =?utf-8?B?MlAzSmNsN3dTaGtwVFJ2ODBZWUhaQ0FiY1ZHZkVCUWJ6ME52Ky9qR3JzUDNF?= =?utf-8?B?ZG5VTEdWWXBobVBkN04zaWF1K1R1RGs0WGpZeE54cXBjcCt0R3d0TjVZYjBy?= =?utf-8?Q?HH0wGI/THN9YekrD9Jq7rixmf?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 100cf02a-9e75-46d9-dd56-08db4ae1d471 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 07:49:59.8345 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: m7aeOGE8HyfdnjrgsJIy9IKOq3Ey52K4PmNsT41I0sHJjR/f76nib12izew0I7YuZ0Ju20WwLNMIOge6zz3OlA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8377 On 01.05.2023 22:03, Stewart Hildebrand wrote: > --- a/xen/drivers/passthrough/pci.c > +++ b/xen/drivers/passthrough/pci.c > @@ -1305,7 +1305,7 @@ __initcall(setup_dump_pcidevs); > > static int iommu_add_device(struct pci_dev *pdev) > { > - const struct domain_iommu *hd; > + const struct domain_iommu *hd __maybe_unused; > int rc; > unsigned int devfn = pdev->devfn; > > @@ -1318,17 +1318,30 @@ static int iommu_add_device(struct pci_dev *pdev) > if ( !is_iommu_enabled(pdev->domain) ) > return 0; > > +#ifdef CONFIG_HAS_DEVICE_TREE > + rc = iommu_add_dt_pci_device(devfn, pdev); > +#else > rc = iommu_call(hd->platform_ops, add_device, devfn, pci_to_dev(pdev)); > - if ( rc || !pdev->phantom_stride ) > +#endif > + if ( rc < 0 || !pdev->phantom_stride ) > + { > + if ( rc < 0 ) > + printk(XENLOG_WARNING "IOMMU: add %pp failed (%d)\n", > + &pdev->sbdf, rc); > return rc; > + } > > for ( ; ; ) > { > devfn += pdev->phantom_stride; > if ( PCI_SLOT(devfn) != PCI_SLOT(pdev->devfn) ) > return 0; > +#ifdef CONFIG_HAS_DEVICE_TREE > + rc = iommu_add_dt_pci_device(devfn, pdev); > +#else > rc = iommu_call(hd->platform_ops, add_device, devfn, pci_to_dev(pdev)); > - if ( rc ) > +#endif > + if ( rc < 0 ) > printk(XENLOG_WARNING "IOMMU: add %pp failed (%d)\n", > &PCI_SBDF(pdev->seg, pdev->bus, devfn), rc); > } Such #ifdef-ary may be okay at the call site(s), but replacing a per- IOMMU hook with a system-wide DT function here looks wrong to me. The != 0 => < 0 changes also would want, after respective auditing, clarifying that they're indeed no functional change to existing code. Jan From xen-devel-bounces@lists.xenproject.org Tue May 02 08:39:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 08:39:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528389.821455 (Exim 4.92) (envelope-from ) id 1ptlXA-0003fK-LF; Tue, 02 May 2023 08:38:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528389.821455; Tue, 02 May 2023 08:38:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptlXA-0003fD-IF; Tue, 02 May 2023 08:38:52 +0000 Received: by outflank-mailman (input) for mailman id 528389; Tue, 02 May 2023 08:38:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptlX9-0003f7-5K for xen-devel@lists.xenproject.org; Tue, 02 May 2023 08:38:51 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20613.outbound.protection.outlook.com [2a01:111:f400:7e1a::613]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c25d6db5-e8c4-11ed-b225-6b7b168915f2; Tue, 02 May 2023 10:38:49 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DUZPR04MB9981.eurprd04.prod.outlook.com (2603:10a6:10:4d8::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Tue, 2 May 2023 08:38:47 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6340.030; Tue, 2 May 2023 08:38:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c25d6db5-e8c4-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EgyPGO1kksQmiFNu/Kmo6csu45oBbMdf3mtqKjvozgwEIuyaupOZM2nP/H9lg2wpREH1kkTIgTKtH0zmOjgA7V1n+XQZNarmk1Kf+yMimm+yh6NX7UD9Ep+YMfbBjfdXRpfgRWtEKt0EOglhEvipF8CEmtFPeQg58ebKTygPazEvANqMqfjYLag2Lah0ZVvCxqaZFsv16WyRII5oZQxzEHnd7ADu6vEyv+OJO2opQufJ6hGAfQILyVhwhGxHwSB0lXscK80NTrqz7C0Lg9TBEldRRkIAFMhTAC7Y974J4qyk5A0RLc+VRMW25ENWYfupxwnh2pZNZ71MT+hXLG8uUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xuhrjsvox4jEM2bJBgm4PuEwQYTn8ZcnwU6nTDq3t+Y=; b=Fp3h7WbOh3Hekd+IwRQV+qzZOnzdbfVVgN3zs7qbZ0r0JqrLYepW8teNZo49VIc6JMNN5tVc/z0zStWUy70WWAtM08dJ6PARKJXbK+XFMv0Y7FVXGq5hX0AuXG1ro1Oc0uciY1A/zIcmK6mdHku6EhoGXVk6umwZ9TlDnX/pyrcKzu2A7XU+v3X2fUKDDCNR62L/z87+59+GYqvqJUGqc/ccDp47Bjouxw3r9AMIyimQX5VJQ0mk9yMnY9R/oG4Bk+9XYK0a8D2A0OCk4li0KXcygbxbQ8nzF9usOlQLY/uHGUOd11GBfYTN5uSgqP0EBLi4+L3AcCHmoqpnbG1nbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xuhrjsvox4jEM2bJBgm4PuEwQYTn8ZcnwU6nTDq3t+Y=; b=EfAtQOdEHEAhCwwZCtwF6/ysvKn7eLbxrFN4oBCio20mbUdB2tjLNk/Nn9iSK0LBILwxvdjDcqJkbVjMFVlhdRIGCp3NNzHL9MDNdbyXo5GEIvjZh04vK/KaknmYXnJRlyD5HJtcmLDzjxJ3c3+3i1FLb+tJo2jiGFbUg+5157RAM3644Q0f35fhAaCS+2SX9jCpwou3Rwb1o0z610CatGPMjeB8hv7I7Blo7l6+5ZQIPD/+u5t397UhxJ2b/XMkqJqA8djcsnfKAyCX4nIOl9I19C2QyiHrRLdREHc03zwzXHenvS+ilzBu8gFb5EGnKsaDVttGI7f4FVGe9HFn3A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <11eb3319-d03b-ef5a-7006-49f0cbb2826a@suse.com> Date: Tue, 2 May 2023 10:38:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH] xen/grant-table: Properly acquire the vCPU maptrack freelist lock Content-Language: en-US To: Ruben Hakobyan Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20230428102633.86473-1-hakor@amazon.com> From: Jan Beulich In-Reply-To: <20230428102633.86473-1-hakor@amazon.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0192.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DUZPR04MB9981:EE_ X-MS-Office365-Filtering-Correlation-Id: 0d2eb96f-1957-4363-6937-08db4ae8a4f6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ar/flNsbbs3iq++bvZBgFotxcVttPfyqEBUzYSVUNx8IA6oUvCyuh354j1cRg1myXRLY4d16DCQ/w2zi4RMaxvY7rwbybV+JkNxUhlMzhCR0PiPXeO/zfMftsiyzBAdMvasRJxz7vq7uS1eO48tbsadvfQIBZdfa/ENIIOEpY51U/SHL9/vn7t4gHPJmI1wlpFg88NPDKS8TsZk+65l5imkuyOEYe3vK+q3RcuctyZES0dqILdKRwfrq5Er4vvo2pOmJKBFxpQnepHUNFyzNqfDDAVCei8FFyHgCH7j6lc0JojInm8riFy/JZLX0hAp6RYLrkDP8Gp5E6ZNHCZ8cdoivpycTogJKceuyTk0wVF/0Klr7AsHNKv6BK8zO8NEB/y1FchbYzCeeUgPstFKgBgIgSjbt1b/UNboQq3Iei/ckG1V4b3JHRr1oCv/6FfhTWkXf3kezV6w8qJF4j+zakCO0RWZwO/22KiqZPneBBf3uGwQz1KHPqGNrg4Lt1Cw8k+pKg1zaCB+eKJVeHRS990k5oFbFqH4RrkqlZx8WhIAiLD4eUxRn8eE8K6kN43aOoqGvg60vVQilqRJl8FHMKBq5Q99Pk7VioS5ZQ2GgQn+3PQ1BWxpGzsYN84JEQPoTj3p5sbQFYvxu/LhYFPtc6Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(396003)(346002)(376002)(366004)(39860400002)(451199021)(26005)(8936002)(2906002)(8676002)(2616005)(6512007)(6506007)(53546011)(41300700001)(83380400001)(31686004)(5660300002)(38100700002)(316002)(4326008)(6916009)(66476007)(66556008)(66946007)(186003)(36756003)(86362001)(31696002)(54906003)(6486002)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eDQ0Skg2WTFrWWNGbytTQ3Fma0FQMklZVnpxc0Z0Z1YrMjFzVFJLMlRSOHpr?= =?utf-8?B?VEdKalJNTlFuMTN6QnBwZndnRFZwa3ZLb0Q5eUt0a2V2REd6N1lnbWNPdEJX?= =?utf-8?B?NDNleUt1VVdxNWxJYWhvQzBhODdZN0Juak9tU1gxc28rckk1NXQ3SnV3d1VQ?= =?utf-8?B?bWRmUzVHQTBPTVFCSDJOQ0VqVWxUTko4WkJHOUxLamNjZEU2NDdpaWtBWEs0?= =?utf-8?B?T3g1c0NDMk5JN1hBUnZHVlY5WnBvWnF0YVAxNlpFYkVaMjdhK1I4VjZTcGFw?= =?utf-8?B?cnc2RS9SRENVV2RKVFF3SXVmeFhYOWNDZko2WkdZbTlHMGpXVnQ5ckU5YUV3?= =?utf-8?B?NW8yVWhOd0tyV0lZTG5GUjdURDdCMW81VUZxRTI0Ykx0RldLTVZLZHkrbERL?= =?utf-8?B?NHpUQ0NER1ZscVl6cnZVRVhvUDNrYXNUTkh0R1kwU1VEazZiOFlYZmxibzRo?= =?utf-8?B?aHFmMGQ1UlVGUDJtaEV1QWVkUENVRjNMUjRsbDVwT21PZHFsMXFtbzJERVNN?= =?utf-8?B?U1p0Mm5CRk9ITUhlNXN5M3hnQ1lsVDkwa2xRNUh5YnVYTE1OWis4TFRNSEhT?= =?utf-8?B?aTg4ZE1tTFNBNTM1aFg4VENkTVp6UFIwZVl0WllTUSttejVPV2VyM1gzY3BN?= =?utf-8?B?d1Z3eU03OXVKR0Q3NnRSQi91TUNISGpHNnRNM3dUWm9ubW9Xc01xRWp6VE5l?= =?utf-8?B?R3NmWUZLZUFLY25yNUVmalhzYXRJcGxaRlJHRFo2SFlSRGFFNzhsdVZQS3BY?= =?utf-8?B?MkxQbjNXRWJVendId0J5aFZxNHFIQjNobkxTOTFnMGNETEQ2c0FZMmhzNjg2?= =?utf-8?B?SEovS2paVkQ3YnpDWittOUZBeGRnVlcxcmxGYitPNFplQnVyTmFWZVJ3eEZV?= =?utf-8?B?WFFvck9DTy8wM3I1N01MZ04rbTJGRjJ0bXhKTWdTMlRwQ2dWMUs3R3FTcElt?= =?utf-8?B?LzM4d1BPTUNER2dZRVZNdHh3SGl0LzlzdnhNbGVyd3hCQUpBS29CdXA3dHlY?= =?utf-8?B?RWRGL2pKdWxySXRZV1dhV0tpU2pwNUljZ0l3bkVHVnBJVFJQamtCSTFIYTlM?= =?utf-8?B?UlBYOGRwZUIyZ0k5bWlzYjVHWUpGYVpIT2wwTGZ2cDhBQXd4cVZieldZbmc0?= =?utf-8?B?WUtSWWNqVGd4TVkzMUlRdmtUY3dRd1dnOGtIVWFsQ0tES0dhTjk5T2V2RTc5?= =?utf-8?B?RlZEUm5UTGVkVnJGbXBDRnB3eFVkN25IRkNTTko3THdmSTNGU1g5MmVQNjZK?= =?utf-8?B?SzNvUkpmb2FaanNYV2VCT016RmJIMGZDQUU5SndZNXprRDJZcXp1UUJGdmt5?= =?utf-8?B?cU1pb3lDYmhDbURNcDlIN3NEMnc3YWJvU2YrWmlETi9MSTBFbFpEWS80Zi9w?= =?utf-8?B?VUJuNVRTTnk2QWhacXRpbFIzNVE3QmhmV0dpUkdPWmxtT01LaFFqMW5wcFdC?= =?utf-8?B?WWtUOERNTkl0czBzcFFmcTNtWllrQjRSZDJsWFhwVW9FRUV0ZEQ2ZHNvek1W?= =?utf-8?B?MEpvdGJGZFAvZS80K1BhQStEVEhkMXh3UGxIcEwvUkxFalorSEtFeWVQaVRY?= =?utf-8?B?ZzFsYXN5SGdoSXNGdmlpOWhGSFlaZU5oLzk2TDAyVXJCR1czZmdvUGkwaU91?= =?utf-8?B?Ujl4VHFqNVYrMFkvbFNUelBjOERnMjJDSVF0TjFkVWNMc0dMYktkRXBudVM1?= =?utf-8?B?WFdSSk56NFBKTnVEM3h1bnlCbVFPTFhSSDg2Y1hyM0MwbXZXQVZEeno3T21m?= =?utf-8?B?WGVpaGVNYlFVRXpTRkdkY3dudkp0Q2U1WmkvRlJ0b2VTQmsrSzhWVEZmQ3lh?= =?utf-8?B?Y2dpTW92eHFucHovN3h4VXhqMnVjekZ5eC9XbWg0UmlqK2Q1YkJkV1dLanpM?= =?utf-8?B?Uk10MHBOSWM3ck0vVUFoUGdacmUrT1FJeTJDVklySFdaSkx3UVpCaHNMVEtn?= =?utf-8?B?VEhwRlZTU1VabndGbjM5OWNNdXFld1VUY3F0eUwxUjN2VVVVUW1wbmNucTFv?= =?utf-8?B?RndQTUlrZXhHdkJhK0wxTWc5b1llaHNjbzB5dzJVNWR6K1F4TjBHMGJqcDRa?= =?utf-8?B?d0VaRTcwMmdnOEpuUTFXWXBqakZKdTNFRmZFSkt2c2k4VHFtUnNtQXl5dkJm?= =?utf-8?Q?MTDrxG2t74xWNPd/+bnTleCTU?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0d2eb96f-1957-4363-6937-08db4ae8a4f6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 08:38:46.4926 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: stFiVwYEEacLnhdC26P047dlW2uX6MEap5XMaLHEYwydGVLmx5hHvPJa7GHqrlkBwgHQH9Yh/gqwysy0ey4HWQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DUZPR04MB9981 On 28.04.2023 12:26, Ruben Hakobyan wrote: > Introduced as part of XSA-228, the maptrack_freelist_lock is meant to > protect all accesses to entries in the vCPU freelist as well as the > head and tail pointers. > > However, this principle is violated twice in get_maptrack_handle(), > where the tail pointer is directly accessed without taking the lock. > The first occurrence is when stealing an extra entry for the tail > pointer, and the second occurrence is when directly setting the tail of > an empty freelist after allocating its first page. I don't read out of the doc we have that this is a violation (the lock still fully protects the list, just - as you say below - that in two cases taking the lock isn't necessary to achieve that goal), and iirc the relaxation was done quite deliberately. Did you, as an alternative, consider making the doc more explicit? > Make sure to correctly acquire the freelist lock before accessing and > modifying the tail pointer to fully comply with XSA-228. > > It should be noted that with the current setup, it is not possible for > these accesses to race with anything. However, it is still important > to correctly take the lock here to avoid any future possible races. For > example, a race could be possible with put_maptrack_handle() if the > maptrack code is modified to allow vCPU freelists to temporarily > include handles not directly assigned to them in the maptrack. > > Note that the tail and head pointers can still be accessed without > taking the lock when initialising the freelist in grant_table_init_vcpu() > as concurrent access will not be possible here. This "no concurrent accesses" is the justification also for at least the "set tail directly ..." case, aiui. > --- a/xen/common/grant_table.c > +++ b/xen/common/grant_table.c > @@ -660,23 +660,27 @@ get_maptrack_handle( > if ( !new_mt ) > { > spin_unlock(&lgt->maptrack_lock); > + handle = steal_maptrack_handle(lgt, curr); > + if ( handle == INVALID_MAPTRACK_HANDLE ) > + return handle; > + > + spin_lock(&curr->maptrack_freelist_lock); > + if ( curr->maptrack_tail != MAPTRACK_TAIL ) > + { > + spin_unlock(&curr->maptrack_freelist_lock); > + return handle; > + } > > /* > * Uninitialized free list? Steal an extra entry for the tail > * sentinel. > */ > - if ( curr->maptrack_tail == MAPTRACK_TAIL ) > - { > - handle = steal_maptrack_handle(lgt, curr); > - if ( handle == INVALID_MAPTRACK_HANDLE ) > - return handle; > - spin_lock(&curr->maptrack_freelist_lock); > - maptrack_entry(lgt, handle).ref = MAPTRACK_TAIL; > - curr->maptrack_tail = handle; > - if ( curr->maptrack_head == MAPTRACK_TAIL ) > - curr->maptrack_head = handle; > - spin_unlock(&curr->maptrack_freelist_lock); > - } > + maptrack_entry(lgt, handle).ref = MAPTRACK_TAIL; > + curr->maptrack_tail = handle; > + if ( curr->maptrack_head == MAPTRACK_TAIL ) > + curr->maptrack_head = handle; > + spin_unlock(&curr->maptrack_freelist_lock); > + > return steal_maptrack_handle(lgt, curr); > } While this transformation looks to provide the intended guarantees (but the comment would then need re-wording some), ... > @@ -696,8 +700,10 @@ get_maptrack_handle( > } > > /* Set tail directly if this is the first page for the local vCPU. */ > + spin_lock(&curr->maptrack_freelist_lock); > if ( curr->maptrack_tail == MAPTRACK_TAIL ) > curr->maptrack_tail = handle + MAPTRACK_PER_PAGE - 1; > + spin_unlock(&curr->maptrack_freelist_lock); > > lgt->maptrack[nr_maptrack_frames(lgt)] = new_mt; > smp_wmb(); ... I don't think this change does: It now leaves the free list in a transiently corrupt state until the freelist-lock is taken again a few lines down and the list is further manipulated. Ftaod it's not the state itself that I'm worried about - that remains as before - but the supposed implication of the list now always being in consistent/correct state when having successfully acquired the lock. (Iirc one of the goals with omitting the lock here was to avoid lock nesting, even if this nesting arrangement is permitted. Plus of course said observation that acquiring the lock once here and then once again later in the function doesn't really help. I don't recall though whether there was a reason why setting the tail needs to be done right here. Yet if it was to be moved into the locked region further down, it would need to be clarified that such movement is correct/legitimate.) Jan From xen-devel-bounces@lists.xenproject.org Tue May 02 09:23:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 09:23:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528392.821465 (Exim 4.92) (envelope-from ) id 1ptmDj-0000Tn-1j; Tue, 02 May 2023 09:22:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528392.821465; Tue, 02 May 2023 09:22:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptmDi-0000Tg-UL; Tue, 02 May 2023 09:22:50 +0000 Received: by outflank-mailman (input) for mailman id 528392; Tue, 02 May 2023 09:22:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptmDh-0000TZ-0z for xen-devel@lists.xenproject.org; Tue, 02 May 2023 09:22:49 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e331ab5d-e8ca-11ed-8611-37d641c3527e; Tue, 02 May 2023 11:22:43 +0200 (CEST) Received: from mail-dm6nam12lp2172.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2023 05:22:40 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by MW4PR03MB6348.namprd03.prod.outlook.com (2603:10b6:303:11f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Tue, 2 May 2023 09:22:37 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec%3]) with mapi id 15.20.6340.031; Tue, 2 May 2023 09:22:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e331ab5d-e8ca-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683019363; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=cXZQ/ieTQqnv0yguUimYMbrZgvtXD6uzWuHWWq/PDVs=; b=fibALUWuSGbHKl/5WkVaXWXBI3Ge1Y0j2y4alYOL9jX6HS4ryD+t2f0L jleA8ARM3HqSRVTR1O4zlRPW5kjofqxejhcXr7H4jOCMSzUmX3o+poDkG ry4lw2b1hFQoQoMHvxfrQ/OD9TvhO9v9qHguPJ4seAK7OGnY32+Cn0S8i A=; X-IronPort-RemoteIP: 104.47.59.172 X-IronPort-MID: 107567437 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:pKlYPq8d9/v/dYFMoADsDrUDpn+TJUtcMsCJ2f8bNWPcYEJGY0x3m jQbUW/XbvfcMGXwL950PNmw9RhV657RmtRkTldv+S48E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kI+1BjOkGlA5AdmOKgR5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklep N83DBkGUSmfjvqt2pWnSM99weIaeZyD0IM34hmMzBn/JNN/G9XvZvuP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWCilUuitABM/KMEjCObd9SkUuC4 HrP4kzyAw0ANczZwj2Amp6prraXwn6lB95JS9VU8NZrr1646UwdFiQGbnbloOeY0FKOCvJQf hl8Fi0G6PJaGFaQZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpatYrqcs3TjwCz UKSkpXiAjkHmKKRYWKQ8PGTtzzaBMQOBWoLZCtBQQ5b5dDm+ds3lkiWEYwlF7OphNroHz222 yqNsCU1m7QUi4gMyrm/+lfExTmro/AlUzII2+keZUr9hisRWWJvT9bABYTzhRqYELukcw== IronPort-HdrOrdr: A9a23:d0fq5KAqEkL55m7lHejXsceALOsnbusQ8zAXPo5KOHhom62j5r STdZEgvnHJYVkqOE3I5urwR5VoLUm8yXcX2/hiAV7dZniFhILAFugLh7cKqAeQeBEWmNQtsJ uJeMBFeaPN5TARt6rHCGLTKbkdKBbsys2VrNab9lMoaTxDL5hn6QIRMHfvLqW1LjM2dKbQ0P Cnl7l6T//LQwVmUi3BPAhjY8Hz4+fTkY7gY1ovHgdP0nj3sRqYrITiFgSe3FM0TzNLzN4ZgB T4uj283Lynr/a4jjjV02O71eUxpPLRjuFbAdCKiIwyNDLhkW+TFf1ccozHhikxvOasrGwLvb D30mwdFvU20WrVYma25SHgwBbtyxEn73OK8y7jvVLT5fbhQS48CY5/iZlCch3fgnBQwe1B7A == X-Talos-CUID: 9a23:j0qjMmPvjGfLku5DSHhE22o9Ef8cbnTF1233P02eGCFPcejA X-Talos-MUID: 9a23:u7aSbQrPEUBcnf5gX0wezzBNN+xHw6qwMVA2vMsHpejeKRwhGzjI2Q== X-IronPort-AV: E=Sophos;i="5.99,243,1677560400"; d="scan'208";a="107567437" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oEoxG0VdALQg+l7WgfIC+Jgz7G7BisD9OG/30gA3LKQ3Y75lHzwNDk+20pPKW52/wX9KkiyHxrC67JZBgwLEZ4jN3+QFH0dpqRxqZ0erZp+iryw0yQfSlJA4wgD2CNRKKc7coZn8ClK61Y3pD6QQoyveTR9AJKUd2moRcPuaSROIrtYd/LP0SQr8XuLnrhrhi1zR9Ic3yq5+9me4kzvgMVFh4xNawQJAzsuIx2tagUd+Vk9Bb7hKLalwLf88J8Y4h+KiOhG47tpvXqhdhHo4xS7iwBmmMeiSOIgDfukC1ZhfMBRMeCX+w36waqZvWipXF40LabcVk2qzK855UT8gIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6wsYJPe0iu0Z4mSkpPhl8HsiIbXw2+t+onLantpeZho=; b=Huhr7yj6GmH9BlDJZfUfroHMePtFb1yp3J4Jt/GauGiODO4r23G+mDEsWOdzdhOvIIuauyTmPt6gJIlI9wDE4sLxvklB+CGgCp1tAgE60GG1NnfAY9aG2S22A+JGuG1S7zCX3C1k4f//WZq8DkF410w5WLYiaEyjtO/TMH3wsdry3tPWdv1F6PFrwP3srFZGfJlhcfGGcUlSck7NQjrHcdoVIWNYynu9VAhBb2Q4b9stON8vZkpSMV4ud1ca8w0r2w5rHapLZBvVof6tylyFAFbzfv5wLZ9c3ewnkdckADdU1rNWWDXVIY/0Ht/IVnIc2Pdvz3ET5+pHuBxrkCbQ0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6wsYJPe0iu0Z4mSkpPhl8HsiIbXw2+t+onLantpeZho=; b=XZMKRRRo0xHpKi4a9Sj7rpTC34e+7V5fVNg5vCVuZdL6RoqFOvgbyzU8D2Ohm8UZbHv4I3j9ZYCfHzcVXeA4t+uDPfTAemMlBsiygduLs7IQPqVUTMRaMROaUuEXlUNgQ5RqKg8X03YPR4H1Z6mNljwtMzeiGs56+eFr9J5o9gc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH 0/2] x86: init improvements Date: Tue, 2 May 2023 11:22:22 +0200 Message-Id: <20230502092224.52265-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.40.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0528.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2c5::10) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|MW4PR03MB6348:EE_ X-MS-Office365-Filtering-Correlation-Id: 0c4d8aaf-6154-4097-76d6-08db4aeec550 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RC792jRsx6dSUTpiv6J5dTZNWWX1UoO3ZfqLoBhB3vGWTeLBdKqFi/mdSsQzWnfy3F0B6A7e5UkKsbRnAlyInq2VfYDjj1q1Y48L66AnJ6We4obLH07f+pcgzigPbiyI/reVz4mM1nLn92u6GTMfng1f5nEqB86869SqNUnWFkgW7agyL5QkNMvqnbJup3RgDMMU+AqDKSri0PVG+GMa/CftAH2Dpza21mGMEMA8Eea/FwaesYSarbLkzLb0rOTS8Ft7ZAaWsaXtwQO5c3OgR3Zb3Wmv5x0lB+MTivco7/ZzGLDVVup8ijEqXgXeSD1tmGsW6MKoF4LmGAwXKZFw9a/dGvnuMuVCfxd49WG5tzPNktVTFpHBffP1xbrn8bpxYf8vHYvxcgugiuvZRoYQBzFPKNllM+2lCi0G+f4Xq7EMqoACVdhJ/97wpNOgefQDe1CxL1LLqUy/LhYu47GsKzl8jnY6lD2j74ewUTn+pTL8w0vtsjlslEJv3auOc1K0fYZB7PpTO34vSlVZEP9A3+C8NNbetdqMzCIniO44ZpMy3ad/EvmLYeti96ULtnOK X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(376002)(396003)(136003)(366004)(451199021)(83380400001)(26005)(6486002)(6512007)(6506007)(1076003)(6666004)(186003)(86362001)(54906003)(36756003)(478600001)(2616005)(82960400001)(66946007)(316002)(38100700002)(41300700001)(6916009)(66476007)(4326008)(66556008)(8676002)(8936002)(5660300002)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U0VHekxvL2EyV1YwR3EyUkltelg2MmlEZDZVQ1NJRW9NSlhzNHBBOWVxRkJR?= =?utf-8?B?RXRlbzErYUtQRjhEeXRFa04yU1I1V2orekZIZG9GQ0pNK2p4c0Z2bnFuREZl?= =?utf-8?B?SG9Bb2Z4S1hTNDBBMjNxZ01YQlAwZlMrekcyQUNFTWV2Ym9hU21FUGpKUUU3?= =?utf-8?B?SnBxNTNyVTNTcEJzcjFSazdHQnlDK3dXNit4eG1wWXUwQ1hDYUhTMHg2dmtQ?= =?utf-8?B?Y1NxWm02TEp4WnBBbTFmcnRlN2pJaG9hV2FJU20xWDE2NktzTG5LOFh0WDc5?= =?utf-8?B?cCtSSFNpWjhkV2daMTg0cUJ6TDdiRCsvYzRieHJYRXl0UitDMTFWbk5NSkd0?= =?utf-8?B?QmRjUmxzLy9ZeXo3TkJSZW5BN0cwb2QyaHVXMS9lYWlRQTFwNTNEVm1YcURR?= =?utf-8?B?TFpLZ0psZ1BGTC8wRENLQXVFa250bkVwRlByZHZCL1ZpcHlzUU9tNEpFQno3?= =?utf-8?B?N1hTekFkN2hEcTJkRGswWHV2OU1CT0M5MmJmYjBEN3VMN2NIT1VJc3k2dngx?= =?utf-8?B?OUtUK2tZS3JMVnYzWmlJdndZZlVIZm5wVlhjcjhqRFR5VHhrRm13RWxPZzA2?= =?utf-8?B?NXF4Uy83Y2grQVhNR3lwVGYxaE5sWHJ4RzZzUG9WS0xsbEt0cjNZa3BKSjlV?= =?utf-8?B?ajlQeEp1MVRrZ1R0cHVXR0NaOUV0YTgxRk9SOFZoeS9JbXpCdzZVYmdmR0lH?= =?utf-8?B?L1pmWlNaSUliaFZMOGVnMUhwL1VTci9LVlp5TEJzM29jOTBTOFBJUkp0YkJR?= =?utf-8?B?aWhuRlhHNzhHOUVxbnVjZHNMaVZPcFppd0tEQWF3VXk1WFYxN0V2elhRcDE4?= =?utf-8?B?RmNDMWVYNExTSmY3TmcwTzc5bjZGVzZoa2V3bTFza3Znd3FTNXVXMWpORW5t?= =?utf-8?B?SGFlc3FmUEVYdmd0SXRaZGRSSzNHcHdDWjZGYXA0MlFWTGozNUtkRDIzVFla?= =?utf-8?B?NHdWMm9GVCtJazcrVUFGR3BFeW9pN1Q4cER3NnRBb0RqVy9TamZwenhvNHA4?= =?utf-8?B?QmI1V0pXYTgvS3c2SlNPZ1BEOVRCbnJ6TFFSRjR2NkE1UUNJQnI1VHJWYnJi?= =?utf-8?B?K2RzVjU4M3hUaWs1ZWQ3VjBYSWlocytxOWlOYmJYaUF2T3VSVzFXYWw2d3Vv?= =?utf-8?B?d2NUVjFVRWwwcWlnM29vWHZ5R21aVUNjYjZtclVCeG5TTUpsOVJRbGRYVW8v?= =?utf-8?B?bnNReUdaUEFGaTlkcUNNOU04R2FqbnJKVEpDcnJiWElJNjRrV1k3MmFwS0M5?= =?utf-8?B?MnlsaS9TVlA2YXMzU3BqU3NHbHpZazhWZXRuQ2dMZkJCVVBLNGliTWU5RXJZ?= =?utf-8?B?UWVoczVwMlU5V0RTK045OCtEbHNuS1YvWm5YN1RYVzRIT0lid3B2a1lQQWEv?= =?utf-8?B?SHNVcC9LRm9jdi9HTHBabnYrQkVFMDhyWkMvUWRIZlJIc0ZsMjJLMWdVcUlm?= =?utf-8?B?YVlvKzlKRWNjZnF5bFBENWhnQjlyc1lYa2U0NzMyZVkrbXZYeWlmTTY4ZHVm?= =?utf-8?B?WWZpd0xiYnNOMkV4WVVNSFZQVmRFRFpvWVhvcnJ5QVdhZTlXckFoM0VsLy9E?= =?utf-8?B?dVdLSHh6YlF1dDRtOU5zbmZLcWY1VGVVekpudzgyUU51WmROb29rYVNJVzRF?= =?utf-8?B?YTJyMGgydVlRbDYvcTYzRjRNZklzTlZsK3BTbVlnRlY2MTdCUEZnTWk0c3Zk?= =?utf-8?B?Zm1meXNwVDZPK1VBUzB0TmdJOW9UM2Z1TzZWN1J4T1lybk9VandoOHNsR2Fp?= =?utf-8?B?VGtDQ3JmN09uSUk2VEgyV0gvQzQ0UUdMMUFZSkE3TnZtei9OVWRwaGo1VjB0?= =?utf-8?B?QzdvRmhWSnBOTjVzY2ZCcDd2Y0FjRzFHMXQyMzU4T2p0TjF4dkZ4Q1JhTXFG?= =?utf-8?B?UFcrMkltUjNIWno3Mi9hV0hCNUFTQUVVcVV3RzFKbkpYNEhKVHptZk5PQUdV?= =?utf-8?B?TnNIQThFa0FSWkVrTjhiUjJkNVJzdUlrazJUbElYbFZrMWdEVUxoS2xtalM4?= =?utf-8?B?K2FWZ3BRQWFvbjl3dzY3eVNIWlJGcUx2VDEwWTZGZk9aTnFKdGxqRTJiUkxK?= =?utf-8?B?ZTVoZG9yVnc0OGRyRGtPWUo0T2g2L3A4L3RiV1M1b2lhaXJJZTluTVJLNmJm?= =?utf-8?Q?phM2DuD9agvGH6aZDo9E8iczA?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: J68I0eyDnjPn1mb+0lkfdKVXXi4T5M2ef2HHVubLu0B6f3WEBqfZqj6me95K/rdT7sFCjP4rt/IUAeRDpe7sJREZ0Knr666B7DJ4I9I+FVu2ETRbm/gSiNfpg9t3+sLIzMK2cF0i14JydbKLWrz8Q7kVdtxnhjMKry+wNhELpszQexpav8KQ4f9qlNGX4+Vkbt8uyPEPSYgH1ErJTGjpa1ztpfW5e7xnFHc2ORZ+f+rgOjWgiuL6rMb0lIFnbaL3VYdyiLfrBjSxq7/yws+nVgE0YkdqZsPZMnDsSitJRsHTs42Vs38rKBjG8684+IRYIyh02ef4QDUZqlNoC3Qe9Gfbuhd4jKMJO4di5gxRXw7Gas3ndhmX5uhJ2GL3dl+HvhdhcAIvux7SUcsUQIQ5dQk5ephBhvPPDO2PQI6q6TIKkMaZe2/BHDcquu3NuZpBIgDRuNbsRgZPY3GO9FI1CMGc7dXvIkC8wJOa2UwRTmlzyz9viE0LrbjsZVMRg0Ed5dLbpkxDVQopGvTg9sKJO9YneT6cFn0oIr+A88y86RWAkzReLAOzJDNbJXS2aFqpJZBKRw/rOnW2k8x9oTOgXG6bCJYeig8OepvDKMrwucix8ZUD/bl5f7tjG9+h4ku+FfH4QiFFSYIBxIljtstC/emeidbiGFHpV+5utS3Hwz36ubQRGaMxpLY6PBtxq/IZDI+XbqabjYqJv6mzjr7xOlTSuqilhZ0GZxO8g0F86E/4j704wAeMaDjBLmIQZ6W6V/nuClTrA2+i22I6YkmkNgQQLZDvSwhdYlLR4KVhgj9qz1ttqCePCmUaSMiBe5RY X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c4d8aaf-6154-4097-76d6-08db4aeec550 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 09:22:37.7760 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yR+0adD1cj/ewrJHc4FnZcIn++HFKEGXZ2VW4wq8nFepfcGIazeXC5Ce1WNrme+c8h9BpZma7nWafxBSgCqx3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6348 Hello, The following series contain two minor improvements for early boot: the first one is an alignment check when building the initial page tables, the second is a consistency fix for the GDT used by the BSP for the trampoline code. Both are a result of some debugging work done on a system with broken firmware that resulted in Xen text not being loaded at a 2Mb aligned address. This resulted in corrupted page tables that would manifest as the ljmp from compatibility mode in trampoline_protmode_entry causing a triple fault due to the GDT being located in the Xen text section, and the page table entry for that address being corrupt because Xen was not loaded a 2Mb boundary. The aim of the series (specially the first patch) is not to allow booting on such broken firmware, but to print an error message instead of causing a triple fault. Thanks, Roger. Roger Pau Monne (2): x86/head: check base address alignment x86/trampoline: load the GDT located in the trampoline page xen/arch/x86/boot/head.S | 9 +++++++++ xen/arch/x86/boot/trampoline.S | 6 ++++++ 2 files changed, 15 insertions(+) -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Tue May 02 09:23:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 09:23:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528394.821481 (Exim 4.92) (envelope-from ) id 1ptmDp-0000qm-NF; Tue, 02 May 2023 09:22:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528394.821481; Tue, 02 May 2023 09:22:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptmDp-0000od-Ij; Tue, 02 May 2023 09:22:57 +0000 Received: by outflank-mailman (input) for mailman id 528394; Tue, 02 May 2023 09:22:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptmDo-0000jF-P2 for xen-devel@lists.xenproject.org; Tue, 02 May 2023 09:22:56 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e8d30504-e8ca-11ed-b225-6b7b168915f2; Tue, 02 May 2023 11:22:53 +0200 (CEST) Received: from mail-dm6nam12lp2176.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2023 05:22:45 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by MW4PR03MB6348.namprd03.prod.outlook.com (2603:10b6:303:11f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Tue, 2 May 2023 09:22:43 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec%3]) with mapi id 15.20.6340.031; Tue, 2 May 2023 09:22:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e8d30504-e8ca-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683019373; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=KCDk/0A8ZabYB6hXuyuxQS2zkZwTzSsysD0WyLMx1Tw=; b=VWf4lLapOIvDzCKx1+Vd3ij4fAS0zOnmp7uudB5BF23R6v60bK89Z4vK YzLChJIRjYvST0Lnqd+gWXgmJn3pUbNl30JpkwXE425fNApkRiukTwJq/ z5f02g0406sUkOWQj2dJaRz+rsTAthHayZ0CbZR/TAAEFVHZ0IKBfYN6/ I=; X-IronPort-RemoteIP: 104.47.59.176 X-IronPort-MID: 109990342 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:4m+MZa3wP7j/nkcxJ/bD5fVwkn2cJEfYwER7XKvMYLTBsI5bp2EEm jQeCGzQOqyLYWP0fooibYi2/UNXvZTcm4Q1QQZopC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS+XuDgNyo4GlD5gFmP6gS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfG2tBy OE8dykxbzPYm+3s6ZyddPlAr5F2RCXrFNt3VnBI6xj8VKxjbbWdBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqsi6Kk1IZPLvFabI5fvSQQspYhACAr 3/u9GXlGBAKcteYzFJp91r13r6ezHugBNh6+LuQ1681rhqa4HQqCzoSW0qnu8O/qhS5cocKQ 6AT0m90xUQoz2S7Q9+4UxCmrXqsuh8HR8EWA+A88BuKyKff/0CeHGdsZjxLZcEitcQ2bSc3z VLPlNTsbRRwtJWFRHTb8a2bxQ5eIgAQJG4GICMBEw0M5oC5pJlp102RCNF+DKSyk9v5Xynqx CyHpzQ/gLNVitMX06K8/hbMhDfESoX1czPZLz7/BgqNhj6Vrqb/D2B0wTA3Ncp9Ebs= IronPort-HdrOrdr: A9a23:0SmS46NZuixqWsBcT7r155DYdb4zR+YMi2TDGXoBLSC9E/bo4/ xG+c5xuyMc5wxwZJheo6H+BEDtexLhHP1OkPss1MmZLWvbUQKTRekJ0WKI+UyCJ8SRzJ856U 9qG5IOduEZZTJB4foTi2ODfOrJD7O8nZyAtKPm6zNIcCkvUqdn6m5Ce3Om+o8dfng2OXL8fq DslfauYlCbCAQqh7+Adx44dtmGncTPiJXlJTYeHnccmXGzpALt0qf+Dx+bmjwDUzZDqI1SjV TtokjC/6C+tPP+7RfZ2wbonvJrseqk8MJHGMuPzu4KLTn24zzYHbhJavm5pTUop+Pq0nYG+e O82CsIDoBI8nbMeWPwmxf3xAX69z4r5xbZuCWlqEqmm9X9WDU5T/VMnphYdByx0TtcgO1B X-Talos-CUID: 9a23:EfXYsm9gMpCVoNSATz2Vv1QeFf04ViLE8HbzeFO3U09HboOFZXbFrQ== X-Talos-MUID: 9a23:iSJOBQY0mwiBSuBTlm6zqnZrEt9R4IOqBlERi68Am5ODHHkl X-IronPort-AV: E=Sophos;i="5.99,243,1677560400"; d="scan'208";a="109990342" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B0U0ilJDWosDcWjLN/xie8ZJzC7K/4HzRPuDd6ViGpiN2hFMsqob9BUPIP5qNRl1Yfz0NhuN5gVNlBnyMXkB8Yh7TISkYZcQQIu2+clV2Xq/0bmcZlGZt6HZFzzT71o4cQhH0/LY8WCwgBYi+AXKF7sGdk3iXRXKTFANP6HeNimrmkmQFfSdkcnnp0b3jE7nu2lVz7HECJvGUXQIgJnegi1IvB/RkuELgZxGBAexSttGK8cEQ57cNVAfQfuJJ8wXiyt4ITnQnjzoRrsiuQjmYdSH74crbYc1y4VXMx/bRiXx3I0XiDJ54/Kvpt3u2DrmmPceMTqKQKSsuzyu7ELv8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DLYLxraJZq+IGvhK6ipB1M7FD/OD6TDsXKINBErQQ+o=; b=PpUcnT3/eM9DD4GHTPL4ILidlRrtk3Am01eCYUuGtdy2ko7DBDLG0lFmMhLGUYv1a+bMBGq+y64Gtu9YJpO8r/DyRuVDlO9oPLlKM+ZpzQuLSzYzOjwgclB/x2f0FguAj67U31caVNWmipJz+lsbTO9wpElesbbq85ReafMmWWMq3iyj+dGSGAbK5gRlgtA5xMFUnV1PGh6FwIWlzxvPcnCQg17XbelIQGJoXCGChLGk45N7MQO498GhJk9CwSmgMwjJlm+n5wqZD7KSPHL3Yn1cvwDIV5S6aGD8S3w3qKgNqu6EURyfRZJv/P0097VMGwm3D0tVXcS7uhu3CaMgMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DLYLxraJZq+IGvhK6ipB1M7FD/OD6TDsXKINBErQQ+o=; b=Ii9WJTut60dHHnfrT60yM5gipP6tkkijMUWqNjda1jKpTNKoS0+uJaVXSrvsmnY9GC+r/iWg+aT0Uwwj5Z3rl3Pn5FOO2nQLy7VIaB8GfupC3zCrsXLAFmmJ5IJABuD02rtar1xwf4fAz9SzSfXlzuvjF2BXVwQURQYnrACHba8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH 1/2] x86/head: check base address alignment Date: Tue, 2 May 2023 11:22:23 +0200 Message-Id: <20230502092224.52265-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230502092224.52265-1-roger.pau@citrix.com> References: <20230502092224.52265-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0229.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:315::18) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|MW4PR03MB6348:EE_ X-MS-Office365-Filtering-Correlation-Id: 1797c685-169a-432c-c6e9-08db4aeec892 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O+4GvYXoQJM46MFGq81QyV6z4VrDr1ddsGQ75IPSBQu1Bp74mpFBxC9VURMw50728U/vejmdkVsK4jBTq83DQf4dHnTtZmUShpg7G7MHebVa3XJGy6RV64GIEFScYBvaIHPa9XKLzTM1KXr5s7ZU8X9MINBGnSGMt/CraK2RdcLY2R11VY+b2tXQOqX0EJ+Yuz78isxGK682E2MHd5iFymjF+uKXjQwCTUjnXH5uoNN82JGGYQCubA69tVdbttiFR/AJDS9z8XorHQabCuJ/W/YCKa6MeK+vQXfCFjkQisRSbggngNy3ySlAj8SCYT9ManB4klZbuqg0gilIMxrYKrpbTQu2enzD6ZEea4ArGGUf6253d4DzytIFny8bJzET2qa/5KnoPsfFRH4AdwT1OjRm54JnbNY1kBAbJPMsZ/Sqz/d5ugCfTezOZ0yEDrBYXSMhP2nXcTf/Eak419MtLdubLX3PCQIojHKERcLvfmpLPfLt+9mHaMBE9oGkPq1c98Yk9/aRMl9SF6nByKMB7IOCIfLEpMbimjqvnI+UKKMgKI3wTD2VeHzCx2M3TU0T X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(376002)(396003)(136003)(366004)(451199021)(83380400001)(26005)(6486002)(6512007)(6506007)(1076003)(6666004)(186003)(86362001)(54906003)(36756003)(478600001)(2616005)(82960400001)(66946007)(316002)(38100700002)(41300700001)(6916009)(66476007)(4326008)(66556008)(8676002)(8936002)(5660300002)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M0RJdldZbktFNDd0QWYxQ1VWNzhpMDJWdzZUWExQWGptbkNiSCt3VlY3MlF3?= =?utf-8?B?OC93endHWnJEYlZ4ejhNdy9ucXdEaDIySmN2c1oyVi9MUjZzNzBjVUtIN3hv?= =?utf-8?B?Y1h4SDh3NUZWV3FMMm9tZ3EzT01FNjUzTDdPY0ZjSHdJcW9GZ1BEbVlnOW12?= =?utf-8?B?L3prUXlNeEo3SHNndVB4MnNUY1VObXJSb1BlQjFUdUw3cXpReS9XcmdRQWNG?= =?utf-8?B?aStvV2p4NVNaN2pnbm9Fd055WTdLeitJdmpFT05NMnU4UkR1bW5PRHRCMVFt?= =?utf-8?B?a0JURVp4VTZ6TjRBWFF2RjdBY0dlbm5tUk43dklIRjVkRi9YZTR3QTVTcit0?= =?utf-8?B?cFlyZmluZGtob0pDNXRlRWw4d09ZaTVQdDNFMmpNN1o4UWx2eCt0SGRQb1NG?= =?utf-8?B?dGo2dTRvZzlmWFBNOEVnLy9XbnJiU0t4ZnU5MVZ3U0QxenVNenJyRmtxcDVk?= =?utf-8?B?c08zcmpFNGRxQ3J4NjROK2lBRk9pVTEzM2pNVWk3UDJGN1RQQlpidGwxWTE5?= =?utf-8?B?RFFMME1oUzVud1JqTjVMeEtQNHNqbHZPVEt1bmU4azRYeWp6OGR2V2E4eWhr?= =?utf-8?B?ZEc3alF1N0Mzb3h4Q0NwTkRKQ2tWYmR3OVpLWVNKbjQ4ZDR4RDZrTU9RL0dx?= =?utf-8?B?MGZITUVIb05mODhVd21qZEdoOEVyWnFJOHNCaTdQRnFDeFl4OFoxZkF2Q3Nw?= =?utf-8?B?RWVuM1Y2TEdZWHd2Zm1XU09QUzMxWFFUSzJuUGgxaE9EY2k1dEFPTWZQRmtq?= =?utf-8?B?Zzl0Sld0SjNLZldxa3dnNzJraDJLK0ZGSGZEYXJ0MmdsOHZEYUVzZGJ5MEVU?= =?utf-8?B?V1ZTanNOQnkrR2FXVlRwSzcydkpScGh3NHpUSlpQcmttUjlxOHNCdXVPL0g0?= =?utf-8?B?eGhCbzNvV3QvUGZKMTFlaVpnaUZIQWtMcUJYa1hENGQ1MmhQcTUzUERJM0NP?= =?utf-8?B?RHMrQXJ2WjJaZnlIbDA3K0I5L2NwME1FYnhTbUVSdkRlSjUrK3FJUGlQOHZ6?= =?utf-8?B?QlBMRzVsNGtuZG0xR3JQb2FlR2V1Q0lMT2Y4c0NrSWxtL29KSUVScjQ4d0VZ?= =?utf-8?B?NkhKYS9FMHlaVGRBNGdrWW9FNkZLOTAzdlJUL3JHNjFCeWZxLzZFRXZWWVFy?= =?utf-8?B?WGo5cVBaN3crNG5FeUI1ZDdlQWxNdW1PSXlnbkI1S3o1RkFxVUplaU1sREVE?= =?utf-8?B?NFNDTHBHNlkyY3FYUFd6bW1xMXBnT01DSkZxVDFab20yN0M2UHB3eEZiNkps?= =?utf-8?B?bXUzSlFlWWZFMUFKcmpMVUJHRU9tc1ZzNEd6a0NodnBCMUpESDNLTkl5ai9J?= =?utf-8?B?cGtqRXJkTG85WjBOTW9rSkZWMmZKdGlGc1NiOHJiMzdMaXI1aXRHNzRYRk4w?= =?utf-8?B?Y0lyaGptWEM5Z0g1Q3E4Nmk5TGVuUDg1NU9ZTTViRVZFZ0djcG85NWp6UXVF?= =?utf-8?B?NjVNbyt4dUViSDIwZnpsdXVkVzJEUTQ4aVdYemF6TC9NQmFEQkpOT3VNVHJx?= =?utf-8?B?aVdlaG9HRjJMYVhzc1gxVGNITWFwc1ltNWl3a2FLZ2tRclpqUE1zZ2lKU1JJ?= =?utf-8?B?RTh6U3NibldHQVpmeU5UV0FTZndYQVVaTGsveXhzVUhmOGNsVEk5YWsrT212?= =?utf-8?B?b2UwQnRWQ2JZME9GOXI3MG1QbXRnUkpiM3c5Yis1ZzVUVFN0RjlWc2VmalBG?= =?utf-8?B?MVpzcXFoZ0hnaHZyM2tvNE1KOG11VlUwSFhXRnhiZEZJZ2Y2R0Y2V25vWHJH?= =?utf-8?B?MGZzZXI5SE1oU2hHS21YZEZ3V1RHQUx2cWpleURpZ2w0RHVQM1Rlb0FZakdP?= =?utf-8?B?cVZDclJGaG9yNDU4M1ZRWWpwbG0zdGMwYW9zaHlEdFhyT1pUaGpUUXd3NW5k?= =?utf-8?B?NUxWa3R3K0N4YXpNYXJiZ3lKdXhHQ1VTTnY4Sk5zR3pKL3pXczRHQ3lPbWFQ?= =?utf-8?B?eWZ1UEk4SVJ3RDlCb2pRU3pzU0lnSk9XMUNZaXVQSnlVWWJOaUtPRjhJSFJB?= =?utf-8?B?RjY2Y09qMjYvU2ZpTmJLblBTQksvdU9vNmRUTWJRQUVKSUFrbm5rSjJ5ampO?= =?utf-8?B?My9JdWI2NERZbS9Wb241bFZ2VmQ2TjUrQ3dlaXdnOEpucXFxcnNEZjJFSDB1?= =?utf-8?Q?qsv+0ijMYTguMPbTnsAmXu5Fw?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: CicFLLOOzW5DBHm2mp76zNtJNAHpJJGRvQsBmCg3mpmMw1EgXrmw0iEc30SB1OGxq/7SGTtLDV8UQp8AZsAMhTx5XNmVecygd4gRmpfk5+/zKAYwS2nsUH6EOHRaZpzo9lbavvclHpa0v92phvYPQQkVkTmKxKc8ZL7B9GQWmZ7Ol5ze3UE+lQjfwEbqbY3UzbHtGm9KspIB7A3jQt6xRFmXENLTaxqr3hadW1KHax0rg5jrb2osCW65Zu3hnbvC045eG2FE1dNrtvQnn967/m5kdenV9/Wg+tKlOrUOutdM5pgPnxFXmb9l0Ob/i+OD7dr5eWTxfoLX2Drem3A2kIfhwhOcS5XlCZzfrY8MdsCFGhKcARs6YYtwqabPvLZyezOz293pGbKHHUYBDcCpKCFlN5Nf3NQXJiZlPnsIFLIHWpyKb9y7yoaP2k48//VOoLg+9NO1hN828Gf4QONO1yTKM8Ozq8L174XXYYQBM+NOZnHWyOyKMjYgGWFzYuPj44ESkkhmpIh0iOgwmt6aONBqvaGyy0lSeKbzjwH91hNLFO+8LB5xsEuYZCNr3PAAFBobsk8JsfnrQcjHtIUF3HWCioTaX7wYhpo6pwJXNqh9HfFBBeduoV9m4eBTpIDaKY+uBspPkcmfiJV1NFS9EJ8SOM/+0QmhfvTJ15zeytNfU62yrnbc4iTCDgY/GtjUoxlm05ixLulQlOzgA3UEUcu+L008NxPsk8FH6iHpakyalQQWShsWAN+MscmlhWncRyQVQdMXmXX+GG2pD9N9gLRLESdYMG//WLYkgBv7TDrYxP5w4HtniPtLFv5J+teT X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1797c685-169a-432c-c6e9-08db4aeec892 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 09:22:43.3618 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9fs8zdPV0c8QrTHn4LxWf/ivDerT69E0d5JZYH65023SADAyWTdXBt6Anf6saefWdvVxgrrzfFuwFl6CWs9Q5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6348 Ensure that the base address is 2M aligned, or else the page table entries created would be corrupt as reserved bits on the PDE end up set. We have found a broken firmware where the loader would end up loading Xen at a non 2M aligned region, and that caused a very difficult to debug triple fault. If the alignment is not as required by the page tables print an error message and stop the boot. The check could be performed earlier, but so far the alignment is required by the page tables, and hence feels more natural that the check lives near to the piece of code that requires it. Note that when booted as an EFI application from the PE entry point the alignment check is already performed by efi_arch_load_addr_check(), and hence there's no need to add another check at the point where page tables get built in efi_arch_memory_setup(). Signed-off-by: Roger Pau Monné --- xen/arch/x86/boot/head.S | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S index 0fb7dd3029f2..ff73c1d274c4 100644 --- a/xen/arch/x86/boot/head.S +++ b/xen/arch/x86/boot/head.S @@ -121,6 +121,7 @@ multiboot2_header: .Lbad_ldr_nst: .asciz "ERR: EFI SystemTable is not provided by bootloader!" .Lbad_ldr_nih: .asciz "ERR: EFI ImageHandle is not provided by bootloader!" .Lbad_efi_msg: .asciz "ERR: EFI IA-32 platforms are not supported!" +.Lbag_alg_msg: .asciz "ERR: Xen must be loaded at a 2Mb boundary!" .section .init.data, "aw", @progbits .align 4 @@ -146,6 +147,9 @@ bad_cpu: not_multiboot: add $sym_offs(.Lbad_ldr_msg),%esi # Error message jmp .Lget_vtb +not_aligned: + add $sym_offs(.Lbag_alg_msg),%esi # Error message + jmp .Lget_vtb .Lmb2_no_st: /* * Here we are on EFI platform. vga_text_buffer was zapped earlier @@ -670,6 +674,11 @@ trampoline_setup: cmp %edi, %eax jb 1b + /* Check that the image base is aligned. */ + lea sym_esi(_start), %eax + and $(1 << L2_PAGETABLE_SHIFT) - 1, %eax + jnz not_aligned + /* Map Xen into the higher mappings using 2M superpages. */ lea _PAGE_PSE + PAGE_HYPERVISOR_RWX + sym_esi(_start), %eax mov $sym_offs(_start), %ecx /* %eax = PTE to write ^ */ -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Tue May 02 09:23:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 09:23:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528393.821474 (Exim 4.92) (envelope-from ) id 1ptmDp-0000jn-7x; Tue, 02 May 2023 09:22:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528393.821474; Tue, 02 May 2023 09:22:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptmDp-0000jg-54; Tue, 02 May 2023 09:22:57 +0000 Received: by outflank-mailman (input) for mailman id 528393; Tue, 02 May 2023 09:22:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptmDn-0000TZ-RB for xen-devel@lists.xenproject.org; Tue, 02 May 2023 09:22:55 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e9e39fd0-e8ca-11ed-8611-37d641c3527e; Tue, 02 May 2023 11:22:53 +0200 (CEST) Received: from mail-dm6nam12lp2177.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2023 05:22:51 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by MW4PR03MB6348.namprd03.prod.outlook.com (2603:10b6:303:11f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Tue, 2 May 2023 09:22:49 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec%3]) with mapi id 15.20.6340.031; Tue, 2 May 2023 09:22:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e9e39fd0-e8ca-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683019374; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=Dq+sSd8VpqgctaVXXnnolVpe/f4WOYP+g9T1j8Xl514=; b=W2nrzB5pAIN47qGqnNLNLnNTSDa9GCsk0UJe8bNHY3J3Pqt8pnNAFo3w cE9hylybGuAuICPVq8YupCwc3A28rt+u7Dsd34VSRQ6iejmKMyua05Gov 2ubR1lL6yBTw9iXvCgoP2ahOn6Wot5sGZjLpZ0l75KfPauYMZlqKvJpi6 Q=; X-IronPort-RemoteIP: 104.47.59.177 X-IronPort-MID: 107567454 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:f7vg4Kx9xmwsU1jbvkF6t+cRxyrEfRIJ4+MujC+fZmUNrF6WrkUCy WQXXTuOO/rbYGr9L4wnO43j8k4DsJWHndZgHVBpqyAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UIHUMja4mtC5QRjPaoT5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KVB8x aY8BAoRVDPd2uW6+ZKAFthvj+12eaEHPKtH0p1h5RfwKK98BLzmHeDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjmVlVMuuFTuGIO9ltiiX8Jak1zev mvb12/4HgsbJJqUzj/tHneE37eQwH2kBN9OfFG+3sRMjWCT7VcYMyYtUUrliteor2iQC90Kf iT4/QJr98De7neDXtT7GhG1vnOAlhodQMZLVf037hmXzajZ6BrfAXILJhZDYtE7sM49RRQxy 0SE2djuAFRHr7m9WX+bsLCOoluP1TM9KGYDYWoISFUD6ty6+oUr1EuQEZBkDbK/icDzFXfo2 TeWoSMihrIVy8kWy6G8+lOBiDWpznTUcjMICszsdjrNxmtEiESNPeRENXCzAS58Ebuk IronPort-HdrOrdr: A9a23:NkiOOa9R0ApEaksDvItuk+FZdb1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQodcdDpAtjifZquz+8O3WBxB8boYOCCggeVxe5ZnOzfKlHbehEWs9QtrZ uIEJIOQuEYb2IK6/oSiTPQe7lP/DDEytHQuQ609QYOcegeUdAF0+4PMHf/LqQZfml7LKt8MK DZyttMpjKmd3hSRN+8HGM5U+/KoMCOvI76YDYdbiRXpDWmvHeN0vrXAhKY1hARX3dk2rE561 XIlAT/++GKr+y78BnBzGXehq4m1+cJi+EzSvBkuPJlagkEuTzYJ7iJnIfy/gzdldvfqWrCVu O85ivIcf4Dr085NVvF3CcFkzOQrArGrUWShGNwyEGT3/AQSF8BerV8rJMcfR3D50U6utZglK pNwmKCrpJSSQjNhSLn+rHzJmdXf2eP0A4feNQo/gtieJpbbKUUoZ0U/UtTHptFFCXm6Jo/GO 0rCM3H/v5ZfV6Tcnic5wBUsZSRd2V2Gg3DTlkJu8ST3TQTlHdlz1EAzMhamnsb7poyR5RN+u yBOKV1k7NFSNMQcMtGda48aNryDnaITQPHMWqUL1iiHKYbO2jVo5qy+7kx7PHCQu188HLzou WybLp1jx9AR6u1M7z+4HRiyGG8fFmA X-Talos-CUID: =?us-ascii?q?9a23=3Arw0tj2uHNhCcCrv4d4cglXzI6IsUQE2H6FvqP3W?= =?us-ascii?q?bVztuRIS1cgOh+6pNxp8=3D?= X-Talos-MUID: =?us-ascii?q?9a23=3AXf9Pbwzglp5q9XzAmyHDDFr2rBCaqJ6IBX0Nuq4?= =?us-ascii?q?NgPK/MT0uEBmMqRKZEoByfw=3D=3D?= X-IronPort-AV: E=Sophos;i="5.99,243,1677560400"; d="scan'208";a="107567454" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fyKmkPZc0R2sVFoAByrKZWef/NHL6WziTmFrL/7Uh6BcznhYMwwhrQwMGpXmHgumSCyeV1K2RB+1AGRO9wP3+tgQ+gqRO0VJV8ZOLwT7kCRakQfA/7VJ3Nw9rvwFdd429o8qj/OPtNQo3QC+x9q07ulQHK9Z/PYUp9s5L7JS4ZTz93HaGrEwGzT9lE9S9VDrEPmJy325IzRjU3KVsM9/5lryUbG6w4X06EWTFtm4+UDVWaOYGmDfkmJHaQL4ic0VUlwDQCyCUmKBcYcGjHXFKeEAPDl53ijinV2ja8VK/kbTFMelrp84IuESTWrHe72dxEY7lnk9IgXna8DjLQd9sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TUjBzIIMR2wZs7nCQYlISDZS3wMRy1R7AX1/v57R7+w=; b=LK2zt9zsprfon7bdwxRH7KUx8gVbcoWguVDkDaotou/nzoySMbLoxJRTCrOI41ZVa/KMF9Q150kke9mdXtxumiWHRy9+l8H3o8wUHf8rWdNQEmFDX3HH7L++91woP9RUzXLb819R0jRP2l2WuAiocN/QFshDDDt9l8FNkh5efaYs5IEXaOzGhqRyj6FbII2VKThJ0SansSxoViX4MJpuEkeowTmothcACIoqlNheh05sJjfKDph9TJLx81YWmrQ6wK2LTKMOdpMAH8qjO4QJWy27kFLD3JtiaT83zJsUpa2pQpU81AMuWzm9ew7tOEzAaJI3WkToioija65aPTSBCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TUjBzIIMR2wZs7nCQYlISDZS3wMRy1R7AX1/v57R7+w=; b=SF469FBt6Wkq80xe8f2qEoH3EkBcPH0ldLrZdEJEvQ3Kita1OzJOMRPaoLNHgIHbPIBi80w+s+D3iivU3fNywPEA+MM1hyQtEbZQea4a8ZDoGU5sCRpwzjZ2D6yi+mSezSx4nyzw26PhD517BBQQaofdCL75jpC3nHEFrDRizic= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH 2/2] x86/trampoline: load the GDT located in the trampoline page Date: Tue, 2 May 2023 11:22:24 +0200 Message-Id: <20230502092224.52265-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230502092224.52265-1-roger.pau@citrix.com> References: <20230502092224.52265-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0101.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2bc::10) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|MW4PR03MB6348:EE_ X-MS-Office365-Filtering-Correlation-Id: e4f46dc4-4c26-4918-231e-08db4aeecc26 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S9TCLLVijCkiVllTEdNlD6+0xUl3mtMSWMstH+dvQ5/6D8E4pH0RWSBvl4zO2kZphsLwgz/VpwNLHDNMg+UL3QXaHs+7cCljCnBPSHEVJpVDvO6ipmJjTAqkQBl6j2pPgO3MMdL5kMhyiFLC/yYtmk1aHKaSJqgES4AnFDMH6VE68M5VtoqNDm9sOmOPQnX5vfDKog6vdmlqc4YCUXJiRjczRzjvq+iOn7/KfrLu3RoOzWjk+G1d7GtHqXD8lxwJKSEUTcEcZ8L3Unwun7/LFc8EAxRHJ+ZXeACcgI6N6UBDWhPq4KenjDfBlY71o9O8lMfiuouoxKX8NnAwjXy69egSC1KJb/fTSyhMIqPtt/O+iQN/dLmo9kRkZRuM5NKj2e1NxX+BH5K7yI//FID+XJE5jYC0hqcQpx+T2hZk4kDCVQVT0G1mLWrwgsuKELiAcPl26+/GZOquW62dQNTSqo6WRysGvRMSgMn/CTW9tLvV3eI3i72zAghMkwoit0O9UZyK8FAFoOgw8NNRh+ARGO4Ei8KZfQDSkeD0IAPt/gKv+iGe4Pgq1Nn8NGZZXOgm X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(376002)(396003)(136003)(366004)(451199021)(26005)(6486002)(6512007)(6506007)(1076003)(6666004)(186003)(86362001)(54906003)(36756003)(478600001)(2616005)(82960400001)(66946007)(316002)(38100700002)(41300700001)(6916009)(66476007)(4326008)(66556008)(8676002)(8936002)(5660300002)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cjN2L3BzNlh2YnNvRERsWS96L3NSLzZaR25haFlpYTBmZXQvSnp0QlFFTVp4?= =?utf-8?B?RUtJZVhaU0dtdkJZZ3Y5VjlVOFlWa2VIQ1JRUEREbVBESWgyd0NDeUF2YklE?= =?utf-8?B?WVc2MGoyM3hjZnV1VS9YZ0pNUjBaOEhhNGxNQTF1VmRhYVRjdVdlZXE4L2VY?= =?utf-8?B?TGIrQWc0RFVGcVNsdE5XdjE0YzhuVUQyZnZ0K2t4akFUV2lYMmJZSkoyc2hX?= =?utf-8?B?VTBlSTAxazgzRExPekVSWXBMR2JJd3Q4NnB1Q1BPSU44eHlENTVla0gzd0NQ?= =?utf-8?B?UTRZeTVXNFhxWTFCQUNLNW54bkdpSkFrUnFvek1NSk4yb2Ztbkp0RXVyRDRX?= =?utf-8?B?SjIvWkozdHZZYkU2VmlRei9ScEtkUkhXc2JFazlVZ3BRVExwWElIU0tqQXZW?= =?utf-8?B?UWM2a1BtditSKzhSR0l3eEswOXhoUWNGUnF3RGt3UVo3S2Rad1Byem5PTUZO?= =?utf-8?B?elk4ZmdzZTNvR2Q1Z3lYTUJSalpBSW5JWEhQSEtUeWxlS0N5R0h0Q0hPcTB2?= =?utf-8?B?UE9Edk1QVVpuZHpwa0poK1c3QmtZeXZGekl1OThJb3VBTWhadmx3ZSs4ZzZW?= =?utf-8?B?bDNTZndlNFQwS200R3NlQ0N0Um9lbFZMaVNVdHpYRkZYM1ExcTVvMjZxM2NI?= =?utf-8?B?SGxsNEJSSmdwV2tSTnpvdWVzV2lpcGw3Rm9yUWcwYlQyOHNTNlhWU1Bpb0Jy?= =?utf-8?B?UkFuWFBMSmQ1RHdpVWxQNDBxdWpCNTQrL1VSNlYweDBZSUJFSFRpSjYrNkZI?= =?utf-8?B?YXJ4M3JkQWV3MVk2ZHlTclZIYTJtMkhYZG9IZExXaWJORmFqcmphV2tjSW1h?= =?utf-8?B?ZnViWW5jRUlLaHNzU1NxT1p1dVhhRWxpYnJLazhCZGNXejc3OWREZk5tYUhW?= =?utf-8?B?QjhwSk1DeXI2ZGJuN2FYVm1CMkdnclp4OW5oclFzaHoyUjB3OVVvd1YwNVJH?= =?utf-8?B?M0xBekFRMlVhb1puR0p2YiszYUFEL1h4RzJwM2hrY3crTGdUc2ZhQ3ZKWlFY?= =?utf-8?B?THBDSUM3RlBERVA5bzcrREtCQlc5MEZucUp6YTRBbXZhSEY3VE9HRWxhemRx?= =?utf-8?B?ZnJmWTRUQ0NEN0xMUnplVDlEUlhCeUQ5UzRpMGwvd1h3TnMvazlBZ254Q0k2?= =?utf-8?B?RHZEVXF2WkpYZXl6NHdHakQ4SFJHcGlKa2E3MzZHVWpNN1QzSDlGRXBpcDR4?= =?utf-8?B?c3VzdzI2UkJRQStEd1pGaFJZR2dtQXRrNktxMzVyTC9OVU5DcWVOSTNiTlVQ?= =?utf-8?B?b1BhaVJqeFd2UWx3N2ZUWEFOT2piWU1mcEc4M1Ewc2JoTlVmK1FQdnR5L1Fi?= =?utf-8?B?NllXYmEvOG1IWVo4SkQ1UGcvc2xjTlZjNXhubllMREJnOGU5U1lYSGp6N2t6?= =?utf-8?B?RkdrT2svend2RUdKcHhFZFhWbE8xQzRhY084bkJNdXRya3NPTHZ2emJ3d3N6?= =?utf-8?B?Z3MyWDRieW1pTHQxRkE4NzNYV0tVamxYanhLdGUrL0lvdkNDMjJrS21kcDBR?= =?utf-8?B?Slk4MEJLdXBmd3JzOXR2OEo2UHZUUkZyemZmRFpnWWtHTCtBL1podjBmUVVC?= =?utf-8?B?ZFhvNTIzazN2Z21JQ0xMR3N5aU1UaDM1THoxWVV0OCtGdVFmQ1lpUkNUMkZk?= =?utf-8?B?NlAxVHVDVjRscFd1YnR0emdpL1JYQkthL2gyNFlOOHZGVWROcGFKSnNxekI1?= =?utf-8?B?MXBpS2lQV0F0cndsRGRvRkpKRFB6R0tyRWZqZTBuWUUyS21peEdmMTZvRHVJ?= =?utf-8?B?Z3c0MFlGZU5JbWR6YTVZbklXWEhpVWNYZUkzUjA4SWwyM3Q0aytPNWFBRk1i?= =?utf-8?B?OTRtYUFKRlNxSnZlMXVYU0VwTWQ5TXhuVWMzNTVXN291WnFvd3pqRFpueXpa?= =?utf-8?B?SE5zWlVCVExwSnJEbzBwcFNlNEd2VlpOSVdQUEZVMUw3TUtoOGtLWTMydjR1?= =?utf-8?B?WVY3UVVjalJYMnNaRjRoc2tMelZXR2EvcDZTeGpyVFNUWTlPbjhlM2pxOXZl?= =?utf-8?B?ZjNaaExrZjQzY2ZOQ04vTkhra1pJUndpZnBMNnFYY2wyZXkvOU53S3VSZEl6?= =?utf-8?B?cnYrUGttWEdnREhjckJsMDRIMkNTaHNhdmt3Vmt6VFhybmExZHIreUxzSUNM?= =?utf-8?Q?qE0+ziXFILmo/VBohgPreWX1Y?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: sXp29qqFBu8mGf2KYSUq1eB+vzHlz6LqIN7qXhYYCy0DJtP+VOhPIV4JIHIQFk+N16KwKBUNkTveJ2Dgg253DStaMhYssDfhso0lYn4qTLXFlaMSSCIg8RXbWN2EL8nqMJk/KIfNwqYmdGBZf6NKlXnA402p/Ur/fEGLFEWnQZgzIqLM0Q2JbJuKEE+kE/4KYzH6wB1X6Kpmi7t9crgII6s+t7nzS/kSOCGOZ1I5bJx9ZXk8DB/OOCA/6YyMwdw1NKH2FTDBRV2VBBxlWRTwHRh30Hv2DRhhy5sNCIn8kGQvX2b+w4x09bMi3H5AtgOkSw8hZjUowgDiHT5kKBGmxzmN6L0yoHEWEMtY/sJVC6I2Q6lxB4eMnWa649ICafOTCz4GYDI6zajvuX2BKFbMy98/Yex08Di5hn9Ynxw39vc2862Cm3SaGVG2emDy37A6HtJ+Vj6fXFviylSdkx7dy64pMCWODO3OIujmZbl7obmZQBdftrg3g+W26/Z8Zuljfal4rNcElY1G2EySQw5WJkCqc4PYcCGSIw8DTx+no/vgCyEKqrTWukU//TLm2Qt5Rqkhz0GEmeisiCRhSol5BlyEQ9RkwbIcdR2F+ZAIwdliyIfKmSfVYLlCu6PdDzf7q2ww0DiLMWbYUe57kn3jF1hdkJkgv21kbXva/jHHeNW2pXxAi8xOBWtS1VhCL/T31rSKKlBDICnjlvmw1gJh6Mg9E1D8RRxaLCTOppP6sHJ/ustLleYwAh0E/doTWplpHpS142qb8XZheHIZCHXPdF6ykBnQ6s965hqIWVF2d4g13tzLQew2/tbDGwRjIqQj X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4f46dc4-4c26-4918-231e-08db4aeecc26 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 09:22:49.3951 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BVd5TpzupTc1IBOwhbA5aeuPRAq+YVbFO/WOxsGynWEFPsjdbVpeag/5LysloKDx0u/z7c33gv5gn3T63Ragkg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6348 When booting the BSP the portion of the code executed from the trampoline page will be using the GDT located in the hypervisor .text.head section rather than the GDT located in the trampoline page. If skip_realmode is not set the GDT located in the trampoline page will be loaded after having executed the BIOS call, otherwise the GDT from .text.head will be used for all the protected mode trampoline code execution. Note that both gdt_boot_descr and gdt_48 contain the same entries, but the former is located inside the hypervisor .text section, while the later lives in the relocated trampoline page. This is not harmful as-is, as both GDTs contain the same entries, but for consistency with the APs switch the BSP trampoline code to also use the GDT on the trampoline page. Signed-off-by: Roger Pau Monné --- xen/arch/x86/boot/trampoline.S | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/xen/arch/x86/boot/trampoline.S b/xen/arch/x86/boot/trampoline.S index cdecf949b410..e4b4b9091d0c 100644 --- a/xen/arch/x86/boot/trampoline.S +++ b/xen/arch/x86/boot/trampoline.S @@ -164,6 +164,12 @@ GLOBAL(trampoline_cpu_started) .code32 trampoline_boot_cpu_entry: + /* + * Load the GDT from the relocated trampoline page rather than the + * hypervisor .text section. + */ + lgdt bootsym_rel(gdt_48, 4) + cmpb $0,bootsym_rel(skip_realmode,5) jnz .Lskip_realmode -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Tue May 02 09:28:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 09:28:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528403.821495 (Exim 4.92) (envelope-from ) id 1ptmId-0002Ge-BC; Tue, 02 May 2023 09:27:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528403.821495; Tue, 02 May 2023 09:27:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptmId-0002GX-8U; Tue, 02 May 2023 09:27:55 +0000 Received: by outflank-mailman (input) for mailman id 528403; Tue, 02 May 2023 09:27:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptmIb-0002GR-Np for xen-devel@lists.xenproject.org; Tue, 02 May 2023 09:27:53 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9b821f0e-e8cb-11ed-b225-6b7b168915f2; Tue, 02 May 2023 11:27:52 +0200 (CEST) Received: from mail-dm3nam02lp2048.outbound.protection.outlook.com (HELO NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.48]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2023 05:27:48 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB6769.namprd03.prod.outlook.com (2603:10b6:510:120::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.22; Tue, 2 May 2023 09:27:46 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb%4]) with mapi id 15.20.6340.031; Tue, 2 May 2023 09:27:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b821f0e-e8cb-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683019671; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=riX/EATnG8fjIwzTkKAbOEAU7FIgdSiaCVyzPoBYrYI=; b=UU2T2QvkPfu/0GNClU7IZXrhXDseTXNPn/Qr0I3MjvORSxlazoczz/HK 77dkZ+1FekrIPPoo1+ZeVYfebR97Dm2oU/gZDJvnTL9nRKgAM2dgGhg3A ltH2OSB9CNQYsp8/fkIREmtMMV2VkOR4sbbCW1jxTcldP+x2apkacdN8j w=; X-IronPort-RemoteIP: 104.47.56.48 X-IronPort-MID: 107956025 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:dvnP2qivJMuHsnZ+3QUtyDLPX161+xEKZh0ujC45NGQN5FlHY01je htvCG7QOKyDZGL9cotzO4njoBhTuseAxoBnSFRlqSxnHi8b9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWj0N8klgZmP6sT4QeEzyB94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQJB2wDMSjbg9m354yqQdFLm8lkCNPSadZ3VnFIlVk1DN4AaLWbGeDmwIQd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEvluS9WDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapLTOLpq6Ay2gD7Kmo7CwMudV/q+OKDhHG+fIldK x0T5jFphP1nnKCsZpynN/Gim1aGtBMBX9tbE8Uh9RqAjKHT5m6xFmUCCzJMdtEinMs3XiAxk E+EmcvzAj5iu6HTTmiSnp+WsDezNC49PWIEIygeQmMt+ML/qYs+ihbOSNdLE6OviNDxXzbqz FiisywWl7gVy8kR2M2T8UjchjOwprDAVgMv+hjMRWWh8x94Y4i+IYev7DDz5PJNLo+fQkOG+ mYNn8yT7ucmBpWKiSDLS+IIdJmr7vCJKizBgnZgGpAg83Km/HvLQGxLyDR3JUMsPsNffzbsO BXXoVkJuM8VO2a2Z6hqZY73E94t0aXrCdXiULbTc8ZKZZ9yMgSA+UmCeHKt4owkq2B0+YlXB HtRWZ/E4aoyYUi/8AeLeg== IronPort-HdrOrdr: A9a23:QkKfhqg/PDQayhHe/l/tuaPn2nBQX1B13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQJVoMkmsjqKdgLNhdYtKOTOLhILGFvAH0WKP+Vzd8mjFh5dgPM RbAuND4b/LfD9HZK/BiWHWferIguP3lpxA7t2urEuFODsaDp2ImD0JaDpzfHcXeCB2Qb4CUL aM7MtOoDStPV4NaN6gO3UDV+/f4/XWiZPPe3c9dlMawTjLqQntxK/xEhCe0BtbeShI260e/W /MlBG8zrm/ssu81gTX2wbonthrcZrau5R+7f63+4kowwbX+0aVjUNaKv6/VQUO0a+SAZAR4Z vxSlkbToFOAjjqDxuISFPWqnTdOXAVmjXfIBaj8ATeScCVfkNHN+NRwY1eaRfX8EwmoZV117 9KxXuQs95NAQrHhzmV3am+a/hGrDvAnZMZq59ms1VPFY8FLLNBp40W+01YVJ8GASLh8YgiVO 1jFtvV6vpaeU6TKymxhBgn/PW8GnAoWhuWSEkLvcKYlzBQgXBi1kMdgMgShG0J+p4xQ4RNo+ 7ELqNrnrdTSdJ+V9MKOM4RBc+sTmDdSxPFN2yfZVzhCaEcInrI74X65b0kjdvaCqDgDKFC66 gpfGkoxVLaIXied/Fm9Kc7gyzwfA== X-Talos-CUID: 9a23:QJuI6W1UvQq8eHKVaLElNLxfC+95fCLllHPrImiGGG1Rb6CYDnuKwfYx X-Talos-MUID: 9a23:tR1l1gjU39DPLBthcqksAMMpN9lQw6D/UVs3n6oGnJKGNX13JyzapWHi X-IronPort-AV: E=Sophos;i="5.99,243,1677560400"; d="scan'208";a="107956025" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q3fd5wyjhZpZtnTaw8zyv1w9IYxEXpbBA1F7qVmT2VphG69kl2ZpcbcQ2IHV9K1RFeuUltrDBDxA6QXzVqzbk3ekKekrP3zvY/x2ipVWfMwL7IZCL7i7LJ/lXkfH8dwLEMXgtvUNzCTa0nF36NLMIdosFbLmps0GuD6qD0C4Wxi8qdGvh7LF+vitvPR3SSRvrV8pu3pR3zOVUJvTBl56rFbTRRcrCBfjC70OclCOadziPTmD1Yy2py2cpdANllhhOhNzFXdnzQ4m9QcdglyHyk4vwLaCilqFpcoDJBRD0LBwfrDlIkOXWIh5ih0u36Zm59zPsERfS/rqyyOkU/ysuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=riX/EATnG8fjIwzTkKAbOEAU7FIgdSiaCVyzPoBYrYI=; b=bpDd6HgEGwVkXT09d0zvxUYmMktK/s48ccWi9cFQenZyaNk9421fOLdpxwKVnWxixA7jAHD4N47IlbWI4GLjAwsOFWQnXlpQwEXATy31UC93iJHOtljrYTSxbw3OErhsMZxr0mWGE9LOrRSzdEofHk68oM4/2gOUriT/BKdwszNqTq3Lc1PaW2R7w34ytMlZPh/yk8Co4OwWal4FJdbT01gTrA1dgiet6UUsH1SwDk22+WhxGLCMJjrMuXdNCzJ3Ripx5ozdmnkRq9pFLlWfDxo6hYPeC7+ooYc8N334c/P5tRocmpnQwbIN9Az4fdRY432RSBX7jAA3Pxxj+2WirQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=riX/EATnG8fjIwzTkKAbOEAU7FIgdSiaCVyzPoBYrYI=; b=iyJllSRnSb6hIKtZLYS9/0lRcIiAsdp+T9FUKvatub9VUBBir4C6laYQTNk+X47WvvJ23L/qRRtT+BilddDTkiHkXB/qpFyaEqWMunM0pYYxWXq5ebxFSK8RPSoZU+yXLMl7TaQkBHLxMzAGgdIvzMrSqbjS4qNmYEgeJ/cDHOc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Tue, 2 May 2023 10:27:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: Andrew Cooper Subject: Re: [PATCH] sysctl: XSM hook should not cause XEN_SYSCTL_getdomaininfolist to (appear to) fail Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Daniel Smith , Alejandro Vallejo , Jason Andryuk References: <26064a5a-423d-ded5-745e-61abb0fa601c@suse.com> In-Reply-To: <26064a5a-423d-ded5-745e-61abb0fa601c@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0186.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a4::11) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|PH0PR03MB6769:EE_ X-MS-Office365-Filtering-Correlation-Id: 8a625af4-d1f2-400f-3203-08db4aef7cfb X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PQ+fdx9BLui81JXByME9Hcxz3ybzz5ksKeT8Y3G9GiSvZPSCQYl0QO399qgu2L70dMB2TYXS9+crtzfxYUPSaDqMlHuiuNbeOjQAApEg7xSZ0s1LaecyP9gzax03TYqYM2xV97EdusCyEi0qEnY8Gx2sBh4nH5KnCzb3+uJeinJz7CThOpNRK4mOi/6UtROXNe81qL5SBQ/NsydIdCHccQ6wmZB7fCdBVUT2x4Hg9QUNG8wIm6+1wYgONHg0AjCI8vswl1/+calxlIq8UgmScygJKkjES4C1LbK6Ngf+gH8TmzgV8GZNsVwsE475HH0UjlEvmdISFpmNUf59qbYpwlXVP0dnRFNJ7dXgYOvHTbtK1msCvDIGCF97JrW9x9Cf6XqU2sHI+Zq7BSJE1ObS/gOcVC/eYTIXokcRyxS95cxpEWDCoweZ/VjgWt8YFUt++CyyExBKRjZk1zXDNIYrKaOVp0vIpyQGjQJZ3OtN7QBMihqKrKl0F/UEIVGZ/yWe8+pN7WEMo5vhpzh2hxUYUZt+f0sC+Oi/Fmr3Lg6vZes5JG8T+eDmCubvw6/wNmOClPgmCvavaqZ3nr1QPjBTMkOQl5lusf6qsZ9spnv5B0JmhWlkWj8hmPIRVBiLK/kFmpPn9hgNQc/bKWnP4cZ3fQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(376002)(136003)(39860400002)(396003)(366004)(451199021)(38100700002)(82960400001)(2906002)(83380400001)(31696002)(2616005)(86362001)(26005)(4744005)(6512007)(6506007)(186003)(53546011)(6486002)(31686004)(6666004)(66556008)(66476007)(36756003)(110136005)(478600001)(66946007)(5660300002)(41300700001)(54906003)(316002)(4326008)(8676002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QnhLclJwcFozc0IrTHEyZElDUzMreXlsVVFoQWt1ZVh5a2lKQnFhcXNxcXlK?= =?utf-8?B?NkFobHFIVlBJc25pT2IwRzd6d28rbE5zZGNad2F4UEdDS1VadmRGWDcxc096?= =?utf-8?B?SWRDVjAvS3JlaUwwMnAxNmlZNVliSlpRUytrbjVWREZaamhCenlNbFpoVXY1?= =?utf-8?B?cU9XOVJXVDh2dkVVRzRyY3ZPdDlyZ2dvUlZLb2JaVU00M2NjMXd1UTZ4RmpZ?= =?utf-8?B?NHk5WFJZM3NjOW05NjJySmlmd3NjS1ZnQzhnL05BWU1vNGJId0VkT3Uwb3RD?= =?utf-8?B?UllhNHJDbHFEbnBDaW1NVjhMcmV1RTR6TENBZ1FiOGVDTEltWUtoQ0luM1Zw?= =?utf-8?B?ZHFON1pvbGtVTVd3dTFXT05SbjRianZtSzBNbDA2ZXpqdzBSbC8wblVSblln?= =?utf-8?B?QWxHY3VTclZqQTR5S21VelZEeUVPeFI5RXdZU3I1NE80RUdIMXk4TUphWVBK?= =?utf-8?B?NGNBQTdIM3liQjlsTDFSblkzWm83eEJPNitISmU1RkdhMTh6MWw2bVVKSHpB?= =?utf-8?B?RklHZEtubW9PQXAvTDBUUndJb1FPeG5yUHdtV0x3MEp0VlRabXovVTFyNCtI?= =?utf-8?B?MzE5bWJodDZwLzdUZk9JSFV5SDNRbDh5OENFNHJVYm5QSGZmb2JreXVMeTdY?= =?utf-8?B?ZkI3MXJsL0lDK25NRzJKVlNWYUJveFo0dVRaMlh5TlcxRE9NUDF0OGZ5Qnhn?= =?utf-8?B?VHdob09XUXdFbmNpM09TOXlvVDdFdXlhd216NnNnTVEwMjFEYnBpV1dxVTFz?= =?utf-8?B?VXVocDVuSU1BVm5rUHFkYVNNbnJrLzFENmljZTIxSGh4YWRldVd3YU5yZXg4?= =?utf-8?B?YW8rbkJNOUVETzYvRlN5aE1SdTV0UU1yZkN4TDRzR010RXpiTkQ4M2pwQ0s1?= =?utf-8?B?Qk1ialVNV3BKaGlSUjVjajI0YXorNlVLWmVoZlJFL25JdzVQbWN6aHdnQ1Vw?= =?utf-8?B?VldqU1lDTmJMbHpSczBoNFRPRWxtWmZRTDlOdHFLbXA5dkl1VUg0MzEveXVh?= =?utf-8?B?cTFoMGJBZEd2VnNCbHovZEU1cHM2ejVTZlI3YlV5a3FjOURTMmkwRWV4dnJI?= =?utf-8?B?d0lBbnhWMTN0OHZ3T2tKNjF5V0l0ZzJrTit4bVFOV2MxY29VTmlmd2Q1NVBN?= =?utf-8?B?NjgybnZBN0NkVkh2LzFDWFE0eHFhM2VzQ0xXdk95STlPSk9xRjFnZVN2bEZh?= =?utf-8?B?U3p4Vk9CRUN6blYvckdGTUNVRWM1YTRnbEVnNDJKSFYyZUZaamdLOU9ndWxy?= =?utf-8?B?RWpSMHROTlcxUlZnQWJGWUJXdC9hL2RYbnJIdCtIanM0STg2U04xQVhjb0tv?= =?utf-8?B?dkRiWXdaUzNtckN2OFg0SitMNDZYbXB5NVgrekoxQXJISEQ3TWF4U1lwOHFK?= =?utf-8?B?ZFNWWUdWaDY4MVJ0NXFVYWdVdEQzVzdOMS9rY216NFl5U1NMckozTHRIdjVF?= =?utf-8?B?NGZmTWh2TkxMUUlSNjR2YTVzNldxMVNzL3ZYajJRc1FVMEVZaGt4UlphTSt1?= =?utf-8?B?cVFQYkRaZlJBSTBYVGtqeFc1dWJxcVl5YmNNaStlcGF1bUFvWlBrcGJyclJq?= =?utf-8?B?eUZhbHBXcHRjczdPazM2U2ZGd09KdmdDakFDbGF0OGZUaEw1R2JCZ1UyeXlm?= =?utf-8?B?NlNMSkdEakpyNTh6aWlnQVdETFRIOXUxM0pMdWd2Sy9kb01lOUJSMmRFSGdz?= =?utf-8?B?NDROcWE5VTlrU040UkgvbHhySjZkRHJkMzIzN2gyVW91bytZUWFtb3VQVlJt?= =?utf-8?B?ZEduT1I3VjMrQzZXS1pNWVgyZ0EwaDNtSEVSNFNzMVlSVkZCWE5oZ1ZtRmEr?= =?utf-8?B?S25jU3RlZEttZkYyQmo5VUlYN29sSnYyZ096MUp6cVpLTnJYTVBZbFNmQzRF?= =?utf-8?B?YnBDMWF0MVczRDFkdjVjT0tWcDRwcndlZGFMVkdMNnpLVTJpQ09ibDUyZkQx?= =?utf-8?B?cllJWGNOWkpDUGs5WWQ5RXBVNk5qWmowV3A5b25OSTYzK2l2d1huQy9QbndM?= =?utf-8?B?dWMrbmNuVFovbHlaMUFDejVnZ1lTNHVUSkVZYVZlV0N5OWVDV2FSN2pCbldj?= =?utf-8?B?MlRaV3d3aTMzakxjQXB3OVZLV212UVZjWWhMOUpqdjBqaGJZdkF4enlNc3JK?= =?utf-8?B?TWt1VFFibG1IZkRHa3ZOREl5U1JSc3JyMlZ5SGVkd3ZNSzNjcEdyNmp1WE1r?= =?utf-8?B?T2c9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?ZlBvSTIwWjlpc2JhM0JxR08yVjMwS21WS29JZjZhMUJPYWd0eURMZnhPK0Fw?= =?utf-8?B?aGgvY21HaG56bjRJS21uSktzNkpEM2VIYTBOekpBUFZHMkpGWW96QWtGSUpF?= =?utf-8?B?cnB3TVAvZWpleFFWMDQyRnU2V2t1eHdaSHZDUm15Mmh2Q250WThlaUdHUExa?= =?utf-8?B?ZkNDNGZ5VnlJRUw5Tlk1ZFNGUGlucDQ5MjA2WWhYS3NFRk82OFFkZDYrNW5s?= =?utf-8?B?azVDWFVXdXZvR1FVK3U1UUNKeDRFN1ZvYmdERzg2QWxON2MraE1RNTJkQkpk?= =?utf-8?B?MkUyaHA1OFQ0UkdvemdoaUFtSERaeU9MejVvU1BCK0hwQk4xOWlPNGk2Y3RF?= =?utf-8?B?VncwRVlLbGtmMkpscURVendrdFFub3JFZEl3NC9RT01NZ1g5SWh5MDVwTVhy?= =?utf-8?B?bDl3OTR5ZXY2RWRwNXhPeFE1K09SZ0hNV2pLa2dITktiNmJiUmxVUzR3dUJB?= =?utf-8?B?TEZyMEo0bFhpSVBrODFxQVplM056Z3IxQjNmdk16T1lZV1ZTUmtGUmY3OXJn?= =?utf-8?B?ekNsVzZsKzFmUENhM0ppVVN4VzFsSWJtbVZLbVFlMnNzZDNuUFpLWXVXUlRy?= =?utf-8?B?bVJlbHdWaHp4NnVONExHMHAxT1Q4NGlaeFpoa29wWlRCd3VDSlZueWNaYTZF?= =?utf-8?B?NVpnckkyb1lkdXp3ZnVqdWtza1VPdDE0TGh6WFJGWENwUDUzRGZVdk9GUFBy?= =?utf-8?B?eEtqbmNPd0xoVFpPcjFkUGF1TE9rZzN5UXRqVXhLTnU2UEhjQUtWanZpSjRG?= =?utf-8?B?TGY2THNMMWg0bEo2dExCak1wMEFzbjlYdGNzZXB4N2VINFRuVWcrM1AyRFlC?= =?utf-8?B?S0hsUHdBTmxob2JsT2c4dGZNWG4rRG44MVV3SXgrUkV2NnBmUGpYYnQ4TlpC?= =?utf-8?B?cit2bFJEUkU1VGpia2tQbnRTQTh3NzV2UGpqZ3lic0xBQjZ5Y0svbzhidEht?= =?utf-8?B?ZzBNendhUGUxMjl4b2w4NGtER3M5RG95Q040R2dCNGtDQzNFU3llYkJyTlBx?= =?utf-8?B?TEpFUzhsSzJRUXp1djhVbXVrVWhrSzhVRHMxZThGd2F0MGdkYXN6QTRyYVkr?= =?utf-8?B?TkVTb0poQldzQkVnV0J2SUtFMi9Ta3FMUzZQWTFCTmNvUUNycDZ1VjRGVzh2?= =?utf-8?B?N0VRYUdCQWhnVmNiZ3pWc3pTcWhHVDk4VnBEV0RPQXBNRXQ5OGdjK2JHbElr?= =?utf-8?B?TmtsMnJPcGZ0NUtqZXMvTWoxRXgrUEFXNVgrd3BCbjJIc09JUnZ0VDZTRHgx?= =?utf-8?B?NEE2bk5XRFhyWEdnbld1RlgvQngyanUraHNqT05sUUYzNS9lQT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a625af4-d1f2-400f-3203-08db4aef7cfb X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 09:27:46.0614 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IljGmG+AiW9XRvjX5Iq6TUmJ5AbtW4DokiYURa+DBPB1+e/ei4Pw9g4ClcdeyZQzpwmDEHXMgqcJcQmRxhlwJYbsjzS2Rpm3vdCKe8cWw5s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6769 On 02/05/2023 8:17 am, Jan Beulich wrote: > The hook being able to deny access to data for certain domains means > that no caller can assume to have a system-wide picture when holding the > results. > > Wouldn't it make sense to permit the function to merely "count" domains? > While racy in general (including in its present, "normal" mode of > operation), within a tool stack this could be used as long as creation > of new domains is suppressed between obtaining the count and then using > it. This would not be the first example of the XSM hooks being tantamount to useless.  I doubt it will be the last either. With the rest of Alejandro's series in place, all requests for a single domid's worth of info use the domctl, and all requests for all domains use the systctl. As a result, we can retrofit some sanity and change the meaning of the XSM hook here for the sysctl, to mean "can see a systemwide view" (or not).  This moves the check out of the loop, and fixes the behaviour. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue May 02 09:34:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 09:34:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528406.821505 (Exim 4.92) (envelope-from ) id 1ptmOj-0003jp-0l; Tue, 02 May 2023 09:34:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528406.821505; Tue, 02 May 2023 09:34:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptmOi-0003ji-Ta; Tue, 02 May 2023 09:34:12 +0000 Received: by outflank-mailman (input) for mailman id 528406; Tue, 02 May 2023 09:34:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptmOh-0003jc-0u for xen-devel@lists.xenproject.org; Tue, 02 May 2023 09:34:11 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7b9d8f3a-e8cc-11ed-8611-37d641c3527e; Tue, 02 May 2023 11:34:08 +0200 (CEST) Received: from mail-bn7nam10lp2107.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.107]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2023 05:33:51 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by SJ0PR03MB6699.namprd03.prod.outlook.com (2603:10b6:a03:402::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.22; Tue, 2 May 2023 09:33:49 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec%3]) with mapi id 15.20.6340.031; Tue, 2 May 2023 09:33:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7b9d8f3a-e8cc-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683020048; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=5zgyUxEJbKeos8eY1I65h8nPBR26M0j8HASaCCtmj70=; b=AZuZ+YpcTh9NN5CyPoHbAVLTYxhGwg7OBZnh8WiREthyII0ubqjg695c x61AEckVECsyAJmvKHNg8ZGLoPxh64KUQ3BctumkpPM/SCWUP6RIC7EwY u4ASybAJ098C4C9GbFSmtz81BxAGYBOdoVTUSMLZYdNnIilY/OFtPsKZc o=; X-IronPort-RemoteIP: 104.47.70.107 X-IronPort-MID: 106876281 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:NFR6KKtMPNC8Jxl52KHjje4gwOfnVMhfMUV32f8akzHdYApBsoF/q tZmKW7UPPyNYmSgfdsga42//RsC6pXXyd9hTANprnpjFywV+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj6Vv0gnRkPaoQ5AKGzSFMZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwIhENQgC6ltCMwbu6ZvFDvPYqM+/AM9ZK0p1g5Wmx4fcOZ7nmGv2Pz/kHmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0ouiP60aIW9lt+iHK25mm6Co W3L5SLhCwwyP92D0zuVtHmrg4cjmAuiANxCS+PipqcCbFu7gW85LhBOan6AjPSHkGjuWPYHL WIZw397xUQ13AnxJjXnZDW6qnOZuh8XW/JLDvY3rgqKz8L88wufQ2QJUDNFQNgnr9MtAywn0 EeTmNHkDiApt6eaIVqf67OVoDWaKSUTa2gYakcsVhAZ6tPupIUyiBPnTdt5FqOxyNrvFlnY3 DSivCU4wbIJgqYj272g+FHbgxqlvpXTUhMu/QLTQ36k6QViIoWiYuSA4FzW7/9GIJyeCEeIu HwJmc+25+QJEJ3LnyuIKM0PFbel/eeYMxXThFduG98q8DHFxpK4VYVZ4TU7LkE2NM8BIGfte BWK4VwX44JPNny3a6Mxe5i2F8kh0annE5LiS+zQad1NJJN2cWdr4R1TWKJZ5Ei1+GBErE31E czFGSpwJR720Zha8Qc= IronPort-HdrOrdr: A9a23:2dq8gqnZ5yTu4rDB8A7xG4tKd27pDfNLiWdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0mskKKdxbNhRYtKOzOWw1dATbsSlLcKpgeNJ8SQzI5gPM tbAstD4ZjLfCJHZKXBkXaF+rQbsb66GcmT7I+xrkuFDzsaDZ2Ihz0JdjpzeXcGIDWua6BJdq Z1saF81kedkDksH42G7j5vZZmxm/T70LbdJTIWDR8u7weDyRuu9b7BChCdmjsOTj9Vxr8m0G 7d1yj0/L+qvf2XwgLVkza71eUapPLRjv94QOCcgMkcLTvhzi6ueYRaQrWH+Bwlve21714usd /U5zMtJd565X/9dny85THtxw7j+jAz7GKK8y7TvVLT5ejCAB4qActIgoxUNjPf9kobpdl5lI ZGxXiQuZZ7BQ7J2H2V3amCazha0m6P5VYym+8aiHJSFaMYdb9qtIQauGdYCo0JEi7W4J0uVM NuEMbfzvBLdk7yVQGQgkBfhPiXGlgjFBaPRUYP/uSTzjhthXh8i3AVwcQO901wgK4Vet1h3a DpI65onLZBQos9dqRmHtoMRsOxFyjkXQ/MGHj6GyWnKIg3f1b277Ln6rQ84++nPLYSyoEppZ jHWFRE8UYvZkPVD9GU1pEjyGGCfIyEZ0Wv9ihi3ek6hlWlL4CbdBFrCWpe3PdIms9vQvEyAJ 2ISdZr6/yKFxqaJW8G5Xy4Z3BoEwhvbCQkgKdEZ7uwmLO7FmTLjJ2tTB+BHsuaLR8UHkXCP1 AkYB/fYO1902HDYA6LvPGWYQKgRnDC X-Talos-CUID: =?us-ascii?q?9a23=3ALt1GG2lER5FR9/1sUbCYvYG/ZyLXOXf8zFvAGl6?= =?us-ascii?q?KM2dgSZGNZmWi8bxCuMU7zg=3D=3D?= X-Talos-MUID: =?us-ascii?q?9a23=3AUseKYA7vvXeEuzPpWbDaxIQixowv4I6IBRgytK4?= =?us-ascii?q?rtveeE3xzH2+bojmOF9o=3D?= X-IronPort-AV: E=Sophos;i="5.99,243,1677560400"; d="scan'208";a="106876281" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BKsJ/lwyG/cnje+UkX+EaqMpAqUk47BzH7r0qc+CaPRmUnoQkJcowC/jxLG7R41dUHkpjvIAwfrFaskj06niaZgXgAlHwAR0h+zN4sC2VWFKhlc0COIMEUpuZMYZfcdGZem56ze7m5mwWNeMqESmVLN0mzZt/uDD1vT8jDb+OhgFAgYO/46+WVoWti7P4sOB/og93cyngNrS1cI8ZmXDzXZDtQ2ivmZKCQW2ugKeYSlFi1xpqp+72Z8Jjws+sfU0AujIPyRo7cUCNttgKR6oKKgwky0FobzU3ldq8BzLkQJ0dXgo4nJFe15bX02hq+sqyeb4uhgRveu+A5oLYghJ/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YUuP+RCufEMSUbnrdI5OJ9jcsu8ig30o9+L3OWAOM7A=; b=YSPvJzlE0s+Fl8UQ3xg+wo+p6/0lmcovkxuEPwGW9UGY/6GZ0YfWraoASzSiW72sEOZcTyBdLZbslrclDMcikp56P3tNvVT+1IjE8wkWE9S88UILh5pY/lsDf7y+t4y/zZegSIqrSHaETM8sgctOvzJeWQoRq7ObD0Cte1HzvSjFrAz+l9tiAuB+Ba0WPDx1HFBm3ybMQtTcYmeTjPU4SgWCQ/VZd+ELeQP4Nb77js7822CwC+cFFHr1UE9ZNvAkMQxPR6lOx/Qu3yP19lOG3BWtL+EyD4Ebo1eOvMZjuLjH2xEZaY0tMSBRgm3UDCG4Qr6xNz7WAtydYKkALOLrcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YUuP+RCufEMSUbnrdI5OJ9jcsu8ig30o9+L3OWAOM7A=; b=JcGOBb1p1ufJ1DKTVJKYEgieJUCt85GzN+rW8GnpB30cHzv7beviAej0GP+FADneESLRAgBOtsp9dtQIeUx2oreV2h5N6GjHe2aOctJsq1V4pUeifg/I/KDr+ZuNslmuo7M2lgG120TSWa7ceK2E/3JwbgQiZ9YEPfpbTYc0oKY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 2 May 2023 11:33:43 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: Jan Beulich , "xen-devel@lists.xenproject.org" , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Daniel Smith , Alejandro Vallejo , Jason Andryuk Subject: Re: [PATCH] sysctl: XSM hook should not cause XEN_SYSCTL_getdomaininfolist to (appear to) fail Message-ID: References: <26064a5a-423d-ded5-745e-61abb0fa601c@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0544.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:319::9) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|SJ0PR03MB6699:EE_ X-MS-Office365-Filtering-Correlation-Id: c4fd9326-0936-44c2-3e11-08db4af0556e X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: k3oP4ioLuhF2xjUm0z2TpuchLI80y3ZAxw84I6USw5c6SDmIj60TuuwnhbloG9u5QC/Hk2YtUZj7LZf+1Hek7AEeE0JafMW56JN3PI8HYbmyyh6efQDMGtoLtncals79k54G2aDCAnBkk9zVCvY5UEB65j6PA4K6AYWLcQv50eQh13wq2HIn4FMmGsI5KKCG6UHZePYD/tYcGTXp2K402g+1Q0pHrk6lq6zfU2WbSSmFtsVckeBZ17h+wdVJ+TKa2AAIsBEpbfBtgdHJMbYzw3nHBy9+gmspxDShoMn5j06ZnuniCm++GgpIO4lq3W2z/ta8XK/OHPH+oj7nizcIDMIfgpjAQQvoDxynYXABwP7w9G1itWn+29mDF0fsw9MuS57caH5TDHaGeHm0XHEZhFZ87sO2TRic0JrWN46WV7fu4w27CQb96MD9g29KLDiPASRW8AT4bQ2hazDxBDTVTkM5Ms6tUW0XAKnRkw2OmZ08bHnTZAOau1hGrMATsKWQ2JXkVNBcdefIrxfUaPyXitv2kaGBs4L+QUdSujueB/rZuVXXdiUzKV0uwI9wt5sg X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(7916004)(346002)(39860400002)(136003)(366004)(376002)(396003)(451199021)(66476007)(316002)(66556008)(41300700001)(66946007)(8936002)(7416002)(8676002)(5660300002)(6862004)(4326008)(86362001)(33716001)(2906002)(85182001)(6512007)(186003)(478600001)(38100700002)(53546011)(9686003)(6506007)(26005)(6486002)(6666004)(54906003)(82960400001)(6636002)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ODFmUGg1c2VzNnBIZHVHYTFsRno1VjFRRW1HenFjSjltd1hWR0hOamVnYnlt?= =?utf-8?B?eW5MZHFqcGsvVWQyRThlVDRkSGx0NTNtazJOZGhZUXNRSVB6VzYvdHBqLzNE?= =?utf-8?B?QkFzYWVmaitRNDVtNjFsZHUyRW1Dd29kSHFBSjlaUmhRSHhFM0VxNHlIRllL?= =?utf-8?B?NTBWblJ6NUMwd3Z0VFdCcmwvNFNrbUNjWWpUYzAwbGZzNExYaDVKOGpud2Er?= =?utf-8?B?OEpTbFJBRVRidXEwdCswaWxyMm1oMTl0NkdMdU5IcWZ2aWhMM3JrdjZWZ2Ji?= =?utf-8?B?R3RPUUU4bXFXa0F2UTBoM2lnU1dYV05ob1BjcExKY0lMVWltY2wyOTkwd2Zp?= =?utf-8?B?bzE3allCZlNKeUNDYUN3cERJbWZWTEdvMXFWWVZjOGNnVzB0QmdKU2RGSXRL?= =?utf-8?B?a3B4TFh4UnZMaUU3RDRqLzBYL2twcTQyNmxKemFBVHkza2NIejhLb09NYmgz?= =?utf-8?B?N0ZmRkZaT2tQSTZWMHFFSHg1TjJuMk1yTzllc1FGd1JKV3N0VStBeGhIVHhp?= =?utf-8?B?ajVpN2ZDZ1E5YjEva09rU1lOQmxoMnJSZ2lPUHJXZXNPOENjL1dScWNRWEVK?= =?utf-8?B?QnU4QTYxMDViL3ZNR2J1b2VFNmQ3cmZHdW1WWFk2OS9LOG5zSEZFYjg0VmtZ?= =?utf-8?B?bDNZQitOK3VpZmdjakFzN0o1TGpCM0xnVFZNbDN1Q3g3QlFyRmh3UUZncDRG?= =?utf-8?B?TkVXSGdmRFhvVE9Jak1McVFKNTI5N2xOUFlkQWpuNDFXTE1xOVVEbXE1NDE2?= =?utf-8?B?V1U0blY5aUVMQjRCeWFjOTk4UlhNZkEySE9lM2REVktjd1Mzbnp3RjVjUHNH?= =?utf-8?B?SXZOOUZMb2pldFZ0OHNCMTJPbE5kRmJ5azg1dThHdElCaVpJT3M0UFE3eEJL?= =?utf-8?B?aVNOaGhHbnkyUURabm9RMTVBRzEza1h2bS9aU2p4YmgweXFidWg0MWZhb2ZX?= =?utf-8?B?cjBDcUZKdEZHVmZES3dEOC9oVkJaaXl4WjF4L0g0KzByUVM5eFhCbGxtYnVH?= =?utf-8?B?QVRMdU52Q2FQQmJFNGc5ckN2T1pvVnh6QWZZRkZTdnpaUkYrYlV0aFhiTW95?= =?utf-8?B?aWNmb29pR2xGdDc1MU1ydTdSUk5iRVVlZjBoTzh3bUJWOVhTcS9tVjc1c0c3?= =?utf-8?B?L1VIbTFlRGRhYUJPK1owR3pQajR5aGtwWTduODU2bzRhd2VDNnI5bmE1WnVp?= =?utf-8?B?ckZoa2xUREszL1Y1WFpIeUlzdzRleHpxTDR0ZHdBOCtqcWM2eUVMMzUwZysz?= =?utf-8?B?UDlLYlFub3JJd1Z3Tk9QUVZ3d005ZmpaNk5NRHU4UlJuTzhIanZTUjJDNWdF?= =?utf-8?B?R1lEamEzT0RlbnV4U2pZSnpDNXVqbEJiZ0tra0x2YUJMMWNOb3Y4dkRjQ2pU?= =?utf-8?B?UGNQQ21TdlJicVgzaTI0NEJTNkZqdjdRVHAvMkIwbmNBYnN3RENabTBPZk8w?= =?utf-8?B?citzNHhzK1l6N1FqaXVMeHVLNGMrTGNmN3pLZDRrZWozZlBFbFIxWFp4NGl6?= =?utf-8?B?Y0k5cFc3eC9Nekd6TWlZUmc4aUhPQ05MY0hZS0dla1VxQytKc0ZyS3BJLy94?= =?utf-8?B?WGdNR0lDUWxza3ZOVUZhQ1BxV1d5aEc1YWRIWlNwWVBrcC85a3BZbzhjTzJX?= =?utf-8?B?aU5iaW5aUTNwdktyQ3BKQTYzV2JUdlk2eUxNV3A2Zzh4bm96Z2VtUTRxUEdH?= =?utf-8?B?anNmMks4SVZGSlB4ajN4YTJXUUVKMks2Wjl1WGZBZ0c4di9pcnZpWFhZb21L?= =?utf-8?B?dCtiL05iM3V0eGlmaTB4UWJjU25vWEE2bG9yeE80Ylp4d0hzVW41bFpTY1hR?= =?utf-8?B?OElKYVRJV0hDaytZVEsvN040bDM5VnE5VUl2ZENZOStBb09BbExDL2VVU3hW?= =?utf-8?B?amVtbUwyM2NPNlR5VU9qZFBhRkdEdVhmQUV1L2NFVXZROEgrTHdJVVd3a2hF?= =?utf-8?B?YXVHSlYxZk82aUI4ai9QczdjNTdOYXBjMWlDZmZoL1BuVXhHdWtLTHI2dk5V?= =?utf-8?B?NnF5NThtY1FTU3JnR3BKZndYL2w2WjhNeUxaVkRBR1BXNmlWL2hmZEhNRDJo?= =?utf-8?B?YmVrK2tMYVd4Y2NlNERzaEdRWFNVQytaYXM4NmFHb0J5YWc0UDAwT2FFMkVp?= =?utf-8?Q?qH1f+Tnyy+eC/Lise1iUC5EpR?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?UlZBU3hFUk1ucHF6dXMvSE9kOUJtZmNSdTF3WFByUzU0MENWV3dtRkFVYzRF?= =?utf-8?B?azVCT2xPNzhZK1AzYlhLdHZ2bDdMNGhFcS9QcERYSHE5bHRTeVJOK0g3NHB1?= =?utf-8?B?bng4M1B1NktNeXFKb1grUVUrUzBreW5PaDBzVXI1OWFJTngyY3FmU0kvdm9H?= =?utf-8?B?MUdpTWo3d3o3L3VyMlVubmhGRkEwTWZPUnFNdlk0cU4vU05HbDlVYjFNTW5O?= =?utf-8?B?b0R1ZTF6b3g4V0NwMDFWRyt6NFk3VndDMGFoRDJrK25OaytiT0NiTmN4ZVg4?= =?utf-8?B?RG5MVEx5SWFwSStGSXVwM05FOVVxRDczb05HcUhZeGtEMVZFb2FBYzFtZDlJ?= =?utf-8?B?Nm1rQ0l4T2J5WUNsZWw0bVFXTDNMdWNKSnJxSnRzRlVocG1uQmlmS2xPczhS?= =?utf-8?B?MThKQ25UR1J1S2NRQUI3bmd3OWJsU0VjRDVNdWUxbmZxZm9QWUlJVExRVFRm?= =?utf-8?B?NlR4QUV6SzltNnFwMFFidm5lMnBWSS92azMrVk41cE5VdnB1SStqaGFxK3Ey?= =?utf-8?B?MnRtK3JUNjJ0VmhiZXRWL2pHY3JHcFBoc2g5aDVYL0Y2TlVJZVVUMjJ4MXdT?= =?utf-8?B?WE5OK2pUelR6c2tscVVFRjJQTmsrNDJFZ0NRbkpmQnZ3RUtpTTJYbWtIeEc3?= =?utf-8?B?dDRNK3NGZE9aR0M4VHJJeHppeGZXUHEzc25QT3pkQmN6a3BlRnRFVVgzTTJ1?= =?utf-8?B?R1BWTGw3T0g1dWdHSjRBVUpRSHplempmWTBzZ0lIMXlDQ01tNEx3ZllZUENV?= =?utf-8?B?bi80bG42dnRoTTV3YTFKZlBzQXZJNDQ4TkcwbC9JT2NvLzBvQnRBNlhvNDE1?= =?utf-8?B?eXVOLytKYnlldEZhSkQweE1xRTNadStwcHVlWkNaK0dMdEpHbUFuU2R0eEhQ?= =?utf-8?B?Zjh3UHZ3K2taSWtjc0RRa1NWSFltWDd3UUdmSmwvSE1yL2wvZlhuVkpiWmcz?= =?utf-8?B?THIvWXphRnhUdnltUnE1Q29zWjREeGZhWDVqekxiSnZ2SVJ5OEJ2dFJ0RlBY?= =?utf-8?B?SEV1TEdrb1NCZTZOYlZ1WFIxYnNwK0FHaXRRMTE0YmFyOUZJMmtJY3lpM1VF?= =?utf-8?B?OXpQUzZGeEdSTEczNDFoOU9XR3JpRE9VUmFJMXh1UWQ2RzZ2a3Vlc0NJT1FJ?= =?utf-8?B?dlV2SklHWksvNjdCckRPNXhKSmhmTzIxejlZeCtBTzZjdCtaSVdKM2lrMjha?= =?utf-8?B?U1pabjhoTXdPdnJtaTNkK21uTTl4MEZrWEhicUVvb0FURHFpRFlkWXZxQjF6?= =?utf-8?B?eFBjRzEvWE12L2JndDVTRndxUFVRSThPZkhFdDk2RElWTll4Zz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: c4fd9326-0936-44c2-3e11-08db4af0556e X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 09:33:49.2402 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 84z/nnPzj03z73/Cj6ojODkpleCNuLwgg/njzSEDetBbU8X7vNiwZ5kJhyFCP3mTSHOBUQevpv3cNKGOhhLZBw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6699 On Tue, May 02, 2023 at 10:27:39AM +0100, Andrew Cooper wrote: > On 02/05/2023 8:17 am, Jan Beulich wrote: > > The hook being able to deny access to data for certain domains means > > that no caller can assume to have a system-wide picture when holding the > > results. > > > > Wouldn't it make sense to permit the function to merely "count" domains? > > While racy in general (including in its present, "normal" mode of > > operation), within a tool stack this could be used as long as creation > > of new domains is suppressed between obtaining the count and then using > > it. > > This would not be the first example of the XSM hooks being tantamount to > useless.  I doubt it will be the last either. > > With the rest of Alejandro's series in place, all requests for a single > domid's worth of info use the domctl, and all requests for all domains > use the systctl. > > > As a result, we can retrofit some sanity and change the meaning of the > XSM hook here for the sysctl, to mean "can see a systemwide view" (or > not).  This moves the check out of the loop, and fixes the behaviour. Don't we still need some kind of loop, as the current getdomaininfo() XSM hook expects a domain parameter in order to check whether the caller has permissions over it? Or we plan to introduce a new hook that reports whether a caller has permissions over all domains? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 02 09:34:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 09:34:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528410.821514 (Exim 4.92) (envelope-from ) id 1ptmPC-0004F8-CG; Tue, 02 May 2023 09:34:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528410.821514; Tue, 02 May 2023 09:34:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptmPC-0004F1-9f; Tue, 02 May 2023 09:34:42 +0000 Received: by outflank-mailman (input) for mailman id 528410; Tue, 02 May 2023 09:34:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptmPB-0004En-Ug; Tue, 02 May 2023 09:34:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptmPB-0006bB-L1; Tue, 02 May 2023 09:34:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptmPB-0000zN-1d; Tue, 02 May 2023 09:34:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ptmPB-0002Hp-15; Tue, 02 May 2023 09:34:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+viSyQCA1Z2bF9ETp9Kc8Gi2H5hJICjYKlwNPCv/2m4=; b=grPipTIBjshBhl3v01nHuewxCZ Ya6YefIyIjIasOheqmoe2Sgb4Df6lTpruL/2Tv9pMTEHDjpES45/vU1dL/gKfO7nU1HdRP/fyUWyY qGZyZyz7EiheC+b3UK6IBOwb7Sbokndx0sBYLsrN+DjbC1KIYGSyakhGaqbWWM462x8o=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180502: all pass - PUSHED X-Osstest-Versions-This: ovmf=23c71536efbebed57942947668f470f934324477 X-Osstest-Versions-That: ovmf=56e9828380b7425678a080bd3a08e7c741af67ba From: osstest service owner Date: Tue, 02 May 2023 09:34:41 +0000 flight 180502 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180502/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 23c71536efbebed57942947668f470f934324477 baseline version: ovmf 56e9828380b7425678a080bd3a08e7c741af67ba Last test of basis 180470 2023-04-28 12:40:43 Z 3 days Testing same since 180502 2023-05-02 07:42:13 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: PaytonX Hsieh jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 56e9828380..23c71536ef 23c71536efbebed57942947668f470f934324477 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue May 02 09:39:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 09:39:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528416.821525 (Exim 4.92) (envelope-from ) id 1ptmTx-00050a-VO; Tue, 02 May 2023 09:39:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528416.821525; Tue, 02 May 2023 09:39:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptmTx-00050T-RX; Tue, 02 May 2023 09:39:37 +0000 Received: by outflank-mailman (input) for mailman id 528416; Tue, 02 May 2023 09:39:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptmTw-00050N-1E for xen-devel@lists.xenproject.org; Tue, 02 May 2023 09:39:36 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3da54026-e8cd-11ed-8611-37d641c3527e; Tue, 02 May 2023 11:39:33 +0200 (CEST) Received: from mail-dm6nam12lp2171.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2023 05:39:26 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB6526.namprd03.prod.outlook.com (2603:10b6:510:b6::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Tue, 2 May 2023 09:39:20 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb%4]) with mapi id 15.20.6340.031; Tue, 2 May 2023 09:39:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3da54026-e8cd-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683020373; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=Vupd9GIf/iSUDWxuU9OY5RGPur9GEsNPNTDZ9vRliqw=; b=hHxXgr3RywuwNAXZxuqaPAvxp10lYWaqfvbZRLBgQU8e2YFxGG08Ogsr xMJUGGAeyYxN8HSkmzoj9+kZSm0sUKlbbzYM9+hWX+wmwWaB7MA3xPIhV 0PBWfu9ovCBBm7L2mG0xkkp5ahvBXvBcMghLcQusGfAkjuCZj0g/PP9pi k=; X-IronPort-RemoteIP: 104.47.59.171 X-IronPort-MID: 106308496 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:0eY/c6/H7nn6MYSZ+Xu0DrUDGn+TJUtcMsCJ2f8bNWPcYEJGY0x3z 2AYD2+EbKrZN2HxKN4gPo+29xkG75TTxtM2HQFvpCo8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kI+1BjOkGlA5AdmOKgR5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklDr 6weJRE9diy9gvm7h7CaR9Z2u5UaeZyD0IM34hmMzBn/JNN/G9XvZvuP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWCilUuidABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTAdpMT+Xoqq806LGV7jAKDyYoVlqdmvyopB6PcO1jK FUL2DV7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhq19KqQrD60ETgYKykFfyBsZRAe/9DprYU3jxTOZtVuCqi4ipvyAz6Y6 y+OhDgzgfMUl8Fj/6mj5lXGnzKEr4DEVBIo/R7QWn+57wR/f8iuYInAwVHf4PRJKoqDSR+ft XwAlsqZxOsKCoyB0ieKRY0lHriv6+yULT70jltmHp1n/DOok0NPZqhV6TB6YUtsbMANfGazZ FeJ4FwIophOIHGtcKl7JZqrDNgnxrThEtKjUe3Iat1JYd56cwrvEDxSWHN8FlvFyCAE+ZzT8 7/AGSpwJR720Zha8Qc= IronPort-HdrOrdr: A9a23:ZTR7X67KDQmj6L8uPAPXwMzXdLJyesId70hD6qkRc20tTiX8ra uTdZsgpHzJYVoqNk3I+urwXZVoI0msl6KdiLN5Vd3PMzUO0FHYSL2KhrGD/9SPIUzDHkM378 pdmy8UMqyXMbCv5vyKhzWFLw== X-Talos-CUID: 9a23:GAVLA20BlJl3roihmSsnh7xfF5p1dHD8/G/sHUqjBCFrabCqU2LBwfYx X-Talos-MUID: 9a23:Lj0T1AkwyweZ29UJXt7Ydno+LcBT3aevLnsIgLtWiuK7CS9pJBWC2WE= X-IronPort-AV: E=Sophos;i="5.99,243,1677560400"; d="scan'208";a="106308496" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XQ8NLxYEtrBeLweKkTfOk4yasIMDAdgsJl/IU+Mvra0WOafI259MHwuuKNAFeF/jn3wBOEiVA9sqBRrk0PFt4G1wQx7ms94fAQMB7YtMjbEjKiHZ7QiFSGLoCkEEsMoOPUTGXqmq+gWnPxEm8qmlKHvxzVgeLvicFWMzsrz0VQahbq1ALBhGRnls5ul65+0APpB1jWRBgbFLpx1MdszHsyHIa2G6WNNIUYIRua87SCpDTILYqTOR1YJWaP0lJh0nf0iebs5HSCd3GZ5V5b0ASzWb+5/en6Zd8asW85BBACtGRjUlr3K7BikI3jA/8JylSKMc0hK4PgvtOoNQif3Ccw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vupd9GIf/iSUDWxuU9OY5RGPur9GEsNPNTDZ9vRliqw=; b=ULX4YjFWLfKRn0miVfnnfDI+HU0p8Z3w9Mp3gWgSyW/YqvmbfTscb1xtcpgeaBAskpXspKWvADW8WL/FIedA2f2CPA0fIPi4F1b47WfyD4BlhdWFswBLuYpwvZXofJmlmWpplf8tQRdYfN45zynyd7PHox9wniyybOK3DwmMmG6dnrZBZRavYHMqCqGZK3yHnTnpiLSo8iyYvHo0JzWKo8ftwl5cKqVs2Qvgat8sFP5bTNPo5c0e52STsSQC2OKEMmKhjyCZmbQclf/oh58WrO3wFDTwuJDairg7K4Eu6XAwX/e00bYilR08T+IkCjf+Cllq86fXGp6Ovx5WuuUR+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vupd9GIf/iSUDWxuU9OY5RGPur9GEsNPNTDZ9vRliqw=; b=EXtBWPs0/nsF082w0k1F9SnQRs2C8zcteDj0+s1gq3LdueF+CyToNFKc0o02CHPogfeD142tRdFLT3Kc66FJEmXnMLMndnPeIJ5NPwggdPE8gIEq+JT6kSj5AFka/yCzT/Evii/CF7sr3zXdZa4SWiXrZBVQwuAV2hMBLI1FxWk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <05b09b22-08a5-a2fa-5efa-74845fcc2445@citrix.com> Date: Tue, 2 May 2023 10:39:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: Andrew Cooper Subject: Re: [PATCH] sysctl: XSM hook should not cause XEN_SYSCTL_getdomaininfolist to (appear to) fail Content-Language: en-GB To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Jan Beulich , "xen-devel@lists.xenproject.org" , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Daniel Smith , Alejandro Vallejo , Jason Andryuk References: <26064a5a-423d-ded5-745e-61abb0fa601c@suse.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0363.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a3::15) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|PH0PR03MB6526:EE_ X-MS-Office365-Filtering-Correlation-Id: c5020920-f78e-4b45-5465-08db4af11b10 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wtyPiy1BXUpYD+Yum4L6xkS9UbDQZD7OK9T6/VSG9sDQpHzfxcaiXtxg5bc6UW46kvfYqU6XyGDVE3vJrvb2PYKUb9Bfbb/js3JNsVsYPHVAxLIB2HnE5PDw+3Il4mpNlh4Ww86rLlW+l7ysUSef0jfHfTISKPl+M245OvvMjlr0WIxdnY2OxSq8zDz4MtcBaso6sLVECSJkOrccFzrHhG50lykxE9oJPNp1IS/HNU/IYoO8O7CwMu0FyOMqsjHEqlo4b0p6MFdmOXB1L8RqOusuO425iAKxIjw9pglHD44NxVuVZpLRTHIclPSf38iUPXcShvg5xjs47e73YVPG+wJ9UPv71jw653Sm7Kxnaf0d7qP2AiFVLiScy15OnoEV9II5j9MGYxptesMKOHkRhxDaw5Q99bqYqsi+HCTlpMn0g6NNn2MIK98PSx9PuST2JxcICHwjOBDe7wzrd+23uik4hzyon1O79Nkf1//tU6sc/1HGtwTbAKhu56eSY75G+V9UeULmH94clWBZtU95duSV6XAXHUuSpzBASRj8O7QpEHizx1ye6nGCuIqjtbjGjnLWfxcQig8hChpoE5jRl3kNhlC0CYXd/xCqnnKRmMscy+TqauohlkE+d9vwCGSZa8teFkREwkm7CTPmzPqoww== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(366004)(346002)(136003)(396003)(39860400002)(451199021)(31686004)(316002)(2616005)(53546011)(6512007)(4326008)(6506007)(6862004)(8936002)(7416002)(8676002)(31696002)(86362001)(5660300002)(478600001)(37006003)(54906003)(83380400001)(26005)(41300700001)(2906002)(36756003)(82960400001)(6636002)(6486002)(66946007)(38100700002)(66556008)(186003)(66476007)(6666004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dktOVmNQZDg3RUROenVlcGt6S0FOcURqRHJDWU56NlJZR2U2clB2YmNIN1ZZ?= =?utf-8?B?c1VEY2FYNHZTdXdzY29ocCtoVHlHcVQvK1pQK2hURkplOUdvTVJuMndOUW1M?= =?utf-8?B?enVDaW5GdEU2S3FUM21DVTNmZ24ySnJYTTM2Wm9hREplNkNOdFpFaWpobDFl?= =?utf-8?B?aXRDYnVacmROVjlWUW1qMW9KaVpMck5ndmxmUlE0TnNFQm5KTm1PaHBmQlN6?= =?utf-8?B?ZXlieFRycTZyZTh1WU9EaFVmdGFpYVZsd1J0NTM5cjhCOGdDem5DUEtJR1BV?= =?utf-8?B?RzB4VDBJVGZmSU1HeU1FOHNKQjN1UGx3SXF1WXUyZnkyTUMyZVgwa0ZNRlhw?= =?utf-8?B?aGUrVUloNURJOGRwR0xhN3k0ekpibFdicDRHREZHbkJueng0ZHNEVTdWcTlW?= =?utf-8?B?WnpTeVdPeW1yY0RhTUVyNUpYdTNxc25KZVk1dG9FeGZoQXBNYkdqbGUwS2h3?= =?utf-8?B?L0JzSGZFN0w2UFd2NUp2ZG1PalhSQTkxTlBBaWdvb3lrTy9BUjNQbTE5L3cv?= =?utf-8?B?Q0dLSFBQdWFLWnppWUU2Q0NkeUFrbUx4NGlHSTJnNUJGTitKYWpKaHc3UWo0?= =?utf-8?B?U1J6UU5iOCtSM0RTWWpRN1grcUtSU1J5L1oxd0pZNlZtcFpraUxrMVVNblgw?= =?utf-8?B?cDc0Kyt5U1E1aWl2QkN3TE12Q0lGd0REeTE0NFRQY1owZ1lhUzZZOFJyV01u?= =?utf-8?B?djZvVWM5Ris3cXgya0pOaTFkcG5wa2lpWU00cG84MjgyYVJXZnZLS0VnUzcx?= =?utf-8?B?RGRjSVBOQ1Fham8zcStGbUJjeDU3NTRGTURFZG1UZGgyeGJ6NXQweXJNZk9t?= =?utf-8?B?bkxSMGl5SGRKV3BtZ1hSRUhoMmg3eEFFZ0xWdUpBOHBlMG1OejJUK2l2S2po?= =?utf-8?B?T21pblpaSUkwWDNDUy9sTnp2eFZlTGVQU2JXL1gxaW9pREtLNitwVTZDRDh4?= =?utf-8?B?dWswbzRtTXYvSngreUdwckNkQ3JVVUFqN0ZwMkVaQTJFQnVNY05aVTQ0S0dU?= =?utf-8?B?dWZNbDVENW9QUjNabEQ4THZRWHN2djhLb1duYlBsNmRYOWJQUFNTZHdWcmJW?= =?utf-8?B?SFM5a1lSZjlnMUNMOTA0ZjB0TU0xOGhFNEZBRUJacjNoNTZKMFNkQlhiVmRV?= =?utf-8?B?TGgySEE4dU90MTlvRzFHZ0hDNytpWndwa01KQXB6YmlNeUs3NkgyZVFRMGw1?= =?utf-8?B?MFNYTm5EZCtmSjlOdG8rTDdjcmVBR2s2ZVVXNUQ5OUt2dlFqT0E3d2lvQ1Zl?= =?utf-8?B?V3ZOZXYzNlpCb2tsM3pqdmlJWmN3WEFzcmd0QXNTTk5sdGU2KzdWRi9vTCtp?= =?utf-8?B?b1kySFJWT1gwUU1EQ1V0NWUxNGgrYmRDdks1anJiMCt3eWYyRDYwNW15UE9K?= =?utf-8?B?Z3gyK3NBREtlQXpoVGpOVkNtanJkMXZsTjRQbTFBeS9waUtOOTE1SWVwSjJ6?= =?utf-8?B?VkZLQkpWNElXUVEzeFpRVHJjVVBPRFhxUCtMVEVIZ29ETUVBVk1QUFJBMWhj?= =?utf-8?B?TTdpU0I2M0VZdWZLdzdxcDhtYTNVUzIwbkt1MXlLTllRZEJnay8vTnJVZkFt?= =?utf-8?B?M1VkaCtnbEN0RngxRTZwRmRKajA0RGFQQ21ucm5oUGdCTXpLQkdEaGFXN0dm?= =?utf-8?B?QnVoWXhyNW0rc3NZVGxPeUZXTEJtdmZORzFXNE5IWUpJQU03UzJndGZaSUdT?= =?utf-8?B?ZzJXQWN4OHkvYXF0UWxhd3F2c29lVGp4Rloza1FCWW0rcTRZM0FZR1Q1R3k1?= =?utf-8?B?dUFYRkFUNVh4bFBYMTRVaWhkSnZmSGNTYVcxZmk1QWwwZFhRQUJJeHFYZVVk?= =?utf-8?B?czhHaUszZ21RSlhqbHI1UFY4dlVJazJFQmFYQlQ1dDBndzd6VkEySjFiVXM2?= =?utf-8?B?VklDLzFMWDJQNFlJbnhSR2l5VExsNTd0cnpTUzVHeE5aUEFPZGlyNWxsNFMz?= =?utf-8?B?UWVSUnNyamJPVVZmZlRWYWVSbnlkWUUwcUZSKzN0VkNjYjdsOVJQU2hCcHBo?= =?utf-8?B?N3ZpR1pVTDRKYS8vdSt2SG5BOGZnd3FVUFJqdTh3dTNUOUgxUVdHRXdNTUto?= =?utf-8?B?Y3BhdDc2ZStOeVA2ek9YaW5mYUZuWStXaFdVcTlzcXFlTjZYdHV5L2xtUVNT?= =?utf-8?B?YUh4VWM1SHFWQmFFUC8xQTZjRFdua3k2MHAxRmQxRFlNNVBaUWNlUHI2M0sy?= =?utf-8?B?TFE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?UnBaRzhsVDV6YjArb1NaV1ZML3dBUlRGT2ZKYW1Gc3Q3dHZEVlhDQTZyQ3gy?= =?utf-8?B?SlNjRWMzYnZ1L0RwL1A5TFI4SStYTGFxdW9aeFZxMWpMend2L0ZQTUVpYjNY?= =?utf-8?B?TzV4eVViSmlPSEhqWGI3dFhzV3pJL2NHSG1aQWI4aTV0UitqMlN3aGszWVNw?= =?utf-8?B?TVNybHJwSUc5ckJtekVQSitqd1FaTjFvOUhtSkdxdlJsTDdFZFRzSEJDWXdL?= =?utf-8?B?Yk9qQU0wRVpBOHpGNUVSU1U4UVNDNzd0R1Bob3BWdmtpaFZucUp5QWFiT0tV?= =?utf-8?B?dzBKQ0cxRGt4RVNBSjFobGFZSDU3WklRZU5JZnJMazVIOFhRb25iWkt1L1Jx?= =?utf-8?B?NWtlOXRPcnA5RitPa3VsWGtjRFZrRFNyd1lvVWNjSGlnQW52TEJkZUtxMkR3?= =?utf-8?B?Y3FXU3RPRGp3QlJyTTZpQ1hMN2NNWFg3cUpBWngwbmtvV3ZEZ1NwOTh4Vm1D?= =?utf-8?B?czBRMG04UzdLUTlXZyt6SVJ5UTdrU1ZlMExLcFV5U3J5RmRaNnM0OXhyQXh3?= =?utf-8?B?R0JzVFFDWXo4azBSdktxRFAzalZNWmtPOWR3akJwZStNVXYraEtlSG9UVHNM?= =?utf-8?B?REZlNDdzYmEvek85d0o3dUdHZldOMHNNZ2hTTTJjSGVsNDd3OGVDNFc5eVRs?= =?utf-8?B?blMwT09yejBoSXlHdmJaS2psQWpkVEoyWUtiazZFSzdtWmpPenRHNnZBRlND?= =?utf-8?B?UTRHcWJtYkxCNmViZWQwVCtvQ1ZXdXYrNFdPWm5EaXREY2ZvTzBmaG83TUxN?= =?utf-8?B?YnFUalloUnhDQ0E5RXVLMHpaV0wxSGk3Y1lZTHVEckdOVys3ZXUzNkNhWDBN?= =?utf-8?B?UDJKUnRGS2VGNDRGaGorR3VNVHVMeFB3UHhJNUtFL3BnUlhlY0RVdUFBQW50?= =?utf-8?B?SE5meTBlSHFTQStoM21MbUVFdkdJNEU5UklvZjlHTTY4ZElVTi9GSFJFcTB2?= =?utf-8?B?aE9DNDdlUW1pVUxQYnROY3pNWFFXYWkwMk50bTRyaUN0VGVsSVpmdTkwb1BS?= =?utf-8?B?VjUrTG1IOEdCcksxTXA4Mkg1N3QySjg0c1pkQzBqQkNRKzNaclJFV1owZVNF?= =?utf-8?B?WVZibHU0cS9oTXpFMmdZQnd1TkttY0d5alV5SnJXWitSeHkrNUsvcGc2cnNE?= =?utf-8?B?ZzJpZEF5b2R2elp6c1VmdWtyNG5CR1hmNlVUN2NhbmhyMUwrNldDYXdzWGsw?= =?utf-8?B?eU9sWE9wdEhkL3NaMUZHM3pxRExTZ0NGd2dnbXRRYXJFZmd0bGNaTUNBS2M1?= =?utf-8?B?NU5JUEVvUXhZTVFGbDV6bGNha2lCckQ2elk3b3N2Y2tvbTZKQT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5020920-f78e-4b45-5465-08db4af11b10 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 09:39:20.7433 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +kBqrQUkG8gSP0RoIpA2tTsCM+AFIwaVmj9faavkyHEjSsxb8fKbTSkE/C/Js4/fKsd+QfK1rxKdTPYpfuPfRT4PmaGubDvlhaMny/DiNis= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6526 On 02/05/2023 10:33 am, Roger Pau Monné wrote: > On Tue, May 02, 2023 at 10:27:39AM +0100, Andrew Cooper wrote: >> On 02/05/2023 8:17 am, Jan Beulich wrote: >>> The hook being able to deny access to data for certain domains means >>> that no caller can assume to have a system-wide picture when holding the >>> results. >>> >>> Wouldn't it make sense to permit the function to merely "count" domains? >>> While racy in general (including in its present, "normal" mode of >>> operation), within a tool stack this could be used as long as creation >>> of new domains is suppressed between obtaining the count and then using >>> it. >> This would not be the first example of the XSM hooks being tantamount to >> useless.  I doubt it will be the last either. >> >> With the rest of Alejandro's series in place, all requests for a single >> domid's worth of info use the domctl, and all requests for all domains >> use the systctl. >> >> >> As a result, we can retrofit some sanity and change the meaning of the >> XSM hook here for the sysctl, to mean "can see a systemwide view" (or >> not).  This moves the check out of the loop, and fixes the behaviour. > Don't we still need some kind of loop, as the current getdomaininfo() > XSM hook expects a domain parameter in order to check whether the > caller has permissions over it? > > Or we plan to introduce a new hook that reports whether a caller has > permissions over all domains? New hook. The current behaviour of skipping certain entries is fundamentally broken, and needs not to stay. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue May 02 09:41:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 09:41:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528419.821535 (Exim 4.92) (envelope-from ) id 1ptmVV-0006NY-9x; Tue, 02 May 2023 09:41:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528419.821535; Tue, 02 May 2023 09:41:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptmVV-0006NR-6j; Tue, 02 May 2023 09:41:13 +0000 Received: by outflank-mailman (input) for mailman id 528419; Tue, 02 May 2023 09:41:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptmVT-0006NJ-Tj for xen-devel@lists.xenproject.org; Tue, 02 May 2023 09:41:12 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2043.outbound.protection.outlook.com [40.107.7.43]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 78286036-e8cd-11ed-b225-6b7b168915f2; Tue, 02 May 2023 11:41:10 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB7025.eurprd04.prod.outlook.com (2603:10a6:208:19c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.25; Tue, 2 May 2023 09:40:40 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6340.030; Tue, 2 May 2023 09:40:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78286036-e8cd-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gyqu7AJGv+KGQ9CFoLTS5HhonlItsa+4ojydPRjvGnG61qfrkaHP7hN9DKIfa2oxhWXvZgfofi1tXsY3+eAFZCLFMZL5sucz7a3Vi+ElgXQ8GgyuZAnf9Ahwq5ffX8gNtwCqrzcYvi9xeXtHYYMw9QKMmv6fp9y9qpVlj4GOQI9oaTfz4FHsmCZW/VfU9VWUT0EqMBmiIm3VKVjAtI7VvEezAb37HSNZSzbY1Ph4HXNzQHFSV8/hRLn/k4vPQ2rS9Ro+DkZn+o/WajDPvkgCydp1QF2CNzKUtMu9OtnHhVgvHcShaL7k5PsBy6rOyMAi0n02RgqO4rEevdGBx1nFDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sWd4VHl3QwgEFRTdzx+i/fqQiQZSGVt6HDdW7tgg490=; b=XcOXzrRx7JKFyOmfAuR6qIjpDaq0Fl1YrcW1oVpyVttBoL3TjPSuFUKxdYa2f6Wq3G796ey9Ue8IvRHLm4JjeCX0wK3UA4m7JFr7gItXZVqwhbBMUDEHnc1SNijjz6FLCq9LpRIAt9vVQvOXbDM6vEAUCuxIxJ40Qfm3Lppc7TjdE95ek7aPLehAqsf6Z1BU/79puweuVQJxqPYcYhjYK3TAdc98Ax9eNtlKwWYsFLYf7YGR2iqRoTGFPZUBisWPlDCFHSZVfhebs3JZCIFoyr2nhu62xwGWlpLHEWTVnZva+ZJ5pjxeNaWBVhnSacuM3t/zDKyBWTM7aPx/BaFebQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sWd4VHl3QwgEFRTdzx+i/fqQiQZSGVt6HDdW7tgg490=; b=UJWTe1tRoi9ZJD62RQeVdubkRyl2+l2vf8b2aOy0v5/fA/qMPEBETg/0ke1iso+a9WwROZnbeVYEaTLHgtUyR08K5QaidsI9Q26pKNxVe5uShajJu1U6OoRZ865ti0at/astLFnlN1xFhfhPt2A6VwU7OmzibyxiOgf5VHDhaGMQm63YT9DdZqAhGOTE6gYfT+DrjaffvUarNMUZNM5mXGJ+Lfl4+C/+xiSMK0k+xdSrWvwemlrN8Ppo6nbYSreQ0hAT4J6g/xqVro+TeE5nxRIp8dkSp8gF8JmSi36eznYJ6Cx+5HXtFgJ3ty6WO1DcIGakcjU6Iq14TFtc5B9JvQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9339daaf-533a-4758-c25f-164c27f56043@suse.com> Date: Tue, 2 May 2023 11:40:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH] sysctl: XSM hook should not cause XEN_SYSCTL_getdomaininfolist to (appear to) fail Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Daniel Smith , Alejandro Vallejo , Jason Andryuk , Andrew Cooper References: <26064a5a-423d-ded5-745e-61abb0fa601c@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0107.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB7025:EE_ X-MS-Office365-Filtering-Correlation-Id: 02054f07-810a-415e-577f-08db4af14a4e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uPTnxV2UK5Lchke2f8bQUOGrw4skonr6hID1Aju23aBSXkmLERCf1T6rjQQYbneCJP41Naztfe+K2jfzU4JIY+UenbVOMig2zd5NMsRhywWEJ856IAjOo3Oh2W8vYkZHCtUnhScKxEQ9lrt/dQl/e2yy1lwvTtE3jZ98igOMDyqEdg8SGQd7W0kwI2aniymNCsuRQy++qf4xaGprixlmXWsP4BtxMuQp5ACKbpykYE56oyYqVSM/6yPdhYg7jChP3JzK/fC6UD+QIW5biUPgS9JT/YLfiPtRcWGtYT8IcaiJbWtW2Xaq7UBaEqK4quc+Q7DWEE1xXxD/FZaGD0Qrq/iCWKpEkwVIXPV5ep2N1KF8zHSdeC2HojbwOow2ZiV9KO9pa155v9SkeGZJO/udr4Ofz5egyKHdmw3CdZj8o6wb2Kj7bUbxeM+qfJ4dC85P1aqy5oopF30LGI3pWSlYv+f+gI0WZoWp+lZeL2NtyvSinuNI+HkhcfXuW5c2vFl7EtiCLAWADW70SRkeLrfgYcNvcHBIPGqzdLhLXxQft7S7fPRMx2G5+INPdkbhatbzmp0tFFh0JiGckcgTl7w79+ilRE0OV6X1CaVB8BNbdAwf67P3lC/bqM8ksDQ4vYe0CpMAx/q4ntAorPPQnximlg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(366004)(136003)(39860400002)(396003)(346002)(451199021)(86362001)(36756003)(31696002)(38100700002)(66556008)(8936002)(316002)(7416002)(6916009)(478600001)(5660300002)(41300700001)(8676002)(66476007)(66946007)(4326008)(2906002)(83380400001)(2616005)(6506007)(6486002)(54906003)(186003)(6512007)(53546011)(26005)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dGJJN28wU3lzZE9lM21hWll1dHkzNmJTeGMvZG9RZCtkR1d6R01zVTVvVUg4?= =?utf-8?B?aGNsOFZKUUJFWTBaZUNwdDBZUVJNWVlaWVhleUlvdExMMWdJYzJXVy9CZ3Rv?= =?utf-8?B?REV0TFhxSmhldDhQekpHVGEyWWNWZzU2ZThPd2doaXhLOWdwcjQ4eUlYSTFq?= =?utf-8?B?cU9Pc0ZyY0d3QkdRT3JRYnRPK2szeFVOcjN5Q3VOWE1iTDVwbSszbzF6SXlk?= =?utf-8?B?QjFwcXJLQU95cEtubkM1Q093T3ZjZHVWQkU4Z1dUZFpPQitqaG53TzRDMlZN?= =?utf-8?B?bXNuNWVXZDRTMkxVc2xmaU9ZN1ZlU2ZHZjJIWC95VHVvYzd2WHVQNHdMYTJQ?= =?utf-8?B?azhHZ3NzYjlmeUkzYWZQb0JEdkF3M09TOFNEamFzcml3eTdBM0h3WEQrKzRm?= =?utf-8?B?a1FPOXJ6Y0F4QzZuU0tSTjE0UCswQ1ZTMlBNRDFEdWJNbHJIcWhQaXcxRTM5?= =?utf-8?B?QlErUVRzWXdGVzJIV0c0YU9YMGx1dWFGYTRTcDRZMXRMOWNmdlVoWlFPeEEv?= =?utf-8?B?Q1VHMWZtZ3lodmMwUk1YbE9OVDN1d3NyazkvdjcwVlJsTS9CWWtENjM3bjRB?= =?utf-8?B?VEQrSHJRb2JsZDdQRVltMEN3dnpwWVFuSEtjTlJhSGZzbnZURWRhTE5XS2x1?= =?utf-8?B?dU1PdG5vQTk4cWUydTRnR1ZRa25mZThRUjF1TVVHNlFTS1Y2bFAyaHB4dEZu?= =?utf-8?B?cVYrVUhuMnFIYWtURndzZDNSaGlzQ1h2SVR6TnlON3JUUWVHTWZ2cFNZK2Jp?= =?utf-8?B?L004a0tvdkdVcW44RE1XakFoalZLWkNHY0RiakV6UXNYUVArOER5bjFVeVNv?= =?utf-8?B?bHBKK21pQWQ4ZUZnZmlqUk5sd2FBNWx3VEpvYzJpaWpOOWNrY0MrVVcxakd5?= =?utf-8?B?NlZLb1Eyek9GOEJSZmhvaktpK0FhRkdaamUyN2R2b2FUUWZ2czVmU05aMGVx?= =?utf-8?B?UWpHalc2d2ZlRmkvVjFBTHF6eDlQbEJCTlg5dGFGUUF3c0hxbEFRWHo4RjND?= =?utf-8?B?SzgwdjFZU2Y2dUpxSU9DRkxrRzVvY3lHTXZkdXZjOXFzcU9RRFRBSW9nQ3FC?= =?utf-8?B?NUtBY21PYXEvNHhYL0szZml4NEcraTVmLzJvVDNKTnF5YzlSdW8zMmJwa1BC?= =?utf-8?B?K25IMXZEcWZNMkVTa05KaTFUNmhMMzF0bDF6RVVBUUQrREpHR1ExYmRnTmUr?= =?utf-8?B?alF3UWE1Y3VhdGlORVJjWXNuTk9zb01DTkVlSXFyZFlYdW8xSmNuaDZ0MFFE?= =?utf-8?B?WTBtTTlRbDZib2VPMUNuU3JDcTlDblJpR0FJbkNON2JZWDc2SExXYk5DdDVJ?= =?utf-8?B?NW9UaSt0MXlsc3UwNXBlbXdKZjVkcUpzMkE3NWRycWFVcmRFM2FIaFVZUUdZ?= =?utf-8?B?RTBQeVBsNy9BTFl4MmhWV0xrR3dWeHBSVFU0Z2tXVDk2OE1Od25rR3JDUU9B?= =?utf-8?B?NmY0djJTYTQ4N1NPb3pBdTRYY1IwWUVjOFJCdXl5VmFKSFJyZFVoS3lDSjFp?= =?utf-8?B?cFVzUlNwOGpZUVhyMXZ2d1RzYlQrUjRDNTMwcnArNENLdHhEL3QrVFhiZThx?= =?utf-8?B?amxXc1d4TEhsWmNmV1o2RFcvYUpXS1VwdGZ1MWp2b1NNeU04Rk1maHNPQ2U4?= =?utf-8?B?Nk03WEh4QlVBUFhDUFFzRHpiUjhQeEdJcUJFQnNDMmN5R2lkTXF0U1JjRzJh?= =?utf-8?B?Z252YzMvamVOMUVyOUI4YjNBeFk1L3ZqLzRwRGF3eXRzdWg1KzdyWFViUmZ1?= =?utf-8?B?UnlxSEtNUFVrc1B2djJiQWhZbjNsV0k3N1pkVlJEYXZEYlV1Sm1BVDJsSU8z?= =?utf-8?B?empFRFpkOUJXMWl3QkR0RzRoSTdGMm9YLzErSnlhdEwyMVRlNFFheERsOVNz?= =?utf-8?B?VEgvY0RhUkpLYVdoV1pYWWhrY1dtUkhQWitWVTR0b3NBakx6ekdFNFNMMmN2?= =?utf-8?B?cVBxdUlaMkx2cnFiRkRCMlhPV3o4dGgwMjhiQ1lMWmhObVBYQTU5bTVneTgv?= =?utf-8?B?U3h3Y2l2ZVpUK3FaOFBBSkVqNTV5ekl3VkVMNHE4S0hEVUlhMGZhOXk2Ryt4?= =?utf-8?B?VTlhV0ZjVFh5akJVYks4b0dZRU1KMmUxdmNZYWFvVFEwUC9WRzd3WXFBTnZX?= =?utf-8?Q?kc8+8uCyuJM+u7ebljEOE6pxn?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 02054f07-810a-415e-577f-08db4af14a4e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 09:40:39.8579 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: j2yoxfCuPyz2KfyXTCUiAWOkJWNHbZ8Z7fPdU20xwwS8p/8ei8DnZDShG2mZ4zTI/oYNqvCVsvoq4fuar1+T/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7025 On 02.05.2023 11:33, Roger Pau Monné wrote: > On Tue, May 02, 2023 at 10:27:39AM +0100, Andrew Cooper wrote: >> On 02/05/2023 8:17 am, Jan Beulich wrote: >>> The hook being able to deny access to data for certain domains means >>> that no caller can assume to have a system-wide picture when holding the >>> results. >>> >>> Wouldn't it make sense to permit the function to merely "count" domains? >>> While racy in general (including in its present, "normal" mode of >>> operation), within a tool stack this could be used as long as creation >>> of new domains is suppressed between obtaining the count and then using >>> it. >> >> This would not be the first example of the XSM hooks being tantamount to >> useless.  I doubt it will be the last either. >> >> With the rest of Alejandro's series in place, all requests for a single >> domid's worth of info use the domctl, and all requests for all domains >> use the systctl. >> >> >> As a result, we can retrofit some sanity and change the meaning of the >> XSM hook here for the sysctl, to mean "can see a systemwide view" (or >> not).  This moves the check out of the loop, and fixes the behaviour. > > Don't we still need some kind of loop, as the current getdomaininfo() > XSM hook expects a domain parameter in order to check whether the > caller has permissions over it? > > Or we plan to introduce a new hook that reports whether a caller has > permissions over all domains? I'd be inclined to make the existing hook recognize NULL as "global view". Jan From xen-devel-bounces@lists.xenproject.org Tue May 02 09:43:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 09:43:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528424.821545 (Exim 4.92) (envelope-from ) id 1ptmXd-00071P-P2; Tue, 02 May 2023 09:43:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528424.821545; Tue, 02 May 2023 09:43:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptmXd-00071I-Li; Tue, 02 May 2023 09:43:25 +0000 Received: by outflank-mailman (input) for mailman id 528424; Tue, 02 May 2023 09:43:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptmXc-00071C-Th for xen-devel@lists.xenproject.org; Tue, 02 May 2023 09:43:24 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c6e2a9cb-e8cd-11ed-b225-6b7b168915f2; Tue, 02 May 2023 11:43:23 +0200 (CEST) Received: from mail-bn7nam10lp2100.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.100]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2023 05:43:20 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB6526.namprd03.prod.outlook.com (2603:10b6:510:b6::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Tue, 2 May 2023 09:43:18 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb%4]) with mapi id 15.20.6340.031; Tue, 2 May 2023 09:43:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c6e2a9cb-e8cd-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683020603; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=SqrnxB1FHGf9zwSPosA5wTrIkQF4vLRLE1zeU49Fi80=; b=Z8gbEux+3tQy039Ju48KQH0wPgsG5U7kUFVmNqWgzbAvOA9xdJzI7P3c JVxdmXLyViIwNNSHAbZxC0uG/f4zsA0IWSlgpDErJIEobEsZDonKP4BqR jrLpGc+96Ddeu15A94QhiEyc7piRPcAphNBHdzabutsdEQZ0Zf0uTe3uV E=; X-IronPort-RemoteIP: 104.47.70.100 X-IronPort-MID: 106877086 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:iZ+TGKysO+xm+jKOPJZ6t+caxyrEfRIJ4+MujC+fZmUNrF6WrkVTm 2JLXDuPOazeY2L2ctF2PIyw8k8A75+BnINhGlM4qyAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UIHUMja4mtC5QRjPaoT5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KT1B+ tdGDxkgVRyGg92nxoOdW9J0ott2eaEHPKtH0p1h5RfwKK9+BLrlHODN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvDCVlVQpuFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAuiANxCS+LgpqACbFu75F0sCTsGeEWAotKGh0+jauAGd F1Kw397xUQ13AnxJjXnZDWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOnM08SCEu1 1SJt8j0HjEpu7qQIVqC8p+EoDX0PjIaRVLufgcBRAoBptPl/4c6i0uXSs45SfbtyNroBTv33 jaG6jAkgKkehtIK0KP9+k3bhzWrpd7CSQtdChjrY19JJzhRPOaND7FEI3CChRqcBO51lmW8g UU= IronPort-HdrOrdr: A9a23:+gkPba3ShLyJWOJP9nScEQqjBfdxeYIsimQD101hICG9Lfbo6f xGzc5rqiMc1gxhJE3I+erwSJVoj0msvKKdkrNhSotKOzOW9FdATbsSoLcKpgeQahEWmdQtp5 uITZIOcOEYYWIKxvoSpTPIWerJ7rG8gcaVbM3lvhJQpTgDUdAG0++SYjzra3GePTM2YabRd6 DsqPavxQDQCkj/Nf7LfUXtNtKrz7an+P2JAH52ZCLPqjP+xQ9Ax4SKaSRwtS1uJw+nr41Sh1 Qt3zaJk5lKcpmAu33hPzi51eUYpDKt8KoEOOW8zugTNjHmjEKJSe1aKsC/lQFwhNvqxEchkd HKrRtlF8Nv60nJdmXwhRf2wQHv3Bsn9nenkDaj8CPeiP28YAh/J9tKhIpffBecw008vOtk2K YO+26CrZJYAT7JgSy4zdnVUBNBkFayvBMZ4Lcupk0adbFbRK5arIQZ8k8QOJAcHBji4IRiK+ VqBNG03ocSTXqqK1Ti+kV/yt2lWXo+Wj2cRFIZh8CT2z9K2Fhk0kox3qUk7ys93aN4b6MBy/ XPM6xumr0LZNQRd7hBCOAIRtbyInDRQCjLLHmZLT3cZfw60kr22sDKCYgOlbCXkMRi9upjpH 2BaiIDiYcKQTOwNSXUt6c7oSwkQw2GLHbQI49llspEU4bHNfnW2B24ORETevSb0rUi6+3gKr KO0cFtcrjexC3VaN109jy7fYVOJnwXV89Qnt46XlaHpavwQLHXig== X-Talos-CUID: =?us-ascii?q?9a23=3Au6oNtWo6yOzObBVyo8Zr3u3mUZwqfVaD6179GEO?= =?us-ascii?q?9DVl4ToyzWGSI3Lwxxg=3D=3D?= X-Talos-MUID: 9a23:2CGbMAkQlv5Otoj+uUjBdnpABfhpxbSDFnsOuqoLutS1B3UvKmmk2WE= X-IronPort-AV: E=Sophos;i="5.99,243,1677560400"; d="scan'208";a="106877086" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vcn2R3zHW7Yk7eCf2+geCobSmlIBLWoztBjE51PVNQGH1okYj3h2698Iu3mRk+GPhpT7BFkhuoKoEL2p6BZQWNezUHyVs7dvmMQ35QwCeq6a4i+FbtUvLEsawiExBqt1xmoNc5yQb85XVM+yxoM0KY3ZOosCUKxcBEv5gwSKDfE5y+dEoAcyNrvxDkPAVeSm0gUkF3BBzZdUFzG668nYUDe47qCo/BahMGHV5sqwux2IAI6eos56Hf99J27Im+jpAeBuO7lkBnWJ1O1msJNBANek1T4XLo5DhnGeeTVqwv9m+ZTts1a1ixnxRrj5qC0NRkzICa0JwyTey+BnPJnWag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y/ohsvz7RMYZ/9dWDuDSvtZTZRcuZhJhikCKGjbfp9M=; b=ijOuBBMk0c71m43wZbFuuiKP8ae9/PULpH2zcthzKUVxQdCVhjfmMx8BiebxI/s+4Bu/aDa1v/OlQ1Od6SZ4lwnV+uV87f1AvT2KYwMfIJdGmKZwD5ZWoU8n++X+bDOn0yrPFRsstChtGb+Ls09/lGsWt/Uwj7NQSWHH5icsKwtFMox6uPFIj0IA4HpgQ7fsSk2ocsxCPJ81tET4/pV7nof5ziuF0XaytSDHwpTLp35vH7+yFeMnWRfCncj6904M2ULMl0T+II33VnS5HxJH9raMKT1pAXth3/0hLCKCNdC+IBqpe5UhRbadgaPXYz6OllAZzZddm71/HsyfOWbqbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y/ohsvz7RMYZ/9dWDuDSvtZTZRcuZhJhikCKGjbfp9M=; b=YQykTkpwG/5Jd7e53JYnlGV3j3MFSztUhiE674oqoyN8TS/Hk+nVR1ePSiuvQsp6ff11GoekWXkKarwkMaErXfObHAJFjhl+rijNtt/OyKYL77pYpeNacExbF3ti6kl7i44msondXkwoOjuziEdLbe33ZRWAuHHAsPBAsVWcj1w= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <11b24761-9268-e647-7316-0bffb549ae6d@citrix.com> Date: Tue, 2 May 2023 10:43:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: Andrew Cooper Subject: Re: [PATCH 2/2] x86/trampoline: load the GDT located in the trampoline page Content-Language: en-GB To: Roger Pau Monne , xen-devel@lists.xenproject.org Cc: Jan Beulich , Wei Liu References: <20230502092224.52265-1-roger.pau@citrix.com> <20230502092224.52265-3-roger.pau@citrix.com> In-Reply-To: <20230502092224.52265-3-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO6P123CA0038.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2fe::15) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|PH0PR03MB6526:EE_ X-MS-Office365-Filtering-Correlation-Id: 5b78b9ed-f411-40b1-feec-08db4af1a8eb X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b+pmVU6BAQoYmnilQ1Y3dJZU9ngm4iugPpLPT2GOUiuQTuWtyrIYWulh6Wupzy7dlgna1BrcryknsfH15KjaMNIVLoKvcPu06kMhCkRBwHbmbvwLr2+yqTCYfpZ/hr4456s8WkwGb3F09rKnzcYtH4EeSk61y/wmNCY9xxXFJvPaX1IxSQ6DrWQnswTSDEFDP+nFQK9yUUH99MWuIG9MyKhGu2fwI/S7FilKP7sd6pCTe/TzNDKv2xjuXnDEIC/bp67IwxrzA8ixdKe1KOzqLmtRMiw4/xYhWv033ePqxKwQ15rvLckyYZ2UK4bFZQp/ZO88O7654yjlfngHnFOL2TNoaEs4M/KTrqLqnj1BQVy9k+Fg7Q7MNQ34RWfUQEC2yuCcpCQ6MLFla2fkN3+0j7ZgPn+CClZCc1CoBwA6ueeK+WTf6526b8Lbsy8H5bk1okRhLUN6NVQKi9SwpXeoc3Qw3X2RlCVCuMghjROPXWzlvlalwbmu8DlQpijChbiFEmXcVsjJq7bnV91ultPrFehLOm09BXwRAysOZf9HTqbdMhvimG0tmm6iLzpMy2FgyyVDMYsHTi2mbo/q12o8bzHbfaURJ+c3iEaTk8hfK+8JEReY8odVvYGi3iLPVu7kyNu5jZhNBdK/SIwdovBe8A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(136003)(346002)(366004)(376002)(451199021)(53546011)(6512007)(4326008)(316002)(2616005)(6506007)(41300700001)(26005)(54906003)(478600001)(38100700002)(66556008)(6486002)(66946007)(6666004)(186003)(66476007)(2906002)(36756003)(82960400001)(31696002)(86362001)(8936002)(8676002)(5660300002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N1dRdjhwalpmREo1N29mTWRRdmFSeWIxR3lCL3RxbUxPVzBxVGZ6L01JNkt2?= =?utf-8?B?VjNRcVdNa3ZRVGk2dUhhQUlhdkNzckhDZzNyTUhDMS9MLys4QUhaZ3A1aHYx?= =?utf-8?B?RzZkTUxwbEpIdW80OEwrZFRHWHhSQUIvQUQ2Y0Z6NGduS2xoWGs2WXBZNEN4?= =?utf-8?B?QVQvdVlnYVZvZ1dKaTFRa0RsaGVuaGNGbTdDQ2xPUHRLV1U1c3pyMTN1YWhm?= =?utf-8?B?TW1BVXlZYTVZRkJkMGZHRDk2YU44MmxNcTVtYUphSy9lR3M1WGVFVi9xS1N2?= =?utf-8?B?Qk9PSk9nWHhYT2w3aW5LZUZObjhJdDRtakhyelRzNUwvVlg2RUsrSExmckQ2?= =?utf-8?B?YkJxczBBRkorOGdGYldRZUU3NGNjS05NRHdRVUkwbTY2N3R5K1E5ZWFmTjNS?= =?utf-8?B?OWRJckQrVUsvVXZiS3VpUmt1bnNBdG1wYlNLS0FVUmJxSkY0c25iV2M5MXBV?= =?utf-8?B?T3YwOHpuMGx0Y2hoS0dDR3ZqSFhZcGhXTHRWZXZoay9iV3lIY1ArSWlMcFhD?= =?utf-8?B?aE40K0ZrVmFyNmZ6OEV1QXhtK2ZvaDN5NFVYcnR4OURmd2xGK3FzODU2Yk5u?= =?utf-8?B?REMzT2gwUmNZN1BHekRVVEhMRFZkclczZHhISTF5RGQwOUI3dzd2QU56U09Y?= =?utf-8?B?dkxIdGowUitKdnk5VWhEZHhwUjUyakJUakc1WUEwUmF2Y3VOS0JYWUNld3lo?= =?utf-8?B?SDVMSkE0NXlvZUJYK3QzYnBsTEIweWNlZGlRb2JDZjd3ZDlSSTd5TVhqTlRw?= =?utf-8?B?dXc1ZzFUblcxdW5VczZvRHJDT08yVWlPSkY4Y2RuUXpNbG9icC9jQkFmRzNK?= =?utf-8?B?NmlJcVcxbHo0MUdiT2VxektWRTFheXl3eFc2N1h3ODR3OTZ5bExJVm1aanhl?= =?utf-8?B?YWJ0dFJ6ekZkd29VOHJGWDZSNEF5L0VRL3NNTTZUTzdMekNqUk9KUWx6a3BH?= =?utf-8?B?dm96WGVlSkY3bFU0TlRlM29sTnJEU3BTeXErSDJpcmp5TVMxeVFSdGdaUDgv?= =?utf-8?B?N09nUDd1R2JTaWFFQnVTd2sxV0tUMnBJTTl2RDlGdzZLVlN2cEpJeWNMNnhy?= =?utf-8?B?S1FiTGxqajBZUVR0N3lQVXhXTnFWRHBMZWdUY1J3bXJEeURUY0hhU3lLVWM0?= =?utf-8?B?U3VjZy9pK1BkUkh6ZFk1bmNWZWszc25BN1k4dWJMcFZidmIwUkI3SnpBdi8z?= =?utf-8?B?aklabjVoWlpjM1hUYXV1bFlET1ZCdTdRSHdJRkdxK3puTEZQTkpCdGo2YjZo?= =?utf-8?B?YjdxUG94ekcxVUxSMzArZWs1S0tkR053V2x4WTVsYTJzVnhVeWhTd2o3MU1U?= =?utf-8?B?V1ppNk5qUjJKWmpWcm0vT2VGb2U1UHh3bm5Uc1QzOGhuQnA5cmlHd2xyMmQ2?= =?utf-8?B?NDlpNzk1WTBPKzBKdkxYTkpSQUl3Q2ZKc2cvOU9kRjNmNk1VSWcxalNUWnc4?= =?utf-8?B?NmRsQzdNU3FXR2FFaGk5alhRWHE3dk9VL3ZOWTZsdkdSeThyNHhFdFFVQ3hu?= =?utf-8?B?Y082ejd1QjQ3Ty9USjFwY3FiM21FQy9FNHBRa0htQ0tIQnltZlNyeENSeWlM?= =?utf-8?B?MG4vdzNCSkRnd0FsUUJpZzBKRVVRaFk1blpnMUkvQlpkcDR6aU16VzRaVGt3?= =?utf-8?B?OXBQSWJ2WjFXT0FIbnNpOE9XWURScUpheDRKVWo5aXN6eGhiS3JOZzJBRFhn?= =?utf-8?B?em14RkNWdWpxa1Fxd21laHJ6RWY1UTQvZERkb2FLaEV6VUU4NWpZRWFRMDF5?= =?utf-8?B?TFFIUFFUY1NSdEpCUGdiZDNLUGFZTXpBYUh1UnJwOUU1NUhWejB2aXoxNldK?= =?utf-8?B?SDl2cUNTRmJSQ2dFUHR6ZVcvMW1hZ3lqeXl3YjlEVjI0ODFFMzNzWGx5RXBU?= =?utf-8?B?eis4ZXdpOHBsTlZmMEJ5Wk5rVEdpbitIS21yRTZWend0SjZFVzNjMFpuTGQx?= =?utf-8?B?VCtJMk1zWVU5U1FNSkc5b2lJaEVnT2c5Y3ZzVXZQbGR0OFBiVzN1M04xVWk3?= =?utf-8?B?UytZMWJmSzBZWGExWmhWdURQdmhseEh3NXVTVkZvcmd4VzZROGtFTTU1dHV3?= =?utf-8?B?QWRIS0MxOFc3ek5mZml2cVVBZGdLaXYvOGhXQWJ5Qk1SWGlHTzFSMStoRUVY?= =?utf-8?B?WmhHWkNIODV5UVRoM2ZhSmk1MytOQTA4UDJQVHZvanF4M1dXVCtkNjgvK0pC?= =?utf-8?B?OFE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: mR/ESx0KRPO8Gqdntnpjc+du4dZtK2MZ/dUdT4GKUh6TK7nMP5p/5Tmx+HIjSEGGuGnFgkN3jmvnXMZ/gZd331TILLcC3y2U6Am92+W5+vd/PbgslZgC6JE5Ej2oOJ8L8eG44cZ0KgB8Wz+79x03TXL32OiysL3Y8SwnCUoxv+viQZdd4UaZc+c6s+fMFoKi1vcrkRQ6XmTE6icrn4lBgKE+Jdb3ResAKICcyfy5tIfw9Y9ez0M/NklkqlqZ3BkInPYkA5Q2yYkzeBvjXXjLxGF9Vp4lC4lwPk+4wlVjs7L9stJC0sK2Ht2/OHpSnMiGjnCfpXGD/waiRTq9etMPOTPmscPBH4zVEL4ExbrDpJDw1y3qmHZvD7HEYIjNMjZq2pI04ofMSO7S60hVU41mQdv8iA6P4XjMOV5EhytY4Srht/XfTFsSu1/dduCYsuEKAAdWsAiWJav5NaRprYE30utEzDeerJLa0+4+e3Tu4jVW0RVaKcJsKtr7bI07igfY5wAqN1xdspzy3yZcfaPiXJM8+2gUNKR338cu2IBqRw1PJXGppPJjO5YwaMzqT10B1U3rYwLPiTQdlKzxDimCsscP6WydtCtSMwA8MjLtGC+mnZSiofpjXODI01soAUqtCe3WBzBLKkBEgT2amPtSqjrI5CJ/7ucNKOSmEm5f2KSMLcyJSUoniU1/TSRokEYDWlQ74r/9pxOFadu8bzPYouddz+Ho3gV4nfbem4C72XEa6JNNNDPvvoCzfNGkNGPflXBR9fU1jUANrdiPgjBiXmMadNLdvxBdKXUlFWNssR01iPL2QoIwyDW0FJOGmb40 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b78b9ed-f411-40b1-feec-08db4af1a8eb X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 09:43:18.7160 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xXeHrFU7MO+zflkpkciGSm+fW9XThtRyqHW8rn8WjvylJ5YW2jYFZC2IKT43gYBh9QpAzBa8F92XBjNwTW+2tpAoOcG9lkxwX3Oc4b+xarg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6526 On 02/05/2023 10:22 am, Roger Pau Monne wrote: > When booting the BSP the portion of the code executed from the > trampoline page will be using the GDT located in the hypervisor > .text.head section rather than the GDT located in the trampoline page. It's more subtle than this. gdt_boot_descr references the trampoline GDT, but by it's position in the main Xen image. > > If skip_realmode is not set the GDT located in the trampoline page > will be loaded after having executed the BIOS call, otherwise the GDT > from .text.head will be used for all the protected mode trampoline > code execution. > > Note that both gdt_boot_descr and gdt_48 contain the same entries, but > the former is located inside the hypervisor .text section, while the > later lives in the relocated trampoline page. > > This is not harmful as-is, as both GDTs contain the same entries, but > for consistency with the APs switch the BSP trampoline code to also > use the GDT on the trampoline page. > > Signed-off-by: Roger Pau Monné Reviewed-by: Andrew Cooper , although ... > --- > xen/arch/x86/boot/trampoline.S | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/xen/arch/x86/boot/trampoline.S b/xen/arch/x86/boot/trampoline.S > index cdecf949b410..e4b4b9091d0c 100644 > --- a/xen/arch/x86/boot/trampoline.S > +++ b/xen/arch/x86/boot/trampoline.S > @@ -164,6 +164,12 @@ GLOBAL(trampoline_cpu_started) > > .code32 > trampoline_boot_cpu_entry: > + /* > + * Load the GDT from the relocated trampoline page rather than the > + * hypervisor .text section. > + */ > + lgdt bootsym_rel(gdt_48, 4) ... I'd suggest rewording this to simply /* Switch to trampoline GDT */, or perhaps with an "alias" in there somewhere. The important point here is that we want to shed all pre-trampoline state, and unexpectedly being on the wrong GDT alias certainly complicated debugging this... > + > cmpb $0,bootsym_rel(skip_realmode,5) > jnz .Lskip_realmode > From xen-devel-bounces@lists.xenproject.org Tue May 02 09:55:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 09:55:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528428.821555 (Exim 4.92) (envelope-from ) id 1ptmj4-0000AN-RH; Tue, 02 May 2023 09:55:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528428.821555; Tue, 02 May 2023 09:55:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptmj4-0000AG-Ob; Tue, 02 May 2023 09:55:14 +0000 Received: by outflank-mailman (input) for mailman id 528428; Tue, 02 May 2023 09:55:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptmj2-00008T-Ui for xen-devel@lists.xenproject.org; Tue, 02 May 2023 09:55:12 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6c208b24-e8cf-11ed-8611-37d641c3527e; Tue, 02 May 2023 11:55:10 +0200 (CEST) Received: from mail-bn8nam12lp2171.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2023 05:55:07 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MW4PR03MB6991.namprd03.prod.outlook.com (2603:10b6:303:1ba::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 09:55:02 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb%4]) with mapi id 15.20.6340.031; Tue, 2 May 2023 09:55:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6c208b24-e8cf-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683021310; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=Qx8TBmHioxfZ2IfV9j0Zp8QCJ6YrR0h3CkbpgUxzq70=; b=JS+WQs+LbidtxCcsJ5tY7QIz6WnKSAi0lDgPaQ+YYAd9pPyZeQsbuHhr vcAAWm1ByQcXNdin/9yXJdGNhwmdITtPKBonFfERMbpUt4Pee+4FtRj58 R1FYSJmm8QW0fKiLNqCFik+PlqZGe7184DvOkE4XcP2fA0/45BZkIRIsY E=; X-IronPort-RemoteIP: 104.47.55.171 X-IronPort-MID: 106310059 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:XROsWaC1SrjXiRVW/wTiw5YqxClBgxIJ4kV8jS/XYbTApGknhjNUz GRJWm/Sa66KazGgKN1+PdmxpEtU6MKDxtdnQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFuspvlDs15K6p4G5A5ARnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwxN1rWk5A9 scichcRNjKhvOWs66u3Vbw57igjBJGD0II3nFhFlGucJ9B2BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI+OxuvDG7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prraXw3iiANpPRdVU8NZn3lKy5lMeKyZMFlfgheXolkekSdFAf hl8Fi0G6PJaGFaQZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpatYrqcs3TjwCz UKSkpXiAjkHmKKRYWKQ8PGTtzzaBMQOBWoLZCtBRw1V5dDm+ds3lkiWEY8lF7OphNroHz222 yqNsCU1m7QUi4gMyrm/+lfExTmro/AlUzII2+keZUr9hisRWWJvT9XABYTzhRqYELukcw== IronPort-HdrOrdr: A9a23:h0CH5aFzSeLJsHu+pLqE7MeALOsnbusQ8zAXPhZKOHhom62j9/ xG885x6faZslwssRIb+OxoWpPufZqGz+8R3WB5B97LYOCBggaVxepZg7cKrQeNJ8VQnNQtsp uJ38JFeb7N5fkRt7eZ3DWF X-Talos-CUID: =?us-ascii?q?9a23=3AlgQC2Gpg1kzjKD4tDjd2qjrmUf4ebibywnTrGRW?= =?us-ascii?q?fFT5LaoaSU3SJ9Lwxxg=3D=3D?= X-Talos-MUID: =?us-ascii?q?9a23=3AEU0i8w7lQPPbA/lIUrOfdMWyxoxlvauPKH8Asq5?= =?us-ascii?q?c+MXfETAhJz6HnjeoF9o=3D?= X-IronPort-AV: E=Sophos;i="5.99,243,1677560400"; d="scan'208";a="106310059" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ge3XFzrOvjkaLOW5CW4t4OqEigzFSal0wso+vq/m4JXn4iy7VGM7L4/JeTvePz9wFYlHCQCDHE9fLABtjN4GCDPZaJtoFNyTyehh1PwlCirpWzXmo2k6mZN6wKXmucDLBeEE3lBdoa+8HkTrPacMNGPfstxh2hWfp6XbJB5jmyZWvIIK/Zecv9jY3PNOwdNEhLJMBxI81m+KR3pYDnlsSQyy6lhdNw8m7TLMfrGu6XRnz8GG2hUuxt4SwhGOI17kVwXs3NnxJJdp+NjM4jG4xo/PTAyk90upn0Ll62CNpcz2ru/WiQp+r9+EZz9QZ79PXre3aLGYCHeLdTnqeLTX5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gCtsbvuU7CzsbkqhJiHIMYUbXQSCF59o1g4jgrRizI4=; b=X4Cn1rGD9hcYqH7l0QlbmOgFeP2G9nDUMhCYTXhiLF7tZRpFTeRm1xGMdZJFjpWszCB4bVmuaHGDAVitxyEqv5lnnupSUuzivct2hzKQoid55nye4OLTpDaoxikRZlRuQ3oJ7lEVdMgGcj/mMBOmOa5WJtDHXN+HO45W8ir5SCbM52RK8ZBuRqYdWdJgongZDUFB45vv7Eb+dWwZ4GpPT9Z+9C1prLUTs5ACIp5ELSbXXS1D1GAkfD1h40a7aQ83WeVdwMC0TY1ouJi7mDDX7v2O0A57KJqfHx9oXrBChpLarN+XUEr0arWdQkbKSjwaXBsyU7lMurkT8u7eLVrNDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gCtsbvuU7CzsbkqhJiHIMYUbXQSCF59o1g4jgrRizI4=; b=mn3KEX+Gg4/7NnmdoKU8rM9CoDuV9uphxS7K1/0k5an7Eeujhqkr66OpMJZbt3HGQFgNyY6RMeYuymWtyH9/2cj7LHW+A8OIIloIZAGBPpi3J8CWUKYL0KOEb18qrtK2KKPEFw5wIKKF0QPlGwqxH07S+UVJbY7/mv3HBBhZqIc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <89389465-f32c-7dfe-f62b-b957e2543cb8@citrix.com> Date: Tue, 2 May 2023 10:54:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: Andrew Cooper Subject: Re: [PATCH 1/2] x86/head: check base address alignment Content-Language: en-GB To: Roger Pau Monne , xen-devel@lists.xenproject.org Cc: Jan Beulich , Wei Liu References: <20230502092224.52265-1-roger.pau@citrix.com> <20230502092224.52265-2-roger.pau@citrix.com> In-Reply-To: <20230502092224.52265-2-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0548.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:319::11) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|MW4PR03MB6991:EE_ X-MS-Office365-Filtering-Correlation-Id: e5ad664f-73ad-4be4-b6b5-08db4af34c22 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pmGua80B08hRyH53Ko8JNGhgKHDeitU/nI6vzr469AH2pGc/hr+iV8sa1fVBOWgzJl0lc+5qIgvIaVwNRS+ILbfASuQGW+jIuoB2gTB7gOfPDuwUjqT5ZCC+m9o2ZMojn3HMVRyLNSZbJ0rd26kACkhVVQsxsjNJJRJV6z1dl3nqST4QokuD8rz8bs/Cz2Disygs6wsSB2Zo/9gHTXgXQfinIgcltsGBpnZr1NpyrfIMEFHYhRsb1EVTXnsX8FgXF9BEQW6Wl+N7EO4qi2qsTc0iNadcV9ov8DrPbQTyJh6ZNeLDdCKSlyv9XblIsoek1/5FbCZDB8ux+BbXVWf1XLZ9aotf8s1C4UnvRTLPJYtOwOpzRZ5Lz2E0iG3rYAf8Euj7pB/e25rMXT1owhZ5NRZ2+UFqDPMuYw+CZuw+82FmkPvv9MP0UC4w5F47hKVCwISNVKg1Q0wpOAKN0Aza8JT8eX6n/afqUZkIiKkD1ofATKxjqZlSZGY9yE9mBzc4v8WtMSYh9ww+5LI1EAGXyVxjV1159Cbih89E5xRG5paFyl+WxnQ0prHHR1vnOWpiChz0xF9+mudjH7aioPhvFdIw+jjtYvS+93elKZity9szlOmzbyWOSYMf/rK/En0B2JFmskoPEAR8leijXamltA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(376002)(39860400002)(366004)(346002)(451199021)(6666004)(6486002)(83380400001)(2906002)(6512007)(6506007)(26005)(53546011)(186003)(478600001)(2616005)(31686004)(36756003)(54906003)(41300700001)(66476007)(66556008)(66946007)(82960400001)(316002)(38100700002)(8936002)(8676002)(86362001)(4326008)(5660300002)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cEp6LzZCNjJqMk5BT3Uxdkt0NzIvZ3A1SkVyU3pTVmw2U2lhZEVpZ2t0d1ha?= =?utf-8?B?STNqODEvZGJ3VTFxSzN0Zy9Xb0c0QXY2ZGtGQU5IdFFOM29SK3ZJOHVDWWg4?= =?utf-8?B?WmxZenI5ZEl0RmF0YmFYU2Y3QjFqK0pMdUVkeWZFWDh5Wmh0akNHUWkwSWps?= =?utf-8?B?Sm1lSTkwOVhaZzFOMUl1aGhyb1d2U01vY2Jya3g2ZnB6V1Z2YUh6REtMcTFS?= =?utf-8?B?bU9oa0tCQmJlTVgxaTBVeTNXTXlnakkxRlFyT1dxaVdiMituTGNyR2JDQTI1?= =?utf-8?B?TUk3VDdEdUlhb25kdFBHMFRhQ25FZkxrUmFzTEQ2VUVZYnI2eGYza054NGt1?= =?utf-8?B?T3l0WXl2bDdGQndjUzl3alQrRGVrM0hpWWZZbXhDbjRqbktnazhLOXpXbVBO?= =?utf-8?B?OGRDQndrb3JKeHR2aVJLL09FUzBYeTNHY20wYjdDcmZPNTYvZ2xILzRjM1BK?= =?utf-8?B?UE9VL3ZHYVhhdkw5VFNwNm5vSGVTRDdnbEgydDZuMVJmK0hFZHowWlp5OFZI?= =?utf-8?B?d05nWFBWRXlwUVpIbHRsSERoWTNlUU5SV0tJQ0NyNlJpVGE3NVpVNWo5eTAy?= =?utf-8?B?ZnFXQy9mSTI3NFpnY2pCMHJhaWFrVzBadXBMOVg1TjRZNXBwa21kSDZGYU5h?= =?utf-8?B?NjFiZ2FnL1hHKzNxS2xyT0U5aDR4UjRVMzZsbHBLMWRITS9pYVN5cFRlRkhK?= =?utf-8?B?WG4xb21RT1dKTXB0cmhrYVcxc2NYQTluZVFTR3lPZmZ2a1BtbENQQ2Y2b21N?= =?utf-8?B?bmpqdExLUEJhNS8wWWhDRmV1T0FGTDdBL2lmbHFwNmRCT2o0WEFTc09uZW9h?= =?utf-8?B?d1N4RFZjaEJTcGVoRDNjVVozd0ZOUHVUVTd5U0x4YnBJQXFiMXE4YXByTTdR?= =?utf-8?B?Zk4rNmF5a3Nocm4reDBUMWIxZVdRbUE2dXZuUDAzWStpRHd4VDcvRGZWbDdQ?= =?utf-8?B?UUxEOGJwQmF0ZDZmZFFlQ0VEN3E0REtnRS9Wd2QvSThaOUk0S3NyaytCR0tr?= =?utf-8?B?TGZpN0dXWDZNVjEwdHNKVFI5QkdHTmhMUmRROUVZcVU3T0lRUjdUbmdHT0xw?= =?utf-8?B?NHY5R3E0QUJvVXdPcW1wTk1oNlF3SDd5enhWdnltc1JULzdIVmx5VldneUVO?= =?utf-8?B?R2F1MUtuTjhUbllFYlV5SDdsM0dtQkZOa1lLaENabEhIV3BhdXNOQlMyOXhV?= =?utf-8?B?bmRkVy94R2VlZ1UrTzdvV3oxcGsyT09HOWFqVGovOXpWbkdzQnZXZWJYVkdz?= =?utf-8?B?d0RBMm00eGEyZm1CalhlNU5EV3ZNMHE0SUdYRHhoa2IxaXltelFJZG1lalkx?= =?utf-8?B?d0ExQXdTWkx4LzVhUWJUZDVZUWZxVXdlVVBYK1l0ZmZiaDU3WGpHWDVKRHYw?= =?utf-8?B?RnNyQ3ZBdzdWNmkvcHpCVW8rV3dQZStrczM4S1NOTklMVzdsMGdGa3JISW9H?= =?utf-8?B?Q1RaRmRhTGdiNkFEUnR5NTd6NUdFNzZZUm5aKzc0Vnd3WjBOZERXWXFjSjh2?= =?utf-8?B?T2huLzQxWG16bjJmbHBEQ1AwK2dmbm5jTjZvZGpZcTVZaDVlYWZTMkZ4RzE3?= =?utf-8?B?SHR1dDJRY3REODdMeXh3amI4OXdpQURDT1hEQThGd2pEb3dITUVKL3ZWdFl2?= =?utf-8?B?NXpzbjk1bDlMNEt0eFJWeTB0R1p0cDBBV2ovOElhb1lyeXJ6TFNUQUV5eVo5?= =?utf-8?B?UDJyZUFjQUFvdXl5WXAwcVdFRFdyUFNRMkw0TkxaY0R0Z2J1RmVrN0xoZHhM?= =?utf-8?B?NUlRRUZPZjVOMDU4eHlidnRWMDI0dnN5R2FSS3owZkIrcTI4QVlCS0lLRERT?= =?utf-8?B?TFFicEZKeGowNnpDSjdTak1HeEYxS0swbllXckwrTHZ0NEtESWVYQUpUaGU0?= =?utf-8?B?L1NvUXdpY1lQZDRkZnZUaWtsSTMvT0Z2WXJOTHNGYStGU1djdEgrdWtRMFhU?= =?utf-8?B?cGNyQ2N4OWVreE5ta0NpVEV1QUkycjBjbzlXdUgvVkF3T0RmV3VTTlVpSGly?= =?utf-8?B?em1TVWpGbEcvVVBYVTF0Yk9CN1V5QnVuTTl4MUlXWTFkSXlyWTBXdHNKRVhF?= =?utf-8?B?OHh2RU03ZngwdHM0TnFzc0RxbXIzWjF4bUoxTWcrQ3dCUlVTOFUzRWRDSDNR?= =?utf-8?B?aWVJWnd4WVZjR2ZtdXl5czVBbzZrWVJDSlZKODg4MzQxdGhyQnBEcmo4Vldr?= =?utf-8?B?bGc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: WZshAvxJx+55c6GyYgFZdYANBepGNXYiRauRZAORDSZHTfkEIwHjNK3gfsO0Mxn/UA2l9qGLc2ln3sMLtCxHa7mE7C6cC7O2NyQ4XvJ9HmuJMXesYwDJDVx4jpIM1AcfohG7xCUOmWfU7BatlmM6V81VEP51dUZJiY1M3PmI6ZQnJY9+PmKAfS9iRl8S2/41ZV2aoJe5hnhzm4XqjV6yDmUkiCaPiYrNU8jdiOFcZIsCFfjdiQDHbzvd8tqpNZcgiZuTgv8GvNxOtoMlUGy//mxuAEnfHfkeiiTrCLlzpWz63lT1uuBJuQgVLZcRwGoxk2Weg3FT3A5zTpBfIBD6X9K5tnlXU5pEMS+CcQuiR6sWMH+D5UtamA0xmKHtmeehBlbjRLdOGq35K4jhBs5uNsEzS9jpgT3bwadJr1dRPUiMGVa9QaBw95nbUJ/t+SYVsNYmNb70unS+RrrZxPbr/oYJlkPkhCWap2qWPLa4nBIFaV+svdrwZyQ7c7Z+FvJSbt634+hUjYK9vYc5CYbA9ffACn9y4EXp6ahdDWuvjivGLRdLSqPoyO7tQgy5KkubfIlpomVeo8DlwljhXTJhgqLzT8dpqsg9Up93Zo++2yjzNh+VLksqWrJV7k/JfNd5SX9krP40QlBYwG4Xl0FH3JcyRVpt30vwhvtkKnig3EwZiFTPLjF7ovp2wNzspRsd6QK6s8UnQ7obUQmu8CECVnVopWiTj5LhAcZp90o/DAtSvQxwXTagOG+jdBeuqCVSzV3z7aM2DZR0rR480iR9rLBN7fFGITfXkrw1YAmOtLGsskA14EA1B2iRCi6dGJEN X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: e5ad664f-73ad-4be4-b6b5-08db4af34c22 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 09:55:02.0767 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: siEj9Jwjrix2/a+saslokRLzV8SOqROU0XO+eH5owbKWpKmDtjO+6/zfe4kXkuVKIx4YsCkoEc4SUKSNpi10lzKhTnBdaK+nBYsePSY7Rvg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6991 On 02/05/2023 10:22 am, Roger Pau Monne wrote: > Ensure that the base address is 2M aligned, or else the page table > entries created would be corrupt as reserved bits on the PDE end up > set. > > We have found a broken firmware where the loader would end up loading > Xen at a non 2M aligned region, and that caused a very difficult to > debug triple fault. It's probably worth saying that in this case, the OEM has fixed their firmware. > > If the alignment is not as required by the page tables print an error > message and stop the boot. > > The check could be performed earlier, but so far the alignment is > required by the page tables, and hence feels more natural that the > check lives near to the piece of code that requires it. > > Note that when booted as an EFI application from the PE entry point > the alignment check is already performed by > efi_arch_load_addr_check(), and hence there's no need to add another > check at the point where page tables get built in > efi_arch_memory_setup(). > > Signed-off-by: Roger Pau Monné > --- > xen/arch/x86/boot/head.S | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S > index 0fb7dd3029f2..ff73c1d274c4 100644 > --- a/xen/arch/x86/boot/head.S > +++ b/xen/arch/x86/boot/head.S > @@ -121,6 +121,7 @@ multiboot2_header: > .Lbad_ldr_nst: .asciz "ERR: EFI SystemTable is not provided by bootloader!" > .Lbad_ldr_nih: .asciz "ERR: EFI ImageHandle is not provided by bootloader!" > .Lbad_efi_msg: .asciz "ERR: EFI IA-32 platforms are not supported!" > +.Lbag_alg_msg: .asciz "ERR: Xen must be loaded at a 2Mb boundary!" > > .section .init.data, "aw", @progbits > .align 4 > @@ -146,6 +147,9 @@ bad_cpu: > not_multiboot: > add $sym_offs(.Lbad_ldr_msg),%esi # Error message > jmp .Lget_vtb > +not_aligned: > + add $sym_offs(.Lbag_alg_msg),%esi # Error message > + jmp .Lget_vtb > .Lmb2_no_st: > /* > * Here we are on EFI platform. vga_text_buffer was zapped earlier > @@ -670,6 +674,11 @@ trampoline_setup: > cmp %edi, %eax > jb 1b > > + /* Check that the image base is aligned. */ > + lea sym_esi(_start), %eax > + and $(1 << L2_PAGETABLE_SHIFT) - 1, %eax > + jnz not_aligned You just want to check the value in %esi, which is the base of the Xen image.  Something like: mov %esi, %eax and ... jnz No need to reference the _start label, or use sym_esi(). Otherwise, LGTM. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue May 02 09:58:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 09:58:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528433.821564 (Exim 4.92) (envelope-from ) id 1ptmlw-0000oX-D6; Tue, 02 May 2023 09:58:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528433.821564; Tue, 02 May 2023 09:58:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptmlw-0000oQ-9m; Tue, 02 May 2023 09:58:12 +0000 Received: by outflank-mailman (input) for mailman id 528433; Tue, 02 May 2023 09:58:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptmlv-0000oI-Db for xen-devel@lists.xenproject.org; Tue, 02 May 2023 09:58:11 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d75d9f23-e8cf-11ed-8611-37d641c3527e; Tue, 02 May 2023 11:58:09 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7373A21D47; Tue, 2 May 2023 09:58:08 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3DD3C139C3; Tue, 2 May 2023 09:58:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2rIuDbDeUGTnZQAAMHmgww (envelope-from ); Tue, 02 May 2023 09:58:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d75d9f23-e8cf-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683021488; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=E3qmdns4q/cZ/NWmrzqGY03nxOPP2tMuMNz4jFkuKl4=; b=mBLYkkHJcOwd8p316DbLOqa2WVhMjfKHp1xXlIBJDCNwZ2l0o3I6E64A/AEVLOtfHU8RRh vjq4VkJniQ85luURpoMiGlxdQoooC9zcBaOwa+gpLJ9w1sVOL5rTB8rW3cjjnvHei9MozT iDFQzKooD/a8KZm8XwxVgHxSa0p28ss= Message-ID: <1d6010d8-ec3b-6b34-f031-5c0e68ebaf6a@suse.com> Date: Tue, 2 May 2023 11:58:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH] xen/blkfront: Only check REQ_FUA for writes To: Ross Lagerwall , xen-devel@lists.xenproject.org Cc: roger.pau@citrix.com, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, axboe@kernel.dk References: <20230426164005.2213139-1-ross.lagerwall@citrix.com> Content-Language: en-US From: Juergen Gross In-Reply-To: <20230426164005.2213139-1-ross.lagerwall@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------L7dAGg1Ytvh72l5dMzjFTHrd" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------L7dAGg1Ytvh72l5dMzjFTHrd Content-Type: multipart/mixed; boundary="------------EA7GBIwmE5skG7fSwXaPF5qz"; protected-headers="v1" From: Juergen Gross To: Ross Lagerwall , xen-devel@lists.xenproject.org Cc: roger.pau@citrix.com, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, axboe@kernel.dk Message-ID: <1d6010d8-ec3b-6b34-f031-5c0e68ebaf6a@suse.com> Subject: Re: [PATCH] xen/blkfront: Only check REQ_FUA for writes References: <20230426164005.2213139-1-ross.lagerwall@citrix.com> In-Reply-To: <20230426164005.2213139-1-ross.lagerwall@citrix.com> --------------EA7GBIwmE5skG7fSwXaPF5qz Content-Type: multipart/mixed; boundary="------------KMPQhgyXkctIaC4EjZvsJSnt" --------------KMPQhgyXkctIaC4EjZvsJSnt Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjYuMDQuMjMgMTg6NDAsIFJvc3MgTGFnZXJ3YWxsIHdyb3RlOg0KPiBUaGUgZXhpc3Rp bmcgY29kZSBzaWxlbnRseSBjb252ZXJ0cyByZWFkIG9wZXJhdGlvbnMgd2l0aCB0aGUNCj4g UkVRX0ZVQSBiaXQgc2V0IGludG8gd3JpdGUtYmFycmllciBvcGVyYXRpb25zLiBUaGlzIHJl c3VsdHMgaW4gZGF0YQ0KPiBsb3NzIGFzIHRoZSBiYWNrZW5kIHNjcmliYmxlcyB6ZXJvZXMg b3ZlciB0aGUgZGF0YSBpbnN0ZWFkIG9mIHJldHVybmluZw0KPiBpdC4NCj4gDQo+IFdoaWxl IHRoZSBSRVFfRlVBIGJpdCBkb2Vzbid0IG1ha2Ugc2Vuc2Ugb24gYSByZWFkIG9wZXJhdGlv biwgYXQgbGVhc3QNCj4gb25lIHdlbGwta25vd24gb3V0LW9mLXRyZWUga2VybmVsIG1vZHVs ZSBkb2VzIHNldCBpdCBhbmQgc2luY2UgaXQNCj4gcmVzdWx0cyBpbiBkYXRhIGxvc3MsIGxl dCdzIGJlIHNhZmUgaGVyZSBhbmQgb25seSBsb29rIGF0IFJFUV9GVUEgZm9yDQo+IHdyaXRl cy4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IFJvc3MgTGFnZXJ3YWxsIDxyb3NzLmxhZ2Vyd2Fs bEBjaXRyaXguY29tPg0KDQpBY2tlZC1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2Uu Y29tPg0KDQoNCkp1ZXJnZW4NCg== --------------KMPQhgyXkctIaC4EjZvsJSnt Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------KMPQhgyXkctIaC4EjZvsJSnt-- --------------EA7GBIwmE5skG7fSwXaPF5qz-- --------------L7dAGg1Ytvh72l5dMzjFTHrd Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmRQ3q8FAwAAAAAACgkQsN6d1ii/Ey/N oAf/Y0NoXQFylmrPidnUfvHRCcY4DCzY0QIQ9+y+7uP5XrvPp9yEpcikk7Oi2pkxcEpFL844n/uT rtZdjhhYqhTh95OSvyX04XfGWKT+uXoaBndQW3coqiuzneG0RZRzZoxCh8w/xdRqgIIdeSp0mkaM TlBnBrhOmlyC45Kevr5ih1jPO4pYf4PT/Qa71Iv0o47N2+O0IAOvLt4/N8eX3fgb2KicQoy4v48e CPFO2kz92vlwRR2IDriK/M7kYwDldrxfBwOOEWdtdcgY/+dorkTuCAmleq+3S413pC4eSh9+cZrq NzvA19d102W+gRexoEuAqZIb6FvlpaG7Y37nqWUSYg== =Uish -----END PGP SIGNATURE----- --------------L7dAGg1Ytvh72l5dMzjFTHrd-- From xen-devel-bounces@lists.xenproject.org Tue May 02 10:11:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 10:11:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528438.821575 (Exim 4.92) (envelope-from ) id 1ptmyX-0003Kh-Hf; Tue, 02 May 2023 10:11:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528438.821575; Tue, 02 May 2023 10:11:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptmyX-0003Ka-Ed; Tue, 02 May 2023 10:11:13 +0000 Received: by outflank-mailman (input) for mailman id 528438; Tue, 02 May 2023 10:11:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptmyV-0003KU-SH for xen-devel@lists.xenproject.org; Tue, 02 May 2023 10:11:11 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a64ff230-e8d1-11ed-8611-37d641c3527e; Tue, 02 May 2023 12:11:07 +0200 (CEST) Received: from mail-dm6nam11lp2177.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2023 06:11:04 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by BL1PR03MB6152.namprd03.prod.outlook.com (2603:10b6:208:319::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 10:11:02 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec%3]) with mapi id 15.20.6340.031; Tue, 2 May 2023 10:11:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a64ff230-e8d1-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683022267; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=YB1v6eMwKwthpuGEZUBw5DLY5WhZFvqP0KKlCoDLEa0=; b=I0Gl62pgNa4Ym33Rapcf3DZKSLE1644n9x0Y4MBFERZLAW25QqPYv29b 6bx/rHHGa12wBW+1hc8hV3I2id0p/MuTdzm7rbtLF2bxCfzLb7fVLn8VA BMzvN9jNrT+maCFtCU/iY1p1hPg6Vhvkr1EGg8Ndo5Y+uQ0uYBJJyGWpS A=; X-IronPort-RemoteIP: 104.47.57.177 X-IronPort-MID: 107440925 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:3jfhTaJOKm1AP97MFE+RHJQlxSXFcZb7ZxGr2PjKsXjdYENS3jxSy zBKW22HPf6LYWT3eNx0PoTlpB5Q78LXmtA2HVNlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPSwP9TlK6q4mhA4wRkPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c4pE11/6 8QiNwsDRQ6e3f+M8eKfFs9V05FLwMnDZOvzu1lG5BSAVLMKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dopTGMk2Sd05C0WDbRUsaNSshP2F6Ru 0rN/njjAwFcP9uaodaA2iv02bOTxXKhBer+EpWA0ONmm2XPxVcqJyYNWFip/6mwukWhDoc3x 0s8v3BGQbIJ3EyiTd7ndxS9qWyDuFgXXN84O/037kSBx7TZ5y6dB3MYVXhRZdo+rsg0SDc2k FiTkLvBBzN1ubmRYXuY/6WTq3W5Pi19BW0IaDIATAAFy8L+u4x1hRXKJv58FIalg9uzHiv/q w1mtwA7jrQXyMIOiaOy+Amehyr2/8eWCAko+g/QQ2SpqBtjY5KobJCp7l6d6utcKIGeTR+Ku 31sd9Wi0d3ixKqlzESlKNjh1pnzjxpZGFUwWWJSIqQ= IronPort-HdrOrdr: A9a23:BEak76mVvcyndKpFxTq8erpV/CrpDfLo3DAbv31ZSRFFG/Fw9/ rCoB17726QtN91YhsdcL+7V5VoLUmzyXcX2/hyAV7BZmnbUQKTRekP0WKL+Vbd8kbFh41gPM lbEpSXCLfLfCJHZcSR2njELz73quP3jJxBho3lvghQpRkBUdAF0+/gYDzranGfQmN9dP0EPa vZ3OVrjRy6d08aa8yqb0N1JNQq97Xw5fTbiQdtPW9f1DWz X-Talos-CUID: =?us-ascii?q?9a23=3Apkj6emsJRgvcs5uQjflRdlUw6It7YEHs0k/qPHS?= =?us-ascii?q?2Inh0EqCveA+0pIVdxp8=3D?= X-Talos-MUID: 9a23:HYAp8AnBXRDg4gGhU7/3dnpaEtpk+JzyC3s0vq4dtsqWa3x5CzyC2WE= X-IronPort-AV: E=Sophos;i="5.99,243,1677560400"; d="scan'208";a="107440925" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cdQ6UwkklcwRH6HDP8BBmJ7VSL0EAyT2Z6SbvPpZnm/Joe0fQRR4uxwRO+3GXQgIETw5uiHULHSCEB/pzwUEFFZQfQ+1zzcCe4kfGwcxI3ux5f9b3mHh9/+m7lFKeBaBRDRw5Wq3NnqQOQd2OieGk03+sDGdKOaSmapxYcVRPsHw/so7EJ9m+8DAr+gj0ea9TjO4dG+CKQkF7xY/FoNFNqn0cMzqVi/cPUuSgkogQD/eZ3uZYh5n7Sx0/gbshg7AE0u6odhmJNkyOsqO0aZk8wYBQI2qwuLobEh+PeZf04zEG/Eyk96sHz7WY4colqtBzJ4pVrYGz9CyAjC1MRg27Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6BE+8aTgQq0j7fMxCMU6txBUZTgnLVdNNaZi1+b/qx8=; b=MKzdG40lb+4c8WlZVMdGiPhPaI+GvBZ57ZVfu2Uz4lEjdchAJsqvf8q7ji8EwiJWq9zahPdoi0rd+c3w9cbQeHpLedbLhRc2AvCMB7LxZTL3axJBLj9qVpqEx0S/Zq+J/R+lLk9YHG2Fs08hffJepetEXlY2xc3wgRSGYNWmXm/KTarfLNv3nLg+CJNES+H44U2/BrNEQQUockcZoMoH97DCSfqNpHxhYMYsVCYc7z5IKLBno+8+Yu6kUSCV8SyiXOxcwHY7BtleosuYgx/2iVwLmcwf+1xdiwF/rj2B2FsoFj3wBIaq2PgA3TjdG47T0TnX0hJl+pzGf/NQCrvPwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6BE+8aTgQq0j7fMxCMU6txBUZTgnLVdNNaZi1+b/qx8=; b=okjlOUYa7lBuvRQVrFe70MaxR/1ZUdeiGVyyarlcvSIbfXiYzHHM3kSiTHxTlT+sSUd2TEB6WVNiIyw51A9Dsy6jbbm5N8Kqy/rBiklgXA7ZDpl+AbDxiP7sjz+9km4TcHmqHr7GvHaNKdxQgZvIHvFiLI2vT1MjHPX3hfiJxV4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 2 May 2023 12:10:55 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Ruben Hakobyan Cc: xen-devel@lists.xenproject.org, Julien Grall , Jan Beulich , Andrew Cooper , Wei Liu Subject: Re: [PATCH] x86/msi: dynamically map pages for MSI-X tables Message-ID: References: <20230426145520.40554-1-hakor@amazon.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230426145520.40554-1-hakor@amazon.com> X-ClientProxiedBy: LO4P123CA0153.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::14) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|BL1PR03MB6152:EE_ X-MS-Office365-Filtering-Correlation-Id: bc1c8ae6-692d-4ada-29bb-08db4af58824 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HmSr5/ajl6GJlEH+N7xomL2Yde8SuqG7qyrITcVvrYhblO1K88LKENs1UqafY9mxJkEibscftOI2Ys2BwCnEexkELfESbPc8B6Je0NmzZ4Osxj+p+yMijUKGxEO/A72unArE8S0oB8E9kGDAU4uGtXUyhM/8Q/y7ZhwpuCeglJSK3Be+y1SZKemz1ZC3TV5joYeFF1zcATMSZIj0j8/nEl9X/Bi5v6QDlzX6MLdC4ltsloPohz/fM3BATmIujAdNtCUXTz/AL469lKZzE3T0wPH5QUM7yPhCu0pGjK2Ty4SmPktWgeU31kDslOzHxuCRK/R7eVNr0VPXcfzvnm/c4TPyTlYYz+Au4/7Ka1j8wEWwPWW95WdYx3J6Xb/UrpbNeCb98O9W2q+InmK41DDM8k7FvOboTJmP0v5oukHK3ok9IG2S9D03Zy+5dQ11CIzKQjRM/ygUmu2UmKZ7k/+H82BoqMznTIbnCuy3N01+bQV4k2BRFem/+kRKRtXbJWeWf9KlN6jE/Y59eNdfcHiA0UgTmO7vsv2WASyN97EH6wuvw1qVQcqgPcUM95DRGOSi9z3g31YHl16qlFI4F8FufzFJDadKUgHzVjM+d3J5FF4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(7916004)(346002)(366004)(396003)(136003)(39860400002)(376002)(451199021)(8936002)(38100700002)(2906002)(41300700001)(8676002)(5660300002)(85182001)(33716001)(86362001)(6486002)(6666004)(6506007)(9686003)(26005)(6512007)(54906003)(478600001)(83380400001)(186003)(6916009)(66556008)(66946007)(66476007)(316002)(4326008)(82960400001)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SHVNOU9Yenh1eTJnbjl3allENmdKaGdybkMyK0JEenh0bk9TQW00VFdQbWhT?= =?utf-8?B?YTNOU3A5KzRBSkRUM2V6ckFLT2NMeERhbS9MMjBhNWR6cXhhVFUwcmR5OTlr?= =?utf-8?B?M3J6Z2MwQlhpZnJtWTZyQzFTM1RVODVuQ0IrNWFES3VsS2ZWdUlxNENGLzV0?= =?utf-8?B?UHZib0UySFdEQ29aRE9UV2lRUUh1ZTd6Q1dTVWFaVFRDWFYwMFB1YkNpQWpy?= =?utf-8?B?TlZCZFZmQlNoZFhiS2pBRk5lMitoT3RhUWRpYWRVZTM4emwzaThRblNpR2lM?= =?utf-8?B?bEYrU29CTDB6eWdLVW4rS08weXZCM3ZadmFWeDNtQ1F2UkJUc3poTGt6WDdv?= =?utf-8?B?VTdIR3gzRWRBNjlUSm1XclJYdENmTDJjYzNYN2lYK1J6Y1pMZFhiL3h5OVlw?= =?utf-8?B?NzNjYWoxNExFRnZLQkVZcVVSVmJRZ0hEWWlJSFB0elpTcVlJdE83RXZpMWMr?= =?utf-8?B?bDYvSDVHTW02US9TSk8wM2RHdEdLWGhkQzdQdnVrWTZBOWk5Q2ZoUXhYRHps?= =?utf-8?B?bXBoYVlqbW1SRUdGWDJJQi9zM1J0OFJZdE5DYkZKMWRzS0xmVmQwMEF4U1p3?= =?utf-8?B?cDg1bW92dG93NzRJZzl2T1ZUSXVENTd1cUJYN1lOZTFWRk9rbFJmZ1Y3dWpt?= =?utf-8?B?NFkzNzlXVXFLc2FxemlJV3ZHOGdGd1UzOTFEQ1oxdEdMelFGbjZncDdOaE80?= =?utf-8?B?eHU4Nnd4TVlTT0I5ZDdTUTBzLzFoL3BneUV2OUdtNUwwcWZaZDJEMjZoTmpI?= =?utf-8?B?a0VTc1pBRkZpTjRlN2JnS005allhb2pDa1JKRWtQditUc3diTEdxOWdwNUZn?= =?utf-8?B?WjZwRjY4YktjWlhIVTRFUU5hdmdYaU9DQW84cTRoSERBUEJUemNRanhFNUx2?= =?utf-8?B?ajN6SW9Tc0RlTWh0elVERWFQTmk5NXJuZXFhMHFOWUxCcmRIblk1eUJ3czRp?= =?utf-8?B?NThuUnF5SjgvWHdKbHYyajNuT2EwdHVyeE1yTmtpQjFSbHRidmVDNUNzZGdP?= =?utf-8?B?VFY4NDluTHcrUVBPRTg0Z2VRT3dPdWp2UTZuc0tWalBnRWJSSGFJUzFENXFG?= =?utf-8?B?a2QvclRKNG9MYzNTdGhOajZJM0FheVJOcWFlZjZIVkdTN0FzSWRhWUxOMjNJ?= =?utf-8?B?N0F3dXdWbVk0b0JVcU44R0lrUGpnNEtBZkw2YlZCTVNtakw1SkVvdkNTUUNv?= =?utf-8?B?a09jSExUUGJmaGxwZy9DYTIwRWl3RlpqSHltems5VEk2ZDcyVVgyT1pvQVdl?= =?utf-8?B?ajYzVFdUZzgwSVp5Z1BEQWdqM0wyWEp5d0l6NnpTNGRpTE5CUFNTNzBWaTdr?= =?utf-8?B?Z2tKbGk1bHgyR0dnMXVSdzVkZ0M3aUJYRTF2S256d0tDUjh3UE1TQU0xditG?= =?utf-8?B?cEpxV0ZGaHhPYVFVNXQ3bTlkbGpDY3czbFhIaE5MYlArbUt4NVZkQWxyWE10?= =?utf-8?B?akxyWHU3djlkRnE5ZG1CY0lzRXFUZGh3cHlPT1gwdkpEdXdDZUY0M0srZmdY?= =?utf-8?B?VEtNb0VwdkJKWUZuMlZyNEREbVRiaFQ1OFdPRWtjOEU0R04zeDdmTzh5ZndO?= =?utf-8?B?ajRKclEvdExZL1hrU2VhVXVUa2lma2NzNEVqVHRnMjB5MkRZUWlHa0I1VURF?= =?utf-8?B?cUVibVZBMlgwSGZYdEVDRDJJOEJYbVd5RTdpR05FOGNOSkZYVVF2WFJveVlX?= =?utf-8?B?bHZ3YWdEaXBmU3VpeUpLN1ozaDFhOEhmOFcwMlBhRGZKTUJRa3BLMjd1citi?= =?utf-8?B?YzAwS29xRjBVbU5RMnQrSGtGYkFRdW5wTHdhTitSZHA0dDVsa1JXRzRQWk9z?= =?utf-8?B?VXRyd1BUaXBCZUVWc0VNK3drYk1rY2pxQkg5MGZIM3lyNnZ0Y3I3Q1o3U3M1?= =?utf-8?B?b2U1YjFmRFA0d1NsRG1pUXdyR3BnU0FyUmwyaTRWSlZlWEhlYTBKSm1nUjls?= =?utf-8?B?dlo2bElIVHVuUk1rT0RBNTBjTDIzRytCUElBRU10WkN1Tkdta1NBZ1UyU3FQ?= =?utf-8?B?dkhlUE80enZMRStLL3J2cVNRK1V1d0FTY2JITlhITCtURUt6MWUyVHpvVWlj?= =?utf-8?B?dHhFZUI3UklVUms4QUhWTFc0V2U3akswOFNJcHZMaHBMQjhPOTRwb2pzRnNw?= =?utf-8?B?bE5VZFJuNnJJLzJHSTdRSVZHUGpVSGpuZlZEb0pMY3JzbEV1T2d5ZEc3TVdz?= =?utf-8?B?MlE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: pcZGgg7v4i8B5Xx7rE+cYCqVHTSizMlAgRybqlQxFqgEDf1LrhWNlaERK/AK6Pa0JXrFvhvB6PPlLOO+CVpaE0zsbU7tQ9jhPe6zGYIZWMsuACY7HWIKXTs+Gp7n7oC/D7QqbiT2efHPySthhVaH+gf1YYkBsoZVHxLeMiwmzW2XEnvIkzOlDuAmdzqD92NgGtxthcDYIogPurrt6Xv6SrlI6Vaqr/HbYxzqFUltrgebeJKliXZP0HjQ3xjyEW2Y5v4jqxX3NzygjxKOO20aDY+BJb9U8KbQ5oPM++L2wMvD2X9yO9974b+yDUCtTq5xQe2CkR9olLFGaR8qV8Yl4mZ4lxja/rXutLo6DJzzNFGs456zay8RPlMoxcWqkupUH9H6Ync1hS+tfVqMeWVh2+uCFkmjctGU12r3PBMbpyMBNLW7BKo8SWh2MgckIwaSFEjq0wXhUubb+8EwYgvGoYLB5P62ZsilHIGWZv3PFwTi0/Sy5cM2CGUdOYNngu5AJHY3RjO0j5XLeB3q6Om5zt3HNnBepB3UUQmNn3r8EKQUnv13aLiKyW3cO2LQnfwFr64VQOR4KGjc7v2PNLBVOPOlkhBhkbA12zuq3nDKLSzzswucCHU1j114wZROtWTJ9XEogxEH+NuI160+d7vb3HZXOFnI5l1Fhr5/ZoEenu30rSQriMkYrNulO5pN40l7sqTpHm1IR6WhdVM8XEkRoq13R6RsnJ7A0BAuqDSzNOW9W+6LV3k1KUkq8floLpqMr0OP90ch0k7B7E8Vn8ECmv+LtP9RFnxCkU0h5pId73nuGkptR0/wWT+KCOgfujhZ8CtesNGXNE0152zFCtv2eUs9iLS4zPCbliiFgXezpQc= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: bc1c8ae6-692d-4ada-29bb-08db4af58824 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 10:11:01.6296 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: d/orvhqYJj8m3AZYWHpyR4VDBfH6rOhT+ZEI36dCkr6KDK+r51VmRv+QCxhR6I/kNcGLoJ+TYMyqsxf2lBhcDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6152 On Wed, Apr 26, 2023 at 02:55:20PM +0000, Ruben Hakobyan wrote: > Xen reserves a constant number of pages that can be used for mapping > MSI-X tables. This limit is defined by FIX_MSIX_MAX_PAGES in fixmap.h. > > Reserving a fixed number of pages could result in an -ENOMEM if a > device requests a new page when the fixmap limit is exhausted and will > necessitate manually adjusting the limit before compilation. > > To avoid the issues with the current fixmap implementation, we modify > the MSI-X page mapping logic to instead dynamically map new pages when > they are needed by making use of ioremap(). I wonder if Arm plans to reuse this code, and whether then arm32 would better keep the fixmap implementation to avoid exhausting virtual address space in that case. This also have the side effect of ioremap() now possibly allocating a page in order to fill the page table for the newly allocated VA. > Signed-off-by: Ruben Hakobyan > --- > xen/arch/x86/include/asm/fixmap.h | 2 - > xen/arch/x86/include/asm/msi.h | 5 +-- > xen/arch/x86/msi.c | 69 ++++++++----------------------- > 3 files changed, 19 insertions(+), 57 deletions(-) > > diff --git a/xen/arch/x86/include/asm/fixmap.h b/xen/arch/x86/include/asm/fixmap.h > index 516ec3fa6c..139c3e2dcc 100644 > --- a/xen/arch/x86/include/asm/fixmap.h > +++ b/xen/arch/x86/include/asm/fixmap.h > @@ -61,8 +61,6 @@ enum fixed_addresses { > FIX_ACPI_END = FIX_ACPI_BEGIN + NUM_FIXMAP_ACPI_PAGES - 1, > FIX_HPET_BASE, > FIX_TBOOT_SHARED_BASE, > - FIX_MSIX_IO_RESERV_BASE, > - FIX_MSIX_IO_RESERV_END = FIX_MSIX_IO_RESERV_BASE + FIX_MSIX_MAX_PAGES -1, > FIX_TBOOT_MAP_ADDRESS, > FIX_APEI_RANGE_BASE, > FIX_APEI_RANGE_END = FIX_APEI_RANGE_BASE + FIX_APEI_RANGE_MAX -1, > diff --git a/xen/arch/x86/include/asm/msi.h b/xen/arch/x86/include/asm/msi.h > index a53ade95c9..16c80c9883 100644 > --- a/xen/arch/x86/include/asm/msi.h > +++ b/xen/arch/x86/include/asm/msi.h > @@ -55,9 +55,6 @@ > #define MSI_ADDR_DEST_ID_MASK 0x00ff000 > #define MSI_ADDR_DEST_ID(dest) (((dest) << MSI_ADDR_DEST_ID_SHIFT) & MSI_ADDR_DEST_ID_MASK) > > -/* MAX fixed pages reserved for mapping MSIX tables. */ > -#define FIX_MSIX_MAX_PAGES 512 > - > struct msi_info { > pci_sbdf_t sbdf; > int irq; > @@ -213,7 +210,7 @@ struct arch_msix { > unsigned long first, last; > } table, pba; > int table_refcnt[MAX_MSIX_TABLE_PAGES]; > - int table_idx[MAX_MSIX_TABLE_PAGES]; > + void __iomem *table_va[MAX_MSIX_TABLE_PAGES]; > spinlock_t table_lock; > bool host_maskall, guest_maskall; > domid_t warned; > diff --git a/xen/arch/x86/msi.c b/xen/arch/x86/msi.c > index d0bf63df1d..8128274c07 100644 > --- a/xen/arch/x86/msi.c > +++ b/xen/arch/x86/msi.c > @@ -24,7 +24,6 @@ > #include > #include > #include > -#include > #include > #include > #include > @@ -39,75 +38,44 @@ boolean_param("msi", use_msi); > > static void __pci_disable_msix(struct msi_desc *); > > -/* bitmap indicate which fixed map is free */ > -static DEFINE_SPINLOCK(msix_fixmap_lock); > -static DECLARE_BITMAP(msix_fixmap_pages, FIX_MSIX_MAX_PAGES); > - > -static int msix_fixmap_alloc(void) > -{ > - int i, rc = -ENOMEM; > - > - spin_lock(&msix_fixmap_lock); > - for ( i = 0; i < FIX_MSIX_MAX_PAGES; i++ ) > - if ( !test_bit(i, &msix_fixmap_pages) ) > - break; > - if ( i == FIX_MSIX_MAX_PAGES ) > - goto out; > - rc = FIX_MSIX_IO_RESERV_BASE + i; > - set_bit(i, &msix_fixmap_pages); > - > - out: > - spin_unlock(&msix_fixmap_lock); > - return rc; > -} > - > -static void msix_fixmap_free(int idx) > -{ > - spin_lock(&msix_fixmap_lock); > - if ( idx >= FIX_MSIX_IO_RESERV_BASE ) > - clear_bit(idx - FIX_MSIX_IO_RESERV_BASE, &msix_fixmap_pages); > - spin_unlock(&msix_fixmap_lock); > -} > - > -static int msix_get_fixmap(struct arch_msix *msix, u64 table_paddr, > +static void __iomem *msix_map_table(struct arch_msix *msix, u64 table_paddr, I think msix_{get,put}_entry() might be better, as you are not mapping and unmapping the table at every call. > u64 entry_paddr) > { > long nr_page; > - int idx; > + void __iomem *va = NULL; > > nr_page = (entry_paddr >> PAGE_SHIFT) - (table_paddr >> PAGE_SHIFT); > > if ( nr_page < 0 || nr_page >= MAX_MSIX_TABLE_PAGES ) > - return -EINVAL; > + return NULL; > > spin_lock(&msix->table_lock); > if ( msix->table_refcnt[nr_page]++ == 0 ) > { > - idx = msix_fixmap_alloc(); > - if ( idx < 0 ) > + va = ioremap(entry_paddr, PAGE_SIZE); You are missing an 'entry_paddr & PAGE_MASK' here AFAICT, or else ioremap() won't return a page-aligned address if entry is not the first one on the requested page when mapping. > + if ( va == NULL ) > { > msix->table_refcnt[nr_page]--; > goto out; > } > - set_fixmap_nocache(idx, entry_paddr); > - msix->table_idx[nr_page] = idx; > + msix->table_va[nr_page] = va; > } > else > - idx = msix->table_idx[nr_page]; > + va = msix->table_va[nr_page]; > > out: > spin_unlock(&msix->table_lock); > - return idx; > + return va; > } > > -static void msix_put_fixmap(struct arch_msix *msix, int idx) > +static void msix_unmap_table(struct arch_msix *msix, void __iomem *va) va can be made const here. > { > int i; > > spin_lock(&msix->table_lock); > for ( i = 0; i < MAX_MSIX_TABLE_PAGES; i++ ) > { > - if ( msix->table_idx[i] == idx ) > + if ( msix->table_va[i] == va ) > break; > } > if ( i == MAX_MSIX_TABLE_PAGES ) > @@ -115,9 +83,8 @@ static void msix_put_fixmap(struct arch_msix *msix, int idx) > > if ( --msix->table_refcnt[i] == 0 ) > { > - clear_fixmap(idx); > - msix_fixmap_free(idx); > - msix->table_idx[i] = 0; > + vunmap(va); iounmap() > + msix->table_va[i] = NULL; > } > > out: > @@ -568,8 +535,8 @@ int msi_free_irq(struct msi_desc *entry) > } > > if ( entry->msi_attrib.type == PCI_CAP_ID_MSIX ) > - msix_put_fixmap(entry->dev->msix, > - virt_to_fix((unsigned long)entry->mask_base)); > + msix_unmap_table(entry->dev->msix, > + (void*)((unsigned long)entry->mask_base & PAGE_MASK)); Did you consider calling this msix_unmap_entry() and just pass the entry VA to the function and get the page from there. round_pgdown() might be helpful here otherwise. > list_del(&entry->list); > xfree(entry); > @@ -892,10 +859,10 @@ static int msix_capability_init(struct pci_dev *dev, > { > /* Map MSI-X table region */ > u64 entry_paddr = table_paddr + msi->entry_nr * PCI_MSIX_ENTRY_SIZE; > - int idx = msix_get_fixmap(msix, table_paddr, entry_paddr); > + void __iomem *va = msix_map_table(msix, table_paddr, entry_paddr); > void __iomem *base; > > - if ( idx < 0 ) > + if ( va == NULL ) > { > if ( zap_on_error ) > { > @@ -907,9 +874,9 @@ static int msix_capability_init(struct pci_dev *dev, > > pci_conf_write16(dev->sbdf, msix_control_reg(pos), control); > xfree(entry); > - return idx; > + return -ENOMEM; > } > - base = fix_to_virt(idx) + (entry_paddr & (PAGE_SIZE - 1)); > + base = va + (entry_paddr & (PAGE_SIZE - 1)); Now that msix_map_table() returns a virtual address, you could likely do the adjustment in there an return the entry VA from msix_map_table() or equivalent? (see my naming suggestion above) Otherwise please use ~PAGE_MASK. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 02 10:15:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 10:15:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528442.821585 (Exim 4.92) (envelope-from ) id 1ptn2Q-0003wF-1l; Tue, 02 May 2023 10:15:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528442.821585; Tue, 02 May 2023 10:15:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptn2P-0003w2-Ub; Tue, 02 May 2023 10:15:13 +0000 Received: by outflank-mailman (input) for mailman id 528442; Tue, 02 May 2023 10:15:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptn2O-0003uZ-UF; Tue, 02 May 2023 10:15:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptn2O-0007dp-Lk; Tue, 02 May 2023 10:15:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptn2O-0002Ue-9S; Tue, 02 May 2023 10:15:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ptn2O-00058k-8z; Tue, 02 May 2023 10:15:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2g68SVldXs+rOMPJbKUl2N0VuAvUCUTq6+uUs0fULe8=; b=QwsKgDmQC+CSzqfTo8bvkSa66y 1CAHgg39kl8tP//BxtIDfOpn/jABZIUmxAkR9mCoppLlFrK4f39zyWCeJkSFJkvDNmaA+nc5HVOzf xJAywC6+20nahHqJCucTO56kEJWDUgzh2hjxav9lbdk2Y28ApU1/N/rz5RkQJCwcOe+U=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180500: regressions - FAIL X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-examine:reboot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=865fdb08197e657c59e74a35fa32362b12397f58 X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Tue, 02 May 2023 10:15:12 +0000 flight 180500 linux-linus real [real] flight 180503 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180500/ http://logs.test-lab.xenproject.org/osstest/logs/180503/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 180278 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 8 xen-boot fail like 180278 test-armhf-armhf-libvirt 8 xen-boot fail like 180278 test-armhf-armhf-xl-vhd 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-raw 8 xen-boot fail like 180278 test-armhf-armhf-xl-arndale 8 xen-boot fail like 180278 test-armhf-armhf-examine 8 reboot fail like 180278 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180278 test-armhf-armhf-xl 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180278 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail like 180278 test-armhf-armhf-xl-rtds 8 xen-boot fail like 180278 test-armhf-armhf-xl-multivcpu 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 865fdb08197e657c59e74a35fa32362b12397f58 baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 15 days Failing since 180281 2023-04-17 06:24:36 Z 15 days 26 attempts Testing same since 180500 2023-05-02 01:41:05 Z 0 days 1 attempts ------------------------------------------------------------ 2156 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 261762 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 02 10:18:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 10:18:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528449.821594 (Exim 4.92) (envelope-from ) id 1ptn5h-0004a8-KA; Tue, 02 May 2023 10:18:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528449.821594; Tue, 02 May 2023 10:18:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptn5h-0004a1-HZ; Tue, 02 May 2023 10:18:37 +0000 Received: by outflank-mailman (input) for mailman id 528449; Tue, 02 May 2023 10:18:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptn5g-0004Zt-NH for xen-devel@lists.xenproject.org; Tue, 02 May 2023 10:18:36 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2053.outbound.protection.outlook.com [40.107.7.53]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b1db14ae-e8d2-11ed-8611-37d641c3527e; Tue, 02 May 2023 12:18:34 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB9212.eurprd04.prod.outlook.com (2603:10a6:10:2fb::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 10:18:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6340.030; Tue, 2 May 2023 10:18:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b1db14ae-e8d2-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CsLNfOW1W2yiuCDCNHqvfGcAigxhKI7kO4AessEpqaxhab5srP/+E8y+Yh4/it4dufy3efTI1scs8ER7ickA5l6D1fqANu8uXIdM1a7Hj+9DHv1qn+2wKku6qKJMS+ZaTWacnoJSRYtCeuM5pbpYO4faYnXfELAtMt2SmKtAFUKeaYozSFH7yZaEPfoM/Fx2xUUXJnoaCS02LhhtPzSoMinLJ71sVx54jFREmPsYHxB8RlTtUBckXNKuyTXvlouyWOQAUvUNe+6v6si2Mw4scsYZ9dbkMNFFfiJaNh+nQPWxj3scBLltxvRvZRjhYhou/qjJzBYuVix6O7kookIL+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xEep6J3w5rqH6AHqUm58pv5LcYpdYtdRvkslNxU9Hi0=; b=lMeeamR4dnJZj/VHRXu8MtVO8ydL97TGdNi5I3NEMy2EoRktlPNgOFnujmAlcIbCamd6EePztNBb6+r/wUcfkFapt1Fvvti1ZHyCb1a6k6OivUYfWV1g6gudpuDAiJNMbWHm9XpDMGSsk68TGG1+MZE21JMJoLytrIKs18koCgIEx0c+1cO/R/OkFEeab00oBMLjJwAT0eSTcy7nTxLEjahnbab4wK5WKpdMVKL5VmufEh8kR9oywbg7FpHv/0e9zGEiSqx7/yevFB+kHdtjLq3X4cDBg6g6YJsP+wz+HdkzBvoFcsyL8mKQZAjZh4bgMq+IiG3XtkQkrZS5L7/AcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xEep6J3w5rqH6AHqUm58pv5LcYpdYtdRvkslNxU9Hi0=; b=NsFcYmJCBrPUKSNjnb4uarYtiTGM0UAYFIYa85CNeR+hA0JMB0fGOVIliOkbWoOOy5Nr1SjLgnpdyUnM/YFUf8KUJXrKybHClaSpapLXnbrD2NujVcBHae/X2lg7K9Md5xMvC9VQtEfQ7+7K/Q72X3TBxH11VmljkjnKpaEEKVYijzTp/1hJTl5TEZ0aamCidRLv0JvhFBnjzavaF/8zuRrLBwolMHMkPP3APf5Ln+zLQqLQjJu7Dgs77CTI4AImAR8IXbmzADJNXf123SrLBTrtkO7WAy0IsneVpX9ZMrHe0gX/gB1rVPI2+HQLpflSfpMyzK4W7imYe58ljUjcHA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 2 May 2023 12:18:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH] x86/msi: dynamically map pages for MSI-X tables Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ruben Hakobyan Cc: xen-devel@lists.xenproject.org, Julien Grall , Andrew Cooper , Wei Liu References: <20230426145520.40554-1-hakor@amazon.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0100.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB9212:EE_ X-MS-Office365-Filtering-Correlation-Id: d4a28759-f6c7-44a3-ed54-08db4af68461 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6KXk2MXMRFBBbxd2KsQxJO3YW5FFhIwGYFrPNRypPOzhHUjagF6Ty+U5LUMR9cj1OAughCW/HicA27D0GhotIam21W5vCZmM8e7mqHAVVo/kyEtjZapMGm4b8+MhtmaSPUP+XFNJ37/ntSg7pCxoqtcUkZNKXtiLJK4qz4+MAwc0mmQVnfppBABAjZrTLoEGX1d39EBUlmCFLMMQFcTMnvFS1EgJKi0s/qDHMC3dEbLiJh6hZZx57XODXYhQhIhHTGKR8Rbvj8DfYLrOoNgCjbZdRdCmJWNSgEHqLTWK+x8s2UhhDxGDKxPVf4ccJBR9LMU9jSueNnP6LCSmV58CdDoKeV8Qcl1jqzSX4YPV9dfwobcr9aHbv9Q5HqRzq8qnjPlZp4F6uJCIw0NqjS5XLPO9ew5B8WbuXRfAbbrZwHeqHGFkuS6HSg9pSfk0sdpAr3spdE7PZ9ylJipyEjyZGOjqWH4aP1QJu+SHJvuvR3fSTvnEm8aSASosZb4BgMLxniJVQjgE9Kghfi9RaKDjLHXMvLDDKWqwPWz1jVL0JYXvDzXX0bdYl4PEaCO/R71WEO4K4fVVUicS211SsKwUajszehktqV9eP1pyQy64/8VPiiGrOUcMDk43FVgzHPBSnzlsPs0POQs3TS6qs/XJQA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(366004)(136003)(396003)(39850400004)(376002)(451199021)(31686004)(6486002)(66946007)(66556008)(66476007)(4326008)(54906003)(478600001)(110136005)(316002)(86362001)(36756003)(31696002)(83380400001)(53546011)(26005)(6506007)(6512007)(5660300002)(8936002)(2906002)(8676002)(41300700001)(186003)(2616005)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b2YyR2x1WjAzeEtEVEJsWlNLdnowM2dpK3RJRGFoYVlhTGlTN3dZUUs5dFh0?= =?utf-8?B?TTBicmtrUjJwK245Z1l3UjNYdHgxVXJ4aWdZNVd3MkpWZzBHUTJveHpTaGxG?= =?utf-8?B?eUN2akthOE5TOW8vUWFabmNkNFZQNU00MmtaTXFSeUZvYzBCQWpSeWZQNTdF?= =?utf-8?B?QmdvaWgrQ25iZVN6QjR6VDJ1cEVLdjN4UFJSa3RHeWd1ZW5QZXV2cDQvYTVU?= =?utf-8?B?amxvaXczcHhYejhHV3VINEFuR2NZN0ZxU3pVbEVnV2ZvM2pEK1VPb3V2MVg2?= =?utf-8?B?aVFzc1E2V09hRWx6SkR2a1h5VlZlUTcxUTFGb0lqUjVQcWpIbHUvVy8vNkpz?= =?utf-8?B?bmZ4K1ZkWWJvVW43a29hYThER1lwYVZ5ZHgwenlTU0RBN3dCSG94YlpOQS9z?= =?utf-8?B?aWNNTzJhbTNjdGF0d3VVNWlKQXhtbDZZeWhQcHgxQ0UrSWdlSDN4RStxQUp1?= =?utf-8?B?NldBR1ZPNGI4SDBSU0lTVWVBVEY0ZGxOcjhydU9uYkZKU1FLNmoxbjBsQU1k?= =?utf-8?B?bC95UHNXS3NmUWsxVzUxRGlWcTMyeXZWRE45VkU2MTBoUm5WWTh1OHQ3c3po?= =?utf-8?B?WmxsdFhHdU1hZmZaSGd5SytLUVJkek1EcWJISVp5cm5Oa1oyakNuNU5CMFVm?= =?utf-8?B?MnozRFAxczhreTFIb0c2aDNWWVlFWUdybUZRRnpvU0VDMFYxVFhhdjgwQ0tV?= =?utf-8?B?bGwvdGQ1YVZaQjk4UzJheTlwUzJvc3lPMTNnMXphMlhFRTZzNW1nbm9FQ3R2?= =?utf-8?B?ZVdzSUF3dG5raVE1cGpmdGFFaS9zTjF6bDBZQS9pZWtSVnkxZU5scFVTS3k5?= =?utf-8?B?QlQ3d085OVJxQ1dGSU9GeHZnTDJOZHIraUJpaWt6QjdUbU9lamRIOHZLM1B1?= =?utf-8?B?bm1vWjhLa2c3eWNCN1dGQ3pJc0hCV0NXRytVNmo1YUx0Qks4WlpkdDVNV3pP?= =?utf-8?B?VGxJS0hVNFhFS2N1UUsrRFI3OTVxbG9wOEdMN2tITndVbTN2dFFIV0djdzRN?= =?utf-8?B?anFwMEFSbDBSd2h4STRPMHVVUlFrYUNRRGQzN3hIa1dWaGRuU2djN1ZpVFBj?= =?utf-8?B?V1NqbVVjUHFDejd2dGRZVGdGZld3Q2t4eVVFeURpVmV4L3M5QnJURTIydlJn?= =?utf-8?B?Rmo1Q0tRa01vMEgxSlFhVGxNa2hucEVGeGZlTGhCWkhVaHFiYzBaWHlVeVB5?= =?utf-8?B?am9XbWUzMTkzY3lLTzM0Y0YxUWFvbnF1a2hkcVhtdFc0UTc2aWxyYlVZNHJF?= =?utf-8?B?WmtGZTk1ZkozZGFJNFpBMVBwZzNLTFZ3WDhrUlJsSGtDbGVtT3JQZDUzZGNx?= =?utf-8?B?ck9tLysvTWtMY2pqVVhNMFlkS0ZPQmZVQWZRYVBkbTZvSFJUSExJOC9TTHNU?= =?utf-8?B?ZVk2TStUQy8rZS9zUjBRR2h6a05ZTmJMdGhYUEFXL0Q3Wk1JekFQSkU3S3RJ?= =?utf-8?B?SkZYNmVwZVJTb3NQT0Y1WVNOWStVbmZJMjV5SlVyVmJTamwzMXpnbzJjSjZ2?= =?utf-8?B?R01KZklYUXhUZ3p0eEpsbzdpZEdLZDBxbWlNNUZuTHpLN1YveXpBbFpnZGFO?= =?utf-8?B?Mm1UTWQvSW1ZRjBuZ091Q1V6QW1oSmIzKzh2Y2JDRWNPKytQSUU4ZlRmYnZU?= =?utf-8?B?R1EvQ0p2azliRlF1RjlDL25DYkg3OE9XTHNqRnNUS1UyUVBtU2twSExMb0JW?= =?utf-8?B?UXFGdmhoTEQ4NlMxVXEyWjh5b3dTVmdEZW11RGpQYVlDWmtCN3RnQk0wS2pX?= =?utf-8?B?MVAwQkE5b3RnSDBSY2c3SjhIRmMrcC9tNTRnR3VySFB3VExnaEp6MkRlYzA3?= =?utf-8?B?Uk9QSURObTBoMDVUTVJ6NnFqMTZzSktHR0xiOVBZcjVxK2dhVWhtbjFtRUpY?= =?utf-8?B?dWlpVWY5OUZjWWFTKzNDZmRqSzZ1c3JidEVXa1FPUFBIb21TWlJMTEY2aUZl?= =?utf-8?B?OG5mN0JxYVBaWlQ5UXlwaDMyMDhybkRtbkFFRVVzSWp3VWZ4Q1NYcTJhSHp6?= =?utf-8?B?dHdheXR2S0NxYXFyb3JmN2VqMjJTT3pDT0tmcFF5MU5wQ0ZucHcrTDZMM2NV?= =?utf-8?B?cVNzZms4dTNGcTEyUWlZQzVrRVR6UE5ockZnNi9pWUNmUUNGV2M2RHdSLzFo?= =?utf-8?Q?nXd3bMQedZtN7NIG5hR/zoClQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d4a28759-f6c7-44a3-ed54-08db4af68461 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 10:18:04.8553 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9R72a0Hf6PwzwKaBPqgw+V77gQGse1nWl3+k++TGoTltIJdOXLquUPaHVCbqfa7pUOaKcsffi5JnVNIarsZAGA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9212 On 02.05.2023 12:10, Roger Pau Monné wrote: > On Wed, Apr 26, 2023 at 02:55:20PM +0000, Ruben Hakobyan wrote: >> Xen reserves a constant number of pages that can be used for mapping >> MSI-X tables. This limit is defined by FIX_MSIX_MAX_PAGES in fixmap.h. >> >> Reserving a fixed number of pages could result in an -ENOMEM if a >> device requests a new page when the fixmap limit is exhausted and will >> necessitate manually adjusting the limit before compilation. >> >> To avoid the issues with the current fixmap implementation, we modify >> the MSI-X page mapping logic to instead dynamically map new pages when >> they are needed by making use of ioremap(). > > I wonder if Arm plans to reuse this code, and whether then arm32 would > better keep the fixmap implementation to avoid exhausting virtual > address space in that case. I think this would then need to be something that 32-bit architectures do specially. Right now aiui PCI (and hence MSI-X) work on Arm targets only Arm64. > This also have the side effect of ioremap() now possibly allocating a > page in order to fill the page table for the newly allocated VA. Indeed, but I think the (vague) plan to switch to ioremap() has been around for a pretty long time (perhaps forever since 32-bit support was purged). Jan From xen-devel-bounces@lists.xenproject.org Tue May 02 10:20:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 10:20:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528452.821605 (Exim 4.92) (envelope-from ) id 1ptn7t-00060v-0x; Tue, 02 May 2023 10:20:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528452.821605; Tue, 02 May 2023 10:20:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptn7s-00060o-UY; Tue, 02 May 2023 10:20:52 +0000 Received: by outflank-mailman (input) for mailman id 528452; Tue, 02 May 2023 10:20:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptn7r-00060g-UY for xen-devel@lists.xenproject.org; Tue, 02 May 2023 10:20:51 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 024749da-e8d3-11ed-b225-6b7b168915f2; Tue, 02 May 2023 12:20:50 +0200 (CEST) Received: from mail-dm6nam04lp2044.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.44]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2023 06:20:41 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by PH0PR03MB6365.namprd03.prod.outlook.com (2603:10b6:510:b4::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 10:20:36 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec%3]) with mapi id 15.20.6340.031; Tue, 2 May 2023 10:20:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 024749da-e8d3-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683022850; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=QthY+tIi41uwnnmCkFKwhmW5dSImhl3K8J/XmWvKTNU=; b=YUFqFKdjI4af/+8jL5JnGwkm4QM7zdTiTE5TTtCKU9qsd0nFJcL1mOUZ mSmzc1/Dl/krqj1BQnxqOY+eO2uN52CEgt2xxRDfOB7xdyFxOTcWpjqiX sVUXFg+aTU6kXQDgfEVSrUJVsH8wZAKfV1xiqhsQgaEWjRQdoD8tDGp4B 0=; X-IronPort-RemoteIP: 104.47.73.44 X-IronPort-MID: 109995977 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Habe7a8MTkRijJFO+LkpDrUDp3+TJUtcMsCJ2f8bNWPcYEJGY0x3z DYcUT3TbvfeazHyc4txb9ixpBlSu8CAztVlGlQ++Co8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kI+1BjOkGlA5AdmOKgR5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklVx 607BG5WVSykuP6o+rODFLVogJsseZyD0IM34hmMzBn/JNN+HdXvZvuP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTeIilAtuFTuGIO9ltiiX8Jak1zev mvb12/4HgsbJJqUzj/tHneE37eezHKmCd1NfFG+3v10oW2u9mo6MwdMCnSCjeCouE/uVvsKf iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwBGAzO/Y7hiUAkAATyVdc5o2uckuXzso2 1SV2dTzClRHr7m9WX+bsLCOoluP1TM9KGYDYWoISFUD6ty7/IUr1EqTEpBkDbK/icDzFXfo2 TeWoSMihrIVy8kWy6G8+lOBiDWpznTUcjMICszsdjrNxmtEiESNPeRENXCzAS58Ebuk IronPort-HdrOrdr: A9a23:SxfA3KOoRp2gzsBcT4T155DYdb4zR+YMi2TDtnoBPCC9F/by+f xG88566faKskdsZJhNo7G90cq7MADhHOBOkOss1N6ZNWGNhILCFvAA0WKN+UyEJ8X0ntQtqp uJG8JFZOEZZjJB4voTL2ODfuoI8Z2/1OSNuM+b9nFqSGhRGtNdB8USMHfkLqWzLjM2dabQ0f Cnl7t6TkGbCBAqR/X+PGABQ+/A4/XTjfvdEGc7Li9i0hCKkTSrrJXnEx2Uty1uLg9n8PMZ6G 3YlA68wa2mv5iAu3jh/l6W1Y1ShNzijv1cA8CW4/JlTAnEu0KTfYF8XL/HhhAZydvfkGoCoZ 33uhI9OMY20X/LYW2vhhPo12DboU0Twk6n80acnXzg5fP0Xyg7Dc0pv/MiTifk X-Talos-CUID: 9a23:D9bsjWOn/4SGYe5DQxs212JKQfsZVULB0k3RGxHkDWA2R+jA X-Talos-MUID: 9a23:lkR0Kgu0B0F3Xvi7gs2nhy9DBPpY5Y2VEhpSvqwqoti2NHx9EmLI X-IronPort-AV: E=Sophos;i="5.99,243,1677560400"; d="scan'208";a="109995977" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C6/4yz/mBnEpw2zxwgYZIvgNZtvQ2q5nABzETJDF5P8tK/zRNMPprX+G0C3jvFdb/NuybslwByN1Gp3TXRfHkcE6Ej0GglL1+O39zKNFrBM5MEnXqX/mlhHnaEDKSbOLXqk+1oNjwkbNXOo1uBSq+DkOxo8GivxVjo8t614XlD+NgkSB1wtrNAyRD9kSf1Ny2E0lncQlt5aYOP5dsQSzg++00E2Sc6o7FoshTX63bzfrPUS8C5tSQ+wz3VVN0fb+RJKWQG6Eg2mD+/q0ijpb4bYoqsEdcPvEKXQ7DK7pC1FUWbJEAqxdCPKNuNXBZ56RD32tZKBpOR8MEzVTHJAzjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pb6iw5cLRiSuesUXK7CeQp6i3v2ou/42Org036m02Yk=; b=S8/4/DgxIfVfrL+NibJ1ygKKsLDQqYhXkPYIqyxzIj3coOwiCxii2VYBzt3WfGF1HkiZ/ZOtuPgfIDCBv+qDpbMxisZXrxrNfFLwAnS+3M+SiN1JAgCCmZi4ngtkiwU0AzU1gGyRueJW3giPn+enq98i+/6ZjI0nZg/r9TSAIpq+UeFQ39ZgNeuBCLo5ASuKGu88gdZEL2r5YqBrj1KjbORo5kilfAvEY7idrZwvawUjYYPkr0T32T6KXt62rBXprJWZjoYiiEpULmIu2uB3KLo35kIHjS81sRKpZOrVhuvICYBX4Bfy4zg3fCrk0kHFrj6YsPN3+rKzftwxQGY8yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pb6iw5cLRiSuesUXK7CeQp6i3v2ou/42Org036m02Yk=; b=iZvJhwSOiAp7jcue6DfVWsg/i3htYt3HgYbyxmrlnIMBbo5fhtC1O9EB9B2uIRMa7JpM39j4+G96vhqkXWOuqaroS1hT1l3i7cKGkr+FQnXpCGkK0DhDoLWB/bTBDRQa1baypxki616bqkf3JkypO2gDBZ+wtZl0KfV5nJhXpA8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 2 May 2023 12:20:31 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , George Dunlap Subject: Re: [PATCH] x86/mm: replace bogus assertion in paging_log_dirty_op() Message-ID: References: <104c3456-03bd-37be-627b-45e614a616c1@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <104c3456-03bd-37be-627b-45e614a616c1@suse.com> X-ClientProxiedBy: LO4P123CA0291.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:196::8) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|PH0PR03MB6365:EE_ X-MS-Office365-Filtering-Correlation-Id: 387bc84d-1553-447c-a90c-08db4af6dec4 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9Hxk+rzzi6C8vhVIkAoS3Us4QvgmE6AJFqEKyG4AV2qp9kAtncdQ9AAZ1c4j/dFWv9EoPoJXNkKe8ASiTTkZacqpUhL7+Tb/plne8XCBUU+uyMkHv3AbBr9SrT1ay2JQuKCi8TZuU51bgzaH2jYzvVK3/cWFqJdMoTpJxggG7v+AQISi4bGDFyWUxD8Y7OyVoNNYroRzPEt0aNJ20k+He0nntg20/h9Ip8g8cojYZMXaC/TT9UF8NW7dNYLUNRowOloPoKcxNWDMGU/Qhb6KegksukvwPv6L8U3A6MdSD34G8rivkh5tcUWb+SBNfxN4BAjunNCBLCXwiMvJRRM/iNtpC0uifx20klZc+zQb4gST3HHEbnpARhSNtMYhQWJqJMuiEZykiU53XnbuTOeKx9vNdQuX7XYdPwN14vFs2zWnEchuQTe8egzIuCBoy0F5MYKUxDR+WIMEBnho2LX1BGRNsISFeh+QXykQeMJHmq1XE3MY2GYZoIciYH7nLRZ0spLg0XTi8bGUpG2XVjQ7GwPUf6Sm/NNQl0XmBuBymKBkuQOSKB1pqycqR/6GY9Isr9WiE0IBDhzO//tOTYdIAr8CeKFmFqRR4f/UmN3j7ek= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(7916004)(4636009)(346002)(396003)(136003)(376002)(39860400002)(366004)(451199021)(2906002)(86362001)(6486002)(4744005)(66946007)(85182001)(6916009)(4326008)(66476007)(66556008)(478600001)(6666004)(54906003)(38100700002)(186003)(5660300002)(83380400001)(33716001)(8936002)(8676002)(6506007)(6512007)(26005)(9686003)(316002)(107886003)(82960400001)(41300700001)(14143004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OUdNT1k2NEx4b091cTdWdVlyd3dLR0NCS3FVbmxmdjQ3RFpvVHQySHdacUc5?= =?utf-8?B?UURybk04ak50VTRlMnhXUzBwTm95KzdoSndZbzU0NnowdzJhQzNVM21MK2gr?= =?utf-8?B?c3VTVVpQeXFiT0RmalhqakNOZTNpYjN3aFcrT2d5ZnRGN21qQk4zT3dJUGxP?= =?utf-8?B?bllUSTJBSTFJcXBwOERTZjZzUVZqdStKWmlhend1aXJ3eE5jamMzNUZ4eWtB?= =?utf-8?B?Q3lTcWVmUmRNZkMyd2RGQWR0R204SGFsZ2hiNkdHUDFlZUNVVUZRNzNLdEQw?= =?utf-8?B?OG10ZVI3aWo2TW9obndWK3JkUWszb1VwQXB1NnQrUlZEMStuWEVraVYxWnN5?= =?utf-8?B?WjRTdzhIODl1RlNKb1JYVHMrSXQ2b3hVNm5BbmRnaDRBdnJsQitjZTZPZ0I2?= =?utf-8?B?UFVmbjdLZWFma0pCU3FzQXZtRFEzaXV4OTd6ZGtyMks3ZE5ianMzSXVvRHNt?= =?utf-8?B?Lzl5Z1d1QzNkWWlpM3UyU2VUc0Y3b0toZ2h5cFIxU0hGYTU5aGN0aXpNY05a?= =?utf-8?B?WmU4SVVacWdsM0h3N3g5ZlpwUUc2Vmd6Mkc1REsvTk9VR0h1RG15QitDRFlz?= =?utf-8?B?Q1NSUm0xOHkzQk5lV3JIeXFIYWtXOUlGY05SekdHTUs1dG96R2VuaEVHREts?= =?utf-8?B?SE10cE01M0laTnFtYTVsSy80dlo1dm56Qm5QWmhTUndiamxEblFmMjF0aU5r?= =?utf-8?B?YmZGOVFQM1I3b2xydnFlbFRHTkp3UkhoYkpodmk3cU9nZXFDUytIbmR3VEVp?= =?utf-8?B?Q3NkMEtaMmlpZm9FeTh1YWVuTVVIY1d6VThyL3crMHRFVlN1SVF2cGYvWmFo?= =?utf-8?B?RUVwQnp5MEYwLzc2MEdqKzNNYllnM0N6UnpodnJyaHdjUFhKbkZ0bDcyaVdG?= =?utf-8?B?ZGhNRXdkWU9melpUTUQxVGVPZVZnVXlNZFlkS2NNdXcyYzZ1eWEyaXMwQVFP?= =?utf-8?B?TVFCeWQzejh3ZTdXeXQ5dndJMGZ3ZkN6MmlCWHlJd0FiYkEvZFg5ZTYrc2FK?= =?utf-8?B?MEduZldYOU9XU0FLMWpTTWNjcTN3TmtzUm5CT3ZOdm41N3ZycG9lSVNMczND?= =?utf-8?B?a1NuU3FqbDZQZFU0TTlBMVEvZWRsZzdvR1E5cmpuWXJuajFnMzFKY1cyNHlY?= =?utf-8?B?aHBrMGE0TWJYenBEdzJEZUsyTHU4SjlEZUhQMjFZb2F2Nk9SYzVpTGhzWnRU?= =?utf-8?B?Q1JqTkgzWTRvV1piZDBwVElvdFdVeC9jNitNQlpTeWNLNURnQkJ6eEFUWDJx?= =?utf-8?B?V0ZtR0dKY0k2UzNTSnBHWk1HZDdVaGJqNC9WZlhqRXFKRTZ6YmcveEtweWlH?= =?utf-8?B?YWRLYnRwZXhMRTB6ZW5vR3VhQ0pFem5pcSsyNUw3UDdFU1lPM2NUeE04MVQ5?= =?utf-8?B?WTRTTTJQOE5yeTl0c1ZtQlY4ZmtDbG8vcUtITThMLzVxR0NNWlBTYS9Fd0o4?= =?utf-8?B?RW1NUW9IaFp4WkVQRWljU0VzN3hINWpPdVhjaTVHUUpTQ1NDbmI2SkxDMGR3?= =?utf-8?B?TWI4RW5ENEhJalFxUzlXR2Y2VFgxM0FhTTh6T3RCa2NYV1FTMGYxbnJQcU5K?= =?utf-8?B?dTFacWhKMGhYYkl0QlFuQlR6ZzUvN0VvVDNkcmcrQTIySWI3eTZDV3cvOTNV?= =?utf-8?B?L2VCNkxsTnJpd014ZUlPVDZ4eGNPa2RXZHEvdHYwL0dtS1kvUWJLSExGL0tV?= =?utf-8?B?emVpOGxPOVRxQW9rZjMwdVJHUzNOZjc3RnJrNm5hUmxHK0hBaHJsdDFjTENX?= =?utf-8?B?NmhxTFd0Vy9LR1N0cXpGMDFhd3BQSkJONHpZdHg5V3RyVHB1STlZM1RYM1Av?= =?utf-8?B?Z1czaTVDdy9IYjBZc054a052RThSTlN4S3dMY0VpTWxteXVFMTRGYkNlU0ZF?= =?utf-8?B?OFk1cDJOTXlFZTl0SVEya1hCeVc0YWVkTVF1OHF4YmN1MFpYTStaL3dKNm9j?= =?utf-8?B?dTREeWd4SWozMnVNVWRMa0FwV1V4SDBKWVZEQXV5QVdYcndZMVNHYkorMktv?= =?utf-8?B?a2kraDcvQXRoZWNWY3c4bmJjRFE3Mmx5b1duNXFDM0dnYzNUSlZ3YUlZa0FL?= =?utf-8?B?aFdXM01vOG9tK1J6VEtWYi85enM0Z2JDeXFaQTRvNDRpSzdPaGVLMHdOUTBU?= =?utf-8?B?eEdDV1BxblRydjlHNnh2Snc3NzlPdDArQm4yNEpVeGd0dkFiYk0rcTNIQWZu?= =?utf-8?B?Z1E9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: xX1/mzD8NEsmBdiCe9WOULWX6EQxYc0o1MhdQRESFIpvoIJwdUa4O8sbt5GAJIfQaj6zAmDJqhOsg9SRrVNp9v3Hq8s9BMK6vGk7nTIshd1TCxK5JKD0z1u6TMTT9/ghxTWyXvuHlMabn5FrmLqLY49sYQzGrdDfWXwIt9SknPGPkpx11LtOyRFTHw6CvsKqvjwjCU9WI3z5RU0YbwbfIB0bEbIKvOMQwUUcJ7/01EEM4P/jv4KSUvepFJfzwefPDWfeLmM8CpKEoqEqCM5ALwQ1uxxsjK2e50cxgGBBOucWmucVl9m0rnKXK1mBgsrNq3lUXDDisrKOjkzzxQEik6xzs/7wrldviuxMjuqUbtLvjw3oEP9aWjB/8WcktAjI9cZkwYPAiBRP3utgOleVj3t16S3mI/ZB98LFoZQ9aMdJsvRB1pwat0SnsE1URdFb0Y+n38BHwGOREbVxTHqPS9iYcSJGs8OrMNsGgwKzEgDSAlYDLMzrF7MiR86y8WJ0qti8KSV8+vBCUQ6khcFibhSMXpZU/lInqKWlf2yLgql9Y9abu0X1EgABW0wGgKyn8C+kPMSNuU9MI5SKejT2A9YtfgpGtrObfqmVfHJR3eQEvtvZyaZOP2JhLHZDBVujKv8A6pdgNym1efFxrxoWm5cZD4zFdTWXE/v6V1GRADGSBa5j4OO/m5d3rguUPnvSU1SW7NNzyMaiSQza7MU0cq88r4fDY/QOllxz8T6Lp95g8JaqxS0WelixmcuyrQIxfvnUQXAq4iw0PMudUJYbIecr+uZJWEQdwMCNamPJ0p+04Be23+OL6szVZj6Nvabs X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 387bc84d-1553-447c-a90c-08db4af6dec4 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 10:20:36.4575 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: D3BE+uF+eLJjkh5VZPQ1G53u2SryNFd90jhiW9qTPqISdM1ksUWhwc+7/IMvW1Cxsm6uA8K4ROrtOyBsHrXP4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6365 On Thu, Apr 27, 2023 at 02:29:06PM +0200, Jan Beulich wrote: > While I was the one to introduce it, I don't think it is correct: A > bogus continuation call issued by a tool stack domain may find another > continuation in progress. IOW we've been asserting caller controlled > state (which is reachable only via a domctl), and the early (lock-less) > check in paging_domctl() helps in a limited way only. > > Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 02 10:22:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 10:22:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528455.821614 (Exim 4.92) (envelope-from ) id 1ptn9a-0006aK-BR; Tue, 02 May 2023 10:22:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528455.821614; Tue, 02 May 2023 10:22:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptn9a-0006aD-8r; Tue, 02 May 2023 10:22:38 +0000 Received: by outflank-mailman (input) for mailman id 528455; Tue, 02 May 2023 10:22:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptn9Y-0006a7-CQ for xen-devel@lists.xenproject.org; Tue, 02 May 2023 10:22:36 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4072e5d8-e8d3-11ed-b225-6b7b168915f2; Tue, 02 May 2023 12:22:35 +0200 (CEST) Received: from mail-dm6nam04lp2042.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.42]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2023 06:22:32 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by PH0PR03MB6365.namprd03.prod.outlook.com (2603:10b6:510:b4::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 10:22:29 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec%3]) with mapi id 15.20.6340.031; Tue, 2 May 2023 10:22:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4072e5d8-e8d3-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683022954; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=8pxjHqsBCnAU/Z0MEF3vX67moRg3lWkjDnto3SsiKW8=; b=fL0XBs5qKwHY1p6HaF1FU5IcRpBO3wIQ8r+8hQXppMYMvUw/P55vtBAv qeQEIsg9peUdECSZHPN/SfmR9ItKLsz1iBA4YOm1Cx8bYoWq8cyqq2k1c FowySZgnD74Odfhkomu41qyVX7QrTA9y0Qz4bR+chVEufece/s10zOLEF c=; X-IronPort-RemoteIP: 104.47.73.42 X-IronPort-MID: 107961572 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:dQDlkqKZ8uCw3zWWFE+RE5QlxSXFcZb7ZxGr2PjKsXjdYENS1TUAy 2EdWzuOa/uJYmH8Ko12OY+29k4GvZTTzYAwSgtlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPSwP9TlK6q4mhA4wRkPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5MOW9E3 9IIJQsfYwmeoeGa7KuZaNtz05FLwMnDZOvzu1lG5BSBUbMKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/VspTSJpOBy+OGF3N79YNuFSN8Thk+Fj mnH4374ElcRM9n3JT+tqyrz17GWwHyhMG4UPJCl0+5WjG+q+nACCz83akmn8MC2qVHrDrqzL GRRoELCt5Ma9kamU938VB2Qu2Ofs1gXXN84O+0z6waX4qPR6hSeAC4PSTspQMwrsoo6SCIn0 neNnsj1Hnp/vbuNU3Wf+7yI6zSoNkA9L2AYbCsAZQIA6svkpsc4iRenZslnOL64iJvyAz6Y/ tyRhC03hrFWgctV0ay+pQzDm2j0+sKPSRMp7ALKWG7j9hl+eIOue42v7x7c8OpEK4GaCFKGu RDohvSj0QzHNrnV/ATlfQnHNOvBCyqtWNEEvWNSIg== IronPort-HdrOrdr: A9a23:sVKx66DDcePI6ujlHem955DYdb4zR+YMi2TDtnoddfUxSKfzqy nApoV56faKskdyZJhNo7690cq7LU80l6QU3WB5B97LYOCMggSVxe9ZjLcKygeQfhHDyg== X-Talos-CUID: =?us-ascii?q?9a23=3AO5Y1qGt+t6rmJwm6Qa7sRVfX6IseSnPX5lnALnS?= =?us-ascii?q?qBH90br65ZUay2pF7xp8=3D?= X-Talos-MUID: 9a23:NeYeiwuEedxKDw3sJM2nqSxHJPtk0Z2SFFEOs7Q5qdXVDCNTJGLI X-IronPort-AV: E=Sophos;i="5.99,243,1677560400"; d="scan'208";a="107961572" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ThYnrfHIJ4NgPMGG2tGutv1oBmV8nHlsAOplqEVjFfSTWwifAIeWh5WKll3tMrJZ2sNctShM1HPf4GgBsa90t+W/Gm2AKfE8hw/+FTmpJc1HMWbO0uE/qhnRLvNxQT7/U/3aEp4CEOipZd2NeHk93AH7e5MqEX1E2H0b7BdbzJufMRcCb9XMzjL1DJX9Orc334Cqgdx7v0vTTB4Pb48qcoKRHJyfXPQ5yAEUDp6m5UALW9nvD1d5fd/vD6TOBqIvbJ1iqPoAgxl9V0L5dqBiKdG/Tlba00DGzj5rZKDcoGlRsAOaIdItwr4kWRauYcYtlkRUoAZhEsbHNG5h9gULhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qUgTXWvqtxnPedM06EBb+hHJ66G71f5SwjS/Ezmc6+Q=; b=W6tkrahJ5zOLIBGGd/70YMKuOv1s4JyiQYUQHgtOpeatO0gibls+h40U5kaFCeTrie8ps4z6C2l99NiBs3vVD2gbRawP5ovbP/19g+fHr5/VzQG5IHqL9v7Wo6roLr/ZUy8Neffc3yPwUMJ4O1TldJ08PENecyUJswXnVZVO1vyQqykLuEAte3Ik9PKt3QiNwqVCKf6YdqU6kozicPYbHwT7kMwvq8kLXOTJ3H+/WBU3GIdxIU5AVEoBZgEHK6PQWblxdHrlnubMEsyzOVLe2Ydrvn6dyjIKy8MpFa/pSkKruTVE/XEUPvEDuDw0oPms5gfbO7Rz4PjvDQJNQJHnaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qUgTXWvqtxnPedM06EBb+hHJ66G71f5SwjS/Ezmc6+Q=; b=MkmmDqCl6yb9nOy/4q/pCN+ft9X5YmMcetNyNGLLL1T0RM0QzfpuzwysWlYiCOG6eS9IzcqIUuUhrkAPwam4ONz+Kmn/VN1HOTvmYwFDFnXjUMbXeP1r2j8ydbMGitR7vtrBC1g9+5BeRU5lcU3fxs0wn2nyHCgeoPnAh6xPrMo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 2 May 2023 12:22:23 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Ruben Hakobyan , xen-devel@lists.xenproject.org, Julien Grall , Andrew Cooper , Wei Liu Subject: Re: [PATCH] x86/msi: dynamically map pages for MSI-X tables Message-ID: References: <20230426145520.40554-1-hakor@amazon.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO2P265CA0459.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a2::15) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|PH0PR03MB6365:EE_ X-MS-Office365-Filtering-Correlation-Id: ed040652-597b-4d65-9abf-08db4af721bc X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: r6fApPOMzwTFMHaYgEyM7KVZW0mvUbssuwY1jWB7WWWCITK7/lQ8hdPtGmXGj6ZfVaBcqa40dscoE4qJttF+mTKORdA56F/DJ9TlZb6dqKu+FYx5sP3iiclKBnAths9/cNRABreOZIw/sIjYBBXAH8n85GKUu9qkPvyygpuL6JSt1/WP5PIqOUcy0vVt3Cht/b2Zs0vjqvMhAzuHN3x3oUGaF7UDePw4QLZ5qIv0hGbiEEpJrFw1M1/y+v/zgqbWICxEz3nUVhZ0GnCPRnCb54xRxygdRmoXRMyYk/cyi7bHxBOBmX27BSqraU2Bm9tWTJZOKNc+1itfrP+MvL+GX9k+sgu7AEREYg0AIMD2H/Stkl+RcW+Ij1W5IseCCge2L3jy0iVP0q+LFJY0IUI3Mnk94fuHf7rq9BVFw+GRDhvlBp4EH502vuZ2IW8gnhztU9ivgd22ic7SO+QveSY5Fm0fNbF0kTtMlKpHuh8VvVcMqdIX8E7szbKmOp7fTt3DBk/GsSQrafgFPwAZIlYkDTXehsVxqsgea6QpZw9pcQRV03wRLW6NE5AMhWopanN1 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(7916004)(4636009)(346002)(396003)(136003)(376002)(39860400002)(366004)(451199021)(2906002)(86362001)(6486002)(66946007)(85182001)(6916009)(4326008)(66476007)(66556008)(478600001)(6666004)(54906003)(38100700002)(186003)(5660300002)(83380400001)(33716001)(8936002)(8676002)(6506007)(53546011)(6512007)(26005)(9686003)(316002)(82960400001)(41300700001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amxEZ2FDK3FROUZtdHZQc093VkFDL0JvRmxUTGZubjZXZ2Y5QzZhckVNRzFz?= =?utf-8?B?eHRnT2diazlrVS8yYUZXOER3UDNtZjFxSGVnZFlkSXBXc1pKaTdLVTFvQkdt?= =?utf-8?B?QnlIY3N5R2lTaDZpVmNWMzFaMVdyU1dVMHFndjVKaTVqN0x0ZWtaQ3ZlWUw3?= =?utf-8?B?di9FVG4weWo0VDFNTDdRdUZsUHd0enlTaW5zUVkvT01SdWFiTmhFYXhwUTEz?= =?utf-8?B?MFlXSmttdXA2MUljYTBOaGVoU1loV1lhM2x0T1F2aTczZEsrWGVpbk9Xb1dE?= =?utf-8?B?bXo4SGhGYk1nMi9Od1h5U0g2dXIzOTBCcS9paFhLaGJHZGRYRm5rbXkrSE1l?= =?utf-8?B?K0JFdzArb1dZaFpoWlVrZ25xOHZWY3c2K0EzcG8zUjVTNGFGNHhBMjF4b1pX?= =?utf-8?B?cWplK0haTnhVK0NDVkJjQncyTHRwSmZEazhMYVhDb3J5Y3VtVVVxZGY5ZVZQ?= =?utf-8?B?RWV5NUhWN0dGTUhnL3hQNmtkVVhObzhpRUtiQUVIb1dqWEVOVFgwSEFURjBj?= =?utf-8?B?RHp6VDVQRXNsRFVWVHdIcUQrZm9uMTRHTjZ2R00wdW9SbTlwL1ZwTmhURk83?= =?utf-8?B?eUZCSHJNUVVBUDhVNXNpKytBbUE3UWNtWTF5enRvcmcvcWZYSGhrc1h2Wkgx?= =?utf-8?B?ZnJpazBCV21qK05NbVI4WGxFQTdZN1U2UUFVM2JqQUM3OG5rK3lFcy9zaFdN?= =?utf-8?B?R0I2UnRiNVlNeld1azk5OTZBMTZVRDdRQWVRaGRWTnppd1JqRUlXN3pKa0R1?= =?utf-8?B?VFo2MGNhSFhrRkhtMGFVTkIwZHpBZ09qVDJ0N3k5aGRFMDBoTFMxeGljc1dL?= =?utf-8?B?eXQ3ZWs3cGcvdnkxVmNIWjFSakp1dmd2VWh5WUtNOUNwMy9DbG8wOGhkRnVx?= =?utf-8?B?MUpuMHlkMUo1YVBXSzZDSFNET1RGNHhoU0VkWUVHSTBIMHJ2NlNNejNFUlE4?= =?utf-8?B?cHZyamo5NlVuUmR1akt5ZWk1Ym5OdkJva0tKeEphYVZNRFIvZnhwODh1TUI3?= =?utf-8?B?SStRckdsWDVQNjB1aGM0K3VCVDBIVXkzazkrcHdvLzZaclArVHp1RFo5T3I3?= =?utf-8?B?UEx3Y2NqN1VybW8yN1BCMExTZmU0RWFvV3RxTTQyMFdvRURLVDFtNVhJOWs4?= =?utf-8?B?VUV0WHQ1N1A4NEpiZy9KWERxRkt6eDNFaUlnM2pNZ3JmQU1QNEpxVkdRWjNN?= =?utf-8?B?Ymp4b3dRa29Iemc3YXppNTFXQTJudDUyN2gxcDdsM1EwQzFNNStQcEV2UUpm?= =?utf-8?B?YUQrRnNaeHFha1pld0NCUW9pR1pxaytXQlN6K2Q4bTJ2OW51ZHlxbXNhaGtw?= =?utf-8?B?b3FKNUxaQmxzNmtCd3JXSEJMOHlaWDlTUmVjdE5iLzNjQzdxYUdFOUVuZTQx?= =?utf-8?B?Wi9CUHVtVWtkeDdodEQ2NkhlVTI0dFk1NFdkaDZFR2MyK1ZpYnRyeDg5YlRk?= =?utf-8?B?bE5uU0lIZnMvRnZKQWRtRzViRkRlL0lHZEhuZS9iRXovbEgvZlRodHAxK0I5?= =?utf-8?B?VGEyZE01Ti9FSW9wUmZjZW9FV2VkUkd4eVdVcnBKZ1ZjcmRFcGw3L3pYbUpz?= =?utf-8?B?cW1ReUFxMjRHUk5pYmJVbWxWTjdCWFg5Q2oxdlMzMFBzNk1ubjFIUkRxYW9X?= =?utf-8?B?QitXa1ZqYzZMY3RKZ2JoNFBzTHppQ0laOTFGaXIvbE1qaGtQWkwwV20xTDNO?= =?utf-8?B?ZXJ4ZVhMazl1L2ZDdDAyTm50dG96VGxZbnUxaFg5TEEyaUJ4eXpUbGJHNXNJ?= =?utf-8?B?eS9aSTVhVmVnZUZrUW43WGpwZ2pMQVBxUzIxaHpyTXc1eUJsUlVRd3VDa3pF?= =?utf-8?B?YzdmYzdrOWJ3NFN3ck9veVlWZ0lCNUJYUEN1dnk4bmNyUmdMTXZ0a3prL1BX?= =?utf-8?B?OEoxWmg3UmxGSkpvbHFMamtUVjNvYkh5MC9WcTd4VFV1Z3J0UU13YTk0Tkpr?= =?utf-8?B?Wk1xNHhGRzdlanorU3dCWnJjY29iYXpOOTI4a2ZDS1BTTUNCOEt5TGpaaW0w?= =?utf-8?B?WEduRDN4aVllTjVGSWV6d0tBRFlHSW9jazExbkYwRVlWOTJBcWl5NHBiKzUz?= =?utf-8?B?eEVONlBDOGRUZW1VQk05cTUvMWdJd05TU2YyUXljWXY5YUJVcjJ0TE5KVmI2?= =?utf-8?B?dEUyVjZMLzZyZWVLQUFmWkxoWVZUajBEQVRKalpHR1AyNmVPRm83cU12UW9v?= =?utf-8?B?dXc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: e9+Sy8S26P2L1rpLnyIDf27274cz3T6oaSuk60kCnBfVFwPD3FLoibFo4zMe294+PZt5rawCMZzgK7bFTbOYzZsba+Cu1gTcn2qqjmd5LCwPfcgrkBAKo18c3RZEbzkrD+TrRMp6MOlq6+gMH2ADSuUugOyQjZSYXrePev5Il2m9x44lJXNe4HgXW61myzB7tKh0hNZqXxMd40qHpnRRrUhz7eM4MjCuvWubhwNIQSGdK6NrtAKTtRYby8rPE20KZYNK5u5xmp4NjscIAvFmoChV2zWdYVFVO3Coc9C8MRGn+5BXnwCJ9GuNWWAHvEfbh4S5Rtl/WLnMnMSWtT2j/dqm7bvSpSp4rGGwzhAga++bKXzUcLl9mgkODuLnZNE4bpItN9F/rKIsrSfOHkMcVRYySuOTVIQeNpQFbL1AY9MkpMs7+BtrZ9eaLvmtBXEe8lVrrQYAxko72XcrFY0HIcgiomeiTe7/Zdeo2emhEjvoIFvxSXoY8zJNiG3ZwkqhmK2tm9Wb93OgwMuZr6Oe+wxv+hCFFHpKVuCZ9KdF+z3HhrqRu6E9JnBDf3tYfya8cd5/j/1WfepQNZvjX43S5SgwGfhvYgybjsIDep/cnW6jhgT+AqIRcyWN+VacoGEuZFWOVwyzP3J4a0fMUCrZI5E4BjTjqQhc+gc2uKHYOhFHCQM7oVOowfmaaAs4Hc3xqWwfcoIdr6JabjLvF5qj3iP32EImwGw2BiPXBZJq3eIZi2AtxhAsgZJZzP1yJgCLQwfnl5ahQS41ERvqIBfPx0dbY9oSotWydnsVkwsUQsmvY/pVhx60NY9EFQONYkGYDGg/ToxxceXldynrSWZ0g8/IDLzoRa8xSZVCMGAkPdA= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed040652-597b-4d65-9abf-08db4af721bc X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 10:22:28.8951 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZjWd4/qp+4AzPEAUjKHMloXhgfahB+8/euTcSW+8XlvGImBPCKZqHnxR7Rx6fy36BOaC7x/xorq0gnDdhb82Hw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6365 On Tue, May 02, 2023 at 12:18:06PM +0200, Jan Beulich wrote: > On 02.05.2023 12:10, Roger Pau Monné wrote: > > On Wed, Apr 26, 2023 at 02:55:20PM +0000, Ruben Hakobyan wrote: > >> Xen reserves a constant number of pages that can be used for mapping > >> MSI-X tables. This limit is defined by FIX_MSIX_MAX_PAGES in fixmap.h. > >> > >> Reserving a fixed number of pages could result in an -ENOMEM if a > >> device requests a new page when the fixmap limit is exhausted and will > >> necessitate manually adjusting the limit before compilation. > >> > >> To avoid the issues with the current fixmap implementation, we modify > >> the MSI-X page mapping logic to instead dynamically map new pages when > >> they are needed by making use of ioremap(). > > > > I wonder if Arm plans to reuse this code, and whether then arm32 would > > better keep the fixmap implementation to avoid exhausting virtual > > address space in that case. > > I think this would then need to be something that 32-bit architectures > do specially. Right now aiui PCI (and hence MSI-X) work on Arm targets > only Arm64. > > > This also have the side effect of ioremap() now possibly allocating a > > page in order to fill the page table for the newly allocated VA. > > Indeed, but I think the (vague) plan to switch to ioremap() has been > around for a pretty long time (perhaps forever since 32-bit support > was purged). Yup, I'm not saying the above should block the patch, but might be worth mentioning in the commit message. Roger. From xen-devel-bounces@lists.xenproject.org Tue May 02 10:29:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 10:29:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528460.821624 (Exim 4.92) (envelope-from ) id 1ptnFj-0007I3-4b; Tue, 02 May 2023 10:28:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528460.821624; Tue, 02 May 2023 10:28:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptnFj-0007Hw-1t; Tue, 02 May 2023 10:28:59 +0000 Received: by outflank-mailman (input) for mailman id 528460; Tue, 02 May 2023 10:28:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptnFi-0007Hj-ES for xen-devel@lists.xenproject.org; Tue, 02 May 2023 10:28:58 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2060f.outbound.protection.outlook.com [2a01:111:f400:fe1a::60f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 247f1ae0-e8d4-11ed-8611-37d641c3527e; Tue, 02 May 2023 12:28:56 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB9099.eurprd04.prod.outlook.com (2603:10a6:10:2f2::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 10:28:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6340.030; Tue, 2 May 2023 10:28:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 247f1ae0-e8d4-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ikwz2xTLMztoIowwUlLUlxyZuq6NeHRMzSqD8gdcgkeCYk318rqZPhKXOArDDPEYjT+A6Rs5lMhW7PZnZNlOiJ6/SKG81cBMHtwRP17KIzwDC3Rdbq5Oa7qGkngHzKYVEqc0aIpKeaTs6BTPr6Q4bX4T6uZ/S7W20wg4tb0iEqm09KOTGTm2eXUZ1zAwNeN+uWtSqOIv36NIgyTPSKFOsY41hEkDYzwZxGwqIOL0B3ARf1Jpo0EefzkLMNGo8M+u64uMcL0jhBX7fQvyvavkThTW0r8XquvfaRVMOUTi+ckKQW+wavMig6PguTWqJ2pSHNEyl2CpZ+Om6vKui4HIYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N0ielytoTu6NUD/JoRmt6M7O4JGjqcE4ERzlv1AGDK4=; b=K2KFHNrDxIduEUI2O3sn/OoEkKlWmTH72OiK8fU2eQmefMdNPrufN5k5VfUflrLSs2j1MLsiRapYCHSViLH1S2f5MlQWs8YFGPjZ0c3f93+Vqe6xtC6cezz82M3IvsWMtU898KPUbwb2iKM7cO61hA7ZA+Jsr+c9+ENwrd1qPbC2RJB//EglLggU7CNYGIZC4e5sO/huP4AeptrmZyHS6tJSVzhvGXLTw6f3MJKpgqfdvcYZDZXa/Io3akQjlI8s4dfxEljtu4FBZRLaSOlbHoRR62Pf/kV8dF/YrktttODrBJYYF12vEVEqZRSf+5Y4iFZpuoVN224mB6JusAAZiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N0ielytoTu6NUD/JoRmt6M7O4JGjqcE4ERzlv1AGDK4=; b=kZr6FI53XNuN0Q57wUaZzNrCKe4WwPqNTiK2eCNN0SGRAVOF3w80LWVHI3Pk8bgUIkm5FnDruGgsOf0zaZHEfOl9ftgUk9to92HJBTfWBThXIHPgLFy06QVrzrhJ+5WSg4eHXu8AbW+XgzMknzRFqE4Ivu1HW4RShfNdXPgfMh1F2mtiWSTzqR2IUJSXUQcvtjOM7FYWsVelfiV7nfu7ZVdc8OeNqyI6nznhvPER5SRwoSacIWcFO49qIPOVKsm8QH0PQS1rhSGXKI9ybqkZ0mvnw7Yk1a0pBOu7cFc59U2i/5mPcUjADpk9C8KELZwTt0fu3i3NmU2DBetoEEzUew== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <068ad06b-d766-4fc7-6bbc-289911441ee7@suse.com> Date: Tue, 2 May 2023 12:28:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 1/2] x86/head: check base address alignment Content-Language: en-US To: Andrew Cooper , Roger Pau Monne Cc: Wei Liu , xen-devel@lists.xenproject.org References: <20230502092224.52265-1-roger.pau@citrix.com> <20230502092224.52265-2-roger.pau@citrix.com> <89389465-f32c-7dfe-f62b-b957e2543cb8@citrix.com> From: Jan Beulich In-Reply-To: <89389465-f32c-7dfe-f62b-b957e2543cb8@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FRYP281CA0015.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::25) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB9099:EE_ X-MS-Office365-Filtering-Correlation-Id: 163cb86b-45b2-400e-7de4-08db4af8073f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BbAy6CO/WTeNfLlW09u5lHhUBbMph0VF5VqHvcs0R3yqZ2NOYnIqa1WPuSqEqVGOtbs684XGxPyS4qNbeqGSauP460K8aPBxYukoF4qGjXCQzJImCf+6X0qR3fdF+gUmhHPXKdjFn8AQ8Fv+1djgxRMWN7sA4qtQTWyKlabE7ab2vl240wToJpDw0AkdIAVDDA+KJPgDioOR4TaUjSeF38PBHzg7yQRDDX1Uh9g53xFceOuSE0ksYhuV5aGrKMuvQtD7GNSj1nmsE0Au9W2E75G0WgXlCLvezZMez4N5XDv7NV/t8XZ0BNjWwNfpM0hYO72JMOkcb2fzhULuwMb4amLG8Hc0QbrnyiwzpQIaugdUrnjBDiVPIIG0B37VvAH0yOj2+6I5UpmQCoYMVE7HmK0XyX95xzbDsvhX2n/D5xyC829ibBlg0qK/AKry/3dCjFoTANbuoK2QqeFZhg/TFGp3EivhA/dqJnXS516bJV7uanNz7gG2xHhZgVuEGz0rbCK0QPJzLU1sw3UW1NJUYmNpUt3J+Syr3uIj2EEqx1u9qOlqoADWfP/MD0oHqpTMJlaOQ/RP4tJlnf70gjw4zg870eVp5UIF1tad4u57Xrxa/6nJe7BnTMTrMWzX8F/ktZVrsNF7zUYPsjw9BDXPYQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39850400004)(396003)(376002)(366004)(136003)(346002)(451199021)(31696002)(86362001)(36756003)(110136005)(316002)(66476007)(4326008)(66556008)(6486002)(66946007)(478600001)(5660300002)(8676002)(2906002)(8936002)(41300700001)(38100700002)(186003)(2616005)(53546011)(6506007)(6512007)(26005)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U1NzalVFSTZ2bk9RalEzdE8zMUdnVnR2SUNCUUkvVVBqSVczenN0MzB4QlFX?= =?utf-8?B?VGFSTDRwenJqVWx4ZXR4dUMvMUhUUEM1OFMyNnpRclNXb0JQdldDbG9UUzh4?= =?utf-8?B?dWVQYUs5MXVWUDJoSTdPNCt1bVEyNDUxallTR0pxWk0xSFpRVXZReXpXeGhz?= =?utf-8?B?cXVJdDlUQkY1MmJmZHVTNmpXeGdZYTVRM2V4cWRRR0FoOTFITjlvbXR2UERM?= =?utf-8?B?TnRISlBKTmt3V3YrNmtJamhJdU10Wms4bUNUUVF6OWRDaTlaZXl1cHNyd20y?= =?utf-8?B?UitmR1VqVngzRWF1QnRYdUNrNDNWQUJJYXJSVk4yQSt6dmNrS1NoNmVIT0RY?= =?utf-8?B?czA2b0Y2WDNCaGszeDNCR0tHRmhQSG52WW9sUzZWSytrdEtMZmFtRlBMeHgw?= =?utf-8?B?RkRub2xGRURHMUpvR24rTmcvdlJwVDZFc29aMWVsQktkM3h5TnRuS0s3L0Nl?= =?utf-8?B?OEsrdWNpNDEvOXFMZGo5aCtZUW5tejloQzJDZXl6aDJveFZiR1Vqc3dmT0NI?= =?utf-8?B?aDh2R2hOL3pheGRvNFpsSG5iQS85S3hhQUpCRWxOQ0xQUW9oT3ZxUnU4K05H?= =?utf-8?B?NzdFUEhKOVV5RzZYVk5tMlFBc0Y4elRHbXRVOUl0VDYzbDNRR2pIN05mUjhy?= =?utf-8?B?U0pna3ZVYU4wN3hjcDRkTWZzak1LeEYydXA1NHlzRXdoOVEwYTNHOElhampO?= =?utf-8?B?MDZjMStaak5XbGlrcHJqMEtINVRsQ2drQk5hK2JwVjlBcnEzalZOK1pvRlc1?= =?utf-8?B?R1pJdTBZdXVEc1ljWll0MHFneUt1emJtSDRaUENDaHdZcWkweWJQR0tYYy9V?= =?utf-8?B?OVBQeVVFME0xUmlNTXNYb29zZkdxa2pkeXRYT21MTW1xZnRCQjZpdEFjUHRE?= =?utf-8?B?djBOemNLaGdIOW81RWpyU2daSzYwdkkvMjNvcHJZRWs2N0dNYnJ0VEx1R3lV?= =?utf-8?B?eCt4bHJaZTAxK2ZqcGVYWnE5d3cxZlZzZ1hIKzVIN2tMZ2diWS9lL1ZJdkV0?= =?utf-8?B?Mk95TkduQ2d6VXEyL2MyWnVCVG8wNWxFQmRCSGRrODNLdzFwR1Jwb2VFNkRk?= =?utf-8?B?RGNRNUhKc0kzVW9UMnZGZmhLN2pWNEpkdStMN0R6R24wU3hmTEJDYjE4djhl?= =?utf-8?B?YlhkV0VqOWhRS1hHalF6Sldpd0M2THRtQmhNd0JVejZNUlVlTjY4dTRMemNN?= =?utf-8?B?LzRBTlI4ZTBFRXZnVkVIb1V4Q2laL0s0MVNxVVgvdnV1cldNZFNkY2FqaGlP?= =?utf-8?B?dTBMSERiU09MTFVNdC91WVd6dC9OQ25qdVl6MlVxN1h0dXpQR3BiZ1RoTUZC?= =?utf-8?B?djJuWEFnNU5UWTByRUtIRENoaFFJWkxHK3JPR1pXSmt4OFY3MGF5RDcwVXZn?= =?utf-8?B?bHg3RW0vRXR0U29LNEsrSzFRVlE3WnpHSnE0cVJJMkI5NStLdk5aL1YwQ3Qz?= =?utf-8?B?dHZjZmp0alpDKzZUd1RKendLaTdyRWUxYm5KR1YrOWt0N1JDL014VWx2Z041?= =?utf-8?B?UkQyMmpGNW5YSy9uMDF1eW9yZk10bjZ2VWhDSE1SdjdwREh1NlMzNktjWmlD?= =?utf-8?B?VGhUWGpDTWpGdTdZTkF1Rkd3UEV6enBKanJLZjB6cWJzUFp4cWlrejl6VjQw?= =?utf-8?B?cUlFc3paU0pVTFNvSUhmMDBmM0tqVVFUVW8yWU5JMWozVjNSdUNwZFVnUGY2?= =?utf-8?B?dlViRmJrbUF2S29WNHdIVDN0ZittVFd6NEI2VUoyUVdmemxKWmpoMVFzTk5B?= =?utf-8?B?MjVzUVdNamVJRUZReXBlMHJFOFBBTFhGRXN5M0EwSUhsYWFnNVlCM3hLYlpO?= =?utf-8?B?d2xLRkoyN2dOd2d4aHNsT2FSSDNYZ2NVT0k5RXl3My9RdkRKRXhWR0VlS3dW?= =?utf-8?B?ZGI2OHZ5OWZNQ05nc2ZVNEV2OGdHcEJhc29RQmNVWXY4dTdVMW1VTzEvbWwr?= =?utf-8?B?NVBhYk4wTE1QNjRKY0c3Nm1SenR0RmpUZ1gwVFdidHFCVnBwczhyTkNnQm4w?= =?utf-8?B?dGtIdGJGVHpyWFVRLzN6RTdPc3ZTTC9RYVJvMjhIeG5IOFpXdEJ0N2FDbXEz?= =?utf-8?B?dE5odmE0c0RLSTV3S0VJUzVrZk9pQ3hhblNORTdLUm5ibEsyVFJacS93S0gr?= =?utf-8?Q?cTATU27mjsM9VDtxPG8r1amFL?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 163cb86b-45b2-400e-7de4-08db4af8073f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 10:28:53.9120 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QxVB2ZCnab8say83gbbxq9UE0jyl3BRg7fMovXNAc4ZgOUkoobH86BqTZbzEkWTx+seQzuif3DTdmFQOgaXKug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9099 On 02.05.2023 11:54, Andrew Cooper wrote: > On 02/05/2023 10:22 am, Roger Pau Monne wrote: >> Ensure that the base address is 2M aligned, or else the page table >> entries created would be corrupt as reserved bits on the PDE end up >> set. >> >> We have found a broken firmware where the loader would end up loading >> Xen at a non 2M aligned region, and that caused a very difficult to >> debug triple fault. > > It's probably worth saying that in this case, the OEM has fixed their > firmware. I'm curious: What firmware loads Xen directly? I thought there was always a boot loader involved (except for xen.efi of course). I'm further a little puzzled by this talking about alignment and not xen.efi: xen.gz only specifies alignment for MB2 afaik. For MB1 all it does specify is the physical address (2Mb) that it wants to be loaded at. So maybe MB2 wants mentioning here as well, for clarity? >> @@ -670,6 +674,11 @@ trampoline_setup: >> cmp %edi, %eax >> jb 1b >> >> + /* Check that the image base is aligned. */ >> + lea sym_esi(_start), %eax >> + and $(1 << L2_PAGETABLE_SHIFT) - 1, %eax >> + jnz not_aligned > > You just want to check the value in %esi, which is the base of the Xen > image.  Something like: > > mov %esi, %eax > and ... > jnz Or yet more simply "test $..., %esi" and then "jnz ..."? Jan From xen-devel-bounces@lists.xenproject.org Tue May 02 10:29:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 10:29:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528461.821635 (Exim 4.92) (envelope-from ) id 1ptnFx-0007ec-CT; Tue, 02 May 2023 10:29:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528461.821635; Tue, 02 May 2023 10:29:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptnFx-0007do-9N; Tue, 02 May 2023 10:29:13 +0000 Received: by outflank-mailman (input) for mailman id 528461; Tue, 02 May 2023 10:29:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptnFv-0007Hj-DG for xen-devel@lists.xenproject.org; Tue, 02 May 2023 10:29:11 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2b7768d7-e8d4-11ed-8611-37d641c3527e; Tue, 02 May 2023 12:29:09 +0200 (CEST) Received: from mail-co1nam11lp2177.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2023 06:29:06 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by SA0PR03MB5530.namprd03.prod.outlook.com (2603:10b6:806:b0::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 10:29:04 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec%3]) with mapi id 15.20.6340.031; Tue, 2 May 2023 10:29:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2b7768d7-e8d4-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683023349; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=8fmYAgrEMm4z+FHSmfluJMGF/rFQW2JxGHZQEALI2hg=; b=TdIWjUBCna7B1s+3QV4maPQZQEA5HvBxanqufrT34dbWavHVwoDMZwCn C0KfIXttbKTJiHX3bVP1+OYP+cGMW95i5VGSEYLfwc5sN5e8qqWalLIjm n8u6FfmodbFZhpuigTCkLKap0dFSQtKYfcK0FaewysY2pxzURGlrY3Dsv I=; X-IronPort-RemoteIP: 104.47.56.177 X-IronPort-MID: 107442572 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ale0mqsSZ4l6+kTeBhpRhgUl7OfnVHBfMUV32f8akzHdYApBsoF/q tZmKWjUO/6CZjD0c4glPY638UwGu8eHn95jGlY6+31jEypB+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj6Vv0gnRkPaoQ5AKGzSFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwOhUIfwCEpuSNx+jjTOB3lvUOBcayFdZK0p1g5Wmx4fcOZ7nmGvyPzvgBmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osjv60b4W9lt+iHK25mm6Co W3L5SLhCwwyP92D0zuVtHmrg4cjmAuiAN1OSOflqaQCbFu7ynAwNgE6VWuCivTnrVXuQv1uL 0YP0397xUQ13AnxJjXnZDWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOnM08SCEu1 1SJt8j0HjEpu7qQIVqC8p+EoDX0PjIaRVLufgcBRAoBptLk+Yc6i0uWSs45SfHqyNroBTv33 jaG6jAkgKkehtIK0KP9+k3bhzWrpd7CSQtdChjrY19JJzhRPOaND7FEI3CChRqcBO51lmW8g UU= IronPort-HdrOrdr: A9a23:Jf1pnqn68euzSUMd4jJGcpYeqnXpDfIr3DAbv31ZSRFFG/Fw8P rCoB1773PJYVMqMk3I9erwW5Voa0msk6KdmLNhWotKPzOGhILLFu9fBOLZqlXd8kvFh4pgPM xbAs1D4bPLYmSS3fyQ3OTwKadD/DDCysCVuds= X-Talos-CUID: 9a23:mavgv24NbRUrpm7lttss5msRC9AiU3vmyy2IJUajGVdEYbLMYArF X-Talos-MUID: 9a23:q8v03Qlu5JV3EUPmpQszdnpuKORW/4iuOHkmnMshoJmdGh10MSy02WE= X-IronPort-AV: E=Sophos;i="5.99,244,1677560400"; d="scan'208";a="107442572" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ci5HwaCdi1MYSVaArKKLV6hxicU4oOU3bf5K2x9/uyi6sTdaezodSiLEDOSnEEO8CREiCC+YLS2pjViJ8eMYTXzIAY5NO2dA7voqKuP718MIbJzf1pdW3tNx2Al8cf9vKNAyeHuONjaNUPDLzj8xSUB7Vpz8kGZCMGxyV/w/yOdWpjL2+oFCDtwuU4gDtCpfIUaIZ04urAoGdrESQ9LLK/LKGC37b7G8+xA3ljIKKCPLqbYu4JG6IN42K1fly1KfeUDKKWnUDTmSwNxdDK7SPiWFbF3hPmtqxdcEC1acA1X3r3+WsvEs/ipwzkV7bwCkQ7QEJEbuKB7v762sc4Iq/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0ZZalwAl4VL+hS2tkqb5oYm/g4u5h2Oc8shmcdV5Itc=; b=ksSQXNChNb5EjG80RlLdeX4kewkaYWefWOof/CGBXUwnAlRiwLpxnsWsYr/HgpnmfxJeocbUoJMl3I5Cih45MKTg+KMMgelaGMZZjq0x5zPgBJzCLQpF2j5WbILfjkG6FFqmslGfyz+Da12077lJmGHbjuKdsEZT2LLsIBZu1VRib7yj6lsiK4GT2KF3c1GHUAREdLTmll05u4T7mqvO5oAjQY0u3WgB+UtrmoKrWb61gvt9jCFY8QzgFmUIpAkQK0Qi/rPBfx5WXSPAYPb2J1QrQzWW2lJXV5siIWs87bhqgDyCUdyF1/mudwHJ3tgGpmJWXPHfOL2QlSOcMwofcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0ZZalwAl4VL+hS2tkqb5oYm/g4u5h2Oc8shmcdV5Itc=; b=umlBnlMJ3Tq6wJXVJcrzAblP7y7JGH0Y1WcL+89fL53RstrMGgPXcIg6ZJA6Z8PGcT0rUcSLIONtlUOGQh78onp4msG/yy7i7AUIVfQbSE6Gk3+mG6NfXxJfhjf8WNzG+wONlDnk4WgWwpVXoaHeXNpjYsshd1K8oTr/LJyEcu0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 2 May 2023 12:28:58 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: xen-devel@lists.xenproject.org, Jan Beulich , Wei Liu Subject: Re: [PATCH 1/2] x86/head: check base address alignment Message-ID: References: <20230502092224.52265-1-roger.pau@citrix.com> <20230502092224.52265-2-roger.pau@citrix.com> <89389465-f32c-7dfe-f62b-b957e2543cb8@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <89389465-f32c-7dfe-f62b-b957e2543cb8@citrix.com> X-ClientProxiedBy: LO2P265CA0259.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8a::31) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|SA0PR03MB5530:EE_ X-MS-Office365-Filtering-Correlation-Id: 5c802f13-7004-4efc-e13b-08db4af80da4 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BhsQKmzbsBf3y0qroIA8DKBLJSVH7hn2THFLpZiypSSZIdn49PYWoinukvRuUCORzBPBC0LBSfgkjwLA+C8ESrW+fPDzRcET6Zx9pCPH4dOBW3qiSjulGT0PYLSHH5IPpR6brnjXlSFvfPOVprlLGShLp/vjeBLt7ytVtfJTjziQ6JDovnJgu8w3DbAw33tMbdNSRNEqKHgoq3CTZuxFDOD/WwTsrsFPNb9PmiQzC8XSyitZXH43sAWHmMcR4jRYdGLKBPt+ecCMhyahwQ8p9yu9PcSJvsP9acTYHyRAioT/Ntrb8Lh3pr6Nt9DuQXZSTimfP08X+2867a+xr++7vbbCffj03nnYuttG/on8ZnKVaSYzki7h4jVGlF1vOJWUcuiDZe6GSuAIx3mrkAEB+wTKjNd/3JZSPWpsfFePp3vDpEx9e/2jHUZ9z0X6wI0cgkwB4ZY50b0I4KMosSmTi7KyqVeN4ZlLfmSk4aOnDsgVqKiLn6xJljI7aBHLKLiiI4s2tNes4fnpjLE1pd4B7rEzuud28We2wfQcAN2Uh1zGm/3P1naRv9KwJEbpVccE X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(7916004)(366004)(376002)(396003)(346002)(136003)(39860400002)(451199021)(85182001)(86362001)(83380400001)(41300700001)(4326008)(5660300002)(66946007)(316002)(2906002)(6862004)(8936002)(8676002)(6636002)(54906003)(38100700002)(82960400001)(478600001)(6666004)(33716001)(186003)(6486002)(66476007)(66556008)(6512007)(9686003)(26005)(53546011)(6506007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TS85b0g5MXltQXNLMGJzcENLdTdVRHh6Q205bnMvU0RXV2p6Zkp6MW5TUzBQ?= =?utf-8?B?YTNna2UyYldwZWc0dzNtTGVwTlJDOUhwYUo3OU1qWXB0ZjNuVHU0S3hLNXlF?= =?utf-8?B?Sk1iOFl6VDlaemFESmxlbkFmdTBQNXNXUWFtY1dDN0F3SCsvVXN1N1ZiUjF2?= =?utf-8?B?cmNFdCtlRW9GcW1PQy9iNFBmc1k4WnN5WWcvL2lhM2tVbUZ1cEZjSDAwYk10?= =?utf-8?B?cFYza2xaQVI0MWtSanhqd1JkZVVyQ29zd2ZTaDVxbFFDRld2cldpRjR3YWsx?= =?utf-8?B?WTJKTTVhSjJMeWRvSk0wb0dQZWkrYkZGYW5zRXRLb0RZSEFWczBlaGFtUFkx?= =?utf-8?B?QTNDZjViSXJTSVY3QXNsZU1tclVla3hacTlTQ21Xb2lER3BOMzQ3eHJhUWlF?= =?utf-8?B?SXErUXR1bFVkRnJZa1BQTHZGbVNramt1TFE0Z1QzcXhFVzh5WThFL1pOWDZJ?= =?utf-8?B?UTJCaUk0RlN5QlB1MHY1TGxtK2NkS21CT2Iwc2hLNmRBUVZuYmJLS2JZNHYr?= =?utf-8?B?WGIxYWlhWWc1ejladzZGajJET0VIUUxOR1EzRVhlcnBpbEtRUVJ4OCtlT1pJ?= =?utf-8?B?NUJWRFlkUkJ4NVpqVlA1MTBuM01zM25pV0ZlUVlYa1hJZHlsZGlMb2FoZHpS?= =?utf-8?B?blhlOTdXUmozVjVVZWhQZDh2ZDZqMHhVKzdZRTZCRjhUVS9UZk1VVXdVK2lU?= =?utf-8?B?bFl0SWhBak9KYzh6ZlJ2RWRuVXZLQytIbjlrVmJQdWtXNlQwWFZDcWpuTGJC?= =?utf-8?B?eUJuTUJGMkpwUTZTV3l4SWNTUmZrRnc2WjFKZlJQcjBHWDRFVFpWczYycVMr?= =?utf-8?B?aW1PTlpueWFEeFN0UG85aGxLNU9iNkIxRkFRWjltKzd2VHFxSjVuV1BaOWZX?= =?utf-8?B?eVdYMzNGbnk1eXIvcXFXV0lDZnNiRERMVytsbGpobjMrNzNNVnJMMWxJc3Zq?= =?utf-8?B?SUxmektMaUJLRzQwVVIvNWt4VE9CTjlFL0prSDliSlgvWTJrdzl3anA1ZUR2?= =?utf-8?B?NU4weGVVUm9nODl1VGhObGhzVXBSa2k4cll1eUd2a09Kc3VmVWFwbnIyZDRq?= =?utf-8?B?b1dCTkkyelN0V3A5ZW5NS3hOd0R3WDlDYzZ5ZDlWOSt3anBxcWxQZjZDSlJO?= =?utf-8?B?TUtObUhYc3dSU3o4L0NNYWF6THlLa1RKZkU5alBwTzltczU1d1pZLzhNalZy?= =?utf-8?B?WFVMd3V0eTZPQUxOWllvV2psQkgwUlYvOVBhQWdKSUhyUjloYklxL1RjQVZP?= =?utf-8?B?RWtyL1pvUFNLZmRaWEFOaEk0bnR0cHhac29adWVEMHhhRGRBc210Z0ZKZDZk?= =?utf-8?B?TThEQXlML0VSdWZZc0J4RGFIUXJuZVhSQ0ZGSkhWNFBaWnJRWUFoNVJZNjhk?= =?utf-8?B?QlpOM2E4eWM0T3dTdGlxcE5QaHNWTkNtc0R3K25OR2VKNWVlVDY5azdyWTh4?= =?utf-8?B?Y25YL0NiOVhoUXllNGxFKzJxankzT1ZURjl5STRXYk81SURxZWVMTUZrdlR2?= =?utf-8?B?L0hGSUpUNVZIeVZaUXB4aGg2TGRRY21qKzJuNFFMZVdySStRVGpXby9pcHph?= =?utf-8?B?aGY4dFo2QzZHUWtoTTB1N3F6b1F3enI0NWpLK1FNNG1RZGltVVpDQ0ZZSDQy?= =?utf-8?B?Nkp6blFvNjRhNzk5V1BPY2MrZWcyWGxkUlROYmxPSlRYd2xzcXNsNWQwbFZW?= =?utf-8?B?UkVhMkxOZ1hHaFBsRithOXAvdWpJb0EzNTc1K2pTZDRSa3d1NmxNUzRVQVZ6?= =?utf-8?B?TlZDd25MMHRzYkVxakNYcmNSTGwxSmt5WGJmRE12QUYxSCtoZVE2OG1LbTRn?= =?utf-8?B?YS9qazVta2RSblVwNzRJY1dkS1VEQ21CaWc2elVWRWNkQzRyMkU3aTJ1K01q?= =?utf-8?B?STZNTVFvNzNhR1ZsblBsNk9TOFlJZUUwcTdCbW5kbTJjRyswbDZReW1rT0Y4?= =?utf-8?B?eWlKZDdjZGVlamV4TDZtVExOdzVSTmtDYUJWSEh6aFViZGV3dTRab1JOUW9n?= =?utf-8?B?K2ZzRE9jOGZqREFSNmpITFlLNjFjVUNtdDcvTWZKb0R5Qko3Z2JrTEYyYVRQ?= =?utf-8?B?bXRwN0k0WHhodi9wOGM0WmNiUTJ1ZWVmQTdCVVZsMXhsZG1oTzVaODF3bHJs?= =?utf-8?B?cTFlRHBnTmxNYmFwSmJkTjFUd1pRbUFMY0FiZkNDZDE1eVZwL2ZaUDRrUm5z?= =?utf-8?B?NHc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: iozp4iqZpBo3UlqpNqOBZQ6i7wXPwa0kI2n4FoL+/D1iwDu6Om2/li0dqMMEyk41Pga2XlIstHUpQf5XgVcCm8zNxuUlbRS1UTCI8AHQW72q31XGPo6O4n+zAYUzXrFYbE5XEZKzjfgwGHJUwDDl1rbydJV7kwGRPNVb+Duk6kWqWqc0+30sgtDGnSo6NI7SlbtKIw8rD5l5f81NXCDA6AEGqmO90Q4SQBn6xHOB7Sm9nwr9c7IkI/6bza9+CgwwYll7IQV/3FeWOj7TWCZTQ8hLlmA8k6xdPkIjbHamXPTfcbXDhj+VM3EahfIUQBnbdJeka3K45+dKGGeKaqongLjjcckkUIo73hWePZ+7C+NF/orjNEtjRdEt1tmEp+ET1/dELtTOBoZBXgKzFDAFGpXZk7GLUuoA6OXrIJSynjTsAo07mPVt7SbH3BYTd0YnzK2wtLvNnlLM+ICzrJE9U93Rz6NKPUV1ZNNv0QfYWkIdlfwozhzxcYmw2of+iN2FduxLXxO4OQJYu6R3bWnww9Jrj/d7zC3SPSKuqzAv4lVBrMgqPjqMRtZxgagE83mcipk3gUy704ovMTl7/84yLipE6dUo2ldv3+fgwO8oViRQJsFHYQQLeoAe5lPmvt/BhL5oymnizhrl1IID1WtzG9yvls5tkwZZATURE7Vbwufcy57v9vfkCkGe2EMBc5ARH0JgUo+56jpaBZTJYKDz6BcJQHs+Yzm/Gw+AOY3zh/qP4kzd2swGHXazbPRzN5jk8l0xzscOQ6KWAHYpDRSpxdnhpRs8PiekRvqQ4cU7POC6oOBvjcLYlaA/SGFLVkJZ X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c802f13-7004-4efc-e13b-08db4af80da4 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 10:29:04.6859 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BNoxJP+5MtsGHUbVmMtY0KvvCAw8yKiRrWEP8DlOygN0WJMZEW7T+dcSGpKfQYkMVte4NLP5se7TQROjm+gnvA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5530 On Tue, May 02, 2023 at 10:54:55AM +0100, Andrew Cooper wrote: > On 02/05/2023 10:22 am, Roger Pau Monne wrote: > > Ensure that the base address is 2M aligned, or else the page table > > entries created would be corrupt as reserved bits on the PDE end up > > set. > > > > We have found a broken firmware where the loader would end up loading > > Xen at a non 2M aligned region, and that caused a very difficult to > > debug triple fault. > > It's probably worth saying that in this case, the OEM has fixed their > firmware. > > > > > If the alignment is not as required by the page tables print an error > > message and stop the boot. > > > > The check could be performed earlier, but so far the alignment is > > required by the page tables, and hence feels more natural that the > > check lives near to the piece of code that requires it. > > > > Note that when booted as an EFI application from the PE entry point > > the alignment check is already performed by > > efi_arch_load_addr_check(), and hence there's no need to add another > > check at the point where page tables get built in > > efi_arch_memory_setup(). > > > > Signed-off-by: Roger Pau Monné > > --- > > xen/arch/x86/boot/head.S | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S > > index 0fb7dd3029f2..ff73c1d274c4 100644 > > --- a/xen/arch/x86/boot/head.S > > +++ b/xen/arch/x86/boot/head.S > > @@ -121,6 +121,7 @@ multiboot2_header: > > .Lbad_ldr_nst: .asciz "ERR: EFI SystemTable is not provided by bootloader!" > > .Lbad_ldr_nih: .asciz "ERR: EFI ImageHandle is not provided by bootloader!" > > .Lbad_efi_msg: .asciz "ERR: EFI IA-32 platforms are not supported!" > > +.Lbag_alg_msg: .asciz "ERR: Xen must be loaded at a 2Mb boundary!" > > > > .section .init.data, "aw", @progbits > > .align 4 > > @@ -146,6 +147,9 @@ bad_cpu: > > not_multiboot: > > add $sym_offs(.Lbad_ldr_msg),%esi # Error message > > jmp .Lget_vtb > > +not_aligned: > > + add $sym_offs(.Lbag_alg_msg),%esi # Error message > > + jmp .Lget_vtb > > .Lmb2_no_st: > > /* > > * Here we are on EFI platform. vga_text_buffer was zapped earlier > > @@ -670,6 +674,11 @@ trampoline_setup: > > cmp %edi, %eax > > jb 1b > > > > + /* Check that the image base is aligned. */ > > + lea sym_esi(_start), %eax > > + and $(1 << L2_PAGETABLE_SHIFT) - 1, %eax > > + jnz not_aligned > > You just want to check the value in %esi, which is the base of the Xen > image.  Something like: > > mov %esi, %eax > and ... > jnz > > No need to reference the _start label, or use sym_esi(). The reason for using sym_esi(_start) is because that's exactly the address used when building the PDE, so it's clearer to keep those in sync IMO. That's also the reason for doing the check here rather than earlier, so it's closer to the point where the value is used and not being aligned would lead to corrupt entries. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 02 10:34:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 10:34:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528466.821644 (Exim 4.92) (envelope-from ) id 1ptnKx-0000ry-Tq; Tue, 02 May 2023 10:34:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528466.821644; Tue, 02 May 2023 10:34:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptnKx-0000rr-RB; Tue, 02 May 2023 10:34:23 +0000 Received: by outflank-mailman (input) for mailman id 528466; Tue, 02 May 2023 10:34:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptnKw-0000rl-HR for xen-devel@lists.xenproject.org; Tue, 02 May 2023 10:34:22 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e4565d0f-e8d4-11ed-8611-37d641c3527e; Tue, 02 May 2023 12:34:19 +0200 (CEST) Received: from mail-mw2nam04lp2173.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2023 06:34:11 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by MW4PR03MB6377.namprd03.prod.outlook.com (2603:10b6:303:11c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Tue, 2 May 2023 10:34:07 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec%3]) with mapi id 15.20.6340.031; Tue, 2 May 2023 10:34:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e4565d0f-e8d4-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683023659; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=OcL+fG5wIRAZ9WwG+QC74Q95vh4A8SH6qo7tdrcXdLg=; b=NsFwCJMy+YXgHlwdSeWlmlztQwbtYYMIZuDSSUfxYA4tjt1YkFkq7UD5 u8DJ2R+Yn22OL9fQpO1RYZyhUxMyVVwAVUwXLLogEQ0yqW9tvuqRjVixm 1Jk2DYiF5R5mnZPGtHDKX7x992B5mCThXqFy1I0YLhvBHbWkv6P9dkDnY g=; X-IronPort-RemoteIP: 104.47.73.173 X-IronPort-MID: 106882018 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:zTYqtKvdXjajRR6hFyO7FWVJOefnVHBfMUV32f8akzHdYApBsoF/q tZmKWiBM/aNYmekc4x0PoS+8h8O7JKGzd5jHQM/+yo2ECgS+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj6Vv0gnRkPaoQ5AKGzSFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwEiEudDGmubOK6ZW9YO5q3McRCJfpBdZK0p1g5Wmx4fcOZ7nmG/mPwOACmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0oui/60b4G9lt+iHK25mm6Co W3L5SLhCwwyP92D0zuVtHmrg4cjmAuiANxCROfgr64CbFu7/jAXUzQMZACCnNK0003uWsBZD 30Uw397xUQ13AnxJjXnZDWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOnM08SCEu1 1SJt8j0HjEpu7qQIVqC8p+EoDX0PjIaRVLufgcBRAoBptz8+oc6i0qTSs45SfHuyNroBTv33 jaG6jAkgKkehtIK0KP9+k3bhzWrpd7CSQtdChjrY19JJzhRPOaND7FEI3CBhRqcBO51lmW8g UU= IronPort-HdrOrdr: A9a23:ZJ2NkaCVUp9mEd3lHemW55DYdb4zR+YMi2TDtnoBKiC9F/byqy nAppgmPHPP5wr5O0tBpTnjAse9qBrnnPYejLX5Vo3CYOCJghrOEKhSqafk3j38C2nf24dmpM FdmnFFebjN5I5B/KLHCaKDYrQd/OU= X-Talos-CUID: =?us-ascii?q?9a23=3AbJwajmvMi3GpRs5RfBQVzgbs6IsfY17H7VLucnO?= =?us-ascii?q?RLmBDT7vPSm20pqFdxp8=3D?= X-Talos-MUID: =?us-ascii?q?9a23=3AD5olMA5B3Aqm3zZmlAqK9wWRxoxQv6D1IVo8yqw?= =?us-ascii?q?7kMTdNnxxKTG5vTSOF9o=3D?= X-IronPort-AV: E=Sophos;i="5.99,244,1677560400"; d="scan'208";a="106882018" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NTiSQy2ZHdqcfQ/c6tg012pHRl5DY5hbab5ef6EPVhV5OsD6mO3qE7M6bt5bg3Y+ihPG0rOtydkH1cqfbEf/ZjxRxflGdFawe4pURq7bNstaNHcH1wO7CfKMwRpfBe7/dj3xHwkVw9nEWshXDNR4ngnQojRlzNqMutMLIVhJyhIH674+8esJ1BDANx3/ijJYX/3RXmLrzblLIoUrlg7L7F7FD/E3E2my7AhbXXOr/CiHlPMxc54/Wd8IFdbG/DNwQrZ6ArBBTaBMeBEmxOrMcUjIur00PDlvq877kLdXNWBawehYGQiRUswKD4jJAGf+5qIpiL6vhS3EXR75scDrkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GK3S7p7ZYgG72MlZtaCx995FesgjOzg2erqZCRG44lw=; b=mrjz97AG4hdLpm59q4PGDRgL5ds7J3vhwV3KQLwZbqUeBx6RiN6Hwh7XLF/lD7RaXSvz0D1P7B+dYV5yEgs3vgkTffPNHzYk9HlEnpR8itOggtbmkvVs181OJEe41Oj+a8694/81j/mH8SDP469bbZUjCOEYSVFcxVn/QahRJg5SYGd0C/ruvDaIEgH6cZGh/4FzXHbO3HT/A7ZsSIjNvfrC8c8BEunUll0wNT/96qHf/ngQVQCbsVxBPMq88gc4E9Jxo/CF/JcQUxAvBYkR3TH3c5aaXHjARNVyN/3OhhPtomBeer3w5rZEOaiOMcfpdRl++DATL6sd1yhGIHF8Ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GK3S7p7ZYgG72MlZtaCx995FesgjOzg2erqZCRG44lw=; b=eOTI4ORgDQXmFoCAHDBMOBHyPA93vF7FVe7fJLvudRTU60PIZibHPuluVR/lKECPJIcHOcmIOkwBg31wdyRdgrgvUC4L7pqvEtrSC8VafyRRny7tbLq0kxjjOCaBDZtXWHwyFYna5UHk1gMuqePcOB1N8Jj9DJfCHSoT2GbhyqU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 2 May 2023 12:34:01 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: xen-devel@lists.xenproject.org, Jan Beulich , Wei Liu Subject: Re: [PATCH 2/2] x86/trampoline: load the GDT located in the trampoline page Message-ID: References: <20230502092224.52265-1-roger.pau@citrix.com> <20230502092224.52265-3-roger.pau@citrix.com> <11b24761-9268-e647-7316-0bffb549ae6d@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <11b24761-9268-e647-7316-0bffb549ae6d@citrix.com> X-ClientProxiedBy: LO4P302CA0010.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:2c2::18) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|MW4PR03MB6377:EE_ X-MS-Office365-Filtering-Correlation-Id: 1f05ead9-979c-4c7e-6d29-08db4af8c22f X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0/3WxzpTu7Lkw1YweM6WqWo72QQQkY45SZYSH1EwD9GNw0x7MqMXtpY3aC/4FBCPoKGCIhH3LnC4uUWecFYwMRxaNWzQXzxG0Uu1gobWLJVVpx/mRP2gI5FneJJG8I3Fq6qCHdHDMcd0/oFPp25q+Hn/hzUsMv2QQUY9tXr3NJELjC5vTS/qVQ8lATsxx+dMypdbc9gXAJhsmu4LJIZOfbUZ4Z3L7qldVrukRuVF7UgcEg8lzZW/YS/RedKJzod7rgXISXn9d2DiyRlIaZRCJrhCyYL047tl3tQVVfb1nPCyqnLYmeOVLRDVhtJqxdmb1I+YtwvHZ2HAkGbYz0ZRTc1mwFk6hp1zn6XaO5eZAYcAc2r9fbM5MPLKTpTbUxWzSIx+R87KApZqmmqRDaKQiMTmxB/8GnnOI9jfIpF7FA4jYZKnHyzYDa8OaCGMCYy37G1Yp6JGEtsoGuMvhGcBb5+bVGNnJ0/IfpYn20jriu7YRm94vstNo8T/8HsHJ3XCpUAx2FK/KBfjbIwHv8P/Y1RIcOI8cI3hU6Bh7ALkzqHxNiSHsj2A06qgxox6fM1S X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(7916004)(346002)(39860400002)(366004)(136003)(396003)(376002)(451199021)(4326008)(6636002)(83380400001)(2906002)(5660300002)(8936002)(85182001)(6862004)(33716001)(8676002)(41300700001)(316002)(186003)(9686003)(6512007)(26005)(66476007)(66946007)(53546011)(66556008)(6506007)(54906003)(86362001)(82960400001)(6486002)(6666004)(38100700002)(478600001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eXM4RXhBSGxXVm1sVXBuWnY0Q2FQdHNrU1pzR0RpN2hteG91MnVVa1hpTmt3?= =?utf-8?B?NWt0aHhURVVUUEhzRnBmWmZDZnZIOFBQZlI3MDNHYTRtWndxdUMvTFNrcHlJ?= =?utf-8?B?TWZ0b1VPNVpwS0VyYkJua1hwbmhRR3FGeGlQOU9hNEF4ZFNNSytRMHY3Tkkx?= =?utf-8?B?dnRMOFRkTTJuekI3VXFuakV4MkNvUmNrclZ5T1MxNC9iMjVDTFdhRUhuVzln?= =?utf-8?B?OXVCZE16RHpBMTA4K1lMcVNkNW5QZWZuRi9kZXFNUFc5aXNncSt6UGFCVXhD?= =?utf-8?B?dm96NjlXcy9Za1ZIRElCVWxvUFJkYVptSURNcGxSbTI4eERGdGxkUUF2RDhm?= =?utf-8?B?MzNEcEk5VFRWVCs3U2RrN2hxcUFCNmpxY0NaT2R4WTMvSTZXUlBMR2pzSUtR?= =?utf-8?B?aDJ3WU5SYUVxVWQwRDhlNDc4MEVydVkwbzBXNXpGdEJQblRFVFZrWXpTN1Rn?= =?utf-8?B?cGYrUm1ZOEpQc0toMzZqRlhWT0RVN0FVbW94bmZTMjAzMHVGWTRmZnlCNVk4?= =?utf-8?B?RXB0OHVxaXFzdDNtVFBoU3M2b0c2U0g1NGpnRXpLKzN6ZGdwZzhKU0UvYm1X?= =?utf-8?B?RGIwSlFCeE53WWdOWGQzYVNWSkswMWpDMlp3Q1hWRnIrQ3l3VFgrbml0TUk0?= =?utf-8?B?OWF4N05QQ0ptZVRncFhVQjdPeG5qbHE3Y2RlS3pmOG1abHpRSkhCZkhPSkNi?= =?utf-8?B?b3hyck0zRG10cThOWjNnMEdqdFZONE1JVFBhYWgvblpsdGh2R3FvUmdnTG50?= =?utf-8?B?UkF2dGYrSXV5TGpQZDZva2lvT0t5QmNZUlRUMVd2NGdxVFh3bWNLRXlOVG1Y?= =?utf-8?B?dDJudVVrcVV3bm51czYrZzFQNUlYV1hLWlhXdzNSTWJmMFNraVY5cVcwVWlt?= =?utf-8?B?Y1YwdkxVMXJJYm1tUzAxVjd4MnZrY1JHU0FhRVFJcUV4OFJma2FuQ1pIZThN?= =?utf-8?B?VDY4ejMwaE1sQkVjV0ZOYTFkeTMybk1yc2lzUW80cVp4KzNHMjJiRnZOblRu?= =?utf-8?B?WWlMeGVJQStpLytIZU5URy9iMUpjaVlSUnFVdS90YStHUEdrM0l0eitRNGc1?= =?utf-8?B?VFBaRDlpNUJwR29URHlpL2NpdW1KbTRLYzhteDRxa2xaSXRWeUYwT1NXMUNs?= =?utf-8?B?WXRkSWg0Si9HcjFXMjdsQk4wZ0xaQjZ2Z0szVDhTT2lDSkdXK2tXS2ZCcVYx?= =?utf-8?B?Mk5jbWIyNGJNcUpPeS9OaGM4NVh2TFljMkYwQVhSY2E1K1lweUROdWdPcWxO?= =?utf-8?B?Tm5BVGpTdm9ZZmFCb254U1BmVk9wWlY4V0hZbHByQ3R1a0p6SStkczM3TDB3?= =?utf-8?B?bklvRXNuNHNoMkRBK2N0U3lXdmpTY2Z0clVpU0sxaEd1blBDMHB6bzZjcC9S?= =?utf-8?B?Y1hNRXF5UXVMemJla0Vmb1E1TkVDLzZ5dis3TnFmL2VEWjdDZUQxNW5CSkdX?= =?utf-8?B?SXk1Vm1EcTNrZUhTRVZCcDJaMXQxZXo0TnRWMThxdGNyYThJeWVqV1hvZmpy?= =?utf-8?B?L1RQMEREeVUwRWo0Tytnd2hDMVhod2czWDRnYy9DYkQxcmFES1o4RVJpZXgy?= =?utf-8?B?MVJJVWJVSUxpQWNqaS9IdnJZOThMYlI1ZGFBOE1sdnJ3RkVOUmNuVS9qeUVK?= =?utf-8?B?aUF2eDd5RWp0d1pLWHBrM283QlBPUmhWM0FHc29JWXJkMmd5ZFZkSzd2cUFz?= =?utf-8?B?bnlaeGNEK1IzWkhEUkp1aUNobFpCZmtRZjBrTnRqWVR4THV0TU1TYlFYUWpW?= =?utf-8?B?cXJNamR3eVY1bGRndE50blRTMUJtMUtmV2ZuNzVqQ0VZR1U4L01yOFR1UUNa?= =?utf-8?B?ZWpSSS9HY0xoWGU0ZnhhcVBlQ1pDZ0lHRFF2SkVNYW00VWxjNWN3WS8xbGND?= =?utf-8?B?OGdMREtadHlwZDVvQ1JDZUM4YlU1TmIzMXFMSkgzZFh3YXl6NFBMak1CK1ZJ?= =?utf-8?B?OEhDMUszMVM2WjVoTnFJRDRockkrOFZzRHhPT05rTEVTUUlBUXR1NUFyd0JT?= =?utf-8?B?ZHdMOGorOXNnY3hVMENqZXI3VGpVVmt6elp6cktvWTMwQlJrSTY0ajBGeUJY?= =?utf-8?B?WDBjOWFtTkNFZHQ0b2pQbFFISDJyK2luUnZRbG56MEIyYzdNeWxCaDUwVmRo?= =?utf-8?B?azJheVdJVnZLNzR2aUVqZVFTQlhaZjhDSkxkbDY4eHpHaGM3b0IyWEVoOW1L?= =?utf-8?B?QVE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 1OOtrEE3Btos8DXXC67djlIg8QlU0OmiGKiQDk2zJpbh4kkQJso5YUyRLodoAHb9YQ1CW7sHZnMNbcN5ElsBbdAISbQ+6eOnLNqK/puHn0f+l4O7tBMtLAVWRXmpIUOYlfBR2WpkGIeeA1Jdg5hb+nL7BrUM5YUV13439AxS3jwiiGXicPWtC7KwfgT3xR51NdhhQmhacCU7Q9XB/1cCu0vv3Vk2/M8xBcqDxrzMrvt60L/8bykwL4xOJB/lQ7OUtvRxUjhjmFWiFHVwBmiQH/CX2PA4mYe2aZ0VZM8G6/DYLWsDcfEV8wpSfps7DDl7nUStjOJ4+WXYf3EbKZhCZGFteiCFvDNDD38Ta/GQj7vhSi9453Y2PnsVnbl+7SCYYYAGb1llEHTpBeSKZVUGxZLkXIQ2ldqguIlAScukjQ7zxnbVoV8yy3tuKOfiZ0D3ReitCpE7VzNJA+sC1cAg+Qz0+ZEcCgLLoBfymqStXeTcfye79ZS75umbGAPtHb25dx5hDDOWtXxYdll9F+8pmtnaeShCsUmMDrVuAoocEStKbT9Tw5WvCWUXI3+RCAw6KNeA+DQPeKygCGWGuXx+QgYkJVvoiWkrE2kqbFN6wC9IKEtYRg3UgpHVpuCrntqL53IA6d8EdYaRNpsw0TNfpt+LKoLyvfnMiuZZLbtZShTe/HnAmAb/TI33oh+g8TOsoJT/P3xgFZVZX77TAdlBxOQXYjfnPEsmzIDmkXSRMivbMVrIOrj9P0pRExH2OyKB4zd4XlKwa/aecTw6BIAPzmGqNvucbViy8aPjf9be6YY/9dGxKrM7Rz8TiMcQ1N4/ X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1f05ead9-979c-4c7e-6d29-08db4af8c22f X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 10:34:07.5778 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1jeQzUA6PEPFeHoJUObp0qEN2xXLkzgpTwSHyCtF7kO5IrD8umptI/dOJDuKdiRSd7hSezm5pVvK0T08eSwcHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6377 On Tue, May 02, 2023 at 10:43:13AM +0100, Andrew Cooper wrote: > On 02/05/2023 10:22 am, Roger Pau Monne wrote: > > When booting the BSP the portion of the code executed from the > > trampoline page will be using the GDT located in the hypervisor > > .text.head section rather than the GDT located in the trampoline page. > > It's more subtle than this. > > gdt_boot_descr references the trampoline GDT, but by it's position in > the main Xen image. Right, gdt_boot_descr GDTR references gdt_48, but the instance on the Xen .text section, not the trampoline. I've tried to explain this in the commit message, but maybe I've failed to do so. > > > > If skip_realmode is not set the GDT located in the trampoline page > > will be loaded after having executed the BIOS call, otherwise the GDT > > from .text.head will be used for all the protected mode trampoline > > code execution. > > > > Note that both gdt_boot_descr and gdt_48 contain the same entries, but > > the former is located inside the hypervisor .text section, while the > > later lives in the relocated trampoline page. > > > > This is not harmful as-is, as both GDTs contain the same entries, but > > for consistency with the APs switch the BSP trampoline code to also > > use the GDT on the trampoline page. > > > > Signed-off-by: Roger Pau Monné > > Reviewed-by: Andrew Cooper , although ... > > > --- > > xen/arch/x86/boot/trampoline.S | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/xen/arch/x86/boot/trampoline.S b/xen/arch/x86/boot/trampoline.S > > index cdecf949b410..e4b4b9091d0c 100644 > > --- a/xen/arch/x86/boot/trampoline.S > > +++ b/xen/arch/x86/boot/trampoline.S > > @@ -164,6 +164,12 @@ GLOBAL(trampoline_cpu_started) > > > > .code32 > > trampoline_boot_cpu_entry: > > + /* > > + * Load the GDT from the relocated trampoline page rather than the > > + * hypervisor .text section. > > + */ > > + lgdt bootsym_rel(gdt_48, 4) > > ... I'd suggest rewording this to simply /* Switch to trampoline GDT */, > or perhaps with an "alias" in there somewhere. "Switch to the relocated trampoline GDT." maybe? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 02 10:35:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 10:35:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528470.821654 (Exim 4.92) (envelope-from ) id 1ptnLa-0001QR-As; Tue, 02 May 2023 10:35:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528470.821654; Tue, 02 May 2023 10:35:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptnLa-0001QK-82; Tue, 02 May 2023 10:35:02 +0000 Received: by outflank-mailman (input) for mailman id 528470; Tue, 02 May 2023 10:35:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptnLY-0000rl-8h for xen-devel@lists.xenproject.org; Tue, 02 May 2023 10:35:00 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2061a.outbound.protection.outlook.com [2a01:111:f400:7e1a::61a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fc38dc79-e8d4-11ed-8611-37d641c3527e; Tue, 02 May 2023 12:34:58 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7323.eurprd04.prod.outlook.com (2603:10a6:102:88::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.22; Tue, 2 May 2023 10:34:55 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6340.030; Tue, 2 May 2023 10:34:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fc38dc79-e8d4-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QxBayhTqCq0MCoE3vWzmlDwvCQWYI9X1gEybsZapi8KRUBLwOgtJQf4HtcR4qkDCGuZZ8OFIQYS8G4qvbxrfFYeVryjVSYqC+6qfgfwXHCZa8JEzjKD/ZAZsOs9WsnCsd1zUmspgrjshLSRPbbB6g9Hm7vE1VaOC3eUKfZU30sd0Jw8B1xfwUaDIWkcakwqSad5A82KkwMt2ie2WxdQVFfCsmge5XJv+xAnctnHiSulTE4qOeljSKYaKW2oKG0/OuO6vm6rI8jyufUHbi/VyUAVUy20erttOTAytvBmgD9iz0qKjUdd+zoPLqm7j3d+IcabsCC90W6YWHkXi8nxYkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d7BwD3nBy3IrkV7OT7lKA7OJfSsO4zE9CNbhIE0PTCM=; b=lhCIcastGiIvCz1c6MR7uQEHKyjlFR6sNDkLRVuuj5aohdtqZTaEgzg6Nm4ZF2rjGPm3KldGeQQ40BFUy5QtZsPI7zq34jc2CTCRsOrhaNPG+3GhMXnhEm/CamJ/HzIrLIZtAGHEOS8M7emENYwn3Toka+F7rHuQWl7FjCLy1AeN2238D11AbgOm52XpVGqcouv5xDIal+GStngJLAbTHn61PdK34sGxG2xhgzeULcyqg53YJs0yNoPiPH4HVApk/i/grmh3mj9hTsBcaT+cALC10WsE0xplJiCp9EQ0LPkBiADe6U+wd6M+9D2AOFiCYooNAPUMufGpwgIIM1xnUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d7BwD3nBy3IrkV7OT7lKA7OJfSsO4zE9CNbhIE0PTCM=; b=t54zU0UAhhEYHFPHE0FuTBGn4y4kTjH4tLgAtCtRQfYWU5igA7uo6zv6D14kEznIRhIPseh6386muAAd/5tm1Fveh4b9JqBp4POQSVZUSzcMJrEjDxeus8O9A5ohe8VepzawtnNl/LQwTvBOXsnvtoQ8fs7nWnjqieKzFQrR/Y34ygvQjBSwBEHwGcVy04o2VmpyepAtjn2a6yjN8EgBbhv2o18KRAa3ijFLWMRSYVpoOcRcf+ijcIwv80UnTacTQ1Zst2N8Yh5T4+zo1C0qWsmCiW7urs4AawBQS+lozFhzh1cnC0DP5hmo7m5c9YkYlpo4Ll7KnNA1B4IVYq9w7w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3154d046-7ba4-63c7-e2c0-9a7e06128ebb@suse.com> Date: Tue, 2 May 2023 12:34:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 1/2] x86/head: check base address alignment Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: xen-devel@lists.xenproject.org, Wei Liu , Andrew Cooper References: <20230502092224.52265-1-roger.pau@citrix.com> <20230502092224.52265-2-roger.pau@citrix.com> <89389465-f32c-7dfe-f62b-b957e2543cb8@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0092.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7323:EE_ X-MS-Office365-Filtering-Correlation-Id: 72169607-6f3f-4f7a-ce70-08db4af8dee1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Am5vrgLOQDuYhZt/PD/FSXEOEMv/Z01pR5H0rSi2Vef+/BjJM8At9q3W20q1yx/xfo+1upEwDo4JKeeYYLipjw646KUNUuEG7gB12A+pUCHriwwBnkz5EHjVEDyOOCSx3CcpQxf4j6NkE1z0YgY3nesVVdz9S+Q6xeQd8vXWoUNL6CQr2D3OQXIeaGmCu/rltce8pAkjl4HgSiNQU4scns8Q60O2tz0e+n0Cld42rJL9Gr7GWxA/+uYBI5GemQ08kTyrbqfDzUb8Qtx0L67hvJOh+2IrlWqiXcex2pP5tCns8FtrCU1n/SM0HH7IeaxNkBsX7RJipypAw6mAbEGojvynM2jdAtxTufKsDOntMWEaqBnXN2GmDb3oWTWWZrJkksxFzJbuGCPUlU+XJAfQkOUoxuJsHGSVA3Ew/DjrhDzbjOKDonvCFyIBdKZvhAu1uIrQvxiqx+WudTitZsPntlLLTaHfL0rP0SaWK4A2HM6EdLLh12WJssDeOiiblmgTBHPj/26HKunsTXos/YQwet/7xLDdm5aARo++Tq57yhP4v96luCcCpzoJUX2uv3pwe0qej/nHG/8asAkG7mImGQfpAx3t/PkUgSeYJ2rTYb7QMyjmerafEfTYJ9V8rPJeuaw5iJO0klw7bTyN3CjySA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(136003)(396003)(366004)(346002)(39860400002)(451199021)(5660300002)(8936002)(36756003)(316002)(41300700001)(31686004)(6916009)(2906002)(4326008)(8676002)(66476007)(66946007)(54906003)(66556008)(478600001)(6486002)(186003)(26005)(6506007)(53546011)(6512007)(38100700002)(2616005)(31696002)(83380400001)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bFJCMmpjVm5vNmdUejFKSFdSQml2OEhzYVhtU2lBMzhSMTVWM0xvOEdPQUdL?= =?utf-8?B?TWFsdU8wVTBpbWZLTndpS0piSnN6Vi92WUFZbDR4Yy91OWpTMTlvYUU4T0FB?= =?utf-8?B?MGZ1M1pRd3JhcDZOcUtreWN5Ny9NcytXNzNtbnU5TE01dWM4WEFhL3ZxS2ls?= =?utf-8?B?b1laNk1rMFp4ZG9jMWVUUER4THI2VlhHbXJGcmRrclQ2NjBzMStseTQ1ZERw?= =?utf-8?B?MUZUMFJNSDMzaHBwaWw2dXdpUERlWkVyQUxjRU5BZ1dGMis3UFhXbHJLMHFN?= =?utf-8?B?WkJ2WXFkRGxUOThCQjdtS2IwNndmMVIrNWxERVN6b29pTzZOcHNkMmpuQmhG?= =?utf-8?B?MXU4cGZvSnA4RG50QmxSWmtwOXdDcjlOcXgyRHV2UDVXTGYrc0kwdVNpOU9s?= =?utf-8?B?R0NGNDgrQ1NJeUlndUo3YU13SmtSRytuYThGalBWUExxc2tBSVpqa1UrdWhV?= =?utf-8?B?SnF6aEhlNmwxdk5rdGVHY1Vqcm1LNmdueEVaUlFvL0txaFJWRnBrbGtNbXNM?= =?utf-8?B?WUVPcmN5OG0yYlNYRW0xUjRLUzlzMk9RWUh0R1Avc1lNVG5LU3UzajFjaHNH?= =?utf-8?B?enR1VmxmOVp1NW9xUmppWkloS2hNdnhPM0Fjd296enpyK2FCd0RnUlQ0OTdR?= =?utf-8?B?UzVFbEo1TVFqSU41WTMvYUFBY1cxNlh5bmRFNmtVYXR1ekZYRDc0QS9aMmR5?= =?utf-8?B?eHhES3R1TFZkVGV2bUFXVlB0d2xnOGVWYkc4TllBZnJHcHg1R0lMYUN2Rmlu?= =?utf-8?B?VEE1WXFTNDZGUmRDdlNRempLRjNXWERVTkEwOVIyVzMvYm45YjA5NE4yS0Vt?= =?utf-8?B?a2I5RG5SWEZYZVV1V01iR0drKzR6QUNOWkpQbTQ4dXI5ekpyNTF0NHRsY3do?= =?utf-8?B?N3JvYXBqR1F5QjFIZmw2WnQ3RVZtN3hvYWFOSXYvWWVQWUVFYTF1eXpWcVVS?= =?utf-8?B?QngxQ0FOblBVNlFzZ0tnMnh5UVNEVGc3Vkd4TmFEdGlQQ0VFSWoxVG45Skk4?= =?utf-8?B?NkdiOFp0VkRTeU9qM0JjWUxGZGcxdzhuVmRuYVhqc3BqUUJLVTk4WnZ1RGYr?= =?utf-8?B?bmhja2JkYTVuS3FDR2tiY1lhWG5OZmhIN0Fuc1FqWnQ1OGJtRWtaY3dCbkJK?= =?utf-8?B?Wk5uT2NQdS9oWmVnUGJHa2s1MURnQmZZOHVoaFVHS3FjT0hZUEFyc3h2UlBw?= =?utf-8?B?WDR6SjVzT3phL015L0h6Y2hrQnpjbVJaN0RBZ3ExSkdZd0tNNWVDaUdOVzB3?= =?utf-8?B?blBlZldrNzVLM3JtamxmSGZZaFRWUzBNc2tHTkUrVHpmeHR2NFZ4OFlrVEpq?= =?utf-8?B?UzFOd2JKcUU5TlUySG15T3dxUWF4R1hxQ09vN1ErU05mbW1YZkRzVFlKMnFS?= =?utf-8?B?R3dEVTdPdk9kVHAxWi9USGdvcUNDOHorbVkzd21kdlE2Z2VyRjBSWjZGSjFu?= =?utf-8?B?djFPdGdxVHo5dU9SSVpqR01ZK3Y1VHJqTkJFSzIyV05OZC8xejdJaHVJMW1z?= =?utf-8?B?QmUxRVV6THY3RURsQUhucmY4N2xkQ3VuUjViYkQxaEgwdW9TVDEyR3JQdHVW?= =?utf-8?B?aHBuZ3JRVHZNVGQ3MW0xK05MSjhjZlcwQ3RiVFBUT1FJWXVzeGl6TlMyZDlk?= =?utf-8?B?aVlLUWloLyttSzJ2RGUxTlZJVDZPdUlsZGx0ZW8rUWQ1elZQNGNRUStqdDFV?= =?utf-8?B?NE5aSFQ3VEFmcjBUVGFiSXpsNlFkSEFHNjNSaHhSZmgzVStVZVVYNURSV2dj?= =?utf-8?B?MnRsazFqSkorWkwyb0Fwdzg0RXRNaXl2M0F5WEtUQW8zbkduQ3Jabkw2WlIy?= =?utf-8?B?aXdLYTdzemdoK2dmTkdrcElWTmJPQU90YXk1LzcyaDMwUGl0N1Jsa2Ezck9U?= =?utf-8?B?MmJJTy9tRFdzdVJWelltSFFrdEh3TW9mUHJVTUprU29QUEVNendGbkZ2ZnF1?= =?utf-8?B?b0lhc0hNWFYreEVscUc2VmI1T1FaVjJkTHBZVnlYNUtlUWg4dnBKZVFWbWtY?= =?utf-8?B?Y3dNTlVxVE01NXJSN3pTZXhzdUI0dGM2VCttT0VjYlVKYkZDZmN2VlBiMGx5?= =?utf-8?B?UVg2aWZYWlprekJ2ZDB1WVlyNld4SkUwTW43Q3M5NkhLcFFkWjB1amMwdE9T?= =?utf-8?Q?ZZP7GnbZpRzYM9J7SjZ+LxFdO?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 72169607-6f3f-4f7a-ce70-08db4af8dee1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 10:34:55.5963 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qj1VzCQl1bBAsVexQYlsOqFxcj0EMwI6uODGarzCR6iucutfovXI9ZnWViPU3SiRBiWpF9MmJV5rU9jDiXgS4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7323 On 02.05.2023 12:28, Roger Pau Monné wrote: > On Tue, May 02, 2023 at 10:54:55AM +0100, Andrew Cooper wrote: >> On 02/05/2023 10:22 am, Roger Pau Monne wrote: >>> Ensure that the base address is 2M aligned, or else the page table >>> entries created would be corrupt as reserved bits on the PDE end up >>> set. >>> >>> We have found a broken firmware where the loader would end up loading >>> Xen at a non 2M aligned region, and that caused a very difficult to >>> debug triple fault. >> >> It's probably worth saying that in this case, the OEM has fixed their >> firmware. >> >>> >>> If the alignment is not as required by the page tables print an error >>> message and stop the boot. >>> >>> The check could be performed earlier, but so far the alignment is >>> required by the page tables, and hence feels more natural that the >>> check lives near to the piece of code that requires it. >>> >>> Note that when booted as an EFI application from the PE entry point >>> the alignment check is already performed by >>> efi_arch_load_addr_check(), and hence there's no need to add another >>> check at the point where page tables get built in >>> efi_arch_memory_setup(). >>> >>> Signed-off-by: Roger Pau Monné >>> --- >>> xen/arch/x86/boot/head.S | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S >>> index 0fb7dd3029f2..ff73c1d274c4 100644 >>> --- a/xen/arch/x86/boot/head.S >>> +++ b/xen/arch/x86/boot/head.S >>> @@ -121,6 +121,7 @@ multiboot2_header: >>> .Lbad_ldr_nst: .asciz "ERR: EFI SystemTable is not provided by bootloader!" >>> .Lbad_ldr_nih: .asciz "ERR: EFI ImageHandle is not provided by bootloader!" >>> .Lbad_efi_msg: .asciz "ERR: EFI IA-32 platforms are not supported!" >>> +.Lbag_alg_msg: .asciz "ERR: Xen must be loaded at a 2Mb boundary!" >>> >>> .section .init.data, "aw", @progbits >>> .align 4 >>> @@ -146,6 +147,9 @@ bad_cpu: >>> not_multiboot: >>> add $sym_offs(.Lbad_ldr_msg),%esi # Error message >>> jmp .Lget_vtb >>> +not_aligned: >>> + add $sym_offs(.Lbag_alg_msg),%esi # Error message >>> + jmp .Lget_vtb >>> .Lmb2_no_st: >>> /* >>> * Here we are on EFI platform. vga_text_buffer was zapped earlier >>> @@ -670,6 +674,11 @@ trampoline_setup: >>> cmp %edi, %eax >>> jb 1b >>> >>> + /* Check that the image base is aligned. */ >>> + lea sym_esi(_start), %eax >>> + and $(1 << L2_PAGETABLE_SHIFT) - 1, %eax >>> + jnz not_aligned >> >> You just want to check the value in %esi, which is the base of the Xen >> image.  Something like: >> >> mov %esi, %eax >> and ... >> jnz >> >> No need to reference the _start label, or use sym_esi(). > > The reason for using sym_esi(_start) is because that's exactly the > address used when building the PDE, so it's clearer to keep those in > sync IMO. Hmm, while I see your point using sym_esi() here merely means subtracting __XEN_VIRT_START. Which would better remain 2Mb- (and even 1Gb-)aligned (and if you wanted to guard for that, you could add a build-time check instead of a runtime one, e.g. for sym_esi(0) to be suitably aligned). Jan > That's also the reason for doing the check here rather than earlier, > so it's closer to the point where the value is used and not being > aligned would lead to corrupt entries. > > Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 02 10:35:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 10:35:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528471.821665 (Exim 4.92) (envelope-from ) id 1ptnLu-0001tM-KQ; Tue, 02 May 2023 10:35:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528471.821665; Tue, 02 May 2023 10:35:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptnLu-0001tD-GV; Tue, 02 May 2023 10:35:22 +0000 Received: by outflank-mailman (input) for mailman id 528471; Tue, 02 May 2023 10:35:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptnLt-0000rl-CL for xen-devel@lists.xenproject.org; Tue, 02 May 2023 10:35:21 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0815b569-e8d5-11ed-8611-37d641c3527e; Tue, 02 May 2023 12:35:19 +0200 (CEST) Received: from mail-mw2nam12lp2049.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.49]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2023 06:35:16 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BLAPR03MB5507.namprd03.prod.outlook.com (2603:10b6:208:284::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 10:35:14 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb%4]) with mapi id 15.20.6340.031; Tue, 2 May 2023 10:35:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0815b569-e8d5-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683023719; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=R+AMK7zkOiW+LnEf1od1SO9FS24cWue2G22D2IbXJWM=; b=OtSZkT1HLzwFIt/qq6giEXsuesyhS4G58iu7p0Afleb2UUDIA6TnFhuo 4LSPMp5lJO1cNqsfPAO8HZIOvzK9kBVE7qu249ZCW8If7REjKmItMTvGn voSHMhuLiRM7MnPjsIXaP2OvUDvzFlMtncfD034RSsnZIXZ5K2cC2KVvL U=; X-IronPort-RemoteIP: 104.47.66.49 X-IronPort-MID: 106882132 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Ts4MW6/iy0m4UVtnxmkvDrUDon+TJUtcMsCJ2f8bNWPcYEJGY0x3z 2AXDz3XOa6KMzb0LYhwYYi3/U0G7JPcyt4wGQc+qi08E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kI+1BjOkGlA5AdmOKgR5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDkkep Pw9CjY3QSmNnsSN5O+mVvBOj+sKeZyD0IM34hmMzBn/JNN/G9XmfP+P4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTaNilAguFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAuiANxCROfhraQCbFu71HVUBBwTXHeCs+inh2myRoNPc Go65X97xUQ13AnxJjXnZDWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOnM08SCEu1 1SJt8j0HjEpu7qQIVqC8p+EoDX0PjIaRVLufgcBRAoBptz8+oc6i0uVSs45SPLkyNroBTv33 jaG6jAkgKkehtIK0KP9+k3bhzWrpd7CSQtdChjrY19JJzhRPOaND7FEI3CChRqcBO51lmW8g UU= IronPort-HdrOrdr: A9a23:l8P3U64j5jJiDGMW/gPXwNnXdLJyesId70hD6qkRc3Fom6mj/K qTdZsgpHzJYUkqKRMdcLy7VpVoIkmxyXcW2+ks1N6ZNWHbUQCTQ72Kg7GC/9ToIVyaytJg X-Talos-CUID: 9a23:jbbHTGE+7ecMc/kuqmI3pU4xOMYfXUTT1VHrBxKlFX9LQZK8HAo= X-Talos-MUID: =?us-ascii?q?9a23=3AjNAqwgwib5BeGdpRn4xnLBRiTZeaqLa3T0wMlJw?= =?us-ascii?q?qgtuVKyFXNyrMnG+RbJByfw=3D=3D?= X-IronPort-AV: E=Sophos;i="5.99,244,1677560400"; d="scan'208";a="106882132" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f335TTLAV6yBmzpReSgML1eNRD/hvsyhFK7YtZdHGMt4fmskG1rgaKWXi7XHtttp90GsaOq20irEy99MSGiIe/TqsOlRV7/ADFYuzvss6Tz00vv3xszLO+kYCdSEBEg7+XiL2p1Sc7tdOQYxmr/ZVaxRYtOOsPg+CXlJfOzmr67xHlo+JA4IHpGTX4o+FVPoknBAz7TJXqPdnQ7uxopiOBTFGX+DC/82QvSrzsgecYS5DNsFkYclWHGToYxed5neN8hHwq/6COE91NUqG9YERBrRkF/xRJX++IqVaAMvosHTmt3Bl3+QfMaZjItcZAVup/H+0EUaTmYEfxqbTXUc9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7jRCMgEtM32NM/MjsLxwPGxdGv3dmM0sdW8hY20jarw=; b=J1nWLPKwtrQT+uUvMEP/7UASUwy9a7/rOvSxKZQ9JXf7YelkYnMLAChJ2ODs0LQfm4bAlTouvLsLXrK4Mtbrm2KsrJUp6Oe+9C+0f1rsy/2lScLhA0UO8q/J8LoVITVeBUve+pvlf5OplwDPUoTaiOjp9iKznhABip1yDxMVnQnAlh5+Z0A6xjIlRbj+ag+YGWR2Gwih3/Inu3pj+4HW41aGMsd+QuLhvyAc+RjcRCeCzxCZDh4t5dhFMSz3tjFjkTPhBi6fkfcSngULGtiYnR/s8/skKAc0HjV7mnZEMJYy+UxV1NxSq0c93wO7YB1XDx4wudL3FRelJC+82wo7Xg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7jRCMgEtM32NM/MjsLxwPGxdGv3dmM0sdW8hY20jarw=; b=kwMON9oe6rWVwo1AcmdRJd3HL/T9ZfkeMoQQ4HOtCEWfTGtk14VCM9PaJ/qrAgIq0uo1A2J/HjcmlD0Ot8tx/Vbor85f7DrGAN4+i6eOkzrNhICWABeU6GvR2blEMOzmc/JfVlgplYQ0GLbyk/+tE1lE3YQvFvtuR+K2LxtS2RM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Tue, 2 May 2023 11:35:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: Andrew Cooper Subject: Re: [PATCH 1/2] x86/head: check base address alignment Content-Language: en-GB To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: xen-devel@lists.xenproject.org, Jan Beulich , Wei Liu References: <20230502092224.52265-1-roger.pau@citrix.com> <20230502092224.52265-2-roger.pau@citrix.com> <89389465-f32c-7dfe-f62b-b957e2543cb8@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0368.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a3::20) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BLAPR03MB5507:EE_ X-MS-Office365-Filtering-Correlation-Id: 75da98d0-ff16-4db4-0782-08db4af8e9b2 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6UFj5GnSKv6Zyk37+kG/d+fOHuVMLSHZ/UuYaHqo42ZzyqtEy87w1Qm8yog719wMQhnZbA/0gUOxdTKcr/iVBdkBZn3zxCSFbDvxvUcmvQM25e5kdGvgmnIEAk3YkPDNHVCaKSPvu8mOnljY93VDdiWZEI07bW2Wxl5lIlAwTCpXxr8dtC9ND+dSYUBpv+5cEWUP6prVOKV8j+lekxlHtnkFIVY7OOOI58+MgQkblKhUixUiR5BlMTaHIHOEEl9rnrcasWi4e3kh6jTp5+xUFW9UYHEXVwn+YW2lwrUJqnO66Mft9pEHTEBernbLcJLPITpPg0EIBASS5RCtlCRDpgjVnJQYYDmTZ0LR44ZYPUmfg1wrCMWsE2s4iLbxnUZ4ozKBGzVxD9Vduk1BBxroR0AONmDEPlerCUfOHsHI7xc+vMw8Th6hfD8mw3TG8xRCufRgsuVYlwCak9oZQ2anYEi8AtqivbY+G9bLtEOZYIWldzYWQlnlLrmfriLRPxqkQl5vaWq1oo2htzFUO8MwkbECaCbElAUv8Oo/+DLmD6JPuFFyLzVfB60yMOuZ/OE04TwvfKHTDK9fz2DUo9gYcgeI+X5PxJkQdyEByut3ChFx6mmLLdijSZY+UyvsEehi4gFm6mNEV4wKmAUePionPQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(346002)(376002)(366004)(39860400002)(396003)(451199021)(6666004)(6486002)(186003)(83380400001)(2906002)(53546011)(6512007)(6506007)(26005)(37006003)(478600001)(2616005)(31686004)(36756003)(54906003)(41300700001)(66556008)(66946007)(82960400001)(316002)(86362001)(38100700002)(5660300002)(8936002)(8676002)(6862004)(4326008)(6636002)(66476007)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZWI2NGhBYm9kNVlGUHdSc2tFQm9ncGtnVkFsVDdkNGhFTWdjSlA0SVU4dkhC?= =?utf-8?B?TmlHNXZIeUNHVDdHNGJyRUZ1YzhhLzVHMTZ3OTY2Zmd2UU1Ic0lJeENmSzBi?= =?utf-8?B?R1Rnc3RSektaaG55VTZVWWUwamQzVDV6OFRSZWJ5Nnk4c0dmbWhPeEhMbUtv?= =?utf-8?B?WDh2WDNlcWNLd2ExbkxMclI2VTNQUjBVNmt0SzFlS3RWSWo1blVRZFF0Z1ly?= =?utf-8?B?Q2taUjdDY1pxNWoyOGhDdGRGOUd1VzNvNkcrYjBnTjdKb3gxaHc4b0oxS0pR?= =?utf-8?B?ZGJocXBHQ3hWZmpuTVBydkFJYmNJNmRXVWlqRFVDcHhkSVFKeVkweWdhcXFw?= =?utf-8?B?UVFlSXZYZ1BPNU1Vcm82dC9oc0JhU2U2LzJmb3dDY0FnRmNSN09oTXJsWjFL?= =?utf-8?B?bHYrSDVPWGNZclZpRkgyVmZxejhacDB4WHdZTnFnNnUvQkx6VTgyeE1xdXpZ?= =?utf-8?B?M1ZaQTMvN0hkT3RsWVh0UTAyNGtkZnBFcWo3RW5GWWg0NGM0UUZYNXF3Skll?= =?utf-8?B?SFN5RHl1MmlkcDNvZENmZFhHbWVZaHNLUDh4VmR5MG1jcFJVR1A0Mk5BM2Fr?= =?utf-8?B?LzF0S1Z4dW9NZ09XeTNKdzBBZHVtc1N4UGdiQVNVcmxOa1NIS0tPSVBSMTlW?= =?utf-8?B?cDhnUVpCSWpBbWYrMDBVZ2syeFJNK3JGNmxrTytobVAzVEp3bTkyQm54SVVW?= =?utf-8?B?Z0h5ZFNOVHp1YzlTRzM2RnJZUlB0RjVsU0RlSDlCSUQwZllMQWljYzdIbUQ1?= =?utf-8?B?UGFjUXY1QUVId0NweHlTYmw1b0RSeS9oNzB4Y0o5RThKY0xZWHlTVG12UmZq?= =?utf-8?B?eXBnbVhGZ2h3YVFkenVGTWVBWEl3dERWQmNiZGRvSk83d0t0UHRFdzZXN2Jx?= =?utf-8?B?Ym5EWGkvN0I3SHArU01vdHZDaUV3MWJnUnJwc1dLN2dKbUZVV0hSQ0thQ1Ju?= =?utf-8?B?THFQYXl1QldaZGJnL0txVXFPcUxKOGdlWWhnOXRvdVU3Z3V0SnNWVVhITXR4?= =?utf-8?B?QjhSZWFQQXZxVDY5d0VOZTd5OXZKeDNWbzlPZTUxbFRFbm1FOXZGbnBsSmp4?= =?utf-8?B?OUhweGZqeENmY0JGVUtFamZ2U3I0emd6UitCZTFaRlRvTzREMDRLZjVpV24x?= =?utf-8?B?SFduL0NxZ1RPODVlUkxtbTdDMmxmTFFJRzlIZnFscGdIdjROQUlDdloxeEZq?= =?utf-8?B?bENnYit6eGVCMDF5SUwrSCtMdjh1WXBYYUYwbFBMYkcveUx5OWxLcVJVU2h4?= =?utf-8?B?cVZGc0VPb01lbkI2a3B5MHkxSW5LUm50dmFqRnY2WjNUSms5UUpGaitxY0tO?= =?utf-8?B?M0xWVUUwSjN1bkZzdVJtRVk5RzM4TDlkS3RWQ2ZNRlNXVXJUWGRoVVNJa3Vn?= =?utf-8?B?U2lxV3ZLZjgvcGhrVzZMY0oxOW45N1FnbW95MmZVU2wrS1lncWVOdm9jcHBH?= =?utf-8?B?a2V6eGpNcENCZXc4dDRFSkJ5SVNjTXhPMnZBMzhmKzdHUWxtUDZxTUU5QXdC?= =?utf-8?B?VTlKM0N5K0Q4cWFpMWU2dWovekV2RFJJOThUZ05qYVoxeEZsdnhyMURiVkdr?= =?utf-8?B?Q0NDdWgzNTFsa080KzhYa0RsK0d5d1I3ajE2SEl3TWsxM05TV1NnMDlBTHhT?= =?utf-8?B?YVJadUtnTFVzVjlRalVqTi9TSzZkbHlvSnBwVVlZcFNiU0pUd1ZtV0RnNDFL?= =?utf-8?B?ZThwY0hjb0hBVklINzY2U1IwNjNaSGNrbXJkejJoOE1xTUtDTnNiM0VKYXA4?= =?utf-8?B?V3hEdkhLSERiaityclVOUWxNN2h4dThOSVBNU012RkkzTjFIOXBSRWZlMHIz?= =?utf-8?B?ekZ5dlBTSTFVSkRkenN4RWovQTQyTnBlQmsxV3JYejRodkVvOElEbDUvTzda?= =?utf-8?B?MTlHaFBxWXYxMDdGUFFGTGVrZm1yMHFCWWlUTTUxdjFIZENoV25FUHBVZnJn?= =?utf-8?B?MGdNNlErK2NyM3Q3NHlaUHFSSWorcUU0T3Rka1Flb0trT0YzbXFpa1JPUmxy?= =?utf-8?B?QmFYZlNjNGdaY25yaXl0NnNFNGUvb0tEUDRiUGFWWWUrN3ExdUE2TkJYS1hw?= =?utf-8?B?ZnBER0JWS3lSaUdKU2lQSVdmLzEvOCthVi85T2puWm5TMXlWNTJKeHJIS29C?= =?utf-8?B?Q1l4UlBGd0t6WUxoSmVOSFExZTRxZXYwb0xXMWVKUVU4bnA5eHJEblB3OXFJ?= =?utf-8?B?cFE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: a6oQ0M+WvMLO5XysweIg/vPBO8wSbUC7Yx4Wu+Y+rCt/MfA6gLiUjP6klys4eGLlL/SBIjZ2sLLeOQZ6nsncL+o/4xVtmkWb16zF/lVSRjeVCa+gcVhZw3E2dQq92yWGphtxsBdolU6vEd4tXW6eIQ65+NwCWck5VWy/A33Ghcy5xRrufLexfJVkTSz0LZEy6S8D0xkmJPXk0u2DhGujs6yl5vAFB2OQAwfDB74EfLSr6Rf2stIcv1NDGZPLUYV01454HILpY6BoTnN+y9UYJ6sDbGYtUu8KlFvGfizod0E/DbeDEVP3mig+D4e+1MkXebvsfVQs39YcE0os/vtdCCR3kqYnLpjbo6s50Lcdg5xcBYS07RT6YR7633rdSYv6vsRae9ctUikCMGg156tBNWJ592GNVvrGavp2/ZQfd21H8zyD4DsN9gXXwOTSvEQTV5/7n/4SRExnOqYRTADFM0ZExYFnBnCmznU0PxaCt7E2VC/xbUWrBwFErQPwy1qFYV3nMkxqsVUus0Am+3nE2wlFnqylHzhcc30vhM8CztVil3LWHIbc6tuCLNg+ERUY5+fae7VOgbXMpklx3+lsaTos3WwlmdhP8Pc0NmKu7bEFOmtDKouBo5Xg58n5FFH4S1qyBGKwEqoSmGeq/zar5bUlnSqnA9OWJPAzaCfUZmMehg2kL7J0e0Ug6BTPm/3dTZZEUqr1dWFhzsbDtfVZZcAMt8+332H5zoIj4yj2jXp33wMp99g8QwGY291Ms67xmbhasKOzPcHW45h0s66f98TNtNjc5HT+P8S3r2UeHL4HzbVzBopq2AuT0LsDGtcd X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 75da98d0-ff16-4db4-0782-08db4af8e9b2 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 10:35:13.8650 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5r3AQbMO3EihMQsXrzbyGw2uqrlo3N31b/Xg1rB+Mwe7PjlfkBJrDkxcmVtL+L0E84IgxWksSbfo6dVjc+tcewCD6rQtyWA1rdOyWWwD7Kg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5507 On 02/05/2023 11:28 am, Roger Pau Monné wrote: > On Tue, May 02, 2023 at 10:54:55AM +0100, Andrew Cooper wrote: >> On 02/05/2023 10:22 am, Roger Pau Monne wrote: >>> Ensure that the base address is 2M aligned, or else the page table >>> entries created would be corrupt as reserved bits on the PDE end up >>> set. >>> >>> We have found a broken firmware where the loader would end up loading >>> Xen at a non 2M aligned region, and that caused a very difficult to >>> debug triple fault. >> It's probably worth saying that in this case, the OEM has fixed their >> firmware. >> >>> If the alignment is not as required by the page tables print an error >>> message and stop the boot. >>> >>> The check could be performed earlier, but so far the alignment is >>> required by the page tables, and hence feels more natural that the >>> check lives near to the piece of code that requires it. >>> >>> Note that when booted as an EFI application from the PE entry point >>> the alignment check is already performed by >>> efi_arch_load_addr_check(), and hence there's no need to add another >>> check at the point where page tables get built in >>> efi_arch_memory_setup(). >>> >>> Signed-off-by: Roger Pau Monné >>> --- >>> xen/arch/x86/boot/head.S | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S >>> index 0fb7dd3029f2..ff73c1d274c4 100644 >>> --- a/xen/arch/x86/boot/head.S >>> +++ b/xen/arch/x86/boot/head.S >>> @@ -121,6 +121,7 @@ multiboot2_header: >>> .Lbad_ldr_nst: .asciz "ERR: EFI SystemTable is not provided by bootloader!" >>> .Lbad_ldr_nih: .asciz "ERR: EFI ImageHandle is not provided by bootloader!" >>> .Lbad_efi_msg: .asciz "ERR: EFI IA-32 platforms are not supported!" >>> +.Lbag_alg_msg: .asciz "ERR: Xen must be loaded at a 2Mb boundary!" >>> >>> .section .init.data, "aw", @progbits >>> .align 4 >>> @@ -146,6 +147,9 @@ bad_cpu: >>> not_multiboot: >>> add $sym_offs(.Lbad_ldr_msg),%esi # Error message >>> jmp .Lget_vtb >>> +not_aligned: >>> + add $sym_offs(.Lbag_alg_msg),%esi # Error message >>> + jmp .Lget_vtb >>> .Lmb2_no_st: >>> /* >>> * Here we are on EFI platform. vga_text_buffer was zapped earlier >>> @@ -670,6 +674,11 @@ trampoline_setup: >>> cmp %edi, %eax >>> jb 1b >>> >>> + /* Check that the image base is aligned. */ >>> + lea sym_esi(_start), %eax >>> + and $(1 << L2_PAGETABLE_SHIFT) - 1, %eax >>> + jnz not_aligned >> You just want to check the value in %esi, which is the base of the Xen >> image.  Something like: >> >> mov %esi, %eax >> and ... >> jnz >> >> No need to reference the _start label, or use sym_esi(). > The reason for using sym_esi(_start) is because that's exactly the > address used when building the PDE, so it's clearer to keep those in > sync IMO. Hmm yeah, fair point. Reviewed-by: Andrew Cooper , preferably with the extra note in the commit message. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue May 02 10:43:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 10:43:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528477.821674 (Exim 4.92) (envelope-from ) id 1ptnU0-0003ai-Fm; Tue, 02 May 2023 10:43:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528477.821674; Tue, 02 May 2023 10:43:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptnU0-0003ab-Cc; Tue, 02 May 2023 10:43:44 +0000 Received: by outflank-mailman (input) for mailman id 528477; Tue, 02 May 2023 10:43:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptnTz-0003aV-5U for xen-devel@lists.xenproject.org; Tue, 02 May 2023 10:43:43 +0000 Received: from sender3-of-o58.zoho.com (sender3-of-o58.zoho.com [136.143.184.58]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 32b7f95e-e8d6-11ed-8611-37d641c3527e; Tue, 02 May 2023 12:43:40 +0200 (CEST) Received: from [10.10.1.128] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1683024216011767.2876740014466; Tue, 2 May 2023 03:43:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 32b7f95e-e8d6-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1683024218; cv=none; d=zohomail.com; s=zohoarc; b=la7k4xNjsSQnpYvPdTmYmMSusIMwiClw5LVgl55eUx8jePMgS0+ImyKRzXcJEfxnp4Qsbtohu8C/eSCAbe3h3CGJVn8JV+33RceH8R6+7v57jg4bCN5Lawl5FH6JHPZQa4ScMKt8Iejj8Dq0zTHdehDCbKk30DiwayZMblZGGhY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1683024218; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=oIghSZgYKIpdj1Zdp8vPzSF0OJ7ZJeiI5lUW7UH9DMc=; b=lEJDv+8p7ANbe+jHXLr9ek3lJJnbwo7A9KixtdajhGOiHQkG69e6v3ErvFxRJItAVBEoMc2DVsr0BD9DIgF6m8rIVM2Nc8mZjLmtP9WrQa5UXHnyljXbe7o8cImgG882xOBTUVRQ70mD80kLH7XcWzMxpG727SRTbpsaoUTxmn0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1683024218; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=oIghSZgYKIpdj1Zdp8vPzSF0OJ7ZJeiI5lUW7UH9DMc=; b=sL8W/BgI3pojMDg1ZDr5k6uL/FnYNc4fGHjkyiEHFb5b+3TZwsTs7kv8QcJr9DOa +QmvWbcJhZONbEuwD/0/2ASp8rnLB16ebM/an4txTiWkTT6sQySeb1Q6ZgcNR2OMlXe l70VLsNuAMdeC0cDnErkEad3b4LvZPSlvB6TX8R4= Message-ID: <600c8c62-5982-ec7e-7996-5b7fbfb40067@apertussolutions.com> Date: Tue, 2 May 2023 06:43:33 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] sysctl: XSM hook should not cause XEN_SYSCTL_getdomaininfolist to (appear to) fail Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu References: <26064a5a-423d-ded5-745e-61abb0fa601c@suse.com> From: "Daniel P. Smith" In-Reply-To: <26064a5a-423d-ded5-745e-61abb0fa601c@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 5/2/23 03:17, Jan Beulich wrote: > Unlike for XEN_DOMCTL_getdomaininfo, where the XSM check is intended to > cause the operation to fail, in the loop here it ought to merely > determine whether information for the domain at hand may be reported > back. Therefore if on the last iteration the hook results in denial, > this should not affect the sub-op's return value. > > Fixes: d046f361dc93 ("Xen Security Modules: XSM") > Signed-off-by: Jan Beulich > --- > The hook being able to deny access to data for certain domains means > that no caller can assume to have a system-wide picture when holding the > results. > > Wouldn't it make sense to permit the function to merely "count" domains? > While racy in general (including in its present, "normal" mode of > operation), within a tool stack this could be used as long as creation > of new domains is suppressed between obtaining the count and then using > it. > > In XEN_DOMCTL_getpageframeinfo2 said commit had introduced a 2nd such > issue, but luckily that sub-op and xsm_getpageframeinfo() are long gone. > I understand there is a larger issue at play here but neutering the security control/XSM check is not the answer. This literally changes the way a FLASK policy that people currently have would be enforced, as well as contrary to how they understand the access control that it provides. Even though the code path does not fall under XSM maintainer, I would NACK this patch. IMHO, it is better to find a solution that does not abuse, misuse, or invalidate the purpose of the XSM calls. On a side note, I am a little concern that only one person thought to include the XSM maintainer, or any of the XSM reviewers, onto a patch and the discussion around a patch that clearly relates to XSM for us to gauge the consequences of the patch. I am not assuming intentions here, only wanting to raise the concern. So for what it is worth, NACK. V/r, Daniel P. Smith From xen-devel-bounces@lists.xenproject.org Tue May 02 10:52:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 10:52:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528482.821685 (Exim 4.92) (envelope-from ) id 1ptncK-0005Bb-DZ; Tue, 02 May 2023 10:52:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528482.821685; Tue, 02 May 2023 10:52:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptncK-0005BU-AF; Tue, 02 May 2023 10:52:20 +0000 Received: by outflank-mailman (input) for mailman id 528482; Tue, 02 May 2023 10:52:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptncI-0005BO-Jw for xen-devel@lists.xenproject.org; Tue, 02 May 2023 10:52:18 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6668088a-e8d7-11ed-b225-6b7b168915f2; Tue, 02 May 2023 12:52:16 +0200 (CEST) Received: from mail-dm6nam10lp2103.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.103]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2023 06:52:11 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by SJ0PR03MB6676.namprd03.prod.outlook.com (2603:10b6:a03:389::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Tue, 2 May 2023 10:52:05 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec%3]) with mapi id 15.20.6340.031; Tue, 2 May 2023 10:52:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6668088a-e8d7-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683024736; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=4PSVT+SYB3WvHqSTfjEJyPbxogo5VSUdqRfe+uzsLCM=; b=KGEH9hKl9oN2ljeyjPtHDWlJ001/4ZH4Icb1LwddPJUQ76xBDnWZa6H3 7bpSIAWfRsrDBq2XntsWGIXCCdrSUfzcQIXQkjT+6ZbYO6gOVihdpApNS Al3OOggeAyT7O9AjMw5hiaFRSrAqLJ40viuPNXAKLCZ/C//yUdd0PbB8o g=; X-IronPort-RemoteIP: 104.47.58.103 X-IronPort-MID: 106315749 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:+0GAsKJQRSMe+wXlFE+R95QlxSXFcZb7ZxGr2PjKsXjdYENSgmdUx 2cYWW+EOv6LNmWnKopyOt6z808G6MSAm4NmHFdlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPSwP9TlK6q4mhA4wRkPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c4pO2tE0 9ZBIQo3c0+qrcuE5rW5Ss9j05FLwMnDZOvzu1lG5BSAVbMKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dnpTGLl2Sd05C0WDbRUsaNSshP2F6Ru 0rN/njjAwFcP9uaodaA2iv02LSWwHynCer+EpWq3K42klGo21ApViA6DGSDr8KLiEeHDoc3x 0s8v3BGQbIJ3E6hQ8T5Xha4iGWZpRNaUN1Ve8Ul7Cmdx6yS5ByWbkAUQzgEZNE4ucseQT0xy kTPj97vHSZosrCeVTSa7Lj8kN+pES0cLGtHaSpaSwIAuoHnuNtq1kmJSct/GqmoiNGzASv33 z2BsCk5gfMUkNIP0KK4u1vAhlpAu6T0c+L83S2PNkrN0++zTNfNi1CAgbQD0ct9EQ== IronPort-HdrOrdr: A9a23:GHNFDa6fsrOPXBzd/wPXwNvXdLJyesId70hD6qkRc203TiX2ra qTdZgguCMc6wxwZJhDo7690cC7KBu2yXcS2+Us1NyZPTUO1lHGEGmnhrGSpgEJ3EbFh4xg6Z s= X-Talos-CUID: =?us-ascii?q?9a23=3Ac867h2rh5L38Ob1FC6CP8UfmUZ4feHf75i7ZGXW?= =?us-ascii?q?lVk9DYY+zTl2Q3qwxxg=3D=3D?= X-Talos-MUID: 9a23:/g6ytgnkWTDajYaGeabWdnpwHpc08aiVFXw3z6gq4va8OxdCOT6k2WE= X-IronPort-AV: E=Sophos;i="5.99,244,1677560400"; d="scan'208";a="106315749" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mm4isgJGn7SLOuiPepVD+Pu7uF+Tx0/YFG3RJUEOajKfq7zqH1ERJag3JJNNu5X/u6XfR+T90fnm2Vij7r9sc6DdZq8xB89dm4dnATbAnVF7QMymPbE99yPRixV34/jdeK0yj7igy0Rqz/oPylH4TN6v6rpIrMf1Bd6UvPS2T5KlrFj2Oyk4Y28HjE+17QUEu1yBcDA4dBHNh72FMuhPHRcHtr7dRoFM0BRnpnkNraxVU6X0O/c++bV+42k345Gkxst2tu6YyxeQg5HSdt8K3bpShqMaAlawEL/VOxdTmHAGoj4hV7i9mqCvY/tnyMQH4FVCaLmjo4XOeOb3w+UsJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ePrgMFJN8aSP6o4ya3j7L9UOUOtT16JJ5FwlOhlpZ7c=; b=OZzBgj/2IdZ5jMNftSBn896BZPXYYHwnz0GPYv78lPgXaI0MEud+uloeeCZIoAn+HJF/W+Dzkr+lwEk+axtpcHd++KAcyHMbyCw3+LYWeRKrrcPpF1Jnp8ZR51KcoPGFAFpiabwI7lOXpAzC+4IrAXKCbyNr7zvoJcCxU3PzWVcijpjAyToQawfpeKi1RduIyBHTLlfmaiyRGxJr3QiRJ0ts/oFnzCaGaHKiu3429Qumn0X8TGcFLKJyi4fewfzvubPGx1iatJYklo1Kp+moRSkBqbKtd1A4leVN2PPEpW+ONTNvAKoC/0sHjZjx3TA946uuFCn5MZfVLqfZ4xn3MA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ePrgMFJN8aSP6o4ya3j7L9UOUOtT16JJ5FwlOhlpZ7c=; b=XXWKILhA08oEh6kjSOXYm+sH91R8wevzZeCC3FMVcJuL1DUg8VtY2LexRFCR6/sKFC7N5dcgjRhi4U84Z2T4yoybl9GSbg2j0G5PKMq4w2wDzGiQc6LbyxHsFzgPyw2JbHci/9F1+N+JZG/Pn0OVzJ4Xq0w0NxOE5hnOz5oIUU8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 2 May 2023 12:51:59 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH 1/2] x86/head: check base address alignment Message-ID: References: <20230502092224.52265-1-roger.pau@citrix.com> <20230502092224.52265-2-roger.pau@citrix.com> <89389465-f32c-7dfe-f62b-b957e2543cb8@citrix.com> <068ad06b-d766-4fc7-6bbc-289911441ee7@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <068ad06b-d766-4fc7-6bbc-289911441ee7@suse.com> X-ClientProxiedBy: LO4P265CA0157.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c7::14) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|SJ0PR03MB6676:EE_ X-MS-Office365-Filtering-Correlation-Id: bba8bd7b-d584-4003-923b-08db4afb446b X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 13pHst1EH1OjcsZp/+sAEMqmBrJ5pHGX2QnulS+q/3HOQyBdWSJW/etozAXvt7g++Fv6EuuTUMEVCMdKjSN1mAK7kHIFXSg+ngtqEQSWUcDVFqEJKs+AxS8UGMY15q3t9vXP2KY+g2x8KVCjDDfcg8viZJRaSjRAFf7e+88BfBZlYpP5fnJsGoU0Z25Tp8DTBpUlo1eVKn0WyVndzYMn10j6Db9idx6OWa6NM2ab2/IczHtuTLy5RbZwXqkG/JW49hXS/jjwEa36n2JSkYMSKW9K0S8yX3a9f01ZnchSWMegDIGJPynoxFFZkxXfucMjTROhYa2wwb3Z0WLdf8OxBnsG3VAqyqwGmtUHtex+auRxL7TptD5FGpnL6kE1FqnFCMXqy68k/NPTUPybrk6e9aLyZKe2hVW92a8iIktgwB8PC54omjYg7bf2iEZa4rCUswmtml/rPEEmyeH8DRazWJt8AulwAWAW+sbITDq0gaNe3wbmG+LxgY9sWU5W+E+WAmrQCRPo4a9T8idIripgMAM9SZt2HMWRtUI7S3iDuGI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(7916004)(4636009)(396003)(136003)(376002)(366004)(346002)(39860400002)(451199021)(54906003)(966005)(86362001)(82960400001)(6666004)(38100700002)(478600001)(6486002)(83380400001)(5660300002)(2906002)(4326008)(6506007)(66476007)(66946007)(53546011)(6916009)(66556008)(85182001)(8936002)(8676002)(41300700001)(33716001)(26005)(9686003)(6512007)(316002)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWVBYzNoSE1ybzZiNXNjcmc5WitGQ0lEZjBYUFNubUwwMVJoWlduWWVUZW5P?= =?utf-8?B?a0dzMXk2UlV4OEFSakQzQVBCTEJMRGxNN0lZb2hrVUkrMURUZ0ZJSEdCLy9q?= =?utf-8?B?YVJPSFNpdkFsVU85ZXptRjFlOGZMVFpvb2kzbllEclhabTZRK1pnYzl2NlVt?= =?utf-8?B?UzlFZXJWcjdvdm92eXJ3YnhlcGErZk1lQnBYNzJMOUY1Z1VXTzJLaDBtL3cz?= =?utf-8?B?YkhnTTM2NHhpK0pQc1N4Y3pRUUZJWklVUkJYS1REVFBxenR5a1phVC84TnNr?= =?utf-8?B?a3RtT3hYY3VESmhCMG0zWVQ4NXlsQVEwUlU0M3U2MHJ4b0JGOEV4UGdRTlVl?= =?utf-8?B?TzBLQXludHZ3RmRjamQrbi8rYzJrc3NCWjArMTlhRFpuQWNhdHErcTJUMW14?= =?utf-8?B?N0hid2d2M2tlbE55WWloYUtjbnlGQi9OWEpCQ3ZqUXZJdzRkcHZrOE1NK0VD?= =?utf-8?B?bkZhcUhjWXNsUlBCT084VzRMVXFmbmwvVnhjb3JxSmdJYnhqWmJ3eWg2NVlI?= =?utf-8?B?WWJKSkswZXNMUUVGZXhtenFLcG42djZZdVUwaXJBSXNiVzlwWU41VmJpbzJK?= =?utf-8?B?OVdVczZtUDdRYWgwMDJ0TGkrMHN2TW1HVlNmMlc3Z3VkNjkxS056ZnpnRnh4?= =?utf-8?B?Y2tOM0lLaDVQeFNvYWNSRS9CYUIySnVZbUpDenpHbzVNbUZKUVdnMWljVjdy?= =?utf-8?B?aWhQUUE0V2tZT3BMTW5XNzVkRkZMMDRvYStSQ1NCRGhLQWU5aHY1L2FvODRZ?= =?utf-8?B?amxnS1J2UDVOT1lNV3RXZTlEY0xTeC9TZ0JCbVlXVlNUUmxTOVFnUEw4Wmxk?= =?utf-8?B?WU95STAxU0xvTTJnT0dnSnVrdlR3NUlKbjdCNEJNK1V2NVpsYWJzdjNWUW1v?= =?utf-8?B?R2pRNElKSk00L1pJNDlYejY2UzVzeXNBWCswRXBtTk9haDZIWUdJWW1hUHRS?= =?utf-8?B?Rjd3TnFNS3NwcHg5VFRUaWtST1liVWoyZllZanJlZ0wxdmd6WkNzeEJwcWRr?= =?utf-8?B?aUp6VENoRnYrYnJzeEpXUGxlMHBGaUJURUhjTGdjOEp6M1JSUkNSSnlwNHlS?= =?utf-8?B?akVsQnF2Z2hGM0dYMXoranRYOGZpSW85OFE2SEpFNVptSTFxRTlxMG1LclRM?= =?utf-8?B?OU5zYm84TnBPdFlWNFpNK3BZK2thUVRHNGlQaGhUUTN0eG1XQnBKQ090ZVpW?= =?utf-8?B?ZUVuMEd5Zll2cVJnOXIvd1FGaHFtNHlEbjlHdjJHRzhBNzJXZGJmNFZZWnhL?= =?utf-8?B?QkNPRjZqVTFUK1VHMlFJOHo4YTlSS1FDMm05a2xPeUpNRWgwWTAzMzdvYWlW?= =?utf-8?B?azcvc3Z2VUVZd2YrMGlDS1ZXWXgyRzJSeUVqa09ZbzdvVkQwWTFSbGtwRXd2?= =?utf-8?B?ZEZGN3FLVVRGSWQzbkZjTDh6SGdQOVJpYkVKSnhvNTZ0RExLRzNzOGNEVXM3?= =?utf-8?B?dXd4ZjRaMEJHR2tiMG1wU0hVQTdBa3ZsclZ3Z2Jkd21NTFI5ZjVVdHF2Y1Ey?= =?utf-8?B?YkxWcDcyVDNUci9CSHoyRExMam8rV2d0MWhIbEJaMElMMi9NWFh0Z0ZDeHBh?= =?utf-8?B?SUNnc0FISktZa2JrRkR5c0FSWWFVMFg5MU9VcDRSS0VSSnBPelg2TWVGT1Qx?= =?utf-8?B?d080TkVGWWZTVlpGZzRLQ2MrdjVTWFNiWDhaSDZkTHJRa0ZMcVJGMTBydkVN?= =?utf-8?B?OHNyNlJJUk01UEhvem91K1lsb1pJMTRJWjFEbkZ3TCtvV0d5WmxmcVUzcnRE?= =?utf-8?B?Wmw2cmN3YnBGL1VkWFZoM2ZCVVFHdHdIV1QwZ2RsbjdtT0NESEI5VjRYbHFQ?= =?utf-8?B?elR5bGNwRTF0YUoyZnRiOGRseFg5Z3orYUVXeGh5L204M2k2clFKcUY1TVFC?= =?utf-8?B?MVVYNldpcnBtMjV0VzFvNDhrZUpFQnh2eC85dG5iMFlVYlJ5Qlo5dW11ckNX?= =?utf-8?B?SlRiWFdGamxlNlN2TzA1Y0t5NmpYTFREOWlPMkkzcUhETmp1TTZRVlRqZ0Ry?= =?utf-8?B?TTcrSUg4SWZWcHl2cmsyYitENnZjakdpL3NSMmlSZkx5a050WlZScE9TQ1Vo?= =?utf-8?B?K2pGeXpMbzRjcmM0Mkt2U2ptUnJXUkkzSXYxMmFTMDM4b0V0dDRIRlRiZzha?= =?utf-8?B?VTFIY2NvUmRUb2FtYnhOY0ZNRGl3Nk1TTUNwcTdoa09yUmRicDA1aTBCc0FY?= =?utf-8?B?ZXc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: BPfUGrpojLIkoI3e9kxazPZ8K73zyStr1w+cu1OwUV8MEorrkbRiNME9ONp1wtTK7+lbCaRvvq/0NexneFsr2rWb0SqwZclf6iw8V00RtTGASjoBwklEbMvmfS+szzQPOQCGftzHZ+NxCWB9v4HP1Y+Dehshn9R/u8SQb4bR3Juea1FTLK731K+mRtdteuGQo3JlqlG371COpJ/2vraXAzDRiy5dYrdd5Q4bPMs2XIhCAzordzx9XxQE/iYFa86CmN9ndratvUcChCgvIckiW8VLk742bNF+HdRXvN90PcuDbQh96I4K8ZeAn+B/KTikqesdl69gXdRh6joHIXhG7/XhkEJoLpvUF5ZLv8A2FVx+R8EX2iuIvu8KTak2Zm87NmOMCgAtHxW65q08BmdB9H+9jgN8H3vy2xu+T5bxhj7rS+dEUz+sB0qRkGfQIf3s60e/Yx5jOt54p7E0faOm0WzRXE+y02G2we4UQIIS8sLQAP/pzNcB4lZhqU5HaxPXcyGVpqWYuZbvyyZHRFhM28k8vgflP1Ra+d2XnYUMXdWN+TOMZaAe40ygcjtRCPHMhRaY92ssmKHl6tJbNPUrJh/qOSNBu20S9Kn19htYC285EO52gTr8JBEgr6N3g070Yt15vnHzqTxi2u5MSUeVZxsGYoEPfq8H4aP5cl0Fx+GlACjTd+hGHhw5CjmNOMUMWMPa4fxtcCRn/M0W27jjYI02sPNeApRDwhR5WK3ctt783BMpYvlVWZvBS0ZIB1YBCVaM48klQRUsZPxFsZqDkslIsh/mRqT+LLZ9DFgufqz6B171/436ZLYDuQJD9DiT X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: bba8bd7b-d584-4003-923b-08db4afb446b X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 10:52:05.0835 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: j2NHiZKPlk+/n/q8wHUvjMvW+bOG2V4rt/B8Y+0WtLmYSIghxYlTTbIARXQQYUqIbxAnOFtAN2TC5ZfOjKp3qg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6676 On Tue, May 02, 2023 at 12:28:55PM +0200, Jan Beulich wrote: > On 02.05.2023 11:54, Andrew Cooper wrote: > > On 02/05/2023 10:22 am, Roger Pau Monne wrote: > >> Ensure that the base address is 2M aligned, or else the page table > >> entries created would be corrupt as reserved bits on the PDE end up > >> set. > >> > >> We have found a broken firmware where the loader would end up loading > >> Xen at a non 2M aligned region, and that caused a very difficult to > >> debug triple fault. > > > > It's probably worth saying that in this case, the OEM has fixed their > > firmware. > > I'm curious: What firmware loads Xen directly? I thought there was > always a boot loader involved (except for xen.efi of course). This was a result of a bug in firmware plus a bug in grub, there's also one pending change for grub, see: https://lists.gnu.org/archive/html/grub-devel/2023-04/msg00157.html The firmware would return error for some calls to Boot Services allocate_pages method, and that triggered a bug in grub that resulted in the memory allocated for Xen not being aligned as requested. > I'm further a little puzzled by this talking about alignment and not > xen.efi: xen.gz only specifies alignment for MB2 afaik. For MB1 all > it does specify is the physical address (2Mb) that it wants to be > loaded at. So maybe MB2 wants mentioning here as well, for clarity? "We have found a broken firmware where grub2 would end up loading Xen at a non 2M aligned region when using the multiboot2 protocol, and that caused a very difficult to debug triple fault." Would that be better? > >> @@ -670,6 +674,11 @@ trampoline_setup: > >> cmp %edi, %eax > >> jb 1b > >> > >> + /* Check that the image base is aligned. */ > >> + lea sym_esi(_start), %eax > >> + and $(1 << L2_PAGETABLE_SHIFT) - 1, %eax > >> + jnz not_aligned > > > > You just want to check the value in %esi, which is the base of the Xen > > image.  Something like: > > > > mov %esi, %eax > > and ... > > jnz > > Or yet more simply "test $..., %esi" and then "jnz ..."? As replied to Andrew, I would rather keep this inline with the address used to build the PDE, which is sym_esi(_start). Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 02 10:53:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 10:53:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528486.821695 (Exim 4.92) (envelope-from ) id 1ptndJ-0005iY-Md; Tue, 02 May 2023 10:53:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528486.821695; Tue, 02 May 2023 10:53:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptndJ-0005iR-Jb; Tue, 02 May 2023 10:53:21 +0000 Received: by outflank-mailman (input) for mailman id 528486; Tue, 02 May 2023 10:53:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptndH-0005fU-Mg for xen-devel@lists.xenproject.org; Tue, 02 May 2023 10:53:19 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2062f.outbound.protection.outlook.com [2a01:111:f400:fe16::62f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8b9147d0-e8d7-11ed-8611-37d641c3527e; Tue, 02 May 2023 12:53:18 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by GVXPR04MB10069.eurprd04.prod.outlook.com (2603:10a6:150:121::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 10:53:13 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6340.030; Tue, 2 May 2023 10:53:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b9147d0-e8d7-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z6uT0owrnYItSFu/uyk+jGZ88jOexV6wNpyIKosz5LRvMk3MPjLOZu8hBYufVM1prSBJ4VByLr2kmnoUw5ZP1fhzdZdcHb8E5Yu49/JBi/diEWbJ4bq2WgRkXBYTj/RlnfK9an09nftBjfiI9mwwN+/1OsxOEl649CcGe8ksg16l+CdepOfsES7luJsKb2Pmf1mkYYLxR4jABet6K5MJfaqYMJi7ZoqaLgO4X2CZh92jwyLHuASTPzwvjNma/1BFDN1EtpUmTuZPFS0u8LV5h7s4UhvEiCNOJzNH/n+aN/koyct611mQgtwCvIQClFg3L2IieiUeHERrAwNyml30Og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gXbRNs8L0HqQSzzKkVrPVszxsVNglD88jNZQ98h8eug=; b=dkmdwbyZ4TVCmhA9uFOUKpt2PH+f+y+J6xEcKTpoiRFtHUZkREq22J8X9yGtnYlABFLYpa1nmHEJ/5fwNhKGw8pwGiyZTxj5St5DhcVB+3cYI8BYYcmo1FyyFzcIZOtdp7l5kZb4fw7zqsxJ5me6eV7RqE6r1fhjkdQAK7NlX4D+vkeImZ+f26Y5khxD54KZPTbUByBEM3nMsK08YBK5cXAGWDIYimL+Ah/9Z2+JRgJFGVXC9tLDt3bVrSLMBWDy6OO4a3AbBErSxWgeyMH2bYgaf+lyZpprI/tMMGGpWoWw9P7QCHOVC9Rx71KRELfCRkys7BuiYY9XLH+cfrPx9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gXbRNs8L0HqQSzzKkVrPVszxsVNglD88jNZQ98h8eug=; b=C4sAanMrp7PQxeG+VeWAGxzwCCf5gEnyPtqPBaSy5HxiMQh6obHymTvaZBoyjJcDTMBf9J9BmQ8FmHGxIdtVO9FHoem27g4Q2P4jwNAqdL5j7ZXFVeuJKk9RUdDEvdfd0O0FKknpV5j+025msewB4zQ7Y59g92nc77WdpQW1+kTPrNGhxmWzZ2mPQZCGgkUX/SGCkgmJCmd419b+7IhjgoNJ6jPPuDxhN1gJOe7g/tuL94kxLR0+adq2cwEMYM3NMC8dS8XV8J/2hmwp2RmCrgH/QNzPQCBkkvMoa0oH6gkemgg5TulGRTkDFf4M9rEd1IGvxVkujwF2SD/Mj8Uuog== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 2 May 2023 12:53:15 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v2] ns16550: enable memory decoding on MMIO-based PCI console card Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20230425143902.142571-1-marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <20230425143902.142571-1-marmarek@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0046.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|GVXPR04MB10069:EE_ X-MS-Office365-Filtering-Correlation-Id: 7718c9a2-cf9d-4a4e-d549-08db4afb6d34 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Sm5t77WuXcH8imUj1HImIQ76wX0XxAhjV04HH9kM5pSFY66LhEDMLzNTCuF51olj2kY7dTx43pBcvCqNOM6KoEHWvik8bhYyirF4a+virPWqKe7T8k7PZIgvKgYls2I3+KvZVRXFkIPjZ87dm/TgpWcOyXIV2jHaXEa2Kci9KcvKjsAWCnbLnMR2IWcQV9hX74QzJEawmM7NTOYSgtzNTtBT1wyC9D4Ef8VQBBQl6ydomW6x9XaYRAQRTdbXIyNjVe/5S4Atpa7gsP5yfFDZiT2RwH5VLA9GiJGkVhjdsEm8T4OLWwODZeXlcvrtrAFuMkcc1cvO0XL7CZSzBeRLc+ZurzhhjDQXorHFSh0C/m+3bBQGq11c3vO36PQ792LSaoxFvBQMaaeO5RtQvhNteb45TrC20H0YPLn/cDNFAJdRMyMX3aMyccoq2FEAD/ohHvG2fcqOVGpCK1GxUO5AwcETIxc3Vf3PPHnf/2PoKDyPgxI0U4R0kCxH5Bb9xNkkaInDtGnrK8mirjUh5WE7Gf5rWQFyZ8AxiB0SWDHxi1758a/8QEuSgHxRfjHHO8KkYu06LA11SQVj3ArDKKuV+u6EIRVD837mULrxsivRq6EqBgoHj12MQNI+1m/62Eko4EsO2tWD+2f1B0SoI6URsA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(346002)(39860400002)(376002)(136003)(451199021)(8676002)(8936002)(36756003)(41300700001)(31696002)(316002)(66556008)(66946007)(6916009)(4326008)(66476007)(86362001)(54906003)(478600001)(38100700002)(6486002)(2906002)(2616005)(5660300002)(53546011)(26005)(6512007)(6506007)(31686004)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SkMxZHNwbjVBSXZUa0RzTjZBQzBJbHVYOS9CN3Y4L01Gbkl2a3NOSkphVGhW?= =?utf-8?B?KzdCc01Ud0p0dS9PTGtIZk1sZ2FZdElhcXBBRW5aTmxuemVFc3loWFNBRmkz?= =?utf-8?B?cEIrRTBMY2VtREltSFRQOW1GTmVjckxwZDUrOEN6allGYWFhTXF1ODZvR1Za?= =?utf-8?B?SCtFejZ5cVAxOWswaFNyMzl3WENQOXhBZ1Axemp4TDNadUVMSWUvYXo0YXky?= =?utf-8?B?RGxRSHJOd29veGNRdDJPSHFGdWtDdWVLMTlaZDEvSUZtR29UVTM2emVJUStz?= =?utf-8?B?cXAxSFJVY3FNSStHaGRjMFFBQzNMYnloWlZ3UjN0U0NEZWM5Nm1DM1FQZDFU?= =?utf-8?B?N1RVSGd6SVppaHpsSEZNZ1lFQkp5TUl3bHNvbHFVdWM4eGkwR0l5azR5Z1Iv?= =?utf-8?B?OE83Zk8zcGhoQ3I0bDZIL3lhTTdZOVNPdGt5TE5KR0NydXdxY1Nma3EyYkpS?= =?utf-8?B?SjNKT3hiWDVNRFYyb0t6dTNHWmZ0Zks0RTlPNzJKU3dhbyttckQrY21LWWEy?= =?utf-8?B?S09mQm9iZnJyenhJMTd6ZTNiN3d5MU9JS1V6YjdCNXAzVlFmb2FLTy9mdXZ6?= =?utf-8?B?WDQ2Wi9xWmRzWnlkcEN5SXNjVCtOMmdyUzNxMUxkTDFBdmJpZ3d3bHN6SGln?= =?utf-8?B?NFlvSDVsQ0NiYWdGMjAzV25jam1Ta3ZBU3BpZklNQ0dWUW05RE5XN2w1d28v?= =?utf-8?B?Z0g0cng0dVhkTVYxeWJ1c1hhd1Vqa3UvS3EvcWVqdlhEeHh0dWdqU3R1cVE5?= =?utf-8?B?MnBZalJhNW5yZ0Rka2s4djlvY2JUMS9tSHJTR2F6MloxcEZJRTVLNzF0MnRt?= =?utf-8?B?UlpmazM4SWNyWDJNRGRjMWptR3Q3WHZ4dmJFb1RMOTFaeERUOEU1ckdpaksr?= =?utf-8?B?WmxVYjU2OWQ2UTdkM0pQOTAyRDUvRkZEdDdrdU9haWNTR2RGVzdzWGRRb0xw?= =?utf-8?B?Z1VBZkp0RzVBRllSZWJWQU91RDA4QTJBazVmYUN5T3ZMUGhpTzRPYmlUWGJN?= =?utf-8?B?dnp2MzBBQ0lGTXZwaE91SFp5UVh4dmZnemZQS3RxSTc5cEVFS04yTkErMER1?= =?utf-8?B?WkJrdHczMm51OFNLdGNHU1I4UG5jVVlXSG9sb3NGMU5HN2N1aVMydTQyL0ha?= =?utf-8?B?NGNEbkpBV3ZaL3E0S1FXanczTzFtbFBuVG1uN0dHbFZaVmdrai96YlBneDY4?= =?utf-8?B?a3cvdEFsblZMS2RNUnNvby85OUF4Y2FENVlsU2pyWXF6TUtDM3RVUWRCMWFi?= =?utf-8?B?N1c1d1ZNeDZBdDVFRmdkNFp2M0tpNTVmTGttM3VoMEt5Qm9ROWYvRHJkNGRz?= =?utf-8?B?emppODBqM1JqSjcyTlpSOVBGVzJzaHNPRHdWR1VSWllVSnNmSm1wYUl0WmtL?= =?utf-8?B?bWxiVTBmcGtmUmFuVEZJRXRHdzFMb3YwVW9VVVlRcnl4YzJhVENOcEQ1aWZK?= =?utf-8?B?VVZtR0JoM0cxbGlhQ0ZjQWFESFlWRUlkYXFLVk1zWFhqanpNNnB5YkZ6TmJ4?= =?utf-8?B?RVVXOG5mSmtXZW52R09vcHVnU3ZtYnlyOGNWZS9Ham5rQy9TZFQwbW5POG1P?= =?utf-8?B?L1J0OWZpUWZMalZoR2FGa055dXlua1BZbElNeEk3QjFmb0NWUnZ3c2g1dXNK?= =?utf-8?B?YVFMejZsS0pFRXduSktQMTU4RFVqalRvMjd0bVFjRFBiL0JJc1FRbmVhLzNW?= =?utf-8?B?djJpNGNHekRrT01icUR4Vm9pVlc4c1NlY1BwNDVnQmlwYkJtTFFuK3JBaFR1?= =?utf-8?B?by9IWnNpclkreFZEUGJ1NXRlbVhIbk12WGYzN2dhditVcEh6OW5PaStUVnV1?= =?utf-8?B?Nkg2MVRUQ094dnlhUytFbzF1OGllSU9jRlpET1U5aDYxaXZrWVhwSCtVQjky?= =?utf-8?B?K2NWWlR5UWhNY1FrLy9mdUtsUlI4cU1oWGFYK2lCTlhnbXlOT3JYcWttNDl4?= =?utf-8?B?ZEVvN3JRU2dXc3JNUWxaTytHZFRVQk5RN0ZvSzZ3WnRLVWtFT2dsTFIycHZy?= =?utf-8?B?c3RsZVcycmdxTEhpT2hlTVBkaWxRemROV3M4L0dkTm1XSXlVN2gxdCtOVDNo?= =?utf-8?B?Y2N5bEVEVCt0U1hMYmM1a2o1S0w1ODR1bEw4Zm9jTnFKTk4xNEFjcWp1b2VC?= =?utf-8?Q?igZylEpaZkLYUHU10vGMfUFDI?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7718c9a2-cf9d-4a4e-d549-08db4afb6d34 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 10:53:13.3819 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oKvXqdiy9789UbIXn3pStcbtOdm9qyK2k79rhBsYRKVavs51E0+aQoYzPTDSX7/25N9H/SknqEXW4OYPBYTNTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB10069 On 25.04.2023 16:39, Marek Marczykowski-Górecki wrote: > pci_serial_early_init() enables PCI_COMMAND_IO for IO-based UART > devices, add setting PCI_COMMAND_MEMORY for MMIO-based UART devices too. This sentence is odd, as by its grammar it looks to describe the current situation only. The respective sentence in v1 did not have this issue. > --- a/xen/drivers/char/ns16550.c > +++ b/xen/drivers/char/ns16550.c > @@ -272,7 +272,15 @@ static int cf_check ns16550_getc(struct serial_port *port, char *pc) > static void pci_serial_early_init(struct ns16550 *uart) > { > #ifdef NS16550_PCI > - if ( !uart->ps_bdf_enable || uart->io_base >= 0x10000 ) > + if ( uart->bar ) > + { > + pci_conf_write16(PCI_SBDF(0, uart->ps_bdf[0], uart->ps_bdf[1], > + uart->ps_bdf[2]), > + PCI_COMMAND, PCI_COMMAND_MEMORY); > + return; > + } > + > + if ( !uart->ps_bdf_enable ) > return; > > if ( uart->pb_bdf_enable ) While I did suggest using uart->bar, my implication was that the io_base check would then remain in place. Otherwise, if I'm not mistaken, MMIO- based devices not specified via "com=...,pci" would then wrongly take the I/O port path. Furthermore - you can't use uart->bar alone here, can you? The field is set equally for MMIO and port based cards in pci_uart_config(). Jan From xen-devel-bounces@lists.xenproject.org Tue May 02 10:59:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 10:59:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528489.821706 (Exim 4.92) (envelope-from ) id 1ptnix-0006Qd-87; Tue, 02 May 2023 10:59:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528489.821706; Tue, 02 May 2023 10:59:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptnix-0006QW-38; Tue, 02 May 2023 10:59:11 +0000 Received: by outflank-mailman (input) for mailman id 528489; Tue, 02 May 2023 10:59:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptniw-0006Q7-08 for xen-devel@lists.xenproject.org; Tue, 02 May 2023 10:59:10 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0619.outbound.protection.outlook.com [2a01:111:f400:fe0c::619]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5c08f4e2-e8d8-11ed-8611-37d641c3527e; Tue, 02 May 2023 12:59:07 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8177.eurprd04.prod.outlook.com (2603:10a6:20b:3b7::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 10:59:04 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6340.030; Tue, 2 May 2023 10:59:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5c08f4e2-e8d8-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zx78q1ZzM2xxCujcPgwQ+6ZG6BElMZMDs60MTwfinDgo2+DKHGpljpZyZHGLiKvk86uJVD/XLXLTqDO6F9jBWWyYOILl7E9uXwlTPMW5bEBrwYW0xG/+11SHQNLXEkX/+8LluV/M2q2vRlFJGlak8oOmtm/OP3bBhbG7tDmnoRPvLixGmTHVDb+RvHbVEt3qykscCITNbuLYMgup3y3ZCQ5oRqa7pPSN8O266jZPyvtpqe9wYFRK2k7sQu0w5HA4G7W5o9fCCfgsffd/wMK5CFCVsSvNbZiWySrdwv5eaJ7lEBmjMWkDLL3Q7N6SERauYX9nvuSVM/l6HmilU/iVIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W3fCQlvpDzEPjiM6a2fCovblRteLnyI0+TpO2FGT6zY=; b=Lr09JNO3cDo1JUzF+X3OrIzG1wkHh5cvu6ZjfS5QlDyaXZ9h+D9C8xy7jr6jL+v82c1RSiwYFA1xhZeRdOEz0E49wV8X6wmzNCWKmG31Vi1M7P3z5BKteoaGMOFxNdwTVC0Twcq1J264cG/PX8kg8nlE+xCJIiIuVcYnRaVzNC+VpYlzJRQfMy2+O+dfKvCvTfxAs35OeO8hLMwkAeDzttvjUNS53dkkeHB7q382U2bVIX/cNw5rH+uOJrdrzvPZ/mMBRuqtZvPNiK6/ldaUhOWpxssf7b4/hFLFXdr2CYlPOy1wyPdU56ZadBvtzVHkfZV24uvlYMRHpS8XwOjpow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W3fCQlvpDzEPjiM6a2fCovblRteLnyI0+TpO2FGT6zY=; b=MQN2nyNvqbSvypviWgvIKv28HjuQU2VPz9XUsO7kKp1cdnY2QzYu47H7+4mtN2DdBQqWQUBlkRHIpVS2YNAeAggiedyMQU8lKEuusdPCoB658VtEXxAonFzFAfH0qULea5x8c4wFSi7NHKJP/r6mlzNuHoSfXubbIM5EfO17SsmOup9MnPEvFi4mnzMVzBMxegceTx/iHBgkQrP/Q17pDJ8oHoWY2KeBS4dsZDqRe5GW83crL35Pb+Mg+HTHqY56hhkVWL08iMzZyCW4rzRP/GP0oRVwS9Zz0u3XUrDrhWR7sjfyVgZBLcbV88FcP2DJJdPU8VFpGbhUTOih4TkIzQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <22b2e03c-ac5e-915a-78a2-0a632b09a53a@suse.com> Date: Tue, 2 May 2023 12:59:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH] sysctl: XSM hook should not cause XEN_SYSCTL_getdomaininfolist to (appear to) fail Content-Language: en-US To: "Daniel P. Smith" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <26064a5a-423d-ded5-745e-61abb0fa601c@suse.com> <600c8c62-5982-ec7e-7996-5b7fbfb40067@apertussolutions.com> From: Jan Beulich In-Reply-To: <600c8c62-5982-ec7e-7996-5b7fbfb40067@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0087.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9b::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8177:EE_ X-MS-Office365-Filtering-Correlation-Id: da721443-6b17-41be-f00b-08db4afc3e6e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8YodDVeluo0qVcFLJrtElMsBqieglQfr5MkiCdmfgv/uQNzkb1cM/avK39Olr0MdPE5Osl3Gz86MhpnlTTzPw37i0HDaS8U/YIMATQLbm8WLCn6CC043x8M1CSdQbJBml9K6IlH8AxfML7w6gvIgcL1HUBM7K4Gc+Rpy++wLDkJTJBxrSHVBu5+4Cpscp0YRn4PHtVKZvdyrf//ac0+EQj4ASk0H83ON145y1mLjmeowgzxYTWn5HuQSbDjgyWADICRELIlMrQf+LFqPnWV1Ho48fMmEQ5JNZEpgAiEEi1TGuCupZUqrcn/4FH4RI46dHadOR5W3GYGhcKqnB3ZRvbkoJ2BEWQeVNPWLFiLRM7EJdYbnCSWX25vHuXExB/fGJuI6K1Z8kFnUyT3sgLEo/7Bv0UdlTuuD9mHK7QLwgvjfN3DXjYU3OeGuiq6T1AClMRb0yNv/L9nxEo3WFDwjuK31kduAZ8p9CMxTP0hBDAxr9h+cF7Prrt7o3aa6FZEJf2BD439iHiwmtajz8cP4wcUE3qIHm6aytA4zJnwhmmRPLwFi9+LrnHLcGpW21ueHNZj2mOp53MNI0BEHfBCcXt9cjgg+UDP8aqq49FIAFyJC6cUP+fD/SBoN6MmM0oEM7CMb77NbogYhdCdm/VV+0g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(136003)(39860400002)(396003)(346002)(376002)(451199021)(316002)(6486002)(41300700001)(8936002)(8676002)(478600001)(5660300002)(54906003)(31686004)(6916009)(66946007)(66476007)(66556008)(4326008)(26005)(6512007)(6506007)(2906002)(53546011)(186003)(36756003)(2616005)(83380400001)(38100700002)(66574015)(31696002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dHhHMGxXMEtDKzRrSC8wSjZzcTlRWGNUeVUrcFdacXBrY05MLzBWb3k2Mi9t?= =?utf-8?B?MGtoQ2VvYTFPVWNEM2RxSlh1WXlVcW10RzJQei9uMk1HLzJFV1NSeFY0MmJl?= =?utf-8?B?OVUzTHgvOGE3ekxpY1U4Nk4zeEJsN2ozNVBOWnpvUlZsOTRGOTQyR3RkcWVS?= =?utf-8?B?dTdqejNCVVVLUy9VeHBpb0pLd3I1dHduOXFGZXR4VHRzRFpGVUExbnI4MjNj?= =?utf-8?B?d3ZtWmhMT2NXSEpwYXFsbms5R3BnZWVRUzYwZzJ1bmdtMkNTcVFJam9YL1Ex?= =?utf-8?B?TDk4NzAvcGZNSlBzamdySFNXdm9ULzZMbXE3ZXNzd1EzdjVCQk1UZ0R4RG8z?= =?utf-8?B?MUt6UzIxRlpnMWNCVGNZSWw2cFNERVVzbWtWaHl6b0tVSm5SRVErSWo4dTBI?= =?utf-8?B?NGYzbjFzN2dzOWxZTXgvc1NiVkhSZE91WWJHdkNvS3RjRGdaNXpGamVoU2RI?= =?utf-8?B?TjdxSXZnd0VNdmdwS1VVdzQrcFN0eU0zNjAzWjFBbWFORDlHdUFaM2dIQUNF?= =?utf-8?B?KzgrZCtwMExCTkgwZ1haRWc5SEIyczZ6RDNlR1Frd0J0QWdEbno0SUgzTjVa?= =?utf-8?B?MG93eGtOSzhVZ0N3aEJMUWxPMkVkYWpuVzdPb3J6dE9LQ3VSZklPWllKS3VJ?= =?utf-8?B?Rk5KMVc4VDBXQjZrV3diZUlMS2N0U042SlQzSXM4L3hQR09va1QwVHJsRGVQ?= =?utf-8?B?bDdFM1djT1VuOUt3V3AwTmRMeEV6bENmdE5RK0JCWHA5YVFIWXNNbjcrV04z?= =?utf-8?B?Kytrb29sUFhhcUZ1MDFwM092by9DS0Z3czFUNzdSdXRpUlR3ZERLYVdlYXlt?= =?utf-8?B?VGhvUTFQc2FXcHBBYXlzb25qUDZOa1VOV2lUSGV3T3IvNHY0ZjgxNTVkaWFy?= =?utf-8?B?OTNlY3JTdFBmbDI4eVNNdHNpUU5VTXlQbFJSaXAwc1lKZkt1U0s5V1NVZVBU?= =?utf-8?B?b1laUGt3SG84aXp0emcrTzlGRkhhWWdvd2NHMFl2YjgvdnRFamtBN3RWaEVl?= =?utf-8?B?ZktKU2g0THJESlBnVkdSRjNMelNTc0dSNU4ybWVDTWpBdU14WkRPOEEwUDc2?= =?utf-8?B?L2pMalltMHVJbG44clR3VVFkSDh6SkdudzJIYVlUakIrWUFLcXNZMkJJbmtX?= =?utf-8?B?NzhxdU5ISUE1aXN0bk94MlZmRlZuV1d4ZVk4RzZHcDJWRllyTWc1Qi9QTm0v?= =?utf-8?B?N0lCcVRHUmM0MFBsdDFYb1NVM1ZUK1VFT0N2OS9YU3lTU3RwcW1ZTElxM0g4?= =?utf-8?B?RENQTjJza2ZxcDZNWG05OW9LRDJteEd3OW16eVZPa21Ca3ArZE5oVHd2Wm9D?= =?utf-8?B?clYvSkVGT3BmUE5idEpDcGRzUFROUm5PSFp3ZXU2K0Mvd2NBbmFHbUhWS2hV?= =?utf-8?B?NVI4Tm0ralE1V05yb0FFdXRZTzR1dXRrc3FnbndGWkFOSUFxU0NqSzV2d2JF?= =?utf-8?B?bDhWQk9yQ3ZGdjIzWnR5NSt3bVlCMngrOFVtelNjMWZ2RTFXSnhPSTJwdGdD?= =?utf-8?B?L0RCenF6a1cyY0l4bG00aC80RW14cXpZc2I2RjlXMFN5Ym4wUUFpMHlwdXc0?= =?utf-8?B?WmJtRU92QzlGOTgzK21GbHh6bFJvQmE3M1Q1TSttcTNJd0RrY2YxVlBIVmtF?= =?utf-8?B?bFY1VjVlZCtpZmpBdFpzdlRXMFZvK0VkKzNMaC9ZTWQ3cDhFRzkxWlMwRDZF?= =?utf-8?B?ZFlCOGVBbldLaGFwNVJIbGViT29wdlpNcWpSOVU4bmlNWmNOb3l4bThiTzBK?= =?utf-8?B?WG5iTEJXMGNkbEV4eU9CbTU3aS9ZMnpnLzd3ZHljZ0NPcm5hVlV1WE1uYTBj?= =?utf-8?B?QWd3RElqSXdqVGVuWFFTUFFJS2pCS2Y0aGEvZ0pxbGJPZzZtS1NwTmNoS00w?= =?utf-8?B?Sitkbnh4WmMzSWQyVmdvUTJzd0F2cGNNZ1hsbmwxL2dhNmphM3Q3dXpHRms3?= =?utf-8?B?VHI1QWQwazZNMko3QzRHR2ZqOVJIbmlEUTFBV2xaWTRLSXpVQkZ2RmNsZmVw?= =?utf-8?B?UlR3SlNXV0dWRFkzZGdEb25VQURCSXIzZWtnM3pNOTdrSzRLb0ZTV1p3aTlR?= =?utf-8?B?UDY4Q0V0OUhPZE9rVnEwK0t5UW1tS1Bsc1BndHpjeFlBWDNBUnIvVmNDR2tw?= =?utf-8?Q?8wPfg6iPR/5pOamGykcONx8oE?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: da721443-6b17-41be-f00b-08db4afc3e6e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 10:59:04.4328 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Wa5abGoCzdx6yeb8wywLyDU5C9b2K+nJ2SfZeP0VJ5jR+7KBU928de8HzHutaiPyiPA/tNJYjL+QW9r6yGKg4Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8177 On 02.05.2023 12:43, Daniel P. Smith wrote: > On 5/2/23 03:17, Jan Beulich wrote: >> Unlike for XEN_DOMCTL_getdomaininfo, where the XSM check is intended to >> cause the operation to fail, in the loop here it ought to merely >> determine whether information for the domain at hand may be reported >> back. Therefore if on the last iteration the hook results in denial, >> this should not affect the sub-op's return value. >> >> Fixes: d046f361dc93 ("Xen Security Modules: XSM") >> Signed-off-by: Jan Beulich >> --- >> The hook being able to deny access to data for certain domains means >> that no caller can assume to have a system-wide picture when holding the >> results. >> >> Wouldn't it make sense to permit the function to merely "count" domains? >> While racy in general (including in its present, "normal" mode of >> operation), within a tool stack this could be used as long as creation >> of new domains is suppressed between obtaining the count and then using >> it. >> >> In XEN_DOMCTL_getpageframeinfo2 said commit had introduced a 2nd such >> issue, but luckily that sub-op and xsm_getpageframeinfo() are long gone. >> > > I understand there is a larger issue at play here but neutering the > security control/XSM check is not the answer. This literally changes the > way a FLASK policy that people currently have would be enforced, as well > as contrary to how they understand the access control that it provides. > Even though the code path does not fall under XSM maintainer, I would > NACK this patch. IMHO, it is better to find a solution that does not > abuse, misuse, or invalidate the purpose of the XSM calls. > > On a side note, I am a little concern that only one person thought to > include the XSM maintainer, or any of the XSM reviewers, onto a patch > and the discussion around a patch that clearly relates to XSM for us to > gauge the consequences of the patch. I am not assuming intentions here, > only wanting to raise the concern. Well, yes, for the discussion items I could have remembered to include you. The code change itself, otoh, doesn't require your ack, even if it is the return value of an XSM function which was used wrongly here. > So for what it is worth, NACK. I'm puzzled: I hope you don't mean NACK to the patch (or effectively Jürgen's identical one, which I had noticed only after sending mine). Yet beyond that I don't see anything here which could be NACKed. I've merely raised a couple of points for discussion. Jan From xen-devel-bounces@lists.xenproject.org Tue May 02 10:59:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 10:59:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528490.821715 (Exim 4.92) (envelope-from ) id 1ptnjB-0006lP-Jl; Tue, 02 May 2023 10:59:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528490.821715; Tue, 02 May 2023 10:59:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptnjB-0006lG-GK; Tue, 02 May 2023 10:59:25 +0000 Received: by outflank-mailman (input) for mailman id 528490; Tue, 02 May 2023 10:59:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptnjA-0006kf-Fm for xen-devel@lists.xenproject.org; Tue, 02 May 2023 10:59:24 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on20628.outbound.protection.outlook.com [2a01:111:f400:7e8a::628]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 648248b0-e8d8-11ed-b225-6b7b168915f2; Tue, 02 May 2023 12:59:22 +0200 (CEST) Received: from DM6PR05CA0052.namprd05.prod.outlook.com (2603:10b6:5:335::21) by PH7PR12MB9101.namprd12.prod.outlook.com (2603:10b6:510:2f9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Tue, 2 May 2023 10:59:14 +0000 Received: from DM6NAM11FT031.eop-nam11.prod.protection.outlook.com (2603:10b6:5:335:cafe::17) by DM6PR05CA0052.outlook.office365.com (2603:10b6:5:335::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.20 via Frontend Transport; Tue, 2 May 2023 10:59:14 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT031.mail.protection.outlook.com (10.13.172.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.21 via Frontend Transport; Tue, 2 May 2023 10:59:13 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 2 May 2023 05:59:13 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 2 May 2023 03:59:12 -0700 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 2 May 2023 05:59:11 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 648248b0-e8d8-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WzaL5pvSdR6/FWIl5XJrQcaUB9qFlxhr2tzrHUsg/nQ8B3OETwOrH+Ua1y/AUpABhGJ8nDlNnjiY+TvV7RiWPw5aTl9/6YWtupUcilUIvUMVWemXb/6itFUDHI77Nc5QCTi/yif3Mshe5e+187xkpf8RLXRt9Cui1Z0C/qgpeqiikckh77qxZlCRpjtBh7crLOobsLDjIRj0UMX6v7DfS43FfAJPca8tScG8uXY7fwrfxGKt7VM9FPGGhD5PNk/rbTyOzfeWn0J+EkjLd8BcnsEtQsTl1BEYXKOSQk9Pf8Yl+zlmwvKXrR9W7IYkwa/cKCsNbwMbYXL5Hl8hZpwU6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6PNfiLfJ10whjs+8iQVR/PSPige/chRgA3zDIEpohM0=; b=nBJvrYCkscFgGLIrrQkgi2tqczU2DO5vaWGd3uFUTaQdkJSsgAgb0TB+ajpIqtzX1FOQrCN1Km758PrrF9Xf4/i8Kzpd5cjw38NAhe7aGcaPxuU8TBF3V17687rpFnBrD+1IciJeFr45iP46EiaxrwJq1kH5Gq1H/a/lMFO5dHuaPDaWmquvDTtzXtXYbo7wbOg5CKfr3vafN0ffviEKlkvKbMh6I3268NvKc/SEwQddMuFuZ2TPf/hJJE9ky7XlPdsQPM80M0U+6C+KYQmScUSoZcwUwn6u32owXiKKqJxcur/r0CxgtpcPV6qKVQ1UufE5zKwpvPXSZqm27xeShw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6PNfiLfJ10whjs+8iQVR/PSPige/chRgA3zDIEpohM0=; b=z9mGcYRSjjWrIvhFEG2GoM16AhGE/tK0alCTBGkOOp7ROsVx31t+Ru17frXUwHcUMS3Q9JWKRgUuRIeO34eCHN6lHxoLm2lp0ZwdsXU5W4Xqvvmg0qIe9V3vDxH+GMjn+wDya8XZoaLaSy0U+zJSzSGBRQpqJdC4Nz0RorWLHrI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , Ayan Kumar Halder Subject: [RFC PATCH] xen/arm: arm32: Enable smpboot on Arm32 based systems Date: Tue, 2 May 2023 11:58:49 +0100 Message-ID: <20230502105849.40677-1-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT031:EE_|PH7PR12MB9101:EE_ X-MS-Office365-Filtering-Correlation-Id: c5ed3dd7-90c7-42a8-c0e9-08db4afc4417 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3ktANM2X2wpzfWF7vop5ZDS74ZOsRE8IF8bCVEKyXE0/s+TLLUnKBXSUs2myd2LIpy7N2BcY95ko1FqBRDIUfowqVvKxnvAmJDSYDuZL4SUzvxhDUbJaNQyR+S5AmlMz4O4KSqtmzvGX8Ckw1gE1SCTdBTURnuuDDBv4sFxRI6Z6H8TQe+d/zniawhuqZe5BrqG6ygWi4Sw32mwQ9hu0+58UBwL/hQSgNUWybr8rcNCL9/8os+n2YnyGhTjqibmfOcHm9ab+8MpyQ4mvQp0Kf1pgzpqu1YFckDpF7ZgB90lo7LYFvPfvpCZOPxvChGs2KiyjlWREUriZX/DbhHBVo0ARTos44N0hsc+EGugWjn6gnYjyd2hv1GOkD9w632V5aKr53yDy7MlcccjDqiU6Jj7jgXZyLVv6tG7SuF0I0IXPkKibjJ24X4uMSm9tcHbw9wthwk7H0rYxcAk25CvLzr0vzQpRwaGteOzM0uRyP7cSZd/yToLVBs91JxVTJAz+y0sGb+l/hC/1RxIM3ooiOYw3cxrlyo8DiuTJ2zDX75batf1bFWhAcP/iSxFkP308El3HnSdznD0e09y/T6Gx1yjek160lEbfXdYXIq5ad7GTXu4Ju63JFh1kw6nrlmAtTPmOMnDtneCEjC8pivT7AgdKuTPKNVUOQfocHQZOLZ0yQKgqIjnbqHpkdBOAIUK8VfWBLJmu9WoYq3xXN2cqU/RfjQj4AE6FHJITX+KYF0w= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(376002)(396003)(39860400002)(451199021)(36840700001)(40470700004)(46966006)(26005)(1076003)(478600001)(36860700001)(47076005)(2616005)(426003)(336012)(186003)(83380400001)(86362001)(40460700003)(966005)(6666004)(40480700001)(82310400005)(8936002)(316002)(2906002)(54906003)(70586007)(6916009)(103116003)(8676002)(36756003)(356005)(70206006)(82740400003)(81166007)(41300700001)(5660300002)(4326008)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 10:59:13.6895 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c5ed3dd7-90c7-42a8-c0e9-08db4afc4417 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT031.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB9101 On some of the Arm32 based systems (eg Cortex-R52), smpboot is supported. In these systems PSCI may not always be supported. In case of Cortex-R52, there is no EL3 or secure mode. Thus, PSCI is not supported as it requires EL3. Thus, we use 'spin-table' mechanism to boot the secondary cpus. The primary cpu provides the startup address of the secondary cores. This address is provided using the 'cpu-release-addr' property. To support smpboot, we have copied the code from xen/arch/arm/arm64/smpboot.c with the following changes :- 1. 'enable-method' is an optional property. Refer to the comment in https://www.kernel.org/doc/Documentation/devicetree/bindings/arm/cpus.yaml " # On ARM 32-bit systems this property is optional" 2. psci is not currently supported as a value for 'enable-method'. 3. update_identity_mapping() is not invoked as we are not sure if it is required. Signed-off-by: Ayan Kumar Halder --- The dts snippet with which this has been validated is :- cpus { #address-cells = <0x02>; #size-cells = <0x00>; cpu-map { cluster0 { core0 { thread0 { cpu = <0x02>; }; }; core1 { thread0 { cpu = <0x03>; }; }; }; }; cpu@0 { device_type = "cpu"; compatible = "arm,armv8"; reg = <0x00 0x00>; phandle = <0x02>; }; cpu@1 { device_type = "cpu"; compatible = "arm,armv8"; reg = <0x00 0x01>; enable-method = "spin-table"; cpu-release-addr = <0xEB58C010>; phandle = <0x03>; }; }; Although currently I have tested this on Cortex-R52, I feel this may be helpful to enable smp on other Arm32 based systems as well. Happy to hear opinions. xen/arch/arm/arm32/smpboot.c | 84 ++++++++++++++++++++++++++++++++++-- 1 file changed, 80 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/arm32/smpboot.c b/xen/arch/arm/arm32/smpboot.c index 518e9f9c7e..feb249d3f8 100644 --- a/xen/arch/arm/arm32/smpboot.c +++ b/xen/arch/arm/arm32/smpboot.c @@ -1,24 +1,100 @@ #include #include #include +#include +#include #include +struct smp_enable_ops { + int (*prepare_cpu)(int); +}; + +static uint32_t cpu_release_addr[NR_CPUS]; +static struct smp_enable_ops smp_enable_ops[NR_CPUS]; + int __init arch_smp_init(void) { return platform_smp_init(); } -int __init arch_cpu_init(int cpu, struct dt_device_node *dn) +static int __init smp_spin_table_cpu_up(int cpu) +{ + uint32_t __iomem *release; + + if (!cpu_release_addr[cpu]) + { + printk("CPU%d: No release addr\n", cpu); + return -ENODEV; + } + + release = ioremap_nocache(cpu_release_addr[cpu], 4); + if ( !release ) + { + dprintk(XENLOG_ERR, "CPU%d: Unable to map release address\n", cpu); + return -EFAULT; + } + + writel(__pa(init_secondary), release); + + iounmap(release); + + sev(); + + return 0; +} + +static void __init smp_spin_table_init(int cpu, struct dt_device_node *dn) { - /* Not needed on ARM32, as there is no relevant information in - * the CPU device tree node for ARMv7 CPUs. + if ( !dt_property_read_u32(dn, "cpu-release-addr", &cpu_release_addr[cpu]) ) + { + printk("CPU%d has no cpu-release-addr\n", cpu); + return; + } + + smp_enable_ops[cpu].prepare_cpu = smp_spin_table_cpu_up; +} + +static int __init dt_arch_cpu_init(int cpu, struct dt_device_node *dn) +{ + const char *enable_method; + + /* + * Refer Documentation/devicetree/bindings/arm/cpus.yaml, it says on + * ARM 32-bit systems this property is optional. */ + enable_method = dt_get_property(dn, "enable-method", NULL); + if (!enable_method) + { + return 0; + } + + if ( !strcmp(enable_method, "spin-table") ) + smp_spin_table_init(cpu, dn); + else + { + printk("CPU%d has unknown enable method \"%s\"\n", cpu, enable_method); + return -EINVAL; + } + return 0; } +int __init arch_cpu_init(int cpu, struct dt_device_node *dn) +{ + return dt_arch_cpu_init(cpu, dn); +} + int arch_cpu_up(int cpu) { - return platform_cpu_up(cpu); + int ret = 0; + + if ( smp_enable_ops[cpu].prepare_cpu ) + ret = smp_enable_ops[cpu].prepare_cpu(cpu); + + if ( !ret ) + return platform_cpu_up(cpu); + + return ret; } void arch_cpu_up_finish(void) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue May 02 11:00:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 11:00:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528497.821724 (Exim 4.92) (envelope-from ) id 1ptnk1-0008OV-SY; Tue, 02 May 2023 11:00:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528497.821724; Tue, 02 May 2023 11:00:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptnk1-0008OO-Pk; Tue, 02 May 2023 11:00:17 +0000 Received: by outflank-mailman (input) for mailman id 528497; Tue, 02 May 2023 11:00:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptnk0-0006Q7-LI for xen-devel@lists.xenproject.org; Tue, 02 May 2023 11:00:16 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 81b76432-e8d8-11ed-8611-37d641c3527e; Tue, 02 May 2023 13:00:13 +0200 (CEST) Received: from mail-bn8nam12lp2170.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2023 07:00:09 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by DM4PR03MB6128.namprd03.prod.outlook.com (2603:10b6:5:397::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Tue, 2 May 2023 11:00:06 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec%3]) with mapi id 15.20.6340.031; Tue, 2 May 2023 11:00:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 81b76432-e8d8-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683025213; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=KsLAOn3h7ZIfMVeyWt77Gz0Acm9pzqv/sXsIG3autwY=; b=dnLnP6+uXLzlrwyxSRa1pZnBb16xI/kbhKwLoXpPuCbfqmOG+BoYUWmB u+x8W8Ml1VWvcn1Txx/J4WYGTyh3ZL8U+u5NBaFHufPqo5YzaXWfgG9IE ByYFnua4MigPwgp2J/KrdESJMvsbLgRSDCe/M8pN1fK9w72FobFuOlld4 8=; X-IronPort-RemoteIP: 104.47.55.170 X-IronPort-MID: 106884776 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:7mCyP60ms8IletlK5fbD5T9wkn2cJEfYwER7XKvMYLTBsI5bp2QHy zZLDTjUMq6KNzCmfIx/aoi19hsO75Hcy4c1QQs6pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS+XuDgNyo4GlD5gFmP6gR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfG2FPr 8UEKgI3axmu3bvszK+Hdsl+v5F2RCXrFNt3VnBI6xj8VKxja7aTBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqvi6Kk1QZPLvFabI5fvSQQspYhACAr 3/u9GXlGBAKcteYzFJp91r13rGfzX+kB9x6+LuQy9xhonuh/mgvDyY0UEe8jMCc1EGvYocKQ 6AT0m90xUQoz2SnVsL4XgG4iHecswQARsFLFOkn9ACKzLGS6AGcbkAGRDNcbN0ttOctWCcnk FSOmrvBFTFp9bGYV3+Z3rOVti+pfzgYK3cYYi0JRhdD5MPsyKkxkxbOQ9BLAKOzyNrvFlnY2 CuWpSIzg7ESi88j1Kih+13DxTW2qfDhUQod9gjRGGW/4WtEiJWNYoWp7R3R66ZGJYPAFF2Z5 iFbw46Z8fwECoyLmGqVWuIREbq15vGDdjrBnVpoGJpn/DOok5K+Qb1tDPhFDB8BGq45lfXBO Sc/ZSs5CEdvAUaX IronPort-HdrOrdr: A9a23:cV404KDrnjN+4c3lHelo55DYdb4zR+YMi2TDt3oddfU1SL38qy nKpp4mPHDP5wr5NEtPpTniAtjjfZq/z/5ICOAqVN/PYOCPggCVxepZnOjfKlPbehEX9oRmpN 1dm6oVMqyMMbCt5/yKnDVRELwbsaa6GLjDv5a785/0JzsaE52J6W1Ce2GmO3wzfiZqL7wjGq GR48JWzgDQAkj+PqyAdx84t/GonayzqK7b X-Talos-CUID: 9a23:h7SKTmM8Qm3O9e5DQilmrncIGPIfd3Twli6KL1KENUZ7cejA X-Talos-MUID: =?us-ascii?q?9a23=3Ay1nRmQ+GXCFCk7Mog2tbaRyQf/pK6IaIOngJrZI?= =?us-ascii?q?9mcyYMgFJHmmSnQ3iFw=3D=3D?= X-IronPort-AV: E=Sophos;i="5.99,244,1677560400"; d="scan'208";a="106884776" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mVUnNBhYuQztLClAKCXvWb0EkZ02/GwYzCpwEzH0pv0jvtve2nFvzqG0jV+3SdW3PCVqPZ4O/LhAbErA/TPpmL3+DyjVKNzNv+idOIEcaSFigg0MiF/GDlFKK1oAc/DoztiLgTxOku4aU65QXeKUPxj36pGor5K1I9P+oYGGmwUaniiJdXfP6jo14cStLIbyXzdcgu9yLax5IUWJ0C3oAm+M/qoduGeESu0QQfCucmJsVbxEyB15ohs6YctuMzxLZqREfm6MceDn6dR1ChuJb11cIhN8dzJYZFb7QxnifmSnHpdzHO48CJHQeRMHy3ZBt/vX9v+mKjI0yZHJbIWOJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=njO6siTvEdw9eAhZlRafJ1EmMyH9PhIGPS5uu3T0qFA=; b=TOjV+M3hwYwdyTS1NeD6RxzMpaPh7J3oiwl95PE/QHF28XUJAFBDclZ0FxnrFgeIHYil2PCQTm586RsUNpfrzy6MG1GRF+pIXWbvpfpv0YSZFdm2XjjZ7wwRaSc2VBM8peUEBMN6epqX9X6ZX9XPgazr1SoZTsuODXowGmqAWPZO9InA24VYWQuKddA9MLKIaGkYTn7ci/Clmxn3PTVuag0RNP7FjEwNheRmRwHYI99zt70ndHnZVM4/dbobv0cUAbeZ+DRyX0yDTn6ktSgBPkGllblf5LzUlAplII+pOmwrMZCBR+0Rfy9UOSGi3Jc49VfWa6zBmA6Rozojmo2Krw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=njO6siTvEdw9eAhZlRafJ1EmMyH9PhIGPS5uu3T0qFA=; b=lq8ZPiqAIprPs94ksrlG+ImM8haJarARWIVGmfAeComHM21kpkdTAfCVjf3lu5qFPjMvRJbSPv3svPGDIQsU5xW4t9K8lGS/j1kbmYu07GGCmlaZw1dDzYJvUTtB7Z+//8oS1TH6JSPRU9zp6u3P883GrKzgkczIBU9dyYwCrJc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 2 May 2023 13:00:00 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: "Daniel P. Smith" Cc: Jan Beulich , "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH] sysctl: XSM hook should not cause XEN_SYSCTL_getdomaininfolist to (appear to) fail Message-ID: References: <26064a5a-423d-ded5-745e-61abb0fa601c@suse.com> <600c8c62-5982-ec7e-7996-5b7fbfb40067@apertussolutions.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <600c8c62-5982-ec7e-7996-5b7fbfb40067@apertussolutions.com> X-ClientProxiedBy: LO4P123CA0087.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:190::20) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|DM4PR03MB6128:EE_ X-MS-Office365-Filtering-Correlation-Id: 674fda44-a22d-47ff-0478-08db4afc6324 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ye/g9z/fhzI9QAKeHyrQUFCabh24zeoq/DgjNuJWI8AsO0Frkn6hSIsMLm57yPaxqUjBGZKK7pcw7pNlSip8cqEXfwdwMhqb4Kd9m5Jl/2l79CtUR6lC//2yoaQRTsHSoNi6pFR/jiMiiEdTC3/aw/eYqxkkGZvEXqk4ukPFpy2fIA2QmAQbH6pk2DQ8xFBHoG+JgR9mzyjtxAcAMq81j+Z+3GN7BkG/cAStazSUKMJtkwB6Nh+BKtELExXfKw6SYXqJBe5z3Xd3G/eseTyV+fN57gb+imqBGM3pypelixr94aTRzGGp3tFtmH7Vx9TTvABHYZTt05R0efL09C2P/RnZ89gWqRTe2RFpVZnXgP3w5t/hT23A+t9mX2WObeQJBY6a14W1Zj8fm2dNGrS6q2G6VFNstif9SJSbHHZZ5IZ2cv+Thx+UfaFtt2ssll3KzeH4Dsm6HnexAFlMtGtU6uQS5bS/qbkFgHI9Ti+JAoN93C1s75JRBGC1PUxW/98l++e5yHmerySBMa5zpikwebRI3khD4kr8uBKtAmFlTU1aVMfYWwy6mrN27aSsPkW+ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(7916004)(346002)(396003)(376002)(136003)(39860400002)(366004)(451199021)(85182001)(6512007)(38100700002)(53546011)(9686003)(6506007)(82960400001)(186003)(26005)(86362001)(6486002)(6666004)(83380400001)(41300700001)(66946007)(66556008)(6916009)(316002)(66476007)(4326008)(5660300002)(2906002)(478600001)(33716001)(8936002)(8676002)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZlJEa0JsbzBDYTR5N2kvNHdVRTU2TG1VY0FJM0t5RDhiTGhXT1gyd0txNXhV?= =?utf-8?B?YUJKQ3Z3OGpRWkh0V2JyQW5NZ2tFdkNEWExMcVY5UTQ4UUpKTUtaOXYxdTBx?= =?utf-8?B?WUl3WHlhNGdtWFRzSUVKSUNaN3hYOHVPR3JmL3lqNW4vdkpCYXVDVHg1WUdS?= =?utf-8?B?eVUxYmJEMDhpeldFVjU1ZlpYT3NmWmFqU3dTNE1SWEdkRkR3eUx3dWYvQ3V3?= =?utf-8?B?bVFhM2tjeGpOTDlUTW93Slk4di9JcEVEaURiS2Y0ZEJkcGx2UW44Z1o4cXFZ?= =?utf-8?B?Y2xkSUVwT3k3eEdoak9PekJmWGRpQldqeUttV1RaL2F4WlpHWExIVTAvNzV0?= =?utf-8?B?Zkhya1NYYlg0ZkJaNXlsQXJ5N0JGTFNrTEt2RVVid1ZpVkRKTzFvMGlQN0NR?= =?utf-8?B?cXZQWXFrWENwdzJrL29Na2pNOXdBczlBREF1UkFEY1Y5dzl2T0Y1b0dhbWpi?= =?utf-8?B?ZWR4RTQ0QWNWSnBkTzN5RXU0b09QWGJpU3FTci95dnBNL1ZZWGEvSVExMDVp?= =?utf-8?B?eGtialJFazYvWVBZeVRrYlA3aVNVbkFXTUpwUXJBTGNFcWVlSE0zSFdJMjVs?= =?utf-8?B?QlhDSy93M1dPb0lpTE9hRlNqSnU0SDdqZnh6LzhMODdraDhjbGt6M1c1K0FN?= =?utf-8?B?WC93djJabGhMSDJnMC95djZjME5qU2xtQ2tQSDdYc3FHeEd6NERyOHU3bTJF?= =?utf-8?B?NUJTZ2p0bEttVzNveStiZnhzQ0hvWFFrUUZKMkI2QTdrTVVlZE1CVHlRR1U1?= =?utf-8?B?NTJMS1NmSU05dzVXK2JFZ1ZUaksrSXRIUjgxQUlqVVlGTnlLTXc1ZllmaENV?= =?utf-8?B?eEJBTHpTVk04a3NGWmYrVkN5cGt5K25xNy81UW5UNnN2ZU8yeDZoODhacmxJ?= =?utf-8?B?aU5qbFk5RG1Kc1ArbGErQnA4RnVySFJjQWVsQytxYTk0L092Q1AwSlRULzM4?= =?utf-8?B?VTYyMFAvbnkxNE43VURrb2U3MU5oTDZOTWZ6ekVYRFB4bzRoNG1WQXZJSVc4?= =?utf-8?B?Vkt1eU1jUXpDNVRkQVhsWCtrcDB4NHY0SUFKc3RZcGN3SGJYdk1OcVlBdU1z?= =?utf-8?B?Umpjcm9vZFMzcDZERjNaM0JhUGdWN21EMGExR1pwRTBKOWw4VVcrRXplMHdr?= =?utf-8?B?MEVUcTl2VlBDaVBBRkJmbFlTUS9sZ0hOR3J1MVAwb1IvMGM5N3ppQkNSSE9I?= =?utf-8?B?UjdzMDhkeHNGU0tzc2xmd3FXSG9CQ3ZqeWhJQlNWSmtDR1hVVThRVjIrQ1VV?= =?utf-8?B?Yy9tQS9NY3YxdVZDYkREbHErWHRlT3ZuVThRblBJaEk5SW1zVC9EZG1tYTJQ?= =?utf-8?B?OThaRklXQkpvNEUvUE5Jbm1EUWlaZjdqb0JpSzdZQW1TVWI5OXJFOTNib0hk?= =?utf-8?B?aU51TDJQRlZyUVNoUmdVbWdRa3FoMmtZTHZsd0JTMVFLSGlyd2Nub3lVazM5?= =?utf-8?B?dHhNVldSemplem5TTFZHMmRIZjZoY2xWTDZ5Q1lrd0VXTkJBMTBhSWFYNEoz?= =?utf-8?B?cDdDRUVnOWRDUDVYbDF3MEpsVSsxdW1rYlJrN1M1VXdmZXNBMlhmV1FqMVNE?= =?utf-8?B?alYvUE1TeU5yeVI3Mk0wUDhZdjdDc0Z1OHRib2dRQ2RJSGw4TXBXNzc0L0JP?= =?utf-8?B?OU5zTHpoQkl2VUE5STNRTG1RTWNRSGJPWFhZUm1lYm9xaDZ5eGJ6ZlJHZmpB?= =?utf-8?B?anNVQ2IwNEpZaENHT09IN3lkazk4MndBN1RaL0RZUVFEaXJjc1ZHQkF1TGRB?= =?utf-8?B?cTNwdHc2cnZIemZJUGRrRTFMZmRBOE9QdGJQZktYckdESEtQeUN3VFd1amln?= =?utf-8?B?Z0poMzVHNWJ4Wmt2dldib0Y2MkRJM0NIWWZMMW1Gb010MnJCZUFxZVBobjVJ?= =?utf-8?B?MzZqYzRXQ0YrTVp1bWR4ZklXanZZN3JMcW12L29kZFhzanFoYkhxTFVLWGFQ?= =?utf-8?B?RlVUa1JiamtrcEVoR05PZjRTQ2gzSFdDZTNHdXprZ1VBK3g3TXhlZVNseElZ?= =?utf-8?B?Z1Q1M2ZWazI3YjRxTUdTOTNBZjFpN3QrZ3VHQ1BIMjVjaWRER0EyRWRpRG0x?= =?utf-8?B?VzRqM3BwY1ROQlg5ak9sQVJId2JFb21zczZ6MkdQemVrTlluZlpseU1xb1Vi?= =?utf-8?B?UTNkRkFJaGtTcFpnMWhITVJmN0RPZGthQlhmVk5wbkFEN2pKRTZQczdHajZK?= =?utf-8?B?b3c9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: p0W+dYFNiPFQKtUqJnzvYIWjaZ7zENr5dPNQquraobBBIRwLgKVNtQg4sudMy0SHpICyXpkYCxRpsuH8tN2L+8fu5YCg34VS8DKapIr7ZHOJa0ISA39muuSLbq84vnXEnQ3uQYcBmj0DaPsIfUfm1NcJzf6ZND3wAHAtLryIQ8VNHgjaYn0u+7YiEMCPI/xHcF/QwDSuFqxZTKDs48tEALixZ5+qpsFVU8Fw9W97ye53CfkjmqZ5JU39/eKjbML2sEKDEtLFaEE3yr6mIsqkfxfgM2ej8NVE7fj0PL12e7l1XRgRtjHkVsF0Wx+9fJTVTzcQ3LSL6rM2ObfdcEvcLidUlo/tyV4ubF3zHhVu3OuiuXQ6Sq8hShEyv6ZnGwlNuMnBUSlVZLeIev3R7N4LLhXX1m7iVhcayU1/hprZcv/LQu8nKPl8GAI4PLOiCrFPFP6zbqLNUyzgYE4mvKrBcDst2A1uRb586hpqcSb5zsHa6ioJCgOYzZA5h+MB+FQ04Aqs4NwTHL5rcpJBFJf12hnC13zoOn+tvxMqqRby6hyxv6pSpT5S6Ql1GZ5IZLBv/pl1+CIhD/i6W9OFaOKzU7MbMjmRNcfm3Bao3/jqZ0fH63A5iIyFlW3lgnjwPmK4p5lOnQ42U2Ol298ZEcgHRR80ofu1XDIyastYjiRo95CzfMryjsQDgzx9qGN6/Jp6hAWxGsOMxkRuzLQrJweeoCBK7/NjDpkMZLnw93dFZctlyzpZ7CGb8VUPNlV9n91VvTh/diTc5APOOBKFTORt6k4RepPIKH0Bb13lX0qkgalN3/18QZy0geko8qUxKL53/XAGNB4IRe6vqVEg0xp+tQa+vplqzPwmbxbaFbYTGaBlD8B1vBXn+3LYQoxPER451PnS3u5DncA3srLq2TtkyA== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 674fda44-a22d-47ff-0478-08db4afc6324 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 11:00:06.0664 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: i1kUJTobExAt2oY4ggIv4p0P4U1dJGqGWAahyaTPYIiDQwS4uk6nRmA+kiVxYcXXxgDD5M6ox4vlw9jKn1TFMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6128 On Tue, May 02, 2023 at 06:43:33AM -0400, Daniel P. Smith wrote: > > > On 5/2/23 03:17, Jan Beulich wrote: > > Unlike for XEN_DOMCTL_getdomaininfo, where the XSM check is intended to > > cause the operation to fail, in the loop here it ought to merely > > determine whether information for the domain at hand may be reported > > back. Therefore if on the last iteration the hook results in denial, > > this should not affect the sub-op's return value. > > > > Fixes: d046f361dc93 ("Xen Security Modules: XSM") > > Signed-off-by: Jan Beulich > > --- > > The hook being able to deny access to data for certain domains means > > that no caller can assume to have a system-wide picture when holding the > > results. > > > > Wouldn't it make sense to permit the function to merely "count" domains? > > While racy in general (including in its present, "normal" mode of > > operation), within a tool stack this could be used as long as creation > > of new domains is suppressed between obtaining the count and then using > > it. > > > > In XEN_DOMCTL_getpageframeinfo2 said commit had introduced a 2nd such > > issue, but luckily that sub-op and xsm_getpageframeinfo() are long gone. > > > > I understand there is a larger issue at play here but neutering the security > control/XSM check is not the answer. This literally changes the way a FLASK > policy that people currently have would be enforced, as well as contrary to > how they understand the access control that it provides. Even though the > code path does not fall under XSM maintainer, I would NACK this patch. IMHO, > it is better to find a solution that does not abuse, misuse, or invalidate > the purpose of the XSM calls. > > On a side note, I am a little concern that only one person thought to > include the XSM maintainer, or any of the XSM reviewers, onto a patch and > the discussion around a patch that clearly relates to XSM for us to gauge > the consequences of the patch. I am not assuming intentions here, only > wanting to raise the concern. > > So for what it is worth, NACK. I assume the NACK is to the remarks after the '---'? The patch itself doesn't change the enforcement of the XSM checks, just prevents returning an error when the information from the last domain in the loop can not be fetched. Am I missing something? Roger. From xen-devel-bounces@lists.xenproject.org Tue May 02 11:06:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 11:06:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528500.821735 (Exim 4.92) (envelope-from ) id 1ptnpT-0000fH-GP; Tue, 02 May 2023 11:05:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528500.821735; Tue, 02 May 2023 11:05:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptnpT-0000fA-DT; Tue, 02 May 2023 11:05:55 +0000 Received: by outflank-mailman (input) for mailman id 528500; Tue, 02 May 2023 11:05:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptnpR-0000ey-Up for xen-devel@lists.xenproject.org; Tue, 02 May 2023 11:05:53 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20611.outbound.protection.outlook.com [2a01:111:f400:fe1a::611]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4d167fa8-e8d9-11ed-b225-6b7b168915f2; Tue, 02 May 2023 13:05:52 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8367.eurprd04.prod.outlook.com (2603:10a6:102:1c7::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 11:05:50 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6340.030; Tue, 2 May 2023 11:05:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4d167fa8-e8d9-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A4scwBzn9rvRbQBKU72IRVBfAVDq/7RYW9nTKHVoVFVqr2yXEWGCwVkwWj3TuNPR7VBy7RR6JLD3ex7pgO4GZwGbhOYjUvvJxgEaoM2SEj5fwAERzp+PtT1Tm9zjg/1FUNgFyC/mCv6ZGgqy8xpf5RTIEw+UMu7YLnnqw9qVXzmvkPcCNnRIZM/5aS96pUj/t0brqcx7pv7ZyZ3mt8H5Ysbh5uyWD5F1wI6bmGBddbEqMl13vTOz//ILcHU/4rfFCHNdQJSU310LUGklofTAjO0ASUSnx/ugdeHakdBzxc1lt4AoMq89jkUgLVDmLliBAnJrgW9iGf9NrJmHrbiqxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EUcaUhaJh2P17DmQn85ZzGyhh7j+KHpKjFu6faQt5hY=; b=TT0lK35Wvw0j3cliYl5EqY63NUKorlCnHag7Vx3DSMQbToDObzRXslF5wWOeJQ5G+xkt3HRz7fcPgrUCBC/3EP4vpDAOstGhNGHw30sZ7/o2B/MRCrmpZTJQXPAI6JUFABjr5UH5864NewexBR4wIOpJDQThkSXyNfce/seqo13ddmTroU08TWsu9QXaRdQpmhCgKswc067/n/hAtVWcKAQzBd9i5TaHf2sGkpSiHOBEXYmHmjPYR//Dv3RFQxBFlJlhhhx8wU1GNTnLax/3Lpl1U45D+9VN1gg1rQmlNFBayvlx8dHKN/5fxGnm/t3eXWnDApqs+C2bgjdEBFtEgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EUcaUhaJh2P17DmQn85ZzGyhh7j+KHpKjFu6faQt5hY=; b=4+sK2Jlre2Un0r9Er1pGg2KFndtv+8KxMucRDUDDicTB62ouo4PtWDRTRIwToP3Jl4Lf8EvitW/1kX1BJYLsSQLxjdhSdhQeJCUBuRPIawu11Cng3SOHddu5K8cvQm3psaQhillkE0C8P9q7deaTw1BPw9biMnqT9wHAgmhPDQprfa53UjZ/NTkDZCR85oLIR8JnQPGqHjHdwLPBvQsiYlkYVPztBUZ9RxQVpIGk7vLhJDzROYgYZqLKr9WNJBQxfyfxts3l3vvW3Uh4s7QW7h32wvTf1gR9flSN8aDlKcY63PhCPuknQJQZLxkdkIHMrvNJbFwXTmhT0jEPmh64Mw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6aa9f2a5-bb57-4c56-84b8-5bc63b47cfa4@suse.com> Date: Tue, 2 May 2023 13:05:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 1/2] x86/head: check base address alignment Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20230502092224.52265-1-roger.pau@citrix.com> <20230502092224.52265-2-roger.pau@citrix.com> <89389465-f32c-7dfe-f62b-b957e2543cb8@citrix.com> <068ad06b-d766-4fc7-6bbc-289911441ee7@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0120.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8367:EE_ X-MS-Office365-Filtering-Correlation-Id: 5aba1d6c-8d78-42cf-d8d7-08db4afd3070 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +4UDTG+ub4kz9f1+5b0tNYaQl8pFRqCAIX1qoqorOY1exGs7lrqXGz/6dhh4Y2UCMwBO9lQbpOOEl6lFR3lhjc9Vm5LP4FwL8jsHeA/nb7dRHHCjiVGiXr/YxbGyoCGQy8Bs0WDx3xqL77MeopeXomhr6U4UCbICImtk52uYIOQ6pabchdmZm5DRjafChmQCahVoNmcJPzjTDiOAjtkADz0H/eSYndFfYSGu0ROF7Z0NxTd2kVUxo62mWC2QfHsI4cEmvhTX9/BFihQIJ+ST/aFPuSyEhkXdBtAnlRf3Ze7692yaIWDWa/LlDw9Vg7TxOnXWAOZ4Oc1u0gyrA1GcYZu5ZYWZl2jmjW5D2cwn8F0Kg+wfZ3BF7XAGRqQStPQo6CIkW5vXivCHLvpeJOHDysAY5KgQknMk0g09n5A9Ec9tMnBqLrW5Ep7L0fN1fbjrrQhtNRmch9imKJwzBEMDlLeaUYn9jVvYfPp/kbB2k5PXsUqgouEMI+j0jcu+Gknmo49DoqT7t3FQeqdW+nLLmJtJxAhwQyNeMmxwRObtokYTIZhbKm91G9u8TkPcwxHm9Pe8dguiK+f5cv0JKozUkNrA78CJPVMQbNwJeGijZFhIZWXH7Hk3Xu6dIwhlAQG8LikTezk0ckdyQnPKg0+Z0A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(366004)(346002)(396003)(376002)(39860400002)(451199021)(66476007)(66556008)(4326008)(316002)(6486002)(966005)(38100700002)(6916009)(26005)(186003)(6506007)(6512007)(53546011)(66946007)(478600001)(36756003)(54906003)(31696002)(86362001)(5660300002)(83380400001)(41300700001)(31686004)(8676002)(8936002)(2906002)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ME1nSlY0TytONVdzbCtlZEU1eHE2WEZ4OXI1amlQSCtZQStNYWRFd2k2R211?= =?utf-8?B?YU5KZno5WU95WnFHZmlTcTRaQi9ocE01NTdydDJtZTJoelExK0MxKzE2TGtl?= =?utf-8?B?eUhPWFdMTDRsa3RVYXpndUQxTXRuQi9vM0ZrRVRxK25BTnNXWVdPajNSK3NR?= =?utf-8?B?TzA1Sm1TbTNTQU9HMW9VR0MzWDlpUEwvbllqdGR2dkVJejlCOC9zZis1MnQv?= =?utf-8?B?SnlrcEJxWDV5blZDZDNUUmx0M0hOQUVOL2VRMVZkS1lpMGU5SXNPMWlmVXVj?= =?utf-8?B?dXVRWjdmbkVHbTlUN1VaY0RMd3F2OW9KMkd6UnBoWTFsZy9SSHhCYkxNcStW?= =?utf-8?B?bFo0WUoyYkxPaURzNkZQVTdxYkN3U3ZNMWp4TjA4MEsyQXVPMk11R3poUmFm?= =?utf-8?B?cE5yeEZ6c2NLaFNZV2l0Uzl6T1VGYnlVNVczK0MxQjBUOTVDV1l2eVU2T2dV?= =?utf-8?B?dWkyWm1qRWNTVDRkckdXVWJRUTBpRUl4Y1JNaXZsNWFXd2dDRmpvekNhMlNJ?= =?utf-8?B?TzlVVlhtVElydUgwVnE4UEVRMHYycWMrQktWc3owUzNLVnQ0K0dITlN4aGxr?= =?utf-8?B?NHlvSHlKcU1GS0d4MU5oc3llVGdDeGhlVXF2eUtpSzQzREdXUmZaU3hVN2lW?= =?utf-8?B?Z0F3RFYvYVlyN1dPSGR5WjFIdGVUTnNBNEpvTDh6cGxBTzdXaEFsSXZ4VHBL?= =?utf-8?B?L0tRNCtGZzU3SjZXMXA4YVpGa3dDaUtqNzFuUFpmVjZmZnFhSFNEZDBhdHEy?= =?utf-8?B?Mk5CREQwRzgzeFdGenRIVC9FTE13ZlpMeHhueTkrMjBjZEpFZUZlQmcrbnhX?= =?utf-8?B?SlYxbjd4ZGxmaHVZbHZadzVYRDRNcDF1Y2J5LzFBZXE2Sm5rMHhBa1ZMTDRj?= =?utf-8?B?dUJ4c0NtVWdYalFqRjdyYlFPMmlJOGtMUUt3ZWVJSFBkRU5MODcwVFZmZjFr?= =?utf-8?B?TjVXNFlyc1lKOGg2SVp4Sis2Rnl3ZnREdlo2NC94bE5LYTErWkNDcXo2RXpY?= =?utf-8?B?dklENnpsMkt0Umoyako5aCtsc0lzekFpaFdRUFJsWldaKzFUR1BKZUwvYzBl?= =?utf-8?B?R1RIdUhUVDZyTy9XNkJ6VUtLT0xSV04zeG9Xald1K0ZXdEM1SHFNOFcxL0xP?= =?utf-8?B?d29nV0hUalUrWWp5Zm93WnB6WjFqZ3dBd3doRzdtTk1Mb1FMakRsK2tJdEMw?= =?utf-8?B?S0VzanZqdW1XWE04a24wVE5BM3RHNEdvS25UNEQ3NHFWUHZEdGpyYmQ5aU1G?= =?utf-8?B?WkszT3BQK2JaMGErUks1WUhJaEQrSTN1TXZ4ODNkZSs4TnlrNFZVR3NRSHZk?= =?utf-8?B?U05UWXYyZGc3K1h5Unl1V1h5d0JybkRmVWpUQ2llT3dqajNLU3FiU3VQSzFM?= =?utf-8?B?NzJxS3VhcEcrZW91UW9qWXI1R3JCZmFqS1dmOTFTZkpsYjNEMHM5dFJ2d2h4?= =?utf-8?B?TlZ4WFAyNVBCdlF1Q2dwL21OQVJGL2c2R0R3Z1JYVmZVWWlBYkFuZGVVcU1M?= =?utf-8?B?N0pLdmdHK0tSakhJZDdjK1VBYWRvWEJwdHE2SzJXaHVLaEFnZ2FRSmRTWUlI?= =?utf-8?B?R3ZhakJwbVBJUWc1SkJwMVBjY29CTU5HMGxackRqaTQyOGZISU9YUE5yb3dM?= =?utf-8?B?TnJScnE4NWRYRUx3TUxlRDFOWTNGT3RERWlOTmxOTEd6VndndW1McmRpYzNq?= =?utf-8?B?eU8wRWRLZmsxSzRjb3Z1QmhtVnRDbTJXNEJGejFJTHlxWXZ2Vytvck02L0l0?= =?utf-8?B?cjRVS2VmQlg4dUY1Y1U3SisvK2lXbGoxZVFoMkVoM2MwYzlEaTJ5Zmp2N1U2?= =?utf-8?B?ZzZlaWRrZkoxMFlZWm1CVkd2T0FYZld2SmFMa3hEWEJBRXh1OVByUlFFZlZZ?= =?utf-8?B?VjFERXVrVW5QWGxmOUl2SDhyMWtvSkpvZzhNVjNXSlBQcnJLa3VWNDBabDMy?= =?utf-8?B?UDl2c0gydzV1aHIrVHF5VlpieWpudG1wOG9ZdkUyMlNPZVBQVS8zRXNKbUdl?= =?utf-8?B?NXMrYjhhRTYyMFo5REF3U2xJWS9sQVRUQmhSMklNWExvbmhqWllDNklhdVVR?= =?utf-8?B?bHlWZ2ppektYa2IybTRIc3J2bk5YMEttaUZSZExMRWpPVWh5cHFmd0lWMmtm?= =?utf-8?Q?zuzyRlOYjyBVuK6Gh4UL9CmXf?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5aba1d6c-8d78-42cf-d8d7-08db4afd3070 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 11:05:50.4142 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WPa4b8uij6EdTz6x0/X5WM4Z+3XHmY/a9YAp8kgaD5lIjPgyk887zvaWrx9eCSjqSiBe+JEbDibLKN2bXRWnzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8367 On 02.05.2023 12:51, Roger Pau Monné wrote: > On Tue, May 02, 2023 at 12:28:55PM +0200, Jan Beulich wrote: >> On 02.05.2023 11:54, Andrew Cooper wrote: >>> On 02/05/2023 10:22 am, Roger Pau Monne wrote: >>>> Ensure that the base address is 2M aligned, or else the page table >>>> entries created would be corrupt as reserved bits on the PDE end up >>>> set. >>>> >>>> We have found a broken firmware where the loader would end up loading >>>> Xen at a non 2M aligned region, and that caused a very difficult to >>>> debug triple fault. >>> >>> It's probably worth saying that in this case, the OEM has fixed their >>> firmware. >> >> I'm curious: What firmware loads Xen directly? I thought there was >> always a boot loader involved (except for xen.efi of course). > > This was a result of a bug in firmware plus a bug in grub, there's > also one pending change for grub, see: > > https://lists.gnu.org/archive/html/grub-devel/2023-04/msg00157.html > > The firmware would return error for some calls to Boot Services > allocate_pages method, and that triggered a bug in grub that resulted > in the memory allocated for Xen not being aligned as requested. > >> I'm further a little puzzled by this talking about alignment and not >> xen.efi: xen.gz only specifies alignment for MB2 afaik. For MB1 all >> it does specify is the physical address (2Mb) that it wants to be >> loaded at. So maybe MB2 wants mentioning here as well, for clarity? > > "We have found a broken firmware where grub2 would end up loading Xen > at a non 2M aligned region when using the multiboot2 protocol, and > that caused a very difficult to debug triple fault." > > Would that be better? Yes indeed, thanks. >>>> @@ -670,6 +674,11 @@ trampoline_setup: >>>> cmp %edi, %eax >>>> jb 1b >>>> >>>> + /* Check that the image base is aligned. */ >>>> + lea sym_esi(_start), %eax >>>> + and $(1 << L2_PAGETABLE_SHIFT) - 1, %eax >>>> + jnz not_aligned >>> >>> You just want to check the value in %esi, which is the base of the Xen >>> image.  Something like: >>> >>> mov %esi, %eax >>> and ... >>> jnz >> >> Or yet more simply "test $..., %esi" and then "jnz ..."? > > As replied to Andrew, I would rather keep this inline with the address > used to build the PDE, which is sym_esi(_start). Well, I won't insist, and you've got Andrew's R-b already. (What I would appreciate though as a minimal change is to switch from AND to TEST. We really should avoid using AND or SUB when in fact we only care about the flags output, and hence TEST or CMP can be used. It doesn't matter much on one-time paths like the one here, but each unnecessary use sets a bad precedent.) Jan From xen-devel-bounces@lists.xenproject.org Tue May 02 11:11:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 11:11:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528505.821745 (Exim 4.92) (envelope-from ) id 1ptnuJ-0002E2-5r; Tue, 02 May 2023 11:10:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528505.821745; Tue, 02 May 2023 11:10:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptnuJ-0002Dv-1z; Tue, 02 May 2023 11:10:55 +0000 Received: by outflank-mailman (input) for mailman id 528505; Tue, 02 May 2023 11:10:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptnuH-0002Do-Uj for xen-devel@lists.xenproject.org; Tue, 02 May 2023 11:10:53 +0000 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [2a00:1450:4864:20::32a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 00942132-e8da-11ed-b225-6b7b168915f2; Tue, 02 May 2023 13:10:53 +0200 (CEST) Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-3f1728c2a57so36242665e9.0 for ; Tue, 02 May 2023 04:10:52 -0700 (PDT) Received: from EMEAENGAAD19049. (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id n3-20020a7bcbc3000000b003f175b360e5sm35359896wmi.0.2023.05.02.04.10.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 04:10:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 00942132-e8da-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1683025852; x=1685617852; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=CrppReUeYZVSFZqFBkVwrLemCcLTs/Xn38ozhZ1/RHE=; b=hlQEGzHU0E+m+gi964/ghAazVExWws+a7i0EwYHZdziXCzEpskfCCNuI/N/1IuPO1j u97I3vSvdyb/Gaj7kds9TqayTtzJi8fQmCjvAfauZIkdeUaF+F9tb0h01En3MXONrMHm 9DlOdwkzCYHAM3EuPuTu4LLTbc31hsie/yFh8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683025852; x=1685617852; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CrppReUeYZVSFZqFBkVwrLemCcLTs/Xn38ozhZ1/RHE=; b=PbLcCwWBWKomk+YAqS/uEUrWu4Eemmb5jrAcq3DUDUdIKbRgcGrg0UXwcPSPY1AwU3 9ANoyXkkFc2GRJhaCYsUaG93PTp3BlFySCIkWiL1IioVMCEjpxuUojL5KXq/mmY+3zu4 uabd6/YBDOMEbO1oD0/XukG+/ES5jmKeHjv3Yabk9RI2SdNlU7r8hr1XygladLtyZL7m cJPSYGzfZOi8dwKf4I0Bteub8/9zKeJmdWCUftNNohOfMy1Zx0mjjOw2ld8H3cXT37yY U5KMNxe/gGW6TjhrUyhDVgZnvUsXHJOLhfgSZj+1NXz3v3k+A5V+/S2ixcvyoVZNxnyg BsMA== X-Gm-Message-State: AC+VfDy+cdSsMsFA6o3EpXnW4L2lmrLA8rH9KW2wT4pvwvJKGQ567rvC 5jIqxHgXmSLBjhMdpMZgIw3iNw== X-Google-Smtp-Source: ACHHUZ7QZc1lIYE4w1r1TuXOZ+DRhv8aFFUNbVFyuIq+VlrY8aE+/DIk30O6TZ/kvStW10oG7gHqIw== X-Received: by 2002:a1c:f019:0:b0:3f0:49b5:f0ce with SMTP id a25-20020a1cf019000000b003f049b5f0cemr11324696wmb.12.1683025852268; Tue, 02 May 2023 04:10:52 -0700 (PDT) Message-ID: <6450efbb.7b0a0220.9c334.a329@mx.google.com> X-Google-Original-Message-ID: Date: Tue, 2 May 2023 12:10:48 +0100 From: Alejandro Vallejo To: Jan Beulich Cc: Stefano Stabellini , andrew.cooper3@citrix.com, committers@xenproject.org, michal.orzel@amd.com, xen-devel@lists.xenproject.org Subject: Re: xen | Failed pipeline for staging | 6a47ba2f References: <644bfbc6939d8_2a49bbb403253f4@gitlab-sidekiq-catchall-v2-78885c497-qxnp2.mail> <333df991-58a8-f4e0-b46c-9f480cd34213@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <333df991-58a8-f4e0-b46c-9f480cd34213@suse.com> On Tue, May 02, 2023 at 08:53:31AM +0200, Jan Beulich wrote: > I'm also having a hard time seeing what failure case the test ended > up encountering: There are only two errors which can occur - one > from the XSM hook (which is mishandled, and I'll make a separate > patch for that) and the other from failing to copy back the info for > the domain being looked at. I hope we can exclude the former, so are > you suggesting the info struct copy-back is failing in your case? Something's off somewhere, that's for sure. I'll post the remainder of the series (not all of it made it to staging) so it's not left hanging and start investigating this failure. Cheers, Alejandro From xen-devel-bounces@lists.xenproject.org Tue May 02 11:11:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 11:11:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528507.821755 (Exim 4.92) (envelope-from ) id 1ptnv4-0002jn-Ei; Tue, 02 May 2023 11:11:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528507.821755; Tue, 02 May 2023 11:11:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptnv4-0002jg-AM; Tue, 02 May 2023 11:11:42 +0000 Received: by outflank-mailman (input) for mailman id 528507; Tue, 02 May 2023 11:11:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptnv3-0002jT-5a for xen-devel@lists.xenproject.org; Tue, 02 May 2023 11:11:41 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2081.outbound.protection.outlook.com [40.107.13.81]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1c06659d-e8da-11ed-8611-37d641c3527e; Tue, 02 May 2023 13:11:39 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB8059.eurprd04.prod.outlook.com (2603:10a6:10:1e9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 11:11:10 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6340.030; Tue, 2 May 2023 11:11:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1c06659d-e8da-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lSV+nmqpe7tb4fBc6V/h5l9GR1v4OFNloFdlKtBv+U8wvV2gBUBRcM7ItadxZA7FXhU7zse8/iUP4Z1cRDoELrKZn4Gzg43P2sQCvcFfVH3gGr9EpDfAoHM1j+Q7hIfsn51h4d35A7M1RDuVEK+R6eYQK8wHFZQyh4BZ6lH6kPLSUHIGhKNKpSMLnEaAKC6GFq5C0F1BpzK8FTiK21Beh/CiEd5ESaOYx3NaTc3Ju98Q66ghg3FEjy0QOGrNg9u4ISIwZS9TtWCSc8Sy9AcK2OaNONcc/rD8KPPsmZ45zmdSKLAmftAcd/gbh9Ju78K2PaaXVKW7aj61Rn84uzr0Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n75EAu9Yc8oJm1hbgtfHoz+EO3uNctXze4Zfpbc9TFU=; b=Z4tD5AIZC/Ptji/ehoWxrAyDuS9l3MgsuP9bSm5vBMJf0JMsOTOYVR7GrzEDZsxt/HCXAyJ1jr9BBrLELynrzaqIxS2DDfSxP5Ieigmy67Ddfix26I3fUTpPiMCN56eM6KCfOSPK7JyWRhHkKsqUlBr266v95CY6RvOa8UFACSJqb23SX7dvlcUe6HgYC+Ahh5UHsrZaTfHWry0MPZ9vga9qhG2Fi2g4jkv7ptma14P+P1tVGzCxG6fdMVXZQfWNy4z6xRJ314AXo/1F8Nqop4u8Auu/meUa3zZJ/M5zWodXGJSCUwgZMb0diUUAtUuHP3XY27KP631KKow+2Z55KA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n75EAu9Yc8oJm1hbgtfHoz+EO3uNctXze4Zfpbc9TFU=; b=JyS0R/ccKwJ0+T/gHZsfjY5+yNJ5jH7MfFad3g14POGNWw/F4xQ9W/sd2b3INy08sZ0Hd6qlCoOW7QGiKpqXUfSdIvSOs2buHvOCRzh9CZz5HhTBNyyqiTkQh2tvvxuXrXasORpiG1cJXXDCBrz1NyxpE37LKHmE1HQx1fLs4qOJ0jCqCaN1NMYQ3TNZ1nTFNtbDKR4HUUsVCT6ve/D/Smet2j47an94XW3EDEqkgcLv5es/KiaakTeSQiZxP4p7syvD9hMcc0A8Z5sBXh43VPi/WvJQRNzl6dPlJOmyID9MIeY4rutNrn6+91yM6HwPRZ/aLEAk8IHJiKc7oN5+yA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <269b0894-5fe6-fd71-9f6d-24e3b08973cf@suse.com> Date: Tue, 2 May 2023 13:11:12 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 1/2] x86/head: check base address alignment Content-Language: en-US From: Jan Beulich To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20230502092224.52265-1-roger.pau@citrix.com> <20230502092224.52265-2-roger.pau@citrix.com> <89389465-f32c-7dfe-f62b-b957e2543cb8@citrix.com> <068ad06b-d766-4fc7-6bbc-289911441ee7@suse.com> <6aa9f2a5-bb57-4c56-84b8-5bc63b47cfa4@suse.com> In-Reply-To: <6aa9f2a5-bb57-4c56-84b8-5bc63b47cfa4@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0142.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB8059:EE_ X-MS-Office365-Filtering-Correlation-Id: 11758879-7dbe-400f-510e-08db4afdef20 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8b6wKl/O6oCEDbj1AgNsg6M/paTeHl34rpYBjJgWXpHxsU31mTN1DkfUe7XH8qd7lmIDiBuX+yj8nLr+0XSQ/8uOHPUTh8G9QsNCyzOkHqEp6+Vhk0RExav21fdXtlNmZSnwluvhMN0sKZhOzgI3EyX6sLrZyeYxiKSVncxhMPMN46/0zvEypF2b8nqDMTYlTJwGTVwVGN5ea8SPtvfXkUG35nuRiBdWl5Gl64tlW1Ec4O4pJKhqoCI3XHoyfCfW3zhzqiFWiX2U+i/GeMX2Lrpvt8ZiJGGe70j1wAF4xv+vyj6g3mqrOLgpZ+ByMxOc7bAuvoSasEw8eNcTtFCeksP/p6QolQsnr4/es3cVt+TGA5+N1gCB/rxY0fbFfmfJj0huT7YciXBnPzAW37CDNS27AgKw/pUCOl0m0H3qa7aX9d4en6Adno2LLKf0WvLXFe9F3JB7LY34Bz5H/CsDSyRrOIWVQDVavr+Qcvkbcl6dSGa7/rwrPBcjblSRmPCknwiNt0zhzzGuUshALpqze4ALbK+moMspi/OsU9eVZjodyy78zyb3w+s40HL5EwAuosG4RtBt39gl4i5R+NWJWM/0a7Oz6QTIIwoBBI2ndc3iwwWTXzib94NfW8MSYGPBQqxp8DBaorhKRJQV657Q3A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(366004)(346002)(396003)(376002)(39860400002)(451199021)(478600001)(26005)(6506007)(6512007)(53546011)(86362001)(31696002)(6486002)(83380400001)(54906003)(186003)(2616005)(31686004)(36756003)(66946007)(66556008)(66476007)(2906002)(316002)(6916009)(4326008)(38100700002)(8936002)(8676002)(5660300002)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OWk2QkxsY0N4NmJoUW5sQjZwOUxHV0pxZWJ6WnV6THErZzBUL1lxUWJxNmRI?= =?utf-8?B?V240bWE2bDFHZVMwd1Npc05VZ1VCY3VFTlI5NHFndTE4V1V6cFpMMlBzcklO?= =?utf-8?B?a011cEdDdTdVR25aNDR0N0Q4M2grTjhZUjJDUVQ1UGt5N1g1REFpT1FpdExB?= =?utf-8?B?YjJDVTAxaFFEUlFaU043NjI0blFsbFZqY1NWTG12SllrTFFmM0xhL1BLd1Fl?= =?utf-8?B?Nk9WV0s3aE0zV3h1VExnWkRxNEJyLzl2S00xRS9VRzllSnRWNi9MRGJMdHh4?= =?utf-8?B?MjNaVUdkSC8xMjlNVHNSU0RXVnRXU3l2bTJJWHVobmJnYS9qRDBya3JxWTVC?= =?utf-8?B?cWRFN0xzUU5WMmFCczZTZU52R3VTVEZ6R2hVNGxwWm5TQnRDREdYRGJFWEdX?= =?utf-8?B?QmtZdTBRMTU0VStDc0c3WWNrTC9xd3ZxajhLWnNsbmlmTG1rTk5ycXozTE02?= =?utf-8?B?K05JeDBnb2pwZUVyMjVjUmR2RWFSblkzdi9LbGpnMFNjZnI5UXczS2RyVWhw?= =?utf-8?B?cUV3QVBnVGdYd3ZDQmt3WFVSR2p5eGxjUkVWWmtBMG4xM2pOY1dIWFF0UlFk?= =?utf-8?B?WU5jV09WSFFVUVZ0b2t2aUJ4MWZieHZYL1lmd2dGMTlmZkhPdDZrZGNlVW1Q?= =?utf-8?B?eGZzSnppRjJIUDhkdnVKSkRxZW9sZnRFM29WWDlNdVZQclU1M3RlR3dUUm9h?= =?utf-8?B?MUpRb3RTakJJV0RIVXJLTERwNTRQQ1NEQnpMK3lLRStKRHFXaGVtR1Y5UTlp?= =?utf-8?B?b05uMGdBdE5qY3RFdkVjSmwwVzRvVHViQ0xtcU5aVWYrNHpFdG42dys4UkZp?= =?utf-8?B?MU9UY1RSSC80Z0EvRFVhYllER2JTRnJMcWx0Q3NyT1JNSFBRSm5Yd2NpcWR5?= =?utf-8?B?R2prTGtaN2xHZ2kxcTZ4dU1GNk9WZWQ1SmdlWmtqYU1EaXNpT1FhUDh2enk0?= =?utf-8?B?MzkrdDhyUlpLV281K2YySWJ4Q1VvYVNaYmxTa1dlcnJ0L1hiVXpsT01HQW1B?= =?utf-8?B?RzgyNlRTdS9YUVk1OFZjSlVOQTFXVVFVdll0REtPd09ZaVJSODlsY1Q0NXRa?= =?utf-8?B?QnFFKzlCUWV5TWNpOFJsQU53dVZYcVpwUzlHSENhRHJEb1pXK2hLWlZCYWFB?= =?utf-8?B?WVlubVdNdjB2c3RQdjV0Rm9VK2wzRHVvWGl5aFVBYjBBdkNnVWpzT2tieWhj?= =?utf-8?B?R3pmUjlIODlzcEh5dkQ5QkZ2WCtkcVJNSithYzFWU3AyeTh2ak81bUlXcGhq?= =?utf-8?B?alRta2trTnJOZE1kV0Q5T2hRcnp0UytTZG9ycGlmV3VKcVJXenFLam1hRnFO?= =?utf-8?B?SHcxNmlKNHpidHhQS3p0RTNidHVnajRiVCttYXk4NFAvbUlMeXI1UnJxb0Z0?= =?utf-8?B?bWZkK0k5LzRrcjU1OE1FL29ycWY3aXlaN2swREhUYmk1TzZOMjZ4eFN3S0lP?= =?utf-8?B?bTBicXRYdEl4R2oyMUlJbnhsd2RVMDJaVWNVUHMwYlYvci9mZlJKUkhqZHdW?= =?utf-8?B?NjBwTzRtc09uUFlMOWNadmxwOUhpWUkxN0Vyb3pZNGhiRzNDS2xLQnRFWlBu?= =?utf-8?B?M1dqQndNbURTUFRET1YzOU1Ic3c0WXNrOGdpWnIydldpdi9ZSGZEdnQ2NS8z?= =?utf-8?B?T09SeEM5SWI0bUcyUm9QMVNFSU1acVlBdWEzZ3c0SnFIbVZqZU82OWg4bW5r?= =?utf-8?B?c0w1RDB0UXQzNkNaN3M1VExRcGRXTlpJOW14RmNMUUJjRTF2L2ZzeHpIQUJy?= =?utf-8?B?bVRiczZrMkIydTF1UXpBbDk2LzFPT1hzS3VCYzBoNDFrQk1kTFVGSUFXQyti?= =?utf-8?B?YWpTRG1VZ24ycThDelZjK2UwR2o2WUl3ODdHL2ZtOXYzTmxzQ1l6ZnR4OW50?= =?utf-8?B?VXFxcVpwVTY2MHRDUUZVQjNWMnhxS0xkWDBiNzkwemhEN090RjhhOEh5eVgx?= =?utf-8?B?cUlEY3RXTU9ScHpGYXdVUlFpd25yOXV4K2lQSnRRWUNMTzZwZW5Ldy9FbDhG?= =?utf-8?B?UlhWM0N5OXNjaFNOK0JFZDNCZXRHRzRwbHNZOC8rSndwU1ZlZWcrb2dCMlNv?= =?utf-8?B?dmdsQTlUWkxza1ZoQmt0ZDZCbFRiMG82QXl3cGpiZitqZG1OK2lQVGN1alVE?= =?utf-8?Q?eVbnmVnQvSvR1N56ZZKp1GrYE?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 11758879-7dbe-400f-510e-08db4afdef20 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 11:11:10.3460 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fB9eJfc1xatQtFuvw/5kBj2QeaOPYuCbX6A2hpP2pISzTdDT6rEvYIR+A3XEwVTcIxBIdN8Ki/Argld6UICJQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB8059 On 02.05.2023 13:05, Jan Beulich wrote: > On 02.05.2023 12:51, Roger Pau Monné wrote: >> On Tue, May 02, 2023 at 12:28:55PM +0200, Jan Beulich wrote: >>> On 02.05.2023 11:54, Andrew Cooper wrote: >>>> On 02/05/2023 10:22 am, Roger Pau Monne wrote: >>>>> @@ -670,6 +674,11 @@ trampoline_setup: >>>>> cmp %edi, %eax >>>>> jb 1b >>>>> >>>>> + /* Check that the image base is aligned. */ >>>>> + lea sym_esi(_start), %eax >>>>> + and $(1 << L2_PAGETABLE_SHIFT) - 1, %eax >>>>> + jnz not_aligned >>>> >>>> You just want to check the value in %esi, which is the base of the Xen >>>> image.  Something like: >>>> >>>> mov %esi, %eax >>>> and ... >>>> jnz >>> >>> Or yet more simply "test $..., %esi" and then "jnz ..."? >> >> As replied to Andrew, I would rather keep this inline with the address >> used to build the PDE, which is sym_esi(_start). > > Well, I won't insist, and you've got Andrew's R-b already. Actually, one more remark here: While using sym_esi() is more in line with the actual consumer of the data, the check triggering because of the transformation yielding a misaligned value (in turn because of a bug elsewhere) would yield a misleading error message: We might well have been loaded at a 2Mb-aligned boundary, and instead its internal logic which would then have been wrong. (I'm sorry, now you'll get to judge whether keeping the check in line with other code or with the diagnostic is going to be better. Or split things into a build-time and a runtime check, as previously suggested.) Jan From xen-devel-bounces@lists.xenproject.org Tue May 02 11:13:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 11:13:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528510.821764 (Exim 4.92) (envelope-from ) id 1ptnx5-0003Li-Qe; Tue, 02 May 2023 11:13:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528510.821764; Tue, 02 May 2023 11:13:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptnx5-0003Lb-No; Tue, 02 May 2023 11:13:47 +0000 Received: by outflank-mailman (input) for mailman id 528510; Tue, 02 May 2023 11:13:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptnx5-0003LR-0N for xen-devel@lists.xenproject.org; Tue, 02 May 2023 11:13:47 +0000 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [2a00:1450:4864:20::336]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 672ba75a-e8da-11ed-8611-37d641c3527e; Tue, 02 May 2023 13:13:45 +0200 (CEST) Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-3f315735514so163681275e9.1 for ; Tue, 02 May 2023 04:13:45 -0700 (PDT) Received: from localhost.localdomain (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id e5-20020a5d5005000000b0030469635629sm25685459wrt.62.2023.05.02.04.13.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 04:13:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 672ba75a-e8da-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1683026024; x=1685618024; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=RsC+epa7CsvsdYdUD2vHUSqP2BJfk8zEfXqKTWfPouw=; b=WkEwIoz90+GkvJBvSoZcRgsY7VdSW391O/IsBn9N2/D1hnSOavHBtc7clB+iRlJWj7 fsNjk+Ro+j4lfpQ/3rcdJFrMZ+y20hmsdLDLAPJ9IDi16CrdjtSen4Ewd2qd17fPqum5 0MCySztnmMDYlfCTAnnB33LrmhEqVRUaSLouI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683026024; x=1685618024; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RsC+epa7CsvsdYdUD2vHUSqP2BJfk8zEfXqKTWfPouw=; b=KEd9GDLGqcz42Z3gqCcDG/Rq6BF5gcFhFpdIU2cP4Q24yIs/OG470cK3y9URaMVmFg XBN7hvr2OVBFfRWIKXmhwK8/aLRO79+Wp6bmPm8I6UF05VO31Hqv7BqQOeQmppaDh0D+ SS8J2ziKpmh+nUz/eYd3vCOW68iO1KwWYvfccTy6UPN4ZD9E68B1aiRQ+JSM9qBV1ZD7 aO8HYpDlbOAex9N+nOW4CZq4r2LOeOR3+WUy1wqyFqPE8zf1vbr4bQ+6YTSCVYLyc8cv 8pSyYc+dgW9LiM0MDnm6p52D1ntFImoMWu749EDLtx/MhFurkoKOVHVA0CvKTMw5IzRE 7SfQ== X-Gm-Message-State: AC+VfDy4fnoDWXJA3zfmpkdDc49jziZS2BV+/cttD8TDQoJToQ37rViH AUpeGm3UCtBIN7UkXn+h1PygvkgF/ATsf/y8dGI= X-Google-Smtp-Source: ACHHUZ46cHk7Or+b/FgUpaGyCoWKuBRHuMEFrC/bLfmR4PqOpsLEBPTOvww+VO4iHL4HAokusHbg6A== X-Received: by 2002:a5d:6b01:0:b0:2fa:abcd:59a2 with SMTP id v1-20020a5d6b01000000b002faabcd59a2mr10558235wrw.30.1683026023975; Tue, 02 May 2023 04:13:43 -0700 (PDT) From: Alejandro Vallejo To: Xen-devel Cc: Alejandro Vallejo , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Anthony PERARD , Juergen Gross , Tim Deegan , Christian Lindig Subject: [PATCH v3 0/3] Rationalize usage of xc_domain_getinfo{,list}() Date: Tue, 2 May 2023 12:13:35 +0100 Message-Id: <20230502111338.16757-1-alejandro.vallejo@cloud.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The first 4 patches of v2 already made it to staging. This is a corrected repost of the 3 remaining ones. Original cover letter: xc_domain_getinfo() returns the list of domains with domid >= first_domid. It does so by repeatedly invoking XEN_DOMCTL_getdomaininfo, which leads to unintuitive behaviour (asking for domid=1 might succeed returning domid=2). Furthermore, N hypercalls are required whereas the equivalent functionality can be achieved using with XEN_SYSCTL_getdomaininfo. Ideally, we want a DOMCTL interface that operates over a single precisely specified domain and a SYSCTL interface that can be used for bulk queries. All callers of xc_domain_getinfo() that are better off using SYSCTL are migrated to use that instead. That includes callers performing domain discovery and those requesting info for more than 1 domain per hypercall. A new xc_domain_getinfo_single() is introduced with stricter semantics than xc_domain_getinfo() (failing if domid isn't found) to migrate the rest to. With no callers left the xc_dominfo_t structure and the xc_domain_getinfo() call itself can be cleanly removed, and the DOMCTL interface simplified to only use its fastpath. With the DOMCTL ammended, the new xc_domain_getinfo_single() drops its stricter check, becoming a simple wrapper to invoke the hypercall itself. Alejandro Vallejo (3): tools: Modify single-domid callers of xc_domain_getinfolist() tools: Use new xc function for some xc_domain_getinfo() calls domctl: Modify XEN_DOMCTL_getdomaininfo to fail if domid is not found tools/console/client/main.c | 7 +-- tools/debugger/kdd/kdd-xen.c | 5 +- tools/include/xenctrl.h | 43 ------------- tools/libs/ctrl/xc_domain.c | 82 ++----------------------- tools/libs/ctrl/xc_pagetab.c | 7 +-- tools/libs/ctrl/xc_private.c | 9 +-- tools/libs/ctrl/xc_private.h | 7 ++- tools/libs/guest/xg_core.c | 23 +++---- tools/libs/guest/xg_core.h | 6 +- tools/libs/guest/xg_core_arm.c | 10 +-- tools/libs/guest/xg_core_x86.c | 18 +++--- tools/libs/guest/xg_cpuid_x86.c | 40 ++++++------ tools/libs/guest/xg_dom_boot.c | 16 ++--- tools/libs/guest/xg_domain.c | 8 +-- tools/libs/guest/xg_offline_page.c | 12 ++-- tools/libs/guest/xg_private.h | 1 + tools/libs/guest/xg_resume.c | 20 +++--- tools/libs/guest/xg_sr_common.h | 2 +- tools/libs/guest/xg_sr_restore.c | 17 ++--- tools/libs/guest/xg_sr_restore_x86_pv.c | 2 +- tools/libs/guest/xg_sr_save.c | 27 ++++---- tools/libs/guest/xg_sr_save_x86_pv.c | 6 +- tools/libs/light/libxl_dom.c | 17 ++--- tools/libs/light/libxl_dom_suspend.c | 7 +-- tools/libs/light/libxl_domain.c | 13 ++-- tools/libs/light/libxl_mem.c | 4 +- tools/libs/light/libxl_sched.c | 26 ++++---- tools/libs/light/libxl_x86_acpi.c | 4 +- tools/misc/xen-hvmcrash.c | 6 +- tools/misc/xen-lowmemd.c | 6 +- tools/misc/xen-mfndump.c | 22 +++---- tools/misc/xen-vmtrace.c | 6 +- tools/ocaml/libs/xc/xenctrl_stubs.c | 6 +- tools/vchan/vchan-socket-proxy.c | 6 +- tools/xenpaging/xenpaging.c | 10 +-- tools/xenstore/xenstored_domain.c | 15 +++-- tools/xentrace/xenctx.c | 8 +-- xen/common/domctl.c | 32 +--------- 38 files changed, 184 insertions(+), 372 deletions(-) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue May 02 11:13:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 11:13:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528512.821785 (Exim 4.92) (envelope-from ) id 1ptnxB-0003tY-CZ; Tue, 02 May 2023 11:13:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528512.821785; Tue, 02 May 2023 11:13:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptnxB-0003tP-9N; Tue, 02 May 2023 11:13:53 +0000 Received: by outflank-mailman (input) for mailman id 528512; Tue, 02 May 2023 11:13:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptnx9-0003LR-RI for xen-devel@lists.xenproject.org; Tue, 02 May 2023 11:13:51 +0000 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [2a00:1450:4864:20::42e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6a25db82-e8da-11ed-8611-37d641c3527e; Tue, 02 May 2023 13:13:50 +0200 (CEST) Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-2fddb442d47so3377411f8f.2 for ; Tue, 02 May 2023 04:13:50 -0700 (PDT) Received: from localhost.localdomain (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id e5-20020a5d5005000000b0030469635629sm25685459wrt.62.2023.05.02.04.13.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 04:13:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a25db82-e8da-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1683026029; x=1685618029; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6NMka2gY1+NXQR3tdXq6DZrNuT/nqEX+jYw5XJAP3Fg=; b=UAWniR9nix166rgK//vtzWkMtmKcU+ns+MqC/YLYxV7C+hhT/UsSmOeYd+IYGb8Wdv zu5+PaVOaRWQgkZ+4SYMZjrQ8Ee/SxcjeiobayebmSf/+pedDY0ufpLgzjmb3oB5W76m 8bVmYn4XnE8wKS61Eh0/2zP58gG7qq550R2no= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683026029; x=1685618029; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6NMka2gY1+NXQR3tdXq6DZrNuT/nqEX+jYw5XJAP3Fg=; b=kNm4l48e/1KAoOfiBA1ggsX18HMg0AXn0qAwF68IE+jcTvJd8pfxiH8M48VS/yq7rf 2wo/YZihFwM6fkmzh4br7d2gVT4mT4/KOCxUtWkCPLQ+sUk6fjaznDoa1FzyrMMPoHVr 61LsHV+gg1yxECOQWE36h6qQbS4pI/cnUUdYJpfWXc3lUtwoAOBNA+c+9Lymwf6o1Myg VrvlQADz5xNdfaUq+96Afq0KkHa3OutkbImKmQf7EbX+vbwfCO0MttaJCu8veVZC+obC GEcYRJfmj7IM01GpSL/wt/Wci8UhqSjYrJMmj5CGtZaMMlRI+SFisDAHbozbxo3ouPYE V/Mg== X-Gm-Message-State: AC+VfDxLelPZts4isipOoLwcVtmJ0TtGpYXf8gU4ErBiEBQOj19vjI2J 1Jw9KZt/4vzLozgR02ZLHlkMZU3gR8e4SNzpLGI= X-Google-Smtp-Source: ACHHUZ50euzeKBOB3ItpiDW44fY+K/YB3syuNexDFtOiirahG7OAo2y9/V6qt/kl5T86jzDCw1etcQ== X-Received: by 2002:a5d:5410:0:b0:305:fbfb:c7d7 with SMTP id g16-20020a5d5410000000b00305fbfbc7d7mr6787591wrv.44.1683026028927; Tue, 02 May 2023 04:13:48 -0700 (PDT) From: Alejandro Vallejo To: Xen-devel Cc: Alejandro Vallejo , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH v3 3/3] domctl: Modify XEN_DOMCTL_getdomaininfo to fail if domid is not found Date: Tue, 2 May 2023 12:13:38 +0100 Message-Id: <20230502111338.16757-4-alejandro.vallejo@cloud.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230502111338.16757-1-alejandro.vallejo@cloud.com> References: <20230502111338.16757-1-alejandro.vallejo@cloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit It previously mimicked the getdomaininfo sysctl semantics by returning the first domid higher than the requested domid that does exist. This unintuitive behaviour causes quite a few mistakes and makes the call needlessly slow in its error path. This patch removes the fallback search, returning -ESRCH if the requested domain doesn't exist. Domain discovery can still be done through the sysctl interface as that performs a linear search on the list of domains. With this modification the xc_domain_getinfo() function is deprecated and removed to make sure it's not mistakenly used expecting the old behaviour. The new xc wrapper is xc_domain_getinfo_single(). All previous callers of xc_domain_getinfo() have been updated to use xc_domain_getinfo_single() or xc_domain_getinfolist() instead. This also means xc_dominfo_t is no longer used by anything and can be purged. Resolves: xen-project/xen#105 Signed-off-by: Alejandro Vallejo Reviewed-by: Andrew Cooper --- Cc: Andrew Cooper Cc: George Dunlap Cc: Jan Beulich Cc: Julien Grall Cc: Stefano Stabellini Cc: Wei Liu Cc: Anthony PERARD Cc: Juergen Gross v3: * No changes --- tools/include/xenctrl.h | 43 ---------------------- tools/libs/ctrl/xc_domain.c | 73 ------------------------------------- xen/common/domctl.c | 32 +--------------- 3 files changed, 2 insertions(+), 146 deletions(-) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index 752fc87580..08a15c5911 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -444,28 +444,6 @@ typedef struct xc_core_header { * DOMAIN MANAGEMENT FUNCTIONS */ -typedef struct xc_dominfo { - uint32_t domid; - uint32_t ssidref; - unsigned int dying:1, crashed:1, shutdown:1, - paused:1, blocked:1, running:1, - hvm:1, debugged:1, xenstore:1, hap:1; - unsigned int shutdown_reason; /* only meaningful if shutdown==1 */ - unsigned long nr_pages; /* current number, not maximum */ - unsigned long nr_outstanding_pages; - unsigned long nr_shared_pages; - unsigned long nr_paged_pages; - unsigned long shared_info_frame; - uint64_t cpu_time; - unsigned long max_memkb; - unsigned int nr_online_vcpus; - unsigned int max_vcpu_id; - xen_domain_handle_t handle; - unsigned int cpupool; - uint8_t gpaddr_bits; - struct xen_arch_domainconfig arch_config; -} xc_dominfo_t; - typedef xen_domctl_getdomaininfo_t xc_domaininfo_t; static inline unsigned int dominfo_shutdown_reason(const xc_domaininfo_t *info) @@ -721,27 +699,6 @@ int xc_domain_getinfo_single(xc_interface *xch, uint32_t domid, xc_domaininfo_t *info); -/** - * This function will return information about one or more domains. It is - * designed to iterate over the list of domains. If a single domain is - * requested, this function will return the next domain in the list - if - * one exists. It is, therefore, important in this case to make sure the - * domain requested was the one returned. - * - * @parm xch a handle to an open hypervisor interface - * @parm first_domid the first domain to enumerate information from. Domains - * are currently enumerate in order of creation. - * @parm max_doms the number of elements in info - * @parm info an array of max_doms size that will contain the information for - * the enumerated domains. - * @return the number of domains enumerated or -1 on error - */ -int xc_domain_getinfo(xc_interface *xch, - uint32_t first_domid, - unsigned int max_doms, - xc_dominfo_t *info); - - /** * This function will set the execution context for the specified vcpu. * diff --git a/tools/libs/ctrl/xc_domain.c b/tools/libs/ctrl/xc_domain.c index 66179e6f12..724fa6f753 100644 --- a/tools/libs/ctrl/xc_domain.c +++ b/tools/libs/ctrl/xc_domain.c @@ -357,85 +357,12 @@ int xc_domain_getinfo_single(xc_interface *xch, if ( do_domctl(xch, &domctl) < 0 ) return -1; - if ( domctl.u.getdomaininfo.domain != domid ) - { - errno = ESRCH; - return -1; - } - if ( info ) *info = domctl.u.getdomaininfo; return 0; } -int xc_domain_getinfo(xc_interface *xch, - uint32_t first_domid, - unsigned int max_doms, - xc_dominfo_t *info) -{ - unsigned int nr_doms; - uint32_t next_domid = first_domid; - DECLARE_DOMCTL; - int rc = 0; - - memset(info, 0, max_doms*sizeof(xc_dominfo_t)); - - for ( nr_doms = 0; nr_doms < max_doms; nr_doms++ ) - { - domctl.cmd = XEN_DOMCTL_getdomaininfo; - domctl.domain = next_domid; - if ( (rc = do_domctl(xch, &domctl)) < 0 ) - break; - info->domid = domctl.domain; - - info->dying = !!(domctl.u.getdomaininfo.flags&XEN_DOMINF_dying); - info->shutdown = !!(domctl.u.getdomaininfo.flags&XEN_DOMINF_shutdown); - info->paused = !!(domctl.u.getdomaininfo.flags&XEN_DOMINF_paused); - info->blocked = !!(domctl.u.getdomaininfo.flags&XEN_DOMINF_blocked); - info->running = !!(domctl.u.getdomaininfo.flags&XEN_DOMINF_running); - info->hvm = !!(domctl.u.getdomaininfo.flags&XEN_DOMINF_hvm_guest); - info->debugged = !!(domctl.u.getdomaininfo.flags&XEN_DOMINF_debugged); - info->xenstore = !!(domctl.u.getdomaininfo.flags&XEN_DOMINF_xs_domain); - info->hap = !!(domctl.u.getdomaininfo.flags&XEN_DOMINF_hap); - - info->shutdown_reason = - (domctl.u.getdomaininfo.flags>>XEN_DOMINF_shutdownshift) & - XEN_DOMINF_shutdownmask; - - if ( info->shutdown && (info->shutdown_reason == SHUTDOWN_crash) ) - { - info->shutdown = 0; - info->crashed = 1; - } - - info->ssidref = domctl.u.getdomaininfo.ssidref; - info->nr_pages = domctl.u.getdomaininfo.tot_pages; - info->nr_outstanding_pages = domctl.u.getdomaininfo.outstanding_pages; - info->nr_shared_pages = domctl.u.getdomaininfo.shr_pages; - info->nr_paged_pages = domctl.u.getdomaininfo.paged_pages; - info->max_memkb = domctl.u.getdomaininfo.max_pages << (PAGE_SHIFT-10); - info->shared_info_frame = domctl.u.getdomaininfo.shared_info_frame; - info->cpu_time = domctl.u.getdomaininfo.cpu_time; - info->nr_online_vcpus = domctl.u.getdomaininfo.nr_online_vcpus; - info->max_vcpu_id = domctl.u.getdomaininfo.max_vcpu_id; - info->cpupool = domctl.u.getdomaininfo.cpupool; - info->gpaddr_bits = domctl.u.getdomaininfo.gpaddr_bits; - info->arch_config = domctl.u.getdomaininfo.arch_config; - - memcpy(info->handle, domctl.u.getdomaininfo.handle, - sizeof(xen_domain_handle_t)); - - next_domid = (uint16_t)domctl.domain + 1; - info++; - } - - if ( nr_doms == 0 ) - return rc; - - return nr_doms; -} - int xc_domain_getinfolist(xc_interface *xch, uint32_t first_domain, unsigned int max_domains, diff --git a/xen/common/domctl.c b/xen/common/domctl.c index ad71ad8a4c..24a14996e6 100644 --- a/xen/common/domctl.c +++ b/xen/common/domctl.c @@ -314,7 +314,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) /* fall through */ default: d = rcu_lock_domain_by_id(op->domain); - if ( !d && op->cmd != XEN_DOMCTL_getdomaininfo ) + if ( !d ) return -ESRCH; } @@ -534,42 +534,14 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) case XEN_DOMCTL_getdomaininfo: { - domid_t dom = DOMID_INVALID; - - if ( !d ) - { - ret = -EINVAL; - if ( op->domain >= DOMID_FIRST_RESERVED ) - break; - - rcu_read_lock(&domlist_read_lock); - - dom = op->domain; - for_each_domain ( d ) - if ( d->domain_id >= dom ) - break; - } - - ret = -ESRCH; - if ( d == NULL ) - goto getdomaininfo_out; - ret = xsm_getdomaininfo(XSM_HOOK, d); if ( ret ) - goto getdomaininfo_out; + break; getdomaininfo(d, &op->u.getdomaininfo); op->domain = op->u.getdomaininfo.domain; copyback = 1; - - getdomaininfo_out: - /* When d was non-NULL upon entry, no cleanup is needed. */ - if ( dom == DOMID_INVALID ) - break; - - rcu_read_unlock(&domlist_read_lock); - d = NULL; break; } -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue May 02 11:13:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 11:13:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528511.821774 (Exim 4.92) (envelope-from ) id 1ptnx8-0003bN-1c; Tue, 02 May 2023 11:13:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528511.821774; Tue, 02 May 2023 11:13:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptnx7-0003bG-VD; Tue, 02 May 2023 11:13:49 +0000 Received: by outflank-mailman (input) for mailman id 528511; Tue, 02 May 2023 11:13:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptnx6-0003LR-EJ for xen-devel@lists.xenproject.org; Tue, 02 May 2023 11:13:48 +0000 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [2a00:1450:4864:20::42a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 681b89b1-e8da-11ed-8611-37d641c3527e; Tue, 02 May 2023 13:13:46 +0200 (CEST) Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-306342d7668so790669f8f.1 for ; Tue, 02 May 2023 04:13:46 -0700 (PDT) Received: from localhost.localdomain (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id e5-20020a5d5005000000b0030469635629sm25685459wrt.62.2023.05.02.04.13.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 04:13:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 681b89b1-e8da-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1683026025; x=1685618025; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UJB458iJtLEmTYey1jxDUVCpJXePcaStPPsd47NEdBU=; b=Q0aQ2HbKVXh5yJ7uUaV235VFVGz5+dWaAOea//8omPCY0h+znmuO0LgbauEITZX4H8 J2gTW9FAy9o6wI2bHlCz5Mav1cC/GcLcF9vDuGqCfvh+HwP2vMGUIfMYD7Nb+pc33TNa OeIRTGNh38yLJADH0wb8vvWi6+eePVWkByR9Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683026025; x=1685618025; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UJB458iJtLEmTYey1jxDUVCpJXePcaStPPsd47NEdBU=; b=ClD6hS61XeuzP1Hg+GBzEhpj3YKUlTLLQfIvUmYFV7oBHb7uRib6Yd+9lmXs3+VZvs DFWzUS/n9ZFoWQI1adIRCQKqt2XAix3xexgFnTik9FV8QrCzmAGhW5ynnWydY6YXEzRj ceNCTJFTrs59RvsRK2SKroTA+ZDZCU4vkfKp8LYiIpN1vQuLgJCQPlQ9war49+g5gJ6U iNm1OPpgxGeZl0ZGV8pSeNXCBxTaJepNUQj0LWYCmghsUtrRRfSGa7byvIEDFOTzZUo3 N9dUrZZIpWUF4LR9tsHuTBaL+hyg4HLVkIxJLvlZGLYZHrL+rloAdjt5fa4B3rlQAhRQ O19Q== X-Gm-Message-State: AC+VfDw8hQ9T06xb8KkW2rRp3fTXiCySUtPwXU6uBXWiJdb+xYXxzhEx ggqoS8v0kplF1R9A719wd+39RMjc9/j7s8JyCy4= X-Google-Smtp-Source: ACHHUZ60duR1pheaga52MURiXLFcnhkK4Bv1d6HQdAP8fJOZPhDkYfo+dpoMpdaXlaBpau0mcGksNw== X-Received: by 2002:adf:e944:0:b0:306:284c:8f4c with SMTP id m4-20020adfe944000000b00306284c8f4cmr6164633wrn.64.1683026025509; Tue, 02 May 2023 04:13:45 -0700 (PDT) From: Alejandro Vallejo To: Xen-devel Cc: Alejandro Vallejo , Andrew Cooper , Wei Liu , Anthony PERARD , Juergen Gross , Christian Lindig Subject: [PATCH v3 1/3] tools: Modify single-domid callers of xc_domain_getinfolist() Date: Tue, 2 May 2023 12:13:36 +0100 Message-Id: <20230502111338.16757-2-alejandro.vallejo@cloud.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230502111338.16757-1-alejandro.vallejo@cloud.com> References: <20230502111338.16757-1-alejandro.vallejo@cloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit xc_domain_getinfolist() internally relies on a sysctl that performs a linear search for the domids. Many callers of xc_domain_getinfolist() who require information about a precise domid are much better off calling xc_domain_getinfo_single() instead, that will use the getdomaininfo domctl instead and ensure the returned domid matches the requested one. The domtctl will find the domid faster too, because that uses hashed lists. Signed-off-by: Alejandro Vallejo --- Cc: Andrew Cooper Cc: Wei Liu Cc: Anthony PERARD Cc: Juergen Gross Cc: Christian Lindig v3: * Replaced single-domid xc_domain_getinfolist() call in ocaml stub with xc_domain_getinfo_single() --- tools/libs/light/libxl_dom.c | 17 ++++++----------- tools/libs/light/libxl_dom_suspend.c | 7 +------ tools/libs/light/libxl_domain.c | 13 +++++-------- tools/libs/light/libxl_mem.c | 4 ++-- tools/libs/light/libxl_sched.c | 10 +++------- tools/ocaml/libs/xc/xenctrl_stubs.c | 6 ++---- tools/xenpaging/xenpaging.c | 10 +++++----- 7 files changed, 24 insertions(+), 43 deletions(-) diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c index 25fb716084..94fef37401 100644 --- a/tools/libs/light/libxl_dom.c +++ b/tools/libs/light/libxl_dom.c @@ -32,9 +32,9 @@ libxl_domain_type libxl__domain_type(libxl__gc *gc, uint32_t domid) xc_domaininfo_t info; int ret; - ret = xc_domain_getinfolist(ctx->xch, domid, 1, &info); - if (ret != 1 || info.domain != domid) { - LOG(ERROR, "unable to get domain type for domid=%"PRIu32, domid); + ret = xc_domain_getinfo_single(ctx->xch, domid, &info); + if (ret < 0) { + LOGED(ERROR, domid, "unable to get dominfo"); return LIBXL_DOMAIN_TYPE_INVALID; } if (info.flags & XEN_DOMINF_hvm_guest) { @@ -70,15 +70,10 @@ int libxl__domain_cpupool(libxl__gc *gc, uint32_t domid) xc_domaininfo_t info; int ret; - ret = xc_domain_getinfolist(CTX->xch, domid, 1, &info); - if (ret != 1) + ret = xc_domain_getinfo_single(CTX->xch, domid, &info); + if (ret < 0) { - LOGE(ERROR, "getinfolist failed %d", ret); - return ERROR_FAIL; - } - if (info.domain != domid) - { - LOGE(ERROR, "got info for dom%d, wanted dom%d\n", info.domain, domid); + LOGED(ERROR, domid, "get domaininfo failed"); return ERROR_FAIL; } return info.cpupool; diff --git a/tools/libs/light/libxl_dom_suspend.c b/tools/libs/light/libxl_dom_suspend.c index 4fa22bb739..6091a5f3f6 100644 --- a/tools/libs/light/libxl_dom_suspend.c +++ b/tools/libs/light/libxl_dom_suspend.c @@ -332,13 +332,8 @@ static void suspend_common_wait_guest_check(libxl__egc *egc, /* Convenience aliases */ const uint32_t domid = dsps->domid; - ret = xc_domain_getinfolist(CTX->xch, domid, 1, &info); + ret = xc_domain_getinfo_single(CTX->xch, domid, &info); if (ret < 0) { - LOGED(ERROR, domid, "unable to check for status of guest"); - goto err; - } - - if (!(ret == 1 && info.domain == domid)) { LOGED(ERROR, domid, "guest we were suspending has been destroyed"); goto err; } diff --git a/tools/libs/light/libxl_domain.c b/tools/libs/light/libxl_domain.c index 7f0986c185..5709b3e62f 100644 --- a/tools/libs/light/libxl_domain.c +++ b/tools/libs/light/libxl_domain.c @@ -349,16 +349,12 @@ int libxl_domain_info(libxl_ctx *ctx, libxl_dominfo *info_r, int ret; GC_INIT(ctx); - ret = xc_domain_getinfolist(ctx->xch, domid, 1, &xcinfo); + ret = xc_domain_getinfo_single(ctx->xch, domid, &xcinfo); if (ret<0) { - LOGED(ERROR, domid, "Getting domain info list"); + LOGED(ERROR, domid, "Getting domain info"); GC_FREE; return ERROR_FAIL; } - if (ret==0 || xcinfo.domain != domid) { - GC_FREE; - return ERROR_DOMAIN_NOTFOUND; - } if (info_r) libxl__xcinfo2xlinfo(ctx, &xcinfo, info_r); @@ -1657,14 +1653,15 @@ int libxl__resolve_domid(libxl__gc *gc, const char *name, uint32_t *domid) libxl_vcpuinfo *libxl_list_vcpu(libxl_ctx *ctx, uint32_t domid, int *nr_vcpus_out, int *nr_cpus_out) { + int rc; GC_INIT(ctx); libxl_vcpuinfo *ptr, *ret; xc_domaininfo_t domaininfo; xc_vcpuinfo_t vcpuinfo; unsigned int nr_vcpus; - if (xc_domain_getinfolist(ctx->xch, domid, 1, &domaininfo) != 1) { - LOGED(ERROR, domid, "Getting infolist"); + if ((rc = xc_domain_getinfo_single(ctx->xch, domid, &domaininfo)) < 0) { + LOGED(ERROR, domid, "Getting dominfo"); GC_FREE; return NULL; } diff --git a/tools/libs/light/libxl_mem.c b/tools/libs/light/libxl_mem.c index 92ec09f4cf..44e554adba 100644 --- a/tools/libs/light/libxl_mem.c +++ b/tools/libs/light/libxl_mem.c @@ -323,8 +323,8 @@ retry_transaction: libxl__xs_printf(gc, t, GCSPRINTF("%s/memory/target", dompath), "%"PRIu64, new_target_memkb); - r = xc_domain_getinfolist(ctx->xch, domid, 1, &info); - if (r != 1 || info.domain != domid) { + r = xc_domain_getinfo_single(ctx->xch, domid, &info); + if (r < 0) { abort_transaction = 1; rc = ERROR_FAIL; goto out; diff --git a/tools/libs/light/libxl_sched.c b/tools/libs/light/libxl_sched.c index 7c53dc60e6..21a65442c0 100644 --- a/tools/libs/light/libxl_sched.c +++ b/tools/libs/light/libxl_sched.c @@ -219,13 +219,11 @@ static int sched_credit_domain_set(libxl__gc *gc, uint32_t domid, xc_domaininfo_t domaininfo; int rc; - rc = xc_domain_getinfolist(CTX->xch, domid, 1, &domaininfo); + rc = xc_domain_getinfo_single(CTX->xch, domid, &domaininfo); if (rc < 0) { - LOGED(ERROR, domid, "Getting domain info list"); + LOGED(ERROR, domid, "Getting domain info"); return ERROR_FAIL; } - if (rc != 1 || domaininfo.domain != domid) - return ERROR_INVAL; rc = xc_sched_credit_domain_get(CTX->xch, domid, &sdom); if (rc != 0) { @@ -426,13 +424,11 @@ static int sched_credit2_domain_set(libxl__gc *gc, uint32_t domid, xc_domaininfo_t info; int rc; - rc = xc_domain_getinfolist(CTX->xch, domid, 1, &info); + rc = xc_domain_getinfo_single(CTX->xch, domid, &info); if (rc < 0) { LOGED(ERROR, domid, "Getting domain info"); return ERROR_FAIL; } - if (rc != 1 || info.domain != domid) - return ERROR_INVAL; rc = xc_sched_credit2_domain_get(CTX->xch, domid, &sdom); if (rc != 0) { diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c index 6ec9ed6d1e..f686db3124 100644 --- a/tools/ocaml/libs/xc/xenctrl_stubs.c +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c @@ -497,10 +497,8 @@ CAMLprim value stub_xc_domain_getinfo(value xch_val, value domid) xc_domaininfo_t info; int ret; - ret = xc_domain_getinfolist(xch, Int_val(domid), 1, &info); - if (ret != 1) - failwith_xc(xch); - if (info.domain != Int_val(domid)) + ret = xc_domain_getinfo_single(xch, Int_val(domid), &info); + if (ret < 0) failwith_xc(xch); result = alloc_domaininfo(&info); diff --git a/tools/xenpaging/xenpaging.c b/tools/xenpaging/xenpaging.c index 6e5490315d..c7a9a82477 100644 --- a/tools/xenpaging/xenpaging.c +++ b/tools/xenpaging/xenpaging.c @@ -169,8 +169,8 @@ static int xenpaging_get_tot_pages(struct xenpaging *paging) xc_domaininfo_t domain_info; int rc; - rc = xc_domain_getinfolist(xch, paging->vm_event.domain_id, 1, &domain_info); - if ( rc != 1 ) + rc = xc_domain_getinfo_single(xch, paging->vm_event.domain_id, &domain_info); + if ( rc < 0 ) { PERROR("Error getting domain info"); return -1; @@ -424,9 +424,9 @@ static struct xenpaging *xenpaging_init(int argc, char *argv[]) /* Get max_pages from guest if not provided via cmdline */ if ( !paging->max_pages ) { - rc = xc_domain_getinfolist(xch, paging->vm_event.domain_id, 1, - &domain_info); - if ( rc != 1 ) + rc = xc_domain_getinfo_single(xch, paging->vm_event.domain_id, + &domain_info); + if ( rc < 0 ) { PERROR("Error getting domain info"); goto err; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue May 02 11:13:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 11:13:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528513.821795 (Exim 4.92) (envelope-from ) id 1ptnxC-0004A8-Ki; Tue, 02 May 2023 11:13:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528513.821795; Tue, 02 May 2023 11:13:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptnxC-000494-HK; Tue, 02 May 2023 11:13:54 +0000 Received: by outflank-mailman (input) for mailman id 528513; Tue, 02 May 2023 11:13:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptnxA-0003LR-Rg for xen-devel@lists.xenproject.org; Tue, 02 May 2023 11:13:53 +0000 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [2a00:1450:4864:20::42e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6930062b-e8da-11ed-8611-37d641c3527e; Tue, 02 May 2023 13:13:48 +0200 (CEST) Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-2f58125b957so3699105f8f.3 for ; Tue, 02 May 2023 04:13:48 -0700 (PDT) Received: from localhost.localdomain (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id e5-20020a5d5005000000b0030469635629sm25685459wrt.62.2023.05.02.04.13.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 04:13:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6930062b-e8da-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1683026027; x=1685618027; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OvwXlyXdL/UMKYGghla11RapD1E2ZkL5ikYlGdKfGoY=; b=M4KZeD654X56iUYNnthflmlSakyP88bM68BJVMBaLC+pr/VYeK7oV3ggJK4zjOx0En MIeYadbhYp44N5S2w1t7AA1/dwjjiSORkSK8tQGID12MDAeuvclHsoGybfLHQrQZ5oZf 6jbtsU5vR0mfiPEngVyryFhWdCLX1ltfs1Z6M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683026027; x=1685618027; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OvwXlyXdL/UMKYGghla11RapD1E2ZkL5ikYlGdKfGoY=; b=JeWNoRNvYyoEDkAoS0cjCr2el5KytqRudXgGjjo9XEId/fG3bbR6J9UlK3SIn4Jk6d wLk1kL7EufHqpeOe+97zaJpun+gkXDfiPU05KlS1Od3PsQ569qgIP+Jv/n6Ha71lTusa 09UHBE9roFst/C9W6ON0sAFMux4A8w4T+AiVnsISODa6ovOR+69osBz1GTOImDdM3zKG 2vkz4wGh+Qt0XxoCAqp9IYSvh4A8/+QDESSEdM+u/xLFD0qlVXPd8dQjrCnEw1LcMXtd pYNwgydrmvZPBzW+W2FpK4xTlCq8j07R9+QBnU+jQizmj6pm+HG1r4A8wGVdz/jNtFQZ NxsA== X-Gm-Message-State: AC+VfDxB8qb/v3aW5oRhVzIBKNDVFX3QuHUXL4LmnkyC8sHaqscfgs5v TF4LYR60PeH3qf8kjb3mpwel1cP+9xPD8LPlL5Y= X-Google-Smtp-Source: ACHHUZ7Ux40yrsaBsU6lLwL5MdUTafOXKH9BTW/XAP17RY+0liZxNg8GViVrO/lKp1wJMHqQo4pjtg== X-Received: by 2002:a5d:618a:0:b0:2f8:3225:2bc1 with SMTP id j10-20020a5d618a000000b002f832252bc1mr13903769wru.41.1683026027164; Tue, 02 May 2023 04:13:47 -0700 (PDT) From: Alejandro Vallejo To: Xen-devel Cc: Alejandro Vallejo , Andrew Cooper , Wei Liu , Anthony PERARD , Tim Deegan , George Dunlap , Juergen Gross Subject: [PATCH v3 2/3] tools: Use new xc function for some xc_domain_getinfo() calls Date: Tue, 2 May 2023 12:13:37 +0100 Message-Id: <20230502111338.16757-3-alejandro.vallejo@cloud.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230502111338.16757-1-alejandro.vallejo@cloud.com> References: <20230502111338.16757-1-alejandro.vallejo@cloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Move calls that require a information about a single precisely identified domain to the new xc_domain_getinfo_single(). Signed-off-by: Alejandro Vallejo Reviewed-by: Andrew Cooper --- Cc: Andrew Cooper Cc: Wei Liu Cc: Anthony PERARD Cc: Tim Deegan Cc: George Dunlap Cc: Juergen Gross v3: * Stylistic changes that fell under the cracks on v2 * Reinserted -errno convention from v1 that had been removed in v2 --- tools/console/client/main.c | 7 ++--- tools/debugger/kdd/kdd-xen.c | 5 ++-- tools/libs/ctrl/xc_domain.c | 9 +++--- tools/libs/ctrl/xc_pagetab.c | 7 ++--- tools/libs/ctrl/xc_private.c | 9 +++--- tools/libs/ctrl/xc_private.h | 7 +++-- tools/libs/guest/xg_core.c | 23 ++++++-------- tools/libs/guest/xg_core.h | 6 ++-- tools/libs/guest/xg_core_arm.c | 10 +++---- tools/libs/guest/xg_core_x86.c | 18 +++++------ tools/libs/guest/xg_cpuid_x86.c | 40 +++++++++++++------------ tools/libs/guest/xg_dom_boot.c | 16 +++------- tools/libs/guest/xg_domain.c | 8 ++--- tools/libs/guest/xg_offline_page.c | 12 ++++---- tools/libs/guest/xg_private.h | 1 + tools/libs/guest/xg_resume.c | 20 ++++++------- tools/libs/guest/xg_sr_common.h | 2 +- tools/libs/guest/xg_sr_restore.c | 17 ++++------- tools/libs/guest/xg_sr_restore_x86_pv.c | 2 +- tools/libs/guest/xg_sr_save.c | 27 +++++++---------- tools/libs/guest/xg_sr_save_x86_pv.c | 6 ++-- tools/libs/light/libxl_sched.c | 16 +++++----- tools/libs/light/libxl_x86_acpi.c | 4 +-- tools/misc/xen-hvmcrash.c | 6 ++-- tools/misc/xen-lowmemd.c | 6 ++-- tools/misc/xen-mfndump.c | 22 ++++++-------- tools/misc/xen-vmtrace.c | 6 ++-- tools/vchan/vchan-socket-proxy.c | 6 ++-- tools/xenstore/xenstored_domain.c | 15 +++++----- tools/xentrace/xenctx.c | 8 ++--- 30 files changed, 158 insertions(+), 183 deletions(-) diff --git a/tools/console/client/main.c b/tools/console/client/main.c index 1a6fa162f7..6775006488 100644 --- a/tools/console/client/main.c +++ b/tools/console/client/main.c @@ -408,17 +408,16 @@ int main(int argc, char **argv) if (dom_path == NULL) err(errno, "xs_get_domain_path()"); if (type == CONSOLE_INVAL) { - xc_dominfo_t xcinfo; + xc_domaininfo_t xcinfo; xc_interface *xc_handle = xc_interface_open(0,0,0); if (xc_handle == NULL) err(errno, "Could not open xc interface"); - if ( (xc_domain_getinfo(xc_handle, domid, 1, &xcinfo) != 1) || - (xcinfo.domid != domid) ) { + if (xc_domain_getinfo_single(xc_handle, domid, &xcinfo) < 0) { xc_interface_close(xc_handle); err(errno, "Failed to get domain information"); } /* default to pv console for pv guests and serial for hvm guests */ - if (xcinfo.hvm) + if (xcinfo.flags & XEN_DOMINF_hvm_guest) type = CONSOLE_SERIAL; else type = CONSOLE_PV; diff --git a/tools/debugger/kdd/kdd-xen.c b/tools/debugger/kdd/kdd-xen.c index e78c9311c4..e63e267023 100644 --- a/tools/debugger/kdd/kdd-xen.c +++ b/tools/debugger/kdd/kdd-xen.c @@ -570,7 +570,7 @@ kdd_guest *kdd_guest_init(char *arg, FILE *log, int verbosity) kdd_guest *g = NULL; xc_interface *xch = NULL; uint32_t domid; - xc_dominfo_t info; + xc_domaininfo_t info; g = calloc(1, sizeof (kdd_guest)); if (!g) @@ -590,7 +590,8 @@ kdd_guest *kdd_guest_init(char *arg, FILE *log, int verbosity) g->domid = domid; /* Check that the domain exists and is HVM */ - if (xc_domain_getinfo(xch, domid, 1, &info) != 1 || !info.hvm) + if (xc_domain_getinfo_single(xch, domid, &info) < 0 || + !(info.flags & XEN_DOMINF_hvm_guest)) goto err; snprintf(g->id, (sizeof g->id) - 1, diff --git a/tools/libs/ctrl/xc_domain.c b/tools/libs/ctrl/xc_domain.c index d5f0923088..66179e6f12 100644 --- a/tools/libs/ctrl/xc_domain.c +++ b/tools/libs/ctrl/xc_domain.c @@ -1960,15 +1960,14 @@ int xc_domain_memory_mapping( uint32_t add_mapping) { DECLARE_DOMCTL; - xc_dominfo_t info; + xc_domaininfo_t info; int ret = 0, rc; unsigned long done = 0, nr, max_batch_sz; - if ( xc_domain_getinfo(xch, domid, 1, &info) != 1 || - info.domid != domid ) + if ( xc_domain_getinfo_single(xch, domid, &info) < 0 ) { - PERROR("Could not get info for domain"); - return -EINVAL; + PERROR("Could not get info for dom%u", domid); + return -1; } if ( !xc_core_arch_auto_translated_physmap(&info) ) return 0; diff --git a/tools/libs/ctrl/xc_pagetab.c b/tools/libs/ctrl/xc_pagetab.c index db25c20247..d9f886633a 100644 --- a/tools/libs/ctrl/xc_pagetab.c +++ b/tools/libs/ctrl/xc_pagetab.c @@ -29,17 +29,16 @@ unsigned long xc_translate_foreign_address(xc_interface *xch, uint32_t dom, int vcpu, unsigned long long virt) { - xc_dominfo_t dominfo; + xc_domaininfo_t dominfo; uint64_t paddr, mask, pte = 0; int size, level, pt_levels = 2; void *map; - if (xc_domain_getinfo(xch, dom, 1, &dominfo) != 1 - || dominfo.domid != dom) + if (xc_domain_getinfo_single(xch, dom, &dominfo) < 0) return 0; /* What kind of paging are we dealing with? */ - if (dominfo.hvm) { + if (dominfo.flags & XEN_DOMINF_hvm_guest) { struct hvm_hw_cpu ctx; if (xc_domain_hvm_getcontext_partial(xch, dom, HVM_SAVE_CODE(CPU), vcpu, diff --git a/tools/libs/ctrl/xc_private.c b/tools/libs/ctrl/xc_private.c index 2f99a7d2cf..6293a45531 100644 --- a/tools/libs/ctrl/xc_private.c +++ b/tools/libs/ctrl/xc_private.c @@ -441,11 +441,12 @@ int xc_machphys_mfn_list(xc_interface *xch, long xc_get_tot_pages(xc_interface *xch, uint32_t domid) { - xc_dominfo_t info; - if ( (xc_domain_getinfo(xch, domid, 1, &info) != 1) || - (info.domid != domid) ) + xc_domaininfo_t info; + + if ( xc_domain_getinfo_single(xch, domid, &info) < 0 ) return -1; - return info.nr_pages; + + return info.tot_pages; } int xc_copy_to_domain_page(xc_interface *xch, diff --git a/tools/libs/ctrl/xc_private.h b/tools/libs/ctrl/xc_private.h index 80dc464c93..8faabaea67 100644 --- a/tools/libs/ctrl/xc_private.h +++ b/tools/libs/ctrl/xc_private.h @@ -16,6 +16,7 @@ #ifndef XC_PRIVATE_H #define XC_PRIVATE_H +#include #include #include #include @@ -420,12 +421,12 @@ void *xc_vm_event_enable(xc_interface *xch, uint32_t domain_id, int param, int do_dm_op(xc_interface *xch, uint32_t domid, unsigned int nr_bufs, ...); #if defined (__i386__) || defined (__x86_64__) -static inline int xc_core_arch_auto_translated_physmap(const xc_dominfo_t *info) +static inline int xc_core_arch_auto_translated_physmap(const xc_domaininfo_t *info) { - return info->hvm; + return info->flags & XEN_DOMINF_hvm_guest; } #elif defined (__arm__) || defined(__aarch64__) -static inline int xc_core_arch_auto_translated_physmap(const xc_dominfo_t *info) +static inline int xc_core_arch_auto_translated_physmap(const xc_domaininfo_t *info) { return 1; } diff --git a/tools/libs/guest/xg_core.c b/tools/libs/guest/xg_core.c index c52f1161c1..f83436d6cb 100644 --- a/tools/libs/guest/xg_core.c +++ b/tools/libs/guest/xg_core.c @@ -349,7 +349,7 @@ elfnote_dump_none(xc_interface *xch, void *args, dumpcore_rtn_t dump_rtn) static int elfnote_dump_core_header( xc_interface *xch, - void *args, dumpcore_rtn_t dump_rtn, const xc_dominfo_t *info, + void *args, dumpcore_rtn_t dump_rtn, const xc_domaininfo_t *info, int nr_vcpus, unsigned long nr_pages) { int sts; @@ -361,7 +361,8 @@ elfnote_dump_core_header( elfnote.descsz = sizeof(header); elfnote.type = XEN_ELFNOTE_DUMPCORE_HEADER; - header.xch_magic = info->hvm ? XC_CORE_MAGIC_HVM : XC_CORE_MAGIC; + header.xch_magic = (info->flags & XEN_DOMINF_hvm_guest) ? XC_CORE_MAGIC_HVM + : XC_CORE_MAGIC; header.xch_nr_vcpus = nr_vcpus; header.xch_nr_pages = nr_pages; header.xch_page_size = PAGE_SIZE; @@ -423,7 +424,7 @@ xc_domain_dumpcore_via_callback(xc_interface *xch, void *args, dumpcore_rtn_t dump_rtn) { - xc_dominfo_t info; + xc_domaininfo_t info; shared_info_any_t *live_shinfo = NULL; struct domain_info_context _dinfo = {}; struct domain_info_context *dinfo = &_dinfo; @@ -468,15 +469,15 @@ xc_domain_dumpcore_via_callback(xc_interface *xch, goto out; } - if ( xc_domain_getinfo(xch, domid, 1, &info) != 1 ) + if ( xc_domain_getinfo_single(xch, domid, &info) < 0 ) { - PERROR("Could not get info for domain"); + PERROR("Could not get info for dom%u", domid); goto out; } /* Map the shared info frame */ live_shinfo = xc_map_foreign_range(xch, domid, PAGE_SIZE, PROT_READ, info.shared_info_frame); - if ( !live_shinfo && !info.hvm ) + if ( !live_shinfo && !(info.flags & XEN_DOMINF_hvm_guest) ) { PERROR("Couldn't map live_shinfo"); goto out; @@ -517,12 +518,6 @@ xc_domain_dumpcore_via_callback(xc_interface *xch, dinfo->guest_width = sizeof(unsigned long); } - if ( domid != info.domid ) - { - PERROR("Domain %d does not exist", domid); - goto out; - } - ctxt = calloc(sizeof(*ctxt), info.max_vcpu_id + 1); if ( !ctxt ) { @@ -560,9 +555,9 @@ xc_domain_dumpcore_via_callback(xc_interface *xch, * all the array... * * We don't want to use the total potential size of the memory map - * since that is usually much higher than info.nr_pages. + * since that is usually much higher than info.tot_pages. */ - nr_pages = info.nr_pages; + nr_pages = info.tot_pages; if ( !auto_translated_physmap ) { diff --git a/tools/libs/guest/xg_core.h b/tools/libs/guest/xg_core.h index aaca9e0a8b..ff577dad31 100644 --- a/tools/libs/guest/xg_core.h +++ b/tools/libs/guest/xg_core.h @@ -134,15 +134,15 @@ typedef struct xc_core_memory_map xc_core_memory_map_t; struct xc_core_arch_context; int xc_core_arch_memory_map_get(xc_interface *xch, struct xc_core_arch_context *arch_ctxt, - xc_dominfo_t *info, shared_info_any_t *live_shinfo, + xc_domaininfo_t *info, shared_info_any_t *live_shinfo, xc_core_memory_map_t **mapp, unsigned int *nr_entries); int xc_core_arch_map_p2m(xc_interface *xch, struct domain_info_context *dinfo, - xc_dominfo_t *info, shared_info_any_t *live_shinfo, + xc_domaininfo_t *info, shared_info_any_t *live_shinfo, xen_pfn_t **live_p2m); int xc_core_arch_map_p2m_writable(xc_interface *xch, struct domain_info_context *dinfo, - xc_dominfo_t *info, + xc_domaininfo_t *info, shared_info_any_t *live_shinfo, xen_pfn_t **live_p2m); diff --git a/tools/libs/guest/xg_core_arm.c b/tools/libs/guest/xg_core_arm.c index de30cf0c31..34276152da 100644 --- a/tools/libs/guest/xg_core_arm.c +++ b/tools/libs/guest/xg_core_arm.c @@ -33,14 +33,14 @@ xc_core_arch_gpfn_may_present(struct xc_core_arch_context *arch_ctxt, int xc_core_arch_memory_map_get(xc_interface *xch, struct xc_core_arch_context *unused, - xc_dominfo_t *info, shared_info_any_t *live_shinfo, + xc_domaininfo_t *info, shared_info_any_t *live_shinfo, xc_core_memory_map_t **mapp, unsigned int *nr_entries) { xen_pfn_t p2m_size = 0; xc_core_memory_map_t *map; - if ( xc_domain_nr_gpfns(xch, info->domid, &p2m_size) < 0 ) + if ( xc_domain_nr_gpfns(xch, info->domain, &p2m_size) < 0 ) return -1; map = malloc(sizeof(*map)); @@ -59,7 +59,7 @@ xc_core_arch_memory_map_get(xc_interface *xch, struct xc_core_arch_context *unus } static int -xc_core_arch_map_p2m_rw(xc_interface *xch, struct domain_info_context *dinfo, xc_dominfo_t *info, +xc_core_arch_map_p2m_rw(xc_interface *xch, struct domain_info_context *dinfo, xc_domaininfo_t *info, shared_info_any_t *live_shinfo, xen_pfn_t **live_p2m, int rw) { errno = ENOSYS; @@ -67,14 +67,14 @@ xc_core_arch_map_p2m_rw(xc_interface *xch, struct domain_info_context *dinfo, xc } int -xc_core_arch_map_p2m(xc_interface *xch, struct domain_info_context *dinfo, xc_dominfo_t *info, +xc_core_arch_map_p2m(xc_interface *xch, struct domain_info_context *dinfo, xc_domaininfo_t *info, shared_info_any_t *live_shinfo, xen_pfn_t **live_p2m) { return xc_core_arch_map_p2m_rw(xch, dinfo, info, live_shinfo, live_p2m, 0); } int -xc_core_arch_map_p2m_writable(xc_interface *xch, struct domain_info_context *dinfo, xc_dominfo_t *info, +xc_core_arch_map_p2m_writable(xc_interface *xch, struct domain_info_context *dinfo, xc_domaininfo_t *info, shared_info_any_t *live_shinfo, xen_pfn_t **live_p2m) { return xc_core_arch_map_p2m_rw(xch, dinfo, info, live_shinfo, live_p2m, 1); diff --git a/tools/libs/guest/xg_core_x86.c b/tools/libs/guest/xg_core_x86.c index c5e4542ccc..dbd3a440f7 100644 --- a/tools/libs/guest/xg_core_x86.c +++ b/tools/libs/guest/xg_core_x86.c @@ -49,14 +49,14 @@ xc_core_arch_gpfn_may_present(struct xc_core_arch_context *arch_ctxt, int xc_core_arch_memory_map_get(xc_interface *xch, struct xc_core_arch_context *unused, - xc_dominfo_t *info, shared_info_any_t *live_shinfo, + xc_domaininfo_t *info, shared_info_any_t *live_shinfo, xc_core_memory_map_t **mapp, unsigned int *nr_entries) { xen_pfn_t p2m_size = 0; xc_core_memory_map_t *map; - if ( xc_domain_nr_gpfns(xch, info->domid, &p2m_size) < 0 ) + if ( xc_domain_nr_gpfns(xch, info->domain, &p2m_size) < 0 ) return -1; map = malloc(sizeof(*map)); @@ -314,24 +314,24 @@ xc_core_arch_map_p2m_tree_rw(xc_interface *xch, struct domain_info_context *dinf } static int -xc_core_arch_map_p2m_rw(xc_interface *xch, struct domain_info_context *dinfo, xc_dominfo_t *info, +xc_core_arch_map_p2m_rw(xc_interface *xch, struct domain_info_context *dinfo, xc_domaininfo_t *info, shared_info_any_t *live_shinfo, xen_pfn_t **live_p2m, int rw) { xen_pfn_t *p2m_frame_list = NULL; uint64_t p2m_cr3; - uint32_t dom = info->domid; + uint32_t dom = info->domain; int ret = -1; int err; - if ( xc_domain_nr_gpfns(xch, info->domid, &dinfo->p2m_size) < 0 ) + if ( xc_domain_nr_gpfns(xch, info->domain, &dinfo->p2m_size) < 0 ) { ERROR("Could not get maximum GPFN!"); goto out; } - if ( dinfo->p2m_size < info->nr_pages ) + if ( dinfo->p2m_size < info->tot_pages ) { - ERROR("p2m_size < nr_pages -1 (%lx < %lx", dinfo->p2m_size, info->nr_pages - 1); + ERROR("p2m_size < nr_pages -1 (%lx < %"PRIx64, dinfo->p2m_size, info->tot_pages - 1); goto out; } @@ -366,14 +366,14 @@ out: } int -xc_core_arch_map_p2m(xc_interface *xch, struct domain_info_context *dinfo, xc_dominfo_t *info, +xc_core_arch_map_p2m(xc_interface *xch, struct domain_info_context *dinfo, xc_domaininfo_t *info, shared_info_any_t *live_shinfo, xen_pfn_t **live_p2m) { return xc_core_arch_map_p2m_rw(xch, dinfo, info, live_shinfo, live_p2m, 0); } int -xc_core_arch_map_p2m_writable(xc_interface *xch, struct domain_info_context *dinfo, xc_dominfo_t *info, +xc_core_arch_map_p2m_writable(xc_interface *xch, struct domain_info_context *dinfo, xc_domaininfo_t *info, shared_info_any_t *live_shinfo, xen_pfn_t **live_p2m) { return xc_core_arch_map_p2m_rw(xch, dinfo, info, live_shinfo, live_p2m, 1); diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c index bd16a87e48..57221ffea8 100644 --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -281,7 +281,8 @@ static int xc_cpuid_xend_policy( xc_interface *xch, uint32_t domid, const struct xc_xend_cpuid *xend) { int rc; - xc_dominfo_t di; + bool hvm; + xc_domaininfo_t di; unsigned int nr_leaves, nr_msrs; uint32_t err_leaf = -1, err_subleaf = -1, err_msr = -1; /* @@ -291,13 +292,13 @@ static int xc_cpuid_xend_policy( xen_cpuid_leaf_t *host = NULL, *def = NULL, *cur = NULL; unsigned int nr_host, nr_def, nr_cur; - if ( xc_domain_getinfo(xch, domid, 1, &di) != 1 || - di.domid != domid ) + if ( (rc = xc_domain_getinfo_single(xch, domid, &di)) < 0 ) { - ERROR("Failed to obtain d%d info", domid); - rc = -ESRCH; + PERROR("Failed to obtain d%d info", domid); + rc = -errno; goto fail; } + hvm = di.flags & XEN_DOMINF_hvm_guest; rc = xc_cpu_policy_get_size(xch, &nr_leaves, &nr_msrs); if ( rc ) @@ -330,12 +331,12 @@ static int xc_cpuid_xend_policy( /* Get the domain type's default policy. */ nr_msrs = 0; nr_def = nr_leaves; - rc = get_system_cpu_policy(xch, di.hvm ? XEN_SYSCTL_cpu_policy_hvm_default - : XEN_SYSCTL_cpu_policy_pv_default, + rc = get_system_cpu_policy(xch, hvm ? XEN_SYSCTL_cpu_policy_hvm_default + : XEN_SYSCTL_cpu_policy_pv_default, &nr_def, def, &nr_msrs, NULL); if ( rc ) { - PERROR("Failed to obtain %s def policy", di.hvm ? "hvm" : "pv"); + PERROR("Failed to obtain %s def policy", hvm ? "hvm" : "pv"); rc = -errno; goto fail; } @@ -428,7 +429,8 @@ int xc_cpuid_apply_policy(xc_interface *xch, uint32_t domid, bool restore, const struct xc_xend_cpuid *xend) { int rc; - xc_dominfo_t di; + bool hvm; + xc_domaininfo_t di; unsigned int i, nr_leaves, nr_msrs; xen_cpuid_leaf_t *leaves = NULL; struct cpu_policy *p = NULL; @@ -436,13 +438,13 @@ int xc_cpuid_apply_policy(xc_interface *xch, uint32_t domid, bool restore, uint32_t host_featureset[FEATURESET_NR_ENTRIES] = {}; uint32_t len = ARRAY_SIZE(host_featureset); - if ( xc_domain_getinfo(xch, domid, 1, &di) != 1 || - di.domid != domid ) + if ( (rc = xc_domain_getinfo_single(xch, domid, &di)) < 0 ) { - ERROR("Failed to obtain d%d info", domid); - rc = -ESRCH; + PERROR("Failed to obtain d%d info", domid); + rc = -errno; goto out; } + hvm = di.flags & XEN_DOMINF_hvm_guest; rc = xc_cpu_policy_get_size(xch, &nr_leaves, &nr_msrs); if ( rc ) @@ -475,12 +477,12 @@ int xc_cpuid_apply_policy(xc_interface *xch, uint32_t domid, bool restore, /* Get the domain's default policy. */ nr_msrs = 0; - rc = get_system_cpu_policy(xch, di.hvm ? XEN_SYSCTL_cpu_policy_hvm_default - : XEN_SYSCTL_cpu_policy_pv_default, + rc = get_system_cpu_policy(xch, hvm ? XEN_SYSCTL_cpu_policy_hvm_default + : XEN_SYSCTL_cpu_policy_pv_default, &nr_leaves, leaves, &nr_msrs, NULL); if ( rc ) { - PERROR("Failed to obtain %s default policy", di.hvm ? "hvm" : "pv"); + PERROR("Failed to obtain %s default policy", hvm ? "hvm" : "pv"); rc = -errno; goto out; } @@ -514,7 +516,7 @@ int xc_cpuid_apply_policy(xc_interface *xch, uint32_t domid, bool restore, p->feat.hle = test_bit(X86_FEATURE_HLE, host_featureset); p->feat.rtm = test_bit(X86_FEATURE_RTM, host_featureset); - if ( di.hvm ) + if ( hvm ) { p->feat.mpx = test_bit(X86_FEATURE_MPX, host_featureset); } @@ -571,7 +573,7 @@ int xc_cpuid_apply_policy(xc_interface *xch, uint32_t domid, bool restore, { p->extd.itsc = itsc; - if ( di.hvm ) + if ( hvm ) { p->basic.pae = pae; p->basic.vmx = nested_virt; @@ -579,7 +581,7 @@ int xc_cpuid_apply_policy(xc_interface *xch, uint32_t domid, bool restore, } } - if ( !di.hvm ) + if ( !hvm ) { /* * On hardware without CPUID Faulting, PV guests see real topology. diff --git a/tools/libs/guest/xg_dom_boot.c b/tools/libs/guest/xg_dom_boot.c index 263a3f4c85..6e0847e718 100644 --- a/tools/libs/guest/xg_dom_boot.c +++ b/tools/libs/guest/xg_dom_boot.c @@ -164,7 +164,7 @@ void *xc_dom_boot_domU_map(struct xc_dom_image *dom, xen_pfn_t pfn, int xc_dom_boot_image(struct xc_dom_image *dom) { - xc_dominfo_t info; + xc_domaininfo_t info; int rc; DOMPRINTF_CALLED(dom->xch); @@ -174,19 +174,11 @@ int xc_dom_boot_image(struct xc_dom_image *dom) return rc; /* collect some info */ - rc = xc_domain_getinfo(dom->xch, dom->guest_domid, 1, &info); - if ( rc < 0 ) - { - xc_dom_panic(dom->xch, XC_INTERNAL_ERROR, - "%s: getdomaininfo failed (rc=%d)", __FUNCTION__, rc); - return rc; - } - if ( rc == 0 || info.domid != dom->guest_domid ) + if ( xc_domain_getinfo_single(dom->xch, dom->guest_domid, &info) < 0 ) { xc_dom_panic(dom->xch, XC_INTERNAL_ERROR, - "%s: Huh? No domains found (nr_domains=%d) " - "or domid mismatch (%d != %d)", __FUNCTION__, - rc, info.domid, dom->guest_domid); + "%s: getdomaininfo failed (errno=%d)", + __func__, errno); return -1; } dom->shared_info_mfn = info.shared_info_frame; diff --git a/tools/libs/guest/xg_domain.c b/tools/libs/guest/xg_domain.c index f0e7748449..198f6f904a 100644 --- a/tools/libs/guest/xg_domain.c +++ b/tools/libs/guest/xg_domain.c @@ -37,7 +37,7 @@ int xc_map_domain_meminfo(xc_interface *xch, uint32_t domid, { struct domain_info_context _di; - xc_dominfo_t info; + xc_domaininfo_t info; shared_info_any_t *live_shinfo; xen_capabilities_info_t xen_caps = ""; unsigned long i; @@ -49,9 +49,9 @@ int xc_map_domain_meminfo(xc_interface *xch, uint32_t domid, return -1; } - if ( xc_domain_getinfo(xch, domid, 1, &info) != 1 ) + if ( xc_domain_getinfo_single(xch, domid, &info) < 0 ) { - PERROR("Could not get domain info"); + PERROR("Could not get dominfo for dom%u", domid); return -1; } @@ -86,7 +86,7 @@ int xc_map_domain_meminfo(xc_interface *xch, uint32_t domid, info.shared_info_frame); if ( !live_shinfo ) { - PERROR("Could not map the shared info frame (MFN 0x%lx)", + PERROR("Could not map the shared info frame (MFN 0x%"PRIx64")", info.shared_info_frame); return -1; } diff --git a/tools/libs/guest/xg_offline_page.c b/tools/libs/guest/xg_offline_page.c index ccd0299f0f..292f73a3e7 100644 --- a/tools/libs/guest/xg_offline_page.c +++ b/tools/libs/guest/xg_offline_page.c @@ -370,7 +370,7 @@ static int clear_pte(xc_interface *xch, uint32_t domid, */ static int is_page_exchangable(xc_interface *xch, uint32_t domid, xen_pfn_t mfn, - xc_dominfo_t *info) + xc_domaininfo_t *info) { uint32_t status; int rc; @@ -381,7 +381,7 @@ static int is_page_exchangable(xc_interface *xch, uint32_t domid, xen_pfn_t mfn, DPRINTF("Dom0's page can't be LM"); return 0; } - if (info->hvm) + if (info->flags & XEN_DOMINF_hvm_guest) { DPRINTF("Currently we can only live change PV guest's page\n"); return 0; @@ -462,7 +462,7 @@ err0: /* The domain should be suspended when called here */ int xc_exchange_page(xc_interface *xch, uint32_t domid, xen_pfn_t mfn) { - xc_dominfo_t info; + xc_domaininfo_t info; struct xc_domain_meminfo minfo; struct xc_mmu *mmu = NULL; struct pte_backup old_ptes = {NULL, 0, 0}; @@ -477,13 +477,13 @@ int xc_exchange_page(xc_interface *xch, uint32_t domid, xen_pfn_t mfn) xen_pfn_t *m2p_table; unsigned long max_mfn; - if ( xc_domain_getinfo(xch, domid, 1, &info) != 1 ) + if ( xc_domain_getinfo_single(xch, domid, &info) < 0 ) { - ERROR("Could not get domain info"); + PERROR("Could not get domain info for dom%u", domid); return -1; } - if (!info.shutdown || info.shutdown_reason != SHUTDOWN_suspend) + if (!dominfo_shutdown_with(&info, SHUTDOWN_suspend)) { errno = EINVAL; ERROR("Can't exchange page unless domain is suspended\n"); diff --git a/tools/libs/guest/xg_private.h b/tools/libs/guest/xg_private.h index e729a8106c..d73947094f 100644 --- a/tools/libs/guest/xg_private.h +++ b/tools/libs/guest/xg_private.h @@ -16,6 +16,7 @@ #ifndef XG_PRIVATE_H #define XG_PRIVATE_H +#include #include #include #include diff --git a/tools/libs/guest/xg_resume.c b/tools/libs/guest/xg_resume.c index 77e2451a3c..c85d09a7f5 100644 --- a/tools/libs/guest/xg_resume.c +++ b/tools/libs/guest/xg_resume.c @@ -26,28 +26,28 @@ static int modify_returncode(xc_interface *xch, uint32_t domid) { vcpu_guest_context_any_t ctxt; - xc_dominfo_t info; + xc_domaininfo_t info; xen_capabilities_info_t caps; struct domain_info_context _dinfo = {}; struct domain_info_context *dinfo = &_dinfo; int rc; - if ( xc_domain_getinfo(xch, domid, 1, &info) != 1 || - info.domid != domid ) + if ( xc_domain_getinfo_single(xch, domid, &info) < 0 ) { - PERROR("Could not get domain info"); + PERROR("Could not get info for dom%u", domid); return -1; } - if ( !info.shutdown || (info.shutdown_reason != SHUTDOWN_suspend) ) + if ( !dominfo_shutdown_with(&info, SHUTDOWN_suspend) ) { ERROR("Dom %d not suspended: (shutdown %d, reason %d)", domid, - info.shutdown, info.shutdown_reason); + info.flags & XEN_DOMINF_shutdown, + dominfo_shutdown_reason(&info)); errno = EINVAL; return -1; } - if ( info.hvm ) + if ( info.flags & XEN_DOMINF_hvm_guest ) { /* HVM guests without PV drivers have no return code to modify. */ uint64_t irq = 0; @@ -133,7 +133,7 @@ static int xc_domain_resume_hvm(xc_interface *xch, uint32_t domid) static int xc_domain_resume_any(xc_interface *xch, uint32_t domid) { DECLARE_DOMCTL; - xc_dominfo_t info; + xc_domaininfo_t info; int i, rc = -1; #if defined(__i386__) || defined(__x86_64__) struct domain_info_context _dinfo = { .guest_width = 0, @@ -146,7 +146,7 @@ static int xc_domain_resume_any(xc_interface *xch, uint32_t domid) xen_pfn_t *p2m = NULL; #endif - if ( xc_domain_getinfo(xch, domid, 1, &info) != 1 ) + if ( xc_domain_getinfo_single(xch, domid, &info) < 0 ) { PERROR("Could not get domain info"); return rc; @@ -156,7 +156,7 @@ static int xc_domain_resume_any(xc_interface *xch, uint32_t domid) * (x86 only) Rewrite store_mfn and console_mfn back to MFN (from PFN). */ #if defined(__i386__) || defined(__x86_64__) - if ( info.hvm ) + if ( info.flags & XEN_DOMINF_hvm_guest ) return xc_domain_resume_hvm(xch, domid); if ( xc_domain_get_guest_width(xch, domid, &dinfo->guest_width) != 0 ) diff --git a/tools/libs/guest/xg_sr_common.h b/tools/libs/guest/xg_sr_common.h index 36d45ef56f..2f058ee3a6 100644 --- a/tools/libs/guest/xg_sr_common.h +++ b/tools/libs/guest/xg_sr_common.h @@ -220,7 +220,7 @@ struct xc_sr_context /* Plain VM, or checkpoints over time. */ xc_stream_type_t stream_type; - xc_dominfo_t dominfo; + xc_domaininfo_t dominfo; union /* Common save or restore data. */ { diff --git a/tools/libs/guest/xg_sr_restore.c b/tools/libs/guest/xg_sr_restore.c index 7314a24cf9..06231ca826 100644 --- a/tools/libs/guest/xg_sr_restore.c +++ b/tools/libs/guest/xg_sr_restore.c @@ -852,6 +852,7 @@ int xc_domain_restore(xc_interface *xch, int io_fd, uint32_t dom, xc_stream_type_t stream_type, struct restore_callbacks *callbacks, int send_back_fd) { + bool hvm; xen_pfn_t nr_pfns; struct xc_sr_context ctx = { .xch = xch, @@ -887,20 +888,15 @@ int xc_domain_restore(xc_interface *xch, int io_fd, uint32_t dom, break; } - if ( xc_domain_getinfo(xch, dom, 1, &ctx.dominfo) != 1 ) + if ( xc_domain_getinfo_single(xch, dom, &ctx.dominfo) < 0 ) { - PERROR("Failed to get domain info"); - return -1; - } - - if ( ctx.dominfo.domid != dom ) - { - ERROR("Domain %u does not exist", dom); + PERROR("Failed to get dominfo for dom%u", dom); return -1; } + hvm = ctx.dominfo.flags & XEN_DOMINF_hvm_guest; DPRINTF("fd %d, dom %u, hvm %u, stream_type %d", - io_fd, dom, ctx.dominfo.hvm, stream_type); + io_fd, dom, hvm, stream_type); ctx.domid = dom; @@ -914,8 +910,7 @@ int xc_domain_restore(xc_interface *xch, int io_fd, uint32_t dom, } ctx.restore.p2m_size = nr_pfns; - ctx.restore.ops = ctx.dominfo.hvm - ? restore_ops_x86_hvm : restore_ops_x86_pv; + ctx.restore.ops = hvm ? restore_ops_x86_hvm : restore_ops_x86_pv; if ( restore(&ctx) ) return -1; diff --git a/tools/libs/guest/xg_sr_restore_x86_pv.c b/tools/libs/guest/xg_sr_restore_x86_pv.c index dc50b0f5a8..eaeb97f4a0 100644 --- a/tools/libs/guest/xg_sr_restore_x86_pv.c +++ b/tools/libs/guest/xg_sr_restore_x86_pv.c @@ -903,7 +903,7 @@ static int handle_shared_info(struct xc_sr_context *ctx, ctx->dominfo.shared_info_frame); if ( !guest_shinfo ) { - PERROR("Failed to map Shared Info at mfn %#lx", + PERROR("Failed to map Shared Info at mfn %#"PRIx64, ctx->dominfo.shared_info_frame); goto err; } diff --git a/tools/libs/guest/xg_sr_save.c b/tools/libs/guest/xg_sr_save.c index 9853d8d846..3b2c5222e4 100644 --- a/tools/libs/guest/xg_sr_save.c +++ b/tools/libs/guest/xg_sr_save.c @@ -336,19 +336,18 @@ static int suspend_domain(struct xc_sr_context *ctx) } /* Refresh domain information. */ - if ( (xc_domain_getinfo(xch, ctx->domid, 1, &ctx->dominfo) != 1) || - (ctx->dominfo.domid != ctx->domid) ) + if ( xc_domain_getinfo_single(xch, ctx->domid, &ctx->dominfo) < 0 ) { PERROR("Unable to refresh domain information"); return -1; } /* Confirm the domain has actually been paused. */ - if ( !ctx->dominfo.shutdown || - (ctx->dominfo.shutdown_reason != SHUTDOWN_suspend) ) + if ( !dominfo_shutdown_with(&ctx->dominfo, SHUTDOWN_suspend) ) { ERROR("Domain has not been suspended: shutdown %d, reason %d", - ctx->dominfo.shutdown, ctx->dominfo.shutdown_reason); + ctx->dominfo.flags & XEN_DOMINF_shutdown, + dominfo_shutdown_reason(&ctx->dominfo)); return -1; } @@ -893,8 +892,7 @@ static int save(struct xc_sr_context *ctx, uint16_t guest_type) if ( rc ) goto err; - if ( !ctx->dominfo.shutdown || - (ctx->dominfo.shutdown_reason != SHUTDOWN_suspend) ) + if ( !dominfo_shutdown_with(&ctx->dominfo, SHUTDOWN_suspend) ) { ERROR("Domain has not been suspended"); rc = -1; @@ -989,6 +987,7 @@ int xc_domain_save(xc_interface *xch, int io_fd, uint32_t dom, .fd = io_fd, .stream_type = stream_type, }; + bool hvm; /* GCC 4.4 (of CentOS 6.x vintage) can' t initialise anonymous unions. */ ctx.save.callbacks = callbacks; @@ -996,17 +995,13 @@ int xc_domain_save(xc_interface *xch, int io_fd, uint32_t dom, ctx.save.debug = !!(flags & XCFLAGS_DEBUG); ctx.save.recv_fd = recv_fd; - if ( xc_domain_getinfo(xch, dom, 1, &ctx.dominfo) != 1 ) + if ( xc_domain_getinfo_single(xch, dom, &ctx.dominfo) < 0 ) { PERROR("Failed to get domain info"); return -1; } - if ( ctx.dominfo.domid != dom ) - { - ERROR("Domain %u does not exist", dom); - return -1; - } + hvm = ctx.dominfo.flags & XEN_DOMINF_hvm_guest; /* Sanity check stream_type-related parameters */ switch ( stream_type ) @@ -1018,7 +1013,7 @@ int xc_domain_save(xc_interface *xch, int io_fd, uint32_t dom, assert(callbacks->checkpoint && callbacks->postcopy); /* Fallthrough */ case XC_STREAM_PLAIN: - if ( ctx.dominfo.hvm ) + if ( hvm ) assert(callbacks->switch_qemu_logdirty); break; @@ -1028,11 +1023,11 @@ int xc_domain_save(xc_interface *xch, int io_fd, uint32_t dom, } DPRINTF("fd %d, dom %u, flags %u, hvm %d", - io_fd, dom, flags, ctx.dominfo.hvm); + io_fd, dom, flags, hvm); ctx.domid = dom; - if ( ctx.dominfo.hvm ) + if ( hvm ) { ctx.save.ops = save_ops_x86_hvm; return save(&ctx, DHDR_TYPE_X86_HVM); diff --git a/tools/libs/guest/xg_sr_save_x86_pv.c b/tools/libs/guest/xg_sr_save_x86_pv.c index 4964f1f7b8..f3d7a7a71a 100644 --- a/tools/libs/guest/xg_sr_save_x86_pv.c +++ b/tools/libs/guest/xg_sr_save_x86_pv.c @@ -20,7 +20,7 @@ static int map_shinfo(struct xc_sr_context *ctx) xch, ctx->domid, PAGE_SIZE, PROT_READ, ctx->dominfo.shared_info_frame); if ( !ctx->x86.pv.shinfo ) { - PERROR("Failed to map shared info frame at mfn %#lx", + PERROR("Failed to map shared info frame at mfn %#"PRIx64, ctx->dominfo.shared_info_frame); return -1; } @@ -943,7 +943,7 @@ static int normalise_pagetable(struct xc_sr_context *ctx, const uint64_t *src, #ifdef __i386__ if ( mfn == INVALID_MFN ) { - if ( !ctx->dominfo.paused ) + if ( !(ctx->dominfo.flags & XEN_DOMINF_paused) ) errno = EAGAIN; else { @@ -965,7 +965,7 @@ static int normalise_pagetable(struct xc_sr_context *ctx, const uint64_t *src, if ( !mfn_in_pseudophysmap(ctx, mfn) ) { - if ( !ctx->dominfo.paused ) + if ( !(ctx->dominfo.flags & XEN_DOMINF_paused) ) errno = EAGAIN; else { diff --git a/tools/libs/light/libxl_sched.c b/tools/libs/light/libxl_sched.c index 21a65442c0..b87e490d12 100644 --- a/tools/libs/light/libxl_sched.c +++ b/tools/libs/light/libxl_sched.c @@ -498,10 +498,10 @@ static int sched_rtds_vcpu_get(libxl__gc *gc, uint32_t domid, { uint32_t num_vcpus; int i, r, rc; - xc_dominfo_t info; + xc_domaininfo_t info; struct xen_domctl_schedparam_vcpu *vcpus; - r = xc_domain_getinfo(CTX->xch, domid, 1, &info); + r = xc_domain_getinfo_single(CTX->xch, domid, &info); if (r < 0) { LOGED(ERROR, domid, "Getting domain info"); rc = ERROR_FAIL; @@ -552,10 +552,10 @@ static int sched_rtds_vcpu_get_all(libxl__gc *gc, uint32_t domid, { uint32_t num_vcpus; int i, r, rc; - xc_dominfo_t info; + xc_domaininfo_t info; struct xen_domctl_schedparam_vcpu *vcpus; - r = xc_domain_getinfo(CTX->xch, domid, 1, &info); + r = xc_domain_getinfo_single(CTX->xch, domid, &info); if (r < 0) { LOGED(ERROR, domid, "Getting domain info"); rc = ERROR_FAIL; @@ -602,10 +602,10 @@ static int sched_rtds_vcpu_set(libxl__gc *gc, uint32_t domid, int r, rc; int i; uint16_t max_vcpuid; - xc_dominfo_t info; + xc_domaininfo_t info; struct xen_domctl_schedparam_vcpu *vcpus; - r = xc_domain_getinfo(CTX->xch, domid, 1, &info); + r = xc_domain_getinfo_single(CTX->xch, domid, &info); if (r < 0) { LOGED(ERROR, domid, "Getting domain info"); rc = ERROR_FAIL; @@ -662,11 +662,11 @@ static int sched_rtds_vcpu_set_all(libxl__gc *gc, uint32_t domid, int r, rc; int i; uint16_t max_vcpuid; - xc_dominfo_t info; + xc_domaininfo_t info; struct xen_domctl_schedparam_vcpu *vcpus; uint32_t num_vcpus; - r = xc_domain_getinfo(CTX->xch, domid, 1, &info); + r = xc_domain_getinfo_single(CTX->xch, domid, &info); if (r < 0) { LOGED(ERROR, domid, "Getting domain info"); rc = ERROR_FAIL; diff --git a/tools/libs/light/libxl_x86_acpi.c b/tools/libs/light/libxl_x86_acpi.c index 22eb160659..796b009d0c 100644 --- a/tools/libs/light/libxl_x86_acpi.c +++ b/tools/libs/light/libxl_x86_acpi.c @@ -87,14 +87,14 @@ static int init_acpi_config(libxl__gc *gc, { xc_interface *xch = dom->xch; uint32_t domid = dom->guest_domid; - xc_dominfo_t info; + xc_domaininfo_t info; struct hvm_info_table *hvminfo; int i, r, rc; config->dsdt_anycpu = config->dsdt_15cpu = dsdt_pvh; config->dsdt_anycpu_len = config->dsdt_15cpu_len = dsdt_pvh_len; - r = xc_domain_getinfo(xch, domid, 1, &info); + r = xc_domain_getinfo_single(xch, domid, &info); if (r < 0) { LOG(ERROR, "getdomaininfo failed (rc=%d)", r); rc = ERROR_FAIL; diff --git a/tools/misc/xen-hvmcrash.c b/tools/misc/xen-hvmcrash.c index 4f0dabcb18..1d058fa40a 100644 --- a/tools/misc/xen-hvmcrash.c +++ b/tools/misc/xen-hvmcrash.c @@ -48,7 +48,7 @@ main(int argc, char **argv) { int domid; xc_interface *xch; - xc_dominfo_t dominfo; + xc_domaininfo_t dominfo; int ret; uint32_t len; uint8_t *buf; @@ -66,13 +66,13 @@ main(int argc, char **argv) exit(1); } - ret = xc_domain_getinfo(xch, domid, 1, &dominfo); + ret = xc_domain_getinfo_single(xch, domid, &dominfo); if (ret < 0) { perror("xc_domain_getinfo"); exit(1); } - if (!dominfo.hvm) { + if (!(dominfo.flags & XEN_DOMINF_hvm_guest)) { fprintf(stderr, "domain %d is not HVM\n", domid); exit(1); } diff --git a/tools/misc/xen-lowmemd.c b/tools/misc/xen-lowmemd.c index a3a2741242..9d5cb549a8 100644 --- a/tools/misc/xen-lowmemd.c +++ b/tools/misc/xen-lowmemd.c @@ -38,7 +38,7 @@ void cleanup(void) #define BUFSZ 512 void handle_low_mem(void) { - xc_dominfo_t dom0_info; + xc_domaininfo_t dom0_info; xc_physinfo_t info; unsigned long long free_pages, dom0_pages, diff, dom0_target; char data[BUFSZ], error[BUFSZ]; @@ -58,13 +58,13 @@ void handle_low_mem(void) return; diff = THRESHOLD_PG - free_pages; - if (xc_domain_getinfo(xch, 0, 1, &dom0_info) < 1) + if (xc_domain_getinfo_single(xch, 0, &dom0_info) < 0) { perror("Failed to get dom0 info"); return; } - dom0_pages = (unsigned long long) dom0_info.nr_pages; + dom0_pages = (unsigned long long) dom0_info.tot_pages; printf("Dom0 pages: 0x%llx:%llu\n", dom0_pages, dom0_pages); dom0_target = dom0_pages - diff; if (dom0_target <= DOM0_FLOOR_PG) diff --git a/tools/misc/xen-mfndump.c b/tools/misc/xen-mfndump.c index b32c95e262..8863ece3f5 100644 --- a/tools/misc/xen-mfndump.c +++ b/tools/misc/xen-mfndump.c @@ -74,7 +74,7 @@ int dump_m2p_func(int argc, char *argv[]) int dump_p2m_func(int argc, char *argv[]) { struct xc_domain_meminfo minfo; - xc_dominfo_t info; + xc_domaininfo_t info; unsigned long i; int domid; @@ -85,8 +85,7 @@ int dump_p2m_func(int argc, char *argv[]) } domid = atoi(argv[0]); - if ( xc_domain_getinfo(xch, domid, 1, &info) != 1 || - info.domid != domid ) + if ( xc_domain_getinfo_single(xch, domid, &info) < 0 ) { ERROR("Failed to obtain info for domain %d\n", domid); return -1; @@ -158,7 +157,7 @@ int dump_p2m_func(int argc, char *argv[]) int dump_ptes_func(int argc, char *argv[]) { struct xc_domain_meminfo minfo; - xc_dominfo_t info; + xc_domaininfo_t info; void *page = NULL; unsigned long i, max_mfn; int domid, pte_num, rc = 0; @@ -172,8 +171,7 @@ int dump_ptes_func(int argc, char *argv[]) domid = atoi(argv[0]); mfn = strtoul(argv[1], NULL, 16); - if ( xc_domain_getinfo(xch, domid, 1, &info) != 1 || - info.domid != domid ) + if ( xc_domain_getinfo_single(xch, domid, &info) < 0 ) { ERROR("Failed to obtain info for domain %d\n", domid); return -1; @@ -266,7 +264,7 @@ int dump_ptes_func(int argc, char *argv[]) int lookup_pte_func(int argc, char *argv[]) { struct xc_domain_meminfo minfo; - xc_dominfo_t info; + xc_domaininfo_t info; void *page = NULL; unsigned long i, j; int domid, pte_num; @@ -280,8 +278,7 @@ int lookup_pte_func(int argc, char *argv[]) domid = atoi(argv[0]); mfn = strtoul(argv[1], NULL, 16); - if ( xc_domain_getinfo(xch, domid, 1, &info) != 1 || - info.domid != domid ) + if ( xc_domain_getinfo_single(xch, domid, &info) < 0 ) { ERROR("Failed to obtain info for domain %d\n", domid); return -1; @@ -336,7 +333,7 @@ int lookup_pte_func(int argc, char *argv[]) int memcmp_mfns_func(int argc, char *argv[]) { - xc_dominfo_t info1, info2; + xc_domaininfo_t info1, info2; void *page1 = NULL, *page2 = NULL; int domid1, domid2; xen_pfn_t mfn1, mfn2; @@ -352,9 +349,8 @@ int memcmp_mfns_func(int argc, char *argv[]) mfn1 = strtoul(argv[1], NULL, 16); mfn2 = strtoul(argv[3], NULL, 16); - if ( xc_domain_getinfo(xch, domid1, 1, &info1) != 1 || - xc_domain_getinfo(xch, domid2, 1, &info2) != 1 || - info1.domid != domid1 || info2.domid != domid2) + if ( xc_domain_getinfo_single(xch, domid1, &info1) < 0 || + xc_domain_getinfo_single(xch, domid2, &info2) < 0) { ERROR("Failed to obtain info for domains\n"); return -1; diff --git a/tools/misc/xen-vmtrace.c b/tools/misc/xen-vmtrace.c index 5b688a54af..ba2ce17a17 100644 --- a/tools/misc/xen-vmtrace.c +++ b/tools/misc/xen-vmtrace.c @@ -133,15 +133,15 @@ int main(int argc, char **argv) while ( !interrupted ) { - xc_dominfo_t dominfo; + xc_domaininfo_t dominfo; if ( get_more_data() ) goto out; usleep(1000 * 100); - if ( xc_domain_getinfo(xch, domid, 1, &dominfo) != 1 || - dominfo.domid != domid || dominfo.shutdown ) + if ( xc_domain_getinfo_single(xch, domid, &dominfo) < 0 || + (dominfo.flags & XEN_DOMINF_shutdown) ) { if ( get_more_data() ) goto out; diff --git a/tools/vchan/vchan-socket-proxy.c b/tools/vchan/vchan-socket-proxy.c index e1d959c6d1..9c4c336b03 100644 --- a/tools/vchan/vchan-socket-proxy.c +++ b/tools/vchan/vchan-socket-proxy.c @@ -222,7 +222,7 @@ static struct libxenvchan *connect_vchan(int domid, const char *path) { struct libxenvchan *ctrl = NULL; struct xs_handle *xs = NULL; xc_interface *xc = NULL; - xc_dominfo_t dominfo; + xc_domaininfo_t dominfo; char **watch_ret; unsigned int watch_num; int ret; @@ -254,12 +254,12 @@ static struct libxenvchan *connect_vchan(int domid, const char *path) { if (ctrl) break; - ret = xc_domain_getinfo(xc, domid, 1, &dominfo); + ret = xc_domain_getinfo_single(xc, domid, &dominfo); /* break the loop if domain is definitely not there anymore, but * continue if it is or the call failed (like EPERM) */ if (ret == -1 && errno == ESRCH) break; - if (ret == 1 && (dominfo.domid != (uint32_t)domid || dominfo.dying)) + if (ret == 0 && (dominfo.flags & XEN_DOMINF_dying)) break; } diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index f62be2245c..aeb7595ae1 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -339,15 +339,14 @@ static int destroy_domain(void *_domain) return 0; } -static bool get_domain_info(unsigned int domid, xc_dominfo_t *dominfo) +static bool get_domain_info(unsigned int domid, xc_domaininfo_t *dominfo) { - return xc_domain_getinfo(*xc_handle, domid, 1, dominfo) == 1 && - dominfo->domid == domid; + return xc_domain_getinfo_single(*xc_handle, domid, dominfo) == 0; } static int check_domain(const void *k, void *v, void *arg) { - xc_dominfo_t dominfo; + xc_domaininfo_t dominfo; struct connection *conn; bool dom_valid; struct domain *domain = v; @@ -360,12 +359,12 @@ static int check_domain(const void *k, void *v, void *arg) return 0; } if (dom_valid) { - if ((dominfo.crashed || dominfo.shutdown) + if ((dominfo.flags & XEN_DOMINF_shutdown) && !domain->shutdown) { domain->shutdown = true; *notify = true; } - if (!dominfo.dying) + if (!(dominfo.flags & XEN_DOMINF_dying)) return 0; } if (domain->conn) { @@ -486,7 +485,7 @@ static struct domain *find_or_alloc_domain(const void *ctx, unsigned int domid) static struct domain *find_or_alloc_existing_domain(unsigned int domid) { struct domain *domain; - xc_dominfo_t dominfo; + xc_domaininfo_t dominfo; domain = find_domain_struct(domid); if (!domain && get_domain_info(domid, &dominfo)) @@ -1010,7 +1009,7 @@ int domain_alloc_permrefs(struct node_perms *perms) { unsigned int i, domid; struct domain *d; - xc_dominfo_t dominfo; + xc_domaininfo_t dominfo; for (i = 0; i < perms->num; i++) { domid = perms->p[i].id; diff --git a/tools/xentrace/xenctx.c b/tools/xentrace/xenctx.c index 85ba0c0fa6..9acb9db460 100644 --- a/tools/xentrace/xenctx.c +++ b/tools/xentrace/xenctx.c @@ -92,7 +92,7 @@ static struct xenctx { int do_stack; #endif int kernel_start_set; - xc_dominfo_t dominfo; + xc_domaininfo_t dominfo; } xenctx; struct symbol { @@ -989,7 +989,7 @@ static void dump_ctx(int vcpu) #if defined(__i386__) || defined(__x86_64__) { - if (xenctx.dominfo.hvm) { + if (xenctx.dominfo.flags & XEN_DOMINF_hvm_guest) { struct hvm_hw_cpu cpuctx; xen_capabilities_info_t xen_caps = ""; if (xc_domain_hvm_getcontext_partial( @@ -1269,9 +1269,9 @@ int main(int argc, char **argv) exit(-1); } - ret = xc_domain_getinfo(xenctx.xc_handle, xenctx.domid, 1, &xenctx.dominfo); + ret = xc_domain_getinfo_single(xenctx.xc_handle, xenctx.domid, &xenctx.dominfo); if (ret < 0) { - perror("xc_domain_getinfo"); + perror("xc_domain_getinfo_single"); exit(-1); } -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue May 02 11:18:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 11:18:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528526.821805 (Exim 4.92) (envelope-from ) id 1pto0y-0005k8-EH; Tue, 02 May 2023 11:17:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528526.821805; Tue, 02 May 2023 11:17:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pto0y-0005k1-BY; Tue, 02 May 2023 11:17:48 +0000 Received: by outflank-mailman (input) for mailman id 528526; Tue, 02 May 2023 11:17:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pto0x-0005jv-1C for xen-devel@lists.xenproject.org; Tue, 02 May 2023 11:17:47 +0000 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [2a00:1450:4864:20::432]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f635e8cc-e8da-11ed-8611-37d641c3527e; Tue, 02 May 2023 13:17:45 +0200 (CEST) Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-3062d764455so1422740f8f.3 for ; Tue, 02 May 2023 04:17:45 -0700 (PDT) Received: from EMEAENGAAD19049. (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id i11-20020adfe48b000000b002c3f81c51b6sm30625977wrm.90.2023.05.02.04.17.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 04:17:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f635e8cc-e8da-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1683026264; x=1685618264; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=VomCUlaJl3m0YlBSN4OcT3ZcH66VA7ob9EV/O6KH2dU=; b=LzNHvFazYiCArmtJom+ikLLfmpgZUamKXE8Mx3YK6bgWFZYwgkujK4qWP6VCaiA81/ Y34bqw3bMIbxAgKEl6fiC9jtK5JurIeQiebK/e5MnX6LsFMR2zwJZXFnSfnmjo+NmpJE kCZHUfoiCc5baaKYibF+IiK0X6SCu1ovZ9H9c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683026264; x=1685618264; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VomCUlaJl3m0YlBSN4OcT3ZcH66VA7ob9EV/O6KH2dU=; b=lKvP6CLFXrjDhffoONiJCYpwkORLWiC5cGlec5zNjRrrWa3QjucNTZKnLaTwmNdSkV oD+UpD1mCGuM4ADstrYx5e0ipP9mtytPfip1YM6RWYaMjMuApsBjiiRSq4jy2FsNap7u OT4KUAU3rSKtTc3kEKBGwRCmv46g6S6aXqy2w6A+ur0XnSF0biIRqu6P3KYRKQ2obrAK x8istrXbX/bPblewME3p/BxXZlqfYZ+lRV2eu3R6YcuVLShY0ugGnFzYNAw6QHw5iZp5 NTA43eVn1nTGzn4GbvUs8xADPmESrn46MhKmX/G/kaovnNWJQ7mIDqCD1X3YRWNHXj5w 0HYQ== X-Gm-Message-State: AC+VfDxNMhcE7sXbtJGWZQLwxsFt3xYx8yDVp/T9PbEHbrmWDW8AFsz1 KlYTcFbahsztN4zgpaooKUeeA+SeUKD5KJHTG2o= X-Google-Smtp-Source: ACHHUZ5vjG7WZuFwcmvJG5zNM7aqMQvYRrPW4JI92sg348uThIygvQVzwJ6k7BuBteoso9YXjaM3VQ== X-Received: by 2002:a5d:67cf:0:b0:306:2bf4:4fe9 with SMTP id n15-20020a5d67cf000000b003062bf44fe9mr4679463wrw.55.1683026264035; Tue, 02 May 2023 04:17:44 -0700 (PDT) Message-ID: <6450f156.df0a0220.8ce3e.2dc6@mx.google.com> X-Google-Original-Message-ID: Date: Tue, 2 May 2023 12:17:40 +0100 From: Alejandro Vallejo To: Xen-devel Cc: Andrew Cooper , Wei Liu , Anthony PERARD , Juergen Gross , Christian Lindig Subject: Re: [PATCH v3 1/3] tools: Modify single-domid callers of xc_domain_getinfolist() References: <20230502111338.16757-1-alejandro.vallejo@cloud.com> <20230502111338.16757-2-alejandro.vallejo@cloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230502111338.16757-2-alejandro.vallejo@cloud.com> On Tue, May 02, 2023 at 12:13:36PM +0100, Alejandro Vallejo wrote: > xc_domain_getinfolist() internally relies on a sysctl that performs > a linear search for the domids. Many callers of xc_domain_getinfolist() > who require information about a precise domid are much better off calling > xc_domain_getinfo_single() instead, that will use the getdomaininfo domctl > instead and ensure the returned domid matches the requested one. The domtctl > will find the domid faster too, because that uses hashed lists. > > Signed-off-by: Alejandro Vallejo > --- > Cc: Andrew Cooper > Cc: Wei Liu > Cc: Anthony PERARD > Cc: Juergen Gross > Cc: Christian Lindig > > v3: > * Replaced single-domid xc_domain_getinfolist() call in ocaml stub with > xc_domain_getinfo_single() My mistake here. It's supposed to have a "R-by: Andrew Cooper" From xen-devel-bounces@lists.xenproject.org Tue May 02 11:18:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 11:18:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528529.821815 (Exim 4.92) (envelope-from ) id 1pto1f-0006FZ-Mn; Tue, 02 May 2023 11:18:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528529.821815; Tue, 02 May 2023 11:18:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pto1f-0006FQ-Jo; Tue, 02 May 2023 11:18:31 +0000 Received: by outflank-mailman (input) for mailman id 528529; Tue, 02 May 2023 11:18:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pto1e-0006FI-66 for xen-devel@lists.xenproject.org; Tue, 02 May 2023 11:18:30 +0000 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [2a00:1450:4864:20::331]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0ff17e9c-e8db-11ed-8611-37d641c3527e; Tue, 02 May 2023 13:18:28 +0200 (CEST) Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-3f1738d0d4cso21527345e9.1 for ; Tue, 02 May 2023 04:18:28 -0700 (PDT) Received: from EMEAENGAAD19049. (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id d3-20020a05600c3ac300b003f19b3d89e9sm28840853wms.33.2023.05.02.04.18.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 04:18:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0ff17e9c-e8db-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1683026307; x=1685618307; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=8+X+FRGE1DrLyhmqqDKnng02bF8UXtim7gerRdngijA=; b=YLNjwFlD4z/AZul9GNAlrTP92tKk96Jm+U48uA9AODsEIxRxKDmIwNZBViCAnBq7Lr O7BiylT+CDdvtc17hRxx+LxuCh6p9aPIkp/qi5bqfHnoS4rFQpi9Ua/Y4B2SZdryp2LI +psQj5pzWOy1XckQaxaQeRev1J9uF7E0VRy2U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683026307; x=1685618307; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8+X+FRGE1DrLyhmqqDKnng02bF8UXtim7gerRdngijA=; b=N1XRYzZqoIkrIrTHpyxV498jJ27zLJyKEkpWTQvPFJvn9vOAgBZDHp6hRaDLwJme94 t93hGfSoYE1Su4Q9SpjSyrzs7oxdJYowubQ0NOsOdlhXm8qcJ1kpWwyTMkDAR2r0szFg vzlB3kYRzIw/JASI4If3d2DHTMP703keWt9B2GsqUoDJmmKk8KxAGFPgyRg5CiW+owv7 yQdI1aL9a/qXWP0RW4yrC2FInbu9QtMYDivkdpqA228MlxxsoDTjnC7PUWjDCJR06ptO 8dMNO4VEUVGqh7YCh2aaikWZoMNFhF5EXTc4XykB99N+gJpPGS1PdlsYg8p4rar0TY/2 EYBg== X-Gm-Message-State: AC+VfDwAqjB4JYnHTvrtCEE9faOSSG7rUh4S5Ns9kpJXmBD5QE+yvrrk izgblw5WE8cXEe5MM1sGhZdrDOY8e/UikdYHoGg= X-Google-Smtp-Source: ACHHUZ7acyPlN8Pg1jZo9IQ6xwFsYu3r965ZVnMjr4/dd1OxIWSeWCn5jKnCNLq0722TvA15V/RZxA== X-Received: by 2002:a7b:c407:0:b0:3f3:481a:902e with SMTP id k7-20020a7bc407000000b003f3481a902emr823096wmi.15.1683026307281; Tue, 02 May 2023 04:18:27 -0700 (PDT) Message-ID: <6450f182.050a0220.6009b.3ca5@mx.google.com> X-Google-Original-Message-ID: Date: Tue, 2 May 2023 12:18:23 +0100 From: Alejandro Vallejo To: Xen-devel Cc: Andrew Cooper , Wei Liu , Anthony PERARD , Tim Deegan , George Dunlap , Juergen Gross Subject: Re: [PATCH v3 2/3] tools: Use new xc function for some xc_domain_getinfo() calls References: <20230502111338.16757-1-alejandro.vallejo@cloud.com> <20230502111338.16757-3-alejandro.vallejo@cloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230502111338.16757-3-alejandro.vallejo@cloud.com> On Tue, May 02, 2023 at 12:13:37PM +0100, Alejandro Vallejo wrote: > Move calls that require a information about a single precisely identified > domain to the new xc_domain_getinfo_single(). > > Signed-off-by: Alejandro Vallejo > Reviewed-by: Andrew Cooper > > --- > Cc: Andrew Cooper > Cc: Wei Liu > Cc: Anthony PERARD > Cc: Tim Deegan > Cc: George Dunlap > Cc: Juergen Gross > > v3: > * Stylistic changes that fell under the cracks on v2 > * Reinserted -errno convention from v1 that had been > removed in v2 Mistake here. It's _NOT_ supposed to have that "Reviewed-by" From xen-devel-bounces@lists.xenproject.org Tue May 02 11:19:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 11:19:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528533.821824 (Exim 4.92) (envelope-from ) id 1pto2i-0006tT-0F; Tue, 02 May 2023 11:19:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528533.821824; Tue, 02 May 2023 11:19:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pto2h-0006tM-To; Tue, 02 May 2023 11:19:35 +0000 Received: by outflank-mailman (input) for mailman id 528533; Tue, 02 May 2023 11:19:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pto2g-0006tC-2p for xen-devel@lists.xenproject.org; Tue, 02 May 2023 11:19:34 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2060b.outbound.protection.outlook.com [2a01:111:f400:7e1a::60b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3659de89-e8db-11ed-b225-6b7b168915f2; Tue, 02 May 2023 13:19:33 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB8059.eurprd04.prod.outlook.com (2603:10a6:10:1e9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 11:19:31 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6340.030; Tue, 2 May 2023 11:19:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3659de89-e8db-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jID5z2WgZrRDtW+1/yKgjHYLFz2ny9PK9aPg2Kt08wXviM4LEfKr/zRfx0wNgIcj8vKAZqsCaZxt5RoWUI5YL7mTnlZLEX+rva9S0UPWVrb/3Ean5vPCNsHqTxsYzEEaD5WWqZO/sejzO0+IvSgKc+xJnUsniVT2OL5knp8QHVWYcOh8bG5rgteOlCpAWct6xetvWpT2dWpiT3zoNCH+r/jARA3EGQuiJDGOXOi2OWL6s7gJYS3CiRllIBgGbBZIrhxsIlGLu1sFHJ28H7sie/vVbSmobEzBh84iNnyfLPq9hcERJRq5E7KHKbSP6i1s169EAKEyVNQi/2duO9kWfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dqbuaeoXW+5rsCtxwnigwiHezoJP/GDY0KCe4Lwn3+U=; b=bkzry4NfrkR7rO4I3Fj5vuBUw2OKeBvjf3yPhipQtFicznNQ2SWHuwvj7W/+ImA7VZDXbJpJmYHygCFkezNkyk+XfW/z9yZzbjXTYOAc3+/ZfDU4h0DGaIGyfmpa00tudyhOHKhqBgKXhN2UStx921f+SiElAyFD118cdPudfQMEU+8UAs/kWmaUD6SFc5bcJc7NTfD/dlDCp2amPwZ4p5mckori7tmCj4JnVVpSuUQocQcCV2GknZPLCaZMU1FXOEKbXUm2U1r9/7+ymZTArOHbDcCyI80nOzm+pvL1S+fTs8phddpfXrhbtaajdRbGvpTQXkCkZphxpqEP6UuGTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dqbuaeoXW+5rsCtxwnigwiHezoJP/GDY0KCe4Lwn3+U=; b=AlyBTDydX9F3w8Qoz0dXWsSJEmS84f/RtjZUnYZ7VotYpKg/ebrufffMQ6BTckau69QVWipukZhnuwRHlX6WMMUFox6JNrhRfmtGlVRxsrJ2UP9fkhWQqCGrrT3OMS2qXmnSB/v0tjgIID2jn3Sfo3FlTb0PT4IM2lbRmVSilNagrDtbJVFDuTFRZ0O/P/C1HplhWt/z/1QwSgP58DOb3EW1PVB6NyLqDyKnfoQj5ymrK9j54d3sGgXXj5sPoSPVwQTsyg9e1ri1c6ZIYf/2Lks3T9OWA3quNT/apEluj08JjPVoGmgK/nuflG79LkNBIO3Q8v15oPa1ZEaE6CKW9g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 2 May 2023 13:19:32 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH RFC] SUPPORT.md: Make all security support explicit Content-Language: en-US To: George Dunlap Cc: Wei Liu , Andrew Cooper , Roger Pau Monne , Stefano Stabellini , Julien Grall , xen-devel@lists.xenproject.org References: <20230428081231.2464275-1-george.dunlap@cloud.com> From: Jan Beulich In-Reply-To: <20230428081231.2464275-1-george.dunlap@cloud.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0077.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB8059:EE_ X-MS-Office365-Filtering-Correlation-Id: 49b311c6-ddd0-4f5c-7845-08db4aff19b0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8OPGBh78YVedYFLA78k5cbmGYko1lrNg1ewCqx+lq4fjSfbxfscm9R5eKRpmjLo8et6XcEnveif18bM3qdXT1dOnWhi6RDdjcXdBfmk/6JP1+fqDsJXCd6bLbUBDoYLuKEM8bHmc3VNh4IcuvONh83kjxf9DCnb94fG+OtL0Or+vaS/u4rJ9eA93TAbIPY9ttMd3Ssvifg5xUVel2RO01158ygQicP3v+Op4iO0VwEp2nmyrFRFkaeLxXZUuymAGrftN2weN1u7344jgk5Yhj2FsM2joJWobgHNc6D1Ru7HR38DOt9rD9mfvK4Zuy3iFgJjdj5g5ZDWEp0CD3ZDBKo8i8RnTNJ6T7LWab7V4KjTzTu8/Uk7l6saHuhWFIIRXYayWtC6PciA4F+50uiAvT0w6PaVrpAq9mGGiKG/Fww6cx+m4E9h1WSYe9734XcyNrfOWHrRFoaGR4U8bukivfPhR2TWLk+BXmsm7JrmY2YCNez/uKzO9J+69RaH/OUT6XTynEbCbxQto+V21ATIFsSHgTrA9mHp+x4d+DrQJ8FZnzlL0qylJCZZvKofq2AWrfGJ2x834/x/N1oxvIwn6ALc4hSy+ND0dVH+licLPFRqnUM3Flc+BU079/MBSa6WPTmsgQdUXG10Q6Ibq44yIwg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(366004)(346002)(396003)(376002)(39860400002)(451199021)(478600001)(26005)(6506007)(6512007)(53546011)(86362001)(31696002)(6486002)(83380400001)(54906003)(186003)(2616005)(31686004)(36756003)(66946007)(66556008)(66476007)(2906002)(316002)(6916009)(4326008)(38100700002)(8936002)(8676002)(5660300002)(166002)(15650500001)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VG1XVEczYjdGOU5zT1hOTDZSS05BMU5ReU50Y2YvdXREL2g4KzJya2VGMmJL?= =?utf-8?B?WWlzNHhxK3ROMUZzNVVPdjIvWUhvNW82NTRkQmFrRytuRllTREt5bzB1QnBh?= =?utf-8?B?bVo5cS9rNlgxL09mQyt0dFhVMGdSUUdKMndZR2oyam5JbjVhdllMMTRoRS81?= =?utf-8?B?cUs3Y3hCZ1VndWMxSTU2ajdCSklaY1lZSmNDWG8vNnFBQUlXOFErNWErc2o5?= =?utf-8?B?NTVvZnBUaFhPZXNsWlB4aGtScEFMbEpkcGV3QTFnZndsSy95SGhFQXM4Ujk0?= =?utf-8?B?MzhXT3hXWlh1QW9FSkVtVGQ1R3FDWEI4bHlZeXo1VWNyWUhKaElFdTk5UE1h?= =?utf-8?B?NVhJK1pEbWVHeCtJQWE1cVd1UXdEaHczSTRPUnN4UkpPWHgzYzBmN0JMclkx?= =?utf-8?B?ZERvTWM2NllSU0FqWlpHeWFBOUIwTTNOcjBnenlwZ3UrdExuQkxiT29FU1NK?= =?utf-8?B?d2R4dVNnTlowVmZQd1RaYk5RMjk4MDdzMkJKVkx4a2ppNWJUd3hiRFB0VTF4?= =?utf-8?B?R0pCTEgyQUpQK1pvak5PVnhHWWN5TTV2M3prdkx6OC9nUEZFQUpEME8rR3k0?= =?utf-8?B?MHlkT3NveithRUNPZWhkS1JpZk1YOFNOa2wvaXRadkZ3ZEhpQ1l5YlhKUG13?= =?utf-8?B?K0d5Qy96SGZFb1NvV1pranU0TExHWTNHRFV2MisvZ0o3eUttZ0pkQS9GSGIy?= =?utf-8?B?aXpPZnVUYU1EY2J1dE81ckdXeVRiZ001Rmo3OExDMHQ3aVdGczBLNTh4S3VQ?= =?utf-8?B?cGwvZXZucjI1UFNhSVdRaStYRDBnUTkraUFMVTJPbGMzc3lZZ3dwOW45OXZV?= =?utf-8?B?TmJzSzkzSEpWTUJVS3krWTJid2d5SDFsdFZxaFlRNTRvNzA0N0F4cGZlaXVV?= =?utf-8?B?bzkzZnQyRXhXalcrR01ZM1dJckhqNUJNcXcyZnMzTU5YbFNWT1dLa0JFNFlt?= =?utf-8?B?NXdTKzk5TWdhbWRXZ3RleVFqbWFqN0lmbmJSMmlMbnBVdFFLNDlWS3NvSGoy?= =?utf-8?B?Um9aUE16RGtCN1dHbTlmdG5sa09XbnZOL2ovWGdPQnRGL0hlS0VieTRpWGxa?= =?utf-8?B?TUVEbElLSHMzc3I1MHorSm5ENWxoZVF6WVN4bHlZckxyNk1WVHVwN2RtSXMy?= =?utf-8?B?Tks0SWo3UjU1OXZjcWE2YnZuTjYxQ2M2blBwbjhJdkNTQk9ZNW9iaVZKVTI1?= =?utf-8?B?cWYvZlZaSGFnd3puOCtYQWk3T0dNdG9mejFudlBpTHJIWVh5QXhLdjBtYU5y?= =?utf-8?B?anVYOVhLeS9PME93ek9QcHprTDFDWDNvTjFVSFdiK3lEZ0JDQVVEUnRJRTd1?= =?utf-8?B?bFM0SHhJZ3FvQ213MUI3SWEwSHgyNllVdnFBRXBLa3pyd0Nud1BKeHR5Wkt2?= =?utf-8?B?R1BXd1JZS2ZYNjR2U0lTWkFKN01iRlBOKzk4eFBVbHdTdzlTSytLemJuMGl1?= =?utf-8?B?R3ZmSUF0cHY2bTVqR2lNT2dpU2FVbk5OVWdJK1V1dFFHaHE0TDJ5dGdHd2Ro?= =?utf-8?B?VW51dzc4dnJrT2tHSGFqK3dPaVNoaDNNaVdNSzAza05LcUNuN1hDekJ1ZWVM?= =?utf-8?B?S3phZGNKWkZhQmc0Q3UxNU5aaTg1bklrMzNFYjF5TTM5YlZXV3lBYUFZYVZw?= =?utf-8?B?L3RFZU8zc0ZKbXlHY2NqRm51TVg0eE0yTDNJaWN5YmgzZnZnellFV04yRlJK?= =?utf-8?B?ZkdQNzNOYThlMlhuTlhGTlIycnVJdVhSU2M3QnpwejhXMFNQVkI2M0h3eXVO?= =?utf-8?B?TExFcFJlZnNHNktNU0RnbEkvOG5zekhOaEJVQWxKNlFzejdqSkpYZTZEZkxu?= =?utf-8?B?dThnTENMVVRhWUp1Z2FpZVpuRnVCOFdNQjkxNnRPd0dBQ0VXbXdEeTJBUEJ1?= =?utf-8?B?cDNnRTVrdDFmNFlER1RubUNVeG43NTBqWHlXajd5R2NZdVJwbHJCM1BENlRm?= =?utf-8?B?UTg1L2hKZUNaUWdqbmRBUWlGbzkyVGpEY1o5ZEZFeEpmU0poc2Q3d1hQUXdl?= =?utf-8?B?cUdSc3ZiMFNPd0V2a29vUFBsQzU4Wi8va3phUkd6RVdUZ0E1RlBqZjRwYWtD?= =?utf-8?B?cXNabGNtOXd0bEl4U2g4NnIyN3hlbW9SQjBtNkFQM1BLTnlPMWY5RzJvQlc4?= =?utf-8?Q?k23PPNjTdFFL+TBWmvUsIAIXF?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49b311c6-ddd0-4f5c-7845-08db4aff19b0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 11:19:31.2615 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jEwhyosF+CcD3YKWI3wdlqqOcscKeRzRiALSCbhl+RuVB3kNEzFQGLh7Cgc5jKwRS4U4AiVPFAkRCAyCLKAhMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB8059 On 28.04.2023 10:12, George Dunlap wrote: > --- a/SUPPORT.md > +++ b/SUPPORT.md > @@ -17,6 +17,36 @@ for the definitions of the support status levels etc. > Release Notes > : RN > > +# General security support > + > +An XSA will always be issued for security-related bugs which are > +present in a "plain vanilla" configuration. A "plain vanilla" > +configuration is defined as follows: > + > +* The Xen hypervisor is built from a tagged release of Xen, or a > + commit which was on the tip of one of the supported stable branches. > + > +* The Xen hypervisor was built with the default config for the platform > + > +* No Xen command-line parameters were specified > + > +* No parameters for Xen-related drivers in the Linux kernel were specified > + > +* No modifications were made to the default xl.conf > + > +* xl.cfg files use only core functionality > + > +* Alternate toolstacks only activate functionality activated by the > + core functionality of xl.cfg files. > + > +Any system outside this configuration will only be considered security > +supported if the functionality is explicitly listed as supported in > +this document. > + > +If a security-related bug exits only in a configuration listed as not > +security supported, the security team will generally not issue an XSA; > +the bug will simply be handled in public. In this last paragraph, did you perhaps mean "not listed as security supported"? Otherwise we wouldn't improve our situation, unless I'm misunderstanding and word order doesn't matter here in English. In which case some unambiguous wording would need to be found. Jan From xen-devel-bounces@lists.xenproject.org Tue May 02 11:28:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 11:28:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528536.821835 (Exim 4.92) (envelope-from ) id 1ptoAk-0008Qe-Ph; Tue, 02 May 2023 11:27:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528536.821835; Tue, 02 May 2023 11:27:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptoAk-0008QX-N5; Tue, 02 May 2023 11:27:54 +0000 Received: by outflank-mailman (input) for mailman id 528536; Tue, 02 May 2023 11:27:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptoAi-0008QR-Nk for xen-devel@lists.xenproject.org; Tue, 02 May 2023 11:27:52 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20628.outbound.protection.outlook.com [2a01:111:f400:fe12::628]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5dd3c46a-e8dc-11ed-8611-37d641c3527e; Tue, 02 May 2023 13:27:48 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB6807.eurprd04.prod.outlook.com (2603:10a6:20b:104::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.27; Tue, 2 May 2023 11:27:46 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6340.030; Tue, 2 May 2023 11:27:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5dd3c46a-e8dc-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f4BbJ2WtFMlwH/xIgqBUosHoNGpHeN4SOvdzvm+y1aqyNI1svP2fkQMVP+ciD9y/MUuADR4cRgTQCzafMKGeAHjWMnAjlKtClFB41q5hpOwQEsVfL89zLFb48IGnHiAlU9Sa+csrGCTho1/vug2JY1GI0BUUzcP1eku0tHHEdSEiTpHcrI6oBLO80zeHCve8r4bR5PMRrYgyzzhBe83iAo7gGMJE+nXDujcvNaMvzj6PIRInR5GsjjervXSJFes1776p+FYz03ZdVO0/SX7/QVkPdHeiqKo5oCs799b9R/AHuUh/YchqNj9igKuyQXvwFWvLNla0XhEp26o5ZAeHpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dB9bahqQeSO9ULtaIOJCrZaIgtCz4kfEoGdjEEz10DY=; b=KJb1NTkiWAfURYKljwQO68ZOOLqd49eSDsjp9w3/WXAW8k6B1hf74xacLa24VO5mHM3oWZfNNukTlFcRFGUFmtGQTWPLRWc9RzFNex0zvI6VBqdz+NOS3GRORsMeNZVNE1iM6rQf2Aaks/5pHPy7xEGTNGLuRc1YIYKpp4LOr3YUqA3l/gJvNd1fGCmYklZEXLvv5IB0sXpVp6Dwz3+u4IuNwWrlUtFF7/VDbiUEkYnJHWnYTc6JUAdx/xUxW7fO0uwKY7eYAkF3jUOGyaTR+63+vRw7RgVxQ/F2tbUay5tJ/eGwxc1LeBLINS3uZ3nz1XGHkEIOuyYSMC5FUwGAVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dB9bahqQeSO9ULtaIOJCrZaIgtCz4kfEoGdjEEz10DY=; b=Ywgki5ZhGPL4/Jowj+sKehesK0CYRq+EjpOAgpyeuqW7uQKUtiZOmeuyEVecAOCiOPujEM1GQOhtBafO+Xc5jf/f3anVAGaCBXo8R66umTCUblME5bXYaqiF4EOfABQumzhSeM2USnUzS3THtz+OX5AzhLQAVQro/XMtRt9qDnr9vB30YdW/yGkeMC2KSZviXamFdvhkklJaxmiluwFX2g1QFSblpVlMF2+PDeCobOURAPBgSgtaQgl4eJcof4nTll+1836MskNjMuY3IiRQoPMITtXGTvEum3DR0oxQxl5Z2ekJzDihIitLhNWpzpyClswIFuleSf7GMEH120C5vg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3485b49a-08ad-157e-f47e-1a6826339cfa@suse.com> Date: Tue, 2 May 2023 13:27:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH RFC] SUPPORT.md: Make all security support explicit Content-Language: en-US To: George Dunlap Cc: Wei Liu , Andrew Cooper , Roger Pau Monne , Stefano Stabellini , Julien Grall , xen-devel@lists.xenproject.org References: <20230428081231.2464275-1-george.dunlap@cloud.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0109.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB6807:EE_ X-MS-Office365-Filtering-Correlation-Id: 882adbc0-b881-4fea-9b6a-08db4b004084 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZR6Yx1YAg7XrqPIEDOb8l4oag5brQp8Ee+49AJe6gO9X4D9XsR8+f/aNAECHWUOzlq5D3/h3az7BKSgahJEkTmF7jCZiExvofAOHoUpaTccp1TH/IfPhpuNzd7ZIGMWwXBJRGFNf4WWZRm5t0i5rWz8l/o7zwcl4utoYxSkG5Jk3YirVe144jiT5m9+F2GT6ky2sscI58EfxqwaVTwsHAI6ze4W0+8ait7qkKHPsI/cmZ3+jXCfSeVLGbMzS3h3elnG1fQff1D/dszALEqg0WHc8u0AiOf/+Z2HenNS8RPlTCHPuhgoUyx3CAK9LVD2vU48wIicGP1LRCs1f46Majsil1RimXUd6+4BPlbeVM4Vi2KQfZ7QJgah6eGHyJgky8f+oW/Xgep49XNuTlzTU1MOk+N7+n6K8JuYLNDoYs0lcqTvgoyTiHlQ1vgc+Ahniomrtr1Ue0LJOa3PEbuxkMt8+bIcC9Z9iK3QpqKpKF4YAVxOGoq3tvQYCsqezHeFTlWvuZ4fw0yUGeDbEUHbO5SkWSXWwa1vFGqDVtkJ+yPYfUGZGJHE2OnONV/l6Cib8Ol4TF1+vC574jfBDizZ/GqcpvmNJVX88Xh5rTc94qzGH64hE0yrfjaOB/CS9H4tW1xhLNVHwZ7xoh8WdgWTBHw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(136003)(346002)(39850400004)(396003)(376002)(451199021)(2616005)(83380400001)(478600001)(31686004)(186003)(54906003)(4326008)(6916009)(66476007)(66556008)(66946007)(53546011)(6486002)(6512007)(6506007)(26005)(316002)(8936002)(8676002)(5660300002)(41300700001)(2906002)(15650500001)(38100700002)(86362001)(31696002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QVU1Q1NZMHVidWFqR1lnWHJRN2NDcjlmaHIxS0xOYTVNeDZQcGRvdDBBSXJp?= =?utf-8?B?Ujd4b1VOTllNRktTZC9XT0ZQbHVvSXd2aDRlN2FkU1U4azVUMk1DVFN1VUJs?= =?utf-8?B?cGZwd2lYSTZ0U0ZTNCtnV3YveVlyQkZWYS83dFl5ZmNqSktWRmxId3NDYURs?= =?utf-8?B?U0tPUmNsUWl2NXNnZ2QzZnpvazVXQ2hyekNyeXlSSmt2eWVRV3VBeHB2S011?= =?utf-8?B?RVdxMEMza0JJUmkzSmVHZmlXZ0pZWDdwd01ST0Y3d1dUVkUwNjJoOEQ2SjRS?= =?utf-8?B?R3hLbWI2MEpaVm1mYi9FQ0Flb3JPWEkrWmJ2Y0lWUjc5eDM2Sm12Z1BlU3hu?= =?utf-8?B?V05sOFZvejVvTUxVbWJ5eWluUEFCdmJpTERCUDFoakYyaGEvaSt1Y2E5SlBV?= =?utf-8?B?MktLMS80Sm0wV0NTZTVzck9tOU4wdW1vUWZGdHlDWWRKVVVON3VOd1NCRXgx?= =?utf-8?B?V2c1Q1ZySjdRR3FQcGk4YlQ3WldUc0JjL0VmenZhVFNYTFFFT09OMFFmV1dU?= =?utf-8?B?NFJNZnpFU29mMmFmSnIrNWo3aWNRTUN2aHAxZ0VNbE1Zak9oemkyZkh1WnNP?= =?utf-8?B?UHFzY3VtdGFJNUtpYnJPNk1qR2VUTWNFMFNyWGR6ZFkvQzAzWWU1WE5XSC8r?= =?utf-8?B?V2kzbzhyY0hGK2xuVEkrYXNxSjRDZnU3c1VTRlVtK2ZHeGFWZU9udkdxZ1lw?= =?utf-8?B?WFE4aWVoQlQ3TEJKNEQxS1luWXp1b1RUb0UzTzJ4RDdJYWJoaGZhVENTeGdT?= =?utf-8?B?eEtLZjdKZUhqV01OSGtNRHVCakk1NmpFdnQ2cHlHSHRoUUo5RS9MSEVZc3BO?= =?utf-8?B?WUhDTmdHYjZmL3FjMksrUUgwR1Z1bW50Y2M5bkJxS2RhOHJwUzJxTllYUE1s?= =?utf-8?B?SVdlNjZjSTNhRjQ0Vk55cEVVbW5mMVloMkhBcUZWb2VmaHJucEtyK2dBeFp5?= =?utf-8?B?b0sybEJDOVlFWW5KakprV2ZkYndsb25pakJhMzRjWWdCa2hZb2ttbFVQUGNv?= =?utf-8?B?SnVNUDhNOUp6c2ZDeUtrS0p3bEprajRLTDdIY1E1c3RlaERFemtZMXBpUy9H?= =?utf-8?B?K2ZwUEIwU0VDQVFTMnROZk1waXFvdzNwb2tyQjllWjNTQVZ1SEFCdmFHbmV4?= =?utf-8?B?NGE0cjV1OGZDMVRibTJRZXl5TU9EQkNFb1A2RllFMHlud0FLNCtFM3Y0dTJj?= =?utf-8?B?NFJrcnhseFhENThuTnFNZTlQM3VsNERNaFJXVmFEcTJaeDh6K3dHYW5RVGI4?= =?utf-8?B?REpqNWsxSmNuYTJ0Vjh4eG9ZcGJnY05UWTRFT0pSY1lJOWZ0MC9neCt6ZUpK?= =?utf-8?B?aUdZOGRRQy9UbG80Wm9kdU14ekUvL2dXbFVNUHZrbGNQSWwyMUJjbmZWQzd2?= =?utf-8?B?eExmK0ZOT1l0YlNDbThORXB6MzFKZ0tTQlJvL2RlYXd6aEluTGJTTzNyWkJv?= =?utf-8?B?NlpRc1ROdFJ4S0p0NjdSN2lXcnRQc0trRnNiSjlmNVdvcnQ1dTRUSVM4anpl?= =?utf-8?B?Zjd4eVNPSkZyaU8vcVFNS00wUmV1UjliUmQrSXN5WkxjWmoxalZKem5Ia2V4?= =?utf-8?B?NHFoQzdRU1BvN2hqODFoOTVSdEpkTmZZRlgwbzd3VnZ6dnQ1K05EczNJOEVK?= =?utf-8?B?Q2M3Nm9pMmpJTFJqUmh0REZmbDJOc1RXR2JMSWFKSThlem5UeE0yL0ljRTUv?= =?utf-8?B?N1NvYTdBbmduZmxwVjBtU0FNYjVqdm1rS2E5NEhEZ3JMdW1ld0x6VVRVelRj?= =?utf-8?B?U1BJenVGMHc4cXhQUkk3dlBydmt1a1ZVUjNDTzlGMEtiODYzOGpMWUVMUHA2?= =?utf-8?B?MDF4RHN6ZHFyQlptNHJucHBwbjJ1NnRYZjVnK3VzWCtQMVlFU1VERG1XNEcx?= =?utf-8?B?cTBNdDdqMDFrbmJuTW0wTGlyc1JPTU5JMzFsbDNtbUhyNnRZY0pXUlpNUWVj?= =?utf-8?B?aDlnYytvUzVDRFdja1BHbnUvNEk3KzdObjQ5cUdmUmgvS3hJcUtkSWFKOTkx?= =?utf-8?B?eG9iNFZjR0pzVkhMcFRBcjZmS3N2RjJjeUNFRGR5UVNQUjhGLzh0QVR4VHNw?= =?utf-8?B?UDdOWlo2OE9XQnkrQkl3a2VHNEcxYUYyU2RldGJvSURGQ0lVZEpPeFg4M3dO?= =?utf-8?Q?xhvXEgi1ATgcd6sG0CstCjqBD?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 882adbc0-b881-4fea-9b6a-08db4b004084 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 11:27:45.9082 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UM2yYJ7gwFaho+fziHmSjd44KeljhOHh4D5OWU1Ko3K/ytlDkZ6Of5lpTk9dZuOvc8UU30Scku8GAEx5D1t0FA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6807 On 28.04.2023 10:14, George Dunlap wrote: > On Fri, Apr 28, 2023 at 9:12 AM George Dunlap wrote: > It occurred to me that in many (most? all?) cases it would be more > effective to define the security support parameters in the > documentation itself. I think I agree; the alternative of needing to look in two places (one telling the syntax, the other telling whether it's "legitimate" to use) would be prone to people omitting the 2nd step. And this isn't going to be meaningfully more work right now: Any option we don't mean to security-support won't need annotating, i.e. like in SUPPORT.md absence of an explicit statement would mean "not supported". While in the examples you list only command line options, I guess the same could apply to xl.cfg / xl.conf ones? Albeit I notice xl.cfg.5.pod.in in its title specifically says "syntax" right now, which then may want changing. For Kconfig items it's not as clear, because I wouldn't consider the various Kconfig files "documentation", yet I guess we shouldn't require people to look at source code. Jan From xen-devel-bounces@lists.xenproject.org Tue May 02 11:33:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 11:33:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528543.821845 (Exim 4.92) (envelope-from ) id 1ptoG4-0001Yx-J7; Tue, 02 May 2023 11:33:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528543.821845; Tue, 02 May 2023 11:33:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptoG4-0001Yq-Ft; Tue, 02 May 2023 11:33:24 +0000 Received: by outflank-mailman (input) for mailman id 528543; Tue, 02 May 2023 11:33:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptoG3-0001Yk-Oe for xen-devel@lists.xenproject.org; Tue, 02 May 2023 11:33:23 +0000 Received: from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de [81.169.146.163]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 249ce61b-e8dd-11ed-b225-6b7b168915f2; Tue, 02 May 2023 13:33:22 +0200 (CEST) Received: from sender by smtp.strato.de (RZmta 49.4.0 AUTH) with ESMTPSA id x6987cz42BXLcdY (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Tue, 2 May 2023 13:33:21 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 249ce61b-e8dd-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1683027201; cv=none; d=strato.com; s=strato-dkim-0002; b=OPmksB21DJ/AM3xaWUaFAcKcHc64BbFMB73v/u4wOT3i927uccuD9SukXRIZvaQhID DJEq8Q66LYnXBFZ9r1KW/TDnUYcfLUKIjYIIlqGsbIT86770hv04loBQq1ZMDv0H0aVI 5A3a8fXXz7Woegs3KdX7AYOA4SFOHj7Nuxc2lbFx15slcIAbUH5B049KWqp7UKlu2xai Ih4L6i1gKMPj1EzieMpX9aTZPdr13TiAbYdwFVfiloAtUmN+TLeUulzkBZDJXH1bTIjA jQ0bVi96oHHncNlTQF+6h4f3YSR1HbRlHMpsvbcSCD9EcMUIOKI3qZf0hRP73eX5nvxP gqZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1683027201; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=a3cApHRkIUuCYLUFapSTvXuSRmye/cuLETd9DiG0noI=; b=ISXeZjZgIr3V0NLFvqCUV1BhAzOmu8OcsmRZBL0rKjuQGIx/TX5eOgxcaxHOsm4w2R VKwN5HyFRAGoF+VrdVj/yJMcVYyZCG+MCfpi0RD7QtdQmEPyvZgiZT15j7i7vb2ddZTT UFm4u5Kprraq/L/xOPQm8UOyd3n6LhQYHsB8ae/VUUaB2dj0Khjqw19vKjiLpoPgGQCB R9lf1hhVkzZxNUi1xVX6FNada8gSJzZaty9RNQ7oD1txhhmeCqjvZxjIpcyLUoMABH+i oYxM1MPx3iq6zu2ExwVJC4Yb5bpMFFA3aBuT6GczBiv/mpIheDookkb7Jso7M12eHJCC oFcA== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1683027201; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=a3cApHRkIUuCYLUFapSTvXuSRmye/cuLETd9DiG0noI=; b=jGjW0GErGZEy4WbQqHVMLYT0A9O7hTsDS/qPrMyOBIZW2JH4rOkTvn+swnfYZq7LX8 lxSSS00N/2pYm10CDYjR5XQrrUQE964BirJjdwH9nKodnqZZr4msGJ/YrngdlBWtQNZ7 TGFUW6NaoEB470r8V0QpxBkQk4nCD6Qi+IRRmsNVsVavjz/EwndzuZnR442NMgnqBQnr nMAF7umO1+8CMIIFu8nO4xMPtiY/kyVczKAzFIkqBpcnQ6a1lDBpiVidPEiijuJjJdZk MgWt9DnC7EOT5Cw1zVDwYIaXnMVL8JIBIvytpCDUl5O/FDcsYYCGvO8QK4rcZtujmPu9 ++Dg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1683027201; s=strato-dkim-0003; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=a3cApHRkIUuCYLUFapSTvXuSRmye/cuLETd9DiG0noI=; b=Fc8fDeCGR/88HxagNILvsBGC25hJpHyM34J7f+xg5BbWjHbo0PyYaWEW/5FFYqTdCO g6wq6q52WXuaTUWbZ3DQ== X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisR5BxOIbBnsc1fym1gFvNQ7EzMpH+yFJc4aADp/8Q==" Date: Tue, 2 May 2023 13:33:13 +0200 From: Olaf Hering To: Jan Beulich Cc: xen-devel@lists.xenproject.org Subject: Re: HAS_CC_CET_IBT misdetected Message-ID: <20230502133313.2192eb99.olaf@aepfle.de> In-Reply-To: <43b1c214-4248-a735-6f8c-9e08bdd2eaf6@suse.com> References: <20230502074853.7cd10ee3.olaf@aepfle.de> <43b1c214-4248-a735-6f8c-9e08bdd2eaf6@suse.com> X-Mailer: Claws Mail 20220819T065813.516423bc hat ein Softwareproblem, kann man nichts machen. MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/ZQhO5xssfOKW5Bk_p7R4m3I"; protocol="application/pgp-signature"; micalg=pgp-sha256 Content-Transfer-Encoding: 7bit --Sig_/ZQhO5xssfOKW5Bk_p7R4m3I Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Tue, 2 May 2023 09:31:56 +0200 Jan Beulich : > How does 2.37 vs 2.39 matter? CET-IBT support is present in gas as of 2.2= 9. I have no idea. It turned out, the previous Leap image was based on 15.3, w= hile the current one will be 15.4. If I run this manually, it appears the error is produced properly: gcc -Wall -fcf-protection=3Dbranch -mmanual-endbr -mindirect-branch=3Dthunk= -extern -c -x assembler -o /dev/null - ; echo $? gcc: error: unrecognized command line option =E2=80=98-fcf-protection=3Dbra= nch=E2=80=99; did you mean =E2=80=98-fno-protect-parens=E2=80=99? gcc: error: unrecognized command line option =E2=80=98-mmanual-endbr=E2=80= =99 1 An for some reason there is no failure with the refreshed image on gitlab: https://gitlab.com/xen-project/xen/-/jobs/4210269545/artifacts/external_fil= e/build.log I will investigate why it failed to build for me. Olaf --Sig_/ZQhO5xssfOKW5Bk_p7R4m3I Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmRQ9PkACgkQ86SN7mm1 DoC9CA//aPfzO636VAjq1LQFiCVnWwcsTYs0KQwbwG9x31em7JznVL0gCwMfHYAW ICNLXqRWD1h9g8/Yd8O9BquHMJkvW2GUyPDfEP815c8mnUiGoVBMAv+C4oWUNDAS rpmZYgj4a6qvKDzCEienxUgTyYSamcNGg4sBY7jHuXnb8rSdDVlEE4hVQI2cQZFa 707tI0DQAGct+DbinX7VAO7feLRHm9vYEs9tDC/iaxrbqlcKSDJ/Nam60vSBma0M esw8xw5+WoXbFCTQ2KVKcL3dfxaDG7vkN6QrCUD26SoDe1wA/a6bVMQ/nauidTZd QQ/raf5KI65Nt1cSf8Cq7GZ34twmHXt76TRM2HQwPM4kFb7Agj0n1tdGPNxWJnkA ioOTo7GBWsAwm47UKb/XGU83rFuwHHDVQNQegmMBG8w/M6WSaOSWqiy6M577FnLd QoeQWoTgCsbwAI83UaYglllxYZBqNiflQI7YxFEOAm7hVkIDEU3fV6skVVgIeMHb Rjtvx/WiLuARltBrfP2Wewr6qrPsJTI6bNlNoztPnxri50D/TcQUVbVTztQ4cseP T9wFQ6+tzejC1C2C0joBdn8MsiW5O29cnqcMMDJ4EJLR/3OP6yUxhxAjQjvSr9Aq JLH1x532mVooANRhpcSpG0kqwLW1Jz1o/2MuuB+nRSjvQ0P+IU0= =IsJ1 -----END PGP SIGNATURE----- --Sig_/ZQhO5xssfOKW5Bk_p7R4m3I-- From xen-devel-bounces@lists.xenproject.org Tue May 02 11:54:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 11:54:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528547.821855 (Exim 4.92) (envelope-from ) id 1ptoaV-00047n-4v; Tue, 02 May 2023 11:54:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528547.821855; Tue, 02 May 2023 11:54:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptoaV-00047g-1p; Tue, 02 May 2023 11:54:31 +0000 Received: by outflank-mailman (input) for mailman id 528547; Tue, 02 May 2023 11:54:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptoaT-00047a-Qw for xen-devel@lists.xenproject.org; Tue, 02 May 2023 11:54:29 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2064.outbound.protection.outlook.com [40.107.247.64]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 16d09ade-e8e0-11ed-8611-37d641c3527e; Tue, 02 May 2023 13:54:27 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB9066.eurprd04.prod.outlook.com (2603:10a6:10:2f1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 11:53:58 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6340.030; Tue, 2 May 2023 11:53:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 16d09ade-e8e0-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SiGR+Kn7niNo8TaNJwOseoCdTInLhvHtyqhSW/Kho6TYp8rB3GDWB5unsDBXlW+4/+KMaSDR1vVodJ3ugcUmy00uKkeik5dRoq6uy7n4oZd7iKXGifGiYBE2GjYj3le2WSXR0yp5g+U28YzLCB3fTzqpafRX2yJoSwutohIk5zqEc0z9s4bPIj/rBMmkJvUXaKHBX3FABQ8VyoQ8RNr7wF0cc1ti5Y9ZS440R29J/mkO+NIlEzQSZgSS6ql3mGLnO4723vlyhcdNTxCwA555ajhrNq1XopH7VctesS69b0KdWSAOuKhAWc5nunRJsQBA8YJFFzjB/3jV6kq3Z9OykA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bT7wUUqaHwxjkzXfncf8KWA9QpevS2EclWSY0d65XTo=; b=fZ6Ugvc1+pJLSyNnE8qvQ+FeSiCqq3OsRWHhB+yq7XvFeViSTS72/qyOlHWh/tq1Bi+Kfshb6qbhDH+oALBxYWwXFaS+i5wrqwfOY7BW7JTRPwoHZQX2ggeUxcXXNBa1Jdnqz5aLNcR1kZLt+j6MJGFLheAsNY4LqCBsQ5gJz7ZohEL/IVz6agabE//fF9uJsv6Za3d/uUk+uXLCoZbLlJvXyeGgDy1EV8iyIsJ9tFbJAgTzmH2uqN1VZiotaQjOFDTSwBaUa4KOcYSw+XmAKiH3w90Kb8Ie1hR29Onat5wJycoGPWq4FBbddMvrh5QEkBLBnuV1ygDGSH/AYq5iIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bT7wUUqaHwxjkzXfncf8KWA9QpevS2EclWSY0d65XTo=; b=CJWz4+mLeT+IbrvTeMLxHO2t3lPArD5xSilsc8NKdcQ7uHtlgZapFvdq+KvahxISJueU8RVnmbQsRyKwiRnu87k+hir+ReOtyQciAdjuIt91hYYOfbWEIzlnO6pf8+uT8kR05F0zti8SUZ+ht4pK0KEs544gnk5l6+ghZd8tTxyizUKuyawuyY2kAiks53pQqd8pmEOSyUoR3GYeIYTZW8/f6zkiFs9OdMIDipfSpqAww0Vs33bcYW4q32Q8ADVrMZveNkwhJGVbMPbCfd9EAnZK6D0HFMUn+cPx8BvW+purV22qYK3cQNoJg1geZ6S+xL7Sa6IJxmZv6iEffL2Kaw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5516fbf5-dbfc-dcd5-0465-e4757fdc16de@suse.com> Date: Tue, 2 May 2023 13:54:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3 1/2] acpi: Make TPM version configurable. Content-Language: en-US To: Jennifer Herbert Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Xen-devel References: <20230425174733.795961-1-jennifer.herbert@citrix.com> <20230425174733.795961-2-jennifer.herbert@citrix.com> From: Jan Beulich In-Reply-To: <20230425174733.795961-2-jennifer.herbert@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0103.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB9066:EE_ X-MS-Office365-Filtering-Correlation-Id: 1179ff0f-d307-4ea2-0caa-08db4b03e9d8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WQt7RqRLwTMZs79gAnBEk52FNMKuHMin8+MxlxbKFoEdgOL+8axAiAtpjo5l2Z045mCXkk5PdAMktQhOJMCyxMeoVD9aTIKyp1fAl0mfVk4bo0X4KVcFD1mWCz5F+DRRmIn07yWSaW+RI59nHOgozH+VTt7Vqhykx5DlTf+qr7x9n8x3Z2FAJSpaYINXEMOpsvfGcy4wA/8wWo8f72ngIPk6UBf3tBEWQ/6wMf380IMIehqUJ/I4OSgIZkXPNxLG06oHBF8QLActoFgS1taVYYRzP1+7/Xv12rDvM/R5B5oGzxXmVEJAzHVO6Nln/TSY5ad4H0A0dm6/pKwyI+6uiYUGqnxE2AvGPpNQkb+vnauK9cP9UWRswZhzCJzxlvxRqB56qGoreq0GCGDScq9IFMqvNU2E5j1VHxKFg05IpL3tDGki7GIZ9NvIC+jFyeiwNsOaVj5trIQemc6htYwOJArJvvXcg9gzLYyR/LoC7lXryYdhnAJHwWVNuc5yjXaZcaYg96Zvq7dQXDVTd35SiKci1EvJspn0xHV/UMFx51S5x5/QCRmLgUXKG/6Yz8/aMxj0eURuyPNMNxR3+p/Egcm6VAtj1HL5gUoXUdAU6xZTcgRRyQmC6kfEvlNnxCXt4UYOI+YFIZB3Bs8a5UVsZQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(136003)(376002)(346002)(39850400004)(366004)(451199021)(478600001)(316002)(6916009)(66476007)(66946007)(66556008)(4326008)(38100700002)(8936002)(8676002)(41300700001)(36756003)(5660300002)(86362001)(31696002)(2906002)(6486002)(6512007)(6506007)(53546011)(26005)(6666004)(186003)(2616005)(31686004)(83380400001)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?azk5b1pKQS9ZSHo4LytjbzhvMnpMeXBUNllqMTFybnZ0N3d2WlN6eTdlOTAx?= =?utf-8?B?aTFDMTBkSlliKzNqYmFaZW9YWWVXV2xxMGV5aENia0tnWVRzVmFqMmFCMUxu?= =?utf-8?B?MnlEUTNpeXQ5RGZsL3pnMXJuYWJ1OHErN0V1Y1ZzdENHeFRCZVBkRWFRRlJJ?= =?utf-8?B?MEtMU1VVaE55OU9iMGpCbkNseldxbkw2VzFKbndaVmxIVVkrVVlsdE9ORHZV?= =?utf-8?B?ZVhzZnBqU0RTNC9UMlpPS1VBV1VPMmpKNW5MZkRsRGxZV2RrdGFXd0tDUW9q?= =?utf-8?B?Q0VHbXkxSTNSOVFyMVZQNk11Qyt0dElwcjA2Y0V0QWRqcVlqMlMvaDZ2RUM5?= =?utf-8?B?WllNNmFFUzZZcHUzYUZkT2RoSitIVWlTa0Q3eDV0bXphS0hZa1VhOFh4NjQ2?= =?utf-8?B?Q094elZzbFRXN04vNmVvS1pkVkdPYmw3TDkvUzRtV0VaTXplTUR2elAvOCtG?= =?utf-8?B?MTMxU2FKMHpHZnhiT3dCaEhlaDF0RkJISzV1dzlwODFQMzcycms2a0swWnIw?= =?utf-8?B?NzY3b0RORzZhM0o2cXVNZEtlRWtqcTNuMmJYTmFvaHJ6d3JyRGl2WVcrRStI?= =?utf-8?B?WnI5aDhqWG5wWE1DY3N6QWRTNC9kWnNHcUwya1UvRHJ4OUFXRnl0eitIcmhB?= =?utf-8?B?QWp6SSsyOWdqbnZoUENsTklGSDc4eWR4QUhRR0ZHV0dGUzIyL1V2QVlBMjdC?= =?utf-8?B?aHQyYzcxU2tFVXFDU00rUDNzZFV3STI4L0hoOHdxd09jRDV1QXRzajcwckx1?= =?utf-8?B?YjVjYVJUekc0ZW5zdWZ0RjdxQVRyTlpGdVNieGVITU5ZN1JVSVErSmlGdHFL?= =?utf-8?B?dFNIQis0OGFIdzhMUWpXd1hQUStMVWhKV3UyZkdUMHVXZXk4NjJjMW9aWVR4?= =?utf-8?B?M3ZPOGdHZW52RkQ0NlhJVjVUNDVkaG93cWJoYythUVdoVmdKbXRaQXVaQ3Fp?= =?utf-8?B?UUlkV3VEWk5WY2xKM1pvTHpaNlZseWI0NldIZkxhSUZESXJhM1JaRHJlSlc0?= =?utf-8?B?QmdlNXllOWpEUFo3QUVJWGxTZnVNSThFSXZVSzZxeVNCalhtYkR3QjFSNlJm?= =?utf-8?B?MXNhaE1aUWw2WWltVFRuS05lR0E0RUNlSTlET0cyWjdZbitEN0NSZHJ5cE1H?= =?utf-8?B?UmV3QnBqOUZWUWs4N3Nsd2lqNmZ2THZ5dzVrcUN4TFBaQ1E5cDdxK3ZKeDRo?= =?utf-8?B?c1MrZEtvMWlsQmhQL1VSOFNkVDFqYmVZZ0xTanZPMjFGRU4xcEVZQk5DRU5X?= =?utf-8?B?ZERtZk5hN2dWUGs0dnp3ZzdCVFRKUzNpT1NNRVBRb25BRWd6TzUrYkxtYVMv?= =?utf-8?B?VTNWWEViZ0s0cVRIV1lHVWMyNGJmc2hRK0NIclJRR29pcHpTTWpyUTU3a1F0?= =?utf-8?B?eUtYbi9PdG5JSDEzMEw3WEZpNlZ0a0VLVk1tRjA1ZzZmUitkZitVbFFVbHRn?= =?utf-8?B?b0xBcGVXSDZsN3Fqd202YkRSZUNVVlhyb1ZxVUFMTnlBMnByMGRsTHZQQ1ov?= =?utf-8?B?RDJlU2dOdGE3MWZSNE04c3Y3YjVLdkR1RUJ6ZmRkcnJSeERVYVJRRmd3cUt4?= =?utf-8?B?N3Y0Q3hXcER5dUhmeGJxUUV0b1hwc1FJeFprWDRLM3dha0dBdGtEeFVhU1dY?= =?utf-8?B?YVIwaVVRSzJxeHRkYlBVYXRZUmxVc1h2d3ZFVWVua2RiY3NhNzdvVzBCcElk?= =?utf-8?B?YUJRRDA1WitVeGc1VXpQNjRCOTZmOXhvQmt4alo1NmVuQXdvRXoxZy9SQ0do?= =?utf-8?B?b1dOU0NTK3pqd1Q5aHltbTVzS21IRm83NlV5OGdteFp5bE1XQ1dyOU9KVERa?= =?utf-8?B?bVVOWUNzVUJuYWtPUUpvd2FnQld0dTcwNTljZWYxQzVTazR4bHkzcGdCT2sv?= =?utf-8?B?Mmo3bjVxRUY1SENwZmMvbDV6YjNWVnJCUGVwRXZzREpUamNuOGI0anZSeWdJ?= =?utf-8?B?Q1l6RkNFM2RSSXFVVGVJRUZWcmhGQWNMVm82Slo0QURWNmhNSDBkM09zaDVJ?= =?utf-8?B?SDZPOEV6VHNMLzB5QzNVVGNFUlkyTjQ0aG5GY3ltd24rUVlpanhuSXN3R0h1?= =?utf-8?B?ZUV1VWVGelQyWnQ2K28xVU9oWXpzZ0xuYUFsejZVbUxpY3p5Zy9rcE9VQmRm?= =?utf-8?Q?XnetBPfPzIjQvbsYlt4WWD3Xd?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1179ff0f-d307-4ea2-0caa-08db4b03e9d8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 11:53:58.4639 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6Sdj6afygbv1f3YZMtMfKvSDPVa/a5YB7pY5bcmhNJOYKdorGtyutwrvxYCI5VfZp8Oy2MJlrqWiSGZIT8q/Gw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9066 On 25.04.2023 19:47, Jennifer Herbert wrote: > This patch makes the TPM version, for which the ACPI libary probes, configurable. > If acpi_config.tpm_verison is set to 1, it indicates that 1.2 (TCPA) should be probed. > I have also added to hvmloader an option to allow setting this new config, which can > be triggered by setting the platform/tpm_version xenstore key. > > Signed-off-by: Jennifer Herbert > --- > docs/misc/xenstore-paths.pandoc | 9 +++++ > tools/firmware/hvmloader/util.c | 19 ++++++--- > tools/libacpi/build.c | 69 +++++++++++++++++++-------------- > tools/libacpi/libacpi.h | 3 +- > 4 files changed, 64 insertions(+), 36 deletions(-) Please can you get used to providing a brief rev log somewhere here? > --- a/tools/firmware/hvmloader/util.c > +++ b/tools/firmware/hvmloader/util.c > @@ -994,13 +994,22 @@ void hvmloader_acpi_build_tables(struct acpi_config *config, > if ( !strncmp(xenstore_read("platform/acpi_laptop_slate", "0"), "1", 1) ) > config->table_flags |= ACPI_HAS_SSDT_LAPTOP_SLATE; > > - config->table_flags |= (ACPI_HAS_TCPA | ACPI_HAS_IOAPIC | > - ACPI_HAS_WAET | ACPI_HAS_PMTIMER | > - ACPI_HAS_BUTTONS | ACPI_HAS_VGA | > - ACPI_HAS_8042 | ACPI_HAS_CMOS_RTC); > + config->table_flags |= (ACPI_HAS_IOAPIC | ACPI_HAS_WAET | > + ACPI_HAS_PMTIMER | ACPI_HAS_BUTTONS | > + ACPI_HAS_VGA | ACPI_HAS_8042 | > + ACPI_HAS_CMOS_RTC); > config->acpi_revision = 4; > > - config->tis_hdr = (uint16_t *)ACPI_TIS_HDR_ADDRESS; > + s = xenstore_read("platform/tpm_version", "1"); > + config->tpm_version = strtoll(s, NULL, 0); Due to field width, someone specifying 257 will also get a 1.2 TPM, if I'm not mistaken. > + switch( config->tpm_version ) Nit: Style (missing blank). > --- a/tools/libacpi/build.c > +++ b/tools/libacpi/build.c > @@ -409,38 +409,47 @@ static int construct_secondary_tables(struct acpi_ctxt *ctxt, > memcpy(ssdt, ssdt_laptop_slate, sizeof(ssdt_laptop_slate)); > table_ptrs[nr_tables++] = ctxt->mem_ops.v2p(ctxt, ssdt); > } > - > - /* TPM TCPA and SSDT. */ > - if ( (config->table_flags & ACPI_HAS_TCPA) && > - (config->tis_hdr[0] != 0 && config->tis_hdr[0] != 0xffff) && > - (config->tis_hdr[1] != 0 && config->tis_hdr[1] != 0xffff) ) > + /* TPM and its SSDT. */ > + if ( config->table_flags & ACPI_HAS_TPM ) > { > - ssdt = ctxt->mem_ops.alloc(ctxt, sizeof(ssdt_tpm), 16); > - if (!ssdt) return -1; > - memcpy(ssdt, ssdt_tpm, sizeof(ssdt_tpm)); > - table_ptrs[nr_tables++] = ctxt->mem_ops.v2p(ctxt, ssdt); > - > - tcpa = ctxt->mem_ops.alloc(ctxt, sizeof(struct acpi_20_tcpa), 16); > - if (!tcpa) return -1; > - memset(tcpa, 0, sizeof(*tcpa)); > - table_ptrs[nr_tables++] = ctxt->mem_ops.v2p(ctxt, tcpa); > - > - tcpa->header.signature = ACPI_2_0_TCPA_SIGNATURE; > - tcpa->header.length = sizeof(*tcpa); > - tcpa->header.revision = ACPI_2_0_TCPA_REVISION; > - fixed_strcpy(tcpa->header.oem_id, ACPI_OEM_ID); > - fixed_strcpy(tcpa->header.oem_table_id, ACPI_OEM_TABLE_ID); > - tcpa->header.oem_revision = ACPI_OEM_REVISION; > - tcpa->header.creator_id = ACPI_CREATOR_ID; > - tcpa->header.creator_revision = ACPI_CREATOR_REVISION; > - if ( (lasa = ctxt->mem_ops.alloc(ctxt, ACPI_2_0_TCPA_LAML_SIZE, 16)) != NULL ) > + switch ( config->tpm_version ) > { > - tcpa->lasa = ctxt->mem_ops.v2p(ctxt, lasa); > - tcpa->laml = ACPI_2_0_TCPA_LAML_SIZE; > - memset(lasa, 0, tcpa->laml); > - set_checksum(tcpa, > - offsetof(struct acpi_header, checksum), > - tcpa->header.length); > + case 0: /* Assume legacy code wanted tpm 1.2 */ Along the lines of what Jason said: Unless this is known to be needed for anything, I'd prefer if it was omitted. Jan From xen-devel-bounces@lists.xenproject.org Tue May 02 12:01:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 12:01:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528552.821865 (Exim 4.92) (envelope-from ) id 1ptoh5-0005jJ-W6; Tue, 02 May 2023 12:01:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528552.821865; Tue, 02 May 2023 12:01:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptoh5-0005jC-TN; Tue, 02 May 2023 12:01:19 +0000 Received: by outflank-mailman (input) for mailman id 528552; Tue, 02 May 2023 12:01:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptoh4-0005j6-7L for xen-devel@lists.xenproject.org; Tue, 02 May 2023 12:01:18 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0908c1e4-e8e1-11ed-8611-37d641c3527e; Tue, 02 May 2023 14:01:15 +0200 (CEST) Received: from mail-dm6nam11lp2170.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2023 08:01:09 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB5888.namprd03.prod.outlook.com (2603:10b6:a03:2d6::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Tue, 2 May 2023 12:01:07 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb%4]) with mapi id 15.20.6340.031; Tue, 2 May 2023 12:01:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0908c1e4-e8e1-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683028875; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=MO9YZe9mZayTlgGSpnI5uZXpludFlQY/Ro+jZvMe6yE=; b=dIReUgIAzMymFuirSf32CIN/TrUgaRp2EwNSPSHbLwE5oneFSKbnVnHK aUmVBzjQiaqA8syN3IF75MqLrHufVJkjO/XaCh/N7wovxDH/jGKnyR3Ll nO0RkZpUhS68yeqdyRkEQBeXZL60y5HPJ2jPncaRxh33oRO59Zoa53ukW I=; X-IronPort-RemoteIP: 104.47.57.170 X-IronPort-MID: 107971263 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23://jsZ6CgJ4uPCRVW/wDiw5YqxClBgxIJ4kV8jS/XYbTApDJx0D1Uz mRLDD2BOq6NZ2D8eNgjOtzl/RsGsJOAzNBqQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFuspvlDs15K6p4G5A5ARkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw3el5WUAS3 t0iKikzcEC9q8uLy5ehRbw57igjBJGD0II3nFhFlGicIdN4BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI+uxuvDC7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prraXwnKkAdhMT9VU8NZBkFSyxWBICiQkXEu+neuztxOaQOt2f hl8Fi0G6PJaGFaQZt75VhOQqXOcsBoRHdZde8U44gyQzqvf4y6CG3MJCDVGbbQOpMIwADAny FKNt9foHiB09q2YT2qH8bWZpi/0PjIaRVLufgcBRAoBptXm/oc6i0uWSs45SfHtyNroBTv33 jaG6jAkgKkehtIK0KP9+k3bhzWrpd7CSQtdChjrY19JJzhRPOaND7FEI3CAhRqcBO51lmW8g UU= IronPort-HdrOrdr: A9a23:kpM9jqyLK1sJV/MNO26yKrPwyb1zdoMgy1knxilNoH1uH/Bw+P rOoB1273/JYVUqKRUdcLK7Scq9qBrnnPYfjeZ+AV7IZniChILHFvAB0aLShxfnHDLz7fNQ2J pnV6h7BLTLfD9HpNe/5BOnV9UtxNTC96y3n+LT0mpgVmhRGthdxhY8DhyEVk57QAQDHpY3FJ f03Ls+mxOwPXAMcIC5Cn0JG/LIr9rNlJXpJQQNAQUq8mC1/FWVwa+/CRKfxRcYXXdEyaov/2 7fg2XCjJmejw== X-Talos-CUID: =?us-ascii?q?9a23=3A77BJxGhnQ5s07KuJSTM09DM6jzJuVXLTlFaMCG6?= =?us-ascii?q?CC39XVu2rZXat84Z+nJ87?= X-Talos-MUID: 9a23:T51NuwQ1ExxVFvySRXTHlDhDN8sz4Z2cAVAIrYcMhpSgLhVZbmI= X-IronPort-AV: E=Sophos;i="5.99,244,1677560400"; d="scan'208";a="107971263" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WjiK3cgwVFpZFETyuqsDf7Z4ZhTFX3IPoKJen1lTGoe0Dar8CTtcTZGY8CsZypQUs2JmAVNje0tG9hBdWl1ymFBB68+jrdRmS8CfRtFDGzuvXgoPd1h019eKmbTJkOzjBc2lTbL9Ny3C65el3K4M3jvPP2PAxF8y8OjvKB8tf+pHvIUoe3bdAPaUFRyT5vab1hZKCUUq0v5EJ290J/fzSf7o9USCvZW6OhzfzKL2uTsMfoZje+/YPxM5UAhDfVvEiy8czuFHLjKMoZsyoxrLl4BdoqIQrhJSMn6MRvUu/PhRM/2khbuI2wmeAnvSfH0ByS5NmVOv49VxvZ58RiU80Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MO9YZe9mZayTlgGSpnI5uZXpludFlQY/Ro+jZvMe6yE=; b=mkgTl/uH3ccqFUk3Gd/H22GN6i4SPsQVzlVGHPIvTFYlLaFux5WTNTlAX5zbeuE4FSinafJajwbfaLbnWU4PG2fb4oOSTKLNYQqlsYwND/M0DqzLh7RcnYHYxBx4fYoDLnoR4z0SBk/rek1Ir7J9xNt2wSlrWPbGh/OLPhAQZm2vOW7hLOVYvDhoCU7kcFAJsih5lOEaDcoOp9eGzs3uT2cgGhEjkdHbbevRkCexBpEyEwW8V3/Dci/uc3SkiASt9wFtrX+e2ovbMQfdE19MzqF+MguC/SvJ4+8o64lFma63DWKqh+1tS9Sq2BKaSrnKIuunbMls4TRgtCdGBZMDwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MO9YZe9mZayTlgGSpnI5uZXpludFlQY/Ro+jZvMe6yE=; b=kKzwgn2UEyLvgVVmD1kmiWHuUTE7yXFu6K1f/NOEcOKD49BxSMuKf8ETlV4Oun6TAiNXPgmcZA+4VZO5xYJEvBWCdfiZJNNGMbAv0zRXLSadVQHMXP4LuPzgzO8szGMj7jlng/scj7odMejv8UxmpO6c/FznWtxObPGcTFkqVHU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <71c0b0a4-caf5-2b60-0e6a-54dfe313e332@citrix.com> Date: Tue, 2 May 2023 13:01:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: HAS_CC_CET_IBT misdetected Content-Language: en-GB To: Olaf Hering , Jan Beulich Cc: xen-devel@lists.xenproject.org References: <20230502074853.7cd10ee3.olaf@aepfle.de> <43b1c214-4248-a735-6f8c-9e08bdd2eaf6@suse.com> <20230502133313.2192eb99.olaf@aepfle.de> From: Andrew Cooper In-Reply-To: <20230502133313.2192eb99.olaf@aepfle.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0576.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:276::23) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB5888:EE_ X-MS-Office365-Filtering-Correlation-Id: 5a327ba5-300e-4f1e-6363-08db4b04e943 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6j4PHyszZ79nd8anDnfw2tQDadC4m8CIJPjldIzYZBTaIl+53GbrRcVNbr9IBbykqw+zXUQ8ZwQj8V9DStc71Y2cHIRXCuS97TMUZHpql8AgmiklNi1I8usu//GGO6jNWS8jzdKLT86HqTnZOp7WzsZ6l1wuJqdKDoLHcy0iIv+QL6rhFf/c0W2J0HTyujKpYSAzG7JM1f9QNEYxcV3NTrqmc56NT6FxhambTlY/K7pXqHdBsz2Z3iZBeIqdau42UcrFDUuPXFoxpNLhoQX5NP98V7UYK0i8m6QqVncIGDtmav/T4ewDjTEi3YkyJs5mq+LVhZA6lXZLM0q8xU5al2mZXYKABgjU1fXeKnVsRt8K8hBeY8e803WhzLM+GFcA5BF1L1Mi3d3uM4+A/QTWiGSMwwTHYd22KM9KlPFv324NQvCjAyEUkDDRRfJsty8yztmQ8lgWMVa8GnjS+QoGkmM7w3XrehOqRCiYtURkFTTYPIgdoX1aTO371uEwbOnpU6Y/TqHvsoX501aat6bHy96SdlbD8o0CBDNRf2Jkq6xnoIlJGrSp9wW1RXVimSnzJ5IiErh+rBeEO+ZVKjbrelf67mxVRgcP3fJ4unktETSUb2FOyVjtkT50kazGpyRDy+4wB/HVICQHHlFXrCVSfw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(346002)(366004)(396003)(39860400002)(451199021)(66556008)(66476007)(82960400001)(38100700002)(6506007)(6512007)(31686004)(186003)(316002)(26005)(4326008)(53546011)(66946007)(110136005)(478600001)(41300700001)(7116003)(36756003)(2616005)(6666004)(966005)(86362001)(6486002)(83380400001)(5660300002)(2906002)(8676002)(8936002)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TXl0WUY2VUZtTE96d0Q0VzBNNUJNYXNyZGtneHA4SlZnSTJYcTkvSENxc1Ju?= =?utf-8?B?U2MrS0xQNnhSemVCaExVdjd0U3lNQ3htaklKTnRBZjJTU3A0SGNBNTlRc0xq?= =?utf-8?B?L0tHRFVpTm9meFBkWmRJUzBQYzQrR1dYYlI0bmNpeTlKMzhLcmZVTVd3WUxo?= =?utf-8?B?VXRLUVN5aGpCYTNpRjl6OWl4UnhXQVJ3ZmZEMDJQMTJNUHdyN0hnUGQ4UEk0?= =?utf-8?B?UTUzZ3ZzNjR4T0lKeXloUG9DaTNwdFpBSk1mR3dJcFhzenBnZXpRTVNicm1o?= =?utf-8?B?czE3WGlJTk9ERkZjS09ieTdTT25KQXU3bGRwUU9yNnkrbHJmYzF2UTJ1dW9P?= =?utf-8?B?a1lHbWkxTmtOamVrTHBDU3JlQXZGbVk4RVNQdGVSQjJBaHFDS0ZXKzV2Z3dE?= =?utf-8?B?ak5UalRteWk0ay94OHNsZG5rc3ppa0h2djVyaTFUWWNPT09UNllTVmVhQ1FE?= =?utf-8?B?VDIzS0h5VkJpNjNMTGpmSng5cVdjWnlzdkI1dy90K2RjRnhLY2VqSm03akR0?= =?utf-8?B?bjQwcU1OSkQzTVUzbTdFWGRiN1Z6cjh5M0JzNThoaW9nMVVYRVBHZUNGTUVF?= =?utf-8?B?V1crRlI1Szlqdkc4NWNMdnp5ZStIMDBSUDBmY3pCOU51K2g1MUJXN2hZTEhY?= =?utf-8?B?UDJSbEJLN3pRZXd6VE1ncFFxelJScFNYRGkxVzJmK3YzWUpXekxNc1p6TEIv?= =?utf-8?B?OC9iUlJ4OW5zM25Db001TTVVQlJKWit4MUxvZHVRMGpBTEsrNGFoWExsZEdp?= =?utf-8?B?dmkyL1pnbURNS21iWVFsdFVFWFJneERJK05kcURvY21ZL01tUVlIbDBrS1Mv?= =?utf-8?B?WUlpZDZLNFU0VmtWamxCR1VMVS9VOVp6ZkFTeTNFRithUCtOSnc0TklsWXM2?= =?utf-8?B?MTVIWlFQOUo1cnBVTHNKZ0hXczJtbktWLy9HM1Y5WkZ6Tk5MQ1g5aHFWVTZz?= =?utf-8?B?YXArMEJDdzBxRHhFbkh1d0huekVCcnJZNlN1bVBvYlhhemFEWnFFQXlUVS9I?= =?utf-8?B?Z3N3TzM0Si9JOGJrck80S1IzcjR3amxjR2o2MDFJY05wMS9MRS9Hb1BkbkNy?= =?utf-8?B?YU1NOXJDK1dUc21PQjFyaTRZdTRoZ2twcjBzaXBqbDJDdzA5clV5MGNUYmFD?= =?utf-8?B?YjRpNGZMNEw3ZzRmRmVaejZvTEZiblUwNmtzczJ6WVUrcGFRdzNuMFpyL2NC?= =?utf-8?B?SXBHUVJ6WUpKb29xajlHM3ZmOFdoM3IrNzk4TXJBM1YxdFZLaTdzV2krUFgv?= =?utf-8?B?V1RFWUczZk5GN2ZqWnY5d2ZYT2VNbVc3eGtVVTNtZjU5RXVEblgyRWRlSDBn?= =?utf-8?B?dkhkY0JvMG0zVmZ6VmlTYjhqMFVGeXJ4S0NucHVuOVBxUllZUVV2TzVlaEZp?= =?utf-8?B?VHhwdk42SjJqN09zd0ZlY3dGTExSSXZiSmtXSDM4R1RZSzdySkwwekx0dUZt?= =?utf-8?B?VkxWTDk0eXhOMXk2cWVBQVJOS3NoK0lBVUUvdVNOOUFrOHgwNWhKNEk1cGx5?= =?utf-8?B?QmlqUndDNHQ0SzRYZmF0L2hWSlQ5VkhiUDdKRkdUWUpQemxvbFdGK1JObWdM?= =?utf-8?B?djU1eWFLNlRZQ24wdU5RUjllU05ici9kNlhFNkc5aGhiZGlMQVFaZWN1Q0g2?= =?utf-8?B?WW82ZSsxTkd4N2JlT2VpL0NqSzZoWXk2RGNMc3AvSVVYMllJWGIrdWQrL2lo?= =?utf-8?B?WCsrV003UE5FMTlDTzIyb09MUk9SNFNLelFTdXBObmpybktLSnFvU01EZXFn?= =?utf-8?B?ZHlQWHUvdzJFcmd5WkNCWEt2OW9Ma3loRS8rVWJEdC9ITEhHa1k0MllSOUdU?= =?utf-8?B?cUEvZnRTRFVtSE1hWm0rUlkyMHBTcE8vMmdnV1VVbkY1S0xHcTZreDgrVVdK?= =?utf-8?B?d3J2Q252TWlQSVFxNkxJRkNZcEtDZklLS2VQQUJDY2tlZWVGU2ZLdFErQzBC?= =?utf-8?B?b2VTWmtxN0ZZWXVkUFZmYzI0RTc1Q2pGVGM2cCtILzVUWHNHNUJ1Z2dpd3oz?= =?utf-8?B?VTJsdm1xekhDZWY0UDlTUFF0WnVSeVlHNHRXcE1xeE1tVFNyNWtaZHdZWHhD?= =?utf-8?B?M2x0SlI1b2xmWndhdDdVV21GWFlQeDlRcWoyQllmaGRTZ3VQcW0vajEyM1Vx?= =?utf-8?B?SWFrRlErcXdMT3ZNYlBsT3FNSytUM3pKRXRLWkRnbC80OXRJWm1Zei9LRkY5?= =?utf-8?B?WXc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Csywnk10FwI9jV3cZBOyb5ImAS/eIadGdeW2eLaKwjPLaMfxRpC2HXw+dz8GMBIYFu7U2uiAYSupXElwMKeRIb+gLFTF8g8bfV437O0tbH1vrFWvZ5Xw3QnI/zje3qZzmAqnFNiatMhNpJnk0gqQOq6HwJCAmyYu/sWh/hNdkEqNOMdGgEQg8wWnegkjgOv4b18UpWpbTqpGFbETn9jYL5iud0Lj9Phi2IeR9sjMR3N+e8JV2cIzBj8p05depYTu4jZ4PG/MQLwWww1cZSKHooRU0qsPTnM53Zzbt3vD5HJ3IA6j6qz/prL/HZXGJyeI++9txlP/uemekK/P/EwyAJAmt45bNYMRuo8CvE+1nrrw/ac6D69lTAeBrR2NDXlfKbYGKSZwOwc0b7Qv4vtY/ElLojnUkxleFoDCCRmP1KxiHPs7Fwhn4fPFMEOLzq71/fPARR309HXfxHCkZuY1ZW4Ydc0l/HLotA3Q66iWK+n8HFwJkkoUmg+kOfbnsQszUWA9FjLmmkyjg/gMR2/EH2qCVwq0f4JnTq4oYuEFluKoSNkrJ9/UP4OiNe2NdJOI1NKXy1s8EqhZunZ3I24Mqcvmkm79Y6/ltVM7uInNWuFMfTvNm/KMFLk1yAh9EbZPBX1yVLvH9UpK+gYO35bSJKO77nkil7x7YbpjVtywrLqzaoBuxAmQMBg8GHi6ec26KrxeLEUlU0EJL2/NAFw7+qbw+t05DBCi8wGbEfHgGb/bjUpv4r076e+FYM84qTOXVfPsaSo+z1YT+PJUI3FbMb13rYcYvS7L4YCnrkyiGEtlvbNdiLt9ViitpROhuy28sMwCKNhnYv3w9pWuQh+//g== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5a327ba5-300e-4f1e-6363-08db4b04e943 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 12:01:07.1529 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g9GZs7zyLzzo8aRF1CoWEumd4iExMffPEqehsC3nuSoi5rhBe1ysjRMepMlFVLN4+SuqI7GyC1clkzkjnyuAWled4XQkpBa2rhv3bhtJqk8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5888 On 02/05/2023 12:33 pm, Olaf Hering wrote: > Tue, 2 May 2023 09:31:56 +0200 Jan Beulich : > >> How does 2.37 vs 2.39 matter? CET-IBT support is present in gas as of 2.29. > I have no idea. It turned out, the previous Leap image was based on 15.3, while the current one will be 15.4. > > If I run this manually, it appears the error is produced properly: > > gcc -Wall -fcf-protection=branch -mmanual-endbr -mindirect-branch=thunk-extern -c -x assembler -o /dev/null - ; echo $? > gcc: error: unrecognized command line option ‘-fcf-protection=branch’; did you mean ‘-fno-protect-parens’? > gcc: error: unrecognized command line option ‘-mmanual-endbr’ > 1 > > An for some reason there is no failure with the refreshed image on gitlab: > > https://gitlab.com/xen-project/xen/-/jobs/4210269545/artifacts/external_file/build.log > > I will investigate why it failed to build for me. CET-IBT is far more dependent on the compiler, than it is on binutils. The minimum version of GCC necessary is 9, but if you've backported the requisite options then an older GCC will work too. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue May 02 12:04:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 12:04:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528555.821875 (Exim 4.92) (envelope-from ) id 1ptoka-0006IW-GB; Tue, 02 May 2023 12:04:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528555.821875; Tue, 02 May 2023 12:04:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptoka-0006IP-Cg; Tue, 02 May 2023 12:04:56 +0000 Received: by outflank-mailman (input) for mailman id 528555; Tue, 02 May 2023 12:04:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptokZ-0006IJ-G2 for xen-devel@lists.xenproject.org; Tue, 02 May 2023 12:04:55 +0000 Received: from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de [85.215.255.24]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8b8047f9-e8e1-11ed-8611-37d641c3527e; Tue, 02 May 2023 14:04:52 +0200 (CEST) Received: from sender by smtp.strato.de (RZmta 49.4.0 AUTH) with ESMTPSA id x6987cz42C4pcnt (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Tue, 2 May 2023 14:04:51 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b8047f9-e8e1-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1683029091; cv=none; d=strato.com; s=strato-dkim-0002; b=EWO7skeoBe4yfkVPVp8E9tGGHEtGucIQH+nn7LMialRWFBTvh03Yjp7YddlGAcDH/P UVY3xpxjxfApHPIKEhs9lR58drijThiRQqw4uiwIPyEA/NPbk3a4hRGR9l9+75DmYEGB tBj7KA6tJ/TFViW27zmZ+tUyyycPaAjasJaSRnAPQSI5NZL0otasnFA8osNJnkhwqewV w6tjhiVXCFWnVSIyZIqy9W8V/gBioQORp80OAKUMiQ4OFnaEvipAhmbr0FQQ+uPYNXNt IgRY37a1nhcxm2P5WgK3+zO2z1kUTbQo7S6VYfd0XQhgjcM2jwgo4KovmqGtyr0mIATU Km/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1683029091; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=qM5Q7xIHqNoa7V8tuK4qUQi9+8lwqvYj9KvI656lkEU=; b=IWBkxbwRO8gW5D0NTN27tqBe7//+rxZBBcqJ5ta8tYVGHHjf4n+o6k3/OZr1FKt+yx 9wTYCAkBpg0P0owNRv99Tr4enViuSg2gDBI513xzrusBys40tcOvxLIyeKI4ihTcw/mq eOskdgw7beZ5/Y+ZBBni6CaApSvg7C6hZjmMY0y0/HAKYw9a6AV+Y4bRdRtzcn/EboA+ 87Sn80X7j3ky5ayF3u3x2Omj43ddxrgWt898tfanf9YOYL1nhtQUw4lhCGwoEwEzuaxM /Ok34dCQ22IdEdzLHVARzuZHJcIlSR76knCEnxSlwePBFPyyP0TMTaI5uOs5wrTAztsm 1WFw== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1683029091; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=qM5Q7xIHqNoa7V8tuK4qUQi9+8lwqvYj9KvI656lkEU=; b=OEBmRGRRxrpMGETMpt/ESEsFgkbUQ8aeGsU/LWiHnb+YzteC2koBVEhuUNiYY8BqML Xs5sB10vk53OoxD+0GEtPZ8NFgOto5D+zytdzti3WtAKlySpki+/STvXJOmzLXeeryGk brY4ybGpZEmglEFFVMXbSEYxuVoMOm9+OR1dU1tZPgic+u5I5ik150tiPpVYoJtycMU1 lnqfz7LodshImI/ZNvr3rVKYwWKF7LmLoXyP+wThyEXZ4GOCHwWbLxS63STyt9HhcuLI Xnt8v4F9q2vwUCgqQMTjtIMb9CogEst2PnSlJHOWXxEInq+avu68LE7AERHftk1CJtK1 sg/w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1683029091; s=strato-dkim-0003; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=qM5Q7xIHqNoa7V8tuK4qUQi9+8lwqvYj9KvI656lkEU=; b=C76atAzpxdx41BT+4DfbwOyRKcXi0KcwZJn9OTlz/+ik+v3G00nujNUraDY3uIGbEc mW+W0i16b09mfspZ3yDA== X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisR5BxOIbBnsc1fym1gFvNQ7EzMpH+yFJc4aADp/8Q==" Date: Tue, 2 May 2023 14:04:44 +0200 From: Olaf Hering To: Jan Beulich Cc: xen-devel@lists.xenproject.org Subject: Re: HAS_CC_CET_IBT misdetected Message-ID: <20230502140444.1dacdb33.olaf@aepfle.de> In-Reply-To: <20230502133313.2192eb99.olaf@aepfle.de> References: <20230502074853.7cd10ee3.olaf@aepfle.de> <43b1c214-4248-a735-6f8c-9e08bdd2eaf6@suse.com> <20230502133313.2192eb99.olaf@aepfle.de> X-Mailer: Claws Mail 20220819T065813.516423bc hat ein Softwareproblem, kann man nichts machen. MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/HiNIMqJmHC3=du_nGbCKnvP"; protocol="application/pgp-signature"; micalg=pgp-sha256 Content-Transfer-Encoding: 7bit --Sig_/HiNIMqJmHC3=du_nGbCKnvP Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Tue, 2 May 2023 13:33:13 +0200 Olaf Hering : > I will investigate why it failed to build for me. This happens if one builds first with the Tumbleweed container, and later w= ith the Leap container, without a 'git clean -dffx' in between. Is there a way to invalidate everything if the toolchain changes? Olaf --Sig_/HiNIMqJmHC3=du_nGbCKnvP Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmRQ/FwACgkQ86SN7mm1 DoBBbA/+JpzGbwooQx4pzx5wH+ctKszUF1DHoZUoBlonOR8ZNXfyDkvFV7CfMLsF ouQe/MzZPIMBXmRQvgdgPoamxOKbSwze+2qNNRsgkqeUMrFafUNT7/UkHqk4cHgG Yx3zj+lKoJDqU1fybmNUFrIdA+0nYuRS/L/vPZkt3qOQXtu1MEn9vsQKmgSOs7Wj 7GfUJhSKXCN5brtxwWy9Gd9/bK6NemaCxLv9txIxKaySWDMJ16yNiKIhX/dK6tTx GMq1kuAajxe8xgbSxUYiHVmJ+fbuFmuiPpejQbYurc30AEzXsVaRg04ub8bt37NF nQxtUuK9E8awKRWtcjZJMs6jJCHtRwWyltROs7JW5R9wtvzu299Kd39NHN+Plu4m RK45OQC8ypbEWO8boN4I4NJ5A1B2o99y6Wwnyufb3fzgZgSu4mnPlX1LcTGQoebD miDxtIm2fAybqBTWQEX350GWSaBy6kCyKFYqNNxmKv29GyraY44jo213CWfQRFqD G757CKQP4BPidjQJpIcarUAmHS3XXSOGbI93oPmLOfPBFt2yJSnnw4WR7uNDyGgR z1m3cEZokbVX7YsTmzwGOE4k5N5S50UEwFKKl7ly2vg0j76yHtyuXfXTHkual3ko xipHjguTHl/E08Z4M5cpmyn+FBQa/Tl/n+stFLsmWjqn3/Dails= =MGIj -----END PGP SIGNATURE----- --Sig_/HiNIMqJmHC3=du_nGbCKnvP-- From xen-devel-bounces@lists.xenproject.org Tue May 02 12:09:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 12:09:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528559.821885 (Exim 4.92) (envelope-from ) id 1ptopG-0006yn-0a; Tue, 02 May 2023 12:09:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528559.821885; Tue, 02 May 2023 12:09:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptopF-0006yg-UC; Tue, 02 May 2023 12:09:45 +0000 Received: by outflank-mailman (input) for mailman id 528559; Tue, 02 May 2023 12:09:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptopE-0006ya-SS for xen-devel@lists.xenproject.org; Tue, 02 May 2023 12:09:44 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 38643c05-e8e2-11ed-8611-37d641c3527e; Tue, 02 May 2023 14:09:42 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 23DE021A10; Tue, 2 May 2023 12:09:42 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9635D139C3; Tue, 2 May 2023 12:09:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id bPRFI4X9UGRmLwAAMHmgww (envelope-from ); Tue, 02 May 2023 12:09:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 38643c05-e8e2-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683029382; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=5isj2N5NCBHlgNEX7kDR8L5F10upbDgKEvNgnzD7pjU=; b=lCdfsFMOgUvQOOjznQ29dhIfCPfBATrhqs0ygxXq+WuLpchDR8rfeWRUqFg4gsVq1hAZso M6yRbkcUUeSN+OZpt0kdpNk+01NuOD3H4axIM8mN+INEgVDTKNBob6uRoIMwSVTHqsAyiH tXY30Kqoaqh0gDh5kUwQuvMJsIBgFwg= From: Juergen Gross To: linux-kernel@vger.kernel.org, x86@kernel.org, linux-hyperv@vger.kernel.org, linux-doc@vger.kernel.org Cc: mikelley@microsoft.com, Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Boris Ostrovsky , xen-devel@lists.xenproject.org, Jonathan Corbet , Andy Lutomirski , Peter Zijlstra Subject: [PATCH v6 00/16] x86/mtrr: fix handling with PAT but without MTRR Date: Tue, 2 May 2023 14:09:15 +0200 Message-Id: <20230502120931.20719-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series tries to fix the rather special case of PAT being available without having MTRRs (either due to CONFIG_MTRR being not set, or because the feature has been disabled e.g. by a hypervisor). The main use cases are Xen PV guests and SEV-SNP guests running under Hyper-V. Instead of trying to work around all the issues by adding if statements here and there, just try to use the complete available infrastructure by setting up a read-only MTRR state when needed. In the Xen PV case the current MTRR MSR values can be read from the hypervisor, while for the SEV-SNP case all needed is to set the default caching mode to "WB". I have added more cleanup which has been discussed when looking into the most recent failures. Note that I couldn't test the Hyper-V related change (patch 3). Running on bare metal and with Xen didn't show any problems with the series applied. It should be noted that patches 9+10 are replacing today's way to lookup the MTRR cache type for a memory region from looking at the MTRR register values to building a memory map with the cache types. This should make the lookup much faster and much easier to understand. Changes in V2: - replaced former patches 1+2 with new patches 1-4, avoiding especially the rather hacky approach of V1, while making all the MTRR type conflict tests available for the Xen PV case - updated patch 6 (was patch 4 in V1) Changes in V3: - dropped patch 5 of V2, as already applied - split patch 1 of V2 into 2 patches - new patches 6-10 - addressed comments Changes in V4: - addressed comments Changes in V5 - addressed comments - some other small fixes - new patches 3, 8 and 15 Changes in V6: - patch 1 replaces patches 1+2 of V5 - new patches 8+12 - addressed comments Juergen Gross (16): x86/mtrr: remove physical address size calculation x86/mtrr: replace some constants with defines x86/mtrr: support setting MTRR state for software defined MTRRs x86/hyperv: set MTRR state when running as SEV-SNP Hyper-V guest x86/xen: set MTRR state when running as Xen PV initial domain x86/mtrr: replace vendor tests in MTRR code x86/mtrr: have only one set_mtrr() variant x86/mtrr: move 32-bit code from mtrr.c to legacy.c x86/mtrr: allocate mtrr_value array dynamically x86/mtrr: add get_effective_type() service function x86/mtrr: construct a memory map with cache modes x86/mtrr: add mtrr=debug command line option x86/mtrr: use new cache_map in mtrr_type_lookup() x86/mtrr: don't let mtrr_type_lookup() return MTRR_TYPE_INVALID x86/mm: only check uniform after calling mtrr_type_lookup() x86/mtrr: remove unused code .../admin-guide/kernel-parameters.txt | 4 + arch/x86/hyperv/ivm.c | 4 + arch/x86/include/asm/mtrr.h | 43 +- arch/x86/include/uapi/asm/mtrr.h | 6 +- arch/x86/kernel/cpu/mtrr/Makefile | 2 +- arch/x86/kernel/cpu/mtrr/amd.c | 2 +- arch/x86/kernel/cpu/mtrr/centaur.c | 11 +- arch/x86/kernel/cpu/mtrr/cleanup.c | 22 +- arch/x86/kernel/cpu/mtrr/cyrix.c | 2 +- arch/x86/kernel/cpu/mtrr/generic.c | 677 ++++++++++++------ arch/x86/kernel/cpu/mtrr/legacy.c | 90 +++ arch/x86/kernel/cpu/mtrr/mtrr.c | 195 ++--- arch/x86/kernel/cpu/mtrr/mtrr.h | 18 +- arch/x86/kernel/setup.c | 2 + arch/x86/mm/pgtable.c | 24 +- arch/x86/xen/enlighten_pv.c | 52 ++ 16 files changed, 721 insertions(+), 433 deletions(-) create mode 100644 arch/x86/kernel/cpu/mtrr/legacy.c -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue May 02 12:10:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 12:10:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528561.821894 (Exim 4.92) (envelope-from ) id 1ptoph-0008Fd-9o; Tue, 02 May 2023 12:10:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528561.821894; Tue, 02 May 2023 12:10:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptoph-0008FU-5s; Tue, 02 May 2023 12:10:13 +0000 Received: by outflank-mailman (input) for mailman id 528561; Tue, 02 May 2023 12:10:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptopg-0008EV-Bf for xen-devel@lists.xenproject.org; Tue, 02 May 2023 12:10:12 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 49720d1c-e8e2-11ed-b225-6b7b168915f2; Tue, 02 May 2023 14:10:11 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DFC711F8D6; Tue, 2 May 2023 12:10:10 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 92321139C3; Tue, 2 May 2023 12:10:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id GmhQIqL9UGTMLwAAMHmgww (envelope-from ); Tue, 02 May 2023 12:10:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 49720d1c-e8e2-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683029410; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RMQn8Yiv0jCwQnecK3T9cC+8gstSs8Pnq7WDZyHBVNw=; b=UthapKSln5sVxc4P6W4BSa2qf1rvyEffS6HG2itfjchsaqorftKG30uqY4qHygD7foz2Sd qDX60C23glOf63Dt33mUz/OjzAGUAEkfM3DRKtIV4jLuqobQl4wBPaZynsRN7Is2PLb0tE yKXtXL2TX9qODXdqlLZNvDgVEnbQqZM= From: Juergen Gross To: linux-kernel@vger.kernel.org, x86@kernel.org Cc: mikelley@microsoft.com, Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , xen-devel@lists.xenproject.org Subject: [PATCH v6 05/16] x86/xen: set MTRR state when running as Xen PV initial domain Date: Tue, 2 May 2023 14:09:20 +0200 Message-Id: <20230502120931.20719-6-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230502120931.20719-1-jgross@suse.com> References: <20230502120931.20719-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When running as Xen PV initial domain (aka dom0), MTRRs are disabled by the hypervisor, but the system should nevertheless use correct cache memory types. This has always kind of worked, as disabled MTRRs resulted in disabled PAT, too, so that the kernel avoided code paths resulting in inconsistencies. This bypassed all of the sanity checks the kernel is doing with enabled MTRRs in order to avoid memory mappings with conflicting memory types. This has been changed recently, leading to PAT being accepted to be enabled, while MTRRs stayed disabled. The result is that mtrr_type_lookup() no longer is accepting all memory type requests, but started to return WB even if UC- was requested. This led to driver failures during initialization of some devices. In reality MTRRs are still in effect, but they are under complete control of the Xen hypervisor. It is possible, however, to retrieve the MTRR settings from the hypervisor. In order to fix those problems, overwrite the MTRR state via mtrr_overwrite_state() with the MTRR data from the hypervisor, if the system is running as a Xen dom0. Fixes: 72cbc8f04fe2 ("x86/PAT: Have pat_enabled() properly reflect state when running on Xen") Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky --- V2: - new patch V3: - move the call of mtrr_overwrite_state() to xen_pv_init_platform() V4: - only call mtrr_overwrite_state() if any MTRR got from Xen (Boris Ostrovsky) --- arch/x86/xen/enlighten_pv.c | 52 +++++++++++++++++++++++++++++++++++++ 1 file changed, 52 insertions(+) diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c index 093b78c8bbec..8732b85d5650 100644 --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -68,6 +68,7 @@ #include #include #include +#include #include #include #include @@ -119,6 +120,54 @@ static int __init parse_xen_msr_safe(char *str) } early_param("xen_msr_safe", parse_xen_msr_safe); +/* Get MTRR settings from Xen and put them into mtrr_state. */ +static void __init xen_set_mtrr_data(void) +{ +#ifdef CONFIG_MTRR + struct xen_platform_op op = { + .cmd = XENPF_read_memtype, + .interface_version = XENPF_INTERFACE_VERSION, + }; + unsigned int reg; + unsigned long mask; + uint32_t eax, width; + static struct mtrr_var_range var[MTRR_MAX_VAR_RANGES] __initdata; + + /* Get physical address width (only 64-bit cpus supported). */ + width = 36; + eax = cpuid_eax(0x80000000); + if ((eax >> 16) == 0x8000 && eax >= 0x80000008) { + eax = cpuid_eax(0x80000008); + width = eax & 0xff; + } + + for (reg = 0; reg < MTRR_MAX_VAR_RANGES; reg++) { + op.u.read_memtype.reg = reg; + if (HYPERVISOR_platform_op(&op)) + break; + + /* + * Only called in dom0, which has all RAM PFNs mapped at + * RAM MFNs, and all PCI space etc. is identity mapped. + * This means we can treat MFN == PFN regarding MTRR settings. + */ + var[reg].base_lo = op.u.read_memtype.type; + var[reg].base_lo |= op.u.read_memtype.mfn << PAGE_SHIFT; + var[reg].base_hi = op.u.read_memtype.mfn >> (32 - PAGE_SHIFT); + mask = ~((op.u.read_memtype.nr_mfns << PAGE_SHIFT) - 1); + mask &= (1UL << width) - 1; + if (mask) + mask |= MTRR_PHYSMASK_V; + var[reg].mask_lo = mask; + var[reg].mask_hi = mask >> 32; + } + + /* Only overwrite MTRR state if any MTRR could be got from Xen. */ + if (reg) + mtrr_overwrite_state(var, reg, MTRR_TYPE_UNCACHABLE); +#endif +} + static void __init xen_pv_init_platform(void) { /* PV guests can't operate virtio devices without grants. */ @@ -135,6 +184,9 @@ static void __init xen_pv_init_platform(void) /* pvclock is in shared info area */ xen_init_time_ops(); + + if (xen_initial_domain()) + xen_set_mtrr_data(); } static void __init xen_pv_guest_late_init(void) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue May 02 12:50:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 12:50:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528574.821905 (Exim 4.92) (envelope-from ) id 1ptpSX-0004Zq-Aj; Tue, 02 May 2023 12:50:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528574.821905; Tue, 02 May 2023 12:50:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptpSX-0004Zj-6t; Tue, 02 May 2023 12:50:21 +0000 Received: by outflank-mailman (input) for mailman id 528574; Tue, 02 May 2023 12:50:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptpSW-0004Zd-9l for xen-devel@lists.xenproject.org; Tue, 02 May 2023 12:50:20 +0000 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [2a00:1450:4864:20::32b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e4cd1940-e8e7-11ed-b225-6b7b168915f2; Tue, 02 May 2023 14:50:19 +0200 (CEST) Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-3f3331f928cso21879345e9.2 for ; Tue, 02 May 2023 05:50:19 -0700 (PDT) Received: from smtpclient.apple (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id k7-20020adff5c7000000b00306299be5a2sm7086099wrp.72.2023.05.02.05.50.17 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 May 2023 05:50:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e4cd1940-e8e7-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1683031819; x=1685623819; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=s4U/e2ueVkIftF9kI3geNYcSUvjsAJfgMH+focDaLwM=; b=UPOW42jY0e1qYe7ptHYUn3nvE7C5mg6br2zNrp98TtVWAIjZhy4iQMly9PBtff3hdX sCR4fEysID5v63m1d4qKaGWYFbR6Ni+0AcMXJYgRVDm6H+gzGZSwZ5naDV59fYyhI7Id 6xplGXvepfZjOlmKvq1xdCSe1EeEYWefmpfUI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683031819; x=1685623819; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s4U/e2ueVkIftF9kI3geNYcSUvjsAJfgMH+focDaLwM=; b=HO2epBH+COFH+PFJg/kMMdpOLP/Ri/AXN2gnxm+0COpvSF3DOoelZxCmjHa6VVor1c Z2Vx9K9nQqxx8BsK7AJtXQoGBjeRnE70yQMLVBm5feoRRtUVRH72UWcPEkf2NpI3TF/H InrZrF4ncJg6WKMYFnBYFF8CrtsLGIv/ijkyyqHVpcBWHa+2w8YchLkxSh9GHofepIKG Fe/tpS9NU4ZH81/AxZaux/WYLZmf8betuzoH4qHwgCk9Nn0M9bxeAmdYhsYqmZWKdNYj dvfF+bYan9frYYVV1aPZb5yO1m6ACs4L6UOUbxp0ZU+tPHrW0RADbA/8yDNzR0PZ3OI0 oKDA== X-Gm-Message-State: AC+VfDy6Ux+sXPqooeX37IpcLmMF0ttq/GFnF8FxBsnWIkl4iOhg8vmH 9r3BSXT+zYD3rHiTHpxWliPW3A== X-Google-Smtp-Source: ACHHUZ5yU5MA+8UsxHIog3VNPIQHEYE6JqjPOldI32Apd5dXnAARkntx6nmRfVrN6gYiWxldQdM3MQ== X-Received: by 2002:a1c:7c19:0:b0:3f1:8c5f:dfc5 with SMTP id x25-20020a1c7c19000000b003f18c5fdfc5mr12794192wmc.39.1683031818759; Tue, 02 May 2023 05:50:18 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: [PATCH v3 1/3] tools: Modify single-domid callers of xc_domain_getinfolist() From: Christian Lindig In-Reply-To: <20230502111338.16757-2-alejandro.vallejo@cloud.com> Date: Tue, 2 May 2023 13:50:17 +0100 Cc: Xen-devel , Andrew Cooper , Wei Liu , Anthony PERARD , Juergen Gross , Christian Lindig Content-Transfer-Encoding: quoted-printable Message-Id: References: <20230502111338.16757-1-alejandro.vallejo@cloud.com> <20230502111338.16757-2-alejandro.vallejo@cloud.com> To: Alejandro Vallejo X-Mailer: Apple Mail (2.3696.120.41.1.1) > On 2 May 2023, at 12:13, Alejandro Vallejo = wrote: >=20 > xc_domain_getinfolist() internally relies on a sysctl that performs > a linear search for the domids. Many callers of = xc_domain_getinfolist() > who require information about a precise domid are much better off = calling > xc_domain_getinfo_single() instead, that will use the getdomaininfo = domctl > instead and ensure the returned domid matches the requested one. The = domtctl > will find the domid faster too, because that uses hashed lists. >=20 > Signed-off-by: Alejandro Vallejo Acked-by: Christian Lindig I mostly care about the OCaml bindings - looks good to me. =E2=80=94 C= From xen-devel-bounces@lists.xenproject.org Tue May 02 12:54:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 12:54:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528578.821914 (Exim 4.92) (envelope-from ) id 1ptpWg-00059x-Qk; Tue, 02 May 2023 12:54:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528578.821914; Tue, 02 May 2023 12:54:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptpWg-00059q-OF; Tue, 02 May 2023 12:54:38 +0000 Received: by outflank-mailman (input) for mailman id 528578; Tue, 02 May 2023 12:54:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptpWf-00059k-OE for xen-devel@lists.xenproject.org; Tue, 02 May 2023 12:54:37 +0000 Received: from sender3-of-o58.zoho.com (sender3-of-o58.zoho.com [136.143.184.58]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7c5b8517-e8e8-11ed-8611-37d641c3527e; Tue, 02 May 2023 14:54:35 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1683032061497608.2626436346678; Tue, 2 May 2023 05:54:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7c5b8517-e8e8-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1683032063; cv=none; d=zohomail.com; s=zohoarc; b=l2XLGY8zcqX3D8x898GT/KRbeRTOt8BCSGyucgps7mCnsDadj6hWr0CfO/hz5mK2Q/sckMfz74mskfOoD2g9H8RGYfUzV8PbOcWO7HekAUawfjwnYFUElJ6I2AtD3/bVsDLYMaMNjLy1HcsYuFEHkfWilNF7/23bhOPVwjXh47c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1683032063; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=xgJzjqiynfOW2SuuA1mzX5zeflmOYIFlHVIvrgPOF+E=; b=YZXVPBMgHa5R5rXlJvRTvpU6EtuCJulZEHyexO3BSj0lMqMib4kWO/FuA+bJTzv5SJVLGfM9nRUYMVn3YmQT4mlShQqu3kqU9Bx5l8KRF28KFs3jzueaJTZn/NH3AA4Z2Pn3FewFZN3yiCmQtiOIAfSW/nTWTcgyDIXl/Qlv0xM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1683032063; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=xgJzjqiynfOW2SuuA1mzX5zeflmOYIFlHVIvrgPOF+E=; b=s+2EMRcww57hKhnh0PlnkU/6CiOICPQWsr7Y/OzuojHyQG7qGjIhmH8WMS/j2w4L vRml+47d2iEIfSscqyxqdDRrRQ7cJEvwC+6wmyHRE9oA1FWLPEN3ORjqqwfPkwQihHD IBbDDkdr2aD3WQoT89j5q3HZE8H22XMzGU8f31uE= Message-ID: Date: Tue, 2 May 2023 08:54:19 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <26064a5a-423d-ded5-745e-61abb0fa601c@suse.com> <600c8c62-5982-ec7e-7996-5b7fbfb40067@apertussolutions.com> <22b2e03c-ac5e-915a-78a2-0a632b09a53a@suse.com> From: "Daniel P. Smith" Subject: Re: [PATCH] sysctl: XSM hook should not cause XEN_SYSCTL_getdomaininfolist to (appear to) fail In-Reply-To: <22b2e03c-ac5e-915a-78a2-0a632b09a53a@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 5/2/23 06:59, Jan Beulich wrote: > On 02.05.2023 12:43, Daniel P. Smith wrote: >> On 5/2/23 03:17, Jan Beulich wrote: >>> Unlike for XEN_DOMCTL_getdomaininfo, where the XSM check is intended to >>> cause the operation to fail, in the loop here it ought to merely >>> determine whether information for the domain at hand may be reported >>> back. Therefore if on the last iteration the hook results in denial, >>> this should not affect the sub-op's return value. >>> >>> Fixes: d046f361dc93 ("Xen Security Modules: XSM") >>> Signed-off-by: Jan Beulich >>> --- >>> The hook being able to deny access to data for certain domains means >>> that no caller can assume to have a system-wide picture when holding the >>> results. >>> >>> Wouldn't it make sense to permit the function to merely "count" domains? >>> While racy in general (including in its present, "normal" mode of >>> operation), within a tool stack this could be used as long as creation >>> of new domains is suppressed between obtaining the count and then using >>> it. >>> >>> In XEN_DOMCTL_getpageframeinfo2 said commit had introduced a 2nd such >>> issue, but luckily that sub-op and xsm_getpageframeinfo() are long gone. >>> >> >> I understand there is a larger issue at play here but neutering the >> security control/XSM check is not the answer. This literally changes the >> way a FLASK policy that people currently have would be enforced, as well >> as contrary to how they understand the access control that it provides. >> Even though the code path does not fall under XSM maintainer, I would >> NACK this patch. IMHO, it is better to find a solution that does not >> abuse, misuse, or invalidate the purpose of the XSM calls. >> >> On a side note, I am a little concern that only one person thought to >> include the XSM maintainer, or any of the XSM reviewers, onto a patch >> and the discussion around a patch that clearly relates to XSM for us to >> gauge the consequences of the patch. I am not assuming intentions here, >> only wanting to raise the concern. > > Well, yes, for the discussion items I could have remembered to include > you. The code change itself, otoh, doesn't require your ack, even if it > is the return value of an XSM function which was used wrongly here. I beg to disagree, not that you could have, but that you should have. This is now the second XSM issue, that I am aware of at least, that myself and the XSM reviewers have been left out of. How and where the XSM hooks are deployed are critical to how XSM function, regardless of how mundane the change may be. By your logic, as the XSM maintainer I can make changes to the XSM code that changes how the system behaves for x86 and claim you have no Ack/Nack authority since it is XSM code. These subsystems are symbiotic, and we owe each other the due respect to include to the other when these systems touch or influence each other. >> So for what it is worth, NACK. > > I'm puzzled: I hope you don't mean NACK to the patch (or effectively > Jürgen's identical one, which I had noticed only after sending mine). > Yet beyond that I don't see anything here which could be NACKed. I've > merely raised a couple of points for discussion. I will comment on Jurgen's patch. From xen-devel-bounces@lists.xenproject.org Tue May 02 13:02:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 13:02:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528583.821925 (Exim 4.92) (envelope-from ) id 1ptpeD-0006jK-In; Tue, 02 May 2023 13:02:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528583.821925; Tue, 02 May 2023 13:02:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptpeD-0006jD-Fo; Tue, 02 May 2023 13:02:25 +0000 Received: by outflank-mailman (input) for mailman id 528583; Tue, 02 May 2023 13:02:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptpeB-0006j7-Dc for xen-devel@lists.xenproject.org; Tue, 02 May 2023 13:02:23 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 924f5aaf-e8e9-11ed-b225-6b7b168915f2; Tue, 02 May 2023 15:02:21 +0200 (CEST) Received: from mail-bn7nam10lp2106.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.106]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2023 09:02:14 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB5910.namprd03.prod.outlook.com (2603:10b6:510:33::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 13:02:08 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb%4]) with mapi id 15.20.6340.031; Tue, 2 May 2023 13:02:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 924f5aaf-e8e9-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683032541; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=MJ3EQEfCQv0MKz4apU7nZmyKA8cw+MX0Adgk9Yd37hU=; b=cauv5k62W3DD7EJwjqPC6f0J1u3UjJI/9uu4MRkDQk8EKqIQYdhNH3Kz sYw+7HDjdI/aikcJQwIMJk9t92u7bG96zM2qHBgWn30fq+HSPOuYFl11T O2GdRlXFs6B/4GCetqlxBeYi79aUycAqfCObYQ9ewLP3soRew4O12NHnq c=; X-IronPort-RemoteIP: 104.47.70.106 X-IronPort-MID: 110012958 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:fTJgQ6onyDZ4OeuKR6Znnx7yMzFeBmLNZBIvgKrLsJaIsI4StFCzt garIBmCaPjcYzShfN52OoXl8UxSv5LdydE2TVFv+y48Hi4Q9JuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WJwUmAWP6gR5weDzyNNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAAA/bgG93ead/JmceuBs19k6A5DHH7pK7xmMzRmBZRonabbqZvySoPV+g3I3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3j+CraYKLEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXhr6Yy2QfCmzx75Bs+EmX4n92/gxKCWIgYI GsQxzsQsJgN6xn+JjX6d1jiyJKehTYVX9dSGus28gbL1KPQ5wubAUAPSjlcZJots8pebSwn0 BqFks3kARRrsaaJUjSN+7GMtzSwNCMJa2gYakcsUg8t89Tl5oYpgXrnUtdmOL64iJvyAz6Y6 zKFti8lnJ0IkNUGka68+Dj6bymEo5HISks/4FrRV2f8tgdhPtf9Ocqv9ETR6utGIMCBVF6ds XMYms+YqucTEZWKky/LS+IIdF2028u43PTnqQYHN/EcG/6FohZPoag4DOlCGXpU IronPort-HdrOrdr: A9a23:SRqh6K5UbchOTRt3MgPXwAzXdLJyesId70hD6qkQc3Fom62j5q WTdZEgvyMc5wx/ZJhNo7690cq7MBHhHPxOgbX5VI3KNGXbUQOTR72KhrGSoAEIdReeygZcv5 0QCZSXCrfLfCVHZRCR2njFLz4iquP3j5xBnY3lvhNQpZkBUdAZ0+9+YDzrdXFedU19KrcSMo GT3cZDryrIQwVtUizqbkN1OdQqvrfw5evbXSI= X-Talos-CUID: 9a23:GsyM9G4xLmZaOMAfO9ssxHwUC/5/dlbh51DgKk/pFH9GEZG2cArF X-Talos-MUID: 9a23:6ElAhgTZQyCLb9FuRXSrunJcEMFhv5itUgcGtpE7qveZBRNvbmI= X-IronPort-AV: E=Sophos;i="5.99,244,1677560400"; d="scan'208";a="110012958" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EdvJ2/xy2FrnRNNV1e0isfo+yqma3tE6UiViMjf+Yl34C9XW+QY75mvPzr0dEgK7WmTHgdrGBFZ17llgiJZ2mUxsHvHvWsVkoN1lLaNCPiHHKejfiNQ8ctYtWnndIjqBFPQZsVLtnXaPDF7Gu7Q4cAHHpTzi7Gl9pDEu1m9HgUOFQUXirIbuGaYQyO6ntmdWervTnTYpQL/aUQJV/S+ljUpm87VftsjjuzmdK75GpPbthzbd7QkRPoq39ybMGkXOVxcUj0VflDQhyqlSy1PzaX5r9or7wLXa+uC5j4JHQD2uz4S4JKg4HJmiX3I0M0zM9Kn71qBb4cU6IlQ77dVhJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HoYYC1NfbPSJoii0IlkINfgKg6sGhzrH7DPoIeM7umk=; b=ZOH+s7ZHBUiqfAJz98fb8jAfLxHfFNXWRm95iOpJgtEblOVVYwH+tQ656SxZXxM0XekQPvCa/Q9eHYe1HT/tuUuY+d71kPXVSk+4jCXhKo/UGyHBq59SSMMRYWZfm4/oh7yTlVpfGBJWN5IYYs9xuCvUGYgSW3Nws+iJJti1xj9myHi8pyc2OHvXD5XmYmmtQnC0yVqwsGoJFZaRECykNvgvHHrcCbYUOgle2uda0BAHhlFqjuK4vc2BD0R4REfRY/fji7OS7vGyyFxkARLGjUDVvD+GGZOJyIDUILLVta+6w3m1XRRd0iOnCJOtPLK+N+x0XoLU+1DmcxTpD+macQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HoYYC1NfbPSJoii0IlkINfgKg6sGhzrH7DPoIeM7umk=; b=nMSWzQJEsWtgWcnrWNDX/6+RagB4AN4xz35D3xFDUrbx2WDQrQJFTrp+zi3wTuQ6ZGpy9UyRbXVDmnoJJdeM09VJcDewEn6yPVSRBBRsjxB57SgThoMPf9+Tan1xqFZ1c9x8S+TALFbYWmenvH8y/soLwD1NJsQf5CNa+Viw6Bc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Tue, 2 May 2023 14:02:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: Andrew Cooper Subject: Re: [PATCH v3 2/3] tools: Use new xc function for some xc_domain_getinfo() calls Content-Language: en-GB To: Alejandro Vallejo , Xen-devel Cc: Wei Liu , Anthony PERARD , Tim Deegan , George Dunlap , Juergen Gross References: <20230502111338.16757-1-alejandro.vallejo@cloud.com> <20230502111338.16757-3-alejandro.vallejo@cloud.com> <6450f182.050a0220.6009b.3ca5@mx.google.com> In-Reply-To: <6450f182.050a0220.6009b.3ca5@mx.google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0667.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:316::20) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|PH0PR03MB5910:EE_ X-MS-Office365-Filtering-Correlation-Id: 3bdb1618-61f1-4af7-efc7-08db4b0d6f33 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: geco7vsJQSLOKdRCwwEedV3eoi6K06ThRRwec90d7TJpVDbkCAo9hGvIVyDYTC0ENNvh3GzX0gcx+mTAg+RrEi1uHl7JO5FqyijcUjoi6S5Y60ar26gL/EdAzpQWB9HZung1GzS+Anq2JJBK0ZNEGIUG2MqYaqdml12wObCeLfTcR8eC8+H2t63o2Yrhvz4eZzeVFsbibogBh22iM3x3VvKwe88vTPVPAc07XmB7Zwb9/JY+oTA4+yvdl8HOQ/ZFLpkcfq5vhLF4xy4jEPEInsEZIYmy4gkUCq+GzDx6ywwkRk5fnditMbijnxWPyr2mow7wJfwdtHfFjh2mkBwwDo1UGdzedOnnNUiOBYXtSVS7c8QrLZNLPqggXiUhxmnsrNQFyLTbKRWScRYli5EPAU1Lq6R+DwjpYoOWLArbyBVbOURIC77sXHV9XdnODq/PnIlsMQD6DCt231OYy6GjGpy6B2ggT3rBTTQ7IN2gfbVgsODGVOOIQRtW5YKuN/UAU6YL3ZY9BU225or7TaKdbU8cau5pyg4gb6ISzEYZEOJDcev1jGdz4FzGCktgsvpMNPMAzxiw42vAR75pH5mbF7xW7hj1x8rIXWf/QbPnnQ9soAu3K/qOz1dWsyhsypc3iNj0EMTZf1YwPigMjOve5A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(136003)(396003)(376002)(346002)(39860400002)(451199021)(36756003)(31686004)(2616005)(6486002)(6666004)(4744005)(2906002)(110136005)(478600001)(6512007)(6506007)(26005)(186003)(53546011)(54906003)(316002)(82960400001)(41300700001)(4326008)(66476007)(66556008)(66946007)(5660300002)(86362001)(8936002)(8676002)(38100700002)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Mk5qU0hIaE5jcmV6WDJsdkhXZ2g3Skh4Qi9wUGxCbHJVS3hEZStNRlZybExt?= =?utf-8?B?Umg3OFhuYmgwMk0xUHpZMUh4ampkMzZsSysxMlJTN1lBQTlmc00rTTlOOHJj?= =?utf-8?B?bldDck1OR3V3SVNWSC8vZWh6SldleVlkemxxWU5FZXVBd09sYTIzSkh2Q3I1?= =?utf-8?B?KzF2cFc3aGdQeXprdDVVT3dzUW8yUllVaTdZS0U4SExTQ0RqbWJHQlRzTFll?= =?utf-8?B?cVF0R3Fhc1l5QjRnQytvcndaYVQxdDQyd2pUR3JtSS93Yk42NjJZbTFxTlpm?= =?utf-8?B?aUZ2Y3d4MW5RcjQzUDlNV2VaN21LWmdPbnExa2FneVh2MWJHb2Z2cXdWWjMz?= =?utf-8?B?L1pMVGdZK25YWTFJaWY3VkIzVVZURDhzVHdFREdidjBUekh0c3NhdEN0bFU3?= =?utf-8?B?S3VQV1VjbWp1eGNlV3c3TytaMzFobUlyejZackQ0UFpmVkk2ZEoyMjNLcVk3?= =?utf-8?B?ZjRRSE90bENjeXAwWUNSOTVYY1dmd3FEWm9qNVc1V1EvekcyaUloM1pqWVFp?= =?utf-8?B?bENMaDB2dEozcGo2Wk5OUlhNTnNUUVhEWmVFUm1idmZLOHJ3MzRzNXdpQXQ0?= =?utf-8?B?T3dFd2M2YXV2ZGVWdlV4Y0g4cWlHK0wvUWZZTWlsdWtXVTdraTNBc0JaeDZ3?= =?utf-8?B?UlUwVHprSTBnYnFTL1J6bktKM0JEYW5BNXlqdGl3K3pDSXEzcUt0VFZtdUZi?= =?utf-8?B?UWZFZUdSSDhCSzRhVXczaGNLNG0rSitsZUlPMUk1WU5SSmpIMzdDcVBCRytZ?= =?utf-8?B?SE0xeFdSMTlzY0VreTRkaFFSQjVmUEYzUnB3aFExTTMrNkFMbkk1bTcxaGZn?= =?utf-8?B?Z3pJK2RTbkJMd25lNGp4Y2JCaEMyK3dSWmpiS1REYUdRNTBFMUZ2Q2xhSUhC?= =?utf-8?B?ZkNVZ3ByekZRMWdidWRaeDBHS2NrMkszOGp2dWJPYVN5K21lUTdRSnozK0hz?= =?utf-8?B?SU03VVczV05tUVlFVWloaERkOXNlTXlhKysrNTltekZkVHN3TzIyOGt3MU5p?= =?utf-8?B?dlFFODBEOSt2YjZWT1dFT1ROTFhZa0VzTXRwanI5Ujgza1Z3bGRFckErQlRy?= =?utf-8?B?K1RvSkx2Tld2WXpiSU1jaldaeG9YNVJUZ3VnbFU2ZnkyQ3VwOVFidnFmMDZK?= =?utf-8?B?TlpKVjllcjliMGJ3ZjVLMlNsdUxNTWJVY3lId3VjQm9IN3Vxd3Q4UmhOV2o4?= =?utf-8?B?a3RlU2drZytLWEQvMElFNWdwQkxxNkNxTmZPSzYyVHYvbElHZVoyekJsOHVq?= =?utf-8?B?TFE3UDFxNzVWMWNFN3N0V3B5a09QUm5ZS0w0OVBCR2ZEY2NycSsxMUdFRTdE?= =?utf-8?B?UjRsQ1A0OFZ2S2g5cTVNSHRrZmFNeDhvT2lzTXZ0a2hWYTluS24wTXROWnFt?= =?utf-8?B?bVE5L3hqZkE0WEVPWGVpb01Xai9XUzdKelBwdUZieWtBdUMyMDNGQUNlV0dv?= =?utf-8?B?RHBwTzhvSDVJTi9KUVJIeVE3ZnZJL28zY2xObWFKeHkxMXpXY2Y0YlFVb1VZ?= =?utf-8?B?bkVqV0EyNUVZZnJCYWhDemdKajUzaktPZEhBYXdvRjZGanBkYUZHbWZ5dm1w?= =?utf-8?B?Zk02QWh6eUdWT0hvZjFaenNWWkliYmk3a1BjVjJ0STZySlR2MTdxMHBCczY1?= =?utf-8?B?VmsvSXBRbFFFeWkxK1Z3NEJWeWxtcmVnZVh3R0lBQ0ZzcVFLQVY5bWZ2Nzdw?= =?utf-8?B?OGtrcVlPL1h3Znl6bCtobjVGcm9rVHhZWDJGNlZuV3UvbTcrL1RPNmxuYUEv?= =?utf-8?B?RUFGRGdJcU9JUVgrVEZxcncydFl3MnZ1dVduRnNpQkhPZ09MYjg3eWZOaVZM?= =?utf-8?B?WEdWT3JsQ09ZL011N0ZQamphUjdQTXVXYzNVUE9UdnZsbXJIdmU0M244c3JJ?= =?utf-8?B?V2liTlVyeUVRRnh3cDIrekJSZkxzUmVmYmlwVzdET2ViK1h0clkrODZZNnF6?= =?utf-8?B?T3hDK3d1R1ZNYndnVFFta1lUSXprRlRDa3gzdG9aY3BaY3c3dnZScE5SdnAy?= =?utf-8?B?dHBuYUFlL0JMSGtOWWcveWdXQmxNWEtObXNreUNzTDFKVHUydURBYXNsVTcx?= =?utf-8?B?SHU5bjkwa2NTd0h6WVRDd3JrZjNMLzYxcy92cW1HbnZpU2k3elNRWXFGUUtz?= =?utf-8?B?dlpTMnc5dlFmbmJuampHejY3dW1odXdsT0lYcmlNakNBWXh6QisyYlBoOVli?= =?utf-8?B?alE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: xZfK6dbcj7T8DNJOCSXMseZmQIoFjiIuAQJpmYXAjWaCOMOsMrV5TM36sIkDtzMPbFFW8mlXpmEq7nmOYLG8lx0U7FuLYrk7LQKN5ItWv5Op2VKBpQ9oorQrdACiXCIOQkm2DoyZO/r0aKADTP4Ihtb2MFJOnYa8CbZZcQlik6K9wQlxAgyzdtPydula16aZcgtCu+d0vpvxCsM/ljqUIMb3OwKj7RJReooiuvzpTy6f9BUO78jwnwa3+dUeVOlejEiakMtgbSr1ka9v5QuBQIeP5llN1MMjqeWPBSch5YstR63RTF+m1A16enmdAPeqarBwNwl4bJcc2SbTWMXKHgeezI9+5N3pY6CHjBKXaEF3c7MqZ/xb2m9rsRWLjC3QuQ6PV0t4adLECdfsuLrhlphMfsqNKBc2L3Je6wCO35rbzZ11HkSDbGv1r0jmb2bOA9P4O0ZUGF153Elq0p1OU2iwYi18jF3y9VHRnJoRKoO5g7svz8/N/TItLvcmO3HGOez6EiNHVNfXVpRSAYq3DrgPWCI8FSTFagjRhkP7DaU1ma/+0O0fzEo4Z5kGLd6xVcRYK//lKIPThrBH1oqSbxEdAIn2bCY/2V3jz6j07toGZaOF6nEiIa8d+d2WuSRrJY6SBR1JhVn6sAu8AuFldaGO3DgrPq+qlTvWqamIFvoSeKjj4kDFxqBwHASdDa0cbtUueIoW/AjvPy5JhXRkoF3pobw7AxHLj1t+mz95/H+E7unm28P1IS/TnINO+74yXIl4ZRDnE0M/VE4IrE/EA0vv+swvVLVtLVQaggjXJj7qO4a3eeYAGhWxH59Ij0ZsqGu+vle6+6d+NmHYg99BX0nlOgYwhW3iDKelgFYcYw4= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3bdb1618-61f1-4af7-efc7-08db4b0d6f33 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 13:02:07.8685 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ihLPt+lY4UHNfK/L0uConxJSUceYgoPSg813WrdkE0pD8JZ32+cxTnQPleNgyGkUhjaHhcLmxdTWwFZ7lkYw3MdxjQsyB/LKR4ol3iSOZD0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5910 On 02/05/2023 12:18 pm, Alejandro Vallejo wrote: > On Tue, May 02, 2023 at 12:13:37PM +0100, Alejandro Vallejo wrote: >> Move calls that require a information about a single precisely identified >> domain to the new xc_domain_getinfo_single(). >> >> Signed-off-by: Alejandro Vallejo >> Reviewed-by: Andrew Cooper >> >> --- >> Cc: Andrew Cooper >> Cc: Wei Liu >> Cc: Anthony PERARD >> Cc: Tim Deegan >> Cc: George Dunlap >> Cc: Juergen Gross >> >> v3: >> * Stylistic changes that fell under the cracks on v2 >> * Reinserted -errno convention from v1 that had been >> removed in v2 > Mistake here. It's _NOT_ supposed to have that "Reviewed-by" Nevertheless, v3 now looks good. Reviewed-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Tue May 02 13:03:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 13:03:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528585.821934 (Exim 4.92) (envelope-from ) id 1ptpep-0007Ac-S4; Tue, 02 May 2023 13:03:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528585.821934; Tue, 02 May 2023 13:03:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptpep-0007AV-P0; Tue, 02 May 2023 13:03:03 +0000 Received: by outflank-mailman (input) for mailman id 528585; Tue, 02 May 2023 13:03:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptpeo-00078T-UW for xen-devel@lists.xenproject.org; Tue, 02 May 2023 13:03:02 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a96bedf1-e8e9-11ed-8611-37d641c3527e; Tue, 02 May 2023 15:03:00 +0200 (CEST) Received: from mail-bn8nam04lp2048.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.48]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2023 09:02:57 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 13:02:55 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec%3]) with mapi id 15.20.6340.031; Tue, 2 May 2023 13:02:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a96bedf1-e8e9-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683032580; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=93UXsglR4TVhZ4ze/hMN0CfXqU1kmOtQG/yfKJ3p2q4=; b=OuzXlj2A7M/hJ7GG6Irp1DtyKOJmNOiLOqOof94LYak4l/2FwyYjrVDf DM9ZnrgdtP08i7OU0KksZ/1r10RzyLQjy+tu4yuNRVsuXVgFUfgKeEpU/ 57WXj/T50j9+WyD1i26b/gPT5ZnMZfm5CvuCPJtWfHWU1ZZvXBpcRHB5b Y=; X-IronPort-RemoteIP: 104.47.74.48 X-IronPort-MID: 107590529 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ibHLBaBbp/QqzxVW/w7iw5YqxClBgxIJ4kV8jS/XYbTApGsg3zJRz 2IXXD3TPvzfamf2co0iaNnjpE9Tu5OHzNFnQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFuspvlDs15K6p4G5A5ARkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwo9pLI0Fn8 uwieBMqYhPYtsnn7amdc7w57igjBJGD0II3nFhFlW2cJ9B2BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTK+exrswA/zyQouFTpGMDSddGQA91cg26Tp 37c/nS/CRYfXDCa4WPdrS/93rKVzEsXXqoyKq3gz8BR2mer/TQKIUQyS36xjKmQ3xvWt9V3b hZ8FjAVhao4+VGvT9L9dwalu3PCtRkZM/JPF8Uq5QfLzbDbiy6JC25BQjNfZdgOsM4tWSdsx lKPh8nuBzFkrPuSU331y1uPhTa7OCxQJ2lSYyYBFVcB+4O7/NF1iQ/TRNF+FqLzlsfyBTz73 zGNqm45mqkXiskIka68+Dgrng6Rm3QAdSZtji2/Y45vxloRiFKND2Bw1WXm0A== IronPort-HdrOrdr: A9a23:hjQZhaBsMXwhdGblHela55DYdb4zR+YMi2TDt3oddfWaSKylfq GV7ZImPHrP4gr5N0tOpTntAse9qDbnhPxICOoqTNCftWvdyQiVxehZhOOP/9SjIVyaygc078 xdmsNFebnN5DZB7PoT4GODYqkdKNvsytHXuQ8JpU0dPD2DaMtbnndE4h7wKDwOeOHfb6BJaa Z14KB81kKdUEVSVOuXLF8fUdPOotXa/aiWHSLvV3YcmXKzZSrD0s+BLySl X-Talos-CUID: =?us-ascii?q?9a23=3Ak5uMwGpku/chGS9jrSdVGXbmUZkZTl/95XDAGR+?= =?us-ascii?q?bLmpqE4y+GHKL3poxxg=3D=3D?= X-Talos-MUID: 9a23:TuiK5wrYYxEIVFYsK58ezxFcJJ9R3Z/0Mng2yYwv4u2aECZdax7I2Q== X-IronPort-AV: E=Sophos;i="5.99,244,1677560400"; d="scan'208";a="107590529" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EdJA6QaxrgoHJnqycfxY331CoBQSLDPAmChLgX05HhhBiKZ05E0U6CUwAcA9fHO9kMKUtBkPrNE7J9InYr5ojKiI8xp77OL1pDmaCe3LbSqDRPQ0SE/EnojlH23Nplhpr5EOaXW2A/0Jdfzz1ckfqBy8PvIQ2iNgAXOE8RRFvxdGuGoh6ulELC4MZIkYgF4T9w/SaAo6OZC39li4eKBkjseEOzvGPfUCWfQq4nP2UP/UZVB58DQcMpVVReWWU/1akvzgJwmIVrgaOM+tU/478tnRWyUnC01uteEtqkRhOGWfQP0PD7VUtb0eERTdb72dykf0Imtx2sHQT6vkrbZh/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WHooOrtZ455hB4epaiuSklactcjPB2cz/QE9dt8MMoM=; b=bqx9oLbUw770c78j8DOGlmy16Dd/pAICUV9YKU06py1+loQLua4rrmTtfqi8GbRxUxwpuJCZ9kc38emPlzsBXyCMx9hpQVO4rQfRUQEEpWaYIr/lztSiGjB075ZYoC7zFMTzjnU/zJ8CoPRagzJHxqPK1cCTpJyPgaPONtZ/L/NtAZo90zChzjTKq33NtuiI0FquL958wRHbg7K90GMefCsB2+U8TIzMSk46L5HhrzP3+P8pI5/n+l67CB9vMWyI3+1eBkvgB64l2ly254DSatg7o0VibYvjOOCtJ97Pq1fnX5dVYGK5bXccSlah/uKb1KgGpfBOob0tzwpxTdsdWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WHooOrtZ455hB4epaiuSklactcjPB2cz/QE9dt8MMoM=; b=IQ34MWdPjYtBK7A6kMxrrpqKnYYkn3sdC55zxdyAr5/j39wcWQ2hEL2vzz/trjOOB9X0WWDkuKLs4Yd0Pa2oSQomEx02P9TsMJMQluvSeqrQHPidCvY3KMM5sOCummqZTH16oLh3kDc2TBPbZxnHBKq8uRDkv9BEcta2UH0KWFY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 2 May 2023 15:02:48 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH 1/2] x86/head: check base address alignment Message-ID: References: <20230502092224.52265-1-roger.pau@citrix.com> <20230502092224.52265-2-roger.pau@citrix.com> <89389465-f32c-7dfe-f62b-b957e2543cb8@citrix.com> <068ad06b-d766-4fc7-6bbc-289911441ee7@suse.com> <6aa9f2a5-bb57-4c56-84b8-5bc63b47cfa4@suse.com> <269b0894-5fe6-fd71-9f6d-24e3b08973cf@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <269b0894-5fe6-fd71-9f6d-24e3b08973cf@suse.com> X-ClientProxiedBy: LO6P123CA0003.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:338::8) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|PH0PR03MB5669:EE_ X-MS-Office365-Filtering-Correlation-Id: 22a69cfa-8c4f-47c0-5056-08db4b0d8b6f X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xYYOogY0VgZP+q5llqclBcANKXt2f8tCWiFWEMrrMGU51px7CC1oGSMFpfnp+xeOy5R53rGyxs6DaG4TvtSF6dUhNytlzMvvh3Nes3zeh6f6ho3pDPjzBVfPMC70LvSienhj9dsV+k6xghj+1inCzV9aVTeoD12+puXTMHPtveQz1fUdusYsbKfVRv41xlbNhHVrRSw3fZZBDiJcTuwgJP+c6ss2QLZkzB5noQ9hJ6H8BczoDqN4UkuYb2GKFj4tl3ARX61mFZ50nEuxLqOmQvv8bVYKSr+EIf43HmqtCe5eu84TiXJnfr+Y0o+vz6o8CNjCR7g8UZtMzWCQT2Se1KzY82nLiTLgLwLiItjxFYMaPPuRCAc4XvYuvi3U3Yp8iwyp8clwDvQBWMJ+ND6MiFd16vVsM/ktHMRNIibcz0DPJ5JLEVQBYZaokLySgwuIkyfZ81TlLo1E4FNdnwe83vh0Kf+fkVF6ersQ3mpD4CfNsYNbYU9y0xZwu7v3AHlIX1oODOXcONGvjC+n0e0ga6DueXOyJZI6cDVNLjk2QBIdVmtdDbPTRh2rDcJ2SBPapsbBA5F+4Bl9je6iMzwO/UEU3DXbEiGDTQd5h32DINI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(7916004)(4636009)(396003)(376002)(136003)(346002)(39860400002)(366004)(451199021)(26005)(6506007)(6512007)(9686003)(82960400001)(38100700002)(2906002)(66476007)(66556008)(66946007)(4326008)(6916009)(8936002)(8676002)(316002)(6666004)(54906003)(86362001)(41300700001)(5660300002)(478600001)(83380400001)(186003)(53546011)(6486002)(85182001)(33716001)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUNZTWNYSEkyaUhzZEdZSnN3OEd0YmJmTjQzOHFrWTFRNWdNWVFYcDY1TlJQ?= =?utf-8?B?SDUwd0p3clBRdEhyeE9VeURuUkNhRkNVNXlkNGp1RWFhc2hTYjkycEdQQ0tH?= =?utf-8?B?MGFLMkVWa2wzeXdPNmFtOXdva09rRG96M2o5cmYxRWcxdGtzQ0FSMXVxUklU?= =?utf-8?B?V0hYSGM4K080YjdnMVZNUXplajFoQnh5NWFyWmxnVHZuOTRJM290Mk1vYmhx?= =?utf-8?B?WE1xZzM4YzJialJocUVJMS9nSy9LTXNEL0gwMmtEOURPYUVFeGIrb0NqZUZQ?= =?utf-8?B?aDZwN0ZPaHIrOVZEYmJseU9aa0xGSHE2MnBqaU1qZ1Bvb3pPaldIa3BmS1Zp?= =?utf-8?B?ZkdvYyszOE9mNmNFc2ZhODRrTVdlcWdyQjdSV09BKzZBK2RCdk1yZ1lkWHgz?= =?utf-8?B?d3lBWE1pZkltVzZkUFcranAyaVUvNzYyaWxWVnI0ZTd1cm9zaGVwUllnUlNz?= =?utf-8?B?Q0d0OEhnNGJUOXgxYytRTzBPKzZ1QXRhRzF3KzRKYlU2NDZnck9HWGpDemIz?= =?utf-8?B?YVJMdk5Oakt0Wkl3bzBPdXJjTktOempjaW1wR21ZaFVzalNrcVpPSTkrZGEw?= =?utf-8?B?eXZXRDJkNmRnYXpKZThieUhsNTdiY0ZEWGJoa0JVWVBvelhwcXpTOFVGZnpL?= =?utf-8?B?T0VnVzg4OW81bUJWY01SNUU3YXlvQnVtMDcxU2RPTlRwcUJKWmlRWmpzN2ZQ?= =?utf-8?B?WDBHRys2MGd6V1VocUNXMG91NzJDZ2d0SlFzbmRsQ2VlNXlKcnA5Z3o1bzBO?= =?utf-8?B?eXRJbEhmK0owOVRFU0dDQVdSaWpSb0ZwMll3MkkrZ0tPQUxtTVFmNzhWSHdo?= =?utf-8?B?QkdvUlFGbUU0QU1idlNhdEM0UDJvQzMzRnYrRnBVV0t0Qk5IMy9PK3Y0Tktx?= =?utf-8?B?M3RmT2dtSUxJMFZwVUM5dkpNMnFpY0ZzaXkrbDNhUDJRUTY2eEtkMmRwQWF1?= =?utf-8?B?b1BkSy9KUXVTdlNBQjVTelU0MG82dUNTNEFnT2dkOHU5WHZ2SE83TUF6elJa?= =?utf-8?B?cTIrZ0tkRHJtcUNnZ1NzaWJzeldxMWtDYWNpUnNwRGlGd1VraXBxdHdwYUsw?= =?utf-8?B?TzVOR2UwT09XWjRBckNSK3cxT0g1TFZoN2pCSXhlcmxOSHdHWWhLVjkvbUxq?= =?utf-8?B?UjZoeCtPUklTOU41b2NoZ3JRamI4K0g2Z3k4SHh5S1dXZjNJSTd6OEw5ZUVN?= =?utf-8?B?aC8wSlgxTUhHQVZHdEJiUFcyYS8vY2JVb0daa3lreUh4eE54MjR0U2JJdSt3?= =?utf-8?B?UFZxWGZRM3I0TUduT0M0bFJOeDdsb0VKRDBUZndpZnV3dWZGVFdVaGJiUm10?= =?utf-8?B?eEtUOVIyc08vM0E1dHh2WmRLWHg0c2FMbFlWZTFEMTQrR2g1RjM4ZTVDVFpJ?= =?utf-8?B?c3dadGJsZ2FPSDlSSHp3d2ZHWUxhMmtsVHVkTFhWTjFoU3NBM21pcldwRzlU?= =?utf-8?B?ZE1LMmZwdGxqcU50QWxoNnVOSUFiYlNjamNTS21uRXBHWnRTUFR2ckF3aUNm?= =?utf-8?B?dTd6QkVJOHdjL0l0dGtYNGsrdXZOZE5Wd3RaMnN4ckZhcU1uODdsMXkxYk9O?= =?utf-8?B?MlAxMFY0WWEvSFZMOHZ5MlpVb0pZbGdTcjdOVUszM2MrTnNlZHovcVlqb0Jv?= =?utf-8?B?UDQxNVFsL3ZZZ29BQzB4SW1aTE0rd2RWbWZ2MTNnS0d0UkJRTC94V3UrN24z?= =?utf-8?B?elRYYVdWN3ozWXZBay9qQWo0NVpqanhBZGRvVm5FTFV0TkRXTlFIWE01NjlP?= =?utf-8?B?V1ZNOWk5akR0STFrMUFLRGI3dWhuWEVTM3FBaExJMUVEelE1bTlwdHROeUJX?= =?utf-8?B?RWkydnZicmtsZ1ZCSEhlSkJxR3R2YWw4UElEUkVaTnR3aVRMcnVNNnVXQ3Q2?= =?utf-8?B?NEZ5M3ZtcnErODdCTitUL0M4ZlRVcUxqMitVbTE0aEhsczdpS25reGN1NTE5?= =?utf-8?B?bk1pRkk5enFjVVZPNHJWZzh3c0ZkT0xsYmNIVitlaHpRQnZoQXd5cEVtWVlV?= =?utf-8?B?eWVzZWJlY3dzaFlPcE5wQXlHOUorQWZDOWdrbk1aeXFBL0wrNjh5M2NvN1Nq?= =?utf-8?B?cVBmYU5qTm5BdTB5T2JrSHNIUXV6d3RrUlR3bnhTSlZFbDV0YkxVYWp1MVMw?= =?utf-8?B?YWVlSTdDZVNDTEl6TmFIdGk1Zi9WRkl5UTBDa0VWLzF1S082WkxkaUs5VGor?= =?utf-8?B?QlE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Luv07VhtD5O0ZmmoCQrPjMyOsRF1TzmBAli6FEO89m0J88q/dV93H3odXlP9pO6HYel0pYm3euZwMW5BeEnfOuBGqRDdd7DL7taAivMwysEX7mTBn+qSoNCv98lLbRlnIv/Lq9a2j7K8pxJ5KzwDvjxVOUL/uqVMRrWmSdj6TbTskZeTfIQ3qceLTp+xRVHPqY3/Njrq6+ZSVvMsLrDMZ7700o0rbkKspuWn1vXrs/b6BeNu4DKJsoL0ETowr3jx/Eo3VD31hIY1roJ/SV4y4KF9a60UvfS2uiMrPjK8cQxVQD7M8s8PKjU2BSw0rZlEHMpINHXQkRx9/xFMkQwIinkPrZAr9xOaEnp2po8F1vAxD7+a2Es1FAGhHpPhgHRAIEXlaLnDCnHBgROchLeuHDyNtkft0hp+LGCEWxRG386+HM/UwQJoRjyfgVjhxRq2XJ6SGImtkYVQpGeWd0p4ia7bdNphTDttcNP+c1cbE97Ci9EHMbWFaQMrolnAl2rXKpvdiCyDQm99JqQTbJJ/wTk2uF/o8VHIfdBxNPMxRAdfi0wQllJCYDiR+A21RE7mApLtqm71EGACfQ4/nKdY6z0cwtDqujSzKDv+O4a7aEwkQvtvutcq/daE6mBihJIOPYanzR0ZFxRNRXzuYE+TJExCAmkHvG8mvOtSxDQE93O97K/9t2xJsPgPiqtiHu8u6F3XvdskLkIgynsomF7DsQVfrmcLnR7dRL7IMUF8u96pas2VYLnZrv2pIr0KqPwiNHTyQ8cpuAIalQaZv2FfuknfH6C5rD1QLdP8M7pBEHUEKzpXwr6JhilmuH8N3k4+ X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 22a69cfa-8c4f-47c0-5056-08db4b0d8b6f X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 13:02:55.1973 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ilgZf40NPjG5ky+RyuXRS3IwaRRKPBI+toaCpDGos2q5vjJAdSMen7xLsbfOYWNOPaQFQMTiLI+i73yQ4AER3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5669 On Tue, May 02, 2023 at 01:11:12PM +0200, Jan Beulich wrote: > On 02.05.2023 13:05, Jan Beulich wrote: > > On 02.05.2023 12:51, Roger Pau Monné wrote: > >> On Tue, May 02, 2023 at 12:28:55PM +0200, Jan Beulich wrote: > >>> On 02.05.2023 11:54, Andrew Cooper wrote: > >>>> On 02/05/2023 10:22 am, Roger Pau Monne wrote: > >>>>> @@ -670,6 +674,11 @@ trampoline_setup: > >>>>> cmp %edi, %eax > >>>>> jb 1b > >>>>> > >>>>> + /* Check that the image base is aligned. */ > >>>>> + lea sym_esi(_start), %eax > >>>>> + and $(1 << L2_PAGETABLE_SHIFT) - 1, %eax > >>>>> + jnz not_aligned > >>>> > >>>> You just want to check the value in %esi, which is the base of the Xen > >>>> image.  Something like: > >>>> > >>>> mov %esi, %eax > >>>> and ... > >>>> jnz > >>> > >>> Or yet more simply "test $..., %esi" and then "jnz ..."? > >> > >> As replied to Andrew, I would rather keep this inline with the address > >> used to build the PDE, which is sym_esi(_start). > > > > Well, I won't insist, and you've got Andrew's R-b already. > > Actually, one more remark here: While using sym_esi() is more in line > with the actual consumer of the data, the check triggering because of > the transformation yielding a misaligned value (in turn because of a > bug elsewhere) would yield a misleading error message: We might well > have been loaded at a 2Mb-aligned boundary, and instead its internal > logic which would then have been wrong. (I'm sorry, now you'll get to > judge whether keeping the check in line with other code or with the > diagnostic is going to be better. Or split things into a build-time > and a runtime check, as previously suggested.) What about adding a build time check that XEN_VIRT_START is 2MB aligned, and then just switching to test instead of and, would that be acceptable? I know that using sym_esi(_start) instead of just esi won't change the result of the check if XEN_VIRT_START is aligned, but I would prefer to keep the usage of sym_esi(_start) for consistency with the value used to build the page tables, as I think it's clearer. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 02 13:03:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 13:03:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528587.821944 (Exim 4.92) (envelope-from ) id 1ptpev-0007T2-88; Tue, 02 May 2023 13:03:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528587.821944; Tue, 02 May 2023 13:03:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptpev-0007Sv-4w; Tue, 02 May 2023 13:03:09 +0000 Received: by outflank-mailman (input) for mailman id 528587; Tue, 02 May 2023 13:03:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptpet-0007RC-V6 for xen-devel@lists.xenproject.org; Tue, 02 May 2023 13:03:07 +0000 Received: from sender3-of-o59.zoho.com (sender3-of-o59.zoho.com [136.143.184.59]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ada93777-e8e9-11ed-b225-6b7b168915f2; Tue, 02 May 2023 15:03:06 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1683032582345892.9308198213303; Tue, 2 May 2023 06:03:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ada93777-e8e9-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1683032583; cv=none; d=zohomail.com; s=zohoarc; b=dcnrjMXMEBqaDs8HEbZpO1CdF6/rgjf5Vvlwc8+apeqQe0DT6bMc+fLmzS123Eqx2HOoPNyZBgGDvjzrDl/k90nzuymYQYfhshju5oMKBv6NAY357rd9y6aWnPqbso9TuKQg7mqE+KJwrhfcwwibJSh+xzjk4RSu3+caj4wulbU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1683032583; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=+PmM/urMgFqGb0mSi5wPADvNdwp6VGJZKc8t26d4ohA=; b=Zs5kwMKNBZqS8yx+15CNimtqKJkvfKHP9XZv+pmDW/PJ865FwLAYEnbWVdtliui1mkIolBjbush/x8Hchwglss1oJ14AKbEsJiwXnNf2/T4GYFWHAkTyIbEh7ZAmAKvEkITJh0yd0jAGXfJrLokjwR+NKoreib0/KiRHKLAANGI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1683032583; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=+PmM/urMgFqGb0mSi5wPADvNdwp6VGJZKc8t26d4ohA=; b=BcKrPcPdZbdx2GDypUx5ylnwwgJp3d5gGkboQZl1jK2Bz5jX2wH36yWz0zR28nzB A9QbRKDCGhrBoiu93reV+7VwhyqQNZrN/oIQK0+C0fn+dEmj+ngFPiDCeQdcrP8biVi xzPpivbblMjvlIoASFGgtSQ/If9WFt3HHWEas9EI= Message-ID: <0c01a75d-8a98-3931-28fa-68ed373e9a2e@apertussolutions.com> Date: Tue, 2 May 2023 09:03:00 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu References: <20230430144646.13624-1-jgross@suse.com> From: "Daniel P. Smith" Subject: Re: [PATCH] xen/sysctl: fix XEN_SYSCTL_getdomaininfolist handling with XSM In-Reply-To: <20230430144646.13624-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 4/30/23 10:46, Juergen Gross wrote: > In case XSM is active, the handling of XEN_SYSCTL_getdomaininfolist > can fail if the last domain scanned isn't allowed to be accessed by > the calling domain (i.e. xsm_getdomaininfo(XSM_HOOK, d) is failing). > > Fix that by just ignoring scanned domains where xsm_getdomaininfo() > is returning an error, like it is effectively done when such a > situation occurs for a domain not being the last one scanned. > > Fixes: d046f361dc93 ("Xen Security Modules: XSM") > Signed-off-by: Juergen Gross > --- > xen/common/sysctl.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c > index 02505ab044..0cbfe8bd44 100644 > --- a/xen/common/sysctl.c > +++ b/xen/common/sysctl.c > @@ -89,8 +89,7 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl) > if ( num_domains == op->u.getdomaininfolist.max_domains ) > break; > > - ret = xsm_getdomaininfo(XSM_HOOK, d); > - if ( ret ) > + if ( xsm_getdomaininfo(XSM_HOOK, d) ) > continue; > > getdomaininfo(d, &info); This change does not match the commit message. This says it fixes an issue, but unless I am totally missing something, this change is nothing more than formatting that drops the use of an intermediate variable. Please feel free to correct me if I am wrong here, otherwise I believe the commit message should be changed to reflect the code change. Second, as far as the problem description goes. The *only* time the call to xsm_getdomaininfo() at this location will return anything other than 0, is when FLASK is being used and a domain whose type is not allowed getdomaininfo is making the call. XSM_HOOK signals a no-op check for the default/dummy policy, and the SILO policy does not override the default/dummy policy for this check. V/r, Daniel P. Smith From xen-devel-bounces@lists.xenproject.org Tue May 02 13:10:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 13:10:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528596.821955 (Exim 4.92) (envelope-from ) id 1ptplz-0000zJ-05; Tue, 02 May 2023 13:10:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528596.821955; Tue, 02 May 2023 13:10:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptply-0000zC-TQ; Tue, 02 May 2023 13:10:26 +0000 Received: by outflank-mailman (input) for mailman id 528596; Tue, 02 May 2023 13:10:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptplx-0000z3-Gd for xen-devel@lists.xenproject.org; Tue, 02 May 2023 13:10:25 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b19caf54-e8ea-11ed-8611-37d641c3527e; Tue, 02 May 2023 15:10:23 +0200 (CEST) Received: from mail-dm6nam11lp2177.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2023 09:10:15 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by DM4PR03MB6013.namprd03.prod.outlook.com (2603:10b6:5:388::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.20; Tue, 2 May 2023 13:10:13 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec%3]) with mapi id 15.20.6340.031; Tue, 2 May 2023 13:10:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b19caf54-e8ea-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683033023; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=MLTij1A4AGgMlMo36T9Wt4Qj75z05q5Hq5R1l5hi9LY=; b=h6eJw6Q4lvP8JFrhrk5eRk9ydzxSNLRUeKMqg9kLd+lbFaYPBercUMm8 mhzutk6SBqRX1buUCjC7LT2Mc/0faJFQVh6zZFLNei31k6oTKPOzr3YFM n2yiCqCpCSIKyAROnqeFHWQMa4Jie8wyZngWzdslEPeDCrn+ehM84BxMN k=; X-IronPort-RemoteIP: 104.47.57.177 X-IronPort-MID: 106330959 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:7oYHTqACK8wkChVW/9biw5YqxClBgxIJ4kV8jS/XYbTApDon0DdTn GIbWjrQa/mDNDOmed1zb4TnoRgD6pPWyYBqQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFuspvlDs15K6p4G5A5ARkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw/aFrP15Bx /gkMW4xbE7fhaWI2rS+Rbw57igjBJGD0II3nFhFlGicIdN4BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI+uxuvDe7IA9ZidABNPLPfdOHX4NNl1uwr WPa5WXpRBodMbRzzBLcqiz33beewHKTtIQ6L6Hk3ORQhEyowHEuBxEcd0DgreGzhRvrMz5YA wlOksY0loA+7FeuT8X9dxSgrWSYowUHXN5ND+w97hrLwa3Riy6bCXIDVSVpc8E9uYk9QjlC/ k+EmZblCCJitJWRSGmB7fGEoDWqIy8XIGQeIygeQmMt4dPuvYUyhRLnVct4Hei+ididMTPtx zGHqgAuirNVitQEv42g5kzOiT+oopnPTyY26x/RU2bj6Rl2DKa6Y6S45F6d6uxPRLt1VXGEt XkA3sSbsuYHCMjUkDTXGbpSWra0+/yCLTvQx0Z1GIUs/Cis/Hjlep1M5DZ5JwFiNcNslSLVX XI/cDh5vPd7VEZGp4cuC25tI6zGFZTdKOk= IronPort-HdrOrdr: A9a23:H+bZBqmszeS+IVs//9cWkMZOspXpDfIN3DAbv31ZSRFFG/Fw9v re5cjzsCWVtN9/YgBCpTntAtjjfZqkz+8S3WBzB8bGYOCZghrTEGgK1+KLqAEIfReOjtK1vp 0QFJSWZueAdmSTiq7BjjVRRL4brOVu4siT5Ns33B9WIj2De8lbhTuQEG6gf3Ge7TM2YaYEKA == X-Talos-CUID: 9a23:slJ1Z2CuWA4nM5v6Ey4g6HArFfIhTmSD8HWOf03/N3xvTbLAHA== X-Talos-MUID: 9a23:nY37hQqWsBZAQ7tzByEezwp+aO1y2aC/M0YQrJoKseufbiBoMTjI2Q== X-IronPort-AV: E=Sophos;i="5.99,244,1677560400"; d="scan'208";a="106330959" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lFyDtxFMI5BcUyRjwWhOm6ZQUx9JZ+CZdN8MukvFFQSjUdtqgCVWlJVlAcDjqNs8/TRjXVzPadrcATJnAd/g21GqAWu5EmKmaKU7VAC/n8D5lnohjg6qm51aYVfWqJPyPmVpCo3ggRyecGpoPa3+igJWiX9/AZR7mMU3r9+hbVDpNTC6yMKjGbjoYaATrc5bDqRMad0I0UswgXA2QIRTZU4xQViMv/yGn1Ib7b/ORydt5iOWkGti8X7gEWqgH9HaQNVtA32VD4HfnGE1jOC1VSSWth1xWOFlbUgnpOYTLpI45NjLZml0KGaEkd77Dq57SSepxf2V0DCMGWcoKeg0sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YnyaevPHt9hCzAcJesQfdl7YN/uqEVelGTTDFPY2XNk=; b=lGuhUQK+M6uSqWMO/N0NnDf5XPXAlt1y4eLybdpUTxRa596ZWpFFtjDnkDCyJMo5v8pxPgnjzY7Uke2VCyHDAsNRlDU3rfiSorBo7Y5iV+ibA4SBJB8OwS08Ttt8npfNbfjuu+ofmwNEaUbYG4MXhcJTgwjn8mATAUS8I57VZazBkrJa2T3iYRHWR03jH4P21GaHWZSkUliJ7bs3bTfUZi4H/vbfdyhp6MRDJBaVCQSWYxTKSQ+M0AIZyiUl8sE8UFba8bDUbSyphzr183xxqV+7FajZBDnqdqcWu58/ulQTac/4okl/X/I2P/p6JnlOg8M9EEY0xs6odCbNabD0tA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YnyaevPHt9hCzAcJesQfdl7YN/uqEVelGTTDFPY2XNk=; b=CspUmLAaxzHAmRVoplMQfH/XvFn/MyvB3VoUokVi5FvWPQC6Xm4Abpw3YPGF/O2BfTyDQ2DnEyAwZrISdVrryes8YA2SD0RsgdrtCbq+rR/4wSsGKo8mGU0qgp+D2ieV3vwU772ISeU8/eKh86bziEq3B79MbrrKU7mlx6EjqZs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 2 May 2023 15:10:07 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: "Daniel P. Smith" Cc: Juergen Gross , xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH] xen/sysctl: fix XEN_SYSCTL_getdomaininfolist handling with XSM Message-ID: References: <20230430144646.13624-1-jgross@suse.com> <0c01a75d-8a98-3931-28fa-68ed373e9a2e@apertussolutions.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <0c01a75d-8a98-3931-28fa-68ed373e9a2e@apertussolutions.com> X-ClientProxiedBy: LO4P265CA0280.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:37a::17) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|DM4PR03MB6013:EE_ X-MS-Office365-Filtering-Correlation-Id: 6b812388-0d10-4fea-4791-08db4b0e90c3 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A284q4kta1n9fTTSN6C8Pz8YvnOENCFWrSpiO8RRAqHJeRNqT61uxpm1axYR7xlxUjrMvR1RmTqGXW4Fq+lLKNll0doD1lVYKds3Q7tCqpV1CuToSe0FKdGRLJo71TUL2CyXkJKaht/fnVXBY64s2mk5W+LHHxsfQx68gMTD40OlUDDFmdy59rJFx/q6tRcM7hxqeFk1JwCCeYQ82a69CecqoaDBg9BIkdyMSqnPgsHlyoHvUj/xd8th5Lt7kic6KtHZs8spDPfZ6vudymDwg6huTLRbOS/qQGQSthCVABxobJ+SBxYC77yIIXQ25q5KBprqNQOFDEfYTaHThD9TD7CNIp9JkM8bzI6UqgxO3nIY9QplxxRtu0O6pfTWojev1MEnadVib9yEIZhZlwaxhhnfvruE6+ODsndksjqlkDnqGlnWEpxmXAb5yKZ5hPb0CYKQ2bSXzKVTNSVoj8aV6slmuqOUlEp08XYmRsz28t42lame+nMtcyMyati1axvbNt0v+iee8cligFvBscxswaMmwZEftRkz5L3KNUyWTNKMCaCUFoWXtc3+TnvWaUgD X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(7916004)(346002)(396003)(136003)(376002)(366004)(39860400002)(451199021)(66476007)(66556008)(66946007)(2906002)(86362001)(5660300002)(8936002)(8676002)(41300700001)(6666004)(85182001)(316002)(4326008)(6916009)(54906003)(478600001)(6486002)(186003)(82960400001)(6506007)(6512007)(9686003)(53546011)(26005)(83380400001)(33716001)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T0N0Qk9UZS9lTmlvd2ZybEFIZ3dETE9XQlVwRDNnZ2UxQ1hXM1o4dVJUWmRS?= =?utf-8?B?UFMxYXFMTE51b3RZUndhakJheWJLcHdVTDlxcm0xbmU1OW1hUlQyRzdTYU96?= =?utf-8?B?SVJGV1hrV1VuenU1VTBZZXAxQWNEdXh3UnAwTWlEMEdVOVBROFBNcXdoL1JU?= =?utf-8?B?NTRITmNyNmp6YzAyajA2S3B4aCtMSmg5d3B3VWg1K3ZPL0FBSW5ROHlQTjda?= =?utf-8?B?dnFranQvODBQRHRVM1pwbEdtVGo2aTV5b05yNTU1MW9CQld6TDZQV2lNU2s1?= =?utf-8?B?cXZCV2JLbFZNQnVzSVJlUVQ5SWFDZ05halVaR1ZIRGlMWTFtdlZHUUdjbWFS?= =?utf-8?B?RUlVMjlWdEJJT0tyN2d0TE00bW5vMDJFdFlUdUtET1RQck1uNE13cmZ4WlNB?= =?utf-8?B?ZnNKczhJVG5YMGhmRzB4SWxPUGMrWE1ZL1lvb2RiYUROWTEvNnBZZThIdUov?= =?utf-8?B?eWw1NGIrNllYelJxWmhuYzBuTlBVYjhxTUVVWnVQbW5BbS9GVHBrOFVZQTlq?= =?utf-8?B?T1hQdWxDUndSN0JxK3MwdndWSC9TZnR0T0tnN2h3T1NwZGxnQ2ErMDMreU5h?= =?utf-8?B?TDhkaVpOb1RWamlsRmNxSFlPWHVGOTgvejFtb05FbS9XMnh0ZU5HOTlVTnps?= =?utf-8?B?WTd3ajdmTnBFZVpHTzdVRFpZTFQwTzFQRkl3TFdkZ0J3aW4wRFYrdVRRZFpZ?= =?utf-8?B?aTBKajk4ZzFYRXk5TU82cUZ3ZmZib1UweUxFcjJ0c3pQeE5reGU1RTNZQWJJ?= =?utf-8?B?MTIyam5YNDNUVVlyTENWYXhGNGowamtzSWJ1MHhXcHdLM2lTaWRPRjlReTI2?= =?utf-8?B?Ky9ZdUJHSHhMNkp5bVJkTXRLTThRWExLbTQycy9hZU8vSGV2U2pEQ0k4SzdH?= =?utf-8?B?RC9LaXVWMXEvc3oyU3VQMEpvakg1NytybTFIT1dLUDJlcjl3RFVTNkZBSWFy?= =?utf-8?B?SVJCbkl3WHR5ajg0TkllWFAwbC85d0VXVkNjSHZydzJSNHVVeDkwMjNwVjBO?= =?utf-8?B?U0pGSlJVS2Y2NzdSQWJob1lmUGlDY1haZGlMdVJvSE9kYVNrZEo1RTdBTTNa?= =?utf-8?B?SnY4OWxBUnZVVmM1ZGZ6RHpwVE9WamtjSjB0SDBndTdodXdkeVlNSW9aWlNN?= =?utf-8?B?UGpYL2EzT0QzUlAvdFhqQi9XZTBsRjFMUXQwbVJ0SGtiOGtmV2JrOFhnendZ?= =?utf-8?B?ZXNLcDNjZ1VTRDJreXBmMU5QUHRkMFNzRnBPam9qMEFSOWZVN2RVdWcvUHNx?= =?utf-8?B?QjI0eDgzMlNnK21MZHM3dWRrbEhXNzFBVSthRVJVVjFhVExUT3J6OGdsSE1D?= =?utf-8?B?akpzNUtBR1B4aVNNVHgzdm0xTUY3VXlOWjh6US9IK1hXeHJPRkFWRlZGcXhO?= =?utf-8?B?OThjcllxcmoxV0M1T0FQdktmNmxjSUZXOVk3WVlDK0ZWZk1HSnRPZG9HQkJE?= =?utf-8?B?MDN5YVlVYkttZzZrdno2Tyt2aXU3R1hIajEwdm44L2tKaUpzN0kvamtRdit5?= =?utf-8?B?Z29QWEFPTWJ6QXM3bmJLMHZZS1U1dG0rYTlXcTZLRlM2MklSQW5tOUt3Z0lH?= =?utf-8?B?eGwzNnJuMHNJVTNWQ2dpSWpnR1VLWVBzSFd5YmZjS0thaE9UUTdQUGE5cXlH?= =?utf-8?B?TTNlUFE3Rk11YTJSeVhab0VNVklRd21IZXpUN1kzUTZDS2Q5R1JwditMcUh2?= =?utf-8?B?d2czOW5tZFlJeitHLzVEazdRQ2lISVBaVWVvRjdwR1ZxTmo5UWhMTlpWdmVu?= =?utf-8?B?Z2wwZzRhWFh2anhkQmdkUW9ZNlNLMzE3MWhuOGpoTUJEU1RNaG5EUkR2UFNJ?= =?utf-8?B?aGxJUWJuNDlDL3ZvQ2NlRXFWZFZpYWpPdFVpamcwaEltZmFYeFg2RkZCRnVB?= =?utf-8?B?clB2UTdOK0x2WmV3S2dQVDNwMG9LTjg2djlTdnBrUHlKQ2NHK2Izck1pVWNu?= =?utf-8?B?N3dOR2tzN3hVeVV6WVVwdmhlYUtGR1RWSEtqbGk0c1lSL2dtMVZFTVR2MmpO?= =?utf-8?B?STk4Q29kNUtGMXR1Wm5TV3pWSzhaTEhZMzJ0Z1hWdXdFU1JjM1RMckQ4WGlm?= =?utf-8?B?d0NVN1p0T3V1YzNnRCtjY0RVNWwvQ3FFay9yZGM3YVQ3cFc1eGM0QVkxbENK?= =?utf-8?B?cDUrMEt5bTBDdzlmNjhnc01ldjV4cWhBNWNmZmpRS0RSMGtkaEJXUGdGdWRU?= =?utf-8?B?MlE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 2VNVuPYfGPrNgiXB7bw4LWeI0+ztdrtDXxwXL2ipUP4sffuIld55GgvPjcRe/HQgrLLYYXEs/hG90C66ucKAFaI9Hn5KY2eMODgGk/iGTKfGLMT+yESFqY4/nx796Q70Ys1+P3tlZQLIJWhQMYxuTqfWXzX1+U/xOgIE/dTOdJwAB+oQ6VLXviGBO5FCO887hmUksDvAmoxJtOmo7gontjvtp1ipk+TVbI6S1vFv03bOq/Xn/lYoKmPluhUak0GAe7GK2MyXlX3WHTIuP2luuzJ+e1BvZiacbGltywwkvcX2e+Z+HHscPLQddAITUMgrtZkPtm1yUFNrJ2h3PByQYd3aQziJY8rwmj83rHR43tf48k9MIksdQY+AcN4srUnv6D8+3prBMeXJmBxaZeCJPj+KKYEZCd8nZOV/yCLafrZw00+csldIaqnDgBviG9ghVTY3PrfCU/JnG2v7B+4FQJDmiRV1Ke3iaZIkrqwQSgPZUPYKMkC2OvwYYZDYs1LtTO/lQh8FwoTMHXdtKPNH5EF2k7noFMhnaPPOCaAZeTRfxQLZItE5lpyThHTtaRm7Rz4vPBJQfSevoiULQ9CpKpAYfZQbZuaKx9iqnO7mdGyLS9ulsR57Z8ShK+azW4OZLCkHWBRt39jV8Rg2iau0Og7Hl9ATYbPCHX3EO/8+H41/ILJXspZoa+juIsNiFo0af7whU0cEm1R7HDrBmyvW6hQ7w6iQx1zZtA/hZlr5JgjnxwVtbD2MuQWhOiarqywWA4EEgY3XD5a+ugEPnKn+pJV5iQ4niEW5+Q8U6tGT8rotonbo3+Amp8zb8IEpN6van5i/Nce1Q5jd3616RdGL40UUA+dQYukk6l2T/xXuW9rpXReCMLqPEvna/geO3RT87A9f5AU2cgxJZbjxO4qhxw== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b812388-0d10-4fea-4791-08db4b0e90c3 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 13:10:13.5897 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ypz+UToJ0eskFZI3G0Lp0ZN5SWrpq++JqLAd6ETXEb9jPESZSfEvH+LuVfthZc6Z2k7cPnfDWe4KMN0zA9KIhQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6013 On Tue, May 02, 2023 at 09:03:00AM -0400, Daniel P. Smith wrote: > On 4/30/23 10:46, Juergen Gross wrote: > > In case XSM is active, the handling of XEN_SYSCTL_getdomaininfolist > > can fail if the last domain scanned isn't allowed to be accessed by > > the calling domain (i.e. xsm_getdomaininfo(XSM_HOOK, d) is failing). > > > > Fix that by just ignoring scanned domains where xsm_getdomaininfo() > > is returning an error, like it is effectively done when such a > > situation occurs for a domain not being the last one scanned. > > > > Fixes: d046f361dc93 ("Xen Security Modules: XSM") > > Signed-off-by: Juergen Gross > > --- > > xen/common/sysctl.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c > > index 02505ab044..0cbfe8bd44 100644 > > --- a/xen/common/sysctl.c > > +++ b/xen/common/sysctl.c > > @@ -89,8 +89,7 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl) > > if ( num_domains == op->u.getdomaininfolist.max_domains ) > > break; > > - ret = xsm_getdomaininfo(XSM_HOOK, d); > > - if ( ret ) > > + if ( xsm_getdomaininfo(XSM_HOOK, d) ) > > continue; > > getdomaininfo(d, &info); > > > This change does not match the commit message. This says it fixes an issue, > but unless I am totally missing something, this change is nothing more than > formatting that drops the use of an intermediate variable. Please feel free > to correct me if I am wrong here, otherwise I believe the commit message > should be changed to reflect the code change. By dropping that intermediate variable it prevents returning an error as the result of the hypercall if xsm_getdomaininfo() for the last domain fails. Note that xsm_getdomaininfo() failing for other domains not the last one don't cause the return value of the hypercall to be an error code, because the variable containing the error gets overwritten by further loops. Regards, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 02 13:13:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 13:13:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528600.821965 (Exim 4.92) (envelope-from ) id 1ptpoc-0001Xk-D6; Tue, 02 May 2023 13:13:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528600.821965; Tue, 02 May 2023 13:13:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptpoc-0001Xd-A4; Tue, 02 May 2023 13:13:10 +0000 Received: by outflank-mailman (input) for mailman id 528600; Tue, 02 May 2023 13:13:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptpob-0001XX-4v for xen-devel@lists.xenproject.org; Tue, 02 May 2023 13:13:09 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 13f1ec27-e8eb-11ed-8611-37d641c3527e; Tue, 02 May 2023 15:13:06 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6C2532219E; Tue, 2 May 2023 13:13:06 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2887B134FB; Tue, 2 May 2023 13:13:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id UEh0CGIMUWRGUwAAMHmgww (envelope-from ); Tue, 02 May 2023 13:13:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 13f1ec27-e8eb-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683033186; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4/WSpv2WTFYkjPxg73ZtghIvmSLUD0+J5pZNvX3ePHA=; b=cvAOgHeqfHd4AvN/MDxZQvnltSnD5mrJ0GsdCeoO/R7Wc+xaMwfOnMVtxh6ZFySjFAnVvI RdIsKBEoEKjCm0l4dvyedwItYFhqfpdU+ztP6MGo0K5Lv5BP/a+8wxoLPUm4lJ9haPf734 Ansikwl+1hWnzcsjkpDVJdRqNYJDXeM= Message-ID: Date: Tue, 2 May 2023 15:13:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Content-Language: en-US To: "Daniel P. Smith" , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu References: <20230430144646.13624-1-jgross@suse.com> <0c01a75d-8a98-3931-28fa-68ed373e9a2e@apertussolutions.com> From: Juergen Gross Subject: Re: [PATCH] xen/sysctl: fix XEN_SYSCTL_getdomaininfolist handling with XSM In-Reply-To: <0c01a75d-8a98-3931-28fa-68ed373e9a2e@apertussolutions.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------kMsB1mAB7fj1RnTAIn2sTf0i" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------kMsB1mAB7fj1RnTAIn2sTf0i Content-Type: multipart/mixed; boundary="------------sjLKwfXhK0tKd9Q2bGaxUaA7"; protected-headers="v1" From: Juergen Gross To: "Daniel P. Smith" , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Message-ID: Subject: Re: [PATCH] xen/sysctl: fix XEN_SYSCTL_getdomaininfolist handling with XSM References: <20230430144646.13624-1-jgross@suse.com> <0c01a75d-8a98-3931-28fa-68ed373e9a2e@apertussolutions.com> In-Reply-To: <0c01a75d-8a98-3931-28fa-68ed373e9a2e@apertussolutions.com> --------------sjLKwfXhK0tKd9Q2bGaxUaA7 Content-Type: multipart/mixed; boundary="------------wTeax1LXCXbzJqxcuuMG6NSl" --------------wTeax1LXCXbzJqxcuuMG6NSl Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDIuMDUuMjMgMTU6MDMsIERhbmllbCBQLiBTbWl0aCB3cm90ZToNCj4gT24gNC8zMC8y MyAxMDo0NiwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4+IEluIGNhc2UgWFNNIGlzIGFjdGl2 ZSwgdGhlIGhhbmRsaW5nIG9mIFhFTl9TWVNDVExfZ2V0ZG9tYWluaW5mb2xpc3QNCj4+IGNh biBmYWlsIGlmIHRoZSBsYXN0IGRvbWFpbiBzY2FubmVkIGlzbid0IGFsbG93ZWQgdG8gYmUg YWNjZXNzZWQgYnkNCj4+IHRoZSBjYWxsaW5nIGRvbWFpbiAoaS5lLiB4c21fZ2V0ZG9tYWlu aW5mbyhYU01fSE9PSywgZCkgaXMgZmFpbGluZykuDQo+Pg0KPj4gRml4IHRoYXQgYnkganVz dCBpZ25vcmluZyBzY2FubmVkIGRvbWFpbnMgd2hlcmUgeHNtX2dldGRvbWFpbmluZm8oKQ0K Pj4gaXMgcmV0dXJuaW5nIGFuIGVycm9yLCBsaWtlIGl0IGlzIGVmZmVjdGl2ZWx5IGRvbmUg d2hlbiBzdWNoIGENCj4+IHNpdHVhdGlvbiBvY2N1cnMgZm9yIGEgZG9tYWluIG5vdCBiZWlu ZyB0aGUgbGFzdCBvbmUgc2Nhbm5lZC4NCj4+DQo+PiBGaXhlczogZDA0NmYzNjFkYzkzICgi WGVuIFNlY3VyaXR5IE1vZHVsZXM6IFhTTSIpDQo+PiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+PiAtLS0NCj4+IMKgIHhlbi9jb21tb24vc3lz Y3RsLmMgfCAzICstLQ0KPj4gwqAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAy IGRlbGV0aW9ucygtKQ0KPj4NCj4+IGRpZmYgLS1naXQgYS94ZW4vY29tbW9uL3N5c2N0bC5j IGIveGVuL2NvbW1vbi9zeXNjdGwuYw0KPj4gaW5kZXggMDI1MDVhYjA0NC4uMGNiZmU4YmQ0 NCAxMDA2NDQNCj4+IC0tLSBhL3hlbi9jb21tb24vc3lzY3RsLmMNCj4+ICsrKyBiL3hlbi9j b21tb24vc3lzY3RsLmMNCj4+IEBAIC04OSw4ICs4OSw3IEBAIGxvbmcgZG9fc3lzY3RsKFhF Tl9HVUVTVF9IQU5ETEVfUEFSQU0oeGVuX3N5c2N0bF90KSB1X3N5c2N0bCkNCj4+IMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIGlmICggbnVtX2RvbWFpbnMgPT0gb3AtPnUuZ2V0ZG9t YWluaW5mb2xpc3QubWF4X2RvbWFpbnMgKQ0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCBicmVhazsNCj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldCA9IHhz bV9nZXRkb21haW5pbmZvKFhTTV9IT09LLCBkKTsNCj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDC oMKgIGlmICggcmV0ICkNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGlmICggeHNtX2dl dGRvbWFpbmluZm8oWFNNX0hPT0ssIGQpICkNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqAgY29udGludWU7DQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBn ZXRkb21haW5pbmZvKGQsICZpbmZvKTsNCj4gDQo+IA0KPiBUaGlzIGNoYW5nZSBkb2VzIG5v dCBtYXRjaCB0aGUgY29tbWl0IG1lc3NhZ2UuIFRoaXMgc2F5cyBpdCBmaXhlcyBhbiBpc3N1 ZSwgYnV0IA0KPiB1bmxlc3MgSSBhbSB0b3RhbGx5IG1pc3Npbmcgc29tZXRoaW5nLCB0aGlz IGNoYW5nZSBpcyBub3RoaW5nIG1vcmUgdGhhbiANCj4gZm9ybWF0dGluZyB0aGF0IGRyb3Bz IHRoZSB1c2Ugb2YgYW4gaW50ZXJtZWRpYXRlIHZhcmlhYmxlLiBQbGVhc2UgZmVlbCBmcmVl IHRvIA0KPiBjb3JyZWN0IG1lIGlmIEkgYW0gd3JvbmcgaGVyZSwgb3RoZXJ3aXNlIEkgYmVs aWV2ZSB0aGUgY29tbWl0IG1lc3NhZ2Ugc2hvdWxkIGJlIA0KPiBjaGFuZ2VkIHRvIHJlZmxl Y3QgdGhlIGNvZGUgY2hhbmdlLg0KDQpZb3UgYXJlIG1pc3NpbmcgdGhlIGZhY3QgdGhhdCBy ZXQgZ2V0dGluZyBzZXQgYnkgYSBmYWlsaW5nIHhzbV9nZXRkb21haW5pbmZvKCkNCmNhbGwg bWlnaHQgcmVzdWx0IGluIHRoZSByZXQgdmFsdWUgYmVpbmcgcHJvcGFnYXRlZCB0byB0aGUg c3lzY3RsIGNhbGxlci4gQW5kDQp0aGlzIHNob3VsZCBub3QgaGFwcGVuLiBTbyB0aGUgZml4 IGlzIHRvIE5PVCBtb2RpZnkgcmV0IGhlcmUuDQoNCj4gU2Vjb25kLCBhcyBmYXIgYXMgdGhl IHByb2JsZW0gZGVzY3JpcHRpb24gZ29lcy4gVGhlICpvbmx5KiB0aW1lIHRoZSBjYWxsIHRv IA0KPiB4c21fZ2V0ZG9tYWluaW5mbygpIGF0IHRoaXMgbG9jYXRpb24gd2lsbCByZXR1cm4g YW55dGhpbmcgb3RoZXIgdGhhbiAwLCBpcyB3aGVuIA0KPiBGTEFTSyBpcyBiZWluZyB1c2Vk IGFuZCBhIGRvbWFpbiB3aG9zZSB0eXBlIGlzIG5vdCBhbGxvd2VkIGdldGRvbWFpbmluZm8g aXMgDQo+IG1ha2luZyB0aGUgY2FsbC4gWFNNX0hPT0sgc2lnbmFscyBhIG5vLW9wIGNoZWNr IGZvciB0aGUgZGVmYXVsdC9kdW1teSBwb2xpY3ksIA0KPiBhbmQgdGhlIFNJTE8gcG9saWN5 IGRvZXMgbm90IG92ZXJyaWRlIHRoZSBkZWZhdWx0L2R1bW15IHBvbGljeSBmb3IgdGhpcyBj aGVjay4NCg0KWW91ciBzdGF0ZW1lbnQgc291bmRzIGFzIGlmIHhzbV9nZXRkb21haW5pbmZv KCkgd291bGQgYWx3YXlzIHJldHVybiB0aGUgc2FtZQ0KdmFsdWUgZm9yIGEgZ2l2ZW4gY2Fs bGVyIGRvbWFpbi4gSXNuJ3QgdGhhdCByZXR1cm4gdmFsdWUgYWxzbyBkZXBlbmRpbmcgb24g dGhlDQpkb21haW4gc3BlY2lmaWVkIHZpYSB0aGUgc2Vjb25kIHBhcmFtZXRlcj8gSW4gY2Fz ZSBpdCBpc24ndCwgd2h5IGRvZXMgdGhhdA0KcGFyYW1ldGVyIGV2ZW4gZXhpc3Q/DQoNCg0K SnVlcmdlbg0K --------------wTeax1LXCXbzJqxcuuMG6NSl Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------wTeax1LXCXbzJqxcuuMG6NSl-- --------------sjLKwfXhK0tKd9Q2bGaxUaA7-- --------------kMsB1mAB7fj1RnTAIn2sTf0i Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmRRDGEFAwAAAAAACgkQsN6d1ii/Ey+E vwf7Bj/AW2e3YlGXtK2EzdoSzUIvg1jbx7l6aodqBSCPKlePgvW9LejgbmI6LNzl/nXPCgEGke1y gLLyufR1XqiTdngcQTeW2Klx18n0lxleHC0wMCNFJlcqtfiKcKLZu0K3dJjkP/d4ljV42vwlJD5u 4M1SuHguS5VKv8NhwqUb0NBvazN6pg2481LAwapyKFeh+SFvXsjGVo2aE0pR5kQa17R5ZBvnJ9OP ZUCX47fFG4yVtWR1RxmsRieZTGK0XAysv94PokZSqtgE5bF4vCEfk1AUXmXo/KcaN+y3hoJ0y2Ee qi8m9bKS5OpNxwxtacwmpGLpCbspz/978sF9jj72Pw== =Df7a -----END PGP SIGNATURE----- --------------kMsB1mAB7fj1RnTAIn2sTf0i-- From xen-devel-bounces@lists.xenproject.org Tue May 02 13:13:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 13:13:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528605.821975 (Exim 4.92) (envelope-from ) id 1ptppD-000272-Re; Tue, 02 May 2023 13:13:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528605.821975; Tue, 02 May 2023 13:13:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptppD-00026v-Ov; Tue, 02 May 2023 13:13:47 +0000 Received: by outflank-mailman (input) for mailman id 528605; Tue, 02 May 2023 13:13:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptppC-0001XX-HU for xen-devel@lists.xenproject.org; Tue, 02 May 2023 13:13:46 +0000 Received: from sender3-of-o57.zoho.com (sender3-of-o57.zoho.com [136.143.184.57]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 296b7a5f-e8eb-11ed-8611-37d641c3527e; Tue, 02 May 2023 15:13:44 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 168303321714554.42914743891174; Tue, 2 May 2023 06:13:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 296b7a5f-e8eb-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1683033219; cv=none; d=zohomail.com; s=zohoarc; b=DsQx1ESOzcVBBH2ANjAdHbaBnC4tR7oXlnEkDVluQxGPrxObtvhUb8qjW3ritVo5WWJDejqqTDTjcFtsmjpBMT3T0lhk9TJOPHx9mmBxpuAmAtCAxMi6APjG1zlym2oB2zRn78RzaN8NVUOjKDb9D1YqxnUdya4oZTbk/jZaOFM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1683033219; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=uGj/pRqsgttZ5oVhJc1QbtEHDuuAij/v2kcj4sZAlMc=; b=Zm5MBp5CVjOXAtHO3HyP+0SRyT+t1GPCx4oMkek8gtPIkpKaA1OY1oHONitQSu2GHJMTIxo0NloMM/LFx7WpkMoKOZgo8kZ6fbDCwFETwTYAECYwMqX84sL9K3jMQvd5s5HPIhFXnKWGuDTGnq/KVRO90XJbgHplrjO4CaIZhYU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1683033219; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=uGj/pRqsgttZ5oVhJc1QbtEHDuuAij/v2kcj4sZAlMc=; b=m4dNLS0RGeNXCYU8fX3aR82Czddukbn7X233xE/IReNvI44Kx6g0PjSChyahQqUf 3SL/ZTNInQCfUxShhP0x48G5cnSPnAiURsb8RRdIwWnTdGpgOrB1uXbj4U2VBGUNL3R z+wSXn5BUGrCbLJ5cjsa5IIEM/fyDwpDZk+6/FMg= Message-ID: Date: Tue, 2 May 2023 09:13:35 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Jan Beulich , "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu References: <26064a5a-423d-ded5-745e-61abb0fa601c@suse.com> <600c8c62-5982-ec7e-7996-5b7fbfb40067@apertussolutions.com> From: "Daniel P. Smith" Subject: Re: [PATCH] sysctl: XSM hook should not cause XEN_SYSCTL_getdomaininfolist to (appear to) fail In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 5/2/23 07:00, Roger Pau Monné wrote: > On Tue, May 02, 2023 at 06:43:33AM -0400, Daniel P. Smith wrote: >> >> >> On 5/2/23 03:17, Jan Beulich wrote: >>> Unlike for XEN_DOMCTL_getdomaininfo, where the XSM check is intended to >>> cause the operation to fail, in the loop here it ought to merely >>> determine whether information for the domain at hand may be reported >>> back. Therefore if on the last iteration the hook results in denial, >>> this should not affect the sub-op's return value. >>> >>> Fixes: d046f361dc93 ("Xen Security Modules: XSM") >>> Signed-off-by: Jan Beulich >>> --- >>> The hook being able to deny access to data for certain domains means >>> that no caller can assume to have a system-wide picture when holding the >>> results. >>> >>> Wouldn't it make sense to permit the function to merely "count" domains? >>> While racy in general (including in its present, "normal" mode of >>> operation), within a tool stack this could be used as long as creation >>> of new domains is suppressed between obtaining the count and then using >>> it. >>> >>> In XEN_DOMCTL_getpageframeinfo2 said commit had introduced a 2nd such >>> issue, but luckily that sub-op and xsm_getpageframeinfo() are long gone. >>> >> >> I understand there is a larger issue at play here but neutering the security >> control/XSM check is not the answer. This literally changes the way a FLASK >> policy that people currently have would be enforced, as well as contrary to >> how they understand the access control that it provides. Even though the >> code path does not fall under XSM maintainer, I would NACK this patch. IMHO, >> it is better to find a solution that does not abuse, misuse, or invalidate >> the purpose of the XSM calls. >> >> On a side note, I am a little concern that only one person thought to >> include the XSM maintainer, or any of the XSM reviewers, onto a patch and >> the discussion around a patch that clearly relates to XSM for us to gauge >> the consequences of the patch. I am not assuming intentions here, only >> wanting to raise the concern. >> >> So for what it is worth, NACK. > > I assume the NACK is to the remarks after the '---'? > > The patch itself doesn't change the enforcement of the XSM checks, > just prevents returning an error when the information from the last > domain in the loop can not be fetched. > > Am I missing something? Actually, I should have finished my first cup of tea and looked closer at the patch in the larger context instead of the description, as the two do not align. You are correct, and provided I am not wrong here, the change is a no-op formatting change that removes an intermediate variable. I do not see how directly checking the return in an if versus checking the return stored in a variable. Additionally, the claim is that this occurs when XSM is enabled, which is also incorrect. The only difference at this location in code between not having XSM enabled and having it enabled is that for the latter, xsm_getdomaininfo() is an in-lined version versus a function call. In either case, both will return 0 unless you are using FLASK and have a policy blocking the domain from making the call. V/r, Daniel P. Smith From xen-devel-bounces@lists.xenproject.org Tue May 02 13:16:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 13:16:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528608.821985 (Exim 4.92) (envelope-from ) id 1ptps0-0002mE-9W; Tue, 02 May 2023 13:16:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528608.821985; Tue, 02 May 2023 13:16:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptps0-0002m7-6F; Tue, 02 May 2023 13:16:40 +0000 Received: by outflank-mailman (input) for mailman id 528608; Tue, 02 May 2023 13:16:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptprz-0002m1-Bm for xen-devel@lists.xenproject.org; Tue, 02 May 2023 13:16:39 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0621.outbound.protection.outlook.com [2a01:111:f400:fe0c::621]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 91b309a9-e8eb-11ed-b225-6b7b168915f2; Tue, 02 May 2023 15:16:38 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB10003.eurprd04.prod.outlook.com (2603:10a6:800:1e1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.27; Tue, 2 May 2023 13:16:35 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6340.030; Tue, 2 May 2023 13:16:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 91b309a9-e8eb-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oJ3KZvBf2B0vzXhiefkVsiNqMULOUpmn95OoBoia67ruP+Ji+PhhfKA/heo0di5174WmeR6Yg1ge3tjYk1FxjogCWZ/410pWGc8rV0Vs/a+Rlodd/GCfasScrDnW3ueP0O+63CN1wzka+/Vv8PRKDQttMdbBfO19dFByORJqpAATQONzJXFdp/+NBsceZMOQWi9/l66rr+FF4w2wEVzTXADHKQiVNiu6gq5KZ0cI66EJeW4c0bTBr6+FEOJn38Gm+RWMls6zd/pN5plbwttdinbBY6PJguyiaty4oKC+Zrh2SQoKNl33cniWIqLE7gMJUKxLLOJpOwFCq/yU/PCPUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p5vUR8qPbyRvK1zt8gvDOYqVk5VfhmNIvpXaUejS8Ok=; b=VMRsT2GByfe+lvGQGNB0sj/MLzfz16+VUKjPX4xKtKtgk/Co5mgiUtpB158NkxAg91lYhpwd8NRg6fkTAxLxn+toZb4P7w3OEh0VSVVfbS7B6XysKngo/5o2Kc0ymuiHgeFKUyva2GvV+CYYHO1AbcN/KOp3sd2ibnyvS5O95T2y+ujL6/CfvXqhXEk0fkyDdakqxvfawHdYOflpdkozgl8KEAA7eGAbPSwCalPKdXgRvRBZkNLKpneo08USGa403GrzpSJ2pCTdgFTm5I4Sq94xn/syHiPWoBSpK8EZF1d7lTNe+sUPD6YsXFu3PhIAGKb8qCF2euzC5ZdsPd8jpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p5vUR8qPbyRvK1zt8gvDOYqVk5VfhmNIvpXaUejS8Ok=; b=TMebciRVbRZObZ9wzvnqmmsJAN9gzXXoUlQNc03ajjlduqv4x1lDjDiO9gj7cAK6l2i/U3BM66Yvb31Xz+7BgOnmJN67s7Vsedwy4hXHhrzYbiNLpcesuocYADHkTBcPjwbv09JnNUYaQ5lKZbEH0Jpa6Jmvq4qRfxCMx3PiQpQk4ah4EIPkOimxmhjuNpyG9XVYOUKab7Rr+P7NyqRIhsO//NgN+hWaJZsO5gvQ+ll4gRM6QD4+LzpBuEaiIEwcnbphmy031c9XQHp1cee9v1iuN2MyBU0v/utfmhHsXrJrwshIOh5O3V63jTrnmGvCOodTJ/ziPgkNSVBKhxCBDQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0ff2af4f-db6a-71b9-649c-028bf4148eb2@suse.com> Date: Tue, 2 May 2023 15:16:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH] sysctl: XSM hook should not cause XEN_SYSCTL_getdomaininfolist to (appear to) fail Content-Language: en-US To: "Daniel P. Smith" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <26064a5a-423d-ded5-745e-61abb0fa601c@suse.com> <600c8c62-5982-ec7e-7996-5b7fbfb40067@apertussolutions.com> <22b2e03c-ac5e-915a-78a2-0a632b09a53a@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0182.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9f::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB10003:EE_ X-MS-Office365-Filtering-Correlation-Id: 042848df-5c30-4928-9fd0-08db4b0f7457 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HFM6EyUMNIVOfETbZzVPcLUJTv48AUYr2JZR6UAbV+ggX9+dd/OQCyH624oj81dnXAbC8MGl5jXGV0TsZsg/irgKvMFHdNZJQPlFdVPjqIdT2GDxsr7SN0N0mmDZaFWm9GfNygzrh8EVrsgJde3PI0GfMx5NiU8qTQXXSClaVuGhA9wRN4u1lPT/+mpFpR4IkPVRXyUCgvmuHwqJnE4lXcCWgpi7Ffsb7I46+WYkQCRJ1tdLKKkS9mxNB9r+fnr96fgpO/LnffzsTPc6/K/hzrR+5/NcIbsAMeiHV6l5XRNbVQKZhhc5KFZYFMPjsqtbHlbAGCsCsGiSxxiOHxsK51Fq+9W8mNe50vKKi00GtECMkoOYJREup5M8Fkfehc/lT9B7E/vedIjWOkm/emccw3GkJaglowKGHv0O2vC/hxeZYX7rnfG2Pe8IkRYq0jFzMMgkI2TbgoHGTWAQ+ZoDwMsVrU+tLYiMUJ75dgzUD6itiA4odtT6479GkuuV47X/AaR6laQQ/UsVrdgc2D5wJfAANtxtUM4dQStAdOmh4nvZefx5HHcvXbGWe/i+/kJbKgAG0lLv9w8w7lI7nvkud0QOfqC5lQpk1Qz5zoKBLN+ihwJ79SUETCbBN3sEGGG3IWc3eWSzk4GOIVNE7y2GDw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39850400004)(136003)(346002)(376002)(396003)(366004)(451199021)(2616005)(6916009)(66946007)(66556008)(316002)(66476007)(41300700001)(4326008)(83380400001)(6486002)(54906003)(478600001)(8936002)(8676002)(38100700002)(5660300002)(2906002)(31686004)(186003)(6512007)(6506007)(53546011)(26005)(31696002)(86362001)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TXNCWEJmenVKUzE2UFpkVVVUWGlsdnB3Z2VtN045OEpqRFNXVURDR0p1YmNi?= =?utf-8?B?T0hhRXNRanMzL2RCSkt0b0ptL3hxYlFVb3NJNDFpWTBzLys2NEliSWZWOGNZ?= =?utf-8?B?dlhlMXhNNWFxTGdvWHB5T0pVYUhUOUxwaGNoU2NQelRNa2hnRksweE1DNFNW?= =?utf-8?B?ZzR6SlUrUStMOFJNMXZFdE1VTjY4VlZuRFgrQnBVdkQxZXBTTmEyOTJidjlO?= =?utf-8?B?aHorZGNDU0hIRUlKM1lud2JmZytHeGtnZklwQnE2cS85UlVtT0VmVmR3b2hU?= =?utf-8?B?ZmhTSkcxZ3ZaZVVxYXB0S3F0WEQ3UDludXlpL3FwSFErbW5LdmRLcjlhSGhz?= =?utf-8?B?TGtSc2hsVURxbkhZTkp3a2J1aGhYeWorWXJuUUF2NFpPekVUTGR1eW0rbnBr?= =?utf-8?B?MnRjUVV1U092VGlJNDFNZ1ZtSjJ2Y3A3dXBSczU2cUtQT0FkalRzeXlNZCta?= =?utf-8?B?SHlRR2VpcWc4elhTaHoyWlZrVFYxdkN2b3NqZU1XZ203c3hIZE11Nm04cVRj?= =?utf-8?B?S2trcUx6Q01MYlFBWGVVNE1qNmlrOG8vS0IyZ05Zb1Q4TEg3YzlWditjcG5D?= =?utf-8?B?QlRUQ1Q5dGFrV1RFUkNrZDllM0N2Smh1U1NuNlN5Y1JlaTc3bG1HaE9XV3pN?= =?utf-8?B?WW5UOHJWV3NSNlhtYU56anBPVjBKNVAxb2o3VDh1WDM2MzdmMjUxblltaERt?= =?utf-8?B?SGlkdDIrSnRnTVJhVU9rZW5hbkZDWUg2OWt6VVpMbDMxZUVUMXZQVFQwTmVL?= =?utf-8?B?SWl5NWtkOWdvL25sK3Q1QVgxRTFzWld0QVhLRzNRbUU0dnhnMWY3aEE1YlNa?= =?utf-8?B?bUN0MGxaWnVZVDRDcnBaRWRKRDlSbkZzRkJPTVVpZlVUeVlRQUFQNk5lcnlT?= =?utf-8?B?ajBoMEhLeGxvZ1BQZ1FPTjRIaDR5b3Zua2NDcVcxd1BtMEpaNTQwNlh1U2k3?= =?utf-8?B?dlI5VGVGN1NYZ25vZ1dOSGkvbGNCSG05OWEzdlI0OHc4dUdrMFcrOEhXT3Vh?= =?utf-8?B?Tk1pcHZyenVueFNqdGxTd2gyRU5KVTVQQUVQV1BtOG1EWDRlODZNMmt1MjJ3?= =?utf-8?B?RDY4ZVVQSmtDcHFyL2pqZDZCSjB3dmFoWlBsNEI0cUpDbldBR0pIcTYwTGxt?= =?utf-8?B?clhmREpUd3FJcThUaDdVQWVHTlNFbDcxNzB3bk9SejQ5L0h5Vmh6ZXhDeCtt?= =?utf-8?B?RStOTDhLVEU1dnFrUEZlUHJBUE4zNCtNN3dIbHVZYzNLQlZlNTQvVGpYdGIy?= =?utf-8?B?OS8yRElMQW1CSnIwbkEzcWpKelBMaFpiU2RpS1dDT0N5MDlpMUJmOEJQTFhU?= =?utf-8?B?THhWUlQyZ0VseS9PK2FrSkFQc2pzb2lnM3hhenJ5Nkg0cWhpaG5ya08wN1Zk?= =?utf-8?B?N2RseVJaQjBadnRtVXBHZ0NhZmtyOWVLVk1hMHUrUk93VGpzY1dUR2dQV1JI?= =?utf-8?B?YjNqNVZpejJENEJzQ3YyOWlLaytYV0VwTXBwRFU1Ulc1Y0g3ZFVyeEJ3SUdD?= =?utf-8?B?aFF2d0Z3dDJJaFN3SEpQMTRQTzArODlkVzJJV3QvRHQzcGJPdzRWWWFxUkxm?= =?utf-8?B?SkxMSjh0Z0tQMDg1aW9VRjdMZTduNDAydUZSNkRyM0tyRzR5djVsaWh5VzJ1?= =?utf-8?B?S3hiZ2haaVBzbDZnR3FnWUFzWm1kWGJ2QlNCOXJLaGlFUDhEN2J4MkIyZVlC?= =?utf-8?B?Rjc3aEE5dVNZc1IvbDM2anVCZm5TZDVuZ1NtdnN5V0tXLzEwTmhQZVhGT0hW?= =?utf-8?B?RnA4dlFiNlFuRjFGYkl6MzVKZVJiUnhrcm10TzMzbW1HRmx6K294SnBDKzlF?= =?utf-8?B?TXZROG4rMlc3RWJiQzlkSzFlcWo5dW80Lzk1L2dENGswclhlOEdMa2xRVnF3?= =?utf-8?B?V00wRjdkRzVJZDJMWDFnWUI5KzFkTHZVL2VDNktVSlNJUEF6N1RYMVM2S2JI?= =?utf-8?B?T0J4QUtrYXpkSUVjbys5K3NLMjk3Y256VEVFMDRJM2ViSGNvQnZOYzM2OEVu?= =?utf-8?B?L09qZmZmc1NaVkFWSTltcEFINmlMSjA3c3RYTndPWGJ3cWY0MkJEZUZ5dThC?= =?utf-8?B?Z1F0UnVJbTgrOG5hY21DK0s5YTB3aXZnSFZXRDBQZ1dBSjdTNWwxN3hWRkQ4?= =?utf-8?Q?iWAAAhQg+i0W23rNGK5J/1tmG?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 042848df-5c30-4928-9fd0-08db4b0f7457 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 13:16:35.3348 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HZW6ReGWRh6w8qzEM9N4Hfi+rF6PLzaNHEoFkB/eyTML0s/7RtJR3IuUxFeGVQIilTynLc0H2qaFve29am9wjg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB10003 On 02.05.2023 14:54, Daniel P. Smith wrote: > On 5/2/23 06:59, Jan Beulich wrote: >> On 02.05.2023 12:43, Daniel P. Smith wrote: >>> On 5/2/23 03:17, Jan Beulich wrote: >>>> Unlike for XEN_DOMCTL_getdomaininfo, where the XSM check is intended to >>>> cause the operation to fail, in the loop here it ought to merely >>>> determine whether information for the domain at hand may be reported >>>> back. Therefore if on the last iteration the hook results in denial, >>>> this should not affect the sub-op's return value. >>>> >>>> Fixes: d046f361dc93 ("Xen Security Modules: XSM") >>>> Signed-off-by: Jan Beulich >>>> --- >>>> The hook being able to deny access to data for certain domains means >>>> that no caller can assume to have a system-wide picture when holding the >>>> results. >>>> >>>> Wouldn't it make sense to permit the function to merely "count" domains? >>>> While racy in general (including in its present, "normal" mode of >>>> operation), within a tool stack this could be used as long as creation >>>> of new domains is suppressed between obtaining the count and then using >>>> it. >>>> >>>> In XEN_DOMCTL_getpageframeinfo2 said commit had introduced a 2nd such >>>> issue, but luckily that sub-op and xsm_getpageframeinfo() are long gone. >>>> >>> >>> I understand there is a larger issue at play here but neutering the >>> security control/XSM check is not the answer. This literally changes the >>> way a FLASK policy that people currently have would be enforced, as well >>> as contrary to how they understand the access control that it provides. >>> Even though the code path does not fall under XSM maintainer, I would >>> NACK this patch. IMHO, it is better to find a solution that does not >>> abuse, misuse, or invalidate the purpose of the XSM calls. >>> >>> On a side note, I am a little concern that only one person thought to >>> include the XSM maintainer, or any of the XSM reviewers, onto a patch >>> and the discussion around a patch that clearly relates to XSM for us to >>> gauge the consequences of the patch. I am not assuming intentions here, >>> only wanting to raise the concern. >> >> Well, yes, for the discussion items I could have remembered to include >> you. The code change itself, otoh, doesn't require your ack, even if it >> is the return value of an XSM function which was used wrongly here. > > I beg to disagree, not that you could have, but that you should have. > This is now the second XSM issue, that I am aware of at least, that > myself and the XSM reviewers have been left out of. How and where the > XSM hooks are deployed are critical to how XSM function, regardless of > how mundane the change may be. By your logic, as the XSM maintainer I > can make changes to the XSM code that changes how the system behaves for > x86 and claim you have no Ack/Nack authority since it is XSM code. These > subsystems are symbiotic, and we owe each other the due respect to > include to the other when these systems touch or influence each other. No, that's not a proper representation of "my logic". Everyone can comment on any patch, and pending objections will prevent it from going in. Still not everyone needs to be Cc-ed on every patch. If you want to get to see ones you're not Cc-ed on, you'll need to be subscribed to the list, to look at (and perhaps comment on) all the ones of interest to you. Jan From xen-devel-bounces@lists.xenproject.org Tue May 02 13:17:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 13:17:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528611.821994 (Exim 4.92) (envelope-from ) id 1ptpt0-0003Ir-IM; Tue, 02 May 2023 13:17:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528611.821994; Tue, 02 May 2023 13:17:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptpt0-0003Ik-FL; Tue, 02 May 2023 13:17:42 +0000 Received: by outflank-mailman (input) for mailman id 528611; Tue, 02 May 2023 13:17:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptpsy-0003IY-V1 for xen-devel@lists.xenproject.org; Tue, 02 May 2023 13:17:40 +0000 Received: from sender3-of-o59.zoho.com (sender3-of-o59.zoho.com [136.143.184.59]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b5f6a33f-e8eb-11ed-b225-6b7b168915f2; Tue, 02 May 2023 15:17:39 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1683033455258422.6280237200574; Tue, 2 May 2023 06:17:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b5f6a33f-e8eb-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1683033455; cv=none; d=zohomail.com; s=zohoarc; b=bKgVqM1cUjQg1RE4Z6Kx69DSsRAw4rMDqvv6/Sy2O23QeM5wbXrA0LI7luRdXAA/4dQw/9Ws5WwK9qMhCm1a8suuRhTktwnWhJwHo9YS5fF+o8M7ojwnViVEQTy17sXfZw7idmwx7uuC6KslLYd3sXcfZ7W/IfaUsqTeBLh39jI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1683033455; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Bj4+tCe/Djy4x77OBozlm/+/KUc/w8n08KGpXcqAFa0=; b=PfzrMRF/rh23CiCZobBufEefvheYPU8Fgodc/pFxKVuVUhu406UagzdU9voi/3QdAp0WFl2VVNZ85deMgIjMllE3ilpnJ5aVXrAHgWrA/VRea7cQh0cpmFbxD9LSE3g0PHNQUtnIWio1BOyO7zr7GYMADceR0xa65Z6ppMFBR0I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1683033455; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=Bj4+tCe/Djy4x77OBozlm/+/KUc/w8n08KGpXcqAFa0=; b=FgKzUjC/XehD1nI7NB2OdpPDvu9CCWiYUInyMEZe5qAO0E4oNWZZzWdt53yj/hyw cxHP95XG4PoLfEjXhrRfPJWPpVwZEJcn1F8TnU8b8eGKT9KwbLbZwl7Gm014ZU8K2S/ m5+W2Le2wwJ9jMaKEbjc04GeUDuX3C1J1mCY6JAw= Message-ID: <8eeb34f6-0889-c2e4-d2fc-e0319f032a97@apertussolutions.com> Date: Tue, 2 May 2023 09:17:33 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] xen/sysctl: fix XEN_SYSCTL_getdomaininfolist handling with XSM Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Juergen Gross , xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu References: <20230430144646.13624-1-jgross@suse.com> <0c01a75d-8a98-3931-28fa-68ed373e9a2e@apertussolutions.com> From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 5/2/23 09:10, Roger Pau Monné wrote: > On Tue, May 02, 2023 at 09:03:00AM -0400, Daniel P. Smith wrote: >> On 4/30/23 10:46, Juergen Gross wrote: >>> In case XSM is active, the handling of XEN_SYSCTL_getdomaininfolist >>> can fail if the last domain scanned isn't allowed to be accessed by >>> the calling domain (i.e. xsm_getdomaininfo(XSM_HOOK, d) is failing). >>> >>> Fix that by just ignoring scanned domains where xsm_getdomaininfo() >>> is returning an error, like it is effectively done when such a >>> situation occurs for a domain not being the last one scanned. >>> >>> Fixes: d046f361dc93 ("Xen Security Modules: XSM") >>> Signed-off-by: Juergen Gross >>> --- >>> xen/common/sysctl.c | 3 +-- >>> 1 file changed, 1 insertion(+), 2 deletions(-) >>> >>> diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c >>> index 02505ab044..0cbfe8bd44 100644 >>> --- a/xen/common/sysctl.c >>> +++ b/xen/common/sysctl.c >>> @@ -89,8 +89,7 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl) >>> if ( num_domains == op->u.getdomaininfolist.max_domains ) >>> break; >>> - ret = xsm_getdomaininfo(XSM_HOOK, d); >>> - if ( ret ) >>> + if ( xsm_getdomaininfo(XSM_HOOK, d) ) >>> continue; >>> getdomaininfo(d, &info); >> >> >> This change does not match the commit message. This says it fixes an issue, >> but unless I am totally missing something, this change is nothing more than >> formatting that drops the use of an intermediate variable. Please feel free >> to correct me if I am wrong here, otherwise I believe the commit message >> should be changed to reflect the code change. > > By dropping that intermediate variable it prevents returning an error > as the result of the hypercall if xsm_getdomaininfo() for the last > domain fails. Ah, understood. I missed ret is state tracking. > Note that xsm_getdomaininfo() failing for other domains not the last > one don't cause the return value of the hypercall to be an error > code, because the variable containing the error gets overwritten by > further loops. In the end, this is just addressing an issue that has not been seen by anyone and happened upon while debugging another issue. V/r, DPS From xen-devel-bounces@lists.xenproject.org Tue May 02 13:20:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 13:20:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528615.822005 (Exim 4.92) (envelope-from ) id 1ptpvO-0004lc-V7; Tue, 02 May 2023 13:20:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528615.822005; Tue, 02 May 2023 13:20:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptpvO-0004lV-S5; Tue, 02 May 2023 13:20:10 +0000 Received: by outflank-mailman (input) for mailman id 528615; Tue, 02 May 2023 13:20:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptpvN-0004lN-E4 for xen-devel@lists.xenproject.org; Tue, 02 May 2023 13:20:09 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0df6aea5-e8ec-11ed-8611-37d641c3527e; Tue, 02 May 2023 15:20:07 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-246-Y31MKCByMBe1jCFod_G6kw-1; Tue, 02 May 2023 09:19:59 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 107073828886; Tue, 2 May 2023 13:19:58 +0000 (UTC) Received: from redhat.com (unknown [10.39.193.211]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C1880C15BAD; Tue, 2 May 2023 13:19:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0df6aea5-e8ec-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683033606; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fGVklx9CdfvOhMG8evo/8EfQSW2qxZF5lAkrucGYcTQ=; b=NXq8nynpAATIIptmj2iJd7mKqe/yKxOWXihrIB0I/EJATr2Vvde9rf6/FrvVUVYvHZ01n9 6WzEntsxzAsY4AgQ68ozxRkQyxOCFPWs0mNqCPkLbfJlEoHB7nEjrTgx/vgsu5avIJfgnB vo7aQ6J43ivVol52tfxSNCjWr91vDC8= X-MC-Unique: Y31MKCByMBe1jCFod_G6kw-1 Date: Tue, 2 May 2023 15:19:52 +0200 From: Kevin Wolf To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Juan Quintela , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Richard Henderson , Fam Zheng , "Michael S. Tsirkin" , Coiby Xu , David Woodhouse , Marcel Apfelbaum , Peter Lieven , Paul Durrant , "Richard W.M. Jones" , qemu-block@nongnu.org, Stefano Garzarella , Anthony Perard , Stefan Weil , Xie Yongji , Paolo Bonzini , Aarushi Mehta , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Eduardo Habkost , Stefano Stabellini , Hanna Reitz , Ronnie Sahlberg , Zhengui Li , Daniil Tatianin Subject: Re: [PATCH v4 04/20] virtio-scsi: stop using aio_disable_external() during unplug Message-ID: References: <20230425172716.1033562-1-stefanha@redhat.com> <20230425172716.1033562-5-stefanha@redhat.com> <20230501150934.GA14869@fedora> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="YXC5ZjyIo1QEPFar" Content-Disposition: inline In-Reply-To: <20230501150934.GA14869@fedora> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 --YXC5ZjyIo1QEPFar Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 01.05.2023 um 17:09 hat Stefan Hajnoczi geschrieben: > On Fri, Apr 28, 2023 at 04:22:55PM +0200, Kevin Wolf wrote: > > Am 25.04.2023 um 19:27 hat Stefan Hajnoczi geschrieben: > > > This patch is part of an effort to remove the aio_disable_external() > > > API because it does not fit in a multi-queue block layer world where > > > many AioContexts may be submitting requests to the same disk. > > >=20 > > > The SCSI emulation code is already in good shape to stop using > > > aio_disable_external(). It was only used by commit 9c5aad84da1c > > > ("virtio-scsi: fixed virtio_scsi_ctx_check failed when detaching scsi > > > disk") to ensure that virtio_scsi_hotunplug() works while the guest > > > driver is submitting I/O. > > >=20 > > > Ensure virtio_scsi_hotunplug() is safe as follows: > > >=20 > > > 1. qdev_simple_device_unplug_cb() -> qdev_unrealize() -> > > > device_set_realized() calls qatomic_set(&dev->realized, false) so > > > that future scsi_device_get() calls return NULL because they exclu= de > > > SCSIDevices with realized=3Dfalse. > > >=20 > > > That means virtio-scsi will reject new I/O requests to this > > > SCSIDevice with VIRTIO_SCSI_S_BAD_TARGET even while > > > virtio_scsi_hotunplug() is still executing. We are protected again= st > > > new requests! > > >=20 > > > 2. Add a call to scsi_device_purge_requests() from scsi_unrealize() so > > > that in-flight requests are cancelled synchronously. This ensures > > > that no in-flight requests remain once qdev_simple_device_unplug_c= b() > > > returns. > > >=20 > > > Thanks to these two conditions we don't need aio_disable_external() > > > anymore. > > >=20 > > > Cc: Zhengui Li > > > Reviewed-by: Paolo Bonzini > > > Reviewed-by: Daniil Tatianin > > > Signed-off-by: Stefan Hajnoczi > >=20 > > qemu-iotests 040 starts failing for me after this patch, with what looks > > like a use-after-free error of some kind. > >=20 > > (gdb) bt > > #0 0x000055b6e3e1f31c in job_type (job=3D0xe3e3e3e3e3e3e3e3) at ../job= =2Ec:238 > > #1 0x000055b6e3e1cee5 in is_block_job (job=3D0xe3e3e3e3e3e3e3e3) at ..= /blockjob.c:41 > > #2 0x000055b6e3e1ce7d in block_job_next_locked (bjob=3D0x55b6e72b7570)= at ../blockjob.c:54 > > #3 0x000055b6e3df6370 in blockdev_mark_auto_del (blk=3D0x55b6e74af0a0)= at ../blockdev.c:157 > > #4 0x000055b6e393e23b in scsi_qdev_unrealize (qdev=3D0x55b6e7c04d40) a= t ../hw/scsi/scsi-bus.c:303 > > #5 0x000055b6e3db0d0e in device_set_realized (obj=3D0x55b6e7c04d40, va= lue=3Dfalse, errp=3D0x55b6e497c918 ) at ../hw/core/qdev.c:599 > > #6 0x000055b6e3dba36e in property_set_bool (obj=3D0x55b6e7c04d40, v=3D= 0x55b6e7d7f290, name=3D0x55b6e41bd6d8 "realized", opaque=3D0x55b6e7246d20, = errp=3D0x55b6e497c918 ) > > at ../qom/object.c:2285 > > #7 0x000055b6e3db7e65 in object_property_set (obj=3D0x55b6e7c04d40, na= me=3D0x55b6e41bd6d8 "realized", v=3D0x55b6e7d7f290, errp=3D0x55b6e497c918 <= error_abort>) at ../qom/object.c:1420 > > #8 0x000055b6e3dbd84a in object_property_set_qobject (obj=3D0x55b6e7c0= 4d40, name=3D0x55b6e41bd6d8 "realized", value=3D0x55b6e74c1890, errp=3D0x55= b6e497c918 ) > > at ../qom/qom-qobject.c:28 > > #9 0x000055b6e3db8570 in object_property_set_bool (obj=3D0x55b6e7c04d4= 0, name=3D0x55b6e41bd6d8 "realized", value=3Dfalse, errp=3D0x55b6e497c918 <= error_abort>) at ../qom/object.c:1489 > > #10 0x000055b6e3daf2b5 in qdev_unrealize (dev=3D0x55b6e7c04d40) at ../h= w/core/qdev.c:306 > > #11 0x000055b6e3db509d in qdev_simple_device_unplug_cb (hotplug_dev=3D0= x55b6e81c3630, dev=3D0x55b6e7c04d40, errp=3D0x7ffec5519200) at ../hw/core/q= dev-hotplug.c:72 > > #12 0x000055b6e3c520f9 in virtio_scsi_hotunplug (hotplug_dev=3D0x55b6e8= 1c3630, dev=3D0x55b6e7c04d40, errp=3D0x7ffec5519200) at ../hw/scsi/virtio-s= csi.c:1065 > > #13 0x000055b6e3db4dec in hotplug_handler_unplug (plug_handler=3D0x55b6= e81c3630, plugged_dev=3D0x55b6e7c04d40, errp=3D0x7ffec5519200) at ../hw/cor= e/hotplug.c:56 > > #14 0x000055b6e3a28f84 in qdev_unplug (dev=3D0x55b6e7c04d40, errp=3D0x7= ffec55192e0) at ../softmmu/qdev-monitor.c:935 > > #15 0x000055b6e3a290fa in qmp_device_del (id=3D0x55b6e74c1760 "scsi0", = errp=3D0x7ffec55192e0) at ../softmmu/qdev-monitor.c:955 > > #16 0x000055b6e3fb0a5f in qmp_marshal_device_del (args=3D0x7f61cc005eb0= , ret=3D0x7f61d5a8ae38, errp=3D0x7f61d5a8ae40) at qapi/qapi-commands-qdev.c= :114 > > #17 0x000055b6e3fd52e1 in do_qmp_dispatch_bh (opaque=3D0x7f61d5a8ae08) = at ../qapi/qmp-dispatch.c:128 > > #18 0x000055b6e4007b9e in aio_bh_call (bh=3D0x55b6e7dea730) at ../util/= async.c:155 > > #19 0x000055b6e4007d2e in aio_bh_poll (ctx=3D0x55b6e72447c0) at ../util= /async.c:184 > > #20 0x000055b6e3fe3b45 in aio_dispatch (ctx=3D0x55b6e72447c0) at ../uti= l/aio-posix.c:421 > > #21 0x000055b6e4009544 in aio_ctx_dispatch (source=3D0x55b6e72447c0, ca= llback=3D0x0, user_data=3D0x0) at ../util/async.c:326 > > #22 0x00007f61ddc14c7f in g_main_dispatch (context=3D0x55b6e7244b20) at= ../glib/gmain.c:3454 > > #23 g_main_context_dispatch (context=3D0x55b6e7244b20) at ../glib/gmain= =2Ec:4172 > > #24 0x000055b6e400a7e8 in glib_pollfds_poll () at ../util/main-loop.c:2= 90 > > #25 0x000055b6e400a0c2 in os_host_main_loop_wait (timeout=3D0) at ../ut= il/main-loop.c:313 > > #26 0x000055b6e4009fa2 in main_loop_wait (nonblocking=3D0) at ../util/m= ain-loop.c:592 > > #27 0x000055b6e3a3047b in qemu_main_loop () at ../softmmu/runstate.c:731 > > #28 0x000055b6e3dab27d in qemu_default_main () at ../softmmu/main.c:37 > > #29 0x000055b6e3dab2b8 in main (argc=3D24, argv=3D0x7ffec55196a8) at ..= /softmmu/main.c:48 > > (gdb) p jobs > > $4 =3D {lh_first =3D 0x0} >=20 > I wasn't able to reproduce this with gcc 13.1.1 or clang 16.0.1: >=20 > $ tests/qemu-iotests/check -qcow2 040 >=20 > Any suggestions on how to reproduce the issue? It happens consistently for me with the same command line, both with gcc and clang. gcc (GCC) 12.2.1 20221121 (Red Hat 12.2.1-4) clang version 15.0.7 (Fedora 15.0.7-2.fc37) Maybe there is a semantic merge conflict? I have applied the series on top of master (05d50ba2d4) and my block branch (88f81f7bc8). Kevin --YXC5ZjyIo1QEPFar Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE3D3rFZqa+V09dFb+fwmycsiPL9YFAmRRDfgACgkQfwmycsiP L9Y3GRAAvRZ6+kD/AtNTvIukd+aeUv2vJhX2aEdXyjX3LKPe/VI+W1xE+g5PTbKs oJePLOmjUPGvu2SRyquYTMW10Ap0+syE+iiEM4O7KaAmrM3pEdfxOdo782IAVy+o 61Ro0DyE8Is1MzLXswSckkArZq5xuiV4PSKBEL/B+Th+GzSCc8+Z8btZhj4hjNN1 KMBQnSSSaGagMLENz0DLHTZADfSRGqASNCO3Gc4DhcK/RiJwD7ScWy6PkptZEsjx 1k6G7aIoa55X0qeqCsvcYUUNpAGzh2SGf+DaJ7IL36DPmQhuAvXffFFV98qrc1Yh MN8kV9/ZEL6fFVXD5QUv7sPy+2Nw760s8dv6NXyorwxqtV56ljkYcn7idbO2+HZn bmcgMQRBbVw8FdzXxDc1k53Bb0LhW0f/0A2iqn+GIwJXZq2IdEJ6sL+N43IN6L/L IJ8b+jrNvuVGD56cyY024FiJVfFEtyeLhN4QSbWgjmsy3TWAw4jZ28ZfSbpVI7ST d3H/j+LZkCQft65xjA09j/7mOd1qSPJjkykUY5uAiBssipogL6nj9aGJc0pkaxGB s5otr6zCgghfprNe+qsA+X4H/So09BjbFC1R3AomFNtJapWzvc0zzyB08HIpPho8 7yr7sTZINUS0aFOr8IG6fPrFR9p8ZNHtVvEIBRKtQMi3uV1Ca+M= =xmD/ -----END PGP SIGNATURE----- --YXC5ZjyIo1QEPFar-- From xen-devel-bounces@lists.xenproject.org Tue May 02 13:21:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 13:21:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528620.822015 (Exim 4.92) (envelope-from ) id 1ptpwA-0005Mm-Cm; Tue, 02 May 2023 13:20:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528620.822015; Tue, 02 May 2023 13:20:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptpwA-0005Mf-9W; Tue, 02 May 2023 13:20:58 +0000 Received: by outflank-mailman (input) for mailman id 528620; Tue, 02 May 2023 13:20:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptpw8-0005FV-Vv for xen-devel@lists.xenproject.org; Tue, 02 May 2023 13:20:56 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2059.outbound.protection.outlook.com [40.107.7.59]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2bcd9ab2-e8ec-11ed-b225-6b7b168915f2; Tue, 02 May 2023 15:20:56 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB7041.eurprd04.prod.outlook.com (2603:10a6:208:19a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.26; Tue, 2 May 2023 13:20:26 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6340.030; Tue, 2 May 2023 13:20:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2bcd9ab2-e8ec-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iMU04rxa9l5XTjyZJyUKkTEL1DRsQmF7BdOs/g3wrogTK+ELfNEYR03XiTs5Tk7l6u9OV3s0lyuxDysYUJvxcbQrZdxGTXaiplFUrFXR4eP/qDyIh9HiuBC3OJQ+WLJdErkQzdgMs4YZbT4Vo5iR3rbgaUczx72gGGx/ZQxK2NnzUVbDQQx9Impd5QUCpBAvAepUhZXPZ1wmkxkjIS9hzHpI8gxyd6wuyL00ih8+B3rcAsIDB9YgVT+C4diLQCEHvAXoVX8AU+gdF3mwcAIwUnQK/zhNGdHPK7iZrtPLRqOPZTIWUDievC2meP2llvbmSVPpHG26npcOkXcewJlGsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zwJg1hIV7/IcKn86O/iBIYSL1qO0b18JDv7CnuQlPJk=; b=QWP8KKIfwPxaF5Ee/ayHFxTSg0yo4bOLjBz8TCSFKmvKeE+NK4XbzLL8+DFIGeIw9947t8T0bkYi9Xfs29Hj9sk7SaFow7XDZ9eYAfxzZirbtPA+Fv/LYOqXRIsVBWMhi14QzEp2LX7Kj0gvlo8QaIsiGREAhhqpGAxd1ppiixTzX5uzSAzVtLr0ei5/90uLDa8zuABsIi93uoVNN0uPhCFe/kalDnUoKNm67qem9y6biPi7jayQijwcmyqSQvwXqdZTaYTgKgFJUHURx2XzLo+0BHAlVFFCx3mtDhKCB9ZKPzq9iZGJ9hWbkHNGC716Iqx90wva3Vsd7C3u1D7Nqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zwJg1hIV7/IcKn86O/iBIYSL1qO0b18JDv7CnuQlPJk=; b=LUisP/8IJctGnK+feS7dx02e58UpdCYmMpF6sHslUs6K9mRRGAY5VR6qTC4pNp39od9MvTaJn8/sme7zSVdtsVL96FAY+ezW/lPp2+dIbZawPH3YJOH3ssP59yDbtVMI2eOGz+ab5HBRWhSTmdEZgD4b+EmBQaIjZB8MSi379ThTSXeKrZKMjqXCJHzyUAWSFIOhhxmT95kRLOeuISmGYCuqZdISGEf0Zb6q/TQNvu14kJRneKLh9ZQdnREm3Zm3D05h4uraiPuXdj06RDB+O6IejZgIZYPYYST6FviVBPx4/u8Lsc1pz27pnDta3GE02Sz1LAQP6EOl2vn6mtH60A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 2 May 2023 15:20:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH] sysctl: XSM hook should not cause XEN_SYSCTL_getdomaininfolist to (appear to) fail Content-Language: en-US To: "Daniel P. Smith" Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <26064a5a-423d-ded5-745e-61abb0fa601c@suse.com> <600c8c62-5982-ec7e-7996-5b7fbfb40067@apertussolutions.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0054.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB7041:EE_ X-MS-Office365-Filtering-Correlation-Id: 81ded193-a7ae-4e4c-b6d2-08db4b0ffe4c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zxdNHioxd4vv43zGhDKzCc+x1NOANDIrUvVyj4VKtpITppl7v0u3Jo0zOHU81O2h22Hqh0KRx+jQnUMbTmFoIBOBR+vi+K7hBQL5ciy4RujoVOPVj+3342ThZDVy82/QrHv5fybmLjEPYYawB9l0ewJrADWuhNbOK4+DCOisTWmDIXMnTofBp562qQtQhtxfNCbdt9IH0GmQBMlFhg3Dutj6A5MWvBKiaQBK28D1wCzJ415S4Pt4KOFruOVZECP/k2C57HFRWRS1VgJFsDIkIgs/2oelGhn+TvgHHRhpBYjG8ZsB3Y2l0KwLHr2UGYbIVGlKqKO2GDEnfeMX9v6UZ+dStK+TntTh/sLBOtUR/GV2r5pJnvKee4QKATb5v05nK6kBQwVV9SsVz2LyXjsptVzuQkT2hCMHFkQwkvCGFWGPPlVielC/cOw8cg63vbyVnzmUkloI+BABheAbA0E/F7NPS6cgdHtMrDiRfCSMsn6OqADhDnH3SMX++/S44qtaW/GeHHnAvUT6/XatFLAkcjU2cSWhFkj4smQuinsFvuIFmB7LA/pcb8ywp57/+y47WcaNaHFLljIr5SDZ/SapLJawsb2BN87rRA+mIbI8jt93Jv86DlUVSdff4PFVJ1h+sMOayRF28GnlfIjcJYdh3w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(136003)(376002)(366004)(396003)(346002)(451199021)(86362001)(36756003)(31696002)(38100700002)(53546011)(5660300002)(316002)(66556008)(66946007)(8676002)(4326008)(41300700001)(8936002)(66476007)(2906002)(6916009)(2616005)(478600001)(6486002)(83380400001)(54906003)(6506007)(186003)(6512007)(26005)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NU80YlQvK3JZMjI4eXNOb2piZ29ROTJwS3p6MG15emZvRVlJeUNCUXJBUlp4?= =?utf-8?B?eU5wVjdqKzIzbThHRkdCc3NIMVVLaGpIdjZPTFZIZ2d2MngrTVoyR1YwWHlY?= =?utf-8?B?NVBMWjQ3cUxQMFljckJSdWlGbnFMbFNFWVpEcVNMUE1NWlA4dHVSL2s1TFVl?= =?utf-8?B?Wnk4WkJyM1dSNjhLVXFGVG5tbmc1MFRWQWR4RGpodVJsd3ZwRXlBWkJvTlNN?= =?utf-8?B?MGZzRHVTcUVMQ0lla0hzcFQrZU5NOUJOamx0a09iR3J4TzdQM1l3Wk9GU2VO?= =?utf-8?B?RWFTZXNJKzJlZlplcDRRQyt4cXBvcmxKVER6ZzMvK3BUQktyamJUaGtsQ1BV?= =?utf-8?B?LzNJYVRrd1Fack1LMHljalpQa0FzK0hvYlNiS3B5Umh5dGprUEdqOTRVNHF1?= =?utf-8?B?YUxIM3k2dGc4UWdUMHNCRGVYZXR3dVh5UWt5MmJDUHBITDNUc1kxTHZuZDRJ?= =?utf-8?B?NDJDWk5mSU5EZXRHZy9mTUxoZ0JUM0F2T1lDSlFXclRrRFk1OHRZbnFkVXh5?= =?utf-8?B?WWh4T3JvZ0pHSzlOeDlnYUVlWnl5dnp0ZUo4WjhxUzdhdFd2MHJSMXRIMUZ4?= =?utf-8?B?Z2F5dWwvMWtBd2JrMllKWlFZK3IwNEswdUp6UjBVV3JBR280bkN2NUlmWHln?= =?utf-8?B?WEp1dHRsZkd4YlNUZjZocXRSaDZ3WWFpbmZVekQ1MjE1Nlh2UGNuY0hKR0RW?= =?utf-8?B?dFY1aGs5blRDMEFGS3dzZjhya2RYYWxIRG1PdmRlMWZsS24zelRmVjNuanly?= =?utf-8?B?Y0JxU24vWUFSaDZOa3F1VC9CQ1p6YUR6bXJJTkg3ZGVESERqTjc1TG5HRmpk?= =?utf-8?B?L1laRVhlREZBNVpDZ2lTcFFPdm55ajZLdWZnSmsrWUJ1S1NUVHJFY3RCK09M?= =?utf-8?B?T3k1M2ZiandIU1ZUSFkzcVlVckZLK3BjK1BHdFNmZGFKT05yNHQyUHczRUhz?= =?utf-8?B?bVU5Y1dnM1llY0pxQVFMTHNYaFAxd1ViRC83cEYvcjlHaWxrWUtSU3hLdWZC?= =?utf-8?B?S3pybFpjajZOaXQ4aFhyUXZaYjdWdEFmNmlrWmQ1aDYrZWdFZlRnUHJQUFRZ?= =?utf-8?B?eEM3dG9VaFJwcWlIUDRrYU5OR0dZcU4vSzJ4UmpjMDRyeWdSM0JmWTJCeXpm?= =?utf-8?B?cEN1Rm1yMWhDdWJZM2FqVktlNmE2UXhCK25Zc2xsMnF5ZDloYXEyM2hlRXhR?= =?utf-8?B?a21EdTliVlRZWFdkOE0vdXVVU0UrdUFBemVXemJmMndaN3NXSDBoWDdROHhY?= =?utf-8?B?cExUUlVzRjNSaTFMK25jSkxHRC8vVXNVRmRtSE9qc241U0RSZHVqMThhbkVG?= =?utf-8?B?dlBDekk1dm5ObVRxaEQ3VVRyVzRKQkE3emlIT1Uyb2VQZVJwNUZqamhUVytF?= =?utf-8?B?aGtXZDVvUWNidTFyc2Z5UzkrYTVCVVVWQ1ZkNyt0emJZTnJEY0tGSlp4UGcy?= =?utf-8?B?eEJJZ3ZPVDRLaGt1cUF0N2UxM1hUMkd0ZHVjMFI2a2oxNHFDNVZlZXFUYXRK?= =?utf-8?B?bGxSYWwxUC9kcHlNdDczYW5LV3hzRFJlKy8zWndwSFg1MkRRMFI3cElaZStI?= =?utf-8?B?YktLeDQ2OFhSSllzUDRuWTdMTFgycjJ1dWY5M28wdXBrWm4zaHNTeGJ2cHJR?= =?utf-8?B?emQvZU5tSDI2ZWlaY0UrRTdZTm5idzdYSlRzdlR6WWdYQWNVTGhrYjU5Zmdl?= =?utf-8?B?U04wdTE1SGJuRG9oQ2NQaFFreDRKNHkrRmx5aDdSWEJTRjdwNmtPa3FDbUV6?= =?utf-8?B?VUVtSEEvNXVuaGhuaHRhTU42Z1A3cEZlSEo3ODIyODBXcUd1QWx3SWpkMWx3?= =?utf-8?B?bDdZM2NMY2N1UnA4TVVyd3J2NEVCSlpCYzNpZE50TkxGN281WGp5U2FVNWFv?= =?utf-8?B?UUw5N21JQlNPMUxpMjdXZ1FEcmRldzh1N1ViWmZkKzNoSUJBV3dwL1FjVnAw?= =?utf-8?B?bmh1dHN0bDZ0NzJCY29JT0FZQ2lyR09Pb2U3YVE0ellLS3VnNzVyN3ZUWjB4?= =?utf-8?B?KzlrM2hWcVFBemwwYUFLNU1sN0pnWHZRbkYxbFZLMXp6bGl0NllzdjdDbjMz?= =?utf-8?B?a2F5RXV3RGhSRTl5cXkwWGNMVWpLYnVNbjNnL25IMmVpNXhDZWdpeHV0aXYx?= =?utf-8?Q?QL4kmjYgvqiDIpTaPkKhbv5xc?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 81ded193-a7ae-4e4c-b6d2-08db4b0ffe4c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 13:20:26.7366 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Jqi+SJKJ6ic8IbrfSIUmOUwA/60e/yik2MNZPIAe27ifEl8eqRj3fRTunb1jogVWtapieF0+B7CKy0+lSKZS1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7041 On 02.05.2023 15:13, Daniel P. Smith wrote: > On 5/2/23 07:00, Roger Pau Monné wrote: >> On Tue, May 02, 2023 at 06:43:33AM -0400, Daniel P. Smith wrote: >>> On 5/2/23 03:17, Jan Beulich wrote: >>>> Unlike for XEN_DOMCTL_getdomaininfo, where the XSM check is intended to >>>> cause the operation to fail, in the loop here it ought to merely >>>> determine whether information for the domain at hand may be reported >>>> back. Therefore if on the last iteration the hook results in denial, >>>> this should not affect the sub-op's return value. >>>> >>>> Fixes: d046f361dc93 ("Xen Security Modules: XSM") >>>> Signed-off-by: Jan Beulich >>>> --- >>>> The hook being able to deny access to data for certain domains means >>>> that no caller can assume to have a system-wide picture when holding the >>>> results. >>>> >>>> Wouldn't it make sense to permit the function to merely "count" domains? >>>> While racy in general (including in its present, "normal" mode of >>>> operation), within a tool stack this could be used as long as creation >>>> of new domains is suppressed between obtaining the count and then using >>>> it. >>>> >>>> In XEN_DOMCTL_getpageframeinfo2 said commit had introduced a 2nd such >>>> issue, but luckily that sub-op and xsm_getpageframeinfo() are long gone. >>>> >>> >>> I understand there is a larger issue at play here but neutering the security >>> control/XSM check is not the answer. This literally changes the way a FLASK >>> policy that people currently have would be enforced, as well as contrary to >>> how they understand the access control that it provides. Even though the >>> code path does not fall under XSM maintainer, I would NACK this patch. IMHO, >>> it is better to find a solution that does not abuse, misuse, or invalidate >>> the purpose of the XSM calls. >>> >>> On a side note, I am a little concern that only one person thought to >>> include the XSM maintainer, or any of the XSM reviewers, onto a patch and >>> the discussion around a patch that clearly relates to XSM for us to gauge >>> the consequences of the patch. I am not assuming intentions here, only >>> wanting to raise the concern. >>> >>> So for what it is worth, NACK. >> >> I assume the NACK is to the remarks after the '---'? >> >> The patch itself doesn't change the enforcement of the XSM checks, >> just prevents returning an error when the information from the last >> domain in the loop can not be fetched. >> >> Am I missing something? > > Actually, I should have finished my first cup of tea and looked closer > at the patch in the larger context instead of the description, as the > two do not align. You are correct, and provided I am not wrong here, the > change is a no-op formatting change that removes an intermediate > variable. I do not see how directly checking the return in an if versus > checking the return stored in a variable. Additionally, the claim is > that this occurs when XSM is enabled, which is also incorrect. The only > difference at this location in code between not having XSM enabled and > having it enabled is that for the latter, xsm_getdomaininfo() is an > in-lined version versus a function call. In either case, both will > return 0 unless you are using FLASK and have a policy blocking the > domain from making the call. While perhaps imprecise, "XSM enabled" typically is taken for "Flask is in use". Then again, looking back, neither title nor description say "XSM enabled". And it truly was the XSM hook which might have caused the sub-op to wrongly be reported as failed (given, as you say, a policy is in place which actually can cause failure from that hook). Jan From xen-devel-bounces@lists.xenproject.org Tue May 02 13:23:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 13:23:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528624.822025 (Exim 4.92) (envelope-from ) id 1ptpyc-0005yl-QU; Tue, 02 May 2023 13:23:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528624.822025; Tue, 02 May 2023 13:23:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptpyc-0005ye-Ns; Tue, 02 May 2023 13:23:30 +0000 Received: by outflank-mailman (input) for mailman id 528624; Tue, 02 May 2023 13:23:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptpyc-0005yW-41 for xen-devel@lists.xenproject.org; Tue, 02 May 2023 13:23:30 +0000 Received: from sender4-of-o50.zoho.com (sender4-of-o50.zoho.com [136.143.188.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 85ce8669-e8ec-11ed-b225-6b7b168915f2; Tue, 02 May 2023 15:23:28 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1683033803259199.99416151184312; Tue, 2 May 2023 06:23:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 85ce8669-e8ec-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1683033805; cv=none; d=zohomail.com; s=zohoarc; b=NXhvWyQnjMPI/nrEPw0XkBZshU+P25rtO2yLhnkEQmGQqrlnWZneFIY84ZUlKOOQdXYAuegzeEbnmFd3up8THw1pdrBOHveeRnXm6hLQkO8qEANM3Vr1H3Vkv+oMefExL+o2N7W73LDkJ13Z0Tu1BqRERHsabw8XvT3laObArPg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1683033805; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=UIZz6l23yKq/jxJE/q4bcYulDbBrcSxr9jYhWlWMR9c=; b=JQHS+s1muxQlU+vFeRI3Jqki+N45oHYHU3EjjiP43OFfQS0s2+OL5Hu4GcCGsA1iD5gCM5WL5Uy3jU5va3qosishh+o0sCpabSJ7kjXidkpm/JHluwEWiYzaNKvfxls1ivMsUbuNqS+aWIvT0/zB/L0B9NpWk8+vMK+Ge91uu2I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1683033805; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=UIZz6l23yKq/jxJE/q4bcYulDbBrcSxr9jYhWlWMR9c=; b=r+A2RcKVNKsbrXCR3HZkGOqgnkddlILRww2f+Oj2gGU3qqsnTZzmLPJ1Ow3C7z5Q 0P0MymDcASyamqh3RblS6IRzdFds5M2gNVDleB1wQ3USMoVF2J0zZaxuzmzV5AqPYvI X52j4yw8Rd2F6/POEm+HhZ7boMhVAWj/LWeObPnw= Message-ID: <25876523-8d03-7e7d-e70f-b88d52f2b270@apertussolutions.com> Date: Tue, 2 May 2023 09:23:21 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu References: <20230430144646.13624-1-jgross@suse.com> <0c01a75d-8a98-3931-28fa-68ed373e9a2e@apertussolutions.com> From: "Daniel P. Smith" Subject: Re: [PATCH] xen/sysctl: fix XEN_SYSCTL_getdomaininfolist handling with XSM In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 5/2/23 09:13, Juergen Gross wrote: > On 02.05.23 15:03, Daniel P. Smith wrote: >> On 4/30/23 10:46, Juergen Gross wrote: >>> In case XSM is active, the handling of XEN_SYSCTL_getdomaininfolist >>> can fail if the last domain scanned isn't allowed to be accessed by >>> the calling domain (i.e. xsm_getdomaininfo(XSM_HOOK, d) is failing). >>> >>> Fix that by just ignoring scanned domains where xsm_getdomaininfo() >>> is returning an error, like it is effectively done when such a >>> situation occurs for a domain not being the last one scanned. >>> >>> Fixes: d046f361dc93 ("Xen Security Modules: XSM") >>> Signed-off-by: Juergen Gross >>> --- >>>   xen/common/sysctl.c | 3 +-- >>>   1 file changed, 1 insertion(+), 2 deletions(-) >>> >>> diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c >>> index 02505ab044..0cbfe8bd44 100644 >>> --- a/xen/common/sysctl.c >>> +++ b/xen/common/sysctl.c >>> @@ -89,8 +89,7 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) >>> u_sysctl) >>>               if ( num_domains == op->u.getdomaininfolist.max_domains ) >>>                   break; >>> -            ret = xsm_getdomaininfo(XSM_HOOK, d); >>> -            if ( ret ) >>> +            if ( xsm_getdomaininfo(XSM_HOOK, d) ) >>>                   continue; >>>               getdomaininfo(d, &info); >> >> >> This change does not match the commit message. This says it fixes an >> issue, but unless I am totally missing something, this change is >> nothing more than formatting that drops the use of an intermediate >> variable. Please feel free to correct me if I am wrong here, otherwise >> I believe the commit message should be changed to reflect the code >> change. > > You are missing the fact that ret getting set by a failing > xsm_getdomaininfo() > call might result in the ret value being propagated to the sysctl > caller. And > this should not happen. So the fix is to NOT modify ret here. You are correct, my apologies for that. >> Second, as far as the problem description goes. The *only* time the >> call to xsm_getdomaininfo() at this location will return anything >> other than 0, is when FLASK is being used and a domain whose type is >> not allowed getdomaininfo is making the call. XSM_HOOK signals a no-op >> check for the default/dummy policy, and the SILO policy does not >> override the default/dummy policy for this check. > > Your statement sounds as if xsm_getdomaininfo() would always return the > same > value for a given caller domain. Isn't that return value also depending > on the > domain specified via the second parameter? In case it isn't, why does that > parameter even exist? It would if the default action was something other than XSM_HOOK. Look at line 82 of include/xsm/dummy.h. XSM_HOOK will always return 0 regardless of the src or dest domains. The function xsm_defualt_action() is the policy for both default/dummy and SILO with the exception for evntchn, grants, and argo checks for SILO. v/r, DPS From xen-devel-bounces@lists.xenproject.org Tue May 02 13:27:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 13:27:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528629.822034 (Exim 4.92) (envelope-from ) id 1ptq2X-0006aD-A7; Tue, 02 May 2023 13:27:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528629.822034; Tue, 02 May 2023 13:27:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptq2X-0006a6-7U; Tue, 02 May 2023 13:27:33 +0000 Received: by outflank-mailman (input) for mailman id 528629; Tue, 02 May 2023 13:27:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptq2W-0006Zv-4W for xen-devel@lists.xenproject.org; Tue, 02 May 2023 13:27:32 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2077.outbound.protection.outlook.com [40.107.7.77]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 174f6465-e8ed-11ed-b225-6b7b168915f2; Tue, 02 May 2023 15:27:31 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8452.eurprd04.prod.outlook.com (2603:10a6:20b:348::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 13:27:01 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6340.030; Tue, 2 May 2023 13:27:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 174f6465-e8ed-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O8eCJdpp0OLIISXdXLYpvPn2geRzysqmT0C7gXspYUm3NWO0+SDGFQ4T5ZI9y3+WMjQX255xslw7OmaeysZiAVh9JLCWWWPkJ7HQzWvWG0asSSRvL6EtLjFEzHOkv0f8ltguDUjC++c5imA1ddUY07q2/TbAEVqWPApcuxdo805uJaVbc1Bj9PqXY9pItgFGT1CKyy/RRI7RruVzrqWYhk+04c8oiCFyaAgcNvCKjcKwgQ5Cw0mKyaR/xFMhd9AUVbOKGpfSvZThxEOMcg93oah2BLsDzLDkFvo1t6cWQxQPyAON8FD4inC17IV5FrIKzCtXhKcDiyPC6sxl8wWwzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Yl+1NFWBDEgrcY/4RVNSJurCxhbAo/P0H3lFt4T6wzs=; b=PCmrXqYrHzweKipPBgiuESq80D34gSg71uNZyVQQISMLT3ymIbPUc5ZGs9vEcHelsMGXjE00ULQqnQlCMx+3yKEgo8oLadIB5FoGHr4gM9MVuoZtZ70wJcgtL67XXA24Qlj/nXOuX9Dss4CnMZx5cgxnXOVwXiXExpPgtGiKcXP6ug52SGOV/iJFbKNZjQq4Mx49dSCkrYIHVbLbhVKA7UyKQUJqr5Q93smzJo4Ez8g2XXqXmLwH7Tx7DbcIsQbxFZhJqwHPON4goXV6nPYKUech7zXxI2Xa14+87x4Knmy2kb2jWHgXO2zgzwnh3WGs3dxRK+fcdeEdGas8lbcadA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yl+1NFWBDEgrcY/4RVNSJurCxhbAo/P0H3lFt4T6wzs=; b=xAHmYzXHh4D6wp5gxRoh8QqEnHObpBNQ2UJeUqzc1PTR/7fBs5OmuKla2c/ibSl/6ZizZeDb+jTr4Fz3524VaQuqZqxSDnyMaBEXykZTL35c/+croyTSSa4WoBiGue4+DyfZipRNDLNH3c5mAH4Y21Q9Ux9P4CBCIRvOSixe9krjvBS8fOB1IvHALH6YTofZYi9lU+0FLToIUjjS2/VIn/CvB6sxrI/Px/4PPDjUJsMa6tv4GVhnVO5DqgWrXbA1hYPfEV8FuFDfcclwHASWcnpQrMCS/MWW82kev4WfXs+2nilv+7bhLVf6yKbm3RyKyrigSpEVkvrjyweNfSBpgQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7a7661e7-b791-85ab-c638-eac471d02cd4@suse.com> Date: Tue, 2 May 2023 15:27:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 1/2] x86/head: check base address alignment Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20230502092224.52265-1-roger.pau@citrix.com> <20230502092224.52265-2-roger.pau@citrix.com> <89389465-f32c-7dfe-f62b-b957e2543cb8@citrix.com> <068ad06b-d766-4fc7-6bbc-289911441ee7@suse.com> <6aa9f2a5-bb57-4c56-84b8-5bc63b47cfa4@suse.com> <269b0894-5fe6-fd71-9f6d-24e3b08973cf@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0057.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8452:EE_ X-MS-Office365-Filtering-Correlation-Id: 8beab0c3-fe21-4170-c1e6-08db4b10e93a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YjJi0nO/ghwHG9cpK5lOLrj3XRQh6nLMbHusdgKv2HHm3OrpoXD7vxx/4HA+AB8LEChGKQMJeppAAQFGV9qU4qKO8AQ/AC0/6gdVDkeVfy/lLUIZEo/MBuBIgi/mfEpT4s1GVu0lDf9iSmyLcRfk3AmeKbZjKcBZZm1zL52pIaf32UO8XT4cgHnNzlkHyxbfu8lLWLMcBbF1b9oO5eRMicABBCf5elAPkCUCz7ug58YqYUl7jLPVYmw5ek1+YFxEEk8VG193ZyAPEfdzUGfsMdIhlSJyky3GRxhF8DbYkQ/AnUgwkrWRXB9KcwN+2JiHQF2b8KontkJDrKQ/SUMsj+E1US9X893oU0iGIJCz2AXiLk8lgr8aM6Easu/JGswjlBONO4Uc1VnD0U/d1Rm6475fojXBcC8PJZPnKEV1HK+RNV0Dlf1JPr8+V8qxNxTla2NcJnLBI/wqOdGzLtaTXbwE0uL0nk5boJzYiaUewAjmu0hizc58PCBfH2L0WgQfv9Iz54qTNIwk7MhR/g2WN9bsJ7mgIqVjq1YkFm0mTnEUl1AB3A9HhkdaJ9TvCie0sRFmOM2aOtW0ztyvE0TO7wshmBmkvpTB9o9RQnISX0lKBD11gRTRkdLeoT91ZIo3IN/Js8vct96L9MAan76jIw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(136003)(346002)(396003)(39860400002)(366004)(451199021)(31686004)(6486002)(54906003)(316002)(4326008)(6916009)(5660300002)(478600001)(36756003)(31696002)(86362001)(41300700001)(66476007)(66556008)(66946007)(186003)(2616005)(6506007)(38100700002)(2906002)(8676002)(8936002)(26005)(6512007)(53546011)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cjczVEtXL2tPS1Y3aWRmM3VZbnBKd0JBMm01eE5DNTJvMGZLODMxTjhyYjhl?= =?utf-8?B?T2dmN1Q4UndScWhXRzZ2VWJRZ2dKQWkzRTc4Nkk0MkJmbkZkclp0QWxKVWF2?= =?utf-8?B?Ty8zMTYzWG1Ha2pFekxwdjJ5VWZjc0llTkRWVTBzUVo5ek1PYVRkdkFpMlFH?= =?utf-8?B?MDFsUVR2bkZCdnRzNGwrTGpBZ2ltUXArVHhwTysyTnBoRUFtWEh3NFZZeURD?= =?utf-8?B?RHRKcm0yZytoSXBpM3dtVEdicklscUVobjlGYmQveDVKQktxTEZmWHRvaVp1?= =?utf-8?B?WlFzcU1DSG5vRGlmOWJOZTgvaVZ3TEZpNittejVFaWpOS25Sd1lkVHZabG0r?= =?utf-8?B?VmZLcTNOYVYzWU8yMmxTcUlWREM1UHIyaVRPdVNNVDIwVkFRWldUZ3dTOEtF?= =?utf-8?B?QzVPbnA3QWZVdXpSTTN5TFdFZEtYbEFsakNLb3hXa29wejl5b1JvZDVZRXZy?= =?utf-8?B?T0FYL1pmRzloZXhKSUllV1hmNkp1UWlCaFk5UjN5MUx4b2lFanhVM0JXeVRX?= =?utf-8?B?NzBWRXc0YXlyazBBZTA5RjJpcW1aMHQ3dmRDV2FZaGJ3eCsyTEpuSTNBdCtZ?= =?utf-8?B?c0VTdzhmQjloUU1ZQ3BjVFM0aXhKckJkRHB5ckpHckZJV0d0eVFyWkthdTUw?= =?utf-8?B?bzdlczdXcE0rTWM0MEYyZmZFQ1BjZWNlYlY1OGo2L003d0g4elZ0VUVySGtj?= =?utf-8?B?OWh2Q2pERTVQSUgrdDdKUzVDYkd4N2xxTWZMVjZoQk0wdWo1d3Vpd1lmOWJ4?= =?utf-8?B?cTA5Z1krOFhDR1VLUXZjUFIvVURRdnV6eXAvbUdVd2t3aE1VYkZ0SWJ1MDJR?= =?utf-8?B?TDBMRzJONzNPbXpoRnB0VWVUZThMb1JDQVlONTVsbXBMT0lJeGc4WnV5Wk1i?= =?utf-8?B?bnlDUG5xMzBzWk8xQTRiRVFqa0ozd0dVbVJ3WXhsblBJaC9VNFRPSFZWK0h2?= =?utf-8?B?M205WE1ibFlTcXBiaGNuS2dUdmNjaDhmNG84K1hjanBpK1BYSGVnc1I0b0pI?= =?utf-8?B?NzR2OUliVCtUNjlJczFIU2Y4ZFR0a3kreE1JV0Nld1Q1Mlp5UzFxaXR0eGZx?= =?utf-8?B?QkRPMWJodVhTT0dBdDl2czhrWlIwckxWSUcyWHFId0kxcTVHUXphRE5DQ0sw?= =?utf-8?B?RzZ4ckkybllRcVVZVitLdm1YS0F2UW9IeVBWemdYWHB3SVBEQk9Jb0dPSEUv?= =?utf-8?B?bTZ2V05EaTdqTDlWeFhyeTc5SFZlZ3pWT3JIdHAyelo1KzVJbEZkQno5OGxx?= =?utf-8?B?SEN4SXNYbU1VSWJnVG93Zm8rN2d4Tm1KOWN2ajJRMS9wcW9PWWFCNGQ4UE05?= =?utf-8?B?bitHVVdCK09XUFpYRkJLUEpuejk5Um5GU0tGaTcxbzd5dGFKM25RN2hXb1Fh?= =?utf-8?B?N2VLaWNrVXB5OVJ1Z2dZR0ZaZnVKV3JNR0RDR09RcEd0MU1OV1Rwd2l3VWhG?= =?utf-8?B?Y3FrQkdSOXR5NGlBdVlXUTlCTVBqeFUxVlRmMVJZQWRpS2tXUXZhZ2JrbG9V?= =?utf-8?B?OXpyOUZ4U01rQkoydXNHdFZNTlFlN1Z5aCtQTjBEdVR6NXByamtTWkZoSEgy?= =?utf-8?B?UU42cVJncjNTZ01SclhGTk1wb0ZNNjBoK0ZRQnhCa3NFdUVBdXIyU3p1bXFL?= =?utf-8?B?c2pCMGc0YUQxeVpjOG9PaTZGK1FiVWhMc1RhN1V2K3Vjc2dPSVpENmpIN3ZM?= =?utf-8?B?bC9tU3ZSYit5S0lTQ0pJenNCdjhJVkUxZDhRS2g2RjRFYlcvekxOM0xMOStV?= =?utf-8?B?WDVEMnZjVHRJdjd2aURwMDE1WWZzaFk5UVJ3d01OU1dqenF5M25aNjVXU0g3?= =?utf-8?B?eSt2clRqb08xS3AxZ2JweWZzOU9KbCtXaHlGdlY5cjNESm1tVy9nWnlzckZa?= =?utf-8?B?SUdWMmhVNC9FYlA4MFVQdzFUQURLeXB1dU1hakVaa0JkYmlEMXpCYnBYeG1S?= =?utf-8?B?WVVWRGFoUEwzOFhKdTVGUHhrTWRYMWVvVGRQc3F5UHo3TzR2QXV4VFRvSndv?= =?utf-8?B?cmlLblA2RUFwUFRjU0xYWlRaRkQvRmRQMU1hdjdIaXpuQmF1dTdYZVh0bFpr?= =?utf-8?B?NXB2QnV2UVljQ2UxRGNxQms4ZWVMdnYxQkt5L1lGN01KU0d2dDJNaE1qV1Ju?= =?utf-8?Q?iM6xKnl454Wy7uMpp8rk4+InY?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8beab0c3-fe21-4170-c1e6-08db4b10e93a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 13:27:00.9515 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bxHYrxNuJnxOXMDu3bVDnmVoUY9aWuc73arWnibg9JLlrc4OvtjatvdGi7X4PXGviW1siP2xekiDtsFXns6vRQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8452 On 02.05.2023 15:02, Roger Pau Monné wrote: > On Tue, May 02, 2023 at 01:11:12PM +0200, Jan Beulich wrote: >> On 02.05.2023 13:05, Jan Beulich wrote: >>> On 02.05.2023 12:51, Roger Pau Monné wrote: >>>> On Tue, May 02, 2023 at 12:28:55PM +0200, Jan Beulich wrote: >>>>> On 02.05.2023 11:54, Andrew Cooper wrote: >>>>>> On 02/05/2023 10:22 am, Roger Pau Monne wrote: >>>>>>> @@ -670,6 +674,11 @@ trampoline_setup: >>>>>>> cmp %edi, %eax >>>>>>> jb 1b >>>>>>> >>>>>>> + /* Check that the image base is aligned. */ >>>>>>> + lea sym_esi(_start), %eax >>>>>>> + and $(1 << L2_PAGETABLE_SHIFT) - 1, %eax >>>>>>> + jnz not_aligned >>>>>> >>>>>> You just want to check the value in %esi, which is the base of the Xen >>>>>> image.  Something like: >>>>>> >>>>>> mov %esi, %eax >>>>>> and ... >>>>>> jnz >>>>> >>>>> Or yet more simply "test $..., %esi" and then "jnz ..."? >>>> >>>> As replied to Andrew, I would rather keep this inline with the address >>>> used to build the PDE, which is sym_esi(_start). >>> >>> Well, I won't insist, and you've got Andrew's R-b already. >> >> Actually, one more remark here: While using sym_esi() is more in line >> with the actual consumer of the data, the check triggering because of >> the transformation yielding a misaligned value (in turn because of a >> bug elsewhere) would yield a misleading error message: We might well >> have been loaded at a 2Mb-aligned boundary, and instead its internal >> logic which would then have been wrong. (I'm sorry, now you'll get to >> judge whether keeping the check in line with other code or with the >> diagnostic is going to be better. Or split things into a build-time >> and a runtime check, as previously suggested.) > > What about adding a build time check that XEN_VIRT_START is 2MB > aligned, and then just switching to test instead of and, would that be > acceptable? Hmm, yes, why not. (Except I would still express it as sym_offs(0) rather than a direct use of XEN_VIRT_START, once again to better match surrounding code.) Jan > I know that using sym_esi(_start) instead of just esi won't change the > result of the check if XEN_VIRT_START is aligned, but I would prefer > to keep the usage of sym_esi(_start) for consistency with the value > used to build the page tables, as I think it's clearer. > > Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 02 13:28:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 13:28:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528634.822045 (Exim 4.92) (envelope-from ) id 1ptq3P-00079T-Pp; Tue, 02 May 2023 13:28:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528634.822045; Tue, 02 May 2023 13:28:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptq3P-00079M-Li; Tue, 02 May 2023 13:28:27 +0000 Received: by outflank-mailman (input) for mailman id 528634; Tue, 02 May 2023 13:28:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptq3O-00079G-6U for xen-devel@lists.xenproject.org; Tue, 02 May 2023 13:28:26 +0000 Received: from sender4-of-o50.zoho.com (sender4-of-o50.zoho.com [136.143.188.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 35a06913-e8ed-11ed-8611-37d641c3527e; Tue, 02 May 2023 15:28:23 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1683034099404379.736342581768; Tue, 2 May 2023 06:28:19 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 35a06913-e8ed-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1683034101; cv=none; d=zohomail.com; s=zohoarc; b=B3zZudwY+vSCNm3jZfy0190aw5ZEQND8RF9ZiH2IQgevHU8a5curtDKgmMmuMk6Yi7DwP/0LzOf9w9C+5rTudxgoZmXSWUz/zkRRP4uuHYqhFrEVlUsDz7dJxIY1f23LWzKkaF72gE7KW1oD6/rpZCmDFCWMtxjB3rhyt3NToeU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1683034101; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=3NHg7AojgcM8Ma5gKRmn71RqBszAUpxCp3PnnZLm5qo=; b=K63BsfvbzEkVV1n3kuFHUDNkL4J8fDG2p1yagVx3FxNfIGb9czlwnW2e1tVnkdyX2dibrm6BgQ8yb8Vv4pkAejAK7esvFXo5ZIw/LyO5rgkly0OmkMgZqiXSfFd2FtBI56ebmI6iVf+BGQQDGt7DkISygm5Uk2D6vQ/h9hQvbm0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1683034101; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:From:From:To:To:Cc:Cc:References:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=3NHg7AojgcM8Ma5gKRmn71RqBszAUpxCp3PnnZLm5qo=; b=Tgxf0IoQvlbIsNtWJNp++CTOXZxHI+Imf0AGJI6Zf6PrEoZT0Xb9ilsze/p839VW qOZEpjV2v+5ca0pZq8k0nbti9zRWkDKW9Zqi7UwiJNKjryiRhbu3TTnmINx/Z8Hf+3E 4VfSvJ+TDk+LaDjrLCx2g5LoHWbmJ/GjawC9/BbM= Message-ID: Date: Tue, 2 May 2023 09:28:15 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] xen/sysctl: fix XEN_SYSCTL_getdomaininfolist handling with XSM Content-Language: en-US From: "Daniel P. Smith" To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu References: <20230430144646.13624-1-jgross@suse.com> <0c01a75d-8a98-3931-28fa-68ed373e9a2e@apertussolutions.com> <25876523-8d03-7e7d-e70f-b88d52f2b270@apertussolutions.com> In-Reply-To: <25876523-8d03-7e7d-e70f-b88d52f2b270@apertussolutions.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 5/2/23 09:23, Daniel P. Smith wrote: > On 5/2/23 09:13, Juergen Gross wrote: >> On 02.05.23 15:03, Daniel P. Smith wrote: >>> On 4/30/23 10:46, Juergen Gross wrote: >>>> In case XSM is active, the handling of XEN_SYSCTL_getdomaininfolist >>>> can fail if the last domain scanned isn't allowed to be accessed by >>>> the calling domain (i.e. xsm_getdomaininfo(XSM_HOOK, d) is failing). >>>> >>>> Fix that by just ignoring scanned domains where xsm_getdomaininfo() >>>> is returning an error, like it is effectively done when such a >>>> situation occurs for a domain not being the last one scanned. >>>> >>>> Fixes: d046f361dc93 ("Xen Security Modules: XSM") >>>> Signed-off-by: Juergen Gross >>>> --- >>>>   xen/common/sysctl.c | 3 +-- >>>>   1 file changed, 1 insertion(+), 2 deletions(-) >>>> >>>> diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c >>>> index 02505ab044..0cbfe8bd44 100644 >>>> --- a/xen/common/sysctl.c >>>> +++ b/xen/common/sysctl.c >>>> @@ -89,8 +89,7 @@ long >>>> do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl) >>>>               if ( num_domains == op->u.getdomaininfolist.max_domains ) >>>>                   break; >>>> -            ret = xsm_getdomaininfo(XSM_HOOK, d); >>>> -            if ( ret ) >>>> +            if ( xsm_getdomaininfo(XSM_HOOK, d) ) >>>>                   continue; >>>>               getdomaininfo(d, &info); >>> >>> >>> This change does not match the commit message. This says it fixes an >>> issue, but unless I am totally missing something, this change is >>> nothing more than formatting that drops the use of an intermediate >>> variable. Please feel free to correct me if I am wrong here, >>> otherwise I believe the commit message should be changed to reflect >>> the code change. >> >> You are missing the fact that ret getting set by a failing >> xsm_getdomaininfo() >> call might result in the ret value being propagated to the sysctl >> caller. And >> this should not happen. So the fix is to NOT modify ret here. > > You are correct, my apologies for that. > >>> Second, as far as the problem description goes. The *only* time the >>> call to xsm_getdomaininfo() at this location will return anything >>> other than 0, is when FLASK is being used and a domain whose type is >>> not allowed getdomaininfo is making the call. XSM_HOOK signals a >>> no-op check for the default/dummy policy, and the SILO policy does >>> not override the default/dummy policy for this check. >> >> Your statement sounds as if xsm_getdomaininfo() would always return >> the same >> value for a given caller domain. Isn't that return value also >> depending on the >> domain specified via the second parameter? In case it isn't, why does >> that >> parameter even exist? > > It would if the default action was something other than XSM_HOOK. Look > at line 82 of include/xsm/dummy.h. XSM_HOOK will always return 0 > regardless of the src or dest domains. The function xsm_defualt_action() > is the policy for both default/dummy and SILO with the exception for > evntchn, grants, and argo checks for SILO. Sorry, one last clarification. xsm_default_action() is also what is used when XSM=n. The difference is that for XSM=n, xsm_default_action() is in-lined at the call site whereas with XSM=y and not using FLASK results in a function call xsm_default_action(). v/r, dps From xen-devel-bounces@lists.xenproject.org Tue May 02 13:29:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 13:29:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528637.822055 (Exim 4.92) (envelope-from ) id 1ptq4I-0007l2-30; Tue, 02 May 2023 13:29:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528637.822055; Tue, 02 May 2023 13:29:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptq4H-0007kv-Ul; Tue, 02 May 2023 13:29:21 +0000 Received: by outflank-mailman (input) for mailman id 528637; Tue, 02 May 2023 13:29:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptq4G-0007ke-F1 for xen-devel@lists.xenproject.org; Tue, 02 May 2023 13:29:20 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0617.outbound.protection.outlook.com [2a01:111:f400:fe0c::617]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 56c89931-e8ed-11ed-8611-37d641c3527e; Tue, 02 May 2023 15:29:18 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8452.eurprd04.prod.outlook.com (2603:10a6:20b:348::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 13:29:17 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6340.030; Tue, 2 May 2023 13:29:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 56c89931-e8ed-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dazf2fR6lB2HLePJKTnVMBJpQi0qR9i4H8M8leSrf/pobXazKGYOSwFpSMduMlbmLbtdtUrzofOK2WYu7mTTtjOMaxiHkF3FAigm/MCxy1N2vMB7MuIkqhWkmtUzQDmD3AB/2cR3MrY50KsQ1S4o2wDnOwtDf+vTuqA29bdivgnPi8FfIimPa8WFB9MhYKVVl//8djaAPIaGT6SH3fgxQ2MqjjvtDFk4fI/pIP7HKaTom066Y3MNwIQy6gsUJq77zS9aFxZwUgP0Eq6A3GmP8uvnCAzbN2oknsqfWGjot6eLSsXGAMV9hCn9r2y0b2yN9RE1y49k5+t4BNN+/3VwWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ME2ZQwWulxZwBXmpwWH9t4GVzAmCDXXPpMuLKWJ28IA=; b=Y2NGa++oFOYkzyb70uhKxiAgYnL+Qxahxlgn2BdSW8HLfKMn00MBzhn/7RSCSdbFGvmNXH+/eaphrLnR+Iv5hZwD9V9TU/JkKgAFOLyHnpT/Sd+Tc0qV0kMzXUZLKahzc8VJVOtyLQlKsSbkFtYvYFYeeuXvb7fGJCMb8qZaqvrkOAIvnYxHAjcbLMwtSglGyZNK1M2lGkIhkF13ZuwzWoUgOu+BQfZjR3P3UwbF9UFZJIPmrbs0nr9zOPCeJaF0os2cyXoyUJNqq1ivGtfyDphJg7CN7H64DsZEhIpxF0NcmqHpwk4NNRyj5szF9pQ2wwUclfOTEwTnAYV1+6g9cQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ME2ZQwWulxZwBXmpwWH9t4GVzAmCDXXPpMuLKWJ28IA=; b=r+AQIZC0DpdQAzaW4Sa9+lM6UD5QBIJpBe49l/CEGwueWEKUULqqN957GCGULdtAo/UmdA3L0viMIURtM6vp4MLX9q7LL2nbXnm9onzSLM7nUJaWixWlAfh+iMbw0WxNBCIv3mPrS6ZXS0Fr4G1nX0qKHVA9gokQvFF8lU3WKufoPMPWH9CIKfkqQbTXBRZy4ssnYeQNozCfUL8tv0+j9VrMSh70KVxVreFqTJv5jwDQoMCprAHL0ocPYEQG0NgCAf0NuZnDXsiTc2JNo8SlOs33oYy6ZC+mDTH8j/1CBJk/CGs46B7qwnQFojyYLJnRwmOhYG+xNsE8HhBlF1O1aQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9353d3f3-563b-ff88-0b0b-dfa2bb03522c@suse.com> Date: Tue, 2 May 2023 15:29:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: HAS_CC_CET_IBT misdetected Content-Language: en-US To: Olaf Hering Cc: xen-devel@lists.xenproject.org References: <20230502074853.7cd10ee3.olaf@aepfle.de> <43b1c214-4248-a735-6f8c-9e08bdd2eaf6@suse.com> <20230502133313.2192eb99.olaf@aepfle.de> <20230502140444.1dacdb33.olaf@aepfle.de> From: Jan Beulich In-Reply-To: <20230502140444.1dacdb33.olaf@aepfle.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0108.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8452:EE_ X-MS-Office365-Filtering-Correlation-Id: 5647e937-736d-40a3-634d-08db4b113a68 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1j0vhaKzmsGTWSnCb0iAAGAKuL4MhtY+mWb1jLSQr/huHtgE92mgq62M/mfZpsNm7YlUXMK83nghwKyFR9JTApdiNNlIcFJ3jVlocIvBkoy4MTj12GQ/XzNGbIYgv9V4Ay5vpvgKCsB0Yknlz/ySqXhrZ5KGJ3CioTroVXg0XFWJW19KTpQ0yLMdpCegQ0VfzSb0gU4JxuKygiYdzie+DB5B53M4Ug7bAtftkSsvZEa6y01l/sVCyDWfscWXfEPa24unSm6AvmKXy5X9FHc4bFeS+67AUS24GRjPO8vb4B5jKPOKUE9UtvAKPUcaRiYV+Cy8S3WIEs8l/5J+AqtLuFglFhOGBSxTXM7ELM1Fa8Fxp+T8KufEM4fA9286D3NRPqlA2YK93JQ8iWAL9PMJQVaLHxLUdakVTxezLPC4ioQoEpnTnDyhKFJnDsuqLgteOdQSPsIrBTqlDGcSVF+0AHBSDnFED4ntFMjbARj1FA6UHBg8I4nfsFIdbEUf+6MlCbsxjjH9ZA570hZ0UMYcFgUG28LqPzvpvt4/dXaUDV6CtA5nSYzmRMa2tUb/T8GjZoswNHnEDKI+tgeNtuExKziCPFqtuYcVjXlJqs1uhdwGwjvpm8EtTZ28bicy1oZNnzkSrbmwfexLfJJ5A9idyw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(136003)(346002)(396003)(39860400002)(366004)(451199021)(31686004)(6486002)(316002)(4326008)(6916009)(5660300002)(478600001)(36756003)(31696002)(86362001)(41300700001)(66476007)(66556008)(66946007)(186003)(2616005)(6506007)(38100700002)(2906002)(4744005)(7116003)(8676002)(8936002)(26005)(6512007)(53546011)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WVUydi9GTmZZdUNQQlpETFNxSmR6TlhVTzJaUFhoN25CNHdONFNpN29HZE1T?= =?utf-8?B?Ukd4WWNkRmtLV3NnQWUyL3JqOUp6WHhRZWxpWFJGRnlMOHlwQndMQ3hGZkZu?= =?utf-8?B?YW9XWmVWNWZRb0Y3aC90dlFlcC9aRitIbUxleWNoeFkyNldQQ0JJMHl3cGxm?= =?utf-8?B?TGpyV1pXekFwaUppUlU5Mzd3QzR1Z0J1OGZObU96dGFrZWRqMFY2dG1OSkJK?= =?utf-8?B?UkFpMEFleFNoZ2JBV0JRZk5xRjRTZHlMa04xYVc1OE53bHJwZnMzVHZIYm9j?= =?utf-8?B?dm1obStLR1RaOEdOcGtGSE9mRGY2dWY1dkI2YXdZVmVwMDBheVo4MW1SZUlN?= =?utf-8?B?cnpzK2RQNW9BUEJ1eHgxUGVhbHlVcmVNZUZxUzFOQWpFYWdTczdIMFBOQlo5?= =?utf-8?B?STNqWVU5SVAxZDZEK1ljY0VIcWZYQ3lvbSswK0tWQVJZVFdyNjBETDJFZjJp?= =?utf-8?B?QW1rWExidTU3dDBLVE9VU3RkRFU4UU9qbUJMWGdaQkFGZ2x6NXJIOE1Ec21P?= =?utf-8?B?MzRxbjBCYU5RZVRkL0wwdVVUeWJmYWZtamVSN0tsS0NyK0M4SWVaMFdWWDZr?= =?utf-8?B?cnpYYzZEandRa044R2pVTGVtWjcvUnhlQ3EvSlllSWhKSmtNQ2FwemhVT1JX?= =?utf-8?B?bWY0SC96bEJQR0Jnd1BnL0VnVUF5U2V4UDFVL0FkYVMxUGhCQ1VaWlQ1MzVW?= =?utf-8?B?d0JobC9sRnc3VHp6aW5MZnpBd0J0K1l5MDZ1eG1FZVMvVEtFdEg3TWozZWZB?= =?utf-8?B?UVZ2N1paSWE4UTNpQnBSWFhtWTF2SmFmN29ub3Z3MThuS2ppQ0JEOHE0U2k1?= =?utf-8?B?dzlablRXeHR1N3h2K2xwVVJqcy9FY2JLLzRpWGttRzNUVkxQT0I3dzFVbFRS?= =?utf-8?B?UUhEZW5yMVNBZm9OTk1lRFJIQjFHMGV0NVhjMDBWNTNxYUsvaGlidlhZTno3?= =?utf-8?B?VUpOMEo2d0lkeDF3dk54VDJMbGFXV243VjRCRjQva3kxbFhaNnNZUDNaOW53?= =?utf-8?B?amlzV0ZSWDVVQTBBNFpnb1VDbE44TXFoZHFwK1lvWno4djRKNVIrdXY1SUtP?= =?utf-8?B?YzhubXpITWZ6dVI3dXZDZUg1N1NST2VSejFzUno1dXBzcXdTa0hyK3JxVlVQ?= =?utf-8?B?c0tDbnRqMWFWNmZrRWM1MW45SHpVc2VBZjdpY0tmcnc0NGQ3ZWc1SkNPTVRG?= =?utf-8?B?enRrai9vanpFMjZDNFI5MEc1S3J3ejBmODhxWWV5V3VSSVhpSDRWWnJsSmVk?= =?utf-8?B?OWVUdk9xK0JyRjY4Vno2NFo1V2ZCOUdrMlJtUm5uR21vNzVtSldaZnlzVVht?= =?utf-8?B?UDd2VHl0ZXNQVUlKWTZ1OXIvaGptWXRaTC80VE9rTWdhZHppRU9XZ3dqcGdH?= =?utf-8?B?S2lWMVlVZTAwQis1S08vM1FWSHQvNldYZGgxWDFBNUNBc3F6MXNhaGpGb2hH?= =?utf-8?B?UzVZVVV5ZG1DTktXcCs4VGZqU2I2dTdiSEIrZndLcVBHQ0oyclFpeFpmaC9o?= =?utf-8?B?MFlRRUl5K21LUVNaMjlpM2U5NEU1R3pjeVBwZy9ZVm5INHN4clkzKzVSNTdX?= =?utf-8?B?ZnZzSHBNMm1vVDRLSkpVQ2MzcXB5Y05Pemppc09ycjRORStpOTIzSDZLTnVn?= =?utf-8?B?SmI0c1pMQVZnWStHallTTGpOTmNZQXhpamFCYTk0dldtWThRN3ZjbjAvVmFa?= =?utf-8?B?QkkyNnhhL2JLVXp5MHNPREYxaElvMzVtUUM2RFJkVzNqUlcwVW9TaWdOZEwz?= =?utf-8?B?WkhmaGp5bXc1Y2d0dlJlUDlrL1MvN2UweW1nOFRicUFDbDBZekl1cmxHTlZS?= =?utf-8?B?dnF0SUpLRVVLeDN0WW9ITVdqK2ZOSXJKS3puZGlyY0NiZC9aYkpOQnN6bU8r?= =?utf-8?B?MUtjVGVacEl6REpnL1ZTalltM25ZUWYxWEVHMlRGS09OU3ZPUE85dGNPbzQ4?= =?utf-8?B?VGwySEpZNDUra1FQREw2SFB0dUd1STUvdG90eVpGOHYzMk42dUgrcmkxa3hR?= =?utf-8?B?U21QbUtteHR2ZDNiZkNmeVB4NFhwNVNrOUtpVGhTeVFGWTlTUkZhOTNMR1ZH?= =?utf-8?B?cVBFMG5Eb1E2QngycEwxNVRIU2w1TVgyVHl3TTFoNlVMUVN2WDVXY0Z6R0Jz?= =?utf-8?Q?BdlLKp0kkg652JdbXe6cFe+qM?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5647e937-736d-40a3-634d-08db4b113a68 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 13:29:17.1177 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FFJUnxEynLHNCH2wftjkb4h7SriH8FwfPQSBuDc1RsgRclWKckKHnWB3YUjYT/FJVOwnbBlgqaOfPlczhWSBSw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8452 On 02.05.2023 14:04, Olaf Hering wrote: > Tue, 2 May 2023 13:33:13 +0200 Olaf Hering : > >> I will investigate why it failed to build for me. > > This happens if one builds first with the Tumbleweed container, and later with the Leap container, without a 'git clean -dffx' in between. > > Is there a way to invalidate everything if the toolchain changes? Getting this to work automatically is a continued subject of discussion. Touching xen/.config before starting the build ought to work, though. Jan From xen-devel-bounces@lists.xenproject.org Tue May 02 13:30:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 13:30:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528641.822065 (Exim 4.92) (envelope-from ) id 1ptq53-0000g8-Bk; Tue, 02 May 2023 13:30:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528641.822065; Tue, 02 May 2023 13:30:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptq53-0000fz-7r; Tue, 02 May 2023 13:30:09 +0000 Received: by outflank-mailman (input) for mailman id 528641; Tue, 02 May 2023 13:30:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptq52-0008BD-FV for xen-devel@lists.xenproject.org; Tue, 02 May 2023 13:30:08 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 747642f8-e8ed-11ed-b225-6b7b168915f2; Tue, 02 May 2023 15:30:07 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 61F521F8D7; Tue, 2 May 2023 13:30:07 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 205A5134FB; Tue, 2 May 2023 13:30:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id JueEBl8QUWQHXQAAMHmgww (envelope-from ); Tue, 02 May 2023 13:30:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 747642f8-e8ed-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683034207; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D8QP5oT7WEw35VAPIubP9M44ZYf0Ip836qmoZQvEDUY=; b=lqXRg8nSHcy9ZmF7LlAJqfMVeNbMFmHdiLtbk1hnVxn96+P/oS1ew/7SYgmHu5H4Jrzb+J w0sK/wgslyq2mZvlWhntQFZTUI6B1Gfbuf0xRpAD7ZWHR/pyV4Ab1MG8w2L90Zn6vrid9G 5gomh/5y3f1pXNn7opEu6Eu4he3cjrY= Message-ID: Date: Tue, 2 May 2023 15:30:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH] xen/sysctl: fix XEN_SYSCTL_getdomaininfolist handling with XSM Content-Language: en-US To: "Daniel P. Smith" , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu References: <20230430144646.13624-1-jgross@suse.com> <0c01a75d-8a98-3931-28fa-68ed373e9a2e@apertussolutions.com> <25876523-8d03-7e7d-e70f-b88d52f2b270@apertussolutions.com> From: Juergen Gross In-Reply-To: <25876523-8d03-7e7d-e70f-b88d52f2b270@apertussolutions.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------wahdxtmcljEBJZ4CSpgT7zTZ" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------wahdxtmcljEBJZ4CSpgT7zTZ Content-Type: multipart/mixed; boundary="------------yeCflqXKhgW6Hjn7xizoBghT"; protected-headers="v1" From: Juergen Gross To: "Daniel P. Smith" , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Message-ID: Subject: Re: [PATCH] xen/sysctl: fix XEN_SYSCTL_getdomaininfolist handling with XSM References: <20230430144646.13624-1-jgross@suse.com> <0c01a75d-8a98-3931-28fa-68ed373e9a2e@apertussolutions.com> <25876523-8d03-7e7d-e70f-b88d52f2b270@apertussolutions.com> In-Reply-To: <25876523-8d03-7e7d-e70f-b88d52f2b270@apertussolutions.com> --------------yeCflqXKhgW6Hjn7xizoBghT Content-Type: multipart/mixed; boundary="------------87nHJ0dLWt40XxySAT8iMUHX" --------------87nHJ0dLWt40XxySAT8iMUHX Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDIuMDUuMjMgMTU6MjMsIERhbmllbCBQLiBTbWl0aCB3cm90ZToNCj4gT24gNS8yLzIz IDA5OjEzLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMDIuMDUuMjMgMTU6MDMsIERh bmllbCBQLiBTbWl0aCB3cm90ZToNCj4+PiBPbiA0LzMwLzIzIDEwOjQ2LCBKdWVyZ2VuIEdy b3NzIHdyb3RlOg0KPj4+PiBJbiBjYXNlIFhTTSBpcyBhY3RpdmUsIHRoZSBoYW5kbGluZyBv ZiBYRU5fU1lTQ1RMX2dldGRvbWFpbmluZm9saXN0DQo+Pj4+IGNhbiBmYWlsIGlmIHRoZSBs YXN0IGRvbWFpbiBzY2FubmVkIGlzbid0IGFsbG93ZWQgdG8gYmUgYWNjZXNzZWQgYnkNCj4+ Pj4gdGhlIGNhbGxpbmcgZG9tYWluIChpLmUuIHhzbV9nZXRkb21haW5pbmZvKFhTTV9IT09L LCBkKSBpcyBmYWlsaW5nKS4NCj4+Pj4NCj4+Pj4gRml4IHRoYXQgYnkganVzdCBpZ25vcmlu ZyBzY2FubmVkIGRvbWFpbnMgd2hlcmUgeHNtX2dldGRvbWFpbmluZm8oKQ0KPj4+PiBpcyBy ZXR1cm5pbmcgYW4gZXJyb3IsIGxpa2UgaXQgaXMgZWZmZWN0aXZlbHkgZG9uZSB3aGVuIHN1 Y2ggYQ0KPj4+PiBzaXR1YXRpb24gb2NjdXJzIGZvciBhIGRvbWFpbiBub3QgYmVpbmcgdGhl IGxhc3Qgb25lIHNjYW5uZWQuDQo+Pj4+DQo+Pj4+IEZpeGVzOiBkMDQ2ZjM2MWRjOTMgKCJY ZW4gU2VjdXJpdHkgTW9kdWxlczogWFNNIikNCj4+Pj4gU2lnbmVkLW9mZi1ieTogSnVlcmdl biBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPj4+PiAtLS0NCj4+Pj4gwqAgeGVuL2NvbW1v bi9zeXNjdGwuYyB8IDMgKy0tDQo+Pj4+IMKgIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlv bigrKSwgMiBkZWxldGlvbnMoLSkNCj4+Pj4NCj4+Pj4gZGlmZiAtLWdpdCBhL3hlbi9jb21t b24vc3lzY3RsLmMgYi94ZW4vY29tbW9uL3N5c2N0bC5jDQo+Pj4+IGluZGV4IDAyNTA1YWIw NDQuLjBjYmZlOGJkNDQgMTAwNjQ0DQo+Pj4+IC0tLSBhL3hlbi9jb21tb24vc3lzY3RsLmMN Cj4+Pj4gKysrIGIveGVuL2NvbW1vbi9zeXNjdGwuYw0KPj4+PiBAQCAtODksOCArODksNyBA QCBsb25nIGRvX3N5c2N0bChYRU5fR1VFU1RfSEFORExFX1BBUkFNKHhlbl9zeXNjdGxfdCkg dV9zeXNjdGwpDQo+Pj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGlmICggbnVtX2Rv bWFpbnMgPT0gb3AtPnUuZ2V0ZG9tYWluaW5mb2xpc3QubWF4X2RvbWFpbnMgKQ0KPj4+PiDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGJyZWFrOw0KPj4+PiAtwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCByZXQgPSB4c21fZ2V0ZG9tYWluaW5mbyhYU01fSE9PSywgZCk7 DQo+Pj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGlmICggcmV0ICkNCj4+Pj4gK8KgwqDC oMKgwqDCoMKgwqDCoMKgwqAgaWYgKCB4c21fZ2V0ZG9tYWluaW5mbyhYU01fSE9PSywgZCkg KQ0KPj4+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGNvbnRpbnVlOw0K Pj4+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBnZXRkb21haW5pbmZvKGQsICZpbmZv KTsNCj4+Pg0KPj4+DQo+Pj4gVGhpcyBjaGFuZ2UgZG9lcyBub3QgbWF0Y2ggdGhlIGNvbW1p dCBtZXNzYWdlLiBUaGlzIHNheXMgaXQgZml4ZXMgYW4gaXNzdWUsIA0KPj4+IGJ1dCB1bmxl c3MgSSBhbSB0b3RhbGx5IG1pc3Npbmcgc29tZXRoaW5nLCB0aGlzIGNoYW5nZSBpcyBub3Ro aW5nIG1vcmUgdGhhbiANCj4+PiBmb3JtYXR0aW5nIHRoYXQgZHJvcHMgdGhlIHVzZSBvZiBh biBpbnRlcm1lZGlhdGUgdmFyaWFibGUuIFBsZWFzZSBmZWVsIGZyZWUgDQo+Pj4gdG8gY29y cmVjdCBtZSBpZiBJIGFtIHdyb25nIGhlcmUsIG90aGVyd2lzZSBJIGJlbGlldmUgdGhlIGNv bW1pdCBtZXNzYWdlIA0KPj4+IHNob3VsZCBiZSBjaGFuZ2VkIHRvIHJlZmxlY3QgdGhlIGNv ZGUgY2hhbmdlLg0KPj4NCj4+IFlvdSBhcmUgbWlzc2luZyB0aGUgZmFjdCB0aGF0IHJldCBn ZXR0aW5nIHNldCBieSBhIGZhaWxpbmcgeHNtX2dldGRvbWFpbmluZm8oKQ0KPj4gY2FsbCBt aWdodCByZXN1bHQgaW4gdGhlIHJldCB2YWx1ZSBiZWluZyBwcm9wYWdhdGVkIHRvIHRoZSBz eXNjdGwgY2FsbGVyLiBBbmQNCj4+IHRoaXMgc2hvdWxkIG5vdCBoYXBwZW4uIFNvIHRoZSBm aXggaXMgdG8gTk9UIG1vZGlmeSByZXQgaGVyZS4NCj4gDQo+IFlvdSBhcmUgY29ycmVjdCwg bXkgYXBvbG9naWVzIGZvciB0aGF0Lg0KDQpObyBuZWVkIHRvIGFwb2xvZ2l6ZS4gOi0pDQoN Cj4+PiBTZWNvbmQsIGFzIGZhciBhcyB0aGUgcHJvYmxlbSBkZXNjcmlwdGlvbiBnb2VzLiBU aGUgKm9ubHkqIHRpbWUgdGhlIGNhbGwgdG8gDQo+Pj4geHNtX2dldGRvbWFpbmluZm8oKSBh dCB0aGlzIGxvY2F0aW9uIHdpbGwgcmV0dXJuIGFueXRoaW5nIG90aGVyIHRoYW4gMCwgaXMg DQo+Pj4gd2hlbiBGTEFTSyBpcyBiZWluZyB1c2VkIGFuZCBhIGRvbWFpbiB3aG9zZSB0eXBl IGlzIG5vdCBhbGxvd2VkIGdldGRvbWFpbmluZm8gDQo+Pj4gaXMgbWFraW5nIHRoZSBjYWxs LiBYU01fSE9PSyBzaWduYWxzIGEgbm8tb3AgY2hlY2sgZm9yIHRoZSBkZWZhdWx0L2R1bW15 IA0KPj4+IHBvbGljeSwgYW5kIHRoZSBTSUxPIHBvbGljeSBkb2VzIG5vdCBvdmVycmlkZSB0 aGUgZGVmYXVsdC9kdW1teSBwb2xpY3kgZm9yIA0KPj4+IHRoaXMgY2hlY2suDQo+Pg0KPj4g WW91ciBzdGF0ZW1lbnQgc291bmRzIGFzIGlmIHhzbV9nZXRkb21haW5pbmZvKCkgd291bGQg YWx3YXlzIHJldHVybiB0aGUgc2FtZQ0KPj4gdmFsdWUgZm9yIGEgZ2l2ZW4gY2FsbGVyIGRv bWFpbi4gSXNuJ3QgdGhhdCByZXR1cm4gdmFsdWUgYWxzbyBkZXBlbmRpbmcgb24gdGhlDQo+ PiBkb21haW4gc3BlY2lmaWVkIHZpYSB0aGUgc2Vjb25kIHBhcmFtZXRlcj8gSW4gY2FzZSBp dCBpc24ndCwgd2h5IGRvZXMgdGhhdA0KPj4gcGFyYW1ldGVyIGV2ZW4gZXhpc3Q/DQo+IA0K PiBJdCB3b3VsZCBpZiB0aGUgZGVmYXVsdCBhY3Rpb24gd2FzIHNvbWV0aGluZyBvdGhlciB0 aGFuIFhTTV9IT09LLiBMb29rIGF0IGxpbmUgDQo+IDgyIG9mIGluY2x1ZGUveHNtL2R1bW15 LmguIFhTTV9IT09LIHdpbGwgYWx3YXlzIHJldHVybiAwIHJlZ2FyZGxlc3Mgb2YgdGhlIHNy YyANCj4gb3IgZGVzdCBkb21haW5zLiBUaGUgZnVuY3Rpb24geHNtX2RlZnVhbHRfYWN0aW9u KCkgaXMgdGhlIHBvbGljeSBmb3IgYm90aCANCj4gZGVmYXVsdC9kdW1teSBhbmQgU0lMTyB3 aXRoIHRoZSBleGNlcHRpb24gZm9yIGV2bnRjaG4sIGdyYW50cywgYW5kIGFyZ28gY2hlY2tz IA0KPiBmb3IgU0lMTy4NCg0KQWgsIG9rYXkuIEkgZGlkbid0IGFuYWx5emUgYWxsIG9mIHRo ZSBpbnZvbHZlZCB4c20gY29kZS4NCg0KDQpKdWVyZ2VuDQo= --------------87nHJ0dLWt40XxySAT8iMUHX Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------87nHJ0dLWt40XxySAT8iMUHX-- --------------yeCflqXKhgW6Hjn7xizoBghT-- --------------wahdxtmcljEBJZ4CSpgT7zTZ Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmRREF4FAwAAAAAACgkQsN6d1ii/Ey9R zwgAj1wqv9R7OHSXYkxFA+Ct5IcW2++ciFYuVCoqcZK8qy67jSIVBWxUY9mRDQZ6pXHowls5Cm7r bJvxVKkJSyTQys0Hiv+SoG8LQQoX5dkfLAqG8AbnCCHyGhH8rMN6ABpYBfLGTDi+gaxDqRRFglEo bXjW4SJiUS8AKrcUEemjJ/MvuYRfjW0ifi5r9HrdwBDwhI5sVKX9Sz5VRBNxr2yFJmjcp/Uaij1L /EVVvMn5M8G0M2KuFaV/Oz6tsG+iJeP/MrG+yCY2QmyPXE6mDyRdrrT23o2LOIV7Rum4wZMOKYF1 to/KQQOAVZtm/zoSZk7cPOrnH7Yoc9P4uyJeyAbdsg== =8Xqb -----END PGP SIGNATURE----- --------------wahdxtmcljEBJZ4CSpgT7zTZ-- From xen-devel-bounces@lists.xenproject.org Tue May 02 13:36:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 13:36:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528646.822075 (Exim 4.92) (envelope-from ) id 1ptqB7-0001ST-5f; Tue, 02 May 2023 13:36:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528646.822075; Tue, 02 May 2023 13:36:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptqB7-0001SM-2n; Tue, 02 May 2023 13:36:25 +0000 Received: by outflank-mailman (input) for mailman id 528646; Tue, 02 May 2023 13:36:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptqB5-0001SG-Cx for xen-devel@lists.xenproject.org; Tue, 02 May 2023 13:36:23 +0000 Received: from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de [81.169.146.219]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 52adf646-e8ee-11ed-8611-37d641c3527e; Tue, 02 May 2023 15:36:20 +0200 (CEST) Received: from sender by smtp.strato.de (RZmta 49.4.0 AUTH) with ESMTPSA id x6987cz42DaJdEX (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Tue, 2 May 2023 15:36:19 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52adf646-e8ee-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1683034580; cv=none; d=strato.com; s=strato-dkim-0002; b=bWXtk3LaVikoIw3D4mTe++wv8K7YiCNyTJAijZzsl1x//oQlxBWmeA/y839pu1zeve 2xYSLnDjVzTOp1RYQXmq6lxF3w3E1lroNSWHzKCYUqfnPo/jldjrR+Hj0BkgBVSIabUD tGoI0W7UIEodIQUCW56oJhPvTPi8S++AHf6ZbHRO46sNORdB/hozp/S92AQ0fyyAEJrA TnH2Wjz7+OQac5BDRcA5KApKDWgnQ8AddGNvOKykaWVTSC3T9WUHZXp0nm6r4N8Auvwi SbeV920VjluHHx1cmBeQj7RVohP1HZuoKarFKMevu8XiQvtQBtWAk1CSII2w2rMU8LLG Jx7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1683034580; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=cPq2GgRUcxP1kIv+LHSUq3CZsq05cQugJJqfWfYX7Ek=; b=CvlpxSVaLXaXOBmei4uvAak3EaNjlJOIk6+omxUK53Ggy63xhHqtGl0xb0Z/mvw526 /jQ1dObqXoijFN+qix2FdXS89hFPK5hGVdoCQFMmUbQho87olrXCbzYfZBcyMbhN/lTO Gpr7JSmCwS/FhGBMtSkVRY6VfeXkCJkliax/c+1hmITUEJb6CY9P3C5iolwxbX4e4RAk E9EBZRcPjynuKANdm2QZEVDKmEKhnrKe+3X6BebHvJPz9UIVYXneu/4cXqPiQt8wjjmF dml7RKbzk37lvvsjYpaWflT6Exf30K69oadTAPZG8EBtwAkBd4mxdNcwYrYw7AIgHP09 5O4g== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1683034580; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=cPq2GgRUcxP1kIv+LHSUq3CZsq05cQugJJqfWfYX7Ek=; b=VezzypDt25o1ZryCvqOiPFZ3/v5jBOqw8o921SZHdYPoR9piaQTWrbuB73uYPjIV6p Y7JT1cLzm5g939/z1nkzEfjfoJxaxd4yQ1MXDTud4ZivFyqOIawda4lpw4rskD9Qz9gv V++kbzlVGSl0CNqZ+rD0J7jFYnfetRtD5rmG2Dm4l4ymTySkoTn+EY83wN9rBuFp0YK4 MHdFN7pudVrhhRIeMj83Gii+JKTLW0UDlEsGHYWbmVsh+HVkgDyLIOW7YafD7uIzuKxn XtRvClIpgyY96ppJiUzwGU63r0QN4rXIFSFOsK0yALg8Gt1UNLT8JwMXgrv629IARO6e rrug== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1683034580; s=strato-dkim-0003; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=cPq2GgRUcxP1kIv+LHSUq3CZsq05cQugJJqfWfYX7Ek=; b=LniSeSGi2qWNgsEkusvsX0EDSQJjjKmGlOyHkbUV1r8pCv5au062i7mFI61jpscHuy ppg6ripXLep36+28rGDw== X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisR5BxOIbBnsc1fym1gFvNQ7EzMpH+yFJc4aADp/8Q==" Date: Tue, 2 May 2023 15:36:12 +0200 From: Olaf Hering To: Jan Beulich Cc: xen-devel@lists.xenproject.org Subject: Re: HAS_CC_CET_IBT misdetected Message-ID: <20230502153612.431dfc08.olaf@aepfle.de> In-Reply-To: <9353d3f3-563b-ff88-0b0b-dfa2bb03522c@suse.com> References: <20230502074853.7cd10ee3.olaf@aepfle.de> <43b1c214-4248-a735-6f8c-9e08bdd2eaf6@suse.com> <20230502133313.2192eb99.olaf@aepfle.de> <20230502140444.1dacdb33.olaf@aepfle.de> <9353d3f3-563b-ff88-0b0b-dfa2bb03522c@suse.com> X-Mailer: Claws Mail 20220819T065813.516423bc hat ein Softwareproblem, kann man nichts machen. MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/nhNf/G1jtomN+3AIav+pwpF"; protocol="application/pgp-signature"; micalg=pgp-sha256 Content-Transfer-Encoding: 7bit --Sig_/nhNf/G1jtomN+3AIav+pwpF Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Tue, 2 May 2023 15:29:19 +0200 Jan Beulich : > Getting this to work automatically is a continued subject of discussion. I think the only real solution is an out-of-tree build. Essentially every s= ingle component needs to detect a toolchain change. This is unrealistic. Olaf --Sig_/nhNf/G1jtomN+3AIav+pwpF Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmRREcwACgkQ86SN7mm1 DoCA1Q//QMUkhuk8WFuiQaHSttQhZWEbRnZL/1vY5c0ny8LLPpzWVEYOiMRPSI28 SN9XQJvmcZxuwbko2rrEbouxa1l+KW5lUltjpq6LMBhR5x/ELWJFbOugVWx9oKyN bSjz32XPQl2ohO8kuzwFwAAo5byIZBrGmGW6KB1TdCwJIAXl4WA1l5qoJ41odqpu zlWwm1X4PLwA7UlXqclDefXUWsbmVTKtV2amT9TJZdLWcUfBTybymeGUBH+DMWGi FNSqUWNwROeHym/byCleYzbR/QTxwCDh09LHriJwK+imbvcHrpV8skoNzgaZ+PHZ KkFohDyY+uIqZP+wIzuDV192M1m18EhV3yq9nM8gMAUq5ZrTWiuHPwS74tuO3yDO rag0feQ/tSuVAMnv4HJ/DDsho9ntZzD3F+TlJYwohXZPEo+tXb0Zdq0dtuCyTjYU 8CYWSXeOHvsTO096rYzHbye/FaQnT4anfPdp+VaqTBUDxo80L6kzHEmdYwpiX2oF O7RkaMmSHPnDfn2GZhKD2DKau5bgOTRt+tLaI9mmo+JxKOiq/G+NUymnfO1uXZFu wvw9skmH+EkpIkRh66dpW1NCMQBwgSsqcVtujYor6mASXDEWq/pKq3Ttu4aZFXxE D3Q6G62fczLZlPOr5O8t2muJqDLf5h3H0fpzhMCVdSyfO9Di3m4= =E3nE -----END PGP SIGNATURE----- --Sig_/nhNf/G1jtomN+3AIav+pwpF-- From xen-devel-bounces@lists.xenproject.org Tue May 02 13:41:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 13:41:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528651.822084 (Exim 4.92) (envelope-from ) id 1ptqFr-0002xp-Nh; Tue, 02 May 2023 13:41:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528651.822084; Tue, 02 May 2023 13:41:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptqFr-0002xi-L4; Tue, 02 May 2023 13:41:19 +0000 Received: by outflank-mailman (input) for mailman id 528651; Tue, 02 May 2023 13:41:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptqFp-0002xc-TK for xen-devel@lists.xenproject.org; Tue, 02 May 2023 13:41:17 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20619.outbound.protection.outlook.com [2a01:111:f400:7d00::619]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0267da2a-e8ef-11ed-8611-37d641c3527e; Tue, 02 May 2023 15:41:15 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8169.eurprd04.prod.outlook.com (2603:10a6:10:25d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 13:41:13 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6340.030; Tue, 2 May 2023 13:41:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0267da2a-e8ef-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TSycrKs8lQBKsfgyb991ekFsr2SrL15ZgbVkZ3jHHTdDClpyiKPhuyjagJB1kRquYw1WldgMrojryzDz8yrhJsZE1SyaKiqVHaaZ1OVU2WJkrNwE2H3XKEUFbIiA5zMOIenTKhlearc/b0CJTPq4XAHCHh1NHEQETom91+0WgQKM/yY1UlGKG/Jo7sROucHsEu+I4gaDQir0VocYthp02QB3iD7zw12UsvjYEa9tkraVYs5ikqe0Z81qdPKDWqBVyYsx61gsHqe58SQ7t0smHtFL5KtbwAN9UcDv5ZM6Q6VL9HXo6dBhAYZnzLBNMxaD0oMOsIyiWqu92JO0D1PWew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X1EDzMdMtmgMtrxFZhOwm06NyGinNaKMmyaW0YO/3FU=; b=J5viAt7NWkC8Syr5cuYg36snwqYtH+X2zwFtjEyY06ay6TQjLkbXhL+4ybMvw5GQ2xKM8WHAeM00cmgLX+O4j7GszJgAtBFlWERWDKeQUeHyILgDthFrgPW8/YXP5DdLnddI4UOFBI1lfO+o+F7phh3yCei8oFlOU0xig1zM0VGFgajjsNvCln309494znxEoraT1gMdKbuaELNpoEWvyju6KKwrHJgPh61jm2mq5/A9x1gr+U6s6ich1o9D5uMx4CM46gpN+dubw7/mPiyRH799IQGLIskYBeqeJWDaSU/C15rRaLjTjY6peAlM0uxTZeIRC0jU1FUbOoZZ/oga/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X1EDzMdMtmgMtrxFZhOwm06NyGinNaKMmyaW0YO/3FU=; b=vDJfhpFAli1ubyMpk19O+7KuHYSRlTzSD7RVENtuMS0J3SLSj+bsUoBAdXKQI+VVeCZOzi2tgPXOZLAhz0e0aeg4Rab4GPB94v0XpMuHLihniCKmz7KJ+ABftbTqZy/foykUvn9t85FJjGllJNoA+9hfot/cnibYRbpyKUwmi2zwbErjzxz7hGRYQwfeMSdMAMRvWm65JwAs47drrTMYtt0ml3Nu7vFXlqBXN9NXMTl7KSb6DCP3x6FJbMx8M14XR1tI8dQ9EFWQ0WcNee0o5Ual9+xcboyptGeewLnEhoMYItwTWDIXL4PJ/3PsbuY7X0yuI7ig0DLuYlC65OM/rQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 2 May 2023 15:41:15 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3 2/2] acpi: Add TPM2 interface definition. Content-Language: en-US To: Jennifer Herbert Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Xen-devel References: <20230425174733.795961-1-jennifer.herbert@citrix.com> <20230425174733.795961-3-jennifer.herbert@citrix.com> From: Jan Beulich In-Reply-To: <20230425174733.795961-3-jennifer.herbert@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0146.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8169:EE_ X-MS-Office365-Filtering-Correlation-Id: 6102cd90-c77f-484b-0d21-08db4b12e594 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nTwGzFc8XMcwwZecidSVWDlZEpEAa+fdr9SFYoUDciq2gDciM4IPAWFE1YM+BDmVrYYPB4pkRxNOlu/zLTMrpl+4POq88LxJuYswvKDptKsd8hWGQ9llnGSjdxhrxZtVxwdEPC2zAdvkvuy419ol3dzBjaOesSriJqE+pKtA/kIOBQIvohfUzJzfhQ08SDR5kZ1T+9LPH7a8Aom3OMMJJ1ctdfD2O9PaOx5asv1Ega0hVOIt9Zvb/KH7vDydMSzVDZe/4QdBETVJNhgddlSMiUAJWcL4frMrArvZkTr/ol6PqtzMhgPcC9qXo6tJzNwszP97zxfu1vQRkNuIanDAxerM2ZdFXyjjmsptN/NU+p7EDQJdmmj+QD69SRs1XspTCXj7arLVq/I0nIsixl/BFGfOKBIh32YN7hJGiy3c+66BzvyJxeqc8v5HVZlQB84joGAOdsq+fHCsV6EEQT+szDVA2XrN9o2NDWpgOLfNKk18rUuml/QHDjLdZ7mSBvSq5Ptyk/hQAW31TL3CM8aAWpY7azynd0Dn6bf6UbiRp56coLFA7ac1DAo2iEUrsrcWbKyetX91FaaIFMveJ9kAgnpDfZaXLyjSetuFN2HvQgs9LX6aIzgIEHDcFDoapjkymBCXsJxX/N/Wimv4kwv/8NqCav3OPO6DIhOo0GqLPZ4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(396003)(346002)(376002)(136003)(39860400002)(451199021)(31686004)(54906003)(316002)(4326008)(6916009)(5660300002)(31696002)(478600001)(36756003)(6486002)(86362001)(41300700001)(66476007)(66556008)(66946007)(26005)(186003)(2616005)(6506007)(38100700002)(2906002)(8676002)(8936002)(6512007)(53546011)(2004002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WnlibGwrdUFuRVZtMnNsd0plNDUxelRrVmJDV0taK3N5TDZ6NGd5eE5oTllL?= =?utf-8?B?NUVtaVlIZGU5YkFFTXZuTDNqOFg0YnA2T0NiS2ZMTldNV096ZWNCR3dQVjM4?= =?utf-8?B?dGdnM1VDL25jdXMxVWt5cjlKaExZNWM0MmRHV0t5U3pOMWk0YmY3bDBUSTRi?= =?utf-8?B?MUwrK3M5UkNGWEU3aW5WQ0N5VzY4YkUxNEJhQW42azMrV3dJSVIzd3dCV2do?= =?utf-8?B?WXJNK21VZ0QrRWZ4Z0FQK1l2TFIxNTFJcVNtQU5zUG45RnF4L1NFd01IV0Z5?= =?utf-8?B?OVJkRFNTVHdGaHlMdVAxZ3pLUEx3dDMzN1gxQTdkRU5uNXhDb0dRM2ZZbklC?= =?utf-8?B?WkVGVWkvTzlTcm5BSC9ReEJ1NktLT2ZJUURwTkVJM2U2MjJhT2cvM0FCY0V5?= =?utf-8?B?aHpub3ZrTWhvOGtuWUtIWmppNHRNV2kxNnFtTVRvSDBON1NZRG5TR01WeXRz?= =?utf-8?B?cE9ocFNKa1ZxbkFxYjZyU3NJSVdMelFHMVhJaG1BQkluTS90bHVRdE4rRmxt?= =?utf-8?B?dkxXUEVpallzZVhscFhPMVM1VWswc09mV3kxd0NlNUJMRXBOTEhsTng4aFgv?= =?utf-8?B?NUk4L0tVQjRqT2l2VituUE1FMU1TcDFtWkR3MGM2Qm8rOFZMS043bnlhU1I5?= =?utf-8?B?WEpud1ZBWnBrTkJEYWl2VmxhdGtwby9lYkYrcVE0R0R1TnhuV1BXaGt1bVE4?= =?utf-8?B?ZmtLcmlTVlRoc0NDaFdYRnJLcXJ2RDI2aDJvYURHL2NmN0VxRnhCRXY5a29D?= =?utf-8?B?TGE3VUh1UW5rdzR5anZVOXU0WmtKeC9tNGdrQU1HWVcxR3QxQXdmWC94cDd4?= =?utf-8?B?aWpZdkdiKy9yWFkwalRVemdiNXFicHdkMUFFWDRIb3dubmt0ejc4dG1ZVUtZ?= =?utf-8?B?eTlPNy9FVjRDemR1Q2lWU2VVaDFpZllsOHQ2ZExSMy90eVhTSnhiTS9ZRjBu?= =?utf-8?B?Tkx6QStSZ3BxWW90Q3FZbVFTN1lGSGJTblg1dWJPSnlNWTFOZ2NuYlhvY2Q1?= =?utf-8?B?UmkwbnU2NVg3cjdGV1U0VTk2dFhmSVFTWXhKU0hDSEM4NmZKNkI4NDJhM2V4?= =?utf-8?B?SitxMXdETXRiNm13STVNRkZSSmpTN3huTTJIVnd4dmFtNFY3UWZGdm1iOXFH?= =?utf-8?B?SVpSMzBnaElyakdUZFFsT0FYMWJ4YzhNenBZSnQwQzYrR2hndVMyUVUyM2tM?= =?utf-8?B?Qi9jVEg3QktjaHlXZ3B5NVBScjg3VG5QSzVCWFRQSEVSU0szNUorMmJtYUxz?= =?utf-8?B?RENhUU5LTnB3cDR5QTU0M09EUkhZWHFPRmNKOWZ2MHlTbmkrai8yVC9XTlhB?= =?utf-8?B?N1pPbEIxWlhtdHA5Z2xPNXNCRDFQWThuTXVVWXpVMml0OFUxdlFlOHN5Sk1v?= =?utf-8?B?OXFEQndxbSs4Wmp4T3g2NHpyTU9DL0lIREttTE5RZDRTMkVZbWducWt2c3g4?= =?utf-8?B?bUM0WVk2Umo0TjluWjZpazB3WC9iUENNNEFPZWptR01CNllHVTExbnUzdGVG?= =?utf-8?B?bnJ0WS9BRW5JSGc4V2VpRmxsdzk2VHdEdUloemhFWkNiZnFYUzA0U0UzWjBB?= =?utf-8?B?U3d1R091SUJJODdHOWxZL0NaNWNwUWRJaGdSa2VZNWVPeldhdkhoLzc1MFNS?= =?utf-8?B?ZXorWTNMT2Q0SVdpWHp3R3V0VTduSlA0L2hTRWl6R1JQVy9NcElTMy84WGlJ?= =?utf-8?B?Mis5a09TMzFyVzZQSXVhY1c4YTNDTHdTTzhHVzNLWUVES1UyLzZyVDFCanBX?= =?utf-8?B?UGtPRm0zTGVaK0picVl0clk3TDB5aFcvRi9Xbk5mV25JbVBYNmpWaEdIdlZY?= =?utf-8?B?ZHovek4zSUtiRkV5dXk4c2hHMFZycDZJcHh4MG9xdSt5bC9UT2RVS3REbzYz?= =?utf-8?B?K1JZbHRiWGo5VzNmekFmcWJIMDJQSWRuUUorNmZRQmIxMFN6UEx3UThTazNa?= =?utf-8?B?Sm5SNUl0RDl3L29PeXhhL0Z5RzVaQkRoMFdzMGdGTkx5WldmUXNudDV6TkhG?= =?utf-8?B?TTNWd3ZIcVo1ZG9xSFJCVnVuZXp3emdJMWlrSTB2cmQyODJGUzljTVpWcXlP?= =?utf-8?B?L041MXJCRktXYndoQnBvYWNDK0o2R2YrZXBzbTQ0aGFjb2VZNGdMNEQwcnhm?= =?utf-8?Q?VC8bocAvUh/8UBZZUoE11hMcj?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6102cd90-c77f-484b-0d21-08db4b12e594 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 13:41:13.7821 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +tVatW8L8TKqLqPcSEIGrPBH3mXSJqj0FCvRx4IBYzYfM1/qW3ggdVOwvR/e9Gw6CETAFjL+seg27PdnxIk6hA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8169 On 25.04.2023 19:47, Jennifer Herbert wrote: > --- a/tools/libacpi/acpi2_0.h > +++ b/tools/libacpi/acpi2_0.h > @@ -121,6 +121,36 @@ struct acpi_20_tcpa { > }; > #define ACPI_2_0_TCPA_LAML_SIZE (64*1024) > > +/* > + * TPM2 > + */ Nit: While I'm willing to accept the comment style violation here as (apparently) intentional, ... > +struct acpi_20_tpm2 { > + struct acpi_header header; > + uint16_t platform_class; > + uint16_t reserved; > + uint64_t control_area_address; > + uint32_t start_method; > + uint8_t start_method_params[12]; > + uint32_t log_area_minimum_length; > + uint64_t log_area_start_address; > +}; > +#define TPM2_ACPI_CLASS_CLIENT 0 > +#define TPM2_START_METHOD_CRB 7 > + > +/* TPM register I/O Mapped region, location of which defined in the > + * TCG PC Client Platform TPM Profile Specification for TPM 2.0. > + * See table 9 - Only Locality 0 is used here. This is emulated by QEMU. > + * Definition of Register space is found in table 12. > + */ ... this comment wants adjusting to hypervisor style (/* on its own line), as that looks to be the aimed-at style in this file. > @@ -352,6 +353,7 @@ static int construct_secondary_tables(struct acpi_ctxt *ctxt, > struct acpi_20_tcpa *tcpa; > unsigned char *ssdt; > void *lasa; > + struct acpi_20_tpm2 *tpm2; Could I talk you into moving this up by two lines, such that it'll be adjacent to "tcpa"? > @@ -450,6 +452,43 @@ static int construct_secondary_tables(struct acpi_ctxt *ctxt, > tcpa->header.length); > } > break; > + > + case 2: > + /* Check VID stored in bits 37:32 (3rd 16 bit word) of CRB > + * identifier register. See table 16 of TCG PC client platform > + * TPM profile specification for TPM 2.0. > + */ Nit: This comment again wants a style adjustment. > --- /dev/null > +++ b/tools/libacpi/ssdt_tpm2.asl > @@ -0,0 +1,36 @@ > +/* > + * ssdt_tpm2.asl > + * > + * Copyright (c) 2018-2022, Citrix Systems, Inc. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU Lesser General Public License as published > + * by the Free Software Foundation; version 2.1 only. with the special > + * exception on linking described in file LICENSE. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU Lesser General Public License for more details. > + */ While the full conversion to SPDX was done in the hypervisor only so far, I think new tool stack source files would better use the much shorter SPDX equivalent, too. Then on top of Jason's R-b, Acked-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Tue May 02 13:41:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 13:41:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528655.822095 (Exim 4.92) (envelope-from ) id 1ptqGK-0003P7-Vk; Tue, 02 May 2023 13:41:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528655.822095; Tue, 02 May 2023 13:41:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptqGK-0003P0-Sl; Tue, 02 May 2023 13:41:48 +0000 Received: by outflank-mailman (input) for mailman id 528655; Tue, 02 May 2023 13:41:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptqGJ-0003Oi-8Q for xen-devel@lists.xenproject.org; Tue, 02 May 2023 13:41:47 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 135ae9a5-e8ef-11ed-b225-6b7b168915f2; Tue, 02 May 2023 15:41:45 +0200 (CEST) Received: from mail-sn1nam02lp2042.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.42]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2023 09:41:35 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA1PR03MB6338.namprd03.prod.outlook.com (2603:10b6:806:1b5::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 13:41:31 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb%4]) with mapi id 15.20.6340.031; Tue, 2 May 2023 13:41:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 135ae9a5-e8ef-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683034905; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=lKAkKK7RUMeCbc4AD2x5SGJG49S6l7oPERFgFVGQoD4=; b=RH3L8AKwlHjJXH3fTPrWKBfXYfMfiheB6l0IQr142o7Ef9g9W1kd9PmG rOpTbu6PFBZ1f0qZbwDV5bkWMqJulhCFRkuR6sKHsn16BzQH7riOCQJt9 k7FngAeq68b8mEoC3QDcGlfQTqQAw9MMxfuLHKgqn985DmVFfedAgM42N M=; X-IronPort-RemoteIP: 104.47.57.42 X-IronPort-MID: 106903496 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:YLOIWq7Dtrzt9L4Xi2w/CgxRtBbGchMFZxGqfqrLsTDasY5as4F+v mpJCmzVafmMZ2egedx3Ydy3pB9Q6MLWx95mGgJr/ngzHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+7ZwehBtC5gZlPa0T5geE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m6 sYfdgBQSi+6o827kO68Suxpo+omBZy+VG8fkikIITDxK98DGcqGeIOToNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6Ok0otitABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTAdpMReXjqq806LGV7ncKDh4wDlGAm/y0q1ThWP1na H0MvQN7+MDe82TuFLERRSaQp3qNsDYVVsJeF+B85Azl4qje7hudB2MEZiVcc9Fgv8gzLRQ62 1nMk973CDhHtLyOVWnb5rqStSm1OyUeMSkFfyBscOcey9zqoYV2lRSWSN9mSPSxloetRWu2x C2Wpi8jgblVldQMy6iw4VHAhXSru4TNSQk2oA7QWwpJ8z9EWWJsXKTwgXCz0BqKBNzxooWp1 JTcp/Wj0Q== IronPort-HdrOrdr: A9a23:s7ax1a8e25NgaOudALVuk+AiI+orL9Y04lQ7vn2ZKSY5TiVXra CTdZUgpHvJYVMqMk3I9uruBEDtex3hHP1OkOws1NWZLWrbUQKTRekP0WKL+Vbd8kbFh4xgPM lbEpSXCLfLfCVHZcSR2njFLz73quP3j5xBho3lvglQpRkBUdAG0+/gYDzraXGfQmN9dPwEPa vZ3OVrjRy6d08aa8yqb0N1JdQq97Xw5evbiQdtPW9e1DWz X-Talos-CUID: 9a23:mfuE2W3bKdM+ukjX8DFrE7xfBfoiLE2A6EjpB2C1WTpuSLiQbHGV0fYx X-Talos-MUID: =?us-ascii?q?9a23=3A+mq4sQ+7Oy0ZUXCSnGgQDqCQf9xx5aeIU0o2q5A?= =?us-ascii?q?LmtPbNgNIeAaFyx3iFw=3D=3D?= X-IronPort-AV: E=Sophos;i="5.99,244,1677560400"; d="scan'208";a="106903496" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ItTglMvh1w0Z5CY60gA0QjjZDMOjVDrteeoYDqDrLmOpJ498surCDr1Pn4ewDExldSXVM3/5t6nPbwDr3QwepuTG2bI76WZGptKRGFOrB4LrSVmC2RYbZG0tOu2dkCuCY+J2RfmdyH2chYtNz+QxsuOVkckI0bIEvs7RTskA7W6mD66CiXu9VH+42EG/iVB9gHSkpcnNAkToGoJQ9e85CFnKlfZZiNGyt9q6FHCyA8vJ7QutIL1UN0YjmlsnXBt1VRV19KejFyLeXcGUo8RfMONMcQ59cJ7plaJQmNIyaIlX9an8mEbOj+pdKKJYbYrvHFLBvse7F0xQBpRJGPozGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lKAkKK7RUMeCbc4AD2x5SGJG49S6l7oPERFgFVGQoD4=; b=KB3z/f5kxLQjZY/jVvgyShsigzMcuKKHuUERMR1ddyqdec+H8e6yy/l239XYV0HciJOtHT0iPKBRkjHUR8G2eEXikjJEvQMp3fp9PWRo4AvkaXzJD3GsZsDFzuqN3OcUXn2GIi+f1rlnAw8EpL+r2dhERKmJQnhMc+JLGD/GIenAFQ1edXJc6vwnyF41g+vafdrwODwC3PeownjGdkDvAC5VDPvWGyEPSRs0H6KH2x56F2ZCkQDQYkmcyJln6ZlFYLMDNZGjFOfZzX5aFsbpCxYmlYR8dxK/YGRQj36ctKZTzi1uyWY1nqM0Ei7TvULTKlg0SNP3xzGVeCASJGdu6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lKAkKK7RUMeCbc4AD2x5SGJG49S6l7oPERFgFVGQoD4=; b=nNE2IflHMCFcG/t+AaESVLnRct7OqRRHGH+2V9seOzGNoCN0SwV9MMFLBEopuBP0qnoTrfz/VH+0fIvcJmngFYUXWayPWrjXpVM6jxz9agsG7UlgzeWZXzbRE28pD9VHwMiyehxkGR85/oAhoFfYT8YSnX2r474sRQJyejlbXxg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Tue, 2 May 2023 14:41:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: HAS_CC_CET_IBT misdetected Content-Language: en-GB To: Olaf Hering , Jan Beulich Cc: xen-devel@lists.xenproject.org References: <20230502074853.7cd10ee3.olaf@aepfle.de> <43b1c214-4248-a735-6f8c-9e08bdd2eaf6@suse.com> <20230502133313.2192eb99.olaf@aepfle.de> <20230502140444.1dacdb33.olaf@aepfle.de> From: Andrew Cooper In-Reply-To: <20230502140444.1dacdb33.olaf@aepfle.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0204.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::11) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SA1PR03MB6338:EE_ X-MS-Office365-Filtering-Correlation-Id: 7b4bd495-ecbb-488b-8c38-08db4b12efb7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TB5yhIKEPrLF4PaxMo8jcPd/qxsI7oiYaNRuUB24yd/tLNgTy4FQzNrbI8r0qS4kSOnYqclIp8JBVLEjNlwr3csDdKytI33JOUvREPLMeSAf1x2W8djcWiZyPAo4tGGTNK+JgbUt3ym89fNpaSSzl4ERBryAg/OZYxP9Joa3O/05HowLHHGhCyBx8Vpq9+rXmTs/tXGQt+gVKx+FwYDow3fyq/+GmQzc60PoDO5WBPLwgRjvwRR0cBFQwwj61Damp7hw88SWfW+3owK4Zv2CMg2CNCKca5yeOYQycotyc95jrQEknmd1liRYsvdsuoRGyQSqTZkxcmdLypAiN+jUpjAPAYe28qTLk2wfCIKU908FhEUfzK1Fz2VQhLsocTP+ExnTQPPpXlWe5sRL7BmL5lECGAbn8rDY3YIyMnUYWYED27i0FmfvVetR9sTfdimffVQcY/WqG34dPAUCHsPLUEPPmK4FXr7abfwF60rxv0d+QDknkBL8UuHdwSiCsChoxoZy0BoVLhuy0180vZcN7O/Uhe2bEwxr0saPNBy4xFmk779gm6aG8GFzit4ys5M4uuHhRbnaIjXn2B9VF6qYXi8kYxG75P+nvGDsJFKmXZF5/OpH4kAOcxLqNL0HqH7azKR/GFvC19xQ7P/2cvJMvw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(136003)(366004)(346002)(396003)(451199021)(66946007)(66476007)(66556008)(82960400001)(316002)(4326008)(6486002)(478600001)(31696002)(110136005)(36756003)(966005)(86362001)(186003)(6666004)(53546011)(6506007)(6512007)(26005)(4744005)(5660300002)(2616005)(31686004)(83380400001)(38100700002)(7116003)(8676002)(8936002)(41300700001)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WlNxaXplblIzRnN3RmJVYXBwVFcyN0M3VG5XaGU4cURyd3V4b2JjMklUWEY1?= =?utf-8?B?NFVMVkY4QzJ2KzlyaUtmM0VuQUR3dDljLyt0RmpXSXp3VUkwL1R6V2RUSjV5?= =?utf-8?B?U1JiZHVKSzE2ak1mcnN5YzJ3OW1aUWgydVZNaDVjV084WTBIemlpbFg3Zmsw?= =?utf-8?B?NENta3FaVkkyV01TeGVaMEZpWHJTZWtycEZ6L0Y4dTgrL2VRMjQ2ZGV3NEFE?= =?utf-8?B?NS8rOFVsM2J4NHlOODQyQnpLNjZDWmFPL2hFYnFjUDhCVmloa0dCSGZWQ3M2?= =?utf-8?B?YmpuZWhIQ0FpTUlGSWVzTkJyOCsxNGFTNWpkdlZyaEZOY21jYjZHcGszWkUz?= =?utf-8?B?SGdUMFJFaCtwaW9HYzFTMWlpVUtLaUVLbjBzSkN3aUloeU1ReTFwakg1d1Bq?= =?utf-8?B?NnRrN2hDTjd3RVpXT0hnN29PMnY4VkdyNUVyYTRnSDFOaHFSLzBZai94NDhL?= =?utf-8?B?TjcvWkFhWjVzRXdhRzdvYjNQdFpFWmJlcnRWNjdDeVJFSi84ZGJWWmVEVWFp?= =?utf-8?B?R1h6TUlRR1FOZDNsMVlxNXJDSHNTMUdBckl6Rmp4NnhuOS9NMDFMbnZMbUhR?= =?utf-8?B?eDBKdFZuek8vaEx0Z3R2bmVDRU5QMmsrS0QzNGwzbEV1VnY3ZzVETFVrbDhh?= =?utf-8?B?eHhpaktFNnRtanhvYS9GNzlvMFJieitPTkpQQzZMNDlMK3hISEljeVN4VXk5?= =?utf-8?B?Tjh1Vk5QM0dTaTFXS1BvLzk1QlVhYmVTZ3lpUEVJbkhtdlp5aURIcUpOb2hQ?= =?utf-8?B?RnpsdTJvUHREdlZCZFM4RFhudlV5aE4yQ0xvTFVsNzNOVk9nOVNObW1pYUV1?= =?utf-8?B?Yzh4MEhkM2diaVF5KytHUGxtVFZUYnlWZ2JYMTZveUF0TndzcGRsV3dWWFds?= =?utf-8?B?R2hoMHVzQjVtMjVKY0NZV3lhN2lXTFBwdnBsZ0U1ZmIzbGlGT0s0QWI2SmNH?= =?utf-8?B?STlMRmdmTlNEb1hQeGpyMHp6N084RzFQVUdYeW5sNVZGL2N3bjgrbHFkRmNz?= =?utf-8?B?Y1puUGpNUmxMZDZpUDVSL1dQRC9oUWN1eFdlT2R0U0xURVlRdXNxNWFpVkJW?= =?utf-8?B?cXRCbS91dHh2MExxT2tYcDdYck54bGVEcDdxN0V6dHk1KzU2Z0QxYXFZamlB?= =?utf-8?B?aWc0eWQ2d29KOUVmSlRzSkJRK3RYYWFuaThwcm5EUmI2YldSSjhCSXBDRWx1?= =?utf-8?B?TlJQUWhKRGdxZysyS3pieFlEU2g0bVMxVno3QUprVTJsMjdvOXEybUI4SVph?= =?utf-8?B?cjM0Rm1pMnk0ejBZc3hvVDN3eXJWd0JoMW5zWWltRzAyWUd4bkxYMzRBaWhO?= =?utf-8?B?Q2FMek1RbEp3WTJ5alljRHRmN0E1cFgvZUZ0cWMyckYvN3hxWnNDMzYxblY1?= =?utf-8?B?SHc2MXpNaGNDMFNVWDlVdTFXUnM0QjVRM01VcmRMdGlsSjJ5aDdSRCt1R2JT?= =?utf-8?B?Y0JNZG5tQ21pYWIyY293eTVDQ0dubElCdCtFeXhoSkdqT2Z5Sm04TklvcFRC?= =?utf-8?B?VGEvcnpPTE9VaXBhejNoMnYwOGszWDNRMC9WSTlhSzhrOWY0clFSWHc3R0lH?= =?utf-8?B?cGFYdWM4TFB1SHNKSENlNUx2OTFGRzF1VWowWTJNdlFYWk5BUGpGWk5UaGpv?= =?utf-8?B?NE9VVitNTFpVWmtENTR6ZGtxZ1h3dGpEMWo4S2FnaHpZeVo1ZndGd0RleWZX?= =?utf-8?B?d1IxWG1qY1A4U3p4bS9hQ29rcmFaVHJpdTFOb21uaUl6NXo3RWpxVEdiaURz?= =?utf-8?B?bSs1dG4walJ0d2gzYjZiMlRjZXIxbGxYUGNiYUFtR3lQa0R6REJ1NHBxdmdl?= =?utf-8?B?dVVTdEtWYjZyTVNYVUJiVFZveW5JN05UTDd2S2pIZzZiejdnNEJHU0NyWW1X?= =?utf-8?B?MkhwNVQ5RHZuQlEvY2x1OFpvUitVbWhHK3dhM1llbnJOOFpOMXpFbnZFNktM?= =?utf-8?B?NHZxc0h5QzRYTW41Q293c2t0M1h4Y3Z6clV2YXY1Z0xsajFTc2R0Wm5GSUxn?= =?utf-8?B?SzVKc0x3NktTLzFua01ZRnVyWm5OejFRWGxxUGx1QVNuSjRYb2NwaGpDSGMz?= =?utf-8?B?c1VLcTlZckhFaGhBS3BzMlc4Q2hXbC9xdmloaWtOcVR3anFTMlE3V21DaGtB?= =?utf-8?B?VUJZeUdSb0J3RlZXOHlsRGRsMzhFQ2xORnBRV09sTDVXdnNkRW9lTkVic0l6?= =?utf-8?B?Z3c9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: uRO9EuvQYu42DO6y07pantXZN/4Azqe3rl0k9wt+YYXJFU1MosxyTvOndg+JnQ/6XpZFX3dyxn7iI6KP33JgJf4hROpgFXq+rMf+fnevTDh688wfkUTjkHQNgw3EtdZGaiNaaP+PcFGrxxpgyZUt6jSk1WHKpB/kiHY05XhYSDwfj/tFKHZ3XdUED80cmt87ixLwdYMgXkMv+tWnjdoCmwc+EmOQZqIRiLxDxY7mDImwHd3Fak8z4C4rQb6ouVdBMVVNY6nkP+R50YWQywA+OQKXvOQtRG8YClfm3Meadf91lBuH9jzTUuhnBUK27FvK8Hxtzaza7/wnAoqxlWWTLAi3zEq0JBVvKy7glNZVb/iwQ3iDknW7sGlXYBpABtcIxy1qnIMiU8odQGCQzYPmTD7tBxAoqW7CZDSf0O5NON2Y7KaTqA3mwJ3lQJRQw1/+2+pvWptTKssFw/An061C8NLuCmrn0ewhnIA0reAtkYZ8SoT/VHIQ1RZOdkEk9r0p1ud7HtRyWaCpt7XleNq7W++yBvUVhRJNQWimIj3azs+ex/Td+pLyK6zMn4iHn1c4lrC9e5PbudLNX+s9EF1TE4h2mBdH90t91d9G2JcppCgsQ8Zjp/IEx/LL3hFEz2lBkGX20SowTVlFICC/bq2IzpUsq8iHKHa0Hw6bF5JRZjfLUaikoI5k9vcFo8v1y2VfbyED2kL3I9dsFYO6Qfw+D5v2qOqPcHUj6M8hcLj+L7l6jlgF9cxqpG/siGL1uoReZfeqvjfXArZ7ZwUke91ZondP9b2C8vRrT2ykMYUrsGgO6SwGf68i/BOSNAtek/GBc0y+ngNp5hvX9Hc9SJU7iQ== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b4bd495-ecbb-488b-8c38-08db4b12efb7 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 13:41:31.0566 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UVRFQCzvJ4/cdJCs36ZA75p8H0Xt9j+j40Pm1HOI7wtC8cDSfoslalox+Cz/4gkIhUa9m36zFQdbI4duQGHkKa/p450civsQLzHBIzif1rQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6338 On 02/05/2023 1:04 pm, Olaf Hering wrote: > Tue, 2 May 2023 13:33:13 +0200 Olaf Hering : > >> I will investigate why it failed to build for me. > This happens if one builds first with the Tumbleweed container, and later with the Leap container, without a 'git clean -dffx' in between. > > Is there a way to invalidate everything if the toolchain changes? I thought we had a fix for this.  But it turns out it's still on the list. https://lore.kernel.org/xen-devel/20230320152836.43205-1-anthony.perard@citrix.com/ Does this improve things for you? ~Andrew From xen-devel-bounces@lists.xenproject.org Tue May 02 13:41:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 13:41:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528656.822104 (Exim 4.92) (envelope-from ) id 1ptqGO-0003hE-A1; Tue, 02 May 2023 13:41:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528656.822104; Tue, 02 May 2023 13:41:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptqGO-0003h7-6s; Tue, 02 May 2023 13:41:52 +0000 Received: by outflank-mailman (input) for mailman id 528656; Tue, 02 May 2023 13:41:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptqGN-0003Oi-CU for xen-devel@lists.xenproject.org; Tue, 02 May 2023 13:41:51 +0000 Received: from sender3-of-o58.zoho.com (sender3-of-o58.zoho.com [136.143.184.58]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 160e9f32-e8ef-11ed-b225-6b7b168915f2; Tue, 02 May 2023 15:41:50 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1683034905351328.7299606446121; Tue, 2 May 2023 06:41:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 160e9f32-e8ef-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1683034906; cv=none; d=zohomail.com; s=zohoarc; b=Z8IImE2XPq+A8wp68OcU39T31usWWv0UrcK7QKKniAngTES4Oxsg/CB/EZhvXshxuL0mJDXJXMcJatiKMukhMu11UU73yZbOZufC+YlsZtyhy0dnd6NpVy+w3Vp5DpYW6SWrc4FVRozEZ26hl5udGrCGB4CRZ78iTB24HYSHBYE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1683034906; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=xNbtRmBKjKSHqEgVtqUXyN+cG3mqZpX02zCxAI/TSZk=; b=mYkQC4foXuhKPg11pWCBLhxMdGeHBs9skFnZ9HWK2EQnEcRu8LcFfvOcVc/BRygctP6jqDQMh6tO6oQaKEdsuyixHDvPW9glqq+arc92kWeDkgKS+Xk0swGFNelKE5WFR/RqI43C/6DyG2Ti8VVrUCUqeLBkRpA1E/bxq+ie2o0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1683034906; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=xNbtRmBKjKSHqEgVtqUXyN+cG3mqZpX02zCxAI/TSZk=; b=VFEfKsGRoxz1UNAQVVwWgBDSC3v7++0diGGP6xwskp9HmbN4BDPNXRfLA88b0Ih3 5b9+MMkUD2IN7KfSvw9XwJqWUTMdkdcUDJmt2WFRk2DTQ/K0FCJBlpO37HAgu+Ioo1E YoLF+4AkLRc2KMza4NdhSaj3Jra1yNtZKOQK9EGc= Message-ID: Date: Tue, 2 May 2023 09:41:43 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu References: <20230430144646.13624-1-jgross@suse.com> <0c01a75d-8a98-3931-28fa-68ed373e9a2e@apertussolutions.com> <25876523-8d03-7e7d-e70f-b88d52f2b270@apertussolutions.com> From: "Daniel P. Smith" Subject: Re: [PATCH] xen/sysctl: fix XEN_SYSCTL_getdomaininfolist handling with XSM In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 5/2/23 09:30, Juergen Gross wrote: > On 02.05.23 15:23, Daniel P. Smith wrote: >> On 5/2/23 09:13, Juergen Gross wrote: >>> On 02.05.23 15:03, Daniel P. Smith wrote: >>>> On 4/30/23 10:46, Juergen Gross wrote: >>>>> In case XSM is active, the handling of XEN_SYSCTL_getdomaininfolist >>>>> can fail if the last domain scanned isn't allowed to be accessed by >>>>> the calling domain (i.e. xsm_getdomaininfo(XSM_HOOK, d) is failing). >>>>> >>>>> Fix that by just ignoring scanned domains where xsm_getdomaininfo() >>>>> is returning an error, like it is effectively done when such a >>>>> situation occurs for a domain not being the last one scanned. >>>>> >>>>> Fixes: d046f361dc93 ("Xen Security Modules: XSM") >>>>> Signed-off-by: Juergen Gross >>>>> --- >>>>>   xen/common/sysctl.c | 3 +-- >>>>>   1 file changed, 1 insertion(+), 2 deletions(-) >>>>> >>>>> diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c >>>>> index 02505ab044..0cbfe8bd44 100644 >>>>> --- a/xen/common/sysctl.c >>>>> +++ b/xen/common/sysctl.c >>>>> @@ -89,8 +89,7 @@ long >>>>> do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl) >>>>>               if ( num_domains == >>>>> op->u.getdomaininfolist.max_domains ) >>>>>                   break; >>>>> -            ret = xsm_getdomaininfo(XSM_HOOK, d); >>>>> -            if ( ret ) >>>>> +            if ( xsm_getdomaininfo(XSM_HOOK, d) ) >>>>>                   continue; >>>>>               getdomaininfo(d, &info); >>>> >>>> >>>> This change does not match the commit message. This says it fixes an >>>> issue, but unless I am totally missing something, this change is >>>> nothing more than formatting that drops the use of an intermediate >>>> variable. Please feel free to correct me if I am wrong here, >>>> otherwise I believe the commit message should be changed to reflect >>>> the code change. >>> >>> You are missing the fact that ret getting set by a failing >>> xsm_getdomaininfo() >>> call might result in the ret value being propagated to the sysctl >>> caller. And >>> this should not happen. So the fix is to NOT modify ret here. >> >> You are correct, my apologies for that. > > No need to apologize. :-) I believe it is proper to admit when you are wrong. >>>> Second, as far as the problem description goes. The *only* time the >>>> call to xsm_getdomaininfo() at this location will return anything >>>> other than 0, is when FLASK is being used and a domain whose type is >>>> not allowed getdomaininfo is making the call. XSM_HOOK signals a >>>> no-op check for the default/dummy policy, and the SILO policy does >>>> not override the default/dummy policy for this check. >>> >>> Your statement sounds as if xsm_getdomaininfo() would always return >>> the same >>> value for a given caller domain. Isn't that return value also >>> depending on the >>> domain specified via the second parameter? In case it isn't, why does >>> that >>> parameter even exist? >> >> It would if the default action was something other than XSM_HOOK. Look >> at line 82 of include/xsm/dummy.h. XSM_HOOK will always return 0 >> regardless of the src or dest domains. The function >> xsm_defualt_action() is the policy for both default/dummy and SILO >> with the exception for evntchn, grants, and argo checks for SILO. > > Ah, okay. I didn't analyze all of the involved xsm code. No worries! I am always willing to help in any way that I can. While I don't have the bandwidth to be proactive and keep up with everything on xen-devel, please do not hesitate to ask me or ping me on anything XSM related. I will gladly take a look and provide what insights I might have on your query. v/r, dps From xen-devel-bounces@lists.xenproject.org Tue May 02 13:44:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 13:44:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528666.822115 (Exim 4.92) (envelope-from ) id 1ptqJ9-0004hB-Oo; Tue, 02 May 2023 13:44:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528666.822115; Tue, 02 May 2023 13:44:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptqJ9-0004h4-M7; Tue, 02 May 2023 13:44:43 +0000 Received: by outflank-mailman (input) for mailman id 528666; Tue, 02 May 2023 13:44:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptqJ8-0004gx-Kc for xen-devel@lists.xenproject.org; Tue, 02 May 2023 13:44:42 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on060b.outbound.protection.outlook.com [2a01:111:f400:fe0e::60b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7c79adbf-e8ef-11ed-8611-37d641c3527e; Tue, 02 May 2023 15:44:40 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8453.eurprd04.prod.outlook.com (2603:10a6:20b:410::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.23; Tue, 2 May 2023 13:44:38 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6340.030; Tue, 2 May 2023 13:44:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7c79adbf-e8ef-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A3VkFcEgpEAKuteAIF5KvAkBLHfZLggxHMosc6dwC0PUDGt1YCV0UAUyYUBSGHfHr28lGFHs1gZuW8laH5/ZxOw0WHtl3iqmJI5KHfohz3RXaKEIw5SkQ/wXFmwvJ73US4Zc0SqMxJGjHmugO54ok4Mq8PqJ/KzIcnazQx5CLgUruNmsgpp2IWV3J/UfCXTrzoyVwew8pQyNephczb2IgzAqLkBk2sX/UwwW26xYq6RLtOoxmv8CU6f+HE2toyRt459/TyktoNHbyAO/gvgmlCsJ+gkPVCNxAdyxU0Mqyf6BuUoAru67XBCh25eUr9RyE+6Rcy43WvciLy4rFX9Meg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2K4kVLOLa5gNCtfHtVS0PlZUKf9AIejVzarpWGB+1X4=; b=ahBocm5jBzDvIAwssSxE8pmammmzKGIoGjkCXPGFmk2FBdtEuLVjatYdCfCVGN2JKUU0fBEBY5tc4PwCS/cvUaurqGLAB/2xIDFmu0Xbq0AFoh9ocnBFOXJPjH9F/x9eQsn3FD/2P7Hmx4TPN+sjIBUHGmPytQ9hdmKgPio8WT8a4hnJ1czfF9PUkETYZg97kSAhyA4kLpzJugOIwGMkUsc/YSyBaWVMYenCwKBLUjNrSyTjXCBShoBIirQav3V5W2qQuKdThWHNRVSVgaEwUg2EJAk7wvGOCi5oSsEMVGwan3XV19pGh96fH17pax/tBGCPm6Y67HJluCIkeItmsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2K4kVLOLa5gNCtfHtVS0PlZUKf9AIejVzarpWGB+1X4=; b=pLuaQCoBSxTLGBQxW9BPLyrOMEY8+x9KGISYB/WtIZx3zdMKOalzr8SI0PS62YszwfIDm2TEN+yDszzzfJyGTwKoS7cleFr0rpt2Qn/KUoTfIJ5cmy9jW7/fELfUsJSClfx8UItoWcOjfgjXbgDHpnubUNrpuOrBRGv5hFBJkI9U8bDFFe6ag/jmTwhWpcycLwykbCsYw9nQve8hXesmBXlXNrud3Am15qKuYhlCOe6+u9Fi1fhBA6IzABe6TTbiaDgn/QFwfjlHlXQWEyKQXmwv2RjJtAF4JW5ltXsSnliv/+95+fXyOuaIn5kHpFvVVPqW86h1mxngxt9nsQx12Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 2 May 2023 15:44:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: HAS_CC_CET_IBT misdetected Content-Language: en-US To: Olaf Hering Cc: xen-devel@lists.xenproject.org References: <20230502074853.7cd10ee3.olaf@aepfle.de> <43b1c214-4248-a735-6f8c-9e08bdd2eaf6@suse.com> <20230502133313.2192eb99.olaf@aepfle.de> <20230502140444.1dacdb33.olaf@aepfle.de> <9353d3f3-563b-ff88-0b0b-dfa2bb03522c@suse.com> <20230502153612.431dfc08.olaf@aepfle.de> From: Jan Beulich In-Reply-To: <20230502153612.431dfc08.olaf@aepfle.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0160.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b3::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8453:EE_ X-MS-Office365-Filtering-Correlation-Id: da8d63e4-880e-41a9-e4e1-08db4b135fb1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TS+o+vBavhdO3T9JE22iVBD11mqKajDwea9IyVP3rvoV2IttswwEe1dR+dgb17kd0FypCC/+ON7RQ6jEMi/JnxgDkV+pym3kdFgjTZABvoWb6kGpRiy24tjao9SgGGj0YvMUPBJMvXKK2G7YHd1xdxYvy5uDLzuOxyREIDu6lqn9EeGpEHGKsIbg1G+3ZT2WPxTspLwDlYqQX3HSx6STmUpkpE3/wWhhCCT44KKJMDa79BZ5tfko6DI/3eCqQ1W5MMhX9+k/bMNjT0mPBJRFq3bUF3LLe7upzGrOV1XHjsDLJmZnBvX4fvIVBL+34r9HDIlbxoW4SzIJH4pYO0Vjk2y5exqh4X5mBB7WmFMA2OT5ao7TRl5zVroM71kam1EUWzlIeGn725hoVfAwRLS1jNFx/Z57esaLSPXAlrf5h5C2RO7PkD5JaAO5BlKsBEVHhLNcmoOnQ3ziY7DSJjgiq7t/k/5/g6uPVe/nwQpA4booupd0H88RS+6voatOeFZbKq8RI9/81xq59zn+QZMZRKHpYJF25Z1l7+WODGJyZve5bsFLongN9shlIEZ9RTTsNpo6tB4GSJPbiUJjFx4Aq9ChfuVOXKqso2ZsgS+CHXZ5UeqxSVk6jcHi1PmXbbVriLrSKNKIrXtpLwW6/IlbTQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(39860400002)(366004)(346002)(376002)(136003)(451199021)(41300700001)(8936002)(8676002)(53546011)(31686004)(2616005)(83380400001)(6666004)(26005)(86362001)(4744005)(66476007)(478600001)(66556008)(6916009)(31696002)(66946007)(38100700002)(186003)(4326008)(6486002)(316002)(5660300002)(7116003)(36756003)(2906002)(6512007)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RWtWR2hOUElBeWM4Qm52RGRWRXZacExZcVdwZnRKODV2SjNpVFQ5Z3JHNXNN?= =?utf-8?B?bzI3Q0UzMWVuTXFhUjh1ckJRYzV2WUUrTUs3S2lXK0tZRE9SUWo4WGsybVgy?= =?utf-8?B?N1IyTFYzT2oyQ0M4cnp6enNXQ0MyVFJGOUs2V2hnRXlaNXVmNllGSEJTektX?= =?utf-8?B?bk9iMzQ1MERRZ09yVEVCSEN0NVlBTUxVaFR5TUlYaXdhRGw0ZHZjSWkzOE1o?= =?utf-8?B?dERoVlBoNE8wNHhGU3REaUwzRWFDM3dSaEdZeWhkWGdmQ0ZYTHVGejJubG8y?= =?utf-8?B?eDl2Qk9iSWN4cERsOVMwZXFudTBDNkRWYkhxaDNoNHRNb3RYRlNkQnBQQS9G?= =?utf-8?B?QXV5aVgyL1M1ZElWRXcvYndyUitNTHhNWXhwK2tPK05SdGpGeHBrZWFBaGV6?= =?utf-8?B?RzEybnAwazF6UDNlTGh1ZXpidmRSbis1SGpidnJnbWdDaTJGK2xNNmxYYXo3?= =?utf-8?B?VkhRSnc1d1JycEQwbFVoYnlnSHBIbEhPdTZWSkt4UnpwNFdBTXVldEZmS0tJ?= =?utf-8?B?dE9TOTFQSGJRVys4eHBpaFJPLzRPelJGbkZEdjUyVXMxL1AvcW0wM1RWUUkr?= =?utf-8?B?ZHNTRzRadFk5T0tRWkNSZGxHWDh6QUoxSFV3NVJVN3pYd293alBBdUpKdWYy?= =?utf-8?B?bE9zL1ZFbml5WEo1SzZVQktXd2haOVJOeTdaSmpZdDc3TWxrRDA5RmlDSWRt?= =?utf-8?B?ZWFhd0xrek9sTmdnNnk5OEVhemFDK1lwQ0pxSG1HN3JocnhDZUdteWs4RCtH?= =?utf-8?B?SFkzd0RyYkttVnFoS1Jrd3dwODc2NXZ6STFmTGc4UEpadkgra1RiaXpCaU83?= =?utf-8?B?SHNKY3NKNFl6YzBUUjNrdDNiNjEwLzNnZ1lTZGI3L28yV1NyYUNHbms0Y2sz?= =?utf-8?B?N0pxRVNISHR5b3VhSlNxVXVzMTg0eFJzeTQ1eFIrTFlUV3VJeHlTVFhxUGtz?= =?utf-8?B?SldET1JvQVdVVkx6RWlnQ3doQ2diaHg0dmpmTUdsVURhMlo1L2NMdnZ3ajJx?= =?utf-8?B?WitLVTNZY0pMVGdiYWZWa1dmN3hCZS9FYWhFbHJNUWYzR2pKTUd4REdQY1NZ?= =?utf-8?B?YU1JeFVIZDhBOVlDTFFBSjVTZk9hWEw2NkxjL1RiakhxZEpwSWVNWTFBREI5?= =?utf-8?B?djFPZlFSS3p2M0FHZld5UjVYcUpCM2MvT2MvVUZzV3l4V1NhS1ExcStiMTFV?= =?utf-8?B?MFBqWExyL3FMZkhIdXliaUFDbGkvTFJJKzRmdE8xR20wMDdteHVuanJCells?= =?utf-8?B?L25tLzFWeW11bzgzdmtEVkxKckF6T2pERXB6dTFUTDR5ZTA2M3YzeG9pTzVO?= =?utf-8?B?M0REa2thbVF1OWNHWUlUdVR2bmhpblRwQWNqSm5aRVNOZDZITERpWWo1Wm10?= =?utf-8?B?QUdESUxkNVNPTm56d0JYOVlGL2UydG04U1J4MFhVZXREcGR6OWQ3TUswVThR?= =?utf-8?B?UmdFcjBnM0RZUzZiVmJHZGtJQmJ6YTdNbUt5a21iRzBHZ2FTS0VHa2JGWnhT?= =?utf-8?B?Z2E5VGlPSHZYRGFwUm1NblRBQmRsYWI3VFEwSGdIU1NQZWZkckZXMVBEb25o?= =?utf-8?B?Tk8vbUY1Y0xpbUNjRFpaYm1hN0F5NllkTERuV2owbWV6eU4vd2NRTHhpOGJz?= =?utf-8?B?eStCSThjTXBrSE8vTzVCYjBjUFpNZ0t0RzZkck5URDZUTTFnMi9kQnh3VzVC?= =?utf-8?B?TUNVS2N1ZjdSSUJNa0JCQ3ZmcHA3SGdHYk4xT1NZOUdrM2NuYnBwSlBzOE10?= =?utf-8?B?NUJxRTdyaElQVjBTY2ZHQWMrTUt0SXQ1L1FjQTl1K3BDUHZkQW1LVlNnQjJq?= =?utf-8?B?ZlkremY5Q3J3eTZ6UERjbEhneWl4cldKSERJSVZLckZiRGZvQnpaTVVVYnQx?= =?utf-8?B?TFAvemZvVWNMUU1EK1orcklFMnJOYS9ZTnpWQUh3QzRYak92NmFKZXlmZHEv?= =?utf-8?B?bTVTSEMvVDZkR0lYUHlJRUpXZ0ZoOWFUU0srTDEyWXRYTzNxbnhvYU9KTGhv?= =?utf-8?B?ZzkrTEtwbWg0Z3JMRHRGMXc0UXlnNThKUURNQnVRNnVMZUZaSUtqK3BJdnZy?= =?utf-8?B?TDVqb2RmVkhBcnlGRGtlSjhSb2hhWjZ4ZGxybThqTjcrWTI3THdRUU9BOG9j?= =?utf-8?Q?rgedz8Q2gyO/j+GE1QAbDzN94?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: da8d63e4-880e-41a9-e4e1-08db4b135fb1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 13:44:38.6958 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kh5Pz7PceY9hdqkmySusWqEZKzAPsyrmihAO8vE/2Yp2JCCvlcCD/8HBOrbkpbJ1kToOpwKbFDfeEbdVGxP/Eg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8453 On 02.05.2023 15:36, Olaf Hering wrote: > Tue, 2 May 2023 15:29:19 +0200 Jan Beulich : > >> Getting this to work automatically is a continued subject of discussion. > > I think the only real solution is an out-of-tree build. Essentially every single component needs to detect a toolchain change. This is unrealistic. How would an out-of-tree build help (which for the hypervisor we now have support for)? An incremental build there will hit exactly the same issue afaict. Jan From xen-devel-bounces@lists.xenproject.org Tue May 02 13:45:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 13:45:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528670.822125 (Exim 4.92) (envelope-from ) id 1ptqKB-0005Ff-2G; Tue, 02 May 2023 13:45:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528670.822125; Tue, 02 May 2023 13:45:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptqKA-0005FW-Vi; Tue, 02 May 2023 13:45:46 +0000 Received: by outflank-mailman (input) for mailman id 528670; Tue, 02 May 2023 13:45:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptqK9-0005FG-Vs; Tue, 02 May 2023 13:45:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptqK9-0004J2-El; Tue, 02 May 2023 13:45:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptqK9-00039J-3V; Tue, 02 May 2023 13:45:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ptqK9-0004Gn-33; Tue, 02 May 2023 13:45:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Ozha16LYgUogcjmrJ/98dBB/GrTJ7I2mbl/WLcbeX+4=; b=iujQ7yJwcQfibkn3lHCnFEnAOz aMr6frJQ9Kt0Gs00gUQiISinTZ1vv8l7PpwGz5rtaXlX9sw+kYYnJ3dvladVvPrTXbZChZMZ3cX09 /Iim1znuxMxLJ9U7zRbIS8P9AAG/JGsmJIW+vNUiFtetj3ENyk0gHGM+VlhygQq4PSmQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180501: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-i386-migrupgrade:xen-install/src_host:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=ef841d2a2377f5297add27e637b725426bb4840a X-Osstest-Versions-That: xen=ef841d2a2377f5297add27e637b725426bb4840a From: osstest service owner Date: Tue, 02 May 2023 13:45:45 +0000 flight 180501 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/180501/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 180496 pass in 180501 test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail in 180496 pass in 180501 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail in 180496 pass in 180501 test-amd64-i386-migrupgrade 10 xen-install/src_host fail pass in 180496 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180496 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180496 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180496 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180496 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180496 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180496 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 180496 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 180496 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180496 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 180496 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180496 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180496 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: xen ef841d2a2377f5297add27e637b725426bb4840a baseline version: xen ef841d2a2377f5297add27e637b725426bb4840a Last test of basis 180501 2023-05-02 01:52:02 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Tue May 02 13:56:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 13:56:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528677.822135 (Exim 4.92) (envelope-from ) id 1ptqTv-0006tb-4O; Tue, 02 May 2023 13:55:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528677.822135; Tue, 02 May 2023 13:55:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptqTv-0006tU-1K; Tue, 02 May 2023 13:55:51 +0000 Received: by outflank-mailman (input) for mailman id 528677; Tue, 02 May 2023 13:55:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptqTt-0006tO-BS for xen-devel@lists.xenproject.org; Tue, 02 May 2023 13:55:49 +0000 Received: from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de [81.169.146.161]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 084e93ce-e8f1-11ed-8611-37d641c3527e; Tue, 02 May 2023 15:55:44 +0200 (CEST) Received: from sender by smtp.strato.de (RZmta 49.4.0 AUTH) with ESMTPSA id x6987cz42DthdKB (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Tue, 2 May 2023 15:55:43 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 084e93ce-e8f1-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1683035743; cv=none; d=strato.com; s=strato-dkim-0002; b=XeW4ofbK+AA3guzhnDqpR8OkHutJp/iL36w6+/V1wRW6DBB79cQJZOoqxxJoscU9am NgPJQVZMsOd+TozEpbMso2Npo/1l25EE5l/UkEh0j3yMQm3zCEY+QXcH87gz5uoLbA6P BWcpM8hNWVA7uNhh6UstMlgpLozcvs7zFjhnbFKIfEvR1H18788PUKAbzLQ+GI27RkAo GiltCUI3BxBAZOfXnhax80fjL235hqXqIXrjAFZ9gsirOb95cOr0CF0eSB0HeG6IDMr2 X6zI+OplFpwzRb8Knht+4D4TUxiVQz2teSVxT2EfDOBgayMRA3+cCfUGDwevDYIW8KGf 7dpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1683035743; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=ppQjs137PIEaIYcsU7xdieFlAfxpPdqVwfIympx+wZU=; b=T2GR49QIZYjFVjUlSOs3RRCQHfyF3/FqUOFambY//D2OPdoM56N+RAJ4rKRbJ+fHHB 11QX7ssQ/RuWvDjykyyLg7RT1yzL91QOGsADu+bg2IGUHdsfELlodWvlxd+vOwNYzV4z dCz4iWeHuZUl4Epl9ZOvjEEYYv4bhUV3rS5Wjpu2BMVIvndE87iR+LvgE+1kWTvwAgVJ 7lvbpECRAtW/PbIBd9WxVfAZFGuFNpEkYG8tol632VeENdyAyf2mXBRdnt4A7e31+nfI F8q94lpoGceVY0L186fY9tPgqiXb+zUn5WRANJYseuTQpfnMmXwU4sZvWmY2yvwoGI0x GAmg== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1683035743; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=ppQjs137PIEaIYcsU7xdieFlAfxpPdqVwfIympx+wZU=; b=d2BReKChG41bRnZ9NbI5CKFIqd4LdKboFlmxKz17MU8Ez6ssOyx9RUL1GyrNZaAk39 kEUOUAFz4EPW4aqKHpdVUD1gqgjnHgQzDsOZcYJKn75O4gsJDgAq+9J+CETMe6MawciB mFhZGxY4P0243jfxIxIt4P2JgxTFgMxeEWR7iFDJC5zDHSEChHxhLXMUiEej1dDJbAZj 6ND/GvAptsZJQMT/6oEHbQpEB2hcgQVYXgCZdFDNUX9ag3mwkutFaeKxlOx6sUP8Jo/6 4RfhAPEnwaB94INY98DwW7LN3xe6d3xK4A3yLzL4kdVAhjVistpAYy6CWoKEx7sR2y0P MJAA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1683035743; s=strato-dkim-0003; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=ppQjs137PIEaIYcsU7xdieFlAfxpPdqVwfIympx+wZU=; b=iIFIO0oVE5btZ3rW4u9IZ3fr/IB7z7R36u8ZnyC7qbpGhXswZWGDtWYvnq9gJs6iW9 8ETtO42BMUUahh6dg1DQ== X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisR5BxOIbBnsc1fym1gFvNQ7EzMpH+yFJc4aADp/8Q==" Date: Tue, 2 May 2023 15:55:37 +0200 From: Olaf Hering To: Jan Beulich Cc: xen-devel@lists.xenproject.org Subject: Re: HAS_CC_CET_IBT misdetected Message-ID: <20230502155537.7983f8c9.olaf@aepfle.de> In-Reply-To: References: <20230502074853.7cd10ee3.olaf@aepfle.de> <43b1c214-4248-a735-6f8c-9e08bdd2eaf6@suse.com> <20230502133313.2192eb99.olaf@aepfle.de> <20230502140444.1dacdb33.olaf@aepfle.de> <9353d3f3-563b-ff88-0b0b-dfa2bb03522c@suse.com> <20230502153612.431dfc08.olaf@aepfle.de> X-Mailer: Claws Mail 20220819T065813.516423bc hat ein Softwareproblem, kann man nichts machen. MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/txqaj7Ga2TsSeTMnuGl7Usi"; protocol="application/pgp-signature"; micalg=pgp-sha256 Content-Transfer-Encoding: 7bit --Sig_/txqaj7Ga2TsSeTMnuGl7Usi Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Tue, 2 May 2023 15:44:41 +0200 Jan Beulich : > How would an out-of-tree build help (which for the hypervisor we now > have support for)? An incremental build there will hit exactly the same > issue afaict. Each container target will use a separate output directory. The Leap contai= ner will only see Leap things, the Tumbleweed container will only see Tumbl= eweed things. A toolchain update within a container will be no different than it is today= . But there will be no unexpected jumps anymore. Olaf --Sig_/txqaj7Ga2TsSeTMnuGl7Usi Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmRRFlkACgkQ86SN7mm1 DoDc6xAAmT2Bn9OAawtgCy/HNNIyKO1JcjrwHb0s32tyJtABnfXpFYLlqO2zgbcN j3CfVD9YXzH1V9UE7pPhPFDJcih1elvyzu3iLUy64ZQ+xOcJW2H0sKGhYj9U7uR0 CEcK+2iZASYcW+rIg3AAHXQixDaZjP3P9fYQbvgYb/919TB4AW+Pk/OA9GCOBz5M OXnMSHsgPlyfm9SpAkI4u5FPN4L28MlHV5K9AWTv0hB7FlYaYlfZcFXipYZAEtp4 ES9UxowQcjLpKb5P5ms2RfHCd6MDiQumRkiM7WCASGGnQbW1fY4UpNo7fZqO4hL0 +uEGVlOxQxl3aL1ZUlAHbfFUoBx1H4ZVA1C20uSnrhSqHKdI+p/Y75KQCsCoxMVT /Zh9cvBegpDECHJc0XlOEC2nJsZ5SY/S9zNxtjB9mMLYQKnweHC35yv2uebbWSTQ F1IPG3esTZukhv0I+eVfMKdGjwiWsq4PvYT47Q0l9ranP8nxKqSsuyI+ftyi6dZb ogG0WVk2Iv+4/DXQY7DeaU+Ff3qh7TgAB5CHvU4nkEjh6mcVtYVyv0zWOIZMjQZM zPqFPyBhs8Utfyd14dOpQ9Q7EQsodfjTcaGLC4iXJBJ9QeT1oS2fQ28AIb1B40ku 1j2i9fnpbN7ncSEGoWWZe2xI2wMWqFzbY1fqJx87qT0AWD2YHt8= =LOIW -----END PGP SIGNATURE----- --Sig_/txqaj7Ga2TsSeTMnuGl7Usi-- From xen-devel-bounces@lists.xenproject.org Tue May 02 14:29:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 14:29:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528683.822145 (Exim 4.92) (envelope-from ) id 1ptr03-0002Ew-LQ; Tue, 02 May 2023 14:29:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528683.822145; Tue, 02 May 2023 14:29:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptr03-0002Ep-II; Tue, 02 May 2023 14:29:03 +0000 Received: by outflank-mailman (input) for mailman id 528683; Tue, 02 May 2023 14:29:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptr02-0002Ef-DJ; Tue, 02 May 2023 14:29:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptr01-0005G0-Tp; Tue, 02 May 2023 14:29:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptr01-0004F1-5p; Tue, 02 May 2023 14:29:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ptr01-0000vO-5M; Tue, 02 May 2023 14:29:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=y6TEwowuifiYIJCbqKlbvg3zuzqFgR6NMDfoyetv85g=; b=M+C+bK9fiZJRVSSUbHY+8RUiQP cQ6g1CC6g2y1A8tki610jp0+2E7tFlpN8CWRq7RL9ouELBt3ZGwWCR3mY2hvO7HkgwXKGUGRIPuhi YfjKt3LE8rB/kBk8Sxu6faqElw5SzRTet24XSOcQnsIEG4pbSDSPAZioYvSi92QY4NmE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 180505: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=b033eddc9779109c06a26936321d27a2ef4e088b X-Osstest-Versions-That: xen=ef841d2a2377f5297add27e637b725426bb4840a From: osstest service owner Date: Tue, 02 May 2023 14:29:01 +0000 flight 180505 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/180505/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen b033eddc9779109c06a26936321d27a2ef4e088b baseline version: xen ef841d2a2377f5297add27e637b725426bb4840a Last test of basis 180494 2023-05-01 11:03:16 Z 1 days Testing same since 180505 2023-05-02 11:00:27 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Ayan Kumar Halder Jan Beulich Juergen Gross jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git ef841d2a23..b033eddc97 b033eddc9779109c06a26936321d27a2ef4e088b -> smoke From xen-devel-bounces@lists.xenproject.org Tue May 02 14:37:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 14:37:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528688.822155 (Exim 4.92) (envelope-from ) id 1ptr8c-0003kj-HF; Tue, 02 May 2023 14:37:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528688.822155; Tue, 02 May 2023 14:37:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptr8c-0003kc-EW; Tue, 02 May 2023 14:37:54 +0000 Received: by outflank-mailman (input) for mailman id 528688; Tue, 02 May 2023 14:37:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptr8a-0003kW-Nh for xen-devel@lists.xenproject.org; Tue, 02 May 2023 14:37:52 +0000 Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [2607:f8b0:4864:20::730]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e9cd0dce-e8f6-11ed-8611-37d641c3527e; Tue, 02 May 2023 16:37:50 +0200 (CEST) Received: by mail-qk1-x730.google.com with SMTP id af79cd13be357-74adf6adac6so359821485a.0 for ; Tue, 02 May 2023 07:37:50 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id l17-20020a0ce511000000b005dd8b9345dbsm2123688qvm.115.2023.05.02.07.37.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 07:37:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e9cd0dce-e8f6-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683038269; x=1685630269; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=mvVfVNvdUQ+dsVuQLzLVZgrOBwJbAlAHyxtlDPxYDPI=; b=lMWbI9liklknEyp0AdJfA4fBntRe1FaP0pj28bEYVRNdksesc9BHCIRW52HokmkTNa 207rKs0CEVeHnl/UoakvcCupxqMXBb1fboaptwS7g6SIB5qtTCM3As3PLwDbG2T8bPpx YAry278fCOasg5uNV66jrPXKjxqSFpVqzUdIUVL3N4uTkKyk7l/pQxYi8Y2ih4HBERpp 5lj6j+LX4Ke4vyr1hfbGEuqdLVIvv30gHWy8DztM1aBIMy8zB8HT0quLvLxbyatd5nd9 ZarV8fvQ5oyAIu97M2gY+ZZo7tZsUdL5BcuptsiHKrLZq5vCk7MowTw1mCYIvQxvGCjA dKXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683038269; x=1685630269; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mvVfVNvdUQ+dsVuQLzLVZgrOBwJbAlAHyxtlDPxYDPI=; b=AcpNz2yHkwjE9Lzc4snGv0k38AJSLCxAKKvwb9o3GGrNMCBurcITr3clHmf7yb02lP 0fepwoN118J13znmQVVBXYIdySwJ/J+p5s5YvMrkUntVEG3OzG9466yP6xDUoPlZRTWn kqI3qpOHaJ5Nd3lDpTmLOcOVLVZ9ZHjJYZ/6mORb351O8ajdgpXYVwyNl9u57oiB7ObN NbaQ4aby3dWhtvz3bUGuanSBpj8QFVL2IGZ3NfaF+RrgduMZsZCJUDjtZ5Anqp+JDSSw dciU/HroCGzuEXzUiCnjIbxMdMKfpNj3MKkleEuy3KzeoUROojKGojxtopnSJNBliDJ0 dgKg== X-Gm-Message-State: AC+VfDyEJMlQLGsMn+u/cQgku1tQJOYuPQNIH5P5tzSVPjf3RLLgWEWT YKP1uf0/pCAI/HQcPSlO6q4= X-Google-Smtp-Source: ACHHUZ7zYKwzvzyqRlxFZI4PuMYtfmBEJ9Pyx91MTJn4ENx0QM8Y5we0PQ1VIzxQMHmYfE+nlnND0Q== X-Received: by 2002:a05:6214:1d23:b0:5f7:8b31:4548 with SMTP id f3-20020a0562141d2300b005f78b314548mr6214915qvd.4.1683038269491; Tue, 02 May 2023 07:37:49 -0700 (PDT) From: Jason Andryuk To: qemu-devel@nongnu.org Cc: Jason Andryuk , Greg Kurz , Christian Schoenebeck , Stefano Stabellini , Anthony Perard , Paul Durrant , xen-devel@lists.xenproject.org (open list:X86 Xen CPUs) Subject: [PATCH] 9pfs/xen: Fix segfault on shutdown Date: Tue, 2 May 2023 10:37:22 -0400 Message-Id: <20230502143722.15613-1-jandryuk@gmail.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit xen_9pfs_free can't use gnttabdev since it is already closed and NULL-ed out when free is called. Do the teardown in _disconnect(). This matches the setup done in _connect(). trace-events are also added for the XenDevOps functions. Signed-off-by: Jason Andryuk --- hw/9pfs/trace-events | 5 +++++ hw/9pfs/xen-9p-backend.c | 36 +++++++++++++++++++++++------------- 2 files changed, 28 insertions(+), 13 deletions(-) diff --git a/hw/9pfs/trace-events b/hw/9pfs/trace-events index 6c77966c0b..7b5b0b5a48 100644 --- a/hw/9pfs/trace-events +++ b/hw/9pfs/trace-events @@ -48,3 +48,8 @@ v9fs_readlink(uint16_t tag, uint8_t id, int32_t fid) "tag %d id %d fid %d" v9fs_readlink_return(uint16_t tag, uint8_t id, char* target) "tag %d id %d name %s" v9fs_setattr(uint16_t tag, uint8_t id, int32_t fid, int32_t valid, int32_t mode, int32_t uid, int32_t gid, int64_t size, int64_t atime_sec, int64_t mtime_sec) "tag %u id %u fid %d iattr={valid %d mode %d uid %d gid %d size %"PRId64" atime=%"PRId64" mtime=%"PRId64" }" v9fs_setattr_return(uint16_t tag, uint8_t id) "tag %u id %u" + +xen_9pfs_alloc(char *name) "name %s" +xen_9pfs_connect(char *name) "name %s" +xen_9pfs_disconnect(char *name) "name %s" +xen_9pfs_free(char *name) "name %s" diff --git a/hw/9pfs/xen-9p-backend.c b/hw/9pfs/xen-9p-backend.c index 0e266c552b..c646a0b3d1 100644 --- a/hw/9pfs/xen-9p-backend.c +++ b/hw/9pfs/xen-9p-backend.c @@ -25,6 +25,8 @@ #include "qemu/iov.h" #include "fsdev/qemu-fsdev.h" +#include "trace.h" + #define VERSIONS "1" #define MAX_RINGS 8 #define MAX_RING_ORDER 9 @@ -337,6 +339,8 @@ static void xen_9pfs_disconnect(struct XenLegacyDevice *xendev) Xen9pfsDev *xen_9pdev = container_of(xendev, Xen9pfsDev, xendev); int i; + trace_xen_9pfs_disconnect(xendev->name); + for (i = 0; i < xen_9pdev->num_rings; i++) { if (xen_9pdev->rings[i].evtchndev != NULL) { qemu_set_fd_handler(qemu_xen_evtchn_fd(xen_9pdev->rings[i].evtchndev), @@ -345,40 +349,42 @@ static void xen_9pfs_disconnect(struct XenLegacyDevice *xendev) xen_9pdev->rings[i].local_port); xen_9pdev->rings[i].evtchndev = NULL; } - } -} - -static int xen_9pfs_free(struct XenLegacyDevice *xendev) -{ - Xen9pfsDev *xen_9pdev = container_of(xendev, Xen9pfsDev, xendev); - int i; - - if (xen_9pdev->rings[0].evtchndev != NULL) { - xen_9pfs_disconnect(xendev); - } - - for (i = 0; i < xen_9pdev->num_rings; i++) { if (xen_9pdev->rings[i].data != NULL) { xen_be_unmap_grant_refs(&xen_9pdev->xendev, xen_9pdev->rings[i].data, xen_9pdev->rings[i].intf->ref, (1 << xen_9pdev->rings[i].ring_order)); + xen_9pdev->rings[i].data = NULL; } if (xen_9pdev->rings[i].intf != NULL) { xen_be_unmap_grant_ref(&xen_9pdev->xendev, xen_9pdev->rings[i].intf, xen_9pdev->rings[i].ref); + xen_9pdev->rings[i].intf = NULL; } if (xen_9pdev->rings[i].bh != NULL) { qemu_bh_delete(xen_9pdev->rings[i].bh); + xen_9pdev->rings[i].bh = NULL; } } g_free(xen_9pdev->id); + xen_9pdev->id = NULL; g_free(xen_9pdev->tag); + xen_9pdev->tag = NULL; g_free(xen_9pdev->path); + xen_9pdev->path = NULL; g_free(xen_9pdev->security_model); + xen_9pdev->security_model = NULL; g_free(xen_9pdev->rings); + xen_9pdev->rings = NULL; + return; +} + +static int xen_9pfs_free(struct XenLegacyDevice *xendev) +{ + trace_xen_9pfs_free(xendev->name); + return 0; } @@ -390,6 +396,8 @@ static int xen_9pfs_connect(struct XenLegacyDevice *xendev) V9fsState *s = &xen_9pdev->state; QemuOpts *fsdev; + trace_xen_9pfs_connect(xendev->name); + if (xenstore_read_fe_int(&xen_9pdev->xendev, "num-rings", &xen_9pdev->num_rings) == -1 || xen_9pdev->num_rings > MAX_RINGS || xen_9pdev->num_rings < 1) { @@ -499,6 +507,8 @@ out: static void xen_9pfs_alloc(struct XenLegacyDevice *xendev) { + trace_xen_9pfs_alloc(xendev->name); + xenstore_write_be_str(xendev, "versions", VERSIONS); xenstore_write_be_int(xendev, "max-rings", MAX_RINGS); xenstore_write_be_int(xendev, "max-ring-page-order", MAX_RING_ORDER); -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Tue May 02 14:45:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 14:45:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528693.822165 (Exim 4.92) (envelope-from ) id 1ptrFe-0005I9-9J; Tue, 02 May 2023 14:45:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528693.822165; Tue, 02 May 2023 14:45:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptrFe-0005I2-67; Tue, 02 May 2023 14:45:10 +0000 Received: by outflank-mailman (input) for mailman id 528693; Tue, 02 May 2023 14:45:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptrFc-0005Hw-KT for xen-devel@lists.xen.org; Tue, 02 May 2023 14:45:08 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ebbba320-e8f7-11ed-b225-6b7b168915f2; Tue, 02 May 2023 16:45:06 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ebbba320-e8f7-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683038706; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=AY1oCzQUnRwuXpbdb05yJrH7EzCQOVt+9I90RiIuFAE=; b=ecShEVvL2VB8e6oozCRqB6DuAdEx4guQ+HcDRrsdkkDAAIl2PeqKhxdn Z/AY9VvB+k3RFUFZr4RmG55NHuYMedPSvmwzh47lZhkkeZ5biKhG6rMAP DZ/2jn2iAL1tnlDrla71GRrJYGOGbSICz1Td2A8FpqCydAapAczOhYwj5 8=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 106346520 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:/l7eVKNUtbzLopTvrR0cl8FynXyQoLVcMsEvi/4bfWQNrUomgz0Hx zMaXzyHbPiJZWekf4twOYm/9EJTvJfUmoJiSgto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvPrRC9H5qyo42tF5gZmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0rdJW01J0 e4VESpTdzSlmdqZh5C7V9A506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI ZNEN3w2Nk+ojx5nYz/7DLo3mvuogX/uNSVVsluPqYI84nTJzRw327/oWDbQUoXSG54JwBvC/ goq+UzSPVZKL9yc8AC//yuzp7TBgg3VdZg7QejQGvlC3wTImz175ActfUW6u/Siigi9RtdWM WQQ+ywnt69081akJvHtUhv9rHOasxo0X9tLD/Z8+AyLjK3O7G6xBGceSSVaQMc7r8JwTjsvv neLgtfoCDpHoLCTD3WH+d+8szK0MiUTMSkNeC4YUQwZy93ipogpiVTIVNkLOLWplNTpHiq1z z2UhC8mwrESltIQkaG6+1ndhHSrvJehZgcx6xWRVG+j6A50TIqkYYWy7h7c9/koBIOQUlmAs WVCg8+f9uEDF7mJlSqEWuJLF7asj96CNDDfmkJ+BJkJ+DGk+nrldodViBlzPkZqdN0PeT7tZ E7VtitV5ZlaJnzsarV4C6q4E8kwxLLsPcjkXPvTKNFJZ/BMmBSvpX80IxTKhia0zRZqyPtkU XuGTSqyJSckU4hg6Ci7fv1DyJsN2BgRgkHTWKmumnxLzoGiiG6ppaYtaQXeNbhgtvPb/2054 P4EaZLUlkw3vPnWJ3COrNVNdQ1iwW0TX8ieliBBSgKUzuOK8kkFAuSZ/74ucpcNc099xraRp SHVtqO1JTPCaZz7xeaiMCoLhEvHB8oXkJ7CFXVE0ayU83Yie52zy6wUaoE6e7IqnMQ6k64uH qdaIp/YXKkQItgixwnxkLGn9NAyHPhVrVvm09WZjMgXIMc7Gl2hFi7MdQrz7igeZheKWT8Fi +T4jGvzGMNTLzmO+e6KMJpDOXvt5ylC8A+zNmOUSuRulLLEqtk2cXSv1qVofKnh63zrn1On6 upfOj9AzcGlnmP/2IKhaXysx2txL9ZDIw== IronPort-HdrOrdr: A9a23:TdL6VaPfSjkpUMBcTjejsMiBIKoaSvp037BK7S1MoNJuEvBw9v re+sjzsCWftN9/Yh4dcLy7VpVoBEmsl6KdgrNhWotKPjOW21dARbsKheffKn/bakjDH4Zmvp uIGJIObOEYY2IasS77ijPIbOrJwrO8gd6VbTG19QYdceloAZsQnzuQEmygYzRLrJEtP+tFKH KbjPA33waISDAsQemQIGIKZOTHr82jruObXfZXbyRXkzVnlFmTmcTHLyQ= X-Talos-CUID: =?us-ascii?q?9a23=3AWRI8C2gDAaWp0CjyKsLhsZVvTzJuI0OH4HD0MUK?= =?us-ascii?q?BEzhwbJuLcXDX2qN5qp87?= X-Talos-MUID: =?us-ascii?q?9a23=3A08WewQ1QDdhbZwZ7qZUMyCLX5DUjyJvpWFsNkqw?= =?us-ascii?q?8gcTdKg0rNSizohmta9py?= X-IronPort-AV: E=Sophos;i="5.99,244,1677560400"; d="scan'208";a="106346520" Date: Tue, 2 May 2023 15:44:50 +0100 From: Anthony PERARD To: Viresh Kumar CC: , Juergen Gross , Julien Grall , Vincent Guittot , , Alex =?iso-8859-1?Q?Benn=E9e?= , Mathieu Poirier , Oleksandr Tyshchenko , Erik Schilling Subject: Re: [PATCH] libxl: arm: Allow grant mappings for backends running on Dom0 Message-ID: <92c7f972-f617-40fc-bc5d-582c8154d03c@perard> References: <817f0320316dd144826add0ac834618026b91160.1680165772.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <817f0320316dd144826add0ac834618026b91160.1680165772.git.viresh.kumar@linaro.org> On Thu, Mar 30, 2023 at 02:13:08PM +0530, Viresh Kumar wrote: > diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in > index 10f37990be57..4879f136aab8 100644 > --- a/docs/man/xl.cfg.5.pod.in > +++ b/docs/man/xl.cfg.5.pod.in > @@ -1616,6 +1616,10 @@ properties in the Device Tree, the type field must be set to "virtio,device". > Specifies the transport mechanism for the Virtio device, only "mmio" is > supported for now. > > +=item B > + > +Allows Xen Grant memory mapping to be done from Dom0. I think this description is missing context. I'm not sure what it would means "from dom0" without reading the patch. Also, it says "allows", maybe this doesn't convey the meaning of "forced". How about something like: Always use grant mapping, even when the backend is run in dom0. (grant are already used if the backend is in another domain.) > + > =back > > =item B > diff --git a/tools/libs/light/libxl_virtio.c b/tools/libs/light/libxl_virtio.c > index faada49e184e..e1f15344ef97 100644 > --- a/tools/libs/light/libxl_virtio.c > +++ b/tools/libs/light/libxl_virtio.c > @@ -48,11 +48,13 @@ static int libxl__set_xenstore_virtio(libxl__gc *gc, uint32_t domid, > flexarray_append_pair(back, "base", GCSPRINTF("%#"PRIx64, virtio->base)); > flexarray_append_pair(back, "type", GCSPRINTF("%s", virtio->type)); > flexarray_append_pair(back, "transport", GCSPRINTF("%s", transport)); > + flexarray_append_pair(back, "forced_grant", GCSPRINTF("%u", virtio->forced_grant)); > > flexarray_append_pair(front, "irq", GCSPRINTF("%u", virtio->irq)); > flexarray_append_pair(front, "base", GCSPRINTF("%#"PRIx64, virtio->base)); > flexarray_append_pair(front, "type", GCSPRINTF("%s", virtio->type)); > flexarray_append_pair(front, "transport", GCSPRINTF("%s", transport)); > + flexarray_append_pair(front, "forced_grant", GCSPRINTF("%u", virtio->forced_grant)); This "forced_grant" feels weird to me in the protocol, I feel like this use of grant or not could be handled by the backend. For example in "blkif" protocol, there's plenty of "feature-*" which allows both front-end and back-end to advertise which feature they can or want to use. But maybe the fact that the device tree needs to be modified to be able to accommodate grant mapping means that libxl needs to ask the backend to use grant or not, and the frontend needs to now if it needs to use grant. > > return 0; > } > @@ -104,6 +106,15 @@ static int libxl__virtio_from_xenstore(libxl__gc *gc, const char *libxl_path, > } > } > > + tmp = NULL; > + rc = libxl__xs_read_checked(gc, XBT_NULL, > + GCSPRINTF("%s/forced_grant", be_path), &tmp); > + if (rc) goto out; > + > + if (tmp) { > + virtio->forced_grant = strtoul(tmp, NULL, 0); > + } > + > tmp = NULL; > rc = libxl__xs_read_checked(gc, XBT_NULL, > GCSPRINTF("%s/type", be_path), &tmp); > diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c > index 1f6f47daf4e1..3e34da099785 100644 > --- a/tools/xl/xl_parse.c > +++ b/tools/xl/xl_parse.c > @@ -1215,6 +1215,8 @@ static int parse_virtio_config(libxl_device_virtio *virtio, char *token) > } else if (MATCH_OPTION("transport", token, oparg)) { > rc = libxl_virtio_transport_from_string(oparg, &virtio->transport); > if (rc) return rc; > + } else if (MATCH_OPTION("forced_grant", token, oparg)) { > + virtio->forced_grant = strtoul(oparg, NULL, 0); Maybe store only !!strtoul() ? I don't think having values other that 0 or 1 is going to be good. > } else { > fprintf(stderr, "Unknown string \"%s\" in virtio spec\n", token); > return -1; Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue May 02 14:59:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 14:59:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528699.822174 (Exim 4.92) (envelope-from ) id 1ptrT6-00073A-Gx; Tue, 02 May 2023 14:59:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528699.822174; Tue, 02 May 2023 14:59:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptrT6-000733-Dl; Tue, 02 May 2023 14:59:04 +0000 Received: by outflank-mailman (input) for mailman id 528699; Tue, 02 May 2023 14:59:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptrT4-00072t-Ul for xen-devel@lists.xenproject.org; Tue, 02 May 2023 14:59:03 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2060.outbound.protection.outlook.com [40.107.247.60]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dd31d87a-e8f9-11ed-8611-37d641c3527e; Tue, 02 May 2023 16:58:57 +0200 (CEST) Received: from DB8PR04CA0026.eurprd04.prod.outlook.com (2603:10a6:10:110::36) by AS8PR08MB7815.eurprd08.prod.outlook.com (2603:10a6:20b:529::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 14:58:50 +0000 Received: from DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:110:cafe::e0) by DB8PR04CA0026.outlook.office365.com (2603:10a6:10:110::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31 via Frontend Transport; Tue, 2 May 2023 14:58:50 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT060.mail.protection.outlook.com (100.127.142.238) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.19 via Frontend Transport; Tue, 2 May 2023 14:58:49 +0000 Received: ("Tessian outbound 3a01b65b5aad:v136"); Tue, 02 May 2023 14:58:49 +0000 Received: from d9863d2e0def.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C45C26F2-BA9F-4E86-83E4-71C0489797EC.1; Tue, 02 May 2023 14:58:42 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d9863d2e0def.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 02 May 2023 14:58:42 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by AS8PR08MB9791.eurprd08.prod.outlook.com (2603:10a6:20b:614::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 14:58:41 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::a4ab:cdfa:b445:7ecb]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::a4ab:cdfa:b445:7ecb%7]) with mapi id 15.20.6340.031; Tue, 2 May 2023 14:58:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dd31d87a-e8f9-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CoBq4X/ytiUZ+0l51aI3Y1BdDXoWW4utuLAfOzMoDMw=; b=CGedJUB5Dw3X8EqHxpm4JSFSuD/JBi60rl8xHgJc4whKjfhvWz7JVNuvxVu9MNQc9gKjhC1He/Lb6rAXEWMO68T4NezCVYf9oSFD4QTfkZMcBhnpxXpQQ0OvJSLS5lbxkNc4q0drTmdrykTwjyI7kxoI97aSUQ5Oh7mkWKOc3aU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: a9e3d369f3555d3d X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RuUoe9q251JAtDGbWBbhaJBZwGnv944m4b9/uZVKpYsHav2Or71oZ/yofCAQAY/0fr2xj891FUraR+tJxpng3igcGyl/omy3Ec127mYpZI3na+5E4qAmVJvuBsoaklDjTzmsfbHFYxukVb3U4hNsS/puVgVOnBJl2dP1BPq25y/zlDwoSWKCGvBvGq4kEX3/soEsRucVcFusnJ2pFry5kUxlyPeeTGJ5DUg/PKGKNk1k5GZC/PGVYvVnCfEcRaP6KL/ySp8UoMMvkRzhLTtO1DKVOsLsJjdIatDOW+hjZ0+bpyrlHDaSvS1M6vLwiuMYeJUGt5mLU26FndO2BetdIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CoBq4X/ytiUZ+0l51aI3Y1BdDXoWW4utuLAfOzMoDMw=; b=LdACtd0pPu6GFRfjr4IlN8OKcYNZIsHIHVhFlzxhxZfUemFo67RfFDuNlsqtaKWD5jcW5ljAiozBh7flCU5alUTWuceme9B582qBSDtFW5kAU8Gvfr0vfchwv3AvBzBAgFVHzDyGvfI9ewG+nDldEaKQPo0rC722txa0xgwShy1mBwFM0ZqArS0HCVRPzXPTEZvreYmtvUe/aj6vKBzFypSLNioWwXci4Q1PL3XHWVxRTQldaA101H2edM+uVWiTzlIWlIKbysiDp9AXAQQgz82VbQ5VrrR2hVO/TYw4wPh2J+brYbYwy1CYJm2/s8GGuzecX0qRuqWr9CWPg9trsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CoBq4X/ytiUZ+0l51aI3Y1BdDXoWW4utuLAfOzMoDMw=; b=CGedJUB5Dw3X8EqHxpm4JSFSuD/JBi60rl8xHgJc4whKjfhvWz7JVNuvxVu9MNQc9gKjhC1He/Lb6rAXEWMO68T4NezCVYf9oSFD4QTfkZMcBhnpxXpQQ0OvJSLS5lbxkNc4q0drTmdrykTwjyI7kxoI97aSUQ5Oh7mkWKOc3aU= From: Rahul Singh To: Ayan Kumar Halder CC: Xen developer discussion , "linux-kernel@vger.kernel.org" , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Samuel Holland , Boris Ostrovsky , Marc Zyngier , Jane Malalane , David Woodhouse Subject: Re: [PATCH] xen/evtchn: Introduce new IOCTL to bind static evtchn Thread-Topic: [PATCH] xen/evtchn: Introduce new IOCTL to bind static evtchn Thread-Index: AQHZec44jeWWxzG+E02fa4Z9QZ57Yq9At36AgAZiAgA= Date: Tue, 2 May 2023 14:58:40 +0000 Message-ID: <116F2F64-6262-4DE3-B9AD-ADE21BD54E41@arm.com> References: <48d30a439e37f6917b9a667289792c2b3f548d6d.1682685294.git.rahul.singh@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7158:EE_|AS8PR08MB9791:EE_|DBAEUR03FT060:EE_|AS8PR08MB7815:EE_ X-MS-Office365-Filtering-Correlation-Id: 8c28ac84-2555-449d-a3d8-08db4b1dbcf3 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: jCSUpN1muS3VQGud2LvUjavYy486L/5e7a7Zk5n6IfmdwKUl/3J696gaflL6/T+AxjGlrYwDlmNIgMKZAGHRBocS435Z/f1x+hFBEdNpea9dU0axn6bdPZc3pIzcuUMjsvIwQlGMAxH2+efs6BUHMAPxV/OteeCYPLPSYbMEqVNLtv+A6g/vUh6UadpRu4gezw6qmu9xSmtd2eA1lpmGPkw4cT/Nf1HVrlY+H2asCLx0CixnMlx6YPWaOs/NkM/Y4f6DwJYBC1ay6xCIo9yijQqntlXYmljKgXYC4yMQzS5FwEUP4xERN11t2b1VU5aUcwEwN+wPF3KMthwUoxyz44+sYiFl7r8QC4VK7h9jMiue4dReIAHFap5nRcEHbqKXXfNjeICLaEb+Ny62XPr3cSDbskFlGGZW1owfn48AWN+CTyJOV4SZr+GBk28kKUwc66KlpP5GrbypZVcYhaAgQDGgKTtktR2aT8EHN3SEflk2+aSNHpzYTfuN7V+lOT0EOrnYnDnb0e/iqu44XpHD6u5Pnrf0eshdq8qxGd70W8S3c0Dv/KGCwggsSdncBPom07O9BlVjJF/qRzAkq8MlK9iMAiPceTvQUGAn8S5EiLWHHeC02Abzxaal5FMBpfiJKW7A4osiHpurPyr20w4VhA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(366004)(136003)(376002)(396003)(346002)(451199021)(54906003)(2616005)(83380400001)(478600001)(53546011)(6486002)(6512007)(26005)(6506007)(71200400001)(66946007)(6916009)(316002)(4326008)(66476007)(66446008)(64756008)(91956017)(186003)(66556008)(76116006)(38070700005)(122000001)(41300700001)(8936002)(5660300002)(7416002)(8676002)(38100700002)(2906002)(33656002)(86362001)(36756003)(45980500001);DIR:OUT;SFP:1101; Content-Type: multipart/alternative; boundary="_000_116F2F6462624DE3B9ADADE21BD54E41armcom_" MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9791 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 33f16859-7e54-42f2-3bf8-08db4b1db775 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 13LNVI5gDYd1TAi7qtXvttmJuVqjU2OE0IrohF0stePDTXU+L5bu9yvWDb+Ya0oSnNDnMwDItDHwstj+4FD51vqF/vmofqUzaqLlIamn9nwwROWU/SgRApVeyC2DwjuL9CX5opx30OuGwdyjQFAApVVmsUeauSfU6EFLAiatPwd7apZh8AlQfqLZhzjTAvPGzecWsSx2CjJG0G0roBkAzIf9wrQoZJ84BLT3PQzpgEaczLZmQ90uKJrAxDHm9PQSOuUbQ62LzWIqM5wt4bp4WogSHDYmbUDiV70X3B9F52lLkTglZiGduOohKip1MI998aaFZBZcVxO4kx7DOB+jtsYqgnsECHQ1lAD7Rr6go1FVfeUGagALw4lJ2Vw7E6N8LIs3nxVfJRla1OqH2Jp7jG/IFCGZDn75XyOehYui3Vp7cRiOpQk7TR6IeIXvSOTYomK1037pJBltk411VqVgiftchadsfbuMkgS6LefghK1VeehkyIwB8w5RvW20sbxquA6qCI/HxGQ8KZ7tS0bw0DGTj/T0pT3iqrNlL6oECLvbW8aO6phluQ5xPWqAf4JEcvYLGZH+ZVQb2mpZoJ/lj44A7LN7rIFYLDf3smxJmr+Y9K7pAGigswZdlsEmzcclX+NtmPVdAuvIRZYWEkwHFPcxwf1I79lqe3FOdmg/ii1vPUDxgJSFB4uYUhiyHVd5+QDEOgFe1wT3HNKeNbptnWPdMLMK4Kr6733oWq7hmjY= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(346002)(136003)(376002)(451199021)(40470700004)(46966006)(36840700001)(5660300002)(40480700001)(40460700003)(86362001)(8936002)(8676002)(6862004)(4326008)(82740400003)(41300700001)(70206006)(70586007)(81166007)(316002)(356005)(2906002)(107886003)(53546011)(26005)(6506007)(6512007)(34020700004)(6486002)(186003)(33964004)(336012)(36860700001)(83380400001)(47076005)(36756003)(33656002)(82310400005)(2616005)(54906003)(478600001)(45080400002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 14:58:49.9119 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8c28ac84-2555-449d-a3d8-08db4b1dbcf3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7815 --_000_116F2F6462624DE3B9ADADE21BD54E41armcom_ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 IEhpIEF5YW4sDQoNCk9uIDI4IEFwciAyMDIzLCBhdCAyOjMwIHBtLCBBeWFuIEt1bWFyIEhhbGRl ciA8YXlhbmt1bWFAYW1kLmNvbT4gd3JvdGU6DQoNCkhpIFJhaHVsLA0KDQpPbiAyOC8wNC8yMDIz IDEzOjM2LCBSYWh1bCBTaW5naCB3cm90ZToNCkNBVVRJT046IFRoaXMgbWVzc2FnZSBoYXMgb3Jp Z2luYXRlZCBmcm9tIGFuIEV4dGVybmFsIFNvdXJjZS4gUGxlYXNlIHVzZSBwcm9wZXIganVkZ21l bnQgYW5kIGNhdXRpb24gd2hlbiBvcGVuaW5nIGF0dGFjaG1lbnRzLCBjbGlja2luZyBsaW5rcywg b3IgcmVzcG9uZGluZyB0byB0aGlzIGVtYWlsLg0KDQoNClhlbiA0LjE3IHN1cHBvcnRzIHRoZSBj cmVhdGlvbiBvZiBzdGF0aWMgZXZ0Y2hucy4gVG8gYWxsb3cgdXNlciBzcGFjZQ0KYXBwbGljYXRp b24gdG8gYmluZCBzdGF0aWMgZXZ0Y2hucyBpbnRyb2R1Y2UgbmV3IGlvY3RsDQoiSU9DVExfRVZU Q0hOX0JJTkRfU1RBVElDIi4gRXhpc3RpbmcgSU9DVEwgZG9pbmcgbW9yZSB0aGFuIGJpbmRpbmcN CnRoYXTigJlzIHdoeSB3ZSBuZWVkIHRvIGludHJvZHVjZSB0aGUgbmV3IElPQ1RMIHRvIG9ubHkg YmluZCB0aGUgc3RhdGljDQpldmVudCBjaGFubmVscy4NCg0KQWxzbywgc3RhdGljIGV2dGNobnMg dG8gYmUgYXZhaWxhYmxlIGZvciB1c2UgZHVyaW5nIHRoZSBsaWZldGltZSBvZiB0aGUNCmd1ZXN0 LiBXaGVuIHRoZSBhcHBsaWNhdGlvbiBleGl0cywgX191bmJpbmRfZnJvbV9pcnEoKSBlbmQgdXAN CmJlaW5nIGNhbGxlZCBmcm9tIHJlbGVhc2UoKSBmb3AgYmVjYXVzZSBvZiB0aGF0IHN0YXRpYyBl dnRjaG5zIGFyZQ0KZ2V0dGluZyBjbG9zZWQuIFRvIGF2b2lkIGNsb3NpbmcgdGhlIHN0YXRpYyBl dmVudCBjaGFubmVsLCBhZGQgdGhlIG5ldw0KYm9vbCB2YXJpYWJsZSAiaXNfc3RhdGljIiBpbiAi c3RydWN0IGlycV9pbmZvIiB0byBtYXJrIHRoZSBldmVudCBjaGFubmVsDQpzdGF0aWMgd2hlbiBj cmVhdGluZyB0aGUgZXZlbnQgY2hhbm5lbCB0byBhdm9pZCBjbG9zaW5nIHRoZSBzdGF0aWMNCmV2 dGNobi4NCg0KU2lnbmVkLW9mZi1ieTogUmFodWwgU2luZ2ggPHJhaHVsLnNpbmdoQGFybS5jb20+ DQotLS0NCiBkcml2ZXJzL3hlbi9ldmVudHMvZXZlbnRzX2Jhc2UuYyB8ICA3ICsrKysrLS0NCiBk cml2ZXJzL3hlbi9ldnRjaG4uYyAgICAgICAgICAgICB8IDIyICsrKysrKysrKysrKysrKysrLS0t LS0NCiBpbmNsdWRlL3VhcGkveGVuL2V2dGNobi5oICAgICAgICB8ICA5ICsrKysrKysrKw0KIGlu Y2x1ZGUveGVuL2V2ZW50cy5oICAgICAgICAgICAgIHwgIDIgKy0NCiA0IGZpbGVzIGNoYW5nZWQs IDMyIGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pDQoNCmRpZmYgLS1naXQgYS9kcml2ZXJz L3hlbi9ldmVudHMvZXZlbnRzX2Jhc2UuYyBiL2RyaXZlcnMveGVuL2V2ZW50cy9ldmVudHNfYmFz ZS5jDQppbmRleCBjNzcxNWY4YmQ0NTIuLjMxZjJkMzYzNGFkNSAxMDA2NDQNCi0tLSBhL2RyaXZl cnMveGVuL2V2ZW50cy9ldmVudHNfYmFzZS5jDQorKysgYi9kcml2ZXJzL3hlbi9ldmVudHMvZXZl bnRzX2Jhc2UuYw0KQEAgLTExMiw2ICsxMTIsNyBAQCBzdHJ1Y3QgaXJxX2luZm8gew0KICAgICAg ICB1bnNpZ25lZCBpbnQgaXJxX2Vwb2NoOyAvKiBJZiBlb2lfY3B1IHZhbGlkOiBpcnFfZXBvY2gg b2YgZXZlbnQgKi8NCiAgICAgICAgdTY0IGVvaV90aW1lOyAgICAgICAgICAgLyogVGltZSBpbiBq aWZmaWVzIHdoZW4gdG8gRU9JLiAqLw0KICAgICAgICByYXdfc3BpbmxvY2tfdCBsb2NrOw0KKyAg ICAgICB1OCBpc19zdGF0aWM7ICAgICAgICAgICAvKiBJcyBldmVudCBjaGFubmVsIHN0YXRpYyAq Lw0KDQpJIHRoaW5rIHdlIHNob3VsZCBhdm9pZCB1OC91MTYvdTMyIGFuZCBpbnN0ZWFkIHVzZSB1 aW50OF90L3VpbnQxNl90L3VpbnQzMl90Lg0KDQpIb3dldmVyIGluIHRoaXMgY2FzZSwgeW91IGNh biB1c2UgYm9vbC4NCg0KTWFrZSBzZW5zZS4gSSB3aWxsIGNoYW5nZSB0byBib29sIGluIG5leHQg cGF0Y2guDQoNClJlZ2FyZHMsDQpSYWh1bA0KDQo= --_000_116F2F6462624DE3B9ADADE21BD54E41armcom_ Content-Type: text/html; charset="utf-8" Content-ID: <2BFC176F7B3B424D9CEA0E18D6C59CC0@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 PGh0bWw+DQo8aGVhZD4NCjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0i dGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4NCjwvaGVhZD4NCjxib2R5IHN0eWxlPSJvdmVyZmxv dy13cmFwOiBicmVhay13b3JkOyAtd2Via2l0LW5ic3AtbW9kZTogc3BhY2U7IGxpbmUtYnJlYWs6 IGFmdGVyLXdoaXRlLXNwYWNlOyI+DQombmJzcDtIaSBBeWFuLDxicj4NCjxkaXY+PGJyPg0KPGJs b2NrcXVvdGUgdHlwZT0iY2l0ZSI+DQo8ZGl2Pk9uIDI4IEFwciAyMDIzLCBhdCAyOjMwIHBtLCBB eWFuIEt1bWFyIEhhbGRlciAmbHQ7YXlhbmt1bWFAYW1kLmNvbSZndDsgd3JvdGU6PC9kaXY+DQo8 YnIgY2xhc3M9IkFwcGxlLWludGVyY2hhbmdlLW5ld2xpbmUiPg0KPGRpdj48c3BhbiBzdHlsZT0i Y2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IEhlbHZldGljYTsgZm9udC1z aXplOiAxMnB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7 IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0 YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6 IG5vcm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBw eDsgdGV4dC1kZWNvcmF0aW9uOiBub25lOyBmbG9hdDogbm9uZTsgZGlzcGxheTogaW5saW5lICFp bXBvcnRhbnQ7Ij5IaQ0KIFJhaHVsLDwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2Io MCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBIZWx2ZXRpY2E7IGZvbnQtc2l6ZTogMTJweDsgZm9udC1z dHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAw OyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6 IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3Bh Y2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlv bjogbm9uZTsiPg0KPGJyIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZh bWlseTogSGVsdmV0aWNhOyBmb250LXNpemU6IDEycHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9u dC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6 IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNm b3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtp dC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7Ij4NCjxzcGFu IHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseTogSGVsdmV0aWNh OyBmb250LXNpemU6IDEycHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6 IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1h bGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0 ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13 aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBp bmxpbmUgIWltcG9ydGFudDsiPk9uDQogMjgvMDQvMjAyMyAxMzozNiwgUmFodWwgU2luZ2ggd3Jv dGU6PC9zcGFuPjxiciBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1p bHk6IEhlbHZldGljYTsgZm9udC1zaXplOiAxMnB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQt dmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBu b3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9y bTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQt dGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0aW9uOiBub25lOyI+DQo8YmxvY2tx dW90ZSB0eXBlPSJjaXRlIiBzdHlsZT0iZm9udC1mYW1pbHk6IEhlbHZldGljYTsgZm9udC1zaXpl OiAxMnB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZv bnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IG9ycGhhbnM6IGF1dG87IHRl eHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsg d2hpdGUtc3BhY2U6IG5vcm1hbDsgd2lkb3dzOiBhdXRvOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdl YmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7Ij4NCkNB VVRJT046IFRoaXMgbWVzc2FnZSBoYXMgb3JpZ2luYXRlZCBmcm9tIGFuIEV4dGVybmFsIFNvdXJj ZS4gUGxlYXNlIHVzZSBwcm9wZXIganVkZ21lbnQgYW5kIGNhdXRpb24gd2hlbiBvcGVuaW5nIGF0 dGFjaG1lbnRzLCBjbGlja2luZyBsaW5rcywgb3IgcmVzcG9uZGluZyB0byB0aGlzIGVtYWlsLjxi cj4NCjxicj4NCjxicj4NClhlbiA0LjE3IHN1cHBvcnRzIHRoZSBjcmVhdGlvbiBvZiBzdGF0aWMg ZXZ0Y2hucy4gVG8gYWxsb3cgdXNlciBzcGFjZTxicj4NCmFwcGxpY2F0aW9uIHRvIGJpbmQgc3Rh dGljIGV2dGNobnMgaW50cm9kdWNlIG5ldyBpb2N0bDxicj4NCiZxdW90O0lPQ1RMX0VWVENITl9C SU5EX1NUQVRJQyZxdW90Oy4gRXhpc3RpbmcgSU9DVEwgZG9pbmcgbW9yZSB0aGFuIGJpbmRpbmc8 YnI+DQp0aGF04oCZcyB3aHkgd2UgbmVlZCB0byBpbnRyb2R1Y2UgdGhlIG5ldyBJT0NUTCB0byBv bmx5IGJpbmQgdGhlIHN0YXRpYzxicj4NCmV2ZW50IGNoYW5uZWxzLjxicj4NCjxicj4NCkFsc28s IHN0YXRpYyBldnRjaG5zIHRvIGJlIGF2YWlsYWJsZSBmb3IgdXNlIGR1cmluZyB0aGUgbGlmZXRp bWUgb2YgdGhlPGJyPg0KZ3Vlc3QuIFdoZW4gdGhlIGFwcGxpY2F0aW9uIGV4aXRzLCBfX3VuYmlu ZF9mcm9tX2lycSgpIGVuZCB1cDxicj4NCmJlaW5nIGNhbGxlZCBmcm9tIHJlbGVhc2UoKSBmb3Ag YmVjYXVzZSBvZiB0aGF0IHN0YXRpYyBldnRjaG5zIGFyZTxicj4NCmdldHRpbmcgY2xvc2VkLiBU byBhdm9pZCBjbG9zaW5nIHRoZSBzdGF0aWMgZXZlbnQgY2hhbm5lbCwgYWRkIHRoZSBuZXc8YnI+ DQpib29sIHZhcmlhYmxlICZxdW90O2lzX3N0YXRpYyZxdW90OyBpbiAmcXVvdDtzdHJ1Y3QgaXJx X2luZm8mcXVvdDsgdG8gbWFyayB0aGUgZXZlbnQgY2hhbm5lbDxicj4NCnN0YXRpYyB3aGVuIGNy ZWF0aW5nIHRoZSBldmVudCBjaGFubmVsIHRvIGF2b2lkIGNsb3NpbmcgdGhlIHN0YXRpYzxicj4N CmV2dGNobi48YnI+DQo8YnI+DQpTaWduZWQtb2ZmLWJ5OiBSYWh1bCBTaW5naCAmbHQ7cmFodWwu c2luZ2hAYXJtLmNvbSZndDs8YnI+DQotLS08YnI+DQombmJzcDtkcml2ZXJzL3hlbi9ldmVudHMv ZXZlbnRzX2Jhc2UuYyB8ICZuYnNwOzcgKysrKystLTxicj4NCiZuYnNwO2RyaXZlcnMveGVuL2V2 dGNobi5jICZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZu YnNwOyZuYnNwOyZuYnNwOyZuYnNwO3wgMjIgKysrKysrKysrKysrKysrKystLS0tLTxicj4NCiZu YnNwO2luY2x1ZGUvdWFwaS94ZW4vZXZ0Y2huLmggJm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5i c3A7Jm5ic3A7Jm5ic3A7fCAmbmJzcDs5ICsrKysrKysrKzxicj4NCiZuYnNwO2luY2x1ZGUveGVu L2V2ZW50cy5oICZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNw OyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwO3wgJm5ic3A7MiArLTxicj4NCiZuYnNwOzQgZmlsZXMg Y2hhbmdlZCwgMzIgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSk8YnI+DQo8YnI+DQpkaWZm IC0tZ2l0IGEvZHJpdmVycy94ZW4vZXZlbnRzL2V2ZW50c19iYXNlLmMgYi9kcml2ZXJzL3hlbi9l dmVudHMvZXZlbnRzX2Jhc2UuYzxicj4NCmluZGV4IGM3NzE1ZjhiZDQ1Mi4uMzFmMmQzNjM0YWQ1 IDEwMDY0NDxicj4NCi0tLSBhL2RyaXZlcnMveGVuL2V2ZW50cy9ldmVudHNfYmFzZS5jPGJyPg0K KysrIGIvZHJpdmVycy94ZW4vZXZlbnRzL2V2ZW50c19iYXNlLmM8YnI+DQpAQCAtMTEyLDYgKzEx Miw3IEBAIHN0cnVjdCBpcnFfaW5mbyB7PGJyPg0KJm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5i c3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7dW5zaWduZWQgaW50IGlycV9lcG9jaDsgLyogSWYgZW9pX2Nw dSB2YWxpZDogaXJxX2Vwb2NoIG9mIGV2ZW50ICovPGJyPg0KJm5ic3A7Jm5ic3A7Jm5ic3A7Jm5i c3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7dTY0IGVvaV90aW1lOyAmbmJzcDsmbmJzcDsmbmJz cDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsvKiBUaW1lIGluIGpp ZmZpZXMgd2hlbiB0byBFT0kuICovPGJyPg0KJm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7 Jm5ic3A7Jm5ic3A7Jm5ic3A7cmF3X3NwaW5sb2NrX3QgbG9jazs8YnI+DQorICZuYnNwOyZuYnNw OyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwO3U4IGlzX3N0YXRpYzsgJm5ic3A7Jm5ic3A7Jm5ic3A7 Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7LyogSXMgZXZlbnQgY2hh bm5lbCBzdGF0aWMgKi88YnI+DQo8L2Jsb2NrcXVvdGU+DQo8YnIgc3R5bGU9ImNhcmV0LWNvbG9y OiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBIZWx2ZXRpY2E7IGZvbnQtc2l6ZTogMTJweDsg Zm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdo dDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1p bmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdv cmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVj b3JhdGlvbjogbm9uZTsiPg0KPHNwYW4gc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7 IGZvbnQtZmFtaWx5OiBIZWx2ZXRpY2E7IGZvbnQtc2l6ZTogMTJweDsgZm9udC1zdHlsZTogbm9y bWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXIt c3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4 dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4 OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsg ZmxvYXQ6IG5vbmU7IGRpc3BsYXk6IGlubGluZSAhaW1wb3J0YW50OyI+SQ0KIHRoaW5rIHdlIHNo b3VsZCBhdm9pZCB1OC91MTYvdTMyIGFuZCBpbnN0ZWFkIHVzZSB1aW50OF90L3VpbnQxNl90L3Vp bnQzMl90Ljwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQt ZmFtaWx5OiBIZWx2ZXRpY2E7IGZvbnQtc2l6ZTogMTJweDsgZm9udC1zdHlsZTogbm9ybWFsOyBm b250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2lu Zzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFu c2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Vi a2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsiPg0KPGJy IHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseTogSGVsdmV0aWNh OyBmb250LXNpemU6IDEycHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6 IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1h bGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0 ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13 aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7Ij4NCjxzcGFuIHN0eWxlPSJjYXJldC1j b2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseTogSGVsdmV0aWNhOyBmb250LXNpemU6IDEy cHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13 ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRl eHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFs OyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0 LWRlY29yYXRpb246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUgIWltcG9ydGFu dDsiPkhvd2V2ZXINCiBpbiB0aGlzIGNhc2UsIHlvdSBjYW4gdXNlIGJvb2wuPC9zcGFuPjxiciBz dHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IEhlbHZldGljYTsg Zm9udC1zaXplOiAxMnB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBu b3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxp Z246IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUt c3BhY2U6IG5vcm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lk dGg6IDBweDsgdGV4dC1kZWNvcmF0aW9uOiBub25lOyI+DQo8L2Rpdj4NCjwvYmxvY2txdW90ZT4N CjxkaXY+PGJyPg0KPC9kaXY+DQpNYWtlIHNlbnNlLiBJIHdpbGwgY2hhbmdlIHRvIGJvb2wgaW4g bmV4dCBwYXRjaC48L2Rpdj4NCjxkaXY+PGJyPg0KPC9kaXY+DQo8ZGl2PlJlZ2FyZHMsPC9kaXY+ DQo8ZGl2PlJhaHVsPGJyPg0KPC9kaXY+DQo8YnI+DQo8L2JvZHk+DQo8L2h0bWw+DQo= --_000_116F2F6462624DE3B9ADADE21BD54E41armcom_-- From xen-devel-bounces@lists.xenproject.org Tue May 02 15:00:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 15:00:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528703.822185 (Exim 4.92) (envelope-from ) id 1ptrUf-0008WM-1g; Tue, 02 May 2023 15:00:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528703.822185; Tue, 02 May 2023 15:00:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptrUe-0008WF-Uv; Tue, 02 May 2023 15:00:40 +0000 Received: by outflank-mailman (input) for mailman id 528703; Tue, 02 May 2023 15:00:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptrUd-0008W9-BS for xen-devel@lists.xenproject.org; Tue, 02 May 2023 15:00:39 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1859a13a-e8fa-11ed-b225-6b7b168915f2; Tue, 02 May 2023 17:00:38 +0200 (CEST) Received: from mail-mw2nam10lp2104.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.104]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2023 10:59:38 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by SJ0PR03MB6422.namprd03.prod.outlook.com (2603:10b6:a03:396::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.27; Tue, 2 May 2023 14:59:36 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec%3]) with mapi id 15.20.6340.031; Tue, 2 May 2023 14:59:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1859a13a-e8fa-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683039638; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=+/IIFwM9mnWmeO4C0VHoB/T3RUCbmQJsbpPxY0Jwn8s=; b=K+DS8ZHoYp6DDybyjkg8ZSqwZ99yL5MHBazHsL/qV/CBrlUzmbOpABlL gBH7w0ySIRJR0WbzKQvY4EKhnl4LNxyklIZ6pZXAnG/sVHpNPYR5I1wQ8 X8BQTQCdnmt0BwPgWj40UgSjf8t7Q8dO26QTgK4RZpMRCY23Yao4+wORL M=; X-IronPort-RemoteIP: 104.47.55.104 X-IronPort-MID: 106348824 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:kFtgX64nnShQk6lwj2MnBgxRtBjGchMFZxGqfqrLsTDasY5as4F+v mIfCG+HM/uNamPweYggaI6z9UwH7ceAxtFgSAA4qCk8Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+7ZwehBtC5gZlPa0T5geE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5mt sAHOis3NUm5p9mb6r+ZdPBSuZwjFZy+VG8fkikIITDxK98DGMiGZpqQoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OkUooiOSF3Nn9I7RmQe1PmUmVv CTe9nnRCRAGLt2PjzGC9xpAg8eWxX2gBNJCTuHQGvhCukK+lisRNj8taBiFnumV0HGXX4tDJ BlBksYphe1onKCxdfHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpQN4sudIyRDcq/ kSUhN6vDjtq2JWKTVqN+7HSqim9URX5NkcHbC4ACA4aud/qpdhrigqVF44/VqmoktfyBDf8h SiQqzQzjKkSishN0Lin+VfAgHSnoZ2hohMJ2zg7l1mNtmtRDLNJraTxtwWzASpoRGpBcmS8g Q== IronPort-HdrOrdr: A9a23:LIa61q+QX2xnH6lGeZRuk+G/dr1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqN03IV+rwWpVoJkmsj6KdgLNhRotKOTOLhILGFvAH0WKP+V3d8mjFh5dgPM RbAtdD4aPLfD9HZK/BiWHXcurIguP3iJxA7d2us0uFJjsaDp2IgT0JaTpyRSZNNXR77NcCZd OhDo0tnUvSRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirCWekD+y77b+Mh6AmjMTSSlGz7sO+X XM11WR3NTvj9iLjjvnk0PD5ZVfn9XsjvNFGcy3k8AQbhn8lwqyY4xlerua+BQ4uvum5loGmM TF5z0gI8NwwXXMeXzdm2qm5yDQlBIVr1Pyw16RhnXu5eT/WTIBEsJEwaZUaAHQ5UYMtMx1lP sj5RPTi7NnSTf72Ajt7dnBUB9n0mKyvHoZiOYWy1hSS5EXZrN9pZEWuGlVDJADNiTn751PKp gnMOjsoNJtNX+KZXHQuWdihPSqQ3QIBx+DBnMPv8SEugIm6ExR/g89/ogyj30A/JUyR91v/O LfKJllk7lIU4s/cb99LP1pe7r3NkX9BTb3dE6CK1XuE68Kf1jXrYTs3bkz7Oa2PLQV0ZoJno jbWl8wjx99R6vXM7zM4HR3yGGOfI3kNg6dj/22pqIJ9YEUfYCbcRFqEzsV4o+dS/Z2OLyvZx /8AuMQPxbZFxqfJW945XyBZ3BsEwhubCRsgKdcZ7uvmLO9FmS4jJ2sTN/jYJzQLB0DZkTTRl M+YRmbHrQz0qnsYA61vCTs X-Talos-CUID: 9a23:SNOc2GGd6PwXxL/KqmIkyFEGAfp+K0f991r6Lm2GEFhWEL2sHAo= X-Talos-MUID: =?us-ascii?q?9a23=3Ab56vpQzNBWCfRjotdy5cuSO+nwSaqJ6xJRBKk6s?= =?us-ascii?q?kgPTHCxNgF22ipTDuXoByfw=3D=3D?= X-IronPort-AV: E=Sophos;i="5.99,244,1677560400"; d="scan'208";a="106348824" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UbwtbursVbivaWSRocTQd0LWVyUWKuLyvPfQVNEviZ6tSY6nT+/kH5mJeb0qXZX5RLXPdIFsUULjMnxQIZ7WXr0LamjxGdt3KDVfAH7kEhWgm0nOXE1+zknbftxwRn9vEXDhAo+yYHpX1ZlrOkgSo0bPKsQ+DcoGi9mWCF9mbcABrdLUSi8MUtp955nkqN0vxWB5iQ7lqydQUiLNybGZ7lUN7WWwb5TJtJQdrgjmWwqWj46fHdWUhD7kLOybNdgJS5kqACiwo/ofOMEn4EHo2mh8C8CV4HlJqIFkbmdmfgpqZVF/u217myAxVwkOGe037NSBnx8QF7dIO2jfqYlTRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UN0wmpmoxxOBfT7pEjwKaFozddVpe6jQy1KrqXoAqWg=; b=KVR4zCHGoqwdPbQgxyo4P7iflX9oP+UT/8atSEFBpJSeN+SpdrqgxDrMOL/p5isydOvxBTKaRRLuXBgG/KPYMBOemcglpSZoSP9OsOMM4P+uzzPTvCyGRb3dZAFQ9IPhYDpjkcrZVovLgRk5gUeoDvstuaP7W68COEOr6UjUMrWwiHyBi4KBmONdU0uD9vJGRcIVVDsPhmAehZH/t8G92ynOfce7kp1Ftip7EMjfPz2gbsl+Dkcy67Hjz1CCF6Yb17i+C9CeXOyn84GpA0VxEgGtch9vrOG4P4QqoIGysgttzDYurs46Vjd07WKX7zPVohFtLTqGPzzAgXbOJJbjkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UN0wmpmoxxOBfT7pEjwKaFozddVpe6jQy1KrqXoAqWg=; b=KTEO/NvQDZtTb5IP+/TG4/YmiGxP8SVAs/Mqh/etOL/PIp/ZoWrhO7aCnUjElg39U7MCxSjxd4uEl68cNKC84ZmX5jLmAYgwAdpKhG+kbmHqvWqd75y4LE48Xss+1BLniu1NoNZHfKaVLcQ48HGP5nUstyvRFGf+vgC9K+FsUtU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH v2 1/2] x86/head: check base address alignment Date: Tue, 2 May 2023 16:59:19 +0200 Message-Id: <20230502145920.56588-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230502145920.56588-1-roger.pau@citrix.com> References: <20230502145920.56588-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0033.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:151::20) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|SJ0PR03MB6422:EE_ X-MS-Office365-Filtering-Correlation-Id: cf9cb7df-081e-4749-bdf3-08db4b1dd84f X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: znNSzi0YaNR+2YRay7gLbnh3QPiNRcEiwCY1djwkr9c6rmmRlUFKznkRLTXZHYr7Ws/ENDA6ho/qC8IKOsJe+l7tl96oeiL+mBZ+b8Bm+YYYB9m8s12NGQdZaF8lna1pB8h2oklMxkizh34BE9EZcxrppTjWytJJBZpIrJ5EV7qzfrhvWcZlYan2Q7jwuzw8+qqdUj9rFveypsaC/TSKCvhkNR9Mq9SIBN59IT2Lbbi0bKBBq02V7vWIG8Ywli8vF4zkJwa8RFrB4a5d2ALoOH8uMMIfImJCNdsLxyfAatu5Tx3gqq9ERj4fx19JhzZbtRAkD1FWFwLkttPbQ6VIuwgw8Kxjlb3wrn4MmmbhHXKEbKZ9y3NAEAxl5mbpxEYBp5NCYRZgSIkUu5Wenljf1YQysitzgNYIVgCuwLfhPebkgVyDpAIqbT50j9ydHEsPoWOdlThMtal10ErAnONo2BvIIuHN7Dd1wAQW9mxtLMUvi5kvJJ/BPT/B6cCwrKj+8T7DB9+G23a16L6zAVFU1f8juWUE41lZHcWZEUsdYGqXbuzKXK7AwVVvIu312Z3j X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(136003)(346002)(39860400002)(396003)(366004)(451199021)(2616005)(83380400001)(478600001)(186003)(54906003)(4326008)(6916009)(66476007)(66556008)(66946007)(6486002)(6666004)(6512007)(1076003)(6506007)(26005)(316002)(8936002)(8676002)(5660300002)(41300700001)(82960400001)(2906002)(38100700002)(86362001)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NEV4VUJyMVMwWHUyWnQ1elJXbWJQZlR0eitZbWo0SVVsOUMzTE1qaWRwL0I1?= =?utf-8?B?bVdvUTF1TFRpcWwwb3FqMjNBZ1VjOWd4MEVhd2hueFB6SkpCVVpPaVFkUVA4?= =?utf-8?B?YjdwWlJtcTBhV1UrSm9VQ29DNHI4YUQwaWpxTDV1Z0I2QWZ5RlRRZUlwSlpH?= =?utf-8?B?RzZCTU05YUdINlhGOFBtV3lkZDJXYUFYU0ZoZy8vVjh1ZlVLMGNya1lSNjVF?= =?utf-8?B?eXRpcG5HVUY5b3liWDd1VmUwbVVZTEpkVUltbURMdVBrNXJZZVJxWG1kbmxG?= =?utf-8?B?Nk9uZ2NRdXk5NzhrbWlRNDdHeTMzaVRENHp3NWwwMUttUzdLNzhaZzM5VjRD?= =?utf-8?B?NnB0VEhFMi9MTmJoYXlVbXorYnp1NnEwUmpuL1BUaEx4VlBNeFBDMThUaGts?= =?utf-8?B?OU52dldkOG9tdVB4eUdRUWtlSWdtV29TTXA3Q1hSY0dURjVYN0dGb2oxc1p3?= =?utf-8?B?dmpaVEg0SkZ1Vko3a2UwY2hITmFSRENIcjlCRGJ1WmlwQTVvdjAxc0FCZ2pk?= =?utf-8?B?SzEwRWVJYU1KUElWZ2N0aGo0VitrRVAyMkJOcFZ4dHJNNjNKTitYenYrbWtn?= =?utf-8?B?QXBsMUhKVUFpS0xRcWhHUmRNbzg3a055RVJJN2djZVBqM0FsUjJ0UUFLNnBh?= =?utf-8?B?ZU0zTG1NYyt4clVTOUlPZFptSUtOTnVpMTJmM3dUOVlCcnE2Q3R0YkNCemp0?= =?utf-8?B?OE9YenB0UitvWjI2azVkTWkzT0g0U3g1U2E2NzNEU2taSWxLY0lDa0dTZVZx?= =?utf-8?B?YzVMU3lXYTArK3lTc0k0ZFBPb3J4VDJHNnoyMVZRTmR2NjBmVllRSUgrSC9P?= =?utf-8?B?OTFBeWZQRWdkMjVyRlp4K25LT255ZGZLckFEcXM4M0ttNS8yV1dpME0weUZh?= =?utf-8?B?b0ZOWGk5eU1Id0p2V1BYbGF6TDRRUXV4RVlETW9zK3p0aGJDU0FzSFpFYXNM?= =?utf-8?B?SVN0ZlJ0UElWcWhxKzFoZ2VLaGh0ekJ5eVl3THVMWjBYb2p3SG05OE9zanVa?= =?utf-8?B?cGpmdmFVMWZMRkhrbjR0a09iVTlyYVpDMGtiNG5wdEZDMlFZR2dOR04vZSt1?= =?utf-8?B?T3czS0s1SEQzN2FrckJCczNHMy9VdjdIYmVtUnluOW5rQmpmS3Z3dVFqb2k5?= =?utf-8?B?SEpXZ1FRdlJjWS9uUGFCeE41VXZHVXdBQjZCc0FVd3ZCa2pDSW9VK1VBWlNw?= =?utf-8?B?VkdQclNmVGZLNGJLNm5VeFppWWR3QlBhSDU2SlQ1TGd5N3VpSlVzQ21UeERK?= =?utf-8?B?dHZqb0xwMmlyL0tVNVRxQjZWV2FNTVVlZHliYTBHWUZ2VTl1YSs5Rlc3cWNr?= =?utf-8?B?YWRlaUpXS1AzSXVmVjVlSUpINk5JOTJUdlBXc254U3BMOHBUUGhVYTNXaStY?= =?utf-8?B?dkFnL2xLcStJV2FuZk5TZFd3VnI1dW9wbEZZcm02R3h1Vm82ZmQrTDEvbHlB?= =?utf-8?B?T1BPeGdDSFBsejM2QXU2N0ZmVXJ5dlp3WUZyS1FWWVJRLzcrSHJZS0Y5YUhq?= =?utf-8?B?Q0FOaTJlZk1qU3ZaU2hoaVRmejNCdTdpUjY4OTBsVTQ5cHE3TTJRNDJzdWQx?= =?utf-8?B?aUh5VVN6SlJ1SFIwdWg5SkZyWURBSXIrRG5qRys4Y0JBRUdtVmdHVjBXNXJv?= =?utf-8?B?dU5sM2lqN1F3ZU5FT0ZUakdMSE9EMjVXOVcxcGJienRwMWk2N1hZcEFzRHN3?= =?utf-8?B?ZmdmSDBuOXVHTE5nWjlhbkxWclNGWDFySnphK1N2T3hkUC84S21zUmhTdEkx?= =?utf-8?B?d0k4d3kwU1hwUGdrZXppT0dSdlNQMVBlYXhHcWZTYkszQ0ovcmpvWFFPaWdC?= =?utf-8?B?WFFoTHRaditZMlpLQ0IrNFRRSHJsNERnendNTEkxZThZTWJZMHMzRlcyNWZl?= =?utf-8?B?bkRNVnNibWI2bnYwMloyMnN0by9qNFZWaXJMYzFNTWtjU0RYeEdUUElnakR5?= =?utf-8?B?OWpmNzBsU1QvMTUvWjZOZ2kzZ1NMN2FzZVpJdzA2SkpIcHF3bG1hd0ZVVjJa?= =?utf-8?B?cThGblVEZ1FPRWxvdytpMzZVVG1oMUhzd2hiNkZTM1RpQWlZRlUzWGp5UEZI?= =?utf-8?B?aGdTZnh2WFlOQ2twNWpUSjFDdmQ3UUluYmx5QzNhY3d2b1k3U0RzZG1hc1p0?= =?utf-8?B?c2dZdjJ3YVVUNnFOWmpQS0pPUlRJNDRPajA2YkJjQU42RDR6eStUeDNqaXRB?= =?utf-8?B?Z2c9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 1jYcfwCL3Xf/ZX7ZhOwangIto81AOQzK7G2EiUX4xfKqpXh09udMo1FPr6HrqukmQ22QI3Cj1sos4uZSwardb27UnPvwvWYOuk3qdWFUPeeZCi5WONONOL3VgW5YWvCnlZwZ2wjfxa+8dRGMabJHFTY/6uBmNy7KUe1HGSpjWon0MmRPe8oebHvcNR8Po1ikebjWqzd9KZ0kWpkjay1pZazNh2jOFGdSTaSQnZbCQpxayvx0c1rux7RIQof2piB9APEl+nVC99NO+m54FmRY+dtq/O5nJ6vnNT5O8QtmjahdV/S05cynI4RzTu/JSd0NGx3ajTxfwaSPS9EDXozqPrR9yG/BOX+ffkRX42+9UrGajTQUyRPtzMbeCRhkw6/Wxcxrl3fcyPmWkBDsTu0uOGYF/pcvIAuZTCIZQYTY35GROR39655zEGYTwhs9+z0mL1RTsTiF8jIHxx1hs1Ylh9cUZ+fzNAPnJQ9cGuuNX19aSLfZjsCrdmt+D5c7ygYgqyEbiScPIwbsgp9jenSapYgv0+TNjHwPJuUldGUCAcpX/sKHIgzlGGrinRU9BXr/QmPXlDSBy+XqKlYnT6748wDF7ckzwR1zoVlC2ddj1sy7mb23V4TRLfJT4QBDcnIWtlmOz/Sa00ArLz92EdzBJH6bSKjaxBbEeYQPnMNLSlT1vo7zekjQUMNpgm2zoGp8++ngNF423sQG68S2/to3LvCoBRkBpMaxPSYwSuiezO1n+dqE7c7gK7+6aGPII+DPZG2X6RZRdiCeKMjwGk+5NQV6upRYLoLYhNXJ3nBJCA3iE4ZNwzh2yOu4v1N5vX1M X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf9cb7df-081e-4749-bdf3-08db4b1dd84f X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 14:59:36.0102 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CS2arztY9VNnVnduuTDlLji6U7vS7RZbsvczys27UrhDF/XImIj6fUXNrieAxft+Xi/epUqhYf5J1S9Y0DsYOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6422 Ensure that the base address is 2M aligned, or else the page table entries created would be corrupt as reserved bits on the PDE end up set. We have encountered a broken firmware where grub2 would end up loading Xen at a non 2M aligned region when using the multiboot2 protocol, and that caused a very difficult to debug triple fault. If the alignment is not as required by the page tables print an error message and stop the boot. Also add a build time check that the calculation of symbol offsets don't break alignment of passed addresses. The check could be performed earlier, but so far the alignment is required by the page tables, and hence feels more natural that the check lives near to the piece of code that requires it. Note that when booted as an EFI application from the PE entry point the alignment check is already performed by efi_arch_load_addr_check(), and hence there's no need to add another check at the point where page tables get built in efi_arch_memory_setup(). Signed-off-by: Roger Pau Monné --- Changes since v1: - Use test instead of and instruction. - Add a build time check for sym_offs correctness. - Reword part of the commit message. --- xen/arch/x86/boot/head.S | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S index 0fb7dd3029f2..b9c9447df9df 100644 --- a/xen/arch/x86/boot/head.S +++ b/xen/arch/x86/boot/head.S @@ -1,3 +1,4 @@ +#include #include #include #include @@ -121,6 +122,7 @@ multiboot2_header: .Lbad_ldr_nst: .asciz "ERR: EFI SystemTable is not provided by bootloader!" .Lbad_ldr_nih: .asciz "ERR: EFI ImageHandle is not provided by bootloader!" .Lbad_efi_msg: .asciz "ERR: EFI IA-32 platforms are not supported!" +.Lbag_alg_msg: .asciz "ERR: Xen must be loaded at a 2Mb boundary!" .section .init.data, "aw", @progbits .align 4 @@ -146,6 +148,9 @@ bad_cpu: not_multiboot: add $sym_offs(.Lbad_ldr_msg),%esi # Error message jmp .Lget_vtb +not_aligned: + add $sym_offs(.Lbag_alg_msg),%esi # Error message + jmp .Lget_vtb .Lmb2_no_st: /* * Here we are on EFI platform. vga_text_buffer was zapped earlier @@ -670,6 +675,15 @@ trampoline_setup: cmp %edi, %eax jb 1b + .if !IS_ALIGNED(sym_offs(0), 1 << L2_PAGETABLE_SHIFT) + .error "Symbol offset calculation breaks alignment" + .endif + + /* Check that the image base is aligned. */ + lea sym_esi(_start), %eax + test $(1 << L2_PAGETABLE_SHIFT) - 1, %eax + jnz not_aligned + /* Map Xen into the higher mappings using 2M superpages. */ lea _PAGE_PSE + PAGE_HYPERVISOR_RWX + sym_esi(_start), %eax mov $sym_offs(_start), %ecx /* %eax = PTE to write ^ */ -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Tue May 02 15:02:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 15:02:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528708.822195 (Exim 4.92) (envelope-from ) id 1ptrWF-0000eY-CN; Tue, 02 May 2023 15:02:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528708.822195; Tue, 02 May 2023 15:02:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptrWF-0000eP-9W; Tue, 02 May 2023 15:02:19 +0000 Received: by outflank-mailman (input) for mailman id 528708; Tue, 02 May 2023 15:02:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptrWD-0000eD-G4 for xen-devel@lists.xenproject.org; Tue, 02 May 2023 15:02:17 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 51e990ee-e8fa-11ed-8611-37d641c3527e; Tue, 02 May 2023 17:02:15 +0200 (CEST) Received: from mail-mw2nam12lp2045.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.45]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2023 10:59:43 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by DM4PR03MB6175.namprd03.prod.outlook.com (2603:10b6:5:39b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.20; Tue, 2 May 2023 14:59:41 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec%3]) with mapi id 15.20.6340.031; Tue, 2 May 2023 14:59:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51e990ee-e8fa-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683039735; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=w09wlSCp9EquAfQqRS+hpjyg6dxzrD1D0xfiQn0bbHI=; b=Zu2mt+6DvnN6FEgS6o8X/FvpnZZTo+ylZWoNrFr52N4uZSkxj6kE1Yxn I5Vj3oyOoXVHkI4pkDkxEnHVsbYnl1dVOsixoqairJnfhgd48KXHdbbbt RI+/68HtC+sFVOW46bAZKjkt6CXAG66mBfZ2vaeW/GpfTgZbbEtTgOL3j A=; X-IronPort-RemoteIP: 104.47.66.45 X-IronPort-MID: 107998060 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:W51CSaNPUDEqF0jvrR2ElsFynXyQoLVcMsEvi/4bfWQNrUpw0GcOy WAbXDqFOf6DM2Lwc4p+b4iy909XuMTWy98wTwto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvPrRC9H5qyo42tF5gZmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0rspJXpwr 6dEET1XdVPfp+O0xu+aQ9A506zPLOGzVG8ekldJ6GiDSNMZG9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+/RxvzW7IA9ZidABNPLPfdOHX4NNl1uwr WPa5WXpRBodMbRzzBLcqi3917+Xw3uTtIQ6MeLnrtVK3gKozEdDCB8Jc3eVvsCLsxvrMz5YA wlOksY0loAi+UruQtTjUhmQpH+fogVaS9dWC/c96gyG1uzT+QnxLmoOQyNFadcmnNQrXjFs3 ViM9/v2ARR/vbvTTmiSnop4thu3MCkRaGodPykNSFJf58G5+N1uyBXSUtxkDai5yMXvHi39y CyLqy54gKgPickM1OOw+lWvby+Qm6UlhzUdvm3/Nl9JJCsgPNPNi1CAgbQD0ct9EQ== IronPort-HdrOrdr: A9a23:/qMsLahr03lzSIjQigpdGdKEoXBQXu8ji2hC6mlwRA09TyVXrb HXoB17726OtN91YhsdcL+7Sc29qB/nhPtICMwqTNSftWrd2VdATrsSircKqgeIc0bDH6xmtZ uIFZIOauEYZmIK6/oSjjPIaurIA+PqzElrv4rjJrtWIj2CopsP0ztE X-Talos-CUID: =?us-ascii?q?9a23=3AcU9vymg1dq0T1GPYrwYtyH4A4DJuLyP510mKeBO?= =?us-ascii?q?BBDxyC+G1SF2WpYJtqp87?= X-Talos-MUID: =?us-ascii?q?9a23=3AYt4tIQ2B6+V2ni18cokrwPJS/zUjxvvxUGstz8o?= =?us-ascii?q?9seLUNS5vHRuzkw2Fe9py?= X-IronPort-AV: E=Sophos;i="5.99,244,1677560400"; d="scan'208";a="107998060" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fke3hhsVQYoZkWY7of+dP26OVNizg8F/s6TN5197GLmFyyOFoFQmSscbqHRFDo0122+axJtV7QW6LG/Z17rANCQKeJz996yrbvf3j84nLlMGiMwDf268OKkCWpqzHb+XxszKOyji/456g1ldjikLtc+U3MVcFZpWK9ZajQcaVrSa0PEYMSXSFNparEQDpGSvsmmThY/DKCb1cSTecif/m1AgmS3Jm7GJWWzJi1y0f7/xSJFTMxepF7Kzkm3Xiq7LKUN6wX7SUDHW2Dy0S7eZfTtORUY1xA8i8Cb9bh2mrzPs/WJmsbGc3SVUwUzRr5Bd/VVCpEjh2jpORS3Wqfg49w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q9yYdD46obGJvl7PXXkeV3azaYqYy0EKOnWgIgsZyZ0=; b=MG2KD3oaXiAfG1K4iMnyoD8MJcMeZY15TE5U3dZew/1v/z5zGpgccgt3EoOqFyto4R/SAJgb+oSrlCtE0KkvnP47cfexyEu4Hf/LHv0ykFjWkvgtuoimbJAp76PpZGvoXCs4gm5JoSbdn078MVVmIRTKUxe0+X0EjR0n8fqvaarduzj41TCLzZMfQAW86bytPjdbXQ4Rhfe5kb5mALpWCA4y6KOQ/B3LEksERsi2+bgfBGuNsVJs7xhdcGi6afPZMn1GbnOBr/mEtlLIk+Wnge398XIWy4cOo/rtTYhxKT1Dqyxqh97wMOfjV1nNStFKAm+bBFkXRv3YQDhCvg+wWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q9yYdD46obGJvl7PXXkeV3azaYqYy0EKOnWgIgsZyZ0=; b=GAbjRitQaPs/RQ3B6NB4CTHQZWFPm30fMYXBD2hNvQOdjJJPr1uJ5zZAzmLSqEqX9HSpSH7ieDFeogx7xQDxDq6Di4kqqyzLENB+mmGUnvy2MnTcAx7tWR+sBB5rWOY+dXaBP3d33Zn1SU1Fg+Z2kJd3gCW+BWrHVkU7f+MYZfg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH v2 2/2] x86/trampoline: load the GDT located in the trampoline page Date: Tue, 2 May 2023 16:59:20 +0200 Message-Id: <20230502145920.56588-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230502145920.56588-1-roger.pau@citrix.com> References: <20230502145920.56588-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO0P265CA0005.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:355::10) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|DM4PR03MB6175:EE_ X-MS-Office365-Filtering-Correlation-Id: 17f44865-2af3-4561-258c-08db4b1ddb67 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RaIJeM2fVvwbWRpBBpvJFlB3N+owt56dnnojhjUnrg0uEOacxQpa6ouDRK00ZEdCvREEL0ZQvkUOi/JZM9Vw6qbU2aM47Q1De6HrNF8+fhKVtNniJJVc4f5R2xFB0BdVIqIIf0TnvTxMlkQu8adnb6OuAcyxizFB9Y31wdeEsaLqeXhH5ZzCrMglINIMEsorE45a/SkI7zKJGRrR8PWy8gA/ctE9nPyyZtDuLfj00vfgJIwThpusCcNhcZIsZYc89H9FeChdz+3xZgL2pABC4zHoejHMdvUTnGGxB6Wui5NpAzJDcHwdJMEgzwPGmuxA1ThmZX5rnMQwvhFKVEbfMi3VUG+/Pmp9W5+K7eI8X+6W0t8MeOcRH2GTcc3yiIYyPd2jlxMZb2CUTOI20OGf2it8MznxUdPCC0tfyK7xBZKUoqK3d3SVC4JpTZkCc1Zb0EqLFFJcZmnRX/AmQQoXiejGUlr5ifjEeJtNfYw4uChFMDf2dvsuxMPfvqKfZdop1XiM7sAlwl5KiMHtOwLmjcMRyWkq+8e2XugkK0ZHwLZ626oTh7lcBVjQzags6MxO X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(346002)(376002)(366004)(39860400002)(451199021)(82960400001)(38100700002)(2906002)(8936002)(5660300002)(8676002)(36756003)(86362001)(2616005)(478600001)(6666004)(54906003)(6512007)(6506007)(26005)(1076003)(6486002)(186003)(66946007)(4326008)(66556008)(66476007)(6916009)(41300700001)(316002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NDhuNHNWVEZLMWZsb2tWQ3lpUTAxdmQwVWVOc3J6ZmZWd1ZRWlpTV1JFbHlo?= =?utf-8?B?M3dNTWxORG5QdnJMV3FmTGlLeW1hd3lhOWJITFpGNzhub0t6VkJqMTBQSzEw?= =?utf-8?B?WFhWMTF4OTExQThIaUZMMU1senVhKzhDTWFzWHlMeFpqOHR2UGl4V1M3Qkd4?= =?utf-8?B?WU5NdjdoL1lsNis1UWhSaGhGTHhLcHY3b1JhSEk4NDRFZWxWSlducVVnczFC?= =?utf-8?B?Sm05RjhseExMd0RuK2RTbWJ4cFJSd01JMWdYRm5SN28zYy9oVXlVT01QWlJM?= =?utf-8?B?K0dVL2ovWkdsdVUwK2hoYmg0N0k3emg1S3pWVmxNOHhVeW5DZXJ1MXFQcXRO?= =?utf-8?B?bTBySEFrcjBqRFlEUnlNei9JenFXZVcveFpnTWVWcWN4K3FCYktqTU9Uckpn?= =?utf-8?B?cFphV2JhcnJ3anY5eXEvdEpmdXVtcFlMY0Q1K1U0blp5d2dHVW1wZVdyckps?= =?utf-8?B?YXM0alQxWnZqTjczMVVCN2tMNTFVUGtJY0o2T050OUxsQ244aGJRbEk4S2p2?= =?utf-8?B?cGNxb1hBek1yS1U1dG5MVWtsalAxV2s5YWRYT3pXL1FxYmtoVlUxM29VdS9v?= =?utf-8?B?QUJrcUdkV25JOGJheitpUHZuRFBFNjcvMmNjTUI3YzVDc1RpWkVLQ21jeENH?= =?utf-8?B?dmtMWnJnU3RSVG1XcGlxQUtFMTFSZWdVUDYxNEdZTzdjbjcyenFJaElkcXdG?= =?utf-8?B?bmxZNkZSRHdjeDBaNXVrT2tURDAvSWo0cDJGS21ON2RnVUYvUEpVMTc0MTB0?= =?utf-8?B?U3hZQ3B1WVhQSXd1UkZNc3V5SVBhVXE0VTdoTENicnZnZ1hKZVJRckdnMFpI?= =?utf-8?B?YVhRWDVkdWJia0RuRml0L0UrY2JLV2hlNGFJMlV3b1lYV1lOT0RGVU41SnVv?= =?utf-8?B?RUZ2aldPRnpSb3hEL3MvVzZvS01RZFJEOEE2OEh6c1M2dENMb0tET0k1bXpJ?= =?utf-8?B?Yk1Nd3NBdGdiK1FsYVdjU1J2dkdLVkI3OWxtVXFMVUlOdVJ4VW5CK0JhSWE4?= =?utf-8?B?Z2lGeDJPL0ZsR3E3NW1VczExaXdBamZmTXNGdllOZHpmcW1DTXhHWFAwRlNM?= =?utf-8?B?bElDUDhvWWlZQy9LakhmSnRoR1NNbWw4VFRuWlNhV2h6Z0liTmVTZ0Q4SUxh?= =?utf-8?B?RHZxenppSnF2THZ2WG9VaXJDMFpQU2RONURKTXhPSkQxSXdReVFwajd0SjhZ?= =?utf-8?B?anB0T21hSTJCV3hPaHVkRTBHbndjMmJUeHhrbmlkdnZIN1A3alM1T1hwOVJX?= =?utf-8?B?VURQb05RL1prTklORndXd0VhcGRFRkVhNnNjTzZTSk9SRHRoWGRTaDdEYnd1?= =?utf-8?B?WlpDcWdBZHFVSmJqZ3Z3R05yMjJURlIrRHFneU0rQW5NTW1hY2c0VDJ1QzBt?= =?utf-8?B?QjhTNXVHbUJpVnh2MWthUUFFTFdNY2crV1V1eHM1Q0dNV0oxN3FwWmdIY1FG?= =?utf-8?B?QmdjU3VTaW1Pam9sTFJFWE9IcmhqL1pLK0crVVhXMGZPbGVVYjhSaXh3Uito?= =?utf-8?B?WjBHSFVMTnVheUtlcWxpZW41L0gyaGYwSGdmOGhoNnZEZGt6TU11WGxBQjlV?= =?utf-8?B?dnI0ZzRmck9CbENrRDRJL1hmR2NZbm81cWI4Z1pTd3QyUm1uVmY3K3BmWElo?= =?utf-8?B?ZmpJRjJ4aURSdlp6YjBqODVyTS9BRU8ybFlhbWhQMnFySEh1MVB1dnJaTmY3?= =?utf-8?B?V1NZQ1YrWjErSVkwUDdkeXhDY0RXVE82NlZkVG9LS25ENUZldnBwU29jYTZH?= =?utf-8?B?bXExdktxbWZXZFpoN0t2Y2dQaCtiYS9hZlo4akpLYlFhYUFVMG5Td1JaTnQy?= =?utf-8?B?ZFVubTZ6Z1NlTXd2NVIvNStNQnQ2VDBzUEhVOWt4TmJiQm4vbkR0U3dIaXlH?= =?utf-8?B?NGlrcEl0bGErcWlaL1ZZQXpsWmp4Y2FOakxNTEJUSXpqTHpEWURvZXFPR1cx?= =?utf-8?B?aExRMiswNDRSZkx1alBPRUdMQnRlTEU3bmh3WE1GYmpNeXNIdnUrTnpoRUpo?= =?utf-8?B?c0V3YWNvZEFuL1RVbVBwNkQ3SDl6Y2w3OHBKV0V1QlAxZDNZUkFyVS9CSy81?= =?utf-8?B?NjB0RVFNSGtWZVRpSVUyWURSWHdSdkNmQy9UNEZNd2UzN2RKb3F0aDhoUmhj?= =?utf-8?B?eDAyUzBKMlRyZVZPTGQ2cGRWaGd3Slh0cVY0Y1phNnRXazhUaEFHTW9LQ1dX?= =?utf-8?B?MXc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: PLpHV08toh8qnxZmyT89R30wwyje0D4ymb97lqkUZczv2q2Q5qZbMDVb5Avex+q5TT5KZhUTA6yNrrMiwadQCKe3fSHa5GQADumDWZZoX8wRuhbywTUlG7959mTgWDUI6jTcL+ASDNgPMg2ffjaExggM+2v2FobrmEkHNiOinM6ebDS3qQa8EH4jpqSlCXSvD0jcpRqTr0LcnucQc7x/CgeXuNQ8FxSydlM1CR+OfS12HKNselKXSSpcHa+RMmdwLXDpz11S5xV07JsOkkKEBSmVbtz0nojSczpFKxKZ+9uugPwn/vu70P61BCf4W8jq5pPqkM1nxzXUQUqwzVEiZ1hxW1LOo0IPBhCPkLTgGoFh8jQX9dXsPkqbVhbynAdbM/5coYXXBXzxVecqcp9hAeY5N3eGh1vNGLebd1AF4TyOY3h+V9DzcsISd3RIL7KXAsLsefNVIxQgS6WkVkM+bBPbJ8VjyZO0lvQwviEHuKOi5UaCUJcXXV4qKAovDdL2lrIUnSW9HT2ToEpfckcMyFpwQjUESZ8LAzJd3LcIWccooWq4gb7pwFDIYKOPPjRuoanw1B6Qc4NHfXCVqfjD5dfFJjkFd8yeUMr9tPD+d4jg1CA+/JNkHUjsb7CgB64SmjMOvdSbVnSLyJCbxiVoClwu+0RzUDO8+SoD12/moXTRZDrEY+1sZXjy2kN7ZNoGySuBUpJ5h1CpeXS2UiFxFOmsBGbjxGbEhcabod3SKIlBi1+F58q5TyTF2BQqHXKR6deg5RTgUgb3JMu1kf7JQyVgmJTJJyAqMI6U2G5+C0UBzRTpoi049RgqgvBQpsG6 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 17f44865-2af3-4561-258c-08db4b1ddb67 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 14:59:41.3542 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: farOd407qZUcrtAYtbDIio7yzBzSZVOF0SoMAcWNN7zkAYITpZHTI5EMsTMU9RR1Wsger1gY2vGhsG29O2Pfsg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6175 When booting the BSP the portion of the code executed from the trampoline page will be using the GDT located in the hypervisor .text.head section rather than the GDT located in the relocated trampoline page. If skip_realmode is not set the GDT located in the trampoline page will be loaded after having executed the BIOS call, otherwise the GDT from .text.head will be used for all the protected mode trampoline code execution. Note that both gdt_boot_descr and gdt_48 contain the same entries, but the former is located inside the hypervisor .text section, while the later lives in the relocated trampoline page. This is not harmful as-is, as both GDTs contain the same entries, but for consistency with the APs switch the BSP trampoline code to also use the GDT on the relocated trampoline page. Signed-off-by: Roger Pau Monné Reviewed-by: Andrew Cooper --- Changes since v1: - Reword comment. --- xen/arch/x86/boot/trampoline.S | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xen/arch/x86/boot/trampoline.S b/xen/arch/x86/boot/trampoline.S index cdecf949b410..c6005fa33d1f 100644 --- a/xen/arch/x86/boot/trampoline.S +++ b/xen/arch/x86/boot/trampoline.S @@ -164,6 +164,9 @@ GLOBAL(trampoline_cpu_started) .code32 trampoline_boot_cpu_entry: + /* Switch to relocated trampoline GDT. */ + lgdt bootsym_rel(gdt_48, 4) + cmpb $0,bootsym_rel(skip_realmode,5) jnz .Lskip_realmode -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Tue May 02 15:02:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 15:02:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528709.822205 (Exim 4.92) (envelope-from ) id 1ptrWc-0000yT-Le; Tue, 02 May 2023 15:02:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528709.822205; Tue, 02 May 2023 15:02:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptrWc-0000yM-IA; Tue, 02 May 2023 15:02:42 +0000 Received: by outflank-mailman (input) for mailman id 528709; Tue, 02 May 2023 15:02:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptrWb-0000xz-Ao for xen-devel@lists.xenproject.org; Tue, 02 May 2023 15:02:41 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 600b64f5-e8fa-11ed-b225-6b7b168915f2; Tue, 02 May 2023 17:02:39 +0200 (CEST) Received: from mail-mw2nam10lp2105.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.105]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2023 10:59:33 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by SJ0PR03MB6422.namprd03.prod.outlook.com (2603:10b6:a03:396::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.27; Tue, 2 May 2023 14:59:30 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec%3]) with mapi id 15.20.6340.031; Tue, 2 May 2023 14:59:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 600b64f5-e8fa-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683039759; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=oFeo/VJqrFvjet3X+2e5EGDYnRXVjUnCVi3N0p1FJNI=; b=UlToa4MX9SkmZkIZEmXAEBjumCRkKRtoyEOUjil7IuRwwJ5GQYkXqTZ/ KQVNUF8/9xpHSu7aB8PCmatBH/U07Tc9E2d6NmkdmEQKeJ693rSQRlwHS LOqjaDZ/bt7AGY1NnSFf2Hyjgoni/um8cGfbYH7j0tfevnUSex1w3Tkik c=; X-IronPort-RemoteIP: 104.47.55.105 X-IronPort-MID: 110031688 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:7yhQdqD5MSjlzRVW/w/iw5YqxClBgxIJ4kV8jS/XYbTApG5x0WYOy mMfD2mBa/qDZWqge9kkbti+oEoGv5WHnYQ1QQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFuspvlDs15K6p4G5A5ARkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw5el9G3oU+ 9chMylKfyuPnqGW7ZacVbw57igjBJGD0II3nFhFlGmcKMl8BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI+OxuuzW7IA9ZidABNPLPfdOHX4NNl1uwr WPa5WXpRBodMbRzzBLcqyr03baRzXOTtIQ6PrKk08Z2oWSqzFNDNyI5anH84vqAsxvrMz5YA wlOksY0loAi+UruQtTjUhmQpH+fogVaS9dWC/c96gyG1uzT+QnxLmoOQyNFadcmnNQrXjFs3 ViM9/v2ARR/vbvTTmiSnop4thu3MCkRaGodPykNSFJd58G5+dluyBXSUtxkDai5yMXvHi39y CyLqy54gKgPickM1OOw+lWvby+Qm6UlhzUdvm3/Nl9JJCsgDGJ5T+REMWTm0Ms= IronPort-HdrOrdr: A9a23:HAsQlqE00bQEPJPFpLqE0seALOsnbusQ8zAXPidKJSC9E/b2qy nKpp8mPHDP5gr5NEtApTnjAtjifZqsz/5ICOAqVN/JMTUO01HYTr2Kg7GSpAHIKmnT8fNcyL clU4UWMqyXMbGit7ee3OBvKadF/OW6 X-Talos-CUID: 9a23:DxuosWNjKbH9OO5DRyZt7lVOFOscaWSa3UzcOgyYJEJOV+jA X-Talos-MUID: 9a23:1rN1pgk341QFoH4QPVy4dnpIO9tN27iPMXkHrsU5hOa7H2szOA6k2WE= X-IronPort-AV: E=Sophos;i="5.99,244,1677560400"; d="scan'208";a="110031688" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i+cWA6A9WKM13hyyjNPxyAFyLMjEmp8toj8HqQ8JA3ZUJ0fneiUB86W0/Gic6lQ3AcaJpS9qriLTBBfj7iInr6bpXozB2bFG4cRio4WJbM5ObI+SJJl9T9XT4XBwWwQiik8FcS1zSpp4oCWeme42DdQkb6ctLJJG/xo5wu6hyYX+Hlg0nxu5O9XEPxnTZb6Zvr4z427LoH97TqNUfSlTpgPFEL6G0sbX0fwgVOL7x2/xM9rI62HrTpz1jQH+XwCViGzXe2/WX3rWPpfsMELFXhEfDZzBtvtCac/s9GBtnzmRY24nyhzILJqeMs/5AVElBN2sVsJWmEOrvaYgaq05RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tHaYVkPXio4QryvASgtAEsRqT3MTpTQ6WEtH/GK1i0g=; b=i12GEvfcX9k5w65irzejnvOXmoylmMpoe8CTXeqM0b4c3W0AYfxkMjYYnnldBqHQ6I3OprOJmFMI3ERZFSFytJicck9yGp6OLYoMVUcNqjDKi1fM2Ujy1IINttvVEvEyWxILhzi0fG7uBa9DHQfgocXG6MoNnb51ErghpKDjfN32zm2Z7nAUab2M8hOfuVNs5x1p93N+G3kvSza/de1i+pPtnXEFkuiPYd2oloZUWjTYAD2i8CRApMzuSb6pN0xcuEFCzI5TB9sBT+vGYyT2LIwRcF3dnWWWngyHF9jubmPx9At0dzAqNXt7k5CrTmCX0rp/H91PiZHo3wQJTk3a4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tHaYVkPXio4QryvASgtAEsRqT3MTpTQ6WEtH/GK1i0g=; b=gpiwbs2EKSxfNA9Z14GOWKQBcwNLzfoP5HF17qU9D2VhebrwCxhODx7mTQ7FmkBq3yicxB44jLFfV+gJKR0xF3R8b9whNWBFpeql+E+LAu0XzRYV5LKnXZ/k68lwGaskbKxJWixV5NkSBqeFOaTRC1WrSsg8SrRHtmonOXPRI9E= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH v2 0/2] x86: init improvements Date: Tue, 2 May 2023 16:59:18 +0200 Message-Id: <20230502145920.56588-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.40.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LNXP265CA0092.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:76::32) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|SJ0PR03MB6422:EE_ X-MS-Office365-Filtering-Correlation-Id: 8e58fd73-7cde-4abd-0ea8-08db4b1dd4ec X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Xs1/A4yX5fSL8O81MCp+aK6m0jubL/WU9kkcJvrCHdSmslsYJsKNINI2FDjslOqJbpZwxb1KEws5p9G0xUcjF+f0FhUafuNs/oc+OTZZUz1TpuBdSUWzm75RdIiqCCAK0/JdUZgqw36w7fVflrlleHew9KORYbylQQyCbxKAdYQZrXx9S8iqSjC23uCjk9fVl9f7MCdo634dicF3GImRecElO3MjsSLxfiFMQM2RHx82CU2vPF6sIY9dAHfC89uip1QVKE5A8fscl59QsmFqOhU5wBAzzhsLO2GhPLw73TpGY5P8XqMZzQtyiZNCFkX0f4bFsx5/Z7EGjmIB/RNFeAoIX57akM79eKnqiYR6Jfq2KEx9h6yvlf9W3p2w97hzH2fValJ7vlrH3fHvj1Rh9li16kP6hWYBAZ0SK1cX+bJdyWBRVfwG/GK1Gf1IUsTCIC6E1r0Gr/uWZ/MHkGqqJaNt4+dWSdPKalPne8bRbdOjrlKMbbA17TIjVcCAUDWk8d+rLgguLVGNwEF/U+2N965KmD2HXm8LZ+Ba/FoxeQ2yPPcFVepCj8QWixpTH+pC X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(136003)(346002)(39860400002)(396003)(366004)(451199021)(2616005)(83380400001)(478600001)(186003)(54906003)(4326008)(6916009)(66476007)(66556008)(66946007)(6486002)(6666004)(6512007)(1076003)(6506007)(26005)(316002)(8936002)(8676002)(5660300002)(41300700001)(82960400001)(2906002)(38100700002)(86362001)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bUJHSmM5ODBoblBvaTBzNk8yL1B2RC9IN0xybVZkbDZKbE1VV1VmY255cDlQ?= =?utf-8?B?Q2dhZGVxaWluYklhc1FBMjV0d2lBa0JsTVhGNUdUaVVacDU0QkxvZWhIWXls?= =?utf-8?B?TG0wMS9CV09qNEFLYTJlYWtMbmowSGo2eWovOHFQTzJKVzBDSDZtMVRNVFhO?= =?utf-8?B?Znk2MGtXV28vMDhtTUgxY1dLakhZTEdBekxjS1FtT3g0S0dCcEJpd2lxWVRG?= =?utf-8?B?akljNjd0RDl5Y0hOV29Tdm8vZnVaOWsyRSt0Y2QyZHY1V0ZwbitIT3hiSVF4?= =?utf-8?B?ZWMvRmlBeVlHcDNRazJNd1lXMWNEY3ZnWUc3V29hTVdsbzlkblpHMDRHSGtP?= =?utf-8?B?VmZDTUVIS0NNa3A3ZXBjbWlPS2czRFZMS2IrVDNHVFQyN1FkcHA5LytBNkxO?= =?utf-8?B?dHoySEkwdDBlb0Q3cHRXSW9BeHg2Yytka041ZERKUUxMR1F0cit0MlQ2V1Q4?= =?utf-8?B?bVU0MFdKTTNUdzRtMHViTnk1ZHFJRFFLWW1pNzZiVFp1dDc5NE5Eb01RWE9a?= =?utf-8?B?WUNlbjRjbEYyTUNvT2I1bTBOVG8yMVJYS3k4dUdLaGZObGZYRU9Zb1VIZWlV?= =?utf-8?B?TXEyV0E3VHAvckZUK3V0QkF6OWREQkVDUVhhYmd5OFV4bVRRNHVTN0wyZ0gv?= =?utf-8?B?a2I5aThVT3dzaVJqVEk0VmJVbGQySTJXWDh5RGRsbGR6dHYvQjNMM1ZUSkJm?= =?utf-8?B?eks1b2I0cFh2VFVaZTN2U3B5Snl1L3RTa3dhTXk3c0xCck1RWTMzWlVpMFBK?= =?utf-8?B?dXp0QXIwTTRFQ1pnWXk1QTVlVjFmM1RUK3NvOFRVUlBwUE9sNStKc2o3MGRE?= =?utf-8?B?Uzc4R0I3WnpiVEwzRWdzQmRuNE14MW92a1BkcnRvSFhzZWx3dUliaE1pcTE3?= =?utf-8?B?a0pmYkRBQjlWNzk5aDY2eHpRb1FsZ3Jib0crL3l3cU5VdFZUQUVFWktqNTBR?= =?utf-8?B?RlA5N1NOWkgyc014ZlVrT09pUjdGMFlBSVRyYUZqZ0pJVWpkMDU1SENqK09y?= =?utf-8?B?S1V1RE5KNmZUUzhxVVpxZDVqZHpvc281dThHM3oyK2FYZllZdW1sZk9qUTc4?= =?utf-8?B?UVFDendqcmhId0NXUjNxQm5zb29oblQ4V0NpajNCdmxraG1aUlFHdkkxdXBS?= =?utf-8?B?YitqT0g0YlVhdnVJbWRzSFg2NENZWjBSUzBGRFV0THdtNnNKWUphUk5YZlVB?= =?utf-8?B?Z3Q1b3d6eThHUWZOYmNoRVVWOVFHcnFabStjMENDK3djUFRFMVNXMll0RFBY?= =?utf-8?B?OHNRZkxhd3lOczB2SXNpbit4YjlGQ2xUNkZEMFZsMU9GR3pSdlorUGJiVkZ0?= =?utf-8?B?MlJHRUh4QnRETm12SFlOUU53TVkyOXU0dURObitrbi80N1JEeU5XSEtGMWEx?= =?utf-8?B?eUVuREhseWl3b1dBSkZLYkNKREdmZW8wTXk3ejhReWw1Z0RneGFuSDNJaGNs?= =?utf-8?B?MHA2QnIzY3NFeFMybm5SNEZ1SXVXdmpZd0dUaUF1eEJqTTFWckRTTWJuRmZZ?= =?utf-8?B?L1kzYXNTSjk1K3ZlOG5tSGVlY3ZLYXc5cjFZNGZvTEhaSlIvaTFJZ0lUNzM2?= =?utf-8?B?ZHpTNVNtNjQwYzlPRDkyTEFrMlJKTHkxemU1VUgxVUluRFduS1lmYkhjMmR2?= =?utf-8?B?NDZVYjFEUTBNanNuQkYrRmlHc0kwOUQ4RnF4MGJrZHpSRmhmWmZhN1kzUmZK?= =?utf-8?B?ZVlsTWp3VTRnNm5ESnlhaGNsaVJmMW0weksyclZENGMvNktzUWxtc2RIcDFJ?= =?utf-8?B?TnRlb3ZPOE1tQTJaeE5ISjdudUNHZzVnTlhHYVpOYWNWaXFsTFh0UzJvK0N4?= =?utf-8?B?aGgvdUFTWVpySjVHS0FCQmdaWjZ1U1Zqamw2QjZ1TkJjTkJOVXNrQzR0eXdv?= =?utf-8?B?WXEzN2Zjbzhjb05jTFQwY0Q4S2kxdHRXUWJEK3BiVlAvOGhITC9jY2lmQVJ6?= =?utf-8?B?VTh0SkNMNXNhRHNtNGliOGNBQ2NlS0NGUnZnbGFjcVYycngzdGVWdXZiWXIy?= =?utf-8?B?S05oTVlEWHpobTh4QXBSMUFqbXRVRjVDN0tZWjJZMXVmYXJOUkJBaElFRlpj?= =?utf-8?B?ZGVKQXlsUXhwOVFJTWpjeWtyc0lOV2NRMHlyRnl5YUN5cTYwbFI4MjhXSG5J?= =?utf-8?B?WHo5R2FxZGd1S25OaGttS3NtajQzTG1XWm1QbXlvdi8vcEppMTgvL1ZCVXgv?= =?utf-8?B?eHc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: GK28bXPhf/JMZFz+2T1n4pUPH1CpRLYAxV310vcIboEf9+TVuruEyP9taE8rQ0c4HMymPrCExltHNwU0BwqW2EBAXdObmMCqRnKj4lJBhHvsqP+m3m1IhC1Gx6XcqBgDMB/SJvRm4aTUJElC7V/hOIZc8GKk2ELwd7b3LLkAZWCi+Wwfjjxuxx7vqQdvBDg3AZIA+36jGqIUCXOFKlgcyTt7NlfCnOFSr+t8MRABU8E/N36KVv3E0hILtkTa5KUbp+MujteBp80xRyl0UUk9mCESViPKPO95hlqi8N2sfCRzavLSSWvzDpUbcFc7SX7jqwgfLDAJ7kAejY2TNC4obaS0ezudzqWaFICQOuemMUOKS/wSwuoxIhUUNSHYSn8NUJQ5vwPDRO47j9xvuZ9EeOYyTdvT1xmYsVH46+as4UFH7xg6uoGJzAvO+ltmOKhCDBGH6XRy9NVKHWw79PRwUAMhBNpG6BIzk14gqr6MEzo32vuQuHXvOAYgaKOKtMZb3PW+PJMerfnZq/iZQnozARLae3r2mk1PPy6Hc00mwCiAVWzaVm0ZxJ3r7OYzh/HcyML8RdmQe4VQKwK7ldfRgVO9BTNAD2XXKf3v5PsS2IYp/ysXZ+Hx4LZbLM5lTjmL0JgrOt+Mk58iSvVlWWzUqLRyjGefUP7unkZiH2EyuUt5xVk8eDQxbsU9kV3/NBGAdcyaWXT17/OG0WVnD0gv6bBNbx3uyppqEpIAL07HcaoHCOKdhNQZfbg8JHHbsdRSJM3JRFNjVB740rkgC5U1C2HphGy7Yi4L30F+rUfiTqH6V+7YpWWha+qKY2E+j3fp X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e58fd73-7cde-4abd-0ea8-08db4b1dd4ec X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 14:59:30.2942 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PQoADG3c06z50l0LkQZTxNeFaUTOhkYoO/688yT+CXNcLDDLTfY/lhwr9xqsopdN8zPymj/TZa6ndzsvtAGoxg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6422 Hello, The following series contain two minor improvements for early boot: the first one is an alignment check when building the initial page tables, the second is a consistency fix for the GDT used by the BSP for the trampoline code. Both are a result of some debugging work done on a system with broken firmware that resulted in Xen text not being loaded at a 2Mb aligned address. This resulted in corrupted page tables that would manifest as the ljmp from compatibility mode in trampoline_protmode_entry causing a triple fault due to the GDT being located in the Xen text section, and the page table entry for that address being corrupt because Xen was not loaded a 2Mb boundary. The aim of the series (specially the first patch) is not to allow booting on such broken firmware, but to print an error message instead of causing a triple fault. Thanks, Roger. Roger Pau Monne (2): x86/head: check base address alignment x86/trampoline: load the GDT located in the trampoline page xen/arch/x86/boot/head.S | 14 ++++++++++++++ xen/arch/x86/boot/trampoline.S | 3 +++ 2 files changed, 17 insertions(+) -- 2.40.0 From xen-devel-bounces@lists.xenproject.org Tue May 02 15:14:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 15:14:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528717.822215 (Exim 4.92) (envelope-from ) id 1ptrhR-0002uK-QM; Tue, 02 May 2023 15:13:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528717.822215; Tue, 02 May 2023 15:13:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptrhR-0002uD-Ni; Tue, 02 May 2023 15:13:53 +0000 Received: by outflank-mailman (input) for mailman id 528717; Tue, 02 May 2023 15:13:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptrhQ-0002u7-Gc for xen-devel@lists.xenproject.org; Tue, 02 May 2023 15:13:52 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f0df85e0-e8fb-11ed-b225-6b7b168915f2; Tue, 02 May 2023 17:13:50 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f0df85e0-e8fb-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683040430; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=07zf0NeMm2d5BtZmhXtI2pUoiNhPMEhhTEmYaZi+6VM=; b=GMAjk58st6hl2mDRuSqNadIMKB6vrLloc/s7G7V/3mXC7y0dYOnUeyiR cNVNwriIz6gRR3M2wanbDItqztGNhWXrK1BlzZPFpwgAH7SVMkBu6ts73 9YFeENaroaK8JKZ/nX9YzkNuC+PY2sHtvaZQl6WWX+PqrDJlPJvCGxD9Z Q=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 110035196 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:s+eLYaA7HJEE5xVW/wjjw5YqxClBgxIJ4kV8jS/XYbTApD0lgTwGm GMZD2qCOfyJNzTzed5xPoy39EhQuZKHndJhQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFuspvlDs15K6p4G5A5ARkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwo/p7JExO0 cIhBBsKMTqHm+ToxK3iVbw57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2M1N3wsYDUWUrsTIJs4gOevgGi5azBCoUiZjaE2/3LS3Ep6172F3N/9I4XSHZ4IxxfGz o7A1ye+X1IxF9W49TOArmuJq8rFrCfwWJ1HQdVU8dY12QbOlwT/EiY+UFKhpPCjh02WWtRBK lcV8C4jsagz8kOwStD3GRa/pRasrhMaHtZdDeA+wAWM0bbPpRaUAHAeSTxMY8Bgs9U5LRQ10 neZktWvAiZg2JWXRmia7ay8ti6pNG4eKmpqTSYcQBEM+dXLvIA5hRWJRdFmeJNZlfWsR2u2m WrT6nFj2fNK15VjO7iHEU7v2i6gg7XJajAMyi7QAUih8gUnYJH8eNn9gbTE1sqsPLp1X3HY4 ihfw5HEvL9RZX2evHfTGbtQRdlF897AaWSB2gA3QvHN4hz3oxaekZZsDCaSzauDGuINYnfXb UDaomu9D7cDbSLxPcebj29cYvnGLJQM9vy/DJg4lvIUPvBMmPavpUmCn3K40WH3i1QLmqoiI 5qdesvEJS9EWf42kmXvHb9DjOBDKsUC+I8ubcqjk0TPPUS2PRZ5tovpwHPRN7tkvctoUS3e8 spFNtvi9iizpNbWO3GNmaZKdABiEJTOLcyuwyChXrLZc1UO9aBII6O5/I7NjKQ+wf4Oyr6Zr xlQmCZwkTLCuJEOEi3SAlgLVV8ldc0XQa4TVcD0AWuV5g== IronPort-HdrOrdr: A9a23:RQmW+KkUW7NY1jcm7aKWfWYvGSDpDfIT3DAbv31ZSRFFG/FwWf re5cjztCWE8Ar5PUtLpTnuAtjkfZqxz+8W3WBVB8bAYOCEggqVxeNZnO/fKlTbckWUygce78 ddmsNFebrN5DZB/KDHCcqDf+rIAuPrzEllv4jjJr5WIz1XVw== X-Talos-CUID: =?us-ascii?q?9a23=3AdEIMBWsbHOkjgbhsdIo8DqpQ6It8bnH44Xf0HXa?= =?us-ascii?q?UImE2YrmJTwGU5/p7xp8=3D?= X-Talos-MUID: =?us-ascii?q?9a23=3AE7+Nig39ZiOi1+2vvmHzld7ZgDUjoOPzS2sumLI?= =?us-ascii?q?6sszYLAldHj2siD+3Xdpy?= X-IronPort-AV: E=Sophos;i="5.99,244,1677560400"; d="scan'208";a="110035196" Date: Tue, 2 May 2023 16:13:40 +0100 From: Anthony PERARD To: Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= CC: , Wei Liu , Juergen Gross Subject: Re: [PATCH v3 2/4] tools/xendevicemodel: Introduce ..._get_ioreq_server_info_ext Message-ID: References: <1f6dc87eebe5d1c27ae15ec8f5d8006e5aa1c36d.1680752649.git-series.marmarek@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Apr 06, 2023 at 08:05:04AM +0200, Juergen Gross wrote: > On 06.04.23 05:57, Marek Marczykowski-Grecki wrote: > > Add xendevicemodel_get_ioreq_server_info_ext() which additionally > > returns output flags that XEN_DMOP_get_ioreq_server_info can now return. > > Do not change signature of existing > > xendevicemodel_get_ioreq_server_info() so existing users will not need > > to be changed. > > > > This advertises behavior change of "x86/msi: passthrough all MSI-X > > vector ctrl writes to device model" patch. > > > > Signed-off-by: Marek Marczykowski-Grecki > > --- > > v3: > > - new patch > > > > Should there be some HAVE_* #define in the header? Does this change > > require soname bump (I hope it doesn't...). > > You need to add version 1.5 to libxendevicemodel.map which should define > the new function. And update MINOR in the Makefile. -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue May 02 15:17:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 15:17:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528720.822225 (Exim 4.92) (envelope-from ) id 1ptrky-0003W5-9c; Tue, 02 May 2023 15:17:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528720.822225; Tue, 02 May 2023 15:17:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptrky-0003Vw-6r; Tue, 02 May 2023 15:17:32 +0000 Received: by outflank-mailman (input) for mailman id 528720; Tue, 02 May 2023 15:17:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptrkw-0003Vq-VQ for xen-devel@lists.xenproject.org; Tue, 02 May 2023 15:17:31 +0000 Received: from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de [81.169.146.162]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 734e5329-e8fc-11ed-8611-37d641c3527e; Tue, 02 May 2023 17:17:28 +0200 (CEST) Received: from sender by smtp.strato.de (RZmta 49.4.0 AUTH) with ESMTPSA id x6987cz42FHRdnY (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Tue, 2 May 2023 17:17:27 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 734e5329-e8fc-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1683040647; cv=none; d=strato.com; s=strato-dkim-0002; b=Wa57NokZYMCCzcN803tea9dgEoWAtmCZHOIBOey296a6pkqxIZXnNjZ8UMJwAV7obC Z1Hnptv5PcI4mT7GOtWARy5HQk/0V/Q1pK4D4JWpo3b5YOk9Gs+MBWAFPeZSOblrBPeJ JH7JF0ZNFHC0VZcrykd6vkKrd5aRNmZEiJRVSbUPWNfvqSuDjwDy+JNKD6ZkBMdN8eOg r0+0MZnnLqyghtBjYmVy0NY9WlWdNnsfGhB3U9TXRkMQ7/2gbUX1g4G7FpV68gl25QN4 Dpcl+64MnjyvVtG/f9pktdVQynXCujpubHCqqpwwZNSa8q4HuQYg71FQxks8ZNE2IT+Z CgTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1683040647; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=Fwogx588Aaq2W17horur++XnjoVqpQdEpobUSP19l0k=; b=tCvtVlzx69JaEKJFbncI1ojaEt+7jWmnG27jF90to4daDrBRi8t6lhKZ8ZY4Ofsypk Bmvlyu097P/GBwoyJDmZ2HMic9jD/jVrqLogsvY7Vd9EIsNILVPwnHwPhi5vwLDRn/mj N2j7DgUUv63jezP5Qoz6KsVimd2eLMlSUFUJ4u4INv6dTsneZl3F5g6cEKkVMSZ8+fx2 3MRA7yRyWIpDC97RmnxaFMOxPHROclUYDIE8er3jS06LDsDlM0An5qOj8lWdMzXPhodP px0FxytJhhv1C2CMZLYgwZPDMHaUOFOMFe8d8cAdxta88Ypd8k4O3ofDAWA9lyx3o8LZ dyWQ== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1683040647; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=Fwogx588Aaq2W17horur++XnjoVqpQdEpobUSP19l0k=; b=QBncioqE5fe9U6uDbElKvJHsPyNUd9YyBEjutjToQrAPTAD/5/hQU+FEG7xqTUuZ6k elo5QLVcEUw743fpp48jdF4KBOfWcjqFT9eg8HN8NTtE1ge4dsOi2XorIW7NkTYPfiZ6 xriap2gL9ohVosD8PdKNp7eTEJyvVzjvlDkFdjPzh/xUuFXEyMngvmpb0Ir+uFKzoUf7 isqnU5rzRRziy+4kYhfwhKUb3t2OfTp3zJYAGEldXgJRiHtJ5Je6lEoH6NS+1D0hwWTD /Y9zhLfDa/r4iBDIXM4jaGeUJFQK6DGL8qtEgCKGLTEGC/t+27o7bTDkREd2aKGrph7w u0sA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1683040647; s=strato-dkim-0003; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=Fwogx588Aaq2W17horur++XnjoVqpQdEpobUSP19l0k=; b=vNi8eV540a1kJ62UpVgJaLrN32m9t0liS3ULrEqaEBerzfymeoHenJ2FhTwPlTAc1x YhFY6ZvI+7mdKxGviZDw== X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisR5BxOIbBnsc1fym1gFvNQ7EzMpH+yFJc4aADp/8Q==" Date: Tue, 2 May 2023 17:17:20 +0200 From: Olaf Hering To: Andrew Cooper Cc: Jan Beulich , xen-devel@lists.xenproject.org Subject: Re: HAS_CC_CET_IBT misdetected Message-ID: <20230502171720.7970f914.olaf@aepfle.de> In-Reply-To: References: <20230502074853.7cd10ee3.olaf@aepfle.de> <43b1c214-4248-a735-6f8c-9e08bdd2eaf6@suse.com> <20230502133313.2192eb99.olaf@aepfle.de> <20230502140444.1dacdb33.olaf@aepfle.de> X-Mailer: Claws Mail 20220819T065813.516423bc hat ein Softwareproblem, kann man nichts machen. MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/w5sxl/Ob8gw=tMiashUNBs0"; protocol="application/pgp-signature"; micalg=pgp-sha256 Content-Transfer-Encoding: 7bit --Sig_/w5sxl/Ob8gw=tMiashUNBs0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Tue, 2 May 2023 14:41:25 +0100 Andrew Cooper : > Does this improve things for you? ./checker: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by ./= checker) make[2]: *** [Makefile:24: check-headers] Error 1 I think as soon as tools/ or stubdom/ is built, more issues like that will = appear. Olaf --Sig_/w5sxl/Ob8gw=tMiashUNBs0 Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmRRKYAACgkQ86SN7mm1 DoBiQQ//coHthXXsKJimfjYYvq/c2zdS+1YE4v6VW3u1EGTrJvGkIt/HOtLnEuk5 iZm9d/CAigEB998Cg5cZJADDJUhriYkH7b7wmypwfL+Sn5UXZrZwZVzugQ/fwBBI uHSu5/exah/fV0vz58+WRT8Lg4ka791nBmzWZPd0A10z57RUlZtGez6vgGU/YHw/ 7iAIrkPaA+MaQ6iPY7rhGoBBFrYwajRo1AZ6aAqO/790zlTKAuEAn9TOT6AbmkqA okYhEHQ+iKKEZ+zhIINu4yDcH9+HnC6I6J0lhSdSIAz4RDqbttJ0ZyiSO88o4WW3 0J7+pEMJripV2CgYxAHjTdmrcnWYLtOUasmHtM96bbGYVrZtkMz9vExtIB0Nu3Rc AcmUEy/JwvJLK69fJ112AGoqNuFiR9QWYtzVdUWPdSFYyVWWo2US6HnimQEKA8gW aGSs8F/+yPrsENEaRBtQbvNydWiczyAHxi2RFD8UZAcVRl7CZe7MOWYykzWaPfSV nDf20UbtOXtC27h5gb0Y/kVzb2nlfSN+8fzgMJhsl2pyUDeKWYG1KbXra44BA+ya 5TJqbonsLXWjLMx5HK2JmeGP2pfFYvsOqQoL5Coez4qIkl5LBvv/HnKxL7dphs+s NWXolq+wz5D9PlRS/ERw+gZsqZyyBng1xcN0JlYr4XSvhWhaBuQ= =HcC5 -----END PGP SIGNATURE----- --Sig_/w5sxl/Ob8gw=tMiashUNBs0-- From xen-devel-bounces@lists.xenproject.org Tue May 02 15:21:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 15:21:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528726.822235 (Exim 4.92) (envelope-from ) id 1ptrp0-00051T-QA; Tue, 02 May 2023 15:21:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528726.822235; Tue, 02 May 2023 15:21:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptrp0-00051M-NB; Tue, 02 May 2023 15:21:42 +0000 Received: by outflank-mailman (input) for mailman id 528726; Tue, 02 May 2023 15:21:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptroy-00051B-LR for xen-devel@lists.xenproject.org; Tue, 02 May 2023 15:21:40 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 078a6cf0-e8fd-11ed-b225-6b7b168915f2; Tue, 02 May 2023 17:21:38 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-556-js-j9vUPNr-JzXSEn51u-w-1; Tue, 02 May 2023 11:21:07 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CC73E18E5312; Tue, 2 May 2023 15:19:53 +0000 (UTC) Received: from redhat.com (unknown [10.39.193.211]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C7EB52026D25; Tue, 2 May 2023 15:19:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 078a6cf0-e8fd-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683040896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=O1kjfWbyj3zykPV4mxkot03UoMaYj696sk4Wl0CL1mY=; b=ZV0qWZFJvlO+3fqr3yJoSQXriwtRM7ZEl7fCXgrvSyXGOxM3d5zz7QshoCBqzlVSlPhtUn LnXCLR0lLfTNCXchNpIH4/j7NMAlfhuCymLiy1UmRIo48lSmZIchjJID4628wtsS1SwtNU jQHtkZSWdk2UZghJmRuJzlkU6f6IH54= X-MC-Unique: js-j9vUPNr-JzXSEn51u-w-1 Date: Tue, 2 May 2023 17:19:46 +0200 From: Kevin Wolf To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Juan Quintela , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Richard Henderson , Fam Zheng , "Michael S. Tsirkin" , Coiby Xu , David Woodhouse , Marcel Apfelbaum , Peter Lieven , Paul Durrant , "Richard W.M. Jones" , qemu-block@nongnu.org, Stefano Garzarella , Anthony Perard , Stefan Weil , Xie Yongji , Paolo Bonzini , Aarushi Mehta , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Eduardo Habkost , Stefano Stabellini , Hanna Reitz , Ronnie Sahlberg , Daniil Tatianin Subject: Re: [PATCH v4 03/20] virtio-scsi: avoid race between unplug and transport event Message-ID: References: <20230425172716.1033562-1-stefanha@redhat.com> <20230425172716.1033562-4-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230425172716.1033562-4-stefanha@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Am 25.04.2023 um 19:26 hat Stefan Hajnoczi geschrieben: > Only report a transport reset event to the guest after the SCSIDevice > has been unrealized by qdev_simple_device_unplug_cb(). > > qdev_simple_device_unplug_cb() sets the SCSIDevice's qdev.realized field > to false so that scsi_device_find/get() no longer see it. > > scsi_target_emulate_report_luns() also needs to be updated to filter out > SCSIDevices that are unrealized. > > These changes ensure that the guest driver does not see the SCSIDevice > that's being unplugged if it responds very quickly to the transport > reset event. > > Reviewed-by: Paolo Bonzini > Reviewed-by: Michael S. Tsirkin > Reviewed-by: Daniil Tatianin > Signed-off-by: Stefan Hajnoczi > @@ -1082,6 +1073,15 @@ static void virtio_scsi_hotunplug(HotplugHandler *hotplug_dev, DeviceState *dev, > blk_set_aio_context(sd->conf.blk, qemu_get_aio_context(), NULL); > virtio_scsi_release(s); > } > + > + if (virtio_vdev_has_feature(vdev, VIRTIO_SCSI_F_HOTPLUG)) { > + virtio_scsi_acquire(s); > + virtio_scsi_push_event(s, sd, > + VIRTIO_SCSI_T_TRANSPORT_RESET, > + VIRTIO_SCSI_EVT_RESET_REMOVED); > + scsi_bus_set_ua(&s->bus, SENSE_CODE(REPORTED_LUNS_CHANGED)); > + virtio_scsi_release(s); > + } > } s, sd and s->bus are all unrealized at this point, whereas before this patch they were still realized. I couldn't find any practical problem with it, but it made me nervous enough that I thought I should comment on it at least. Should we maybe have documentation on these functions that says that they accept unrealized objects as their parameters? Kevin From xen-devel-bounces@lists.xenproject.org Tue May 02 15:43:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 15:43:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528732.822245 (Exim 4.92) (envelope-from ) id 1pts9j-0007ca-IS; Tue, 02 May 2023 15:43:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528732.822245; Tue, 02 May 2023 15:43:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pts9j-0007cT-Fi; Tue, 02 May 2023 15:43:07 +0000 Received: by outflank-mailman (input) for mailman id 528732; Tue, 02 May 2023 15:43:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pts9h-0007cN-OJ for xen-devel@lists.xenproject.org; Tue, 02 May 2023 15:43:05 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0599a117-e900-11ed-8611-37d641c3527e; Tue, 02 May 2023 17:43:03 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-647-kgZznv_pOqGm5hBR5_5Thg-1; Tue, 02 May 2023 11:42:57 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 24D3FA0F389; Tue, 2 May 2023 15:42:56 +0000 (UTC) Received: from redhat.com (unknown [10.39.193.211]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 71F17404E4AD; Tue, 2 May 2023 15:42:52 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0599a117-e900-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683042181; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xl8B7Hoag5VEXFozvo4Ia9rRJMwFaCM8mAYKxZI+zJE=; b=BF7/GlcHdRmWRANPu3gFbydxQelORZTeHJo9gofW36xmZJUiF2/HuxZfFn6728srGVGeoF diygddfxRJGOjq9KW+GrOqc9n0fOMO10Ey6TwDrx6QEZBIime9UyP+qzaD/Li9ve2vDZ0U F+qAPzgn2dkxMKuuV/GubBgQrclKbCE= X-MC-Unique: kgZznv_pOqGm5hBR5_5Thg-1 Date: Tue, 2 May 2023 17:42:51 +0200 From: Kevin Wolf To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Juan Quintela , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Richard Henderson , Fam Zheng , "Michael S. Tsirkin" , Coiby Xu , David Woodhouse , Marcel Apfelbaum , Peter Lieven , Paul Durrant , "Richard W.M. Jones" , qemu-block@nongnu.org, Stefano Garzarella , Anthony Perard , Stefan Weil , Xie Yongji , Paolo Bonzini , Aarushi Mehta , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Eduardo Habkost , Stefano Stabellini , Hanna Reitz , Ronnie Sahlberg Subject: Re: [PATCH v4 06/20] block/export: wait for vhost-user-blk requests when draining Message-ID: References: <20230425172716.1033562-1-stefanha@redhat.com> <20230425172716.1033562-7-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230425172716.1033562-7-stefanha@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 Am 25.04.2023 um 19:27 hat Stefan Hajnoczi geschrieben: > Each vhost-user-blk request runs in a coroutine. When the BlockBackend > enters a drained section we need to enter a quiescent state. Currently > any in-flight requests race with bdrv_drained_begin() because it is > unaware of vhost-user-blk requests. > > When blk_co_preadv/pwritev()/etc returns it wakes the > bdrv_drained_begin() thread but vhost-user-blk request processing has > not yet finished. The request coroutine continues executing while the > main loop thread thinks it is in a drained section. > > One example where this is unsafe is for blk_set_aio_context() where > bdrv_drained_begin() is called before .aio_context_detached() and > .aio_context_attach(). If request coroutines are still running after > bdrv_drained_begin(), then the AioContext could change underneath them > and they race with new requests processed in the new AioContext. This > could lead to virtqueue corruption, for example. > > (This example is theoretical, I came across this while reading the > code and have not tried to reproduce it.) > > It's easy to make bdrv_drained_begin() wait for in-flight requests: add > a .drained_poll() callback that checks the VuServer's in-flight counter. > VuServer just needs an API that returns true when there are requests in > flight. The in-flight counter needs to be atomic. > > Signed-off-by: Stefan Hajnoczi > --- > include/qemu/vhost-user-server.h | 4 +++- > block/export/vhost-user-blk-server.c | 16 ++++++++++++++++ > util/vhost-user-server.c | 14 ++++++++++---- > 3 files changed, 29 insertions(+), 5 deletions(-) > > diff --git a/include/qemu/vhost-user-server.h b/include/qemu/vhost-user-server.h > index bc0ac9ddb6..b1c1cda886 100644 > --- a/include/qemu/vhost-user-server.h > +++ b/include/qemu/vhost-user-server.h > @@ -40,8 +40,9 @@ typedef struct { > int max_queues; > const VuDevIface *vu_iface; > > + unsigned int in_flight; /* atomic */ > + > /* Protected by ctx lock */ > - unsigned int in_flight; > bool wait_idle; > VuDev vu_dev; > QIOChannel *ioc; /* The I/O channel with the client */ > @@ -62,6 +63,7 @@ void vhost_user_server_stop(VuServer *server); > > void vhost_user_server_inc_in_flight(VuServer *server); > void vhost_user_server_dec_in_flight(VuServer *server); > +bool vhost_user_server_has_in_flight(VuServer *server); > > void vhost_user_server_attach_aio_context(VuServer *server, AioContext *ctx); > void vhost_user_server_detach_aio_context(VuServer *server); > diff --git a/block/export/vhost-user-blk-server.c b/block/export/vhost-user-blk-server.c > index 841acb36e3..092b86aae4 100644 > --- a/block/export/vhost-user-blk-server.c > +++ b/block/export/vhost-user-blk-server.c > @@ -272,7 +272,20 @@ static void vu_blk_exp_resize(void *opaque) > vu_config_change_msg(&vexp->vu_server.vu_dev); > } > > +/* > + * Ensures that bdrv_drained_begin() waits until in-flight requests complete. > + * > + * Called with vexp->export.ctx acquired. > + */ > +static bool vu_blk_drained_poll(void *opaque) > +{ > + VuBlkExport *vexp = opaque; > + > + return vhost_user_server_has_in_flight(&vexp->vu_server); > +} > + > static const BlockDevOps vu_blk_dev_ops = { > + .drained_poll = vu_blk_drained_poll, > .resize_cb = vu_blk_exp_resize, > }; You're adding a new function pointer to an existing BlockDevOps... > @@ -314,6 +327,7 @@ static int vu_blk_exp_create(BlockExport *exp, BlockExportOptions *opts, > vu_blk_initialize_config(blk_bs(exp->blk), &vexp->blkcfg, > logical_block_size, num_queues); > > + blk_set_dev_ops(exp->blk, &vu_blk_dev_ops, vexp); > blk_add_aio_context_notifier(exp->blk, blk_aio_attached, blk_aio_detach, > vexp); > > blk_set_dev_ops(exp->blk, &vu_blk_dev_ops, vexp); ..but still add a second blk_set_dev_ops(). Maybe a bad merge conflict resolution with commit ca858a5fe94? > @@ -323,6 +337,7 @@ static int vu_blk_exp_create(BlockExport *exp, BlockExportOptions *opts, > num_queues, &vu_blk_iface, errp)) { > blk_remove_aio_context_notifier(exp->blk, blk_aio_attached, > blk_aio_detach, vexp); > + blk_set_dev_ops(exp->blk, NULL, NULL); > g_free(vexp->handler.serial); > return -EADDRNOTAVAIL; > } > @@ -336,6 +351,7 @@ static void vu_blk_exp_delete(BlockExport *exp) > > blk_remove_aio_context_notifier(exp->blk, blk_aio_attached, blk_aio_detach, > vexp); > + blk_set_dev_ops(exp->blk, NULL, NULL); > g_free(vexp->handler.serial); > } These two hunks are then probably already fixes for ca858a5fe94 and should be a separate patch if so. > diff --git a/util/vhost-user-server.c b/util/vhost-user-server.c > index 1622f8cfb3..2e6b640050 100644 > --- a/util/vhost-user-server.c > +++ b/util/vhost-user-server.c > @@ -78,17 +78,23 @@ static void panic_cb(VuDev *vu_dev, const char *buf) > void vhost_user_server_inc_in_flight(VuServer *server) > { > assert(!server->wait_idle); > - server->in_flight++; > + qatomic_inc(&server->in_flight); > } > > void vhost_user_server_dec_in_flight(VuServer *server) > { > - server->in_flight--; > - if (server->wait_idle && !server->in_flight) { > - aio_co_wake(server->co_trip); > + if (qatomic_fetch_dec(&server->in_flight) == 1) { > + if (server->wait_idle) { > + aio_co_wake(server->co_trip); > + } > } > } > > +bool vhost_user_server_has_in_flight(VuServer *server) > +{ > + return qatomic_load_acquire(&server->in_flight) > 0; > +} > + Any reason why you left the server->in_flight accesses in vu_client_trip() non-atomic? Kevin From xen-devel-bounces@lists.xenproject.org Tue May 02 15:58:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 15:58:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528736.822255 (Exim 4.92) (envelope-from ) id 1ptsOI-0000uJ-Ti; Tue, 02 May 2023 15:58:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528736.822255; Tue, 02 May 2023 15:58:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptsOI-0000uC-QH; Tue, 02 May 2023 15:58:10 +0000 Received: by outflank-mailman (input) for mailman id 528736; Tue, 02 May 2023 15:58:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptsOH-0000u6-Gd for xen-devel@lists.xenproject.org; Tue, 02 May 2023 15:58:10 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 201eb7ae-e902-11ed-8611-37d641c3527e; Tue, 02 May 2023 17:58:07 +0200 (CEST) Received: from mail-dm6nam10lp2100.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.100]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2023 11:58:04 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by SA1PR03MB6498.namprd03.prod.outlook.com (2603:10b6:806:1c5::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Tue, 2 May 2023 15:58:00 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec%3]) with mapi id 15.20.6340.031; Tue, 2 May 2023 15:58:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 201eb7ae-e902-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683043087; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=VKhzaoHzMpkPI2oR0wG+B/3Pp4LdVNlAg8bUSXN0pJ0=; b=gwerr6cexusN8GPWctBfh5FzBp6x3ylsDBqCXFyqpwVg62oRb26kM29G tDEgB+KeedChZU3vGWWd+2FYNVXn6y7Y2xqi4zFkdZARku/ZF3dpaLvEi 7dEoDd+dZDzP764j6eTTQcT+31moiYBkmAnMBCufAnJirOCWIWBkR5X5+ E=; X-IronPort-RemoteIP: 104.47.58.100 X-IronPort-MID: 108008988 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:7FKgqqo7gnbY1C1D+urO8uX5ByBeBmLAZBIvgKrLsJaIsI4StFCzt garIBnVbvjZYDb2L9Aia9/j9UpT65bWndFlSFRsrypnQyNE8ZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WJwUmAWP6gR5weDzyNNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXABIEcCCfpPOT+6i6FOpvuOIMLNvBGapK7xmMzRmBZRonabbqZvySoPN9gnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeiraYKNEjCJbZw9ckKwv GXJ8n6/GhgHHNee1SCE4jSngeqncSbTAdpCTOXop6466LGV7lIVLBoTaXuUmqSat2iwYslPK RRL1DV7+MDe82TuFLERRSaQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3Oc0SiYtz UShhM7yCHpkt7j9YWmG6r6eoDe2OC4UBWwPfykJSU0C+daLiIY3gxHUR9BvCpmpn8b1EjH9x TONhCUmjrBVhskOv42y7VrAjhqvq4LPQwpz6ga/Y46+xgZwZYrga4n271HetK5ENNzAFgHHu 2UYkc+D6uxIFYuKiCGGXOQKGveu+uqBNzrfx1VoGvHN6giQxpJqRqgIiBkWGaujGpxslePBC KMLhT5s2Q== IronPort-HdrOrdr: A9a23:6xcJG6t5EXH8F1FhSsRe4IlT7skCF4Aji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJhBo7+90We7MBbhHLpOkPEs1NaZLXDbUQ6TQL2KgrGD/9SNIVycygcZ79 YaT0EcMqyNMbEZt7ec3ODQKb9Jrri6GeKT9IHjJh9WPHxXgspbnmNE42igYy9LrF4sP+tCKH PQ3Lswm9LmEk5nHviTNz0gZazuttfLnJXpbVovAAMm0hCHiXeF+aP3CB+R2zYZSndqza05+W bIvgTl7uH72svLgCP05iv21dB7idHhwtxMCIiljdUUECzljkKFdZlsQLqLuREyuaWK5EwxmN fBjh88N4BY6m/XfEuyvRzxsjOQmwoG2jvH8xu1kHHjqcv2SHYTDNdAv5tQdl/851A7tN9x/a pX1ybB3qAnRS/orWDY3ZzlRhtqnk27rT4LlvMStWVWVc87ZKVKpYIS0UtJGNMrHT786qogDO 5yZfusrcp+QBe/VTT0r2NvyNujUjAaGQqHeFELvoiv3z1fjBlCvj4l7f1auk1F2IM2SpFC6e iBGL9vjqtyQsgfar84LPsdQOOsY1a9Dy7kASa3GxDKBasHM3XCp9rc+7Mu/tynf5QO0d8bhI nBalVFrmQ/EnieRvFm5Kc7siwlfV/NHggEkqplltpEU/zHNfbW2BS4ORETe5DKmYRbPiXZM8 zDSq6+TcWTaVcGIrw5rjEWa6MiVkX2b/dlxOrTe2j+1v4jebeawdDzQbL0GIfHNwoCdyfWPk YjNQKDV/moqHrbF0PFvA== X-Talos-CUID: 9a23:L42GzG/Zg9W9tYnDPX6Vv2wdBPA5UWz4923RfUy7N0BGSK+/bHbFrQ== X-Talos-MUID: 9a23:YJ+q+QlxQOhbxWGimefsdnpcMuNv5piOJ3tQsqggtfCfJS4oZBmC2WE= X-IronPort-AV: E=Sophos;i="5.99,244,1677560400"; d="scan'208";a="108008988" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lo8U/uUvEB2ha2pgKN9vjq0+YRDvxQZVObgj6yJiMjJGwAvBarm+m9xtTOOi1JPhIUJJ/BXiNHofuaH74vKDaOKD2nB2nMN13Q+B6COn/bFnjiqCP7AtGnWdno6wWW49s72hNeRUB+0bA2bKTGTMdVWdAaA3FOVbpi39n7bGg7AlIAK9gkUHZr1Ra1ZEwAjDtcli3s9Dw5yzAE0aOD0KRL5edgUNYMDcUgU0FhsCBp7SLyalwsuxtZcfPxNH9yZnaMX8pvXEUFErg2li7Bk83SRdlc59bschA2zh2pXgPvlZZcVnsPPszxLFNCfE5hx8jPVqKT2bgbbgOd1qj/s+4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/QaIJbAvvaRh5Q90NiE5lmpweIBxxS9Nnf6nV7wK/SM=; b=d9fNLDW7+RpPR9dIp2ln/p3e6qODtN8CwUotzM3u51766kRzXux15W/oRUQm12ecxBTb8mgropqb19+xPP+HV9XEt0Y8lmCQk5ZDfFAX5GJW3HVzpgnWgRCCHKqNuMW0wZewLzABhFVGAOzq/sZwvNqEvaAp/4ReSzjA1AoCHYT/On7WFVL7aYNxskwBIxGvAwc6nNdPdVKu4SQ/Ed6lJxHkNKnE3m3/BPHGUL7NPeBxtBGCLJkZ2uOQ12c5xuavCyv3CR2L90NXnFy+aBEVae+6Wb6ueDRiNrqYOSHGXmPP4Lkvt32HDC5NDf1GRqgt3+mPnlFyO6xx00/5w/Jwyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/QaIJbAvvaRh5Q90NiE5lmpweIBxxS9Nnf6nV7wK/SM=; b=ifWJ3IR985Qh0FmHNHWrEEvj0/y/LWC7L/bct0obu712Of20dmh8lyramXtdHWpVYw3sOpWZXhTt0XUPnrPQzh6/3ZK9T9DTBBsSVYMHLLofsXZZ86+uJr+C0p9V51r5bVlEBWggCrlWbpYG5kghW+CI0RixziqfPXN2D1kaqHQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 2 May 2023 17:57:54 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Ross Lagerwall Cc: xen-devel@lists.xenproject.org, jgross@suse.com, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, axboe@kernel.dk Subject: Re: [PATCH] xen/blkfront: Only check REQ_FUA for writes Message-ID: References: <20230426164005.2213139-1-ross.lagerwall@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230426164005.2213139-1-ross.lagerwall@citrix.com> X-ClientProxiedBy: LO4P265CA0153.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c7::16) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|SA1PR03MB6498:EE_ X-MS-Office365-Filtering-Correlation-Id: 3f5dad1b-c9b4-4298-a16e-08db4b2600d2 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G2YnfR7bHaOMhnzA5rW4sSzuvCAFc1PDplUnlznmaMEIe2j7GUFb0MeyzC+glt6Z44GPSXlyOTWpI9O2bukoSWhhfrm3uZG1jAjVKHzMi5nnGcJAq+zbEx26qgNfrjT8pelyT8kouZReq/YVz/NH3pEumwOt8cVIHbSaA9KbXM9qBhp3Yrd5i7M284ezSd/EIy61Pfeb1k6R4KTPABms9nMED4f4mJ0iQcHUTYoQJ/Wkdg45SHhpgwNH1FejZzLn0aekonK440HoP+RyLCkJ4dtpYbZlOeHXh9duLI0bg81cRLTqHkF7fGbxRMhGA1zDN3/I4zftWwTN5RZTCL3o1OlYHv119E/1IwORu42F7zPKOyEnVbYfxzUl3W3DWtK/RwBFAc5G6P2hoyR+kvnOo6Az83EHtjqkuxY4NyNomUFEK2Qt8nrRGLtAaO6sdp7+TgSllu0L8RXWdQgvKY6UnbIkq37RddzM/guEViwO/5RFNVfErT2RIHUPQQjZwlKwkJ+ea7MUk+fssnaSzIl3Z6tT1+25/35TZR1CRrbf83primg/LzlC9vlXKpKm3DGr X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(7916004)(346002)(376002)(396003)(366004)(39860400002)(136003)(451199021)(33716001)(83380400001)(85182001)(66946007)(66556008)(66476007)(38100700002)(41300700001)(82960400001)(4326008)(316002)(186003)(9686003)(6506007)(478600001)(6636002)(86362001)(6512007)(26005)(5660300002)(6862004)(8676002)(8936002)(2906002)(6666004)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YVBwS1Z6T1N4cm1lZnRvc0EyQW1hK1FpOHZJczUrVHFMRE1TbGNmbUE3aTFv?= =?utf-8?B?YWFUSWVCYlNsVDg4eDcrRWVkdGlyYThWdlZYcWdsTFVYRUJhRUVmNXNYektj?= =?utf-8?B?US9ab29tTlJUMUx0aWYxWHBwcXpsdGFsTFNGYmNzK1dueTc0Q0ovL1lCd3pT?= =?utf-8?B?ajRqWW9NTkQzcHc5OWYyMUE4ekEydXBaY1BKOEpaNXJnQ3c2MUhRRUJnS2RB?= =?utf-8?B?dHBldGZUQ0Y2dTREVm5rSjZnNUR0eGpHNmNSeTcydXdKYzU2bFdrSU9aaGZk?= =?utf-8?B?c09ydVdtQTlYb1Z3STl3ay9VbmVrMVRvY0JlUkJXUG1PVktpbDQvZENGNjRt?= =?utf-8?B?dm11eUxmVWZwRllLV0ZIVEMrcnZKaDkrSnAxYUtsaWFQQlZ4L3MyWmJHSVd0?= =?utf-8?B?dWIyVEUvaFlRQ0c0TXBDNjA0T0NBV2s5dVQwdnhCbTZ5L3IrVUtvcDM1Z0dq?= =?utf-8?B?Nk5wWW9xdk56Q01lSXE5cWJ6YW1DT08vaEs5ei9JeDZuMjBSNEhvU1hqSHd5?= =?utf-8?B?YTZVRmpTQmx0TDdzSXhMa2w3a2tWWm5mSmhzaVByc0gwVHU3SFZaNU5HdzNF?= =?utf-8?B?WnJYOElBanI2MGxvS1NHOHZHaTZlckpJZ1c3b1V6WC94ekQrTVJXK2Y0NENo?= =?utf-8?B?eWJqSnlIUmF4SVJubWIyamdPSGFkZTNRREZ5UXNnNUlEaTBjZWV2KzFXUnkv?= =?utf-8?B?dDFNSFNGeGZ6aGFZV0R0SDR4VVhjd3hNd0QyYzYycXBpdXRiY1g2MXgrYzF3?= =?utf-8?B?VnV0Nk5FVzBMZGowY2tSYkpMcVZXT3JyT2kxNWt5RFhUYVI0bm1LNk9xb0xG?= =?utf-8?B?bjE3SVlDZ1lYYXhKOXdiTk5MMmFUY2F3b1JiL2hiZG1JSG94cm51SDVMMWFj?= =?utf-8?B?QVFybnlmQ21qek9qS1o0N3NGTGdIRitZRWw5RzM4R1JVbERCSUtlcU1VRWpK?= =?utf-8?B?UldTOTkyYlZPZWg4U01CMTAxeit5MmJwUjBVUjdPZlpKK2VoWmpramRiUW8w?= =?utf-8?B?L2FqdTRpd2VtN2s5RnFxWWEzVTFXL2hlUFM0RExUOGFkcVgvVUhBdHR2bVBG?= =?utf-8?B?aVVmL3lXdllIMmVhVStKaHJOKzNoSFZ3anpBamd3cUdSRzlOTU5nMnNXQ1Zy?= =?utf-8?B?SDZDWldBN3k1cmNUajRYQ2pYSXhTVDVyVWJoS0lSbDY4OGk4L1NiTksyZVMy?= =?utf-8?B?ZytGSHgxM1hrb2ViangvR2JjeVhrc0trNFJFYXN1WkwvcTd3dWR5bzMxeEFv?= =?utf-8?B?S1ZkdU9nUUE2dHp6V1VUZFo1dUhBcERDZ2xHQXVlRFFWZFJUd2doYmdYSi80?= =?utf-8?B?NHB0dTEvOXoxUTFsQU5aakhjeU9tMXhqNlk3SUNmL1Y1anZpc1lCN0NTMVF1?= =?utf-8?B?QTJGUFpXbHVRelZnSDNTa3NVK240UmIvY1IvUDdGRFlaRVNKanJSc01aZTR5?= =?utf-8?B?Q2NiTkNaNlQ1bk5KL0lCSXBJTVNIWmpoVHZtNmhVMG9lTjdwYWhzVE1OQzVI?= =?utf-8?B?ckMwRFBzcGVjaVNFZDJYdUhmWEkrcXhFTU9Ra3l5bkhEUkorU0JFZzFFQWQ0?= =?utf-8?B?d3lRc3Z3aUNPM2Z0ZUhUQ05xR1dvVHl2S1E1NVNJSHcyeFhDclZCSTM3UlUz?= =?utf-8?B?TmdlNnMrQ1ZIQi9Xd016VWNLWjJkdWlqMG1JTXFtQkdlZ2FSN250TjhhY1dh?= =?utf-8?B?bVg1bXlidkw4N0N5SXJab2QwejkyeDdMWjVMUGVsMTlnMjhGNHFnM3NnVllu?= =?utf-8?B?L2VBZ1lYUjNUMTBNKzVEemIwSnJPWDNEUkF6bnZiU2ZicEJycFlBdTA1ZEhp?= =?utf-8?B?OG4yUXVLU3hNR1cyRndrYzI5bUxRVFBhL1Q0TmF0aDYrTXFlMk5hc3VKRVc0?= =?utf-8?B?RlF4c290NEpuWHpXRlNydnBLM2JuekRqSTNUUGZ6bHNRV3RvcWZGVEcwYjFC?= =?utf-8?B?WVA5U3o1UGJMRU5tcndmMTQ4T0ZHaDJKaDJMK2lOMEJnaTBGZjFoUnROQzlF?= =?utf-8?B?NTFUbnMwb3J0TEZCVTBWb0hiZ3Joc1RZWHVNSlZBcjZ6V0VWcUhVZFRuRktJ?= =?utf-8?B?L2cydXFaaXVqSU9yTFZ4V2pDM2Q4WXBQTVh5QjRaUy9sMXdiSEZKS25BRnoz?= =?utf-8?B?SURRZyttb0pDekVKSzVsdFJvNWpBVGlzc2hzeWtIeGZKZUU5ZkpDMnBjc0Zy?= =?utf-8?B?TlE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: vJTrFmE//FTHUYox9LJde1JcozRR+cxMuvIo6QBYlVn5CJFsplXSmgq76QSm/VRFRd71BhMoTaCKTsKRXmb6oRq6impkUxOxM6YEH8WLOmAXX34WprSGX0azqhIb2uL5XlmtJI4GmrZKw2kb5j/8ChKmyDrJu1jlyLrR0C/IqIe/eg2MxNfkHiw//Geuyq3KYc4VXJaedX5MHpJSwee+KRldiPytykx6aXBMwFs7Olhn5wiLs4wnQKfW+sNmrfuYEyDFhtBgxKFsXSBZKrA/LqI4u76s+xxpLeP6pojQ5CDlGKCkDIHiuflQju0quDyllpn772NLEF1BVf4kCYgWwhwPs24sQxl1eNdVdkcEfZK2jc5Vb2w81GJ6CtHU7h0FW4om6bFuPkOf4ZXgjO4jjy3CzoTBaYHFFM3clXf7my/SVnpLPlxEGEFYYJL+3eN4Inz4go95pRuMiS4/Dhuvf/oOCQeSCOfKhVFyGUDcrTSnjCxMESXA41ivr35WOiWuYGvNzci/dpVtHK9JfSzjQ57SQUoq5yRttaL9dmbtpGJv4b3e1Vi2Bq34G0D7gc5QJXuCGb6MQ9TqUEZB918oLivQfIhWEAfKq0jw5BqimvM1Y7nBDqzqPuFzslLxfrWmQB3urdAD3LBx19QooHfOX0LbjFEQc9rpK1GPuFnplobDJer3CV/lJUIs6l/kqNV8gj+9vbsL0LfbrNfoIBwkMo4M93ECWsEFd097T5hnBtUU7ufpbcuFRDY1dr6nmzop2UZJjOZxyKAsOYPL20Ds6q9aMWHg+ViYKjbLUlrRtinAhP8WjGRZBkSBfUkjtXK4H2eDeAF2wd0SoXmLW4p1z/Qr55VshRHWJveC6prrE7tNnY+bhO6IHnwZWOBtuyru X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3f5dad1b-c9b4-4298-a16e-08db4b2600d2 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 15:58:00.0789 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hMmq9He7APaTLki7WDsWHmuS7BCyNRWf0mFhPtQLJiDzl0WDFJV7yOQzrNGeYHpol5j5ov1lEwi3ba1yaCKSzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6498 On Wed, Apr 26, 2023 at 05:40:05PM +0100, Ross Lagerwall wrote: > The existing code silently converts read operations with the > REQ_FUA bit set into write-barrier operations. This results in data > loss as the backend scribbles zeroes over the data instead of returning > it. > > While the REQ_FUA bit doesn't make sense on a read operation, at least > one well-known out-of-tree kernel module does set it and since it > results in data loss, let's be safe here and only look at REQ_FUA for > writes. Do we know what's the intention of the out-of-tree kernel module with it's usage of FUA for reads? Should this maybe be translated to a pair of flush cache and read requests? > Signed-off-by: Ross Lagerwall > --- > drivers/block/xen-blkfront.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c > index 23ed258b57f0..c1890c8a9f6e 100644 > --- a/drivers/block/xen-blkfront.c > +++ b/drivers/block/xen-blkfront.c > @@ -780,7 +780,8 @@ static int blkif_queue_rw_req(struct request *req, struct blkfront_ring_info *ri > ring_req->u.rw.handle = info->handle; > ring_req->operation = rq_data_dir(req) ? > BLKIF_OP_WRITE : BLKIF_OP_READ; > - if (req_op(req) == REQ_OP_FLUSH || req->cmd_flags & REQ_FUA) { > + if (req_op(req) == REQ_OP_FLUSH || > + (req_op(req) == REQ_OP_WRITE && (req->cmd_flags & REQ_FUA))) { Should we print some kind of warning maybe once that we have received a READ request with the FUA flag set, and the FUA flag will have no effect? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 02 16:04:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 16:04:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528741.822265 (Exim 4.92) (envelope-from ) id 1ptsUa-00031s-MG; Tue, 02 May 2023 16:04:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528741.822265; Tue, 02 May 2023 16:04:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptsUa-00031l-Jj; Tue, 02 May 2023 16:04:40 +0000 Received: by outflank-mailman (input) for mailman id 528741; Tue, 02 May 2023 16:04:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptsUZ-00031f-JT for xen-devel@lists.xenproject.org; Tue, 02 May 2023 16:04:39 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 09774b34-e903-11ed-b225-6b7b168915f2; Tue, 02 May 2023 18:04:38 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-199-NtVPAAg0PAGoLecNFhMJ8Q-1; Tue, 02 May 2023 12:04:32 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 506A218E5380; Tue, 2 May 2023 16:04:30 +0000 (UTC) Received: from redhat.com (unknown [10.39.193.211]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 77F2C1410F24; Tue, 2 May 2023 16:04:25 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 09774b34-e903-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683043477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ErZ2aQ2HUcNIqx2OSDpVI+Y5PzprxF1vRVAtic0RH4k=; b=KE7Bk8VEeG9NygJUkXVwLlCiYy5VWZfuL2kxlSIw6xNPU49FIyHa9ojuCT7JdUuP947y1V OOlUFPHTj8ZhUfksOyJpyUB0tMWWn5orR0JIQMSwydx7l2tQluaTvQF2ECAtv+nNbCgQ1F IUiMqApS8TFdxszmy+aRqJhcPOhkf0Y= X-MC-Unique: NtVPAAg0PAGoLecNFhMJ8Q-1 Date: Tue, 2 May 2023 18:04:24 +0200 From: Kevin Wolf To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Juan Quintela , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Richard Henderson , Fam Zheng , "Michael S. Tsirkin" , Coiby Xu , David Woodhouse , Marcel Apfelbaum , Peter Lieven , Paul Durrant , "Richard W.M. Jones" , qemu-block@nongnu.org, Stefano Garzarella , Anthony Perard , Stefan Weil , Xie Yongji , Paolo Bonzini , Aarushi Mehta , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Eduardo Habkost , Stefano Stabellini , Hanna Reitz , Ronnie Sahlberg Subject: Re: [PATCH v4 07/20] block/export: stop using is_external in vhost-user-blk server Message-ID: References: <20230425172716.1033562-1-stefanha@redhat.com> <20230425172716.1033562-8-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230425172716.1033562-8-stefanha@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 Am 25.04.2023 um 19:27 hat Stefan Hajnoczi geschrieben: > vhost-user activity must be suspended during bdrv_drained_begin/end(). > This prevents new requests from interfering with whatever is happening > in the drained section. > > Previously this was done using aio_set_fd_handler()'s is_external > argument. In a multi-queue block layer world the aio_disable_external() > API cannot be used since multiple AioContext may be processing I/O, not > just one. > > Switch to BlockDevOps->drained_begin/end() callbacks. > > Signed-off-by: Stefan Hajnoczi > --- > block/export/vhost-user-blk-server.c | 43 ++++++++++++++-------------- > util/vhost-user-server.c | 10 +++---- > 2 files changed, 26 insertions(+), 27 deletions(-) > > diff --git a/block/export/vhost-user-blk-server.c b/block/export/vhost-user-blk-server.c > index 092b86aae4..d20f69cd74 100644 > --- a/block/export/vhost-user-blk-server.c > +++ b/block/export/vhost-user-blk-server.c > @@ -208,22 +208,6 @@ static const VuDevIface vu_blk_iface = { > .process_msg = vu_blk_process_msg, > }; > > -static void blk_aio_attached(AioContext *ctx, void *opaque) > -{ > - VuBlkExport *vexp = opaque; > - > - vexp->export.ctx = ctx; > - vhost_user_server_attach_aio_context(&vexp->vu_server, ctx); > -} > - > -static void blk_aio_detach(void *opaque) > -{ > - VuBlkExport *vexp = opaque; > - > - vhost_user_server_detach_aio_context(&vexp->vu_server); > - vexp->export.ctx = NULL; > -} So for changing the AioContext, we now rely on the fact that the node to be changed is always drained, so the drain callbacks implicitly cover this case, too? > static void > vu_blk_initialize_config(BlockDriverState *bs, > struct virtio_blk_config *config, > @@ -272,6 +256,25 @@ static void vu_blk_exp_resize(void *opaque) > vu_config_change_msg(&vexp->vu_server.vu_dev); > } > > +/* Called with vexp->export.ctx acquired */ > +static void vu_blk_drained_begin(void *opaque) > +{ > + VuBlkExport *vexp = opaque; > + > + vhost_user_server_detach_aio_context(&vexp->vu_server); > +} Compared to the old code, we're losing the vexp->export.ctx = NULL. This is correct at this point because after drained_begin we still keep processing requests until we arrive at a quiescent state. However, if we detach the AioContext because we're deleting the iothread, won't we end up with a dangling pointer in vexp->export.ctx? Or can we be certain that nothing interesting happens before drained_end updates it with a new valid pointer again? Kevin From xen-devel-bounces@lists.xenproject.org Tue May 02 16:14:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 16:14:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528746.822275 (Exim 4.92) (envelope-from ) id 1ptsdy-0004al-JZ; Tue, 02 May 2023 16:14:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528746.822275; Tue, 02 May 2023 16:14:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptsdy-0004ae-GS; Tue, 02 May 2023 16:14:22 +0000 Received: by outflank-mailman (input) for mailman id 528746; Tue, 02 May 2023 16:14:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptsdx-0004aY-1E for xen-devel@lists.xenproject.org; Tue, 02 May 2023 16:14:21 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 63048d9b-e904-11ed-8611-37d641c3527e; Tue, 02 May 2023 18:14:18 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 63048d9b-e904-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683044058; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=dlVsysxRrIKNoi35lH/qtyIF3TPOuG6EK6kie+J/XDs=; b=aKoANNoc/vLWoTEs6sGNeqOLhl2p50rd9HgJj7dkf5UnMTEjNzfjIPlf uadU+La7pvCD5YwE3jwQUNDYmpZbgDnsd+XrFjnO6mY81dYj2NLoNo6ZF P92YxuqV3H3MM5zoBqp5a6piS55vDr/1g8i13vOROwCoGxRKnaGjWdKFb M=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 110045256 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:c9ANzqD0YxOYnRVW/6jiw5YqxClBgxIJ4kV8jS/XYbTApDIi3jIHn 2AcD2mPO/qKajD1e9lxbdvg9B5TsMWDyt9hQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFuspvlDs15K6p4G5A5ARkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw59x0JGdv5 KYhNTkQbhOsgP+k/pC4Rbw57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2M1N3wsYDUWUrsTIJs4gOevgGi5azBCoUiZjaE2/3LS3Ep6172F3N/9I4XSHZkIxBvGz o7A10P3WzNBKPLC9RSY/kuwn/7i2hznQp1HQdVU8dYv2jV/3Fc7DAAdXB21qP+yh0q6RvpWM UlS8S0rxYAi+UruQtTjUhmQpH+fogVaS9dWC/c96gyG1uzT+QnxLmIJVCJbYdoq8so/XyU31 0ShlsnsQzdotdW9Vn+csLyUoDWaMDIQa2QFYEcsVwwe6cPkp4I1ph3KR9dnVqWyi7XdBjXY0 z2M6i8kiN07j8ER0L6g1UvamD/qrZ/MJiY57xvadnio5QR4YMiifYPAwV3S9/NJNouaZliHo nkfmsKa4fwODJeCjyiESqMGG7TBz/+dPSfVm1JHA5gr/DPr8HmmFb28+xkneh0vaJxdP2a0P gmK41g5CIJvAUZGpJRfO+qZY/nGB4C5S7wJiti8ggJyX6VM IronPort-HdrOrdr: A9a23:fG0L0qsGgBbImt6lLOkPInQ57skC8IMji2hC6mlwRA09TyXGra 6TdaUguiMc1gx8ZJh5o6H9BEGBKUmskaKdkrNhQotKPTOW9VdASbsC0WKM+UyZJ8STzJ8+6U 4kSdkCNDSSNyk3sS+Z2njCLz9I+rDum8rE5Za8854ud3ARV0gJ1XY+Nu/xKDwQeOAyP+tBKH Pq3Lsgm9PPQwVzUu2LQl0+G8TTrdzCk5zrJTQcAQQ81QWIhTS0rJbnDhmxxH4lInxy6IZn1V KAvx3y562lvf3+4ATbzXXv45Nfn8ak4sdfBfaLltMeJlzX+0iVjcVaKvy/VQIO0aKSAWUR4Z vxStAbToFOAkbqDyGISN3Wqk3dOXgVmjjfIBSj8AXeSITCNUMH4ox69Ntkm1LimjodlcA536 RR022DsZ1LSRvGgSTm/tDNEwpnj0yuvBMZ4KYuZlFkIP0jgYVq3MUi1VIQFI1FEDPx6YghHu UrBMbA5OxOeVffa3zCpGFgzNGlQ3x2R369MwI/k93Q1yITkGFyzkMeysBalnAc9IglQ50B4+ jfKKxnmLxHU8dTZ6NgA+UKR9exFwX2MFnxGXPXJU6iGLAMOnrLpZKy6LIp5PuycJhN15c2kI SpaiIuiYfzQTObNSSj5uw/zvmWehTPYd3E8LAt26RE X-Talos-CUID: =?us-ascii?q?9a23=3AgKksxmu5dlxP0KgktlxOAtUK6Is4SH74ylbBeXa?= =?us-ascii?q?lAHtpS5KSVE2u2qBrxp8=3D?= X-Talos-MUID: =?us-ascii?q?9a23=3AhGkI6Q1fni7zQzgbHEgnroynEjUjxKr3KhsRv8g?= =?us-ascii?q?6ldSIDDBpKhrasyitXdpy?= X-IronPort-AV: E=Sophos;i="5.99,244,1677560400"; d="scan'208";a="110045256" Date: Tue, 2 May 2023 17:13:41 +0100 From: Anthony PERARD To: Luca Fancellu CC: , , , George Dunlap , Nick Rosbrook , Wei Liu , Juergen Gross , Christian Lindig , David Scott , Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= , Christian Lindig Subject: Re: [PATCH v6 09/12] tools: add physinfo arch_capabilities handling for Arm Message-ID: <4e6758c0-dd81-4963-8989-d941eba2b257@perard> References: <20230424060248.1488859-1-luca.fancellu@arm.com> <20230424060248.1488859-10-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230424060248.1488859-10-luca.fancellu@arm.com> On Mon, Apr 24, 2023 at 07:02:45AM +0100, Luca Fancellu wrote: > diff --git a/tools/include/xen-tools/arm-arch-capabilities.h b/tools/include/xen-tools/arm-arch-capabilities.h > new file mode 100644 > index 000000000000..ac44c8b14344 > --- /dev/null > +++ b/tools/include/xen-tools/arm-arch-capabilities.h > @@ -0,0 +1,28 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ Do you mean GPL-2.0-only ? GPL-2.0 is deprecated by the SPDX project. https://spdx.org/licenses/GPL-2.0.html Besides that, patch looks fine: Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue May 02 16:21:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 16:21:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528751.822285 (Exim 4.92) (envelope-from ) id 1ptsky-00068t-9y; Tue, 02 May 2023 16:21:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528751.822285; Tue, 02 May 2023 16:21:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptsky-00068m-7O; Tue, 02 May 2023 16:21:36 +0000 Received: by outflank-mailman (input) for mailman id 528751; Tue, 02 May 2023 16:21:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptskw-00068e-A8 for xen-devel@lists.xenproject.org; Tue, 02 May 2023 16:21:34 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6676d4a3-e905-11ed-b225-6b7b168915f2; Tue, 02 May 2023 18:21:33 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-248-XFbx3vdZP5Ky0DHbFh4gXA-1; Tue, 02 May 2023 12:21:28 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C753C2807D63; Tue, 2 May 2023 16:21:25 +0000 (UTC) Received: from redhat.com (unknown [10.39.193.211]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E2BA563F4A; Tue, 2 May 2023 16:21:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6676d4a3-e905-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683044492; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=veAM1yxiNJOFHsx6/inor+jTVAWMkCyEti4maPSbfwU=; b=elqcCIYjAyJ6fQ5hm3szZez32Xuf5TuBjBNhoLNy8OdYZQOIjLrcCJYNmhd2TqjQcrxKGp sEIpPKmzKdZqIm1IqUJPs059aV1B4BIZaBCC00cz7vYDRjTPK87t2Bk/BvQkA25sytiDIW ycfavmAL6n7onktQP1Ct+pUPmSIxXUQ= X-MC-Unique: XFbx3vdZP5Ky0DHbFh4gXA-1 Date: Tue, 2 May 2023 18:21:20 +0200 From: Kevin Wolf To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Juan Quintela , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Richard Henderson , Fam Zheng , "Michael S. Tsirkin" , Coiby Xu , David Woodhouse , Marcel Apfelbaum , Peter Lieven , Paul Durrant , "Richard W.M. Jones" , qemu-block@nongnu.org, Stefano Garzarella , Anthony Perard , Stefan Weil , Xie Yongji , Paolo Bonzini , Aarushi Mehta , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Eduardo Habkost , Stefano Stabellini , Hanna Reitz , Ronnie Sahlberg Subject: Re: [PATCH v4 10/20] block: drain from main loop thread in bdrv_co_yield_to_drain() Message-ID: References: <20230425172716.1033562-1-stefanha@redhat.com> <20230425172716.1033562-11-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230425172716.1033562-11-stefanha@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Am 25.04.2023 um 19:27 hat Stefan Hajnoczi geschrieben: > For simplicity, always run BlockDevOps .drained_begin/end/poll() > callbacks in the main loop thread. This makes it easier to implement the > callbacks and avoids extra locks. > > Move the function pointer declarations from the I/O Code section to the > Global State section in block-backend-common.h. > > Signed-off-by: Stefan Hajnoczi If we're updating function pointers, we should probably update them in BdrvChildClass and BlockDriver, too. This means that a non-coroutine caller can't run in an iothread, not even the home iothread of the BlockDriverState. (I'm not sure if it was allowed previously. I don't think we're actually doing this, but in theory it could have worked.) Maybe put a GLOBAL_STATE_CODE() after handling the bdrv_co_yield_to_drain() case? Or would that look too odd? IO_OR_GS_CODE(); if (qemu_in_coroutine()) { bdrv_co_yield_to_drain(bs, true, parent, poll); return; } GLOBAL_STATE_CODE(); Kevin From xen-devel-bounces@lists.xenproject.org Tue May 02 16:40:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 16:40:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528754.822295 (Exim 4.92) (envelope-from ) id 1ptt3C-0000Ig-S0; Tue, 02 May 2023 16:40:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528754.822295; Tue, 02 May 2023 16:40:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptt3C-0000IZ-PG; Tue, 02 May 2023 16:40:26 +0000 Received: by outflank-mailman (input) for mailman id 528754; Tue, 02 May 2023 16:40:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptt3B-0000IQ-8V for xen-devel@lists.xenproject.org; Tue, 02 May 2023 16:40:25 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 07ec211e-e908-11ed-b225-6b7b168915f2; Tue, 02 May 2023 18:40:23 +0200 (CEST) Received: from mail-mw2nam12lp2041.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2023 12:40:21 -0400 Received: from DM6PR03MB5372.namprd03.prod.outlook.com (2603:10b6:5:24f::15) by CO1PR03MB5892.namprd03.prod.outlook.com (2603:10b6:303:9f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Tue, 2 May 2023 16:40:18 +0000 Received: from DM6PR03MB5372.namprd03.prod.outlook.com ([fe80::4418:2c5d:f218:e58]) by DM6PR03MB5372.namprd03.prod.outlook.com ([fe80::4418:2c5d:f218:e58%7]) with mapi id 15.20.6340.031; Tue, 2 May 2023 16:40:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 07ec211e-e908-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683045623; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=4mYyoRkb2KBysrxE5QbSTOtHlQEiOZdXXNJTxWMpNh8=; b=KRIcwXlYNbPPyhnYQXIR7U34Svr9dbXmRbUeCCFL2ZU8YO6LA1MurJua 9peNYMdZZAYINLF0+OUq5ICTChL1kLPKNay0rx+RjFWXE443BGBsIc4Z6 zoHjCeWNXgK9M7mdeIYXGkP2JBwIPdNiAma6u/SXv0BJdvvRrGSxUlAg6 g=; X-IronPort-RemoteIP: 104.47.66.41 X-IronPort-MID: 110048524 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:JW9YbKodScoReLkXi+lcRiD2+4NeBmL8ZBIvgKrLsJaIsI4StFCzt garIBnUPv3YYTH2ct91Pd+3/U4HuZTVmoNkTQNp/i80HnlA9JuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WJwUmAWP6gR5weDzyNNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXACIBTQuuucmY/IK+ScRhjZUqPOrZYqpK7xmMzRmBZRonabbqZvyQoPpnhnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3juarbIO9lt+iHK25mm6Co XnduWDwDRwAK9WbzRKO8262h/+JliT+MG4XPOThrqY20ADJmgT/DjUGBEOk/KGooHKFYIoCd k092QcpoIEboRnDot7VGkfQTGS/lg4RXZ9cHvM37CmJy7HI+ECJC24cVDlDZdc68sgsSlQC1 FCTmMjyLSdyq7DTQnWYnp+Pti+7MyURKW4EZAcHQBED7t2lp5s85jrISttgC6ezgsfCBSDrw zuKoS49gJ0elccOka68+DjviiKmoZXhTQMv4AjTGG6mhj6Vf6agbo2srF3Et/BJKd/DSkHb5 CRd3c+D8OoJEJeB0jSXR/kAF62o4PDDNyDAhVloHN8q8DHFF2OfQL28KQpWfC9BWvvosxeyC KMPkWu9PKNuAUY= IronPort-HdrOrdr: A9a23:N70KvqCEqzrvKHXlHela55DYdb4zR+YMi2TDt3oddfWaSKylfq GV7ZImPHrP4gr5N0tOpTntAse9qDbnhPxICOoqTNCftWvdyQiVxehZhOOP/9SjIVyaygc078 xdmsNFebnN5DZB7PoT4GODYqkdKNvsytHXuQ8JpU0dPD2DaMtbnndE4h7wKDwOeOHfb6BJaa Z14KB81kKdUEVSVOuXLF8fUdPOotXa/aiWHSLvV3YcmXKzZSrD0s+BLySl X-Talos-CUID: =?us-ascii?q?9a23=3AWrTpcWlDvgSpPDMMge7cdhOyfJPXOW/R72z9HWS?= =?us-ascii?q?WNVZsS5CYQg6Z6IBWzeM7zg=3D=3D?= X-Talos-MUID: =?us-ascii?q?9a23=3AJIwiIQ6DoQb2wlMOhyuCJ4gsxox4sryxVRgcu6k?= =?us-ascii?q?9gJHZaC1ZGBqagR2eF9o=3D?= X-IronPort-AV: E=Sophos;i="5.99,244,1677560400"; d="scan'208";a="110048524" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pt7AcETFJHnpYgkREil2HpNjnnM+VD6AqXHWcgo0Gb3zyh5CWX2qqx26fI6y6uJnSxdFXyzHxs2pzFuP+oQl6WIdsNm5gzGt9AFZADblCtUkzc5l3ldZqZcNFI7iYhCvvqXJcY5Yrsdmq15AWhIZVfCtkGPEm5pyinwzQXNK3QcFwRNdx9FwXcqQi7KG55CwV1+nSN6Hl4Wz9ZOP6BlJBHhNtH4qQHd9oKbZ7R2xI6y/RgYsThLjMTM8QKB2zvjkBrFnEetrY9aQHinX3QtQ1+U83Bo0QKbA2h4d+neirtVLsoG8dbUvYaEgxYlw46irhpM3/0NY5zwRdriIoJbY4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4mYyoRkb2KBysrxE5QbSTOtHlQEiOZdXXNJTxWMpNh8=; b=j8c1QcRoWnYQSVMzUxsedD/nGCzLkt+QT69PdIIyEKkkPijDpv7HV3bK9xrwOy7dlvBx3dOKavvAJbYNvyVRPuMjGQb6hXptWT9QwWH64H3rgQe1NYSnUBvozduVe/dXQi9S5eWGx7XyxPU+RSzBV2/55Ui7uNtagEraKQvLGW/hrQ4qVKC/XWw4KC6O2DN82j8K77AKS0+vxnbpdOsW1Ai/WZQ6Svqmi8qm3CTsxEVaE/wi1XH1g32f3GX6my4Y794VlAV3JpHIdiUXDRHve2P1Nvm4UmJEJUmvEes20GV7US7v0YobmO/Zuz9jx/p9Tqg5Y7sN6+qp0O6e59TmGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4mYyoRkb2KBysrxE5QbSTOtHlQEiOZdXXNJTxWMpNh8=; b=Xi5mFnm3sSuJU4jwnGKbAD+xlD0rtbMKCm2sV9whAWXD2pSKnIjdFp91OID8f6+oN48rWP4UTm1BxV5GlPSsoxQnxy0ZgeNq1dbzauPTR7GGdz+oTgxoNeYhc5L2uKwEHdfNXBrwIDN5beKS2sDKwRXVtLvL90ChPa5iea8OZbo= From: Ross Lagerwall To: Roger Pau Monne CC: "xen-devel@lists.xenproject.org" , "jgross@suse.com" , "sstabellini@kernel.org" , "oleksandr_tyshchenko@epam.com" , "axboe@kernel.dk" Subject: Re: [PATCH] xen/blkfront: Only check REQ_FUA for writes Thread-Topic: [PATCH] xen/blkfront: Only check REQ_FUA for writes Thread-Index: AQHZeF3Nw+6VlmAXM0WLxiEiRURXM69HLPoAgAAImgI= Date: Tue, 2 May 2023 16:40:17 +0000 Message-ID: References: <20230426164005.2213139-1-ross.lagerwall@citrix.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR03MB5372:EE_|CO1PR03MB5892:EE_ x-ms-office365-filtering-correlation-id: 0351faf7-db63-42f8-6600-08db4b2be99a x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZSGq2kmR/cv1P1xiJIMt2SrYx0bQJqV0Q/3dawkb0LY2bd8xR/0Bh2QjLQfxezpVWsjEsdClm842MrjxXxef02wZEczPm3xjxQx1Q/0ihpXGBfcAVA3es/F4mBurb4kA7iZfgGnhhlLMwx6ku7r3LMgX/wSkmvmz5bvJfkhJWsZ9qpIC/1ACnPqQeiTn2nPZUpLq6KijDLrKzpiLfnfvFDvnesBSnwziduf70FMgn0sPTNkV7Wv0/Vqcm+zDK1oYodHfMZ9Gr2c/OxSrDhoboWeOZap53fMIgJpybl24pUkvsbAk51LZkA0JhN7z8gSFBwZHkkZVSwceyhs1Np8u+MBT/v3XTqG3u+3RC8jSjVE8zl7xrxrYp+voZdqDVsXs96RH9bArNWi//CwE4XxmqT5Pj3utnwUFJWS8QYn/7BcRQuzwDBw/mv1Ddm1iGTuYnXeQAMVA+DCFhO8bXP6egpizPvvKo0qZkS7PUY+NhZW/2EtP+1341JzEzD86/7tYUeRJgmrH/PH2N/IXgLHI/inpKo5aDHjgPqvee/zrxbVqjj1JC182hVPKAHWkW/Z5W1VhoyGxoq5hcfCs9tI+tS/f96BLZWlwLHeruaHA/ls= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB5372.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(136003)(376002)(396003)(39860400002)(346002)(451199021)(66556008)(64756008)(2906002)(76116006)(66446008)(66476007)(66946007)(52536014)(86362001)(44832011)(5660300002)(8676002)(478600001)(8936002)(55016003)(91956017)(6636002)(4326008)(71200400001)(33656002)(54906003)(316002)(41300700001)(966005)(82960400001)(7696005)(122000001)(9686003)(53546011)(6506007)(186003)(83380400001)(26005)(38070700005)(6862004)(38100700002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?+Mb5GxzHf2RJQYXMthwL7DFuzgmC4BBc6lp4iK4hLGu7FkRfx1Hlf/c7Rk?= =?iso-8859-1?Q?aH2e4LZjP8DWs4w9H6xK1imwlA/Wb+bi5/v500MXcNZ0777AwcH4YD8l4l?= =?iso-8859-1?Q?rKEei7toX9KDHQTK6wXjsXiw6cTxMZLo5aQO/NtuuJcuRlsYkKNVfcgj24?= =?iso-8859-1?Q?gFijuZ49oTAwqbmV8OnUwzBr5HXfQqNQSEkAxE9xMocqkWufLbyRamAfV7?= =?iso-8859-1?Q?4GaMjE6rC2baQfTNeiaT1rg8QBk6REwodq2zvYJ6s+wEgnVf/U/MHgt1d8?= =?iso-8859-1?Q?UaUhch2nJ3x4lV4mwM70doFX6AibZflUT7wbN3hOSrFp7edq3FZ4QZ6l1L?= =?iso-8859-1?Q?L0l1EjoMnLsCKQ/yOmf8hynKzU8q6K44vSiuDPSFGNyHleWSEoMjWRhyGK?= =?iso-8859-1?Q?YsfiAkh6V+7b3PjJn0xWolUMDbPThWNx0+Lg6bmTtG6ZrMV4y7SMliGqYV?= =?iso-8859-1?Q?mDW0N52QFoijesS7nT8a2jKsjrWdNSa6zgVZ9ci/9LGEUW/SrD/nA/hUC2?= =?iso-8859-1?Q?rSTR6LlF2EniE35fwnvQts65zkwf2zYBqxIuVbXzjM553AD4X9IIMHE6oK?= =?iso-8859-1?Q?W5iaB00wKtpYN7RNiLhk6x58F9aC95MnZ1X7G20h6iBtMp2a+BPy7bRH5r?= =?iso-8859-1?Q?D0BLMjJOj4RJX2oLEgudj7GvP2eT4kRX10R/c5e8akNdByW4rVcgdVbGcF?= =?iso-8859-1?Q?2uLE17nik4qYkTlizqHn8W4nliaDr2sHD+qbthULQ4EtpkABQE8ZPV2Qln?= =?iso-8859-1?Q?oCyxH77GkVp2YrkMX/gPKzy0eBe20JOlJq6cR7rcPbcjGtEDVpcv+A/nLg?= =?iso-8859-1?Q?y+21ZInpcubQ/7tlna+kawnMzZwRd2lOUWWh+juAjFEMxFZLAr4PEgeUaD?= =?iso-8859-1?Q?sCErqe7KIm/RfrWlIK92JX9fqaworTocidOS/z7J62CksX0evF8xcgQ+pu?= =?iso-8859-1?Q?ozRR3wscG3HxVVbQB+fo8laQuUZbl/OevHu1oLL9q0+IFy7cB9bru9AWbe?= =?iso-8859-1?Q?Wd1j+RSQmIsCzsFJwAm7Iq2WobcceK8U2V+aOEZxIrQttgHon2nIFzYLAA?= =?iso-8859-1?Q?PELFSxiN1OuDpB0mMiDL0o59axi6n4xX2YSS9Y5O4Xx6GVHcCoSG3ij/MW?= =?iso-8859-1?Q?hBmOEzmId8U/hGuawmQaaf2gYHhsT7+kwjDJ4b26P71kgPahvlcWV7p5/r?= =?iso-8859-1?Q?E3xKGT2OyBz+/0evAFtYe3N+vXqLG3gLbdqrVJonZXR7rVNDE45XOZv6CY?= =?iso-8859-1?Q?JH/zhSU5upifIDW4Ps05wWayYKv7WDPaOtuFdmCNZujwinGFnultvYRwvq?= =?iso-8859-1?Q?y/mqo4pqnGTEJ3OpMJvLKW2lmzCoTGnBYwDaTSMZXPHskpgJC4iU3xXtII?= =?iso-8859-1?Q?x0UzTjSEST1HzYHICeUWlhxyaC/6ZvvJbfiqctV6Qrq5YfOVwWu9TZy7cZ?= =?iso-8859-1?Q?UG/jMv6r3rkouVue9y5pXAfnXXCO2f37qbYVxKz0UWD/94nZNRUm0pndMD?= =?iso-8859-1?Q?q7PCkVfQvXd+Ah5MLCNnaZABB5JlMeAJOQgCXuOlG/B71Z0bkKWxkRCqDV?= =?iso-8859-1?Q?WO1c4x6P7S8yoGXnhPf92IIIsLlheYHWDsOT5vAEYTnNqV8KhNkUW+RZIE?= =?iso-8859-1?Q?6SwWWyva+TlV0pyHLnP7m6Iq37C+xyiQpQ?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: eliju2Rl4GyG3YiF9I9GWR+CXfwxErVP4SObx55TQQabDr68Tz6tkl2O01HoEEuj81qotQkcPZ/86Eubm3R0jnotc0v9RJGwI2LwjvEuQqr/0OeZiJs31qxhKGU9bm7zuuvg3PQ3Pl2khwP4vU1WaDzk2t7PWsbGhGqQabTM1NnkbPLUnyFOxQPVZXXqsYg2OmI5oU+AQ0mLtftYNqaYLEEt48eoEovF/cbpXyY+PXqroql1riyXhLm6JKL2n3mDfvt/nMTQOX/C49XyrjO1oMqUP9mww3pm4vkeXJPaT8HX4QSjuWVOLxeKjFJEpgPSI9Sk+ZPUx06lHcbe38uIo9tgnBgOdOw8MWaV+QUm2s/EfzxUETn6qwPQfk+Ymd3vuBrl+Xn1b0UBvfySnxAlSYS7vxhk7qkz6DboA7IPOJLG8vE9PGqkOW4oy2TLb4NRmGDx7cFQCtq36DGB1UlYs32CaxevKyj0QasvPRkbuna7Qs4diuFk6lzthlEA0UmTY8+AvnPNhl7RESxW5K21G1C+EgdVsAevlf330wR/vLf65JGZrHic+6rhnCtmyMPgJLWLzPsovqt/FmGLsu7n2N7cdzaGctftKJNdwi379Saai3wis3/ZGmRLtWxAcTlZllkqZQxQDj3wHMFGpQUVocixgwlQ8nC31uXr1Q6RYiJpA+y9gwZFca2AyHoVaAYTEV1xvkJeg83mcLRbqv9Pu3FKZOdG53a4YkQV+MU2lZNwEggJHQUuQ11jEm/bqOxNtB0y6kvCz6qkTpUJYuzFQz+YPqXRhZ6+zh3K9bvrorGQCmp7I7UaQks/x7oPuYY/l+O8ITO+438sHO+qFpofWymH8ToO5kPztDnUbCqrqFwLvZZfYEheybjwiOMSJiYA X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB5372.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0351faf7-db63-42f8-6600-08db4b2be99a X-MS-Exchange-CrossTenant-originalarrivaltime: 02 May 2023 16:40:17.7892 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bMZAauT5joSy/R2Os63qhree6c3RugFqbGxuned7KyfmYchAU0plkj5HYz/Jg2XPIS1dws4CGSB+Shl/KhR64jzuJAlCo5CJAqIYIGvosCk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5892 > From: Roger Pau Monne =0A= > Sent: Tuesday, May 2, 2023 4:57 PM=0A= > To: Ross Lagerwall =0A= > Cc: xen-devel@lists.xenproject.org ; jgro= ss@suse.com ; sstabellini@kernel.org ; oleksandr_tyshchenko@epam.com ; axboe@k= ernel.dk =0A= > Subject: Re: [PATCH] xen/blkfront: Only check REQ_FUA for writes =0A= > =A0=0A= > On Wed, Apr 26, 2023 at 05:40:05PM +0100, Ross Lagerwall wrote:=0A= > > The existing code silently converts read operations with the=0A= > > REQ_FUA bit set into write-barrier operations. This results in data=0A= > > loss as the backend scribbles zeroes over the data instead of returning= =0A= > > it.=0A= > > =0A= > > While the REQ_FUA bit doesn't make sense on a read operation, at least= =0A= > > one well-known out-of-tree kernel module does set it and since it=0A= > > results in data loss, let's be safe here and only look at REQ_FUA for= =0A= > > writes.=0A= > =0A= > Do we know what's the intention of the out-of-tree kernel module with=0A= > it's usage of FUA for reads?=0A= =0A= It was just a plain bug that has now been fixed:=0A= =0A= https://github.com/veeam/blksnap/commit/e3b3e7369642b59e01c647934789e5e20b3= 80c62=0A= =0A= I think this patch is still worthwile since reads becoming writes is=0A= asking for data corruption.=0A= =0A= > =0A= > Should this maybe be translated to a pair of flush cache and read=0A= > requests?=0A= > =0A= > > Signed-off-by: Ross Lagerwall =0A= > > ---=0A= > >=A0 drivers/block/xen-blkfront.c | 3 ++-=0A= > >=A0 1 file changed, 2 insertions(+), 1 deletion(-)=0A= > > =0A= > > diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.= c=0A= > > index 23ed258b57f0..c1890c8a9f6e 100644=0A= > > --- a/drivers/block/xen-blkfront.c=0A= > > +++ b/drivers/block/xen-blkfront.c=0A= > > @@ -780,7 +780,8 @@ static int blkif_queue_rw_req(struct request *req, = struct blkfront_ring_info *ri=0A= > >=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 ring_req->u.rw.handle =3D = info->handle;=0A= > >=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 ring_req->operation =3D rq= _data_dir(req) ?=0A= > >=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 BL= KIF_OP_WRITE : BLKIF_OP_READ;=0A= > > -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 if (req_op(req) =3D=3D REQ_OP_FLU= SH || req->cmd_flags & REQ_FUA) {=0A= > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 if (req_op(req) =3D=3D REQ_OP_FLU= SH ||=0A= > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 (req_op(req) =3D=3D R= EQ_OP_WRITE && (req->cmd_flags & REQ_FUA))) {=0A= > =0A= > Should we print some kind of warning maybe once that we have received=0A= > a READ request with the FUA flag set, and the FUA flag will have no=0A= > effect?=0A= > =0A= =0A= I thought of adding something like this but I couldn't find any other=0A= block layer code doing a similar check (also it seems more appropriate=0A= in the core block layer).=0A= =0A= WARN_ONCE(req_op(req) !=3D REQ_OP_WRITE && (req->cmd_flags & REQ_FUA));=0A= =0A= I can add it if the maintainers want it.=0A= =0A= Thanks,=0A= Ross= From xen-devel-bounces@lists.xenproject.org Tue May 02 17:06:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 17:06:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528762.822304 (Exim 4.92) (envelope-from ) id 1pttSL-000359-Vm; Tue, 02 May 2023 17:06:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528762.822304; Tue, 02 May 2023 17:06:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pttSL-000352-TH; Tue, 02 May 2023 17:06:25 +0000 Received: by outflank-mailman (input) for mailman id 528762; Tue, 02 May 2023 17:06:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pttSK-00034w-Ip for xen-devel@lists.xenproject.org; Tue, 02 May 2023 17:06:24 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a7b4f32b-e90b-11ed-8611-37d641c3527e; Tue, 02 May 2023 19:06:20 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a7b4f32b-e90b-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683047180; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=X8Ye7JviKJ6lmX7NtPkFlXMM7AfRK4M9QiNKUFj64gg=; b=T232EKTWhpDuxPlSfNwf0ZcsLXvPrSVSXBi2EFQOn1hPPa9eQKo9voKv l1lma5sDr2jGcSMcDYqi0wGVIoyNAX/Q60GkAr67Emu9R/b2b3SucmsaI XZeTXoIBG0H0wJR9o+M+AiZMhzU39XO4Lq3cEM8G8KBYmdgQQJcH8q3PR I=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 106369293 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:AK+AwqCpXJ7xdhVW//fjw5YqxClBgxIJ4kV8jS/XYbTApDgi0mYAz WMXWmqPP/7eamX8eNp0O4608kIEuJPSx4Q1QQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFuspvlDs15K6p4G5A5ARkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw1Od8KEFJy a0iCzUOPi29pr6tyZH8Rbw57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2M1N3wsYDUWUrsTIJs4gOevgGi5azBCoUiZjaE2/3LS3Ep6172F3N/9I4TUHpsExBfDz o7A1yPHHzsTDfid8mCq9H+LpeD+kzuheZ1HQdVU8dY12QbOlwT/EiY+UUawqL+3g0i1VtZbN mQd4C9opq83nGS7Q9+4UxCmrXqsuh8HR8EWA+A88BuKyKff/0CeHGdsZjRMcsA8vck6Azkjz EaUnsjBDCZq9raSTBq16bqV6ziyNC49JHUHIyQDSGMt/N3LsIw1yBXVQb5LCqmuhMfyHjL26 z+PpSk6wb4UiKYj1aqh+kvcqymxvZWPRQkwji3eRm+/5xl1TJKkbYevr1Pc6J59wJ2xFwfb+ iJewo7Hsb5IVMvW/MCQfAkTNJ+o7N+lNwGNu31qHMkcyRXx4HeAOo8FtVmSO3xV3tY4lS7BO RGD4lsIvs8MYxNGfocsPdvvVp1CIbzIUI28C6uKNocmjo1ZLlfvwc14WaKHM4kBemAImLp3B 5qUeN3E4Z0yWfU+l2reqwvwPNYWKsECKYD7H8qTI+yPi+b2WZJsYe5t3KGyRu449riYhw7e7 sxSMcCHoz0GDr2kM3eIqNRLcw1VRZTeOa0aVuQNLrLTSuaYMDhJ5wDtLUMJJNU+wvU9ehbg9 XChQE5IoGfCaYn8AVzSMBhLMeq/NauTWFpnZUTAy370gSl8CWtuhY9DH6YKkU4Pr7I5lqItH qhtlgfpKq0ndwkrMg81NfHVxLGOvjz27e5SF0JJuAQCQqM= IronPort-HdrOrdr: A9a23:kwDN1Ku64flgASkKpK7SikcI7skDSdV00zEX/kB9WHVpmwKj5r mTdZUgpGfJYVMqMk3I9urwXZVoLUmsl6KdpLNhXotKPzOGhILLFvAH0WKK+VSJcBEWtNQ86U 4KSdkYNDSfNykdsS842mWF+hQbreVvPJrGuQ4W9RlQcT0= X-Talos-CUID: 9a23:CCLcimBUMSsS9E36Ewdm/2c0Hfx0SF7YzyftHW7kEm9KD7LAHA== X-Talos-MUID: =?us-ascii?q?9a23=3Ap8osvg90opA8ZszmfJDj80iQf4BW/o6nMWQPqs8?= =?us-ascii?q?pvcSjFiNBNS/HrSviFw=3D=3D?= X-IronPort-AV: E=Sophos;i="5.99,244,1677560400"; d="scan'208";a="106369293" Date: Tue, 2 May 2023 18:06:08 +0100 From: Anthony PERARD To: Luca Fancellu CC: , , , Wei Liu , George Dunlap , Nick Rosbrook , "Juergen Gross" Subject: Re: [PATCH v6 10/12] xen/tools: add sve parameter in XL configuration Message-ID: <996db21b-e963-4259-884d-2131c548ca1e@perard> References: <20230424060248.1488859-1-luca.fancellu@arm.com> <20230424060248.1488859-11-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230424060248.1488859-11-luca.fancellu@arm.com> On Mon, Apr 24, 2023 at 07:02:46AM +0100, Luca Fancellu wrote: > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c > index ddc7b2a15975..1e69dac2c4fa 100644 > --- a/tools/libs/light/libxl_arm.c > +++ b/tools/libs/light/libxl_arm.c > @@ -211,6 +213,12 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, > return ERROR_FAIL; > } > > + /* Parameter is sanitised in libxl__arch_domain_build_info_setdefault */ > + if (d_config->b_info.arch_arm.sve_vl) { > + /* Vector length is divided by 128 in struct xen_domctl_createdomain */ > + config->arch.sve_vl = d_config->b_info.arch_arm.sve_vl / 128U; > + } > + > return 0; > } > > @@ -1681,6 +1689,26 @@ int libxl__arch_domain_build_info_setdefault(libxl__gc *gc, > /* ACPI is disabled by default */ > libxl_defbool_setdefault(&b_info->acpi, false); > > + /* Sanitise SVE parameter */ > + if (b_info->arch_arm.sve_vl) { > + unsigned int max_sve_vl = > + arch_capabilities_arm_sve(physinfo->arch_capabilities); > + > + if (!max_sve_vl) { > + LOG(ERROR, "SVE is unsupported on this machine."); > + return ERROR_FAIL; > + } > + > + if (LIBXL_SVE_TYPE_HW == b_info->arch_arm.sve_vl) { > + b_info->arch_arm.sve_vl = max_sve_vl; > + } else if (b_info->arch_arm.sve_vl > max_sve_vl) { > + LOG(ERROR, > + "Invalid sve value: %d. Platform supports up to %u bits", > + b_info->arch_arm.sve_vl, max_sve_vl); > + return ERROR_FAIL; > + } You still need to check that sve_vl is one of the value from the enum, or that the value is divisible by 128. > + } > + > if (b_info->type != LIBXL_DOMAIN_TYPE_PV) > return 0; > > diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl > index fd31dacf7d5a..9e48bb772646 100644 > --- a/tools/libs/light/libxl_types.idl > +++ b/tools/libs/light/libxl_types.idl > @@ -523,6 +523,27 @@ libxl_tee_type = Enumeration("tee_type", [ > (1, "optee") > ], init_val = "LIBXL_TEE_TYPE_NONE") > > +libxl_sve_type = Enumeration("sve_type", [ > + (-1, "hw"), > + (0, "disabled"), > + (128, "128"), > + (256, "256"), > + (384, "384"), > + (512, "512"), > + (640, "640"), > + (768, "768"), > + (896, "896"), > + (1024, "1024"), > + (1152, "1152"), > + (1280, "1280"), > + (1408, "1408"), > + (1536, "1536"), > + (1664, "1664"), > + (1792, "1792"), > + (1920, "1920"), > + (2048, "2048") > + ], init_val = "LIBXL_SVE_TYPE_DISABLED") I'm not sure if I like that or not. Is there a reason to stop at 2048? It is possible that there will be more value available in the future? Also this mean that users of libxl (like libvirt) would be supposed to use LIBXL_SVE_TYPE_1024 for e.g., or use libxl_sve_type_from_string(). Also, it feels weird to me to mostly use numerical value of the enum rather than the enum itself. Anyway, hopefully that enum will work fine. > libxl_rdm_reserve = Struct("rdm_reserve", [ > ("strategy", libxl_rdm_reserve_strategy), > ("policy", libxl_rdm_reserve_policy), Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue May 02 17:08:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 17:08:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528766.822314 (Exim 4.92) (envelope-from ) id 1pttUe-0003dG-AR; Tue, 02 May 2023 17:08:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528766.822314; Tue, 02 May 2023 17:08:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pttUe-0003d9-7h; Tue, 02 May 2023 17:08:48 +0000 Received: by outflank-mailman (input) for mailman id 528766; Tue, 02 May 2023 17:08:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pttUc-0003d1-0w for xen-devel@lists.xenproject.org; Tue, 02 May 2023 17:08:46 +0000 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [2a00:1450:4864:20::536]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fdcb4104-e90b-11ed-b225-6b7b168915f2; Tue, 02 May 2023 19:08:44 +0200 (CEST) Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-50bc4ba28cbso4763225a12.0 for ; Tue, 02 May 2023 10:08:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fdcb4104-e90b-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683047323; x=1685639323; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=wKq68nL7IZe8CxCPKWRpfsYPAqO/kJptEynBmrLXGno=; b=wJTz2Lb9P2BIcudGgZCX+y+30ZlzVkLjiFwcmaHxkHtJYW7P5L/qYfTAiZ+i4zqgtg 0IlRSg4MA1HAqV+D0ba8Ih+KRJ5IYo8McCdQYaAKLoHJ0c0yM/3QuOL+N3HOsRbmwYwx YUU/sXI+6PaC+TgDxUDSllY3ZQNDycR8MxfDHtYukm8AT+M2ON6OQQ1vFKjobX/XROMj LU2FAObSj+uKhG8pYCmYJCX5Fj6GEMmI/En30Rt2dV3vL3qtYvuJaDb3J756VQ5g+rlh iU74ECh20gV+Mkf64cBgq/6oJ7b7yB7X2hG+wTL4we+cWq1KMC3EYdj26hWTxXZn5xCh tYlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683047323; x=1685639323; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wKq68nL7IZe8CxCPKWRpfsYPAqO/kJptEynBmrLXGno=; b=kTXo9YvaEjv/tNM4SKzB04PLYUfW62Y7NM1/NxGETOETLstZZS9L2W8qGK/sead7b1 4q18R2sXjCHZKnj/zKyh78XYavQDQTOV9OecSHrUHuUcFxha+0/pbO55mT98TMgb+3J8 AYmkIHWh8dmGgGturP1pwifhktUVwO7DArnhvhK3GHjMZMdez+mBtIJ7SyfjEDPeKxjP t9x4+z6k54zSNgZ49KWoPPMDCdLukJJKcyhaAc9ld+ZRkVj76GelxtavCjtUDVtAyZhl 4F+KEBGxlzdcbLyUqeZq5nMuEUh4Boc50NLlfJpu+0tqGNgyP7Xy2obpga9xP3CHXXJ/ 6duw== X-Gm-Message-State: AC+VfDxhYYJ0HvJlHc6wMGUTQEatVZSluh9rdj3T/azEkveaR3Zm4ePg 2Y8YA4E5jheGsjneQlOvyOHlcq5fLKju6r5Ny7xOVQ== X-Google-Smtp-Source: ACHHUZ5ryAaiEYM7YxlTJAHU6zLdkibBxJTqdgb+u5+jyCzwLxskxERr5n7iMCM3uXDn/QRibKS6VOtt1URTw1XYbYQ= X-Received: by 2002:a05:6402:44a:b0:504:b511:1a39 with SMTP id p10-20020a056402044a00b00504b5111a39mr8695641edw.12.1683047322896; Tue, 02 May 2023 10:08:42 -0700 (PDT) MIME-Version: 1.0 References: <20230307182707.2298618-1-dwmw2@infradead.org> <20230307182707.2298618-6-dwmw2@infradead.org> In-Reply-To: <20230307182707.2298618-6-dwmw2@infradead.org> From: Peter Maydell Date: Tue, 2 May 2023 18:08:32 +0100 Message-ID: Subject: Re: [PULL 05/27] hw/xen: Watches on XenStore transactions To: David Woodhouse Cc: qemu-devel@nongnu.org, Paolo Bonzini , Paul Durrant , Joao Martins , Ankur Arora , Stefano Stabellini , vikram.garhwal@amd.com, Anthony Perard , xen-devel@lists.xenproject.org, Juan Quintela , "Dr . David Alan Gilbert" Content-Type: text/plain; charset="UTF-8" On Tue, 7 Mar 2023 at 18:27, David Woodhouse wrote: > > From: David Woodhouse > > Firing watches on the nodes that still exist is relatively easy; just > walk the tree and look at the nodes with refcount of one. > > Firing watches on *deleted* nodes is more fun. We add 'modified_in_tx' > and 'deleted_in_tx' flags to each node. Nodes with those flags cannot > be shared, as they will always be unique to the transaction in which > they were created. > > When xs_node_walk would need to *create* a node as scaffolding and it > encounters a deleted_in_tx node, it can resurrect it simply by clearing > its deleted_in_tx flag. If that node originally had any *data*, they're > gone, and the modified_in_tx flag will have been set when it was first > deleted. > > We then attempt to send appropriate watches when the transaction is > committed, properly delete the deleted_in_tx nodes, and remove the > modified_in_tx flag from the others. > > Signed-off-by: David Woodhouse > Reviewed-by: Paul Durrant Hi; Coverity's "is there missing error handling?" heuristic fired for a change in this code (CID 1508359): > static int transaction_commit(XenstoreImplState *s, XsTransaction *tx) > { > + struct walk_op op; > + XsNode **n; > + > if (s->root_tx != tx->base_tx) { > return EAGAIN; > } > @@ -720,10 +861,18 @@ static int transaction_commit(XenstoreImplState *s, XsTransaction *tx) > s->root_tx = tx->tx_id; > s->nr_nodes = tx->nr_nodes; > > + init_walk_op(s, &op, XBT_NULL, tx->dom_id, "/", &n); This is the only call to init_walk_op() which ignores its return value. Intentional, or missing error handling? > + op.deleted_in_tx = false; > + op.mutating = true; > + > /* > - * XX: Walk the new root and fire watches on any node which has a > + * Walk the new root and fire watches on any node which has a > * refcount of one (which is therefore unique to this transaction). > */ > + if (s->root->children) { > + g_hash_table_foreach_remove(s->root->children, tx_commit_walk, &op); > + } > + > return 0; > } thanks -- PMM From xen-devel-bounces@lists.xenproject.org Tue May 02 17:59:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 17:59:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528770.822325 (Exim 4.92) (envelope-from ) id 1ptuHv-0001IF-53; Tue, 02 May 2023 17:59:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528770.822325; Tue, 02 May 2023 17:59:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptuHv-0001I8-1l; Tue, 02 May 2023 17:59:43 +0000 Received: by outflank-mailman (input) for mailman id 528770; Tue, 02 May 2023 17:59:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptuHt-0001Hy-S1; Tue, 02 May 2023 17:59:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptuHt-0002Oq-Cg; Tue, 02 May 2023 17:59:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptuHs-0006P0-Th; Tue, 02 May 2023 17:59:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ptuHs-0006rw-RF; Tue, 02 May 2023 17:59:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=fM4yXtJL6nBZqLERvzuPa4/Ju0V+pyT4JCiE9KAPLt0=; b=jawDzMgioiTEyZCCf0IjPkzzHR B1inYv3vViH8K/j1v1nWbatmKVkPs10iRVO+TGdBd+6KBvWA5zeJWjPxyCSHU1uJnd91qVQ/P/2NS 46gMdcOOj7YZHZKBR7XAYUbim0gA7/GSvvuHXt0056sIbyeQEKg0NnsnWuUuP2xLQmEQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180504: regressions - FAIL X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:debian-install:fail:heisenbug linux-linus:test-amd64-amd64-xl-vhd:guest-start/debian.repeat:fail:heisenbug linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-examine:reboot:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=865fdb08197e657c59e74a35fa32362b12397f58 X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Tue, 02 May 2023 17:59:40 +0000 flight 180504 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/180504/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 180278 Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-credit2 12 debian-install fail pass in 180500 test-amd64-amd64-xl-vhd 21 guest-start/debian.repeat fail pass in 180500 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 180500 never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 180500 never pass test-armhf-armhf-xl-credit2 8 xen-boot fail like 180278 test-armhf-armhf-libvirt 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-raw 8 xen-boot fail like 180278 test-armhf-armhf-xl-arndale 8 xen-boot fail like 180278 test-armhf-armhf-xl-vhd 8 xen-boot fail like 180278 test-armhf-armhf-examine 8 reboot fail like 180278 test-armhf-armhf-xl-rtds 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180278 test-armhf-armhf-xl 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180278 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail like 180278 test-armhf-armhf-xl-multivcpu 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 865fdb08197e657c59e74a35fa32362b12397f58 baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 15 days Failing since 180281 2023-04-17 06:24:36 Z 15 days 27 attempts Testing same since 180500 2023-05-02 01:41:05 Z 0 days 2 attempts ------------------------------------------------------------ 2156 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 261762 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 02 18:56:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 18:56:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528776.822335 (Exim 4.92) (envelope-from ) id 1ptvAL-000842-Bx; Tue, 02 May 2023 18:55:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528776.822335; Tue, 02 May 2023 18:55:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptvAL-00083v-9D; Tue, 02 May 2023 18:55:57 +0000 Received: by outflank-mailman (input) for mailman id 528776; Tue, 02 May 2023 18:55:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptvAJ-00083p-PY for xen-devel@lists.xenproject.org; Tue, 02 May 2023 18:55:55 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptvAI-0003hh-TJ; Tue, 02 May 2023 18:55:54 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=[192.168.27.23]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ptvAI-0005Bb-Mq; Tue, 02 May 2023 18:55:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=/ZyE9fpt/78nDThThdz/kDxQb85mcyv/qvVJpj6ieEk=; b=Qzgu9OvVgcAEZYAA0/Y0wse8EM 2fyoW52R3LXF9ib8fWeQDRaPeuzvLMralupIneW8Q4KK7xKn6+kbRFQl9kQFcqHWghK6wSN7gCCY6 ZCBoM+t+Vdcq/bdq9vmhM8KIf3c8Io9owrsl45fBkvip4PafUUiTt8/xzG/zlmLHBSUk=; Message-ID: Date: Tue, 2 May 2023 19:55:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 05/13] tools/xenstore: use accounting buffering for node accounting Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230405070349.25293-1-jgross@suse.com> <20230405070349.25293-6-jgross@suse.com> From: Julien Grall In-Reply-To: <20230405070349.25293-6-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 05/04/2023 08:03, Juergen Gross wrote: > Add the node accounting to the accounting information buffering in > order to avoid having to undo it in case of failure. > > Signed-off-by: Juergen Gross > --- > tools/xenstore/xenstored_core.c | 21 ++------------------- > tools/xenstore/xenstored_domain.h | 4 ++-- > 2 files changed, 4 insertions(+), 21 deletions(-) > > diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c > index 84335f5f3d..92a40ccf3f 100644 > --- a/tools/xenstore/xenstored_core.c > +++ b/tools/xenstore/xenstored_core.c > @@ -1452,7 +1452,6 @@ static void destroy_node_rm(struct connection *conn, struct node *node) > static int destroy_node(struct connection *conn, struct node *node) > { > destroy_node_rm(conn, node); > - domain_nbentry_dec(conn, get_node_owner(node)); > > /* > * It is not possible to easily revert the changes in a transaction. > @@ -1797,27 +1796,11 @@ static int do_set_perms(const void *ctx, struct connection *conn, > old_perms = node->perms; > domain_nbentry_dec(conn, get_node_owner(node)); IIRC, we originally said that domain_nbentry_dec() could never fail in a non-transaction case. But with your current rework, the function can now fail because of an allocation failure. Therefore, shouldn't we now check the error? (Possibly in a patch beforehand). > node->perms = perms; > - if (domain_nbentry_inc(conn, get_node_owner(node))) { > - node->perms = old_perms; > - /* > - * This should never fail because we had a reference on the > - * domain before and Xenstored is single-threaded. > - */ > - domain_nbentry_inc(conn, get_node_owner(node)); > + if (domain_nbentry_inc(conn, get_node_owner(node))) > return ENOMEM; > - } > > - if (write_node(conn, node, false)) { > - int saved_errno = errno; > - > - domain_nbentry_dec(conn, get_node_owner(node)); > - node->perms = old_perms; > - /* No failure possible as above. */ > - domain_nbentry_inc(conn, get_node_owner(node)); > - > - errno = saved_errno; > + if (write_node(conn, node, false)) > return errno; > - } > > fire_watches(conn, ctx, name, node, false, &old_perms); > send_ack(conn, XS_SET_PERMS); > diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h > index 6355ad4f37..e669f57b80 100644 > --- a/tools/xenstore/xenstored_domain.h > +++ b/tools/xenstore/xenstored_domain.h > @@ -25,9 +25,9 @@ > * a per transaction array. > */ > enum accitem { > + ACC_NODES, > ACC_REQ_N, /* Number of elements per request. */ > - ACC_NODES = ACC_REQ_N, > - ACC_TR_N, /* Number of elements per transaction. */ > + ACC_TR_N = ACC_REQ_N, /* Number of elements per transaction. */ > ACC_N = ACC_TR_N, /* Number of elements per domain. */ > }; > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 02 18:56:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 18:56:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528780.822345 (Exim 4.92) (envelope-from ) id 1ptvAy-00005r-Pb; Tue, 02 May 2023 18:56:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528780.822345; Tue, 02 May 2023 18:56:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptvAy-00005k-MN; Tue, 02 May 2023 18:56:36 +0000 Received: by outflank-mailman (input) for mailman id 528780; Tue, 02 May 2023 18:56:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptvAw-0008UA-N0 for xen-devel@lists.xenproject.org; Tue, 02 May 2023 18:56:34 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0ddd27c4-e91b-11ed-b225-6b7b168915f2; Tue, 02 May 2023 20:56:33 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-297-hz_-_nNRNHKLUa7zat10Kw-1; Tue, 02 May 2023 14:56:28 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AF841811E7C; Tue, 2 May 2023 18:56:27 +0000 (UTC) Received: from localhost (unknown [10.39.192.230]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5A29F492B03; Tue, 2 May 2023 18:56:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0ddd27c4-e91b-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683053792; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JvqiB11pwfyb9mMlyyPXLE6NQZxd1luK1o/19K1fqnk=; b=Jl4gsC1KlQMRK0juJOoLPeJbdKQyXa0ar5TmsH51hUb7c8IzyFWx7oVpcQ7KsZ9fLU7e1y FFDf3I/nseYyoInDjLMk+EgL4IQGvKr/69RhcjVt0ePFUCGVC9phJK8ASvlRD0ivqxXZWi yTiPIzIo+9+GB2mMV5BEfCF3edfSXxs= X-MC-Unique: hz_-_nNRNHKLUa7zat10Kw-1 Date: Tue, 2 May 2023 14:56:24 -0400 From: Stefan Hajnoczi To: Kevin Wolf Cc: qemu-devel@nongnu.org, Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Juan Quintela , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Richard Henderson , Fam Zheng , "Michael S. Tsirkin" , Coiby Xu , David Woodhouse , Marcel Apfelbaum , Peter Lieven , Paul Durrant , "Richard W.M. Jones" , qemu-block@nongnu.org, Stefano Garzarella , Anthony Perard , Stefan Weil , Xie Yongji , Paolo Bonzini , Aarushi Mehta , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Eduardo Habkost , Stefano Stabellini , Hanna Reitz , Ronnie Sahlberg , Daniil Tatianin Subject: Re: [PATCH v4 03/20] virtio-scsi: avoid race between unplug and transport event Message-ID: <20230502185624.GA535070@fedora> References: <20230425172716.1033562-1-stefanha@redhat.com> <20230425172716.1033562-4-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Qd9ljEEGWct7+HKe" Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 --Qd9ljEEGWct7+HKe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 02, 2023 at 05:19:46PM +0200, Kevin Wolf wrote: > Am 25.04.2023 um 19:26 hat Stefan Hajnoczi geschrieben: > > Only report a transport reset event to the guest after the SCSIDevice > > has been unrealized by qdev_simple_device_unplug_cb(). > >=20 > > qdev_simple_device_unplug_cb() sets the SCSIDevice's qdev.realized field > > to false so that scsi_device_find/get() no longer see it. > >=20 > > scsi_target_emulate_report_luns() also needs to be updated to filter out > > SCSIDevices that are unrealized. > >=20 > > These changes ensure that the guest driver does not see the SCSIDevice > > that's being unplugged if it responds very quickly to the transport > > reset event. > >=20 > > Reviewed-by: Paolo Bonzini > > Reviewed-by: Michael S. Tsirkin > > Reviewed-by: Daniil Tatianin > > Signed-off-by: Stefan Hajnoczi >=20 > > @@ -1082,6 +1073,15 @@ static void virtio_scsi_hotunplug(HotplugHandler= *hotplug_dev, DeviceState *dev, > > blk_set_aio_context(sd->conf.blk, qemu_get_aio_context(), NULL= ); > > virtio_scsi_release(s); > > } > > + > > + if (virtio_vdev_has_feature(vdev, VIRTIO_SCSI_F_HOTPLUG)) { > > + virtio_scsi_acquire(s); > > + virtio_scsi_push_event(s, sd, > > + VIRTIO_SCSI_T_TRANSPORT_RESET, > > + VIRTIO_SCSI_EVT_RESET_REMOVED); > > + scsi_bus_set_ua(&s->bus, SENSE_CODE(REPORTED_LUNS_CHANGED)); > > + virtio_scsi_release(s); > > + } > > } >=20 > s, sd and s->bus are all unrealized at this point, whereas before this > patch they were still realized. I couldn't find any practical problem > with it, but it made me nervous enough that I thought I should comment > on it at least. >=20 > Should we maybe have documentation on these functions that says that > they accept unrealized objects as their parameters? s is the VirtIOSCSI controller, not the SCSIDevice that is being unplugged. The VirtIOSCSI controller is still realized. s->bus is the VirtIOSCSI controller's bus, it is still realized. You are right that the SCSIDevice (sd) has been unrealized at this point: - sd->conf.blk is safe because qdev properties stay alive the Object is deleted, but I'm not sure we should rely on that. - virti_scsi_push_event(.., sd, ...) is questionable because the LUN that's fetched from sd no longer belongs to the unplugged SCSIDevice. How about I change the code to fetch sd->conf.blk and the LUN before unplugging? Stefan --Qd9ljEEGWct7+HKe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmRRXNgACgkQnKSrs4Gr c8ipsAf+MYIOWS+2lk+xRt3nEDpVri7B1MaNSrlKDWSw2vK6J34jE0bGdHF3I5kZ cS6XFEpcK0BRYes0zRpFZyksJFYS1033b2up4HGodKOJp34ahYy7Vg4yNrov6pzO pZHJAEeEkK0FrHHJkho15qjoOykxt4bib6RzUFN+EdKo3KGQzk1dEyh8fzPEm40x CwNN7D/FJAOOM3CpgsHLUGu6EvOBlfGkd8kS7It3qOD+/BeLFHKDiLBaU5w/IXtA WmgFKnZiOEsMQIEIFgcg+m/YrlomPy0kRPFFSFNn7/5yCmhLCU5WNY/1sTiM3LEi 20aCYTqXQJt5E6c1jk1x21IACc9qRA== =PP5I -----END PGP SIGNATURE----- --Qd9ljEEGWct7+HKe-- From xen-devel-bounces@lists.xenproject.org Tue May 02 18:57:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 18:57:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528784.822355 (Exim 4.92) (envelope-from ) id 1ptvBq-0000ki-2X; Tue, 02 May 2023 18:57:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528784.822355; Tue, 02 May 2023 18:57:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptvBp-0000kb-VU; Tue, 02 May 2023 18:57:29 +0000 Received: by outflank-mailman (input) for mailman id 528784; Tue, 02 May 2023 18:57:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptvBo-0000kJ-37 for xen-devel@lists.xenproject.org; Tue, 02 May 2023 18:57:28 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptvBn-0003j4-FA; Tue, 02 May 2023 18:57:27 +0000 Received: from 54-240-197-228.amazon.com ([54.240.197.228] helo=[192.168.27.23]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ptvBn-0005E7-98; Tue, 02 May 2023 18:57:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=mUiVQ/ID7Mf9r5d/C6BFsfv6tI7q/JAE0UDgvSyOPsU=; b=WjTQ2BOSDP4ntjMiRL3gHONm9R n2Yfob7K1cXcYtRbvpEDozixeJDvHAGGbHov5ntM5ebI7W/OW3XGRG6fcohxFQhCgPxcRtglKnyjq bmlipOCZ2jeFBhhijBM86Ht368+KQlbzrDpFzekXjwSYlRVIAJISslizVXJkvhQ8lXDE=; Message-ID: <4e7f5761-e21c-ee8b-6bb4-cd3753ce9b33@xen.org> Date: Tue, 2 May 2023 19:57:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 06/13] tools/xenstore: add current connection to domain_memory_add() parameters Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230405070349.25293-1-jgross@suse.com> <20230405070349.25293-7-jgross@suse.com> From: Julien Grall In-Reply-To: <20230405070349.25293-7-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 05/04/2023 08:03, Juergen Gross wrote: > In order to enable switching memory accounting to the generic array > based accounting, add the current connection to the parameters of > domain_memory_add(). > > This requires to add the connection to some other functions, too. > > Signed-off-by: Juergen Gross Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 02 19:09:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 19:09:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528788.822365 (Exim 4.92) (envelope-from ) id 1ptvNl-0002Yt-4L; Tue, 02 May 2023 19:09:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528788.822365; Tue, 02 May 2023 19:09:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptvNl-0002Ym-1V; Tue, 02 May 2023 19:09:49 +0000 Received: by outflank-mailman (input) for mailman id 528788; Tue, 02 May 2023 19:09:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptvNj-0002Yg-V4 for xen-devel@lists.xenproject.org; Tue, 02 May 2023 19:09:47 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptvNi-00046d-Un; Tue, 02 May 2023 19:09:46 +0000 Received: from 54-240-197-228.amazon.com ([54.240.197.228] helo=[192.168.27.23]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ptvNi-0005pv-Oo; Tue, 02 May 2023 19:09:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=PQKNilhygwzDZCPuPcBWG5h80MuAqj51hGz16gI1WKI=; b=DMe6v1X6sejoZtew8uhtaR2Uyv sA3qEhyiP0+gDqjWtRj+EZZjr0NlZ7gf+k5Pow/h+tBNdpseczojI1WGOYQzUhY9pDYG74sfj1wVe 4rsJ4pLvNYPtpvADJVpeW38QRE0+LO7qOmcKhNKxGUPSxUuI0A2zT/PigfRcgvd/qqfc=; Message-ID: <25027287-441a-304c-f035-0d3da3572d3a@xen.org> Date: Tue, 2 May 2023 20:09:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 07/13] tools/xenstore: use accounting data array for per-domain values Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230405070349.25293-1-jgross@suse.com> <20230405070349.25293-8-jgross@suse.com> From: Julien Grall In-Reply-To: <20230405070349.25293-8-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 05/04/2023 08:03, Juergen Gross wrote: > diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h > index 5cfd730cf6..0d61bf4344 100644 > --- a/tools/xenstore/xenstored_domain.h > +++ b/tools/xenstore/xenstored_domain.h > @@ -28,7 +28,10 @@ enum accitem { > ACC_NODES, > ACC_REQ_N, /* Number of elements per request. */ > ACC_TR_N = ACC_REQ_N, /* Number of elements per transaction. */ > - ACC_N = ACC_TR_N, /* Number of elements per domain. */ > + ACC_WATCH = ACC_TR_N, > + ACC_OUTST, > + ACC_MEM, > + ACC_N, /* Number of elements per domain. */ > }; > > void handle_event(void); > @@ -107,9 +110,8 @@ static inline void domain_memory_add_nochk(struct connection *conn, > void domain_watch_inc(struct connection *conn); > void domain_watch_dec(struct connection *conn); > int domain_watch(struct connection *conn); > -void domain_outstanding_inc(struct connection *conn); > -void domain_outstanding_dec(struct connection *conn); > -void domain_outstanding_domid_dec(unsigned int domid); > +void domain_outstanding_inc(struct connection *conn, unsigned int domid); AFAICT, all the caller of domain_outstanding_inc() will pass 'conn->id'. So it is not entirely clear what's the benefits to add the extra parameter. I am not against this change (and same for removing *domid_dec()). But I think this ought to be explained in the commit message as this feels unrelated. > +void domain_outstanding_dec(struct connection *conn, unsigned int domid); > int domain_get_quota(const void *ctx, struct connection *conn, > unsigned int domid); > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 02 19:19:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 19:19:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528791.822375 (Exim 4.92) (envelope-from ) id 1ptvWm-000476-1W; Tue, 02 May 2023 19:19:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528791.822375; Tue, 02 May 2023 19:19:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptvWl-00046z-Ud; Tue, 02 May 2023 19:19:07 +0000 Received: by outflank-mailman (input) for mailman id 528791; Tue, 02 May 2023 19:19:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptvWk-00046t-Jq for xen-devel@lists.xenproject.org; Tue, 02 May 2023 19:19:06 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptvWk-0004GX-CF for xen-devel@lists.xenproject.org; Tue, 02 May 2023 19:19:06 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=[192.168.27.23]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ptvWk-00068z-7D for xen-devel@lists.xenproject.org; Tue, 02 May 2023 19:19:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:To:Subject:MIME-Version:Date:Message-ID; bh=EBnYYM8HG9bUiwwQLUhRg9xb2vnvYthtANZybEVBW+w=; b=OT1Pl1ozn/hkxMrVGH22QAUg6o 2D2AwFJUyT/w7fWhH1JYZcd/rYPxIsRhaz4ep9xaq2jcXYKEK4wQm6XlTolkp/EZqiON11q+iVTix bggIHuaWi1LWGsOQLQFYsLm7RCDbg9nYoJRbEHa+BmmJWOIY/zMLsO6xWFtsu39fFMoQ=; Message-ID: <5b61ce7e-639c-4f2d-6cb9-421679d30d9d@xen.org> Date: Tue, 2 May 2023 20:19:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 10/13] tools/xenstore: switch transaction accounting to generic accounting Content-Language: en-US To: xen-devel@lists.xenproject.org References: <20230405070349.25293-1-jgross@suse.com> <20230405070349.25293-11-jgross@suse.com> From: Julien Grall In-Reply-To: <20230405070349.25293-11-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 05/04/2023 08:03, Juergen Gross wrote: > As transaction accounting is active for unprivileged domains only, it > can easily be added to the generic per-domain accounting. > > Signed-off-by: Juergen Gross > --- > tools/xenstore/xenstored_core.c | 3 +-- > tools/xenstore/xenstored_core.h | 1 - > tools/xenstore/xenstored_domain.c | 21 ++++++++++++++++++--- > tools/xenstore/xenstored_domain.h | 4 ++++ > tools/xenstore/xenstored_transaction.c | 12 +++++------- > 5 files changed, 28 insertions(+), 13 deletions(-) > > diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c > index 2d481fcad9..88c569b7d5 100644 > --- a/tools/xenstore/xenstored_core.c > +++ b/tools/xenstore/xenstored_core.c > @@ -2083,7 +2083,7 @@ static void consider_message(struct connection *conn) > * stalled. This will ignore new requests until Live-Update happened > * or it was aborted. > */ > - if (lu_is_pending() && conn->transaction_started == 0 && > + if (lu_is_pending() && conn->ta_start_time == 0 && NIT: I know there are some places in the code checking for conn->ta_start_time == 0. But it feels like a better replacement to "conn->transaction_started" is "list_empty(...)". I agree this is going to be more expensive. But you are switching the transaction accounting to a generic infrastructure which is pretty heavy compare to a simple addition/substraction. So I think a "list_empty()" would be OK here. > conn->in->hdr.msg.type == XS_TRANSACTION_START) { > trace("Delaying transaction start for connection %p req_id %u\n", > conn, conn->in->hdr.msg.req_id); > @@ -2190,7 +2190,6 @@ struct connection *new_connection(const struct interface_funcs *funcs) > new->funcs = funcs; > new->is_ignored = false; > new->is_stalled = false; > - new->transaction_started = 0; > INIT_LIST_HEAD(&new->out_list); > INIT_LIST_HEAD(&new->acc_list); > INIT_LIST_HEAD(&new->ref_list); > diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h > index 5a11dc1231..3564d85d7d 100644 > --- a/tools/xenstore/xenstored_core.h > +++ b/tools/xenstore/xenstored_core.h > @@ -151,7 +151,6 @@ struct connection > /* List of in-progress transactions. */ > struct list_head transaction_list; > uint32_t next_transaction_id; > - unsigned int transaction_started; > time_t ta_start_time; > > /* List of delayed requests. */ > diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c > index 1caa60bb14..40bcc1dbfa 100644 > --- a/tools/xenstore/xenstored_domain.c > +++ b/tools/xenstore/xenstored_domain.c > @@ -419,12 +419,10 @@ int domain_get_quota(const void *ctx, struct connection *conn, > { > struct domain *d = find_domain_struct(domid); > char *resp; > - int ta; > > if (!d) > return ENOENT; > > - ta = d->conn ? d->conn->transaction_started : 0; > resp = talloc_asprintf(ctx, "Domain %u:\n", domid); > if (!resp) > return ENOMEM; > @@ -435,7 +433,7 @@ int domain_get_quota(const void *ctx, struct connection *conn, > > ent(nodes, d->acc[ACC_NODES]); > ent(watches, d->acc[ACC_WATCH]); > - ent(transactions, ta); > + ent(transactions, d->acc[ACC_TRANS]); > ent(outstanding, d->acc[ACC_OUTST]); > ent(memory, d->acc[ACC_MEM]); > > @@ -1297,6 +1295,23 @@ void domain_outstanding_dec(struct connection *conn, unsigned int domid) > domain_acc_add(conn, domid, ACC_OUTST, -1, true); > } > > +void domain_transaction_inc(struct connection *conn) > +{ > + domain_acc_add(conn, conn->id, ACC_TRANS, 1, true); > +} > + > +void domain_transaction_dec(struct connection *conn) > +{ > + domain_acc_add(conn, conn->id, ACC_TRANS, -1, true); > +} > + > +unsigned int domain_transaction_get(struct connection *conn) > +{ > + return (domain_is_unprivileged(conn)) > + ? domain_acc_add(conn, conn->id, ACC_TRANS, 0, true) > + : 0; > +} > + > static wrl_creditt wrl_config_writecost = WRL_FACTOR; > static wrl_creditt wrl_config_rate = WRL_RATE * WRL_FACTOR; > static wrl_creditt wrl_config_dburst = WRL_DBURST * WRL_FACTOR; > diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h > index 0d61bf4344..abc766f343 100644 > --- a/tools/xenstore/xenstored_domain.h > +++ b/tools/xenstore/xenstored_domain.h > @@ -31,6 +31,7 @@ enum accitem { > ACC_WATCH = ACC_TR_N, > ACC_OUTST, > ACC_MEM, > + ACC_TRANS, > ACC_N, /* Number of elements per domain. */ > }; > > @@ -112,6 +113,9 @@ void domain_watch_dec(struct connection *conn); > int domain_watch(struct connection *conn); > void domain_outstanding_inc(struct connection *conn, unsigned int domid); > void domain_outstanding_dec(struct connection *conn, unsigned int domid); > +void domain_transaction_inc(struct connection *conn); > +void domain_transaction_dec(struct connection *conn); > +unsigned int domain_transaction_get(struct connection *conn); > int domain_get_quota(const void *ctx, struct connection *conn, > unsigned int domid); > > diff --git a/tools/xenstore/xenstored_transaction.c b/tools/xenstore/xenstored_transaction.c > index 11c8bcec84..1c14b8579a 100644 > --- a/tools/xenstore/xenstored_transaction.c > +++ b/tools/xenstore/xenstored_transaction.c > @@ -479,8 +479,7 @@ int do_transaction_start(const void *ctx, struct connection *conn, > if (conn->transaction) > return EBUSY; > > - if (domain_is_unprivileged(conn) && > - conn->transaction_started > quota_max_transaction) > + if (domain_transaction_get(conn) > quota_max_transaction) > return ENOSPC; > > /* Attach transaction to ctx for autofree until it's complete */ > @@ -505,9 +504,9 @@ int do_transaction_start(const void *ctx, struct connection *conn, > list_add_tail(&trans->list, &conn->transaction_list); > talloc_steal(conn, trans); > talloc_set_destructor(trans, destroy_transaction); > - if (!conn->transaction_started) > + if (!conn->ta_start_time) I think it would make more sense to move this if just before the list_add_tail() and use (list_empty()) for the checked. This would make the code more consistent... > conn->ta_start_time = time(NULL); > - conn->transaction_started++; > + domain_transaction_inc(conn); > wrl_ntransactions++; > > snprintf(id_str, sizeof(id_str), "%u", trans->id); > @@ -533,8 +532,8 @@ int do_transaction_end(const void *ctx, struct connection *conn, > > conn->transaction = NULL; > list_del(&trans->list); > - conn->transaction_started--; > - if (!conn->transaction_started) > + domain_transaction_dec(conn); > + if (list_empty(&conn->transaction_list)) > conn->ta_start_time = 0; ... with this check and also easier to spot they are related. > > chk_quota = trans->node_created && domain_is_unprivileged(conn); > @@ -588,7 +587,6 @@ void conn_delete_all_transactions(struct connection *conn) > > assert(conn->transaction == NULL); > > - conn->transaction_started = 0; > conn->ta_start_time = 0; > } > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 02 19:41:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 19:41:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528794.822385 (Exim 4.92) (envelope-from ) id 1ptvsB-0007bx-Rc; Tue, 02 May 2023 19:41:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528794.822385; Tue, 02 May 2023 19:41:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptvsB-0007bq-O9; Tue, 02 May 2023 19:41:15 +0000 Received: by outflank-mailman (input) for mailman id 528794; Tue, 02 May 2023 19:41:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptvsA-0007bk-Re for xen-devel@lists.xenproject.org; Tue, 02 May 2023 19:41:14 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4a9a5fbc-e921-11ed-8611-37d641c3527e; Tue, 02 May 2023 21:41:12 +0200 (CEST) Received: from mimecast-mx02.redhat.com (66.187.233.88 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-335-YMLPGPKMO4SxOjhl3dEpxA-1; Tue, 02 May 2023 15:41:01 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E962D85A588; Tue, 2 May 2023 19:40:54 +0000 (UTC) Received: from localhost (unknown [10.39.192.230]) by smtp.corp.redhat.com (Postfix) with ESMTP id E85EC4020960; Tue, 2 May 2023 19:40:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a9a5fbc-e921-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683056471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6xENbjVvp+Pts3X84Cy2DsWSBfSYloGA+NzmbgbplRU=; b=fOt5e4RU5TCQFUGbDzQYsMURmBV4TTppPLwFTDXuiOX/1HAeWzGUfAZBXzXiWnCsNNQ+6K ZzSkLnn2K9rjM23rxRBj5B/SGsNXfh3w0WRwxeaPssy8iGjfAXZmMM26l+zMdFxLzhUNlf R+HFjIHQCOB0Hw5mFMP//N1FNQGQAhg= X-MC-Unique: YMLPGPKMO4SxOjhl3dEpxA-1 Date: Tue, 2 May 2023 15:40:45 -0400 From: Stefan Hajnoczi To: Kevin Wolf Cc: qemu-devel@nongnu.org, Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Juan Quintela , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Richard Henderson , Fam Zheng , "Michael S. Tsirkin" , Coiby Xu , David Woodhouse , Marcel Apfelbaum , Peter Lieven , Paul Durrant , "Richard W.M. Jones" , qemu-block@nongnu.org, Stefano Garzarella , Anthony Perard , Stefan Weil , Xie Yongji , Paolo Bonzini , Aarushi Mehta , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Eduardo Habkost , Stefano Stabellini , Hanna Reitz , Ronnie Sahlberg Subject: Re: [PATCH v4 06/20] block/export: wait for vhost-user-blk requests when draining Message-ID: <20230502194045.GC535070@fedora> References: <20230425172716.1033562-1-stefanha@redhat.com> <20230425172716.1033562-7-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XRuGd9g1z5oS2ell" Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 --XRuGd9g1z5oS2ell Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 02, 2023 at 05:42:51PM +0200, Kevin Wolf wrote: > Am 25.04.2023 um 19:27 hat Stefan Hajnoczi geschrieben: > > Each vhost-user-blk request runs in a coroutine. When the BlockBackend > > enters a drained section we need to enter a quiescent state. Currently > > any in-flight requests race with bdrv_drained_begin() because it is > > unaware of vhost-user-blk requests. > >=20 > > When blk_co_preadv/pwritev()/etc returns it wakes the > > bdrv_drained_begin() thread but vhost-user-blk request processing has > > not yet finished. The request coroutine continues executing while the > > main loop thread thinks it is in a drained section. > >=20 > > One example where this is unsafe is for blk_set_aio_context() where > > bdrv_drained_begin() is called before .aio_context_detached() and > > .aio_context_attach(). If request coroutines are still running after > > bdrv_drained_begin(), then the AioContext could change underneath them > > and they race with new requests processed in the new AioContext. This > > could lead to virtqueue corruption, for example. > >=20 > > (This example is theoretical, I came across this while reading the > > code and have not tried to reproduce it.) > >=20 > > It's easy to make bdrv_drained_begin() wait for in-flight requests: add > > a .drained_poll() callback that checks the VuServer's in-flight counter. > > VuServer just needs an API that returns true when there are requests in > > flight. The in-flight counter needs to be atomic. > >=20 > > Signed-off-by: Stefan Hajnoczi > > --- > > include/qemu/vhost-user-server.h | 4 +++- > > block/export/vhost-user-blk-server.c | 16 ++++++++++++++++ > > util/vhost-user-server.c | 14 ++++++++++---- > > 3 files changed, 29 insertions(+), 5 deletions(-) > >=20 > > diff --git a/include/qemu/vhost-user-server.h b/include/qemu/vhost-user= -server.h > > index bc0ac9ddb6..b1c1cda886 100644 > > --- a/include/qemu/vhost-user-server.h > > +++ b/include/qemu/vhost-user-server.h > > @@ -40,8 +40,9 @@ typedef struct { > > int max_queues; > > const VuDevIface *vu_iface; > > =20 > > + unsigned int in_flight; /* atomic */ > > + > > /* Protected by ctx lock */ > > - unsigned int in_flight; > > bool wait_idle; > > VuDev vu_dev; > > QIOChannel *ioc; /* The I/O channel with the client */ > > @@ -62,6 +63,7 @@ void vhost_user_server_stop(VuServer *server); > > =20 > > void vhost_user_server_inc_in_flight(VuServer *server); > > void vhost_user_server_dec_in_flight(VuServer *server); > > +bool vhost_user_server_has_in_flight(VuServer *server); > > =20 > > void vhost_user_server_attach_aio_context(VuServer *server, AioContext= *ctx); > > void vhost_user_server_detach_aio_context(VuServer *server); > > diff --git a/block/export/vhost-user-blk-server.c b/block/export/vhost-= user-blk-server.c > > index 841acb36e3..092b86aae4 100644 > > --- a/block/export/vhost-user-blk-server.c > > +++ b/block/export/vhost-user-blk-server.c > > @@ -272,7 +272,20 @@ static void vu_blk_exp_resize(void *opaque) > > vu_config_change_msg(&vexp->vu_server.vu_dev); > > } > > =20 > > +/* > > + * Ensures that bdrv_drained_begin() waits until in-flight requests co= mplete. > > + * > > + * Called with vexp->export.ctx acquired. > > + */ > > +static bool vu_blk_drained_poll(void *opaque) > > +{ > > + VuBlkExport *vexp =3D opaque; > > + > > + return vhost_user_server_has_in_flight(&vexp->vu_server); > > +} > > + > > static const BlockDevOps vu_blk_dev_ops =3D { > > + .drained_poll =3D vu_blk_drained_poll, > > .resize_cb =3D vu_blk_exp_resize, > > }; >=20 > You're adding a new function pointer to an existing BlockDevOps... >=20 > > @@ -314,6 +327,7 @@ static int vu_blk_exp_create(BlockExport *exp, Bloc= kExportOptions *opts, > > vu_blk_initialize_config(blk_bs(exp->blk), &vexp->blkcfg, > > logical_block_size, num_queues); > > =20 > > + blk_set_dev_ops(exp->blk, &vu_blk_dev_ops, vexp); > > blk_add_aio_context_notifier(exp->blk, blk_aio_attached, blk_aio_d= etach, > > vexp); > > =20 > > blk_set_dev_ops(exp->blk, &vu_blk_dev_ops, vexp); >=20 > ..but still add a second blk_set_dev_ops(). Maybe a bad merge conflict > resolution with commit ca858a5fe94? Thanks, I probably didn't have ca858a5fe94 in my tree when writing this code. > > @@ -323,6 +337,7 @@ static int vu_blk_exp_create(BlockExport *exp, Bloc= kExportOptions *opts, > > num_queues, &vu_blk_iface, errp)) { > > blk_remove_aio_context_notifier(exp->blk, blk_aio_attached, > > blk_aio_detach, vexp); > > + blk_set_dev_ops(exp->blk, NULL, NULL); > > g_free(vexp->handler.serial); > > return -EADDRNOTAVAIL; > > } > > @@ -336,6 +351,7 @@ static void vu_blk_exp_delete(BlockExport *exp) > > =20 > > blk_remove_aio_context_notifier(exp->blk, blk_aio_attached, blk_ai= o_detach, > > vexp); > > + blk_set_dev_ops(exp->blk, NULL, NULL); > > g_free(vexp->handler.serial); > > } >=20 > These two hunks are then probably already fixes for ca858a5fe94 and > should be a separate patch if so. Sure, I can split them out. hw/ doesn't need to call blk_set_dev_ops(blk, NULL, NULL) because hw/core/qdev-properties-system.c:release_drive() -> blk_detach_dev() does it automatically, but block/export does. It's easy to overlook and that's probably why ca858a5fe94 didn't include it. > > diff --git a/util/vhost-user-server.c b/util/vhost-user-server.c > > index 1622f8cfb3..2e6b640050 100644 > > --- a/util/vhost-user-server.c > > +++ b/util/vhost-user-server.c > > @@ -78,17 +78,23 @@ static void panic_cb(VuDev *vu_dev, const char *buf) > > void vhost_user_server_inc_in_flight(VuServer *server) > > { > > assert(!server->wait_idle); > > - server->in_flight++; > > + qatomic_inc(&server->in_flight); > > } > > =20 > > void vhost_user_server_dec_in_flight(VuServer *server) > > { > > - server->in_flight--; > > - if (server->wait_idle && !server->in_flight) { > > - aio_co_wake(server->co_trip); > > + if (qatomic_fetch_dec(&server->in_flight) =3D=3D 1) { > > + if (server->wait_idle) { > > + aio_co_wake(server->co_trip); > > + } > > } > > } > > =20 > > +bool vhost_user_server_has_in_flight(VuServer *server) > > +{ > > + return qatomic_load_acquire(&server->in_flight) > 0; > > +} > > + >=20 > Any reason why you left the server->in_flight accesses in > vu_client_trip() non-atomic? I don't remember if it was a mistake or if there is a reason why it's safe. I'll replace those accesses with calls to vhost_user_server_has_in_flight(). Stefan --XRuGd9g1z5oS2ell Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmRRZz0ACgkQnKSrs4Gr c8iEjwgAov+Ozs58HYaiYo0b4VnPoOnAM2QqHXYzmVRN4+5mqvFWNVKufgQMDbSG 1o1dgDNOCRU1tpOCUbNRYmvJxvYY6QA9Ho7AdLGPZc6jq2CR4LHarr5MP1Py5ktT dGAN6GFH3qzsf93j4wEa0HnWax5RvOdFEPxkK2JKgXRA+AesbOLRizK1q2P5p3TH 6I0SfPnLhlTeosVaQ4mRLkZuXNt5/bTeh54lW/NSLP6IpbBoB082Wqr1JqCwjdVO XxBNAMrMB/0oImJNHh9HSqpB2oHlL2FOa/yu++wNeZ1uzHdt7oRDpgwx2mQpMmiT /HhN2vFe1XsM621h8uV5aa4HZH7Hiw== =UcN5 -----END PGP SIGNATURE----- --XRuGd9g1z5oS2ell-- From xen-devel-bounces@lists.xenproject.org Tue May 02 19:54:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 19:54:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528799.822395 (Exim 4.92) (envelope-from ) id 1ptw59-0000qF-2f; Tue, 02 May 2023 19:54:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528799.822395; Tue, 02 May 2023 19:54:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptw58-0000q8-W9; Tue, 02 May 2023 19:54:38 +0000 Received: by outflank-mailman (input) for mailman id 528799; Tue, 02 May 2023 19:54:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptw57-0000q2-Lw for xen-devel@lists.xenproject.org; Tue, 02 May 2023 19:54:37 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2062c.outbound.protection.outlook.com [2a01:111:f400:7d00::62c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 28f94b9b-e923-11ed-8611-37d641c3527e; Tue, 02 May 2023 21:54:34 +0200 (CEST) Received: from DB6P18901CA0014.EURP189.PROD.OUTLOOK.COM (2603:10a6:4:16::24) by PAXPR08MB7365.eurprd08.prod.outlook.com (2603:10a6:102:225::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 19:54:30 +0000 Received: from DBAEUR03FT019.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:16:cafe::ee) by DB6P18901CA0014.outlook.office365.com (2603:10a6:4:16::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31 via Frontend Transport; Tue, 2 May 2023 19:54:30 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT019.mail.protection.outlook.com (100.127.142.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.20 via Frontend Transport; Tue, 2 May 2023 19:54:30 +0000 Received: ("Tessian outbound 3a01b65b5aad:v136"); Tue, 02 May 2023 19:54:30 +0000 Received: from b54e168d3d85.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E57027C9-C2EC-48B5-AFD4-76F064C796A6.1; Tue, 02 May 2023 19:54:23 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b54e168d3d85.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 02 May 2023 19:54:23 +0000 Received: from AM0PR08MB3745.eurprd08.prod.outlook.com (2603:10a6:208:ff::27) by AS8PR08MB7790.eurprd08.prod.outlook.com (2603:10a6:20b:527::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 19:54:20 +0000 Received: from AM0PR08MB3745.eurprd08.prod.outlook.com ([fe80::e6af:7fc5:bb80:9406]) by AM0PR08MB3745.eurprd08.prod.outlook.com ([fe80::e6af:7fc5:bb80:9406%7]) with mapi id 15.20.6340.031; Tue, 2 May 2023 19:54:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 28f94b9b-e923-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rIauXjVPwCZaMr0emwlQmLTVrakJ4XH4Bg+H0hwJ6Ps=; b=Dn+OGWmWdLsk3GfgTNzj4BxB6XYEAtHamV31fGGOKpf34aTy9eCCl/9jv29XAwE0M3KYpn8O0m31qIjN63kAcaLweCGllEYLESWPgghAkgWvtiqofn+FYEdYgesmNIG+KuGPir0ki2pVF+i+0l1u0K7+RRBBhpz3Zweh6PwRMlQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: e32b693e000c3f57 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FpthWXKaINUH8Ffau9FkQTjG/1yDRnGL3JXR6Pjfxo6/LU5+NlNRPOp16Xj32KG2DArUmXeeVZ1/J116fmtmngh7hDunEbvMVHIGeCC0BFt/GXB5Ml/AVWwPu+zn/EDIpU3NFp8VQg59Z/lu6DlMV7V38XAI5VjKLq4mldeESrwJZBmXpHuqfT6bbDQgGYxdStvULFR/NZoEPVaIAJHixe40c2Gq9mxwHCwCwhFHOGATDjm7weTLZ4ZcP0x/AII+DtPbxFefyQVxwGBXtqmoixGxAE7mtJ4wS5RVuhDR99XuNumLIjGwA2i7QhXx08id+bqOvHxw1GmyRgARGEEAeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rIauXjVPwCZaMr0emwlQmLTVrakJ4XH4Bg+H0hwJ6Ps=; b=b3wlaNk70l3h2uMgePNDcwa21sKbJarrPVzhT/TdQpxnK1zhVudO8FIDmp+i37fwixEE7/qfUH+ISMv5PUf5qrhiI6kswttR1aCobhlJwjWoC6+bB7epBLz+CNA/3u1zw626YrfIssy+Ed9hqOWt/YzKoplhObqbBQguXYnHK6OnZacJXfnhemlqbMt/un+X+89J7FK03VJ9yVtxLxcnFSXmAJtSp8x6AQEliLGWrBl88lOPLh6Wg4gLZlbItk+haXSmxyB4xHqinR1wF+ije5TH+U6djs2G5RvfTYabuJ8nZfnNVvKdBSIUyY5W+dynmG7w4iyhpkKaMrwiejqm5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rIauXjVPwCZaMr0emwlQmLTVrakJ4XH4Bg+H0hwJ6Ps=; b=Dn+OGWmWdLsk3GfgTNzj4BxB6XYEAtHamV31fGGOKpf34aTy9eCCl/9jv29XAwE0M3KYpn8O0m31qIjN63kAcaLweCGllEYLESWPgghAkgWvtiqofn+FYEdYgesmNIG+KuGPir0ki2pVF+i+0l1u0K7+RRBBhpz3Zweh6PwRMlQ= From: Luca Fancellu To: Anthony PERARD CC: Xen-devel , Bertrand Marquis , Wei Chen , Wei Liu , George Dunlap , Nick Rosbrook , Juergen Gross Subject: Re: [PATCH v6 10/12] xen/tools: add sve parameter in XL configuration Thread-Topic: [PATCH v6 10/12] xen/tools: add sve parameter in XL configuration Thread-Index: AQHZdnKI1/ryq6h2kEuVT2yTgC4YMq9HQ+EAgAAu74A= Date: Tue, 2 May 2023 19:54:19 +0000 Message-ID: <8C3DC6ED-83D8-4DD0-9C99-B34449304373@arm.com> References: <20230424060248.1488859-1-luca.fancellu@arm.com> <20230424060248.1488859-11-luca.fancellu@arm.com> <996db21b-e963-4259-884d-2131c548ca1e@perard> In-Reply-To: <996db21b-e963-4259-884d-2131c548ca1e@perard> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.500.231) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB3745:EE_|AS8PR08MB7790:EE_|DBAEUR03FT019:EE_|PAXPR08MB7365:EE_ X-MS-Office365-Filtering-Correlation-Id: ed8df2ad-d3f4-4f97-8c36-08db4b470b2b x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: nl7jwy/rHwCPApwMIp99tPwC058MrOC+sbuOUGWwMy0B4loMknKMU7rIELwR0U7EexJSfJimqvJN9M9BtR697nk60j/wIHfnE1XIplUMseFxr306WXBD2p6nQhyJOTIzIijiF122dxnzcKMBGVJv0gFZC1B2+HQ5BowBy40GBSl1Q30g+4p3XoROa239QlgdKF7QwcIcZV0H7QmQAIgMC2z2eRSXo9pGO5qg7Nu2ovn/e0oZN0ySxDUuMAb2cpy5t3jeLvgMRyh6L+eW4OXJA4QGxt3lmJ7RN/2HUX6eQrQfnd1XRfrJQcCsHsty/eF3UX+iTUXRSipXkYtlYLqL2BGcHFF58HfFIRghv8suVmdEyY62F9pMUEi2tBshNCGzkxDMs9R5tcAdDdEx2CaVn61et1UtAMw7JjkjQu55YJRMV2e1xhLhm1aIXurVUHQcKNXs3WFMvOdR0Uf7no5u6husfiMlLYaBb/Bo9oYIaC13bAX9ah2nuzR4/9p0ZM4+2s4vfgSAANd64DwyTe0Y2ujtenTuqg4mBvDIiCw6bBfHeZQXD6OSDJFc5Xhc6pqv4v+ZRtZJ3VcJBrZ+cDtVHtHoNKnB9oTWNadrc7HAogB7ZdZntg+5nruBE0h94UDqX1AbfCnxtKdXo6h4Zt+h6A== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3745.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(366004)(39860400002)(346002)(396003)(376002)(451199021)(53546011)(26005)(6512007)(6506007)(4326008)(76116006)(64756008)(66446008)(66556008)(6916009)(66476007)(66946007)(2616005)(33656002)(478600001)(40140700001)(86362001)(91956017)(83380400001)(71200400001)(316002)(38070700005)(122000001)(38100700002)(41300700001)(2906002)(6486002)(36756003)(186003)(54906003)(5660300002)(8936002)(8676002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7790 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 017bfbe8-4da0-47fe-6519-08db4b4704c0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +gV8+WY3y81bNs8Edn910en4Q0IWtOLF4ggYKDGMXTxrTWrRgTUra+0ePZDtO2Qz+MBTXf2uWQEA0amTLNEfPknFXNN78FEeFzvCeV3tCOiXu9ex75UKe877xNnD0B6uxWEVSg3RoxXGjgUHmNT/pq6iRwhOBQK9GkdzL6Cq3oVvRxr2U53t5VACqNXTSAeZEPY8dipVcHr6H8Ta8oH1kSInH5Rn40/GoHSyr4dqX4W/BBpoFK3JAe7OvHWmzisHP2vh2lmUyqLs1Z9YbD4BKQhjq+YOhHoz/JFMKRyKylRsQv9xDvECtM3DvnRhBxlOM3ZHOkwBVLl8Rq7HjKWvo8LgaOYn397VpdbMJew4a6i9A7nnrxMSKMjx/QVZbO4fv68DMLIAmc+CoKN7QtgVc2Ezen8o0ksGmUUsQre/ny/sxHdTn/DNrmzWVVQCezMySDV355DuRCycU/ZfRnrfYiYjcLOOOMCWRgMFdx7l1SM56liV38U6P6PM18oh8n1+yv0sddGYVdBTiOo5tfDblRa6dIyUht70dYih8i5eOUeoz0yF7VZwm3EeykFObTEJr5TmM8N/3VLRlfbFvufRpco6qHsnqysVBTdlFRqXruSn+pg89cX3eitNlxDwHlH2HihSw79rJcEYy/a+d3icNnnAcW6TRPKHMSQaFSN3x+P+GC+4iGtRxpu0MBGJHfgz5BWzh1pgr8HHFKIed/wscv/LyBbZjH7DXEYDmVrduPg= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(39860400002)(136003)(396003)(451199021)(40470700004)(36840700001)(46966006)(6862004)(86362001)(40460700003)(5660300002)(8676002)(70206006)(8936002)(41300700001)(81166007)(356005)(82740400003)(70586007)(4326008)(316002)(40480700001)(2906002)(6486002)(34020700004)(36860700001)(36756003)(33656002)(2616005)(107886003)(53546011)(186003)(26005)(40140700001)(6506007)(82310400005)(6512007)(83380400001)(54906003)(47076005)(478600001)(336012);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 19:54:30.5221 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ed8df2ad-d3f4-4f97-8c36-08db4b470b2b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7365 Hi Anthony, Thank you for your review. > On 2 May 2023, at 18:06, Anthony PERARD wrote= : >=20 > On Mon, Apr 24, 2023 at 07:02:46AM +0100, Luca Fancellu wrote: >> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c >> index ddc7b2a15975..1e69dac2c4fa 100644 >> --- a/tools/libs/light/libxl_arm.c >> +++ b/tools/libs/light/libxl_arm.c >> @@ -211,6 +213,12 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc= , >> return ERROR_FAIL; >> } >>=20 >> + /* Parameter is sanitised in libxl__arch_domain_build_info_setdefau= lt */ >> + if (d_config->b_info.arch_arm.sve_vl) { >> + /* Vector length is divided by 128 in struct xen_domctl_created= omain */ >> + config->arch.sve_vl =3D d_config->b_info.arch_arm.sve_vl / 128U= ; >> + } >> + >> return 0; >> } >>=20 >> @@ -1681,6 +1689,26 @@ int libxl__arch_domain_build_info_setdefault(libx= l__gc *gc, >> /* ACPI is disabled by default */ >> libxl_defbool_setdefault(&b_info->acpi, false); >>=20 >> + /* Sanitise SVE parameter */ >> + if (b_info->arch_arm.sve_vl) { >> + unsigned int max_sve_vl =3D >> + arch_capabilities_arm_sve(physinfo->arch_capabilities); >> + >> + if (!max_sve_vl) { >> + LOG(ERROR, "SVE is unsupported on this machine."); >> + return ERROR_FAIL; >> + } >> + >> + if (LIBXL_SVE_TYPE_HW =3D=3D b_info->arch_arm.sve_vl) { >> + b_info->arch_arm.sve_vl =3D max_sve_vl; >> + } else if (b_info->arch_arm.sve_vl > max_sve_vl) { >> + LOG(ERROR, >> + "Invalid sve value: %d. Platform supports up to %u bits= ", >> + b_info->arch_arm.sve_vl, max_sve_vl); >> + return ERROR_FAIL; >> + } >=20 > You still need to check that sve_vl is one of the value from the enum, > or that the value is divisible by 128. I have probably missed something, I thought that using the way below to specify the input I had for free that the value is 0 or divisible by 128, i= s it not the case? Who can write to b_info->arch_arm.sve_vl different value from the enum we specified in the .idl? >=20 >> + } >> + >> if (b_info->type !=3D LIBXL_DOMAIN_TYPE_PV) >> return 0; >>=20 >> diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_t= ypes.idl >> index fd31dacf7d5a..9e48bb772646 100644 >> --- a/tools/libs/light/libxl_types.idl >> +++ b/tools/libs/light/libxl_types.idl >> @@ -523,6 +523,27 @@ libxl_tee_type =3D Enumeration("tee_type", [ >> (1, "optee") >> ], init_val =3D "LIBXL_TEE_TYPE_NONE") >>=20 >> +libxl_sve_type =3D Enumeration("sve_type", [ >> + (-1, "hw"), >> + (0, "disabled"), >> + (128, "128"), >> + (256, "256"), >> + (384, "384"), >> + (512, "512"), >> + (640, "640"), >> + (768, "768"), >> + (896, "896"), >> + (1024, "1024"), >> + (1152, "1152"), >> + (1280, "1280"), >> + (1408, "1408"), >> + (1536, "1536"), >> + (1664, "1664"), >> + (1792, "1792"), >> + (1920, "1920"), >> + (2048, "2048") >> + ], init_val =3D "LIBXL_SVE_TYPE_DISABLED") >=20 > I'm not sure if I like that or not. Is there a reason to stop at 2048? > It is possible that there will be more value available in the future? Uhm... possibly there might be some extension, I thought that when it will be the case, the only thing to do was to add another entry, I used this way also to have for free the checks on the %128 and maximum 2048. >=20 > Also this mean that users of libxl (like libvirt) would be supposed to > use LIBXL_SVE_TYPE_1024 for e.g., or use libxl_sve_type_from_string(). >=20 > Also, it feels weird to me to mostly use numerical value of the enum > rather than the enum itself. >=20 > Anyway, hopefully that enum will work fine. >=20 >> libxl_rdm_reserve =3D Struct("rdm_reserve", [ >> ("strategy", libxl_rdm_reserve_strategy), >> ("policy", libxl_rdm_reserve_policy), >=20 > Thanks, >=20 > --=20 > Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue May 02 20:03:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 20:03:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528802.822405 (Exim 4.92) (envelope-from ) id 1ptwD9-0002UO-T7; Tue, 02 May 2023 20:02:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528802.822405; Tue, 02 May 2023 20:02:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptwD9-0002UH-Pt; Tue, 02 May 2023 20:02:55 +0000 Received: by outflank-mailman (input) for mailman id 528802; Tue, 02 May 2023 20:02:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptwD8-0002UB-MN for xen-devel@lists.xenproject.org; Tue, 02 May 2023 20:02:54 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 506a762f-e924-11ed-8611-37d641c3527e; Tue, 02 May 2023 22:02:50 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-551-8i9sxkcoOrucqmHkxzDdSA-1; Tue, 02 May 2023 16:02:47 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C708A101A531; Tue, 2 May 2023 20:02:46 +0000 (UTC) Received: from localhost (unknown [10.39.192.230]) by smtp.corp.redhat.com (Postfix) with ESMTP id B65FF63F5B; Tue, 2 May 2023 20:02:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 506a762f-e924-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683057769; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7lfhqttiODmbNxuxzmQIGPLL6DVlwheJNNJYYd5PHZI=; b=AGFtq8/EGGpm3JUeI6/CRMExUZ6AnZ5zcqDaOdxHzwxRxLC1k41BXmbB7V/2ZQznGsWuQ2 6UXIAgqnPhyJc54mAl82el0Q/+FQQv8R22QPGyAhZPHmsL7on8f/869spz1FFVqXnORij1 f1cRVtmlXDbCO5FcsKSFWKc88FvPOTE= X-MC-Unique: 8i9sxkcoOrucqmHkxzDdSA-1 Date: Tue, 2 May 2023 16:02:43 -0400 From: Stefan Hajnoczi To: Kevin Wolf Cc: qemu-devel@nongnu.org, Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Juan Quintela , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Richard Henderson , Fam Zheng , "Michael S. Tsirkin" , Coiby Xu , David Woodhouse , Marcel Apfelbaum , Peter Lieven , Paul Durrant , "Richard W.M. Jones" , qemu-block@nongnu.org, Stefano Garzarella , Anthony Perard , Stefan Weil , Xie Yongji , Paolo Bonzini , Aarushi Mehta , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Eduardo Habkost , Stefano Stabellini , Hanna Reitz , Ronnie Sahlberg , Zhengui Li , Daniil Tatianin Subject: Re: [PATCH v4 04/20] virtio-scsi: stop using aio_disable_external() during unplug Message-ID: <20230502200243.GD535070@fedora> References: <20230425172716.1033562-1-stefanha@redhat.com> <20230425172716.1033562-5-stefanha@redhat.com> <20230501150934.GA14869@fedora> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KLJLJshWTSqDDVpb" Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 --KLJLJshWTSqDDVpb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 02, 2023 at 03:19:52PM +0200, Kevin Wolf wrote: > Am 01.05.2023 um 17:09 hat Stefan Hajnoczi geschrieben: > > On Fri, Apr 28, 2023 at 04:22:55PM +0200, Kevin Wolf wrote: > > > Am 25.04.2023 um 19:27 hat Stefan Hajnoczi geschrieben: > > > > This patch is part of an effort to remove the aio_disable_external() > > > > API because it does not fit in a multi-queue block layer world where > > > > many AioContexts may be submitting requests to the same disk. > > > >=20 > > > > The SCSI emulation code is already in good shape to stop using > > > > aio_disable_external(). It was only used by commit 9c5aad84da1c > > > > ("virtio-scsi: fixed virtio_scsi_ctx_check failed when detaching sc= si > > > > disk") to ensure that virtio_scsi_hotunplug() works while the guest > > > > driver is submitting I/O. > > > >=20 > > > > Ensure virtio_scsi_hotunplug() is safe as follows: > > > >=20 > > > > 1. qdev_simple_device_unplug_cb() -> qdev_unrealize() -> > > > > device_set_realized() calls qatomic_set(&dev->realized, false) so > > > > that future scsi_device_get() calls return NULL because they exc= lude > > > > SCSIDevices with realized=3Dfalse. > > > >=20 > > > > That means virtio-scsi will reject new I/O requests to this > > > > SCSIDevice with VIRTIO_SCSI_S_BAD_TARGET even while > > > > virtio_scsi_hotunplug() is still executing. We are protected aga= inst > > > > new requests! > > > >=20 > > > > 2. Add a call to scsi_device_purge_requests() from scsi_unrealize()= so > > > > that in-flight requests are cancelled synchronously. This ensures > > > > that no in-flight requests remain once qdev_simple_device_unplug= _cb() > > > > returns. > > > >=20 > > > > Thanks to these two conditions we don't need aio_disable_external() > > > > anymore. > > > >=20 > > > > Cc: Zhengui Li > > > > Reviewed-by: Paolo Bonzini > > > > Reviewed-by: Daniil Tatianin > > > > Signed-off-by: Stefan Hajnoczi > > >=20 > > > qemu-iotests 040 starts failing for me after this patch, with what lo= oks > > > like a use-after-free error of some kind. > > >=20 > > > (gdb) bt > > > #0 0x000055b6e3e1f31c in job_type (job=3D0xe3e3e3e3e3e3e3e3) at ../j= ob.c:238 > > > #1 0x000055b6e3e1cee5 in is_block_job (job=3D0xe3e3e3e3e3e3e3e3) at = =2E./blockjob.c:41 > > > #2 0x000055b6e3e1ce7d in block_job_next_locked (bjob=3D0x55b6e72b757= 0) at ../blockjob.c:54 > > > #3 0x000055b6e3df6370 in blockdev_mark_auto_del (blk=3D0x55b6e74af0a= 0) at ../blockdev.c:157 > > > #4 0x000055b6e393e23b in scsi_qdev_unrealize (qdev=3D0x55b6e7c04d40)= at ../hw/scsi/scsi-bus.c:303 > > > #5 0x000055b6e3db0d0e in device_set_realized (obj=3D0x55b6e7c04d40, = value=3Dfalse, errp=3D0x55b6e497c918 ) at ../hw/core/qdev.c:599 > > > #6 0x000055b6e3dba36e in property_set_bool (obj=3D0x55b6e7c04d40, v= =3D0x55b6e7d7f290, name=3D0x55b6e41bd6d8 "realized", opaque=3D0x55b6e7246d2= 0, errp=3D0x55b6e497c918 ) > > > at ../qom/object.c:2285 > > > #7 0x000055b6e3db7e65 in object_property_set (obj=3D0x55b6e7c04d40, = name=3D0x55b6e41bd6d8 "realized", v=3D0x55b6e7d7f290, errp=3D0x55b6e497c918= ) at ../qom/object.c:1420 > > > #8 0x000055b6e3dbd84a in object_property_set_qobject (obj=3D0x55b6e7= c04d40, name=3D0x55b6e41bd6d8 "realized", value=3D0x55b6e74c1890, errp=3D0x= 55b6e497c918 ) > > > at ../qom/qom-qobject.c:28 > > > #9 0x000055b6e3db8570 in object_property_set_bool (obj=3D0x55b6e7c04= d40, name=3D0x55b6e41bd6d8 "realized", value=3Dfalse, errp=3D0x55b6e497c918= ) at ../qom/object.c:1489 > > > #10 0x000055b6e3daf2b5 in qdev_unrealize (dev=3D0x55b6e7c04d40) at ..= /hw/core/qdev.c:306 > > > #11 0x000055b6e3db509d in qdev_simple_device_unplug_cb (hotplug_dev= =3D0x55b6e81c3630, dev=3D0x55b6e7c04d40, errp=3D0x7ffec5519200) at ../hw/co= re/qdev-hotplug.c:72 > > > #12 0x000055b6e3c520f9 in virtio_scsi_hotunplug (hotplug_dev=3D0x55b6= e81c3630, dev=3D0x55b6e7c04d40, errp=3D0x7ffec5519200) at ../hw/scsi/virtio= -scsi.c:1065 > > > #13 0x000055b6e3db4dec in hotplug_handler_unplug (plug_handler=3D0x55= b6e81c3630, plugged_dev=3D0x55b6e7c04d40, errp=3D0x7ffec5519200) at ../hw/c= ore/hotplug.c:56 > > > #14 0x000055b6e3a28f84 in qdev_unplug (dev=3D0x55b6e7c04d40, errp=3D0= x7ffec55192e0) at ../softmmu/qdev-monitor.c:935 > > > #15 0x000055b6e3a290fa in qmp_device_del (id=3D0x55b6e74c1760 "scsi0"= , errp=3D0x7ffec55192e0) at ../softmmu/qdev-monitor.c:955 > > > #16 0x000055b6e3fb0a5f in qmp_marshal_device_del (args=3D0x7f61cc005e= b0, ret=3D0x7f61d5a8ae38, errp=3D0x7f61d5a8ae40) at qapi/qapi-commands-qdev= =2Ec:114 > > > #17 0x000055b6e3fd52e1 in do_qmp_dispatch_bh (opaque=3D0x7f61d5a8ae08= ) at ../qapi/qmp-dispatch.c:128 > > > #18 0x000055b6e4007b9e in aio_bh_call (bh=3D0x55b6e7dea730) at ../uti= l/async.c:155 > > > #19 0x000055b6e4007d2e in aio_bh_poll (ctx=3D0x55b6e72447c0) at ../ut= il/async.c:184 > > > #20 0x000055b6e3fe3b45 in aio_dispatch (ctx=3D0x55b6e72447c0) at ../u= til/aio-posix.c:421 > > > #21 0x000055b6e4009544 in aio_ctx_dispatch (source=3D0x55b6e72447c0, = callback=3D0x0, user_data=3D0x0) at ../util/async.c:326 > > > #22 0x00007f61ddc14c7f in g_main_dispatch (context=3D0x55b6e7244b20) = at ../glib/gmain.c:3454 > > > #23 g_main_context_dispatch (context=3D0x55b6e7244b20) at ../glib/gma= in.c:4172 > > > #24 0x000055b6e400a7e8 in glib_pollfds_poll () at ../util/main-loop.c= :290 > > > #25 0x000055b6e400a0c2 in os_host_main_loop_wait (timeout=3D0) at ../= util/main-loop.c:313 > > > #26 0x000055b6e4009fa2 in main_loop_wait (nonblocking=3D0) at ../util= /main-loop.c:592 > > > #27 0x000055b6e3a3047b in qemu_main_loop () at ../softmmu/runstate.c:= 731 > > > #28 0x000055b6e3dab27d in qemu_default_main () at ../softmmu/main.c:37 > > > #29 0x000055b6e3dab2b8 in main (argc=3D24, argv=3D0x7ffec55196a8) at = =2E./softmmu/main.c:48 > > > (gdb) p jobs > > > $4 =3D {lh_first =3D 0x0} > >=20 > > I wasn't able to reproduce this with gcc 13.1.1 or clang 16.0.1: > >=20 > > $ tests/qemu-iotests/check -qcow2 040 > >=20 > > Any suggestions on how to reproduce the issue? >=20 > It happens consistently for me with the same command line, both with gcc > and clang. >=20 > gcc (GCC) 12.2.1 20221121 (Red Hat 12.2.1-4) > clang version 15.0.7 (Fedora 15.0.7-2.fc37) >=20 > Maybe there is a semantic merge conflict? I have applied the series on > top of master (05d50ba2d4) and my block branch (88f81f7bc8). I can't find 88f81f7bc8 but rebased on repo.or.cz/qemu/kevin.git block (4514dac7f2e9) and the test passes here. I rebased on qemu.git/master (05d50ba2d4) and it also passes. Please let me know if the following tree (a0ff680a72f6) works on your machine: https://gitlab.com/stefanha/qemu/-/tree/remove-aio_disable_external Thanks, Stefan --KLJLJshWTSqDDVpb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmRRbGMACgkQnKSrs4Gr c8iL5Af+MRYfwim9BEWCQ+OFF9rPydT4E+bBnTgMftUJz8XcaxXz5sDzpq3sXhvM UXDSMHg1/RY38aMEGGT1kPtlxI3zUO3pwNckFeU3rpqa22dI1yxMwI92Rn29LLIk 8txmNTd4eG89Vgvvl3zrqV/budvInTRmy7ZtMgMnNJ+SGAMxWWtakCZlBQzw7WBh 946sfiub2lvQKnvBgQJJLCOfVs3drSqV9+4IdzkpGwjN5fruVe3WhKC98Ha88ACF L4cpa9MvlMyJvrxmPdB2uL8Eyn1mV3uLVi8Z0nRwiy4/mtahrGMZ3jkEJNi3Zn12 qpT/iMyl9DjsAj5nh2ElduicM7QFgw== =9x4Q -----END PGP SIGNATURE----- --KLJLJshWTSqDDVpb-- From xen-devel-bounces@lists.xenproject.org Tue May 02 20:05:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 20:05:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528806.822415 (Exim 4.92) (envelope-from ) id 1ptwFp-00034v-B0; Tue, 02 May 2023 20:05:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528806.822415; Tue, 02 May 2023 20:05:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptwFp-00034o-6i; Tue, 02 May 2023 20:05:41 +0000 Received: by outflank-mailman (input) for mailman id 528806; Tue, 02 May 2023 20:05:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptwFo-00034i-E3 for xen-devel@lists.xenproject.org; Tue, 02 May 2023 20:05:40 +0000 Received: from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de [81.169.146.160]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b5024652-e924-11ed-b225-6b7b168915f2; Tue, 02 May 2023 22:05:38 +0200 (CEST) Received: from sender by smtp.strato.de (RZmta 49.4.0 AUTH) with ESMTPSA id x6987cz42K5TeWg (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Tue, 2 May 2023 22:05:29 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b5024652-e924-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1683057929; cv=none; d=strato.com; s=strato-dkim-0002; b=cG8KjmyrRrTYB5GwSRIc8LwpK66j62bJNlj/2huPJn8NfiXUGLJafuQMCWyQry7VpL jsiu4rKFyCiqsQhvULmKEPR2drVTwIlcbcfRqc8uJjiWrHxKkLy+iPfyRcUz6pGKoK6x LctszF9rh0ZTALpbHTLgLoN52mjhartSdrK+bZKpVVvkxeKzO8eUt25tXc3CVuMKg832 WSmu26Xq+fzWNI04vHMr1jOj7IgOmDqSrrXbeCDojL5K+nw1Ac0Wijjxy4kJvElFaPSh XedWXrpuA/lazArBvSlvfkfxLFY1W5oeVw4rBp7FxLJUQ6mr1p+4AsQav0qv/sfNQzbO LTPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1683057929; s=strato-dkim-0002; d=strato.com; h=Message-Id:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=Jcpwk8O1aNbRAScb4kL6cbWNb5fNbiHkZRl03EzEa2Y=; b=R9NQNLPDlwFbs06f7FnhVtVR0BGo0RnuNjeRbXLoxYMyQa12noGM2g2p+s73wzLRH+ Bszkph2/uBTNc/wnIusfmGYuD7cOVSg+S8jA18RNFLXdzYrfdQkESBKlVTW5kYL/BaGS Z340NeHgAqYK6R63zabC4PXJknQyJ8iGQKJoWyqaqE/1JPiN8Rr0EbIxQqTbBe3r+BLr IDTjw0BWl2SShIWDgLOhn7Jk4ehL7OEXOHY8AYbUc2H0KeKjVP/KSv+sLvJDHgUDrdq1 J2y8hW2qI1/nyRs3NhPq05RVajCCFZ3xnI2fc/qvJydIQzLb3SwXQ/81uoJDUayR20rx hPvQ== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1683057929; s=strato-dkim-0002; d=aepfle.de; h=Message-Id:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=Jcpwk8O1aNbRAScb4kL6cbWNb5fNbiHkZRl03EzEa2Y=; b=UKZD/btOkhsmuzrQ2ax97YV/4tJajWTvblfrPjEFQne5BfdY4rKA8Cz6n6xbZ0Gdoc yus83LWHbtzPEX8fkj7TQy7YAnlDewoqsMElkcSFBd/aRmUc1A5UFE3HZUST+O+08IU4 ZGaxLts0aJdg+h8X0Eijk+jo+RVM+W/rZdClZUp+yhJpG5UMbOfcLAmlcimLbJSWS1mf 7K62KuoHrtJz9TINh3P7UT7/pslAUUfYTCp0i+pZpBGYl0NZPTssnriQva8L0hqe0lvV 8MAjzkRlWNIlZx/+B9LDNUfIWaDcgM/MXxzwCdB/MA+wPviJFMlRbQJufLfHccx3RvPX hzCw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1683057929; s=strato-dkim-0003; d=aepfle.de; h=Message-Id:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=Jcpwk8O1aNbRAScb4kL6cbWNb5fNbiHkZRl03EzEa2Y=; b=bo7z4PjawhUc+CdXTcaWsyybfHs0y1hAbRsIzFKNpPagK/56U2ateLU4sqT2NpKRYu WjuNsz/pTOdiJ62akIBw== X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg4wqVv7FZ8tH5EUSbMVU80kUr7f4QlYaI60OjHt/Q==" From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini Subject: [PATCH v1] automation: remove python2 from opensuse images Date: Tue, 2 May 2023 20:05:27 +0000 Message-Id: <20230502200527.5365-1-olaf@aepfle.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="us-ascii" The upcoming Leap 15.5 will come without a binary named 'python'. Prepare the suse images for that change. Starting with Xen 4.14 python3 can be used for build. Signed-off-by: Olaf Hering --- automation/build/suse/opensuse-leap.dockerfile | 2 -- automation/build/suse/opensuse-tumbleweed.dockerfile | 1 - 2 files changed, 3 deletions(-) diff --git a/automation/build/suse/opensuse-leap.dockerfile b/automation/build/suse/opensuse-leap.dockerfile index c7973dd6ab..79de83ac20 100644 --- a/automation/build/suse/opensuse-leap.dockerfile +++ b/automation/build/suse/opensuse-leap.dockerfile @@ -58,8 +58,6 @@ RUN zypper install -y --no-recommends \ 'pkgconfig(libpci)' \ 'pkgconfig(sdl)' \ 'pkgconfig(sdl2)' \ - python \ - python-devel \ python3-devel \ systemd-devel \ tar \ diff --git a/automation/build/suse/opensuse-tumbleweed.dockerfile b/automation/build/suse/opensuse-tumbleweed.dockerfile index 7e5f22acef..abb25c8c84 100644 --- a/automation/build/suse/opensuse-tumbleweed.dockerfile +++ b/automation/build/suse/opensuse-tumbleweed.dockerfile @@ -61,7 +61,6 @@ RUN zypper install -y --no-recommends \ 'pkgconfig(libpci)' \ 'pkgconfig(sdl)' \ 'pkgconfig(sdl2)' \ - python-devel \ python3-devel \ systemd-devel \ tar \ From xen-devel-bounces@lists.xenproject.org Tue May 02 20:07:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 20:07:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528812.822425 (Exim 4.92) (envelope-from ) id 1ptwH1-0003h0-Mu; Tue, 02 May 2023 20:06:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528812.822425; Tue, 02 May 2023 20:06:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptwH1-0003gt-K4; Tue, 02 May 2023 20:06:55 +0000 Received: by outflank-mailman (input) for mailman id 528812; Tue, 02 May 2023 20:06:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptwH0-0003gj-Er for xen-devel@lists.xenproject.org; Tue, 02 May 2023 20:06:54 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e0bd3cb8-e924-11ed-b225-6b7b168915f2; Tue, 02 May 2023 22:06:52 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-228-EPMPoQX1NfuQ2XU-a2gp2Q-1; Tue, 02 May 2023 16:06:48 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5758A85A588; Tue, 2 May 2023 20:06:47 +0000 (UTC) Received: from localhost (unknown [10.39.192.230]) by smtp.corp.redhat.com (Postfix) with ESMTP id C37E1C15BAE; Tue, 2 May 2023 20:06:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e0bd3cb8-e924-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683058011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LgDhtbpQWSSNsgeEph8esneZJVWEPWcWGLZOnDkeVKE=; b=Kdbe6o3RSShoyolv1BJEpZjDP6CP1+4m4XuVtcQZgsQ8LZnWJ0ZRruYghKu6UwyXZPiH6I qEb+XNd2k/EysxjXB5O8vTPgiIC9pDlAMRg4iKbCoMn30TV93xjZDaSZ0cHl1p6ydQ5qJg fz0cE2caF7n03Xrp0fzPYt9s6obYr9Y= X-MC-Unique: EPMPoQX1NfuQ2XU-a2gp2Q-1 Date: Tue, 2 May 2023 16:06:45 -0400 From: Stefan Hajnoczi To: Kevin Wolf Cc: qemu-devel@nongnu.org, Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Juan Quintela , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Richard Henderson , Fam Zheng , "Michael S. Tsirkin" , Coiby Xu , David Woodhouse , Marcel Apfelbaum , Peter Lieven , Paul Durrant , "Richard W.M. Jones" , qemu-block@nongnu.org, Stefano Garzarella , Anthony Perard , Stefan Weil , Xie Yongji , Paolo Bonzini , Aarushi Mehta , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Eduardo Habkost , Stefano Stabellini , Hanna Reitz , Ronnie Sahlberg Subject: Re: [PATCH v4 07/20] block/export: stop using is_external in vhost-user-blk server Message-ID: <20230502200645.GE535070@fedora> References: <20230425172716.1033562-1-stefanha@redhat.com> <20230425172716.1033562-8-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="O5xAqfWJ9HxCWIfk" Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 --O5xAqfWJ9HxCWIfk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 02, 2023 at 06:04:24PM +0200, Kevin Wolf wrote: > Am 25.04.2023 um 19:27 hat Stefan Hajnoczi geschrieben: > > vhost-user activity must be suspended during bdrv_drained_begin/end(). > > This prevents new requests from interfering with whatever is happening > > in the drained section. > >=20 > > Previously this was done using aio_set_fd_handler()'s is_external > > argument. In a multi-queue block layer world the aio_disable_external() > > API cannot be used since multiple AioContext may be processing I/O, not > > just one. > >=20 > > Switch to BlockDevOps->drained_begin/end() callbacks. > >=20 > > Signed-off-by: Stefan Hajnoczi > > --- > > block/export/vhost-user-blk-server.c | 43 ++++++++++++++-------------- > > util/vhost-user-server.c | 10 +++---- > > 2 files changed, 26 insertions(+), 27 deletions(-) > >=20 > > diff --git a/block/export/vhost-user-blk-server.c b/block/export/vhost-= user-blk-server.c > > index 092b86aae4..d20f69cd74 100644 > > --- a/block/export/vhost-user-blk-server.c > > +++ b/block/export/vhost-user-blk-server.c > > @@ -208,22 +208,6 @@ static const VuDevIface vu_blk_iface =3D { > > .process_msg =3D vu_blk_process_msg, > > }; > > =20 > > -static void blk_aio_attached(AioContext *ctx, void *opaque) > > -{ > > - VuBlkExport *vexp =3D opaque; > > - > > - vexp->export.ctx =3D ctx; > > - vhost_user_server_attach_aio_context(&vexp->vu_server, ctx); > > -} > > - > > -static void blk_aio_detach(void *opaque) > > -{ > > - VuBlkExport *vexp =3D opaque; > > - > > - vhost_user_server_detach_aio_context(&vexp->vu_server); > > - vexp->export.ctx =3D NULL; > > -} >=20 > So for changing the AioContext, we now rely on the fact that the node to > be changed is always drained, so the drain callbacks implicitly cover > this case, too? Yes. > > static void > > vu_blk_initialize_config(BlockDriverState *bs, > > struct virtio_blk_config *config, > > @@ -272,6 +256,25 @@ static void vu_blk_exp_resize(void *opaque) > > vu_config_change_msg(&vexp->vu_server.vu_dev); > > } > > =20 > > +/* Called with vexp->export.ctx acquired */ > > +static void vu_blk_drained_begin(void *opaque) > > +{ > > + VuBlkExport *vexp =3D opaque; > > + > > + vhost_user_server_detach_aio_context(&vexp->vu_server); > > +} >=20 > Compared to the old code, we're losing the vexp->export.ctx =3D NULL. This > is correct at this point because after drained_begin we still keep > processing requests until we arrive at a quiescent state. >=20 > However, if we detach the AioContext because we're deleting the > iothread, won't we end up with a dangling pointer in vexp->export.ctx? > Or can we be certain that nothing interesting happens before drained_end > updates it with a new valid pointer again? If you want I can add the detach() callback back again and set ctx to NULL there? Stefan --O5xAqfWJ9HxCWIfk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmRRbVUACgkQnKSrs4Gr c8i4OAf+KMBGicSKs6PxKeNThQpFSMAOYw12vnQg0N97hfarjPeaKf9lZmdJLKB7 McPjsLuRThNx0snklzDlcRovZKNZcV5EjEddXKA1ikDqZXDeLue4X717xIIV1RF0 oYAyyPcTXr9V1JKG2nKQzz1fK/zb0oXyEycRI1uPB1YjiL/NnBUZEdAG3DEZmBXK qjZcFpvChPe6DFydAfunLcRtoSASIb6cBLCeOFHXuTrKixFZeG9QDW87ONOMnG7D JF3Cjcfsn94R6SFWDOK2TGeKF7IY6kVJa+gOJXyTE2+n2vZhpezwmroM4kprRJGc TiMUeoBbZl3Oi5FrMOcj7MOeMEdRlw== =PCPd -----END PGP SIGNATURE----- --O5xAqfWJ9HxCWIfk-- From xen-devel-bounces@lists.xenproject.org Tue May 02 20:10:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 20:10:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528815.822435 (Exim 4.92) (envelope-from ) id 1ptwKg-0005DY-6G; Tue, 02 May 2023 20:10:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528815.822435; Tue, 02 May 2023 20:10:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptwKg-0005DR-3X; Tue, 02 May 2023 20:10:42 +0000 Received: by outflank-mailman (input) for mailman id 528815; Tue, 02 May 2023 20:10:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptwKe-0005DL-MF for xen-devel@lists.xenproject.org; Tue, 02 May 2023 20:10:40 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6775e7a5-e925-11ed-8611-37d641c3527e; Tue, 02 May 2023 22:10:38 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-215-bZJNyyK4N4GaEmywDujudQ-1; Tue, 02 May 2023 16:10:34 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 04349381D4CF; Tue, 2 May 2023 20:10:33 +0000 (UTC) Received: from localhost (unknown [10.39.192.230]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4A3BA2026D16; Tue, 2 May 2023 20:10:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6775e7a5-e925-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683058237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G3M6X6Cb/uW8g9mA7FuVSmxMkf0IsGJPoGtjU0Aq7ck=; b=RZxDJe5lu4RnGcmN+KYDTrqtX7hrzuZzbT2Beipg3nNRdhCAPthdixq8qoRBt3l59wscW8 qcsgj0Zt4h1IxBUffsPO2o3AT1V9brxXxYH/02H2VCMtD8+VoZMDrUTwarfpMVchnSUVAo 6U8cRZm+2CHan+r0/c7LeYkJciKsnZA= X-MC-Unique: bZJNyyK4N4GaEmywDujudQ-1 Date: Tue, 2 May 2023 16:10:29 -0400 From: Stefan Hajnoczi To: Kevin Wolf Cc: qemu-devel@nongnu.org, Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Juan Quintela , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Richard Henderson , Fam Zheng , "Michael S. Tsirkin" , Coiby Xu , David Woodhouse , Marcel Apfelbaum , Peter Lieven , Paul Durrant , "Richard W.M. Jones" , qemu-block@nongnu.org, Stefano Garzarella , Anthony Perard , Stefan Weil , Xie Yongji , Paolo Bonzini , Aarushi Mehta , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Eduardo Habkost , Stefano Stabellini , Hanna Reitz , Ronnie Sahlberg Subject: Re: [PATCH v4 10/20] block: drain from main loop thread in bdrv_co_yield_to_drain() Message-ID: <20230502201029.GF535070@fedora> References: <20230425172716.1033562-1-stefanha@redhat.com> <20230425172716.1033562-11-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="brpBxr+X1vKHT7XM" Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 --brpBxr+X1vKHT7XM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 02, 2023 at 06:21:20PM +0200, Kevin Wolf wrote: > Am 25.04.2023 um 19:27 hat Stefan Hajnoczi geschrieben: > > For simplicity, always run BlockDevOps .drained_begin/end/poll() > > callbacks in the main loop thread. This makes it easier to implement the > > callbacks and avoids extra locks. > >=20 > > Move the function pointer declarations from the I/O Code section to the > > Global State section in block-backend-common.h. > >=20 > > Signed-off-by: Stefan Hajnoczi >=20 > If we're updating function pointers, we should probably update them in > BdrvChildClass and BlockDriver, too. I'll do that in the next revision. > This means that a non-coroutine caller can't run in an iothread, not > even the home iothread of the BlockDriverState. (I'm not sure if it was > allowed previously. I don't think we're actually doing this, but in > theory it could have worked.) Maybe put a GLOBAL_STATE_CODE() after > handling the bdrv_co_yield_to_drain() case? Or would that look too odd? >=20 > IO_OR_GS_CODE(); >=20 > if (qemu_in_coroutine()) { > bdrv_co_yield_to_drain(bs, true, parent, poll); > return; > } >=20 > GLOBAL_STATE_CODE(); That looks good to me, it makes explicit that IO_OR_GS_CODE() only applies until the end of the if statement. Stefan --brpBxr+X1vKHT7XM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmRRbjUACgkQnKSrs4Gr c8gcCwf/T65LBfJJcwJAyvlXRfg2oJ/yZvsfJ3BZCAaupLZjx+EeDLlXwOdhSb2S GKjZnCRY+804xb2asfcWI/aD6+FfB/OtlSQmoNpLQ0rRSl0ySEwoAolto1Z9ekGZ L+Jfc76d+YxOe+NNrrZ9OzISmnofdrQVvqoJotHO/4bB0pUPvWzJG4f+ji/jy3u/ A+7u0pbN8C5zVOa6Cd3OXliYePtIv3nGH9xL8HmL/6YQD5rcPgFj2HlylhSMjRqy dY54mvDssnwZL5sI2RfogH00TesZlaXrVwMD5Mr+HJ/T5H3myPLw1Y3RCgiPVLCM WUaRx6PORhkBp198DzErfTVGl1grqQ== =G1hQ -----END PGP SIGNATURE----- --brpBxr+X1vKHT7XM-- From xen-devel-bounces@lists.xenproject.org Tue May 02 20:15:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 20:15:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528818.822445 (Exim 4.92) (envelope-from ) id 1ptwOs-0005no-OM; Tue, 02 May 2023 20:15:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528818.822445; Tue, 02 May 2023 20:15:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptwOs-0005nh-K8; Tue, 02 May 2023 20:15:02 +0000 Received: by outflank-mailman (input) for mailman id 528818; Tue, 02 May 2023 20:15:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptwOr-0005nb-3W for xen-devel@lists.xenproject.org; Tue, 02 May 2023 20:15:01 +0000 Received: from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de [81.169.146.218]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 03a698ed-e926-11ed-b225-6b7b168915f2; Tue, 02 May 2023 22:15:00 +0200 (CEST) Received: from sender by smtp.strato.de (RZmta 49.4.0 AUTH) with ESMTPSA id x6987cz42KEleXg (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Tue, 2 May 2023 22:14:47 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 03a698ed-e926-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1683058487; cv=none; d=strato.com; s=strato-dkim-0002; b=Ds0jttF+aKpnyizFvLwPcgYyQRhFfzMmVaTRFZFNctH8VH0kFLcpAqsfezmvXBRCYz KdHcAvL8a5xQxKV3oJ4eFsD9UpZKLkQJ0B3RifRzgEJCB9MSttCR6Vzo64PXAldLsrBc Wz07E2ECscbZkA5fovapg8KST8mN89S1n52mNib0tFWFXVUOeBmSxH7SET4Q7MgUQom3 tu8yYbmqek/+H7PJCALNsWv/K6qdJ1Ujd203jQM7vnuFJ5NkoPZnCZ+Bw+Fk2eRpNA6E B2Q2wMD/a10MG4miOUoWb362pgJ0ynvRiq1jXFXazKxDb3PnokK50/j+CXGvKi4BnALs JmfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1683058487; s=strato-dkim-0002; d=strato.com; h=Message-Id:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=HaTckfyLjqk40qDuyIqmlzT69DZDd16J9hzv/RfFXdw=; b=dsxLrTGvJ23T0cLr9YlQYcXuwdqpEWfDYiLJ94z/QIJ6twmuzGXMtrvyN6ftwhIIYG cfYul3FNjCmKCe/qiQMwMckCgNWTmJ8WSpOXPjJp/77pGtBy0vUu1VM6YQvDHcdQI247 Ng8R0AEne0dExBspNBKkpofLCNvuCXph5HkmY1aSB2iE/T7J3Onbc2wGrBCKFMJAEtKy 52eKKRcbrln15szUJw+GSGCZiSKSPQUJEe0xD749jR3H52DVyaISMj+5qlzfGVI8zXyU EJC4xpoRO9h6WzGmNluT2N/aEl8wYKCuxPtym6chdTBQHnK/+HYHHty1aF3Fm/Kb0KBa hqVA== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1683058487; s=strato-dkim-0002; d=aepfle.de; h=Message-Id:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=HaTckfyLjqk40qDuyIqmlzT69DZDd16J9hzv/RfFXdw=; b=OXtbbvbKPXlMkGJF8ZaYajgpWeNfBs5y3Qf140/IE3LzHJPYCTOyQS3fS780NHuQ5j wKE5wO7VZgpvTzvymXqXSFRv2IFmMJ2lMH5CK9QJgEOu/c91IdiILy331uVW7b8XwSu6 PMHFbPeI78m579EtlPF1iiCxl01o5b0/00uJQybU4YdMj+POgy+n6QqXVbbCSjEI9Sm0 Aq3Gz5e041ng0qtZ7WMw4XXgRPtyx05VRzPaRGno9mNg9Q0S5azvMnIPXA+wqMmaUnp8 ZClndfo8k0LLVapdnt19BAbUxbNGI0cTeZpys1u70TOiw40CosQ6wvChDjtgtmxQCx8V 858w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1683058487; s=strato-dkim-0003; d=aepfle.de; h=Message-Id:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=HaTckfyLjqk40qDuyIqmlzT69DZDd16J9hzv/RfFXdw=; b=L5mt69J7gmNxWp5lL7WZVDPa68NiGMEPAUz+f0Z9EBN68KWNTHWFAEWe3zLIl2gfLE P6ezV3ZGiZBn8qyoISDA== X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg4wqVv7FZ8tH5EUSbMVU80kUr7f4QlYaI60OjHt/Q==" From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini Subject: [PATCH v1] automation: provide example for downloading an existing container Date: Tue, 2 May 2023 20:14:44 +0000 Message-Id: <20230502201444.6532-1-olaf@aepfle.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="us-ascii" Signed-off-by: Olaf Hering --- automation/build/README.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/automation/build/README.md b/automation/build/README.md index 2d07cafe0e..8ad89a259a 100644 --- a/automation/build/README.md +++ b/automation/build/README.md @@ -12,6 +12,12 @@ can be pulled with Docker from the following path: docker pull registry.gitlab.com/xen-project/xen/DISTRO:VERSION ``` +This example shows how to pull the existing container for Tumbleweed: + +``` +docker pull registry.gitlab.com/xen-project/xen/suse:opensuse-tumbleweed +``` + To see the list of available containers run `make` in this directory. You will have to replace the `/` with a `:` to use them. From xen-devel-bounces@lists.xenproject.org Tue May 02 20:41:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 20:41:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528823.822455 (Exim 4.92) (envelope-from ) id 1ptwoW-00011m-SB; Tue, 02 May 2023 20:41:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528823.822455; Tue, 02 May 2023 20:41:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptwoW-00011f-Nh; Tue, 02 May 2023 20:41:32 +0000 Received: by outflank-mailman (input) for mailman id 528823; Tue, 02 May 2023 20:41:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptwoV-00011V-Bv; Tue, 02 May 2023 20:41:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptwoV-0006CD-3m; Tue, 02 May 2023 20:41:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptwoU-0007jw-PA; Tue, 02 May 2023 20:41:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ptwoU-00021N-Of; Tue, 02 May 2023 20:41:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Av+DCOvPiFoOSzqCPa5dDi6cyRQ7WduvSjAH+ZlDvOY=; b=VuEY9ZTEt6Z672mNSHfYeZwFVU 2A4/KEKWzW76CoMKZa52J3yjU+/Pfg5gHnasGqdI3UZbzUt+KhwZ0vPQGcidfoLOfkTmsLRHLq9/N RvVCEk7rjfnjnVhcwhKa+g4JGPoZK5mIryg4mcqOST+U+B5RMKpqNhwKhrUdWSE0AdGQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180508: all pass - PUSHED X-Osstest-Versions-This: ovmf=d6b42ed7ed1b0c4584097f0d76798cff74c96379 X-Osstest-Versions-That: ovmf=23c71536efbebed57942947668f470f934324477 From: osstest service owner Date: Tue, 02 May 2023 20:41:30 +0000 flight 180508 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180508/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf d6b42ed7ed1b0c4584097f0d76798cff74c96379 baseline version: ovmf 23c71536efbebed57942947668f470f934324477 Last test of basis 180502 2023-05-02 07:42:13 Z 0 days Testing same since 180508 2023-05-02 16:10:54 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Gerd Hoffmann jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 23c71536ef..d6b42ed7ed d6b42ed7ed1b0c4584097f0d76798cff74c96379 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue May 02 20:44:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 20:44:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528828.822464 (Exim 4.92) (envelope-from ) id 1ptwr3-0001bJ-8M; Tue, 02 May 2023 20:44:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528828.822464; Tue, 02 May 2023 20:44:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptwr3-0001bC-5X; Tue, 02 May 2023 20:44:09 +0000 Received: by outflank-mailman (input) for mailman id 528828; Tue, 02 May 2023 20:44:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptwr2-0001b6-GB for xen-devel@lists.xenproject.org; Tue, 02 May 2023 20:44:08 +0000 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1389ce24-e92a-11ed-8611-37d641c3527e; Tue, 02 May 2023 22:44:05 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 2EA135C0206; Tue, 2 May 2023 16:44:04 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 02 May 2023 16:44:04 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 2 May 2023 16:44:02 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1389ce24-e92a-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1683060244; x=1683146644; bh=bquulcUGVvPXVr3hhUZYxsQgDschilipxpo PBxW7lwM=; b=RPmQ0OEV9S1XkKuov9bdECga8Q63lGNujL6ihp0PnRNOmlBYp7l EsvBDkYTCNEiDTD8WP6tOee8+sayAI3Fx9y7ZcpmmZ+ou/AhR5Oh3dQAXoiIFSan amtiFluu6Hj7BMyLhViAT5i1SI+Fkz7AQ0d49oNlnQS04R4oaVOHA1/gTtjVe2Dc wO/sFNKj3PU3mrBZg05Yv/VlSefvV3kFDlCGpmG/W/9QQIwoVGxOfsH28DBDCaqT N8gkWDQMJq+cONor2MdJSk9tMwg0MjnE9ReybQ7WTNyafJVW0KF9zvoWKRFryyNF WI+l2AV7hByEb4zm00CdvUYtIx3aP3769Sg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1683060244; x=1683146644; bh=bquulcUGVvPXV r3hhUZYxsQgDschilipxpoPBxW7lwM=; b=hHrHP8WKRMORzXF/1BbhU2fLHwaxC +SIWNSZAakxT1Xjiw2S4+upHy4LtpWg89ea3rUS42UJVq9QMN5fpSUBBmheMEvm3 11qNlg4sKrLSvUCc8qNvNUEFjZCVmqthKmU/d1K+BF/sgOpuxyuGwFkfBf8+hqSX 7Zt3fih/ZsgANDSLoMNgQczj63l1ItxGlooXPLoDSZ2raYWhReUnS3TFgtWDnE4e ulaJEooge2O1aVDlu9rlNOt/Eg6YRQfaIirQ5Pmovd56T/qEXnPa1G+42jRaSgxk srviAENp5d+ALe/+9wSYlKQvWCKMVeHLMRpuIJjZ9f657hgOx7GnaunWQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedviedgudehfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg udelteefvefhfeehieetleeihfejhfeludevteetkeevtedtvdegueetfeejudenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Tue, 2 May 2023 22:43:58 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH v2] ns16550: enable memory decoding on MMIO-based PCI console card Message-ID: References: <20230425143902.142571-1-marmarek@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eIxYRDk9pctUlU0V" Content-Disposition: inline In-Reply-To: --eIxYRDk9pctUlU0V Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Tue, 2 May 2023 22:43:58 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH v2] ns16550: enable memory decoding on MMIO-based PCI console card On Tue, May 02, 2023 at 12:53:15PM +0200, Jan Beulich wrote: > On 25.04.2023 16:39, Marek Marczykowski-G=C3=B3recki wrote: > > pci_serial_early_init() enables PCI_COMMAND_IO for IO-based UART > > devices, add setting PCI_COMMAND_MEMORY for MMIO-based UART devices too. >=20 > This sentence is odd, as by its grammar it looks to describe the current > situation only. The respective sentence in v1 did not have this issue. >=20 > > --- a/xen/drivers/char/ns16550.c > > +++ b/xen/drivers/char/ns16550.c > > @@ -272,7 +272,15 @@ static int cf_check ns16550_getc(struct serial_por= t *port, char *pc) > > static void pci_serial_early_init(struct ns16550 *uart) > > { > > #ifdef NS16550_PCI > > - if ( !uart->ps_bdf_enable || uart->io_base >=3D 0x10000 ) > > + if ( uart->bar ) > > + { > > + pci_conf_write16(PCI_SBDF(0, uart->ps_bdf[0], uart->ps_bdf[1], > > + uart->ps_bdf[2]), > > + PCI_COMMAND, PCI_COMMAND_MEMORY); > > + return; > > + } > > + > > + if ( !uart->ps_bdf_enable ) > > return; > > =20 > > if ( uart->pb_bdf_enable ) >=20 > While I did suggest using uart->bar, my implication was that the io_base > check would then remain in place. Otherwise, if I'm not mistaken, MMIO- > based devices not specified via "com=3D...,pci" would then wrongly take > the I/O port path. I don't think MMIO-based devices specified manually have great chance to work anyway (see the commit message), but indeed I shouldn't have broken them even more. > Furthermore - you can't use uart->bar alone here, can you? The field is > set equally for MMIO and port based cards in pci_uart_config(). Right, I'll restore the io_base check. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --eIxYRDk9pctUlU0V Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmRRdg8ACgkQ24/THMrX 1yxm9wf/dusj5o4WiivPB3JYBb6aS4pI2gj3KvUbO+8zK5nxFkL5SCTxE/4gMhY2 aTNlNTnxfo7xuhWqptqaJ1tM9mScc6vwHODrwUf6jv8o8K+YFZoEPgfhyeEC2Xjn qJA6M8JPaEWi+QPCSbY2BeVlxXTNM30xKOoBIuCav9v8OMozbz02OGescxyDCt0e xUzFozvsy/KC4Bvv22sZ7YxwKad+KbfmNhFN791YZ97RFn4uTErAgVCV/ajGH6FE fXQeVQcLymxyWBI4tlicQdw9SNVYwvm0bkHXhjP6MmGXQhc//LxssUIRPe/KVXW9 DcAWB7caQ7yNyV+kbvFO6qK3UlMgtw== =Q3KG -----END PGP SIGNATURE----- --eIxYRDk9pctUlU0V-- From xen-devel-bounces@lists.xenproject.org Tue May 02 20:48:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 20:48:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528836.822475 (Exim 4.92) (envelope-from ) id 1ptwux-0002HA-TL; Tue, 02 May 2023 20:48:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528836.822475; Tue, 02 May 2023 20:48:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptwux-0002H3-QK; Tue, 02 May 2023 20:48:11 +0000 Received: by outflank-mailman (input) for mailman id 528836; Tue, 02 May 2023 20:48:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptwuw-0002Gn-K3 for xen-devel@lists.xenproject.org; Tue, 02 May 2023 20:48:10 +0000 Received: from mo4-p01-ob.smtp.rzone.de (mo4-p01-ob.smtp.rzone.de [85.215.255.53]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a523253f-e92a-11ed-8611-37d641c3527e; Tue, 02 May 2023 22:48:08 +0200 (CEST) Received: from sender by smtp.strato.de (RZmta 49.4.0 AUTH) with ESMTPSA id x6987cz42Km3eaa (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Tue, 2 May 2023 22:48:03 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a523253f-e92a-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1683060483; cv=none; d=strato.com; s=strato-dkim-0002; b=YphspjVUr1YpHqRikiihIxJoLv2OCITtQV2UvMFMZ2PhF0noh9mB5RGWXjV+mAczkw L1D8CF4IovVOq4qUDTdEpIMR0bq6FwITgN0BhrxC1JsM2ThblhlULPZSoA/H3ylwwWpZ lJKF1YlpJhho+lVjd8yYd7KAsby9JrXF/DUnlZZ7TdUTpdGpNOm07UscfTohjdte4dnX /M2F6nIIxMjUfBO4hGi0/n6D6Se+FyRilaw0Nn9Ql9SRv0g94y8rBPDMg9ye+zM6cpHP vLhgBSlKBl6oQl/FO/K2gBFVFsabShGgQDKZAzFJ6s3qoxqTRmc8UeQ+GZaS/pwFnNOs AL9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1683060483; s=strato-dkim-0002; d=strato.com; h=Message-Id:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=QAmU+/VygWvLyKR/GJw/qjknyykgRWf7rx6CpuHmpt0=; b=JZKUUpuNJbmSYa79RF9EtvehtI53BYpwqF27R7Xb0vE6y9JiDhBdiahv8xaMttbDzD JYVebTs4az3SUiq33cVM1mG60iOju+tuA8HzdgVowSe2WSLkazyPMXuLwl+LCK6bhfwR /5XTEM7Hgxf5N0Intn9oRtQ4Z735QDIWZkKB7qmBUju0M723cSJLcBVYcd/ZhFBEUoOJ s9ZdgVk2SAOHU/U0e2RZ/Cuhd2dNaz0DJLWUYuXFYs4N1yR8oa+qa9Lend3L6JEce7Sb oVKSRpG4wXIDD1oWPnhXIgbbKnZFcszRybkb2InYmvYlb4b8VjcQm/IfsnfOZ2kl9omX 05tw== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo01 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1683060483; s=strato-dkim-0002; d=aepfle.de; h=Message-Id:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=QAmU+/VygWvLyKR/GJw/qjknyykgRWf7rx6CpuHmpt0=; b=OzvPmEsxeE2vTN5SuQfki+E/p+3fuZVACtCtI2ckS9oij4NX5t3tm37W1cfbh/VWB9 tycdyhkLAvDcHNa+8BZh6VDtqLZ01phSFgKtJHSjRwnAg4w2DF23wkrycAujdhwJJ9a3 tIdo1c6kwidHeMmaQqJrTefbTa7AHpuf3pZpt+A/ZshFeU083lk/rVopJEWQDeLHRHEM hTSL21bDBRh3IaDxleayoIz6NL4gH2AuxfbvIdxTYbhLuv/AXXjH+bVMkJ3jTpT0BFfT idqlR5cAX7cG5zCUmMgJXzIXGyvadPXmTxTtYJCwkz6gUqte0LWin4GbFtDUMPZIpp/X Bkfg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1683060483; s=strato-dkim-0003; d=aepfle.de; h=Message-Id:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=QAmU+/VygWvLyKR/GJw/qjknyykgRWf7rx6CpuHmpt0=; b=BkQP3SKq0gNjF4VeD4vRL+gay92bML/DQMIgjjOJL2Jn0X4euM9t0Umb6TwfbfvmYF KdRauizvLKwtf1oIg4DA== X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg4wqVv7FZ8tH5EUSbMVU80kUr7f4QlYaI60OjHt/Q==" From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Subject: [PATCH v1] tools: drop bogus and obsolete ptyfuncs.m4 Date: Tue, 2 May 2023 20:48:00 +0000 Message-Id: <20230502204800.10733-1-olaf@aepfle.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="us-ascii" According to openpty(3) it is required to include to get the prototypes for openpty() and login_tty(). But this is not what the function AX_CHECK_PTYFUNCS actually does. It makes no attempt to include the required header. The two source files which call openpty() and login_tty() already contain the conditionals to include the required header. Remove the bogus m4 file to fix build with clang, which complains about calls to undeclared functions. Signed-off-by: Olaf Hering --- m4/ptyfuncs.m4 | 35 ----------------------------------- tools/configure.ac | 1 - 2 files changed, 36 deletions(-) delete mode 100644 m4/ptyfuncs.m4 diff --git a/m4/ptyfuncs.m4 b/m4/ptyfuncs.m4 deleted file mode 100644 index 3e37b5a23c..0000000000 --- a/m4/ptyfuncs.m4 +++ /dev/null @@ -1,35 +0,0 @@ -AC_DEFUN([AX_CHECK_PTYFUNCS], [ - dnl This is a workaround for a bug in Debian package - dnl libbsd-dev-0.3.0-1. Once we no longer support that - dnl package we can remove the addition of -Werror to - dnl CPPFLAGS. - AX_SAVEVAR_SAVE(CPPFLAGS) - CPPFLAGS="$CPPFLAGS -Werror" - AC_CHECK_HEADER([libutil.h],[ - AC_DEFINE([INCLUDE_LIBUTIL_H],[],[libutil header file name]) - ]) - AX_SAVEVAR_RESTORE(CPPFLAGS) - AC_CACHE_CHECK([for openpty et al], [ax_cv_ptyfuncs_libs], [ - for ax_cv_ptyfuncs_libs in -lutil "" NOT_FOUND; do - if test "x$ax_cv_ptyfuncs_libs" = "xNOT_FOUND"; then - AC_MSG_FAILURE([Unable to find library for openpty and login_tty]) - fi - AX_SAVEVAR_SAVE(LIBS) - LIBS="$LIBS $ax_cv_ptyfuncs_libs" - AC_LINK_IFELSE([AC_LANG_SOURCE([ -#ifdef INCLUDE_LIBUTIL_H -#include INCLUDE_LIBUTIL_H -#endif -int main(void) { - openpty(0,0,0,0,0); - login_tty(0); -} -])],[ - break - ],[]) - AX_SAVEVAR_RESTORE(LIBS) - done - ]) - PTYFUNCS_LIBS="$ax_cv_ptyfuncs_libs" - AC_SUBST(PTYFUNCS_LIBS) -]) diff --git a/tools/configure.ac b/tools/configure.ac index 9bcf42f233..c94257f751 100644 --- a/tools/configure.ac +++ b/tools/configure.ac @@ -70,7 +70,6 @@ m4_include([../m4/uuid.m4]) m4_include([../m4/pkg.m4]) m4_include([../m4/curses.m4]) m4_include([../m4/pthread.m4]) -m4_include([../m4/ptyfuncs.m4]) m4_include([../m4/extfs.m4]) m4_include([../m4/fetcher.m4]) m4_include([../m4/ax_compare_version.m4]) From xen-devel-bounces@lists.xenproject.org Tue May 02 22:41:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 22:41:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528844.822485 (Exim 4.92) (envelope-from ) id 1ptyft-00070c-Op; Tue, 02 May 2023 22:40:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528844.822485; Tue, 02 May 2023 22:40:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptyft-00070V-M3; Tue, 02 May 2023 22:40:45 +0000 Received: by outflank-mailman (input) for mailman id 528844; Tue, 02 May 2023 22:40:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptyfr-00070P-I6 for xen-devel@lists.xenproject.org; Tue, 02 May 2023 22:40:43 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5baff743-e93a-11ed-8611-37d641c3527e; Wed, 03 May 2023 00:40:39 +0200 (CEST) Received: from mail-dm6nam12lp2175.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2023 18:40:23 -0400 Received: from DS7PR03MB5414.namprd03.prod.outlook.com (2603:10b6:5:2c2::6) by MN2PR03MB4989.namprd03.prod.outlook.com (2603:10b6:208:1a5::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.20; Tue, 2 May 2023 22:40:21 +0000 Received: from DS7PR03MB5414.namprd03.prod.outlook.com ([fe80::fdfd:97e5:7c55:82d]) by DS7PR03MB5414.namprd03.prod.outlook.com ([fe80::fdfd:97e5:7c55:82d%6]) with mapi id 15.20.6340.031; Tue, 2 May 2023 22:40:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5baff743-e93a-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683067239; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=FNB9GSnyRPnYK98/Gs9Y6pEJFd5wbO1w+y7hmtAbIcA=; b=LuHqencmt8ngkpycZ7EhW8VOZLUMK5xVT7V/Yvqgxq/VNNuzqIXq6ijf EmGtXCE3dRtfMoDXeFpt9ekbyvaSCegVhYaXZaWXNPvka5o7EcihPX2zP I/x4CDL0difqZJlcIjN7PXTWdkJzOsUhHN0G8HYpsUY+BSWUPCeS3iLTY E=; X-IronPort-RemoteIP: 104.47.59.175 X-IronPort-MID: 106400643 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:3ILQr66FAqk+9ypsawsoVAxRtCPGchMFZxGqfqrLsTDasY5as4F+v mNJDzyHO/3ZNDP8eYhza9vj9kxXu8DQxtBjSQM6pSgxHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+7ZwehBtC5gZlPa0T5geF/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m7 O4TDjQQdUm/rsWx7OyFEtYyupsCFZy+VG8fkikIITDxK98DGMqGb4CUoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OnUooj+WF3Nn9I7RmQe1Xk0Cep 2zL5SL5DwsQOcaD4TGE7mitlqnEmiaTtIc6TeXmqqYy3gHIroAVIBJOCFaGk/mBsHajXPYCd UsvpRE37pFnoSRHSfG4BXVUukWsvBQRRt5RGO0S8xyWx+zf5APxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+pQSiaPCEUKSoOYHECRA5cud37+ths01TIU8ppF7OzgpvtAzbsz juWrS84wbIOkcoM0Kb99lfC696xmqX0oscOzl2/dgqYAslRPeZJu6TABYDn0Mt9 IronPort-HdrOrdr: A9a23:EeK/za7YLSgKAYek3QPXwOTXdLJyesId70hD6qkXc3Bom62j+P xG+c5x6faaslgssR0b+OxoWpPwIk80hKQU3WB5B97LNmTbUQCTXeNfBOXZslvdMhy72ulB1b pxN4hSYeeAdGSSVPyKhDVQxexQp+Wv+qauguvV0ndqSgFmApsQijtENg== X-Talos-CUID: 9a23:EE3REWNNP23Zh+5DQTts0koJAZkZW1ra4Cnue3DmNTlIcejA X-Talos-MUID: 9a23:k1cfJwgUAYuKg1hODiTGt8MpO5817pmcCHg3qYgBn5TaMhcvAC7etWHi X-IronPort-AV: E=Sophos;i="5.99,245,1677560400"; d="scan'208";a="106400643" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FhynCaDbmxKP3i5Gsz3FwyM3xKKVa562v2Ee/d8QYLd0md19dchnifKlm9R2WOqMBEJLdUbVMXkbLC/O260MjJtMdmkZXwTLvi3aCiVZsqD2J/GSNeKaIgDKAJlXefMnEI3G+3v6hRJseHPn8bY6m46dhXBOMLJD38gg3ZnYcNyT48WSGotQcYwzOJwpZfS+k81/XIgBBWwcp3xYEaUX2vrTaky/J6ICl6LsyJ11mFD4inW2AkfTBXpCB9zbVWkztsLGNKC6aoz78PFnETApQ06kuD2nrra/Eow0/lEd/IGmcvDazF0gqIvSjnn0GHt/RoQgHfk8yPManXy7EV1XJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mlq3SnBA/2XciEPKI0qXHiISzju/CjJhWkRkawbwRwk=; b=E2eu+u4eIq+fS6OWReydzqs0MUv63TkR3RXJMMVqVsmO7lOdqE+P+DWiYjXVtLapLs12ZrwNpF1VgSvnmEMMLUzswUTECLWpApnFEVF8CmuZv8SWMiFY4jLA/8ZcYCX32CUsNn6k+jPRGXjn4VIDThWV0RsWSskrRi9xzDpqsp6aZZQh3sZC2bDhwsfHOQR//q8fO78snhzhaX5UxglrTj2Od1PISUTWTnHW66rSVwu9ynlwFCxUpGpU/FHbpJMFn+Mkwi6dxUWviYI8mDmmGZm0hF6W2ydbkBJoC6GZAtIsNJ8nzOCFxElX6ZWfJKrsgmxSUHXvFCHrdfta8rq4/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mlq3SnBA/2XciEPKI0qXHiISzju/CjJhWkRkawbwRwk=; b=KBnyIhg0haOjT7nZs38ciExnDmZ8sJ4QbWtliwa/yIATjAy1vGUYxDFygcUtJmVvM9teNXFNY1voBAkXrv0yxWMN1jBv4uXysWaJfkovNYeGp6vaOcWXG6vYjC0R8L61YjbdHzuQ84Fr/ctuLb0RkFKa/iG0eWtQ4PDQC1LEn2Y= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <5e877d50-de2d-0af4-9fa0-d4529a97ee2f@citrix.com> Date: Tue, 2 May 2023 23:40:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3 1/2] acpi: Make TPM version configurable. To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Xen-devel References: <20230425174733.795961-1-jennifer.herbert@citrix.com> <20230425174733.795961-2-jennifer.herbert@citrix.com> <5516fbf5-dbfc-dcd5-0465-e4757fdc16de@suse.com> From: Jennifer Herbert In-Reply-To: <5516fbf5-dbfc-dcd5-0465-e4757fdc16de@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0591.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:295::13) To DS7PR03MB5414.namprd03.prod.outlook.com (2603:10b6:5:2c2::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR03MB5414:EE_|MN2PR03MB4989:EE_ X-MS-Office365-Filtering-Correlation-Id: 6882bbf6-3dc4-4193-6965-08db4b5e3609 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RnaqWcA84bQdqs9njpw3FW9OeB6hIWs4GZJqZvOXfknA1g7AHUMyR5zJHa47pCxWXf9QZPcYCX+TGa8KzM1IA5g57mii9NyLnvne0bGi3+WG5q/1jhhlaHCFV5FvBu9eKOlp37ZbIf8NI4gPmF4wXeuuXt9hsgQmBrItcNaHrUh2s7x678MKGUV0YNmuWmpwD5exVert2O8TX4T5kDAgyH5lHXVHSs1JEUzR9j9BwLDf/E+uyxMdg7it6XCcu9/giPKnVX4gKFnidIMVH6xJ0UPfMaE7iq0esZjA15ySxN82CdFKX95DUoSNIZekDvZ+LUsRVgJt8mYObKLho7qW8JhDlvSSNKsnoxYpUevZSqbFuU5TYQ83NMNhSnnv8YzK6DBov0n6T+/yZyvA5YeWG5xUhBTXMzeGqQO6qbYsGR1dts0tTcajdDs21DpwR45h95VtT6kNdLKJBu6pPFFMO6s3qsH9zTUGybI7rvYj2UQYWjnlWOk5mkV8K095SWzdiqYvqgVU7htStyyDbjH4onjQe5YYnI75/YHxay/0lhgM6C+u72xVu0/yhE17lGcK2iY3qy+35JZf5adzCb2mNl6STUfUDX26sLUOW60kaqWJo3qLHEYyrkgNSaZMglCVz41y4HUil/DD2Em3FRG4zA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5414.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(376002)(346002)(136003)(366004)(396003)(451199021)(54906003)(26005)(6506007)(31686004)(6512007)(2616005)(6666004)(478600001)(66556008)(66476007)(66946007)(4326008)(6916009)(316002)(53546011)(41300700001)(186003)(83380400001)(6486002)(5660300002)(8936002)(82960400001)(2906002)(38100700002)(44832011)(86362001)(8676002)(31696002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d3VOZ1Zxc2ZpZWEwb3A3eHpsdVUwNTBYcENVcGJhVjZrU1JmMWQvQnJrZStL?= =?utf-8?B?SHdrdndLSExMM3JvbGtjeVZCRndrUmtwaHIwNFJhMUJkMmJubWJwdnM1TlBX?= =?utf-8?B?ZzkySWo0L1BweE85dVVldkdhd1lpbGpEN3JjcEZFS2F6cjN2VGcvZUhOK3My?= =?utf-8?B?cmR1MjYxK3BBQ00yeW5sS0gxQnM2SjJLOWtvMjNpZFRWczh0TFh1aHJxYUJ5?= =?utf-8?B?NmpZNFlFNVNVV1hXVTVVUC82Ym9TS21hTDRMTUFmL2tmYithdXpGemNiVisx?= =?utf-8?B?ZFNSWkg2QkgxTXN4VW9xUG5KWk9QOFp6NWRLOUMxWGFieTVnemorVU5KYml6?= =?utf-8?B?K1k2elRaYVFjdFpGY2FUU0RkRVN6b214RXoyUlVQTU5zZFdyNEhKT0NWR1du?= =?utf-8?B?ZWR1dHdycDczbnhxVnYzbGhPNlV1MG4rWEFCU2p0OENkdm5BY2tlV2NpTGl2?= =?utf-8?B?cVp5ZUxOSUNBRytPcTA1TXRMMWZzNy9wSkZ5Uk5wL0dvNGZ0ZGdJZG9hR2ZL?= =?utf-8?B?UXZ2ZVQrbUwwbjJSVzczWTJ1dnpuUUJHRnBCQ1RCMHdPZ0Y4clBKbzBReEI0?= =?utf-8?B?eWgycVN0OHI2SDNuVU1NNXBOQmYwZDJGNHhITkYzR25ndmNRSk9PN0prU2J0?= =?utf-8?B?Z1FqcXg2RHMybGhBamRyOFQ4TUhKeFF3ekNDL0Z5Tll5cjJaTU1nTXZ2dHpt?= =?utf-8?B?Mi9FT2tnR1NRSy9UT1h2QVhPMmZBUzBpQ3lJR0xNc0RvejJaaFpUUnFDUlhp?= =?utf-8?B?dHVCSmNwN3haSlF1bTRWc1haaWZWcjFDaitlKzgwOXpwWlpObDVhdWpxUFFm?= =?utf-8?B?UkdKRVZ2NUVVbTJXdXJ5NDB4a1pLekUzb1dhQVFWSDg5Vzh6dlN0SE5BWnRP?= =?utf-8?B?Y0FpYi90RkQvbXhiYStHUUhZa1ZCT2J3WGtxQit1Y2dVNjE4VXlHZlhLYnNB?= =?utf-8?B?djltTDg5SjVhNml6UW8yQWhIK0k0MmFDMDRBZmUrRExMNDN0TE00bFY1OUFQ?= =?utf-8?B?VGx0OGt1cVJJYm5VNURBdDVYeUlFZ3lRNW9NZ05xSndYejFDbEFNTmdBeUdt?= =?utf-8?B?bCtWUERqK0Y1ZWd1RjZBSXdZUjVrQzE4WFc5OTlJME9BbnY3RGxsUHVlVnRa?= =?utf-8?B?SEtsdFpYajNUS01MNGVDbDBYQlZnb0VuTzNIVkMzVnVXM2g5UC9pVms3b3Zj?= =?utf-8?B?NDhpN2xzQVlCU3BwNkhrWjUyYmlnb1hzYU0zSmptdGZnbnJOTjlrc2FQNnhF?= =?utf-8?B?UDJsUnJmT3JHSUw0U0JYYnZPdnFzUEEwaHFLTjZ3bzBYN3FjRXplbEF1cHlu?= =?utf-8?B?TVJzYlYvUXVNU3Q4QTd3dWhWNTdUS2JWZlA0b0dhNnZlWEpCZlRoVGM3bG9l?= =?utf-8?B?MmZZYkZJYytKaE1nZEYrOGdVSUFOL080MFBrRTd1ZlRpN3d5aUhJRWRpVnhZ?= =?utf-8?B?RW52SkQ0RjMyR0ZPWGZMVnBuUUFZOTltNk1vNVZhaDROVk1GQWcrSFA2WnFP?= =?utf-8?B?dWlFYytjUXpTMU9ZeVZxNTBXMEtneDR2djNYZmgxdFJHY1JHcjhiVmdFeVJk?= =?utf-8?B?Ymc5Mjd1SXhUc0wvemFpSW9xWlJuelNFbGtseU9Kemk1RGczNHhjd1BZYUlM?= =?utf-8?B?U01wRU96UHhmR3dnbXFkaVgyQXRiMGY4eGhlZVVlVnViMGI3T2Nlb05EdHNH?= =?utf-8?B?WXEzR3g3aEJHNHUzMTR0bm5lUG04cFhlWTRxNXZIY1ExQ2ZiRHE0TTZEY3I0?= =?utf-8?B?TkYwR2Z4RGhFdnVLYUl4VitNWFVwZ2w4K1Vxc1pwVEpmYUh6V0YrZUhsNnBP?= =?utf-8?B?S3hPR1c3eGdkcnRWSmx4SG41SWluVzRnNXNDR2g5UFQzNXRwRkhOZEtKTGdC?= =?utf-8?B?YnlTYmpiV05WNG0vNkJaYVoxOTNsYmxIRXM2SjFEalBtZFlYbFVEb0grMHN3?= =?utf-8?B?ZlRsL3p1UTU5YlNFY1hpM2pLQW5ybUdJU0xVTktzaWw1eURPVFJJMTZRTzYz?= =?utf-8?B?NWNNUW5RbnVzckxwN2V4U0dWWW00eUpxRXREQUUyNDU3Z3FhcWZ5K2F3MHZ4?= =?utf-8?B?b3BFMTlySTkrRGZqNkhUTFhzMDY1M0VyY3JjTnBsMC9IbklITzNxZWpjclZk?= =?utf-8?B?S0tqTFJMWHVLNWRNTlRveWx3QmRsL0tidENIY1Q3Y2VZbnYxbEJseGd1b3Vx?= =?utf-8?B?clE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: kqTb7B2bWPV1YEHvVsbHP8wKyQqI13OgF7f0uEFSYKKj3q/o/0vRe6bQ83+ZZ2rIo7qWJpGAhinPtXj6nJFQbH+ohxBT1tiT6dMzjqobjoFd2DZdWmU7JT/vbYk9yAbOqlHBvmHI11G4696l2/Bw1QsoFhszL6uT9Qfdvzf14OG3b6fYZjJSUD+bBenlzF/4K3rmvA4zIrOszEPcF2SaIjQSDNqdar7bMwBNhZA0sDcLPYX+TWd78h8E/02AYmp51+9oR6zeiB39HuxRKF0gIjkYKFxgaXdsqBxzyj84bxE6CSq+FlfPOxgQYu2BtxUNv7yi+uEEWnTvQ/GHr+NRayqck9n15cOoZL4RAGFLH3l/5osmQ2nKPeWZ5TkKzPINQEh/F7pEPOnMVs6xrMEglhwOquYCrzncQwLJCcSfpoYShkFWxjnsgeBEFcJuCXpGP/zCozO2jEpVOSwIyYi0ObRn2UZvT92MU/bt8thJm61mx66ByFh7IH8IRMwrRmb0eQAoILf7IC5aOSvWa5LZ1+OmJ4OKqQ7CEQBAxKjrq9syYPwotNe/gC6v9D+9aS/oMJHivupeLWxNH5sChlfBQEwwM99TPp+jj02G2pf+c5bNHJdYfcfWeNbUiv8Wo2nqIgGMrUeTOnSwyYqfP3FOjCki2rSGbuQKZ03GqD6w0GJ9irNwXw4FHBzQPw2g2DpOUuYKB5ubov78Ck5uMzwRbH5gSDUbMbLSW8XJIVerAp4iqBLGIyi0Jof1AFdpt33530WW55SMxOcDWYeBrHvE5NCimy6LIJfrSVFzIaF28xE= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6882bbf6-3dc4-4193-6965-08db4b5e3609 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5414.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 22:40:21.1377 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vhQwWrJMGqmY34wBhzMfvQccN35nRNOUHITDbA6m2PIt/YHFza1l2zZyBorjuoRhrl0SvumVd9zCqCSnUuni+7o7VNuzpzwFLSTXb/Cbevo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4989 On 02/05/2023 12:54, Jan Beulich wrote: > On 25.04.2023 19:47, Jennifer Herbert wrote: >> This patch makes the TPM version, for which the ACPI libary probes, configurable. >> If acpi_config.tpm_verison is set to 1, it indicates that 1.2 (TCPA) should be probed. >> I have also added to hvmloader an option to allow setting this new config, which can >> be triggered by setting the platform/tpm_version xenstore key. >> >> Signed-off-by: Jennifer Herbert >> --- >> docs/misc/xenstore-paths.pandoc | 9 +++++ >> tools/firmware/hvmloader/util.c | 19 ++++++--- >> tools/libacpi/build.c | 69 +++++++++++++++++++-------------- >> tools/libacpi/libacpi.h | 3 +- >> 4 files changed, 64 insertions(+), 36 deletions(-) > Please can you get used to providing a brief rev log somewhere here? Yes, ok. >> --- a/tools/firmware/hvmloader/util.c >> +++ b/tools/firmware/hvmloader/util.c >> @@ -994,13 +994,22 @@ void hvmloader_acpi_build_tables(struct acpi_config *config, >> if ( !strncmp(xenstore_read("platform/acpi_laptop_slate", "0"), "1", 1) ) >> config->table_flags |= ACPI_HAS_SSDT_LAPTOP_SLATE; >> >> - config->table_flags |= (ACPI_HAS_TCPA | ACPI_HAS_IOAPIC | >> - ACPI_HAS_WAET | ACPI_HAS_PMTIMER | >> - ACPI_HAS_BUTTONS | ACPI_HAS_VGA | >> - ACPI_HAS_8042 | ACPI_HAS_CMOS_RTC); >> + config->table_flags |= (ACPI_HAS_IOAPIC | ACPI_HAS_WAET | >> + ACPI_HAS_PMTIMER | ACPI_HAS_BUTTONS | >> + ACPI_HAS_VGA | ACPI_HAS_8042 | >> + ACPI_HAS_CMOS_RTC); >> config->acpi_revision = 4; >> >> - config->tis_hdr = (uint16_t *)ACPI_TIS_HDR_ADDRESS; >> + s = xenstore_read("platform/tpm_version", "1"); >> + config->tpm_version = strtoll(s, NULL, 0); > Due to field width, someone specifying 257 will also get a 1.2 TPM, > if I'm not mistaken. Seems likely.   And i few other wacky values would give you 1.2 as well I'd think.   There could also be trailing junk on the version number. I was a bit phased by the lack of any real error cases in hvmloader_acpi_build_tables.  It seemed the approch was if you put in junk, you'll get something, but possibly not what your expecting. Do I take it you'd prefer it to only accept a strict '1' for 1.2 and any other value would result in no TPM being probed?  Or is it only the overflow cases your concerned about? >> + switch( config->tpm_version ) > Nit: Style (missing blank). yup >> --- a/tools/libacpi/build.c >> +++ b/tools/libacpi/build.c >> @@ -409,38 +409,47 @@ static int construct_secondary_tables(struct acpi_ctxt *ctxt, >> memcpy(ssdt, ssdt_laptop_slate, sizeof(ssdt_laptop_slate)); >> table_ptrs[nr_tables++] = ctxt->mem_ops.v2p(ctxt, ssdt); >> } >> - >> - /* TPM TCPA and SSDT. */ >> - if ( (config->table_flags & ACPI_HAS_TCPA) && >> - (config->tis_hdr[0] != 0 && config->tis_hdr[0] != 0xffff) && >> - (config->tis_hdr[1] != 0 && config->tis_hdr[1] != 0xffff) ) >> + /* TPM and its SSDT. */ >> + if ( config->table_flags & ACPI_HAS_TPM ) >> { >> - ssdt = ctxt->mem_ops.alloc(ctxt, sizeof(ssdt_tpm), 16); >> - if (!ssdt) return -1; >> - memcpy(ssdt, ssdt_tpm, sizeof(ssdt_tpm)); >> - table_ptrs[nr_tables++] = ctxt->mem_ops.v2p(ctxt, ssdt); >> - >> - tcpa = ctxt->mem_ops.alloc(ctxt, sizeof(struct acpi_20_tcpa), 16); >> - if (!tcpa) return -1; >> - memset(tcpa, 0, sizeof(*tcpa)); >> - table_ptrs[nr_tables++] = ctxt->mem_ops.v2p(ctxt, tcpa); >> - >> - tcpa->header.signature = ACPI_2_0_TCPA_SIGNATURE; >> - tcpa->header.length = sizeof(*tcpa); >> - tcpa->header.revision = ACPI_2_0_TCPA_REVISION; >> - fixed_strcpy(tcpa->header.oem_id, ACPI_OEM_ID); >> - fixed_strcpy(tcpa->header.oem_table_id, ACPI_OEM_TABLE_ID); >> - tcpa->header.oem_revision = ACPI_OEM_REVISION; >> - tcpa->header.creator_id = ACPI_CREATOR_ID; >> - tcpa->header.creator_revision = ACPI_CREATOR_REVISION; >> - if ( (lasa = ctxt->mem_ops.alloc(ctxt, ACPI_2_0_TCPA_LAML_SIZE, 16)) != NULL ) >> + switch ( config->tpm_version ) >> { >> - tcpa->lasa = ctxt->mem_ops.v2p(ctxt, lasa); >> - tcpa->laml = ACPI_2_0_TCPA_LAML_SIZE; >> - memset(lasa, 0, tcpa->laml); >> - set_checksum(tcpa, >> - offsetof(struct acpi_header, checksum), >> - tcpa->header.length); >> + case 0: /* Assume legacy code wanted tpm 1.2 */ > Along the lines of what Jason said: Unless this is known to be needed for > anything, I'd prefer if it was omitted. I'm not awair of anything, but your comment 2 lines down  from version 2 made me think you knew of some.  So if your happy with me removing this line, I am! > Jan From xen-devel-bounces@lists.xenproject.org Tue May 02 23:30:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 23:30:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528848.822495 (Exim 4.92) (envelope-from ) id 1ptzRy-0004CV-He; Tue, 02 May 2023 23:30:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528848.822495; Tue, 02 May 2023 23:30:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzRy-0004CO-Dk; Tue, 02 May 2023 23:30:26 +0000 Received: by outflank-mailman (input) for mailman id 528848; Tue, 02 May 2023 23:30:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzRx-0004CI-E6 for xen-devel@lists.xenproject.org; Tue, 02 May 2023 23:30:25 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4db69382-e941-11ed-b225-6b7b168915f2; Wed, 03 May 2023 01:30:22 +0200 (CEST) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2023 19:29:57 -0400 Received: from DS7PR03MB5414.namprd03.prod.outlook.com (2603:10b6:5:2c2::6) by BN9PR03MB5964.namprd03.prod.outlook.com (2603:10b6:408:135::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 23:29:55 +0000 Received: from DS7PR03MB5414.namprd03.prod.outlook.com ([fe80::fdfd:97e5:7c55:82d]) by DS7PR03MB5414.namprd03.prod.outlook.com ([fe80::fdfd:97e5:7c55:82d%6]) with mapi id 15.20.6340.031; Tue, 2 May 2023 23:29:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4db69382-e941-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683070222; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=PtilvS3couIDxORSsS51S+eP1j16D5Wq5MhXfN+iXfo=; b=Lx8o6MI/Vzba/YAdSME1pyYFWG7PjLC0flO/KbpQFrzgcy3POk8TS0Fk 0/rDZKQXJRMDebzEHec5wuVekf3Opbr8jaLu7f5ZQ8ru6sh1L/WEwLuzP Tj++4d+Gn9FCOb68m9RIIfwNfI3cGGAtFH8JdUH6K49F8MjJfOfv4Mr8c k=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 108052479 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Da4lkqMDv4yCtgrvrR2/lsFynXyQoLVcMsEvi/4bfWQNrUp20mQHy GBOCmjQPfuIamL8ctEkYdyy8EoHu5WBzdRqHgto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvPrRC9H5qyo42tF5gZmPpingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0ttUAkpi1 +wfEwFOfgKkvO2c76i8FfY506zPLOGzVG8ekldJ6GiASNwAEdXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PpxujaCpOBy+OGF3N79eNGMQ8Rbk1zep m/c9WnjHjkRNcCFyCrD+XWp7gPKtXqjCNpPTuHnp5aGhnW8nn04GDE8b2KrsMGQm0jhBYldA G0br39GQa8asRbDosPGdx+yrWOAvxUcc8FNCOB84waIooLE7gDcCmUaQzppbN09qNRwVTEsz kWOnd7iGXpoqrL9dJ6G3rKdrDf3My5FK2YHPHYAVVFcvYilp5wvhBXSSNolCLSyktD+BTD3x XaNsTQ6gLIQy8UM0s1X4Gz6vt5lnbCRJiZd2+kddjv+hu+lTOZJv7CV1GU= IronPort-HdrOrdr: A9a23:dAQUaq19z5GohPKf+9JByQqjBdVxeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5OEtOpTlPAtjmfZq6z+8O3WBxB8bYYOCCggeVxe5ZnOjfKlHbalTDH6tmpN 9dmstFeaLN5DpB7foSiTPQe7hA/DDEytHPuQ639QYQcegAUdAE0+4WMHf+LqQ7fnglOXJvf6 Dsm/av6gDQMEj+Ka+Adwo4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/PwmE0gwYWzZvx65n1W TeiQT26oiqrvn+k3bnpiLuxqUTvOGk5spIBcSKhMRQAjLwijywbIAkd6yesCszqOSP7k9vtN XXuR8vM+l69nuUVGCophnG3RXmzV8VmjXf4G7dpUGmjd3yRTo8BcYErYVFciHB405lmN1nyq pE00+QqpISVHr77W/AzumNcysvulu/oHIkn+JWp3tDUbEGYLsUiYAE5ktaHLoJASq/woE6F+ tFCt3a+Z9tABunRkGcmlMq7M2nX3w1EBvDak8euvaN2zwTp3x9x1tw/r1qol4wsLYGD7VU7e XNNapl0JtUSNUNUK57DOAdBeOqF23kW3v3QSOvCGWiMJtCF2PGqpbx7rlwzvqtYoY0wJw7n4 mEeE9EtFQ1Z1nlBaS1rdN2Gyj2MSaAtAnWu4NjD8ATgMy4eFOrC1zNdLkWqbrhnx1FaferH8 paO/ptcorexCXVaMF0NjbFKulvwEklIbMoU+kAKiOzS+LwW/rXX7/gAYDuDYuoNwoYcUXCJV ZGdATPBax7nzKWsznD8VTsZ08= X-Talos-CUID: 9a23:cVMy3GMVvauN2+5DZQpk32I2CsceQz7N3lDrLGWXE2E2V+jA X-Talos-MUID: 9a23:eJxp7wroHYq6VhtgiZgezx46Jex4z46UMVAcqbwXvZbabi5bGjjI2Q== X-IronPort-AV: E=Sophos;i="5.99,245,1677560400"; d="scan'208";a="108052479" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LVR4DddfZ3VJmR/6dMjgtHSn1mo4zeA5vuSO0NwBDd0InMmvuZ7pCLPvzUynRO8Waqr0EWQZx53EV6C46UsPKJyOvdblBJfuWlm9zBm9jkMeYyNh1MUkkstTiudunpBKdbc1WfJkGdiIDOo2e5sqEtK71JTgO6aqZ0HzVNM9FDwdZooYxzM67NibvQvV+05/9ZMFk3KiN37R12dKM4PAlTTi7sGh7+pUCOrzaHxsUO/DOrl+V5tWo7IQFaNhbpFXYRBiyNJamJ64n98m36tJBfxBBpJCWe/IPeKwuDOs4fDs+I40+YOkOEmAmK2uiBTjnXafqnh3bVxGZRined8d1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nnOUfgqG72GzlNLoWtCu9JubUWnp35TFYzuwlitj5yg=; b=YuIuVMJWsBt5FmpTJVbUB4jUYSLJQ8sC+1doBAs0Mzlq45fs15kgqxMo04iz5usFdwzM1sb6yaXFJtf0Ug04RzJnkNsjLGZ5MLTgEvN4ED6Gr7+UQLzgpP39y63xta8A+wPvJvEfyGSvsUisALGw9o9Zol/ezOzM/atyP6Ze7KScrLANM041MbVRJnQW/HGPV1zoa7V+HpjjzN/8ThsWbiceDO27mHOg3bgTBXbc8IysSh0n+PFcIrbW8uRq1TDnH+iFMpdujMTDSmwn2HNwz68wgybunU4+sx7hQRjmD3MOf4nbScyKn6xOtQWd6F9oegPJZ5/LJkWC39F5BpfVKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nnOUfgqG72GzlNLoWtCu9JubUWnp35TFYzuwlitj5yg=; b=KDIgP2XvydV+vk5M8aLAtUYvKsWuTQ0u3F2Hn+hAQBGSzH0wixzx1v+1mDs2A0osC+IOCjQnhuZCVnEZw1hIFibiMR+PLtGMQBAqOXiOad7PQtzZH+VlFfRY14SDws9rFwTgsOGhxuKr7EfdV08qvjtFomToh9dEbnit8rMnlSY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <91620112-039e-9e8b-9bac-452ea9ecddaf@citrix.com> Date: Wed, 3 May 2023 00:29:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3 2/2] acpi: Add TPM2 interface definition. To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Xen-devel References: <20230425174733.795961-1-jennifer.herbert@citrix.com> <20230425174733.795961-3-jennifer.herbert@citrix.com> From: Jennifer Herbert In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0417.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18b::8) To DS7PR03MB5414.namprd03.prod.outlook.com (2603:10b6:5:2c2::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR03MB5414:EE_|BN9PR03MB5964:EE_ X-MS-Office365-Filtering-Correlation-Id: 99b355db-cd5a-4766-ac4b-08db4b652284 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p9Zr2Wz0k+9oM26q2yO3LI+jZNdYZ1KAukRtO0O4X5pwY4hUUPrN3l9Na6ircHiE5y41jorQ5smd/U7lIzfGeH3ggia9vlERZSm1JwziagJUTqvFMaTmyX3TmicjThTX89yjnyyhGYwiw4WDZKvfv95JNmWLGqE7VusmM+uqUtAIXG4JQdGUijRvRBLJ4FyykP8dNKKeJ5D2+yV2k40R7g/C1yR2pqx7wd/WYe+WCm6TUY4H4uwte0DhpUOg7XPrdM/6xC0Zwj7GZYlmOHyANcf8enqd3o3z5IjRsrUlJDtC51brnFea+RYDM0kBMkbGtes/XWp0p1CxdSKAkN2gYiF8qeU88ilhu/kGK+QD8b0MxfHslhlf+BsNuVlQj1stmkQbuLK673lSt7mVwPFQ9vgN7KyrRw4KWb/OyBh0wClwSfUT/EDSkIu3Wq4MiB4xsMyetuElgp2jNocl3YKmPJ0gydPOqXzCvCzVKsG6xrorHeq6hPZjPy+gBw5Yh5BF2Juj2Ch/a+NVqXTtCIjzaye7YXXhdIbKDmSAx4oulaVbTQKieyFtme2imVhwBGNS8RwcblgPUV1/YxQkjxd6We5pdWThLj8y9UPa9lWhjJ1Vnd97WVcBdEAMD3QoLj78WGW0jFkj2CJ35PW4C3o3ZS1FzRPVIvM5jk3GuPGOxVQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5414.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(346002)(136003)(366004)(376002)(451199021)(6666004)(6486002)(2906002)(6512007)(6506007)(26005)(53546011)(186003)(54906003)(2616005)(31686004)(36756003)(478600001)(41300700001)(66946007)(44832011)(82960400001)(316002)(8936002)(38100700002)(8676002)(5660300002)(86362001)(66476007)(66556008)(6916009)(4326008)(31696002)(2004002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dkVKMVZqakFwS202ajVMQUEvbGZ4VzEwbGt4RWhJVWE5eUozOUJVazI0Wklx?= =?utf-8?B?TnJPWG1wNEQ1VzN4MUJ4Q2lUMldvTEUvRFh6REoyeElSeXp0UW4ybmh1cUhT?= =?utf-8?B?cFh3Zmt4OGcwQWpBS2ROZk16VUZsWGNEL2hRK0Y1YzRqWDBsYXBwNmlzaEZK?= =?utf-8?B?MkpSeHRzT09JWUx3a3ZaUmM5WEYyMERVZ0V4ZXdrc3JOSkRZNUQ3NkFvMnVs?= =?utf-8?B?NW9MWElTWTJkZmF1UmdGQk95dUpOMUJablQrcEVsZlFSMGQ0Y2hCVm5oN0pl?= =?utf-8?B?Rm5TSHVoRGZLUkF6cGJaeURaNklSOFg2djBaaFBhNjhLZmZFN0pwbEczUkFH?= =?utf-8?B?Um4vR1pYTjdtZEUyN0pSdWxxM3B5aEZrejZxTkJoQk13NzBVSTF6T3B2d29W?= =?utf-8?B?aXpuN2xMNGl6UFlHbVZIRHdwc21xb1hhbUdKL3h2cmdkM3crSSs0YUNKVmNQ?= =?utf-8?B?UWpYOStTT05RSG94ai9xcTcwK2RGdDRRR2JVYUY3Z1RTazluMWoyWG92aHFZ?= =?utf-8?B?QzFvR0ZOU2NBWlBVSmlhdThNZkl3aUIvMnhrYjd0V2lQOGtEUHhBbmkzRVNl?= =?utf-8?B?MkU1YVFTRnNzMDFGQjRiMXFUKy9oM09SNFcwRUhaM216SCtVeUNWaEpxMHNj?= =?utf-8?B?eTlSVmp3QjVTNStUOWhCYnllSlBKaVZCc1lFeUE5b3hPcHpxR3Bqd2FHdjBO?= =?utf-8?B?OEl4OWJOOUh2aDZjbVBwRmdNTUZ3SFcwNSswLzNINkYwTG5qRFA1Nk1WWnBQ?= =?utf-8?B?c2VkbjNMOXZRMmNUbi9iK1BkOUVpckxKcmR6WGQ1Tms3Vys0NDAvVHJxanp5?= =?utf-8?B?emQ3akNxM3o0aG52OWxxbGJGMFhzQWtMNHZ1dEwxU1lDTW9DVzdUNUNUY2Nw?= =?utf-8?B?SjBYd2paU1JQU1BHa1B0enYvUEFrQ3M4RmNhUklxSXlTRk9xdFUvbGo1Z0xE?= =?utf-8?B?MzlDKzc5Z1ZueW84amJBZmxqdEI4VDNKNmcxVSswa01RNnNqc1R0UmpvQVF3?= =?utf-8?B?UDJsK09hYmRNa293dHM2cWdLSTd2d0Z2cm9kNUJyWTdoM05OSVpqNU01akV3?= =?utf-8?B?MXpmTU1GTzIyNWt5K1A1QWlBTSt6NDhtdzBLUXpkVEg5ZDRxbWpEckgrTVhm?= =?utf-8?B?ejE5Ymc1T0lDWTZCUDFsemtrQzBsWTF3MmRqa2lyc292SlFUeTgrNnFlVW8z?= =?utf-8?B?QWpXejFoWjQvTGU5QS8wWmxMam8vNHIzU2Z6QjVKRU1kTlF0RkZkS0hIejN3?= =?utf-8?B?NHkycGsvNU1UQW56NklUd2JoazR0T0dxRDhsMGQ3RG5mLzNYeFltaXMvT0lD?= =?utf-8?B?ZGs0R0NPSUVwSG1qenhMT3RxKy9QQzV3bUxQamRDb2FNd21NaC9meS9kZG40?= =?utf-8?B?Ky9nOVNuUEtKTlB4RmJxeXlSYTE3WThLbGxZWkkrV3VabkFwbi9tbHJaZUk4?= =?utf-8?B?aVo5MEZNZFVYaDJsTTJ3ODZNd2FWTHcwcUZSajU2aHBCR0xLVlcwSnZkQWxG?= =?utf-8?B?TzNRb1FCZFdId2RBTUoycUVESnFiNGN5Z3phYVh6MXpkeFlLRENXY2ZSL1h4?= =?utf-8?B?T2wweXMvemtJdHZJRU1NZGpLWDE2L2tlV210L1M2L3BCOTVYd2lPRGZYaHdv?= =?utf-8?B?TnlOdm5sS2dkaXVVTGo2Y1ArV1pTK1FOaE14MHdHYjMxU3JsdjdXV3hrNVVE?= =?utf-8?B?OWhyRXVyb1c4TWxsRXJmbitma2hpY2hkRTFOakpmd3d3Q1lMNElwUzJwcEdS?= =?utf-8?B?dnRLOWRUeHlmbjBiRTh0OWRFT0NqZDRQNm1KK1JwNG5mVSt3R2RVa0pRaG1z?= =?utf-8?B?WlpEL0hCMHFobjFybVdRMVdTb3Ryd3dLdzRPWnM3aHpjd3RDOTV0Tm1mQ0dI?= =?utf-8?B?NkVFOHRoYS90UGlyaFlxODllSEpZc1UrSmJxdVBETGhJRUdxOTQ4YVUveHBp?= =?utf-8?B?dlU1L3g1enUyYzZSdUhuT0xXVFhRanpjN09OL0xwTHdqQlBiY2xQcGJDWCt3?= =?utf-8?B?OStseEZJaVNPd0tDcy9aZk14endOcExGWkE5QmZ0c1QzU1NxVFVUaXlxa1h2?= =?utf-8?B?OHRzUFp0TEl4RDFoNlVTbVQ3OUxBOXZ0UmwzTVlNa1lBaTA1dUNrQnRyT1JT?= =?utf-8?B?aGRKdEpBZlJoeDgrU3Ria2w0UWNTa3JGWkJMZDR1bE4xalFWV3o2d0pQOVJF?= =?utf-8?B?ZWc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 9ycWrDL90mzr8SruEvNFf8nhroJMOFLF4OjtW1G79tupabDWwN43LJDGU+toDFIm4Mtf5iMoLv6GIL3oTwMiDTc7K2b6GBieWZqnIeIkNAn1/SZxvUD+E3+d0hQV+Ob0P6dCPqdUtQf2gQ0ixUXMbMXDBm7ysEKLYYG64iDJUPvTOlKJDm7G9fqnBsqnZhLiE4l+Q7fd5PlLLimtTc1E26oLfLNdRhh2tkhwEWKcgNPq+3beDVQQjMz3otWT4rHexEF5UzLLtr5QoYron2beqhhtOqRokRGwmSScokJoS+OTBPX38DXJ2owT3jkapn4tH7vEizahntowOY54iElN7aOu2H6zJdwzrdxVD20CdPwVgxBB7feJwt5hEAa17UZpuG6ZaEFpevvhNyAvSTi5Vd9SQyprwMK9wo/QBcGQEJoVzND/kpH56RZHc+oXyFWFfdR1NRhGb+8Z98VKXBKrF9O8nEQLPayO+wPI5ArBqusgkbQygl45duIBXEUZ/VOSLpKGEOb3a3yJwI5hhpFSqNwJTvvueVE8DGw4umx5NxwWsbPzsIkdL29r/rOC/yavk7O0ZuwFcBS/6JeY5/glIbWfev0tQuFmJ47oWVMCGDl2FZwIPRJO0blwl0/mJ+XdkVuX7UNtCzDVCqA0UhEceFPfP4aBQxny4UNV4IgTfg4S3P0i0v20huOHxZTmMiTaQUXQb98oI7cz4/O3CFnVIIti2ZbfIY9XfmloSTbcZLc85w0wv6UNME/aTsU74XJwoh/PYhA+jsULEKNwW2c10QWM3NHBvuvoSBykfWAXca4= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 99b355db-cd5a-4766-ac4b-08db4b652284 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5414.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 23:29:54.8173 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: boBBs/8emxpfjGyoMwtLTTdC+jqCJvh5hIZlQcXr9EBSuADaQ6m3FNu8sTFEvw40t4iUcdVXqsLj3bmldDtmNIDyo4KJCfXX1bluOszZ1/M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB5964 On 02/05/2023 14:41, Jan Beulich wrote: > On 25.04.2023 19:47, Jennifer Herbert wrote: >> --- a/tools/libacpi/acpi2_0.h >> +++ b/tools/libacpi/acpi2_0.h >> @@ -121,6 +121,36 @@ struct acpi_20_tcpa { >> }; >> #define ACPI_2_0_TCPA_LAML_SIZE (64*1024) >> >> +/* >> + * TPM2 >> + */ > Nit: While I'm willing to accept the comment style violation here as > (apparently) intentional, ... Well, I was trying to keep the file consistant.   As far as I can tell, this styling is used thoughout the file - unless I'm misunderstanding your 'Nit'. (You object to a multi-line coment used for a single line? ) But I'm codes style blind, so just say how you want it. >> +struct acpi_20_tpm2 { >> + struct acpi_header header; >> + uint16_t platform_class; >> + uint16_t reserved; >> + uint64_t control_area_address; >> + uint32_t start_method; >> + uint8_t start_method_params[12]; >> + uint32_t log_area_minimum_length; >> + uint64_t log_area_start_address; >> +}; >> +#define TPM2_ACPI_CLASS_CLIENT 0 >> +#define TPM2_START_METHOD_CRB 7 >> + >> +/* TPM register I/O Mapped region, location of which defined in the >> + * TCG PC Client Platform TPM Profile Specification for TPM 2.0. >> + * See table 9 - Only Locality 0 is used here. This is emulated by QEMU. >> + * Definition of Register space is found in table 12. >> + */ > ... this comment wants adjusting to hypervisor style (/* on its own line), > as that looks to be the aimed-at style in this file. Will do. >> @@ -352,6 +353,7 @@ static int construct_secondary_tables(struct acpi_ctxt *ctxt, >> struct acpi_20_tcpa *tcpa; >> unsigned char *ssdt; >> void *lasa; >> + struct acpi_20_tpm2 *tpm2; > Could I talk you into moving this up by two lines, such that it'll be > adjacent to "tcpa"? No problem. >> @@ -450,6 +452,43 @@ static int construct_secondary_tables(struct acpi_ctxt *ctxt, >> tcpa->header.length); >> } >> break; >> + >> + case 2: >> + /* Check VID stored in bits 37:32 (3rd 16 bit word) of CRB >> + * identifier register. See table 16 of TCG PC client platform >> + * TPM profile specification for TPM 2.0. >> + */ > Nit: This comment again wants a style adjustment. ok >> --- /dev/null >> +++ b/tools/libacpi/ssdt_tpm2.asl >> @@ -0,0 +1,36 @@ >> +/* >> + * ssdt_tpm2.asl >> + * >> + * Copyright (c) 2018-2022, Citrix Systems, Inc. >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU Lesser General Public License as published >> + * by the Free Software Foundation; version 2.1 only. with the special >> + * exception on linking described in file LICENSE. >> + * >> + * This program is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU Lesser General Public License for more details. >> + */ > While the full conversion to SPDX was done in the hypervisor only so far, > I think new tool stack source files would better use the much shorter > SPDX equivalent, too. OK, this is where I get a bit confused.  I belive I copied the licence from ssdt_tpm.asl, for consistancy. So I think i need to use a 'LGPL-2.1-only' but then it says its using exceptions on linking as discribed in LICENSE, but um, which LICENSE file?  So i'm not sure what exception I should be adding. Do you know? > Then on top of Jason's R-b, > Acked-by: Jan Beulich > > Jan Thanks, -jenny From xen-devel-bounces@lists.xenproject.org Tue May 02 23:37:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 23:37:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528853.822504 (Exim 4.92) (envelope-from ) id 1ptzYZ-0004sP-9w; Tue, 02 May 2023 23:37:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528853.822504; Tue, 02 May 2023 23:37:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzYZ-0004sI-7E; Tue, 02 May 2023 23:37:15 +0000 Received: by outflank-mailman (input) for mailman id 528853; Tue, 02 May 2023 23:37:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzYX-0004sC-LX for xen-devel@lists.xenproject.org; Tue, 02 May 2023 23:37:13 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on20611.outbound.protection.outlook.com [2a01:111:f400:7e8a::611]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 429877f1-e942-11ed-b225-6b7b168915f2; Wed, 03 May 2023 01:37:11 +0200 (CEST) Received: from DM6PR06CA0068.namprd06.prod.outlook.com (2603:10b6:5:54::45) by IA1PR12MB7589.namprd12.prod.outlook.com (2603:10b6:208:42b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Tue, 2 May 2023 23:37:05 +0000 Received: from DM6NAM11FT068.eop-nam11.prod.protection.outlook.com (2603:10b6:5:54:cafe::e) by DM6PR06CA0068.outlook.office365.com (2603:10b6:5:54::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.20 via Frontend Transport; Tue, 2 May 2023 23:37:05 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT068.mail.protection.outlook.com (10.13.173.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.21 via Frontend Transport; Tue, 2 May 2023 23:37:05 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 2 May 2023 18:37:03 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 2 May 2023 16:37:03 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 2 May 2023 18:37:02 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 429877f1-e942-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZLZXj1JXvDZcDJ1ousp2Un42WflSH8aECl8ooOxRxSCk5vIeOZTNtfvq8MxYeBDv0O0iXM1HrEYo+0bn/wS7cGo3qHwwEMr8B+YHwmlwqflXUiQmaTgefbu6JQRBFa9BlKwp0slS9isLs5fmt/w7UHAaF+foWr/HgEDyTRGI9GohdK+k+mpjYGKPifAAP9OYgEbFbujKTUX8XM061MgSXCqG/o490d6V623TRQ3Y2uxC+Yj8bUZG5SN6/zKT6xYUajWaEF/B1M2WKraR3X4PDN/SCnPLExp2xdJdgQTiJy12K0lG8XUChMRFoo1njpFMi2wISQpRc0HSTXdcihwsCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZscFKHtEwxmwCfbCbt4eRL4EXCZVnMpebuuBX3YRsyA=; b=RtitxiBzJxgpb1v9xEcCSbM1XNJE5GQ+V0NOrB9gCjzXVX2zWDQ8REjq1Vk3lgMTnRfFSx/UgRd7tJPbhYEIggZZqq/kK1XhmnVLHKkuVgp6Rw4zDnVv2XPN3i4jjRyC9Wjn6Wv0WO5H5C1rIr8Tkw1tapSBtu+HYhOeD4Xx0T1PgnkTfPIfjktl7Dy87uf3ogBIWBM7CeCq+u1z+iVG+wyLHfHz8Wmn1cjaZJZAlpY4AyXm8xjUMhIuQCPNHn/+3DvrYYGtP6IMy7YZ+D7UOCMd/xAD+/tZAirItowkhLJE7q4/4c/uUB0Tnira0CKE8jHqOBMc3bfpM1o0NNLw8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZscFKHtEwxmwCfbCbt4eRL4EXCZVnMpebuuBX3YRsyA=; b=jxDFiVkCYn9xatcHc0c0NhBlsAod0TNNt2oWeWhDKdVZgjCoNuvI0Z5G7JSTL1YCjg6sXRpaFQxZEyWY7oREBIeOpI8P2p047kFi9BLCmt8+ppfNVo6uaJv6DdaHkxVwLWGF5+cVqCycB/BxD6zDqjeM8GzsNc6jO/ymrhNFCvk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Vikram Garhwal To: CC: , , , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Rahul Singh , Anthony PERARD , "Juergen Gross" Subject: [XEN][PATCH v6 00/19] dynamic node programming using overlay dtbo Date: Tue, 2 May 2023 16:36:31 -0700 Message-ID: <20230502233650.20121-1-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT068:EE_|IA1PR12MB7589:EE_ X-MS-Office365-Filtering-Correlation-Id: a7809011-32f1-4b14-44bb-08db4b66232d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: N8w8ph0vVidtsKiePulqsXxpmZwZ8SgtS8c4gubAvBLUNGZawYNuRjEiTJjmO5epKkscOWSnikZgDhLr8mHAiUAIucSOk/wYehReqKrYbJr7bNaiybll00p6UYP+mGSRFETssuDKEbT3SWTgf5mgXf/SaWXG1SdWjnJ3h2baaQOwnCk/DNx0GMupPWvdhBydJUmLxjLZvYE7P4TRNVWkoxMD+8F+MBRiUVJGfo+AeRitK7w1i0PEgPRw+A6zHDCRh9H4CFaJUsruUexFm3qI4Jo0NLdBFidE9tWRgfE4LKCFZhLe2OdvH7hWlqcyr/TpH32hYriDelAVB5a1nMxrL8y/CJ3hPlEVqy0EgcX1RjzgUtokLiRPksuFWFdmAK227LlBa+zeATvbBuyUj3ycxv/ZPBxAr67iqyaI+jCAKD6JYkT1CJHFUcFyTlFR3tQ8Crp98IFX2yKqvFYvUh0sztpYVJJViyzbBLNhpP8tw2No+fK1oUUZeHHlmmdpHzXtStsVrBOxoOsXtLNqPjf6s03y99v8X4ry9XsBj6ar14uGcW65iJ0ujSzsfZgxve9sUb0rJxYkGsx7h+wHOkHDbvQ0Bv9GktgYaJrJHUq/ra0ol9XDCDn5ulISwjoPF/bM8UV+5Ivqp/jKFSMzQrQQonKW1Fy8VMP/pjzrppE51Qx4CXliwPtJzT4wGExdwGlUnODs7eUbitNx9tJrZF7j+cV1uWqOM1QXPqT8QniULr4= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(376002)(346002)(39860400002)(451199021)(46966006)(36840700001)(40470700004)(316002)(426003)(336012)(40480700001)(5660300002)(82740400003)(44832011)(81166007)(41300700001)(47076005)(356005)(6916009)(4326008)(70206006)(70586007)(83380400001)(54906003)(36860700001)(2616005)(40460700003)(8676002)(8936002)(82310400005)(26005)(1076003)(86362001)(186003)(36756003)(7416002)(2906002)(6666004)(478600001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 23:37:05.1348 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a7809011-32f1-4b14-44bb-08db4b66232d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT068.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7589 Hi, This patch series is for introducing dynamic programming i.e. add/remove the devices during run time. Using "xl dt_overlay" a device can be added/removed with dtbo. For adding a node using dynamic programming: 1. flatten device tree overlay node will be added to a fdt 2. Updated fdt will be unflattened to a new dt_host_new 3. Extract the newly added node information from dt_host_new 4. Add the added node under correct parent in original dt_host. 3. Map/Permit interrupt and iomem region as required. For removing a node: 1. Find the node with given path. 2. Check if the node is used by any of domus. Removes the node only when it's not used by any domain. 3. Removes IRQ permissions and MMIO access. 5. Find the node in dt_host and delete the device node entry from dt_host. 6. Free the overlay_tracker entry which means free dt_host_new also(created in adding node step). The main purpose of this series to address first part of the dynamic programming i.e. making Xen aware of new device tree node which means updating the dt_host with overlay node information. Here we are adding/removing node from dt_host, and checking/set IOMMU and IRQ permission but never mapping them to any domain. Right now, mapping/Un-mapping will happen only when a new domU is created/destroyed using "xl create". To map IOREQ and IOMMU during runtime, there will be another small series after this one where we will do the actual IOMMU and IRQ mapping to a running domain and will call unmap_mmio_regions() to remove the mapping. Change Log: v5 -> v6: Add separate patch for memory allocation failure in __unflatten_device_tree(). Move __unflatten_device_tree() function type changes to single patch. Add error propagation for failures in unflatten_dt_node. Change CONFIG_OVERLAY_DTB status to "ARM: Tech Preview". xen/smmu: Add remove_device callback for smmu_iommu ops: Added check to see if device is currently used. common/device_tree: Add rwlock for dt_host: Addressed feedback from Henry to rearrange code. xen/arm: Implement device tree node removal functionalities: Changed file name to dash format. Addressed Michal's comments. Rectified formatting related errors pointed by Michal. v4 -> v5: Split patch 01/16 to two patches. One with function type changes and another with changes inside unflatten_device_tree(). Change dt_overlay xl command to dt-overlay. Protect overlay functionality with CONFIG(arm). Fix rwlock issues. Move include "device_tree.h" to c file where arch_cpu_init() is called and forward declare dt_device_node. This was done to avoid circular deps b/w device_tree.h and rwlock.h Address Michal's comment on coding style. v3 -> v4: Add support for adding node's children. Add rwlock to dt_host functions. Corrected fdt size issue when applying overlay into it. Add memory allocation fail handling for unflatten_device_tree(). Changed xl overlay to xl dt_overlay. Correct commit messages. Addressed code issue from v3 review. v2 -> v3: Moved overlay functionalities to dt_overlay.c file. Renamed XEN_SYSCTL_overlay to XEN_SYSCTL_dt_overlay. Add dt_* prefix to overlay_add/remove_nodes. Added dtdevs_lock to protect iommu_add_dt_device(). For iommu, moved spin_lock to caller. Address code issue from v2 review. v1 -> v2: Add support for multiple node addition/removal using dtbo. Replaced fpga-add and fpga-remove with one hypercall overlay_op. Moved common domain_build.c function to device.c Add OVERLAY_DTB configuration. Renamed overlay_get_target() to fdt_overlay_get_target(). Split remove_device patch into two patches. Moved overlay_add/remove code to sysctl and changed it from domctl to sysctl. Added all overlay code under CONFIG_OVERLAY_DTB Renamed all tool domains fpga function to overlay Addressed code issues from v1 review. Regards, Vikram Vikram Garhwal (19): xen/arm/device: Remove __init from function type common/device_tree: handle memory allocation failure in __unflatten_device_tree() common/device_tree: change __unflatten_device_tree() type common/device_tree.c: unflatten_device_tree() propagate errors xen/arm: Add CONFIG_OVERLAY_DTB libfdt: Keep fdt functions after init for CONFIG_OVERLAY_DTB. libfdt: overlay: change overlay_get_target() xen/device-tree: Add device_tree_find_node_by_path() to find nodes in device tree xen/iommu: Move spin_lock from iommu_dt_device_is_assigned to caller xen/iommu: protect iommu_add_dt_device() with dtdevs_lock xen/iommu: Introduce iommu_remove_dt_device() xen/smmu: Add remove_device callback for smmu_iommu ops asm/smp.h: Fix circular dependency for device_tree.h and rwlock.h common/device_tree: Add rwlock for dt_host xen/arm: Implement device tree node removal functionalities xen/arm: Implement device tree node addition functionalities tools/libs/ctrl: Implement new xc interfaces for dt overlay tools/libs/light: Implement new libxl functions for device tree overlay ops tools/xl: Add new xl command overlay for device tree overlay support SUPPORT.md | 6 + tools/include/libxl.h | 11 + tools/include/xenctrl.h | 5 + tools/libs/ctrl/Makefile.common | 1 + tools/libs/ctrl/xc_dt_overlay.c | 48 ++ tools/libs/light/Makefile | 3 + tools/libs/light/libxl_dt_overlay.c | 71 ++ tools/xl/xl.h | 1 + tools/xl/xl_cmdtable.c | 6 + tools/xl/xl_vmcontrol.c | 52 ++ xen/arch/arm/Kconfig | 5 + xen/arch/arm/device.c | 144 ++++ xen/arch/arm/domain_build.c | 142 ---- xen/arch/arm/include/asm/domain_build.h | 2 - xen/arch/arm/include/asm/setup.h | 6 + xen/arch/arm/include/asm/smp.h | 3 +- xen/arch/arm/smpboot.c | 1 + xen/arch/arm/sysctl.c | 16 +- xen/common/Makefile | 1 + xen/common/device_tree.c | 50 +- xen/common/dt-overlay.c | 929 ++++++++++++++++++++++++ xen/common/libfdt/Makefile | 4 + xen/common/libfdt/fdt_overlay.c | 29 +- xen/common/libfdt/version.lds | 1 + xen/drivers/passthrough/arm/smmu.c | 58 ++ xen/drivers/passthrough/device_tree.c | 87 ++- xen/include/public/sysctl.h | 23 + xen/include/xen/device_tree.h | 28 +- xen/include/xen/dt-overlay.h | 58 ++ xen/include/xen/iommu.h | 3 + xen/include/xen/libfdt/libfdt.h | 18 + 31 files changed, 1623 insertions(+), 189 deletions(-) create mode 100644 tools/libs/ctrl/xc_dt_overlay.c create mode 100644 tools/libs/light/libxl_dt_overlay.c create mode 100644 xen/common/dt-overlay.c create mode 100644 xen/include/xen/dt-overlay.h -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue May 02 23:37:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 23:37:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528854.822515 (Exim 4.92) (envelope-from ) id 1ptzYg-00059l-IB; Tue, 02 May 2023 23:37:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528854.822515; Tue, 02 May 2023 23:37:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzYg-00059e-EG; Tue, 02 May 2023 23:37:22 +0000 Received: by outflank-mailman (input) for mailman id 528854; Tue, 02 May 2023 23:37:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzYe-0004sC-F0 for xen-devel@lists.xenproject.org; Tue, 02 May 2023 23:37:20 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on20625.outbound.protection.outlook.com [2a01:111:f400:7e8a::625]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 474e8439-e942-11ed-b225-6b7b168915f2; Wed, 03 May 2023 01:37:19 +0200 (CEST) Received: from DS7PR03CA0256.namprd03.prod.outlook.com (2603:10b6:5:3b3::21) by PH0PR12MB5404.namprd12.prod.outlook.com (2603:10b6:510:d7::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 23:37:15 +0000 Received: from DM6NAM11FT072.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b3:cafe::86) by DS7PR03CA0256.outlook.office365.com (2603:10b6:5:3b3::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31 via Frontend Transport; Tue, 2 May 2023 23:37:15 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT072.mail.protection.outlook.com (10.13.173.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.21 via Frontend Transport; Tue, 2 May 2023 23:37:15 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 2 May 2023 18:37:13 -0500 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 2 May 2023 18:37:13 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 474e8439-e942-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eqY7o3U2kc48o7sQ9kzIP4hsRjay3NTEhCYn6scr9vlx2szGvghJBY7BTqBZ5+ePpX2hGq0WAmuGD0pGkDFsLPsa4viQ73nQ5KnudJ3/1o1WnOAiiM8t0gUGwrhdnaUMx6ULthTR7pskowWxfrm2kZOb52Z3EacSFArS7+f7GJ34ASmTZjjK0YTLjF9R3pp9tLgsi3d1f82bQHE7EvMMte0BvmyQ1blkNla4LmgJhYVLRr3DZBmuEYnl0TluTKmlFH7tk0BdHEkZk9/ZJpTU9qBbzdFhN8Iy4K/jpuuoBBbLPLuZPqhMNSCvytZNDA3pOTBJcIpHUioeafUBrgarcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z1f/f7bsw24NdyZtZPfyDM5uGc9VQDLG7SJSmTtwvfg=; b=OWKuBhLTe0ujJwlwhEqj05kzwWoUPrsysQTQJ3V+a5n9hZvLwFkBOP8PGgdu7hu5kici3C0bnY22OjLvuhFGvvSa9erk3Cs3ue1k+ijPVkZ3o2wQyGSrRbDP5pwAYagNdBwSIvtKHKj5h14UBJ2cpt6bbV7vipmfFt/V2Ra5TZ6428Z8+b0+QQaB+Mq22qb1Hj1b/Z8X5sGVmHn5nBnYq0DUnX3LusBXuS19Z/CUBbX/OG/FmaSNnWfHBF/kbQyuFV6Qv7hTSNPiQfOYwlnPRLapX2rG3sXShsvSgWLGqxNzkOQZBMVc2jLd7JY+v2G4ICu2jTezlYrvDIrySlqqwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z1f/f7bsw24NdyZtZPfyDM5uGc9VQDLG7SJSmTtwvfg=; b=y/JQ2yrTo88/hmwMi8xLbMSEhyKhySLQPOvP75g0ejnrU/llpBn/nzzZGD+Jnwrwyqj+wnCVFIw/yR1PIwBDerq6x7DaOwryVVmOAzX9VyER2w6s1il8SriJbBnJ4pIeLPnUpohQjNSmWzO0L/X5eU+uXdWvV1yrhLuD7szxO4w= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Vikram Garhwal To: CC: , , , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [XEN][PATCH v6 01/19] xen/arm/device: Remove __init from function type Date: Tue, 2 May 2023 16:36:32 -0700 Message-ID: <20230502233650.20121-2-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230502233650.20121-1-vikram.garhwal@amd.com> References: <20230502233650.20121-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT072:EE_|PH0PR12MB5404:EE_ X-MS-Office365-Filtering-Correlation-Id: 02c9cde4-7911-4d95-51bf-08db4b662922 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sIAHOPEjxzjT7v3MKV92z8sKxP+zmf6zc7ms5pdpvVtVtQs6Z2k2XuKcpRcN+ZvrIjO8HETaBTkyleK/7YapDMQNrmCmMUMOeqG0a9f4JDJFJt7HxcCH5JEaOwyGzbEdhcaHXM/lSNohS3xhTdS+/pEIEgf3eKp/WWBNznENr2TxBNCJq8EKqe+U4i5UvBhXhIZZ2+6/LMdM+TtKcc2GNMD1G3hkKG7zida+FFIrngZOe1MOWUJnWf5Qk8hP/Cy8fjZosLPpUrLPcPMeOR2JAI962904PTofp+Z9PItZ+Wbo3ypG76QbWU6i+Sqt1ooa1Auna1sHU20MLlDuJ5/KI/qi2jxOzf2oJdDOi/s3RnorY2bA7KWTdxVmjftYuDhZJpvsC+lR0Um9Q3PHlACk7nCR7FWtkx3lW6+9K1R68bP4R8CaUIEue7KeXN+J5opBoRlPxdQ1h1NehoNYzie4xVbkHr4F71wyXvV9mNcQCPDw50Yq+SVFECj2nXd7NeUkh/Xruv+4Js4dL3UVN0yyEGqop9JpUtTDs3wI8BKxhsWvv734xHYKAYGgtT/JwMkVlmOA8L4Hvd2KSKFjUwoLegDxUXb6lpy1araBni7IheHeXKtIjYEazEf0jitG23RJFC1K1Skk+fqH0Acs0H29sbGFm6G0z+ubs/yWPV7SxI4HFCOgGTH41zwbQQLtjY/iJxZGg1v3lJ0LOp2LDuJBX51bADg5L+QgSJFCxw26nvo= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(39860400002)(136003)(396003)(451199021)(36840700001)(40470700004)(46966006)(26005)(1076003)(86362001)(6666004)(8676002)(8936002)(40460700003)(5660300002)(2906002)(30864003)(70206006)(70586007)(6916009)(4326008)(36860700001)(82740400003)(81166007)(356005)(41300700001)(44832011)(316002)(478600001)(40480700001)(186003)(47076005)(36756003)(426003)(336012)(82310400005)(83380400001)(54906003)(2616005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 23:37:15.1138 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 02c9cde4-7911-4d95-51bf-08db4b662922 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT072.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5404 Remove __init from following function to access during runtime: 1. map_irq_to_domain() 2. handle_device_interrupts() 3. map_range_to_domain() 4. unflatten_dt_node() Move map_irq_to_domain() prototype from domain_build.h to setup.h. To avoid breaking the build, following changes are also done: 1. Move map_irq_to_domain(), handle_device_interrupts() and map_range_to_domain() to device.c. After removing __init type, these functions are not specific to domain building, so moving them out of domain_build.c to device.c. 2. Remove static type from handle_device_interrupt(). Overall, these changes are done to support the dynamic programming of a nodes where an overlay node will be added to fdt and unflattened node will be added to dt_host. Furthermore, IRQ and mmio mapping will be done for the added node. Signed-off-by: Vikram Garhwal Reviewed-by: Michal Orzel --- xen/arch/arm/device.c | 144 ++++++++++++++++++++++++ xen/arch/arm/domain_build.c | 142 ----------------------- xen/arch/arm/include/asm/domain_build.h | 2 - xen/arch/arm/include/asm/setup.h | 6 + xen/common/device_tree.c | 12 +- 5 files changed, 156 insertions(+), 150 deletions(-) diff --git a/xen/arch/arm/device.c b/xen/arch/arm/device.c index ca8539dee5..84197981a0 100644 --- a/xen/arch/arm/device.c +++ b/xen/arch/arm/device.c @@ -9,8 +9,10 @@ */ #include +#include #include #include +#include #include extern const struct device_desc _sdevice[], _edevice[]; @@ -75,6 +77,148 @@ enum device_class device_get_class(const struct dt_device_node *dev) return DEVICE_UNKNOWN; } +int map_irq_to_domain(struct domain *d, unsigned int irq, + bool need_mapping, const char *devname) +{ + int res; + + res = irq_permit_access(d, irq); + if ( res ) + { + printk(XENLOG_ERR "Unable to permit to dom%u access to IRQ %u\n", + d->domain_id, irq); + return res; + } + + if ( need_mapping ) + { + /* + * Checking the return of vgic_reserve_virq is not + * necessary. It should not fail except when we try to map + * the IRQ twice. This can legitimately happen if the IRQ is shared + */ + vgic_reserve_virq(d, irq); + + res = route_irq_to_guest(d, irq, irq, devname); + if ( res < 0 ) + { + printk(XENLOG_ERR "Unable to map IRQ%"PRId32" to dom%d\n", + irq, d->domain_id); + return res; + } + } + + dt_dprintk(" - IRQ: %u\n", irq); + return 0; +} + +int map_range_to_domain(const struct dt_device_node *dev, + u64 addr, u64 len, void *data) +{ + struct map_range_data *mr_data = data; + struct domain *d = mr_data->d; + int res; + + /* + * reserved-memory regions are RAM carved out for a special purpose. + * They are not MMIO and therefore a domain should not be able to + * manage them via the IOMEM interface. + */ + if ( strncasecmp(dt_node_full_name(dev), "/reserved-memory/", + strlen("/reserved-memory/")) != 0 ) + { + res = iomem_permit_access(d, paddr_to_pfn(addr), + paddr_to_pfn(PAGE_ALIGN(addr + len - 1))); + if ( res ) + { + printk(XENLOG_ERR "Unable to permit to dom%d access to" + " 0x%"PRIx64" - 0x%"PRIx64"\n", + d->domain_id, + addr & PAGE_MASK, PAGE_ALIGN(addr + len) - 1); + return res; + } + } + + if ( !mr_data->skip_mapping ) + { + res = map_regions_p2mt(d, + gaddr_to_gfn(addr), + PFN_UP(len), + maddr_to_mfn(addr), + mr_data->p2mt); + + if ( res < 0 ) + { + printk(XENLOG_ERR "Unable to map 0x%"PRIx64 + " - 0x%"PRIx64" in domain %d\n", + addr & PAGE_MASK, PAGE_ALIGN(addr + len) - 1, + d->domain_id); + return res; + } + } + + dt_dprintk(" - MMIO: %010"PRIx64" - %010"PRIx64" P2MType=%x\n", + addr, addr + len, mr_data->p2mt); + + return 0; +} + +/* + * handle_device_interrupts retrieves the interrupts configuration from + * a device tree node and maps those interrupts to the target domain. + * + * Returns: + * < 0 error + * 0 success + */ +int handle_device_interrupts(struct domain *d, + struct dt_device_node *dev, + bool need_mapping) +{ + unsigned int i, nirq; + int res; + struct dt_raw_irq rirq; + + nirq = dt_number_of_irq(dev); + + /* Give permission and map IRQs */ + for ( i = 0; i < nirq; i++ ) + { + res = dt_device_get_raw_irq(dev, i, &rirq); + if ( res ) + { + printk(XENLOG_ERR "Unable to retrieve irq %u for %s\n", + i, dt_node_full_name(dev)); + return res; + } + + /* + * Don't map IRQ that have no physical meaning + * ie: IRQ whose controller is not the GIC + */ + if ( rirq.controller != dt_interrupt_controller ) + { + dt_dprintk("irq %u not connected to primary controller. Connected to %s\n", + i, dt_node_full_name(rirq.controller)); + continue; + } + + res = platform_get_irq(dev, i); + if ( res < 0 ) + { + printk(XENLOG_ERR "Unable to get irq %u for %s\n", + i, dt_node_full_name(dev)); + return res; + } + + res = map_irq_to_domain(d, res, need_mapping, dt_node_name(dev)); + if ( res ) + return res; + } + + return 0; +} + /* * Local variables: * mode: C diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index f80fdd1af2..5e4108a233 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -2257,41 +2257,6 @@ int __init make_chosen_node(const struct kernel_info *kinfo) return res; } -int __init map_irq_to_domain(struct domain *d, unsigned int irq, - bool need_mapping, const char *devname) -{ - int res; - - res = irq_permit_access(d, irq); - if ( res ) - { - printk(XENLOG_ERR "Unable to permit to dom%u access to IRQ %u\n", - d->domain_id, irq); - return res; - } - - if ( need_mapping ) - { - /* - * Checking the return of vgic_reserve_virq is not - * necessary. It should not fail except when we try to map - * the IRQ twice. This can legitimately happen if the IRQ is shared - */ - vgic_reserve_virq(d, irq); - - res = route_irq_to_guest(d, irq, irq, devname); - if ( res < 0 ) - { - printk(XENLOG_ERR "Unable to map IRQ%"PRId32" to dom%d\n", - irq, d->domain_id); - return res; - } - } - - dt_dprintk(" - IRQ: %u\n", irq); - return 0; -} - static int __init map_dt_irq_to_domain(const struct dt_device_node *dev, const struct dt_irq *dt_irq, void *data) @@ -2323,57 +2288,6 @@ static int __init map_dt_irq_to_domain(const struct dt_device_node *dev, return 0; } -int __init map_range_to_domain(const struct dt_device_node *dev, - u64 addr, u64 len, void *data) -{ - struct map_range_data *mr_data = data; - struct domain *d = mr_data->d; - int res; - - /* - * reserved-memory regions are RAM carved out for a special purpose. - * They are not MMIO and therefore a domain should not be able to - * manage them via the IOMEM interface. - */ - if ( strncasecmp(dt_node_full_name(dev), "/reserved-memory/", - strlen("/reserved-memory/")) != 0 ) - { - res = iomem_permit_access(d, paddr_to_pfn(addr), - paddr_to_pfn(PAGE_ALIGN(addr + len - 1))); - if ( res ) - { - printk(XENLOG_ERR "Unable to permit to dom%d access to" - " 0x%"PRIx64" - 0x%"PRIx64"\n", - d->domain_id, - addr & PAGE_MASK, PAGE_ALIGN(addr + len) - 1); - return res; - } - } - - if ( !mr_data->skip_mapping ) - { - res = map_regions_p2mt(d, - gaddr_to_gfn(addr), - PFN_UP(len), - maddr_to_mfn(addr), - mr_data->p2mt); - - if ( res < 0 ) - { - printk(XENLOG_ERR "Unable to map 0x%"PRIx64 - " - 0x%"PRIx64" in domain %d\n", - addr & PAGE_MASK, PAGE_ALIGN(addr + len) - 1, - d->domain_id); - return res; - } - } - - dt_dprintk(" - MMIO: %010"PRIx64" - %010"PRIx64" P2MType=%x\n", - addr, addr + len, mr_data->p2mt); - - return 0; -} - /* * For a node which describes a discoverable bus (such as a PCI bus) * then we may need to perform additional mappings in order to make @@ -2401,62 +2315,6 @@ static int __init map_device_children(const struct dt_device_node *dev, return 0; } -/* - * handle_device_interrupts retrieves the interrupts configuration from - * a device tree node and maps those interrupts to the target domain. - * - * Returns: - * < 0 error - * 0 success - */ -static int __init handle_device_interrupts(struct domain *d, - struct dt_device_node *dev, - bool need_mapping) -{ - unsigned int i, nirq; - int res; - struct dt_raw_irq rirq; - - nirq = dt_number_of_irq(dev); - - /* Give permission and map IRQs */ - for ( i = 0; i < nirq; i++ ) - { - res = dt_device_get_raw_irq(dev, i, &rirq); - if ( res ) - { - printk(XENLOG_ERR "Unable to retrieve irq %u for %s\n", - i, dt_node_full_name(dev)); - return res; - } - - /* - * Don't map IRQ that have no physical meaning - * ie: IRQ whose controller is not the GIC - */ - if ( rirq.controller != dt_interrupt_controller ) - { - dt_dprintk("irq %u not connected to primary controller. Connected to %s\n", - i, dt_node_full_name(rirq.controller)); - continue; - } - - res = platform_get_irq(dev, i); - if ( res < 0 ) - { - printk(XENLOG_ERR "Unable to get irq %u for %s\n", - i, dt_node_full_name(dev)); - return res; - } - - res = map_irq_to_domain(d, res, need_mapping, dt_node_name(dev)); - if ( res ) - return res; - } - - return 0; -} - /* * For a given device node: * - Give permission to the guest to manage IRQ and MMIO range diff --git a/xen/arch/arm/include/asm/domain_build.h b/xen/arch/arm/include/asm/domain_build.h index 34ceddc995..b9329c9ee0 100644 --- a/xen/arch/arm/include/asm/domain_build.h +++ b/xen/arch/arm/include/asm/domain_build.h @@ -4,8 +4,6 @@ #include #include -int map_irq_to_domain(struct domain *d, unsigned int irq, - bool need_mapping, const char *devname); int make_chosen_node(const struct kernel_info *kinfo); void evtchn_allocate(struct domain *d); diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 38e2ce255f..40a30c78b7 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -165,9 +165,15 @@ void device_tree_get_reg(const __be32 **cell, u32 address_cells, u32 device_tree_get_u32(const void *fdt, int node, const char *prop_name, u32 dflt); +int handle_device_interrupts(struct domain *d, struct dt_device_node *dev, + bool need_mapping); + int map_range_to_domain(const struct dt_device_node *dev, u64 addr, u64 len, void *data); +int map_irq_to_domain(struct domain *d, unsigned int irq, + bool need_mapping, const char *devname); + extern DEFINE_BOOT_PAGE_TABLE(boot_pgtable); #ifdef CONFIG_ARM_64 diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index 6c9712ab7b..5f7ae45304 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -1811,12 +1811,12 @@ int dt_count_phandle_with_args(const struct dt_device_node *np, * @allnextpp: pointer to ->allnext from last allocated device_node * @fpsize: Size of the node path up at the current depth. */ -static unsigned long __init unflatten_dt_node(const void *fdt, - unsigned long mem, - unsigned long *p, - struct dt_device_node *dad, - struct dt_device_node ***allnextpp, - unsigned long fpsize) +static unsigned long unflatten_dt_node(const void *fdt, + unsigned long mem, + unsigned long *p, + struct dt_device_node *dad, + struct dt_device_node ***allnextpp, + unsigned long fpsize) { struct dt_device_node *np; struct dt_property *pp, **prev_pp = NULL; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue May 02 23:37:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 23:37:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528855.822525 (Exim 4.92) (envelope-from ) id 1ptzYn-0005Th-U9; Tue, 02 May 2023 23:37:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528855.822525; Tue, 02 May 2023 23:37:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzYn-0005Ta-QX; Tue, 02 May 2023 23:37:29 +0000 Received: by outflank-mailman (input) for mailman id 528855; Tue, 02 May 2023 23:37:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzYm-0005Si-Oc for xen-devel@lists.xenproject.org; Tue, 02 May 2023 23:37:28 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on20623.outbound.protection.outlook.com [2a01:111:f400:7e88::623]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4ba8dd56-e942-11ed-8611-37d641c3527e; Wed, 03 May 2023 01:37:26 +0200 (CEST) Received: from BN9PR03CA0740.namprd03.prod.outlook.com (2603:10b6:408:110::25) by MN0PR12MB6128.namprd12.prod.outlook.com (2603:10b6:208:3c4::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Tue, 2 May 2023 23:37:22 +0000 Received: from BN8NAM11FT063.eop-nam11.prod.protection.outlook.com (2603:10b6:408:110:cafe::cb) by BN9PR03CA0740.outlook.office365.com (2603:10b6:408:110::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31 via Frontend Transport; Tue, 2 May 2023 23:37:22 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT063.mail.protection.outlook.com (10.13.177.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.22 via Frontend Transport; Tue, 2 May 2023 23:37:22 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 2 May 2023 18:37:22 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 2 May 2023 18:37:21 -0500 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 2 May 2023 18:37:21 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4ba8dd56-e942-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QTtkvu0gTNoHijYkh0caIcnZNMVLdlec5IVV1/GIiTyjW8HTmKScMudSqSiA3htV1cZ8vvhz5Bp/iZxudHo6+QUlCAtUcKThf+SRQ50LgjN9tHlngZkudxvpRTONEh2X3jrIQ7j0XDW1jl44qpHXArcZOmLeQibWvf31pSHUv/3Jiov4FyS8ANGHpCEQ16Ebhp3dmYOCLLU3oSD/5GM2sHD9RM0YdolPfIPFvsv5spS352CyEZZBn0DTy/bewuV3hojwbfrFIuT31bYRiCcbai+i86Qs9LrNF5edALt1qcC4S5osQ/yQ3mYm9BwHeuQzP/8yg1iio7VIktsgVQ8pxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qGBrlYz1MYPx3dVlqExLGnD1JoxqWVU0WGIisylldqw=; b=JGM+vcyC9zcVJ2lePJixNlxjB8OaBGl9kNpIMLOyiWdAyyaFllsWoph8OQu0PUe+WBjm7p5F9YKGVaP3cUkvauBksR2KigrhusO5wEBshJnBuHjtluCBEoW9hm8cgySyGsYiL3VoemRRJ6hSBwbGPxdwMQGh3ZbLsYlXYbIvQ80PiYAL9Ew0KohhuJm5SrL5K3d95bUblb9tydvbEWK3QYC/4R5oG2xOM4CmS58xTI0Rij8YK+/F2Q5JQeZ/kNHRDSOoG/LFQOfloIeFMAjvGBUnSSh8I7BAz7TRS6jIkI1Xv0WuvvQn+tSVfnwWCxj0CN6qgNbSQZpgzWP9jkqn0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qGBrlYz1MYPx3dVlqExLGnD1JoxqWVU0WGIisylldqw=; b=b0/gi+WxhUSiSWWIvLFFkAUwRqFGs3UEBrAFs07LH6hZ84oI6vK6hqW6holvwjIV3jQiHwobuv5R+dQHHoiqCYsvctQ+e/lOYTIdtXWan8YNF8dBsqGE6UYT4oybDw0v6AyDLHnktDOldilktGJ/5AV4TN9e95H/qWVqiFBbALo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , , , Julien Grall Subject: [XEN][PATCH v6 03/19] common/device_tree: change __unflatten_device_tree() type Date: Tue, 2 May 2023 16:36:34 -0700 Message-ID: <20230502233650.20121-4-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230502233650.20121-1-vikram.garhwal@amd.com> References: <20230502233650.20121-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT063:EE_|MN0PR12MB6128:EE_ X-MS-Office365-Filtering-Correlation-Id: 29ae46b7-ee61-4327-35bc-08db4b662d8a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TXciANatIM6/IA9AvojUj9UdWhHKXAjDMGdyeU7y3PB48zQRGYNcagqGIB4G/9pZwjBlr3rKRIB1gvc91DXmfFM/EKpywHX2cc4ldJKyO0WqRdKA1NeVp3RGih4E0Z4auQW29j56ew7JUrTl9LUcmJ+nYoM+V9ULgs6Inyh+Etrm8LLl6Qf/odhshXhPaXXq/L7rZmYz63BSG4HpzeV6clkINLNS3yKBzM/ueQ7YmFvDpLcCMWskCYFXxui12nhmw0urmd4HC3mPMDiWIcigy4idQRczIg9IOq4adYscUamiqrKLVbLEqWkL0UqK3+DKOn56XuSXtrLXuOircKZyjI9Je3gFadHOORoJE/4Jc74qMiK4x+1RoUoHeMV90AKRmbm6yis3hnW8/3zekqawupqsB1wG4KoFW6TQErDNFg82moRqoNZP/NR0hu8QJg6bVDHke/zXNNb6FIYWb3HWAGXlgk1UtOAfs2LgQm7y38qrHh29DZpdwrOKjqhIwfNHStb2q/7ycAHlUnm/4FLUK3sHTvzm5H4Jln/fNq9Pfcad/fF1C6sLNZr759GFEmm17lTzVU4dgHKAizHd8zr0ceqavN6CnDuITP5a+KQUpq6tZqDfhjaoymXCru5MnOyahS7RJaaJBvbrNjt1uFqM8BEuxbHqRrg+f2ZpBZYJCLkmtQwinAqxUpU1ZOH9ZvZ+g22HYi9fqk9I77DriJ/oHFnSw/MgvXuDfu6zLSCAncw= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(376002)(39860400002)(346002)(451199021)(40470700004)(46966006)(36840700001)(41300700001)(8936002)(44832011)(8676002)(5660300002)(86362001)(36860700001)(47076005)(83380400001)(81166007)(82740400003)(356005)(2616005)(426003)(316002)(26005)(40480700001)(478600001)(36756003)(336012)(54906003)(70586007)(4326008)(6666004)(6916009)(70206006)(40460700003)(2906002)(1076003)(186003)(82310400005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 23:37:22.5368 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 29ae46b7-ee61-4327-35bc-08db4b662d8a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT063.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6128 Following changes are done to __unflatten_device_tree(): 1. __unflatten_device_tree() is renamed to unflatten_device_tree(). 2. Remove __init and static function type. Signed-off-by: Vikram Garhwal --- xen/common/device_tree.c | 9 ++++----- xen/include/xen/device_tree.h | 5 +++++ 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index fc38a0b3dd..5daf5197bd 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -2047,7 +2047,7 @@ static unsigned long unflatten_dt_node(const void *fdt, } /** - * __unflatten_device_tree - create tree of device_nodes from flat blob + * unflatten_device_tree - create tree of device_nodes from flat blob * * unflattens a device-tree, creating the * tree of struct device_node. It also fills the "name" and "type" @@ -2056,8 +2056,7 @@ static unsigned long unflatten_dt_node(const void *fdt, * @fdt: The fdt to expand * @mynodes: The device_node tree created by the call */ -static int __init __unflatten_device_tree(const void *fdt, - struct dt_device_node **mynodes) +int unflatten_device_tree(const void *fdt, struct dt_device_node **mynodes) { unsigned long start, mem, size; struct dt_device_node **allnextp = mynodes; @@ -2183,9 +2182,9 @@ dt_find_interrupt_controller(const struct dt_device_match *matches) void __init dt_unflatten_host_device_tree(void) { - int error = __unflatten_device_tree(device_tree_flattened, &dt_host); + int error = unflatten_device_tree(device_tree_flattened, &dt_host); if ( error ) - panic("__unflatten_device_tree failed with error %d\n", error); + panic("unflatten_device_tree failed with error %d\n", error); dt_alias_scan(); } diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index 19a74909ce..eef0335b79 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -178,6 +178,11 @@ int device_tree_for_each_node(const void *fdt, int node, */ void dt_unflatten_host_device_tree(void); +/** + * unflatten any device tree. + */ +int unflatten_device_tree(const void *fdt, struct dt_device_node **mynodes); + /** * IRQ translation callback * TODO: For the moment we assume that we only have ONE -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue May 02 23:37:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 23:37:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528856.822535 (Exim 4.92) (envelope-from ) id 1ptzYp-0005kw-5L; Tue, 02 May 2023 23:37:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528856.822535; Tue, 02 May 2023 23:37:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzYp-0005kp-2Q; Tue, 02 May 2023 23:37:31 +0000 Received: by outflank-mailman (input) for mailman id 528856; Tue, 02 May 2023 23:37:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzYn-0004sC-M7 for xen-devel@lists.xenproject.org; Tue, 02 May 2023 23:37:29 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2061b.outbound.protection.outlook.com [2a01:111:f400:fe59::61b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4c196cac-e942-11ed-b225-6b7b168915f2; Wed, 03 May 2023 01:37:28 +0200 (CEST) Received: from DS7P222CA0004.NAMP222.PROD.OUTLOOK.COM (2603:10b6:8:2e::14) by DS0PR12MB8455.namprd12.prod.outlook.com (2603:10b6:8:158::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Tue, 2 May 2023 23:37:22 +0000 Received: from DM6NAM11FT102.eop-nam11.prod.protection.outlook.com (2603:10b6:8:2e:cafe::b0) by DS7P222CA0004.outlook.office365.com (2603:10b6:8:2e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31 via Frontend Transport; Tue, 2 May 2023 23:37:22 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT102.mail.protection.outlook.com (10.13.173.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.21 via Frontend Transport; Tue, 2 May 2023 23:37:22 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 2 May 2023 18:37:17 -0500 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 2 May 2023 18:37:16 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c196cac-e942-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U+Jo3aZ/KXfCpID5n2MqwuEg+k/PJWPStk/V7ThEjUdZSxD2n071o+4GiDyi7VQShAVY17IRY7Ygfy2XcBUTIEmJs0AUzAi+Fnktq7MGgARIkko7gEphpqHdWdZ7OE5/VhUK5LRMpnQThG34+rszzv/22fhLnNqzN/+7Pzldq0Muno6B553aa2LvDjmv+IBqyBfCl1PXWMUSqtZY3aOdnS+XotN2TdwdmXXCQ2A+k+3iQcdjgBfnmrm5B4A8n5GKu4s9i6HkjlKMgjDyfb/Jtd6wB+TFceuEhm7elEcPXrJS+G9ICJovNLTohBfS4myaVSYHLTJGDl1hj6QSAnh5jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vzddX9TV10ndAd/6iE6kCNK/WBOdnTL0B9KxpRRHgRI=; b=j3fsZJ9IS3+TAhj6342U+O5MPJm3D1bTxoachuuFo/r8ed1CYRt4rNRKAn9gD9n0krpTmCoebLydEExor4KfOcxoANBbt3fUieHqEAKR1t0CTUoqzdF80prbHe7a1Txqvz1yGL5JOBlgNKdtAlH1JdFggaU8Fdj3KgGz/OF6ulbE6PMMgPqiVGLQWlcYGv/zOj/KKcwimlVJL+oerHgfQ6rFa5k2ghnpXwHbkoZ80NmtxpJBKJIl2oICsPg0FtlN2TFxS2wgA9bbwe8KB50uqY4ZjyWMxxYOO7DPeZyurt/2WWGFzVwL5Maw0kDemxiYUKBl+FwoL7De839WZvrX1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vzddX9TV10ndAd/6iE6kCNK/WBOdnTL0B9KxpRRHgRI=; b=zTMm0RzZVvXES+Lc4cafDnZ6fs6J9ghbOAfPJXcrA7fJUAzCobmGtkkaJqH7E2PgoOoihXEnWr+Kh1+BdT7ujmx1hBYb36qg6bhudH5Rk1JZlgBk0IhPz7cJpjqEfzLOA4+xylCoZRhU1X/smL9grrElU3tAmjUoQCPgiexGxic= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Vikram Garhwal To: CC: , , , Julien Grall Subject: [XEN][PATCH v6 02/19] common/device_tree: handle memory allocation failure in __unflatten_device_tree() Date: Tue, 2 May 2023 16:36:33 -0700 Message-ID: <20230502233650.20121-3-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230502233650.20121-1-vikram.garhwal@amd.com> References: <20230502233650.20121-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT102:EE_|DS0PR12MB8455:EE_ X-MS-Office365-Filtering-Correlation-Id: 00c59c3d-252e-446b-6218-08db4b662d61 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bXZpaaDpLqpx3roIliDKqmF4bmnR5HXhmhZVM2NqaPcDVBz31GEC/P2lYHnGwskM3ttHDDta60GqtlFtTIBtKvOWiU5BFy3nB0+4yngPumQS6bNottUnxA+rZkIBx4GUOjkWuFzuDkFaapJG8Cha2wE1Rs1l3NZ3Kwl+GD8NAWwjLVK7dExeGwbJww/zmNuRW/1DpZ6S53DTOyWWbEx0cyMxkuD+2GsmLp8U3mvihdVWbrcOCMJJvgBxnqGSPy1eF8+hKrTvyitW9TuJGXIDA0cN83Q8aqbfa+NyW6Q2nzp/5iP7wMe3v5ofIgM+Lvhkkeq7FOAaTObKqS9xEV4GOmF3wDpBT3T19HYOFii1fJcAoxb8lXIgVxrGO982BogbCI3DdjJD2iPUU+Upywx3hAwhcDPcQwmf87l7UJQ3aFkfHQndWb0hw1pNQNvbwBNgAtwUqdDmFPSpzQNnPVhDUpZSNI0sehU2LBu7WKz+a1eUokDVs1L4nVcU5Er1bR03dOcV2gpt6yn4DWC4cJEVjPHb36XXbAdJoQw41qZyl2jteQx9cX3Btr4AiNOIsU7ZKp74sqW4Ns9H7kpvZCG/ZIV/ogC9rEekq7qZesxjsGau3cT+2b/aoImpD/5EKH7t7rLX+WUzX9q3mwdz3udItMPeHZjy5ekkdMXaQSKMeGhGrOPq845wG/bn+LwGKLPWnduD3troODuoJ0ZZDrZTtHtGBYO+Fxg3RikM9XX1iuU= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(396003)(39860400002)(346002)(136003)(451199021)(40470700004)(46966006)(36840700001)(82310400005)(83380400001)(47076005)(36860700001)(2616005)(40480700001)(41300700001)(40460700003)(81166007)(356005)(36756003)(70206006)(70586007)(82740400003)(6916009)(316002)(4326008)(186003)(478600001)(1076003)(86362001)(336012)(426003)(54906003)(26005)(5660300002)(8936002)(8676002)(44832011)(2906002)(6666004)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 23:37:22.2380 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 00c59c3d-252e-446b-6218-08db4b662d61 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT102.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8455 Change __unflatten_device_tree() return type to integer so it can propagate memory allocation failure. Add panic() in dt_unflatten_host_device_tree() for memory allocation failure during boot. Signed-off-by: Vikram Garhwal --- xen/common/device_tree.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index 5f7ae45304..fc38a0b3dd 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -2056,8 +2056,8 @@ static unsigned long unflatten_dt_node(const void *fdt, * @fdt: The fdt to expand * @mynodes: The device_node tree created by the call */ -static void __init __unflatten_device_tree(const void *fdt, - struct dt_device_node **mynodes) +static int __init __unflatten_device_tree(const void *fdt, + struct dt_device_node **mynodes) { unsigned long start, mem, size; struct dt_device_node **allnextp = mynodes; @@ -2078,6 +2078,8 @@ static void __init __unflatten_device_tree(const void *fdt, /* Allocate memory for the expanded device tree */ mem = (unsigned long)_xmalloc (size + 4, __alignof__(struct dt_device_node)); + if ( !mem ) + return -ENOMEM; ((__be32 *)mem)[size / 4] = cpu_to_be32(0xdeadbeef); @@ -2095,6 +2097,8 @@ static void __init __unflatten_device_tree(const void *fdt, *allnextp = NULL; dt_dprintk(" <- unflatten_device_tree()\n"); + + return 0; } static void dt_alias_add(struct dt_alias_prop *ap, @@ -2179,7 +2183,10 @@ dt_find_interrupt_controller(const struct dt_device_match *matches) void __init dt_unflatten_host_device_tree(void) { - __unflatten_device_tree(device_tree_flattened, &dt_host); + int error = __unflatten_device_tree(device_tree_flattened, &dt_host); + if ( error ) + panic("__unflatten_device_tree failed with error %d\n", error); + dt_alias_scan(); } -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue May 02 23:37:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 23:37:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528857.822545 (Exim 4.92) (envelope-from ) id 1ptzYr-000649-G0; Tue, 02 May 2023 23:37:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528857.822545; Tue, 02 May 2023 23:37:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzYr-000640-C4; Tue, 02 May 2023 23:37:33 +0000 Received: by outflank-mailman (input) for mailman id 528857; Tue, 02 May 2023 23:37:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzYq-0004sC-9f for xen-devel@lists.xenproject.org; Tue, 02 May 2023 23:37:32 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2061f.outbound.protection.outlook.com [2a01:111:f400:fe5a::61f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4ea29618-e942-11ed-b225-6b7b168915f2; Wed, 03 May 2023 01:37:31 +0200 (CEST) Received: from DS7P222CA0025.NAMP222.PROD.OUTLOOK.COM (2603:10b6:8:2e::31) by MN2PR12MB4344.namprd12.prod.outlook.com (2603:10b6:208:26e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 23:37:28 +0000 Received: from DM6NAM11FT102.eop-nam11.prod.protection.outlook.com (2603:10b6:8:2e:cafe::f8) by DS7P222CA0025.outlook.office365.com (2603:10b6:8:2e::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31 via Frontend Transport; Tue, 2 May 2023 23:37:27 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT102.mail.protection.outlook.com (10.13.173.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.21 via Frontend Transport; Tue, 2 May 2023 23:37:27 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 2 May 2023 18:37:24 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 2 May 2023 18:37:24 -0500 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 2 May 2023 18:37:24 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4ea29618-e942-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ya559k3ytzE58QL3KyvkDHWlCou/EpLMtnHz+AfDNesZbJBVQrHCVd9O/X2sfYs05nR0ZAZjqOqgqkRLwnTBn8PpcVmbtU0aopomIApedhGmB/llatC44tqLNBQcHF2dCqtBKIa8XLArx4gGhnW2qK1RbrGhIGqwPHPmb1s2YNb7D9543ZkB9Zlt+sZJv6s+rdx8Wy87BkrDiJD5I7XsjPtr+Vf9b5F8Q+mFGoFu9ICQkq24m3mQrsWcygnqvnH9icSZR8tERgym2WX49BiGJ8FGcasSlWzdsiSdzlJYWPE/lC+KElJ5/0v8NktQghL2FkC3kM2ZyQKZFZYSCqQ5Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Rjb1ox/OK8Kv1DTBbQ9Lbk0Z1Hvt88hsPr+KDuGNW5w=; b=Hz+rdkM/wfTd9fxqtd5x1iefsXZ5mWlTJ5i6ondLuEz2ceyHntIcRRSyW2xPHYCNdoO/FphYeMbP+AZcZoJtHp6s9p4jlAWFXTA3fEcpAXjpfvsf5BTEopY8T35mBYsXyruxraWInqxT8jGrWsrSKsWMfA2SKolXZxiEem64KeSU6hGDMIgXP7f3SEEHOnqi2kq9OOcemoTSZZwNjQGWja1kPKIZaa4d2oav8TC96FZr/MuJG7i68c+62fGEoqhrxj5BnLWdRKyWcpqQeS6ptJtAcZNIInrEI9BYFv6vVal2PGQBwa25PVZ2uW/OHC73Khk//DWjUug+5c1c9n8LhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Rjb1ox/OK8Kv1DTBbQ9Lbk0Z1Hvt88hsPr+KDuGNW5w=; b=ZvkjLJX73yjR4ZHX+wK0pLnIZu3fH6j8wQsc5N42hg8/AmY1r3cFKaB1XlyFRKWL+Oi8LCuu1F0BHRwFcZyTdtns+Lqx4vw1oHrJNhx1kzwEP9wL+1EW0XjNuy1D+bOoh5xsTiu9vgbC7Ov8cG0SeIJ776NQu1jZ1i9n7KM5wkU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Vikram Garhwal To: CC: , , , Julien Grall Subject: [XEN][PATCH v6 04/19] common/device_tree.c: unflatten_device_tree() propagate errors Date: Tue, 2 May 2023 16:36:35 -0700 Message-ID: <20230502233650.20121-5-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230502233650.20121-1-vikram.garhwal@amd.com> References: <20230502233650.20121-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT102:EE_|MN2PR12MB4344:EE_ X-MS-Office365-Filtering-Correlation-Id: 65cd3dcb-bc7d-4e88-029a-08db4b6630be X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /5YqEmdxPxt4isXUmi0aJJ8EK8xbb5p6mWWsxsKih3OJ7jlhYqr0NqHve5493P80TN1pNTDEc1DFblP0Ouzpycrjd+LxkKTEBzbvEtnMN3e0b7KRPMzUypiUo1vK+QbjbHQu8UHfGQM8NKRkzonnvO3DNpIbFFS0Q2vHARa5V8/28bunJXzQWBvd0hF7eHvL5qYHtwBHQfv7GHoTO60+FXPdw52gIbEgSQ6WIYdZzi3QBYV84eZnztPFccpZmoSzu8WlFMg5urAVsfzVEi7cxT7bY58p1ZVfa7j6fvM2TGV5srEiFU+CMjpOgP3oaYNhY5ljK2uilqsJ1IfqqCs0/oahIy8D4bleeMBMspvgbdk2z1x6kn2GVB6SsMRMLa27qzSivp/hx+g851UudOrtAONbpdmXccibs5dRHZnWoC/CDpCTjZKkGwfTnD+X+4XvOTwdvAst1hLtvNA1W5WpR2DkM9VUt9berrNsbMgKu9qnSpfqY8I97Gb0Xpj3RRSyqBF6YGAzlB/81X6dmsZMol/XnQFpbI8Jl3Fpnr+5vAqguHj/viIo1z0gLEXKMpq727MJbJ+7EhcG6ho3W2NDCLaxLfE+2p7vfy+crx/n8ecnpGU0IE3rHw7ZZTiXI6OQo6rd2/cGv6nJyIlL/R65zS1oXPtnok9SYBCJGIQdHge/pqel7XfAsGb4Wy2Wu00lpiWlZigbAN71hL/xve1Ga5PRwfYWRocifoMJu88U9Mc= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(376002)(396003)(346002)(451199021)(36840700001)(40470700004)(46966006)(6916009)(70586007)(70206006)(356005)(82740400003)(316002)(4326008)(40460700003)(478600001)(82310400005)(54906003)(36756003)(86362001)(186003)(6666004)(40480700001)(1076003)(26005)(36860700001)(5660300002)(2616005)(44832011)(83380400001)(336012)(426003)(8676002)(8936002)(41300700001)(81166007)(2906002)(47076005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 23:37:27.8782 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 65cd3dcb-bc7d-4e88-029a-08db4b6630be X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT102.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4344 This will be useful in dynamic node programming when new dt nodes are unflatten during runtime. Invalid device tree node related errors should be propagated back to the caller. Signed-off-by: Vikram Garhwal --- xen/common/device_tree.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index 5daf5197bd..47ab2f7940 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -2071,6 +2071,9 @@ int unflatten_device_tree(const void *fdt, struct dt_device_node **mynodes) /* First pass, scan for size */ start = ((unsigned long)fdt) + fdt_off_dt_struct(fdt); size = unflatten_dt_node(fdt, 0, &start, NULL, NULL, 0); + if ( !size ) + return -EINVAL; + size = (size | 3) + 1; dt_dprintk(" size is %#lx allocating...\n", size); @@ -2088,11 +2091,19 @@ int unflatten_device_tree(const void *fdt, struct dt_device_node **mynodes) start = ((unsigned long)fdt) + fdt_off_dt_struct(fdt); unflatten_dt_node(fdt, mem, &start, NULL, &allnextp, 0); if ( be32_to_cpup((__be32 *)start) != FDT_END ) - printk(XENLOG_WARNING "Weird tag at end of tree: %08x\n", + { + printk(XENLOG_ERR "Weird tag at end of tree: %08x\n", *((u32 *)start)); + return -EINVAL; + } + if ( be32_to_cpu(((__be32 *)mem)[size / 4]) != 0xdeadbeef ) - printk(XENLOG_WARNING "End of tree marker overwritten: %08x\n", + { + printk(XENLOG_ERR "End of tree marker overwritten: %08x\n", be32_to_cpu(((__be32 *)mem)[size / 4])); + return -EINVAL; + } + *allnextp = NULL; dt_dprintk(" <- unflatten_device_tree()\n"); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue May 02 23:37:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 23:37:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528858.822555 (Exim 4.92) (envelope-from ) id 1ptzYs-0006LD-PZ; Tue, 02 May 2023 23:37:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528858.822555; Tue, 02 May 2023 23:37:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzYs-0006Ky-LR; Tue, 02 May 2023 23:37:34 +0000 Received: by outflank-mailman (input) for mailman id 528858; Tue, 02 May 2023 23:37:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzYr-0004sC-JC for xen-devel@lists.xenproject.org; Tue, 02 May 2023 23:37:33 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on20620.outbound.protection.outlook.com [2a01:111:f400:7e88::620]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4f841d83-e942-11ed-b225-6b7b168915f2; Wed, 03 May 2023 01:37:33 +0200 (CEST) Received: from BN1PR13CA0006.namprd13.prod.outlook.com (2603:10b6:408:e2::11) by CH3PR12MB8912.namprd12.prod.outlook.com (2603:10b6:610:169::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 23:37:30 +0000 Received: from BN8NAM11FT082.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e2:cafe::88) by BN1PR13CA0006.outlook.office365.com (2603:10b6:408:e2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.21 via Frontend Transport; Tue, 2 May 2023 23:37:30 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT082.mail.protection.outlook.com (10.13.176.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.21 via Frontend Transport; Tue, 2 May 2023 23:37:29 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 2 May 2023 18:37:29 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 2 May 2023 18:37:29 -0500 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 2 May 2023 18:37:28 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f841d83-e942-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nQNz5wxnSNHnhF3KsOCS17kfx8SR59b60S+M5rwJS51BB1LlF0e/zbfWbGKAvYUcj3Z6z71tfqp5eKHSE2Q0GuIagR0mTV0KKC9kZXojsXWBZmrKHYjAF5T7YxFddVDBHAPJLNWzJwQz/dL4PsEsLmMBojxcWIwJ5o14t1u8A8X6hNV4Jpy12FrCvfuenKv+BhuCwcVSbnVIQczWNeToQGmsH8VE1N00pU20sz3UIsAe95jOk+MAbaThqojZpzkds5FYpdVm0mhKNmP+2tJbacWdQf7Zxd2O4LKFW8bHU359DPkmwdq8zZR8ua3y1I3daiV+2mu1ydlVQBFlFqtiQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F0j3i9rO3ndTIMxTYPP/EpeTJUoU0W3bKZrIDhMYirk=; b=LCeMEu8LY7CJcnfW8lVkHrH/Ly9iygD+qYDlGweTDAA7kM4ySyjwLH+W9aLoQ+oysRBimROfg6KAkuTQ6RvetUthIweLOoudGaEnWDlrJ4bb5RFx4R6fOqMVuED4bAGXqN43a0rw9M43c+7bZwCEXTrTM3dx/bF3EiXSBkvcmz/iS2+b6tpr92NaxdcsmZOonL+MGoyXM0tRp76bXvrl3XLyV8IpUzUM5nf24B3uj306m6D78+CkXngZXr8sCUlsNn+Vm10+dQcgO4VxLcHyAvuMqZESXsfdMBWY7wxPI4SCO54UkfyP4ujPMV+tZLXlxAh5ng5/x50ID1wez7LuLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F0j3i9rO3ndTIMxTYPP/EpeTJUoU0W3bKZrIDhMYirk=; b=wZTm6IKZpqV9BPjt1HFwSMztoYc3VJ1K4NeX2B44LSc0Pqg2I4PClc2ux4dc8Pj+qw/Z7mh3paiX1io9MRxHhFBAoDe5EsIIKPJbT/ZsqQIm2J1yvNKb3kFBCFJduuqlbhQi8s/icZ4jUGexyCSh1RxGGTiWlWx6cF6FvywDrsY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , , , Andrew Cooper , "George Dunlap" , Jan Beulich , "Julien Grall" , Wei Liu , Bertrand Marquis , Volodymyr Babchuk Subject: [XEN][PATCH v6 05/19] xen/arm: Add CONFIG_OVERLAY_DTB Date: Tue, 2 May 2023 16:36:36 -0700 Message-ID: <20230502233650.20121-6-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230502233650.20121-1-vikram.garhwal@amd.com> References: <20230502233650.20121-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT082:EE_|CH3PR12MB8912:EE_ X-MS-Office365-Filtering-Correlation-Id: eb644b4e-1f72-4a36-9496-08db4b6631d5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: q7+45602Cr5J7QTaF4ra4FlnfGcVG8zk1+745qMSwgbfzEVWLF1xQNil9Tqpm3jwx99qVNPL71p0iQbUa5/q/alOz9PcI4EzygwQfSRiu2GJk30LShG5kwd0iYvPhPyhutNObrLdQGlSOsnbMEtJZz6FR8X2MWovIPJAZdqUKR+9zYLFyFG4mqGdX5xno1z8yuuaY03D6fQTV7/vszAjI3gyB7ZmJCbW/wYBwbdo+QqSZQneNk5z19FF76HMQzgGG3Jd6JIdtDQhhAcrGw79CgH1gYLkEGHZQRwDJWCjGRateAjHJA0CGVCuNnqNCbsEucFAMf5wZgpspGzpJpsZE6YT4mTBWHj7Eemw8XMYy1ABP5yhlThIUiZd2RCbSwuo9hU4k1dOyEn6y3yx8oAtx4DnRpIrBm5D7x52FoSkihBdDcjZT0q94j2aGtZzaKQGNLZnuU0dM3/Ex2vT7kk7CS2ynsl7t32LBWZ750KFipGUQjGvGpB3WN81oSQxkD5hM501ZVOOmQd2v8A7zg42kjaVq2YXT4P3sBffjYviceUPmU+Ubx4XoY2THoHy7x7/zSQOpdp8Stt4M546mdAQ2hl71xipILnm4h+MYwzkP5H8JHOLwpTgYYXUC4xYY9Sp/XPq5VIDco8dTfq0qBHd2QZ8PzrsL262ARghEZC+b2tqkUK23W2O76fl3JpfJ78OYRT90l+d3gTIZVOu9QZEO1jfAbB1JMAseLJlusMpTu8= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(136003)(39860400002)(346002)(451199021)(46966006)(36840700001)(40470700004)(81166007)(8676002)(8936002)(40480700001)(86362001)(4326008)(82310400005)(478600001)(6916009)(6666004)(316002)(36756003)(41300700001)(70586007)(70206006)(356005)(82740400003)(40460700003)(5660300002)(426003)(336012)(2616005)(54906003)(26005)(186003)(47076005)(1076003)(2906002)(44832011)(36860700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 23:37:29.7416 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eb644b4e-1f72-4a36-9496-08db4b6631d5 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT082.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8912 Introduce a config option where the user can enable support for adding/removing device tree nodes using a device tree binary overlay. Signed-off-by: Vikram Garhwal --- SUPPORT.md | 6 ++++++ xen/arch/arm/Kconfig | 5 +++++ 2 files changed, 11 insertions(+) diff --git a/SUPPORT.md b/SUPPORT.md index aa1940e55f..e40ec4fba2 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -822,6 +822,12 @@ No support for QEMU backends in a 16K or 64K domain. Status: Supported +### Device Tree Overlays + +Add/Remove device tree nodes using a device tree overlay binary(.dtbo). + + Status, ARM: Experimental + ### ARM: Guest ACPI support Status: Supported diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 239d3aed3c..1fe3d698a5 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -53,6 +53,11 @@ config HAS_ITS bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPORTED depends on GICV3 && !NEW_VGIC && !ARM_32 +config OVERLAY_DTB + bool "DTB overlay support (UNSUPPORTED)" if UNSUPPORTED + help + Dynamic addition/removal of Xen device tree nodes using a dtbo. + config HVM def_bool y -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue May 02 23:37:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 23:37:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528860.822565 (Exim 4.92) (envelope-from ) id 1ptzYx-0006oD-8c; Tue, 02 May 2023 23:37:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528860.822565; Tue, 02 May 2023 23:37:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzYx-0006o0-4X; Tue, 02 May 2023 23:37:39 +0000 Received: by outflank-mailman (input) for mailman id 528860; Tue, 02 May 2023 23:37:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzYw-0005Si-AY for xen-devel@lists.xenproject.org; Tue, 02 May 2023 23:37:38 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on20613.outbound.protection.outlook.com [2a01:111:f400:fe5a::613]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5111dbf2-e942-11ed-8611-37d641c3527e; Wed, 03 May 2023 01:37:36 +0200 (CEST) Received: from BN9PR03CA0347.namprd03.prod.outlook.com (2603:10b6:408:f6::22) by SJ2PR12MB8651.namprd12.prod.outlook.com (2603:10b6:a03:541::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 23:37:33 +0000 Received: from BN8NAM11FT047.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f6:cafe::85) by BN9PR03CA0347.outlook.office365.com (2603:10b6:408:f6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31 via Frontend Transport; Tue, 2 May 2023 23:37:32 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT047.mail.protection.outlook.com (10.13.177.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.21 via Frontend Transport; Tue, 2 May 2023 23:37:32 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 2 May 2023 18:37:32 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 2 May 2023 16:37:31 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 2 May 2023 18:37:31 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5111dbf2-e942-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dOI3UsBnZi4ADCLNm0yqO8Y/wzh7xghvMpxvyh3MCnsrMZ8Ky7vfl8I+QHrtUg9oCKhturO0n71UZq2frso6yCbXO1lWnREJAYVt+K5dOFXLXE5Olsb5IMzkIZbHWa4MJRTAV1GZoRMPaHHKWNzes1ypE64DR/i3jQ7gjrJcY5nzybAv+sIyq4F4Gqzt1+Ia6DGDpCyQU+Q8oRhQCLv2jb1/xM40c4lntw2shxo6bJlhiOlUKnpXAEmzWOylVL/xqM3BeIbNvIFNoE8fhlxRNvUidpIhPLZddZ5El8GMvLYMreJAs2P8m0paW0cAu204rYjZjQuoXmbvhbnrSu3N2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+aOH8wbfxJ3CDB9n8z4otIPVVDXaY3ZnHxlpPeTlbO8=; b=InGULvt9rlpPWnhP/U/d5fplmSZzkHYKMu7e+WH2tT9AS3c2hL4Dq3egm/4Z1H6DbsJtozSV2+sMFUDHG+33u0THnv4iIJVSczrpgY7e3MUmOsFhuQBs/MDiZvNH+3/RlhpkperW81txoUf/SMeypvyc5tJXtDjhrU2IGucn82LaDOlTpcxtjHoWTMfuYvIJ4OtfcwpEzsyzQv90HuMBoX8PoJZRs2HNYWh1rfhNP3fJv8X9NhchbS6Ctf/JC2J4JXW//d8MP4HgK8OFaxqOe1xA4O+hTnUlmYkBgD/92aHxU79MjgtMLGdwThRLqZ4mUcz1diJP9pAQpI1IcTvd3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+aOH8wbfxJ3CDB9n8z4otIPVVDXaY3ZnHxlpPeTlbO8=; b=28l3iP1mztYxC9ocTLWhJFHIYBjUtI9s7/WBjkQRkkotPrsiTA6R7IZFB8xnjitJVFkqe3/nV5tWzqSh9baKAqazvjCRpAUdxikLGeiUVEJxydzVVZQ4Ew6+wB2PkpqX0uMkY52eQTctpOyzPUjNnkHRb5BI9Ex4esR615JLTX8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , , , Julien Grall Subject: [XEN][PATCH v6 06/19] libfdt: Keep fdt functions after init for CONFIG_OVERLAY_DTB. Date: Tue, 2 May 2023 16:36:37 -0700 Message-ID: <20230502233650.20121-7-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230502233650.20121-1-vikram.garhwal@amd.com> References: <20230502233650.20121-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT047:EE_|SJ2PR12MB8651:EE_ X-MS-Office365-Filtering-Correlation-Id: 12a6975c-c9e3-4350-bdb8-08db4b663375 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EUY32wrrKmUTKyUR8ekT4xiIwr4sbHJVwToDFSGra4BowHtWKoGqIm5p0h6+Qgth+w3gYRYkrKSsfkbvbxKCERjp1e3zRcwEUn7dOU6eYzEBTq7eB7qBPsZwwY25G1YOvy1WuzHlJwnMppbWlmNUVgUwx5LffnAlc89+C8zf5L08ZBorO02pWjexrbqKDRb72CVPYQyariwLzAnJ77dqPILNvtjP21+ADxDE3Z4a07oVMMKyNHzEEcvxSejnQSk25BDNpeLDRhtGgUTljhCgK5xtsllZke95HvqWZdZ5MkUp0w2QrCCKZ9DWlQ07QGGTu+p4wDjVkeRqpQZjtKiliOqcVXedzSi3XwtZsovNCpCrf48k6I5qQNYoYd+PzRyxvvgDWnfAloiTEqCy8MeQcdCyvyfCaGHFAotjM+QWH/B9v0I/bm1IqAWPOMJ5rYA5hRlgDaSyWIJdlzF5GT4b9RPoA1rn43Ls86U6VvzRBhAHoxlpyKFepKIp2ujp+rl4ODmOlUkNX3NT7xD5/BSn2D6qOhiWyR5ROyK8lQ8L6qH9mo1zPnxrOYsuxtd23yqBgqBFJxXcbbt8fWt0dDCU4P5VVeTks4mE05PDqIykKjB55SBT87i2U45dDrN443QULEJ3HL/8wcCFb/02ahhUWVsgWyih0V45Q/95FC/pbPNUqxtX8kAMfV8XuXij+uJfW5ozf9i6kSqajqkauDzcL66ZN0hDofsHjnXnzafeWXI= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(136003)(39860400002)(376002)(451199021)(46966006)(40470700004)(36840700001)(40460700003)(1076003)(26005)(82740400003)(36756003)(2616005)(41300700001)(82310400005)(4326008)(6916009)(36860700001)(336012)(426003)(316002)(478600001)(47076005)(70586007)(70206006)(86362001)(83380400001)(356005)(4744005)(186003)(40480700001)(81166007)(54906003)(44832011)(2906002)(5660300002)(8936002)(8676002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 23:37:32.4690 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 12a6975c-c9e3-4350-bdb8-08db4b663375 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT047.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8651 This is done to access fdt library function which are required for adding device tree overlay nodes for dynamic programming of nodes. Signed-off-by: Vikram Garhwal Acked-by: Julien Grall --- xen/common/libfdt/Makefile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/xen/common/libfdt/Makefile b/xen/common/libfdt/Makefile index 75aaefa2e3..d50487aa6e 100644 --- a/xen/common/libfdt/Makefile +++ b/xen/common/libfdt/Makefile @@ -1,7 +1,11 @@ include $(src)/Makefile.libfdt SECTIONS := text data $(SPECIAL_DATA_SECTIONS) + +# For CONFIG_OVERLAY_DTB, libfdt functionalities will be needed during runtime. +ifneq ($(CONFIG_OVERLAY_DTB),y) OBJCOPYFLAGS := $(foreach s,$(SECTIONS),--rename-section .$(s)=.init.$(s)) +endif obj-y += libfdt.o nocov-y += libfdt.o -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue May 02 23:37:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 23:37:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528862.822574 (Exim 4.92) (envelope-from ) id 1ptzYz-00079J-G4; Tue, 02 May 2023 23:37:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528862.822574; Tue, 02 May 2023 23:37:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzYz-00078z-Cp; Tue, 02 May 2023 23:37:41 +0000 Received: by outflank-mailman (input) for mailman id 528862; Tue, 02 May 2023 23:37:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzYy-0004sC-BZ for xen-devel@lists.xenproject.org; Tue, 02 May 2023 23:37:40 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on20622.outbound.protection.outlook.com [2a01:111:f400:7e88::622]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 52edf28a-e942-11ed-b225-6b7b168915f2; Wed, 03 May 2023 01:37:39 +0200 (CEST) Received: from BN9PR03CA0346.namprd03.prod.outlook.com (2603:10b6:408:f6::21) by SA0PR12MB4591.namprd12.prod.outlook.com (2603:10b6:806:9d::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Tue, 2 May 2023 23:37:37 +0000 Received: from BN8NAM11FT047.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f6:cafe::97) by BN9PR03CA0346.outlook.office365.com (2603:10b6:408:f6::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31 via Frontend Transport; Tue, 2 May 2023 23:37:36 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT047.mail.protection.outlook.com (10.13.177.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.21 via Frontend Transport; Tue, 2 May 2023 23:37:36 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 2 May 2023 18:37:34 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 2 May 2023 16:37:34 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 2 May 2023 18:37:33 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52edf28a-e942-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oU0ePOBiG+WFuk03h0aJuvgatXHo+HtslAsPF8/SjrUbRNz8GXcE6/2YtKyf2A3WNBqM/by7vOzfKMQPzzDyeXALfUbt7/SeNc4I3gJAEiWCEVZ5eOKWK9oviDcLb0JSPdTN0yse3ah6rZMytRmMZhM6PaQtXJg/fszsXPDNQmLVN/OUtJWZyjTKPHoEfSo+i87cYeYVhnDW9R0dupPBdcbaYxu1X5xBCG1Lsmbo6YU/j/rTWYzIdHKNkaoyBmembCoYu2+LKlVCwUnOCY7UoYKNFj2xydv8oaQQSC512dihHORCxXyXCFSngN0q5bM75KMH67vUboctcWB0vEepxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A7a8SO//tZf8dnpDvLiol5y8mZo4siOv2JmDmv476O8=; b=VqaAMbUA8W+NWm2MXFVLuvfkaddrdbCs+sVauAxPeDyqqEHIRgL7MJ8bhyh/EEQPXoyNCU3kX2TvQKvx25tQjvMUQnNDBXpx22lvHABtkG/Wvk+Md/sWQTU7Vl+3dqdo7A/wN60WgtkcPw8W3jjzteyRTl+tR0R4r2+MMjiYruO5hdJLH7xlWYh569bXNu01MTUaZUy7Gp1tAmOHNgtra0doncKwGbvqufaZ/qjaewJeeNZzO9vZrjZdAVukKILS8jVlNiZWJKnTSrZtS/x4HiqtKHxmUVBfxFhlt2xH3+Gt9RgbKt5uUZCcjvJdv/Wv/Ep0kg0KWjvwcZAyWKkgkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A7a8SO//tZf8dnpDvLiol5y8mZo4siOv2JmDmv476O8=; b=Y//I1YxSxs07Ke9XfwSAHsAWj3cIR16fafxzouwyg7k7PxSVdnm/R327CwyfLaFnMIwvGCTaQ5iaEwIhXnlPPsD5xCnQ76ZtuXM3DbJ4ruYvVuu4W2dDGBJpceuYQM6u0e6v5lpEAhlJ/vxyg9E7eLcFNVACK57GfkN7yPy3fU0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , , , Julien Grall , Jan Beulich , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [XEN][PATCH v6 09/19] xen/iommu: Move spin_lock from iommu_dt_device_is_assigned to caller Date: Tue, 2 May 2023 16:36:40 -0700 Message-ID: <20230502233650.20121-10-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230502233650.20121-1-vikram.garhwal@amd.com> References: <20230502233650.20121-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT047:EE_|SA0PR12MB4591:EE_ X-MS-Office365-Filtering-Correlation-Id: 86cb0c46-2d1f-4b3b-d4d2-08db4b6635fb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: r57mn/8nqbzEuAz8S7ebrddM+Jxdwf2cJa/mk60QqgcX+ghGXqbDvH7/hBVwN65/HxegsidKm5aDS+lpeVGcb6F9Z0cJreUAUojCavL7rczSVca3BYtsQKK7ixCyalADViBc2aMjyLILeoA/TINRadND2fd1Hp77IMkkffNScPof4TttK6FiH0/mOospzN8mam1RCAUC9pdeRSQ1+AClmYzPWdQ72O4e+nffDx75VM0yUtL2XwW43Bz6A5olRP5fwDBRTBDE38wAs4iekfeix2VYzysm0RzggOJ7ZVxjLSQ4xDrU7vZAwj4o7hmp2EgPIV7koe5E21v+WsVzT0XpkSqI8ctgGPd822o2osF20PxaeBNug8p2Qdpr8BF7uPcJyXLwUdf/0BFjez4VyanZzn0du8D2iMiBhPdkdQnfNnH6baW2EzFVZx2w4gPGivf73B3MWCYHLyuNticlldp/cHx/aCKI36ldyK8/kTYFZ53DiD1CJi5HVuJc36P1bXMXmBmp/hiDlMFhu72uYkKCpiQ/g8VHXilp5Wdf9AewmIH5Y05OdLhm2038GIe6ImZWMUOso9jrlKSn4eR9EE5yGjp/RnnwEsHL+AfUNYHLzQWLKsYHe7ou3VMroIqwcLj0Yp25sQIlwdZFJqCfZT3Y6fuTyl14bBEysGXBPKJVaGrTEZB+CZkx7mvJb5ZmkLbYlRvz7+J5R+c9gZ3DdRcieIACPBOdFVPtxtbecppjMpE= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(136003)(39860400002)(376002)(451199021)(46966006)(36840700001)(40470700004)(47076005)(40460700003)(2616005)(426003)(186003)(336012)(40480700001)(36756003)(86362001)(82310400005)(356005)(81166007)(82740400003)(83380400001)(36860700001)(8936002)(6666004)(8676002)(316002)(41300700001)(44832011)(5660300002)(54906003)(478600001)(4326008)(6916009)(70206006)(70586007)(26005)(1076003)(2906002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 23:37:36.7188 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 86cb0c46-2d1f-4b3b-d4d2-08db4b6635fb X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT047.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4591 Rename iommu_dt_device_is_assigned() to iommu_dt_device_is_assigned_locked(). Remove static type so this can also be used by SMMU drivers to check if the device is being used before removing. Moving spin_lock to caller was done to prevent the concurrent access to iommu_dt_device_is_assigned while doing add/remove/assign/deassign. Signed-off-by: Vikram Garhwal Reviewed-by: Luca Fancellu --- xen/drivers/passthrough/device_tree.c | 19 +++++++++++++++---- xen/include/xen/iommu.h | 1 + 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/xen/drivers/passthrough/device_tree.c b/xen/drivers/passthrough/device_tree.c index 1c32d7b50c..c386fda3e4 100644 --- a/xen/drivers/passthrough/device_tree.c +++ b/xen/drivers/passthrough/device_tree.c @@ -83,16 +83,14 @@ fail: return rc; } -static bool_t iommu_dt_device_is_assigned(const struct dt_device_node *dev) +bool_t iommu_dt_device_is_assigned_locked(const struct dt_device_node *dev) { bool_t assigned = 0; if ( !dt_device_is_protected(dev) ) return 0; - spin_lock(&dtdevs_lock); assigned = !list_empty(&dev->domain_list); - spin_unlock(&dtdevs_lock); return assigned; } @@ -213,27 +211,40 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, struct domain *d, if ( (d && d->is_dying) || domctl->u.assign_device.flags ) break; + spin_lock(&dtdevs_lock); + ret = dt_find_node_by_gpath(domctl->u.assign_device.u.dt.path, domctl->u.assign_device.u.dt.size, &dev); if ( ret ) + { + spin_unlock(&dtdevs_lock); break; + } ret = xsm_assign_dtdevice(XSM_HOOK, d, dt_node_full_name(dev)); if ( ret ) + { + spin_unlock(&dtdevs_lock); break; + } if ( domctl->cmd == XEN_DOMCTL_test_assign_device ) { - if ( iommu_dt_device_is_assigned(dev) ) + + if ( iommu_dt_device_is_assigned_locked(dev) ) { printk(XENLOG_G_ERR "%s already assigned.\n", dt_node_full_name(dev)); ret = -EINVAL; } + + spin_unlock(&dtdevs_lock); break; } + spin_unlock(&dtdevs_lock); + if ( d == dom_io ) return -EINVAL; diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h index 405db59971..76add226ec 100644 --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -214,6 +214,7 @@ struct msi_msg; #include int iommu_assign_dt_device(struct domain *d, struct dt_device_node *dev); +bool_t iommu_dt_device_is_assigned_locked(const struct dt_device_node *dev); int iommu_deassign_dt_device(struct domain *d, struct dt_device_node *dev); int iommu_dt_domain_init(struct domain *d); int iommu_release_dt_devices(struct domain *d); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue May 02 23:37:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 23:37:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528863.822585 (Exim 4.92) (envelope-from ) id 1ptzZ0-0007SI-Sd; Tue, 02 May 2023 23:37:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528863.822585; Tue, 02 May 2023 23:37:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzZ0-0007Rn-Kt; Tue, 02 May 2023 23:37:42 +0000 Received: by outflank-mailman (input) for mailman id 528863; Tue, 02 May 2023 23:37:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzYz-0005Si-Hf for xen-devel@lists.xenproject.org; Tue, 02 May 2023 23:37:41 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2060f.outbound.protection.outlook.com [2a01:111:f400:7e88::60f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 53775b0b-e942-11ed-8611-37d641c3527e; Wed, 03 May 2023 01:37:39 +0200 (CEST) Received: from BN9PR03CA0343.namprd03.prod.outlook.com (2603:10b6:408:f6::18) by CH2PR12MB4103.namprd12.prod.outlook.com (2603:10b6:610:7e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 23:37:36 +0000 Received: from BN8NAM11FT047.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f6:cafe::43) by BN9PR03CA0343.outlook.office365.com (2603:10b6:408:f6::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.32 via Frontend Transport; Tue, 2 May 2023 23:37:36 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT047.mail.protection.outlook.com (10.13.177.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.21 via Frontend Transport; Tue, 2 May 2023 23:37:36 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 2 May 2023 18:37:33 -0500 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 2 May 2023 18:37:33 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 53775b0b-e942-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OcuBEpgBv91+CABaEHG+sQ13V2oVko2y7E2qN/5olSnow6SkQ+e+yyDAb836RN70VOUGaV90hYDVSa27niA4ayCVwQoOt02mfu+k4kEobVnj9G2oyeYg/7SpbE/FJ5nqCgNCrElGFrFGstapy/Hv1E2S3FS0PpfNaoX20JkYDudfKiuAQbmrDTeCQ0GFXgD3MVLrFnve3e30AYtjM6fvwTLUqjUjJGgPmLSnke0u+Xl5tJpKoaVfxSNHu2oNXvU6cptQAwbf/bwzAqKNYs9bSCJVF7u3gUVCJWXl4W7SU+Hb8I1YQH0S/+347z2LPlTVkeTIee4hqjLCxgr4JjxWAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LptqMUkxHVxrSuaM+i6CgX8fqOqrHiX3/jew+F/gQRs=; b=P5m/nNPtt7VhJ+pgTHeLyfND9vt7eBABWqquZOefh7SK/CVMMtlusCr/PoLJj58WB0KuvT8srAFToGBx7q0WdFPWDilN/rM1EU/BDpEWNF4aYEmXWWXV0ISbMXVTdFoR4kyK7F2U9MPSL1EaFDrQevS9emZT2ed3u1HNE5adJvI6Eg1p6elajde6wJTDH2V0wFBDfACLY70kdeUAxDjss0ykfQKxB7b6PkAhzifjgpq8uPz2DxLOBszkPLL9tnf5I7vzkkC0YmxWvTxbm3T5wirzdnq2VzXslrAXuKKVC0G1jmgLrCrLPdtHXcxefFjeph5C13/vY7UNiVhFcRCyvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LptqMUkxHVxrSuaM+i6CgX8fqOqrHiX3/jew+F/gQRs=; b=w2IDg1FiVeNBJgY/xOdKhF9kBqNjIivZ1AzFnDhj95o/f++ewR0Mga7GrIvkOIlNU+lo2HVVGRrgAHMnMu5MATjB5JpJl0r9kgOSoB2NsdNcz4S5AKOKazjoFCaOsPgssVMlkhvz1LmlCf47gfcJvXLyWfV94QjW9+lVL0yfoLs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , , , Julien Grall Subject: [XEN][PATCH v6 08/19] xen/device-tree: Add device_tree_find_node_by_path() to find nodes in device tree Date: Tue, 2 May 2023 16:36:39 -0700 Message-ID: <20230502233650.20121-9-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230502233650.20121-1-vikram.garhwal@amd.com> References: <20230502233650.20121-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT047:EE_|CH2PR12MB4103:EE_ X-MS-Office365-Filtering-Correlation-Id: ac7d9bfb-95f8-4823-ffc0-08db4b6635c4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tnVNrl+EWQRdKhMY7bSFdykTa7BAPjsgesGWpRYzgt3des1TrY6lbV8bTx/RSGE/6bFXXXz3mzRE6kQf+3X2bk5oJnkQRcc7WBBEsrjJxBzR8GUwoN6pgR+S77tDxhBkhbg1Y9pIQEA7Olycq75K+X8MIBVhghJCbdsgsEUulzmI0RhNPr2ZPy18El+vNcYMg9//H7gOWxsFdVlI8ykTjbT/GZNhcEwiNYkE/3ctwXj9LpYUeC50SmZtMayqvbRQz+0iLywP6Gpc3tYTWEQXR4DebiSh0iOMxDPfgSGy3/kmLCLkSiFnQHCSeVlBniI853HZ+/GcIceOU9rXq0EFvYO8nRf2rjlgmZ+TX48Eo9VjFMfihoiPKrtk4Jw/FVX3lUCVMWWwxlHqncYWfA3IBFGOp+LmQMZVJaDXpHQG48p3YPuNZByepSTyp7oFTeEfPlyVPpoyE2Htxd9K8PGPqNNfDqcOm3ulPFH8sFGR73SX+gSS6c0kcd46rvWcncxcVxh174TD2RaGzLpSZ5GJsTsFNrgU7FE2geHXrxs6z5p1S65mYDBasXV2UaoAdWMQ8eLxcu3rVmTD+MEGTYkmg7kaAsVd5RvPXNKvek4fGhqx8uvUc7q8WzX6A0tzAinnYwPNsjvR740o9gjRGJkRT7bZ1xcqEOVx6hciulPNN1kEwjCTJGltj12IrExAQWTy9Q2ZPobgGPsnspKEyjCRqfDLlEc8jrLDm1rqOUwOIy6pZav127Epdm4y4Yvw3p701bFIJu94gKtPWtmgoVcFlA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(376002)(346002)(136003)(451199021)(36840700001)(40470700004)(46966006)(81166007)(41300700001)(356005)(5660300002)(8936002)(8676002)(70206006)(70586007)(316002)(82740400003)(2906002)(86362001)(40480700001)(40460700003)(44832011)(6916009)(1076003)(26005)(186003)(4326008)(336012)(83380400001)(36860700001)(426003)(47076005)(36756003)(82310400005)(2616005)(54906003)(478600001)(37363002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 23:37:36.3595 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ac7d9bfb-95f8-4823-ffc0-08db4b6635c4 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT047.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4103 Add device_tree_find_node_by_path() to find a matching node with path for a dt_device_node. Reason behind this function: Each time overlay nodes are added using .dtbo, a new fdt(memcpy of device_tree_flattened) is created and updated with overlay nodes. This updated fdt is further unflattened to a dt_host_new. Next, we need to find the overlay nodes in dt_host_new, find the overlay node's parent in dt_host and add the nodes as child under their parent in the dt_host. Thus we need this function to search for node in different unflattened device trees. Also, make dt_find_node_by_path() static inline. Signed-off-by: Vikram Garhwal --- xen/common/device_tree.c | 5 +++-- xen/include/xen/device_tree.h | 17 +++++++++++++++-- 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index 47ab2f7940..426a809f42 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -358,11 +358,12 @@ struct dt_device_node *dt_find_node_by_type(struct dt_device_node *from, return np; } -struct dt_device_node *dt_find_node_by_path(const char *path) +struct dt_device_node *device_tree_find_node_by_path(struct dt_device_node *dt, + const char *path) { struct dt_device_node *np; - dt_for_each_device_node(dt_host, np) + dt_for_each_device_node(dt, np) if ( np->full_name && (dt_node_cmp(np->full_name, path) == 0) ) break; diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index eef0335b79..d6366d3dac 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -534,13 +534,26 @@ struct dt_device_node *dt_find_node_by_type(struct dt_device_node *from, struct dt_device_node *dt_find_node_by_alias(const char *alias); /** - * dt_find_node_by_path - Find a node matching a full DT path + * device_tree_find_node_by_path - Generic function to find a node matching the + * full DT path for any given unflatten device tree + * @dt_node: The device tree to search * @path: The full path to match * * Returns a node pointer. */ -struct dt_device_node *dt_find_node_by_path(const char *path); +struct dt_device_node *device_tree_find_node_by_path(struct dt_device_node *dt, + const char *path); +/** + * dt_find_node_by_path - Find a node matching a full DT path in dt_host + * @path: The full path to match + * + * Returns a node pointer. + */ +static inline struct dt_device_node *dt_find_node_by_path(const char *path) +{ + return device_tree_find_node_by_path(dt_host, path); +} /** * dt_find_node_by_gpath - Same as dt_find_node_by_path but retrieve the -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue May 02 23:37:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 23:37:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528864.822590 (Exim 4.92) (envelope-from ) id 1ptzZ1-0007Yx-CL; Tue, 02 May 2023 23:37:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528864.822590; Tue, 02 May 2023 23:37:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzZ1-0007Wg-5y; Tue, 02 May 2023 23:37:43 +0000 Received: by outflank-mailman (input) for mailman id 528864; Tue, 02 May 2023 23:37:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzYz-0004sC-Se for xen-devel@lists.xenproject.org; Tue, 02 May 2023 23:37:41 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on20600.outbound.protection.outlook.com [2a01:111:f400:fe59::600]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 53a655d4-e942-11ed-b225-6b7b168915f2; Wed, 03 May 2023 01:37:41 +0200 (CEST) Received: from BN9PR03CA0358.namprd03.prod.outlook.com (2603:10b6:408:f6::33) by PH7PR12MB8180.namprd12.prod.outlook.com (2603:10b6:510:2b6::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.28; Tue, 2 May 2023 23:37:38 +0000 Received: from BN8NAM11FT047.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f6:cafe::ae) by BN9PR03CA0358.outlook.office365.com (2603:10b6:408:f6::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31 via Frontend Transport; Tue, 2 May 2023 23:37:38 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT047.mail.protection.outlook.com (10.13.177.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.21 via Frontend Transport; Tue, 2 May 2023 23:37:38 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 2 May 2023 18:37:36 -0500 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 2 May 2023 18:37:36 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 53a655d4-e942-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VMuhiR7OjqK98R6C2Y+i2BwUPlmh/NGw2J8UYvPW8dKGxBa1iV1j5v33lhksmAVKe8fslgYp/p8OyGG+xz6Yr1br6oRqS0Rz0txYazHtUOD3ENh0pOiA/yDPtHWUDAxT7OftAIsG2ievhkgIQippqVQLEZAyw0TONxPYxx5dhumzJUrnPc8mXShxNWcUGBp07e/cxB+hH4Wn7z7+89ipGslY+3JEqTGd5NZbhw+pfEUEdSQbG+ECynalrKb3jBZJbH6kWsKdCQsfTePuf4YAURIh4hT1om4sjnbmzd9krWT5Vowk9s/jFQJqpKnvqgsBtq+LsKKsTsMr2fv5j2Ir0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o//kziDFlVk7rDkLuyZCz6gXGJUkyhMLecqyMP3X36E=; b=j8RnKyNane9AlUt12z+CtWCP8pOZJ9vwNhFsxN7qgdNLCaOXJqeW5/nstSsVhdlOdS2zpo9RJXTId1o+lgEA6ubGR0qWqV1zxbj6rqkju6O9IWxYmRaWHqIy4uBg+MTBWM3oZ383FjVz1K+kpQCezutbY8mrCbAvdSmXk205liAE5ejIgOHkfzMQk4IIfSICMGnGQpzwhjUopVSdr47z6VNVZmSn3ceddCp20aT/mh6hIS9Oad6BT/m2wrH1msLYYLzy1bmVFZ8U61GkSJ7yWEsZiOfAjB0rGJTiusxx0v3UYqnMd9WWb2wWMghl6/2BxWA8qOYIHKlwEPYgLPd4dA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o//kziDFlVk7rDkLuyZCz6gXGJUkyhMLecqyMP3X36E=; b=K4bFgZs7i4fiQhliTFJ3687gVb/NFX5VZnNbJDYqIW9oAIuSE3IMOJ2I+uhNXIlwU2L3tqpyVuXWv2EaH04PzPmADLC3xQ4laizDvvSdI6KWscP5sqSJy6huRLe+/sYVY0xti30U20nWlkJrdkgcfxaMe8iMNeaLbx39WJb6YJE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , , , Julien Grall , Rahul Singh , Bertrand Marquis , "Volodymyr Babchuk" Subject: [XEN][PATCH v6 12/19] xen/smmu: Add remove_device callback for smmu_iommu ops Date: Tue, 2 May 2023 16:36:43 -0700 Message-ID: <20230502233650.20121-13-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230502233650.20121-1-vikram.garhwal@amd.com> References: <20230502233650.20121-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT047:EE_|PH7PR12MB8180:EE_ X-MS-Office365-Filtering-Correlation-Id: 1a718bd1-80da-4de4-b416-08db4b6636c1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NiE6EW8yQhtuk8zLuQOPtsucZA/jm2YfnWqSL444s42WCtwp71ub9OatR2Zk4hEGxH4OiRqh+3BZj9X+/rjfKeubFY/6ciKhQ+1pvi2nyqzdIutUKkIeP5cCziAw1FLWaYZ/5BjtcBdZSMvrGqR+phs+kNQOtnSKM79X8lo+JvdRDsHR5pUBVWELT6C4qLbQj1eP6egOYuThDxG+2aBRWEXWDKel8IV/u+5AfT/ms6OGA0SJd+UEevJoae7OfTnCLkew/JMFZb+7udFcrwlg9sK8S9e3ejXkUBVJ0ANwZjNCzxNQgcmf8LmXHl181MER0Ltc1IIVfHwjut0Ab70W9sSeiFhG58DPmMYnTNEw4QU1kL+9b4MO0pivJgu5RKwWvYJ6vqwjZ1FaPsdVu83bnneVzMsnaLAT7cLGL58Xr9fjMYa9k/+v39LL0LNfGEVhr3QuE9GxBW9zqLFUI0NW33kDXfzlyytuBwJc8X//GWC7s82JEtLWz85zM7/h8YmNqWWRfuVNoxtzfrwLKEhXyQYiCrZn/iOMyPSPAPqSy20XRFmBI3YFoAp2hXPY9b1RVzgACY6Ay5jFdkebh/9l2pJlzKkVR7tG0vdDHxiiBu/+Dgfcd6x2SunGKnGV1QgKPU5xBiuPhY0rEQycKJWWbxvz8XKG03oDxR315qg+C9zAAPokCoHbTOEO24NCu8DfDyo3nmkHoe4R3UVJdaW52lMat4Htl1aQu8T0/HPqF7c= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(136003)(396003)(346002)(451199021)(40470700004)(36840700001)(46966006)(2906002)(478600001)(47076005)(70586007)(70206006)(40480700001)(8936002)(8676002)(83380400001)(5660300002)(44832011)(426003)(336012)(41300700001)(356005)(81166007)(54906003)(82740400003)(4326008)(316002)(6916009)(2616005)(40460700003)(36860700001)(6666004)(86362001)(36756003)(186003)(82310400005)(1076003)(26005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 23:37:38.0156 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1a718bd1-80da-4de4-b416-08db4b6636c1 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT047.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8180 Add remove_device callback for removing the device entry from smmu-master using following steps: 1. Find if SMMU master exists for the device node. 2. Check if device is currently in use. 3. Remove the SMMU master. Signed-off-by: Vikram Garhwal Reviewed-by: Luca Fancellu Reviewed-by: Michal Orzel --- xen/drivers/passthrough/arm/smmu.c | 58 ++++++++++++++++++++++++++++++ 1 file changed, 58 insertions(+) diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c index 0a514821b3..39d3a5c345 100644 --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -816,6 +816,19 @@ static int insert_smmu_master(struct arm_smmu_device *smmu, return 0; } +static int remove_smmu_master(struct arm_smmu_device *smmu, + struct arm_smmu_master *master) +{ + if (!smmu->masters.rb_node) { + ASSERT_UNREACHABLE(); + return -ENOENT; + } + + rb_erase(&master->node, &smmu->masters); + + return 0; +} + static int arm_smmu_dt_add_device_legacy(struct arm_smmu_device *smmu, struct device *dev, struct iommu_fwspec *fwspec) @@ -853,6 +866,34 @@ static int arm_smmu_dt_add_device_legacy(struct arm_smmu_device *smmu, return insert_smmu_master(smmu, master); } +static int arm_smmu_dt_remove_device_legacy(struct arm_smmu_device *smmu, + struct device *dev) +{ + struct arm_smmu_master *master; + struct device_node *dev_node = dev_get_dev_node(dev); + int ret; + + master = find_smmu_master(smmu, dev_node); + if (master == NULL) { + dev_err(dev, + "No registrations found for master device %s\n", + dev_node->name); + return -EINVAL; + } + + if (iommu_dt_device_is_assigned_locked(dev_to_dt(dev))) + return -EBUSY; + + ret = remove_smmu_master(smmu, master); + if (ret) + return ret; + + dev_node->is_protected = false; + + kfree(master); + return 0; +} + static int register_smmu_master(struct arm_smmu_device *smmu, struct device *dev, struct of_phandle_args *masterspec) @@ -876,6 +917,22 @@ static int register_smmu_master(struct arm_smmu_device *smmu, fwspec); } +static int arm_smmu_dt_remove_device_generic(u8 devfn, struct device *dev) +{ + struct arm_smmu_device *smmu; + struct iommu_fwspec *fwspec; + + fwspec = dev_iommu_fwspec_get(dev); + if (fwspec == NULL) + return -ENXIO; + + smmu = find_smmu(fwspec->iommu_dev); + if (smmu == NULL) + return -ENXIO; + + return arm_smmu_dt_remove_device_legacy(smmu, dev); +} + static int arm_smmu_dt_add_device_generic(u8 devfn, struct device *dev) { struct arm_smmu_device *smmu; @@ -2858,6 +2915,7 @@ static const struct iommu_ops arm_smmu_iommu_ops = { .init = arm_smmu_iommu_domain_init, .hwdom_init = arch_iommu_hwdom_init, .add_device = arm_smmu_dt_add_device_generic, + .remove_device = arm_smmu_dt_remove_device_generic, .teardown = arm_smmu_iommu_domain_teardown, .iotlb_flush = arm_smmu_iotlb_flush, .assign_device = arm_smmu_assign_dev, -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue May 02 23:37:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 23:37:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528865.822597 (Exim 4.92) (envelope-from ) id 1ptzZ2-0007i9-24; Tue, 02 May 2023 23:37:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528865.822597; Tue, 02 May 2023 23:37:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzZ1-0007h6-MS; Tue, 02 May 2023 23:37:43 +0000 Received: by outflank-mailman (input) for mailman id 528865; Tue, 02 May 2023 23:37:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzZ0-0004sC-C1 for xen-devel@lists.xenproject.org; Tue, 02 May 2023 23:37:42 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2060e.outbound.protection.outlook.com [2a01:111:f400:7e89::60e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 547f4a68-e942-11ed-b225-6b7b168915f2; Wed, 03 May 2023 01:37:41 +0200 (CEST) Received: from DS7PR03CA0208.namprd03.prod.outlook.com (2603:10b6:5:3b6::33) by DM4PR12MB5071.namprd12.prod.outlook.com (2603:10b6:5:38a::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 23:37:36 +0000 Received: from DM6NAM11FT068.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b6:cafe::99) by DS7PR03CA0208.outlook.office365.com (2603:10b6:5:3b6::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.32 via Frontend Transport; Tue, 2 May 2023 23:37:36 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT068.mail.protection.outlook.com (10.13.173.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.21 via Frontend Transport; Tue, 2 May 2023 23:37:36 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 2 May 2023 18:37:32 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 2 May 2023 16:37:32 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 2 May 2023 18:37:32 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 547f4a68-e942-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SrS7MKU7griNkYaA1QkcHvAz1NT8Pcu0D5BbYbnr/ayE3Ag2TZjEAUJeykBeDaXsA5VusHzafAfq9VJXw3ttMv2CFBiLSJ0z5I7f0vh1BFv9GDdfZpWFzPGSek133i900JsoaYci0E48xxOkP1vEnh4P2N2QEPWI/SFxduijnXRENOkau8cBF9ZrbApazqiLabACxtapl0C+j5BfSa67NWNL3LN84UAQ48hNyQbfigittrGm++/NF3A4fSh5sEQ+UolZsEPgxCkZTwtpDnnCgPWkuAffKFSCQhmPtjtCZztWuem8sZTmwvJvEYaL4Eyb66/3gcL2XV1GjUdCUzQhRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Izi8iFk0zRF4BRyNOjdDxCvThsPDcczKcmdhMhR/3Sk=; b=KwdI1Z2YIxKavOXDxN7d/J7eEfXh5WYQDKccFRFeEFXolQusimheCwFSdn/y7h3MTVrREeYn2U3ccn+o4HiGQGONPtDZI6ZmYrBYkS7i2z9EuhY32wnsQ+G+QvsEVfvdNKRZx9D3ZHx7c1FgN4Q+9EQieG2qGsQh6FDuUDTBHOlTplJBB7qE8QZ4khYu9Hj1yRAKSj+sf5WFHUitLLhsn7sWoaOWlLahHCnTiDj03VcwJxJ0WA0RJpstYXxRSTwvmM7TaqhTB3C2oh29RKc1dspvpZxorovjxYTwUGWOkIFs8a1SaeZcpwCNdZnbigNbsHvaX7jxLv70qGCwGoqb7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Izi8iFk0zRF4BRyNOjdDxCvThsPDcczKcmdhMhR/3Sk=; b=VuNvzciNWJ4Lx0/rMEBLsVGEvfM3eIhHYxvb38q6fUaQhmahn2jrDfK13eOT4zO6kuHGYo2lPTbE7BXQUoePeXmsaxTwV8kiZL/Z/DO0z0UHp++qYoBWDSmBDt5+3mUR876gzcBMLQaWKvZ6KAQLrZ8tKHedZ0VE5wcw/d43Z0Q= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Vikram Garhwal To: CC: , , , Julien Grall , Vikram Garhwal , David Gibson Subject: [XEN][PATCH v6 07/19] libfdt: overlay: change overlay_get_target() Date: Tue, 2 May 2023 16:36:38 -0700 Message-ID: <20230502233650.20121-8-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230502233650.20121-1-vikram.garhwal@amd.com> References: <20230502233650.20121-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT068:EE_|DM4PR12MB5071:EE_ X-MS-Office365-Filtering-Correlation-Id: f6d2c9fa-7007-410d-69ba-08db4b6635a2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eVMJI7TaxrFA/V7rVr0NqyN0WoPsJmJvpK7gnokNKWc6GU6g0vqSn53EQn8c3sZR+4IlT+SZXnzwOdMGL8hBC27wg9fxzUer8ui8dimykTIZ39M61mFWDrIOkU3MaSYs08NbJBF78SvnQ3Rl/04M5ZQbnm50kYVM+xuuysOjHSwg7ADDjZAFOKudF2RLo345dH7lylPcFnBHCKhj8areY+Awtd+W04IxWTRr5VWlON1qYjC+IwzZbe96lxO/By9yFLCrFaOBIr5a28yf+R8w2Wa9BxsO/v9QrzTRYmuDORLX0yFSPNCG6rnLRUHdJTO2S7cN6vobJXqW7qHGuEAgOo6vVEIQV2Za+BzFLAGFEjWOGfJTiGTf8pVefihRFj7KWqxpVtycFmywKfjkJDdePu2d/vCZ0nuqC0/ogh6BxUZ2YXenwusJuHyul7Mb/PUMGFgOvz1kjU90KxxHT3NPC/l4kpEmmcO/nDaZ8HevIC071FtUTX8DvlZp7LOOLSFhIiSAcXWJWHBsmw3inYsPkoA7DPVySm699o/TNOrps57+iASgLNDV6HnGxdCodGHRL6gtJP8wJRzVbK1k2YNYhvzhlKlO4AXbfPmzYTVUstKBm+eXr9sF5kCCF+0cLWKtJd8dFYTvmWS8R0LCEUzYbHfeL8a8/2xO+eoJGsghtKUwk849j0WhKaQxucynE+dIkj3Z8JtIlmgoMFzrw/rp2rTWFGUIwdP+W+4XR+Qkzqg= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(346002)(39860400002)(376002)(451199021)(36840700001)(40470700004)(46966006)(26005)(1076003)(40460700003)(316002)(2906002)(70586007)(8936002)(70206006)(6916009)(5660300002)(86362001)(4326008)(8676002)(44832011)(356005)(81166007)(82740400003)(41300700001)(82310400005)(40480700001)(186003)(478600001)(47076005)(36860700001)(2616005)(336012)(426003)(54906003)(36756003)(83380400001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 23:37:36.0859 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f6d2c9fa-7007-410d-69ba-08db4b6635a2 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT068.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5071 Rename overlay_get_target() to fdt_overlay_target_offset() and remove static function type. This is done to get the target path for the overlay nodes which is very useful in many cases. For example, Xen hypervisor needs it when applying overlays because Xen needs to do further processing of the overlay nodes, e.g. mapping of resources(IRQs and IOMMUs) to other VMs, creation of SMMU pagetables, etc. Signed-off-by: Vikram Garhwal Message-Id: <1637204036-382159-2-git-send-email-fnu.vikram@xilinx.com> Signed-off-by: David Gibson Origin: git://git.kernel.org/pub/scm/utils/dtc/dtc.git 45f3d1a095dd Signed-off-by: Vikram Garhwal Reviewed-by: Michal Orzel --- xen/common/libfdt/fdt_overlay.c | 29 +++++++---------------------- xen/common/libfdt/version.lds | 1 + xen/include/xen/libfdt/libfdt.h | 18 ++++++++++++++++++ 3 files changed, 26 insertions(+), 22 deletions(-) diff --git a/xen/common/libfdt/fdt_overlay.c b/xen/common/libfdt/fdt_overlay.c index 7b95e2b639..acf0c4c2a6 100644 --- a/xen/common/libfdt/fdt_overlay.c +++ b/xen/common/libfdt/fdt_overlay.c @@ -41,37 +41,22 @@ static uint32_t overlay_get_target_phandle(const void *fdto, int fragment) return fdt32_to_cpu(*val); } -/** - * overlay_get_target - retrieves the offset of a fragment's target - * @fdt: Base device tree blob - * @fdto: Device tree overlay blob - * @fragment: node offset of the fragment in the overlay - * @pathp: pointer which receives the path of the target (or NULL) - * - * overlay_get_target() retrieves the target offset in the base - * device tree of a fragment, no matter how the actual targeting is - * done (through a phandle or a path) - * - * returns: - * the targeted node offset in the base device tree - * Negative error code on error - */ -static int overlay_get_target(const void *fdt, const void *fdto, - int fragment, char const **pathp) +int fdt_overlay_target_offset(const void *fdt, const void *fdto, + int fragment_offset, char const **pathp) { uint32_t phandle; const char *path = NULL; int path_len = 0, ret; /* Try first to do a phandle based lookup */ - phandle = overlay_get_target_phandle(fdto, fragment); + phandle = overlay_get_target_phandle(fdto, fragment_offset); if (phandle == (uint32_t)-1) return -FDT_ERR_BADPHANDLE; /* no phandle, try path */ if (!phandle) { /* And then a path based lookup */ - path = fdt_getprop(fdto, fragment, "target-path", &path_len); + path = fdt_getprop(fdto, fragment_offset, "target-path", &path_len); if (path) ret = fdt_path_offset(fdt, path); else @@ -638,7 +623,7 @@ static int overlay_merge(void *fdt, void *fdto) if (overlay < 0) return overlay; - target = overlay_get_target(fdt, fdto, fragment, NULL); + target = fdt_overlay_target_offset(fdt, fdto, fragment, NULL); if (target < 0) return target; @@ -781,7 +766,7 @@ static int overlay_symbol_update(void *fdt, void *fdto) return -FDT_ERR_BADOVERLAY; /* get the target of the fragment */ - ret = overlay_get_target(fdt, fdto, fragment, &target_path); + ret = fdt_overlay_target_offset(fdt, fdto, fragment, &target_path); if (ret < 0) return ret; target = ret; @@ -803,7 +788,7 @@ static int overlay_symbol_update(void *fdt, void *fdto) if (!target_path) { /* again in case setprop_placeholder changed it */ - ret = overlay_get_target(fdt, fdto, fragment, &target_path); + ret = fdt_overlay_target_offset(fdt, fdto, fragment, &target_path); if (ret < 0) return ret; target = ret; diff --git a/xen/common/libfdt/version.lds b/xen/common/libfdt/version.lds index 7ab85f1d9d..cbce5d4a8b 100644 --- a/xen/common/libfdt/version.lds +++ b/xen/common/libfdt/version.lds @@ -77,6 +77,7 @@ LIBFDT_1.2 { fdt_appendprop_addrrange; fdt_setprop_inplace_namelen_partial; fdt_create_with_flags; + fdt_overlay_target_offset; local: *; }; diff --git a/xen/include/xen/libfdt/libfdt.h b/xen/include/xen/libfdt/libfdt.h index c71689e2be..fabddbee8c 100644 --- a/xen/include/xen/libfdt/libfdt.h +++ b/xen/include/xen/libfdt/libfdt.h @@ -2109,6 +2109,24 @@ int fdt_del_node(void *fdt, int nodeoffset); */ int fdt_overlay_apply(void *fdt, void *fdto); +/** + * fdt_overlay_target_offset - retrieves the offset of a fragment's target + * @fdt: Base device tree blob + * @fdto: Device tree overlay blob + * @fragment_offset: node offset of the fragment in the overlay + * @pathp: pointer which receives the path of the target (or NULL) + * + * fdt_overlay_target_offset() retrieves the target offset in the base + * device tree of a fragment, no matter how the actual targeting is + * done (through a phandle or a path) + * + * returns: + * the targeted node offset in the base device tree + * Negative error code on error + */ +int fdt_overlay_target_offset(const void *fdt, const void *fdto, + int fragment_offset, char const **pathp); + /**********************************************************************/ /* Debugging / informational functions */ /**********************************************************************/ -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue May 02 23:37:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 23:37:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528868.822614 (Exim 4.92) (envelope-from ) id 1ptzZ4-0008US-L4; Tue, 02 May 2023 23:37:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528868.822614; Tue, 02 May 2023 23:37:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzZ4-0008Tz-Ew; Tue, 02 May 2023 23:37:46 +0000 Received: by outflank-mailman (input) for mailman id 528868; Tue, 02 May 2023 23:37:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzZ2-0004sC-Fg for xen-devel@lists.xenproject.org; Tue, 02 May 2023 23:37:44 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2062c.outbound.protection.outlook.com [2a01:111:f400:7eaa::62c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 552ea58e-e942-11ed-b225-6b7b168915f2; Wed, 03 May 2023 01:37:43 +0200 (CEST) Received: from DM6PR10CA0030.namprd10.prod.outlook.com (2603:10b6:5:60::43) by PH8PR12MB6841.namprd12.prod.outlook.com (2603:10b6:510:1c8::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 23:37:38 +0000 Received: from DM6NAM11FT073.eop-nam11.prod.protection.outlook.com (2603:10b6:5:60:cafe::88) by DM6PR10CA0030.outlook.office365.com (2603:10b6:5:60::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31 via Frontend Transport; Tue, 2 May 2023 23:37:38 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT073.mail.protection.outlook.com (10.13.173.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.21 via Frontend Transport; Tue, 2 May 2023 23:37:37 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 2 May 2023 18:37:35 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 2 May 2023 16:37:35 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 2 May 2023 18:37:34 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 552ea58e-e942-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fVNgEAorIrinAzAbFAp1oO37hZXxBb7ekDWjwhWkcemEPGnxRKqcW+m3UToKpPlfVd5OCRi1xKCFrZ5/wejFBIqH3b1Sg/PB2Gch6emWZvgQ8egmSLDJ33AbTJIrCRcn6yeNRSi5YjHKGgW0RvmZYOfrcEVXpXtwKkSabinpq7IdVcbt2VjGlEWFGoNlfIPP7T1S6jkb8Vo0Mo9X6mkX+eE+gQA5ntIefbtpOGhR9OAYBiD/6w84OY6lZSXdK3bZ4TBHKtP4l3CasBIvAKuwRFk9xrXybm5I2RfUkP1tfYo2E051mpKe4JBWuDr6UIg6bxyNST9AcCBfRsgz3JlGXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=45fuJEPfdOT3ElxOeWsri05r41QvJhpC/khBsBhOc+k=; b=ltr4GcawQtiBZOSzhjSlRlnkHepmTmdlewD6rX+IyOnI3Qa0LfkDFdAJL+YFn1zSkzgBVKIl0ZYra/377eGVtKJkDB/QS1G9Gx7cQ7W0OjEhLrtQVq05w0nrfPRtqcJKkocQAfU+tHtORxkrmo0ywS9hFQuhc05Ibiys4Kecv0D3QXRYBmMfDpNhqyZ1A+aNUwrMfA+hpyfeCtQpHSL0iqhcofaTixr4F5QliDttmXUExnqhYAnKj6S77jlubO6+MY3Tp00N1CFECr7kYBf3FrPJQVFXbMwR8saRecwD+Xe3vtR3s7sq4HF3eW9tfZdMPrwGcGMirvRqTe4uD/27SA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=45fuJEPfdOT3ElxOeWsri05r41QvJhpC/khBsBhOc+k=; b=f8ysGqbPRFTrPohT1BVu30l4EsRvmo5iN1OZd5jYXU1jJPbaurGryIB/ed7WzKBC8kShyNGm0hocom6HFA2xp3LLHwyDlR21MvM0LDlP8Qbr7lKzzckUhrnSyLtrgeB8JTqcJPoFLPry19PslYAGuGQKRG6I7Xlyu1gCoJ0yiFE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Vikram Garhwal To: CC: , , , Julien Grall Subject: [XEN][PATCH v6 10/19] xen/iommu: protect iommu_add_dt_device() with dtdevs_lock Date: Tue, 2 May 2023 16:36:41 -0700 Message-ID: <20230502233650.20121-11-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230502233650.20121-1-vikram.garhwal@amd.com> References: <20230502233650.20121-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT073:EE_|PH8PR12MB6841:EE_ X-MS-Office365-Filtering-Correlation-Id: 79ad38c7-1516-43e6-acb0-08db4b6636c3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NU8RTqxFer0gTDcYCP8jr+YW3AMDAsYu2QvLaiu8yd98kz3m4aPe0bQWQEwgYiIdstnCe19lnOY3Xye7H7DwX7O8UW56F7yM9nwvcy1JQAc6rcNZbOSxR2PG2bdbrJCrkvTvNtHlhP4/M4d+rUoh8jEynp0yVWHXSMGg9uwY8OVHhZIFoOyYXZJiCgxo2CpVU81kWQdvBKJ+9dGL+mjsQQWor5CamdMZROucpMUupXD/bZIVlPAZ57cCYHaqf4W61yqsW8tV/XYcnKESHWvCva67K6QkrokKkyiExt2abTqEECYfekxRmbYg2bV3vuaEl6ZnnfYU7MQ32qxyPHEOTz4mMOQiAPSFnaMLfTh8vSzeelg+lLIfhxH0VYpNjyTHHahFFqXaIdCnBIMmMetWnFdmbOeElN7Q/kH+izWNQSsJIHioRxrKBZx+FzrvQNiOhJ4I6Le3omOpfDUIZXP/QYGpTUcFGVVtjGNZomH5v9QVIpauS3pOMtWTpnYWhH59Ze2ts3dBNAdqRy4zELKma4W2XvNmeVRCzdYT3fUsy4TMe7GaCkrCB3adacu7lAJTQCjA39Fs7PzN7nHMhzdFEMIvxp5WZezlFReFpekc5vT7EhmbuJ1WyntoWf33ocp/766tix0lhGZjAIwpelVWUPKZJOFmQbZDnIUfc6TAsFYYWcus/E24U1PsPwnlRU+rnwNKWIblsuESa/gPXDi3eNKp+UtS4VARwlth7KSQg1s= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(376002)(346002)(136003)(396003)(451199021)(36840700001)(40470700004)(46966006)(54906003)(478600001)(2616005)(83380400001)(36860700001)(47076005)(40480700001)(6666004)(26005)(1076003)(336012)(6916009)(4326008)(316002)(356005)(82740400003)(70586007)(70206006)(186003)(426003)(41300700001)(2906002)(81166007)(8676002)(5660300002)(44832011)(8936002)(40460700003)(86362001)(36756003)(82310400005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 23:37:37.9816 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 79ad38c7-1516-43e6-acb0-08db4b6636c3 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT073.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6841 Protect iommu_add_dt_device() with dtdevs_lock to prevent concurrent access add. Signed-off-by: Vikram Garhwal Reviewed-by: Luca Fancellu Reviewed-by: Michal Orzel --- xen/drivers/passthrough/device_tree.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/xen/drivers/passthrough/device_tree.c b/xen/drivers/passthrough/device_tree.c index c386fda3e4..f3867ef1a6 100644 --- a/xen/drivers/passthrough/device_tree.c +++ b/xen/drivers/passthrough/device_tree.c @@ -145,6 +145,8 @@ int iommu_add_dt_device(struct dt_device_node *np) if ( dev_iommu_fwspec_get(dev) ) return 0; + spin_lock(&dtdevs_lock); + /* * According to the Documentation/devicetree/bindings/iommu/iommu.txt * from Linux. @@ -157,7 +159,10 @@ int iommu_add_dt_device(struct dt_device_node *np) * these callback implemented. */ if ( !ops->add_device || !ops->dt_xlate ) - return -EINVAL; + { + rc = -EINVAL; + goto fail; + } if ( !dt_device_is_available(iommu_spec.np) ) break; @@ -188,6 +193,8 @@ int iommu_add_dt_device(struct dt_device_node *np) if ( rc < 0 ) iommu_fwspec_free(dev); +fail: + spin_unlock(&dtdevs_lock); return rc; } -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue May 02 23:37:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 23:37:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528869.822620 (Exim 4.92) (envelope-from ) id 1ptzZ5-000060-6Y; Tue, 02 May 2023 23:37:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528869.822620; Tue, 02 May 2023 23:37:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzZ4-00004v-UB; Tue, 02 May 2023 23:37:46 +0000 Received: by outflank-mailman (input) for mailman id 528869; Tue, 02 May 2023 23:37:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzZ2-0005Si-I8 for xen-devel@lists.xenproject.org; Tue, 02 May 2023 23:37:44 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on20615.outbound.protection.outlook.com [2a01:111:f400:7eab::615]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 542f6709-e942-11ed-8611-37d641c3527e; Wed, 03 May 2023 01:37:42 +0200 (CEST) Received: from BN9PR03CA0353.namprd03.prod.outlook.com (2603:10b6:408:f6::28) by DS0PR12MB8017.namprd12.prod.outlook.com (2603:10b6:8:146::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.20; Tue, 2 May 2023 23:37:38 +0000 Received: from BN8NAM11FT047.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f6:cafe::79) by BN9PR03CA0353.outlook.office365.com (2603:10b6:408:f6::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.21 via Frontend Transport; Tue, 2 May 2023 23:37:38 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT047.mail.protection.outlook.com (10.13.177.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.21 via Frontend Transport; Tue, 2 May 2023 23:37:38 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 2 May 2023 18:37:37 -0500 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 2 May 2023 18:37:37 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 542f6709-e942-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lbLrY0XLfmtX5VteDWmQwhU0kk2Ylnhgds6RZ+kfmVv+oussvigC+N19O6lGs47+KeUblhHXdolMu9LH6xcHSmkRtx+yYjeY2V1qZTGJo7ZCRPwbhTYpVYUHIRmEpJbdX1P2cAHvf3C2RksP+jLk6vMv/ByNntBL78KPO2SNbGAAe3vTB8Q83yTXoKrXtEIAUovJ6/HTXVJPWI7TWQbOck8P7Tae/+L/rUiXDEL6IrRRYNRRWsMS1zYbVMPo9XClfsovvTbbvDeQpLMqEbBnj8eP0igPQb1TU/c4Aww3cmwDbkYqiI/XQcz231ht3T1raBkk6Oz05iiYUq0i7X4mbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+CZpvoQNw8JQfGrQR7sP9j/mivY1rVi0G0xxugML0N8=; b=OYsyBQ2qtqWf9g4uKUwiBP9H0/uFQGZgVXvKlpP8iP5ZoN4x9aKo/EFMymredk4PiW4oSgu3M5BWjelyXrC5qMVLoKFCLxWVOm2e6lgMhpwnbviHTt3NEhe5ivHhIrqa0bBFHNkqWBZLY8KddIbB6/W4T+vhlFyzWnjk3DQLF8RRYe21RM8so3gX9N1dJW2FzJWV3WanfYdE2DU0DbFmQkL8JKuOyf7L4cAmuDwiuqIZdkV70RS6oVV+bOEA89Y/TWwz/lkHPbQdKw1oLrYKh2rpqYesYyCN5AefVo/vtk/zeWTFbpWNaCK/xHq8t4KkmvMo35sAFYfpLLDpiS29Dw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+CZpvoQNw8JQfGrQR7sP9j/mivY1rVi0G0xxugML0N8=; b=wPIjnURyLlj93gqdi6Z9aCwXcg+joWkR/kkmEM8sFZVJWqiAR9Zzf0gTzm0bh6clUjcfjwg/jMz6JuCxjD1vPxnPWM3Dqpc7cgWJanHT2GKTQ0W6aORAjlFk1ik/ZvSlwGmyUcBI+Ab0WbZQwEutjYwJ9Gj1xFpOVhJ40cnjhUQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , , , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [XEN][PATCH v6 13/19] asm/smp.h: Fix circular dependency for device_tree.h and rwlock.h Date: Tue, 2 May 2023 16:36:44 -0700 Message-ID: <20230502233650.20121-14-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230502233650.20121-1-vikram.garhwal@amd.com> References: <20230502233650.20121-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT047:EE_|DS0PR12MB8017:EE_ X-MS-Office365-Filtering-Correlation-Id: 497fbd75-4f3b-410f-3942-08db4b663709 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QDJUL5UEsyw4J3mOZMHxO6MCIzm75A6YFTW2AkkQIcsuLRHs5vWqj64AKqydffx5mFFgPMwILp2KH7S/s2EeVNQYdWveT69oPyb25LzbrtBEY592D+WV68LQ/kx6hV3nBM1JFUIjzLIgJWIyHWGIorDRg4GP1w5RAXulf+7Q61hrJYNXc4Pd9DFyeJqOAFYhXwKMW5c41bI7WgyN/jD4cbQtX4+6oBUuizaN5u4f164CJMLg3DyiDK5/ecex3eh97PyONaJDMjaq4B74FyltkzLDz0YtnSA9VveGUs3Xe1smDdM9pATBCVOIjfVHem1wkh8FFVPBU0N9imnou9JI+jT+CS8rhHl4D860WfrG8ZjIkl+7yY4czOHf95HOZyR8Vf426SllumytAZFP3XhrP7bVD4tfqPGqy/VEe8Zf+HsmgtCyd0wcvYtBxi1VoozpHHUrdNm3mUAvnZ0S8MJ9U2nJnYFSI+mcemuUSkVWFxadpIokx9PaJ4VZQM42dtFk8cCW7QHC+7Jte7kNSJ2b339pKiQiYj70ICIhvNywYHEL7eOzXMUvoUqnKx1IRDGhVu9xeyVIOylmJpw0eQ3sl80hABabLPFDJLRct2aPwDDHF0tYgL2JNPAFDVnzs7ZsO6Zdzxh3A0SeGwDw0nYk4+Bknur1eOWtGSDxHvo/j715/FTzc6LAIlQUoGk3DM9tzpbwNTHw2Ga+YJ/rb/btLKHjzTx9KHbjiGOnco08ufU= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(39860400002)(376002)(451199021)(36840700001)(46966006)(40470700004)(81166007)(356005)(82740400003)(44832011)(41300700001)(8936002)(5660300002)(8676002)(2906002)(40480700001)(86362001)(40460700003)(82310400005)(6666004)(36860700001)(47076005)(54906003)(478600001)(186003)(36756003)(2616005)(70206006)(83380400001)(1076003)(26005)(336012)(6916009)(70586007)(4326008)(426003)(316002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 23:37:38.4843 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 497fbd75-4f3b-410f-3942-08db4b663709 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT047.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8017 Dynamic programming ops will modify the dt_host and there might be other function which are browsing the dt_host at the same time. To avoid the race conditions, adding rwlock for browsing the dt_host. But adding rwlock in device_tree.h causes following circular dependency: device_tree.h->rwlock.h->smp.h->asm/smp.h->device_tree.h To fix this, removed the "#include and forward declared "struct dt_device_node". Signed-off-by: Vikram Garhwal Reviewed-by: Henry Wang Reviewed-by: Michal Orzel --- xen/arch/arm/include/asm/smp.h | 3 ++- xen/arch/arm/smpboot.c | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/include/asm/smp.h b/xen/arch/arm/include/asm/smp.h index a37ca55bff..b12949ba8a 100644 --- a/xen/arch/arm/include/asm/smp.h +++ b/xen/arch/arm/include/asm/smp.h @@ -3,13 +3,14 @@ #ifndef __ASSEMBLY__ #include -#include #include #endif DECLARE_PER_CPU(cpumask_var_t, cpu_sibling_mask); DECLARE_PER_CPU(cpumask_var_t, cpu_core_mask); +struct dt_device_node; + #define cpu_is_offline(cpu) unlikely(!cpu_online(cpu)) #define smp_processor_id() get_processor_id() diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c index 4a89b3a834..255bbcc967 100644 --- a/xen/arch/arm/smpboot.c +++ b/xen/arch/arm/smpboot.c @@ -10,6 +10,7 @@ #include #include #include +#include #include #include #include -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue May 02 23:37:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 23:37:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528870.822625 (Exim 4.92) (envelope-from ) id 1ptzZ6-0000Mm-3V; Tue, 02 May 2023 23:37:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528870.822625; Tue, 02 May 2023 23:37:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzZ5-0000Kd-M3; Tue, 02 May 2023 23:37:47 +0000 Received: by outflank-mailman (input) for mailman id 528870; Tue, 02 May 2023 23:37:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzZ3-0005Si-IN for xen-devel@lists.xenproject.org; Tue, 02 May 2023 23:37:45 +0000 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on20624.outbound.protection.outlook.com [2a01:111:f400:7ea9::624]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 55505898-e942-11ed-8611-37d641c3527e; Wed, 03 May 2023 01:37:42 +0200 (CEST) Received: from BN9PR03CA0343.namprd03.prod.outlook.com (2603:10b6:408:f6::18) by CH0PR12MB5267.namprd12.prod.outlook.com (2603:10b6:610:d2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 23:37:39 +0000 Received: from BN8NAM11FT047.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f6:cafe::43) by BN9PR03CA0343.outlook.office365.com (2603:10b6:408:f6::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.32 via Frontend Transport; Tue, 2 May 2023 23:37:39 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT047.mail.protection.outlook.com (10.13.177.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.21 via Frontend Transport; Tue, 2 May 2023 23:37:39 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 2 May 2023 18:37:38 -0500 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 2 May 2023 18:37:38 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55505898-e942-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QJGXP6I5DbTWCJd4UPQsUa0et2w6HnKRklEs3Tq0HDyaZjomDSMmOx394jyxoEYWtAH6vCir7FylPFU47fc5cNMSPqak6eMuO60yyiS1EqWOULnwGw6+asuLYM933ih96Mlz4rdVOpmwLYAyPBEP9t8vE5yFsf7bHbV4I/Dchquluyt4YAkiDVcSaV8BpTMtQTWOD10Gins5RVJpjeduZkDKnL3jubsobkU9OAVDcU58UFWtQO8oMrkNifcG8+gQmEa0XZxKFfY3bw7JHWvad/J1pZN6gywslRw3mFs+sy8g5c7DzMxMnnZh4ZUkhYrqSY0rHmnzyMydW8mBwsGjbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vIBy8QBowBYZ6c4wTJeiTkeZZ3rBM64WqnXkHigySw8=; b=NR+ALs6okeXu7dtkr7pF8B7BIDy9LXA4clEVyPo7OHLKid4HxwQCPa6HuTiDDxEHk6LT1A9FfYuaNZDF//KamLzgVZnaUUBnezUlWuAH6zBLqG7DQy1KYcNd62eZkEb0CtH7SKWfVJLs1jTqL+vA3jr3TWWrHHeM6SbHyN1lqL+sVexlS2Spqx5JVYVgGFaf6aVbTt6irajHTJpcgjl5DCyoyXCQawyLUGXKgVeuBkdh7QYfOAU8kjH32Z2MPE6ORFCDwVcond62doT2494uDpknItOSiuq3S/LnYgdhmKt7LehAavC9htErHbgv7D1l0XH3IiGVzCBhjc9daIx9pA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vIBy8QBowBYZ6c4wTJeiTkeZZ3rBM64WqnXkHigySw8=; b=FxrmF8KpbY8OMt9twCQcmBtIxQj5cssKdQJWsbfwwjf9LZ6+wqZgxnrMzBXMKkjrx/97XNSxcVTeU9iV1fn8YxDLaXlDFB+NgnzDSeKR8p1cOZ/EAxELUFAnFuguxJt4eaX1z3OTPb9ONhgsB6iCik+9jIrYsV0EUMufMGS4rZE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , , , Julien Grall Subject: [XEN][PATCH v6 14/19] common/device_tree: Add rwlock for dt_host Date: Tue, 2 May 2023 16:36:45 -0700 Message-ID: <20230502233650.20121-15-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230502233650.20121-1-vikram.garhwal@amd.com> References: <20230502233650.20121-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT047:EE_|CH0PR12MB5267:EE_ X-MS-Office365-Filtering-Correlation-Id: 8a7aefba-4bc9-41ea-9579-08db4b663768 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bY3CIOnIcI4X9pEmoRAiF0hbj8IBsn/tdl4KhSa8MyxKKPCRWysPgd+5Su4M60i8YtOI3p0Ob5N0HQGmeayfBYiS1j+xRM1O5UHiP3eVLwM3SB4Xert+T/Ta3TJvAWgRQMAju3f/bxjG975cMuNiwfCsys72Qfquwuc2QTVKY8iH9vAozLUVnqobOJiHJi2yGLIk5Uc73GNtigC7fOSTVU/dDDZn715IDTPsLtwj0f9YWiCBfZShzDp4cfOWCttgnVX7YmXIAIw35g8prowY3mh5dX7a/F6gAtEw+w5Zlg9N7nUY5KGlBINMtKrHyug7jsHHAceFgSKSfPKqhrLf4PsfetJAUldfao/+rkU4USgq+59DcH+RK5FR32N5VV3qNza4glve1w2pUBY4q0dwFuYCX9mb7RQ6FC212GdKc5CWVwGWnXtEvcK93whOoJcwYzlbnjyc1TGvF1DQIVDutwjYLMQgjyExTKPz+YpuxPWbd6+dWxzAmr6e/9gbYBRVEL+avVZOYBcFpS7SG8bE7kG+4h0SrM3RbvEpfrZXsLCNzadFqjC18NLaBVYyFbUh+DDMJRaoBnvU70sxgoqXCcbaM55SVGF1qXxgWB+eSaT7PMuJTw+FS0kTxfaJnkEP2Hr4WPdZP4lENxwUyzA5B+qZoRC2I374aMQUTVrLvVueswPoDjcuhl+HCx7F/QWwFH7COFZnePKschJzE3miL3N+gGL7wabVZMpH+GqMs70= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(376002)(39860400002)(451199021)(36840700001)(40470700004)(46966006)(81166007)(26005)(356005)(82740400003)(1076003)(186003)(83380400001)(2616005)(336012)(36860700001)(426003)(47076005)(36756003)(44832011)(40460700003)(2906002)(40480700001)(41300700001)(54906003)(5660300002)(82310400005)(478600001)(6666004)(70586007)(6916009)(70206006)(4326008)(8936002)(86362001)(316002)(8676002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 23:37:39.1092 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8a7aefba-4bc9-41ea-9579-08db4b663768 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT047.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5267 Dynamic programming ops will modify the dt_host and there might be other function which are browsing the dt_host at the same time. To avoid the race conditions, adding rwlock for browsing the dt_host during runtime. Signed-off-by: Vikram Garhwal --- xen/common/device_tree.c | 4 ++++ xen/drivers/passthrough/device_tree.c | 18 ++++++++++++++++++ xen/include/xen/device_tree.h | 6 ++++++ 3 files changed, 28 insertions(+) diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index 426a809f42..48cb68bcd9 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -2109,7 +2109,11 @@ int unflatten_device_tree(const void *fdt, struct dt_device_node **mynodes) dt_dprintk(" <- unflatten_device_tree()\n"); + /* Init r/w lock for host device tree. */ + rwlock_init(&dt_host->lock); + return 0; + } static void dt_alias_add(struct dt_alias_prop *ap, diff --git a/xen/drivers/passthrough/device_tree.c b/xen/drivers/passthrough/device_tree.c index 46f9080c8f..e3be8e3f91 100644 --- a/xen/drivers/passthrough/device_tree.c +++ b/xen/drivers/passthrough/device_tree.c @@ -111,6 +111,8 @@ int iommu_release_dt_devices(struct domain *d) if ( !is_iommu_enabled(d) ) return 0; + read_lock(&dt_host->lock); + list_for_each_entry_safe(dev, _dev, &hd->dt_devices, domain_list) { rc = iommu_deassign_dt_device(d, dev); @@ -118,10 +120,14 @@ int iommu_release_dt_devices(struct domain *d) { dprintk(XENLOG_ERR, "Failed to deassign %s in domain %u\n", dt_node_full_name(dev), d->domain_id); + + read_unlock(&dt_host->lock); return rc; } } + read_unlock(&dt_host->lock); + return 0; } @@ -245,6 +251,8 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, struct domain *d, int ret; struct dt_device_node *dev; + read_lock(&dt_host->lock); + switch ( domctl->cmd ) { case XEN_DOMCTL_assign_device: @@ -294,7 +302,10 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, struct domain *d, spin_unlock(&dtdevs_lock); if ( d == dom_io ) + { + read_unlock(&dt_host->lock); return -EINVAL; + } ret = iommu_add_dt_device(dev); if ( ret < 0 ) @@ -310,6 +321,8 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, struct domain *d, printk(XENLOG_G_ERR "XEN_DOMCTL_assign_dt_device: assign \"%s\"" " to dom%u failed (%d)\n", dt_node_full_name(dev), d->domain_id, ret); + + read_unlock(&dt_host->lock); break; case XEN_DOMCTL_deassign_device: @@ -328,11 +341,15 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, struct domain *d, break; ret = xsm_deassign_dtdevice(XSM_HOOK, d, dt_node_full_name(dev)); + if ( ret ) break; if ( d == dom_io ) + { + read_unlock(&dt_host->lock); return -EINVAL; + } ret = iommu_deassign_dt_device(d, dev); @@ -347,5 +364,6 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, struct domain *d, break; } + read_unlock(&dt_host->lock); return ret; } diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index d6366d3dac..e616dd7e9c 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -18,6 +18,7 @@ #include #include #include +#include #define DEVICE_TREE_MAX_DEPTH 16 @@ -106,6 +107,11 @@ struct dt_device_node { struct list_head domain_list; struct device dev; + + /* + * Lock that protects r/w updates to unflattened device tree i.e. dt_host. + */ + rwlock_t lock; }; #define dt_to_dev(dt_node) (&(dt_node)->dev) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue May 02 23:37:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 23:37:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528871.822633 (Exim 4.92) (envelope-from ) id 1ptzZ7-0000YY-7U; Tue, 02 May 2023 23:37:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528871.822633; Tue, 02 May 2023 23:37:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzZ6-0000VP-Im; Tue, 02 May 2023 23:37:48 +0000 Received: by outflank-mailman (input) for mailman id 528871; Tue, 02 May 2023 23:37:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzZ4-0005Si-IQ for xen-devel@lists.xenproject.org; Tue, 02 May 2023 23:37:46 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on20605.outbound.protection.outlook.com [2a01:111:f400:fe5a::605]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 54ed58db-e942-11ed-8611-37d641c3527e; Wed, 03 May 2023 01:37:43 +0200 (CEST) Received: from BN9PR03CA0357.namprd03.prod.outlook.com (2603:10b6:408:f6::32) by PH8PR12MB7026.namprd12.prod.outlook.com (2603:10b6:510:1bd::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Tue, 2 May 2023 23:37:37 +0000 Received: from BN8NAM11FT047.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f6:cafe::c6) by BN9PR03CA0357.outlook.office365.com (2603:10b6:408:f6::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31 via Frontend Transport; Tue, 2 May 2023 23:37:37 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT047.mail.protection.outlook.com (10.13.177.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.21 via Frontend Transport; Tue, 2 May 2023 23:37:37 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 2 May 2023 18:37:36 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 2 May 2023 16:37:36 -0700 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 2 May 2023 18:37:35 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 54ed58db-e942-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lnzedPcLVf9AgNtKSrsWnxlj8wg/n0b35HQajSB8VeMk4/pP7cndeadLyZowOcl2cp8NM5Php0iB6EEijSr27Gcr6oW5YxBvmLqan8hePFHoBA5z8xdMPfKDTamtWJK6IpxtnoDCI9SeL+WK7LJTuFWhKNAIRL+NdnJ0FBQ/cQyBL8XbJIUfuBHGHgrlwky19/krsIwZ9Skv1eUOqyI1tdoS/SIGj21ZpfUacUZRD4ipLXElLbe4+FHqUPd47hstrCmvywKSfZHcubZ15rpdxhjTXVTD4X5T3SiSuexWs5l5ITZkTiXtg8e+NkVOv6HoD202Y8xKvgoADEnXjVu7kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rIRy40Pphy3puPxLyarufMzgZUdXxhJqsOpQVvIQDWY=; b=hUh4Ds6KIjy/4l/tB4nJ3FwOgDFMEgiZmqb4yxVATYO+IOx+kG3xHZS8zilSoIVmBglcIUo6LhW8N0KL+ZE66jVfkv6sI4Ei+3us6nzoco9EAKtcuK3sFkpvZwkdFRncjFHPfWEbAj9dH4fRhCiwmjM+HqHgsDkvQhOl2UFtFm5QxluZsBkNmu9QetIzLlQ77P0p3Tumwv613ZgUCs+gAubxx/yQiYTvYWcXJw3BiYiTM9kHFNkdGJYydGQcTMviMfyfSViCujx29GugZbQ2twaF4jbnYsBIWP84S2dICBi7p7hwqPwN0rt1AoDgDjLDJ1hxf6atjmg9BbgDWeV8Kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rIRy40Pphy3puPxLyarufMzgZUdXxhJqsOpQVvIQDWY=; b=Q/vuMHZ8fOVxvR+uIcHcM5KH/SxWuak/R7bE8S7aLTxzJu0aA69UCBk4z+RcfrbI/eNljptrJ1S/C/+1SkX5AUO6FUgc6h5GxXXpkyB/cYLkV2Law6ezhiZ6LuNTcuQ/N0Eg9OBAgvy0i+4aQrIdO3C1mjAgdEmVTeHyi1cRViQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , , , Julien Grall , Jan Beulich , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [XEN][PATCH v6 11/19] xen/iommu: Introduce iommu_remove_dt_device() Date: Tue, 2 May 2023 16:36:42 -0700 Message-ID: <20230502233650.20121-12-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230502233650.20121-1-vikram.garhwal@amd.com> References: <20230502233650.20121-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT047:EE_|PH8PR12MB7026:EE_ X-MS-Office365-Filtering-Correlation-Id: 2bca90a4-d19f-4adf-e3c7-08db4b66364c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Mzjbtg8HLssdAgmmIu3wUMMiNi91uy0HTN5DYlJM0B0ON8jJCxHlcp05X1gONEuw9Oc9aAAkv+VsvX5rXJB+IDtvfdptl0OPABfZkC8hOeVvmaLUJj/uHlvze+znXRGJvmukIUrLfu/0HUmPlImEE9I2g7+JnNZBX0bRZiw9zVDjP1BHgMaMysjnJlSNJE8R2rBETEiD2OthCc7X1SmBVh97APnSTMDBTM96YtBhuWENBFZru89Y31VeMxXbo9PjDO1ZQV5xAU3lNvgXjSDG+r1TclAGDFsRaEgg8Sfs4U3cfCRgubWjassDtP/MY5RbsqS+mTrXHFO7VyLsPZQMDO8xA4CdJ3xZRHayJGBxf1uGpb15h/Rm01w5QJ5v6S2+99dN2sy/n3JDj3er/Adl+xeZd6Kp+sUKAE+xMbUcOuLhvqn9LCegjapwsNzrpWiybDx0SuOkkNLfwWcwjGvdTSe9k0KJpLXmH30clwUls/CAwOMlIV5Gb380W9oMSk0+hysSA2uq7C0APc6XI5pyyej24WoLWviAjsjbITzBwqI8h4+mrZTsWiy/tWaaJPNKC6QEGLZ2SUNpBRvWZSYzluTAXGClYkmSpmyImqPDfHFsQZRGKL/AVXBDTEEryo/lAtTmPHUsjcxD4OGjKX1CSln//eDn2adIOoy9LmYcQPKQQ4U37/jgo3Av3tIChk5j4Z94PV5Nm8WrQ3GkreUCWXNSw6vt3wp/qXUzN2jeerY= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(376002)(39860400002)(396003)(451199021)(46966006)(40470700004)(36840700001)(2616005)(83380400001)(478600001)(36860700001)(186003)(4326008)(54906003)(70586007)(70206006)(6916009)(47076005)(426003)(26005)(6666004)(336012)(1076003)(44832011)(316002)(40460700003)(8676002)(82740400003)(8936002)(5660300002)(356005)(41300700001)(2906002)(40480700001)(81166007)(82310400005)(86362001)(36756003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 23:37:37.2500 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2bca90a4-d19f-4adf-e3c7-08db4b66364c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT047.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7026 Remove master device from the IOMMU. This will be helpful when removing the overlay nodes using dynamic programming during run time. Signed-off-by: Vikram Garhwal Reviewed-by: Michal Orzel --- xen/drivers/passthrough/device_tree.c | 41 +++++++++++++++++++++++++++ xen/include/xen/iommu.h | 2 ++ 2 files changed, 43 insertions(+) diff --git a/xen/drivers/passthrough/device_tree.c b/xen/drivers/passthrough/device_tree.c index f3867ef1a6..46f9080c8f 100644 --- a/xen/drivers/passthrough/device_tree.c +++ b/xen/drivers/passthrough/device_tree.c @@ -125,6 +125,47 @@ int iommu_release_dt_devices(struct domain *d) return 0; } +int iommu_remove_dt_device(struct dt_device_node *np) +{ + const struct iommu_ops *ops = iommu_get_ops(); + struct device *dev = dt_to_dev(np); + int rc; + + if ( !ops ) + return -EOPNOTSUPP; + + spin_lock(&dtdevs_lock); + + if ( iommu_dt_device_is_assigned_locked(np) ) + { + rc = -EBUSY; + goto fail; + } + + /* + * The driver which supports generic IOMMU DT bindings must have this + * callback implemented. + */ + if ( !ops->remove_device ) + { + rc = -EOPNOTSUPP; + goto fail; + } + + /* + * Remove master device from the IOMMU if latter is present and available. + * The driver is responsible for removing is_protected flag. + */ + rc = ops->remove_device(0, dev); + + if ( !rc ) + iommu_fwspec_free(dev); + +fail: + spin_unlock(&dtdevs_lock); + return rc; +} + int iommu_add_dt_device(struct dt_device_node *np) { const struct iommu_ops *ops = iommu_get_ops(); diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h index 76add226ec..6ba8d73966 100644 --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -219,6 +219,8 @@ int iommu_deassign_dt_device(struct domain *d, struct dt_device_node *dev); int iommu_dt_domain_init(struct domain *d); int iommu_release_dt_devices(struct domain *d); +int iommu_remove_dt_device(struct dt_device_node *np); + /* * Helper to add master device to the IOMMU using generic IOMMU DT bindings. * -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue May 02 23:38:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 23:38:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528872.822640 (Exim 4.92) (envelope-from ) id 1ptzZ8-0000vu-EI; Tue, 02 May 2023 23:37:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528872.822640; Tue, 02 May 2023 23:37:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzZ8-0000ql-12; Tue, 02 May 2023 23:37:50 +0000 Received: by outflank-mailman (input) for mailman id 528872; Tue, 02 May 2023 23:37:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzZ5-0005Si-IX for xen-devel@lists.xenproject.org; Tue, 02 May 2023 23:37:47 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2062f.outbound.protection.outlook.com [2a01:111:f400:7eaa::62f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 553c6b0d-e942-11ed-8611-37d641c3527e; Wed, 03 May 2023 01:37:44 +0200 (CEST) Received: from BN9PR03CA0742.namprd03.prod.outlook.com (2603:10b6:408:110::27) by MN0PR12MB5714.namprd12.prod.outlook.com (2603:10b6:208:371::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Tue, 2 May 2023 23:37:40 +0000 Received: from BN8NAM11FT063.eop-nam11.prod.protection.outlook.com (2603:10b6:408:110:cafe::24) by BN9PR03CA0742.outlook.office365.com (2603:10b6:408:110::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.32 via Frontend Transport; Tue, 2 May 2023 23:37:40 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT063.mail.protection.outlook.com (10.13.177.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.22 via Frontend Transport; Tue, 2 May 2023 23:37:40 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 2 May 2023 18:37:39 -0500 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 2 May 2023 18:37:38 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 553c6b0d-e942-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jf+Pl77K6re/uAAOe5J4d4QO0tluyAQnYENz1B5K2kLmkfK2zC954matqkxE/DTpmsorFJIonpoTDzx7fOFWprJ9S7Bvqll8TlSBiH4BnemvzvPeyso+0rpNmy7MGyKe9KPnttUlKYLAVY/2z3e+s6elSp2vRTD3rB8t2rKpgXyLwAO0SUN8+5T1AjE6mtISgWvX1r6pQ6RuqfvZv2DAmJkAlqlM4YY0cf9Tk9FoYwTlozNsKDQs6j9tM6mYER2uQfX0AebVFv5gdx6amuzpHtDwMbuArX3JLSIkG1n6SLSdKfzjjzU7bJ3iXCm8iSc3RTRVKXJQ+0+aFAH/H26Zhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6lA6+5GWeGyVJ/eIdTxBUhZWKw1xIAoedVb14517C6o=; b=R6TNLe8+2RrL5HKo7lQY9ChtM6wPoQjqI8QVsU8yacg70PslIwv7gsqU7yDzeNGVO1WSXiUFFloIUrWWvnMlYozfoc8SN5SfQA0GwUFJ5BDkYb1Twasrbq0iNx3vOf7QE7rKjuK3+8jUJEnBaJ5oU3w0i9ZiUE3HRoZ47JfaXOTkDQdhjJMEcpKmY2Sdwgz9BgbM37J63dDvfPx+YoeoIRPYoYjQH5CHPyaQPk8E4aTG1bdELaS2K3smzybPrlYqZOBA4VMScnkxL95NYvLkofVWX5+lHA2D1dkU+gwfYt5e923k9TK46aNuqqBW7vzxT5JbER2Z3W1Y/qhI7QUEUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6lA6+5GWeGyVJ/eIdTxBUhZWKw1xIAoedVb14517C6o=; b=Qpbpu8+IF1xpezD7wZX6vbBwY7w0HXK28rUpruhu9xKRMEx7yreFz58Lf2T5UN2N+v0m5Horm7pVGooqFKqAXF7r991YNQbfOlfKUIZnUigIKJ+FwxKz9CJyPxMPkOXvR7mfmvE8FrKnYtmjopNVAfQXEAD1uGNQGY3XumDNZmU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , , , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [XEN][PATCH v6 15/19] xen/arm: Implement device tree node removal functionalities Date: Tue, 2 May 2023 16:36:46 -0700 Message-ID: <20230502233650.20121-16-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230502233650.20121-1-vikram.garhwal@amd.com> References: <20230502233650.20121-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT063:EE_|MN0PR12MB5714:EE_ X-MS-Office365-Filtering-Correlation-Id: a9d8e0b7-d6c2-42a9-5f77-08db4b66380b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ObIVh6nvqFLs+CfF0txS2yj8MSGrx3IkESWWOS7Xihpa/omLs9Z9DE8hsoMksIvtKx0wYkWBMOeby0wVb1AaD2Nxasd/fA4vpgtHlVtsZMIDKnhMRYN5huYQf+vZF6zHJ3uxhxbXhVVcC7wlIavLfsBYoteJ3fgYy1m8lwwt3T7gCyFMT1WAT2VHCzEXFVrX4u/ohnQVHcTDD/yI2MZ+ve9Bj+itFG+yWdtj2FhWLTfpfOQ5K1AwmF5egPx9yHffC7IpiW7dDyrntp34WUZn5zUzu8ivEYK4VMWd4zRsG3198PLBcyIB3k9/WPRIFiV4N5EuHGmIcdcVJlNoREsELzT6iociJr01r+kj6SyCNRoesUFHIQCKD+d3Gz3PEWNGi7Lj1s8OnEvXlIRE1VVfWGRe8sslB4bOswgD8hOkJc029sFq1Ma+flo/M/PmvdF6zyMf5zfmL3+ORytITDp5xsVGsy3bYncKMVn8GbuTXjFxkWFUrpiIhfDNu46TtPkNzBZE1jsQnwGHC+qQgeaCAffvndxLlY54DegzisCl7N2oKgmmxdM/A+oS1PndxHWIwxUFpULO7HJvqEtKkd4ycf5Mp8DbL1rGea1tPF5Obu34rEn0hqKDeOBlbzLC4UaXM9rhs8ZxpQ7WhrJT7sKCUZYjS1ivbWQqzeJTapEjNWsjVuQodkj7QzUZ75wLFgspkTSIxMXmzirTDOlWSN7dA1tprGom/4NNEou1nBB6mWQqv+eqIjDx4j+2DHuZSC3r6RKTLITpQQL6MLc7a52+9g== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(39860400002)(376002)(136003)(451199021)(40470700004)(36840700001)(46966006)(478600001)(36860700001)(36756003)(316002)(5660300002)(2906002)(30864003)(40460700003)(8936002)(8676002)(70206006)(40480700001)(86362001)(4326008)(82310400005)(70586007)(81166007)(6916009)(336012)(356005)(44832011)(41300700001)(82740400003)(83380400001)(426003)(47076005)(54906003)(1076003)(186003)(26005)(2616005)(6666004)(403724002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 23:37:40.1605 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a9d8e0b7-d6c2-42a9-5f77-08db4b66380b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT063.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5714 Introduce sysctl XEN_SYSCTL_dt_overlay to remove device-tree nodes added using device tree overlay. xl dt-overlay remove file.dtbo: Removes all the nodes in a given dtbo. First, removes IRQ permissions and MMIO accesses. Next, it finds the nodes in dt_host and delete the device node entries from dt_host. The nodes get removed only if it is not used by any of dom0 or domio. Also, added overlay_track struct to keep the track of added node through device tree overlay. overlay_track has dt_host_new which is unflattened form of updated fdt and name of overlay nodes. When a node is removed, we also free the memory used by overlay_track for the particular overlay node. Nested overlay removal is supported in sequential manner only i.e. if overlay_child nests under overlay_parent, it is assumed that user first removes overlay_child and then removes overlay_parent. Signed-off-by: Vikram Garhwal --- xen/arch/arm/sysctl.c | 16 +- xen/common/Makefile | 1 + xen/common/dt-overlay.c | 419 +++++++++++++++++++++++++++++++++++ xen/include/public/sysctl.h | 23 ++ xen/include/xen/dt-overlay.h | 58 +++++ 5 files changed, 516 insertions(+), 1 deletion(-) create mode 100644 xen/common/dt-overlay.c create mode 100644 xen/include/xen/dt-overlay.h diff --git a/xen/arch/arm/sysctl.c b/xen/arch/arm/sysctl.c index b0a78a8b10..456358166c 100644 --- a/xen/arch/arm/sysctl.c +++ b/xen/arch/arm/sysctl.c @@ -9,6 +9,7 @@ #include #include +#include #include #include #include @@ -21,7 +22,20 @@ void arch_do_physinfo(struct xen_sysctl_physinfo *pi) long arch_do_sysctl(struct xen_sysctl *sysctl, XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl) { - return -ENOSYS; + long ret = 0; + + switch ( sysctl->cmd ) + { + case XEN_SYSCTL_dt_overlay: + ret = dt_sysctl(&sysctl->u.dt_overlay); + break; + + default: + ret = -ENOSYS; + break; + } + + return ret; } /* diff --git a/xen/common/Makefile b/xen/common/Makefile index 46049eac35..e7e96b1087 100644 --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -8,6 +8,7 @@ obj-$(CONFIG_DEBUG_TRACE) += debugtrace.o obj-$(CONFIG_HAS_DEVICE_TREE) += device_tree.o obj-$(CONFIG_IOREQ_SERVER) += dm.o obj-y += domain.o +obj-$(CONFIG_OVERLAY_DTB) += dt-overlay.o obj-y += event_2l.o obj-y += event_channel.o obj-y += event_fifo.o diff --git a/xen/common/dt-overlay.c b/xen/common/dt-overlay.c new file mode 100644 index 0000000000..b89cceab84 --- /dev/null +++ b/xen/common/dt-overlay.c @@ -0,0 +1,419 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * xen/common/dt-overlay.c + * + * Device tree overlay support in Xen. + * + * Copyright (C) 2023, Advanced Micro Devices, Inc. All Rights Reserved. + * Written by Vikram Garhwal + * + */ +#include +#include +#include +#include +#include + +static LIST_HEAD(overlay_tracker); +static DEFINE_SPINLOCK(overlay_lock); + +/* Find last descendants of the device_node. */ +static struct dt_device_node * + find_last_descendants_node(struct dt_device_node *device_node) +{ + struct dt_device_node *child_node; + + for ( child_node = device_node->child; child_node->sibling != NULL; + child_node = child_node->sibling ); + + /* If last child_node also have children. */ + if ( child_node->child ) + child_node = find_last_descendants_node(child_node); + + return child_node; +} + +static int dt_overlay_remove_node(struct dt_device_node *device_node) +{ + struct dt_device_node *np; + struct dt_device_node *parent_node; + struct dt_device_node *device_node_last_descendant = device_node->child; + + parent_node = device_node->parent; + + if ( parent_node == NULL ) + { + dt_dprintk("%s's parent node not found\n", device_node->name); + return -EFAULT; + } + + np = parent_node->child; + + if ( np == NULL ) + { + dt_dprintk("parent node %s's not found\n", parent_node->name); + return -EFAULT; + } + + /* If node to be removed is only child node or first child. */ + if ( !dt_node_cmp(np->full_name, device_node->full_name) ) + { + parent_node->child = np->sibling; + + /* + * Iterate over all child nodes of device_node. Given that we are + * removing parent node, we need to remove all it's descendants too. + */ + if ( device_node_last_descendant ) + { + device_node_last_descendant = + find_last_descendants_node(device_node); + parent_node->allnext = device_node_last_descendant->allnext; + } + else + parent_node->allnext = np->allnext; + + return 0; + } + + for ( np = parent_node->child; np->sibling != NULL; np = np->sibling ) + { + if ( !dt_node_cmp(np->sibling->full_name, device_node->full_name) ) + { + /* Found the node. Now we remove it. */ + np->sibling = np->sibling->sibling; + + if ( np->child ) + np = find_last_descendants_node(np); + + /* + * Iterate over all child nodes of device_node. Given that we are + * removing parent node, we need to remove all it's descendants too. + */ + if ( device_node_last_descendant ) + device_node_last_descendant = + find_last_descendants_node(device_node); + + if ( device_node_last_descendant ) + np->allnext = device_node_last_descendant->allnext; + else + np->allnext = np->allnext->allnext; + + break; + } + } + + return 0; +} + +/* Basic sanity check for the dtbo tool stack provided to Xen. */ +static int check_overlay_fdt(const void *overlay_fdt, uint32_t overlay_fdt_size) +{ + if ( (fdt_totalsize(overlay_fdt) != overlay_fdt_size) || + fdt_check_header(overlay_fdt) ) + { + printk(XENLOG_ERR "The overlay FDT is not a valid Flat Device Tree\n"); + return -EINVAL; + } + + return 0; +} + +/* Count number of nodes till one level of __overlay__ tag. */ +static unsigned int overlay_node_count(const void *overlay_fdt) +{ + unsigned int num_overlay_nodes = 0; + int fragment; + + fdt_for_each_subnode(fragment, overlay_fdt, 0) + { + int subnode; + int overlay; + + overlay = fdt_subnode_offset(overlay_fdt, fragment, "__overlay__"); + + /* + * overlay value can be < 0. But fdt_for_each_subnode() loop checks for + * overlay >= 0. So, no need for a overlay>=0 check here. + */ + fdt_for_each_subnode(subnode, overlay_fdt, overlay) + { + num_overlay_nodes++; + } + } + + return num_overlay_nodes; +} + +static int handle_remove_irq_iommu(struct dt_device_node *device_node) +{ + int rc = 0; + struct domain *d = hardware_domain; + domid_t domid; + unsigned int naddr, len; + unsigned int i, nirq; + + domid = dt_device_used_by(device_node); + + dt_dprintk("Checking if node %s is used by any domain\n", + device_node->full_name); + + /* Remove the node if only it's assigned to domain 0 or domain io. */ + if ( domid != 0 && domid != DOMID_IO ) + { + printk(XENLOG_ERR "Device %s is being used by domain %u. Removing nodes failed\n", + device_node->full_name, domid); + return -EINVAL; + } + + dt_dprintk("Removing node: %s\n", device_node->full_name); + + nirq = dt_number_of_irq(device_node); + + /* Remove IRQ permission */ + for ( i = 0; i < nirq; i++ ) + { + rc = platform_get_irq(device_node, i); + if ( rc < 0 ) + { + printk(XENLOG_ERR "Failed to get IRQ num for device node %s\n", + device_node->full_name); + return -EINVAL; + } + + if ( irq_access_permitted(d, rc) == false ) + { + printk(XENLOG_ERR "IRQ %d is not routed to domain %u\n", rc, + domid); + return -EINVAL; + } + /* + * TODO: We don't handle shared IRQs for now. So, it is assumed that + * the IRQs was not shared with another devices. + */ + rc = irq_deny_access(d, rc); + if ( rc ) + { + printk(XENLOG_ERR "unable to revoke access for irq %u for %s\n", + i, device_node->full_name); + return rc; + } + } + + /* Check if iommu property exists. */ + if ( dt_get_property(device_node, "iommus", &len) ) + { + rc = iommu_remove_dt_device(device_node); + if ( rc != 0 && rc != -ENXIO ) + return rc; + } + + naddr = dt_number_of_address(device_node); + + /* Remove mmio access. */ + for ( i = 0; i < naddr; i++ ) + { + uint64_t addr, size; + + rc = dt_device_get_address(device_node, i, &addr, &size); + if ( rc ) + { + printk(XENLOG_ERR "Unable to retrieve address %u for %s\n", + i, dt_node_full_name(device_node)); + return rc; + } + + rc = iomem_deny_access(d, paddr_to_pfn(addr), + paddr_to_pfn(PAGE_ALIGN(addr + size - 1))); + if ( rc ) + { + printk(XENLOG_ERR "Unable to remove dom%d access to" + " 0x%"PRIx64" - 0x%"PRIx64"\n", + d->domain_id, + addr & PAGE_MASK, PAGE_ALIGN(addr + size) - 1); + return rc; + } + + } + + return rc; +} + +/* Removes all descendants of the given node. */ +static int remove_all_descendant_nodes(struct dt_device_node *device_node) +{ + int rc = 0; + struct dt_device_node *child_node; + + for ( child_node = device_node->child; child_node != NULL; + child_node = child_node->sibling ) + { + if ( child_node->child ) + remove_all_descendant_nodes(child_node); + + rc = handle_remove_irq_iommu(child_node); + if ( rc ) + return rc; + } + + return rc; +} + +/* Remove nodes from dt_host. */ +static int remove_nodes(const struct overlay_track *tracker) +{ + int rc = 0; + struct dt_device_node *overlay_node; + unsigned int j; + + for ( j = 0; j < tracker->num_nodes; j++ ) + { + overlay_node = (struct dt_device_node *)tracker->nodes_address[j]; + if ( overlay_node == NULL ) + { + printk(XENLOG_ERR "Device %s is not present in the tree. Removing nodes failed\n", + overlay_node->full_name); + return -EINVAL; + } + + rc = remove_all_descendant_nodes(overlay_node); + + /* All children nodes are unmapped. Now remove the node itself. */ + rc = handle_remove_irq_iommu(overlay_node); + if ( rc ) + return rc; + + read_lock(&dt_host->lock); + + rc = dt_overlay_remove_node(overlay_node); + if ( rc ) + { + read_unlock(&dt_host->lock); + + return rc; + } + + read_unlock(&dt_host->lock); + } + + return rc; +} + +/* + * First finds the device node to remove. Check if the device is being used by + * any dom and finally remove it from dt_host. IOMMU is already being taken care + * while destroying the domain. + */ +static long handle_remove_overlay_nodes(void *overlay_fdt, + uint32_t overlay_fdt_size) +{ + int rc = 0; + struct overlay_track *entry, *temp, *track; + bool found_entry = false; + + rc = check_overlay_fdt(overlay_fdt, overlay_fdt_size); + if ( rc ) + return rc; + + if ( overlay_node_count(overlay_fdt) == 0 ) + return -EINVAL; + + spin_lock(&overlay_lock); + + /* + * First check if dtbo is correct i.e. it should one of the dtbo which was + * used when dynamically adding the node. + * Limitation: Cases with same node names but different property are not + * supported currently. We are relying on user to provide the same dtbo + * as it was used when adding the nodes. + */ + list_for_each_entry_safe( entry, temp, &overlay_tracker, entry ) + { + if ( memcmp(entry->overlay_fdt, overlay_fdt, overlay_fdt_size) == 0 ) + { + track = entry; + found_entry = true; + break; + } + } + + if ( found_entry == false ) + { + rc = -EINVAL; + + printk(XENLOG_ERR "Cannot find any matching tracker with input dtbo." + " Removing nodes is supported for only prior added dtbo. Please" + " provide a valid dtbo which was used to add the nodes.\n"); + goto out; + + } + + rc = remove_nodes(entry); + + if ( rc ) + { + printk(XENLOG_ERR "Removing node failed\n"); + goto out; + } + + list_del(&entry->entry); + + xfree(entry->dt_host_new); + xfree(entry->fdt); + xfree(entry->overlay_fdt); + + xfree(entry->nodes_address); + + xfree(entry); + +out: + spin_unlock(&overlay_lock); + return rc; +} + +long dt_sysctl(struct xen_sysctl_dt_overlay *op) +{ + long ret; + void *overlay_fdt; + + if ( op->overlay_fdt_size == 0 || op->overlay_fdt_size > KB(500) ) + return -EINVAL; + + overlay_fdt = xmalloc_bytes(op->overlay_fdt_size); + + if ( overlay_fdt == NULL ) + return -ENOMEM; + + ret = copy_from_guest(overlay_fdt, op->overlay_fdt, op->overlay_fdt_size); + if ( ret ) + { + gprintk(XENLOG_ERR, "copy from guest failed\n"); + xfree(overlay_fdt); + + return -EFAULT; + } + + switch ( op->overlay_op ) + { + case XEN_SYSCTL_DT_OVERLAY_REMOVE: + ret = handle_remove_overlay_nodes(overlay_fdt, op->overlay_fdt_size); + xfree(overlay_fdt); + + break; + + default: + xfree(overlay_fdt); + break; + } + + return ret; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h index 2b24d6bfd0..28f7fba98b 100644 --- a/xen/include/public/sysctl.h +++ b/xen/include/public/sysctl.h @@ -1057,6 +1057,24 @@ typedef struct xen_sysctl_cpu_policy xen_sysctl_cpu_policy_t; DEFINE_XEN_GUEST_HANDLE(xen_sysctl_cpu_policy_t); #endif +#if defined(__arm__) || defined (__aarch64__) +/* + * XEN_SYSCTL_dt_overlay + * Performs addition/removal of device tree nodes under parent node using dtbo. + * This does in three steps: + * - Adds/Removes the nodes from dt_host. + * - Adds/Removes IRQ permission for the nodes. + * - Adds/Removes MMIO accesses. + */ +struct xen_sysctl_dt_overlay { + XEN_GUEST_HANDLE_64(void) overlay_fdt; /* IN: overlay fdt. */ + uint32_t overlay_fdt_size; /* IN: Overlay dtb size. */ +#define XEN_SYSCTL_DT_OVERLAY_ADD 1 +#define XEN_SYSCTL_DT_OVERLAY_REMOVE 2 + uint8_t overlay_op; /* IN: Add or remove. */ +}; +#endif + struct xen_sysctl { uint32_t cmd; #define XEN_SYSCTL_readconsole 1 @@ -1087,6 +1105,7 @@ struct xen_sysctl { #define XEN_SYSCTL_livepatch_op 27 /* #define XEN_SYSCTL_set_parameter 28 */ #define XEN_SYSCTL_get_cpu_policy 29 +#define XEN_SYSCTL_dt_overlay 30 uint32_t interface_version; /* XEN_SYSCTL_INTERFACE_VERSION */ union { struct xen_sysctl_readconsole readconsole; @@ -1117,6 +1136,10 @@ struct xen_sysctl { #if defined(__i386__) || defined(__x86_64__) struct xen_sysctl_cpu_policy cpu_policy; #endif + +#if defined(__arm__) || defined (__aarch64__) + struct xen_sysctl_dt_overlay dt_overlay; +#endif uint8_t pad[128]; } u; }; diff --git a/xen/include/xen/dt-overlay.h b/xen/include/xen/dt-overlay.h new file mode 100644 index 0000000000..5b369f8eb7 --- /dev/null +++ b/xen/include/xen/dt-overlay.h @@ -0,0 +1,58 @@ + /* SPDX-License-Identifier: GPL-2.0 */ + /* + * xen/dt-overlay.h + * + * Device tree overlay support in Xen. + * + * Copyright (C) 2023, Advanced Micro Devices, Inc. All Rights Reserved. + * Written by Vikram Garhwal + * + */ +#ifndef __XEN_DT_OVERLAY_H__ +#define __XEN_DT_OVERLAY_H__ + +#include +#include +#include +#include + +/* + * overlay_node_track describes information about added nodes through dtbo. + * @entry: List pointer. + * @dt_host_new: Pointer to the updated dt_host_new unflattened 'updated fdt'. + * @fdt: Stores the fdt. + * @nodes_fullname: Stores the full name of nodes. + * @nodes_irq: Stores the IRQ added from overlay dtb. + * @node_num_irq: Stores num of IRQ for each node in overlay dtb. + * @num_nodes: Stores total number of nodes in overlay dtb. + */ +struct overlay_track { + struct list_head entry; + struct dt_device_node *dt_host_new; + void *fdt; + void *overlay_fdt; + unsigned long *nodes_address; + unsigned int num_nodes; +}; + +struct xen_sysctl_dt_overlay; + +#ifdef CONFIG_OVERLAY_DTB +long dt_sysctl(struct xen_sysctl_dt_overlay *op); +#else +static inline long dt_sysctl(struct xen_sysctl_dt_overlay *op) +{ + return -ENOSYS; +} +#endif +#endif + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue May 02 23:38:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 23:38:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528873.822650 (Exim 4.92) (envelope-from ) id 1ptzZ9-00017l-NO; Tue, 02 May 2023 23:37:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528873.822650; Tue, 02 May 2023 23:37:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzZ8-000150-TA; Tue, 02 May 2023 23:37:50 +0000 Received: by outflank-mailman (input) for mailman id 528873; Tue, 02 May 2023 23:37:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzZ6-0005Si-Om for xen-devel@lists.xenproject.org; Tue, 02 May 2023 23:37:48 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2060f.outbound.protection.outlook.com [2a01:111:f400:7eaa::60f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 56cde790-e942-11ed-8611-37d641c3527e; Wed, 03 May 2023 01:37:46 +0200 (CEST) Received: from BN9PR03CA0251.namprd03.prod.outlook.com (2603:10b6:408:ff::16) by DM4PR12MB7647.namprd12.prod.outlook.com (2603:10b6:8:105::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Tue, 2 May 2023 23:37:43 +0000 Received: from BN8NAM11FT101.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ff:cafe::8) by BN9PR03CA0251.outlook.office365.com (2603:10b6:408:ff::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31 via Frontend Transport; Tue, 2 May 2023 23:37:43 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT101.mail.protection.outlook.com (10.13.177.126) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.21 via Frontend Transport; Tue, 2 May 2023 23:37:42 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 2 May 2023 18:37:40 -0500 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 2 May 2023 18:37:40 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 56cde790-e942-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d+CBlD4/N0WIl6ao3jV5P6Wv5qMbul26Yjh9mI5DwgaymAwiNKw/amRYWmNZGTfp3fzAjzcZxOOTBagXx6zCsqBe2j09bhcCT8qUR9nFYsCw5ayia2K3EzKm9z+c2ipeXZBpcSDGZaAk+Q7d9Htoh0EUxOhPCn8WiKJZle0AQSWfs/zNpnGwjlDif25uhC7XNH/at8OQUtnFaueowFB01OA7/aNKJT3WwUm/LLJNB18XuvNJgtbpVR7w1jn9XY9Cwy5KLHLV0H1Zqu+GVQWthMcMLEouOl0u5z814f1JTb7GIbDRj221ltOVe/YZ5k9dcHhKJhQckzZrLSZSTsW+Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DAz4bXIcLBaNxB7D8chHRJkgDHozUzgRvSx6fTSNQTA=; b=F7HyEkG+GLwlElxdZczQOhg9mmuvbLSMRxkaOk6v9qgRuZIvRupd+6El8aa1WkB+eDy78qsDEP3ZWq3PeeHMJQLJipyRtbzeZquFPSrFFX6Sluu8MlD9M0qmYs+DnAvyxS+VsAQOdmD16YNNTobdS6+ts1/DKfElwkd3xjShBt1g/NeA6g/MBd32CvU+IGqF3AIAJimRN1w43GtiBNTx6+wW6GEkS2K4fZvMZ0iogVma8zhuXpje8DyuaG8Rz0XJidZ2t+WVefKlayhCJGOoc+KOcKJsIFuZrfnrHjYUb889soCDbOY1adXtiyNZMmjnaEQxCN9d3Goa8keIakrX3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DAz4bXIcLBaNxB7D8chHRJkgDHozUzgRvSx6fTSNQTA=; b=tvwnbBv0YwQoW7fIrtmBRyeA/qbvHPPniXYcQF5dZLJDTAj1ggmq3qLLyoBs75aSCqiDKKkW+9E50/THsMvuilQAJP+PSMeUzZ3ge5W9CnBLylvVHGemuCzZceD23O46wQuhIcXpfHg+Lamascd6G4qNHHk0eKi7qeUBaVSKsw4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , , , Andrew Cooper , "George Dunlap" , Jan Beulich , "Julien Grall" , Wei Liu Subject: [XEN][PATCH v6 16/19] xen/arm: Implement device tree node addition functionalities Date: Tue, 2 May 2023 16:36:47 -0700 Message-ID: <20230502233650.20121-17-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230502233650.20121-1-vikram.garhwal@amd.com> References: <20230502233650.20121-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT101:EE_|DM4PR12MB7647:EE_ X-MS-Office365-Filtering-Correlation-Id: 70cb53a0-6b2e-4327-0398-08db4b6639b3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1hPgD0kpSyOEMfq6/nPxjohfDV4v+5ckgSAvz0uL7Xh2ayAcX333ubGPBXhgr9M4Y8QQuaaD/t26ORibFv3saFNqXXJzWpW27YcQJdXklOyVITQyWTcWkKhkR3LpE0mhAatM2zqzScbsjodCUYigyhO9VYuT3qwbExXOuaLpzLJ7CNFkh/luYDSEqrI7kRig/0gNyKL1EORQcPgfNJ2iVBwGGv7wgoocxgoPLLAH6bhef78rD8caJ98SrFy6ipMK8A8VlCZS/1U4RFbfK+G8zYajluUuBnUHkzIiW6qInYciCaDLQ+lcNuNVhOIJRfstvPRyK265gKVcC/ikmgy2aDGdcHeJ6m2Epq4dW7LTia2pFWwFvLEK3OmZysf8kSMJOqZzE90ajzTSe7mDtva1cjQVKjHDTr72NjqJe9rTfIlj+nkwEuR1mdKe4VOS19YogYQIbEgLtqkvmE1hr1fD+SL6ZqDYAGRxqqvvumQWHkHgf4K8/9+0ujSnQGPZ874SMrUq51dMbv8nfHUUD6uov6aofwBfRMTr5ka2ndauqP6IOFjD9SAazAW2nZrKpzN88d5AkmQwHxFc9kT3XUtfZZZ1n4n+VpoH1gQ5gZsT4K+68kDYlt02Ye4+ocVAQPQdwPzuTQG45f1j81QG/hn8YbhDGyZ5Iodrqxh5Kx++bDNwVaoU9qNmlkLKj/BEPfq/4ztuuMhYPtl6VtGYLrzh9AAy6L/2XEfjheeDrOXE//Y= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(376002)(136003)(396003)(451199021)(40470700004)(36840700001)(46966006)(30864003)(66899021)(426003)(44832011)(4326008)(82310400005)(36860700001)(336012)(83380400001)(47076005)(2906002)(5660300002)(8936002)(8676002)(41300700001)(36756003)(316002)(186003)(26005)(70586007)(70206006)(6916009)(1076003)(356005)(81166007)(40460700003)(82740400003)(54906003)(86362001)(2616005)(40480700001)(478600001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 23:37:42.9525 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 70cb53a0-6b2e-4327-0398-08db4b6639b3 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT101.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7647 Update sysctl XEN_SYSCTL_dt_overlay to enable support for dtbo nodes addition using device tree overlay. xl dt-overlay add file.dtbo: Each time overlay nodes are added using .dtbo, a new fdt(memcpy of device_tree_flattened) is created and updated with overlay nodes. This updated fdt is further unflattened to a dt_host_new. Next, it checks if any of the overlay nodes already exists in the dt_host. If overlay nodes doesn't exist then find the overlay nodes in dt_host_new, find the overlay node's parent in dt_host and add the nodes as child under their parent in the dt_host. The node is attached as the last node under target parent. Finally, add IRQs, add device to IOMMUs, set permissions and map MMIO for the overlay node. When a node is added using overlay, a new entry is allocated in the overlay_track to keep the track of memory allocation due to addition of overlay node. This is helpful for freeing the memory allocated when a device tree node is removed. The main purpose of this to address first part of dynamic programming i.e. making xen aware of new device tree node which means updating the dt_host with overlay node information. Here we are adding/removing node from dt_host, and checking/setting IOMMU and IRQ permission but never mapping them to any domain. Right now, mapping/Un-mapping will happen only when a new domU is created/destroyed using "xl create". Signed-off-by: Vikram Garhwal --- xen/common/dt-overlay.c | 510 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 510 insertions(+) diff --git a/xen/common/dt-overlay.c b/xen/common/dt-overlay.c index b89cceab84..09ea46111b 100644 --- a/xen/common/dt-overlay.c +++ b/xen/common/dt-overlay.c @@ -33,6 +33,25 @@ static struct dt_device_node * return child_node; } +/* + * Returns next node to the input node. If node has children then return + * last descendant's next node. +*/ +static struct dt_device_node * +dt_find_next_node(struct dt_device_node *dt, const struct dt_device_node *node) +{ + struct dt_device_node *np; + + dt_for_each_device_node(dt, np) + if ( np == node ) + break; + + if ( np->child ) + np = find_last_descendants_node(np); + + return np->allnext; +} + static int dt_overlay_remove_node(struct dt_device_node *device_node) { struct dt_device_node *np; @@ -106,6 +125,76 @@ static int dt_overlay_remove_node(struct dt_device_node *device_node) return 0; } +static int dt_overlay_add_node(struct dt_device_node *device_node, + const char *parent_node_path) +{ + struct dt_device_node *parent_node; + struct dt_device_node *next_node; + + parent_node = dt_find_node_by_path(parent_node_path); + + if ( parent_node == NULL ) + { + dt_dprintk("Parent node %s not found. Overlay node will not be added\n", + parent_node_path); + return -EINVAL; + } + + /* If parent has no child. */ + if ( parent_node->child == NULL ) + { + next_node = parent_node->allnext; + device_node->parent = parent_node; + parent_node->allnext = device_node; + parent_node->child = device_node; + } + else + { + struct dt_device_node *np; + /* If parent has at least one child node. + * Iterate to the last child node of parent. + */ + for ( np = parent_node->child; np->sibling != NULL; np = np->sibling ); + + /* Iterate over all child nodes of np node. */ + if ( np->child ) + { + struct dt_device_node *np_last_descendant; + + np_last_descendant = find_last_descendants_node(np); + + next_node = np_last_descendant->allnext; + np_last_descendant->allnext = device_node; + } + else + { + next_node = np->allnext; + np->allnext = device_node; + } + + device_node->parent = parent_node; + np->sibling = device_node; + np->sibling->sibling = NULL; + } + + /* Iterate over all child nodes of device_node to add children too. */ + if ( device_node->child ) + { + struct dt_device_node *device_node_last_descendant; + + device_node_last_descendant = find_last_descendants_node(device_node); + /* Plug next_node at the end of last children of device_node. */ + device_node_last_descendant->allnext = next_node; + } + else + { + /* Now plug next_node at the end of device_node. */ + device_node->allnext = next_node; + } + + return 0; +} + /* Basic sanity check for the dtbo tool stack provided to Xen. */ static int check_overlay_fdt(const void *overlay_fdt, uint32_t overlay_fdt_size) { @@ -145,6 +234,82 @@ static unsigned int overlay_node_count(const void *overlay_fdt) return num_overlay_nodes; } +/* + * overlay_get_nodes_info gets full name with path for all the nodes which + * are in one level of __overlay__ tag. This is useful when checking node for + * duplication i.e. dtbo tries to add nodes which already exists in device tree. + */ +static int overlay_get_nodes_info(const void *fdto, char ***nodes_full_path, + unsigned int num_overlay_nodes) +{ + int fragment; + + *nodes_full_path = xzalloc_bytes(num_overlay_nodes * sizeof(char *)); + + if ( *nodes_full_path == NULL ) + return -ENOMEM; + + fdt_for_each_subnode(fragment, fdto, 0) + { + int target; + int overlay; + int subnode; + const char *target_path; + + target = fdt_overlay_target_offset(device_tree_flattened, fdto, + fragment, &target_path); + if ( target < 0 ) + return target; + + if ( target_path == NULL ) + return -EINVAL; + + overlay = fdt_subnode_offset(fdto, fragment, "__overlay__"); + + /* + * overlay value can be < 0. But fdt_for_each_subnode() loop checks for + * overlay >= 0. So, no need for a overlay>=0 check here. + */ + fdt_for_each_subnode(subnode, fdto, overlay) + { + const char *node_name = NULL; + int node_name_len; + unsigned int target_path_len = strlen(target_path); + unsigned int node_full_name_len; + unsigned int node_num = 0; + + node_name = fdt_get_name(fdto, subnode, &node_name_len); + + if ( node_name == NULL ) + return node_name_len; + + /* + * Magic number 2 is for adding '/' and '\0'. This is done to keep + * the node_full_path in the correct full node name format. + */ + node_full_name_len = target_path_len + node_name_len + 2; + + (*nodes_full_path)[node_num] = xmalloc_bytes(node_full_name_len); + + if ( (*nodes_full_path)[node_num] == NULL ) + return -ENOMEM; + + memcpy((*nodes_full_path)[node_num], target_path, target_path_len); + + (*nodes_full_path)[node_num][target_path_len] = '/'; + + memcpy((*nodes_full_path)[node_num] + target_path_len + 1, + node_name, node_name_len); + + (*nodes_full_path)[node_num][node_full_name_len - 1] = '\0'; + + node_num++; + } + } + + return 0; +} + static int handle_remove_irq_iommu(struct dt_device_node *device_node) { int rc = 0; @@ -371,6 +536,344 @@ out: return rc; } +/* + * Handles IRQ and IOMMU mapping for the overlay_node and all descendants of the + * overlay_node. + */ +static int handle_add_irq_iommu(struct domain *d, + struct dt_device_node *overlay_node) +{ + int rc; + unsigned int naddr, i, len; + struct dt_device_node *np; + + /* First let's handle the interrupts. */ + rc = handle_device_interrupts(d, overlay_node, false); + if ( rc < 0 ) + { + printk(XENLOG_ERR "Failed to retrieve interrupts configuration\n"); + return rc; + } + + /* Check if iommu property exists. */ + if ( dt_get_property(overlay_node, "iommus", &len) ) + { + /* Add device to IOMMUs. */ + rc = iommu_add_dt_device(overlay_node); + if ( rc < 0 ) + { + printk(XENLOG_ERR "Failed to add %s to the IOMMU\n", + dt_node_full_name(overlay_node)); + return rc; + } + } + + /* Set permissions. */ + naddr = dt_number_of_address(overlay_node); + + dt_dprintk("%s naddr = %u\n", dt_node_full_name(overlay_node), naddr); + + /* Give permission to map MMIOs */ + for ( i = 0; i < naddr; i++ ) + { + uint64_t addr, size; + + /* + * For now, we skip_mapping which means it will only permit iomem access + * to hardware_domain using iomem_permit_access() but will never map as + * map_range_p2mt() will not be called. + */ + struct map_range_data mr_data = { .d = d, + .p2mt = p2m_mmio_direct_c, + .skip_mapping = true + }; + + rc = dt_device_get_address(overlay_node, i, &addr, &size); + if ( rc ) + { + printk(XENLOG_ERR "Unable to retrieve address %u for %s\n", + i, dt_node_full_name(overlay_node)); + return rc; + } + + rc = map_range_to_domain(overlay_node, addr, size, &mr_data); + if ( rc ) + return rc; + } + + /* Map IRQ and IOMMU for overlay_node's children. */ + for ( np = overlay_node->child; np != NULL; np = np->sibling ) + { + rc = handle_add_irq_iommu(d, np); + if ( rc ) + { + printk(XENLOG_ERR "Adding IRQ and IOMMU failed\n"); + return rc; + } + } + + return rc; +} + +/* + * Adds device tree nodes under target node. + * We use tr->dt_host_new to unflatten the updated device_tree_flattened. This + * is done to avoid the removal of device_tree generation, iomem regions mapping + * to hardware domain done by handle_node(). + */ +static long handle_add_overlay_nodes(void *overlay_fdt, + uint32_t overlay_fdt_size) +{ + int rc, j, i; + struct dt_device_node *overlay_node; + struct overlay_track *tr = NULL; + char **nodes_full_path = NULL; + unsigned int new_fdt_size; + + tr = xzalloc(struct overlay_track); + if ( tr == NULL ) + return -ENOMEM; + + new_fdt_size = fdt_totalsize(device_tree_flattened) + + fdt_totalsize(overlay_fdt); + + tr->fdt = xzalloc_bytes(new_fdt_size); + if ( tr->fdt == NULL ) + { + xfree(tr); + return -ENOMEM; + } + + tr->num_nodes = overlay_node_count(overlay_fdt); + if ( tr->num_nodes == 0 ) + { + xfree(tr->fdt); + xfree(tr); + return -ENOMEM; + } + + tr->nodes_address = xzalloc_bytes(tr->num_nodes * sizeof(unsigned long)); + if ( tr->nodes_address == NULL ) + { + xfree(tr->fdt); + xfree(tr); + return -ENOMEM; + } + + rc = check_overlay_fdt(overlay_fdt, overlay_fdt_size); + if ( rc ) + { + xfree(tr->nodes_address); + xfree(tr->fdt); + xfree(tr); + return rc; + } + + /* + * Keep a copy of overlay_fdt as fdt_overlay_apply will change the input + * overlay's content(magic) when applying overlay. + */ + tr->overlay_fdt = xzalloc_bytes(overlay_fdt_size); + if ( tr->overlay_fdt == NULL ) + { + xfree(tr->nodes_address); + xfree(tr->fdt); + xfree(tr); + return -ENOMEM; + } + + memcpy(tr->overlay_fdt, overlay_fdt, overlay_fdt_size); + + spin_lock(&overlay_lock); + + memcpy(tr->fdt, device_tree_flattened, + fdt_totalsize(device_tree_flattened)); + + /* Open tr->fdt with more space to accommodate the overlay_fdt. */ + rc = fdt_open_into(tr->fdt, tr->fdt, new_fdt_size); + if ( rc ) + { + printk(XENLOG_ERR "Increasing tr->fdt size failed with error %d\n", + rc); + goto err; + } + + /* + * overlay_get_nodes_info is called to get the node information from dtbo. + * This is done before fdt_overlay_apply() because the overlay apply will + * erase the magic of overlay_fdt. + */ + rc = overlay_get_nodes_info(overlay_fdt, &nodes_full_path, + tr->num_nodes); + if ( rc ) + { + printk(XENLOG_ERR "Getting nodes information failed with error %d\n", + rc); + goto err; + } + + rc = fdt_overlay_apply(tr->fdt, overlay_fdt); + if ( rc ) + { + printk(XENLOG_ERR "Adding overlay node failed with error %d\n", rc); + goto err; + } + + /* + * Check if any of the node already exists in dt_host. If node already exits + * we can return here as this overlay_fdt is not suitable for overlay ops. + */ + for ( j = 0; j < tr->num_nodes; j++ ) + { + overlay_node = dt_find_node_by_path(nodes_full_path[j]); + if ( overlay_node != NULL ) + { + printk(XENLOG_ERR "node %s exists in device tree\n", + nodes_full_path[j]); + rc = -EINVAL; + goto err; + } + } + + /* Unflatten the tr->fdt into a new dt_host. */ + rc = unflatten_device_tree(tr->fdt, &tr->dt_host_new); + if ( rc ) + { + printk(XENLOG_ERR "unflatten_device_tree failed with error %d\n", rc); + goto err; + } + + for ( j = 0; j < tr->num_nodes; j++ ) + { + struct dt_device_node *prev_node, *next_node; + + dt_dprintk("Adding node: %s\n", nodes_full_path[j]); + + /* Find the newly added node in tr->dt_host_new by it's full path. */ + overlay_node = device_tree_find_node_by_path(tr->dt_host_new, + nodes_full_path[j]); + if ( overlay_node == NULL ) + { + /* Sanity check. But code will never come here. */ + ASSERT_UNREACHABLE(); + goto remove_node; + } + + /* + * Find previous and next node to overlay_node in dt_host_new. We will + * need these nodes to fix the dt_host_new mapping. When overlay_node is + * take out of dt_host_new tree and added to dt_host, link between + * previous node and next_node is broken. We will need to refresh + * dt_host_new with correct linking for any other overlay nodes + * extraction in future. + */ + dt_for_each_device_node(tr->dt_host_new, prev_node) + if ( prev_node->allnext == overlay_node ) + break; + + next_node = dt_find_next_node(tr->dt_host_new, overlay_node); + + read_lock(&dt_host->lock); + + /* Add the node to dt_host. */ + rc = dt_overlay_add_node(overlay_node, overlay_node->parent->full_name); + if ( rc ) + { + read_unlock(&dt_host->lock); + + /* Node not added in dt_host. */ + goto remove_node; + } + + read_unlock(&dt_host->lock); + + prev_node->allnext = next_node; + + overlay_node = dt_find_node_by_path(overlay_node->full_name); + if ( overlay_node == NULL ) + { + /* Sanity check. But code will never come here. */ + ASSERT_UNREACHABLE(); + goto remove_node; + } + + rc = handle_add_irq_iommu(hardware_domain, overlay_node); + if ( rc ) + { + printk(XENLOG_ERR "Adding IRQ and IOMMU failed\n"); + return rc; + } + + /* Keep overlay_node address in tracker. */ + tr->nodes_address[j] = (unsigned long)overlay_node; + } + + INIT_LIST_HEAD(&tr->entry); + list_add_tail(&tr->entry, &overlay_tracker); + + spin_unlock(&overlay_lock); + + if ( nodes_full_path != NULL ) + { + for ( i = 0; i < tr->num_nodes && nodes_full_path[i] != NULL; + i++ ) + { + xfree(nodes_full_path[i]); + } + xfree(nodes_full_path); + } + + return rc; + +/* + * Failure case. We need to remove the nodes, free tracker(if tr exists) and + * tr->dt_host_new. + */ +remove_node: + tr->num_nodes = j; + rc = remove_nodes(tr); + + if ( rc ) + { + /* + * User needs to provide right overlay. Incorrect node information + * example parent node doesn't exist in dt_host etc can cause memory + * leaks as removing_nodes() will fail and this means nodes memory is + * not freed from tracker. Which may cause memory leaks. Ideally, these + * device tree related mistakes will be caught by fdt_overlay_apply() + * but given that we don't manage that code keeping this warning message + * is better here. + */ + printk(XENLOG_ERR "Removing node failed.\n"); + spin_unlock(&overlay_lock); + return rc; + } + +err: + spin_unlock(&overlay_lock); + + if ( tr->dt_host_new ) + xfree(tr->dt_host_new); + + xfree(tr->overlay_fdt); + xfree(tr->nodes_address); + xfree(tr->fdt); + + if ( nodes_full_path != NULL ) + { + for ( i = 0; i < tr->num_nodes && nodes_full_path[i] != NULL; + i++ ) + { + xfree(nodes_full_path[i]); + } + xfree(nodes_full_path); + } + + xfree(tr); + + return rc; +} + long dt_sysctl(struct xen_sysctl_dt_overlay *op) { long ret; @@ -395,6 +898,13 @@ long dt_sysctl(struct xen_sysctl_dt_overlay *op) switch ( op->overlay_op ) { + case XEN_SYSCTL_DT_OVERLAY_ADD: + ret = handle_add_overlay_nodes(overlay_fdt, op->overlay_fdt_size); + if ( ret ) + xfree(overlay_fdt); + + break; + case XEN_SYSCTL_DT_OVERLAY_REMOVE: ret = handle_remove_overlay_nodes(overlay_fdt, op->overlay_fdt_size); xfree(overlay_fdt); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue May 02 23:39:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 23:39:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528894.822675 (Exim 4.92) (envelope-from ) id 1ptzaF-0005p9-PG; Tue, 02 May 2023 23:38:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528894.822675; Tue, 02 May 2023 23:38:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzaF-0005on-LD; Tue, 02 May 2023 23:38:59 +0000 Received: by outflank-mailman (input) for mailman id 528894; Tue, 02 May 2023 23:38:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzZ7-0004sC-Lr for xen-devel@lists.xenproject.org; Tue, 02 May 2023 23:37:49 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2061e.outbound.protection.outlook.com [2a01:111:f400:7eab::61e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 582050bd-e942-11ed-b225-6b7b168915f2; Wed, 03 May 2023 01:37:49 +0200 (CEST) Received: from BN9PR03CA0269.namprd03.prod.outlook.com (2603:10b6:408:ff::34) by DS0PR12MB6559.namprd12.prod.outlook.com (2603:10b6:8:d1::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.20; Tue, 2 May 2023 23:37:45 +0000 Received: from BN8NAM11FT101.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ff:cafe::2c) by BN9PR03CA0269.outlook.office365.com (2603:10b6:408:ff::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31 via Frontend Transport; Tue, 2 May 2023 23:37:45 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT101.mail.protection.outlook.com (10.13.177.126) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.21 via Frontend Transport; Tue, 2 May 2023 23:37:45 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 2 May 2023 18:37:43 -0500 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 2 May 2023 18:37:42 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 582050bd-e942-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DROLClaF+aGH7NYS5zydzrPTP4mibpTNPe0ZoUB0bNtEgTnF7SV6zAwcvfmxH3k8vXh0kFr3FltTZ9r851MD1pbZeZ/2Y4GGAoUmC64jqHyT7oieI4BlyMayUPqlbrzPZJn3JKnhqRFvb8RmEVY5yDj3/msJR0MkBMAoZ0c9ubGZvmUG2Yyys/8mVGJEcIl2fVFRZ0TwB9LKsNidCjRYK7wBxEqI/KqTn93UHrmDTqRLM29+5bA1ptTsEN68F3xU7vt02WgfzTenO1Fqst1MWPbqytuWEtf/l5x/iEshJ8RaTYN/OuC0iJ+NEP7qMrT8EHhgWnYhsXIVB9VysQAgow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W8ANf04rvVBwwTVoSmk1wMh7BnV4jbgpw3PgliDnkIY=; b=T9QZoJnBB2xOZ1/jmK/an5wpiebV1ZJURBqpIOADuHLmDou8E6zhHXpMY3idjmzyiHZghWswDPZsaf07fVuWeVaHQIWUTk7wf5jApo5WaBXs5vsBpn/23OUeCky6wA4v7cpeyQnBNkBviXD+oUiosL/uYaYBSwX3kr74lqjs3fszIw8ay97Gyj0sYnAD9I5a7ZBU216h4WztFF72nJ/F/WsAae5RCRNMmXiukDov2K5RinaWmAT9tMRsA1w+sWhZpsfiRDfgCjOvS3RMyaSH9aJuDxdaRb4WN3Vgrq3YmyJRnvCB/ioixZc+VV89Sj1xEsSqh5QWYr6n8Zz5H9EPZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W8ANf04rvVBwwTVoSmk1wMh7BnV4jbgpw3PgliDnkIY=; b=mfMEDx1uFImG7A79WBozqHEF2QaRa5nkflQ1zG9Mp0jlMowT7VOk82LRmrBYQfGZDBCBnpgATlgNfzKix+vIYo4VbAU6H9liO3KEs+CYIjNkz/fSrX4+cOhbflIktTiB+vr4TSuOhNIgM1lMUj28Xv853meqj4V/feAdQPZpnls= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , , , Wei Liu , Anthony PERARD Subject: [XEN][PATCH v6 19/19] tools/xl: Add new xl command overlay for device tree overlay support Date: Tue, 2 May 2023 16:36:50 -0700 Message-ID: <20230502233650.20121-20-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230502233650.20121-1-vikram.garhwal@amd.com> References: <20230502233650.20121-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT101:EE_|DS0PR12MB6559:EE_ X-MS-Office365-Filtering-Correlation-Id: 87db793a-0ce9-45e1-14f2-08db4b663b0f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5Ky0jDQ4nyKCJRDumE86REXWu2MwxLdK/N4E2ZhzE8ccdaSyv3yNRoPZcsBcI9fQGC1FFQ/fuGX/KAekGKo6JCmQo+ouL+BxL123Vhxn60oV76fmKva9JBNBWOfuMEUH9voXJHENWv8N22JPCO26FT0XR1OT9seGW9JnX4p0redjuQ7qAAGFxLsHDhDB0ggjl+HHJeiBhSGfRJhD3ikXu72OwkfaSYS5bWHGKlInr4B1K5p9N5aanBizbmTHGlN1pgUgQX3rSMf2c7l7zFRCvAhjeoC18ebw/S8OwmNrf5aBIYL18q3kKRXSQVqiuAhpxeZAowrLBMCideSLROGISJ06GfSo8FWUxf+jypIXCJPmwGYT0jPWrsR4l8GCCpJjtmi29Jvax1Ed9gInCVCh6JmtKRwhkcRo27MU0oGdbLYkBcoTnvuuFz6mfoA4ndvHW6AUFxWiJA2IsVSsXUdD2FqsPGOcOZXH3bs7/gVpITYaJCTM9nrjVGmLCV24FsGrjawGG+1UM313zXFLcq5GB6MHVQ/0HU6bR7gJDhaFdK9VB/iNnzZbYxSUW8EdZJdsLfbxsnR1v0nlWHtASoCs5KFNuWFnfGe2Ji9uR5nMwjSMt2R9ZCPJw8aOZOi9A8zdLYopXEkBmVdxLdOx+C9ZGJykxd28HM6La4dK1GWl3S3Z7O9C3VRTneCMX0RyorMCAsI/GPgWuT0fl2/RsGRNNEWRPCHSl1V8urf9CMN8nmU= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(39860400002)(396003)(136003)(451199021)(40470700004)(46966006)(36840700001)(356005)(2906002)(81166007)(1076003)(82740400003)(186003)(26005)(6666004)(47076005)(36860700001)(2616005)(82310400005)(336012)(426003)(36756003)(44832011)(40460700003)(5660300002)(54906003)(478600001)(86362001)(83380400001)(8936002)(8676002)(41300700001)(6916009)(70206006)(70586007)(316002)(40480700001)(4326008)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 23:37:45.2336 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 87db793a-0ce9-45e1-14f2-08db4b663b0f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT101.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6559 Signed-off-by: Vikram Garhwal --- tools/xl/xl.h | 1 + tools/xl/xl_cmdtable.c | 6 +++++ tools/xl/xl_vmcontrol.c | 52 +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 59 insertions(+) diff --git a/tools/xl/xl.h b/tools/xl/xl.h index 72538d6a81..a923daccd3 100644 --- a/tools/xl/xl.h +++ b/tools/xl/xl.h @@ -138,6 +138,7 @@ int main_shutdown(int argc, char **argv); int main_reboot(int argc, char **argv); int main_list(int argc, char **argv); int main_vm_list(int argc, char **argv); +int main_dt_overlay(int argc, char **argv); int main_create(int argc, char **argv); int main_config_update(int argc, char **argv); int main_button_press(int argc, char **argv); diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c index ccf4d83584..db0acff62a 100644 --- a/tools/xl/xl_cmdtable.c +++ b/tools/xl/xl_cmdtable.c @@ -630,6 +630,12 @@ const struct cmd_spec cmd_table[] = { "Issue a qemu monitor command to the device model of a domain", " ", }, + { "dt-overlay", + &main_dt_overlay, 0, 1, + "Add/Remove a device tree overlay", + "add/remove <.dtbo>" + "-h print this help\n" + }, }; const int cmdtable_len = ARRAY_SIZE(cmd_table); diff --git a/tools/xl/xl_vmcontrol.c b/tools/xl/xl_vmcontrol.c index 5518c78dc6..de56e00d8b 100644 --- a/tools/xl/xl_vmcontrol.c +++ b/tools/xl/xl_vmcontrol.c @@ -1265,6 +1265,58 @@ int main_create(int argc, char **argv) return 0; } +int main_dt_overlay(int argc, char **argv) +{ + const char *overlay_ops = NULL; + const char *overlay_config_file = NULL; + void *overlay_dtb = NULL; + int rc; + uint8_t op; + int overlay_dtb_size = 0; + const int overlay_add_op = 1; + const int overlay_remove_op = 2; + + if (argc < 2) { + help("dt_overlay"); + return EXIT_FAILURE; + } + + overlay_ops = argv[1]; + overlay_config_file = argv[2]; + + if (strcmp(overlay_ops, "add") == 0) + op = overlay_add_op; + else if (strcmp(overlay_ops, "remove") == 0) + op = overlay_remove_op; + else { + fprintf(stderr, "Invalid dt overlay operation\n"); + return EXIT_FAILURE; + } + + if (overlay_config_file) { + rc = libxl_read_file_contents(ctx, overlay_config_file, + &overlay_dtb, &overlay_dtb_size); + + if (rc) { + fprintf(stderr, "failed to read the overlay device tree file %s\n", + overlay_config_file); + free(overlay_dtb); + return ERROR_FAIL; + } + } else { + fprintf(stderr, "overlay dtbo file not provided\n"); + return ERROR_FAIL; + } + + rc = libxl_dt_overlay(ctx, overlay_dtb, overlay_dtb_size, op); + + free(overlay_dtb); + + if (rc) + return EXIT_FAILURE; + + return rc; +} /* * Local variables: * mode: C -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue May 02 23:39:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 23:39:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528899.822685 (Exim 4.92) (envelope-from ) id 1ptzaH-00065C-10; Tue, 02 May 2023 23:39:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528899.822685; Tue, 02 May 2023 23:39:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzaG-000655-Tg; Tue, 02 May 2023 23:39:00 +0000 Received: by outflank-mailman (input) for mailman id 528899; Tue, 02 May 2023 23:38:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzZ8-0005Si-KC for xen-devel@lists.xenproject.org; Tue, 02 May 2023 23:37:50 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2061b.outbound.protection.outlook.com [2a01:111:f400:7e88::61b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5852231d-e942-11ed-8611-37d641c3527e; Wed, 03 May 2023 01:37:48 +0200 (CEST) Received: from BN9PR03CA0269.namprd03.prod.outlook.com (2603:10b6:408:ff::34) by MW3PR12MB4441.namprd12.prod.outlook.com (2603:10b6:303:59::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 23:37:44 +0000 Received: from BN8NAM11FT101.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ff:cafe::2c) by BN9PR03CA0269.outlook.office365.com (2603:10b6:408:ff::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31 via Frontend Transport; Tue, 2 May 2023 23:37:44 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT101.mail.protection.outlook.com (10.13.177.126) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.21 via Frontend Transport; Tue, 2 May 2023 23:37:44 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 2 May 2023 18:37:42 -0500 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 2 May 2023 18:37:41 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5852231d-e942-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O9KJvxaJwC7gSbVT/N0kcaG447n665alx2AFy1uWliqBzkmRVikvSOeO+S5Ubpv9EW2JcueM5Ns+LHYlbYnq2CXHnK42OyJIzo7cngq1FoKWKXJ3DhSjBMhpQvTSt1h8JjgB1LMxOR29g0qrnriJlFI2LRg0QdJfoUhmXr3lvOJNfiENv/A8ZVn1j6l6wS0MSe+xWd16iR84yEJZQVZ0BLIWNbeNxflQqJQEfAJQMO3rgNSl7/Ahsuth0O9lY3N3jqlffV6vvLBmhAyZPh+EmCkQUjfxNQlPSpSdVSFxMF0tpwnim08Frz6HPdZhK9yNmXLFa1ciisrAfJF7SwXm2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=91E2KEtRfiC4xks88DcPT08G46pT034ykx3UwRRlezk=; b=bYPfW6hbwLA+thF6ca7CBjdBIlWJxlk0Sg5jlme6Najiqe+bl2kdfgvb97Lr+ujgZnd4yrJVZ8MdH4XyKgWpUl0bQF3ZjeQp7ijqGU8lsZq/G5g6ZqtRNJ5SRa+s+iWE6vldLb98w9LDhKS/ftkDFxl2DCo1IgquGcvjki0aPp57C1FQ7LFKJB5bPpV7XEfq9cQHjeZElRmjpwb1TwPwZQfQxYjbRMglaBJv79zZqksys65Edxe1mcHZ5cgwqZXR5HksP1Hd6gmEwCjMWkaqqZPmMsUQUdA8KDUKxF9M2s4Y0MUfYrHMMc05ILm+6nBeo0dR+Dv7A190Ox9L3rwaEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=91E2KEtRfiC4xks88DcPT08G46pT034ykx3UwRRlezk=; b=hQeYj5zsHKXYLQ5oZ+X59iJtWrHLjoaauVSb5Tg/5IuQt5Vu2d4Z15FmUy4YWG5JY45jxcV6Mn/UmRM7SLJRVyd+CAWee5mFkcfL/V3wyZtDY/djiKDk9/8z/eZnZ1kvSIodkAC+saLlGRKZJlvyxPvaIRZZizMj6eStxABGNhw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , , , Wei Liu , Anthony PERARD , Juergen Gross Subject: [XEN][PATCH v6 18/19] tools/libs/light: Implement new libxl functions for device tree overlay ops Date: Tue, 2 May 2023 16:36:49 -0700 Message-ID: <20230502233650.20121-19-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230502233650.20121-1-vikram.garhwal@amd.com> References: <20230502233650.20121-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT101:EE_|MW3PR12MB4441:EE_ X-MS-Office365-Filtering-Correlation-Id: 5347c826-59cd-4976-0a45-08db4b663a80 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WDRiwXSfCM+NKXNP/23ZDrpZh1shJqPjsyD0mxQbTv1llItNW+0F+6gp6h0+uCV715uKpHYCDSt2Y1WQIXGT+iX9roA/pKCce3QTT7lnpTYZHeWQaUB7EhUZlKuyzOczC7fkm0Z0EMqyCmDdZnTkyCDStaEx5cRm6xUxinC9eEINZhxvH8k4LmpdIdPm43on96NUQLxZKmVXGdYop5XVEy6pEO0aXd6ThHiQKO+bQx2gO4JONuKwuJRAR787zGyKibdnysVIlGPXYTQxt3lXGrC2EkXHeac4+0v5VG3pHU0OhvItI14/9ZiEkjUQbfOrt2mC3zAfgS8Gwd4xFzp8avQeXywY6RKxwMcM2fMyg+jvH3Q2fCwWAR+W2RxRXWF4/Lb1OyhPBu7bO5tKawuRrK3/xk/2HubNPyKJN2z++G68x+6cUEtfq+a3VgY5pJwfSPxdvVMxZKA4/SeYJuzurysfof86jlj3PokCw89qmnYZb41pyaknKgQWmL3pRMoYz+rQ2T1G0GEupxlkpxEafGt1IvihjOz5DyEDWHNZvqSEKH+sPw/1j6w3YtClPsbWI5sittpV1abYsn8H//mvN1VMsTdz3VhQ3DUzeh+QmD8EGba7mCL5Wph1X4G34D0Km0niXBTAJniZzNRG13WnybOhoq5ioKU5JABDwClfiAmfPL8n67pGUr8HZEiWhck7uoeR+/0PqNbZltJ7CiPFbW1BpOGEMvOZGSyuqzwix2+9vrylBuO9x+HVXW3RdaNU X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(39860400002)(136003)(376002)(451199021)(40470700004)(46966006)(36840700001)(478600001)(82310400005)(316002)(2906002)(6916009)(70206006)(70586007)(4326008)(36756003)(40480700001)(86362001)(54906003)(40460700003)(1076003)(8936002)(8676002)(44832011)(2616005)(336012)(426003)(36860700001)(5660300002)(186003)(47076005)(26005)(82740400003)(356005)(81166007)(41300700001)(2004002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 23:37:44.2961 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5347c826-59cd-4976-0a45-08db4b663a80 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT101.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4441 Signed-off-by: Vikram Garhwal --- tools/include/libxl.h | 11 +++++ tools/libs/light/Makefile | 3 ++ tools/libs/light/libxl_dt_overlay.c | 71 +++++++++++++++++++++++++++++ 3 files changed, 85 insertions(+) create mode 100644 tools/libs/light/libxl_dt_overlay.c diff --git a/tools/include/libxl.h b/tools/include/libxl.h index cfa1a19131..1c5e8abaae 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -250,6 +250,12 @@ */ #define LIBXL_HAVE_DEVICETREE_PASSTHROUGH 1 +#if defined(__arm__) || defined(__aarch64__) +/** + * This means Device Tree Overlay is supported. + */ +#define LIBXL_HAVE_DT_OVERLAY 1 +#endif /* * libxl_domain_build_info has device_model_user to specify the user to * run the device model with. See docs/misc/qemu-deprivilege.txt. @@ -2453,6 +2459,11 @@ libxl_device_pci *libxl_device_pci_list(libxl_ctx *ctx, uint32_t domid, int *num); void libxl_device_pci_list_free(libxl_device_pci* list, int num); +#if defined(__arm__) || defined(__aarch64__) +int libxl_dt_overlay(libxl_ctx *ctx, void *overlay, + uint32_t overlay_size, uint8_t overlay_op); +#endif + /* * Turns the current process into a backend device service daemon * for a driver domain. diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile index 96daeabc47..563a1e8d0a 100644 --- a/tools/libs/light/Makefile +++ b/tools/libs/light/Makefile @@ -112,6 +112,9 @@ OBJS-y += _libxl_types.o OBJS-y += libxl_flask.o OBJS-y += _libxl_types_internal.o +# Device tree overlay is enabled only for ARM architecture. +OBJS-$(CONFIG_ARM) += libxl_dt_overlay.o + ifeq ($(CONFIG_LIBNL),y) CFLAGS_LIBXL += $(LIBNL3_CFLAGS) endif diff --git a/tools/libs/light/libxl_dt_overlay.c b/tools/libs/light/libxl_dt_overlay.c new file mode 100644 index 0000000000..a6c709a6dc --- /dev/null +++ b/tools/libs/light/libxl_dt_overlay.c @@ -0,0 +1,71 @@ +/* + * Copyright (C) 2021 Xilinx Inc. + * Author Vikram Garhwal + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published + * by the Free Software Foundation; version 2.1 only. with the special + * exception on linking described in file LICENSE. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + */ + +#include "libxl_osdeps.h" /* must come before any other headers */ +#include "libxl_internal.h" +#include +#include + +static int check_overlay_fdt(libxl__gc *gc, void *fdt, size_t size) +{ + int r; + + if (fdt_magic(fdt) != FDT_MAGIC) { + LOG(ERROR, "Overlay FDT is not a valid Flat Device Tree"); + return ERROR_FAIL; + } + + r = fdt_check_header(fdt); + if (r) { + LOG(ERROR, "Failed to check the overlay FDT (%d)", r); + return ERROR_FAIL; + } + + if (fdt_totalsize(fdt) > size) { + LOG(ERROR, "Overlay FDT totalsize is too big"); + return ERROR_FAIL; + } + + return 0; +} + +int libxl_dt_overlay(libxl_ctx *ctx, void *overlay_dt, uint32_t overlay_dt_size, + uint8_t overlay_op) +{ + int rc; + int r; + GC_INIT(ctx); + + if (check_overlay_fdt(gc, overlay_dt, overlay_dt_size)) { + LOG(ERROR, "Overlay DTB check failed"); + rc = ERROR_FAIL; + goto out; + } else { + LOG(DEBUG, "Overlay DTB check passed"); + rc = 0; + } + + r = xc_dt_overlay(ctx->xch, overlay_dt, overlay_dt_size, overlay_op); + + if (r) { + LOG(ERROR, "%s: Adding/Removing overlay dtb failed.", __func__); + rc = ERROR_FAIL; + } + +out: + GC_FREE; + return rc; +} + -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue May 02 23:39:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 23:39:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528915.822695 (Exim 4.92) (envelope-from ) id 1ptzaP-0006X2-9G; Tue, 02 May 2023 23:39:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528915.822695; Tue, 02 May 2023 23:39:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzaP-0006Wt-6M; Tue, 02 May 2023 23:39:09 +0000 Received: by outflank-mailman (input) for mailman id 528915; Tue, 02 May 2023 23:39:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzZ7-0005Si-M1 for xen-devel@lists.xenproject.org; Tue, 02 May 2023 23:37:49 +0000 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on20600.outbound.protection.outlook.com [2a01:111:f400:7e8c::600]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 578e1a5d-e942-11ed-8611-37d641c3527e; Wed, 03 May 2023 01:37:47 +0200 (CEST) Received: from BN9PR03CA0243.namprd03.prod.outlook.com (2603:10b6:408:ff::8) by SN7PR12MB7953.namprd12.prod.outlook.com (2603:10b6:806:345::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.32; Tue, 2 May 2023 23:37:44 +0000 Received: from BN8NAM11FT101.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ff:cafe::1a) by BN9PR03CA0243.outlook.office365.com (2603:10b6:408:ff::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.21 via Frontend Transport; Tue, 2 May 2023 23:37:43 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT101.mail.protection.outlook.com (10.13.177.126) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.21 via Frontend Transport; Tue, 2 May 2023 23:37:43 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 2 May 2023 18:37:41 -0500 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 2 May 2023 18:37:41 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 578e1a5d-e942-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bERWKi0IoKVO4XW7QmAZRl3xJLDoCyjpHNLhXy2w8KqjDAoMs4NvnCUKsP8Ee2WJwWXgEeCIvj5SsNeRzRSw+O9XGQi3DaHdSauVbrSF6eGvT60gHy4K7VsV3+wh8upOth/TCzae97M7vL0vIZiOeZv2A703E7v+v4lRPiqLWAL6GV1FsYA1cZme8c992f2NDqbHxuiatP1xZhUv+cnRLY5Ex39gbw6PeelY5rR3Pis192NKcDft3LuoL3Z3Z7H0avkqt0ha7trY++XL2wodIBgdKunUOBAMXdaLIgiht7Gw3fTELp02mvA6E4lsnx6/wPNTUdL3GBSzZ3Q5DWSVzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EQ8GqVc2MExei+u64NzeTvfYwAOuigBIRcvJ0a0ukt4=; b=TBzHrtkDlEDXZ5Lzf5F99GDULi3RK4nBdtOX21n/x9a6YZTpImEBQ5Whmz29A0Tiz+T/NfvGXC9BxqCIcW0uuBppMH5DBdEtl6xQbhis8jFH471u8+Vw3MQtcZ7sxomqGaK55/VekubFpRxbedk/ZxTLrD0XBozo6xETNhqtPzyG+BR4XAp5aX6FhFqXzHFB753uSVxZfMCf7PUUjqo7k3PVLOg/aNitMpHW3gjSYByVl7OlBQjNEbg2q5s3pnzJ6fTUxO2bEh5cQPJb5QaGu1EHX73zFUEqbtpwbrsJCYSpEGnHxPmZEqhlhJus2bhTs7rQBofRbguO4OEu1E8cyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EQ8GqVc2MExei+u64NzeTvfYwAOuigBIRcvJ0a0ukt4=; b=r3D+eMzSnKuDoXOsPjZC7VuCLArC/Phzl8Bgg+JYBuvvdMKeWbrwes775Dj3DJ/BPoOms52uOzfZHhKdRhrs271X7kb84qsN9vr2UBcMqa6faF1/ue/6u1R3KLiTepvf4V0PNlgPvOHeAxnfWXaljExWAuCiaw7hFz5g2qNWpQU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , , , Wei Liu , Anthony PERARD , Juergen Gross Subject: [XEN][PATCH v6 17/19] tools/libs/ctrl: Implement new xc interfaces for dt overlay Date: Tue, 2 May 2023 16:36:48 -0700 Message-ID: <20230502233650.20121-18-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230502233650.20121-1-vikram.garhwal@amd.com> References: <20230502233650.20121-1-vikram.garhwal@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT101:EE_|SN7PR12MB7953:EE_ X-MS-Office365-Filtering-Correlation-Id: a4a8e144-13c2-4e46-1033-08db4b663a23 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: V8hJH/YlyuhXPweNA4KTn69XI5co255t1TQrBJSBvak61sR9Z3kCIRm5PnYmiv/8VqFuHPWmw23kSZX9Sgkb1NCFN/xGvif9AfKeylD3OvOSJNwhd2tXo0Jma9dFo399P2p40XlneedckLjeWsUFVEm7BNKVYFIjNl8lfhjCPrdSOB593Wr1vI9Wd7xvkCo5n1NopJMXwljxnE23QQVusPVxoAzbYmLh0w86LPSAH93OiSvn2LLcpWfOEeeyNC/bUFw/93dBSLQPXyon8uYIi6bVTtMpWqAXPh9CyRNEwwshjuLmjWx6d/UBUgY2AJFBP4ipLifz4pY65iVwivesH8NYfiqiXMDW4Zk/sOeDyj4K0mjp+znx5UzhcuLhT87RhGxNR3IcnMOLy6NoAsVmZMIJO5VnkHjH0MQbIFsVHDfmeDYziHmTYE+ufpzQkzNnZY+LRCOawJUiStHSrYS5FkzwcWS8sLXjrYUDh6VqFfMSbf2ewn33FRHtTk30RrMBNAGJiSOpRMlJ0pZ+VJlddqBEzd+yUVl4PQYf01N9kA8qgbPmzZdu6yk289xZGJQykT0fIIAgXxBBr+1frpPvXxKB+unoP/6Ad2o+xLMu0kxg7nxtgaqU/3UFHDOXFIw8rqAKt+xEIg5TMRfFUiWKEw5iEiuxBdvGKaSwymKKL42uIU0VmC3zLY6k92kisa9ONiTE9SuDFSZUM+SFTGybctS0pLMx3HwMmy4G43noknm4Di25fqdTgxamn/6aoYA2 X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(39860400002)(136003)(396003)(451199021)(46966006)(36840700001)(40470700004)(5660300002)(36860700001)(1076003)(40480700001)(478600001)(356005)(81166007)(26005)(186003)(82740400003)(54906003)(47076005)(426003)(2616005)(336012)(8676002)(41300700001)(8936002)(4326008)(70206006)(2906002)(316002)(6916009)(44832011)(70586007)(86362001)(36756003)(40460700003)(82310400005)(2004002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 23:37:43.6868 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a4a8e144-13c2-4e46-1033-08db4b663a23 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT101.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7953 xc_dt_overlay() sends the device tree binary overlay, size of .dtbo and overlay operation type i.e. add or remove to xen. Signed-off-by: Vikram Garhwal --- tools/include/xenctrl.h | 5 ++++ tools/libs/ctrl/Makefile.common | 1 + tools/libs/ctrl/xc_dt_overlay.c | 48 +++++++++++++++++++++++++++++++++ 3 files changed, 54 insertions(+) create mode 100644 tools/libs/ctrl/xc_dt_overlay.c diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index 752fc87580..1a99c06561 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -2666,6 +2666,11 @@ int xc_livepatch_replace(xc_interface *xch, char *name, uint32_t timeout, uint32 int xc_domain_cacheflush(xc_interface *xch, uint32_t domid, xen_pfn_t start_pfn, xen_pfn_t nr_pfns); +#if defined(__arm__) || defined(__aarch64__) +int xc_dt_overlay(xc_interface *xch, void *overlay_fdt, + uint32_t overlay_fdt_size, uint8_t overlay_op); +#endif + /* Compat shims */ #include "xenctrl_compat.h" diff --git a/tools/libs/ctrl/Makefile.common b/tools/libs/ctrl/Makefile.common index 0a09c28fd3..247afbe5f9 100644 --- a/tools/libs/ctrl/Makefile.common +++ b/tools/libs/ctrl/Makefile.common @@ -24,6 +24,7 @@ OBJS-y += xc_hcall_buf.o OBJS-y += xc_foreign_memory.o OBJS-y += xc_kexec.o OBJS-y += xc_resource.o +OBJS-$(CONFIG_ARM) += xc_dt_overlay.o OBJS-$(CONFIG_X86) += xc_psr.o OBJS-$(CONFIG_X86) += xc_pagetab.o OBJS-$(CONFIG_Linux) += xc_linux.o diff --git a/tools/libs/ctrl/xc_dt_overlay.c b/tools/libs/ctrl/xc_dt_overlay.c new file mode 100644 index 0000000000..202fc906f4 --- /dev/null +++ b/tools/libs/ctrl/xc_dt_overlay.c @@ -0,0 +1,48 @@ +/* + * + * Device Tree Overlay functions. + * Copyright (C) 2021 Xilinx Inc. + * Author Vikram Garhwal + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; + * version 2.1 of the License. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; If not, see . + */ + +#include "xc_private.h" + +int xc_dt_overlay(xc_interface *xch, void *overlay_fdt, + uint32_t overlay_fdt_size, uint8_t overlay_op) +{ + int err; + DECLARE_SYSCTL; + + DECLARE_HYPERCALL_BOUNCE(overlay_fdt, overlay_fdt_size, + XC_HYPERCALL_BUFFER_BOUNCE_IN); + + if ( (err = xc_hypercall_bounce_pre(xch, overlay_fdt)) ) + goto err; + + sysctl.cmd = XEN_SYSCTL_dt_overlay; + sysctl.u.dt_overlay.overlay_op = overlay_op; + sysctl.u.dt_overlay.overlay_fdt_size = overlay_fdt_size; + + set_xen_guest_handle(sysctl.u.dt_overlay.overlay_fdt, overlay_fdt); + + if ( (err = do_sysctl(xch, &sysctl)) != 0 ) + PERROR("%s failed", __func__); + +err: + xc_hypercall_bounce_post(xch, overlay_fdt); + + return err; +} -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue May 02 23:56:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 May 2023 23:56:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528927.822704 (Exim 4.92) (envelope-from ) id 1ptzqh-0001MK-Rw; Tue, 02 May 2023 23:55:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528927.822704; Tue, 02 May 2023 23:55:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzqh-0001MD-PN; Tue, 02 May 2023 23:55:59 +0000 Received: by outflank-mailman (input) for mailman id 528927; Tue, 02 May 2023 23:55:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptzqg-0001M7-UZ for xen-devel@lists.xenproject.org; Tue, 02 May 2023 23:55:59 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dfb62e28-e944-11ed-8611-37d641c3527e; Wed, 03 May 2023 01:55:54 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 464DE6133A; Tue, 2 May 2023 23:55:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7E40C433D2; Tue, 2 May 2023 23:55:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dfb62e28-e944-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683071752; bh=21q8w7ad/mG6Dz+Zc8o3O6b5fBKnpcih2EQHedK29+8=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=T0y+SeALxGjv7qjOAHnrqgrZT6aZedSmotuF2IoKNPZ8uxf8OkvphYb0qZIo6MFE+ 1NAsx6pVeLibpHQ8TZM/tEvGzTtr5CUajFlDBi+UNyKdtt+I6LYtlbGIe/ztos7pQ6 boF1nDodstjmLzeBx6dDvgyLxCJH0vJglPyMc/gvHZCeG0cN4gpxlBcBU2StAgY7Dm 8dczSL+C5RmIjH2vG/xX1YKaInsCFLpDqgPPIanh2DOP3D3IsoyO1PeP8PMdUTEVEu WDfd7vSPHOZovoZEwt8vKQgafg1f5wvQhWSvG5mv+YfA9zN+nFzsqmKQy3kSi6wC4a nAfVh5kPvrM0Q== Date: Tue, 2 May 2023 16:55:49 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Ayan Kumar Halder cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, stefano.stabellini@amd.com, julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com Subject: Re: [RFC PATCH] xen/arm: arm32: Enable smpboot on Arm32 based systems In-Reply-To: <20230502105849.40677-1-ayan.kumar.halder@amd.com> Message-ID: References: <20230502105849.40677-1-ayan.kumar.halder@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 2 May 2023, Ayan Kumar Halder wrote: > On some of the Arm32 based systems (eg Cortex-R52), smpboot is supported. > In these systems PSCI may not always be supported. In case of Cortex-R52, there > is no EL3 or secure mode. Thus, PSCI is not supported as it requires EL3. > > Thus, we use 'spin-table' mechanism to boot the secondary cpus. The primary > cpu provides the startup address of the secondary cores. This address is > provided using the 'cpu-release-addr' property. > > To support smpboot, we have copied the code from xen/arch/arm/arm64/smpboot.c > with the following changes :- > > 1. 'enable-method' is an optional property. Refer to the comment in > https://www.kernel.org/doc/Documentation/devicetree/bindings/arm/cpus.yaml > " # On ARM 32-bit systems this property is optional" > > 2. psci is not currently supported as a value for 'enable-method'. > > 3. update_identity_mapping() is not invoked as we are not sure if it is > required. > > Signed-off-by: Ayan Kumar Halder > --- > > The dts snippet with which this has been validated is :- > > cpus { > #address-cells = <0x02>; > #size-cells = <0x00>; > > cpu-map { > > cluster0 { > > core0 { > > thread0 { > cpu = <0x02>; > }; > }; > core1 { > > thread0 { > cpu = <0x03>; > }; > }; > }; > }; > > cpu@0 { > device_type = "cpu"; > compatible = "arm,armv8"; > reg = <0x00 0x00>; > phandle = <0x02>; > }; > > cpu@1 { > device_type = "cpu"; > compatible = "arm,armv8"; > reg = <0x00 0x01>; > enable-method = "spin-table"; > cpu-release-addr = <0xEB58C010>; > phandle = <0x03>; > }; > }; > > Although currently I have tested this on Cortex-R52, I feel this may be helpful > to enable smp on other Arm32 based systems as well. Happy to hear opinions. I think you are right > xen/arch/arm/arm32/smpboot.c | 84 ++++++++++++++++++++++++++++++++++-- > 1 file changed, 80 insertions(+), 4 deletions(-) > > diff --git a/xen/arch/arm/arm32/smpboot.c b/xen/arch/arm/arm32/smpboot.c > index 518e9f9c7e..feb249d3f8 100644 > --- a/xen/arch/arm/arm32/smpboot.c > +++ b/xen/arch/arm/arm32/smpboot.c > @@ -1,24 +1,100 @@ > #include > #include > #include > +#include > +#include > #include > > +struct smp_enable_ops { > + int (*prepare_cpu)(int); > +}; coding style > +static uint32_t cpu_release_addr[NR_CPUS]; > +static struct smp_enable_ops smp_enable_ops[NR_CPUS]; they could be __initdata > int __init arch_smp_init(void) > { > return platform_smp_init(); > } > > -int __init arch_cpu_init(int cpu, struct dt_device_node *dn) > +static int __init smp_spin_table_cpu_up(int cpu) > +{ > + uint32_t __iomem *release; > + > + if (!cpu_release_addr[cpu]) code style > + { > + printk("CPU%d: No release addr\n", cpu); > + return -ENODEV; > + } > + > + release = ioremap_nocache(cpu_release_addr[cpu], 4); > + if ( !release ) > + { > + dprintk(XENLOG_ERR, "CPU%d: Unable to map release address\n", cpu); > + return -EFAULT; > + } > + > + writel(__pa(init_secondary), release); > + > + iounmap(release); I think we need a wmb() ? > + sev(); > + > + return 0; > +} > + > +static void __init smp_spin_table_init(int cpu, struct dt_device_node *dn) > { > - /* Not needed on ARM32, as there is no relevant information in > - * the CPU device tree node for ARMv7 CPUs. > + if ( !dt_property_read_u32(dn, "cpu-release-addr", &cpu_release_addr[cpu]) ) It looks like cpu-release-addr could be u64 or u32. Can we detect the size of the property and act accordingly? If the address is u64 and above 4GB it is fine to abort. > + { > + printk("CPU%d has no cpu-release-addr\n", cpu); > + return; > + } > + > + smp_enable_ops[cpu].prepare_cpu = smp_spin_table_cpu_up; > +} > + > +static int __init dt_arch_cpu_init(int cpu, struct dt_device_node *dn) > +{ > + const char *enable_method; > + > + /* > + * Refer Documentation/devicetree/bindings/arm/cpus.yaml, it says on > + * ARM 32-bit systems this property is optional. > */ > + enable_method = dt_get_property(dn, "enable-method", NULL); > + if (!enable_method) coding style > + { > + return 0; > + } > + > + if ( !strcmp(enable_method, "spin-table") ) > + smp_spin_table_init(cpu, dn); > + else > + { > + printk("CPU%d has unknown enable method \"%s\"\n", cpu, enable_method); > + return -EINVAL; > + } > + > return 0; > } > > +int __init arch_cpu_init(int cpu, struct dt_device_node *dn) > +{ > + return dt_arch_cpu_init(cpu, dn); > +} > + > int arch_cpu_up(int cpu) > { > - return platform_cpu_up(cpu); > + int ret = 0; > + > + if ( smp_enable_ops[cpu].prepare_cpu ) > + ret = smp_enable_ops[cpu].prepare_cpu(cpu); > + > + if ( !ret ) > + return platform_cpu_up(cpu); I think this should be: if ( smp_enable_ops[cpu].prepare_cpu ) ret = smp_enable_ops[cpu].prepare_cpu(cpu); else ret = platform_cpu_up(cpu); > + return ret; > } > > void arch_cpu_up_finish(void) > -- > 2.17.1 > > From xen-devel-bounces@lists.xenproject.org Wed May 03 00:15:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 00:15:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528934.822727 (Exim 4.92) (envelope-from ) id 1pu09Z-0004Ym-Mh; Wed, 03 May 2023 00:15:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528934.822727; Wed, 03 May 2023 00:15:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu09Z-0004Yf-Jf; Wed, 03 May 2023 00:15:29 +0000 Received: by outflank-mailman (input) for mailman id 528934; Wed, 03 May 2023 00:15:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu09Z-0004YV-5t; Wed, 03 May 2023 00:15:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu09Z-0004tp-3U; Wed, 03 May 2023 00:15:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu09Y-0000LK-J8; Wed, 03 May 2023 00:15:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pu09Y-0006Wl-II; Wed, 03 May 2023 00:15:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=WL6VCTzBja3me8Re44aOgtooiAZuZdOQfC75djFLKDs=; b=vrOR7xpm5iFaIEwS8M8FGtrt75 FeOf8aVDpM8MJg4IALF6abruau/ju21aNY4Kzc8dcJqWZTRdV5jGrXtO757LyUm6G3bAUDEcNq2+6 GW3v0JsZnszoyutqXCfyEQLU4nTFcwC0haoyIwYhQ+S0JbBAZcJeHtSNl/l8HgcxgCOw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180506: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-livepatch:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=b033eddc9779109c06a26936321d27a2ef4e088b X-Osstest-Versions-That: xen=ef841d2a2377f5297add27e637b725426bb4840a From: osstest service owner Date: Wed, 03 May 2023 00:15:28 +0000 flight 180506 xen-unstable real [real] flight 180510 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180506/ http://logs.test-lab.xenproject.org/osstest/logs/180510/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-livepatch 7 xen-install fail pass in 180510-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180501 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180501 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180501 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180501 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180501 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180501 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 180501 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 180501 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180501 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 180501 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180501 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180501 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: xen b033eddc9779109c06a26936321d27a2ef4e088b baseline version: xen ef841d2a2377f5297add27e637b725426bb4840a Last test of basis 180501 2023-05-02 01:52:02 Z 0 days Testing same since 180506 2023-05-02 14:40:07 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Ayan Kumar Halder Jan Beulich Juergen Gross jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch fail test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git ef841d2a23..b033eddc97 b033eddc9779109c06a26936321d27a2ef4e088b -> master From xen-devel-bounces@lists.xenproject.org Wed May 03 04:23:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 04:23:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528943.822737 (Exim 4.92) (envelope-from ) id 1pu411-000239-Te; Wed, 03 May 2023 04:22:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528943.822737; Wed, 03 May 2023 04:22:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu411-000231-Od; Wed, 03 May 2023 04:22:55 +0000 Received: by outflank-mailman (input) for mailman id 528943; Wed, 03 May 2023 04:22:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu410-00022v-9h for xen-devel@lists.xenproject.org; Wed, 03 May 2023 04:22:54 +0000 Received: from BN3PR00CU001.outbound.protection.outlook.com (mail-eastus2azlp170100001.outbound.protection.outlook.com [2a01:111:f403:c110::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2aa4e9dd-e96a-11ed-b225-6b7b168915f2; Wed, 03 May 2023 06:22:52 +0200 (CEST) Received: from BYAPR21MB1688.namprd21.prod.outlook.com (2603:10b6:a02:bf::26) by SJ1PR21MB3672.namprd21.prod.outlook.com (2603:10b6:a03:454::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.5; Wed, 3 May 2023 04:22:47 +0000 Received: from BYAPR21MB1688.namprd21.prod.outlook.com ([fe80::9a0f:a04d:69bd:e622]) by BYAPR21MB1688.namprd21.prod.outlook.com ([fe80::9a0f:a04d:69bd:e622%4]) with mapi id 15.20.6387.008; Wed, 3 May 2023 04:22:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2aa4e9dd-e96a-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NIX0NsEqXlxjBuV+z3lpVjMeduOj+RWt3DWEQW/YX9/xvnwOjBvNxH5hPDvx5r3ypIynmawqZsJ6lnLKJcT4xOcjJXMLisIaZRzsuhDzoKAXRTirHYMNZENLlQy8utMSnEUc6F9slpyTwGugbFwFizLTUdaMqWeOFDXGxKldT462dnh5/kBsLGpwy+S29aGvKFXuPtUYdC7RRIwfHRVRaog0Foq4m/uMsPO1Limp0svxqIq7JhDoDCWpb4K1bxfcFuDuDgVyo28VfzTZ8Qr70tc6YWj8CwBmM9/VcO2TxN22LPIFfspmyOgGcYlpxtUT94PUQJTCpSn8YZEu1F2S4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mEbWF04JB1+jJ2e/vZRLaUQDQhU6GPACa5+X14xXBfA=; b=nJvmAFRblAAsjjZmfjspG/CN//djt467hPSelBXUVIm1FnzJu9rgpkAhqBAcfRcHKtigjNXqWGJKE8TbbRpdBLBoRBImlnIHJYb0oly/SZC10s0qCn0x5hrcpwYW6GbZQKVnuT9HUavxt1o+8uUrR/14T6ebLHqemuCt52R41v8CpMk2Y7Cddg6tfMlbGmpzStk4Nw8CkfffSMpc1MfD2QXhyldDdxtpo+yvolymSKVcEm/Zux8JDP+X7gA0sMYj7ERdIjUML3OyQQPKhny7VRJAlNvDEt1NXME4p6ht7oZOlgzYZF5xQU87Q2sP+07TFq6iY2xGru6LDqFwAc54HQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mEbWF04JB1+jJ2e/vZRLaUQDQhU6GPACa5+X14xXBfA=; b=AcnimC9uDbYIbBVE395BH32ulUHT4KZJB6XqIyMk1/PfkEYTZPdcteELcaDyIb3ZofLsaIROLcEMksfetG6jkHnIw35CRtXcYHMEgF0LJA3JOp6Srn2bVdzSV8xFPI//cfSfnV0mioVWrWmbSFQWoH0hS2dzpcvmUUgUP4G3LpY= From: "Michael Kelley (LINUX)" To: Juergen Gross , "linux-kernel@vger.kernel.org" , "x86@kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-doc@vger.kernel.org" CC: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , KY Srinivasan , Haiyang Zhang , Wei Liu , Dexuan Cui , Boris Ostrovsky , "xen-devel@lists.xenproject.org" , Jonathan Corbet , Andy Lutomirski , Peter Zijlstra Subject: RE: [PATCH v6 00/16] x86/mtrr: fix handling with PAT but without MTRR Thread-Topic: [PATCH v6 00/16] x86/mtrr: fix handling with PAT but without MTRR Thread-Index: AQHZfO8AidMlTOanxE29vr+R9vbz+69H8llg Date: Wed, 3 May 2023 04:22:47 +0000 Message-ID: References: <20230502120931.20719-1-jgross@suse.com> In-Reply-To: <20230502120931.20719-1-jgross@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=623c2fcc-89cf-47dd-a85a-04fd8fadfa20;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2023-05-03T04:17:01Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR21MB1688:EE_|SJ1PR21MB3672:EE_ x-ms-office365-filtering-correlation-id: 0c1bf722-548b-4607-f879-08db4b8e0cba x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fwCBycC5zSlUwDxiBf74VJaq8hMw2JHL6NjE1faRai7H37vkQew8zG7pgu9wrjuS9Nj7cqskAsjPm7/YGDKG8BTqFus85NLKQlaQiDJKUgBgJYDUYH6bIW9nENgue4H/EHpW+adBZiMaBRibZxvQDhvdEmA2n98rkqFQFHXiw/mBQaNwPaNoz8ow9E8fI7H38f26YO49HIm6U7AP4Vv27xlB1ekG/4MOcDKBqOjm5i36UN17AgG+L7x7Q3lfjrL+4tOU/0Gg4U1Zwfnp5JsIlmagCrXcyzmCIxHsZ55w6XODEYG19ZbKIbJ2QhGNV9SPxmh967Set4Ke6/5ScQehV/BbqNDwh9oydXxTjxlGgJ4+DGZGkBVpkONs9gMvK9N7mb0QoLX6cvf/EMCBaR7nr3iNiE7FExXVlUd3KCANZGl4vga4HtGrHu1In74MtEVUD/uqCLS4omRP61weN90X1CYKsilbl4KulrR9vAwmqjIKvb3Di5U4yjUlWIi/xzcGAI8skQ3CWGUsQuQHVSf4tDLyQi/lXIk1Py54Qym7QQMA34TPAIbjVZKpJF40x7c6tM/2VGi3zGxlqlmfDEMXGh17LZO0KVXNx/kUC2slExoq6YnVxSp/hCasEJQQEUJp8r6FN7U/KDTTuHZGTQhWOGt2YEAlHe/dNlB0ytzZtIQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR21MB1688.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(376002)(396003)(136003)(366004)(451199021)(52536014)(8936002)(5660300002)(8676002)(7416002)(41300700001)(82960400001)(316002)(786003)(82950400001)(33656002)(38070700005)(86362001)(2906002)(122000001)(38100700002)(55016003)(8990500004)(10290500003)(26005)(54906003)(6506007)(9686003)(83380400001)(478600001)(186003)(71200400001)(7696005)(76116006)(4326008)(64756008)(66556008)(66446008)(66946007)(66476007)(110136005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6Be8axflG7PfbcOl6TqBYxOmhTBdjq/lv27ZadRFiFK8L2wVavNNyLiPmVMy?= =?us-ascii?Q?UqZXpDRAbchH/dWmtdQeFzHeGIkkRZXD0M0av4NZu9lGRivjSoeqQ0CrQIxl?= =?us-ascii?Q?60rt+Vq6F8ATV4JRra3Lmv4Fu/xOaLQZLCj05cBT0+UkyZnO886CUKbdgwTq?= =?us-ascii?Q?QtW04zG+LF+y8mkWZbtB063JHSJf1ywDpdveLssOzjwdqhE2cJH8xDRjsHDB?= =?us-ascii?Q?6+V1R1W3RBCyYOPMcpwXOP/MoLoE9OCrBBD4NNWH3+OEnBUApNG53Z0FN3hC?= =?us-ascii?Q?ZvXxSWyeuZKqAv4qyhkkuKNlq6aWcXBnPe2aHO3ikkhXf6qRCFvdG60uMqca?= =?us-ascii?Q?aHkCplQYZ28+7lbkNizN0msrQ+z4xha2Bfj6LN36ZwFYFr8OgW7SPrpWRqNk?= =?us-ascii?Q?4LTRN4CkfRpBJ3QHqNdVtlZQeICQAHHvtH3rT70x7yklyzjFvNYS0t7IVUsE?= =?us-ascii?Q?e3zs/g3a5Di1QIj5aRKjmDM0dEewWQ8jja4ILX6d/hw7CoquWpi/nExgdNr2?= =?us-ascii?Q?dwNQyc8Vz/6G+bzaFSDGd9fYJlF1Hopns8i0abYt4+JkEgw8ml/9ql6JV9dC?= =?us-ascii?Q?289CyZ2P1FFMMJBX4qT+m//wTl9FuN5dwzO/YLb31g7KfU6BT7had5u0DJxq?= =?us-ascii?Q?uw3UxtRTyAnkoJB+BLlruNtajJVEg+Gj4fqg67L3krAeLFwc1MyBZGI9o6fI?= =?us-ascii?Q?PcWRwa8ToFHdY0gmpbEPO83ByBqjaPhT84/dTC/HTpzfGZjnlyce1pjvH3z2?= =?us-ascii?Q?9l0lak9bQKqz4CIpJl47MGaOhOaQQ4fb71Fb+ooqYXVQfj9JA107gbVAfGXa?= =?us-ascii?Q?6cPCPQimkeqFwUUL0I3P9XuhnQqMJrBwbsXuTn5PLysRVo28uU4ZswvZHoxe?= =?us-ascii?Q?6nj08xlzbQce9LqioNqDGNJFxiwBXNw3epoP0inHSzioHW82vqVRwdAXosAE?= =?us-ascii?Q?GGez/Gq2jwsT0P5sH0P2t84CoZLTDQIjPdbycqtOuGe0HvSCn+x7xk1l5Ony?= =?us-ascii?Q?GpJ2CybBKhYz51VS3VYreNFpGl8M+6wp8J1f0zX9Vz8vU4y2h5LLFD9t8EOF?= =?us-ascii?Q?15qKoo44bXv0CEz8iz/GEo+LxHlN9YWX+7QYkdaAHbcfDe/Xivf5EuGQXcZp?= =?us-ascii?Q?gSwBzYOPYY035u9nifu4QQZWQYRpihCrJz4dDitRUCsK4I+M2bzeQxOJ7upB?= =?us-ascii?Q?og096lBeMmE36ekMsgsISyqpY/Uj4up0BixRrE7SbN8dhfaVqvUb4A+BFjWR?= =?us-ascii?Q?QeZHvwXub0uROgb7t2iGl3HqkKtDdP/aBBOdVPCcZMVGEr9P4jY5VKPP5/QK?= =?us-ascii?Q?wPISdH/59BAiS9V63EQmZA15fJ6OCnT4scO3RBM1skDr1cMNLEJnc6lhg8RY?= =?us-ascii?Q?5/dMDlAE0K10GgL2kiKsQL5teGAtWrCVcPSy1Pd7ngwhvKakdn+OSZoY7uhz?= =?us-ascii?Q?eV1ftHiHKKL2OClkRuasqtaSZ6tNruLpiyhF/lBJlvhcrRgsPAbz1+sFMBd+?= =?us-ascii?Q?5eWkAzVQLK9QXCch7FcUDD5RJBSibQmK9C06juqV1+8giA12z45qdqRgvCeW?= =?us-ascii?Q?qpb7AqTih8BSHE9zdznG9sEiKY6mIp7k5YB8QlnA69pmaErR1ooEMpHYVeiw?= =?us-ascii?Q?9Q=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR21MB1688.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c1bf722-548b-4607-f879-08db4b8e0cba X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2023 04:22:47.3546 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: F4oz+y3a+0Vw8WA7Yyy7owpm/xWojADSC5j6iYwY6aydHvqP9XDf88eWc5mo3pwV5g7MITimVS8bEgxbVTFOLHfvMUMBbAfxxuOAAsxlbEw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR21MB3672 From: Juergen Gross Sent: Tuesday, May 2, 2023 5:09 AM >=20 > This series tries to fix the rather special case of PAT being available > without having MTRRs (either due to CONFIG_MTRR being not set, or > because the feature has been disabled e.g. by a hypervisor). >=20 > The main use cases are Xen PV guests and SEV-SNP guests running under > Hyper-V. >=20 > Instead of trying to work around all the issues by adding if statements > here and there, just try to use the complete available infrastructure > by setting up a read-only MTRR state when needed. >=20 > In the Xen PV case the current MTRR MSR values can be read from the > hypervisor, while for the SEV-SNP case all needed is to set the > default caching mode to "WB". >=20 > I have added more cleanup which has been discussed when looking into > the most recent failures. >=20 > Note that I couldn't test the Hyper-V related change (patch 3). >=20 > Running on bare metal and with Xen didn't show any problems with the > series applied. >=20 > It should be noted that patches 9+10 are replacing today's way to > lookup the MTRR cache type for a memory region from looking at the > MTRR register values to building a memory map with the cache types. > This should make the lookup much faster and much easier to understand. >=20 > Changes in V2: > - replaced former patches 1+2 with new patches 1-4, avoiding especially > the rather hacky approach of V1, while making all the MTRR type > conflict tests available for the Xen PV case > - updated patch 6 (was patch 4 in V1) >=20 > Changes in V3: > - dropped patch 5 of V2, as already applied > - split patch 1 of V2 into 2 patches > - new patches 6-10 > - addressed comments >=20 > Changes in V4: > - addressed comments >=20 > Changes in V5 > - addressed comments > - some other small fixes > - new patches 3, 8 and 15 >=20 > Changes in V6: > - patch 1 replaces patches 1+2 of V5 > - new patches 8+12 > - addressed comments >=20 > Juergen Gross (16): > x86/mtrr: remove physical address size calculation > x86/mtrr: replace some constants with defines > x86/mtrr: support setting MTRR state for software defined MTRRs > x86/hyperv: set MTRR state when running as SEV-SNP Hyper-V guest > x86/xen: set MTRR state when running as Xen PV initial domain > x86/mtrr: replace vendor tests in MTRR code > x86/mtrr: have only one set_mtrr() variant > x86/mtrr: move 32-bit code from mtrr.c to legacy.c > x86/mtrr: allocate mtrr_value array dynamically > x86/mtrr: add get_effective_type() service function > x86/mtrr: construct a memory map with cache modes > x86/mtrr: add mtrr=3Ddebug command line option > x86/mtrr: use new cache_map in mtrr_type_lookup() > x86/mtrr: don't let mtrr_type_lookup() return MTRR_TYPE_INVALID > x86/mm: only check uniform after calling mtrr_type_lookup() > x86/mtrr: remove unused code >=20 > .../admin-guide/kernel-parameters.txt | 4 + > arch/x86/hyperv/ivm.c | 4 + > arch/x86/include/asm/mtrr.h | 43 +- > arch/x86/include/uapi/asm/mtrr.h | 6 +- > arch/x86/kernel/cpu/mtrr/Makefile | 2 +- > arch/x86/kernel/cpu/mtrr/amd.c | 2 +- > arch/x86/kernel/cpu/mtrr/centaur.c | 11 +- > arch/x86/kernel/cpu/mtrr/cleanup.c | 22 +- > arch/x86/kernel/cpu/mtrr/cyrix.c | 2 +- > arch/x86/kernel/cpu/mtrr/generic.c | 677 ++++++++++++------ > arch/x86/kernel/cpu/mtrr/legacy.c | 90 +++ > arch/x86/kernel/cpu/mtrr/mtrr.c | 195 ++--- > arch/x86/kernel/cpu/mtrr/mtrr.h | 18 +- > arch/x86/kernel/setup.c | 2 + > arch/x86/mm/pgtable.c | 24 +- > arch/x86/xen/enlighten_pv.c | 52 ++ > 16 files changed, 721 insertions(+), 433 deletions(-) > create mode 100644 arch/x86/kernel/cpu/mtrr/legacy.c >=20 > -- > 2.35.3 I've tested the full v6 series in a normal Hyper-V guest and in an SEV-SNP = guest. In the SNP guest, the page attributes in /sys/kernel/debug/x86/pat_memtype_= list are "write-back" in the expected cases. The "mtrr" x86 feature no longer a= ppears in the "flags" output of "lscpu" or /proc/cpuinfo. /proc/mtrr does not exi= st, again as expected. In a normal VM, the "mtrr" x86 feature appears in the flags, and /proc/mtrr shows expected values. The boot option mtrr=3Ddebug works as expected. Tested-by: Michael Kelley From xen-devel-bounces@lists.xenproject.org Wed May 03 05:14:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 05:14:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528949.822746 (Exim 4.92) (envelope-from ) id 1pu4oK-0000gh-NO; Wed, 03 May 2023 05:13:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528949.822746; Wed, 03 May 2023 05:13:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu4oK-0000ga-Km; Wed, 03 May 2023 05:13:52 +0000 Received: by outflank-mailman (input) for mailman id 528949; Wed, 03 May 2023 05:13:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu4oJ-0000gU-7d for xen-devel@lists.xenproject.org; Wed, 03 May 2023 05:13:51 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4863da49-e971-11ed-8611-37d641c3527e; Wed, 03 May 2023 07:13:47 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 433382220F; Wed, 3 May 2023 05:13:46 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 18B661331F; Wed, 3 May 2023 05:13:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id yzlhA4rtUWTuDAAAMHmgww (envelope-from ); Wed, 03 May 2023 05:13:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4863da49-e971-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683090826; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LaWDROxnQcpwHJGfkAql2NTegOv3GyU+pkxSUG8g+SA=; b=pnNZhh5mhscbPVHU/wsicPKUkI9tXkqGFZyRghDH8ItD91k9k36az7kNVBMVWR6eTJ6J4K vHdrd91uaGWn5BQPHaAaWAZGNYrmWrkcGVHLlGlf9FR8PhU4Xln1j+vqAV130Th6TtICoQ oNKnVcY+NJKrp27X2nT+OFh05uQkVFA= Message-ID: <887675ad-ef06-cf8c-8a32-5b3f726e2198@suse.com> Date: Wed, 3 May 2023 07:13:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v4 05/13] tools/xenstore: use accounting buffering for node accounting Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230405070349.25293-1-jgross@suse.com> <20230405070349.25293-6-jgross@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------VeQcZ8FdmnwJV4taqQPZtlrI" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------VeQcZ8FdmnwJV4taqQPZtlrI Content-Type: multipart/mixed; boundary="------------nfpqoveNwzJbFL96YvSvSfM1"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: <887675ad-ef06-cf8c-8a32-5b3f726e2198@suse.com> Subject: Re: [PATCH v4 05/13] tools/xenstore: use accounting buffering for node accounting References: <20230405070349.25293-1-jgross@suse.com> <20230405070349.25293-6-jgross@suse.com> In-Reply-To: --------------nfpqoveNwzJbFL96YvSvSfM1 Content-Type: multipart/mixed; boundary="------------N8VE7HNtmR9cgCw1BF6JdMag" --------------N8VE7HNtmR9cgCw1BF6JdMag Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDIuMDUuMjMgMjA6NTUsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDA1LzA0LzIwMjMgMDg6MDMsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBB ZGQgdGhlIG5vZGUgYWNjb3VudGluZyB0byB0aGUgYWNjb3VudGluZyBpbmZvcm1hdGlvbiBi dWZmZXJpbmcgaW4NCj4+IG9yZGVyIHRvIGF2b2lkIGhhdmluZyB0byB1bmRvIGl0IGluIGNh c2Ugb2YgZmFpbHVyZS4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxq Z3Jvc3NAc3VzZS5jb20+DQo+PiAtLS0NCj4+IMKgIHRvb2xzL3hlbnN0b3JlL3hlbnN0b3Jl ZF9jb3JlLmPCoMKgIHwgMjEgKystLS0tLS0tLS0tLS0tLS0tLS0tDQo+PiDCoCB0b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmggfMKgIDQgKystLQ0KPj4gwqAgMiBmaWxlcyBj aGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDIxIGRlbGV0aW9ucygtKQ0KPj4NCj4+IGRpZmYg LS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jIGIvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2NvcmUuYw0KPj4gaW5kZXggODQzMzVmNWYzZC4uOTJhNDBjY2YzZiAx MDA2NDQNCj4+IC0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMNCj4+ICsr KyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMNCj4+IEBAIC0xNDUyLDcgKzE0 NTIsNiBAQCBzdGF0aWMgdm9pZCBkZXN0cm95X25vZGVfcm0oc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sIA0KPj4gc3RydWN0IG5vZGUgKm5vZGUpDQo+PiDCoCBzdGF0aWMgaW50IGRlc3Ry b3lfbm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IG5vZGUgKm5vZGUpDQo+ PiDCoCB7DQo+PiDCoMKgwqDCoMKgIGRlc3Ryb3lfbm9kZV9ybShjb25uLCBub2RlKTsNCj4+ IC3CoMKgwqAgZG9tYWluX25iZW50cnlfZGVjKGNvbm4sIGdldF9ub2RlX293bmVyKG5vZGUp KTsNCj4+IMKgwqDCoMKgwqAgLyoNCj4+IMKgwqDCoMKgwqDCoCAqIEl0IGlzIG5vdCBwb3Nz aWJsZSB0byBlYXNpbHkgcmV2ZXJ0IHRoZSBjaGFuZ2VzIGluIGEgdHJhbnNhY3Rpb24uDQo+ PiBAQCAtMTc5NywyNyArMTc5NiwxMSBAQCBzdGF0aWMgaW50IGRvX3NldF9wZXJtcyhjb25z dCB2b2lkICpjdHgsIHN0cnVjdCANCj4+IGNvbm5lY3Rpb24gKmNvbm4sDQo+PiDCoMKgwqDC oMKgIG9sZF9wZXJtcyA9IG5vZGUtPnBlcm1zOw0KPj4gwqDCoMKgwqDCoCBkb21haW5fbmJl bnRyeV9kZWMoY29ubiwgZ2V0X25vZGVfb3duZXIobm9kZSkpOw0KPiANCj4gSUlSQywgd2Ug b3JpZ2luYWxseSBzYWlkIHRoYXQgZG9tYWluX25iZW50cnlfZGVjKCkgY291bGQgbmV2ZXIg ZmFpbCBpbiBhIA0KPiBub24tdHJhbnNhY3Rpb24gY2FzZS4gQnV0IHdpdGggeW91ciBjdXJy ZW50IHJld29yaywgdGhlIGZ1bmN0aW9uIGNhbiBub3cgZmFpbCANCj4gYmVjYXVzZSBvZiBh biBhbGxvY2F0aW9uIGZhaWx1cmUuDQoNCkhvdyB3b3VsZCB0aGF0IGJlIHBvc3NpYmxlIHRv IGhhcHBlbj8NCg0KZG9tYWluX25iZW50cnlfZGVjKCkgY2FuIG9ubHkgYmUgY2FsbGVkIGlm IGEgbm9kZSBpcyBiZWluZyBvd25lZCBieSBhbiBhbHJlYWR5DQprbm93biBkb21haW4uIFNv IGFsbG9jYXRpb24gaXMgaW1wb3NzaWJsZSB0byBoYXBwZW4sIGFzIHRoaXMgd291bGQgYmUg YSBtYWpvcg0KZXJyb3IgaW4geGVuc3RvcmVkLg0KDQo+IFRoZXJlZm9yZSwgc2hvdWxkbid0 IHdlIG5vdyBjaGVjayB0aGUgZXJyb3I/IChQb3NzaWJseSBpbiBhIHBhdGNoIGJlZm9yZWhh bmQpLg0KDQpJIGRvbid0IHRoaW5rIHNvLiBJIGNhbiBhZGQgYSBjb21tZW50IGlmIHlvdSB3 YW50Lg0KDQoNCkp1ZXJnZW4NCg== --------------N8VE7HNtmR9cgCw1BF6JdMag Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------N8VE7HNtmR9cgCw1BF6JdMag-- --------------nfpqoveNwzJbFL96YvSvSfM1-- --------------VeQcZ8FdmnwJV4taqQPZtlrI Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmRR7YkFAwAAAAAACgkQsN6d1ii/Ey/O 7Qf7BulSDLguGvrfdji0yzCuDH9ISSVnqqtzcCMi3AZy9wmPBj113oiv2J7ZzwGyQ3VJBKb/kDk5 JM178hdWL1FiLNNtnac6ax5jiRg75E2665mu2LzoPoRz6Qdhxr5gEb8h+Bq2+1Smawdm4g0bt0rF vbfNPmmRXF8xlGYIKNkgSXdgzKdXeFv9QrzZ7G1V/dq1e2o86r94MMFfN9czyXrMqjsh9mVM5HPb TL4iD8ch8HMkon0oigu9IK+pEcfyfoqDe2zgctyvzbVS1bxX08ZEpzaYRzFGAjLHxJJRQ7Jw0CUQ WH6QgH+ej9RJMLCzH+D1wUI1luasOklU29qNHGk/6Q== =DZH8 -----END PGP SIGNATURE----- --------------VeQcZ8FdmnwJV4taqQPZtlrI-- From xen-devel-bounces@lists.xenproject.org Wed May 03 05:22:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 05:22:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528952.822757 (Exim 4.92) (envelope-from ) id 1pu4w0-00027p-Fz; Wed, 03 May 2023 05:21:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528952.822757; Wed, 03 May 2023 05:21:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu4w0-00027i-Cz; Wed, 03 May 2023 05:21:48 +0000 Received: by outflank-mailman (input) for mailman id 528952; Wed, 03 May 2023 05:21:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu4vz-00027c-Um for xen-devel@lists.xenproject.org; Wed, 03 May 2023 05:21:47 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6622d888-e972-11ed-b225-6b7b168915f2; Wed, 03 May 2023 07:21:47 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 899501FF78; Wed, 3 May 2023 05:21:46 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5BB821331F; Wed, 3 May 2023 05:21:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id SlEwFGrvUWTOEAAAMHmgww (envelope-from ); Wed, 03 May 2023 05:21:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6622d888-e972-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683091306; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yOi3yGLq7RX6Qag50H/c43X0b6cIunKT3mfc8j3/LUQ=; b=oT2zFUg2A/o39AZK0LgXBeVQCIx0cBXMRXnKCMGji2a3eIA4++vaWe9sH4oUms6W7+DTa0 D2ENxwGNML8qF5U5XRkjCbbw9o1/cIZaT1uT4CQdRK/D199vYQoK1izTNacyNlUVmLcyrn jc7gD6XqD6uLf+yO+qdglV985puhnek= Message-ID: <80246bbf-85eb-0829-8f86-d5a2ea3941fe@suse.com> Date: Wed, 3 May 2023 07:21:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230405070349.25293-1-jgross@suse.com> <20230405070349.25293-8-jgross@suse.com> <25027287-441a-304c-f035-0d3da3572d3a@xen.org> From: Juergen Gross Subject: Re: [PATCH v4 07/13] tools/xenstore: use accounting data array for per-domain values In-Reply-To: <25027287-441a-304c-f035-0d3da3572d3a@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------FcxXT8qekjRmiPntJ9Rci2Tl" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------FcxXT8qekjRmiPntJ9Rci2Tl Content-Type: multipart/mixed; boundary="------------Rm8WJ3mb8Jcsj3d8pClM9LxW"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: <80246bbf-85eb-0829-8f86-d5a2ea3941fe@suse.com> Subject: Re: [PATCH v4 07/13] tools/xenstore: use accounting data array for per-domain values References: <20230405070349.25293-1-jgross@suse.com> <20230405070349.25293-8-jgross@suse.com> <25027287-441a-304c-f035-0d3da3572d3a@xen.org> In-Reply-To: <25027287-441a-304c-f035-0d3da3572d3a@xen.org> --------------Rm8WJ3mb8Jcsj3d8pClM9LxW Content-Type: multipart/mixed; boundary="------------KEYllicDOrIfjMYCxqnnIMog" --------------KEYllicDOrIfjMYCxqnnIMog Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDIuMDUuMjMgMjE6MDksIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDA1LzA0LzIwMjMgMDg6MDMsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBk aWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5oIA0KPj4gYi90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmgNCj4+IGluZGV4IDVjZmQ3MzBjZjYu LjBkNjFiZjQzNDQgMTAwNjQ0DQo+PiAtLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf ZG9tYWluLmgNCj4+ICsrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uaA0K Pj4gQEAgLTI4LDcgKzI4LDEwIEBAIGVudW0gYWNjaXRlbSB7DQo+PiDCoMKgwqDCoMKgIEFD Q19OT0RFUywNCj4+IMKgwqDCoMKgwqAgQUNDX1JFUV9OLMKgwqDCoMKgwqDCoMKgIC8qIE51 bWJlciBvZiBlbGVtZW50cyBwZXIgcmVxdWVzdC4gKi8NCj4+IMKgwqDCoMKgwqAgQUNDX1RS X04gPSBBQ0NfUkVRX04swqDCoMKgIC8qIE51bWJlciBvZiBlbGVtZW50cyBwZXIgdHJhbnNh Y3Rpb24uICovDQo+PiAtwqDCoMKgIEFDQ19OID0gQUNDX1RSX04swqDCoMKgIC8qIE51bWJl ciBvZiBlbGVtZW50cyBwZXIgZG9tYWluLiAqLw0KPj4gK8KgwqDCoCBBQ0NfV0FUQ0ggPSBB Q0NfVFJfTiwNCj4+ICvCoMKgwqAgQUNDX09VVFNULA0KPj4gK8KgwqDCoCBBQ0NfTUVNLA0K Pj4gK8KgwqDCoCBBQ0NfTizCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIC8qIE51bWJlciBvZiBl bGVtZW50cyBwZXIgZG9tYWluLiAqLw0KPj4gwqAgfTsNCj4+IMKgIHZvaWQgaGFuZGxlX2V2 ZW50KHZvaWQpOw0KPj4gQEAgLTEwNyw5ICsxMTAsOCBAQCBzdGF0aWMgaW5saW5lIHZvaWQg ZG9tYWluX21lbW9yeV9hZGRfbm9jaGsoc3RydWN0IA0KPj4gY29ubmVjdGlvbiAqY29ubiwN Cj4+IMKgIHZvaWQgZG9tYWluX3dhdGNoX2luYyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubik7 DQo+PiDCoCB2b2lkIGRvbWFpbl93YXRjaF9kZWMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4p Ow0KPj4gwqAgaW50IGRvbWFpbl93YXRjaChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubik7DQo+ PiAtdm9pZCBkb21haW5fb3V0c3RhbmRpbmdfaW5jKHN0cnVjdCBjb25uZWN0aW9uICpjb25u KTsNCj4+IC12b2lkIGRvbWFpbl9vdXRzdGFuZGluZ19kZWMoc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4pOw0KPj4gLXZvaWQgZG9tYWluX291dHN0YW5kaW5nX2RvbWlkX2RlYyh1bnNpZ25l ZCBpbnQgZG9taWQpOw0KPj4gK3ZvaWQgZG9tYWluX291dHN0YW5kaW5nX2luYyhzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwgdW5zaWduZWQgaW50IGRvbWlkKTsNCj4gDQo+IEFGQUlDVCwg YWxsIHRoZSBjYWxsZXIgb2YgZG9tYWluX291dHN0YW5kaW5nX2luYygpIHdpbGwgcGFzcyAn Y29ubi0+aWQnLiBTbyBpdCANCj4gaXMgbm90IGVudGlyZWx5IGNsZWFyIHdoYXQncyB0aGUg YmVuZWZpdHMgdG8gYWRkIHRoZSBleHRyYSBwYXJhbWV0ZXIuDQoNCmRvbWFpbl9hY2NfYWRk KCkgd2lsbCBuZWVkIGNvbm4uIEkgYWdyZWUgdGhhdCBJIHNob3VsZCBkcm9wIHRoZSBkb21p ZA0KcGFyYW1ldGVyLg0KDQoNCkp1ZXJnZW4NCg0K --------------KEYllicDOrIfjMYCxqnnIMog Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------KEYllicDOrIfjMYCxqnnIMog-- --------------Rm8WJ3mb8Jcsj3d8pClM9LxW-- --------------FcxXT8qekjRmiPntJ9Rci2Tl Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmRR72kFAwAAAAAACgkQsN6d1ii/Ey9F dQf9Ek9e2fCCniFtImYz1SfFBlRInCabKSX7y3w2m1F3CqKVf4GKv4m845vV21Hph22VUPJ7ogNq kRNov81HNSQ3LQuPBg7wP4mGiCR6cONf88EGj7eMJump/AQD9utV+OXy0xvXiSFnBbdvx0E/5lD6 PHPORQjM0HyJocEZaGYxt5a71CgWIAJE/4LH45QSd2sDxoT+XQ0I5q63syBQu9B6m334g5ycjdld 4Q6sEUXRo8Sb5O7Z+844OT6MqptO1KXgxdLq4coC/ghBlaQunVCYSJtyVUVGI/qYbjEsH+axnBPv fCImRNdaYZPPpEooPBduu8yFOmAfLMLUtYyFifpFXQ== =SbpM -----END PGP SIGNATURE----- --------------FcxXT8qekjRmiPntJ9Rci2Tl-- From xen-devel-bounces@lists.xenproject.org Wed May 03 05:27:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 05:27:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528955.822767 (Exim 4.92) (envelope-from ) id 1pu51K-0002mr-04; Wed, 03 May 2023 05:27:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528955.822767; Wed, 03 May 2023 05:27:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu51J-0002mk-So; Wed, 03 May 2023 05:27:17 +0000 Received: by outflank-mailman (input) for mailman id 528955; Wed, 03 May 2023 05:27:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu51J-0002ma-8e; Wed, 03 May 2023 05:27:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu51J-0007LX-2A; Wed, 03 May 2023 05:27:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu51I-0003n3-Cw; Wed, 03 May 2023 05:27:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pu51I-0006NP-BH; Wed, 03 May 2023 05:27:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=BexeGpCqAkTvV1hg0XPr1SSXsfkkQ+O9nnEWB14rzVE=; b=gvIk0A54qIlMFVUuIyfKcw2Z5X C1c/JqB/UtPK+0j2FIfHb2aDzhPWpBPyWXnScGmPqw1e3C9ired3umeCtJRxoSbuWaVS2wg0KPjbQ G3PwE3RsNwdeyiEQUSngPTNif14A+RKHJRzT1WE3EjPrzzjkq03AsTadfb6CEFiqUTLE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 180507: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-xl-xsm:xen-install:fail:heisenbug qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=b5f47ba73b7c1457d2f18d71c00e1a91a76fe60b X-Osstest-Versions-That: qemuu=7c18f2d663521f1b31b821a13358ce38075eaf7d From: osstest service owner Date: Wed, 03 May 2023 05:27:16 +0000 flight 180507 qemu-mainline real [real] flight 180512 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180507/ http://logs.test-lab.xenproject.org/osstest/logs/180512/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-xsm 7 xen-install fail pass in 180512-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 180487 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180487 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180487 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 180487 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 180487 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180487 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180487 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180487 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu b5f47ba73b7c1457d2f18d71c00e1a91a76fe60b baseline version: qemuu 7c18f2d663521f1b31b821a13358ce38075eaf7d Last test of basis 180487 2023-04-30 07:39:02 Z 2 days Testing same since 180507 2023-05-02 15:37:40 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alexander Bulekov Fabiano Rosas Richard Henderson Thomas Huth jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 7c18f2d663..b5f47ba73b b5f47ba73b7c1457d2f18d71c00e1a91a76fe60b -> upstream-tested From xen-devel-bounces@lists.xenproject.org Wed May 03 06:15:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 06:15:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528964.822777 (Exim 4.92) (envelope-from ) id 1pu5mK-0008OU-O9; Wed, 03 May 2023 06:15:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528964.822777; Wed, 03 May 2023 06:15:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu5mK-0008ON-LW; Wed, 03 May 2023 06:15:52 +0000 Received: by outflank-mailman (input) for mailman id 528964; Wed, 03 May 2023 06:15:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu5mJ-0008OH-G2 for xen-devel@lists.xenproject.org; Wed, 03 May 2023 06:15:51 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f1cfa927-e979-11ed-8611-37d641c3527e; Wed, 03 May 2023 08:15:47 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1C770222BD; Wed, 3 May 2023 06:15:47 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F247613584; Wed, 3 May 2023 06:15:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 95p8ORL8UWTtKQAAMHmgww (envelope-from ); Wed, 03 May 2023 06:15:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f1cfa927-e979-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683094547; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kmcwBsajxIzxE0uREb5tgy7d6wQRBvMrRV6hOczWqJY=; b=akO08lM+JHLACcvgISVgWsLWChTKaWbmO6swufQ+52xziMfKGuEw6CnGQz/+XpUOjYNz2/ 5J+tWmlD+TyMVitCWFk3B6QSV8dKXEtwks4dU+b6nLKUc0ofV+ZQbsgDmxkV+0O31txUo+ 61XRRgqDCgXrlyX54LcNbluL2ytsarM= Message-ID: <2d98605e-9310-4e95-7688-003374dddefe@suse.com> Date: Wed, 3 May 2023 08:15:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v4 10/13] tools/xenstore: switch transaction accounting to generic accounting Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org References: <20230405070349.25293-1-jgross@suse.com> <20230405070349.25293-11-jgross@suse.com> <5b61ce7e-639c-4f2d-6cb9-421679d30d9d@xen.org> From: Juergen Gross In-Reply-To: <5b61ce7e-639c-4f2d-6cb9-421679d30d9d@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------MyRyK0u3FPb61Z70nR0fXyY5" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------MyRyK0u3FPb61Z70nR0fXyY5 Content-Type: multipart/mixed; boundary="------------SgTviRsEdOjj6hzyoDajOReW"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Message-ID: <2d98605e-9310-4e95-7688-003374dddefe@suse.com> Subject: Re: [PATCH v4 10/13] tools/xenstore: switch transaction accounting to generic accounting References: <20230405070349.25293-1-jgross@suse.com> <20230405070349.25293-11-jgross@suse.com> <5b61ce7e-639c-4f2d-6cb9-421679d30d9d@xen.org> In-Reply-To: <5b61ce7e-639c-4f2d-6cb9-421679d30d9d@xen.org> --------------SgTviRsEdOjj6hzyoDajOReW Content-Type: multipart/mixed; boundary="------------O3h0PR8yVdeKvkLJu22VSBPE" --------------O3h0PR8yVdeKvkLJu22VSBPE Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDIuMDUuMjMgMjE6MTksIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGksDQo+IA0KPiBP biAwNS8wNC8yMDIzIDA4OjAzLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gQXMgdHJhbnNh Y3Rpb24gYWNjb3VudGluZyBpcyBhY3RpdmUgZm9yIHVucHJpdmlsZWdlZCBkb21haW5zIG9u bHksIGl0DQo+PiBjYW4gZWFzaWx5IGJlIGFkZGVkIHRvIHRoZSBnZW5lcmljIHBlci1kb21h aW4gYWNjb3VudGluZy4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxq Z3Jvc3NAc3VzZS5jb20+DQo+PiAtLS0NCj4+IMKgIHRvb2xzL3hlbnN0b3JlL3hlbnN0b3Jl ZF9jb3JlLmPCoMKgwqDCoMKgwqDCoCB8wqAgMyArLS0NCj4+IMKgIHRvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb3JlLmjCoMKgwqDCoMKgwqDCoCB8wqAgMSAtDQo+PiDCoCB0b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmPCoMKgwqDCoMKgIHwgMjEgKysrKysrKysrKysr KysrKysrLS0tDQo+PiDCoCB0b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmjCoMKg wqDCoMKgIHzCoCA0ICsrKysNCj4+IMKgIHRvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFu c2FjdGlvbi5jIHwgMTIgKysrKystLS0tLS0tDQo+PiDCoCA1IGZpbGVzIGNoYW5nZWQsIDI4 IGluc2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygtKQ0KPj4NCj4+IGRpZmYgLS1naXQgYS90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jIGIvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2NvcmUuYw0KPj4gaW5kZXggMmQ0ODFmY2FkOS4uODhjNTY5YjdkNSAxMDA2NDQNCj4+ IC0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMNCj4+ICsrKyBiL3Rvb2xz L3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMNCj4+IEBAIC0yMDgzLDcgKzIwODMsNyBAQCBz dGF0aWMgdm9pZCBjb25zaWRlcl9tZXNzYWdlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uKQ0K Pj4gwqDCoMKgwqDCoMKgICogc3RhbGxlZC4gVGhpcyB3aWxsIGlnbm9yZSBuZXcgcmVxdWVz dHMgdW50aWwgTGl2ZS1VcGRhdGUgaGFwcGVuZWQNCj4+IMKgwqDCoMKgwqDCoCAqIG9yIGl0 IHdhcyBhYm9ydGVkLg0KPj4gwqDCoMKgwqDCoMKgICovDQo+PiAtwqDCoMKgIGlmIChsdV9p c19wZW5kaW5nKCkgJiYgY29ubi0+dHJhbnNhY3Rpb25fc3RhcnRlZCA9PSAwICYmDQo+PiAr wqDCoMKgIGlmIChsdV9pc19wZW5kaW5nKCkgJiYgY29ubi0+dGFfc3RhcnRfdGltZSA9PSAw ICYmDQo+IA0KPiBOSVQ6IEkga25vdyB0aGVyZSBhcmUgc29tZSBwbGFjZXMgaW4gdGhlIGNv ZGUgY2hlY2tpbmcgZm9yIGNvbm4tPnRhX3N0YXJ0X3RpbWUgDQo+ID09IDAuIEJ1dCBpdCBm ZWVscyBsaWtlIGEgYmV0dGVyIHJlcGxhY2VtZW50IHRvICJjb25uLT50cmFuc2FjdGlvbl9z dGFydGVkIiBpcyANCj4gImxpc3RfZW1wdHkoLi4uKSIuDQoNCkZpbmUgd2l0aCBtZS4NCg0K PiANCj4gSSBhZ3JlZSB0aGlzIGlzIGdvaW5nIHRvIGJlIG1vcmUgZXhwZW5zaXZlLiBCdXQg eW91IGFyZSBzd2l0Y2hpbmcgdGhlIA0KPiB0cmFuc2FjdGlvbiBhY2NvdW50aW5nIHRvIGEg Z2VuZXJpYyBpbmZyYXN0cnVjdHVyZSB3aGljaCBpcyBwcmV0dHkgaGVhdnkgY29tcGFyZSAN Cj4gdG8gYSBzaW1wbGUgYWRkaXRpb24vc3Vic3RyYWN0aW9uLiBTbyBJIHRoaW5rIGEgImxp c3RfZW1wdHkoKSIgd291bGQgYmUgT0sgaGVyZS4NCj4gDQo+PiDCoMKgwqDCoMKgwqDCoMKg wqAgY29ubi0+aW4tPmhkci5tc2cudHlwZSA9PSBYU19UUkFOU0FDVElPTl9TVEFSVCkgew0K Pj4gwqDCoMKgwqDCoMKgwqDCoMKgIHRyYWNlKCJEZWxheWluZyB0cmFuc2FjdGlvbiBzdGFy dCBmb3IgY29ubmVjdGlvbiAlcCByZXFfaWQgJXVcbiIsDQo+PiDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgY29ubiwgY29ubi0+aW4tPmhkci5tc2cucmVxX2lkKTsNCj4+IEBA IC0yMTkwLDcgKzIxOTAsNiBAQCBzdHJ1Y3QgY29ubmVjdGlvbiAqbmV3X2Nvbm5lY3Rpb24o Y29uc3Qgc3RydWN0IA0KPj4gaW50ZXJmYWNlX2Z1bmNzICpmdW5jcykNCj4+IMKgwqDCoMKg wqAgbmV3LT5mdW5jcyA9IGZ1bmNzOw0KPj4gwqDCoMKgwqDCoCBuZXctPmlzX2lnbm9yZWQg PSBmYWxzZTsNCj4+IMKgwqDCoMKgwqAgbmV3LT5pc19zdGFsbGVkID0gZmFsc2U7DQo+PiAt wqDCoMKgIG5ldy0+dHJhbnNhY3Rpb25fc3RhcnRlZCA9IDA7DQo+PiDCoMKgwqDCoMKgIElO SVRfTElTVF9IRUFEKCZuZXctPm91dF9saXN0KTsNCj4+IMKgwqDCoMKgwqAgSU5JVF9MSVNU X0hFQUQoJm5ldy0+YWNjX2xpc3QpOw0KPj4gwqDCoMKgwqDCoCBJTklUX0xJU1RfSEVBRCgm bmV3LT5yZWZfbGlzdCk7DQo+PiBkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2NvcmUuaCBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgNCj4+IGluZGV4 IDVhMTFkYzEyMzEuLjM1NjRkODVkN2QgMTAwNjQ0DQo+PiAtLS0gYS90b29scy94ZW5zdG9y ZS94ZW5zdG9yZWRfY29yZS5oDQo+PiArKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf Y29yZS5oDQo+PiBAQCAtMTUxLDcgKzE1MSw2IEBAIHN0cnVjdCBjb25uZWN0aW9uDQo+PiDC oMKgwqDCoMKgIC8qIExpc3Qgb2YgaW4tcHJvZ3Jlc3MgdHJhbnNhY3Rpb25zLiAqLw0KPj4g wqDCoMKgwqDCoCBzdHJ1Y3QgbGlzdF9oZWFkIHRyYW5zYWN0aW9uX2xpc3Q7DQo+PiDCoMKg wqDCoMKgIHVpbnQzMl90IG5leHRfdHJhbnNhY3Rpb25faWQ7DQo+PiAtwqDCoMKgIHVuc2ln bmVkIGludCB0cmFuc2FjdGlvbl9zdGFydGVkOw0KPj4gwqDCoMKgwqDCoCB0aW1lX3QgdGFf c3RhcnRfdGltZTsNCj4+IMKgwqDCoMKgwqAgLyogTGlzdCBvZiBkZWxheWVkIHJlcXVlc3Rz LiAqLw0KPj4gZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4u YyANCj4+IGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jDQo+PiBpbmRleCAx Y2FhNjBiYjE0Li40MGJjYzFkYmZhIDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX2RvbWFpbi5jDQo+PiArKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf ZG9tYWluLmMNCj4+IEBAIC00MTksMTIgKzQxOSwxMCBAQCBpbnQgZG9tYWluX2dldF9xdW90 YShjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uIA0KPj4gKmNvbm4sDQo+PiDC oCB7DQo+PiDCoMKgwqDCoMKgIHN0cnVjdCBkb21haW4gKmQgPSBmaW5kX2RvbWFpbl9zdHJ1 Y3QoZG9taWQpOw0KPj4gwqDCoMKgwqDCoCBjaGFyICpyZXNwOw0KPj4gLcKgwqDCoCBpbnQg dGE7DQo+PiDCoMKgwqDCoMKgIGlmICghZCkNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1 cm4gRU5PRU5UOw0KPj4gLcKgwqDCoCB0YSA9IGQtPmNvbm4gPyBkLT5jb25uLT50cmFuc2Fj dGlvbl9zdGFydGVkIDogMDsNCj4+IMKgwqDCoMKgwqAgcmVzcCA9IHRhbGxvY19hc3ByaW50 ZihjdHgsICJEb21haW4gJXU6XG4iLCBkb21pZCk7DQo+PiDCoMKgwqDCoMKgIGlmICghcmVz cCkNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gRU5PTUVNOw0KPj4gQEAgLTQzNSw3 ICs0MzMsNyBAQCBpbnQgZG9tYWluX2dldF9xdW90YShjb25zdCB2b2lkICpjdHgsIHN0cnVj dCBjb25uZWN0aW9uIA0KPj4gKmNvbm4sDQo+PiDCoMKgwqDCoMKgIGVudChub2RlcywgZC0+ YWNjW0FDQ19OT0RFU10pOw0KPj4gwqDCoMKgwqDCoCBlbnQod2F0Y2hlcywgZC0+YWNjW0FD Q19XQVRDSF0pOw0KPj4gLcKgwqDCoCBlbnQodHJhbnNhY3Rpb25zLCB0YSk7DQo+PiArwqDC oMKgIGVudCh0cmFuc2FjdGlvbnMsIGQtPmFjY1tBQ0NfVFJBTlNdKTsNCj4+IMKgwqDCoMKg wqAgZW50KG91dHN0YW5kaW5nLCBkLT5hY2NbQUNDX09VVFNUXSk7DQo+PiDCoMKgwqDCoMKg IGVudChtZW1vcnksIGQtPmFjY1tBQ0NfTUVNXSk7DQo+PiBAQCAtMTI5Nyw2ICsxMjk1LDIz IEBAIHZvaWQgZG9tYWluX291dHN0YW5kaW5nX2RlYyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29u biwgDQo+PiB1bnNpZ25lZCBpbnQgZG9taWQpDQo+PiDCoMKgwqDCoMKgIGRvbWFpbl9hY2Nf YWRkKGNvbm4sIGRvbWlkLCBBQ0NfT1VUU1QsIC0xLCB0cnVlKTsNCj4+IMKgIH0NCj4+ICt2 b2lkIGRvbWFpbl90cmFuc2FjdGlvbl9pbmMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4pDQo+ PiArew0KPj4gK8KgwqDCoCBkb21haW5fYWNjX2FkZChjb25uLCBjb25uLT5pZCwgQUNDX1RS QU5TLCAxLCB0cnVlKTsNCj4+ICt9DQo+PiArDQo+PiArdm9pZCBkb21haW5fdHJhbnNhY3Rp b25fZGVjKHN0cnVjdCBjb25uZWN0aW9uICpjb25uKQ0KPj4gK3sNCj4+ICvCoMKgwqAgZG9t YWluX2FjY19hZGQoY29ubiwgY29ubi0+aWQsIEFDQ19UUkFOUywgLTEsIHRydWUpOw0KPj4g K30NCj4+ICsNCj4+ICt1bnNpZ25lZCBpbnQgZG9tYWluX3RyYW5zYWN0aW9uX2dldChzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubikNCj4+ICt7DQo+PiArwqDCoMKgIHJldHVybiAoZG9tYWlu X2lzX3VucHJpdmlsZWdlZChjb25uKSkNCj4+ICvCoMKgwqDCoMKgwqDCoCA/IGRvbWFpbl9h Y2NfYWRkKGNvbm4sIGNvbm4tPmlkLCBBQ0NfVFJBTlMsIDAsIHRydWUpDQo+PiArwqDCoMKg wqDCoMKgwqAgOiAwOw0KPj4gK30NCj4+ICsNCj4+IMKgIHN0YXRpYyB3cmxfY3JlZGl0dCB3 cmxfY29uZmlnX3dyaXRlY29zdMKgwqDCoMKgwqAgPSBXUkxfRkFDVE9SOw0KPj4gwqAgc3Rh dGljIHdybF9jcmVkaXR0IHdybF9jb25maWdfcmF0ZcKgwqDCoMKgwqDCoMKgwqDCoMKgID0g V1JMX1JBVEXCoMKgICogV1JMX0ZBQ1RPUjsNCj4+IMKgIHN0YXRpYyB3cmxfY3JlZGl0dCB3 cmxfY29uZmlnX2RidXJzdMKgwqDCoMKgwqDCoMKgwqAgPSBXUkxfREJVUlNUICogV1JMX0ZB Q1RPUjsNCj4+IGRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWlu LmggDQo+PiBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uaA0KPj4gaW5kZXgg MGQ2MWJmNDM0NC4uYWJjNzY2ZjM0MyAxMDA2NDQNCj4+IC0tLSBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9kb21haW4uaA0KPj4gKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVk X2RvbWFpbi5oDQo+PiBAQCAtMzEsNiArMzEsNyBAQCBlbnVtIGFjY2l0ZW0gew0KPj4gwqDC oMKgwqDCoCBBQ0NfV0FUQ0ggPSBBQ0NfVFJfTiwNCj4+IMKgwqDCoMKgwqAgQUNDX09VVFNU LA0KPj4gwqDCoMKgwqDCoCBBQ0NfTUVNLA0KPj4gK8KgwqDCoCBBQ0NfVFJBTlMsDQo+PiDC oMKgwqDCoMKgIEFDQ19OLMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgLyogTnVtYmVyIG9mIGVs ZW1lbnRzIHBlciBkb21haW4uICovDQo+PiDCoCB9Ow0KPj4gQEAgLTExMiw2ICsxMTMsOSBA QCB2b2lkIGRvbWFpbl93YXRjaF9kZWMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4pOw0KPj4g wqAgaW50IGRvbWFpbl93YXRjaChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubik7DQo+PiDCoCB2 b2lkIGRvbWFpbl9vdXRzdGFuZGluZ19pbmMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHVu c2lnbmVkIGludCBkb21pZCk7DQo+PiDCoCB2b2lkIGRvbWFpbl9vdXRzdGFuZGluZ19kZWMo c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHVuc2lnbmVkIGludCBkb21pZCk7DQo+PiArdm9p ZCBkb21haW5fdHJhbnNhY3Rpb25faW5jKHN0cnVjdCBjb25uZWN0aW9uICpjb25uKTsNCj4+ ICt2b2lkIGRvbWFpbl90cmFuc2FjdGlvbl9kZWMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4p Ow0KPj4gK3Vuc2lnbmVkIGludCBkb21haW5fdHJhbnNhY3Rpb25fZ2V0KHN0cnVjdCBjb25u ZWN0aW9uICpjb25uKTsNCj4+IMKgIGludCBkb21haW5fZ2V0X3F1b3RhKGNvbnN0IHZvaWQg KmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIHVuc2lnbmVkIGludCBkb21pZCk7DQo+PiBkaWZmIC0tZ2l0IGEvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMgDQo+PiBiL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jDQo+PiBpbmRleCAxMWM4YmNlYzg0Li4xYzE0Yjg1 NzlhIDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0 aW9uLmMNCj4+ICsrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5j DQo+PiBAQCAtNDc5LDggKzQ3OSw3IEBAIGludCBkb190cmFuc2FjdGlvbl9zdGFydChjb25z dCB2b2lkICpjdHgsIHN0cnVjdCANCj4+IGNvbm5lY3Rpb24gKmNvbm4sDQo+PiDCoMKgwqDC oMKgIGlmIChjb25uLT50cmFuc2FjdGlvbikNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1 cm4gRUJVU1k7DQo+PiAtwqDCoMKgIGlmIChkb21haW5faXNfdW5wcml2aWxlZ2VkKGNvbm4p ICYmDQo+PiAtwqDCoMKgwqDCoMKgwqAgY29ubi0+dHJhbnNhY3Rpb25fc3RhcnRlZCA+IHF1 b3RhX21heF90cmFuc2FjdGlvbikNCj4+ICvCoMKgwqAgaWYgKGRvbWFpbl90cmFuc2FjdGlv bl9nZXQoY29ubikgPiBxdW90YV9tYXhfdHJhbnNhY3Rpb24pDQo+PiDCoMKgwqDCoMKgwqDC oMKgwqAgcmV0dXJuIEVOT1NQQzsNCj4+IMKgwqDCoMKgwqAgLyogQXR0YWNoIHRyYW5zYWN0 aW9uIHRvIGN0eCBmb3IgYXV0b2ZyZWUgdW50aWwgaXQncyBjb21wbGV0ZSAqLw0KPj4gQEAg LTUwNSw5ICs1MDQsOSBAQCBpbnQgZG9fdHJhbnNhY3Rpb25fc3RhcnQoY29uc3Qgdm9pZCAq Y3R4LCBzdHJ1Y3QgDQo+PiBjb25uZWN0aW9uICpjb25uLA0KPj4gwqDCoMKgwqDCoCBsaXN0 X2FkZF90YWlsKCZ0cmFucy0+bGlzdCwgJmNvbm4tPnRyYW5zYWN0aW9uX2xpc3QpOw0KPj4g wqDCoMKgwqDCoCB0YWxsb2Nfc3RlYWwoY29ubiwgdHJhbnMpOw0KPj4gwqDCoMKgwqDCoCB0 YWxsb2Nfc2V0X2Rlc3RydWN0b3IodHJhbnMsIGRlc3Ryb3lfdHJhbnNhY3Rpb24pOw0KPj4g LcKgwqDCoCBpZiAoIWNvbm4tPnRyYW5zYWN0aW9uX3N0YXJ0ZWQpDQo+PiArwqDCoMKgIGlm ICghY29ubi0+dGFfc3RhcnRfdGltZSkNCj4gDQo+IEkgdGhpbmsgaXQgd291bGQgbWFrZSBt b3JlIHNlbnNlIHRvIG1vdmUgdGhpcyBpZiBqdXN0IGJlZm9yZSB0aGUgbGlzdF9hZGRfdGFp bCgpIA0KPiBhbmQgdXNlIChsaXN0X2VtcHR5KCkpIGZvciB0aGUgY2hlY2tlZC4gVGhpcyB3 b3VsZCBtYWtlIHRoZSBjb2RlIG1vcmUgY29uc2lzdGVudC4uLg0KDQpPa2F5Lg0KDQoNCkp1 ZXJnZW4NCg== --------------O3h0PR8yVdeKvkLJu22VSBPE Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------O3h0PR8yVdeKvkLJu22VSBPE-- --------------SgTviRsEdOjj6hzyoDajOReW-- --------------MyRyK0u3FPb61Z70nR0fXyY5 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmRR/BIFAwAAAAAACgkQsN6d1ii/Ey// VAf9EH5+YR0g1o2f23X0hBYSoAYB1MEzYk6zNNBJZ0LmHiUiPUH8f6+G3WKjq/a9RyJBFTXmgv1r cNysT3L2vJKSvcSDP9Mnv3pzft+1DJib2OxM3EZlkh8ChYZd72TFV07LYdvOZPFf3i9vJcmBSP/Z 6LEI9HFGYR5J/rr7vEyXnFGfYwUlW/2MnCeSCyObU04xjsQFeo0fa5sDWJzkAXPrKEoi0Wkr/WYw fWJMf0rvbwmLKdrTmdxlaX3BFSl55gxZpPP08zswNAz4qDvrH56RZ94fFP4NdB5Py4Iya9NNje3R lk1N7/J24224oX3aGGggSuNF3aSEYGMOy9IRyBPZfw== =rdqI -----END PGP SIGNATURE----- --------------MyRyK0u3FPb61Z70nR0fXyY5-- From xen-devel-bounces@lists.xenproject.org Wed May 03 07:08:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 07:08:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528968.822786 (Exim 4.92) (envelope-from ) id 1pu6bR-0005KR-Mg; Wed, 03 May 2023 07:08:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528968.822786; Wed, 03 May 2023 07:08:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu6bR-0005KK-Jy; Wed, 03 May 2023 07:08:41 +0000 Received: by outflank-mailman (input) for mailman id 528968; Wed, 03 May 2023 07:08:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu6bP-0005KE-P1 for xen-devel@lists.xenproject.org; Wed, 03 May 2023 07:08:39 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20612.outbound.protection.outlook.com [2a01:111:f400:7d00::612]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 52cf0d40-e981-11ed-8611-37d641c3527e; Wed, 03 May 2023 09:08:37 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DUZPR04MB9967.eurprd04.prod.outlook.com (2603:10a6:10:4dd::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Wed, 3 May 2023 07:08:35 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 07:08:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52cf0d40-e981-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jonfv+56iCepjnplQOTpQC1sb/vsZZNPYpco53+O1LLm1se8t5n1//JF2kKOYY06Amz7F1tkEEWGHwawegiaMCcyNS1850gYO4gqUXuuksLx6D+ajDS/A/OhLRXkBI4p/HE7D3sG+PhMkGuaNUIHO8NROg6Nz8IXcX4iJr3mcb9KU+Io8XrrObwQWjNZHovgtKyyswgTsOPKlzr8r0peGDXBC973EXmJ2FDgPf551doE8M35Wy3gLCEdenrz+wK2F7JhWLH0kDvBpED9v/RL5u+ln8758sE64lPaH2j94I5gaVk28uHG1wwagAjdniweWVPwHwi7s9uFHOMuo9QABA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YXcIHP4+HOvaIqGF7aCScNCByN18B1j4dRBfMEacL2A=; b=BwWCOiblj89GykKEQ5z5Xm7VKnXVNbac7bOQjzjqfwHMxpMsrEg034IOT02SP3Gx66hzFdqrQTlplV73YPwBYK+u54vLEY0uAXUM/RW52Nvm/SaheplQElVE5YN4ceXwgaBIIHboRg7wVvy28RDQUcp+qIinVlzdW31z4R5TLscjC3PUZJhwc9qafkpFmlUSziNnSr/7v6Y0BqoBoUJ4mZPwtdS4cgd7wf9D4GZKDDkzAXkq5BuaWZJvC2pVE4Q9LUcdJZqpVkfHlM5tlenwn4kLSmvI2HomwRO6nTMsS/maFjaqYB3yyz3XZpl8MX6k31M1aPHOoWEWqahQ3Jy3nw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YXcIHP4+HOvaIqGF7aCScNCByN18B1j4dRBfMEacL2A=; b=K8pTth6oXr0g+dcDCO78ogfIs6sKiHGaattx0PXm5viopVL610FgoUvAU6SIPdnwiKmNS0fn9B+jTbQQHz9UK9bUpHuhKZag9OGocZ3AKZy0e+l8vbIKm2ZK1qT4xv30PDjtkpQFWpLdc/rE8ZNQUZDGwJPtLCnvRvr1CfQi3Uw9/Lvl7X1gv9q+teOIV03DbPtMDQTNdIDquuHM1y6LWpatlPna4sE6yVXZAVC2qYS60UmeRgv+dpVofS+inAELjUSHaMzdMfG62wrMQxU1+tj3kn9azUHdatVmbT05Y7GhlcG5H8dG8RfjmtPbyLQNK/Cgk2lMZINM0LD7fU/9NQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 3 May 2023 09:08:32 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3 1/2] acpi: Make TPM version configurable. Content-Language: en-US To: Jennifer Herbert Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Xen-devel References: <20230425174733.795961-1-jennifer.herbert@citrix.com> <20230425174733.795961-2-jennifer.herbert@citrix.com> <5516fbf5-dbfc-dcd5-0465-e4757fdc16de@suse.com> <5e877d50-de2d-0af4-9fa0-d4529a97ee2f@citrix.com> From: Jan Beulich In-Reply-To: <5e877d50-de2d-0af4-9fa0-d4529a97ee2f@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0156.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::13) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|DUZPR04MB9967:EE_ X-MS-Office365-Filtering-Correlation-Id: 583b9408-7ce4-49e0-8867-08db4ba5359b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NbXzl1RMvkvvB0wgYJx6ysTb6i1E5XdpEb+8Xquwzq5gIcoJhxvbDoNEM+H/8moq32t7ZuHXEW++q7EXo5Te9e5Da+dfJbPcPxw/U9I7n+y8d2WEKh7zCNVfCPJ0z/s1grpzMXizlvJr68ev8uDFSNP58tIt9P610m24xsc2TrWrieDOQxNI1oaIrzz0x3XVFMfKA7bZwRswlEUYztS2mpI0cgByLE8U7wZWo5ABgyBdCNpTlQSOaBBCCxUz5lkkmFyE4o0qTLD0tpiDY+cLH6wRsLEWrUf06co37i8DiKasDxE396GSYqv+rf9kkZfZ4L7b+juXrmrDJkRLNNPnO/S2OwphkPSMtErjsuwT2XPzjBTuY+GRrUzlmvgXbW4t5ibAvjAoetJEZkIVQtLVEA+0wwU992X2KBrJu9KvygiQ4EqmNNT4Jnpt3HNQBelwuZ099O3CAgJXbNAUJU62HnGojaCndzSuBsagAOtROGbxouevVaKEGLYeEJ/VHZIw1ChkWNCPH1x7xyZrpQwAsmpMyRrkw5zK6c7t+RjXqa28yAKKVQ+yuTDfGdNNzM89MHHhDtDzi3CqUepANikHOpRQwRBH2zs89wJWY7TxhY8RpVAxNDUoI59gwh+30zmZfUPG11z/AE3h3AfBPMo+zQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(346002)(39860400002)(396003)(366004)(376002)(451199021)(31686004)(83380400001)(4326008)(6916009)(38100700002)(41300700001)(8936002)(316002)(6512007)(6506007)(26005)(6486002)(53546011)(478600001)(66946007)(66476007)(66556008)(2616005)(86362001)(31696002)(5660300002)(36756003)(8676002)(186003)(54906003)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QkNJQ0hiUFM3ZFdMK1Y2WHUzQWRjc3d0N1NFclRsNlpmYmZoS0RlcWN2WW5x?= =?utf-8?B?SjcxaTBiUHF0MTNtRFZnbUJtSTR2REVxWkpIbmJNcXI1K2d5akF3ekRoZGtW?= =?utf-8?B?dm9iT1Fud0VLeUtvaFA1akt2cmthTUQ3SG56U2lxS0RUd2Zpd0dhZzJCOVJq?= =?utf-8?B?U2xPY0hla1RyWHRYS2d3UEVWVUJZSXQ5REJCM2o3RTVhazBweG8wZTBXN1lk?= =?utf-8?B?R2Q5dm1kQzBISVNwem53dDlScWJ5bnRUS1lkVWRXdTdzY0tvMmVHMys2RnFn?= =?utf-8?B?WjNERksrU3hDQnZCS3REaGl4YmFiUHBGTVhBMGg3N1duK09aZTRwWjBScjdU?= =?utf-8?B?S1NWQTU5b0tIelk2eFdhYWFXaW9kVjAzTEpDb2FZdUdhTWdkamxCUjBxa0RF?= =?utf-8?B?YlNBbTdSVGh4b1lkWldOSDRDSmEyQnhpejQyL3Q4cEpvUUE5RW0wRW56WHZL?= =?utf-8?B?RWJ3YjZGaFd3UWMzY2pXb3k5b1NoT2Y3UEczQ1gyUDR5d3gwS3pORkpSbGVr?= =?utf-8?B?MnJ3YUorbS9hNWw3ODVEeU9RekRpVkFqQzRmd3ZhQmFXRkYrTkRUbzJjd1hi?= =?utf-8?B?cUIrY1RHeC9wcS9lSGRIdXhPQnUvbEdIVmRXQnQ3N3ZDWmRZWndmUXY2K1RN?= =?utf-8?B?c3BUbnFWRkdDay9rRkZPWE85eWkwOVY0ci9BVVlqWWJGOUhvcFoxNmNuWTcr?= =?utf-8?B?L0ZTS2hGR2RjZjd1RTlKWVRDcGQ4cWVlUVdtS0d3aXFyNjN5TElCdkg4eXI5?= =?utf-8?B?c3BiS2VaTUJsNytqTzFTSGpWbTVQcFM3bEhaSmVyaE9WcXAvaVROc2ZieWNY?= =?utf-8?B?WFplMTh5ZThJaVV1cFNJTkRPQ1lWUzRNTVlGM0dGaUVVU1dWQ3ljZDVHMXM2?= =?utf-8?B?a1V0cEswQitFdmJaQnVabEYybXRnT3dKQzJMWDZFZys5Y3Q3ZDB6MFlUMDFm?= =?utf-8?B?a2gxamlIN2RMVE5lRHFidWthNDEzMVF3UDhGb01GN2JuTnhmb3ExMkFMRGxW?= =?utf-8?B?Zi9MazNIQWZsd0pIT1duRDZjek91cEZJVjdFUTJQbWJybVZHSnN6MWFpYW9N?= =?utf-8?B?Y0ZDaU5INWdRZ0grWGJ2blczYTVJa0hjWGpjK2VTSFpaZGMxZjF6T3IzeitH?= =?utf-8?B?QWVrWmNEK3JkMEZEMkJoaEdKZDRMNjdkREZaUTF0M1FmNmgyRTR0eTJqRENR?= =?utf-8?B?QWEwUlVUY29GNUlFYWFPZlk5T0xjQWt2cmNhVjA0R1NwcmVyd2Uvc0thMnJ1?= =?utf-8?B?SGdsK2NKVHVyVnoxUERxUE5zbU1jVXFBNWpISHU0Tnp6ZC8rbEJlVGtsS0dq?= =?utf-8?B?amRhVW9FQjVQNHFUMVNsYW1nTHo0L3E0cHNOZUdwM1Vad3Z4ZnV1MlJLajRW?= =?utf-8?B?MWZRUXNYNE9UK050R01XTzMyV09FN29KVThscXFMZlBZMEdYdGxOWDI0NXY0?= =?utf-8?B?eGw4VVRCbnhNRGhDbksrZlBMMmloN0NLdGxFUmdBRHAzNG9Jb29Yc2pkd2t3?= =?utf-8?B?aURhSWM3UEw4QmVxUUVYdi8rWWtCMDJGK2NpdnFBdk9sZzdYa2NzdndHTWk4?= =?utf-8?B?ek12dm4rMzJZUkxNb00wNHFXUzVZMmNJSDNHbEFLQzFHV2YyKzB4VEN5Rm4w?= =?utf-8?B?aE1HbkJYcW9Qa0d5czZzQVNmVTdNUWVsaHdGWnpZUjMxdkoxNkxzbElxaDFB?= =?utf-8?B?Ri9adk1rK0xjTHpSRGhJS2RvM1dOaVpQdWl0ZGlkVGJseEJXZzZpVXpzWk9p?= =?utf-8?B?dHNWZHU1TlZtV1paNlN4V1lpYnZGSWV5aUxsMWhKRldjYlZOU0RmSTNLYjB1?= =?utf-8?B?TkVyY3Nua0RGbWVOT1lhTVF1TkpGTFBkSE0xeXFPWnBiamNQZlZOWlZDRDBp?= =?utf-8?B?TGxMZFlSK2hQb3IwT3BSbERRdTVERlY1VG5HRG5hT2V5akQ0T0hQV0p6WDM1?= =?utf-8?B?WXRIWHlkVVJBdzhpRS9rZU1QZ1VtM01UcnJSNmwyaVJUZ2hwMndRbFAxcFFO?= =?utf-8?B?aksyK0swRjFUUVNhbWt4Y1ZSekllTDVFTStVbHV4a1hTRVprZXBsWkRlRVBM?= =?utf-8?B?b2hhaklpRzExQThlY2lodFFuQng5Z0dEQUliSE51VjJ6enJTSTlpN1BoQmRn?= =?utf-8?Q?JKyy3LHSlEmcHleFOR4vlC76h?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 583b9408-7ce4-49e0-8867-08db4ba5359b X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 07:08:34.9031 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: daZ7ji40hnxsjgg6+6fqpEHd3tevjB60KIg8ZC5XwCBzDXgWuPkVVmBgMFoiiW4gKUOAENdaly4DKog6Ddse1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DUZPR04MB9967 On 03.05.2023 00:40, Jennifer Herbert wrote: > On 02/05/2023 12:54, Jan Beulich wrote: >> On 25.04.2023 19:47, Jennifer Herbert wrote: >>> --- a/tools/firmware/hvmloader/util.c >>> +++ b/tools/firmware/hvmloader/util.c >>> @@ -994,13 +994,22 @@ void hvmloader_acpi_build_tables(struct acpi_config *config, >>> if ( !strncmp(xenstore_read("platform/acpi_laptop_slate", "0"), "1", 1) ) >>> config->table_flags |= ACPI_HAS_SSDT_LAPTOP_SLATE; >>> >>> - config->table_flags |= (ACPI_HAS_TCPA | ACPI_HAS_IOAPIC | >>> - ACPI_HAS_WAET | ACPI_HAS_PMTIMER | >>> - ACPI_HAS_BUTTONS | ACPI_HAS_VGA | >>> - ACPI_HAS_8042 | ACPI_HAS_CMOS_RTC); >>> + config->table_flags |= (ACPI_HAS_IOAPIC | ACPI_HAS_WAET | >>> + ACPI_HAS_PMTIMER | ACPI_HAS_BUTTONS | >>> + ACPI_HAS_VGA | ACPI_HAS_8042 | >>> + ACPI_HAS_CMOS_RTC); >>> config->acpi_revision = 4; >>> >>> - config->tis_hdr = (uint16_t *)ACPI_TIS_HDR_ADDRESS; >>> + s = xenstore_read("platform/tpm_version", "1"); >>> + config->tpm_version = strtoll(s, NULL, 0); >> Due to field width, someone specifying 257 will also get a 1.2 TPM, >> if I'm not mistaken. > > Seems likely.   And i few other wacky values would give you 1.2 as well > I'd think.   There could also be trailing junk on the version number. > > I was a bit phased by the lack of any real error cases in > hvmloader_acpi_build_tables.  It seemed the approch was if you put in > junk, you'll get something, but possibly not what your expecting. > > Do I take it you'd prefer it to only accept a strict '1' for 1.2 and any > other value would result in no TPM being probed?  Or is it only the > overflow cases your concerned about? Iirc xs convention is that numeric values can be spelled out in arbitrary ways. So limiting to strictly "1" may be too restrictive. Anything that evaluates to 1 without overflow nor trailing junk ought to be taken to mean 1, I think. >>> --- a/tools/libacpi/build.c >>> +++ b/tools/libacpi/build.c >>> @@ -409,38 +409,47 @@ static int construct_secondary_tables(struct acpi_ctxt *ctxt, >>> memcpy(ssdt, ssdt_laptop_slate, sizeof(ssdt_laptop_slate)); >>> table_ptrs[nr_tables++] = ctxt->mem_ops.v2p(ctxt, ssdt); >>> } >>> - >>> - /* TPM TCPA and SSDT. */ >>> - if ( (config->table_flags & ACPI_HAS_TCPA) && >>> - (config->tis_hdr[0] != 0 && config->tis_hdr[0] != 0xffff) && >>> - (config->tis_hdr[1] != 0 && config->tis_hdr[1] != 0xffff) ) >>> + /* TPM and its SSDT. */ >>> + if ( config->table_flags & ACPI_HAS_TPM ) >>> { >>> - ssdt = ctxt->mem_ops.alloc(ctxt, sizeof(ssdt_tpm), 16); >>> - if (!ssdt) return -1; >>> - memcpy(ssdt, ssdt_tpm, sizeof(ssdt_tpm)); >>> - table_ptrs[nr_tables++] = ctxt->mem_ops.v2p(ctxt, ssdt); >>> - >>> - tcpa = ctxt->mem_ops.alloc(ctxt, sizeof(struct acpi_20_tcpa), 16); >>> - if (!tcpa) return -1; >>> - memset(tcpa, 0, sizeof(*tcpa)); >>> - table_ptrs[nr_tables++] = ctxt->mem_ops.v2p(ctxt, tcpa); >>> - >>> - tcpa->header.signature = ACPI_2_0_TCPA_SIGNATURE; >>> - tcpa->header.length = sizeof(*tcpa); >>> - tcpa->header.revision = ACPI_2_0_TCPA_REVISION; >>> - fixed_strcpy(tcpa->header.oem_id, ACPI_OEM_ID); >>> - fixed_strcpy(tcpa->header.oem_table_id, ACPI_OEM_TABLE_ID); >>> - tcpa->header.oem_revision = ACPI_OEM_REVISION; >>> - tcpa->header.creator_id = ACPI_CREATOR_ID; >>> - tcpa->header.creator_revision = ACPI_CREATOR_REVISION; >>> - if ( (lasa = ctxt->mem_ops.alloc(ctxt, ACPI_2_0_TCPA_LAML_SIZE, 16)) != NULL ) >>> + switch ( config->tpm_version ) >>> { >>> - tcpa->lasa = ctxt->mem_ops.v2p(ctxt, lasa); >>> - tcpa->laml = ACPI_2_0_TCPA_LAML_SIZE; >>> - memset(lasa, 0, tcpa->laml); >>> - set_checksum(tcpa, >>> - offsetof(struct acpi_header, checksum), >>> - tcpa->header.length); >>> + case 0: /* Assume legacy code wanted tpm 1.2 */ >> Along the lines of what Jason said: Unless this is known to be needed for >> anything, I'd prefer if it was omitted. > > I'm not awair of anything, but your comment 2 lines down  from version 2 > made me think you knew of some.  So if your happy with me removing this > line, I am! I'm afraid I can't make the connection to that comment (assuming I fished out the right one). In any event, especially with Jason's observation that ACPI_HAS_TPM won't be set alongside ->tpm_version being zero, I see no use for keeping the "case 0:". Jan From xen-devel-bounces@lists.xenproject.org Wed May 03 07:28:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 07:28:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528973.822797 (Exim 4.92) (envelope-from ) id 1pu6ul-0007qP-DT; Wed, 03 May 2023 07:28:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528973.822797; Wed, 03 May 2023 07:28:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu6ul-0007qI-AB; Wed, 03 May 2023 07:28:39 +0000 Received: by outflank-mailman (input) for mailman id 528973; Wed, 03 May 2023 07:28:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu6uk-0007qA-OG for xen-devel@lists.xenproject.org; Wed, 03 May 2023 07:28:38 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2062a.outbound.protection.outlook.com [2a01:111:f400:7d00::62a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1c5d2d85-e984-11ed-8611-37d641c3527e; Wed, 03 May 2023 09:28:34 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DB8PR04MB7116.eurprd04.prod.outlook.com (2603:10a6:10:127::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Wed, 3 May 2023 07:28:32 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 07:28:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1c5d2d85-e984-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ImCULAaXzgubtsZRDgZSe3poikXKaqzTyOFOpP3ttUfarNMuGj4AI6vGwJexNpi8FIqgc6jqG+AfidU6e4TI6snK1a3JohGTTN2dbkqeCvqCSvTeBUJ6U4CAL7gAIDi/HrPrzkPWm4n/53TApEPh92kVxbzhX0Q9juU4BA3KGDTEhg5U84sN2z/q/Cy1wAQjC+5p3MV8KiZUbUJwKlql5bLCd2w/NJlQhOrA3BggIXeHCNdjXsRsVAwfU3tC7e+SKSmtpzYpFr295deYkKCSgg1dtZLDOCg6BNr6kAjZNBYiddGn1Celm4QVucfAjarzxXUOMYKgKSW+RTEi7rcFbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XYDxzoDfSntGovRDW6SRfZYPYluyZM7hlhUJpC/rvBY=; b=odZqeaoco9TfplBEEH+wN2Wxghicz6nH4WkD3FbBoshjvEmsUObSE+iPHlLMNYLF16vp1ZNrZCqI+O5AMr1khsL8isg2kw4tH+NqpT5xy2nu1CWV6/iMy4kXRFH+fpGi88u6ylcCOqfHqx3Z+6OsZJTBpjHOZwBrAKelH8o/ySxOjcP5GDJPPMpp3itt6SvF7rQcR5omQ5CsQ5w3XtGr2W6K9XymU4bbKm+smBVQY9s50OjWHs+PkHBErjbHpwRSxKXCXP+vV9r6SrQTmsiyTvcYWMDQGE0+M4oFIHfFr2PmtQ1n+YlrClq0b5++sXavGkJXiFrXuzOcKRIxVCxiIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XYDxzoDfSntGovRDW6SRfZYPYluyZM7hlhUJpC/rvBY=; b=OeTwGPJEza4xRhOWFbJFxicoaHsdT9U5R9INUD8JwgKgz9h+CvMGT0C3ny2rAnOnVloACdCfMiwZ2gXf82CuMLT8TQUtUDWtQCkNHIN1LbGiQdTW9r8EyPWyOjTHyVbBMlz07dIabuC9n6FylFiDk54jIvYHjUi1jlE3TDWAbMpWbPERI+sv0JZQufcYuHmErIjMrj6/7+4gHRU8Lkt8G5YqMNSxjVkuodpovPSwDvz3A1xx1XadNiyEPQomqIu2YrKTZlwAwv+4L88h4Av51dVIm71P2Zokb/1fvMvyRQs4A9e5tCjxgSHTYxN1M79Pi6fPQ93jf5y6fK1RPOaUMg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 3 May 2023 09:28:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3 2/2] acpi: Add TPM2 interface definition. Content-Language: en-US To: Jennifer Herbert Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Xen-devel References: <20230425174733.795961-1-jennifer.herbert@citrix.com> <20230425174733.795961-3-jennifer.herbert@citrix.com> <91620112-039e-9e8b-9bac-452ea9ecddaf@citrix.com> From: Jan Beulich In-Reply-To: <91620112-039e-9e8b-9bac-452ea9ecddaf@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0184.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9f::16) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|DB8PR04MB7116:EE_ X-MS-Office365-Filtering-Correlation-Id: 75ae5f8d-2c46-434f-ba65-08db4ba7ff5f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Fbkuy/bRoeSiw8p5wtBUORJfFKBYxuosjG0o0PS2ZiK5eDLhv310HASGxMuf8CtsU6A/u5jwpRrYlvv9o8jUFTbcz8owzmJUClFPPc1g229gRKBaHmjwPCeWdi93O/yXgImGBVJc+eel8xe6882Zz5WaYizcP5NhLErVxvDtnKLiqo6ZyeQ6EBpbUxanDTD9y3JkBp/kb9qog6C2Ik9jnw1uaI442jRy5ESHTf38uNlzSG6oC1ZNoWtmkQjI6CXmt3wM+kpjZNbrcnRbKTss4iZFuKGHgjVEnTbSmrJTZRF9owyG0FHRY38wDe5JzVsyepOi5S9XLK2rtpjHosBclfckLh+0xrTwu7sI9clLGJy/ysLTCmjWNddkgIg6zFfdrfW1z9ECpfsPNgT0+Mok5+/yEhFislmecC5vhuT02y7UJTHXmmWLOhQZjxzbosYePTsgWaj+OdoPOfAqi5D+NEbR4PE2l8Hs68LpEVWlq83u2djvNdpDyGdTNYeX++/AQJs0p4sGn+rpDyVyMBWoylIIIq5b/gEqRHvGEDQMFFxVQjgv871Rs4mVSWVAIyVEsiKh+GOribBHLeK2nPH/N2Fm4zmPgpSyUyfr/M1+l7wKdlp2lyXzDpUDuRl2ZMIUzYZfba2l5ibDDDNZKXvDxSVWkKpuB2mITgg30YIuhec= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(366004)(396003)(376002)(346002)(39860400002)(451199021)(316002)(66476007)(6916009)(66556008)(66946007)(4326008)(38100700002)(8936002)(8676002)(41300700001)(5660300002)(36756003)(31696002)(86362001)(2906002)(6512007)(6486002)(478600001)(6506007)(53546011)(26005)(2616005)(31686004)(186003)(54906003)(2004002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmpSenRBc0kxNGczKzhUeC9oY0U2SXBHWjZ4MFpBOHlBNVhicGljNnFQcGQw?= =?utf-8?B?SWt3NlBLY2NoUVJNM05ySkdzRzFCL3FvbFozeGNvOGpPWCt5Mml2U2xkUHY4?= =?utf-8?B?SE9FSkU1dFI2MmxRQk05eHhPSlpvVXUxQS8waHdSVGJINFB1ZTNsYi9JcHBZ?= =?utf-8?B?YVRRWVZaWFhZYmFpQ2hqd2l6aENsemhFR2dNOFFJbVVmYmwvNVMxZFBkVjEv?= =?utf-8?B?dTNQNXlNbUpHNlJnYWhyckxocXRtTkFlUFVKYlNnV3VHZVE5YUtEbVZpSloy?= =?utf-8?B?T1hhc1htN2lhNU5ya1JBdGVlL2FTYVF0Smx6Tk41d3RJZ1I2MTNVeFlHNkNo?= =?utf-8?B?U0JONmFLT0ZaOHExY2cvYVQrOGc0Qm9SaWpqMHZTSndMMlp3QzRyS1JuSkpz?= =?utf-8?B?RXZxV0dLNXVzYXplUUdvZnpjRnhDUTN3WElvc29XaS9rSEQxaHJRYVRxcS8z?= =?utf-8?B?dkVjZWxVUDN6c0pFcGlWTnk0SEJEV0tzeHJOdlBLWWVqSVlBK0VMS09nVWEy?= =?utf-8?B?Wk1QNlhzcDRoeE9kakVOV1lBb3ZOWmFCWEI3d0Z4ZFNUdDFKVGtNeTVCeWNT?= =?utf-8?B?YnFrcmw3TFNGWi9GcFBCUUVVbUMzZnNtN1lleGlES0hvQWtPenBRYU5penZt?= =?utf-8?B?RnptWnpUWFRUQmJGd1ZvSm1DNEkvYnpmZDdoSW9RUjNRTmpCZllubXpYQnFS?= =?utf-8?B?d3MycGIxd1ZvYkFjVjJxRHhWQ3dicHh0TnhJbXNHbVV1TWpyNEJwdnRhaDc5?= =?utf-8?B?SVFCZXBmelVubHkwbWcwME5tbFhKRkJ5dE5CSWZBNlhMSTNWYjVjdEFRMUEr?= =?utf-8?B?aGVhZloyZHNWbUtjL1ZwSWV2WnJQdFRLOXJYYUtYZXBtRDZIQjJ3cGdwNkkv?= =?utf-8?B?UzZFcDJwRVdOK0ZnakNLdXQrUGxCMlE5VHBEaFU4N1F1K3VNWlM3V3VJbjRn?= =?utf-8?B?QUxFazM1RXFGZlRMWGtna0pHMzVVbGpTRkkwcERPNU5XaFNmdWgzQVplaFRW?= =?utf-8?B?Tzk3NUx0aTVaUno4aVFBVUVjMmxINnZaWkQ0U3QvZVRqK2tZTndkUXBtbXk0?= =?utf-8?B?QzgwR1h2UnNtRnlBbVVRR1dZaEovWVNZS0p3ZzZRdnVCSVJzYjBsYWVST1NL?= =?utf-8?B?ZTQ2Y3g2aEhXeUQrQzdxL05YMWphVzZHM01TbmtSanA4YUxQT1llbmkvVURJ?= =?utf-8?B?UElyeWxxZmJ3b1ZoOGE3cUhZckR6L3dXUGxnNDdRemV1eWxrbDVCdXNYazlO?= =?utf-8?B?UEhYcHRpTDZPaEZKdDNmMk9mdysreEk4Yk9JaFo5cjVCTHFlZW1wQzllT1Jv?= =?utf-8?B?S0NUSDZ5aVUrSGR3YTVZekI0N3lQSWdWUTh4U3lFVHZ2cjdLQldiUkVJaWhK?= =?utf-8?B?d1cyczZOaGxpOGdRN01OeUh2ajJjL0EraVZFaHgwQzBvNXdZd1VJc3NxWXB2?= =?utf-8?B?TWJEWHNUNVBxcjdRbUZOcjFiUnBWbnU3c2tMMWhIbzRHd3dNTjNBaVQybzgx?= =?utf-8?B?Z3YvZkFnTHg0UzFCOVlpZ215K3hVRzErQ1NGdHI4TnVYaFF3SmYydEdoak5m?= =?utf-8?B?SDl4QmhQY0YwdUZHNG50VmhKaEY5VEFGeDJUSEdxMlgzRGhSSTlvZmwyN2ZE?= =?utf-8?B?R2xjVGxQRWIxeTU1NEI2dFVpRHhOVkQzMGROQnRaUGZicUlFVkFNUHN0UlBZ?= =?utf-8?B?aHZGY0RVcTNLbVAyZkdjY0V2TnZHZEVEcHlsVTd3MzFrQ0M3dStRa0prbEdJ?= =?utf-8?B?TndJcGhoYkZOWGFLVW93b1JRTm1EeXUxaGNlSEhadkxGQTdsV1ozcXRmUThJ?= =?utf-8?B?aEdWNXI0Rm1vL3lPaHhUUXJlc09JeXViRzRLSjlVSUFHNlBiaytrdTc5MUUy?= =?utf-8?B?NWdqUys0cklQbkRHb0hNM1ZHMm55SmFHWXVSSHN6QmYrYTdUL1huOUJRWE5h?= =?utf-8?B?ZFBxbytpYlVETGh4UXVaZzBRVE5OdUVLc3FLTk9EaThFQUpQeU5LQm5PWkdE?= =?utf-8?B?cHFIL29rbVc1YWtaSEtFYlFiYUM2QWtVWGdUa2hST1Q3WGlQS2ZqOWx5NWV4?= =?utf-8?B?MEpwZHdpTkFJSXp6dC9JZzdGY3p5ZExEMTcycDdLdXpieDFMVzk5ZDQ0Rm1j?= =?utf-8?Q?gnlfOBVpJ6MpSW7KocQFxxUNK?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 75ae5f8d-2c46-434f-ba65-08db4ba7ff5f X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 07:28:32.0372 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6dRDS1gzxhCZD91CdmJwLdqNdS6Gl9MOOJyIL/EyjF6xRdSiw2+9L8OftWznN6guGr71PUGUhc/mZIFSNZCGHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7116 On 03.05.2023 01:29, Jennifer Herbert wrote: > On 02/05/2023 14:41, Jan Beulich wrote: >> On 25.04.2023 19:47, Jennifer Herbert wrote: >>> --- a/tools/libacpi/acpi2_0.h >>> +++ b/tools/libacpi/acpi2_0.h >>> @@ -121,6 +121,36 @@ struct acpi_20_tcpa { >>> }; >>> #define ACPI_2_0_TCPA_LAML_SIZE (64*1024) >>> >>> +/* >>> + * TPM2 >>> + */ >> Nit: While I'm willing to accept the comment style violation here as >> (apparently) intentional, ... > > Well, I was trying to keep the file consistant.   As far as I can tell, > this styling is used thoughout the file - unless I'm misunderstanding > your 'Nit'. (You object to a multi-line coment used for a single line? ) > But I'm codes style blind, so just say how you want it. Right - strictly speaking those multi-line comments all ought to be single- line ones, but aiui they're multi-line intentionally so they stand out. Hence - as you say, for consistency - it's okay for this one to follow suit. >>> --- /dev/null >>> +++ b/tools/libacpi/ssdt_tpm2.asl >>> @@ -0,0 +1,36 @@ >>> +/* >>> + * ssdt_tpm2.asl >>> + * >>> + * Copyright (c) 2018-2022, Citrix Systems, Inc. >>> + * >>> + * This program is free software; you can redistribute it and/or modify >>> + * it under the terms of the GNU Lesser General Public License as published >>> + * by the Free Software Foundation; version 2.1 only. with the special >>> + * exception on linking described in file LICENSE. >>> + * >>> + * This program is distributed in the hope that it will be useful, >>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>> + * GNU Lesser General Public License for more details. >>> + */ >> While the full conversion to SPDX was done in the hypervisor only so far, >> I think new tool stack source files would better use the much shorter >> SPDX equivalent, too. > > OK, this is where I get a bit confused.  I belive I copied the licence > from ssdt_tpm.asl, for consistancy. > > So I think i need to use a 'LGPL-2.1-only' but then it says its using > exceptions on linking as discribed in LICENSE, but um, which LICENSE > file?  So i'm not sure what exception I should be adding. Do you know? First of all I think commit 68823df358e8 ("acpi: Re-license ACPI builder files from GPLv2 to LGPLv2.1") was wrong using LICENSE; I'm pretty sure COPYING was meant instead. And indeed the difference between libacpi's COPYING and LICENCES/LGPL-2.1 look to be formatting plus an extra section at the bottom of the latter; I haven't found any "special exception on linking" anywhere. IOW I think using LGPL-2.1 here is what is wanted (unlike e.g. GPL-2.0-only there's no LGPL-2.1-only afaics), the more that you're contributing a new file (and of course provided you're okay to put the new file under that license). Jan From xen-devel-bounces@lists.xenproject.org Wed May 03 07:40:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 07:40:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528977.822806 (Exim 4.92) (envelope-from ) id 1pu769-0001n0-EQ; Wed, 03 May 2023 07:40:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528977.822806; Wed, 03 May 2023 07:40:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu769-0001mt-Bj; Wed, 03 May 2023 07:40:25 +0000 Received: by outflank-mailman (input) for mailman id 528977; Wed, 03 May 2023 07:40:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu767-0001mX-Rl for xen-devel@lists.xenproject.org; Wed, 03 May 2023 07:40:23 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu767-0002pH-BV; Wed, 03 May 2023 07:40:23 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[192.168.7.72]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pu767-000695-56; Wed, 03 May 2023 07:40:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=kvXYVl/zAq6keySiHy5yktJ5q2UYOeC69zj7hcDPRlM=; b=OU8E/atPMu/WlYT4ZfpwHDKr+X 1pvAl3d9oLRTtodR4Bj2+MwYN4Oq+ngKUeoLKCRmwzLQGkLL/bGJx3CHv4E/5qAyPQ7Ntbdkfwp2V pXG8gVfKCUufQXcAdo2KdgFcQJPB2tTs+SKXr+lLk0b7XhvMdXbIBUuyjVCCu+aLtpd0=; Message-ID: <2d764f29-2eb9-ecff-84cd-9baf12961c54@xen.org> Date: Wed, 3 May 2023 08:40:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [RFC PATCH] xen/arm: arm32: Enable smpboot on Arm32 based systems Content-Language: en-US To: Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com References: <20230502105849.40677-1-ayan.kumar.halder@amd.com> From: Julien Grall In-Reply-To: <20230502105849.40677-1-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Title: Did you mean "Enable spin table"? On 02/05/2023 11:58, Ayan Kumar Halder wrote: > On some of the Arm32 based systems (eg Cortex-R52), smpboot is supported. Same here. > In these systems PSCI may not always be supported. In case of Cortex-R52, there > is no EL3 or secure mode. Thus, PSCI is not supported as it requires EL3. > > Thus, we use 'spin-table' mechanism to boot the secondary cpus. The primary > cpu provides the startup address of the secondary cores. This address is > provided using the 'cpu-release-addr' property. > > To support smpboot, we have copied the code from xen/arch/arm/arm64/smpboot.c I would rather prefer if we don't duplicate the code but instead move the logic in common code. > with the following changes :- > > 1. 'enable-method' is an optional property. Refer to the comment in > https://www.kernel.org/doc/Documentation/devicetree/bindings/arm/cpus.yaml > " # On ARM 32-bit systems this property is optional" Looking at this list, "spin-table" doesn't seem to be supported for 32-bit systems. Can you point me to the discussion/patch where this would be added? > > 2. psci is not currently supported as a value for 'enable-method'. > > 3. update_identity_mapping() is not invoked as we are not sure if it is > required. This is not necessary at the moment for 32-bit. This may change in the future as we make the 32-bit boot code more compliant. For now, I would not add it. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 03 07:45:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 07:45:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528980.822817 (Exim 4.92) (envelope-from ) id 1pu7BI-0002Ox-1g; Wed, 03 May 2023 07:45:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528980.822817; Wed, 03 May 2023 07:45:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu7BH-0002Oq-Ug; Wed, 03 May 2023 07:45:43 +0000 Received: by outflank-mailman (input) for mailman id 528980; Wed, 03 May 2023 07:45:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu7BG-0002Ok-Im for xen-devel@lists.xenproject.org; Wed, 03 May 2023 07:45:42 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20630.outbound.protection.outlook.com [2a01:111:f400:7e1a::630]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7fa575a0-e986-11ed-8611-37d641c3527e; Wed, 03 May 2023 09:45:39 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DB9PR04MB9473.eurprd04.prod.outlook.com (2603:10a6:10:369::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.21; Wed, 3 May 2023 07:45:36 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 07:45:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7fa575a0-e986-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MVwpTULunggPn9zGNavkWQdrBfER/3JzKbUwxmQQuBvL5y6NsqfR0zTDYuT+dGo0xMI8ahINwqUitkRjHIQInxqgz56y1gAIIeDc0PBlhKlM09IixN7zGF0XqnYKIcAmcBPaCAyUcuVEfcCnRngE/0Vp/90++vFjmeelEBy3gUKqUxrOeme746AxcsArLvPjbIOdtEMXKoPRWVFMIIqVdQHmZ7KikZntNMxnO8hIy4jl+FF6NeB9Op77XWNq+Zk4PLWgUy8uBj+NMlDZT5Hz296xbU1sfdTpEusS3P9xLdaRGKhFhqM0QBGAB8Fd901NeTWu4GStBFFQT2dPlEY9ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2IxiRtGBIVXxf6pXJPzRosvgwZ0y1a6EjJDShLld+2I=; b=OnpDf8i1UFnHn4dXivQCvc5vGX3LWblNBekF9O8uMcpthzsOKggoQtl5cZS4UxsF7Pvw2sttWf/G5pvMefA07p6MkU+l30hdwViXO7LZDZXPNF+9UMaBHEsgEzd4Eo2Cwo5kGmm2THZ9bFmSapE/MhuJYfmWju+ufkgCMGKKFTJrclYmXLrZi7effwIZIwb5SivPemK8Je48PaSAdJct0cVy70R6NJQqiBfeIBn/2zVbkNZbjYuUT8AU/VGb+5xHLDA7gABI8udZakTyeNpaeZlnZSVj/Nkvw9IszdF70qX2pFDr5BktOHw3sYV0H7m+8tjC8po473cIC09p4TVt/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2IxiRtGBIVXxf6pXJPzRosvgwZ0y1a6EjJDShLld+2I=; b=27Ujovh27GP56YtYNXdVelmelfOjDCZmmHIr+GF6UWFLLsb2VN3XA1BVQIi7V4+QiWkCT4dUGQ/7oUaxfyjX3qNB2GwEdhyoAx16z6kHXKsxW9EEohe3IvRhkfXnajZKMmvNwV77aCUbvwtaQ083xJd1Vr3fa1sAEJ4iK8vlYTXfscYKzAmDGc5V4BesAHRSOxbcZhHl8F/d0kcvqm7AksE9kmg7WSBxYfRyJ589fAjvbt9AopCPoB5OJNXEX6g0eFD6Q3TN7swGInqAPlg8y12KbVPtvdXD/wN0snOANbJOfFuMBDXDb+ywdcDMJweoBTdIvbtj19vBYLeGUsfglA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 3 May 2023 09:45:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Anthony Perard , Jennifer Herbert From: Jan Beulich Subject: [PATCH] libacpi: switch to SPDX Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0144.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::15) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|DB9PR04MB9473:EE_ X-MS-Office365-Filtering-Correlation-Id: d3c6e7c2-4981-4611-4c16-08db4baa619a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tH6/wwROm5mlGVc6kVk3AGjf+NOErREBA1FP9KvVw0jCF/w/5mEoF9x0ulh+lC2daGCpAETXAfXQ+04vn2dD8ks9HMY1fM0Urhm4HOtmbsCJbREL3CswnxaMIJqUvhsR5DHYGl5kZ7lupjbPt6kOtMZuUSokzeDihQ6dT4ocmzMDvxArw4jRVjd4Fu7nBTxdr9SqBVHPS1pbh27cwLrpoIiJZymScZCvYqLra8Ky6Hp7mbdvvw0IXhLdMyMHQH2gvU6D8tc340S7/HpvN506rxDD9ODIzmzM8+s5hXy27B4IXrn4a0ALlbnD778HfFgjH+d4fYMMKZe43Xw28Uc9VNKA1TH1y2IHfa4XspeaJPjX0CS1C1HlfDgPYm4DNRLEJnr9jOehNGOLr7RPZZjUzE8OX7V3ILii4EbW878euF7NLiYskcEBd4tfCinyyzjaNhlXpSxhJHJJkCaVM2BonfGCsTcakQiOh2S/u3P0qk5MVJjneeu1hv7J699nCcPckLOeLVwpR8HJtV6QFUBAoIa7H28xGG9f4dKoTuB+QiPHWHbHhiMRxvO7kYtLlt+a7WonWw9yTpVeDt6k0i5jKYxnG1V9dE2amcy3+BH2XEepAGBKze1WZEm3cXWNjjCoKTrzDgZtD7deTmysMb1x9bDWOXLMN5ytd9kDEwO13KmLxLW+h3aeF+GTVYynX65v X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(376002)(366004)(396003)(346002)(136003)(451199021)(83380400001)(31686004)(2616005)(478600001)(31696002)(6666004)(6486002)(66476007)(66946007)(54906003)(66556008)(4326008)(316002)(6512007)(26005)(186003)(6506007)(6916009)(8936002)(8676002)(2906002)(38100700002)(30864003)(5660300002)(41300700001)(66899021)(86362001)(36756003)(55084003)(2004002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dTlqUS9Odk94QWZDaE5VY0w5MkZ5TElLekpwS0VVSEw0RTVwaWEyeEx3bUg4?= =?utf-8?B?b3lXUDEvUExWM3IrM0xGdjh4enBKcnFNTTlodWdOR2VZWXUzNmNaVnJLREMz?= =?utf-8?B?YllqUnk2NVdzQTRNdFU4a25lSWd4WGJQZmJFbXVuWVowQmtwdTFtKzhwQjRK?= =?utf-8?B?WjZXdUUzL3ViVmtEcEhva1JSVmJKR3ZLNGlKcTVvZXYxaGxZc1FWYThOZzBj?= =?utf-8?B?YTRlVUVXdUFHSUxjL0ZWQWdHaURjUEVqL0pkemdYZkplUjA2QXFFcDJuSE1G?= =?utf-8?B?ajhqeER3MWZ4UlU4MUQvRkw4Q1JCclJNb2RtTkN2Ty9NcHhKN0ZHRmRsVG9m?= =?utf-8?B?VXJKSmpGQ0tPdjVjamJSb3owbHVQY3htQ3kvMGJLMVV2d0ZiTVpEYjViRVZn?= =?utf-8?B?cXUvcy80aTJrNVJFUDlOSXNBcTdNZW90RlVKdXcxZjdTbm96a29PeUFFcExR?= =?utf-8?B?U2padUcwRTYwWHlhU3E1clhGd1NlWFdkVzltVG9QQnNObis3cHFjc2VNcHU4?= =?utf-8?B?Z3hlU2ZIOHpQSkwrZnd1Rjd6dlZkUVZpYnMrajBrMU42cjlzdjNESjdSZGJz?= =?utf-8?B?YVE4RzlkSDdJUWhXRHpGNXNSMXRXR3ZRdzhiZ0FFTEtraDA0ZEJ4MlI4MXlO?= =?utf-8?B?NG5zTithODI1UWJXNHA3c00xalFHNzBiUThob3ZJenp5dCtHamNocVlYRVNi?= =?utf-8?B?T2tuQWJXRi9qaElSdWgyRXB3RHF0ZkV5Kzdvc0s1bHB5b0JWMzY1MWdtWlZE?= =?utf-8?B?U25CYlcyRGpIcW1DWTNOa3lVbUQwUGJFeFZzQXVhR0JKWHZQR1UzWWRPcVBt?= =?utf-8?B?bEJxZ3cvSVltSkplSzJNWGRhcFd2K0RCenVjSklLemdHWDRFbGdWWUMyemg5?= =?utf-8?B?T3pxdWcrK1JidjFycGZVM09CVzQwT1VKbzRCZkFqbnRNd0M4TTY4My83M01U?= =?utf-8?B?TG42VWdWM24wcTNBSnI1di9LNVpDZXQ0OUZlQ1ZTYnpORUZSa1BMc3pENWdH?= =?utf-8?B?OWl1eEd4R1VUTDlOUHg5ZkNyOFdoN2VKVmQ4NHp3UjFpOHc2TVpXVGl1ekdo?= =?utf-8?B?M3NtdHFIRUphSnlYT3ZDVmtHYlI5VHI0dFR0K1h3YWlndTdqbzNqV1V3RzJR?= =?utf-8?B?QkRDSkpaazBHUUgxakp4bW43eERSQ0h2eEVDOEtXb3QzaDI5YnVWYlZHQjFx?= =?utf-8?B?a1pVQ2tRcTVIMms4eW1tTEdhbE5VYUdURU5YVFVOU1JIbWlPL3RZWVZsZnQz?= =?utf-8?B?WEV2cFVnRFNmMFVSTS8wYkp5cWZmdVI2dExNUWx5MXBhZ1E2b3hvWEROejFB?= =?utf-8?B?Z1Zyb3FRSnU2bDVJeWcwb2VROXBGYlhjTWtRMjMxQThFa09pNkoyVjdYZFFQ?= =?utf-8?B?Uk9LYUlaUkIrYmYybjNPODRNWGFCUm5kb0VyRHBLS2FXRW84aklwejQ2K3ND?= =?utf-8?B?Rjk1ZFNFT1Y4Q1VTVC9xclYzNDE2SWpHU0NOTHRnMkNQVlhvNUR6Vnd1WVNp?= =?utf-8?B?bGRLL1VWSFZpS0dJMnlPbml6OWpkeWJ6aU0wTGtpcGpjVS8rYUNPQ1lkU2Ez?= =?utf-8?B?RXFDa2lyUjlEaHk1c01xSit3M3JuSFRqUkViUm15MHBVdFkrUVdmbGszUjVj?= =?utf-8?B?NHlKYWRydUt4RDdCYUNCdjVibDZFQityZmVjL3p3WWRKNFdxY0lNV2d4ckhM?= =?utf-8?B?dndrUmptL2xSRENpaUVSTEFveWc3TWlTTVBGbEFXTnNweld5VnY1dENNYzJu?= =?utf-8?B?NmNwQ1F5NHVUYTNLU1dFQzdEUmJCaGxxQU9aVFVZV0NQMGozaWVnd016T2s5?= =?utf-8?B?dzA3djJyTHdHbjQ4SzU0UDJTMWhDUjBIME5mVU9ERzZSVUcrWVprVDYwcnRv?= =?utf-8?B?NGFDMFZXby9rVjlQeUhqUDA2bW93T0U3RkJQbHN5SGhkTzRFa29adStSRGln?= =?utf-8?B?ZW1DTEFsTFZnOC9TaEEvcFhiZ2o0NTYzcW5RcmFmOW0za3hLbFNITFhLWVFn?= =?utf-8?B?c0ZnYitDejBvTG9jemhlalU0RC90TEdubWN3RG1qdDNYTUFUaXM3K3NPUmpO?= =?utf-8?B?Sm0rSysrSU5RNG00RjRUd0F3cHVlcUZSNnlmYVk4NEFFSmhZb3k5V1lIR0dY?= =?utf-8?Q?caeP69tsDf+JbNtEMt7FLrhy5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3c6e7c2-4981-4611-4c16-08db4baa619a X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 07:45:35.9128 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZNN7gMI9N8VQr6OCMAu2kS51qdefEUDRtI3MCE9EnK2QRbaC4C52GMG8YRA4Xt1zD/2kWMsth2WDDHqaNTuM1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9473 Commit 68823df358e8 ("acpi: Re-license ACPI builder files from GPLv2 to LGPLv2.1") added references to a "special exception on linking described in file LICENSE", without actually adding such a file. Quite likely COPYING was meant instead, yet then its text matches LICENSES/LGPL-2.1 except for some explanatory text (clarifying the "only" aspect) at the top (and formatting). Hence replace the text in all the files with SPDX references to LGPL-2.1. Note that dsdt_acpi_info.asl had no license text. An SPDX tag is being added there nevertheless. Signed-off-by: Jan Beulich --- a/tools/libacpi/COPYING +++ /dev/null @@ -1,468 +0,0 @@ -This library is licensed under LGPL v2.1 to allow its usage in LGPL-2.1 -libraries such as libxl. Note that the only valid version of the LGPL as -far as the files in this directory (and its subdirectories) are concerned -is _this_ particular version of the license (i.e., *only* v2.1, not v2.2 -or v3.x, unless explicitly otherwise stated. - -Where clause 3 is invoked in order to relicense under the GPL then -this shall be considered to be GPL v2 only for files which have -specified LGPL v2.1 only. - - GNU LESSER GENERAL PUBLIC LICENSE - Version 2.1, February 1999 - - Copyright (C) 1991, 1999 Free Software Foundation, Inc. - 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA - Everyone is permitted to copy and distribute verbatim copies - of this license document, but changing it is not allowed. - -[This is the first released version of the Lesser GPL. It also counts - as the successor of the GNU Library Public License, version 2, hence - the version number 2.1.] - - Preamble - - The licenses for most software are designed to take away your -freedom to share and change it. By contrast, the GNU General Public -Licenses are intended to guarantee your freedom to share and change -free software--to make sure the software is free for all its users. - - This license, the Lesser General Public License, applies to some -specially designated software packages--typically libraries--of the -Free Software Foundation and other authors who decide to use it. You -can use it too, but we suggest you first think carefully about whether -this license or the ordinary General Public License is the better -strategy to use in any particular case, based on the explanations below. - - When we speak of free software, we are referring to freedom of use, -not price. Our General Public Licenses are designed to make sure that -you have the freedom to distribute copies of free software (and charge -for this service if you wish); that you receive source code or can get -it if you want it; that you can change the software and use pieces of -it in new free programs; and that you are informed that you can do -these things. - - To protect your rights, we need to make restrictions that forbid -distributors to deny you these rights or to ask you to surrender these -rights. These restrictions translate to certain responsibilities for -you if you distribute copies of the library or if you modify it. - - For example, if you distribute copies of the library, whether gratis -or for a fee, you must give the recipients all the rights that we gave -you. You must make sure that they, too, receive or can get the source -code. If you link other code with the library, you must provide -complete object files to the recipients, so that they can relink them -with the library after making changes to the library and recompiling -it. And you must show them these terms so they know their rights. - - We protect your rights with a two-step method: (1) we copyright the -library, and (2) we offer you this license, which gives you legal -permission to copy, distribute and/or modify the library. - - To protect each distributor, we want to make it very clear that -there is no warranty for the free library. Also, if the library is -modified by someone else and passed on, the recipients should know -that what they have is not the original version, so that the original -author's reputation will not be affected by problems that might be -introduced by others. - - Finally, software patents pose a constant threat to the existence of -any free program. We wish to make sure that a company cannot -effectively restrict the users of a free program by obtaining a -restrictive license from a patent holder. Therefore, we insist that -any patent license obtained for a version of the library must be -consistent with the full freedom of use specified in this license. - - Most GNU software, including some libraries, is covered by the -ordinary GNU General Public License. This license, the GNU Lesser -General Public License, applies to certain designated libraries, and -is quite different from the ordinary General Public License. We use -this license for certain libraries in order to permit linking those -libraries into non-free programs. - - When a program is linked with a library, whether statically or using -a shared library, the combination of the two is legally speaking a -combined work, a derivative of the original library. The ordinary -General Public License therefore permits such linking only if the -entire combination fits its criteria of freedom. The Lesser General -Public License permits more lax criteria for linking other code with -the library. - - We call this license the "Lesser" General Public License because it -does Less to protect the user's freedom than the ordinary General -Public License. It also provides other free software developers Less -of an advantage over competing non-free programs. These disadvantages -are the reason we use the ordinary General Public License for many -libraries. However, the Lesser license provides advantages in certain -special circumstances. - - For example, on rare occasions, there may be a special need to -encourage the widest possible use of a certain library, so that it becomes -a de-facto standard. To achieve this, non-free programs must be -allowed to use the library. A more frequent case is that a free -library does the same job as widely used non-free libraries. In this -case, there is little to gain by limiting the free library to free -software only, so we use the Lesser General Public License. - - In other cases, permission to use a particular library in non-free -programs enables a greater number of people to use a large body of -free software. For example, permission to use the GNU C Library in -non-free programs enables many more people to use the whole GNU -operating system, as well as its variant, the GNU/Linux operating -system. - - Although the Lesser General Public License is Less protective of the -users' freedom, it does ensure that the user of a program that is -linked with the Library has the freedom and the wherewithal to run -that program using a modified version of the Library. - - The precise terms and conditions for copying, distribution and -modification follow. Pay close attention to the difference between a -"work based on the library" and a "work that uses the library". The -former contains code derived from the library, whereas the latter must -be combined with the library in order to run. - - GNU LESSER GENERAL PUBLIC LICENSE - TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION - - 0. This License Agreement applies to any software library or other -program which contains a notice placed by the copyright holder or -other authorized party saying it may be distributed under the terms of -this Lesser General Public License (also called "this License"). -Each licensee is addressed as "you". - - A "library" means a collection of software functions and/or data -prepared so as to be conveniently linked with application programs -(which use some of those functions and data) to form executables. - - The "Library", below, refers to any such software library or work -which has been distributed under these terms. A "work based on the -Library" means either the Library or any derivative work under -copyright law: that is to say, a work containing the Library or a -portion of it, either verbatim or with modifications and/or translated -straightforwardly into another language. (Hereinafter, translation is -included without limitation in the term "modification".) - - "Source code" for a work means the preferred form of the work for -making modifications to it. For a library, complete source code means -all the source code for all modules it contains, plus any associated -interface definition files, plus the scripts used to control compilation -and installation of the library. - - Activities other than copying, distribution and modification are not -covered by this License; they are outside its scope. The act of -running a program using the Library is not restricted, and output from -such a program is covered only if its contents constitute a work based -on the Library (independent of the use of the Library in a tool for -writing it). Whether that is true depends on what the Library does -and what the program that uses the Library does. - - 1. You may copy and distribute verbatim copies of the Library's -complete source code as you receive it, in any medium, provided that -you conspicuously and appropriately publish on each copy an -appropriate copyright notice and disclaimer of warranty; keep intact -all the notices that refer to this License and to the absence of any -warranty; and distribute a copy of this License along with the -Library. - - You may charge a fee for the physical act of transferring a copy, -and you may at your option offer warranty protection in exchange for a -fee. - - 2. You may modify your copy or copies of the Library or any portion -of it, thus forming a work based on the Library, and copy and -distribute such modifications or work under the terms of Section 1 -above, provided that you also meet all of these conditions: - - a) The modified work must itself be a software library. - - b) You must cause the files modified to carry prominent notices - stating that you changed the files and the date of any change. - - c) You must cause the whole of the work to be licensed at no - charge to all third parties under the terms of this License. - - d) If a facility in the modified Library refers to a function or a - table of data to be supplied by an application program that uses - the facility, other than as an argument passed when the facility - is invoked, then you must make a good faith effort to ensure that, - in the event an application does not supply such function or - table, the facility still operates, and performs whatever part of - its purpose remains meaningful. - - (For example, a function in a library to compute square roots has - a purpose that is entirely well-defined independent of the - application. Therefore, Subsection 2d requires that any - application-supplied function or table used by this function must - be optional: if the application does not supply it, the square - root function must still compute square roots.) - -These requirements apply to the modified work as a whole. If -identifiable sections of that work are not derived from the Library, -and can be reasonably considered independent and separate works in -themselves, then this License, and its terms, do not apply to those -sections when you distribute them as separate works. But when you -distribute the same sections as part of a whole which is a work based -on the Library, the distribution of the whole must be on the terms of -this License, whose permissions for other licensees extend to the -entire whole, and thus to each and every part regardless of who wrote -it. - -Thus, it is not the intent of this section to claim rights or contest -your rights to work written entirely by you; rather, the intent is to -exercise the right to control the distribution of derivative or -collective works based on the Library. - -In addition, mere aggregation of another work not based on the Library -with the Library (or with a work based on the Library) on a volume of -a storage or distribution medium does not bring the other work under -the scope of this License. - - 3. You may opt to apply the terms of the ordinary GNU General Public -License instead of this License to a given copy of the Library. To do -this, you must alter all the notices that refer to this License, so -that they refer to the ordinary GNU General Public License, version 2, -instead of to this License. (If a newer version than version 2 of the -ordinary GNU General Public License has appeared, then you can specify -that version instead if you wish.) Do not make any other change in -these notices. - - Once this change is made in a given copy, it is irreversible for -that copy, so the ordinary GNU General Public License applies to all -subsequent copies and derivative works made from that copy. - - This option is useful when you wish to copy part of the code of -the Library into a program that is not a library. - - 4. You may copy and distribute the Library (or a portion or -derivative of it, under Section 2) in object code or executable form -under the terms of Sections 1 and 2 above provided that you accompany -it with the complete corresponding machine-readable source code, which -must be distributed under the terms of Sections 1 and 2 above on a -medium customarily used for software interchange. - - If distribution of object code is made by offering access to copy -from a designated place, then offering equivalent access to copy the -source code from the same place satisfies the requirement to -distribute the source code, even though third parties are not -compelled to copy the source along with the object code. - - 5. A program that contains no derivative of any portion of the -Library, but is designed to work with the Library by being compiled or -linked with it, is called a "work that uses the Library". Such a -work, in isolation, is not a derivative work of the Library, and -therefore falls outside the scope of this License. - - However, linking a "work that uses the Library" with the Library -creates an executable that is a derivative of the Library (because it -contains portions of the Library), rather than a "work that uses the -library". The executable is therefore covered by this License. -Section 6 states terms for distribution of such executables. - - When a "work that uses the Library" uses material from a header file -that is part of the Library, the object code for the work may be a -derivative work of the Library even though the source code is not. -Whether this is true is especially significant if the work can be -linked without the Library, or if the work is itself a library. The -threshold for this to be true is not precisely defined by law. - - If such an object file uses only numerical parameters, data -structure layouts and accessors, and small macros and small inline -functions (ten lines or less in length), then the use of the object -file is unrestricted, regardless of whether it is legally a derivative -work. (Executables containing this object code plus portions of the -Library will still fall under Section 6.) - - Otherwise, if the work is a derivative of the Library, you may -distribute the object code for the work under the terms of Section 6. -Any executables containing that work also fall under Section 6, -whether or not they are linked directly with the Library itself. - - 6. As an exception to the Sections above, you may also combine or -link a "work that uses the Library" with the Library to produce a -work containing portions of the Library, and distribute that work -under terms of your choice, provided that the terms permit -modification of the work for the customer's own use and reverse -engineering for debugging such modifications. - - You must give prominent notice with each copy of the work that the -Library is used in it and that the Library and its use are covered by -this License. You must supply a copy of this License. If the work -during execution displays copyright notices, you must include the -copyright notice for the Library among them, as well as a reference -directing the user to the copy of this License. Also, you must do one -of these things: - - a) Accompany the work with the complete corresponding - machine-readable source code for the Library including whatever - changes were used in the work (which must be distributed under - Sections 1 and 2 above); and, if the work is an executable linked - with the Library, with the complete machine-readable "work that - uses the Library", as object code and/or source code, so that the - user can modify the Library and then relink to produce a modified - executable containing the modified Library. (It is understood - that the user who changes the contents of definitions files in the - Library will not necessarily be able to recompile the application - to use the modified definitions.) - - b) Use a suitable shared library mechanism for linking with the - Library. A suitable mechanism is one that (1) uses at run time a - copy of the library already present on the user's computer system, - rather than copying library functions into the executable, and (2) - will operate properly with a modified version of the library, if - the user installs one, as long as the modified version is - interface-compatible with the version that the work was made with. - - c) Accompany the work with a written offer, valid for at - least three years, to give the same user the materials - specified in Subsection 6a, above, for a charge no more - than the cost of performing this distribution. - - d) If distribution of the work is made by offering access to copy - from a designated place, offer equivalent access to copy the above - specified materials from the same place. - - e) Verify that the user has already received a copy of these - materials or that you have already sent this user a copy. - - For an executable, the required form of the "work that uses the -Library" must include any data and utility programs needed for -reproducing the executable from it. However, as a special exception, -the materials to be distributed need not include anything that is -normally distributed (in either source or binary form) with the major -components (compiler, kernel, and so on) of the operating system on -which the executable runs, unless that component itself accompanies -the executable. - - It may happen that this requirement contradicts the license -restrictions of other proprietary libraries that do not normally -accompany the operating system. Such a contradiction means you cannot -use both them and the Library together in an executable that you -distribute. - - 7. You may place library facilities that are a work based on the -Library side-by-side in a single library together with other library -facilities not covered by this License, and distribute such a combined -library, provided that the separate distribution of the work based on -the Library and of the other library facilities is otherwise -permitted, and provided that you do these two things: - - a) Accompany the combined library with a copy of the same work - based on the Library, uncombined with any other library - facilities. This must be distributed under the terms of the - Sections above. - - b) Give prominent notice with the combined library of the fact - that part of it is a work based on the Library, and explaining - where to find the accompanying uncombined form of the same work. - - 8. You may not copy, modify, sublicense, link with, or distribute -the Library except as expressly provided under this License. Any -attempt otherwise to copy, modify, sublicense, link with, or -distribute the Library is void, and will automatically terminate your -rights under this License. However, parties who have received copies, -or rights, from you under this License will not have their licenses -terminated so long as such parties remain in full compliance. - - 9. You are not required to accept this License, since you have not -signed it. However, nothing else grants you permission to modify or -distribute the Library or its derivative works. These actions are -prohibited by law if you do not accept this License. Therefore, by -modifying or distributing the Library (or any work based on the -Library), you indicate your acceptance of this License to do so, and -all its terms and conditions for copying, distributing or modifying -the Library or works based on it. - - 10. Each time you redistribute the Library (or any work based on the -Library), the recipient automatically receives a license from the -original licensor to copy, distribute, link with or modify the Library -subject to these terms and conditions. You may not impose any further -restrictions on the recipients' exercise of the rights granted herein. -You are not responsible for enforcing compliance by third parties with -this License. - - 11. If, as a consequence of a court judgment or allegation of patent -infringement or for any other reason (not limited to patent issues), -conditions are imposed on you (whether by court order, agreement or -otherwise) that contradict the conditions of this License, they do not -excuse you from the conditions of this License. If you cannot -distribute so as to satisfy simultaneously your obligations under this -License and any other pertinent obligations, then as a consequence you -may not distribute the Library at all. For example, if a patent -license would not permit royalty-free redistribution of the Library by -all those who receive copies directly or indirectly through you, then -the only way you could satisfy both it and this License would be to -refrain entirely from distribution of the Library. - -If any portion of this section is held invalid or unenforceable under any -particular circumstance, the balance of the section is intended to apply, -and the section as a whole is intended to apply in other circumstances. - -It is not the purpose of this section to induce you to infringe any -patents or other property right claims or to contest validity of any -such claims; this section has the sole purpose of protecting the -integrity of the free software distribution system which is -implemented by public license practices. Many people have made -generous contributions to the wide range of software distributed -through that system in reliance on consistent application of that -system; it is up to the author/donor to decide if he or she is willing -to distribute software through any other system and a licensee cannot -impose that choice. - -This section is intended to make thoroughly clear what is believed to -be a consequence of the rest of this License. - - 12. If the distribution and/or use of the Library is restricted in -certain countries either by patents or by copyrighted interfaces, the -original copyright holder who places the Library under this License may add -an explicit geographical distribution limitation excluding those countries, -so that distribution is permitted only in or among countries not thus -excluded. In such case, this License incorporates the limitation as if -written in the body of this License. - - 13. The Free Software Foundation may publish revised and/or new -versions of the Lesser General Public License from time to time. -Such new versions will be similar in spirit to the present version, -but may differ in detail to address new problems or concerns. - -Each version is given a distinguishing version number. If the Library -specifies a version number of this License which applies to it and -"any later version", you have the option of following the terms and -conditions either of that version or of any later version published by -the Free Software Foundation. If the Library does not specify a -license version number, you may choose any version ever published by -the Free Software Foundation. - - 14. If you wish to incorporate parts of the Library into other free -programs whose distribution conditions are incompatible with these, -write to the author to ask for permission. For software which is -copyrighted by the Free Software Foundation, write to the Free -Software Foundation; we sometimes make exceptions for this. Our -decision will be guided by the two goals of preserving the free status -of all derivatives of our free software and of promoting the sharing -and reuse of software generally. - - NO WARRANTY - - 15. BECAUSE THE LIBRARY IS LICENSED FREE OF CHARGE, THERE IS NO -WARRANTY FOR THE LIBRARY, TO THE EXTENT PERMITTED BY APPLICABLE LAW. -EXCEPT WHEN OTHERWISE STATED IN WRITING THE COPYRIGHT HOLDERS AND/OR -OTHER PARTIES PROVIDE THE LIBRARY "AS IS" WITHOUT WARRANTY OF ANY -KIND, EITHER EXPRESSED OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, THE -IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR -PURPOSE. THE ENTIRE RISK AS TO THE QUALITY AND PERFORMANCE OF THE -LIBRARY IS WITH YOU. SHOULD THE LIBRARY PROVE DEFECTIVE, YOU ASSUME -THE COST OF ALL NECESSARY SERVICING, REPAIR OR CORRECTION. - - 16. IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN -WRITING WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MAY MODIFY -AND/OR REDISTRIBUTE THE LIBRARY AS PERMITTED ABOVE, BE LIABLE TO YOU -FOR DAMAGES, INCLUDING ANY GENERAL, SPECIAL, INCIDENTAL OR -CONSEQUENTIAL DAMAGES ARISING OUT OF THE USE OR INABILITY TO USE THE -LIBRARY (INCLUDING BUT NOT LIMITED TO LOSS OF DATA OR DATA BEING -RENDERED INACCURATE OR LOSSES SUSTAINED BY YOU OR THIRD PARTIES OR A -FAILURE OF THE LIBRARY TO OPERATE WITH ANY OTHER SOFTWARE), EVEN IF -SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE POSSIBILITY OF SUCH -DAMAGES. - - END OF TERMS AND CONDITIONS --- a/tools/libacpi/Makefile +++ b/tools/libacpi/Makefile @@ -1,16 +1,6 @@ +# SPDX-License-Identifier: LGPL-2.1 # # Copyright (c) 2004, Intel Corporation. -# -# This program is free software; you can redistribute it and/or modify -# it under the terms of the GNU Lesser General Public License as published -# by the Free Software Foundation; version 2.1 only. with the special -# exception on linking described in file LICENSE. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU Lesser General Public License for more details. -# XEN_ROOT = $(CURDIR)/../.. include $(XEN_ROOT)/tools/Rules.mk --- a/tools/libacpi/acpi2_0.h +++ b/tools/libacpi/acpi2_0.h @@ -1,15 +1,6 @@ +/* SPDX-License-Identifier: LGPL-2.1 */ /* * Copyright (c) 2004, Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU Lesser General Public License as published - * by the Free Software Foundation; version 2.1 only. with the special - * exception on linking described in file LICENSE. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Lesser General Public License for more details. */ #ifndef _ACPI_2_0_H_ #define _ACPI_2_0_H_ --- a/tools/libacpi/build.c +++ b/tools/libacpi/build.c @@ -1,16 +1,7 @@ +/* SPDX-License-Identifier: LGPL-2.1 */ /* * Copyright (c) 2004, Intel Corporation. * Copyright (c) 2006, Keir Fraser, XenSource Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU Lesser General Public License as published - * by the Free Software Foundation; version 2.1 only. with the special - * exception on linking described in file LICENSE. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Lesser General Public License for more details. */ #include LIBACPI_STDUTILS --- a/tools/libacpi/dsdt.asl +++ b/tools/libacpi/dsdt.asl @@ -1,17 +1,8 @@ +/* SPDX-License-Identifier: LGPL-2.1 */ /****************************************************************************** * DSDT for Xen with Qemu device model * * Copyright (c) 2004, Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU Lesser General Public License as published - * by the Free Software Foundation; version 2.1 only. with the special - * exception on linking described in file LICENSE. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Lesser General Public License for more details. */ DefinitionBlock ("DSDT.aml", "DSDT", 2, "Xen", "HVM", 0) --- a/tools/libacpi/dsdt_acpi_info.asl +++ b/tools/libacpi/dsdt_acpi_info.asl @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: LGPL-2.1 */ Scope (\_SB) { --- a/tools/libacpi/libacpi.h +++ b/tools/libacpi/libacpi.h @@ -1,18 +1,9 @@ +/* SPDX-License-Identifier: LGPL-2.1 */ /****************************************************************************** * libacpi.h * * libacpi interfaces * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU Lesser General Public License as published - * by the Free Software Foundation; version 2.1 only. with the special - * exception on linking described in file LICENSE. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Lesser General Public License for more details. - * * Copyright (c) 2016 Oracle and/or its affiliates. All rights reserved. */ --- a/tools/libacpi/mk_dsdt.c +++ b/tools/libacpi/mk_dsdt.c @@ -1,14 +1,4 @@ -/* - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU Lesser General Public License as published - * by the Free Software Foundation; version 2.1 only. with the special - * exception on linking described in file LICENSE. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Lesser General Public License for more details. - */ +/* SPDX-License-Identifier: LGPL-2.1 */ #include #include --- a/tools/libacpi/ssdt_laptop_slate.asl +++ b/tools/libacpi/ssdt_laptop_slate.asl @@ -1,17 +1,8 @@ +/* SPDX-License-Identifier: LGPL-2.1 */ /* * ssdt_conv.asl * * Copyright (c) 2017 Citrix Systems, Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU Lesser General Public License as published - * by the Free Software Foundation; version 2.1 only. with the special - * exception on linking described in file LICENSE. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Lesser General Public License for more details. */ /* --- a/tools/libacpi/ssdt_pm.asl +++ b/tools/libacpi/ssdt_pm.asl @@ -1,18 +1,9 @@ +/* SPDX-License-Identifier: LGPL-2.1 */ /* * ssdt_pm.asl * * Copyright (c) 2008 Kamala Narasimhan * Copyright (c) 2008 Citrix Systems, Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU Lesser General Public License as published - * by the Free Software Foundation; version 2.1 only. with the special - * exception on linking described in file LICENSE. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Lesser General Public License for more details. */ /* --- a/tools/libacpi/ssdt_s3.asl +++ b/tools/libacpi/ssdt_s3.asl @@ -1,17 +1,8 @@ +/* SPDX-License-Identifier: LGPL-2.1 */ /* * ssdt_s3.asl * * Copyright (c) 2011 Citrix Systems, Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU Lesser General Public License as published - * by the Free Software Foundation; version 2.1 only. with the special - * exception on linking described in file LICENSE. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Lesser General Public License for more details. */ DefinitionBlock ("SSDT_S3.aml", "SSDT", 2, "Xen", "HVM", 0) --- a/tools/libacpi/ssdt_s4.asl +++ b/tools/libacpi/ssdt_s4.asl @@ -1,17 +1,8 @@ +/* SPDX-License-Identifier: LGPL-2.1 */ /* * ssdt_s4.asl * * Copyright (c) 2011 Citrix Systems, Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU Lesser General Public License as published - * by the Free Software Foundation; version 2.1 only. with the special - * exception on linking described in file LICENSE. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Lesser General Public License for more details. */ DefinitionBlock ("SSDT_S4.aml", "SSDT", 2, "Xen", "HVM", 0) --- a/tools/libacpi/ssdt_tpm.asl +++ b/tools/libacpi/ssdt_tpm.asl @@ -1,17 +1,8 @@ +/* SPDX-License-Identifier: LGPL-2.1 */ /* * ssdt_tpm.asl * * Copyright (c) 2006, IBM Corporation. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU Lesser General Public License as published - * by the Free Software Foundation; version 2.1 only. with the special - * exception on linking described in file LICENSE. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Lesser General Public License for more details. */ /* SSDT for TPM TIS Interface for Xen with Qemu device model. */ --- a/tools/libacpi/static_tables.c +++ b/tools/libacpi/static_tables.c @@ -1,16 +1,7 @@ +/* SPDX-License-Identifier: LGPL-2.1 */ /* * Copyright (c) 2004, Intel Corporation. * Copyright (c) 2006, Keir Fraser, XenSource Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU Lesser General Public License as published - * by the Free Software Foundation; version 2.1 only. with the special - * exception on linking described in file LICENSE. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Lesser General Public License for more details. */ #include "acpi2_0.h" From xen-devel-bounces@lists.xenproject.org Wed May 03 07:48:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 07:48:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528984.822826 (Exim 4.92) (envelope-from ) id 1pu7E8-00033Q-Jw; Wed, 03 May 2023 07:48:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528984.822826; Wed, 03 May 2023 07:48:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu7E8-00033J-HB; Wed, 03 May 2023 07:48:40 +0000 Received: by outflank-mailman (input) for mailman id 528984; Wed, 03 May 2023 07:48:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu7E7-00033D-D5 for xen-devel@lists.xenproject.org; Wed, 03 May 2023 07:48:39 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu7E6-0002zq-O0; Wed, 03 May 2023 07:48:38 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[192.168.7.72]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pu7E6-0006SL-H6; Wed, 03 May 2023 07:48:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=yj+e1ojIhHwufSuyLSUso4b/P3PcU7U9UvJs47xRsIU=; b=dH+FJbRwaeuaH0NjrkQa91XgU4 bWUxDnN3om/arSYfa08X2l9tl4WL0XFPKENF8tjk7DJ1V6macCncSwzlMLeIIZRcWFKs5x9uXjWkl nASqC68QL7mZVy6R0b4pSrb7cdmZWSw+lxlgE8MHoSlwenJnRz/c9KBakpzkjZQJdAoA=; Message-ID: Date: Wed, 3 May 2023 08:48:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [RFC PATCH] xen/arm: arm32: Enable smpboot on Arm32 based systems Content-Language: en-US To: Stefano Stabellini , Ayan Kumar Halder Cc: xen-devel@lists.xenproject.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com References: <20230502105849.40677-1-ayan.kumar.halder@amd.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Stefano, On 03/05/2023 00:55, Stefano Stabellini wrote: >> + { >> + printk("CPU%d: No release addr\n", cpu); >> + return -ENODEV; >> + } >> + >> + release = ioremap_nocache(cpu_release_addr[cpu], 4); >> + if ( !release ) >> + { >> + dprintk(XENLOG_ERR, "CPU%d: Unable to map release address\n", cpu); >> + return -EFAULT; >> + } >> + >> + writel(__pa(init_secondary), release); >> + >> + iounmap(release); > > I think we need a wmb() ? I am not sure why we would need a wmb() here. Instead, looking at the Linux version, I think we are missing a cache flush (so does on arm64) which would be necessary if the CPU waiting for the release doesn't have cache enabled. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 03 07:54:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 07:54:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528987.822837 (Exim 4.92) (envelope-from ) id 1pu7J8-0004UL-6O; Wed, 03 May 2023 07:53:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528987.822837; Wed, 03 May 2023 07:53:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu7J8-0004UE-38; Wed, 03 May 2023 07:53:50 +0000 Received: by outflank-mailman (input) for mailman id 528987; Wed, 03 May 2023 07:53:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu7J7-0004U8-Eg for xen-devel@lists.xenproject.org; Wed, 03 May 2023 07:53:49 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0600.outbound.protection.outlook.com [2a01:111:f400:fe1f::600]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a2717ada-e987-11ed-b225-6b7b168915f2; Wed, 03 May 2023 09:53:47 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AM8PR04MB7281.eurprd04.prod.outlook.com (2603:10a6:20b:1d4::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.21; Wed, 3 May 2023 07:53:45 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 07:53:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a2717ada-e987-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YDh4CXiHVE0BJZWqTtssqSY/PAUkMuWOkg3SLgOyFBzEZeDOS2v5Xu1WmtN33BFQ+tEC637oKgXenG6gzTRSUiA+A4qKC3U1kR1WLf9+ikIPBjYRrdIFD+G4OIB8oUWdH3Uz990MSM3fs0hU/ZE1+wzoTBKojCPYZRkh4fqS7QFpy/1VWzeRJW9dn8frMoRp+49UtWFebHpsWFLIDdHST6eVK3Vjnk+QcGH+QSXUCkmYm0xHBIyNeLI6ptcSTocsps4X3F2BhvWja/AlZ1mLTohzyxzbbfXGBtN537Rzz/fAom0kyyECPUYNk95XCQvd6xNBd9/Y8aKxoWDMuQeTIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e9CbK7nt9CXb0fo98FUzYPyx8qOlbbc9IREixlGl91A=; b=Hq9ADPT4pF0QUafHQNiQWBKGf33xjbLJ7IIifg4w9z+ZzVeAjUHFX+zilK7tjsSZZ5li1Gj1/l93l9QCVzVYPELxQpjP3kI+FzAJx6GFjbWvnS7RYXIuEtHnAosJGIdoDwW9Wx6P0/Lwx9/IPzpYt3RXwk5fk457lA2i3Nra6dnFgWxBJ/xxBFoIywn/ydgPqh6t2TyrZ4O5Mh/GgPE4YmgIaT8ozQDAC5UaLsAxRnL3GzLzD8MhY+yijhRc9TCZxEtFNat1dwksxcoVzd/kq1r+4yX3SK3WsCncRcbG9hCopwvpCmb9fqw1OnsDaMyemdBg3KVfpeALxKPLvmIQvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e9CbK7nt9CXb0fo98FUzYPyx8qOlbbc9IREixlGl91A=; b=tGPCGEzXO44KrTyjuaUb7w+h2IEuI7m63fk/4SHAITKvKmrz/M+Wj6oNZlYZ3GmyBbCO45rKgJmwHh4DK7yGsQmkIu19MLbiOtIbGHIJ222WdAhz1x0s0/CtSPpJ1DTMMoQkmVvsm/5WueKAdkjyt+bLwS3oPnrkuDrkxR0Ww+T/UfuL3cXcF7l2WjfvpaX2/h2fUh987JgMUrpblthxz3fGBP5h49U/RBi7RMRGg+Hrr+HXYg+DvBOXgbs3NqUAwpSTgLKdItlUu86AytEeJBwQ3aFfASaLMXV6zUVDsVjtwa7+gbmGvnrPzEa4ifvl58dXkD8XzBWJ/8x0YNlIqA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <01be67ec-f7e6-f9bf-9d9c-57941ec1dd70@suse.com> Date: Wed, 3 May 2023 09:53:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [XEN][PATCH v6 09/19] xen/iommu: Move spin_lock from iommu_dt_device_is_assigned to caller Content-Language: en-US To: Vikram Garhwal Cc: sstabellini@kernel.org, michal.orzel@amd.com, Julien Grall , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20230502233650.20121-1-vikram.garhwal@amd.com> <20230502233650.20121-10-vikram.garhwal@amd.com> From: Jan Beulich In-Reply-To: <20230502233650.20121-10-vikram.garhwal@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0101.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::10) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|AM8PR04MB7281:EE_ X-MS-Office365-Filtering-Correlation-Id: c59cf137-f0d4-41d9-a495-08db4bab8567 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4+PNPvfYGfcnkB0/mi/BLaNPh6jtCB3RZfUlZVnZNoCYfU77iGq4f89mDiBz+qfb9cbp6OVY/QEts1niQAOGRO2XjI2Mb7hiRP8nFQ1pb7wFRbdvoMWujTuVIp9eFxV+DWtLMFPVCJ94MoK3gOuYku3uOuklTuhO4s53/hjU9ypc8LcB+sbmO9SYDjYUXKuNBr0GR7quMeoLxQ1b9KNvqC+nDsg4FrFrWGU6IxE5gULnX6slVOSMvWSpIqdaGIUxhg9YIx0ALsL7LRHPC3Se17eC5haaw4lWoCP4LovvC300ufgctPlGr4o+R/EnKje37w2reeVkw0TZNCeS5c9KoAjRE5XEjm5SJumIMVIqkeUDTNNzzg/fWqpLZUIelc4OJ/XdUp35BA0bgUsxzPkFYW0xLvreIvlFrW9R+WQNnrceXWsU1cz0FQ+n3LxhJ1jnLe/aIc6C9YpGJYnuLxyWWipGWUBqvkDnxWC1SRvZxAX32gviGcx9pZoAhIpS1urrmZdItYm0z2aCYk8NJ7uyF6T++D/kd/mqeh9xkWWqtSyb4H8+CzqATJLBtefGJzivf9B9BIXUbEHCMFESeB7sc4gMtxrY6PGgywFUc6AMtSYWLI8SK6EOT5hg9f63qVD7JjBngGDbIITEkaH78iiiiA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(376002)(366004)(136003)(346002)(396003)(451199021)(38100700002)(4744005)(2906002)(8936002)(8676002)(5660300002)(31696002)(36756003)(86362001)(6486002)(478600001)(54906003)(186003)(6512007)(6506007)(26005)(53546011)(31686004)(2616005)(83380400001)(41300700001)(66556008)(66946007)(66476007)(6916009)(4326008)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3FlcFBvbVBoK0tqL21jTlJsSDdQSXZLMHF3MHZjR0FvV25pVUxsZlY1TW5L?= =?utf-8?B?YXpkRjlaNUFJd05sZHZZUitqTmd1dy83ZE9HaHNQaU9jV1Nwd013Z1lJaGtT?= =?utf-8?B?RWJsQW5QUFArQUthZjh3STRnWGQ3ZEtNTEVURzI3V3NyN3F3bDJzMmFHZU1E?= =?utf-8?B?NDZBTWQ5c2RHWDhWWVYxUVNmb2NFNTF3b3VnQVNaOGVjd2lRQUVwWWZrREUx?= =?utf-8?B?eFlBSnBqV1BjaC9jTy9RTE8xb0Fqek8wd0pqR0FxbkU4WVNxRWt4aWVNclZs?= =?utf-8?B?K0dOTGxjQnBvSHphVWhIdzdXdGpRUlNFNUtTTjdXVzgwSW5WNklsUWpkamtR?= =?utf-8?B?aEtpMTl2ZUVXbDE3N1Zubm1OQnJVbklDaGNMZEJOcmdPODJDME1zY0FDb0VL?= =?utf-8?B?VlRoSjhkdEhscTYyVmU2RUpzMWh1eXlvWnBQTk1OaFgrZW5NNTdBUVZUaWVE?= =?utf-8?B?SWF0RFdGTG1lNU5UOVJGWHhTa3ordWtOS2IyakpUSm9ZTW9YSHRqOU44LzRk?= =?utf-8?B?bzNWZnpXNkdnc0tPdFhXRklPUlRYem16NjBrL3g1V2g4eGgrQ0xIb3A5ckRN?= =?utf-8?B?ejl6YUIveGdrdU96Q1hjNkcweFR6VDV1RE4yMkFwMFNiSGxhT0VZNkVkeHk5?= =?utf-8?B?TGNMVlgrOFRoQ3VrVTRtaGJBM1BTN212L1ZQRUw2UUdOU0JwN01Kalhvd0pq?= =?utf-8?B?YmdFV0xTKzBhM081NHc1MDBQLzVseDJVait0TTdCN1J4RHZFdzR3K2hoeTJp?= =?utf-8?B?WE1wMUIzaWVkRjNtQVJjRlVmYWgyenlPMGRMMVVFNlNzeDhKQW82ZnVONW1E?= =?utf-8?B?UkRNSG9oRHFDVVllaVZaK0dvdTZUdVBpUmd6bm53cDBHQnZGL1V5WWpMOTNt?= =?utf-8?B?eDR0Nk9oR1FVMlJlU0xRZnduT3Rxb1BEekpDdGJmVGxjSGNrN1hHZGtPWURY?= =?utf-8?B?U29lemY4N3dURlgwb1JOS1htSDh2eUpCM1pFTFZONkZiVCtLdVZEUDE2Si8v?= =?utf-8?B?cXh2VjVpQlZGVGthdjZRdjFVMi9vOU5yQlMyY2VPT0lDSjhFNjZtdGcwQWxs?= =?utf-8?B?ZjZoOEo0VlJqd3hjZFNISkU3d1p6Z1NGZmNuRmZJRjgxR1hkMkRETnZWcXBQ?= =?utf-8?B?TVZwc3pXcHpoUW5zWDR2dWdUdC9IdFJJODVsd01XMTgzWGRPRzVZUzh6ZTA1?= =?utf-8?B?VXFjWDVLUFlXWUs5dElEeWtaRDh6NWdnRUJNUlYybHZKQTFiTm9iblM5dTVp?= =?utf-8?B?ejBXVG9XRStWTjFhM1l6UDhlbm85dXczRmlQK2dLWWw5QnNKK2Nybm94bDhu?= =?utf-8?B?dnFOK04zY1RBYTZXK1kxclBybVFPVUk0cXd2SENaREZsazl1aUhnRS94eGtD?= =?utf-8?B?OEVTbC9wY3FWVmNFc0pCQlA3b3ZvY0J1UkZTZEljQmIvNHhjdTNXeUdzUFJn?= =?utf-8?B?Tk9DN1h6b1lGMlVqUTNJV0FzMm9FNC9SSXg5VUpZTUtHVGdMRnpJRHB5QzdH?= =?utf-8?B?UEMvc01Bc2ZnUkhIeE9qUFY5eE1HTzdSZENZcGgvblVtTzNkaDBlTDBxckpI?= =?utf-8?B?Ym83NVBqaXpaeDlCYUtuNW5SWDNyQ0lKWENRMVR4bFpjbHZSeFhTdXBTcFZw?= =?utf-8?B?UnpuaEgvZ2FjSStRa0JBUzhpdXN6RHdYZnFSdTE4ZGxXaisxdE5wcHBubWhl?= =?utf-8?B?WnlYQmFFZ1RyOCtsdy9BbzhnLzBaVHRYVWhSNjBZSjkxRzFSWDA0ZmVHVTBG?= =?utf-8?B?SENJY3IrcG51VHRQeUMzcGZ0YlMvMi9GY1NQZTF2RGsrSWVFOWR6VWhFdytB?= =?utf-8?B?aHpSb1gvcW5BRnlBREdSZFJIMDNBK2M5Q21vNXE4M08va3hOZGJDcnRLT3BR?= =?utf-8?B?dEd6dHhwYnQrZGtSSTQ3Ym5VV2hFOVEzL3pmZkZtZUZsaEtXZTFBUlBTQnNn?= =?utf-8?B?UEh1QnFsS29jclRzak9wcmhqMDk3NFI2MjlwYkxXZGw4aytFRWxHajl3Mks4?= =?utf-8?B?TDM4VGtIdnJpY3I2V2ZyWHA5Tkc4NnpaSkhuM1A2YmJaL2YvRTBacnFqKzNI?= =?utf-8?B?dGtqbnhXek5EaVh1OGFYa0hya054S2c1WWNsNmZTTTA2NjlQS04xSk9WQktP?= =?utf-8?Q?CF2/eCyAwN9FWjaUx993bnqCn?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c59cf137-f0d4-41d9-a495-08db4bab8567 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 07:53:45.7345 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3+BX5ewiv8USQ6o6sIwmlSsDtWHmyiRypJYGv2T2omrbvcjKeqbMWZ75PgpDCJsarudSbYT19nA79lJVxwiR7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7281 On 03.05.2023 01:36, Vikram Garhwal wrote: > --- a/xen/include/xen/iommu.h > +++ b/xen/include/xen/iommu.h > @@ -214,6 +214,7 @@ struct msi_msg; > #include > > int iommu_assign_dt_device(struct domain *d, struct dt_device_node *dev); > +bool_t iommu_dt_device_is_assigned_locked(const struct dt_device_node *dev); Hmm, exposing a function globally which, first and foremost because of requiring the caller to hold the correct lock(s), is pretty much internal, doesn't look very nice to me. Can this perhaps be put in a private header, such that it gets only limited visibility? Jan From xen-devel-bounces@lists.xenproject.org Wed May 03 07:56:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 07:56:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528990.822847 (Exim 4.92) (envelope-from ) id 1pu7LV-00052t-JJ; Wed, 03 May 2023 07:56:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528990.822847; Wed, 03 May 2023 07:56:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu7LV-00052m-GL; Wed, 03 May 2023 07:56:17 +0000 Received: by outflank-mailman (input) for mailman id 528990; Wed, 03 May 2023 07:56:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu7LU-00052f-8G for xen-devel@lists.xenproject.org; Wed, 03 May 2023 07:56:16 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0622.outbound.protection.outlook.com [2a01:111:f400:fe0c::622]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fa990d2f-e987-11ed-b225-6b7b168915f2; Wed, 03 May 2023 09:56:15 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AM9PR04MB8162.eurprd04.prod.outlook.com (2603:10a6:20b:3b5::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.21; Wed, 3 May 2023 07:56:13 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 07:56:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa990d2f-e987-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UiJ0wOBbjB0Qz7Au7ACpQDJLnP+cjf2b8roK6Gs4RbM1l+/nWn5veVz1WK0g4Ie5ka5kfSr0MFyITsTNsdU2c5Ucv2Fi8EEslpVhOQ+F/GkkTM2lJDJoR0j09RWxleMT7VAg5xkeuiLAiHCbMPZf9XeYpnW9dkARqj1T4wffTXofcEulugILt/J5vf3OQQsjTyI/V7wzHcSLITM5ehsbLSGYVt8fzE21fIYWwLn9cZmlH1nZW5OfLBF85gL8LdLAGO4E4pHQB5nYt/8LcVE6QkHCJ0N2cJ96jp1/q/rqNGUSlM2sEGpaHzcTTND8cqWBWRqJZg9uBKJceLoxFxAZUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V1x8YyTWyQBNdIxAs9f3haq8niI/qNnULSndmW7mmjQ=; b=epASxsusJnEMjGQas782OyL9/0RPLQ9GlFWOlkPyLznnwq3laM+xeuyvGEK0PUrsjfev/Cl+/vGnFSgn4AZKC5ESKeUfcKFP82tvlMGP4EuF4Nb90Zij6Fug1kE0f/tdjwvAsbNoOLoIzfNsqSfOV5naGLUVHvHGDqETPHuZr6jgijxXuMu7zbZgz2LoNghIs9gHbeica6Ehrsd5D1he0JIger0b7NLI7DDkODWwVH++pY6iWdL7aMyA4UNarqOlqkchQy/ha0HBfQDd3Hn7q374Qzteh5Vb51JKQ1GN0N6NoDsKMcG/GbbKdfEBJZ73B5rNdSl0IR7oPhSGk29MNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V1x8YyTWyQBNdIxAs9f3haq8niI/qNnULSndmW7mmjQ=; b=JN5Yd16lxdZbIH/2iqTkKEAY0tK7AaYH/1ehEtiPeeQqYs5B4p+kJxrM6SmGxjevCGSbdukN3vldd+voVlu6o3Z1z7SIOEy9zuI2pXTdokBkO5PNTaDW+mvOvKM5jjZ21NBM4k3yVQMLRIWu+VnoW+HChs0wz1s/aQb7FKbypE9ewL7s+h05ju0usYr9mNH2fPfZg15lPauXq63RE8CGQEVwUizHrKFs6/66ayEXMfGZkw+83UY8sm02PuWsffPMYVwkWNrUYVfFeD2rZNk+lLu3U6l8pxGwa/MdhFZYi3jJlAaoUpTJzwnvUxQ0MuyfBO00+dP9wX9TBg3kL13Iug== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7e4419e2-5715-85b7-0742-67d7cc35ba1c@suse.com> Date: Wed, 3 May 2023 09:56:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [XEN][PATCH v6 11/19] xen/iommu: Introduce iommu_remove_dt_device() Content-Language: en-US To: Vikram Garhwal Cc: sstabellini@kernel.org, michal.orzel@amd.com, Julien Grall , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20230502233650.20121-1-vikram.garhwal@amd.com> <20230502233650.20121-12-vikram.garhwal@amd.com> From: Jan Beulich In-Reply-To: <20230502233650.20121-12-vikram.garhwal@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0098.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::6) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|AM9PR04MB8162:EE_ X-MS-Office365-Filtering-Correlation-Id: d6c5794f-7e73-4445-39ad-08db4babdd5f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4ZA4Jf6cdbc8RCYktaV8qQBNMe3fhhwf4cXPspxPv6BL6SSZcUuotOCPm1qnE8vKopz5tp/4amuWkw6KTd1CFsFoT7O8g8i5Nxv4X7hP58b3zdWeMVUGbwlSXTbHk593Q7mRwTCBsiuTU4+cjcW7gtiDJfN7IU3o6kmyeEEUBRdZg6npP+EYPifT48/ckhWI8esvONOSLGh10U9/2IGrHqNUvNhDWOEsr2k4ctllIIy91ogUDePakWAFa2qJga/e4Ivtg3J15sep/UB3d2tJpQxMLQUXl2Ibbq5dZ1/+AzglcWTdJy82WjtVAOHawCE9JHMOUSWjEqAR0Z5/mbSTDUZrK5vD+MAqwUfn7oM+zhBNpyE4VJIFL/JBFLyxtcydVbfPQsEZxaHehWJv5Kxrgo4CPuwAwwTu5Y2HK1sG2WFxaViaRH2iWNnNvmqNw2xhJPgibvaVV7DmcU+cA1t2SSrcrC2c3OwtYmXdAJ7grKe171o51uRVlOD5X1tAjYwZ6RnCSpXkw3LckfXWXDaC+gVw+Y8nh+iXEK1j4/7Kc559BQwzBzG8NObmcwlzezA5TmViFIyunx+vLhUVRkCT9SDqFlVNz3OV14fUoMYYKzqvacknx/qwejvAOml/vSXC6alPw9JKI4vxQ5psc6niamzePx6rIjQsXaIBpymDibDAwwMBAipTlYP4BT34eYM1XGxQPPdPv1rIKWaztAr6hQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(376002)(346002)(366004)(39860400002)(396003)(451199021)(31686004)(6916009)(4326008)(66556008)(66946007)(66476007)(478600001)(6486002)(316002)(54906003)(36756003)(86362001)(31696002)(53546011)(6506007)(26005)(6512007)(41300700001)(5660300002)(8936002)(8676002)(2906002)(4744005)(38100700002)(186003)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SVFtcy9tQzhDYW54UkNaUU81QVNZMmRYNVUyekJFTTRZSVpyTGN0SHhlaVVK?= =?utf-8?B?UzFremRtMkg1WGYrRWFDbmVGWFVJUVlDY0s2RExPK3ZaOTIwVjM5dkJOeWZm?= =?utf-8?B?UXRIZ1RncDVxVFFRUU52dkxKWk9VMzQ0VzM4MUcxd3ltNHVRcTJOdWpqOUtD?= =?utf-8?B?QWYvRHNzK1hMTTdMMFdnaUFWMmRvaHlZNGIxQVJiMVdhbkRocjd2bmNXN0hW?= =?utf-8?B?bE0yQkw4UWFFdUJ6d3M0cnFVcTRxSTFCdlFhREF0NjJLakhVeFozSkRqT3I1?= =?utf-8?B?c3dsbGMvQmhHRm44REFTVFQyeElwQ1RRcnhrekJLb21uZmxNc0FWdk1ueUF2?= =?utf-8?B?bk5Bb2R6cEN3VTlnNG5XQ3NnVm5mVGNCZHBPcWlvMWNOSWsrZ0hhb2duN1Fk?= =?utf-8?B?bkk2cys3anZxMm0rdHRVWjlJMW1reUdJaWRiWVk3WWJoUGNMNzExL2ZJekxV?= =?utf-8?B?VTNjd29xZDRVTk1kWU5RbEl1YnhMZ0pjU1lueUFBaFdDcDFZRExBcFM3Vmwx?= =?utf-8?B?WkwrNmY4RVQ3NzA2NCtYTTVuckJ2a040bVBLQjVWRERVSUZFVWRkZXVVMkhN?= =?utf-8?B?dCtYQWRXVitmUVlna0xXZWlVaFVCeTVzMXNCNFpUT2hOeHJ3bjNaNmlKNFpu?= =?utf-8?B?bUVtUC9oMlZTekFidVpocE1KQTlQeHVwbzFtZDY1ZkdxOGU2cnNZd0xDQ2tt?= =?utf-8?B?TFhJRFNEZUswWXdUVmVrWUxLME5UVkNIT2t4ZEhsVjNCYUcrcVJLT2U4MGd4?= =?utf-8?B?amRnNzlNdDRaaS85UThKdk44ZkExSjBvOVN2M1duNXBoaUY2SDNGd2RzTVR3?= =?utf-8?B?M3BwdnNLejNoa21NNnVLWVFoeWVJYjd1VXVEa1lKZ0JOYVhsYUs1dmI0aXZu?= =?utf-8?B?V294SjJsb3l3NEp2MGhmK1kwaVk1YSs1VjZCSTNwWkV0aDRTYng3cnVNY2Mw?= =?utf-8?B?bFFKWDg1bjFBRUlwTFNmT25DQUVCK2lVaE95eDU0TktuclA2UnNNZDczU3M0?= =?utf-8?B?di9kVkhQL2I0ZVFOSzhkdDRQNnRGVW5Bc3lFdGV3ZERCNHdsZlRQRThRSDYr?= =?utf-8?B?c0ZGQitxZGNYbG5PdndjYUpoVjA2Z0toSkdNb2NSU0NtbzF0L1NGYWZZOFMr?= =?utf-8?B?WWgzaVdIWFBHcW9kVWMzQjh5bWFCSThmOUI1WGV3djdTdFhYMU5hVGE0V1Yz?= =?utf-8?B?bkFocFBWOWVLUis4U3dTcXBCMnlINDNVdHoyTDcyY1JqUEk4SFNDcmNWZDhq?= =?utf-8?B?K1JJQ0FEQmhrZDFNTkJaVm5TcWYzNlAzQ25mcnZUNm9iaG9vTUhhNDZ1RVNo?= =?utf-8?B?WW51cm95T1o2ek5jVzRvMjRDVEV0ZWZmNmhnMldmZXJjSnUxMXozNG1pL0g3?= =?utf-8?B?UjJkczIrZlVuc0VsbkxyYUNvMTdkWkFBNHVIRzRTVmJxQlVqOHQ2Zzk0dHpZ?= =?utf-8?B?L3UxZzl2NTNzWWNCMjRxeC9oSUdSWHhud0lzUnBVdnQzbzNwbjdES2xiUmRi?= =?utf-8?B?WkYrZkdPeEt3bFA2cnl2anlBcWxGZVgxNlpLT3MzZnJUclprT2VkckFNeUdP?= =?utf-8?B?TWlRWTVQUURoYk1mbHpzcE1XT3p0RUdITElQM3VwOUtKSHBlVEptcHY0QW05?= =?utf-8?B?WUNnMEtkVTEyS2tpUVlobjJxSmNSNjlvZXpVUm9QamE1SWp5Zm9zQzh0UG9H?= =?utf-8?B?SDdJeUVDTzBTenJYWlVjbWwzTkt1MTBnNjM1Z2FqRGdtbUZybW11b1ZoYzNy?= =?utf-8?B?VmZVVERPWDExeFFZOGFWU0Q3MzNrb2ZkYzFsdEJuWWQ2RFNpSFJtcy95MFRC?= =?utf-8?B?L01vYmg1cXVKMW55S2hRK282bEsva3ZXZmtRWXFFeVk3QUN2Mm5JVjVXUDJD?= =?utf-8?B?MFRpK0ZTcGZkb3pHYThwekdhZ1F4K2I4bmdmVFpxYzVzTlM3VGYySU8wTVB4?= =?utf-8?B?eEd1NXFxWkRCMC92NzJWT0dMSFRlOUxiR0lMTFcrTHllUjdLOU5ISkN0ejUz?= =?utf-8?B?aGF1TU1BYlVjcjZpaUZSRDNTY1VYOW5UbmN6RmR2THM0MlVCMVVFb2dNallZ?= =?utf-8?B?SW1xSXNBZW5INWw4eTY0QkVoRUh5dkczdnlEcFMrSTZFRmpIbE42bE1WQnRm?= =?utf-8?Q?KoIBQXNXUHOhteZcwROphLTMo?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6c5794f-7e73-4445-39ad-08db4babdd5f X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 07:56:12.9828 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pHHNVjqa6RQoHeLw3eNJnmmuFtz7yGDOIEq0NQ4rYfA+BX1qdcB6qAnUQJgfwF0+REvwT9JiOB/JsfA/vS+Rmg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8162 On 03.05.2023 01:36, Vikram Garhwal wrote: > --- a/xen/include/xen/iommu.h > +++ b/xen/include/xen/iommu.h > @@ -219,6 +219,8 @@ int iommu_deassign_dt_device(struct domain *d, struct dt_device_node *dev); > int iommu_dt_domain_init(struct domain *d); > int iommu_release_dt_devices(struct domain *d); > > +int iommu_remove_dt_device(struct dt_device_node *np); > + > /* > * Helper to add master device to the IOMMU using generic IOMMU DT bindings. > * Nit: I'd consider it more logical if this declaration came after iommu_add_dt_device()'s. With that adjustment: Acked-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Wed May 03 07:57:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 07:57:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528993.822857 (Exim 4.92) (envelope-from ) id 1pu7MH-0005an-UB; Wed, 03 May 2023 07:57:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528993.822857; Wed, 03 May 2023 07:57:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu7MH-0005ag-RA; Wed, 03 May 2023 07:57:05 +0000 Received: by outflank-mailman (input) for mailman id 528993; Wed, 03 May 2023 07:57:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu7MG-0005aa-Kq for xen-devel@lists.xenproject.org; Wed, 03 May 2023 07:57:04 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 15600c5c-e988-11ed-8611-37d641c3527e; Wed, 03 May 2023 09:57:02 +0200 (CEST) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 May 2023 03:56:58 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA3PR03MB7396.namprd03.prod.outlook.com (2603:10b6:806:39a::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Wed, 3 May 2023 07:56:56 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb%4]) with mapi id 15.20.6340.031; Wed, 3 May 2023 07:56:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 15600c5c-e988-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683100621; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=bGjhDo7vIaxEMzr49lNGjOBF70RQKgKjgiJwsZsUYkY=; b=dLkTKMOWq/5u9MQ4WnJHcqpdtLrXPwS8IzPwj+HoOCQbO+o3/xziErhx yAfh69N+58dER13PbTGbcyKSXARgeiYXUkZo1adOjT9WjSr8Y/2InRGWk WvC0vPoN03oSTxBU+U7MsoNdNK8Da03R2a96LnkwyS8rotoNrxP7XclsL Y=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 107698380 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:4JTAi6k1UzF3A60W9PW9UH7o5gxUJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xJOWmmGOPiIYmv9KNEnOd7npxwHucLRxoUwGgQ9rC82EiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aWaVA8w5ARkPqgW5ASGzhH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 fkdcWsJXzCzvdP1x5abQ/Rqpocmcsa+aevzulk4pd3YJdAPZMmaBo/stZpf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVw3iea9WDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapLTOLmp64x0AX7Kmo7LAMHClCLm+mAlE+ncNx2K 24rxQYHov1nnKCsZpynN/Gim1aGtBMBX9tbE8Uh9RqAjKHT5m6xFmUCCzJMdtEinMs3XiAxk E+EmcvzAj5iu6HTTmiSnp+WsDezNC49PWIEIygeQmMt+ML/qYs+ihbOSNdLE6OviNDxXzbqz FiisywWl7gVy8kR2M2GEUvvhjutot3DSF4z7wCOB2a9tFonNMiiepCi7kXd4bBYNoGFQ1Kdv X8C3c+D8OQJCpLLnyuIKAkQIIyUCz++GGW0qTZS81MJrVxBJ1bLkVhs3QxD IronPort-HdrOrdr: A9a23:llbhLK6BaN3+WzVkcwPXwY2BI+orL9Y04lQ7vn2ZKCYlB/Bw8v rE8sjzuiWVtN9vYgBdpTntAsi9qBDnhO1ICPcqTNWftWDd0QPDEGgI1/qA/9SPIVyaygZXvZ 0QDJSXYLfLYWST5qzBjzVR3LwbreWvweSQoaP78l8odAdtbshbnnVE4sTwKDwJeOGDb6BJZK Z1I6B81kudkA8sH6CGL0hAZfHHu9rI0Lr+eHc9dmcawTjLtyqs9Ln5VzOF3hISOgk/vIsKwC z+ignk4afmlPm+xnbnpgjuxqUTosLl1txAQOqTjcQPQw+c7DqAVcBaQrifuzJwmsGDgWxa6O XkklMbJsFu7HGURG2vvhf3/AHl3F8VmgTf4G7du2Lnvcv6AA03ENBAg4UxSGqi13Yd X-Talos-CUID: 9a23:c3kzHmP+TQT9Ne5DXSw+r0olOvAfQz7a6FfZPkmYSmM3R+jA X-Talos-MUID: 9a23:PeXJLQbtPsYJkeBTkyH92zpSDtdR/aW3I04kkbc5hOWtOnkl X-IronPort-AV: E=Sophos;i="5.99,246,1677560400"; d="scan'208";a="107698380" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H6FJtlJcw+2wB9EFVXfNpDk7wb4gGhppc4F+lsQUjoeKIw99G77CjiYzkod9t5NoIS/Bk/qeRrCCAcU217jeMZ9Nd3AeCz9Zkwm1E/gbZDCMlIvTWNe7W0RrWfOATikVqvF9/gTzzWq5JCzUvcHxJXmcQAyGl/JA1B0aBWyaUCRingH85tUh4ufVelCpBPNx1qS5NjG+t2AhiuQy9ErsJvY9Dya6PXKSn4M9cy0NRx9T+btjRbpVvaqBu+Z+tIMFdG5FpLIktaa+a4DzXYWlC6KdEoAfKjzHdbqEkqiZWIeMVh6uSDV20Ki5uQL317oC2J5w3Jd2nh/4u2/MRzrSwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bGjhDo7vIaxEMzr49lNGjOBF70RQKgKjgiJwsZsUYkY=; b=CH5+vAlLMb52jSTvR7VJsuH1SeqtLvnNjkx0GuHEhXPRQdFD6ypyVy2L69vt2X5Nx31G6tXJ0Rbpru1t2gY3NDyYxi6/PmhGG6TWh4Leb6RUrRewEJ9nZlNJuFStvdqFWHD3VUo3lKGbS2py3oIeXc2Sugu4RU3eMTAJLg7R1du4Ad5WiYFBfmgZj0XZCrJasIoI48qhC8ED9KPkIWNrVGBgeODy2Wji5cbn3b7QcrVuqHJkc8YlIDVh48W/towFNj7aQ+ZJUwjPmvsoIrdMaUPmPtbPhjiUzNaRhfu+RgXepO1YLVF1WadWlxqB16XEGvg5lLG/eFCn0R++wKcakw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bGjhDo7vIaxEMzr49lNGjOBF70RQKgKjgiJwsZsUYkY=; b=bFrAoHOXqPvp/eiaHdgpKGjMmvcZQwLhTh8R3UIYLpVKyVcBEoYf0NZL3YDb8UfCBLCt51NXdHU/lJHmLKa8iK0LL0zbcsFCFwgRw6Xh0Lpo2oVoVIEJUuyrC0jO4IzjD0qvlflybsRLs07SgUTTVjsEJ0R+QtgXNFJb/wequYQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <9e9927ec-dae4-c204-73e4-a534368bbddb@citrix.com> Date: Wed, 3 May 2023 08:56:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: Andrew Cooper Subject: Re: [PATCH] libacpi: switch to SPDX Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Anthony Perard , Jennifer Herbert References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0316.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::16) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SA3PR03MB7396:EE_ X-MS-Office365-Filtering-Correlation-Id: 6a11f186-01b5-4919-dc9a-08db4babf6bc X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nQ1WEvjeLhboXYbS57F09TxQOgx2xKDbDTudFDG5cz2wxqF/yv7Vi18hUfg4bra4QTAsPcdK3PZyA7u06iLuDPEJSQuTt6XIlJLYGnRceWG2PGVZloSXPOsjV1enOWTGHxslhR5qhNw/8S4bOdGXzsBY4tr5C7byIXJGCJnvSNK+AMjSKuL6klO/69qNVq6Z0XUkcqatwaQiwC2o30fejKFG38iRewUBRr8npA6Udl+yok8QbnPjM/tH7IOj7khRUvfFgZs+P3AHADWNHetlLBPCuqb3z+E8amEh8257DSMI0d6LK9qCN1gpv3gU3WELPa+y9uIqRJfjxz1UjtnDyjJDn/lUOIix0CJq6ENNZ6535x3uDOuL1k6GfcQDQj8GVZychUhf31+zKPdtUrOfZDOXvfHBIlhRKio1cXOKw49dIGZ6XnKjyHJ5NYIn999MLE37njfslPSBWbMXkwDBPKzaeM35adNjxnOjykENaicF9qC80uwc8PDd8iD3VVXN78r5fp13gnShlRuLLp/ww5Dh8QjTOeKhP7hF688VVPvIcPIU1WdZgFGD6tit5EO37rB9LnMOt0ECngkAyjlTr9/q7ZixkCL8ChFzrtM3Xy3OrCix1MBD2imTDiWy+uGacILVJCgb/j6IEQvZcaYQWA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(346002)(366004)(396003)(376002)(451199021)(66476007)(53546011)(66946007)(4326008)(66556008)(6506007)(316002)(86362001)(82960400001)(26005)(6512007)(31696002)(110136005)(38100700002)(54906003)(478600001)(6666004)(6486002)(186003)(36756003)(107886003)(41300700001)(8676002)(2616005)(4744005)(2906002)(5660300002)(8936002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3RoU05OZTR3SUhvUmVyL1krRzZjZjJ0VzRNSnppMi9LUVVyd0dMWndGM2Jo?= =?utf-8?B?S0lDVGNXaE5hMmpCSVp2VVZFOXduTVpBWWdvQWZvY3E0Y2JmdTNWeG9VRlh4?= =?utf-8?B?dHFKQjRnb0M3QU1vMEJvaHppcVdqREhjOVErZk9JVUNCanNjMkt2YWdoUEJT?= =?utf-8?B?S0dKaU5hdjdrdy9OWEV5dHhrclc0UkZObUIyWU16ems5WXd3dU5Nck1uek92?= =?utf-8?B?WWdGZURaeElTZ00xK1lENmhsUXEzdkwwMHA5cWgvTXlaUUg2Tkw1V25Jek9l?= =?utf-8?B?c21GRldxeVNqa2dPVjlTVVBRYkRCeFNGWjhTK0t4Y3VHUVV4QWRqMUhiUlBk?= =?utf-8?B?UDZwYjRkMS9kMDlBSVg3cTZtVU1iamxJWWhsS0pXTTFrcUhGZ0RNc0dPQXc4?= =?utf-8?B?UjR2Z2VDc0lTRlFxY2NZamN6VFdtajhUOVFMZS9SZkJCRzFPbzVjazd2Rldq?= =?utf-8?B?cFVWem1VdEY3ekJWV3VUbDRWVjM4dFNsMThwWkxjSGdSc1MzZmZvQ3llU0hk?= =?utf-8?B?OVI4QjNSWFNCSXNxenI1ZzNPMlJhOUY1dzlTeTU5ZW02QktPWlYySWhSakdm?= =?utf-8?B?ZU5nL3BsMWkxTTEwNnJPRGwvVlZDRFZzenVKSWJMWTJGWWdOVjlSb1FHMzky?= =?utf-8?B?ZVY0VEY5MXlHQjRpWGEvOXpWODlBT0trY3RYZVFxZUVmL0p5d2dHcHNtWnU5?= =?utf-8?B?Y09jYWpwN1E3MmJCM0N2cVlwaUJjbUxSTjBleGhGbllsWFpHcXkvcnI0QXVE?= =?utf-8?B?M0kycmhyUXVodzQwRVdtNFp2MWRqSW9PZE5HMEFCQTJ6NERnUmw4aUFBaDFk?= =?utf-8?B?azlYYytsV1ZxT3czMXBDbHlmN1plcHluZGVldnpGSzFORDc2M2JWRU0vdjBr?= =?utf-8?B?MnpwbEpwcll3WEJ0VmF2WjNETGt0WnIreHVId3BBcEFySGgyS0VkM0F2ZVky?= =?utf-8?B?WkRNV2RTYm5yMktlRHdBekxVMDQ1UXBFN1I2M2RlK2tVcDVDSXM5WlAvckth?= =?utf-8?B?SUJyb3RLTVVpUm8rRkgxTlJJQ0QxeXhybjJ1b3BqUFB5eXBwUVR6WlRMWG5D?= =?utf-8?B?S09BcXI0K0JuemhWL1ByV0lHTlZXcHQ0Ykh6T0syN0tFV2Q0dTNrREhZcFpR?= =?utf-8?B?SnczYUs0VWYvcUgwMWRBd2pmc2o1VEJ6TUNsdWJldW1KNUtMQlg3VC9tUlI5?= =?utf-8?B?blRnTlRRdnpZM2dmNE9iSUxaY05nbEIvTEJmWkhqd05DM1RuRG8yaVpOMW9n?= =?utf-8?B?ZkNFQTlua2F1QlJtTWtDcTdhUXlnUTl2QTVDZnhuT1o2YUloTlZMb3hVVlBN?= =?utf-8?B?RW5YVTlJK1hVRXhLVUovNGxMeXdGRnRMb1R6RCtIWW5xaHhiU2dsNW5RYU91?= =?utf-8?B?UHdjaGZ6K3U5aUVoZkVFdTViQjVFdWFpWnUwbUtsNG9nLzdtOHQ2NmpwaDdp?= =?utf-8?B?bEtXOTJ0Z0RTbExoT05iSisrZ2lpTmpvVGQ5TjlNR2JuRDV1bDNtZERSQXZu?= =?utf-8?B?RGFzaWhacUxRWHV6NlhGOVBjOCtSZDNqd0N3Y2R6b0tyOHVnSEgweW1pRVB0?= =?utf-8?B?cjF0ditha2JFdDJabFBJMVM2K0ZuVE9Za1NaV2ladWs3ZUR2Lzl4Um81YkFH?= =?utf-8?B?ODgxOUQya1FUMDhYUkJjcmNHNmI2TUhFeFZ4RzdTR09Nd0RuVWd1Zmk3S0Mz?= =?utf-8?B?aGNBYmhuTGJaOTNsb0E3TnJKb0s3bExEaHRXQ2dDNzdIM1dwd1RBY0RCdzg3?= =?utf-8?B?SVJEeFA4SGIxSGg5eVZ3L2FZZFZXbkxJd2svS3orRkNJcUI1TG9zcjhyRWxE?= =?utf-8?B?UDN2YzltczNPZFNwUlRHWEMxUFhqVGs5aTNqUkh1TzVpTzQ0SzhXMm5PeVI0?= =?utf-8?B?SzZ5VjlHaTEzRXNaMnd4emp2S3Z2S3EwUU9naXZ1bkI5N2dsV3pINUtXZFkx?= =?utf-8?B?c1hHM3M2d1hzaDgreThSZzRrNkZ2cnJuZGY5bk04a3JHelcvdjVhaGU4Nlox?= =?utf-8?B?cU1ZS1RGZEhDMGkwUmpsRjd0ZG1qZkc0RVQ0cnZ0bWdNdmtzV1BsL0k4ZUd4?= =?utf-8?B?R25vZ1FQbHFGRXE0bGJKZTlzTDJvZXU1eUVDczNLTXA4YTlZNHZIR0Z3Vjd0?= =?utf-8?B?SUx2UlcwdkdzbWd4WndOc1h1NW9vTkNjbVpmNXBrb082QkdWR0M1dHJlWGEv?= =?utf-8?B?aEE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: DbpQoi6pHE8EcAQdYaUaWMVGefJ9aUIYxFVes96lZvYQLVZIOLtbmGbk8wK41QUoWaGUKneFxDSkA1+hx7Uw42oX4AmeB+f6dJRUWLLU0LyVAQ/VAqMVIr/YTgy/J/dISlXKGcSAlP2yB7v0DQscL4sN9qIAbujBuZMjpaGKZ0jLjvVbRlj8ZApUYI5cQs7FA8C7iAzL5nXdEiefg5KToPXVECtB9lD8zCzZeYfTfO4zHQMF1xPS7ylzCZ2rCpg1EL8qrqRcabBwOCO1TRZGrvx8PwNUyCWwtPylOuWpvbnYAfXwGv6lBV+pb8iabQPWOI8mV3mtR5hlkSchTH7MYgDnUqTamaLiS0CKz+eY8yxmdx6aHUEqn8L7vFageSEtDnt+Le4MBhLGAKzCN2alPWaBZmiXYkAhH/aL4ZnvzKfeYejLR0ANsDMX0PvLlJiowO0auW2OQYIJNq+1mf5SKWmROGNs9a8NPO2QN+uiT3AWWThik/Zz2aWgAp2VHxjanBWWgQMHIZuxmoJbs8Ykr2syZdZUoFl5Q6W9oLc/Rm1daM4m0DBB0ynxXx2ie2UzkoVBNcSsegwtCaV8+WZNoRB8VIVVazFJVktW0uXMP3/MmnM4ss92BfyV/9DMJ2CJS3wRWfzd5ao6/3S4WQQwQm4JKJVOQwET9IYaLvntCbRdxH3hgLnsHdVTyCAbVaijbY7EqbGwHKqzy/OIarFp+oHkjx+rmjIxVtD5acT1Zj94O/vLTPWSG3BT22aRdaOOdLqVVGpxnPu3opaXTIQCAuYSyAFnExiQPSwTChH3mlllLeLmAE/yMihIuMSI4YFGMRYgPIzmFhSrolGUJGC8hQ61+CEd35WNDa7lTwQT/N8= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6a11f186-01b5-4919-dc9a-08db4babf6bc X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 07:56:55.7541 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /FViMrhnaLElDVjkoe0rnwROErnSaw7yGYxF+Lq8x6kQ5hYl4e3FHlL/T4oJUfVoPWETcymwBpIebYzzGrIeDNVVb6zlY3JnOCYhUpOJZeE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR03MB7396 On 03/05/2023 8:45 am, Jan Beulich wrote: > Commit 68823df358e8 ("acpi: Re-license ACPI builder files from GPLv2 to > LGPLv2.1") added references to a "special exception on linking described > in file LICENSE", without actually adding such a file. Quite likely > COPYING was meant instead, yet then its text matches LICENSES/LGPL-2.1 > except for some explanatory text (clarifying the "only" aspect) at the > top (and formatting). Hence replace the text in all the files with SPDX > references to LGPL-2.1. > > Note that dsdt_acpi_info.asl had no license text. An SPDX tag is being > added there nevertheless. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Wed May 03 07:57:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 07:57:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.528996.822866 (Exim 4.92) (envelope-from ) id 1pu7Ma-00062b-8j; Wed, 03 May 2023 07:57:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528996.822866; Wed, 03 May 2023 07:57:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu7Ma-00062U-68; Wed, 03 May 2023 07:57:24 +0000 Received: by outflank-mailman (input) for mailman id 528996; Wed, 03 May 2023 07:57:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu7MY-0005aa-89 for xen-devel@lists.xenproject.org; Wed, 03 May 2023 07:57:22 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 208a384d-e988-11ed-8611-37d641c3527e; Wed, 03 May 2023 09:57:20 +0200 (CEST) Received: from mail-dm6nam12lp2174.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 May 2023 03:57:17 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by PH8PR03MB7200.namprd03.prod.outlook.com (2603:10b6:510:238::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Wed, 3 May 2023 07:57:12 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec%3]) with mapi id 15.20.6340.031; Wed, 3 May 2023 07:57:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 208a384d-e988-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683100640; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=itWKGxrLUCqshMYvXypKtCJ+px6WnIaXc4zX2RJ0me4=; b=QvfZuZV3On+WCHkSM2gC+s1QbZ0IyibG/dptgvIrAivdgQBfF4lIVuLP +Jaj+TLxt15RbXAHnQ5P8tqWEV1T6KPWtZfm6mDIaqPuGEhSqSfhsvpcy +vml2ZsX12ckDzokA3AZY0SBn1uoT8YHQteFs6cV6DoHPTR5AVxlNk/Uf 8=; X-IronPort-RemoteIP: 104.47.59.174 X-IronPort-MID: 107698403 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ZMeSbq0VZUnqLDhPsvbD5Qtwkn2cJEfYwER7XKvMYLTBsI5bp2AGy GAfC2qBaPzcMGahLdklaN7i9hsCupeAy9JnTAM6pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS+XuDgNyo4GlD5gFmPqgS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfBUVN/ sY0FzkxYDfchsbm/OrhSeVrmZF2RCXrFNt3VnBI6xj8VKxjbbWdBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqsi6Kk1AZPLvFabI5fvSQQspYhACAr 3/u9GXlGBAKcteYzFJp91r13rCRzHOnANl6+LuQr6JqokWV9kMqNQQNcxy5m7qYsG+GcocKQ 6AT0m90xUQoz2S7Q9+4UxCmrXqsuh8HR8EWA+A88BuKyKff/0CeHGdsZjxOcts9r+ctWCcnk FSOmrvBHidzubeYTXac8La8rj6oPyURa2gYakcsSg8I4MLqpo0puQ7eVdZoEKOzjdrdFCn5x naBqy1Wr7wDh8kG/6a251bKh3SgpfD0ohUd4wzWWiep611/bYv8PYiwswGEsbBHMZqTSUSHs D4cgc+C4esSDJaL0iuQXOEKG7Lv7PGAWNHBvWNS81Aa32zF0xaekUp4uVmS+G8B3h44RALU IronPort-HdrOrdr: A9a23:0rf7RKGsRo6H44v8pLqFrZHXdLJyesId70hD6qkRc20hTiX8ra vBoB1173/JYUkqKQ0dcLy7WZVoIkmshqKdn7NhX4tKNTOO0AGVxepZnOjfKlPbakjDHuU079 YeT0AXYuedMbAQ5/yU3OF2eexM/PC3tJmNwcPi5zNVSwduApsQnTuQyGygYzNLrM0tP+tIKH JYjPA31gZIAk5nCviTNz0+Ru3eoN+OvIv+CCR2fiIP2U21lDa177y/OASZ2xp2aUIz/Z4StV LdlhD/5OGFu/W2oyWssFP73tBtgd78zdkGItKKhtN9EESLti+YIL55XqGEvnQOgMzH0idTrP D85y04Oth16TfqcnqrrQDL0w3tuQxekEPK+BujmH7+ps68ez4gEcpGgutiA2Hk13Y= X-Talos-CUID: 9a23:SbAwbWMnPi/O1+5DXA1k/3Q4JckZfFqCzVOAHxfiCmpuV+jA X-Talos-MUID: 9a23:NGDfMQQQdlb3Ybl6RXS12DFALMFYzJ2TEVsr1pc8+Oi+FBRZbmI= X-IronPort-AV: E=Sophos;i="5.99,246,1677560400"; d="scan'208";a="107698403" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AeuASqqABLOx1yIhEZqX8BvvtOQu2Dy6rm0gYmAHfl4fsmri6m8h+iqM2Vuxq3nPJF07HPMRHUO6AULxHbMTBtgvJ9rf739/JvKmk4VvgIXee5hPaFINgZPu235r4bGTY5Zm4L+z12g9Z2hbGK8VJfazqLGJldu3es7vrCdKfLMhEYusJpiRdXcpBN4TL1cYayJiaFS17X70dgtJOfBp+OpENzeYqXpxGJx17hwjFSaXdVsofu2z+hvcXWqRnoYixjMAhw/ONaILu46tcS1GzJxoDo4Lvc6T2J4Mb37JfDXl78Kk2f2s2aEWpx/gVkwtQXy/ebWliVbOLzjd6R2TIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4SE1h/hbxFGyTWQaiwT8El7+ijhYgcZMhFhy29wQyVA=; b=nR0Ydg74lKq7NF9gh11WFe5rmxaFxfRStqRhBZjZOTtFycXd94E3bA3WZY9CyXgCNR974SU3cuGedQfTRlV2uR0pQJ4qAVRzWrIRV9EDACWVBkMSDPuz5ew0nFOMfOgE8osQamUaeWg5vNkfnF1DaBTGZDRNNQYsikSY9zjWItOPoZS3NAd02k+4A+t6GGIUOvTdd/DkUC+Vb+WcoE+goYN2xa7TtlU+OxRuQUttLhR8aLvHrpgUE+OWC54zHV1Yj8YUtVi3ayfF5LbiKA3J2joxfSlcbSD5l/nMpf20Plo2ipbqa0HthT4iosL0EiWFzTVosRc02jhA9chyRxM3uw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4SE1h/hbxFGyTWQaiwT8El7+ijhYgcZMhFhy29wQyVA=; b=qGfxJ31aT/umzKH4CRGEKepOM3knajT64UfVs4ekfO/Qz0d8YzwbZeFVNwT1WKJiw6wCVr/gputai1cmtt6bjZnHGKwxh3B2lfI8/ciwNwWflI0t1c2xelc50gfbDG2TWg5so+FzIA5aSHhr+rDncXLDBfKjy2c/+UN89cL/MO4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 3 May 2023 09:57:07 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Ross Lagerwall Cc: "xen-devel@lists.xenproject.org" , "jgross@suse.com" , "sstabellini@kernel.org" , "oleksandr_tyshchenko@epam.com" , "axboe@kernel.dk" Subject: Re: [PATCH] xen/blkfront: Only check REQ_FUA for writes Message-ID: References: <20230426164005.2213139-1-ross.lagerwall@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO2P265CA0152.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::20) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|PH8PR03MB7200:EE_ X-MS-Office365-Filtering-Correlation-Id: 5ac2aa51-87e0-4f92-d8b2-08db4bac00d2 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wGF/M20XJenEdc5WJsI03d/3J2Mw7006RagmapNu7QGhn0GiMNHcIPUvjcEYDEbYVQyOhdxi2CNYhx/wNBt11TXF9MII7R2pdMmP2+MvHJc9AqBMO7SPfYPtyMNZbfdj9VA71zRDeu7QG/bCoELU20Y0wtfPl7UvUxtE5WH32+dTGdn7/Qbj33/y6l3chgsIdRnstmGx2vOYW06i9EH2Sraoz1xxjjaESU1S1vc8jJr2DIxIE1qHW61Pi47tibAIqR5lYqJbpxsubTx1/2Bn7HSHKV5+DcJN1cwkdbpyChn+MVe6kV/mjhUNBNvo+kJXJ/okZQ8X3/xkZkwDkhH625pG2jshugnHT7VvSzgiVJhBi+wWiVWpBZiWv6xNvRs2ZnD44rK3WoRtbTXMbkCrZy2hll3juMmph+eeo4WJInSyTnUFH9DfiGyDvgbvSnWLtXRpCHYnoWRMZXxi9zWGOKMWNNTLQhg2BxUARM1ZiKFUNgZisicAVEQQhlahWNwaA/XaLmdE6NLxIKu8aR3Kw6b8eQtQdl06it3xtWEwOJhdCNFuLdoVwvCKrlLL5ErXggThecenHx6rLDddjG9j/iou/MJAqRnK3yTdrY5jsRU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(7916004)(4636009)(346002)(396003)(136003)(39860400002)(366004)(376002)(451199021)(478600001)(83380400001)(186003)(4326008)(6636002)(66556008)(54906003)(53546011)(9686003)(966005)(6486002)(6666004)(6512007)(6506007)(26005)(66476007)(316002)(66946007)(8676002)(41300700001)(5660300002)(82960400001)(8936002)(6862004)(2906002)(38100700002)(85182001)(86362001)(33716001)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M0JZRDBVVlh2UUlxVTJJYlNEajEwL2FKemxoL3dHbG5Xc2tDVURQenFyV3ZJ?= =?utf-8?B?UFRnN1hFMVg5RkpFNnRsNmhoNlN0cUc3MGJEd2FPcHAvZFBhc09OT201dnVT?= =?utf-8?B?aG1Na05GdWxMN09jRjdrclVvN0VqcEhMamRnYWlTUndaa1Nrd1VyQ3JiYlRT?= =?utf-8?B?elJRS0ZRUndDVjRIcU1rdVNDRTVzTERZbjN3TkRQM1M2UmU1bE1oQVZucWxE?= =?utf-8?B?aURyNDhFenlVVElsQkxaSDI4NFEvREhOSVVrZUdYdkFZNWV4dFF1OFR0dm45?= =?utf-8?B?TzlOLy94dWdNeWlId3JqdTFKY0JCUW5NbmxDbHFIemZmdjc5T2V5aEZhVUJm?= =?utf-8?B?OEx6VEJNV1B4Tks1WTR3TC9pR3ZmWXp1M3NjUkVoODJCVEZnQm82b0pxQlZB?= =?utf-8?B?OHVtbkZOM0I2NUt6N0lSSjB0MlVjSDNaZGp2Q1pqb2Rld20yT0hCOE4xOTZV?= =?utf-8?B?V0NLSWpoS05EemhENXYyWWVaU05XOXNBamxRZUp3T2I3M3BFZ1h5OGU5VnlP?= =?utf-8?B?YUxWOTVPOWdUR0tVRlJBM2xQak5YNmRibEsyOWxtR05TdUJ4SmpIcGRFU3ZZ?= =?utf-8?B?UDNENFlyMnV5Um83blR3N1FUWDlPb0JjSXJjM2VmZ3pQd01Ia0l4MGZ1STRU?= =?utf-8?B?MnRIV2RaZjdFZnpMVi8vVVRBMlZxS0pUdVk0V0doekwzQjRtbXNhc2E2Mndk?= =?utf-8?B?RUE3VkJXaTlwNXhBK3BDSlBGaGVmOEFnQ2c5UW10SFc2c2JFKy9rUCsrdEY0?= =?utf-8?B?ZzJvczdLYUNnMHFGY0RBZGRsMHZLa0h3WmZnVC9iRy8wSDNRZEJTRFYvNVhG?= =?utf-8?B?ZkhNL3ZsT1JZZHRUTlcxY1BsY1ZlLy9mVFJQaERKOGNOaDdFTHZVWUlyNk42?= =?utf-8?B?N2dIemt4UWEyL1ZoYU04bmRiVElrUlVMR2EyYlh6MTlkcmlIaVh6bDZuam9K?= =?utf-8?B?eW1pR3pYK28vaFh5K1MxbGhYYnUwM0RsRVZEYS8vcDFFU3drUlE3SWFsdzBw?= =?utf-8?B?VmV1WStWQkRmWkZXZ3V4VjM5Uk1iWDYvYzdQT2FyMFJQQjBUSHM2dUdVU0lZ?= =?utf-8?B?V2FIaHdOTFcvaXlJZ3JveEdyVUtBZjFobFNEeDU0YWZMd0RwMjlQZXYwUTVo?= =?utf-8?B?TVdLQ1ZrVWxmeGdmeW5aN0lZZGpVbldyUEx1OGhPUVh4MXVtNTFlM29qYlZU?= =?utf-8?B?VVlyYU9nZVVZbGtvZGltTzJoYnIyTm5Sd1ExTHk3Z2hza1JoYkdzbDRTUHN1?= =?utf-8?B?L3hWM2QrVUljZEZkM0M0VmdVMjVEZ0lNazNQZE53U0VOTEhOclVraVFMTlFF?= =?utf-8?B?U2xpb1N2U3VmNU55RnhHRXR4ZFRVY2ZaVlpOZ2dXb2NqSzlicXVnbGZQT1Vr?= =?utf-8?B?WG4ybkdZUWF0M3BaR001NUZsSk5Vb2dXVFRCcldxdE9nc1ZjMkR6SVNsWTNF?= =?utf-8?B?eHZyZStIUXA4Ymx4dEFLeUt2NmtHRUpPK2U2emgyY1V1QmRmbzJCa0NCSmIw?= =?utf-8?B?K2lpKzYxYXVuSTJFYkpNdmkvOU4ydkJ3Zm9rd0VBS2ZOUW8xYnovb2NlOGdQ?= =?utf-8?B?UE9ML0FUUlNlNEE0Q3JEZEV2UjltdVVTMXFDQVhCRCtrQ0ZTMWdqL3djRWZl?= =?utf-8?B?VSttYk5Pb2RSTzlyUkxRWFVIc3dQS0JJOHdVTFJlV3VJK05XcnlxT00vUEV5?= =?utf-8?B?MEpkbE1PcFM0bWt3QnpWVW5wTHI1eTN6eEVVTWx0d0xMWVh4UkdnVExESy9Y?= =?utf-8?B?WlRwa1l6N2xWR2dRK3RZa29rRkFaQ0FGUUlObU80d3kxbzhBeFNFQnNxaHpz?= =?utf-8?B?VG03VXZobmw0Q281clc4ZjVKMmxoTkxBT3dTTVRNeklmbThLNE15SVVZL2JC?= =?utf-8?B?VkJGTTBnRkoyTUtTSCtNN0pnNGF0Z09nR0E5WGdvSkZmZk1waTBkaFFIcHJi?= =?utf-8?B?V2IrUGtOd24wUDZHTjlTWHlDd05zd0JNUjQyMWZHMms1VklsVkRuNXFSNnRs?= =?utf-8?B?L0ZqbWJOU0RGaGo0QTI3UTdyUXgybFo3NG9DL0FNUmtEYU03NjhzK1plUVJV?= =?utf-8?B?d3d0NmdVZ1pCWDdoNkxvdFFzRUJMalI1V3gxNDhLUTF2UlNtYXJkeGZnSnVi?= =?utf-8?B?QWJqcS9VbUdKaVFOTjJLdXJsc3JocS9pdkZjeldPMU02VklLWHgwanhtUVFq?= =?utf-8?B?K1E9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 8ewb1XD0ZKu+1j2l/D3I8loJVw0bdzx4B2dvY7XcCKCySe+wwZVUd4vpZjMaoDc/J5mjhWote+LpwhrNg+GEY+UagvQBMzku9jBgXPBkaVOuReyYZQmhdHLiKr1imTCMtB+QI1t9LT1nDnusHKmcRQDmjZBAa0xZKP5xoQq+++EqNZJi4eYeYcaldy5yzgaGO7TFK4kxDr8j4QnU1m3u8wrqbXUcXZ9iX2OcjGB7AgTvrf282QLr/BcAnpFt/2V2VwzEoVmIHu1B3B/sKR3xmVAOFvI6UuqssIdAno/duu+uqoq4tYUNdz8mjIhq3IeOefvttnsNSZoVrUgYyq6t3YBia5gZsWgEA2G5hjn9HS2zUcA4dpIQ0uNa+Q22PMBB4WQFCX1/FCpPiQf30MJtBOua0+kffp2/ZzzIevmNfhQbw7EbrjC9CO6SZEmxd8irG0aaETF3pNhjPaRLR5BWehAvoxC1uydAnEYhW03YLXmxXjZiJ+zLfvreTdW8jzAN/WgpaP+5DK9w+xnLenxtRYwoY0PfluBfbUOZGWhxtJnimXo4UbrdSKS8DRT2ihLz59ohTNWbivQQfYqDq89V1e5+oy3St3KrQIx7HFfPSduA+biauL4CPZvC1dIxozwCw/E0OP8tQpfBcb+Z0H6PxxvUbyq6k6lOjCvAotINbphDGcYMjWyeZ02FfqlrIQmwOBkpOaqoWMwEHK3bAXvnCUSMJgXAvtfWrSsYdZ7XRrLqOHISTbMt4sPSxDl9P4E4GXpoKa1nwr7U7mZP3qxs3c9yeM//arTnxZutcysfkWkMKM4cWMAy7SqEvS8dTSdrHlzB3BI8RTorsB41knZLoStFpMK9OOi30GC7U72feAaq3C5TPkDo3o99mRPsjWgm X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ac2aa51-87e0-4f92-d8b2-08db4bac00d2 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 07:57:12.6007 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nKlAsURm+LbZWB35AOf+UJvY19oTdIj7E0sPnPDmIBr2v1OTdNMsmwg13YyizPzkxYJo78Fo/2fimEUnXrM4yw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR03MB7200 On Tue, May 02, 2023 at 04:40:17PM +0000, Ross Lagerwall wrote: > > From: Roger Pau Monne > > Sent: Tuesday, May 2, 2023 4:57 PM > > To: Ross Lagerwall > > Cc: xen-devel@lists.xenproject.org ; jgross@suse.com ; sstabellini@kernel.org ; oleksandr_tyshchenko@epam.com ; axboe@kernel.dk > > Subject: Re: [PATCH] xen/blkfront: Only check REQ_FUA for writes > >   > > On Wed, Apr 26, 2023 at 05:40:05PM +0100, Ross Lagerwall wrote: > > > The existing code silently converts read operations with the > > > REQ_FUA bit set into write-barrier operations. This results in data > > > loss as the backend scribbles zeroes over the data instead of returning > > > it. > > > > > > While the REQ_FUA bit doesn't make sense on a read operation, at least > > > one well-known out-of-tree kernel module does set it and since it > > > results in data loss, let's be safe here and only look at REQ_FUA for > > > writes. > > > > Do we know what's the intention of the out-of-tree kernel module with > > it's usage of FUA for reads? > > It was just a plain bug that has now been fixed: > > https://github.com/veeam/blksnap/commit/e3b3e7369642b59e01c647934789e5e20b380c62 > > I think this patch is still worthwile since reads becoming writes is > asking for data corruption. Right, can you add to the commit message that this was a bug in the driver? It wasn't clear to me whether that was the case or it was legit for FUA to be used with requests != write. > > > > Should this maybe be translated to a pair of flush cache and read > > requests? > > > > > Signed-off-by: Ross Lagerwall > > > --- > > >  drivers/block/xen-blkfront.c | 3 ++- > > >  1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c > > > index 23ed258b57f0..c1890c8a9f6e 100644 > > > --- a/drivers/block/xen-blkfront.c > > > +++ b/drivers/block/xen-blkfront.c > > > @@ -780,7 +780,8 @@ static int blkif_queue_rw_req(struct request *req, struct blkfront_ring_info *ri > > >                ring_req->u.rw.handle = info->handle; > > >                ring_req->operation = rq_data_dir(req) ? > > >                        BLKIF_OP_WRITE : BLKIF_OP_READ; > > > -             if (req_op(req) == REQ_OP_FLUSH || req->cmd_flags & REQ_FUA) { > > > +             if (req_op(req) == REQ_OP_FLUSH || > > > +                 (req_op(req) == REQ_OP_WRITE && (req->cmd_flags & REQ_FUA))) { > > > > Should we print some kind of warning maybe once that we have received > > a READ request with the FUA flag set, and the FUA flag will have no > > effect? > > > > I thought of adding something like this but I couldn't find any other > block layer code doing a similar check (also it seems more appropriate > in the core block layer). > > WARN_ONCE(req_op(req) != REQ_OP_WRITE && (req->cmd_flags & REQ_FUA)); > > I can add it if the maintainers want it. Hm, yes, it would be better placed in some generic blk code rather than (possibly) at every driver, otherwise people might complain that xen-blkfront trows warnings for requests other drivers handle fine. Would you be up for sending such a patch to generic blk layer? For the code here: Reviewed-by: Roger Pau Monné With the commit message slightly adjusted to make it clear read + fua was a bug in the module? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed May 03 07:59:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 07:59:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529001.822877 (Exim 4.92) (envelope-from ) id 1pu7Oq-0006oD-Ln; Wed, 03 May 2023 07:59:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529001.822877; Wed, 03 May 2023 07:59:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu7Oq-0006o6-Iz; Wed, 03 May 2023 07:59:44 +0000 Received: by outflank-mailman (input) for mailman id 529001; Wed, 03 May 2023 07:59:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu7Oo-0006o0-TJ for xen-devel@lists.xenproject.org; Wed, 03 May 2023 07:59:42 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0614.outbound.protection.outlook.com [2a01:111:f400:fe02::614]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 74e5dbbf-e988-11ed-8611-37d641c3527e; Wed, 03 May 2023 09:59:40 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DB9PR04MB9499.eurprd04.prod.outlook.com (2603:10a6:10:362::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.21; Wed, 3 May 2023 07:59:38 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 07:59:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 74e5dbbf-e988-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iBifMORxsMWiuSuej3g989o3uQq5ekhk2Dl3I/xiM5dG0UOk1BUw25p+/kJSuyGu+5t0yNlNONNFhGKUt7VPdWYFxhYnfp+w/n1sW0uwTTzZ6obBTK5KYgBzMLVdZUnOXEKjICXEr8VLZnTjbBq2cURz3sku6wouuLtr7gKkwJ1LsyzvhV33fgPU/Rosm/4At0MhIIpl8TSrZjLE+RpyQE3DkR7X3rO3VB94h/k84PqmyzXTgOc+temXuEAfnINF+ynwk0uFmEKw7u6SZ6Gd4ksGRbnJTZUYuXzRG3ntPrIy0o5SNA8H59hJTV/ExW/xTMDGbyxROMdKWZH5T3OgzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TnfPxbd9O5raFiv4FU6HklW0GmRoH0bxmZ8WkaI26WQ=; b=NSJn5XY9hPeXqzUMPLTlzkz/WjjqRUTcP+/ZBOzFu87gaRU7NR9fBARdZnxbR4CIQ6PWWov1rJOv+dI69J+epm3ILj85PhTT3LjL88Bc/WsGNS3QDUNUxSi1a0HAGvRZarOskBWNnYc4lE9OXP9Um3l2SLlFwc/Djvx8Yc9uajS9+hQVk5/Ptrk7XemJp9o+SytVTJiWbB4pPWaOgLWSVqLOI2KuuYTXFBQMS58O/LxkUvi6tGv+9Jf5XNTcmkCmv3oCutLrJc8IuyK2hpPdw+dN4sVWLF17/67XOrB9Hdqy/6ZSsYsmL7g7LncyT9lvDh3DOx8vovettHZzZPGBEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TnfPxbd9O5raFiv4FU6HklW0GmRoH0bxmZ8WkaI26WQ=; b=4n2rsWJ8VcynALeWFrSsldxOwOO3xu9YRCNkWDkJejZa28ALA25dce1p5X6guroQYn+kS64fPw81dT61Ep8Ory8h59pbuNfAZ3p1fMIgiwaduPWa1a4e2Yd/2GpRt/jxGMiWZ81OFeIC8QGX33rTm0XasmoVV4Lj21zKfKT+nm2WnlYQbU9Y6HY2/rZZ/16ngJBwWgzSJEkvZtWGtg3Jwg+PDqS4iXJaEWe/6x+cZ7ghzrv9q5gdqe9KXw6SrHOhkqKj0BZ2lwBgRB8nrVhS+cW6+HJARWFKXbCCK5zN/qiTa+zjKDyZ5xQTT0mvFevLFkaR8iFnf8p2QPEMZEg1pw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5ab506b4-1084-b9b5-6fb1-7d1961416dec@suse.com> Date: Wed, 3 May 2023 09:59:36 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [XEN][PATCH v6 15/19] xen/arm: Implement device tree node removal functionalities Content-Language: en-US To: Vikram Garhwal Cc: sstabellini@kernel.org, michal.orzel@amd.com, Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <20230502233650.20121-1-vikram.garhwal@amd.com> <20230502233650.20121-16-vikram.garhwal@amd.com> From: Jan Beulich In-Reply-To: <20230502233650.20121-16-vikram.garhwal@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0045.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::16) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|DB9PR04MB9499:EE_ X-MS-Office365-Filtering-Correlation-Id: d7254c95-99e7-4475-c1a0-08db4bac578d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Lsxd7DjnsESfd5XmFxw4kLvPKvrjn3YB5RPewRgqIhyoaCfir3fvyPie0AT2HKXMiF9e1221P4iNNtwLOqk5bUV1HyDoiWJkQZ+fT6magpYnviQ8VlJgu6locUVNebVCdQyViugQyitVOgd0Zcb+UtoPXmnl1O0VoWJKhLqrTgadVTIHK070D5M5zNCiueEM3uTa25VellDcP7D6P8XHvA2VGvN8THB4wV/oDHwYL88pNbfaxX4OLLWI0+zOW8sl/1lX+zBMJqpIVIYwTheyydzK0a1fiOWv8yjqDNJ4gTnEXx4k44eaG5EUw30IAq4QI3GpIhUXat/qQDM6QKw9Y/Ipigm0/FB20m2HYkEltUkrTJclvINyGhHuADd69klZLdosapTKaoDqEy+vdFppmuMaQpvqPY6uGg3ip6a0nh0SBWxQJ3NM4OQD8XMdpW9//jNcy66y3piNv3/1MYxjQCydq1s4R9dtVwTCm5Ti7rbkq1sYiXSfhEhDQmQ972/uqWbCZrYA+U1JJuS/LKEq0fQRl1rJlseio3qOskg1Fj0W6pIYycUNzILfI0AfWCOESRgkslaO0nRLeVoP8egcrCuI1eVFM1AME9kisZbVOgnHjGHAloKx+ak4HswEEpKEFf0V22IFJr0oYkzwljmByrKk9RuzNfI8+lMwCCKzJPA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(136003)(346002)(376002)(39860400002)(366004)(451199021)(54906003)(478600001)(31686004)(2616005)(53546011)(186003)(6506007)(6512007)(26005)(6486002)(41300700001)(6916009)(4326008)(66946007)(66556008)(66476007)(316002)(83380400001)(8676002)(5660300002)(7416002)(2906002)(38100700002)(8936002)(31696002)(36756003)(86362001)(403724002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2hDbHhDS1NCY0txVTcyT0RVSGhNQjB2ZG1wSERHOUJuMlp4R1NENmpKWll2?= =?utf-8?B?ZFBUb0pSMUljeTBFbk5mTVpYaGlITmlXNkpwM3p5SWE3M0pDR0tRTkt2ZmdI?= =?utf-8?B?L3JQRWlzakpWQTBRSzY5SHhtN1BPMzNQVlFKdDUvay9yRFdwWEUrSk1MYS9D?= =?utf-8?B?bXNXSjdYTHgwb1hMbzZST1BJd0NjdkZLcElDbW52SU94UmNFWmlXVU9BOWdU?= =?utf-8?B?LytnVmFFVUNWcTdjZUl3SmNzRmRqUytIdjlta0lIaUVZNTBhcEszRG5hU2di?= =?utf-8?B?YXlCNlVmS2N6QTd2WDFFcXBlV3IvTE5mc2tqMXo2UkpjS1d2VUhlMEtKeHVQ?= =?utf-8?B?RFU4VzNMN2xOU1hiaFBXMlZHYWU0WmhRdFFlM1hORnRGQW51aE9UUFNlejBK?= =?utf-8?B?Wi9zZytGUVhWcVZNc0t2Y3hRQTZvd1hZb2EvNlMrZGVFOHUzc3owekNvdDJx?= =?utf-8?B?dFYwOXZxcEJ4RzhObS9sU0NvSWVhcmJMTkF2WkF1R1h0ZS9SZHZ0TG1iK3hu?= =?utf-8?B?UE5nWmxpVGJyTFdGNXJveUU1UEQ2elhab3FsNCtEQ2JvUDUwOC9kYlNkM2Z2?= =?utf-8?B?bHdidzI1VzRobnB5RHU1VFJJNUtTSlBmWmhwN3JKVGsyVkJJN0hCY2dORkY3?= =?utf-8?B?OHQ1d3pPQ0JHUVFEVzB3TVhSQTBSN2hsMVhrczllMGdCMHFZRnR4U2pERThC?= =?utf-8?B?MFdIcWdLa3Y0WS9OeG5MOHBDMFNPQ3RxNTZMR0VvZE5IelRxVnZKcmdUK0NM?= =?utf-8?B?L2Jjc0l4Qkl5RjRYRjgvTGg0a2FIcXorS0pjcGpSL1F1WE9abU1JZmpTa1F4?= =?utf-8?B?bS9LSDZOUlZ2V3RJTTFiYTh3amdKdDdRMFR0SlN6N0VQQkU1ckllblhUdUUr?= =?utf-8?B?U1dVNXpIaEZlaTlOaUJKZ3dVU05UenZITGRPZ1E1WGJ6MkcwTWMyaitLNnZ4?= =?utf-8?B?YkZzVG5taVhvT3UzNXl3aVBocVpBbnhzNUZzRGZGSGRidzV2U052VStEVEEy?= =?utf-8?B?d0hUZ0NnMW9XYVNxdEJZSGpGWmxZZmgxTXlPTjJ4TlR3NkZrSE50cm5KeHJW?= =?utf-8?B?UkJkLzRCRTVSNDdqYjUyNjFrdGxyMUFRVjQwR0ZLTGhxb2JKR09MeUkrd1FI?= =?utf-8?B?dEhtVFpiWWx6KzBkK1kxeHlJck05TEZaKzBYL0RscHhKZlF2bEg5Y1ROTnp1?= =?utf-8?B?N3c3bUdYc2txUUI3NVpGS0RVN1hodkd4bWZiMTBWZVR6a2oyZmxmdkh3YlUv?= =?utf-8?B?ZE41cGFTd0wrNDF4a293WkdrMXZZS2xyTUU2U2h0U1o2aWt1alNMbFUvQmY1?= =?utf-8?B?cFdHVHhXMURiWTZ4L2RVTHB4VktPYjBibzFKWTQvVlQ2eGlTY2ozU0lmS2Vt?= =?utf-8?B?Z3I0ZURuMlU0ZWdWWGtGaWN4eXNCZVlqYUdPTE1peHBZeW42NzNjcmZOQVRR?= =?utf-8?B?aW85ZW0zVGp2c0dNOFZHVTgwRUlHZmJaUWpqdTUvSG56TGk2QXJtT256QjBN?= =?utf-8?B?SnJIYkkxMzU5RjM0V3VQdW1jcDJHYk5jYUd0NTVZTjEreFdFR3hJa2tLUllh?= =?utf-8?B?ZEVSdFdWS0RJUkRPbDBxeHRLMktFRWZOOFcybHYxU3VGc2FRdzFiOEg4b1VY?= =?utf-8?B?T0t0TGhWcmliTGQ2cFhOKzRkS0RCaWQ4NUxQeHp0emZyZTZPNWtsK1BZUGlU?= =?utf-8?B?V0ZyVmZQNzVlZGlOeW9vM3hQTXFaYlBvT1kzdTZ6MGlhSFhncWVxVTByQTE3?= =?utf-8?B?Mk5xZkttZ1JlRk1XOEJVMDhjT2ZycVBUc20rek9yanVhZEVNYkVKUlB4NVFn?= =?utf-8?B?cTM1QWhaaGErNndWMFJQVklCN09EYXUwbEhhSVlQRXFRR1JEazJCcVlEOVBG?= =?utf-8?B?QitzaS9HNGZGdldPcTM5eXYySXZRT0hmbVJNbTZMM3g3M2dTVWtVZU9rcFVl?= =?utf-8?B?S01ZcGtjaTF6QWxJSi9rSUdKbjY2a0U4VXJhZnUvdmZwamlpYjFxTGpmSk5N?= =?utf-8?B?UUU5d1kzM0I4dC9QM0RlSlNqcTZ6cFhaaStFNTgzVDZCS2FFSENNcVB3NnVr?= =?utf-8?B?ZFBvUzZ4eDVDQlJaNHBlVElONzRobjlBS1lCTEo4cHpoNWZDZXBCN0lmWmhn?= =?utf-8?Q?bbEs9uYi8QRZnoI8AeiZJ06JM?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d7254c95-99e7-4475-c1a0-08db4bac578d X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 07:59:37.9763 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0GcOjQjEbxTAT2sX4nzDbHLCuxWkGhNnlzpQgcTusG+SD276i3/h9Mk56VntdDZ1SWyTIKoFy4bEfoWazzfTJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9499 On 03.05.2023 01:36, Vikram Garhwal wrote: > --- a/xen/include/public/sysctl.h > +++ b/xen/include/public/sysctl.h > @@ -1057,6 +1057,24 @@ typedef struct xen_sysctl_cpu_policy xen_sysctl_cpu_policy_t; > DEFINE_XEN_GUEST_HANDLE(xen_sysctl_cpu_policy_t); > #endif > > +#if defined(__arm__) || defined (__aarch64__) > +/* > + * XEN_SYSCTL_dt_overlay > + * Performs addition/removal of device tree nodes under parent node using dtbo. > + * This does in three steps: > + * - Adds/Removes the nodes from dt_host. > + * - Adds/Removes IRQ permission for the nodes. > + * - Adds/Removes MMIO accesses. > + */ > +struct xen_sysctl_dt_overlay { > + XEN_GUEST_HANDLE_64(void) overlay_fdt; /* IN: overlay fdt. */ > + uint32_t overlay_fdt_size; /* IN: Overlay dtb size. */ > +#define XEN_SYSCTL_DT_OVERLAY_ADD 1 > +#define XEN_SYSCTL_DT_OVERLAY_REMOVE 2 > + uint8_t overlay_op; /* IN: Add or remove. */ > +}; I think you want to make padding explicit here and also check it to be zero when incoming. > --- /dev/null > +++ b/xen/include/xen/dt-overlay.h > @@ -0,0 +1,58 @@ > + /* SPDX-License-Identifier: GPL-2.0 */ > + /* > + * xen/dt-overlay.h > + * > + * Device tree overlay support in Xen. > + * > + * Copyright (C) 2023, Advanced Micro Devices, Inc. All Rights Reserved. > + * Written by Vikram Garhwal > + * > + */ > +#ifndef __XEN_DT_OVERLAY_H__ > +#define __XEN_DT_OVERLAY_H__ > + > +#include > +#include > +#include > +#include > + > +/* > + * overlay_node_track describes information about added nodes through dtbo. > + * @entry: List pointer. > + * @dt_host_new: Pointer to the updated dt_host_new unflattened 'updated fdt'. > + * @fdt: Stores the fdt. > + * @nodes_fullname: Stores the full name of nodes. > + * @nodes_irq: Stores the IRQ added from overlay dtb. > + * @node_num_irq: Stores num of IRQ for each node in overlay dtb. > + * @num_nodes: Stores total number of nodes in overlay dtb. > + */ > +struct overlay_track { > + struct list_head entry; > + struct dt_device_node *dt_host_new; > + void *fdt; > + void *overlay_fdt; > + unsigned long *nodes_address; > + unsigned int num_nodes; > +}; > + > +struct xen_sysctl_dt_overlay; > + > +#ifdef CONFIG_OVERLAY_DTB > +long dt_sysctl(struct xen_sysctl_dt_overlay *op); > +#else > +static inline long dt_sysctl(struct xen_sysctl_dt_overlay *op) > +{ > + return -ENOSYS; Pretty certainly -EOPNOTSUPP. Jan From xen-devel-bounces@lists.xenproject.org Wed May 03 08:01:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 08:01:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529008.822886 (Exim 4.92) (envelope-from ) id 1pu7QI-0000JU-Cl; Wed, 03 May 2023 08:01:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529008.822886; Wed, 03 May 2023 08:01:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu7QI-0000JN-9b; Wed, 03 May 2023 08:01:14 +0000 Received: by outflank-mailman (input) for mailman id 529008; Wed, 03 May 2023 08:01:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu7QG-0000JF-Mz for xen-devel@lists.xenproject.org; Wed, 03 May 2023 08:01:12 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a833ac18-e988-11ed-8611-37d641c3527e; Wed, 03 May 2023 10:01:07 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-178-h_zbahIaOUiVHVIBwANCXg-1; Wed, 03 May 2023 04:01:03 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F0BEB381D4CB; Wed, 3 May 2023 08:01:01 +0000 (UTC) Received: from redhat.com (dhcp-192-205.str.redhat.com [10.33.192.205]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4B0B4C15BAE; Wed, 3 May 2023 08:00:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a833ac18-e988-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683100866; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GJwJ5SBwqAyYWEb432D7rKlgjx5C7ieltMZT2oWDkb8=; b=L1hllRACNE1PYINwhLxv59l+/ORhUNJ4LCxae9wzc2L7L/npIWDWZKNWr/HGFDDsIAVCT2 bhgAx8rkejPr336TW+NK23jjBBmeojSmlph48QzmcsWMVKFgJ1wIEauqfqODKfU5bfM/cD n7yrvEV9O8fw5P96XKuWTndq7ZkQcTo= X-MC-Unique: h_zbahIaOUiVHVIBwANCXg-1 Date: Wed, 3 May 2023 10:00:57 +0200 From: Kevin Wolf To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Juan Quintela , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Richard Henderson , Fam Zheng , "Michael S. Tsirkin" , Coiby Xu , David Woodhouse , Marcel Apfelbaum , Peter Lieven , Paul Durrant , "Richard W.M. Jones" , qemu-block@nongnu.org, Stefano Garzarella , Anthony Perard , Stefan Weil , Xie Yongji , Paolo Bonzini , Aarushi Mehta , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Eduardo Habkost , Stefano Stabellini , Hanna Reitz , Ronnie Sahlberg , Daniil Tatianin Subject: Re: [PATCH v4 03/20] virtio-scsi: avoid race between unplug and transport event Message-ID: References: <20230425172716.1033562-1-stefanha@redhat.com> <20230425172716.1033562-4-stefanha@redhat.com> <20230502185624.GA535070@fedora> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="j7CkwuFkyJz+LKdb" Content-Disposition: inline In-Reply-To: <20230502185624.GA535070@fedora> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 --j7CkwuFkyJz+LKdb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 02.05.2023 um 20:56 hat Stefan Hajnoczi geschrieben: > On Tue, May 02, 2023 at 05:19:46PM +0200, Kevin Wolf wrote: > > Am 25.04.2023 um 19:26 hat Stefan Hajnoczi geschrieben: > > > Only report a transport reset event to the guest after the SCSIDevice > > > has been unrealized by qdev_simple_device_unplug_cb(). > > >=20 > > > qdev_simple_device_unplug_cb() sets the SCSIDevice's qdev.realized fi= eld > > > to false so that scsi_device_find/get() no longer see it. > > >=20 > > > scsi_target_emulate_report_luns() also needs to be updated to filter = out > > > SCSIDevices that are unrealized. > > >=20 > > > These changes ensure that the guest driver does not see the SCSIDevice > > > that's being unplugged if it responds very quickly to the transport > > > reset event. > > >=20 > > > Reviewed-by: Paolo Bonzini > > > Reviewed-by: Michael S. Tsirkin > > > Reviewed-by: Daniil Tatianin > > > Signed-off-by: Stefan Hajnoczi > >=20 > > > @@ -1082,6 +1073,15 @@ static void virtio_scsi_hotunplug(HotplugHandl= er *hotplug_dev, DeviceState *dev, > > > blk_set_aio_context(sd->conf.blk, qemu_get_aio_context(), NU= LL); > > > virtio_scsi_release(s); > > > } > > > + > > > + if (virtio_vdev_has_feature(vdev, VIRTIO_SCSI_F_HOTPLUG)) { > > > + virtio_scsi_acquire(s); > > > + virtio_scsi_push_event(s, sd, > > > + VIRTIO_SCSI_T_TRANSPORT_RESET, > > > + VIRTIO_SCSI_EVT_RESET_REMOVED); > > > + scsi_bus_set_ua(&s->bus, SENSE_CODE(REPORTED_LUNS_CHANGED)); > > > + virtio_scsi_release(s); > > > + } > > > } > >=20 > > s, sd and s->bus are all unrealized at this point, whereas before this > > patch they were still realized. I couldn't find any practical problem > > with it, but it made me nervous enough that I thought I should comment > > on it at least. > >=20 > > Should we maybe have documentation on these functions that says that > > they accept unrealized objects as their parameters? >=20 > s is the VirtIOSCSI controller, not the SCSIDevice that is being > unplugged. The VirtIOSCSI controller is still realized. >=20 > s->bus is the VirtIOSCSI controller's bus, it is still realized. You're right, I misread this part. > You are right that the SCSIDevice (sd) has been unrealized at this > point: > - sd->conf.blk is safe because qdev properties stay alive the > Object is deleted, but I'm not sure we should rely on that. This feels relatively safe (and it's preexisting anyway), reading a property doesn't do anything unpredictable and we know the pointer is still valid. > - virti_scsi_push_event(.., sd, ...) is questionable because the LUN > that's fetched from sd no longer belongs to the unplugged SCSIDevice. This call is what made me nervous. > How about I change the code to fetch sd->conf.blk and the LUN before > unplugging? You mean passing sd->id and sd->lun to virtio_scsi_push_event() instead of sd itself? That would certainly look cleaner and make sure that we don't later add code to it that does something with sd that would require it to be realized. Kevin --j7CkwuFkyJz+LKdb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE3D3rFZqa+V09dFb+fwmycsiPL9YFAmRSFLkACgkQfwmycsiP L9ai9hAAhKY0YAEhZNY7SY5b0lE/PTJpz63IpPn12rH1l8oQFgwUK5larJcxRmnG 2dC+TkTReWSEiF5cs3ubVy72RpQtzO6TcBLneAPFoxj5cSVZ9KQG2CWZhdC51snx +CIjJT5P818w0gd5YDlLPKvh9O+L9Uw6ljR3gJxPUuO13q3RwypT14PSCaeccr6k mTbLr4iBx+4tUJ7SR5fBA+vwaoIj1XbGBvx97AlyI2yQ2wSz0e70ZLXXArNorUil eyhXmh+aWYELab95fkGlqYWu1vz0YLhHCdsD5pSzQa8SSvlQ+WqMdt7mXm7zW2wp tpGcAV7Ew/HDfCTINHWqSAED+csbdqvSk4Ujh+RevUmgQPSAr/SiX6477WIIVec8 xxjWlwskBs1OjGhPUhVISdOqG/bad/oHR2RJeEam1FeStFppDSw0up5Z+FDRwZK0 M0sQog8eLqLvCkb7/pdH0w838xTDieVOCJ2aKIGcKvEkmSBALduzeuBdDMo/Vjz4 UM1oM3jw4oCQhL2GUaz23sDbMtkbTRK0/DgPB1qK7Qxa1qA+fI+CHBbYgyaYzPpi yIy2K+p2yGUuym35lFyOsfPjESFTOyaiKsrTG6cm/ZB3IymCGjfQ5R4UgObfeVkw +aS2yboG/lBZzkxo1Hc6vHcC8NHMztxT2zfjD9EfzLnyQzc9TYM= =hjg/ -----END PGP SIGNATURE----- --j7CkwuFkyJz+LKdb-- From xen-devel-bounces@lists.xenproject.org Wed May 03 08:02:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 08:02:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529013.822897 (Exim 4.92) (envelope-from ) id 1pu7RE-0000vY-RB; Wed, 03 May 2023 08:02:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529013.822897; Wed, 03 May 2023 08:02:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu7RE-0000vR-OF; Wed, 03 May 2023 08:02:12 +0000 Received: by outflank-mailman (input) for mailman id 529013; Wed, 03 May 2023 08:02:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu7RD-0000vH-Ft for xen-devel@lists.xenproject.org; Wed, 03 May 2023 08:02:11 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0622.outbound.protection.outlook.com [2a01:111:f400:fe1f::622]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cd75bf2c-e988-11ed-8611-37d641c3527e; Wed, 03 May 2023 10:02:09 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by VI1PR04MB9977.eurprd04.prod.outlook.com (2603:10a6:800:1d9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Wed, 3 May 2023 08:02:06 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 08:02:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd75bf2c-e988-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AmLCN5c06VUAzbyjhWOYR4eFmmS8TyCVRoJCKrCDV42a7R0YaJlMnC0hUwgfxIK3o1h6suRH1wP0dFup4lpIT+H+dbBDrWDc8JXI7D7hdxBKhuC4Xyng17i9Pd2vGi5aqKJNbNOP3X/Xd2LnxB+G5B6LUhw0VuElnW75pH0XJbJHGSjRRBj0bUy/WfRgw5qfwhaztVLli0fcT+LjjlrscwO/UMK6IfGodKnmxxMndk78c2p4B+lK9iDedYtPBlGYbK7tsWYNfzAWZpTY6rzHAj8Lq125ao3+UL+qPUJy+flyMDcnosTIbssTO6epSNmTUlpHbZCErNjsnIFL/ZZXBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8XxwCWxGBDJ9HjygqjC1krQMtwlO2IPEWApQaNDq2/k=; b=hw4Om+hBEv1rQlltg6NlspKK4fq9dQkYU/MoConA7RP4HX5YPMMq5b4L3eviyP+C5F6CsX78KeRtYRaCPek9eLEWn/KPIGw3L9b+heWuYJGOWsGuZRUz49/Uz2DpsaqHNJ3Jgzj52dmX8ixbzV+7rsfikFCXeZlAvEQc1MQMAWhodmTYr6TrXtVxeEMhlMA2E37cOSNX6iCNSOtFKYkIg0hjV0zp9U1PKluHPHyEVmfhrag0kgjEned7D75I1sDJO4GNnbbzWQCe3pha1cT0UT/xH++X2OMg781oAbJC3U1eU/UOUrHJoOHqZhdyzg7kmoU4cSP+NqiPTCe4LC1XRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8XxwCWxGBDJ9HjygqjC1krQMtwlO2IPEWApQaNDq2/k=; b=dwYShb5MRg7YFbxstPKVZQKCoPdfRZeLLX0vLtT0W5Om+U0M6gNcql7F67ZvIKoszpPGhHkbzBhOdZ0+KK9/Wo6FqSGn0+GPB1wDe5+2rtI6XTPmPHwwo1GNuV0AwCN7uKEITUGRLyhyiRbcfSth6cPma7JbmAwYkcwZ51fphal4QfLUdH0h6i8FzC/aJbjk75WoiByk7deZnHym/RnKt15xCXtuLPskVVd8JpYy+UMtnl8EPfCApgGphmBfLC9zWw2H1iYWwDF995FdGSLuq4QHHZTWhjs+p4eid1WknO1bmYUoNqaP8Q3pIY6C2Dl7o7aoVS1JGI+gZokvcTmOhw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <83a1b85b-ad6e-475f-41fb-9d3ff896d86c@suse.com> Date: Wed, 3 May 2023 10:02:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [XEN][PATCH v6 15/19] xen/arm: Implement device tree node removal functionalities Content-Language: en-US To: Vikram Garhwal Cc: sstabellini@kernel.org, michal.orzel@amd.com, Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <20230502233650.20121-1-vikram.garhwal@amd.com> <20230502233650.20121-16-vikram.garhwal@amd.com> From: Jan Beulich In-Reply-To: <20230502233650.20121-16-vikram.garhwal@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0072.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::11) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|VI1PR04MB9977:EE_ X-MS-Office365-Filtering-Correlation-Id: cf3b8679-072d-449c-682e-08db4bacafd6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HqqQ5e7WcyI5bytZHxYHbsChOpxEG3GapNkcR8M8yhIzPBgNa3rIuWeCGdQF6zDRywxVAACC50olUA9So7RKIj9DnWD3PqONqNDqsIxgVorSE+swWnPZzOmAFB03EPyLRRj41dZXW9sVd+E4TVBgp2vDOKaCh6mKrvKA4XVM51DI1nRJA6z9M+N/cgMv8G51Q6aSP1gUdwF4aOF0qmpYa06RUaMSkcLBUK4Z28cFun9ZpE41mdVCbD593er/ExJXbNJ9HDWajSf7OS3BwgSEnDplGJt0qsq4J21+hUWcETVG8cBjjpX2sti5il6m/NUjh+fO472JAafWD9ukKojmj1annvrUmLhiGGl4WfxBTLRuVuIyZMBp6bO/W0DF4v/xHYxdrBkOLCDVijruJLOW3TmiuEg5gt+zpEG+lgjrExarh7VdGbLkKJm0RZ3xSS01Xe08Ig6ah5aIMDVRzvKwQN0tVz2kw8E+pXMzteZAAxyW2kaTX5F8TROZrsQ6tkv1zn0hSkJkqOsK0k1YWasSJBm01395SYx4qaTsHRVQHwx6QxuShy8M9lwQ9IiwSbja4dnVmlFmyXOKSBIUd1PrN2opUEERsOuyPfRh8xvb0s1K/NHf0wbIpgSr8xYp/5gGeEhJ8tcTj3fAAxVuHQjyyQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(346002)(39860400002)(366004)(136003)(396003)(451199021)(86362001)(31696002)(2616005)(83380400001)(5660300002)(478600001)(41300700001)(8936002)(8676002)(4326008)(38100700002)(66476007)(66556008)(6916009)(6486002)(54906003)(66946007)(7416002)(31686004)(36756003)(316002)(26005)(6506007)(53546011)(186003)(2906002)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmhQTVFKOHBqd0s3RDgxcXZqeG5jbFNzRTRMY0M3bUpmcW9Dc1QzNnkrczZ3?= =?utf-8?B?b2JycW9Jc205SjM4TWlpYW1JRFBHc2NDOUE0cHlJZEdVb0RPWUVqSWt6eUR2?= =?utf-8?B?azJIaHdjVkdaT3ZxcmFpNUxkWm1OL3c3U3FwamFkenRVMWFkbEFjQWhoWlB4?= =?utf-8?B?NXZEV01EKzJkTEsxNjhEL1lhVXlUa2JHWXFNT3hFaDlJRzhBdURhdmxQSnlu?= =?utf-8?B?c0tmSFExQ2JVQnRiYU1aTyszQXprVExnSERVQWlqRW1QaVY1bkVMMUJZK0FG?= =?utf-8?B?enFoRVJld2JQSWdHM0RRVHA4cjd0TFBkaDNKL2JLeURXaUpjUjNCdnlwRmVQ?= =?utf-8?B?V0FWQmRCWWxxU3RleGZ2b3pRVEkyMmZOMFg0d3FadkxFSktJTjJQTzRrb053?= =?utf-8?B?cE94OVRScllrOWVpSEVxMUdyTDhLSmgxb1FveHE0aFA3RWIvS2dGelVkY3FN?= =?utf-8?B?V0lzcTNsS0lTVjRadjIyS3B3Q01zN0NkOUUvN1grNDNLVEk2NjhnQnRUTUFG?= =?utf-8?B?Q2FKdkJ2Ris2NEsvTzZMNE82UTlHQ0dVM2xJTUNDSjRpUmc1UCt4NHZVSnEz?= =?utf-8?B?ZWJub0JqZEVzZG5RTlRoTEZiY1BYYVBaWW8rTzZqQTJyUXdMejd6anVFenVS?= =?utf-8?B?RTIyZVNKN2hnRDBkdm9NTHAvalNBY01Vbjk0WUVqenRSUjBZT2o3ZUQ4L3dk?= =?utf-8?B?eUJKdW15TS92YTYxQVZNZjJIZ0xVL1llM3ZrbnhnSGVwVEVXQURVT2ZHalVG?= =?utf-8?B?VUFRamJFSzNMS0p4Q0gvNklQRXZwclJSdFo3ckVJeHFjeEJGQ3J6L2d5L3gz?= =?utf-8?B?all2RWNTWDFiWGxDem9GN0p5QS9hbUwzd2pQZnd3STl3NlgvUWhMWUZaRk1J?= =?utf-8?B?TlczNk9uUDVCNEE1Ym5NYlIybFlaQXBkUEp0R2l1S3VIMEZHbGw3dDBGZWdx?= =?utf-8?B?dFJNRjk1VytrUWMvZEpCYitLK0RsZ2NUMmdNT1JmeGV2U1hSY0s2VzIxdlR1?= =?utf-8?B?T0NXOHQ1eFNYNmlJS2ZwTlJUczBMcG8rZXBtMUx0N1BuY0o1T3Y3ell2Sndx?= =?utf-8?B?akpQVmtHS1hFeUJ1WTV4NU9aM21xOUdFYzdiaXg5Vy9GOHlaMmpqU2dJZDFl?= =?utf-8?B?M093V0pjd0w0ZEFZK1M5TmxYaFVXZ2xPS1dVNXU0b0l6cS80cmpJWXE2RlpW?= =?utf-8?B?RTYzNERmT1ZrOUdZL0hBcWtvMGlMRkd6bEQ2cUw2a3hML3krL2V6aEJxSlJ5?= =?utf-8?B?My9kN1BUNkg4ODBKT21xTEtBVENzSDV2TkhOMTBkUUZZVy9ucG1GWVJXa0dl?= =?utf-8?B?SERNbTdySTV3RnNYZXRrWWsrVmFMTVZFZFJVZ3FUTnp6MCs4VHlpdXowMURz?= =?utf-8?B?eDJzRWRVdUV2cHZTbVZDYXFDQUxLUzcvWXhHNGs0d05qaGY3MVZtSFpuVURR?= =?utf-8?B?YmIxWDc3OGRZQ1NqYXFaaGxBVmt0dmszQTE4MFlXUmUzcXphbXNwSmdOSHhH?= =?utf-8?B?T0tETXJRa0R4TUtNQlU2MFFIekU1N0VrSldSbUdrVUZpaWNqdUtCSlBkbW94?= =?utf-8?B?bUVRWm1oMkRCVXFKYzJLTndtaTdJQUszMWhqclk0bGtoaVJ1RU94TXR4cUZI?= =?utf-8?B?amJNaW50WVJkWmdJeFpDalQ4THNQcGZQMkpzdUJkZDF0UzA2Tk9UbXFMSVZS?= =?utf-8?B?bWx5WGQ0a0pyTHJUWXdsV2tIQWRNY1p1Y3JUMzV5UEp2TkNOdXRKbTZMcG5T?= =?utf-8?B?UkFoNVl6TUQwenZacjlJc2IvQmpvbmxRUWhTb3lmYVlPUk9mbmdTZ2FIeE4w?= =?utf-8?B?M2lKSFZGemdOU3VMeVlCamdkU25zQXA0K3BHamFQMmJMaC82TDd1Z1hNSXVw?= =?utf-8?B?YnhaU0ZUOTJIaytUb0VySU1XUk5wNFVmNmFjMHRiS0psN3hDcUM2Y0tUWDVF?= =?utf-8?B?R3dwRWNnOWJ4ZjFyc1Rpb3hUeU1XbXNJV2l4clB3Wi9EMUJkd08zRmVNeGJ1?= =?utf-8?B?QTI2VWFIRXFMWHhoV2xxeHNzV3oxS2NlZ2NFdjMzTnlQdjZ0ZEJMczZPaWdz?= =?utf-8?B?VS93RGZnZldxWUkyQ3N4STNyTTJUbmszeGdVeE94VmtWWTNCR1dmZjE1Rlhs?= =?utf-8?Q?fD+RiU8S4LrTeTM/+nWbLArEa?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf3b8679-072d-449c-682e-08db4bacafd6 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 08:02:06.0699 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ux4OGw/yrdQcyIn7hFS+ExpqCcdcN/aYPM4uSN0NMja2/0McON/Yo+IjXfj7P99IYBrIybPNJkO6PR+l66BaoQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB9977 On 03.05.2023 01:36, Vikram Garhwal wrote: > Introduce sysctl XEN_SYSCTL_dt_overlay to remove device-tree nodes added using > device tree overlay. > > xl dt-overlay remove file.dtbo: > Removes all the nodes in a given dtbo. > First, removes IRQ permissions and MMIO accesses. Next, it finds the nodes > in dt_host and delete the device node entries from dt_host. > > The nodes get removed only if it is not used by any of dom0 or domio. > > Also, added overlay_track struct to keep the track of added node through device > tree overlay. overlay_track has dt_host_new which is unflattened form of updated > fdt and name of overlay nodes. When a node is removed, we also free the memory > used by overlay_track for the particular overlay node. > > Nested overlay removal is supported in sequential manner only i.e. if > overlay_child nests under overlay_parent, it is assumed that user first removes > overlay_child and then removes overlay_parent. > > Signed-off-by: Vikram Garhwal > --- > xen/arch/arm/sysctl.c | 16 +- > xen/common/Makefile | 1 + > xen/common/dt-overlay.c | 419 +++++++++++++++++++++++++++++++++++ > xen/include/public/sysctl.h | 23 ++ > xen/include/xen/dt-overlay.h | 58 +++++ > 5 files changed, 516 insertions(+), 1 deletion(-) > create mode 100644 xen/common/dt-overlay.c > create mode 100644 xen/include/xen/dt-overlay.h Is it possible that on the next patch I and other REST maintainers are Cc-ed merely because at this point of introducing the two new files they're not added to (perhaps) the DEVICE TREE section of ./MAINTAINERS right away? Jan From xen-devel-bounces@lists.xenproject.org Wed May 03 08:02:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 08:02:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529015.822907 (Exim 4.92) (envelope-from ) id 1pu7Ra-0001PV-2e; Wed, 03 May 2023 08:02:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529015.822907; Wed, 03 May 2023 08:02:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu7RZ-0001Ov-Vu; Wed, 03 May 2023 08:02:33 +0000 Received: by outflank-mailman (input) for mailman id 529015; Wed, 03 May 2023 08:02:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu7RY-0001Nb-4t for xen-devel@lists.xenproject.org; Wed, 03 May 2023 08:02:32 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu7RX-000419-8m; Wed, 03 May 2023 08:02:31 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.7.72]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pu7RX-00072m-2y; Wed, 03 May 2023 08:02:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=agd0YHdB4COnxADCJ9g9QhBh4bEoptan8icrJwMebws=; b=XKvf32gvDUY6nW4SOcu5kWxp0H yls5SMFIcQAMLcD519IWP0ST8P7GRos7UELyD2wg/lrSMefPL9aq+ZbRSP4xjFPQ5W9g6yC1pVL5M LDcsZgX/PHI6LGP0b4F6UJN1/onxIG7JuXtErqnctwvKRC0Vi4/BOHgF1J8YYmPSIRrc=; Message-ID: Date: Wed, 3 May 2023 09:02:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 05/13] tools/xenstore: use accounting buffering for node accounting Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230405070349.25293-1-jgross@suse.com> <20230405070349.25293-6-jgross@suse.com> <887675ad-ef06-cf8c-8a32-5b3f726e2198@suse.com> From: Julien Grall In-Reply-To: <887675ad-ef06-cf8c-8a32-5b3f726e2198@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Juergen, On 03/05/2023 06:13, Juergen Gross wrote: > On 02.05.23 20:55, Julien Grall wrote: >> Hi Juergen, >> >> On 05/04/2023 08:03, Juergen Gross wrote: >>> Add the node accounting to the accounting information buffering in >>> order to avoid having to undo it in case of failure. >>> >>> Signed-off-by: Juergen Gross >>> --- >>>   tools/xenstore/xenstored_core.c   | 21 ++------------------- >>>   tools/xenstore/xenstored_domain.h |  4 ++-- >>>   2 files changed, 4 insertions(+), 21 deletions(-) >>> >>> diff --git a/tools/xenstore/xenstored_core.c >>> b/tools/xenstore/xenstored_core.c >>> index 84335f5f3d..92a40ccf3f 100644 >>> --- a/tools/xenstore/xenstored_core.c >>> +++ b/tools/xenstore/xenstored_core.c >>> @@ -1452,7 +1452,6 @@ static void destroy_node_rm(struct connection >>> *conn, struct node *node) >>>   static int destroy_node(struct connection *conn, struct node *node) >>>   { >>>       destroy_node_rm(conn, node); >>> -    domain_nbentry_dec(conn, get_node_owner(node)); >>>       /* >>>        * It is not possible to easily revert the changes in a >>> transaction. >>> @@ -1797,27 +1796,11 @@ static int do_set_perms(const void *ctx, >>> struct connection *conn, >>>       old_perms = node->perms; >>>       domain_nbentry_dec(conn, get_node_owner(node)); >> >> IIRC, we originally said that domain_nbentry_dec() could never fail in >> a non-transaction case. But with your current rework, the function can >> now fail because of an allocation failure. > > How would that be possible to happen? > > domain_nbentry_dec() can only be called if a node is being owned by an > already > known domain. So allocation is impossible to happen, as this would be a > major > error in xenstored. From my understanding, the nodes accounting will be temporary and then committed at the end of the request. So we would call acc_add_changed_dom() which may require allocation to hold the temporary accounting. > >> Therefore, shouldn't we now check the error? (Possibly in a patch >> beforehand). > > I don't think so. I can add a comment if you want. See above. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 03 08:08:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 08:08:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529019.822917 (Exim 4.92) (envelope-from ) id 1pu7XJ-0002Ak-Mx; Wed, 03 May 2023 08:08:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529019.822917; Wed, 03 May 2023 08:08:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu7XJ-0002Ad-Jr; Wed, 03 May 2023 08:08:29 +0000 Received: by outflank-mailman (input) for mailman id 529019; Wed, 03 May 2023 08:08:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu7XI-0002AX-BO for xen-devel@lists.xenproject.org; Wed, 03 May 2023 08:08:28 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20621.outbound.protection.outlook.com [2a01:111:f400:7e1b::621]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ae2e2a2e-e989-11ed-b225-6b7b168915f2; Wed, 03 May 2023 10:08:26 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DU2PR04MB8758.eurprd04.prod.outlook.com (2603:10a6:10:2e1::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Wed, 3 May 2023 08:08:23 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 08:08:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae2e2a2e-e989-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ifkwBpCendxZkEV9W6kA0Vw6qpd2Qm5WNJsTHbZW1oHTD0uBt23rug0QR8Ge/SL/KoJxK0svfoTZOID+gSXKpCQ6H27Z/HDfysoT0Hl9cg8bsPYBw1W5jFD4OD+eaSPWXvWMotDG0cKdb4LxLg7u40dU2af1stzUOyFjEQPC7Uf3Uy16rLcm61JG3A/FrhlLFaztTEbZWyaR3IptzD/FsS9k2rXo+miLS9vrQVkMLTDPxXEidoeh6YRUx/O7R6vhHhVqk4V5cOX6857X4nfr2t2fH1r1KRBylSEyS2KsNLx+pTCJYdmPKEKI6GwIDiIMrNKGynSl8M+Pnapia0nT9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DaxVrrA90NzQvNu/mjQcPr0kvA7Gj9knhoypR4X+QXI=; b=iV8/Xlb4DUaL29JayndH83Kz4ubk71ihxSlEJJW04n9e39Ovx2huPR1Zgs1hysbHy7+Ck+70jnBO+63OfFbrdHoJ3FM5V+msospBfGiHOuxk/siEdJi9vUZc5oOjlhpb3nmMSDzlrLiUlWEjNZSiPNCKJLs1yMMDTS9eyFh4QV/uCCZgYpQBOsAKX7OjkM/n1A0stUXZx9vkKrwWHPxuXTHnQ0OJFcmIdP2vI8W1Xe6VpB8YIqzfjdiGmkzTjtdoLWZy4HBVCvt7+aeRnuL1qP4KB+30OK9ZmxovvUNwQSfQ/vjERddH4aX5CbhDrhmp7QUVMZKc30CaEN4c771NMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DaxVrrA90NzQvNu/mjQcPr0kvA7Gj9knhoypR4X+QXI=; b=FbK+HGKm+aDVs5vyQPMQ562L6OK3Ur/Ai+cSV7777mJsbgmPNMgxwgezaXvf1rOhHDEnCH/JGSoXsT255H6TXeYNUQW2hsSJ0m8ESVUTBD7PI0wOfsZQymW+Ry6I15fH6r9ffIh6iNhjLK9z9uTPSG/XsLDk4cMkSPhfX0XlnBhgVU/IZ70uqjCrOIR2b97JVLbHM8J1C0LNgpKgKpMjoSN9pL5Zaak0sXDKCRC6apy+UYd83moZKTQ/TeOuS066oxdWDT/4RC1emjDHNHeyVv1ALyJnlBX/Ghenh8d9x+hhkKPcD1FjcyA4CqxZgJsqJgt4Nsrmfj0QeTOKqFAM5w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5045583e-8776-0834-ca93-44f85888d877@suse.com> Date: Wed, 3 May 2023 10:08:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v2 1/2] x86/head: check base address alignment Content-Language: en-US To: Roger Pau Monne Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20230502145920.56588-1-roger.pau@citrix.com> <20230502145920.56588-2-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20230502145920.56588-2-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0107.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::20) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|DU2PR04MB8758:EE_ X-MS-Office365-Filtering-Correlation-Id: 0500c80f-b3aa-4a50-55db-08db4bad9075 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ol80LB5lkYT8LRDvFeP04SVCgDs9LApsj3X6B5zvvqc7HCx7uJHB/QgffOis5b6ybaLDrU8BXXvWcJCGwCVLN25NgRmjZPf0zEvpPO4avuFz/v+56F2ZIky6bJw3mISwJyGii0YBPwUnHS5QUsVR2sX+Xy3hgBgHn1OboTsJ4n3SajxsdjxOEKeS/Xbki9bgMmdjuS50jGMU9wOlA46cA7RqPSHp5sDUiS/oPaVjWTWfvQHzfRKDqh5Qf7x5LLtNknb7FORIxY8qfhy0N5V4OgQxjr6nRQ5qUdelYEWn/OpnxeCee6e81LkZ6jYvtqmPahDwgN0QAOm/aBExXwtxHgaF3oP1DmSxLfqujklIup2unq4ITfFMw4spiilawDowR//BBlNuE3ltX9AE7YkFTAw1rrgnKGS+60EBV9TiB40/1EzJP8oZh6P2cvUBXlGiYWpRxgz90UPAWzpgnZXpImUq8Fdyr7Kd6zZIhqMP1zFtpyU8eurz9o4KVyImb5pJt/CrYk4fTVIna3TZxwU0AG8H7Bv/V3y4Ed19keawu536NIo6quZ4Z/93cNf495zonSlKcBMfW3zan+E1YX6KYqTR3qf6CCqkFu8KYv7yjEoHO/tdOU3hH7RVkqCR4PMLymhQcZMdW8qrNWrc50CVxA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(346002)(376002)(396003)(136003)(366004)(451199021)(478600001)(26005)(53546011)(6506007)(6512007)(6486002)(83380400001)(54906003)(186003)(31686004)(2616005)(4326008)(38100700002)(6916009)(66556008)(66476007)(66946007)(8676002)(41300700001)(8936002)(316002)(86362001)(31696002)(2906002)(5660300002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dC9Dam1RM0JNaktwKzRhOVBLcFN2YnpKK2pzemRBZVFMUEIyUzdkN2MxVXJs?= =?utf-8?B?Um9VaVFwNnVNNWVaZmNUaVRyZ1doNHgraHdRdWN3SnBUcHprZUg3cGNQSWNl?= =?utf-8?B?cFp2QVRMWi9OVVRxdm1mZWlXMk1JNC9COFBWUkpwTTJEYUNGZlNub2dwb2dP?= =?utf-8?B?YkNEa0VHMGlvWlJlUU9xRnVtU2tSUVFtZzQxOU9QMDN6d2FWaGY1UjBFTS9l?= =?utf-8?B?T0dWaW9nLzFTZ0NtSG1reVk4ODNKRy9pR1l6a1I1UzNocDlsd3BVVmVzTWd0?= =?utf-8?B?NmlxdlNtT2JqK2xqOFFRWFJaajVJa2Q1WW9mYmZlWWdWUStqQ2RqWko5dk4w?= =?utf-8?B?amtkdXVhMEZ6bWVzZXo2SEtaT0hDZ1BtWUZMZk5ndTVGbWE4UUMvYUl1UnIw?= =?utf-8?B?RlFVb2NZdWVvT0V2cUZNS3Z0YklPS05ZRDY5bW9IK3dJNjRralBrUnE4KzEx?= =?utf-8?B?WWVwb3MwM1VDLytKL1h1RFU2Q2FWeXM2SXZhVklwWjVEQXpYTTdXRG9YRTBF?= =?utf-8?B?bDJoemN4enU0Zk5VNnd4alpMak42L01BMmtJYVUrQ01HOWVrNkJtaTZQdVlX?= =?utf-8?B?Qm1FdExISUx4UGRsRGFGZ0tLN1hIOWw2Sy8vN0syR3dhK0IxdXFScmNyNENs?= =?utf-8?B?ZUJvZzRVQlRXZnRTa3FicDBXZkZZWlBpa2d4aXBwRHk2RUNDTkRvSXpnSTJa?= =?utf-8?B?Qk9ReG1Wam90UVZMTndzZEpKMTU1VjhhcjZPenRQR0VxYXRQVlpoV0FoOG9i?= =?utf-8?B?TGdVNTh2eC9rTmFVbXNNdGJ4RUI1S1k0Ky8xWjNLYXZzQ1FrcHQ3OFdpR1Z4?= =?utf-8?B?NEQ0d2lVZVFvUnBmbVA4WFgrbURzMTVEdytMc2d4N1h4dTExZDU0MG1YVDB1?= =?utf-8?B?dFE4R2NXMEJTT2JDNllvYk1EQytObjVvS0pCM21XZnBZSXh6ZDVoWFprYTNK?= =?utf-8?B?aG9xZHBxOEw2K3JWekdBUkZPeWxVcW5MYUU2b0RaMnJkWXdsWnAxUzgxaENE?= =?utf-8?B?alZDQTY0d2ZLcldNRHlHSDAreTR4aTR3T1MvdGR5OW5xb2pqQ01SRnhMMzBs?= =?utf-8?B?eUJ6M2hBV09Ia255Q2JHaVRDSFRCQjlsWWxHdXlOMXoyMEk3TFRpNU9ISkxx?= =?utf-8?B?NGRpblhmcVRDNkxXNFFWUXA1Tkl1QWU4ZmU3eWE3aDRzMVpWUm9DVnBKSFNh?= =?utf-8?B?TVJZZFgrY3M2bUVycUcyeW4xbUZMUE5qQW1BdzUxcDcvVEVNZWxRWWJWbEdS?= =?utf-8?B?L0lnOXpxV2Z4Zlk4eitDa2RzZGJ5cnp5all3RWNNb21ad2dCM3pjdUxCWHR3?= =?utf-8?B?OVMzK203emUzaGpxQ25wS2lUalZHcm9TQmh5T0owVCtOaWc4QWFYaUowRkFh?= =?utf-8?B?MUY4S2NpYUtaUXpnclYzcVNkbDlxQTdaVk9OS0tjZ3FnU0pKWTVwSVNubkFG?= =?utf-8?B?TWJEK2wxZzZmcE1kbHRaNXNtSEE4bmo5S0FSQTBMaDJMcXJpMy9vN0QwaUhl?= =?utf-8?B?OXUveWRqZ1ZMMmM1dC9Xc0h4YlZBeDhjMFpwdTRCYThrcWN5QjNlS08wZ0wy?= =?utf-8?B?Yk9qOXZSN0U2Zjc3U2pUb0ErK2ZDNUJGZkxSZ1Z1VU9ORmNMMG81bWMxakl5?= =?utf-8?B?dC95alFIM2sxdWsvUjltZ2RMdHExV0dKZG1odmtPT3hEaDdZS1h2RU40bEJJ?= =?utf-8?B?M2M3QUdQVE12ejNuby9zam1EUDg1U2JPZ1BBbm9ON2w0cXdoRytVQnFORFdK?= =?utf-8?B?alJLSjVCUjEwUjBIYmRPVllVZWZ2UitQNlEvWXBERzh0WlIwMW9TVzlKUEpy?= =?utf-8?B?Y1RHK2ZFZVB6OG9BYjZ4WkJOeDdMeC90MEFiUVJJZjZZNzQ4ZjRGdWNFOW5B?= =?utf-8?B?QStEMFF1QnBVVGlYOGg1NldMNTFpaXlUSy9OeUdsOXdHejZCbkVxQXhoZHZX?= =?utf-8?B?TmlxOHpBQVF1M2ZNcFk0UUNoTGJwNFkvV3BjRzQ2cGEyQWY1dklLRkQ0SFNi?= =?utf-8?B?VFVQbWxlSzJ2YnMvZTlhWW13RkxhckNWbDhiSHE4dUFzUVNselVTY0NJY3hz?= =?utf-8?B?dUxuY3Z3VU5jblFCTVUySmRLVjBmRXQ2bjcrNnI1NnZTRFNUZzdKTmplU3Vh?= =?utf-8?Q?Q83Jw0nWhx6iIdvX6KJyyKoXr?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0500c80f-b3aa-4a50-55db-08db4bad9075 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 08:08:22.9215 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YAJZAMBudSRTZrzLpMQ1kN7y3PD3XhoU3D0+0Jt6/Pmj0oG5MJeDIG3w7Up1p94Uu27ymrtA6/Vjc6wLnLPigg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8758 On 02.05.2023 16:59, Roger Pau Monne wrote: > Ensure that the base address is 2M aligned, or else the page table > entries created would be corrupt as reserved bits on the PDE end up > set. > > We have encountered a broken firmware where grub2 would end up loading > Xen at a non 2M aligned region when using the multiboot2 protocol, and > that caused a very difficult to debug triple fault. > > If the alignment is not as required by the page tables print an error > message and stop the boot. Also add a build time check that the > calculation of symbol offsets don't break alignment of passed > addresses. > > The check could be performed earlier, but so far the alignment is > required by the page tables, and hence feels more natural that the > check lives near to the piece of code that requires it. > > Note that when booted as an EFI application from the PE entry point > the alignment check is already performed by > efi_arch_load_addr_check(), and hence there's no need to add another > check at the point where page tables get built in > efi_arch_memory_setup(). > > Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich Would you mind if, while committing, ... > @@ -146,6 +148,9 @@ bad_cpu: > not_multiboot: > add $sym_offs(.Lbad_ldr_msg),%esi # Error message > jmp .Lget_vtb > +not_aligned: ... a .L prefix was added to this label, bringing it out of sync with the earlier one, but in line with e.g. ... > + add $sym_offs(.Lbag_alg_msg),%esi # Error message > + jmp .Lget_vtb > .Lmb2_no_st: ... this one? I don't think the label is particularly useful to have in the symbol table (nor are not_multiboot and likely a few others). Jan From xen-devel-bounces@lists.xenproject.org Wed May 03 08:09:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 08:09:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529021.822927 (Exim 4.92) (envelope-from ) id 1pu7Xn-0002bv-V9; Wed, 03 May 2023 08:08:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529021.822927; Wed, 03 May 2023 08:08:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu7Xn-0002bm-Rf; Wed, 03 May 2023 08:08:59 +0000 Received: by outflank-mailman (input) for mailman id 529021; Wed, 03 May 2023 08:08:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu7Xn-0002AX-5e for xen-devel@lists.xenproject.org; Wed, 03 May 2023 08:08:59 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c0e62e46-e989-11ed-b225-6b7b168915f2; Wed, 03 May 2023 10:08:58 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-36-vLcfhCiUOwuGWkdaAmksmg-1; Wed, 03 May 2023 04:08:51 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C56C810504AC; Wed, 3 May 2023 08:08:50 +0000 (UTC) Received: from redhat.com (dhcp-192-205.str.redhat.com [10.33.192.205]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4DD9F492B00; Wed, 3 May 2023 08:08:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c0e62e46-e989-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683101337; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GdsrTvtpKiwphnVpAamWYth1JM74zuqKQh3Am2keHQg=; b=DrcBo0DMnCv/KYxjqbWPFEyuBQ5x0xjmLkCGM4iu9AWTD7bMDcq3Wb9YyNkcujEtAfsvw/ j+MCnqqGLEWWFB1X3FiTInfVcS+E9cAVWuKkQJdECig6CHgi8sOGjV7gIO0ZE6SJgaxxPl EOqzB54vB61LF8uKV5o2rajrMYOoT1w= X-MC-Unique: vLcfhCiUOwuGWkdaAmksmg-1 Date: Wed, 3 May 2023 10:08:46 +0200 From: Kevin Wolf To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Juan Quintela , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Richard Henderson , Fam Zheng , "Michael S. Tsirkin" , Coiby Xu , David Woodhouse , Marcel Apfelbaum , Peter Lieven , Paul Durrant , "Richard W.M. Jones" , qemu-block@nongnu.org, Stefano Garzarella , Anthony Perard , Stefan Weil , Xie Yongji , Paolo Bonzini , Aarushi Mehta , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Eduardo Habkost , Stefano Stabellini , Hanna Reitz , Ronnie Sahlberg Subject: Re: [PATCH v4 07/20] block/export: stop using is_external in vhost-user-blk server Message-ID: References: <20230425172716.1033562-1-stefanha@redhat.com> <20230425172716.1033562-8-stefanha@redhat.com> <20230502200645.GE535070@fedora> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8uIPJqxz2LaoW5Jz" Content-Disposition: inline In-Reply-To: <20230502200645.GE535070@fedora> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 --8uIPJqxz2LaoW5Jz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 02.05.2023 um 22:06 hat Stefan Hajnoczi geschrieben: > On Tue, May 02, 2023 at 06:04:24PM +0200, Kevin Wolf wrote: > > Am 25.04.2023 um 19:27 hat Stefan Hajnoczi geschrieben: > > > vhost-user activity must be suspended during bdrv_drained_begin/end(). > > > This prevents new requests from interfering with whatever is happening > > > in the drained section. > > >=20 > > > Previously this was done using aio_set_fd_handler()'s is_external > > > argument. In a multi-queue block layer world the aio_disable_external= () > > > API cannot be used since multiple AioContext may be processing I/O, n= ot > > > just one. > > >=20 > > > Switch to BlockDevOps->drained_begin/end() callbacks. > > >=20 > > > Signed-off-by: Stefan Hajnoczi > > > --- > > > block/export/vhost-user-blk-server.c | 43 ++++++++++++++------------= -- > > > util/vhost-user-server.c | 10 +++---- > > > 2 files changed, 26 insertions(+), 27 deletions(-) > > >=20 > > > diff --git a/block/export/vhost-user-blk-server.c b/block/export/vhos= t-user-blk-server.c > > > index 092b86aae4..d20f69cd74 100644 > > > --- a/block/export/vhost-user-blk-server.c > > > +++ b/block/export/vhost-user-blk-server.c > > > @@ -208,22 +208,6 @@ static const VuDevIface vu_blk_iface =3D { > > > .process_msg =3D vu_blk_process_msg, > > > }; > > > =20 > > > -static void blk_aio_attached(AioContext *ctx, void *opaque) > > > -{ > > > - VuBlkExport *vexp =3D opaque; > > > - > > > - vexp->export.ctx =3D ctx; > > > - vhost_user_server_attach_aio_context(&vexp->vu_server, ctx); > > > -} > > > - > > > -static void blk_aio_detach(void *opaque) > > > -{ > > > - VuBlkExport *vexp =3D opaque; > > > - > > > - vhost_user_server_detach_aio_context(&vexp->vu_server); > > > - vexp->export.ctx =3D NULL; > > > -} > >=20 > > So for changing the AioContext, we now rely on the fact that the node to > > be changed is always drained, so the drain callbacks implicitly cover > > this case, too? >=20 > Yes. Ok. This surprised me a bit at first, but I think it's fine. We just need to remember it if we ever decide that once we have multiqueue, we can actually change the default AioContext without draining the node. But maybe at that point, we have to do more fundamental changes anyway. > > > static void > > > vu_blk_initialize_config(BlockDriverState *bs, > > > struct virtio_blk_config *config, > > > @@ -272,6 +256,25 @@ static void vu_blk_exp_resize(void *opaque) > > > vu_config_change_msg(&vexp->vu_server.vu_dev); > > > } > > > =20 > > > +/* Called with vexp->export.ctx acquired */ > > > +static void vu_blk_drained_begin(void *opaque) > > > +{ > > > + VuBlkExport *vexp =3D opaque; > > > + > > > + vhost_user_server_detach_aio_context(&vexp->vu_server); > > > +} > >=20 > > Compared to the old code, we're losing the vexp->export.ctx =3D NULL. T= his > > is correct at this point because after drained_begin we still keep > > processing requests until we arrive at a quiescent state. > >=20 > > However, if we detach the AioContext because we're deleting the > > iothread, won't we end up with a dangling pointer in vexp->export.ctx? > > Or can we be certain that nothing interesting happens before drained_end > > updates it with a new valid pointer again? >=20 > If you want I can add the detach() callback back again and set ctx to > NULL there? I haven't thought enough about it to say if it's a problem. If you have and are confident that it's correct the way it is, I'm happy with it. But bringing the callback back is the minimal change compared to the old state. It's just unnecessary code if we don't actually need it. Kevin --8uIPJqxz2LaoW5Jz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE3D3rFZqa+V09dFb+fwmycsiPL9YFAmRSFo4ACgkQfwmycsiP L9bGwQ/9HZIvpsXG7HrllRtRSZut7ucmoWbVO6oQFsVMI4RFuShXz3jZHU1roMAs tCqrZRC6M8Y+JA/pROYtwBTcrvOE/FUc6d/KXFXblg/NGTFDUGwmPWa3t8kZPul/ wfOG8F/BRVLtOhY1DtJhAqO1cXkda/bZxqFDrCgyqtfLpXh+kuVQSOCHbontOMYu vNfhY3FYP0FH44fRnPsUJQVsx0pmZ07waR5lc2ukINv8d0uSN2L7U8Vw8JrNaWAK xGJmpznwr+eZla+/lsWQCQhWysYQIuZGuk/WFeXbitwLEnw7CiJc7qpYf55v4v8Z AOLuMBQVN7QGGrKmpbwuzoD09MOWsIk7dd6X30DxiF7eaE5kO/4jkIeVYPtiaXg2 WUJpZYL1bRX04Tg2snXA4fw06fWMOO1LdAhrDHbU8P+WmxgjDpSO6zFGySFEjukb NHi9p14nSXwrhFUD5wOREzVRR828cmgltcrVypCRPXwISwqxfHuAvqRdrG4/+pIh 5u/VTqxrKerXIPxMgiU9yqJAwaRJkyK/+yFmg9vYUiBcR4sGw5HQIUzeEif5V+pd ckV5NxGX/Wbuyo5RpiL1YnzwB4LthdVaRYLQBuR3RaKyY7G6VSUP9ARQjBg6hEr/ fDnW23q/JH7Gr7CIdAKWz/D9Q4aL+rw4z9CbfBFkq4oG7naqDIU= =3jaa -----END PGP SIGNATURE----- --8uIPJqxz2LaoW5Jz-- From xen-devel-bounces@lists.xenproject.org Wed May 03 08:42:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 08:42:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529035.822937 (Exim 4.92) (envelope-from ) id 1pu83f-00070s-IJ; Wed, 03 May 2023 08:41:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529035.822937; Wed, 03 May 2023 08:41:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu83f-00070l-Fh; Wed, 03 May 2023 08:41:55 +0000 Received: by outflank-mailman (input) for mailman id 529035; Wed, 03 May 2023 08:41:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu83e-00070f-1W for xen-devel@lists.xenproject.org; Wed, 03 May 2023 08:41:54 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 59abf5b9-e98e-11ed-8611-37d641c3527e; Wed, 03 May 2023 10:41:51 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 75AAC22448; Wed, 3 May 2023 08:41:51 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4E77C139F8; Wed, 3 May 2023 08:41:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ekddEU8eUmT0dwAAMHmgww (envelope-from ); Wed, 03 May 2023 08:41:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 59abf5b9-e98e-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683103311; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lUD7esgrDW79z9o7+4vsMOz/TSmW2ZPXBObw8d5vtnU=; b=Z95QtXrIV8lVavs295Wjb54a3o+JdDbodmdlTdvZ5OBWGCGCegXm+GcDi3lzbNOT4bKnZm wxgNWV1JogPKjZfZGjRlb4EXF9ekz6uPoaYHG4j//PMQhubJLIml3rvdf/0sEbEOFPhaFC NDIS/b95wbSa3tRRghUQgGW03zzYTdM= Message-ID: Date: Wed, 3 May 2023 10:41:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v4 05/13] tools/xenstore: use accounting buffering for node accounting Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230405070349.25293-1-jgross@suse.com> <20230405070349.25293-6-jgross@suse.com> <887675ad-ef06-cf8c-8a32-5b3f726e2198@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------TMp6T5rdQQnTdKltCroqfQzP" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------TMp6T5rdQQnTdKltCroqfQzP Content-Type: multipart/mixed; boundary="------------5CBjTXPndDZHeScJshg2sxDR"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: Subject: Re: [PATCH v4 05/13] tools/xenstore: use accounting buffering for node accounting References: <20230405070349.25293-1-jgross@suse.com> <20230405070349.25293-6-jgross@suse.com> <887675ad-ef06-cf8c-8a32-5b3f726e2198@suse.com> In-Reply-To: --------------5CBjTXPndDZHeScJshg2sxDR Content-Type: multipart/mixed; boundary="------------OB0I27oQAIR4oCHfZceSMzAY" --------------OB0I27oQAIR4oCHfZceSMzAY Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMDUuMjMgMTA6MDIsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDAzLzA1LzIwMjMgMDY6MTMsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBP biAwMi4wNS4yMyAyMDo1NSwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPj4+IEhpIEp1ZXJnZW4s DQo+Pj4NCj4+PiBPbiAwNS8wNC8yMDIzIDA4OjAzLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0K Pj4+PiBBZGQgdGhlIG5vZGUgYWNjb3VudGluZyB0byB0aGUgYWNjb3VudGluZyBpbmZvcm1h dGlvbiBidWZmZXJpbmcgaW4NCj4+Pj4gb3JkZXIgdG8gYXZvaWQgaGF2aW5nIHRvIHVuZG8g aXQgaW4gY2FzZSBvZiBmYWlsdXJlLg0KPj4+Pg0KPj4+PiBTaWduZWQtb2ZmLWJ5OiBKdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+Pj4+IC0tLQ0KPj4+PiDCoCB0b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jwqDCoCB8IDIxICsrLS0tLS0tLS0tLS0tLS0tLS0t LQ0KPj4+PiDCoCB0b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmggfMKgIDQgKyst LQ0KPj4+PiDCoCAyIGZpbGVzIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMjEgZGVsZXRp b25zKC0pDQo+Pj4+DQo+Pj4+IGRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfY29yZS5jIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYw0KPj4+PiBpbmRl eCA4NDMzNWY1ZjNkLi45MmE0MGNjZjNmIDEwMDY0NA0KPj4+PiAtLS0gYS90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfY29yZS5jDQo+Pj4+ICsrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF9jb3JlLmMNCj4+Pj4gQEAgLTE0NTIsNyArMTQ1Miw2IEBAIHN0YXRpYyB2b2lkIGRl c3Ryb3lfbm9kZV9ybShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgDQo+Pj4+IHN0cnVjdCBu b2RlICpub2RlKQ0KPj4+PiDCoCBzdGF0aWMgaW50IGRlc3Ryb3lfbm9kZShzdHJ1Y3QgY29u bmVjdGlvbiAqY29ubiwgc3RydWN0IG5vZGUgKm5vZGUpDQo+Pj4+IMKgIHsNCj4+Pj4gwqDC oMKgwqDCoCBkZXN0cm95X25vZGVfcm0oY29ubiwgbm9kZSk7DQo+Pj4+IC3CoMKgwqAgZG9t YWluX25iZW50cnlfZGVjKGNvbm4sIGdldF9ub2RlX293bmVyKG5vZGUpKTsNCj4+Pj4gwqDC oMKgwqDCoCAvKg0KPj4+PiDCoMKgwqDCoMKgwqAgKiBJdCBpcyBub3QgcG9zc2libGUgdG8g ZWFzaWx5IHJldmVydCB0aGUgY2hhbmdlcyBpbiBhIHRyYW5zYWN0aW9uLg0KPj4+PiBAQCAt MTc5NywyNyArMTc5NiwxMSBAQCBzdGF0aWMgaW50IGRvX3NldF9wZXJtcyhjb25zdCB2b2lk ICpjdHgsIHN0cnVjdCANCj4+Pj4gY29ubmVjdGlvbiAqY29ubiwNCj4+Pj4gwqDCoMKgwqDC oCBvbGRfcGVybXMgPSBub2RlLT5wZXJtczsNCj4+Pj4gwqDCoMKgwqDCoCBkb21haW5fbmJl bnRyeV9kZWMoY29ubiwgZ2V0X25vZGVfb3duZXIobm9kZSkpOw0KPj4+DQo+Pj4gSUlSQywg d2Ugb3JpZ2luYWxseSBzYWlkIHRoYXQgZG9tYWluX25iZW50cnlfZGVjKCkgY291bGQgbmV2 ZXIgZmFpbCBpbiBhIA0KPj4+IG5vbi10cmFuc2FjdGlvbiBjYXNlLiBCdXQgd2l0aCB5b3Vy IGN1cnJlbnQgcmV3b3JrLCB0aGUgZnVuY3Rpb24gY2FuIG5vdyBmYWlsIA0KPj4+IGJlY2F1 c2Ugb2YgYW4gYWxsb2NhdGlvbiBmYWlsdXJlLg0KPj4NCj4+IEhvdyB3b3VsZCB0aGF0IGJl IHBvc3NpYmxlIHRvIGhhcHBlbj8NCj4+DQo+PiBkb21haW5fbmJlbnRyeV9kZWMoKSBjYW4g b25seSBiZSBjYWxsZWQgaWYgYSBub2RlIGlzIGJlaW5nIG93bmVkIGJ5IGFuIGFscmVhZHkN Cj4+IGtub3duIGRvbWFpbi4gU28gYWxsb2NhdGlvbiBpcyBpbXBvc3NpYmxlIHRvIGhhcHBl biwgYXMgdGhpcyB3b3VsZCBiZSBhIG1ham9yDQo+PiBlcnJvciBpbiB4ZW5zdG9yZWQuDQo+ IA0KPiAgRnJvbSBteSB1bmRlcnN0YW5kaW5nLCB0aGUgbm9kZXMgYWNjb3VudGluZyB3aWxs IGJlIHRlbXBvcmFyeSBhbmQgdGhlbiANCj4gY29tbWl0dGVkIGF0IHRoZSBlbmQgb2YgdGhl IHJlcXVlc3QuDQo+IA0KPiBTbyB3ZSB3b3VsZCBjYWxsIGFjY19hZGRfY2hhbmdlZF9kb20o KSB3aGljaCBtYXkgcmVxdWlyZSBhbGxvY2F0aW9uIHRvIGhvbGQgdGhlIA0KPiB0ZW1wb3Jh cnkgYWNjb3VudGluZy4NCg0KQWgsIHJpZ2h0LCBnb29kIGNhdGNoIQ0KDQpXaWxsIGFkZCBj aGVja2luZyB0aGUgcmV0dXJuIHZhbHVlIGFuZCBtb3ZlIHRoZSBjYWxscyBhaGVhZCBvZiB0 aGUgdGRiIGNoYW5nZXMuDQoNCg0KSnVlcmdlbg0K --------------OB0I27oQAIR4oCHfZceSMzAY Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------OB0I27oQAIR4oCHfZceSMzAY-- --------------5CBjTXPndDZHeScJshg2sxDR-- --------------TMp6T5rdQQnTdKltCroqfQzP Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmRSHk4FAwAAAAAACgkQsN6d1ii/Ey/x /Af+LQayKbh6eHMkv4HWMtqlDxEjXR1ipNLuHisUPL+VBlb2oqr35hC2mKpkD014gUBr7gGonEHH yBbA+EKgTBdNM/HAnB2UzxOW/IHavKElP+U2CVAM9g9PPuOTJZoLIo5OP6tMRWjbIETvT0Kn8OLm /rP5jqmBi4G0slEKnci4XPn4qeW2GwOagcvJgW5d05a4rfxyX1O4ik2lzFj641/MpLyc25++JJwR PrgY7nB4nhDok1xYz0Q0GUXfHfIN/zjEoVamIsrltsIv+FQBaRgufH6Mxwx7TC8koDJOwl6PIHz1 pbPa6P3o71M8r05ofPeRW9HW5Dmn+1k12DdNoRaVuA== =WGAn -----END PGP SIGNATURE----- --------------TMp6T5rdQQnTdKltCroqfQzP-- From xen-devel-bounces@lists.xenproject.org Wed May 03 09:01:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 09:01:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529039.822947 (Exim 4.92) (envelope-from ) id 1pu8MU-00011m-1E; Wed, 03 May 2023 09:01:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529039.822947; Wed, 03 May 2023 09:01:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu8MT-00011f-UI; Wed, 03 May 2023 09:01:21 +0000 Received: by outflank-mailman (input) for mailman id 529039; Wed, 03 May 2023 09:01:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu8MR-00011Z-Rt for xen-devel@lists.xenproject.org; Wed, 03 May 2023 09:01:20 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0edab7a3-e991-11ed-b225-6b7b168915f2; Wed, 03 May 2023 11:01:17 +0200 (CEST) Received: from mail-dm3nam02lp2045.outbound.protection.outlook.com (HELO NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.45]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 May 2023 05:01:10 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by PH0PR03MB6478.namprd03.prod.outlook.com (2603:10b6:510:b3::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Wed, 3 May 2023 09:01:07 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec%3]) with mapi id 15.20.6340.031; Wed, 3 May 2023 09:01:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0edab7a3-e991-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683104477; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=uHpfFcdAXwIgkMT8P5xBrItPuaNsQy8c7pMU+K0M+mk=; b=YIU6XQ8HcgJ/bVSiK0R2x6c3e3ZMRDVvLNU6L6wjh70rEhZ2+FQBiIzW 7bwmDCqpbGKicp8EsVvZhvQUY9JYcjPii15a4hdXksVMGeMoDWsiZ5Gik 8qY+fEZmalxtTVHm9uIlmzNzMyP4HOSzARH6+D8nLpuGViE5MK/8wHe9K M=; X-IronPort-RemoteIP: 104.47.56.45 X-IronPort-MID: 107704670 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:jdsSyKBRX+LTXBVW/9Xiw5YqxClBgxIJ4kV8jS/XYbTApGh20WRVx mRNWzyPbveIZTfwe9siaoq39RgD6seDzdNkQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFuspvlDs15K6p4G5A5QRnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw0+11IFwf+ 6YkNz1Qchuqt8mUzLy8Vbw57igjBJGD0II3nFhFlWucIdN9BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI++xrvgA/zyQouFTpGMDSddGQA91cg26Tp 37c/nS/CRYfXDCa4WPdrS302rGQxUsXXqpCMbO31vNBgGSv/W8PKlpGTla4+aeQ3xvWt9V3b hZ8FjAVha077kmiVNT+dxy+vn+fvxQYVsZQEus18wWEwOzf5APxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+8rzm/JCwUJm8qfjIfQE0O5NyLiJ43pgLCSJBkCqHdpt/oHTD9x RiaoS54gK8c5eYQzLmy913DhzOqp7DKQxQz6wGRWXiqhithbZOhT5yl7x7c9/koEWqCZlyIv XxBl83F6ukLVcuJjHbVHLhLG6y17fGYNjGamURoA5Qq6zWq/TikYJxU5zZ9YkxuN67oZAPUX aMagisJjLc7AZdgRfIfj16ZYyjy8ZXdKA== IronPort-HdrOrdr: A9a23:0BOv2q8laMStvgsvEXBuk+G/dr1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqN03IV+rwXZVoZUmsjaKdhrNhRotKPTOWwVdASbsP0WKM+V3d8kHFh41gPO JbAtJD4b7LfCdHZKTBkW6F+r8bqbHokZxAx92uqUuFJTsaF52IhD0JbjpzfHcGJjWvUvECZe ehD4d81nOdkTN9VLXJOlA1G8z44/HbnpPvZhALQzYh9Qm1lDutrJLqDhSC2R8acjVXhZMv63 LMnQDV7riq96jT8G6Q60bjq7Bt3PfxwNpKA8KBzuATNzXXkw6tIKhxRrGYuzgxgee3rHInis PFrRsMN9l6r1nRYma2ix3w3BSI6kdl11bSjXujxVfzq83wQzw3T+JHmIJiaxPcr24tpst13q 5n13+Q88M/N2KKoA3No/zzEz16nEu9pnQv1cYVknxkSIMbLJtct5YW8k95GIoJWAj69IckOu 9zC9y03ocfTXqqK1Ti+kV/yt2lWXo+Wj+AX0g5o8SQlwNbmXhopnFosPA3rzMlztYQWpNE7+ PLPuBDj7dVVPIbaqp7GaMoXda3Inale2OMDEuiZXDcUI0XMXPErJD6pJ8v4vuxRZAOxJwu3L zcTVJjs3IocU6GM7zB4HRyyGGPfIyBZ0Wu9ikHjKIJ/4EUBYCbfhFrcWpe0/dJ+J4kc4nms/ XaAuMiPxasFxqoJW9z5XyPZ3BjEwhhbCQrgKdLZ7uvmLO9FmS4jJ2sTN/jYJzQLB0DZkTTRl M+YRmbHrQz0qnsYA61vCTs X-Talos-CUID: 9a23:sOS36WwxDsCyMdlTexHZBgU9EcIETyzTlkvPLhKkAk9ZY5+ZR1iPrfY= X-Talos-MUID: =?us-ascii?q?9a23=3AfgNDAQ4WeAJZMqELBVPbVwtKxow4xqqhKE0mkaw?= =?us-ascii?q?6gMqYF2sgIDqe1GqeF9o=3D?= X-IronPort-AV: E=Sophos;i="5.99,246,1677560400"; d="scan'208";a="107704670" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a04QjF8cUxkfO3hpRqGr6wKBWdSA9N+NibetoKJimr0CJPRKJPnZqafsCkjNvnpdaANPPSrc9Qa1hI501i0eyrXR0eLDRI9IDY6x/AZJasF77hXh0KW63Jr4Kndm2DRHUZw5hWRy8ZAaluXOdf1cifP2MYTTU5jEdEgnzWvlnpPRgUMi3ft7bUqrUrn1X9uuMNpKyv2Ql8y0NE21yU8NpFqqdCGnpGIRdtZfkJgpaLbZBID1OhsLXbN/2p2UYJHJTAEizWEje1PUk7aRVlpu5oGfU+mkDsSJFocrUCTBqstt1vkN+hecn9ZyIUcuNpcxdIqMKJtWb9BNTks9F/B8sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I9zylJ9wiT91cpmea72jc3/pwcQNSdq+sLu8ekS/W6k=; b=UiqI3sJueayFAY5WTMRufMa7nKI72KuykVgQVzUDZtZFagmAG0/SFLwBL5hGZYbz7GfKiQeFtPdb7jeSx56kjiLU2wrRYTx1Pli1r7TJpoJxtbhsewvMUklqUcBcySqAj6G9tDJ/Eh+e1OmexAoZNS6ME9G9myDF27VAMMPjCEIG6DS5Q1PhzWxU0dHRXCoGaMdgo/nCT+gp97fXRTACYBuPAtwME/CDPPfseaEJ3CAMBu2+KrY+RkdP5QaE69vuEg+3HOfvCZHeEW5i5V7Uc4nA8tiZsTfXJ2hQQefmrUtTnKcGhSL9Q3/fTsBVvN2SPSBS1LkQSGc83Js1Ct6/4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I9zylJ9wiT91cpmea72jc3/pwcQNSdq+sLu8ekS/W6k=; b=vzZ/OWxPi6N0TdAfRPzfyC2P1tYFwtyvTXKzisAstgzd5fEKpWxq9AyQyTuIHGBFoO5FYoUHg5pFBJAl3gHWBq9/DYuhk6O608Y8v0klN88/U+Jfd6r4MFjycmeVWAT95gvQosNUB+WN33UOHliCY8IQkE5E6wSpqeLPUjPkYtI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 3 May 2023 11:01:01 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Cc: xen-devel@lists.xenproject.org, Jan Beulich , Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Paul Durrant Subject: Re: [PATCH v3 1/4] x86/msi: passthrough all MSI-X vector ctrl writes to device model Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P265CA0074.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2bd::13) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|PH0PR03MB6478:EE_ X-MS-Office365-Filtering-Correlation-Id: 0cc9a1a0-45d1-4b0b-3ae3-08db4bb4ee8b X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6OPqI/Kux9wUr+CKQ3nLOHe5ODt5ftQUkFh+Pb8IeIqjZ4wiPHhFQLpNuMW4nAMzFeDLpHZsPzI9fNRLmIx9io/dK22SQJGV+X3xOhxhoDaT1Pu3JGxm320dW20MjI4WfH4BucSca8SwFcR5PsrgLuc53FnRGEEnPFl0Ht/R3SV+0JVHBgjjDekshnQGbLPGIGwtNKA++DINRqpRTUboycfszynXMEWxem/t2bxW4je2nfRo5z2O9HhyTH7fpXiKo0AFJeAq7ILv0QkZtFBZ4BUuFU/b/WW/2LGbXeAwLYPzbAzQt/ZyG6+vDdAFuwNxKc2Wy8pJtuw/m+l0+jGkCpsAypeA0b29r4Ac9ah/lder8jI0mUM7PM6dLWpZcrm0fDnI0+O9D0SiIB4wtxYZgfnHksfW35EPGoo6EhXUsNj9Jl9l6cLqE+b4cbxPRmAW4hVYCwPqwTCNms5ZAwLaxf5j8VjtrFNx6x0lNgmVttqsKSHy//SbumEbAMzSnd1ZvdigaRwn0Ghcmqggs6iV0KgKPgJR+QpfTzBQ/2p5uzRZ1V8gD7rcgyN86C9vhLHB X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(7916004)(39860400002)(136003)(376002)(396003)(366004)(346002)(451199021)(6916009)(5660300002)(8676002)(86362001)(6512007)(83380400001)(9686003)(26005)(66574015)(186003)(33716001)(82960400001)(6506007)(38100700002)(8936002)(316002)(6486002)(54906003)(85182001)(41300700001)(478600001)(6666004)(4326008)(66946007)(66476007)(66556008)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cUQ1YUN2Ty80WXA5TEZwZm15UzVnaUlndUtmUFlSZXhOcHZSMGdGZ2M1N25k?= =?utf-8?B?Z3R2YmRMaWFKNHRRcXptSGtQeXZnUTIxR2dzZ253TnBOL0UwdEhVOFhveFYw?= =?utf-8?B?QmdhSDkyeEE0ZmZxcHA0UjJVQnNpdkxreTVXdzd2d29PM3ZxSFpmVDhHTGdY?= =?utf-8?B?QjgzQXA5TVlWeWVobXZIaVg3VEk4eDc2Q3UxaDl6QytjZzZYMGFVdWV5bnFW?= =?utf-8?B?ZVduUHpSRndxY0tCeUhvTXloM25RSjBRcFRpOE9aWUhJNW4rK0FLMXEvaU1N?= =?utf-8?B?SW5XNlRESjlHN3FjejBYNlJFMksxK0F4bGhwbHJGM1A5Qzlza2RPWld6blE4?= =?utf-8?B?THowbW15a1RKZTZSd2V6M2NHOGRYSno4Q3d0aiswRjV2bVRHNFZ2c0JQWnRi?= =?utf-8?B?bWJXcXVIbUM0KzRCanRNaFcvUWJsQWQzWHlZa3VJbTlsbXNzcEd6TmJlUGpK?= =?utf-8?B?aHBXeDFoL3cva2VnWWI1QU5XOURnNG1GWis0N2JPby9BUHdjbGtpTjYyeFhN?= =?utf-8?B?dDRNZXZ2M241VjlYRHNzdTE0S3NINGIxa3RJUThFOGZBN2JHOGFrV2p4OXd0?= =?utf-8?B?MzEwQWRLMm1rcXBNeXpnUVFyTjhhbnBsVGxoeUxaUlVNa0cxOEpVMFFwQmps?= =?utf-8?B?VzQvcXg4SWN0VWtYanhVWFFnMWJ3VHFJQUpkWmt1OUJweGZobm0rVFpTK2tR?= =?utf-8?B?aHp5ZExaNUdIVXoxZEQ0MDY0cEJZRGs5d0ltT2E4czZ0MDBXeFF3aTdreGlE?= =?utf-8?B?M1hkNjNMZlpzVGlzNU5ld3plUlNQaWNSdkJHZGR2Z0trbk0rcWdTbFNhdHla?= =?utf-8?B?N2xLOE5iTUdUWnMwTUw4ZXFHUnJ5a0haa25NZkZsTnRTcVZneDVoVWw0NElQ?= =?utf-8?B?amV0ZWhwRXJVd1BZT0o4RmVBTUF5NStjMElFSi9JWldIQlpwUGQ4RnFMSjZk?= =?utf-8?B?NmIwVEdyNzgvejdWZU9ROTBrSjVUQUUvOWNTUGxKYUhnYTZZZEJiQUM2N09v?= =?utf-8?B?YmFXNEsvdWtLcHV5QWFtMUJ0djJLczRnRFBjenhjK29HQkRneDJQa21wb3dW?= =?utf-8?B?TStSUjFKZ0pYNGFRS3YyM2w0N2gvdUh4R3JUdzNUaG5LQnRHSzFseFpaQTE4?= =?utf-8?B?VG10ZVp0V09VTTVnamxrQkdPMHArWmM2K1diQS82QTd2SjZEQlJBemFLWmo0?= =?utf-8?B?eGp0KzNuRXlPS0huLzBpYVE5SUViRnViL2F5R2ZXeUhLYWNjanFXODVlM3JV?= =?utf-8?B?N0JFT1Z5OTI2Q1dTc0tpL0F2VUQzcFd0VVFCRG14d2h1WVpFaEMvSm9qZEtn?= =?utf-8?B?cXpXRStuMDI0aXQxVXpvS0hncEdNbC93R0dSUlkxN2M2MG5LZ1dJVkNpcTND?= =?utf-8?B?VjNkdU8rMVlFMEdNc01mUk5zRVRreHFpN3pCOC9RbFUxWnFKd2xtQVZTaWpB?= =?utf-8?B?SGlNaksxY1BobmNDcXB6MDJNSnBpMDZMeDE0Ym5iVFZManFRK21zRW5MZmFo?= =?utf-8?B?a2dBOW9LV29HY20xQlJwQ0FIVjZDbzF2N3pkQUJJQW9UTVN3N3A3L2JOSVlZ?= =?utf-8?B?bmdSRzdiNzBwY3R1VEYvNHJDUGpnKzlPNEZTeFNuVXpmODlmQ2laOEJKM1ZU?= =?utf-8?B?bVNBVGlOTmQwbkNZMnFXUk9rem1aaHVMU3l4dW5FRlZBS1FTR3l3N2RLbHFo?= =?utf-8?B?cDI1SXl4dEk4N0wzVEtoa2I5aFcvaHRoaVFsUXFUWVhvSUl0WlpKT09mUitm?= =?utf-8?B?c01iQjhaZDdYSnRtSDJDVjJiOFd5dFEyM0FyeXFrWUt1TElxck1WZ0hsVktF?= =?utf-8?B?VG1zUmpOL3VxY3JiT1Rya0l0ck9IcTV3NTVJS3MwSmUxWWNPbUhwcTc1NmxH?= =?utf-8?B?MXpFdGhrNHhoN203OEt4N3AvOUs3TklnOEtrbFBIMEx4Zzkyd3FQSFdabk8y?= =?utf-8?B?OXIrbzJ2TEFqUnF1Ty8rMDBtZHkydEduS1hrTnpPRC9xSjN4R2dQbHU5eTgx?= =?utf-8?B?NUt2dzZya1RwVHlzWVRpcnRjV3d1TThJbDA5dmZYbXdOVUVBM1FUZXo5QW42?= =?utf-8?B?d2NIbU5yM2pDQkN0SGtjR3drL1FrTjI2cTJ3Wmh5bFFxV0RCeGZjSzhKTUl2?= =?utf-8?B?VXhLbHJramtIZDQybWxOWWNEWWFwbTR3YmpUTjZkYXJjK0RFb25vMWNDdW0y?= =?utf-8?B?eXc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: HJC4Qw2E+uy3KMPfGkCmiLojakkcS/9hCju5rNr985KLEGZ8+GK1DkjFQtWmUXW8aK0FbP/fYTBvGrI6Yzp3IzmSvuImLbFMZBtxl83UGLXK98CjmZNkXKwtN1RWg2RJtKuDWlXeYPOySD6Ey0s4pFMLOBhH3FHkIzYneBsV0WbqZyvTWu565AHwhn/hhsRStz+j1GzVmx9VGnpqfVY69vcQ9F/kHfaYN6uLv2tAIzwWQbJr1wKRWfh94j0uz6RzgPGdfU0L6NCOiCUGGBPSFXbLGjOGM81qq9GP/f7DQ9BhBGFh/FxkmtU6sJp4a8KsmLnUWYEZV7sLtnR0ZMYENp4JPUjlgj+cB7RB7xIurQXkqoK1jwnA41++0EAjcdaGqVqTqrvhiqTNGt/vkHtfbjXBu8Su60WTGRdntgva2up/p1jBPIuzO3PsgiYvOktiTuuPRFq3bcXKBKqdADL/xm24ufNxWSaPaf/8mBPUAul+WBZLq85oICpZIqi9sXPXB+xF7Kg3LHCtSHVyZXVk3GCPWYifS5aM6Lio5CdGcIrDRPwk7tQxxPs+KBdnDt6EGbc0BDJpu/8zy5X9CY+0HxAmR1XFN6AVThqV4PkQGzV/Eed1nQfbe1ShdHIt1MOA8r1ob/KmLiUJYFZvKaBTwiIrSQ6YGhbFZozsuSBq7lqmuIRBHk2fCjcFliAGgBgzq8i1DgUFCIj/gyWsjRJyjEb/qW7bgATrGFqibed5fDgcSU855ueZUMlU0lCjo/fpvi3ujmOod4yPod/UpYRhOCkm9LIS5V0ehfxcOwCkFBV2ZfarCvEAhfH38YfhOEJn4i18AzNgnm/yrSZPcaTRIJSe6RQQ289KNVv38YXBWpqMotZBXtm9oBG+GE2C8wITwbsHgX0Jiw+ZFnBElTFtvJPn8xsjcE1+alJm+xjw2O0= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0cc9a1a0-45d1-4b0b-3ae3-08db4bb4ee8b X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 09:01:07.3519 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WFgL2LF1+GL4tWZDI5M9FWLaeFkFilc/uVeeTX3cKPKmZ7TFX3u97zZbsllIh9cO9gT4DVZYUIusUHy3EuPK/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6478 On Thu, Apr 06, 2023 at 05:57:23AM +0200, Marek Marczykowski-Górecki wrote: > QEMU needs to know whether clearing maskbit of a vector is really > clearing, or was already cleared before. Currently Xen sends only > clearing that bit to the device model, but not setting it, so QEMU > cannot detect it. Because of that, QEMU is working this around by > checking via /dev/mem, but that isn't the proper approach. It's just a > workaround which in fact is racy. > > Give all necessary information to QEMU by passing all ctrl writes, > including masking a vector. > > While this commit doesn't move the whole maskbit handling to QEMU (as > discussed on xen-devel as one of the possibilities), it is a necessary > first step anyway. Including telling QEMU it will get all the required > information to do so. The actual implementation would need to include: > - a hypercall for QEMU to control just maskbit (without (re)binding the > interrupt again > - a methor for QEMU to tell Xen it will actually do the work > Those are not part of this series. > > Signed-off-by: Marek Marczykowski-Górecki > --- > v3: > - advertise changed behavior in XEN_DMOP_get_ioreq_server_info - make > "flags" parameter IN/OUT > - move len check back to msixtbl_write() - will be needed there anyway > in a later patch > v2: > - passthrough quad writes to emulator too (Jan) > - (ab)use len==0 for write len=4 completion (Jan), but add descriptive > #define for this magic value > > Should flags on output include only "out" values (current version), or > also include those passed in by the caller unchanged? > --- > xen/arch/x86/hvm/vmsi.c | 18 ++++++++++++++---- > xen/common/ioreq.c | 9 +++++++-- > xen/include/public/hvm/dm_op.h | 12 ++++++++---- > 3 files changed, 29 insertions(+), 10 deletions(-) > > diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c > index 3cd4923060c8..231253a2cbd4 100644 > --- a/xen/arch/x86/hvm/vmsi.c > +++ b/xen/arch/x86/hvm/vmsi.c > @@ -272,6 +272,15 @@ out: > return r; > } > > +/* > + * This function returns X86EMUL_UNHANDLEABLE even if write is properly > + * handled, to propagate it to the device model (so it can keep its internal > + * state in sync). > + * len==0 means really len==4, but as a write completion that will return > + * X86EMUL_OKAY on successful processing. Use WRITE_LEN4_COMPLETION to make it > + * less confusing. Isn't it fine to just forward every (valid) write to the dm, and so not introduce WRITE_LEN4_COMPLETION? (see my comment about _msixtbl_write()). > + */ > +#define WRITE_LEN4_COMPLETION 0 > static int msixtbl_write(struct vcpu *v, unsigned long address, > unsigned int len, unsigned long val) > { > @@ -283,8 +292,9 @@ static int msixtbl_write(struct vcpu *v, unsigned long address, > unsigned long flags; > struct irq_desc *desc; > > - if ( (len != 4 && len != 8) || (address & (len - 1)) ) > - return r; > + if ( (len != 4 && len != 8 && len != WRITE_LEN4_COMPLETION) || > + (len && (address & (len - 1))) ) > + return X86EMUL_UNHANDLEABLE; I think you want to just return X86EMUL_OKAY here, and ignore the access since it's not properly sized or aligned? > > rcu_read_lock(&msixtbl_rcu_lock); > > @@ -345,7 +355,7 @@ static int msixtbl_write(struct vcpu *v, unsigned long address, > > unlock: > spin_unlock_irqrestore(&desc->lock, flags); > - if ( len == 4 ) > + if ( len == WRITE_LEN4_COMPLETION ) > r = X86EMUL_OKAY; > > out: > @@ -635,7 +645,7 @@ void msix_write_completion(struct vcpu *v) > return; > > v->arch.hvm.hvm_io.msix_unmask_address = 0; > - if ( msixtbl_write(v, ctrl_address, 4, 0) != X86EMUL_OKAY ) > + if ( msixtbl_write(v, ctrl_address, WRITE_LEN4_COMPLETION, 0) != X86EMUL_OKAY ) > gdprintk(XENLOG_WARNING, "MSI-X write completion failure\n"); Would it be possible to always return X86EMUL_UNHANDLEABLE from _msixtbl_write() and keep the return values of msixtbl_write() as-is? > } > > diff --git a/xen/common/ioreq.c b/xen/common/ioreq.c > index ecb8f545e1c4..bd6f074c1e85 100644 > --- a/xen/common/ioreq.c > +++ b/xen/common/ioreq.c > @@ -743,7 +743,8 @@ static int ioreq_server_destroy(struct domain *d, ioservid_t id) > static int ioreq_server_get_info(struct domain *d, ioservid_t id, > unsigned long *ioreq_gfn, > unsigned long *bufioreq_gfn, > - evtchn_port_t *bufioreq_port) > + evtchn_port_t *bufioreq_port, > + uint16_t *flags) > { > struct ioreq_server *s; > int rc; > @@ -779,6 +780,9 @@ static int ioreq_server_get_info(struct domain *d, ioservid_t id, > *bufioreq_port = s->bufioreq_evtchn; > } > > + /* Advertise supported features/behaviors. */ > + *flags = XEN_DMOP_all_msix_writes; > + > rc = 0; > > out: > @@ -1374,7 +1378,8 @@ int ioreq_server_dm_op(struct xen_dm_op *op, struct domain *d, bool *const_op) > NULL : (unsigned long *)&data->ioreq_gfn, > (data->flags & XEN_DMOP_no_gfns) ? > NULL : (unsigned long *)&data->bufioreq_gfn, > - &data->bufioreq_port); > + &data->bufioreq_port, &data->flags); > + > break; > } > > diff --git a/xen/include/public/hvm/dm_op.h b/xen/include/public/hvm/dm_op.h > index acdf91693d0b..490b151c5dd7 100644 > --- a/xen/include/public/hvm/dm_op.h > +++ b/xen/include/public/hvm/dm_op.h > @@ -70,7 +70,9 @@ typedef struct xen_dm_op_create_ioreq_server xen_dm_op_create_ioreq_server_t; > * not contain XEN_DMOP_no_gfns then these pages will be made available and > * the frame numbers passed back in gfns and > * respectively. (If the IOREQ Server is not handling buffered emulation > - * only will be valid). > + * only will be valid). When Xen returns XEN_DMOP_all_msix_writes > + * flag set, it will notify the IOREQ server about all writes to MSI-X table > + * (if it's handled by this IOREQ server), not only those clearing a mask bit. > * > * NOTE: To access the synchronous ioreq structures and buffered ioreq > * ring, it is preferable to use the XENMEM_acquire_resource memory > @@ -81,11 +83,13 @@ typedef struct xen_dm_op_create_ioreq_server xen_dm_op_create_ioreq_server_t; > struct xen_dm_op_get_ioreq_server_info { > /* IN - server id */ > ioservid_t id; > - /* IN - flags */ > + /* IN/OUT - flags */ > uint16_t flags; > > -#define _XEN_DMOP_no_gfns 0 > -#define XEN_DMOP_no_gfns (1u << _XEN_DMOP_no_gfns) > +#define _XEN_DMOP_no_gfns 0 /* IN */ > +#define _XEN_DMOP_all_msix_writes 1 /* OUT */ > +#define XEN_DMOP_no_gfns (1u << _XEN_DMOP_no_gfns) > +#define XEN_DMOP_all_msix_writes (1u << _XEN_DMOP_all_msix_writes) FWIW, we usually interleave _XEN_DMOP_no_gfns and XEN_DMOP_no_gfns, ie: #define _XEN_DMOP_no_gfns 0 /* IN */ #define XEN_DMOP_no_gfns (1u << _XEN_DMOP_no_gfns) #define _XEN_DMOP_all_msix_writes 1 /* OUT */ #define XEN_DMOP_all_msix_writes (1u << _XEN_DMOP_all_msix_writes) I wonder whether XEN_DMOP_all_msix_writes should be a feature requested by the dm, as to not change the existing behaviour of how MSIX writes are handled (which might work for QEMU, but could cause issues with other out of tree users of ioreqs)? That would turn XEN_DMOP_all_msix_writes into an IN flag also. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed May 03 09:24:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 09:24:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529044.822957 (Exim 4.92) (envelope-from ) id 1pu8iY-0003YG-Vb; Wed, 03 May 2023 09:24:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529044.822957; Wed, 03 May 2023 09:24:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu8iY-0003Y9-SQ; Wed, 03 May 2023 09:24:10 +0000 Received: by outflank-mailman (input) for mailman id 529044; Wed, 03 May 2023 09:24:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu8iY-0003Y3-1Z for xen-devel@lists.xenproject.org; Wed, 03 May 2023 09:24:10 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2082.outbound.protection.outlook.com [40.107.7.82]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 41efe7cc-e994-11ed-b225-6b7b168915f2; Wed, 03 May 2023 11:24:09 +0200 (CEST) Received: from AM6PR0502CA0072.eurprd05.prod.outlook.com (2603:10a6:20b:56::49) by AS2PR08MB9975.eurprd08.prod.outlook.com (2603:10a6:20b:62c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Wed, 3 May 2023 09:23:34 +0000 Received: from AM7EUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:56:cafe::f5) by AM6PR0502CA0072.outlook.office365.com (2603:10a6:20b:56::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.33 via Frontend Transport; Wed, 3 May 2023 09:23:34 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT006.mail.protection.outlook.com (100.127.141.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22 via Frontend Transport; Wed, 3 May 2023 09:23:33 +0000 Received: ("Tessian outbound 5154e9d36775:v136"); Wed, 03 May 2023 09:23:33 +0000 Received: from 0921191df72a.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 02A1AA8F-D41C-45C9-A4BF-BDEBC6B8812F.1; Wed, 03 May 2023 09:23:22 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0921191df72a.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 03 May 2023 09:23:22 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by AM8PR08MB6356.eurprd08.prod.outlook.com (2603:10a6:20b:36b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.21; Wed, 3 May 2023 09:23:19 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::bce1:f206:86af:31be]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::bce1:f206:86af:31be%6]) with mapi id 15.20.6363.021; Wed, 3 May 2023 09:23:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 41efe7cc-e994-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G/fSbBTFe3/uzUMdyRg6Fli0XJbqBBbHqOn+Zoz/Qus=; b=gPLp8Jd07J+b27HVBb01G5c85sou7BAXnjVa2AtlqlhwMPN6oj/ChUBaD4UxnjSsBAcJZPSW9CyW2EQU9QyQT1PuC4Desocm0r/bEsOJUMk4hbWTNxyGfKFzYdAou1s2ILT31aUnb0G+/u1bxTK+dpzM5RwzLFDvuoQP4pyczg0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 719093a87f3c6ce5 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ItxQTXveafxQT6qGqiK0sW41uxS+L9SdUTpm65Zrqzd0slDbkkB9S3wdSz+JlNHW2mPxu546Vwm2CckQ/XZAu5T00f/0pyRXxkl8aU+c2YHzYflIdROtIGf8rfw/3Ez34+mf//iZwYjXijiFIZ8G05uU3aDwRSFqwwiy4x+O5fVBPZoRu1zkvk1vS24CKmSh15nks9czTj7kBatcSVpgk3xUXNBwThCZvnE9VAvvLoD+ge4hzHNrTSF9UwOHc0Bevj6kDzbwFDOJP2kqVd2IguxFleoe+Gx46GtvIyyjXGUIkyr2Tkw8TVu3GgXeecvKmUmbNdnMkPY6l1phX0T/Og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G/fSbBTFe3/uzUMdyRg6Fli0XJbqBBbHqOn+Zoz/Qus=; b=XguU+roEG5S+n/KMfm+ThVDFzaoACjWpusoETMjuSwUQ+28OezuVXCIIgEVwW63Lv0FHEKdOZyIuS7L6b+usFVXNFaMNfRrpEhL8G5dvNk1/5V5fgJ2lD4VKNVeHwC5REdNBMvwuUkdEiwFyD2SoKSO57jx2f5d7LQmoSmp7XrOkyO/4cI5+1/4TNP1eOalSBuIdG7kkxcWOpRmdp8hMnmcxgxDs2dyfqp9B6OsAOEtgt1VHU0LeE7bX5JQjzJmY/IvBTWTrkktw3ridCqU9xF/vDf+eQTHkaocCdLshsohzLv2YyCSzIMM0e4QVzSna6T71JWKIH0w46HhqiUfDbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G/fSbBTFe3/uzUMdyRg6Fli0XJbqBBbHqOn+Zoz/Qus=; b=gPLp8Jd07J+b27HVBb01G5c85sou7BAXnjVa2AtlqlhwMPN6oj/ChUBaD4UxnjSsBAcJZPSW9CyW2EQU9QyQT1PuC4Desocm0r/bEsOJUMk4hbWTNxyGfKFzYdAou1s2ILT31aUnb0G+/u1bxTK+dpzM5RwzLFDvuoQP4pyczg0= From: Luca Fancellu To: Anthony PERARD CC: Xen-devel , Bertrand Marquis , Wei Chen , George Dunlap , Nick Rosbrook , Wei Liu , Juergen Gross , Christian Lindig , David Scott , =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?= , Christian Lindig Subject: Re: [PATCH v6 09/12] tools: add physinfo arch_capabilities handling for Arm Thread-Topic: [PATCH v6 09/12] tools: add physinfo arch_capabilities handling for Arm Thread-Index: AQHZdnKCeDO91wnv7UqBsQsgLvHj6a9HNTmAgAEfoAA= Date: Wed, 3 May 2023 09:23:19 +0000 Message-ID: <34A79CE8-FEE8-426B-810C-1E928E207724@arm.com> References: <20230424060248.1488859-1-luca.fancellu@arm.com> <20230424060248.1488859-10-luca.fancellu@arm.com> <4e6758c0-dd81-4963-8989-d941eba2b257@perard> In-Reply-To: <4e6758c0-dd81-4963-8989-d941eba2b257@perard> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.500.231) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|AM8PR08MB6356:EE_|AM7EUR03FT006:EE_|AS2PR08MB9975:EE_ X-MS-Office365-Filtering-Correlation-Id: 5f7d314a-72b7-4766-2907-08db4bb81105 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: pwdSKhDAs+MaGRnoB1uwi+D+3Nk7oM8LNainJYqONG1yB2KmApys5N6Of5jXhEJLtDG6zGv2mvGwxh5giyypZ8Yg+NYhFh2AEiEcdcI6tb1C/CJUSHSG2XpnkSUbHcmn/2LlybF3jXDlv31yRr0jujibqfC9W1IeTZSnNyWFYXNiHsIyYUQ12royGN6YkIW707RaS53whxJeR1juNgKfwsCow9VhDoRshxrAKu0bW9g1AwXjnD966jG7Uauw+wuMdeUfuhkPgxNJ4ml/YSPt3qTKfFAro7nruxek9NVOXASvRWgZTL9XyCnLX/X6hrJjzZ7eZzhEfsM26DTV0U9ifs1VkRSIoV4NcpFDqx99cabvB1zdq7zB5Bo3/m76lG+Es2HriGKVgQsq63LkPrLAEanGPgVWucicOBJTJfLBaSlxHXD5rF0eOrAWzAKWApbWWJOUim1xJ3p6XpZga/sCOFg6bRR8kVQW5YnAYiWyItkXAGMjwIo/3W+vQsrYJ97fUtJ1ZNphdro5z1ALHQMk8ZCAcYzHF710lE5GrhD4Skr3qSd9t+I6w3gQomPPiiAq0Nmnrl40wNuOm261cPsWXiNl5fx97f+2j5UtGPaJq1T5EpUaPB89o3OKnBrmzUVsREDNrwPutanH51pZVNolIQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(376002)(366004)(396003)(39860400002)(451199021)(76116006)(91956017)(966005)(71200400001)(6506007)(6486002)(478600001)(2616005)(6512007)(53546011)(26005)(54906003)(186003)(6916009)(38100700002)(7416002)(2906002)(4744005)(36756003)(33656002)(5660300002)(122000001)(66556008)(66446008)(64756008)(66476007)(66946007)(4326008)(41300700001)(8936002)(8676002)(38070700005)(316002)(86362001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <8A55BEE214CFBD4C841E48339770822B@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6356 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d137c074-f75e-49c3-d7a7-08db4bb808ce X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o+IzolzGAT5eNBQHz1/w8bqG4vLdPEOg6Cd181NTE0XWobbea9tLnDApIqTbDrfGn9WG/l7+kLOkxBJFPvBqn0ADSB5SO571xh+/uB6EAOlnNr2VXNuBlOA2REFYJSUENfKPbjDny5rozebP5chDGj76iTztEY+Jx6umjmj9m3sBuZTpvHG7FSZcq8pULSjVrW86jBG0CGeXzCufbcdBKrK/bJ4Y7MNGWpTU/G7FTGZN0Puihw8Tf48Dwhd6qmrb6JCb/wxVsUAjl4aQOk1RgcjWyMoe8lF5Aw5NqXkELC6jsWmfOY3I1J9m/iYdbzFRw5fDPvJ6HE3S1rtitXpImIW+mdvdxYYMvGHwGljjai1i+yNfr3oIqJVtmIZgebkqFE7GMCrFusNjGZwAy1D54UmQOvCyuyQYKzpHzZIJMrNbZ+BnJxjqmUi/Y1T5aTXaLVB4XDBbU/t3Tnh8BsAUlceYcPg7tImzuKkJ/wnsnbqsMHIJUeA06TcSH//6CJM9Mfte35K3KIrMfOd6Kst6t9twv31tCvkG3W1+EqfUUD7rY98IjB3Bzpg3eGPGE4MPVKTHZtxcy1nxM8eXfkfv4UtQJJDR6hrs2eukqIOxxTygzqOiInru5tB1YU4mh/KnixUMAKaMS5Q9RugVaXLR+RAOziRdx78VdVlFxtWutzCqH0e2jRKMTte3/DXyjDz5fx9jIQcGdRSIW/lbG662yWM1OdDHCZjYoCQS/emzkMo= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(39860400002)(396003)(136003)(376002)(451199021)(36840700001)(40470700004)(46966006)(2616005)(107886003)(478600001)(36860700001)(186003)(4326008)(54906003)(70586007)(70206006)(47076005)(53546011)(26005)(966005)(6486002)(6512007)(336012)(6506007)(316002)(6862004)(34020700004)(40460700003)(8676002)(82740400003)(8936002)(5660300002)(356005)(41300700001)(2906002)(40480700001)(81166007)(4744005)(82310400005)(86362001)(33656002)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 09:23:33.3892 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5f7d314a-72b7-4766-2907-08db4bb81105 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9975 DQoNCj4gT24gMiBNYXkgMjAyMywgYXQgMTc6MTMsIEFudGhvbnkgUEVSQVJEIDxhbnRob255LnBl cmFyZEBjaXRyaXguY29tPiB3cm90ZToNCj4gDQo+IE9uIE1vbiwgQXByIDI0LCAyMDIzIGF0IDA3 OjAyOjQ1QU0gKzAxMDAsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+PiBkaWZmIC0tZ2l0IGEvdG9v bHMvaW5jbHVkZS94ZW4tdG9vbHMvYXJtLWFyY2gtY2FwYWJpbGl0aWVzLmggYi90b29scy9pbmNs dWRlL3hlbi10b29scy9hcm0tYXJjaC1jYXBhYmlsaXRpZXMuaA0KPj4gbmV3IGZpbGUgbW9kZSAx MDA2NDQNCj4+IGluZGV4IDAwMDAwMDAwMDAwMC4uYWM0NGM4YjE0MzQ0DQo+PiAtLS0gL2Rldi9u dWxsDQo+PiArKysgYi90b29scy9pbmNsdWRlL3hlbi10b29scy9hcm0tYXJjaC1jYXBhYmlsaXRp ZXMuaA0KPj4gQEAgLTAsMCArMSwyOCBAQA0KPj4gKy8qIFNQRFgtTGljZW5zZS1JZGVudGlmaWVy OiBHUEwtMi4wICovDQo+IA0KPiBEbyB5b3UgbWVhbiBHUEwtMi4wLW9ubHkgPw0KPiANCj4gR1BM LTIuMCBpcyBkZXByZWNhdGVkIGJ5IHRoZSBTUERYIHByb2plY3QuDQo+IA0KPiBodHRwczovL3Nw ZHgub3JnL2xpY2Vuc2VzL0dQTC0yLjAuaHRtbA0KPiANCj4gDQo+IEJlc2lkZXMgdGhhdCwgcGF0 Y2ggbG9va3MgZmluZToNCj4gUmV2aWV3ZWQtYnk6IEFudGhvbnkgUEVSQVJEIDxhbnRob255LnBl cmFyZEBjaXRyaXguY29tPg0KDQpUaGFua3MsIEnigJlsbCBmaXggaW4gdGhlIG5leHQgcHVzaCBh bmQgSeKAmWxsIGFkZCB5b3VyIFItYnkNCg0KPiANCj4gVGhhbmtzLA0KPiANCj4gLS0gDQo+IEFu dGhvbnkgUEVSQVJEDQoNCg== From xen-devel-bounces@lists.xenproject.org Wed May 03 09:33:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 09:33:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529046.822967 (Exim 4.92) (envelope-from ) id 1pu8rX-00051q-T6; Wed, 03 May 2023 09:33:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529046.822967; Wed, 03 May 2023 09:33:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu8rX-00051j-Oc; Wed, 03 May 2023 09:33:27 +0000 Received: by outflank-mailman (input) for mailman id 529046; Wed, 03 May 2023 09:33:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu8rW-00051K-TI for xen-devel@lists.xenproject.org; Wed, 03 May 2023 09:33:26 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8a370b6a-e995-11ed-8611-37d641c3527e; Wed, 03 May 2023 11:33:22 +0200 (CEST) Received: from mail-mw2nam10lp2109.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.109]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 May 2023 05:33:18 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by DM6PR03MB5130.namprd03.prod.outlook.com (2603:10b6:5:1e3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Wed, 3 May 2023 09:33:16 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec%3]) with mapi id 15.20.6340.031; Wed, 3 May 2023 09:33:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8a370b6a-e995-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683106402; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=7kyWfYul+N75/GPvgOf9U6x0PuiLzb7N0wkESfsbdow=; b=U7gn32TxpdyjxK85FxjUDW93x0XT7OOFX1brSgH9cUu0L/CeOu2/UcAF D0CHl0IQjb6/Tk0NDSRhQJ8TbxC6qwFTiJtY9KpnSH6moeT27zZ2GrUWM 2LXeNm8p740IzAvLOs+YjVohUX4OQGjGCRVbyBBhhzxbdEGRc/V95RoHK k=; X-IronPort-RemoteIP: 104.47.55.109 X-IronPort-MID: 107574493 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:9GBtEqKTzD/+qfJWFE+R95QlxSXFcZb7ZxGr2PjKsXjdYENShTJRz GQeDWCFPPbfNjbxeNFyOoS/9EwBsZ/VyIc2QARlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPSwP9TlK6q4mhA4wRlPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5GWFtv1 fNAMAtRfxHYoMGs4L6cFtZV05FLwMnDZOvzu1lG5BSAVbMDfsqGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dqpTGLnWSd05C0WDbRUsaNSshP2F6Ru 0rN/njjAwFcP9uaodaA2iv02bKQwX+qA+r+EpWY66Itw2bDzVVPDTYGZGWdnMu9yW6hDoc3x 0s8v3BGQbIJ3E6hQ8T5Xha4iGWZpRNaUN1Ve8Ul7Cmdx6yS5ByWbkAUQzgEZNE4ucseQT0xy kTPj97vHSZosrCeVTSa7Lj8kN+pES0cLGtHYDBeSwIAuoHnuNtq1kOJSct/GqmoiNGzASv33 z2BsCk5gfMUkNIP0KK4u1vAhlpAu6T0c+L83S2PNkrN0++zTNXNi1CAgbQD0ct9EQ== IronPort-HdrOrdr: A9a23:e3yq9au0g1rG7JZ7IJZFWhSa7skDqtV00zEX/kB9WHVpm62j5r uTdZEgviMc5wx+ZJhNo7290eq7MBfhHOdOgLX5ZI3DYOCEghrLEGgB1/qb/9SIIUSXnNK1s5 0QFpSWY+eeMbEVt6rHCUaDYrEdKXS8gcaVrPab5U1ECSttb7hk7w9/AAreKEtrXwNLbKBJd6 Z0ovA33gadRQ== X-Talos-CUID: =?us-ascii?q?9a23=3ApNEZ3Gl3tjV41vLMYiPTjQoYiTfXOUyE9lbwLBe?= =?us-ascii?q?gMjp4SeayakWw9IQ4rPM7zg=3D=3D?= X-Talos-MUID: 9a23:+R31Xgbtne+r1uBTlyKww3JZZMxRv6GFGHEzt6g0v4qkKnkl X-IronPort-AV: E=Sophos;i="5.99,246,1677560400"; d="scan'208";a="107574493" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h38E4wq066uDdodZCwl2CD3/gjWlD+a2ayXmwKgq9qVX4O1MSqs3lB6ITLW+F+ox3h8S10nWWVFAnPKTYmc/STe8F5XTJBVlBO1GH/BetIjrkbz96u4k9RbN8DNiYPDSXv379LdNtG0W9sG8R0VKERfy0CWKyTzbZUWPRlgl6Zw6Xvjd8hI+DGGVO7c7VmCpi5ZZainiLTuOY9IvCR/PPb0/b3+rC4fglHZycj+0CiN2S3G4jqINPxBdw1K/X/BYbWiBTw9VYro+Bq18YWBxsy3f0WPvm3LYsA10Loyx9CjK3/LjSyoQ1R0MchDgJE8w/MP0ZDG7Z173Xa15ctDTng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PJFcSxQoVfNgBFA18BFegmC01/OvepmAEyPElUa5FiA=; b=KHFFLwYt6WtngYimK6VLe5XR9jylchbIsPf+cNzWCzwU2XFdGqk6H8aKRUPbzVeCWLnzyMaqsPzdrqKQKzudOO3Pnw8A7ox4zihr6XYvNsmvu2/42c9yjXUJ34KKdI3vSqsMovWY3SR1C4F2nrD4xYuREFAjjNxbUPOzpukamakJaBTn3iw8NELU0tdmv1YNrt5oW5bZIsZ1q4kDCko8P15xGGgXb73p2QFGmfvDV8RNrjX3ebpH/T4wlN6e2s/qBl8yw2xTTWzxdvw2h3ei/cNJtSgP7vz/FMMJmyaYeiUfC+JqtWVqq1qACtXUxTEJCxjXiXBcKIFsA6b3AwKp8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PJFcSxQoVfNgBFA18BFegmC01/OvepmAEyPElUa5FiA=; b=FusvH7OS77V7esoJ2zUTQ2EbcL3+5E8DK72xoVlL1jkW6fuvKRYf2Lrle+LvLKronuGb4+//B3+NWl8H/CmM1BJuIf/45Hzr52D97st57ZgHnATFGET6iJPNNSWkUMA86AXv8cAg7n39QOr80sezCYC36LrQtQxzJMIWKu0gbn4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 3 May 2023 11:33:09 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH v2 1/2] x86/head: check base address alignment Message-ID: References: <20230502145920.56588-1-roger.pau@citrix.com> <20230502145920.56588-2-roger.pau@citrix.com> <5045583e-8776-0834-ca93-44f85888d877@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5045583e-8776-0834-ca93-44f85888d877@suse.com> X-ClientProxiedBy: LO4P123CA0526.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2c5::12) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|DM6PR03MB5130:EE_ X-MS-Office365-Filtering-Correlation-Id: 062a9424-83dc-4392-9642-08db4bb96bfc X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Bobxd91YDYQx0Tw/pV0aYTfHSZTQ3lrM5m0eNQxA+ox4CB9k/MUzY9pSPd3tGZUr+hBK3K0ydOHty9AT5ciit4ClvrHuKy6XStxvgAedUTQPDZZgE0NdyGwh/T4SUVwbaUdim6Tfw9xAqrM5zqVk5QjBv7W7M2Up2GgCZQgU7W9RED4aO/Cqt8MpI1P3QnlCnc2e2LpMB8EdCzXEpZugRLfB17kqMwOSGTPh6tyFKz+Wdh7yDVUihEjc8jbjmpzhgw19Z1mtI55XGWZHMKdNxBSlXjG56MzYBI8epn5qT5Z+w/Bulk1viXh/5zl04FmLf65oloUdSMRrXGBhxfTEzzRKE863b+P9O2T3T5WxMiaUVfomFXilnSUXx+IPV1+IZCC9M4gTi209G7LfOJsG2JPw88xrSHYNFqwKjBaQ3B15sARRIjdbORs7UDW80nHxUc7jUXS4XAm4T+vS1+R08WfdeBd3RMLeDe96V8z3XRUDHZJaYsmKOW6kfiHuEPONluBERdshJJtUt2TTNg5sFrOQo5/ZOMMYVh5CQO3xtGh5yorUh2PGxOIxH0kub682 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(7916004)(376002)(136003)(396003)(346002)(39860400002)(366004)(451199021)(9686003)(8936002)(8676002)(83380400001)(2906002)(186003)(82960400001)(85182001)(33716001)(38100700002)(86362001)(26005)(5660300002)(6512007)(6506007)(53546011)(41300700001)(6916009)(4326008)(66946007)(66556008)(66476007)(478600001)(316002)(6486002)(6666004)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WHQvdVN6c09pOHBldzFYVzB4Z2tDOG9tMzRCRjE5cTJyMi92Y2s5bkF3VFEr?= =?utf-8?B?Rmk1clBkcnR3Z3JkdkI0WkhBa3Y0bmVZcXVRMXRKWGdBRDkrMkFvaktoZzZp?= =?utf-8?B?SmdRRDNacC82L0NOU0xHMFBMQVowNUlHSjZSbnFjZnh0cXFUNkFYN25iUVh6?= =?utf-8?B?b0xLRUFJVDFRRmhzYnlkdXAwMXk3RXl5MFFqekdubnBCRWdSdGxHOVo1K1J4?= =?utf-8?B?R0JpRjErcnMvVW1IZEkrNnowR0tNV0VTY1ZEQ2J4bU1KZ3JqY0RlWjUvaGhS?= =?utf-8?B?eExwbkxDaGRSaVg3Q1JtSFd2WHhxSkVuTjFtRjg1cFVyVWkrYnVUc3daQUE3?= =?utf-8?B?dU9QOXR1QS9hWlI2RmMyRUNSenR2VHZ2RkxJdXNsM2VXQmFCUzltQXVRT0VF?= =?utf-8?B?Nm5JeHg5cHpab2g2Zm1MUE5sSVF4MUR4WUlFeVVqaU81Rnp2anBqTTZ4NFV1?= =?utf-8?B?alZjZWl0Y1lldGgxSGRKb015d1FrNXpHSGlZbzV3dmJudkFYaWM4aWZER0pL?= =?utf-8?B?WGZGd0RBRTI2aVZTZUpKcWw5QXh0NFl3Y2FhWVcyN0kvd3lLR1J6bVd3dmV6?= =?utf-8?B?WXU3em5uWUgzZXgvbzVxcnJYWTd4M3psOUNFVEtucDhHM0xSWlhMdFFTb0cr?= =?utf-8?B?SUMwYnRFemJoZDM2WXBKRk1FdFB4VHhvaXE4aGR5VUw3Z0dDNmVick5VZS9l?= =?utf-8?B?NXlxNjl1azA3RVZsUmpCQXMzbFRtK3hmNmZLQmZSdkZ3a2ZSdXUyM2dtVTJY?= =?utf-8?B?cFdCRDJkSjV6SkxaaWZRUmxMbzlMVG42b3g3dkxaQmV1RFhVQlRoQy9jYzZV?= =?utf-8?B?MVVSV0llWGl0ZFV0ZjRDejhpS0h0d1V1ZHRqS1ZkQ2RWSklIVDVicW9RcXRJ?= =?utf-8?B?R0M5dGVGby9XNi9HMCtxdTllRVlVNTFKeEpRQ0RWRk5XMnlWTGJJSlp3elp6?= =?utf-8?B?V2FvTE5Ld2tXUlNrT0ZZb2xIL0RocHBZOU9GTlpRUVRoaXRjb0VGa1dmL2Fz?= =?utf-8?B?eXNJeWsrNHVMN3RPTTVSbW9QUzdjWmw0V2ZidE85a1Z4aHB4cHZmVXRFdEtW?= =?utf-8?B?UHBhUXlweGtCSkl5M2lDTDZvNlFleWprKzVvdG9vZkVNWU5wdWpOT05wNzZL?= =?utf-8?B?WWlHTzI2WDdtWjR4ZVdTbGdselNEM1AwcmszOURnWkEyTkJsS0dKNisyWEFv?= =?utf-8?B?cmFHeTNpZEhpSFFMQUpPenRzdVkwWmh5dEN6bGZqYUpudGdFU3V5amxrYmVV?= =?utf-8?B?cVo1TnlQbkJyZ3pzV2grQm82Q3ZXVk9ncnppcUpCT0t6K2dFbm04cVNqUWZQ?= =?utf-8?B?bFRvV0oxbVhSMnExUVRLSU9mMW1JZnZUd2szcDVRV2MvNFM0NUkyMFhzV25F?= =?utf-8?B?b25vWHFid09rR05LaWs2QUVKZGJ1UkdlZkdPZmNHMDVicEFuTHRxSlVYZ1M1?= =?utf-8?B?YUFPS3ZKOW4waXlmQUxmWGxBNUdtdEdDUnJjTzJOQWJWVlFwamFsTU5IOTds?= =?utf-8?B?R2JDTHNFMndYVm1YVXJuclR2c2NwUWpmdkV0V3RkMUlVQTdmTXN6ck9QOE16?= =?utf-8?B?Y2J4b25rOFlPTlVmZVVUQ05udnlxNVc3cnVRRjNvUmIvQStpL3dHYjRnVGxI?= =?utf-8?B?KzZzUnJTc1hERWFTNFByRi9DNThXWmRaWENSZVgvejBPTm1BRU1vbUkrK2VH?= =?utf-8?B?RG50SnQ5NWVVZmM4VWtZa21DU0hNc2JMVHJpWjZYTGtHK0ZORFc1Tno1cmlG?= =?utf-8?B?OVUvZXUzUXhuUTBLbVZ2eGtDR0hBMkdrT3hucDdiSGJNUVdTbzFoR2VZS2pY?= =?utf-8?B?VHlyZytCVm1taFVHSlVzUFIwSzM2N0dFdVJVZCtVZkZSM3lOTVg4VndPVUpI?= =?utf-8?B?YVhpMnF3dCtwVEVtVWp2UVJDZTRFSFZYSmxhNXNWOVYwVkpqb09wcy9NRS96?= =?utf-8?B?MzJZUzI5QWd4enByUitVMTQ3ZFhSRGtUZG9TamJpVGNHSFlBc3BHdjEreHg0?= =?utf-8?B?U0UyWXZmSkFWSjU0OUNRLzBBanZCSEliS29NQlJZY0xTT0JhZTJxTVJFNFIz?= =?utf-8?B?T1dUY3ROcDl0NGRsWjlBSEplaVpoeFBXWWhodk5tU1ViUW1IUzZtaVFWN1Fa?= =?utf-8?B?aGtydlhUdWtJamh6Wjc1dnF1b0U2dmlCM3Y3dGRJc1hja04xeFlXUzJubU1S?= =?utf-8?B?aGc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: pOJsr4RIOW8ELRhh7sc8hHUC3SDAkOZHV5PT5WNuAs3gKzRdJlmosNSwvW2di3q6IochLxezE7eKeFZEU6FugLn7u2D8/ITp2GBYJNjLz8ELNUVDtm/++MKcXOlP1rO5F7fJSqfSTml+pqqXcPzSrwNdp4o0EwzSw6Oby5lLBdKXQIAYWfwTWJuqnyj8veuw1rIFjfIl9cFHAm/B1S4bvp06fkZIW5K8OvqoKpu14cqbTKYHTw0Nw2lMEx6YfwTh+3qlGiCIkMzk5rwa9u+dNi+WJkUqeEHvyDU+Ym76OBfx72QZODf5h0lyLPHhb9UOY0Xv7XcZver6cXIh/hwXtwwS/uXLvlhfPT4bK9+/z/mRSejpVXJCVXMsD37pLfzQF+5a3QRpB5i2u0M6LklL3zVz6X1oF6rS2xAev7lEoS06VYVVGHA2hzqB5iAnD4Q/VPvCjAjsj+FZPW/2KdozKFfho5Lbwu0qSuTBJfWxg0wutmK8pVAA1YACpg8vg/pdrVTGH7YvIanfmooJkBhjCj6hKEKVXWzYxdbTE1GI4Z22NIqSsO2pNr2GCUaLP2mlWVgQzgvAfbRnITQa34UyfnXBpfI5++fIaF2aWzOWRmqk326FDAVH7/+6pKaA+VmSKovnEEfAaBtJq2Zi6Kqu3e9YDnhN/2B37LBJ8tALFS+5/fSLXyJ0xRcvQL0bmXZQ16KRBqvcV19allgEvA4LctPJ7LzUHShanB0qPj/qes8EZL38u5ISY1SbUwKu6yIT+e3+q8FeXKQgXqyRMylEphJjj1Cdhh53Vhkzv7DvElG8l7pwXwL4Ye/wUDMvDX4w X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 062a9424-83dc-4392-9642-08db4bb96bfc X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 09:33:15.8613 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: b6RMVv8yMGEdEm/iWO0KKivXLa7nubGJd5Vosk3EdtRXnGX7T/N1CEN+76MdrUWZZLY7QLgsZGryNlQ2Yi97xg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5130 On Wed, May 03, 2023 at 10:08:20AM +0200, Jan Beulich wrote: > On 02.05.2023 16:59, Roger Pau Monne wrote: > > Ensure that the base address is 2M aligned, or else the page table > > entries created would be corrupt as reserved bits on the PDE end up > > set. > > > > We have encountered a broken firmware where grub2 would end up loading > > Xen at a non 2M aligned region when using the multiboot2 protocol, and > > that caused a very difficult to debug triple fault. > > > > If the alignment is not as required by the page tables print an error > > message and stop the boot. Also add a build time check that the > > calculation of symbol offsets don't break alignment of passed > > addresses. > > > > The check could be performed earlier, but so far the alignment is > > required by the page tables, and hence feels more natural that the > > check lives near to the piece of code that requires it. > > > > Note that when booted as an EFI application from the PE entry point > > the alignment check is already performed by > > efi_arch_load_addr_check(), and hence there's no need to add another > > check at the point where page tables get built in > > efi_arch_memory_setup(). > > > > Signed-off-by: Roger Pau Monné > > Reviewed-by: Jan Beulich > > Would you mind if, while committing, ... > > > @@ -146,6 +148,9 @@ bad_cpu: > > not_multiboot: > > add $sym_offs(.Lbad_ldr_msg),%esi # Error message > > jmp .Lget_vtb > > +not_aligned: > > ... a .L prefix was added to this label, bringing it out of sync with the > earlier one, but in line with e.g. ... > > > + add $sym_offs(.Lbag_alg_msg),%esi # Error message > > + jmp .Lget_vtb > > .Lmb2_no_st: > > ... this one? I don't think the label is particularly useful to have in > the symbol table (nor are not_multiboot and likely a few others). Hm, right, yes, I don't think having those on the symbol table is helpful, please adjust. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed May 03 09:39:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 09:39:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529048.822976 (Exim 4.92) (envelope-from ) id 1pu8xI-0005dn-Fq; Wed, 03 May 2023 09:39:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529048.822976; Wed, 03 May 2023 09:39:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu8xI-0005dg-D3; Wed, 03 May 2023 09:39:24 +0000 Received: by outflank-mailman (input) for mailman id 529048; Wed, 03 May 2023 09:39:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu8xG-0005dW-Iu; Wed, 03 May 2023 09:39:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu8xG-0006Da-76; Wed, 03 May 2023 09:39:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu8xF-0000HF-N0; Wed, 03 May 2023 09:39:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pu8xF-0004aw-MX; Wed, 03 May 2023 09:39:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=lBL/1R6TBV3ZK3HEeR14Sq5JE1N++D0RdiQWO+Qq9+E=; b=64lzuoTngGVg+VEsgzvi3gkR3I PdFfhB7DOdGu4Fizhbty/nXOTHUAuq2xzkhgKJ7uSdKeGFGLIv9XW74OhgwK3XtO045zQlm6kA2QP k7Weax86/Jw4Gwwe7Ey/X8P3IILT1mM6KgUzYZveYN0VfjXlLxwOwMwDCJ89eAdoI0DQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180509: regressions - FAIL X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:guest-start/debian.repeat:fail:heisenbug linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-examine:reboot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=d7b3ffe2d7e476f11d73b74093006aa936f59e8b X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Wed, 03 May 2023 09:39:21 +0000 flight 180509 linux-linus real [real] flight 180515 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180509/ http://logs.test-lab.xenproject.org/osstest/logs/180515/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 180278 Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-qcow2 19 guest-start/debian.repeat fail pass in 180515-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 8 xen-boot fail like 180278 test-armhf-armhf-xl-arndale 8 xen-boot fail like 180278 test-armhf-armhf-xl-vhd 8 xen-boot fail like 180278 test-armhf-armhf-examine 8 reboot fail like 180278 test-armhf-armhf-libvirt-raw 8 xen-boot fail like 180278 test-armhf-armhf-xl-rtds 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180278 test-armhf-armhf-xl 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180278 test-armhf-armhf-xl-multivcpu 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail like 180278 test-armhf-armhf-xl-credit2 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux d7b3ffe2d7e476f11d73b74093006aa936f59e8b baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 16 days Failing since 180281 2023-04-17 06:24:36 Z 16 days 28 attempts Testing same since 180509 2023-05-02 18:14:04 Z 0 days 1 attempts ------------------------------------------------------------ 2179 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 264469 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 03 09:43:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 09:43:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529054.822986 (Exim 4.92) (envelope-from ) id 1pu91Y-00077b-5C; Wed, 03 May 2023 09:43:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529054.822986; Wed, 03 May 2023 09:43:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu91Y-00077U-2P; Wed, 03 May 2023 09:43:48 +0000 Received: by outflank-mailman (input) for mailman id 529054; Wed, 03 May 2023 09:43:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu91W-00077O-Kx for xen-devel@lists.xenproject.org; Wed, 03 May 2023 09:43:46 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on060c.outbound.protection.outlook.com [2a01:111:f400:fe1f::60c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ff163415-e996-11ed-b225-6b7b168915f2; Wed, 03 May 2023 11:43:45 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by VI1PR04MB7086.eurprd04.prod.outlook.com (2603:10a6:800:121::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.21; Wed, 3 May 2023 09:43:43 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 09:43:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff163415-e996-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nvlVrJCN1wpMUgj5RBZnno5n0WKap57OL1+JRDZ+F+g+KkFqqEPEh/ZJ+fYg8GTyCIw9EHZb83WR1IYoR6uWXPuj6xwsItRbGt4/wzYmDPn3EL+IUJy5eBWL75MDauAz4vBkBKsZkBB2ZBljNfWnKuGKloYUCqqR02mL9l/3zyX1Tsk5LWLZsO/NEGbnkEvs1ooRtbtlOXmKy3mr1lEqxF+lVFBsZRGdizqEGK1EmlEBcCdiOuhxoouVjYQQJXIFnTRlup8qFaz7zgd05vpIBveqO0A5QyhPXI5fp7ScdliD/mfYRxaQ8yPfMwlcFqc4/cWMJRerBYIdNJRexF8N1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4Qwx2nQ1Z3b4p2Wd1pGiSoSwuiZ9EYUJViH5NdLyHps=; b=dufUCTfLXKqyjgptp1iOZTWPPYfzECmxfAzmTaGlyrh9GW+LyK9LHiuJDJKUbLXWrQT+YoUWo/w8X2rt1+niE0uqFrdCK5ezlXpK0bdCT5gch9RBnJdANYvswpdW25uzhqDrB5y7I4g2ggkFzf8cZenUmfXjbL/bFB8/MxPMI6qtUi2sS3gAScs5UGP2EzocKHWn5m/TYyarPbN1AVL5NBSg081iiDCftz4L70rtZYYbQaS0uydZvEJaPpp4jh7To17opIurqh/VyJW0OhZF9z1wAykjbQIGoShZzMji6qPLk1butwNfcsHycZhOCyPzBfy38UcMpsfuYVwsmL93tQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4Qwx2nQ1Z3b4p2Wd1pGiSoSwuiZ9EYUJViH5NdLyHps=; b=b+aVJ4RrBo3Op8HqLlmoDkjfH42M2z4CenQFBy7kWX3+eUr+VytlS7FWC9ZB/ImqlU+YSUOkA4EXpn/wOcNCFMZ7xSJKbdN4pZc8S0kPqXUCeCNY17RXiHCKOcnTebOSP+SpevsU2+RG4mg+/NBYvId/w/iY3zdKHSG9mKDxgcjiqVd0N1ljd7LOzYF3Mcfc9Ito5PfIFwDhhFwDOlNAuypu04j8tMRL0b7R77005i8d6J566AhdqtGy0rP3zvI5+nl4f+7tAiZ13G4S9O8qm4OkUi5S0pqvovxpcqwWPcDYGaJwUBlKWeSJNrzCXT7TXAd9udnPLCxy4FHvgXhtwA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 3 May 2023 11:43:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 From: Jan Beulich Subject: [PATCH v2 0/6] x86: reduce cache flushing overhead To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0182.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::17) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|VI1PR04MB7086:EE_ X-MS-Office365-Filtering-Correlation-Id: 60341197-c4d2-4551-8528-08db4bbae23e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FkMeEnChH262wCFRe4r7jt69aNSmLpwDSoHKxhFiC/onfK87bxmIqT7atpT0wUkRNvMs8VM4dNL6WdP6o1PbUbkTgk1DXRqlvA4P3DOPluheeHAQr25MHlnlnZ/Nuh5nkVKLnTqhOTx4AAOPGZ5fegU2g+tyqif9Okv4+qnyzD/zij1kGhP3PQ++YiMca4cSNQiyWh/7L8Zgo8yYX5Rwd0dhQQH0Oxg1X8spohnI65+vf1KOP06uRuAaIslnhsXmjZ8dJDq/uLMpdsKya/iIBu5+RQyNwJ0VdVR0BrbcyTb2xL66XRE1ZuQKzUKLfXFv4+v6HAUeewjEqaBkSLeCEUYwa8+cp1m1G9kj8fJkCQY6Q1dhhMEzaD1A7/PxiJiiwBvwHIUnIBdIXTxo6TpQunrDyxRok5EnBjheyJFdD1rq5UEFgfEEJ5RjVM/XwBb+6iMNvJMY5Oqm6eny3WnYhHyMbO/lYiDwLW+/tYqGYk2wUI3V2GbfjhYEzjUfAkGx5hjnadinIFDdW5oDSY8PuIfKugRksjda8IXOICd/TVajvnbA++mG7shx4TrjU+PMWvzyMOlFijdJTjpyZgbVGHMY0hpc2lzdTjvq1bP2+TA0jwgmD3RvIoBPGTpYUdX2CW8tjz8OrmyeODZaEMwqug== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(39860400002)(366004)(376002)(136003)(346002)(451199021)(31686004)(36756003)(5660300002)(2906002)(38100700002)(31696002)(8676002)(316002)(86362001)(66476007)(66946007)(66556008)(41300700001)(8936002)(4326008)(83380400001)(54906003)(186003)(6512007)(26005)(6916009)(478600001)(6486002)(6506007)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VTd1Z3djQVV1L0VVWkhxdFNxNEZ5cm5GSXdmUWpxK0EzTjJDU3pUaU5palU4?= =?utf-8?B?WHdUVzRybzB4cjgyQlJTaE9sVTNuWXplYnBUSWRmMjFnenpJNHlUY0FNTVdH?= =?utf-8?B?S2t0Q0tiZ3h6bzgzam5yeFNZOTIyekR5TDlpQUVUV0U0N1F3dGlKVDc4dVJC?= =?utf-8?B?Q2dFcDBMTnF3TXQyM00xcllvY3MrYklEeXduZndIMm9JdVNRaWNZQ2dJcXUy?= =?utf-8?B?M21nckFhRGNreWlDS3BXR2g3VTl4ejRoSUVmaTRycVhKZVNEZlBkVVdYenpV?= =?utf-8?B?c0Nmd1U4cXI5TUNXZFhFMmMxU1RaOTZzVS9GeFpxV2cwazhRSmZTV3hEeCtY?= =?utf-8?B?V0N0MFc0WVpSb3F5d3J1VStwZ3RaVDhwVjkyU3J1MTN5WDBSU1VSUEVvQWFp?= =?utf-8?B?Z1pUbWlhbVBvUk5XOXQwR0hERkFpbEQ5eHdQaFVtRHZqdGlhRUZSSWVqcDJL?= =?utf-8?B?RHNoSkxyZndaWHhybEgyTG92RDBtWnpUUEZWMWY0WWxvMzlDOG50T3lVN0g0?= =?utf-8?B?ZkVGL1AzUERDRzZWektGMUZRS0ZCbGFCaDFaTitpQjNYWmk2KzdUSmxGYmxJ?= =?utf-8?B?N1FEWDJCV0NrM0Q4cG5lVHpicXMvazNINk1QdkxaaDJzVFB3RUJUNHJBRkFE?= =?utf-8?B?cFZodEgrSGhzVlE2N2JiYWtZUEVaczVoNEZYRk1uVHB3NmdZSzIzekd2cFBC?= =?utf-8?B?MHFtSUg4Y3JIYXJMNFFCc3FKNVBUa1NOZUlzRkVRMENrZ29uRjRvT0NjQW9o?= =?utf-8?B?a2FpZlpWbGhWYWJDd3RMUytRZkNRNHc0dVh3MFFvRjROaUdHUklLT0xmaUs3?= =?utf-8?B?WTZPNnNGRlA5T0w0V1FSMy96OGYwelZhbE9kc1puaHFzVG5uenN2UW42aUlQ?= =?utf-8?B?MGdSRkFQRGVuZlplZnYrbXZEeHJUMVE1M2NuZnRSRkRWaVI0eFpGUnlZbXFy?= =?utf-8?B?dXROb1hBSVFxaDNzQlNCem1wd3NwUW1vclJtSjhkMDlEY0VOL2cwUll6Z2do?= =?utf-8?B?OXZQS2c5MS9RVGRHbTFWVWtNSzVNUmJ4T3czTXZmRnpHTUF4TmdyR09TSjgr?= =?utf-8?B?WHFjajhBRmhucmxCcndmWUNCVVROTENqTGptMW5DZmxPaGYydzNDdUtBcjZl?= =?utf-8?B?cWRTbHdpb21vNDJkWFByMWxOZnJtMHRYVHhYSHRvMjFqWG41SVRONk0zTkZt?= =?utf-8?B?QXIxYWJmWTdLZm1Nb0tXYlB5Y0s0NkZEYXR5U3VCWVd5anIzcllNSUhtV2R4?= =?utf-8?B?dXVycmhsS1dhRlVyNnRoNHlnTDcxQi9ITzNzUWNubVI1Q2hIaTZ1REJtTGp6?= =?utf-8?B?b3FOZ3JtWVFaZEpsVjErc3A4SmUvVjhIUVNwY0VTL1IwWEJJb3pmM2JqUWYv?= =?utf-8?B?cTdqODloZjFwMlR2UnlCUkswdXAvVjFMaXJ1Rk5vVnBta0puZkFsR1hiZExP?= =?utf-8?B?cGdyYmwrK2V2Z0hpdEpKV3pXNlRIUndCR3EyTDR5a0JXejR4R3pqM0VSNTc4?= =?utf-8?B?R3phQ0JCMzFSckRVRHhGdjRDbEVvK0NqTHhoczBNZ2pWMUM3N2VWQXgyVkc1?= =?utf-8?B?SVNsQk1rWHRGYmhraFpTdTVTNGVMNGpkRWMwc2tNZmt1d1AzNGdnMytON0hI?= =?utf-8?B?dEE1VkV5N3NTK0pyWUpJdldKSXRHblNKeE9VdVlGUi9PMDBPUmRXdUM0S2l2?= =?utf-8?B?RzlsazUxNmRaRTFtT2lkTXNKWmx5QU1mWXM1VVFYOEVIYUlzV0M3S1BudkNv?= =?utf-8?B?d25pT1Q1UDJIdlhGaE9qUkd5dFpRa01YTmJoTDlKMTVoV3JVVEhja3pMVnhp?= =?utf-8?B?UFoyQUtXcnlTSEhrckQ4dk5EV05HV0hqQ3BKRGpRMWQ2YlNOVCtLTXltNmhH?= =?utf-8?B?WjBJMHVJdUViWGJPTmZBa1liVFlvY29va2dKZW1tdkIvaXhGK2svdkZaNHlI?= =?utf-8?B?NjBkNTJPUGlkMU02Y1ZyU2xkNmhOUFpXVkZFUHJSbS9hVDVmRjZlbnA0YUI4?= =?utf-8?B?VkNJT3daUzZDbWFJR3RFU0RWQnRpNUxyQmlaMUN1YkRodGVYNWRTYUtGZEFZ?= =?utf-8?B?RDNma2RKOFhFZFpPMW5la2MxeWZDc1VabXA1SVpCTTV1UjFhTHBJMU11NkRP?= =?utf-8?Q?dPYy31lpixX1oadyT/L5FK62K?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60341197-c4d2-4551-8528-08db4bbae23e X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 09:43:43.5911 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Hnc4CZffQ4vYpGE4NIt+OCnmRL+VctUOGgTtMB9dm3CXrOAjdlwUSSGzLa0wyEehkzPF2qg44ru23rCKGYYwYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7086 ..., first and foremost by using cache write-back operations instead of flushing (evicting) ones when available and sufficient for the purpose. In the context of making the last patch I started wondering whether for PV we don't flush (write back) too little for MMUEXT_FLUSH_CACHE: Just like for HVM, pCPU-s a vCPU has run on before could still hold data in their caches. (We clearly still flush / write back too much in MMUEXT_FLUSH_CACHE_GLOBAL even with this series in place.) We also can't call this the guest's responsibility, as it may not have any means to have one of its vCPU-s run on the intended pCPU. v2 is merely changing some names, compared to v1. Other discussion on feedback sadly looks to have stalled. 1: x86: support cache-writeback in flush_area_local() et al 2: x86/HVM: restrict guest-induced WBINVD to cache writeback 3: x86/PV: restrict guest-induced WBINVD (or alike) to cache writeback 4: VT-d: restrict iommu_flush_all() to cache writeback 5: x86: FLUSH_CACHE -> FLUSH_CACHE_EVICT 6: x86/HVM: limit cache writeback overhead Jan From xen-devel-bounces@lists.xenproject.org Wed May 03 09:44:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 09:44:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529056.822997 (Exim 4.92) (envelope-from ) id 1pu92S-0007ce-EK; Wed, 03 May 2023 09:44:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529056.822997; Wed, 03 May 2023 09:44:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu92S-0007cX-BG; Wed, 03 May 2023 09:44:44 +0000 Received: by outflank-mailman (input) for mailman id 529056; Wed, 03 May 2023 09:44:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu92Q-0007cL-VY for xen-devel@lists.xenproject.org; Wed, 03 May 2023 09:44:42 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on20627.outbound.protection.outlook.com [2a01:111:f400:fe16::627]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 20d896b0-e997-11ed-b225-6b7b168915f2; Wed, 03 May 2023 11:44:42 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by VI1PR04MB7086.eurprd04.prod.outlook.com (2603:10a6:800:121::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.21; Wed, 3 May 2023 09:44:40 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 09:44:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 20d896b0-e997-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nvlRo9gffZaOASpcLxLtB6sqsLqdsDbGzUGPPf3VBZ1Zi9glelxkR9Hf0+CQEZj1TYnvboQwjk3TJIxDuSCtUS6I1sWw75HzkajVwc34j9Eyl2WqfXjC0tyd5TfDXMjTpgpEqwsxsN7p71ZhZ7B5qnAke3g9koOO6MoJkFe0UcOl6VYQiukFMFJK9C9q8NmqNj2HadTmEMh96eWNhFQ7jibSwhE9prtSxsRI895dKtETfdnw3tGIAXNrYy3a1Sj1yf2NWcME7xzUIaSdFwzQUWRgvEY0kLsWcn72KAflvXh1bctnf15JrrKQUAOl7UhO7pkNWi+Z9j84W/GuxHFksw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uG2zYnfRmLb43OT9mdiD5lm/T/9r7Wlaz+YjVV6KHds=; b=BjZkalo36iwu8/QwTG0G1MjeJE6yJHJFk5fmd/6RHu2DrlsqKjH5LJWj4AhOV4VWv3x/8WNh+0PdUb4hBfqmdOiZ4AYjdk8Vj1r1anXMAX5ZAbroWc//TbJNgn25Z3ENIS1VGLaIprJXn8KywolSmvLyGnq+AJI2hRni05MH8/3Ob3ub+nkAK1puW4a42UspU6bgGBVaFXvs1kXgGdDRqn7gvh0UoO9IYgnZ9oXOzyAkwvjD3duWYBkrVV1TfzuCS9KVhqqqzBzPcxaHhV5V1F/6kjyUYkY5jyctio0kqu9+AdAMvcvPMuTmAVdiAb1WlihEIhOHUlYeieudGtsuXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uG2zYnfRmLb43OT9mdiD5lm/T/9r7Wlaz+YjVV6KHds=; b=I6EBmK5BzFg05tm4Le3m41t63GyqeAInXGTuf2aQf/7gKeVehD7mElMeE5B0s5x5HsGs27aIYf+w4+XXB0Rs4ZbhAknWLcenQwt1FgQtgLNzmI2Q81u7SUDNZ3CdyffSSHyHNARnB9ntTHmEfZn7ReGn8rFbwm0cfGk0+vIz+K4fut4yHNZk3ngtBom4s5KQVgFWBkj6LG6Fr7hekTcyC8Rl9NdaHkdzDbNgzEf15dUQrrYwuAWuLLJHOKBWegyDnHC643K31abqubZp0e3nHHyjS8EplO+ttQsJ/qde+yBF1H77SoVKXS5YEj5LQU+lUITywzd60nhL1JWxw9O5ow== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 3 May 2023 11:44:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: [PATCH v2 1/6] x86: support cache-writeback in flush_area_local() et al Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0182.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::17) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|VI1PR04MB7086:EE_ X-MS-Office365-Filtering-Correlation-Id: 8524c7b2-6117-4f39-caea-08db4bbb0445 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WwaZuD7vJLgsKWHayFHThjQ9LIhWqFoDzh4bQG2FlAaXxPpj3gLoFX2UZV0YJ7Ceb/b3VT3PYVTA9yrHABhXtfWodKBcPDVypkO+BakHm+BG1mgmD+rZ7tQAkQFbRsfAJhB+Ds9vc7OQ0Vadd+PGA+KzFUFqQro1qkTi7+LdpF5p7Qg0F7mZjvIYxMohHV3X5bT52Z6jew+usGCyerlBPQHFV0tnSF4qKejZFPHeq9JyEd9st/s0yixzolhvtXs8xrHogi4I63nhFhcYlArF9/iRDLkJS/Du8gJuRaJ/uySFQUWUHYox7phTSZOnhypyonyt0ItYUEnsufxTZpdE0RI0vsLu82pE/DI1JGjBdIPUnhUbhLrn9ql0iFgIzWIJnNtWmvwpq7HNyTWeNEcJ3mWMGJx7AUFTpmDMZThiechytmC8/5+eDd8or4hGI+Iy7RnO05CU8tJrNxySjHZy/9XuNdPmVQHHYALEAbCcGYKfjKkcKHuFtpmznNkJkSI4iNFnv2OT3/UXCdJ56b4a/PoheVEwkRvcfFJLXGzmEzspOVqqf034pRH8W4oRIRaOc07B0Ha9kwjQA+3NmVgSC30Vvh3bb/WASAUaL0H6ynCZmp5fCYhCMqJE1WlOJQhGip8YfFEXJTgSyYb4s+rsaA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(39860400002)(366004)(376002)(136003)(346002)(451199021)(31686004)(36756003)(5660300002)(2906002)(38100700002)(31696002)(8676002)(316002)(86362001)(66476007)(66946007)(66556008)(41300700001)(8936002)(4326008)(83380400001)(54906003)(186003)(6512007)(26005)(6916009)(478600001)(6486002)(6506007)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WFJWRlBzdWRVYzFrOE5XRWlDNUp0Zk92VlJDM0ZHY0NpVmNReVAxMzg3QVRH?= =?utf-8?B?ckVXYU1HYmtvQ0UrUnk5VndFMkI2Z2pSczZQUzJjVHJERFBWZERWeGxiRnVM?= =?utf-8?B?NjJlWVlWbE9mRjJGajd2eFdQa0NCT3ZsQVRyY04vSEQycFBLWkJqZHRNTlly?= =?utf-8?B?M2M4ZUwzTkh3VjgyN3F4VFV4TzdhblpyK3VCUWQvMlpZZEtkdkMyblh2b09s?= =?utf-8?B?cHExU1oxeHZrdGl4bVBoWVpJaHNPblpmbjhPZnI0WjhuekZvdmd2Y0R6anBr?= =?utf-8?B?d1pYRzk3L3BzdzFmdDFpVzRYemFTMzVnNGJQSUtacW82dlV5bVI3ekNjOVc3?= =?utf-8?B?YTdzcWNoaHdrd2F4TUh0ZmhKMG94Qy9wRCtYemFQQmkyeUtyRFdEMVZESk5K?= =?utf-8?B?TC9lcjU5Qmd2cFJscXRMUzJFdks1UFBrcVplNFJtTnZKN2hvTUZyK0Q5MnVP?= =?utf-8?B?M2l2Zi9Gd2JuaHFWenZEeTBPRlNmbmpMeEFkei9Qc0w0VGNaWGRrMUNoTHdZ?= =?utf-8?B?OW84NU9mQnNySlREL2xSVmpvQXZsbmtnK2Mxc2xtNVBFUXRyaGJkTHpDekdr?= =?utf-8?B?cWhRZUhueHAzWjRFd0dxQkFkdVl5emgrY0RYL284VjI4ekVHdnZocXZENUhJ?= =?utf-8?B?dlEwV0hGZ1IxdDlPNmU1dkFFWFMvK0EyYUFSaGttTGljZmpqZVpnZWdJdjZ0?= =?utf-8?B?dDF3MDJFZC95eWg1bzR4V3JZaUQxWitxUittWUg0MjRWbVZCR0tzazlDQzNB?= =?utf-8?B?YmpLSU9RUkJiVzBCWmgrbEVLY2h3dXEyb1pmcUM4eFg4Y0YrNjZlc2xTdUpR?= =?utf-8?B?ZTJodTFPb0prb2hIYUdubkRiT1ZSMTUrdHpnMTZDZk1CelpIOEVTSFNxTUdI?= =?utf-8?B?cE15L0hMOG4reklLSkM3dmpjWXVKeVdMK3pHRUd6L2tpOGc1SFB1OGVkaCt5?= =?utf-8?B?MDZneGJqMG5kUlQxN1FraGZ5TzU4TGgxdGVqTkY0Ni9BWmhSa2kyUkdUOVU0?= =?utf-8?B?ZFhDYmJKOUhFd0dPdHU0dVEySEFjSU92am1GNGk3VHVQTFNpQmN5Y0t3eGcv?= =?utf-8?B?QUJ5eTVvRS9jZU1SZllYaDVGZEJydUZweTN4bjkxWUJ2dmdkcHM0MjRPQUZP?= =?utf-8?B?a3puaEFabFhDa1F5MmI5T3NONmdBU3U4VHIvbzJCU3FJNitwMGlmOU90T1Ew?= =?utf-8?B?ekVia0paeXRXTFFreElrd1U5cDVNMHZsQXlWcUZXTGRUbmU2c0Z4STBtSjMr?= =?utf-8?B?OEpMZ2Y4Qi9rZkk5b2V6THZFQTVIS09wY2VHYnBuL01vbi93SHY2bXBscmlH?= =?utf-8?B?bm9lMHBFUEFuSlVDU2JyUlJRdThCVFczUkNtbVU3c1ZnWlU2QlhlZ0pFK0ph?= =?utf-8?B?U1piZEViQnRtM1BsRHJQaXNhUGxBL0c0dW9EZFNVWlVjb1VhY3gxSFd6RFJ5?= =?utf-8?B?R3FuZzhXbXJkK2llMHhYMEpqaDhLa1R0bXR6ekdOaVpERjZpM3RFUFB2QVNw?= =?utf-8?B?c0JpUTlhS3Z6bzBGT1prRzhjZXVqYXZaNS9HUHh6dk9wUjFwa1hCalRLR0Fv?= =?utf-8?B?OERtS2tHOTF0ZmwvU0lvTUREQmpBVkRndE8rMHk5Q3JQbWZUdkJjQ21aYWEz?= =?utf-8?B?MUhkY3J2S1RscVMvZGcvbmlESzdsRy84OEVWUUMvLzVJM1IyTUNGTFdsMmtO?= =?utf-8?B?VFRjMGtUc2NHTXJxTlZDSXVPK0JGNkhKaXRTa2pqTExMVmlVb3NMRzhsd0wv?= =?utf-8?B?cTZPQlRzUnp1TXUvTGM4all4aVEyZVY1LzBmSWpZZi9mKytSaXVYNDI2THI5?= =?utf-8?B?aEZTckVxZVp2ellzMlg2RGlRRXY0TmdtTDZ2YlpEejl0MC9TMGR2ZUFrTzI5?= =?utf-8?B?RHl3K1pwdmdiU0dldFc2TS92MC9ON29pOXhZbmhHbU9BWUw4cWxqc0ZRUTRz?= =?utf-8?B?RitwdlM5TFRzK1pLb2pZU21EcEVIUzNhVEQzV3dMTmY0cWVoTGptQjkyK0Vw?= =?utf-8?B?RGRBdGp2TW5PMGc1dW4xTmozRldUZVBkZTA1Tm1GdmFHT3lwZlZLc1M0MktN?= =?utf-8?B?RWxmTjFnUmVydVhwMFptKzlHSkdMZEhFT3V1eFZqZDJEMTFSZllqc3pucDNm?= =?utf-8?Q?s2AIRFmnOe2ypOBYDwOvg2X/u?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8524c7b2-6117-4f39-caea-08db4bbb0445 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 09:44:40.6861 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QZ2rxB6r1k1fURd8zcHoxXn0iyi9GaEvBtbH2jri/gUD5oOfPxd0fpTJws8tlcn01FJhd/+r/veyNTp1yBu3Yg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7086 The majority of the present callers really aren't after invalidating cache contents, but only after writeback. Make this available by simply extending the FLUSH_CACHE handling accordingly. No feature checks are required here: cache_writeback() falls back to cache_flush() as necessary, while WBNOINVD degenerates to WBINVD on older hardware. Signed-off-by: Jan Beulich --- v2: FLUSH_WRITEBACK -> FLUSH_CACHE_WRITEBACK. --- a/xen/arch/x86/flushtlb.c +++ b/xen/arch/x86/flushtlb.c @@ -232,7 +232,7 @@ unsigned int flush_area_local(const void if ( flags & FLUSH_HVM_ASID_CORE ) hvm_flush_guest_tlbs(); - if ( flags & FLUSH_CACHE ) + if ( flags & (FLUSH_CACHE | FLUSH_CACHE_WRITEBACK) ) { const struct cpuinfo_x86 *c = ¤t_cpu_data; unsigned long sz = 0; @@ -245,13 +245,16 @@ unsigned int flush_area_local(const void c->x86_clflush_size && c->x86_cache_size && sz && ((sz >> 10) < c->x86_cache_size) ) { - cache_flush(va, sz); - flags &= ~FLUSH_CACHE; + if ( flags & FLUSH_CACHE ) + cache_flush(va, sz); + else + cache_writeback(va, sz); + flags &= ~(FLUSH_CACHE | FLUSH_CACHE_WRITEBACK); } - else - { + else if ( flags & FLUSH_CACHE ) wbinvd(); - } + else + wbnoinvd(); } if ( flags & FLUSH_ROOT_PGTBL ) --- a/xen/arch/x86/include/asm/flushtlb.h +++ b/xen/arch/x86/include/asm/flushtlb.h @@ -135,6 +135,8 @@ void switch_cr3_cr4(unsigned long cr3, u #else # define FLUSH_NO_ASSIST 0 #endif + /* Write back data cache contents */ +#define FLUSH_CACHE_WRITEBACK 0x10000 /* Flush local TLBs/caches. */ unsigned int flush_area_local(const void *va, unsigned int flags); @@ -194,7 +196,11 @@ static inline int clean_and_invalidate_d } static inline int clean_dcache_va_range(const void *p, unsigned long size) { - return clean_and_invalidate_dcache_va_range(p, size); + unsigned int order = get_order_from_bytes(size); + + /* sub-page granularity support needs to be added if necessary */ + flush_area_local(p, FLUSH_CACHE_WRITEBACK | FLUSH_ORDER(order)); + return 0; } unsigned int guest_flush_tlb_flags(const struct domain *d); From xen-devel-bounces@lists.xenproject.org Wed May 03 09:45:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 09:45:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529058.823007 (Exim 4.92) (envelope-from ) id 1pu939-0008AE-PE; Wed, 03 May 2023 09:45:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529058.823007; Wed, 03 May 2023 09:45:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu939-0008A7-L3; Wed, 03 May 2023 09:45:27 +0000 Received: by outflank-mailman (input) for mailman id 529058; Wed, 03 May 2023 09:45:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu938-00089y-Kw for xen-devel@lists.xenproject.org; Wed, 03 May 2023 09:45:26 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on20608.outbound.protection.outlook.com [2a01:111:f400:fe16::608]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3adfdd92-e997-11ed-b225-6b7b168915f2; Wed, 03 May 2023 11:45:25 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by VI1PR04MB7086.eurprd04.prod.outlook.com (2603:10a6:800:121::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.21; Wed, 3 May 2023 09:45:24 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 09:45:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3adfdd92-e997-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VGtyGOsO7zERtWbhfcjaOWGePa40SgKqvrcfepqF2fArWmil5qv4VIvrXkSGMca/IGS8/eyDw1VpIhSYiOTjg/eRJdNBDsyYhF3uYx9WEATvW1BFkuFeFqg7+2c+FWKdhFh5KaDdRgl9GKA3Q2kewwjxoCaHiGnNLdiU0hNASgfScggtt8t+9AOFVWxqTXS6cFfCRkZE5z9Ox9RJZYtW9XdeG0+vOaPSptP1lYV4V0kwCdY5N9fYgAbKMcQw9W8mSqGHhTaU4WlT0yamXyDqtmQw0hBdOgte5NJNxmwJkSxOxqpvvQKODrFwYMEi7HO8jJMXNq4KzBrdtRhDM3Qkgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zX9q4vPbP6ZoAmb7n1j4z3y9de90GGwg4j8OmjDy0DU=; b=eDnvx2/8VO+DaLCVpFsqNOU5ScZZ+2au3awGE2RNnzrxAm9cGATuI9WymdbXehLcYEd7w+Q9F70ZG8WNLGlzBWBalAB2lTDqupEhzabKLCFr+hlUGZD1xVj51ab25pfBGDwfIzFfYkhyMw3UfTDtYSBJKXKILiekQT+5/B4RsHcluqUecP+jM/QUHQynLBliYEL8RCnVmldl64sblV+FqTQEYWp6VeJvH7DvEz9JDKBa/zxux8K5HlTCscuhGjrc04jWliwVYCPz2Qpe8WupwPCoO6TIJhegpdruuqHIeUX3dGfVNSUi8pYSIOcXKi0Pex7L3vHA0InxLko98wvOog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zX9q4vPbP6ZoAmb7n1j4z3y9de90GGwg4j8OmjDy0DU=; b=GenVxBVomwXnuwavtyG0H/gbr6cPoySUXFaIK+rS5sejKNgT5Hvawu+6aoHK8C5JV6bn7kdFyuys+tt2ds1q07OTUD3NIqrw1bsPIO0IaJw+DzsTJSBaQWU73GgDp56Pu1Tcjuhb2cGHFL4MGWcZp/utHirWVNLc6DkFCuYCR0j82S46gHFQBCXcubS8xTM7NXwLfCRfWPyZh7wEHxBabgMCLkFOu+j9LHZwm9P2fVbO7V8tEmXBCKmdrfH4a26BJJI4NohLEkqHt+Skk4IAgc5e10yZtmqSdBlOSN/j3DS+CYo0rVmWhRowq4+ZxeYhd+W16lvmld5ZU7IDQfINjw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 3 May 2023 11:45:22 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: [PATCH v2 2/6] x86/HVM: restrict guest-induced WBINVD to cache writeback Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Kevin Tian , Jun Nakajima References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0090.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::6) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|VI1PR04MB7086:EE_ X-MS-Office365-Filtering-Correlation-Id: d0a95501-d4d9-423a-b453-08db4bbb1e75 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pVu+Re5JO518uDmDhT6tkkfRyCRtvjUc1uHnT30Gfc8oPwLSsfckovHlIhCKdkryMdyP9+RELS4e2MhcVugtQvBXeCfHeVepuIQzS+XG2duFgeGA9EWLzXLJriR0E+tMpqeya8Kjkdb7BUB9T2wk+sOBx5PT9y7P5JBtmSX1/9JS90qNtzWF8Pq4JC+SxhOiaT3Ui6Ng3BhTSQIDzLyINHsFG1+b7+lDhzafnzsIWO97UfsyET0HIFDKplPHdTeB5aQ8bzd73B0D/+kh033HNiORKeF5oKeZp/xTFHr2k5/lSy88IcQb1AoQgcau7kn9P+nmwo2rU43pToiW6Dty7Mu5BZComGSHTOcXG7MClOsPwYQnv7dcS/mVly7QjZARM3KY0flUQSyOze5Ty4KbBgmpGwm9mdB7ae16NVuulaKJkOgAivNqrTxFPLC7ipZ4Tq3TacVeT+L3vAK9n2CGz/fT0LnhPba4QXuIAr77CRzsyWOXLhBdtqAr/N7Nr7BnwbzXyi+ikddaqc3WIYsKNj/nveeSOV0WiiyVuDsI6elT0s+lwKpqNR3n30Kpjr0o1AXeOPCMKG5XVUDwDSoczr99CmDXyX3+dnL2XhhQObixXjnZHKFHC8ME3dN8JXM2iqeaagXCEudXHmkEiaqpZA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(39860400002)(366004)(376002)(136003)(346002)(451199021)(31686004)(36756003)(5660300002)(2906002)(38100700002)(31696002)(8676002)(316002)(86362001)(66476007)(66946007)(66556008)(41300700001)(8936002)(4326008)(83380400001)(54906003)(186003)(6512007)(26005)(6916009)(478600001)(6486002)(6506007)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z0NpK1JRb2MwTUFyYkpPRjBmaFUvajh3b0tCQkFmMTFuZGl3UWRCcTF3UENV?= =?utf-8?B?YU5JNVFKQ25vS3JRRDFQZjZZR1RQa0l5eG1QSlV6N3ZkMEpZVU03QU5mSlcz?= =?utf-8?B?M3BLME90alpRaVI2QzlzQkN2OGlSU1MrZUszMG1RMmFhS09BV2VtMVlTNCth?= =?utf-8?B?Wm8weFF4UVV2cU1ScVRvYU9kakU0ZmQ3VSs2UThORDdZVkpXQXBOdnEwRnJp?= =?utf-8?B?dGR1L3JJZURrYlBTZFR5akcwM2V5Q0VPckh4OEJzcnU2ZHFXVUpVaW1VNEdn?= =?utf-8?B?enIyV3Rrb3NXWkZrdkJCSHNMQW0yWmVyTE1qUU1vK3FLdjhmVG9URXRDaFFn?= =?utf-8?B?Wklvam5zdU1seHMwblRRWUtrM09WMkhUWVJUQmdNUThnM2tKT0dVeUVSVGRS?= =?utf-8?B?c1k5ZlpyMzNPWWN4UXRqRmcwOWd4MkVtelBtNWNIK1F3bTg2SXRSM3lXS3BE?= =?utf-8?B?TXE4VVlyOExPRUN4L1N6cVRqTWFUejVoWjQvcFJXcHBpSjFtanZlVkFyaWc4?= =?utf-8?B?RTc0TUdtd25jMG1HTDFId3hQRVkxdkVJcnJZb0hTWC9KQkUrMFNURmVQS2pZ?= =?utf-8?B?RkRISENxZGRjbmVMSklNdnUzaW9WUEtEV3dZZktSSEZpV2pYUFhNaVUxd2tt?= =?utf-8?B?MEt2WCttb1lQR1ptRUsxTGYyWXo1NTR4eE5PMzl3WXdQTFZuME5Icm9OeXFL?= =?utf-8?B?VVBPRUR2T0pkeTFHWmNpYjJEdzlOaDgwODIxNnVDMWtReGJHL096TGdjZ1Jj?= =?utf-8?B?bjAyOE53Zk94TWdTbUZXdlRweGVySXc0YVVNVlNIVy90Z3JVWm9vaThMamtu?= =?utf-8?B?NVBnUW54b0txbkJxWjEvK0ppRmovNDREY3JCQzQ1SWM1MmtLYy9lSkFSYmw1?= =?utf-8?B?dE1zTHk2RjdkUGFOS1h6b2lGRVFYYVZGUFoxalE1VVgrREc0aStVbzlqbHph?= =?utf-8?B?OUFGbVBPMHhPYnpkeFYzSkFRN1pSQ3ZzSWhZV2VFR2o0aFRDUHVaMVcrM1Ju?= =?utf-8?B?SGlaaS9QbEU0MWJlUElSeTdxZDdwYzdwWFI1REZsT1F0UFNlNjNJSDhtbkEw?= =?utf-8?B?cXRrVTh3WitXMVd0QUV1N043OHBIRFc2VVQ4Nzg1NGorenFDZG1JQjRtYk5N?= =?utf-8?B?aXVzWGJKV2J6anRKLzhWQmpRMkNkY2h6UVdKYVZKTS94NlVhYy9zT1lMcXEv?= =?utf-8?B?Wm0vdllGNVJHVDVXQVVKbWJLbjd2YWtUbXh3VTFrT0FYTkg3SE0rZ3h5YXR4?= =?utf-8?B?Q09SQWhMZjVvSXJiR0R0eTJYei92N1kwTUdNazFRcGlvS1NRZmdVbVBMZ0lr?= =?utf-8?B?UEI1NDl5bjhGbWp0VHVZT25RNlZPRnZHOFh4MHFkTk1CRk1HZjkwVjdqNnlM?= =?utf-8?B?dGlwSkpwSGxGWGxtcnpYcCsxUkJQL09KQkVxcGlOVEdPWEg0aEhpb3FDQTJo?= =?utf-8?B?Ymh6eWtvOUVnaitOenhQS0pCa2Iyd3VOdDlRNnJaTml5OGh3dnFqQUFtdVRy?= =?utf-8?B?OFY5Z0FSMS9VeVpDZkR4TWZRWHZ3by9nNWZtQVBMZ25KM01ReTJseVlxcG1V?= =?utf-8?B?N3ZHVTFkckRUdjJ3T3I0TEZWdmtWMWFpM01aK204UEgxY1lKYjg5eFR5SWxx?= =?utf-8?B?cDFiZVhpcWdyc2lUSlBaNS8rVy9rQklweEJQeXRKOFJEZVBoRjZvK25naHU2?= =?utf-8?B?QlNYbld0YitWMEVrZkcrOWZQOHVrcnhwRHZ0T1Y4em0xRys2Z0diZGY3R1cz?= =?utf-8?B?c2wxZi9rRGI1RnBIUEpLZkhXdVdtdEpKdGoxTGh0SDNVeDRqTUR3ZjVzWjEx?= =?utf-8?B?R3VhK2czTzNGVkY2elFDWHh4czVHNHVDV2pUckNtc0N3NlBXdXZoRkp0cENl?= =?utf-8?B?MjV4Y0RmNDluck9MVWdldmtraExkZ25qSEZrU25OeDE4WmNHUjJSSDB3OUpx?= =?utf-8?B?RGNrSzl3dzV5OHVYM1lKUkJtWGUrT0lJdUZmeEMwSmtiOG53ZFJET1E0Wm9W?= =?utf-8?B?Vmgyd2pDVkNNUkVLUGZaSDB0aWlDdGF4dkFOQmpKemxaa2ZSWjhGQ203T3F3?= =?utf-8?B?SzdhNmpJYWxWS21hVGtmZFlJTHBxT05QbWkwaDNaNGlxT0dBT0tMZ1ZFZFlN?= =?utf-8?Q?7oQxkoMiIkilqkYfjhd7cJcVe?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0a95501-d4d9-423a-b453-08db4bbb1e75 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 09:45:24.6381 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XjPGC+mrbEbWB9KG0+jRskqWVRrRhdkXsYYzGAwLXeu5NWzhJxRzGugBXDJIcKxHzYtyvK6QIpz/opdlekX+bA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7086 We allow its use for writeback purposes only anyway, so let's also carry these out that way on capable hardware. With it now known that WBNOINVD uses the same VM exit code as WBINVD for both SVM and VT-x, we can now also expose the feature that way without further distinguishing the specific cases of those VM exits. Note that on SVM this builds upon INSTR_WBINVD also covering WBNOINVD, as the decoder won't set prefix related bits for this encoding in the resulting canonicalized opcode. Signed-off-by: Jan Beulich --- v2: FLUSH_WRITEBACK -> FLUSH_CACHE_WRITEBACK. --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -2364,7 +2364,7 @@ static void svm_vmexit_mce_intercept( static void cf_check svm_wbinvd_intercept(void) { if ( cache_flush_permitted(current->domain) ) - flush_all(FLUSH_CACHE); + flush_all(FLUSH_CACHE_WRITEBACK); } static void svm_vmexit_do_invalidate_cache(struct cpu_user_regs *regs, --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -1881,12 +1881,12 @@ void cf_check vmx_do_resume(void) { /* * For pass-through domain, guest PCI-E device driver may leverage the - * "Non-Snoop" I/O, and explicitly WBINVD or CLFLUSH to a RAM space. - * Since migration may occur before WBINVD or CLFLUSH, we need to - * maintain data consistency either by: - * 1: flushing cache (wbinvd) when the guest is scheduled out if + * "Non-Snoop" I/O, and explicitly WB{NO,}INVD or CL{WB,FLUSH} RAM space. + * Since migration may occur before WB{NO,}INVD or CL{WB,FLUSH}, we need + * to maintain data consistency either by: + * 1: flushing cache (wbnoinvd) when the guest is scheduled out if * there is no wbinvd exit, or - * 2: execute wbinvd on all dirty pCPUs when guest wbinvd exits. + * 2: execute wbnoinvd on all dirty pCPUs when guest wbinvd exits. * If VT-d engine can force snooping, we don't need to do these. */ if ( has_arch_pdevs(v->domain) && !iommu_snoop @@ -1894,7 +1894,7 @@ void cf_check vmx_do_resume(void) { int cpu = v->arch.hvm.vmx.active_cpu; if ( cpu != -1 ) - flush_mask(cpumask_of(cpu), FLUSH_CACHE); + flush_mask(cpumask_of(cpu), FLUSH_CACHE_WRITEBACK); } vmx_clear_vmcs(v); --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -3714,9 +3714,9 @@ static void cf_check vmx_wbinvd_intercep return; if ( cpu_has_wbinvd_exiting ) - flush_all(FLUSH_CACHE); + flush_all(FLUSH_CACHE_WRITEBACK); else - wbinvd(); + wbnoinvd(); } static void ept_handle_violation(ept_qual_t q, paddr_t gpa) --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -238,7 +238,7 @@ XEN_CPUFEATURE(EFRO, 7*32+10) / /* AMD-defined CPU features, CPUID level 0x80000008.ebx, word 8 */ XEN_CPUFEATURE(CLZERO, 8*32+ 0) /*A CLZERO instruction */ XEN_CPUFEATURE(RSTR_FP_ERR_PTRS, 8*32+ 2) /*A (F)X{SAVE,RSTOR} always saves/restores FPU Error pointers */ -XEN_CPUFEATURE(WBNOINVD, 8*32+ 9) /* WBNOINVD instruction */ +XEN_CPUFEATURE(WBNOINVD, 8*32+ 9) /*S WBNOINVD instruction */ XEN_CPUFEATURE(IBPB, 8*32+12) /*A IBPB support only (no IBRS, used by AMD) */ XEN_CPUFEATURE(IBRS, 8*32+14) /*S MSR_SPEC_CTRL.IBRS */ XEN_CPUFEATURE(AMD_STIBP, 8*32+15) /*S MSR_SPEC_CTRL.STIBP */ From xen-devel-bounces@lists.xenproject.org Wed May 03 09:46:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 09:46:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529061.823017 (Exim 4.92) (envelope-from ) id 1pu943-0000Nu-63; Wed, 03 May 2023 09:46:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529061.823017; Wed, 03 May 2023 09:46:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu943-0000Nn-3F; Wed, 03 May 2023 09:46:23 +0000 Received: by outflank-mailman (input) for mailman id 529061; Wed, 03 May 2023 09:46:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu941-0000NW-Hl for xen-devel@lists.xenproject.org; Wed, 03 May 2023 09:46:21 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2052.outbound.protection.outlook.com [40.107.7.52]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5a6b7481-e997-11ed-8611-37d641c3527e; Wed, 03 May 2023 11:46:18 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DBBPR04MB7980.eurprd04.prod.outlook.com (2603:10a6:10:1f0::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Wed, 3 May 2023 09:45:49 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 09:45:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a6b7481-e997-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J4Ti2FyuNUFQo5B8p5+8s/4oJXDMxJr4KKeZe8p8wtr3e1k4W5eDwmb7tNGjKTiFZ8R/2fkCzoQvb6S4L99qPz2G34yxw8XbbZVeemMv81G3lhYCOHzpHw4I65ar99LXv10pzDykBzWDVazamiMiMmx9HfjndxVUJCgLzcbh/iKhqWcjIFPjzSsZHoI4EDdp4hGtkCI+hVrpMjP7b9moBgopZCanlq8r7+I7yKd5e6rTaE5py+ai2W+PWhln8wHBC1UuDxiGc6yU8NhPug96hjWXoHXzDDhvwxs3R8ICcyJBxNJvLh8YquXWKaSBk9wUBJV0V45n20+K72K9bOE8TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6s2ziFxyLLrxphcX9bcoXKx8fmbmlbg2IZSNSJNSJw4=; b=FMTOR7WhKDNt4LkIe9tfRUyAZ9nEOLx/by1cEAo2LlyZ5ifueXwpA/HV+aR6OoIW5CEkERNlu5TVRQn83k+D1B7mSuZurzkjyBo3tRgz1cuGopmXbf9lJ2Od1QcEIIdUxtJV430GitjlOt18S11dJA7r3u47WGDksihXrkR5QBWahZ0uAlSJnIa6Xtis2qJDSeOByAUFV8lTHfpNAhOEvaD4X5r+3GqSKbNf6Fn+6FJc1VvkRJ9KVQyO1vkIopyMzcWKR8owXyByqrCRNhi4rGAXqta5RjNKyk1U5z599nJ0K/81KV0vWi0VKomsTIC40pmDsKXZ21YC01BXucjgbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6s2ziFxyLLrxphcX9bcoXKx8fmbmlbg2IZSNSJNSJw4=; b=ktwluAyIBMs75Hpu+3Nb54GPGgIiTdVoBjUA0PphmB0CUjFKOJ8yTC02HwGmI3PjNOqanvVR2B9VgCMxN2ckOEbsiNRTmPAkaihvZHoZMNe7w1VphDaNqHRLL4s8vGVMxMIC3OagahJ7OsCA15OpgCdr8ULVu/T9cMFuKLZX3RgR0yGdfc3QKa01jjk7kDS0vgr72tEk6VAmkSC/EMof96tEsQkMrOhuOhMSb9QEqEUNeS3zYVA+6qNHQ7culh1Ob5q0pNPAXqCJxKnj1+GlYKYmJTLzXnehamKrXeAD7aLU6HdAKskqtWor14jog8a7YX0T+dy3sEU2gHpwcCLFKA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9dc789fe-6c03-165d-c361-6aaa4ba09763@suse.com> Date: Wed, 3 May 2023 11:45:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: [PATCH v2 3/6] x86/PV: restrict guest-induced WBINVD (or alike) to cache writeback Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0040.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:92::7) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|DBBPR04MB7980:EE_ X-MS-Office365-Filtering-Correlation-Id: d6d72f2c-df64-4a34-50b1-08db4bbb2d63 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zfJSpX52zNoSJgSDqDh8oLyEvYsXe+x+6prtXbYx8ALGbJb96oKPqeyHF5F+meIC3b8O4RI4gNZhxPNXdDWBxyUElvQ9I/Lhv3I60Rwue4pRhfItPmrpK//PLjdVH5960/t612XGZePRHIKawThacTL0cka/7GjDCrvOhHBzgrcnBH98DzrcVP3cGCgtVAvNgOXZiBK8VsoGGrjazOguvxYU9wubhbZSRfC1rRyoTMOviOPKCE5Q7PSjhsXEleE5FuRysMF/XhmUn/KVFwNtMAlJea0hysPzlCKBQxdWY+tPuLFuwfy//EPhlMI5KkAGgf/ElUFbjnA9Mg1qGerYDU0EF8Av4SZzw/E8xq43HcOUZj/z0WlG1RpR8+zbY7pYO7vd3jYhbZ0aHblAVXPWmjBmn+v3kUZp/DckA8afR2Q+EeeSlDEzdPISB45X2c/IyhpzI2LvgCLRjMrwrqhVqPaC7g9z9S8dug8PyLISR169G6OSqN5LLy4DjrNSQuHQVz3XHTCgH/cIpxfLtyqPy7y4A8smtbRou9uLySp9suCu7YnlBkGrU8wWv8ye05NgDp4g7MSKDml3yZtKy1L7IoxnZwyxy+KLh42yDMebpWkBqhvp3SNU7Oeo9R7pB15Z260MTz6CSIrdpw7akGxAsg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(136003)(346002)(376002)(366004)(396003)(451199021)(6506007)(26005)(6512007)(186003)(31686004)(2616005)(2906002)(5660300002)(83380400001)(8936002)(8676002)(6486002)(41300700001)(36756003)(478600001)(54906003)(38100700002)(66476007)(66556008)(316002)(31696002)(66946007)(6916009)(4326008)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VU5kWGhqKzNkK29WdFVEb25pdG5Rc2JKL0xvL0UvTXc1V3FrdllDaElBQ2Ft?= =?utf-8?B?SHc1NGFwdFNEdGxoNForSFRTUllieVhERG82aFE0RlZXTnU5NUJVaklZK1RE?= =?utf-8?B?UnJPTno4NDhyR0RId3BaVk1KdXVFODZuUk1PdzFvcHBwUXFveTdtMlFqVUVs?= =?utf-8?B?bk9yYnNxZkc4b3RUMVJrK1RQSFFScUhTVDFzVmtWbVoyLzBiZW9FWlVTZlQw?= =?utf-8?B?d1FLNGhlK0F5cDdDM2RSVE5wM1MvTVVHSlBDcHJma1B1eHl3RXlNeTRZSW5L?= =?utf-8?B?Qi90bFpQaVpNaXFoVllPNStMeDVzNEdwMVVYYkJJMGtQcUFVMTJuZzFzSVk4?= =?utf-8?B?UFJMRWQyRTdHSFFiT2VjdFVBUWU1VXh4Z3JGUkFjdjdiM24rQUljSWhtNDdD?= =?utf-8?B?THJoNkRublZpdlRmdCtkTEw0RVd5WFN1NWVvb2JhLy8rVmFTdllObDQxR2hM?= =?utf-8?B?SThmK1YzU3U4cWRYRlhIQUpYOC9UN2RvMHBGM0t6Y2lGVVFyYlpyU0hkbTB4?= =?utf-8?B?NkNUcHhKZmhBMFhOWkNBOTM0ZHR0ZFRlc2NXOEMyNm41THl5dlZVVVBHTFBi?= =?utf-8?B?SHdHZkVML3pSVjA1b3htN3kxeUMvcWVwZHhQeGpoSSt4UUpUTWhhaWprWlk3?= =?utf-8?B?MTRySGFvVWUrMlBJaXBmb3lpdHI4cXkzTC9WNVJmWmtIUUMvQ0dJK1JISURQ?= =?utf-8?B?TEI1TlJ1M0svV01HTE5mc2NtYWlYUnZHRGkwNWNyUmZ1RE5McDNwZFdYdThE?= =?utf-8?B?Y0NpTlE5THprSGtWMGg4Qjlaa1BZVjY5WmV2WVFqT0dJWlQxb016NkpFTld0?= =?utf-8?B?RGdYK3ZaU1BIcmpVZ0tpODkrOGMyNFZ6TzMvdVdvbE9kRjhVNitPZDdVNUtP?= =?utf-8?B?c2o4QXlzNDdpR1krRU9tZHVLbEh3N25saXRMbldaVDk3RkRkU25vVGN0TElp?= =?utf-8?B?WXkzR1J2UE9Qd1VDdWlUdWt6L3czQ2dSZnVNVTNLRjZVLzJQRXN3emljQ2pZ?= =?utf-8?B?Ui9sVStwZXZYSlduVmhaWHAyTGVDamp2dUxSS2poYStidGMvQkZSbFhuVTVv?= =?utf-8?B?c3M1L0dDODlwcmh5ZzgxUU9IMEVTN09aZlI3Y3FJYUtCS1NNV05ZRFlEb1Mv?= =?utf-8?B?eTBWSmlEb2JEd2c5eGw2RHJlL29nQzVnaE1pYks4TEZGbHU0UVdUUFJoRFdJ?= =?utf-8?B?Rmo4dnFvQkhiSzBDOElBclR3Y0JzWU50NVpuWjV1dUVaUDVhL3E0L3lCck1L?= =?utf-8?B?ZkE4d2ZTdUdyV2RkdmdpNThQdlVXUW9QZjJCdWJqSUVJNUF2Wkd6aWlGTlhN?= =?utf-8?B?M0NLaW9ybnh5N1lIbG1aeWs4VzVob2ZIZUhzdXJXcXc3VlUzUkdyaHJnR0x3?= =?utf-8?B?RnQya2F2TkVLYTA3ZUZia2pKNTVOUEc0dUJlY0Z1TTYwTjZTVUNzSG1GZVcx?= =?utf-8?B?SW1zc1VNaVBiMVIxQStWeU45STJzeEJwdTl4TWt0SmZDRnNFc05ZVlRTZTNK?= =?utf-8?B?SEVDMkdGdGdOb1RaY212Wm5ZaG1YOU1ENFcvTWZ5dDBYQlBVdFdTN2p3VVRu?= =?utf-8?B?VmE3Nm5HOVZra1Z5ckFiRTI5YlZic2s3eGtyZUF5VGRYZlpWbEJsdms4TWdU?= =?utf-8?B?akhwNlZ6WFBrSEtMaTdjM3JuZXExNUdMV2JMR3EwemhmVHZMV014QTBWQmZt?= =?utf-8?B?NG1ZalloKyt6bDlXRE9aTEcyWjhvOUNxSUYrbXo3dnZrTVdkblczUFRaYWgw?= =?utf-8?B?bVlyaDFqSnlrUUJOSTN0ckx0QTZ1NEJFT2s2dDdOYXBwdlVOSDA2MnBNUVlo?= =?utf-8?B?b0ZTT2Nya2Z0QjNKcGJ1YzBkcmhpSGdHTDhoYi9iOEYwdVJ2MW5ZcTRRMmJ6?= =?utf-8?B?S1JWd0UrVkltRFdhdUZuNDFFMTVyTjhWV1FOUlFwWktlRnBDOVAveGplWkNs?= =?utf-8?B?bXJJc0VPVXJ6Ylh4VnhzY24wWkFKOEV0R05sR1JDblk5VXRqcUJUVDR0blVT?= =?utf-8?B?L2JvUEszVUUvNGVvb2Rhdm5FZ09wb2tqeU14OTdWUG5hK21UMThGVEFQOHl6?= =?utf-8?B?YkVIWVFKM1dYYksySjJML3RMZFVoZElCUmMrT2V6THhhUWxueVRHMUtrVHla?= =?utf-8?Q?TCaWxD72OPwrIrqFmACPfYKct?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6d72f2c-df64-4a34-50b1-08db4bbb2d63 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 09:45:49.6761 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HZSwL4/OqmrpkAbdfihTLGdGwYzfL8zA+AX5fDWRIJJwdCV0osEFvJvWF/yJv3ziRbzjENpPGGkk5olv6NBIYw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7980 We allow its use for writeback purposes only anyway, so let's also carry these out that way on capable hardware. We can then also expose the WBNOINVD feature, as there's no difference to WBINVD anymore. Note that respective emulation logic has already been in place since ad3abc47dd23 ("x86emul: support WBNOINVD"). Signed-off-by: Jan Beulich --- v2: FLUSH_WRITEBACK -> FLUSH_CACHE_WRITEBACK. --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -3772,7 +3772,7 @@ long do_mmuext_op( else if ( unlikely(!cache_flush_permitted(currd)) ) rc = -EACCES; else - wbinvd(); + wbnoinvd(); break; case MMUEXT_FLUSH_CACHE_GLOBAL: @@ -3788,7 +3788,7 @@ long do_mmuext_op( if ( !cpumask_intersects(mask, per_cpu(cpu_sibling_mask, cpu)) ) __cpumask_set_cpu(cpu, mask); - flush_mask(mask, FLUSH_CACHE); + flush_mask(mask, FLUSH_CACHE_WRITEBACK); } else rc = -EINVAL; --- a/xen/arch/x86/pv/emul-priv-op.c +++ b/xen/arch/x86/pv/emul-priv-op.c @@ -1196,10 +1196,8 @@ static int cf_check cache_op( * newer linux uses this in some start-of-day timing loops. */ ; - else if ( op == x86emul_wbnoinvd /* && cpu_has_wbnoinvd */ ) - wbnoinvd(); else - wbinvd(); + wbnoinvd(); return X86EMUL_OKAY; } --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -238,7 +238,7 @@ XEN_CPUFEATURE(EFRO, 7*32+10) / /* AMD-defined CPU features, CPUID level 0x80000008.ebx, word 8 */ XEN_CPUFEATURE(CLZERO, 8*32+ 0) /*A CLZERO instruction */ XEN_CPUFEATURE(RSTR_FP_ERR_PTRS, 8*32+ 2) /*A (F)X{SAVE,RSTOR} always saves/restores FPU Error pointers */ -XEN_CPUFEATURE(WBNOINVD, 8*32+ 9) /*S WBNOINVD instruction */ +XEN_CPUFEATURE(WBNOINVD, 8*32+ 9) /*A WBNOINVD instruction */ XEN_CPUFEATURE(IBPB, 8*32+12) /*A IBPB support only (no IBRS, used by AMD) */ XEN_CPUFEATURE(IBRS, 8*32+14) /*S MSR_SPEC_CTRL.IBRS */ XEN_CPUFEATURE(AMD_STIBP, 8*32+15) /*S MSR_SPEC_CTRL.STIBP */ From xen-devel-bounces@lists.xenproject.org Wed May 03 09:46:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 09:46:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529062.823027 (Exim 4.92) (envelope-from ) id 1pu944-0000dN-HC; Wed, 03 May 2023 09:46:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529062.823027; Wed, 03 May 2023 09:46:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu944-0000dE-CN; Wed, 03 May 2023 09:46:24 +0000 Received: by outflank-mailman (input) for mailman id 529062; Wed, 03 May 2023 09:46:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu942-0000NW-EQ for xen-devel@lists.xenproject.org; Wed, 03 May 2023 09:46:22 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2052.outbound.protection.outlook.com [40.107.7.52]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5bbe9fa1-e997-11ed-8611-37d641c3527e; Wed, 03 May 2023 11:46:20 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DBBPR04MB7980.eurprd04.prod.outlook.com (2603:10a6:10:1f0::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Wed, 3 May 2023 09:46:13 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 09:46:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5bbe9fa1-e997-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=baVyL1YjsprtZuoztGplHhfLl3GIExQ+Byq4JgrWfmfX7r/N303+eIdSzV4KloqlV3Ymvl+PrAlL5VRjF8UVgvw7M+1PItN2OAPJdooiD2IrPFrnJSXSES4CLNUbPJX68veDCfJZ3JnI3TcmsLxl0NdRrQfi+2GQN5sexOVt6EISbi9TAp7oa6Z2DcpvLraGfWmREB8yXOnQ9dyfN693LlKy9pwIhsAie6+5t8IE573CaRqHtBPhfkHzee5yGDqYX8f1237YxM/G2kdqGRSNw4cBCeZvG1wRy2EcMblr94BrfSYndG7mGDXU8PzOozxLv5ESnq8ygfS3LjDHOlf0lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ws+81il08fZF9Iyvf//QRJ+mt2teUl0Lbm4jBjIkcAo=; b=c2NF8nB8CjOAOryJyw4anItilvXvtyfOf6XAkN6Yu/yH6QEfle4SY+flQ20iC4mrSkeAfPmM0eCLfxrUXpgvsdew3cVMza9Nx2SEFgMtLe9Y47L+sA/+htm666ln2/uI4kktOMXmGT3uuRHlPpB2NLXKAN27qvWYwbwIEOGtLyGALLwNvHqrZrBjPldOEi1LZtG1HEQKODKF/TegIl1BT0ttOgp75CvMmRfYewVKsqFtDGSZIT1goLrGpouRaj87bB27I68iR3MQUp+PB3G8cZB0o3VjepFZCrLL0AMP1N1/C3/SU2zeEWCOD9MNhgO23GKdsjieYmGhF2MPp38gGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ws+81il08fZF9Iyvf//QRJ+mt2teUl0Lbm4jBjIkcAo=; b=amgxSUQqariV5Z5kqocOG8FAyVQZS3nVpB2u23E7qGlxCuq6nkpSIucU/Jbd+XxNMf9kdcaiEPzg47WNX08Vdw2FHmyrxCo80HhyyI50qPC9A+/R57HD8xHPYm7ieVPsOkJ5Iy8rdUJetjWfSuQFQaiVG4JSgqSyeJLTGutVVdok4Cce4XVzaOLyz9x/dTQExuQI9rxV7Ug3Ik0Wj5hw8RbdJxKb2Lg6b0CwnY3ws0pk3Q7IiGshPQnEfh5eTSLL5O6UocmAwdt39Sbc7DD783t3sMcuSdlxbG9S84h0CZaWvoCnbZ10I90kUQDjQuzsX9p/wbDqpbSTknBz4MSmKA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 3 May 2023 11:46:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: [PATCH v2 4/6] VT-d: restrict iommu_flush_all() to cache writeback Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Kevin Tian References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0001.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::11) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|DBBPR04MB7980:EE_ X-MS-Office365-Filtering-Correlation-Id: 7a1238cc-c88c-40f4-e604-08db4bbb3b83 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ClJdEjTpDKlYlZcz6EMYiejEPiGMD6VV9DUGIWvjRhbtqGCMWn9eTa3PBqsD73O6+3VuB/pXw1JhvarF2XrgnYMFSxocaFfEur5pLLravmG6Jvkxo0Hy9UFW6LlXLPUPbtnDSy1NU4T0FPnPyataGDtoSSFi4hqoZAy5LRdR5Z3VEbmjp3KDInh/HJ+35+lBbhVo7lM4M2MuCEBCcsBiWL/p39oQF7TNZwWUYtRZ8eSycmO6Ng9UdFGdOdPGZZgb/llj78CWDXKEmKELQPcNxqbPpOEx+kfNP0VgXvLQB2nbb0jwWrR95kwXttTp9KFNXZJ55k+z5/Y5irGXA0oiEfucu2lQddq0ygsS23ylOW//mppRPJrd4nwqeF22rWtmWcDPXNTgVXqfVzFtW8SHDlcxGQT21yw4LZyaxtmwpJusr4oFsQDkY0ahREfNq1F/klT21FJ9K9ccagZ2We/GPnBG1yFm6xYgUoCHL1TgGoKB6FYGO4AXeAD5BSe7BAC8X/h24+uec8ww8y+gFBRYMMellTG7ravC8Bf9IJuI7kroKni6NTs0feNeMjMZH13ZXmI2ZQhpGIuZlGjBojzMkCxDYAwdwcrMopQmkc7uTf5gjep3X902jo9JIJ1ksNXPmYrw+iQyP32893itb/713g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(136003)(346002)(376002)(366004)(396003)(451199021)(6506007)(26005)(6512007)(186003)(31686004)(2616005)(4744005)(2906002)(5660300002)(83380400001)(8936002)(8676002)(6486002)(41300700001)(36756003)(478600001)(54906003)(38100700002)(66476007)(66556008)(316002)(31696002)(66946007)(6916009)(4326008)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVdzZ2tsaU5oRkkrbmhIY1J2UVNMWXpGSmg3M09UOVNkOWRUK0xxNzFzWWVj?= =?utf-8?B?SmdHK2pxNFA0NXUzK2ZSa2E5aTlBQVUrVkNGdTdWYzlQbVhucklvNzdUYzJE?= =?utf-8?B?MEMwVVFDUkRranIza3dBU0RFOExhQi9ZN2s0WEljWGMzaktNYkRnUUZBK0pk?= =?utf-8?B?c09WL2ludGxvSlIyK3g1alFCYS92aHFiRWNQaXc5ckJLQ2lpd2NPNmJKZ0VV?= =?utf-8?B?RUdyZ0IxVVZ1Y1M5VXM4bW4vMmVvbkJxYm1tdXkvbVV1cGd2eUtVb3RtUXJ4?= =?utf-8?B?cTM1aTNaN2FETmFSS0JJR2pFbmtTUGs4Z0VES09mVG5KNVIzZWdXS2dQQ2Rs?= =?utf-8?B?ZzBQcjNLK2k4aHY3ZUNSZDRDN3FrczZyWVR1ZllMd1FLbE9Hd3p0Z2NkS0xx?= =?utf-8?B?d1U2b1p6d2kwc0hrVHkrTm9YQTdmVkZhVkwraFdENzg0V3dLOTN3ZnBMUkZy?= =?utf-8?B?eFVoWlNiMVVnaGRGaWRWZ3dMU1lpdnpLUlpIRmtuN29UZmZPRmU4enZvcjFN?= =?utf-8?B?NGpsUFJlNFZTdDhvaHU4VEFUdmdTWithd2hwV2o5eXNWa1lQaHArQ1oxd2hV?= =?utf-8?B?aUprcHhmbVcrNmZMN0lzQnBEYS9PdkVMTkFSY1A2VlcwNTFoRE50a2c3bUpQ?= =?utf-8?B?d0hwTm1LSVIzZVFmQ3gySWVqRGNxZU1oNldST1ZTS1FzMDNqMERTUUU4UzZy?= =?utf-8?B?NDMwVCtMMmlPMVc4L09JSG5FWW9MYUVXM0cwbFVXTGw0Y1lCTmIrYm12dUtG?= =?utf-8?B?cEQxY2RhMzNlUXZVa1VKS3FZTjlHdWF4Qkh2bzNabFdWb2dkN3NndWJjYjcv?= =?utf-8?B?cWQ3Uis4UW1MQks4MitpWGJBSittR1laakt5U09EQ3FYQ0hNWWxHOHZLWnZa?= =?utf-8?B?UTZMS3g5OWg4ZW5XT3dXaGF5QWNJbkxObXJza3Y2V1Y0c2FYT2UyWW52Zks2?= =?utf-8?B?R1QxRTlSRmwrb0VNUlBwb0pqOWozNzBsZDY0QUVJRi9VZWVxVkV1MCtzY2xL?= =?utf-8?B?WFZQcHV3L1crNUhPUXJBcXptOEt5bzk4OFkyYUlwYy9KK1k4Z0d4aWVtb21K?= =?utf-8?B?cUhHTUxTbGFBbU1NUHg3VFBwUFZqUGt4TWpOWUlNYjlibVVBYkZoZnBJaC9K?= =?utf-8?B?N1VjVDJjSGtmMGRVZFd6MkpNUFhkM3kyc2JhSkxldDZLRlprUzBzamJWS3oy?= =?utf-8?B?VnhXS2NuSlFlTU5qMGo2cEFNK2VqTUZOalZ5a1FHc01XSlhKZHpNUTdycm05?= =?utf-8?B?RU55ejlRUmtHRVVKOGErbXV1WHRiN2NGT0hiNXVtWUIwdDV6UTBYMDkvNGMy?= =?utf-8?B?MSszQS9qR1preXlsZWRKS2x4TDhSMlRjR09wUEFramgzUE8rTGNPa0NpLzZp?= =?utf-8?B?R1A1V3B3UHNaSUprbytRQzhkVjJtL05TQXRndWFBTTd6UER3OHBTTTVBTUJm?= =?utf-8?B?U21pRnVFQkY5YzdteTJ4U3hqNTdqMWVva2JXdWlGS0ltY0x1TlBrQmJ5RXNB?= =?utf-8?B?UkpjRlR1cSthNEdjVUNxM1NmbGlJbXMrbnhJOFFZYVdNL3ROTE92MnZoUTA3?= =?utf-8?B?SFJydDZuTjhLUk9YMXZoRHVFS2ZWcWwxUUgwL1R3czVUaFZiTkFVb1BKQXhT?= =?utf-8?B?MkMyVVhyTkxqeHpJM3Vkamdac3pPNEhSZXdncW1teVd4SWhrSmczTTRWcW5y?= =?utf-8?B?RmZOcStrcFlWd1VVRGNYLzNkK1VZY2ZOQXpTWVFBc2ZQRVpaM0ZGaEZtc1NN?= =?utf-8?B?VE00UDRlN2JEWmhoY2FHc3ZhZThsOXhWSlk4RHVrbWpicmZwZy9peERGZzN6?= =?utf-8?B?bFVUTk1IaVNmdWZQV243MjFVVzJEVlJueEpPRVdUbVhWZitCdEw0UllwdnRz?= =?utf-8?B?VjU1anBlQlhZaWVQQURHWE5ORUgxVkRuTmlwc05SeFoxNFVoMTlPb1pIWk5w?= =?utf-8?B?RElpSU1OaW93WkQ3OXUzRWNUQkx2QzN2clZSQlJ5VXRNVEJ3eVRjWVZVdTZF?= =?utf-8?B?Z2RTWUZhcFAyQkpIRThoZUVERm01cUJKU2tsMENWQkR3VzkvVWFmTGlWNFpV?= =?utf-8?B?MTg0U0tydjlZWmRZUDRpSGhMOEthaVFkQktSSlc1dWx2elhUdnNjRVZNVGk1?= =?utf-8?Q?YAnr6AOKPPVA74P/Fj2VOMMw1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a1238cc-c88c-40f4-e604-08db4bbb3b83 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 09:46:13.4542 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XzSW4C2/tBeUvdnlgoTGW4+dhDrRraPPIiedr5w9JzuBXfbHq3IqBvBeFO2kv90l2W9ZNez75QPniwfFM8W/Jw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7980 We don't need to invalidate caches here; all we're after is that earlier writes have made it to main memory (and aiui even that just in case). Signed-off-by: Jan Beulich --- This, aiui, being an analogue to uses of iommu_sync_cache() (just not range restricted), I wonder whether it shouldn't be conditional upon iommu_non_coherent. Then again I'm vaguely under the impression that we had been here before, possibly even as far as questioning the need for this call altogether. --- v2: FLUSH_WRITEBACK -> FLUSH_CACHE_WRITEBACK. --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -693,7 +693,7 @@ static int __must_check iommu_flush_all( bool_t flush_dev_iotlb; int rc = 0; - flush_local(FLUSH_CACHE); + flush_local(FLUSH_CACHE_WRITEBACK); for_each_drhd_unit ( drhd ) { From xen-devel-bounces@lists.xenproject.org Wed May 03 09:46:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 09:46:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529065.823037 (Exim 4.92) (envelope-from ) id 1pu94R-0001Kn-PF; Wed, 03 May 2023 09:46:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529065.823037; Wed, 03 May 2023 09:46:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu94R-0001Ke-MX; Wed, 03 May 2023 09:46:47 +0000 Received: by outflank-mailman (input) for mailman id 529065; Wed, 03 May 2023 09:46:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu94P-0000NW-M8 for xen-devel@lists.xenproject.org; Wed, 03 May 2023 09:46:45 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2045.outbound.protection.outlook.com [40.107.7.45]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 698984d9-e997-11ed-8611-37d641c3527e; Wed, 03 May 2023 11:46:44 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DBBPR04MB7980.eurprd04.prod.outlook.com (2603:10a6:10:1f0::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Wed, 3 May 2023 09:46:42 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 09:46:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 698984d9-e997-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VaR0A5tp8fMh/lROh/quBvvsVXHbFyPUdvPfJjuVjjyQRZZuJBQOo0LApaCs6cVHp87yH2bgp/Sa5Z9DyZIdrKe3+dmqxP47joldFirb/eG+Wy78vsTd7Nu9Xyq2qGYCz/SBsf+07yLLQIX/wjvc2AgUbUCuH8++U8X8zzzqWbKzX0i5A+jXE2XM3MZ3et/QBI7jSCguqOPA7Nxa15NfYy8LC+2DnfISTnsVnsTrHyUPucKgX/q2aFml3F9hDJieEwRnOTDbHQj2A+4ZcSl4tk3S1caj+1J9jleBLTmTaX6yuO6LFtHsgrLD9E1ZMNsoX+JrwW1MNyz45YDDGMsWGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sedWtunTwKdoeXFOwuCOGYeVfeFrxIMCs6hPZD4OxMU=; b=N1pcB5tDRlN0LlN57NvJ5aF40rJTwHSKxP3kG44dClPY1SNKXzF3A3OqnEY3aotZffpCw4qVAF8TRHHc3TsTQNPkw9LrIgur5VbWFkfMzYcQNEjynCNjRAOX1uc0eEjWOqSAq8RPwY0x4mcLKL+BcJiWLvEIt8JxurkyfbtfiIV1RT3O9Mr1Ehyn0vhlc5WC1sosOuokalGkAjkRQsJY5CYS6C5gxcLdtlrvCawBRfF9LdKElPxFzuAmYPNlHJrbZVih8gg+MrFSZB0XTZ9mWgnAaR4OV1VjJZpt0FuLMmoCfhmx6LS5f2nj5Z1o/TvnyUsFe8bCTIAxjbhOrBsq1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sedWtunTwKdoeXFOwuCOGYeVfeFrxIMCs6hPZD4OxMU=; b=Za8+QXovpFpczNGsYnFlYDIa+np3IluLtYet1NBmSLVW3ZHAk3/gDmRmmW2xManq7N58K1y323lr/9vKQ+OBOrifqwwNpyyhmfek7+4l7kSMIF9xFKnTxIVA54CAWunJjd/vUTpiJktvWLMgvvx/H++yRKfOiA8tYq2kgKsXgeRoBDpMU3wjMZRW/OAmITlA5EbXyUt1102hZAVHDPahDIVrEK0gnBF1UWhFREbYnoP49cqx14ppXHXdOQDVMp6VbHflegDgn2+Yux2aoHpU9jZNLbbJt/iAuSM2rO3+ywb4NesbPqTxcqk2SuukTSzGd1vY2Q+inKVvvvUT2CK6ow== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 3 May 2023 11:46:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: [PATCH v2 5/6] x86: FLUSH_CACHE -> FLUSH_CACHE_EVICT Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0157.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:99::18) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|DBBPR04MB7980:EE_ X-MS-Office365-Filtering-Correlation-Id: c2546fdf-8b07-4440-6e49-08db4bbb4cf0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fpRL9bnhCOhnsC6alSfEVtWe8YJYTJaE2+JHcW9qTIonFtJjgm7EYSzObIfQ1vQRifbWAy3nvRlXyZwI+IrftptNWbY9jM8AuTfbkBg+oa46wl2OwhEt/3DZoaDg92anp+nA/7eEui9hQqhnhVC4/yn0110QK1gPAAK3c6PQTFfMH6ibSEUFgvmClWAbO9HlryKswV4aoqcIfbQxnD55OqiqLC03TyZhHELFhf8U4oGvYCWpDPX5MUdxU9sQIUC22jZIMA06xeXPBkSlHBir+OQ6DAgO4uK9PZMXzCfkZFq36TAU/NCUcabVG1XDwpfBeWHzRjDMsSjmOq0RjVA/bOpCRqgTi1SbAQ9fzp5wOzC0kmDvAckavSRbX3SwKuL0Ej0Ht0N/54vRMj53qmiw2dFUoLSFI+HJDIgsqXu2V6D9kj5hlum75vDItSwcdzlkhgeBpAY20rtqmFaCMb6/OgZjrF1Sa5wslNiIP+Gx0nj2BqkY51JqG+qqHn0l9T10gRqkeN/NomuFcpcw+mEE6wDYIqF0la2FOs1Yyyg/7sgWzw+O306RiHl0QksDfJjjV0FlMuGOoc7gXj8LOU3wiEIJvOwAfGZ8EOVjVz9dH4wt5iYaNWURSDCk3qhQ3VMZpNxp4kHI9oDJJQ14QJwshA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(136003)(346002)(376002)(366004)(396003)(451199021)(6506007)(26005)(6512007)(186003)(31686004)(2616005)(2906002)(5660300002)(83380400001)(8936002)(8676002)(6486002)(41300700001)(36756003)(478600001)(54906003)(38100700002)(66476007)(66556008)(316002)(31696002)(66946007)(6916009)(4326008)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M0EvZ1VtNjZCMEg4amc3Tmkra0EvMWFhVTgwbjRSTVByN1FCdTQwYzVWcUg4?= =?utf-8?B?c0NNSHZsS2ZRU2p6S0dYSi90a0RiRUt5OFNVdk1OTWp0VkpNOGhtd0N0dVAw?= =?utf-8?B?SDdVVloyK0ZTaGI4bDFOdUFwVnljdkQzVnNiSlhMMDFtanF3NGpmWUZaaDVW?= =?utf-8?B?UVhITVZaTmhnejdqL20yNWdCdTltcDJYUytIYWZwMWxpQlFTTHRhVU5lWE1L?= =?utf-8?B?R0loUzgwQWU2cldLRjhjWUR3Ym5ncHpoYXdiOVNQZWVZUDVENWJhNUpOeXU3?= =?utf-8?B?V1hJYVBCZWZIOEMwbXZ6SkdvMlE4V0l3M0VBYXJMWUFKalBlcldtNnB3eTN1?= =?utf-8?B?cHFmMUVPTkJpdlN5dHEvZHhVQ0R5ZFIvWlY3TWVFc29EK3cwMlZxSE1lRWlK?= =?utf-8?B?WkNoY3lWRDRiSGxwVEoxL0owVUQ1bFN4STZnUkduQ1lXaWRjWlU3QTExbk5x?= =?utf-8?B?R0RGUlNITVFVbWRyWjA0WmdZOUladmlQQlRubWkvU3ZzbnZWOW9wNTFSelZq?= =?utf-8?B?S1JkblBUUnZ6enU5c0ovdWQvejNucEFJMEVhS3hxVU0vV3FlbGNENVhEWGht?= =?utf-8?B?M3c5THB2YWh5RnlrYzdnUkpHZ2lTR3pYMWFCUExheFF6cEJkQzFmZWJwM2hZ?= =?utf-8?B?UkVlZ0pHNUQ3NkxPeDNOUmoxZVQwcEFzSk1hM21yd3ZrRmZXTDYzVzRybDBG?= =?utf-8?B?MGk4WDZvdFJOMXY1bG5CUnJCbkp4bGxtTlRwdURydGYraEFGUDU1LytueUJF?= =?utf-8?B?UzdtOGZGVTlXVGNGQzNHcXVGM05iTXpxUklIUnROY3o4eUI5OUk4RnpsV3BB?= =?utf-8?B?ZWFUNFlpRFFSWnBqSmJIVDg2WEpNbitUcWlUWTRFS0lIQTJvNG9WQldPVHpT?= =?utf-8?B?b2VaL1hlTGgwaXZmNkhrbUR0U0N6amxzN3hxTnowMW5hMU5rSFZPckp2Rkp6?= =?utf-8?B?WnFNVGZHaTNBWlhkUHlYR3VwdDI4K3A3YUJKbHFFUUVEZmtnQVh1cDhOZGI0?= =?utf-8?B?S3JWTjV6TWZCSHhVV2J5NkRqMXJwamF2ZGYweDBqbmozTGsydytieUNBOUMv?= =?utf-8?B?TlF5L0dDcC90bURvc0loTjFPcTNXdGFOdG50WWpNUEdtZ1JOSFlOVFlQN01F?= =?utf-8?B?elRwRmk4Q0ZUdFQzS3R0cmRUYlBRNXFsNm1UUWdKb3dSVVdIMC8waHlTYTZT?= =?utf-8?B?OUlTakdJSlhYbU11bWE3OUp1V3VSRno1YzZJNGQyd2x3eTZSR25NbkVzTFJQ?= =?utf-8?B?WitZbURxUTRuUXBQZnh2WWRad0ZmMzhJeFFBMmJKeDh1VGVBNFl4RnoyRElr?= =?utf-8?B?WFV3WFJSL2ZuYWZCb2d1L1FTaXB5L0NFaVl2djIwL09yZHA3amQ3a1hXWWlp?= =?utf-8?B?NmZ2NUp4d1hzcnc4ei9nTml4TG5FUkluRW5zR25aVDJXV3FNdUdHd2pBVWpz?= =?utf-8?B?djlkQ1JmWVJCNlowekdpUWZXa1ZVOUJMWnJwaWJzWjh1UUR1RnI3a1o3V1Bv?= =?utf-8?B?blhtK3lZNHNWMXl3cWJIK2RiMEU0aVg1OFFZTUY2MUdJbWdEWG1lVHJyMis2?= =?utf-8?B?MTErajVLQjdnWDZiRU9GZjlPbFpiYTIvWWRXRzgzTTI3NHdBaW1mKzBBaHp2?= =?utf-8?B?bStvVjVoczBSWVo2OFVGNVljaUhZZ3h4bWJxYzNtWU1EaElnSWFsSVNpeHps?= =?utf-8?B?RFBHYk91Qmtzdzg0U3l3cFoxODZYUzZ5aEtsM0pmV3FvYjZrV3doMFA3SzJK?= =?utf-8?B?dFVwMWRwYy9LN1F2UGNkRGQ1VWNqMVFtM3czNWFpMFJwak1NSDA5QlF0b211?= =?utf-8?B?ZkFpOWJWTWdhWkJiN3hDak1BV3dmeG5WZlRYY2JHUW5CZFkwMGYvczRtUmFZ?= =?utf-8?B?T0pzZjhXanZ1Ymx3aGZjSm1JdEkyL1NSS1ZxSnpLN0lhaG1naHFHQzFtc3lW?= =?utf-8?B?NWVSNUpRRHlDUUtkWXQwbHdJaUpDK2dBWEszUjdORDVOVDVheWEvM1Jvdnpx?= =?utf-8?B?TytrRDFjODM4WktURFRCeVlaME5MZDc1aUo3Z1VYRlU0enhwUUwxQUxMdVF2?= =?utf-8?B?SnZQQndKalltVkpjcjJtRzhpd3RmTGsvS21jNnVxaEZPU00xTC9EakdEWUNj?= =?utf-8?Q?SMk1duqpQVan/4rXP6UMAz3wg?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c2546fdf-8b07-4440-6e49-08db4bbb4cf0 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 09:46:42.6204 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oAbjnMzlOUvnn1zJGckmhAAb86n+GubmED2soiX7lSxTEnNaTZRkLr5UBhYyPwfCpCMDaHSs8fAZ12vNbF69VQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7980 This is to make the difference to FLUSH_CACHE_WRITEBACK more explicit. Requested-by: Andrew Cooper Signed-off-by: Jan Beulich --- Note that this (of course) collides with "x86/HVM: restrict use of pinned cache attributes as well as associated flushing". --- v2: New. --- a/xen/arch/x86/flushtlb.c +++ b/xen/arch/x86/flushtlb.c @@ -232,7 +232,7 @@ unsigned int flush_area_local(const void if ( flags & FLUSH_HVM_ASID_CORE ) hvm_flush_guest_tlbs(); - if ( flags & (FLUSH_CACHE | FLUSH_CACHE_WRITEBACK) ) + if ( flags & (FLUSH_CACHE_EVICT | FLUSH_CACHE_WRITEBACK) ) { const struct cpuinfo_x86 *c = ¤t_cpu_data; unsigned long sz = 0; @@ -245,13 +245,13 @@ unsigned int flush_area_local(const void c->x86_clflush_size && c->x86_cache_size && sz && ((sz >> 10) < c->x86_cache_size) ) { - if ( flags & FLUSH_CACHE ) + if ( flags & FLUSH_CACHE_EVICT ) cache_flush(va, sz); else cache_writeback(va, sz); - flags &= ~(FLUSH_CACHE | FLUSH_CACHE_WRITEBACK); + flags &= ~(FLUSH_CACHE_EVICT | FLUSH_CACHE_WRITEBACK); } - else if ( flags & FLUSH_CACHE ) + else if ( flags & FLUSH_CACHE_EVICT ) wbinvd(); else wbnoinvd(); --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -2228,7 +2228,7 @@ void hvm_shadow_handle_cd(struct vcpu *v domain_pause_nosync(v->domain); /* Flush physical caches. */ - flush_all(FLUSH_CACHE); + flush_all(FLUSH_CACHE_EVICT); hvm_set_uc_mode(v, 1); domain_unpause(v->domain); --- a/xen/arch/x86/hvm/mtrr.c +++ b/xen/arch/x86/hvm/mtrr.c @@ -614,7 +614,7 @@ int hvm_set_mem_pinned_cacheattr(struct break; /* fall through */ default: - flush_all(FLUSH_CACHE); + flush_all(FLUSH_CACHE_EVICT); break; } return 0; @@ -680,7 +680,7 @@ int hvm_set_mem_pinned_cacheattr(struct p2m_memory_type_changed(d); if ( type != X86_MT_WB ) - flush_all(FLUSH_CACHE); + flush_all(FLUSH_CACHE_EVICT); return rc; } @@ -782,7 +782,7 @@ void memory_type_changed(struct domain * d->vcpu && d->vcpu[0] ) { p2m_memory_type_changed(d); - flush_all(FLUSH_CACHE); + flush_all(FLUSH_CACHE_EVICT); } } --- a/xen/arch/x86/include/asm/flushtlb.h +++ b/xen/arch/x86/include/asm/flushtlb.h @@ -113,7 +113,7 @@ void switch_cr3_cr4(unsigned long cr3, u /* Flush TLBs (or parts thereof) including global mappings */ #define FLUSH_TLB_GLOBAL 0x200 /* Flush data caches */ -#define FLUSH_CACHE 0x400 +#define FLUSH_CACHE_EVICT 0x400 /* VA for the flush has a valid mapping */ #define FLUSH_VA_VALID 0x800 /* Flush CPU state */ @@ -191,7 +191,7 @@ static inline int clean_and_invalidate_d { unsigned int order = get_order_from_bytes(size); /* sub-page granularity support needs to be added if necessary */ - flush_area_local(p, FLUSH_CACHE|FLUSH_ORDER(order)); + flush_area_local(p, FLUSH_CACHE_EVICT | FLUSH_ORDER(order)); return 0; } static inline int clean_dcache_va_range(const void *p, unsigned long size) --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -5193,7 +5193,7 @@ int map_pages_to_xen( if ( (flags & _PAGE_PRESENT) && \ (((o_) ^ flags) & PAGE_CACHE_ATTRS) ) \ { \ - flush_flags |= FLUSH_CACHE; \ + flush_flags |= FLUSH_CACHE_EVICT; \ if ( virt >= DIRECTMAP_VIRT_START && \ virt < HYPERVISOR_VIRT_END ) \ flush_flags |= FLUSH_VA_VALID; \ From xen-devel-bounces@lists.xenproject.org Wed May 03 09:47:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 09:47:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529069.823047 (Exim 4.92) (envelope-from ) id 1pu95T-00026b-6t; Wed, 03 May 2023 09:47:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529069.823047; Wed, 03 May 2023 09:47:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu95T-00026U-46; Wed, 03 May 2023 09:47:51 +0000 Received: by outflank-mailman (input) for mailman id 529069; Wed, 03 May 2023 09:47:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu95S-00026M-D7 for xen-devel@lists.xenproject.org; Wed, 03 May 2023 09:47:50 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2053.outbound.protection.outlook.com [40.107.7.53]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8fb96d3f-e997-11ed-8611-37d641c3527e; Wed, 03 May 2023 11:47:48 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DBBPR04MB7980.eurprd04.prod.outlook.com (2603:10a6:10:1f0::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Wed, 3 May 2023 09:47:19 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 09:47:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8fb96d3f-e997-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nk+Zig6DRm5g/T5AVqh2RtQ8dg9/LyGuF5laszhFvbe1uMMb5mlaJqSHr/WU8pGJ77yS035Hb28sjnc0Q2/prmEKrTMc+E3jDls9fReKBToVOyjN2oQc39Ce4xUNIddkAIj//pvqlsVbw7+o0BLYazQ9W5FG4Uped0cK2setlLk4lKUIXO6ESrbjqLf4qTEvJK4c56u4jM6IirY+Rf1ij7AIa1NxPFGmNGU1CNUhYdXZHT+FJ8SCyaMBQftiNLZ62BqYly2jY0xyImSK594kXeuFzglZo1ht1jxs/xwZZy8F7NwveNFpIQGeUhyU3C9uyjzwCu/K0RcEcr05RsGTPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KxFwwb3BZGcHC7xshgmJ4kLtF4OIl105qptm5zCcXSA=; b=EvRaJti7qqk2J+WJxPzZjlQXlhvK+HeaG+lI9+Y1K2xn44lZ+ndYG+jU9OA1o7O4nYp8BnqyGRI0b/77JT9ULtMpDhBSc5Gl4oue4WOlqcUq4b7XFhPYrax4/MqNbTqJlXUyK0YXNUNTonIfOU3S7fBz+AAOigxySRmQUQ8Q0K+7MG8NzpGYF/GybQSBo/0HW+GMzI9ZG7vFbp0DCIIYMcz1FSdIKDyH2yM5sB3R+qb5b085IxctWm0F7pHMliTgh4hVVVo3yiS0vQZqyMzvDKUupRUF3lecc4tmPZVgmG1MYcGhvuYHt33dZvAVApbZogfwoQvbVeQDgQgpZ0DOuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KxFwwb3BZGcHC7xshgmJ4kLtF4OIl105qptm5zCcXSA=; b=4Tpn1AY+3Nx41MSek8MHxr+5itCcZ7tF23iHge2xklIIplLYV1eQ3k9heNhYzehSRfLs65OHGiVAlOid4d2m5YEjNh4B1lIyU266kJAlqfQFLM3hUPC+Acw60PDJ7fMpPBKeTbMtbmWfj/U3AyGWv2rocydVdNdFxktx5IhsscRSgGEpYOSI3NlDs2OT/RqAyMZAOwT4RIyi0WEux0WateV//cylzMA7PLRCilCaudcJq3SQt4R5tpbAIW49RoRyBBPV0yYIy2FP7KcMk3zw4JR2hgXAyKSuUM2kHEI42cMCXlKi7t6qt+4e7SyYcJB/iLCbB/R/mX9lKOqUMkDY/A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9274fbb1-c1be-9570-ecfc-8f0ac9a1f42b@suse.com> Date: Wed, 3 May 2023 11:47:18 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: [PATCH v2 6/6] x86/HVM: limit cache writeback overhead Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Kevin Tian , Jun Nakajima References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0157.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:99::18) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|DBBPR04MB7980:EE_ X-MS-Office365-Filtering-Correlation-Id: fc04887b-0423-4823-8252-08db4bbb632d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /yNMJBKt644QL+6Shjl0FzLE8bJGk7zcFnsk+9lyD1eO8QyJKn9AsTHj6yhQpGMXOxwDhJsft+Vh0WttnFSst+ZeZozBie4UMoJifjPQlhYiJFINjVYF3VjY//lam9Z/JrB6cgIKM/iJPG5ivecenOkgyqp5L5/ZcJgz1PQX/CzEOAPBy33JS9WhXK9F7SJc8EmG8CBAwkyddrczQta6AzNDp7oGo9TpfLLNb4lzmFy1t0qIp6eXckyE7CVGid4CfRUxG3Fhbtrhc+juoiiLOsb65JKxa1vzSOjyMW1/oa8xTY6t+qky4J/JOAmysgDBaRVJuwWkreYBnoM3D0hUM7JifTLkyo79OS4BuJcjpTvEFDFnlQhF4rTPj37Ba1yrzUsRJr5F7Q2HGsrgEBi4rYKgxsGd0rBiNLTXcGop8zNwjBjMWE+6jrYeHSh9D3WFTM68aq79lURWF8+/Ee39ZY1SQC637A9n+ilPNyYJUq4y3AHgh7D/rsTGE78/xOdP7zW9oH7OoOf158x5q4jv5bgOopvh2R+my6mB/CwHgicBNlTQNN45h6003oUbujkb7stmvreJVrAr1vze6VuSjou9SPLBisAT1Hs5wCctX4g97N/VRXTa/apvOqTmgFJxupQ/ybBGq/92QhS4LKWqLg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(136003)(346002)(376002)(366004)(396003)(451199021)(6506007)(26005)(6512007)(186003)(31686004)(2616005)(2906002)(5660300002)(83380400001)(8936002)(8676002)(6486002)(41300700001)(36756003)(478600001)(54906003)(38100700002)(66476007)(66556008)(316002)(31696002)(66946007)(6916009)(4326008)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WHFZTG9pMHNKQkZlT21TTWVGMkVnMVkrNUpBeXhTWTZWdjBKc1lQZWg5QmtC?= =?utf-8?B?U2dkdVNiamRNb2F3RTdUeDh2Y2Jzd3JyRC9KYnJ2K2cvUlJKTVlOL2lFRTdk?= =?utf-8?B?MlBZM0VwdVNBUDVndHRVT2tQZGtZZGVwM3p0VFN1YkNxOHpJNThCMUtPdURF?= =?utf-8?B?b3djQlhkSTQ3UytjMmpoWmhRTzh5clJvSE9va0tFbXZkLzRZa2Ficmt1NzBr?= =?utf-8?B?SnNFNkU3ZWJkM3hVSE1aWFYvM0hKL3VXNWp5SW1qYncrcW5PMGNNaWpsTXVI?= =?utf-8?B?Q0trZGUzZ1VaSnRBYU1RcjN0cEUzaW1MaURWVngxakVUMXBSSTFrV05JZUNa?= =?utf-8?B?MkJuZVIySXl1YTVtZEEvaXJXVFl0RXhlQkN2U05wMjlheGhhL09nSjQxbFNq?= =?utf-8?B?ajB3NVY2NjJRK1p1V0JlSGFEVXp3QURsM3Z4SDNZOXo3WWwrWkYwTnJuOGpM?= =?utf-8?B?TlVhc1JZOVdyTTU1ZUJSdi9WS1JTQ1pvQjFXMjNweGdoWURGcmtIcVd1ZUkz?= =?utf-8?B?cXcvUlZuS1d1Q1BFQ3NvWXl4YnE5Z0hsVTdWTU1xeEF3N2ZUaFJPN1hVa21K?= =?utf-8?B?V0pmVGtmTklLVHdVMzRHTFJLenNOQVo0SlowSTg1WnpycmxSeWcvQWJDOFVw?= =?utf-8?B?UXhmcW5BTGV1L2NlKzl2WVpzNHp6ZCs2NEJXYjU4S1NLN1c5RmNjSjR2OUdB?= =?utf-8?B?ZnJWT0tXZ2cwbmM2dWk5bmNZUlhMTVlBbG9jalZFaUJTakhVaFBvRWhhdzhH?= =?utf-8?B?a21SSWFUNWo3aUpTSUlKdDVYTm1ZZE9PSTdJUW5NWmFnYUxZUVljR2NtbHF2?= =?utf-8?B?MWpJN0thQktvL3R1cEFkMjJGWmFzMjV2bldNVXQvMFVkZ0lnMXdBUndqQWhG?= =?utf-8?B?VFFuWXh3RFMvVzNqTXBNOXd1b3ZVOW9WZld0Nm0rSTZnUzJEbEp3bENWcUhs?= =?utf-8?B?VGZNLzFUV2FzOTNKUXZmQlhIVWExeFUyS2FjOFdMbFhrMEJObkhaNFhiZ3B5?= =?utf-8?B?NG1wNEhmTVlHa0gwUkpXNVN0dnU4blZOU2M4TEpOSUR2S3NNaTVRVVcrWDBO?= =?utf-8?B?S1VGRnZRVmFJb1RWRTFDQURvc1ZxYjdRWlFXRzhaMUtsNDR5TVVsbHpZbUN0?= =?utf-8?B?ZXhpZEpxcDRLYno5MDdkdkVoWFNCSUhja1FKQ3dyWEU2RURTWHVTbm0wYXRt?= =?utf-8?B?UGZXbU5UWTVhN0JDU2d1UGM4RVc4SEtjREJmakdhZlhtK2RWM2drMlN2K2Uz?= =?utf-8?B?R2R2Q3NYdXMrWTI2NjJoVUhaVkpoT0pZVFNmZzMrUWtxc1E5R1VrQTBHUC9t?= =?utf-8?B?eGR4b08vZVpWblBCSFRJRFJzRmxPYStRQ09Vazl2WVB1TmtyVmJzK2pEQkp6?= =?utf-8?B?RmZhYVNCMkpBdEpmbE44Z1UvdzRLY0F4RVZRQmEwUGhuZkpGNlNteTlWckty?= =?utf-8?B?SXJHaUttZjQ2WG51UU9aS3cyQXhLWHBwbTlWTGxwMVV1d3NvMjRsczFENEdh?= =?utf-8?B?eHJVeEZ2Y2lCSXhGTVVDN2crT3RrenMyaDNSN3MvS0xTeHhxa2wwbExiL0ov?= =?utf-8?B?NzhwT2hGOEFjMEEremVieXpDM3lzRUtIaElmc0tRMlVLcVZ0SkwyU2hENU9w?= =?utf-8?B?QUR3MExyZkhTVU1wam45cFEzR3ZwMHBHSlg2SU5xb2NMR2IxcnZvVjlCNFlJ?= =?utf-8?B?R214WWxFY0pOYzduTmRMOTAxekRlNXV0K1BoUHVleG1QT1dzR2s5UHI1U1JQ?= =?utf-8?B?RWVvOGF4NktETExEaG9sd2VNYU9PVFk4VUxNK3hiVDdrNy9FUG5hdG1VcU9H?= =?utf-8?B?ajhaRmczdG93ZVBMclh1QnNMOXREamM1ZkFyK1I4MmRqWHJESkQ2WjBSZzFV?= =?utf-8?B?aEU0S2owMWpEclppdm5DK2hTSzZvc0tacEFHYnhXZitvVjJZRUpJODFsYnJD?= =?utf-8?B?SUsrbXIvWnpTYUQ2WHBybnZRQ2F4K1pGdk8vVVZCVEpqZVRzM0kxMzJKc2x4?= =?utf-8?B?SVNQSXVFSkIvVnNWTklaREtzbWk2cDBuWUFVWkRjN0RoNCtyQWlkb2ZaNjJq?= =?utf-8?B?VEgwNitISTFkSlVHTUV3K2F1NE1LcVRuZDVLdFl0QncvVmNkK0VqZERPY1Qr?= =?utf-8?Q?OZaxGm2A3BCEUCFQjdMckCsvD?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc04887b-0423-4823-8252-08db4bbb632d X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 09:47:19.9090 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pS4CniR+agOgejHU9tQB0i7PoAuRN3b2C3kIYP+c35gMjDm0T6Q3bB9l3l8HGnmYyRWVNqpKt3klmdqIyG3Fmg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7980 There's no need to write back caches on all CPUs upon seeing a WBINVD exit; ones that a vCPU hasn't run on since the last writeback (or since it was started) can't hold data which may need writing back. Signed-off-by: Jan Beulich --- With us not running AMD IOMMUs in non-coherent ways, I wonder whether svm_wbinvd_intercept() really needs to do anything (or whether it couldn't check iommu_snoop just like VMX does, knowing that as of c609108b2190 ["x86/shadow: make iommu_snoop usage consistent with HAP's"] that's always set; this would largely serve as grep fodder then, to make sure this code is updated once / when we do away with this global variable, and it would be the penultimate step to being able to fold SVM's and VT-x'es functions). --- v2: Re-base over changes earlier in the series. --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -537,6 +537,8 @@ void hvm_do_resume(struct vcpu *v) v->arch.hvm.inject_event.vector = HVM_EVENT_VECTOR_UNSET; } + __cpumask_set_cpu(v->processor, v->arch.hvm.cache_dirty_mask); + if ( unlikely(v->arch.vm_event) && v->arch.monitor.next_interrupt_enabled ) { struct x86_event info; @@ -1592,6 +1594,10 @@ int hvm_vcpu_initialise(struct vcpu *v) if ( rc ) goto fail6; + rc = -ENOMEM; + if ( !zalloc_cpumask_var(&v->arch.hvm.cache_dirty_mask) ) + goto fail6; + rc = ioreq_server_add_vcpu_all(d, v); if ( rc != 0 ) goto fail6; @@ -1621,6 +1627,7 @@ int hvm_vcpu_initialise(struct vcpu *v) hvm_vcpu_cacheattr_destroy(v); fail1: viridian_vcpu_deinit(v); + FREE_CPUMASK_VAR(v->arch.hvm.cache_dirty_mask); return rc; } @@ -1628,6 +1635,8 @@ void hvm_vcpu_destroy(struct vcpu *v) { viridian_vcpu_deinit(v); + FREE_CPUMASK_VAR(v->arch.hvm.cache_dirty_mask); + ioreq_server_remove_vcpu_all(v->domain, v); if ( hvm_altp2m_supported() ) --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -2363,8 +2363,14 @@ static void svm_vmexit_mce_intercept( static void cf_check svm_wbinvd_intercept(void) { - if ( cache_flush_permitted(current->domain) ) - flush_all(FLUSH_CACHE_WRITEBACK); + struct vcpu *curr = current; + + if ( !cache_flush_permitted(curr->domain) ) + return; + + flush_mask(curr->arch.hvm.cache_dirty_mask, FLUSH_CACHE_WRITEBACK); + cpumask_copy(curr->arch.hvm.cache_dirty_mask, + cpumask_of(curr->processor)); } static void svm_vmexit_do_invalidate_cache(struct cpu_user_regs *regs, --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -3710,11 +3710,17 @@ static void vmx_do_extint(struct cpu_use static void cf_check vmx_wbinvd_intercept(void) { - if ( !cache_flush_permitted(current->domain) || iommu_snoop ) + struct vcpu *curr = current; + + if ( !cache_flush_permitted(curr->domain) || iommu_snoop ) return; if ( cpu_has_wbinvd_exiting ) - flush_all(FLUSH_CACHE_WRITEBACK); + { + flush_mask(curr->arch.hvm.cache_dirty_mask, FLUSH_CACHE_WRITEBACK); + cpumask_copy(curr->arch.hvm.cache_dirty_mask, + cpumask_of(curr->processor)); + } else wbnoinvd(); } --- a/xen/arch/x86/include/asm/hvm/vcpu.h +++ b/xen/arch/x86/include/asm/hvm/vcpu.h @@ -161,6 +161,8 @@ struct hvm_vcpu { struct svm_vcpu svm; }; + cpumask_var_t cache_dirty_mask; + struct tasklet assert_evtchn_irq_tasklet; struct nestedvcpu nvcpu; From xen-devel-bounces@lists.xenproject.org Wed May 03 09:57:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 09:57:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529071.823057 (Exim 4.92) (envelope-from ) id 1pu9Ew-0003f2-4Y; Wed, 03 May 2023 09:57:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529071.823057; Wed, 03 May 2023 09:57:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu9Ew-0003ev-1U; Wed, 03 May 2023 09:57:38 +0000 Received: by outflank-mailman (input) for mailman id 529071; Wed, 03 May 2023 09:57:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu9Ev-0003ep-58 for xen-devel@lists.xenproject.org; Wed, 03 May 2023 09:57:37 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu9Eu-0006Xx-Ne; Wed, 03 May 2023 09:57:36 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.7.72]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pu9Eu-0003nQ-GK; Wed, 03 May 2023 09:57:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=ul3QFpGjbwRlVg8hyIG/++WptfdF4QkYqxE1QSqeqkc=; b=rC3qS9xkoPH+d0b41Hsy+JIQnY hRsV3/ltomwLOWl8LLM0B3U6ojNwUElqJAlONBdCR8bNcEZcPu52tO6TWFImKzcFpjix4gJ9kvuSa cGdN83izIEI4rxAMyWqpuWl423RMJ3AuGmsYKHOrIJyZqYWIuPkvYbSNlGZGfsumisI0=; Message-ID: Date: Wed, 3 May 2023 10:57:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 11/13] tools/xenstore: remember global and per domain max accounting values Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Anthony PERARD References: <20230405070349.25293-1-jgross@suse.com> <20230405070349.25293-12-jgross@suse.com> From: Julien Grall In-Reply-To: <20230405070349.25293-12-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 05/04/2023 08:03, Juergen Gross wrote: > Add saving the maximum values of the different accounting data seen > per domain and (for unprivileged domains) globally, and print those > values via the xenstore-control quota command. Add a sub-command for > resetting the global maximum values seen. > > This should help for a decision how to set the related quotas. > > Signed-off-by: Juergen Gross Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 03 10:18:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 10:18:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529083.823067 (Exim 4.92) (envelope-from ) id 1pu9Ym-00069a-OU; Wed, 03 May 2023 10:18:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529083.823067; Wed, 03 May 2023 10:18:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu9Ym-00069T-Lp; Wed, 03 May 2023 10:18:08 +0000 Received: by outflank-mailman (input) for mailman id 529083; Wed, 03 May 2023 10:18:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu9Yl-00069N-Cu for xen-devel@lists.xenproject.org; Wed, 03 May 2023 10:18:07 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu9Yk-00078e-E8; Wed, 03 May 2023 10:18:06 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.7.72]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pu9Yk-0004ko-79; Wed, 03 May 2023 10:18:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=MFnrBR4HCIIlWL1rbTcejWiIvoGKmGhxOCDBSwCs6GI=; b=MDOaEpj0CPWx3z7qbqDK8J+gQ1 Uf9l/7buGbt2TEJyfcwek2XDQNOtico9tmQLuiYD8Y3k/gRbwXfqTawoiozi0EDF40FRRK0esbfOO ge3t4T99vzFG6G8Y1pNtndf0Jd3ukLhr6waRQIlvrxxn3QWP/BjCO9n82IatppGyNqlg=; Message-ID: Date: Wed, 3 May 2023 11:18:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 12/13] tools/xenstore: use generic accounting for remaining quotas Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230405070349.25293-1-jgross@suse.com> <20230405070349.25293-13-jgross@suse.com> From: Julien Grall In-Reply-To: <20230405070349.25293-13-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05/04/2023 08:03, Juergen Gross wrote: > The maxrequests, node size, number of node permissions, and path length > quota are a little bit special, as they are either active in > transactions only (maxrequests), or they are just per item instead of > count values. Nevertheless being able to know the maximum number of > those quota related values per domain would be beneficial, so add them > to the generic accounting. > > The per domain value will never show current numbers other than zero, > but the maximum number seen can be gathered the same way as the number > of nodes during a transaction. > > To be able to use the const qualifier for a new function switch > domain_is_unprivileged() to take a const pointer, too. > > Signed-off-by: Juergen Gross > --- > tools/xenstore/xenstored_core.c | 14 ++++----- > tools/xenstore/xenstored_core.h | 2 +- > tools/xenstore/xenstored_domain.c | 39 ++++++++++++++++++++------ > tools/xenstore/xenstored_domain.h | 6 ++++ > tools/xenstore/xenstored_transaction.c | 4 +-- > tools/xenstore/xenstored_watch.c | 2 +- > 6 files changed, 48 insertions(+), 19 deletions(-) > > diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c > index 88c569b7d5..65df2866bf 100644 > --- a/tools/xenstore/xenstored_core.c > +++ b/tools/xenstore/xenstored_core.c > @@ -799,8 +799,8 @@ int write_node_raw(struct connection *conn, TDB_DATA *key, struct node *node, > + node->perms.num * sizeof(node->perms.p[0]) > + node->datalen + node->childlen; > > - if (!no_quota_check && domain_is_unprivileged(conn) && > - data.dsize >= quota_max_entry_size) { > + if (domain_max_chk(conn, ACC_NODESZ, data.dsize, quota_max_entry_size) > + && !no_quota_check) { It feels a bit odd to move the !no_quota_check right after the actual check. But AFAICT, you are doing it because domain_max_chk() will also update the maximum value seen by the current quota. Is that correct? If so, it would be worth mentioning it in a comment. > errno = ENOSPC; > return errno; > } > @@ -1168,7 +1168,7 @@ static bool valid_chars(const char *node) > "0123456789-/_@") == strlen(node)); > } > > -bool is_valid_nodename(const char *node) > +bool is_valid_nodename(const struct connection *conn, const char *node) > { > int local_off = 0; > unsigned int domid; > @@ -1188,7 +1188,8 @@ bool is_valid_nodename(const char *node) > if (sscanf(node, "/local/domain/%5u/%n", &domid, &local_off) != 1) > local_off = 0; > > - if (strlen(node) > local_off + quota_max_path_len) > + if (domain_max_chk(conn, ACC_PATHLEN, strlen(node) - local_off, > + quota_max_path_len)) > return false; > > return valid_chars(node); > @@ -1250,7 +1251,7 @@ static struct node *get_node_canonicalized(struct connection *conn, > *canonical_name = canonicalize(conn, ctx, name); > if (!*canonical_name) > return NULL; > - if (!is_valid_nodename(*canonical_name)) { > + if (!is_valid_nodename(conn, *canonical_name)) { > errno = EINVAL; > return NULL; > } > @@ -1775,8 +1776,7 @@ static int do_set_perms(const void *ctx, struct connection *conn, > return EINVAL; > > perms.num--; > - if (domain_is_unprivileged(conn) && > - perms.num > quota_nb_perms_per_node) > + if (domain_max_chk(conn, ACC_NPERM, perms.num, quota_nb_perms_per_node)) > return ENOSPC; > > permstr = in->buffer + strlen(in->buffer) + 1; > diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h > index 3564d85d7d..9339820156 100644 > --- a/tools/xenstore/xenstored_core.h > +++ b/tools/xenstore/xenstored_core.h > @@ -258,7 +258,7 @@ void check_store(void); > void corrupt(struct connection *conn, const char *fmt, ...); > > /* Is this a valid node name? */ > -bool is_valid_nodename(const char *node); > +bool is_valid_nodename(const struct connection *conn, const char *node); > > /* Get name of parent node. */ > char *get_parent(const void *ctx, const char *node); > diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c > index d21f31da92..49e2c5c82a 100644 > --- a/tools/xenstore/xenstored_domain.c > +++ b/tools/xenstore/xenstored_domain.c > @@ -433,7 +433,7 @@ int domain_get_quota(const void *ctx, struct connection *conn, > return ENOMEM; > > #define ent(t, e) \ > - resp = talloc_asprintf_append(resp, "%-16s: %8u (max: %8u\n", #t, \ > + resp = talloc_asprintf_append(resp, "%-17s: %8u (max: %8u\n", #t, \ This changes feels a bit unrelated. Can you mention why this is necessary in the commit message? > d->acc[e].val, d->acc[e].max); \ > if (!resp) return ENOMEM > > @@ -442,6 +442,7 @@ int domain_get_quota(const void *ctx, struct connection *conn, > ent(transactions, ACC_TRANS); > ent(outstanding, ACC_OUTST); > ent(memory, ACC_MEM); > + ent(transaction-nodes, ACC_TRANSNODES); You seem to convert multiple quotas but only print one. Why? > > #undef ent > > @@ -459,7 +460,7 @@ int domain_max_global_acc(const void *ctx, struct connection *conn) > return ENOMEM; > > #define ent(t, e) \ > - resp = talloc_asprintf_append(resp, "%-16s: %8u\n", #t, \ > + resp = talloc_asprintf_append(resp, "%-17s: %8u\n", #t, \ > acc_global_max[e]); \ Ditto. > if (!resp) return ENOMEM > > @@ -468,6 +469,7 @@ int domain_max_global_acc(const void *ctx, struct connection *conn) > ent(transactions, ACC_TRANS); > ent(outstanding, ACC_OUTST); > ent(memory, ACC_MEM); > + ent(transaction-nodes, ACC_TRANSNODES); > > #undef ent > > @@ -1081,12 +1083,22 @@ int domain_adjust_node_perms(struct node *node) > return 0; > } > > +static void domain_acc_valid_max(struct domain *d, enum accitem what, > + unsigned int val) > +{ > + assert(what < ARRAY_SIZE(d->acc)); > + assert(what < ARRAY_SIZE(acc_global_max)); > + > + if (val > d->acc[what].max) > + d->acc[what].max = val; > + if (val > acc_global_max[what] && domid_is_unprivileged(d->domid)) > + acc_global_max[what] = val; > +} > + > static int domain_acc_add_valid(struct domain *d, enum accitem what, int add) > { > unsigned int val; > > - assert(what < ARRAY_SIZE(d->acc)); I think this assert should be kept because... > - > if ((add < 0 && -add > d->acc[what].val) || ... of this check. Otherwise, you would check that 'what' is within the bounds after the use. > (add > 0 && (INT_MAX - d->acc[what].val) < add)) { > /* > @@ -1100,10 +1112,7 @@ static int domain_acc_add_valid(struct domain *d, enum accitem what, int add) > } > > val = d->acc[what].val + add; > - if (val > d->acc[what].max) > - d->acc[what].max = val; > - if (val > acc_global_max[what] && domid_is_unprivileged(d->domid)) > - acc_global_max[what] = val; > + domain_acc_valid_max(d, what, val); > > return val; > } > @@ -1221,6 +1230,20 @@ void domain_reset_global_acc(void) > hashtable_iterate(domhash, domain_reset_global_acc_sub, NULL); > } > > +bool domain_max_chk(const struct connection *conn, enum accitem what, > + unsigned int val, unsigned int quota) > +{ > + if (!conn || !conn->domain) > + return false; > + > + if (domain_is_unprivileged(conn) && val > quota) > + return true; > + > + domain_acc_valid_max(conn->domain, what, val); > + > + return false; > +} > + > int domain_nbentry_inc(struct connection *conn, unsigned int domid) > { > return (domain_acc_add(conn, domid, ACC_NODES, 1, false) < 0) > diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h > index b55c9bcc2d..3e17b63659 100644 > --- a/tools/xenstore/xenstored_domain.h > +++ b/tools/xenstore/xenstored_domain.h > @@ -32,6 +32,10 @@ enum accitem { > ACC_OUTST, > ACC_MEM, > ACC_TRANS, > + ACC_TRANSNODES, > + ACC_NPERM, > + ACC_PATHLEN, > + ACC_NODESZ, > ACC_N, /* Number of elements per domain. */ > }; > > @@ -128,6 +132,8 @@ void acc_drop(struct connection *conn); > void acc_commit(struct connection *conn); > int domain_max_global_acc(const void *ctx, struct connection *conn); > void domain_reset_global_acc(void); > +bool domain_max_chk(const struct connection *conn, unsigned int what, > + unsigned int val, unsigned int quota); > > /* Write rate limiting */ > > diff --git a/tools/xenstore/xenstored_transaction.c b/tools/xenstore/xenstored_transaction.c > index 1c14b8579a..0b256f9b18 100644 > --- a/tools/xenstore/xenstored_transaction.c > +++ b/tools/xenstore/xenstored_transaction.c > @@ -252,8 +252,8 @@ int access_node(struct connection *conn, struct node *node, > > i = find_accessed_node(trans, node->name); > if (!i) { > - if (trans->nodes >= quota_trans_nodes && > - domain_is_unprivileged(conn)) { > + if (domain_max_chk(conn, ACC_TRANSNODES, trans->nodes + 1, > + quota_trans_nodes)) { > ret = ENOSPC; > goto err; > } > diff --git a/tools/xenstore/xenstored_watch.c b/tools/xenstore/xenstored_watch.c > index e30cd89be3..61b1e3421e 100644 > --- a/tools/xenstore/xenstored_watch.c > +++ b/tools/xenstore/xenstored_watch.c > @@ -176,7 +176,7 @@ static int check_watch_path(struct connection *conn, const void *ctx, > *path = canonicalize(conn, ctx, *path); > if (!*path) > return errno; > - if (!is_valid_nodename(*path)) > + if (!is_valid_nodename(conn, *path)) > goto inval; > } > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 03 10:31:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 10:31:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529087.823077 (Exim 4.92) (envelope-from ) id 1pu9lO-0008V1-Tw; Wed, 03 May 2023 10:31:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529087.823077; Wed, 03 May 2023 10:31:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu9lO-0008Uu-Qp; Wed, 03 May 2023 10:31:10 +0000 Received: by outflank-mailman (input) for mailman id 529087; Wed, 03 May 2023 10:31:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu9lN-0008Uo-7S for xen-devel@lists.xenproject.org; Wed, 03 May 2023 10:31:09 +0000 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [2a00:1450:4864:20::129]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9bddfd91-e99d-11ed-8611-37d641c3527e; Wed, 03 May 2023 12:31:05 +0200 (CEST) Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-4ecb137af7eso5789766e87.2 for ; Wed, 03 May 2023 03:31:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9bddfd91-e99d-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1683109865; x=1685701865; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=XH75TWJ2QK3zdQ/KOUS0feKVGadWx7stMsjQVAPoLPk=; b=Rb6ZOSztdPJhHIt2xej/h224+3Edu0xk4ke2X6vH/IPAL9jb/53cT5nEH28c/Hd/NS FBXA2zZiZDPjX3+hd0FWPEM6O5yybznZra2LbJvbY63ylhYayOIUNjFmsACgjrfZfj1R ax8Jj3NOCDOU1Rgzr9DtemrhagdEwAdBAkCIU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683109865; x=1685701865; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XH75TWJ2QK3zdQ/KOUS0feKVGadWx7stMsjQVAPoLPk=; b=cU9+0PJj2BK7vXbtrUZPP764PfPXpNuaYmGWdV1/IVcWF3OYzLpxT7PYFQHGyTqbEE po7jVr5kBS69Ky4Kc31wEaDgRuXtu1HgpqdzXgoxdURIzYgYokcaP8yQJJdamp/xxJfd x+dl3pEtTYB0AHc68DcalGzzgf5QowWaXhDYY/svfsKzhy17Rgs2+snw3MktAACt0iuB 6dbAnVO03pNtc4s5edn16LhIqXUGv//zD/ftDMaecDbZC4ArEBlWV76f6Qw4+bpasZ8L 7cvVsWziOf8vlzZISb/IFk6B3qCpw7cjAvjB/fKOJ1UxuWmF8kwRk5EHCjy8NrK69hH5 hTnA== X-Gm-Message-State: AC+VfDxsPc3bFV4qqIFAKTAwZuWCh92FNk0Uwgvoa+BFKka3rSAWpxTQ oX0VAULD07BdMLBFywfl00rians+LENjRkmgyErpFw== X-Google-Smtp-Source: ACHHUZ6hTs76I1dbN2GtIr2MCjXCJG09adCJ7BxIwzWF6znw3MNSgQAe1EX5GBuLa33kH0FpAh1BgdXq7yUDWaIdrAg= X-Received: by 2002:ac2:5ec2:0:b0:4dd:af71:a5b7 with SMTP id d2-20020ac25ec2000000b004ddaf71a5b7mr819878lfq.41.1683109864742; Wed, 03 May 2023 03:31:04 -0700 (PDT) MIME-Version: 1.0 References: <20230428081231.2464275-1-george.dunlap@cloud.com> In-Reply-To: From: George Dunlap Date: Wed, 3 May 2023 11:30:53 +0100 Message-ID: Subject: Re: [PATCH RFC] SUPPORT.md: Make all security support explicit To: Jan Beulich Cc: Wei Liu , Andrew Cooper , Roger Pau Monne , Stefano Stabellini , Julien Grall , xen-devel@lists.xenproject.org Content-Type: multipart/alternative; boundary="0000000000009b382e05fac78d41" --0000000000009b382e05fac78d41 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, May 2, 2023 at 12:19=E2=80=AFPM Jan Beulich wro= te: > On 28.04.2023 10:12, George Dunlap wrote: > > --- a/SUPPORT.md > > +++ b/SUPPORT.md > > @@ -17,6 +17,36 @@ for the definitions of the support status levels etc= . > > Release Notes > > : https://wiki.xenproject.org/wiki/Xen_Project_X.YY_Release_Notes">RN > > > > +# General security support > > + > > +An XSA will always be issued for security-related bugs which are > > +present in a "plain vanilla" configuration. A "plain vanilla" > > +configuration is defined as follows: > > + > > +* The Xen hypervisor is built from a tagged release of Xen, or a > > + commit which was on the tip of one of the supported stable branches. > > + > > +* The Xen hypervisor was built with the default config for the platfor= m > > + > > +* No Xen command-line parameters were specified > > + > > +* No parameters for Xen-related drivers in the Linux kernel were > specified > > + > > +* No modifications were made to the default xl.conf > > + > > +* xl.cfg files use only core functionality > > + > > +* Alternate toolstacks only activate functionality activated by the > > + core functionality of xl.cfg files. > > + > > +Any system outside this configuration will only be considered security > > +supported if the functionality is explicitly listed as supported in > > +this document. > > + > > +If a security-related bug exits only in a configuration listed as not > > +security supported, the security team will generally not issue an XSA; > > +the bug will simply be handled in public. > > In this last paragraph, did you perhaps mean "not listed as security > supported"? Otherwise we wouldn't improve our situation, unless I'm > misunderstanding and word order doesn't matter here in English. In which > case some unambiguous wording would need to be found. > No, I think your wording is more accurate. -George --0000000000009b382e05fac78d41 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Tue, May 2, 2023 at 12:19=E2=80=AF= PM Jan Beulich <j= beulich@suse.com> wrote:
On 28.04.2023 10:12, George Dunlap wrote:
> --- a/SUPPORT.md
> +++ b/SUPPORT.md
> @@ -17,6 +17,36 @@ for the definitions of the support status levels et= c.
>=C2=A0 Release Notes
>=C2=A0 : <a href=3D"https= ://wiki.xenproject.org/wiki/Xen_Project_X.YY_Release_Notes">RN&= lt;/a>
>=C2=A0
> +# General security support
> +
> +An XSA will always be issued for security-related bugs which are
> +present in a "plain vanilla" configuration.=C2=A0 A "p= lain vanilla"
> +configuration is defined as follows:
> +
> +* The Xen hypervisor is built from a tagged release of Xen, or a
> +=C2=A0 commit which was on the tip of one of the supported stable bra= nches.
> +
> +* The Xen hypervisor was built with the default config for the platfo= rm
> +
> +* No Xen command-line parameters were specified
> +
> +* No parameters for Xen-related drivers in the Linux kernel were spec= ified
> +
> +* No modifications were made to the default xl.conf
> +
> +* xl.cfg files use only core functionality
> +
> +* Alternate toolstacks only activate functionality activated by the > +=C2=A0 core functionality of xl.cfg files.
> +
> +Any system outside this configuration will only be considered securit= y
> +supported if the functionality is explicitly listed as supported in > +this document.
> +
> +If a security-related bug exits only in a configuration listed as not=
> +security supported, the security team will generally not issue an XSA= ;
> +the bug will simply be handled in public.

In this last paragraph, did you perhaps mean "not listed as security supported"? Otherwise we wouldn't improve our situation, unless I&= #39;m
misunderstanding and word order doesn't matter here in English. In whic= h
case some unambiguous wording would need to be found.
=
No, I think your wording is more accurate.

=C2=A0-George=C2=A0
--0000000000009b382e05fac78d41-- From xen-devel-bounces@lists.xenproject.org Wed May 03 10:37:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 10:37:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529091.823087 (Exim 4.92) (envelope-from ) id 1pu9qu-0000m2-Ln; Wed, 03 May 2023 10:36:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529091.823087; Wed, 03 May 2023 10:36:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu9qu-0000lv-IV; Wed, 03 May 2023 10:36:52 +0000 Received: by outflank-mailman (input) for mailman id 529091; Wed, 03 May 2023 10:36:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu9qt-0000lp-67 for xen-devel@lists.xenproject.org; Wed, 03 May 2023 10:36:51 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20619.outbound.protection.outlook.com [2a01:111:f400:7e1a::619]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6919bb39-e99e-11ed-b225-6b7b168915f2; Wed, 03 May 2023 12:36:50 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by VE1PR04MB7263.eurprd04.prod.outlook.com (2603:10a6:800:1af::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Wed, 3 May 2023 10:36:47 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 10:36:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6919bb39-e99e-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cl5p12lIMh/AmyDfA2AnyabYzMVMLVngMTmR1PluzZT51IO9gh0e6tOaxQtHpu/Ln5FeQfIhupw8UUUAcd2ocXPFpcJKICd3/OpJkOxKgw+EajqslZ6B85EjLbfKDi0qxhlESdy9ZNvh379AwDw3Ev1+QGHc5jXx6F0tkRdWQM0brl5Xsyi4mE5w8hPOeGn0lY9IIf3OQBnH+2mWobljYEIxYGn8XSLIMEHEzvyBQZ0HS4x2r7lLWdnf04idUO1CdnjNtFnh/nUmZNHqpXi2uRuG3yUhTCwaS5rHI3yEKehlLrNWWp0FQKsHEDl2r0OexICJMqjvKWk3TzIKpwGBGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4hFX+X1sh+3XqbisDaZVyq/2N10sj1zXa+mjFkM1wa4=; b=NaFrp9Qe6qajzY7JOnA6XMU0Upv5Zz32xhKZF3vJz8TH+OeSzQdeqtR/Yrex3RQUFtC05hKMVJ81We3FVhmGiCu3dPI7sOrGoDK0VNRX9eU3N3KfevRGu+37BIScd8tZEEPjddiMxGu52o/2iO0yo5U28LuL0ynk18wmsiGIiaAwBBxse9NfS3frwxQUAaA9IMX/A+0BTJ8FAzVK8gOvQ5JADp2BQfH8BcT30cFMirnHpcx9lXXPkbG4AC6jCG9h6lxqgpnFSQoH1CEzszb53++vaB6FwIQ4Zp/XT2OWKkjzi7IfhKqMsTE+KmAU7DJt7Or+sN+x/c3LGZNFtYXDUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4hFX+X1sh+3XqbisDaZVyq/2N10sj1zXa+mjFkM1wa4=; b=S2HRuKQBn7OmsBGIvXdBWLLJTgFyyLR/ACxMX/HTm/kZ1Y7Staj0qAfm4SRZDomjZjKYvjv5+hFtGfb1Jto3Umf6fBy5z2Rg6a6fwTsMFxbgSfCadF/jqFEVKdfR1EsEWlBP3NonGqOmNifykpqmsRVJarF1jpbQ9iqqDW1CtFGJ+gXEue8XSBjeMUUz760YF5Wmj4lyzAt74AR+nqHVrIgVzuq7++Zv7UsqFu6lha0cP6apvgqBYiECmZR2xQKuWLBVO4gh1HYUhOxL6RD5k4dQlUNYavZ5uX0rWgLWrh4xsPckhLnP5P0Y6biVD1I4aqiadckTonvBtf57H3B9Rw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 3 May 2023 12:36:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Ping: [PATCH RFC] build: respect top-level .config also for out-of-tree hypervisor builds Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Anthony Perard References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0114.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::6) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|VE1PR04MB7263:EE_ X-MS-Office365-Filtering-Correlation-Id: 513571ee-53ae-47a7-4526-08db4bc24bb9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RWPi+bzsMpR58Ct8rKlP8TTg54OyOsiLk0oy03whHf0GKjkO26IGXf+/YY2gsWwh3peYgNL3yRIi2Q7PrEstBl+YwCezL3PKuGujwe7W0MyTEMHfb+aKkr0IOuSeW8/zPLEt1ZuhopBzlPGzIuH8UzTTzPvFjh65jcl3WObOjfK8zMC2CGkHj4vyN4xOjwCRmwRD4ZxvFPwvYsnpfgaXpm7XJ8BSZ3kQeoX3Qk6WAm3hL2HjiXnsDB9vQnpEdrCHfO6Yhg4h1xe4/nmPS45TUQTDg9fa3ekvcAg/MRxUXAiClkTybgRTsa9MUVhO7RM2X8oBeu1L0ouzqpnqoLfZM6WtxSEXRbyoiNhDKgCeh2RrEwZjiK1HD689C6dEOFzXlXNf/oaUgzHKxg+cb9FYshuR6wnyqAqqv+0Lgg1yC3fvCBexCbUPys9Z1WKuzb715eDfN5pu5KR6GPbHww5jLVqAMZFIHi/vF3mtkZRKwe1oYUO7gWwkeCV26vlZ4iFa4BKJSmGbmcZHPLfBy4ZrsdM90IJYgOJpGY9XVGvghna5e/pjrj/vpsGZCVZLMCQLgWYSrXNM/9I8XV9RDB2GX87f/28u5ZH5iDxAesFogs/18NuZ+DxsEwzSKCBZRKfd/BJKR56Tp5QiGzgeBqHAWyuGg8/cWqx892ABWAXNepG7Ze1ZZIAzI50a6GRmeWflH3JB3kKFIpyKzoSt3uSioGhWdqva0LaEdh+8lzmt6w8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(346002)(366004)(396003)(136003)(39850400004)(451199021)(186003)(31686004)(2906002)(38100700002)(2616005)(54906003)(53546011)(6506007)(26005)(6512007)(66476007)(66556008)(66946007)(478600001)(5660300002)(8936002)(8676002)(41300700001)(36756003)(86362001)(6486002)(31696002)(316002)(4326008)(6916009)(142923001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MUpaTVpTTWx1NW1DNUN1aE1mcS96bTNzY2Q5L2ZVOTc1TDlOdXpUTTJCQjI2?= =?utf-8?B?cm45c2dCcWdUTkJpMVdsS21ZcWU0ZHptcHUvbS9PNHNmUlVMSnNMOEs1N3R3?= =?utf-8?B?eWZtNFd6bUNMaEVWd2RNWUl2OTVYUVpHWHZzcUxOd0xRblI0SmxRN2xlbnhL?= =?utf-8?B?RFR1MllRcWx0amlaTE93ZXQrMElFUSt2OHUxT3ErcDFYWGFEV0M0VUlwNW5W?= =?utf-8?B?cUc4YU1SK2VkcXFJelNyM21LZGdCRjNEdXpzN2MvSlRQc1lNZU9zYXVoUU91?= =?utf-8?B?bXUyM3BqSDJFRmw4MmowUUp6ZFZZdFUrZU5kd1Ixbk8zN1AxQWViUi9NOUxB?= =?utf-8?B?a3cxdHdVbHhjVXRZVmxBOHMwYTVqTk9PV3pLaGpoMm9MRmR1cDltRnFyNG9H?= =?utf-8?B?VlVYbzNMNHZjT0JIMDVFRWlRSjJhUmNPZ1c3U2NDMWQvUTlGR1I3dFdDbFFn?= =?utf-8?B?SUZZWEh4ZFZTS3dGMDhmT3NLS3d1bUJxQ0JJYzNRZzZQd3Nsd2pYTURRNDU2?= =?utf-8?B?bUF0MGFZbytyQ1VELzJXOXl1ZnhYdEsyUnp1ZmZBRVltNkpGdlM2TGdBaHp3?= =?utf-8?B?VHBONkI1QlNld3M1WXNmaXNic1BCZU40OGwzL05jZitHK0VqVStxVnlWUVFr?= =?utf-8?B?bCtZVWE3YmpsemZqRXB3eUIrcEdjb3FvNWNiNlMwTkkwWVA0SStvYVFIVzhT?= =?utf-8?B?bWEvMGF1VTNWRUhOVElyR2dKUjA4L0lYWWtFdWxmbXp4YnBCbWRielYyd1E5?= =?utf-8?B?TmU2cElwa0VmdGxhdjhydnlzYWxSTExKdjRXZzdQNXZLL3REMmtsWDlSRy8y?= =?utf-8?B?THozTjFKcSt0VXRIcXEvSUtSaHVPeEJXMmx0T0poRThSRklMbENFTm5zbnZX?= =?utf-8?B?ZDFreXRsRVozRnV0ekJ6bWhNWmxZMFFjcHNNeCtIZzgreXZDWVY5VU9yeTF4?= =?utf-8?B?TjJWZ3Q4ZTVZL0VydDQ5elI1Zm5LYkpWc3cxMnpIWE12RUJnUUhSQXlkT2c2?= =?utf-8?B?em1JQVU0cjhzM0hQUXZJM3RmRFM5KzFnenkrRGFuRnh6SER5TXgra2E5YktW?= =?utf-8?B?RUQ5SnpISUtTODJPM2RDVWRiQ05melhQcFBPZmQ4aTZ5TU5OcEVlZWdoQVVx?= =?utf-8?B?OGg2U0NpRkltSVlmMzArMy9mVkVCL0ltMjZsVlJ2Y1VEUUVjclVJajJVU0Rw?= =?utf-8?B?WDFXUEhGRnZyNy9oUnNiWHRVWlBHOEZEYVRZS3J3WVlFTWZuRnFjRkFQL09L?= =?utf-8?B?d0hGbVNhUDlqdWtmcXh1azhSYW16WDBLUjM0b1BBSUhjNFpyVzZNM2dFa3da?= =?utf-8?B?VlFWUE1hYWRzN21aZTlMMXE0NStvcWdGZ1k4aEFQeDl6Y2FWcFp2VkpsWG1p?= =?utf-8?B?dTNEQ1FueXRYREEvMnNSWGxxeDhrMk5IRVdWb3VwajFZME5jNkE3YlV1VCt6?= =?utf-8?B?U1ZQQ29GdmJOMTB0MGZBeExMR04xMDIzTGxrakc5bXJ1TFdHYW03eUg5d09k?= =?utf-8?B?czRBRjBRRHRpNENiQ054di9VWmRnQ09paHhMZ3poMHMyV3JkbTd1SytDY3pU?= =?utf-8?B?Nm9GMkhEazFva2FabmMzSmZmbTBoUkl2QlZwMGptNDVtY2lTV1QwMHpyL3hE?= =?utf-8?B?QkN0S3Roa1puTGQ1clFhOEMzSk1tZzB1TU15eVJhdm9zTENLcWlYSklMc0Zw?= =?utf-8?B?T2JXdmxheURrS2ZUcU91cVh4NFVWRk92dTdoMFkraVVXdVREaTQvazFOUGgz?= =?utf-8?B?dXhvU2EwVlRjaVR2QnVRYndjK1pIOTJWR2RZQnAvajdTZ1d3cmhLWVJkMS9B?= =?utf-8?B?eEl0TFNBdjlGRGMxTGNac1NneDMwWjgzQUQwMURnQk5jTWEyelFaRTNldHJP?= =?utf-8?B?SDNoU3Z4NFBDWnQ3ZWpVN0puM3N0NGlkQjhFSFNyV3krQTRZWTNsT1Z4TXlJ?= =?utf-8?B?MFp2TnlGUHBHM2tnY282S2Evd2ZlMEJDNGRVNUlwWWZEeHppQldlbFUwYjha?= =?utf-8?B?K2R0WC8wL2FLWnlQc2t3VitRMzNxRTZPQSs0UGhtYms4cjl1cHpGL3VIMW93?= =?utf-8?B?dm1oakh5b1R1dHc3S0xEa2hIaEtBNWRVaEVPampaOWc3K1JkcjU5VDNxS1pm?= =?utf-8?Q?3Wb22EHlKeyJHwGrXd9qdPvOC?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 513571ee-53ae-47a7-4526-08db4bc24bb9 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 10:36:47.1327 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: f6eZUv9EpTvJhEpWvi3jxyEup6Ia7GgquzBLg9bQlon20oKn9v4aUOupgHDw0AJZzG9w8SsQW9LrQo8gQwapDw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7263 On 15.03.2023 15:58, Jan Beulich wrote: > With in-tree builds Config.mk includes a .config file (if present) from > the top-level directory. Similar functionality is wanted with out-of- > tree builds. Yet the concept of "top-level directory" becomes fuzzy in > that case, because there is not really a requirement to have identical > top-level directory structure in the output tree; in fact there's no > need for anything top-level-ish there. Look for such a .config, but only > if the tree layout matches (read: if the directory we're building in is > named "xen"). > > Signed-off-by: Jan Beulich > --- > RFC: The directory name based heuristic of course isn't nice. But I > couldn't think of anything better. Suggestions? > > RFC: There also being a .config in the top-level source dir would be a > little problematic: It would be included _after_ the one in the > object tree. Yet if such a scenario is to be expected/supported at > all, it makes more sense the other way around. Anyone? I'm certainly okay for my approach to be rejected, but I'd like to see out-of-tree builds to reach functional parity with in-tree ones. Jan > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -236,8 +236,17 @@ endif > > include scripts/Kbuild.include > > -# Don't break if the build process wasn't called from the top level > -# we need XEN_TARGET_ARCH to generate the proper config > +# Don't break if the build process wasn't called from the top level. We need > +# XEN_TARGET_ARCH to generate the proper config. If building outside of the > +# source tree also check whether we need to include a "top-level" .config: > +# Config.mk, using $(XEN_ROOT)/.config, would look only in the source tree. > +ifeq ($(building_out_of_srctree),1) > +# Try to avoid including a random unrelated .config: Assume our parent dir > +# is a "top-level" one only when the objtree is .../xen. > +ifeq ($(patsubst %/xen,,$(abs_objtree)),) > +-include ../.config > +endif > +endif > include $(XEN_ROOT)/Config.mk > > # Set ARCH/SUBARCH appropriately. > --- a/xen/Rules.mk > +++ b/xen/Rules.mk > @@ -17,6 +17,13 @@ __build: > > -include $(objtree)/include/config/auto.conf > > +# See commentary around the similar contruct in Makefile. > +ifneq ($(abs_objtree),$(abs_srctree)) > +ifeq ($(patsubst %/xen,,$(abs_objtree)),) > +../.config: ; > +-include ../.config > +endif > +endif > include $(XEN_ROOT)/Config.mk > include $(srctree)/scripts/Kbuild.include > > From xen-devel-bounces@lists.xenproject.org Wed May 03 10:37:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 10:37:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529092.823097 (Exim 4.92) (envelope-from ) id 1pu9rK-0001E4-TD; Wed, 03 May 2023 10:37:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529092.823097; Wed, 03 May 2023 10:37:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu9rK-0001Dx-QQ; Wed, 03 May 2023 10:37:18 +0000 Received: by outflank-mailman (input) for mailman id 529092; Wed, 03 May 2023 10:37:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu9rJ-0000lp-Cu for xen-devel@lists.xenproject.org; Wed, 03 May 2023 10:37:17 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2062c.outbound.protection.outlook.com [2a01:111:f400:7e1a::62c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7927021c-e99e-11ed-b225-6b7b168915f2; Wed, 03 May 2023 12:37:16 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by VE1PR04MB7263.eurprd04.prod.outlook.com (2603:10a6:800:1af::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Wed, 3 May 2023 10:37:15 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 10:37:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7927021c-e99e-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=idqv5qDC/nh9+ZeiUrkDV/6iHDBR6RPMZzuH+pFEz/2GqMoF2JjXAjyld6VtXNWENIs/q5Tzaqj/G9J6gpq6hj1ujLYWHuNWD43ZmZHzqBBdu3JAj9po/RSJAU6wPlGso6MCxqGFyHL2GkWwffp6sFWyoCGv02In+aMMa0RZ5RlNLBTXW3abXQdRICf+GNMv03eCRwCM29DSapqstk4E383u5+KibZWZzsFVygrU6lbPBYB1tTE7XVWcWFLUUHIr3TkCuy2ExIdFV5miNa865CZVOe1b18wDgxieyolMnapZOZLFLNTjZ5cITDmvqiBL15b+T5aXgJvzkH+xXnKqrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cHBPuULj0Sa/v+7ugwG02mbs8ZvG329LJjK9HhyCgLY=; b=i+Bz2/o/7zyAbvnZ1KeNETh1WQ5GynvW8NwZg+uoV8h6Sl09ydRpMEyEqyTAdhuS3UYKrUh6iIVcYSuTh80lxubHR8M5eiaNwM7iMObNFXufZv5Fu9f6XlAvWByCorDyL2nl/qA+6LTXzBarljSbJDeUDMjdCyBEJVoWerfUEfe1dqHLTCdev1IRj3U8XkdfWFqqdQcE9gJWqdvmfWi2HsmpxtTK/mzy+nMSCc+Brdngw1xkDloxSx1lm3K6S3YipGobCr7twTG1VpvzF+YEM8B3NDyZMmu544sVr+GTDdLH706/1HHf9HtR8MGEZhx50Kf7H4KCbVFDN7NbWbKYvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cHBPuULj0Sa/v+7ugwG02mbs8ZvG329LJjK9HhyCgLY=; b=Ut0w9EP1qB83gfS95dE40C5K83uHoTo35rejFPXI3sPuwOOaiDuAQfhtPkLMGFySPXhsbo5oKhjH1O119CysKeldtDvQ0qAdibcWf0CDKhBkSW6xsUPKO1KqOv0TV/dpW8lZ1kIbShTL6xcoJBELdqwoD5xnmayfoU1SqUyTaslwJPWPEt15WuIWHTGBTZHu7KIhxTVLZbwJcWxBbY7RWYn4Yx+sDd6izZHwOiDRG0DYLgygXP+SUakk8vzsVRhjJ27XWyBA/4uyWXHnSxGp3hrpMfpkRYSorySv+L0a2G74SDrswBWII5BAZBkMFtu7swBwlWBami5Vph5n9CjOZw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <594ca301-8f4d-83ff-3de2-a68741767bb2@suse.com> Date: Wed, 3 May 2023 12:37:12 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Ping: [PATCH v2 0/2] build: out-of-tree building adjustments Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Anthony Perard , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <2e3c8f9d-8007-638a-c88b-21ad2783d8d3@suse.com> In-Reply-To: <2e3c8f9d-8007-638a-c88b-21ad2783d8d3@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0114.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::6) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|VE1PR04MB7263:EE_ X-MS-Office365-Filtering-Correlation-Id: 2425850b-2cfd-4ae7-56f6-08db4bc25be6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h0OUC79i62Nq6BVvA0enfoIXZ9pEVFDvjWjAmtu57Alt8YVrxHRRdQkp2e3jmMJYTtHYoI59xENtnK0AxuIOOkG1PiB0YYpn99E6b3V7i/h6Z8w03W5EFCbSNPnDh0xEVImsc/zl+FEexsGdi2vrcXy9w1oovEME3m2RSvwNL7D+S8vS02Eo9Wn2BBGfj9df/N4AmYNpTZ1S9T0WCa8EtUJqLa+PD+YK9074yly2zYVjSlss37YhM2Wnv06AvhFFiTIdgP6ZDH+rqx6l+qb+CdCuS33Zvi1iijcOv07cgf+VE7IHOU3eIKIxvrD40zyIY1CDmcXdRfNsbBh80gE9IHEerrJH7X5VDoj0BazjSaNEQqr3Odo7nWYyGRQLMKBN2EjuWPu8opIxHkAafYdYwp+tvn/C16YdIFNzmgDjclLOEwlALMdoIcL7Ar3wBze91IMfH6V5KqPQWa3unqICWfkyFw/yC+WEk7xBnhVZt2uBxzcDyZ4r0h1z+yRCXyIDabZTjdSxW9G3F9aa2T0nRpwP6Psq4BVCLvwKzH0F16+9mzYayBSehaWaNI/8VuIqGCqPWJC0tUmqWuPkhz1fCRvR9I32OWrNvflrg3f92VrcxTAa28IhfgQi3aUpS9aEgEdZ+ZL5puFDpn0KI23aNkDgA14A1Y+v2xv9VShHYAu/eE7iJui6+QIhrto0PWMOFSVk5VoK8fYmAHVmpK4X4w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(346002)(366004)(396003)(136003)(39850400004)(451199021)(186003)(31686004)(4744005)(2906002)(38100700002)(2616005)(54906003)(53546011)(6506007)(26005)(6512007)(66476007)(66556008)(66946007)(478600001)(5660300002)(8936002)(8676002)(41300700001)(36756003)(6666004)(86362001)(6486002)(31696002)(316002)(4326008)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WEJpNTZRQVpoYTk1ZWZJbFl5WWIzK2pTOVRublRqYXhvZ3J5NkFBWXljYVIr?= =?utf-8?B?OWNYT2drQVQzMUZ4WTBGQ2hLYU5QdzdBYnBXaVI4NWRZMXRKZ29ZL3NDbm01?= =?utf-8?B?Rlc5MmZVWDZzVEZuQnE5dEpDYmxoL0FzL2tYSUs1REpzYWdTUS9LSTlPdzYr?= =?utf-8?B?R1V1cGN4bUdlS1dIcGV3OUJkeW1rSTdocjIvOWZjaC9xU2lLNncwcW8zS3pi?= =?utf-8?B?TUk1eE9QYXBxUER2bGhkUEpYSkhoSE85SThoWVp4SE1IUFFGbk5WOFhla3BB?= =?utf-8?B?MnFxUG5rZkZuTWV6SUZwemRPSnMyVTl4QXNxMUZiZXBQbmxQTS90cDFyNW11?= =?utf-8?B?KzJhQStXR25ya0g2Ykx2MEltLzljOFBYQW1HV3lTV3p3NTVaV2VZc3lzYzBu?= =?utf-8?B?RjhZNXhaZnNlR3NHMVN6VFlQQmg3eWMwTEZCWlJkNXF6Q2lmWGVxL1ZxNmg0?= =?utf-8?B?d01MTEhXUWwvc3IvaGdIWXpuMDVpOVZKQVVKVzB3ZWxONFF3eEUwaG9rcEFl?= =?utf-8?B?NHVpMW80YStHcmxiR3EzUXFhZUpjRENRdDd4WUxhdHJMVXJPUVdiQlZiM2d5?= =?utf-8?B?L1l5Nldad29lYWJYL3V1R3BvcXkzMlI3cFp3eEtqczJZanpIMTJJZmF0RWYv?= =?utf-8?B?NWx1bjFlNXFxd1E1cTNsakRnUWtkYUF0dm1wUWlsSUtYeXI2WkRqTDZLV1p6?= =?utf-8?B?MEhSUktQUVJIZFVkZDBDU3lwQWIrZXhScEFOejRIS1dCYVJpUHBZL0VKTkx5?= =?utf-8?B?MEloMVZYZjdBd3VQRTFQOU1uY2dOOVZSZVNKYzd1dDdvVGVsYmd0VlpLZkRG?= =?utf-8?B?US90QTBjTmk5YzJESnVFMjRaeXhoQVNZQ0VzM3doZlB5SFFtb3c1cUlKMGpY?= =?utf-8?B?MVc4VUdWMmthYWU1TU9hcGFOOHkrV2dMK1FzZUV0N0s5YnFidTgxRXNiUmp0?= =?utf-8?B?aExoUmV3MVA0b3JLZ3dhS3B6TXc1U2JQY3A5aEdqVVZCOW1aY0c5QVlKRThQ?= =?utf-8?B?bXRQUWFkUTlURTlEbC9rQjZTRFRHZlI5K1Q0TnErUTRZNUFTb3gzelA0OUVR?= =?utf-8?B?RTk1YXlCQUtodGNzVDMwZTNkQzZ2OFpmOHNiSGRMU21sdVdvdXp1dy9RaUtk?= =?utf-8?B?TzFLTEh2U25SRmxDd2MydUZOODVQRktQQTZXWkxrd2R5TVV4dk81RGtjVXRE?= =?utf-8?B?WHdpZlhnVzZGTlFDWVRVSWp0SXdBeDJadm5kbDRjVHBheWxjNWw1SjRudTFU?= =?utf-8?B?dWV3U0c2MHNYL1l4KzR5VU5xSlFqVkwrckJsSDVIK1FBcEVYSlVVYm9uVk9u?= =?utf-8?B?Ly9uS044Zkt2Zkw0eXZ4Rm8ybHNZZ3hQVW1XeVB3d3hLS2F1YzJDd2lXMWI1?= =?utf-8?B?SlN3WVR4ZUxlcHhPc0tHN0RuclVBSjJ2V2kyTkNNQnRHNExrekpSdWtQZ3pZ?= =?utf-8?B?SGozMkYvdHRMcVVad0VWUEhTUVBmYThmcERrbXcxeU9CcHNKdDd4VEtNaG5t?= =?utf-8?B?cjY0RDVwSUN6Ykx2dXJpMHcwbU4rWTJwOE1GT0FMbWRwLzZRVmNodHdVZVlX?= =?utf-8?B?MmE1ZWZmRk45MGhMZFFyZkdZU0c3MGVXd1kraDd6Skl0b2tPS0NhcTZXZWNV?= =?utf-8?B?cDZZcmhwWU50YTl4N2hVUDBwbTUwa25PaTNUdFJqTUFrUVJiemQyTGJxc2dk?= =?utf-8?B?U1NUR3orWTNRUUNiZ2xscE5MbWlybkFyb2U0U3V2ekhqMDBrbHg1U1V2L2xz?= =?utf-8?B?TEFIdkFuTnEvcy9Kd2V1Y2hQUGRBR2F6Y0tUQXZkc01mSDArRnZyenRRZlhU?= =?utf-8?B?QjRkb0E0RHQwWFFnaWovYVJ5SEVIQytTeHZwTGNEejI4eFp0Nmh0a0g5L0hu?= =?utf-8?B?MnN3M0VkL3FjdjdaRTVDbllUcEN1eEhNdVNOVG9xMTlvNnpPWHk3YnlZSWhM?= =?utf-8?B?VlV4SXpsOVNxU2pEWEk4SjFXM3JEeHd6WDB2R1drL1hCSktwWlhsTCtqa0J2?= =?utf-8?B?ZjBWQ3FVY1dpN0YxNmpaUVNadk5pL1hDTk5ndzlXTGtEcXhBTWxJOUpMVXRZ?= =?utf-8?B?RVVaNTcwa1BNclIwRXBTWWhRZUVLQ0IxWk5nNEg4WHhwTnNvTU0yYlBwQ3BQ?= =?utf-8?Q?KJJBcmem+OmjmlRg9bEub6MWo?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2425850b-2cfd-4ae7-56f6-08db4bc25be6 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 10:37:15.5031 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ydnn68yUoyKjAoKp3Ov7CzEhE9YaBcL9xOuM6J/CFAX7MgOkHznLwv8NjBbWlz3S3dvN/UrgebWxnl+p+N1fGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7263 On 29.03.2023 12:20, Jan Beulich wrote: > The 1st patch is new, addressing comments on the previously standalone > (and unchanged) 2nd patch in a way different from what was discussed. > > 1: don't export building_out_of_srctree > 2: omit "source" symlink when building hypervisor in-tree Ping? Thanks, Jan From xen-devel-bounces@lists.xenproject.org Wed May 03 10:39:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 10:39:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529097.823107 (Exim 4.92) (envelope-from ) id 1pu9t5-0001rg-8T; Wed, 03 May 2023 10:39:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529097.823107; Wed, 03 May 2023 10:39:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu9t5-0001rX-56; Wed, 03 May 2023 10:39:07 +0000 Received: by outflank-mailman (input) for mailman id 529097; Wed, 03 May 2023 10:39:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu9t3-0001rD-Mw for xen-devel@lists.xenproject.org; Wed, 03 May 2023 10:39:05 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20624.outbound.protection.outlook.com [2a01:111:f400:7d00::624]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b98a52d9-e99e-11ed-b225-6b7b168915f2; Wed, 03 May 2023 12:39:04 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by PAXPR04MB9708.eurprd04.prod.outlook.com (2603:10a6:102:24e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Wed, 3 May 2023 10:39:01 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 10:39:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b98a52d9-e99e-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BzVtkFcvkJS5xCtCqy2zTZ2VXEXAnRmdJUZvJHuuUYhHX9eI1MitKhYYEVcSztQ55bILvtyyArMegJgq0Qrw06yjYrU009ITQtHxucF4cY9CRc4UreZfgnO/g3mrGVl5Uxfcq1An3Odd+xXRAN2L31PuuG7FzkZRzeiJq6Z0IL0sMYxIePVL7PvGCa8+cX7YfTU4b7HbOpSHOUN82X96RGvJYaugoVK86oCI+nC9Re65bhU8+iuTNUKAvuiqn/3ir9Cel2/8MIenH8dZ2h+r+ih4kzODuEzGMPj8oRo77vsk0KJAYpaplhyK06oyXgmbpoMLUvItpYk8uPU5MJeBpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YZnJA7uwg1W9CXtAacAnccV/fU/ZKdDe4hNxkcvkVs4=; b=UIPi1G/GnNoI6W31ZtyQIbYCusztGPgVuqOqNR0sXYTuB1vT0pgUoyOeS7IzYH3HFP97koD4DNwc88GEldTUb++7KtWVJPbdBBv+28ce4APZXdwnhYXMa/TbJfUARa7tiXpGcDESCQJDrBi+sjR4NuonM1D3j+m8OBEYGN4cF/s+0dneAPFMzaps6pg2LMDGXM0pmZdIIQCrToAkd0RhrUput9nKYGBIvYqhBDMD9ylHy1mU/H1eDwv30HXYvCQLuseKHbXThL5Yhy37pIge9HNxqT1+N540SOuX4ljrJhS7RH7OwZxDOtbPCCMbjk2GHycmWTJ5xkI+eELa5iowdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YZnJA7uwg1W9CXtAacAnccV/fU/ZKdDe4hNxkcvkVs4=; b=0OLzElqy49CTs6nlUt9j+KyM+bhE1oSs5kJ5jbMs41J3kC8Az+zU3yy0o+l82K+8cwhTyORRInIjmtRiRAfAqC2+jzD4x0zgtePxAGn6wqmVASq2HSRlsULVWWIuEapV5aGsA/9Lp+zWUllVlsSlY5fxN6CFn1X2JE0zNkIAI4pl9B/0P+URwWlp9+zUvuyHobaWlmIh4qsKaoEN6+JqrkP2QyfWMuL4ikaIEKOJFfbEQ+GcyH/GHOSJtq/ribdgyQHUcNorcdU3UevzjmP2Ys6OtvjygHmqotV/d8nD6KNcSX53mOMMWqWJg5eV6eGi86BNTvp6w8tZId0JbMpn0g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0820220d-a500-7920-3630-eea074856e3f@suse.com> Date: Wed, 3 May 2023 12:38:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3] xen/vcpu: ignore VCPU_SSHOTTMR_future Content-Language: en-US To: Roger Pau Monne Cc: Henry Wang , Community Manager , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20230419143155.36864-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20230419143155.36864-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0208.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::18) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|PAXPR04MB9708:EE_ X-MS-Office365-Filtering-Correlation-Id: 902caba1-e3ce-401d-2298-08db4bc29bb8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qslPK06QJaDlZ6v06JV5tA0yzaoyi0+tJ0TXinklQOSqKxrcI7n7oDPuf2RyvZ/pd+ZedzVXhhBMh4PfXwPd6uPxdbhW9VJoxnYWEaSHwiqOsCIdyQahBpMLOI+eE5p1HYKos73PPawjaG2NzGfaHcmByJCaisrIwFBt3b2PUyp9Wv37mvFuM7dSWzO6yZmXS/jxhP1ZH0Hh+gvfI6TfqtOL8OSPSj+kd79dhajm07RC0ScPTUYjxz19pvOHZwpUBOxetWN3DmOOsi8n6Y87vLZ9T1pkf7y9+PC7dWr2K9ltqGXidFXtoDalqhGrOaFTpvaKKwPKb4pD9vAbmhJ2WrR2Hh1F25dD9bhBr4SSsuFQZeoHpqt8B1svFI/OeHD4nQpa+v81aj5Om7bWOHnX99MOf+zZ9Wxe5fdereDG9eppx3YS/ucz7i92GBcFyFShjyxNzeOYsOyMv01iiG+eFXFVD3OTsYqPNkJRcMWnnRICwhHuTBDc6xZyrwfIKpNZUzd3OIz2w+NShH6nMMAdc0xx0vrnHhwDwmyVQMsCZjyiUhIDflXTpu2MQzOCjSv84tRWU6PqxaldFS7b8ngye7JCTx9gs8NeMsoSqGcMsICB2gtTt9Xp0RpS1KdlKSNHXbsskc9MeeOl1rCuUA+aBA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(39860400002)(376002)(136003)(366004)(346002)(451199021)(6916009)(66946007)(66476007)(4326008)(66556008)(316002)(478600001)(6486002)(31696002)(54906003)(36756003)(86362001)(186003)(53546011)(6506007)(6512007)(26005)(5660300002)(2906002)(2616005)(31686004)(83380400001)(38100700002)(8676002)(8936002)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmFISG9HcDRzRkl6Znp6d0tJcDllek9NS0VjVmZMM1lxbGJYVEtudGRFME4y?= =?utf-8?B?bkdNRDh4dHQrdy9wWGRpUkJoYmdrUGZ6dkZ3amV5VXdDYTRTeXNxemROL0FN?= =?utf-8?B?REYvajFLV2M4N1dLZWdpd0ZGMW9oK0Y1NUJHeUgyY1p3K1F1Z092cWxvNXBw?= =?utf-8?B?RWhpcDZ0T3BpR1NSblVNQ0YxVXJnUi9wVXZFZFJpbzhzNE1MNDRNN213bHc1?= =?utf-8?B?V01VcktmVlF0blc5ZSsvMzFuSm1wL0V3ZFlGNmRWbkFMV1gzSlNINlU5c2tm?= =?utf-8?B?cjBGMnEycUJBc240Rlo3Vk1GNXNvY2hpNFpYc3E1UkdnNENSSU9oQ0xHUFhB?= =?utf-8?B?ZkYydWU3L0l4RG9HeWtwbVc0R3JtWUN5Y0R6TXNtOXMzRHpqd0pQck5wUzdx?= =?utf-8?B?QjlrNW9Ka0daaFdwdlk0dFNaRUJLSWpLT2hrSUZPbFIyekdEMjczNzVQYWlN?= =?utf-8?B?NEpLL2loa1J1a1hSczFqaDU0VTd6c0QvMFB2WEdnZm80THBpdlNuWU42Z2pK?= =?utf-8?B?YUNsaUluYmsyanJHV3BBQWxhM00vQjhTRjdOMnhkRHh3WEFKYTI3WWdXMmxx?= =?utf-8?B?c1Qzai8vWjBxSEYyeloyTmpYR3UvblVBaWQ0cnl3bC9EVHQ4UFJXR2NDRkxB?= =?utf-8?B?NVBhUXJNTFdRbDZkNU9uMmpJamEzNWN1M2VVbWlSZXBVNHhFTW9uZGZaUkNO?= =?utf-8?B?dHpVSUFuc3A4NjRKTmhWamFLMk9NS3VnTmpVUTFWTE11dkd1ZG5VaUVWRlU1?= =?utf-8?B?c21CUEJnQlc4K0xhTTYrbXk0MzdtM3dVSHFtOW1kYWIrVUV4cG80NVJqSTVO?= =?utf-8?B?RHdzYVlkMGFZbWFEekFVMlBGZTM4R3V2TVFLRWxuWnBKMlQ0bEJnY2YxLzJ2?= =?utf-8?B?SzRIbU5HMVJlbTd5Wk84eWJ0eU9FNFJtUXhVbWhzeU5QNnNVRmF4Y2JHR1ow?= =?utf-8?B?Z3RLbU0va04rcS9aTktoOVpJR1c4NnM4WUw5ZElVNmVIaDhSSkRzVTk2Y0VC?= =?utf-8?B?cUZwK1dUVldQc0h5R3h2Vm9LUmZsUmpoWm1kRlhhQVVCdnY0NVk3K00ralJv?= =?utf-8?B?OTJUYmNkV2grbk5ocWMvNHZMeGRuR1hkVjNVMG1DNGx3eGZuNnRLdnVPR0JY?= =?utf-8?B?S0xXZ04vQUxwNWZIMXB1Ym1VWEU2bUU3WWRQVHltMHhaL2s4Mk1KcmtiYkQz?= =?utf-8?B?ZTZuNVRwNE4yRGloQ09SUVpKVVZNVVdRaGFCMEhFUDhTa2NhMlFvT3hvZmtP?= =?utf-8?B?NFFsSnM1L1pKa05sbHBMZ3ppT2hxUWNSRDNOMEtaZWZpbHVvOGUvOTVDejVC?= =?utf-8?B?ckpjQkR6cXJkaUwxTThWZTBhYWFUZDJIVGxqTlY3cFBnTTR4VzVTUGdxZmU2?= =?utf-8?B?MlZJVDFDaDVSVFQraERsNVZKcmloVEs1U2w0WWRTZ3NEcmZKR0lVSWo4N2gx?= =?utf-8?B?OFN1RHNkS0hqaHhZYk1rbHFBbUVNYUhsR2wrc1ZaWUlBWUMzSGJHc1poL0R1?= =?utf-8?B?dkFONDY1bi9ONHhiQWNRS0JZT2JYZDNPUkNjWTBiM1lYemgwMk1CSVlMUzFx?= =?utf-8?B?bTlRbUV4TEkwSTdGWGdHdzhad0NrcWZCdzRuMysvd1F5TTIxaTJUYTdoalFq?= =?utf-8?B?ZUlRRDBhUDVTanV5U2VSbUIzaFQ4R3V0aDhwNnh0dmlIanJMVFBFQTRNcXNv?= =?utf-8?B?NjA1NFhBSVVIQmJMUGNFdmM2anEwMkJMUTZZQklZOFpHQ291eDdCZCsrUWpE?= =?utf-8?B?RWVabUNnZ3ludEEydW5rS2NvR1Z5RytzaHlEK1l2OWpVbGFldVo4OFEwWFhi?= =?utf-8?B?RWRYWmIxenhSMkZSSnVJa2M3Z0dQSWY1anF1OXY2RjRKM3Z4OUpubkV0R1lZ?= =?utf-8?B?bUl2Sno0OXZjYmpGZm1RakszdkZzVnExcHRZdHFmWkpLU0NNOXltR0N5S2Y5?= =?utf-8?B?T3JZSjJTaStNbnlYcTI2ZFRYRmpDN2RhVllsT3o1bjk2NEVPWnNueVp4Njlu?= =?utf-8?B?WlUxOWMxVnI2d0k5aSs0ZWlZajhZaFQ5YmdBQkZpeTYzaFZ4TW9iOE5oNnhp?= =?utf-8?B?Z0VnSnFWd1NaNWdaRU16V1lNcmgyQmpGdmR1dHdBbkpxcmNEN1plT2t4Nmc3?= =?utf-8?Q?ZGDYEyhEmojWzes4mPsnHQPAf?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 902caba1-e3ce-401d-2298-08db4bc29bb8 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 10:39:01.3511 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J3mTB5ptPPKcCTVhZqlzKq9sP29OINTRcHV/GAGE8xY6A56Pw1WcH7OEVwoSPB4V4918kOwHGFRshHNw+2hvWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9708 On 19.04.2023 16:31, Roger Pau Monne wrote: > The usage of VCPU_SSHOTTMR_future in Linux prior to 4.7 is bogus. > When the hypervisor returns -ETIME (timeout in the past) Linux keeps > retrying to setup the timer with a higher timeout instead of > self-injecting a timer interrupt. > > On boxes without any hardware assistance for logdirty we have seen HVM > Linux guests < 4.7 with 32vCPUs give up trying to setup the timer when > logdirty is enabled: > > CE: Reprogramming failure. Giving up > CE: xen increased min_delta_ns to 1000000 nsec > CE: Reprogramming failure. Giving up > CE: Reprogramming failure. Giving up > CE: xen increased min_delta_ns to 506250 nsec > CE: xen increased min_delta_ns to 759375 nsec > CE: xen increased min_delta_ns to 1000000 nsec > CE: Reprogramming failure. Giving up > CE: Reprogramming failure. Giving up > CE: Reprogramming failure. Giving up > Freezing user space processes ... > INFO: rcu_sched detected stalls on CPUs/tasks: { 14} (detected by 10, t=60002 jiffies, g=4006, c=4005, q=14130) > Task dump for CPU 14: > swapper/14 R running task 0 0 1 0x00000000 > Call Trace: > [] ? rcu_eqs_enter_common.isra.30+0x3d/0xf0 > [] ? default_idle+0x1e/0xd0 > [] ? arch_cpu_idle+0x20/0xc0 > [] ? cpu_startup_entry+0x14a/0x1e0 > [] ? start_secondary+0x1f7/0x270 > [] ? start_cpu+0x5/0x14 > INFO: rcu_sched detected stalls on CPUs/tasks: { 26} (detected by 24, t=60002 jiffies, g=6922, c=6921, q=7013) > Task dump for CPU 26: > swapper/26 R running task 0 0 1 0x00000000 > Call Trace: > [] ? rcu_eqs_enter_common.isra.30+0x3d/0xf0 > [] ? default_idle+0x1e/0xd0 > [] ? arch_cpu_idle+0x20/0xc0 > [] ? cpu_startup_entry+0x14a/0x1e0 > [] ? start_secondary+0x1f7/0x270 > [] ? start_cpu+0x5/0x14 > INFO: rcu_sched detected stalls on CPUs/tasks: { 26} (detected by 24, t=60002 jiffies, g=8499, c=8498, q=7664) > Task dump for CPU 26: > swapper/26 R running task 0 0 1 0x00000000 > Call Trace: > [] ? rcu_eqs_enter_common.isra.30+0x3d/0xf0 > [] ? default_idle+0x1e/0xd0 > [] ? arch_cpu_idle+0x20/0xc0 > [] ? cpu_startup_entry+0x14a/0x1e0 > [] ? start_secondary+0x1f7/0x270 > [] ? start_cpu+0x5/0x14 > > Thus leading to CPU stalls and a broken system as a result. > > Workaround this bogus usage by ignoring the VCPU_SSHOTTMR_future in > the hypervisor. Old Linux versions are the only ones known to have > (wrongly) attempted to use the flag, and ignoring it is compatible > with the behavior expected by any guests setting that flag. > > Note the usage of the flag has been removed from Linux by commit: > > c06b6d70feb3 xen/x86: don't lose event interrupts > > Which landed in Linux 4.7. > > Signed-off-by: Roger Pau Monné > Acked-by: Henry Wang # CHANGELOG A little hesitantly, but since no-one else appears to show any interest: Acked-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Wed May 03 10:43:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 10:43:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529101.823117 (Exim 4.92) (envelope-from ) id 1pu9xL-0003NH-TW; Wed, 03 May 2023 10:43:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529101.823117; Wed, 03 May 2023 10:43:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu9xL-0003NA-Qc; Wed, 03 May 2023 10:43:31 +0000 Received: by outflank-mailman (input) for mailman id 529101; Wed, 03 May 2023 10:43:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pu9xK-0003N4-KB for xen-devel@lists.xenproject.org; Wed, 03 May 2023 10:43:30 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on061e.outbound.protection.outlook.com [2a01:111:f400:fe0e::61e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 56998652-e99f-11ed-8611-37d641c3527e; Wed, 03 May 2023 12:43:28 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by PA4PR04MB7711.eurprd04.prod.outlook.com (2603:10a6:102:e1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Wed, 3 May 2023 10:43:25 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 10:43:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 56998652-e99f-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=btIpTBakCJSSCiuxUHE3FTP+qS5cGuyPWFYaoqDxenWoWTA60zqkJcy8u7OeWu0AIiLfos9TGcMlp40IwsXHaRntt6s4BsnjrZRA3tnfV9IYX4iivVnd/AhaIGbf7/xnPT4djGrA+pxMAmau2eHND0hG10chn/bojj4Zzr9V1QyPe27hyG84GcZSEeIwg1hQeNEVi+2B+yPoytYDIr558910D2sRYgyBPPfPzwItwbdAbhMzKw1Vwg7nMkT+wV5g9pn7tn8SeF5ZVN19iKgEYo28MKQ7BlTQgTV29SugVLsxU4NWDFCKo6/6e8RsYiIZMnl72JJQQgbR3G1axyR1iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tw0s9+B+lOUlPzGuqqHZc+BliG9zWYxRoLru8awX5BU=; b=dEYtG6yHF8kJH14ULqSWjrr99kgp27zP+hYWqB8vwUCWVq6IJv6kM3BT9Lv9GQmXzZGBmD5Kuz+giezgclhLfErhlvcxV/LtaYC09GqzcvQ2B2kWlEy6YWPaWF+ZV3Z4avdB/oiFnn5FZK+wSlCoiF1DWxd6TW+0CIk0T7fYTqBt3nDGJw3Zb7tTzKaC5xKCK8x89GoIxo6WpHv6JbTjMgSAtX3G9id15lNJDsEaIhwfnh4FXNX4qX87leIoXnPXorIXO3oy9sGROFCfOWd2W5+oYz9jysrsfEB7PqGCPAcjGpJf6+sOd6RCC4MaKvkMHzGocl3anR/ji9hmTXJchA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tw0s9+B+lOUlPzGuqqHZc+BliG9zWYxRoLru8awX5BU=; b=FG2fZlsjlijToQ45xGQgw00XhGVsgCvfSz7rJgVd7nnj7DiToQf+Es7ULHf9JZBf4AG04+FR5ScQ2LToYvZaYdEIEmQVTFnBw0zg4R8nuDwBjp8mW4OJkSnQ5uBgaf4PU181djhd9MOGgFsV3gPmHvpPFVYDEyipa9s+/z3j0CgU/ZDUtYaahRcPY1B4qN2MeO392m4yo/PXt5ub+QyDfJayrY0DgVbgviD4nURxcjBJOm6rFQH1QSJDDn+O+W3ary061OIOEiAfQNZ2f47mDEFDTCl8fEugerzC4EqyWqL8rnw9tbXfb59LhVp8JqVolF0K3NHJ7FirrIlYgYI8Sw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9f319f7b-5080-2802-09e0-2793d9dad1a7@suse.com> Date: Wed, 3 May 2023 12:43:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH] cmdline: document and enforce "extra_guest_irqs" upper bounds Content-Language: en-US From: Jan Beulich To: Julien Grall , Stefano Stabellini , Bertrand Marquis Cc: George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" , Andrew Cooper References: <54e126fc-484b-92fa-ce66-f901f92ec19c@suse.com> <6c5cdffa-f3fb-8f40-c44f-ad7431451929@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0131.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::16) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|PA4PR04MB7711:EE_ X-MS-Office365-Filtering-Correlation-Id: 951cc484-a02b-4e10-b73a-08db4bc3391c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y6fUfyX3E65fJ9h9MgEwmrNp4Dhzzee2PB2VVFV43rmXG4xDCgXYfzMwkI2FpKO7jjw3LSgqBPefl0BPu/BTvM/l4mlUp4bZ6/5wV/ySGXSE5y5oBPRVln84ou8GGAweTfPLDmgAFNpU0HluHd5cd9h36LNVHpmZo8bRiWMLlxU15nJvo50gXi57M+MIsJWriUda7R+5D+96S3jpo7XtJwULUVUUwWWV+X/Y5qD4FYGdj8l2CeItbRxEqICjZZFAVyAO18JuLVfM9h3lmzqrYnc9ZeDZQXySNslE5fGtfts2NiTVBlYpdkbZZSFEBqPpTgY7JqZec91J+tuJsWfvZ9zq9IF6e6ReXKE1RRD/BXTYDUYsTY+vRWVgYOMugj/MKB9cVmgomU1IeJPcTlVBlq9Ox+ystcZlNJTJ/dR2pfjwWcVmiDiVZ3KkttyWc1RI7vCweNmkSs6XwBi5H6PO3KoNrkn1i3YukzqTkpzyqUsHVb3Hw65Ad5xbTjU24kxfLH+7yHX955Pje2ZvCRSw6cSNMal30OUAUsYf/O3nyXJIIBsqNt5yUO8LJdl6q6yUM9Odzvdk808vVL8+OgeFQWajZHMicFWP0284yf/IqSiwGK0vI5jzHDzMHRZU5HiKcanLAOyBuYIKaBbsPF+mkQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(39860400002)(376002)(396003)(366004)(346002)(451199021)(31686004)(2906002)(4744005)(5660300002)(36756003)(8676002)(8936002)(66476007)(66946007)(66556008)(110136005)(41300700001)(86362001)(31696002)(478600001)(316002)(4326008)(54906003)(6486002)(38100700002)(186003)(53546011)(2616005)(83380400001)(26005)(6506007)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S09DdkcyVTRaUy9aZk10K3YxWjhHVFVHRkZnZEp3cHFnRXJlQTdncWY0WTBx?= =?utf-8?B?dkVXZkJyMGlVOXZoZmRuQnAySTZXanNDZy9FSEduN25RR3dtNmQ0MldCN0Z1?= =?utf-8?B?NEtRdCtFSjQyQUtjUkFWU1M2aVp0Qld2OWhiZEFlSHYxYVZzejU1NDJSaFdP?= =?utf-8?B?VGI1QWlGMUdtM2c4aGcrRi9pTThTOUpkNEtad2ZoVnFrWFppZmRZVFd5V3RW?= =?utf-8?B?TVZDQmJReGYvN2dPcVZVaXlWT0dtQ3diV3BMbW0ycVdVRjJKQlNocWNIQ2tp?= =?utf-8?B?ZzhZL3ZsVURWRS9TTEpNb3VKMzJ1SWFPdXhDWXRTdEpzRStvQ3lFVU5sRFVG?= =?utf-8?B?OHdxNFpzb1F2V29la2RuOVc4Qm84dHk2ZDZubjkvUWpYQ0ljcXhoeE9SWDRl?= =?utf-8?B?TVRiRmFJN1NXcVFodGpWc2RLM1Nac084YWNRZVljYXh1NWtJZkZRYmJ5ZXlR?= =?utf-8?B?RmdkY0lIYlpOc2M1MFlDU1k1UXpkV0tXTmx6V1lITXpnSnIyQjN5TWY1R3hT?= =?utf-8?B?WUl4V2wzSW1IY3hPY1Q1aW9qQVZrWXorOWxWMW51TUh6OEM1Q1Uzakx3T0Fr?= =?utf-8?B?cm5KcjhCbVVUaEdjZitOS3Z5OWJQa2kvdE5qSlZ2RkRJS1BHdGp4RmZiMDR1?= =?utf-8?B?MW5EZENLREg2ZEQrWTAzeG9iTHY3ZW05U3NhRjRaTW9tOXNPUkVzMWtBRnp0?= =?utf-8?B?REI2S3NHTm5nZ3RpQURzZlJtTTNmbmY0Uzh2VlZqWXd6S25tdXVkQThVUitD?= =?utf-8?B?ZG82SVlrZlVzbUdHVlBWUFZzQnZUZDVBOXZ6aXFZS0NjZGF1REk3eHAwY1lP?= =?utf-8?B?clVJN2dWcWdnLzBXSlFOQy9rVUxuaU1ZR09RTWlydUVpd1pyLzZ6YWlvcVRP?= =?utf-8?B?dmhDOHFudFJMWUtnQTBvTU9xdXAxVTZmMllQQUdWRzBodHhTLzlBNk1CQ3hT?= =?utf-8?B?SFRLMFdjWGIxRHVyVTZtczRsbEVmVnlQaFgvajlxNlhXNmtVeFkzeVMyRWVT?= =?utf-8?B?aUhYWVdTKzgya3pSRHNtZ3VRTFJWWnFNUkZhUjJ1d05NNE5HSFpUVDhNRVlU?= =?utf-8?B?Rzl4MEdZb1FYYUwxZmJIV3M2b1h6ZWlyMG5PTzNieEJzRmpqM2JlR1dpRy9v?= =?utf-8?B?MithVFovQnVHdFZ3N0NKOFNkb3VVbjNwTm9lNHNxNlUvUVhnS3J3dlgrdktp?= =?utf-8?B?OThvV1RJcEJRRitaR1dqVTRnRENZZ3lpbXdZVDhjUzRzdTlRNHd1SHpXZkhT?= =?utf-8?B?QllSRDVZMmx1ZlJUdHFMSmU5bGV1ZGVVZ3FSbnA3bjY5Q0pGYXVyUEo1V2Jw?= =?utf-8?B?MFN4N213aElPZ3Y2bEFIc2hhdE9XdHRpQ2ppRksvWEUrblBTcHpoYW8xN2VX?= =?utf-8?B?aWFXYXRyb1RuODU1Y0tYSlI5SVpYYnJEL25pby96WC8yNHFIWnJhM3BORmcz?= =?utf-8?B?MTR4a21YamducVBiRVR6cmxZYm1xaTc4MlN1b1dORUo5NnF0ajJWWlR2ZE85?= =?utf-8?B?WTc5NTZDOGV2bHc2WUNUeTNKelFOblp6U2xQeVBlbHRVSWRCY2hRR2h0RExr?= =?utf-8?B?aGZydHdCRFhkdHJ2ZXhaYmdkVnZ3MS9rK0QzYnpXRmpwUldMdTFvaGJIdjhS?= =?utf-8?B?UnJJZTJFcWprNE5MNHVOYlo2aS9LOXc3M0crQjdzdWs2QysxdGQ5elRBdGk4?= =?utf-8?B?bTY2M3kwSVRDRDRNMXVYS0dLT1dVZ2FUSWFWaHhIWUhzN2N3QXliTVRLZms1?= =?utf-8?B?VnNqMU00b2YvU2hhSytHN3lZQzN4akx4aFhFSU9YNnkvU1gwUFVsZU1Zcmdl?= =?utf-8?B?QlB1TzBSY3hmdnJRczEvMWdMZVJBK1dkOEx1Tk1VUG56QnZBSk1UZm5GRU91?= =?utf-8?B?QVRmWFZDS3lxZUF6ZWl4aWErNEdHQlo3SjQycHhTOStGdmFZNmlZdG5lZ0dh?= =?utf-8?B?K2l6WUVxRUQ4UzdnUXhhOHVqajc1VTdaQ0k3T29nU0prMFlaTEJCZFRaQmZu?= =?utf-8?B?Y3dYT1FRY1dJT1paeDI3c3JUdXUzS2JFdHJuMGRNYm1jK09ORDZ2eXhJdjFB?= =?utf-8?B?NjkyYXBZYlFTL3EzQm5sN1hQUzE3TWlZOXQ1aHN0eG14WnhCOUxaSU5jcU5r?= =?utf-8?Q?XrDJTBo81YwH28DYC4Xepweyo?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 951cc484-a02b-4e10-b73a-08db4bc3391c X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 10:43:25.3609 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KvqwDhGlE/+m0dR9nGU34fMZktn8oNqgixCoGV0KM4tNbWzwx/4+6O855lrGoP6Q5qwMfEU/Ch7Nm3sRxaX9/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7711 On 04.04.2023 12:40, Jan Beulich wrote: > On 04.04.2023 12:34, Andrew Cooper wrote: >> On 04/04/2023 10:20 am, Jan Beulich wrote: >>> --- a/xen/arch/arm/include/asm/irq.h >>> +++ b/xen/arch/arm/include/asm/irq.h >>> @@ -52,7 +52,7 @@ struct arch_irq_desc { >>> >>> extern const unsigned int nr_irqs; >>> #define nr_static_irqs NR_IRQS >>> -#define arch_hwdom_irqs(domid) NR_IRQS >>> +#define arch_hwdom_irqs(d) NR_IRQS >> >> I know it's not your bug, but this ought to be (d, NR_IRQS) as you're >> changing it. > > I can add this (with a cast to void), but I'll leave the final say to > Arm maintainers. Arm maintainers, may I ask for some kind of statement here? I'd be happy to follow Andrew's request, but I don't want to then end up with an "unrelated change" objection. Thanks, Jan From xen-devel-bounces@lists.xenproject.org Wed May 03 10:53:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 10:53:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529104.823127 (Exim 4.92) (envelope-from ) id 1puA70-0004sJ-R4; Wed, 03 May 2023 10:53:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529104.823127; Wed, 03 May 2023 10:53:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puA70-0004sC-OI; Wed, 03 May 2023 10:53:30 +0000 Received: by outflank-mailman (input) for mailman id 529104; Wed, 03 May 2023 10:53:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puA6z-0004s6-NU for xen-devel@lists.xenproject.org; Wed, 03 May 2023 10:53:29 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puA6y-0007xn-LB; Wed, 03 May 2023 10:53:28 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.7.72]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1puA6y-0006MO-Dp; Wed, 03 May 2023 10:53:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=1BCdJCjM28LGf/KTqeCxNJ67GzgccYNIlqtOxilJCvs=; b=rLE6Pp8ZSjuZuJlVO8Il++yoZ8 nPLjeyEuc3QAa+4BtyUZGeLmmyUo9jeXeZS84stL453xg+4fqCSHVVZfQd61jYkN15tZd0uVKdwYL nAKzH7AmiS6k6JL1iEZ2lNzcdwkJZZkUGhJvFQuq6sHbBknrlIqyH+ttNabWOj0Uqqzg=; Message-ID: <1a529c44-1564-ad42-3924-f58efaa83a91@xen.org> Date: Wed, 3 May 2023 11:53:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 13/13] tools/xenstore: switch quota management to be table based Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230405070349.25293-1-jgross@suse.com> <20230405070349.25293-14-jgross@suse.com> From: Julien Grall In-Reply-To: <20230405070349.25293-14-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 05/04/2023 08:03, Juergen Gross wrote: > Instead of having individual quota variables switch to a table based > approach like the generic accounting. Include all the related data in > the same table and add accessor functions. > > This enables to use the command line --quota parameter for setting all > possible quota values, keeping the previous parameters for > compatibility. > > Signed-off-by: Juergen Gross > --- > V2: > - new patch > One further remark: it would be rather easy to add soft-quota for all > the other quotas (similar to the memory one). This could be used as > an early warning for the need to raise global quota. I don't have a strong opinion on this topic. > --- > tools/xenstore/xenstored_control.c | 43 ++------ > tools/xenstore/xenstored_core.c | 85 ++++++++-------- > tools/xenstore/xenstored_core.h | 10 -- > tools/xenstore/xenstored_domain.c | 132 +++++++++++++++++-------- > tools/xenstore/xenstored_domain.h | 12 ++- > tools/xenstore/xenstored_transaction.c | 5 +- > tools/xenstore/xenstored_watch.c | 2 +- > 7 files changed, 155 insertions(+), 134 deletions(-) > > diff --git a/tools/xenstore/xenstored_control.c b/tools/xenstore/xenstored_control.c > index a2ba64a15c..75f51a80db 100644 > --- a/tools/xenstore/xenstored_control.c > +++ b/tools/xenstore/xenstored_control.c > @@ -221,35 +221,6 @@ static int do_control_log(const void *ctx, struct connection *conn, > return 0; > } > > -struct quota { > - const char *name; > - int *quota; > - const char *descr; > -}; > - > -static const struct quota hard_quotas[] = { > - { "nodes", "a_nb_entry_per_domain, "Nodes per domain" }, > - { "watches", "a_nb_watch_per_domain, "Watches per domain" }, > - { "transactions", "a_max_transaction, "Transactions per domain" }, > - { "outstanding", "a_req_outstanding, > - "Outstanding requests per domain" }, > - { "transaction-nodes", "a_trans_nodes, > - "Max. number of accessed nodes per transaction" }, > - { "memory", "a_memory_per_domain_hard, > - "Total Xenstore memory per domain (error level)" }, > - { "node-size", "a_max_entry_size, "Max. size of a node" }, > - { "path-max", "a_max_path_len, "Max. length of a node path" }, > - { "permissions", "a_nb_perms_per_node, > - "Max. number of permissions per node" }, > - { NULL, NULL, NULL } > -}; > - > -static const struct quota soft_quotas[] = { > - { "memory", "a_memory_per_domain_soft, > - "Total Xenstore memory per domain (warning level)" }, > - { NULL, NULL, NULL } > -}; > - > static int quota_show_current(const void *ctx, struct connection *conn, > const struct quota *quotas) > { > @@ -260,9 +231,11 @@ static int quota_show_current(const void *ctx, struct connection *conn, > if (!resp) > return ENOMEM; > > - for (i = 0; quotas[i].quota; i++) { > + for (i = 0; i < ACC_N; i++) { > + if (!quotas[i].name) > + continue; > resp = talloc_asprintf_append(resp, "%-17s: %8d %s\n", > - quotas[i].name, *quotas[i].quota, > + quotas[i].name, quotas[i].val, > quotas[i].descr); > if (!resp) > return ENOMEM; > @@ -274,7 +247,7 @@ static int quota_show_current(const void *ctx, struct connection *conn, > } > > static int quota_set(const void *ctx, struct connection *conn, > - char **vec, int num, const struct quota *quotas) > + char **vec, int num, struct quota *quotas) > { > unsigned int i; > int val; > @@ -286,9 +259,9 @@ static int quota_set(const void *ctx, struct connection *conn, > if (val < 1) > return EINVAL; > > - for (i = 0; quotas[i].quota; i++) { > - if (!strcmp(vec[0], quotas[i].name)) { > - *quotas[i].quota = val; > + for (i = 0; i < ACC_N; i++) { > + if (quotas[i].name && !strcmp(vec[0], quotas[i].name)) { > + quotas[i].val = val; > send_ack(conn, XS_CONTROL); > return 0; > } > diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c > index 65df2866bf..6e2fc06840 100644 > --- a/tools/xenstore/xenstored_core.c > +++ b/tools/xenstore/xenstored_core.c > @@ -89,17 +89,6 @@ unsigned int trace_flags = TRACE_OBJ | TRACE_IO; > > static const char *sockmsg_string(enum xsd_sockmsg_type type); > > -int quota_nb_entry_per_domain = 1000; > -int quota_nb_watch_per_domain = 128; > -int quota_max_entry_size = 2048; /* 2K */ > -int quota_max_transaction = 10; > -int quota_nb_perms_per_node = 5; > -int quota_trans_nodes = 1024; > -int quota_max_path_len = XENSTORE_REL_PATH_MAX; > -int quota_req_outstanding = 20; > -int quota_memory_per_domain_soft = 2 * 1024 * 1024; /* 2 MB */ > -int quota_memory_per_domain_hard = 2 * 1024 * 1024 + 512 * 1024; /* 2.5 MB */ > - > unsigned int timeout_watch_event_msec = 20000; > > void trace(const char *fmt, ...) > @@ -799,7 +788,7 @@ int write_node_raw(struct connection *conn, TDB_DATA *key, struct node *node, > + node->perms.num * sizeof(node->perms.p[0]) > + node->datalen + node->childlen; > > - if (domain_max_chk(conn, ACC_NODESZ, data.dsize, quota_max_entry_size) > + if (domain_max_chk(conn, ACC_NODESZ, data.dsize) > && !no_quota_check) { > errno = ENOSPC; > return errno; > @@ -1188,8 +1177,7 @@ bool is_valid_nodename(const struct connection *conn, const char *node) > if (sscanf(node, "/local/domain/%5u/%n", &domid, &local_off) != 1) > local_off = 0; > > - if (domain_max_chk(conn, ACC_PATHLEN, strlen(node) - local_off, > - quota_max_path_len)) > + if (domain_max_chk(conn, ACC_PATHLEN, strlen(node) - local_off)) > return false; > > return valid_chars(node); > @@ -1501,7 +1489,7 @@ static struct node *create_node(struct connection *conn, const void *ctx, > for (i = node; i; i = i->parent) { > /* i->parent is set for each new node, so check quota. */ > if (i->parent && > - domain_nbentry(conn) >= quota_nb_entry_per_domain) { > + domain_nbentry(conn) >= hard_quotas[ACC_NODES].val) { > ret = ENOSPC; > goto err; > } > @@ -1776,7 +1764,7 @@ static int do_set_perms(const void *ctx, struct connection *conn, > return EINVAL; > > perms.num--; > - if (domain_max_chk(conn, ACC_NPERM, perms.num, quota_nb_perms_per_node)) > + if (domain_max_chk(conn, ACC_NPERM, perms.num)) > return ENOSPC; > > permstr = in->buffer + strlen(in->buffer) + 1; > @@ -2644,7 +2632,16 @@ static void usage(void) > " memory: total used memory per domain for nodes,\n" > " transactions, watches and requests, above\n" > " which Xenstore will stop talking to domain\n" > +" nodes: number nodes owned by a domain\n" > +" node-permissions: number of access permissions per\n" > +" node\n" > +" node-size: total size of a node (permissions +\n" > +" children names + content)\n" > " outstanding: number of outstanding requests\n" > +" path-length: length of a node path\n" > +" transactions: number of concurrent transactions\n" > +" per domain\n" > +" watches: number of watches per domain" > " -q, --quota-soft = set a soft quota to the value ,\n" > " causing a warning to be issued via syslog() if the\n" > " limit is violated, allowed quotas are:\n" > @@ -2695,12 +2692,12 @@ int dom0_domid = 0; > int dom0_event = 0; > int priv_domid = 0; > > -static int get_optval_int(const char *arg) > +static unsigned int get_optval_int(const char *arg) > { > char *end; > - long val; > + unsigned long val; > > - val = strtol(arg, &end, 10); > + val = strtoul(arg, &end, 10); The changes in get_optval_int() feels like more a clean-up because the returned value cannot be negative (see check below). I would prefer if they are done in a separate patch. > if (!*arg || *end || val < 0 || val > INT_MAX) Now that 'val' is unsigned long, then there is no point for checking val is < 0. Lastly, I would rename the helper to make clear it returns an unsigned value. How about get_optval_uint()? > barf("invalid parameter value \"%s\"\n", arg); > > @@ -2709,15 +2706,19 @@ static int get_optval_int(const char *arg) > > static bool what_matches(const char *arg, const char *what) > { > - unsigned int what_len = strlen(what); > + unsigned int what_len; > + > + if (!what) > + false; Shouldn't this be "return false"? > > + what_len = strlen(what); > return !strncmp(arg, what, what_len) && arg[what_len] == '='; > } > > static void set_timeout(const char *arg) > { > const char *eq = strchr(arg, '='); > - int val; > + unsigned int val; > > if (!eq) > barf("quotas must be specified via =\n"); > @@ -2731,22 +2732,22 @@ static void set_timeout(const char *arg) > static void set_quota(const char *arg, bool soft) > { > const char *eq = strchr(arg, '='); > - int val; > + struct quota *q = soft ? soft_quotas : hard_quotas; > + unsigned int val; > + unsigned int i; > > if (!eq) > barf("quotas must be specified via =\n"); > val = get_optval_int(eq + 1); > - if (what_matches(arg, "outstanding") && !soft) > - quota_req_outstanding = val; > - else if (what_matches(arg, "transaction-nodes") && !soft) > - quota_trans_nodes = val; > - else if (what_matches(arg, "memory")) { > - if (soft) > - quota_memory_per_domain_soft = val; > - else > - quota_memory_per_domain_hard = val; > - } else > - barf("unknown quota \"%s\"\n", arg); > + > + for (i = 0; i < ACC_N; i++) { > + if (what_matches(arg, q[i].name)) { > + q[i].val = val; > + return; > + } > + } > + > + barf("unknown quota \"%s\"\n", arg); > } > > /* Sorted by bit values of TRACE_* flags. Flag is (1u << index). */ > @@ -2808,7 +2809,7 @@ int main(int argc, char *argv[]) > no_domain_init = true; > break; > case 'E': > - quota_nb_entry_per_domain = strtol(optarg, NULL, 10); > + hard_quotas[ACC_NODES].val = strtoul(optarg, NULL, 10); I think we should use get_optval_int() here and all the other below. > break; > case 'F': > pidfile = optarg; > @@ -2826,10 +2827,10 @@ int main(int argc, char *argv[]) > recovery = false; > break; > case 'S': > - quota_max_entry_size = strtol(optarg, NULL, 10); > + hard_quotas[ACC_NODESZ].val = strtoul(optarg, NULL, 10); > break; > case 't': > - quota_max_transaction = strtol(optarg, NULL, 10); > + hard_quotas[ACC_TRANS].val = strtoul(optarg, NULL, 10); > break; > case 'T': > tracefile = optarg; > @@ -2849,15 +2850,17 @@ int main(int argc, char *argv[]) > verbose = true; > break; > case 'W': > - quota_nb_watch_per_domain = strtol(optarg, NULL, 10); > + hard_quotas[ACC_WATCH].val = strtoul(optarg, NULL, 10); > break; > case 'A': > - quota_nb_perms_per_node = strtol(optarg, NULL, 10); > + hard_quotas[ACC_NPERM].val = strtoul(optarg, NULL, 10); > break; > case 'M': > - quota_max_path_len = strtol(optarg, NULL, 10); > - quota_max_path_len = min(XENSTORE_REL_PATH_MAX, > - quota_max_path_len); > + hard_quotas[ACC_PATHLEN].val = > + strtoul(optarg, NULL, 10); > + hard_quotas[ACC_PATHLEN].val = > + min((unsigned int)XENSTORE_REL_PATH_MAX, > + hard_quotas[ACC_PATHLEN].val); > break; > case 'Q': > set_quota(optarg, false); Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 03 10:59:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 10:59:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529115.823137 (Exim 4.92) (envelope-from ) id 1puAD6-0005WN-H1; Wed, 03 May 2023 10:59:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529115.823137; Wed, 03 May 2023 10:59:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puAD6-0005WG-ED; Wed, 03 May 2023 10:59:48 +0000 Received: by outflank-mailman (input) for mailman id 529115; Wed, 03 May 2023 10:59:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puAD4-0005WA-SF for xen-devel@lists.xenproject.org; Wed, 03 May 2023 10:59:47 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9bffbf91-e9a1-11ed-b225-6b7b168915f2; Wed, 03 May 2023 12:59:45 +0200 (CEST) Received: from mail-bn8nam12lp2168.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 May 2023 06:59:41 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by CH3PR03MB7433.namprd03.prod.outlook.com (2603:10b6:610:19f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Wed, 3 May 2023 10:59:39 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec%3]) with mapi id 15.20.6340.031; Wed, 3 May 2023 10:59:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9bffbf91-e9a1-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683111585; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=6RWwbk5SEKauqK8nsuOFdhJu82y4KomYtMURf7L1qLo=; b=Ht7CZnw9xqwtrZOi6zoUqaYMoJhnu1ePqRMrWQjFaWSI0kZKiRfY9bSa jdl69jaOxh3hy0AFhshmoPS1tpwrtmHs/bW1rwEuc+zUaj1b8uD3oqFU/ MognUM4QVDzgt95W37ONSIlGqZUa3zE1EMY+CP3bRMUdYsvJ4hfdOjJpF o=; X-IronPort-RemoteIP: 104.47.55.168 X-IronPort-MID: 108104179 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:dgedVqM8IBHZRmrvrR0hlsFynXyQoLVcMsEvi/4bfWQNrUom1zAHx zdLWGGGMv2JYTbxc4x2YIjkph5TvpLRyYIwQQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvPrRC9H5qyo42tF5gdmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0uF1E39op P05E3MMYA+y2rqRnbOaZtA506zPLOGzVG8ekldJ6GiDSNwAEdXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PdxujaDpOBy+OGF3N79YNuFSN8Thk+Fj mnH4374ElcRM9n3JT+tqyr837eTxHyqMG4UPIWZ5vJ3vUzI/XRJAVofc2uj++i602frDrqzL GRRoELCt5Ma9kamU938VB2Qu2Ofs1gXXN84O8037hucjJXd5QmxD3IBCDVGbbQOv8gzQCEs1 0OY2dbgAzVgvae9WX+b7q2Trz65JW4SN2BqTS0ZSQoI5fHzrYd1iQjAJv54C7K8hNDxHTD2w hiJoTI4irFVitQEv42k+XjXjjTqoYLGJiYl6wOSUm+74wdRYI++e5fu+VXd9exHLouSUh+Gp ndspiSFxOUHDJXInirdRuwIReut/6zcbm2ahkNzFZ488Tjr42SkYY1b/DB5IgFuL9oAfjjqJ kTUvGu9+aNuAZdjVocvC6rZNijg5fGI+QjNPhwMUudzXw== IronPort-HdrOrdr: A9a23:NsTmwal+0o1KkjCV5pE1VCV4g3LpDfII3DAbv31ZSRFFG/Fwwf re+cjzsiWE9Ar5OUtQ5OxoXZPrfZqyz+8T3WB8B8bFYOCighrSEGgA1+rfKl/baknDH4dmvM 8KAstD4Z/LfCBHZK7BkWuF+r0bsaC6Gc6T5ds3uh1WPHtXgmJbgzuRyDz3LqS7fmZ77FMCeq ah2g== X-Talos-CUID: 9a23:bIz+i2/EoNtwm+4Iu0SVv0kWCN4DI3z89zTRLVCJVD5OFby0ZWbFrQ== X-Talos-MUID: 9a23:ltcYBASKJKQxBHRGRXTUpSFuKfp5uJ+2UklKmLM2o5OVNnVZbmI= X-IronPort-AV: E=Sophos;i="5.99,247,1677560400"; d="scan'208";a="108104179" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CxZ3/7zv6RX6YN8Ziz4xBdR50HNBzdunqDCzWnXipIgzdnCImQsRD4qTrfgMZw7teuQnjEfk4u3qLIDFL1B/fwaRi/WISIjsqOYzj9tOteiS2Y4j0AMgvgPgzqfYYkpPkye103biQ0fbGWcwLgJhzp2K5FvBlO+TmfdUjbia6qrEf4iFvziDY9qp5JGsK923GBy/AzobxbXMjfK7EMrujjydOK0PKBH4DA/JrOFbb90VYz+zB1hUAeJ3uZdTymec6QEcbKVf7QfGLSYKCVKHIKDI9ONB1MLGY378j/QEiNODGDJ4PgFMMf8nDIWXTc1vWYw/rXoKfFsEcLjCtjlhSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t1WAO9qDhaUZ+sqChhfahS0xja8lxmtg8lYiM5KDuO4=; b=FptxSn79Q4ffQXiK8i7+2SP0UtZVEUf8RLoq+D4wLHVV5ufQ8R5Xw0Y6k8OTLcR53P5og9ZpfGo+iETbDFuiFtOs4vJsOcIqgV77pTdTwhkvca407wEJZmJGqR0XxtPLUsgi6XEQ9W6pxIhwcMpHTuWr5exaCjvfFK2iMGGdsUo0qW4Cb8z2wC/6oRD+b+ED1P7F7OBDkiex1hHp3A8Hg6vL/9ffkCSDSX+1vId7BS/ik+RQDhWkj+vIk4V6IFZH2ECAX70Mczwxn2NnqQMBMzWRN+xdcAKA+Fa9XN796Pmk+4Jr6l9udVAjl5MBAR3fbjcg8yDcPr8JR6JW2+N7ww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t1WAO9qDhaUZ+sqChhfahS0xja8lxmtg8lYiM5KDuO4=; b=luGhlknKHK0I95pyLVB5TGzwPOD/CFMB3p3qspFRFv/gS0eVT1zW8fmQFW5B6JoYKTHhhX6d2jsFSPdAJOwLiwoC9Dv1yyA+wUKYPF5PSL2rehAmN31bcPZH/IEEXOE2oTkpBgrh5HFQg+I503i3vn/3Ds0dzn6IE0qugqOM9Gc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 3 May 2023 12:59:32 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Henry Wang , Community Manager , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH v3] xen/vcpu: ignore VCPU_SSHOTTMR_future Message-ID: References: <20230419143155.36864-1-roger.pau@citrix.com> <0820220d-a500-7920-3630-eea074856e3f@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0820220d-a500-7920-3630-eea074856e3f@suse.com> X-ClientProxiedBy: LO2P265CA0082.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::22) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|CH3PR03MB7433:EE_ X-MS-Office365-Filtering-Correlation-Id: 1c5e9566-3d21-4ecf-bc09-08db4bc57d77 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gBFskLXDcSLMokwjmRfUYvAW0wQCHcknYjKu6kKoVQTrxDXwWsmFDKdVpePqec11G8AQGTXWONZslFBnjggXmUmvw7YM2T7Rb6+lHNtd3EbdQCaATTHp1Qt6v4XA+x/QwLWr5lBNt5gaR6weQGQCZ/37qXq7RkWNwY3vyQd7EMlmb9WDLrMN7a4Iif9k9ARzyVEy0aHP0eLZsXpb9fUYBI7Sm/OOr+00g87b/2Ifp70wyAw6JudXp+fAGoHICbJXZ0p5h6P4JnnCa37QoDUCl7mxu4eAMzZgESmQ95BK2LCpa2zEfwJCbuMc6eOBbPbuRXsALKiWwNxxH2JWJ3txH0RbkOd7MjBb8OPaxvJiwnbv6xHN2YydJA8kxZgU6r9h/jTmp5OEdboBxGLi60p6XMEClV/xpRB5I2xbCnMFNjtCdUsy8IypgE59lK+NviU4mrFOZJP6WYarUmt0TCjb0KSJ5Wi+/ZY9cuCoiM+evCsaBZJ6sDC2rbEg2fA1G7wPkRRVgaLtS6pnrFCF/BpcnEHZd8AKiQxfYKWNpsy8EVnUINUpi9VQKa3MA3IREwaeHKFwVciBM9qV153TgYhw1f2FZaj+JVH7BwaIS9fZWec= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(7916004)(396003)(136003)(39860400002)(376002)(366004)(346002)(451199021)(82960400001)(41300700001)(33716001)(316002)(38100700002)(4326008)(6916009)(83380400001)(54906003)(85182001)(186003)(478600001)(66556008)(66946007)(9686003)(6666004)(53546011)(6506007)(6486002)(8676002)(66476007)(26005)(86362001)(6512007)(2906002)(5660300002)(8936002)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M3NzeWpFQUM4NEFmOGtpM0dZK21MRUpIdW5ZdE5VWmVhZ1FPdWZSYW85Unl3?= =?utf-8?B?d1R3WFZUdXZIMEZ0c0dJb2d4cG9UL3JuaWhsaFZ3clVvUDlkWlcxU1A4N0Ex?= =?utf-8?B?OHFDbU1iTnB5aVVYNkJFTS94NmlQeFBsV0diRHcvQjFiWWJKcHovbjRGSUU5?= =?utf-8?B?REV1RHEzbGVnb3VIU2IxdzdsdXFkYXlNUW1vL2djdUpNb3lEaGVMK3M3Y2JK?= =?utf-8?B?VlN5UzMxVFYzMk0rUHErTVBuV0JseUhpc0tsQVdyN2xTQUdWOHU2dkZNWlR4?= =?utf-8?B?elI0UFNLZEtTSEE4MVhoek4xUlhWeVR4L3NvTzBRaVUweFA5RE1ZalgrQlhv?= =?utf-8?B?eXVYQnVLaUUwNnBYclRLY1JTRlVaNmhkQUVFbEkyVkYrVWd6dXA1M0RybkxZ?= =?utf-8?B?S2JMbnh3N1B4S2ZxUG9VUjBkK3JjVW5lTEdmR2ZXOThOVVVMZnA5QkJXWnlG?= =?utf-8?B?YjZiYTlvaWVQckptMWwrMDU3ZWg5VmF2MTZYS25QUEwxai9MZVo5OFRCeUtG?= =?utf-8?B?REFPRXpPTFloRFg5c2d1OWVtTENMUnNVS0dMN1hFcVVteHNkVmdTbVhuYjQr?= =?utf-8?B?UWVwa3A1TkJ3Qy9MYWRYSTd3Y3lVVklxTE9wWVNuR1NYS0VncWJPTDJvbERt?= =?utf-8?B?akE4Lzg5c01vR1JIc2o5Vko5MUZVQk1JWjVReFU2QzY1Sm9YeHdHQU5xYVN5?= =?utf-8?B?YlJDcmtTeFUrTVk0MVFCRHc3SnBxQVlGYXNMRXpXby9VSG5udFFMWURESFQ5?= =?utf-8?B?WlNaNWc3akk1T1ZmT3ZPTVVSN2MxSEtLL29vd2drVWFPbVhoWHRxeDNmWURG?= =?utf-8?B?OGZ4V2g3eWdDazRWcmxia1hrblR2Mi9UYi96QzRnRGRLVUVKVHJpay9vWFYz?= =?utf-8?B?bDhCRTFqc3JFM0paaUszSFZuNmlyNys4WmFQRjVRV1ZlczB6NXh4QTJCQnEz?= =?utf-8?B?NmhBOUhIa2Q1cjBtRGtHK0w5a05ZellXU1RyK0FyT3BiSGlwL3YzbmdVOXNt?= =?utf-8?B?V2dJVExmSjhiV0JRZ2xrYWdlYVoyTnh6K0xmSTNuRnR2ejRVSk9TRFo1SkM0?= =?utf-8?B?T2lDSThDME5JNDNMK29peDVYMTNEOHpQUkNBRkdWR0xGajh0cmh5bUZxSWNR?= =?utf-8?B?Q01jc1RldFdCUUREUWFYQ3ppTGZxMitXYjdIODVyazRtK2hESEdGYUt4bndB?= =?utf-8?B?aGs5d1hMODlNaFFRbi9WQ2kxZmJKb3VUZWhTTThTU1NlSU4rN1J3SlJXblJl?= =?utf-8?B?akUyMVhFTDZYb0s5QXVBZmRFYnpoMTN0M3hZTGNXM0VaM2YxU2tpSkxmWDZ2?= =?utf-8?B?R3FDWHVxTHh4QS9uR004TmxLcVRYNGltQi9UcVl4aUpqTTNsNkxHTFhDSzB1?= =?utf-8?B?Njh1VXUvSlFNNEFNUXpLRTZKdVVicmhnVVpsc3FrSHkzdTd6S0doZlR6TnhM?= =?utf-8?B?VGcxcGVQekJqSmlLeFFPVXhZSnJSdXNUQnoyMytUcnFLa3Fyc2ZnM3Q4WWQx?= =?utf-8?B?bUFHUENOQUxCY1FpWGFMUGxzb05qSThoVmduZk5LQkN1eHpLQkUxMDA4UStl?= =?utf-8?B?T2RNQ2EwTmtqQUU5Q0RYTXBxTkkwWjhrdEZLbEhTZlpHTzJrbEJ1VThxa2tn?= =?utf-8?B?K2lWK2hVa0loaU5RZXZyUng3SHJxUHdkUml1QnFZYXVFaHkva3FnZ1FwNUdZ?= =?utf-8?B?VlY1cXFkbUFBTW9qb1dEcmU1cUdPQmdyeU1QempibEdZZm5jMHMraXpzTitN?= =?utf-8?B?aXkrdEtMc0tUejBiaWllcHdZOGJiK2NzWFlFMngzeVFBWkJ2alNEaXhvNEJ6?= =?utf-8?B?bXhXMnQyTEMzT0pIU1NSZWpWcGE2WnVuOEYrS0JCYUdXUm91NHRpVzlJd0xl?= =?utf-8?B?MG5kT3plejIzay9Id0xmR3BlMFhnMG1UbXZLK21rZnIxUnhZVld3OWxROEFk?= =?utf-8?B?elpvcWVKWHRkMEpKS00wUW1XRGxBTDc4MElhVzNUSE5HdjU2RGp2bDdDUkZ3?= =?utf-8?B?RkdvWk96UFBxNUh0bHpuRnBoQWs2UXZDVyt1RTg1Vk16TGtCTEJjblA5emNH?= =?utf-8?B?cDBDakp6SWRqOEFQSHlqR2t1Z1VEMGhXbG84dXFSZ05mQlRpOVQ5VzY0c2pJ?= =?utf-8?B?UmZKbk5WSzRMN2pGc1hzRDJubmwvWVM2M1VrUTdFNTRKaDNxUXRtTENxZlN4?= =?utf-8?B?T1E9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: CpYO7J0DkI3U7dnB42GwPEmK0+JoepzdLuMvKHxC8fRjcwzR+/Tw+/ytMvlHFsXV4Pd9f4VfO4abCPBrLNSLAMSEfekTDnXECU18+KJTwWtcHMw65+I8nZ6N/TnWwWRTIeldyFrd16lm+mxb54DCOE/NbueK5QXud8H58wdxww4ZsVIphBheGNk6ufetyU2jU7EcjALvtx+vT6ourWXvMcFdDuh7m7SLGSmRXmGLOArIQDo74m3kFjaoo+LbxNoRReGQzTkhGXPwjMruMiTnti9dzOeYm0JLx8GolyOShjENYz0K8LQMrnZAbhJfAZP54XhzKntYHu3h74cf6cNBE20RAwCLS0Dw8iDCtWxYe7ipiehNKhYnlzLloLs5fvqauaqwXjEI4AumLsuL5VAOP8mDwZEkHxeoDblk4yNKZcvmdyjroOtsBS89BdSdfROYVQF2T35e3ebkOo4D7Ms0oLF5jGo8UY46Vj1h4RD3eZ9aN+4zsH2CU00ifgyO672LvX3JbrTmH9XaUtxMj5LQVIdwrZeqrvwF23KlS9fBaR7s5p3is42tmDZFmJlAElyGOWQnkBG4GcSLEnRkyKqNdJ+V5xL3BhYp2SoGET/f4CzPVNaNekxsqbiNTiMAL8NURCyviRyRTlBB4lm8CAuBUjZcohKQWcwbiTRPKQczP6exsDWy9hDz49lZIovjhAGtyt8eLqh+2el6053JGUxL+T/AIl5DT9G90yfkkkLq/GcSqrk8wcjzl03XuT+63Gu8XwTDMT5Whb4VGoYeloQwmTcuNh90fcKTzTMPX5oBjvEHmh75lqG2Zp6ucsOqq7lk/FZHvMJPURAyjgfcwvohwehTgJSnEyKD+7SxaIJ8XrxSb+7pI8ScasbYsSc1JqPuwKcJbT9tCbgnVCjFJ9wUjqMwMbC+yPy4q2QLRn3p3DM= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1c5e9566-3d21-4ecf-bc09-08db4bc57d77 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 10:59:39.1594 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nLpPyJdsMW5etHRUzOyF4UqssSwCwtn2C7JjaiB/OXhGWvJQE1hk/rbQzh7viNA4FnmmbZK4+KI0VosYoGgG4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR03MB7433 On Wed, May 03, 2023 at 12:38:59PM +0200, Jan Beulich wrote: > On 19.04.2023 16:31, Roger Pau Monne wrote: > > The usage of VCPU_SSHOTTMR_future in Linux prior to 4.7 is bogus. > > When the hypervisor returns -ETIME (timeout in the past) Linux keeps > > retrying to setup the timer with a higher timeout instead of > > self-injecting a timer interrupt. > > > > On boxes without any hardware assistance for logdirty we have seen HVM > > Linux guests < 4.7 with 32vCPUs give up trying to setup the timer when > > logdirty is enabled: > > > > CE: Reprogramming failure. Giving up > > CE: xen increased min_delta_ns to 1000000 nsec > > CE: Reprogramming failure. Giving up > > CE: Reprogramming failure. Giving up > > CE: xen increased min_delta_ns to 506250 nsec > > CE: xen increased min_delta_ns to 759375 nsec > > CE: xen increased min_delta_ns to 1000000 nsec > > CE: Reprogramming failure. Giving up > > CE: Reprogramming failure. Giving up > > CE: Reprogramming failure. Giving up > > Freezing user space processes ... > > INFO: rcu_sched detected stalls on CPUs/tasks: { 14} (detected by 10, t=60002 jiffies, g=4006, c=4005, q=14130) > > Task dump for CPU 14: > > swapper/14 R running task 0 0 1 0x00000000 > > Call Trace: > > [] ? rcu_eqs_enter_common.isra.30+0x3d/0xf0 > > [] ? default_idle+0x1e/0xd0 > > [] ? arch_cpu_idle+0x20/0xc0 > > [] ? cpu_startup_entry+0x14a/0x1e0 > > [] ? start_secondary+0x1f7/0x270 > > [] ? start_cpu+0x5/0x14 > > INFO: rcu_sched detected stalls on CPUs/tasks: { 26} (detected by 24, t=60002 jiffies, g=6922, c=6921, q=7013) > > Task dump for CPU 26: > > swapper/26 R running task 0 0 1 0x00000000 > > Call Trace: > > [] ? rcu_eqs_enter_common.isra.30+0x3d/0xf0 > > [] ? default_idle+0x1e/0xd0 > > [] ? arch_cpu_idle+0x20/0xc0 > > [] ? cpu_startup_entry+0x14a/0x1e0 > > [] ? start_secondary+0x1f7/0x270 > > [] ? start_cpu+0x5/0x14 > > INFO: rcu_sched detected stalls on CPUs/tasks: { 26} (detected by 24, t=60002 jiffies, g=8499, c=8498, q=7664) > > Task dump for CPU 26: > > swapper/26 R running task 0 0 1 0x00000000 > > Call Trace: > > [] ? rcu_eqs_enter_common.isra.30+0x3d/0xf0 > > [] ? default_idle+0x1e/0xd0 > > [] ? arch_cpu_idle+0x20/0xc0 > > [] ? cpu_startup_entry+0x14a/0x1e0 > > [] ? start_secondary+0x1f7/0x270 > > [] ? start_cpu+0x5/0x14 > > > > Thus leading to CPU stalls and a broken system as a result. > > > > Workaround this bogus usage by ignoring the VCPU_SSHOTTMR_future in > > the hypervisor. Old Linux versions are the only ones known to have > > (wrongly) attempted to use the flag, and ignoring it is compatible > > with the behavior expected by any guests setting that flag. > > > > Note the usage of the flag has been removed from Linux by commit: > > > > c06b6d70feb3 xen/x86: don't lose event interrupts > > > > Which landed in Linux 4.7. > > > > Signed-off-by: Roger Pau Monné > > Acked-by: Henry Wang # CHANGELOG > > A little hesitantly, but since no-one else appears to show any interest: > Acked-by: Jan Beulich Thanks. Roger. From xen-devel-bounces@lists.xenproject.org Wed May 03 11:05:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 11:05:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529118.823147 (Exim 4.92) (envelope-from ) id 1puAId-00072v-9o; Wed, 03 May 2023 11:05:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529118.823147; Wed, 03 May 2023 11:05:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puAId-00072o-6c; Wed, 03 May 2023 11:05:31 +0000 Received: by outflank-mailman (input) for mailman id 529118; Wed, 03 May 2023 11:05:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puAIb-00072i-Hv for xen-devel@lists.xenproject.org; Wed, 03 May 2023 11:05:29 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puAIa-0008Mk-FX; Wed, 03 May 2023 11:05:28 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.7.72]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1puAIa-0006zv-7A; Wed, 03 May 2023 11:05:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=AeUrmNI/HwRkNCXfF485hOEexMp7VO2G/kxR0JPvuwo=; b=F3LB9urI+oDNr9Oi8jc/hvixXc SF8yb67dGPIonAapg/89vE52Vay4aODK1HPI+LQZBk9weHdIPx9F3UGnFt7IlqgLsGktOVktzop96 7yn+YuyxcjxWHF5jhCIIdpowGNVRoGihsR3/PaqZJtyvRvZ87J+WR4xK+JJ5yft2nuUs=; Message-ID: <7e8a0e14-51d0-a8aa-1395-6e50a7f6eb94@xen.org> Date: Wed, 3 May 2023 12:05:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] cmdline: document and enforce "extra_guest_irqs" upper bounds Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Volodymyr Babchuk References: <54e126fc-484b-92fa-ce66-f901f92ec19c@suse.com> From: Julien Grall In-Reply-To: <54e126fc-484b-92fa-ce66-f901f92ec19c@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 04/04/2023 10:20, Jan Beulich wrote: > PHYSDEVOP_pirq_eoi_gmfn_v accepting just a single GFN implies that no > more than 32k pIRQ-s can be used by a domain on x86. Document this upper > bound. > > To also enforce the limit, (ab)use both arch_hwdom_irqs() (changing its > parameter type) and setup_system_domains(). This is primarily to avoid > exposing the two static variables or introducing yet further arch hooks. > > Signed-off-by: Jan Beulich > --- > Instead of passing dom_xen into arch_hwdom_irqs(), NULL could also be > used. That would make the connection to setup_system_domains() yet more > weak, though. > > On Arm the upper limit right now effectively is zero, albeit with - > afaict - no impact if a higher value was used (and hence permitting up > to the default of 32 is okay albeit useless). The question though is > whether the command line option as a whole shouldn't be x86-only. AFAIK, ->nr_pirq is not used at all on Arm because we don't have any concept of PIRQs. So I think it would be fine to move the command line option to x86-only (assuming this will not be needed on RISC-V). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 03 11:06:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 11:06:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529121.823156 (Exim 4.92) (envelope-from ) id 1puAJc-0007aO-Hk; Wed, 03 May 2023 11:06:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529121.823156; Wed, 03 May 2023 11:06:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puAJc-0007aH-F9; Wed, 03 May 2023 11:06:32 +0000 Received: by outflank-mailman (input) for mailman id 529121; Wed, 03 May 2023 11:06:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puAJb-0007a3-4d for xen-devel@lists.xenproject.org; Wed, 03 May 2023 11:06:31 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puAJX-0008Ng-I3; Wed, 03 May 2023 11:06:27 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[192.168.7.72]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1puAJX-000738-Ak; Wed, 03 May 2023 11:06:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=n1oLv0j52Jg7zu+EwY2y3c3OMNeTuHcEx0S6u4b3fxM=; b=2WQzMLvM1+lZKuSD/9ZVSNwxHX tsqrkqI5jff+/YehoXDRIQwxCwEOX1EvxzezCMrak5bEakJO4MKwPiqW8M+lkWeYkJtZjsV2j6yEZ i8kTmPlimc1vPVGkVkh70RzXUoPy4AS/Faww/SHaYZSdY2g+cf+3ihzAj4OGaHh9tIXU=; Message-ID: Date: Wed, 3 May 2023 12:06:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] cmdline: document and enforce "extra_guest_irqs" upper bounds Content-Language: en-US To: Jan Beulich , Stefano Stabellini , Bertrand Marquis Cc: George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" , Andrew Cooper References: <54e126fc-484b-92fa-ce66-f901f92ec19c@suse.com> <6c5cdffa-f3fb-8f40-c44f-ad7431451929@citrix.com> <9f319f7b-5080-2802-09e0-2793d9dad1a7@suse.com> From: Julien Grall In-Reply-To: <9f319f7b-5080-2802-09e0-2793d9dad1a7@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 03/05/2023 11:43, Jan Beulich wrote: > On 04.04.2023 12:40, Jan Beulich wrote: >> On 04.04.2023 12:34, Andrew Cooper wrote: >>> On 04/04/2023 10:20 am, Jan Beulich wrote: >>>> --- a/xen/arch/arm/include/asm/irq.h >>>> +++ b/xen/arch/arm/include/asm/irq.h >>>> @@ -52,7 +52,7 @@ struct arch_irq_desc { >>>> >>>> extern const unsigned int nr_irqs; >>>> #define nr_static_irqs NR_IRQS >>>> -#define arch_hwdom_irqs(domid) NR_IRQS >>>> +#define arch_hwdom_irqs(d) NR_IRQS >>> >>> I know it's not your bug, but this ought to be (d, NR_IRQS) as you're >>> changing it. >> >> I can add this (with a cast to void), but I'll leave the final say to >> Arm maintainers. > > Arm maintainers, > > may I ask for some kind of statement here? I'd be happy to follow > Andrew's request, but I don't want to then end up with an "unrelated > change" objection. I am OK so long it is mentioned in the commit message. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 03 11:18:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 11:18:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529124.823167 (Exim 4.92) (envelope-from ) id 1puAUp-0000iM-IV; Wed, 03 May 2023 11:18:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529124.823167; Wed, 03 May 2023 11:18:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puAUp-0000iF-F2; Wed, 03 May 2023 11:18:07 +0000 Received: by outflank-mailman (input) for mailman id 529124; Wed, 03 May 2023 11:18:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puAUo-0000i9-7U for xen-devel@lists.xenproject.org; Wed, 03 May 2023 11:18:06 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puAUn-00007V-Gv; Wed, 03 May 2023 11:18:05 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[192.168.7.72]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1puAUn-0007XG-8n; Wed, 03 May 2023 11:18:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=LM+GbpkIg/ENzcdPKrIAU1+f7oH9sLXG/MVrC12j6Cs=; b=LlQVSYlyBgU1o3n5F7uai8ef/v VFQCFcZJxiP5Z3aaDKYXsFA4bLKPheX1k4/NRDQTa0/RGNR//jXsx2urJev4N5odebmF9lh9uFYvd J+8mM6EyMpiJfLfrI2uwo4xgsg3e4Er1AUp7K0wOhSjMpnTtFRA2BOTgaMav38vI393g=; Message-ID: <935ea085-5a82-973a-00cf-b5f57b4e769b@xen.org> Date: Wed, 3 May 2023 12:18:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [XEN v6 02/12] xen/arm: Typecast the DT values into paddr_t Content-Language: en-US To: Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, wl@xen.org, rahul.singh@arm.com References: <20230428175543.11902-1-ayan.kumar.halder@amd.com> <20230428175543.11902-3-ayan.kumar.halder@amd.com> From: Julien Grall In-Reply-To: <20230428175543.11902-3-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 28/04/2023 18:55, Ayan Kumar Halder wrote: > The DT functions (dt_read_number(), device_tree_get_reg(), fdt_get_mem_rsv()) > currently accept or return 64-bit values. > > In future when we support 32-bit physical address, these DT functions are > expected to accept/return 32-bit or 64-bit values (depending on the width of > physical address). Also, we wish to detect if any truncation has occurred > (i.e. while parsing 32-bit physical addresses from 64-bit values read from DT). > > device_tree_get_reg() should now be able to return paddr_t. This is invoked by > various callers to get DT address and size. > > For fdt_get_mem_rsv(), we have introduced a wrapper named > fdt_get_mem_rsv_paddr() which will invoke fdt_get_mem_rsv() and translate > uint64_t to paddr_t. The reason being we cannot modify fdt_get_mem_rsv() as it > has been imported from external source. > > For dt_read_number(), we have also introduced a wrapper named dt_read_paddr() > dt_read_paddr() to read physical addresses. We chose not to modify the original > function as it is used in places where it needs to specifically read 64-bit > values from dt (For e.g. dt_property_read_u64()). > > Xen prints warning when it detects truncation in cases where it is not able to > return error. > > Also, replaced u32/u64 with uint32_t/uint64_t in the functions touched > by the code changes. > > Signed-off-by: Ayan Kumar Halder Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 03 11:25:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 11:25:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529130.823177 (Exim 4.92) (envelope-from ) id 1puAba-0002Aj-Bj; Wed, 03 May 2023 11:25:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529130.823177; Wed, 03 May 2023 11:25:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puAba-0002Ac-8Z; Wed, 03 May 2023 11:25:06 +0000 Received: by outflank-mailman (input) for mailman id 529130; Wed, 03 May 2023 11:25:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puAbZ-0002AW-RE for xen-devel@lists.xenproject.org; Wed, 03 May 2023 11:25:05 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puAbZ-0000GD-Bn; Wed, 03 May 2023 11:25:05 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.7.72]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1puAbZ-0007oI-3q; Wed, 03 May 2023 11:25:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=6sG+lt55RW6cg3w+0EPGSycs/EzwUim5Jp6dpCWi5DA=; b=UD0X50o87WcMeQjBXdYmyau2vZ mziPLsMUO/gH64SjlIlcx2dE/LG+bTr+1AjCWgCjh7/vX0EjWzc3gzj6T39UaF5wLBEDx+SmiZX51 Eiu4qKc/7LHJp19Ss4qd7Gvs3lK6hyv92fbO5jDOXA2DPEkoBbzJagznZTmJ0OjcRyp4=; Message-ID: <37c9a45f-ae07-8d47-093a-6cf7501389d4@xen.org> Date: Wed, 3 May 2023 12:25:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [XEN v6 03/12] xen/arm: Introduce a wrapper for dt_device_get_address() to handle paddr_t Content-Language: en-US To: Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, wl@xen.org, rahul.singh@arm.com References: <20230428175543.11902-1-ayan.kumar.halder@amd.com> <20230428175543.11902-4-ayan.kumar.halder@amd.com> From: Julien Grall In-Reply-To: <20230428175543.11902-4-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Ayan, On 28/04/2023 18:55, Ayan Kumar Halder wrote: > dt_device_get_address() can accept uint64_t only for address and size. > However, the address/size denotes physical addresses. Thus, they should > be represented by 'paddr_t'. > Consequently, we introduce a wrapper for dt_device_get_address() ie > dt_device_get_paddr() which accepts address/size as paddr_t and inturn > invokes dt_device_get_address() after converting address/size to > uint64_t. > > The reason for introducing this is that in future 'paddr_t' may not > always be 64-bit. Thus, we need an explicit wrapper to do the type > conversion and return an error in case of truncation. > > With this, callers can now invoke dt_device_get_paddr(). > > Signed-off-by: Ayan Kumar Halder > --- > Changes from - > > v1 - 1. New patch. > > v2 - 1. Extracted part of "[XEN v2 05/11] xen/arm: Use paddr_t instead of u64 for address/size" > into this patch. > > 2. dt_device_get_address() callers now invoke dt_device_get_paddr() instead. > > 3. Logged error in case of truncation. > > v3 - 1. Modified the truncation checks as "dt_addr != (paddr_t)dt_addr". > 2. Some sanity fixes. > > v4 - 1. Some sanity fixes. > 2. Preserved the declaration of dt_device_get_address() in > xen/include/xen/device_tree.h. The reason being it is currently used by > ns16550.c. This driver requires some more changes as pointed by Jan in > https://lore.kernel.org/xen-devel/6196e90f-752e-e61a-45ce-37e46c22b812@suse.com/ > which is to be addressed as a separate series. > > v5 - 1. Removed initialization of variables. > 2. In dt_device_get_paddr(), added the check > if ( !addr ) > return -EINVAL; > > xen/arch/arm/domain_build.c | 10 +++--- > xen/arch/arm/gic-v2.c | 10 +++--- > xen/arch/arm/gic-v3-its.c | 4 +-- > xen/arch/arm/gic-v3.c | 10 +++--- > xen/arch/arm/pci/pci-host-common.c | 6 ++-- > xen/arch/arm/platforms/brcm-raspberry-pi.c | 2 +- > xen/arch/arm/platforms/brcm.c | 6 ++-- > xen/arch/arm/platforms/exynos5.c | 32 +++++++++--------- > xen/arch/arm/platforms/sunxi.c | 2 +- > xen/arch/arm/platforms/xgene-storm.c | 2 +- > xen/common/device_tree.c | 39 ++++++++++++++++++++++ > xen/drivers/char/cadence-uart.c | 4 +-- > xen/drivers/char/exynos4210-uart.c | 4 +-- > xen/drivers/char/imx-lpuart.c | 4 +-- > xen/drivers/char/meson-uart.c | 4 +-- > xen/drivers/char/mvebu-uart.c | 4 +-- > xen/drivers/char/omap-uart.c | 4 +-- > xen/drivers/char/pl011.c | 6 ++-- > xen/drivers/char/scif-uart.c | 4 +-- What about the call in xen/drivers/char/ns16550.c? > xen/drivers/passthrough/arm/ipmmu-vmsa.c | 8 ++--- > xen/drivers/passthrough/arm/smmu-v3.c | 2 +- > xen/drivers/passthrough/arm/smmu.c | 8 ++--- > xen/include/xen/device_tree.h | 13 ++++++++ > 23 files changed, 120 insertions(+), 68 deletions(-) Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 03 11:41:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 11:41:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529132.823186 (Exim 4.92) (envelope-from ) id 1puAr2-0004am-Pf; Wed, 03 May 2023 11:41:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529132.823186; Wed, 03 May 2023 11:41:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puAr2-0004af-M9; Wed, 03 May 2023 11:41:04 +0000 Received: by outflank-mailman (input) for mailman id 529132; Wed, 03 May 2023 11:41:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puAr1-0004aZ-1j for xen-devel@lists.xenproject.org; Wed, 03 May 2023 11:41:03 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5ea33c10-e9a7-11ed-8611-37d641c3527e; Wed, 03 May 2023 13:40:58 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-638-0-m7RWIiMhaNdaGkO17WiQ-1; Wed, 03 May 2023 07:40:55 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6BEB7A0F386; Wed, 3 May 2023 11:40:54 +0000 (UTC) Received: from redhat.com (dhcp-192-205.str.redhat.com [10.33.192.205]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 132F1405DBBC; Wed, 3 May 2023 11:40:49 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5ea33c10-e9a7-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683114057; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dRwOSZS087B+j9NDbbckQmSe0NEnNmqFyABRgslLrL0=; b=QathHsffgtsumWCQxOd1tvVwCEFZzKWMwfiTHAJ3ebD2ZZ5FHqBTZdNG2IcXPYPUlkkiQq XFOSdcpdSe1h66XSIeiG8P5VMBhL45pwU7r3fLIgrikl3bUU8KklC/J2h+JoTaOXvC9oHp 90TxTV5HTVBVLnIIcRqNdnsmfXJYxsQ= X-MC-Unique: 0-m7RWIiMhaNdaGkO17WiQ-1 Date: Wed, 3 May 2023 13:40:49 +0200 From: Kevin Wolf To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Juan Quintela , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Richard Henderson , Fam Zheng , "Michael S. Tsirkin" , Coiby Xu , David Woodhouse , Marcel Apfelbaum , Peter Lieven , Paul Durrant , "Richard W.M. Jones" , qemu-block@nongnu.org, Stefano Garzarella , Anthony Perard , Stefan Weil , Xie Yongji , Paolo Bonzini , Aarushi Mehta , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Eduardo Habkost , Stefano Stabellini , Hanna Reitz , Ronnie Sahlberg , Zhengui Li , Daniil Tatianin Subject: Re: [PATCH v4 04/20] virtio-scsi: stop using aio_disable_external() during unplug Message-ID: References: <20230425172716.1033562-1-stefanha@redhat.com> <20230425172716.1033562-5-stefanha@redhat.com> <20230501150934.GA14869@fedora> <20230502200243.GD535070@fedora> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Sh4VljrAVjcetdM0" Content-Disposition: inline In-Reply-To: <20230502200243.GD535070@fedora> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 --Sh4VljrAVjcetdM0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 02.05.2023 um 22:02 hat Stefan Hajnoczi geschrieben: > On Tue, May 02, 2023 at 03:19:52PM +0200, Kevin Wolf wrote: > > Am 01.05.2023 um 17:09 hat Stefan Hajnoczi geschrieben: > > > On Fri, Apr 28, 2023 at 04:22:55PM +0200, Kevin Wolf wrote: > > > > Am 25.04.2023 um 19:27 hat Stefan Hajnoczi geschrieben: > > > > > This patch is part of an effort to remove the aio_disable_externa= l() > > > > > API because it does not fit in a multi-queue block layer world wh= ere > > > > > many AioContexts may be submitting requests to the same disk. > > > > >=20 > > > > > The SCSI emulation code is already in good shape to stop using > > > > > aio_disable_external(). It was only used by commit 9c5aad84da1c > > > > > ("virtio-scsi: fixed virtio_scsi_ctx_check failed when detaching = scsi > > > > > disk") to ensure that virtio_scsi_hotunplug() works while the gue= st > > > > > driver is submitting I/O. > > > > >=20 > > > > > Ensure virtio_scsi_hotunplug() is safe as follows: > > > > >=20 > > > > > 1. qdev_simple_device_unplug_cb() -> qdev_unrealize() -> > > > > > device_set_realized() calls qatomic_set(&dev->realized, false)= so > > > > > that future scsi_device_get() calls return NULL because they e= xclude > > > > > SCSIDevices with realized=3Dfalse. > > > > >=20 > > > > > That means virtio-scsi will reject new I/O requests to this > > > > > SCSIDevice with VIRTIO_SCSI_S_BAD_TARGET even while > > > > > virtio_scsi_hotunplug() is still executing. We are protected a= gainst > > > > > new requests! > > > > >=20 > > > > > 2. Add a call to scsi_device_purge_requests() from scsi_unrealize= () so > > > > > that in-flight requests are cancelled synchronously. This ensu= res > > > > > that no in-flight requests remain once qdev_simple_device_unpl= ug_cb() > > > > > returns. > > > > >=20 > > > > > Thanks to these two conditions we don't need aio_disable_external= () > > > > > anymore. > > > > >=20 > > > > > Cc: Zhengui Li > > > > > Reviewed-by: Paolo Bonzini > > > > > Reviewed-by: Daniil Tatianin > > > > > Signed-off-by: Stefan Hajnoczi > > > >=20 > > > > qemu-iotests 040 starts failing for me after this patch, with what = looks > > > > like a use-after-free error of some kind. > > > >=20 > > > > (gdb) bt > > > > #0 0x000055b6e3e1f31c in job_type (job=3D0xe3e3e3e3e3e3e3e3) at ..= /job.c:238 > > > > #1 0x000055b6e3e1cee5 in is_block_job (job=3D0xe3e3e3e3e3e3e3e3) a= t ../blockjob.c:41 > > > > #2 0x000055b6e3e1ce7d in block_job_next_locked (bjob=3D0x55b6e72b7= 570) at ../blockjob.c:54 > > > > #3 0x000055b6e3df6370 in blockdev_mark_auto_del (blk=3D0x55b6e74af= 0a0) at ../blockdev.c:157 > > > > #4 0x000055b6e393e23b in scsi_qdev_unrealize (qdev=3D0x55b6e7c04d4= 0) at ../hw/scsi/scsi-bus.c:303 > > > > #5 0x000055b6e3db0d0e in device_set_realized (obj=3D0x55b6e7c04d40= , value=3Dfalse, errp=3D0x55b6e497c918 ) at ../hw/core/qdev.c:= 599 > > > > #6 0x000055b6e3dba36e in property_set_bool (obj=3D0x55b6e7c04d40, = v=3D0x55b6e7d7f290, name=3D0x55b6e41bd6d8 "realized", opaque=3D0x55b6e7246d= 20, errp=3D0x55b6e497c918 ) > > > > at ../qom/object.c:2285 > > > > #7 0x000055b6e3db7e65 in object_property_set (obj=3D0x55b6e7c04d40= , name=3D0x55b6e41bd6d8 "realized", v=3D0x55b6e7d7f290, errp=3D0x55b6e497c9= 18 ) at ../qom/object.c:1420 > > > > #8 0x000055b6e3dbd84a in object_property_set_qobject (obj=3D0x55b6= e7c04d40, name=3D0x55b6e41bd6d8 "realized", value=3D0x55b6e74c1890, errp=3D= 0x55b6e497c918 ) > > > > at ../qom/qom-qobject.c:28 > > > > #9 0x000055b6e3db8570 in object_property_set_bool (obj=3D0x55b6e7c= 04d40, name=3D0x55b6e41bd6d8 "realized", value=3Dfalse, errp=3D0x55b6e497c9= 18 ) at ../qom/object.c:1489 > > > > #10 0x000055b6e3daf2b5 in qdev_unrealize (dev=3D0x55b6e7c04d40) at = =2E./hw/core/qdev.c:306 > > > > #11 0x000055b6e3db509d in qdev_simple_device_unplug_cb (hotplug_dev= =3D0x55b6e81c3630, dev=3D0x55b6e7c04d40, errp=3D0x7ffec5519200) at ../hw/co= re/qdev-hotplug.c:72 > > > > #12 0x000055b6e3c520f9 in virtio_scsi_hotunplug (hotplug_dev=3D0x55= b6e81c3630, dev=3D0x55b6e7c04d40, errp=3D0x7ffec5519200) at ../hw/scsi/virt= io-scsi.c:1065 > > > > #13 0x000055b6e3db4dec in hotplug_handler_unplug (plug_handler=3D0x= 55b6e81c3630, plugged_dev=3D0x55b6e7c04d40, errp=3D0x7ffec5519200) at ../hw= /core/hotplug.c:56 > > > > #14 0x000055b6e3a28f84 in qdev_unplug (dev=3D0x55b6e7c04d40, errp= =3D0x7ffec55192e0) at ../softmmu/qdev-monitor.c:935 > > > > #15 0x000055b6e3a290fa in qmp_device_del (id=3D0x55b6e74c1760 "scsi= 0", errp=3D0x7ffec55192e0) at ../softmmu/qdev-monitor.c:955 > > > > #16 0x000055b6e3fb0a5f in qmp_marshal_device_del (args=3D0x7f61cc00= 5eb0, ret=3D0x7f61d5a8ae38, errp=3D0x7f61d5a8ae40) at qapi/qapi-commands-qd= ev.c:114 > > > > #17 0x000055b6e3fd52e1 in do_qmp_dispatch_bh (opaque=3D0x7f61d5a8ae= 08) at ../qapi/qmp-dispatch.c:128 > > > > #18 0x000055b6e4007b9e in aio_bh_call (bh=3D0x55b6e7dea730) at ../u= til/async.c:155 > > > > #19 0x000055b6e4007d2e in aio_bh_poll (ctx=3D0x55b6e72447c0) at ../= util/async.c:184 > > > > #20 0x000055b6e3fe3b45 in aio_dispatch (ctx=3D0x55b6e72447c0) at ..= /util/aio-posix.c:421 > > > > #21 0x000055b6e4009544 in aio_ctx_dispatch (source=3D0x55b6e72447c0= , callback=3D0x0, user_data=3D0x0) at ../util/async.c:326 > > > > #22 0x00007f61ddc14c7f in g_main_dispatch (context=3D0x55b6e7244b20= ) at ../glib/gmain.c:3454 > > > > #23 g_main_context_dispatch (context=3D0x55b6e7244b20) at ../glib/g= main.c:4172 > > > > #24 0x000055b6e400a7e8 in glib_pollfds_poll () at ../util/main-loop= =2Ec:290 > > > > #25 0x000055b6e400a0c2 in os_host_main_loop_wait (timeout=3D0) at .= =2E/util/main-loop.c:313 > > > > #26 0x000055b6e4009fa2 in main_loop_wait (nonblocking=3D0) at ../ut= il/main-loop.c:592 > > > > #27 0x000055b6e3a3047b in qemu_main_loop () at ../softmmu/runstate.= c:731 > > > > #28 0x000055b6e3dab27d in qemu_default_main () at ../softmmu/main.c= :37 > > > > #29 0x000055b6e3dab2b8 in main (argc=3D24, argv=3D0x7ffec55196a8) a= t ../softmmu/main.c:48 > > > > (gdb) p jobs > > > > $4 =3D {lh_first =3D 0x0} > > >=20 > > > I wasn't able to reproduce this with gcc 13.1.1 or clang 16.0.1: > > >=20 > > > $ tests/qemu-iotests/check -qcow2 040 > > >=20 > > > Any suggestions on how to reproduce the issue? > >=20 > > It happens consistently for me with the same command line, both with gcc > > and clang. > >=20 > > gcc (GCC) 12.2.1 20221121 (Red Hat 12.2.1-4) > > clang version 15.0.7 (Fedora 15.0.7-2.fc37) > >=20 > > Maybe there is a semantic merge conflict? I have applied the series on > > top of master (05d50ba2d4) and my block branch (88f81f7bc8). >=20 > I can't find 88f81f7bc8 but rebased on repo.or.cz/qemu/kevin.git block > (4514dac7f2e9) and the test passes here. >=20 > I rebased on qemu.git/master (05d50ba2d4) and it also passes. >=20 > Please let me know if the following tree (a0ff680a72f6) works on your > machine: > https://gitlab.com/stefanha/qemu/-/tree/remove-aio_disable_external Fails in the same way. So I tried to debug this myself now. The problem is that iterating the jobs in blockdev_mark_auto_del() is incorrect: job_cancel_locked() frees the job and then block_job_next_locked() is a use after free. It also drops job_mutex temporarily and polls, so even switching to a *_FOREACH_SAFE style loop won't fix this. I guess we have to restart the whole search from the start after a job_cancel_locked() because the list might look very different after the call. Now, of course, how this is related to your patch and why it doesn't trigger before it, is still less than clear. What I found out is that adding the scsi_device_purge_requests() is enough to crash it. Maybe it's related to the blk_drain() inside of it. That the job finishes earlier during the unplug now or something like that. Anyway, changing blockdev_mark_auto_del() fixes it. I'll send a patch. Kevin --Sh4VljrAVjcetdM0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE3D3rFZqa+V09dFb+fwmycsiPL9YFAmRSSEAACgkQfwmycsiP L9Z4jRAAvTT64p9bQdNSCCIFrqkkGEZS5J/8ud4wvKBgYacJ8pOY30Z2B3dA78bz ik5KMZlaTa4GXFwlKGNn/OUGiB3ivuhXeIUHXv+pw8F9sCQy4WJDpeO6WPDtQ6Os swWWC3Uv+cnfLQH8dZjf4yoLY4hYACt683Ptml960LIYhpX/AXjdnOv6f/tj3gXO q+mxfLwTi5S08Kkq08e8sXbqCwSiTPXX106MDdk/oMD3MxzUmqu6qFxrf9n6Yp5i kI1rJD0VR64ScA58lJlFnAdZGWL7d9kX5WUbZ+x27lLay4Uel4cmY9AIsUWThnHZ fMk2Sol1aUKSEAlVdHL5vWbQF/UyYe+KB2tn++4HJZ/ojVBL1GNdnWgmk+ZPXGfI BtIc5+h7Qsa2uXUX2gJQYP7j6Y/EBQMAT0oTlG2v+CxS+1MrSa4O9ufnx1c9hoLF FOUU2CT4vrJlYI281yWZ5R6pZrm0ZJMHAGStCJH4/ayo1xVj/5gPdffIRksFwUzy yfia4Pis1nU9ET5riOk4WTCHz44BgIPvkDSYe1aJMS9XT3DM6MsZm9shuUMueLBd 0H5rU7ScgGB6ZLJLOQN0m84AfHOrxSgo7+bdAmXriAYvgDwr9B6fc50cDUBOEGNo zDb0PBH7R3fZT9rEpHlQi4t3SOBkDV3L1toGvWHYymLPkzOC3/w= =9639 -----END PGP SIGNATURE----- --Sh4VljrAVjcetdM0-- From xen-devel-bounces@lists.xenproject.org Wed May 03 11:42:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 11:42:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529137.823197 (Exim 4.92) (envelope-from ) id 1puAsU-0005Ad-7I; Wed, 03 May 2023 11:42:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529137.823197; Wed, 03 May 2023 11:42:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puAsU-0005AW-4W; Wed, 03 May 2023 11:42:34 +0000 Received: by outflank-mailman (input) for mailman id 529137; Wed, 03 May 2023 11:42:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puAsS-0005AQ-QW for xen-devel@lists.xen.org; Wed, 03 May 2023 11:42:32 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20607.outbound.protection.outlook.com [2a01:111:f400:7e1a::607]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 96bd1c28-e9a7-11ed-b225-6b7b168915f2; Wed, 03 May 2023 13:42:31 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AM7PR04MB6998.eurprd04.prod.outlook.com (2603:10a6:20b:10a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.33; Wed, 3 May 2023 11:42:29 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 11:42:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 96bd1c28-e9a7-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jzIJHT4HhHUjeJNm9Xv4nW2Mc4JnyDJHVwILzK1biKIll3zQkfRVloH9QIqqwyXKpe7WtUwgSmy3sQ16nvm7n53i01Ib53ODdFW4wBkxvFeecIuL5QBu44kXLSIRcTKyaZcAYQgz60iekk/AD2F2R88vJz7fpQRwwZe0gn5b2V3iYbB7fWVB9e2CTmp7+H/gOnL/kaStwQYsNnQ5sSfXhRrU3Sk3gTyH4biXkv+/+qU2ssjstGb/W9VpqNx8kjvy3L/b+cj38lHKwgkh0LlQEtsYhfBi+5h3vWfy65R4WdIRiNZrivGCMLNcxYZ8URw77jZtGEZgDIL4xIrEQfTAiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T6yWBchkBNgoC9CCoa83SX//6pM98VoMRlufZMx9IEM=; b=IofnN4TDjXT29HplfUE20jkIWNUP2ZHTcDn89WiqK+UMsg+DWahRY5fBm+z6wAR7h8/dEZjIFRDuP6rkUZXNluFX19V6jZ5avoC6KirOceNJxzeSJ6DEEYqrhUdGsKurDv/rt+bf60enQ/5KLQrckMTEOaBP3ELQQ3+voGcY1iiPSSq2flZSYb1R1oTYGvwfyKCZr/JqyEJruzQdDACJaR0qSt3Z6ogZPWDMeo7M1xyb4Elj+FnASURJezFnv0B5koaxiGgh7nrMhBeEZoNDIX/LkFxuFQzSUILicT4sAV7Bv+5OiOrjO4seh2j2Me5WRciBvVw4sM1usA30RLGlpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T6yWBchkBNgoC9CCoa83SX//6pM98VoMRlufZMx9IEM=; b=wZZcmxFX77cbgKZ1aJXQExSyrxQd7BzNO2ILww8/BBZLPIEDTMf6p1I5b3eN/DxqC0w44goDt17QPb3JKQlUffdJjN1PWAgq01UjiE8njkG2BKF9Uv3zcjorySA0AzVGD2j9N7Y07Y/MvpLS6XYFQkZLmHlKAZDFcLMuxiFnIX4lXsHpGq4IisKs9Ua9pjekCqpOX31SNVjngZff+/9FynlfpgHEkpxYZn+SB0GOxbLZtAqmy/EijRO3nSGVKxJhXQtthxn40ssizIg/olOZpH8WkzGAG2ivMLKJSwxyjEez+67Op+yoeDhZHxzQxTaIb2tnMzmCjoJMOml8AStebg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6d18f284-8cf9-4c21-7057-5f53bd98536e@suse.com> Date: Wed, 3 May 2023 13:42:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH V3 2/2] libxl: fix matching of generic virtio device Content-Language: en-US To: Viresh Kumar , Anthony PERARD , Wei Liu Cc: Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?Q?Alex_Benn=c3=a9e?= , Mathieu Poirier , Oleksandr Tyshchenko , Erik Schilling , Oleksandr Tyshchenko , xen-devel@lists.xen.org, Julien Grall , Juergen Gross References: <18458fa39433ce4ac950a0a20cc64da93db0b03a.1680771422.git.viresh.kumar@linaro.org> <888e60d2ec49f53230bc82df393b6bed4180cb8a.1680771422.git.viresh.kumar@linaro.org> From: Jan Beulich In-Reply-To: <888e60d2ec49f53230bc82df393b6bed4180cb8a.1680771422.git.viresh.kumar@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0136.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::10) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|AM7PR04MB6998:EE_ X-MS-Office365-Filtering-Correlation-Id: d8beee39-b378-42c4-f366-08db4bcb7975 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Gnn/WE853ow6ZIQvpxAXQByDhilqk9fVTdBQ/CyqwX3kN8shqwqMMPB7lsr6l3FAq3ofQ83rAzwH3fwyPNQdoxpLzrLtCEnHfC+/6+jQGJIXMk3E0AEyEdRn5bU/X2UygE/cvcsOwCqJqnnrqHZiHxc6nHs8slyoXhDOlGwy0RyiVeC+D+gRmUAsCtR/yhjafnVpJTyH2FQ0YV2ybgwYtPztVQb89YH+h5rIeW5u8KgMSZjr+qkwvl29fo+rDT0bl8KvwcTkdlcHtJd2snOMzqL4/eOkIpQvNJQsfW+zC00dMoAS7I/WNEmgQr5Qq+TbjmEIS+rEeJm+BSWMm7E9GXKsprl8MAEGGEpXwxqaJDXT2Kv7vKhukVqxc1C7iYG6/dxLQsfidgo2SEF73ZeqlNYme/AKfRsjKmRDbPwXUW38UgTuEkvYcHe895QRLXOiuhdKC0ChCJmGj5kfyMa3aPcaI6Qs/mj8P4aBOatqH8ipc472R+HQ3bSrID3UnZ3M0hHxAFV4nlLt0MPDwdyYUNXPbvdQ/A2yKEjOJyMZSxHmkM7tK6HFzY4urhr/4lCGFWdGUMIImFC9EveA9pP8HDsIJ2mfKCxq4zHeWj01soQWwYhvFnE4S14hn/wu+4YJ5RqYa9EWvmvz5ySL1ZpQ1HAQxpiXNGKmPnUzDxDl3nk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(136003)(39860400002)(376002)(366004)(346002)(451199021)(2616005)(6506007)(83380400001)(2906002)(26005)(6512007)(53546011)(41300700001)(4326008)(66946007)(66476007)(66556008)(316002)(110136005)(54906003)(186003)(7416002)(107886003)(5660300002)(6486002)(8936002)(8676002)(478600001)(38100700002)(86362001)(31696002)(36756003)(31686004)(41533002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SlBtMEZGeHBRcWVwMHB4aWF1dnBMN1oyTElpYXAxM2NZVXJDNEdIb0ZSbGgw?= =?utf-8?B?R2FzUkJHVWpBNElOc3NXUkk3RjZhT3BjSWZDMlBxK0xNYXZJV0xweG1iRHhR?= =?utf-8?B?U29TNjdjbmloYkxnOFA3dkJ0UnhMU0VLTlgzZUgrVU8rb2IrYVJJOGZBYjBS?= =?utf-8?B?UUx4QlJhK2F4eUREQWpIci9LUlU3R1FZc2hhT29lc05nenRtL3JZQnNIdGJP?= =?utf-8?B?TTJUWWNDV0lVMFcvbkdRUHNHTjBvS0NWUWs2c1lqYWhaY29KNzNxQ1pOZjI3?= =?utf-8?B?bVM2MzVuR3pwdEtNbFBRVUsvT1lJV2RTSERrNTV2ZXp5R0VqclFFdE0vWUxx?= =?utf-8?B?aktEaFZlNXYxUU41RDdyT05NMnBoa3BxczdUZDB1c0NBUGRUZ0F0ZWdGTGtr?= =?utf-8?B?YnRqUlBsWWJ4cy95OGEzTmpFWXhHcmFSMmFMVDV0SXZ2ZHBsQ3pXMDJvQWJk?= =?utf-8?B?dGlGSVBlVFhlaTVRQkkyZGpSOHFnRngrb3BLMnU4dGZjaE1Gcy9tb0NEdmNt?= =?utf-8?B?MkJXbU01bE0xQ3JJdzdUR0ZDUldjeVNnQVRHa05PSisxYnJZc0thOHlGTXkw?= =?utf-8?B?SElTd0cybTRtcmFlTmFhZUU4QkdvcEVoTzRHYVU5cjN2dkk3U1l0bzhBY1Nm?= =?utf-8?B?QWlSU1pMVFNkY0UwQzVQR1hzZnhWdWpMNmZHMGs4T2MwQVRpT3lzTGE4Y3U5?= =?utf-8?B?aGZ2OUxoMUx1cy9kbzRwK0pxTVV6MlBJK0tTamRpMVZNeUdsU2ZPL2VwY3NQ?= =?utf-8?B?OC9xdUNkOFNNckpxaUJUWDlBVHQxZUg0ak1PeUY4TVgxWkZkYXN6MTJqd3VP?= =?utf-8?B?N3JXNGJkNVFTZjdUY3hkeGZNTUxObGRiQ0R2aUhQQTdxZklJSXNrRlo5dy95?= =?utf-8?B?NFFQa3h0eFd2S0pFQ3lwblE4ME9JTUh0TWt2djEyaU80a2I4UzM5c0dvVjVX?= =?utf-8?B?WklleWY5azI1VGF1WmhHbFk5UmRkVmJQQ2d4Y0FKY3VJME44cllDT0pEbUdu?= =?utf-8?B?TFc4V3BNSVNZcSsxK2RpdDlKOTJMaTNveHVUdzlSVXhMTzNRTzNjcWluRUxW?= =?utf-8?B?RFlETEdMV1lLNzhvb0U4dXRwbFJoR29rZlhubzIwNUVJbjRqckF1bVFlMGxB?= =?utf-8?B?TVhhZ0RYMThwYTMrTm1SN2ZEVngxTHVtR1RtZCtFcGVKSFhoVHUwMHpRaDk1?= =?utf-8?B?RVNlMktBUkltUFhITXNkL1VKZ1dOQk9xTmRoNUl3UXlJNVFvOXl0d2w5Sjc2?= =?utf-8?B?TUJ5eWMrbzJKa1Eya2VWcExSR2xmeUdWbDc0SDZXSGZDdWpkdU1nMVZWMDk0?= =?utf-8?B?cjcvSWdKUGZ3cFRiT2RvSUsvK0pZRWNMUTJvSUh4UHZrczVhNUo1YlM0bXo5?= =?utf-8?B?MEh3VjY3VXZ2RE5EVVhTYVZWODlNUlZnR1QwTTJDcmNtUS9PQVYrb1FFL3lt?= =?utf-8?B?clRVNlJZZ000Y3FIR241S1ArOE5JUTZpbytkM1pSYWlTU29MOHo2ckxtYjVh?= =?utf-8?B?dEdOSlJ2TCtZQ2hTaHJMZHJHRS9IV2I3dDZoZlEzREdmQTE5MXhURG1JV3hW?= =?utf-8?B?SnVDb05tT0xCdFdlVDVoTzRDVW9lbmx0NlM5dTFlMDRVclRWYWtUVmVmZ2V1?= =?utf-8?B?bmIveWh2OW9pSWlxQXBpYithUnJ0K1JHY1IvSm1aYlZDdmY0ZklWTGdCY1NR?= =?utf-8?B?R0psa2NodVFnWnd4ZkV2bENJbWs2aFJEaUpXTVBaUDhpU1RPYmo5cWNnRWM2?= =?utf-8?B?dVMxOW9MTjhZM0pVNi9CVEluSy9OUmFnT2dmZ3FVNFB2L3c1bjRhamgveEt0?= =?utf-8?B?Q0dWZGNCeTFkbTBEZEU4cEsrL20reklzUzlJdnhWUUs3eFVoT2toZUdWdlha?= =?utf-8?B?MjNaRXZOMU1GQzBGZHRQYlJSTTZZaW93THFTQ0IwZ0h6M1RwWmtkUWN4Znlh?= =?utf-8?B?bnBKMmJJQUNsRllaekNwYVFhOVdZcmNRVmIyaFZxZzU5YnVqZ3NsUXNqRzlZ?= =?utf-8?B?MjFucUEwZDk0VWFlN0hHaXdCTXB4SDZWSmdmN2IrRXJoMGFOWlpLcUFLZFph?= =?utf-8?B?d0ltaFJqWGFCTExad0IrUGlpWjZVeGs5MGtzcURBYThaVkNBYU9NdzRNcXI2?= =?utf-8?Q?QQflbsdCZYtY74Gcib3et3qxW?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8beee39-b378-42c4-f366-08db4bcb7975 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 11:42:29.4095 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ajXbDfDc/mJOmnEg/SLlzCr2Co2o+nDsb6Qaaxmmr/9j3NqgErSGuZqW5BQvH3M6m2q+PWoUWgyFXRbSe7hYgQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6998 On 06.04.2023 10:58, Viresh Kumar wrote: > The strings won't be an exact match, as we are only looking to match the > prefix here, i.e. "virtio,device". This is already done properly in > libxl_virtio.c file, lets do the same here too. > > Fixes: 43ba5202e2ee ("libxl: add support for generic virtio device") > Signed-off-by: Viresh Kumar > Reviewed-by: Oleksandr Tyshchenko While I've committed the doc patch (patch 1), I don't think I should commit this one without a maintainer ack, even if it looks pretty straightforward. Anthony, Wei? Jan > --- > V2->V3: > - Tag from Oleksandr. > > tools/libs/light/libxl_arm.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c > index ddc7b2a15975..97c80d7ed0fa 100644 > --- a/tools/libs/light/libxl_arm.c > +++ b/tools/libs/light/libxl_arm.c > @@ -1033,10 +1033,14 @@ static int make_virtio_mmio_node_device(libxl__gc *gc, void *fdt, uint64_t base, > } else if (!strcmp(type, VIRTIO_DEVICE_TYPE_GPIO)) { > res = make_virtio_mmio_node_gpio(gc, fdt); > if (res) return res; > - } else if (strcmp(type, VIRTIO_DEVICE_TYPE_GENERIC)) { > - /* Doesn't match generic virtio device */ > - LOG(ERROR, "Invalid type for virtio device: %s", type); > - return -EINVAL; > + } else { > + int len = sizeof(VIRTIO_DEVICE_TYPE_GENERIC) - 1; > + > + if (strncmp(type, VIRTIO_DEVICE_TYPE_GENERIC, len)) { > + /* Doesn't match generic virtio device */ > + LOG(ERROR, "Invalid type for virtio device: %s", type); > + return -EINVAL; > + } > } > > return fdt_end_node(fdt); From xen-devel-bounces@lists.xenproject.org Wed May 03 12:02:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 12:02:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529144.823208 (Exim 4.92) (envelope-from ) id 1puBBw-0007jJ-5g; Wed, 03 May 2023 12:02:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529144.823208; Wed, 03 May 2023 12:02:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puBBw-0007jC-0v; Wed, 03 May 2023 12:02:40 +0000 Received: by outflank-mailman (input) for mailman id 529144; Wed, 03 May 2023 12:02:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puBBv-0007j6-7E for xen-devel@lists.xenproject.org; Wed, 03 May 2023 12:02:39 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puBBu-0001Cs-Jm; Wed, 03 May 2023 12:02:38 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.7.72]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1puBBu-0001C8-CJ; Wed, 03 May 2023 12:02:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=VMVN2vAC2nE/Zj3G5fg5xXXvofC9KMg65JAvt4knDXs=; b=bdKzYUSOlnV/tUygOkaX1/EW3u f8BtAxDvy73ogFwi9vxzrfB+P3JBJdrgvhWR+d/lZjjWBe/E9T4QTsH4gK+2dE/how1+SBeyQNkW0 pxOOnx+SVRvbUekyof/misBK7tQSuFp2Xj9JIg8txCTjnkluPZ/2K6VzGKMhtm5H9q2I=; Message-ID: <6ab92e3d-03b9-91d3-ef6f-697f69a2debd@xen.org> Date: Wed, 3 May 2023 13:02:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [XEN v6 05/12] xen/arm: Introduce choice to enable 64/32 bit physical addressing Content-Language: en-US To: Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, wl@xen.org, rahul.singh@arm.com References: <20230428175543.11902-1-ayan.kumar.halder@amd.com> <20230428175543.11902-6-ayan.kumar.halder@amd.com> From: Julien Grall In-Reply-To: <20230428175543.11902-6-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Ayan, On 28/04/2023 18:55, Ayan Kumar Halder wrote: > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index 239d3aed3c..192582b61d 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -19,13 +19,41 @@ config ARM > select HAS_PMAP > select IOMMU_FORCE_PT_SHARE > > +menu "Architecture Features" > + > +choice > + prompt "Physical address space size" if ARM_32 > + default ARM_PA_BITS_40 if ARM_32 > + help > + User can choose to represent the width of physical address. This can > + sometimes help in optimizing the size of image when user chooses a > + smaller size to represent physical address. > + > +config ARM_PA_BITS_32 > + bool "32-bit" > + depends on ARM_32 > + select PHYS_ADDR_T_32 > + help > + On platforms where any physical address can be represented within 32 bits, > + user should choose this option. This will help is reduced size of the > + binary. > + > +config ARM_PA_BITS_40 > + bool "40-bit" > + depends on ARM_32 > +endchoice > + > +config PADDR_BITS > + int > + default 32 if ARM_PA_BITS_32 > + default 40 if ARM_PA_BITS_40 > + default 48 if ARM_64 > + > config ARCH_DEFCONFIG Any particular reason to move this config under "Architectures features"? IOW... Why didn't you add... > string > default "arch/arm/configs/arm32_defconfig" if ARM_32 > default "arch/arm/configs/arm64_defconfig" if ARM_64 > > -menu "Architecture Features" > - ... your new config here rather than moving "menu"? > source "arch/Kconfig" > > config ACPI > diff --git a/xen/arch/arm/include/asm/page-bits.h b/xen/arch/arm/include/asm/page-bits.h > index 5d6477e599..deb381ceeb 100644 > --- a/xen/arch/arm/include/asm/page-bits.h > +++ b/xen/arch/arm/include/asm/page-bits.h > @@ -3,10 +3,6 @@ > > #define PAGE_SHIFT 12 > > -#ifdef CONFIG_ARM_64 > -#define PADDR_BITS 48 > -#else > -#define PADDR_BITS 40 > -#endif > +#define PADDR_BITS CONFIG_PADDR_BITS > > #endif /* __ARM_PAGE_SHIFT_H__ */ > diff --git a/xen/arch/arm/include/asm/types.h b/xen/arch/arm/include/asm/types.h > index e218ed77bd..e3cfbbb060 100644 > --- a/xen/arch/arm/include/asm/types.h > +++ b/xen/arch/arm/include/asm/types.h > @@ -34,9 +34,15 @@ typedef signed long long s64; > typedef unsigned long long u64; > typedef u32 vaddr_t; > #define PRIvaddr PRIx32 > +#if defined(CONFIG_PHYS_ADDR_T_32) > +typedef unsigned long paddr_t; Looking at this again, I think this needs an explanation in the commit message and Kconfig at least and possibly in the code why we are not using uint32_t. > +#define INVALID_PADDR (~0UL) > +#define PRIpaddr "08lx" > +#else > typedef u64 paddr_t; > #define INVALID_PADDR (~0ULL) > #define PRIpaddr "016llx" > +#endif > typedef u32 register_t; > #define PRIregister "08x" > #elif defined (CONFIG_ARM_64) > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c > index 74f6ff2c6f..5ef5fd8c49 100644 > --- a/xen/arch/arm/mm.c > +++ b/xen/arch/arm/mm.c > @@ -703,6 +703,11 @@ void __init setup_frametable_mappings(paddr_t ps, paddr_t pe) > const unsigned long mapping_size = frametable_size < MB(32) ? MB(2) : MB(32); > int rc; > > + /* > + * The size of paddr_t should be sufficient for the complete range of > + * physical address. > + */ > + BUILD_BUG_ON((sizeof(paddr_t) * BITS_PER_BYTE) < PADDR_BITS); > BUILD_BUG_ON(sizeof(struct page_info) != PAGE_INFO_SIZE); > > if ( frametable_size > FRAMETABLE_SIZE ) Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 03 12:04:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 12:04:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529147.823217 (Exim 4.92) (envelope-from ) id 1puBDY-0008GX-Do; Wed, 03 May 2023 12:04:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529147.823217; Wed, 03 May 2023 12:04:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puBDY-0008GQ-Ay; Wed, 03 May 2023 12:04:20 +0000 Received: by outflank-mailman (input) for mailman id 529147; Wed, 03 May 2023 12:04:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puBDW-0008GG-Ut for xen-devel@lists.xen.org; Wed, 03 May 2023 12:04:18 +0000 Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a0fd9587-e9aa-11ed-b225-6b7b168915f2; Wed, 03 May 2023 14:04:18 +0200 (CEST) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puBDS-0001Ei-C9; Wed, 03 May 2023 12:04:14 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.7.72]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1puBDS-0001Dc-51; Wed, 03 May 2023 12:04:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a0fd9587-e9aa-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=iFeaJQawpHU0XOg+AJe7sZ7kc1MFF3Cejlix51ECQjA=; b=ea4CyjXpNW1exCleaO5ewKF85H T7g0YCjlRJ4UW32dEVnA6SRQ0vopfcvTP6Yf/Yydfzj4y7OzeLH33F3dBMtZI2jRYKVe7NJ7PF1es vCHmI94K2n0iQlc2Ni+jZ2MFzZfRPOtc6Fqkl1gHVyUt64qYO27fcl2apXyM1ZpYsXZE=; Message-ID: <1e34ae06-c5b1-586a-c840-1dcb768c70e9@xen.org> Date: Wed, 3 May 2023 13:04:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH V3 2/2] libxl: fix matching of generic virtio device Content-Language: en-US To: Jan Beulich , Viresh Kumar , Anthony PERARD , Wei Liu Cc: Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?Q?Alex_Benn=c3=a9e?= , Mathieu Poirier , Oleksandr Tyshchenko , Erik Schilling , Oleksandr Tyshchenko , xen-devel@lists.xen.org, Juergen Gross References: <18458fa39433ce4ac950a0a20cc64da93db0b03a.1680771422.git.viresh.kumar@linaro.org> <888e60d2ec49f53230bc82df393b6bed4180cb8a.1680771422.git.viresh.kumar@linaro.org> <6d18f284-8cf9-4c21-7057-5f53bd98536e@suse.com> From: Julien Grall In-Reply-To: <6d18f284-8cf9-4c21-7057-5f53bd98536e@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 03/05/2023 12:42, Jan Beulich wrote: > On 06.04.2023 10:58, Viresh Kumar wrote: >> The strings won't be an exact match, as we are only looking to match the >> prefix here, i.e. "virtio,device". This is already done properly in >> libxl_virtio.c file, lets do the same here too. >> >> Fixes: 43ba5202e2ee ("libxl: add support for generic virtio device") >> Signed-off-by: Viresh Kumar >> Reviewed-by: Oleksandr Tyshchenko > > While I've committed the doc patch (patch 1), I don't think I should > commit this one without a maintainer ack, even if it looks pretty > straightforward. Anthony, Wei? AFAICT Anthony has already given his acked-by: https://lore.kernel.org/xen-devel/5e98d465-be8f-4050-a988-2a0829a71a2e@perard/#R Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 03 12:08:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 12:08:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529150.823227 (Exim 4.92) (envelope-from ) id 1puBHx-0000TR-0h; Wed, 03 May 2023 12:08:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529150.823227; Wed, 03 May 2023 12:08:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puBHw-0000TK-So; Wed, 03 May 2023 12:08:52 +0000 Received: by outflank-mailman (input) for mailman id 529150; Wed, 03 May 2023 12:08:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puBHv-0000TE-RR for xen-devel@lists.xenproject.org; Wed, 03 May 2023 12:08:51 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puBHv-0001Jm-9D; Wed, 03 May 2023 12:08:51 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[192.168.7.72]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1puBHv-0001UT-0w; Wed, 03 May 2023 12:08:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=V1Br1aM8ZSk05T7KMZpn1Acl9L+OCjkgD7wdGT3hsIw=; b=LVv9jlBQf916GX2/6r8Hlsibto dz5+3TaUU8OyqT8G1vjquxRj/6nqiwGomPPZFfEm/l+/wkMuzt88glKVUddduajdQhNPJh+cSckiR TnJAuh6p0QE/YN/SKbDMNQDasYUfRxddIuNcNk6LJgAjkRKqpvm6g/hjMuQgGuOq2djw=; Message-ID: Date: Wed, 3 May 2023 13:08:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [XEN v6 08/12] xen: dt: Replace u64 with uint64_t as the callback function parameters for dt_for_each_range() Content-Language: en-US To: Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, wl@xen.org, rahul.singh@arm.com References: <20230428175543.11902-1-ayan.kumar.halder@amd.com> <20230428175543.11902-9-ayan.kumar.halder@amd.com> From: Julien Grall In-Reply-To: <20230428175543.11902-9-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 28/04/2023 18:55, Ayan Kumar Halder wrote: > In the callback functions invoked by dt_for_each_range() ie handle_pci_range(), > map_range_to_domain(), 'u64' should be replaced with 'uint64_t' as the data type > for the parameters. Please explain why this needs to be replaced. I.e. Xen coding style mention that u32 should be avoided. > Also dt_for_each_range() invokes the callback functions with > 'uint64_t' arguments. > > There is another callback function ie is_bar_valid() which uses 'paddr_t' > instead of 'u64' or 'uint64_t'. We will change it in the subsequent commit. I would rather prefer if this is folded in this patch. > > Signed-off-by: Ayan Kumar Halder > --- > Changes from :- > > v1-v5 - New patch introduced in v6. > > xen/arch/arm/domain_build.c | 4 ++-- > xen/arch/arm/include/asm/setup.h | 2 +- > xen/common/device_tree.c | 4 ++-- > xen/include/xen/device_tree.h | 2 +- > 4 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 1c558fca0c..9865340eac 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -1637,7 +1637,7 @@ out: > } > > static int __init handle_pci_range(const struct dt_device_node *dev, > - u64 addr, u64 len, void *data) > + uint64_t addr, uint64_t len, void *data) > { > struct rangeset *mem_holes = data; > paddr_t start, end; > @@ -2331,7 +2331,7 @@ static int __init map_dt_irq_to_domain(const struct dt_device_node *dev, > } > > int __init map_range_to_domain(const struct dt_device_node *dev, > - u64 addr, u64 len, void *data) > + uint64_t addr, uint64_t len, void *data) > { > struct map_range_data *mr_data = data; > struct domain *d = mr_data->d; > diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h > index 47ce565d87..fe17cb0a4a 100644 > --- a/xen/arch/arm/include/asm/setup.h > +++ b/xen/arch/arm/include/asm/setup.h > @@ -166,7 +166,7 @@ u32 device_tree_get_u32(const void *fdt, int node, > const char *prop_name, u32 dflt); > > int map_range_to_domain(const struct dt_device_node *dev, > - u64 addr, u64 len, void *data); > + uint64_t addr, uint64_t len, void *data); > > extern DEFINE_BOOT_PAGE_TABLE(boot_pgtable); > > diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c > index 2163cf26d0..ab5f8df66c 100644 > --- a/xen/common/device_tree.c > +++ b/xen/common/device_tree.c > @@ -997,7 +997,7 @@ int dt_device_get_paddr(const struct dt_device_node *dev, unsigned int index, > > int dt_for_each_range(const struct dt_device_node *dev, > int (*cb)(const struct dt_device_node *, > - u64 addr, u64 length, > + uint64_t addr, uint64_t length, > void *), > void *data) > { > @@ -1060,7 +1060,7 @@ int dt_for_each_range(const struct dt_device_node *dev, > > for ( ; rlen >= rone; rlen -= rone, ranges += rone ) > { > - u64 a, s; > + uint64_t a, s; > int ret; > > memcpy(addr, ranges + na, 4 * pna); > diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h > index ce25b89c4b..b3888c1b96 100644 > --- a/xen/include/xen/device_tree.h > +++ b/xen/include/xen/device_tree.h > @@ -681,7 +681,7 @@ int dt_for_each_irq_map(const struct dt_device_node *dev, > */ > int dt_for_each_range(const struct dt_device_node *dev, > int (*cb)(const struct dt_device_node *, > - u64 addr, u64 length, > + uint64_t addr, uint64_t length, > void *), > void *data); > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 03 12:10:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 12:10:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529153.823237 (Exim 4.92) (envelope-from ) id 1puBJQ-0001pl-DB; Wed, 03 May 2023 12:10:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529153.823237; Wed, 03 May 2023 12:10:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puBJQ-0001pe-97; Wed, 03 May 2023 12:10:24 +0000 Received: by outflank-mailman (input) for mailman id 529153; Wed, 03 May 2023 12:10:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puBJO-0001pW-NZ for xen-devel@lists.xenproject.org; Wed, 03 May 2023 12:10:22 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puBJO-0001N1-CA; Wed, 03 May 2023 12:10:22 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.7.72]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1puBJO-0001X6-4p; Wed, 03 May 2023 12:10:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=f7n7K79rPqQ1unoFM74/iUlmR416DinXE/L8aH1BDmk=; b=wqsPYl/4KfSVkhHHQyLI1hqz5c W4NrsUCCwxnE488PD8tS9/DjMEGznZoGesCUYIuKUn1ve+JUaflgoFC40cNQvyA82PplzWIKsjU0/ NXpNjfmZi1o8EUWXVuzBjkkYsYouKF0t7cc7/Lo5i1PN7A6gcjMGZozSQXMDHeT+d7G4=; Message-ID: <9735d546-4869-2847-db5c-411c489faea1@xen.org> Date: Wed, 3 May 2023 13:10:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [XEN v6 10/12] xen/arm: domain_build: Check if the address fits the range of physical address Content-Language: en-US To: Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, wl@xen.org, rahul.singh@arm.com References: <20230428175543.11902-1-ayan.kumar.halder@amd.com> <20230428175543.11902-11-ayan.kumar.halder@amd.com> From: Julien Grall In-Reply-To: <20230428175543.11902-11-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 28/04/2023 18:55, Ayan Kumar Halder wrote: > handle_pci_range() and map_range_to_domain() take addr and len as uint64_t > parameters. Then frame numbers are obtained from addr and len by right shifting > with PAGE_SHIFT. The frame numbers are expressed using unsigned long. > > Now if 64-bit >> PAGE_SHIFT, the result will have 52-bits as valid. On a 32-bit > system, 'unsigned long' is 32-bits. Thus, there is a potential loss of value > when the result is stored as 'unsigned long'. > > To mitigate this issue, we check if the starting and end address can be > contained within the range of physical address supported on the system. If not, > then an appropriate error is returned. > > Signed-off-by: Ayan Kumar Halder Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 03 12:20:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 12:20:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529156.823246 (Exim 4.92) (envelope-from ) id 1puBSv-0003KL-9x; Wed, 03 May 2023 12:20:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529156.823246; Wed, 03 May 2023 12:20:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puBSv-0003KE-7B; Wed, 03 May 2023 12:20:13 +0000 Received: by outflank-mailman (input) for mailman id 529156; Wed, 03 May 2023 12:20:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puBSt-0003K5-SO for xen-devel@lists.xenproject.org; Wed, 03 May 2023 12:20:11 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puBSt-0001Xh-74; Wed, 03 May 2023 12:20:11 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.7.72]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1puBSs-0001tb-UY; Wed, 03 May 2023 12:20:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=hVAdin5xqML1rwquAjKeVU1U2+e0AMiPJc2yq1ixpdg=; b=V2L0gW2nYDxpx0czJP1uItXgGq MR9OaD3tJuHlqfLNg71EHjoMb1HiTK6MhtBAwTxpQNJtqVrQzITo7cathYaoFlPMtdW/plMClKCHO bFh/1jqxaPJNf1OyDPmks2FlCgG21g5kfXpaqelUQMDoJa7yMT6cXKv10zpr3PjoHaqU=; Message-ID: <63fa927e-72f5-1645-97c0-6986f2fdcabe@xen.org> Date: Wed, 3 May 2023 13:20:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [XEN v6 11/12] xen/arm: p2m: Use the pa_range_info table to support ARM_32 and ARM_64 Content-Language: en-US To: Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, wl@xen.org, rahul.singh@arm.com References: <20230428175543.11902-1-ayan.kumar.halder@amd.com> <20230428175543.11902-12-ayan.kumar.halder@amd.com> From: Julien Grall In-Reply-To: <20230428175543.11902-12-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 28/04/2023 18:55, Ayan Kumar Halder wrote: > Restructure the code so that one can use pa_range_info[] table for both > ARM_32 as well as ARM_64. > > Also, removed the hardcoding for P2M_ROOT_ORDER and P2M_ROOT_LEVEL as > p2m_root_order can be obtained from the pa_range_info[].root_order and > p2m_root_level can be obtained from pa_range_info[].sl0. > > Refer ARM DDI 0406C.d ID040418, B3-1345, > "Use of concatenated first-level translation tables > > ...However, a 40-bit input address range with a translation granularity of 4KB > requires a total of 28 bits of address resolution. Therefore, a stage 2 > translation that supports a 40-bit input address range requires two concatenated > first-level translation tables,..." > > Thus, root-order is 1 for 40-bit IPA on ARM_32. > > Refer ARM DDI 0406C.d ID040418, B3-1348, > > "Determining the required first lookup level for stage 2 translations > > For a stage 2 translation, the output address range from the stage 1 > translations determines the required input address range for the stage 2 > translation. The permitted values of VTCR.SL0 are: > > 0b00 Stage 2 translation lookup must start at the second level. > 0b01 Stage 2 translation lookup must start at the first level. > > VTCR.T0SZ must indicate the required input address range. The size of the input > address region is 2^(32-T0SZ) bytes." > > Thus VTCR.SL0 = 1 (maximum value) and VTCR.T0SZ = -8 when the size of input > address region is 2^40 bytes. > > Thus, pa_range_info[].t0sz = 1 (VTCR.S) | 8 (VTCR.T0SZ) ie 11000b which is 24. > > Signed-off-by: Ayan Kumar Halder > --- > Changes from - > > v3 - 1. New patch introduced in v4. > 2. Restructure the code such that pa_range_info[] is used both by ARM_32 as > well as ARM_64. > > v4 - 1. Removed the hardcoded definitions of P2M_ROOT_ORDER and P2M_ROOT_LEVEL. > The reason being root_order will not be always 1 (See the next patch). > 2. Updated the commit message to explain t0sz, sl0 and root_order values for > 32-bit IPA on Arm32. > 3. Some sanity fixes. > > v5 - pa_range_info is indexed by system_cpuinfo.mm64.pa_range. ie > when PARange is 0, the PA size is 32, 1 -> 36 and so on. So pa_range_info[] has > been updated accordingly. > For ARM_32 pa_range_info[0] = 0 and pa_range_info[1] = 0 as we do not support > 32-bit, 36-bit physical address range yet. > > xen/arch/arm/include/asm/p2m.h | 8 +------- > xen/arch/arm/p2m.c | 32 ++++++++++++++++++-------------- > 2 files changed, 19 insertions(+), 21 deletions(-) > > diff --git a/xen/arch/arm/include/asm/p2m.h b/xen/arch/arm/include/asm/p2m.h > index f67e9ddc72..4ddd4643d7 100644 > --- a/xen/arch/arm/include/asm/p2m.h > +++ b/xen/arch/arm/include/asm/p2m.h > @@ -14,16 +14,10 @@ > /* Holds the bit size of IPAs in p2m tables. */ > extern unsigned int p2m_ipa_bits; > > -#ifdef CONFIG_ARM_64 > extern unsigned int p2m_root_order; > extern unsigned int p2m_root_level; > -#define P2M_ROOT_ORDER p2m_root_order > +#define P2M_ROOT_ORDER p2m_root_order This looks like a spurious change. > #define P2M_ROOT_LEVEL p2m_root_level > -#else > -/* First level P2M is always 2 consecutive pages */ > -#define P2M_ROOT_ORDER 1 > -#define P2M_ROOT_LEVEL 1 > -#endif > > struct domain; > > diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c > index 418997843d..1fe3cccf46 100644 > --- a/xen/arch/arm/p2m.c > +++ b/xen/arch/arm/p2m.c > @@ -19,9 +19,9 @@ > > #define INVALID_VMID 0 /* VMID 0 is reserved */ > > -#ifdef CONFIG_ARM_64 > unsigned int __read_mostly p2m_root_order; > unsigned int __read_mostly p2m_root_level; > +#ifdef CONFIG_ARM_64 > static unsigned int __read_mostly max_vmid = MAX_VMID_8_BIT; > /* VMID is by default 8 bit width on AArch64 */ > #define MAX_VMID max_vmid > @@ -2247,16 +2247,6 @@ void __init setup_virt_paging(void) > /* Setup Stage 2 address translation */ > register_t val = VTCR_RES1|VTCR_SH0_IS|VTCR_ORGN0_WBWA|VTCR_IRGN0_WBWA; > > -#ifdef CONFIG_ARM_32 > - if ( p2m_ipa_bits < 40 ) > - panic("P2M: Not able to support %u-bit IPA at the moment\n", > - p2m_ipa_bits); > - > - printk("P2M: 40-bit IPA\n"); > - p2m_ipa_bits = 40; > - val |= VTCR_T0SZ(0x18); /* 40 bit IPA */ > - val |= VTCR_SL0(0x1); /* P2M starts at first level */ > -#else /* CONFIG_ARM_64 */ > static const struct { > unsigned int pabits; /* Physical Address Size */ > unsigned int t0sz; /* Desired T0SZ, minimum in comment */ > @@ -2265,19 +2255,26 @@ void __init setup_virt_paging(void) > } pa_range_info[] __initconst = { > /* T0SZ minimum and SL0 maximum from ARM DDI 0487H.a Table D5-6 */ > /* PA size, t0sz(min), root-order, sl0(max) */ > + [2] = { 40, 24/*24*/, 1, 1 }, I don't like the fact that the index are not ordered anymore and... > +#ifdef CONFIG_ARM_64 > [0] = { 32, 32/*32*/, 0, 1 }, > [1] = { 36, 28/*28*/, 0, 1 }, > - [2] = { 40, 24/*24*/, 1, 1 }, > [3] = { 42, 22/*22*/, 3, 1 }, > [4] = { 44, 20/*20*/, 0, 2 }, > [5] = { 48, 16/*16*/, 0, 2 }, > [6] = { 52, 12/*12*/, 4, 2 }, > [7] = { 0 } /* Invalid */ > +#else > + [0] = { 0 }, /* Invalid */ > + [1] = { 0 }, /* Invalid */ > + [3] = { 0 } /* Invalid */ > +#endif ... it is not clear to me why we are adding 3 extra entries. I think it would be better if we do: #ifdef CONFIG_ARM_64 [0] ... [1] ... #endif [2] ... #ifdef CONFIG_ARM_64 [3] ... [4] ... ... #endif > }; > > unsigned int i; > unsigned int pa_range = 0x10; /* Larger than any possible value */ > > +#ifdef CONFIG_ARM_64 > /* > * Restrict "p2m_ipa_bits" if needed. As P2M table is always configured > * with IPA bits == PA bits, compare against "pabits". > @@ -2291,6 +2288,9 @@ void __init setup_virt_paging(void) > */ > if ( system_cpuinfo.mm64.vmid_bits == MM64_VMID_16_BITS_SUPPORT ) > max_vmid = MAX_VMID_16_BIT; > +#else > + p2m_ipa_bits = PADDR_BITS; > +#endif Why do we need to reset p2m_ipa_bits for Arm? > > /* Choose suitable "pa_range" according to the resulted "p2m_ipa_bits". */ > for ( i = 0; i < ARRAY_SIZE(pa_range_info); i++ ) > @@ -2306,24 +2306,28 @@ void __init setup_virt_paging(void) > if ( pa_range >= ARRAY_SIZE(pa_range_info) || !pa_range_info[pa_range].pabits ) > panic("Unknown encoding of ID_AA64MMFR0_EL1.PARange %x\n", pa_range); > > +#ifdef CONFIG_ARM_64 > val |= VTCR_PS(pa_range); > val |= VTCR_TG0_4K; > > /* Set the VS bit only if 16 bit VMID is supported. */ > if ( MAX_VMID == MAX_VMID_16_BIT ) > val |= VTCR_VS; > + > + p2m_ipa_bits = 64 - pa_range_info[pa_range].t0sz; > +#endif > + > val |= VTCR_SL0(pa_range_info[pa_range].sl0); > val |= VTCR_T0SZ(pa_range_info[pa_range].t0sz); > > p2m_root_order = pa_range_info[pa_range].root_order; > p2m_root_level = 2 - pa_range_info[pa_range].sl0; > - p2m_ipa_bits = 64 - pa_range_info[pa_range].t0sz; I think this line should stay for 32-bit as well because we p2m_ipa_bits should be based on the PA range we selected (see the loop 'Choose suitable "pa_range"...'). > > printk("P2M: %d-bit IPA with %d-bit PA and %d-bit VMID\n", > p2m_ipa_bits, > pa_range_info[pa_range].pabits, > ( MAX_VMID == MAX_VMID_16_BIT ) ? 16 : 8); > -#endif > + > printk("P2M: %d levels with order-%d root, VTCR 0x%"PRIregister"\n", > 4 - P2M_ROOT_LEVEL, P2M_ROOT_ORDER, val); > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 03 12:28:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 12:28:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529165.823257 (Exim 4.92) (envelope-from ) id 1puBaO-00042n-79; Wed, 03 May 2023 12:27:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529165.823257; Wed, 03 May 2023 12:27:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puBaO-00042g-47; Wed, 03 May 2023 12:27:56 +0000 Received: by outflank-mailman (input) for mailman id 529165; Wed, 03 May 2023 12:27:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puBaM-00042a-KX for xen-devel@lists.xen.org; Wed, 03 May 2023 12:27:54 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on20625.outbound.protection.outlook.com [2a01:111:f400:fe13::625]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ebebd58c-e9ad-11ed-8611-37d641c3527e; Wed, 03 May 2023 14:27:51 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AM8PR04MB7332.eurprd04.prod.outlook.com (2603:10a6:20b:1db::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.21; Wed, 3 May 2023 12:27:51 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 12:27:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ebebd58c-e9ad-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qw98ewXzUnygrXuCZH3fKbYbAOyfhIiRAnG382VjQ9OleHtRNZTm8EAyvwa77hlhiZE2HbSpWx4FBXpjVfsI44kGK9eUny1lf8g1ErYFd1eOfAPfo6c67Z4vdU/L4I3hJINQKwBhQnZsCrqn2v+SKAbVX1QQMbHV+DLDwKjHN6WwWKdFkjB5RvLg5vOax76LmXuXLUAz0y5YOVkob/IteEselgtyEZSYQBOank8tpUYNu6tutXLqUvWP/4++9woknm5Bfbs9qLRRsfvZtRMm7cd70AAXAdaFWNkRe8E7VCPzU52uRm0Gi7OIzWikfWIHFcx4UCZfJ/QCnJwuf0KlPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v9M5VZYtq+Ran5nYj9i4Y8tieuCE7epdLKj66oHAKeY=; b=T7pBL6CYiog40yzAKvYGpCwuEF1XzzfdiX05zzz7VFoIYaZBZ4OPVUxMOUggCNgFI5CDeyFrQYFcdNVMgAcLzkn5xY3F77b6Ka6ydFJUDkpRDyGrr/KmTn9OSty4o/A6snhzdcEQUvg48N7sll4fFtpbWr70Mz1sZ+aCOB/mFG7Mkqa8CpR733uas6kI0kiKCvHk9AHWoJew0iTFrwATyh1rCrmNrLyMONeLJNkmUULLjNZ2VcqmeehzJjepVUAtPU0kNgRH4lfMpqv/WCpQ3irGLSYsTtfxtBG0MhiUM7PFctkn/3R3LkWooiPj02a9Wj4fyaKHnE1/pnMXloNE9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v9M5VZYtq+Ran5nYj9i4Y8tieuCE7epdLKj66oHAKeY=; b=Le1kwJhj7WPYIxOnoloTHR9k3PcyiPe0UOh314Kmst1ZmG+JelG+nye1hnFDxLYRVmvNL1bxpIhpaEp0kRvZiC3t7wG/pLhDUbSzsjefGrAMTugX4rsW5NN/RRc4gVvoiC+aSKM0PNJ34eK8l5Z8J3ceCnUopwcJoiKD7EWUsdK/oCZxVENWPN6YKVXGUBwK6pcPNocjm+9A4HGAyhGoKR9j3OtbZwZQcbwrNONyRFS3vISm/kQ62dL38OMGw24dkqWIqVUxRYnm6bFdxFkBFPGSXwFLuBP3LwwBSUOiDdJst06rwmUB7Xg6gZUmPXJROcToakQ1Qa4eNQyigfas9A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7cd38c79-2876-87a5-ed2a-8a49a432d79d@suse.com> Date: Wed, 3 May 2023 14:27:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH V3 2/2] libxl: fix matching of generic virtio device Content-Language: en-US To: Julien Grall , Anthony PERARD Cc: Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?Q?Alex_Benn=c3=a9e?= , Mathieu Poirier , Oleksandr Tyshchenko , Erik Schilling , Oleksandr Tyshchenko , xen-devel@lists.xen.org, Juergen Gross , Wei Liu , Viresh Kumar References: <18458fa39433ce4ac950a0a20cc64da93db0b03a.1680771422.git.viresh.kumar@linaro.org> <888e60d2ec49f53230bc82df393b6bed4180cb8a.1680771422.git.viresh.kumar@linaro.org> <6d18f284-8cf9-4c21-7057-5f53bd98536e@suse.com> <1e34ae06-c5b1-586a-c840-1dcb768c70e9@xen.org> From: Jan Beulich In-Reply-To: <1e34ae06-c5b1-586a-c840-1dcb768c70e9@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0049.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:92::9) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|AM8PR04MB7332:EE_ X-MS-Office365-Filtering-Correlation-Id: 55303217-77ca-4134-25e4-08db4bd1cfc7 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C7vKvupxex64WdRGeTWpDWPNpvjqQG7cZTGvlI2jj2lgLnJhfTfVbOyH8ZXTHl3VLqmvhu9xd72WNXyh15sbKpVcY+z994FB3ARliho629K/8dE94V/MXizYGvpaj1fFMjuH4TYo9zlHQlSaKJVuqlyHdYxwK0GzkNmrcXWFD80MpJvbYDnBwX5yAirFHDRTqdB7HpC+EEIXbLfijcTyGgTW45sp4XYzMlSuh72/Qikpgc29j5ztIAnqdOimtAsudg5tRggB44vLuKTLTC3S0eLzSMzfq8kvDQRCfn9z7Y6lMK4Sz1SOriBX91A1ujOcghTANeZ3YErDiMAbXIn8mqcdWQI+0Ra7eLNGn2wenIZf8T0wP5JoASJrE/OA/KvqElHW+CXALvp758OwlqMURYfhc/LE9caK5nJsRSpmf07dobEJBLidNbx0WhwqmEtnw/Vq0vXr/Mlh2b9aILPAY6EW87fVf+hIWLn3BSI2ZHjSnHwUIoSbFk8S9/oRZnSdwi0yTweZ/nXyI4sMLadQ7w4p5dmYWiCcogIFPH2v6oKMwz5yjo3JY/nlmaJ6aAID5YxtDXwqu0QlSZJi1R+58ZfRr8yOYmOX46bv4nsYykxeBwVK5QewvioT+niOYsjV8p3kRsJv0cM8cMmwomSfRyX65zSi1Rf6CDEUsNoCMPg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(346002)(136003)(39860400002)(376002)(396003)(451199021)(966005)(6506007)(6486002)(478600001)(110136005)(2616005)(6512007)(53546011)(26005)(54906003)(186003)(38100700002)(2906002)(4744005)(7416002)(36756003)(5660300002)(66556008)(66476007)(66946007)(4326008)(41300700001)(8936002)(8676002)(31696002)(316002)(86362001)(31686004)(41533002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YzhnT1hwNmN1Ynp6SVlYS3hselN5dHEwMWRPcmlVbFJXRk5ackx2cFFaaGIx?= =?utf-8?B?UzNMY28rVllrRjMvV3QvNC90aVRkTzdsUG43Um1zYmZLZEcxUGg5S2MvZzZ3?= =?utf-8?B?NUUwQjhNRzNxbndPYk9EdnE0OUhSOFRLLzdId2FrRE1naUNMaW0wdVJSdDBY?= =?utf-8?B?WUx1U3NFWTVSWis4c0pjaFVDSGVBQmRsMUJVaEtyY3JIS1ZLdHZDK2R2Slly?= =?utf-8?B?czZiUW04T1dDRFNxZVdpZzUzRGNTaThXaVFGWXFvS3kxQU5TZ3J6Ym9pVitq?= =?utf-8?B?STF4VnUvUHU3WlRJOW5BNzBCNkw5WUhHVkRhbG5uRTNCK2Jpc0FtR2RoQ0dP?= =?utf-8?B?emp5RnM5b3dmQVA5SDdrMHdiOFhTV3dSVWlxcUk1WXRhMjNVMll0UCtKWC9L?= =?utf-8?B?L2g4ZWlqUk9qL3dVYTBGUElmcGFrZTFYcGE2YlpVMU5YTzJBOVVlVTRLTUV6?= =?utf-8?B?cUFuZ3lOOFhwemFURkpEODdsVU56MzRScTZqdHJPVTIwMnB5bWsyYWtYMG9J?= =?utf-8?B?VUFqOWVtSHNCY2t5L2I1am4zUE01L2R0ei9WZjNUNEFkZG9OR3NFTnFWWEhv?= =?utf-8?B?dDR0b01vRFVkZ2FzVHNRZi81dWUyVjI5aXMrS3VSZTdBd1UvdTlsbGRzT3h4?= =?utf-8?B?eE9BUTF1eUNQUDhMQURQMURZQXlML28xQWt3UjgxbXdLait0NTlTbUVyVENl?= =?utf-8?B?aE44ejdUM0Q0WFlacjlaRmVlMFJCNFowaHIvOWpUbE96OVNtYzhLNEVnMVNS?= =?utf-8?B?UVhZYjBJelVDQ2V3R1V6dURmQVFROXRaY3NSZ2lKR1h2bTYvRW5laXlDemRV?= =?utf-8?B?czR5b2swLzdHbmNLYmtObUJ3eEIrNHJtZmJHRnZTUWRzWUZnUFFYS2FmZ0JB?= =?utf-8?B?MUlvcks5YW1JeHF1TmRXZ0M1b3BOYWt6VlZIWnJNQVpQNi81cEI1Y1o5eDZy?= =?utf-8?B?MDVkKzdYZG54SDBwaHZDSEdpcHh1QzBUQThVdjBVM1ZST2xXV0xKaFJwNFVw?= =?utf-8?B?TkxsY0g5VjRicHhlckVtd2x4eFF3ampMQWR2Q0o3SkJXV1RONGEvbFRWcWVo?= =?utf-8?B?anNHSDc4NnpvNXZCTDg2L25EWnpvOEZwT2FLRUt0ZkRTaWNYcXZmQ3c3cVND?= =?utf-8?B?cXJ6dUNwMnh3N1dWN1lnZEJRMW9BTFd3TmFpeDlWOHRySnhWWXNpbFZiSUl1?= =?utf-8?B?SjBVYUdINFVnS09GRkhmNGd0d244MFQybG1zTXlrZG96cDNFOVRVVUV3bzho?= =?utf-8?B?eGxBMzBOOHJPL0NYaVF4WkhneS9xdjBvYXcxQVFjeGVkdVpzZ1hpc0RLRHdB?= =?utf-8?B?ekdHZTRBcnhJMk1UL1E1bEQzaDk5eGhXMEpVL3FhclkwR0pPc0ZCeGt0TnFQ?= =?utf-8?B?cFYrd3A1RTgyajV6LzU2WGNUanhmaC80TUg0TlVuenZkd0FpN1dJVXlCTmRP?= =?utf-8?B?dWNORU1UK25LbFdnZ0pEeHQ4RTIwUE1qbUlqUXVTd3dKcTZxRFZkblJ4b3lu?= =?utf-8?B?Szlka2ZDakQ3dVprclIwNTJQUDFFeGppT0xKVm5Bc1F3c2lUY1BtZmc4MjdT?= =?utf-8?B?T244endpNTVBcUNSUVNCdVhnbk15c0JTTXJWSkFYREpXQ2J2U3MwSGIrblpX?= =?utf-8?B?UkhVd2lNNWNqVFpCbjViMjNoYWxPdzlZbm9jQXF5ZS9wMHNJRllETUw4Yy9h?= =?utf-8?B?SWxSTmcxS0o1VXlhOUY5OXlQa1B1azVjdVZSQVRPak16bnNLOExLWTdGcm9O?= =?utf-8?B?U0RHK0ZkTFgwTGNFT2F5OFlQVThRTlhRWHVqVFVLUmYxMHYvdlk2R2JDVkl2?= =?utf-8?B?N1RyR0JabjE0bHhaOW5nMTRVNkZMTWs5MXR1UzBuK0FSVXdTOXVuK0llK3dW?= =?utf-8?B?aEY5L3I1QmFuazJNQXYwNUdLTkZFUU1ia2lmYjh1Z21uWDhQNmF6WWhzNTRa?= =?utf-8?B?MDV6MmdhNDliUHhxRTRDdnRaVFFnTzFLNmhHRktuSUxWSDhuUWFxblZlanlZ?= =?utf-8?B?bWhXZ1FnYis0OUxvbGJibDQxTEE0UjRFNzZTcC9EVGUwNTlubjk0TGxhZU5l?= =?utf-8?B?elNleDQvK25aZGZWNTZ6MVZkZVV2bllJekIwWTZTVldwUytzaWF0VWMzbi9P?= =?utf-8?Q?HJfzdfY7340gKyRkVdsqpZ9Ms?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 55303217-77ca-4134-25e4-08db4bd1cfc7 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 12:27:51.1052 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jw+CWna+tnLJJiG4Z3q7uM1F61Cb0SU0Sm5TErcWLYM9ZsnCEwgEC9o6bnYpmbP1HbLyO7Yhq1bACT6ew+kpfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7332 On 03.05.2023 14:04, Julien Grall wrote: > On 03/05/2023 12:42, Jan Beulich wrote: >> On 06.04.2023 10:58, Viresh Kumar wrote: >>> The strings won't be an exact match, as we are only looking to match the >>> prefix here, i.e. "virtio,device". This is already done properly in >>> libxl_virtio.c file, lets do the same here too. >>> >>> Fixes: 43ba5202e2ee ("libxl: add support for generic virtio device") >>> Signed-off-by: Viresh Kumar >>> Reviewed-by: Oleksandr Tyshchenko >> >> While I've committed the doc patch (patch 1), I don't think I should >> commit this one without a maintainer ack, even if it looks pretty >> straightforward. Anthony, Wei? > > AFAICT Anthony has already given his acked-by: > > https://lore.kernel.org/xen-devel/5e98d465-be8f-4050-a988-2a0829a71a2e@perard/#R Oh, right you are. Thanks for pointing this out. And, Anthony: I'm sorry. Jan From xen-devel-bounces@lists.xenproject.org Wed May 03 12:36:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 12:36:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529169.823266 (Exim 4.92) (envelope-from ) id 1puBi6-0005Wi-Vz; Wed, 03 May 2023 12:35:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529169.823266; Wed, 03 May 2023 12:35:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puBi6-0005Wb-TM; Wed, 03 May 2023 12:35:54 +0000 Received: by outflank-mailman (input) for mailman id 529169; Wed, 03 May 2023 12:35:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puBi5-0005WV-Cs for xen-devel@lists.xenproject.org; Wed, 03 May 2023 12:35:53 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puBi4-0001y0-Qe; Wed, 03 May 2023 12:35:52 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[192.168.7.72]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1puBi4-0002Xj-JJ; Wed, 03 May 2023 12:35:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: References:Cc:To:From:Subject:MIME-Version:Date:Message-ID; bh=lpezSXCZbHYzG/uYZGtKRGiZ9sjYSZy6hUjCZRVKOas=; b=k5X+wG9s2ZrxRK6QiNaBjNnZqR 0e4K0w8pXtIUTlrQDj2eUvb2hdrmrZSqaRBVP7Yih60vkuImU4dv7VxsUb6gYIyZcXHek4WeZ5TmM KhbuLtTPCB97mf93HXg2m/qOc06vToxZ1fTA/9x+Zh+FVJOYWrGBOKbK20Nnf3nUHySQ=; Message-ID: <178f9c0f-2f72-daac-772b-c3c4221bea40@xen.org> Date: Wed, 3 May 2023 13:35:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [XEN v6 11/12] xen/arm: p2m: Use the pa_range_info table to support ARM_32 and ARM_64 Content-Language: en-US From: Julien Grall To: Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, wl@xen.org, rahul.singh@arm.com References: <20230428175543.11902-1-ayan.kumar.halder@amd.com> <20230428175543.11902-12-ayan.kumar.halder@amd.com> <63fa927e-72f5-1645-97c0-6986f2fdcabe@xen.org> In-Reply-To: <63fa927e-72f5-1645-97c0-6986f2fdcabe@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 03/05/2023 13:20, Julien Grall wrote: > Hi, > > On 28/04/2023 18:55, Ayan Kumar Halder wrote: >> Restructure the code so that one can use pa_range_info[] table for both >> ARM_32 as well as ARM_64. >> >> Also, removed the hardcoding for P2M_ROOT_ORDER and P2M_ROOT_LEVEL as >> p2m_root_order can be obtained from the pa_range_info[].root_order and >> p2m_root_level can be obtained from pa_range_info[].sl0. >> >> Refer ARM DDI 0406C.d ID040418, B3-1345, >> "Use of concatenated first-level translation tables >> >> ...However, a 40-bit input address range with a translation >> granularity of 4KB >> requires a total of 28 bits of address resolution. Therefore, a stage 2 >> translation that supports a 40-bit input address range requires two >> concatenated >> first-level translation tables,..." >> >> Thus, root-order is 1 for 40-bit IPA on ARM_32. >> >> Refer ARM DDI 0406C.d ID040418, B3-1348, >> >> "Determining the required first lookup level for stage 2 translations >> >> For a stage 2 translation, the output address range from the stage 1 >> translations determines the required input address range for the stage 2 >> translation. The permitted values of VTCR.SL0 are: >> >> 0b00 Stage 2 translation lookup must start at the second level. >> 0b01 Stage 2 translation lookup must start at the first level. >> >> VTCR.T0SZ must indicate the required input address range. The size of >> the input >> address region is 2^(32-T0SZ) bytes." >> >> Thus VTCR.SL0 = 1 (maximum value) and VTCR.T0SZ = -8 when the size of >> input >> address region is 2^40 bytes. >> >> Thus, pa_range_info[].t0sz = 1 (VTCR.S) | 8 (VTCR.T0SZ) ie 11000b >> which is 24. >> >> Signed-off-by: Ayan Kumar Halder >> --- >> Changes from - >> >> v3 - 1. New patch introduced in v4. >> 2. Restructure the code such that pa_range_info[] is used both by >> ARM_32 as >> well as ARM_64. >> >> v4 - 1. Removed the hardcoded definitions of P2M_ROOT_ORDER and >> P2M_ROOT_LEVEL. >> The reason being root_order will not be always 1 (See the next patch). >> 2. Updated the commit message to explain t0sz, sl0 and root_order >> values for >> 32-bit IPA on Arm32. >> 3. Some sanity fixes. >> >> v5 - pa_range_info is indexed by system_cpuinfo.mm64.pa_range. ie >> when PARange is 0, the PA size is 32, 1 -> 36 and so on. So >> pa_range_info[] has >> been updated accordingly. >> For ARM_32 pa_range_info[0] = 0 and pa_range_info[1] = 0 as we do not >> support >> 32-bit, 36-bit physical address range yet. >> >>   xen/arch/arm/include/asm/p2m.h |  8 +------- >>   xen/arch/arm/p2m.c             | 32 ++++++++++++++++++-------------- >>   2 files changed, 19 insertions(+), 21 deletions(-) >> >> diff --git a/xen/arch/arm/include/asm/p2m.h >> b/xen/arch/arm/include/asm/p2m.h >> index f67e9ddc72..4ddd4643d7 100644 >> --- a/xen/arch/arm/include/asm/p2m.h >> +++ b/xen/arch/arm/include/asm/p2m.h >> @@ -14,16 +14,10 @@ >>   /* Holds the bit size of IPAs in p2m tables.  */ >>   extern unsigned int p2m_ipa_bits; >> -#ifdef CONFIG_ARM_64 >>   extern unsigned int p2m_root_order; >>   extern unsigned int p2m_root_level; >> -#define P2M_ROOT_ORDER    p2m_root_order >> +#define P2M_ROOT_ORDER p2m_root_order > > This looks like a spurious change. > >>   #define P2M_ROOT_LEVEL p2m_root_level >> -#else >> -/* First level P2M is always 2 consecutive pages */ >> -#define P2M_ROOT_ORDER    1 >> -#define P2M_ROOT_LEVEL 1 >> -#endif >>   struct domain; >> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c >> index 418997843d..1fe3cccf46 100644 >> --- a/xen/arch/arm/p2m.c >> +++ b/xen/arch/arm/p2m.c >> @@ -19,9 +19,9 @@ >>   #define INVALID_VMID 0 /* VMID 0 is reserved */ >> -#ifdef CONFIG_ARM_64 >>   unsigned int __read_mostly p2m_root_order; >>   unsigned int __read_mostly p2m_root_level; >> +#ifdef CONFIG_ARM_64 >>   static unsigned int __read_mostly max_vmid = MAX_VMID_8_BIT; >>   /* VMID is by default 8 bit width on AArch64 */ >>   #define MAX_VMID       max_vmid >> @@ -2247,16 +2247,6 @@ void __init setup_virt_paging(void) >>       /* Setup Stage 2 address translation */ >>       register_t val = >> VTCR_RES1|VTCR_SH0_IS|VTCR_ORGN0_WBWA|VTCR_IRGN0_WBWA; >> -#ifdef CONFIG_ARM_32 >> -    if ( p2m_ipa_bits < 40 ) >> -        panic("P2M: Not able to support %u-bit IPA at the moment\n", >> -              p2m_ipa_bits); >> - >> -    printk("P2M: 40-bit IPA\n"); >> -    p2m_ipa_bits = 40; >> -    val |= VTCR_T0SZ(0x18); /* 40 bit IPA */ >> -    val |= VTCR_SL0(0x1); /* P2M starts at first level */ >> -#else /* CONFIG_ARM_64 */ >>       static const struct { >>           unsigned int pabits; /* Physical Address Size */ >>           unsigned int t0sz;   /* Desired T0SZ, minimum in comment */ >> @@ -2265,19 +2255,26 @@ void __init setup_virt_paging(void) >>       } pa_range_info[] __initconst = { >>           /* T0SZ minimum and SL0 maximum from ARM DDI 0487H.a Table >> D5-6 */ >>           /*      PA size, t0sz(min), root-order, sl0(max) */ >> +        [2] = { 40,      24/*24*/,  1,          1 }, > > I don't like the fact that the index are not ordered anymore and... > >> +#ifdef CONFIG_ARM_64 >>           [0] = { 32,      32/*32*/,  0,          1 }, >>           [1] = { 36,      28/*28*/,  0,          1 }, >> -        [2] = { 40,      24/*24*/,  1,          1 }, >>           [3] = { 42,      22/*22*/,  3,          1 }, >>           [4] = { 44,      20/*20*/,  0,          2 }, >>           [5] = { 48,      16/*16*/,  0,          2 }, >>           [6] = { 52,      12/*12*/,  4,          2 }, >>           [7] = { 0 }  /* Invalid */ >> +#else >> +        [0] = { 0 },  /* Invalid */ >> +        [1] = { 0 },  /* Invalid */ >> +        [3] = { 0 }  /* Invalid */ >> +#endif > > ... it is not clear to me why we are adding 3 extra entries. I think it > would be better if we do: > > #ifdef CONFIG_ARM_64 >    [0] ... >    [1] ... > #endif >    [2] ... > #ifdef CONFIG_ARM_64 >    [3] ... >    [4] ... >    ... > #endif Looking at the next patch. An alternative would be to go back duplicating the lines. So after the two patches we would have #ifdef CONFIG_ARM_64 [0] ... [7] ... #else { /* 32-bit */ } { /* 40-bit */ } #endif I didn't add '[X] = ' because the index is not necessary for 32-bit. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 03 12:46:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 12:46:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529177.823277 (Exim 4.92) (envelope-from ) id 1puBsK-000722-VK; Wed, 03 May 2023 12:46:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529177.823277; Wed, 03 May 2023 12:46:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puBsK-00071v-S6; Wed, 03 May 2023 12:46:28 +0000 Received: by outflank-mailman (input) for mailman id 529177; Wed, 03 May 2023 12:46:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puBsJ-00071Y-NZ for xen-devel@lists.xenproject.org; Wed, 03 May 2023 12:46:27 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puBsI-0002Ba-Dq; Wed, 03 May 2023 12:46:26 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.7.72]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1puBsI-00032K-6X; Wed, 03 May 2023 12:46:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=E9fnji8EWnL4Q3KzOAL+r0yyQHK5Ln8yKDSohAdh+lY=; b=MfeyMzW5NmhzccmnDms08bftKd /+bAE7iZwagUAKRdP3Js3vnNU1nf8AQeMwmCvzdpB/i2fK4EhrWPK1z03zv7AABml39NNUO14quQ1 zwd2L3Elq2guyzFZjZ9DX+4Ckk0Ll0YP+2qjhPrvKbOIkObhXxRFarPRXvWJCYanCs1I=; Message-ID: <0654529d-fe53-f3b4-a1f2-bf3515af8e93@xen.org> Date: Wed, 3 May 2023 13:46:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 01/13] tools/xenstore: verify command line parameters better Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230330085011.9170-1-jgross@suse.com> <20230330085011.9170-2-jgross@suse.com> From: Julien Grall In-Reply-To: <20230330085011.9170-2-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 30/03/2023 09:49, Juergen Gross wrote: > Add some more verification of command line parameters. > > Signed-off-by: Juergen Gross > --- > tools/xenstore/xenstored_core.c | 19 +++++++++---------- > 1 file changed, 9 insertions(+), 10 deletions(-) > > diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c > index 6e2fc06840..7214b3df03 100644 > --- a/tools/xenstore/xenstored_core.c > +++ b/tools/xenstore/xenstored_core.c > @@ -2809,7 +2809,7 @@ int main(int argc, char *argv[]) > no_domain_init = true; > break; > case 'E': > - hard_quotas[ACC_NODES].val = strtoul(optarg, NULL, 10); > + hard_quotas[ACC_NODES].val = get_optval_int(optarg); Ah, so that exactly what I was exactly on the other series. I would be OK if this is kept separate: Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 03 12:56:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 12:56:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529185.823287 (Exim 4.92) (envelope-from ) id 1puC1a-000050-QI; Wed, 03 May 2023 12:56:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529185.823287; Wed, 03 May 2023 12:56:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puC1a-00004r-NP; Wed, 03 May 2023 12:56:02 +0000 Received: by outflank-mailman (input) for mailman id 529185; Wed, 03 May 2023 12:56:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puC1Z-0008WR-UJ for xen-devel@lists.xenproject.org; Wed, 03 May 2023 12:56:01 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puC1Y-0002NG-OU; Wed, 03 May 2023 12:56:00 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[192.168.7.72]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1puC1Y-0003Mq-H3; Wed, 03 May 2023 12:56:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=cYThjRTWIYId03gPcjqSu6mJI5Pz9knWhki2c3eBCtU=; b=wWalS9+sdX1DLpgcrnF/f0iA98 G+9MGwv3GLwBSAVb/bBofMDglFJmUGCnJT/u57Fo4hTy9UrjUXKTBvNupyGcIypG6N1sWOTZXdWzj aVasbntlDK14kJTwR9nnA+oPDob8AP0x8GHbudXRTeTpQ7MJWtAcQ6KHfFj9ROzFi7Qc=; Message-ID: <8d91f57b-41ed-2939-94e8-9f73f0d523a6@xen.org> Date: Wed, 3 May 2023 13:55:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 02/13] tools/xenstore: do some cleanup of hashtable.c Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230330085011.9170-1-jgross@suse.com> <20230330085011.9170-3-jgross@suse.com> From: Julien Grall In-Reply-To: <20230330085011.9170-3-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 30/03/2023 09:50, Juergen Gross wrote: > Do the following cleanups: > - hashtable_count() isn't used at all, so remove it > - replace prime_table_length and max_load_factor with macros > - make hash() static > - add a loadlimit() helper function > - remove the /***/ lines between functions > - do some style corrections > > Signed-off-by: Juergen Gross > --- > tools/xenstore/hashtable.c | 71 ++++++++++++++------------------------ > tools/xenstore/hashtable.h | 10 ------ > 2 files changed, 26 insertions(+), 55 deletions(-) > > diff --git a/tools/xenstore/hashtable.c b/tools/xenstore/hashtable.c > index 3d4466b597..c1b11743bb 100644 > --- a/tools/xenstore/hashtable.c > +++ b/tools/xenstore/hashtable.c > @@ -40,22 +40,25 @@ static const unsigned int primes[] = { > 50331653, 100663319, 201326611, 402653189, > 805306457, 1610612741 > }; > -const unsigned int prime_table_length = sizeof(primes)/sizeof(primes[0]); > -const unsigned int max_load_factor = 65; /* percentage */ > > -/*****************************************************************************/ > -/* indexFor */ > -static inline unsigned int > -indexFor(unsigned int tablelength, unsigned int hashvalue) { > +#define PRIME_TABLE_LEN ARRAY_SIZE(primes) > +#define MAX_LOAD_PERCENT 65 > + > +static inline unsigned int indexFor(unsigned int tablelength, > + unsigned int hashvalue) > +{ > return (hashvalue % tablelength); > } > > -/*****************************************************************************/ > -struct hashtable * > -create_hashtable(const void *ctx, unsigned int minsize, > - unsigned int (*hashf) (const void *), > - int (*eqf) (const void *, const void *), > - unsigned int flags) > +static unsigned int loadlimit(unsigned int pindex) > +{ > + return ((uint64_t)primes[pindex] * MAX_LOAD_PERCENT) / 100; > +} > + > +struct hashtable *create_hashtable(const void *ctx, unsigned int minsize, > + unsigned int (*hashf) (const void *), > + int (*eqf) (const void *, const void *), > + unsigned int flags) > { > struct hashtable *h; > unsigned int pindex, size = primes[0]; > @@ -64,7 +67,7 @@ create_hashtable(const void *ctx, unsigned int minsize, > if (minsize > (1u << 30)) return NULL; > > /* Enforce size as prime */ > - for (pindex=0; pindex < prime_table_length; pindex++) { > + for (pindex=0; pindex < PRIME_TABLE_LEN; pindex++) { As you fix the style, how about adding a space before/after '=' and... > if (primes[pindex] > minsize) { size = primes[pindex]; break; } ... break this line in multiple ones? With or without this included here: Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 03 12:59:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 12:59:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529190.823297 (Exim 4.92) (envelope-from ) id 1puC4q-0000fB-8g; Wed, 03 May 2023 12:59:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529190.823297; Wed, 03 May 2023 12:59:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puC4q-0000f4-5n; Wed, 03 May 2023 12:59:24 +0000 Received: by outflank-mailman (input) for mailman id 529190; Wed, 03 May 2023 12:59:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puC4o-0000er-RD for xen-devel@lists.xenproject.org; Wed, 03 May 2023 12:59:22 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20620.outbound.protection.outlook.com [2a01:111:f400:7d00::620]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 523fdbba-e9b2-11ed-b225-6b7b168915f2; Wed, 03 May 2023 14:59:21 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DU0PR04MB9588.eurprd04.prod.outlook.com (2603:10a6:10:31d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.21; Wed, 3 May 2023 12:59:20 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 12:59:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 523fdbba-e9b2-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T7+7htrPsnZscAy77VQ0DrJY/CD8rQ4wZmA0MdDLqXalaiuJW3skRaZlbwLn+vFOXFx8+mY649YFJ4I8Fk12MK37SQu+DvNDh+Pkzdy1Ihv7VepmTE41poUSmYz8tfMyK2C5ZSNBiqXcsbYgwKy3Eajwygzl8BTxVpVxSj4IjqcpevCkCFq+X14PxEcVd9O4vQIOPXDb+3k5iz7e0G1/IAnhF1eKsM3LIgk4GNQeQLfplJg4ZfU2r4RzBjjSccgdrZQfReQUFanI7ErbVa91sKdQRTdOZm8OirHITUjxyUD5+UVcEL09EsmDaoT5boucGscQGmHhm3fXZKz21u0VPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vTIfjDGnj3/WeqbrCcUfjD6T8DjZ2Pu0a9/w7OnCY6E=; b=RmgKJ0brgpFDbK67k7XoUoY26A7/mFZAwcz7fCoL7gtgbjlhH5hjAAmLsR4zg/IyItyVK/103JFxDylqaFHQ4YSM2UmMZ4pA/ZUgRw2Hf5mCgpPrCsI0iBxTw8kCnzb5uuKsUPnVnSIj8FIcV/bcUYTb9FWT3TC6vCVeXHSu9SdyMN7ssiChWAsprIeMQvLllGdnTbnxvH+o5k/E0YWdnSj9cBAoehQBPoAKmly/9TAvYmCZji+oeZ7xHw0UDxT5/GEAt1ErQ4r3KhACQUBEIBXfynAw+vaIqfMaJQK7oZ/G+QjhB5Vh9GjjBE5PUyQXgPlgJkdjJaqdR3RKzxALVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vTIfjDGnj3/WeqbrCcUfjD6T8DjZ2Pu0a9/w7OnCY6E=; b=qQBxlO7FegaZrQp3PBWVF8O+EMLWrgP7oAh0GXt6bREjoxgEYI+LzFJdxPMTA2L5DZVeypprssBxpdW8T8ltxZqXbPgqXvigUv0t25DLRitVZbTtFY2iIdIwIXYLzpRXYkVC5a8as7BHD8FtSgSIcFozkThz46ZKGs+yWFCyfeka6BdeswJinjzBpht7vmk46GTymk3GNW4NfCBcULMp6CSsSzHaWErL7jQWzaxvi4DUF17cjA9LlTZmkCrOSZ9O4Z+dLy0Q5N3ld/NrrkO0al103LTSwK1koKR0f6hZhd5N0Oz+OUvYRThbUZnsyrm/2134tB5ujjFyhrk8Go6z8Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7e21773f-7178-5c8c-f7bc-941308d0297a@suse.com> Date: Wed, 3 May 2023 14:59:18 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: xen | Failed pipeline for staging | 0956aa22 Content-Language: en-US To: "xen-devel@lists.xenproject.org" References: <6452557e7028b_2a54f38959a5@gitlab-sidekiq-catchall-v2-bdc885877-cd8zv.mail> From: Jan Beulich In-Reply-To: <6452557e7028b_2a54f38959a5@gitlab-sidekiq-catchall-v2-bdc885877-cd8zv.mail> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0173.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::15) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|DU0PR04MB9588:EE_ X-MS-Office365-Filtering-Correlation-Id: ad911d4e-1aaa-4f7d-d1ab-08db4bd6358f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: r98y/HrmxbuMqatbAL87ofxAqeI9Nl1FNyqitSZz+pIn5J+lskyc3b9Qf7zb4NYoU/NjLtqCa2oMddGh0JDWvGETFWCrhzJGgowSnTFDo3Dpy5UGVyDAe/khv1MG14fYjBVvfoqYhejf+RjEagf60LZ7/Tcn/sWVDjGLLDdbpZzzQsGjlYDgf9RtYuDCJjAEXWljKWMPdYaRZIPLUG5UsKeuFj442qjHwtd6ZdvyNWNBy11dtd1cgtc9FpYZvMrRE0n0SuGU+JD1QkBujI22lLwhzN6Nt5EtvN1lyAS1nqj2Lyt9gkum9zNswVAdiXpKDZ44r/6OJ20/fEEnqA6U7dIhGl628MhEh2L2huAL3Nq3mQq4LKbzuxVUznWrUpltOp5+q3fEwu9z9gUXYn6uyiLZKQKl8FLU52BTizj4l/76P59cvw9HhLCFAxhxk49aZEMW1nIS40xYM0FbYMLGBajEZzPFsT1+dSeCMP82iuT8NFkoc3J/qY1A56ZCLG8a2/E1Mht8u4oOzksfN9odwQJjIouaEe4EbOhNToEqTYBEN4m+zVh7diVsj4LmHIwkmE1wkK9P5sxQgNhdWzBlwUkhq26XPO+bF83VUoYhncR/SiJfM04Dpah6jt3ODWEc0IrE2i11nltiDAvTiEQiNtl56a9jtGetOgTsO7PDJfo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(136003)(346002)(376002)(39860400002)(366004)(451199021)(478600001)(53546011)(31686004)(2616005)(186003)(6506007)(6512007)(26005)(6486002)(966005)(6916009)(41300700001)(66476007)(66946007)(66556008)(316002)(83380400001)(8676002)(5660300002)(2906002)(38100700002)(8936002)(31696002)(36756003)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d2lHcGVwOXdmbmgwY1RVdTRoaEdjKzFLaE5qNGVIMEFEV3YrZlRYM2k5d28v?= =?utf-8?B?R1pOVkIrR3Vxazl6Y2hRcXQ5eU9ueVV3Q0xHUE13VGdwWUtraXp0cDcxem9p?= =?utf-8?B?VFErN00wM2dRWTFTWTh0cG9QaEJtUkRUS08weVg4R21UTnVPUFdIcTB6Mlpa?= =?utf-8?B?U1U1R0tFRHpMa0JXSHlGOWpQbHRDdUMycVNYcE1pcEpIVmREbE1IcmFVbC9k?= =?utf-8?B?RHZKSEVObFlvNVFER2tSYW81MVJDL2duN1d0di9SbTJSRk42clNhVzBNNHlw?= =?utf-8?B?c2ZRTmpyb21XN2M2bnBubWVRYU9lbmh5Qm1OQ2U3S1RIRWNXeTRYdFMxeGlx?= =?utf-8?B?ejg1S0pwN25GKzVqdCtTYVh2cGtPZ0c2bGdBQU9UOXlRZUF6QUllaXZiRWRn?= =?utf-8?B?dU1JVHpDa1h2VWFBQ01GRWdkNml5Q2Fpdm0xN3hLdk9JaGZYdExucGNKWWZD?= =?utf-8?B?YmtNUmZFcWVQLzA1cGFCaGJoa0g3YkptSEhGeVZCZXFBd2NNSVlrQ0Q2MlVV?= =?utf-8?B?K1krYlJxMGhhZlZwa1B5RmVHSURSR29RRGNSS2thUlAxTDZOMGNXQSszd2xh?= =?utf-8?B?K0NGeHpwd2o5bnY1TElRSGdaS2Y4WWVYUW5TWXpCaGR0eUxHRWo0Unh1Uk5B?= =?utf-8?B?TUZJYnA3ZUZWL0t6Sko3VW1aNzhvc3VqaU84U2MyWHU3aXQ2NFpYR0pIZ290?= =?utf-8?B?TzU2d0ZQRkNRaFhQS0pqRnlVbmUyVUQ3QXBMMFhaSStWbjI2WUd3QzBkczBB?= =?utf-8?B?RElSZjFVODl0aHhOWVI2cm4wUzVJc3VIeXZPQ2ZKbytHbWI1dzFJZ0xMVjdT?= =?utf-8?B?NmxZYzlhcGZSQ0ZueVo2Vmp5V05jWVhhRndidEx3OCtMNW9VaTRlL0k5UG5t?= =?utf-8?B?S1BNWDBzNkF1Z0VQWmNDelJmS1B6S1g0QkJKVi9WWEZOK3B3SGV3MzYvMllx?= =?utf-8?B?Q2NpOEhxdWpXTGExczYrL0hWSHVDWHY3ck4vemRUOXJZS3ZIS0Z5enB0NkJl?= =?utf-8?B?QXRnRXlxR3c4UG1meGkxR3JuZjZnL1ZXRUh1cTNJZDUrUjlodk9LY1ZVY3BV?= =?utf-8?B?WkNLRmtqaEV5a2V4ZDEza2hHckgvVkE1Q2hvSitFLzBRajhqQXN1M01waUdk?= =?utf-8?B?K1lJZ0UrN2pDVnp0a0ozWEtTU0RYZXZ5Q0lsNGRXbEJwMHpyRG93Mkpudkoz?= =?utf-8?B?aysvVnRiZUtZMHdLdFA4K3JnbEtvb3N2dVZzbkx3VEl6czZTRzk5c2NrdDBQ?= =?utf-8?B?MU9vOGphellXcDBuK2hLS2IydlhRT0F6QVorcTFEZkVvSjR3dkxzcWdpMjll?= =?utf-8?B?U2NlREVsWmZKdjFBZURTYVM4MHpzckRodGlYZHFHbDVRWlBmV0hTWDN5TEpv?= =?utf-8?B?SE1MZ3p2Z3ZJN2oyYXRHZDUwNFdiaFlwUkFQVnVKbitxaW1NZVNIOHFkNUVE?= =?utf-8?B?bVRCOUdzL0lWVldkaldDSGtIOG9abEdlU1d3VVpGaG10RVdZYlN4dTExNDRQ?= =?utf-8?B?RlB0QmkvKzg1bEJOZ3VIT3VLc0puNWFPemYwTUY3NjJTbnArZHc1ZEYzY0NQ?= =?utf-8?B?QUNoSm05RVNvVzRBTEU0L3lCQnlaNlBSOFNhcksyVzFadWtPYTJ4UmhEY1lQ?= =?utf-8?B?ZjI1WTBFb2dQcE00WXVqQ0NURXhHUElBUE0vbXpIZ3lTL0FWcHQyc0YzdC9y?= =?utf-8?B?YURkTkxzdHhRV2Q0elNYSE0vc1l6UStDN1lYVTYyZThTdnZ4UGVpZmNwTUhP?= =?utf-8?B?Q0VhcUpzQitmUFhiVnZ1RXB2TGczUjk4U0RrZUJMSjA5TWExalJ0L1VZNkRw?= =?utf-8?B?THFoVEROMlpOUVNRZDhYdkQyeVhBN3hXOUtmckJlODI1N3ZVdEN3c3dtWGhY?= =?utf-8?B?V1ZkOERxRWtGTUxQekZnV211VkszVzlOOTdZUDBNVEJUVFRsb3N5QVVoOTNw?= =?utf-8?B?bW5mTHdLWjl0eE5nWmovQTZaOHp0bkE0VXMxV2FNVGlCVXhKem5ZaldSRFVO?= =?utf-8?B?U1FPa29ra0F3QnJpY0xzeDNzMEh1WlVHWm5qekZpTTZpaDJpaTBiU2gyemI0?= =?utf-8?B?RlRBTUNqZzJ1My9zaC9tZkZrZEN4SXVmWXhIaWxKNFp6Mi9IbTFCdHF5YUV6?= =?utf-8?Q?TQmfYbtoL4zfep+Jpz7eXCz0q?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad911d4e-1aaa-4f7d-d1ab-08db4bd6358f X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 12:59:19.8471 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: n+hZby+46q7JDSxKMmQFztqVZEzX6VBkJm4GC+En5o3m+zDcFXgPa3vvcORFyZPbxCSiFVqvoMg1TpIOCkIIKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9588 On 03.05.2023 14:37, GitLab wrote: > > > Pipeline #855820014 has failed! > > Project: xen ( https://gitlab.com/xen-project/xen ) > Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) > > Commit: 0956aa22 ( https://gitlab.com/xen-project/xen/-/commit/0956aa2219745a198bb6a0a99e2108a3c09b280e ) > Commit Message: x86/mm: replace bogus assertion in paging_log_d... > Commit Author: Jan Beulich ( https://gitlab.com/jbeulich ) > > Pipeline #855820014 ( https://gitlab.com/xen-project/xen/-/pipelines/855820014 ) triggered by Ganis ( https://gitlab.com/ganis ) > had 6 failed jobs. > > Job #4218447934 ( https://gitlab.com/xen-project/xen/-/jobs/4218447934/raw ) > > Stage: build > Name: opensuse-tumbleweed-clang > Job #4218447943 ( https://gitlab.com/xen-project/xen/-/jobs/4218447943/raw ) > > Stage: build > Name: opensuse-tumbleweed-gcc-debug > Job #4218447940 ( https://gitlab.com/xen-project/xen/-/jobs/4218447940/raw ) > > Stage: build > Name: opensuse-tumbleweed-gcc > Job #4218447966 ( https://gitlab.com/xen-project/xen/-/jobs/4218447966/raw ) > > Stage: test > Name: adl-pci-hvm-x86-64-gcc-debug > Job #4218447937 ( https://gitlab.com/xen-project/xen/-/jobs/4218447937/raw ) > > Stage: build > Name: opensuse-tumbleweed-clang-debug Two of the build failures look to be addressed by Olaf's still pending "tools/libs/guest: assist gcc13's realloc analyzer". I guess I'm going to commit this with (just) the two R-b that there are. The other two are less clear, at least to me: checking for openpty et al... configure: error: in `/builds/xen-project/xen/tools': configure: error: Unable to find library for openpty and login_tty See `config.log' for more details configure: error: ./configure failed for tools Jan > Job #4218448078 ( https://gitlab.com/xen-project/xen/-/jobs/4218448078/raw ) > > Stage: test > Name: qemu-smoke-dom0less-arm32-gcc-debug-gzip > From xen-devel-bounces@lists.xenproject.org Wed May 03 12:59:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 12:59:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529192.823307 (Exim 4.92) (envelope-from ) id 1puC5C-00013Z-KV; Wed, 03 May 2023 12:59:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529192.823307; Wed, 03 May 2023 12:59:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puC5C-00013S-HS; Wed, 03 May 2023 12:59:46 +0000 Received: by outflank-mailman (input) for mailman id 529192; Wed, 03 May 2023 12:59:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puC5B-000138-IK for xen-devel@lists.xenproject.org; Wed, 03 May 2023 12:59:45 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puC5B-0002QN-0Z; Wed, 03 May 2023 12:59:45 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[192.168.7.72]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1puC5A-0003Rr-QE; Wed, 03 May 2023 12:59:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=XjRyBmen38hK+2UHszJvugGdf2RXVGnU3dXLBe5dbg4=; b=EeRHE7ncI8jOofgXmkpWu2d3ay gnUPEHirBoc2ozm8dN96kesg5yQSoDfiivFjZYoI9kX68vzg1vrSl3CZBfhIQCwYqX7q1QkLLyk4z Qj8Cs2n5rrr0VriQa+ixJBm6tKZhdoDUWtgW+BirORqQZCxO8y2vLiKXAqLzhRSaDz04=; Message-ID: <1a2a7aed-8947-c5ed-e1ed-8fa80bc75750@xen.org> Date: Wed, 3 May 2023 13:59:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 03/13] tools/xenstore: modify interface of create_hashtable() Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230330085011.9170-1-jgross@suse.com> <20230330085011.9170-4-jgross@suse.com> From: Julien Grall In-Reply-To: <20230330085011.9170-4-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 30/03/2023 09:50, Juergen Gross wrote: > The minsize parameter of create_hashtable() doesn't have any real use > case for Xenstore, so drop it. > > For better talloc_report_full() diagnostic output add a name parameter > to create_hashtable(). > > Signed-off-by: Juergen Gross > --- > tools/xenstore/hashtable.c | 20 ++++++-------------- > tools/xenstore/hashtable.h | 4 ++-- > tools/xenstore/xenstored_core.c | 2 +- > tools/xenstore/xenstored_domain.c | 4 ++-- > 4 files changed, 11 insertions(+), 19 deletions(-) > > diff --git a/tools/xenstore/hashtable.c b/tools/xenstore/hashtable.c > index c1b11743bb..ab1e687d0b 100644 > --- a/tools/xenstore/hashtable.c > +++ b/tools/xenstore/hashtable.c > @@ -55,36 +55,28 @@ static unsigned int loadlimit(unsigned int pindex) > return ((uint64_t)primes[pindex] * MAX_LOAD_PERCENT) / 100; > } > > -struct hashtable *create_hashtable(const void *ctx, unsigned int minsize, > +struct hashtable *create_hashtable(const void *ctx, const char *name, > unsigned int (*hashf) (const void *), > int (*eqf) (const void *, const void *), > unsigned int flags) > { > struct hashtable *h; > - unsigned int pindex, size = primes[0]; > - > - /* Check requested hashtable isn't too large */ > - if (minsize > (1u << 30)) return NULL; > - > - /* Enforce size as prime */ > - for (pindex=0; pindex < PRIME_TABLE_LEN; pindex++) { > - if (primes[pindex] > minsize) { size = primes[pindex]; break; } > - } > > h = talloc_zero(ctx, struct hashtable); > if (NULL == h) > goto err0; > - h->table = talloc_zero_array(h, struct entry *, size); > + talloc_set_name_const(h, name); > + h->table = talloc_zero_array(h, struct entry *, primes[0]); > if (NULL == h->table) > goto err1; > > - h->tablelength = size; > + h->tablelength = primes[0]; I find the connection between this line, ... > h->flags = flags; > - h->primeindex = pindex; > + h->primeindex = 0; ... this one and ... > h->entrycount = 0; > h->hashfn = hashf; > h->eqfn = eqf; > - h->loadlimit = loadlimit(pindex); > + h->loadlimit = loadlimit(0); ... now more difficult to find. How about setting h->primeindex first and then using it in place of 0? > return h; > > err1: > diff --git a/tools/xenstore/hashtable.h b/tools/xenstore/hashtable.h > index 04310783b6..0e1a6f61c2 100644 > --- a/tools/xenstore/hashtable.h > +++ b/tools/xenstore/hashtable.h > @@ -10,7 +10,7 @@ struct hashtable; > > * @name create_hashtable > * @param ctx talloc context to use for allocations > - * @param minsize minimum initial size of hashtable > + * @param name talloc name of the hashtable > * @param hashfunction function for hashing keys > * @param key_eq_fn function for determining key equality > * @param flags flags HASHTABLE_* > @@ -23,7 +23,7 @@ struct hashtable; > #define HASHTABLE_FREE_KEY (1U << 1) > > struct hashtable * > -create_hashtable(const void *ctx, unsigned int minsize, > +create_hashtable(const void *ctx, const char *name, > unsigned int (*hashfunction) (const void *), > int (*key_eq_fn) (const void *, const void *), > unsigned int flags > diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c > index 7214b3df03..6ce7be3161 100644 > --- a/tools/xenstore/xenstored_core.c > +++ b/tools/xenstore/xenstored_core.c > @@ -2511,7 +2511,7 @@ void check_store(void) > struct check_store_data data; > > /* Don't free values (they are all void *1) */ > - data.reachable = create_hashtable(NULL, 16, hash_from_key_fn, > + data.reachable = create_hashtable(NULL, "checkstore", hash_from_key_fn, > keys_equal_fn, HASHTABLE_FREE_KEY); > if (!data.reachable) { > log("check_store: ENOMEM"); > diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c > index df64c87efc..6d40aefc63 100644 > --- a/tools/xenstore/xenstored_domain.c > +++ b/tools/xenstore/xenstored_domain.c > @@ -1017,7 +1017,7 @@ void domain_init(int evtfd) > int rc; > > /* Start with a random rather low domain count for the hashtable. */ > - domhash = create_hashtable(NULL, 8, domhash_fn, domeq_fn, 0); > + domhash = create_hashtable(NULL, "domains", domhash_fn, domeq_fn, 0); > if (!domhash) > barf_perror("Failed to allocate domain hashtable"); > > @@ -1804,7 +1804,7 @@ struct hashtable *domain_check_acc_init(void) > { > struct hashtable *domains; > > - domains = create_hashtable(NULL, 8, domhash_fn, domeq_fn, > + domains = create_hashtable(NULL, "domain_check", domhash_fn, domeq_fn, > HASHTABLE_FREE_VALUE); > if (!domains) > return NULL; Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 03 13:01:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 13:01:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529197.823317 (Exim 4.92) (envelope-from ) id 1puC6p-0002ge-Ve; Wed, 03 May 2023 13:01:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529197.823317; Wed, 03 May 2023 13:01:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puC6p-0002gX-SW; Wed, 03 May 2023 13:01:27 +0000 Received: by outflank-mailman (input) for mailman id 529197; Wed, 03 May 2023 13:01:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puC6o-0002g5-MT for xen-devel@lists.xenproject.org; Wed, 03 May 2023 13:01:26 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9a23f189-e9b2-11ed-8611-37d641c3527e; Wed, 03 May 2023 15:01:23 +0200 (CEST) Received: from mail-mw2nam10lp2108.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.108]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 May 2023 09:01:09 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB6455.namprd03.prod.outlook.com (2603:10b6:a03:38d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Wed, 3 May 2023 13:01:07 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb%4]) with mapi id 15.20.6340.031; Wed, 3 May 2023 13:01:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9a23f189-e9b2-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683118884; h=message-id:date:subject:to:references:from:in-reply-to: content-transfer-encoding:mime-version; bh=GJeHLp374TLZGI7k5umNOKZxgQ00DxIGQ5macyftYIk=; b=EuylkQDB8unKNJXhf6FGTPqKevuhQE4hyhELKpOpzJu2DHns5Ysas5Ny 6JycFiPh9ubnLEm7CRua6HvCYF1xNaGVSCmVYnsaj47KxL7AeYvBbKJr5 CHtc7QQGoV+BCFVD+XqdugRgJk5Kay/o1uS3GB46qUs8f5Xqgm4+AqSoh M=; X-IronPort-RemoteIP: 104.47.55.108 X-IronPort-MID: 107038349 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:E3EDQ6jzElGaSw/snzeqlWYZX161eREKZh0ujC45NGQN5FlHY01je htvXGiBb6uKN2r3f95xPoW2p01V7ZWEnYJiHAplpCw0E3gb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWj0N8klgZmP6sT4QeFzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQFdABUZSCjjdi974meestUgeFyCcLCadZ3VnFIlVk1DN4AaLWaG+Dv2oUd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEsluG1YLI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6TeXnrqU62wHCroAVIC8tc0S9jejgtnCvBM1vd Q8e+XF/lpFnoSRHSfG4BXVUukWsvBQRRt5RGO0S8xyWx+zf5APxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+pQSiaPCEUKSoHenUCRA5cu937+thr3lTIU8ppF7OzgpvtAzbsz juWrS84wbIOkcoM0Kb99lfC696xmqX0oscOzl2/dgqYAslROOZJu6TABYDn0Mt9 IronPort-HdrOrdr: A9a23:9PNNKK9A0U1MmP7kRIluk+Fcdb1zdoMgy1knxilNoENuHPBwxv rAoB1E73PJYW4qKQodcLC7UpVoMkmsj6KdgLNhdYtKOTOGhILGFvAa0WKP+UyDJ8SczJ8X6U 4DSdkHNDSYNzET5qaKgzVQeOxQpOVvhZrY49s2uE0dKj2CBZsQijuRDDz3LmRGAC19QbYpHp uV4cRK4xC6f24MU8i9Dn4ZG8DeutzijvvdEFM7Li9izDPLoSKj6bb8HRTd9AwZSSlzzbAr9n WAuxDl55+kr+qwxnbnpiPuBtVt6ZTcI+l4dY2xY/suW3XRY8GTFcdcsoi5zX4ISSeUmRQXeZ f30lId1o9Img7slymO0GfQMk/boXwTA7uI8y7evZMlyvaJAA4SGo5Pg5lUfQDe7FdltNZg0L hT12bcrJZPCwjc9R6NkOQhx3lR5zWJSFcZ4JsuZkZkIP8jQa4UqZZa8FJeEZ8GEi6/4Ic7EP N2BMWZ4PpNa1uVY33Qo2EqmbWXLz0ONwbDRlJHtt2e0jBQknw8x0wExNYHlnNF8J4mUZFL6+ nNL6wtnrBTSc0da757GY46ML2KI32IRQiJPHOZIFzhGq1CM3XRq4Tv6LFw/+2ucIxg9upBpH 0AaiIqiYcfQTOfNSTV5uw0zvnkehTNYQjQ X-Talos-CUID: 9a23:lTQ/fGONbGpgn+5DRXVXrUUkOsofeVLm6UfyG0idWENiYejA X-Talos-MUID: 9a23:kr82ogkFfIc3tjdZ4hgsdnpQD+F35Yi/UXwzgMoZi5fHPy8ragyk2WE= X-IronPort-AV: E=Sophos;i="5.99,247,1677560400"; d="scan'208";a="107038349" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gdRdI2MYENYPMvkUlGRUrojLTp1a9nINojpWGkebCTIVzq5yPXblNqdzrW0cMBavHCM3LUHFBEgbSi57QcEyRhtIPL+B/YUdvno380OsB5/u2Djun0yLcuxW1GrZrpHs2tDMkDIUd/NKI6eQuuwK7656YmDHd2cjqUszqOlyIVx8rUPA3xvGHFt/CCwbh2absd9Zlb8jAJtiqXdKZhDLmPv02Ql6OteyOaB8oRTXBT6SIoiaeZiuzX7b5SZXyl2XmVrNOLBaxY33VQ46H9YdAltLCFQq+vGiU8Udmq6ZbUz2F8uZrVtP8++GgY3Y7XxEsyPz8SMioGryo4bYlsaFlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GJeHLp374TLZGI7k5umNOKZxgQ00DxIGQ5macyftYIk=; b=Q6GWLFamqfwaRhklE/1Kzyx9+GMD/SZ5FjTiFuL4nruMKheqKzKdEcu4JUDJCXcgKBoYphtYjMkFV9vJVaEdsK3TnKPTwDBxj02HYzBJdSL+7/D7An2w/B46DfQN3JOB8Ium4JKuY9iy2YWbz6REqT51zLiaHUhZPdQSuzK4Rhhpzte7kpbrLDsTcTJ5d2Xfr6Q2zNhf3Scws8NaUJNecXhxi4AM1EEyCXXZ7/L/IguILxflt0X4nurdRAVUqpOfgY/NGzP51MRUDHKHK8Lm1g9OpogsVXwOFaW6b2ziUjay/oFIka69DkO7U5HRxgHwUH23sbOsdRWJ9j9Pjun9Iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GJeHLp374TLZGI7k5umNOKZxgQ00DxIGQ5macyftYIk=; b=bZFKgATTh7lyuBDXnvYYZ0ZMmB81eKMrr3GhI79Smm6NRU8xZkO4jZRJsCQ6quHiA3z/VE6FZpAcTplRSKsmXqb3gRNZf4HbDnZKyHIiyauPYUn3WpGC+jBdXOEkwfni2XK4zQ4Oy0OhDWqP/dgKfG5+7ds1PATqL4yNVeju/CQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <836de116-bfac-3bf7-ef36-9f83d7f7dcc1@citrix.com> Date: Wed, 3 May 2023 14:01:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: xen | Failed pipeline for staging | 0956aa22 Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <6452557e7028b_2a54f38959a5@gitlab-sidekiq-catchall-v2-bdc885877-cd8zv.mail> <7e21773f-7178-5c8c-f7bc-941308d0297a@suse.com> From: Andrew Cooper In-Reply-To: <7e21773f-7178-5c8c-f7bc-941308d0297a@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LNXP265CA0011.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::23) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB6455:EE_ X-MS-Office365-Filtering-Correlation-Id: 8f273861-27f2-4e3a-015f-08db4bd67540 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ehDi5b9lYW0T4FgBnZJNFEiKnjJwHHNzamW8VeU+W+ppsNO/PhejbPknKuvXx+H0AqFmt/k6FIvPmSlMZeD+R/XrtYo1u72Cz/WsH9EDMFjV2mnbK9Fl8oHKYtyL1437SRqxIr9J2eOihXY0sa72fiQ0jTE607YklNvF73CNr5CeBs55049a/pyeiqAZxVsl8NC9hBmACDyYjhA9/jrbypiZ1HGM9slRAyqpskfu2Wqc374Qkaie1JEct/V18zBsGnePIOobLwW6OP86hL0w+WAMAoSPywxcW+m6V7lzMekWlT1xtJ3CQc1sDlBc3sCFv9urdTPFVNcXTPHHoZaCLr2bq5+nIsI33fZifhssF0ir0v052gqdBqUPMzYRFoyMhez5O9r+69RMue+Ny91U+emiwtFiSJnbuyydoDeublNnQ9UbKIHZZl9YZfnpstarG2u6Ci5VIKh4b9uEgrewe8k3APQPmndYeSMAtNtd+ShuWKy4qJOkCU+Xf3+nNWX5108j4B7klkkSNxFLHHujutZwqkIxmlKnSNvd3lugINFpzL9wCiOvSWI8+vtARVfXiFrr6nrA0pKBFTXxko0kL7iQmfIAEut++hHQABfVl53e5e7xbb8ydOQrOgZb3DEmc1Z3h3lxsMqbeoAa5S6lu+1UZV4P7cyTPQYmDH/eMdCkMg8nDMXQUr6C4QnedFRt X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(136003)(39860400002)(366004)(346002)(451199021)(5660300002)(6506007)(966005)(8936002)(8676002)(83380400001)(2616005)(2906002)(186003)(36756003)(82960400001)(38100700002)(86362001)(31696002)(6512007)(26005)(53546011)(41300700001)(66946007)(66556008)(66476007)(478600001)(316002)(31686004)(6486002)(110136005)(6666004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WTNkalJ6SDNvbUphQ3ZieVMvL1JqY2l3LzU1S2ZjZWlkQnE3em11cmtiQVFN?= =?utf-8?B?aGRBZXVVdGFLZDlDL2Z3NWUrU1V4SVpQNGxvVDAzbjRxZzI4Ti9kdDhUTzFI?= =?utf-8?B?STlEK01XbnJabFlOWEtLU2IrTkdpUU9lb0g4UjhMbFpYOGI3Yy84UDhTTUFT?= =?utf-8?B?aTR3bDhHU3VXeVBUWm5wb0s4REZ2NWovV1RQREdQMGlXajRpU2FrZm9iQ3Q1?= =?utf-8?B?RGliSFhmVmFrcjB0c1p6N0JyKytpa0tEU1RTMERyb1RjOFZTN2pRM1pYTnpM?= =?utf-8?B?bHhNSjRTMFRRRlF1YWtBUERrU1pyNk1QNkpzOGRpdGY0VHBoMTk4R25XSHhP?= =?utf-8?B?TXZWZGpWOVU1c1hRVGlZdjgyWGh0YXlXOSs0QXU4d3JPUU1kYm5iclc0WmNl?= =?utf-8?B?Qk95ckdma0hyUFYzV2ZkbFZnUFRiVHA3TjFQZ0JFWWtQUEVTN242L2MzZ04v?= =?utf-8?B?aWV3Ym96Y2QrUm5NOWlOWWpyUWtwVEsraGdqVURFR1FwTU1CUkdlWUlFVmdW?= =?utf-8?B?Z1RGdkRCdVFiUmZYOGdTQS9jZXVsckFtTlREclcvL3JXaUpBNy9qQ1NYS0Zo?= =?utf-8?B?c1hPVFVMZUJMdWozdFVoOW5ZSE5vQmFCNDYvZ3RXWFZKR2dLZDdLdVV1Z1Fa?= =?utf-8?B?RzlwUmZTNUNJSFVXWFJTcmxzbW9neS82cHBjRE1Dak45LzZkUUNUSjM2eTdE?= =?utf-8?B?QVp0UXJrWTI5bldsNU03N0ZNSU5rZ2dsenBvdGF5Nm1ubUplWHN0SHVFWkx5?= =?utf-8?B?T1pQRkF2TGJVbUwrcXdFeW1ESTRuOFA2bzNmWWZEd2Y3VFAzS0NicG9RN0Nw?= =?utf-8?B?T1kvbnRGd0lVZXN0NVorbVN1ZmlmUlFqcXE4dlNYUFRGTlBLdEVkZVB6aWEz?= =?utf-8?B?L2tUZ1RlQnhNM3ZFV29YVnZZcHc3U01uekVyUUJEU3Bpb1k5amhacjZFQ0xi?= =?utf-8?B?OU5SZnd5dHZZMjJXUDRENUZ1Q1ZwWnZ1eEVPTUZxb1FReERrV2dKQ1NxWGdX?= =?utf-8?B?dVcraUlTS2tkVXMwSER0cEFHWEpJZTFuOFQ0d2p0M3k4cEkvc3FKQ2srSmxI?= =?utf-8?B?OHBCSE5TaTh3dWxGRDhyOUJwU1N6MlpWYmZFWDRadDNkSi82U3JRcnZjck53?= =?utf-8?B?QjhSSFRqUndmTldESi9zaVNGZ2ZucG1oZXlScDZWS1ZwMmZ4eXd1RXRaTFhN?= =?utf-8?B?Tm5EN1VFdVV1M1JEcXVOYlIwdUJTQnlGM0tPU0tjLzNJbnc2a0NKdWxmT2d6?= =?utf-8?B?VHJUUHlDOGNaM0dRTDRwdCtXdDJoS1ErQ1VvemE3QnFtOWdYcXU0QWdlZVN4?= =?utf-8?B?Rkc5TStIbTMxK1R3d0ZHckhZeHZibVhzV0srdGhTdkx1M1VjZXRoQ3hCemJ4?= =?utf-8?B?OU9CYXZtQVlLd3Y4ZjF1Rlg0Tk96T3pXL0h2bjdoWllRUUVwdXBleGRobGhx?= =?utf-8?B?ZG5VelArVUJXY2hUOWt4eDZ2Wm5ZeHBKSDg1OHBsQjIzL1hZaEMySnFNckpp?= =?utf-8?B?UHZKenZQOGZvRmMxNHpScWhwalkweTI5bUl2YkVCNXBsSk96cEVFbnRSOFFx?= =?utf-8?B?Zzh5WWdTeSt4TE41OGdhMjZ2MHFib3Q5NVNqcTNwb2xaNUROQXAvM3FnYkV1?= =?utf-8?B?MnNNT3cxUHRCUmVETVJ1Ty84bGFEQzgxNlZZWGIxcjdCaHcvOTJrSzFNWnhY?= =?utf-8?B?YUlQU2QzMGN3UGlVZ0pHMCt3OGtBYmM1ZVJLOEdUQ0tZR3pzOGVzUnUrZ25o?= =?utf-8?B?VTlwM3JOWk9QWFJxckNNaGExYzd1ZTFzREQvaDMwb1RacXVHQW9DalBHT1lH?= =?utf-8?B?bU91a0NyRmk4d1RwU3M1RHU2SFIyeWp6em9TUytIWnIzTDU0eUx1RHhWRzdZ?= =?utf-8?B?Z1R4dE1QWFNEcytJN3BQNEUrcXhQMDkrdyt2N2hPeWxPbUpWdVBMT0Z1bWxT?= =?utf-8?B?dTl4WjhReFdLUEFyQ2dCdTdwelIzekhkYnBaNW1QSGhXbC81MG5RNnViTE1t?= =?utf-8?B?MjdERzBLMHY3enpvSkdFTmJzOVVYS3Rkb1hlTEV5MnYvM0lmTk5sN1gzcldn?= =?utf-8?B?QkF1UnE5NjNKdGxTYko0RERDcWt0N05iZkdOMG5OT2ZESmZYb053NVZ3U01k?= =?utf-8?B?UEF4aGY2UVhpZk5UVDcrbjYvSWxhdWhENWZXMXZ4ZG1xTjlkZnVUV2VnVVgw?= =?utf-8?B?ZUE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: xJrZd+XJIx6oQil3B6AGjOLY9Zqx52+ET4H7bB384ui439eVrMEmWEpRzbcwQB5rQ+B9qVugG0291cVPmaWLMk5rihcDKLIh3Avo3Y4FpWjQrzmoaB7mBxU+SPfqq4F3yjoopHs2mTduoV6I9uvzlUSPnq4J7nX3hOEc6IOz/mG/tUVLF5N5OdL0OWoaomuGtqxBoCKUYRa7vlxuFPFpZddTgnJw/J9QA0q9NhbZAQEsbog4nUGSlZ9ja1rVjlmYpYyF+nBQdHtfnGRHZDNWFpJi/zmVd6NLwfJoHkflJSut8242lByuiOzs9zwhYmt3dZr2wRr97Nwdw9mOvFuYwAduWqJId0u0SUFel075WzPsyuZvNKPg/y42SqYAelYOcgAYxZX9uftzMkC+inqiDQ545exvnMCBnbAAneGmb7aRoTnIf8VP/gP3DsKyPHkDYoWay3kF/gA74qXv/dhgi9NuQTpqWJXz2SC0kYiEsnOvqKyLh9t3frEEvwhRG1hY9G3tT9idc+qzGF4gkOq35eEwN5NCN61JQaq2OPaOFXDItipFYnjOhSkZ0M/Nc3AiX++tDGm1TLtze3PU2DSWAAfjDINtSyJXz0+PfpRs29kFDBjLzSlU9hJoh2QGK1MFxLkWMgi+MH3YS2OMIm2dhC+rD/xGos0AV9EiFaI9sxCkOk8tdlaZEHFROmd3hopHngFNHUqNik9fMJPpspegkMAZxTxqBLwQVAhgB7OfKpmbDmBJMVyOHerWu8VcCTKXdV2yU4oFKKNEwfxz64zczr3LvqsQaCXIchV9NCV1JOw= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f273861-27f2-4e3a-015f-08db4bd67540 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 13:01:06.8357 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wX9hDx2/qkMUM+b6snqtBuXKh5C2Uc6EabiL+4KnJpxLz4qhQILX5TgBeSpnZK3cYgrhIk3WPU88vrvF+N2xVztoyWfKR++r18EEi7ckBrk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6455 On 03/05/2023 1:59 pm, Jan Beulich wrote: > On 03.05.2023 14:37, GitLab wrote: >> >> Pipeline #855820014 has failed! >> >> Project: xen ( https://gitlab.com/xen-project/xen ) >> Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) >> >> Commit: 0956aa22 ( https://gitlab.com/xen-project/xen/-/commit/0956aa2219745a198bb6a0a99e2108a3c09b280e ) >> Commit Message: x86/mm: replace bogus assertion in paging_log_d... >> Commit Author: Jan Beulich ( https://gitlab.com/jbeulich ) >> >> Pipeline #855820014 ( https://gitlab.com/xen-project/xen/-/pipelines/855820014 ) triggered by Ganis ( https://gitlab.com/ganis ) >> had 6 failed jobs. >> >> Job #4218447934 ( https://gitlab.com/xen-project/xen/-/jobs/4218447934/raw ) >> >> Stage: build >> Name: opensuse-tumbleweed-clang >> Job #4218447943 ( https://gitlab.com/xen-project/xen/-/jobs/4218447943/raw ) >> >> Stage: build >> Name: opensuse-tumbleweed-gcc-debug >> Job #4218447940 ( https://gitlab.com/xen-project/xen/-/jobs/4218447940/raw ) >> >> Stage: build >> Name: opensuse-tumbleweed-gcc >> Job #4218447966 ( https://gitlab.com/xen-project/xen/-/jobs/4218447966/raw ) >> >> Stage: test >> Name: adl-pci-hvm-x86-64-gcc-debug >> Job #4218447937 ( https://gitlab.com/xen-project/xen/-/jobs/4218447937/raw ) >> >> Stage: build >> Name: opensuse-tumbleweed-clang-debug > Two of the build failures look to be addressed by Olaf's still pending > "tools/libs/guest: assist gcc13's realloc analyzer". I guess I'm going > to commit this with (just) the two R-b that there are. > > The other two are less clear, at least to me: > > checking for openpty et al... configure: error: in `/builds/xen-project/xen/tools': > configure: error: Unable to find library for openpty and login_tty > See `config.log' for more details > configure: error: ./configure failed for tools Olaf has a patch for these too.  "[PATCH v1] tools: drop bogus and obsolete ptyfuncs.m4" I haven't got to looking at it yet, while I'm still chasing the ARM bug. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed May 03 13:03:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 13:03:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529202.823326 (Exim 4.92) (envelope-from ) id 1puC90-0003Ga-CF; Wed, 03 May 2023 13:03:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529202.823326; Wed, 03 May 2023 13:03:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puC90-0003GT-92; Wed, 03 May 2023 13:03:42 +0000 Received: by outflank-mailman (input) for mailman id 529202; Wed, 03 May 2023 13:03:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puC8y-0003GN-Co for xen-devel@lists.xenproject.org; Wed, 03 May 2023 13:03:40 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puC8x-0002hD-Gd; Wed, 03 May 2023 13:03:39 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.7.72]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1puC8x-0003lm-8P; Wed, 03 May 2023 13:03:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=h+RlaBcIWCR28e7I+kfx12e/YKFC6yRGKVdpoY41KuE=; b=gTJjWFEhVB2YsmAO8bIy28t2sD OBU4/9XTrlMJUXWRFW4ZDPR/dGbBNe3DfLkmKxkmPy1U//CI1upBhp44eXQrmsP2NVhgTB2ogEeQt 8pBiHpPjVhgSxLlTYnvBfwdVg1LC/33QG0k/nuYviMWpzW+pJ7GNpquaxdbb7YAdqRWY=; Message-ID: Date: Wed, 3 May 2023 14:03:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 04/13] tools/xenstore: let hashtable_insert() return 0 on success Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230330085011.9170-1-jgross@suse.com> <20230330085011.9170-5-jgross@suse.com> From: Julien Grall In-Reply-To: <20230330085011.9170-5-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 30/03/2023 09:50, Juergen Gross wrote: > Today hashtable_insert() returns 0 in case of an error. Change that to > let it return an errno value in the error case and 0 in case of success. I usually find such change risky because it makes the backport more complex if we introduce a new call to hashtable_insert() and it is also quite difficult to review (the compiler would not help to confirm all the callers have changed). So can you provide a compelling reason for doing the change? (consistency would not be one IMO) Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 03 13:06:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 13:06:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529205.823337 (Exim 4.92) (envelope-from ) id 1puCBK-0003qz-Nt; Wed, 03 May 2023 13:06:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529205.823337; Wed, 03 May 2023 13:06:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puCBK-0003qs-Kw; Wed, 03 May 2023 13:06:06 +0000 Received: by outflank-mailman (input) for mailman id 529205; Wed, 03 May 2023 13:06:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puCBK-0003qm-2x for xen-devel@lists.xenproject.org; Wed, 03 May 2023 13:06:06 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 421be6c3-e9b3-11ed-b225-6b7b168915f2; Wed, 03 May 2023 15:06:04 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-21-PTV4Sh6-PaqKGLOW2cNEKg-1; Wed, 03 May 2023 09:05:59 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 92E9A885627; Wed, 3 May 2023 13:05:58 +0000 (UTC) Received: from localhost (unknown [10.39.195.169]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6C56C2026D16; Wed, 3 May 2023 13:05:57 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 421be6c3-e9b3-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683119163; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Phu2rUngwbJv3O5WPwObndw41FS7BwEFsVdpGZ12G2o=; b=MjA20ljRzl3jfPkuzyrEiCNfJLcmHX/6jllIzT490eNt2wn9EfbF9ct9YQSFlt2X0MyVTZ 9a6mweYEbJ5dp/PimhVeyFCFWBOJ6//VGgHlnnyafyNtWDQLk696kSaLrDqeBGrs2P1Tp1 wkZfWXvflCgv1uuFEiEYnGsr30sofGs= X-MC-Unique: PTV4Sh6-PaqKGLOW2cNEKg-1 Date: Wed, 3 May 2023 09:05:50 -0400 From: Stefan Hajnoczi To: Kevin Wolf Cc: qemu-devel@nongnu.org, Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Juan Quintela , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Richard Henderson , Fam Zheng , "Michael S. Tsirkin" , Coiby Xu , David Woodhouse , Marcel Apfelbaum , Peter Lieven , Paul Durrant , "Richard W.M. Jones" , qemu-block@nongnu.org, Stefano Garzarella , Anthony Perard , Stefan Weil , Xie Yongji , Paolo Bonzini , Aarushi Mehta , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Eduardo Habkost , Stefano Stabellini , Hanna Reitz , Ronnie Sahlberg , Zhengui Li , Daniil Tatianin Subject: Re: [PATCH v4 04/20] virtio-scsi: stop using aio_disable_external() during unplug Message-ID: <20230503130550.GA757667@fedora> References: <20230425172716.1033562-1-stefanha@redhat.com> <20230425172716.1033562-5-stefanha@redhat.com> <20230501150934.GA14869@fedora> <20230502200243.GD535070@fedora> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SX9dxWjHVceQRg4J" Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 --SX9dxWjHVceQRg4J Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 03, 2023 at 01:40:49PM +0200, Kevin Wolf wrote: > Am 02.05.2023 um 22:02 hat Stefan Hajnoczi geschrieben: > > On Tue, May 02, 2023 at 03:19:52PM +0200, Kevin Wolf wrote: > > > Am 01.05.2023 um 17:09 hat Stefan Hajnoczi geschrieben: > > > > On Fri, Apr 28, 2023 at 04:22:55PM +0200, Kevin Wolf wrote: > > > > > Am 25.04.2023 um 19:27 hat Stefan Hajnoczi geschrieben: > > > > > > This patch is part of an effort to remove the aio_disable_exter= nal() > > > > > > API because it does not fit in a multi-queue block layer world = where > > > > > > many AioContexts may be submitting requests to the same disk. > > > > > >=20 > > > > > > The SCSI emulation code is already in good shape to stop using > > > > > > aio_disable_external(). It was only used by commit 9c5aad84da1c > > > > > > ("virtio-scsi: fixed virtio_scsi_ctx_check failed when detachin= g scsi > > > > > > disk") to ensure that virtio_scsi_hotunplug() works while the g= uest > > > > > > driver is submitting I/O. > > > > > >=20 > > > > > > Ensure virtio_scsi_hotunplug() is safe as follows: > > > > > >=20 > > > > > > 1. qdev_simple_device_unplug_cb() -> qdev_unrealize() -> > > > > > > device_set_realized() calls qatomic_set(&dev->realized, fals= e) so > > > > > > that future scsi_device_get() calls return NULL because they= exclude > > > > > > SCSIDevices with realized=3Dfalse. > > > > > >=20 > > > > > > That means virtio-scsi will reject new I/O requests to this > > > > > > SCSIDevice with VIRTIO_SCSI_S_BAD_TARGET even while > > > > > > virtio_scsi_hotunplug() is still executing. We are protected= against > > > > > > new requests! > > > > > >=20 > > > > > > 2. Add a call to scsi_device_purge_requests() from scsi_unreali= ze() so > > > > > > that in-flight requests are cancelled synchronously. This en= sures > > > > > > that no in-flight requests remain once qdev_simple_device_un= plug_cb() > > > > > > returns. > > > > > >=20 > > > > > > Thanks to these two conditions we don't need aio_disable_extern= al() > > > > > > anymore. > > > > > >=20 > > > > > > Cc: Zhengui Li > > > > > > Reviewed-by: Paolo Bonzini > > > > > > Reviewed-by: Daniil Tatianin > > > > > > Signed-off-by: Stefan Hajnoczi > > > > >=20 > > > > > qemu-iotests 040 starts failing for me after this patch, with wha= t looks > > > > > like a use-after-free error of some kind. > > > > >=20 > > > > > (gdb) bt > > > > > #0 0x000055b6e3e1f31c in job_type (job=3D0xe3e3e3e3e3e3e3e3) at = =2E./job.c:238 > > > > > #1 0x000055b6e3e1cee5 in is_block_job (job=3D0xe3e3e3e3e3e3e3e3)= at ../blockjob.c:41 > > > > > #2 0x000055b6e3e1ce7d in block_job_next_locked (bjob=3D0x55b6e72= b7570) at ../blockjob.c:54 > > > > > #3 0x000055b6e3df6370 in blockdev_mark_auto_del (blk=3D0x55b6e74= af0a0) at ../blockdev.c:157 > > > > > #4 0x000055b6e393e23b in scsi_qdev_unrealize (qdev=3D0x55b6e7c04= d40) at ../hw/scsi/scsi-bus.c:303 > > > > > #5 0x000055b6e3db0d0e in device_set_realized (obj=3D0x55b6e7c04d= 40, value=3Dfalse, errp=3D0x55b6e497c918 ) at ../hw/core/qdev.= c:599 > > > > > #6 0x000055b6e3dba36e in property_set_bool (obj=3D0x55b6e7c04d40= , v=3D0x55b6e7d7f290, name=3D0x55b6e41bd6d8 "realized", opaque=3D0x55b6e724= 6d20, errp=3D0x55b6e497c918 ) > > > > > at ../qom/object.c:2285 > > > > > #7 0x000055b6e3db7e65 in object_property_set (obj=3D0x55b6e7c04d= 40, name=3D0x55b6e41bd6d8 "realized", v=3D0x55b6e7d7f290, errp=3D0x55b6e497= c918 ) at ../qom/object.c:1420 > > > > > #8 0x000055b6e3dbd84a in object_property_set_qobject (obj=3D0x55= b6e7c04d40, name=3D0x55b6e41bd6d8 "realized", value=3D0x55b6e74c1890, errp= =3D0x55b6e497c918 ) > > > > > at ../qom/qom-qobject.c:28 > > > > > #9 0x000055b6e3db8570 in object_property_set_bool (obj=3D0x55b6e= 7c04d40, name=3D0x55b6e41bd6d8 "realized", value=3Dfalse, errp=3D0x55b6e497= c918 ) at ../qom/object.c:1489 > > > > > #10 0x000055b6e3daf2b5 in qdev_unrealize (dev=3D0x55b6e7c04d40) a= t ../hw/core/qdev.c:306 > > > > > #11 0x000055b6e3db509d in qdev_simple_device_unplug_cb (hotplug_d= ev=3D0x55b6e81c3630, dev=3D0x55b6e7c04d40, errp=3D0x7ffec5519200) at ../hw/= core/qdev-hotplug.c:72 > > > > > #12 0x000055b6e3c520f9 in virtio_scsi_hotunplug (hotplug_dev=3D0x= 55b6e81c3630, dev=3D0x55b6e7c04d40, errp=3D0x7ffec5519200) at ../hw/scsi/vi= rtio-scsi.c:1065 > > > > > #13 0x000055b6e3db4dec in hotplug_handler_unplug (plug_handler=3D= 0x55b6e81c3630, plugged_dev=3D0x55b6e7c04d40, errp=3D0x7ffec5519200) at ../= hw/core/hotplug.c:56 > > > > > #14 0x000055b6e3a28f84 in qdev_unplug (dev=3D0x55b6e7c04d40, errp= =3D0x7ffec55192e0) at ../softmmu/qdev-monitor.c:935 > > > > > #15 0x000055b6e3a290fa in qmp_device_del (id=3D0x55b6e74c1760 "sc= si0", errp=3D0x7ffec55192e0) at ../softmmu/qdev-monitor.c:955 > > > > > #16 0x000055b6e3fb0a5f in qmp_marshal_device_del (args=3D0x7f61cc= 005eb0, ret=3D0x7f61d5a8ae38, errp=3D0x7f61d5a8ae40) at qapi/qapi-commands-= qdev.c:114 > > > > > #17 0x000055b6e3fd52e1 in do_qmp_dispatch_bh (opaque=3D0x7f61d5a8= ae08) at ../qapi/qmp-dispatch.c:128 > > > > > #18 0x000055b6e4007b9e in aio_bh_call (bh=3D0x55b6e7dea730) at ..= /util/async.c:155 > > > > > #19 0x000055b6e4007d2e in aio_bh_poll (ctx=3D0x55b6e72447c0) at .= =2E/util/async.c:184 > > > > > #20 0x000055b6e3fe3b45 in aio_dispatch (ctx=3D0x55b6e72447c0) at = =2E./util/aio-posix.c:421 > > > > > #21 0x000055b6e4009544 in aio_ctx_dispatch (source=3D0x55b6e72447= c0, callback=3D0x0, user_data=3D0x0) at ../util/async.c:326 > > > > > #22 0x00007f61ddc14c7f in g_main_dispatch (context=3D0x55b6e7244b= 20) at ../glib/gmain.c:3454 > > > > > #23 g_main_context_dispatch (context=3D0x55b6e7244b20) at ../glib= /gmain.c:4172 > > > > > #24 0x000055b6e400a7e8 in glib_pollfds_poll () at ../util/main-lo= op.c:290 > > > > > #25 0x000055b6e400a0c2 in os_host_main_loop_wait (timeout=3D0) at= ../util/main-loop.c:313 > > > > > #26 0x000055b6e4009fa2 in main_loop_wait (nonblocking=3D0) at ../= util/main-loop.c:592 > > > > > #27 0x000055b6e3a3047b in qemu_main_loop () at ../softmmu/runstat= e.c:731 > > > > > #28 0x000055b6e3dab27d in qemu_default_main () at ../softmmu/main= =2Ec:37 > > > > > #29 0x000055b6e3dab2b8 in main (argc=3D24, argv=3D0x7ffec55196a8)= at ../softmmu/main.c:48 > > > > > (gdb) p jobs > > > > > $4 =3D {lh_first =3D 0x0} > > > >=20 > > > > I wasn't able to reproduce this with gcc 13.1.1 or clang 16.0.1: > > > >=20 > > > > $ tests/qemu-iotests/check -qcow2 040 > > > >=20 > > > > Any suggestions on how to reproduce the issue? > > >=20 > > > It happens consistently for me with the same command line, both with = gcc > > > and clang. > > >=20 > > > gcc (GCC) 12.2.1 20221121 (Red Hat 12.2.1-4) > > > clang version 15.0.7 (Fedora 15.0.7-2.fc37) > > >=20 > > > Maybe there is a semantic merge conflict? I have applied the series on > > > top of master (05d50ba2d4) and my block branch (88f81f7bc8). > >=20 > > I can't find 88f81f7bc8 but rebased on repo.or.cz/qemu/kevin.git block > > (4514dac7f2e9) and the test passes here. > >=20 > > I rebased on qemu.git/master (05d50ba2d4) and it also passes. > >=20 > > Please let me know if the following tree (a0ff680a72f6) works on your > > machine: > > https://gitlab.com/stefanha/qemu/-/tree/remove-aio_disable_external >=20 > Fails in the same way. >=20 > So I tried to debug this myself now. The problem is that iterating the > jobs in blockdev_mark_auto_del() is incorrect: job_cancel_locked() > frees the job and then block_job_next_locked() is a use after free. >=20 > It also drops job_mutex temporarily and polls, so even switching to a > *_FOREACH_SAFE style loop won't fix this. I guess we have to restart > the whole search from the start after a job_cancel_locked() because the > list might look very different after the call. >=20 > Now, of course, how this is related to your patch and why it doesn't > trigger before it, is still less than clear. What I found out is that > adding the scsi_device_purge_requests() is enough to crash it. Maybe > it's related to the blk_drain() inside of it. That the job finishes > earlier during the unplug now or something like that. >=20 > Anyway, changing blockdev_mark_auto_del() fixes it. I'll send a patch. Thanks, and sorry for taking your time with debugging it! Stefan --SX9dxWjHVceQRg4J Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmRSXC4ACgkQnKSrs4Gr c8i74Qf6AklkO6aWrRBz6XAZ8dK/EiYL1W+TDr0RyrsU7nCVkvdlyP7AlGvIyjcs YrK8FIjM+cjgHKnMkRqFBMn0xVQMrnSNZ2cLDZaVY4DlgVlmYmmt0RNnQWlftAuc UJkymWg5dZV6hw/TI7ku1+pRnZRx32fxLiMIn+R1tkD8+OX+JMeN7WG3cAhvpPUI m24TcHXZrqNO0kV4qXoM4GJNkDkYLaF1pXQ4MsZpPHcr8Zzhyn+5vlVmo+FEp7iX ozXdMSGcA+fQ3yUGEIUISvZMrc3f8aIfaV29gti8Sj+ekULPGAS9It/2ZJuZTRos Rbou/5fwuiQX6myLLQCGj7HQuwlZ+g== =GY3E -----END PGP SIGNATURE----- --SX9dxWjHVceQRg4J-- From xen-devel-bounces@lists.xenproject.org Wed May 03 13:07:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 13:07:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529209.823347 (Exim 4.92) (envelope-from ) id 1puCCd-0004Sd-6i; Wed, 03 May 2023 13:07:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529209.823347; Wed, 03 May 2023 13:07:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puCCd-0004SW-3U; Wed, 03 May 2023 13:07:27 +0000 Received: by outflank-mailman (input) for mailman id 529209; Wed, 03 May 2023 13:07:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puCCb-0004SJ-Iy for xen-devel@lists.xenproject.org; Wed, 03 May 2023 13:07:25 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puCCb-0002lj-IC for xen-devel@lists.xenproject.org; Wed, 03 May 2023 13:07:25 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[192.168.7.72]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1puCCb-0003xa-BP for xen-devel@lists.xenproject.org; Wed, 03 May 2023 13:07:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:To:Subject:MIME-Version:Date:Message-ID; bh=J25v0xeHQmJ98iK3AGD9avQ1ZwSuZ9KoC9ZQDOtObug=; b=hURQbTZRe8JfAQoef9xYeABi2j kXmArVjZEHjOQsGZtAijTPbsE0Prcsco1uEU5ZHnSCjrx5DH0kM/8FfLZVjkJfSUTIzexYSjGtiQD 2rhZzm7wwhRKtWYdyJGliaidH+mpIxAgEMWqUCA9GjiiUEAp976D3gUPcf0kAq77iRVM=; Message-ID: <764c6eaf-3f3a-bf27-3678-391b12f56cd9@xen.org> Date: Wed, 3 May 2023 14:07:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 07/13] tools/xenstore: remove stale TODO file Content-Language: en-US To: xen-devel@lists.xenproject.org References: <20230330085011.9170-1-jgross@suse.com> <20230330085011.9170-8-jgross@suse.com> From: Julien Grall In-Reply-To: <20230330085011.9170-8-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 30/03/2023 09:50, Juergen Gross wrote: > The TODO file is not really helpful any longer. It contains only > entries which no longer apply or it is unknown what they are meant > for ("Dynamic/supply nodes", "Remove assumption that rename doesn't > fail"). > > Signed-off-by: Juergen Gross Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 03 13:08:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 13:08:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529213.823357 (Exim 4.92) (envelope-from ) id 1puCDI-0004yQ-FC; Wed, 03 May 2023 13:08:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529213.823357; Wed, 03 May 2023 13:08:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puCDI-0004yJ-CB; Wed, 03 May 2023 13:08:08 +0000 Received: by outflank-mailman (input) for mailman id 529213; Wed, 03 May 2023 13:08:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puCDG-0004yB-NV for xen-devel@lists.xenproject.org; Wed, 03 May 2023 13:08:06 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puCDF-0002mb-Vj; Wed, 03 May 2023 13:08:05 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.7.72]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1puCDF-0003zY-PD; Wed, 03 May 2023 13:08:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=YtF1M7NzKn1kvI4rH1OiF33P+f9VuzkgDiqImSOPZ5g=; b=twKI5E1Z5r7GYXTFVie4BcJYus /0FFJdFrAHh/OudyAVF9ZcYwMwZmFFjcPFaG9DuZkb+uygS7v6M5g8+D7JwJkF1cER3lZCIG2Kc2U x4XJForuSvE4COwaBet9eeEvDAETZa0VJkPWC9CXOVIf4nJ4lbE/OWMlFFyqUAPE8bqE=; Message-ID: Date: Wed, 3 May 2023 14:08:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 08/13] tools/xenstore: remove unused events list Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230330085011.9170-1-jgross@suse.com> <20230330085011.9170-9-jgross@suse.com> From: Julien Grall In-Reply-To: <20230330085011.9170-9-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 30/03/2023 09:50, Juergen Gross wrote: > struct watch contains an used struct list_head events. Remove it. Typo: s/used/unused/? > > Signed-off-by: Juergen Gross Acked-by: Julien Grall Cheers, > --- > tools/xenstore/xenstored_watch.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/tools/xenstore/xenstored_watch.c b/tools/xenstore/xenstored_watch.c > index e8eb35de02..4195c59e17 100644 > --- a/tools/xenstore/xenstored_watch.c > +++ b/tools/xenstore/xenstored_watch.c > @@ -36,9 +36,6 @@ struct watch > /* Watches on this connection */ > struct list_head list; > > - /* Current outstanding events applying to this watch. */ > - struct list_head events; > - > /* Offset into path for skipping prefix (used for relative paths). */ > unsigned int prefix_len; > > @@ -205,8 +202,6 @@ static struct watch *add_watch(struct connection *conn, char *path, char *token, > > watch->prefix_len = relative ? strlen(get_implicit_path(conn)) + 1 : 0; > > - INIT_LIST_HEAD(&watch->events); > - > domain_watch_inc(conn); > list_add_tail(&watch->list, &conn->watches); > talloc_set_destructor(watch, destroy_watch); -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 03 13:11:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 13:11:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529215.823366 (Exim 4.92) (envelope-from ) id 1puCGd-0006SK-TD; Wed, 03 May 2023 13:11:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529215.823366; Wed, 03 May 2023 13:11:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puCGd-0006SD-Qh; Wed, 03 May 2023 13:11:35 +0000 Received: by outflank-mailman (input) for mailman id 529215; Wed, 03 May 2023 13:11:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puCGc-0006S7-6o for xen-devel@lists.xenproject.org; Wed, 03 May 2023 13:11:34 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 04e02d26-e9b4-11ed-8611-37d641c3527e; Wed, 03 May 2023 15:11:31 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-400-scHiVcTtPcyrb409VnmdJw-1; Wed, 03 May 2023 09:11:29 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C73D1185A7A2; Wed, 3 May 2023 13:11:27 +0000 (UTC) Received: from localhost (unknown [10.39.195.169]) by smtp.corp.redhat.com (Postfix) with ESMTP id CD6E3492C1B; Wed, 3 May 2023 13:11:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 04e02d26-e9b4-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683119490; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zDf5y2EkHT9U0n319r/7zDgcT1di3Iez/iSIsbs73yg=; b=DomLdPxnEEBmpmTt9RiVVGSaBm/Lr0x7JARg2vzdbJJJAxynU7WHPUMN54enoHsBr5g1Jh 6kopnctjm6D7lonwZK+1NEDnU3slT4BrfzMz8YwXsl8ciOOevVc8T6C0KuwusR7VOXHmlP 1FEAf5WtU243XZ/9zD5UZpZ1aicqSuY= X-MC-Unique: scHiVcTtPcyrb409VnmdJw-1 Date: Wed, 3 May 2023 09:11:25 -0400 From: Stefan Hajnoczi To: Kevin Wolf Cc: qemu-devel@nongnu.org, Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Juan Quintela , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Richard Henderson , Fam Zheng , "Michael S. Tsirkin" , Coiby Xu , David Woodhouse , Marcel Apfelbaum , Peter Lieven , Paul Durrant , "Richard W.M. Jones" , qemu-block@nongnu.org, Stefano Garzarella , Anthony Perard , Stefan Weil , Xie Yongji , Paolo Bonzini , Aarushi Mehta , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Eduardo Habkost , Stefano Stabellini , Hanna Reitz , Ronnie Sahlberg Subject: Re: [PATCH v4 07/20] block/export: stop using is_external in vhost-user-blk server Message-ID: <20230503131125.GB757667@fedora> References: <20230425172716.1033562-1-stefanha@redhat.com> <20230425172716.1033562-8-stefanha@redhat.com> <20230502200645.GE535070@fedora> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7BkvsqboKjcTwbWK" Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 --7BkvsqboKjcTwbWK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 03, 2023 at 10:08:46AM +0200, Kevin Wolf wrote: > Am 02.05.2023 um 22:06 hat Stefan Hajnoczi geschrieben: > > On Tue, May 02, 2023 at 06:04:24PM +0200, Kevin Wolf wrote: > > > Am 25.04.2023 um 19:27 hat Stefan Hajnoczi geschrieben: > > > > vhost-user activity must be suspended during bdrv_drained_begin/end= (). > > > > This prevents new requests from interfering with whatever is happen= ing > > > > in the drained section. > > > >=20 > > > > Previously this was done using aio_set_fd_handler()'s is_external > > > > argument. In a multi-queue block layer world the aio_disable_extern= al() > > > > API cannot be used since multiple AioContext may be processing I/O,= not > > > > just one. > > > >=20 > > > > Switch to BlockDevOps->drained_begin/end() callbacks. > > > >=20 > > > > Signed-off-by: Stefan Hajnoczi > > > > --- > > > > block/export/vhost-user-blk-server.c | 43 ++++++++++++++----------= ---- > > > > util/vhost-user-server.c | 10 +++---- > > > > 2 files changed, 26 insertions(+), 27 deletions(-) > > > >=20 > > > > diff --git a/block/export/vhost-user-blk-server.c b/block/export/vh= ost-user-blk-server.c > > > > index 092b86aae4..d20f69cd74 100644 > > > > --- a/block/export/vhost-user-blk-server.c > > > > +++ b/block/export/vhost-user-blk-server.c > > > > @@ -208,22 +208,6 @@ static const VuDevIface vu_blk_iface =3D { > > > > .process_msg =3D vu_blk_process_msg, > > > > }; > > > > =20 > > > > -static void blk_aio_attached(AioContext *ctx, void *opaque) > > > > -{ > > > > - VuBlkExport *vexp =3D opaque; > > > > - > > > > - vexp->export.ctx =3D ctx; > > > > - vhost_user_server_attach_aio_context(&vexp->vu_server, ctx); > > > > -} > > > > - > > > > -static void blk_aio_detach(void *opaque) > > > > -{ > > > > - VuBlkExport *vexp =3D opaque; > > > > - > > > > - vhost_user_server_detach_aio_context(&vexp->vu_server); > > > > - vexp->export.ctx =3D NULL; > > > > -} > > >=20 > > > So for changing the AioContext, we now rely on the fact that the node= to > > > be changed is always drained, so the drain callbacks implicitly cover > > > this case, too? > >=20 > > Yes. >=20 > Ok. This surprised me a bit at first, but I think it's fine. >=20 > We just need to remember it if we ever decide that once we have > multiqueue, we can actually change the default AioContext without > draining the node. But maybe at that point, we have to do more > fundamental changes anyway. >=20 > > > > static void > > > > vu_blk_initialize_config(BlockDriverState *bs, > > > > struct virtio_blk_config *config, > > > > @@ -272,6 +256,25 @@ static void vu_blk_exp_resize(void *opaque) > > > > vu_config_change_msg(&vexp->vu_server.vu_dev); > > > > } > > > > =20 > > > > +/* Called with vexp->export.ctx acquired */ > > > > +static void vu_blk_drained_begin(void *opaque) > > > > +{ > > > > + VuBlkExport *vexp =3D opaque; > > > > + > > > > + vhost_user_server_detach_aio_context(&vexp->vu_server); > > > > +} > > >=20 > > > Compared to the old code, we're losing the vexp->export.ctx =3D NULL.= This > > > is correct at this point because after drained_begin we still keep > > > processing requests until we arrive at a quiescent state. > > >=20 > > > However, if we detach the AioContext because we're deleting the > > > iothread, won't we end up with a dangling pointer in vexp->export.ctx? > > > Or can we be certain that nothing interesting happens before drained_= end > > > updates it with a new valid pointer again? > >=20 > > If you want I can add the detach() callback back again and set ctx to > > NULL there? >=20 > I haven't thought enough about it to say if it's a problem. If you have > and are confident that it's correct the way it is, I'm happy with it. > > But bringing the callback back is the minimal change compared to the old > state. It's just unnecessary code if we don't actually need it. The reasoning behind my patch is that detach() sets NULL today and we would see crashes if ctx was accessed between detach() -> attach(). Therefore, I'm assuming there are no ctx accesses in the code today and removing the ctx =3D NULL assignment doesn't break anything. However, my approach is not very defensive. If the code is changed in a way that accesses ctx when it's not supposed to, then a dangling pointer will be accessed. I think leaving the detach() callback there can be justified because it will make it easier to detect bugs in the future. I'll add it back in the next revision. Stefan --7BkvsqboKjcTwbWK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmRSXX0ACgkQnKSrs4Gr c8gM4wf9EGB7urw2+olwINpeSZIIcwDydnYjHtFLdg2c1j5VCnMBvL9ZLGU43pUg 9ZjyblYuKFxm/lepAy8L67L9X7MWyUDAC5RVjvTKviQuEcYzsXdKqxCM7FDLz5/G z+jOU1ds4cfCAL6RhRfkEZPClubmNTp9kuWXpsbISy6+WfMGui4957grADrXgH47 qL7ERau5lMwU+NVljzZ7q0U+hPdu1j7jVM5qq34NXLoZTAmDNpaUr29MGJGCYgEP xnv2eAJ/2+bJ4uDvd0G8L93nbpXSulv9l+bTViQEjDP1R4tPxtiXQ7WNfkRoVrHe H4iug75lp6O5k2vDRwNAbqrlaRJZLw== =6nP0 -----END PGP SIGNATURE----- --7BkvsqboKjcTwbWK-- From xen-devel-bounces@lists.xenproject.org Wed May 03 13:12:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 13:12:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529218.823377 (Exim 4.92) (envelope-from ) id 1puCHk-0006yp-6Z; Wed, 03 May 2023 13:12:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529218.823377; Wed, 03 May 2023 13:12:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puCHk-0006yi-3s; Wed, 03 May 2023 13:12:44 +0000 Received: by outflank-mailman (input) for mailman id 529218; Wed, 03 May 2023 13:12:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puCHi-0006yU-7u for xen-devel@lists.xenproject.org; Wed, 03 May 2023 13:12:42 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2dc9f713-e9b4-11ed-8611-37d641c3527e; Wed, 03 May 2023 15:12:39 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-244-nouLQjL3P5uWvchsYPzZzg-1; Wed, 03 May 2023 09:12:37 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B4C4B38173C1; Wed, 3 May 2023 13:12:36 +0000 (UTC) Received: from localhost (unknown [10.39.195.169]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3686B40C6E68; Wed, 3 May 2023 13:12:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2dc9f713-e9b4-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683119559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MvTBKYXxzCnGpUAnqw7NUl7Kpg6AmIw7nyBP3ZgVcq8=; b=D/yynmV2oe6C3Dwi5G3YeNQxt5WO5CPuaZQbRv9nPDnHUL9r8kSXaeFkjm2+ceTcdOcWC8 H8HszutuW+3TaR5y3jUFsgqwVfgAuq16JAbcVQ0QLKMcmS195sH4b4ELd0+ekO79FZiOdV r1hKMyruujc5qAcsyPDOiMwt5VroAsM= X-MC-Unique: nouLQjL3P5uWvchsYPzZzg-1 Date: Wed, 3 May 2023 09:12:34 -0400 From: Stefan Hajnoczi To: Kevin Wolf Cc: qemu-devel@nongnu.org, Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Juan Quintela , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Richard Henderson , Fam Zheng , "Michael S. Tsirkin" , Coiby Xu , David Woodhouse , Marcel Apfelbaum , Peter Lieven , Paul Durrant , "Richard W.M. Jones" , qemu-block@nongnu.org, Stefano Garzarella , Anthony Perard , Stefan Weil , Xie Yongji , Paolo Bonzini , Aarushi Mehta , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Eduardo Habkost , Stefano Stabellini , Hanna Reitz , Ronnie Sahlberg , Daniil Tatianin Subject: Re: [PATCH v4 03/20] virtio-scsi: avoid race between unplug and transport event Message-ID: <20230503131234.GC757667@fedora> References: <20230425172716.1033562-1-stefanha@redhat.com> <20230425172716.1033562-4-stefanha@redhat.com> <20230502185624.GA535070@fedora> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hRXnVXzvq+032LBu" Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 --hRXnVXzvq+032LBu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 03, 2023 at 10:00:57AM +0200, Kevin Wolf wrote: > Am 02.05.2023 um 20:56 hat Stefan Hajnoczi geschrieben: > > On Tue, May 02, 2023 at 05:19:46PM +0200, Kevin Wolf wrote: > > > Am 25.04.2023 um 19:26 hat Stefan Hajnoczi geschrieben: > > > > Only report a transport reset event to the guest after the SCSIDevi= ce > > > > has been unrealized by qdev_simple_device_unplug_cb(). > > > >=20 > > > > qdev_simple_device_unplug_cb() sets the SCSIDevice's qdev.realized = field > > > > to false so that scsi_device_find/get() no longer see it. > > > >=20 > > > > scsi_target_emulate_report_luns() also needs to be updated to filte= r out > > > > SCSIDevices that are unrealized. > > > >=20 > > > > These changes ensure that the guest driver does not see the SCSIDev= ice > > > > that's being unplugged if it responds very quickly to the transport > > > > reset event. > > > >=20 > > > > Reviewed-by: Paolo Bonzini > > > > Reviewed-by: Michael S. Tsirkin > > > > Reviewed-by: Daniil Tatianin > > > > Signed-off-by: Stefan Hajnoczi > > >=20 > > > > @@ -1082,6 +1073,15 @@ static void virtio_scsi_hotunplug(HotplugHan= dler *hotplug_dev, DeviceState *dev, > > > > blk_set_aio_context(sd->conf.blk, qemu_get_aio_context(), = NULL); > > > > virtio_scsi_release(s); > > > > } > > > > + > > > > + if (virtio_vdev_has_feature(vdev, VIRTIO_SCSI_F_HOTPLUG)) { > > > > + virtio_scsi_acquire(s); > > > > + virtio_scsi_push_event(s, sd, > > > > + VIRTIO_SCSI_T_TRANSPORT_RESET, > > > > + VIRTIO_SCSI_EVT_RESET_REMOVED); > > > > + scsi_bus_set_ua(&s->bus, SENSE_CODE(REPORTED_LUNS_CHANGED)= ); > > > > + virtio_scsi_release(s); > > > > + } > > > > } > > >=20 > > > s, sd and s->bus are all unrealized at this point, whereas before this > > > patch they were still realized. I couldn't find any practical problem > > > with it, but it made me nervous enough that I thought I should comment > > > on it at least. > > >=20 > > > Should we maybe have documentation on these functions that says that > > > they accept unrealized objects as their parameters? > >=20 > > s is the VirtIOSCSI controller, not the SCSIDevice that is being > > unplugged. The VirtIOSCSI controller is still realized. > >=20 > > s->bus is the VirtIOSCSI controller's bus, it is still realized. >=20 > You're right, I misread this part. >=20 > > You are right that the SCSIDevice (sd) has been unrealized at this > > point: > > - sd->conf.blk is safe because qdev properties stay alive the > > Object is deleted, but I'm not sure we should rely on that. >=20 > This feels relatively safe (and it's preexisting anyway), reading a > property doesn't do anything unpredictable and we know the pointer is > still valid. >=20 > > - virti_scsi_push_event(.., sd, ...) is questionable because the LUN > > that's fetched from sd no longer belongs to the unplugged SCSIDevice. >=20 > This call is what made me nervous. >=20 > > How about I change the code to fetch sd->conf.blk and the LUN before > > unplugging? >=20 > You mean passing sd->id and sd->lun to virtio_scsi_push_event() instead > of sd itself? That would certainly look cleaner and make sure that we > don't later add code to it that does something with sd that would > require it to be realized. Yes, I'll do that in the next revision. Stefan --hRXnVXzvq+032LBu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmRSXcIACgkQnKSrs4Gr c8iBrQgAnO/r1Kps6Svp0/9nUqUx3S65i1XwWIAK1IbuFqWP6Nq2R+xecFEdmAUN 8f6QyslrUI1EnQ9qXoMRagSDc8iw5CBtA9CtPTg/32uRelh111GM85U3uYvhBlGY dd9GPbB17c/u2Y2CuxBrfc2w2TpDgp0tazuXiQHYO1drrGYyyZu73XdGF+W4DChc Gvk2FofPZ7luLv/kcZvR9UAn9hmBHXpLjByS2XM4QxB+1qXKMYnac6NPl5Icr14H 1TIthHvPJkBklFGrMFyz7CFIYzMIdqFYWT74NpSeEveAODZMxWuZ8JVZtdLIbC6q ZK0P/CdfiC3AKLh1BYuQFDGdrkDJWQ== =7qbb -----END PGP SIGNATURE----- --hRXnVXzvq+032LBu-- From xen-devel-bounces@lists.xenproject.org Wed May 03 13:19:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 13:19:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529223.823387 (Exim 4.92) (envelope-from ) id 1puCNq-0007dg-TZ; Wed, 03 May 2023 13:19:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529223.823387; Wed, 03 May 2023 13:19:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puCNq-0007dZ-QQ; Wed, 03 May 2023 13:19:02 +0000 Received: by outflank-mailman (input) for mailman id 529223; Wed, 03 May 2023 13:19:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puCNq-0007dT-5z for xen-devel@lists.xenproject.org; Wed, 03 May 2023 13:19:02 +0000 Received: from smtp-fw-6001.amazon.com (smtp-fw-6001.amazon.com [52.95.48.154]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 10b465f4-e9b5-11ed-b225-6b7b168915f2; Wed, 03 May 2023 15:19:00 +0200 (CEST) Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-pdx-2a-m6i4x-83883bdb.us-west-2.amazon.com) ([10.43.8.2]) by smtp-border-fw-6001.iad6.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 May 2023 13:18:56 +0000 Received: from EX19D008EUC001.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-pdx-2a-m6i4x-83883bdb.us-west-2.amazon.com (Postfix) with ESMTPS id 1C7BB60F81; Wed, 3 May 2023 13:18:53 +0000 (UTC) Received: from EX19MTAUWC001.ant.amazon.com (10.250.64.145) by EX19D008EUC001.ant.amazon.com (10.252.51.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Wed, 3 May 2023 13:18:52 +0000 Received: from dev-dsk-mheyne-1b-c1362c4d.eu-west-1.amazon.com (10.15.57.183) by mail-relay.amazon.com (10.250.64.145) with Microsoft SMTP Server id 15.2.1118.25 via Frontend Transport; Wed, 3 May 2023 13:18:51 +0000 Received: by dev-dsk-mheyne-1b-c1362c4d.eu-west-1.amazon.com (Postfix, from userid 5466572) id 38D6595D; Wed, 3 May 2023 13:18:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 10b465f4-e9b5-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1683119941; x=1714655941; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=5qY6hxBY40KASy+98g6jZI4fvE1bwgAl23ESUykmNsg=; b=IkmiogEVDztPAwavdF6wMBs1Qo87FT/UxGRsffIvVHhFqiz7JPP1mRxK sz01x6kETEXfGqbQudY9MskQO/NHSbU2fjnpIANzi0Lp9RLdx+tj40Dh9 fcKqVpiMjpI3iwl5AMyjvbtSEvQzLwhM0Fo4aADyIDU78m8vud2Muni+c w=; X-IronPort-AV: E=Sophos;i="5.99,247,1677542400"; d="scan'208";a="327667209" From: Maximilian Heyne To: CC: Maximilian Heyne , Juergen Gross , Bjorn Helgaas , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , , "H. Peter Anvin" , Marc Zyngier , Kevin Tian , Jason Gunthorpe , Ashok Raj , "Ahmed S. Darwish" , Greg Kroah-Hartman , , , Subject: [PATCH] x86/pci/xen: populate MSI sysfs entries Date: Wed, 3 May 2023 13:16:53 +0000 Message-ID: <20230503131656.15928-1-mheyne@amazon.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Precedence: Bulk Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Commit bf5e758f02fc ("genirq/msi: Simplify sysfs handling") reworked the creation of sysfs entries for MSI IRQs. The creation used to be in msi_domain_alloc_irqs_descs_locked after calling ops->domain_alloc_irqs. Then it moved into __msi_domain_alloc_irqs which is an implementation of domain_alloc_irqs. However, Xen comes with the only other implementation of domain_alloc_irqs and hence doesn't run the sysfs population code anymore. Commit 6c796996ee70 ("x86/pci/xen: Fixup fallout from the PCI/MSI overhaul") set the flag MSI_FLAG_DEV_SYSFS for the xen msi_domain_info but that doesn't actually have an effect because Xen uses it's own domain_alloc_irqs implementation. Fix this by making use of the fallback functions for sysfs population. Fixes: bf5e758f02fc ("genirq/msi: Simplify sysfs handling") Signed-off-by: Maximilian Heyne --- arch/x86/pci/xen.c | 8 +++++--- include/linux/msi.h | 9 ++++++++- kernel/irq/msi.c | 4 ++-- 3 files changed, 15 insertions(+), 6 deletions(-) diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c index 8babce71915f..014c508e914d 100644 --- a/arch/x86/pci/xen.c +++ b/arch/x86/pci/xen.c @@ -198,7 +198,7 @@ static int xen_setup_msi_irqs(struct pci_dev *dev, int nvec, int type) i++; } kfree(v); - return 0; + return msi_device_populate_sysfs(&dev->dev); error: if (ret == -ENOSYS) @@ -254,7 +254,7 @@ static int xen_hvm_setup_msi_irqs(struct pci_dev *dev, int nvec, int type) dev_dbg(&dev->dev, "xen: msi --> pirq=%d --> irq=%d\n", pirq, irq); } - return 0; + return msi_device_populate_sysfs(&dev->dev); error: dev_err(&dev->dev, "Failed to create MSI%s! ret=%d!\n", @@ -346,7 +346,7 @@ static int xen_initdom_setup_msi_irqs(struct pci_dev *dev, int nvec, int type) if (ret < 0) goto out; } - ret = 0; + ret = msi_device_populate_sysfs(&dev->dev); out: return ret; } @@ -394,6 +394,8 @@ static void xen_teardown_msi_irqs(struct pci_dev *dev) xen_destroy_irq(msidesc->irq + i); msidesc->irq = 0; } + + msi_device_destroy_sysfs(&dev->dev); } static void xen_pv_teardown_msi_irqs(struct pci_dev *dev) diff --git a/include/linux/msi.h b/include/linux/msi.h index cdb14a1ef268..a50ea79522f8 100644 --- a/include/linux/msi.h +++ b/include/linux/msi.h @@ -383,6 +383,13 @@ int arch_setup_msi_irq(struct pci_dev *dev, struct msi_desc *desc); void arch_teardown_msi_irq(unsigned int irq); int arch_setup_msi_irqs(struct pci_dev *dev, int nvec, int type); void arch_teardown_msi_irqs(struct pci_dev *dev); +#endif /* CONFIG_PCI_MSI_ARCH_FALLBACKS */ + +/* + * Xen uses non-default msi_domain_ops and hence needs a way to populate sysfs + * entries of MSI IRQs. + */ +#if defined(CONFIG_PCI_XEN) || defined(CONFIG_PCI_MSI_ARCH_FALLBACKS) #ifdef CONFIG_SYSFS int msi_device_populate_sysfs(struct device *dev); void msi_device_destroy_sysfs(struct device *dev); @@ -390,7 +397,7 @@ void msi_device_destroy_sysfs(struct device *dev); static inline int msi_device_populate_sysfs(struct device *dev) { return 0; } static inline void msi_device_destroy_sysfs(struct device *dev) { } #endif /* !CONFIG_SYSFS */ -#endif /* CONFIG_PCI_MSI_ARCH_FALLBACKS */ +#endif /* CONFIG_PCI_XEN || CONFIG_PCI_MSI_ARCH_FALLBACKS */ /* * The restore hook is still available even for fully irq domain based diff --git a/kernel/irq/msi.c b/kernel/irq/msi.c index 7a97bcb086bf..b4c31a5c1147 100644 --- a/kernel/irq/msi.c +++ b/kernel/irq/msi.c @@ -542,7 +542,7 @@ static int msi_sysfs_populate_desc(struct device *dev, struct msi_desc *desc) return ret; } -#ifdef CONFIG_PCI_MSI_ARCH_FALLBACKS +#if defined(CONFIG_PCI_MSI_ARCH_FALLBACKS) || defined(CONFIG_PCI_XEN) /** * msi_device_populate_sysfs - Populate msi_irqs sysfs entries for a device * @dev: The device (PCI, platform etc) which will get sysfs entries @@ -574,7 +574,7 @@ void msi_device_destroy_sysfs(struct device *dev) msi_for_each_desc(desc, dev, MSI_DESC_ALL) msi_sysfs_remove_desc(dev, desc); } -#endif /* CONFIG_PCI_MSI_ARCH_FALLBACK */ +#endif /* CONFIG_PCI_MSI_ARCH_FALLBACK || CONFIG_PCI_XEN */ #else /* CONFIG_SYSFS */ static inline int msi_sysfs_create_group(struct device *dev) { return 0; } static inline int msi_sysfs_populate_desc(struct device *dev, struct msi_desc *desc) { return 0; } -- 2.39.2 Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 From xen-devel-bounces@lists.xenproject.org Wed May 03 13:43:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 13:43:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529233.823396 (Exim 4.92) (envelope-from ) id 1puClP-0002cz-08; Wed, 03 May 2023 13:43:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529233.823396; Wed, 03 May 2023 13:43:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puClO-0002cs-Tk; Wed, 03 May 2023 13:43:22 +0000 Received: by outflank-mailman (input) for mailman id 529233; Wed, 03 May 2023 13:43:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puClN-0002ck-Fl for xen-devel@lists.xenproject.org; Wed, 03 May 2023 13:43:21 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 749eda3a-e9b8-11ed-8611-37d641c3527e; Wed, 03 May 2023 15:43:16 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-63-BMx0iVPUPgGDcLgQ7YyuzA-1; Wed, 03 May 2023 09:43:10 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 92812852AF6; Wed, 3 May 2023 13:43:09 +0000 (UTC) Received: from redhat.com (dhcp-192-205.str.redhat.com [10.33.192.205]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 164622166B29; Wed, 3 May 2023 13:43:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 749eda3a-e9b8-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683121395; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LnWGqGWWdJPHGGU1rFwcwMAX+ugZvyvG/DLBRKCKxQk=; b=IrjBXvGomeoyBrVgohlnRrrk8WFPFBDsym+7DJT6odAmaLlcn44QKw3ATnui2caZk5U7N2 5j+/lqhdBSrCq0d+mmLhDQ1TUJgSV8DnkADDlUhiOXuk0CfJ3Gr4UT3k+WW4pIY4+68f0B zFJF4s3ltd6cGJeSIWYeFrYpL+gaUq8= X-MC-Unique: BMx0iVPUPgGDcLgQ7YyuzA-1 Date: Wed, 3 May 2023 15:43:05 +0200 From: Kevin Wolf To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Juan Quintela , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Richard Henderson , Fam Zheng , "Michael S. Tsirkin" , Coiby Xu , David Woodhouse , Marcel Apfelbaum , Peter Lieven , Paul Durrant , "Richard W.M. Jones" , qemu-block@nongnu.org, Stefano Garzarella , Anthony Perard , Stefan Weil , Xie Yongji , Paolo Bonzini , Aarushi Mehta , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Eduardo Habkost , Stefano Stabellini , Hanna Reitz , Ronnie Sahlberg Subject: Re: [PATCH v4 07/20] block/export: stop using is_external in vhost-user-blk server Message-ID: References: <20230425172716.1033562-1-stefanha@redhat.com> <20230425172716.1033562-8-stefanha@redhat.com> <20230502200645.GE535070@fedora> <20230503131125.GB757667@fedora> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3jXylBdepGNQTKaY" Content-Disposition: inline In-Reply-To: <20230503131125.GB757667@fedora> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 --3jXylBdepGNQTKaY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 03.05.2023 um 15:11 hat Stefan Hajnoczi geschrieben: > On Wed, May 03, 2023 at 10:08:46AM +0200, Kevin Wolf wrote: > > Am 02.05.2023 um 22:06 hat Stefan Hajnoczi geschrieben: > > > On Tue, May 02, 2023 at 06:04:24PM +0200, Kevin Wolf wrote: > > > > Am 25.04.2023 um 19:27 hat Stefan Hajnoczi geschrieben: > > > > > vhost-user activity must be suspended during bdrv_drained_begin/e= nd(). > > > > > This prevents new requests from interfering with whatever is happ= ening > > > > > in the drained section. > > > > >=20 > > > > > Previously this was done using aio_set_fd_handler()'s is_external > > > > > argument. In a multi-queue block layer world the aio_disable_exte= rnal() > > > > > API cannot be used since multiple AioContext may be processing I/= O, not > > > > > just one. > > > > >=20 > > > > > Switch to BlockDevOps->drained_begin/end() callbacks. > > > > >=20 > > > > > Signed-off-by: Stefan Hajnoczi > > > > > --- > > > > > block/export/vhost-user-blk-server.c | 43 ++++++++++++++--------= ------ > > > > > util/vhost-user-server.c | 10 +++---- > > > > > 2 files changed, 26 insertions(+), 27 deletions(-) > > > > >=20 > > > > > diff --git a/block/export/vhost-user-blk-server.c b/block/export/= vhost-user-blk-server.c > > > > > index 092b86aae4..d20f69cd74 100644 > > > > > --- a/block/export/vhost-user-blk-server.c > > > > > +++ b/block/export/vhost-user-blk-server.c > > > > > @@ -208,22 +208,6 @@ static const VuDevIface vu_blk_iface =3D { > > > > > .process_msg =3D vu_blk_process_msg, > > > > > }; > > > > > =20 > > > > > -static void blk_aio_attached(AioContext *ctx, void *opaque) > > > > > -{ > > > > > - VuBlkExport *vexp =3D opaque; > > > > > - > > > > > - vexp->export.ctx =3D ctx; > > > > > - vhost_user_server_attach_aio_context(&vexp->vu_server, ctx); > > > > > -} > > > > > - > > > > > -static void blk_aio_detach(void *opaque) > > > > > -{ > > > > > - VuBlkExport *vexp =3D opaque; > > > > > - > > > > > - vhost_user_server_detach_aio_context(&vexp->vu_server); > > > > > - vexp->export.ctx =3D NULL; > > > > > -} > > > >=20 > > > > So for changing the AioContext, we now rely on the fact that the no= de to > > > > be changed is always drained, so the drain callbacks implicitly cov= er > > > > this case, too? > > >=20 > > > Yes. > >=20 > > Ok. This surprised me a bit at first, but I think it's fine. > >=20 > > We just need to remember it if we ever decide that once we have > > multiqueue, we can actually change the default AioContext without > > draining the node. But maybe at that point, we have to do more > > fundamental changes anyway. > >=20 > > > > > static void > > > > > vu_blk_initialize_config(BlockDriverState *bs, > > > > > struct virtio_blk_config *config, > > > > > @@ -272,6 +256,25 @@ static void vu_blk_exp_resize(void *opaque) > > > > > vu_config_change_msg(&vexp->vu_server.vu_dev); > > > > > } > > > > > =20 > > > > > +/* Called with vexp->export.ctx acquired */ > > > > > +static void vu_blk_drained_begin(void *opaque) > > > > > +{ > > > > > + VuBlkExport *vexp =3D opaque; > > > > > + > > > > > + vhost_user_server_detach_aio_context(&vexp->vu_server); > > > > > +} > > > >=20 > > > > Compared to the old code, we're losing the vexp->export.ctx =3D NUL= L. This > > > > is correct at this point because after drained_begin we still keep > > > > processing requests until we arrive at a quiescent state. > > > >=20 > > > > However, if we detach the AioContext because we're deleting the > > > > iothread, won't we end up with a dangling pointer in vexp->export.c= tx? > > > > Or can we be certain that nothing interesting happens before draine= d_end > > > > updates it with a new valid pointer again? > > >=20 > > > If you want I can add the detach() callback back again and set ctx to > > > NULL there? > >=20 > > I haven't thought enough about it to say if it's a problem. If you have > > and are confident that it's correct the way it is, I'm happy with it. > > > > But bringing the callback back is the minimal change compared to the old > > state. It's just unnecessary code if we don't actually need it. >=20 > The reasoning behind my patch is that detach() sets NULL today and we > would see crashes if ctx was accessed between detach() -> attach(). > Therefore, I'm assuming there are no ctx accesses in the code today and > removing the ctx =3D NULL assignment doesn't break anything. Sometimes ctx =3D NULL defaults to qemu_get_aio_context(), so in theory there could be cases where NULL works, but a dangling pointer wouldn't. > However, my approach is not very defensive. If the code is changed in > a way that accesses ctx when it's not supposed to, then a dangling > pointer will be accessed. >=20 > I think leaving the detach() callback there can be justified because it > will make it easier to detect bugs in the future. I'll add it back in > the next revision. Ok, sounds good me. Kevin --3jXylBdepGNQTKaY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE3D3rFZqa+V09dFb+fwmycsiPL9YFAmRSZOgACgkQfwmycsiP L9Z4eQ/+LgU+OhaX4MhIHoKVbBeqTOHQYSWlDg/eh/I3pVF0g/HToZc1vLm0azxU NhSqg87kLo3DRKFUh25e5370t219xFbDW4rz4RVy0OJLklLfj7qi59XOxE0MLiVI 5ySbG1FxdFTNS9dAoYmPuxrucX+RPEpwHw1gIpmIx+GqLGuYhrjvjqOeB/Nx7tm6 dAUmxB4Vt16wsTPs92zA09I8KtiWqr+fm+P2u/jfdsC1HqtWL93uiyQoon7LoCqO c3VwmyR+aFr5AUmlIkS0dxzd9Bbnixd0jnHUEdaowCVLmAYbKvDJkl5HTjYEyF+D p7Lm7GRdQPaJgu4GyKtj8NWwfra2VXEDW0M+VhWEYCLMrka00wXGO1bxjUZzEpP5 8F25eFcpNb2rixwMHlEU3UQJxNS+wtODzmkjIcj4N8F0aM7eNZDuUIDnwGMQirid 9VubITTJZtDtnp+AOO2B3zMhuAqi7EslMXOYHb5NZ9Yi31otsYE5BKScKxaCy5jq w1h+o7sNoyW+48yvjUhxkH1bU/CHbhv9VLQ1QTHgy+uR5lADMjEba7XHBQnclHs2 rzyA9WgwuQcdq4pbUCH/hFMpoPCSNdL/Dw7riadrx7hoJB+GRr7AYfR9NEk6NtAd uBfxOOO5MBpngMUdiDQdlDHmigg2QSJMyFacVTs/NVGFuAO1B6c= =+t1f -----END PGP SIGNATURE----- --3jXylBdepGNQTKaY-- From xen-devel-bounces@lists.xenproject.org Wed May 03 14:07:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 14:07:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529239.823407 (Exim 4.92) (envelope-from ) id 1puD8O-0005F3-Rv; Wed, 03 May 2023 14:07:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529239.823407; Wed, 03 May 2023 14:07:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puD8O-0005Ew-OM; Wed, 03 May 2023 14:07:08 +0000 Received: by outflank-mailman (input) for mailman id 529239; Wed, 03 May 2023 14:07:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puD8N-0005Eq-8L for xen-devel@lists.xenproject.org; Wed, 03 May 2023 14:07:07 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20631.outbound.protection.outlook.com [2a01:111:f400:fe5b::631]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c76bb478-e9bb-11ed-8611-37d641c3527e; Wed, 03 May 2023 16:07:04 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by SA1PR12MB8859.namprd12.prod.outlook.com (2603:10b6:806:37c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Wed, 3 May 2023 14:07:01 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::5b9b:f31f:ac6d:be94]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::5b9b:f31f:ac6d:be94%7]) with mapi id 15.20.6363.022; Wed, 3 May 2023 14:07:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c76bb478-e9bb-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CpFXu2m9Esb3p5mMr35zNmMg7eIHt651b4Maet0sn5/0YHC3LnlplCMZ0kN1APzPKN73YWhDoO01qAaeLVsptpnPbi54dXnP0bysre/K69EMUTSxQypjXLeopXUqTbNlyw8Vid+jUFXGwewqSsnppGHjHsbOq8Gyy0wuEb3v0qD8L5Hy60gpSBlRTHUQbiH9dBdWSLRWshIYs04YPQ/zLb+6a5OJZPm3S98eShsBSDjKlF+qK9iOV3nU8cCPKFCRosHkYVZmtdmCgr0QL+3wQfZjOlr1dtq04pPeqMVsIXHCSGlqHuYCblmrQFjj3JH1LRkfTZMenDduK6FvXki+Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=htY6wAQlmkfy+g2a0rtOTjM6Ae3lrM6ND5lLPxrqvUQ=; b=MIuD2xKDUtbdiaSsfZT2mBE0nJdBuK3UOe9YJiu6wbd/iNVYQxreC8nAQqyOPfJ5xhgsUPSlFsskSNR/w018Ba6PKomcTiDfJm+jSEScP2d3NezSzGmqPOIySKBMqLn4d1uy10JwVVkj6NquoEmAkX3po9ifrJpMwhrnuhb8Tpa6oMokC9MUj+/2qjEwUWeUNG3pdq7pm6SO+gdYX5D8XkNor3dlVKflaWWnqJjzNybmQovTxjpblngF609jESTSwz29yr0ESJGQ4gFof9JOwVIFXdLz3Wbp2FgGloU3h2ZUwHR9s1L404fvpWSTyDO1p8lr2srTuUk12IyQjS9wIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=htY6wAQlmkfy+g2a0rtOTjM6Ae3lrM6ND5lLPxrqvUQ=; b=XTua8Q2+cBXBkeOYxMPpJx4pbReWhxMFB0mQr3y9XABnwi44mta0eUnO9VpwdxgMGkRdiuFmT54otLqWMklE0qXNs08hSCaH0YMXdvzwBJ4tPj0o4LSoDYFNfz1KU9HM6wXqK7XjtLQYoUGFUg7yP2w73Gukn3JrkTd2HzyTPMs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: Date: Wed, 3 May 2023 15:06:54 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [XEN v6 03/12] xen/arm: Introduce a wrapper for dt_device_get_address() to handle paddr_t To: Julien Grall , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, wl@xen.org, rahul.singh@arm.com References: <20230428175543.11902-1-ayan.kumar.halder@amd.com> <20230428175543.11902-4-ayan.kumar.halder@amd.com> <37c9a45f-ae07-8d47-093a-6cf7501389d4@xen.org> From: Ayan Kumar Halder In-Reply-To: <37c9a45f-ae07-8d47-093a-6cf7501389d4@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0202.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::9) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|SA1PR12MB8859:EE_ X-MS-Office365-Filtering-Correlation-Id: dcae417e-3d97-44e1-5438-08db4bdfaa1c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nUU6F07NEW+ox6KrhiHqcQ8L1Xbq2osPC0MX2z0cpIkR+rl590tKOgLutJuOokCqtA1nzJ2z9NoO+4bJQgTUjSeNZTmm0ui6yXt29onAyH0h6UTxIGMWNAYNhLRwMHL9mWhC0j547UdkRTURKcxjle9lTRDWn5oExHTlY/nxEVbx/3vinGnPEdD9IPyKE/y7vyWDaf4WwJYJXd4uQGlEUH7u+8nudI94w/G9EW+CFzPh55t4vAyOmBmGv36uVif/QPSi9wKXitfx7hyapMl5N7iVcojXCe9JSmDrRL+hLm26Nd1KAq7ejoHhqAea1+tNl7NDHjzQyDXo56IhfXvfeAV4ABuy7B7RTjaYsin3UKwuwqyOq/umfRATjrhCt+w39bVh5eaD/I1flOVFZ5aTTgMK70SlOFVZmwLed0yRSpQSvMXsnP5OUaxoke/rChxX5p9vnsjRixRjP3iBz2lhCSekDQ1p25+1mFejAI2qRztK8qYuiPDTzXIqTwgg0lC4iZ3N1E4dNRT2EvMENoz6eWLvppJFWbojEnk5RIET4Cb6x71ybS35q+xZXAVtrFMDwgdN6XTXBQTKkmuIiqFnXfFHvtIhDzCZs3/KCx/yGGe4Lt0QyagtuKSHSwixSeSKWGK0sAR8yPdnncBraivSDg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(366004)(39860400002)(346002)(136003)(396003)(451199021)(31686004)(966005)(8676002)(8936002)(6512007)(26005)(6506007)(2616005)(7416002)(53546011)(36756003)(2906002)(83380400001)(6666004)(5660300002)(4326008)(478600001)(6486002)(41300700001)(316002)(186003)(66946007)(66556008)(66476007)(110136005)(31696002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VFVTb2F2bkRBeGxvaUppcS9kdjJrZWlCWktpRzhkRmhEN2o5cmE1QmsxWGlL?= =?utf-8?B?QWY2UVFqcExhYzNTbTZ3a0FobXRYckRhTGFnN2EycnVJK2VxMXgraUxRYXU0?= =?utf-8?B?K0hQUlJZOWsrTTZPNDFxR3FoZGpPbFBjZ25KVzdRdVZIOW9ERE5CaXpSQXRx?= =?utf-8?B?VGd1U0pKN2s2OVFyWGRDTWRkY2FHNHFEcUt5YW5lNXRpdXA1SUh3VVdmRmdz?= =?utf-8?B?YlJhQXd3ZjYydXdQWmZHRmdJaGxuREtDZEc1NFpVbGN0bTdBL0FpTnU4MlVY?= =?utf-8?B?SFQvLzl0ZzduaXA3R2lRMWNCWXhQNW5QaTgvTk9RaE4zYlJkbDM5Mm9RZm5j?= =?utf-8?B?YkVIOU03WEpZRzhHWWNIUzIxNUQ4cDh5VWhYYmRxWW9mTFVRUzVXR3BHdHUw?= =?utf-8?B?SE9UczY4YzI1TGdOREVkRlZjR1BnYUVrZSszU2dZTk5sVFdhcHlBa0g5ZEow?= =?utf-8?B?NmpTTzg2aDY0N01ydThYeHZHZ296Qm91eEJZQmphSVhIVnNEa1hVbFJ3RGVY?= =?utf-8?B?dVEzTmswL1U5bWNldjBvMEptbmEwb2o5M2E3NTloK1dJMTdKOWpwdnhWcE9v?= =?utf-8?B?V3N2K0J1V1FkZGJ0NkNCcXp2MWdpbGVTMnZRYk9mamNUSjBwWUFUZXkxVlFL?= =?utf-8?B?WkN2dGFsb3JxaFBEZkRPbFVnRzJ0QWdIRlVGMG1JV0g3Nnd5ZmdVY2RmSU9F?= =?utf-8?B?VjhVbG1pZmxRSTlML1pISVMrNThoNGNpV2ZmaDFya0tIa0t6Q1pkL01Fbm9H?= =?utf-8?B?TTZUWFZxTnhScHNrK2QxMXhjQkFKR3JCUGtxQUpQQUNaRzE4a0RqMXhTOUdD?= =?utf-8?B?YWRPOGNJTmNVRkpweWxjVjBkSmc4bGtSbzlZN3hKaVViMmdmbEJMTWgvR2d5?= =?utf-8?B?UkhPVk9uOVZ1YzNxM21TU2RLcmhCNEJhVVBPUVE5eVk3S2pwc1paT0pOQkpz?= =?utf-8?B?K0NWMHROZFMyQnkrODdVZDh2L2NZRnR3SGZKQ1dySmFmMTNVSGNySE5GMjMz?= =?utf-8?B?ckNQZG5DNjUzQkNCZGpZeGFyRFVtYXc5VHdpZzY2M05PM29JdU9ZRjQ3bzRa?= =?utf-8?B?MFNabWJTN2xhNFZBSzI3Y2I2bUtwVVJrYzhFaU8vbkt3emZHL3dzcWxLYmFO?= =?utf-8?B?TWJmeWl1bDBPaUhaYkVOeHZ5QkZrNC9aaUU1dWFTeXBBc0ZxMFMvTmxETnJC?= =?utf-8?B?d1dlNVc4VDU3cXdvYmhpYjdCRjVidGZvdnlldzZqajlpQXUwa1p0ZHFtaE5p?= =?utf-8?B?OExKRkRaUVVtcWhVWEpobDNnbnFPS2VqUzdxT296ODRBelJHQ0t6bDRZanZi?= =?utf-8?B?VkNMSUh5RXRJVGwwbVRzUUNnWnBVYlB0RHdORnN4aWcxRnp3cjAyeENkQ2Q0?= =?utf-8?B?ZnlKL2kxOEJPQzFJWUJ2UWlrNWpHNVVxT1N3aEwrck5zY3h4RzB0RnI5ZGRM?= =?utf-8?B?eStUclZ2OE8wM09oeEVLbGZuUzFqTE5ZdXRYK3hmMnAwQTJTczh3ZVlNeGMx?= =?utf-8?B?b2k4S1RpSXlLSEx1a2RRcFdkQXhKcjU4L0NKOW0yU2hOTTk0SHZnSFgvWldy?= =?utf-8?B?a3VXN005c1VGcUtrUEw2K2VoUFk4ZTRFOWg4VXpiUUI1SmF3bmZTU1FDWC8r?= =?utf-8?B?WE40MUJQUlNrTERmdW4vQW5QRDY4b1RoVm1oaU5Jd2N3OEM1V29OZm4weEVI?= =?utf-8?B?L1FjSXdaRFpQRlBvSFJGZktsaEV4ZXZ6UjJPODJGT2FxQkR5eTB3dmhkMHEv?= =?utf-8?B?cFo5R3ZPaXJQeG1BOWdhT3BqRzdodDc0QjVzYUFPMWV2RnROZkx6V3lXUElr?= =?utf-8?B?RThYZFRhTDdsZnR3YktPNnFEeXJRUDVPWmFLMko1Z1c2VmloTnRCNGFnR0ds?= =?utf-8?B?ZHNSL1RzeWMzL2ZLWUQvcXJuVjN4cTJvZndVb01ZbUFnUEs2QjdMTEtOenMz?= =?utf-8?B?Z0FkRlllMkZzNDV1RVZuQUNVYUgrQnNCdVpWRE1nZDloYUZmVzMyTU5zeWpv?= =?utf-8?B?aE5ndnozVi9uSkh5NkZzRTZiU01oUTBkdDgvZEFiV0Y0WEpweURhbmVTcEhU?= =?utf-8?B?bFIrMXgwR3RFTWxKa3orNHlueDVIYVpZSGo1ODM0cUlrbjc5LzNwaHA1SlZs?= =?utf-8?Q?1vS7J3ukNsLJZzdErk4qKpqTR?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: dcae417e-3d97-44e1-5438-08db4bdfaa1c X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 14:07:00.9647 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ckkZbgPKlkXzMsEU3TeRb/CQlxR7T1v5ugcE1ekrx0EWbRAyJ11HC2Bpe9VwnDb5+XIhSKL5myynxZoeVvjP+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8859 On 03/05/2023 12:25, Julien Grall wrote: > Hi Ayan, Hi Julien, > > On 28/04/2023 18:55, Ayan Kumar Halder wrote: >> dt_device_get_address() can accept uint64_t only for address and size. >> However, the address/size denotes physical addresses. Thus, they should >> be represented by 'paddr_t'. >> Consequently, we introduce a wrapper for dt_device_get_address() ie >> dt_device_get_paddr() which accepts address/size as paddr_t and inturn >> invokes dt_device_get_address() after converting address/size to >> uint64_t. >> >> The reason for introducing this is that in future 'paddr_t' may not >> always be 64-bit. Thus, we need an explicit wrapper to do the type >> conversion and return an error in case of truncation. >> >> With this, callers can now invoke dt_device_get_paddr(). >> >> Signed-off-by: Ayan Kumar Halder >> --- >> Changes from - >> >> v1 - 1. New patch. >> >> v2 - 1. Extracted part of "[XEN v2 05/11] xen/arm: Use paddr_t >> instead of u64 for address/size" >> into this patch. >> >> 2. dt_device_get_address() callers now invoke dt_device_get_paddr() >> instead. >> >> 3. Logged error in case of truncation. >> >> v3 - 1. Modified the truncation checks as "dt_addr != (paddr_t)dt_addr". >> 2. Some sanity fixes. >> >> v4 - 1. Some sanity fixes. >> 2. Preserved the declaration of dt_device_get_address() in >> xen/include/xen/device_tree.h. The reason being it is currently used by >> ns16550.c. This driver requires some more changes as pointed by Jan in >> https://lore.kernel.org/xen-devel/6196e90f-752e-e61a-45ce-37e46c22b812@suse.com/ >> >> which is to be addressed as a separate series. >> >> v5 - 1. Removed initialization of variables. >> 2. In dt_device_get_paddr(), added the check >> if ( !addr ) >>      return -EINVAL; >> >>   xen/arch/arm/domain_build.c                | 10 +++--- >>   xen/arch/arm/gic-v2.c                      | 10 +++--- >>   xen/arch/arm/gic-v3-its.c                  |  4 +-- >>   xen/arch/arm/gic-v3.c                      | 10 +++--- >>   xen/arch/arm/pci/pci-host-common.c         |  6 ++-- >>   xen/arch/arm/platforms/brcm-raspberry-pi.c |  2 +- >>   xen/arch/arm/platforms/brcm.c              |  6 ++-- >>   xen/arch/arm/platforms/exynos5.c           | 32 +++++++++--------- >>   xen/arch/arm/platforms/sunxi.c             |  2 +- >>   xen/arch/arm/platforms/xgene-storm.c       |  2 +- >>   xen/common/device_tree.c                   | 39 ++++++++++++++++++++++ >>   xen/drivers/char/cadence-uart.c            |  4 +-- >>   xen/drivers/char/exynos4210-uart.c         |  4 +-- >>   xen/drivers/char/imx-lpuart.c              |  4 +-- >>   xen/drivers/char/meson-uart.c              |  4 +-- >>   xen/drivers/char/mvebu-uart.c              |  4 +-- >>   xen/drivers/char/omap-uart.c               |  4 +-- >>   xen/drivers/char/pl011.c                   |  6 ++-- >>   xen/drivers/char/scif-uart.c               |  4 +-- > > What about the call in xen/drivers/char/ns16550.c? Refer to https://lore.kernel.org/xen-devel/6196e90f-752e-e61a-45ce-37e46c22b812@suse.com/ , Jan mentioned that this driver needs some prior cleanup. So, I decided to take it out and do it after the current series has been committed. See https://patchew.org/Xen/20230413173735.48387-1-ayan.kumar.halder@amd.com/ , Jan agreed to this. Is this ok with you ? - Ayan > >> xen/drivers/passthrough/arm/ipmmu-vmsa.c   |  8 ++--- >>   xen/drivers/passthrough/arm/smmu-v3.c      |  2 +- >>   xen/drivers/passthrough/arm/smmu.c         |  8 ++--- >>   xen/include/xen/device_tree.h              | 13 ++++++++ >>   23 files changed, 120 insertions(+), 68 deletions(-) > Cheers, > From xen-devel-bounces@lists.xenproject.org Wed May 03 14:39:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 14:39:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529249.823427 (Exim 4.92) (envelope-from ) id 1puDdO-0000Vp-Fs; Wed, 03 May 2023 14:39:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529249.823427; Wed, 03 May 2023 14:39:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puDdO-0000Vi-C3; Wed, 03 May 2023 14:39:10 +0000 Received: by outflank-mailman (input) for mailman id 529249; Wed, 03 May 2023 14:39:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puDdM-0000S9-61 for xen-devel@lists.xenproject.org; Wed, 03 May 2023 14:39:08 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3fdcec86-e9c0-11ed-8611-37d641c3527e; Wed, 03 May 2023 16:39:05 +0200 (CEST) Received: from mail-dm3nam02lp2044.outbound.protection.outlook.com (HELO NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.44]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 May 2023 10:39:01 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BLAPR03MB5540.namprd03.prod.outlook.com (2603:10b6:208:296::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Wed, 3 May 2023 14:38:59 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb%4]) with mapi id 15.20.6340.031; Wed, 3 May 2023 14:38:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3fdcec86-e9c0-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683124744; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=7nnX6IZ8Z2sVLN67lMjh6GA1f0VbnRwRssrhiTdYdV8=; b=dZg7uYWWyt2Oc62X6T3jC/X5OkWfdln9/sK/SnXtaP1Ur080td3HbezU 8bfsg5kYjEnbStD7rzj59QFA3HhhzJMqJ6DA93YbP6Fz/yCZ17JspUoZB h97j3Zm+QIhaxDGSR+EX6l1rcLUYaXlCXpOnL0kJs0wvoENdAdnrYR+zU 0=; X-IronPort-RemoteIP: 104.47.56.44 X-IronPort-MID: 108134434 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:jB6Si6BxslovwBVW/5Diw5YqxClBgxIJ4kV8jS/XYbTApDsm0j1Uz GNNXz+DOP+LMzf1eN9zadizo08H6pTUyIU2QQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFuspvlDs15K6p4G5A5QRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw3LknUFNcx 9cidT0yfz6krdu54LCDRbw57igjBJGD0II3nFhFlWucIdN9BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI++xrvwA/zyQouFTpGPPTdsaHWoN+mUGAq 3id12/4HgsbJJqUzj/tHneE37efxHinBNlOfFG+3qZPhVuYmEESNDQTWXu28d60l0CyWOsKf iT4/QJr98De7neDVcLhVhe1pHqFuB80WNdKFeA+rgaXxcL86gKUBGECQiRGLsIvsMs7RzsC3 VuOgt+vDjtq2JWeTneY96uIoCmpETgYK3cYYi0JRhdD5MPsyKk2jxnPR9IlF7Sng9ndEDT8h TuNqUAWl7gVyMIGyai/1VTGmC634IjESBYv4QfaVX7j6Rl2DKanaJah7Vzz5PNJPoGfCFKGu RAsmceE6/sVJYqQjyHLS+IIdJmr7fuYNDzXgXZ0AoIssT+q/haLcIxP4Tc4OEBzNcUscjvuf UOVsgRUjKK/J1OvZK5zJo60UMIjyPC6Ecy/DqyIKN1TfpJ2aQmLujl0YlKd1Hzsl05qlrwjP ZCccoCnCnNy5blb8Qdajtw1idcDrh3SD0uKLXwn53xLCYajWUM= IronPort-HdrOrdr: A9a23:oHQ0WKzeNJf0CXoN5o9oKrPw6L1zdoMgy1knxilNoHxuH/Bw9v re+cjzsCWftN9/Yh4dcLy7VpVoIkmsl6Kdg7NwAV7KZmCP1FdARLsI0WKI+UyCJ8SRzI9gPa cLSdkFNDXzZ2IK8PoTNmODYqodKNrsytHWuQ/HpU0dKT2D88tbnn9E4gDwKDwQeCB2QaAXOb C7/cR9qz+paR0sH7+G7ilsZZmkmzXT/qiWGCI7Ow== X-Talos-CUID: 9a23:lMuyV2yUe+BVnTAysBylBgUyRZB0QG/v502NLnCpJ0FDcbK1S2efrfY= X-Talos-MUID: =?us-ascii?q?9a23=3AfZpUQQxhj3AEIfhT2uPYrXxQGNuaqPyLDUYGz7g?= =?us-ascii?q?Hh+CBOQx9axCQkTq7QbZyfw=3D=3D?= X-IronPort-AV: E=Sophos;i="5.99,247,1677560400"; d="scan'208";a="108134434" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KFn9piLntcqBiRDvDM20tk2/H+fLr0BlyqpfCdVjWUaTUjRslxU+qN7Gj3RJ/VZaJ5VZjlsrm+cBgXItwfqr2HpXGkXv+AXYq1voLGD/6EeL6z1bVi8vbG2xMNY3wN043zYoeC1AxAR7hnkZCClub1aTtrOaqgaKBxz5d5Ely2zobuJsvXy7d7N5Cm2V0MmUmD9KsjsaSj27swaXmjYLsrM3BZxq6yPOMMrdbW9nI/wiLXEsarammGIawpMrgHM/aDHNZ8jZmemh/5GjEameLVRkWEAa4lUTfoqlOV1xnQ28QaqgRerowXtdui3nFJITc/YMybF+Gw98ll6StyOlyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7nnX6IZ8Z2sVLN67lMjh6GA1f0VbnRwRssrhiTdYdV8=; b=jPqSbxkcszKui9XpuUGIhSTwL7eEIkvGlBFz8jOveArwmBoM+FWoWFM5TuNn/o0BusAEtz8PXOMkm0OCeNQEHpcCYol+whc37vHcQWIb2pU9BR+QmcrE7z4lx42P05KGTbBd3W64x6mKEV5mxg3mxKPIT9V/fnk740G1SDYxdrZe7TGfohOibOKnIDOdWgeUOBN8GE/pz6gAml9cv1BPrw73IUgAzX1SNvzAzxk14H0aeE06qCxUaiE0uIkEAc5Z2ux42LWt+2WGdTyDMIQbXITLxqExDl6SGoLXp9mQyEfo/v25Q7c0aNoGQ5LrRhjTrLCzabKm9tZrNw6sv7eZ6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7nnX6IZ8Z2sVLN67lMjh6GA1f0VbnRwRssrhiTdYdV8=; b=gzYsfQbwmpw16HGqUOUv8XyT7do433Tg+SHcNIBIrlFPvByE+3HE2V1OOrk6orX5gGn4Vn9mblSxqkMasmR0VUsxi83t5mff0A+FDunaAch/dmQXY2vkjVEDY3oB+nGDERM325Cx+vNMP34WBnfIK48UEZJrESVXuj86++acYWo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Wed, 3 May 2023 15:38:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: andrew.cooper3@citrix.com Subject: dom0less vs xenstored setup race Was: xen | Failed pipeline for staging | 6a47ba2f Content-Language: en-GB To: Stefano Stabellini , alejandro.vallejo@cloud.com Cc: committers@xenproject.org, michal.orzel@amd.com, xen-devel@lists.xenproject.org, Julien Grall , Juergen Gross , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jan Beulich , =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= References: <644bfbc6939d8_2a49bbb403253f4@gitlab-sidekiq-catchall-v2-78885c497-qxnp2.mail> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P123CA0081.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:138::14) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BLAPR03MB5540:EE_ X-MS-Office365-Filtering-Correlation-Id: a3ab658a-78d1-4323-ae00-08db4be42136 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mrGujqyEYLe/9uiW/wNnNr9FkT5l5Ub4V2JEwdyZg+lgH0VhIS7s2GTZC/aqcMELFTazl03Sfr037TQtt6sfwyEUsE/jxCJk5++Jdd2x+mlhLEwbcc+bQq1TQEmiv6qK2bk/vUl6A4/dqw2VQYkESFqJtd2t3/f7LN1GYd5f3z70WNvAOmy/PhOd1RINLdGW5II/Rv0ybFNwPabCpbGIaQFKmti5XCZSqJHPjBz6oa16Idh7ov8zJQpF7TzE67R41uXrHerDyudz5ZoEfv/qjsb4NupivK9lyrZj6crkGHOM/rjuhUZcitXTVprmzNyITQ/bmdNPnNpvYHfs1pPtfak+MKhQQpzDPalRW2mQtsc15Ps+4IEKdzGhvmxX8Cqm1GBALeUytNL/KKOlKOaaeJDPax4Q5NUeEwz0gHQ84fMxJnJyjBTaWMWO2owbaRINK26u07ZKzYuyafn1iaX/nVkEds1vE0+QOxfhHsmutm3YzleFqEs0Oei74qU6eXlY1QW1eTsIPpEMlgSTusD3ozikCfTAeegk0MOQar2wkQZE2LvIgSu7oUMDLyYACzYv08Nn645nfhD4SX3choMVaHb+tSrWZmb9PZyahe6ocKyLeV47Y25s4IwZN4y4Prcl X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(39860400002)(346002)(136003)(366004)(451199021)(6666004)(6486002)(83380400001)(2906002)(6512007)(9686003)(26005)(6506007)(966005)(186003)(478600001)(31686004)(36756003)(2616005)(54906003)(41300700001)(66476007)(66556008)(66946007)(82960400001)(38100700002)(316002)(8676002)(8936002)(7416002)(86362001)(5660300002)(4326008)(31696002)(32563001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N2xaM1lId3RrcUpiSitnb2ptN0dZemJYRCtjTU9CWW05ZXh5N0wzNzNIUzBi?= =?utf-8?B?bjQ1aEd3Wm9zb1RoZ2NBOENnaEtSRWpmcHRocnhlVW02elhBcXRQclJkYXdW?= =?utf-8?B?VENzVUNNQVRrRDhuLzd6QSt0cDR4ZlRPWHZTbUJYZmJTTTNpOTdOUXE5T2Mw?= =?utf-8?B?dVc2NXNLVEt0Kzg3WFBLeEZRaEZNL3VYOU1BWXVhcHc5THBMV1AvM3dsU3h2?= =?utf-8?B?ZENmeWg2WVlUN2w4a3RjZ0tibDEzeDFiZnJ6b0NDaE5pRDZjNXFvVDF3T3FL?= =?utf-8?B?c25DM0ErakRuOGE0clR5OURYYXNwaVJQREVQK0J0SFlPemxXL0dDQnRsWitF?= =?utf-8?B?WVZma0NSNnBxU3hxSkdaQjVMbzZOWnJoaTI1Y3V4UVlIdnNpUktUdWQ5eFFS?= =?utf-8?B?VjNOY1N0RVJ3dnhQTVBaTDBybWJ4UlBoeitJdENLbjFrRmdaU2xhWm5iOHlC?= =?utf-8?B?MkJ6TC9NaEJscjRDSkR5eUNGbFVFWVhpRDIxZTR6SndVYU1qT3FMMmZyQXNE?= =?utf-8?B?NVg1bHk5UTJmUGNaclVpSTNMbU80OXNNdU9xbldoTzBSdU84WUxUSHlMNGVM?= =?utf-8?B?NVY5VWx6UDZralZHWG5pcG40WkJYSlVFWXJESHQxOTU4T3Z6Z2hIRDVLZFFD?= =?utf-8?B?MFF2N1VXNzF4WTY5Z2RtakVxYmd5K3ZNMElrRjVGQmlpVnBKdFcvOGtadmk3?= =?utf-8?B?ZDBBdVJQYUd4MDZ4Q0pNOWgvTWlsSXAyQWh1VXNLbmx2TVlISFJXTWhvNXB3?= =?utf-8?B?UzI5WDVoMGtQNjhLcVU2aW5uMlhUSmpWaWZLT1h4d0h5V3VGMk1vM3E1cnc1?= =?utf-8?B?RElnMHptOHVIZktnN0g5cE93elM3bjRNdUtsWHdjbDBmeEJLWkNVazUwQk1V?= =?utf-8?B?YkNyU1NTQ2E2MGd2bE00a3o0dlMvT3RWVVdwZ3RxcVFaVW4wL0RmZFlOVGxP?= =?utf-8?B?SHk4cE1tWFE0clRsTitNcGc0UVNpZjBUMzh3eGptZnJxbjVORjhXT3pSNm41?= =?utf-8?B?NnBTYkU1eVVHWVU3WmpsQXlFaHNDUEpKeXd6Q1RDcXFXSkRMKzl6dTZBcHc5?= =?utf-8?B?L3YvQUZqQ01xbncxZzhvbzNwR3M4SUt4WTRwendENGN6RGFsVnFiaUdJSU1j?= =?utf-8?B?SStUZCtlRHBHMG85Q1dDeFl5eTY4bHI5bG8xVWQ0SFVVb0hZYXEwUWJtbWV0?= =?utf-8?B?cW9qUTROejVUUzN3NjNTeVNnSTNnb3VqNFZpVlA4MlY2Wm8zSktjZjhlcFk2?= =?utf-8?B?b0M3d1FFSzhHM2drNDJoWlZqeXJDa1JLSUxJL0VBcVBUN09PZENJS2dMdmJM?= =?utf-8?B?QU9STUpwaS9DYXIrbHNMalljbzJSS01OL1dGS05EZkVlV2h1cG1kU1RIOTQr?= =?utf-8?B?djZENnRqQkt5OFI3Sm5ZU0ZwRFBkcUQ4YTAxblZFcGFxbWM5MU9ZRndjZmxj?= =?utf-8?B?V2J6VEF2SDJ6VUtxRFFaMVR6N3hXTEV2VzVLbGMxZW1TU2g4Q1N2K3pMdVJ5?= =?utf-8?B?R1FFSGxoUFZQWFFSbyszVElHT0RzN3NlaGxIcEg4aGN3U1BSaFl0dHU3Q08x?= =?utf-8?B?c3I0aXFCZXdSK01heWxDdTZWa2doSGVhT1FhRHZVMWkxOVBCV1dDTktSRUFx?= =?utf-8?B?U3pkWnByQXVyNlRwQU1xQ0V3blFvMWx2dTNZUTVYVFRMQXpxb3N1NThGeC9k?= =?utf-8?B?eTRyS0NYTy9kMGdrVXJ1M0NNN0xtMVYxanZTWW54bFpXbTEvWm8vemJuamdM?= =?utf-8?B?cTNyZ3VhblRqTEdqaUdkVjdkZW1hTlFZdVhlYWVMOExEQ29HNUtvRUdKVGMz?= =?utf-8?B?L0JQK1ZEYy9PUjVHdWZ4Q3pXMFoyczhYMTltYTFtQWN4czFTbkJsNjVCWkFq?= =?utf-8?B?VGJCdmxsaU5RaEdwZkpFMERnc2pqdTNqTXRhSGx3aEFCVEtSOFd6cXF4RXZD?= =?utf-8?B?ZEZSNU5hdGtoYlNYb2V3UGU3TG9QaDRibDZ5ekFmaVBIUWN5clRrenVXTXQ2?= =?utf-8?B?YU40WERsTEpxSzBwQTFCVWF0a201RUduK3hTcGdMK3ZLMlFXRkc3NDVIZFRL?= =?utf-8?B?Qm5meHp5U1Y1U0FCN2lMY2tabmN1Z0dzT0RxUFZ4SFQyVk9kN2NMTGtiWlI4?= =?utf-8?B?SnczamI2ZTAyY0pKQUlrTDRjR3Bsa0ZqYWdENHpkbEhFdDBmbUFhekRYZUlV?= =?utf-8?B?dWc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?QXNSalNvSHRYNVhUSnpyd1QrT2M1emlKOXliK2p1UW9tQjNWQXlNMHY3eUJk?= =?utf-8?B?MVdlWjdRQ2hUcTc0OEJvMTk2eEdvRksvTGNGTHhyc3hHZGg0eWo5VURlQTdU?= =?utf-8?B?Umd1UzZGc0F0bVNzUUtYdCtqYy8xZ3lpN1ZlcTQ1d0NRd0todXhuNUxXa1ZL?= =?utf-8?B?V3BkVExablRiQzd2QUJsSWxlTFdNcWh3UkJ2WXllRGlLbkxya3I4amRNMyt1?= =?utf-8?B?ZHpUaWE4THAvR3MrOURRWnNOSU01WGhIZXMxNFlqR1dXeEM2dTVyMnI1bVc3?= =?utf-8?B?VTJmQ3BPQmk4dHFaOGgrTDVjYkIzenRzeFQ3NXZOcmVSekdTa1NKT2hkMERR?= =?utf-8?B?cFVyWTcyR0VHak9PZ3lqQXZPTXVVMGtTV3gzTWh2bWptS0JJaTI4d1dncVJV?= =?utf-8?B?aGg2WGRONGlJS1dKbGZOckJSOXNaQjM4Sk5Ocm55VlYzQzI2NDU1blV3R3Zr?= =?utf-8?B?aUdZNTRlVkptN1VqVjNXdjZ1ZGdFU09tdU9xZEJERWhDZXlhZTJOSjlibGRq?= =?utf-8?B?dnh2SDJsZDUvTDEwKzdjT3ZCZWpxMk5Qd0UrK1dvL0tLUDVvWU5iM2xNUTg2?= =?utf-8?B?UXNqN3k3UFFSaGxDQnRPa3Z2andsdkN1eExhcUF0MGlCS1ZFTkxKRE43RThu?= =?utf-8?B?UktkazhzQzN6a0t1RkJOSmQ2ZGgvWlovZVBhME5WUHI3dys2N1h4TENKMDBS?= =?utf-8?B?RHlqUnNSL1VwbTBJSjhwc2QwRkMzSnZYSUlLN09rMXpBL0xFTUgwaGc2R3d0?= =?utf-8?B?WTduWXhFbjJaZXpScnVCd0RqYzNBTEtRaG1qNDNUdVMvR3VzNVZIMTdCVmxN?= =?utf-8?B?Wk1kSkZsRHFqOVF2RlRscTJMSWM3YlU0enlNVllKZ2pjcmc5TVgzQjFUWGM2?= =?utf-8?B?aFZRQVgvb2Q5b0xMVFhhUGJCNS91b3VTdGg2VXBYRE0ySndsa1JTNnNNVjFP?= =?utf-8?B?Wmg5cm9WTElrNnNMVW9lVWdxOVJ1eHBZNml3bzJjOENJUFRJam0vbWJQN2pI?= =?utf-8?B?SmZGUkt3UStrckxNK3F5ZFI0MVRlZWpkTmY4VEdxVDBCRXVkejBhRkVrQ0xZ?= =?utf-8?B?UlJQNlE4ajlQZ1ZWR0xoMlF3VmllT3pVSFlVZUo0Z3c2QWtJWmN1eXBGYUhU?= =?utf-8?B?WGZvYTc5OUVHMGo0TDFHNU5UQW5hQmtPM2RVRm9ZZEZZNHZocDJkdmwyRlFP?= =?utf-8?B?VHBpQ0NnN01YakdMKy9tT1REeXV1V3VJcTluSjJxSm9waUphQmM2OGd3dlhr?= =?utf-8?Q?fJBimSaZlby3L6T?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: a3ab658a-78d1-4323-ae00-08db4be42136 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 14:38:58.8377 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hLQMm52kx4Mj1zuwWhofrXQ4WgiMJxOneYJkNfWPOAH5xtYsc/NTsSrHyJnIYeSHIhyYtEizNdUmwYaa03JuMUQH2Y3LakW9UoD8xg0qDG0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5540 Hello, After what seems like an unreasonable amount of debugging, we've tracked down exactly what is going wrong here. https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/4219721944 Of note is the smoke.serial log around: io: IN 0xffff90fec250 d0 20230503 14:20:42 INTRODUCE (1 233473 1 ) obj: CREATE connection 0xffff90fff1f0 *** d1 CONN RESET req_cons 00000000, req_prod 0000003a rsp_cons 00000000, rsp_prod 00000000 io: OUT 0xffff9105cef0 d0 20230503 14:20:42 WATCH_EVENT (@introduceDomain domlist ) XS_INTRODUCE (in C xenstored at least, not checked O yet) always clobbers the ring pointers.  The added pressure on dom0 that the xensconsoled adds with it's 4M hypercall bounce buffer occasionally defers xenstored long enough that the XS_INTRODUCE clobbers the first message that dom1 wrote into the ring. The other behaviour seen was xenstored observing a header looking like this: *** d1 HDR { ty 0x746e6f63, rqid 0x2f6c6f72, txid 0x74616c70, len 0x6d726f66 } which was rejected as being too long.  That's "control/platform" in ASCII, so the XS_INTRODUCE intersected dom1 between writing the header and writing the payload. Anyway, it is buggy for XS_INTRODUCE to be called on a live an unsuspecting connection.  It is ultimately init-dom0less's fault for telling dom1 it's good to go before having waited for XS_INTRODUCE to complete. I am going to start by correcting the documentation to make these details clear, and then figure out what is the best set of steps to unbreak this. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed May 03 14:39:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 14:39:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529246.823417 (Exim 4.92) (envelope-from ) id 1puDdL-0000G9-5a; Wed, 03 May 2023 14:39:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529246.823417; Wed, 03 May 2023 14:39:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puDdL-0000G2-2T; Wed, 03 May 2023 14:39:07 +0000 Received: by outflank-mailman (input) for mailman id 529246; Wed, 03 May 2023 14:39:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puDdJ-0000Fq-BU; Wed, 03 May 2023 14:39:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puDdJ-0004zJ-2R; Wed, 03 May 2023 14:39:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puDdI-00036r-M6; Wed, 03 May 2023 14:39:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1puDdI-0005Vl-Li; Wed, 03 May 2023 14:39:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=DBU34PiOuxKjr3RLyM+LZyoVHSP6YFjxDOhsP2Lu5f0=; b=LFusJ+rJskgpXg0xbqJCIq+SM1 qaSTv0v3O5p+p4BHtGi+9zunSR1t2bOSlojkcHWseBg5fYYXWSM5dk9caVmK5Ps7Ta2BxulN3izpT nmoXOZkLTu6eZMGI/c7Med9ptgiuMpAPWkWyM63CF1Er7OgUgPapsN1rSiewQcxQ0l94=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 180517: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=0956aa2219745a198bb6a0a99e2108a3c09b280e X-Osstest-Versions-That: xen=b033eddc9779109c06a26936321d27a2ef4e088b From: osstest service owner Date: Wed, 03 May 2023 14:39:04 +0000 flight 180517 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/180517/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 0956aa2219745a198bb6a0a99e2108a3c09b280e baseline version: xen b033eddc9779109c06a26936321d27a2ef4e088b Last test of basis 180505 2023-05-02 11:00:27 Z 1 days Testing same since 180517 2023-05-03 12:01:56 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Henry Wang # CHANGELOG Jan Beulich Roger Pau Monné Viresh Kumar jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git b033eddc97..0956aa2219 0956aa2219745a198bb6a0a99e2108a3c09b280e -> smoke From xen-devel-bounces@lists.xenproject.org Wed May 03 14:39:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 14:39:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529250.823437 (Exim 4.92) (envelope-from ) id 1puDdb-0000rr-TH; Wed, 03 May 2023 14:39:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529250.823437; Wed, 03 May 2023 14:39:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puDdb-0000rk-Q0; Wed, 03 May 2023 14:39:23 +0000 Received: by outflank-mailman (input) for mailman id 529250; Wed, 03 May 2023 14:39:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puDda-0000qr-Sv for xen-devel@lists.xenproject.org; Wed, 03 May 2023 14:39:23 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4a9f4469-e9c0-11ed-b225-6b7b168915f2; Wed, 03 May 2023 16:39:21 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 04A0722906; Wed, 3 May 2023 14:39:21 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D0D701331F; Wed, 3 May 2023 14:39:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id PbOVMRhyUmR8SgAAMHmgww (envelope-from ); Wed, 03 May 2023 14:39:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a9f4469-e9c0-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683124761; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QaN379kgUJzfI8bNyZlqD4wJZ+lpSc8tdJtpKFXSYtQ=; b=M7Lg376jX5leWitBzM0BNDu885VXV9anawqCnStKarkmtmrRVE6wGtXTfNo+AXaYcsRvDq 5Omc/hsc09koV3p1mN7pngc5WXaSv6N64FPLntjmkt3IiDjt+/I0O6jRkZr/j/hwBEPP2g NeM+8K1+6SRFL3uLWZ92PTl7SiYEZi4= Message-ID: Date: Wed, 3 May 2023 16:39:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v4 12/13] tools/xenstore: use generic accounting for remaining quotas Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230405070349.25293-1-jgross@suse.com> <20230405070349.25293-13-jgross@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------7wLbm2MU50tdk2L67QW1JM8K" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------7wLbm2MU50tdk2L67QW1JM8K Content-Type: multipart/mixed; boundary="------------gxSoSjJcQC64XgM4FYX2wIV8"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: Subject: Re: [PATCH v4 12/13] tools/xenstore: use generic accounting for remaining quotas References: <20230405070349.25293-1-jgross@suse.com> <20230405070349.25293-13-jgross@suse.com> In-Reply-To: --------------gxSoSjJcQC64XgM4FYX2wIV8 Content-Type: multipart/mixed; boundary="------------7qAD10QsO7GsKd0Nap2aWKUZ" --------------7qAD10QsO7GsKd0Nap2aWKUZ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMDUuMjMgMTI6MTgsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gDQo+IA0KPiBPbiAw NS8wNC8yMDIzIDA4OjAzLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gVGhlIG1heHJlcXVl c3RzLCBub2RlIHNpemUsIG51bWJlciBvZiBub2RlIHBlcm1pc3Npb25zLCBhbmQgcGF0aCBs ZW5ndGgNCj4+IHF1b3RhIGFyZSBhIGxpdHRsZSBiaXQgc3BlY2lhbCwgYXMgdGhleSBhcmUg ZWl0aGVyIGFjdGl2ZSBpbg0KPj4gdHJhbnNhY3Rpb25zIG9ubHkgKG1heHJlcXVlc3RzKSwg b3IgdGhleSBhcmUganVzdCBwZXIgaXRlbSBpbnN0ZWFkIG9mDQo+PiBjb3VudCB2YWx1ZXMu IE5ldmVydGhlbGVzcyBiZWluZyBhYmxlIHRvIGtub3cgdGhlIG1heGltdW0gbnVtYmVyIG9m DQo+PiB0aG9zZSBxdW90YSByZWxhdGVkIHZhbHVlcyBwZXIgZG9tYWluIHdvdWxkIGJlIGJl bmVmaWNpYWwsIHNvIGFkZCB0aGVtDQo+PiB0byB0aGUgZ2VuZXJpYyBhY2NvdW50aW5nLg0K Pj4NCj4+IFRoZSBwZXIgZG9tYWluIHZhbHVlIHdpbGwgbmV2ZXIgc2hvdyBjdXJyZW50IG51 bWJlcnMgb3RoZXIgdGhhbiB6ZXJvLA0KPj4gYnV0IHRoZSBtYXhpbXVtIG51bWJlciBzZWVu IGNhbiBiZSBnYXRoZXJlZCB0aGUgc2FtZSB3YXkgYXMgdGhlIG51bWJlcg0KPj4gb2Ygbm9k ZXMgZHVyaW5nIGEgdHJhbnNhY3Rpb24uDQo+Pg0KPj4gVG8gYmUgYWJsZSB0byB1c2UgdGhl IGNvbnN0IHF1YWxpZmllciBmb3IgYSBuZXcgZnVuY3Rpb24gc3dpdGNoDQo+PiBkb21haW5f aXNfdW5wcml2aWxlZ2VkKCkgdG8gdGFrZSBhIGNvbnN0IHBvaW50ZXIsIHRvby4NCj4+DQo+ PiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+PiAt LS0NCj4+IMKgIHRvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmPCoMKgwqDCoMKgwqDC oCB8IDE0ICsrKystLS0tLQ0KPj4gwqAgdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUu aMKgwqDCoMKgwqDCoMKgIHzCoCAyICstDQo+PiDCoCB0b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfZG9tYWluLmPCoMKgwqDCoMKgIHwgMzkgKysrKysrKysrKysrKysrKysrKystLS0tLS0N Cj4+IMKgIHRvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uaMKgwqDCoMKgwqAgfMKg IDYgKysrKw0KPj4gwqAgdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMg fMKgIDQgKy0tDQo+PiDCoCB0b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfd2F0Y2guY8KgwqDC oMKgwqDCoCB8wqAgMiArLQ0KPj4gwqAgNiBmaWxlcyBjaGFuZ2VkLCA0OCBpbnNlcnRpb25z KCspLCAxOSBkZWxldGlvbnMoLSkNCj4+DQo+PiBkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMN Cj4+IGluZGV4IDg4YzU2OWI3ZDUuLjY1ZGYyODY2YmYgMTAwNjQ0DQo+PiAtLS0gYS90b29s cy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jDQo+PiArKysgYi90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfY29yZS5jDQo+PiBAQCAtNzk5LDggKzc5OSw4IEBAIGludCB3cml0ZV9ub2Rl X3JhdyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgVERCX0RBVEEgKmtleSwgDQo+PiBzdHJ1 Y3Qgbm9kZSAqbm9kZSwNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCArIG5vZGUtPnBlcm1zLm51 bSAqIHNpemVvZihub2RlLT5wZXJtcy5wWzBdKQ0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgICsg bm9kZS0+ZGF0YWxlbiArIG5vZGUtPmNoaWxkbGVuOw0KPj4gLcKgwqDCoCBpZiAoIW5vX3F1 b3RhX2NoZWNrICYmIGRvbWFpbl9pc191bnByaXZpbGVnZWQoY29ubikgJiYNCj4+IC3CoMKg wqDCoMKgwqDCoCBkYXRhLmRzaXplID49IHF1b3RhX21heF9lbnRyeV9zaXplKSB7DQo+PiAr wqDCoMKgIGlmIChkb21haW5fbWF4X2Noayhjb25uLCBBQ0NfTk9ERVNaLCBkYXRhLmRzaXpl LCBxdW90YV9tYXhfZW50cnlfc2l6ZSkNCj4+ICvCoMKgwqDCoMKgwqDCoCAmJiAhbm9fcXVv dGFfY2hlY2spIHsNCj4gDQo+IEl0IGZlZWxzIGEgYml0IG9kZCB0byBtb3ZlIHRoZSAhbm9f cXVvdGFfY2hlY2sgcmlnaHQgYWZ0ZXIgdGhlIGFjdHVhbCBjaGVjay4gQnV0IA0KPiBBRkFJ Q1QsIHlvdSBhcmUgZG9pbmcgaXQgYmVjYXVzZSBkb21haW5fbWF4X2NoaygpIHdpbGwgYWxz byB1cGRhdGUgdGhlIG1heGltdW0gDQo+IHZhbHVlIHNlZW4gYnkgdGhlIGN1cnJlbnQgcXVv dGEuDQoNCkNvcnJlY3QuDQoNCj4gDQo+IElzIHRoYXQgY29ycmVjdD8gSWYgc28sIGl0IHdv dWxkIGJlIHdvcnRoIG1lbnRpb25pbmcgaXQgaW4gYSBjb21tZW50Lg0KDQpPa2F5Lg0KDQo+ IA0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIGVycm5vID0gRU5PU1BDOw0KPj4gwqDCoMKgwqDC oMKgwqDCoMKgIHJldHVybiBlcnJubzsNCj4+IMKgwqDCoMKgwqAgfQ0KPj4gQEAgLTExNjgs NyArMTE2OCw3IEBAIHN0YXRpYyBib29sIHZhbGlkX2NoYXJzKGNvbnN0IGNoYXIgKm5vZGUp DQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAiMDEyMzQ1Njc4OS0vX0Ai KSA9PSBzdHJsZW4obm9kZSkpOw0KPj4gwqAgfQ0KPj4gLWJvb2wgaXNfdmFsaWRfbm9kZW5h bWUoY29uc3QgY2hhciAqbm9kZSkNCj4+ICtib29sIGlzX3ZhbGlkX25vZGVuYW1lKGNvbnN0 IHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCBjaGFyICpub2RlKQ0KPj4gwqAgew0K Pj4gwqDCoMKgwqDCoCBpbnQgbG9jYWxfb2ZmID0gMDsNCj4+IMKgwqDCoMKgwqAgdW5zaWdu ZWQgaW50IGRvbWlkOw0KPj4gQEAgLTExODgsNyArMTE4OCw4IEBAIGJvb2wgaXNfdmFsaWRf bm9kZW5hbWUoY29uc3QgY2hhciAqbm9kZSkNCj4+IMKgwqDCoMKgwqAgaWYgKHNzY2FuZihu b2RlLCAiL2xvY2FsL2RvbWFpbi8lNXUvJW4iLCAmZG9taWQsICZsb2NhbF9vZmYpICE9IDEp DQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgbG9jYWxfb2ZmID0gMDsNCj4+IC3CoMKgwqAgaWYg KHN0cmxlbihub2RlKSA+IGxvY2FsX29mZiArIHF1b3RhX21heF9wYXRoX2xlbikNCj4+ICvC oMKgwqAgaWYgKGRvbWFpbl9tYXhfY2hrKGNvbm4sIEFDQ19QQVRITEVOLCBzdHJsZW4obm9k ZSkgLSBsb2NhbF9vZmYsDQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBxdW90 YV9tYXhfcGF0aF9sZW4pKQ0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiBmYWxzZTsN Cj4+IMKgwqDCoMKgwqAgcmV0dXJuIHZhbGlkX2NoYXJzKG5vZGUpOw0KPj4gQEAgLTEyNTAs NyArMTI1MSw3IEBAIHN0YXRpYyBzdHJ1Y3Qgbm9kZSAqZ2V0X25vZGVfY2Fub25pY2FsaXpl ZChzdHJ1Y3QgDQo+PiBjb25uZWN0aW9uICpjb25uLA0KPj4gwqDCoMKgwqDCoCAqY2Fub25p Y2FsX25hbWUgPSBjYW5vbmljYWxpemUoY29ubiwgY3R4LCBuYW1lKTsNCj4+IMKgwqDCoMKg wqAgaWYgKCEqY2Fub25pY2FsX25hbWUpDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJu IE5VTEw7DQo+PiAtwqDCoMKgIGlmICghaXNfdmFsaWRfbm9kZW5hbWUoKmNhbm9uaWNhbF9u YW1lKSkgew0KPj4gK8KgwqDCoCBpZiAoIWlzX3ZhbGlkX25vZGVuYW1lKGNvbm4sICpjYW5v bmljYWxfbmFtZSkpIHsNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCBlcnJubyA9IEVJTlZBTDsN Cj4+IMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gTlVMTDsNCj4+IMKgwqDCoMKgwqAgfQ0K Pj4gQEAgLTE3NzUsOCArMTc3Niw3IEBAIHN0YXRpYyBpbnQgZG9fc2V0X3Blcm1zKGNvbnN0 IHZvaWQgKmN0eCwgc3RydWN0IA0KPj4gY29ubmVjdGlvbiAqY29ubiwNCj4+IMKgwqDCoMKg wqDCoMKgwqDCoCByZXR1cm4gRUlOVkFMOw0KPj4gwqDCoMKgwqDCoCBwZXJtcy5udW0tLTsN Cj4+IC3CoMKgwqAgaWYgKGRvbWFpbl9pc191bnByaXZpbGVnZWQoY29ubikgJiYNCj4+IC3C oMKgwqDCoMKgwqDCoCBwZXJtcy5udW0gPiBxdW90YV9uYl9wZXJtc19wZXJfbm9kZSkNCj4+ ICvCoMKgwqAgaWYgKGRvbWFpbl9tYXhfY2hrKGNvbm4sIEFDQ19OUEVSTSwgcGVybXMubnVt LCBxdW90YV9uYl9wZXJtc19wZXJfbm9kZSkpDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0 dXJuIEVOT1NQQzsNCj4+IMKgwqDCoMKgwqAgcGVybXN0ciA9IGluLT5idWZmZXIgKyBzdHJs ZW4oaW4tPmJ1ZmZlcikgKyAxOw0KPj4gZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hl bnN0b3JlZF9jb3JlLmggYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oDQo+PiBp bmRleCAzNTY0ZDg1ZDdkLi45MzM5ODIwMTU2IDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMveGVu c3RvcmUveGVuc3RvcmVkX2NvcmUuaA0KPj4gKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2NvcmUuaA0KPj4gQEAgLTI1OCw3ICsyNTgsNyBAQCB2b2lkIGNoZWNrX3N0b3JlKHZv aWQpOw0KPj4gwqAgdm9pZCBjb3JydXB0KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25z dCBjaGFyICpmbXQsIC4uLik7DQo+PiDCoCAvKiBJcyB0aGlzIGEgdmFsaWQgbm9kZSBuYW1l PyAqLw0KPj4gLWJvb2wgaXNfdmFsaWRfbm9kZW5hbWUoY29uc3QgY2hhciAqbm9kZSk7DQo+ PiArYm9vbCBpc192YWxpZF9ub2RlbmFtZShjb25zdCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29u biwgY29uc3QgY2hhciAqbm9kZSk7DQo+PiDCoCAvKiBHZXQgbmFtZSBvZiBwYXJlbnQgbm9k ZS4gKi8NCj4+IMKgIGNoYXIgKmdldF9wYXJlbnQoY29uc3Qgdm9pZCAqY3R4LCBjb25zdCBj aGFyICpub2RlKTsNCj4+IGRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf ZG9tYWluLmMgDQo+PiBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uYw0KPj4g aW5kZXggZDIxZjMxZGE5Mi4uNDllMmM1YzgyYSAxMDA2NDQNCj4+IC0tLSBhL3Rvb2xzL3hl bnN0b3JlL3hlbnN0b3JlZF9kb21haW4uYw0KPj4gKysrIGIvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2RvbWFpbi5jDQo+PiBAQCAtNDMzLDcgKzQzMyw3IEBAIGludCBkb21haW5fZ2V0 X3F1b3RhKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gDQo+PiAqY29ubiwN Cj4+IMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gRU5PTUVNOw0KPj4gwqAgI2RlZmluZSBl bnQodCwgZSkgXA0KPj4gLcKgwqDCoCByZXNwID0gdGFsbG9jX2FzcHJpbnRmX2FwcGVuZChy ZXNwLCAiJS0xNnM6ICU4dSAobWF4OiAlOHVcbiIsICN0LCBcDQo+PiArwqDCoMKgIHJlc3Ag PSB0YWxsb2NfYXNwcmludGZfYXBwZW5kKHJlc3AsICIlLTE3czogJTh1IChtYXg6ICU4dVxu IiwgI3QsIFwNCj4gDQo+IFRoaXMgY2hhbmdlcyBmZWVscyBhIGJpdCB1bnJlbGF0ZWQuIENh biB5b3UgbWVudGlvbiB3aHkgdGhpcyBpcyBuZWNlc3NhcnkgaW4gdGhlIA0KPiBjb21taXQg bWVzc2FnZT8NCg0KInRyYW5zYWN0aW9uLW5vZGVzIiBoYXMgMTcgY2hhcmFjdGVycy4gOi0p DQoNCj4gDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIGQtPmFjY1tlXS52YWwsIGQtPmFjY1tlXS5tYXgpOyBcDQo+PiDCoMKgwqDCoMKgIGlm ICghcmVzcCkgcmV0dXJuIEVOT01FTQ0KPj4gQEAgLTQ0Miw2ICs0NDIsNyBAQCBpbnQgZG9t YWluX2dldF9xdW90YShjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uIA0KPj4g KmNvbm4sDQo+PiDCoMKgwqDCoMKgIGVudCh0cmFuc2FjdGlvbnMsIEFDQ19UUkFOUyk7DQo+ PiDCoMKgwqDCoMKgIGVudChvdXRzdGFuZGluZywgQUNDX09VVFNUKTsNCj4+IMKgwqDCoMKg wqAgZW50KG1lbW9yeSwgQUNDX01FTSk7DQo+PiArwqDCoMKgIGVudCh0cmFuc2FjdGlvbi1u b2RlcywgQUNDX1RSQU5TTk9ERVMpOw0KPiANCj4gWW91IHNlZW0gdG8gY29udmVydCBtdWx0 aXBsZSBxdW90YXMgYnV0IG9ubHkgcHJpbnQgb25lLiBXaHk/DQoNCkFoLCBzb3JyeSBmb3Ig b21pdHRpbmcgdGhlIG90aGVyIG9uZXMuIFRoZSBmb2xsb3dpbmcgcGF0Y2ggaXMgYWRkaW5n DQp0aGVtIGFnYWluLCBzbyBJIGRpZG4ndCByZWNvZ25pemUgdGhlbSBtaXNzaW5nLg0KDQo+ IA0KPj4gwqAgI3VuZGVmIGVudA0KPj4gQEAgLTQ1OSw3ICs0NjAsNyBAQCBpbnQgZG9tYWlu X21heF9nbG9iYWxfYWNjKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IA0KPj4gY29ubmVjdGlv biAqY29ubikNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gRU5PTUVNOw0KPj4gwqAg I2RlZmluZSBlbnQodCwgZSkgXA0KPj4gLcKgwqDCoCByZXNwID0gdGFsbG9jX2FzcHJpbnRm X2FwcGVuZChyZXNwLCAiJS0xNnM6ICU4dVxuIiwgI3QswqDCoCBcDQo+PiArwqDCoMKgIHJl c3AgPSB0YWxsb2NfYXNwcmludGZfYXBwZW5kKHJlc3AsICIlLTE3czogJTh1XG4iLCAjdCzC oMKgIFwNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgYWNjX2dsb2JhbF9tYXhbZV0pO8KgwqDCoMKgwqDCoMKgwqAgXA0KPiANCj4gRGl0dG8u DQo+IA0KPj4gwqDCoMKgwqDCoCBpZiAoIXJlc3ApIHJldHVybiBFTk9NRU0NCj4+IEBAIC00 NjgsNiArNDY5LDcgQEAgaW50IGRvbWFpbl9tYXhfZ2xvYmFsX2FjYyhjb25zdCB2b2lkICpj dHgsIHN0cnVjdCANCj4+IGNvbm5lY3Rpb24gKmNvbm4pDQo+PiDCoMKgwqDCoMKgIGVudCh0 cmFuc2FjdGlvbnMsIEFDQ19UUkFOUyk7DQo+PiDCoMKgwqDCoMKgIGVudChvdXRzdGFuZGlu ZywgQUNDX09VVFNUKTsNCj4+IMKgwqDCoMKgwqAgZW50KG1lbW9yeSwgQUNDX01FTSk7DQo+ PiArwqDCoMKgIGVudCh0cmFuc2FjdGlvbi1ub2RlcywgQUNDX1RSQU5TTk9ERVMpOw0KPj4g wqAgI3VuZGVmIGVudA0KPj4gQEAgLTEwODEsMTIgKzEwODMsMjIgQEAgaW50IGRvbWFpbl9h ZGp1c3Rfbm9kZV9wZXJtcyhzdHJ1Y3Qgbm9kZSAqbm9kZSkNCj4+IMKgwqDCoMKgwqAgcmV0 dXJuIDA7DQo+PiDCoCB9DQo+PiArc3RhdGljIHZvaWQgZG9tYWluX2FjY192YWxpZF9tYXgo c3RydWN0IGRvbWFpbiAqZCwgZW51bSBhY2NpdGVtIHdoYXQsDQo+PiArwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgdW5zaWduZWQgaW50IHZhbCkNCj4+ICt7DQo+PiArwqDC oMKgIGFzc2VydCh3aGF0IDwgQVJSQVlfU0laRShkLT5hY2MpKTsNCj4+ICvCoMKgwqAgYXNz ZXJ0KHdoYXQgPCBBUlJBWV9TSVpFKGFjY19nbG9iYWxfbWF4KSk7DQo+PiArDQo+PiArwqDC oMKgIGlmICh2YWwgPiBkLT5hY2Nbd2hhdF0ubWF4KQ0KPj4gK8KgwqDCoMKgwqDCoMKgIGQt PmFjY1t3aGF0XS5tYXggPSB2YWw7DQo+PiArwqDCoMKgIGlmICh2YWwgPiBhY2NfZ2xvYmFs X21heFt3aGF0XSAmJiBkb21pZF9pc191bnByaXZpbGVnZWQoZC0+ZG9taWQpKQ0KPj4gK8Kg wqDCoMKgwqDCoMKgIGFjY19nbG9iYWxfbWF4W3doYXRdID0gdmFsOw0KPj4gK30NCj4+ICsN Cj4+IMKgIHN0YXRpYyBpbnQgZG9tYWluX2FjY19hZGRfdmFsaWQoc3RydWN0IGRvbWFpbiAq ZCwgZW51bSBhY2NpdGVtIHdoYXQsIGludCBhZGQpDQo+PiDCoCB7DQo+PiDCoMKgwqDCoMKg IHVuc2lnbmVkIGludCB2YWw7DQo+PiAtwqDCoMKgIGFzc2VydCh3aGF0IDwgQVJSQVlfU0la RShkLT5hY2MpKTsNCj4gDQo+IEkgdGhpbmsgdGhpcyBhc3NlcnQgc2hvdWxkIGJlIGtlcHQg YmVjYXVzZS4uLg0KPiANCj4+IC0NCj4+IMKgwqDCoMKgwqAgaWYgKChhZGQgPCAwICYmIC1h ZGQgPiBkLT5hY2Nbd2hhdF0udmFsKSB8fA0KPiANCj4gLi4uIG9mIHRoaXMgY2hlY2suIE90 aGVyd2lzZSwgeW91IHdvdWxkIGNoZWNrIHRoYXQgJ3doYXQnIGlzIHdpdGhpbiB0aGUgYm91 bmRzIA0KPiBhZnRlciB0aGUgdXNlLg0KDQpPa2F5Lg0KDQoNCkp1ZXJnZW4NCg== --------------7qAD10QsO7GsKd0Nap2aWKUZ Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------7qAD10QsO7GsKd0Nap2aWKUZ-- --------------gxSoSjJcQC64XgM4FYX2wIV8-- --------------7wLbm2MU50tdk2L67QW1JM8K Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmRSchgFAwAAAAAACgkQsN6d1ii/Ey+N MAf/fuTLpwqPZRUoqYFhGYUhzjzobF/vUFRpp0RvdYISKu0ybq1zUoELfSW9ODeqamhjCBJZPXeD 3oEUGjHjJ+jmWOSFZCBfSFffo3Rp4mx7+C+nITEoKfmLL+/1deEt/V+sHD8tEo3zLpJRfEc3f+is ECGFqkKX+BPSgNNNjzcnLdbmGVQ1MGGnA71fFHesC3DaNAwwiCqAaufIBa6TGVXOalySGYpTaC60 A9xpkYYvVI0JncPQoFR1n2TMkbZ+P/oMvB8hEkb2VzG7svVqQHkeY4X99oVB6qgxNefcQLzBn/If YXTK3ZHJe+ZW42B9Mxulud/ngsKvObw7hU8GK/RR/Q== =gM3c -----END PGP SIGNATURE----- --------------7wLbm2MU50tdk2L67QW1JM8K-- From xen-devel-bounces@lists.xenproject.org Wed May 03 14:44:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 14:44:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529259.823447 (Exim 4.92) (envelope-from ) id 1puDiC-0002rU-Fn; Wed, 03 May 2023 14:44:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529259.823447; Wed, 03 May 2023 14:44:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puDiC-0002rN-CC; Wed, 03 May 2023 14:44:08 +0000 Received: by outflank-mailman (input) for mailman id 529259; Wed, 03 May 2023 14:44:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puDiB-0002rH-0W for xen-devel@lists.xenproject.org; Wed, 03 May 2023 14:44:07 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f424ea50-e9c0-11ed-b225-6b7b168915f2; Wed, 03 May 2023 16:44:05 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A6AE320472; Wed, 3 May 2023 14:44:05 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7C69C1331F; Wed, 3 May 2023 14:44:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id TymTHDVzUmQWTQAAMHmgww (envelope-from ); Wed, 03 May 2023 14:44:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f424ea50-e9c0-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683125045; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DtfcldeIlyvyiJm+cGQ7ZADA31nTBjnzUzAh3WEK4LI=; b=pDHBxrMoLmy2lNOK3R253gIMgyGg4rxjMSpygX5VAkpG7UunSqtHf//aam6kSqkQiLDQSK WV1xy55fe+L1wBWBFsb1aeB7PLHxFtcdZhHtFpO+tdbTo6YpJwVJUM1GI7ii7kllO3ZW7N 509yzLXjDojD3HBdUYe4/52IL0PIyrU= Message-ID: Date: Wed, 3 May 2023 16:44:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v4 13/13] tools/xenstore: switch quota management to be table based Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230405070349.25293-1-jgross@suse.com> <20230405070349.25293-14-jgross@suse.com> <1a529c44-1564-ad42-3924-f58efaa83a91@xen.org> From: Juergen Gross In-Reply-To: <1a529c44-1564-ad42-3924-f58efaa83a91@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------ZUF9dq0iMRAl2VbFZRkyRanD" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------ZUF9dq0iMRAl2VbFZRkyRanD Content-Type: multipart/mixed; boundary="------------7v7rD0UKHduATGBLDKGFLyoT"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: Subject: Re: [PATCH v4 13/13] tools/xenstore: switch quota management to be table based References: <20230405070349.25293-1-jgross@suse.com> <20230405070349.25293-14-jgross@suse.com> <1a529c44-1564-ad42-3924-f58efaa83a91@xen.org> In-Reply-To: <1a529c44-1564-ad42-3924-f58efaa83a91@xen.org> --------------7v7rD0UKHduATGBLDKGFLyoT Content-Type: multipart/mixed; boundary="------------LP7Vogz9Cyihv0QPkgO5Q10w" --------------LP7Vogz9Cyihv0QPkgO5Q10w Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMDUuMjMgMTI6NTMsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDA1LzA0LzIwMjMgMDg6MDMsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBJ bnN0ZWFkIG9mIGhhdmluZyBpbmRpdmlkdWFsIHF1b3RhIHZhcmlhYmxlcyBzd2l0Y2ggdG8g YSB0YWJsZSBiYXNlZA0KPj4gYXBwcm9hY2ggbGlrZSB0aGUgZ2VuZXJpYyBhY2NvdW50aW5n LiBJbmNsdWRlIGFsbCB0aGUgcmVsYXRlZCBkYXRhIGluDQo+PiB0aGUgc2FtZSB0YWJsZSBh bmQgYWRkIGFjY2Vzc29yIGZ1bmN0aW9ucy4NCj4+DQo+PiBUaGlzIGVuYWJsZXMgdG8gdXNl IHRoZSBjb21tYW5kIGxpbmUgLS1xdW90YSBwYXJhbWV0ZXIgZm9yIHNldHRpbmcgYWxsDQo+ PiBwb3NzaWJsZSBxdW90YSB2YWx1ZXMsIGtlZXBpbmcgdGhlIHByZXZpb3VzIHBhcmFtZXRl cnMgZm9yDQo+PiBjb21wYXRpYmlsaXR5Lg0KPj4NCj4+IFNpZ25lZC1vZmYtYnk6IEp1ZXJn ZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4+IC0tLQ0KPj4gVjI6DQo+PiAtIG5ldyBw YXRjaA0KPj4gT25lIGZ1cnRoZXIgcmVtYXJrOiBpdCB3b3VsZCBiZSByYXRoZXIgZWFzeSB0 byBhZGQgc29mdC1xdW90YSBmb3IgYWxsDQo+PiB0aGUgb3RoZXIgcXVvdGFzIChzaW1pbGFy IHRvIHRoZSBtZW1vcnkgb25lKS4gVGhpcyBjb3VsZCBiZSB1c2VkIGFzDQo+PiBhbiBlYXJs eSB3YXJuaW5nIGZvciB0aGUgbmVlZCB0byByYWlzZSBnbG9iYWwgcXVvdGEuDQo+IA0KPiBJ IGRvbid0IGhhdmUgYSBzdHJvbmcgb3BpbmlvbiBvbiB0aGlzIHRvcGljLg0KDQpNZSBuZWl0 aGVyLg0KDQo+IA0KPj4gLS0tDQo+PiDCoCB0b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29u dHJvbC5jwqDCoMKgwqAgfMKgIDQzICsrLS0tLS0tDQo+PiDCoCB0b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfY29yZS5jwqDCoMKgwqDCoMKgwqAgfMKgIDg1ICsrKysrKysrLS0tLS0tLS0N Cj4+IMKgIHRvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmjCoMKgwqDCoMKgwqDCoCB8 wqAgMTAgLS0NCj4+IMKgIHRvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uY8KgwqDC oMKgwqAgfCAxMzIgKysrKysrKysrKysrKysrKystLS0tLS0tLQ0KPj4gwqAgdG9vbHMveGVu c3RvcmUveGVuc3RvcmVkX2RvbWFpbi5owqDCoMKgwqDCoCB8wqAgMTIgKystDQo+PiDCoCB0 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYyB8wqDCoCA1ICstDQo+PiDC oCB0b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfd2F0Y2guY8KgwqDCoMKgwqDCoCB8wqDCoCAy ICstDQo+PiDCoCA3IGZpbGVzIGNoYW5nZWQsIDE1NSBpbnNlcnRpb25zKCspLCAxMzQgZGVs ZXRpb25zKC0pDQo+Pg0KPj4gZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3Jl ZF9jb250cm9sLmMgDQo+PiBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb250cm9sLmMN Cj4+IGluZGV4IGEyYmE2NGExNWMuLjc1ZjUxYTgwZGIgMTAwNjQ0DQo+PiAtLS0gYS90b29s cy94ZW5zdG9yZS94ZW5zdG9yZWRfY29udHJvbC5jDQo+PiArKysgYi90b29scy94ZW5zdG9y ZS94ZW5zdG9yZWRfY29udHJvbC5jDQo+PiBAQCAtMjIxLDM1ICsyMjEsNiBAQCBzdGF0aWMg aW50IGRvX2NvbnRyb2xfbG9nKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IA0KPj4gY29ubmVj dGlvbiAqY29ubiwNCj4+IMKgwqDCoMKgwqAgcmV0dXJuIDA7DQo+PiDCoCB9DQo+PiAtc3Ry dWN0IHF1b3RhIHsNCj4+IC3CoMKgwqAgY29uc3QgY2hhciAqbmFtZTsNCj4+IC3CoMKgwqAg aW50ICpxdW90YTsNCj4+IC3CoMKgwqAgY29uc3QgY2hhciAqZGVzY3I7DQo+PiAtfTsNCj4+ IC0NCj4+IC1zdGF0aWMgY29uc3Qgc3RydWN0IHF1b3RhIGhhcmRfcXVvdGFzW10gPSB7DQo+ PiAtwqDCoMKgIHsgIm5vZGVzIiwgJnF1b3RhX25iX2VudHJ5X3Blcl9kb21haW4sICJOb2Rl cyBwZXIgZG9tYWluIiB9LA0KPj4gLcKgwqDCoCB7ICJ3YXRjaGVzIiwgJnF1b3RhX25iX3dh dGNoX3Blcl9kb21haW4sICJXYXRjaGVzIHBlciBkb21haW4iIH0sDQo+PiAtwqDCoMKgIHsg InRyYW5zYWN0aW9ucyIsICZxdW90YV9tYXhfdHJhbnNhY3Rpb24sICJUcmFuc2FjdGlvbnMg cGVyIGRvbWFpbiIgfSwNCj4+IC3CoMKgwqAgeyAib3V0c3RhbmRpbmciLCAmcXVvdGFfcmVx X291dHN0YW5kaW5nLA0KPj4gLcKgwqDCoMKgwqDCoMKgICJPdXRzdGFuZGluZyByZXF1ZXN0 cyBwZXIgZG9tYWluIiB9LA0KPj4gLcKgwqDCoCB7ICJ0cmFuc2FjdGlvbi1ub2RlcyIsICZx dW90YV90cmFuc19ub2RlcywNCj4+IC3CoMKgwqDCoMKgwqDCoCAiTWF4LiBudW1iZXIgb2Yg YWNjZXNzZWQgbm9kZXMgcGVyIHRyYW5zYWN0aW9uIiB9LA0KPj4gLcKgwqDCoCB7ICJtZW1v cnkiLCAmcXVvdGFfbWVtb3J5X3Blcl9kb21haW5faGFyZCwNCj4+IC3CoMKgwqDCoMKgwqDC oCAiVG90YWwgWGVuc3RvcmUgbWVtb3J5IHBlciBkb21haW4gKGVycm9yIGxldmVsKSIgfSwN Cj4+IC3CoMKgwqAgeyAibm9kZS1zaXplIiwgJnF1b3RhX21heF9lbnRyeV9zaXplLCAiTWF4 LiBzaXplIG9mIGEgbm9kZSIgfSwNCj4+IC3CoMKgwqAgeyAicGF0aC1tYXgiLCAmcXVvdGFf bWF4X3BhdGhfbGVuLCAiTWF4LiBsZW5ndGggb2YgYSBub2RlIHBhdGgiIH0sDQo+PiAtwqDC oMKgIHsgInBlcm1pc3Npb25zIiwgJnF1b3RhX25iX3Blcm1zX3Blcl9ub2RlLA0KPj4gLcKg wqDCoMKgwqDCoMKgICJNYXguIG51bWJlciBvZiBwZXJtaXNzaW9ucyBwZXIgbm9kZSIgfSwN Cj4+IC3CoMKgwqAgeyBOVUxMLCBOVUxMLCBOVUxMIH0NCj4+IC19Ow0KPj4gLQ0KPj4gLXN0 YXRpYyBjb25zdCBzdHJ1Y3QgcXVvdGEgc29mdF9xdW90YXNbXSA9IHsNCj4+IC3CoMKgwqAg eyAibWVtb3J5IiwgJnF1b3RhX21lbW9yeV9wZXJfZG9tYWluX3NvZnQsDQo+PiAtwqDCoMKg wqDCoMKgwqAgIlRvdGFsIFhlbnN0b3JlIG1lbW9yeSBwZXIgZG9tYWluICh3YXJuaW5nIGxl dmVsKSIgfSwNCj4+IC3CoMKgwqAgeyBOVUxMLCBOVUxMLCBOVUxMIH0NCj4+IC19Ow0KPj4g LQ0KPj4gwqAgc3RhdGljIGludCBxdW90YV9zaG93X2N1cnJlbnQoY29uc3Qgdm9pZCAqY3R4 LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIGNvbnN0IHN0cnVjdCBxdW90YSAqcXVvdGFzKQ0KPj4gwqAgew0K Pj4gQEAgLTI2MCw5ICsyMzEsMTEgQEAgc3RhdGljIGludCBxdW90YV9zaG93X2N1cnJlbnQo Y29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgDQo+PiBjb25uZWN0aW9uICpjb25uLA0KPj4gwqDC oMKgwqDCoCBpZiAoIXJlc3ApDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIEVOT01F TTsNCj4+IC3CoMKgwqAgZm9yIChpID0gMDsgcXVvdGFzW2ldLnF1b3RhOyBpKyspIHsNCj4+ ICvCoMKgwqAgZm9yIChpID0gMDsgaSA8IEFDQ19OOyBpKyspIHsNCj4+ICvCoMKgwqDCoMKg wqDCoCBpZiAoIXF1b3Rhc1tpXS5uYW1lKQ0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAg Y29udGludWU7DQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgcmVzcCA9IHRhbGxvY19hc3ByaW50 Zl9hcHBlbmQocmVzcCwgIiUtMTdzOiAlOGQgJXNcbiIsDQo+PiAtwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcXVvdGFzW2ldLm5hbWUsICpx dW90YXNbaV0ucXVvdGEsDQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgcXVvdGFzW2ldLm5hbWUsIHF1b3Rhc1tpXS52YWwsDQo+PiDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg cXVvdGFzW2ldLmRlc2NyKTsNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCBpZiAoIXJlc3ApDQo+ PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gRU5PTUVNOw0KPj4gQEAgLTI3 NCw3ICsyNDcsNyBAQCBzdGF0aWMgaW50IHF1b3RhX3Nob3dfY3VycmVudChjb25zdCB2b2lk ICpjdHgsIHN0cnVjdCANCj4+IGNvbm5lY3Rpb24gKmNvbm4sDQo+PiDCoCB9DQo+PiDCoCBz dGF0aWMgaW50IHF1b3RhX3NldChjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9u ICpjb25uLA0KPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBjaGFyICoqdmVjLCBpbnQg bnVtLCBjb25zdCBzdHJ1Y3QgcXVvdGEgKnF1b3RhcykNCj4+ICvCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAgY2hhciAqKnZlYywgaW50IG51bSwgc3RydWN0IHF1b3RhICpxdW90YXMpDQo+ PiDCoCB7DQo+PiDCoMKgwqDCoMKgIHVuc2lnbmVkIGludCBpOw0KPj4gwqDCoMKgwqDCoCBp bnQgdmFsOw0KPj4gQEAgLTI4Niw5ICsyNTksOSBAQCBzdGF0aWMgaW50IHF1b3RhX3NldChj b25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uIA0KPj4gKmNvbm4sDQo+PiDCoMKg wqDCoMKgIGlmICh2YWwgPCAxKQ0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiBFSU5W QUw7DQo+PiAtwqDCoMKgIGZvciAoaSA9IDA7IHF1b3Rhc1tpXS5xdW90YTsgaSsrKSB7DQo+ PiAtwqDCoMKgwqDCoMKgwqAgaWYgKCFzdHJjbXAodmVjWzBdLCBxdW90YXNbaV0ubmFtZSkp IHsNCj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgICpxdW90YXNbaV0ucXVvdGEgPSB2YWw7 DQo+PiArwqDCoMKgIGZvciAoaSA9IDA7IGkgPCBBQ0NfTjsgaSsrKSB7DQo+PiArwqDCoMKg wqDCoMKgwqAgaWYgKHF1b3Rhc1tpXS5uYW1lICYmICFzdHJjbXAodmVjWzBdLCBxdW90YXNb aV0ubmFtZSkpIHsNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHF1b3Rhc1tpXS52YWwg PSB2YWw7DQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBzZW5kX2Fjayhjb25uLCBY U19DT05UUk9MKTsNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiAwOw0K Pj4gwqDCoMKgwqDCoMKgwqDCoMKgIH0NCj4+IGRpZmYgLS1naXQgYS90b29scy94ZW5zdG9y ZS94ZW5zdG9yZWRfY29yZS5jIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYw0K Pj4gaW5kZXggNjVkZjI4NjZiZi4uNmUyZmMwNjg0MCAxMDA2NDQNCj4+IC0tLSBhL3Rvb2xz L3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMNCj4+ICsrKyBiL3Rvb2xzL3hlbnN0b3JlL3hl bnN0b3JlZF9jb3JlLmMNCj4+IEBAIC04OSwxNyArODksNiBAQCB1bnNpZ25lZCBpbnQgdHJh Y2VfZmxhZ3MgPSBUUkFDRV9PQkogfCBUUkFDRV9JTzsNCj4+IMKgIHN0YXRpYyBjb25zdCBj aGFyICpzb2NrbXNnX3N0cmluZyhlbnVtIHhzZF9zb2NrbXNnX3R5cGUgdHlwZSk7DQo+PiAt aW50IHF1b3RhX25iX2VudHJ5X3Blcl9kb21haW4gPSAxMDAwOw0KPj4gLWludCBxdW90YV9u Yl93YXRjaF9wZXJfZG9tYWluID0gMTI4Ow0KPj4gLWludCBxdW90YV9tYXhfZW50cnlfc2l6 ZSA9IDIwNDg7IC8qIDJLICovDQo+PiAtaW50IHF1b3RhX21heF90cmFuc2FjdGlvbiA9IDEw Ow0KPj4gLWludCBxdW90YV9uYl9wZXJtc19wZXJfbm9kZSA9IDU7DQo+PiAtaW50IHF1b3Rh X3RyYW5zX25vZGVzID0gMTAyNDsNCj4+IC1pbnQgcXVvdGFfbWF4X3BhdGhfbGVuID0gWEVO U1RPUkVfUkVMX1BBVEhfTUFYOw0KPj4gLWludCBxdW90YV9yZXFfb3V0c3RhbmRpbmcgPSAy MDsNCj4+IC1pbnQgcXVvdGFfbWVtb3J5X3Blcl9kb21haW5fc29mdCA9IDIgKiAxMDI0ICog MTAyNDsgLyogMiBNQiAqLw0KPj4gLWludCBxdW90YV9tZW1vcnlfcGVyX2RvbWFpbl9oYXJk ID0gMiAqIDEwMjQgKiAxMDI0ICsgNTEyICogMTAyNDsgLyogMi41IE1CICovDQo+PiAtDQo+ PiDCoCB1bnNpZ25lZCBpbnQgdGltZW91dF93YXRjaF9ldmVudF9tc2VjID0gMjAwMDA7DQo+ PiDCoCB2b2lkIHRyYWNlKGNvbnN0IGNoYXIgKmZtdCwgLi4uKQ0KPj4gQEAgLTc5OSw3ICs3 ODgsNyBAQCBpbnQgd3JpdGVfbm9kZV9yYXcoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIFRE Ql9EQVRBICprZXksIA0KPj4gc3RydWN0IG5vZGUgKm5vZGUsDQo+PiDCoMKgwqDCoMKgwqDC oMKgwqAgKyBub2RlLT5wZXJtcy5udW0gKiBzaXplb2Yobm9kZS0+cGVybXMucFswXSkNCj4+ IMKgwqDCoMKgwqDCoMKgwqDCoCArIG5vZGUtPmRhdGFsZW4gKyBub2RlLT5jaGlsZGxlbjsN Cj4+IC3CoMKgwqAgaWYgKGRvbWFpbl9tYXhfY2hrKGNvbm4sIEFDQ19OT0RFU1osIGRhdGEu ZHNpemUsIHF1b3RhX21heF9lbnRyeV9zaXplKQ0KPj4gK8KgwqDCoCBpZiAoZG9tYWluX21h eF9jaGsoY29ubiwgQUNDX05PREVTWiwgZGF0YS5kc2l6ZSkNCj4+IMKgwqDCoMKgwqDCoMKg wqDCoCAmJiAhbm9fcXVvdGFfY2hlY2spIHsNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCBlcnJu byA9IEVOT1NQQzsNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gZXJybm87DQo+PiBA QCAtMTE4OCw4ICsxMTc3LDcgQEAgYm9vbCBpc192YWxpZF9ub2RlbmFtZShjb25zdCBzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubiwgDQo+PiBjb25zdCBjaGFyICpub2RlKQ0KPj4gwqDCoMKg wqDCoCBpZiAoc3NjYW5mKG5vZGUsICIvbG9jYWwvZG9tYWluLyU1dS8lbiIsICZkb21pZCwg JmxvY2FsX29mZikgIT0gMSkNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCBsb2NhbF9vZmYgPSAw Ow0KPj4gLcKgwqDCoCBpZiAoZG9tYWluX21heF9jaGsoY29ubiwgQUNDX1BBVEhMRU4sIHN0 cmxlbihub2RlKSAtIGxvY2FsX29mZiwNCj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIHF1b3RhX21heF9wYXRoX2xlbikpDQo+PiArwqDCoMKgIGlmIChkb21haW5fbWF4X2No ayhjb25uLCBBQ0NfUEFUSExFTiwgc3RybGVuKG5vZGUpIC0gbG9jYWxfb2ZmKSkNCj4+IMKg wqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gZmFsc2U7DQo+PiDCoMKgwqDCoMKgIHJldHVybiB2 YWxpZF9jaGFycyhub2RlKTsNCj4+IEBAIC0xNTAxLDcgKzE0ODksNyBAQCBzdGF0aWMgc3Ry dWN0IG5vZGUgKmNyZWF0ZV9ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCANCj4+IGNv bnN0IHZvaWQgKmN0eCwNCj4+IMKgwqDCoMKgwqAgZm9yIChpID0gbm9kZTsgaTsgaSA9IGkt PnBhcmVudCkgew0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIC8qIGktPnBhcmVudCBpcyBzZXQg Zm9yIGVhY2ggbmV3IG5vZGUsIHNvIGNoZWNrIHF1b3RhLiAqLw0KPj4gwqDCoMKgwqDCoMKg wqDCoMKgIGlmIChpLT5wYXJlbnQgJiYNCj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGRv bWFpbl9uYmVudHJ5KGNvbm4pID49IHF1b3RhX25iX2VudHJ5X3Blcl9kb21haW4pIHsNCj4+ ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGRvbWFpbl9uYmVudHJ5KGNvbm4pID49IGhhcmRf cXVvdGFzW0FDQ19OT0RFU10udmFsKSB7DQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCByZXQgPSBFTk9TUEM7DQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBnb3RvIGVy cjsNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCB9DQo+PiBAQCAtMTc3Niw3ICsxNzY0LDcgQEAg c3RhdGljIGludCBkb19zZXRfcGVybXMoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgDQo+PiBj b25uZWN0aW9uICpjb25uLA0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiBFSU5WQUw7 DQo+PiDCoMKgwqDCoMKgIHBlcm1zLm51bS0tOw0KPj4gLcKgwqDCoCBpZiAoZG9tYWluX21h eF9jaGsoY29ubiwgQUNDX05QRVJNLCBwZXJtcy5udW0sIHF1b3RhX25iX3Blcm1zX3Blcl9u b2RlKSkNCj4+ICvCoMKgwqAgaWYgKGRvbWFpbl9tYXhfY2hrKGNvbm4sIEFDQ19OUEVSTSwg cGVybXMubnVtKSkNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gRU5PU1BDOw0KPj4g wqDCoMKgwqDCoCBwZXJtc3RyID0gaW4tPmJ1ZmZlciArIHN0cmxlbihpbi0+YnVmZmVyKSAr IDE7DQo+PiBAQCAtMjY0NCw3ICsyNjMyLDE2IEBAIHN0YXRpYyB2b2lkIHVzYWdlKHZvaWQp DQo+PiDCoCAiwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqAgbWVtb3J5OiB0b3RhbCB1c2VkIG1lbW9yeSBwZXIgZG9tYWluIGZvciBub2Rlcyxc biINCj4+IMKgICLCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdHJhbnNhY3Rpb25zLCB3YXRjaGVzIGFuZCByZXF1 ZXN0cywgYWJvdmVcbiINCj4+IMKgICLCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgd2hpY2ggWGVuc3RvcmUgd2ls bCBzdG9wIHRhbGtpbmcgdG8gDQo+PiBkb21haW5cbiINCj4+ICsiwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgbm9kZXM6IG51bWJlciBub2Rl cyBvd25lZCBieSBhIGRvbWFpblxuIg0KPj4gKyLCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBub2RlLXBlcm1pc3Npb25zOiBudW1iZXIgb2Yg YWNjZXNzIHBlcm1pc3Npb25zIHBlclxuIg0KPj4gKyLCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCBub2RlXG4iDQo+PiArIsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIG5vZGUtc2l6ZTogdG90YWwgc2l6ZSBvZiBhIG5vZGUg KHBlcm1pc3Npb25zICtcbiINCj4+ICsiwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGNoaWxkcmVuIG5h bWVzICsgY29udGVudClcbiINCj4+IMKgICLCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBvdXRzdGFuZGluZzogbnVtYmVyIG9mIG91dHN0YW5k aW5nIHJlcXVlc3RzXG4iDQo+PiArIsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgIHBhdGgtbGVuZ3RoOiBsZW5ndGggb2YgYSBub2RlIHBhdGhc biINCj4+ICsiwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqAgdHJhbnNhY3Rpb25zOiBudW1iZXIgb2YgY29uY3VycmVudCB0cmFuc2FjdGlvbnNc biINCj4+ICsiwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHBlciBkb21haW5cbiINCj4+ICsi wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgd2F0 Y2hlczogbnVtYmVyIG9mIHdhdGNoZXMgcGVyIGRvbWFpbiINCj4+IMKgICLCoCAtcSwgLS1x dW90YS1zb2Z0IDx3aGF0Pj08bmI+IHNldCBhIHNvZnQgcXVvdGEgPHdoYXQ+IHRvIHRoZSB2 YWx1ZSA8bmI+LFxuIg0KPj4gwqAgIsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgIGNhdXNpbmcgYSB3YXJuaW5nIHRvIGJlIGlzc3VlZCB2aWEg c3lzbG9nKCkgaWYgDQo+PiB0aGVcbiINCj4+IMKgICLCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBsaW1pdCBpcyB2aW9sYXRlZCwgYWxsb3dl ZCBxdW90YXMgYXJlOlxuIg0KPj4gQEAgLTI2OTUsMTIgKzI2OTIsMTIgQEAgaW50IGRvbTBf ZG9taWQgPSAwOw0KPj4gwqAgaW50IGRvbTBfZXZlbnQgPSAwOw0KPj4gwqAgaW50IHByaXZf ZG9taWQgPSAwOw0KPj4gLXN0YXRpYyBpbnQgZ2V0X29wdHZhbF9pbnQoY29uc3QgY2hhciAq YXJnKQ0KPj4gK3N0YXRpYyB1bnNpZ25lZCBpbnQgZ2V0X29wdHZhbF9pbnQoY29uc3QgY2hh ciAqYXJnKQ0KPj4gwqAgew0KPj4gwqDCoMKgwqDCoCBjaGFyICplbmQ7DQo+PiAtwqDCoMKg IGxvbmcgdmFsOw0KPj4gK8KgwqDCoCB1bnNpZ25lZCBsb25nIHZhbDsNCj4+IC3CoMKgwqAg dmFsID0gc3RydG9sKGFyZywgJmVuZCwgMTApOw0KPj4gK8KgwqDCoCB2YWwgPSBzdHJ0b3Vs KGFyZywgJmVuZCwgMTApOw0KPiBUaGUgY2hhbmdlcyBpbiBnZXRfb3B0dmFsX2ludCgpIGZl ZWxzIGxpa2UgbW9yZSBhIGNsZWFuLXVwIGJlY2F1c2UgdGhlIHJldHVybmVkIA0KPiB2YWx1 ZSBjYW5ub3QgYmUgbmVnYXRpdmUgKHNlZSBjaGVjayBiZWxvdykuIEkgd291bGQgcHJlZmVy IGlmIHRoZXkgYXJlIGRvbmUgaW4gYSANCj4gc2VwYXJhdGUgcGF0Y2guDQoNCk9rYXkuDQoN Cj4gDQo+PiDCoMKgwqDCoMKgIGlmICghKmFyZyB8fCAqZW5kIHx8IHZhbCA8IDAgfHwgdmFs ID4gSU5UX01BWCkNCj4gDQo+IE5vdyB0aGF0ICd2YWwnIGlzIHVuc2lnbmVkIGxvbmcsIHRo ZW4gdGhlcmUgaXMgbm8gcG9pbnQgZm9yIGNoZWNraW5nIHZhbCBpcyA8IDAuDQoNCk9oLCBp bmRlZWQuDQoNCj4gDQo+IExhc3RseSwgSSB3b3VsZCByZW5hbWUgdGhlIGhlbHBlciB0byBt YWtlIGNsZWFyIGl0IHJldHVybnMgYW4gdW5zaWduZWQgdmFsdWUuIA0KPiBIb3cgYWJvdXQg Z2V0X29wdHZhbF91aW50KCk/DQoNCk9rYXkuDQoNCj4gDQo+PiDCoMKgwqDCoMKgwqDCoMKg wqAgYmFyZigiaW52YWxpZCBwYXJhbWV0ZXIgdmFsdWUgXCIlc1wiXG4iLCBhcmcpOw0KPj4g QEAgLTI3MDksMTUgKzI3MDYsMTkgQEAgc3RhdGljIGludCBnZXRfb3B0dmFsX2ludChjb25z dCBjaGFyICphcmcpDQo+PiDCoCBzdGF0aWMgYm9vbCB3aGF0X21hdGNoZXMoY29uc3QgY2hh ciAqYXJnLCBjb25zdCBjaGFyICp3aGF0KQ0KPj4gwqAgew0KPj4gLcKgwqDCoCB1bnNpZ25l ZCBpbnQgd2hhdF9sZW4gPSBzdHJsZW4od2hhdCk7DQo+PiArwqDCoMKgIHVuc2lnbmVkIGlu dCB3aGF0X2xlbjsNCj4+ICsNCj4+ICvCoMKgwqAgaWYgKCF3aGF0KQ0KPj4gK8KgwqDCoMKg wqDCoMKgIGZhbHNlOw0KPiANCj4gU2hvdWxkbid0IHRoaXMgYmUgInJldHVybiBmYWxzZSI/ DQoNClllcy4NCg0KDQpKdWVyZ2VuDQo= --------------LP7Vogz9Cyihv0QPkgO5Q10w Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------LP7Vogz9Cyihv0QPkgO5Q10w-- --------------7v7rD0UKHduATGBLDKGFLyoT-- --------------ZUF9dq0iMRAl2VbFZRkyRanD Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmRSczUFAwAAAAAACgkQsN6d1ii/Ey/C rwf/RujEp52TS0gYT54CJSshoUqjmJS8HvP7on68P1iFJGoe6pc5R1fKPNGcbqQZAQUodNaILssy vWhIMY9GZiwbRBXGYES9rUxzCDMPcITuRlQh2+x0Xzbzcg/DXu01rUYlJq/Ed0+82QdR/5wN2SYL FY7wKWKvIWCTRDGzFVip9lccbtovvV/PF0baiwPvVly0ZYl2ybBpsDm/C6sZDoIvE4N9hFnFbsDn hbWhA7xxokpmTe9/9XYTYSiNGElJEWBTk+CHJDWtb/ws1N9t9+x4UAzp883cHHTdePkJ9xBwMYjj gTRScnbLKu4f4WKIBMjsMezvaExDA61nfsdsvuQTEA== =H1Z+ -----END PGP SIGNATURE----- --------------ZUF9dq0iMRAl2VbFZRkyRanD-- From xen-devel-bounces@lists.xenproject.org Wed May 03 14:45:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 14:45:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529264.823458 (Exim 4.92) (envelope-from ) id 1puDjW-0003UW-Vl; Wed, 03 May 2023 14:45:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529264.823458; Wed, 03 May 2023 14:45:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puDjW-0003UP-Qf; Wed, 03 May 2023 14:45:30 +0000 Received: by outflank-mailman (input) for mailman id 529264; Wed, 03 May 2023 14:45:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puDjV-0003Tz-83 for xen-devel@lists.xenproject.org; Wed, 03 May 2023 14:45:29 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2558c85d-e9c1-11ed-b225-6b7b168915f2; Wed, 03 May 2023 16:45:28 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1A5DD20472; Wed, 3 May 2023 14:45:28 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E4C601331F; Wed, 3 May 2023 14:45:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id JLF5NodzUmTzTQAAMHmgww (envelope-from ); Wed, 03 May 2023 14:45:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2558c85d-e9c1-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683125128; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hGQYK42d3jA6rJoAskGLq5Fd4hxMy9lkmej84hXY6bk=; b=SMmWC5G6ERV3cjrfWKkUE+RNx7QvqF9tcw+V3WWvmgCteTwolgAlMRIpVMd74me4DIo12f H0a3GhMONfseA8yWGZFxXJKu970GLf7My2biGEeFV8IcGE45QcVkD6ZiufOFbWB3lzJCgl jHz/724htpgdD2zyZ4Mr2pg8iV1g9QM= Message-ID: Date: Wed, 3 May 2023 16:45:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v2 03/13] tools/xenstore: modify interface of create_hashtable() Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230330085011.9170-1-jgross@suse.com> <20230330085011.9170-4-jgross@suse.com> <1a2a7aed-8947-c5ed-e1ed-8fa80bc75750@xen.org> From: Juergen Gross In-Reply-To: <1a2a7aed-8947-c5ed-e1ed-8fa80bc75750@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------9QaKlmPp0zNMNJYTjaYe2SOX" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------9QaKlmPp0zNMNJYTjaYe2SOX Content-Type: multipart/mixed; boundary="------------wqR7kyJJtfyTTDjEJUj6v8r0"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: Subject: Re: [PATCH v2 03/13] tools/xenstore: modify interface of create_hashtable() References: <20230330085011.9170-1-jgross@suse.com> <20230330085011.9170-4-jgross@suse.com> <1a2a7aed-8947-c5ed-e1ed-8fa80bc75750@xen.org> In-Reply-To: <1a2a7aed-8947-c5ed-e1ed-8fa80bc75750@xen.org> --------------wqR7kyJJtfyTTDjEJUj6v8r0 Content-Type: multipart/mixed; boundary="------------2afD6VB57g35pVY2pMO5GNIx" --------------2afD6VB57g35pVY2pMO5GNIx Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMDUuMjMgMTQ6NTksIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDMwLzAzLzIwMjMgMDk6NTAsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBU aGUgbWluc2l6ZSBwYXJhbWV0ZXIgb2YgY3JlYXRlX2hhc2h0YWJsZSgpIGRvZXNuJ3QgaGF2 ZSBhbnkgcmVhbCB1c2UNCj4+IGNhc2UgZm9yIFhlbnN0b3JlLCBzbyBkcm9wIGl0Lg0KPj4N Cj4+IEZvciBiZXR0ZXIgdGFsbG9jX3JlcG9ydF9mdWxsKCkgZGlhZ25vc3RpYyBvdXRwdXQg YWRkIGEgbmFtZSBwYXJhbWV0ZXINCj4+IHRvIGNyZWF0ZV9oYXNodGFibGUoKS4NCj4+DQo+ PiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+PiAt LS0NCj4+IMKgIHRvb2xzL3hlbnN0b3JlL2hhc2h0YWJsZS5jwqDCoMKgwqDCoMKgwqAgfCAy MCArKysrKystLS0tLS0tLS0tLS0tLQ0KPj4gwqAgdG9vbHMveGVuc3RvcmUvaGFzaHRhYmxl LmjCoMKgwqDCoMKgwqDCoCB8wqAgNCArKy0tDQo+PiDCoCB0b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfY29yZS5jwqDCoCB8wqAgMiArLQ0KPj4gwqAgdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2RvbWFpbi5jIHzCoCA0ICsrLS0NCj4+IMKgIDQgZmlsZXMgY2hhbmdlZCwgMTEgaW5z ZXJ0aW9ucygrKSwgMTkgZGVsZXRpb25zKC0pDQo+Pg0KPj4gZGlmZiAtLWdpdCBhL3Rvb2xz L3hlbnN0b3JlL2hhc2h0YWJsZS5jIGIvdG9vbHMveGVuc3RvcmUvaGFzaHRhYmxlLmMNCj4+ IGluZGV4IGMxYjExNzQzYmIuLmFiMWU2ODdkMGIgMTAwNjQ0DQo+PiAtLS0gYS90b29scy94 ZW5zdG9yZS9oYXNodGFibGUuYw0KPj4gKysrIGIvdG9vbHMveGVuc3RvcmUvaGFzaHRhYmxl LmMNCj4+IEBAIC01NSwzNiArNTUsMjggQEAgc3RhdGljIHVuc2lnbmVkIGludCBsb2FkbGlt aXQodW5zaWduZWQgaW50IHBpbmRleCkNCj4+IMKgwqDCoMKgwqAgcmV0dXJuICgodWludDY0 X3QpcHJpbWVzW3BpbmRleF0gKiBNQVhfTE9BRF9QRVJDRU5UKSAvIDEwMDsNCj4+IMKgIH0N Cj4+IC1zdHJ1Y3QgaGFzaHRhYmxlICpjcmVhdGVfaGFzaHRhYmxlKGNvbnN0IHZvaWQgKmN0 eCwgdW5zaWduZWQgaW50IG1pbnNpemUsDQo+PiArc3RydWN0IGhhc2h0YWJsZSAqY3JlYXRl X2hhc2h0YWJsZShjb25zdCB2b2lkICpjdHgsIGNvbnN0IGNoYXIgKm5hbWUsDQo+PiDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgdW5zaWduZWQgaW50ICgqaGFzaGYpIChjb25zdCB2b2lkICopLA0K Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIGludCAoKmVxZikgKGNvbnN0IHZvaWQgKiwgY29uc3Qg dm9pZCAqKSwNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBpbnQgZmxhZ3MpDQo+ PiDCoCB7DQo+PiDCoMKgwqDCoMKgIHN0cnVjdCBoYXNodGFibGUgKmg7DQo+PiAtwqDCoMKg IHVuc2lnbmVkIGludCBwaW5kZXgsIHNpemUgPSBwcmltZXNbMF07DQo+PiAtDQo+PiAtwqDC oMKgIC8qIENoZWNrIHJlcXVlc3RlZCBoYXNodGFibGUgaXNuJ3QgdG9vIGxhcmdlICovDQo+ PiAtwqDCoMKgIGlmIChtaW5zaXplID4gKDF1IDw8IDMwKSkgcmV0dXJuIE5VTEw7DQo+PiAt DQo+PiAtwqDCoMKgIC8qIEVuZm9yY2Ugc2l6ZSBhcyBwcmltZSAqLw0KPj4gLcKgwqDCoCBm b3IgKHBpbmRleD0wOyBwaW5kZXggPCBQUklNRV9UQUJMRV9MRU47IHBpbmRleCsrKSB7DQo+ PiAtwqDCoMKgwqDCoMKgwqAgaWYgKHByaW1lc1twaW5kZXhdID4gbWluc2l6ZSkgeyBzaXpl ID0gcHJpbWVzW3BpbmRleF07IGJyZWFrOyB9DQo+PiAtwqDCoMKgIH0NCj4+IMKgwqDCoMKg wqAgaCA9IHRhbGxvY196ZXJvKGN0eCwgc3RydWN0IGhhc2h0YWJsZSk7DQo+PiDCoMKgwqDC oMKgIGlmIChOVUxMID09IGgpDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgZ290byBlcnIwOw0K Pj4gLcKgwqDCoCBoLT50YWJsZSA9IHRhbGxvY196ZXJvX2FycmF5KGgsIHN0cnVjdCBlbnRy eSAqLCBzaXplKTsNCj4+ICvCoMKgwqAgdGFsbG9jX3NldF9uYW1lX2NvbnN0KGgsIG5hbWUp Ow0KPj4gK8KgwqDCoCBoLT50YWJsZSA9IHRhbGxvY196ZXJvX2FycmF5KGgsIHN0cnVjdCBl bnRyeSAqLCBwcmltZXNbMF0pOw0KPj4gwqDCoMKgwqDCoCBpZiAoTlVMTCA9PSBoLT50YWJs ZSkNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCBnb3RvIGVycjE7DQo+PiAtwqDCoMKgIGgtPnRh YmxlbGVuZ3RowqAgPSBzaXplOw0KPj4gK8KgwqDCoCBoLT50YWJsZWxlbmd0aMKgID0gcHJp bWVzWzBdOw0KPiANCj4gSSBmaW5kIHRoZSBjb25uZWN0aW9uIGJldHdlZW4gdGhpcyBsaW5l LCAuLi4NCj4gDQo+PiDCoMKgwqDCoMKgIGgtPmZsYWdzwqDCoMKgwqDCoMKgwqAgPSBmbGFn czsNCj4+IC3CoMKgwqAgaC0+cHJpbWVpbmRleMKgwqAgPSBwaW5kZXg7DQo+PiArwqDCoMKg IGgtPnByaW1laW5kZXjCoMKgID0gMDsNCj4gDQo+IC4uLiB0aGlzIG9uZSBhbmQgLi4uDQo+ IA0KPj4gwqDCoMKgwqDCoCBoLT5lbnRyeWNvdW50wqDCoCA9IDA7DQo+PiDCoMKgwqDCoMKg IGgtPmhhc2hmbsKgwqDCoMKgwqDCoCA9IGhhc2hmOw0KPj4gwqDCoMKgwqDCoCBoLT5lcWZu wqDCoMKgwqDCoMKgwqDCoCA9IGVxZjsNCj4+IC3CoMKgwqAgaC0+bG9hZGxpbWl0wqDCoMKg ID0gbG9hZGxpbWl0KHBpbmRleCk7DQo+PiArwqDCoMKgIGgtPmxvYWRsaW1pdMKgwqDCoCA9 IGxvYWRsaW1pdCgwKTsNCj4gDQo+IC4uLiBub3cgbW9yZSBkaWZmaWN1bHQgdG8gZmluZC4g SG93IGFib3V0IHNldHRpbmcgaC0+cHJpbWVpbmRleCBmaXJzdCBhbmQgdGhlbiANCj4gdXNp bmcgaXQgaW4gcGxhY2Ugb2YgMD8NCg0KRmluZSB3aXRoIG1lLg0KDQoNCkp1ZXJnZW4NCg== --------------2afD6VB57g35pVY2pMO5GNIx Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------2afD6VB57g35pVY2pMO5GNIx-- --------------wqR7kyJJtfyTTDjEJUj6v8r0-- --------------9QaKlmPp0zNMNJYTjaYe2SOX Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmRSc4cFAwAAAAAACgkQsN6d1ii/Ey9P 0ggAkS5HMD+CA45UEsBPOrXVWkP+jY6NYAHffWzFz8D8oXkWaqyroga1kZlbTxBilzlsd8UqPdhj +TlLCwlaGj0+MLT/4q/OA4GBklwN7MqZ4fh4I1+rBquUE3KxBCUQwPzP8Dwueln1NxPCNEA5CYbn 99XQ7qilvhCqQLKxZHBAW5M064xT8VKN97w3IACB/S6SHohaUvxGJ/mlO+Z4f+krESA87PckU8zz Pbc4kyvp2cIht2hYN1oVxrZyueRx7xGi1gABV286e/frRIFUCvJWhtm1HFt6eso2XAF4TlXTr2Ou l4luEdXdQHx8g41swz0pbx7bWUrGLRBO1chgJbymiw== =yyFZ -----END PGP SIGNATURE----- --------------9QaKlmPp0zNMNJYTjaYe2SOX-- From xen-devel-bounces@lists.xenproject.org Wed May 03 14:46:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 14:46:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529267.823467 (Exim 4.92) (envelope-from ) id 1puDk5-0003zd-6o; Wed, 03 May 2023 14:46:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529267.823467; Wed, 03 May 2023 14:46:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puDk5-0003zW-3V; Wed, 03 May 2023 14:46:05 +0000 Received: by outflank-mailman (input) for mailman id 529267; Wed, 03 May 2023 14:46:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puDk3-0003zE-GJ for xen-devel@lists.xenproject.org; Wed, 03 May 2023 14:46:03 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 39af8658-e9c1-11ed-b225-6b7b168915f2; Wed, 03 May 2023 16:46:02 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 56BAB1FFDE; Wed, 3 May 2023 14:46:02 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 309871331F; Wed, 3 May 2023 14:46:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Sh1wCqpzUmRFTgAAMHmgww (envelope-from ); Wed, 03 May 2023 14:46:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 39af8658-e9c1-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683125162; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pFpmv1gGDLXU8PfERn9zZeyVEmZy5izRrOkIEEPjLEc=; b=A8EHRUb/mS9PCKrQruVCiAPVfIyydnOqbJETVV8gxX9LVMFDmXJ6yyUj0/axUeH5idSUET df5BJmNCxqTGW/CLOZYTz318HVQ4luzG74rdcZaHJSJXJYuGK31Cgs1wSmYf77bifHR6be EKR1Ox7tw9ZYih9yQYQmupPtfvy9vSg= Message-ID: Date: Wed, 3 May 2023 16:46:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v2 02/13] tools/xenstore: do some cleanup of hashtable.c Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230330085011.9170-1-jgross@suse.com> <20230330085011.9170-3-jgross@suse.com> <8d91f57b-41ed-2939-94e8-9f73f0d523a6@xen.org> From: Juergen Gross In-Reply-To: <8d91f57b-41ed-2939-94e8-9f73f0d523a6@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------EddWgL95A5UVdSL8zjLHahIL" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------EddWgL95A5UVdSL8zjLHahIL Content-Type: multipart/mixed; boundary="------------LReBWUmikuryo4KQO0eBI0CF"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: Subject: Re: [PATCH v2 02/13] tools/xenstore: do some cleanup of hashtable.c References: <20230330085011.9170-1-jgross@suse.com> <20230330085011.9170-3-jgross@suse.com> <8d91f57b-41ed-2939-94e8-9f73f0d523a6@xen.org> In-Reply-To: <8d91f57b-41ed-2939-94e8-9f73f0d523a6@xen.org> --------------LReBWUmikuryo4KQO0eBI0CF Content-Type: multipart/mixed; boundary="------------76X27yqS6xh0zS29YlioB0ik" --------------76X27yqS6xh0zS29YlioB0ik Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMDUuMjMgMTQ6NTUsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDMwLzAzLzIwMjMgMDk6NTAsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBE byB0aGUgZm9sbG93aW5nIGNsZWFudXBzOg0KPj4gLSBoYXNodGFibGVfY291bnQoKSBpc24n dCB1c2VkIGF0IGFsbCwgc28gcmVtb3ZlIGl0DQo+PiAtIHJlcGxhY2UgcHJpbWVfdGFibGVf bGVuZ3RoIGFuZCBtYXhfbG9hZF9mYWN0b3Igd2l0aCBtYWNyb3MNCj4+IC0gbWFrZSBoYXNo KCkgc3RhdGljDQo+PiAtIGFkZCBhIGxvYWRsaW1pdCgpIGhlbHBlciBmdW5jdGlvbg0KPj4g LSByZW1vdmUgdGhlIC8qKiovIGxpbmVzIGJldHdlZW4gZnVuY3Rpb25zDQo+PiAtIGRvIHNv bWUgc3R5bGUgY29ycmVjdGlvbnMNCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdy b3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+PiAtLS0NCj4+IMKgIHRvb2xzL3hlbnN0b3JlL2hh c2h0YWJsZS5jIHwgNzEgKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0N Cj4+IMKgIHRvb2xzL3hlbnN0b3JlL2hhc2h0YWJsZS5oIHwgMTAgLS0tLS0tDQo+PiDCoCAy IGZpbGVzIGNoYW5nZWQsIDI2IGluc2VydGlvbnMoKyksIDU1IGRlbGV0aW9ucygtKQ0KPj4N Cj4+IGRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS9oYXNodGFibGUuYyBiL3Rvb2xzL3hl bnN0b3JlL2hhc2h0YWJsZS5jDQo+PiBpbmRleCAzZDQ0NjZiNTk3Li5jMWIxMTc0M2JiIDEw MDY0NA0KPj4gLS0tIGEvdG9vbHMveGVuc3RvcmUvaGFzaHRhYmxlLmMNCj4+ICsrKyBiL3Rv b2xzL3hlbnN0b3JlL2hhc2h0YWJsZS5jDQo+PiBAQCAtNDAsMjIgKzQwLDI1IEBAIHN0YXRp YyBjb25zdCB1bnNpZ25lZCBpbnQgcHJpbWVzW10gPSB7DQo+PiDCoCA1MDMzMTY1MywgMTAw NjYzMzE5LCAyMDEzMjY2MTEsIDQwMjY1MzE4OSwNCj4+IMKgIDgwNTMwNjQ1NywgMTYxMDYx Mjc0MQ0KPj4gwqAgfTsNCj4+IC1jb25zdCB1bnNpZ25lZCBpbnQgcHJpbWVfdGFibGVfbGVu Z3RoID0gc2l6ZW9mKHByaW1lcykvc2l6ZW9mKHByaW1lc1swXSk7DQo+PiAtY29uc3QgdW5z aWduZWQgaW50IG1heF9sb2FkX2ZhY3RvciA9IDY1OyAvKiBwZXJjZW50YWdlICovDQo+PiAt LyoqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqLw0KPj4gLS8qIGluZGV4Rm9yICovDQo+PiAtc3Rh dGljIGlubGluZSB1bnNpZ25lZCBpbnQNCj4+IC1pbmRleEZvcih1bnNpZ25lZCBpbnQgdGFi bGVsZW5ndGgsIHVuc2lnbmVkIGludCBoYXNodmFsdWUpIHsNCj4+ICsjZGVmaW5lIFBSSU1F X1RBQkxFX0xFTsKgwqAgQVJSQVlfU0laRShwcmltZXMpDQo+PiArI2RlZmluZSBNQVhfTE9B RF9QRVJDRU5UwqAgNjUNCj4+ICsNCj4+ICtzdGF0aWMgaW5saW5lIHVuc2lnbmVkIGludCBp bmRleEZvcih1bnNpZ25lZCBpbnQgdGFibGVsZW5ndGgsDQo+PiArwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCB1bnNpZ25lZCBpbnQgaGFzaHZhbHVlKQ0KPj4gK3sNCj4+IMKgwqDCoMKgwqAgcmV0dXJu IChoYXNodmFsdWUgJSB0YWJsZWxlbmd0aCk7DQo+PiDCoCB9DQo+PiAtLyoqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqLw0KPj4gLXN0cnVjdCBoYXNodGFibGUgKg0KPj4gLWNyZWF0ZV9oYXNo dGFibGUoY29uc3Qgdm9pZCAqY3R4LCB1bnNpZ25lZCBpbnQgbWluc2l6ZSwNCj4+IC3CoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBpbnQgKCpoYXNoZikgKGNv bnN0IHZvaWQgKiksDQo+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaW50 ICgqZXFmKSAoY29uc3Qgdm9pZCAqLCBjb25zdCB2b2lkICopLA0KPj4gLcKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVuc2lnbmVkIGludCBmbGFncykNCj4+ICtzdGF0aWMg dW5zaWduZWQgaW50IGxvYWRsaW1pdCh1bnNpZ25lZCBpbnQgcGluZGV4KQ0KPj4gK3sNCj4+ ICvCoMKgwqAgcmV0dXJuICgodWludDY0X3QpcHJpbWVzW3BpbmRleF0gKiBNQVhfTE9BRF9Q RVJDRU5UKSAvIDEwMDsNCj4+ICt9DQo+PiArDQo+PiArc3RydWN0IGhhc2h0YWJsZSAqY3Jl YXRlX2hhc2h0YWJsZShjb25zdCB2b2lkICpjdHgsIHVuc2lnbmVkIGludCBtaW5zaXplLA0K Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgIHVuc2lnbmVkIGludCAoKmhhc2hmKSAoY29uc3Qgdm9pZCAq KSwNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBpbnQgKCplcWYpIChjb25zdCB2b2lkICosIGNvbnN0 IHZvaWQgKiksDQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdW5zaWduZWQgaW50IGZsYWdzKQ0KPj4g wqAgew0KPj4gwqDCoMKgwqDCoCBzdHJ1Y3QgaGFzaHRhYmxlICpoOw0KPj4gwqDCoMKgwqDC oCB1bnNpZ25lZCBpbnQgcGluZGV4LCBzaXplID0gcHJpbWVzWzBdOw0KPj4gQEAgLTY0LDcg KzY3LDcgQEAgY3JlYXRlX2hhc2h0YWJsZShjb25zdCB2b2lkICpjdHgsIHVuc2lnbmVkIGlu dCBtaW5zaXplLA0KPj4gwqDCoMKgwqDCoCBpZiAobWluc2l6ZSA+ICgxdSA8PCAzMCkpIHJl dHVybiBOVUxMOw0KPj4gwqDCoMKgwqDCoCAvKiBFbmZvcmNlIHNpemUgYXMgcHJpbWUgKi8N Cj4+IC3CoMKgwqAgZm9yIChwaW5kZXg9MDsgcGluZGV4IDwgcHJpbWVfdGFibGVfbGVuZ3Ro OyBwaW5kZXgrKykgew0KPj4gK8KgwqDCoCBmb3IgKHBpbmRleD0wOyBwaW5kZXggPCBQUklN RV9UQUJMRV9MRU47IHBpbmRleCsrKSB7DQo+IA0KPiBBcyB5b3UgZml4IHRoZSBzdHlsZSwg aG93IGFib3V0IGFkZGluZyBhIHNwYWNlIGJlZm9yZS9hZnRlciAnPScgYW5kLi4uDQo+IA0K Pj4gwqDCoMKgwqDCoMKgwqDCoMKgIGlmIChwcmltZXNbcGluZGV4XSA+IG1pbnNpemUpIHsg c2l6ZSA9IHByaW1lc1twaW5kZXhdOyBicmVhazsgfQ0KPiANCj4gLi4uIGJyZWFrIHRoaXMg bGluZSBpbiBtdWx0aXBsZSBvbmVzPw0KDQpXaWxsIGRvIGJvdGguDQoNCj4gDQo+IFdpdGgg b3Igd2l0aG91dCB0aGlzIGluY2x1ZGVkIGhlcmU6DQo+IA0KPiBSZXZpZXdlZC1ieTogSnVs aWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4NCg0KVGhhbmtzLA0KDQoNCkp1ZXJnZW4N Cg0K --------------76X27yqS6xh0zS29YlioB0ik Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------76X27yqS6xh0zS29YlioB0ik-- --------------LReBWUmikuryo4KQO0eBI0CF-- --------------EddWgL95A5UVdSL8zjLHahIL Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmRSc6kFAwAAAAAACgkQsN6d1ii/Ey8y XwgAiROwk8wPAlouLo9qg3I+G4Ngy2oBDrZfkY6SftKQQRARuizeHq6dCNwpDVX8CAG7Gom9Nh9e KW9pOhXSjJl7G48PcKoncRh2X64K4x4VknU5PCIRCaHurTD3m7jvDu+z9zHgSh52iOcZ0PTs3NeN Z9VdeIXziC9yvMHn9Fpnnp4LGZUty9xBTJ8cjwFqnRIiprFgdDYxDgDxhvAbQYO+/1BkZay1Z1/e uo6sIcVoro4KEF0jWuEcffwsT7BIT78dZKsPcHZt93zgXuj4G9teQpkF3PapVa1cu5ukw3oXf1ai mmokGMrCQwJ1Pr2V3b4Cs+WaCt2P+z5tRNRqM6IPHw== =lYd0 -----END PGP SIGNATURE----- --------------EddWgL95A5UVdSL8zjLHahIL-- From xen-devel-bounces@lists.xenproject.org Wed May 03 14:48:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 14:48:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529270.823477 (Exim 4.92) (envelope-from ) id 1puDmd-0004d9-MF; Wed, 03 May 2023 14:48:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529270.823477; Wed, 03 May 2023 14:48:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puDmd-0004d2-IY; Wed, 03 May 2023 14:48:43 +0000 Received: by outflank-mailman (input) for mailman id 529270; Wed, 03 May 2023 14:48:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puDmc-0004cq-IS for xen-devel@lists.xenproject.org; Wed, 03 May 2023 14:48:42 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 98322c7d-e9c1-11ed-b225-6b7b168915f2; Wed, 03 May 2023 16:48:41 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DBDC02047A; Wed, 3 May 2023 14:48:40 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B603F1331F; Wed, 3 May 2023 14:48:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KQoOK0h0UmTkTwAAMHmgww (envelope-from ); Wed, 03 May 2023 14:48:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 98322c7d-e9c1-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683125320; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hB2lLaG8pUH5+daj/u8rW0lInWwuo6ot3NYeUtBZcfQ=; b=aAuHV+So7HcZC1mPG1MTlnbtcrlCdf9Pdwsh/uoKLlUK9VEwJCUvjAvdLPK1cYHbE6gXBl EK0GWD3CFjpkm7Z+/qG8ML+IVxxExUaY8MXcqIYXRQ4/n1ZnR3M26wt5QuMm0//IV2eKbG ICV4CCY67zWjsFlGM61pvQqVM8otsmg= Message-ID: <991a003c-fc7e-f922-6a5c-9a8d75c543db@suse.com> Date: Wed, 3 May 2023 16:48:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v2 04/13] tools/xenstore: let hashtable_insert() return 0 on success Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230330085011.9170-1-jgross@suse.com> <20230330085011.9170-5-jgross@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------I4fGrNu5OMWFyWrFpZNunVy4" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------I4fGrNu5OMWFyWrFpZNunVy4 Content-Type: multipart/mixed; boundary="------------6oQMX19aK3dEXiLiQ4sh08Cc"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: <991a003c-fc7e-f922-6a5c-9a8d75c543db@suse.com> Subject: Re: [PATCH v2 04/13] tools/xenstore: let hashtable_insert() return 0 on success References: <20230330085011.9170-1-jgross@suse.com> <20230330085011.9170-5-jgross@suse.com> In-Reply-To: --------------6oQMX19aK3dEXiLiQ4sh08Cc Content-Type: multipart/mixed; boundary="------------zN0jWzD3yow0FXWGwseRoJWV" --------------zN0jWzD3yow0FXWGwseRoJWV Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMDUuMjMgMTU6MDMsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGksDQo+IA0KPiBP biAzMC8wMy8yMDIzIDA5OjUwLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gVG9kYXkgaGFz aHRhYmxlX2luc2VydCgpIHJldHVybnMgMCBpbiBjYXNlIG9mIGFuIGVycm9yLiBDaGFuZ2Ug dGhhdCB0bw0KPj4gbGV0IGl0IHJldHVybiBhbiBlcnJubyB2YWx1ZSBpbiB0aGUgZXJyb3Ig Y2FzZSBhbmQgMCBpbiBjYXNlIG9mIHN1Y2Nlc3MuDQo+IA0KPiBJIHVzdWFsbHkgZmluZCBz dWNoIGNoYW5nZSByaXNreSBiZWNhdXNlIGl0IG1ha2VzIHRoZSBiYWNrcG9ydCBtb3JlIGNv bXBsZXggaWYgDQo+IHdlIGludHJvZHVjZSBhIG5ldyBjYWxsIHRvIGhhc2h0YWJsZV9pbnNl cnQoKSBhbmQgaXQgaXMgYWxzbyBxdWl0ZSBkaWZmaWN1bHQgdG8gDQo+IHJldmlldyAodGhl IGNvbXBpbGVyIHdvdWxkIG5vdCBoZWxwIHRvIGNvbmZpcm0gYWxsIHRoZSBjYWxsZXJzIGhh dmUgY2hhbmdlZCkuDQo+IA0KPiBTbyBjYW4geW91IHByb3ZpZGUgYSBjb21wZWxsaW5nIHJl YXNvbiBmb3IgZG9pbmcgdGhlIGNoYW5nZT8gKGNvbnNpc3RlbmN5IHdvdWxkIA0KPiBub3Qg YmUgb25lIElNTykNCg0KVGhlIG1vdGl2YXRpb24gd2FzIGNvbnNpc3RlbmN5LiA6LSkNCg0K VGhlIGFsdGVybmF0aXZlIHdvdWxkIGJlIHRvIHJlYWxseSBzZXQgZXJybm8gaW4gdGhlIGVy cm9yIGNhc2UsIHdoaWNoDQp3b3VsZCBhZGQgYWRkaXRpb25hbCBsaW5lcy4NCg0KSSdtIG5v dCByZWFsbHkgZmVlbGluZyBzdHJvbmcgaGVyZSwgQlRXLg0KDQoNCkp1ZXJnZW4NCg0K --------------zN0jWzD3yow0FXWGwseRoJWV Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------zN0jWzD3yow0FXWGwseRoJWV-- --------------6oQMX19aK3dEXiLiQ4sh08Cc-- --------------I4fGrNu5OMWFyWrFpZNunVy4 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmRSdEgFAwAAAAAACgkQsN6d1ii/Ey8A cwf+IpaXsnTe8X6ponzYHoHUEwlFAKBgwOiMKgF4xpAJOO683wVsgnmFHhnWvcGTEXYMdRAr5q6o 23+0XGVeVj2omMaBbIzmurEVN5joJfCDa61gQ7WGUQ/xcgBkTAfQCFR9vOb+kOZykyPsnv79Hhw4 Rn01vm1JGFowzoXxL3oUeqT5SSZIUZlMRsj/wzVBFpOjjS+XYKyW764UMkT0eS5Zam4hg1Tp56lu 4vJNsAik1t7IJ8KVjiOXfvS2yKE8jO+o7qaF3RYo7+4gTmqOS6coJ7ASsCWBHLv34ivLCM2pRUMg 7Qdq6Z+6g5DaPIuguuDD5edffmymCo743rerPVqIwg== =4IAH -----END PGP SIGNATURE----- --------------I4fGrNu5OMWFyWrFpZNunVy4-- From xen-devel-bounces@lists.xenproject.org Wed May 03 14:49:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 14:49:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529274.823487 (Exim 4.92) (envelope-from ) id 1puDn2-0005AH-1Y; Wed, 03 May 2023 14:49:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529274.823487; Wed, 03 May 2023 14:49:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puDn1-0005AA-Uv; Wed, 03 May 2023 14:49:07 +0000 Received: by outflank-mailman (input) for mailman id 529274; Wed, 03 May 2023 14:49:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puDn0-0004cq-Ba for xen-devel@lists.xenproject.org; Wed, 03 May 2023 14:49:06 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a6a03ed4-e9c1-11ed-b225-6b7b168915f2; Wed, 03 May 2023 16:49:05 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2035F22908; Wed, 3 May 2023 14:49:05 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EE8491331F; Wed, 3 May 2023 14:49:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4azQOGB0UmQlUAAAMHmgww (envelope-from ); Wed, 03 May 2023 14:49:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a6a03ed4-e9c1-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683125345; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xt+2MKOFCuUEdtIgZo1nmqQoEhcMQgz9aEUMbQS5MDY=; b=lhkJHTrsF9sknW9V/Txq3KTqB0AUTPZB+Q2DNVpch+VN/ildkeJmF2DNmz9+/8aAvxO56d ryZMoVGoLv1KH0tHk9UEUlsuSrrLnn6F5MPNzzlCAtHpXhk4qHNYLCtkxQS6FSaRaUIKJw V3tvHAAyhXdY0E4FyiY1Eg40M/u94xo= Message-ID: Date: Wed, 3 May 2023 16:49:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v2 08/13] tools/xenstore: remove unused events list Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230330085011.9170-1-jgross@suse.com> <20230330085011.9170-9-jgross@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------JnrhvwRIw6rbY9M6s0GUNiEu" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------JnrhvwRIw6rbY9M6s0GUNiEu Content-Type: multipart/mixed; boundary="------------vpwi0A7LVy2H0fP9NOAoXmwU"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: Subject: Re: [PATCH v2 08/13] tools/xenstore: remove unused events list References: <20230330085011.9170-1-jgross@suse.com> <20230330085011.9170-9-jgross@suse.com> In-Reply-To: --------------vpwi0A7LVy2H0fP9NOAoXmwU Content-Type: multipart/mixed; boundary="------------dmr02Ru0PPkiM60ng1104hgS" --------------dmr02Ru0PPkiM60ng1104hgS Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMDUuMjMgMTU6MDgsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDMwLzAzLzIwMjMgMDk6NTAsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBz dHJ1Y3Qgd2F0Y2ggY29udGFpbnMgYW4gdXNlZCBzdHJ1Y3QgbGlzdF9oZWFkIGV2ZW50cy4g UmVtb3ZlIGl0Lg0KPiANCj4gVHlwbzogcy91c2VkL3VudXNlZC8/DQoNClllcy4NCg0KPiAN Cj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+ DQo+IA0KPiBBY2tlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4NCg0K VGhhbmtzLA0KDQoNCkp1ZXJnZW4NCg0K --------------dmr02Ru0PPkiM60ng1104hgS Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------dmr02Ru0PPkiM60ng1104hgS-- --------------vpwi0A7LVy2H0fP9NOAoXmwU-- --------------JnrhvwRIw6rbY9M6s0GUNiEu Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmRSdGAFAwAAAAAACgkQsN6d1ii/Ey8c /wf/XMi1oZE6O5e/CG1N+FqpGMafzsawid5ewdeXfFIioLzzy51yshm5KaIeySxiCTn1IMeGfH3s XDz+GL74wp3a4bxN/rvxKRHTjw2DuGiNdWz6VtqYjHlpOOt5KSANGwO0lC4v/iP2F/IvBOUHxhX4 yP/iGultzMTH51A3eEBGjr0S7GispQglW1EwvIl9NFv/UXQqrthwSOqBaEHDRUV4+/q20+VxIfiS svgxeACVfM5SKAzc6vernec9UN6UNZXyEGb9i4lQmvtMM8T5+UWMfQKvl99Iib1vPAOtgknSdr9K PlS7b2kSwlQMA7H0yNz0Y6O+GaZL3MDWzTMIsE7UQg== =364L -----END PGP SIGNATURE----- --------------JnrhvwRIw6rbY9M6s0GUNiEu-- From xen-devel-bounces@lists.xenproject.org Wed May 03 14:51:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 14:51:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529278.823497 (Exim 4.92) (envelope-from ) id 1puDpa-0006ec-E1; Wed, 03 May 2023 14:51:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529278.823497; Wed, 03 May 2023 14:51:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puDpa-0006eU-BE; Wed, 03 May 2023 14:51:46 +0000 Received: by outflank-mailman (input) for mailman id 529278; Wed, 03 May 2023 14:51:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puDpY-0006eM-Qv for xen-devel@lists.xenproject.org; Wed, 03 May 2023 14:51:44 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 038539d4-e9c2-11ed-b225-6b7b168915f2; Wed, 03 May 2023 16:51:43 +0200 (CEST) Received: from mail-dm6nam11lp2176.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 May 2023 10:51:32 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM4PR03MB6911.namprd03.prod.outlook.com (2603:10b6:8:46::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.20; Wed, 3 May 2023 14:51:30 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb%4]) with mapi id 15.20.6340.031; Wed, 3 May 2023 14:51:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 038539d4-e9c2-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683125503; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=/X/3AygOT6pqvdCJTuddwvw1xXUXT6MPGOspvFfgm/0=; b=R2egYkHScXUaATCsrp/V/iUMBKHVLmtFNhi/C9M4a6fzwka+piS96tkR YmOdwckbwpuGee+2nlyynGs3wt1cNsINLLyPb4xz8NIs9CMuhrCGXXpRc jYnh9f3iODGHKFNa+cZBMYEdOUa+5emYDZ3AaNMN6Ra3MSWhZN0WGsi4r I=; X-IronPort-RemoteIP: 104.47.57.176 X-IronPort-MID: 107055755 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Wl1eBaAKzHakcBVW/xriw5YqxClBgxIJ4kV8jS/XYbTApD500mYDx mAfW2yDbviPZGDzf40nO4jg8U9XscfdyYNrQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFuspvlDs15K6p4G5A5QRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw98cpPTtX2 sIjBTkkYSLElbKcn6qnVbw57igjBJGD0II3nFhFlGicIdN4BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI+uxuvDa7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prraXwnumBd1PSdVU8NZggUShxT0PSyEtTH2WnNW5iEK/W/12f hl8Fi0G6PJaGFaQZtvyRRqju1afowURHdFXFoUS+AyLj6bZ/QudLmwFVSJaLswrstcsQj4n3 UPPmMnmbRRwtJWFRHTb8a2bxRuwJCwUIGkqdSICCwwf7LHeTJobixvOSpNvFfCzh9isQDXom WnV8m45mqkZitMN2+Oj51fbjjmwp5/PCAko+gHQWWHj5QR8DGK4W7GVBZHgxa4oBO6kopOp5 RDoR+D2ADgyMKyw IronPort-HdrOrdr: A9a23:yQ67tq13+mLSTsw58XkSnQqjBEQkLtp133Aq2lEZdPU0SKGlfg 6V/MjztCWE7gr5PUtLpTnuAsa9qB/nm6KdpLNhX4tKPzOW31dATrsSjrcKqgeIc0HDH6xmpM JdmsBFY+EYZmIK6foSjjPYLz4hquP3j5xBh43lvglQpdcBUdAQ0+97YDzrYnGfXGN9dOME/A L33Ls7m9KnE05nFviTNz0+cMXogcbEr57iaQ5uPW9a1OHf5QnYk4ITCnKjr20jbw8= X-Talos-CUID: =?us-ascii?q?9a23=3ASE7unGiihWlDWsSIKalMP5EZLjJuf1yD8C3JDHG?= =?us-ascii?q?DJG9AR4/SWw+6p7t4jJ87?= X-Talos-MUID: 9a23:Plz/oATG81mYEk8MRXTmhShQN5Z0oJiVEWYgrLkGucWFNQNZbmI= X-IronPort-AV: E=Sophos;i="5.99,247,1677560400"; d="scan'208";a="107055755" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CuWJIykQPjZ8IcNIvublUGnV4QS3JBJGPly/w8U+il/505S9OqR7UAniAbazny02AFVJlpiENX8/XOSNPulNVzaf7oSQEI+qjZ79QLnv3yi5hgzGDPPb3T9xoMAi5WpYclpS3paG/fud7nt55mF/X9+Y2Ei4ByDdxxPY2n3yutcZ8ljW3StYuJ1c7Ba8zn3M0d1vMHZUzvG/du5uQ/nUDYTFhNll5Htekio7lMk+6BLDmL+0rvI1X3L3FcwvmlI/rkDhyQ0TNzA0EACw8RnooaJloy5W/ybKeE99paDC5LEIDKBQqeuUeo2GQ3yKjo4nqtFIFA0hOOKrtrLgMK7kGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fK1HdlSFgUeNp73i8nRGTp0o0QDbjonIrKf9mR7N5pA=; b=BgePcSAcH393hYeIhFJ7I4kykyve6QhPn4Yn79hKkAv8ABHcsFPFrNn6VK0JacSj79j3220w5hIjOHBNxl+b3UnP3ftyl6akwBmBIVSMO0zQbNnthk97PAI03cCGmdK3QrVnF1e/TGWBZoLZdF77AKbUX6NzDQjG37ITfeMqQSHmhCZF246Y8VqiPpyYndAh/4J1eOq8R7TgohQ5ag+Gj98qVw5ljVHv2py/XVDBhUC9d+KnordIqqjOpWC1raj7ZWXtLw28IJE1lvTawewzF0SGW2hErVZcPvDfPDaEtvjw8gmvg0DOb4p292iUQtOMq+zg67Fy7/XbOhGQeevEaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fK1HdlSFgUeNp73i8nRGTp0o0QDbjonIrKf9mR7N5pA=; b=iw4UNMSbnLd15FjksGdVGppjkqfDb3HPXh9OC2AEB3hEpDpPwWMR9rKvI5pXX+dse7fX7tFeH12zCvWfoH5d+uXCCsaGLoKNNlEj10U91fWyWIImyjP6PdIaA3zkrgKytRCQyEyE6d7SmWR//Fj1d1XQps0vZA/+XD5qHcbBXk0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Wed, 3 May 2023 15:51:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 05/13] tools/xenstore: make some write limit functions static Content-Language: en-GB To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Julien Grall , Anthony PERARD References: <20230330085011.9170-1-jgross@suse.com> <20230330085011.9170-6-jgross@suse.com> From: Andrew Cooper In-Reply-To: <20230330085011.9170-6-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P302CA0005.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:2c2::13) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|DM4PR03MB6911:EE_ X-MS-Office365-Filtering-Correlation-Id: f1a1ee10-0972-4fca-6117-08db4be5e155 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZG7jdHrcX9EPN8D4IvDEoV8MlBtnERv2gKHtPPQIgM73SnfsC73/76dQw0rI2B3xkLhpKcxbg9BxK1ionl6qjMOgpP8DZNux0m5//QF7n616HItA9WpvWhM50LX2raPnkpn3Xi0uIiASouUdB+eieY3zoNnRTDVwvx6p92tpafJM5U6EIj6pun6GcuINeyS4HvRVMmt05cpMleQ5p475GXFNkgyElTGp3FxRDj4BQULfpiVBnSqD3T7d/JpMQH4QKjUoIduX3vOigX8nclHs932t1NxRUzAfNZHs/xsz3ha4/WcefoufmAVQnp1S9uuXP5YvWYjflADGbxJguGAw7GTDPiKBL7czwF5eMP+Tcsm9D8RwACwQdH9uUSmZPDlWYqWme9h6O2XCs/VKkp1WEKmsplfh+vMKeBAy1Ku9Uvowf0pGKQyfCdodm4vvQ/akZONCbwhJxQVOymV9d0IMwEoEB9+i6QMoWacwoXxTHz+bPj36c7VDaT/hwf6ttTDM/0bgwtgpYa91ZYI4xFmp/8RavXTW6hexpUCn/XwnP9JLn8C3sDCc+mu8N/7rDpULCO8Ou1oT/TlfYmXXbU5+5dOcO59Yy2+tBvszUuw7a56LLA69j5hvmbRAyvNzEaSTqIqO5BAsg9hcWHln0gqLlQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(39860400002)(346002)(376002)(396003)(366004)(451199021)(5660300002)(2616005)(86362001)(31696002)(6506007)(107886003)(186003)(26005)(6512007)(82960400001)(53546011)(38100700002)(8676002)(8936002)(54906003)(6486002)(36756003)(41300700001)(4326008)(316002)(6666004)(478600001)(31686004)(66556008)(66946007)(66476007)(2906002)(4744005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R0luREsrWlFPOHFTMnBLNzB3cS9GL3hDRk5QVkh3L04rQjJhWnN3eWl1d3gv?= =?utf-8?B?OVUxY25RbThlZnJUT2ozcXBnb25Qbk05NlZ5blpFR2VncmZnMHlSRGUyMXdT?= =?utf-8?B?eEhzbzd5bElSeXFkcFo2ZXZRS3RFQzA2UjVxdk5zTkI3STQ5c2dPR1dvUWhM?= =?utf-8?B?R1FkZmZJVVJvZE5QaVVrS0t4QlNZby9NZDFhY0FGbVlpZFRTQ2VRdklueVNO?= =?utf-8?B?R095bmEvWWpUeGYrN3hnWHVPOUN1dWcxbmRpYys3VHhPSVd3QXpobXQ4Vy9s?= =?utf-8?B?VitnVWFxY0QxZlc3ZGhqOUdxdTVRTlRsemoraDlVb1FaY0U1OW5Hd0VDbXJ3?= =?utf-8?B?Y0xRY2FSRmxiczRNMmdyUGZXS3NrOHpVSnJBNVF6WlZwalFiWmNDbnM2V1RM?= =?utf-8?B?QStocUxMUEhDaXBOK015WXY1QlRvcnpiSEZ3dUlwNEVSY1QyZDd4VVUwNCsz?= =?utf-8?B?M2RUL3FkVW5PWWZleUkxMGU5QUZpMW5IMldhYjE0YlNMdmJNNTV2bXg0dXBr?= =?utf-8?B?RlZmV0pYS3lSRlhRMktsN3JXWC9KMDBWY09UOUlXU0p2MFZpT01kN2NSV1Av?= =?utf-8?B?dHlhMXc1QmFqaENNQ3E2Z2hBeTYxQTJDVjJJTWZlWm0zSzhXUVNYeWZoVysz?= =?utf-8?B?UjJ5M1J1NTJyUFRJUS9rWjh2Q2J3WHZaV0N6SEJ5ZktnMHI3V2hBM0pUOUE4?= =?utf-8?B?OWFxamQyWkdyOFZrdkd3RkNDeW5CTGtKR2RuR2RGTUlqU2ZSQmFHckxxbWVS?= =?utf-8?B?cDdzeThOVXpJZDMrcWROeE4rSEZwQmd5QlpnMTZRbjladjNCTk8zMUFFcStE?= =?utf-8?B?b1dCUjRpRmRlWld1OXlBcHBNRjFaL2ZXQldia1BtanVrYVZFaDBSQ1ZiOEE1?= =?utf-8?B?TWtGVTY4ek9zNHhjeDYvWi9aTkVmRXRWbzdldnBXMlB2enBUWE9qUTVKM0p6?= =?utf-8?B?KzQxSzVySzg3eitEblpXWHBjVWtmMy83N3ZZWjJrMWkxRUZMT2NGZkZUcVVQ?= =?utf-8?B?elN1QUF5MXM3R013TTNHenFHRFZ5OTlmQ3ZIOVVWdnNUZm4zNWc3eE96Qmls?= =?utf-8?B?WFJTZERvSDBOQ1UwZldWaEl6RjVWaWFXcnpnc1djTUg5UHk3YnZyOFZMMmxW?= =?utf-8?B?NllRSnBhdGIxRGRzQjZGUSt6UldpU0p4Tk9zWEdtemFqNUdSUWszUDlSUTQ2?= =?utf-8?B?WnFYdDRZL1lGbGk1ZVpzWmFnS3ZTS1lTcnJPbE1OSUVCL1ovNEV6Yk5hbFNE?= =?utf-8?B?dUhWcEt2c1hlZkYvUzg2RmsvQi93RnRJUlJYV2N1NXdraW94eVNNM0R6Y2Ri?= =?utf-8?B?VHB3NmxkV3AwdVdzK2tHZWVZa0xCWkRQSFpxaFcvVmc2SXl4SU1icVUwdjI5?= =?utf-8?B?QXNaSkJYKzE2cG9rNDlCdTdGSWVOT01DaGpNK2NpNSs2Z3h1ODZJbERtdXlm?= =?utf-8?B?LzhpQVZBSGJpMjF0akpYTVBTY3FkbUFnWXpQVEZEaEo4QU5KczNvL0FjSVAv?= =?utf-8?B?N2pEYWkyZlFyaGlPaDVONkF4THZreHdwaTFnWnNNaU5iRWRVdTlvR2RleGxZ?= =?utf-8?B?VGxKZk1oSi94dXFCd0U3TFVPN1U5WnJ4STNkUGNwVW9CZEFlcjVlYzhhc0hE?= =?utf-8?B?WG81cHlaTXNwa1VSTnIzNitoc1dsSlVnNG50VkpybmZOSTg1bzJwSkNLcVNh?= =?utf-8?B?WTRiT0N2U2VVbzBZbDlmRkRDbC9QbzY3eXBXS0RrdnJnU1MzZmRmWFNTUmZo?= =?utf-8?B?bmZkeTNqNVllQklUNFlNY2VDOWFpNHhjb2JsVVNVZENmTmlQQU5RTEhTNU9h?= =?utf-8?B?YlppV2dDNFAzNHhlRFVaYzVvVXVrYWd0czMvTHllaWh0Um5sc0ZiMlNrL0ZU?= =?utf-8?B?cGxMR3EyeFQ4Z0RwVSsxWEJFanI3eTI2VHhoQzVaczEzY2VkMUtsTEhIT2RF?= =?utf-8?B?NFB0QlZYMVg4U0Y0bTFvZVJIZEoyTjdZbGZFR1oyN0ZTYjRmeVFoZURSV09X?= =?utf-8?B?blNBc1VwcXA3bEg2Mk1nNlJlSlZKenczb1g5RHFnS2VHcVAzSmtZaVJqTDhV?= =?utf-8?B?eTFUbitaZktERytpNk1aRnRqZ3JvNjNUbUovN2NsUHBXNzJ2em91dEVhQklo?= =?utf-8?B?WEc5MHlqMmZ3Yjc3NWZrN3RyU3N2anVEbmxxcGxRdjVQZklyYnNJZDhCV2Qx?= =?utf-8?B?cHc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 2TO8NoFPeYkmIJmzyyjrDALsH2pbEteKu5AZfWJwqzDhijoG70mLIphbeswOgik/BKrwYC5pnYw/cgJbILCKGU9ZOgYitNAgYyFOhetai5HUa1+gYiG2l78BqJevNSud1anMHYFYsD6mt6CSzICZQGodAYmPTkr6Xne9GWqn8FQ0nvOgQhrxX9Ps//Xbfuk+EnrDc5uHKXtyoqyL6DJDjQUIAIeuzakuvIOtqGtwBVO1YXbHlnSVyj4cvFUkm0Z4E8bEp3VU8YcA7T6/4XuTgow3fl4Y4DzwYMXgmZcRE2KH/jIpiJ16OhgEFCTe9i081HFP4i8PS0teLwSX7NONKqV73eHcgBhAhWAK/7MYqUDJEnYJ1ISvN6gFVitwnpwtArAWUC9yl86UcXEN1uudM73KIKAnBNCQAW34MEUBA8jekTTSw/FEVZUm6NWF9AyeqKZefNADuXMl1guRljhN9fnO8WjiqEvHcIhwOMGUxT5ZiQ3X/3EFNEIvNI6AJFb7xhtIWoE+TDUJt6pl4Y7jjtIF97+EW8QatQ74pwspxGPu0uiYsoCF1EVH40f1C2jlzOZ5GAyik4CG1PlK2JU8vPnBR/S+/TwAEAQVuU7lUN+Xnpc6hjTSnDTZHjNk/qNlEeAA2XVJiRJCT2OPWHZpDFjlnJMZBC9sWx3GIVk0pT7pILTG/lSfWK7ULLVlBZK2tBuQ3Eo92fxCkgaHXOzuuaATrcz0AKAAzlAzANFgu0TKLsDMEr7FCDL2ZpBqNE3TSXeOwWECb2pACiuyiDRRcYh5MeAZn51KSD96bcsBMOJ55ldRcENx4ahVPtZyVk0A X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f1a1ee10-0972-4fca-6117-08db4be5e155 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 14:51:30.6006 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JH2o1c7mmSgtRswSWXKK0fxFmUU2JUV7Ssf6s18Ubz5o3TbwqMYVf72H+AlMR4Dz+HxTYNG4ceLFs9hx/NukDjqa/KACg0lMN2rIP3BhKds= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6911 On 30/03/2023 9:50 am, Juergen Gross wrote: > +static void wrl_xfer_credit(wrl_creditt *debit, wrl_creditt debit_floor, > + wrl_creditt *credit, wrl_creditt credit_ceil) > + /* > + * Transfers zero or more credit from "debit" to "credit". > + * Transfers as much as possible while maintaining > + * debit >= debit_floor and credit <= credit_ceil. > + * (If that's violated already, does nothing.) > + * > + * Sufficient conditions to avoid overflow, either of: > + * |every argument| <= 0x3fffffff > + * |every argument| <= 1E9 > + * |every argument| <= WRL_CREDIT_MAX > + * (And this condition is preserved.) > + */ > +{ > + wrl_creditt xfer = MIN( *debit - debit_floor, > + credit_ceil - *credit ); MIN() evaluates its parameters multiple times.  I believe the only legal way for the compiler to emit this code is to interleave double reads. As with pretty much any C code, you want to read the pointers into locals first, then operate on them, then write them out at the end. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed May 03 14:54:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 14:54:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529281.823507 (Exim 4.92) (envelope-from ) id 1puDs2-0007DU-R5; Wed, 03 May 2023 14:54:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529281.823507; Wed, 03 May 2023 14:54:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puDs2-0007DN-OF; Wed, 03 May 2023 14:54:18 +0000 Received: by outflank-mailman (input) for mailman id 529281; Wed, 03 May 2023 14:54:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puDs1-0007DH-Ew for xen-devel@lists.xenproject.org; Wed, 03 May 2023 14:54:17 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5f75e5cb-e9c2-11ed-8611-37d641c3527e; Wed, 03 May 2023 16:54:15 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 17EEC2291F; Wed, 3 May 2023 14:54:15 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D93C01331F; Wed, 3 May 2023 14:54:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id +SafM5Z1UmQTUwAAMHmgww (envelope-from ); Wed, 03 May 2023 14:54:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5f75e5cb-e9c2-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683125655; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4lwZKYFnvfyzxvRQhR5IxeQ9hEUssK/wK2hS9nUgYfE=; b=SaExl2Xq7Kl3oT54ki1tokQuO5gTsqAKDuV6ZP5A1ZT1y30gRZHpn4xyol0w22NZy1qk2u H+PBiXZzBzBKCQgcQfasRsiU8k1ZuflH+Pcat3kJHHrpzomD87LjLVglg1jIfFDi2Bt/Ab tjYtk7pjmhrg/gzenaczb6LQF/VheuA= Message-ID: <65f15210-2a7a-4629-1ee0-628fb0ccb8b4@suse.com> Date: Wed, 3 May 2023 16:54:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v2 05/13] tools/xenstore: make some write limit functions static Content-Language: en-US To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Wei Liu , Julien Grall , Anthony PERARD References: <20230330085011.9170-1-jgross@suse.com> <20230330085011.9170-6-jgross@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------iUv8k4vJcnYY1mZGZ8drVHpb" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------iUv8k4vJcnYY1mZGZ8drVHpb Content-Type: multipart/mixed; boundary="------------uur77b6610Ll2FVVs7I0Gkdo"; protected-headers="v1" From: Juergen Gross To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Wei Liu , Julien Grall , Anthony PERARD Message-ID: <65f15210-2a7a-4629-1ee0-628fb0ccb8b4@suse.com> Subject: Re: [PATCH v2 05/13] tools/xenstore: make some write limit functions static References: <20230330085011.9170-1-jgross@suse.com> <20230330085011.9170-6-jgross@suse.com> In-Reply-To: --------------uur77b6610Ll2FVVs7I0Gkdo Content-Type: multipart/mixed; boundary="------------02RPCUk7hmNjeWEFo5EoNtf6" --------------02RPCUk7hmNjeWEFo5EoNtf6 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMDUuMjMgMTY6NTEsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+IE9uIDMwLzAzLzIw MjMgOTo1MCBhbSwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4+ICtzdGF0aWMgdm9pZCB3cmxf eGZlcl9jcmVkaXQod3JsX2NyZWRpdHQgKmRlYml0LCAgd3JsX2NyZWRpdHQgZGViaXRfZmxv b3IsDQo+PiArCQkJICAgIHdybF9jcmVkaXR0ICpjcmVkaXQsIHdybF9jcmVkaXR0IGNyZWRp dF9jZWlsKQ0KPj4gKwkvKg0KPj4gKwkgKiBUcmFuc2ZlcnMgemVybyBvciBtb3JlIGNyZWRp dCBmcm9tICJkZWJpdCIgdG8gImNyZWRpdCIuDQo+PiArCSAqIFRyYW5zZmVycyBhcyBtdWNo IGFzIHBvc3NpYmxlIHdoaWxlIG1haW50YWluaW5nDQo+PiArCSAqIGRlYml0ID49IGRlYml0 X2Zsb29yIGFuZCBjcmVkaXQgPD0gY3JlZGl0X2NlaWwuDQo+PiArCSAqIChJZiB0aGF0J3Mg dmlvbGF0ZWQgYWxyZWFkeSwgZG9lcyBub3RoaW5nLikNCj4+ICsJICoNCj4+ICsJICogU3Vm ZmljaWVudCBjb25kaXRpb25zIHRvIGF2b2lkIG92ZXJmbG93LCBlaXRoZXIgb2Y6DQo+PiAr CSAqICB8ZXZlcnkgYXJndW1lbnR8IDw9IDB4M2ZmZmZmZmYNCj4+ICsJICogIHxldmVyeSBh cmd1bWVudHwgPD0gMUU5DQo+PiArCSAqICB8ZXZlcnkgYXJndW1lbnR8IDw9IFdSTF9DUkVE SVRfTUFYDQo+PiArCSAqIChBbmQgdGhpcyBjb25kaXRpb24gaXMgcHJlc2VydmVkLikNCj4+ ICsJICovDQo+PiArew0KPj4gKwl3cmxfY3JlZGl0dCB4ZmVyID0gTUlOKCAqZGViaXQgICAg ICAtIGRlYml0X2Zsb29yLA0KPj4gKwkJCSAgICAgICAgY3JlZGl0X2NlaWwgLSAqY3JlZGl0 ICAgICAgKTsNCj4gDQo+IE1JTigpIGV2YWx1YXRlcyBpdHMgcGFyYW1ldGVycyBtdWx0aXBs ZSB0aW1lcy7CoCBJIGJlbGlldmUgdGhlIG9ubHkgbGVnYWwNCj4gd2F5IGZvciB0aGUgY29t cGlsZXIgdG8gZW1pdCB0aGlzIGNvZGUgaXMgdG8gaW50ZXJsZWF2ZSBkb3VibGUgcmVhZHMu DQo+IA0KPiBBcyB3aXRoIHByZXR0eSBtdWNoIGFueSBDIGNvZGUsIHlvdSB3YW50IHRvIHJl YWQgdGhlIHBvaW50ZXJzIGludG8NCj4gbG9jYWxzIGZpcnN0LCB0aGVuIG9wZXJhdGUgb24g dGhlbSwgdGhlbiB3cml0ZSB0aGVtIG91dCBhdCB0aGUgZW5kLg0KDQp4ZW5zdG9yZWQgaXMg c2luZ2xlLXRocmVhZGVkLiBTbyBubyBuZWVkIHRvIHdvcnJ5IGhlcmUuDQoNCg0KSnVlcmdl bg0KDQo= --------------02RPCUk7hmNjeWEFo5EoNtf6 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------02RPCUk7hmNjeWEFo5EoNtf6-- --------------uur77b6610Ll2FVVs7I0Gkdo-- --------------iUv8k4vJcnYY1mZGZ8drVHpb Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmRSdZYFAwAAAAAACgkQsN6d1ii/Ey9q Mwf+NEeKKQ7yqLna3vKVq3tKT5dHf7OXthyBNL8pa2Klur8q5FcZdWdBZjFh0IaJqiVFiUNaGeX8 TruPzEuHOcHja6FLiJyzADpLtUqebzs1/isVBVdykLSqF5vf/o2jSF/zOkK608hfOgNkA6qvX964 tAdyZ2vFySWs9EhLZsU/TGwmNGo/asR2DYnggUcleLtEPs7bXesJoJh59ZC75YUDU3D6duQ7FZtu 2xnOIT5ZTsUVRLny6XSV8y+wgaXCKIs/shTRGNfnaoHsMt71YlOaL3gvYn9jEzC4u5N3IzpvZALw SgGd3GYym+AMEQmKuctrW6cnDZj502B78lep5zmwgQ== =3xuG -----END PGP SIGNATURE----- --------------iUv8k4vJcnYY1mZGZ8drVHpb-- From xen-devel-bounces@lists.xenproject.org Wed May 03 15:02:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 15:02:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529285.823517 (Exim 4.92) (envelope-from ) id 1puDze-0000NA-QI; Wed, 03 May 2023 15:02:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529285.823517; Wed, 03 May 2023 15:02:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puDze-0000N3-M3; Wed, 03 May 2023 15:02:10 +0000 Received: by outflank-mailman (input) for mailman id 529285; Wed, 03 May 2023 15:02:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puDzd-0000Mx-II for xen-devel@lists.xenproject.org; Wed, 03 May 2023 15:02:09 +0000 Received: from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de [85.215.255.20]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7849e45f-e9c3-11ed-8611-37d641c3527e; Wed, 03 May 2023 17:02:06 +0200 (CEST) Received: from sender by smtp.strato.de (RZmta 49.4.0 AUTH) with ESMTPSA id x6987cz43F1sivZ (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Wed, 3 May 2023 17:01:54 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7849e45f-e9c3-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1683126114; cv=none; d=strato.com; s=strato-dkim-0002; b=an3Si/DZaCH9pneAM2ENpePOMfOaZa3AqjW2ZOatMWSZjVpyNM67SFvneQ2TG1R6ns a5/y296PLUGefDtOel9H0Bq5qpvuUtrYPl45LiYkjVwoqxAPGDDMU9oLbiqiadRX9WBN a45gNROs6dbRgLUxkpXqEHd2G3El65Ye1VtPO1rA2rf2JmhT6zLsa5Q/5vUqtMYLnI1J NR4rSCzfSLzIRE/JRglCKKYZhBH8+PBk63G2Zwl+hiKsZLDgE7OracoM25zD9jw0vqu4 GPSfrIt9CBsjPX3r1lYpcLpGbVdPXLuEyFLl9mxweE4KqcK+4wA7BFPyFOx1GbmX3Hdm uXZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1683126114; s=strato-dkim-0002; d=strato.com; h=Message-Id:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=n+NGG3DQPZc+9Rhhl9b5pYee5RxxjvFCd1OK5V3cABk=; b=tYOI7l4mnIlwWPP2R9bd0LxGM5EIKKxU/38cbULkB/wbY6q8PIA/d/GYi2Tmk+75Wn krowxG79KasyoaWG59yNEAxTuCH1HCC93uscrw8MgsM7pynAleOg8cnBDevFKERLG8V9 Ss4dPh8X8eju60Q5+wQY82FumUikBXi8Gk/vTftt0YBRhngzc47QKr6o07YRwo5fRTeE 43CaqutIvvFafc9K7rdMu98Lo7yJr0MtR/MUVMe8TxpIKzHAGnuo6GgnmgeDiVlzBi22 4bmxBBb0hmyPmYcwM/F4chhxZCBfuxwynQlKo7rU7SycmvD/DoUkxW6NQPOzibAdO5Pd L9jA== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1683126114; s=strato-dkim-0002; d=aepfle.de; h=Message-Id:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=n+NGG3DQPZc+9Rhhl9b5pYee5RxxjvFCd1OK5V3cABk=; b=TwqpkV9ug89fcyLYQDObqODL/gjAl5sWmoKuMUOfMOgoeZcolvstn32mO+JzHJ9y7F emDjSSgB63OHF6aLZAhY8zOEX149SnVPN8t1w7Q+Ji+ztysf61onHr7DMloLguAZAnSp 8V0KWR0TfPbnDTWQwBG9W0/0oe1o3dow3KeFb+Lkuxz8IXaRLYbWgU3TjP5GeD8afUNS C2etHiuduuDJE8XHRPIM7EBQDnFGvPLYP34J+qkhNOA5YJuKiS+gYgUBVTSQkPzpvLfl x37KOnrQbT0KPUYw8shGFUJjZG/ygx3JPgD0Een/FZLKRyOWF226YaBiUebgT9896CJM +u+A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1683126114; s=strato-dkim-0003; d=aepfle.de; h=Message-Id:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=n+NGG3DQPZc+9Rhhl9b5pYee5RxxjvFCd1OK5V3cABk=; b=wC8s4YqIb8NF+7s79yfRMixs7jT1xwEizl+opuOr9Hzp8EA4X61a0D70gEtzXL5m2F R5CDEjEVQEyQ8TTYBRCQ== X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg4wqVv7FZ8tH5EUSbMVU80kUr7f4QlYaI60OjHt/Q==" From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD , Juergen Gross , George Dunlap Subject: [PATCH v1] tools: convert bitfields to unsigned type Date: Wed, 3 May 2023 15:01:42 +0000 Message-Id: <20230503150142.4987-1-olaf@aepfle.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="us-ascii" clang complains about the signed type: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Wsingle-bit-bitfield-constant-conversion] The potential ABI change in libxenvchan is covered by the Xen version based SONAME. The xenalyze change follows the existing pattern in that file. Signed-off-by: Olaf Hering --- tools/include/libxenvchan.h | 6 +++--- tools/xentrace/xenalyze.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/include/libxenvchan.h b/tools/include/libxenvchan.h index 30cc73cf97..3d3b8aa8dd 100644 --- a/tools/include/libxenvchan.h +++ b/tools/include/libxenvchan.h @@ -79,11 +79,11 @@ struct libxenvchan { xenevtchn_handle *event; uint32_t event_port; /* informative flags: are we acting as server? */ - int is_server:1; + unsigned int is_server:1; /* true if server remains active when client closes (allows reconnection) */ - int server_persist:1; + unsigned int server_persist:1; /* true if operations should block instead of returning 0 */ - int blocking:1; + unsigned int blocking:1; /* communication rings */ struct libxenvchan_ring read, write; /** diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c index 12dcca9646..1b4a188aaa 100644 --- a/tools/xentrace/xenalyze.c +++ b/tools/xentrace/xenalyze.c @@ -1377,7 +1377,7 @@ struct hvm_data { tsc_t exit_tsc, arc_cycles, entry_tsc; unsigned long long rip; unsigned exit_reason, event_handler; - int short_summary_done:1, prealloc_unpin:1, wrmap_bf:1; + unsigned short_summary_done:1, prealloc_unpin:1, wrmap_bf:1; /* Immediate processing */ void *d; From xen-devel-bounces@lists.xenproject.org Wed May 03 15:14:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 15:14:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529291.823526 (Exim 4.92) (envelope-from ) id 1puEBO-0001t3-Rp; Wed, 03 May 2023 15:14:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529291.823526; Wed, 03 May 2023 15:14:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puEBO-0001sw-P8; Wed, 03 May 2023 15:14:18 +0000 Received: by outflank-mailman (input) for mailman id 529291; Wed, 03 May 2023 15:14:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puEBN-0001sm-8P; Wed, 03 May 2023 15:14:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puEBM-0005nh-Vg; Wed, 03 May 2023 15:14:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puEBM-0003vb-L3; Wed, 03 May 2023 15:14:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1puEBM-00017q-Kd; Wed, 03 May 2023 15:14:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=CkX0CWQN5dGu+QHwRrHu9ztnqAXvkdTUDXKsdzfAlnI=; b=Tv2jSXdjf/SXsK4amjgx/cjkad bAu2qs85koQKsyShR17BO6Y5xCNz9pedga6/Tmqo43U7OMLJZMVAQ239D2EHb/WBhwIXW5oOKIOE9 3rh8HBdexM4siePQxBRgaQ765Dz9mzxNR6gdu8+H+87ioihEhJjmnK4KOrALB/1jiGXI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180511: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-livepatch:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=b033eddc9779109c06a26936321d27a2ef4e088b X-Osstest-Versions-That: xen=b033eddc9779109c06a26936321d27a2ef4e088b From: osstest service owner Date: Wed, 03 May 2023 15:14:16 +0000 flight 180511 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/180511/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-livepatch 7 xen-install fail in 180506 pass in 180511 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail pass in 180506 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180506 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180506 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180506 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180506 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180506 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180506 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 180506 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 180506 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180506 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 180506 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180506 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180506 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: xen b033eddc9779109c06a26936321d27a2ef4e088b baseline version: xen b033eddc9779109c06a26936321d27a2ef4e088b Last test of basis 180511 2023-05-03 01:53:22 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Wed May 03 15:14:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 15:14:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529289.823537 (Exim 4.92) (envelope-from ) id 1puEBt-0002J4-51; Wed, 03 May 2023 15:14:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529289.823537; Wed, 03 May 2023 15:14:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puEBt-0002Ix-2C; Wed, 03 May 2023 15:14:49 +0000 Received: by outflank-mailman (input) for mailman id 529289; Wed, 03 May 2023 15:11:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puE8t-0001rK-Ob for xen-devel@lists.xenproject.org; Wed, 03 May 2023 15:11:43 +0000 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [2a00:1450:4864:20::32f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cf90cd04-e9c4-11ed-b225-6b7b168915f2; Wed, 03 May 2023 17:11:42 +0200 (CEST) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-3f192c23fffso33825995e9.3 for ; Wed, 03 May 2023 08:11:42 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id d15-20020adfe84f000000b002fb60c7995esm34427038wrn.8.2023.05.03.08.11.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 May 2023 08:11:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cf90cd04-e9c4-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683126702; x=1685718702; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=omxGsHaKkcGC+xqSddM+y0Rv4lJTnT54/CknYbjXVhY=; b=YfDzGylBhlR3CVxpMMI4acCmCfqTfHfM5iBfgOCW6OyIloOXcvH8dEmNrR80OObTjK IwiUIcA3EAalQUC1fcg6MNtj8x4BJYd3sJPyd1U6v+NcbtOe5wHOosZpqzvgGp8d60s/ GEuDIhroTKLKU3RLl3Q1FYflOwqkteq5501Hv7jKKV+O+4lgokZlz6LlAf+t4oJvNHp0 ZWyt5MEIYS7GLmms+q9eXjK+KzyG/JMYwSlML9xXTrZnmx3fQyKd5U046ZCENMYczcQL jcsxZ8mDjvZC0tP1ENbJbTfiTKJKjO/AZbTZ0Prl4nDNDNwD+/yjN0s7b2KBvKuTLtdC JPDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683126702; x=1685718702; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=omxGsHaKkcGC+xqSddM+y0Rv4lJTnT54/CknYbjXVhY=; b=RmCb0C9AyrlrhUXPumuOMPebQTYtdtXm62T9O1nJYIH2SkJxLep/u7zTMj5A5jDJlC 6+oRe7WVe7JYp+r37ZTzFSRSNOZZk2giURZ2kOQTJ4p2honMbO2au+Jz5jNXN6U5Xc8Y IpYNFndVbQPy1DsugbWHsYPO4ThMqAjj4LvnC/iFXcmUBLvpNq0QeEZJWNn19bF1Vt9I iTEEo/yog2kjOKTBPmDhAduEqI9DAcnT62mCXfju4/EG9J9LmU5aWxxBN+of6mlcKfiM WGVQYkNJNDt4lPRp+7vqKeCUk/l1q+GDzQG1gqSCxCJm+3o7p3YoDEFf9B5mbDJfZSSt Mheg== X-Gm-Message-State: AC+VfDy2HybHgahXaThD4ADmZOxYn8j6YW7nyc5g34HbztCHBV+sKcgf hhgugVTsbrAn7SeoDAaeUsS2fw== X-Google-Smtp-Source: ACHHUZ5OZVQBtqAWZgaLWLuVjAfGEiqAlM8i3902hJEurNrW2MxWTzUvvq1ZwT17Z0WElKBzUOcmHw== X-Received: by 2002:adf:dd4c:0:b0:2f6:8834:5952 with SMTP id u12-20020adfdd4c000000b002f688345952mr361499wrm.8.1683126701992; Wed, 03 May 2023 08:11:41 -0700 (PDT) Date: Wed, 3 May 2023 18:11:35 +0300 From: Dan Carpenter To: Stefano Stabellini Cc: Juergen Gross , Oleksandr Tyshchenko , Boris Ostrovsky , xen-devel@lists.xenproject.org, kernel-janitors@vger.kernel.org Subject: [PATCH] xen/pvcalls-back: fix double frees with pvcalls_new_active_socket() Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding In the pvcalls_new_active_socket() function, most error paths call pvcalls_back_release_active(fedata->dev, fedata, map) which calls sock_release() on "sock". The bug is that the caller also frees sock. Fix this by making every error path in pvcalls_new_active_socket() release the sock, and don't free it in the caller. Fixes: 5db4d286a8ef ("xen/pvcalls: implement connect command") Signed-off-by: Dan Carpenter --- drivers/xen/pvcalls-back.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c index 1f5219e12cc3..7beaf2c41fbb 100644 --- a/drivers/xen/pvcalls-back.c +++ b/drivers/xen/pvcalls-back.c @@ -325,8 +325,10 @@ static struct sock_mapping *pvcalls_new_active_socket( void *page; map = kzalloc(sizeof(*map), GFP_KERNEL); - if (map == NULL) + if (map == NULL) { + sock_release(sock); return NULL; + } map->fedata = fedata; map->sock = sock; @@ -418,10 +420,8 @@ static int pvcalls_back_connect(struct xenbus_device *dev, req->u.connect.ref, req->u.connect.evtchn, sock); - if (!map) { + if (!map) ret = -EFAULT; - sock_release(sock); - } out: rsp = RING_GET_RESPONSE(&fedata->ring, fedata->ring.rsp_prod_pvt++); @@ -561,7 +561,6 @@ static void __pvcalls_back_accept(struct work_struct *work) sock); if (!map) { ret = -EFAULT; - sock_release(sock); goto out_error; } -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Wed May 03 15:15:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 15:15:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529298.823547 (Exim 4.92) (envelope-from ) id 1puECX-0002xY-JF; Wed, 03 May 2023 15:15:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529298.823547; Wed, 03 May 2023 15:15:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puECX-0002xR-GQ; Wed, 03 May 2023 15:15:29 +0000 Received: by outflank-mailman (input) for mailman id 529298; Wed, 03 May 2023 15:15:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puECV-0002wu-Lv for xen-devel@lists.xenproject.org; Wed, 03 May 2023 15:15:27 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puECR-0005qG-T8; Wed, 03 May 2023 15:15:23 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.7.72]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1puECR-0001Ng-KE; Wed, 03 May 2023 15:15:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=nIC/YWeeZCwRzdVGnmO3ranVa2mAyxX8vWqqRl7z65g=; b=ZoinoO1kru205KIRLGGkkYOr05 mgcw4CV/vDzgUVEGElf4q9zwXk6Rty5M8N7GijXNoGiHYtriNOkJXMpnMDhfa6PjlOOg5a4t05Wup 0aTzZikFJTod+pR/ETpK/WZC9uZoO9jEFIfAlc+h1v1PseVv/05G7yCxqdchNV6dsxoQ=; Message-ID: <28235d38-ad7f-f1bd-f093-bd83f9fd6589@xen.org> Date: Wed, 3 May 2023 16:15:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: dom0less vs xenstored setup race Was: xen | Failed pipeline for staging | 6a47ba2f Content-Language: en-US To: andrew.cooper3@citrix.com, Stefano Stabellini , alejandro.vallejo@cloud.com Cc: committers@xenproject.org, michal.orzel@amd.com, xen-devel@lists.xenproject.org, Julien Grall , Juergen Gross , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jan Beulich , =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= References: <644bfbc6939d8_2a49bbb403253f4@gitlab-sidekiq-catchall-v2-78885c497-qxnp2.mail> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 03/05/2023 15:38, andrew.cooper3@citrix.com wrote: > Hello, > > After what seems like an unreasonable amount of debugging, we've tracked > down exactly what is going wrong here. > > https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/4219721944 > > Of note is the smoke.serial log around: > > io: IN 0xffff90fec250 d0 20230503 14:20:42 INTRODUCE (1 233473 1 ) > obj: CREATE connection 0xffff90fff1f0 > *** d1 CONN RESET req_cons 00000000, req_prod 0000003a rsp_cons > 00000000, rsp_prod 00000000 > io: OUT 0xffff9105cef0 d0 20230503 14:20:42 WATCH_EVENT > (@introduceDomain domlist ) > > XS_INTRODUCE (in C xenstored at least, not checked O yet) always > clobbers the ring pointers.  The added pressure on dom0 that the > xensconsoled adds with it's 4M hypercall bounce buffer occasionally > defers xenstored long enough that the XS_INTRODUCE clobbers the first > message that dom1 wrote into the ring. > > The other behaviour seen was xenstored observing a header looking like this: > > *** d1 HDR { ty 0x746e6f63, rqid 0x2f6c6f72, txid 0x74616c70, len > 0x6d726f66 } > > which was rejected as being too long.  That's "control/platform" in > ASCII, so the XS_INTRODUCE intersected dom1 between writing the header > and writing the payload. > > > Anyway, it is buggy for XS_INTRODUCE to be called on a live an > unsuspecting connection.  It is ultimately init-dom0less's fault for > telling dom1 it's good to go before having waited for XS_INTRODUCE to > complete. So the problem is xenstored will set interface->connection to XENSTORE_CONNECTED before finalizing the connection. Caqn you try the following, for now, very hackish patch: diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index f62be2245c42..bbf85bbbea3b 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -688,6 +688,7 @@ static struct domain *introduce_domain(const void *ctx, talloc_steal(domain->conn, domain); if (!restore) { + domain_conn_reset(domain); /* Notify the domain that xenstore is available */ interface->connection = XENSTORE_CONNECTED; xenevtchn_notify(xce_handle, domain->port); @@ -730,8 +731,6 @@ int do_introduce(const void *ctx, struct connection *conn, if (!domain) return errno; - domain_conn_reset(domain); - send_ack(conn, XS_INTRODUCE); return 0; Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 03 15:22:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 15:22:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529301.823556 (Exim 4.92) (envelope-from ) id 1puEJb-0004WW-9o; Wed, 03 May 2023 15:22:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529301.823556; Wed, 03 May 2023 15:22:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puEJb-0004WP-7C; Wed, 03 May 2023 15:22:47 +0000 Received: by outflank-mailman (input) for mailman id 529301; Wed, 03 May 2023 15:22:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puEJa-0004WI-1R for xen-devel@lists.xenproject.org; Wed, 03 May 2023 15:22:46 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5a2d4f79-e9c6-11ed-b225-6b7b168915f2; Wed, 03 May 2023 17:22:44 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0A4B51FEC0; Wed, 3 May 2023 15:22:44 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AE31E13584; Wed, 3 May 2023 15:22:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id RmCDKEN8UmRyYwAAMHmgww (envelope-from ); Wed, 03 May 2023 15:22:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a2d4f79-e9c6-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683127364; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZiJyyFT5NgGLMYEWC/qN3yTxGI2R5QUMP+cQbIcM3+0=; b=DudI60UQ37JdVpDHP3DqnQsgwBRBkbiDoD9bVg2ZXwyzdPFYmUm59x0TeBhiEYFQQ/vBfz f4USNzO+sh0ccfIvEgOJZUMrzY+Ha7u8SV+Viw+2cQIf2rglczQANONlbPaPQCe4zbf8fm DcQq+niJUBrMHLvok92/U/MoQfAfclM= Message-ID: <998dbbeb-94d7-7afe-e4c2-02ef134cbe94@suse.com> Date: Wed, 3 May 2023 17:22:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: dom0less vs xenstored setup race Was: xen | Failed pipeline for staging | 6a47ba2f To: Julien Grall , andrew.cooper3@citrix.com, Stefano Stabellini , alejandro.vallejo@cloud.com Cc: committers@xenproject.org, michal.orzel@amd.com, xen-devel@lists.xenproject.org, Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jan Beulich , =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= References: <644bfbc6939d8_2a49bbb403253f4@gitlab-sidekiq-catchall-v2-78885c497-qxnp2.mail> <28235d38-ad7f-f1bd-f093-bd83f9fd6589@xen.org> Content-Language: en-US From: Juergen Gross In-Reply-To: <28235d38-ad7f-f1bd-f093-bd83f9fd6589@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------LKvmCwmwmvjJzje9EwrTHrka" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------LKvmCwmwmvjJzje9EwrTHrka Content-Type: multipart/mixed; boundary="------------pCCo8kU23o0UY5ep3g9fRqkn"; protected-headers="v1" From: Juergen Gross To: Julien Grall , andrew.cooper3@citrix.com, Stefano Stabellini , alejandro.vallejo@cloud.com Cc: committers@xenproject.org, michal.orzel@amd.com, xen-devel@lists.xenproject.org, Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jan Beulich , =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= Message-ID: <998dbbeb-94d7-7afe-e4c2-02ef134cbe94@suse.com> Subject: Re: dom0less vs xenstored setup race Was: xen | Failed pipeline for staging | 6a47ba2f References: <644bfbc6939d8_2a49bbb403253f4@gitlab-sidekiq-catchall-v2-78885c497-qxnp2.mail> <28235d38-ad7f-f1bd-f093-bd83f9fd6589@xen.org> In-Reply-To: <28235d38-ad7f-f1bd-f093-bd83f9fd6589@xen.org> --------------pCCo8kU23o0UY5ep3g9fRqkn Content-Type: multipart/mixed; boundary="------------3Fd0Q0UDsfMiJdb1Utf8YC0a" --------------3Fd0Q0UDsfMiJdb1Utf8YC0a Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMDUuMjMgMTc6MTUsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGksDQo+IA0KPiBP biAwMy8wNS8yMDIzIDE1OjM4LCBhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tIHdyb3RlOg0K Pj4gSGVsbG8sDQo+Pg0KPj4gQWZ0ZXIgd2hhdCBzZWVtcyBsaWtlIGFuIHVucmVhc29uYWJs ZSBhbW91bnQgb2YgZGVidWdnaW5nLCB3ZSd2ZSB0cmFja2VkDQo+PiBkb3duIGV4YWN0bHkg d2hhdCBpcyBnb2luZyB3cm9uZyBoZXJlLg0KPj4NCj4+IGh0dHBzOi8vZ2l0bGFiLmNvbS94 ZW4tcHJvamVjdC9wZW9wbGUvYW5keWhocC94ZW4vLS9qb2JzLzQyMTk3MjE5NDQNCj4+DQo+ PiBPZiBub3RlIGlzIHRoZSBzbW9rZS5zZXJpYWwgbG9nIGFyb3VuZDoNCj4+DQo+PiBpbzog SU4gMHhmZmZmOTBmZWMyNTAgZDAgMjAyMzA1MDMgMTQ6MjA6NDIgSU5UUk9EVUNFICgxIDIz MzQ3MyAxICkNCj4+IG9iajogQ1JFQVRFIGNvbm5lY3Rpb24gMHhmZmZmOTBmZmYxZjANCj4+ ICoqKiBkMSBDT05OIFJFU0VUIHJlcV9jb25zIDAwMDAwMDAwLCByZXFfcHJvZCAwMDAwMDAz YSByc3BfY29ucw0KPj4gMDAwMDAwMDAsIHJzcF9wcm9kIDAwMDAwMDAwDQo+PiBpbzogT1VU IDB4ZmZmZjkxMDVjZWYwIGQwIDIwMjMwNTAzIDE0OjIwOjQyIFdBVENIX0VWRU5UDQo+PiAo QGludHJvZHVjZURvbWFpbiBkb21saXN0ICkNCj4+DQo+PiBYU19JTlRST0RVQ0UgKGluIEMg eGVuc3RvcmVkIGF0IGxlYXN0LCBub3QgY2hlY2tlZCBPIHlldCkgYWx3YXlzDQo+PiBjbG9i YmVycyB0aGUgcmluZyBwb2ludGVycy7CoCBUaGUgYWRkZWQgcHJlc3N1cmUgb24gZG9tMCB0 aGF0IHRoZQ0KPj4geGVuc2NvbnNvbGVkIGFkZHMgd2l0aCBpdCdzIDRNIGh5cGVyY2FsbCBi b3VuY2UgYnVmZmVyIG9jY2FzaW9uYWxseQ0KPj4gZGVmZXJzIHhlbnN0b3JlZCBsb25nIGVu b3VnaCB0aGF0IHRoZSBYU19JTlRST0RVQ0UgY2xvYmJlcnMgdGhlIGZpcnN0DQo+PiBtZXNz YWdlIHRoYXQgZG9tMSB3cm90ZSBpbnRvIHRoZSByaW5nLg0KPj4NCj4+IFRoZSBvdGhlciBi ZWhhdmlvdXIgc2VlbiB3YXMgeGVuc3RvcmVkIG9ic2VydmluZyBhIGhlYWRlciBsb29raW5n IGxpa2UgdGhpczoNCj4+DQo+PiAqKiogZDEgSERSIHsgdHkgMHg3NDZlNmY2MywgcnFpZCAw eDJmNmM2ZjcyLCB0eGlkIDB4NzQ2MTZjNzAsIGxlbg0KPj4gMHg2ZDcyNmY2NiB9DQo+Pg0K Pj4gd2hpY2ggd2FzIHJlamVjdGVkIGFzIGJlaW5nIHRvbyBsb25nLsKgIFRoYXQncyAiY29u dHJvbC9wbGF0Zm9ybSIgaW4NCj4+IEFTQ0lJLCBzbyB0aGUgWFNfSU5UUk9EVUNFIGludGVy c2VjdGVkIGRvbTEgYmV0d2VlbiB3cml0aW5nIHRoZSBoZWFkZXINCj4+IGFuZCB3cml0aW5n IHRoZSBwYXlsb2FkLg0KPj4NCj4+DQo+PiBBbnl3YXksIGl0IGlzIGJ1Z2d5IGZvciBYU19J TlRST0RVQ0UgdG8gYmUgY2FsbGVkIG9uIGEgbGl2ZSBhbg0KPj4gdW5zdXNwZWN0aW5nIGNv bm5lY3Rpb24uwqAgSXQgaXMgdWx0aW1hdGVseSBpbml0LWRvbTBsZXNzJ3MgZmF1bHQgZm9y DQo+PiB0ZWxsaW5nIGRvbTEgaXQncyBnb29kIHRvIGdvIGJlZm9yZSBoYXZpbmcgd2FpdGVk IGZvciBYU19JTlRST0RVQ0UgdG8NCj4+IGNvbXBsZXRlLg0KPiANCj4gU28gdGhlIHByb2Js ZW0gaXMgeGVuc3RvcmVkIHdpbGwgc2V0IGludGVyZmFjZS0+Y29ubmVjdGlvbiB0byBYRU5T VE9SRV9DT05ORUNURUQgDQo+IGJlZm9yZSBmaW5hbGl6aW5nIHRoZSBjb25uZWN0aW9uLiBD YXFuIHlvdSB0cnkgdGhlIGZvbGxvd2luZywgZm9yIG5vdywgdmVyeSANCj4gaGFja2lzaCBw YXRjaDoNCj4gDQo+IGRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9t YWluLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmMNCj4gaW5kZXggZjYy YmUyMjQ1YzQyLi5iYmY4NWJiYmVhM2IgMTAwNjQ0DQo+IC0tLSBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9kb21haW4uYw0KPiArKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf ZG9tYWluLmMNCj4gQEAgLTY4OCw2ICs2ODgsNyBAQCBzdGF0aWMgc3RydWN0IGRvbWFpbiAq aW50cm9kdWNlX2RvbWFpbihjb25zdCB2b2lkICpjdHgsDQo+ICDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgdGFsbG9jX3N0ZWFsKGRvbWFpbi0+Y29ubiwgZG9tYWluKTsNCj4g DQo+ICDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaWYgKCFyZXN0b3JlKSB7DQo+ ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBkb21haW5f Y29ubl9yZXNldChkb21haW4pOw0KPiAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCAvKiBOb3RpZnkgdGhlIGRvbWFpbiB0aGF0IHhlbnN0b3JlIGlz IGF2YWlsYWJsZSAqLw0KPiAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCBpbnRlcmZhY2UtPmNvbm5lY3Rpb24gPSBYRU5TVE9SRV9DT05ORUNURUQ7 DQoNCkkgdGhpbmsgdGhlcmUgYXJlIGJhcnJpZXJzIG1pc3NpbmcgKGVzcGVjaWFsbHkgaW4g b3JkZXIgdG8gd29yayBvbiBBcm0pPw0KDQpBbmQgSSB0aGluayB5b3Ugd2lsbCBicmVhayBk b20wIHdpdGggY2FsbGluZyBkb21haW5fY29ubl9yZXNldCgpLCBhcyB0aGUNCmtlcm5lbCBt aWdodCBhbHJlYWR5IGhhdmUgd3JpdHRlbiBkYXRhIGludG8gdGhlIHhlbmJ1cyBwYWdlLiBT byB5b3UgbWlnaHQNCndhbnQgdG8gbWFrZSB0aGUgY2FsbCBkZXBlbmQgb24gIWlzX21hc3Rl cl9kb21haW4uDQoNCg0KSnVlcmdlbg0K --------------3Fd0Q0UDsfMiJdb1Utf8YC0a Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------3Fd0Q0UDsfMiJdb1Utf8YC0a-- --------------pCCo8kU23o0UY5ep3g9fRqkn-- --------------LKvmCwmwmvjJzje9EwrTHrka Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmRSfEMFAwAAAAAACgkQsN6d1ii/Ey8G 9Af+NEwenYC1cdXgo/lIM3vfvV5ynElLMzFKBEG6TxJHrMLGsNvYonkVl1O3gf6EsjBKZjZsSBta AlFhsqPW4o/VLWWMxSR/Buyck3KLyEmsEnaH0lOqLEClOIS9lvYKZnMBrK1wPZzXYywy6VMr6kgO 8H7eVufMtt878b5tSPCwr7NTDa5fBM600MNYn1SAtW65kMHjwjB/4ZErh5lIFrJZRu+OtG8JZri4 qbnNHW416PpW0GDIwdu3AzQ69ZATsT9LuL3frTxyp86EOGONukItDPbjhuZX2dNyeY2Qrzec/HcY jGUxCVjFhHMDsUS4YKw3Vdq7JEWnxAc/Mvfuq1LQgg== =aWMQ -----END PGP SIGNATURE----- --------------LKvmCwmwmvjJzje9EwrTHrka-- From xen-devel-bounces@lists.xenproject.org Wed May 03 15:31:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 15:31:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529304.823567 (Exim 4.92) (envelope-from ) id 1puES8-00061F-44; Wed, 03 May 2023 15:31:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529304.823567; Wed, 03 May 2023 15:31:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puES8-000618-1J; Wed, 03 May 2023 15:31:36 +0000 Received: by outflank-mailman (input) for mailman id 529304; Wed, 03 May 2023 15:31:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puES6-000612-OG for xen-devel@lists.xenproject.org; Wed, 03 May 2023 15:31:34 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20623.outbound.protection.outlook.com [2a01:111:f400:7eaf::623]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 959eed8d-e9c7-11ed-b225-6b7b168915f2; Wed, 03 May 2023 17:31:33 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DBBPR04MB7498.eurprd04.prod.outlook.com (2603:10a6:10:20b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Wed, 3 May 2023 15:31:32 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 15:31:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 959eed8d-e9c7-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AwXYI9hGwllz7WFkaXJzseWu6gBclgIP+sKNRk7IkdGLOZVCNdDzwKxep5U676xKWzWY93uCCqT+c0VAeRQOvkH3Fb68IQ7eB5QcZ50y0C+ohTqEX6k5wnAuHxPJpzAybnlWjz25OfEelfdyC3RA+wXx3FYmsjnhQfHMby65tccRSR6Y0Fa8sUAN1A7Ll+oQlSjZzXZ2iJgVBQCfrChKY0TmKGplarA7a0EK3j4KtrWAjx/mqA3rd4Q+nxnf1D0RtIrCsRWZOfZanwgbgCJ8QJmxHSQiw3PWPh329VT4YXHsm4Wpq34glx8I494gDB2k7R04KXKKTSoZu96wPvDHVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H2xNVauUIZx/Q0E/ZFLgBZEw6IdycaAvbYocEzDzrNA=; b=bcX5NVUyfmyi3B8iYPDSKIutil33aYHB9MEs18Fe3H2ktn0x6tVSIYoe69cYtrk4rulDIj35tC3ni+0mg+DXEdGdhsc2uDoB7+/vpcPcoh1ovewLBJorF5M8BI5NGgyq7ZA+kUl5lxqzn5IW0MgaXHxkwH/9i7swK4bShOwpNTWVyQtvWj+LWv3kE/yT6KVMp3hv4gpcUNpoZY/Qsi4JWDUPN9bf/FCUymNN4XKjR8AUwmDhlstyjMa6DdvPFOyzJCW6dDl4dcbOA9avvnSjs0LazwOvogeByyzHAB5Do9Z5p0iv5lVysorEKmQvZES5zRUFKK4g8FLlkFM8pEqBKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H2xNVauUIZx/Q0E/ZFLgBZEw6IdycaAvbYocEzDzrNA=; b=MdECWLAR2t6oAuwhKfXNr8DsRx0IfidXB901+DMweeyEFGQG+lRJOhVg4n9cMxgig2eBn5MWL2iB7+qe2afSqwMA0b5tgFqFvRl4ZhmF5aJabMrp45fUE+iJGKc+FISpHW0HJnnGkjzHbav/Qg9L0rZFVwjCzx/xh5JfVFE1kbUCNwFD+uGEhfCMw+2aAWsesLTLQDvyOMBi2y4Njcu1BrCx6gRdEmpaMWVc4dRl5a9pRlfE5iQbBA7tlQEVRJTxHEWqioaGFnW2TV/+74Q9Wn5tBNkhfZ0+Rj3P+htaWUPfECRhDAarKcnTUZ9HG0+nY7/Pm78dfWsyk2WxzhcjQA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <85e59fd5-9a06-48b4-ba7e-81865d44e332@suse.com> Date: Wed, 3 May 2023 17:31:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Volodymyr Babchuk From: Jan Beulich Subject: [PATCH v2 0/2] new CONFIG_HAS_PIRQ and extra_guest_irqs adjustment Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0256.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b5::9) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|DBBPR04MB7498:EE_ X-MS-Office365-Filtering-Correlation-Id: 3e6d5a8b-e508-4a54-a9f1-08db4beb790e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CuuTJOXHpxWsbBFYh906b/aRzcD5b66USGPSbgRMS3uOaTOQ+XqG47zmMk01ucYUDx8NaxxibjyZunDtgFxf/HCozMhISPRpliOxQWhg5luCCQMUB3stcwS8gVZlQGx6IGihocqqUe14CNJrzm93QHvLSTHJ1k8M07u6IUfSDy5CBVMMsOQk4E6OLz+iL8qY/VGx1mmVaO8hdeRn6465vtXpQtgv4dKAyccyTD60K5zQEA5M1rzlWJ0tceYMW67UEQ5iNysyQxAVsNVSAMH0GKQc3yiWIkhtHh9R2RBbzfHkGhBJDzy7pETqhCpSn+e+LBo3z0ItXw1scsnRgf4d53vd1lrijsd2VA0UWdf1qVISOs1nEHfEuGv9jjOJbHTNVyVkiz5AxWUeGou4GeD94CNnUVS8NDdJKRnpHGxwE+x7Vyf+Pdm/59wKVUW91CjL4HyfBEbvw/qw8TCm+n/7DGF/nmhCmH1v6AubX2epqmBFwuYrsgkz315hpKQuXM+7LM3dmYVop2/wC2HDam8F7q3Yu9sEpbPRGtrO8dZqZr1Jc24M1ZzUSZ7fU3XLYnWx/bFhrsaJFZ+Z2vRuF4T0N/JuUXHT/2klwauJ3ZPdFegGDAw4c/y1IixhYifa/OBnnhE1A/gajTsh/Coa9CXUXUssA70tVFlG6bRZsOempjVqVd7wpTuNGJKBR1f0GZ/w X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(346002)(366004)(376002)(39860400002)(136003)(451199021)(2906002)(38100700002)(2616005)(26005)(6512007)(6506007)(186003)(6486002)(36756003)(558084003)(8676002)(8936002)(5660300002)(86362001)(31696002)(478600001)(4326008)(6916009)(54906003)(316002)(41300700001)(66476007)(66946007)(66556008)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bGVOUXNwKzU4NkRHcHJCd0dzTWZ2TjNYRHFMc1lrS21KMTc2OE5SZ0MrNEp0?= =?utf-8?B?TmxwcTczMll4bkREb0toSHh3aWtsbUx6ZXMvNUgxbEgybnI1alo0eithZ3dp?= =?utf-8?B?Z0NPWDlVM0duTG94cGp3QlRYTWdiZGlrbE1tL2c5S2R0THF1OFJnTEpHTFRV?= =?utf-8?B?T2lTNlRsTnNhRXl5THYyU2hQYWtvRVRjbklrcEc0S2E0bDJsZHlVeE0zM0Js?= =?utf-8?B?MTN0UVV2OGtQSTVqMnM4eDJGMnk1UzlIWEEvZGNRTGZ1ME5pVmNIU254QW5P?= =?utf-8?B?YjQxVWFuQ0pYc1BYOE1rVWZaM2xxZGN6eTJ2ZUE1eXNXMWVHSjRGdm5RV0Vj?= =?utf-8?B?UkpxUTJqWm5XRkVIbGQ1dkVCc3dBeXlHTWRTTXBtVm5sVi94T1ZBWVRtMEVK?= =?utf-8?B?RktVLzVicnRhTjBqR0p2dENEMkFwRTNoeEpicGJETFZRVGNGVVRFaENLSGMw?= =?utf-8?B?Mko4Z0pGTGg1WWd6c0dWRXV3YUszTnFVbGQvOUx5QUVZYVJ1elI4OGJrd0N3?= =?utf-8?B?ZHVscVRsbUl0Qzd1NG5Id3pWbEhpeXVsczhnVXZ5b2VQL0ZqN2dEQXdjUXFr?= =?utf-8?B?ZHNkWEZIM09uYVFsRy9CM3laV0w4MXQ3WHZOajNOVTNsb3ExZXd3TVk0QkVR?= =?utf-8?B?T2dGV0ZOU1k1U1YwdUloanNoTi9scmlwekNQczFqd2dRME85dWdjWkhIYmwv?= =?utf-8?B?bFpDc0hrM0lFUGZtdndWZDJiZ0lMaW94K3Rrb0VVUW01eHdZRDdheGFDc0F2?= =?utf-8?B?bm5SMnorNkRCa21maUhDNmR2aTJGcnZmczhrdkljUi92SHBFUGZscjQzMDk3?= =?utf-8?B?bi9XT3B1QllrYnJsSXNtM2MvZ05PVzlEV1gxaXBJS3Z0NkxsREtoT1VFMGJT?= =?utf-8?B?REhUc3o0VTQ0Y2NwMEFQYW9FMXFSaFpFMjgwa0FUOUh4djB1L05BOGJ1WDFt?= =?utf-8?B?WXRPQkM2UXBmelFQNUZ2K0t2MUtFejBrSG1RdS9mYk9TdGpEQ0lSYmdWbytx?= =?utf-8?B?cXFPSG5YU0d1bUVZNFVqVnhPcGtzWENFaEg5ay9lYk01YmExcGluWjRUWldU?= =?utf-8?B?V2Zkbm1Ganc0UDNUVDlPaXB2dTIwcVVoSGV5SEo3TGFNNjZrSVlDUlVDSyt6?= =?utf-8?B?ejU2Ym5LVE9mZ1pOREVFVlZLSDVZOEQvVkRkb2YzWEZDMVdRR1VXMXMveTc2?= =?utf-8?B?ZkF5V0NlM2hidndFY2lOS3RSa1QxaGlZaCtpT28zazNJdmV4STFyTjgwUXh5?= =?utf-8?B?ZWNoNm9qMktqYlR0Skdib2paeUkzSCtJRUk1VWdwekZCeGtCaW5FcGt0RG5E?= =?utf-8?B?Z0xNNG1IOE1haE1rQ0RTWDQraGZJNnRBNVhtV1MwNXdQL0NOT3RVRVhjVU1Z?= =?utf-8?B?RHUySmwyeEl3QWZpZ1ZGblhkNnlrRklrd1Z4WDAzbWI0UDh6Q29ZZnU4THZl?= =?utf-8?B?SDlXSjM1OUZDbHd6bkhJYWFrSHZFUkhkRm56LzlVbVpQZyt0M0dSTHM2NG9X?= =?utf-8?B?QzBJSWFpdk1PVisrcSsxNW1naE9TT25HVTAyWDRUV3FCSUFJaWJXb1BkTTFC?= =?utf-8?B?eVhhU2FQVHJUcXlYTzdzV3J1ci9rQy9CTGhaZ2RheHR1cktLWkZXWUo0Zjd3?= =?utf-8?B?RkxrcFZKOFM3N3ZFcFF2NzlqWjdwNEFRV0d4bFdtQzZnbzVpaXU2Zk5iL1g2?= =?utf-8?B?by9aSTBJRUJmTmNDTW9qVmZhUGtLZnZlRWF6eDBLOUJnQmdrV3NmckMxNE9w?= =?utf-8?B?TkFGaHV5QkdabjlIYkJWV1BWWVJMdk13czRKcDVMQWlaNlJxVHhZMXh6eVll?= =?utf-8?B?SndMdU5iaU0vM2hLY3I0MVhhUmx6T1VKcVo2U1lmUUhxblBzQWxEQldhV3E0?= =?utf-8?B?WnFkVnVkTHVNVnlFVWlWallGSWQrYnhwRmxUS0l4NlFsazRDVW55MDJQalRH?= =?utf-8?B?YllReHkyVks2QkFDY2xPTlN6aEVSVVF3b3hlYmRxN1p0dmxrekNiRzJWaDJz?= =?utf-8?B?STd6QW9ockwzNkI3MU9hb2x2dkhQOGhyMVNNZFlveFY5Vmd3U0ZVRjNjTVdq?= =?utf-8?B?SktpUDZGYXZaaThjRzQxcXBSMHFQMXhVQmFGc2pUckFwQ1JLVHZBZjZyUkNJ?= =?utf-8?Q?EAt+A1PYjdxbyjSVqb4UhdaG8?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3e6d5a8b-e508-4a54-a9f1-08db4beb790e X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 15:31:32.5434 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LwCoFThrBh5+er6xEfw/rOCvcQLjoj/+TOPzvM7oqlNb376bZQrGtcan/8MPK4jqpM2v4tb7UGmsKlIWTopk1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7498 The 1st patch (new in v2) has the effect of the 2nd one no longer affecting Arm. 1: restrict concept of pIRQ to x86 2: cmdline: document and enforce "extra_guest_irqs" upper bounds Jan From xen-devel-bounces@lists.xenproject.org Wed May 03 15:33:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 15:33:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529307.823577 (Exim 4.92) (envelope-from ) id 1puETg-0006YL-EM; Wed, 03 May 2023 15:33:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529307.823577; Wed, 03 May 2023 15:33:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puETg-0006YE-BO; Wed, 03 May 2023 15:33:12 +0000 Received: by outflank-mailman (input) for mailman id 529307; Wed, 03 May 2023 15:33:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puETe-0006Y6-WC for xen-devel@lists.xenproject.org; Wed, 03 May 2023 15:33:11 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20616.outbound.protection.outlook.com [2a01:111:f400:7eaf::616]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ce137e99-e9c7-11ed-8611-37d641c3527e; Wed, 03 May 2023 17:33:08 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DBBPR04MB7498.eurprd04.prod.outlook.com (2603:10a6:10:20b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Wed, 3 May 2023 15:33:07 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 15:33:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ce137e99-e9c7-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nSgB/yFikd9A65BGSSGIKIyQygm92cG+/3011FVurmipxC58uOkyY7W4m6Yvd8xMheY1Ao4f22SZA5IZyEBC/2ccaXsV+2VuL9RfaMUXbSzTY/yQR8W6TI7AdGmCWyVnfyjzfSXD4dN9fYULBzNrgsE/7LurvowxL7uw6+CCpQU/oRhiCY/kPVsWKO/5I3YnDr46uWKSEfWPJKd5YZ827V3KQYDGGsE4kHES9/ytnke97ur3xfplzbzC9z10qqhX9JmalwPAEQB0lOrh1m3fgFJZDED25YcbTy2jrnq0EqAbI6qFl2eQu9Vb5gKLjgWbhDquWgwQhQyCy9eGNSOHvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g3wz92lQ5KDUxdt8BmZClL8NBUi7+IdNuZks2UaRJyU=; b=gXtfyiiP1q1b9Q+Ftsb7t7PhMZE/zsJ+JcGhXU8ZSxD1A3CFYwjRhAyj8Q0K2HZr3c9lj+822nboWrJEvq9Kv+PT9DX6AbP0mFpChXyAYUcAawM6BtMlh9EwTf4IWlTj0uANRF/g7mfnGjSlG0aAvq10VZAB2edFTwCD1YtK/OA/Kvlh4OELwxVnlGmt+CKvrjSmEKdpIU4G12UWWHxbwC8b9KyLh7lAkvrMw6gy5rbPMlg91lXvM/zJz3jmkChzU0u2VOzvzIIOlrL/axu9IST8n+yPeC+ZQYZxIsVRN3vbTIazM/i4dF97eV6tFc1UuZ/7Sh9iRg/6K6GLObf+Tg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g3wz92lQ5KDUxdt8BmZClL8NBUi7+IdNuZks2UaRJyU=; b=wWZJWEo2csCq+ts+WmBivzAf7dj+q15/dhb8hM6lCZzGF7dEYJf6GpodWSdyXJ48Eh/3oFUrt4WhAYcJiKLXY4l7UQX6qAHXHf7eKhK70uy1jft1p0mGqZamsBuL3ds17stW/NaaNK2YU6zS49GliCxirAKzhpA4t4wubmvNLoS3vVHurUhATqKXLFAQtDKbzr+AUGS2SHG+2NL+pDiF2eiHD+D+k6c54H7rEfroEPPrMs1YVr/YjailEXntJvMG7CVQqWDMUUg8fFU+izziIwsyth5WIUZTMxdkwCA73MRuHangD9aLlboMtWwPVj4u+XB1kfc6OM2vsOXPPZ6Arw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <98f51b96-8a1c-7f33-b4d3-1744174df465@suse.com> Date: Wed, 3 May 2023 17:33:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: [PATCH v2 1/2] restrict concept of pIRQ to x86 Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Volodymyr Babchuk References: <85e59fd5-9a06-48b4-ba7e-81865d44e332@suse.com> In-Reply-To: <85e59fd5-9a06-48b4-ba7e-81865d44e332@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0039.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::22) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|DBBPR04MB7498:EE_ X-MS-Office365-Filtering-Correlation-Id: 9a73f6e4-c252-4979-c19b-08db4bebb195 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X8N1uBMFM/CQ2lRA4tF99/KGO78WBR/GOmU7pEy+b5Zw9dGDVVlCmAtWoXpK9tIDvFA8bbV+fa9l2PJa1YYwp9rCG6BD9lK396w6UiLWtp68qhQBu5V+YfJ2czPkkprwd0h43qXyJXpWH2ybDGAUFrQ1Xr1Jv+5UqOc0YrNRN4oOHCj8bHnEwuUPv5vTEe35nPyA0tkCA7E8vhq+Hf9Fa3RefUcAV1TbD57w9QUucxq+juHHqczCSnH+nfMAmfXDcjWsox8btc/l71neZfkacDUJijKhAjEg8SQMltIzG3zAxNw3d+uBoCCqG/d4vv/fOC9Jqr4tHqjOSo/kkstxUkn985C63JZFyaWZK8XGz0UFTBNWL6t4GS/kGvTZVLvTRbk+QXbgw6CjmXqwwafp0ekrBxNsMkVAi7dOuZx3Vlp8fN6zbt7ufrcAlwRFJp6Gt7IMYmwCFc9vEfrmI1pRCqzBeZZuLV22hInMwXUewtol1/UQsXIJKKkNJGDUMMhWULM2pTZxr23Zb42knaETBhsnC+bvcp+usEpX6Tza0v1n/+J1HoAbb6kzR8U7b5sAeHjQD+sR5XQqV1oHiaD9rgDTdzTfftooFdhwWClORixFyMsXfcFgC2J1kzxYSiRUr8h+sixoglMZLa/ISA8MEezjjiy5j9rjrowIMZitahCZlokFAAOYbBZF3lOmZa/O X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(346002)(366004)(376002)(39860400002)(136003)(451199021)(2906002)(38100700002)(83380400001)(2616005)(26005)(6512007)(6506007)(186003)(6486002)(36756003)(8676002)(8936002)(5660300002)(86362001)(31696002)(478600001)(4326008)(6916009)(54906003)(316002)(41300700001)(66476007)(66946007)(66556008)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZEk3WVR3Tk85TWsxcEF2SlZxcnpaK1FCNXRZRENlcHVtUkZTWi8rSGtYYjFs?= =?utf-8?B?aUMyMjEyQ0ZaUHhlNE9XU3VuWHl0Wk43TU1QVEZSOW9EcXpYQkFIYTh4QjlZ?= =?utf-8?B?MXhnMzd0YnBKV3YxR1M3YWFOSzZZcmxZN1JET3A5MFZqQmZVelppRVg4RE13?= =?utf-8?B?TTBPYjRwYm9YeUUya2J5MVA2eHhkUFNXVUNINzdock9YSnh3M3g4dTAwak9N?= =?utf-8?B?blhRdjVDS0x1YjB5WHdhUnJKTDRPeHNLc1hkVVdFSkl5ODRyMHlQWldpWHJa?= =?utf-8?B?NUJoUXRrQ09KUXMzMG01dEQ0SXhJejAyejRMS3pZYmZFTHFyUUQyTGoyZ291?= =?utf-8?B?YzhSd21HQko0R1lHMmExZXlBQjRuVTFydUtEczZKcUV6MlQ3V0d6Zm15MGRP?= =?utf-8?B?MkFINWt0MmRMSGhzK29yN3pUVDNrWE1iRmRSeWhDSnNxYkk4M0R5b0JNRktH?= =?utf-8?B?VmxvRU0wREJROEVrT0wrZWoxSXYxSzUwSTdNY2w5bmdrSXMzUnFGTUNvREJx?= =?utf-8?B?cVNkOS9KM1NzM3ZHSmNDNmhpM2RZR0hmbS9tU0JEbXVrWHJ6QTNBeDAwZnJC?= =?utf-8?B?TEQ5S3I4L1lJN1JrdmFGa0tFalFRTFVJSDBQWE1iQlVaM0ptS2FhaFM0S2Jw?= =?utf-8?B?RGFXVzRCMVRnWGNwQ0hza1p3VXFzKzF4WkJVSE1hTlh4SnNuOFJqVEhuUGdE?= =?utf-8?B?dEw4ZmRtUkZhdXRUOUlMQnpLQnlQbjkyTFNER0s0elJGZXQ0Zjd1UnNPRmox?= =?utf-8?B?ZHVPSk1aU1VxeTEwTmJRQkZZN0lhc0g2VnVra2lna01xcVpheWNXM3Q2cm81?= =?utf-8?B?UlhWcjlsT3VZd2ZrQkVOM09RbXBuN0I2UWx0bVg5WGZqOElaa0FRMDZLcU9a?= =?utf-8?B?Z2s0bW4xT3ZPRFFzRlMxTWFvZlVPM2V6NkhJWkxpU2l3aFNpWWE2cFVrZVVh?= =?utf-8?B?Y2I1c0JQVnhMSHNnbFBKa1FneExpZWx3YlBhTEJUei9LRGFlM0pXZWJSK3V4?= =?utf-8?B?WGpWd3NRbFNmMHpad0p5NWJlUmxVZzNoc0RJMzZZMzBocStLbkdNTmdMN0JN?= =?utf-8?B?clAvbmhDcnN4VkFuNE9ab20xdXNhd3JvU2tsUVIvRHpOb05LMHU1dW9rVzVV?= =?utf-8?B?Zjk1RXQvWkJNK1JzWkpMZzQ4cWMyQUh1eGJpb2FlZzFUL3dwelYzQ2hDK1M3?= =?utf-8?B?MldLVys0NWlobEhjY2ZQVTBST29uY3hrenF3NlpaVXN5WXVkV0tDT0VDNzRI?= =?utf-8?B?c09uRmRwVzZnU0VHRmE0K3lMM0d1NDg3N1JxbDA3V1ViRy9qOXNmU3RlamM4?= =?utf-8?B?N2swdEpYZkNMcXVNRDM0U2RCY2tJOEdmSndUcDBEOUNVTUdlOTBmREp6S2RH?= =?utf-8?B?dW5QWWtNdUJKdlJjbGMyL0R6QlIyak1kdGkzVHJnazlYa01rc29YMlBwUEJn?= =?utf-8?B?TXlzVzBGVTBEdXVxVncvMjZkYXhPWUZES1JQY1ExMDNhRVJQaE9OVzFpVWlH?= =?utf-8?B?WXpKWThjbWVzVEhOVklhSEZiaE9yK2lVVTVra3lEbFdVU2w1bmdVQXJXbE0z?= =?utf-8?B?a0M1MmNScnNuOGduOXAwM1FXUkxyamJKT0NXSWMwMmVCNjZUeS9GaGh1VGs1?= =?utf-8?B?cUtHelhIRGFKQk1zczk4Z1RrMnEwZkYrT1ZqNjhob3hmRGI5MnZZZjB2cGk5?= =?utf-8?B?VUpCU1ZHUTBkQ3BoQTBUNUc5eHR4a3lJSmJMNTQxbnkrc2I2cnpsV2x4ank4?= =?utf-8?B?SVpkelZRZ2xnVHlqTkZEWXNQcGs1Zms4czJiZW9PM3JjSklGc2VGeHVFbXFF?= =?utf-8?B?RXltaXNYSGxBLzVpcHNobWZOSUxYTG93aEh3eVR2cTB2UWU4MEgxVjBIZjJH?= =?utf-8?B?RzROVzJ6MkU3TUJGUmFpQVQ2RHk2MkZXVzVDcDVrSWd6Wk00Z3RtVEZDZEZZ?= =?utf-8?B?WitoU2hDMzl0aW43WDNBR2tFUnhkTWliZ0h3ckhZb0hKUitod3B4NGtMOURZ?= =?utf-8?B?NzRjYTFlbU1FTFc3MzdWY2pFVkhPT05RZnNDaXVPK050SmYwSEIxNE14OHgw?= =?utf-8?B?YWxDUXNkZ1BhQktxZHV4dTYveUdwTHRhWHRNYTVMOVdLVzZ3MWMyaEdxYUla?= =?utf-8?Q?ivwht6oUnMOXiNx3tAKvhgc3o?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a73f6e4-c252-4979-c19b-08db4bebb195 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 15:33:07.2824 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BJwHarARIxSm0JrOqugUK70nhkVOKmSA66weHMWK3Nk8Ohw889mtHQV8TJOn4v999HAheH0LeUzzowLi1t5h/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7498 ... by way of a new arch-selectable Kconfig control. Note that some smaller pieces of code are left without #ifdef, to keep things better readable. Hence items like ECS_PIRQ, nr_static_irqs, or domain_pirq_to_irq() remain uniformly. Signed-off-by: Jan Beulich --- I'm not really certain about XEN_DOMCTL_irq_permission: With pIRQ-s not used, the prior pIRQ -> IRQ translation cannot have succeeded on Arm, so quite possibly the entire domctl is unused there? Yet then how is access to particular device IRQs being granted/revoked? --- v2: New. --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -1120,7 +1120,7 @@ introduced with the Nehalem architecture intended as an emergency option for people who first chose fast, then change their minds to secure, and wish not to reboot.** -### extra_guest_irqs +### extra_guest_irqs (x86) > `= [][,]` > Default: `32,` --- a/xen/arch/arm/include/asm/irq.h +++ b/xen/arch/arm/include/asm/irq.h @@ -52,7 +52,6 @@ struct arch_irq_desc { extern const unsigned int nr_irqs; #define nr_static_irqs NR_IRQS -#define arch_hwdom_irqs(domid) NR_IRQS struct irq_desc; struct irqaction; --- a/xen/arch/x86/Kconfig +++ b/xen/arch/x86/Kconfig @@ -25,6 +25,7 @@ config X86 select HAS_PCI select HAS_PCI_MSI select HAS_PDX + select HAS_PIRQ select HAS_SCHED_GRANULARITY select HAS_UBSAN select HAS_VPCI if HVM --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -56,6 +56,9 @@ config HAS_KEXEC config HAS_PDX bool +config HAS_PIRQ + bool + config HAS_PMAP bool --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -350,6 +350,8 @@ static int late_hwdom_init(struct domain #endif } +#ifdef CONFIG_HAS_PIRQ + static unsigned int __read_mostly extra_hwdom_irqs; static unsigned int __read_mostly extra_domU_irqs = 32; @@ -364,6 +366,8 @@ static int __init cf_check parse_extra_g } custom_param("extra_guest_irqs", parse_extra_guest_irqs); +#endif /* CONFIG_HAS_PIRQ */ + /* * Release resources held by a domain. There may or may not be live * references to the domain, and it may or may not be fully constructed. @@ -653,6 +657,7 @@ struct domain *domain_create(domid_t dom if ( is_system_domain(d) && !is_idle_domain(d) ) return d; +#ifdef CONFIG_HAS_PIRQ if ( !is_idle_domain(d) ) { if ( !is_hardware_domain(d) ) @@ -664,6 +669,7 @@ struct domain *domain_create(domid_t dom radix_tree_init(&d->pirq_tree); } +#endif if ( (err = arch_domain_create(d, config, flags)) != 0 ) goto fail; @@ -755,7 +761,9 @@ struct domain *domain_create(domid_t dom { evtchn_destroy(d); evtchn_destroy_final(d); +#ifdef CONFIG_HAS_PIRQ radix_tree_destroy(&d->pirq_tree, free_pirq_struct); +#endif } if ( init_status & INIT_watchdog ) watchdog_domain_destroy(d); @@ -1151,7 +1159,9 @@ static void cf_check complete_domain_des evtchn_destroy_final(d); +#ifdef CONFIG_HAS_PIRQ radix_tree_destroy(&d->pirq_tree, free_pirq_struct); +#endif xfree(d->vcpu); @@ -1864,6 +1874,8 @@ long do_vm_assist(unsigned int cmd, unsi } #endif +#ifdef CONFIG_HAS_PIRQ + struct pirq *pirq_get_info(struct domain *d, int pirq) { struct pirq *info = pirq_info(d, pirq); @@ -1893,6 +1905,8 @@ void cf_check free_pirq_struct(void *ptr call_rcu(&pirq->rcu_head, _free_pirq_struct); } +#endif /* CONFIG_HAS_PIRQ */ + struct migrate_info { long (*func)(void *data); void *data; --- a/xen/common/domctl.c +++ b/xen/common/domctl.c @@ -683,11 +683,13 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xe unsigned int pirq = op->u.irq_permission.pirq, irq; int allow = op->u.irq_permission.allow_access; +#ifdef CONFIG_HAS_PIRQ if ( pirq >= current->domain->nr_pirqs ) { ret = -EINVAL; break; } +#endif irq = pirq_access_permitted(current->domain, pirq); if ( !irq || xsm_irq_permission(XSM_HOOK, d, irq, allow) ) ret = -EPERM; --- a/xen/common/event_channel.c +++ b/xen/common/event_channel.c @@ -555,6 +555,7 @@ static int evtchn_bind_ipi(evtchn_bind_i return rc; } +#ifdef CONFIG_HAS_PIRQ static void link_pirq_port(int port, struct evtchn *chn, struct vcpu *v) { @@ -580,9 +581,11 @@ static void unlink_pirq_port(struct evtc chn->u.pirq.prev_port; } +#endif /* CONFIG_HAS_PIRQ */ static int evtchn_bind_pirq(evtchn_bind_pirq_t *bind) { +#ifdef CONFIG_HAS_PIRQ struct evtchn *chn; struct domain *d = current->domain; struct vcpu *v = d->vcpu[0]; @@ -639,6 +642,9 @@ static int evtchn_bind_pirq(evtchn_bind_ write_unlock(&d->event_lock); return rc; +#else /* !CONFIG_HAS_PIRQ */ + return -EOPNOTSUPP; +#endif } @@ -671,6 +677,7 @@ int evtchn_close(struct domain *d1, int case ECS_UNBOUND: break; +#ifdef CONFIG_HAS_PIRQ case ECS_PIRQ: { struct pirq *pirq = pirq_info(d1, chn1->u.pirq.irq); @@ -680,14 +687,13 @@ int evtchn_close(struct domain *d1, int pirq_guest_unbind(d1, pirq); pirq->evtchn = 0; pirq_cleanup_check(pirq, d1); -#ifdef CONFIG_X86 if ( is_hvm_domain(d1) && domain_pirq_to_irq(d1, pirq->pirq) > 0 ) unmap_domain_pirq_emuirq(d1, pirq->pirq); -#endif } unlink_pirq_port(chn1, d1->vcpu[chn1->notify_vcpu_id]); break; } +#endif case ECS_VIRQ: { struct vcpu *v; @@ -1097,6 +1103,8 @@ int evtchn_bind_vcpu(evtchn_port_t port, case ECS_INTERDOMAIN: chn->notify_vcpu_id = v->vcpu_id; break; + +#ifdef CONFIG_HAS_PIRQ case ECS_PIRQ: if ( chn->notify_vcpu_id == v->vcpu_id ) break; @@ -1106,6 +1114,8 @@ int evtchn_bind_vcpu(evtchn_port_t port, cpumask_of(v->processor)); link_pirq_port(port, chn, v); break; +#endif + default: rc = -EINVAL; break; --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -438,12 +438,14 @@ struct domain struct grant_table *grant_table; +#ifdef CONFIG_HAS_PIRQ /* * Interrupt to event-channel mappings and other per-guest-pirq data. * Protected by the domain's event-channel spinlock. */ struct radix_tree_root pirq_tree; unsigned int nr_pirqs; +#endif unsigned int options; /* copy of createdomain flags */ From xen-devel-bounces@lists.xenproject.org Wed May 03 15:33:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 15:33:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529312.823587 (Exim 4.92) (envelope-from ) id 1puEUP-00078N-RB; Wed, 03 May 2023 15:33:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529312.823587; Wed, 03 May 2023 15:33:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puEUP-00078G-OM; Wed, 03 May 2023 15:33:57 +0000 Received: by outflank-mailman (input) for mailman id 529312; Wed, 03 May 2023 15:33:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puEUN-000715-TT for xen-devel@lists.xenproject.org; Wed, 03 May 2023 15:33:55 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2062a.outbound.protection.outlook.com [2a01:111:f400:7d00::62a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e9d48b08-e9c7-11ed-b225-6b7b168915f2; Wed, 03 May 2023 17:33:55 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DBBPR04MB7498.eurprd04.prod.outlook.com (2603:10a6:10:20b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Wed, 3 May 2023 15:33:53 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 15:33:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e9d48b08-e9c7-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Osh+id0j45zfZXNwwHYouI5WHcCjfXcW/PyhDXbQXBsTt22k+zb9dvmqUh0qb8/gJpX49M+717kFrQpfsxD4+zEjGH28AxGPjcDXZRf7B91Sdp46bA8jKrHKjKo0T2ForzHKAis1oWD687NmykAO+8nyLPd3VYIlavX/tUeSpWmlOQVrU1RksTJnk94eScXQstVvafNxxH11XSLNEI8zTyYWUYMYdmivRB7v/66vuSZhqReKu5UGjhbNtxD1TN4zeyoVxapi5UTkRTzyxdRWh8HIQp5njCtIyfqTfkLD01m3SIzWucl/UfXoPIk+OpgA7kYrO8ok3N6HU4M2tAaYyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9Stzvh+MzN3TPUQsXG0ZEOGdaQBSL5CX/KwjgUIRxmE=; b=XNIvxcwah0j0y5meDtGSTvbuPRRZaltVoJGZABiv4ebymhF28ftVLne/3HN9SLCXTFVwbqHDqlEICGRfq6yrE0gsoquglqbRg33k/OME9bJ0VswsZUBkprlPKPSXQOj91Q/4nezcAzaMl4Noob+DJQVCjhPWv0jk6SJbflqF/MnvmW7tJ3e2KsBpyehb80qv5rgfHJNKMmN96/71pFcNH5rzXx2vIXAEl+5vXXhRRrJWFR2yMiZ67yOW+HYWpQLft2edyQd/TE7UMohdLHQKjnEybuSIY4RhiOkTzSEfRBwQqQX1MQQa7pzTPaYceVMHFSevJSspkKIv/4hNjOi1dQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Stzvh+MzN3TPUQsXG0ZEOGdaQBSL5CX/KwjgUIRxmE=; b=WSCpiCM0pwYb3is2V7/KjC/dXNtG/1sAm2BHuO7hURtLJlMZ62T22xzj6NV2xR5rgptr76qpkDYNo7UA8l3w1gQWD7MxxHYkO6xy2INWmLylU4M35sKmQqjzouqPyVdlXXOsOvcXjRS2MueZbCaWqmq79j1DQK9oJQ70v+wYojnHdUaGH38KefhKWmxCb5hjU3pYDdOQQBKmDUqzhzdk3UAzLp/lXOZtBTqSn1UYUyv8HepHNo+B5JV17VCG9bkaug/bpDltBs/Y2ovnMt9pjCy6uAM8k0dvQduAf6SwNsMO492AuxOcj/IcoyL9OT2MpIaqBVf8FSbN7+J4IWkv1Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 3 May 2023 17:33:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: [PATCH v2 2/2] cmdline: document and enforce "extra_guest_irqs" upper bounds Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <85e59fd5-9a06-48b4-ba7e-81865d44e332@suse.com> In-Reply-To: <85e59fd5-9a06-48b4-ba7e-81865d44e332@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0041.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::6) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|DBBPR04MB7498:EE_ X-MS-Office365-Filtering-Correlation-Id: 1ab24165-e4b5-4636-bd4c-08db4bebcd02 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: leDVpWvs0zltC/Ydikt60yEb5v24ta6p02297aWXobICp5wlrY8ahIQCAWWMGoAwPtzog8ZsVA03Wa3IIsn6tLDUf7/9Q+95p4OQ/wNGiL/nsbR/Ch+MLBiKgJ5f+vYv5dcBT4DbVi7Al0aua7QCrHLOE0m1zRXp62gPfA3ZGGl8KY1s81zDO2jVMWZcNIboRb/HSolJl1zq5aQRcxROafTKwjtTi+AfGOTJdsy6inexFh48GbL9Bw9Xzqz9Nb2iocKUnd7rl/48yZSe8954gBXACcB7L6AAw5RFWBVjfqAOfypyXDjcG/tKog/+JzfiLThwKKsc2bxKkGLbMTrT+qloI/9yPBGaq2StcE0L6b8YcjF+LWcRiG3RcNgmrv2HlGtqKTBJ3sD0J+cefabBut1VXzVvvvJ08XK1H/FQ40HJGkjQHu/3bFOCBXXLHDjAGfLwF6QqYNEKPx/r9rwUZ7xIgvp9Vouzdcura2/qMDEWsnLqmWHFlG3661i7mk/ofELMz1nM7xyImamS7032MsxuQATPC6xtkmFKE88hma3eP9a7ekjx3oxG0D+4hkkKjBAge0LBnZz3v3nEvhrP7o50acptyY+6KicwTBgmHcpGvhdrPkz0inLe3LxkGKdipuhDEg18TGq0k6bXRzoGggfkSbssihQ2Z7txnbdc1eA7gDqsX3tUEb8zDYwLPvxaJsAha4PVxNkYx5Y3Kafhcw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(346002)(366004)(376002)(39860400002)(136003)(451199021)(2906002)(38100700002)(83380400001)(2616005)(26005)(6512007)(6506007)(186003)(6486002)(36756003)(8676002)(8936002)(5660300002)(86362001)(31696002)(478600001)(4326008)(6916009)(54906003)(316002)(41300700001)(66476007)(66946007)(66556008)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RnVwb0R3ZVN0OUdZd3gvMkovN04wM2xLUXRmUmY4ckRwbDZiUmZmQ3ZZMnRT?= =?utf-8?B?dVYxVmEwTTNiY2dvNGNsVmxrZThIc3hqeHZvZkxjdHdOYXU1RXBvZURLa0xj?= =?utf-8?B?OGZlT0VmYW52eE9KNHgxSjBQemZpWk5PaG5vUHdTVVpaSVo4c3VWWGh3OHlp?= =?utf-8?B?YkJ3blZna3ovR0dmN0tjOE9hMUc2Z0dYMkc2bzg4cURqM3FtSXZqR0ptQkNn?= =?utf-8?B?cGZ6cFY3RjNhWjJxTUtleTVSQjBVZzZIQmZSblRuWmluTjV0bEhrdlFxZ1ZV?= =?utf-8?B?QVNVei8wQnVhNHc0MVcwd0hhYUE4bUh4bWhFU2Z4RXBLQmM0ZXVmWnNXeHAz?= =?utf-8?B?b3JObG0xS3RTRTAzME8wV0FYa0taZ2d3MnZLU0o4aDROSjRSTGE0WFBuTDJD?= =?utf-8?B?bnNGcUliYVNsRmZxaUpXUC9EZ0REYzJDV2RkSisvUzIwUmdKbUhCRXFQNG1U?= =?utf-8?B?VWRkRno5cXVDQUlSYTJtSXlEMDNCaWs3eHZCK1JlaHV5cVllbllkL0lULzJP?= =?utf-8?B?VWpvekk5eXFra0xGcEEyR28vemJrd29xL3JpVDQ2K25lUFJNSVhwa3pkMFNu?= =?utf-8?B?R2Q2dUt0dFo3VFlwdU44VHVTc0hQMGc5NjZmQkZGM1lmTi9pZ3l3NG43TUUv?= =?utf-8?B?RWh2OThVM2VpcVRleEtBTG91cXVaMTZNSmdUWlorNXcvUGJ4eS9McDRCQWtQ?= =?utf-8?B?MUoyUGU3MHNzeklVSzVjZ1NNTnZXNnA5QnhXcDNCRStSRnc5U3BnUi9PRVZx?= =?utf-8?B?a0xtZnNtT0Z6eHpsQ2xFb01WaGt1RW1aNkJlMGZILzdtb1RDOTQzREhhUzJ3?= =?utf-8?B?RVlKR2ZvbWVhdTBBMmJjcjFxSDFLVE1kb0VWUFZnVmdyZ00xYk1zUXVPMDNw?= =?utf-8?B?ZDgzNHA4TExUMmwvdHY5elgzZUpYU1pDOHRURktBV3N2YkxYcEZQLzdKSU1w?= =?utf-8?B?R3lEVjlkeDh6d0FVeHdyU2dCUDh3Q2lZZEh2WnBEV2RhK01zVFFTay85NXN3?= =?utf-8?B?UU85bldaYzFsb3VlWE94MGQza2YrUit5aGV0MUt1SVJIMHJHNHVkbkQwdFVu?= =?utf-8?B?cWhtNnVQYWRxS08zOVY0TEwwTmdHRUlUWktSbDdidlA1MzdiT3BMeVRyM2da?= =?utf-8?B?dC9LcGgxeDlOOHBRMml2cjNTWGxyZVZtMjdIQkxna2lXcWFpVE1xSkFabzRB?= =?utf-8?B?MFN6TVRHUWRCakV1NEgrMUhtc1A2VXAzWERlM3FRZ3d5Qm96UGVmUFNLejls?= =?utf-8?B?QVd5b0p3TW5iQ0JZNkJ6QkNJdFZaSmhENUF0UW4yaUJocWhJTFFWbUp5TFUy?= =?utf-8?B?YndUMWh1L1lzS3NKeHJOaUZKdk9leEFCVU4yN1dnRjRXRzRTa2ZxUXBORVdM?= =?utf-8?B?S3I0Y0Uvd0t1YjE5YXQvNlAxaVlUZm10WFp4YU9wNWtaZER2QU9XaGp6UHBE?= =?utf-8?B?SjFKQU81U0NjZmZEbmhGSDl0TTR1NkV1eFF3ZndEQTVUZzRZNW55ZFowQnlZ?= =?utf-8?B?MUphWDY5bjRnOWN2MU9qMU5mamJ2Vm9hUzBDZ1pVWE5LelRNWkdOU0I5clJk?= =?utf-8?B?QVFzbzRZMTdkdW1NSzV2NWdHRkdNOUVVamt4cWFKU2VuYXJvUjlTNjhISWcv?= =?utf-8?B?YjRUYWhTVktyZ2IwOHJYYTU2eGJadkVTeUJlL2V2eGoxdCtraEFXczR5REZS?= =?utf-8?B?a3FEU1p5ZE5IYkg1QmszWTlZM1VyRE0xVVZQUUh3QXo1QzdXclpabVJjcFMz?= =?utf-8?B?R2RBT09WMW11aUpuWWRxTlN6WVJmU25Pb0ZYS1NCVGprbUlYYS9Cdm1vV1Vw?= =?utf-8?B?cG54c1oyV0hGNnYyS28ybHpsNGdjVkxtWGNyV3R4SzRMSnhHSFZFalpXUnNB?= =?utf-8?B?NnVNMElEUEdWdmMyVHpjaW5YVXRiQTZEb0pDM29WVVR3SzJLY2dlcncrU2JI?= =?utf-8?B?dExBUmwwY1VwbHdTamR4aTJBRmRNT2xORlJyT21qaFJ0VERKeGl4eVcxNWJ5?= =?utf-8?B?NjFTOUlVWE1NcDVJQXlaeGozSHpDM1hPd3BFNWlyRUpQSE9jWE5BQU16ZnJl?= =?utf-8?B?Q28wWWVBQ3J3aEtJdmdHdzh2OHdQbmpNSy83bnhnV1ZBR3FsY2hZb0N3aUE2?= =?utf-8?Q?g6DE0DOb7vWi951dVVcTjWMKl?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ab24165-e4b5-4636-bd4c-08db4bebcd02 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 15:33:53.3300 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /qSKEzYxXp5UlJBs3RLCbphf7RVbJrX2cagk/opAjDZKWg6seXFDKXD31QlFJmdfcNh9yXf6qaWqAgOnMm9RNg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7498 PHYSDEVOP_pirq_eoi_gmfn_v accepting just a single GFN implies that no more than 32k pIRQ-s can be used by a domain on x86. Document this upper bound. To also enforce the limit, (ab)use both arch_hwdom_irqs() (changing its parameter type) and setup_system_domains(). This is primarily to avoid exposing the two static variables or introducing yet further arch hooks. Signed-off-by: Jan Beulich --- Instead of passing dom_xen into arch_hwdom_irqs(), NULL could also be used. That would make the connection to setup_system_domains() yet more weak, though. Passing the domain pointer instead of the domain ID would also allow to return a possibly different value if sensible for PVH Dom0 (which presently has no access to PHYSDEVOP_pirq_eoi_gmfn_v in the first place). --- v2: Also enforce these bounds. Adjust doc to constrain the bound to x86 only. Re-base over new earlier patch. --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -1130,7 +1130,8 @@ common for all domUs, while the optional is for dom0. Changing the setting for domU has no impact on dom0 and vice versa. For example to change dom0 without changing domU, use `extra_guest_irqs=,512`. The default value for Dom0 and an eventual separate -hardware domain is architecture dependent. +hardware domain is architecture dependent. The upper limit for both values on +x86 is such that the resulting total number of IRQs can't be higher than 32768. Note that specifying zero as domU value means zero, while for dom0 it means to use the default. --- a/xen/arch/x86/io_apic.c +++ b/xen/arch/x86/io_apic.c @@ -2665,18 +2665,21 @@ void __init ioapic_init(void) nr_irqs_gsi, nr_irqs - nr_irqs_gsi); } -unsigned int arch_hwdom_irqs(domid_t domid) +unsigned int arch_hwdom_irqs(const struct domain *d) { unsigned int n = fls(num_present_cpus()); - if ( !domid ) + if ( is_system_domain(d) ) + return PAGE_SIZE * BITS_PER_BYTE; + + if ( !d->domain_id ) n = min(n, dom0_max_vcpus()); n = min(nr_irqs_gsi + n * NR_DYNAMIC_VECTORS, nr_irqs); /* Bounded by the domain pirq eoi bitmap gfn. */ n = min_t(unsigned int, n, PAGE_SIZE * BITS_PER_BYTE); - printk("Dom%d has maximum %u PIRQs\n", domid, n); + printk("%pd has maximum %u PIRQs\n", d, n); return n; } --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -664,7 +664,7 @@ struct domain *domain_create(domid_t dom d->nr_pirqs = nr_static_irqs + extra_domU_irqs; else d->nr_pirqs = extra_hwdom_irqs ? nr_static_irqs + extra_hwdom_irqs - : arch_hwdom_irqs(domid); + : arch_hwdom_irqs(d); d->nr_pirqs = min(d->nr_pirqs, nr_irqs); radix_tree_init(&d->pirq_tree); @@ -790,6 +790,24 @@ void __init setup_system_domains(void) if ( IS_ERR(dom_xen) ) panic("Failed to create d[XEN]: %ld\n", PTR_ERR(dom_xen)); +#ifdef CONFIG_HAS_PIRQ + /* Bound-check values passed via "extra_guest_irqs=". */ + { + unsigned int n = max(arch_hwdom_irqs(dom_xen), nr_static_irqs); + + if ( extra_hwdom_irqs > n - nr_static_irqs ) + { + extra_hwdom_irqs = n - nr_static_irqs; + printk(XENLOG_WARNING "hwdom IRQs bounded to %u\n", n); + } + if ( extra_domU_irqs > max(32U, n - nr_static_irqs) ) + { + extra_domU_irqs = n - nr_static_irqs; + printk(XENLOG_WARNING "domU IRQs bounded to %u\n", n); + } + } +#endif + /* * Initialise our DOMID_IO domain. * This domain owns I/O pages that are within the range of the page_info --- a/xen/include/xen/irq.h +++ b/xen/include/xen/irq.h @@ -173,8 +173,9 @@ extern irq_desc_t *pirq_spin_lock_irq_de unsigned int set_desc_affinity(struct irq_desc *, const cpumask_t *); +/* When passed a system domain, this returns the maximum permissible value. */ #ifndef arch_hwdom_irqs -unsigned int arch_hwdom_irqs(domid_t); +unsigned int arch_hwdom_irqs(const struct domain *); #endif #ifndef arch_evtchn_bind_pirq From xen-devel-bounces@lists.xenproject.org Wed May 03 15:34:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 15:34:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529314.823596 (Exim 4.92) (envelope-from ) id 1puEUh-0007XD-4H; Wed, 03 May 2023 15:34:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529314.823596; Wed, 03 May 2023 15:34:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puEUh-0007X6-1B; Wed, 03 May 2023 15:34:15 +0000 Received: by outflank-mailman (input) for mailman id 529314; Wed, 03 May 2023 15:34:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puEUf-000715-28 for xen-devel@lists.xenproject.org; Wed, 03 May 2023 15:34:13 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f2e70610-e9c7-11ed-b225-6b7b168915f2; Wed, 03 May 2023 17:34:11 +0200 (CEST) Received: from mail-co1nam11lp2173.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 May 2023 11:34:08 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA0PR03MB5641.namprd03.prod.outlook.com (2603:10b6:806:b0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Wed, 3 May 2023 15:34:05 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb%4]) with mapi id 15.20.6340.031; Wed, 3 May 2023 15:34:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f2e70610-e9c7-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683128051; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=ekEcTjd1EIWBQhUD19Z4YcSet7yF/pD6/o03EZiH10w=; b=MIv76NJOjg2jly3xtN2tXBk02CxXPERfCCUZr85UqP4z7nPkmJ4r1XvS v05g6VmxzKQSiuPpRclUdp1gvbKSyU4xlDdSoLbsO907blPPPk0scJ/0E vGmfWG0wE68GJTAS7ELoiZR1LdNHXPFZ+vkSHHnCbNILETez87+VihYNF w=; X-IronPort-RemoteIP: 104.47.56.173 X-IronPort-MID: 108143656 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Gda3bK3OGQxlFd4v5vbD5Ztxkn2cJEfYwER7XKvMYLTBsI5bpzICx zMbD2uDaPbbNmGhKIh1bIS1o01S7MWBz9RkGQRlpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS+XuDgNyo4GlD5gFmPqgR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfAlFOp fo0LCk3dwmMrriM37mEENNSiZF2RCXrFNt3VnBI6xj8VK9jareaBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqvS6Kk1cZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXqjCNtOT+PlqJaGhnWBgXc1Mg84SWCk//OIkWmQafByA n0Lr39GQa8asRbDosPGdx+3unmfpTYHRsFdVeY97WmlyLfQ4gufLngJSHhGctNOnNQtWTUg2 1uNntXoLT9iqruYTTSa7Lj8hTq2NCocK2MYYmkaRA8B7tvkiIo3iQ/DCN1kFcadhdrwHDDs3 z2QtwAuirMLl8kJ2q6nu1fdjFqEo5nCTgcxoALNTG+hxgp8aMiuYInAwUjW67NMIZiUSnGFv WMYgI6O4eYWF5aPmSeRBuIXE9mB5fmfOTnYqVdqFosm8XKm/HvLVYJa7Sx6JUxpGt0ZYjKva 0jW0Stc6IBSOj22arVwYKq6D8M3we7rEtGNaxzPRt9HY5w0fwje+ihrPBeUxzq0zxNqlrwjM 5CGd8rqFWwdFals0DuxQaEazKMvwSc9g2jUQPgX0iia7FZXX1bNIZ9tDbdERrlRAH+syOkNz +tiCg== IronPort-HdrOrdr: A9a23:/OOaRq8hh1kQc0ndt+puk+DcI+orL9Y04lQ7vn2ZKCY4TiX8ra uTdZsguiMc5Ax+ZJhDo7C90di7IE80nKQdieN9AV7IZniEhILHFvAH0aLShxHmBi3i5qp8+M 5bAs9D4QTLfDpHZBDBkWyFL+o= X-Talos-CUID: 9a23:UDe2XG4CXndJyzvKOtss934USsYJdmTn1W7fChWCFm1WEoerRgrF X-Talos-MUID: =?us-ascii?q?9a23=3A9+s48g+KIpmJTCaX1sSPZGeQf9Uv+IKUGm4Rqop?= =?us-ascii?q?YsfifEgJCGRq0vSviFw=3D=3D?= X-IronPort-AV: E=Sophos;i="5.99,247,1677560400"; d="scan'208";a="108143656" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fXDNieHtHUKGnvmk4b3Zxjo2/fB0mBgzGr/wL3cmMwQTO4fFf9+mrZWKFMHPlWdmYt9FTYcbcZIWMvQ/PCIAQnkxRMrLuFr7GRuzDjY1jbCywjrI7SNcdvDtpB+dP9K67zUe2eeZcZQ+ddfGUaH3I583HzKxUgJVSph/942jwG0SnkQNngGnxO1kvpLtws8m/bqqR1InzZiVI0uWyEiUL1gcnaI1y7+mHtAf3tSqRjsI4ttTCdwn27/id9MLL+ONaqdclBxV/ZViKJ8ODUvhbVXJv13MOCDPM2yZ3kZwaNfZ9z8J1s46YTIsx3tNfXNZmPslZk1kpWsA/TPP2+DZYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ekEcTjd1EIWBQhUD19Z4YcSet7yF/pD6/o03EZiH10w=; b=OzPsNNZs+ZolpP5D/Wzqt5TUvJGSCns3IBQabZDuudoh0fNrwTF5XW1PmJfWeUJ27IFbHKs9yLN4Sy5qYJ0bvSMA79oKuaGqUOlZdCZj9cOdy4h1X7b1cpavU2ByMoBCirGtORg+DkIRsx7WkCdndoLhYHLdiNOUUQG9h7oTpG+Orc/6amzrAp34EPoWomejM2dURXNSmmrc7ZcOPj+Ov4s0TTERCtF1n/4cK1rYsZ2oSfQsCHyxgfTLYtP7SQZVhMwjYcf+d3I2ZSMBknDGl2I5q7urD+vLtPSD/ODec+deSaanHK//RQqjb9+iJ/PI62i5eDp//jNIcp50+d+kEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ekEcTjd1EIWBQhUD19Z4YcSet7yF/pD6/o03EZiH10w=; b=PNe1IPb+pQWDI04iuPReezREcYUblqU41cqB+OfuoKK9cAjcBs9fIVno5ce95PKYw2SJaRc3Mv1okNHjFcFrT2DSFSEpjWR1lsYyX2n4wPi4viqNgxeODmMV+A0ZkxHML6OpAf+XLVxdtx3m7re8KkoTTL0fZvW4GR22rf4nSSU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Wed, 3 May 2023 16:33:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: andrew.cooper3@citrix.com Subject: Re: dom0less vs xenstored setup race Was: xen | Failed pipeline for staging | 6a47ba2f Content-Language: en-GB To: Juergen Gross , Julien Grall , Stefano Stabellini , alejandro.vallejo@cloud.com Cc: committers@xenproject.org, michal.orzel@amd.com, xen-devel@lists.xenproject.org, Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jan Beulich , =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= References: <644bfbc6939d8_2a49bbb403253f4@gitlab-sidekiq-catchall-v2-78885c497-qxnp2.mail> <28235d38-ad7f-f1bd-f093-bd83f9fd6589@xen.org> <998dbbeb-94d7-7afe-e4c2-02ef134cbe94@suse.com> In-Reply-To: <998dbbeb-94d7-7afe-e4c2-02ef134cbe94@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P302CA0015.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:2c2::11) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SA0PR03MB5641:EE_ X-MS-Office365-Filtering-Correlation-Id: 7ea3f220-1edf-4c54-ae9d-08db4bebd43b X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bKg+BguLZd3M8LgHp2jBZmxFW1/b7xtoAYyC1RjhYrRqpPncGu0VFVc3eBAyTQgw7GLsauO1jJZh9i016wHQPZz8h9dh7ZEMJcsc/ho0CqAeTw7zgydPneH4XEeDx+3XwWT3LdYWoCsUdPJqgA/GV2UIOxr+gzAaKCavSIM/GV9lHU0wKcfh7goQiSPHXEBEiSeAs3UF+FzT3CY+ygyTJimYFYdz9lUslLsJ54gXgV1fN74109lfx3h3wYRYIFf40E7IDk1yzVgolIJoya+iO0fwNLFwKYuYvLgJUaWPlGs6oVry6ewTxO4QOJZuCk31Bd1OGIwSwBA+YzaDESY3y5WinwP2OvxilnPvXfdGSix7sIhhlRbCSNz2oX7JwubJKE+vV+ouSywAxiuz5X6VRKkUlpV1bmtICHGK02pNVd2IJBW6x7FXJyrQ1vymq4eg77BYl0ZhmVZ9vb+TBkviwBD/+aN2C95ezTihDHycB6vT8ri0qXhFMUtVipgy2SfrV8XverIBmBsTOyzCPVtIn7a0F/V5KUsxgJvlJyzRpFMdBdJ3i9JjOwWX4vtllmEpsfh7aQ3UFkyb+UQHCtxSuEAHqbten/7THpED8mQm2nlO96DbjRac8Uz+qRKrmPya X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(136003)(366004)(39860400002)(376002)(451199021)(6666004)(186003)(6486002)(83380400001)(2906002)(53546011)(9686003)(6506007)(6512007)(26005)(966005)(110136005)(478600001)(31686004)(2616005)(36756003)(54906003)(66556008)(41300700001)(66946007)(82960400001)(316002)(86362001)(7416002)(38100700002)(5660300002)(8936002)(8676002)(66476007)(4326008)(31696002)(32563001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MEF1NVdWVmE5ckNtQXlhQkZRRk5PNXNSSmxZOHViUWRjdW5pdWRRU0RnNjh2?= =?utf-8?B?YlFldGNSa3MvdnpUcHFXM2JJc3hBMnBUWjRZOUJ6OS9CSTY5YytJUmMvME9T?= =?utf-8?B?clhZQmNleVFMeGRjUlM3Kzl2S25ZNHpJY2pMVGt6a1Q2bzArU0M0cW03OFFL?= =?utf-8?B?WDRBZ0dDTUdJemtMb1l3dk5jZDNpK0dKb3R2SWZBcEtZRmRqQXVjdUsyQkVw?= =?utf-8?B?aURRT01KQzBVcFREckdPTG0yZ2JsMlRKL3NLaFczNnUwcHF1cDUvaXZHL0JX?= =?utf-8?B?dEp3cEtXT2preDdjYnBUZC9oV25EYkNqZnRCZnZnQUtGNkJxWDM5RXRGbmlZ?= =?utf-8?B?MVdWN0F4WERRSE5HbmZyVXcrYURFOWl3MWF3SlJLT3FPTHRoVjJIOW5XZDBX?= =?utf-8?B?bFg4MnhmcnNwQzdnclBlVitWL1loc09UK0N1Z2xqeDRUcXkxMVliL2ZHODBU?= =?utf-8?B?cDNGeUU2RlpVaXR2NktHdndlL1hmcjhScEQrdEV0WXZQTGtkOElaOGRiYzBY?= =?utf-8?B?UFg0MmE1dHpybXJqTW5QUUlDRG9wVEx6QUJJMXpvT0J1Ti8yKy91RFlUN20w?= =?utf-8?B?QXNqTzd6a0RZMkY2Zis3TDZ4T1R5NVhTYjkwQUIySXEyamtBZ1lWdTJ5YnZz?= =?utf-8?B?K3FiaWZMQlhTK29KazVhQTI5MjlEWklxZ3g4MklpSXJFUTJGVjB3V1VxVUpt?= =?utf-8?B?eWJQVHEvVGU1WTlNNmNXVFNIcFYwNWExQXVOV2dJMjJCNkg3RHBWeG5McU5z?= =?utf-8?B?OFBpajBObFNqRVk5b0RPVVNaby9xMXlGaHJDcStJVkRJbnFuRkF3YnpvZVFI?= =?utf-8?B?T0Fjd3h4aXdVaEQ5UHdzMklTVS9XdEdLTkVKMXZ1THVFZHFYczFqM2dhQXpo?= =?utf-8?B?ZWRUbzBRTlo1MlVFUEJqRS9kZlJpY3o1RVp5a3Q2dU5rVVFjNDIzZ2xhckJl?= =?utf-8?B?ZXZOR3hBQ2h4c0hRV1VwU0R5bytiRFVqQW9pQlEvcXdTeHhDMjhXK3Mza1Ra?= =?utf-8?B?UGhoNjJtVm1MbWJpOXZBeUFvSnEydHpJZVIzM3JEc3BCYm16cG9RRjgyL3JL?= =?utf-8?B?alNtM3daYUljaWFmZFlMMTRzSmVBc0ZDdDIrc0FFaXdnbk9lRFZPdUcwQ21z?= =?utf-8?B?NG9mY3ZKY2pYanhXc2N1SWVGeW1JOWFwb2I1QTc1b3pGZ20vZmR1KzcxOHpW?= =?utf-8?B?VE1CVTVBWUIxS2NNa3VqR1VSNzgwRU1aMk5PNHlHQXdaL3hlc2U1eVczK1V2?= =?utf-8?B?TmxtU3JBZDFwYUZXMDMrZFkxSUNZdDgvREMyZXMxdFJOSitwMGFYRVlWNWpk?= =?utf-8?B?ZGZzZkQwYVRMOTcyRkFhbUhYTHdjRi9rNTd4bXJ0NHREZ3UxbXd5eE1lT08y?= =?utf-8?B?MTFnNjZybUtLOEJVWVJWMEk3aWdtSExKM2hMSUF5V01PVThPR2wzbzYvMC9I?= =?utf-8?B?VEU4Y1oyUU54UlRLUjlQbzdEK2lhZm82NjF2cHRJUExlWnRSeXo3TGcyR3Zx?= =?utf-8?B?dHNHVlM1cy9NdmxrMXY5OXRUNDZTVHNhOThtamp6d2MzbDFRc0lMVTBQMUQ1?= =?utf-8?B?R3RGRnNmbkJyaXdyWmtieWV0SXNnRnVNWEtGd1hCeGhjWlZHT0liUDBYV0J5?= =?utf-8?B?MGp1ZWhYUTNDVkhySCtmc3h5WHRCZXpwWCtHWG5zY2hoa1Y5VlVYWGVPcUFv?= =?utf-8?B?elhJRC80R3haL3hRZzFZeGhYVnBmREtuU1hvbWtNeVdxYTZxZzdaczBrV3Qw?= =?utf-8?B?eHF3QlgrcFZGdWFGQmE4REErZERHMFlyR05DWU9VdlFKdUNrRkVjdmVxSjZ4?= =?utf-8?B?MjZiaHdDaEZRWDNOWTVhZlc1ZFEwSTNJWEhNTk9Ld0h4YnpxWGdvS0hJQy8x?= =?utf-8?B?RE5hK1dTTncvV1c0Z3Bxd3VMRXVlR2dsSG10b2pCc09lOU9LUFp2Sk5FUkZi?= =?utf-8?B?cW5DTGIvZ29yekFWRHU4M01rVWlic2w4dzI0cUhGS296QVNvRjU2bVkrZWMr?= =?utf-8?B?TlBWV0huY09TMmNFTkhDeFc0YjJDRlQzZzdVWWh2QmRtNGpVWU5jK0JBY3dq?= =?utf-8?B?dE9lWThoYkx4Tjd3ZmJ5WVg4eUt5RmIrbTZDVU1OYzgwcXkvY0N0bHhwYkVH?= =?utf-8?B?OTNyTHJheFR3TVduRzcrTE1EanU1Q3ViOWFSNS9IVlZFN3d4ZjlPM3pYcUpl?= =?utf-8?B?Smc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?UTArT0NlVThwZWJ5SCtETTRnNzBFeXJkTTdrYU9Vd09zN3dXRTVSMHpKWWZZ?= =?utf-8?B?ZlBYS3BhM2gvd2FMOU95RVJNQm5uRFQyRUVNSUcxbXRpQmdEWUl5V01pTUM0?= =?utf-8?B?S2oxOTF5Vzd0WER6cEZYUVJ4THZQNU1GWkVzM0xZcDQ4MUVkbWgzbmhqc2pO?= =?utf-8?B?YWwvYUtXdm9mbjNBVlZvSDAxaUpwcCt1WjNGMWtIb0FraTl0R2FURzIrMmdV?= =?utf-8?B?eE45eDFpUGZadXkzYVhxUTBqTVo0VGk4dzcyaG1QQ0Nxbitzc3o5QWlGTExK?= =?utf-8?B?V2ExSVA5QnRmWDFSY2xKU1hNVWhGMnhDTy9GaTdXbTU1aXNUeWhncUlITmZD?= =?utf-8?B?OSsrT3hPZHBwM21UY2ZaQWJsTmhUTVB0UG94WXVXdTJIUzNFRVN3dldBMjZs?= =?utf-8?B?cVNBSGwySTZDQ1FVNDVJMU1XNnNBaU5wQTkraVNIUzZ1TUJoYlVEamdSbXhP?= =?utf-8?B?RnFIcnRZVE1EMGVsMU9IRm5LNVFhS0JUY2lwWG9ReVMzK09ZUTlGVng5enBw?= =?utf-8?B?Uy9NaUJDZjlZcU9vRzdoN2NtSHN0SHNiWit1elBXSEpFaEsydW9MUVFhTTFC?= =?utf-8?B?YWNkMUd1NFNpV3dQU3pYdS9hZFE2QThtazkrcUEzZVdXbTRLK1FETHBmcmFa?= =?utf-8?B?UW5RUmxiN2RKL0VweTY3VFFZbGtaSkdrVERMU2IrR0tmVS9RMjNuQnRuVHJh?= =?utf-8?B?L3pRUzNpZDRTdkxzVDI0OHErd2UzYVNpN0JPZTJHL0hXNGIzMnV5cC9DVTRT?= =?utf-8?B?eWNXcTZneVV4MkZDQ3EyVHlWaHJuV3gyMGhTbncrODFwUXRsMGhMbG5hUDAv?= =?utf-8?B?U09HRm0vTWtNcFJaNkVad05zZmR6MWlZTENVeGxmMGdpOUQ5UkcwZ0ZEaTl1?= =?utf-8?B?UDZ2VENZS2VIUEtOS21SNG5zWDZwQ3dvOXFiOUhlQmJ2MEtJVVVHaVRIamxM?= =?utf-8?B?K05LZUJtUmFZb0tmdk0yVWkrNjFWejdtV2F0Y1Jrc3NIcG0rTXJtbTduTGMr?= =?utf-8?B?cUM4OWZlWkRFSXQ2eTZ2NVQycHpqei9KUi9SbmZBVlFyeC9ITUNkaDVjaTZB?= =?utf-8?B?QW1QK09tZWZLUnV4R0dENlc3Y3FxZ0ZORDlIdEpxem9uU2VMM0g4UndxT3Fz?= =?utf-8?B?ek5hb1kyUHc2QjJGWVJHbDg4Ly81ZFc5TE9Wa2RWL3BkcVJ5ZitzVVI4QmNj?= =?utf-8?B?SVo1SUIyQ0ZhcG41dkd5TW9mcmVsLzBBeHhSUC9KK2VnQW51MjdLQncrYWQ1?= =?utf-8?B?ek9WYWpDc2VkbUxkSkpxd0czTURxdmpKaFdmSGI0WTJiK05nUT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7ea3f220-1edf-4c54-ae9d-08db4bebd43b X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 15:34:05.6501 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HLusJwCxuNLJiGgUqgBRoOb1yYN5fbfr8F4Mwmcqx1jvr/FiHdi0lRI6RVZZGpENJaMhShDgsDXXWO9oZl2o6e2L4txyR9LUSU8sR9JU9qI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5641 On 03/05/2023 4:22 pm, Juergen Gross wrote: > On 03.05.23 17:15, Julien Grall wrote: >> Hi, >> >> On 03/05/2023 15:38, andrew.cooper3@citrix.com wrote: >>> Hello, >>> >>> After what seems like an unreasonable amount of debugging, we've >>> tracked >>> down exactly what is going wrong here. >>> >>> https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/4219721944 >>> >>> Of note is the smoke.serial log around: >>> >>> io: IN 0xffff90fec250 d0 20230503 14:20:42 INTRODUCE (1 233473 1 ) >>> obj: CREATE connection 0xffff90fff1f0 >>> *** d1 CONN RESET req_cons 00000000, req_prod 0000003a rsp_cons >>> 00000000, rsp_prod 00000000 >>> io: OUT 0xffff9105cef0 d0 20230503 14:20:42 WATCH_EVENT >>> (@introduceDomain domlist ) >>> >>> XS_INTRODUCE (in C xenstored at least, not checked O yet) always >>> clobbers the ring pointers.  The added pressure on dom0 that the >>> xensconsoled adds with it's 4M hypercall bounce buffer occasionally >>> defers xenstored long enough that the XS_INTRODUCE clobbers the first >>> message that dom1 wrote into the ring. >>> >>> The other behaviour seen was xenstored observing a header looking >>> like this: >>> >>> *** d1 HDR { ty 0x746e6f63, rqid 0x2f6c6f72, txid 0x74616c70, len >>> 0x6d726f66 } >>> >>> which was rejected as being too long.  That's "control/platform" in >>> ASCII, so the XS_INTRODUCE intersected dom1 between writing the header >>> and writing the payload. >>> >>> >>> Anyway, it is buggy for XS_INTRODUCE to be called on a live an >>> unsuspecting connection.  It is ultimately init-dom0less's fault for >>> telling dom1 it's good to go before having waited for XS_INTRODUCE to >>> complete. >> >> So the problem is xenstored will set interface->connection to >> XENSTORE_CONNECTED before finalizing the connection. Caqn you try the >> following, for now, very hackish patch: >> >> diff --git a/tools/xenstore/xenstored_domain.c >> b/tools/xenstore/xenstored_domain.c >> index f62be2245c42..bbf85bbbea3b 100644 >> --- a/tools/xenstore/xenstored_domain.c >> +++ b/tools/xenstore/xenstored_domain.c >> @@ -688,6 +688,7 @@ static struct domain *introduce_domain(const void >> *ctx, >>                  talloc_steal(domain->conn, domain); >> >>                  if (!restore) { >> +                       domain_conn_reset(domain); >>                          /* Notify the domain that xenstore is >> available */ >>                          interface->connection = XENSTORE_CONNECTED; > > I think there are barriers missing (especially in order to work on Arm)? Yes there are.  I think x86 skates by on side effects of hypercalls. > > And I think you will break dom0 with calling domain_conn_reset(), as the > kernel might already have written data into the xenbus page. So you might > want to make the call depend on !is_master_domain. And this is why I am very deliberately not doing anything until the documentation is matches reality, and is safe to use. For starters, shuffling this doesn't make any difference for a domU which hasn't been taught about this optional extension.  Ignoring such cases is not an acceptable fix. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed May 03 15:54:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 15:54:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529322.823606 (Exim 4.92) (envelope-from ) id 1puEns-0001oY-Tt; Wed, 03 May 2023 15:54:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529322.823606; Wed, 03 May 2023 15:54:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puEns-0001oR-R3; Wed, 03 May 2023 15:54:04 +0000 Received: by outflank-mailman (input) for mailman id 529322; Wed, 03 May 2023 15:54:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puEnr-0001oL-RI for xen-devel@lists.xenproject.org; Wed, 03 May 2023 15:54:03 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2059.outbound.protection.outlook.com [40.107.7.59]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b85d7bbb-e9ca-11ed-8611-37d641c3527e; Wed, 03 May 2023 17:54:00 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by VI1PR04MB7183.eurprd04.prod.outlook.com (2603:10a6:800:128::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.21; Wed, 3 May 2023 15:53:31 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 15:53:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b85d7bbb-e9ca-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bjb8BEJj0PYX7jh5eTsnRZYJT/OqHwLu1yxqLdmcEoz3+b0vR5QJ4irQXi04nd/F39NLnD0A35wsx0MQDVjgeiNkzzPcB1BD/SRVSygfIdSdjLMfWkyllKnp5ULtofG2RENazC8pftLy6Vwp1MqNevIeKCxiNF6+w5gT7JNYyqVCAuzvIo2seDo56cWPRRH7urzAwMkmXuARUTWL1ecgGLJkDLGFZF9VNzwqU6oOYAfeP6+6i41e3GT88ihr3OFatS75alePmh/4Ockdz0mw8DY/HpOly25xpbgpFZy93JhF+hAiY4huqYtJ1LhOC3qNpm1IVwTjoYdHFHUDygJQTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+q1JcwX+Pu//DS9SDuAr7savIZQBK7Vvwp/Ti40aPT4=; b=BtlQrmpw6JlLjgYKRNa0EQNrdNfaih0UMFhfclqidS88MN5woWRMBVvBXZWE/4loVpph1q+iKWbNK/QZFGVnbku7UFASp3YXvt6sdwNQ0JcHQIUDdPj8BHDGClvnmClBZaGFc7f+ZX7wVGZFQ8SDiqN1v2O3bSGPDAmpwc8sUIQ3MdWINyPIYPiZSVYQbw9R3F/xThhc5MT5VgBQrqVvpIonDQSXrGivihmzDQ8ZvFlWuAORCMdN4nKkq7Tb6BWwcL32NP7fSf0dnsNoFB2ao5UPIUX+g/ViWowEdeoUF9Mi6x2Mb7Bg+6ZwAIhbinIjy7c0dUEF02vzVxLKFm1FRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+q1JcwX+Pu//DS9SDuAr7savIZQBK7Vvwp/Ti40aPT4=; b=JRgaaE2k4VlhP2MKPwoVmj1rHn0FWA6lSyc/dZVuNFSanSJI7c33644RuJMM2MdLX2jE1ufzlq4STsWxJGWGXVPmzSE5tcjqVXYSHGpAdkMZlquu+Yqxsax8N6PRHRhRvH572yZKx+xKHBzVW3v98SeCO5HJODf+ZVQdNjfibJ08opjJAICrdEnqVSHOr2JJ1NWVf8HLi4bxtGtkV3nKpgnFEKzRwTgEyNnbCaLwi7BZ7NIdTYYku1pUWY7XpElAudrFyIA3PaHpHcPJ2GcPYq6kZ3bFNIRWj0f8Z+loX4QQu/eK0vcgOuOVBys61VJ+osrt21kHYD4wX3g3kbaUaQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <472f8314-9ad7-523a-32dc-d5c2138c2c8c@suse.com> Date: Wed, 3 May 2023 17:53:29 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 From: Jan Beulich Subject: [PATCH v3 0/8] runstate/time area registration by (guest) physical address To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0269.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b5::7) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|VI1PR04MB7183:EE_ X-MS-Office365-Filtering-Correlation-Id: 31ab90fe-81b6-474c-a200-08db4bee8b3f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XrrkzfdvYkXBQMMtx5RdXqr293tjkkXppdHW4t7rGB5z9+eN78f9SfFU7qk9gkSsdEvtEzIudKG8jRYBz96FVqfYrW66ixOt+xeo/CKiYWd77sn3pjTlbHtvkgj0TD0iO2ef017/ow3jK9Qs/pUc8+4cWOepoGM1gBVOrn3g9IkEyJSngW62TwTuNFSH7vmkQNtEeut7JUugmscN4DyuZlPptyNWsdVUVuy2+TsdL6HpBmlr1LL4ltXmcKsgZzMbCHJr9HGd9rQuzBqnSbN8aPyeJAUBa1P5wmOUM8ajBrKiufiTyqSMjsOAaYMXfzOSyui/kryAMdzt+GeMF+6DJb5AgmvjzVO1USdpAmql0hnKtRPBUxd8Bh7lpek8Ro7t5Jphbe3cIYaF7Ve0ppTEXLWooSSjIBzYs9gmJQbT44KYdI7VDwH6dSe3RmqIL0v869UHVCvmv/Ah+ILXeqsLNDL/v+zldXSrSrJjggaHs3m4pSwyaRu8QLeutQ85ygNqwh84cUQDaj0JPYmMjLptSR6F7MJv4bKzNiAScYoIu8nLfKEeVLyeMqg6kegoVVeBv5KFV/embj20jI6C+72hPHuL+EOIxLYhCaSsh1URlzVmIkALmFzGbczJeqcLjuev8pdAKA8+/nE/kO8X9Flu4g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(376002)(366004)(136003)(346002)(396003)(451199021)(4744005)(38100700002)(2906002)(8936002)(8676002)(5660300002)(31696002)(36756003)(86362001)(6486002)(478600001)(54906003)(186003)(6506007)(26005)(6512007)(31686004)(2616005)(83380400001)(41300700001)(66556008)(66946007)(66476007)(4326008)(6916009)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MUxqQzBqc2kzNDFYeUpNR29kQnFKekY5NmJUTVpDcTZuY1pKRDhFSXRlTGJI?= =?utf-8?B?ajhjOHlMUTZiTlpXdC8vOCs3dG5lOGh4MVpYNXFtd1BhZjFaNC9BZEZkU0Qr?= =?utf-8?B?RVRDRmtlYlFtQnhUR09lV0NhQlB1N3Y3U2VnQ0FlV25ZOFM3WFlvdkZOMDkz?= =?utf-8?B?bDlNbFd6ajd0cllKS0dGMDBhbkdrdDFlVEN3VGF0emtEcTVvbHVSbnIyVDlT?= =?utf-8?B?U292bTVTeEhuNDhhYlMxM2d0dU5ISVFJVE94dGJFSzdwTEN0Ky9HZlV3dmpL?= =?utf-8?B?RDlUck1HNzd5R0V1MkhGcGdSOVUwQ3huOW5FMGhOZWswckVuQXBBY1hiTE96?= =?utf-8?B?bzV3T0lOZ1BBc05yMWxaa1c1RmRKcEg3c1JZY2NrVEZUNFQzNW9QSlJjUk5J?= =?utf-8?B?STZIMFVYV210enRnejBHNTk0MlBpQXVZdXRLOG0xSzRPZ01nRmo0QWNGd1NP?= =?utf-8?B?elFyTG9EbFJsNHU0dGhTbUpCWlhJZDlraTZzQUxsMFhBVy9RNjJnUzExd3d4?= =?utf-8?B?MXhTVGtaaEFHdFkxaHkzOVdBY3BPSVV1MWRlYWg5d1plalE4dnZDNzE4NW1X?= =?utf-8?B?eEV1NmtCWEp2ZUhMSGFzNGx2RUg5QmxxZWVJcEpNWnBOZDJOTkZWN3ZWVFcv?= =?utf-8?B?Wi92QTNFWHdPdW9NN0dIQ1dCK2RvM2F3NkxWSkcxOU5jRUlCWHNJd3NPMmQ1?= =?utf-8?B?bDB3dHVydnZucG5jajJ1VSs5YjRHbHZNejlKUDZLUCtPa3hTRlJQOE9ld1Zi?= =?utf-8?B?YTVMSHlDQXI3SWVQUnJBRUVTTCtLUnhxN1NPb1BLQWZGU01weGFjd3VaSVc3?= =?utf-8?B?TXZiYU9nNFY4RHprRitRNHAyUWFkQjdJS1NVRWtRVmhuRFBZUDFMZHhPSnp1?= =?utf-8?B?c09FaS9yWklsaXpwbWlSU3YwYXZRZDdUeFZ5akFHWnRaTUVHMVlwd0hHQjJy?= =?utf-8?B?Wnk0dnhrSEYrYXViYy8zQzVDMGIvZEJ1bVFxeTVySTlycXloRTlTUWh5Qkkz?= =?utf-8?B?TTNYbzBvVGVYcTFrcUtrME9sS1dKa3UzbHFZRi82MHl1S09DaEJxRHlwVVFX?= =?utf-8?B?T2RnZ2wyYzdWKzNIekV4TUNjQzV4OFF3UTB6NmMvV0lDcWI5S3VTcmFjU1Fy?= =?utf-8?B?dzFmNlBlZ0RzMjQrMnA3OC9FanpHK2U2UWRJL2ZaNkZIVER3UlR4N1lTOFdD?= =?utf-8?B?Y1NxTFV1Tmp0NC9xak42M3dCcDV0UXllaTV1bW1TQU9EbDA4a3BFSHNnOW1I?= =?utf-8?B?NXFqK1ZYRklsY3l0NlMyZG5TdlZCK2UraVRwZzF3M29kcGhWdmdXa1pFR0xJ?= =?utf-8?B?Z0NqMEo3aEJybnQrMTZRZTR5Z3gyam5BQ2twNCt4elFTMzJvZTk1NnhZdStC?= =?utf-8?B?dGUzcUJVWTdqeW0xZkM5QlpJSTliUHJ6T0k0TWJqcllJeWx6T3QvSWJaZDZH?= =?utf-8?B?dzRsVG9vT1hDcEh6WUMydUlPcmZWeDhUeUhsWURjWWJ0REhOcEtnUjZrS3VR?= =?utf-8?B?S0JQSGhlV1l6SGRVMGhqYmhySUxWOXZ2eGZhU0kvVlp5endFT0pMN3NkM0tn?= =?utf-8?B?S0JoTGNjTzdFS2pNTUtKbXpsZnQ1MVducnhBMHA3aDg2cWJsWWtjT2N0QXlo?= =?utf-8?B?QlVDZEZCdWlhdFBrUytUN3haRXlIdGt5MWQ3ZGZHOXRWWW1ubEZSNlB0Ni9m?= =?utf-8?B?YlhQNkFWZHlraG5kZzVkVXNPeThxM3VGSlN0ZkF2bzlSOVVIR3E1eHplVkxW?= =?utf-8?B?WHp5UTdvRnlvdGYwTGRkYXJDeStDUHlOaDNGL1VxL0swNmhhakcwUjhQK2hz?= =?utf-8?B?NE5VY0JEMy9ONWdQajd1TXFYZ29CY09oM2FKNHc4UzJEODNsTG1vRzhtNkQw?= =?utf-8?B?RXdBNzBHMDhTckxSazY1N1RRbWNCRVZPSmsrcThCYy9iRWUxYTlmRW9hOW02?= =?utf-8?B?cXNoaERsOG1MTmpRa3lCLzg0OEpVakVvUFdCc3dLYXdiSUc4Tmw2S2dDaGdB?= =?utf-8?B?U2s0THY3SmN0ZE4ybzdTQnp2V21sVzV6clZPWThUOG51YzZYNUR4U3BVVEdP?= =?utf-8?B?bGswb2V4NTE4aXppQlZaNXJiWkJNYktwek5WUDZZaWlWRHNYWG1Od3dTNmhx?= =?utf-8?Q?S9Bnow7KxREHAdw5vGDCqbWwl?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 31ab90fe-81b6-474c-a200-08db4bee8b3f X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 15:53:31.7567 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JIDX0MEPcQl6k5iarXJqr0Us8GZ/+wYEt85/K7TmBDv+bZLlEpp7V/pghU/yE3nmsr1si/6r9RLq1Dt8QkUyoA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7183 Since it was indicated that introducing specific new vCPU ops may be beneficial independent of the introduction of a fully physical- address-based ABI flavor, here we go. There continue to be a number of open questions throughout the series, resolving of which was one of the main goals of the earlier v2 posting; v3 has very little changes and is meant to serve as a reminder that this series wants looking at. 1: domain: GADDR based shared guest area registration alternative - cleanup 3: domain: update GADDR based runstate guest area 4: x86: update GADDR based secondary time area 5: x86/mem-sharing: copy GADDR based shared guest areas 6: domain: map/unmap GADDR based shared guest areas 7: domain: introduce GADDR based runstate area registration alternative 8: x86: introduce GADDR based secondary time area registration alternative 9: common: convert vCPU info area registration Jan From xen-devel-bounces@lists.xenproject.org Wed May 03 15:55:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 15:55:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529325.823617 (Exim 4.92) (envelope-from ) id 1puEp7-0002Me-7X; Wed, 03 May 2023 15:55:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529325.823617; Wed, 03 May 2023 15:55:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puEp7-0002MX-4J; Wed, 03 May 2023 15:55:21 +0000 Received: by outflank-mailman (input) for mailman id 529325; Wed, 03 May 2023 15:55:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puEp6-0002MD-1O for xen-devel@lists.xenproject.org; Wed, 03 May 2023 15:55:20 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2081.outbound.protection.outlook.com [40.107.13.81]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e64e6568-e9ca-11ed-8611-37d641c3527e; Wed, 03 May 2023 17:55:18 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DU0PR04MB9658.eurprd04.prod.outlook.com (2603:10a6:10:31f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Wed, 3 May 2023 15:54:49 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 15:54:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e64e6568-e9ca-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EWxT0JNuD/IcywYuvhA5HvAE1wg0FUD86AIUHN3xrgU2LOGT1lIEST8aWLu15jfJRV41koLhE+PglHGgE2nurqYpdJ1ihUX9ymRRI7k1fMIXJt08HazO+/2WYXqfyVunJUXi595easd5UDF7J0npFg/O6F8uPpzfxn5Fy7G+Hwr2vu4Wx0zPOgUnolSf8WU3xXml7DwGSCz0eJ+f73WrutXcMcTN1GXnACEqxP/CBz/2efMide4JVDF+in+8qIX6ZiqJp46UumsE+65+CwiAjUOaR7lpJs/3cqJ1oeBtV3qWemfhxkO2DAOWO7ELNyxJ3095CoorJP4xHDQxL8MLGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bQ4sjL50lVdQLdIcCEEN0lFGFwGWLMMNd8s5YRynU9w=; b=CTnIt+QB4/HGpwjgHslqoHPIvwZ/DbsXDv9ayW8eRDJDJnL0stGVaMX+d5r1KLB/gozgW4NjAGUtTS/ZU2vT86AEigRMHHbI78Fx1eBCaHakjgnZR1JDOZ69WJQnF405r15wAbmC1BGQvl7wHQE+DZvJqys4i3Niz6ojw888ajbSQkc92fF6m50kibj6abRiDoHYbNpFQgDhB1wOT+w1mkWxVlx55gnltDdEwDqe8+gk333iJdkQe+yzxD3zD/dLieDs14pf+UQ9JrMWE00SDwMlSnRRnBmVg17ek81KpBfUtNscHYIvF5pRzihnCiadFcT9yOQydLcHyxpvHkWq5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bQ4sjL50lVdQLdIcCEEN0lFGFwGWLMMNd8s5YRynU9w=; b=ZZDp1jAKFNSe8oww7lYPnsm8pgapYjtkSCYrIbasG0m5wUCUl3BoPaWP+41vIMb7/9BpmVW4O8SeyRwkzgaHKms32pdoTm9wh0IaR0ZVnks8KkoNB9SwkT3iLarwrDZ3+oL2T4C1xGALMo+XGV14kQKuHL4seeMgM0SUBVck4J+RLZW0qnaiaMHT5/4PGRVZpCv0X4Y4kFMnk7mSPCgv70o0uze8YcLE7ONkZDZIn5gv7XKC+wn8zMruD8THSnP0l/IIJTTQZ7JtDfk0WU+qGLVT/gpZcHzQmF1N+feyFW3WLKnMSh4tal3tI1vbkDpnDmV0uxMaNjGX5i6pIl0LuA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <68cdb299-c41c-b6a5-c9ce-bd915508ecf2@suse.com> Date: Wed, 3 May 2023 17:54:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: [PATCH v3 1/8] domain: GADDR based shared guest area registration alternative - teardown Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <472f8314-9ad7-523a-32dc-d5c2138c2c8c@suse.com> In-Reply-To: <472f8314-9ad7-523a-32dc-d5c2138c2c8c@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0015.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::25) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|DU0PR04MB9658:EE_ X-MS-Office365-Filtering-Correlation-Id: bf5e5982-4c31-4f43-a921-08db4beeb9a9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8ATUtPuHGqXm+bDAuOd4cESMq7QuAD5Bkl4WjdS+yLWHkRmIwEQRpcDq5uaI6FMIJt0OYLiSTAoWZFaY31zfksU8XthFysVYI1IIm74HIZ58f2ot0pMCRpjJntofkvSdr7b+wjsyptOT5sPv5uy3AmGhPjqHeJXS3sdgoIE4atYlBckRsyqhxhUTnPHA5uTHOM+io0n5HEjANeKCUxUaWzobehyKYPFCYKWA6nIXRkYeY75tCmkH6X4Z9PlifzmpBDsKlGUHdXu2LIbrBrzrF7idClVzuYxYq1uaC5As8bbIyuCeV5olTM4Sna2kW3cMPgXfJIEH4ucWvr0hkIpd5mMeXE4aplJn5yCvrN/oTSqFPsEJuJTQi2DxQuRmaH7Z406+mNMFqK5AKNURIyjtXB3d/G6sZDCmr1LcqclXkSKVrLEOh0mtjMTq60z0wlf7y2Fjy6C+oa6YsUC/WbmUOvo81wAvu4VE+vSDIGJuTRqP++hmiBbJm9Ied+0bsBeidMRf+DnwksCOeAIf2iNOLOjKj3ZjnG6esM4cG9Pknxb8cCtUefOpsH2W5ehTdjRVgJqcQBoDjdI6T9pMqfJy4pIIduHcoF9uwmaSfI9XQ0JDI5hCcTNXtuiCvek+2uBUaYciijoIfCBO8W6nkpFDqA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(39860400002)(346002)(136003)(376002)(451199021)(31686004)(66946007)(6916009)(66476007)(6486002)(316002)(66556008)(41300700001)(54906003)(4326008)(86362001)(31696002)(36756003)(5660300002)(26005)(6512007)(6506007)(2616005)(8676002)(2906002)(38100700002)(186003)(8936002)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVIxM2hvYityYm5yTm9xWWdYODViekMxN3VjSDVtR0RaamxVT1BXQnhvdlVZ?= =?utf-8?B?SkJWLzFqZDhYU0dPejFvUkVFT1hPNTB2Ymh5NXhGMnZXVVQ1MU9NVTR3dnM0?= =?utf-8?B?YlpwdEYwdXNsZGFYNFhFYXQzR2JrZk5TWStqT0VyWkRZRURicVhzMVVhL1pQ?= =?utf-8?B?Y2ZmVjFxVEFxSmNFNHBEL3RMWFB1NjdoZzEwYytWMGRDVDUvRUluaUg3NDdY?= =?utf-8?B?MlYraHdDdkthNkF6aUlBRjNOWjR4QXBrbFV6VzhUaUhJTUJ5QWQ5RUtYNHJl?= =?utf-8?B?Ym5YcHV4TmlUdXJwTGFqa3krbUc2WWFDd2VwOWU4UHB1VjFoMUtCSkVYTytV?= =?utf-8?B?em1FSnJ0OTJKZnhubU1RZUdyTEthYzFtSWVYOGN2U1M4TGtaVzJEc1V1aVF0?= =?utf-8?B?Umo4OUpPbldGdForbnlsVm9rdE5hWE1pOVdPeTdxcitLM2hveDB1ZjI4T3N0?= =?utf-8?B?UjNPU0JmZ3FyQUwwL1VRZkh6WWY0dkR1VEhPRCtVNXZnalRVemVhUEFkUGsr?= =?utf-8?B?VGJLL1EwdlhCNjAwbDJ1UGhHclRsd0RucDRXTXlwTUJ1YjRTSUdyKzBUVVdU?= =?utf-8?B?ZVZnVUZ2K1lESU5UR2dFdG1kUnN6bjJDTm9tLzc5Uk1JdkVTQkhxZGNTUjkz?= =?utf-8?B?TDJ1c3VwaGFqZEZYNlN3MUptZ3NUQTZJaGVOZ25KbkExL3NpdU0ybDg0NHFk?= =?utf-8?B?Q28rZGlLYi9ZVlhMOVFNMHd2T01LRG1vZ2djV3lHSzh0WE9ZNEFFWWZKNHo3?= =?utf-8?B?clNWOThWU1FiTFYxK2VKbUFrNG02bEJTT0YyUjU3Q0ZlbUhGNi9yckl2amls?= =?utf-8?B?T25iTGdqZWNFYW9GTUhYaVR1dkZSUTRiTVN1UXZrOFJRSkFVeGhnZ2NhVURt?= =?utf-8?B?a0pXcmZDYUUwVStPakI5RzRLWFpNcFNybnZBQ1I0aGV5RU1ydlo5OGh1U2dY?= =?utf-8?B?Vmd1NkhXTzZJbkREQ3lreStlN285VHNyWktwOTEwU0lhelFnQWVaVE5NOGEr?= =?utf-8?B?a0VLbHQ3VEZadmlxTTQ0SnJycVY2dms4Z1A0UjRhOUdWWmVOUFcvQjJ6cWph?= =?utf-8?B?QjhDd1Z6TjdaMUFqNjlrL0NlVmtObkVLclVscmxFVkR0d1BCZXRlYUk4TGt4?= =?utf-8?B?NDZLdzlIMnZlN3RKeEJId0FFb3p6UEZjT3VCSnFPSVVpTzRDTjAxZzlMdmpx?= =?utf-8?B?LzI2NWlUay83R0NwcGtDOVVObEIvN3dUMnNKZVp5Q3pNa0RHdVVpdzc2Ymxh?= =?utf-8?B?QkppaXRuN1BXVnZOcmRaalpvWlFtTTFrWHEvY3ZWd1hzeC83ZHFUcE1ScFpL?= =?utf-8?B?a0VTMG9aVm1DQUxQZ3JrT0ttQ2F3OHBiVHFhVFFKV24vUzVaU3F6b3hDbzlH?= =?utf-8?B?Z2dhSEhvOVRibTlPSWJpZ3VBVUQ4THEzYjlCVFZFY29WVjhUY1JtYlh1Ykpl?= =?utf-8?B?c2VBMmZoa3ZPN1J1ZXJOT2xBWlZPb2ZhbXhwWmpoL0lEenNydlFuYXpOd1Mx?= =?utf-8?B?M2grK2h0SHRLeVFZOG5JVFFFTklodXp0RHNwQThGMnc1SEVEZjkyVGVXeDdh?= =?utf-8?B?aG92L09HdVZicU41UmRvMyt1ZW4ySkFTVlVyS3dNcnAxdE1rdklvSDQ2OEdW?= =?utf-8?B?dFBIMjFWL3BrNnBVQTlLa0tzU1dqU0lReTBkYzlFRDM2SDg0NG9yMEFtY2l1?= =?utf-8?B?R2pBbjBtWW1Oc2VjM2Q5VklubUk3NHE4ZHptd2hSaUhQQjdWNWdPQzBOcEZl?= =?utf-8?B?WVc0bHlwTUZSVlhVbkVGMWF1QllGQjg4bnJhZ0ZmWi8rYUlnWmZBTWVudFpz?= =?utf-8?B?NXZtOGNoYldacGh0RmpFaDJuaVpDVitOTDlIVSs0T0tjRjlIMWcyR2F6UnlD?= =?utf-8?B?ZDd5bkdmUkUyVzV3Um1EYkJzYXMyVEVPc1d0dnVaYkhlcUpVQ3paQmVGNjNU?= =?utf-8?B?WXhrZ1JvRzU5anZOSFVXcWd3ZmxtQnF0VnFKTjVEUHRKU3VKU0pJLzJBU3g4?= =?utf-8?B?YUhoQkRTVk1tZUU5RjBrUWhTaHp2L25wblJLTGdLKzlkeS9UdHhJK0NCNXpx?= =?utf-8?B?dmFDVmFDSWJPdmVwZXo3TGdNY3RsclE0Q2h6eW9FN3J1YWw0eE0rWEwwYUMw?= =?utf-8?Q?IrXl3850+5Ziq5SIkOAFNSZiU?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bf5e5982-4c31-4f43-a921-08db4beeb9a9 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 15:54:49.3439 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BQ8Rjd067xQUqIeJOCXp0IjbyVVxKWUziIJ+yLKPTgRMxvnbayLxXRBLL6VFSFSDgWFkNaPqqtsc4Vf/Ekqi2Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9658 In preparation of the introduction of new vCPU operations allowing to register the respective areas (one of the two is x86-specific) by guest-physical address, add the necessary domain cleanup hooks. Signed-off-by: Jan Beulich Reviewed-by: Julien Grall --- RFC: Zapping the areas in pv_shim_shutdown() may not be strictly necessary: Aiui unmap_vcpu_info() is called only because the vCPU info area cannot be re-registered. Beyond that I guess the assumption is that the areas would only be re-registered as they were before. If that's not the case I wonder whether the guest handles for both areas shouldn't also be zapped. --- v2: Add assertion in unmap_guest_area(). --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -1019,7 +1019,10 @@ int arch_domain_soft_reset(struct domain } for_each_vcpu ( d, v ) + { set_xen_guest_handle(v->arch.time_info_guest, NULL); + unmap_guest_area(v, &v->arch.time_guest_area); + } exit_put_gfn: put_gfn(d, gfn_x(gfn)); @@ -2356,6 +2359,8 @@ int domain_relinquish_resources(struct d if ( ret ) return ret; + unmap_guest_area(v, &v->arch.time_guest_area); + vpmu_destroy(v); } --- a/xen/arch/x86/include/asm/domain.h +++ b/xen/arch/x86/include/asm/domain.h @@ -669,6 +669,7 @@ struct arch_vcpu /* A secondary copy of the vcpu time info. */ XEN_GUEST_HANDLE(vcpu_time_info_t) time_info_guest; + struct guest_area time_guest_area; struct arch_vm_event *vm_event; --- a/xen/arch/x86/pv/shim.c +++ b/xen/arch/x86/pv/shim.c @@ -382,8 +382,10 @@ int pv_shim_shutdown(uint8_t reason) for_each_vcpu ( d, v ) { - /* Unmap guest vcpu_info pages. */ + /* Unmap guest vcpu_info page and runstate/time areas. */ unmap_vcpu_info(v); + unmap_guest_area(v, &v->runstate_guest_area); + unmap_guest_area(v, &v->arch.time_guest_area); /* Reset the periodic timer to the default value. */ vcpu_set_periodic_timer(v, MILLISECS(10)); --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -963,7 +963,10 @@ int domain_kill(struct domain *d) if ( cpupool_move_domain(d, cpupool0) ) return -ERESTART; for_each_vcpu ( d, v ) + { unmap_vcpu_info(v); + unmap_guest_area(v, &v->runstate_guest_area); + } d->is_dying = DOMDYING_dead; /* Mem event cleanup has to go here because the rings * have to be put before we call put_domain. */ @@ -1417,6 +1420,7 @@ int domain_soft_reset(struct domain *d, { set_xen_guest_handle(runstate_guest(v), NULL); unmap_vcpu_info(v); + unmap_guest_area(v, &v->runstate_guest_area); } rc = arch_domain_soft_reset(d); @@ -1568,6 +1572,19 @@ void unmap_vcpu_info(struct vcpu *v) put_page_and_type(mfn_to_page(mfn)); } +/* + * This is only intended to be used for domain cleanup (or more generally only + * with at least the respective vCPU, if it's not the current one, reliably + * paused). + */ +void unmap_guest_area(struct vcpu *v, struct guest_area *area) +{ + struct domain *d = v->domain; + + if ( v != current ) + ASSERT(atomic_read(&v->pause_count) | atomic_read(&d->pause_count)); +} + int default_initialise_vcpu(struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg) { struct vcpu_guest_context *ctxt; --- a/xen/include/xen/domain.h +++ b/xen/include/xen/domain.h @@ -5,6 +5,12 @@ #include #include + +struct guest_area { + struct page_info *pg; + void *map; +}; + #include #include @@ -76,6 +82,11 @@ void arch_vcpu_destroy(struct vcpu *v); int map_vcpu_info(struct vcpu *v, unsigned long gfn, unsigned int offset); void unmap_vcpu_info(struct vcpu *v); +int map_guest_area(struct vcpu *v, paddr_t gaddr, unsigned int size, + struct guest_area *area, + void (*populate)(void *dst, struct vcpu *v)); +void unmap_guest_area(struct vcpu *v, struct guest_area *area); + int arch_domain_create(struct domain *d, struct xen_domctl_createdomain *config, unsigned int flags); --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -202,6 +202,7 @@ struct vcpu XEN_GUEST_HANDLE(vcpu_runstate_info_compat_t) compat; } runstate_guest; /* guest address */ #endif + struct guest_area runstate_guest_area; unsigned int new_state; /* Has the FPU been initialised? */ From xen-devel-bounces@lists.xenproject.org Wed May 03 15:55:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 15:55:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529326.823627 (Exim 4.92) (envelope-from ) id 1puEp9-0002cn-GK; Wed, 03 May 2023 15:55:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529326.823627; Wed, 03 May 2023 15:55:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puEp9-0002cg-Cl; Wed, 03 May 2023 15:55:23 +0000 Received: by outflank-mailman (input) for mailman id 529326; Wed, 03 May 2023 15:55:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puEp7-0002MD-Cz for xen-devel@lists.xenproject.org; Wed, 03 May 2023 15:55:21 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2081.outbound.protection.outlook.com [40.107.13.81]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e783c349-e9ca-11ed-8611-37d641c3527e; Wed, 03 May 2023 17:55:19 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DU0PR04MB9658.eurprd04.prod.outlook.com (2603:10a6:10:31f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Wed, 3 May 2023 15:55:13 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 15:55:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e783c349-e9ca-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BEn3SZamiUh+LaSGxz7RnHnIzh7e18dlWlHCy6dICRCUkgBM67J5anVsw931BjnKX8w6H//1huTXHaVGCrETzaU8iCB8BnGBYf5CKCHOJJtHOlSvq6fSMBCVPQ1dPLsBggoDbDnebGqreSCtdlEGCkYSFCN1daVdyQiILjqWCnmfys425MrGCfxubl+Rvq402iZ1BgOAfU+TPF0yAZszO+E+ARa0EnFd3el7zYAjuRoXGvAwbzVIfczwjA7BIqnp5RqH6VgfyREUulfmvevLsMGgJZz6MVyFZFE8e0Xgcri5jcdFDH8aZZpXyVdeaqX9SiFXWl5ZUA2SPvYAXJOupA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j6yjHr0PfftdPO6Ee88aaSu+J8Pv7p1vKjlZEcGgTTw=; b=Dm7r90AHXe+maGSyqlOiRafIFF2DFnW0tjdci60DDSWPXn1M/7k+oxTXOv8Q9x8NgbZFAv3BSStJ7LNwzU4QqrPE3Qy7kPe0otAn27OIOaYaouyMKz97IfSpI1fPs9giMnwyDOhzr52YCKS7V01tVEmjxNHJLg+Qyz/F0TmxKsEGQNQOeC0Sc83RpTHWFPDVp74egokb6Hudpzv0C2DjJ3q9SlTVLAc1orgA7MDgtU98NixXr3Ua4JCuTCjpWBjHXvPIVRP9E9VCSGQNf/RnpoLksRInNSBDW/nwtx6QTklvj+F0/h3s8LTSb0cUuC9fT53v0tJyvnzRJTDANe0BcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j6yjHr0PfftdPO6Ee88aaSu+J8Pv7p1vKjlZEcGgTTw=; b=D1GYqkZTkOLEKzzmIi9q5uEAvCEJvrZ4Ee7Vz9DOw+kX+RMHfUlVqsRkRtyletxBp5UEcr4QNT10qq74FJ/C4t7cM+PEKMCB0S548RE7Dc1eRF+bb7Cx3QQkIihY0kiWME6gpwOGqgJB1iIxNnFN6ppbYEWjf3KG9+N3egQvkfPNCMXa3jTcfxw8MPOzVPQrnkR5OztHV9rPcv0hBcB1HbFugURuKzEMUECBX1P/CtMt4ocFKKd/Y/crFfAJ6UPUgnZjQFpDwu9byx7mTgxmzt1bQXusauj4LbSfHMBUxJBoVeL0BSY2HwbNVJoEK07JXCBFB5PQbabyqFKN+SW9bw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <65893a9e-e2ae-6853-7c4d-54f2bf19b17b@suse.com> Date: Wed, 3 May 2023 17:55:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: [PATCH v3 2/8] domain: update GADDR based runstate guest area Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <472f8314-9ad7-523a-32dc-d5c2138c2c8c@suse.com> In-Reply-To: <472f8314-9ad7-523a-32dc-d5c2138c2c8c@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0012.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::22) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|DU0PR04MB9658:EE_ X-MS-Office365-Filtering-Correlation-Id: 595c3862-ac38-43d7-4e5b-08db4beec7fc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tEUd3Jv42yDnr32vQG7G5osjlauYf2E+lSNMeMo3iDIKhunZm7E5ZTcJlYbLwPoQg6rojBIuVrR03F4KMm2Hm54eE3yrDet0U8jPMV/LkOypAxJvfmPFFujWDyZZL/49O8W8+XIEdyhunFKKcP8vvqSFEVk47N2XMJZoSwFZfZwLNnsBYfvblWBYsTOjFDqLg+0P8pSekEOYoRUp3dbIPiM3e9kobI2IPkIvA+m23wDVYO7rvGxnufNgjJjI8+3+RsbM6SsBUu4RmHmKVgF+r31hfeuFphD4GfSRvZDmflSk3SXJ281ELse1YcsFXXWGLgM4lKxupQzrh/rdbG51eTPHELC64ycV5145CkHpTn7eP3uX0JfuLbaRrY2+ORI0xWc3mBnqkhZh85Mtk7qAoeX+1JPGqnFTVdcJDTFGoDx2RfVpZZH042Ciq9FQoK673hrwx+1Pun8L88P4LLroQuNPj/gMA1bkp9WLUD2MBxyXSrVWrY/lTIYBjV6snkLeN/BOZAmBKM25qpvplSF2+9zE3LfbMDSaW87DBjTLs6yShAR35soTP5Ta1BzaDZgFBsHE6kITp0dJj+uLBD5Ttk0EQ97LJk2/0O3hDUEsZljBYS2/Gh83/5IYjsBDtPaQkl4No9twnHINvF5z4AxyCQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(39860400002)(346002)(136003)(376002)(451199021)(31686004)(66946007)(6916009)(66476007)(6486002)(316002)(66556008)(41300700001)(54906003)(4326008)(86362001)(31696002)(36756003)(5660300002)(83380400001)(26005)(6512007)(6506007)(2616005)(15650500001)(8676002)(2906002)(38100700002)(186003)(8936002)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q0dtWkJ3UnBhaDRleEdFeFlxVGlabFR6NVlTcTBMdGx4TndqK0lTOFpaUVp0?= =?utf-8?B?QVlVakdVYlArcnRkanNhenZVUTBlYnFCT1krZHpIS2dVdGhrV2JBRmcrTFF0?= =?utf-8?B?S1V4aUNuOC9qa1lCb3dWTDIvZ3hQaVlkSkN4RHhEaVB5TGpTc2tHVnlzNEcw?= =?utf-8?B?bnM2dG90dWdkVHhlcitVOUlqT3dzeVgxSWpUU21yekQ4bjZkSHdpd3RBeUl6?= =?utf-8?B?R0NkRHRaMTNTNWVrSUd4QUxsTndLakg5akZ0aUpzM2xSUk9oRU9TUDJPZ3Q5?= =?utf-8?B?K2RjMEJzUVlhdUZQVlQ2ZEU0UnFpdldpYmxvQWpnYWtSYWsyMzZBclk3NVA2?= =?utf-8?B?dG1VejdMdXE4MFgxd1VIUmEzci9VSjJTQU9FSC9qTXdZcUQ5QkNnUGdia1Yw?= =?utf-8?B?THkrczVpVFNFeUU1eEZ5Y3duSzQwK1FpdWI1cEZxQ21ET2dzS3ZQa1Q0blhF?= =?utf-8?B?ZWhtUlQzRHI2Y1ZjRlhGRkhpMGZteDVSdVI2N1h1SEN0K2FHYm9kZ1dXSlVZ?= =?utf-8?B?Ykt1NkxVOTAxSTJIM0hoMDdiamxNMU1HeWx6S1lMbUx0ZjZka3Y2UG1HcnpN?= =?utf-8?B?VzdzQXJZeHJYRGxtSEo1WUpBU2xrenJUeVIxNXMxaTJqMC9idXh0SWQrbXBi?= =?utf-8?B?LzFKSEduTEpFTWp0TUZrcUs2a2c5MWxMQ2lnQmNMVUw4L2taelhGMzhOdDRw?= =?utf-8?B?SzZVNU90Sm5HZFJjWjBGNHRsNXJCa1YrYmg2OU1xSTZWU09NWTFzZFhJUS9o?= =?utf-8?B?K2FRaXY0bnMzWEFHVXNRVUVxYUxHYUhOM0VlYXJWdFNubVBmOWtucEp4ZlA2?= =?utf-8?B?VlVtaEpuNVVzN1RzVGcxZmZTUkd1dC92WTZUbDN6T2ErN2F1UnpjZjNjc3lG?= =?utf-8?B?YTdiMlZ0dHp0TWxZc2ZPd2h0MGdwMzh2Sk5WOEVNR3RyVDlTUndrYVZGYzMz?= =?utf-8?B?UkNObFZPVWlDRzdNVkc3WVpGTVpXL29XcU80ZmJGMFE4Ui9uQlVaN3JVcmdo?= =?utf-8?B?ajgvTkpobjNQUWVNcDVMcWRTOVQ2dmY2N2lTQUR6bGV2RkFZYlZJY0llTTBS?= =?utf-8?B?bFBPR1JVUWFtZjhhd0o4WVc0NU5rUWJYU2daRkJmVTE5TDNMNTA1Q0IzTDBU?= =?utf-8?B?Ymc0OWFaSkhTV2lLUkgvNndEcWtSNXE0QTduUHhsb0ZQRGM3TG9EWDBhd2Mw?= =?utf-8?B?TlhDQzBLRXNCdXYva2wxT2kxakkzOE1Qc0Uvb2hLWlBxaGZpZ0NITjRINDdy?= =?utf-8?B?c2R6blBXOTFySjRLWXdGZDlCNzNiVU4yRzVLbDIrTDBhMjdNNEpuRGYzNmE2?= =?utf-8?B?T1lxYlUvVFZvR3l0SmhQd0FDRjVFLzgwTXdxM3cxSjRqYXRMVU1nWmV0SWQr?= =?utf-8?B?cDFueEwrL1NRdGhhUkdGZ1cxb3c1VjhlMGRLSDFOT2pIdEtIeWdwZngrcXhz?= =?utf-8?B?T0todFlIVC9lUllncWUwbFZtMEhJMk5wdVMyRHE4dEFQUjI0OGxQVW0xaUs3?= =?utf-8?B?c2phOVdaWjRlVHY4Uk91a0xiNjBKMFR6c2thT2Z6YzZqTkdKRDdyQWkzS0s5?= =?utf-8?B?NHFncXllT3RaOTB0UXBnVmFHN2V2K0podFVYeEl6cFFKSkxEbThkd1ByN1N2?= =?utf-8?B?dU5Ta0NCZnRJTVljM2ZVSDB0bDVlMFYxZHJ5aUMxS3V3OEh5SlNLWkM1ZHpX?= =?utf-8?B?NkNubEhySk9ZbDg1SVpWV2xGSEdBSXJxWi9zSlV5L0dJMXpJRGdsNkhkak1U?= =?utf-8?B?ektaLzJDWWpqWjhMenFsMlUxaDBFODlnUEk0WG9VV2ZSZ3cwdE13MnJYNk5w?= =?utf-8?B?QThxRnZVMHhRekhkY0tKcER4SW1GUDkzRENHcVVoNzZzcWY4VENBWWZWZnAx?= =?utf-8?B?K1hyZWl4MlRUT055cjJMS1VlZW1ibEQ2Z2I2Y25PZFhkME5yRE1sWWxlNC9W?= =?utf-8?B?RHUwMmw2YnBkK2p6MVJtbWZLL2VsQlpJNFdsR3FyZmVrSGs3N1NIL1pEUHVz?= =?utf-8?B?eFBzT0F3VzAvblVrQ0VjcjhydGlRaXRzMW1WV2tXNHBQZTZkWHJPVkJEVVox?= =?utf-8?B?aEUrUWZlUjNHaTdkUU9YR1FqN0VJWDJ0QmczWHZqaHdsbklBcjRRQ1JDeFps?= =?utf-8?Q?Y8F2vNbsBwPE3QPpkzYckBWo3?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 595c3862-ac38-43d7-4e5b-08db4beec7fc X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 15:55:13.3717 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XqEp816xcAml/2VFrs3XPNY+k5XyBRnNeAN8RSnOPqHEHmWcbOuoQRbm2ZtlHRJWzMgL/6gPcyul4t3ZhVhkgQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9658 Before adding a new vCPU operation to register the runstate area by guest-physical address, add code to actually keep such areas up-to-date. Note that updating of the area will be done exclusively following the model enabled by VMASST_TYPE_runstate_update_flag for virtual-address based registered areas. Note further that pages aren't marked dirty when written to (matching the handling of space mapped by map_vcpu_info()), on the basis that the registrations are lost anyway across migration (or would need re- populating at the target for transparent migration). Plus the contents of the areas in question have to be deemed volatile in the first place (so saving a "most recent" value is pretty meaningless even for e.g. snapshotting). Signed-off-by: Jan Beulich --- RFC: HVM guests (on x86) can change bitness and hence layout (and size! and alignment) of the runstate area. I don't think it is an option to require 32-bit code to pass a range such that even the 64-bit layout wouldn't cross a page boundary (and be suitably aligned). I also don't see any other good solution, so for now a crude approach with an extra boolean is used (using has_32bit_shinfo() isn't race free and could hence lead to overrunning the mapped space). --- v3: Use assignment instead of memcpy(). v2: Drop VM-assist conditionals. --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -1615,15 +1615,52 @@ bool update_runstate_area(struct vcpu *v bool rc; struct guest_memory_policy policy = { }; void __user *guest_handle = NULL; - struct vcpu_runstate_info runstate; + struct vcpu_runstate_info runstate = v->runstate; + struct vcpu_runstate_info *map = v->runstate_guest_area.map; + + if ( map ) + { + uint64_t *pset; +#ifdef CONFIG_COMPAT + struct compat_vcpu_runstate_info *cmap = NULL; + + if ( v->runstate_guest_area_compat ) + cmap = (void *)map; +#endif + + /* + * NB: No VM_ASSIST(v->domain, runstate_update_flag) check here. + * Always using that updating model. + */ +#ifdef CONFIG_COMPAT + if ( cmap ) + pset = &cmap->state_entry_time; + else +#endif + pset = &map->state_entry_time; + runstate.state_entry_time |= XEN_RUNSTATE_UPDATE; + write_atomic(pset, runstate.state_entry_time); + smp_wmb(); + +#ifdef CONFIG_COMPAT + if ( cmap ) + XLAT_vcpu_runstate_info(cmap, &runstate); + else +#endif + *map = runstate; + + smp_wmb(); + runstate.state_entry_time &= ~XEN_RUNSTATE_UPDATE; + write_atomic(pset, runstate.state_entry_time); + + return true; + } if ( guest_handle_is_null(runstate_guest(v)) ) return true; update_guest_memory_policy(v, &policy); - memcpy(&runstate, &v->runstate, sizeof(runstate)); - if ( VM_ASSIST(v->domain, runstate_update_flag) ) { #ifdef CONFIG_COMPAT --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -231,6 +231,8 @@ struct vcpu #ifdef CONFIG_COMPAT /* A hypercall is using the compat ABI? */ bool hcall_compat; + /* Physical runstate area registered via compat ABI? */ + bool runstate_guest_area_compat; #endif #ifdef CONFIG_IOREQ_SERVER From xen-devel-bounces@lists.xenproject.org Wed May 03 15:55:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 15:55:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529331.823637 (Exim 4.92) (envelope-from ) id 1puEph-0003Qa-Ss; Wed, 03 May 2023 15:55:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529331.823637; Wed, 03 May 2023 15:55:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puEph-0003QT-Pf; Wed, 03 May 2023 15:55:57 +0000 Received: by outflank-mailman (input) for mailman id 529331; Wed, 03 May 2023 15:55:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puEpg-0002MD-KG for xen-devel@lists.xenproject.org; Wed, 03 May 2023 15:55:56 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20624.outbound.protection.outlook.com [2a01:111:f400:7e1b::624]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fc9c191c-e9ca-11ed-8611-37d641c3527e; Wed, 03 May 2023 17:55:55 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DU0PR04MB9658.eurprd04.prod.outlook.com (2603:10a6:10:31f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Wed, 3 May 2023 15:55:53 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 15:55:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fc9c191c-e9ca-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=inLmMtkj/mKxcjN81kgyPe/lnB/4VWpaGW50iS+vg88WDPZBlDV/ycy8N1GP97TGe3ZG82g/HYehDp5IbofzsKhgZcaFKPJH1/n9qnk8U8KGD+/1HJUJrowrjvPG30kgbRDi38rjV6HibvL6mFw3TciDbvmayb/aTpjF1lYhh646qt1ahcGVtS5X7FrwoZphGYAgkXGhagwQSKP8fKA8sl50nV7sR70u/j6EwifIqq41eOoesaWd74SO5YXDWBo3Rg59q65dxqU8JSh4M71os02P/97Ic0hkMV45tVEEfaSoV927OXyyiC/EVqemn+j4YLRY4uWusLw91S9DGcwRmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tj6boY6MQ0Ajhx1lKmKqTBrZzfbIB+gH7SjBjs88Cgs=; b=WOmbBwvy6yvVcm4/sRFEytdm/A7nloW60M0F43SDphMcYYxgBT214ndozt8RGtpoqQPD7QCOfHTQJrGGhN03C8JJUFULnK06hHKMgevfMb/frnlf0q5aY4k4smaRnz3ca8Ls9FY9c1q0PgHH2GiPsPGlfT5V7b2HB5GzzH/7BqVrtG1RECjwcr97KSpdfYd/qW5tYwSQkt8VWo/hai6mnjPS/GcPtaguMBkgP7GWkjUGpSTVh9V0NPLYD0FLO5DScuHC0B4rLxTUPkMVjjV7kfVD4LO+9cKtptauRDGkYiuvYDNxaY3SdOlS0CkVoUJujN+2VNpgTRaSJGdoio6PKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tj6boY6MQ0Ajhx1lKmKqTBrZzfbIB+gH7SjBjs88Cgs=; b=JnxDbA7c26oKLPC7EQWSU+WaPlfFEV14MIM8YKhRqQ2+CIl5hq475tY5yDlLbk+JPalAJjCIzNb9kGagNIeR9wYb/csi4rTf3pf+QK5szHVs0KNT+9fNS2R7WSSYqPoAw0Grk1RZImFrEfSlm4G6cBC5qk3vYueP/wn460uNnuG4bTLUIne8hemx+j5hCdxcQ1LN+Kk6P5spq+irvLmd8KMoSeS9hYY6E8g+so6tp/b5qrwXUxX9g7lfNmLTE5/RmdwGI04aLI6YIVh7afGnQ4z8V7IkUCt9wHU9Tk/CYNB7BNGv48g2oDvtoBb32eigVzxpHH9S7mqo9P3astgCOg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3cbc92ac-7817-e08c-0e7a-bddd0a4ce070@suse.com> Date: Wed, 3 May 2023 17:55:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: [PATCH v3 3/8] x86: update GADDR based secondary time area Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <472f8314-9ad7-523a-32dc-d5c2138c2c8c@suse.com> In-Reply-To: <472f8314-9ad7-523a-32dc-d5c2138c2c8c@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0008.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::18) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|DU0PR04MB9658:EE_ X-MS-Office365-Filtering-Correlation-Id: e382cbbb-bef9-4559-58fc-08db4beedffe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FBHUQEIdZLzsPyjdhKbpxKEMLI8j1EcOqu1V6MCesVhb7bAsTi8sttRZOz84wyxW6HQf+gWYp1HApVMRzhqLRqSa+qh/3A407eB/whFLAvipq2JZoRI3SxZBxG1ToSJM/IL4z9By3aZhLWNxd27deKEqrtLz4F+8YfYMEs0a8OMWQx5Lfkw0XRjjsN0piturilZfpsZW81pDJ//6FHmybvhHpN1lHBFAYCTr7M8OqtPAsxHM3mNHBNBg1c1CYzH2neP/ZSAZZA/ToonoQb6LyWHdGNtBthxKVYGiV+IsSYVMJVaZScVRS+UApr43wNwrhr/OSdEepjGqA7jxJ7Nyft9yqGcZV/hLPq6guwg5/3qTTx9jA8ykFtt5JwP4HPZ8lFa9AZwm0pEY+6Akvk7uc8hBGdqOHluOV9XTKqBridrUGuz4pFfTIUQc2YnbqgjqDPVij60ViZsdOvWFZ38vMPQZZr/D5kH2S543rpnWA+Fd5NEvfTPDhWT+iAX8yyyqxXT8LlMsZsS5v43dytaAgi9hZVas9hRKWEo0+3MeEwLMu6KRC92d6V3xZkjoU2SBwnNueMi0OjT5Iyz8gRl1LyPMJWChiqrxIyH1VsCoDFbIPzuWh34eL9fJ984/yjfSBl8AI39gr3EdrNxM155VPw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(39860400002)(346002)(136003)(376002)(451199021)(31686004)(66946007)(6916009)(66476007)(6486002)(316002)(66556008)(41300700001)(54906003)(4326008)(86362001)(31696002)(36756003)(5660300002)(83380400001)(26005)(6512007)(6506007)(2616005)(15650500001)(8676002)(2906002)(38100700002)(186003)(8936002)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?LzJSRUN2ME00K21CeGtLMkx3WlpsYTF1NDVZdnJUQ3lPUjJZS1A2N1RNZk9X?= =?utf-8?B?V2JyUiswamR6cll2Kzh2T0gxbEFBZFVFOWNZNERvNzl2cTJZeEkwcUppOG9Z?= =?utf-8?B?Y24rakNzTzNEdlh0R1VodUZCdktXWmdRWllYVEF4YUQvN0JEV1FaNkRZVENx?= =?utf-8?B?ckNHOXRiVWNuRk5tMFU1YVJ5cXRyNVYzOTBKR0tsVmF2OUkrUTR4ZkVGZ2Vm?= =?utf-8?B?Q3dKaWRTUTRiT0NSR2NDbXpjb05WQkkrNVh5Vm5CVndKZHJmUzYrM1d2UDhz?= =?utf-8?B?U1RhYjc3SlNHdEhrTHNmZGdVR1ZrMDhRcjBObUlKRy9HZUdXUUV4S0FoYW5p?= =?utf-8?B?VjFVYjgzQzd3RnRWSFJJWERrNytFSGFhcHRMbEhWNG1Jc2QwZW1LWGVzOWhO?= =?utf-8?B?UXBQZmRCS08zaktNeWlFVWFwSDdhZUhObGw5T1Z3OWRMek5KcHZnNXlWL2Jp?= =?utf-8?B?dFYzdlBrdGhIU0VPYTBXTUJ4VkNpUHhCbDdpZ1ZyZWJSV3pWRzNkRUcxbFpm?= =?utf-8?B?Q0tXQjFFZDVPWUNDazRGNkpOYlBqSDlMU2IvVVhOdGZyRTIzNHJmcC83eG53?= =?utf-8?B?dXFaRFFYQ0o3UzFSMFVQQktJM1dubmdmWDAwM1NKci8rTVFPU1pzc0I1SWhC?= =?utf-8?B?QTg1d0MwKzI2bUFmejhHdi95bWtHbEVidlMvT2hnTzB3TVovV1VZNXNPMmxS?= =?utf-8?B?cU9tWDdZVTl0eWkrVElxMldSYWdTS2pBZXI4ZFo4NTVmaXhhdjd3RVgxWGxI?= =?utf-8?B?VXZ3Vy9QeFRkZ1p1ZFpYTnhzT3hJZVFxYU1RSEY0eXJEdzhLUElJaG9tSzUr?= =?utf-8?B?WVFmRHk2Vnc4ejVXQ3U2K2dYT245a25PSmhqWDRZV3B4WjZHbmppQUwxbEFY?= =?utf-8?B?MXI3aHVhU1BmS3ZYakI3NDNDZE1pYWozMkdqODRGemM5dDRNbXJ3OXE0QUND?= =?utf-8?B?blVFWXZpSVBSRG1lNXl3UGR1YlJYZ2hYYmZIQUxtSFdrMzFydllsK2J6dlpN?= =?utf-8?B?bTJHVUdmeE52OUJnaGtkOUEzOTQ0ZjE5ZGREYnZ2TEYwWkNXOHVkQS9wUDlH?= =?utf-8?B?cWhDMmk5Ni9oL2IvY2JoNGdWMFBiTE9MUlRzLzV0UnE0aTRHYnhCTlFqRUdH?= =?utf-8?B?YXYydjFJUUJvbW00RHZpVzNyRUU3YjZBbkQvdHZTcUtGZEtEL0NHUkt6dVFs?= =?utf-8?B?TW40Rk5LNGZSN0F3S2hHaFNLaXBYS0xybVRRY09zTHJXekl0UWJXVEQ2YjFG?= =?utf-8?B?QUc3UUsvZjdVdXZQcDVoY0J0bFdLN2lwYkJwRWZCa2xZQ1hwcGlMSnZidzVS?= =?utf-8?B?bzkyVUIxNGRhbWg0OXBWOUc1MzRWMmZZaWVqL3NUNnQxVFFoNHA4U2NkR3hm?= =?utf-8?B?dHlJRjNxV1VKTGk3WU90TXlDS0JZZml4NDV4RWZtRDBnV1FIUjlXd3h0em4y?= =?utf-8?B?OXlBUXZHb0lTVWsyNmdGamRQVEwyVno4b3NNemE0V0o2VUhDaEhyWW4wN2g4?= =?utf-8?B?VWFJZU5ZTXh4M3ZCM2FnZEhHOG5MNmp6RTQrekY3WFh6cWxPV0c2TXJLbUlS?= =?utf-8?B?MysraFZQRUJjRnZxNHJ0WGgvaEVLWm5zYXJLa0xtdk9GY1dwbUhYV3h2NnQ4?= =?utf-8?B?a2dtZTl5ajhIZVVCajdIV0N6T2kyZXU1YlhPKzJvZU1RVS9ncFlNVWMxamhF?= =?utf-8?B?VHozb2h0QnA5cVhLZndmTHlyYXdMSEdxZmFUWnJLUkxQOFFOeWMrZ2RNUncw?= =?utf-8?B?WEYrK082SGZQdWJlMWpyYmxYQWw1QVc3ZU5BY0dqWnV4TWhGc0lQM0drUmpp?= =?utf-8?B?bVJnQ3JzcWdWSWZ3WmRoNkdhZk9ha29uM3JzZ0tQN1ZhRjJTbnROWllkSWtG?= =?utf-8?B?RUdvS3IwcmpUN3RIV3V1bW9NZ3Z0Y3A1dzJkZkErcTg5VVNLWVI1OFdkV2d1?= =?utf-8?B?MUs4M0RrMjhXdEJINnRFZTRRNlJ2OTZlL1NuVVM4MFB0N2dUK21UQkhrNXlz?= =?utf-8?B?LzIyOTVMTExNeHVwUTNsblB3ZVhzeXR4WFlXWXlvWExSS0Y5MFFIWHBPakVn?= =?utf-8?B?MDdzbVZMeTRUMi9zY2lUY3hzZDBaSTI5TW5reHY3OTlZYWRlUG81aVlUdjVV?= =?utf-8?Q?E8/OKwJ3Do1uKbFCotEbWo8VG?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e382cbbb-bef9-4559-58fc-08db4beedffe X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 15:55:53.6708 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QSQc75YlcKMNRqWx8MZ1zJ9JS8jp1LH/vunCpmGTJMgDcmie6m0JU3L509gt7IByUozI12ZKrmFwlWS1ZQmqpA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9658 Before adding a new vCPU operation to register the secondary time area by guest-physical address, add code to actually keep such areas up-to- date. Note that pages aren't marked dirty when written to (matching the handling of space mapped by map_vcpu_info()), on the basis that the registrations are lost anyway across migration (or would need re- populating at the target for transparent migration). Plus the contents of the areas in question have to be deemed volatile in the first place (so saving a "most recent" value is pretty meaningless even for e.g. snapshotting). Signed-off-by: Jan Beulich --- a/xen/arch/x86/time.c +++ b/xen/arch/x86/time.c @@ -1571,12 +1571,34 @@ static void __update_vcpu_system_time(st v->arch.pv.pending_system_time = _u; } +static void write_time_guest_area(struct vcpu_time_info *map, + const struct vcpu_time_info *src) +{ + /* 1. Update userspace version. */ + write_atomic(&map->version, src->version); + smp_wmb(); + + /* 2. Update all other userspace fields. */ + *map = *src; + + /* 3. Update userspace version again. */ + smp_wmb(); + write_atomic(&map->version, version_update_end(src->version)); +} + bool update_secondary_system_time(struct vcpu *v, struct vcpu_time_info *u) { XEN_GUEST_HANDLE(vcpu_time_info_t) user_u = v->arch.time_info_guest; + struct vcpu_time_info *map = v->arch.time_guest_area.map; struct guest_memory_policy policy = { .nested_guest_mode = false }; + if ( map ) + { + write_time_guest_area(map, u); + return true; + } + if ( guest_handle_is_null(user_u) ) return true; From xen-devel-bounces@lists.xenproject.org Wed May 03 15:56:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 15:56:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529335.823647 (Exim 4.92) (envelope-from ) id 1puEqa-000437-5V; Wed, 03 May 2023 15:56:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529335.823647; Wed, 03 May 2023 15:56:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puEqa-000430-2k; Wed, 03 May 2023 15:56:52 +0000 Received: by outflank-mailman (input) for mailman id 529335; Wed, 03 May 2023 15:56:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puEqY-00042q-Nk for xen-devel@lists.xenproject.org; Wed, 03 May 2023 15:56:50 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2052.outbound.protection.outlook.com [40.107.7.52]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1d1b9cdb-e9cb-11ed-b225-6b7b168915f2; Wed, 03 May 2023 17:56:49 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AM9PR04MB8290.eurprd04.prod.outlook.com (2603:10a6:20b:3e3::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.21; Wed, 3 May 2023 15:56:48 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 15:56:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d1b9cdb-e9cb-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CgjoTUN6CbxKasVTNMIxaD8XwmSLIRV+DyqK6OYqLjQbNQHofyE4bQ5PqpvLrDrmPcPX6VrLYQwxIUnED8nZJxZ9Z7fIbdmu9HIAe18oVsv2laqUU3gMrcdeusKrWJmebtzqIF4tJ4PktucSPMOMCUitQHHQfIp3neMghZmIkPuVSCza29qEu52s52WUBqsNP0uGy0na+lk2GyNyrckDpEvYaYAiLCvbRABagoCa1O2zZXDBmUAsPtQG3j//Z4DslV0k3x5eui+9KwrMofN4raU5LM4Jvl7Upwy+XeGVPgYNyARikWEMxc/uiXHRB5PohhEeSc7ngDQg/Qpw8rr+Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W+yAFYV7AlsDjWOjH7N7vMb8CphBeaTJd50l2bpX5dg=; b=Z+yC1slpCuamfXNjHaPWV1NAMO6BU1z3EQja1Fs9ngsGSUxe4pelq1WuMqKJQJBtj8vYkpWV3tBMvzYKjS/82Jz+4eudTx8jgXAT7WEKB8BcPPXFoM94d4LG3NkDxwlgj9ip3igFL9t8naOpAMxAhyRP9yNoTFpeTeuTtHM5vvWSPgktKQOuf14qjsH/nwR414u9oBT9+xpsTCy8nkV+VH1Jo6lJlkE3z+pRHmGyGLHD3TUWMysvKycxckf4zcm6acG9pLESb77B/lxtTnqfqVLEUFMZhS8fVK3cxYymhdxzf/5w0GTMUPKasOJ/sCihsHBJHd7gkhuT1udU3LnPYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W+yAFYV7AlsDjWOjH7N7vMb8CphBeaTJd50l2bpX5dg=; b=vrgIQX9XaVWdZVcA4/SlZpstpXpAJmmoQL76lByw/wEQJs07/XjrzPos0G0YyOm0ilx7uFhERhhM2T35+56bNxisQdnW1Qf92hlw1BY47GpjnEFAsvNVwlCphNuwFEOfxaXAmg7cRojrvToJ4Ysd8v37YENn5Burjyp3O2YTAxNTBNDvt7GTVrW3Ndf/5How766lcpzswxfYWw9CBsy/eDDxiAdiELX5kUl0ILQGoFCSTsmfW4rbmC9H3i64CyduLMdfOYgnkWnFl0lnmJ5DG9X+P8lUjf0n7co3R30vGdvxeWBqB8Dsovy7piESniTxZtNjpTU36Ih6cUGA803JKw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 3 May 2023 17:56:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: [PATCH v3 4/8] x86/mem-sharing: copy GADDR based shared guest areas Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tamas K Lengyel References: <472f8314-9ad7-523a-32dc-d5c2138c2c8c@suse.com> In-Reply-To: <472f8314-9ad7-523a-32dc-d5c2138c2c8c@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0067.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::7) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|AM9PR04MB8290:EE_ X-MS-Office365-Filtering-Correlation-Id: b1bb34b2-2845-498c-2856-08db4bef00a7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 281ssijAfKKP6qCPeODgn5xmJm5AZl5edljNsSZgwqj34uMmnMoIkfFxz4QZlheV+Bm6gEuQmO1LfzTtHCGXY9R56jlawoU1bgb5UdMZ/4VGZdDCu3qZxY63Eyq56uANVn6uTMmCWyQ/++fLoqAPaeMmT5nXH8HmizOynZgdp9avkfJOV2lSWzVEIKxfcDDVCEOMzhHV3Ptk5h5ng2E++VjWcOX+gTQzlhzUynyZZJrYlnCRMHujW/oiIU6LYiICpRrmkerdH1iBlzAkafokwUFBWckQDIVl2EakBPCxNxUtKPJabmS44pVodSZnVWaoHAgdnuJuGMh0s1QN34HmCh4AMdS5mcq8APBAkDFTdCU9GZWOxOZEe/w9IJdA2Rf1qyPjiWBv+1TlDiIsNpqg5SH795pxJzrKhYBGzyDr/GKcHvUrUhvDYgmPBPgwzT6m5dTKejIc3tVgI7+4wxCfBT/R/ayudPrbUixg6uCl1ESVB5hGk3ebDezEy4Dnu+a6/BiZrIYptOEDrRPp53ybqnT3MFwIt4Kh1uTVVyKo6e9BODrULxuXzAuLFtxhKnIrHqtr9Z5B4P/LqAwyBIkV4l7XWzuM4/IbmXs1IEfDXgra9vEcRLAZZ2x4Txg7R7c4KRIiMJKpImsdpwmGZDLBTA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(366004)(39860400002)(346002)(396003)(136003)(451199021)(2906002)(38100700002)(8936002)(8676002)(5660300002)(31696002)(36756003)(86362001)(6486002)(478600001)(54906003)(186003)(6512007)(26005)(6506007)(31686004)(2616005)(83380400001)(41300700001)(66556008)(66946007)(66476007)(6916009)(4326008)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V2RsanIwWDdvUVhBd0J4YXRmTk1wTnNOc0g0K25JejNZa0J4ZEFZOUtUN0g4?= =?utf-8?B?eFVHL1ptZDNDZjNkM1lhNE9wb3g5cGwxcjFlUzZ6NTFMQWJTcXRuN0JzZk1h?= =?utf-8?B?V2dkZjlab05laHhGaGU5cC80N0RUWWtPTXNvcElGRURpUWlESDJ1NnRaUm93?= =?utf-8?B?MkdWbkFZZ0N0RUdMK1dwK2JmbWZxUTNYc0V3QmRBekd1L1ovbmdFNjZCRzFE?= =?utf-8?B?d21XZEYzL05DanRBZHhpLzdpWlgxZVMwRlBEa2tyWWkreGVic3pOQURkays4?= =?utf-8?B?V3h0MW5SbElsUk1YeXIwczFqK1l6aFlQUDRaM3NuOEo3Ly9OenF2MHpwQ0cr?= =?utf-8?B?U1BLcFZiQXMxTndGTzZIQmNvSDFZS1Rtd3RkZ3pSSHBFTlVIajF1YndNU29E?= =?utf-8?B?WXBiL0ZBSHRHbG1tZmN3YjVtTzJCanhXK25GWWRyVVdmWThkVDAvV21EQTVB?= =?utf-8?B?ZDFmNGh0L3o4NFdiQTZSMHp1cDlXdXp5V0w3WW84eTlkWHVoQmk5MTRnOFZ3?= =?utf-8?B?MmlqakFQMlo3cjRScTJmWWdhRTRJVnJxZkJDaEdOcE1yZUNYRGlGMllVRGpJ?= =?utf-8?B?dGVVUjIvUXBRM1FRZU5xTk1nNnV5M3gybW1jVmErc2tMWnhKdTBlQXdNZXFo?= =?utf-8?B?d0wyWmlaNGduQ09KcEdJUmNIRXRENmZzTGlrZlUzelhxZGVTOVc3ZEkySTBX?= =?utf-8?B?aGliYk41ZXBROVg1cnBlbTc3WFIyOUR6NW9sMkNhV0lNUEVzVXR3TmNpVmdS?= =?utf-8?B?a3QzTDZYYkt6QmZ4UkMyVyszd2lVRUNFTG00ZXRFL21PRE9Xdzl4MmRUbmM4?= =?utf-8?B?UFE2WWl6eFFUc216K0RUZXpHQmRUYU9YK09CcXNNQU01ZFg0RVhBVXdZSWt3?= =?utf-8?B?U3JHa3dEbHl4S1BFL3VOMitmNXBGWnFKOW8zaTNWbXFrU3hXUmhyUnZOZm1X?= =?utf-8?B?Y25ORGo5TmZlQ255aGNHRkduUGVJTkZVNnpoZVQvajJCeGRLMmxtd2JtdEpp?= =?utf-8?B?SjF1UmZjVWVwM25Xbk8ybk1TRWFOcGxORVRCMlpNTnBIczcxbXh5V2NRR25G?= =?utf-8?B?UFlZOTZucGIwUlpETzkzSmFwc1p3K2xOUTJ1ZmVPV0VsRnZuMTVWbEo3M2hx?= =?utf-8?B?eXBOYTUwejhXTkRsUEU2eW80YUJkVWRuWkluNDZZNDdqTkJidGpaRi85eklL?= =?utf-8?B?c0ZSbzlWdkFwSHc3S3k2azJMekpxWTh0WEttSFZoZDFBVy9ydGFpd205bHYz?= =?utf-8?B?M2lDdW9jTS93cXVaakw5SmQ2d0U3NnFVRW15eXRSc1cvVzNyc0V0MnFqM29y?= =?utf-8?B?bXpzVXNvcW5TZm1XVmdoeXJHczFBTTBYZFAxVlNlOWlqZkczeG1ZWHUvOXdM?= =?utf-8?B?Umpub3JNVFN5VnJDVE5CODYzNUtWdGczK1JPdG5lRy9ZNGhtdEdvWnNxVUNR?= =?utf-8?B?U2hHQjRBbmE5UlRQVGVnUWxhVG16alNQdzVWUi9zT3dPSWk5bCtBdUYwYk1j?= =?utf-8?B?NTJoRkVkQ2lxVkVLcmFPSnZnOVFNaGpqVzdoZlZJM3UvaURjUnFGMnpiTjEv?= =?utf-8?B?ZW5KcjZGQzA1ZHdqc05jODAyZXBKNVJhNmFiS21zM2ZpK1RpYUhob1BEd1pX?= =?utf-8?B?VGtSRkMwUWZJRi9lOFBjSURReWQ0U2gySXlmOTI3VkJDcTViQitaaGJjQ2or?= =?utf-8?B?YnZhSmYxZWZ4d2R2MWg2UjU2NHJQRGI5NlUyVjJiT2dnY0Fya0RSUFVuRDNF?= =?utf-8?B?SmEyVTVhV2RHYUZzZlBNaXlXZFdKbjkwNXB3UmVTYlpkS3FtUlVLM2tvRFhW?= =?utf-8?B?eXBUWUMyK0RIYXRXNWRZNllmbzk3RHhBZUhsYU0zL0FqWVRPOUxMWVVnMU9S?= =?utf-8?B?bUNYU0FnaWJiZ0xiR1hVT1BQdTlYeXp0cm9BWUZ5eTFpUmNaTUhOM0UrYTlr?= =?utf-8?B?bWs4eTBWSHoyVTMwZUhMaXVpcHpDTXBROEs4NlgvaFVrYmh2bUVSbDBBR29H?= =?utf-8?B?aExucXQxMC92b3pBeGNZWXZkcFRIOWl3Y1FxZnhTMFVvNGp6TmxZdnZtMVpV?= =?utf-8?B?NERNNkVlUU83WVY5a2IxTThYM1BPWVV4UGJ6TWJOUjdLWnhseHlYcU1VcUh1?= =?utf-8?Q?uYXiPlATYodlWJnF0llVq2vBM?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1bb34b2-2845-498c-2856-08db4bef00a7 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 15:56:48.4224 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gbQ2fpMW8jWUj8uN6cZSiyEIXjZxhuReTi0qZoTODu897SIIU59hWq+bDj6+BU7IiSU/fZn6ycP+pd1pnaxOCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8290 In preparation of the introduction of new vCPU operations allowing to register the respective areas (one of the two is x86-specific) by guest-physical address, add the necessary fork handling (with the backing function yet to be filled in). Signed-off-by: Jan Beulich --- v3: Extend comment. --- a/xen/arch/x86/mm/mem_sharing.c +++ b/xen/arch/x86/mm/mem_sharing.c @@ -1641,6 +1641,68 @@ static void copy_vcpu_nonreg_state(struc hvm_set_nonreg_state(cd_vcpu, &nrs); } +static int copy_guest_area(struct guest_area *cd_area, + const struct guest_area *d_area, + struct vcpu *cd_vcpu, + const struct domain *d) +{ + mfn_t d_mfn, cd_mfn; + + if ( !d_area->pg ) + return 0; + + d_mfn = page_to_mfn(d_area->pg); + + /* Allocate & map a page for the area if it hasn't been already. */ + if ( !cd_area->pg ) + { + gfn_t gfn = mfn_to_gfn(d, d_mfn); + struct p2m_domain *p2m = p2m_get_hostp2m(cd_vcpu->domain); + p2m_type_t p2mt; + p2m_access_t p2ma; + unsigned int offset; + int ret; + + cd_mfn = p2m->get_entry(p2m, gfn, &p2mt, &p2ma, 0, NULL, NULL); + if ( mfn_eq(cd_mfn, INVALID_MFN) ) + { + struct page_info *pg = alloc_domheap_page(cd_vcpu->domain, 0); + + if ( !pg ) + return -ENOMEM; + + cd_mfn = page_to_mfn(pg); + set_gpfn_from_mfn(mfn_x(cd_mfn), gfn_x(gfn)); + + ret = p2m->set_entry(p2m, gfn, cd_mfn, PAGE_ORDER_4K, p2m_ram_rw, + p2m->default_access, -1); + if ( ret ) + return ret; + } + else if ( p2mt != p2m_ram_rw ) + return -EBUSY; + + /* + * Map the into the guest. For simplicity specify the entire range up + * to the end of the page: All the function uses it for is to check + * that the range doesn't cross page boundaries. Having the area mapped + * in the original domain implies that it fits there and therefore will + * also fit in the clone. + */ + offset = PAGE_OFFSET(d_area->map); + ret = map_guest_area(cd_vcpu, gfn_to_gaddr(gfn) + offset, + PAGE_SIZE - offset, cd_area, NULL); + if ( ret ) + return ret; + } + else + cd_mfn = page_to_mfn(cd_area->pg); + + copy_domain_page(cd_mfn, d_mfn); + + return 0; +} + static int copy_vpmu(struct vcpu *d_vcpu, struct vcpu *cd_vcpu) { struct vpmu_struct *d_vpmu = vcpu_vpmu(d_vcpu); @@ -1733,6 +1795,16 @@ static int copy_vcpu_settings(struct dom copy_domain_page(new_vcpu_info_mfn, vcpu_info_mfn); } + /* Same for the (physically registered) runstate and time info areas. */ + ret = copy_guest_area(&cd_vcpu->runstate_guest_area, + &d_vcpu->runstate_guest_area, cd_vcpu, d); + if ( ret ) + return ret; + ret = copy_guest_area(&cd_vcpu->arch.time_guest_area, + &d_vcpu->arch.time_guest_area, cd_vcpu, d); + if ( ret ) + return ret; + ret = copy_vpmu(d_vcpu, cd_vcpu); if ( ret ) return ret; @@ -1974,7 +2046,10 @@ int mem_sharing_fork_reset(struct domain state: if ( reset_state ) + { rc = copy_settings(d, pd); + /* TBD: What to do here with -ERESTART? */ + } domain_unpause(d); --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -1572,6 +1572,13 @@ void unmap_vcpu_info(struct vcpu *v) put_page_and_type(mfn_to_page(mfn)); } +int map_guest_area(struct vcpu *v, paddr_t gaddr, unsigned int size, + struct guest_area *area, + void (*populate)(void *dst, struct vcpu *v)) +{ + return -EOPNOTSUPP; +} + /* * This is only intended to be used for domain cleanup (or more generally only * with at least the respective vCPU, if it's not the current one, reliably From xen-devel-bounces@lists.xenproject.org Wed May 03 15:57:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 15:57:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529336.823657 (Exim 4.92) (envelope-from ) id 1puErN-0004Zm-Gh; Wed, 03 May 2023 15:57:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529336.823657; Wed, 03 May 2023 15:57:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puErN-0004Zf-DU; Wed, 03 May 2023 15:57:41 +0000 Received: by outflank-mailman (input) for mailman id 529336; Wed, 03 May 2023 15:57:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puErM-0004ZO-Hd for xen-devel@lists.xenproject.org; Wed, 03 May 2023 15:57:40 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2051.outbound.protection.outlook.com [40.107.7.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3ad93c58-e9cb-11ed-b225-6b7b168915f2; Wed, 03 May 2023 17:57:39 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AM9PR04MB8290.eurprd04.prod.outlook.com (2603:10a6:20b:3e3::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.21; Wed, 3 May 2023 15:57:11 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 15:57:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ad93c58-e9cb-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ecl6OoeY3v9bYuSfyv4XwM4HHyOiqOqkPixZ2UG8OIn7hDHfwjANc11GAG5XUJP9H9cZDdUiSD/QKUk2Tlzqq4AAkW3O0FrFTnYS+HWBGl07akyZCsr87tGCSAJA1bWxzC8I6cj7fQLzGWsASxQdUGGEiel2hOUJdMqhWelguqaCK+6Ox+UN8fioKTxBFpkQMBXSGUnQ1lhmmINQIsTXy8Bzq7RqYZ3Bb5Zq08j6PfnUGowBT6c7p5Q9y13CLCXCL0w/TTFbyTJsdvPrzjvkfM4+jfV8EW4iPkyyvOhO6pxUUZF8VomcIXUxFTYNU9RqZekujizyJ4q6bB/FNnL5aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NH84g47tK7c4GlHoaAADCkWf+J2O8DieVbFkOg4ugNs=; b=Riy4pq1Vr2jZEw0jWPQCWBvh1Gzq2UkbXR6FB4EvslF8RwR8WdvsmllqgTXGcnbExY8lAYNReBHnxQSGSc/YhTky4W15b38Z4fHcmibXXqf/OT9kQ6WM6jTUBXPcNV9d7mUF9G1WsedKS2xci/lHaXmAe7LwJKW6Dg8QeArwewyWsL5zmYCgBP3Xbrun8jZq0YMnJfydhX6O6O2XZHNOakqvw5yuZtnH+LaGn0X0N/OkKL4RiS1Sg8RdtRZxp4xOZAJA+AgPOVFMnQ7WxD2DYGUVAPpd4FXmrfCJY3+Nft64nkyfn+pLJi5FpsvL3rhzFqaXP6bacWdpqXcYK6RQWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NH84g47tK7c4GlHoaAADCkWf+J2O8DieVbFkOg4ugNs=; b=AN+UqnCuIkVXFXGo75TS2i16XkYOfqjLHsaiJixrQWP6QljTr+mRTbhvMnR1KiEIXj+D/OdvKKLW+xksjr1pRwiDNn4FnupuljH+M4NOqedXj1hMWupWC4bvtYKj7fWME+Yn0/Yuu6PstWH+z6VzHgN96hFax3hm8a94tUnozA/XYK/cd/ya88DuRZ6skyvdypsLasIVZMbycOgePIV5b8tjYUv76S7rPSV+DHzRE+KI49rfNaRff+zUPQ52NbXDrGHDqhmkOcfNYmh8daT4Ua797b3mGpeBapdTL90jjNsLQa2ByAjVsMDTVZxlvJeqRGVLNTXSmXcHlYiJglRexQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <140e906f-07c4-ae40-1d37-ae9966709289@suse.com> Date: Wed, 3 May 2023 17:57:09 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: [PATCH v3 5/8] domain: map/unmap GADDR based shared guest areas Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <472f8314-9ad7-523a-32dc-d5c2138c2c8c@suse.com> In-Reply-To: <472f8314-9ad7-523a-32dc-d5c2138c2c8c@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0040.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::8) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|AM9PR04MB8290:EE_ X-MS-Office365-Filtering-Correlation-Id: 3d4925db-50fc-4a26-627b-08db4bef0e49 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VdbsEsxYOJZLI2yg0DerlCvyJ3okHohulxga3CtEn+dyKuFWyhHj8GeRDd7BhLWOmO0k3U42VG+RbLWWLxeMtVB7sCocOTd4YFe+nePU4KjNvG9dv0Jb67AsRetRN8IVbMaCXSFDxmuN61N+b+nbl8pMVM+ODzGxswu8TyusXsJoPpot1MocdrNuDo0IYAdbGp+NE853JC+SB7mBzyQunjudg5Q36Tt8CRdMPU0krLmkRn3GD2Qrtg/trLgLofs2WnGfja6aYx0idpAQePzMuFncI4DXrTdDSmbM04GFalU0Qgv0wEAdO0H+44awXnBDpUHeaJKtj+bSzxA2t+7ypyLXzFEvpeIucgUqSsjkE9jNm8E5OrPUhddzQBwJLgPWcS/6giBDA25K6wsq6tZ5CiRG63nLG2lti8MPl0+44E8fZUHshNO2NOhfEkG6iT9zuf82nNkk1EvV583GjlFzA+OSDZZaTStVV+wolbnae2ZwzsMTkhEiyjiG8gkF561pDp3AWg2E+PZeE3TMJ6sqSq2Dc/CfW3cHfvYX8z1trmM2uozFRzt17F3TKBZuI6hYC2GqcHGbIKLWSVGd4PLy9U/7d4IZIQBzO4c436/5h/HhOx4zQIAmX5/y5UurzbptreLqK5lICp+45OGGO9lENw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(366004)(39860400002)(346002)(396003)(136003)(451199021)(2906002)(38100700002)(8936002)(8676002)(5660300002)(31696002)(36756003)(86362001)(6486002)(478600001)(54906003)(186003)(6512007)(26005)(6506007)(31686004)(2616005)(83380400001)(41300700001)(66556008)(66946007)(66476007)(6916009)(4326008)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VXhmcjVYNC9ZeUVhVzZkOXg1M0hrTUVFdUYrUlY0Y1g1WlFPQS9PblJXY29F?= =?utf-8?B?eXc2QWJPdmdmY2FZT2ZXZGVYVmhQMVRiV2gwRWp6OVFIQ2ZPWGlSUEcyRy9q?= =?utf-8?B?TkxzMjFRV084RlFwSGY2eFhMbFdTQUNoRHpRTFNBTVBkT2Nzc0NwOFJteDE3?= =?utf-8?B?N3pJT0FyUVd3cUFTY2s0SlAzUmFWZXFnZDd3R2JaZzBiNGRSUzlQU2o2UzBP?= =?utf-8?B?V3RzZ3E1RHhxaVFSNUlMazNqVm1zQk5OVVFpemxuUld6Q2JKeHVZWHVwVzFh?= =?utf-8?B?ZjExa090SHNNdWd4QTZsVzJHZ2xxaThkWExESzI4TkpUSlBCOGg3NWlaUWlB?= =?utf-8?B?c1JlMWg5ZTJVOWlmUHo3akNIS3huNjUvNE1CZTdiTHFpMi9QVkpsYVpCL0lL?= =?utf-8?B?ajJVZU5iMTk0akxxRStDazcxQS9pTDhaUkVsUE9hay9pUHZhSEIzY1NjT091?= =?utf-8?B?ZUhlNVlhV3ROTUpEWXV4K3ZVa25uSUlVT1pwd1RtQ1NaRThkb3cyZmVBYkpn?= =?utf-8?B?L0tXWm1vWHFXaE5aOFU5WmdXY2VEa2RkdTUvaFNmOGQvUVJJMDVjbXFTbXpn?= =?utf-8?B?YlNFMjg2dmdsaERtVG5NdHFPYUh2ZitoL0dxb1F1NElibGkwNjhtYVM1VU1H?= =?utf-8?B?U3pJNzE4c0o5NnN0cHZVeWR6VjIySWtQWDdlRi9uNlc1V3hLSERwSkx1MjJl?= =?utf-8?B?YVBiYnFqSGt6dmVtVjBXNHltV0hubDd6VHBxUmgxTHdLWVRIVis3TnBiZ1lj?= =?utf-8?B?MWNmYk5jZzE3SzZsK2JOZGs0ckJKbTNRRkdXY3BzenEveFdOZlp4K04vb2Uz?= =?utf-8?B?MDZnV0E1WEJoMHdnNDJKT2tWK21lNFRyL0pIRE9DSXpPam1tdVYydXRFajBo?= =?utf-8?B?VE1vQ1ZrQXFHRVFSOFpuQ0w5MGxUOTFoZmlBNTNRTm9mYkplVWxSSlVsbTFB?= =?utf-8?B?RU1HODZ1ZndxQTVqOUtWRE5mQzZtUVM4TWhsYVM5UjFRTFQwQVk5aTlMZ1cw?= =?utf-8?B?TmNzbC9JWk5wWGtzZlNPL1RkMWlqdDZJanMrOGM2WjFBbzFZZmJTMnRjbTdu?= =?utf-8?B?bUg0ZEdnSjFoZ3JTQTRwK3VVeTJlVHNCRElsVnZFdVZtZ3RveU1hc1dUMlhR?= =?utf-8?B?UUYraUVYTkNqUUg5ak9PL2Q3bG9jOVZJMGxqbGhORHlsdGRYVWhQS1Ztb241?= =?utf-8?B?anQ4ZXMzQlhtZmpJVGxiTm1XY3N1VU1YbXlrRHFMQzMvOXUzcjNpSllaakp3?= =?utf-8?B?WnhXRWVncFp6UG9SRlpUeUlnMDY3c1FucC9ZKzNtdXBZQ3RZTGRZL3pFU0Nh?= =?utf-8?B?K3JSRjdGNTZVSHk0Q3JDRlM5YjJSNHdqWkR5YndONklJUFRqVGlNQkRwV0dr?= =?utf-8?B?VmY0b1BhVEh2eHlHLzRHeXdYYm5EdGVJMjJxbDRUclZScE5HQnhsdzArc214?= =?utf-8?B?YW9DZTZMRjQzRTRIOFZUU3FDVWFZSVpvM0VuRGovNk1HK1NVdk82M1lqY253?= =?utf-8?B?Sk9MNHYvcGNHZk1OWmVFU2J6RnhnNUl3Z3dwcHQzV3pNcEhwS0JCN2hUV3dS?= =?utf-8?B?WnVZOHJVZGhCdHNqVHl1aDYwdERXdTFHMHFpOXkzZFNwSGNUMktaZWJOOHIr?= =?utf-8?B?NTBlbzdSZmFNWUwwb05NVFBFVkR3dGcxbU1yVzFuVnhXbHZzdmM2SUJiOVZl?= =?utf-8?B?WGxJakxrZU8wRTZHc2RmS1Q2SEw5U2NrNU5KNVUvNGIwVDdTLytEeXJhcmdN?= =?utf-8?B?Y2JaQWlacVp0L1VldEpjOUFOanFGajhBR2xGZG5xV2t2b0VOYURQa3hYbGNm?= =?utf-8?B?Vzl0eTRyWktsUWUwOGlwZGY2cGZFZjNOQ0F1ai9VRFJzRmZSMm1vTk9mNWxO?= =?utf-8?B?QUFhdXVVR1NYNHlTMDJyWkgzZWhPejJBak9iWUo5bWhWcGVnUWZpbjNZZGVX?= =?utf-8?B?RnJtR3RpblRwNGt0bkNOR2puSTRmbW1XMHVYaDQ5QTE4dVhhaEVub01KbnMz?= =?utf-8?B?U21lVGFiTjRyN1FVMWdBUlRhQlhpbWcydWxpYko1dWRVWGozWGJzSkxmSExp?= =?utf-8?B?RGwwOHc0QkRmZkpFVWk0WGFnWHlSbWludjNZbzN0WHhBWmVqRUxuN21abW9T?= =?utf-8?Q?uFEgIwLhpGdzxZ0nUHOjmHLsw?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d4925db-50fc-4a26-627b-08db4bef0e49 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 15:57:11.3208 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xmD79uMgkBcmhtDa0F3SJ3rz3sD99yKkN/378NoEOkjHiRuRQFin3v3khjMrvG1gGlo5CMPsaA3dvEyifSaLUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8290 The registration by virtual/linear address has downsides: At least on x86 the access is expensive for HVM/PVH domains. Furthermore for 64-bit PV domains the areas are inaccessible (and hence cannot be updated by Xen) when in guest-user mode, and for HVM guests they may be inaccessible when Meltdown mitigations are in place. (There are yet more issues.) In preparation of the introduction of new vCPU operations allowing to register the respective areas (one of the two is x86-specific) by guest-physical address, flesh out the map/unmap functions. Noteworthy differences from map_vcpu_info(): - areas can be registered more than once (and de-registered), - remote vCPU-s are paused rather than checked for being down (which in principle can change right after the check), - the domain lock is taken for a much smaller region. Signed-off-by: Jan Beulich --- RFC: By using global domain page mappings the demand on the underlying VA range may increase significantly. I did consider to use per- domain mappings instead, but they exist for x86 only. Of course we could have arch_{,un}map_guest_area() aliasing global domain page mapping functions on Arm and using per-domain mappings on x86. Yet then again map_vcpu_info() doesn't (and can't) do so. RFC: In map_guest_area() I'm not checking the P2M type, instead - just like map_vcpu_info() - solely relying on the type ref acquisition. Checking for p2m_ram_rw alone would be wrong, as at least p2m_ram_logdirty ought to also be okay to use here (and in similar cases, e.g. in Argo's find_ring_mfn()). p2m_is_pageable() could be used here (like altp2m_vcpu_enable_ve() does) as well as in map_vcpu_info(), yet then again the P2M type is stale by the time it is being looked at anyway without the P2M lock held. --- v2: currd -> d, to cover mem-sharing's copy_guest_area(). Re-base over change(s) earlier in the series. Use ~0 as "unmap" request indicator. --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -1576,7 +1576,82 @@ int map_guest_area(struct vcpu *v, paddr struct guest_area *area, void (*populate)(void *dst, struct vcpu *v)) { - return -EOPNOTSUPP; + struct domain *d = v->domain; + void *map = NULL; + struct page_info *pg = NULL; + int rc = 0; + + if ( ~gaddr ) + { + unsigned long gfn = PFN_DOWN(gaddr); + unsigned int align; + p2m_type_t p2mt; + + if ( gfn != PFN_DOWN(gaddr + size - 1) ) + return -ENXIO; + +#ifdef CONFIG_COMPAT + if ( has_32bit_shinfo(d) ) + align = alignof(compat_ulong_t); + else +#endif + align = alignof(xen_ulong_t); + if ( gaddr & (align - 1) ) + return -ENXIO; + + rc = check_get_page_from_gfn(d, _gfn(gfn), false, &p2mt, &pg); + if ( rc ) + return rc; + + if ( !get_page_type(pg, PGT_writable_page) ) + { + put_page(pg); + return -EACCES; + } + + map = __map_domain_page_global(pg); + if ( !map ) + { + put_page_and_type(pg); + return -ENOMEM; + } + map += PAGE_OFFSET(gaddr); + } + + if ( v != current ) + { + if ( !spin_trylock(&d->hypercall_deadlock_mutex) ) + { + rc = -ERESTART; + goto unmap; + } + + vcpu_pause(v); + + spin_unlock(&d->hypercall_deadlock_mutex); + } + + domain_lock(d); + + if ( map ) + populate(map, v); + + SWAP(area->pg, pg); + SWAP(area->map, map); + + domain_unlock(d); + + if ( v != current ) + vcpu_unpause(v); + + unmap: + if ( pg ) + { + unmap_domain_page_global(map); + put_page_and_type(pg); + } + + return rc; } /* @@ -1587,9 +1662,24 @@ int map_guest_area(struct vcpu *v, paddr void unmap_guest_area(struct vcpu *v, struct guest_area *area) { struct domain *d = v->domain; + void *map; + struct page_info *pg; if ( v != current ) ASSERT(atomic_read(&v->pause_count) | atomic_read(&d->pause_count)); + + domain_lock(d); + map = area->map; + area->map = NULL; + pg = area->pg; + area->pg = NULL; + domain_unlock(d); + + if ( pg ) + { + unmap_domain_page_global(map); + put_page_and_type(pg); + } } int default_initialise_vcpu(struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg) From xen-devel-bounces@lists.xenproject.org Wed May 03 15:58:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 15:58:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529342.823673 (Exim 4.92) (envelope-from ) id 1puErs-0005GW-A4; Wed, 03 May 2023 15:58:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529342.823673; Wed, 03 May 2023 15:58:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puErs-0005Fz-48; Wed, 03 May 2023 15:58:12 +0000 Received: by outflank-mailman (input) for mailman id 529342; Wed, 03 May 2023 15:58:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puErr-0004ZO-Ar for xen-devel@lists.xenproject.org; Wed, 03 May 2023 15:58:11 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2042.outbound.protection.outlook.com [40.107.7.42]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4cfa37bf-e9cb-11ed-b225-6b7b168915f2; Wed, 03 May 2023 17:58:09 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AM9PR04MB8290.eurprd04.prod.outlook.com (2603:10a6:20b:3e3::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.21; Wed, 3 May 2023 15:58:03 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 15:58:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4cfa37bf-e9cb-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DWQ3OkdIcWpnojaH7W+ucsbUWR1ZTeRXk5MK8lmHmASi3pmiabuGpCVVT8WhdErXDqBa4BxJCJ1Alt17mH8fg248Xic8TrMIJ++LrScAGsEwlll0b6TfeOOaLY01SA0PS5k2iVMN18pKgOIzCwdmULN3hBwcdh0EuFYxWKen9PRoixnOkv1nOOGWlQRY04I1ShT2hEXzgbRDQsCixQt4+rR5vfeFZ0mjS6tfqwMez3mMqH0HiAL6oOqD3V5K4Zg7m8Gv4P4sxaaFRdSePHnvsvTXHGqFt54HS6WQvZWHaGPXmmXnpNUPOR0GPGiaTkp6jdEw2CCIMgb3BTcNJoygJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6IQwYv9j9TS5s8pPI31juObfMSOZTWBzzVzQE/pCSAE=; b=JezfK0d/OwXAuSHXH42UrRKDhCwMCqcO7K2vS5uJyVBzBcwnKpxZvQ8D1eIlfGjAHsYzegb/2g8p/GuIckjqP/B5jNCywu/riXvX5Ngwqv7Ssdv5N7wum62mSKsPv7pc+TrAmBVrHTDL8EkPeYBd30evFQgys4vE7PjEnqJ/pGrepvThyoudQ/Gq3q+duZaxXbu9oU+jwijYWDxyIk/PdOXv1OhJfR2s/EVsF8RQOpV7+RRzmqK+wpP4a7dx5kEyqnOMebC7VSnmrC+MHhqOsaG70oubSciRIfv8w2M3LMYJTlqxP/Tpc+umpMfhNw0FvexYy+VIINgj8PwFLHhF6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6IQwYv9j9TS5s8pPI31juObfMSOZTWBzzVzQE/pCSAE=; b=0YW3mguoNtsxk604tYbrugzbScH4vqZrqMg1kaVOUPjNZArkBc8pAhDEoTDdtodKMCe5LtlzaZHttuoPb8apcOUbYMT0Wnc86JwxNaJLlHiUaelFOFVCRNdtS+Mq3Y2ySaR7AWXjDceYgc5zkcDojgW4osb8kCcPe2qBv1AsnOWNaRkxEwXLL/vn1hX/NOd3KXRKC+2TwcILbIx3VFaUqlD2jkr/5wUzaw3ni3NUfgx7UJvNci+tCVmmeW8BrR+oOlRfUjLlFNKqaPOHMuMxhMdXNc5pWltg5l/Tzmms7WErcg/UN3/hYb6aHchx/KRVgy8OCQwdiNFRteQdm1MgMQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <77218fb0-5e96-4ecb-c2b0-4fe8c3ba683f@suse.com> Date: Wed, 3 May 2023 17:58:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: [PATCH v3 7/8] x86: introduce GADDR based secondary time area registration alternative Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <472f8314-9ad7-523a-32dc-d5c2138c2c8c@suse.com> In-Reply-To: <472f8314-9ad7-523a-32dc-d5c2138c2c8c@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FRYP281CA0014.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::24) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|AM9PR04MB8290:EE_ X-MS-Office365-Filtering-Correlation-Id: 8adacc83-d5b0-4ccc-3c71-08db4bef2d0e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nA0ZLjq39ztusNsD3W+n4YXi02q0iFsSXGG607E1IlXbU/vEiyXEfcd6er3qAZhnjj6EAul0hlyYTuFV27y538Qc1q7kCt78VSVA8G/d1R5xNZxBazrtKc4/0KeECMujJYaN88m8yKE3LsPLGiDPPTjltj8wEQgO53lhW86RcS094EcgOsFtKlANBGyAQmbdp710a27VeAmCPFCoIMU/xbJzBs6uNgeG6N7Y4iZ8t3Mxxl2enZ+/p0ILnUimMJrRBfx67u4AY+o3RbJ65nTdTaN2CP+2XsBaH4ckc6bdL941/LhsK1us2oQCMM1yWS98U+P3EOvkeoQWm92wYjwmUK3GwNo3+8w0rTv3hRRkm4xw9vp6gA64aSQtT9eiQi3LlJ60MBsrs6mfGy40ckVxkB1VKuv2Wg9fWXsKDJMtNFsfkBDR4WRATn9hO5AAt5gbrEehI0DGny5NvYnJT1WP5nW/TQOsTtx/tDwnZDnLrkGshhwIUER0jdAKT40qG824G/iR7N3kTNVqG7qShTmlnJNmqAef4U9XcNMc3V7/iPjevo+ShXe55sJov5e+CBcuT36nUGkFL5Qal/fkRmcErRUbGe4KUUjTN1JrvqicOLouQ9+Bm3PCx7fKzUgZgZ5l493G++OhciqIzjc1UK91+Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(366004)(39860400002)(346002)(396003)(136003)(451199021)(2906002)(38100700002)(8936002)(8676002)(5660300002)(31696002)(36756003)(86362001)(6486002)(478600001)(54906003)(186003)(6512007)(26005)(6506007)(31686004)(2616005)(83380400001)(41300700001)(66556008)(66946007)(66476007)(6916009)(4326008)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z25FQ1Q5M2hJTDFWMWxSZWtOTysxZlNBbEJ4MUFLK1phNmhTYVhlZ3NaWUlG?= =?utf-8?B?ZUlxb0JIdzU3RUlRNFF2UzZ3a3h2dy9PbDNTbDkza0grYUNHQksxZENWSXpr?= =?utf-8?B?R21tRURVYnVTVkhwSWhYdHJmRnJBTmNXLzRLZys3TVhJTUN4TW9MLzJWMGNo?= =?utf-8?B?dWdHNmxrTHYwMXVrTTN1M0FRK1FON0ZlSlZpM1ZwMFVSd2pXK3lZOVFlUlA2?= =?utf-8?B?UVVmakR1VUxyV1FvSVRtcEZHdzNYdCtXRkZRRkorcHRpemo4b25TeXNIYm9h?= =?utf-8?B?N0o0cnNhS0pCdjVIN2swbFNMSnlpSkRHVTJRNjVVQlhxcDMwSUgrRjY0SlFh?= =?utf-8?B?UTVaejk4QS8rdDExNnFjakY0WVpMWWpJM2NOUEVwVFVsZ05RdXEvb0loamgz?= =?utf-8?B?bGpHd0NGTGJTWkg5OWc4MXFJYjNoS1hlMGZXaHdCYnd6QjZPRWtLQVFSZGxr?= =?utf-8?B?NmI4eXdyY0cxb1RKaTVvcGR5cFF0Q0dTcnl1S1h6dlV3UDFHZFVQNWR0WFp6?= =?utf-8?B?eE5sMGhuL0VxczhDb29MMXVvVS9rVGZQMXd2YUl0dXhQdGU0LzhqbVhJRksy?= =?utf-8?B?ZS8zY1pwcWZFL1MzNXhrRndTOThLUDI4L2hUbkdPaEF0YTlMQlY5bnc5UmY5?= =?utf-8?B?ZWJCazdZTXFmUHRKYjNCa1JTM0hEaVlCblcxa2RIakN1TzIvSUViaDlpZG9h?= =?utf-8?B?SGM2cDA2eEpaSG52WW1oeHBCeFg0UkNsR2pLZHZ1b3B3cHdJWjJPcis1Yk9Z?= =?utf-8?B?TmNQT2xKUCs4bXlKVCtuREtLZDZhNU44bWpydWUrRzhaamJ5aVFtQ29tbWxI?= =?utf-8?B?SUcyZlRQSHdjTkFGdm9BeXdwT3pXZkgzRzFuK3kyYnVNVWwzRGpaYjREOUl1?= =?utf-8?B?QlJCd3N5ZWZWTlRlcm1vTjJTbUw4N0JyWnlJMWNYR24vZ1d1YmFucGJMRDFs?= =?utf-8?B?MU1rKzBNNkU1M1A5SkovVmxRSzNTNWZnWWE4VHNxZjA3NGhROTVFV09WMWEx?= =?utf-8?B?MUkzWUtmV1IrRUREa2JXcU02SVRMTVpPV3BqdFFjOHh1SmRSQWF0RkQzdmF0?= =?utf-8?B?OUZPTnAvV0RxeG1LTkEvUnNzWVJraVlueHpBSStMaHQ4QzZKd1JFN2tkZUJY?= =?utf-8?B?NDZGNkFrL0NGdDBSbk4zVGoyd3JsUzFxZHlocms3MVhCNjBiTEpiY0pNMGRz?= =?utf-8?B?L0xRRHlvWTBSWXE3UytCMUZZeHd1QitvMnYwc1pqUW10Si91ZFlOcVVhZVE1?= =?utf-8?B?TG5KSVNmTEdISGIrb2lxb0RGU2U3cGRvTFBaSnJxTEhEY3R3NWpuL1JRTFNK?= =?utf-8?B?ckdzMVdsME5PWHFIbGVxQUd6dWFTMDdieDlGSDA5UW1wNzFyM0FzNCtCSGhQ?= =?utf-8?B?cS9EQ2RlOXAvakVWSjZDR0R5amJRcXV5N2tXeFNVSGFoR0VNdTh2ZFkvS2tx?= =?utf-8?B?OThXQ1NFTHF0VEZKd0UzNUthV0hwZWlkRjNqdERYMnZQQTdHUEw4Wk92S0VM?= =?utf-8?B?c05GUEFaMG1zbEZ5WWh0ektxSEpIbkJUdmNlNlJxWGFLVU9DR1ZxRU01ZG1X?= =?utf-8?B?L0JycEpUNjRlQUJ1SWk3Z0l6SWp4ZjVPSGdqMHN2UVFZbnNzbUppMkk5YkE0?= =?utf-8?B?bkNFNHRyWmdYOW5tTHFHTmZzR0FyK1VxN09DSHBBQVJ1eVNXdFNQTTh4eGVG?= =?utf-8?B?a1c4ejViOVZxeTk0SVM5aGkvdXU0bnJ6TmZvTGhUTE5KZ3RRVjFuOG9WTWYz?= =?utf-8?B?aHk4NUI4bGprRTF1RDN3cmg0Z29KRmdrZDRjYnNMVzlsRlBRK2E5a1haMzhM?= =?utf-8?B?SWpiRTB3Rld3dWlIN2lud1FCRUNEVGhoWUhZcjQxbWg3ZzB4U1kvNmR4MUlU?= =?utf-8?B?NFNtVVpaZ213bnJHeDdDQjRZYlJDeU54Q3FBQlJSRWhvNWI4NldrcGN4dHNr?= =?utf-8?B?MThvY0hMcUoxbzlMdUUyeFQxWVZzOVRiRmZUMFUxWGpuMXIwMTZGQ1cyV3Rv?= =?utf-8?B?Tmxub01xNG4wUU1uK29rK3RNZ1BiSmJkZ3NYRENLSGZjV0NqYnpVNlY1SVVZ?= =?utf-8?B?MDBBQWtBMWxOZytnUWdvOHJGQTQ2MlM3RmtaRHFJbUl4L3hFc3IxMFlOemVx?= =?utf-8?Q?XIuaRkbVaIWiyqxtnUYQ4tp74?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8adacc83-d5b0-4ccc-3c71-08db4bef2d0e X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 15:58:02.9418 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zeKTkZKAXxPcnWAwQHiplkpt2tWBC3ott9VQCqULVr/4I+nw8db2Y0Y2YBBXEDzEnjkTaTxz7vFA7+37YSJmDA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8290 The registration by virtual/linear address has downsides: The access is expensive for HVM/PVH domains. Furthermore for 64-bit PV domains the area is inaccessible (and hence cannot be updated by Xen) when in guest-user mode. Introduce a new vCPU operation allowing to register the secondary time area by guest-physical address. An at least theoretical downside to using physically registered areas is that PV then won't see dirty (and perhaps also accessed) bits set in its respective page table entries. Signed-off-by: Jan Beulich --- v3: Re-base. v2: Forge version in force_update_secondary_system_time(). --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -1504,6 +1504,15 @@ int arch_vcpu_reset(struct vcpu *v) return 0; } +static void cf_check +time_area_populate(void *map, struct vcpu *v) +{ + if ( is_pv_vcpu(v) ) + v->arch.pv.pending_system_time.version = 0; + + force_update_secondary_system_time(v, map); +} + long do_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg) { long rc = 0; @@ -1541,6 +1550,25 @@ long do_vcpu_op(int cmd, unsigned int vc break; } + + case VCPUOP_register_vcpu_time_phys_area: + { + struct vcpu_register_time_memory_area area; + + rc = -EFAULT; + if ( copy_from_guest(&area.addr.p, arg, 1) ) + break; + + rc = map_guest_area(v, area.addr.p, + sizeof(vcpu_time_info_t), + &v->arch.time_guest_area, + time_area_populate); + if ( rc == -ERESTART ) + rc = hypercall_create_continuation(__HYPERVISOR_vcpu_op, "iih", + cmd, vcpuid, arg); + + break; + } case VCPUOP_get_physid: { --- a/xen/arch/x86/include/asm/domain.h +++ b/xen/arch/x86/include/asm/domain.h @@ -692,6 +692,8 @@ void domain_cpu_policy_changed(struct do bool update_secondary_system_time(struct vcpu *, struct vcpu_time_info *); +void force_update_secondary_system_time(struct vcpu *, + struct vcpu_time_info *); void vcpu_show_registers(const struct vcpu *); --- a/xen/arch/x86/time.c +++ b/xen/arch/x86/time.c @@ -1633,6 +1633,16 @@ void force_update_vcpu_system_time(struc __update_vcpu_system_time(v, 1); } +void force_update_secondary_system_time(struct vcpu *v, + struct vcpu_time_info *map) +{ + struct vcpu_time_info u; + + collect_time_info(v, &u); + u.version = -1; /* Compensate for version_update_end(). */ + write_time_guest_area(map, &u); +} + static void update_domain_rtc(void) { struct domain *d; --- a/xen/arch/x86/x86_64/domain.c +++ b/xen/arch/x86/x86_64/domain.c @@ -115,6 +115,7 @@ compat_vcpu_op(int cmd, unsigned int vcp case VCPUOP_send_nmi: case VCPUOP_get_physid: + case VCPUOP_register_vcpu_time_phys_area: rc = do_vcpu_op(cmd, vcpuid, arg); break; --- a/xen/include/public/vcpu.h +++ b/xen/include/public/vcpu.h @@ -233,6 +233,7 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_register_ti * VMASST_TYPE_runstate_update_flag engaged by the domain. */ #define VCPUOP_register_runstate_phys_area 14 +#define VCPUOP_register_vcpu_time_phys_area 15 #endif /* __XEN_PUBLIC_VCPU_H__ */ From xen-devel-bounces@lists.xenproject.org Wed May 03 15:58:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 15:58:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529341.823667 (Exim 4.92) (envelope-from ) id 1puErr-0005D0-Ud; Wed, 03 May 2023 15:58:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529341.823667; Wed, 03 May 2023 15:58:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puErr-0005Ct-Rm; Wed, 03 May 2023 15:58:11 +0000 Received: by outflank-mailman (input) for mailman id 529341; Wed, 03 May 2023 15:58:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puErq-0004ZO-Aq for xen-devel@lists.xenproject.org; Wed, 03 May 2023 15:58:10 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2042.outbound.protection.outlook.com [40.107.7.42]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4ca49550-e9cb-11ed-b225-6b7b168915f2; Wed, 03 May 2023 17:58:09 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AM9PR04MB8290.eurprd04.prod.outlook.com (2603:10a6:20b:3e3::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.21; Wed, 3 May 2023 15:57:41 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 15:57:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4ca49550-e9cb-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iwDh4Py+rBePb7bAhR8XAK5SQklMGxSoM4B60GiysjRoNhVdXIIETeqIdIpwB4liBRnZOqrtK8te8JS5PdF/Vme+5E6fNBAPbQZsHIkWbp5e8S3APn5D2At8H1WkMUGURTnUdjJ2BYc/eDX4wJb/qActLI+rm+kw03V/bICqBxW6iLNLYj54V4rtHSxXWCvgOfjvJowc8oIact7ZoRZKeP3qkAMWrioHp6AvMG7k1omCGG83fUHn8coO3oaPNzGWn7wLOA0jvQHVrTu48Jf8aYzEo7Heca8OGpsqFMGP6ZEHmbpAsqxk3bnEoGdFMLSi+Hzd63yoEtzRbwj9Pwunmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cHmrg8DCDjzc3gUkSKqzrnriTYYYSioIWkI/FbXeWW0=; b=TNCmdZWVx1dDyeiANy/VoLyhhx4gNPzIlEsCmK/aZ2To0EKw2fN6Jv0Xokp3jeB8PY9BgchcJ/WfuQVKkJVhXQ52zk+oDKxB09cVzml+e1Qv+nxnthIDIeOtlGMeLbqFTIjqoudqrQaKC5NbV8iWwBxtYEXyjn8q99rVyjjpPu3VRJ10QsFPAXhmEpbbeFff2RbNNPBsYBET74EsoUIJ5p9K0ujtu4s1H8gRASPyji/rY0SdIxLRUJNOXkFgHhbcPhwHRJJ+ZFpAXqOD6cNxpJYskOXtDpTu/B3bvJYqEDaG87EUCY0nCuY6mGkiv/k+oQV0E7Txzgs6yz1wWnhh3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cHmrg8DCDjzc3gUkSKqzrnriTYYYSioIWkI/FbXeWW0=; b=CKhfH78q8lFOPOEj5ms4DACcQP8x9I6T9pIspJRMAuWHJEHR+Xn1XLvD/7H8HAxLHCGvWlXSyh9wU2xm6J8bnIu8pOwvq+k41n1ACpTd4oT4KeLWMl1MQVMJV15i/Fy5FyOOmccQWD64GGcVjfYLBOaDBAAL/tHQE+o87loAjIFi55ZgPM/SbgwRdB+gy4bYDNgDzLsjQZwudhvUFR3g9+fS0DXSD7C+zsCq7y1tk9+9qWFjgU9P2u7E0mmeMGk8Q4NNwJ5CVDjZtTn2em3FnkdMLtPSLGwiQTzmevR3ICAhLlMsaYStj8NOBvEmMEIGh4pZnxkFsViQg3RSGlo1kw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 3 May 2023 17:57:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: [PATCH v3 6/8] domain: introduce GADDR based runstate area registration alternative Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <472f8314-9ad7-523a-32dc-d5c2138c2c8c@suse.com> In-Reply-To: <472f8314-9ad7-523a-32dc-d5c2138c2c8c@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0025.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::12) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|AM9PR04MB8290:EE_ X-MS-Office365-Filtering-Correlation-Id: 884b6d8d-6959-4ce3-f2d8-08db4bef2063 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 90rUOQXzqh4HlIWA+xbpGtmpMbfcpg6+OyFNPMGlDpOacSeJS/0+0cIpDtjQHNxni+VsmvfdQmxtUIfspCqipZE9wiAgVCIL63S3susurwondSPqjzvHL0s0mp+09T/m3bAp/wU5q/ClzBGsJRg2a7gOk/tJPVxvzQunAYsKYc3gMY0ube73QLba28FCG0oBFuZDwGXOPHOLvcTKEBTEqQuSGNRmSy2EfdpVe5NlxFEwK2vXvID0zxNZ5Gq5Kbao3wtxSdaK5SO9/K2LoYPzW4Qn8jv+5sm9vnUAO1cFIf2v8AyXovyFZ04XnG2HiZ/zTkHasuxzTKqNMC6g/rAKzSVWuTvynktvsYmJcuoIGPCPv/vp4OiFSQQDsEi9xSYZrX+F74o5qag2Ln38oDKHeQq6llhqnTAEPmsJ3pJUKcTMCunzzcwad0CDsMr2lkOLvG415ITI72VLbQduRi0Sv6X9zuJuFVKIrOYrUSQ28q1Hia0tU8IVRuXvcTsLHMssOhfy184CQWqgdJ3TbXgibeL5Ogoep3tCvJYSDJ3/mCnp0nBBLE64WW7ETXP7yix+CCUEvv4zec4FixLR4bPXJf4qS3QkA6Nx6G9XFPchOINDYpbziRZzaomDz3dJdw+QZmJ+A5rYGHmGtsQahoKFrQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(366004)(39860400002)(346002)(396003)(136003)(451199021)(2906002)(38100700002)(8936002)(8676002)(5660300002)(31696002)(36756003)(86362001)(6486002)(478600001)(54906003)(186003)(6512007)(26005)(6506007)(31686004)(2616005)(83380400001)(41300700001)(66556008)(66946007)(66476007)(6916009)(4326008)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QkF1Z0pGNTBkT3QzMjE4cEdOS01HNllxM0U0cEM5WEt2RkxheHVDVVVrZTUr?= =?utf-8?B?L2dZRHRyeDQ2VzVFdnpxYkI0QUFRQnd2UWpjYXEvbUZ4QWRsUDRCYW10RkI1?= =?utf-8?B?Y2tJWGU5Wjh1Wml5Z21RV1NENUh1QmgvYngwbEVlSGwwa0xHdHVOaFhOV096?= =?utf-8?B?bWZpdm54ejJvVGRaWDJxMk1LOXcyMjNqbkptRWNvR1crdnpqNVlCL0YrR05a?= =?utf-8?B?MndKTWZyWmtKOEcza2dXTFIrTk43M2xycmg1K1Z6SkZyVGxCaUJ2SldmODhT?= =?utf-8?B?dHNsa1VaSWgrb2lMVGk1cTZhSEV5cG85QmNsN05sdFVMemFsYlFvUkNtSHNr?= =?utf-8?B?OW9xVzBEYXB2YTdvSDFCQTZuTnczcUU3bThWZG5HbDF0MnByMjVUOEk5aC8x?= =?utf-8?B?MEhTNTZqUzkxbUp1Tkd0eUwrNGtqVS9DQ1ZFZkFsTUhmOUIrNjNhOHF4dGlK?= =?utf-8?B?TXVsWlo0cCtSOE1QOWVVc1JCcnJSWGJIRW04YzZpWXZXVnppV0J2Zk1yK3ln?= =?utf-8?B?UTFHY2xjeHE0b09YT0MvNU51dlg1SlFaejBnUUlybkd3Q1l2SUQrcTNKQ2J6?= =?utf-8?B?blJGd3dmd2NzeG5Od2Vtb2FmRFlpdUpoWmlNRUxKTlIvT0tkaC9yMWQxN1Vt?= =?utf-8?B?bTJEMFJkb01ZTkg1M3B4QTNHL1U4UG1MWUlqVUxyL0FMSGtSczFBVmlvSzN3?= =?utf-8?B?OW9iN1BVM1ZWQyttMDFlREg1elhFZmV2WWREbVF0N0FsSnZIRStNOXpnRlpt?= =?utf-8?B?cHZYWVo2WnN4eXNVY2kxM2tqdEJlMDgxcjdaYWFqVFIxbkZ5T1VrcGdnRGFt?= =?utf-8?B?Yk93UVh6OHFLWFVuMXRTQ2VaNkw5Z2E3SzRHaVdMcmc1eHhJVW1Fb2Q1UWtN?= =?utf-8?B?ZlV6ODFCN201ZTY5SVkwbjBLU1Y0cEpiNFdaMEV4MXhteUZiaWMvTDZ3SFdO?= =?utf-8?B?aVRZNGNDRGhwZVk2UHVROVp6VCttQk5kNTZOYW1aNWlqeWxGazV1R0ZMalIw?= =?utf-8?B?bVNxaEEvWEtKMEIxVHptbjgzMHF4ZThZNmxLUXEzTVVncHlHaFZOOHQyd3lv?= =?utf-8?B?SHJuek9qbGV4QmRZeHpRbW94U3h5Z3ZTY1VsV0g0TVNSaEMwZTFlRmJNNkZv?= =?utf-8?B?RnptbVREaE51Uk8vN3cwNnNnU1ROSnNMZi9MU2c0dExrajQzdFpyTEllZ0RL?= =?utf-8?B?RkpWbHJQQ3RiU2RTTEJpU09sajN4OFBmUW93WC93bDkvRGVtSkc1MUp4L25u?= =?utf-8?B?RXZ4RTBYYnZTeWNway9wU1NaRFE1V0dMTWg1UFR3anBXUmFNTnV2Y2VKdnU1?= =?utf-8?B?dG5hUHhOTVlPVHN4OTVxUElvODhzODk5M2lsWmd3MWt4Smk1NUtWVnNVaFhV?= =?utf-8?B?WlUyVVNyT3FKMjNzdXZHMHRuWStrWVEveVZlaDJvWGpVYkR4aFpxWUNlcjJM?= =?utf-8?B?dVBha3BaTUZEL1FnVzdYdHlCVzBVTjNBMG9QenFkSGtrM3NCYWlzSVBCUGZn?= =?utf-8?B?eXdJanZNWmtLeHNaUnBvVUxaZWs3OStER3RxSWxuc2ZWbHJUUlhxZU4zcU9L?= =?utf-8?B?TmtCRnVhTGp4R3I4ME1zNWE3ejhmMlN6SHNRRGljbjZlZmQ5OUZObU1oR0VM?= =?utf-8?B?S0xDcTNQU05kTkJrcFhmSllmWURiQkRnTngzVmhXU2pMbFFud1V4djRLdW91?= =?utf-8?B?YnZaYnF6UXZqMXhIZ1B6SGVJRHdrVEpDRUZXYmpDMlE4a1NWYWtIcGFJOXhk?= =?utf-8?B?QTczb3pVSXlvd3hlWlhmZVVYcUIxU091SS81NVNyK0paSUNIZmNjM1I5VzVK?= =?utf-8?B?WnVYdzBJRGUzZFc0YmNjN2kxWXYwYUUrRjU0QXFJL1pxSW5GM3VtSGJ5RUhn?= =?utf-8?B?QitHZS9oTGdETjRacHpEcFNyNWxRSU9GMVBwSE5TY2NkTjYydksreEJKMTdv?= =?utf-8?B?SzMyQTNxZm5aU1FRVTJpdkpGdHZiekhKa3RTc2thbUphOXBiYUZHWkFkVSsr?= =?utf-8?B?MEdJTElrd0ZQcXZQYlNFN2JIT2kzMnlVU1UzZGU1dUhwWWV5eEN0NDFZMlZp?= =?utf-8?B?TzdLS3Z2b1E3aFplYWpqZkN1SHl6TFNKdzRJZCthZlhmdXFsQTNLRFNRcFJU?= =?utf-8?Q?IqcBH3knkketuzJfsnl8IkDxJ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 884b6d8d-6959-4ce3-f2d8-08db4bef2063 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 15:57:41.6601 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 708Gqe18ZRlBelGpJLvdT/lrx4D3F5jxQ4pq5jCfTGM1tHxQTcLoYubFkPry1Y4pf/5aEteWWAVrJt26SBoYKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8290 The registration by virtual/linear address has downsides: At least on x86 the access is expensive for HVM/PVH domains. Furthermore for 64-bit PV domains the area is inaccessible (and hence cannot be updated by Xen) when in guest-user mode. Introduce a new vCPU operation allowing to register the runstate area by guest-physical address. An at least theoretical downside to using physically registered areas is that PV then won't see dirty (and perhaps also accessed) bits set in its respective page table entries. Signed-off-by: Jan Beulich --- v2: Extend comment in public header. --- a/xen/arch/x86/x86_64/domain.c +++ b/xen/arch/x86/x86_64/domain.c @@ -12,6 +12,22 @@ CHECK_vcpu_get_physid; #undef xen_vcpu_get_physid +static void cf_check +runstate_area_populate(void *map, struct vcpu *v) +{ + if ( is_pv_vcpu(v) ) + v->arch.pv.need_update_runstate_area = false; + + v->runstate_guest_area_compat = true; + + if ( v == current ) + { + struct compat_vcpu_runstate_info *info = map; + + XLAT_vcpu_runstate_info(info, &v->runstate); + } +} + int compat_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg) { @@ -57,6 +73,25 @@ compat_vcpu_op(int cmd, unsigned int vcp break; } + + case VCPUOP_register_runstate_phys_area: + { + struct compat_vcpu_register_runstate_memory_area area; + + rc = -EFAULT; + if ( copy_from_guest(&area.addr.p, arg, 1) ) + break; + + rc = map_guest_area(v, area.addr.p, + sizeof(struct compat_vcpu_runstate_info), + &v->runstate_guest_area, + runstate_area_populate); + if ( rc == -ERESTART ) + rc = hypercall_create_continuation(__HYPERVISOR_vcpu_op, "iih", + cmd, vcpuid, arg); + + break; + } case VCPUOP_register_vcpu_time_memory_area: { --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -1801,6 +1801,26 @@ bool update_runstate_area(struct vcpu *v return rc; } +static void cf_check +runstate_area_populate(void *map, struct vcpu *v) +{ +#ifdef CONFIG_PV + if ( is_pv_vcpu(v) ) + v->arch.pv.need_update_runstate_area = false; +#endif + +#ifdef CONFIG_COMPAT + v->runstate_guest_area_compat = false; +#endif + + if ( v == current ) + { + struct vcpu_runstate_info *info = map; + + *info = v->runstate; + } +} + long common_vcpu_op(int cmd, struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg) { long rc = 0; @@ -1982,6 +2002,25 @@ long common_vcpu_op(int cmd, struct vcpu break; } + + case VCPUOP_register_runstate_phys_area: + { + struct vcpu_register_runstate_memory_area area; + + rc = -EFAULT; + if ( copy_from_guest(&area.addr.p, arg, 1) ) + break; + + rc = map_guest_area(v, area.addr.p, + sizeof(struct vcpu_runstate_info), + &v->runstate_guest_area, + runstate_area_populate); + if ( rc == -ERESTART ) + rc = hypercall_create_continuation(__HYPERVISOR_vcpu_op, "iih", + cmd, vcpuid, arg); + + break; + } default: rc = -ENOSYS; --- a/xen/include/public/vcpu.h +++ b/xen/include/public/vcpu.h @@ -221,6 +221,19 @@ struct vcpu_register_time_memory_area { typedef struct vcpu_register_time_memory_area vcpu_register_time_memory_area_t; DEFINE_XEN_GUEST_HANDLE(vcpu_register_time_memory_area_t); +/* + * Like the respective VCPUOP_register_*_memory_area, just using the "addr.p" + * field of the supplied struct as a guest physical address (i.e. in GFN space). + * The respective area may not cross a page boundary. Pass ~0 to unregister an + * area. Note that as long as an area is registered by physical address, the + * linear address based area will not be serviced (updated) by the hypervisor. + * + * Note that the area registered via VCPUOP_register_runstate_memory_area will + * be updated in the same manner as the one registered via virtual address PLUS + * VMASST_TYPE_runstate_update_flag engaged by the domain. + */ +#define VCPUOP_register_runstate_phys_area 14 + #endif /* __XEN_PUBLIC_VCPU_H__ */ /* From xen-devel-bounces@lists.xenproject.org Wed May 03 15:58:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 15:58:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529346.823687 (Exim 4.92) (envelope-from ) id 1puEsG-00069v-FZ; Wed, 03 May 2023 15:58:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529346.823687; Wed, 03 May 2023 15:58:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puEsG-00069o-CH; Wed, 03 May 2023 15:58:36 +0000 Received: by outflank-mailman (input) for mailman id 529346; Wed, 03 May 2023 15:58:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puEsF-0004ZO-F4 for xen-devel@lists.xenproject.org; Wed, 03 May 2023 15:58:35 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2047.outbound.protection.outlook.com [40.107.7.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5b68b310-e9cb-11ed-b225-6b7b168915f2; Wed, 03 May 2023 17:58:34 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AM9PR04MB8290.eurprd04.prod.outlook.com (2603:10a6:20b:3e3::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.21; Wed, 3 May 2023 15:58:32 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 15:58:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5b68b310-e9cb-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bd50JmvKVslpnn3Ed/ZBvSBw54hpjdTregOxwQUs0Xed+evjNrY0L5b5PNLDvoVEsTfg+1f22sXAkJGlPNqyawclBnJOnuo5N7WSK31c1DzxkgzesPk0um0V5dVvMOwEnfv2np5gISrxQkT7RDg0u12y7pA82GkynF5E+BkYjX/0Tfumxuwo5BCOEqSqqKAspkhHrU9u3uqwe24mnK1O0cBmPOdf9FTbYc2/YlLE6V4OALi2cP6pL6SOeQpp4iVxqK16ooY3ZXcn42ilEXHhYVUq+ROaSqEbvHXVAKmj8WK4GA0ACriC8zXoBTHdWFovK7THFj6xPq3nE8TnXEGk5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F0sX7Qef0nkvc/rC96yOb8shBC/hUhR66PShSaviz8s=; b=CU//CzaPs5F3r/iQZE8U1AMY7xIkMw6C9vqo2MPFPiCaC0FTo0b6dHF954rsPSW+tam8LNTYcMZ28kXEwzLa9x4hugHbyp89GH7Zyv2d3J+z7n7VrARQ8kcc21hTnz2xhL2WKIyJm3p5AwSHoeryG2UUhVBF1nQjTRAfupCzbnd+FHutNsBswF/4KlCMA30r7cvZyWzdKW4SoWts+6tr+uUt13B8mraDKNfZHGdfrQYFo1VP5/l/AHLVgS61QrcooHWnBHKEj7NdLdp7PCHiaJau0oxAcSOPMlCsqYENySyagX3hQYmL47MtUs+hEXEHoPb5cKGvxmLRt3XLOzhGlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F0sX7Qef0nkvc/rC96yOb8shBC/hUhR66PShSaviz8s=; b=DWFubvPfRH5sAPn18sEAXiebzjuhtdxWkNQ0fOMc1mlHloNUI4zFbPXUHPYfphnkiHj/y++Eu3d9oU0LVOQAA33brDgLwlMhJ83dSJ/maLQ7Wy5hAVybk0KDKIAPOyTnWfArbI4kdvvaavp4J3PSnCFvFDZMljU9YzkxLAH2AllQ37+HUORb/gZXkxSuJ1A8yl9wjMczTdoVtPlrmBSSi0udFqTLmkOJcklg/ryURfyfzzVSC88kulxOij4kY5f12q2tyHGPSfk0rhMF+VOEgI5uyKe/uP97afxzm0jfejbNEiGKXpTsN/Dkr8BfOR8odX5ehyRvEZ9GGf0iTcND2w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 3 May 2023 17:58:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: [PATCH v3 8/8] common: convert vCPU info area registration Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tamas K Lengyel References: <472f8314-9ad7-523a-32dc-d5c2138c2c8c@suse.com> In-Reply-To: <472f8314-9ad7-523a-32dc-d5c2138c2c8c@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0088.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9b::13) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|AM9PR04MB8290:EE_ X-MS-Office365-Filtering-Correlation-Id: bf0b7847-74f1-44e7-d870-08db4bef3e6e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p6bqDp2ARKnRgO1KHKF1evwJDNuv6wPzdDaycrBO9whT8bkj3YRMep1PLeEASJFg+29aaEbwnDPBFfB7SNCXwJt137bt8wPS23Sngs91oQ/DwY7Lx7iTzv/Q8acWkx3J31HKeGYQvPhM4h77osqOThjk5VxP/wk8ziwR0ehXWyP92VQ8WWvB9H6wzJesE0YREK0xOMbd73z4shn8mIT8C14XL43BzwqBVS0vxwdd9PqBg4ptocd2W/kjYNmppNotRGVRkMLB+qpH6HDebtfBynNxHEKCnJz4RKnd2YNZSkx1yU1EjXXo+wb7IxVP2NmH2NDhBMrhDgtgFYlY4uH5ydxcmL++hCBD7XjLoxuSV6olhgEyJlZ0Xp2RfJs6v7z3yxnGbHzXnwBoHQrGBKBGvx4DWW7nix0BYtZ8C4YS3jduqyRbXeZFqfp8EXjYagivVsFgEKegM46zkImUZfb+8ZQjmxzSpYbkspqoP9/66hh2zn/XxG+rdEKxLt0TMqE9ysc9RJLKKQXqVFjCwKcVwqTQ1R22bK7jR9p2nStAayiMq7CXPGNtdaK6/axwrnJwGqqgQ/yfH+HckoWN1PQ1fWWJhxws5JBiBYxyh9tQigeIhslg0H6zTgy+nMDMLC5ZmuYkGPDLuK4GGLxii9rkKZq+MI+3Ij51WxRK6Iy1/6fkP8zkir1Je3bARx/Le0UH X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(366004)(39860400002)(346002)(396003)(136003)(451199021)(30864003)(2906002)(38100700002)(8936002)(8676002)(5660300002)(31696002)(36756003)(86362001)(6486002)(478600001)(54906003)(186003)(6512007)(26005)(6506007)(31686004)(2616005)(83380400001)(41300700001)(66556008)(66946007)(66476007)(6916009)(4326008)(316002)(43740500002)(45980500001)(309714004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M09RTzZheWFyMU1Uby91OW5wOEJobmdTcVNEeFkwa21TdFBheHNvaFlNRVVw?= =?utf-8?B?Z2lUNW1QUUl6R3VtSHZJYjFJSzFxdUUwMTdpOUV5bFhrWC8vQXcvaHVJUUZu?= =?utf-8?B?UmVJTGFOZUx4VXJBcWJwcmVjQkRzUVc4aVdjajdEdkVyQ1J4ZlJaL3dqWVdj?= =?utf-8?B?Rm9WSmRKSDRmTnR3SGJjdDV3bnQzS1UxTGlxM0xrNUVWOTNkL3JQeEhLNy9a?= =?utf-8?B?Y3IvQVdNT1lrNFhJRStrTUU2Vzh3cDVJYVlxZzhlaStkQlUrU3NLRElsZ2RV?= =?utf-8?B?bW9Xa09kbzExa1AxaUJVOFEyV0VVSUhxZVdlampWbjNZR214TG1SaXpNQXdy?= =?utf-8?B?MDVyNDAxY1I4ckxSYW5Kc1lSbVVobXZ4akc0SXJiSDVIbkxBdml3bVZCUi9I?= =?utf-8?B?Q1RkMCtYRFhob09qTE9sNmNmbHdhWEVCcVRCYld1S0VmaUFmT3FTanQrMnFT?= =?utf-8?B?Z29ld1hXa1crc2VMMUdWZzFqNVNvUHN1d2ZPRHBETlFFZDE0bTY0ZnU4d0lo?= =?utf-8?B?UzlRazRESy92RzBPeDhpeEcrMWp5OUF6d0hkZS9pQXp2d2JqdHZreE9HWkY5?= =?utf-8?B?QXRDYUJKOUtLcE9YVnNUSUZMeHZpbGVnOHFVd2NCVEJ1RjhOcWRaMk1tMllW?= =?utf-8?B?Z0NnVHBycENXcnZRU0FkMXMyUU9ObVZ6OFdQZ1c1VUhQS1h3Wm5WYjhsekNK?= =?utf-8?B?aFlYWUpXQUt5NkVWQmExMmwxWkkyOHpsUlM5Q2k0b09HYjJESFlXamQzVWlp?= =?utf-8?B?UGFyWHc3RHBHTTU5bWE4WjhNaWw1Y2p0OS9neUFKUURzTkdvMlFoZFc4TjZZ?= =?utf-8?B?cWFKcHQ4d25NeHRYQ1MxcnJSUzdWdk80Mm9vTEtoamJIMWlheVlKNzZITk5R?= =?utf-8?B?c1ZVR2RjWk9wcm5ZeXl6UjBpODkvMC9veGI0WEx0K1d5cVZvSzEzdVcrNjV0?= =?utf-8?B?aW9RQklCYnM3b2M5MVNlcVdUanZ0NDZzbVJQTm56ZjZ3NXBkOGluZVBaWFJB?= =?utf-8?B?QkNtYTV1N0V0d290OEtRZm92WmZMSXFZRXREV3hrYVU1ZDh0cE45VXBaTUt2?= =?utf-8?B?VlBNMWRxMzBBU3pkdTI1bXBRZThscThySTF2ZklPL3ArNExCT2pQaUtqeDZS?= =?utf-8?B?RVNHdmZxMVRWTUlFUG10cmpmazlTMllPbVF0OTBRcUl1MG9ncFlob0hoMjBw?= =?utf-8?B?bktscWRvRk5ITUwrb3JJUVkwbU1LeGJyN0xWd2JUWjBpNkZteE5XaXUwdy9R?= =?utf-8?B?Ti9OSVE0RCtmckxiR2hJampjVG5YUUtTL2oxL0ludC9hMlBkQzluYW5vWjNl?= =?utf-8?B?UDBMU1hMTE1DeU9zL3pVREduckxoZk5xcEdtVzFYYmwwVzQ3TDhKemRsR3lF?= =?utf-8?B?bU5ZS3RDZytVWXZ4cGc0RVF4b2tZUkljUm94Q2s5NDJpcWZlcmQ0OWxIcVl1?= =?utf-8?B?QlNwTHlIN2Jza0R3dEUyeVVzYklXeFhQbzNPeTJRQ2RKVkRJOFhrVkN2TlRV?= =?utf-8?B?Y0ZsMVAzc3JQZFZIZmtRK1lpNTR3MTRRa0xEbzl5SW9Lc01mcnNGZjAwbUV1?= =?utf-8?B?SHR4TFBKK2lDNnVtMUFxOGhvcC9JZldVejIrd3N0bkQyL2M0NFRMRHFmcWt5?= =?utf-8?B?VGVCcGtoMWlwU0lQRjIxd1B2eTgwZktVcWhnQWVWeDNybmJZVlpTazFhSWtK?= =?utf-8?B?Q0lia2lHVDNRblA2VFgzSy9PK0hyaWFiN1Znblg5cFgzaVMyS01DTmJ1WHBU?= =?utf-8?B?eHJzVGRpbzREN0xqYzA4Q0tDK2ZEb0dTYXVIdGlxRmp0SndTL1ZPZC9oS1Fx?= =?utf-8?B?WmdTZUZDcWZkT2dHVVlEcm90eEJJTmw5cERSRXN3VC8zckJia3NZSWFXNVFi?= =?utf-8?B?V3J6Wk94NEsvNXpoSlhNYmFBOVAraEV6d3Y1NWdBUEZ3dXV4VS9lL1p4SkRr?= =?utf-8?B?WDA2N0dqYWFlUnA4M3ZvQm8xNy9YRFdaT2pwWGp2enZjVGVnVnlUUTVJZW9a?= =?utf-8?B?cmxyeWZyOTQrUm1CRWpKN1RJUys3RldSOTBMbHplTnZLSndNRTVIZVp4RWZX?= =?utf-8?B?bXczaWx5S05yMVVZbTE1Z01UZTFLaEc1ak8ycHJVNFJmRzhMbm5MejNHdit1?= =?utf-8?Q?SaLkKtnIDcYU8e4NL2vYmr6Im?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bf0b7847-74f1-44e7-d870-08db4bef3e6e X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 15:58:32.1179 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MpwZDxQK+7PAdFMZA5LzTU1Vu1oU/aRCEhX5K9XUzBeFls2sjy0/H43+t0JqdyQ+3f5N7Bi9+6cjyeBJuQMR3A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8290 Switch to using map_guest_area(). Noteworthy differences from map_vcpu_info(): - remote vCPU-s are paused rather than checked for being down (which in principle can change right after the check), - the domain lock is taken for a much smaller region, - the error code for an attempt to re-register the area is now -EBUSY, - we could in principle permit de-registration when no area was previously registered (which would permit "probing", if necessary for anything). Note that this eliminates a bug in copy_vcpu_settings(): The function did allocate a new page regardless of the GFN already having a mapping, thus in particular breaking the case of two vCPU-s having their info areas on the same page. Signed-off-by: Jan Beulich --- RFC: I'm not really certain whether the preliminary check (ahead of calling map_guest_area()) is worthwhile to have. --- v2: Re-base over changes earlier in the series. Properly enforce no re- registration. Avoid several casts by introducing local variables. --- a/xen/arch/x86/include/asm/shared.h +++ b/xen/arch/x86/include/asm/shared.h @@ -26,17 +26,20 @@ static inline void arch_set_##field(stru #define GET_SET_VCPU(type, field) \ static inline type arch_get_##field(const struct vcpu *v) \ { \ + const vcpu_info_t *vi = v->vcpu_info_area.map; \ + \ return !has_32bit_shinfo(v->domain) ? \ - v->vcpu_info->native.arch.field : \ - v->vcpu_info->compat.arch.field; \ + vi->native.arch.field : vi->compat.arch.field; \ } \ static inline void arch_set_##field(struct vcpu *v, \ type val) \ { \ + vcpu_info_t *vi = v->vcpu_info_area.map; \ + \ if ( !has_32bit_shinfo(v->domain) ) \ - v->vcpu_info->native.arch.field = val; \ + vi->native.arch.field = val; \ else \ - v->vcpu_info->compat.arch.field = val; \ + vi->compat.arch.field = val; \ } #else @@ -57,12 +60,16 @@ static inline void arch_set_##field(stru #define GET_SET_VCPU(type, field) \ static inline type arch_get_##field(const struct vcpu *v) \ { \ - return v->vcpu_info->arch.field; \ + const vcpu_info_t *vi = v->vcpu_info_area.map; \ + \ + return vi->arch.field; \ } \ static inline void arch_set_##field(struct vcpu *v, \ type val) \ { \ - v->vcpu_info->arch.field = val; \ + vcpu_info_t *vi = v->vcpu_info_area.map; \ + \ + vi->arch.field = val; \ } #endif --- a/xen/arch/x86/mm/mem_sharing.c +++ b/xen/arch/x86/mm/mem_sharing.c @@ -1749,53 +1749,24 @@ static int copy_vpmu(struct vcpu *d_vcpu static int copy_vcpu_settings(struct domain *cd, const struct domain *d) { unsigned int i; - struct p2m_domain *p2m = p2m_get_hostp2m(cd); int ret = -EINVAL; for ( i = 0; i < cd->max_vcpus; i++ ) { struct vcpu *d_vcpu = d->vcpu[i]; struct vcpu *cd_vcpu = cd->vcpu[i]; - mfn_t vcpu_info_mfn; if ( !d_vcpu || !cd_vcpu ) continue; - /* Copy & map in the vcpu_info page if the guest uses one */ - vcpu_info_mfn = d_vcpu->vcpu_info_mfn; - if ( !mfn_eq(vcpu_info_mfn, INVALID_MFN) ) - { - mfn_t new_vcpu_info_mfn = cd_vcpu->vcpu_info_mfn; - - /* Allocate & map the page for it if it hasn't been already */ - if ( mfn_eq(new_vcpu_info_mfn, INVALID_MFN) ) - { - gfn_t gfn = mfn_to_gfn(d, vcpu_info_mfn); - unsigned long gfn_l = gfn_x(gfn); - struct page_info *page; - - if ( !(page = alloc_domheap_page(cd, 0)) ) - return -ENOMEM; - - new_vcpu_info_mfn = page_to_mfn(page); - set_gpfn_from_mfn(mfn_x(new_vcpu_info_mfn), gfn_l); - - ret = p2m->set_entry(p2m, gfn, new_vcpu_info_mfn, - PAGE_ORDER_4K, p2m_ram_rw, - p2m->default_access, -1); - if ( ret ) - return ret; - - ret = map_vcpu_info(cd_vcpu, gfn_l, - PAGE_OFFSET(d_vcpu->vcpu_info)); - if ( ret ) - return ret; - } - - copy_domain_page(new_vcpu_info_mfn, vcpu_info_mfn); - } - - /* Same for the (physically registered) runstate and time info areas. */ + /* + * Copy and map the vcpu_info page and the (physically registered) + * runstate and time info areas. + */ + ret = copy_guest_area(&cd_vcpu->vcpu_info_area, + &d_vcpu->vcpu_info_area, cd_vcpu, d); + if ( ret ) + return ret; ret = copy_guest_area(&cd_vcpu->runstate_guest_area, &d_vcpu->runstate_guest_area, cd_vcpu, d); if ( ret ) --- a/xen/arch/x86/pv/shim.c +++ b/xen/arch/x86/pv/shim.c @@ -383,7 +383,7 @@ int pv_shim_shutdown(uint8_t reason) for_each_vcpu ( d, v ) { /* Unmap guest vcpu_info page and runstate/time areas. */ - unmap_vcpu_info(v); + unmap_guest_area(v, &v->vcpu_info_area); unmap_guest_area(v, &v->runstate_guest_area); unmap_guest_area(v, &v->arch.time_guest_area); --- a/xen/arch/x86/time.c +++ b/xen/arch/x86/time.c @@ -1547,7 +1547,7 @@ static void __update_vcpu_system_time(st struct vcpu_time_info *u = &vcpu_info(v, time), _u; const struct domain *d = v->domain; - if ( v->vcpu_info == NULL ) + if ( !v->vcpu_info_area.map ) return; collect_time_info(v, &_u); --- a/xen/arch/x86/x86_64/asm-offsets.c +++ b/xen/arch/x86/x86_64/asm-offsets.c @@ -53,7 +53,7 @@ void __dummy__(void) OFFSET(VCPU_processor, struct vcpu, processor); OFFSET(VCPU_domain, struct vcpu, domain); - OFFSET(VCPU_vcpu_info, struct vcpu, vcpu_info); + OFFSET(VCPU_vcpu_info, struct vcpu, vcpu_info_area.map); OFFSET(VCPU_trap_bounce, struct vcpu, arch.pv.trap_bounce); OFFSET(VCPU_thread_flags, struct vcpu, arch.flags); OFFSET(VCPU_event_addr, struct vcpu, arch.pv.event_callback_eip); --- a/xen/arch/x86/x86_64/traps.c +++ b/xen/arch/x86/x86_64/traps.c @@ -96,7 +96,7 @@ static void _show_registers( if ( context == CTXT_hypervisor ) printk(" %pS", _p(regs->rip)); printk("\nRFLAGS: %016lx ", regs->rflags); - if ( (context == CTXT_pv_guest) && v && v->vcpu_info ) + if ( (context == CTXT_pv_guest) && v && v->vcpu_info_area.map ) printk("EM: %d ", !!vcpu_info(v, evtchn_upcall_mask)); printk("CONTEXT: %s", context_names[context]); if ( v && !is_idle_vcpu(v) ) --- a/xen/common/compat/domain.c +++ b/xen/common/compat/domain.c @@ -49,7 +49,7 @@ int compat_common_vcpu_op(int cmd, struc { case VCPUOP_initialise: { - if ( v->vcpu_info == &dummy_vcpu_info ) + if ( v->vcpu_info_area.map == &dummy_vcpu_info ) return -EINVAL; #ifdef CONFIG_HVM --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -127,10 +127,10 @@ static void vcpu_info_reset(struct vcpu { struct domain *d = v->domain; - v->vcpu_info = ((v->vcpu_id < XEN_LEGACY_MAX_VCPUS) - ? (vcpu_info_t *)&shared_info(d, vcpu_info[v->vcpu_id]) - : &dummy_vcpu_info); - v->vcpu_info_mfn = INVALID_MFN; + v->vcpu_info_area.map = + ((v->vcpu_id < XEN_LEGACY_MAX_VCPUS) + ? (vcpu_info_t *)&shared_info(d, vcpu_info[v->vcpu_id]) + : &dummy_vcpu_info); } static void vmtrace_free_buffer(struct vcpu *v) @@ -964,7 +964,7 @@ int domain_kill(struct domain *d) return -ERESTART; for_each_vcpu ( d, v ) { - unmap_vcpu_info(v); + unmap_guest_area(v, &v->vcpu_info_area); unmap_guest_area(v, &v->runstate_guest_area); } d->is_dying = DOMDYING_dead; @@ -1419,7 +1419,7 @@ int domain_soft_reset(struct domain *d, for_each_vcpu ( d, v ) { set_xen_guest_handle(runstate_guest(v), NULL); - unmap_vcpu_info(v); + unmap_guest_area(v, &v->vcpu_info_area); unmap_guest_area(v, &v->runstate_guest_area); } @@ -1467,111 +1467,6 @@ int vcpu_reset(struct vcpu *v) return rc; } -/* - * Map a guest page in and point the vcpu_info pointer at it. This - * makes sure that the vcpu_info is always pointing at a valid piece - * of memory, and it sets a pending event to make sure that a pending - * event doesn't get missed. - */ -int map_vcpu_info(struct vcpu *v, unsigned long gfn, unsigned int offset) -{ - struct domain *d = v->domain; - void *mapping; - vcpu_info_t *new_info; - struct page_info *page; - unsigned int align; - - if ( offset > (PAGE_SIZE - sizeof(*new_info)) ) - return -ENXIO; - -#ifdef CONFIG_COMPAT - BUILD_BUG_ON(sizeof(*new_info) != sizeof(new_info->compat)); - if ( has_32bit_shinfo(d) ) - align = alignof(new_info->compat); - else -#endif - align = alignof(*new_info); - if ( offset & (align - 1) ) - return -ENXIO; - - if ( !mfn_eq(v->vcpu_info_mfn, INVALID_MFN) ) - return -EINVAL; - - /* Run this command on yourself or on other offline VCPUS. */ - if ( (v != current) && !(v->pause_flags & VPF_down) ) - return -EINVAL; - - page = get_page_from_gfn(d, gfn, NULL, P2M_UNSHARE); - if ( !page ) - return -EINVAL; - - if ( !get_page_type(page, PGT_writable_page) ) - { - put_page(page); - return -EINVAL; - } - - mapping = __map_domain_page_global(page); - if ( mapping == NULL ) - { - put_page_and_type(page); - return -ENOMEM; - } - - new_info = (vcpu_info_t *)(mapping + offset); - - if ( v->vcpu_info == &dummy_vcpu_info ) - { - memset(new_info, 0, sizeof(*new_info)); -#ifdef XEN_HAVE_PV_UPCALL_MASK - __vcpu_info(v, new_info, evtchn_upcall_mask) = 1; -#endif - } - else - { - memcpy(new_info, v->vcpu_info, sizeof(*new_info)); - } - - v->vcpu_info = new_info; - v->vcpu_info_mfn = page_to_mfn(page); - - /* Set new vcpu_info pointer /before/ setting pending flags. */ - smp_wmb(); - - /* - * Mark everything as being pending just to make sure nothing gets - * lost. The domain will get a spurious event, but it can cope. - */ -#ifdef CONFIG_COMPAT - if ( !has_32bit_shinfo(d) ) - write_atomic(&new_info->native.evtchn_pending_sel, ~0); - else -#endif - write_atomic(&vcpu_info(v, evtchn_pending_sel), ~0); - vcpu_mark_events_pending(v); - - return 0; -} - -/* - * Unmap the vcpu info page if the guest decided to place it somewhere - * else. This is used from domain_kill() and domain_soft_reset(). - */ -void unmap_vcpu_info(struct vcpu *v) -{ - mfn_t mfn = v->vcpu_info_mfn; - - if ( mfn_eq(mfn, INVALID_MFN) ) - return; - - unmap_domain_page_global((void *) - ((unsigned long)v->vcpu_info & PAGE_MASK)); - - vcpu_info_reset(v); /* NB: Clobbers v->vcpu_info_mfn */ - - put_page_and_type(mfn_to_page(mfn)); -} - int map_guest_area(struct vcpu *v, paddr_t gaddr, unsigned int size, struct guest_area *area, void (*populate)(void *dst, struct vcpu *v)) @@ -1633,14 +1528,44 @@ int map_guest_area(struct vcpu *v, paddr domain_lock(d); - if ( map ) - populate(map, v); + /* No re-registration of the vCPU info area. */ + if ( area != &v->vcpu_info_area || !area->pg ) + { + if ( map ) + populate(map, v); - SWAP(area->pg, pg); - SWAP(area->map, map); + SWAP(area->pg, pg); + SWAP(area->map, map); + } + else + rc = -EBUSY; domain_unlock(d); + /* Set pending flags /after/ new vcpu_info pointer was set. */ + if ( area == &v->vcpu_info_area && !rc ) + { + /* + * Mark everything as being pending just to make sure nothing gets + * lost. The domain will get a spurious event, but it can cope. + */ +#ifdef CONFIG_COMPAT + if ( !has_32bit_shinfo(d) ) + { + vcpu_info_t *info = area->map; + + /* For VCPUOP_register_vcpu_info handling in common_vcpu_op(). */ + BUILD_BUG_ON(sizeof(*info) != sizeof(info->compat)); + write_atomic(&info->native.evtchn_pending_sel, ~0); + } + else +#endif + write_atomic(&vcpu_info(v, evtchn_pending_sel), ~0); + vcpu_mark_events_pending(v); + + force_update_vcpu_system_time(v); + } + if ( v != current ) vcpu_unpause(v); @@ -1670,7 +1595,10 @@ void unmap_guest_area(struct vcpu *v, st domain_lock(d); map = area->map; - area->map = NULL; + if ( area == &v->vcpu_info_area ) + vcpu_info_reset(v); + else + area->map = NULL; pg = area->pg; area->pg = NULL; domain_unlock(d); @@ -1801,6 +1729,27 @@ bool update_runstate_area(struct vcpu *v return rc; } +/* + * This makes sure that the vcpu_info is always pointing at a valid piece of + * memory, and it sets a pending event to make sure that a pending event + * doesn't get missed. + */ +static void cf_check +vcpu_info_populate(void *map, struct vcpu *v) +{ + vcpu_info_t *info = map; + + if ( v->vcpu_info_area.map == &dummy_vcpu_info ) + { + memset(info, 0, sizeof(*info)); +#ifdef XEN_HAVE_PV_UPCALL_MASK + __vcpu_info(v, info, evtchn_upcall_mask) = 1; +#endif + } + else + memcpy(info, v->vcpu_info_area.map, sizeof(*info)); +} + static void cf_check runstate_area_populate(void *map, struct vcpu *v) { @@ -1830,7 +1779,7 @@ long common_vcpu_op(int cmd, struct vcpu switch ( cmd ) { case VCPUOP_initialise: - if ( v->vcpu_info == &dummy_vcpu_info ) + if ( v->vcpu_info_area.map == &dummy_vcpu_info ) return -EINVAL; rc = arch_initialise_vcpu(v, arg); @@ -1961,16 +1910,29 @@ long common_vcpu_op(int cmd, struct vcpu case VCPUOP_register_vcpu_info: { struct vcpu_register_vcpu_info info; + paddr_t gaddr; rc = -EFAULT; if ( copy_from_guest(&info, arg, 1) ) break; - domain_lock(d); - rc = map_vcpu_info(v, info.mfn, info.offset); - domain_unlock(d); + rc = -EINVAL; + gaddr = gfn_to_gaddr(_gfn(info.mfn)) + info.offset; + if ( !~gaddr || + gfn_x(gaddr_to_gfn(gaddr)) != info.mfn ) + break; - force_update_vcpu_system_time(v); + /* Preliminary check only; see map_guest_area(). */ + rc = -EBUSY; + if ( v->vcpu_info_area.pg ) + break; + + /* See the BUILD_BUG_ON() in vcpu_info_populate(). */ + rc = map_guest_area(v, gaddr, sizeof(vcpu_info_t), + &v->vcpu_info_area, vcpu_info_populate); + if ( rc == -ERESTART ) + rc = hypercall_create_continuation(__HYPERVISOR_vcpu_op, "iih", + cmd, vcpuid, arg); break; } --- a/xen/include/xen/domain.h +++ b/xen/include/xen/domain.h @@ -79,9 +79,6 @@ void cf_check free_pirq_struct(void *); int arch_vcpu_create(struct vcpu *v); void arch_vcpu_destroy(struct vcpu *v); -int map_vcpu_info(struct vcpu *v, unsigned long gfn, unsigned int offset); -void unmap_vcpu_info(struct vcpu *v); - int map_guest_area(struct vcpu *v, paddr_t gaddr, unsigned int size, struct guest_area *area, void (*populate)(void *dst, struct vcpu *v)); --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -175,7 +175,7 @@ struct vcpu int processor; - vcpu_info_t *vcpu_info; + struct guest_area vcpu_info_area; struct domain *domain; @@ -288,9 +288,6 @@ struct vcpu struct waitqueue_vcpu *waitqueue_vcpu; - /* Guest-specified relocation of vcpu_info. */ - mfn_t vcpu_info_mfn; - struct evtchn_fifo_vcpu *evtchn_fifo; /* vPCI per-vCPU area, used to store data for long running operations. */ --- a/xen/include/xen/shared.h +++ b/xen/include/xen/shared.h @@ -44,6 +44,7 @@ typedef struct vcpu_info vcpu_info_t; extern vcpu_info_t dummy_vcpu_info; #define shared_info(d, field) __shared_info(d, (d)->shared_info, field) -#define vcpu_info(v, field) __vcpu_info(v, (v)->vcpu_info, field) +#define vcpu_info(v, field) \ + __vcpu_info(v, (vcpu_info_t *)(v)->vcpu_info_area.map, field) #endif /* __XEN_SHARED_H__ */ From xen-devel-bounces@lists.xenproject.org Wed May 03 16:32:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 16:32:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529380.823729 (Exim 4.92) (envelope-from ) id 1puFOl-00047h-9j; Wed, 03 May 2023 16:32:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529380.823729; Wed, 03 May 2023 16:32:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puFOl-00046e-1Y; Wed, 03 May 2023 16:32:11 +0000 Received: by outflank-mailman (input) for mailman id 529380; Wed, 03 May 2023 16:32:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puFOj-0003pe-9y for xen-devel@lists.xenproject.org; Wed, 03 May 2023 16:32:09 +0000 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [2a00:1450:4864:20::12a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0b1c3d72-e9d0-11ed-8611-37d641c3527e; Wed, 03 May 2023 18:32:06 +0200 (CEST) Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-4f00c33c3d6so6788921e87.2 for ; Wed, 03 May 2023 09:32:06 -0700 (PDT) Received: from fedora.. ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id h20-20020a2e9ed4000000b002a634bfa224sm6074321ljk.40.2023.05.03.09.32.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 May 2023 09:32:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0b1c3d72-e9d0-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683131526; x=1685723526; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Na1AM2pS/tIxc8UzxXCz1qX+aY29hkPhhjEAhDGZruo=; b=YN4i0x2Yf/gqJP/4Wil8NwO76B5aVgrwNYJfDOi8HrmreBLvnv7H08aytbVqZ11YhL 4KekE+f6UrOsu3MY9X0MLjVCZYapuKXWZQmCGXGqq8oAdXx3NeEHZitnOUlLKf47hQIK vlcgKcr35nyhsh7XF1oHcpG/Q4bJJS3fAYMSY0cvU/HeMXSfq6cRBqE/bRG/69xs0Sr6 4icKCS2Oqd4uKktE5QoUTobPVOK4ETFx7dZIOhK1XQ8c7XZdnXz09wuhqf0jo67vsRsp NK2vVQRZ+tmQYCMI8Qneg6sD6J93ozqM+SGdnvl+wYsxK5GDUpBkMIECURDrm9kV4ydO tPxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683131526; x=1685723526; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Na1AM2pS/tIxc8UzxXCz1qX+aY29hkPhhjEAhDGZruo=; b=eII/XvRzZF/PXjkQ8ZFZoREfOlqHoiknav+w5Sz+PIpOGfLmLQWOQE7EXUR2XWtR5D aLjnTOtf7S6GUHp9rOYfl2xzCB8Y5aIwsoGMDWKZJz++4ozQ28tbHQugnFluD+HV5/Rx sfpU7IhZqV8uOe3HQCk4JmGlMzwnEYI+HbrozCES3w3LvRdRAluXM1Nc+ShDefJm1SUL zRC9/8Kyl3J0AwowVYT+C/sD13gKHfLDGWAXd+JlxwrRi8nXhcYdipY9pyKEM7quvudO qG2xjHzKb7IPn1Q5hErenOiaZj8RSEDIMGgCXzkoo+TByMfuF5Pk5wPlCu9zctWt44hb N7eQ== X-Gm-Message-State: AC+VfDysJH1CQn/S7VEFuRQRKd3yt7XIhzg/2gU27msm2wh/9+O/Kcd1 67Ke0iL1sgT9NjKlc8rmAAvVj/Fys2w= X-Google-Smtp-Source: ACHHUZ6yZKqCW5UQULMXODri/ZEA/RVcnsdSbX8Yx5MfUVYSJ4SkZhriZAecO1eFmtWzAYYMtP4P3g== X-Received: by 2002:ac2:42d4:0:b0:4ec:9fe9:fea9 with SMTP id n20-20020ac242d4000000b004ec9fe9fea9mr1289229lfl.56.1683131525895; Wed, 03 May 2023 09:32:05 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Julien Grall , Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v6 1/4] xen/riscv: add VM space layout Date: Wed, 3 May 2023 19:31:58 +0300 Message-Id: X-Mailer: git-send-email 2.40.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Also it was added explanation about ignoring of top VA bits Signed-off-by: Oleksii Kurochko --- Changes in V6: - update comment above the RISCV-64 layout table - add Slot column to the table with RISCV-64 Layout - update RV-64 layout table. --- Changes in V5: * the patch was introduced in the current patch series. --- xen/arch/riscv/include/asm/config.h | 31 +++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/xen/arch/riscv/include/asm/config.h b/xen/arch/riscv/include/asm/config.h index 763a922a04..73b86ce789 100644 --- a/xen/arch/riscv/include/asm/config.h +++ b/xen/arch/riscv/include/asm/config.h @@ -4,6 +4,37 @@ #include #include +/* + * RISC-V64 Layout: + * + * From the riscv-privileged doc: + * When mapping between narrower and wider addresses, + * RISC-V zero-extends a narrower physical address to a wider size. + * The mapping between 64-bit virtual addresses and the 39-bit usable + * address space of Sv39 is not based on zero-extension but instead + * follows an entrenched convention that allows an OS to use one or + * a few of the most-significant bits of a full-size (64-bit) virtual + * address to quickly distinguish user and supervisor address regions. + * + * It means that: + * top VA bits are simply ignored for the purpose of translating to PA. + * + * ============================================================================ + * Start addr | End addr | Size | Slot |area description + * ============================================================================ + * FFFFFFFFC0000000 | FFFFFFFFC0200000 | 2 MB | L2 511 | Xen + * FFFFFFFFC0200000 | FFFFFFFFC0600000 | 4 MB | L2 511 | FDT + * FFFFFFFFC0600000 | FFFFFFFFC0800000 | 2 MB | L2 511 | Fixmap + * ... | 1 GB | L2 510 | Unused + * 0000003200000000 | 0000007f40000000 | 331 GB | L2 200-609 | Direct map + * ... | 1 GB | L2 199 | Unused + * 0000003100000000 | 0000003140000000 | 3 GB | L2 196-198 | Frametable + * ... | 1 GB | L2 195 | Unused + * 0000003080000000 | 00000030c0000000 | 1 GB | L2 194 | VMAP + * .................. unused .................. + * ============================================================================ + */ + #if defined(CONFIG_RISCV_64) # define LONG_BYTEORDER 3 # define ELFSIZE 64 -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Wed May 03 16:32:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 16:32:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529378.823714 (Exim 4.92) (envelope-from ) id 1puFOj-0003q4-LX; Wed, 03 May 2023 16:32:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529378.823714; Wed, 03 May 2023 16:32:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puFOj-0003px-IK; Wed, 03 May 2023 16:32:09 +0000 Received: by outflank-mailman (input) for mailman id 529378; Wed, 03 May 2023 16:32:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puFOi-0003pe-LE for xen-devel@lists.xenproject.org; Wed, 03 May 2023 16:32:08 +0000 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [2a00:1450:4864:20::236]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0ac7d538-e9d0-11ed-8611-37d641c3527e; Wed, 03 May 2023 18:32:06 +0200 (CEST) Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2ac785015d6so5005641fa.0 for ; Wed, 03 May 2023 09:32:06 -0700 (PDT) Received: from fedora.. ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id h20-20020a2e9ed4000000b002a634bfa224sm6074321ljk.40.2023.05.03.09.32.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 May 2023 09:32:04 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0ac7d538-e9d0-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683131525; x=1685723525; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=TWeR2qcurw4IzjHMr6XJWFzGIGAQGUDuYVTUhmEWiwA=; b=UXJ6jF2MYR5jhjvd7sXNNq9wGZuk7Z/kA1pQbsm3a9PjKdqhRsWejMfJ9y7o2FPLmS IV7/smydWp6/vfnGWUGpbtMfQ0+w4mnc8KTmf1szhotCEswsrtKn9AEOavqJOhrC/tqE cHTZ0r0Uw0iRfE2TZMhrmTiwdlVHJCtSMsll4Are/9MiLGkqN1a73ytgX79wlJlQF4ke +sFl4rBzipRzHZokuwX4dGG5TubK/TurL0TtVDPUgK1SpkkmihfSFVW0N8farxL6SUKg vjAjo3TdnnnNZcOrx9pkSXC9ol08m5rxiXIEpoNf4gyncLtVX3/W3gzroJAD7I90U9s6 gbcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683131525; x=1685723525; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TWeR2qcurw4IzjHMr6XJWFzGIGAQGUDuYVTUhmEWiwA=; b=PsTE7EORsviiLB8B9g6iYzgpkz6+SDmzKx8U4VXsbT7T0ZXYZ8Ovopnn0MELdARG4E Y9jFb2PEShX+DQ6pxDvBbDeVRF+W07SIzk76RFIPJWj3svpZ44chPU1/S4PnuCanJXv9 LYGUWus9Z427h1C68YVwgxk5Pbh6LXR8kiwns1OMndf51WAzhYJ2ioXZtZ8/AShniMKp 7ZLQeiFawRh4kXpJYtgEsxUPjHElqSNuOgrtKLvZVgNcyoPMBHGHkpg/VJ0dHfxICVr6 OShLrjrMdMBZEBeaU9sd5w5IlTUq7IWoULMRtJ8IBTsP75oNKem24n6yj4lYEgQQn56O KpLA== X-Gm-Message-State: AC+VfDxT/pTfyssY7Em16mSqozvBct/zdgtdEfX0s04+Yl7QymRm1G01 kuy7fLUBgIKJhC3G/w5zOZe5XCiH/vw= X-Google-Smtp-Source: ACHHUZ7glxPCRwO7qFBhiTeHjIW6cp91jCb1h0bTuP4OpAw0eE7y3beNZGyL2fnKjsEQSFsif8ejkA== X-Received: by 2002:a05:651c:117:b0:2a6:1682:3a1e with SMTP id a23-20020a05651c011700b002a616823a1emr147641ljb.31.1683131525180; Wed, 03 May 2023 09:32:05 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Julien Grall , Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v6 0/4] enable MMU for RISC-V Date: Wed, 3 May 2023 19:31:57 +0300 Message-Id: X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch series introduces the following things: 1. Functionality to build the page tables for Xen that map link-time to physical-time location. 2. Check that Xen is less then page size. 3. Check that load addresses don't overlap with linker addresses. 4. Prepare things for proper switch to virtual memory world. 5. Load the built page table into the SATP 6. Enable MMU. --- Changes in V6: - update RV VM layout and related to it things - move PAGE_SHIFT, PADDR_BITS to the top of page-bits.h - cast argument x of pte_to_addr() macros to paddr_t to avoid risk of overflow for RV32 - update type of num_levels from 'unsigned long' to 'unsigned int' - define PGTBL_INITIAL_COUNT as ((CONFIG_PAGING_LEVELS - 1) + 1) - update type of permission arguments. changed it from 'unsgined long' to 'unsigned int' - fix code style - switch while 'loop' to 'for' loop - undef HANDLE_PGTBL - clean root page table after MMU is disabled in check_pgtbl_mode_support() function - align __bss_start properly - remove unnecesssary const for paddr_to_pte, pte_to_paddr, pte_is_valid functions - add switch_stack_and_jump macros and use it inside enable_mmu() before jump to cont_after_mmu_is_enabled() function --- Changes in V5: * rebase the patch series on top of current staging * Update cover letter: it was removed the info about the patches on which MMU patch series is based as they were merged to staging * add new patch with description of VM layout for RISC-V2 * Indent fields of pte_t struct * Rename addr_to_pte() and ppn_to_paddr() to match their content --- Changes in V4: * use GB() macros instead of defining SZ_1G * hardcode XEN_VIRT_START and add comment (ADDRESS_SPACE_END + 1 - GB(1)) * remove unnecessary 'asm' word at the end of #error * encapsulate pte_t definition in a struct * rename addr_to_ppn() to ppn_to_paddr(). * change type of paddr argument from const unsigned long to paddr_t * pte_to_paddr() update prototype. * calculate size of Xen binary based on an amount of page tables * use unsgined int instead of 'uint32_t' instead of uint32_t as their use isn't warranted. * remove extern of bss_{start,end} as they aren't used in mm.c anymore * fix code style * add argument for HANDLE_PGTBL macros instead of curr_lvl_num variable * make enable_mmu() as noinline to prevent under link-time optimization because of the nature of enable_mmu() * add function to check that SATP_MODE is supported. * update the commit message * update setup_initial_pagetables to set correct PTE flags in one pass instead of calling setup_pte_permissions after setup_initial_pagetables() as setup_initial_pagetables() isn't used to change permission flags. --- Changes in V3: * Update the cover letter message: the patch series isn't depend on [ RISC-V basic exception handling implementation ] as it was decied to enable MMU before implementation of exception handling. Also MMU patch series is based on two other patches which weren't merged [1] and [2] - Update the commit message for [ [PATCH v3 1/3] xen/riscv: introduce setup_initial_pages ]. - update definition of pte_t structure to have a proper size of pte_t in case of RV32. - update asm/mm.h with new functions and remove unnecessary 'extern'. - remove LEVEL_* macros as only XEN_PT_LEVEL_* are enough. - update paddr_to_pte() to receive permissions as an argument. - add check that map_start & pa_start is properly aligned. - move defines PAGETABLE_ORDER, PAGETABLE_ENTRIES, PTE_PPN_SHIFT to - Rename PTE_SHIFT to PTE_PPN_SHIFT - refactor setup_initial_pagetables: map all LINK addresses to LOAD addresses and after setup PTEs permission for sections; update check that linker and load addresses don't overlap. - refactor setup_initial_mapping: allocate pagetable 'dynamically' if it is necessary. - rewrite enable_mmu in C; add the check that map_start and pa_start are aligned on 4k boundary. - update the comment for setup_initial_pagetable funcion - Add RV_STAGE1_MODE to support different MMU modes. - update the commit message that MMU is also enabled here - set XEN_VIRT_START very high to not overlap with load address range - align bss section --- Changes in V2: * Remove {ZEROETH,FIRST,...}_{SHIFT,MASK, SIZE,...} and introduce instead of them XEN_PT_LEVEL_*() and LEVEL_* * Rework pt_linear_offset() and pt_index based on XEN_PT_LEVEL_*() * Remove clear_pagetables() functions as pagetables were zeroed during .bss initialization * Rename _setup_initial_pagetables() to setup_initial_mapping() * Make PTE_DEFAULT equal to RX. * Update prototype of setup_initial_mapping(..., bool writable) -> setup_initial_mapping(..., UL flags) * Update calls of setup_initial_mapping according to new prototype * Remove unnecessary call of: _setup_initial_pagetables(..., load_addr_start, load_addr_end, load_addr_start, ...) * Define index* in the loop of setup_initial_mapping * Remove attribute "__attribute__((section(".entry")))" for setup_initial_pagetables() as we don't have such section * make arguments of paddr_to_pte() and pte_is_valid() as const. * use instead of declaring extern unsigned long _stext, 0etext, _srodata, _erodata * update 'extern unsigned long __init_begin' to 'extern unsigned long __init_begin[]' * use aligned() instead of "__attribute__((__aligned__(PAGE_SIZE)))" * set __section(".bss.page_aligned") for page tables arrays * fix identatations * Change '__attribute__((section(".entry")))' to '__init' * Remove alignment of {map, pa}_start &= XEN_PT_LEVEL_MAP_MASK(0); in setup_inital_mapping() as they should be already aligned. * Remove clear_pagetables() as initial pagetables will be zeroed during bss initialization * Remove __attribute__((section(".entry")) for setup_initial_pagetables() as there is no such section in xen.lds.S * Update the argument of pte_is_valid() to "const pte_t *p" * Remove patch "[PATCH v1 3/3] automation: update RISC-V smoke test" from the patch series as it was introduced simplified approach for RISC-V smoke test by Andrew Cooper * Add patch [[xen/riscv: remove dummy_bss variable] as there is no any sense in dummy_bss variable after introduction of inittial page tables. --- Oleksii Kurochko (4): xen/riscv: add VM space layout xen/riscv: introduce setup_initial_pages xen/riscv: setup initial pagetables xen/riscv: remove dummy_bss variable xen/arch/riscv/Makefile | 1 + xen/arch/riscv/include/asm/config.h | 44 +++- xen/arch/riscv/include/asm/current.h | 10 + xen/arch/riscv/include/asm/mm.h | 9 + xen/arch/riscv/include/asm/page-bits.h | 10 + xen/arch/riscv/include/asm/page.h | 62 +++++ xen/arch/riscv/mm.c | 315 +++++++++++++++++++++++++ xen/arch/riscv/riscv64/head.S | 1 + xen/arch/riscv/setup.c | 22 +- xen/arch/riscv/xen.lds.S | 4 + 10 files changed, 469 insertions(+), 9 deletions(-) create mode 100644 xen/arch/riscv/include/asm/current.h create mode 100644 xen/arch/riscv/include/asm/mm.h create mode 100644 xen/arch/riscv/include/asm/page.h create mode 100644 xen/arch/riscv/mm.c -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Wed May 03 16:32:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 16:32:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529381.823735 (Exim 4.92) (envelope-from ) id 1puFOl-0004D8-J4; Wed, 03 May 2023 16:32:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529381.823735; Wed, 03 May 2023 16:32:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puFOl-0004Ay-BX; Wed, 03 May 2023 16:32:11 +0000 Received: by outflank-mailman (input) for mailman id 529381; Wed, 03 May 2023 16:32:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puFOj-0003pk-UX for xen-devel@lists.xenproject.org; Wed, 03 May 2023 16:32:09 +0000 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [2a00:1450:4864:20::22f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0c6e7a89-e9d0-11ed-b225-6b7b168915f2; Wed, 03 May 2023 18:32:08 +0200 (CEST) Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2ac79d4858dso1400431fa.2 for ; Wed, 03 May 2023 09:32:09 -0700 (PDT) Received: from fedora.. ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id h20-20020a2e9ed4000000b002a634bfa224sm6074321ljk.40.2023.05.03.09.32.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 May 2023 09:32:08 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0c6e7a89-e9d0-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683131529; x=1685723529; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sf2FBCUITLNv92K79Iv4iXww3Xtu3EP3+kJgTTV/WyQ=; b=Wwb8m+A/MBKxX8/aWnWoEAimCvThAmY/wZKelw/NuyBSqjIs8K3Lh/c9Sq/1t/ME/B ksePu5gs7LyHEmnqWN/5snSwFgID7DcOdjRzLgdyz6UeQ2TvdJq3H43a1PqnL468docT nIyX+mzpXdJRddfjR681v6+JpEBQU55RJmGrZdq8eWhr+7EytTMr2nkRF2an9QIDFhY/ 2hmGYZkQhzdVs8kMqWkfcGYopmM/kPsfP8H2SCeonQNHF/NcwTvMQLYvzD5OFOuQTX/W /3u4WkPKpUYJ7j0GoR1w93PxgQBL26pniiLXqZ5ZlNj6fXtAn8Qc7MkjTJNl4CnIuwhx NYxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683131529; x=1685723529; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sf2FBCUITLNv92K79Iv4iXww3Xtu3EP3+kJgTTV/WyQ=; b=itYgQfLeDAabNWq+STTHVqECHBZTPPusIWluzEq7TGW4478FN7Cp/Iui5ygvamzwUz JUAV66xWxSEX948KZk1GevSBgnhGzWI4xMzE2DaS/igSZXBJFae2SySdBfRDtfYf1n+p u1U4c+HRXJw6kukM/QewFONLXP9uONwT4eGZoO+uUbujyWcn+jLRXn25d5sQ5C6qndwp mi2ln2SezsltZD7ZZ9GKCbbStixHj+y0aBBtlJRY1F2mgOI4zM2rrUN0Z9j4Yqo45IxC 8GW+IddELgLi9StkoUKABfyXscAJc377tDztVnlcEzkPPYj1NatWf4vTf2fsg4SI411L 3kUQ== X-Gm-Message-State: AC+VfDxoM+imqHaFJOZOmag6SnuTtLl9gmWnpP4NIvC1PoOHA3oqFq5C 4nYv+Mx2UskN5h5v9qaDfnCOHnQpTKA= X-Google-Smtp-Source: ACHHUZ5ONYjmDZJcXbTYja7oYhZ9BtG1XHn25ZZdgX5rmJ5PlsbPBv4Yf2u9gk6gVigp38rrlLOaxA== X-Received: by 2002:a2e:2c13:0:b0:2a7:6812:ed9d with SMTP id s19-20020a2e2c13000000b002a76812ed9dmr149304ljs.50.1683131528551; Wed, 03 May 2023 09:32:08 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Julien Grall , Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v6 4/4] xen/riscv: remove dummy_bss variable Date: Wed, 3 May 2023 19:32:01 +0300 Message-Id: X-Mailer: git-send-email 2.40.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit After introduction of initial pagetables there is no any sense in dummy_bss variable as bss section will not be empty anymore. Signed-off-by: Oleksii Kurochko --- Changes in V6: - Nothing changed. Only rebase --- Changes in V5: - Nothing changed. Only rebase --- Changes in V4: - Nothing changed. Only rebase --- Changes in V3: * patch was introduced in the current one patch series (v3). --- Changes in V2: * patch was introduced in the current one patch series (v2). --- xen/arch/riscv/setup.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c index cf5dc5824e..845d18d86f 100644 --- a/xen/arch/riscv/setup.c +++ b/xen/arch/riscv/setup.c @@ -8,14 +8,6 @@ unsigned char __initdata cpu0_boot_stack[STACK_SIZE] __aligned(STACK_SIZE); -/* - * To be sure that .bss isn't zero. It will simplify code of - * .bss initialization. - * TODO: - * To be deleted when the first real .bss user appears - */ -int dummy_bss __attribute__((unused)); - void __init noreturn start_xen(unsigned long bootcpu_id, paddr_t dtb_addr) { -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Wed May 03 16:32:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 16:32:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529379.823724 (Exim 4.92) (envelope-from ) id 1puFOk-000450-T1; Wed, 03 May 2023 16:32:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529379.823724; Wed, 03 May 2023 16:32:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puFOk-00044t-Pn; Wed, 03 May 2023 16:32:10 +0000 Received: by outflank-mailman (input) for mailman id 529379; Wed, 03 May 2023 16:32:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puFOj-0003pk-8I for xen-devel@lists.xenproject.org; Wed, 03 May 2023 16:32:09 +0000 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [2a00:1450:4864:20::230]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0bc8b9ae-e9d0-11ed-b225-6b7b168915f2; Wed, 03 May 2023 18:32:08 +0200 (CEST) Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2a8dc00ade2so54559771fa.0 for ; Wed, 03 May 2023 09:32:08 -0700 (PDT) Received: from fedora.. ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id h20-20020a2e9ed4000000b002a634bfa224sm6074321ljk.40.2023.05.03.09.32.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 May 2023 09:32:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0bc8b9ae-e9d0-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683131528; x=1685723528; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bsfM97J5O+UpCSjMju/nOXYsGeOrD/W7nZOAovHNtiM=; b=W6+ogGuzG53c3UETfJpq0zks2Ni0FaBWiOO91I+UT4EJyiSF09+76TXD5JQmrocGMc DOUU6FJJ/GcfmvHwZunYG+5sVZ+CiwMOoxQAr6RIA7Gj24SF7kO103UHa+Ibwo3v1DsT +TA7Xxc9cjGjC2VbY4P/BCW0j19xEYdUU1kFe894TcyKutuVtv54B7rcH7q4PnkbMJnm 27HaPgJIPAkunfK1kYIhD389Wz4IkQk3VXhQY4hifb08eAu81ccS7ReTGlwqozKP6ote 7KiZeLYdJieEhZb8PrFyc9ooB6bt1PLmrFOYp5xILkPca3mtFC4H0hgwk9GuEv5zwV7F d+Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683131528; x=1685723528; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bsfM97J5O+UpCSjMju/nOXYsGeOrD/W7nZOAovHNtiM=; b=ABQJ+WzFjLj61bJS+cD5ixJeI4/n5FKDrsTzo31eZmKbTMo7D38ZmvLcRnhycFuMnk +X7kuwTYBxAyz2pvYkYVVseFFa4HO4s6jWSlwx3fEjqrPeppwoH3l8a4xjwlCzM1tOzs P76Bpjuyzde2sdk7LIOxtRxowSSGZtvAa9grBGU6ARMkIo2dken3vS83rUa26ZvcblHw r6fmhEaAAH2OF46r6CLTF2sC+FjDFYQ6f9s5Z/ibdbLqyEGOF4ZU+NVjueHSZMChFunA 0/Z2bAd7BziBAwdBID4koKSiLnZ3tf0jJoVd53+9czyDUfBBwVzogGdV4nlgfMifTJAC KoEw== X-Gm-Message-State: AC+VfDwRb42PK1FDMSeAuu9YrJotZBzGCfBArE8ZxZIuS5NbLZIzXdnL /F9PPE/wV3xz3Ea5kKrT5+w4qPr8F9c= X-Google-Smtp-Source: ACHHUZ503Xhj72fABoOXv+XvN3atFesd1TP1pzqMQS1XFTYQF0u1guxYyIZ7sV0gX6RP58M84Vi1ig== X-Received: by 2002:a2e:920c:0:b0:2a1:ab4a:153d with SMTP id k12-20020a2e920c000000b002a1ab4a153dmr152012ljg.29.1683131527692; Wed, 03 May 2023 09:32:07 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Julien Grall , Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v6 3/4] xen/riscv: setup initial pagetables Date: Wed, 3 May 2023 19:32:00 +0300 Message-Id: <4880494180634e53332dcfde24cc03ed1fea1a86.1683131359.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch does two thing: 1. Setup initial pagetables. 2. Enable MMU which end up with code in cont_after_mmu_is_enabled() Signed-off-by: Oleksii Kurochko --- Changes in V6: - Nothing changed. Only rebase --- Changes in V5: - Nothing changed. Only rebase --- Changes in V4: - Nothing changed. Only rebase --- Changes in V3: - update the commit message that MMU is also enabled here - remove early_printk("All set up\n") as it was moved to cont_after_mmu_is_enabled() function after MMU is enabled. --- Changes in V2: * Update the commit message --- xen/arch/riscv/setup.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c index 315804aa87..cf5dc5824e 100644 --- a/xen/arch/riscv/setup.c +++ b/xen/arch/riscv/setup.c @@ -21,7 +21,10 @@ void __init noreturn start_xen(unsigned long bootcpu_id, { early_printk("Hello from C env\n"); - early_printk("All set up\n"); + setup_initial_pagetables(); + + enable_mmu(); + for ( ;; ) asm volatile ("wfi"); -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Wed May 03 16:32:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 16:32:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529382.823741 (Exim 4.92) (envelope-from ) id 1puFOl-0004HL-SJ; Wed, 03 May 2023 16:32:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529382.823741; Wed, 03 May 2023 16:32:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puFOl-0004FD-Jt; Wed, 03 May 2023 16:32:11 +0000 Received: by outflank-mailman (input) for mailman id 529382; Wed, 03 May 2023 16:32:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puFOk-0003pe-9z for xen-devel@lists.xenproject.org; Wed, 03 May 2023 16:32:10 +0000 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [2a00:1450:4864:20::135]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0bc3b58e-e9d0-11ed-8611-37d641c3527e; Wed, 03 May 2023 18:32:07 +0200 (CEST) Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-4f137dbaa4fso1235194e87.2 for ; Wed, 03 May 2023 09:32:08 -0700 (PDT) Received: from fedora.. ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id h20-20020a2e9ed4000000b002a634bfa224sm6074321ljk.40.2023.05.03.09.32.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 May 2023 09:32:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0bc3b58e-e9d0-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683131527; x=1685723527; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ax1p/+Ojg24s3uOBpiRJ9X07/nApnSHzGweJ6WFH648=; b=DCHKe6PsTaBnm7AOWO6SRyvaqhHS6WvbwA2mELkNLgWfyvqCpkZlqeWtqEASKyiyH6 VAMP1WaeJ8ufcdRyFQsXsA2H7cE8QsKx2HgJEmsBM4QoYFqtW2AIDczM/34w5vD5T/MP 0AlI5uqCr2Y1zxyx2uzhBAL9o/dHj92b55MEwpOV17NTUGB4RxV/d/9GfP3vsyrPkSqP GloF2oLTL7OHc/ZeumNo6nIU1p27+MJ9DuUiWlCbuRiMCGRag2MjuTRP4F7pyMI0i3ls 0srcojwQjdaghB9HPFtOu4CG4MVxgur8hW2QAD2pSKwVnqRkItABCY8wHJJSXOv+psi1 vsZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683131527; x=1685723527; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ax1p/+Ojg24s3uOBpiRJ9X07/nApnSHzGweJ6WFH648=; b=Uy7j80v4EX0i3RUXA2GSRvYor1lLMUlxcF2RwPrBbIl4eo2LvO7L6qDSBTAfobL2gi mzXzsvrDGFQF7Ac8FnzgikpXCeg7skdMdi4KUeOYso/nF3QJnL3MgosQziUXeK2jkTZ+ ZHWL9qZMsFqNdEW7QmivGceE2iVl5Um9Tg+tniYbAZ/qzYhdHp2SN/zmWN7t/Vj7QEk7 kSkYTLWR7hXu6oxm+c8o7/o4FqL478Ftwi0zjun7ExkTIzO50cxvU3JFYTQYC5KDHTD/ 0aqj1oM5uFB/lVd8Ss+CQk78jTf0HMQZfwEctln8ViOzGAOYKFSj6FQurOTVyNb50j7Y pEUQ== X-Gm-Message-State: AC+VfDwS8lHypIUPLKDReK0K3jhoIoW8X+/1DWLGfCFaDPApliJnoH18 g6FppJ9khuNmVtu3Ocx41sH5Tu0DCG0= X-Google-Smtp-Source: ACHHUZ5gv8pRr8ymywPtNmbKQcjo67kL49ke7vlfhtiGZnZDzEeBZjtmAa6XvbL/ag9h3FJA/2scXA== X-Received: by 2002:ac2:4a66:0:b0:4eb:e7f:945 with SMTP id q6-20020ac24a66000000b004eb0e7f0945mr1000813lfp.41.1683131526959; Wed, 03 May 2023 09:32:06 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Julien Grall , Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v6 2/4] xen/riscv: introduce setup_initial_pages Date: Wed, 3 May 2023 19:31:59 +0300 Message-Id: X-Mailer: git-send-email 2.40.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The idea was taken from xvisor but the following changes were done: * Use only a minimal part of the code enough to enable MMU * rename {_}setup_initial_pagetables functions * add an argument for setup_initial_mapping to have an opportunity to make set PTE flags. * update setup_initial_pagetables function to map sections with correct PTE flags. * Rewrite enable_mmu() to C. * map linker addresses range to load addresses range without 1:1 mapping. It will be 1:1 only in case when load_start_addr is equal to linker_start_addr. * add safety checks such as: * Xen size is less than page size * linker addresses range doesn't overlap load addresses range * Rework macros {THIRD,SECOND,FIRST,ZEROETH}_{SHIFT,MASK} * change PTE_LEAF_DEFAULT to RW instead of RWX. * Remove phys_offset as it is not used now * Remove alignment of {map, pa}_start &= XEN_PT_LEVEL_MAP_MASK(0); in setup_inital_mapping() as they should be already aligned. Make a check that {map_pa}_start are aligned. * Remove clear_pagetables() as initial pagetables will be zeroed during bss initialization * Remove __attribute__((section(".entry")) for setup_initial_pagetables() as there is no such section in xen.lds.S * Update the argument of pte_is_valid() to "const pte_t *p" * Add check that Xen's load address is aligned at 4k boundary * Refactor setup_initial_pagetables() so it is mapping linker address range to load address range. After setup needed permissions for specific section ( such as .text, .rodata, etc ) otherwise RW permission will be set by default. * Add function to check that requested SATP_MODE is supported Origin: git@github.com:xvisor/xvisor.git 9be2fdd7 Signed-off-by: Oleksii Kurochko --- Changes in V6: - move PAGE_SHIFT, PADDR_BITS to the top of page-bits.h - cast argument x of pte_to_addr() macros to paddr_t to avoid risk of overflow for RV32 - update type of num_levels from 'unsigned long' to 'unsigned int' - define PGTBL_INITIAL_COUNT as ((CONFIG_PAGING_LEVELS - 1) + 1) - update type of permission arguments. changed it from 'unsgined long' to 'unsigned int' - fix code style - switch while 'loop' to 'for' loop - undef HANDLE_PGTBL - clean root page table after MMU is disabled in check_pgtbl_mode_support() function - align __bss_start properly - remove unnecesssary const for paddr_to_pte, pte_to_paddr, pte_is_valid functions - add switch_stack_and_jump macros and use it inside enable_mmu() before jump to cont_after_mmu_is_enabled() function --- Changes in V5: * Indent fields of pte_t struct * Rename addr_to_pte() and ppn_to_paddr() to match their content --- Changes in V4: * use GB() macros instead of defining SZ_1G * hardcode XEN_VIRT_START and add comment (ADDRESS_SPACE_END + 1 - GB(1)) * remove unnecessary 'asm' word at the end of #error * encapsulate pte_t definition in a struct * rename addr_to_ppn() to ppn_to_paddr(). * change type of paddr argument from const unsigned long to paddr_t * pte_to_paddr() update prototype. * calculate size of Xen binary based on an amount of page tables * use unsgined int instead of 'uint32_t' instead of uint32_t as their use isn't warranted. * remove extern of bss_{start,end} as they aren't used in mm.c anymore * fix code style * add argument for HANDLE_PGTBL macros instead of curr_lvl_num variable * make enable_mmu() as noinline to prevent under link-time optimization because of the nature of enable_mmu() * add function to check that SATP_MODE is supported. * update the commit message * update setup_initial_pagetables to set correct PTE flags in one pass instead of calling setup_pte_permissions after setup_initial_pagetables() as setup_initial_pagetables() isn't used to change permission flags. --- Changes in V3: - update definition of pte_t structure to have a proper size of pte_t in case of RV32. - update asm/mm.h with new functions and remove unnecessary 'extern'. - remove LEVEL_* macros as only XEN_PT_LEVEL_* are enough. - update paddr_to_pte() to receive permissions as an argument. - add check that map_start & pa_start is properly aligned. - move defines PAGETABLE_ORDER, PAGETABLE_ENTRIES, PTE_PPN_SHIFT to - Rename PTE_SHIFT to PTE_PPN_SHIFT - refactor setup_initial_pagetables: map all LINK addresses to LOAD addresses and after setup PTEs permission for sections; update check that linker and load addresses don't overlap. - refactor setup_initial_mapping: allocate pagetable 'dynamically' if it is necessary. - rewrite enable_mmu in C; add the check that map_start and pa_start are aligned on 4k boundary. - update the comment for setup_initial_pagetable funcion - Add RV_STAGE1_MODE to support different MMU modes - set XEN_VIRT_START very high to not overlap with load address range - align bss section --- Changes in V2: * update the commit message: * Remove {ZEROETH,FIRST,...}_{SHIFT,MASK, SIZE,...} and introduce instead of them XEN_PT_LEVEL_*() and LEVEL_* * Rework pt_linear_offset() and pt_index based on XEN_PT_LEVEL_*() * Remove clear_pagetables() functions as pagetables were zeroed during .bss initialization * Rename _setup_initial_pagetables() to setup_initial_mapping() * Make PTE_DEFAULT equal to RX. * Update prototype of setup_initial_mapping(..., bool writable) -> setup_initial_mapping(..., UL flags) * Update calls of setup_initial_mapping according to new prototype * Remove unnecessary call of: _setup_initial_pagetables(..., load_addr_start, load_addr_end, load_addr_start, ...) * Define index* in the loop of setup_initial_mapping * Remove attribute "__attribute__((section(".entry")))" for setup_initial_pagetables() as we don't have such section * make arguments of paddr_to_pte() and pte_is_valid() as const. * make xen_second_pagetable static. * use instead of declaring extern unsigned long _stext, 0etext, _srodata, _erodata * update 'extern unsigned long __init_begin' to 'extern unsigned long __init_begin[]' * use aligned() instead of "__attribute__((__aligned__(PAGE_SIZE)))" * set __section(".bss.page_aligned") for page tables arrays * fix identatations * Change '__attribute__((section(".entry")))' to '__init' * Remove phys_offset as it isn't used now. * Remove alignment of {map, pa}_start &= XEN_PT_LEVEL_MAP_MASK(0); in setup_inital_mapping() as they should be already aligned. * Remove clear_pagetables() as initial pagetables will be zeroed during bss initialization * Remove __attribute__((section(".entry")) for setup_initial_pagetables() as there is no such section in xen.lds.S * Update the argument of pte_is_valid() to "const pte_t *p" --- xen/arch/riscv/Makefile | 1 + xen/arch/riscv/include/asm/config.h | 13 +- xen/arch/riscv/include/asm/current.h | 10 + xen/arch/riscv/include/asm/mm.h | 9 + xen/arch/riscv/include/asm/page-bits.h | 10 + xen/arch/riscv/include/asm/page.h | 62 +++++ xen/arch/riscv/mm.c | 315 +++++++++++++++++++++++++ xen/arch/riscv/riscv64/head.S | 1 + xen/arch/riscv/setup.c | 11 + xen/arch/riscv/xen.lds.S | 4 + 10 files changed, 435 insertions(+), 1 deletion(-) create mode 100644 xen/arch/riscv/include/asm/current.h create mode 100644 xen/arch/riscv/include/asm/mm.h create mode 100644 xen/arch/riscv/include/asm/page.h create mode 100644 xen/arch/riscv/mm.c diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile index 443f6bf15f..956ceb02df 100644 --- a/xen/arch/riscv/Makefile +++ b/xen/arch/riscv/Makefile @@ -1,5 +1,6 @@ obj-$(CONFIG_EARLY_PRINTK) += early_printk.o obj-y += entry.o +obj-y += mm.o obj-$(CONFIG_RISCV_64) += riscv64/ obj-y += sbi.o obj-y += setup.o diff --git a/xen/arch/riscv/include/asm/config.h b/xen/arch/riscv/include/asm/config.h index 73b86ce789..3bd206766e 100644 --- a/xen/arch/riscv/include/asm/config.h +++ b/xen/arch/riscv/include/asm/config.h @@ -70,12 +70,23 @@ name: #endif -#define XEN_VIRT_START _AT(UL, 0x80200000) +#ifdef CONFIG_RISCV_64 +#define XEN_VIRT_START 0xFFFFFFFFC0000000 /* (_AC(-1, UL) + 1 - GB(1)) */ +#else +#error "RV32 isn't supported" +#endif #define SMP_CACHE_BYTES (1 << 6) #define STACK_SIZE PAGE_SIZE +#ifdef CONFIG_RISCV_64 +#define CONFIG_PAGING_LEVELS 3 +#define RV_STAGE1_MODE SATP_MODE_SV39 +#else +#define RV_STAGE1_MODE SATP_MODE_SV32 +#endif + #endif /* __RISCV_CONFIG_H__ */ /* * Local variables: diff --git a/xen/arch/riscv/include/asm/current.h b/xen/arch/riscv/include/asm/current.h new file mode 100644 index 0000000000..1cb5946fe9 --- /dev/null +++ b/xen/arch/riscv/include/asm/current.h @@ -0,0 +1,10 @@ +#ifndef __ASM_CURRENT_H +#define __ASM_CURRENT_H + +#define switch_stack_and_jump(stack, fn) \ + asm volatile ( \ + "mv sp, %0 \n" \ + "j " #fn :: "r" (stack) : \ + ) + +#endif /* __ASM_CURRENT_H */ diff --git a/xen/arch/riscv/include/asm/mm.h b/xen/arch/riscv/include/asm/mm.h new file mode 100644 index 0000000000..e16ce66fae --- /dev/null +++ b/xen/arch/riscv/include/asm/mm.h @@ -0,0 +1,9 @@ +#ifndef _ASM_RISCV_MM_H +#define _ASM_RISCV_MM_H + +void setup_initial_pagetables(void); + +void enable_mmu(void); +void cont_after_mmu_is_enabled(void); + +#endif /* _ASM_RISCV_MM_H */ diff --git a/xen/arch/riscv/include/asm/page-bits.h b/xen/arch/riscv/include/asm/page-bits.h index 1801820294..4a3e33589a 100644 --- a/xen/arch/riscv/include/asm/page-bits.h +++ b/xen/arch/riscv/include/asm/page-bits.h @@ -4,4 +4,14 @@ #define PAGE_SHIFT 12 /* 4 KiB Pages */ #define PADDR_BITS 56 /* 44-bit PPN */ +#ifdef CONFIG_RISCV_64 +#define PAGETABLE_ORDER (9) +#else /* CONFIG_RISCV_32 */ +#define PAGETABLE_ORDER (10) +#endif + +#define PAGETABLE_ENTRIES (1 << PAGETABLE_ORDER) + +#define PTE_PPN_SHIFT 10 + #endif /* __RISCV_PAGE_BITS_H__ */ diff --git a/xen/arch/riscv/include/asm/page.h b/xen/arch/riscv/include/asm/page.h new file mode 100644 index 0000000000..b4fc67484b --- /dev/null +++ b/xen/arch/riscv/include/asm/page.h @@ -0,0 +1,62 @@ +#ifndef _ASM_RISCV_PAGE_H +#define _ASM_RISCV_PAGE_H + +#include +#include + +#define VPN_MASK ((unsigned long)(PAGETABLE_ENTRIES - 1)) + +#define XEN_PT_LEVEL_ORDER(lvl) ((lvl) * PAGETABLE_ORDER) +#define XEN_PT_LEVEL_SHIFT(lvl) (XEN_PT_LEVEL_ORDER(lvl) + PAGE_SHIFT) +#define XEN_PT_LEVEL_SIZE(lvl) (_AT(paddr_t, 1) << XEN_PT_LEVEL_SHIFT(lvl)) +#define XEN_PT_LEVEL_MAP_MASK(lvl) (~(XEN_PT_LEVEL_SIZE(lvl) - 1)) +#define XEN_PT_LEVEL_MASK(lvl) (VPN_MASK << XEN_PT_LEVEL_SHIFT(lvl)) + +#define PTE_VALID BIT(0, UL) +#define PTE_READABLE BIT(1, UL) +#define PTE_WRITABLE BIT(2, UL) +#define PTE_EXECUTABLE BIT(3, UL) +#define PTE_USER BIT(4, UL) +#define PTE_GLOBAL BIT(5, UL) +#define PTE_ACCESSED BIT(6, UL) +#define PTE_DIRTY BIT(7, UL) +#define PTE_RSW (BIT(8, UL) | BIT(9, UL)) + +#define PTE_LEAF_DEFAULT (PTE_VALID | PTE_READABLE | PTE_WRITABLE) +#define PTE_TABLE (PTE_VALID) + +/* Calculate the offsets into the pagetables for a given VA */ +#define pt_linear_offset(lvl, va) ((va) >> XEN_PT_LEVEL_SHIFT(lvl)) + +#define pt_index(lvl, va) pt_linear_offset(lvl, (va) & XEN_PT_LEVEL_MASK(lvl)) + +/* Page Table entry */ +typedef struct { +#ifdef CONFIG_RISCV_64 + uint64_t pte; +#else + uint32_t pte; +#endif +} pte_t; + +#define pte_to_addr(x) (((paddr_t)(x) >> PTE_PPN_SHIFT) << PAGE_SHIFT) + +#define addr_to_pte(x) (((x) >> PAGE_SHIFT) << PTE_PPN_SHIFT) + +static inline pte_t paddr_to_pte(paddr_t paddr, + unsigned int permissions) +{ + return (pte_t) { .pte = addr_to_pte(paddr) | permissions }; +} + +static inline paddr_t pte_to_paddr(pte_t pte) +{ + return pte_to_addr(pte.pte); +} + +static inline bool pte_is_valid(pte_t p) +{ + return p.pte & PTE_VALID; +} + +#endif /* _ASM_RISCV_PAGE_H */ diff --git a/xen/arch/riscv/mm.c b/xen/arch/riscv/mm.c new file mode 100644 index 0000000000..b13f15f75f --- /dev/null +++ b/xen/arch/riscv/mm.c @@ -0,0 +1,315 @@ +#include +#include +#include +#include + +#include +#include +#include +#include +#include +#include +#include + +struct mmu_desc { + unsigned int num_levels; + unsigned int pgtbl_count; + pte_t *next_pgtbl; + pte_t *pgtbl_base; +}; + +extern unsigned char cpu0_boot_stack[STACK_SIZE]; + +#define PHYS_OFFSET ((unsigned long)_start - XEN_VIRT_START) +#define LOAD_TO_LINK(addr) ((addr) - PHYS_OFFSET) +#define LINK_TO_LOAD(addr) ((addr) + PHYS_OFFSET) + + +/* + * It is expected that Xen won't be more then 2 MB. + * The check in xen.lds.S guarantees that. + * At least 3 page (in case of Sv39 ) + * tables are needed to cover 2 MB. One for each page level + * table with PAGE_SIZE = 4 Kb + * + * One L0 page table can cover 2 MB + * (512 entries of one page table * PAGE_SIZE). + * + */ +#define PGTBL_INITIAL_COUNT ((CONFIG_PAGING_LEVELS - 1) + 1) + +#define PGTBL_ENTRY_AMOUNT (PAGE_SIZE / sizeof(pte_t)) + +pte_t __section(".bss.page_aligned") __aligned(PAGE_SIZE) +stage1_pgtbl_root[PGTBL_ENTRY_AMOUNT]; + +pte_t __section(".bss.page_aligned") __aligned(PAGE_SIZE) +stage1_pgtbl_nonroot[PGTBL_INITIAL_COUNT * PGTBL_ENTRY_AMOUNT]; + +#define HANDLE_PGTBL(curr_lvl_num) \ + index = pt_index(curr_lvl_num, page_addr); \ + if ( pte_is_valid(pgtbl[index]) ) \ + { \ + /* Find L{ 0-3 } table */ \ + pgtbl = (pte_t *)pte_to_paddr(pgtbl[index]); \ + } \ + else \ + { \ + /* Allocate new L{0-3} page table */ \ + if ( mmu_desc->pgtbl_count == PGTBL_INITIAL_COUNT ) \ + { \ + early_printk("(XEN) No initial table available\n"); \ + /* panic(), BUG() or ASSERT() aren't ready now. */ \ + die(); \ + } \ + mmu_desc->pgtbl_count++; \ + pgtbl[index] = paddr_to_pte((unsigned long)mmu_desc->next_pgtbl, \ + PTE_VALID); \ + pgtbl = mmu_desc->next_pgtbl; \ + mmu_desc->next_pgtbl += PGTBL_ENTRY_AMOUNT; \ + } + +static void __init setup_initial_mapping(struct mmu_desc *mmu_desc, + unsigned long map_start, + unsigned long map_end, + unsigned long pa_start, + unsigned int permissions) +{ + unsigned int index; + pte_t *pgtbl; + unsigned long page_addr; + pte_t pte_to_be_written; + unsigned long paddr; + unsigned int tmp_permissions; + + if ( (unsigned long)_start % XEN_PT_LEVEL_SIZE(0) ) + { + early_printk("(XEN) Xen should be loaded at 4k boundary\n"); + die(); + } + + if ( map_start & ~XEN_PT_LEVEL_MAP_MASK(0) || + pa_start & ~XEN_PT_LEVEL_MAP_MASK(0) ) + { + early_printk("(XEN) map and pa start addresses should be aligned\n"); + /* panic(), BUG() or ASSERT() aren't ready now. */ + die(); + } + + for ( page_addr = map_start; page_addr < map_end; page_addr += XEN_PT_LEVEL_SIZE(0) ) + { + pgtbl = mmu_desc->pgtbl_base; + + switch ( mmu_desc->num_levels ) + { + case 4: /* Level 3 */ + HANDLE_PGTBL(3); + case 3: /* Level 2 */ + HANDLE_PGTBL(2); + case 2: /* Level 1 */ + HANDLE_PGTBL(1); + case 1: /* Level 0 */ + index = pt_index(0, page_addr); + paddr = (page_addr - map_start) + pa_start; + + tmp_permissions = permissions; + + if ( is_kernel_text(LINK_TO_LOAD(page_addr)) || + is_kernel_inittext(LINK_TO_LOAD(page_addr)) ) + tmp_permissions = + PTE_EXECUTABLE | PTE_READABLE | PTE_VALID; + + if ( is_kernel_rodata(LINK_TO_LOAD(page_addr)) ) + tmp_permissions = PTE_READABLE | PTE_VALID; + + pte_to_be_written = paddr_to_pte(paddr, tmp_permissions); + + if ( !pte_is_valid(pgtbl[index]) ) + pgtbl[index] = pte_to_be_written; + else + { + /* + * get an adresses of current pte and that one to + * be written + */ + unsigned long curr_pte = + pgtbl[index].pte & ~(PTE_DIRTY | PTE_ACCESSED); + + pte_to_be_written.pte &= ~(PTE_DIRTY | PTE_ACCESSED); + + if ( curr_pte != pte_to_be_written.pte ) + { + early_printk("PTE overridden has occurred\n"); + /* panic(), aren't ready now. */ + die(); + } + } + } + } + #undef HANDLE_PGTBL +} + +static void __init calc_pgtbl_lvls_num(struct mmu_desc *mmu_desc) +{ + unsigned long satp_mode = RV_STAGE1_MODE; + + /* Number of page table levels */ + switch (satp_mode) + { + case SATP_MODE_SV32: + mmu_desc->num_levels = 2; + break; + case SATP_MODE_SV39: + mmu_desc->num_levels = 3; + break; + case SATP_MODE_SV48: + mmu_desc->num_levels = 4; + break; + default: + early_printk("(XEN) Unsupported SATP_MODE\n"); + die(); + } +} + +static bool __init check_pgtbl_mode_support(struct mmu_desc *mmu_desc, + unsigned long load_start, + unsigned long satp_mode) +{ + bool is_mode_supported = false; + unsigned int index; + unsigned int page_table_level = (mmu_desc->num_levels - 1); + unsigned level_map_mask = XEN_PT_LEVEL_MAP_MASK(page_table_level); + + unsigned long aligned_load_start = load_start & level_map_mask; + unsigned long aligned_page_size = XEN_PT_LEVEL_SIZE(page_table_level); + unsigned long xen_size = (unsigned long)(_end - start); + + if ( (load_start + xen_size) > (aligned_load_start + aligned_page_size) ) + { + early_printk("please place Xen to be in range of PAGE_SIZE " + "where PAGE_SIZE is XEN_PT_LEVEL_SIZE( {L3 | L2 | L1} ) " + "depending on expected SATP_MODE \n" + "XEN_PT_LEVEL_SIZE is defined in \n"); + die(); + } + + index = pt_index(page_table_level, aligned_load_start); + stage1_pgtbl_root[index] = paddr_to_pte(aligned_load_start, + PTE_LEAF_DEFAULT | PTE_EXECUTABLE); + + asm volatile ( "sfence.vma" ); + csr_write(CSR_SATP, + PFN_DOWN((unsigned long)stage1_pgtbl_root) | + satp_mode << SATP_MODE_SHIFT); + + if ( (csr_read(CSR_SATP) >> SATP_MODE_SHIFT) == satp_mode ) + is_mode_supported = true; + + csr_write(CSR_SATP, 0); + + /* Clean MMU root page table */ + stage1_pgtbl_root[index] = paddr_to_pte(0x0, 0x0); + + asm volatile ( "sfence.vma" ); + + return is_mode_supported; +} + +/* + * setup_initial_pagetables: + * + * Build the page tables for Xen that map the following: + * 1. Calculate page table's level numbers. + * 2. Init mmu description structure. + * 3. Check that linker addresses range doesn't overlap + * with load addresses range + * 4. Map all linker addresses and load addresses ( it shouldn't + * be 1:1 mapped and will be 1:1 mapped only in case if + * linker address is equal to load address ) with + * RW permissions by default. + * 5. Setup proper PTE permissions for each section. + */ +void __init setup_initial_pagetables(void) +{ + struct mmu_desc mmu_desc = { 0, 0, NULL, NULL }; + + /* + * Access to _stard, _end is always PC-relative + * thereby when access them we will get load adresses + * of start and end of Xen + * To get linker addresses LOAD_TO_LINK() is required + * to use + */ + unsigned long load_start = (unsigned long)_start; + unsigned long load_end = (unsigned long)_end; + unsigned long linker_start = LOAD_TO_LINK(load_start); + unsigned long linker_end = LOAD_TO_LINK(load_end); + + if ( (linker_start != load_start) && + (linker_start <= load_end) && (load_start <= linker_end) ) + { + early_printk("(XEN) linker and load address ranges overlap\n"); + die(); + } + + calc_pgtbl_lvls_num(&mmu_desc); + + if ( !check_pgtbl_mode_support(&mmu_desc, load_start, RV_STAGE1_MODE) ) + { + early_printk("requested MMU mode isn't supported by CPU\n" + "Please choose different in \n"); + die(); + } + + mmu_desc.pgtbl_base = stage1_pgtbl_root; + mmu_desc.next_pgtbl = stage1_pgtbl_nonroot; + + setup_initial_mapping(&mmu_desc, + linker_start, + linker_end, + load_start, + PTE_LEAF_DEFAULT); +} + +void __init noinline enable_mmu() +{ + /* + * Calculate a linker time address of the mmu_is_enabled + * label and update CSR_STVEC with it. + * MMU is configured in a way where linker addresses are mapped + * on load addresses so in a case when linker addresses are not equal + * to load addresses, after MMU is enabled, it will cause + * an exception and jump to linker time addresses. + * Otherwise if load addresses are equal to linker addresses the code + * after mmu_is_enabled label will be executed without exception. + */ + csr_write(CSR_STVEC, LOAD_TO_LINK((unsigned long)&&mmu_is_enabled)); + + /* Ensure page table writes precede loading the SATP */ + asm volatile ( "sfence.vma" ); + + /* Enable the MMU and load the new pagetable for Xen */ + csr_write(CSR_SATP, + PFN_DOWN((unsigned long)stage1_pgtbl_root) | + RV_STAGE1_MODE << SATP_MODE_SHIFT); + + asm volatile ( ".align 2" ); + mmu_is_enabled: + /* + * Stack should be re-inited as: + * 1. Right now an address of the stack is relative to load time + * addresses what will cause an issue in case of load start address + * isn't equal to linker start address. + * 2. Addresses in stack are all load time relative which can be an + * issue in case when load start address isn't equal to linker + * start address. + * + * We can't return to the caller because the stack was reseted + * and it may have stash some variable on the stack. + * Jump to a brand new function as the stack was reseted + */ + + switch_stack_and_jump((unsigned long)cpu0_boot_stack + STACK_SIZE, + cont_after_mmu_is_enabled); +} + diff --git a/xen/arch/riscv/riscv64/head.S b/xen/arch/riscv/riscv64/head.S index 8887f0cbd4..983757e498 100644 --- a/xen/arch/riscv/riscv64/head.S +++ b/xen/arch/riscv/riscv64/head.S @@ -1,4 +1,5 @@ #include +#include #include .section .text.header, "ax", %progbits diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c index 3786f337e0..315804aa87 100644 --- a/xen/arch/riscv/setup.c +++ b/xen/arch/riscv/setup.c @@ -2,6 +2,7 @@ #include #include +#include /* Xen stack for bringing up the first CPU. */ unsigned char __initdata cpu0_boot_stack[STACK_SIZE] @@ -26,3 +27,13 @@ void __init noreturn start_xen(unsigned long bootcpu_id, unreachable(); } + +void __init noreturn cont_after_mmu_is_enabled(void) +{ + early_printk("All set up\n"); + + for ( ;; ) + asm volatile ("wfi"); + + unreachable(); +} diff --git a/xen/arch/riscv/xen.lds.S b/xen/arch/riscv/xen.lds.S index 31e0d3576c..f9d89b69b9 100644 --- a/xen/arch/riscv/xen.lds.S +++ b/xen/arch/riscv/xen.lds.S @@ -137,6 +137,7 @@ SECTIONS __init_end = .; .bss : { /* BSS */ + . = ALIGN(POINTER_ALIGN); __bss_start = .; *(.bss.stack_aligned) . = ALIGN(PAGE_SIZE); @@ -172,3 +173,6 @@ ASSERT(IS_ALIGNED(__bss_end, POINTER_ALIGN), "__bss_end is misaligned") ASSERT(!SIZEOF(.got), ".got non-empty") ASSERT(!SIZEOF(.got.plt), ".got.plt non-empty") + +ASSERT(_end - _start <= MB(2), "Xen too large for early-boot assumptions") + -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Wed May 03 16:36:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 16:36:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529394.823764 (Exim 4.92) (envelope-from ) id 1puFTD-0006h6-Fj; Wed, 03 May 2023 16:36:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529394.823764; Wed, 03 May 2023 16:36:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puFTD-0006gz-Co; Wed, 03 May 2023 16:36:47 +0000 Received: by outflank-mailman (input) for mailman id 529394; Wed, 03 May 2023 16:36:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puFTC-0006gt-B6 for xen-devel@lists.xenproject.org; Wed, 03 May 2023 16:36:46 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id af208a88-e9d0-11ed-b225-6b7b168915f2; Wed, 03 May 2023 18:36:43 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: af208a88-e9d0-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683131803; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=qJd4BNQgLPxNBx6IhpSFPUe3kUXTC4ATTMmrCT7u5Hc=; b=YdX15iZECYWYTr99d7saY9lfUSokFQLn2IVSad3xWnTPv6ZdboI0vpfO xNP5t4OlIncW7OEY4f+LJr7y1Vo9xoBG+685GdIpskE4xXzojMU4+ruyD 8s5QNdJSkJl9YVRlpsJ5d5UzJs08Xf1HaH6VfC9uX1NAsBP/d9uJR2Pji A=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 108152269 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:2+qypa7/vQ6LiBpupMMRbwxRtDjHchMFZxGqfqrLsTDasY5as4F+v jEaXWmFPamLMGP2eNlxb4u/oExQ6seAzNFiGQc6/3wyHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+7ZwehBtC5gZlPa0T5weE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m3 /s8OTUIUUm/hfOHy52hdsBUm+smFZy+VG8fkikIITDxCP8nRdbIQrnQ5M8e1zA17ixMNa+AP YxDM2MpNUmeJUQVYT/7C7pn9AusrnD5bz1frkPTvact6nLf5AdwzKLsIJzefdniqcB9xx7I/ z+cpTqoav0cHPKw9gLb+UywvMLKzXndSdhCJqK4+sc/1TV/wURMUUZLBDNXu8KRmkO4Ht5SN UEQ0i4vtrQpslymSMHnWB+1q2LCuQQTM/JPF8Uq5QfLzbDbiy6bCXIDVSVpc8E9uYk9QjlC/ laRksngHzBHrLyfQnXb/bCRxQ5eIgBMczVEP3VdC1JYvZ+6+tpbYg/zoshLOqmRn9jwJmjMw SG7pwcku5wrkOEO7vDulbzYuA5AtqQlXyZsuFWMBjv/vlwmDGK2T9f2sAaGtJ6sOK7cFwDc5 yZcxqBy+chUVfmweDqxrPLh9V1Dz9KMK3XijFFmBPHNHBz9qif4Lei8DNyTTXqF0/romhezO ic/QSsLuPdu0IKCNMebmb6ZBcUw1rTHHt/4TP3SZdcmSsEvJFTfoXozPBTKhjCFfK0QrE3CE c3DLZbE4YgyUMyLMwZat89CiOR2l0jSNEvYRIzhzgTP7IdykEW9EO9fWHPXN7BR0U9xiFmNm zqpH5fQmko3vSyXSnW/zLP/2nhTdyhnWcyo9JYLHgNBSyI/cFwc5zbq6etJU+RYc259z48kI lnVtpdk9WfC IronPort-HdrOrdr: A9a23:8qq0Pa4hEe/l+tfyLQPXwAzXdLJyesId70hD6qkQc3Fom62j5q WTdZEgvyMc5wx/ZJhNo7690cq7MBHhHPxOgbX5VI3KNGXbUQOTR72KhrGSoAEIdReeygZcv5 0QCZSXCrfLfCVHZRCR2njFLz4iquP3j5xBnY3lvhNQpZkBUdAZ0+9+YDzrdXFedU19KrcSMo GT3cZDryrIQwVtUizqbkN1OdQqvrfw5evbXSI= X-Talos-CUID: 9a23:sMRAyGHtHkf3qbmBqmJN82oFH8UaK0Hf3UbbDFWEIF50Z7isHAo= X-Talos-MUID: 9a23:ztX78QZSRvkhc+BTmRDTvG9pCttSzqH+UmYcy8U0pMmIDHkl X-IronPort-AV: E=Sophos;i="5.99,247,1677560400"; d="scan'208";a="108152269" Date: Wed, 3 May 2023 17:36:32 +0100 From: Anthony PERARD To: Alejandro Vallejo CC: Xen-devel , Andrew Cooper , Wei Liu , Juergen Gross , Christian Lindig Subject: Re: [PATCH v3 1/3] tools: Modify single-domid callers of xc_domain_getinfolist() Message-ID: References: <20230502111338.16757-1-alejandro.vallejo@cloud.com> <20230502111338.16757-2-alejandro.vallejo@cloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230502111338.16757-2-alejandro.vallejo@cloud.com> On Tue, May 02, 2023 at 12:13:36PM +0100, Alejandro Vallejo wrote: > diff --git a/tools/libs/light/libxl_domain.c b/tools/libs/light/libxl_domain.c > index 7f0986c185..5709b3e62f 100644 > --- a/tools/libs/light/libxl_domain.c > +++ b/tools/libs/light/libxl_domain.c > @@ -349,16 +349,12 @@ int libxl_domain_info(libxl_ctx *ctx, libxl_dominfo *info_r, > int ret; > GC_INIT(ctx); > > - ret = xc_domain_getinfolist(ctx->xch, domid, 1, &xcinfo); > + ret = xc_domain_getinfo_single(ctx->xch, domid, &xcinfo); > if (ret<0) { > - LOGED(ERROR, domid, "Getting domain info list"); > + LOGED(ERROR, domid, "Getting domain info"); > GC_FREE; > return ERROR_FAIL; > } > - if (ret==0 || xcinfo.domain != domid) { > - GC_FREE; > - return ERROR_DOMAIN_NOTFOUND; I kind of think we should keep returning ERROR_DOMAIN_NOTFOUND on error as this is the most likely explanation. Also, the comment for this function in libxl.h explain this: /* May be called with info_r == NULL to check for domain's existence. * Returns ERROR_DOMAIN_NOTFOUND if domain does not exist (used to return * ERROR_INVAL for this scenario). */ int libxl_domain_info(libxl_ctx*, libxl_dominfo *info_r, uint32_t domid); Would it be possible to find out from xc_domain_getinfo_single() if it's a domain not found scenario vs other error (like permission denied)? > - } > > if (info_r) > libxl__xcinfo2xlinfo(ctx, &xcinfo, info_r); > @@ -1657,14 +1653,15 @@ int libxl__resolve_domid(libxl__gc *gc, const char *name, uint32_t *domid) > libxl_vcpuinfo *libxl_list_vcpu(libxl_ctx *ctx, uint32_t domid, > int *nr_vcpus_out, int *nr_cpus_out) > { > + int rc; > GC_INIT(ctx); > libxl_vcpuinfo *ptr, *ret; > xc_domaininfo_t domaininfo; > xc_vcpuinfo_t vcpuinfo; > unsigned int nr_vcpus; > > - if (xc_domain_getinfolist(ctx->xch, domid, 1, &domaininfo) != 1) { > - LOGED(ERROR, domid, "Getting infolist"); > + if ((rc = xc_domain_getinfo_single(ctx->xch, domid, &domaininfo)) < 0) { The variable name "rc" is reserved for libxl return code. For syscall and other external call, we should use the name "r". (I know that in other part of this patch the name used is "ret", but as it is already existing in the code base, I'm not asking for a change elsewhere) Also, assignment to the variable should be done outside of the if(). So the new code should look like: r = xc_domain_getinfolist(...); if (r < 0) { (There's tools/libs/light/CODING_STYLE for all this explained) > + LOGED(ERROR, domid, "Getting dominfo"); > GC_FREE; > return NULL; > } > diff --git a/tools/libs/light/libxl_sched.c b/tools/libs/light/libxl_sched.c > index 7c53dc60e6..21a65442c0 100644 > --- a/tools/libs/light/libxl_sched.c > +++ b/tools/libs/light/libxl_sched.c > @@ -219,13 +219,11 @@ static int sched_credit_domain_set(libxl__gc *gc, uint32_t domid, > xc_domaininfo_t domaininfo; > int rc; > > - rc = xc_domain_getinfolist(CTX->xch, domid, 1, &domaininfo); > + rc = xc_domain_getinfo_single(CTX->xch, domid, &domaininfo); > if (rc < 0) { > - LOGED(ERROR, domid, "Getting domain info list"); > + LOGED(ERROR, domid, "Getting domain info"); > return ERROR_FAIL; > } > - if (rc != 1 || domaininfo.domain != domid) > - return ERROR_INVAL; We can probably return ERROR_INVAL on error instead of ERROR_FAIL, as I guess it's more likely that we try to change a non-existing domain rather than having another error. > > rc = xc_sched_credit_domain_get(CTX->xch, domid, &sdom); > if (rc != 0) { > @@ -426,13 +424,11 @@ static int sched_credit2_domain_set(libxl__gc *gc, uint32_t domid, > xc_domaininfo_t info; > int rc; > > - rc = xc_domain_getinfolist(CTX->xch, domid, 1, &info); > + rc = xc_domain_getinfo_single(CTX->xch, domid, &info); > if (rc < 0) { > LOGED(ERROR, domid, "Getting domain info"); > return ERROR_FAIL; dito. > } > - if (rc != 1 || info.domain != domid) > - return ERROR_INVAL; > > rc = xc_sched_credit2_domain_get(CTX->xch, domid, &sdom); > if (rc != 0) { Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed May 03 16:50:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 16:50:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529398.823774 (Exim 4.92) (envelope-from ) id 1puFft-0008Fe-JE; Wed, 03 May 2023 16:49:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529398.823774; Wed, 03 May 2023 16:49:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puFft-0008FX-GT; Wed, 03 May 2023 16:49:53 +0000 Received: by outflank-mailman (input) for mailman id 529398; Wed, 03 May 2023 16:49:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puFfs-0008FR-Ad for xen-devel@lists.xenproject.org; Wed, 03 May 2023 16:49:52 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on20607.outbound.protection.outlook.com [2a01:111:f400:7e8a::607]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8459330c-e9d2-11ed-b225-6b7b168915f2; Wed, 03 May 2023 18:49:50 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by CO6PR12MB5412.namprd12.prod.outlook.com (2603:10b6:5:35e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Wed, 3 May 2023 16:49:47 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::5b9b:f31f:ac6d:be94]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::5b9b:f31f:ac6d:be94%7]) with mapi id 15.20.6363.022; Wed, 3 May 2023 16:49:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8459330c-e9d2-11ed-b225-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C50VgqF/7/92gmrzb/0Y1CrOo3aKpqLOn8GhSOsdn+B8gPRCIGB7B1gsC+FHPhIFeR/tenSHrFYcaOU0zC4RVnUQBrlRwo6b09IMC3wAVEem5cMIq2H+jWJ03zK/dHszhKK5kf151TtOdE/JvolUMMUL1EHHZ5R9jccczawgumMAbDQlPeFYyZkYIecocEK+nJBy+cYoZ1se0PofKLTQhdUZk4aieWBoLmoR7qKkymooQc68rWbocdnpQEVnmyLmkgB1ImzE4qp54EwrXIQ4kguujOvc2ATSvkgcH264mMIa42jY6lTK0WyuzTLWWdvudkYgh3anH24POsalYHF4jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tw2kDdaQA48o2ztDNh7bwQ29b2De6+ByZ/x1YYln9oE=; b=Rtu7AosvgxaTmYHD00Q7FJJP32VbhSJMeuitmBUSHhoUzHXIgq9k7bFNleT0s3BDEpzSUn2N+YCvHh2G5fNvkbnWoN/h6RCnzi4ZHiegDwWhkOb2Go2TzmK0+2VWtbeMZVz254+3iJcSThHm0RUSUchx9q27RhLV16pSKUwvuA0bhcWQUA6QVbMyJdcbJGryD/l6lSlUgWlmpIq2y7HgEoreugeM33IyDiTx4y6KKSwMpztiHUcF+PpvrELNQZVhX051Gcq/6h8qjqdM2V5culG1H+MGBPnbuYr8lnJfQIsz1UqDOjjMV7ZFKso7O+sqX4TgdktacwB7vt5TRVU6oQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tw2kDdaQA48o2ztDNh7bwQ29b2De6+ByZ/x1YYln9oE=; b=wPsiJ1kNsKdIdU/j4AQ4ntvvcuI/gRehwcq3XZ3KPda/w1IRBNBcheofwnPueA2rxEhesastPchSobdYfVmy6pti57OONfMrZTsVtwwBsUGt6B4jm6KnZTiE6RtHmmfvLe2mESESx4TEIr8AY6pttLMathqcIID0Ha+CyjrOGug= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: Date: Wed, 3 May 2023 17:49:40 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [RFC PATCH] xen/arm: arm32: Enable smpboot on Arm32 based systems To: Julien Grall , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com References: <20230502105849.40677-1-ayan.kumar.halder@amd.com> <2d764f29-2eb9-ecff-84cd-9baf12961c54@xen.org> From: Ayan Kumar Halder In-Reply-To: <2d764f29-2eb9-ecff-84cd-9baf12961c54@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P302CA0022.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:2c1::7) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|CO6PR12MB5412:EE_ X-MS-Office365-Filtering-Correlation-Id: 9583befc-75bd-4df0-6108-08db4bf66703 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zosjtUhAKz0EhQlnRXtL9YNgD7aN5uwrzpHoial+a7SAhmM225wQFr3zjhhBdoHMyUjPkWSKVyt16POS1rPpQAvFqGOFi2Vti2pGQQSKJpYA7b0B9nw2pRHp9ZvHt1utv9kvDDTmhXu9Bwdhmp/0MTDMAfG639siVUa+ygMC9hvQMa+72MoGwzg7X9l7UZ3/EvnaFx2BtUe5tFu/f/4/IHzhDBC3AojE7m935w6GzAOQWf4JNV9gmEocX54o4crNNnbz5IniRlJqjb4bWv5/r4scvmvo9GpbUpB4PY0GHqSKDRk/TL6tf+/naSuQ1jyCw3iWXZcIWg5/qZ5lVTJUs8OY1JN9sSS9DRUbj1eBBiyZu0eSyWZ5g+ApJsA9Hs7bLwny9KHiZyI8vMyp9Q0/MSYhOkpsG55WgjbvPMe1I2StejRmaPSEmtxvajrLFJtGu6L8BuZYjOAIxPtfUslXWnXPGrNVmtFN0aceUFiZFxhyRMzQgvea1hZYfqfoB/Eve0MDg3KYoInd8Maf5ImlrN/+pnmdV3Jc1auh7dtig7GDRwXW5BIZLDECZvG6aUQ6VzS6WiFk5a3QbD7gsw0DT79X4yAhrLgwKw3kWti1eVun8TKqZvqGXrgYnG/DIreLGp5SvwCA0bkBi6z/G80nwpTJPUybma0IH36FGa1jPYceLyLhwRLWP2RcxRkBkV9l X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(366004)(39860400002)(376002)(136003)(451199021)(6506007)(6512007)(83380400001)(2616005)(66556008)(478600001)(31686004)(31696002)(6486002)(966005)(26005)(6666004)(316002)(66476007)(4326008)(66946007)(110136005)(53546011)(186003)(41300700001)(2906002)(5660300002)(8676002)(8936002)(38100700002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K1dvWTVXQkFqQ2Z5US9FSFJHQUFjZWxIeW1sUnVYcUFReklLejBGOGxhS1ZY?= =?utf-8?B?UEh0ZjliNkRDN2MxQXV5SEdXaXpBS0FYMFVxRGhkbzBPeDJIeDBYRng2SDFQ?= =?utf-8?B?c3dISWhzMWRETnlxU0pvWUxPMzZoRGFDSG9QTWU1ODBvQjkreERJdXJrdTFO?= =?utf-8?B?eDg4b0F1N3RqT2dTREo3aEFNWHBPVkdqNDEwWWdWODBkMHRZZ3ZuRm91a0M5?= =?utf-8?B?UUU0eElxaFZ3MUVWVlR3OCtUS0lmSzhiK3k2MkdOaU5lWTVPSUdhNXQzbUt0?= =?utf-8?B?bU1adkVhb2w0QXVYb3QwUG16VHhncEpac0VzNEFFcVFmNUtyQmlKY2xoR2ho?= =?utf-8?B?ZlVua0ZWNDliM1hvZFdvWmRCSWpUQnZqYVAvTDdTcXhGbGNnSVZkRXU4RGpn?= =?utf-8?B?ZGl6cTQzNVVmTFNHUEpSdUdtZ0F3amZWemdBSWZRMCt4TytjckVSZWJRVlBj?= =?utf-8?B?NzY5em9rZmFNQlFqMjFMVjdjOTlzbVl5VmdHUmNmZWNkTS9MS2c3Q3d1dCt1?= =?utf-8?B?VEpadmdmK3RBZjdUdjQwcFhIQldWT2haVitQdnFZWVhPWE9oTi9YajVrUFNF?= =?utf-8?B?bnhJYTQyREk1OVc5UW8yZlArcUFHY2VkVW16V2RPL3RNTHQ5ODNhTGtBTHc3?= =?utf-8?B?RW9zY0V4ZkFLWTZCUS9qbS9YNy9OcUFxZm5UWnM5NmZ2M0R4eW44N01iYjlQ?= =?utf-8?B?ejhuZzVoWW5kUGVnSlcxWHRrMk5xK2RtLzdFUndzKzc5VGMwYmdOYnMyYlFN?= =?utf-8?B?ckhOUDVIb1I3bnVMWS8zcVVXNW9wQmJFOTF1R0pqcjZ1ZVIrY2VBYW9yOVYy?= =?utf-8?B?UENHT3psYUc5aGV3RlduSEdaY3VmWXRWdmFlUmxMS201UW9yNFJvTDdndkFN?= =?utf-8?B?ZlQrR3RpZFR1OXlKelVxUmIxQkxocm9IcVU0Zk9pUjZaZUxJbTZOclNGT3JF?= =?utf-8?B?VGtXTXZZcmswV25CVVlGbjRXeXlQZkwxRVhuSkUzVFFsYTRFVnZaN05VbHRi?= =?utf-8?B?NGh4UkVPWU5nZEpBS3hhMkM4VnBvNlBieFg0T2NIcjcrNk5la2R6RU9va0FK?= =?utf-8?B?aGFCTjBEWmRHTEV4NDhZS1NTYTJISSszTlBqVzIzUWpaNDNpV3FIQTNjZWJn?= =?utf-8?B?K0JGWkZXVDRPSmVJSjg4Z0hBL2U1NE5QZVR0T0pPcnNFOXNWamk1YnJxcnJx?= =?utf-8?B?Y1MwNEdDNmphd3NidTZ6S0NvdGxiVjBpai9jWTkrTG12c3NXbXlPNWhTeWFO?= =?utf-8?B?eE9LZ05ZK0hSbjl2VWFmZDFSMkVXL2N3SE5GSnQ1RlF3WUFTZ3V3MEdkSVZK?= =?utf-8?B?QjNrQ2d3TGFtOG9TMTVpb1hWNVdJWXFFYXFCQkNSVGNPdTFFQzNlVFVpMnY0?= =?utf-8?B?TFNIbHkrQ1hFdjYzUFJPdEMwV1dJMThTOEd0ZFZGQXcrODhLSXMxbEhVbWdi?= =?utf-8?B?WTZQNDNkbk1BQ0RJT2RxUDVVaERSUTR3MnJUU3VpbDljS28wdElGTGppVElK?= =?utf-8?B?bWhDcDJQeGpTN3JWQ2xMSXFib1VhSlFpY3pwME1HWTdLM0hBcnZOSG5kTjVQ?= =?utf-8?B?aUh1ZkJzVStIK1F6TTZpT296VVp1SGg2Mk9MYlZ1c2E4NnJWaENIblVzMGUr?= =?utf-8?B?QkZxc1Jua3dGcFlLQkVJLzNKSWowNEVGWHZobDNCWHU5SEJYQjBUSi9KUU52?= =?utf-8?B?bmVYVVhsSWdpSlBKME5hOEx1VmJPd1h3b0s3ZU1nMHpZUE5rNTEvVEw0TWlw?= =?utf-8?B?SWlIM0JBa2ZlaUFQKy85OUtxc2g4NFBJcWNVbmZUNHkxV0JLYnVVWFNYWGtJ?= =?utf-8?B?c3FPejNEclRqY1dKanpIaXNMK2F3UnIwYUU1QnFDc0hjWkt2TEdCODZNbGMy?= =?utf-8?B?Mm1aT3ZrN0J2dVRhTVRpckFEQTJqSVNIcVJxNnl3UjNVRmhmQkFrNEw0Z2xa?= =?utf-8?B?NUZFbVZsd1ptNFBOb3JLL25nVkNjRGkxRzBxaHAveFc5Y3loOWxmdE9rRlVQ?= =?utf-8?B?aWhGc0VXZnphUllRSUZHN0lsOE5IQ3JXVXNWdndsQVJ4bzN1V29PQk1KZzBo?= =?utf-8?B?dVNVWXdNNmpIQUlOTEl6NTRxZE85ZG9HS0RRR3ZsNUdDZE5GZjhRSkNLTXZs?= =?utf-8?Q?Sdi6KhCf2McN85z2AMbsATWPo?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9583befc-75bd-4df0-6108-08db4bf66703 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 16:49:46.7835 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fgKudBZMl92uRWGb5gX1tyWNqs4Xr1QdBpy3rJQWgw44NeYBLAEyUAphN98oiVc4oZbZdM/7WCkT1DGmYLnRpQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5412 On 03/05/2023 08:40, Julien Grall wrote: > Hi, Hi Julien, > > Title: Did you mean "Enable spin table"? Yes, that would be more concrete. > > On 02/05/2023 11:58, Ayan Kumar Halder wrote: >> On some of the Arm32 based systems (eg Cortex-R52), smpboot is >> supported. > > Same here. Yes > >> In these systems PSCI may not always be supported. In case of >> Cortex-R52, there >> is no EL3 or secure mode. Thus, PSCI is not supported as it requires >> EL3. >> >> Thus, we use 'spin-table' mechanism to boot the secondary cpus. The >> primary >> cpu provides the startup address of the secondary cores. This address is >> provided using the 'cpu-release-addr' property. >> >> To support smpboot, we have copied the code from >> xen/arch/arm/arm64/smpboot.c > > I would rather prefer if we don't duplicate the code but instead move > the logic in common code. Ack > >> with the following changes :- >> >> 1. 'enable-method' is an optional property. Refer to the comment in >> https://www.kernel.org/doc/Documentation/devicetree/bindings/arm/cpus.yaml >> >> "      # On ARM 32-bit systems this property is optional" > > Looking at this list, "spin-table" doesn't seem to be supported > for 32-bit systems. However, looking at https://developer.arm.com/documentation/den0013/d/Multi-core-processors/Booting-SMP-systems/SMP-boot-in-Linux , it seems "spin-table" is a valid boot mechanism for Armv7 cpus. > Can you point me to the discussion/patch where this would be added? Actually, this is the first discussion I am having with regards to adding a "spin-table" support on Arm32. The logic that we will use for secondary cpu booting is similar to the "spin-table" mechanism used in arm64/smpboot.c. This is :- 1. Write the address of init_secondary() to cpu-release-address register of the secondary cpu. (In my current patch, I attempt to achieve this.) 2. Write to the configuration register of the secondary cpu to bring it out of reset. This is the corresponding patch (yet to be cleaned) which will be used to do step 2. --- a/xen/arch/arm/platforms/amd-versal-net.c +++ b/xen/arch/arm/platforms/amd-versal-net.c @@ -36,6 +36,47 @@ static int versal_net_init_time(void)      return 0;  } +static __init void versal_net_populate_plat_regs(void) +{ +    /* TODO :- Parse 0xEB58C000 ie CORE_1_CFG0 from dtb */ +} + +static __init int versal_net_init(void) +{ +    versal_net_populate_plat_regs(); + +    return 0; +} + +static __init int versasl_net_smp_init(void) +{ +    return 0; +} + +static __init int versal_net_cpu_up(int cpu) +{ +    uint32_t __iomem *cpu_rel_addr = ioremap_nocache(0xEB58C000, 4); +    uint32_t i = 0; + +    writel(1, cpu_rel_addr); + +    /* Delay has been added due to some platform nuance */ +    __iowmb(); +    for (i=0; i<0xF000000; i++) +        __asm __volatile("nop"); + +    writel(0, cpu_rel_addr); + +    /* Delay has been added due to some platform nuance */ +    __iowmb(); +    for (i=0; i<0xF000000; i++) +        __asm __volatile("nop"); + +    iounmap(cpu_rel_addr); + +    return 0; +} +  static const char * const versal_net_dt_compat[] __initconst =  {      "xlnx,versal-net", @@ -44,5 +85,8 @@ static const char * const versal_net_dt_compat[] __initconst =  PLATFORM_START(versal_net, "XILINX VERSAL-NET")      .compatible = versal_net_dt_compat, +    .init = versal_net_init, +    .smp_init = versasl_net_smp_init, +    .cpu_up = versal_net_cpu_up,      .init_time = versal_net_init_time,  PLATFORM_END > >> >> 2. psci is not currently supported as a value for 'enable-method'. >> >> 3. update_identity_mapping() is not invoked as we are not sure if it is >> required. > > This is not necessary at the moment for 32-bit. This may change in the > future as we make the 32-bit boot code more compliant. For now, I > would not add it. Ack. - Ayan > > Cheers, > From xen-devel-bounces@lists.xenproject.org Wed May 03 17:03:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 17:03:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529401.823784 (Exim 4.92) (envelope-from ) id 1puFsq-0002Cq-Om; Wed, 03 May 2023 17:03:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529401.823784; Wed, 03 May 2023 17:03:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puFsq-0002Cj-L0; Wed, 03 May 2023 17:03:16 +0000 Received: by outflank-mailman (input) for mailman id 529401; Wed, 03 May 2023 17:03:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puFsp-0002Cd-5k for xen-devel@lists.xenproject.org; Wed, 03 May 2023 17:03:15 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6229df47-e9d4-11ed-b225-6b7b168915f2; Wed, 03 May 2023 19:03:12 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6229df47-e9d4-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683133392; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=TFk000qXnvuKsmqHZ8WX/bYNw58Rk1KBLQEnXQGux8M=; b=Z0j0Bk6uCZXOdsBLz3jPU3HfL+XWLR9I09bzv24vcESjOGnRZVrgXfNA ta7QtFc4o8M3KSfMqzwBXI06+6riEJ81wLU40cKkWNMACLfkCc0YLg3SZ cadA9C3F+i4+9dNT2OEgOd/xyJ+Oqv+JjQiczEeh+QLHIsM+7l62oSrQw 0=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 110190138 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:sVtXLqhjwiauR/ZizUulX+AuX161dxAKZh0ujC45NGQN5FlHY01je htvWD3SOPuIZzHxLdB+btnjo0pTupPUndFiHlA/pChkECgb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWj0N8klgZmP6sT4QeFzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tREKiI3bjaIntiq0Y+fd/Uwo58JJcPCadZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJYw1MYH49tL7Aan3XejtEqFWTtOwv7nLa1gBZ27nxKtvFPNeNQK25m27B/ zqfrjygWUFy2Nq3igOPrUiW2ObzvRjLZbwrCK+mq6A3nwjGroAUIEJPDgbqyRWjsWaiWtd3O 0ESvC00osAa/VSmVNDnUzWkoXSPuVgXXN84O+818gaW0YLP/h2UQGMDS1ZpeNEg8cM7WzEu/ luIhM/yQyxitqWPTnCQ/avSqim9UQAKKUcSaClCShEKi+QPu6lq0EiJFIw6Vvfo0JusQ2qYL y22QDYW27cBt84t3LyB4UH6pw+w+r2SZAc/z1CCNo661T+VdLJJdqTxtwiAta8afNnGJrWSl CNawpbDtYjiGbnIzXXQG7tVQdlF8t7faFXhbUhT847NHthH01qqZshu7T53Py+F2e5UKGayM Cc/Ve68jaK/3UdGjoctOepd8+xwkcDd+S3ND5g4lOZmbJlrbxOg9ypzf0OW1G2FuBFywfpnZ MzGKJz2VCZy5UFb8dZLb71Fje9DKt4WnAs/uqwXPzz4iOHDNRZ5uJ8OMUeUb/BR0Z5oVD79q o4FX+PTkkU3bQELSnWPmWLlBQxQfCdT6FGfg5A/S9Nv1SI/QjF9V6OPnul9E2Gn9owM/tr1E riGchcw4DLCabfvd21mtlgLhGvTYKtC IronPort-HdrOrdr: A9a23:V982hairHaw8sVIoyQv8TIKZnXBQXlMji2hC6mlwRA09TyX4ra yTdZEgviMc5wxwZJhNo7G90ey7MArhHLROkO4s1NSZMzUOxlHYSr2KhLGKq1eMJ8S9zJ8k6U 4HSdkENDSaNzZHZKjBkXWFOudl7N6b8L25wcfypk0dMj2CspsQlTuR3Dzrb3FedU19CZ0lD4 rZw8xIqTa6EE5nDPiTNz0+U+/fvM2OsZTpbxIcQzsq9wWK5AnYjYLSIlyj0hACSCMK+Kwl8m TOjmXCl8aemsD+8BPaynTCq69bgd7wjuZEbfb87vQoFg== X-Talos-CUID: 9a23:2hL3xGww7DzlUDf2SilKBgVIGNIfclvW1U3MMnKcNHo1bea/QFW5rfY= X-Talos-MUID: 9a23:WHvQ8gi07hnAne3yEbQzt8Mpd/5ivJ6UVkkxsa42hve9KT5uZmnAk2Hi X-IronPort-AV: E=Sophos;i="5.99,247,1677560400"; d="scan'208";a="110190138" Date: Wed, 3 May 2023 18:02:58 +0100 From: Anthony PERARD To: Alejandro Vallejo CC: Xen-devel , Andrew Cooper , Wei Liu , Tim Deegan , George Dunlap , Juergen Gross Subject: Re: [PATCH v3 2/3] tools: Use new xc function for some xc_domain_getinfo() calls Message-ID: <1828a067-95fe-4d6e-9923-54f76593b9d8@perard> References: <20230502111338.16757-1-alejandro.vallejo@cloud.com> <20230502111338.16757-3-alejandro.vallejo@cloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230502111338.16757-3-alejandro.vallejo@cloud.com> On Tue, May 02, 2023 at 12:13:37PM +0100, Alejandro Vallejo wrote: > diff --git a/tools/libs/light/libxl_x86_acpi.c b/tools/libs/light/libxl_x86_acpi.c > index 22eb160659..796b009d0c 100644 > --- a/tools/libs/light/libxl_x86_acpi.c > +++ b/tools/libs/light/libxl_x86_acpi.c > @@ -87,14 +87,14 @@ static int init_acpi_config(libxl__gc *gc, > { > xc_interface *xch = dom->xch; > uint32_t domid = dom->guest_domid; > - xc_dominfo_t info; > + xc_domaininfo_t info; > struct hvm_info_table *hvminfo; > int i, r, rc; > > config->dsdt_anycpu = config->dsdt_15cpu = dsdt_pvh; > config->dsdt_anycpu_len = config->dsdt_15cpu_len = dsdt_pvh_len; > > - r = xc_domain_getinfo(xch, domid, 1, &info); > + r = xc_domain_getinfo_single(xch, domid, &info); > if (r < 0) { > LOG(ERROR, "getdomaininfo failed (rc=%d)", r); You could change this error message. The value of 'r' isn't interesting anymore. Instead, you could replace that by LOGE or LOGED (both will print errno). Otherwise, patch looks good: Acked-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed May 03 17:13:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 17:13:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529403.823793 (Exim 4.92) (envelope-from ) id 1puG2N-0003hq-LU; Wed, 03 May 2023 17:13:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529403.823793; Wed, 03 May 2023 17:13:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puG2N-0003hj-It; Wed, 03 May 2023 17:13:07 +0000 Received: by outflank-mailman (input) for mailman id 529403; Wed, 03 May 2023 17:13:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puG2N-0003hd-42 for xen-devel@lists.xenproject.org; Wed, 03 May 2023 17:13:07 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c3c7fa37-e9d5-11ed-b225-6b7b168915f2; Wed, 03 May 2023 19:13:06 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c3c7fa37-e9d5-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683133986; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=2M2YzHhQe+4b8uYTmzqGzDo4Ommpt+0EZR59fV316rw=; b=FeitYJwnKDgZTl2N4YMsDOc7cHw4SVKN/DjMJaXmh2vZp7B4uKQugpIA wPN4LATi2AeEqdpMZkDInovZjYTuCOtKO5KHjibVVRf+l9+MT+bbfh3tc gVy7+zYHb/mMbxomNBUhAPDnjZ9+FBSaY9+IAmNd5g1yCUBqh6PpnKfzt Q=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 108156469 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:KQ5owazzxBZDaiTWTYl6t+fyxirEfRIJ4+MujC+fZmUNrF6WrkUBm 2BOUDuCOv+ONjOkKdt2Yd+19B5U7MCAndVhSQpp/iAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UIHUMja4mtC5QRjPasT5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KUxk0 vEZBWEqVAqen9qd6bL4Usdoltt2eaEHPKtH0p1h5TTQDPJgSpHfWaTao9Rf2V/chOgXQ6yYP ZBAL2MyMlKZOUYn1lQ/UfrSmM+hgGX/dDtJ7kqYv6Mt70DYzRBr0airO93QEjCPbZwNzh/F+ D6YrgwVBDkfK87cimCXz0mSh7OVsDrXc78pLbano6sCbFq7mTVIVUx+uUGAiem0jAuyVsxSL 2QQ+zEytu4i+UqzVN7/Uhak5nmesXY0WdBdDuk74wGl0bfP7kCSAW1sZjxcbN0rsucmSDps0 UWG9/vyHiBmurCRTXOb95+XoCm0NCxTKnUNDQcbSSMV7t+lp5s85jrNQcxkC7WdlcDuFHf7x DXihCEmiq8al8Ijy6Sx9leBiDWpzqUlVSZsuF+RBDj8qFokOsj8PdfABUXnAehoAay+Q1is7 V8+gdWG1MsnDdKVuiidX7BYdF223MppIAEwkHY2Qcl6r233qyH8FWxDyGogfRk0a67obResO RaO4l0Jufe/KVPwNcdKj5SN59PGJEQKPfDsTbjqY9VHefCdnyfXrXg1NSZ8M40A+XXAcJ3T2 r/BK65A9V5AVcxaIMOeHo/xK4MDyCEk3n/0Tpvm1Rmh2rf2TCfLGexdbQDTN7pjtfPsTODpz jqiH5HSl0U3vBPWO0E7DrL/3XhVdCNmVPgaWuRcd/KZIxoOJVzN/8T5mOt7E6Q8xvQ9qws91 i3lMqOu4Aal1CKvxMTjQiwLVY4Dqr4m9yJnYXByYgz0s5XhCK72hJoim1IMVeFP3IReITRcF ZHpp+3o7ixzdwn6 IronPort-HdrOrdr: A9a23:mHurl67v6tHjiHPC1QPXwAzXdLJyesId70hD6qkQc3Fom62j5q WTdZEgvyMc5wx/ZJhNo7690cq7MBHhHPxOgbX5VI3KNGXbUQOTR72KhrGSoAEIdReeygZcv5 0QCZSXCrfLfCVHZRCR2njFLz4iquP3j5xBnY3lvhNQpZkBUdAZ0+9+YDzrdXFedU19KrcSMo GT3cZDryrIQwVtUizqbkN1OdQqvrfw5evbXSI= X-Talos-CUID: 9a23:1jjxam0e36RCFg2nBqTwxLxfN+oCf3zwnVDqOVKgMU1ASP6NZ1uA5/Yx X-Talos-MUID: 9a23:VZnVpASIhgFhruwIRXTpmyMhd5163p+QCRxXvIwqkPS/DCdvbmI= X-IronPort-AV: E=Sophos;i="5.99,247,1677560400"; d="scan'208";a="108156469" Date: Wed, 3 May 2023 18:12:53 +0100 From: Anthony PERARD To: Alejandro Vallejo CC: Xen-devel , Andrew Cooper , George Dunlap , "Jan Beulich" , Julien Grall , "Stefano Stabellini" , Wei Liu , Juergen Gross Subject: Re: [PATCH v3 3/3] domctl: Modify XEN_DOMCTL_getdomaininfo to fail if domid is not found Message-ID: References: <20230502111338.16757-1-alejandro.vallejo@cloud.com> <20230502111338.16757-4-alejandro.vallejo@cloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230502111338.16757-4-alejandro.vallejo@cloud.com> On Tue, May 02, 2023 at 12:13:38PM +0100, Alejandro Vallejo wrote: > It previously mimicked the getdomaininfo sysctl semantics by returning > the first domid higher than the requested domid that does exist. This > unintuitive behaviour causes quite a few mistakes and makes the call > needlessly slow in its error path. > > This patch removes the fallback search, returning -ESRCH if the requested > domain doesn't exist. Domain discovery can still be done through the sysctl > interface as that performs a linear search on the list of domains. > > With this modification the xc_domain_getinfo() function is deprecated and > removed to make sure it's not mistakenly used expecting the old behaviour. > The new xc wrapper is xc_domain_getinfo_single(). > > All previous callers of xc_domain_getinfo() have been updated to use > xc_domain_getinfo_single() or xc_domain_getinfolist() instead. This also > means xc_dominfo_t is no longer used by anything and can be purged. > > Resolves: xen-project/xen#105 > Signed-off-by: Alejandro Vallejo > Reviewed-by: Andrew Cooper Acked-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed May 03 17:15:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 17:15:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529408.823803 (Exim 4.92) (envelope-from ) id 1puG4j-0004Lu-6w; Wed, 03 May 2023 17:15:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529408.823803; Wed, 03 May 2023 17:15:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puG4j-0004Ln-2v; Wed, 03 May 2023 17:15:33 +0000 Received: by outflank-mailman (input) for mailman id 529408; Wed, 03 May 2023 17:15:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puG4i-0004Lf-87 for xen-devel@lists.xenproject.org; Wed, 03 May 2023 17:15:32 +0000 Received: from rs227.mailgun.us (rs227.mailgun.us [209.61.151.227]) by se1-gles-sth1.inumbo.com (Halon) with UTF8SMTPS id 1ae33198-e9d6-11ed-b225-6b7b168915f2; Wed, 03 May 2023 19:15:31 +0200 (CEST) Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) by 628c2f3507a6 with SMTP id 645296b08a040ae8e218a377 (version=TLS1.3, cipher=TLS_AES_128_GCM_SHA256); Wed, 03 May 2023 17:15:28 GMT Received: by mail-yb1-f172.google.com with SMTP id 3f1490d57ef6-b9a6f17f2b6so4533649276.1 for ; Wed, 03 May 2023 10:15:28 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 1ae33198-e9d6-11ed-b225-6b7b168915f2 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=tklengyel.com; q=dns/txt; s=mailo; t=1683134128; x=1683141328; h=Content-Type: Cc: To: To: Subject: Subject: Message-ID: Date: From: From: In-Reply-To: References: MIME-Version: Sender: Sender; bh=TirsW8/KIZ0QmHxWPC0SOfA+JzpVCBqdOLxkFAQMwV4=; b=8BSDSsNsgeenPXKChP/CNp0bd6CSJS08K51I5h2jBzcVm7nc9hSlZl5xkerUSrcZyV/S/VsiVrlacePnX4tpyjtHYZaXrVQ/ib4yz0zFCQZTrpefIHa1VOXcwGHMVq/72gZKRB7TPaWRFd7IZX59gGLqXYPXy8Kpt+qCnX+BQGAHh24gSZt4GtK2fRjrQHM8V/eQTHa5AEHXQfqg4Tx/Z7s7CWKEYYxwYQN0u6TVqdjg9Hx4rra8XMXHw8UuXsFDKPRQq5o8Kh0e4gYwPv2VxCBeehG0Ts+tgM+CkSB++my5ls20NevHTN+Ffq6T9Qi88JC8ChDm1C3LyapMZ50ZQg== X-Mailgun-Sending-Ip: 209.61.151.227 X-Mailgun-Sid: WyIyYTNmOCIsInhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZyIsImNkODQwIl0= Sender: tamas@tklengyel.com X-Gm-Message-State: AC+VfDz5HOCAGu+5FavMDCVam1aBe8Vmh9/34MphLR1/dymX8k/h7ow9 3y3KnJF4wUNEEs46w6OlIiXIPJ19FYAjIdYqbzM= X-Google-Smtp-Source: ACHHUZ767567dvazsFs+5+/XAzI0om2r5wjeBctqT0Wjowi5pEXIaqiZcoTMxgrROd1AJ8YZpsNPt6doCFvFF/LxWXo= X-Received: by 2002:a81:5284:0:b0:55a:c779:d8c0 with SMTP id g126-20020a815284000000b0055ac779d8c0mr2918180ywb.22.1683134128464; Wed, 03 May 2023 10:15:28 -0700 (PDT) MIME-Version: 1.0 References: <472f8314-9ad7-523a-32dc-d5c2138c2c8c@suse.com> In-Reply-To: From: Tamas K Lengyel Date: Wed, 3 May 2023 13:14:52 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 4/8] x86/mem-sharing: copy GADDR based shared guest areas To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Content-Type: multipart/alternative; boundary="000000000000d62b1705facd33c8" --000000000000d62b1705facd33c8 Content-Type: text/plain; charset="UTF-8" > @@ -1974,7 +2046,10 @@ int mem_sharing_fork_reset(struct domain > > state: > if ( reset_state ) > + { > rc = copy_settings(d, pd); > + /* TBD: What to do here with -ERESTART? */ Ideally we could avoid hitting code-paths that are restartable during fork reset since it gets called from vm_event replies that have no concept of handling errors. If we start having errors like this we would just have to drop the vm_event reply optimization and issue a standalone fork reset hypercall every time which isn't a big deal, it's just slower. My preference would actually be that after the initial forking is performed a local copy of the parent's state is maintained for the fork to reset to so there would be no case of hitting an error like this. It would also allow us in the future to unpause the parent for example.. Tamas --000000000000d62b1705facd33c8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> @@ -1974,7 +2046,10 @@ int mem_sharing_fork_reset(str= uct domain
>
> =C2=A0 state:
> =C2=A0 =C2=A0 =C2=A0if ( r= eset_state )
> + =C2=A0 =C2=A0{
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0rc =3D copy_settings(d, pd);
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0/* = TBD: What to do here with -ERESTART? */

Ideally we c= ould avoid hitting code-paths that are restartable during fork reset since = it gets called from vm_event replies that have no concept of handling error= s. If we start having errors like this we would just have to drop the vm_ev= ent reply optimization and issue a standalone fork reset hypercall every ti= me which isn't a big deal, it's just slower. My preference would ac= tually be that after the initial forking is performed a local copy of the p= arent's state is maintained for the fork to reset to so there would be = no case of hitting an error like this. It would also allow us in the future= to unpause the parent for example..

Tamas
=
--000000000000d62b1705facd33c8-- From xen-devel-bounces@lists.xenproject.org Wed May 03 17:37:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 17:37:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529411.823813 (Exim 4.92) (envelope-from ) id 1puGPV-0006pJ-Sy; Wed, 03 May 2023 17:37:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529411.823813; Wed, 03 May 2023 17:37:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puGPV-0006pC-QK; Wed, 03 May 2023 17:37:01 +0000 Received: by outflank-mailman (input) for mailman id 529411; Wed, 03 May 2023 17:37:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puGPU-0006p6-75 for xen-devel@lists.xenproject.org; Wed, 03 May 2023 17:37:00 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 19cc0720-e9d9-11ed-b225-6b7b168915f2; Wed, 03 May 2023 19:36:58 +0200 (CEST) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 May 2023 13:36:51 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB6616.namprd03.prod.outlook.com (2603:10b6:a03:389::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Wed, 3 May 2023 17:36:45 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb%4]) with mapi id 15.20.6340.031; Wed, 3 May 2023 17:36:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 19cc0720-e9d9-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683135418; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=XQoRvwDsNAbb2Ldv2vsHR2jw0A+eesLTBRQ0JAHIYZI=; b=XrQxQ5peAW8sK57BWfAuI00QHm46BVDOPZzx25JrknnG0IpzuRcLuxMF ZydkGkDUsKTR5l0LUDl/j0tIBoz1Mek4bY9FjdrHUkVMZVPq/i4V+UNxs 7I96rzCAob4GkPPYvcn8Bzd7HxhWY/N2N9VihKRcE8WlfBTbW/ilK4AKP Y=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 110194738 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:OoV7gKCtUkBhOBVW/83iw5YqxClBgxIJ4kV8jS/XYbTApG8k1TAEm 2MfWTiOP/+DYzT9fNklOo2yphsEscSEnNNmQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFuspvlDs15K6p4G5A5QRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw/d0uLG5ey OUkNxMGSiu4neGMwbCdRbw57igjBJGD0II3nFhFlGicJ9B2BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI9exuvTi7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prraWxXqqBN1JRNVU8NZJq1/U6DUtMyQsD2aenMHgq227edRAf hl8Fi0G6PJaGFaQZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpatYrqcs3TjwCz UKSkpXiAjkHmKKRYWKQ8PGTtzzaESoaN2gZfgcfUBAIpdLkpekbjA/LT9tlOL64iJvyAz6Y6 yuRsCE0irEXjMgK/6a251bKh3SrvJehc+IuzgDeX2bg5AUpYoegPtWs8QKCs6YGK5uFRF6cu nRCg9KZ8O0FEZCKkmqKXfkJG7aqof2CNVUwnGJSInXozBz1k1bLQGyayGgWyJtBWircRQLUX Q== IronPort-HdrOrdr: A9a23:kUDlKKunYYPikJ0wxn/YQRyo7skDVNV00zEX/kB9WHVpm62j5q WTdZEgv3LJYVkqNE3I9eruBED4ewK6yXcX2/hyAV7BZmnbUQKTRelfBO3ZrQEIcBeOldK1u5 0AT0FIMqyVMbErt63HCdGDYqwdKQO8gdiVbDrlvhFQpN1RGtpdBtlCe3um+iIffng+OaYE X-Talos-CUID: 9a23:DN45g28AhDanwNXW77iVv0kvQ+0qYkDE8GjzKGuDMnxqcryXb1DFrQ== X-Talos-MUID: 9a23:V9VPzQuV9aiXg2sgP82npxpgc+kx3Z+XMhowtKg+4uinMA52JGLI X-IronPort-AV: E=Sophos;i="5.99,247,1677560400"; d="scan'208";a="110194738" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YO2+CGSKubaWEYAcnbck40Jmvju5UacLj4D9ZcoL3hkyqj3p92FfnekWxBObctA/dZ3XFNpqr/UFtZaxcbLtPvci5SVL/XGnpB4x1r9KfuskQ+KW8V5Iu1J0GBusP7mIr7xxZjP19nJjRu4xPREHg14SEUdzs0owhhacov1b6zv7te/OrNdjOKViCGdyTS6dh7Yvfby7w4O1LFilXccQok+OrytXKIn/cdiqgK4TBMQSffcnuUSNmt0nvyKx6s8876vlGOXAiC4njCKIZM3I2stcEYR4tN1ToqkHnPl5njPFcctTMhhVxpbTHxGQkMg4+xdXy837vRvzERXMgofJDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gth2XfANnyxBojNYe2210OffKWETGMpY5ZLlikIbgls=; b=aW5XaTADBXtq4LrjLZXTxPtdqPBA+7gudne83WluH++jME57nxcP9k+UbdkKqf6/AeuBJSaiLBwLzPk5y1JzJ+iXc+zAKOJIA0Ria8lubNuehhkmzvCp/ZzRGsxGNviSbI/TfQtPHrkaYkS4yn2CPE7ep5m4avH9NV8CreXqUswUcj8dCc9vvSmX7Xs0dHC+8KNui7CnprS8h7o4wpxCvVlaZJjC5CIFNxAKPUznwczIS7UsNjtMnlbD18R20JTuBcIhTGLf2WWEhrKi855lQjek9k+BAY5s/t6PHUVE8UEnfSF9dBPqgzM3VrrLrrtPDMuTAW+AR3Q37d1w/BvSmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gth2XfANnyxBojNYe2210OffKWETGMpY5ZLlikIbgls=; b=mMP4wjN5qWh8cOVs3fYwsQDQrbwTvKDoNgL92rMt6V2e3hmEGyE06Z97Q55peyhfulk/CNN/XPKREJFsLRa1yN1CeYG2PKflZyuf4R6jEZz367btveXEbNDIp1VDdX9j67i2bwiINx+1ZEoVuGP0NdTOHferiTyDUIJf5u4YZ1A= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Wed, 3 May 2023 18:36:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: Andrew Cooper Subject: Re: [PATCH v5 3/3] tools/xen-ucode: print information about currently loaded ucode Content-Language: en-GB To: xen-devel@lists.xenproject.org Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Anthony PERARD , Juergen Gross , George Dunlap , Julien Grall , Stefano Stabellini References: <20230417135335.17176-1-sergey.dyasli@citrix.com> <20230417135335.17176-4-sergey.dyasli@citrix.com> In-Reply-To: <20230417135335.17176-4-sergey.dyasli@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0103.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:191::18) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB6616:EE_ X-MS-Office365-Filtering-Correlation-Id: 8987df46-5fd2-4ae5-c92c-08db4bfcf6e1 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /mvLE98wnHuCNj6thre3J8vYFwhoO+4dTfq8JxEO/EzZyQ2ecCKfZsOVe7Ef+2H+yWJcMhAGd62SPhpnhXw4IP4/iteuM/zOwtMayKGVJ3NOTkTZDzz0VqTP6vKFqOXh4dB+yuJZ8Rvpbs3c4BhfmvPPq6335wXUgTVEMoTj2STejqO72pylQQeM304V8KNFElaOfwbx5q45HHuoWusK+UIYZ86xtnN67dvLrfZ4EhvvXH1UwdaVJ5glW6jIA5R8kqM/8/vClYDXozs7lgib/FisQSGpaLBvRdKO5A8kPRiGo0RnvJOOxMDG7D4vKagl7xHYxDPCxSXtS+Pl9wv2gxGLE/H88uE74OMWL0d6qWIHSqkPz7kCSEvhIzXwSgOk4tVaY/J7ADAOP0k/qQS/mkwdk/DTTeqmJCIGE/hnbnekbe7ktJQy5T6cPOB2FDRHL4wpny3BBAh/o6YWPXn3SXduv+nmgmMVAsxuIu/C3XezZkywv6mnkA0kCjqB/z5GDWeEeTfp6zip4Peg7o7fCa5i/Qe2zouEk4AwQ8uOfJbxYSPB9Pt/h91HzKzresA1wcp8WsRH7YxidzsQEc58oUDGzrGFFle0lN04Lo1eQozcbl/oweSEDlUfvWh0zUPOX52PiEPOYqZfxl9ZlJydJA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(366004)(39860400002)(346002)(376002)(451199021)(38100700002)(6486002)(6666004)(6506007)(53546011)(26005)(6512007)(36756003)(2616005)(186003)(82960400001)(86362001)(41300700001)(316002)(4326008)(6916009)(4744005)(2906002)(31696002)(66556008)(66476007)(66946007)(8676002)(8936002)(31686004)(478600001)(5660300002)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dU95eWpZWUtTOFF0bEU3aTBJbUZSSUNJWTBYUVZuVEFiY01oRW96Q3FvTFBW?= =?utf-8?B?NGo2ZmxITVZnVGxBd2tEZkhpUlJYMmRuQnZZdDdvM3RFU2pQb1ljYmpab25S?= =?utf-8?B?S0pGNEdHMm81Q2lOdFVyVXluYy9uNXZNNmt5ODE5eUoxS1NCeG9keVIwMEVN?= =?utf-8?B?MlhiRFZUOU9tUHZCUXVXT0M3TzJsTlRUUFAxY1lxVmJDbnQ5SzVJVzFlR3ps?= =?utf-8?B?TmFTSkRLa2tSd3B4UDZnVkY5aE1YWUhWVmViL2lmUUVmY1VKWjN0cjZ5bXJY?= =?utf-8?B?Vzg1YkpVZWE2am5yRUVaYmkwRjRkR0M4Sjg4TExPbE5EOW9rcUYwUTNyOWRq?= =?utf-8?B?SEpUNDVraVltWGRJNnhkQU1YVlhVcTkzUFBkeDVjNVRuUllTQ0lPSCtkanlZ?= =?utf-8?B?Mm1paURkU0Y1bWVsRGY0Q0FjZDBvQyt6T0xiMlA5eGUrQWpTN3ZQTngwcC80?= =?utf-8?B?MlJsazArVmpVcTkwS1hZbUs5TGszNS9hcXl1b3BYMTJhT211ZmQvNWtyQ2hP?= =?utf-8?B?THltUHZvZ2NrVWhVMEhTcXdsQlpKQ1pHcUtQb2xLcFVlcnREOXlPZHY4K2x6?= =?utf-8?B?Vk1uSlMrcytCR1JMeHZqM29QRkd5L3lOQXpyci9VUWplRjd5WXpmT3ZrTHAv?= =?utf-8?B?RUtUZGZNZ2NMVktoMkVyc3BDOFlkb3JtNDU3UEswakZXdHNrbm1YSkx4TlVE?= =?utf-8?B?dVQ5eXBLY1M2MnFmazJzeHFWVVJaWTRaZG5pWi92QUxsNVVZaVFWc2ZYMWRa?= =?utf-8?B?TjRWaW13RVJMejlnWWJCZm1vSkVsWm8zSnNTbVJINXVQK1d5RXo1cm1YVEw2?= =?utf-8?B?UXNoUTIxelVnbEloYWFZVEdKUWJYbVI3SnoyaG0vZGlsZWlpL3RFKzBGa2pp?= =?utf-8?B?OXE0VlR2OGxwNzM4MEd0SzFVRXZIT3R5anBSc2R3WjhrYUJTY0R6WTVvWUk1?= =?utf-8?B?dE82bEg3ZUVYTFJhL3V4ZkZiVzg1S1ZCRlUyY3NZZWtkeVo0UXAxcWcxYWo0?= =?utf-8?B?RDFhOXVpaDRnUHA5cGYyY0QvT0JoYXYzcml0dmEySmx2ZnA0Nmc4M1FMdWtH?= =?utf-8?B?aTBqNDRMWDJVbFdwS3NFZjRHd21wRlBMdnJWcU1GdndFTWpIMjNacUJQWEQz?= =?utf-8?B?cTZ4SnRYRGUwM091dHgzKzZieE9KbWNxMC9QLzVlUitVeEg2NW9vNGRGUDdB?= =?utf-8?B?bHYrOSs1UGRFcTJYZHc3SGx6cEZoU0Zxa2tpQmxybGhBNjRLakNaa1p0bG8w?= =?utf-8?B?bzlGa04yRUZueUFYcU9DUkdwUnJqSXZIU2RiUkdIbll2dmJlRFBnN2FDbkdj?= =?utf-8?B?VS9zaFd2c0swSjBFbUZBQ2ZSeUJJM29NV2ZsZHFpbE4xRXlaMjYxejdTRHA3?= =?utf-8?B?WE1ZVzFXbTJYMXpZTGsyS3dtblRQSi9xV3huNVN4a0kyLy9FRStxSW9TKzU4?= =?utf-8?B?RVRMUWtkdmtoMHRQa1dqYTYyb1B3bHlUTzh3UCtka2pyUFFyNVRBRFYxdlhn?= =?utf-8?B?MmNndVdQTjVJQUtIVFRpUy9CbDhVUlk5TDNFUFJid2N1WWdidEVoZHppNE1n?= =?utf-8?B?R05SOXI5bEVmdGc0TVdQbzQ4amNUc3JuSDM0QVU5YTMvNTNKclpXSVRLVVUx?= =?utf-8?B?UzU5ZythT3UxeENVcE04MjdIMXBZaFVMbXhqTHAzbThwRnNNZjIyL3RIZzlt?= =?utf-8?B?NTROWkVlaCtzSE56c0gyQndMZGpFczk1Wjh5ckVTS0ZFaVo5cFZVbnI3SDJw?= =?utf-8?B?ZTJUbFJlNmZ3V3NOeTB2QmlrRDNHWWhhK0xjcGdyRFFiMjh4MkMxMmF2eWVm?= =?utf-8?B?bVkxelJEUWNib0FrejZ4SldwVjNXbzVJTHA4dUg2bVFINkdiMldKSXRGeUx1?= =?utf-8?B?TEhVdXE4Qm83dVIyN2ZncWgyZVBzY3ZlTnhVbHRBUG9aM0tsY2c2MDhpNTRY?= =?utf-8?B?V2lWa0o4M01zUGlyeWxZTGtpZWQ1YU04eE1rQjNzdEt5OW9GRDVQbUp1UTMw?= =?utf-8?B?L3pxbTRNeURFdUJIVnVaNlBGYnlUZlArMlRxVlVsVFhwL0FHbjNLeXlmbjUr?= =?utf-8?B?WHBmbHVUNGU3bjRteVlWeW1MQWNrTTk1em8zVkRTemZZT2RPQ1hVcmZGb0Y5?= =?utf-8?B?bVhSdjZUWnNRMTN2U0Nqd2pjdmxlQUIzVFBHMDlueXhhVHo5WDI0LzQzOXMz?= =?utf-8?B?dlE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: XBu/sw2V3JaD5oAP+cIDlB1s/UP6SeBGenGQxDOtRhFcIurx2e3KyBCZ1QpgBSz6GzLWi9TusnmVU9/rmZlPZbiaJAMSDrvdYo2pM6CWYOQo8kaTdvAZpgKfoZ5acv7TMxs92s0s+UQuipIHhd5qo3ma9dG7eh3pphFk7HkOZJx9617+V7SOJmGLdvtGObO+r7m6vqng6emLzjeFdghEi/O7n1d0sD/sFyQJgYw/VIOGVfsa5C3s27RseBoM0CQQq5LA6gYC6bMsWeIoXQ0Ia3dO8AlwKaG9eg52LVYkx+VkkPUFPaC8TKjIS0vcU/VaVaQWKostKhHdm3l1VLRNkC1M4awUPZDNJ7GHR2iab241Upd7YV2RVrPqxWPW9PjIUMiRveBGTlSRsG8yjBF6iGrzwhJgFAX1/4BJJDv2rDNdTnInOMkQNVD+JS5bpc1UVRqTqb8lNz3eyNmaHx1RPvXHq/DWhToz4/MeWOEw+qLsbDOQCgEmCwCHlwSB/Moqwo9OEDIkUqM5a96iWzkoiTXTKwlCZ97aGWHhA6dBYlJQeBwvI5wtoWcIq6qvthqSupFRgXL5AYqQy5xRs+OEf70NWEre9ezvgoEZilCAuQLB8s9B2imZ69cMD+4ZdzFFQyOWzXTJGuly9TB/HYS+syLqbu9P2Id4USrGcF/EoRocc6J8KsMWZhiuGqFG3PnJ3l4VxEQc7ALE4zJfpihCnpaED2meilOrBakc0R3+Nxec+PTwOSBAfkcsiwuAcfggo0A4VoN4ixHJ7bW3lVfewTGlfnDIML0LqW5kydJPJ/hH2kXvjcqo+y7MVCjeelW4qcHQZGWb6Zh9TMFQiBXQZ6vdN4MTqNfAFfqAgzssD58= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8987df46-5fd2-4ae5-c92c-08db4bfcf6e1 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 17:36:45.3250 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2wkg5dfYukcSrV4rL4LfSDE2+CUE3+NDQZxbtMpdxUdw21EBC3MabB2HfJqsfj47web0djbWDueemVLzZPQtBQAg6i036xMNWkFfUdbKQbk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6616 On 17/04/2023 2:53 pm, Sergey Dyasli wrote: > Add an option to xen-ucode tool to print the currently loaded ucode > revision and also print it during usage info. Print CPU signature and > platform flags as well. The raw data comes from XENPF_get_cpu_version > and XENPF_get_ucode_revision platform ops. > > Example output: > Intel: CPU signature 06-55-04 (raw 0x00050654) pf 0x1 revision 0x02006e05 > AMD: CPU signature 19-01-01 (raw 0x00a00f11) revision 0x0a0011ce > > Signed-off-by: Sergey Dyasli Acked-by: Andrew Cooper This is good enough for now.  Incremental improvements can follow up. From xen-devel-bounces@lists.xenproject.org Wed May 03 17:44:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 17:44:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529414.823824 (Exim 4.92) (envelope-from ) id 1puGW4-0008Gc-M0; Wed, 03 May 2023 17:43:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529414.823824; Wed, 03 May 2023 17:43:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puGW4-0008GV-IN; Wed, 03 May 2023 17:43:48 +0000 Received: by outflank-mailman (input) for mailman id 529414; Wed, 03 May 2023 17:43:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puGW3-0008GP-Qx for xen-devel@lists.xenproject.org; Wed, 03 May 2023 17:43:47 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puGW3-0001DY-6Q; Wed, 03 May 2023 17:43:47 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[192.168.7.72]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1puGW2-0004EE-SN; Wed, 03 May 2023 17:43:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=MqtxypmUk17dKd0G1AXzSt7RuNsLGclS8MiMovjho+0=; b=e6XZocs5E9HLnhipQ/5hjf1KrZ ZKN6VUuZcy6CGZTFtwE4Kyimdoh984dANucEPTMdKEqRIcZga2c96cu2hYzO5MKBOcsjbHo1l9k4r ApbepXV5zplE+QlFtiSY5sCr4ZeaCYa6FPOFHglHD9Bp/Gsxtxs3au/TratNBiLUh9sk=; Message-ID: <556611a5-dc9a-8155-650d-327b6853f761@xen.org> Date: Wed, 3 May 2023 18:43:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [RFC PATCH] xen/arm: arm32: Enable smpboot on Arm32 based systems Content-Language: en-US To: Ayan Kumar Halder , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com References: <20230502105849.40677-1-ayan.kumar.halder@amd.com> <2d764f29-2eb9-ecff-84cd-9baf12961c54@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Ayan, On 03/05/2023 17:49, Ayan Kumar Halder wrote: > > On 03/05/2023 08:40, Julien Grall wrote: >> Hi, > Hi Julien, >> >> Title: Did you mean "Enable spin table"? > Yes, that would be more concrete. >> >> On 02/05/2023 11:58, Ayan Kumar Halder wrote: >>> On some of the Arm32 based systems (eg Cortex-R52), smpboot is >>> supported. >> >> Same here. > Yes >> >>> In these systems PSCI may not always be supported. In case of >>> Cortex-R52, there >>> is no EL3 or secure mode. Thus, PSCI is not supported as it requires >>> EL3. >>> >>> Thus, we use 'spin-table' mechanism to boot the secondary cpus. The >>> primary >>> cpu provides the startup address of the secondary cores. This address is >>> provided using the 'cpu-release-addr' property. >>> >>> To support smpboot, we have copied the code from >>> xen/arch/arm/arm64/smpboot.c >> >> I would rather prefer if we don't duplicate the code but instead move >> the logic in common code. > Ack >> >>> with the following changes :- >>> >>> 1. 'enable-method' is an optional property. Refer to the comment in >>> https://www.kernel.org/doc/Documentation/devicetree/bindings/arm/cpus.yaml >>> "      # On ARM 32-bit systems this property is optional" >> >> Looking at this list, "spin-table" doesn't seem to be supported >> for 32-bit systems. > > However, looking at > https://developer.arm.com/documentation/den0013/d/Multi-core-processors/Booting-SMP-systems/SMP-boot-in-Linux , it seems "spin-table" is a valid boot mechanism for Armv7 cpus. I am not able to find the associated code in Linux 32-bit. Do you have any pointer? > > >> Can you point me to the discussion/patch where this would be added? > > Actually, this is the first discussion I am having with regards to > adding a "spin-table" support on Arm32. I was asking for the discussion on the Device-Tree/Linux ML or code. I don't really want to do a "spin-table" support if this is not even supported in Linux. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 03 17:46:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 17:46:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529416.823834 (Exim 4.92) (envelope-from ) id 1puGYC-0000Qj-11; Wed, 03 May 2023 17:46:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529416.823834; Wed, 03 May 2023 17:45:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puGYB-0000Qc-UJ; Wed, 03 May 2023 17:45:59 +0000 Received: by outflank-mailman (input) for mailman id 529416; Wed, 03 May 2023 17:45:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puGYA-0000QS-Gs; Wed, 03 May 2023 17:45:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puGYA-0001H4-FH; Wed, 03 May 2023 17:45:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puGYA-0000F1-3C; Wed, 03 May 2023 17:45:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1puGYA-0001Am-2d; Wed, 03 May 2023 17:45:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=yG2gX4m8SPgzFxt09UFUplBjhrvtZSdRomfzn7CSzac=; b=09Gk4UhEh4kspzgLf/s9YSAiiV 2HUel732nZec5HJ1RG5BuvGNB0eT5a6jd2eBcV4BACogpLQSyUPMgmcTdnmTXTe1bdqt+6GCLms4C uG2WcX1k874ch+xe8YSlBA1NwdM5ojbkp5sHugquJDVAHEUmMINqRU4VQcCc4vzSZLeg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 180513: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=b4f5e6c91b9871173de205f81b51cf06a833fcb1 X-Osstest-Versions-That: libvirt=844a3b48d6161560eddc1e1f85719b67659f1ea9 From: osstest service owner Date: Wed, 03 May 2023 17:45:58 +0000 flight 180513 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/180513/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 180479 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 180479 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 180479 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: libvirt b4f5e6c91b9871173de205f81b51cf06a833fcb1 baseline version: libvirt 844a3b48d6161560eddc1e1f85719b67659f1ea9 Last test of basis 180479 2023-04-29 04:20:19 Z 4 days Testing same since 180513 2023-05-03 04:18:50 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jiri Denemark Peter Krempa Shaleen Bathla Tim Shearer jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 844a3b48d6..b4f5e6c91b b4f5e6c91b9871173de205f81b51cf06a833fcb1 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed May 03 17:51:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 17:51:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529424.823844 (Exim 4.92) (envelope-from ) id 1puGd5-0001vw-Nx; Wed, 03 May 2023 17:51:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529424.823844; Wed, 03 May 2023 17:51:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puGd5-0001vp-Kc; Wed, 03 May 2023 17:51:03 +0000 Received: by outflank-mailman (input) for mailman id 529424; Wed, 03 May 2023 17:51:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puGd4-0001vf-NN; Wed, 03 May 2023 17:51:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puGd4-0001MC-It; Wed, 03 May 2023 17:51:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puGd4-0000S0-2d; Wed, 03 May 2023 17:51:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1puGd4-0002wd-29; Wed, 03 May 2023 17:51:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MsiWno7UsTjhI/mSnDzGVdjJifgINL2VW4bzZfnD9gk=; b=AvUrIoXrYtafWCnH+j73cC2M3W Eg2sXcNhbK5dorBkdAN7z5Iuzb+evSEGKCEk0eknPzOnGuOwW3Z+ldU1xoW5H41W56HtmBmWQDRVx bub082P2SjgB9c5ak9QCZuru5DmIBKgjyMKCOk7opb+/j0keHW9Uf34Zvnuw80SxxiXo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 180518: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=99a9c3d7141063ae3f357892c6181cfa3be8a280 X-Osstest-Versions-That: xen=0956aa2219745a198bb6a0a99e2108a3c09b280e From: osstest service owner Date: Wed, 03 May 2023 17:51:02 +0000 flight 180518 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/180518/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 99a9c3d7141063ae3f357892c6181cfa3be8a280 baseline version: xen 0956aa2219745a198bb6a0a99e2108a3c09b280e Last test of basis 180517 2023-05-03 12:01:56 Z 0 days Testing same since 180518 2023-05-03 15:00:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Jan Beulich Olaf Hering Viresh Kumar jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 0956aa2219..99a9c3d714 99a9c3d7141063ae3f357892c6181cfa3be8a280 -> smoke From xen-devel-bounces@lists.xenproject.org Wed May 03 17:54:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 17:54:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529429.823854 (Exim 4.92) (envelope-from ) id 1puGgG-0002Vf-6W; Wed, 03 May 2023 17:54:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529429.823854; Wed, 03 May 2023 17:54:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puGgG-0002VY-3h; Wed, 03 May 2023 17:54:20 +0000 Received: by outflank-mailman (input) for mailman id 529429; Wed, 03 May 2023 17:54:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puGgF-0002VS-Ew for xen-devel@lists.xenproject.org; Wed, 03 May 2023 17:54:19 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 86135c70-e9db-11ed-b225-6b7b168915f2; Wed, 03 May 2023 19:54:18 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BE40260F7B; Wed, 3 May 2023 17:54:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3FBB9C433EF; Wed, 3 May 2023 17:54:15 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 86135c70-e9db-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683136456; bh=pYSY+/3DUBT8zv91GwZKnPhkAlej1WQJEZ6BUC42DsM=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=ZbZQB4SU/VtM5irjWc60DW7lyHBSM0kf8mCFsv9LbYSgD/tyhYNdsg+aOhQbUks5x q4pV+8YX+xd+98Jb/GYDyCrJqD5g0UADxB+gXs7d0NHl96NUjKgzBb9U6o+nTyjGSv rXJe86FOc1K+W4CcqdFFDqdYdQMy8M1ZPp6e5G8nemHjOEgeQyk3brd0zJJwmzwmtD J3YKxomKeQBxJG/9K9WGid1hvJyLgmE6jvQrn4NA8/9RQ4Rxj15ZlB6OdumfaarL60 lrPr8pyrYVKNuovx1NIgmu2/2pU7i582EsytVw/Yy/c4NySIkdXeUYzcF7xfpSdl+J YNDGQFZnFpD2g== Date: Wed, 3 May 2023 10:54:12 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Stefano Stabellini , Ayan Kumar Halder , xen-devel@lists.xenproject.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com Subject: Re: [RFC PATCH] xen/arm: arm32: Enable smpboot on Arm32 based systems In-Reply-To: Message-ID: References: <20230502105849.40677-1-ayan.kumar.halder@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 3 May 2023, Julien Grall wrote: > Hi Stefano, > > On 03/05/2023 00:55, Stefano Stabellini wrote: > > > + { > > > + printk("CPU%d: No release addr\n", cpu); > > > + return -ENODEV; > > > + } > > > + > > > + release = ioremap_nocache(cpu_release_addr[cpu], 4); > > > + if ( !release ) > > > + { > > > + dprintk(XENLOG_ERR, "CPU%d: Unable to map release address\n", > > > cpu); > > > + return -EFAULT; > > > + } > > > + > > > + writel(__pa(init_secondary), release); > > > + > > > + iounmap(release); > > > > I think we need a wmb() ? > > I am not sure why we would need a wmb() here. The code does: writel(__pa(init_secondary), release); iounmap sev(); I was thinking of trying to make sure the write is completed before issuing a sev(). Technically it is possible for the CPU to reorder the sev() before the write as there is no explicit dependency between the two? > Instead, looking at the Linux > version, I think we are missing a cache flush (so does on arm64) which would > be necessary if the CPU waiting for the release doesn't have cache enabled. I thought about it as well but here the patch is calling ioremap_nocache(), so cache flushes should not be needed? From xen-devel-bounces@lists.xenproject.org Wed May 03 18:19:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 18:19:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529444.823864 (Exim 4.92) (envelope-from ) id 1puH46-00056B-5a; Wed, 03 May 2023 18:18:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529444.823864; Wed, 03 May 2023 18:18:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puH46-000564-1k; Wed, 03 May 2023 18:18:58 +0000 Received: by outflank-mailman (input) for mailman id 529444; Wed, 03 May 2023 18:18:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puH45-00055y-FP for xen-devel@lists.xenproject.org; Wed, 03 May 2023 18:18:57 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puH45-00022g-2c; Wed, 03 May 2023 18:18:57 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[192.168.7.72]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1puH44-00063p-RC; Wed, 03 May 2023 18:18:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=NNhvbZyBNIyCOxi54PjONIH+ezlsZypVpRL/LqBtjNg=; b=IwgPIXVtPteAOIbwzng4iPF4rZ bvCXgThwiPL5y8QvsEEuctIz6MJMA35rndKy5MbM01n7t61qatHpZb/R7ZfGLaJfMF4sMolYam5qZ BMWyn1nNDXtuE3LWOG2mH2/Y6WOuj+2/AcA2GF8kBXcE+2Eaqw/7bI0QxApr4aIITP4g=; Message-ID: Date: Wed, 3 May 2023 19:18:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [RFC PATCH] xen/arm: arm32: Enable smpboot on Arm32 based systems Content-Language: en-US To: Stefano Stabellini Cc: Ayan Kumar Halder , xen-devel@lists.xenproject.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com References: <20230502105849.40677-1-ayan.kumar.halder@amd.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Stefano, On 03/05/2023 18:54, Stefano Stabellini wrote: > On Wed, 3 May 2023, Julien Grall wrote: >> Hi Stefano, >> >> On 03/05/2023 00:55, Stefano Stabellini wrote: >>>> + { >>>> + printk("CPU%d: No release addr\n", cpu); >>>> + return -ENODEV; >>>> + } >>>> + >>>> + release = ioremap_nocache(cpu_release_addr[cpu], 4); >>>> + if ( !release ) >>>> + { >>>> + dprintk(XENLOG_ERR, "CPU%d: Unable to map release address\n", >>>> cpu); >>>> + return -EFAULT; >>>> + } >>>> + >>>> + writel(__pa(init_secondary), release); >>>> + >>>> + iounmap(release); >>> >>> I think we need a wmb() ? >> >> I am not sure why we would need a wmb() here. > > The code does: > > writel(__pa(init_secondary), release); > iounmap > sev(); > > I was thinking of trying to make sure the write is completed before > issuing a sev(). Technically it is possible for the CPU to reorder the > sev() before the write as there is no explicit dependency between the > two? I would assume that iounmap() would contain an wmb(). But I guess this is not something we should rely on. > >> Instead, looking at the Linux >> version, I think we are missing a cache flush (so does on arm64) which would >> be necessary if the CPU waiting for the release doesn't have cache enabled. > > I thought about it as well but here the patch is calling > ioremap_nocache(), so cache flushes should not be needed? Hmmm... You are right, we are using ioremap_nocache(). I got confused because Linux is using ioremap_cache(). I am now wondering whether we are using the correct helper. AFAIU, spin table is part of the reserved memory section in the Device-Tree. From section 5.3 in [1], the memory could be mapped cacheable by the other end. So for correctness, it seems to me that we would need to use ioremap_cache() + cache flush. BTW, writel_relaxed() should be sufficient here as there is no ordering necessary with any previous write. Cheers, [1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3 -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 03 18:37:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 18:37:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529447.823874 (Exim 4.92) (envelope-from ) id 1puHLe-0007W7-MM; Wed, 03 May 2023 18:37:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529447.823874; Wed, 03 May 2023 18:37:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puHLe-0007W0-JX; Wed, 03 May 2023 18:37:06 +0000 Received: by outflank-mailman (input) for mailman id 529447; Wed, 03 May 2023 18:26:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puHBn-0006ZA-Gs for xen-devel@lists.xenproject.org; Wed, 03 May 2023 18:26:55 +0000 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1221fb74-e9e0-11ed-b225-6b7b168915f2; Wed, 03 May 2023 20:26:52 +0200 (CEST) Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 May 2023 11:14:32 -0700 Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga008.fm.intel.com with ESMTP; 03 May 2023 11:14:31 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 3 May 2023 11:14:31 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 3 May 2023 11:14:31 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 3 May 2023 11:14:31 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.176) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 3 May 2023 11:14:30 -0700 Received: from BYAPR11MB3320.namprd11.prod.outlook.com (2603:10b6:a03:18::25) by BN9PR11MB5529.namprd11.prod.outlook.com (2603:10b6:408:102::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Wed, 3 May 2023 18:14:28 +0000 Received: from BYAPR11MB3320.namprd11.prod.outlook.com ([fe80::a0e0:efa7:eda3:b36b]) by BYAPR11MB3320.namprd11.prod.outlook.com ([fe80::a0e0:efa7:eda3:b36b%6]) with mapi id 15.20.6340.031; Wed, 3 May 2023 18:14:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1221fb74-e9e0-11ed-b225-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683138412; x=1714674412; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=YU1LpqW36QSHkB5/jJBCAPcOaEJjCOlcwEq4cJabuDE=; b=NIJrpZ1nl7ilNw570AgiH8u45EuwVQrgX6BRoH5zYo3ddmWpP9SDuJcn 5wGPDcblT4zhfReqimwa5oJQux3Glg77RWzAlhBoQdRvyPFTZ+cgZ5w65 YsiynqCF45lj6IhguEnPR0K1pG0tFc3Tx39rsLkMNg4lCNsLRV4mtVeZr vPP4VGBbt6u/+6C0tI55LEJxQf+Rl25KH9WfVvf4UlJ/tNBo5s480KlYk SIkhiYk4Sk6MHvYKbMC5eOsGDqkHG2lW42SyrUpO2R6P6uBmGKsgUHCXl 6y/b3IXY3s+94psKDEllJzUhIVx3YDcyAXu5QE6mYsnbVgj1DqFNfIoG7 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10699"; a="347551839" X-IronPort-AV: E=Sophos;i="5.99,248,1677571200"; d="scan'208";a="347551839" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10699"; a="761589777" X-IronPort-AV: E=Sophos;i="5.99,247,1677571200"; d="scan'208";a="761589777" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gTPuKaefgy/ZBI5yTNUOYt0GMYuuLIQiUjXpmenHdINhxGqLze9cIZ9zPCq5YA8j4dJuhi5a4VzI3cyl5cnoe2VP49Zt/wdakJHNTS5eLz8owErWD+nODsbZuUwFhGpZDo8UtYcarQUl+8ttLjNjDdb7M8HWDSKhmGLduc1SgVDdxsGh+/paOrZV7hZIXZmcKZ6oFf/iYDQsDtvQjY4nckax7+8tjdaaJPOQlOcyQP5okZuyJ/RzWlhIx62pnxiZoNo6djMY5jh5i1nw0tHovAGb/a+4162xKDz5c/jaZQScqOAses2uMSmCsRWHkhZ0LNBBGhs9RTS0wI8KsfgeEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=acApguog1hrw9FK2yIo2Pl8uvzK1Ho/Twm/E37M8al4=; b=T+T7MBorv47xi1TIOwGHyMRcmEKDOQVcW0BNGrcJ4It2pq8/VSWC+803n/LbvLlYJ95N7InSprwc7yKA6Gv0w7fZltFvXwgtjxx6NaNeCEknq03Xf5LKhiNpp+BxtYV13P43SDxS6qEAyPiOhvgRv12oHKOU/kDYj4siTaprfcrWRdmdduKKa2HBW68qd8PdC029D+lKIEIDlS00C0uq9q6wBpxIzBP1gVsWJo+7ayOYy6fFIJhQTi5yHfZS1JMCpPtUwDW5Qx6bboKr4xWvbDHQyWiTHMliPYe9q7BCOuRdJdnf7BNXeqaBubM2eK7ifzCXvNHphDgYrEUUelynhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Message-ID: <26e6947c-6c56-d8c0-1baf-1ff006258679@intel.com> Date: Wed, 3 May 2023 11:14:25 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v6 00/16] x86/mtrr: fix handling with PAT but without MTRR To: Juergen Gross CC: , Thomas Gleixner , "Ingo Molnar" , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , "K. Y. Srinivasan" , Haiyang Zhang , "Wei Liu" , Dexuan Cui , Boris Ostrovsky , , "Jonathan Corbet" , Andy Lutomirski , Peter Zijlstra , , , , References: <20230502120931.20719-1-jgross@suse.com> Content-Language: en-US From: Sohil Mehta In-Reply-To: <20230502120931.20719-1-jgross@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SJ0PR05CA0048.namprd05.prod.outlook.com (2603:10b6:a03:33f::23) To BYAPR11MB3320.namprd11.prod.outlook.com (2603:10b6:a03:18::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR11MB3320:EE_|BN9PR11MB5529:EE_ X-MS-Office365-Filtering-Correlation-Id: fd3be5c8-54b9-4457-ca96-08db4c023b98 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hNgUlvKNNJaYjJgnnPrK3FzXCampfuny5QwS+vmt6f2QTBm1OtW4v4FoxRAWr2v3oX/pQ6GNPD9tjH2DacjOJtF+fYMJ7ZKqrGVjxOyQ/iBJNcqUYKpWywvlW9WNfwOtGbf11KIr2L4Wjf0LdRQhFBjWqFU3ut6vFm9r+7t2DVSMijey2HtR8mfakAYSRtjGIMkZfpRQAK6Kr2zOvbIuGsK7DfwlxsYuRCousZF4c5+tXJETZMpVknUeCIlzq5dWExFaM7JTBKHGGayNYgkxLvzaocGhFKhvBYqUXP86/sy2HTNuUXjp3BqQ6WBvknnX7VbD1vv25aUS88bTQ/EgR0bx0RAZEGdR05YEiciZTAKQa4YiNDDIUrHDUZZHRlXeteBm09FZ/PI9OZ7kby99SrNYtZKj+8jYOLe1Nx0zsDKR27rXeUr9s7Zug0EZWYebbcqV0ISZToGiqAiT6VP/C/NDZhygAF4crUWL3vej2SWNT/Cp5JniHptxrxnpaTKYRF/QaGTAXFqDwcKN08px/o0mOdEC0ofUySi/iBX1Fl2SLeDAu16SvLroS7NVSy1r6EMe1g5wuliOexjTbkPHPkT0N8Co713V7/6v/iQ++Tvzp2cxuhYdH/7ZaMtXbj4fpcqHRfKvjm5hbe5AqKwEnw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB3320.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(39860400002)(366004)(346002)(376002)(396003)(451199021)(478600001)(2906002)(316002)(66946007)(66556008)(66476007)(4326008)(6486002)(6666004)(6916009)(82960400001)(36756003)(186003)(41300700001)(6506007)(6512007)(26005)(2616005)(86362001)(38100700002)(54906003)(7416002)(31686004)(8676002)(8936002)(31696002)(44832011)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QkQrTE5vd2lFV2h0TDNacUxjbXhzS3ZYSHlmTzdCRG8wcHArd1ZLK29BNlh0?= =?utf-8?B?eGg3RkNVVkp4eEU0TGxQZHkrYkRkMVJHTnJ3SXFwYmFCbTZqeTIvQnk5aWpK?= =?utf-8?B?ZnF1ZlBsNVR6QnFNRXFGbnhwR2E5QWFBUmsrZzZieWJEbWFHV1lyTlRtQkhI?= =?utf-8?B?S2N5cXNxaVhJUmtPREZwRVNkczRLTUZsMEtkT1F4QXBuWWw5NzUvclpMclZR?= =?utf-8?B?M3luYUsyUUxIT1hwRWlaUm1tc0Y3Zmpjczl6b2Y2YmNsT3Y4Q0ZlTVJrMFp1?= =?utf-8?B?WVltM0R3c2tRTlRUQWl6cW5SZC94bThnMXUySzlMc3lvZFptQkowUXdXZjc1?= =?utf-8?B?SXRIK3hwMWhXUyt6ek1CcWFtdysxZDk0ekUzTDA0Ukt5aFk1RGV1ek1GUWI2?= =?utf-8?B?d240NzRGUmlHMlQyUDk2NURDS2JKamp3cTl3NGZEOVR3S2g3RHlqRTNPcS9l?= =?utf-8?B?MUE1cS8yRTJQeE1ZNW83OUsyQTN0Y2lUbmZoZGpJdFZpN1F0ejUvYSs4Nkxh?= =?utf-8?B?UlQyU1RnQjB4aHVQWTVld2ZKQ1Jac3NBMm5jVzNHdlZUNmt6VEoybkt0Ni9j?= =?utf-8?B?MFVxYjkya2ZpekY0c1A0dmZyOWlWNS9rNU1HNDBSeFQzSkRKdkFEYkovZjlw?= =?utf-8?B?TDNpOXZ3RHNNUzVZZWljMnJuVC91TjFyK3IzNEwxdCtwUlJUbnFKbm5mVHEy?= =?utf-8?B?NmpEc1BvNEphSmRCV0tOSFRLblBLbElYS08yeFc1UUFEVnUyQVh5M0ZrMmxq?= =?utf-8?B?WFZ6dEN3ck1Hd1ZqYkxrSU10UTJqa3RhVmJPeTRRNHVnL3kyV045WEhMamN0?= =?utf-8?B?dXNzYUFYd1hmTEdTbko3TFVtenJZeHJlSXhsNk10UlZ2WWZXTkJrUDJLN2pV?= =?utf-8?B?anNUZ3NKN1NWcFN3QTZZdlRUbEpDVzVMNUJzZ1dXUWVyU2ZXQitxbFFZME4r?= =?utf-8?B?WTVwUzdkSWhyVUd2Tm1KRlh6V3d3MjFadUZ2YUlYeGd5TGZWU1djM3J6U25v?= =?utf-8?B?Mk0vWlBxeVhtYTViV01pbWFEaGxENnc4WDhwNDZaOTMxUENYVDNLanhLNDVP?= =?utf-8?B?akpFemxiWGJ4ZmUxd1VwOVVXd05wSGVuMHBnbGREWFJwR3NBSDJ6Qnl3QXkx?= =?utf-8?B?aGRGSWRhOUprODVrNVEvRzFmQjRPL1NlT2s5UmZ1WFR4SUFYZlJaL1ZCRWpl?= =?utf-8?B?L1VRSWJjT25RN1hwb1hzZnliS0VjYUhhTEMvSVFIRllTSzBSS1F4QWN0bDYz?= =?utf-8?B?ZVBqQTdlaXZ2eWRVcnZwdklJSWpxSUVCVlV6blFyTVk1UWcwNXRDcDNiR0Zv?= =?utf-8?B?ZTZJTTFXZXNIMEpzREdTS0ZJcGI2RFRoYU9rbDg1emljeENoSDdaT0V5U2l3?= =?utf-8?B?a01ZOEZ5U1ZHL1p5T3JzaTBEQlZMZWtUK3VPUG9TdG14eFNtanpxSzZtOFlD?= =?utf-8?B?ZTlIU0kxT0FiNGlhTGNRY2lETnhTM0tGYWowQ1kyd29KT25yZ1FtNmUzVFhC?= =?utf-8?B?b1FNMnpaV3J5ZkVIUVdmS1UwcXdORkNMVko2ZXlEUkJFbm9TYWl4citBTnJY?= =?utf-8?B?c256YkNJUGFPaVdIODBxVkZSZGZaWVFOZnBtWHVST1B1R1Z4azI2RGZIeDJl?= =?utf-8?B?aVViVyswTUZURmdrRGhmd0piYkdOMlhFV0NybFMyTWtIbmcwcjN4NGc2bm5J?= =?utf-8?B?NlhhR0pQSlo0ZnIyV1p2V1Y2Um8zUnhrQkdEa2FJaS8rdDR2eUMrK3VDV0x3?= =?utf-8?B?NENtdEVHUWxqLzJNNVJoZjRKUlhUYmoyTU9iemtSN0lNRVpNZG8xT2dXalJp?= =?utf-8?B?M1pwWk1Nakc4KzdWMU9memdUeUJldkdaV1Z6S29RYzlYUkhFN1lXbHBBZ2xa?= =?utf-8?B?L3NDMHlRb2dQQVoxR0xSWWJjeWNUMXgxN0J0MmtyNlFvME1DY05qTDEvcytm?= =?utf-8?B?Sm82V1NKZUY3WE5ycEEzeXUvNjJzY2dIWEdVUHZSU1kvLytFOXhtSDhFZzZn?= =?utf-8?B?bmFpT05rZk9YSEdqZXRUeDZaazlmdFRPTnZKQWtpRjBTYTBkQURZWUVGbjFM?= =?utf-8?B?NUUvUDFBSjdRanV1T0pKZlV2bEx3cS93QjMvWFFURHhXbmVnQnQ4QzdCWk02?= =?utf-8?Q?ps/1dgk7bcBs1d+wmhSmBhegD?= X-MS-Exchange-CrossTenant-Network-Message-Id: fd3be5c8-54b9-4457-ca96-08db4c023b98 X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 18:14:27.8377 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8ktFFMmqRMunU622QH2XA2R1m6wBuoC/irgg/3W26PGzyAN7jZ4Tz010x8zYpjva6OQxsQ2CxSOtMsk2EVa7oA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5529 X-OriginatorOrg: intel.com > Juergen Gross (16): > x86/mtrr: remove physical address size calculation > x86/mtrr: replace some constants with defines > x86/mtrr: support setting MTRR state for software defined MTRRs > x86/hyperv: set MTRR state when running as SEV-SNP Hyper-V guest > x86/xen: set MTRR state when running as Xen PV initial domain > x86/mtrr: replace vendor tests in MTRR code > x86/mtrr: have only one set_mtrr() variant > x86/mtrr: move 32-bit code from mtrr.c to legacy.c > x86/mtrr: allocate mtrr_value array dynamically > x86/mtrr: add get_effective_type() service function > x86/mtrr: construct a memory map with cache modes > x86/mtrr: add mtrr=debug command line option > x86/mtrr: use new cache_map in mtrr_type_lookup() > x86/mtrr: don't let mtrr_type_lookup() return MTRR_TYPE_INVALID > x86/mm: only check uniform after calling mtrr_type_lookup() > x86/mtrr: remove unused code > A Nit -> Documentation/process/maintainer-tip.rst suggests: "The condensed patch description in the subject line should start with a uppercase letter and ..." -Sohil From xen-devel-bounces@lists.xenproject.org Wed May 03 18:58:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 18:58:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529455.823884 (Exim 4.92) (envelope-from ) id 1puHgL-0001X2-Ck; Wed, 03 May 2023 18:58:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529455.823884; Wed, 03 May 2023 18:58:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puHgL-0001Wv-9i; Wed, 03 May 2023 18:58:29 +0000 Received: by outflank-mailman (input) for mailman id 529455; Wed, 03 May 2023 18:58:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puHgJ-0001Wp-Sn for xen-devel@lists.xenproject.org; Wed, 03 May 2023 18:58:28 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7a7728d0-e9e4-11ed-b226-6b7b168915f2; Wed, 03 May 2023 20:58:25 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7a7728d0-e9e4-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683140305; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=TZ0uzHXRe5NFf4mFFjml7I3UzuX0lFxn2xNYPMCq6gY=; b=a2QIiL5KdIyMuroyjjK4+MXSGFEJrKCyxdl/o1kLvWMN8s4I4ueCjYP4 hCIxpASNXch9cBuWjPq7TbUVUQm3jqQuT/IR3X2LtedyIa8D522MjNqlc poCq2jo6+9VHIpr75H0oSgbw+btwuw0iL5hx6j87QVvK8IGFpIjc7hrUu E=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 110204666 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:8svK163+VERbbQF1EPbD5atxkn2cJEfYwER7XKvMYLTBsI5bpzMFx mAbWDvTaPePazb1L951OYS2pk8Gvp6Hx9I3Hlc4pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS+XuDgNyo4GlD5gFmPqgQ1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfDGhBx P40JyI0X1OGl9Ob7L/mb+J+mZF2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP ZNfMGcxKk2aOHWjOX9OYH46tM6uimPybHtzr1WNqLBsy2PS0BZwwP7mN9+9ltmiHJwNxB7E+ DyYl4j/KjQBJMSazzPYyy2Pr8PMrA/cdZ0dJqLto5aGh3XMnzdOWXX6T2CTvv2RmkO4HdVFJ CQ86ico6KQ/6kGvZt38RAGj5m6JuAYGXNhdGPF87xuCooL2yQuEAmkPThZadccr8sQxQFQXO kShxo2zQ2Y16fvMFCzbr+3Pxd+vBcQLBWILah4GYQQX2uigpZECoz7CE/NoArHg27UZBgrML yC2QDkW3utD1pZSjfXkojgrkBr3+MGXE1ddChH/Gzv8s1gnPNPNi5mAswCz0BpWEGqOorBtV lAgktPW0u0BBIrleMelELRUR+HBCxpo3VThbb9T83oJrW7FF4aLJ9w43d2EGG9nM9wfZRjia 1LJtAVa6fd7ZSX6NvcqON/oUZ5zncAM8OjYug38NIISMvCdiifelM2RWaJg9z+0yxV9+U3OE ZyabdytHR4nNEiT9xLvH711+eZylkgDKZb7GciT5w65yoCXeHP9Ye5DaDNimMhltvLbyOgUm v4DX/a3J+J3CbCnPnWKqtZMdTjn7xETXPjLliCeTcbbSiIOJY3rI6W5LW8JE2C9o5loqw== IronPort-HdrOrdr: A9a23:5hNiYKgNQUymdnn2984wpRfx6XBQXuQji2hC6mlwRA09TyX4ra GTdZEgvnXJYVkqKRIdcLy7VZVoOEmsk6KdgrN+AV7BZmXbUQKTRelfBeGL+UyYJ8SUzIFgPM lbE5SXBLXLfDpHZcuT2njeLz4rqOP3lZxBio/lvhNQcT0= X-Talos-CUID: 9a23:RltK3GEu6OG/keIfqmJq/UElGOwqYETsj3LAEmKUBDtMQ6+KHAo= X-Talos-MUID: 9a23:Yh4tvwVtzxDBkFbq/Br3lClnMs412vuNIWwOoLkhltaLBzMlbg== X-IronPort-AV: E=Sophos;i="5.99,248,1677560400"; d="scan'208";a="110204666" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH] x86/ucode: Refresh raw CPU policy after microcode load Date: Wed, 3 May 2023 19:58:13 +0100 Message-ID: <20230503185813.3050382-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Loading microcode can cause new features to appear. This has happened routinely since Spectre/Meltdown, and even the presence of new status bits can mean the administrator has no further work to perform. Refresh the raw CPU policy after late microcode load, so xen-cpuid can reflect the updated state of the system. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu This is also the first step of being able to livepatch support for new functionality in microcode. --- xen/arch/x86/cpu-policy.c | 6 +++--- xen/arch/x86/cpu/microcode/core.c | 4 ++++ xen/arch/x86/include/asm/cpu-policy.h | 6 ++++++ 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/cpu-policy.c b/xen/arch/x86/cpu-policy.c index a58bf6cad54e..ef6a2d0d180a 100644 --- a/xen/arch/x86/cpu-policy.c +++ b/xen/arch/x86/cpu-policy.c @@ -15,7 +15,7 @@ #include #include -struct cpu_policy __ro_after_init raw_cpu_policy; +struct cpu_policy __read_mostly raw_cpu_policy; struct cpu_policy __ro_after_init host_cpu_policy; #ifdef CONFIG_PV struct cpu_policy __ro_after_init pv_max_cpu_policy; @@ -343,7 +343,7 @@ static void recalculate_misc(struct cpu_policy *p) } } -static void __init calculate_raw_policy(void) +void calculate_raw_cpu_policy(void) { struct cpu_policy *p = &raw_cpu_policy; @@ -655,7 +655,7 @@ static void __init calculate_hvm_def_policy(void) void __init init_guest_cpu_policies(void) { - calculate_raw_policy(); + calculate_raw_cpu_policy(); calculate_host_policy(); if ( IS_ENABLED(CONFIG_PV) ) diff --git a/xen/arch/x86/cpu/microcode/core.c b/xen/arch/x86/cpu/microcode/core.c index 61cd36d601d6..cd456c476fbf 100644 --- a/xen/arch/x86/cpu/microcode/core.c +++ b/xen/arch/x86/cpu/microcode/core.c @@ -34,6 +34,7 @@ #include #include +#include #include #include #include @@ -677,6 +678,9 @@ static long cf_check microcode_update_helper(void *data) spin_lock(µcode_mutex); microcode_update_cache(patch); spin_unlock(µcode_mutex); + + /* Refresh the raw CPU policy, in case the features have changed. */ + calculate_raw_cpu_policy(); } else microcode_free_patch(patch); diff --git a/xen/arch/x86/include/asm/cpu-policy.h b/xen/arch/x86/include/asm/cpu-policy.h index b361537a602b..99d5a8e67eeb 100644 --- a/xen/arch/x86/include/asm/cpu-policy.h +++ b/xen/arch/x86/include/asm/cpu-policy.h @@ -24,4 +24,10 @@ void init_dom0_cpuid_policy(struct domain *d); /* Clamp the CPUID policy to reality. */ void recalculate_cpuid_policy(struct domain *d); +/* + * Collect the raw CPUID and MSR values. Called during boot, and after late + * microcode loading. + */ +void calculate_raw_cpu_policy(void); + #endif /* X86_CPU_POLICY_H */ -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed May 03 19:13:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 19:13:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529460.823894 (Exim 4.92) (envelope-from ) id 1puHuS-0003zq-Os; Wed, 03 May 2023 19:13:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529460.823894; Wed, 03 May 2023 19:13:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puHuS-0003zj-M3; Wed, 03 May 2023 19:13:04 +0000 Received: by outflank-mailman (input) for mailman id 529460; Wed, 03 May 2023 19:13:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puHuR-0003zd-T9 for xen-devel@lists.xenproject.org; Wed, 03 May 2023 19:13:04 +0000 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 86470aff-e9e6-11ed-b226-6b7b168915f2; Wed, 03 May 2023 21:13:02 +0200 (CEST) Received: from zn.tnic (p5de8e8ea.dip0.t-ipconnect.de [93.232.232.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id B681A1EC0674; Wed, 3 May 2023 21:13:01 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 86470aff-e9e6-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1683141181; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=L/8fxhHQV9gUmxp73tGqFoK9bK/rX7AQ4vVPU8ZIH0I=; b=KcU0BTLrM12dhsRj+QLZSG0/+RmUKUiYJfiYee8JlzdiNbgVFD/LmgeqgPH66sbzspCphX bqQXAAnTIVKkGkWa5UKHtB5PoYSIhviQ5VRtBo8QE52D5xzSpgI5rqz3rUcKRpD07YdiXO lnMXaXWkqPpgYFEw1Wfi0/RkoaQnTVI= Date: Wed, 3 May 2023 21:12:56 +0200 From: Borislav Petkov To: Sohil Mehta Cc: Juergen Gross , mikelley@microsoft.com, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Boris Ostrovsky , xen-devel@lists.xenproject.org, Jonathan Corbet , Andy Lutomirski , Peter Zijlstra , linux-kernel@vger.kernel.org, x86@kernel.org, linux-hyperv@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v6 00/16] x86/mtrr: fix handling with PAT but without MTRR Message-ID: <20230503191256.GGZFKyOLi12JS/HuXD@fat_crate.local> References: <20230502120931.20719-1-jgross@suse.com> <26e6947c-6c56-d8c0-1baf-1ff006258679@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <26e6947c-6c56-d8c0-1baf-1ff006258679@intel.com> On Wed, May 03, 2023 at 11:14:25AM -0700, Sohil Mehta wrote: > A Nit -> Documentation/process/maintainer-tip.rst suggests: > "The condensed patch description in the subject line should start with a > uppercase letter and ..." Yeah, good point. But my patch massaging script does that automatically so no need to resend. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Wed May 03 19:17:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 19:17:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529462.823904 (Exim 4.92) (envelope-from ) id 1puHyk-0004cP-A4; Wed, 03 May 2023 19:17:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529462.823904; Wed, 03 May 2023 19:17:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puHyk-0004cI-72; Wed, 03 May 2023 19:17:30 +0000 Received: by outflank-mailman (input) for mailman id 529462; Wed, 03 May 2023 19:17:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puHyi-0004cC-S7 for xen-devel@lists.xenproject.org; Wed, 03 May 2023 19:17:28 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 233d47f7-e9e7-11ed-8611-37d641c3527e; Wed, 03 May 2023 21:17:26 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D970B62E8D; Wed, 3 May 2023 19:17:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C610C433EF; Wed, 3 May 2023 19:17:23 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 233d47f7-e9e7-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683141444; bh=7DLf9DxLpQdqFGhYy5M9J4sQ9tSCqG3t+rA1StCLhlE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=X2aXxT9thLirWjWcV+6M+Oxq5/YD6oX9/Qx5urINHMTXMUQhcMGdkcEujr/7dW5nS HDdde+bRtr6mbyytXFEZeckeHlz6pzb2CODhRQlyib0PZAo3vbYBhuVgAuRPB0y2Ul ctGdK8twVJgdncY33MFr9HSeZEvgY2xK7OEtCEDSsuJ6z/A5FAUFZuZb9KdMfDxKT1 VIDduja2BhCfwXLTOe4mmyckv1ZGuSPxD/PTO0tDppenqGoseYjkOpqHKNWnCKaMQk iWBfzc7zXSUAsC+WiUm7kRTQS5fqP0hqXhmiXUVBzwSszn2oGBYH9zZf8FjRdMsxpm XCkga0NTgR6PA== Date: Wed, 3 May 2023 12:17:21 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Stefano Stabellini , Ayan Kumar Halder , xen-devel@lists.xenproject.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com Subject: Re: [RFC PATCH] xen/arm: arm32: Enable smpboot on Arm32 based systems In-Reply-To: Message-ID: References: <20230502105849.40677-1-ayan.kumar.halder@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 3 May 2023, Julien Grall wrote: > Hi Stefano, > > On 03/05/2023 18:54, Stefano Stabellini wrote: > > On Wed, 3 May 2023, Julien Grall wrote: > > > Hi Stefano, > > > > > > On 03/05/2023 00:55, Stefano Stabellini wrote: > > > > > + { > > > > > + printk("CPU%d: No release addr\n", cpu); > > > > > + return -ENODEV; > > > > > + } > > > > > + > > > > > + release = ioremap_nocache(cpu_release_addr[cpu], 4); > > > > > + if ( !release ) > > > > > + { > > > > > + dprintk(XENLOG_ERR, "CPU%d: Unable to map release address\n", > > > > > cpu); > > > > > + return -EFAULT; > > > > > + } > > > > > + > > > > > + writel(__pa(init_secondary), release); > > > > > + > > > > > + iounmap(release); > > > > > > > > I think we need a wmb() ? > > > > > > I am not sure why we would need a wmb() here. > > > > The code does: > > > > writel(__pa(init_secondary), release); > > iounmap > > sev(); > > > > I was thinking of trying to make sure the write is completed before > > issuing a sev(). Technically it is possible for the CPU to reorder the > > sev() before the write as there is no explicit dependency between the > > two? > > I would assume that iounmap() would contain an wmb(). But I guess this is not > something we should rely on. > > > > > > Instead, looking at the Linux > > > version, I think we are missing a cache flush (so does on arm64) which > > > would > > > be necessary if the CPU waiting for the release doesn't have cache > > > enabled. > > > > I thought about it as well but here the patch is calling > > ioremap_nocache(), so cache flushes should not be needed? > > Hmmm... You are right, we are using ioremap_nocache(). I got confused because > Linux is using ioremap_cache(). I am now wondering whether we are using the > correct helper. > > AFAIU, spin table is part of the reserved memory section in the Device-Tree. > From section 5.3 in [1], the memory could be mapped cacheable by the other > end. So for correctness, it seems to me that we would need to use > ioremap_cache() + cache flush. Good point > BTW, writel_relaxed() should be sufficient here as there is no ordering > necessary with any previous write. From xen-devel-bounces@lists.xenproject.org Wed May 03 19:18:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 19:18:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529465.823914 (Exim 4.92) (envelope-from ) id 1puHzq-0005A8-L2; Wed, 03 May 2023 19:18:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529465.823914; Wed, 03 May 2023 19:18:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puHzq-0005A1-HQ; Wed, 03 May 2023 19:18:38 +0000 Received: by outflank-mailman (input) for mailman id 529465; Wed, 03 May 2023 19:18:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puHzp-00059b-7E for xen-devel@lists.xenproject.org; Wed, 03 May 2023 19:18:37 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on20603.outbound.protection.outlook.com [2a01:111:f400:7eaa::603]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4a27939c-e9e7-11ed-8611-37d641c3527e; Wed, 03 May 2023 21:18:32 +0200 (CEST) Received: from DS7PR05CA0005.namprd05.prod.outlook.com (2603:10b6:5:3b9::10) by SA1PR12MB7224.namprd12.prod.outlook.com (2603:10b6:806:2bb::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Wed, 3 May 2023 19:18:28 +0000 Received: from DM6NAM11FT012.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b9:cafe::62) by DS7PR05CA0005.outlook.office365.com (2603:10b6:5:3b9::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.20 via Frontend Transport; Wed, 3 May 2023 19:18:28 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT012.mail.protection.outlook.com (10.13.173.109) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.26 via Frontend Transport; Wed, 3 May 2023 19:18:27 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 3 May 2023 14:18:27 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 3 May 2023 12:18:27 -0700 Received: from ubuntu.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 3 May 2023 14:18:26 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a27939c-e9e7-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=awTPgLlZQFHMVZe1jqiHifPCm8RPkQCeWRvL5+7vFylfx/Qc4fHKrVoYF4MT7t902wAO/JZ8nCAQJFDiZ5PuRlA0tIJ1aFslSWdI46ZYUjfW74J2iVSXooFf0sckF3x2LkpUod/o1cgN4cExgGEtQ1XNjev1Te88h9yAvm7jM9kDBsjwNXva+RPSUii3Vq46VUhKWIVvjcP3h5fH3jWpQ4nsHzMFuwlTsZqkFmea2lfQlquGNwaZ6ZUMb0IJcdi7wrKvlFA75knPMusqAGTGvSFomprvILqORQD62VNGT/ZTeMl5qPT9pASJ1vJG/Eo/euGT6igFJCJn+eSAIJeeZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nJnGX5ULMa6JNgalgwK8aS04dIdQBzShnRt2jL2i2WM=; b=dBGkZW3uDEYItZiwXENNMuP29NYyArq044dWcsaIBOk30Gcyyq6Sm8hgJe+igvXrI5syczxZW6bmbpJ48qEE5MJK9K48RvjCJHWm07Nn42X9y+XkyPvjpAaWHlGLmgM+P4zmqZJkD+zAuH51eFrZ5KRG8OWtvwWAEco35P5SOCmD4/AjPCOkpY+XaIMRfVjckhHlJ3kUuxoUNak7PrQk7Z+K6wc9wYlQaLca6nidah77CngF6Euy6rteU41NoXI/1GCgqMeqxX6YxiXWM56Dd3+tsTFLxTv5gpjIfuUmUx14bIb4Tejy+Y/hyLbNz3qoy1LVyEATLC1/7ozHZ1JSPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nJnGX5ULMa6JNgalgwK8aS04dIdQBzShnRt2jL2i2WM=; b=iVbfvjiGf990ikhmQSB62zpx9UFqw45spyGC5sr8jyqgNTgss+pwDvXiOzzlc2WP7Ztmgi1qPtKFhZ2hKviw/2vkPfF+CMnj8kLPT5eN3tVieGNCA5ULz63MeSStz+k+htK+EoPSLSJtfPI2LkWrgf52eo07FnaC8qXPa+nIm94= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Stewart Hildebrand To: CC: Stewart Hildebrand , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH] xen/arm: pci: fix -Wtype-limits warning in pci-host-common.c Date: Wed, 3 May 2023 15:18:20 -0400 Message-ID: <20230503191820.78322-1-stewart.hildebrand@amd.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT012:EE_|SA1PR12MB7224:EE_ X-MS-Office365-Filtering-Correlation-Id: c09f3d0e-ee97-443d-94ff-08db4c0b2ca7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xgbjipOMaSEIiUtsJGDiIr0b5vaSw45Yifz+cwzKOVYRvB+pb4qlCRBZXphO3BoBtFZDHwD3VKLhevAwIr4m/x+fDxezlXV6sBiVRaxrnQm9WSrGWOzqNqnORhUASH60wcyRNo52QqSnupVdSR0hjT/y3XdDdDCmF/S0XinxoZ513z8wl0UaptjksxLaGkZVH7iqBVOrVS5KiFUvfZfo9T+fElYr3h/Kr1af0iWnoEcvMqUAvqME993AmQaCHdBbRQF/SI0Ny2nU7jUta76MqZ/hh7O+tDvmz8Vrcx+gswLe0dStVXaFmVCpthu2U8XMFWUBZeAz5QvYxREffijn3bLQ8uzFL78UQYUwgU1tiqDx5RAqJh+2yd+NC4+00B4eEJPxpmPKmCItNEGr9SWe87CYWVZwpi+VrFkHSA9kgAjkc9mSMFbZ2qKE+s+c6Ap9HvLEddg43ktzwiaO4/oVfrVwQxfQBrETlgIXDVQyWyl4UGk8yG6sOCo4pGSsJ4f/SzrW4Re6w8lTHdoAlBwuDw9Z0RIRan3MRQlQ/SbKpJ1nxyT4ZjdIMyOhcpsJwi8Z6WqN5VQ94lRWsHfddfs754hF+D79AIroXViI5afBjtkA2Ghxv9I77Yl9JGvENXIPOZ8kS03yFTA543dAVdGr8jfz3aja9IifGK9cis0J1mXySKI2hJOfpcj3k6Lmw/zH6bhwYTLt82a6e0wEureT32bsFUig/d7qavteNMOTi4M= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(39860400002)(376002)(136003)(451199021)(36840700001)(46966006)(40470700004)(36756003)(86362001)(54906003)(316002)(6916009)(4326008)(70206006)(70586007)(6666004)(478600001)(41300700001)(40480700001)(82310400005)(2906002)(5660300002)(8936002)(82740400003)(8676002)(44832011)(81166007)(186003)(356005)(26005)(36860700001)(1076003)(426003)(336012)(47076005)(83380400001)(2616005)(40460700003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 19:18:27.9807 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c09f3d0e-ee97-443d-94ff-08db4c0b2ca7 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT012.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7224 When building with EXTRA_CFLAGS_XEN_CORE="-Wtype-limits", we observe the following warning: arch/arm/pci/pci-host-common.c: In function ‘pci_host_common_probe’: arch/arm/pci/pci-host-common.c:238:26: warning: comparison is always false due to limited range of data type [-Wtype-limits] 238 | if ( bridge->segment < 0 ) | ^ This is due to bridge->segment being an unsigned type. Fix it by introducing a new variable of signed type to use in the condition. Signed-off-by: Stewart Hildebrand --- xen/arch/arm/pci/pci-host-common.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c index a8ece94303ca..7474d877deb8 100644 --- a/xen/arch/arm/pci/pci-host-common.c +++ b/xen/arch/arm/pci/pci-host-common.c @@ -214,6 +214,7 @@ int pci_host_common_probe(struct dt_device_node *dev, struct pci_host_bridge *bridge; struct pci_config_window *cfg; int err; + int domain; if ( dt_device_for_passthrough(dev) ) return 0; @@ -234,12 +235,13 @@ int pci_host_common_probe(struct dt_device_node *dev, bridge->cfg = cfg; bridge->ops = &ops->pci_ops; - bridge->segment = pci_bus_find_domain_nr(dev); - if ( bridge->segment < 0 ) + domain = pci_bus_find_domain_nr(dev); + if ( domain < 0 ) { printk(XENLOG_ERR "Inconsistent \"linux,pci-domain\" property in DT\n"); BUG(); } + bridge->segment = domain; pci_add_host_bridge(bridge); return 0; -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Wed May 03 21:02:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 21:02:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529470.823924 (Exim 4.92) (envelope-from ) id 1puJbb-0008LP-31; Wed, 03 May 2023 21:01:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529470.823924; Wed, 03 May 2023 21:01:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puJba-0008LI-Ug; Wed, 03 May 2023 21:01:42 +0000 Received: by outflank-mailman (input) for mailman id 529470; Wed, 03 May 2023 21:01:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puJba-0008L8-7L; Wed, 03 May 2023 21:01:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puJba-0005nz-1a; Wed, 03 May 2023 21:01:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puJbZ-0001Sd-EI; Wed, 03 May 2023 21:01:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1puJbZ-0004WW-Dp; Wed, 03 May 2023 21:01:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=e5ZzJ1QkxlXcZG8A7Wih1vkuWg1EhJzwMQ+yXbUS0e4=; b=MR4rhn/1Bv/uobRRO6SU0VjJUU 3+G/5mirPAOm2z9lJE5V0Q1GtRJyJrKmdG1BDP6IRxp4qXZZA1tnINXJCC4Z7703Q6YvN+7jHkFu2 GIOSOQ5Dh0bqqrXJIGgHloF4+IT7bcTGjEH/9xud7YCUWWOcjfvgLhmvrEEXNoGjQPg0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 180520: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=b95a72bb5b2df24ff1baaa27920e57947dc97d49 X-Osstest-Versions-That: xen=99a9c3d7141063ae3f357892c6181cfa3be8a280 From: osstest service owner Date: Wed, 03 May 2023 21:01:41 +0000 flight 180520 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/180520/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen b95a72bb5b2df24ff1baaa27920e57947dc97d49 baseline version: xen 99a9c3d7141063ae3f357892c6181cfa3be8a280 Last test of basis 180518 2023-05-03 15:00:25 Z 0 days Testing same since 180520 2023-05-03 18:03:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Sergey Dyasli jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 99a9c3d714..b95a72bb5b b95a72bb5b2df24ff1baaa27920e57947dc97d49 -> smoke From xen-devel-bounces@lists.xenproject.org Wed May 03 21:53:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 21:53:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529475.823934 (Exim 4.92) (envelope-from ) id 1puKPd-0005YZ-U6; Wed, 03 May 2023 21:53:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529475.823934; Wed, 03 May 2023 21:53:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puKPd-0005YS-RM; Wed, 03 May 2023 21:53:25 +0000 Received: by outflank-mailman (input) for mailman id 529475; Wed, 03 May 2023 21:53:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puKPb-0005YG-NW for xen-devel@lists.xenproject.org; Wed, 03 May 2023 21:53:23 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id eb9685cf-e9fc-11ed-b226-6b7b168915f2; Wed, 03 May 2023 23:53:22 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8347B613F1; Wed, 3 May 2023 21:53:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47887C433D2; Wed, 3 May 2023 21:53:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb9685cf-e9fc-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683150799; bh=f5O1HcnIBoGH8WgEsfzB7pRadYy0g18+BTxdPIh3MME=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=F5QzscPRZCEUIpb9lPUcy9f7aruV6lAUiukTjUHOh0KdA3CoTeR3IlWMtOm2bxsfp 8yVyBYh/0xK5FHXSoiAKvjjTR+jNKq8+y8+F//1qk6gOMAY+t66udy6Wn+AGRsj+NZ scRcKn1DrMocRqTl604GxDaDahtTOnlH7Vy8HpjGsj43rd9Gf5sbFVzijtCxuZkc+J 2PcnmnRnQxms0mFVVcvp+v/7DNZWtUCOTl1Uhw+looNOkZ8m+pfGgjEuVZVgY692x3 r0LdAk+d0i3kyj1+oJMWqGtehIF9zAcCg0h0j9LKnhmXPJcRbSaaeFCjCypks7M9ZH 1b2T4OyLI9hwg== Date: Wed, 3 May 2023 14:53:15 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: andrew.cooper3@citrix.com, Stefano Stabellini , alejandro.vallejo@cloud.com, committers@xenproject.org, michal.orzel@amd.com, xen-devel@lists.xenproject.org, Julien Grall , Juergen Gross , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Jan Beulich , =?UTF-8?Q?Edwin_T=C3=B6r=C3=B6k?= Subject: Re: dom0less vs xenstored setup race Was: xen | Failed pipeline for staging | 6a47ba2f In-Reply-To: <28235d38-ad7f-f1bd-f093-bd83f9fd6589@xen.org> Message-ID: References: <644bfbc6939d8_2a49bbb403253f4@gitlab-sidekiq-catchall-v2-78885c497-qxnp2.mail> <28235d38-ad7f-f1bd-f093-bd83f9fd6589@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1599493801-1683150798=:974517" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1599493801-1683150798=:974517 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Wed, 3 May 2023, Julien Grall wrote: > On 03/05/2023 15:38, andrew.cooper3@citrix.com wrote: > > Hello, > > > > After what seems like an unreasonable amount of debugging, we've tracked > > down exactly what is going wrong here. > > > > https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/4219721944 > > > > Of note is the smoke.serial log around: > > > > io: IN 0xffff90fec250 d0 20230503 14:20:42 INTRODUCE (1 233473 1 ) > > obj: CREATE connection 0xffff90fff1f0 > > *** d1 CONN RESET req_cons 00000000, req_prod 0000003a rsp_cons > > 00000000, rsp_prod 00000000 > > io: OUT 0xffff9105cef0 d0 20230503 14:20:42 WATCH_EVENT > > (@introduceDomain domlist ) > > > > XS_INTRODUCE (in C xenstored at least, not checked O yet) always > > clobbers the ring pointers.  The added pressure on dom0 that the > > xensconsoled adds with it's 4M hypercall bounce buffer occasionally > > defers xenstored long enough that the XS_INTRODUCE clobbers the first > > message that dom1 wrote into the ring. > > > > The other behaviour seen was xenstored observing a header looking like this: > > > > *** d1 HDR { ty 0x746e6f63, rqid 0x2f6c6f72, txid 0x74616c70, len > > 0x6d726f66 } > > > > which was rejected as being too long.  That's "control/platform" in > > ASCII, so the XS_INTRODUCE intersected dom1 between writing the header > > and writing the payload. > > > > > > Anyway, it is buggy for XS_INTRODUCE to be called on a live an > > unsuspecting connection.  It is ultimately init-dom0less's fault for > > telling dom1 it's good to go before having waited for XS_INTRODUCE to > > complete. > > So the problem is xenstored will set interface->connection to > XENSTORE_CONNECTED before finalizing the connection. Caqn you try the > following, for now, very hackish patch: > > diff --git a/tools/xenstore/xenstored_domain.c > b/tools/xenstore/xenstored_domain.c > index f62be2245c42..bbf85bbbea3b 100644 > --- a/tools/xenstore/xenstored_domain.c > +++ b/tools/xenstore/xenstored_domain.c > @@ -688,6 +688,7 @@ static struct domain *introduce_domain(const void *ctx, > talloc_steal(domain->conn, domain); > > if (!restore) { > + domain_conn_reset(domain); > /* Notify the domain that xenstore is available */ > interface->connection = XENSTORE_CONNECTED; > xenevtchn_notify(xce_handle, domain->port); > @@ -730,8 +731,6 @@ int do_introduce(const void *ctx, struct connection *conn, > if (!domain) > return errno; > > - domain_conn_reset(domain); > - > send_ack(conn, XS_INTRODUCE); Following Jurgen's suggestion, I made this slightly modified version of the patch. With it, the problem is solved: https://gitlab.com/xen-project/people/sstabellini/xen/-/pipelines/856450703 diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index f62be2245c..5ca160d9f2 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -688,6 +688,8 @@ static struct domain *introduce_domain(const void *ctx, talloc_steal(domain->conn, domain); if (!restore) { + if (!is_master_domain) + domain_conn_reset(domain); /* Notify the domain that xenstore is available */ interface->connection = XENSTORE_CONNECTED; xenevtchn_notify(xce_handle, domain->port); @@ -730,8 +732,6 @@ int do_introduce(const void *ctx, struct connection *conn, if (!domain) return errno; - domain_conn_reset(domain); - send_ack(conn, XS_INTRODUCE); return 0; --8323329-1599493801-1683150798=:974517-- From xen-devel-bounces@lists.xenproject.org Wed May 03 22:20:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 22:20:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529480.823944 (Exim 4.92) (envelope-from ) id 1puKpi-0000fm-6B; Wed, 03 May 2023 22:20:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529480.823944; Wed, 03 May 2023 22:20:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puKpi-0000fe-1c; Wed, 03 May 2023 22:20:22 +0000 Received: by outflank-mailman (input) for mailman id 529480; Wed, 03 May 2023 22:20:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puKpg-0000fX-R8 for xen-devel@lists.xenproject.org; Wed, 03 May 2023 22:20:21 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ae0ccc2c-ea00-11ed-8611-37d641c3527e; Thu, 04 May 2023 00:20:17 +0200 (CEST) Received: from mail-mw2nam04lp2171.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 May 2023 18:20:13 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MN2PR03MB4959.namprd03.prod.outlook.com (2603:10b6:208:1a3::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Wed, 3 May 2023 22:20:11 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb%4]) with mapi id 15.20.6340.031; Wed, 3 May 2023 22:20:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae0ccc2c-ea00-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683152417; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=h+x/L9PuPiMriAfHyORNjFM1aZwyLjAAJ6seYpBIHio=; b=Bed0PDqWUobGG15Dv5GLNiEcQHL0vY2LJfm/Ji+gg3EkFB9/DUuAgX6o PLZCJRrNkSsxuqHwmC81th7d8mpYbvmEBFqihA9HTRMoQvXeVyQtCj8Rd vbs0I1zMRRBAwfvnq5InAm/qDQKIHcLqcHvtygb8lEDHTP5vCwE/Y/w5k Q=; X-IronPort-RemoteIP: 104.47.73.171 X-IronPort-MID: 107802591 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:De1B3Kx7fGXxTxK1Mph6t+d/xirEfRIJ4+MujC+fZmUNrF6WrkUHx 2pMCDyCaf+PYWbxfdpxYY63phgAuZLRx9RlGVE6+CAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UIHUMja4mtC5QRjPasT5zcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KWxK/ PwmLC1OVRug2P718qqga9JPjNt2eaEHPKtH0p1h5RfwKK56BLX8GeDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvDOVlVMouFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAuiAN1CTOflp6cCbFu75jYNJSYESXGB4vTkh2zgW49vO 1I/9X97xUQ13AnxJjXnZDWju2KNtBMYX9tWEsU55RuLx66S5ByWbkAGUzpAZdoOpMIwAzsw2 TehltfkBzVpvKeSD2yU8rOZrzSaMiwSMGNEbigBJSMO5NzmoZ0vgwjUZsZuFravid/4Ei22x CqFxAA7hr4ThMpN0L+p8FTvijeg4JPOS2Yd9gjRG26o8A59TIqkfJCzr0jW6+5aK4SURUXHu 2IL8+Cc4/oHCZWlnSmEUuILWrqu4p6tMjLGhkV0N4I87Dnr8HmmFahS6jxjIEZiMu4fZCTkJ kTUvGt56ZNMPX3scahtZIGZAMAt0KSmHtPgPs04dfJLa5l1MQqYpidnYBbM23i3yRd116YiJ Z2cbMCgS24ADrhqxya3QOFb1qI3wic5xiXYQpWTIwmb7IdyrUW9Ed8tWGZipMhghE9YiG05K +piCvY= IronPort-HdrOrdr: A9a23:2ULlAKgkYY3/fRYsCbTs6P2rynBQX6F13DAbv31ZSRFFG/FwWf re+MjztCWE/Ar5PUtK9+xoV5PhfZqiz+8L3WB8B9aftWrdyRmVxf9ZnOnfKlTbckWVygc379 YCT0ERMqyUMbBw5fyKnjVRe7wbrOVum8qT6ts3AB1WID1CWuVYy0NcNy7eK0txQWB9dO8E/F j33Ls3m9JlE05nHfhSwxM+Lpj+Tqbw5fXbSC9DPQcj9A6NyRuw8dfBYmCl9yZbaSpL3bAhtU PYkwn1j5/Tz82T+1vnzmrO6JYTv9PkxrJ4daqxo/lQECzolgGrIKJ+XLGY1QpF2d2H2RIRid zRpBVlBeRfgkmhBV2dkF/Wwgz91zRr0XP41lOCpnPmraXCNUgHIvsEv5tdbhzar3Utp8t91q Uj5RPli6Zq X-Talos-CUID: 9a23:fYlJAmMXLilnHO5DVS1u9HAQB4MeeV6C0DTiO1SZMkVjV+jA X-Talos-MUID: =?us-ascii?q?9a23=3AcK8zxw4zo/cLFLvQr8o7LeUVxoxIubqDM1IRu69?= =?us-ascii?q?FtpSJF3JwZgeNkh+4F9o=3D?= X-IronPort-AV: E=Sophos;i="5.99,248,1677560400"; d="scan'208";a="107802591" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RyzEKcg82G7OwiUeZsD6hDzF6oh6pS/cvCF4caKthD+TavpElqoe2p1JUgoWGBsVLjyCwb8rBizpEGf7mJ7/GqvPpnSn4zRKYGxahV2V4fzmjvMKcY8zyqqQtXdrdrebtZDtk5cz/2kcHbToSJDjjhyYn5NPwPleHMaTjSEO0rYziHSY0bMsO95aQgyVKgZLgY01Y8oKzFITAW21NomGYaMaZ4hE09ZI4/XS5mTpThgfuJL7HJQAUFqnWc8otgMxkbp0Ad8raEcrWZ09KgENzAB/9mtQtGFuqRrZBgnWGESDmROxPaqxqmcpjts2Y8dHEov37KIBeukszso0MKXs/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G+FFpobbSOiQkMF40Buh+1T++dobOOXyl+bvvWhtG1I=; b=RREHfe/DMvhOuBlrJGa8OAlhlX16G7F0MPoe4ORX/iiTbA/cXlWVM1GmrwHYbDqdwsIEgtyZvn17qk+4mN+wPScUAt3WdKIHqcnXv8uJECfye97DV0tleLfB82+co1k9YLaS601eHO0t83hBc+hFwA2GGxsTszZHt2e//in/3e4Of/5G21AVV2ACp0SSgw3OvjzzZ6DvyYWWCIKmhWdvZYsQWzUWqt0BnvHyJlMbBvKppOfu9tf7yV/8P2ddY6q5j9ZE300YTgNdGq47g+l52rvSkNhYveF23ObLe3G8eVxcSP15gxn/EwNwxx77SB6K9XZa8NbaKhxp8x/LNgrY3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G+FFpobbSOiQkMF40Buh+1T++dobOOXyl+bvvWhtG1I=; b=PVF1rO0bByYj/mCGVm813GVh/xLSatiChIYHAuzn9ULSqe1k2frMik5skkQZuvcn77du0fEdAh7qw8JIHMXFjovAAFKIY0ur+8pLIJXiTt5WUNc+qxr6CqrpMyqYktXxYWWYC3q/QHSKH+E+meQB4XdORF2yqPCNKeU2hc8mE/Y= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <2c1c83be-19d8-34cc-113a-36245adac07e@citrix.com> Date: Wed, 3 May 2023 23:20:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: andrew.cooper3@citrix.com Subject: Re: dom0less vs xenstored setup race Was: xen | Failed pipeline for staging | 6a47ba2f Content-Language: en-GB To: Stefano Stabellini , Julien Grall Cc: alejandro.vallejo@cloud.com, committers@xenproject.org, michal.orzel@amd.com, xen-devel@lists.xenproject.org, Julien Grall , Juergen Gross , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jan Beulich , =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= References: <644bfbc6939d8_2a49bbb403253f4@gitlab-sidekiq-catchall-v2-78885c497-qxnp2.mail> <28235d38-ad7f-f1bd-f093-bd83f9fd6589@xen.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO6P265CA0002.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:339::11) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|MN2PR03MB4959:EE_ X-MS-Office365-Filtering-Correlation-Id: a251c83d-89d4-46ac-38bb-08db4c248e51 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9jYhAAqlr8fmn/5uvT6XBDSPtej+imosfm+wtPePrBuVHISWWBbtVKv8J6/A+kEsA+VfbwDnKcl87qKX2JqORfYQkCKNnVivnNee18CGt7OKpdkbYJHduBWK3gcdNp1+1JcR6atf1vBFHeeOGrWJqH4Mu7TmE2KJoEP3LCN119xpcAS3QfSgVc8wbaa2qheQ5qZuL0/Ax9TwyEF4einO50HG3DJAjkbLpLIE8bbI2gN2fE/d1JzxkUAx7dg4mJicCk255sIdlh91aWOSaGWmJa8bZtylvLC/KeUVQMqI1HydQ7koOMUo3D6leMi40n/h4ANwp1RPPMg5jF2LHlTMrZL5O6H3X74tLNbBxP7gBx6QveOCrWd0De7ut8BZMjXlQkiXF7L4Z0vF7I2dJih8CI5A//mYljxudE6TyTOrKXQecgwufLP+/Q6X9NRE8Web39cLs2ps5LYMR8IHVbnq3+KLlUelvXfnd5UomS+VxSjx7eBgXbucCrpklzQNL2+3wZB+xS6HAoINS5B9HrK2S65vIGJBTaACM3MXzDbJ9TUCPbMEPUDeSXEeN14TuFMz4IjXk6ZN4tkDSj5lTg0AzJ0ipibyeFC0Vs1TzJPecuQEFIy0UBRBDFYVYMkN7W8sGIsbSO5DePY0Vbl+DjJnrMc+efWnbFHNJGvSXylyOAg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(346002)(366004)(136003)(39860400002)(451199021)(6666004)(6486002)(186003)(83380400001)(31696002)(26005)(53546011)(6512007)(9686003)(6506007)(966005)(110136005)(54906003)(36756003)(2616005)(31686004)(478600001)(66476007)(66946007)(66556008)(82960400001)(316002)(8676002)(8936002)(38100700002)(41300700001)(5660300002)(4326008)(86362001)(2906002)(7416002)(32563001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N2ZCQlBpeWczdThYY24wOVA1NEl2Zi9EUW9QeTg3dDdQTVRNRXRvcEdPb3ZE?= =?utf-8?B?eFg5cEtUSGRBM1JkV0V6MWpSS3dRM20wYkRQQVFtMVJKQWlMSkhKT3lvN0FY?= =?utf-8?B?TURiSGdCRWZYY09seDdiNzQzMktQUFIzQVdYM2pYNENxWENCTktqTFdENm9s?= =?utf-8?B?RzNleGRnV1lBc2NiWHBWblRhZ2lVV0xXNlZvZm1WTkdGSmpKc3VQRjdHSWNE?= =?utf-8?B?U09YOUtINzFMYkY2R2JXUWdaRWVCWHp6RUZvUXEyYmNVS1ZIZTUvTlpTc2p2?= =?utf-8?B?Ky81ZElhSHVPcGl5TGJmVENkYW5IQUdZUzI3NzY2L2lTTkl1S2NRWVBZdG96?= =?utf-8?B?eDlOWTZIOEFIQ0NzcS9NRkRoSHNDTXZBMUxPWnFJbFJtYWYxVEc2V0ZGbHhD?= =?utf-8?B?VGVNN0YxNXBJZjlDc3VIRmxmVFpIQmkxdlVidTlZK2ZvbVFzQVN0ZTJvOCtt?= =?utf-8?B?aFBEaWxoa05Jb21INjBkWHBuVmJPOVN1YU9hWFAwcUhVa3RsSjVCcmNuNkg4?= =?utf-8?B?a3ZNbU5SRTlSZHprOVVjSUVqcHdvN1l5U3NpakFXS3ZjQlMyWVlkZGlEc1ov?= =?utf-8?B?ZnlCRUNiRmlmeDFLZzBJYXYwNXBnUEZWMlpVbUQ0RDFreFhxd21lejV3TjZI?= =?utf-8?B?RW5EeVNtVDBjRURrb3lHMkZTSy9nVTNvSHZnUWxMRE1wS1B6ZEFiWC9qYWor?= =?utf-8?B?M1dXK0wzak8vRFV3WC8xdkh1TDA5ekFMMEFSZU85YTF1SlQyQWd4MkRSdHJu?= =?utf-8?B?bE5Sek9aZU5qbVRqRVg1R21iUWx0U0NDcXVYYlNQZEtNdEFhQVZJaHpqL1ZF?= =?utf-8?B?WExSQUxCVXd3Zm95TEhXUEVadTZzbElUK3hIMkVGS1gvUWViTy9iR2hOQlBY?= =?utf-8?B?UHJSd3JhNkhwMGdGQVduelNmKzI3eTVwanl2V2ZMaE81cm4vZFVqZy82SHZa?= =?utf-8?B?Wi9URTF6N0VmUVlld1pXcDNBemZIZ1RvYWRVaEdXWVJuUTJKcU1nTDFsYWFP?= =?utf-8?B?b2tzSUpYaHYyRit2TkN3aE9zNXNZczZDVGgxS3VDc3Y5MFUvU1liM2NpVVVy?= =?utf-8?B?YzBINFBMMStYdkhhbGppVFRDam1WOFVkbWppTVBZNGZndCtCOENTSXNteEpE?= =?utf-8?B?VmZGbXFRMzRqRDlxNDAva1UzQkwrK2p5S2RGeGpxSDU0NVJwbHF5SXcwSFhz?= =?utf-8?B?NWMzV1A0RHRYN1FaSUhVQ1NqVGFwR2licG16dmFpZy82bEVDbXVLeFNyZU5t?= =?utf-8?B?a0lUazFKd2JtYVBPejd2SkZjU2FQdDI2ZGtjTDRTZE8zREhOL093NWZ4Y25j?= =?utf-8?B?OVd6cmRhZTRzSFlGSVFNRUs3NHJKSkxNanNRbVFBT3lsY3VIK01GK1BIOUpH?= =?utf-8?B?T2RxQTlpd0t1RGJrNUw0M2hJemRXL1VVTGI2TENVN0lBM1BzaDNaZGZtd09F?= =?utf-8?B?SVJKbk5oRFVGdDRpeEdNaHZWWm92WnpMTFVobjRabGxoRkFXUlpZalY2T1JK?= =?utf-8?B?ZVNWRkZ5WndON1dTcXRDUHV1Y2taQ1FWWGNxKzNmTmwzV0k2T3d5cENCWmNw?= =?utf-8?B?VGY1VXJmRTAwbHdCWXYvQXAzMXd6anBIaW5ZK0lPZFJMVk1wSW1XSE9nS042?= =?utf-8?B?SDY0T3ErdGg2V0k4ODhMWDVuaitZVmRlUm9wd2xQZFFBNkN3cXUvTFJQb1VE?= =?utf-8?B?YjVFNEhMQmZQSEhCbXd6STRPVGt3aWJPek90c05UTWxNMmw0K0ZmSXkrWEZU?= =?utf-8?B?TjFoQVZTbWNsSzhZMUR1M09GdkUxbU5lZnN1dVdpMVlDR3E3Yzk5Ty9FajRl?= =?utf-8?B?WW01NWVYb1ZaNyt2WjJkdU5BWXU2ZG5xNnl3SVFNRjRkUG10MW9zN0kxME5Y?= =?utf-8?B?UmxxNzVFYnFveXluVzRqSGIrbldLdTdTM1IwM2VoTlhNczFwcTZTMVUveEJj?= =?utf-8?B?OFBLenVBN2NxdDFhdTlHbHNWTzZSZDNOb01wWkhOV2ZNb0E2Vmk0dzBJYm9u?= =?utf-8?B?QjFueCtEck8zemJDUXp2UU9teDFLUmovY0l4SFpPNUpSSGFyeEVvQTR1bWZB?= =?utf-8?B?bjhPMlRXREJaNDhBSHczaFlDRW5LajZWb0hQUVNLeHAyUG5QbmhpMHlXMDAw?= =?utf-8?B?R1ZvaFcxRmpTQWZEd2FKSzNuVS9ScDN3K1RjYWdOMThLc3RiY0N4NFk0Zi9T?= =?utf-8?B?Q3c9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?L0tqaFZhcXRZOHNaSmZLMzZBMEJGZ0lzSlo0WjdKc0ZuSlNvVGlqUkl4aDNI?= =?utf-8?B?OXFGQW50bStWVG5Xb1ZPTEtCc204ZkRsa2JmTFZucWwrblZjcmsvRmlMZ1li?= =?utf-8?B?cFQzaFBGQndydTBpMlhSaEdJQWVNZFZRUyswQUxFUWtpUVgrRUk0NnJSL3Yx?= =?utf-8?B?M2Q5bUo3S0poQ0JWNi93SEhHK0VwK3UwSlVwSVdLbmJoV0UxTlpnSlpCdGli?= =?utf-8?B?eVNpNTU5d0s2UWhLVFV2N2RiYm56b3l4MlprV0t5R2RLaUhMSTBzdXhDUllI?= =?utf-8?B?d2U0V0YxOEtrcGdGRDNLaGNYY3Q0dHFRVENWVElrTXFWL3NTeUFNcEcxL0c5?= =?utf-8?B?WHBicTVJVFFrWlZEcDRYdUN2dlpqbGZFTUhmVE1jUmp3azg2UjBUN3E2Zk5h?= =?utf-8?B?M0svY3d3TmZWYzJFbDFsZjFPR3crZW5HVndMTDhhamphWk96dHV5TEg4akxR?= =?utf-8?B?SDlkeVdRbHFZRVB2Y2xnakdiQVhmVE9PMW5Pd3NxV1l6dlJ3VWFBNkJYOTYw?= =?utf-8?B?ZFRuSmJMSEdWT3c2cTQ1TzR2U2lXeUg4eDBYVnB4Vk9hd0NDc093U2l3VUlt?= =?utf-8?B?RHpUbkxOSGRUdCtrWHZRcmtnTVlUdktQY010NnhyaXMzSGQ2WXBiYkx3NWd2?= =?utf-8?B?VXJzL21jR3ZXczIrSGFtY21KR1VHUEFJUU9HQ3pFQVhxVW81aTZsQmJaZkdo?= =?utf-8?B?Sk9RN1RQaU1hN0JZYXVsU0p4Wm16RVphV0tlWjJtVjJvNEZlQXBUTkRJWnBa?= =?utf-8?B?d3B2UlRvQ3FmNU9hM09vVklibFVhTXd4bEZ4UDlMU3FPaHc0ckJkdVNub3I0?= =?utf-8?B?eVhNZjF2b0dyWEowaWtRRURMZ1Z2SjVoNmVJaVJFWU5iYTZhZG5uY2lMNTNx?= =?utf-8?B?L2xMR2gwVzR3VTFsTWdzaTB0OXlVNnZNL1NjVlhnelVVUnZYckJLQzU4bEtL?= =?utf-8?B?M2xXcUZyZU0vRFF2N252Mjg1QjNJSGFqQldMZlU3WTZYcHVaR0E1amVjam04?= =?utf-8?B?WnhpSnNOMm5CSW1HZU14cWpIOVhaYzk2UUp0MjVIc1pVL01RZkt1aVJOSlQx?= =?utf-8?B?UGxmQmEyQytyaStjSUczZXU0KzQzOHBCODRFT2JTdDBwYW1ibksvTEhTVmIz?= =?utf-8?B?V0x1QVhSdUdib3M5Tk50cjZOM2U1cjVwSXpPSEJZc2hTTzliTVE2TE9ubWVH?= =?utf-8?B?ZERNYWF6VVl0YVprblZYSEhxTFBDVW9VY1hYNWVUVWJhbG1pejZpdkhBa1lD?= =?utf-8?B?YVREeXV3RS9QTTZMaWMrQmljWjJWVnhsYjY0SHJaMzFubUtGZz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: a251c83d-89d4-46ac-38bb-08db4c248e51 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 22:20:09.6884 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: D/j6Km3Nug55maPlR4m5AT/bwHWj91Nfn8icpJ93j2jzVmdhf4NubkLj6jncQngVKkrfu4jqPFhK/Dt4fgjoBuT+/BCu2vHV3KweLrafRuM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4959 On 03/05/2023 10:53 pm, Stefano Stabellini wrote: > On Wed, 3 May 2023, Julien Grall wrote: >> On 03/05/2023 15:38, andrew.cooper3@citrix.com wrote: >>> Hello, >>> >>> After what seems like an unreasonable amount of debugging, we've tracked >>> down exactly what is going wrong here. >>> >>> https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/4219721944 >>> >>> Of note is the smoke.serial log around: >>> >>> io: IN 0xffff90fec250 d0 20230503 14:20:42 INTRODUCE (1 233473 1 ) >>> obj: CREATE connection 0xffff90fff1f0 >>> *** d1 CONN RESET req_cons 00000000, req_prod 0000003a rsp_cons >>> 00000000, rsp_prod 00000000 >>> io: OUT 0xffff9105cef0 d0 20230503 14:20:42 WATCH_EVENT >>> (@introduceDomain domlist ) >>> >>> XS_INTRODUCE (in C xenstored at least, not checked O yet) always >>> clobbers the ring pointers.  The added pressure on dom0 that the >>> xensconsoled adds with it's 4M hypercall bounce buffer occasionally >>> defers xenstored long enough that the XS_INTRODUCE clobbers the first >>> message that dom1 wrote into the ring. >>> >>> The other behaviour seen was xenstored observing a header looking like this: >>> >>> *** d1 HDR { ty 0x746e6f63, rqid 0x2f6c6f72, txid 0x74616c70, len >>> 0x6d726f66 } >>> >>> which was rejected as being too long.  That's "control/platform" in >>> ASCII, so the XS_INTRODUCE intersected dom1 between writing the header >>> and writing the payload. >>> >>> >>> Anyway, it is buggy for XS_INTRODUCE to be called on a live an >>> unsuspecting connection.  It is ultimately init-dom0less's fault for >>> telling dom1 it's good to go before having waited for XS_INTRODUCE to >>> complete. >> So the problem is xenstored will set interface->connection to >> XENSTORE_CONNECTED before finalizing the connection. Caqn you try the >> following, for now, very hackish patch: >> >> diff --git a/tools/xenstore/xenstored_domain.c >> b/tools/xenstore/xenstored_domain.c >> index f62be2245c42..bbf85bbbea3b 100644 >> --- a/tools/xenstore/xenstored_domain.c >> +++ b/tools/xenstore/xenstored_domain.c >> @@ -688,6 +688,7 @@ static struct domain *introduce_domain(const void *ctx, >> talloc_steal(domain->conn, domain); >> >> if (!restore) { >> + domain_conn_reset(domain); >> /* Notify the domain that xenstore is available */ >> interface->connection = XENSTORE_CONNECTED; >> xenevtchn_notify(xce_handle, domain->port); >> @@ -730,8 +731,6 @@ int do_introduce(const void *ctx, struct connection *conn, >> if (!domain) >> return errno; >> >> - domain_conn_reset(domain); >> - >> send_ack(conn, XS_INTRODUCE); > Following Jurgen's suggestion, I made this slightly modified version of > the patch. With it, the problem is solved: > > https://gitlab.com/xen-project/people/sstabellini/xen/-/pipelines/856450703 This fails to solve 3(?) of the 4(?) bugs pointed out between this email thread and on IRC. Stop with the bull-in-a-china-shop approach.  There is no acceptable fix to this mess which starts with anything other than corrections to the documentation, and a plan for how to make startup work robustly given all the bugs introduced previously by failing to do it properly the first time around. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed May 03 23:13:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 23:13:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529483.823953 (Exim 4.92) (envelope-from ) id 1puLeU-0006IX-3S; Wed, 03 May 2023 23:12:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529483.823953; Wed, 03 May 2023 23:12:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puLeU-0006IQ-0r; Wed, 03 May 2023 23:12:50 +0000 Received: by outflank-mailman (input) for mailman id 529483; Wed, 03 May 2023 23:12:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puLeS-0006ID-4x; Wed, 03 May 2023 23:12:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puLeR-00008j-TN; Wed, 03 May 2023 23:12:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puLeR-0005dw-Fq; Wed, 03 May 2023 23:12:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1puLeR-0006fF-FQ; Wed, 03 May 2023 23:12:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=wsQpAf+PN7LBtc5b+mq/sNu5Fn74iXEGjxo0c1K21A4=; b=BU+G4f8xRpmSISGjhGwm88RKiO mlsrqUNY7YysTsRZj1UNuyfDGeNF2zdWZYEgiRh6CFx8UpEUgWx3w/0D1VX5G9DvrAPI9hw0BoLX2 669CrEeVimlw1WpkUYLnaYjvsbyq5kfcCwp95N89IYCrA6/254Un+Ykuhcue3iaBgskc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 180514: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=c586691e676214eb7edf6a468e84e7ce3b314d43 X-Osstest-Versions-That: qemuu=b5f47ba73b7c1457d2f18d71c00e1a91a76fe60b From: osstest service owner Date: Wed, 03 May 2023 23:12:47 +0000 flight 180514 qemu-mainline real [real] flight 180521 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180514/ http://logs.test-lab.xenproject.org/osstest/logs/180521/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail pass in 180521-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 180507 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180507 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180507 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 180507 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 180507 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180507 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180507 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180507 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass version targeted for testing: qemuu c586691e676214eb7edf6a468e84e7ce3b314d43 baseline version: qemuu b5f47ba73b7c1457d2f18d71c00e1a91a76fe60b Last test of basis 180507 2023-05-02 15:37:40 Z 1 days Testing same since 180514 2023-05-03 05:31:08 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Claudio Fontana Cédric Le Goater Daniel Bertalan Fabiano Rosas Patrick Venture Peter Maydell Richard Henderson Thomas Huth jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git b5f47ba73b..c586691e67 c586691e676214eb7edf6a468e84e7ce3b314d43 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Wed May 03 23:16:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 May 2023 23:16:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529489.823964 (Exim 4.92) (envelope-from ) id 1puLho-0006yL-N3; Wed, 03 May 2023 23:16:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529489.823964; Wed, 03 May 2023 23:16:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puLho-0006yE-Jc; Wed, 03 May 2023 23:16:16 +0000 Received: by outflank-mailman (input) for mailman id 529489; Wed, 03 May 2023 23:16:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puLhm-0006y6-Sy for xen-devel@lists.xenproject.org; Wed, 03 May 2023 23:16:14 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7e2281fe-ea08-11ed-8611-37d641c3527e; Thu, 04 May 2023 01:16:12 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1441A63042; Wed, 3 May 2023 23:16:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB734C433D2; Wed, 3 May 2023 23:16:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e2281fe-ea08-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683155770; bh=mcZbuchNBi5Fppn0ME2sv81rsNiMa7IiZd7Odu5pZ4w=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=TIt+fGLsl1M2PVavsLiu9koO6+kHcojFudesqPs55ZIJYJBY+T/0zekiTTiYaM9+L mzEZNnIIigSwMmNjuUPRuODF8naScvaLDhUlR3TYElrm+NnCh98eR9e6OkjXSjjpxU YHAMDk7lP23b+OHXStUdo2cp7uD+XHiThShIj8A2NzeEeNH5soRwiQXqIk5lBKIjwK dIHp7dwk30/fjjBR8+nWbTDo05FB++JJ8k4UqQYOT1HXmgElY92iUQ8u4RYPS8Fj+k 8UchsvMA+7GIsc8kUpe7dxXkU6kcsl5k39QwGVTtXptU0GWaMy5vRhVQf2JmJPM1JX PkKEf5sjuAQhw== Date: Wed, 3 May 2023 16:16:07 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: andrew.cooper3@citrix.com cc: Stefano Stabellini , Julien Grall , alejandro.vallejo@cloud.com, committers@xenproject.org, michal.orzel@amd.com, xen-devel@lists.xenproject.org, Julien Grall , Juergen Gross , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Jan Beulich , =?UTF-8?Q?Edwin_T=C3=B6r=C3=B6k?= Subject: Re: dom0less vs xenstored setup race Was: xen | Failed pipeline for staging | 6a47ba2f In-Reply-To: <2c1c83be-19d8-34cc-113a-36245adac07e@citrix.com> Message-ID: References: <644bfbc6939d8_2a49bbb403253f4@gitlab-sidekiq-catchall-v2-78885c497-qxnp2.mail> <28235d38-ad7f-f1bd-f093-bd83f9fd6589@xen.org> <2c1c83be-19d8-34cc-113a-36245adac07e@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1729168010-1683155543=:974517" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1729168010-1683155543=:974517 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Wed, 3 May 2023, andrew.cooper3@citrix.com wrote: > On 03/05/2023 10:53 pm, Stefano Stabellini wrote: > > On Wed, 3 May 2023, Julien Grall wrote: > >> On 03/05/2023 15:38, andrew.cooper3@citrix.com wrote: > >>> Hello, > >>> > >>> After what seems like an unreasonable amount of debugging, we've tracked > >>> down exactly what is going wrong here. > >>> > >>> https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/4219721944 > >>> > >>> Of note is the smoke.serial log around: > >>> > >>> io: IN 0xffff90fec250 d0 20230503 14:20:42 INTRODUCE (1 233473 1 ) > >>> obj: CREATE connection 0xffff90fff1f0 > >>> *** d1 CONN RESET req_cons 00000000, req_prod 0000003a rsp_cons > >>> 00000000, rsp_prod 00000000 > >>> io: OUT 0xffff9105cef0 d0 20230503 14:20:42 WATCH_EVENT > >>> (@introduceDomain domlist ) > >>> > >>> XS_INTRODUCE (in C xenstored at least, not checked O yet) always > >>> clobbers the ring pointers.  The added pressure on dom0 that the > >>> xensconsoled adds with it's 4M hypercall bounce buffer occasionally > >>> defers xenstored long enough that the XS_INTRODUCE clobbers the first > >>> message that dom1 wrote into the ring. > >>> > >>> The other behaviour seen was xenstored observing a header looking like this: > >>> > >>> *** d1 HDR { ty 0x746e6f63, rqid 0x2f6c6f72, txid 0x74616c70, len > >>> 0x6d726f66 } > >>> > >>> which was rejected as being too long.  That's "control/platform" in > >>> ASCII, so the XS_INTRODUCE intersected dom1 between writing the header > >>> and writing the payload. > >>> > >>> > >>> Anyway, it is buggy for XS_INTRODUCE to be called on a live an > >>> unsuspecting connection.  It is ultimately init-dom0less's fault for > >>> telling dom1 it's good to go before having waited for XS_INTRODUCE to > >>> complete. > >> So the problem is xenstored will set interface->connection to > >> XENSTORE_CONNECTED before finalizing the connection. Caqn you try the > >> following, for now, very hackish patch: > >> > >> diff --git a/tools/xenstore/xenstored_domain.c > >> b/tools/xenstore/xenstored_domain.c > >> index f62be2245c42..bbf85bbbea3b 100644 > >> --- a/tools/xenstore/xenstored_domain.c > >> +++ b/tools/xenstore/xenstored_domain.c > >> @@ -688,6 +688,7 @@ static struct domain *introduce_domain(const void *ctx, > >> talloc_steal(domain->conn, domain); > >> > >> if (!restore) { > >> + domain_conn_reset(domain); > >> /* Notify the domain that xenstore is available */ > >> interface->connection = XENSTORE_CONNECTED; > >> xenevtchn_notify(xce_handle, domain->port); > >> @@ -730,8 +731,6 @@ int do_introduce(const void *ctx, struct connection *conn, > >> if (!domain) > >> return errno; > >> > >> - domain_conn_reset(domain); > >> - > >> send_ack(conn, XS_INTRODUCE); > > Following Jurgen's suggestion, I made this slightly modified version of > > the patch. With it, the problem is solved: > > > > https://gitlab.com/xen-project/people/sstabellini/xen/-/pipelines/856450703 > > This fails to solve 3(?) of the 4(?) bugs pointed out between this email > thread and on IRC. > > Stop with the bull-in-a-china-shop approach.  There is no acceptable fix > to this mess which starts with anything other than corrections to the > documentation, and a plan for how to make startup work robustly given > all the bugs introduced previously by failing to do it properly the > first time around. I am not suggesting this is the fix (I didn't add any Signed-off-by or commit message on purpose). I think it is useful to know if a theoretical proposal would work in practice as it helps us understand the problem. In the little time I had in-between meetings I thought I could help a bit by providing this update. Like you, I would appreciate a comprehensive fix which includes a documentation update. Genuine question: how would you like to proceed? In the project management sense of who does what and what is the suggested timeline. --8323329-1729168010-1683155543=:974517-- From xen-devel-bounces@lists.xenproject.org Thu May 04 03:55:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 03:55:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529528.823974 (Exim 4.92) (envelope-from ) id 1puQ3b-0005AG-1r; Thu, 04 May 2023 03:55:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529528.823974; Thu, 04 May 2023 03:55:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puQ3a-00059u-RJ; Thu, 04 May 2023 03:55:02 +0000 Received: by outflank-mailman (input) for mailman id 529528; Thu, 04 May 2023 03:55:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puQ3Z-00059l-4c for xen-devel@lists.xenproject.org; Thu, 04 May 2023 03:55:01 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20624.outbound.protection.outlook.com [2a01:111:f400:7e1b::624]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6fb4fa2a-ea2f-11ed-b226-6b7b168915f2; Thu, 04 May 2023 05:54:58 +0200 (CEST) Received: from AM6P192CA0060.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:82::37) by AS2PR08MB8454.eurprd08.prod.outlook.com (2603:10a6:20b:55a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Thu, 4 May 2023 03:54:55 +0000 Received: from AM7EUR03FT065.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:82:cafe::5a) by AM6P192CA0060.outlook.office365.com (2603:10a6:209:82::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26 via Frontend Transport; Thu, 4 May 2023 03:54:55 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT065.mail.protection.outlook.com (100.127.140.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.21 via Frontend Transport; Thu, 4 May 2023 03:54:55 +0000 Received: ("Tessian outbound 3570909035da:v136"); Thu, 04 May 2023 03:54:54 +0000 Received: from 05c584a71ee4.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9191A3A7-3D2D-4559-A542-1213A3019919.1; Thu, 04 May 2023 03:54:49 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 05c584a71ee4.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 04 May 2023 03:54:49 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by VE1PR08MB5823.eurprd08.prod.outlook.com (2603:10a6:800:1a5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Thu, 4 May 2023 03:54:47 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6%6]) with mapi id 15.20.6340.031; Thu, 4 May 2023 03:54:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6fb4fa2a-ea2f-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TRauj12Zeuec/7oL0evdHlgULMSFkh+0FOD2EYPTdzE=; b=K9W7WZN/VDfESn/v3wY3Mrf+X1bdrYNCe/Lqd8odEVodM36zPO607yxdtzUem2FBe7FkfqUe6VC3/z4z4JsmHABRQkD2TMF4LIbTMxXszlfmT48PEGwZkhU7vaDGhzKB2GZKUIZKLNpSLC331ZRzy9xCDAfq5m7YNZdGh8EpO1E= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PBWYzNcrvDlu3EiNS2hqudOQkYDjt1ZtGyhv3wi1ss9ozhBvVyLstzspRkGjp4XXqOwAot+RQa98cdVFe+FCd9dXf+4Q1udwzdCWVNKkeRP7ai3n+wWmCHRyHm2DL+IaetnSNCv1HbOdHLOex7GR2xvIxorGD2NYayaX8suBxwXupMG9576p+AL4iYi5ty7E2zFkGHNc+YVpf9gTTb9mosfSX/kzkNhGSxvppu+GcILXlP7f4oW9fuuwNLGAWrqgpAheW42wGFvWvlPekNJ7TtzbhkiQmDIm2U+ZwDgyat/kOfuRjFpdp5/wGEtJfjlugXzQ7mpn05PtaE/rjgkvzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TRauj12Zeuec/7oL0evdHlgULMSFkh+0FOD2EYPTdzE=; b=l64eiEScDW3RNEWmI97rDn+KEKQ/HKV3Ld4WGF3tWtugHc9GPU1j7XSFCV1OACMb3uNdTfcZrxq9/uXOBa+YZzkh7cS3uHTisUZ97JNk877je849zCmygRYNli7K/FPvkjT0BIzA4gFlQfWlBpncVCycR4NKzfNaC9+Sok9d6NAJLzykuLOqvR110sVGyVyvFPKOKedXEjwPtlr1NJlzOKpCmJoLpWbqg1c6SKA501C9dnCemncfP1dyh5BRJk1DOva56EWMWqwQtMgF7iIPrMh0GvkzsYJGdfkpUdpXFaHjOMNk4+Q5Ps5SEPf3CkpQT21EoI25oTaTTm+WotbJrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TRauj12Zeuec/7oL0evdHlgULMSFkh+0FOD2EYPTdzE=; b=K9W7WZN/VDfESn/v3wY3Mrf+X1bdrYNCe/Lqd8odEVodM36zPO607yxdtzUem2FBe7FkfqUe6VC3/z4z4JsmHABRQkD2TMF4LIbTMxXszlfmT48PEGwZkhU7vaDGhzKB2GZKUIZKLNpSLC331ZRzy9xCDAfq5m7YNZdGh8EpO1E= From: Henry Wang To: Vikram Garhwal , "xen-devel@lists.xenproject.org" CC: "sstabellini@kernel.org" , "michal.orzel@amd.com" , Julien Grall Subject: RE: [XEN][PATCH v6 02/19] common/device_tree: handle memory allocation failure in __unflatten_device_tree() Thread-Topic: [XEN][PATCH v6 02/19] common/device_tree: handle memory allocation failure in __unflatten_device_tree() Thread-Index: AQHZfU8Zj43F8/qoe0aOSV+uN58JIK9JfX4Q Date: Thu, 4 May 2023 03:54:46 +0000 Message-ID: References: <20230502233650.20121-1-vikram.garhwal@amd.com> <20230502233650.20121-3-vikram.garhwal@amd.com> In-Reply-To: <20230502233650.20121-3-vikram.garhwal@amd.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 6D50E71DC551B149BE8281E2F88E7FAA.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|VE1PR08MB5823:EE_|AM7EUR03FT065:EE_|AS2PR08MB8454:EE_ X-MS-Office365-Filtering-Correlation-Id: 80667c16-239a-4f66-ffe9-08db4c53526f x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ztzKfw5IbwaZPZdvf/NR/xq0XeyqxhdNuhAhgRQsy0Nup/HvPmrylapLIm9dQEZjTkf0lzh8JncWeJ/cU6CMFEcsgitoy+HiV9+1BhDkwUjO60xpC2BIhe3EhYn4RsXV8iE7tCwSzfwMR4auVNX59ISDqP9oyPvLgeuYUSrH9Fdr1w2aAUJAbG1uqPr7T5XZW1MfsNTb4cgS3Vg4j4+gGdiJY9n3vyJfgRx7qAxebXhZRuzyOMP4P1tDeicTRVLxm131/3BEIh+5M0lvQ0QGT1Obi4X9BNm9bm2+s8/PMrtocLlKb6HfJbJOnNVAp58cPuG7U63WleHZnM1E30UG5lIXkFRP8XDYkdXFsgzTEriUUOJZ8E+0uCv5W1OWJGG2OpnlJm0LFTPbbUAASvd4XlzXY4ts5Txjex7hC6hGlGQbtvHmGsS0AdmMuiGuWivur5CnlEZLL36sdiKk3BRC9MhpIdqQvI6QJqFvrgnJzebHTHxClLuyznNjYGeMurqr7h1V9Ehq6RVGMatE/XtBRpPSjFr3h3IkqvEnlU0uOhMlnmB4F9jruHrKHL6kHWvTz3idQl6NT4w/DZnRC8z0NxkDjAef/FOi0L+IEFs3r7oEzeiUHLKliIBWXh8mvv4T X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(366004)(136003)(39850400004)(376002)(451199021)(86362001)(33656002)(54906003)(316002)(110136005)(66946007)(66476007)(66556008)(64756008)(4326008)(76116006)(7696005)(478600001)(66446008)(71200400001)(41300700001)(2906002)(55016003)(8676002)(8936002)(4744005)(5660300002)(52536014)(38100700002)(122000001)(38070700005)(186003)(6506007)(26005)(9686003)(83380400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5823 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT065.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ab152563-eca1-4fd0-9ceb-08db4c534d33 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GmxvWtX6+bJmgQZfHbGfhXAz9WEjM0dQo00VbSLDtO2llWFpphfcuOuNDdAMoC1yFfscobGCzmgaHPTWrNjQjL1K+kabxErI7ngEj/yBRu7voaLfDgb1RUu/3K7WqJnYiH8B4AutxUBpaoSy67HABj2vuHJbDCwMgyxc5X4AXT/DHNjREtAIA6+3Xwmu97fbHZE/s2YkTa69/nmhqh2J84tOApzCHPFCnm4ZrIm9LpaJ8ZTH7sXOiDUYrUQazVUBx3Xhdc+DtTAULbLSMu4PaCVg3Vo2Oyi375n8YIR0S5ryI7jMS67nc0pYZSPTR7lFuraS+bODrZTTLBzBLUjgn9e2QPBGO4f1oPE+3CK71oSQ4qlBelDCZQXRvJenAvZ8Y+fYZzxBbjJtI5d8DqrN9J+jJ5mjWp5HcrvhAslMHNgZF0GXQnKFakkSB+WX5UFnmckf9S/QtDPgvHzJRctA5sPRbWOu6Uib0hSxnArv1jLE5M5A4a6ek/FmStEElAE7TM0G0UiJvnKfiObCeBE/64vuEhELa/4LeDxWQMdo0kWTrolGx9oiSmqIJBj4JNF9hl9uFS35AAWAaSbgt3l+E1MRmyhVyHmYJjBlYZ+T1JRaGRpzXGejC2a2rpH5GjYIag1CO7tE9idOQoZM14qWqvIM/sD2+OeVttAfVAfOoJYWWcOTU0uyT8OeuoU3MFH2Us3yaKqPQA5BAgLKGggI5GyVp/XJbDEcjGuHRt8Rjss= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(376002)(346002)(396003)(136003)(451199021)(40470700004)(46966006)(36840700001)(36860700001)(8676002)(40480700001)(55016003)(82740400003)(356005)(33656002)(82310400005)(81166007)(34020700004)(70206006)(316002)(41300700001)(4326008)(86362001)(70586007)(478600001)(54906003)(110136005)(40460700003)(7696005)(8936002)(4744005)(2906002)(336012)(52536014)(5660300002)(83380400001)(6506007)(9686003)(26005)(186003)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 03:54:55.1500 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 80667c16-239a-4f66-ffe9-08db4c53526f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT065.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8454 Hi Vikram, > -----Original Message----- > Subject: [XEN][PATCH v6 02/19] common/device_tree: handle memory > allocation failure in __unflatten_device_tree() >=20 > Change __unflatten_device_tree() return type to integer so it can propaga= te > memory allocation failure. Add panic() in dt_unflatten_host_device_tree()= for > memory allocation failure during boot. >=20 > Signed-off-by: Vikram Garhwal Reviewed-by: Henry Wang Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Thu May 04 04:02:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 04:02:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529531.823983 (Exim 4.92) (envelope-from ) id 1puQAq-0006kS-MM; Thu, 04 May 2023 04:02:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529531.823983; Thu, 04 May 2023 04:02:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puQAq-0006kL-Jc; Thu, 04 May 2023 04:02:32 +0000 Received: by outflank-mailman (input) for mailman id 529531; Thu, 04 May 2023 04:02:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puQAp-0006kD-Sl for xen-devel@lists.xenproject.org; Thu, 04 May 2023 04:02:31 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20617.outbound.protection.outlook.com [2a01:111:f400:7eaf::617]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7d103d32-ea30-11ed-8611-37d641c3527e; Thu, 04 May 2023 06:02:29 +0200 (CEST) Received: from AS9P250CA0021.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:532::19) by AS8PR08MB7718.eurprd08.prod.outlook.com (2603:10a6:20b:50a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.25; Thu, 4 May 2023 04:02:25 +0000 Received: from AM7EUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:532:cafe::ee) by AS9P250CA0021.outlook.office365.com (2603:10a6:20b:532::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26 via Frontend Transport; Thu, 4 May 2023 04:02:25 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT013.mail.protection.outlook.com (100.127.140.191) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.21 via Frontend Transport; Thu, 4 May 2023 04:02:24 +0000 Received: ("Tessian outbound e13c2446394c:v136"); Thu, 04 May 2023 04:02:24 +0000 Received: from 7b7f01d2abe7.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CD37423D-E1B3-498D-A885-44CB77E5BD62.1; Thu, 04 May 2023 04:02:18 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7b7f01d2abe7.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 04 May 2023 04:02:18 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DB4PR08MB8079.eurprd08.prod.outlook.com (2603:10a6:10:385::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.21; Thu, 4 May 2023 04:02:12 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6%6]) with mapi id 15.20.6340.031; Thu, 4 May 2023 04:02:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d103d32-ea30-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XaxhynDBCTXoTSxI9Bm3w0rOkevBy3kSLJCJWr+icL4=; b=IRwSFvDzAgeDnR6J+MytlgvBsCqL6lf3vnFKbAb0PB5VtecbtO7oQJsIt3EEfK3K4IVhFhJDjLnb3T4aKWAyz6n14yF0JqyULws3LN9PMISBbvml4w2bP0Yyr4DxZXvV5IWrDmT+rnlBbtc1ydLiBDsmnjQxR/KMkNSkxaG9jmY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fhLDA9ktPq2qbTYeY6WxJxZiRrFFqqXN4z/8sryUytfp/AjOeCkmzJXqgJCJmspHo3G9npsebVwKm8FDtSIVDyNDhLcVCJFGdvUYlLoCa/zndqpv6YS49VBnRqzpXALkLihLgJLOwAAn7hFFKX2kVtj4XuE3GyqQV7aLQaa6j/oK2lYT6W0z1LHAH5Kdgbi2sin1F6IF9og0vTvUEMsbH0ZU8DjWwBPe3An7E+dA4RbLOibeBb5n7JpJJLf41IEIYFu7WslWCN9AmrAFSuGBr3t0e+q536nxM0TF/64R5+M47iOK8lZr1eCNQg9K/ZYKMs7NkxgKDLcYM6XI6FYA/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XaxhynDBCTXoTSxI9Bm3w0rOkevBy3kSLJCJWr+icL4=; b=JfwDmKb2yj2jFnKWYzQn5JLrFxY2F9aFiP4TjaNoR+x/5NWH/7sNiMzBA2gEKkpaJhkMW3j2MMFDt0R6s0Flxomxlm2Scd4Uyo9DzO74+GAePCe+VeeEPv1gVV+B7wB9JSXmXfmzBci/ah+w9pwUWFsKxsQqCGJ/lRTtdVcMeJQnQj8pmUBpDFm464EeYW2KPc7qpKrYc8jrixmzsfV4+NlM1sBB46aGutndhlppVukRZMvpyxv/elgks7GoGnCanCnd6EX3Tg3GEw41cfp/DOlySyROkhW6ITClQiwX/amCP5/ZletCnNMpeIXDfhOOi9QfiXEnINju5prCKQ3Yrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XaxhynDBCTXoTSxI9Bm3w0rOkevBy3kSLJCJWr+icL4=; b=IRwSFvDzAgeDnR6J+MytlgvBsCqL6lf3vnFKbAb0PB5VtecbtO7oQJsIt3EEfK3K4IVhFhJDjLnb3T4aKWAyz6n14yF0JqyULws3LN9PMISBbvml4w2bP0Yyr4DxZXvV5IWrDmT+rnlBbtc1ydLiBDsmnjQxR/KMkNSkxaG9jmY= From: Henry Wang To: Vikram Garhwal , "xen-devel@lists.xenproject.org" CC: "sstabellini@kernel.org" , "michal.orzel@amd.com" , Julien Grall Subject: RE: [XEN][PATCH v6 03/19] common/device_tree: change __unflatten_device_tree() type Thread-Topic: [XEN][PATCH v6 03/19] common/device_tree: change __unflatten_device_tree() type Thread-Index: AQHZfU8eFkyMAUM1+keBcOFUYgl+f69Jf5iw Date: Thu, 4 May 2023 04:02:12 +0000 Message-ID: References: <20230502233650.20121-1-vikram.garhwal@amd.com> <20230502233650.20121-4-vikram.garhwal@amd.com> In-Reply-To: <20230502233650.20121-4-vikram.garhwal@amd.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 3B261B364574344BBB4AF7D4E5CF721A.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DB4PR08MB8079:EE_|AM7EUR03FT013:EE_|AS8PR08MB7718:EE_ X-MS-Office365-Filtering-Correlation-Id: 65c2850d-fd5b-4c3a-ab3b-08db4c545e80 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 2wKQiCXB3W9owXHSbAT01FTBYDAAR5an3buN8KAewWeHxsJVxIFdeHNEISZmn7+p1ca/gaa5bFjTewUmoWOiQHQidphtLorI2mmXgTM1sVuSJq9OZ3HF5XUKssHcyVDLm0ELfbTA31ruQyns7xw8tpmIO/uy8kWPSKulmpgcaKRFs561nfm8tK/zsvVUdhXGE/br+WN+0pllDrpm8u9wvTnc0IAF2VYHdjhoruNVkYdzRDDsmhIXDW744OKK002G7xhJVi5o3M/VMsEgOTfGK3I86yU/pyv9lW6uVznXhpYI+EFfYHyI+OEAY475fy/5wRbJofViQKGInpPx+7t4HUwK/jknhkZWJjYFSmKXXGsv5afjJ4oGPJp2BJVd5jGykg/Uy6t7zvsvHtn6osuiJUms+Pe982hyXDo/5wo3IbVKihG7UsdPR4FFEOdK7tblDurchup+bW8MhCVQDIfpCWq9fzA/UFsUIrC/xbRQfxqYfJvncTduDpdGq0Gi47L6TVFe6lhJZDmZISqPFxORS0slo0l4ygtqpDW9/hqq0irkUEv2gAzotJEA7ZPrhTbrO83rplzTs+3gwlBz4i4gytFBp5IkklZ0rISTN9/W/DBhVr9GejY/ahCgtpbvfMZK X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(366004)(39850400004)(396003)(136003)(451199021)(2906002)(38100700002)(4744005)(8936002)(8676002)(52536014)(5660300002)(33656002)(86362001)(122000001)(38070700005)(55016003)(71200400001)(7696005)(54906003)(478600001)(110136005)(186003)(26005)(6506007)(9686003)(83380400001)(76116006)(66446008)(66476007)(66946007)(66556008)(64756008)(41300700001)(4326008)(316002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB8079 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9ad99b47-f05d-4115-55bf-08db4c5456d1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5VtMzY41cjmmAf9oevHWI0URtocUXtIJhvrAXQ0vUsK83/LNbln8s9E/yvzNzmJVeBz4k4hkD5arnKymn3h3iNDDgi19K3BDmhNUSK7e6pFrAupeg0H+eraTItURuHO57WNu95UFCrWnfUHLBmkO4gYkKK+pm6VSK88f+MEVT10BZzUPXWhAGHNer3qUW2y/1HynPEFVziumluwZ0jQ8Kj6r0B9uT9d86Io9gJrVDNgzaDD5pSpAuDEzrgtfa+35zEfWGH9WmDc7xfJgBaedWm2pUdDSXGFNsV7qTMtbxMYSLw/de970KZrZKq5kiav46kRyXiCAfvE06E8EvdMtqj4vzkSwGH3YeJqCtOim13a3RboGsrY5+0ALMjymaMTTyhR5S8rN/gtClcEtpn8f6NAitgMEYDx2HznV8ffGX3ZyOv9GDsd2ufdw16KDqmaa0xG+M+f513HPCzWoDYBSXmVIb0sJrq1HR4n2oXK6M8Co4OsN/VQU1vtj9vXdF6nTRLZKJmELm45rQ0DQ2Xuimz6BI+y6uJguziD+pk2hPYr5t4ZTCp5kbdnbyo7QzVvYm8E0s9b1onjyamnr+9LBtyGtYIhhb90BBFwg9fnZLjngQXsHrkSy6FUL9NpZr8YaU5gpNsrsciCKOTwpFgT5oPRqwopLmB39vUZYO+oCq3yLboJBUX0ZdrTh/nyYG40nA0iyjF462rfHhh9x8k4njDuMVIF66ci+vasL2TffMZo= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(136003)(39860400002)(376002)(451199021)(36840700001)(40470700004)(46966006)(34020700004)(478600001)(356005)(81166007)(40480700001)(55016003)(52536014)(82740400003)(5660300002)(8676002)(8936002)(40460700003)(54906003)(110136005)(82310400005)(6506007)(26005)(86362001)(70206006)(70586007)(47076005)(4326008)(83380400001)(7696005)(336012)(9686003)(316002)(33656002)(2906002)(186003)(41300700001)(4744005)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 04:02:24.8886 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 65c2850d-fd5b-4c3a-ab3b-08db4c545e80 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7718 Hi Vikram, > -----Original Message----- > Subject: [XEN][PATCH v6 03/19] common/device_tree: change > __unflatten_device_tree() type >=20 > Following changes are done to __unflatten_device_tree(): > 1. __unflatten_device_tree() is renamed to unflatten_device_tree(). > 2. Remove __init and static function type. >=20 > Signed-off-by: Vikram Garhwal I have a feeling that it may be better to swap the order between patch #2 and patch #3, so you won't need the extra name change in function dt_unflatten_host_device_tree(). But this is my personal opinion and I thin= k the Arm maintainers are the people to do the final call. Anyway this change looks good to me, either with the swap of patch order or not, you can keep my: Reviewed-by: Henry Wang Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Thu May 04 04:08:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 04:08:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529536.823994 (Exim 4.92) (envelope-from ) id 1puQGU-0007Sc-Di; Thu, 04 May 2023 04:08:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529536.823994; Thu, 04 May 2023 04:08:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puQGU-0007SV-Au; Thu, 04 May 2023 04:08:22 +0000 Received: by outflank-mailman (input) for mailman id 529536; Thu, 04 May 2023 04:08:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puQGT-0007SP-Dp for xen-devel@lists.xenproject.org; Thu, 04 May 2023 04:08:21 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2061b.outbound.protection.outlook.com [2a01:111:f400:fe1a::61b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4d88cf89-ea31-11ed-b226-6b7b168915f2; Thu, 04 May 2023 06:08:19 +0200 (CEST) Received: from DB6PR1001CA0046.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::32) by GV1PR08MB8178.eurprd08.prod.outlook.com (2603:10a6:150:92::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Thu, 4 May 2023 04:08:14 +0000 Received: from DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:55:cafe::68) by DB6PR1001CA0046.outlook.office365.com (2603:10a6:4:55::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31 via Frontend Transport; Thu, 4 May 2023 04:08:14 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT014.mail.protection.outlook.com (100.127.143.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26 via Frontend Transport; Thu, 4 May 2023 04:08:14 +0000 Received: ("Tessian outbound 3a01b65b5aad:v136"); Thu, 04 May 2023 04:08:14 +0000 Received: from 766ddd8ff3a2.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A74EA22D-9AE0-4D17-BCA9-94B26A60CCA2.1; Thu, 04 May 2023 04:08:08 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 766ddd8ff3a2.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 04 May 2023 04:08:08 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS2PR08MB9318.eurprd08.prod.outlook.com (2603:10a6:20b:59a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Thu, 4 May 2023 04:08:06 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6%6]) with mapi id 15.20.6340.031; Thu, 4 May 2023 04:08:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4d88cf89-ea31-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PWvM9wmLCUR6GOvCgPkahatkE9po1Rn73LzxnwCS/+Y=; b=sQ4+WLxRmFFVqd1gYweOBbK9jWht7Q7/XHL9e5jE0g3ni7GS7EVIfYY/Uf4B3ZQJogq9nhcDAXgqKeu4UQHWw3lDivpSTAEXnCgKCUIRP4WXevKYR2dm9y+m0JlxF7/3oFA6lAyCRiSvYCpCaMo0fBjYs3dBrfxVDppDtZSgjGo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZGFQcYUdgSBUTMm+Lw6cApFR/2rqnNOg4bjqpti2j9Ky2Oz4/i2Yh8TlpLJD+QEssBSCtyb7/vZzMkYt0FaeYPGm5GX4ElcEWczpbJvofBFfjeE5vJUKYXGPA3QBQNoUDOeVLTQYyrU6d1QTz4j9Zk+bkBfNtdUjEI9bNKwMi1pC8GRRCKyD4fOW28q7x/Prf+1Kcpc7p5sheclgnkhFhR7k4+pKoXXHMn6MDXU6fH0Fhu7mY7b8tKl/WSTYG62KIbvakAvZAIDCkqni/8lcqPEnmlO3gMnck9cNhoE+Dw1FkvPAr02vprGpHb7mTQNJfHhvMDVevS51IafZ0+E7Cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PWvM9wmLCUR6GOvCgPkahatkE9po1Rn73LzxnwCS/+Y=; b=EXh/rqwQZJZ5wAUZn905Fs/ae7n9CzMheieKlhfVoBkwMag+WC+SDY7x+33Kx/Mxx6r+RnxaYxpRAiNFHVC3AR96PMxnFI7ui8RiuGQqUIreTW3KWn7B+t+j0Jgds5xOMjgGHH4hyGDSUrAo6MAxxji+dSjuykLJtbzWIZXhiiCsBG9B2eMdtRt4spuoZaMf2Xw4t9PfZAV+snB1u4JS5WKSdUvUxv9yDWIik+eW60hbS2S7dzjWxMTUmTI3JKI2aA3XaCF7Vc1ZOH2/GnI18cfQIWGZ5LpFX4INhTs2QHHfQHiIFLH31NBav2JypsmwGaWd09zf8NIZ1IS2qpKVlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PWvM9wmLCUR6GOvCgPkahatkE9po1Rn73LzxnwCS/+Y=; b=sQ4+WLxRmFFVqd1gYweOBbK9jWht7Q7/XHL9e5jE0g3ni7GS7EVIfYY/Uf4B3ZQJogq9nhcDAXgqKeu4UQHWw3lDivpSTAEXnCgKCUIRP4WXevKYR2dm9y+m0JlxF7/3oFA6lAyCRiSvYCpCaMo0fBjYs3dBrfxVDppDtZSgjGo= From: Henry Wang To: Vikram Garhwal , "xen-devel@lists.xenproject.org" CC: "sstabellini@kernel.org" , "michal.orzel@amd.com" , Julien Grall Subject: RE: [XEN][PATCH v6 04/19] common/device_tree.c: unflatten_device_tree() propagate errors Thread-Topic: [XEN][PATCH v6 04/19] common/device_tree.c: unflatten_device_tree() propagate errors Thread-Index: AQHZfU8dTUEoDGBGd0KIZrm/bdcnRK9JgM7A Date: Thu, 4 May 2023 04:08:05 +0000 Message-ID: References: <20230502233650.20121-1-vikram.garhwal@amd.com> <20230502233650.20121-5-vikram.garhwal@amd.com> In-Reply-To: <20230502233650.20121-5-vikram.garhwal@amd.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: D3BF081E2E0A9140A7C268B1B873586D.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS2PR08MB9318:EE_|DBAEUR03FT014:EE_|GV1PR08MB8178:EE_ X-MS-Office365-Filtering-Correlation-Id: 8ce8015e-0feb-4fec-d84a-08db4c552ebd x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: T3hdUIoV3LZho5cDGA3nt5Cta3CvRGAupxs3iy/sspzML0MnGIj5em75YaRxcF3IhSzGCLB9uCGkm9tVRtntALvn1YSFbUmvwHi+f+b191PmMWQNCGeLFXCu/6xQgS9Czc2GdblbUupowdu+1MTATWP2v9cMrbbwl3SJNJGzUAKeVH1Hwm/9wivwgBhZmRD19vYVueV+8VyT+MKEx34Vr5hqWOSjFeDbBsCRR57ZUvL6sJtJCcyx5ZHiIKn0hAg7mpM7FGuGcoYtbwi/OpCGCYK8lGcUtEf4MMvQ1dnQZe45ZM8L04oCA4RoBEyk32j15cQhEl/jZo9GrsqbO92rUT+PDb/q2zJ3laKaoNayrYMoNXm1AqzULMO22TylFQ2R5riaY97AI1LKOAC7RWLvC3nHvx4cqhLEO3u23i2I+WEeI1HGn9hd14nAyw7EfCQcvxD8Cuws9Z3xujR2Kq7iDGHD5ngOYWeOYpUziUZa6Vm9LW7OjVffVaCAAFspDrx8cDpxxeSrcmb+Gqm5r9fK4w7dfWWI+Tw811tTANkujwQ+GFAljwHMJPjXpwz4vNaNyF8/IH0vPS4+1i4Vr2R6G2oELtlWLorYyE+U2sqz8Dtor6rg32IARPwV3er8FZ0H X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(39860400002)(136003)(366004)(396003)(451199021)(316002)(186003)(66446008)(41300700001)(4744005)(2906002)(9686003)(33656002)(26005)(6506007)(54906003)(110136005)(71200400001)(86362001)(66476007)(7696005)(64756008)(4326008)(83380400001)(66556008)(66946007)(76116006)(478600001)(38070700005)(52536014)(8936002)(38100700002)(8676002)(5660300002)(122000001)(55016003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9318 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 03990af5-4397-4b7d-6504-08db4c5529c5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zUFSVEjrVBptzOnu7Fzf+FHfOBWhkZ7OhgUPdVnw1Mw1geAz1qhU0qOUgEAmC/7bS6xs9Gtqwpj+W/gZthdtiUrgvIxE21ZSSDuFJuj6YoA48o63z5wvbiYd5GDoBhHihHUdxH3RdGP9ZArMGdMO6BsBO38PRu5znTa2/4/H1G3CNAL4FCJ5JX5tMI/sdNlkHIO8A8vqlpCzw9043oXz27sa48jx+PX2pCHm7FceZlbWWtBUR4qfgVu9EjM6DyLvJ7Dr4PIzd2JLFQs7cqKvLaHDh/3wRugpdnctvo/Oqf1Ir4xxeGE6FtEtnFiPIIQHpaowhTCYoMA2pLjMWuoBrD7p4KLdHf/AQH5svzM9AsSnXHR1Y7HBD+OEl9PMSfzQ6AuIGmjqufJ8JAPUqyXwk7rbwChuZLcM1jIhZHJScCkXKmJwXD6Lg9s5too7NEcdG/o5b9eylHoAFDkEEPMd3bp/PL3poUTT8Cp5aM71WNaT84LkLImEZeBWQk7J1q+DK+Z8Tet8x4SS985F7TvD56YXWKwljKstfZvtUygBNkutuDT0rfYPm/GnIRrbA1M2W2z2LctvsnvbAH5XX+Tiq04DI1ZyGommPYJMS0Jc1XxgueDe0zv6WMuYZRNxPa6PW3V2tMM20lfXcYvq71rPh2i06UfttPvKTQ+qsCbf45J0GkWTbChJd94IPMzDFe+Ayhi58HVFpqGBHivI/V6P9FgLQSh3D+5eEsrga79i4BM= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(136003)(39860400002)(346002)(451199021)(40470700004)(46966006)(36840700001)(8676002)(8936002)(36860700001)(40480700001)(356005)(82310400005)(41300700001)(81166007)(34020700004)(4326008)(33656002)(70586007)(55016003)(86362001)(110136005)(478600001)(70206006)(316002)(54906003)(40460700003)(7696005)(82740400003)(4744005)(2906002)(336012)(52536014)(5660300002)(9686003)(6506007)(26005)(186003)(47076005)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 04:08:14.3025 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8ce8015e-0feb-4fec-d84a-08db4c552ebd X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8178 Hi Vikram, > -----Original Message----- > Subject: [XEN][PATCH v6 04/19] common/device_tree.c: > unflatten_device_tree() propagate errors >=20 > This will be useful in dynamic node programming when new dt nodes are > unflatten Typo: s/unflatten/unflattened/? > during runtime. Invalid device tree node related errors should be propaga= ted > back to the caller. >=20 > Signed-off-by: Vikram Garhwal Reviewed-by: Henry Wang Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Thu May 04 04:11:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 04:11:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529539.824003 (Exim 4.92) (envelope-from ) id 1puQJU-0000TX-Rt; Thu, 04 May 2023 04:11:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529539.824003; Thu, 04 May 2023 04:11:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puQJU-0000TQ-PE; Thu, 04 May 2023 04:11:28 +0000 Received: by outflank-mailman (input) for mailman id 529539; Thu, 04 May 2023 04:11:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puQJT-0000T9-JW for xen-devel@lists.xenproject.org; Thu, 04 May 2023 04:11:27 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2060d.outbound.protection.outlook.com [2a01:111:f400:7d00::60d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bceb1300-ea31-11ed-b226-6b7b168915f2; Thu, 04 May 2023 06:11:26 +0200 (CEST) Received: from DB3PR08CA0007.eurprd08.prod.outlook.com (2603:10a6:8::20) by AS8PR08MB8969.eurprd08.prod.outlook.com (2603:10a6:20b:5b4::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Thu, 4 May 2023 04:11:22 +0000 Received: from DBAEUR03FT020.eop-EUR03.prod.protection.outlook.com (2603:10a6:8:0:cafe::89) by DB3PR08CA0007.outlook.office365.com (2603:10a6:8::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26 via Frontend Transport; Thu, 4 May 2023 04:11:22 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT020.mail.protection.outlook.com (100.127.143.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.20 via Frontend Transport; Thu, 4 May 2023 04:11:21 +0000 Received: ("Tessian outbound 3a01b65b5aad:v136"); Thu, 04 May 2023 04:11:21 +0000 Received: from f58563182d46.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C3930B08-7ACF-4A63-923B-820A0CEB416C.1; Thu, 04 May 2023 04:11:15 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f58563182d46.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 04 May 2023 04:11:15 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS2PR08MB9318.eurprd08.prod.outlook.com (2603:10a6:20b:59a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Thu, 4 May 2023 04:11:13 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6%6]) with mapi id 15.20.6340.031; Thu, 4 May 2023 04:11:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bceb1300-ea31-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fxay42dSdmjWN8IT6/RlKiEPIPktamK7xVeI87saUeg=; b=qrEwkInrCzW9aNRH/D2CbUoY8lTIBEDk2gqRTy0YTZgc7qpEGR5EGA6h3MkaqB0yLWNM7FSraWf7kxwHIch+Tgg3iwbGDMpT3EcWRvmiC/dTqg0GMeq83Zaw8uapYhGjBDSEN/Nae9foIZpO0mhCTJYRDqsjKyN1f6pAp+QIb50= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KGFou6L6yyLFXannkGB0McshBhr7X1odx48U/zRMDhhL8c/bTrW3VP0LH/uJsgG2qXfPjiL74GwaPJn/np8LCif9kHsd6p5Pg9zVWEbIuk3pOQhaZi6wPN8TJdaNtRrWakIt383+Hy9lUy5tPYA4uAijQttmdAKnslYBpG7NF8+tY+kJ/VcGyFxCDYA1+gkW3GxOzXONGOMYOehoU9vxyXis5PayngUIeryzqegVY/0m3fKv3Zm+XLC/C+vwrV9sj2NvnFk3pfzee/XARLqEEMMZ+5i1qCRM6tbS//XACLkpltA7DaF0rmXJPcBwC+YQ9JxhXEpHgi/211xgKQ49Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fxay42dSdmjWN8IT6/RlKiEPIPktamK7xVeI87saUeg=; b=j/pbfzpj9dEqabyTCIhH3VR1nNp5cETezwcRjnBEYEaQ2U7rXRSXFpU9Mi8HvW7HByzRrlXxOAoq15JSHi++W3ugS/aKQbjlm6ELgaSAx6LSLII0wHdGP8r5vaocj1fVAmMiyYj5Eyr0IDdSab6gJaksGc6sC3sNP1Ko/S4FjUsv0sT/ekhhfNmpzcDx/LC0nAbtEEMR6Lh0iNWWHPbV9EsSfCDAqXNGB9JU/BEwADCFphAGvgR4uJH2VEJmxmoPuHLk5vXSTJmatzDSibOUWvfckNa8Zv1gk7eNOfEkzU1z6QMNoLA5/Vs+9c4ae9Cg7gFNI0f7G92PwSX6oDF4cw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fxay42dSdmjWN8IT6/RlKiEPIPktamK7xVeI87saUeg=; b=qrEwkInrCzW9aNRH/D2CbUoY8lTIBEDk2gqRTy0YTZgc7qpEGR5EGA6h3MkaqB0yLWNM7FSraWf7kxwHIch+Tgg3iwbGDMpT3EcWRvmiC/dTqg0GMeq83Zaw8uapYhGjBDSEN/Nae9foIZpO0mhCTJYRDqsjKyN1f6pAp+QIb50= From: Henry Wang To: Vikram Garhwal , "xen-devel@lists.xenproject.org" CC: "sstabellini@kernel.org" , "michal.orzel@amd.com" , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [XEN][PATCH v6 05/19] xen/arm: Add CONFIG_OVERLAY_DTB Thread-Topic: [XEN][PATCH v6 05/19] xen/arm: Add CONFIG_OVERLAY_DTB Thread-Index: AQHZfU8esEuGfevR30ChHQjU9+v2dq9JgYNw Date: Thu, 4 May 2023 04:11:12 +0000 Message-ID: References: <20230502233650.20121-1-vikram.garhwal@amd.com> <20230502233650.20121-6-vikram.garhwal@amd.com> In-Reply-To: <20230502233650.20121-6-vikram.garhwal@amd.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 97A432DCC59437498D34F28A40C1798E.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS2PR08MB9318:EE_|DBAEUR03FT020:EE_|AS8PR08MB8969:EE_ X-MS-Office365-Filtering-Correlation-Id: e56dfe3e-d323-4327-94e2-08db4c559e6c x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: tInXyNO8hj44Vsiq4fqyQS6PWbzKj3/Y8i+FU7ZJZejnEodZx5228Og0CFwpo8MxUoXgO3SeAlzm1fhZDJxOrYNgzC6TSNpdb763BdmhIBaN0PXiu4VTvyuPZPB+ahgzoc7+DqM8hZ8KMKQ269ultHN+B+cCKJDokX65GQx6hR29wcYLqncFIGF4MKVJnAMjUux0GLbpGM8V1fg/LvhUT/bTrPmrtjIrdEhkDG5NBZ03cdDvuzzfFR26b8LqQVz5rYm5S5BUFzjCQhc2J+MyskBnZDKQ/1NRZ4E/KFgkntJXMCUZPsaNWHDc1h9oV+zCsCt7d0sya3hXiUjCZj+N04XHQqmYi7sp7EhTFL0i/hdP/P3Kk6HZcArkE0OzxLLOYOvYlF+nvgQ28zz68hg/cGtSxULjAJ44xbqYmRU0OCPZyrjUJi07Yx/XdRjLfDmm4G07XhJMWtViB6i9NIccvfOHxRplwzmn4qjEuEiiTrFSrQyTmE8VUvWCxR1ibbcGBFsc3nWoQi7XvGSkFaQMz8X3t6K00JDxf6bgjn8Qr1XbN2brjuWnKzVqPa9/ZT8bcKZq7Sz2UxQZ1V06JtOwIbG47NwzLyGLVVAsieJKiiQkiQHC4XLze4kcIlyaHJmb X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(366004)(136003)(346002)(376002)(451199021)(38070700005)(7416002)(478600001)(122000001)(55016003)(52536014)(8676002)(5660300002)(8936002)(38100700002)(110136005)(71200400001)(54906003)(6506007)(86362001)(66946007)(66556008)(76116006)(66476007)(7696005)(4326008)(83380400001)(64756008)(26005)(66446008)(316002)(186003)(33656002)(9686003)(41300700001)(2906002)(4744005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9318 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT020.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 124e434a-952d-438d-4aab-08db4c559936 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: D6G+VX+dKBTBdUcjDsvD+R6/kXGYFuI88hRAsT8hopAzHcb78bIPoeIpUg/OMtfqF7Ke4oYFtApsexvsVCHI2zWF3y49FQ6GYASaySANkPreyUGAqKP5+vl1b/IJaryQ7vRNBj0qYUFrbghXI0x4kRTMo513UU1S6V9Tn0y7Vp8NbzJW6ygI9QZYRTRUtlKGWWXx3ApIQcD+ubOeAqSvcPv/GDm1t4McCSyB4ZbrD2gPaFlHyYqt56cqhKFuLNDjyin9th9i7UquAwN/oL49gyOvDLy2tPBAR7dNSo4zaca5e51jgET35S/CcSf7vOoocN8Ui7m/r0NYRkXXuvwu1mpxCRDRUAnjs2296jqRJX9PrODa8Y5b8abEAPLR7DQYHXcPzWrJsUIoUsNDlbHKZqV9Zw8cZmdwWWcL5RG4XBj6fxzdhPhvPrxEy8o6vYuefgCnugFsc7Kfj/EP6eNPQ9n9a6sMOT1yQWP03OQOCSADsLOg2sQ8WHhHlFiC+oZUJ0ULyUoXq6ORfRSJ4emVa+CC1CHGF1+A0Ukm4+j+2OltRAdnymlN0KSCUB87hy6mEN0EWK0ptromh9yE/9mGlcpeNII11OlQ89FJ4RoyEM1K1XeGbfzilnT2k3f0hawI5FGSRi3quCe/dJ2RWep01qgCRYQc1ndqSgVA1Aq28DvoNpP6VcnqA/S/vHfZ2hN6raQkT/F7iOULn35ediebxzVvXfz4W1cCc+VxeqaiRg8= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(376002)(346002)(396003)(451199021)(40470700004)(36840700001)(46966006)(82310400005)(70586007)(41300700001)(83380400001)(40480700001)(336012)(33656002)(4744005)(2906002)(316002)(34020700004)(55016003)(5660300002)(478600001)(52536014)(4326008)(86362001)(82740400003)(70206006)(356005)(81166007)(110136005)(54906003)(7696005)(47076005)(40460700003)(36860700001)(186003)(107886003)(6506007)(26005)(9686003)(8936002)(8676002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 04:11:21.6591 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e56dfe3e-d323-4327-94e2-08db4c559e6c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT020.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8969 Hi Vikram, > -----Original Message----- > Subject: [XEN][PATCH v6 05/19] xen/arm: Add CONFIG_OVERLAY_DTB >=20 > Introduce a config option where the user can enable support for > adding/removing > device tree nodes using a device tree binary overlay. May I please also suggest adding a CHANGELOG entry in the "### Added" section? I personally think this series deserves a CHANGELOG entry but I am open to others' opinion though. Thanks! Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Thu May 04 04:14:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 04:14:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529542.824013 (Exim 4.92) (envelope-from ) id 1puQMG-00014L-9z; Thu, 04 May 2023 04:14:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529542.824013; Thu, 04 May 2023 04:14:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puQMG-00014E-6f; Thu, 04 May 2023 04:14:20 +0000 Received: by outflank-mailman (input) for mailman id 529542; Thu, 04 May 2023 04:14:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puQME-000140-HR for xen-devel@lists.xenproject.org; Thu, 04 May 2023 04:14:18 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2071.outbound.protection.outlook.com [40.107.7.71]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 22ca196c-ea32-11ed-b226-6b7b168915f2; Thu, 04 May 2023 06:14:17 +0200 (CEST) Received: from AS4P195CA0001.EURP195.PROD.OUTLOOK.COM (2603:10a6:20b:5e2::8) by PAWPR08MB10017.eurprd08.prod.outlook.com (2603:10a6:102:34e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.36; Thu, 4 May 2023 04:13:48 +0000 Received: from AM7EUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:5e2:cafe::41) by AS4P195CA0001.outlook.office365.com (2603:10a6:20b:5e2::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.25 via Frontend Transport; Thu, 4 May 2023 04:13:48 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT046.mail.protection.outlook.com (100.127.140.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26 via Frontend Transport; Thu, 4 May 2023 04:13:47 +0000 Received: ("Tessian outbound 3570909035da:v136"); Thu, 04 May 2023 04:13:47 +0000 Received: from 935fa7e549fd.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 382A2462-025A-48FB-86A2-9B54290EC670.1; Thu, 04 May 2023 04:13:41 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 935fa7e549fd.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 04 May 2023 04:13:41 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS2PR08MB9318.eurprd08.prod.outlook.com (2603:10a6:20b:59a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Thu, 4 May 2023 04:13:39 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6%6]) with mapi id 15.20.6340.031; Thu, 4 May 2023 04:13:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 22ca196c-ea32-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C3kU+1WbGesUTX/nZUfvqnyHgj4JvcY4aYWwS7cXBno=; b=PZNlDyRsB1aXaOVAURS+iO17+j2kjnu9+KEp+JAu+1ajgtnE9nO7PVD5zhYoFmPlyUK45QcwFhECAqViRNorNyjDuViMplurl3sQZYoN/3ckXwJ/DUbyEmsM3SvPQFAA7o23LKgj5eCSrzrWD3lOx2+9yFgPSFRMQoQ5AXgYsFI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jLxvT5ggCmmSVQy73NC25iTWkS6CNVZKgNxn8nc8oeaphV7pt9H4cZInVKCLpBgi/mptK4YNAqwEkbGFDNuOIQDA2tu8dmm1zlX0HIEx9UfnqoRbClFwPtupflpSkXlsDlpJt7ifCCWFX20PwkT3YTxGbadCGc4ZEzzeUhKg2bYzfHvZny6Q7UwHIQ/X7SIWAhb9pXfxVZc6ljfImL0zZihn1/vAopDmba7gmS+RP79FOASdUk6rvntlcR8cjbhgS/Um9r3PM07LPO/CAHG4t1j+ynrDYgug8EfhBp7C7t5elhwF2Slq8fVFqGq4VS1xDCICo1FyT8Y10oX/VJMgkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C3kU+1WbGesUTX/nZUfvqnyHgj4JvcY4aYWwS7cXBno=; b=XiFy/0yq9tZ2OdxoG/ghQk8trvww9wKWpprYaQ3QfC8TbfEL0T4m6J887eF3umlxcMZVs2MpdAXqZ5slxQvhUgw5Tmk9ZzVOacsAKN8ZZTFfcgSVzUshyJmDawvBbuFjJ9duTsLoKoSx5UJidNh3xP+dfU0FZp3+XuAQwsivCbFksWg/OL01nV4gVkW3G67ODNzyrpbfW54oYo4CFt6mGaVL94HPriYzYqwzfvCn/ym3dWcuB2ajmRx3lhPpTy/U5vbKQUAD3Txuvq27+l8onjQo9jWunMG6gJnTa6q1E/C4/crM5OqxxUdoLcLXCt/ebaVG4+jqljwiTWdxqJOnhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C3kU+1WbGesUTX/nZUfvqnyHgj4JvcY4aYWwS7cXBno=; b=PZNlDyRsB1aXaOVAURS+iO17+j2kjnu9+KEp+JAu+1ajgtnE9nO7PVD5zhYoFmPlyUK45QcwFhECAqViRNorNyjDuViMplurl3sQZYoN/3ckXwJ/DUbyEmsM3SvPQFAA7o23LKgj5eCSrzrWD3lOx2+9yFgPSFRMQoQ5AXgYsFI= From: Henry Wang To: Vikram Garhwal , "xen-devel@lists.xenproject.org" CC: "sstabellini@kernel.org" , "michal.orzel@amd.com" , Julien Grall , Vikram Garhwal , David Gibson Subject: RE: [XEN][PATCH v6 07/19] libfdt: overlay: change overlay_get_target() Thread-Topic: [XEN][PATCH v6 07/19] libfdt: overlay: change overlay_get_target() Thread-Index: AQHZfU8lidJvDau6tkqOqDCcDCOd6K9JgsNA Date: Thu, 4 May 2023 04:13:39 +0000 Message-ID: References: <20230502233650.20121-1-vikram.garhwal@amd.com> <20230502233650.20121-8-vikram.garhwal@amd.com> In-Reply-To: <20230502233650.20121-8-vikram.garhwal@amd.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 8EB2B4542D95134BB0A71869053B359A.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS2PR08MB9318:EE_|AM7EUR03FT046:EE_|PAWPR08MB10017:EE_ X-MS-Office365-Filtering-Correlation-Id: 11a288c1-5c2c-4909-0948-08db4c55f565 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3IKUGnKAyCG4He4Cr6wW2BGCouWJapks1E2DlcMKUo3mPAuAQWlhjjKOIo5YwEKaGI+qhkFs6yAgRupFKP1O83heVP/DwouEtf8d6IDX64Obkpq50eNITM6MsTIHoGqn/VU/HQTv9hUeo+XhTyDod31YKxruu2GMV7782nPRY+bRIDL7I9JI0BcV5ciP2Tc78WRuExApvb1hYB8v0trB7xB/roWWKDFqDRLqj2iYORQ4dnU0+ChLa3MYH7iiS/CgjfWnyO8ZSyqajrUAN0Yiu9uysn3VRjbQa+a9Z5sHGKJyQiFSM+gWnyoJrpgAaqhQp6ohicGUcDSYoRO9fPtNaeEb3U8dUKFp9Cf+Ais/XRMt+3RifymEKehCxV8iI2Fg4DA6KJXfEt/jtCEEK0+2z9tpCwg8v/LF3HrtZ0WRi75WdDY8OEHrZFd0Xg0X6o5Rhgbb23ddvPcTimn7gkRjiA7tVI3KfXnrgwl6LTcQB2/dxtA6LV5J0RDF8pg90vLzslQUbO3SgxfKQbpRQmu3HD64rgc/2hhOs1yx6O+rR0yPh14VOfmpjN1CgsBt2fkW4P2y3GsSA00bqcAnTc+gkxzXoXMXXLI6I+7mZRNqfZi09C6bRm0c5XeRWMyfyOtJ X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(366004)(136003)(346002)(376002)(451199021)(38070700005)(478600001)(122000001)(55016003)(52536014)(8676002)(5660300002)(8936002)(38100700002)(110136005)(71200400001)(54906003)(6506007)(86362001)(66946007)(66556008)(76116006)(66476007)(7696005)(4326008)(83380400001)(64756008)(26005)(66446008)(316002)(186003)(33656002)(9686003)(41300700001)(2906002)(4744005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9318 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5b518887-47c0-47d0-fc2c-08db4c55f06d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JD/dNjjbdY3Uww9hh/hSZZCW3QTbUvU0tLUnE4sG7Tixy+GdJYavXCmdcx3nLV4uRA/xdtoZo3BKRgPgck6MNiiS0Ze7If308hZyneI019uUViqv0IV1lugBp0mBw1apDfrdVqyfSQGcxjVI4maPvu4DOSfgtQkdXclgUdv1ZhLUIYCrMHUBZHbDJMkdOlT8vLdA+3Q+sv2pOCa9FsXpKvzZFe6t212C7Eeya6UZgUX3fD36jrS+XNBWDa5+ejg+Fv/XQ/7vra4Ifx8jKFmmhWsRubUiA+vkUSSIyRh6BomG2I+GiOjRrin06RiXCWkXBKb6C9kP+5YXlaiBWpX2sK8wtgOC+e/BE/L0Y23C08Ch1pI9+bS6I/5fIxdenFPqVp035BuwwwUwomXlMLL6s76kjLBLh442adbgHs96DJJQWn6A6mEd1LheyXI3tv15xOFX6dK80FebR2AAB4F8j9x9DYYfwoxv2cytFkFqxzadvzDEmXsxSQG0clnq5ckthbOT016ufmnjDaCxWLevrgXM4iXUC0S96MB5iGjijGelr0LGzJBvWEi0yLH7qFgQop6mHxPmyv5Ua04Pf/PRTJr7se+J9MlOACRZ9yfTPgX70PKJJZbTXfyz4WjezDy01nVkX67OFbdc0DcNm2Na0czDgHukNgv+HxffZpn7KPS5qMj+Nwj3MRK6p/TH7Dsb6msyAYS0111EWPbhTSDiXcxAFNWy74SxAdA5/LgVeR0= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(39860400002)(346002)(376002)(451199021)(40470700004)(36840700001)(46966006)(40480700001)(34020700004)(478600001)(356005)(81166007)(55016003)(52536014)(82740400003)(8936002)(5660300002)(8676002)(40460700003)(86362001)(7696005)(54906003)(82310400005)(26005)(2906002)(6506007)(70206006)(47076005)(70586007)(336012)(107886003)(83380400001)(4326008)(33656002)(316002)(186003)(9686003)(41300700001)(4744005)(110136005)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 04:13:47.5402 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 11a288c1-5c2c-4909-0948-08db4c55f565 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB10017 Hi Vikram, > -----Original Message----- > Subject: [XEN][PATCH v6 07/19] libfdt: overlay: change overlay_get_target= () >=20 > Rename overlay_get_target() to fdt_overlay_target_offset() and remove sta= tic > function type. >=20 > This is done to get the target path for the overlay nodes which is very u= seful > in many cases. For example, Xen hypervisor needs it when applying overlay= s > because Xen needs to do further processing of the overlay nodes, e.g. > mapping of > resources(IRQs and IOMMUs) to other VMs, creation of SMMU pagetables, > etc. >=20 > Signed-off-by: Vikram Garhwal > Message-Id: <1637204036-382159-2-git-send-email-fnu.vikram@xilinx.com> > Signed-off-by: David Gibson > Origin: git://git.kernel.org/pub/scm/utils/dtc/dtc.git 45f3d1a095dd >=20 > Signed-off-by: Vikram Garhwal > Reviewed-by: Michal Orzel Reviewed-by: Henry Wang Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Thu May 04 04:23:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 04:23:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529547.824024 (Exim 4.92) (envelope-from ) id 1puQVH-0002rY-7l; Thu, 04 May 2023 04:23:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529547.824024; Thu, 04 May 2023 04:23:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puQVH-0002rR-4g; Thu, 04 May 2023 04:23:39 +0000 Received: by outflank-mailman (input) for mailman id 529547; Thu, 04 May 2023 04:23:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puQVG-0002r0-Ck for xen-devel@lists.xenproject.org; Thu, 04 May 2023 04:23:38 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20618.outbound.protection.outlook.com [2a01:111:f400:7d00::618]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6ed1914b-ea33-11ed-8611-37d641c3527e; Thu, 04 May 2023 06:23:34 +0200 (CEST) Received: from AS9PR01CA0004.eurprd01.prod.exchangelabs.com (2603:10a6:20b:540::13) by PAXPR08MB6672.eurprd08.prod.outlook.com (2603:10a6:102:137::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Thu, 4 May 2023 04:23:30 +0000 Received: from AM7EUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:540:cafe::ce) by AS9PR01CA0004.outlook.office365.com (2603:10a6:20b:540::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26 via Frontend Transport; Thu, 4 May 2023 04:23:30 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT039.mail.protection.outlook.com (100.127.140.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.25 via Frontend Transport; Thu, 4 May 2023 04:23:29 +0000 Received: ("Tessian outbound e13c2446394c:v136"); Thu, 04 May 2023 04:23:29 +0000 Received: from f83775cd8bbe.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2CC55D5F-6E59-4398-825A-921D5D0CAAED.1; Thu, 04 May 2023 04:23:23 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f83775cd8bbe.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 04 May 2023 04:23:23 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by VE1PR08MB5742.eurprd08.prod.outlook.com (2603:10a6:800:1a9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Thu, 4 May 2023 04:23:18 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6%6]) with mapi id 15.20.6340.031; Thu, 4 May 2023 04:23:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6ed1914b-ea33-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/HYqL7xhkw9+WdB4I1aHYn7t4ZClm5rVJZUpNZxuLvU=; b=GGwvP4wRizwIhmXGXkRlDay4pfHwTO7J6ibCdRpkTq1lGKk966seetuNM41l5TxaqS/TlOQJxlll+RG/NzF7zgHCOX6mCbTkYkORunjtM3nsbeujLVh/+cXJ0GZ4SI029mOdhJfolx8+QcMLPgJb255oqCLmsNVDfjIvId9lVPo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QldMFTUaabUlA+KJ6xPGELEqViReWBaQt2iHFKymtJgzm6p8LxGn9J1OazTlbsCmVPVX25dWM2+dUoDH6ikVSGf5GMYF4ngXEwsJeT2pXGpLrVd267Rty020tRaaGMo0otVxqFwsW9KX6BkyzpyV+WvUj2tUGQT0+BezBWPK0naEHX3+ISlr6lmK5bDhsv4cScx6Byx2PojBQ+0WhSTubIBuq8EsSi98zOs84ft+2kVVPe5bGh9gYip64nwVX32Y5yC3nDAtuHvXqgJ1mP/OB7izm9n9WYwF+ur7i8QvzQxkmaabl02Rsrfe16ZNnawDHjIdbhKQ+x7/pMxnbog/hA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/HYqL7xhkw9+WdB4I1aHYn7t4ZClm5rVJZUpNZxuLvU=; b=KC+SyAoSAaq1bonYkrT6FSLYodgAkOA7/JKTrcLMweOew+qXY3NQCWj0RvqYXuGDDhtPQ8HS1EPv7scFTK326IdFuXAgx2HxPChIT+n8WWPSkiV1G7bB+qezVjL72xr32sxufLuiLVvlnAJtKdYEnr1ytysN4yssFf5HffJLu3SJoSgWeG5QanLP3ZV7NjBSVuk61nmFOYEIWF7Pp31PF9lr92TuSyhK8q7QgMrZOY0ehR548hBhmUvsoUtV3ZT0fmHObKyvtuQ8Eoz/rvovNdrVhzoi7C4F0lAATXN/DQZ20IicN+wzBon3cA9zzDHmNKhXx9GQWm8DBJr/CpsQgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/HYqL7xhkw9+WdB4I1aHYn7t4ZClm5rVJZUpNZxuLvU=; b=GGwvP4wRizwIhmXGXkRlDay4pfHwTO7J6ibCdRpkTq1lGKk966seetuNM41l5TxaqS/TlOQJxlll+RG/NzF7zgHCOX6mCbTkYkORunjtM3nsbeujLVh/+cXJ0GZ4SI029mOdhJfolx8+QcMLPgJb255oqCLmsNVDfjIvId9lVPo= From: Henry Wang To: Vikram Garhwal , "xen-devel@lists.xenproject.org" CC: "sstabellini@kernel.org" , "michal.orzel@amd.com" , Julien Grall Subject: RE: [XEN][PATCH v6 08/19] xen/device-tree: Add device_tree_find_node_by_path() to find nodes in device tree Thread-Topic: [XEN][PATCH v6 08/19] xen/device-tree: Add device_tree_find_node_by_path() to find nodes in device tree Thread-Index: AQHZfU8kxczuWvlyd0qZ9yNYcQTG6K9JhHkw Date: Thu, 4 May 2023 04:23:17 +0000 Message-ID: References: <20230502233650.20121-1-vikram.garhwal@amd.com> <20230502233650.20121-9-vikram.garhwal@amd.com> In-Reply-To: <20230502233650.20121-9-vikram.garhwal@amd.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 9532491CA0CA444AB7D822D303AFE3B8.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|VE1PR08MB5742:EE_|AM7EUR03FT039:EE_|PAXPR08MB6672:EE_ X-MS-Office365-Filtering-Correlation-Id: a91a931b-0fbe-4635-9a75-08db4c575030 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: NASxhxlVnZp8OrUzQvzGDhRAqRAm7P2N6GSaFDhGOQL5176YCoRo3lOqRp5XvePbVMxAlVsXB++76GDPSh5/qIdTWCiej5Vna7ms+jc5w9pRQ0c0QnxOkYT9ETZOXGHw/KbDOykWMFlSRrZvE/8nepliabffW0hsyTvi6/UvRBVMUmoyU4dMuRQPGtago72OmCScEsU7Wk96+HqGxNRJ/VbLsiQfwzXcSfx1VoLJ2YKOGeDt+Y3KF+N34cCZnKw6cHU3dS9ZIfu7nMnIoRZsCA4TDaXJFO5SImfT0HqGn0xKgk9Eyk29brd7D5zgm273QTwVvCiQN6K2p7d3PgCB+f8qNGFmORR53vYmb8SVd4YKdEqqF3OxR0J5qGWKHyppaehCpy6SXzRELTjOgkr4BampOi3uaPs07M0uy72/ldcBKkuNpcS3CPuOxg+rJXtBjBXLAI1iklGEHX5wUSiUYogiX6dUr9nruzt+V8eENgqXEUbYszMStNp31m+Npnfevi0FyMHkr2VrsrJCstNIf33nufDFQtDJuFQpPPDO4GcJS/ffELQZXd10LkWG04+LFEEE2wmXJeSQdUVEq4vB5/ZFrbYji7xgnFVZHitFKEQ7rjzkNz2jVlu+wBWa1t8MrX9gTS0Ke7oiOXoMlVqgsQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(39850400004)(376002)(366004)(346002)(136003)(451199021)(52536014)(8676002)(8936002)(55016003)(7696005)(86362001)(71200400001)(4326008)(316002)(33656002)(41300700001)(38070700005)(64756008)(66446008)(66476007)(66556008)(76116006)(66946007)(122000001)(5660300002)(478600001)(38100700002)(2906002)(26005)(54906003)(110136005)(9686003)(6506007)(83380400001)(186003)(37363002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5742 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 762f33d9-5b21-4aad-bb9b-08db4c57494b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6ZY0uS7Jpe0PCPLFfA8Z+uuJOEdkixKYLR62d1AQ0Kr35rVRBr+cVeoFu25p5yiBEeTbfqvtdX+wTdepTG+el5GYg2IT052R2mw4YxaCSL+lTCSkymP49i++FEw+V6bffBZCfK08DT53VcMlj3nSAi5K/elFmy5Y4MTei/oPfGyIdxZV2cGHEg+fj1dPCHT4ruuPb2ejxyirQsk2T5WBQNilH7dFPVope07HPc8f5hJ1/6twybya1uMmAW1h0CZWs+pqnQ7WsQNl5OBLX46HGrPMCTE8hz3pcbglKAbRSGHAeqM8b0kVGLUyT3zIcbud7xVd5f3+NmO4ls2ipzx+i8WhKtsBvR9429aPlc9VrPsr3R24gWEFA6UZfVSrdZelTGS/FDbeqPPViUxEX1zksyrUvMjiMvpL7QUFlQ+ee/jJSTM7gmghZIJMCHFJhcKGyJya6CjCzlg9k1XZD4naCMl6zp8XLHDFqLkMTyNs+hF16P4mGgpeonrPLqRjciLkVmY5Vio24ktI2pkEvWFbSlUn93eh15UK3876JwMD/XrtbYmmPkAnA0L+2epS248qavWIePgj+LjgtKYy4ILXJFw91cv5rT3K8XoEm54N8QWWaVVM24MCuKAM/9XONhfFE+mfCEC5d96RQIONigE0TghKwSBykJw4WoDV2B53abNOoHqZ5X9mI1KPu3lyoFK364Qw1yNc1ogBdvGLXwDgrn3EyS+vl06XmwKspMJ1Lh/rVIp/mJkW/fBblz5Id0Dib6n0ngGNzICH9lfdlDOE2g== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(39860400002)(346002)(376002)(451199021)(36840700001)(46966006)(40470700004)(52536014)(34020700004)(8676002)(55016003)(40480700001)(8936002)(82310400005)(4326008)(316002)(7696005)(86362001)(41300700001)(33656002)(70206006)(70586007)(356005)(81166007)(40460700003)(5660300002)(82740400003)(478600001)(336012)(83380400001)(54906003)(110136005)(47076005)(2906002)(186003)(9686003)(26005)(6506007)(36860700001)(37363002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 04:23:29.3816 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a91a931b-0fbe-4635-9a75-08db4c575030 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6672 Hi Vikram, > -----Original Message----- > Subject: [XEN][PATCH v6 08/19] xen/device-tree: Add > device_tree_find_node_by_path() to find nodes in device tree >=20 > Add device_tree_find_node_by_path() to find a matching node with path for > a > dt_device_node. >=20 > Reason behind this function: > Each time overlay nodes are added using .dtbo, a new fdt(memcpy of > device_tree_flattened) is created and updated with overlay nodes. Thi= s > updated fdt is further unflattened to a dt_host_new. Next, we need to= find > the overlay nodes in dt_host_new, find the overlay node's parent in d= t_host > and add the nodes as child under their parent in the dt_host. Thus we= need > this function to search for node in different unflattened device tree= s. >=20 > Also, make dt_find_node_by_path() static inline. >=20 > Signed-off-by: Vikram Garhwal > --- > xen/common/device_tree.c | 5 +++-- > xen/include/xen/device_tree.h | 17 +++++++++++++++-- > 2 files changed, 18 insertions(+), 4 deletions(-) >=20 [...] > /** > - * dt_find_node_by_path - Find a node matching a full DT path > + * device_tree_find_node_by_path - Generic function to find a node > matching the > + * full DT path for any given unflatten device tree > + * @dt_node: The device tree to search I noticed that you missed Michal's comment here about renaming the "dt_node" here to "dt" to match below function prototype... > * @path: The full path to match > * > * Returns a node pointer. > */ > -struct dt_device_node *dt_find_node_by_path(const char *path); > +struct dt_device_node *device_tree_find_node_by_path(struct > dt_device_node *dt, ...here. I personally agree with Michal so I think please fix the comment to keep consistency. The rest of the patch looks good to me, so as long as you fixed this, you can have my: Reviewed-by: Henry Wang Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Thu May 04 04:39:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 04:39:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529550.824033 (Exim 4.92) (envelope-from ) id 1puQjx-0004Yk-Gc; Thu, 04 May 2023 04:38:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529550.824033; Thu, 04 May 2023 04:38:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puQjx-0004Yd-Dw; Thu, 04 May 2023 04:38:49 +0000 Received: by outflank-mailman (input) for mailman id 529550; Thu, 04 May 2023 04:38:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puQjw-0004YT-0W for xen-devel@lists.xenproject.org; Thu, 04 May 2023 04:38:48 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20602.outbound.protection.outlook.com [2a01:111:f400:7e1a::602]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8e057a87-ea35-11ed-b226-6b7b168915f2; Thu, 04 May 2023 06:38:46 +0200 (CEST) Received: from AS8PR04CA0009.eurprd04.prod.outlook.com (2603:10a6:20b:310::14) by AM8PR08MB6545.eurprd08.prod.outlook.com (2603:10a6:20b:368::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Thu, 4 May 2023 04:38:37 +0000 Received: from AM7EUR03FT044.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:310:cafe::3c) by AS8PR04CA0009.outlook.office365.com (2603:10a6:20b:310::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26 via Frontend Transport; Thu, 4 May 2023 04:38:37 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT044.mail.protection.outlook.com (100.127.140.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26 via Frontend Transport; Thu, 4 May 2023 04:38:37 +0000 Received: ("Tessian outbound 8b05220b4215:v136"); Thu, 04 May 2023 04:38:37 +0000 Received: from c7311422318c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1A9751A1-930A-4FDB-8517-62D73A2CD018.1; Thu, 04 May 2023 04:38:31 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c7311422318c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 04 May 2023 04:38:31 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AM7PR08MB5365.eurprd08.prod.outlook.com (2603:10a6:20b:109::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.21; Thu, 4 May 2023 04:38:27 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::2db3:aa30:7be0:10a6%6]) with mapi id 15.20.6340.031; Thu, 4 May 2023 04:38:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e057a87-ea35-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9IMZTaetQU/LDyWZ0wOaYTWh5ffcjtrO06NcTJvkw4Y=; b=jdAjDFwNxYqW2SP5C4+voYD6zBYm3iU7TKOPNCJZw2uTvfI8Yoi8xvny2j+QkbBRNHL3KNsf4tCzY9ByR2soq21JBSxuxRj9azlmiictv+o8LUuUe7kWLG3BP/1xX5QlZg4XqYVZ52O0Yywz3zOAEHGup2idbsjnrr37QiTpgrc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h891+WVSYNkDSsl0p3idiC+O4Vh0a2bV8iqvG3t3xxQlrHTz8U3fXuB3klsRmMip6Cp1KrNvgdIUbQ7X2hwSpdF4VCbIf7Ql3VQoqsoaWwY33qs5YDIQd7P8jW3+IkAdlgVO6Lt8Xb58FOaMGwrQTA5YfHCNQ3XS4lhcucQi1JdWH7Cy2K5Fq+6I81Xvs8B+4+jYGV4d0emF3WnLUGngeI7aj22lUYOPirPohSu5P86Lknff7rhXcf93uyEWeT/JtmLPhDsO8jXUiLaR2GP76CQhnrjY81pLiodYK5DwjV43JF3IRwbqjypsGmOWHruv419DIbxE6mtGoYpkpecM9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9IMZTaetQU/LDyWZ0wOaYTWh5ffcjtrO06NcTJvkw4Y=; b=HvUYcRfbl+iLpyD14flz4wfc8EkAPOQ/UZhar/y5f8WXxRzUGk7BrEJfcsnSoFpbXou5aFsk9mE9KEdksEZc7YmLI7U9asGdtFSOwd4cDwojKfV8nnaQw4b7G0tfayL9T/YowrLVr0JnPsKEJ6ldafH8f5cQlePKyhJqtPl8jpj+t0Daejw9ArOH8p2xBr9WMMpghIPUuVhGR6xB8BDtjgvKhisxd7ZYYQIqY3XanIppFWdkPDXUgTIPILdqLKRZRO6QtHffzyrTznYPZvGa8pCS9YenRNNuAKkwhKb+fim3k/SuBE+HzZGxBVkA27t7vadimFx/vfvTOGFDrhLRCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9IMZTaetQU/LDyWZ0wOaYTWh5ffcjtrO06NcTJvkw4Y=; b=jdAjDFwNxYqW2SP5C4+voYD6zBYm3iU7TKOPNCJZw2uTvfI8Yoi8xvny2j+QkbBRNHL3KNsf4tCzY9ByR2soq21JBSxuxRj9azlmiictv+o8LUuUe7kWLG3BP/1xX5QlZg4XqYVZ52O0Yywz3zOAEHGup2idbsjnrr37QiTpgrc= From: Henry Wang To: Vikram Garhwal , "xen-devel@lists.xenproject.org" CC: "sstabellini@kernel.org" , "michal.orzel@amd.com" , Julien Grall Subject: RE: [XEN][PATCH v6 14/19] common/device_tree: Add rwlock for dt_host Thread-Topic: [XEN][PATCH v6 14/19] common/device_tree: Add rwlock for dt_host Thread-Index: AQHZfU8ldKybmQ5LfEKEsMjqvUt8n69Jh4jw Date: Thu, 4 May 2023 04:38:26 +0000 Message-ID: References: <20230502233650.20121-1-vikram.garhwal@amd.com> <20230502233650.20121-15-vikram.garhwal@amd.com> In-Reply-To: <20230502233650.20121-15-vikram.garhwal@amd.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: F5DEE6E9CFF93740BBB29AE2D5873925.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AM7PR08MB5365:EE_|AM7EUR03FT044:EE_|AM8PR08MB6545:EE_ X-MS-Office365-Filtering-Correlation-Id: 275a40de-3bfc-4ef7-61f0-08db4c596d61 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: zGE/iAS5D+Z5KOllX6q4lvf3yjjg5M/Rc9YEpZv1MmKLlB8PlfareyL61VznCrlgzVrEFTEsc/J4xwnkHAHVAQFI8X+rtqh0bftispKmBRV0INwkiRIZg/4S65EAx65gq4wl8x6ecXa1hIBQm2SKXbRyZxHrnK+w2JGnNF5gvg7l7OI6lq69jdFWPvpdbLLbs4IgegVCEd4uHGkiPPuZRzMBaSI1WyQGeTEud0LT0jbN6yZgaBGMG80PeFIa/smQE7pB9G7WwSi0qV1VlU/PvVwzZ3WTHLhDYYhm8WP3xgT18W7uftUOKDQ4b0ogTX1m40zkxobVELalinoMoRhqkHBrURem2vEeQ5jnLvj6I7h8KmpEmYLmNnNNydvl3r3RCzQOu0vacWdiaZWyR4jJ99gwWL2PN/R7M+2FVa0Gxd0mDJkDpxZF36u0sALlhbgZaBMm4dz0FLkamQiBWSQXVifJ5LjPdozfiVXW72eDr1mfsmMY+QijfDBR/EMNZ0czKzHecuqMKKyO3Bk00gvmWC0HVuIiJs0IQeY6Vs6cnqDsrXPR+wrXbeScwItZQVxDCqsD8HQdexGsazdg5tsNrubQspJtdCC81BNfZ7quh3P+kuE0CVzBaDzsNvU/I5tk X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(366004)(39850400004)(396003)(136003)(451199021)(122000001)(38100700002)(8936002)(2906002)(8676002)(52536014)(5660300002)(33656002)(86362001)(38070700005)(55016003)(71200400001)(7696005)(110136005)(54906003)(478600001)(26005)(6506007)(9686003)(186003)(83380400001)(41300700001)(76116006)(66476007)(66946007)(64756008)(66446008)(4326008)(66556008)(316002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5365 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 08ad4aed-3095-48e4-bd06-08db4c5966d1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Unp5QTXPpUZ9QgExU0kGsAZ7WbDUyFGyMzjR3DpYh0+i15HzzWPnVjjE6WMI7etqf47htdWjoYjlnjhY4W/pUpMEk/Ha5lLT4As1niMEfo6jYU3iAOMDWBmZ+A2ryMeJTw5GffM/DLmXhbkZllAW7AC3NsCvEeDjozdzv+KJoOBuHd1ql0hf/IiVelGvHpH1aJx+FEZ4ON5N+13Ffrk9dfQdvtJ6nZIheZYUUvCHL5c5pxQ6vdrAoL7mOSZFmDXpCh5YhwYzBxC6hMrPO482na2DjxiKJKGjQUqPhC+iCpQ3EQIqvpxzEbO8Cma4ygvveYPSG2ZfpYxs48ECUX7OSz9pi9cF9yPkNxermX1CaxSsXNYRBC8Plyntho1NK9sVyNwtkDof7N0Wm+iiJ6/BafNQaJE6Yn69ZrSh57HtwqcYjzsYoBBesa5520IF+waYfno8nB5N/Yt8dARmGNRCYZ+UC1IpWgCYajSz/DMp/zkrccJ8sB+2jx/ZXBA9MHMQNcgIOz3XTyzTp+mLvZKVdJ2956Csax15Q4c0i4bKdTu1cTEu4UfU5oevfTvzNL9bWE1uPac8mh82OKGK0kk/TTK4jpFYPbh6paUJPLQdKoG5jRet8dstv8cFMNKsLtpVWjIBlw8QODt6sBeIKzJ0qbxhn/tPJoxFv1E0XEPt/4Mn9/EtoBQ1HIuSTNCuRoDe/S5nxt9/7XbfFX79oJAbLqRHjlrNeZTEXrbUma7U2J0= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(376002)(136003)(39860400002)(451199021)(36840700001)(46966006)(40470700004)(36860700001)(40460700003)(34020700004)(40480700001)(55016003)(2906002)(478600001)(6506007)(7696005)(83380400001)(4326008)(82740400003)(316002)(47076005)(110136005)(81166007)(8676002)(5660300002)(52536014)(41300700001)(86362001)(8936002)(356005)(70206006)(336012)(70586007)(54906003)(9686003)(33656002)(186003)(82310400005)(26005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 04:38:37.3331 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 275a40de-3bfc-4ef7-61f0-08db4c596d61 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6545 Hi Vikram, > -----Original Message----- > Subject: [XEN][PATCH v6 14/19] common/device_tree: Add rwlock for dt_host >=20 > Dynamic programming ops will modify the dt_host and there might be other > function which are browsing the dt_host at the same time. To avoid the r= ace > conditions, adding rwlock for browsing the dt_host during runtime. While now I understand why you use rwlock instead of spinlock in this patch since you explained it in replying my comment in v5 (Thanks!). I would stil= l suggest that you can add that kind of explanation in the commit message to make the commit message clear to everyone that reading this patch. >=20 > Signed-off-by: Vikram Garhwal > --- > xen/common/device_tree.c | 4 ++++ > xen/drivers/passthrough/device_tree.c | 18 ++++++++++++++++++ > xen/include/xen/device_tree.h | 6 ++++++ > 3 files changed, 28 insertions(+) >=20 [...] > ret =3D iommu_add_dt_device(dev); > if ( ret < 0 ) > @@ -310,6 +321,8 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, > struct domain *d, > printk(XENLOG_G_ERR "XEN_DOMCTL_assign_dt_device: assign > \"%s\"" > " to dom%u failed (%d)\n", > dt_node_full_name(dev), d->domain_id, ret); > + > + read_unlock(&dt_host->lock); Since you added "read_unlock(&dt_host->lock);" before the final return, i.e. "return ret", I don't think you need to add "read_unlock(&dt_host->loc= k);" here before the break. Or am I missing something? > break; >=20 > case XEN_DOMCTL_deassign_device: > @@ -328,11 +341,15 @@ int iommu_do_dt_domctl(struct xen_domctl > *domctl, struct domain *d, > break; >=20 > ret =3D xsm_deassign_dtdevice(XSM_HOOK, d, dt_node_full_name(dev= )); > + Nit: Unnecessary blank line addition here. Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Thu May 04 05:02:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 05:02:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529553.824044 (Exim 4.92) (envelope-from ) id 1puR6V-0008L2-BB; Thu, 04 May 2023 05:02:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529553.824044; Thu, 04 May 2023 05:02:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puR6V-0008Kv-7i; Thu, 04 May 2023 05:02:07 +0000 Received: by outflank-mailman (input) for mailman id 529553; Thu, 04 May 2023 05:02:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puR6U-0008Kl-1h; Thu, 04 May 2023 05:02:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puR6T-0003Fz-Nj; Thu, 04 May 2023 05:02:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puR6T-0001V8-EI; Thu, 04 May 2023 05:02:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1puR6T-0004gS-8F; Thu, 04 May 2023 05:02:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=BVzlKS27eCwBG75ubFEALwQoOw/lTowyKqMriHkgyS4=; b=Ou+/8149eZs2v09fomVRIplen6 af37q9PT9EqeH/7nRiCBQ3x1Ci/asO2vphSdWl2jbzgOX1MKxNdqFagLzu0DSTJzVe+2N1pe8I2Ah kK8D77Lm3aG3Qa5uP4cE+VESvCHAIpQa8Tyag16tnFtcbRyHlzcPGPG3ax5sc/H2Cop4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180516: regressions - FAIL X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-examine:reboot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=348551ddaf311c76b01cdcbaf61b6fef06a49144 X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Thu, 04 May 2023 05:02:05 +0000 flight 180516 linux-linus real [real] flight 180523 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180516/ http://logs.test-lab.xenproject.org/osstest/logs/180523/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 180278 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 8 xen-boot fail like 180278 test-armhf-armhf-xl-arndale 8 xen-boot fail like 180278 test-armhf-armhf-xl-vhd 8 xen-boot fail like 180278 test-armhf-armhf-examine 8 reboot fail like 180278 test-armhf-armhf-libvirt-raw 8 xen-boot fail like 180278 test-armhf-armhf-xl-rtds 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180278 test-armhf-armhf-xl 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180278 test-armhf-armhf-xl-multivcpu 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail like 180278 test-armhf-armhf-xl-credit2 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 348551ddaf311c76b01cdcbaf61b6fef06a49144 baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 17 days Failing since 180281 2023-04-17 06:24:36 Z 16 days 29 attempts Testing same since 180516 2023-05-03 09:42:44 Z 0 days 1 attempts ------------------------------------------------------------ 2194 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 267091 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 04 05:56:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 05:56:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529560.824054 (Exim 4.92) (envelope-from ) id 1puRxM-0005T6-Cw; Thu, 04 May 2023 05:56:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529560.824054; Thu, 04 May 2023 05:56:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puRxM-0005Sz-A7; Thu, 04 May 2023 05:56:44 +0000 Received: by outflank-mailman (input) for mailman id 529560; Thu, 04 May 2023 05:56:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puRxL-0005Sq-CF for xen-devel@lists.xenproject.org; Thu, 04 May 2023 05:56:43 +0000 Received: from mail-vk1-xa33.google.com (mail-vk1-xa33.google.com [2607:f8b0:4864:20::a33]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7046a8fe-ea40-11ed-8611-37d641c3527e; Thu, 04 May 2023 07:56:40 +0200 (CEST) Received: by mail-vk1-xa33.google.com with SMTP id 71dfb90a1353d-44f985f250aso28151e0c.3 for ; Wed, 03 May 2023 22:56:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7046a8fe-ea40-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683179799; x=1685771799; h=cc:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=VK/HOsLMJbrMWPV7/oXJICeUdndI85E2By62v77+Wp4=; b=CVPuBUJ70jfuo+olUztYtGZHcgaT7XXOHxwsGCPcDKaXAZEina6PHhvYqVCD1+W6og m0Zo2g+9+K+W+90sghiFTQIkB7lNgChgexYKP8GaBlcct8FnvHAFOHewZtSL6JumaUDz V0Ls3s9JQNX3MYryDyAwfQipDXj5rtfvBzTiYvYU2W6H7/u2S3JHdz0hOwX8XcgsMOds N2SXNIA2Ow+kn2RLHelpzjOqXeNtd7KVFJ4FPo19hpFOkgCzUFTjNcI5p8HfYcQXqOWW n9xqXg7IVTmV0eY47YG2MojzgBTkG3QHi+E6a1iIZb2LnDUZK0w4BKAc7mOudrkjle/I z9JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683179799; x=1685771799; h=cc:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VK/HOsLMJbrMWPV7/oXJICeUdndI85E2By62v77+Wp4=; b=Qrb3VNpHF+mjqUYiIeY04FG5RZCUoRr16HQO3l8KM11Sj3nvI/KoetuGl+p1lLdeJP T01y6BFqPUVE3d9gxww5i+Kaffaw8ECwn94k4aHcdfHc1uNnRFyWXtaX2R90vQrKtkTT H+Zdb4dVIW6mfLWgGptWMBF9q4YH1lX2UHiXb53U5QQv6UibnX4tZxUeEkiI/CGTBGlF RfIrHvLuaYDHghPk3qc3ExTd8Bf5PLV8ueLVBrVh7r+zdpAeAhsZzJiks4nXe9I2LPib CXy/qd4p5YXmjH8a8SIZLEbNZmip7cDDcYdNVpE6wS2qfsLNpQJJrkdZaHqNubIOCPw8 sMaA== X-Gm-Message-State: AC+VfDxhafHjn8tDSBmnisdZIeIzElkdra3P3WiImhhDXZMxhITfEVJy rsED+AVkoHAvyLQypuebIKZnf1cXybZS4Qwwl5WQeU0J X-Google-Smtp-Source: ACHHUZ7JaNJYTFJLwDI1ONQaLdQiWw35e54cEKfjeOHNm4IQg2S/uOx5yO3WSEwWNwWYCd0wsuZsW6T2rTceCOO7B+M= X-Received: by 2002:a05:6102:40f:b0:430:76df:b03b with SMTP id d15-20020a056102040f00b0043076dfb03bmr2821153vsq.30.1683179799302; Wed, 03 May 2023 22:56:39 -0700 (PDT) MIME-Version: 1.0 References: <20230502233650.20121-1-vikram.garhwal@amd.com> <20230502233650.20121-9-vikram.garhwal@amd.com> In-Reply-To: From: Terry Yang Date: Thu, 4 May 2023 13:56:27 +0800 Message-ID: Subject: unsubscribe Cc: "xen-devel@lists.xenproject.org" Content-Type: multipart/alternative; boundary="00000000000007d79705fad7d633" --00000000000007d79705fad7d633 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Henry Wang =E4=BA=8E2023=E5=B9=B45=E6=9C=884=E6=97=A5 = =E5=91=A8=E5=9B=9B12:23=E5=86=99=E9=81=93=EF=BC=9A > Hi Vikram, > > > -----Original Message----- > > Subject: [XEN][PATCH v6 08/19] xen/device-tree: Add > > device_tree_find_node_by_path() to find nodes in device tree > > > > Add device_tree_find_node_by_path() to find a matching node with path f= or > > a > > dt_device_node. > > > > Reason behind this function: > > Each time overlay nodes are added using .dtbo, a new fdt(memcpy of > > device_tree_flattened) is created and updated with overlay nodes. > This > > updated fdt is further unflattened to a dt_host_new. Next, we need > to find > > the overlay nodes in dt_host_new, find the overlay node's parent in > dt_host > > and add the nodes as child under their parent in the dt_host. Thus > we need > > this function to search for node in different unflattened device > trees. > > > > Also, make dt_find_node_by_path() static inline. > > > > Signed-off-by: Vikram Garhwal > > --- > > xen/common/device_tree.c | 5 +++-- > > xen/include/xen/device_tree.h | 17 +++++++++++++++-- > > 2 files changed, 18 insertions(+), 4 deletions(-) > > > > [...] > > > /** > > - * dt_find_node_by_path - Find a node matching a full DT path > > + * device_tree_find_node_by_path - Generic function to find a node > > matching the > > + * full DT path for any given unflatten device tree > > + * @dt_node: The device tree to search > > I noticed that you missed Michal's comment here about renaming the > "dt_node" here to "dt" to match below function prototype... > > > * @path: The full path to match > > * > > * Returns a node pointer. > > */ > > -struct dt_device_node *dt_find_node_by_path(const char *path); > > +struct dt_device_node *device_tree_find_node_by_path(struct > > dt_device_node *dt, > > ...here. I personally agree with Michal so I think please fix the comment > to keep consistency. > > The rest of the patch looks good to me, so as long as you fixed this, you > can have my: > > Reviewed-by: Henry Wang > > Kind regards, > Henry > > > --00000000000007d79705fad7d633 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Henry Wang <Henry.= Wang@arm.com>=E4=BA=8E2023=E5=B9=B45=E6=9C=884=E6=97=A5 =E5=91=A8=E5= =9B=9B12:23=E5=86=99=E9=81=93=EF=BC=9A
Hi Vikram,

> -----Original Message-----
> Subject: [XEN][PATCH v6 08/19] xen/device-tree: Add
> device_tree_find_node_by_path() to find nodes in device tree
>
> Add device_tree_find_node_by_path() to find a matching node with path = for
> a
> dt_device_node.
>
> Reason behind this function:
>=C2=A0 =C2=A0 =C2=A0Each time overlay nodes are added using .dtbo, a ne= w fdt(memcpy of
>=C2=A0 =C2=A0 =C2=A0device_tree_flattened) is created and updated with = overlay nodes. This
>=C2=A0 =C2=A0 =C2=A0updated fdt is further unflattened to a dt_host_new= . Next, we need to find
>=C2=A0 =C2=A0 =C2=A0the overlay nodes in dt_host_new, find the overlay = node's parent in dt_host
>=C2=A0 =C2=A0 =C2=A0and add the nodes as child under their parent in th= e dt_host. Thus we need
>=C2=A0 =C2=A0 =C2=A0this function to search for node in different unfla= ttened device trees.
>
> Also, make dt_find_node_by_path() static inline.
>
> Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com>
> ---
>=C2=A0 xen/common/device_tree.c=C2=A0 =C2=A0 =C2=A0 |=C2=A0 5 +++--
>=C2=A0 xen/include/xen/device_tree.h | 17 +++++++++++++++--
>=C2=A0 2 files changed, 18 insertions(+), 4 deletions(-)
>

[...]

>=C2=A0 /**
> - * dt_find_node_by_path - Find a node matching a full DT path
> + * device_tree_find_node_by_path - Generic function to find a node > matching the
> + * full DT path for any given unflatten device tree
> + * @dt_node: The device tree to search

I noticed that you missed Michal's comment here about renaming the
"dt_node" here to "dt" to match below function prototyp= e...

>=C2=A0 =C2=A0* @path: The full path to match
>=C2=A0 =C2=A0*
>=C2=A0 =C2=A0* Returns a node pointer.
>=C2=A0 =C2=A0*/
> -struct dt_device_node *dt_find_node_by_path(const char *path);
> +struct dt_device_node *device_tree_find_node_by_path(struct
> dt_device_node *dt,

...here. I personally agree with Michal so I think please fix the comment to keep consistency.

The rest of the patch looks good to me, so as long as you fixed this, you can have my:

Reviewed-by: Henry Wang <Henry.Wang@arm.com>

Kind regards,
Henry


--00000000000007d79705fad7d633-- From xen-devel-bounces@lists.xenproject.org Thu May 04 06:39:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 06:39:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529567.824064 (Exim 4.92) (envelope-from ) id 1puSc6-0001cP-N1; Thu, 04 May 2023 06:38:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529567.824064; Thu, 04 May 2023 06:38:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puSc6-0001cI-KK; Thu, 04 May 2023 06:38:50 +0000 Received: by outflank-mailman (input) for mailman id 529567; Thu, 04 May 2023 06:38:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puSc5-0001cC-3G for xen-devel@lists.xenproject.org; Thu, 04 May 2023 06:38:49 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20629.outbound.protection.outlook.com [2a01:111:f400:7d00::629]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 520ac285-ea46-11ed-b226-6b7b168915f2; Thu, 04 May 2023 08:38:46 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8928.eurprd04.prod.outlook.com (2603:10a6:102:20f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Thu, 4 May 2023 06:38:43 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6363.022; Thu, 4 May 2023 06:38:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 520ac285-ea46-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hK0z8MRh+oZMYIiPBu8adL2pdYoVh3ULBXAIMzQpRxPTUtBetPt3YCf+KhitQUsSUUG8NAx6Rl2Pg3u0TyZw+/fNrZIdIWBHg7csD7U1aBfJVPUuHQ6xOpmyoOogYG4uyZgsajTF3Vax0P/SaXeLtcA+h2L2M0V0e5cgQ3Lv0Rpx5iytXXG3IDafn20GvW0zZlO2LSpv91cLS3xkI7K+NCLLAK2GiRGU7CPFRztXWZpH/bWNLCni45R4TPTiP4DjcEesKIOqP1vNIW08hcM4ywyudRkcqvgqTK7LavWCawj44RPgDZ/V7EzP4AeIWA3rv7Ntmh1Eu3j49LnHoq7H7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AYJ7iD/4wH8NobWx0XxiU2uD48mzWp79ptgMKoq265g=; b=XwNrnRBg6QPDKtE5WT330MYZnOOdvOpF+wGf8sqzxvz/c4KfQPArnBKuXLoEOjXNAYRi4lc4yH8/cQQAMhsxRuiCRFncAessvTmn1SnmCcNuk/og0AgDBYAuUHO90rjXlHy8PPV0lZ2Ri6aJKQ73eXGTOhEeJs+MDCFXILV9PMXG28QXb8kUOzYXmcrjzyr03jDzU6wWK7uj208DCngsfXp8EXnuqAkwLppJhQFVSy80QT9zvaZl/kYGQMWN9GH5AOcKQ6jX0IAgYow4qslzMzpJ6zzs7IBG6b561zLT6LA95VWyK/eIrOq5/19FKH47bta1rQueTi5yxFDH7Qz6EA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AYJ7iD/4wH8NobWx0XxiU2uD48mzWp79ptgMKoq265g=; b=Hlw0qb4ffkVr4piAdCBwwmv3669rCCLyRdwgNIunwu9u/L7AR9rmnqVAmhXMnmZa8DIAvj4iu0a/wcZMUXS7qzVhl1SMwq7Vm5T3KFo4O22XJgQS4afDC0J3DSkGNRYJYJ7ZUz4sSS21TV+FA7Vn/D+CFdw0khsGEu5UUWRE6sGeF6F0dHsrqIDuF+VuhdmtqnTt/JHnko7zuRJllNA+VJtSj1RqIFrmkzpDuEoArDfsvvSFud3lPYkqfIaDQuSMTnj0j9f/Fbz4HgtLzIqBgKrUizK+OOyfVqf/K6S6EOBVgsOfnLrdEEK/Z8KRpzdfJPWlHKqU1ccqQHxnveVIsQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 4 May 2023 08:38:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v2 1/2] restrict concept of pIRQ to x86 Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Volodymyr Babchuk References: <85e59fd5-9a06-48b4-ba7e-81865d44e332@suse.com> <98f51b96-8a1c-7f33-b4d3-1744174df465@suse.com> In-Reply-To: <98f51b96-8a1c-7f33-b4d3-1744174df465@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0260.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b5::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8928:EE_ X-MS-Office365-Filtering-Correlation-Id: 980f9379-1d07-41b8-67c7-08db4c6a345e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IL9uO7e8dswtLUicdJoU/V97XEPZjycUpuaN6iG72V+rVMSycgfkGUs7axfRGo2HdsyVfaKbF/ZCbYsbphGPxyC2EGTx9pNUBz+RXEY8il8ESMAPNmfAmXXcoZng2K6FWAhdHDPV7Mtt7uH8uMr1ZFUff2/Ni4Xw8DI60fokymZ3ujFGP/hqOzwAm6V3t7XdsY4mf9Gy9E2EuMnKaafBqHZHbsMJNJz8WQZaBY19iWhKaqWxUAB3xkdQEMz1Iv9ch/KokQqJn+MzfATTxbjm+8uyJciJGCJ4gVTq4e6wodBabHsF6RtDpcdx2E/SDpfcsM6lXd+NNcd3sdHuTgYoslQCgNptK/RN4yW34NY76L9F60IL8Sehwos90nWYvSYYaWNLSdNH8dyt855nh2IZ1mAJAK7a07xMqtkZXiHpvD4rrhR4riajgy+FiVicHU0THJMS2l3JQlgzQrXeZvp26ePB1NP4kMjS2yniGhxluXRJIg/A8tj1m95O4KoqOorWfODdTjzlPwE2xOQy1ZW4CzeY2hhjQJB9ZlJZuYOtCqIE9Iu/DYKgG6YEKW269Wl8mNP4ryWAnoC1Q0fkk3EkNJSkukUuW+PNKJBbCPy8XQ0gKv1f7LM/A/e8XshUacwAIMxwgONt/0K3j7lj5NTQ9Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(39860400002)(396003)(136003)(366004)(346002)(451199021)(38100700002)(478600001)(5660300002)(8936002)(8676002)(2616005)(54906003)(6506007)(2906002)(31696002)(86362001)(66556008)(66946007)(66476007)(6916009)(6486002)(26005)(83380400001)(4326008)(316002)(186003)(53546011)(6512007)(41300700001)(31686004)(4744005)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?KzRtdHZwZ2tTZmdSckdoVHVoaitob3QxaVJmR0NlS0JXUm9PYlhtOVhYTEto?= =?utf-8?B?bzN4ck45eDlReXZMaUU3OXZWcytVa0JHTEl1UFo2NGU2RzlRVWh4eDhKNnU2?= =?utf-8?B?RktRSzZ6Tk9FZVpQL3pJZnFkTlpkOGptUkl2TzRVOWx1cHIxbmRLNElkVUlZ?= =?utf-8?B?bklVTGZNLy9IbDR0TE5wcEx4SXNRS0swQWJMeDFHeHBRYWdacGF5NVNkOFIv?= =?utf-8?B?VHZTY2xpM0R4Tyt5N29zY0ZtcDBRcG5GK044ZW9SajdUamI3bCtXZFdXUzQ0?= =?utf-8?B?VDAvazNmZHVKMHlNV3lJL0RIeVZ1UTBVaTYzaUI1SjVmY2JrQ0dESndLUTBO?= =?utf-8?B?czdCbHp2OTYrb1BaYkN1S1lSSEppR21UTk5HcHJBUUtCSlBPTzhVeFZ3VUNB?= =?utf-8?B?K3Fna2ZxRktjVkhVZHhoWVVkVFJ0RmhhNDhNSmZnMUtzTE5hRFRDRXoxcXZo?= =?utf-8?B?aFQ0aGxsWjVwek9uRVk1WTd5TWNsNG0rSllzcVBRKzBUckgrei9BaWJ3V05F?= =?utf-8?B?OWk3bG1kYjYzL09YZTdJMUpMNGl0VEZoM0VObHFaeW9MMXQvcUlCeWJxUnVa?= =?utf-8?B?WGVuVTFHenBoSkt5Yms1MGR6VXUxVExvb0s5UGg3TUpiK1l1eEI1VkRRUlJZ?= =?utf-8?B?aTY0cm9PZ2xsYXhIcUpGZTh2TWRSYTlxUHQzc1FDZEZXczBDZWFpSStHams4?= =?utf-8?B?aE9KZ2htWE14L1lsREVFY2dKYlp5bWhMeVRqazVNa2hSTDZqRnBoQkgwV1dq?= =?utf-8?B?bEx4TDIvTkZoZEVReWpQSHNTK1hLTHBva2RDbTFhVlU1QVFtRWNQVExUbmI4?= =?utf-8?B?dldFTDNSVER2T0pYWnlFOUVkRFFmbDY4RGFvTXZZaXAxT21DUTBjcHcxQUVm?= =?utf-8?B?SEVHNEtuT24zODNFN1RsWFRGeGNpMEtZR2tiS2d5NkliUmxvYmZJclpDc2xw?= =?utf-8?B?a1Z0VFdUeWF2TWFEdVViYXQvQnZjRGQwZHAyQ0tOVXFWeEZRTXhMVS9TUU4x?= =?utf-8?B?NUxWSUp3YW94NktyQzliL0tPUm9pMW4vWUVpZ082bjk5L0xDZmZEK2JVMGVZ?= =?utf-8?B?KzE2UU84aGRKTmxYQS9JdXpMT0hvSysrZURIOTNkQWtrZklyYzI3Q1pWUFlF?= =?utf-8?B?NXlxNzhGSmVpUzhuS0RveDNpNDA5amRaNzNjd1dxbCtacWlSOVlDS2ZDY2hL?= =?utf-8?B?ZzA2RXJPcUhSZ250WGloV2JMeW9ERWJWbUhianZBeUxxMW5JV05xdHF2OVFn?= =?utf-8?B?alBQTXJZUmVibXNPcU1YNEJtaXRIL0J2WWRrMmpsbGt2d3F4T1hBR3VwNUhh?= =?utf-8?B?cHpSSGNSazBPVXcwZmwwZ0lROEtqVGxhSmRyemtTL0NmRVYvcVZUUVlxZVNY?= =?utf-8?B?MFhVOU8xWkFVSjRuS1A4NXl5WDZyUzE4ZS9NbU9RUkoyNGFlNFp1M0pOVWFX?= =?utf-8?B?Z1dIMVhrUXpTaFBjY1BMU2ZmaVlMeXVpSmFUdEoxVTNuMWpmcWN5eHBzY0M4?= =?utf-8?B?YnM4ajdkVDV1NkhHN0c3YXZvRTBocm1mVzB4Z3NiNU9YeGtuRW56OEhHUGR6?= =?utf-8?B?WnRnRVByaXhnTWFEY0NoNGpqZjFlTHcxeGwrSWN4d0pCaU8vc2toLzBTVGJw?= =?utf-8?B?ek84U0FhUmVtdlBTb0ZIdEVmZy82RU5zSXNnNjRFb0NqQStpZ0xSTlpYTkFU?= =?utf-8?B?Y2Y5SFJxWHZQQ2J5WnpNa1lTSjAvZDNWUndBaE1CbC90dlJYMVoyaWVSNHNz?= =?utf-8?B?UlQ5clNhWFZKa3BrYzlKM2QyMUpwY1F4S0NxSG5uZmZ3cnhZM2VEYlFEL2tz?= =?utf-8?B?T1padUo4eHVDMzQ2WndIcGllb216ODZpK0l2cXhsTmsyUkgvU3NBZzVHUEpT?= =?utf-8?B?NDZsUldISmJLZzBmb09wRDNTWVBFdyt3Q1haKzJJSERIWm9mU1RPNnFPakQ0?= =?utf-8?B?TTZYdDBBNEhkS3lkMmZHdHFQTEFuK3Uxb2w0SWdXTXdBdWJiWHBDbXFEOU8w?= =?utf-8?B?OU9oaWtueEE2SmliQjRUckhEeFFiTURMbmg5dkp0WnRpcXlIYjRha2F0djdZ?= =?utf-8?B?bFE5VllaZ0VhYTR1YlR1aXE4a0dLVmh6a0Fmd2kyK0ZYeVUrL3dTME5JUDA5?= =?utf-8?Q?N3W6r7YywDF9xBMRa1Kk77+u5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 980f9379-1d07-41b8-67c7-08db4c6a345e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 06:38:43.4016 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g14kofs0TsLfZgnwJy1mrdJ9mPpaT7GtZd+qPO0JAItYmY7QLkuHl6DpyW4gazK4dlSVABAG37lzCtaJW7VawQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8928 On 03.05.2023 17:33, Jan Beulich wrote: > --- a/xen/common/domctl.c > +++ b/xen/common/domctl.c > @@ -683,11 +683,13 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xe > unsigned int pirq = op->u.irq_permission.pirq, irq; > int allow = op->u.irq_permission.allow_access; > > +#ifdef CONFIG_HAS_PIRQ > if ( pirq >= current->domain->nr_pirqs ) > { > ret = -EINVAL; > break; > } > +#endif > irq = pirq_access_permitted(current->domain, pirq); > if ( !irq || xsm_irq_permission(XSM_HOOK, d, irq, allow) ) > ret = -EPERM; It has occurred to me that in place of adding #ifdef here, we could simply drop that if(), resulting in out-of-range value to also hit the -EPERM path. Would that (a) be acceptable and (b) maybe be preferred for being less code and (more importantly) less #ifdef-ary? Jan From xen-devel-bounces@lists.xenproject.org Thu May 04 07:08:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 07:08:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529570.824074 (Exim 4.92) (envelope-from ) id 1puT4V-0005BD-VN; Thu, 04 May 2023 07:08:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529570.824074; Thu, 04 May 2023 07:08:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puT4V-0005B6-SV; Thu, 04 May 2023 07:08:11 +0000 Received: by outflank-mailman (input) for mailman id 529570; Thu, 04 May 2023 07:08:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puT4V-0005B0-8C for xen-devel@lists.xenproject.org; Thu, 04 May 2023 07:08:11 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2060a.outbound.protection.outlook.com [2a01:111:f400:7d00::60a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6bc27803-ea4a-11ed-8611-37d641c3527e; Thu, 04 May 2023 09:08:07 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by GVXPR04MB9994.eurprd04.prod.outlook.com (2603:10a6:150:11a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.21; Thu, 4 May 2023 07:08:03 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6363.022; Thu, 4 May 2023 07:08:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6bc27803-ea4a-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SJK8lApNMuCDa6EhPpym/yWjsLTlG0QQxtoUFI8cYht1bOXkHwW7dhvGMlwcNg1uKmCJ9WZsSJlqcj/fXU3NNIc+rK4dNn2OCAQ6SKn3OHAujEbQwntMc3lsDY2+0HSQp7Fhqyh+M2IfyGmC552qx7idEL8sor5IaHxX3ihbG7Al5f7sEQovpjBlCOYARHZZLclK7iRWDxb/nn6d4yVd6edvLsDoIsO+qkDuBzTcKQkH9NedTj7dmW37mDkt8KcPayhtc2uWn40db1qp9pua2HXtphd3QZ69wM09sA7RZb79VHP+vmvQhXw1pBIJ9NdiIeKMHDgJWVPJPdtxj3oKlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EMCovZM5a+5Fe3ZHk/ZrcwEFDoMx44Y0U1aq3mDeCHg=; b=X8sKn/gVa9kMTKvq1sS3RKaynzLi5t7cYOB9lwc6hoQs7Bj1IxxPSj3Q5SjhzCEu3IwECN0mAaX84s91pnxD0k4hjITOwYMDCHfHZCjs5fQyVJaHeABfu4SHJlRi4wLnUpCEUOoyWecepMQCzeXDYmYznikVhw6ollNuhHVqdyUwPufBAYRvmiAFvL5rHinOglAHh4RN7aASnUSeBVySsSX+8HTdkIj6OPMiu+MSxkJqPgP75k9GoDO+O4978NTL2D6txcHRUNjVTH5VX2GZSYkmYqmH0+c8bOO9pN1o/rz29kvJcmasDR73m5iKVQTU9h8/Y0GgGJ6AcLDlAuBikw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EMCovZM5a+5Fe3ZHk/ZrcwEFDoMx44Y0U1aq3mDeCHg=; b=fDmkOD5ZiOGtBToTpAlobXmUMzeRxy/N4QMwpCmxe6oHds6zV0U/GOaHP5kqvYOyYOsBR+ILp0wx0Tvg0OLTYvNjrCx+yAMVqLy/txZdgcGKxDX839HTSmQAghZ1wreKvXeJyVcFQBnwzszOS+EcW+T/XFeSTwFu9L59Wmm+nmKalFW02arWhsd8q6/NtK7g6JVC2+fZLl9VTzrkdUDrA8B5EB9CKI+dh1CQX9qb07J1HYygwAUls73GvEjIU8WYwHW3sUNvlMtgGu3Ibw5aLp69CCH5BhGV0TLGkiC2YSa7D39TSNaDAqGzEQuj2DiZbIUjZbueoAsaw+LP8oxG9w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 4 May 2023 09:08:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH] x86/ucode: Refresh raw CPU policy after microcode load Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230503185813.3050382-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230503185813.3050382-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FRYP281CA0010.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|GVXPR04MB9994:EE_ X-MS-Office365-Filtering-Correlation-Id: e7d4a750-fbb7-4a1a-373a-08db4c6e4d4c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6N0pE+SRulAfFCgkWYLUMMXDq+lWyGuGEY0+2Oyuub8xKRtb6zYiLwFw9ArItYgr92mXf8iNA3hPd6mfvyYC6XictQ7YOTKcnjSR5ASKmNm0kH+TeT9XHipGM97NSxVXxYZKOULQKclmPUwMBvbWYa0NtEWCX9I0qQcU5+NgRX6M9j9JsIBPs0yh4F6CYisqbT9gJ+v4YQRs3J8l1fXEUOZXGpEn5hnyFiL900LEZMdbh5/u4xb+5XIe91+Rdqiyy31iAPAIGjVcxF18C+AtwYuy/SnHWD9xVDkYWYkkR4kFKlCNTQMHcAdWj3dcvwr1GBXO1+5VoBPX65Icu8n5kD3EyIXYPRexdoaUYtgFU2jtsR9krptHdBzXi7dmfgF78LGUAxOnh3zpZLf84/6b+39MDDJIt1ssIG9gnkARB/KYVRe+cR6gmjy5Xqug3J7tG6Is/XnM4lLdjr4C1Jlw+RdW0MVjajoTBew+xP9ZBdzT0P7RJtpXSc+5bilUeWLo6hiUOjErOqnFMwJQb8/WdKMgwNFoRMfjwsi3LDt4X54v/CD7Puncel0LQvEJfOIJQH1pENh6PHJ8kmMEC39f7pJdCSkvEkRq52Yy7HYSe6ClYLEDEt/a/s+dSYYemzsnG2ceHyi7+ieO9QGVXhY5qg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(396003)(366004)(376002)(136003)(39860400002)(451199021)(31686004)(5660300002)(8936002)(66899021)(2906002)(8676002)(41300700001)(316002)(6916009)(4326008)(66476007)(66556008)(66946007)(38100700002)(83380400001)(186003)(6486002)(478600001)(2616005)(54906003)(31696002)(6512007)(36756003)(6506007)(53546011)(86362001)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SUxHaTFoaW04TExJUW91RklBTG9mQitoclErNVd3d3VJT09hV0h5c3NzeEd0?= =?utf-8?B?K1UydkFxOXVBM0NDaGZnZVZhb1Q4dzFldlJ0amlFeFlUR2IrUWhBNXUxRlNL?= =?utf-8?B?dkRYU0tXVGhuYTlGTVhNSVpRQmM3a3ZoNm43VlQySXROYURsVjBTbzJyRU0w?= =?utf-8?B?UHR4aWZVQUtYaXp2Z0hFOElsSnNacWYwbzV0UUhDTEtSMTlTZ3BReC8xN3VV?= =?utf-8?B?eWZNKzVObkJpNi9zRXZaQ1BBejljTGpoK3JlbC9LV2FnWGlIL1c1ay9Ieis5?= =?utf-8?B?NHFOTkt5Q2lJVEc4ZG0yWTBGSitLdjMyQ1NTZmdsM01kK3c3MG43eEJnN1lK?= =?utf-8?B?KzF6QUJlYVJyc3RvRXV2elNoVFRWNm9WV1BveElIUU94TVM1akx4bEZXRDZK?= =?utf-8?B?NmVITnN6ZE0yMnMyS1pSLzJ6bHZxT0ZFa0dWa0N2Mno3eEdGazFRVVRSWjRk?= =?utf-8?B?QUFxd3dPbitBMjh0NGJpTktjMUc3VnBTbytYL0RwcXN2bURDUlZ4NWZLVFVN?= =?utf-8?B?Z3RSSjlEOFFlR3NXeWZpWFdHeHdJbkVPbjRiK3hlT2kvdzBuaDFBNHduTlNG?= =?utf-8?B?eHhDcm1MVmptWFdVOXk3VFRzd0xBMlpuYlYxU3BCNFk1OE1nMEMyRXFtaEFM?= =?utf-8?B?eUN1R0QwZHBzSEZUR29VU1FqVVNPeGY4WVRtdXFYd0lqdHlZUzVjZjdhdURv?= =?utf-8?B?RDludm1xTVQ2YndiUFpzblMwME9XYm9kWkdETjQwRk9wb2JJQmllY0JMa1Ny?= =?utf-8?B?Q2piNDhMNTFhZXU5REQ5LzF4cGxHa20vN1c4MnNtTGU5KzQ2eDI4Ykx2SEtO?= =?utf-8?B?a21pdFJGRVBGMEJhRkdNakJCQ3BnYlJwQlY4QWRIenVoc1BPZGVNWXVHTVdW?= =?utf-8?B?dk9uRnp4QzFEZnd4TFNjbElGYkhEczJ5OFRVKzI5VEF4RTVpQ2xleHRzMTZ2?= =?utf-8?B?SzFLMG9UTVpJeWNGekZldkFuK0ZSLzRPVDdWSGI0ZjkrWmh6NnNCd2ljOEJJ?= =?utf-8?B?ZDNjL2xRcnRTc1dGcHlaWkk0SHNBb3R4VE91VktkSFArd3FWNGczemZRbUY1?= =?utf-8?B?R3JZM1VsNS9FcnRqVXhBTVBEckVLS1VjcjRtazU4ZzBhRXNPc3F4cERmNWZr?= =?utf-8?B?MzdjVXpLVnA1cjZVZkJ6T2hKMCthYUs3Nk10Q2lPMlhaVmwvM0hUZ05yV0Nu?= =?utf-8?B?enpLMjhNSGpUMW9KVnZ5MnNpaTlBVElXaFJKSFhURWZrSEZ3UzNXNkFETzJh?= =?utf-8?B?ay9CQXlXVlJLdStCQVcyVmU0SmFvVWZVdEdiZUZwdGRaWUpmOUtadmU4UFZD?= =?utf-8?B?d01PbVZITnJaRG5SSE5GbEFicUxnSStBcmlLVG5uM3Z1bFAvb2xSd2pjcVlP?= =?utf-8?B?a2V1cm9xMWY3dUtKZTdIQkpSL1pzOTVPekc2ZkNTcE5tV256SzBZcDUyZ2pW?= =?utf-8?B?YSswTEJHOFlTeGs4M2JEU2RnR09NMi95M0ZBa3ZKTytzL2JlZ01VNzZlaDkr?= =?utf-8?B?ZmZwSkhTZDc5R1JPVVpRckhicGVEMC9nZmh5KzZNSHVVQXpqVE9UeU4rL0c0?= =?utf-8?B?djR2QnJSSkZtYmRGaUhsVVZIeXE5Q3pSQ2ltTTl1cm83Tm5nZE1oSlB3NVlW?= =?utf-8?B?TG1HY2V6cVBjWFJuYTRwOTFHcnpzOTlvRGpxTXdybXVNUExGODlSVzUvYytn?= =?utf-8?B?OFY0cmxscTFqOEZVcmNIclJWbTVXWHZ6ejhkVFM1S0VTSGFyUnpHL1l3NU9E?= =?utf-8?B?SUhBbzc1RUFNdkRBSGdBbjMvSk5nQmlFTkJOSjFaR2JTZk1kZ1l2Yy9TTHV5?= =?utf-8?B?MVR6SXh1V3cxeGtTeHk2MTI5V1BZRWlRcDNTKzQySGpiOHRqd051L1hQQWl3?= =?utf-8?B?eEMwNWxUdHVzdkFuMjh5cmFMWXVlTHhGMkRiUmlTM3I1YzU0YU9TYnJadXkv?= =?utf-8?B?clBtRnF1MU84MXM2VktMUE8wRDVBdVh5ZUpWL09kQzhvM1VtTUFBYnk0QVU3?= =?utf-8?B?V09ZSUs1OEVLWHpTQVQrZ0VmK243cHVWc2FOQlJHTFY2eGFzMmlMbmtVRE9Y?= =?utf-8?B?T1hTbEhxYkgwU1djSkp5aHoyTGRyQnhUc3Awa1Z2TEVGWm5OMEtYbDdxOFgr?= =?utf-8?Q?s8H7F8fy/2rWuA3cyk6C3A23E?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e7d4a750-fbb7-4a1a-373a-08db4c6e4d4c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 07:08:03.1123 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ySQCA00UbaDE7s6AJDCte1d8MrqmQNEM43NOgGKZ0r0EALxUi6dQOI33tCYD8xXJAyBI8esf0FRKATn0gVh/gg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9994 On 03.05.2023 20:58, Andrew Cooper wrote: > Loading microcode can cause new features to appear. Or disappear (LWP)? While I don't think we want to panic() in this case (we do on the S3 resume path when recheck_cpu_features() fails on the BSP), it would seem to me that we want to go a step further than you do and at least warn when a feature went amiss. Or is that too much of a scope-creeping request right here? > @@ -677,6 +678,9 @@ static long cf_check microcode_update_helper(void *data) > spin_lock(µcode_mutex); > microcode_update_cache(patch); > spin_unlock(µcode_mutex); > + > + /* Refresh the raw CPU policy, in case the features have changed. */ > + calculate_raw_cpu_policy(); I understand this is in line with what we do during boot, but there and here I wonder whether this wouldn't better deal with possible asymmetries (e.g. in case ucode loading failed on one of the CPUs), along the lines of what we do near the end of identify_cpu() for APs. (Unlike the question higher up, this is definitely only a remark here, not something I'd consider dealing with right in this change.) Jan From xen-devel-bounces@lists.xenproject.org Thu May 04 07:27:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 07:27:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529575.824084 (Exim 4.92) (envelope-from ) id 1puTN1-0007jt-JU; Thu, 04 May 2023 07:27:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529575.824084; Thu, 04 May 2023 07:27:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puTN1-0007jm-Gk; Thu, 04 May 2023 07:27:19 +0000 Received: by outflank-mailman (input) for mailman id 529575; Thu, 04 May 2023 07:27:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puTN0-0007jg-8p for xen-devel@lists.xenproject.org; Thu, 04 May 2023 07:27:18 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2061a.outbound.protection.outlook.com [2a01:111:f400:7e8a::61a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 171caca3-ea4d-11ed-8611-37d641c3527e; Thu, 04 May 2023 09:27:14 +0200 (CEST) Received: from DM6PR13CA0003.namprd13.prod.outlook.com (2603:10b6:5:bc::16) by CY5PR12MB6405.namprd12.prod.outlook.com (2603:10b6:930:3e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Thu, 4 May 2023 07:27:11 +0000 Received: from DM6NAM11FT064.eop-nam11.prod.protection.outlook.com (2603:10b6:5:bc:cafe::94) by DM6PR13CA0003.outlook.office365.com (2603:10b6:5:bc::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.9 via Frontend Transport; Thu, 4 May 2023 07:27:11 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT064.mail.protection.outlook.com (10.13.172.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.26 via Frontend Transport; Thu, 4 May 2023 07:27:11 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 4 May 2023 02:27:10 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 4 May 2023 02:27:10 -0500 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 4 May 2023 02:27:08 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 171caca3-ea4d-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NwPyUoFiPLy79x+V3gAUVNnuJ2u0KI35vP94nwvM/SaJBXAWZb9c37jU2Pokch9tRiD2GdxUhp3RO5CnVKKIXPmr4E28b8NSwFfcfdhxmzKZ2AMdxhgcqmmxCDeNX8nBOzQ6MCwIDaaeCQHGz4Rv8EysxCPlJTKzjJ1ynsEP7lrzIGgS/C5NYCazPZaVsqLbAYjO6xABrIv1KW59+7ySHjp6X3+a0S5wMGuOfZbA7hRmtT1aGfdgIfaDL6Y3sWX2urooLvF/oTwnwui4Cx1JL2nC4/i3Onr1MXzJXxXuapngnBMu+4CMb4+tMnOKDlZHEGiWpISsZdN/+fzL22Ql2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=piNITOBU4G5juGieXw/xT3ryw6m2OzxAGcoOcWNc/iw=; b=HHaj8lxxAIK2tFW68v0PHujjDhshCHYqhRkprRY7urzOJmeZvuCEpGuqNvfAJ9c62zilsYGl1s3nbN32KRxa6DEUskgNa7sr/1bXrJWiqCuu/0lm5pa8wKvlTS7wSUwEYCRxWd4beSbyYoyCVKU6y/NFBeB/0zYy+J/MGnip9Dqw6vLsj3GC3BKZWgb678GXRi9Rb+w5+0aqbZFsxiaOC/3G66t7ej+fhe055CmQlGKzWAL9wwyHINEkiHuUCu/PXJ4EMM+aNofs87pn3zN8/fl9y3EzGkDekeNhsG90/jp+KOwf7avDZd6ac1v4RNnzLZ46CzgpXn+SYQGa0UMJ0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=piNITOBU4G5juGieXw/xT3ryw6m2OzxAGcoOcWNc/iw=; b=OBZhlXOw8V74WbQ6zZcl/o9w1qQXUpmx1bPGfzrlLL8Jsl6pdGqFlhY8xTYAJP7DWc59DjQtKceV5gfVRxMmoBjvQTFOovO6wqMevWmkyGRwh3p288wyUpQ2L6sTUNB4zLf6RQDurBcUF66jQzxt4wZmsaQ2nz4UIWH7ebmI0+c= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: Date: Thu, 4 May 2023 09:27:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [XEN v6 02/12] xen/arm: Typecast the DT values into paddr_t Content-Language: en-US To: Ayan Kumar Halder , CC: , , , , , , , , , References: <20230428175543.11902-1-ayan.kumar.halder@amd.com> <20230428175543.11902-3-ayan.kumar.halder@amd.com> From: Michal Orzel In-Reply-To: <20230428175543.11902-3-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT064:EE_|CY5PR12MB6405:EE_ X-MS-Office365-Filtering-Correlation-Id: f634efe8-35b0-43aa-009e-08db4c70f9c5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uk5LriQ8imUIgWFcpf5KoiCMPj0Rf0so0oPeAFhQJL7tpUr34CnJmUYAqxMJY5S6erwe0Xl/2AkWamXG68SrABUSx0Ynw7oyi26edk5K/dNFuV/XoppVqMrhZBTRUZLxQnlo0P3Ypw8C83rTSzw+UF9CBhSXJH0JU1tThWqjjKW6g/Q0lCrXGNkwiZyM3ejfQRcLZMDz0owHvyl9DNITtKYQ+2/L0lF1IA3AgoNQZHIcBbcGZ7zuvZRui/tqbYOzD3bb8DccM8AQaGvmc2XsFuB2UMq+qt3tVUTbiZoOxscHtPequQ0wd0GHUN2hczrWUl73Q4Yn2R+WaaNR9MX8YZC5JmF/7S6gShWEfdXyOeQ7RsSGv58RFqvmCTS8kyNxisLt2QvOTyPuPDk1mgT/G+gykePIci1LSSBNuFFmh9vyxr9w4C9rCgZmW5AvY7uiV+0VIADDgeSI2cv/J9GB3C3xei3sOTzag0GrtmkJGf4f+BoqP2OYE4LpSimT06NpegZht33zdFxldxhkMSzzDbjX+zzcFXoyok+q176mmLlEGwEUkpzEMkW2BoaTKW4LjzZwIjq9v5mOVFnYyQB/4dtIvazYB8GsTXBFWt0REqfOKN6UsUKFUaOQoAU5k59p0zudwSZ73SX9/hgVjDKXQS2kV7iXpn6MzpJyHqv+i9CCM7FCNqRTw8kUJm8G+aWxQkmgPwpzQGNsTrJqHZX2otyq6KfmHhaLEYvARApU/++SpDVQclY+Lx9LsNfqRtBDF4/eck5OsTywoSggLVFcjA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(376002)(136003)(346002)(396003)(451199021)(40470700004)(36840700001)(46966006)(70586007)(70206006)(82740400003)(356005)(316002)(4326008)(40460700003)(16576012)(478600001)(82310400005)(31696002)(110136005)(54906003)(36756003)(86362001)(186003)(40480700001)(53546011)(26005)(36860700001)(2616005)(5660300002)(44832011)(31686004)(7416002)(83380400001)(426003)(8676002)(8936002)(336012)(41300700001)(81166007)(47076005)(2906002)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 07:27:11.2761 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f634efe8-35b0-43aa-009e-08db4c70f9c5 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT064.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6405 On 28/04/2023 19:55, Ayan Kumar Halder wrote: > > > The DT functions (dt_read_number(), device_tree_get_reg(), fdt_get_mem_rsv()) > currently accept or return 64-bit values. > > In future when we support 32-bit physical address, these DT functions are > expected to accept/return 32-bit or 64-bit values (depending on the width of > physical address). Also, we wish to detect if any truncation has occurred > (i.e. while parsing 32-bit physical addresses from 64-bit values read from DT). > > device_tree_get_reg() should now be able to return paddr_t. This is invoked by > various callers to get DT address and size. > > For fdt_get_mem_rsv(), we have introduced a wrapper named > fdt_get_mem_rsv_paddr() which will invoke fdt_get_mem_rsv() and translate > uint64_t to paddr_t. The reason being we cannot modify fdt_get_mem_rsv() as it > has been imported from external source. > > For dt_read_number(), we have also introduced a wrapper named dt_read_paddr() > dt_read_paddr() to read physical addresses. We chose not to modify the original > function as it is used in places where it needs to specifically read 64-bit > values from dt (For e.g. dt_property_read_u64()). > > Xen prints warning when it detects truncation in cases where it is not able to > return error. > > Also, replaced u32/u64 with uint32_t/uint64_t in the functions touched > by the code changes. > > Signed-off-by: Ayan Kumar Halder Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Thu May 04 07:29:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 07:29:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529578.824094 (Exim 4.92) (envelope-from ) id 1puTOX-0008Hh-UP; Thu, 04 May 2023 07:28:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529578.824094; Thu, 04 May 2023 07:28:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puTOX-0008Ha-Rb; Thu, 04 May 2023 07:28:53 +0000 Received: by outflank-mailman (input) for mailman id 529578; Thu, 04 May 2023 07:28:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puTOW-0008HO-5M for xen-devel@lists.xenproject.org; Thu, 04 May 2023 07:28:52 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 502288e7-ea4d-11ed-8611-37d641c3527e; Thu, 04 May 2023 09:28:49 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4D94E2093F; Thu, 4 May 2023 07:28:49 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 26172133F7; Thu, 4 May 2023 07:28:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ljjEB7FeU2TREAAAMHmgww (envelope-from ); Thu, 04 May 2023 07:28:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 502288e7-ea4d-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683185329; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ay238mjQf1ceO3a0O/KbE61dVumd3XZZUy4XAGxOU7M=; b=WpRLtgl4xAFAqsK4cZW08WEZwX9+BFJ1rQaX4L28EDWJmsbGJJyNoPX46XCcNd7Ug7lqPr TXSLcYMkOHf7h9l5yOIGEdtI/bV9YCnZ2ei3b3unvvuyIf1KfA8Nsptf7iF3PcDuM8yaW+ OoXCVklH1bO5qFeUjyLS5/2oClW4fBs= Message-ID: Date: Thu, 4 May 2023 09:28:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v4 12/13] tools/xenstore: use generic accounting for remaining quotas Content-Language: en-US From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230405070349.25293-1-jgross@suse.com> <20230405070349.25293-13-jgross@suse.com> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------omy7s3TeOwCTo65ysfZS0svu" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------omy7s3TeOwCTo65ysfZS0svu Content-Type: multipart/mixed; boundary="------------krxl8VYciXw4aVNwHwjYgAy3"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: Subject: Re: [PATCH v4 12/13] tools/xenstore: use generic accounting for remaining quotas References: <20230405070349.25293-1-jgross@suse.com> <20230405070349.25293-13-jgross@suse.com> In-Reply-To: --------------krxl8VYciXw4aVNwHwjYgAy3 Content-Type: multipart/mixed; boundary="------------Al8MzfbhTp0V99nba1sGjqRy" --------------Al8MzfbhTp0V99nba1sGjqRy Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMDUuMjMgMTY6MzksIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IE9uIDAzLjA1LjIz IDEyOjE4LCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+PiBPbiAwNS8wNC8yMDIzIDA4OjAzLCBK dWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4+ICtzdGF0aWMgdm9pZCBkb21haW5fYWNjX3ZhbGlk X21heChzdHJ1Y3QgZG9tYWluICpkLCBlbnVtIGFjY2l0ZW0gd2hhdCwNCj4+PiArwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdW5zaWduZWQgaW50IHZhbCkNCj4+PiArew0K Pj4+ICvCoMKgwqAgYXNzZXJ0KHdoYXQgPCBBUlJBWV9TSVpFKGQtPmFjYykpOw0KPj4+ICvC oMKgwqAgYXNzZXJ0KHdoYXQgPCBBUlJBWV9TSVpFKGFjY19nbG9iYWxfbWF4KSk7DQo+Pj4g Kw0KPj4+ICvCoMKgwqAgaWYgKHZhbCA+IGQtPmFjY1t3aGF0XS5tYXgpDQo+Pj4gK8KgwqDC oMKgwqDCoMKgIGQtPmFjY1t3aGF0XS5tYXggPSB2YWw7DQo+Pj4gK8KgwqDCoCBpZiAodmFs ID4gYWNjX2dsb2JhbF9tYXhbd2hhdF0gJiYgZG9taWRfaXNfdW5wcml2aWxlZ2VkKGQtPmRv bWlkKSkNCj4+PiArwqDCoMKgwqDCoMKgwqAgYWNjX2dsb2JhbF9tYXhbd2hhdF0gPSB2YWw7 DQo+Pj4gK30NCj4+PiArDQo+Pj4gwqAgc3RhdGljIGludCBkb21haW5fYWNjX2FkZF92YWxp ZChzdHJ1Y3QgZG9tYWluICpkLCBlbnVtIGFjY2l0ZW0gd2hhdCwgaW50IGFkZCkNCj4+PiDC oCB7DQo+Pj4gwqDCoMKgwqDCoCB1bnNpZ25lZCBpbnQgdmFsOw0KPj4+IC3CoMKgwqAgYXNz ZXJ0KHdoYXQgPCBBUlJBWV9TSVpFKGQtPmFjYykpOw0KPj4NCj4+IEkgdGhpbmsgdGhpcyBh c3NlcnQgc2hvdWxkIGJlIGtlcHQgYmVjYXVzZS4uLg0KPj4NCj4+PiAtDQo+Pj4gwqDCoMKg wqDCoCBpZiAoKGFkZCA8IDAgJiYgLWFkZCA+IGQtPmFjY1t3aGF0XS52YWwpIHx8DQo+Pg0K Pj4gLi4uIG9mIHRoaXMgY2hlY2suIE90aGVyd2lzZSwgeW91IHdvdWxkIGNoZWNrIHRoYXQg J3doYXQnIGlzIHdpdGhpbiB0aGUgYm91bmRzIA0KPj4gYWZ0ZXIgdGhlIHVzZS4NCj4gDQo+ IE9rYXkuDQoNCkhtbSwgSSdtIG5vIGxvbmdlciBzdXJlIHRoaXMgaXMgYSBnb29kIHJlYXNv biB0byBkdXBsaWNhdGUgdGhlIGFzc2VydCgpLg0KDQpGb2xsb3dpbmcgdGhpcyByZWFzb25p bmcgSSdkIG5lZWQgdG8gcHV0IGl0IGludG8gZXZlbiBtb3JlIGZ1bmN0aW9ucy4gQW5kIGFu DQphc3NlcnQoKSB0cmlnZ2VyaW5nIGEgbGl0dGxlIGJpdCBsYXRlIGlzIG5vIHJlYWwgcHJv YmxlbSwgYXMgaXQgd2lsbCBhYm9ydA0KeGVuc3RvcmVkIGFueXdheS4NCg0KQWRkaXRpb25h bGx5IHdpdGggdGhlIGdsb2JhbCBhbmQgdGhlIHBlci1kb21haW4gYXJyYXlzIG5vdyBjb3Zl cmluZyBhbGwNCnBvc3NpYmxlIHF1b3RhcywgaXQgd291bGQgZXZlbiBiZSByZWFzb25hYmxl IHRvIGRyb3AgdGhlIGFzc2VydCgpcyBpbg0KZG9tYWluX2FjY192YWxpZF9tYXgoKSBjb21w bGV0ZWx5Lg0KDQoNCkp1ZXJnZW4NCg== --------------Al8MzfbhTp0V99nba1sGjqRy Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------Al8MzfbhTp0V99nba1sGjqRy-- --------------krxl8VYciXw4aVNwHwjYgAy3-- --------------omy7s3TeOwCTo65ysfZS0svu Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmRTXrAFAwAAAAAACgkQsN6d1ii/Ey/c YAf+MbaXkDJigZEt8y6Sh5KvAOMsl3S4KOLaM4KZgsGjgMA5S5O/tMI3FV7z97sF8UzOZ0naj7UH eBvjq+SCXbL4fXN4k812h3Nn2hSfEGugcsl9XWgBh+CFCUJS7Jf1KQ3wS1QF1/zgBjom/Kari62c EMVQaJVp0S+9QNDGlT+19mZFocfPxQerlUTp5+xr0kf9VBeMrijEK6i86VOmKyFg2K6ZkzRMmKTg KcDjmv8e8xgcU8QIZiwnftYZj7qE0wnFfuwf0hFFNnn+n7EhkM4bgUlMDxr22/3OpMmMRF1hGNFG B27d5HJ8qQz43E6Ha+IKnRogYxEPS2uhVMHCXp0dKw== =umYT -----END PGP SIGNATURE----- --------------omy7s3TeOwCTo65ysfZS0svu-- From xen-devel-bounces@lists.xenproject.org Thu May 04 07:30:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 07:30:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529581.824103 (Exim 4.92) (envelope-from ) id 1puTQ4-0001Gz-AG; Thu, 04 May 2023 07:30:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529581.824103; Thu, 04 May 2023 07:30:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puTQ4-0001Gs-7B; Thu, 04 May 2023 07:30:28 +0000 Received: by outflank-mailman (input) for mailman id 529581; Thu, 04 May 2023 07:30:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puTQ2-0001Gf-Og for xen-devel@lists.xenproject.org; Thu, 04 May 2023 07:30:26 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on20603.outbound.protection.outlook.com [2a01:111:f400:7eaa::603]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 87f718a7-ea4d-11ed-8611-37d641c3527e; Thu, 04 May 2023 09:30:24 +0200 (CEST) Received: from DS7PR03CA0328.namprd03.prod.outlook.com (2603:10b6:8:2b::30) by PH0PR12MB5679.namprd12.prod.outlook.com (2603:10b6:510:14f::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Thu, 4 May 2023 07:30:19 +0000 Received: from DM6NAM11FT044.eop-nam11.prod.protection.outlook.com (2603:10b6:8:2b:cafe::5d) by DS7PR03CA0328.outlook.office365.com (2603:10b6:8:2b::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26 via Frontend Transport; Thu, 4 May 2023 07:30:18 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT044.mail.protection.outlook.com (10.13.173.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.27 via Frontend Transport; Thu, 4 May 2023 07:30:18 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 4 May 2023 02:30:17 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 4 May 2023 02:30:17 -0500 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 4 May 2023 02:30:15 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 87f718a7-ea4d-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EV6gYA28E9DOfBjQk9A0XhceyM2C/8+TklkE1RLM354c9oyu/RYyEu9dp2epeIk/bMb2QzqGdQO7S6q4PCa25RP4IA6aQAUI7M4aZdMwrtFmF8FVDy9Nnm7nWarIYAcnpsIC5Wp9u9GQFupmxG8Yv15tKSLT2Rcdz/g4EsgQ6735/AghMkHQyq2kO1/WAGN7fd8YfmRHFCZoPaPZ+TekOSha3pNGXN17CPYj8bPRLiTjjC+UmBws0Vlq/NdvLYF45MtMVx/DFhQZP7tMVqGQ2n9lMS4F2C1FIiIBKuH23sQgvvL7+V/7IAoS8aA+YyzwrAVuXyxsA1zslkuJeg+6DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lX6B3Pv3MVT8M+7HUeJq5+tI69DxXdfq+5n4o6/+Vt8=; b=gj43ETfFIwHvlSYgybRFHVrOXotPzPm7IF8tKPevEzzB3z8ohM82kdPkxvMydzv48qQaRpSwb4HZrIqmwNSZmV71IsfW1C5KVOgJofrrDUCjr4FdHRjTuJImf3vn3Rpt0fZxVPh+8Dm8jIJZQ0b344OmVH1hojyRcizAA3fAeWqZPP5LjYkHmSUm94JlQHYGgzd5Uv8kvGGXx0D+Bsp9dSgiZTDEVDGHRAMdu2lg46fgDy6MB/bhiP78CE04garUl1zUEdnvwxLzgs0yywnLFbrw4HFHTfZo86DJqXwl67Y6PG9/6YdhHf16lCfnnz5A7FaVzGq5yTQGM/nTcVZ3Ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lX6B3Pv3MVT8M+7HUeJq5+tI69DxXdfq+5n4o6/+Vt8=; b=R1/wPWDfeusBSqWi7QVkXEIm5IylL6qXln2gxbHwnQl1ndCp1Bn2KpkVe4TR16NApGoy+LUAwUqzFwOC/iPycuW3ve269o8VPEqgkOdrCPW46JKkycAmbtrSFAPiHff/jkS4Tz45KPwQ1i3hLXG6Mh1NVBwsXUnRg708Ak2/DyU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <0c947418-9551-c5cc-7fa3-8569f08d4c25@amd.com> Date: Thu, 4 May 2023 09:30:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [XEN v6 03/12] xen/arm: Introduce a wrapper for dt_device_get_address() to handle paddr_t Content-Language: en-US To: Ayan Kumar Halder , CC: , , , , , , , , , References: <20230428175543.11902-1-ayan.kumar.halder@amd.com> <20230428175543.11902-4-ayan.kumar.halder@amd.com> From: Michal Orzel In-Reply-To: <20230428175543.11902-4-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT044:EE_|PH0PR12MB5679:EE_ X-MS-Office365-Filtering-Correlation-Id: 80876131-7851-4e06-7add-08db4c71694f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: z222BoF3KjJwJw1ysBbUfXFxGGWFDJ4lUjajOyxc5UjbCOmkYJWFcyz/qm75hpYbOIH2EBU1lhsbchWOLuslSCc6vYzZfTO5UjAB8Ya/ODsPOsr2eyi3qZlz5LZjbvml65If25KStByTtjswvvnFdRLWT7xu3fqWUrtadZUhoBPBpenQ8xN1CCNnHOdedUx1zhRMczociE0ueTj6yvb76OzhxfgqpWl46NJVdUFYzDxeGOopKDHaj6UcJlZZz8CPMlJDDOm7r7IvtCCdz5wT55KyAG1SseXceSpvft3sH1Nl8NjaCKao4XzzKcZHztRIwciAAlCW5ahtW/C1BO3wJZWZ4zgT05OICD38Z7wa3Q3QfhKYUTzPhW8tLvArn6SpURpKOnTgFb64ns41n42fM/9OY2CxgY6IqEvjxAHqJarHwP9qZsgbryWjsIm6OxlBBjzGK5YMwPEY5SUeNF8kb8Z+Q2fS+rvS/1CqmSWe1genr20vSMAT7mv7UFsko1vuN17MgBWMB7ZxlDBDTJJ/kM62bZB0CkK1MugMWx/xZmOgH/Yl66ejjFPJhzUIA3HmFDaa73q5Hrddt0uO32XYAdBWuEs48Y/8kbesPCP0IdfUq6kpxlz9TrkYNhx95vzVkeV6SVaTl3DJ5W7/TdbTJNcH98E8vE7QFyWr/QwM5kGK2VJ6qwC8jylkZRdXZmlQjApi3HAphAS4A44xUq7XT8v3RCgFnqBWu/d7gvCAy1M5Y9Ee8eSb+J/EqL5FuKV3pyaqjrl0OrNEAUC7j2QOSQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(39860400002)(396003)(376002)(451199021)(46966006)(36840700001)(40470700004)(36756003)(4326008)(70586007)(426003)(336012)(70206006)(53546011)(26005)(186003)(110136005)(2906002)(54906003)(16576012)(31686004)(478600001)(40460700003)(2616005)(81166007)(82740400003)(356005)(8676002)(8936002)(40480700001)(44832011)(31696002)(6666004)(86362001)(41300700001)(82310400005)(7416002)(5660300002)(47076005)(316002)(36860700001)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 07:30:18.4107 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 80876131-7851-4e06-7add-08db4c71694f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT044.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5679 On 28/04/2023 19:55, Ayan Kumar Halder wrote: > > > dt_device_get_address() can accept uint64_t only for address and size. > However, the address/size denotes physical addresses. Thus, they should > be represented by 'paddr_t'. > Consequently, we introduce a wrapper for dt_device_get_address() ie > dt_device_get_paddr() which accepts address/size as paddr_t and inturn > invokes dt_device_get_address() after converting address/size to > uint64_t. > > The reason for introducing this is that in future 'paddr_t' may not > always be 64-bit. Thus, we need an explicit wrapper to do the type > conversion and return an error in case of truncation. > > With this, callers can now invoke dt_device_get_paddr(). > > Signed-off-by: Ayan Kumar Halder > diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c > index 6c9712ab7b..2163cf26d0 100644 > --- a/xen/common/device_tree.c > +++ b/xen/common/device_tree.c > @@ -955,6 +955,45 @@ int dt_device_get_address(const struct dt_device_node *dev, unsigned int index, > return 0; > } > > +int dt_device_get_paddr(const struct dt_device_node *dev, unsigned int index, > + paddr_t *addr, paddr_t *size) > +{ > + uint64_t dt_addr, dt_size; > + int ret; > + > + ret = dt_device_get_address(dev, index, &dt_addr, &dt_size); > + if ( ret ) > + return ret; > + > + if ( !addr ) Because of this ... > + return -EINVAL; > + > + if ( addr ) you should drop this. > + { > + if ( dt_addr != (paddr_t)dt_addr ) > + { > + printk("Error: Physical address 0x%"PRIx64" for node=%s is greater than max width (%zu bytes) supported\n", > + dt_addr, dev->name, sizeof(paddr_t)); > + return -ERANGE; > + } > + > + *addr = dt_addr; > + } > + > + if ( size ) > + { > + if ( dt_size != (paddr_t)dt_size ) > + { > + printk("Error: Physical size 0x%"PRIx64" for node=%s is greater than max width (%zu bytes) supported\n", > + dt_size, dev->name, sizeof(paddr_t)); > + return -ERANGE; > + } > + > + *size = dt_size; > + } > + > + return ret; > +} > > int dt_for_each_range(const struct dt_device_node *dev, > int (*cb)(const struct dt_device_node *, > diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h > index 5f8f61aec8..ce25b89c4b 100644 > --- a/xen/include/xen/device_tree.h > +++ b/xen/include/xen/device_tree.h > @@ -585,6 +585,19 @@ int dt_find_node_by_gpath(XEN_GUEST_HANDLE(char) u_path, uint32_t u_plen, > */ > const struct dt_device_node *dt_get_parent(const struct dt_device_node *node); > > +/** > + * dt_device_get_paddr - Resolve an address for a device > + * @device: the device whose address is to be resolved > + * @index: index of the address to resolve > + * @addr: address filled by this function > + * @size: size filled by this function > + * > + * This function resolves an address, walking the tree, for a give s/give/given Other than that: Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Thu May 04 07:37:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 07:37:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529586.824113 (Exim 4.92) (envelope-from ) id 1puTWb-00020B-5O; Thu, 04 May 2023 07:37:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529586.824113; Thu, 04 May 2023 07:37:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puTWb-000204-2j; Thu, 04 May 2023 07:37:13 +0000 Received: by outflank-mailman (input) for mailman id 529586; Thu, 04 May 2023 07:37:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puTWa-0001zw-1W for xen-devel@lists.xenproject.org; Thu, 04 May 2023 07:37:12 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2062a.outbound.protection.outlook.com [2a01:111:f400:7e8a::62a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7a1026a6-ea4e-11ed-b226-6b7b168915f2; Thu, 04 May 2023 09:37:10 +0200 (CEST) Received: from BN0PR02CA0034.namprd02.prod.outlook.com (2603:10b6:408:e5::9) by SA1PR12MB8844.namprd12.prod.outlook.com (2603:10b6:806:378::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Thu, 4 May 2023 07:37:07 +0000 Received: from BN8NAM11FT096.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e5:cafe::53) by BN0PR02CA0034.outlook.office365.com (2603:10b6:408:e5::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26 via Frontend Transport; Thu, 4 May 2023 07:37:07 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT096.mail.protection.outlook.com (10.13.177.195) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.26 via Frontend Transport; Thu, 4 May 2023 07:37:07 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 4 May 2023 02:37:06 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 4 May 2023 00:37:06 -0700 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 4 May 2023 02:37:03 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7a1026a6-ea4e-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oHvF1C89f/2TW8wdWUOmYH+s2bG6TZ7D7X8dwIDxQ+aSmUZuthmJJ03ou9ro14b+raEtgwzVI8eqlPZncaOmaE55qDApPZ9EuRluFIfq1qlRG04UgYpHe0cbqLVQOd7ViMJp4hdPMqvBshjfIpJPIchQNbtrNoQcICDLxfORTikDn4GBpk+o3UJliO0TqXnYxHC44q+jduuRi12LCQSnQYzJtnngb+L/gcS1hl5hHXLFiquvLmxZj4vBsajbM+v9zX/8jD1BOkOjl/XDRfEYlzGyYtUJnyKKdHd1nZP7GFYymt+k2zDl4UuWq3xn9SOMYItnoG+1poUVt/R2slUezw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Hu6RIZv7TDT51Iy6tIM1pYoLNuxak+6DMHpCl2kjCLY=; b=QKsOihvQnjv25Wai3rsM7/2ZNQgmS0ruZbbp7QQw3r7Jy9Vgonf7Tlr3VhjS9vwg1nSi59UQe9VveOgYKreNtu4UQtZ1+Apa5hPFeTsyvXzjhcDv+EcKknkaMmejMUxNQOTQazTo/JfDpwEQ1ELdkRUoJQYxRmsEPt3YLhNKbLi9qjjugU5PD+q/2xuHnCcpIeD4CMw7Js842c+zAD0d+8Pya1b2lV7WzHhe/S7PfznS8VRaXCifr3gWNhuljaZhIQdxKfFi8EajSf5ktGd6t19cmxYoS3drRJ/4IYCCoW5dn+aJtXXaPpIPHt1pT+p4Oc2cwq6JH0ks2GNrMTX0fA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hu6RIZv7TDT51Iy6tIM1pYoLNuxak+6DMHpCl2kjCLY=; b=VtJWsARv31OXPw9ZAHCx0sdouzVKXFjIcL6CFXVyDOwl0bnZGlAppTLWU3WPpNXhRlh/jwReC5gn08TgkTj99CBHPEIvzny84xlssQzk4bLmsJKa+0U1mFCqFcJHp+sJTVOCSopZ4JjyX287GdFukXZrnKAdPaawaZhD+sw2aHU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: Date: Thu, 4 May 2023 09:37:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [XEN v6 04/12] xen/arm: smmu: Use writeq_relaxed_non_atomic() for writing to SMMU_CBn_TTBR0 Content-Language: en-US To: Ayan Kumar Halder , CC: , , , , , , , , , References: <20230428175543.11902-1-ayan.kumar.halder@amd.com> <20230428175543.11902-5-ayan.kumar.halder@amd.com> From: Michal Orzel In-Reply-To: <20230428175543.11902-5-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT096:EE_|SA1PR12MB8844:EE_ X-MS-Office365-Filtering-Correlation-Id: 603f5a7e-87af-46ff-d2db-08db4c725ce9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p2snQRYJSJYpHFA1xT35VNyEWPn2EERHZfGw/vDbcIuwBE9TGdYbWxL3Zv9M9E41rCSG5M54v7uhB02qP22LDeMsnW/nIxt/pRUUH4Dtghlv2S4T4ycMegYkd+CqnSGcqhqGIL5CdOrDxbfn2fFsuP77TMjNkFgpojDNJMAVTu2OnCGkHmTRo5n/1PD218QxtMtMzUN/+MWH56Yjo5z72468XX9HBRdKa5S5oFl5sVoqBBavIAXTqsf77sEuz0oXRMYV+pKSVxnuOpyQGDkhd2EYzKlZobrelkZaNz5lZ2PGWLIpVpjphC12bq2T6aWphVRTUxJ/7KTCJim0NiB3fW0/37aibbnSsC0xH06zQMX/sBmd8SKnkEcavazSVkLBfrnm0YD/jHEtmIiFK2mEGEVxLacXwYHFEqD0RazhtV/DNg09F7XhAnALRwboQY8zfBFpEynn+IwrUYJPzFuC5CyLZ6V1MT7ZA7WV0A1LfUA2ekrQAgeAaVq5RsIaUl7sJLSDegiW3atVnVH9LkbFNM6egqDeqI5PS5KlmnOeNswL5DnO5Zq3pN20gPrexQ0HoDEKEfbeZPCzFgwMVk85o/lUwFGB3SDES5eX4MGPYkwYMNkcoG01RP31VjcMGgXyZiKz598FQfx91ze5S2zYziz9SxqBx51zx6jcX3SG9DscAas3Wok/kvhHzWLyWToSo0Co+cckXwIXFnA7bGM9A7yS9aYgWIqB43GTBJMPvxVph0zgOjdDb6vyq/wfSIyaEo5knxwAOB0XiM/sQvFxfQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(396003)(39860400002)(346002)(451199021)(36840700001)(40470700004)(46966006)(356005)(8676002)(53546011)(40480700001)(36756003)(26005)(336012)(8936002)(2616005)(426003)(7416002)(5660300002)(16576012)(316002)(110136005)(54906003)(70586007)(478600001)(4326008)(186003)(70206006)(41300700001)(81166007)(31696002)(86362001)(82740400003)(36860700001)(47076005)(83380400001)(44832011)(2906002)(82310400005)(40460700003)(31686004)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 07:37:07.1398 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 603f5a7e-87af-46ff-d2db-08db4c725ce9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT096.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8844 On 28/04/2023 19:55, Ayan Kumar Halder wrote: > > > Refer ARM IHI 0062D.c ID070116 (SMMU 2.0 spec), 17-360, 17.3.9, > SMMU_CBn_TTBR0 is a 64 bit register. Thus, one can use > writeq_relaxed_non_atomic() to write to it instead of invoking > writel_relaxed() twice for lower half and upper half of the register. > > This also helps us as p2maddr is 'paddr_t' (which may be u32 in future). > Thus, one can assign p2maddr to a 64 bit register and do the bit > manipulations on it, to generate the value for SMMU_CBn_TTBR0. > > Signed-off-by: Ayan Kumar Halder > Reviewed-by: Stefano Stabellini > --- > Changes from - > > v1 - 1. Extracted the patch from "[XEN v1 8/9] xen/arm: Other adaptations required to support 32bit paddr". > Use writeq_relaxed_non_atomic() to write u64 register in a non-atomic > fashion. > > v2 - 1. Added R-b. > > v3 - 1. No changes. > > v4 - 1. Reordered the R-b. No further changes. > (This patch can be committed independent of the series). > > v5 - Used 'uint64_t' instead of u64. As the change looked trivial to me, I > retained the R-b. > > xen/drivers/passthrough/arm/smmu.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c > index 79281075ba..fb8bef5f69 100644 > --- a/xen/drivers/passthrough/arm/smmu.c > +++ b/xen/drivers/passthrough/arm/smmu.c > @@ -499,8 +499,7 @@ enum arm_smmu_s2cr_privcfg { > #define ARM_SMMU_CB_SCTLR 0x0 > #define ARM_SMMU_CB_RESUME 0x8 > #define ARM_SMMU_CB_TTBCR2 0x10 > -#define ARM_SMMU_CB_TTBR0_LO 0x20 > -#define ARM_SMMU_CB_TTBR0_HI 0x24 > +#define ARM_SMMU_CB_TTBR0 0x20 > #define ARM_SMMU_CB_TTBCR 0x30 > #define ARM_SMMU_CB_S1_MAIR0 0x38 > #define ARM_SMMU_CB_FSR 0x58 > @@ -1083,6 +1082,7 @@ static void arm_smmu_flush_pgtable(struct arm_smmu_device *smmu, void *addr, > static void arm_smmu_init_context_bank(struct arm_smmu_domain *smmu_domain) > { > u32 reg; > + uint64_t reg64; > bool stage1; > struct arm_smmu_cfg *cfg = &smmu_domain->cfg; > struct arm_smmu_device *smmu = smmu_domain->smmu; > @@ -1177,12 +1177,13 @@ static void arm_smmu_init_context_bank(struct arm_smmu_domain *smmu_domain) > dev_notice(smmu->dev, "d%u: p2maddr 0x%"PRIpaddr"\n", > smmu_domain->cfg.domain->domain_id, p2maddr); > > - reg = (p2maddr & ((1ULL << 32) - 1)); > - writel_relaxed(reg, cb_base + ARM_SMMU_CB_TTBR0_LO); > - reg = (p2maddr >> 32); > + reg64 = p2maddr; > + > if (stage1) > - reg |= ARM_SMMU_CB_ASID(cfg) << TTBRn_HI_ASID_SHIFT; > - writel_relaxed(reg, cb_base + ARM_SMMU_CB_TTBR0_HI); > + reg64 |= (((uint64_t) (ARM_SMMU_CB_ASID(cfg) << TTBRn_HI_ASID_SHIFT)) > + << 32); I think << should be aligned to the second '(' above. Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Thu May 04 07:44:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 07:44:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529589.824124 (Exim 4.92) (envelope-from ) id 1puTdK-0003TX-VI; Thu, 04 May 2023 07:44:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529589.824124; Thu, 04 May 2023 07:44:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puTdK-0003TQ-RC; Thu, 04 May 2023 07:44:10 +0000 Received: by outflank-mailman (input) for mailman id 529589; Thu, 04 May 2023 07:44:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puTdJ-0003TK-E1 for xen-devel@lists.xenproject.org; Thu, 04 May 2023 07:44:09 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on20606.outbound.protection.outlook.com [2a01:111:f400:fe13::606]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 72f7c0da-ea4f-11ed-8611-37d641c3527e; Thu, 04 May 2023 09:44:07 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8644.eurprd04.prod.outlook.com (2603:10a6:20b:42b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Thu, 4 May 2023 07:44:06 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6363.022; Thu, 4 May 2023 07:44:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 72f7c0da-ea4f-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J7JJucWs7/ZMt+VkgeBDHTPXL1Ll1z8h7etz+PqaD5tjrmdTFOCr05jlcVzyOdCNPP1AZYEtLk9hw0EZC4lygBCUoKAabf/08sKKV6pX8+sdDiMQt57QUxbf4+g4C45oeav0KRArbwZV2oRwvqQXtgCTlJlriidHFss74xnkrSE3M1Q+OrC0FXu3HYszADolR4ywfBEXehBhu2nibtMrMQph9PJ7cdRqu/3o9y104csVD1qHEgw+BrR6ndf3Rh1T3jMYwbYfhnc1kmx5ZBNktOon4csX1t0jemxyV3b85RL3o9WBYmL3ZEfHtV/CSEDiLodRNN3UajuviPGHI5ReZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9CiAMrpXGLanBsbatUg3PQiFHBMR9ut/YXD3WLXe1lg=; b=GNwk/IJnwT9S5yUHg6+vNXgtmRSAX2HY2d3hXx/FHAtjiKWcZH/SEq472dNGtlIe5yUbzmsbkshhNTrBEF91HB3AGJRsvQ3HUahdrJDApYg+5jqVihBfRue0X37lVUPTpIq8NERHD4OSZar8SzqX3QNdGSEhIdLvVH6MOFs7wxlTSEpOyBarI/i7UECj9gNRRkeAd8KiwcepGK6vuJWV3lm2qWTyGTBB9232wf0h0A/sX76ZBEO93EI+KUmFQEykZox3idWqA6ViBnlVotCbyO1gMdQ+F15GMGAA2qNFrXGAqXhy2cofIPFeyn8z0ypTzh9fjXsdVOONqoCXGCAuUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9CiAMrpXGLanBsbatUg3PQiFHBMR9ut/YXD3WLXe1lg=; b=VrGgZnuvs3LU4SEo0wPh0Fn58qtBqm6Pd0xgvujRqK0o4dQJFR/GBJd2aqRfV5Fv+CNSGqMSeOuA67QTi5z8Idvzwg1g/WMFCoUjhf11hXxLKhlB6iJq/r9ZUS/np3T3xUpQx9FK0SmDydKSGfsXqYkl1Cme0bm7cMdoKHhxPmO4d1naFaN+rUje0zSa01DowB49hCtaZ7TX17IwPYXA1bQtSGfTf7csNprAnLpdZqd9YWdFag8s3/CtHBAHZMa+h7F4l0JrxYfU9F3u9+qZYGzIlsuTMQaFlXcM7MTqJcCOQzQTtx4BBLOXbKoLdvtoiH3XpnvthK2r+IslcgwRmQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 4 May 2023 09:44:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3 4/8] x86/mem-sharing: copy GADDR based shared guest areas Content-Language: en-US To: Tamas K Lengyel Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <472f8314-9ad7-523a-32dc-d5c2138c2c8c@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0075.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8644:EE_ X-MS-Office365-Filtering-Correlation-Id: cfbfd59d-2789-46c2-3124-08db4c735647 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /ab44n/bbzDb0iWahSJ6e2Io39H6bdzUL2SnD3ANzJRj28T7sw6qjO9nzWpRVGfL/KxT5gcRAJKc79YgX3ZFA7cMQqin80Kpo+MkvxNkjaFkeF9VhX5BUOqyVJpZvLrUAAGR/MgkOB5izRFFqpvaTuwn0kBx50t6YXvLCbyRGRFY7+ZZRYBkQ6LeBzXRtFMQ6C12JJUOThYkWa9/450wTfbYyrV4qB2GOEZg74KcvoNT/JyFcfE9qiRkLj+z9z+XDsYKBwuelsaDFGdWfmw2faoarNsPHrEHxPKoRA3mo932TCHC+RRnxkpNZ/G6kfX4I1wbWCAMWMOg9Xj4/nSuOZvFHYjipxgHjPc8GoHzPhVYKOdixQXx2LYVi58+e7xNXLuHs5t512Y4A8DzrrXmEJy7+C6rnMOss0/EYvA4zq3La6e5FWOTa2lGclUHEaoQGLkkNPR1NWPhSA0m9GgMhMZbqSuxuZ6cb0y+sJFkmU5lDbqec+kCBI3DwuQXPRA+Q6XzzWQvWCIRCzJiYXy5mhQCjG0GPSDRei6KLnl815U0HlFRX5Fal4WaJiwQ96Tq1nGPAfANrMqBLmk4r/wHhcjWO7+OZR5VVEWexlF84zTI48g5Tg4UXKzJXOqqK74CraZCZDRWAFLu7EoS+Cy9mA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(136003)(346002)(396003)(376002)(366004)(451199021)(26005)(6506007)(6512007)(53546011)(186003)(2616005)(66899021)(31686004)(54906003)(83380400001)(6486002)(36756003)(316002)(5660300002)(478600001)(2906002)(6916009)(4326008)(31696002)(38100700002)(86362001)(41300700001)(8676002)(8936002)(66556008)(66946007)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?enk5V2g3K2V5WmJBelg2aUd4ZFdFQkhtc0RaWVFPNUpRYVNWNndicTVsTGlF?= =?utf-8?B?bmFPQWtwSk1QUXZQbHNzU21aUytzVEZaRWRUczBwY2M3OHo1T09TSjdhelZI?= =?utf-8?B?Q3A0SE1XcGpQSXIxU2FrVTNjWXBrZHpTUVhmSDV3NFJkekpDcDNMOTZ0cXhh?= =?utf-8?B?OTVFRHptMzQ3MUE4NTdhRHVKWnRaRGJWcEFvM2d3WTI1YktrR3JaR1Z1aUdU?= =?utf-8?B?OWJTN3ZVdE1icmdONGwxMlJJMG40MUMvR1RxUHBjN1ZzejQvVkxUcXdTTjVt?= =?utf-8?B?NzNxd2JWQU9JblVab2FxSlNkdmRoQUp5RTU4UUhBTGsvQWZwQUhWTjd1NXpy?= =?utf-8?B?SkdYclBqSFJhMm4weW93cE9rR2lFVjMvSEZvdjdwc084SVJOQWFzVTRBb01a?= =?utf-8?B?L05IQXF1MFhJZ1llNm1nRWUyT3cxd0VPQ1d2Z0NTM1ZITDJ3RDhXd2pqMkdv?= =?utf-8?B?OE5meFRyOTYvWmpSWktjbk8vM2toUXZWTDdpYjlsSGFIRnlQcmcrNk9sWStQ?= =?utf-8?B?NjJEWm9Jd0REMmtSb01yT1JscHJHTkxBbWhKZzNKVlhmV2x0Wi9scFY4OUdP?= =?utf-8?B?Z0NzTnJ6QUFzNWhUYit0YmRBK3M0OWRYTUpvWTMvVCtVWmZxVUVxOXZIUGxM?= =?utf-8?B?SDI4cVFaMFRXdFpIWG5kYUxwSGJMRlBqNUluUW81VWxaWGJrZFhSSy92SDI0?= =?utf-8?B?R3E0UEZ1Z21saHFaY3Y5RldVYUp6Mkdxc1pMVTYrbHVMMU0xYU9LQmNpUFJv?= =?utf-8?B?T2JJUkYrSmk2cDltZFo1Y2k0aG1uaGt1d3BkZTVEWHU0UmpvY1hPOXJjdmNu?= =?utf-8?B?VDNQUjVCNHhsUWRuTWVMNkpaS2Y2bFd5Qm5yeWI2dWRjQ0VmMEd2Rnd6Z3Yv?= =?utf-8?B?d3NGanpkM3I0aXNnNEp0MXp3K2FTbUVsalNiMmg3QkZ1TUJGdEdtbGp6bWF6?= =?utf-8?B?dWlzWk5zVzlmS0hGWUZwcTc0YkZZNGRUbmZTdEhSUWZtNjM3eFN0LzdpTXA3?= =?utf-8?B?SkU3QVJqSjFxSkJRR1ZsbWxwNFdLZCs0bVh1N2M4bTFid1B6Q21RMyszemhW?= =?utf-8?B?bUFSRS9FblpSbEVQbFNXYUxCUTdDZmdFeHJTS1FHbDYrOFNaRXhMbU5oVnU2?= =?utf-8?B?blAyYldqOTd2WjVkaEZNQXJxYkpKMzJJQnFRTEFDbXF4WE9WbUhTcEloVG4v?= =?utf-8?B?ekZOMGZxNmQ1WFYvellZY2lKZVVwdFJsUTlHQ1BFUWx6cEpqSWJueFVLWkxo?= =?utf-8?B?TEtySC8xU2pISW5INGFhU3dFZnNVWVdjbEs0aGYzTHNjTmw5Q2NUU044UkZN?= =?utf-8?B?eGVpaGhMOWJnZk9uMlV1ckorM3Y2bHprcGlFNnhJbXAwK2tqeCs5dGREYS93?= =?utf-8?B?R242NzJkQnpkbzNjMS8reTE1THdsb3hFZENTV0xMeVV3MFB1akcyWFBsUTkr?= =?utf-8?B?bFNyQVRYTlJ3cFp6amp6OTJJZWlwN29lYWgyQlVPVHo2SHRVcisyZTErbEFx?= =?utf-8?B?NGdjWlI1NnJ6bEVscitVVUs1YS9FYlhCenZJUVBnVjk5VEd4T2U4RHY4MzRH?= =?utf-8?B?emVyaVZIMHB5WFhRL3YxSklpK3lLN09NNCtVMWc2MWtYTDVUaGl0UTJPc2hm?= =?utf-8?B?T1Bna3lXVnc4ZEVvMVVaaGFuVmZNdFY1WG1ETE44RWVFMFlTNEprUk56Wmkz?= =?utf-8?B?aWU2b3gzQjhwakJpck9SaUNkVzJaSTRHdmR3NEdUTjhuUDRxSHlWMlI1cjd0?= =?utf-8?B?Mjl4Z21pYm9YSng2d3dNVWsydnpuWnRTY2w1aHB2cmpORnpyYXdJZEZJdHBE?= =?utf-8?B?RjF1Qjd5NUErTlNESnU4dEFYdS9hTlRYOVRJVlk2K1VEKzRMQk1PaURWb0lo?= =?utf-8?B?SnN0eThkMFdaN1BJdWFuaHBpMmUyY0VFamt1ZDNaUGx3L1JtVG5Jdi85U1p5?= =?utf-8?B?T29TRXVTM1BiRXRSZWN4U0FFSGJpRUJCM2dodHNyVzFOdWovR05aWWNqME1J?= =?utf-8?B?WnlSbkFlU1lxMkZSSVpsQXVCNEZjWnV4ZFJlSGRyL1d4VEx6OFJyOHJNWVNB?= =?utf-8?B?Nm8wK1NPSFpFRy9mWDMvb2hCNHJJVEN3SXhtV0ZwaXR0STRHZTU3cDlpd2ly?= =?utf-8?Q?FXUmKovkzkYfnqTCSIyIx54Cz?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cfbfd59d-2789-46c2-3124-08db4c735647 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 07:44:05.6629 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OifVk2omLdFPV3VmcdQcMIZh/W0NDMcF4YPg9MLA8agIG4deKMoGq+16z5mfww1lHmox6YQbSgEGSD0jzCHwng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8644 On 03.05.2023 19:14, Tamas K Lengyel wrote: >> @@ -1974,7 +2046,10 @@ int mem_sharing_fork_reset(struct domain >> >> state: >> if ( reset_state ) >> + { >> rc = copy_settings(d, pd); >> + /* TBD: What to do here with -ERESTART? */ > > Ideally we could avoid hitting code-paths that are restartable during fork > reset since it gets called from vm_event replies that have no concept of > handling errors. If we start having errors like this we would just have to > drop the vm_event reply optimization and issue a standalone fork reset > hypercall every time which isn't a big deal, it's just slower. I'm afraid I don't follow: We are in the process of fork-reset here. How would issuing "a standalone fork reset hypercall every time" make this any different? The possible need for a continuation here comes from a failed spin_trylock() in map_guest_area(). That won't change the next time round. But perhaps I should say that till now I didn't even pay much attention to the 2nd use of the function by vm_event_resume(); I was mainly focused on the one from XENMEM_sharing_op_fork_reset, where no continuation handling exists. Yet perhaps your comment is mainly related to that use? I actually notice that the comment ahead of the function already has a continuation related TODO, just that there thought is only of larger memory footprint. > My > preference would actually be that after the initial forking is performed a > local copy of the parent's state is maintained for the fork to reset to so > there would be no case of hitting an error like this. It would also allow > us in the future to unpause the parent for example.. Oh, I guess I didn't realize the parent was kept paused. Such state copying / caching may then indeed be a possibility, but that's nothing I can see myself deal with, even less so in the context of this series. I need a solution to the problem at hand within the scope of what is there right now (or based on what could be provided e.g. by you within the foreseeable future). Bubbling up the need for continuation from the XENMEM_sharing_op_fork_reset path is the most I could see me handle myself ... For vm_event_resume() bubbling state up the domctl path _may_ also be doable, but mem_sharing_notification() and friends don't even check the function's return value. Jan From xen-devel-bounces@lists.xenproject.org Thu May 04 07:44:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 07:44:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529590.824133 (Exim 4.92) (envelope-from ) id 1puTdb-0003nt-5y; Thu, 04 May 2023 07:44:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529590.824133; Thu, 04 May 2023 07:44:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puTdb-0003nm-3B; Thu, 04 May 2023 07:44:27 +0000 Received: by outflank-mailman (input) for mailman id 529590; Thu, 04 May 2023 07:44:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puTdZ-0003TK-AN for xen-devel@lists.xenproject.org; Thu, 04 May 2023 07:44:25 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7b29185c-ea4f-11ed-8611-37d641c3527e; Thu, 04 May 2023 09:44:22 +0200 (CEST) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 May 2023 03:44:17 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by BLAPR03MB5409.namprd03.prod.outlook.com (2603:10b6:208:290::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Thu, 4 May 2023 07:44:16 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec%3]) with mapi id 15.20.6340.031; Thu, 4 May 2023 07:44:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7b29185c-ea4f-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683186261; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=yk8GEGwtFNhf6MLWbdraXhm9Rq7CHNlbs51CGLhvgeg=; b=RnCjVuHzs1eEZUsfYKTomu6mR25nwfQwCbxxz7vx3pYcQFQSZOZ9F2xL 8flAkcaTrkG02JMpZ69kFrD0mZfDtyHse9NPqu/aw5sJyFRVTsijPguJC mnp22D7dNR5sTMfeKSS8iNP43hxvk2LDw4yH5GIhseBAZ2nnzM9p45YIq I=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 108226374 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:PLdoCqKsjLrZUAwhFE+RVZQlxSXFcZb7ZxGr2PjKsXjdYENS0jAOn zAeUDuEbKnZMWakco8kPoXjp08O6JCBztQ2T1RlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPSwP9TlK6q4mhA4wRiPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5bCEBUy eNfIQtQSRuvru2T4Y+CEs1F05FLwMnDZOvzu1lG5BSAVLMMZ8CGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dnpTGNnWSd05C0WDbRUsaNSshP2F6Ru 0rN/njjAwFcP9uaodaA2iv01rWVw3ikBOr+EpWAqMdskgK0x1c4BR8dS3++rtu8mFWhDoc3x 0s8v3BGQbIJ3E6hQ8T5Xha4iGWZpRNaUN1Ve8Uq5QfIxqfK7gKxAmkfUiUHeNEgrNUxRzEhy hmOhdyBLT5ytLyYT1qN+7HSqim9UQAONnMLbyIASQoD4vHgrZs1gxaJScxseIaqivXlFDe2x CqFxAA0iq8Pl8cN2+O+9ErenjO3jpHTS0g+4QC/dnyi6gR1dYu0fbui4FLQ7etDBIuBR1zHt 38B8/Vy98gLBJCJ0SaLEOMEGejw4+7faWONx1lyA5Mm6jKhvWa5epxd6y1/I0EvNdsYfTjuY wnYvgY5CIJvAUZGpJRfO+qZY/nGB4C7fTg5fpg4tuZzX6U= IronPort-HdrOrdr: A9a23:rYIDbaABe6xfAGPlHelo55DYdb4zR+YMi2TDt3oddfU1SL38qy nKpp4mPHDP5wr5NEtPpTniAtjjfZq/z/5ICOAqVN/PYOCPggCVxepZnOjfKlPbehEX9oRmpN 1dm6oVMqyMMbCt5/yKnDVRELwbsaa6GLjDv5a785/0JzsaE52J6W1Ce2GmO3wzfiZqL7wjGq GR48JWzgDQAkj+PqyAdx84t/GonayzqK7b X-Talos-CUID: 9a23:bGbPUmP7RazVWO5DdCBG7nILXckeL1rW4F7fBm6FMD5NYejA X-Talos-MUID: 9a23:qFainQgxt3to+LSNhFRPHMMpDJlR5bbxL0E2upgEsNegMCNSPiWGk2Hi X-IronPort-AV: E=Sophos;i="5.99,249,1677560400"; d="scan'208";a="108226374" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dPPOv+E/oG41XGUAawPerIwgks5lQUiVoVJjupgDW4R4nGlEVv7Hb1QCut/Ab4zSquRMnS5VgamV6e0aBr/Ku9Ywq4KZeR3rsCMpT3ek/lkaeCh4BzphM1ULrHPpGpx3FTEv63GQi6m8IlAUa9zxDODnrLqsk5zFnQFs35j0Wo/FsvpMKB4iYe+rv3z0fmsYs7HvnmVBMzm4eMI+GFwC2ItuUyPcybOpmAhQem5VidnqzaAGZvO5O3ikQxBnMTVQStYYRTU0YslNtWUjRFGe4VYo4TByVpuB53v6eQ+2I3dUE0s69FcjwQ/J+3MX5wZOKAKbFd+Lgqn6+oK0Plv+nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LTFv2L769fnTJo8Ke6VVXviRQQALqA65dGzZvVdiga8=; b=JwVWUjXfUX5TZ6bZwbKLIZLyN9UEh2hAozXChpszJFkVGBXDp0qazv+o4QAY+SpB+e9DjZenoWLVNx9yxYhyG4CRh65O74X1ceXE+y+/SKb795+2ZWmdsAKvIDTDx9PI44lsrRYjaqtTQ5fRJ+N0jPoqSiAsf+wAj1YFHJyYM7PWRZBwq2RWM5fqbHwTtSRo238nWoaphKRYmamWQV3Sk7ViHzSucqkj2GczPOFjBfwUAT6wsXb7f02vsc2pfSP4M7vx+NoVRt8477qu1kJqhIQhk7LqMG9IAP6D1zO2KJgUjfMQf9syOMU2livccuZUOzcSoFHwrcZPxtl7FzcZRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LTFv2L769fnTJo8Ke6VVXviRQQALqA65dGzZvVdiga8=; b=ft3ZsGtXNJJVW0KWp/Deauzp7f7xt9QKH1jpBS1+TO7MmfTpMSK78ucXVlIGA6G0vRGqXkpGt6yPNqo6C9kMadEQmxcx61HR7qEAb8CjDEMxP7Q4llZTe6ZvvHl9c2FQyRJWsCmVMYrexyzviXjLLnNe8vpkW18UuCH5xSYK1ck= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 4 May 2023 09:44:11 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v2 1/2] restrict concept of pIRQ to x86 Message-ID: References: <85e59fd5-9a06-48b4-ba7e-81865d44e332@suse.com> <98f51b96-8a1c-7f33-b4d3-1744174df465@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <98f51b96-8a1c-7f33-b4d3-1744174df465@suse.com> X-ClientProxiedBy: LO4P123CA0513.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:272::23) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|BLAPR03MB5409:EE_ X-MS-Office365-Filtering-Correlation-Id: 11bfeee6-5f5a-4d75-b6b4-08db4c735cb9 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qnNrM7Z3w/+QWoVJJyYzWCifwYA7cjHH3ffJD3Bu6Y/slg7kkymqN253mt+4Cb5m3FF1g9YQVIACFIIGhKEyBbcXDf31NzxS8pVRtn8CZW7+Cpf65ykl9tBiEs9pZkeR6gstV2+vlcneum2GwrpR2l16osEzdYPpbsIvSKfNl66NmBDZvThUmE6EeSsJjZ1qgcKSzmXz9hUomep0J420vxHH02Z2sPB0QfRYYx87KNPqlvj7zcJHzfkiFuo2sBrrUGWtvn9vY62fNP+f7e34Fu5HaoPCBl0GoogWH23zOHkNCFx6U3ugWlJNEvBH/NC+tpKvffRi/fIte5g/TzS9SL0/uolr5wv7U5LVHMhSGbiZ8ZdsLWAcg8403qe/9lfE3BFMHgOTRmpu26dbeRu/J3QOPpRt5z1DLQ5a1X8S/Bq53hGeWwPXcaCO7bfVpzhNZ6B8fEq18Ldz/2VIjDpoEyOw5NqzKCWwOC3LtglcmumiDoMP6JkHyPJIun/gaUj906PBSeEhTSZxWBVZ4UGB4E/HPRdrJOplta73QHzjVTKZH7VDpvCMl8mhIz3ilLQg X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(7916004)(4636009)(366004)(136003)(376002)(346002)(39860400002)(396003)(451199021)(54906003)(66556008)(316002)(66476007)(6486002)(6666004)(478600001)(6916009)(4326008)(66946007)(86362001)(85182001)(83380400001)(6506007)(6512007)(26005)(9686003)(8936002)(4744005)(8676002)(2906002)(5660300002)(41300700001)(82960400001)(33716001)(38100700002)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bWN5cy80bkZHc2IzS1orekQ2WDMvTXg0Zm9hcEt2L2dmeXZtTnhacWhtVCtQ?= =?utf-8?B?eTVGTVZta1BCeHVSTkVHY3pCNjh1NEFtR1dUSDRVV04wcHg5MGJENnBhNWVw?= =?utf-8?B?eFJkY2ord3M3Rm44SmdhYVpYWDc3aVY2SEp1L3M0c3ZYYnd4dEgxWEJZdXhn?= =?utf-8?B?QUxHWHRhMy8wQUtPSmRpb0FaSWNjcmZNdW5FZGJpQlQwSytTNDBDeWRJa3FB?= =?utf-8?B?ZnFlbGtvR2xROTd3UVZ2UG5yWUNRRHF0SDdyMllNOHpWNlIxSVdkaDh2Szly?= =?utf-8?B?RE9pU085YnNnMjMvS1NRT0VjdUhscDE4WGtPQThRc1JoSEx0OEhaaFV5WXhE?= =?utf-8?B?c21HTkFrTExGYkN2ZVEvc1JSRkhFSGtaNUN0YzZZaVZOL0dVN3YwZkNGakdX?= =?utf-8?B?emcySTk3ZlpvN0JtRlVRaFNFc3JyY1JBVGFoNnBCQWExVldReEI0RVNwbFg0?= =?utf-8?B?NUNtRWdMNldiRGpRdDNRSmNIbUR6MFU4eURRQnYxcnFxYVQyMi81R3Fjekpm?= =?utf-8?B?UU53SGU3TTd1MzFBWm5hTUl5czhJc0xoR3R5b1hMQ0xJbG1MM2pxOXJaUWJP?= =?utf-8?B?TFVsK1BLWDVleWdWWFJtME1mTlFvR2p2QVNnbGJicTFmcDEvOHJhdmZvQVov?= =?utf-8?B?eTFTRW53K2VvdERtNWVmQjlrcllKMjVSRG5GKzV5QnpJVW94Rm1LTDExb2Fp?= =?utf-8?B?UjJvQlM4dHFDZlNXVS8rVHpFWi9kRm15SThtWklXanZRTm9VVUJEa2dsOTJU?= =?utf-8?B?QTIzVEZEdGEzN1JqWGJGSE1sR3hyVkMySkxEMDdYMnJFNmhvL1FKMXlmYU1K?= =?utf-8?B?dEFNaUo1ZjliRU9ENzZkSUtXejFvdjNjdWwrYUphNUZuRXE4djczQXBHZFI5?= =?utf-8?B?QmFOYzF4R1dlWG1qZ3ZxVnhYSDJqalZSckxXaHBLU01CTHBaeVJSK3ZvRnpw?= =?utf-8?B?VGlkM2orZjc1eW9kTDEzUC81ZzcxZGg1MklxTitJWkhaRU5COHBhWVQ3L09L?= =?utf-8?B?Kzc4U0NoZFdqVEh2aGcyVk02TTM3K3RKSElpWFRNdHpzT3NtZVl4L2QxL21X?= =?utf-8?B?Zk1MN2drZzRBT0lKR3dCS3RnSmNDVDFqNGEvVDJMNjFoQVd4UHZ2SDJsVUFt?= =?utf-8?B?U1ljZ3AvZkgvQVRkckNWTldtTGs5S2NuSmJLL2hmbzBtakhpNitpN3U0Q2Fo?= =?utf-8?B?UXFNUjdHMG8vN1NnTkhxd1o5dmJpZzJFaEoxakY1bW4zaDdUYkF0dUVmaXdZ?= =?utf-8?B?NnAvM3BiZ1dQNnQxMWhZZG9PNkIyRUNucm5rdEhMSVkzRHRsMUxYZUFycVhQ?= =?utf-8?B?QWVlMFI0dC9JN3RUeUxYM1lBcndJVVVDTXVZMCsySWxSRFZuSEQ2eTVVTFFR?= =?utf-8?B?cmhuQzUzSTNoZ3dYOW9GRktnaXovOXdTNFlscG1qeWFsTHV1dlNWK3VBU1B1?= =?utf-8?B?QzNVbVlrcDQwMnZZR0l3U2pDNm5GZDN3UllzQytEeUk5V0hrRS9ldjVQQ0Zy?= =?utf-8?B?aHpJOHp6RXQxajlkWmpTcTRKZzU0Y3NIb3J1VC8zdFBwejlQQUJ3b0VBcHdP?= =?utf-8?B?WjZZTDUzQ0lSMnQrUXZPKzNNRCs1NzE1YmpqZ1NyMlluY3VtcHRiTU9XV0dE?= =?utf-8?B?dCtLK1MyUVN6TGZ2dkxyTVBxVUExMnhXbFFXSkY3MjZTSS9kK2g5Qmo5Nm56?= =?utf-8?B?bEdMdVIyM1drUlMxcVVjeVZqeGtsM2U3Z29wU1k2VGNwWkQwNkI0eDNjT2hU?= =?utf-8?B?V0pXcWZ0V0QvdVNXejQ1dkdjMDk3Z3VZVThlMy95WCtKYVZvZHRDTUFnTXV3?= =?utf-8?B?Z1hINFFJS0VWRnc3MkZVck80UEJQSmdnZVhJcVlEYlRBMVk1WlBybmRpdmd0?= =?utf-8?B?azZzZ2EyUnVwM0FNRTJvN1FDMlRLVFpuQW5ZYzZMK0cvVWpsMnliSlZTeDJu?= =?utf-8?B?SHhqdFp6cEhNbzNzdFhyeEdab3FaazZqNEJiSEtUY2tlTEF6eEkveFNYZHBK?= =?utf-8?B?STlXRE9CcG9jZjhYNWNrMEpqOElvWnhXNWxSL050YkptK2VZTXkxRk1mOXFT?= =?utf-8?B?SmRPbUN0a3cvcSs3TkFIM1owUFk4dTQxNHNscnNFKytub1dTbHFxc3RFczVu?= =?utf-8?Q?nUYo6hgeaKsg2Lh8ImjunzEmg?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: QYzVcb+PCuuOzSnWSwZQ6lAohSVyy9jz25w3U4XllgoY2SfpZfxKgO98AGudEph8E78n1eOWKjyO1ixUpMFUfjxwEgtyn+cpdUW94mHvehusdniV2bISkqcNQf99FQI9DM1nZnIGzC5RJiOQmo1gi0o1Einb8redk7bX568YzrnXvbyNTPgAC0raWKuotr2NKiMDQR8KoOiJDFIaqg33AG7yaPAxxjZsKxyUge5fJ+oSPap+BMMLZpy5QpYbwwSSxuTTb3ks8d+X8Vy0Na0Z3Dk2OFs/egfYuUvFv4yWlQJ23/g3SUj9vrs1m9kM0+IfmXxoO1In42NQGL/a1BmZQLIq6BaauQTXa8/SgyJadviFsDaXrwi1AAMp/W1UIVGIlDveJA5CaRGXVqNsZx8N/jRmENJJI5cpYCbHoTsEmvHdnYPWuQhG4jGOXzc4dsEpTSw3juWj80nafQAd3Rd2yJetw5HLILlL7d8bdguzA+1LjgT7SWLibPGMFK1nKxdTwZeyuqUw7dKS6dFDnULYwqBnmnTwsOD0wlGS0FEUr34RwlxBq1AjuEGwjuMyw3q04eV02FcY/HorCJoq8rxgB/WMFiLmV16sZ2gvq8iKwMjVSq0ETaNhbf8Tuo1emygBkKcp2MLpEHX6YP8oxFJB83W4zsga+YQB3CEDxegE7Qxak3CoOqUfqyp7/bDQITf4yOWWZy/k/EWU6xs+UA/7N55fU1utcCHxszyFxFQkH8axIKFXOFQIse4kwCB2nDkTPZe1C3+8rHIMvDw3Aeq8D2xeaypjfINx8VRXUf5G5qnpkntP/H5pkcHdApyqwdM9WZQ+jfTNlPLCg1+8OSeufNBdej+dizTFut//TzTFopX3R0T1tFzN/XkKSw6EiCrH16LVgOLyjw6G4U35gaeJ7A== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 11bfeee6-5f5a-4d75-b6b4-08db4c735cb9 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 07:44:16.4996 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DokWulNcHQJeYrd5TU+CXtW8Dly+OMKxfIQvHt1/QRu/zA7H4uxXqEu9ZeiUmYmInnwRrYPHFOxmSPb5TZhK9Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5409 On Wed, May 03, 2023 at 05:33:05PM +0200, Jan Beulich wrote: > --- a/xen/include/xen/sched.h > +++ b/xen/include/xen/sched.h > @@ -438,12 +438,14 @@ struct domain > > struct grant_table *grant_table; > > +#ifdef CONFIG_HAS_PIRQ > /* > * Interrupt to event-channel mappings and other per-guest-pirq data. > * Protected by the domain's event-channel spinlock. > */ > struct radix_tree_root pirq_tree; > unsigned int nr_pirqs; > +#endif Won't it be cleaner to just move this into arch_domain and avoid a bunch of the ifdefary? As the initialization of the fields would be moved to arch_domain_create() also. Maybe we would want to introduce some kind of arch-specific event channel handler so that the bind PIRQ hypercall could be handled there? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu May 04 07:50:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 07:50:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529598.824144 (Exim 4.92) (envelope-from ) id 1puTjY-0005at-VZ; Thu, 04 May 2023 07:50:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529598.824144; Thu, 04 May 2023 07:50:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puTjY-0005am-Sr; Thu, 04 May 2023 07:50:36 +0000 Received: by outflank-mailman (input) for mailman id 529598; Thu, 04 May 2023 07:50:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puTjX-0005ag-OK for xen-devel@lists.xenproject.org; Thu, 04 May 2023 07:50:35 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20602.outbound.protection.outlook.com [2a01:111:f400:fe1a::602]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 594dea75-ea50-11ed-8611-37d641c3527e; Thu, 04 May 2023 09:50:33 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9708.eurprd04.prod.outlook.com (2603:10a6:102:24e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Thu, 4 May 2023 07:50:30 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6363.022; Thu, 4 May 2023 07:50:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 594dea75-ea50-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JP0dg7emPWMFCbzQHGL/5yHAjo5qtmu6tZBzrdZuC554LjwQWcSc0cM45W5WCLtHDkyAPguUILVEHlsXSwRsUK9bcJ7qZG/NcY5O2Qtn6JSH3suwRqzBMkc2AI9hIEwpMWZYZfN75L5ZI2TxROXZz22zws58Jm1slf2L86fZJZ7DNVW1PstZU4VTnE+l2u5Zd3H8HsfIfiYcN+jd5tU/KhnWL+s+pfKfy9ovSXb16T/9RpqecZO86b1Mg0xSROAjCmUSHpTSe/3m9n0G91BqZ4zD4OzwzoECSwksonNh1PGa4tpfdaFnw8/V8L0LhM+OwruwB3YmNc0Ockhy3sAVJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Lv6nK4okzX9Eb24rzwqQlQtMHnW6zOzECXaBdXmSqh0=; b=FUDMwP3EvBs8q7nm4avNI8Xarpb5DVv3JXXTE0DSNTXtbbME9V6w0bvgUDAVEyIgdyOt+31slRNJeuTGIMkuesFss/m5apfj6ObKm4OfN80xmJzt9bLE6cChxbjvvsHRizDZ5OASTgQ0aWhY3irC53EsFVI1PpUwkhPz4VTSJtRXE8sYK9WI07cCYsBZJws6wZd1pbDcaC3FMMItqp0tzFAAi8yHyyHhj/RtrPciLz5mT+Sln3/2sQ4ZhRdh0QMCW+I1TX+g7PMtBHVWRkVjE95oGZsuMxbOXnWNqkGbVls4mVW4wViTdHriNY7YXoCFlDVcDiun9ju+dE8pp6j96A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lv6nK4okzX9Eb24rzwqQlQtMHnW6zOzECXaBdXmSqh0=; b=PFc0i+CJGkznrX1w9D8cvcBv9r/32GnJ2Ah2nJIGrpZwhOqc8Rw01rBIgZOgU/wAU1q3pdXna4g4kxBDzQ47sn2DEGmWy8K4avMROVzJGdjolgKe4227Zl+InVcFNeketRWdufgrCOE0gjvYO2y67uNzXXnAFesElfewNEZwpoSxnQw873ytD/wbIfox6ZbwNCgCTLot6Pz7ijwE9Gl5gpXFpyt4vjhDpTHxsYgzkiJKEiQq7iCoDk6pqkQ3tV8zYGzXXoVFqGs9PIQ/pjRodw1M+MXYXyBp4nn521N6Onm5iD6X/OxDPiromeXH9OPjPHORpUxjICuEbHpUsgzmoA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2a46c7df-b380-cc41-5582-70b4829d7f47@suse.com> Date: Thu, 4 May 2023 09:50:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v2 1/2] restrict concept of pIRQ to x86 Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk References: <85e59fd5-9a06-48b4-ba7e-81865d44e332@suse.com> <98f51b96-8a1c-7f33-b4d3-1744174df465@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0055.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:93::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9708:EE_ X-MS-Office365-Filtering-Correlation-Id: 99aebccb-6191-4677-00f4-08db4c743b87 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: egBNRetxNH9oziw851GHE3LrKHTaGXHIytcqY4eyoWqQfdJ9JaLwyUvZVLDwqSjUqVai4+lo6W76CoBgVD5TgqqLsF2fi3HTgGZSG9sAtJsuf9bArgu3KL506f8ytUWoWuEdzPIG+mfRjXkZ0b5KxSVOjP5efg77GWPgOfMKFA/PFX25DVA3hHPknUucCMYlaPAA7/uWPQx+71uSFgnD9DR8OkfPcx9pxQ9nQmBz80Atdl7RYyDvjVqTOUdg+vCuczbYc1uBsoyIKWpbzg+VoRwrTM/Q5nV+Bqew0YXGHOTbmagWB5E6Zncpqo5MDhyc2ijNwK308X3eL5hwZHnNADRAMuIQC3MjpBDJ7Y5UsW2MNIT6YBv+lOfHOr/BdkM0niOwHzkn3wmOz02+iU4jf6OpvnhRdg6wRWJQiqv2lhIgacDqzl5vpSKtkJz2QzdQHo9fGo5nS4xIC3/BYwOIk3W58vyOfRmdQ4p6XrV2B7e6gyGCCVPRZ/oWyb56cnGqqrg+Utity8HkB6RrKZRY2mnuCNVW9rndgH7jgiI71M+4lJ0hnEG3Sse48dOvX4WceqPeQQj0qjNTGir4/G+NfVTky68ZH9j7rfUX/XJPYKEdyU50V2nz7oMImq5Zojvd2GuXU2Qflg+1QiH1tQTYlw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(136003)(376002)(366004)(39860400002)(346002)(451199021)(5660300002)(2906002)(31686004)(2616005)(6512007)(6506007)(53546011)(26005)(41300700001)(83380400001)(38100700002)(8676002)(8936002)(316002)(66556008)(66946007)(66476007)(4326008)(36756003)(86362001)(31696002)(54906003)(186003)(478600001)(6666004)(6486002)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VXBvNzZCcFRYR0hyYVRHV3Q5SEZHWGxvTEtEaVF2MFVzamdCVmd6OS9pV01K?= =?utf-8?B?MFRBOWZWa3FBdldGNXhZSjJ3czE3bWlSM282VWQ5TFFlRWRTQ2E0WklqcmVo?= =?utf-8?B?VFVrWGVTL3UrcUEyRXMvZWpWUzFqa3J6VHU2bVdVdWVOa2NRVnZLQTlmSmVo?= =?utf-8?B?VW1zUDlqaUs0TXJaajh2aG5WSW0xMnhMR1BRMWNIZXF6enhJL0RadmZNL2lV?= =?utf-8?B?cGVJa3JKZkEzLy9ZTDN2SU5yVENXN2xENEdiMDRCU3hUMms2TjdqcWcvN3dT?= =?utf-8?B?NCszdm9BeWNlZnlwSXpHRW9MWXordDV1dllTc3FKQ0p4WnhFbHRMRUdabTZu?= =?utf-8?B?ZWRkK1Z2OGxQQ0JaOWdPUXk2SFBYeFg1T0ZSSTNlT1JiZzE1UzZzTWNzR1kv?= =?utf-8?B?N0xqWlRqQnEzQlJaT3hJY1FiNlNPU016bTM4ajdCSDBUOWY4MXlBN2tPQ25j?= =?utf-8?B?Tmc2VXVPRlZqTDJ5RnVzci8wUnZpRkdSZVZHazYrM2VDak82MUhaQzFONkxC?= =?utf-8?B?NnE3a2dhb2JjOTkzRmd4L25WTlNiZFZSNkowOWZCeGxEZGkyOGVYeU9BVHNG?= =?utf-8?B?RklTTGgycGtoUWNla3F1RkpRMjl1UDNlU1ByZE1yQ3ZBRGM1cTF5Yjc4djZ1?= =?utf-8?B?S1l6MVFwdEp1aFRvVlM1WkJ2RUlIWEpHTVl2dzVCL0EwV3YvazlENmpkR1VL?= =?utf-8?B?M2ViTkJma0pNdkZ2Nm1nOGo5M2FhYTU5RS9qWERiU3pINEtaLzB6Y0FweUdU?= =?utf-8?B?YmxUK3JBZ2QzczhRRVo4QVhaRjdGR0VPUk95V1FId1VGeENiTkJiK2tIN2M0?= =?utf-8?B?RnBmUnFWeXVCL2V3R3pkTGYzb3NwWFZmTjRJM0c1SXArd0M5akdQcDA1d2FS?= =?utf-8?B?OG9ObE1lMHNhU2locmdMUHFHcG5KRExaVVkyeTFpbVdyY0xiWFZJVWJUYjg5?= =?utf-8?B?cjd4Q25lYnRacXdTZ1J0WDlXMHlkcUxkbCt0Njg1V1IxLzEzVWs0SU9LSEtx?= =?utf-8?B?YU82OUlEUGFrQVM4RGVCV3FlZ1lOMzlUMS9NelpMRUZIdXZmWlJ5QUkyMlZh?= =?utf-8?B?M1JwMHBtWCtRajlEd1pIQXNrVWtlcTVSMmhQb01ZcFJLWHJSWEFyQzAxS2xD?= =?utf-8?B?OEZwRXFVRXNNWWczbWZwcGxPNit3R1o1dG9NQmw5djRGaGtDb1hrdGV6TGE2?= =?utf-8?B?THZXQ2hKQXZ0TjgzRnk1TkRxdjlSSmg0K1Vpa3pVREx1ZytvZ0NNTi9HcjlD?= =?utf-8?B?UmJpaFBmOUVPZWFsbHRwYW8yeGlEZHJxSXZoU3ltaUxyTlRsblVxRm9jMmZP?= =?utf-8?B?Mk5ycjNaK2U5M2ZpK2ZWdVBQWll0M09HS1Q3aDFRakh0aXVNYnJ4Nm83UXEw?= =?utf-8?B?eHVLQkZQYnJXMjJHVUdZcGNaeC9jRzFtZVZOT1Zzby85djM0eDdRNDJJQzh5?= =?utf-8?B?cHZzSTdvQ04reU1YY2dWRXdobjRnWGY1WWZneGF2bkFRU0dldFI0YVErTy9F?= =?utf-8?B?UVRZeGd6czlHam5xdjBvTkE1RitrTzlzcGhleVJPaUR0UjVVYzhpY0x4UVZC?= =?utf-8?B?ZCtXSGNpRGRmVWxMeEhHMXYvaDZyaDAxWVZuS2d6bXJXMHU5bGdicStFZ28z?= =?utf-8?B?Mkh2OTNyb3VweTlYZVB5QThyM05kTnhReHIzVjhyV3FsSHpvc0VkWWI1QlVi?= =?utf-8?B?Y0ZSVDAvTTNYSjdibG9yZXpnQitKamttaGJoZnhsb3RIVEdITld4Mjc5SjI5?= =?utf-8?B?OS8wZjRBSWowckpnai93eVhVMTUrb1BtRytSRmJZM3g1Ynd1S1E1aVM1WEZJ?= =?utf-8?B?Zy82M1h1TjBLdVA4WFhBK0dkOExnLzZqQnR1Um1kajlKNjNGczRRSVZTUUQ3?= =?utf-8?B?K1BGUk0yNTZjMzg4aHdicWYvK0Fid3ZIRld3K0JnT2tYeGtzVHF1Und3UE0y?= =?utf-8?B?K1JqZE5Bajcxd0xUV1Q3MFRUS25YZEFqZHBoK0VEZnVzSGNzREx5OEJjUEFu?= =?utf-8?B?QmsrMW13M0Y3YTlsR0pDUnlrMlM2bzdZd1FnZkdlMVJoNEU3OXQ4dmU2Wmx2?= =?utf-8?B?OG5xbHJrc0l1WkJpakpsY0pXSXhIei9mYUVPcWdRNjFwRmpodlpCVExoR2pq?= =?utf-8?Q?2DJkFr7GARF2a5H9wZI45YX9d?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 99aebccb-6191-4677-00f4-08db4c743b87 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 07:50:30.3616 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Xwm4pV/z8hQ2Tit/87I8FkCn20OZ0OCNW4SbAg+34leMZuw12P9b0rcnu4QOYac0enm9RLI8vqIcPxfaNP11Jw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9708 On 04.05.2023 09:44, Roger Pau Monné wrote: > On Wed, May 03, 2023 at 05:33:05PM +0200, Jan Beulich wrote: >> --- a/xen/include/xen/sched.h >> +++ b/xen/include/xen/sched.h >> @@ -438,12 +438,14 @@ struct domain >> >> struct grant_table *grant_table; >> >> +#ifdef CONFIG_HAS_PIRQ >> /* >> * Interrupt to event-channel mappings and other per-guest-pirq data. >> * Protected by the domain's event-channel spinlock. >> */ >> struct radix_tree_root pirq_tree; >> unsigned int nr_pirqs; >> +#endif > > Won't it be cleaner to just move this into arch_domain and avoid a > bunch of the ifdefary? As the initialization of the fields would be > moved to arch_domain_create() also. That's hard to decide without knowing what e.g. RISC-V is going to want. Taking (past) IA-64 into consideration - that would likely have wanted to select this new HAS_PIRQ, and hence keeping these pieces where they are imo makes sense. I did actually consider that alternative, albeit just briefly. If that ... > Maybe we would want to introduce some kind of arch-specific event > channel handler so that the bind PIRQ hypercall could be handled > there? ... and hence this was the route to take, I suppose I would simply drop this patch and revert the 2nd one to what it was before (merely addressing the review comment on Arm's arch_hwdom_irqs()). That's simply more intrusive a change than I'm willing to make right here. Jan From xen-devel-bounces@lists.xenproject.org Thu May 04 08:08:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 08:08:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529604.824154 (Exim 4.92) (envelope-from ) id 1puU0I-0007lu-OS; Thu, 04 May 2023 08:07:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529604.824154; Thu, 04 May 2023 08:07:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puU0I-0007ln-LT; Thu, 04 May 2023 08:07:54 +0000 Received: by outflank-mailman (input) for mailman id 529604; Thu, 04 May 2023 08:07:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puU0H-0007ld-9X; Thu, 04 May 2023 08:07:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puU0G-0007yx-W7; Thu, 04 May 2023 08:07:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puU0G-0001It-EE; Thu, 04 May 2023 08:07:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1puU0G-0006JM-De; Thu, 04 May 2023 08:07:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=sBWiGdTjO6+aD21Q2L1qj43QH/HzVELulFslG71XckQ=; b=6qTldF87GIH4LXRvQTRJxUnz5S r6Rn5PGSqZuP3E6fbv6yIncIAk7hT/QRQMcymiyvd3a6Q83VVJhlM1NY5COAkRFBqfmUTfB7WvTx/ kfmHfKdgAJ3IvMZ4yYmAXb/1yVnj1+hiafKOi7PhwS6vN06tvwcoCC4lidBa+o+li9zs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180519: regressions - FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=0956aa2219745a198bb6a0a99e2108a3c09b280e X-Osstest-Versions-That: xen=b033eddc9779109c06a26936321d27a2ef4e088b From: osstest service owner Date: Thu, 04 May 2023 08:07:52 +0000 flight 180519 xen-unstable real [real] flight 180526 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180519/ http://logs.test-lab.xenproject.org/osstest/logs/180526/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 180511 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180511 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180511 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180511 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180511 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180511 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180511 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 180511 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 180511 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180511 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 180511 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180511 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180511 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: xen 0956aa2219745a198bb6a0a99e2108a3c09b280e baseline version: xen b033eddc9779109c06a26936321d27a2ef4e088b Last test of basis 180511 2023-05-03 01:53:22 Z 1 days Testing same since 180519 2023-05-03 15:38:32 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Henry Wang # CHANGELOG Jan Beulich Roger Pau Monné Viresh Kumar jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 0956aa2219745a198bb6a0a99e2108a3c09b280e Author: Jan Beulich Date: Wed May 3 13:38:30 2023 +0200 x86/mm: replace bogus assertion in paging_log_dirty_op() While I was the one to introduce it, I don't think it is correct: A bogus continuation call issued by a tool stack domain may find another continuation in progress. IOW we've been asserting caller controlled state (which is reachable only via a domctl), and the early (lock-less) check in paging_domctl() helps in a limited way only. Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné commit eaa324bfebcf17333d993b74024901701e0e2162 Author: Roger Pau Monné Date: Wed May 3 13:37:19 2023 +0200 x86/trampoline: load the GDT located in the trampoline page When booting the BSP the portion of the code executed from the trampoline page will be using the GDT located in the hypervisor .text.head section rather than the GDT located in the relocated trampoline page. If skip_realmode is not set the GDT located in the trampoline page will be loaded after having executed the BIOS call, otherwise the GDT from .text.head will be used for all the protected mode trampoline code execution. Note that both gdt_boot_descr and gdt_48 contain the same entries, but the former is located inside the hypervisor .text section, while the later lives in the relocated trampoline page. This is not harmful as-is, as both GDTs contain the same entries, but for consistency with the APs switch the BSP trampoline code to also use the GDT on the relocated trampoline page. Signed-off-by: Roger Pau Monné Reviewed-by: Andrew Cooper commit 0946068e7faea22868c577d7afa54ba4970ff520 Author: Roger Pau Monné Date: Wed May 3 13:36:25 2023 +0200 x86/head: check base address alignment Ensure that the base address is 2M aligned, or else the page table entries created would be corrupt as reserved bits on the PDE end up set. We have encountered a broken firmware where grub2 would end up loading Xen at a non 2M aligned region when using the multiboot2 protocol, and that caused a very difficult to debug triple fault. If the alignment is not as required by the page tables print an error message and stop the boot. Also add a build time check that the calculation of symbol offsets don't break alignment of passed addresses. The check could be performed earlier, but so far the alignment is required by the page tables, and hence feels more natural that the check lives near to the piece of code that requires it. Note that when booted as an EFI application from the PE entry point the alignment check is already performed by efi_arch_load_addr_check(), and hence there's no need to add another check at the point where page tables get built in efi_arch_memory_setup(). Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich commit 19c6cbd90965b1440bd551069373d6fa3f2f365d Author: Roger Pau Monné Date: Wed May 3 13:36:05 2023 +0200 xen/vcpu: ignore VCPU_SSHOTTMR_future The usage of VCPU_SSHOTTMR_future in Linux prior to 4.7 is bogus. When the hypervisor returns -ETIME (timeout in the past) Linux keeps retrying to setup the timer with a higher timeout instead of self-injecting a timer interrupt. On boxes without any hardware assistance for logdirty we have seen HVM Linux guests < 4.7 with 32vCPUs give up trying to setup the timer when logdirty is enabled: CE: Reprogramming failure. Giving up CE: xen increased min_delta_ns to 1000000 nsec CE: Reprogramming failure. Giving up CE: Reprogramming failure. Giving up CE: xen increased min_delta_ns to 506250 nsec CE: xen increased min_delta_ns to 759375 nsec CE: xen increased min_delta_ns to 1000000 nsec CE: Reprogramming failure. Giving up CE: Reprogramming failure. Giving up CE: Reprogramming failure. Giving up Freezing user space processes ... INFO: rcu_sched detected stalls on CPUs/tasks: { 14} (detected by 10, t=60002 jiffies, g=4006, c=4005, q=14130) Task dump for CPU 14: swapper/14 R running task 0 0 1 0x00000000 Call Trace: [] ? rcu_eqs_enter_common.isra.30+0x3d/0xf0 [] ? default_idle+0x1e/0xd0 [] ? arch_cpu_idle+0x20/0xc0 [] ? cpu_startup_entry+0x14a/0x1e0 [] ? start_secondary+0x1f7/0x270 [] ? start_cpu+0x5/0x14 INFO: rcu_sched detected stalls on CPUs/tasks: { 26} (detected by 24, t=60002 jiffies, g=6922, c=6921, q=7013) Task dump for CPU 26: swapper/26 R running task 0 0 1 0x00000000 Call Trace: [] ? rcu_eqs_enter_common.isra.30+0x3d/0xf0 [] ? default_idle+0x1e/0xd0 [] ? arch_cpu_idle+0x20/0xc0 [] ? cpu_startup_entry+0x14a/0x1e0 [] ? start_secondary+0x1f7/0x270 [] ? start_cpu+0x5/0x14 INFO: rcu_sched detected stalls on CPUs/tasks: { 26} (detected by 24, t=60002 jiffies, g=8499, c=8498, q=7664) Task dump for CPU 26: swapper/26 R running task 0 0 1 0x00000000 Call Trace: [] ? rcu_eqs_enter_common.isra.30+0x3d/0xf0 [] ? default_idle+0x1e/0xd0 [] ? arch_cpu_idle+0x20/0xc0 [] ? cpu_startup_entry+0x14a/0x1e0 [] ? start_secondary+0x1f7/0x270 [] ? start_cpu+0x5/0x14 Thus leading to CPU stalls and a broken system as a result. Workaround this bogus usage by ignoring the VCPU_SSHOTTMR_future in the hypervisor. Old Linux versions are the only ones known to have (wrongly) attempted to use the flag, and ignoring it is compatible with the behavior expected by any guests setting that flag. Note the usage of the flag has been removed from Linux by commit: c06b6d70feb3 xen/x86: don't lose event interrupts Which landed in Linux 4.7. Signed-off-by: Roger Pau Monné Acked-by: Henry Wang # CHANGELOG Acked-by: Jan Beulich commit f8135d234a90777b4b6606a241605fb75f239530 Author: Viresh Kumar Date: Wed May 3 13:35:40 2023 +0200 docs: allow generic virtio device types to contain device-id For generic virtio devices, where we don't need to add compatible or other special DT properties, the type field is set to "virtio,device". But this misses the case where the user sets the type with a valid virtio device id as well, like "virtio,device1a" for file system device. The complete list of virtio device ids is mentioned here: https://docs.oasis-open.org/virtio/virtio/v1.2/cs01/virtio-v1.2-cs01.html#x1-2160005 Update documentation to support that as well. Fixes: dd54ea500be8 ("docs: add documentation for generic virtio devices") Signed-off-by: Viresh Kumar Reviewed-by: Oleksandr Tyshchenko (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Thu May 04 08:08:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 08:08:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529612.824164 (Exim 4.92) (envelope-from ) id 1puU14-0008Ke-7T; Thu, 04 May 2023 08:08:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529612.824164; Thu, 04 May 2023 08:08:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puU14-0008KX-4N; Thu, 04 May 2023 08:08:42 +0000 Received: by outflank-mailman (input) for mailman id 529612; Thu, 04 May 2023 08:08:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puU12-00089f-OY for xen-devel@lists.xenproject.org; Thu, 04 May 2023 08:08:40 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dee8e1d8-ea52-11ed-8611-37d641c3527e; Thu, 04 May 2023 10:08:38 +0200 (CEST) Received: from mail-dm6nam12lp2169.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 May 2023 04:08:12 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CO3PR03MB6805.namprd03.prod.outlook.com (2603:10b6:303:164::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Thu, 4 May 2023 08:08:10 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb%4]) with mapi id 15.20.6340.031; Thu, 4 May 2023 08:08:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dee8e1d8-ea52-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683187718; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=rURzpHR8WrEvYtHltPsT9tGpCzCxO67WbyXQ7TTmH/I=; b=dkcprs1wlcHkl5+zAkccE6tG2TxoQtS893+rSDwpRn+xqVueZArtC4LJ AVdOl/oN7J9QgdEFD0aChsm+Docn9fnr4WQQEEKIavlKMAcQaUqpTdPsX K4/5oQM9PCxwcoU7uMNeiw12930BDx+/EAvY/B/o2h6b4m2zvbfapoNmX g=; X-IronPort-RemoteIP: 104.47.59.169 X-IronPort-MID: 106583845 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:iWvoxahs3JR9dEywYrlVDbYuX161TBEKZh0ujC45NGQN5FlHY01je htvCG2Oa/qJNmT3fNB2b9u28UhU7ZGGzoJgT1Q6rywxHygb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWj0N8klgZmP6sT4QeCzyB94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQ2Iwkmainbjtvonquwc9J2quIMLpP0adZ3VnFIlVk1DN4AaLWaGeDmwIEd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEgluGzYbI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6TeXmq64x0AHOroAVID4mSH264tq5sHWZXO8DB hQv9HY2jKdnoSRHSfG4BXVUukWsvBQRRt5RGO0S8xyWx+zf5APxLncAZi5MbpohrsBebSwn0 BqFks3kARRrsaaJUjSN+7GMtzSwNCMJa2gYakc5oRAt5tDipMQ/i0zJR9M6Sqqt1ISrSHf33 iyAqzU4i/MLl8kX2q6n/FfBxTWxupzOSQ1z7QLSNo640j5EiEeeT9TAwTDmATxodd3xooWp1 JTcp/Wj0Q== IronPort-HdrOrdr: A9a23:44NbyapnSXnsq8nXJj8sLCgaV5s2LNV00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssREb9uxo9pPwOE80hqQFhrX5Wo3SITUO2VHYVr2KiLGP/9SOIVycygcw79 YET0E6MqyKMbEYt7eF3ODbKbYdKbC8mcjH5Ns2jU0dNT2CA5sQkDuRYTzrdnGeKjM2Y6bRWK DshPau8FGbCAgqh4mAdzE4t6+pnay4qLvWJTo9QzI34giHij2lrJb8Dhijxx8bFx9f3Ls49m DBsgrhooGuqeuyxBPw33Laq80+oqqs9vJzQOi3zuQFIDTljQilIKxnRr25pTgw5M2/9Vowl9 HIghE4e+B+8WnYcG2ZqQbknyPgzDEtwXn/zkLwuwqvneXJABYBT+ZRj4NQdRXUr2ImodFHya pOm0aUrYBeAx/slDn0o4GgbWAhqmOE5V4Z1cIDhX1WVoUTLJdXsIwk5UtQVLMNBjjz5owLGP RnSOvc+PFVW1WHaG2xhBgl/PWcGlAIWjuWSEkLvcKYlxBQgXBC1kMdgPcSm38RnahNPKVs1q DhCOBFhbtORsgZYeZWH+EaW/a6DWTLXFblLH+SCU6PLtBGB1v977rMpJkl7uCjf5IFiLEono 7abV9evWkuP2rzFMy12oFR+BylehT9Yd3U8LAd23FFgMy4eFKyWhfzDGzG0vHQ7cn3O/erGM paY/ltcrjexWiHI/c84+SxYegVFZAkarxnhj8KYSP+niv1EPybigX6SoekGFO/K0dsZkrPRl 0+YRPUGOJsqmiWZ16QummlZ5qqQD2xwa5N X-Talos-CUID: =?us-ascii?q?9a23=3AVwvQmmlrrHok/5QRTwVsXCHrOhLXOVPW9VzUGhe?= =?us-ascii?q?xMDg3UbasckW83oxmydU7zg=3D=3D?= X-Talos-MUID: 9a23:nOAn3QZzYNqxauBTlA/xojAhF8dS2IOpNRwgya4I59GlOnkl X-IronPort-AV: E=Sophos;i="5.99,249,1677560400"; d="scan'208";a="106583845" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JSbaFnCo4eB8wC2GxG2Y4dgZC92A//05vtURnHtT/IzfUkh/pdXAGDH+zfonUWoOXZ5t0zrWLy3cpBkvS5OOzWg3BTPZrOjsyOr8FxMw2OgkpueQ0mnJfXCVcN1H9rv6bYmzMa4qpSr+Pxdu1jpIwCbRyMowz6iqa0EfIPVqBIX1/LONp/kgkNH0YDihMDbIZTcz6RKAwdtdPPO030XdnC9hQI4DoG3Ubfjw0BtYJX8tz77yzB90Hs04OhWBuYkbBCovHsiUPzhfDUYVzyl6EdnCIzyTLse7JjDdefcirBj66tO2lj42YHP892KbEkS4m3OS85hmNC4rRZsx/1bZDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gaFTPGTvNngWNE43MLLjvuWMkEaKHJDKYxMeBcTAGUE=; b=KQg+1fvi2IEFdD46jXEU+U+VHgL0UuANa5FDI8243gdHhiyiWzgQgdDZJiYodh9P2fAubZlPlZU1xICKq/76pnQegVarwl5u7bUa10Uhz7whS6gXeOWN0erfLjbHLfEQcHP4Rff86quJKbdlQOQe+UgYvg8DhR6rg/yO9jwIClS6Dyg5Y+IVhEiNu3H/+zjTHHz+ifHal+Il7q8BKfWcegS90eX/gjqPjOANoZmWv1lzIxYM31522HmeCFB3ByMZhZnyodBtbctn33mfz/zDK1lZ9DhkG9JyVB82QcPesjTGasIjbeLQZkA2XPhG7q4pwI6nLSPAonR4fYguBzv4+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gaFTPGTvNngWNE43MLLjvuWMkEaKHJDKYxMeBcTAGUE=; b=UPTZDqA2/9DDsXPNxAxYGdPsjN+85zRQn0bncABEd/RI5/byw2H+Gc+DfEfWQN6ejD8DNkgrjVOgJ+uOTRGTMbCf5SrXCJCKqGXehXzxgC21SQi/Xj+Va1RMApUR5L+g7t5cv54SVteJt1pUCixDZ7hgv4KssKb0pfcjVbHoD1k= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Thu, 4 May 2023 09:08:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: Andrew Cooper Subject: Re: [PATCH] x86/ucode: Refresh raw CPU policy after microcode load Content-Language: en-GB To: Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230503185813.3050382-1-andrew.cooper3@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0068.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:60::32) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|CO3PR03MB6805:EE_ X-MS-Office365-Filtering-Correlation-Id: 5f82236e-b346-46ef-69ac-08db4c76b25a X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: q07bJRdyBQ2vcFGBGSoR7HmmV/kKQqQomfJYD9cwKwBOKQEsmp+81FdLOFHivwtW8gdcY33mVPBjLccb2dDtMjsFdTiRzxDNcyNFsrlRMO7dYi9WxSQQCghsidex4No0QYalSGQuh5/PTyCPno3XfjOO785b6+taLWPtfgNAIfavDoj/4WNrA42V4BHFZcEVrtY3Agm9KNa6YZH/liTLC6BcbhLHc5hBw2agnK/umaWyNDpm2FGh/mFFxwUQMiaFp2qlDh6juJzKbufV0LKSmeULvDTL4o6JmbTddneH9HXrZGJm/nw3WfiDsMAJ1aRc+nIHPNT5S0xuYNm2FxRMxAhTR0xNRq7AgeQ9iP3CRFZB52luJFi5NOPnit1GnZ3o2FNuIDZKC20zH7Yha2WvSXOIk67Qll0w6RbYaBbGz9/VczMQoNYa0VIIVud9cd7Uj0CEH9O4EYTT64LKRCaIb79eav8EdmhCpWOWN+4il39z54iPgNkiusgdJ8fw2KzL8C17sI3mZ7zNUv4jgOiOIf0WVY0D1XSdw2bfnfz3aS7a7+mRsxm0f0evprqFFNE2AleJclokAAtXDHCoTEldJ3b1AofCP+kP0HTHGMVX7KlihZ7PTM31C5WTn/yQ//IFuMCqYhNU5ElYHg/nqMbXFg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(366004)(39860400002)(136003)(376002)(396003)(451199021)(66899021)(31686004)(36756003)(38100700002)(2906002)(8676002)(8936002)(86362001)(82960400001)(31696002)(316002)(5660300002)(66556008)(66946007)(41300700001)(4326008)(66476007)(6916009)(83380400001)(6512007)(186003)(53546011)(26005)(6486002)(6506007)(54906003)(478600001)(2616005)(6666004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MGNLcXRGMEYwMkVBczk5bFRrcGg2TWF3c0ZETTM2UmlKcFRmSU9uTjJLbFJp?= =?utf-8?B?Tlo5c3p0Y1Z6dk9INHVDeERXMHpYRFhhY3RsNG0rbXVhbmFOTFpUZWpOZWJS?= =?utf-8?B?VHhLRk1Kdmh1SFhNSk9TWEVNKzViUEFZZFM5SkkwQVFjRW93bUY4ZlNqeHJu?= =?utf-8?B?YVVhWC9FRFdEUHY1SEZZNjFvTTVpQUhHNk9TdDR1STBZakgzdkU3eHFoVU5E?= =?utf-8?B?bXdFdnNHZm5sMlhacEpJNFFmVDJXZkt3VXFjeVhLSzlGbmdEQkJJS0lWejNW?= =?utf-8?B?Q0RYSnZCc1RsWU5FSXh2cVVFcGZHL0NvM21ZSmZtMWVVTUxGUGxXcVNkNXBp?= =?utf-8?B?N2t0bUUxM3ZCZjIvZm9IWlZCVjMrQWFldVFMWkhNR0ZZdUhNUWJnb1dVTGtw?= =?utf-8?B?UDZlUXBIOEpGTHhZSjZCeU1NT0l6UGg0NVN5YmZTdUhFNVVMa0V5c0VVNU1y?= =?utf-8?B?OEErbHRXUHRsbVB2SXBjWWRkR1lwQmFmR1NVYWQzTkdDOUw4Sndpd21lTlZF?= =?utf-8?B?RUE0U1QvQXBmditXSVo4TVNXQU5NVldFMVFEZ3VDY3RQTGgyd0cvYmJKYW1v?= =?utf-8?B?YlhZeDZDcmhlZjVmYS9YK095TzZVNU5uT0ZyUVpUZ0QzaXZaRjM1T2Vic083?= =?utf-8?B?SmFTMlRNZUdyNjhJRjNmMEYrZlkvclpnQlFqaTZIbzUxa2JHWUI4OGVYTmtm?= =?utf-8?B?MzFhaGNOVS94WjJTMkYzKzZHeTRScEVkKzZGK1hCeWJXVVRzVXFYZEZ0TkVQ?= =?utf-8?B?cmhrUXU5UGdoYUpNa3luVHdnRnBqelVpZjA4Y1RIZ3R0Q1RXSUNnS0hYQ216?= =?utf-8?B?UElocFFTK21oUmdkSFNIU0VwWGlNOWUzejVZTVVQSGl2VkxOU0UyalgzL0lI?= =?utf-8?B?WFA2OTgvb3RiTU4rZnVlSlBqdmlxeGZhNFUxZE1zRUkvR2pKNGFTL3dvV3FC?= =?utf-8?B?Z1hKcGJlaGgzMUY2eGRsdWE2bUZiZEVVdnI2eVBXZEIvMEdlVFRqYjlMU0F5?= =?utf-8?B?Qk05VS9QM2Y1RmduYTJ6STVtMmMvSFk1WVpGb0VjSHA2T1RwMUR0cVMzdWlH?= =?utf-8?B?WTRmeXNVN1RNOFQ5TDhHeVYxMUlaUnY0MVJ3cHN1SFZ2QU1YNXNEV05JNnR0?= =?utf-8?B?K2pBWldyN0NHRW1RUjN4a1NhR254Z2RSUzVMK253U1pZWFhiNWoydFNEZ2E4?= =?utf-8?B?ZWtaUEhTeFNjU0hRWlQrYWw2T0s4RTU0Zi9kTEFEUUNqK2pBUC9pMFptWFZi?= =?utf-8?B?TXk0dGR1RWtHWC9CaEJxZG9HS1dyMk1lLzMzRlJJR2dZdC83aENLaFR6RDhQ?= =?utf-8?B?SWpERmVEM0V5bE9RQ2RaemZuSndqYXZoOUlJazVEb2xCcnYvUnM2YUNzQWd0?= =?utf-8?B?K09xNEZ6QUprTkFqVFRvUlF2RDV1Mjhuci9VWm90OWxrTkhYcHVrRjRGeHRC?= =?utf-8?B?ek9xU0QyZHRZVElDdmdqN2N4VThBdGgrSTlMRDdoQ2w0SHFUSlFpRjc0K1BC?= =?utf-8?B?OFR2NmdVYnJ1bTBIampjRkcrQWJRb2FsYWxVWVEzUXdyNEtGekxTU1o3NXJH?= =?utf-8?B?S3BNRmhZdER3ZElXczRRdlp1OU9zVDA4djloN1hCaTREMzNGYUFMVk5LWmx3?= =?utf-8?B?NFJtVUtNcmMyaTZtNFRndlBZUmFqSHkvcWdJQWFzOVJBYUluVXJrVmd6WEZV?= =?utf-8?B?Zlo2VTNBc05WWCt5czRITXorNENpcUswWG1VYjBaOXNRRjk5UzNuMk1RWTdY?= =?utf-8?B?N0N5QXNjSzZMUlFDczAwcXY3bXd5dmFiUEJKaEVPMkNhNzFRZVFpTk9tWXVN?= =?utf-8?B?cHVGeTRSa2xHWXBvNXNtVlhEVExlVGxjd1J6anJYSnRUSFMwd0lSUmtqZkdZ?= =?utf-8?B?czFTY0piV1ljQjlJd3E3Mk5zSTFIS3F2bjFUdld4ZDkvWXNoZ0YrN3dDZTUy?= =?utf-8?B?cGVLN0V3dzlkZ1RVdSt4c0p6bWVoRGN5ZWY5MHhienZYWVc5YnluZzRvVFBu?= =?utf-8?B?YkNSTzN4S2dZMGVjUEpIMGNSVlNMbnBIcVNKL0g5TWhnY2NQeEtOVzB1ZC83?= =?utf-8?B?ZnFOdFJqTUhxU0V1RUxhQTlmVHo5czRsOVFIY1crdnZvWmt6RDZnQlJOUzNI?= =?utf-8?B?ZHRGTThTenFjcGI4T0NmU1RObzZhMFh2RVVZZFQzVzZKOWFSZFpMUXJEVHBq?= =?utf-8?B?clE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: gSx6qIXQNOA+yIk4oxeWKq6jKTWGO2BAelG6Ghvzmh8nPodMJIryIuaEV+573TdV9piOoZuE4jC9ckoBdhOuT/wF9H2y8l3gk2h9D6k18cx7k92Mjf9z7mWjsmYfetCIbvmSo4otUEgErEpjK0tUR7klbEXbJiyEPMiv2N3sOTYpakEqOi1vtzDJ8FhlQqavcLxehFTBJ6Tj9Z+szCZY6aexS3upfBgfOlQBdioMk3FwBq/nc1mGXl3MMGfkJ+DIh67wttbgAvenZQfoTKPrDfKYJRQsgvdfgCugXInr6KCXbXfuZzI2m3+obyQx5BfBJ4cgfOsUx7Ce78JbLS4mAkkpTGp5Vg64tiUCyrFK4q1xyIhGBjuiEJj/9LIGqjoFsVcDruD2ZiTL+NBCE5r/1+gbvn6XR09TF+De8azbKJ/9w+DgMk7OUeLvRBKUi8TsinsxwxK0pWsfiMUvSIfdNchxCmyi7Tg4X3GwBxSKe6LUlx6eNXK9MRdXKuU2k8bV9j7yWkYMGSS3eyO+IBht41uAYiLIqJYtRIRqAdoNRvFInz+ESZmARiOUlMcyM9du7z8NjtOaUXr57XQcdJ3nY8QqSwSJhGpIFm3sUDhmXN1MmSVQVkfZfPU+LcrVEoPu7LCr2bjmQ2JmCfPbsIHJQO6by7e8TuMTh/zUs4Nw4V9hDfD1eHHEkWWegrDFrOfcDDr6mRmzfHChZOjNnKA6yyeQ80oeY3csuSLDka2E/4AE1FHiDJSP3MuPiSUnctmHOiIo4cCitPZ3Wk8dfxjUGYLXxdDsLd4xkjpBB7O4B4UndSI1wAFVPxAkyOzn5wdJ X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f82236e-b346-46ef-69ac-08db4c76b25a X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 08:08:08.8822 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9VakSZSl3l3PoCeB5zJTT2r12xwxWDDtQddsZxZFb0rKByuDrtb76PDMtELmLd5IHZJzIMzQJUrJF+KBFI52KXa+PLx571xGGLsW2XwCXx4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR03MB6805 On 04/05/2023 8:08 am, Jan Beulich wrote: > On 03.05.2023 20:58, Andrew Cooper wrote: >> Loading microcode can cause new features to appear. > Or disappear (LWP)? While I don't think we want to panic() in this > case (we do on the S3 resume path when recheck_cpu_features() fails > on the BSP), it would seem to me that we want to go a step further > than you do and at least warn when a feature went amiss. Or is that > too much of a scope-creeping request right here? You're correct that I ought to discuss the disappear case.  But like livepatching, it's firmly in the realm of "the end user takes responsibility for trying this in their test system before running it in production". For LWP specifically, we ought to explicitly permit its disappearance in recheck_cpu_features(), because this specific example is known to exist, and known safe as Xen never used or virtualised LWP functionality.  Crashing on S3 > >> @@ -677,6 +678,9 @@ static long cf_check microcode_update_helper(void *data) >> spin_lock(µcode_mutex); >> microcode_update_cache(patch); >> spin_unlock(µcode_mutex); >> + >> + /* Refresh the raw CPU policy, in case the features have changed. */ >> + calculate_raw_cpu_policy(); > I understand this is in line with what we do during boot, but there > and here I wonder whether this wouldn't better deal with possible > asymmetries (e.g. in case ucode loading failed on one of the CPUs), > along the lines of what we do near the end of identify_cpu() for > APs. (Unlike the question higher up, this is definitely only a > remark here, not something I'd consider dealing with right in this > change.) Asymmetry is an increasingly theoretical problem.  Yeah, it exists in principle, but Xen has no way of letting you explicitly get into that situation. This too falls firmly into the "end user takes responsibility for testing it properly first" category. We have explicit symmetric assumptions/requirements elsewhere (e.g. for a single system, there's 1 correct ucode blob). We can acknowledge that asymmetry exists, but there is basically nothing Xen can do about it other than highlight that something is very wrong on the system.  Odds are that a system which gets into such a state won't survive much longer. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu May 04 08:11:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 08:11:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529615.824173 (Exim 4.92) (envelope-from ) id 1puU3H-0001NC-Kb; Thu, 04 May 2023 08:10:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529615.824173; Thu, 04 May 2023 08:10:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puU3H-0001N3-Ho; Thu, 04 May 2023 08:10:59 +0000 Received: by outflank-mailman (input) for mailman id 529615; Thu, 04 May 2023 08:10:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puU3G-0001Mx-Im for xen-devel@lists.xenproject.org; Thu, 04 May 2023 08:10:58 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20606.outbound.protection.outlook.com [2a01:111:f400:7d00::606]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 32c285a6-ea53-11ed-b226-6b7b168915f2; Thu, 04 May 2023 10:10:57 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB9078.eurprd04.prod.outlook.com (2603:10a6:20b:445::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Thu, 4 May 2023 08:10:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6363.022; Thu, 4 May 2023 08:10:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 32c285a6-ea53-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AFoLyuR9hyHT2W5nm8VTPIDjrmNv4CbA15hI38VL2cUiNV3g5vQJZP9+AZSj3zpGYjQKg6fIFTIvzHKAtTPKwBg3uhTnqDBN04gT4TIAZHD+vKOE4r0aR3SssZ0eXCOf0Pi0cdq/u9ELgXzdJqGkx+CX7zSFjsOyO0OVv+VMsAoo/ybu8FwvHjbMdlDp39aj5KeQTLKihI0VnbNWwekplTl/05y+G65SY67HCsXRIGUc39JlpFUWU/suFBPSD2sZNIvJDuZ5y8SuGRS9ZlVCQD8A0uzrd0kXWJNnF1NvG7YEjI7WjcnO7Qjriln7vdOD9Rmg1lW9oz6xcjw09Xrdlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x8lYMg19hUZpAHP16/2jCnOsXiBiDA/1TpD45NDmil0=; b=UQVeJ8fq9plHWzZyGFLpAjVkLEGYaAxrDlKsUDTg6KQjdalxClqL+Y/zgx6TKG8IpPDYpnjlu2toX2eIgePGKFQO6y+NqmXkorQKBBX7DnAPiqMGVo++Fpua2we7uC2BbXJWsWMT5WY0yt1oj2mgG5iKqqVrjBhtGKvjbA36SpmzQTFgKrMkccjCbmXa1ayzZfKg9SDH8Pgm2Gw617Os1rR1hmotUyW603xkHy7Ogwfqrps/TUE9r/VM6hKnbTOKidcLQb8k3aLmi5tJonmssTL6miAejKG9LGWgY6xp82Vl9yx9WxOo1vDCLcRmHiTc4qA1dwT477LYDCN/L9+sSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x8lYMg19hUZpAHP16/2jCnOsXiBiDA/1TpD45NDmil0=; b=XgMGbX5w8uwjybYzIUXGkIthddMY4OaKqM/iNGjHf6BB4nRE1BAkY6B7pggHhwZ86L1e7/LxHsL9NfsTuU91bnqj78W8XGfz0XJaWyUlPthQ508YXMJUkduit+P6inps2oOBK4iK3SCoJaIIruzlOlOxNbb3PNVhaYt4qcIAo4Oy2AxOJaEHTMdDBdsC1XEGG22Tgf/8k0yQUej3EYSwrhbbw9x6bGqMGQpJIBjGXgGwxIdDn2PrqMh3NbvUQ7snz2YnZ4JAzz3C7p6SUx8HnNHaYw/piRAG01SS3h3KffR3r9FLOHaFa6QBL5CRKEMqe0IpuEXxMqOm+sZOk1a1rA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <01e1cf98-1c36-37f2-18b3-0994e279e5a1@suse.com> Date: Thu, 4 May 2023 10:10:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v6 1/4] xen/riscv: add VM space layout Content-Language: en-US To: Oleksii Kurochko Cc: Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0208.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ad::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB9078:EE_ X-MS-Office365-Filtering-Correlation-Id: 6d66c6f6-02b5-40f3-ab4f-08db4c771527 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o3PgupvEZmLrWJn1DjCzZ3JrmLqZuAXtaapqgd5lAWMbS5D4hsOacsqaJ9Iwfpn7zcS5dqX1taokX/p5nrp7o3M7tq25jQCLU84zUakm2z5mp+kBUchzbcDt5AEwQwTnHFZUQgKoMusmYrw0RUltq9696bXrh1wTsB2ao7Dl9ingA8Ta2dP3NGsKHvCMxOOun9HtoNUsbvA+/ty7iVZaHbQXqCDRoLOTXylm1SSfdF7/cpAbbBEjn5m6sGROTmk2Poi806StiQAPcAqxQ21oIo+ZUgQAbIGoXcgmeBw+hx7VZQOvEhRiLFunbg3s2HH28mpMKqa0oBNACCRq4lM6G6twSXhjR2Lk7k+5UY8L4B0ZeJIUYwPaqm5ygHnSZIhoa137Y3kKun5JcttkOEXEJf9IfwxmsRFuhMn0ZBVii/yewSGIDnad3gCZAeCiqCysLvNgJyBXYLTKrf8SsYIjFU5EARww4bQUhD9a9lIe1+DTl+w2TfBjn6qtoah7HWtxpp8JVT4N0laxBivVom9NxDoCo/g9A8Rn4tIE3GGYrjJFfmt0yFAGzKjUExLbXwOAdCBwGa0z44eV4e88U5L4Tu6cpLtdtmyP0e55HD3DFpMKwvfj99ZtIhuPakUgp+6pYLR9RTG3fy0NbZctVQOhIg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(396003)(346002)(366004)(376002)(39860400002)(451199021)(316002)(41300700001)(2906002)(186003)(53546011)(6512007)(6506007)(26005)(6916009)(31696002)(54906003)(2616005)(86362001)(6486002)(4326008)(83380400001)(66556008)(66476007)(31686004)(66946007)(36756003)(8936002)(8676002)(5660300002)(478600001)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?THF2K2V4MlBuQTdMS0Y4bldiQWlBeTBkYmtDUWVNckZNeEJydHA3eVRRQ05C?= =?utf-8?B?OXliVmpGVWlDNys2RVdWTTdhNHJVbHNjbGt0OVNRakxGNXE4RHVrd2RrbHpn?= =?utf-8?B?VGw4b3l2WEd2eWp4WUdEYVZLRkZCYW9iNDdTdkkyNW1zN0svekFFZ2ppakRG?= =?utf-8?B?cFMrTEMzd2xEUFU4ZURkdXRoVHZuRjdqSlphUkY2T2N6d2JHRnVlamh6d2tZ?= =?utf-8?B?WTZITzFqZHZzM01aWHZhZGFvbDdBdnppK0hOYkU0RHhNS0R4MGlxalFFRXky?= =?utf-8?B?cUNGWEJpQ0drc3BjS2JpK0pQdXBkaklNL0N1OXptdmdRblR6NzZYd1p6SDJs?= =?utf-8?B?VFRSVnRMempGVzRCSjZuYnhHbGxkVTc4eGlOSHlOcUFBQXdROWxGQW9kVUNj?= =?utf-8?B?TVl6d3ZnY200eVZGd0pTb3FQaXcrL2RoV3NVT1N1anozZUY0aVBKNVllY2gx?= =?utf-8?B?eWVRMzExdElBSENqancyYUQ0WmMrS2JuYXhsanEwRmlObk9oNUVwWmxNOHUr?= =?utf-8?B?U3UyeWJEU2J0dk9vd05zWXlhdkZRYVFjMW5ZQVduZDVBcVN0RUtKN3lsd0du?= =?utf-8?B?Y3RnVy9Zc3dnVXhMQ0NXb0RpWTlhTDNaODVwRXYrMy9HVWtRVmRxKy9pY1Fm?= =?utf-8?B?c01qS3pBeDZweWhXQkc3bXkwRzFhTUFhSVBHWjVDWHd0MDR3Z2R2by9uNWty?= =?utf-8?B?S2NTNlVuVHZJejBRclRBSDNKTXVldkErWmNVc2Y2T3A5V09DUVJrMTQyUlNL?= =?utf-8?B?VHl1bVB2bHdTanA0TmQ2WnhiSVRZb2JxVzhmTXVyS01hMW92YzB3cmRPQ3Vh?= =?utf-8?B?U21wWTlwUGlmYWVjbnhTZUZXdkJMQ1IrMXdocG9zWTg1cXFablp0T0NKYkQ0?= =?utf-8?B?cVFqQUh0YlcwTnR0VzNrZnI5Q2o2OFAwcjcxbXU5ak5FSFpDTWdOZUV0bzdL?= =?utf-8?B?NytXdTB5N0ZYUmlyTXArUHJhZ01RN3pUeTVyK2lFRlhybUZDcklreVQ3TmRN?= =?utf-8?B?RWo0SS9WY3A0QjVGUkFHUVhQZmIycEdrc2EvTlBwQ0hZdFI3OENmWjBUVG94?= =?utf-8?B?dGpZd0c5ZDVUTkRaVDJHYWVaazJSNjg3Vk9iVnIyOXczTFFKVzQ4WmQ2c2Mv?= =?utf-8?B?TVg4M2lyVFg1VzJIa3I3NXdldW12MCsveU9CdVg1RkQ5bEx3QjZMWmRWWDk5?= =?utf-8?B?bnNaSzZjdTFuZkZDNHBkTlB5bSsySEpKMGthV0FiRFJJUGVqV3FlQllmbXBG?= =?utf-8?B?QU9lZmlPWmlPOElycHNKeDFzNENxaFh0MGZYZlZ5NDV1V1pPaFRZWlYwZ0VI?= =?utf-8?B?eXV5QUxlQXUyYTJwU1VOOGJ6ZmlIUzEzd0o3L3FMSlA2WE9NTTFBOUUrbjc2?= =?utf-8?B?eE0vTXdxNDgydFFaMEw1eEk5aHlSbS9vcm9zTXFtS1VlRitGSmxiODU1aEx5?= =?utf-8?B?WlExdlRadDBCc2oxZm04RFp5OWF2UHRGam5kbk1hWlEvK1FJTDlrWWpxRWFP?= =?utf-8?B?Nzk1bXBXcS9aOVQydHMvMXc2QkcxcU5aZm94TFhmZUVPL3Y0WWZaUHJyRkRV?= =?utf-8?B?cDhFRCtVSnFhWUxVcVlqZ0NSeStnQ1Rsa1Qrc25aeE96UnR5Nm4yeG9KdDE2?= =?utf-8?B?OVd1MkRYWksrQTRVNkxwY3MwbjVIM01MYUtBTmlQMDVqbzFjSjhJM3VtRjI5?= =?utf-8?B?SnhyQkNQMW0xY04rR1JpVWtLWjB6NlNQN1VMa0RaTTBQaXhoeUEzYjFpMjZW?= =?utf-8?B?Z1pNNk1wZk5wQ0p1S3ZBSldxQVhsQXgyb0RmZmlXR1FhMmpYY2FTRkJKdEhX?= =?utf-8?B?M1RzY2JhRE96a29aZmtsU0N1VDVtdDAvNmNoNHRwOWswUW8rVUFXTlRtZzN3?= =?utf-8?B?ZHJkUm1pV2RXQ2g4ZTltQXlTb0syRmhmTWhkVVBIRXZhNE1VaDhCQmx1MmZR?= =?utf-8?B?cXpiN1VJY3Z4SldTSE1ubnpXM0RVc0cvdVlmNTlBTmUwTnVzdFVtZ2dkblZG?= =?utf-8?B?aVRJTHlneERDZGcyQkFiV0NTV1l0U2ljRFJISjJhYXl4eWNwMUMwNzNFd0Nh?= =?utf-8?B?MWdRdHV6dnd5cDJFVXpsem1zdzVEZmgrVzk2U0g2VXMzRXNwWnkzN1doTmht?= =?utf-8?Q?healedcNF92Xn7dVKP5rXrppr?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6d66c6f6-02b5-40f3-ab4f-08db4c771527 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 08:10:54.4597 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NddVjoidE3TgwVXRAvf1QiWkw3yRPcbdGyNIRMmn8yWHl5i5A4AhIAEvAvdn1vgRXwcmKK09lphUSY7zhyeWkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9078 On 03.05.2023 18:31, Oleksii Kurochko wrote: > --- a/xen/arch/riscv/include/asm/config.h > +++ b/xen/arch/riscv/include/asm/config.h > @@ -4,6 +4,37 @@ > #include > #include > > +/* > + * RISC-V64 Layout: > + * > + * From the riscv-privileged doc: > + * When mapping between narrower and wider addresses, > + * RISC-V zero-extends a narrower physical address to a wider size. > + * The mapping between 64-bit virtual addresses and the 39-bit usable > + * address space of Sv39 is not based on zero-extension but instead > + * follows an entrenched convention that allows an OS to use one or > + * a few of the most-significant bits of a full-size (64-bit) virtual > + * address to quickly distinguish user and supervisor address regions. > + * > + * It means that: > + * top VA bits are simply ignored for the purpose of translating to PA. > + * > + * ============================================================================ > + * Start addr | End addr | Size | Slot |area description > + * ============================================================================ > + * FFFFFFFFC0000000 | FFFFFFFFC0200000 | 2 MB | L2 511 | Xen > + * FFFFFFFFC0200000 | FFFFFFFFC0600000 | 4 MB | L2 511 | FDT > + * FFFFFFFFC0600000 | FFFFFFFFC0800000 | 2 MB | L2 511 | Fixmap > + * ... | 1 GB | L2 510 | Unused > + * 0000003200000000 | 0000007f40000000 | 331 GB | L2 200-609 | Direct map I guess the upper value is 509 here? > + * ... | 1 GB | L2 199 | Unused > + * 0000003100000000 | 0000003140000000 | 3 GB | L2 196-198 | Frametable The two leftmost columns cover 1Gb only. > + * ... | 1 GB | L2 195 | Unused > + * 0000003080000000 | 00000030c0000000 | 1 GB | L2 194 | VMAP > + * .................. unused .................. > + * ============================================================================ > + */ Two more remarks: This map is, aiui, Sv39-specific. The quotation from the doc doesn't really imply that, so I'd suggest to add something to make this explicit. This might be as simple as a suitable #ifdef around or inside the comment (even inside I think it'll be easily understood what it means; see e.g. the CONFIG_BIGMEM conditional in x86'es table). The other oddity here is the sorting of entries: You sort downwards by L2 slot, but upwards within slot 511. Once suitably re-ordered it'll become apparent that there's another "unused" row missing (or perhaps even two). Jan From xen-devel-bounces@lists.xenproject.org Thu May 04 08:13:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 08:13:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529618.824183 (Exim 4.92) (envelope-from ) id 1puU5r-0001xv-23; Thu, 04 May 2023 08:13:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529618.824183; Thu, 04 May 2023 08:13:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puU5q-0001xo-Ve; Thu, 04 May 2023 08:13:38 +0000 Received: by outflank-mailman (input) for mailman id 529618; Thu, 04 May 2023 08:13:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puU5p-0001xe-5u for xen-devel@lists.xenproject.org; Thu, 04 May 2023 08:13:37 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 905933bc-ea53-11ed-b226-6b7b168915f2; Thu, 04 May 2023 10:13:35 +0200 (CEST) Received: from mail-dm3nam02lp2043.outbound.protection.outlook.com (HELO NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.43]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 May 2023 04:13:33 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by DS7PR03MB5511.namprd03.prod.outlook.com (2603:10b6:5:2c5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Thu, 4 May 2023 08:13:30 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec%3]) with mapi id 15.20.6340.031; Thu, 4 May 2023 08:13:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 905933bc-ea53-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683188015; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=qV+TOaaCZDXGVxD1MZbIph6jolX0UTUma1vADEkvVAo=; b=Al5g7VJjN3n0axQMGELbHGIY1BzU4HYnrka5D4/bMSl7/QY5GzxTmrk1 jPl9JrGHbymtOZdxojMh2R5VXXwbWpxXNMdoQ1TF0eTLU8mS9G/3JqjU0 jJjhC5pGS4HAFlcu+lfn6hQ9a5HR8C2a8fP8uQDRUTz2mKoB7rnvoq+Of M=; X-IronPort-RemoteIP: 104.47.56.43 X-IronPort-MID: 108229542 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:XLXcIq/u6JVRGPQz64+fDrUDBX+TJUtcMsCJ2f8bNWPcYEJGY0x3y DdJWmmPa62Mamf8fdx1YIq08UIHupHRnddqTVdsryk8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kI+1BjOkGlA5AdmOKgX5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDkke2 PolcQwiRyrArNy60q2ZdvRUhvg8eZyD0IM34hmMzBn/JNN+G9XvZv6P4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWNilAquFTuGIO9ltiiX8Jak1zev mvb12/4HgsbJJqUzj/tHneE37efx3mqBd5IfFG+3qJDm3mjnlUjMSZMeFyGmtiz02KvcusKf iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwBGAzO/Y7hiUAkAATyVdc5o2uckuXzso2 1SV2dTzClRHsqCRSH+b3qeZq3W1Iyd9BXQZeSYOQA8B4t/iiII+lBTCSpBkCqHdpsLxMSH9x XaNtidWr78el9IR3qO3u1XOmSuxp4PhRxQwoA7QWwqN8AR9Y4K0Yp2y3lLS5/1AMYWxQ0GIu T4PnM320QwVJZSElSjITOBWGrisv6yBKGeE3QUpGIQ9/TOw/XLlZZpX/Dx1OEZuNIADZCPtZ 0jQ/whW4fe/IUeXUEO+WKrpY+xC8EQqPY2Nuiz8BjaWXqVMSQ== IronPort-HdrOrdr: A9a23:DTSA3a5tJEaikQxsXQPXwMbXdLJyesId70hD6qkRc3Bom6mj/P xG88516faZslgssRMb+exoSZPgfZq0z/cci+Qs1NyZLWrbUQWTXeRfxLqn7zr8GzDvss5xvJ 0QF5SW0eeAb2RHsQ== X-Talos-CUID: 9a23:7w8DBm9DxBkE3OmwbdyVvx45HP18TlL09jT7HUOqFkRVVYWVdUDFrQ== X-Talos-MUID: 9a23:U3ddTglXMzWeD6JIh4eAdno+HdxM0/yXOHk2y7gBhvKlP3VcKh6k2WE= X-IronPort-AV: E=Sophos;i="5.99,249,1677560400"; d="scan'208";a="108229542" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kFYl15GBp1EIN8kUSHhn47Ih3N+rdQQfuzFF7M/NC8sAcSWZXIX4736q4CJAwV5pqt8+eZfDudB/78S/pnjMe6h5gz7Ele68X+KZ53I7vUbsy6CNelU6LSiOmJjiOfWnc1kOnQr7FHv03xS4QMSv0GpigjgvTzH5zTVBN1gE3DXvhTx1W8H+eK1bDjgS88kAvcOmvnH5+WzEP7LGoEhobHy+GVNYzOGZaJNeLX3OiHJwyZL9OpZZGkzKrkAEiN9qakcsvJ/dwwS0baLSys0sodhySV8SEJVEbmnDiNa2rvEuvMlP1lTCFW0frHPK7XDlQN/duMc5TvzlVmeglqVqfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UZxLcVB2P6h+bOOzpC2vFL/eewznKkbc0nq8gWRwdeM=; b=b2bcsF/CK9uIoTLvesFEUm53Qoay1BVeIvrIF13wPvG9OQA1UkwGAd0NiwXbcNo6BHCqiF7xw77DlXQB68Ss8Nnl559cajgY02Pganub1RPNoSGbWa+bszW7rKd0iOunTIYrw203Z4rwRBrE6h9T1LkfzHTz0HkNMHgrosHKbmZ2Q/d554bZOldJUUAaXdZQ/QDcqpK2E8KoaJ1qAg9vMmLlFpbX9yS3gsXmXEOqAg4BGAzedP3jqb5g7Wf3kBnwlfo1yGwjh6wmoVQrnq4t48TmZ9VtzQPgONXDjiPrns+vA5vQBlzqP9qfpdpd2BMnWWj3DOkc6xXG2mFTIMk01w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UZxLcVB2P6h+bOOzpC2vFL/eewznKkbc0nq8gWRwdeM=; b=P0yzwMgPXeZ27ynzm5KvP0fg6LS71iBD8+uVZF68jNVbZzNVcDNLTIPXCdz4DikHSCqA4dhHg4s6C2yyrBr8mwVhIS+VTv1QnX680Xe1X8EDRdvx20rtH/XuUOCH/+Z0VfIdmGQwGaeevafiHJBWvP+GhFVyFswHD//dSK9ib5E= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 4 May 2023 10:13:23 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v2 1/2] restrict concept of pIRQ to x86 Message-ID: References: <85e59fd5-9a06-48b4-ba7e-81865d44e332@suse.com> <98f51b96-8a1c-7f33-b4d3-1744174df465@suse.com> <2a46c7df-b380-cc41-5582-70b4829d7f47@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2a46c7df-b380-cc41-5582-70b4829d7f47@suse.com> X-ClientProxiedBy: LO2P265CA0421.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::25) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|DS7PR03MB5511:EE_ X-MS-Office365-Filtering-Correlation-Id: fb9715b0-4cec-4c6e-5614-08db4c7771bd X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6SMcK5RiNVI37CcDdt2pC+XR/yDWLG5zZl8kmIXotKs2RZXbNKAN/L/m2ELjUJBqp5dDyPphOYQzWZzxd7T8rbb8C2MbJ7nUwUONuAHJ98FE8nSaXa99TxhQemeQtAcd/WJja2dxkQnkclhf6nKMUFQ5r0SDKql8VysrDXrkc/wlc86ryxw1TfZ0tX81aCBSBNq5UYEMScxVNLW+k8kuR8wdcPxM3iLbahfIbbJqObti0Joxbf8S6wP9DAAXbd4/kZxetQ+uihK6jrie3zj+mTlMsv4TmLIYZMAXROdclFbFdII+2hy1A3w8cfZRgQtQaFeUNhfilvQ8KM/lfmX1ZAwqACGWEyhAPg2yLcUh9wy+hwFFSy23iZPI6/YB3WPqZ6Zi3fKyvoGgKePH15vjEwM22hH7VIAOf2vp4ZKv6f7CXskPnluu5PnB2MNRjJZL5WdUaSAqlBqBF+DcuDYNmzm8+jL/TRoVfjX3gQMmsaNnN0rFtmA0qu7yE9vLpXDGJx0oyHIn/gLBkDyR2n+Z/MINfUBlxbAkHCY1Gt4oaAM+mdGDDhmfpV5KCRMew1tN X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(7916004)(136003)(376002)(366004)(346002)(396003)(39860400002)(451199021)(66946007)(6916009)(66476007)(4326008)(66556008)(5660300002)(186003)(2906002)(41300700001)(316002)(38100700002)(83380400001)(82960400001)(8676002)(8936002)(85182001)(6512007)(6506007)(9686003)(26005)(54906003)(478600001)(86362001)(53546011)(33716001)(6486002)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmR1QUNsaHB6bzcwMTlYY2Zwa3dDQVBFZytsSEJzcW9pTUFQdm8ycHNLTkJi?= =?utf-8?B?UVMremV6cXpxaEtlZnJMeXJ6RFM4bDA5emZUZUcwQVJIUjBraHBraGdmeThm?= =?utf-8?B?TnpvSStLM1VTeHF2cHg2RE0xOWJjNXN1bVhrcytxc28zMXpja29XMFlmOHZu?= =?utf-8?B?VzdNTjI0dStrVVlEWVZ0VkFIRUhHelY1cnB6QXRyVEI0S3NmbHpBV0JieWd2?= =?utf-8?B?WGRobXBZeWVuSCs3Q0lGWlkvR3ZnQkVaem96VythUFJocUxKd2VvYzFiNzho?= =?utf-8?B?ek90OEQrSWVOdlZJSEJDZmhYanpFOW1lV1pYODNDdFNPc1ozOGdEeEVmUFhz?= =?utf-8?B?aFVpZjZTbkdXSThScW9VMGhiLzRwK293TDNhWktPT09zUTh4d2FmVExxQ2s1?= =?utf-8?B?RytMSVl3eVhJalRVdC9aQjlFK0lHN1B3ZzVPUHVXd3BDM25paVhGRWdIa2Jt?= =?utf-8?B?d1J6d0FYZUpYWkttRnRpWWlGN2d1ZTRiMHpHRUVnRk0yTXhyb2tkWmFsYjQy?= =?utf-8?B?eGYvVzBPSmpodDYrcnBsKzY3bnljSDg0bTRpUmFQZndMcnNsZWdXWVNSRzg5?= =?utf-8?B?QlA5dFZIY3hIWW53VjFiYm1EcE1sb0hIVzY5OXRpYUNVSjNOUHp4ZWpzbHNQ?= =?utf-8?B?QnpIQ1hQQlJpUWk5NnFrYlJkSk8rakI5NFg3T0VySFZyTWN4Nk9QRzl0bjBy?= =?utf-8?B?QWpFbEdOazMzVmFaa09pUGlGU2NlU3RGenZzUlNFYy9yYkhzeDcxaFNIcDRv?= =?utf-8?B?eXhjY05DZDQ4MTloY003V0t1WEdjYnNDZkhWanlaMG1LblpRT3ZHZExvTFJO?= =?utf-8?B?ZW5FR2xaYXp5cE8ybDF5UW9JMXVSRmYzNldjQTBpd2NGSU15dWY5MDVVbjFu?= =?utf-8?B?MGZxdExHUWJTUHFKcTYydmtNRWIxS2g0QkdaREd5MDNVa1U0aTEva3pxd0JM?= =?utf-8?B?UTBIV0liV0o0RW5Bb0VvSXo5akJTL1ZNeDdzZ0t2M0FXM25Rak1WVFFWbXBh?= =?utf-8?B?YWlqbkdOUVFSNy9jbXc3LzA4RG1Ib0hNb3FscndZMTBWc2dhdHJuOVh1akF6?= =?utf-8?B?RWdqaEVmV2k0bDNmcStva3UrdCt1SzdvL1FjOG5SS1I3MFZpNDZpOEZpendP?= =?utf-8?B?N2lBaDd0QTJ6MytQWitveUUzVTFzODVraklQZ0xDUS9sRzF6NWRiU0hONWtj?= =?utf-8?B?NktKUVdQTGdhbkNNRGlVdWpRb0xBUGZGY2N4YktHUThyUGNmSUlOcUVFMks1?= =?utf-8?B?MU0vM0tGakJWbGs5TmFuOVV1VzlGZzRPK0Q5RTVLOXZIVzV5N0FQMFFMVlJ6?= =?utf-8?B?bHdHanVFRlF3ZkpWeDBnTGk3MkNRNVJjaFRaVFpkZW5jNHk2MXc5Z0QvWTF0?= =?utf-8?B?aUlFMzJ1QXBOaUJTaFpGemhtRlFvZFJ2R2VwbHlyRm9aZnp1MW82TThrMTBT?= =?utf-8?B?QXdwZlFORFd6aElPU2N5UDBYcC94UmxLUzFKRVducjlpdXV4WDFacVg3Ni9t?= =?utf-8?B?aFdQZG1WV0hzQmwxSTQzYVE4ZUZXb1ZwTTQvMnNyUkU2YTZCU3BBWHM5ajJC?= =?utf-8?B?QWRDRFZwU3lmWVRkSE9aWWFFNm03TFJ3Zm1RdWlPN2IvOWRxWmNVaW5LYVNr?= =?utf-8?B?TURYUUhocWNOMmJKS2dmQmo1SmF1cVljYjhOS0VrS25kNzdMT25DSy9JbVpn?= =?utf-8?B?M01QTXZnWTBQNlNleTFUaDVLYmFtdTVPZGI5OERGVGlWaDQrcFZrT0F0V080?= =?utf-8?B?QTM1eCs1dEsyTk8vb0M4UzczYWJEQnZMaTFzOE91VVNhbDZyWHVmMHpkT2hB?= =?utf-8?B?V2IweWZIdGd2b04zelFzdkhxcEZIU211OE83TnVuUXd1Qk5aZ1ozdkFxN1Ru?= =?utf-8?B?UUxnV0JNdWJUYWk3RWd2SStNaUI0OXpBTnVXZmlIa1NtelQxWGUwdlY5cndX?= =?utf-8?B?Z1VMQ29PMU5POUI5UVpuNkw2bHFsRXo4UUxwNjVzYzBXamZ3UEtadXpiZk1P?= =?utf-8?B?SG5paXBzQzNRSE9YNExxRlRKTFVwN3FpVDRsT2lXSzJ1b1BGandMUGM5aDBR?= =?utf-8?B?YVhaNVBKZGtBWUZKNVJhWlAveS9XcVZSU0pzV2lrV01XZ29CVEpvWVpPWnAx?= =?utf-8?Q?cYAxxNzxNnUh7QP+BcGQ4UqVb?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: PSzg8J0dl8lWFFxNiwQ3gJEJ3+0oKWeH5tce+3dKoHdUIBJ72tSxA2eSSDu73JZKdFRUIefbbAah7JIFcOYeJRUtsSFSkV3OCpHvbKL+0eAyBBQjqhdYzOGMKAn+7nzy2JjrOsyfpfV1HM2neXQ61tcB6HgKayq3ePtR3F2yTDfSfRZ/9qCclPHrHG3DnksW8YOvcZL4Yw4y6YsAjCgs4K7W7B4jyg2MqGlEkpQykQaO62+6NnrgSkRlYVVXI1W29/LZv5aeEj2u1fewVX/mBkgco6r1HIp3390kGpLGl8iUK/pi/RkrxfpLXNgkYGPcoOllBWeBApjo7BfoWzMtcQjY+ltGwEfcTaIzqYZP1djeZLLlhvrBhgIj0MajjyaG4EdVL4dzK/d/f1DYZXS99faiyoVaLiLgVl85cwW601eIDiXh5iBccnX3TGz4dUTF8gh0o1T/EzLFmKIEr9hVE89vkZ7cm+SyQJvZ8yXxlHtdGr3VtJrO7qOR0c3lZ0RKX+d+u+ltZ3lcie/hkwXz1u/EAYNlrLqmUgh0roYA+JpW0NBPFmGVCxHavps7h70WXgYjEWHLFhxU7cviJzYCe3sJqz4AypZSs94IW8AzDE2RoW3Rx3fyyPsu+3cbjyXrriFIGaCxMQfHDIf56ZdEdPK6S3Xf6wWjEkpue6QMltrUMop8eNxck1YxLENHM5+y3kJTZKYP/2Sv4mQMxC1LeYKnf361rvRnRfNkdOr/Hwrp8aDnNHK21KldWeuxUZSOwBYS5tmWScjxvecC6gfZ4uqPQETWFoODAC8/seOYU3nTT5YM/F/dt3HZ6/hEVNHbRR35Ie+DIzNj5e17nUKhFlgdnkYNNbsQEI0FJFJK17nOOrCeNOMNJlHfGn4B3kr97IXN6v+PebGzNPHnbrjQxg== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb9715b0-4cec-4c6e-5614-08db4c7771bd X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 08:13:29.8888 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bFzbkuQCfwiHOx2IQJroyVkQ8TnsKWXOo7ViTwRFWt9bw2+gt5AzhccZsuCLV9aEw0t7+DlckNJO1xGh4c9gVQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5511 On Thu, May 04, 2023 at 09:50:27AM +0200, Jan Beulich wrote: > On 04.05.2023 09:44, Roger Pau Monné wrote: > > On Wed, May 03, 2023 at 05:33:05PM +0200, Jan Beulich wrote: > >> --- a/xen/include/xen/sched.h > >> +++ b/xen/include/xen/sched.h > >> @@ -438,12 +438,14 @@ struct domain > >> > >> struct grant_table *grant_table; > >> > >> +#ifdef CONFIG_HAS_PIRQ > >> /* > >> * Interrupt to event-channel mappings and other per-guest-pirq data. > >> * Protected by the domain's event-channel spinlock. > >> */ > >> struct radix_tree_root pirq_tree; > >> unsigned int nr_pirqs; > >> +#endif > > > > Won't it be cleaner to just move this into arch_domain and avoid a > > bunch of the ifdefary? As the initialization of the fields would be > > moved to arch_domain_create() also. > > That's hard to decide without knowing what e.g. RISC-V is going to > want. Taking (past) IA-64 into consideration - that would likely > have wanted to select this new HAS_PIRQ, and hence keeping these > pieces where they are imo makes sense. I'm kind of confused, what does Arm do here? AFAICT the pirq_tree is used by both PV and HVM guests in order to store the native interrupt -> guest interrupt translation, doesn't Arm also need something similar? > I did actually consider that > alternative, albeit just briefly. If that ... > > > Maybe we would want to introduce some kind of arch-specific event > > channel handler so that the bind PIRQ hypercall could be handled > > there? > > ... and hence this was the route to take, I suppose I would simply > drop this patch and revert the 2nd one to what it was before (merely > addressing the review comment on Arm's arch_hwdom_irqs()). That's > simply more intrusive a change than I'm willing to make right here. It's hard to tell whether other arches will need that, I think I need to better understand why Arm doesn't before making any judgment myself. I do think it would be cleaner if the field was moved, but that would require us being quite sure it won't be needed by other arches. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu May 04 08:17:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 08:17:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529624.824194 (Exim 4.92) (envelope-from ) id 1puU9b-0002dt-Lk; Thu, 04 May 2023 08:17:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529624.824194; Thu, 04 May 2023 08:17:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puU9b-0002dm-J2; Thu, 04 May 2023 08:17:31 +0000 Received: by outflank-mailman (input) for mailman id 529624; Thu, 04 May 2023 08:17:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puU9b-0002dg-2b for xen-devel@lists.xenproject.org; Thu, 04 May 2023 08:17:31 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2062f.outbound.protection.outlook.com [2a01:111:f400:fe12::62f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1c86e7d7-ea54-11ed-b226-6b7b168915f2; Thu, 04 May 2023 10:17:30 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB9078.eurprd04.prod.outlook.com (2603:10a6:20b:445::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Thu, 4 May 2023 08:17:28 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6363.022; Thu, 4 May 2023 08:17:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1c86e7d7-ea54-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oHJlK11xkY+CMu53cM6p1sE+Ctcpz6xPff6T+93JQ5Wk8oODPHMP4ERBwv4c8V/CkJQ+jTHdG1MjupQxZGJwAUs8UsnyD35yiL05G/B5+t4xe5UcSjdtXV+qfBp86fIBBnU9KpHmijoBYfhhMDprB3Wo7yibSF9mC1IMdo/uoDqAjwMk9eVHHfHv97zcuwdHv4f7loWj17v8+b7XHd3j7H5H4ItdjdTCD+3ew66YuBs7EJy4iK3QLX3BzGU3JhBF0UFk8JsXEu8FvafwJbcoEfP2yqE6lfJ6jBSEQKBF+Pyj8y2JxLHhKV/tURRrt8PXMVKWgTIFd1Ys8o3tqDek0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iTHJ1g0+LZrRj1zftOmP6q5palV4trRf8dC586XjlVU=; b=XRK/bhlXMFHwcq+dK3CXc7qku5fcTr/I5wuFbgQL7v/oYEV8pJTheK4Vpqzi+AtTLQWeRj9r8cHl34TObBu7t8kYqQ846ubG7Z+HKG2rQO/TEYkBD8rMw7+CAHtKhi9x1CEWso5C8rFA/7mJ5j8SFdEntXC0l/y3W/evSU/1Rmr/r+uQmDmDFkgOO1/elFD3sea1ReRg5/8MeUU0Dnz5Fr/VIH673LB+aXJEpKkAc/x4ecKCqNuPGGFYM0HxkcqnnUT1V9EmWxUY0DQjj6humJm9MfGnhyhZM5FlaedmUqM0VcrmqQSkyPIvrEGbMfNLlliLm7mNhCnfZ8rVisb/iQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iTHJ1g0+LZrRj1zftOmP6q5palV4trRf8dC586XjlVU=; b=ZBAtokuwBU9I9IVnlLRX29kXwDgGEYy0VZYAEYHQFf5FKfYaLLJ67OWHd+T15l62qkKEFkGfWXUTp1Y0bWZmkwye81ybH49ab5/Y2DwLIbcg5afnJlzJ9+g6AOcwKxnIXu9NXImorqOwX3TU+a2yNJ+5BLNJxP4b/UGDSQ11K5wkWbMp0BV0/a6vmXEw2ei4UVQ0lbFJwYwjh6opahJ6mPT6Jmu5QFAGj9zBia6JXI4vOG9F29tNMeAaivysPTuzb2ZwoSXRaoAdWP+K8/h3Lj5EK8h8SQ9q6mYyqJhuhE8mWEIAp97i2P01qSfa9LyUdGq7qCkKdHPic6RMffiNEw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2b125ebf-53ed-27a9-2f04-be2a6cac7fd0@suse.com> Date: Thu, 4 May 2023 10:17:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH] x86/ucode: Refresh raw CPU policy after microcode load Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230503185813.3050382-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0043.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB9078:EE_ X-MS-Office365-Filtering-Correlation-Id: ac014da5-5556-4680-f6d8-08db4c77fff1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZcVFnvW+w+5xiR/gD+yUIgh24uLPv97Ed3ROtx0Xgur1xcWxdqz6BiBN+6PukiGJyCXsTHPpo9K7rbiw+8HAjHS09d8Gs51AnC4s0FrZEHC9jHLVXMFhXztk3wXAx7E22N69wD5C6VGXvMKyqYJCXtHtLFnsHK1t2IoI+HqSTgMH/vF8YCQewkfwchk+mz7aLKAZS4IU2i1OCg+lnLbjZzqIbGB5hdkWKPsxbVuPHWW0s5ZYQaO5Q77Hw0wmU0tn62bKDoDvBPXvnNnCnIInQKbmm/ZY+eUStiocXdPm3asmYZNCyorJzU7+BNJdNSulFo6Sc2f5VtLUC/Z6ZUXs52BCs+ii6V3PGRQxFp9sXxnT0UUiny/EbK0NdrgUutH/+0S2ijLcm9W0mdFOjXwe2IHmfN/Lj6fe3SEHjG6XnBcWGUbg5Uac7U/03RBD1PNbp61tkFBo1FtuqWouvYMvdM2QV15L4JvugQ/XVdiCDZYJP0qev7QSeK5E61+qOJKOMTdWurZqAM2xE9NMaFrgV+EvbmqD93J+rmCd7ii2MtVSqtx7ANjNkQWkBQQkBx51pIj46doEFtwxEp0ICe5BKvr+25gVWt2K7xJ9XzInEGoWcfS/Y2Sq3UclSsVICitzNYYrLd8lE/L3gnAIBEC5rw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(396003)(346002)(366004)(376002)(39860400002)(451199021)(316002)(41300700001)(2906002)(186003)(53546011)(6512007)(6506007)(26005)(6916009)(31696002)(54906003)(2616005)(86362001)(6486002)(4326008)(83380400001)(66556008)(66476007)(31686004)(66946007)(36756003)(66899021)(8936002)(8676002)(5660300002)(478600001)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U21lTlNRdzh2ckRUNmlDMEo1UU5DTStuRUFWN1R0YmlmU2gxVjM1TDlsUUMy?= =?utf-8?B?QkpzZ04xVTVoSXcza3FDU1NtLzNmcWQ5enZENkREamNqc0U3dkphTnBROEV1?= =?utf-8?B?NnZaajQ1a1lWelUxT2QvVzZsa0tjc1lHcEs5TXQ3WmZnN1FWdFpRQTBIdXMz?= =?utf-8?B?bHlkVHBSR3pXSU5aMXA4Uld2aTNOSkU0TXJVZ29oalprWXlsMTFDWll5Y2c4?= =?utf-8?B?cnVvWU1oR1VvMlhHZ1Nic0FnOWgzTlBFbmVLK2F6dFZmSjM4c0NLU2hrYVlN?= =?utf-8?B?T3p4cW1CYXNHMzcwTnZtUUM5TUJyNDlmSERvMmlnVERiSXR0QkROV1loM1d1?= =?utf-8?B?VktqajVDMmFvRDd2SVFHeXVONXdLZ010MDhDWWFzMXFxa2VkdDhKaElRbWN0?= =?utf-8?B?aTZKd2VGWVhLbzhwODlvQlAxOTlZLzUxSzROaWFQZEdqNGZiOHVQWmlDd0k3?= =?utf-8?B?SktNczVKSUNUTGlkdDBGd2FJUzRoZjE4Z25qQ0VRZmxlZFZ1cnZiaWZKeVgz?= =?utf-8?B?K1NMZGpySUJPeWI1L1QxUE5QR2QrTC9Cdm5KL2NueDJMZy9ENXlvdVdVeGV1?= =?utf-8?B?NEthT0xSbEJ2UGFlbFpDSFlJYWE2TFc0bGdHNC91NmowN0RuRjRONjg3YVNY?= =?utf-8?B?OCtiTGVoZ2NTUHVNTncrWjNFWS9SZ1EvajZBWGY4ZzRkYXp0SXBNWHY5eU15?= =?utf-8?B?SU5QSlYzQ0JZaXdBemdlWm5YZC9KbGNSK0UwQUhkai9kV2hCdnlHcythY3pN?= =?utf-8?B?UU5rMGxZMWREUGM4TllIRDJ3ZGxxSEkzdm9FUnUyL1RTZU8yTjY2eUJSQ0JP?= =?utf-8?B?L3UwN21GUlVmNjBnT1gzMGtDTHVlR0VnK2tMNEdObzFISGVmWmw0UlZIWUs3?= =?utf-8?B?U2c2aS90VHUzRCtLZmN1RFU2VlVGdG0rMCswUWtTdlhFekNJamNHaWZBT1pp?= =?utf-8?B?Ui9nMW5ualhqd2cvTkN3MFBaOTk1OHFvSkJyVUhZWjlCblNzTm9XQjlQTytV?= =?utf-8?B?WnlDNG42WXhaZnhsV2VaaVpxcWYxRGloUGtLYUIxbkN0K0NvTitHY2pLeHVJ?= =?utf-8?B?NFNhSWpNRlA5SFVQL2QxV0d2OVpGOVRrV3RsL0ppV3hJVnJSRWorVkVPQzFO?= =?utf-8?B?Wm9IVFU1NU4xbDMxSnNqZWV6S2FsOXlxZkRlcEpwZDFGOU1UNHh5Wjh4MElL?= =?utf-8?B?Q01EZy82MHRUZjg5Sk9namhyaU50bVU4d0FqQVFhYzAxRmFQdU9ZYnloUjNq?= =?utf-8?B?ZklHZkMrenQwWkNHVThRR0c1b01WRXpmQmtDTkFSTFpxdWNYbTJUa1I0RHRR?= =?utf-8?B?N0lCeWVjMmg4VVUxZUs1aTVEcklIeWxJR3lkMzNtRnhCaWt0Q0NoQlpXUWZ3?= =?utf-8?B?RnEzQmNCN21OSlBNZmZES05iZ1RLbXl5dUlxZDl0alRvYXpIaThxNmloRUZH?= =?utf-8?B?QTc1VnMxRURNODkzeG4vUkxoNkgvNTU1ajU5cmdWOU5rUysxVWc4UVYxRjIw?= =?utf-8?B?SWY1OHdGWFN1VThmbDVzZWF4N1ZLZTFKdStRRHI0VHRtbVhxM0EwaW5jNzdC?= =?utf-8?B?eXljUjVaRlF1ckp3ZTIrY0F6VUpYSjVySEs1M3U4TTRBSnBFcVA2SzFIV1M3?= =?utf-8?B?ZTRrNWo3RkYyYmFGeVVzSEQ5M0V1cmVqV2w4aXJ0RXh6b01BQmZyZFpKeXFp?= =?utf-8?B?TnF3QmMvbXJ4WE8xVGQ5L2pkaURkKzA3M1JDbWFXVlFhb3RpYnBEaEZKQTZT?= =?utf-8?B?bkgwZmNaNWM2Q3lXaURhWjZtbFJoVHJhY1hiTUJpVDJzWXY3aHpXSlRzeGFR?= =?utf-8?B?N0w3NGViSWY5YU9RcE5vVElvOTRNNktYcXNpMDRtR0d5dENFeWtLVWUwcWQw?= =?utf-8?B?VnBPWU4vNnI2amM2bk95cDdmWjgrV0lyV3Vpa2Nka0ZyTittemFETzRhbXNB?= =?utf-8?B?U3JiV0pQMXd5VnUveTdnNmd3THJ2MmZtMGJRT0FpSnpVUjJqTitZWFJvYU5Q?= =?utf-8?B?d3BibVl4WDhobUo5eEZSbkp1ekxUVEM3UTlGWlkwL2h4YXc0LzE3aFJmUkVw?= =?utf-8?B?QXIwK3BZSHBoelM2WDVhdzBYVjE0aGxKdkE1NjNoaC96VUEyblZZaTl4WGNl?= =?utf-8?Q?CvgDjeOxzQ/oPbSmRiJQnPoeB?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac014da5-5556-4680-f6d8-08db4c77fff1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 08:17:28.3085 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: v5zE08o0Bl/etrbbyx7xuH8Vw1jA20tKQaG7T+EYTeoPoU1f6i+d5cmxmcPJyLowgWhDlifhn+GJ+B0xrxslYg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9078 On 04.05.2023 10:08, Andrew Cooper wrote: > On 04/05/2023 8:08 am, Jan Beulich wrote: >> On 03.05.2023 20:58, Andrew Cooper wrote: >>> Loading microcode can cause new features to appear. >> Or disappear (LWP)? While I don't think we want to panic() in this >> case (we do on the S3 resume path when recheck_cpu_features() fails >> on the BSP), it would seem to me that we want to go a step further >> than you do and at least warn when a feature went amiss. Or is that >> too much of a scope-creeping request right here? > > You're correct that I ought to discuss the disappear case.  But like > livepatching, it's firmly in the realm of "the end user takes > responsibility for trying this in their test system before running it in > production". Okay, with the case at least suitably mentioned Reviewed-by: Jan Beulich > For LWP specifically, we ought to explicitly permit its disappearance in > recheck_cpu_features(), because this specific example is known to exist, > and known safe as Xen never used or virtualised LWP functionality.  Right, but iirc we did expose it to guests earlier on. And I've used it as a known example only anyway. Who knows what vendors decide to make disappear the next time round ... > Crashing on S3 I may guess you meant to continue "... is bad anyway"? >>> @@ -677,6 +678,9 @@ static long cf_check microcode_update_helper(void *data) >>> spin_lock(µcode_mutex); >>> microcode_update_cache(patch); >>> spin_unlock(µcode_mutex); >>> + >>> + /* Refresh the raw CPU policy, in case the features have changed. */ >>> + calculate_raw_cpu_policy(); >> I understand this is in line with what we do during boot, but there >> and here I wonder whether this wouldn't better deal with possible >> asymmetries (e.g. in case ucode loading failed on one of the CPUs), >> along the lines of what we do near the end of identify_cpu() for >> APs. (Unlike the question higher up, this is definitely only a >> remark here, not something I'd consider dealing with right in this >> change.) > > Asymmetry is an increasingly theoretical problem.  Yeah, it exists in > principle, but Xen has no way of letting you explicitly get into that > situation. > > This too falls firmly into the "end user takes responsibility for > testing it properly first" category. > > We have explicit symmetric assumptions/requirements elsewhere (e.g. for > a single system, there's 1 correct ucode blob). > > We can acknowledge that asymmetry exists, but there is basically nothing > Xen can do about it other than highlight that something is very wrong on > the system.  Odds are that a system which gets into such a state won't > survive much longer. Indeed. Hence the desire to at least log the fact, such that investigation of the sudden death won't take long. Jan From xen-devel-bounces@lists.xenproject.org Thu May 04 08:21:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 08:21:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529627.824204 (Exim 4.92) (envelope-from ) id 1puUDT-00046j-6I; Thu, 04 May 2023 08:21:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529627.824204; Thu, 04 May 2023 08:21:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puUDT-00046c-3Z; Thu, 04 May 2023 08:21:31 +0000 Received: by outflank-mailman (input) for mailman id 529627; Thu, 04 May 2023 08:21:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puUDS-00046W-B4 for xen-devel@lists.xenproject.org; Thu, 04 May 2023 08:21:30 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2061a.outbound.protection.outlook.com [2a01:111:f400:7e1b::61a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aaa7fda9-ea54-11ed-8611-37d641c3527e; Thu, 04 May 2023 10:21:28 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7479.eurprd04.prod.outlook.com (2603:10a6:10:1ad::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.25; Thu, 4 May 2023 08:21:25 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6363.022; Thu, 4 May 2023 08:21:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aaa7fda9-ea54-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dzZ7YQWEJzZZfabhrbsKP041Xp5luhcZjaLYohDTM1Mkxrc/P/+JX/vwsLwyu7Oy2ke3gnKmcaxcSscIj5qQBcAu6dvwxBKIi4lZYYX4MGX/g4kyoCDs0ono0QFRjbvBICd5JEDyj1tmj9pLuq+UCLkxU2/29k4A8bAPugjHYF13watgpav5+2AnhVLC8GLVd8RmYzVPzMWu7TkS9nd519DBqrkPiCi04QqHHmKMdxsKLoZeGuYS3Qs6Ah3MZyY86O0osBqd6B/jlDKpukKKrXBcwIGDcH/jjNtDtePu642bBpBYyE4dAp1jhDKAv5jhHsx1rjXWOAwI0rdFSKOYOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aI0/JyEON9kCkhqTyTPi7ggRbwp5JhYQG2jo6txVfvQ=; b=h/0hiF3Jdjz5YAuen/QLsYPpCzLbDT1R/vFWhY20TSJvDuMC9xPiGIk8jBiieztAOSmAFCiyvfTplIqn0fPUaXTbpdhAErZIocPPqJq6VFHIK74ETQtodEJPo+0cGmN18nlq6CaC0YZ9IieOQSWGg54rswrBXLay94N9zgizjfxWDgdvFs5me0P7SWvdD3igYij11b26cug+2TAa902S51OreP97fMYlclotRM0hX8JcXM9u5zSpwJBbaAp6rN8m6FmlNkJEwNw1XVCmffg3NMSFC+5d308PC1Mp23de6UwxNDvrtLsFaBHqbHkkJB1nvuZXc8VB3z5+1urPqfLdKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aI0/JyEON9kCkhqTyTPi7ggRbwp5JhYQG2jo6txVfvQ=; b=pFYKFDSuauBvx32KLRw76S+hJ17h9l2Gf6sXBlld95hgDUeHG3Qz/QcbUwopNU/9tc3zYYj7qECE/lyP4VoenNiNvcxESM+F/ubvyLX3Z2grn+9aPRgWFYozvZf92YKm81p+H0DKWKOwXWDgCBfvmn9nj6563+kTBOGmEgE5oL9/uB7iO2j4rR/flHM73Her2TEcsOqPxNTC93+Ab/2nQKYy5jG0iw8gYQNwBK/0IWQ895T0igcqZVFNNBHzJOzDxguhhqBWt4ruVGVHVNmdLUV9QoGEsgVpgPgCFjDkapPjZ0DXXOT1cXsXDbFgFJrXCfkeyGkb0nkoqMMLMeKFTw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 4 May 2023 10:21:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v2 1/2] restrict concept of pIRQ to x86 Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk References: <85e59fd5-9a06-48b4-ba7e-81865d44e332@suse.com> <98f51b96-8a1c-7f33-b4d3-1744174df465@suse.com> <2a46c7df-b380-cc41-5582-70b4829d7f47@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0117.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7479:EE_ X-MS-Office365-Filtering-Correlation-Id: 10202286-02d4-4af8-4f1d-08db4c788d60 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G/BJ2udFc8x9GiqZWgq9MxCsX3EPfOEFb74NCUcsfMEGRwuQvsEpXoB5LK96SbyicUz8QjhWqBRFtFsoPCEamB8zzetsDX4sOLHasx8gk+tLo8kbsTtZedE6zV8NU/81YL4ThZKQNBRXeYie2xeJQVD8fxRH7lb9CmoeUD28atm5/KML6h0qLKrL4W3HfUfqPkO322PeYhta4VECjhg1+DpOAMzHJhZosLakDYNPsXH2lXVu6ldEbOeK38fn0+TBWC9RRExYW6PoW8ANN0pcynxXNq4jG1FbT27iM7AcOmK1sUy/aqBNyFi2IloTN6/NIf3JSDPa86K5A7mydJUdzx7A3/moBBHt6QMW+snvDNxsYpAejfJL/DuVarvUJaeqbneARhH/jNuglGQHMFuwLYEfg5DjICKC9HfsW1c7OyzhoSn0cqxt8yBw7hZUI0M2hVfhr5Y4yUjiidqgUniqOlhB821qbU1UdzT2OjOzL/fdo2StxvG2JIv5Q1VMLRjk15yX11qVykQ94Ujq7I1x0msxogD+kPuEeCiyIvd0yrwG2l9zBUpjkoLM8IHTrps9sD61/fzAXBIUVWMd/nqPJhLqoFeTjOoCC1g8qrljiV122jTLkb7hMcFb3sKc4Z9hzRFzgkImB8aD3QE5YCg7mw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(396003)(136003)(376002)(366004)(346002)(451199021)(966005)(6486002)(83380400001)(6512007)(36756003)(2616005)(186003)(31696002)(38100700002)(86362001)(6506007)(53546011)(26005)(54906003)(2906002)(66476007)(66556008)(4326008)(6916009)(8676002)(66946007)(316002)(8936002)(478600001)(41300700001)(5660300002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WkFwOEh1VGRnMy9wWS9IWWVwcWJwaldJSnJ6V2pRSmRGUi9SM0NiOG5tYWty?= =?utf-8?B?dEVLVlZnRlNtY1dxVm1TdGVuanp5UzAvR1VpSERjMURnWnY0RVpubnRWYllt?= =?utf-8?B?S3cySWNpa1FvRUpxSFlsTFkwVVBkMERUQjBvT2FIbmxER3h3SEpSQ1hqaWJ2?= =?utf-8?B?d1RDeXN3MzZEb0hwL0N1aXB5TmVVSXNVTzFaTTdreVBoaSt5YjJSUVF3R1pq?= =?utf-8?B?bnYxcEZPUWl0Mm03ZXVreXdwSThmT293N2tFeGpLVmx3UjRYTzdyemxiejFy?= =?utf-8?B?U2J1WXorR0JUQmFZZXRaZXhMdjV2eE1JVUpSbU5DU1h5VlNhc3czWmNlNUxW?= =?utf-8?B?M2hVRkJxMlE3RzJSL3dJNVhPS0JKYnlrQnkvcDBTNnNLemphbHdBM0ZneW1M?= =?utf-8?B?UzJDTk1ycGxYdkg1QndLaXBrWjRodFZuTHJKcndlTS9XcU5PZDhiT0F4bjFM?= =?utf-8?B?MVBoOXk4aUVKM2Q1MXB6MDBCeXpEZHNIeUs2QzU0WEhWVG9NNXNBWFV3T2Z5?= =?utf-8?B?M3grSXJ0VnhETVozczIrWlhYU081VnB0MVA5SCtPNUNmbk5VZG1pQUoxR2dG?= =?utf-8?B?N3QzV3ZMMjlyckVsTERLWXlGU3RTV3IrVklRMHMwakQ0R2Q3T0hsOHZuVCtw?= =?utf-8?B?REpVT2RTemxBVEVvWGRnU2U2eVBSWnc3S3pzVEh5QnNrYndZdC9CWE0xTFZs?= =?utf-8?B?VTBRYVlZekZ4dUNkaWZZYXFxL1Y3SkJOUzRiQmNmbmphU08xcUJCOGpiVVhh?= =?utf-8?B?cjFSR1dEa3FqVTBVZlk5TzNOUi9lUWlqaG1US0l1SWZwWnBGUGZrQ2lDcmdP?= =?utf-8?B?Zm4rTVM4WTh3Nm1KendNam1oRHhJajAySkIyd3c0NkFGUHBCcVhiUXl6c2w2?= =?utf-8?B?L1lMMXJsanNlU2p4Y3V1eDdHR09BV3ZNSjczRjZWSXYxelRlVllVZ3JRaGxv?= =?utf-8?B?MXlER3VhK2dUOWJMQkRia0FsZFFWbktoZFVzSExuU1hoRFcwOXdNaEN6VW5P?= =?utf-8?B?cnJRd0lQRUZHbXJLNzFmMU9BY2lxTGpTWEVEOUxETjlYbTVSUmJ2Wk5SbmpJ?= =?utf-8?B?VTBGNmFDMWI5Nk5lNCtJaFY0YUVTMGI3eWQzZHBaVGFUQWs2Zjc0YjUxK21w?= =?utf-8?B?ajdtMjV0bFp6a3M3WUYvZHFlZ1NWZWdsRnRrcUFhL2pldG9RZDFJYlJWbjhD?= =?utf-8?B?dTVRTXdVNE1MTnhvejFuV1JVblJPNHAvRFNNRFBFSnNWTHM0dktMcDBJcmZx?= =?utf-8?B?YXA3NFV4enlDZG1EU3dqT0xLTmRkanRLaUdWM3lPZmM1MWlPOWJ3cTA1Zkdp?= =?utf-8?B?NHVRWC9nZXdwTzU5d1ppbU1GQlZLS0dkVVdvcGhCa3NSdkVBemFieE8xOG9I?= =?utf-8?B?eW12d1RCSEJtUUVjV0tNWThBOElIUFVtTFpJRG1sREtCTW56WkFuZlRGTFJq?= =?utf-8?B?cVFmeVgreG1sa1dIN3ZhVFV3ZWdNTGlreDF0aGNiajNhcGN4UjNueVg5bWxC?= =?utf-8?B?amV6eGVkZ2E5VFA4dXluQmEzWDd2MzFuZVlLVk1iNDdmQS9mRXI3YXRPRStD?= =?utf-8?B?WnN6a1JBZk1CUlRuTGFWUys4a1VxYndhWU1wU0R6VFJKNnlDUzJXck0vY25w?= =?utf-8?B?YVdHeWkvSWJrY1YxU1ZncUQ1cENEUU1pb3p2eGNBSW1SaFJvcnYvK1VlQkRW?= =?utf-8?B?cjE3RE1TTy9wUGNMNnhKM0pHQ2pERGJSVWRyUmRiRG00VU9YM1NPeVZaQWk2?= =?utf-8?B?ZkNwNUZrMitORGtqRDVNUnRRQS9yUitTZm5QME9uRGswSlVmM25MMHVyRnlM?= =?utf-8?B?VW1vV0Q1RllYWDNVNVRYYU85Vi81SkJPcXdPYVVoeTZKU2NUSFNVd2FHanNx?= =?utf-8?B?M1RLdVZqU0h6YnJnVlowQzRSVDVmdWNMNXVkRUpOcFB1S2dNM29DcVVkZm5I?= =?utf-8?B?anc4cC9mSUFydVJGWlhrUFFYQjhhUjVwTDJybzlJRy9OeFRpWllzZEJHNXdT?= =?utf-8?B?Sm40Y0ZzTktkdjFLd29zT3JRbVlXZEhIZjFGSy9SMCtFQ0l6UlB4Sm5Eb1hS?= =?utf-8?B?cC9aV2xRZGRvd1BoS09pR1BIQk4vcE5XT1c3QkJKc0dpYmNpVkdHTWtxdGVI?= =?utf-8?Q?bA5hhd7UgfEyoh/nAbNQir5j5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10202286-02d4-4af8-4f1d-08db4c788d60 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 08:21:25.6542 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RWy9DL/NesyFekUOBuEiyZ78OyEGMBT3BBYu+zFdIEibvDHKMZn5rXrJ+I2xZkqEknvXqZRySGXoCLUOmflxYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7479 On 04.05.2023 10:13, Roger Pau Monné wrote: > On Thu, May 04, 2023 at 09:50:27AM +0200, Jan Beulich wrote: >> On 04.05.2023 09:44, Roger Pau Monné wrote: >>> On Wed, May 03, 2023 at 05:33:05PM +0200, Jan Beulich wrote: >>>> --- a/xen/include/xen/sched.h >>>> +++ b/xen/include/xen/sched.h >>>> @@ -438,12 +438,14 @@ struct domain >>>> >>>> struct grant_table *grant_table; >>>> >>>> +#ifdef CONFIG_HAS_PIRQ >>>> /* >>>> * Interrupt to event-channel mappings and other per-guest-pirq data. >>>> * Protected by the domain's event-channel spinlock. >>>> */ >>>> struct radix_tree_root pirq_tree; >>>> unsigned int nr_pirqs; >>>> +#endif >>> >>> Won't it be cleaner to just move this into arch_domain and avoid a >>> bunch of the ifdefary? As the initialization of the fields would be >>> moved to arch_domain_create() also. >> >> That's hard to decide without knowing what e.g. RISC-V is going to >> want. Taking (past) IA-64 into consideration - that would likely >> have wanted to select this new HAS_PIRQ, and hence keeping these >> pieces where they are imo makes sense. > > I'm kind of confused, what does Arm do here? AFAICT the pirq_tree is > used by both PV and HVM guests in order to store the native interrupt > -> guest interrupt translation, doesn't Arm also need something > similar? According to [1] they don't, hence the (new in v2) change here. Aiui they simply map IRQ to pIRQ 1:1. Jan [1] https://lists.xen.org/archives/html/xen-devel/2023-05/msg00258.html From xen-devel-bounces@lists.xenproject.org Thu May 04 08:23:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 08:23:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529630.824214 (Exim 4.92) (envelope-from ) id 1puUEy-0004f1-HL; Thu, 04 May 2023 08:23:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529630.824214; Thu, 04 May 2023 08:23:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puUEy-0004eu-Dz; Thu, 04 May 2023 08:23:04 +0000 Received: by outflank-mailman (input) for mailman id 529630; Thu, 04 May 2023 08:23:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puUEx-0004el-0y for xen-devel@lists.xenproject.org; Thu, 04 May 2023 08:23:03 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e1b0bf3a-ea54-11ed-b226-6b7b168915f2; Thu, 04 May 2023 10:23:01 +0200 (CEST) Received: from mail-dm6nam10lp2104.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.104]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 May 2023 04:22:59 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by SJ0PR03MB5648.namprd03.prod.outlook.com (2603:10b6:a03:288::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Thu, 4 May 2023 08:22:57 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec%3]) with mapi id 15.20.6340.031; Thu, 4 May 2023 08:22:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e1b0bf3a-ea54-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683188581; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=29Hbv4zczTPm7mmZsDXiWwpgGywep53NlU2KoFia+Ks=; b=XrJzlUvCo6vvUIUJoLsrSsAWQ2H9SpUE1uKe5tXz8iJoYFNN34K6t/RR 2/VSH7RQgNSf5FIE+1+V+cAIX0Y79TZv9CHVf7mfM9aJmU2VSv6cf2+Zp Y5MgnAA016zTwKdenjs9tJJbS7hoZCSzSmpwqHerADbmp8P62LmkHWbz+ Q=; X-IronPort-RemoteIP: 104.47.58.104 X-IronPort-MID: 106585431 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:6dUlkK/r8W4Wagp5riJCDrUDpn+TJUtcMsCJ2f8bNWPcYEJGY0x3m mEbCj+Oa6uPa2Omf90lbYu1/BgF65PTz9M2T1Bpqi48E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kI+1BjOkGlA5AdmOKgX5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklw+ 94KJSEoZyq4isCn64n8YOlCppoKeZyD0IM34hmMzBn/JNN/GdXvZvuP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWDilUpjNABM/KMEjCObd9SkUuC4 HrP4kzyAw0ANczZwj2Amp6prraXw36rBd5JTdVU8NZxuFmul0MdOicPC1qqhuCSgF+YRulQf hl8Fi0G6PJaGFaQZtv3UgC8oXWElgUBQNcWGOo/gCmSzoLE7gDfAXILJhZRZdpjuMIoSDgC0 l6Sg8ivFTFpqKeSS3+W6vGTtzzaBMQOBWoLZCtBQQ5b5dDm+dk3lkiWFoolF7OphNroHz222 yqNsCU1m7QUi4gMyrm/+lfExTmro/AlUzII2+keZUr9hisRWWJvT9XABYTzhRqYELukcw== IronPort-HdrOrdr: A9a23:6rr6Jqnatn9OM+lMf8vqPmuC1QvpDfIW3DAbv31ZSRFFG/Fw8P rDoB1773DJYVMqM03I9urvBEDtexLhHPxOkOos1MaZPDUO0VHAROsO0WKI+UyDJ8SRzJ876Y 5QN4R4Fd3sHRxboK/BkW+F+g8bsby6GXaT9IPj80s= X-Talos-CUID: 9a23:xSSJzGAwslYYNi76Exdp1lwZC+UsSEbQ7mb7GAiSCUhJFpTAHA== X-Talos-MUID: =?us-ascii?q?9a23=3AYgLQ2Q8pptk3vgv21uLeMoaQf9xQ55n/J04/q4x?= =?us-ascii?q?YutijLAd6KhGAtzviFw=3D=3D?= X-IronPort-AV: E=Sophos;i="5.99,249,1677560400"; d="scan'208";a="106585431" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WLK373GUcwahTfMmf8XAGl/Chmc8ERWlGZKXxUorWPyXaMdFA5Rx3eNptNvB1h9GXBYcytJXjSDCyLSLX4iISARWSLI9PL+Nxs47XindI7ulaJgKIHNyZRfwdrv0KmTKDQUSd0MWUQ3J/4cgqP7TPr7UmgB0Uwmb0XiOAxtL0SP9vU7fihfWoOk3DvCV4yCWhDBBWog14+QvCsMBIXM0CDSb2VTAdr6Cy7yw1NdSKijUq8ujQ8Zu52GMQAA2WmhaGzMYjlmnesEUwUq6Ys/LIMSG2fHstkluodKEgB6zKMDIjqVFoYU7ykbxxDPDiiznit0HeRt/fhoNoWdlo2ZL0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vbwPc94iyHwUkqQgtzgz/Y6XXp7gSahAMvglzZG4bls=; b=YYFL0bvnQMYA/gCvQiDKB7myLKs2SIqcJIztkU6pOH+lXr/dqTZ22iz7FuTpwZumhY45XirT66qomCgBb0Mua90cWdItmTpkxoJIO1cl73/e9JCzUNxB/PtRb4JHArBUgO9RCI231hn9psQ50Z62MRu8hD8kkN4XTh7XBBTd1d2eOq5NJLkrAwgN1HdbPRCE6oV9vWVl0V1Hx6UmS/qvgFAMki/2O/XI7s9yve1cq6kbhUQs1soLCmGGmoO8NrYKPxkOzhQKHQDSw5ymNeWKO65p197rczE6f32GQEGknWQAl28zlu//cbWOw3Y8chKcuQV+Is9ukES0Rp6IVtvzHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vbwPc94iyHwUkqQgtzgz/Y6XXp7gSahAMvglzZG4bls=; b=QzcZfixCFnfr+RoJCK5gMRlS3sQTqIahoRn5/gCM8xs4nJbf78xGV2kyQfa01mpvZgNK7ie5YBvrostieVdldUTRTPmC5rASpdxgvMhj1ezOz4++B1OMIevUPEl+YJCtyYAIIHz6FVAtkZYn/aPRS0p0Dv34YzLZaDE9gq4oFsI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 4 May 2023 10:22:51 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: Jan Beulich , Wei Liu , Xen-devel Subject: Re: [PATCH] x86/ucode: Refresh raw CPU policy after microcode load Message-ID: References: <20230503185813.3050382-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO6P265CA0016.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ff::7) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|SJ0PR03MB5648:EE_ X-MS-Office365-Filtering-Correlation-Id: bcb543bc-21ef-4fc9-0d87-08db4c78c439 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xoiLXjy6P22MRQka85m4N4n3qTK0mpjyxch2PkmakTJF0xDNC1YuIscRAa7/SGbReZVKKis65RlsS8LlsTcUsTTQkxBkVmIpxAMDI69LFar19YYslQfnkmjAnSOkWE8QHY4i0hm/pJc3/QUuA7+l4MyNHJx5iSjgiQKDjaKDXeuzZGGLtTC2C7Q7qacBUYPwoJUuHTlo4LPnV6mxhG+EnfTn8dFcPfafi546PJa5ZOK7X809nRf5j7WbMFy4x7O5tALV8OpUbOrpKuLd/ta5YrnjRFlGtwNeZjgUUUapqHKrzT4MScLPF2lVTV4dFQc3BJVZ7jRAxswkd7Oet0CpFjOKnGMEfqLBI2DsjKI7PtlHY0pQ5ZnIdLc9pgLftJcnt52jb4HrnuV2p1CJdqD1f9bDT33GJDQsU+twn60deduFFk+43VgTbsG4ltn2QC27gBsT/qj0+Bi2YJcZTsfxFhsuRQfT9proW0w4EtS0aKWgrm7MtBUZyh2O4e476xIVzVsWMjcaBy0G0gVdaoy7EJ5CeVl5MKZtpSnyXIHiV3HWmAqtO5yfY5Hqt/RfzZW4 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(7916004)(39860400002)(366004)(376002)(136003)(396003)(346002)(451199021)(66899021)(33716001)(8936002)(26005)(8676002)(9686003)(6512007)(6506007)(6862004)(53546011)(2906002)(83380400001)(478600001)(186003)(4326008)(6666004)(85182001)(6486002)(6636002)(41300700001)(5660300002)(316002)(66946007)(66556008)(66476007)(54906003)(38100700002)(82960400001)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R1NmSFFhQ2JUKzRqcENaVWJIdUFtTTJTUVhscTFCZjNRcFBjeEJvZ1kzM095?= =?utf-8?B?a3ZXSlQ4QXg4TitKaXZQT0c0MjlaUVRpdmpwQUdPY3AvWFdtSktvdHRqY2da?= =?utf-8?B?SHdFMmFkS2Zlb3hSdXNNT3dpMnYxbmhpYVZNVnh3Q0JxemJsdTVHNTB3WHpD?= =?utf-8?B?OFhBTzhYWWhtQnBoTDFCeUN2cGFBTDNMWHdmeFpZZkViaXpnMW9sNk9veVRG?= =?utf-8?B?YVR0SnZhdVA3dERNRTNZQXdxa0c1NHFGZDJvbnd1Z3dMVmk1YXFRdVpxeXFj?= =?utf-8?B?NjM0dzVVTVJSSy9Lc1JXZ09FRmlqaHhSMjZnK1R0S0tVVVB1WnZOL1VpQ2lC?= =?utf-8?B?NngvVEtubHp6Y015SllMejJ2TnBzYmY5dXNKR3dzY1BxSWpPZmh5U1JyeFRI?= =?utf-8?B?ZVIwbXFKc2krQTU1YnpwUXJvNnFSeGVUQ3JCQ0ZGNXhHaGp6ZXcwUHlTUjJt?= =?utf-8?B?TWRQNkVzcXZhS2FPRzhOa0VMcGx4ajBTSU9UWERGY2xGMmtSNXJmRXlucXBC?= =?utf-8?B?eS9kdXBoTWYzY0Q5SkRuTW1rcGZ1QVUxVmtveUc2dHh6SThYa3NtYWRsVnM0?= =?utf-8?B?UEVZUTc3TTdnbFY0M3JYWmZJU05DSVpSVzJKanliSFY1aDl4bmZVNitqSWFl?= =?utf-8?B?VGdIa2FEaThkYjdoekpwaWFwWEZrd2JNdlFXVzA2V0pOcmVKYUY0SlgvM3J6?= =?utf-8?B?LzBTNTdXMStIWS8wOGNvZnVvei9iOGtkQUpXL0d2TlhRVjhxWWVWTEdKSXk1?= =?utf-8?B?L3d0TW9JOHRqYm4rOFFkMzFMcFBsemRLS3dFK0tyd2NhSFB1K2sxWFkrUlRh?= =?utf-8?B?U1gxK1NCUGJ2UDcwZE05OWFQVU14NnlFQ2t5RGlrbUE1RTVKMW9UUmFZVlh1?= =?utf-8?B?ZzRHUVhSaHVQcXF1ZlJJVWhsV3dpUTFMMFBGdzl4WWMyRElwb0d4RXM3NkRE?= =?utf-8?B?dm5tUGUraEVLVHhybU9pR3V5NjFJYUVJTUR2WDYxd0hDSG1jcDJpRTE0ellt?= =?utf-8?B?enVIRUtPTFFTRHl3SjlXNWpJQXBDMCtOR244ZURoK3RYUjRpSk5kS0pJTDly?= =?utf-8?B?Y3Z5R0dOWkdhaUZGR1puL01XVFJiQUJkRnVLdTVuNUFDVm9VTGU2c1hzdmNG?= =?utf-8?B?V2t3eXA4ZTVQNVhCQ1ZsNmNRdG1hTmsrN0JXV0tjbTlvWXNveVRLeXQ5aUFG?= =?utf-8?B?WXUxZTRiSERmLy9NOWIvZ1V1SG50eVR4aFpmYUM3UUhxWFJwaDZqTW5TSHhs?= =?utf-8?B?aWVsZ2FmN0lPQ3o0U0xoUktSN1BmaTc0RUFNT0hWRytJOWIrWEdmMFZyT3Nx?= =?utf-8?B?YnFnZDBQME02TkNpQlExS3hEaGlZUnlJQUsrTHRwQ2JLMnk1c1NjSzZHRDlQ?= =?utf-8?B?eWJKTzlaWHRkM1Erdy9iNG42WGZFUFMwM3REaWZlY0t4eGMrc0tmR2dwNUJJ?= =?utf-8?B?dGtpQ0lBdjRLdCtxUVQxUEhCZjNVNG5SSWZQU2pUNk81R3NhWkg3d3U4UEVB?= =?utf-8?B?cjdjb0dWMGhRWGVIZlNEeXB3a0xuZ1dERGNxMzZGZW0wOFhoK1pLUitydXlM?= =?utf-8?B?UnVmL3BwNjhYZGNUVndqMWhBRnN0WW5lWk4ycVRpdmJ2TlBHMEkvb0dGS21J?= =?utf-8?B?VkxBbWpjbnU5b0Y1Z1NtK1EycUZIdlpLRUFOa2lBaUNwU1JuT2dJV1VNa0Zt?= =?utf-8?B?ZmROZm55REpvc0grNm85QitmdlVlZm00cWdHMFRSL3JuYjBqUmxPOFJjRHJ6?= =?utf-8?B?VHFqWkp6djRUYW1yOTM0aDh6bU0zbWVrNXViZytobjFrMjg4UGF0NWpBZTAw?= =?utf-8?B?c1Z5Q2hObGJWWUFFNWtPWHJkNXlVbTRYOGNtQS8yNitYTTJZSjZpTnRoY3hs?= =?utf-8?B?NWtNUkNjNk1QUzUxamRGeGN4bERpQ1hZUmxJR1NWdUp4UXdvSEM2angzSy9s?= =?utf-8?B?dWpvT0pyT2NYeVN1RGlPQnNldk1obzRUOS9LK0o5cFA5MzBkVlN1anZKQ2xO?= =?utf-8?B?eWpXZncvOWtpNzJXYlVvMTdNRWt1blQxTmdSam5WbFhCUkV1M3Z5dW1ZcVhS?= =?utf-8?B?NzQxQnYrVzZ6NzZnRGRXZ1p6TXFwVjQrK01seWw1eXR1MUdsUGd4K0FFci9X?= =?utf-8?Q?7cgHu1TSS6pbN8Rmhv1I6aqvZ?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ATQJZC+NXqsUJTIB/C93uEsActuBsUDUI1H9PtsN43fczgFz9LN2mYkuMECjsCK+ntQu99Bg2mgZqjj6ZzmfXv6ZMN0HgW3/uB7hGrvnTugY/ljwfvg/EzpzLF9kAT6ufUigxFjs2ROi+LQZrq/7K8MZlnRsJsWujd9TcWWe1AsTNlZuHtsybrgZSxbLzyHKUkJkHTFCkTPiqfrgxHe3POV+uqEppxPL3Pv2CqHBWiGaBo2KSnKwZ93bgHp3IYsfVxMN902tfmuEjak1kq2DfWu6GP2pBW97NG+msxTz73khSYT07N3c1C5qSyS48j4298qA0u8dXivlyb9AuCKW37ezDBi28zVk+8/XXXj1Z9mKxLQRkk9aL6FRPO1ViBVywc4un03fNjWcCWqPNLypYIicAHlQ/hzx5njUZqK3JFpYs8I32wXVh+k99QgAae54jAvVuLEDSs+3z0aDUk0ngmyJHQGcBHlQ15nEKqJIJ5XJVrMKeGQo15zCK2ROTWBRDIc3v4y2iLYnm7GFqsxzvTxNExJJ+jiDB8zo5Hmz+RVtIAUIXcDKCMkYgP6VGU8Tp7rqGR0ffk8jjSuJNYzsOKxozf/ToB7fOquhryh29xo9kpJx117tmqS3ppvmUAQQFitFdfe+3zUtePuzrBAlSYy6HfuoByqtF/nseMOp/84/hRDw7fFjXVzd8JVkgd8qzG2dpx00TU9RJthIzpgQV4Jm5pDLZKEomdRrSDRtrM97nljFmrMTcGDKXK4S8+9URZ36q5LkkvGCUMLM/yFwN9XDpKrD5d5RlmBHKnqEs41BGS0w9NXnmhfz9ORPVaZI X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: bcb543bc-21ef-4fc9-0d87-08db4c78c439 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 08:22:57.6547 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zft3jmgwPQVZUK+nupfBR18LSv2muX4ZRF6JLqM1wXg1t6es59eUvXPkk3m2JLIMq/pc7XiK29miM/OBqMLinw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5648 On Thu, May 04, 2023 at 09:08:02AM +0100, Andrew Cooper wrote: > On 04/05/2023 8:08 am, Jan Beulich wrote: > > On 03.05.2023 20:58, Andrew Cooper wrote: > >> Loading microcode can cause new features to appear. > > Or disappear (LWP)? While I don't think we want to panic() in this > > case (we do on the S3 resume path when recheck_cpu_features() fails > > on the BSP), it would seem to me that we want to go a step further > > than you do and at least warn when a feature went amiss. Or is that > > too much of a scope-creeping request right here? > > You're correct that I ought to discuss the disappear case.  But like > livepatching, it's firmly in the realm of "the end user takes > responsibility for trying this in their test system before running it in > production". > > For LWP specifically, we ought to explicitly permit its disappearance in > recheck_cpu_features(), because this specific example is known to exist, > and known safe as Xen never used or virtualised LWP functionality.  > Crashing on S3 Printing disappearing features might be a nice bonus, but could be done from the tool that loads the microcode itself, no need to do such work in the hypervisor IMO. > > > >> @@ -677,6 +678,9 @@ static long cf_check microcode_update_helper(void *data) > >> spin_lock(µcode_mutex); > >> microcode_update_cache(patch); > >> spin_unlock(µcode_mutex); > >> + > >> + /* Refresh the raw CPU policy, in case the features have changed. */ > >> + calculate_raw_cpu_policy(); > > I understand this is in line with what we do during boot, but there > > and here I wonder whether this wouldn't better deal with possible > > asymmetries (e.g. in case ucode loading failed on one of the CPUs), > > along the lines of what we do near the end of identify_cpu() for > > APs. (Unlike the question higher up, this is definitely only a > > remark here, not something I'd consider dealing with right in this > > change.) > > Asymmetry is an increasingly theoretical problem.  Yeah, it exists in > principle, but Xen has no way of letting you explicitly get into that > situation. > > This too falls firmly into the "end user takes responsibility for > testing it properly first" category. > > We have explicit symmetric assumptions/requirements elsewhere (e.g. for > a single system, there's 1 correct ucode blob). > > We can acknowledge that asymmetry exists, but there is basically nothing > Xen can do about it other than highlight that something is very wrong on > the system.  Odds are that a system which gets into such a state won't > survive much longer. Would it make sense to only update the CPU policy if updated == nr_cores? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu May 04 08:57:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 08:57:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529636.824227 (Exim 4.92) (envelope-from ) id 1puUm2-0008LO-80; Thu, 04 May 2023 08:57:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529636.824227; Thu, 04 May 2023 08:57:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puUm2-0008LH-5G; Thu, 04 May 2023 08:57:14 +0000 Received: by outflank-mailman (input) for mailman id 529636; Thu, 04 May 2023 08:57:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puUm0-0008LB-D2 for xen-devel@lists.xenproject.org; Thu, 04 May 2023 08:57:12 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20600.outbound.protection.outlook.com [2a01:111:f400:7eae::600]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a739ef4f-ea59-11ed-b226-6b7b168915f2; Thu, 04 May 2023 10:57:10 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by MN0PR12MB6150.namprd12.prod.outlook.com (2603:10b6:208:3c6::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Thu, 4 May 2023 08:57:07 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::5b9b:f31f:ac6d:be94]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::5b9b:f31f:ac6d:be94%7]) with mapi id 15.20.6363.022; Thu, 4 May 2023 08:57:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a739ef4f-ea59-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V5gcc2Zjco2uTjZEwkckk85r6s/WdAHcPiGxVMxMnzcGdjhUcA5rk4vq+k+jAu3S8WXzqItdIUpLz4p2rWeelg2mRr6QixWe2zdZGt5KWdTMUQlcLMNlI/IiJ7p4Ex17vpvew9CnKxBQyGRK099kf292UCeV1PIter4X+xPhXhEqGwMHDC4TXFhk/wHLAWXmWFQxXQKobplFcM//9SXZF9JRBL5YU+W4dV/1uNRSeQmFhs8Wli/jEcaq6juLEJLmBLFs98dNVlvXxP4BESH5ESA68sgC1/63Dk0Rzi/W/b9TukjRpNTOfBi6MpPXYXpfVQ3O6A50rMXHU11cOI52WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bOcCAn5J6X8Pm64VOVcAOsHmFnDG/KQ8frpCsmJ+zzY=; b=RF28fiOq7LUiNB/qA+LxEN7s5tnsZzlUOV6AJ+Vp5OSao3ZycLQU81VvRXQvtkNd7skGu+mqMPt9yLnuCH3MQo/NeLlQiaKpf0b4QG4gYbBTuTHy8+faojU8ofFhNpMPW2NiL6VqBryhri673yIpusWQWhRU0CnkMKPite6I4sgl4Rk4rIwKFqm6cB6pvVz4vUjxplTT35Mv8YCJPwbHe3sVXLCOVrtr/UNAjSNIovN/0YMLBFkrrlgt+W7Lhf1/Z14fdarfCUDG9i6iAsoKwBJtAfkgYqn/uXapVnT5OFnzs6/vl9+ROhc0i2bTI0c/GmelxkQReOV97TesERZqiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bOcCAn5J6X8Pm64VOVcAOsHmFnDG/KQ8frpCsmJ+zzY=; b=DGUNHVRpwYrRt9NaYynA62vhDPd3DCL2xMsRQQ8R8ApQGt/DqTGeqH8u826i4nTd5dCb5aCOQCluiAPGDwrMnZONTm+CXJ2FeT4aDtlCwMfyD8F3CFLXaX5wpUPSK9M5CNiKFkNX8hFOc6wXg9q57wh4ryCHe70HD5YxoiYHKPQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <22c4da5c-9ad7-68ba-b005-8ba18e584bf6@amd.com> Date: Thu, 4 May 2023 09:57:01 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [RFC PATCH] xen/arm: arm32: Enable smpboot on Arm32 based systems To: Julien Grall , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com References: <20230502105849.40677-1-ayan.kumar.halder@amd.com> <2d764f29-2eb9-ecff-84cd-9baf12961c54@xen.org> <556611a5-dc9a-8155-650d-327b6853f761@xen.org> From: Ayan Kumar Halder In-Reply-To: <556611a5-dc9a-8155-650d-327b6853f761@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0322.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::22) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|MN0PR12MB6150:EE_ X-MS-Office365-Filtering-Correlation-Id: 7e170e52-c7d5-4b73-e76a-08db4c7d89b5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Pf1gvA9IXaWApc6aTTNxVBn+hHNVK2SY6nk4axFLBAZ45EeMT3l3YhTakMceUoFWrXnMus6PqtGCKgfvNkOOMjErm5jCwatLxuqXjxtbM87WoK+6C7ZbhNT0XfkF07csWkvdyPvTAiVy5k/SRRtvef6Ijs7O7dKCPG7oi1etKcXMwwMNf2/NJL9FRXkhMB4cgAuX9sjgqDRWoaPZrBDvmnTrZii2BoJU/Hz82waHM0zVD20TakSD/6m8KUV0RUWR6BiItOhin1sWAP+BQocb5pDSIEoLT9DDiWJ/UR3C0otX2A1SoWMbZ9IuBDZV4LZ6/JtpdClDZvq4ByW7e8CsEhAoZFfjEf+oigOs7dXrEbcu3UyguFPeAHPzQ/yRYU8XCavVQnPikIRHY8BzYhQalS+MvCxo350LoQboYWWEgB5h/1XwbjsEdGasD6qdDrOOEEZyfFiGzVLqUiEs5sIdsWYhVx+vBnvX5o3CIhVZBZJxQc+wcpFlY5y02ZF3UoK0kB53uWstSxW1VlbRYJqdS6yY1nE2My0j/u+0JLeL3j+bOcx+HSSGAmTTAUXIaVwmbOpCh2VMs/SNW8lglPJls5pW5qNQSaV5aP1klpfrESuiNZmQETTzM0g3Rcch2h+zPcNasNZqMQgTd9sAxf0yg47ZEeXMlefWZW1Xb2JtM9w1sG92uwal6hpNIeTb4D/p X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(39860400002)(366004)(346002)(396003)(451199021)(31686004)(4326008)(66476007)(66946007)(478600001)(966005)(66556008)(6666004)(6486002)(316002)(110136005)(36756003)(31696002)(83380400001)(53546011)(2616005)(6512007)(6506007)(26005)(8676002)(41300700001)(8936002)(2906002)(5660300002)(38100700002)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YTFhT1NZcVFwVUNXcHBPQ1VJWm5nV2I0RGZpNTh1MDlQL2FiT3FOcnRaQlhH?= =?utf-8?B?REU3RGJSUElmRTFSbUJBZTZWOEV0T3FUTUZ6NXRyb2RvNmc3cCtQbmlZcmd4?= =?utf-8?B?cWVRM3AybytSRU9pVWx4cTUwQUZCZ3V5bElBTEpYUnVSQW1jWmR6RGZCcWxJ?= =?utf-8?B?QTFJN2p5RHdGaFZMSHpuSnFhSlhkWjJqVmNuN3JaS3k1aHZldm9NUGwyRHRv?= =?utf-8?B?MW4vZ2VXWW9OZkE1K2JSTXBPRms1ejI0bFpMMUV2QzZYWXlFekpqcVR1ZmFW?= =?utf-8?B?V2V3eHR1VkF4SWEzdUUwb09BNE9PcGlKS29CYlJEenRNQlFRZ2FFSGwzNVpV?= =?utf-8?B?RWIzYXk0ZzNodGtENFZsMk5zajlyYnFVNnNrWjNiUmMxU1I2L01wNWlSajZx?= =?utf-8?B?bHU3azhGWmlLaE5LYkJqNlk5a1dqd1FWYkI2cXJUVFpORHl4eW1rMlNLbzMz?= =?utf-8?B?STc2VjljL1N1QWhscVNTUVhWbGJTOUF6YzZPd3NUNm1Qa3hLTlBqM2MzWEln?= =?utf-8?B?KzlmTURWeVRuT3lQQW1rcEtDK3hYOFNUNUlSbGkyck0vNzE3MzB0TkZLRmhp?= =?utf-8?B?QTQ1YUd4YUwrN1V5S3F3VFdkZ2tDcmNXNGx0T0o5OHNwTUR3TFk2UXlic0wr?= =?utf-8?B?U0pFcTViWFA0RHRGTS9UVFVlSjhBYnpZYytZMHhkVGFmUDRaMm5rOWxxVmxF?= =?utf-8?B?Uy82cUx6bkhoYStPT0g4ZWtQUzJPUHB0VWNCYkVnZFhFVDdCQThuSEZCN0oz?= =?utf-8?B?UkJ3dnZocmVEdkhuSDIxbTNmakh2MnkreFVodzl0azBadlJiWmNNL0dVdVIv?= =?utf-8?B?TXgxdGxSM0lIbko2NDdDbWNhV1VTN3F1L2lLRUpnRmxBWURhMnRhdTRzMVpJ?= =?utf-8?B?b2VWdmRBS21YKzczcW1pTjdTQXN4Qk85TE8rcnRkR21MU2JrSFhVeHVXckVi?= =?utf-8?B?ZHQ2T3lmRldqekNIRGwzVDNZVWNBcEtSWFc2cGdPRGtHWnFpVUh3RmViU0NH?= =?utf-8?B?ZEdKeXNiQmcxMTIzOVQ5dlVDU1JpdzVlakV2YjE5U3FTcklmQzlaNWdWQkZt?= =?utf-8?B?QldzUElmcnBFRVBpRS9XL2lvZkpZVVpTWTM0QzU4dFI0NlF6VldTM0JIbStR?= =?utf-8?B?OXhKNmNNMW9OMVd3Mml0UXROM3U0YU1wdTNUVWlEV290OUNwWTZoNHpuVjZH?= =?utf-8?B?UWVPQyt3T3FId2Z5UU1wVmZTRkprVXJuSWgxdlQvVmpiMkczbEhCNFBMckJX?= =?utf-8?B?TnlmVDRxcjBRZkFkVHFzWDhHdHUxWDZqSjhvalZlMW1FV2JSMDcvTklRNkc0?= =?utf-8?B?aDFQcFkrbVplQmhma3pQM2dxOEtyNW8rZ2l1RmdiVVlNaW5TUm5FeFhqdk5i?= =?utf-8?B?VlU2WVZzc0ZlcFdEdUprbHR1WHl1K1VWd2VQZEFNdTRxTVB1TkpPL01yd1Q5?= =?utf-8?B?V0drTThRV0M4d3FqeG50T1RLY2Qxa0t2cHVlUjRVb1dESzZLemRmVlYvTmZG?= =?utf-8?B?SFB1QmV5VnZBYTk1eHdQVlpVQUw5T3J1Q1BKMXlTVUhwZUVqNEdkUTcxWnR6?= =?utf-8?B?Q25WWkxXb1NtUmRjNHBIdE9vM0E1eE1MOWVoeDZvaXdBTTRQQ1ErYWJMejFL?= =?utf-8?B?TTZDVVZBdU5OaWVabUM1ak84WnVjTXFuckRPMEZVQUs3Qzk1eDRZais2R2FY?= =?utf-8?B?bU8ySlhDQTJTQVgzMkdrUVNBMzIva1JxRzhaV0owT1FqeExXZ3FvTmlITlFh?= =?utf-8?B?MUQzTjFjQUxheHVrOXRTUnlyMW54NE5NUGJjYlh5a2VHNnZva3hVcUpQMGpj?= =?utf-8?B?RjRDMEFWTmc4dmJ4Wm5vNFVibFZrWkdkTTY1dHdpVkJTUDBFb1dIUTczbUgv?= =?utf-8?B?LytSbmdTU0JpWDN4OUl5VzZaeHRkYlBqSDFkUXNkM2g0MlRXN2lISDdpQ1oz?= =?utf-8?B?TFUwSzVyR1ZiOHhibG1lenZTbTMzb0c4WXk4a2tpMGUzZy9OR3ExVDlzZ1F6?= =?utf-8?B?VC9ET3VJK0ZCMUJOZTVnQ3VKVlVET0U2S2E1NFFpZ0RETXh3azRNYkErSWZ4?= =?utf-8?B?YnBwRVJKdkdxMWpkLytFK1l0bmEzWWc4RDF4OGt5b0dlMkVxd2Y0d0UzZGpB?= =?utf-8?Q?tRB0fPFHouoZfUjnMVofDxjz3?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e170e52-c7d5-4b73-e76a-08db4c7d89b5 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 08:57:07.0618 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: G61RrDPaAk7D1HDfQB8/3qo6By6bTewltqiyqgNxQ3kHxEqsXhOsa5YYfmtMUvD9pEivNDdfY9F/hh/VLA7TVw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6150 On 03/05/2023 18:43, Julien Grall wrote: > Hi Ayan, Hi Julien, > > On 03/05/2023 17:49, Ayan Kumar Halder wrote: >> >> On 03/05/2023 08:40, Julien Grall wrote: >>> Hi, >> Hi Julien, >>> >>> Title: Did you mean "Enable spin table"? >> Yes, that would be more concrete. >>> >>> On 02/05/2023 11:58, Ayan Kumar Halder wrote: >>>> On some of the Arm32 based systems (eg Cortex-R52), smpboot is >>>> supported. >>> >>> Same here. >> Yes >>> >>>> In these systems PSCI may not always be supported. In case of >>>> Cortex-R52, there >>>> is no EL3 or secure mode. Thus, PSCI is not supported as it >>>> requires EL3. >>>> >>>> Thus, we use 'spin-table' mechanism to boot the secondary cpus. The >>>> primary >>>> cpu provides the startup address of the secondary cores. This >>>> address is >>>> provided using the 'cpu-release-addr' property. >>>> >>>> To support smpboot, we have copied the code from >>>> xen/arch/arm/arm64/smpboot.c >>> >>> I would rather prefer if we don't duplicate the code but instead >>> move the logic in common code. >> Ack >>> >>>> with the following changes :- >>>> >>>> 1. 'enable-method' is an optional property. Refer to the comment in >>>> https://www.kernel.org/doc/Documentation/devicetree/bindings/arm/cpus.yaml >>>> >>>> "      # On ARM 32-bit systems this property is optional" >>> >>> Looking at this list, "spin-table" doesn't seem to be supported >>> for 32-bit systems. >> >> However, looking at >> https://developer.arm.com/documentation/den0013/d/Multi-core-processors/Booting-SMP-systems/SMP-boot-in-Linux >> , it seems "spin-table" is a valid boot mechanism for Armv7 cpus. > > I am not able to find the associated code in Linux 32-bit. Do you have > any pointer? Unfortunately, no. I see that in linux, "spin-table" support is added in arch/arm64/kernel/smp_spin_table.c. So, there seems to be no Arm32 support for this. > >> >> >>> Can you point me to the discussion/patch where this would be added? >> >> Actually, this is the first discussion I am having with regards to >> adding a "spin-table" support on Arm32. > > I was asking for the discussion on the Device-Tree/Linux ML or code. > I don't really want to do a "spin-table" support if this is not even > supported in Linux. I see your point. But that brings me to my next question, how do I parse cpu node specific properties for Arm32 cpus. In https://www.kernel.org/doc/Documentation/devicetree/bindings/arm/cpus.yaml , I see some of the properties valid for Arm32 cpus. For example:- secondary-boot-reg rockchip,pmu Also, it says "additionalProperties: true" which means I can add platform specific properties under the cpu node. Please correct me if mistaken. My cpu nodes will look like this :- cpu@1 { device_type = "cpu"; compatible = "arm,armv8"; reg = <0x00 0x01>; enable-method = "spin-table"; amd-cpu-release-addr = <0xEB58C010>; /* might also use "secondary-boot-reg" */ amd-cpu-reset-addr = <0xEB58C000>; amd-cpu-reset-delay = <0xF00000>; amd-cpu-re phandle = <0x03>; }; cpu@2 { device_type = "cpu"; compatible = "arm,armv8"; reg = <0x00 0x02>; enable-method = "spin-table"; amd-cpu-release-addr = <0xEB59C010>; /* might also use "secondary-boot-reg" */ amd-cpu-reset-addr = <0xEB59C000>; amd-cpu-reset-delay = <0xF00000>; amd-cpu-re phandle = <0x03>; }; If the reasoning makes sense, then does the following proposed change looks sane ? diff --git a/xen/arch/arm/arm32/smpboot.c b/xen/arch/arm/arm32/smpboot.c index e7368665d5..0b281edb9d 100644 --- a/xen/arch/arm/arm32/smpboot.c +++ b/xen/arch/arm/arm32/smpboot.c @@ -10,10 +10,7 @@ int __init arch_smp_init(void)  int __init arch_cpu_init(int cpu, struct dt_device_node *dn)  { -    /* Not needed on ARM32, as there is no relevant information in -     * the CPU device tree node for ARMv7 CPUs. -     */ -    return 0; +    return platform_cpu_init(cpu, dn);  }  int arch_cpu_up(int cpu) diff --git a/xen/arch/arm/include/asm/platform.h b/xen/arch/arm/include/asm/platform.h index d03b261ce8..5cd7af4d0e 100644 --- a/xen/arch/arm/include/asm/platform.h +++ b/xen/arch/arm/include/asm/platform.h @@ -18,6 +18,7 @@ struct platform_desc {      /* SMP */      int (*smp_init)(void);      int (*cpu_up)(int cpu); +    int (*cpu_init)(int cpu, struct dt_device_node *dn);  #endif      /* Specific mapping for dom0 */      int (*specific_mapping)(struct domain *d); diff --git a/xen/arch/arm/platform.c b/xen/arch/arm/platform.c index a820665020..ed54b68c20 100644 --- a/xen/arch/arm/platform.c +++ b/xen/arch/arm/platform.c @@ -95,6 +95,14 @@ int __init platform_specific_mapping(struct domain *d)  }  #ifdef CONFIG_ARM_32 +int __init platform_cpu_init(int cpu, struct dt_device_node *dn) +{ +    if ( platform && platform->cpu_init ) +        return platform_cpu_init(cpu, dn); /* parse platform specific cpu properties */ + +    return 0; +} +  int platform_cpu_up(int cpu)  {      if ( psci_ver ) Let me know your thoughts, please. Kind regards, Ayan > > Cheers, > From xen-devel-bounces@lists.xenproject.org Thu May 04 09:00:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 09:00:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529639.824237 (Exim 4.92) (envelope-from ) id 1puUog-0000WU-M1; Thu, 04 May 2023 08:59:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529639.824237; Thu, 04 May 2023 08:59:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puUog-0000WN-JL; Thu, 04 May 2023 08:59:58 +0000 Received: by outflank-mailman (input) for mailman id 529639; Thu, 04 May 2023 08:59:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puUof-0000WF-H1 for xen-devel@lists.xenproject.org; Thu, 04 May 2023 08:59:57 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0631.outbound.protection.outlook.com [2a01:111:f400:fe0c::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0a32a5d0-ea5a-11ed-b226-6b7b168915f2; Thu, 04 May 2023 10:59:56 +0200 (CEST) Received: from DU2PR04CA0323.eurprd04.prod.outlook.com (2603:10a6:10:2b5::28) by DB9PR08MB10378.eurprd08.prod.outlook.com (2603:10a6:10:3da::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Thu, 4 May 2023 08:59:53 +0000 Received: from DBAEUR03FT032.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b5:cafe::8) by DU2PR04CA0323.outlook.office365.com (2603:10a6:10:2b5::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26 via Frontend Transport; Thu, 4 May 2023 08:59:53 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT032.mail.protection.outlook.com (100.127.142.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22 via Frontend Transport; Thu, 4 May 2023 08:59:53 +0000 Received: ("Tessian outbound 8b05220b4215:v136"); Thu, 04 May 2023 08:59:53 +0000 Received: from 054332754a50.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8D8824C4-A056-4F05-A9D7-D31265CD6C0C.1; Thu, 04 May 2023 08:59:46 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 054332754a50.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 04 May 2023 08:59:46 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AS8PR08MB9741.eurprd08.prod.outlook.com (2603:10a6:20b:617::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.21; Thu, 4 May 2023 08:59:45 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::9283:e527:bed8:ab23]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::9283:e527:bed8:ab23%7]) with mapi id 15.20.6363.022; Thu, 4 May 2023 08:59:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a32a5d0-ea5a-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Pe4iGj8pxSowClsFdNt0rI/Ih7O9o6ufQz/RjTFFtZY=; b=4oSeY/Jd/EJOwmBOY7IyEYD+aiybvQKu+mkXUJdB6sN79v+NODW5bdeqDS2TgH6n46vrpegLe94RK+XYQpteBIO5gLGhjN4y+1iixye/Bny8yalj/Ozs5GyiREuchFl+DgY2o4F7+B7sPwWJoR8X9JZOPM3DaDWl4DYVF1YtuRU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: f6b78dfc23327d82 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VFUYSGY6Fi7KpZ1EpOD78bU4SjdODDDGXYYJf9cHx9cP/11HeJrrH5njMMxkH3jA5uYDXXx2V3Nw1bixeMRwZgFadbcixg/QI1BzXOyHn0xHi5EgPICgJ5JTo8e6ChJ/IcIpYsK4qmwYeQOrc9v6SDqNhmI/IzpFC8SEGycMVjF3S21oWov0tJfEBOpHn65Fj5j26R2d30aYGOdIn+M5hIVenKClmMN+qKyzpVOipU412xtTN/gQuy2Bjt/EVfcPwFb7a8dPNJXDdxUZPq2mWbio48CleGGAfPxij2T9vVjnaSkjrcZg/VmYyPiQ9rNPxS3HHciQ0W6JmnR6S+QYHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Pe4iGj8pxSowClsFdNt0rI/Ih7O9o6ufQz/RjTFFtZY=; b=B8ueVsysN5bjB2BbbX4UxWBO/eoLEW3pxKR+ElVbPOmBBPeCs/8rdnC6L6/LGtNt6R2EjVpAEXID6XJuW0kAvzlVflykJOFY++oJM6t1/QLoDWWdLrJY8aqUb7a5HPpBH09jwvW4Zm5EsDOE3vCBDun1FVkhvXK+AyItXyIfeeGL2CqZsVImOyFo9TFKEpXyyN/zs68R5nIINbZUR3ACI40qDbGBXO/wzbe71voyItZar2VAXyozWLFwsC+b5MZPpXcflpT819tjUkJej5nnSmN77zCDoYJahJJmmsPaBzpbJ8vP97HlTJwz9Qv3MebDxRFORnv/z1ErAGn41/al4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Pe4iGj8pxSowClsFdNt0rI/Ih7O9o6ufQz/RjTFFtZY=; b=4oSeY/Jd/EJOwmBOY7IyEYD+aiybvQKu+mkXUJdB6sN79v+NODW5bdeqDS2TgH6n46vrpegLe94RK+XYQpteBIO5gLGhjN4y+1iixye/Bny8yalj/Ozs5GyiREuchFl+DgY2o4F7+B7sPwWJoR8X9JZOPM3DaDWl4DYVF1YtuRU= From: Bertrand Marquis To: Stewart Hildebrand CC: Xen-devel , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm: pci: fix -Wtype-limits warning in pci-host-common.c Thread-Topic: [PATCH] xen/arm: pci: fix -Wtype-limits warning in pci-host-common.c Thread-Index: AQHZffQTsmRRBKh80kOBQgH8fU6H2a9J0ZUA Date: Thu, 4 May 2023 08:59:44 +0000 Message-ID: <5D298044-314C-473F-97AB-420DA3DA44A2@arm.com> References: <20230503191820.78322-1-stewart.hildebrand@amd.com> In-Reply-To: <20230503191820.78322-1-stewart.hildebrand@amd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.500.231) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|AS8PR08MB9741:EE_|DBAEUR03FT032:EE_|DB9PR08MB10378:EE_ X-MS-Office365-Filtering-Correlation-Id: 30fad04d-eb30-4116-c8ed-08db4c7decdd x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: DcuV7NsL4RyDysu2xbACbluAmjrKp0t+plcOgUJTcr8n+85pm+n5eTPBSi6V4oyp3OJraYMFoDVB8t0huVgKWTv9+GCQfQgrqzSK3s5R+zMFrPCV19NiEz7g8T7wHugTS400vDdQa89Bx2pol4BpxU5DLFczF1BEwQj0AynthYDTHRhfxS7p8Qk6x/GIS5rR+Db5sd+zr/XBEsPQrXoEvoL7i9HPXaQAGeLV19SUp/5t9zm+wYy16cYP6ZtSP6/DPQ4u0LBt6NFLK00VTYtGGOcJPu/vpeBT7b/5Xx4lH+JkKA8/CwIGh7MCVqpaiQMW+NyC8W/LQyCh40Cg8bgcob7Em7stKaZfeNjZqEQA2sIatJtiTTT95d36UWF82KURuwniHCDafSreE8FAm1trtRA655BTJS+obs0aNTAAezIURzxcC2Ebm9Xcf/OYoIJIJ1g6dgug0KUKywCX9Lk/OIDuaQAK4A0rcP6WHmLplWslre/FhSV1Q1TYVImoRyfIjoPSbtqQib3aOPhZANY7pRxbmRE6vDfMGJ+Ylm/dXQn5deZMRsI0szByD4JHr5YR+dxdbwdtyQSq9y54+fcnYcDO2Btp1z/pU252pJQahW8FhyUx5Vt2E7TKfWd618sicJRG7A+OaKtiVJ/8o8LELg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(366004)(346002)(376002)(39860400002)(136003)(451199021)(54906003)(186003)(478600001)(6506007)(2616005)(6512007)(53546011)(71200400001)(6486002)(4326008)(6916009)(66446008)(41300700001)(66556008)(76116006)(66476007)(91956017)(66946007)(64756008)(316002)(83380400001)(5660300002)(8676002)(8936002)(122000001)(2906002)(38100700002)(38070700005)(36756003)(33656002)(86362001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <99CF58F2C0329B4EBD5E10C71324FF75@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9741 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c34286c9-720b-4b8e-417a-08db4c7de7f9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6IoV9SQAmRE1vymZaHsBsX5BlYowCLJsHFVFVOtNQmIdgCcxOGdJzCzyMCrVMweKjqxVXRyXyzfQtVhPR+C3vKykprdse4xMM9wnx/6h3fcsBoVUkPl0kHx4NgjZOaK1PPegf6n8rPk5Onix2CUdOGcQA7PuCSjBrSBbXWNBJOXyVHLk9aheKoDVLrWk9rG+u1inqMXGmpIGQNfZlffiWcfPz1+gAUz9rlRzP1FC3tpS8DKYz2XlhruDFRVtda44FF5gYnBVOhqdW2Zh4qbaSXUCJ0bQFoVoHCeOICTKxrl/USWNeRiHPCo5qAWgsMgAFhXTH6Qer8JgCc1+VZJYifP5PH+Ya4BxYChDWhPRVoBhjj2+q2Qfznd1lOpXM3F0MGo03BHB3TvbD7rRt5DqQV2LUCu9mSFW5JDyagcoxSfuH9vG6cl14C+jtCRz+Z89oNjRzrvuDRWyQpOOFZlL3NLh+KSllzpq5xQaZAcQwwOIROx+Ojba2Tmbr/c2wAM+TnXbT132BNocEO44GnFX9Vgnot86OKzEzmrKUOKZTGSAvjMGQKYcZq9GOkxdxBJM0/iPh04hqui0XVAvLHQIZ/rNbiOpERB72uHZ1o3XsVsn3sxNVr6LtA/nlgXc69FeMg2WgwkENoo3q24qnoiiNJcdujEa2TvHtWomzCcRld0J0YkAHp3YLMe67OmuItue5f36kKGN/w6aht4mtzpZbriCOx02k78xQpUG38ZTeHU= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(39860400002)(136003)(376002)(451199021)(40470700004)(36840700001)(46966006)(316002)(186003)(41300700001)(2906002)(33656002)(53546011)(6506007)(6512007)(54906003)(2616005)(82310400005)(86362001)(6486002)(107886003)(83380400001)(4326008)(336012)(70206006)(47076005)(26005)(70586007)(36860700001)(478600001)(40460700003)(34020700004)(36756003)(8936002)(82740400003)(6862004)(5660300002)(8676002)(81166007)(356005)(40480700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 08:59:53.1481 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 30fad04d-eb30-4116-c8ed-08db4c7decdd X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB10378 SGkgU3Rld2FydCwNCg0KPiBPbiAzIE1heSAyMDIzLCBhdCAyMToxOCwgU3Rld2FydCBIaWxkZWJy YW5kIDxTdGV3YXJ0LkhpbGRlYnJhbmRAYW1kLmNvbT4gd3JvdGU6DQo+IA0KPiBXaGVuIGJ1aWxk aW5nIHdpdGggRVhUUkFfQ0ZMQUdTX1hFTl9DT1JFPSItV3R5cGUtbGltaXRzIiwgd2Ugb2JzZXJ2 ZSB0aGUNCj4gZm9sbG93aW5nIHdhcm5pbmc6DQo+IA0KPiBhcmNoL2FybS9wY2kvcGNpLWhvc3Qt Y29tbW9uLmM6IEluIGZ1bmN0aW9uIOKAmHBjaV9ob3N0X2NvbW1vbl9wcm9iZeKAmToNCj4gYXJj aC9hcm0vcGNpL3BjaS1ob3N0LWNvbW1vbi5jOjIzODoyNjogd2FybmluZzogY29tcGFyaXNvbiBp cyBhbHdheXMgZmFsc2UgZHVlIHRvIGxpbWl0ZWQgcmFuZ2Ugb2YgZGF0YSB0eXBlIFstV3R5cGUt bGltaXRzXQ0KPiAgMjM4IHwgICAgIGlmICggYnJpZGdlLT5zZWdtZW50IDwgMCApDQo+ICAgICAg fCAgICAgICAgICAgICAgICAgICAgICAgICAgXg0KPiANCj4gVGhpcyBpcyBkdWUgdG8gYnJpZGdl LT5zZWdtZW50IGJlaW5nIGFuIHVuc2lnbmVkIHR5cGUuIEZpeCBpdCBieSBpbnRyb2R1Y2luZyBh DQo+IG5ldyB2YXJpYWJsZSBvZiBzaWduZWQgdHlwZSB0byB1c2UgaW4gdGhlIGNvbmRpdGlvbi4N Cj4gDQo+IFNpZ25lZC1vZmYtYnk6IFN0ZXdhcnQgSGlsZGVicmFuZCA8c3Rld2FydC5oaWxkZWJy YW5kQGFtZC5jb20+DQoNCkkgd291bGQgc2VlIHRoaXMgYXMgYSBidWcgZml4IG1vcmUgdGhhbiBh IGNvbXBpbGVyIHdhcm5pbmcgZml4IGFzIHRoZSBlcnJvciBjb2RlIHdhcw0KaWdub3JlZCBiZWZv cmUgdGhhdC4NCg0KQW55d2F5Og0KUmV2aWV3ZWQtYnk6IEJlcnRyYW5kIE1hcnF1aXMgPGJlcnRy YW5kLm1hcnF1aXNAYXJtLmNvbT4NCg0KQ2hlZXJzDQpCZXJ0cmFuZA0KDQoNCj4gLS0tDQo+IHhl bi9hcmNoL2FybS9wY2kvcGNpLWhvc3QtY29tbW9uLmMgfCA2ICsrKystLQ0KPiAxIGZpbGUgY2hh bmdlZCwgNCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBh L3hlbi9hcmNoL2FybS9wY2kvcGNpLWhvc3QtY29tbW9uLmMgYi94ZW4vYXJjaC9hcm0vcGNpL3Bj aS1ob3N0LWNvbW1vbi5jDQo+IGluZGV4IGE4ZWNlOTQzMDNjYS4uNzQ3NGQ4NzdkZWI4IDEwMDY0 NA0KPiAtLS0gYS94ZW4vYXJjaC9hcm0vcGNpL3BjaS1ob3N0LWNvbW1vbi5jDQo+ICsrKyBiL3hl bi9hcmNoL2FybS9wY2kvcGNpLWhvc3QtY29tbW9uLmMNCj4gQEAgLTIxNCw2ICsyMTQsNyBAQCBp bnQgcGNpX2hvc3RfY29tbW9uX3Byb2JlKHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqZGV2LA0KPiAg ICAgc3RydWN0IHBjaV9ob3N0X2JyaWRnZSAqYnJpZGdlOw0KPiAgICAgc3RydWN0IHBjaV9jb25m aWdfd2luZG93ICpjZmc7DQo+ICAgICBpbnQgZXJyOw0KPiArICAgIGludCBkb21haW47DQo+IA0K PiAgICAgaWYgKCBkdF9kZXZpY2VfZm9yX3Bhc3N0aHJvdWdoKGRldikgKQ0KPiAgICAgICAgIHJl dHVybiAwOw0KPiBAQCAtMjM0LDEyICsyMzUsMTMgQEAgaW50IHBjaV9ob3N0X2NvbW1vbl9wcm9i ZShzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKmRldiwNCj4gICAgIGJyaWRnZS0+Y2ZnID0gY2ZnOw0K PiAgICAgYnJpZGdlLT5vcHMgPSAmb3BzLT5wY2lfb3BzOw0KPiANCj4gLSAgICBicmlkZ2UtPnNl Z21lbnQgPSBwY2lfYnVzX2ZpbmRfZG9tYWluX25yKGRldik7DQo+IC0gICAgaWYgKCBicmlkZ2Ut PnNlZ21lbnQgPCAwICkNCj4gKyAgICBkb21haW4gPSBwY2lfYnVzX2ZpbmRfZG9tYWluX25yKGRl dik7DQo+ICsgICAgaWYgKCBkb21haW4gPCAwICkNCj4gICAgIHsNCj4gICAgICAgICBwcmludGso WEVOTE9HX0VSUiAiSW5jb25zaXN0ZW50IFwibGludXgscGNpLWRvbWFpblwiIHByb3BlcnR5IGlu IERUXG4iKTsNCj4gICAgICAgICBCVUcoKTsNCj4gICAgIH0NCj4gKyAgICBicmlkZ2UtPnNlZ21l bnQgPSBkb21haW47DQo+ICAgICBwY2lfYWRkX2hvc3RfYnJpZGdlKGJyaWRnZSk7DQo+IA0KPiAg ICAgcmV0dXJuIDA7DQo+IC0tIA0KPiAyLjQwLjENCj4gDQoNCg== From xen-devel-bounces@lists.xenproject.org Thu May 04 09:07:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 09:07:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529644.824246 (Exim 4.92) (envelope-from ) id 1puUwB-00024C-Fl; Thu, 04 May 2023 09:07:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529644.824246; Thu, 04 May 2023 09:07:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puUwB-000245-Cv; Thu, 04 May 2023 09:07:43 +0000 Received: by outflank-mailman (input) for mailman id 529644; Thu, 04 May 2023 09:07:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puUwA-00023z-Ew for xen-devel@lists.xenproject.org; Thu, 04 May 2023 09:07:42 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on062d.outbound.protection.outlook.com [2a01:111:f400:fe0c::62d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1f69816b-ea5b-11ed-b226-6b7b168915f2; Thu, 04 May 2023 11:07:41 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB7196.eurprd04.prod.outlook.com (2603:10a6:10:123::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Thu, 4 May 2023 09:07:37 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6363.022; Thu, 4 May 2023 09:07:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1f69816b-ea5b-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j4H1VA8bznmMSbKgMZocZJvvgaOwAHBFtDH/eX8KHjkbw4qHICIvLk8IvdOy9wF5Acv9nakuFlz3wieQYlRH9EvCEnerJIwiINrchDN55RfUeDMo7byptkcboBVNQ+nFYZNNPhY++8Spq/ewqWYOPXV32IoXySvD0gRyA1JWQVzmlO8p/kjgYXoXNBqoJy9svUd4a363Iyo2/qG3k8SU7lkBGMvsk4CR34JF+FGQhkcmIpc6FgQlKxDUm5ewaUF0EcHsmNMxzVFfYgxwEhvEHy5mDr6HirbflxmMTvtM1HeCdwxcUgv2RqSPrBp/6KlID8pRhfvVv8wWdeDyv1a96Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zlZrFoirnzlXG/C+nNjoRY8I/3VK2E7VhUCpER1XfAE=; b=Q9YDBDQcO5LfDPH7v4BaC8mR04ONiu29LMPfS0pORKYhaz9MtrbllcejolxtormKt650CNqba4gRxYzJQt5RriSccYQc8NrcpY1PgCgqZHgB+bGaV1HDQt2RPKzLjyE1Hp5vmQV+T6qzEwBAgELh3fhdI2TNucfG3HC6Sj6pUlHD2FkYRBizYjk2gH+TLAUzWFDQDbwfUjtfZobLLIxCkD0FSE7D3B4+r7d2x5OnAV4DNv5L8bx7biSBpq/+ieWmJ5mAezTJ/AM4CzZDTVsKUcqaZ7iXLjAJWYuyPuFLN8ztE9Y3Mn5z9gsczObV2GmlQCcm7/cQ6B4TYkYpouEuZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zlZrFoirnzlXG/C+nNjoRY8I/3VK2E7VhUCpER1XfAE=; b=EVRm5HP1ARaBXSEdnz1aB5gBKt7VK2YZPtoJdqTHdnkIgATcv1fBQfuRXbJSpH/xkBo1DybK8CYF8jkO+WJ2uIC94NcdVXS+dhZVf+ETCPtDSN3331RJDrrJFJNWUUGaC1o4R2t+G4552xfJNVKhUSYaKqVLAeuB3enRVOVN+2hTI/Ux17fEXPdoF9Qaia1PqwjIF7tLQjPsHWLNzM/DUjq+dhMdWF1tcK5fkE6S3ygXjjELVAMn8LLfhk6Nzctkx1w8A6rNZuSHa/uGpS9AgHxwRh+o5WOkuT4jmLQzHH5YjPyh2VecUXJawPQCc2dVc+WOIKDmlOnQfEVbJJ+evQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7e159a5b-b7be-c582-7300-154cec7a8e91@suse.com> Date: Thu, 4 May 2023 11:07:35 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH] x86/ucode: Refresh raw CPU policy after microcode load Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Wei Liu , Xen-devel , Andrew Cooper References: <20230503185813.3050382-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0045.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:92::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB7196:EE_ X-MS-Office365-Filtering-Correlation-Id: 5718b1c8-f2d7-4513-60a6-08db4c7f0166 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9zCrcCsnwpNP5iAQJnFh29r1DtLdbsXHRp12nm/Ea23tb0Wj4uOb4aX8QllUyA39muhmufyct8Tq6gHMukKg0qrebYSEDGmAf48hCNMDObAN4k21UtYZVZC2TWdUPnQF294hX+sHS50WCMYC2LWIaKubFRiKewBhlvZ0dvRIx6E+dyjPtprWBmUukr+E/9UGGpDgyb4lg556JzW8ip8hW50S3u/h8+VdnCT/ZaW3NNh2ZXDisdXLSz+3gp3IWCzDOSpfg4FnHZcnDB+hTHEbdF6xZ4t7aKTJQgDQpXXrxLymrF4QqHN/z18mautVH61EzvmwBl8oQzvesir5bwm5DR2MQeLN2uLDntSuqSnAFQXnq57R7azHztEmescyz6nU8uwrhIVT4YWX3qWDBzX9r9eGaQ/wNnXd3HNn+gp2BkJC3XwBz2igvD3RaXCFnwqLjf3TPYHAceUp7OiU1n2HxDjln4n6w9BsURTUPMsyJp/jitk8c+x/fsCfh7u3JNtjx+NeIVF32MM+TZGJVqqaQbCyIzBMtTe9SFfwEhXQuFpcH622jVj07kB7v0Y0ZUr8TyhnRMkTKVWdQmZqa2yjwBHnF1jiUXa3O0RoEK4wLAGB2dOlacelq1SLQvrpijpaoDmfTyl+YNad9eNjfj+zzQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(136003)(396003)(346002)(366004)(376002)(451199021)(83380400001)(54906003)(5660300002)(186003)(2906002)(38100700002)(31686004)(316002)(8936002)(8676002)(53546011)(6506007)(6512007)(26005)(41300700001)(36756003)(6486002)(2616005)(66476007)(66556008)(66946007)(6916009)(478600001)(4326008)(86362001)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VzZVQkVZZEtrdG9nWm1JZXRLVVpRUk1Eb1NOVGx2c1BEd1Y2cVpkeW5xKzV3?= =?utf-8?B?OTdIQXJyWlJ5NWZKT3k2TmV1bUpGMEJUdnBkenhiN1czdVR0Ti9xaWVJY0Jt?= =?utf-8?B?NkNBUXNYYmFBUEl1c1dHeHJLcDFPaWJSNk5ZSEx4ZjNicldoMXJ4NnUyaStR?= =?utf-8?B?ZnJPWGxOM0hCQVpSMWNrVnh4dzBJSXJ4ZVRjNzAyd3lrelkrQ2N2aFpTb1Iz?= =?utf-8?B?VEhTWFI2YjVGbnlRV1hsMzlFM1dzdHdTekVNazRMUXNRdmZYUmlaT2dqUWNv?= =?utf-8?B?L09jYUtXeHBUS1NJemxNNGhDdk9aRVdDVlE2VWVJY0duVjl2dVA4M29uazlx?= =?utf-8?B?c01DWE5oY2VzMkVoTXBQWHMvRHoxZmtwM2wzUDBIZTdmTS9ldFhTdDBtcnRH?= =?utf-8?B?MEt2TjlEdWJUQ2wvQ0EwcXRBWTJPOEE1SVVZSVFBRjBWNmxrT2oyYnUzejgx?= =?utf-8?B?aGd4elFVbUsxUzdvRUhWUWJRTFdWamwyQ1RwRDJjdTgvYTVIN1RiVUY0Wjl1?= =?utf-8?B?ZlJUcjRVR2xwWXFXYVVvUzBTdjNtSXNZOWVMUXJkYWpaeEk1cExZcVB1NHUv?= =?utf-8?B?MWw3ZkJEMmVrV3ZtV0ErQkdVSVVtb01pZHYwNzJ5SkNjWGRLMXM2VHRrN1BH?= =?utf-8?B?bVNjTHNIRUY3NEF4MmNucTdPMms4Y2JkSExvWEJUTmx3dzlvdWkwK21pWVl3?= =?utf-8?B?cXBMaGJsaE92anlleW1hT1gwSStzVjBmQ3J0R0IrSkZlVDhXSlJHVkg5Ynhn?= =?utf-8?B?Q1JjTE8vNWZ0NU0yb1RTaTU3L2wwaThkL2VodkNGQ2JXTFF3VTViT2s1TzF5?= =?utf-8?B?bzFrSjkwalkrQklUSjh0dlpvMlNzQjljVXdFb2ZyaHhSbFQ1ckc5dXFzdW1w?= =?utf-8?B?bXhnenVyNjl5MUcrVHd5M1VYb3ZieEhSRVJSell1M2FMQmZ6QlFEWjlwcFAv?= =?utf-8?B?WlM4ZGIwTWROUTk3U0I1QmkrRThzaWhtV2RJZUJzM3RHK3FrdnRPdEVlV2ZF?= =?utf-8?B?QTBQL3BIZUpqTTl6NnpDaU1QYklKSThFSTdyVG9FNGhCcU1vUFBIamlkei9J?= =?utf-8?B?RE50RVBtSXZ0RFBERi9KRWRzZ2xYbThkRWc0NW1VNDNhOTBiVmJ3b0s3clA3?= =?utf-8?B?STVBMEJoajZXeG9qNnRpUWl1bUUycjZBbjFxZ3h5UGpndGNDTXJyOHQwcWla?= =?utf-8?B?dGd2bWdBcmN1LzhPR1ZkY1RFQTFpMkZ0MDZZYmRPMGh5NkRXWFpVZS9XWDRl?= =?utf-8?B?N2dxTUdRandhck5qK0RLeGl4TUw2SWRxenFDMWJpZjZSS0JUYVFrMDRFUjZj?= =?utf-8?B?OCtPL0NaKzc4bU9MTzBMZHBLcTd4S202cHptQkpEaWpQeCszcWVwdU5kWEhp?= =?utf-8?B?UmEwVlg2UVJjc1l5MlJOcllTZjArS2xPMWRCWlpsOE1ORlBySmc1b2pWUUVP?= =?utf-8?B?NHp1NDNMa3lvRVNBYzBWSDEzdEtmT2d0RTdMZVJrNWNKSmNNVTRyTUFNTEtH?= =?utf-8?B?dHJ5eVNxdC8zWVk4SzJybWM3Mi9HbTdORWRYaDY5S2s4VVFpRE5LZXJOYkR0?= =?utf-8?B?b2xhMFE5TXp0aUYwWWhYVVBrbGFuMGt4TnA2L1pHTlRQQndrV2p0SlgxWE8x?= =?utf-8?B?VU1FMHRDbHRLclhMVWM3NTAxNGs3aWFucTJTRXZoRHZ3VkNibDlvSzByRWRY?= =?utf-8?B?NVkxbGh2by82OXJpK01YR1Jnc25IaTVQd2VnWURqSk8ycUduRzFQSTNCMFV6?= =?utf-8?B?Qm5KaTlkRk11a0ZIeVp4OW52UVNwVVkxbHBEbWhqUDhpYzNYdDlxSFY2QjdR?= =?utf-8?B?R1JvM3JaV3dVdHg3QmxPMFBkU3lLUmFoUWg1d2FKdmlPUFE4NVBsWElqUWlo?= =?utf-8?B?Z2pWRFdNWHByK0lwU2UzeWVDLzIxSmlKbEttaVFSYWRlS2kzNXJUNVptTWtX?= =?utf-8?B?Y20rRWs2K1IrbFNGTHpjTUVlWFlUZFJreDE4ejFTbVBsOFdBN09QSW96ZWE0?= =?utf-8?B?SzVNZWhXTS9DNTFwSXR2RWpsODY3TzcvZyt3N2poT0syTDR4VXFxd2tOa2Ew?= =?utf-8?B?cUc5TFB5bnp0U2JzRzN6M2lqNFZNYVlNSXAxZDU5ZTNTQkx4S1NDMjdGSU5E?= =?utf-8?Q?U05uGXxxoPehwn6En/yOyn/GM?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5718b1c8-f2d7-4513-60a6-08db4c7f0166 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 09:07:37.2298 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5SWQqwkqyZYJH/YZCLou74z22vX1jX4iSbs6twqh1A6Z/P9muLJpan3TTxT5G97B6QOXQI2uXOAd4RoQEJPSpQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7196 On 04.05.2023 10:22, Roger Pau Monné wrote: > On Thu, May 04, 2023 at 09:08:02AM +0100, Andrew Cooper wrote: >> On 04/05/2023 8:08 am, Jan Beulich wrote: >>> On 03.05.2023 20:58, Andrew Cooper wrote: >>>> Loading microcode can cause new features to appear. >>> Or disappear (LWP)? While I don't think we want to panic() in this >>> case (we do on the S3 resume path when recheck_cpu_features() fails >>> on the BSP), it would seem to me that we want to go a step further >>> than you do and at least warn when a feature went amiss. Or is that >>> too much of a scope-creeping request right here? >> >> You're correct that I ought to discuss the disappear case.  But like >> livepatching, it's firmly in the realm of "the end user takes >> responsibility for trying this in their test system before running it in >> production". >> >> For LWP specifically, we ought to explicitly permit its disappearance in >> recheck_cpu_features(), because this specific example is known to exist, >> and known safe as Xen never used or virtualised LWP functionality.  >> Crashing on S3 > > Printing disappearing features might be a nice bonus, but could be > done from the tool that loads the microcode itself, no need to do such > work in the hypervisor IMO. Except that the system may not last long enough for the (or any) tool to actually make it to producing such output, let alone any human actually observing it (when that output isn't necessarily going to some remote system). Jan From xen-devel-bounces@lists.xenproject.org Thu May 04 09:29:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 09:29:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529649.824257 (Exim 4.92) (envelope-from ) id 1puVGk-0004gt-9O; Thu, 04 May 2023 09:28:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529649.824257; Thu, 04 May 2023 09:28:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puVGk-0004gm-6d; Thu, 04 May 2023 09:28:58 +0000 Received: by outflank-mailman (input) for mailman id 529649; Thu, 04 May 2023 09:28:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puVGi-0004gg-TU for xen-devel@lists.xenproject.org; Thu, 04 May 2023 09:28:57 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1469e726-ea5e-11ed-8611-37d641c3527e; Thu, 04 May 2023 11:28:52 +0200 (CEST) Received: from mail-co1nam11lp2173.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 May 2023 05:28:47 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MW4PR03MB6665.namprd03.prod.outlook.com (2603:10b6:303:120::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Thu, 4 May 2023 09:28:45 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb%4]) with mapi id 15.20.6340.031; Thu, 4 May 2023 09:28:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1469e726-ea5e-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683192532; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=3SjYCgeiKRFBUkUBBZDSAPkT9FgNhZv7QMCfPzQlePU=; b=YVrxyidmCpWGKcnVvSQ8DAYsf7LXlycLhoZb8RiTdS7ZJWBRMVy2g0+o ALvn39xg2Cu/C2yfQ8K+UeHgQhh4xX2KAOCfdSDIrl1cwmdLpa79Z5CSm Jng3uS4/Sjj9YfzXMJgNjS2ORTvB+032iCMbYhB5FHSoQigR+ICsPwIBO c=; X-IronPort-RemoteIP: 104.47.56.173 X-IronPort-MID: 106594044 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:8/+nHamy59lAXDffA2U24Gjo5gysJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIYXmCOO62MNmH8f4t/b4u3pksEsZeHzodjQFRrriBmHiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aWaVA8w5ARkPqgW5AOGzhH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 fYWcD41byyEvOirmfGWb/dcj98bFsa+aevzulk4pd3YJdAPZMmaBo7tvJpf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVI3iee2WDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapLTOPlp6Iy3AH7Kmo7DzE6WlKFi8mAtXWRHPB7e 3FE9zQwsv1nnKCsZpynN/Gim1aGtBMBX9tbE8Uh9RqAjKHT5m6xGWwsXjNHLts8u6ceVTEsk 1OEgd7tLThuq6GOD2KQ8K+OqjG/MjRTKnUNDRLoViMA6tjn5Yo01xTGS486FLbv14KuXzbt3 zqNsS4ywa0JitIG3Lm6+laBhC+wop/OTUg+4QC/sn+Z0z6VrbWNP+SAgWU3J94ZRGpFZjFtZ EQ5pvU= IronPort-HdrOrdr: A9a23:4AJsOKEyLLSAaDbipLqE+ceALOsnbusQ8zAXPiFKJCC9F/by/f xG885rtiMc9wxhOk3I9ervBEDiex/hHPxOgbX5VI3KNDUO01HGEGgN1+rfKjTbakjDytI= X-Talos-CUID: =?us-ascii?q?9a23=3A5oYlZWndslUzZCK+iHA8R52pi5fXOXfTlHnoInO?= =?us-ascii?q?/Mmx0Ef64bEGg8bhcqcU7zg=3D=3D?= X-Talos-MUID: =?us-ascii?q?9a23=3A3nvAsgwrc4lbH8+P5poBu+fl0IuaqKOCJE8Er78?= =?us-ascii?q?2gva/GmtSH2eg3DmpXJByfw=3D=3D?= X-IronPort-AV: E=Sophos;i="5.99,249,1677560400"; d="scan'208";a="106594044" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aU8cJwsCVGaNz4grwnsgSMsATAvip8qDZxxOl9rN700sWG5GoGd7eUzt93eQgCrRbAgM2OEe2xQ0dzXve1sDrthvkHxQVWi+7nv64O8IyM1MwBP2QB+jzTYZ7kUAzFu8goWaW+AGLLAizniEYZsG45ZhWtiRdErtTcutbHvhutJ/2CC+HwxJWHGmj2cikUs2xlIu0o7n0WCs/QhJIkX63NJkukwe5FkMHgRKJowb592egqazi8XOg9ii6PeQ8dPq7et5eNuT3zebM/Ma+n7lYOpuGDra1CXcRzO2Xi7NV5TtrKEL9S2C0aJfsGNLUf8p2HUcJvLsFq+F1L4syk79Pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3SjYCgeiKRFBUkUBBZDSAPkT9FgNhZv7QMCfPzQlePU=; b=TgZU8yiUIjlX21UkprydHslXERHz794xIeVWQmB0sEOMNYzwm13cx5SR1ESUV0EAyS+VVEi2WPBzuPSGflL2Qebxnm+SZqUuRJx9A5kasADsdYH8AtiDE7uL0nPpwNyydCYjFi0af8vBY0Ctrx7F/R49lH3S/Ct2Ww5w7MWNUOsLDJ0FbLGY5tgUY683iWnmU434R+aV/NLRAjOYxFTJrMv+cvhFmqH0U57mQt5xUIVIi5DMzvOvWC/9Y9I7XUfmQngHJ6a8RXF6Tm7azRSNadlCpKG5ALXpFpsVhFyyC2Kui4Plo95Z9UBtUQ6yFi6z337jCM1cS7FJKcL1DET1PQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3SjYCgeiKRFBUkUBBZDSAPkT9FgNhZv7QMCfPzQlePU=; b=PGZHLRspaaQKWH6j2L3fJVi0H3omcq+yI6zsSXYC1VLeTQnC4mwLOkHflsfZ/8WekKNVanqd3o2+xqRst+RYSQeUFITYQwUidOfGRo+fNsa1hyul2GcJQ8HzLBCiZ5sahSG3zlsqWdbY0okctEdXtiraPq8jd7ihLM5z0UwFFzA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <575505d8-b6bd-be14-a70c-547d4229ad90@citrix.com> Date: Thu, 4 May 2023 10:28:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: Andrew Cooper Subject: Re: [PATCH] x86/ucode: Refresh raw CPU policy after microcode load Content-Language: en-GB To: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Wei Liu , Xen-devel References: <20230503185813.3050382-1-andrew.cooper3@citrix.com> <7e159a5b-b7be-c582-7300-154cec7a8e91@suse.com> In-Reply-To: <7e159a5b-b7be-c582-7300-154cec7a8e91@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0346.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::22) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|MW4PR03MB6665:EE_ X-MS-Office365-Filtering-Correlation-Id: 2c3be7a9-d59f-49a9-e14e-08db4c81f47e X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: K9XBHQej91rQizQR9sGHII6vqzLm4tTg+KM+WQHnAafqQ6ojzTob9ZkCHVx0G6nwz2X36HgcO+ZHDqwHUAfXuOcyMEgdSR8JAWbPXU9w/pGnUZBcFLhOx7TimFkL4ILs9Ms2dWu/tkhSF6l8mm5v6i6njrpmVZoUoK03vOeeur+t0br2WJYoq51223xW5kv2IiPhVKnQL6e8OGmwNmSulcO0niGUGkWTFmjJLfT+Hm5jx14Mpvix8Rq4DHqVTcYhxTjWZiEloS6LUsOiGB1+KxLEmp4GoUCKAT6S8Q8s5Ds1lP0doZUWm7nABg6bEi+aWLNk8ab2WVXmTFj1vfC2ULo+GzBKZSg9TX9RlNHX9V4ZZR/sR6Co3Iepiq1XMEcxAOX3HF07oAeAfO/oraUPz/ldB4pPbStY3Pv3nW06hdd7xBnLSzk42nm1+srK0EpUbL/XCl1alf2Z900EJDAFuXC6a+WyvzuLXM8d42hT9jNc/JW9TKtkyj2dtW/YrZmOGg2OIrENSrVBYu7Hv34OitrrV9TT7T4HWHbvFoUiNzfMxwjS/oANIq+kDNIEGaHmFbHHvdSYsUbRcp2PM7Iwtwj3WO/ZGNOBW4DdI+VM23ZjZmLzSWodtDR3i9wLaxRKfsnNFa3jdQ5Prm5BLUXw7g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(376002)(396003)(39860400002)(136003)(366004)(451199021)(6512007)(6506007)(26005)(53546011)(31686004)(186003)(8936002)(2616005)(66946007)(8676002)(2906002)(316002)(41300700001)(83380400001)(6666004)(36756003)(66476007)(478600001)(38100700002)(4326008)(6636002)(86362001)(82960400001)(5660300002)(66556008)(6486002)(54906003)(31696002)(110136005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YzFRQWNaUERqRXp6ZjJPdkF5S0QyRWlDcURmb2ptQUJtWWJCM0d3TGRSTGZD?= =?utf-8?B?T1g2TlBtem5uOVNwYlZCVnFCcDFYbDVMb0xGMDliUXRvNEpjWlJNV0tVdGNJ?= =?utf-8?B?bFh4cFhaWTlnMzBHWktod29QMGVFaUZ0dUU3NkJPekFJQWkyTGhqNHBxU3kx?= =?utf-8?B?ZTZKQ0ZUeXpCaGduM1VKTDJTdlk2Q0dMZnFQS3AzUEt4UURLQzB2em5WMWU1?= =?utf-8?B?RmFha2NiZWpvekJwa2Y0ZkFtT0pPVlhUNWJQajdGVm1Iak8vcUVjOUpicHNT?= =?utf-8?B?akM5c1Fja2FRYUdtM3RPMzR1WXpWd2ZpbkEvd2VFT290OVFiSTF0MldZdWxH?= =?utf-8?B?UEx3VW96MkpRY1JiWHRrWjkvdXQ2ZkdJN0QzczBkWjBDVTA2TVRzM1JxSEtX?= =?utf-8?B?K3M5blRwZEpJNStVMHp4YWIra1U0aExlcEdJM1Rkd3pJRENCQmxoWm1MZS9x?= =?utf-8?B?bmI3R2FVOHVIMGN3c1lpZTBYNWZHVFdaVWlvZVpmSU02SXZuR2dKQWtvVHp2?= =?utf-8?B?anZCZTdjKzArc2FPdlZMWlhIQjJRbzhoS1NFNUQ2WlQ4TDBsQUZFNzA3YVlk?= =?utf-8?B?Sy82MWN2aVgzZkJpeHZhSU1OVTcybGRWOHJMa2dKcWQwaTZFNGI0MUovVzE3?= =?utf-8?B?REZqVXJBOGVZeTFBbndhYmtyZEpFZWh3ZzE4dmdrd1E4Ri8ydUtTbzg4blNI?= =?utf-8?B?aE1RemRLS2NaTzkwNHZyckVKcDRiRi9xYWhDaGpjZ1FWYjMrRi9idzNyOTdU?= =?utf-8?B?NXl0NkMwQjFyZm9OUng4K3dRSVRwL1VQdXR1NDhOTVRJeGJkeGVaZjQzK2RD?= =?utf-8?B?b01oc0RnNkZuT3grQkt2cDFoTE5XZGhUSm1IejdSZk8zQksvc29FOUphV0hF?= =?utf-8?B?emE1L1pPZUJRVUUrd2lZamwwMit1SGIrSEhrTXhYakpraGNLeG5acDNycERy?= =?utf-8?B?U0pZbiszWi82aDVqVUd3K2trTzAzbytDUVgrYkR6VzZYN3NuYXRKb0haQVJr?= =?utf-8?B?cVR0TW54RlJXTDYvbEl3d3RxaDhCelZzZE9LQ21rTHdjL2lNWE5aVjdTdWJI?= =?utf-8?B?MFJYQktvT3hqbGJaa0taVmYxSElyRFJhQUZsN08zbXJUOVZac2N3bHVOQ0Vr?= =?utf-8?B?N0pnam83SWtzZUlWL0RnZjFyMEcxOHpyV0d6ajlac0hmWG9qb3RlYlMzdFdQ?= =?utf-8?B?UjNaaThaTEtaVjM4cWFkZllqYzBXN0dmdmswVjVCd0hsdFRuOFk0cS8zU25W?= =?utf-8?B?WWk5dHdwclN3TTQ2T0laT3d5TGVLVm9Wd09iYTVBRldxZ2ZLOEZ6ZGg4VSt6?= =?utf-8?B?MTZYdjlicHNxd3ViSnFFdExRRDRjV25GNElJUHFuaHZ3SkxMeWNjaWYwWGIx?= =?utf-8?B?YjZpeU9qWHBHZUtLYkZUaXpUbWhKUFRTSG5nSGQ4VTlBU3E2Um5wSTBNWWlE?= =?utf-8?B?bGtjZ0dBTnJueitzaHRWMEY5WlNtK1p2QXZXdjFuYnRHRStyTEg0M0t6UTB1?= =?utf-8?B?MUZwZ3ZRVTVuaFJOd1N2ZUJnbjJJa01ib0RpNCtjTHlnVi9hc21BUlBaL0hX?= =?utf-8?B?NkdVbWF4enMxOXE2SmpqYXlrTzYwekNFekYrV1VHVFg5c3M3K240SjdxcDlK?= =?utf-8?B?aVRBOWVyTXVmdlRnOGRkcmV6WE10dU50eXd0TGpMeEJkaEc3VEtpNjIzU1RQ?= =?utf-8?B?VlVaZ1BqS01zUEh6dUNEYjc2MkxnQUJkaStnZFpoNlBZTHd0WEwvbE5FZVFS?= =?utf-8?B?aDVVak84RlhPRHNzdm1FZ3dFK2lzaEljcTQ5OWRYaWtzbWJmYnE5cXozZnRt?= =?utf-8?B?N05wMERxQVBwN05XT2oybnBsWGlyTk1jRjd6eWprQ2tXZEpDeXVHRnlKQVA2?= =?utf-8?B?U0NQaEFIZWQ3b0NpdVViQ0F3cG1zN3pkUkMyaEtIVG90dW0xYmx1ek82VDVE?= =?utf-8?B?UllzMnR5K2tmdis3NFBtVGI5U0NIeXN2U2h0MEJmOGVCMVQrczdSVjBBZFo4?= =?utf-8?B?d3dyQmkyTVEzbUlmRk1rN056S1pNUHRrNW1Xbnd6L0tzcmpDSENWYUwzNGpQ?= =?utf-8?B?Y1Z3RStUVDJJMUJzczRGUlA5S0RQTE1pRWFSUlpuYUgwVS9qbWh3WmY5L2tH?= =?utf-8?B?YUtjSHdLanpuN2NKbnJaZmhNaENlOUR3M3dnSjZCUEJXSTNLVE5UcmdvNVhp?= =?utf-8?B?bGc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 7roCAQXfQ1HPgdojV2gaspnJW9JjH2WFu763yHNCa0zyuM4xrviotWfQQm1UgvlzDJFQYPdP8ISY7qoCvcxgr0CoYm1pCufCUdeHD8WaHq/uiX6XDcUI1npewKWftibyL4sks25zlZCCjA3D1ZAtmEiKAGFXLboY1EnzFoYMsYIBEJ/LqyxhXCV1hyiBQNKqv/ZXVheN0nw5gAJw+CNQuOGSTJlWW5vdSxvTmmx1a9dNu/lmyV05SgLVXCGdIOcKP4V3Dh+wzoom4WTlHOsRU2hEiTYuwa0Y+dUvmlBor7V7c0Ndi3YqcrwH1O6XvU6kQixDGraiqaWwJElc1h5gAiaq/Rg8a9OcvI8DlS8BuDCnnAOuV6j17+iYqCBnSuNYnih9UFRBSzFjYSMbVQViIXREGueL7v2KQn3KMwy96BRBuU4vIJaqBuqizLv4XBSIxvILUY8qm6gW89F6sd8ekFGlXTD4waSzvA1dxi7VZEfxZXV6BWdFvifHPNVGQgndC9ugunNwFvJb+K3xnnC8i7H0scuFPdkKlFI0Ivnf92sWkSl9i2rPK1flGvYk2TJDWGpftIGKDqA2JHDZGHbM+VETdSBO/3/tiT14oqd56V3OLkDCAMPFJqOKfSINjQPNbgZSweUGCnx8Oe25cI3hIp52bvTQpnpfA/pdmbjo7lsPKLCQJFcRcS6olusZ5z7lzHng0Pt2CXhD7jbUCDXsoEMh9iHYMGMqWUobN09UKzoQGKSd3sgEO1xABXVg8MLyVwkq/UXN9ZYDaoZXX1CjkFL/Jwj0dv9Wy9C3NoTexHTvZfMBaWd971mwrIjDmfzc X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c3be7a9-d59f-49a9-e14e-08db4c81f47e X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 09:28:44.3497 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2197Ocdx0mihdrzx9end/aI/r8DBHdLfxm7DhdrZ7gnhKHeCAwSEa5uiZR7jQaQMTzMHRtyneJqAT9LvKAHt2tesrrJZGHwtNU6bPqbqe2E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6665 On 04/05/2023 10:07 am, Jan Beulich wrote: > On 04.05.2023 10:22, Roger Pau Monné wrote: >> On Thu, May 04, 2023 at 09:08:02AM +0100, Andrew Cooper wrote: >>> On 04/05/2023 8:08 am, Jan Beulich wrote: >>>> On 03.05.2023 20:58, Andrew Cooper wrote: >>>>> Loading microcode can cause new features to appear. >>>> Or disappear (LWP)? While I don't think we want to panic() in this >>>> case (we do on the S3 resume path when recheck_cpu_features() fails >>>> on the BSP), it would seem to me that we want to go a step further >>>> than you do and at least warn when a feature went amiss. Or is that >>>> too much of a scope-creeping request right here? >>> You're correct that I ought to discuss the disappear case.  But like >>> livepatching, it's firmly in the realm of "the end user takes >>> responsibility for trying this in their test system before running it in >>> production". >>> >>> For LWP specifically, we ought to explicitly permit its disappearance in >>> recheck_cpu_features(), because this specific example is known to exist, >>> and known safe as Xen never used or virtualised LWP functionality.  >>> Crashing on S3 >> Printing disappearing features might be a nice bonus, but could be >> done from the tool that loads the microcode itself, no need to do such >> work in the hypervisor IMO. Xen is really the only entity in a position to judge when stuff has gone away, so this can't really be deferred to another tool. We have the X86_FEATURE_* names during boot for parsing the {dom0-}cpuid= command line options, but we don't keep this beyond init > Except that the system may not last long enough for the (or any) tool > to actually make it to producing such output, let alone any human > actually observing it (when that output isn't necessarily going to > some remote system). Yeah, `xl dmesg`/serial/whatever is the one place liable for anything like this to get noticed. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu May 04 09:33:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 09:33:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529652.824267 (Exim 4.92) (envelope-from ) id 1puVLJ-00069i-R7; Thu, 04 May 2023 09:33:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529652.824267; Thu, 04 May 2023 09:33:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puVLJ-00069b-OQ; Thu, 04 May 2023 09:33:41 +0000 Received: by outflank-mailman (input) for mailman id 529652; Thu, 04 May 2023 09:33:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puVLI-00069C-6H for xen-devel@lists.xenproject.org; Thu, 04 May 2023 09:33:40 +0000 Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id beeaea84-ea5e-11ed-b226-6b7b168915f2; Thu, 04 May 2023 11:33:37 +0200 (CEST) Received: from pps.filterd (m0174682.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3446m1I2022834; Thu, 4 May 2023 09:33:17 GMT Received: from eur05-db8-obe.outbound.protection.outlook.com (mail-db8eur05lp2113.outbound.protection.outlook.com [104.47.17.113]) by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3qc7rj8mwg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 04 May 2023 09:33:17 +0000 Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23) by PAWPR03MB8914.eurprd03.prod.outlook.com (2603:10a6:102:332::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.25; Thu, 4 May 2023 09:33:12 +0000 Received: from PA4PR03MB7136.eurprd03.prod.outlook.com ([fe80::bcf5:cd14:fd35:1300]) by PA4PR03MB7136.eurprd03.prod.outlook.com ([fe80::bcf5:cd14:fd35:1300%4]) with mapi id 15.20.6363.022; Thu, 4 May 2023 09:33:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: beeaea84-ea5e-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cVYcjlctwyKuhngP4otlVbHV8rz8lvBwoZwDY9n1iwcEdfi6t8h+8wHaOnq6I930Qm66o5khLwoayspFAiSK3H21cyPWs2CmG7RjOAcUpztrZd24Mt0E76wKahgV4BEJKVn4VnLo9AfZPavA83qS8KbCftOqja1kMqZoZR5p2DXX0O03a5MOGwniXz7gDIH6clhUS5axQcAF42+kURIn6ImEZb6HqHnNS/PDzeI5PfkpBjxwy3lQy2lJUbkZ6NuWK96iwP20oeXpsTF2bIIOQqVEBl/o/cqBqZzKxNsIr3KZ4KIXIxTfkRBYPZLpeel2p9OwMSMpyCVilv4dks3wNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GDao+USfzRI6dC60XrUYVQ0VZ4TY5qoaErLxSCvXCag=; b=mn3TlgxCdcJO8Zwh+rqLpe3s/bLZb/6dnp7oLMKqHGOjD2OZ4PXPKwcuxDShHX558BxUm52wGOikNCrbtfBUntEOmvCzzTUsbp+EpsG09ZxFvnkoop3mR2Ybcq1jSK4r7X39zFIfhxrv5GtCGgUDLDI7Dv6N6xgo1EC5Yy+xrhEu/2lJGTkxU9TN4l0tFLwYkEOynZPTqU0i16JTbDZdWYe74P5kgxJnxdG4q0ZUN3jjCyiQtJgZLJvShAeu4+mIIh1uCR5LiPYGCgih6pPPVIZihTSd3hwr0BwdDt03y+osK8VT02Pcj1f7wJqaaYGf+AE3k9VgHHCoPO+lpyo8eA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GDao+USfzRI6dC60XrUYVQ0VZ4TY5qoaErLxSCvXCag=; b=D9RaDaA6gP+xPjNpWrPx/4hPrwNstN652ZI0foumcpv5FoTlVLb5KSwtQElnp5lbXPcrJrVLik/0ByfbqpFUNNubmhihTWULudQqxRvP4MAbe0vAedA8ZTv7l0UYYIE8+WppZUaH0D3W8Sc3ss5vH3wxv11Z19odwz3cR7+jVsWiap0Z9bFiiaeV3dOGj07Zf/G4liPX+zxTfbhS24GbwRtAMgMn4STUF55FcVGHLJSYXfBcj9qhzJZEWBYyryqXd97KMLHTk3o+OjXKlGnYe3yCcNbEtvfgYaAcFg12mKqj6V8BNpOqWfscX0Nd0fsXD+R23CbqJCi4ay9KDqR4tg== From: Oleksii Moisieiev To: "sstabellini@kernel.org" CC: Sergiy Kibrik , "devicetree@vger.kernel.org" , "julien@xen.org" , "linux-arm-kernel@lists.infradead.org" , "olekstysh@gmail.com" , "robh@kernel.org" , "robin.murphy@arm.com" , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v3 1/2] dt-bindings: arm: xen: document Xen iommu device Thread-Topic: [PATCH v3 1/2] dt-bindings: arm: xen: document Xen iommu device Thread-Index: AQHZfmttKueJIQgVZkeItcqDtfTLRQ== Date: Thu, 4 May 2023 09:33:10 +0000 Message-ID: <3fb45717-46a2-6465-ff3f-30a641ba67a4@epam.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PA4PR03MB7136:EE_|PAWPR03MB8914:EE_ x-ms-office365-filtering-correlation-id: d0857f72-4333-4e40-ac8f-08db4c8293b3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: t5AK+5C4amBvwaLBuawZcCJso0WltRlSi2f+bwrzJiukcy40CUQVRBVCuVjLpDIgjnU/F4DfrziHFvteMA7ArxCCv8u/7IQlxeU9scxiBPcNCTOoKl3dYuAaPJ47ntE3xXcS9Db72QqUSzogiobRiSVZBWttiLvTZxvIW395dR1eAy0zH4TxTSjzw3dUQVdGuD5h5PwPrtw0gSz9hABrMDeiR0KHUxmc0NgHQsEP+TJePDCXVrDCe41nTEOdf/RAGG0o22jBHbL3bpiLZQy2B8RPkvezsrJhbbDVYKo+oVzI1060/gNhiV3L3ZyOchmy5QCVizDTyFDamEaBVu5rPuTKtNyOXoSUa4AiaVZK2MzQCVKNWoj0T7ptw1U+I0TKlgbxrTq2DAbxyznQXIgZv0+h3jynWLyUrCiDd95Wttn8j4Eh8jNIZy88bQhTVco+0387gSfdq7KHRN5Pl2M8ka/tz3ZXFUqJiygZUSYf/BrrhB8s5+cUfjUKXFtlS7U66FmUITomTi8ZeEX3d//U9eC5lHGfqEVFryX63C/UNiluA7MuQAI+jANcxMTIhaEfQ2LSuqN8RECHrd1VnhkRRBBoGCtMGiGu4R5cOzlfJw3Wyt13sAwSIzM5CMsj7alqDV7YWIAjoASZa/ugMJbqAQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(376002)(39860400002)(136003)(346002)(396003)(451199021)(316002)(41300700001)(6506007)(186003)(2906002)(71200400001)(26005)(6512007)(31696002)(2616005)(6916009)(83380400001)(6486002)(4326008)(66946007)(76116006)(66476007)(86362001)(64756008)(66446008)(66556008)(91956017)(31686004)(4744005)(38070700005)(36756003)(54906003)(478600001)(8676002)(8936002)(5660300002)(122000001)(38100700002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?aitwdzl6QVZBMFMvVVkrSzRqaUpMcFNQaHRzaXdFeDRkdUE3NjFycjRiV0Er?= =?utf-8?B?VkNXRDJMd1BPS01Rd3pEWEZjTFl0RnRaN3FCRmRxWU1yUlRIWlIzZ2ozUFp5?= =?utf-8?B?NXhCdnpLUEZteGlEUlh0TVJVRnA2QXJ0b3F3QW43VitTVEY0L01jd0Z1V2VX?= =?utf-8?B?MG9TdTBLcEZYbnpJdHJmOFNrOGZIamFzVmxrWTgxUkVEUUFCOXd5N1hmRGNK?= =?utf-8?B?N2xUU01IVXdSZXloRWpUSExJK1A4Uis3ZmxpZ0xWYStyNnR4NldWTCtKaDVR?= =?utf-8?B?NnRyVEZZQ0FZbTJYbmk5RW5iZU9sdWJKOXM0RkMrVitlL1IxZ3Rmd1IrNGZh?= =?utf-8?B?aXB4MitXZlRNUTJHU3FvTllNS2tFNzE4WkgxUzdqaFlsMUE2MWdwWUtaakZK?= =?utf-8?B?Nm5ZNFlpSEllcWpFTDVtZHczdUpmRnhjcCtueEFzQjdSZnZIa2VYelBiNWFz?= =?utf-8?B?QUJYUUZRM3dTVktzOVRCYlRwRkJPNkV4cERlaVZGUlQ4Uk9xYjZQS2VvR1JS?= =?utf-8?B?RVMzbWxsUDRkVnZGQ29OSDhpY0tkVU1xeXlXSW1SNzNvY01kWEZuVmh6eHNk?= =?utf-8?B?QTBvUUgrYjdwR2Z2Vnlza0dxbGszWW5aQ3c5TmIvdVdnRGV2bUJkL3hBVTRy?= =?utf-8?B?Qk00b0d2RDI5cmRxWnhjYVFzRlV6Y21qY1BtdWVleXA3eWZoWk5SeTdQS1Ry?= =?utf-8?B?KzBZU2t5c2pFR3pxNHFWWHFFUHNVR3FKT0pTMndDNVR4ZFZNaTY1MWkvWVFt?= =?utf-8?B?YlNXU21BYndCS2lZZ3FkeHkvanAxd0tQTmJjdHRhbTdycG05VG9TNUVqWFZR?= =?utf-8?B?MjhWdmxuVC9URmZodnJVSk1jNG53QWtpNjcyZ2ZQUXdwOU92YjUxaFJYN2dT?= =?utf-8?B?dUF3WjdUNWh2d0d4K1NhbCttRlk1NE93cWltNUl5VVREVVBGY3ZCd0doYU40?= =?utf-8?B?UnZDMlZzUDJhdVRMYXd3YW1RQVJ2dVBUSmhGdkVpU1pFSDRRRFVxVFdRVVY0?= =?utf-8?B?VDIvZmNJaHFseTJrSEJqT0VoUEJJTHhBTklZOUNqK3JrUFljWE0ybDRRVnhI?= =?utf-8?B?WlRkNmgrWXRuMFJ4R3NGYUdWNmNTVVNCUWRpZlk0Y0E1Z2Y3dUtGWDJCMmxu?= =?utf-8?B?ZVZ1RHMxbFZZSEU4VHJrM2hyT1ZGb2JkY3IrQ2NJZFdGODVOelVqTnFTNEJo?= =?utf-8?B?TGZyK21DeEVDS3d1ZHVDSUJtMm9VL1hhUmV2d0V2VFc1MyswYm5rOXk4QXNJ?= =?utf-8?B?ZzIzcExlY2pRaGFGM29MNHhiaGYvUHhYZFdKczVBc0FLc2F3b1U3UHZEeHN3?= =?utf-8?B?RnB1eWM1YU81a0wza3kxOGswL3lGaWV0c20wZSs4WEl4K2IzbjZveWxJUVor?= =?utf-8?B?amw4dTh4My92OStuZmg5M0ZuN3JQbFR1cjJtN2JmZDhId2FHaW1RSUpNcUNC?= =?utf-8?B?Wi9ROWtNemVseURkQnZyZXRlSWpIak5MVmpnc1BENHNKRCtxclMxRzRVaTY2?= =?utf-8?B?T05Sc0NqeUgrZW5xdlE3WGo5bmJnSHorREdBL2IrZityTmhzWU5kSmEvOVJ4?= =?utf-8?B?aDlHUlZtOTBmczRuNGs4dGxQVnVCWkpKRUgwR3dzTzJ5azU4UTBETStERXo0?= =?utf-8?B?SHVqbGhOMnR1RytwdEV3cVB3ajZBOXdsSnp5TC9IVzhlOUt3bGJ3MUJENmIr?= =?utf-8?B?REkveml2K0dYRUhKSGF1UGo1eXZVYzQ0ei9aRGtCcjRwSnN0Z29scktCRUZh?= =?utf-8?B?SFp3ejdyUEtrdDEwZ2lGU0JRWEJhcmN6YmxZL3F3SVBjQStyNkVMcWxPTGNt?= =?utf-8?B?d3o0OXBzd01GbkN4Zmovd0k2UDJNUHdWK2ZtVDZOeEd2VDJha0tHTVArODRs?= =?utf-8?B?OFJ0VGFENWVWQU4vUDBDYk1wc0JQUmJaVzlncHFmdi9aQzl4Wlp2a1ZwTTg4?= =?utf-8?B?amNIQjREdFNFZS8vVGhQS1lZbVhUU0FaT0xKQ0IwV2N1TitOcnN0OXRJR2w0?= =?utf-8?B?R0FPVStDdVppT1pSK1lqemFjb0FES3FiS0dueU9oNHBDZW5WVitjWGI0MGJF?= =?utf-8?B?Vk9JaHB3QVI5ZFc2SHFIOEZGUWdlWTNjOVBQbS9ldmFhRHczZFpLdmlFZlJ3?= =?utf-8?B?UXlLeDVpOU43WWNlNm1uMWs3aVBqSEUxTndMNjYycEp2ZVBBM2lzM3B0cHN2?= =?utf-8?B?Zmc9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0857f72-4333-4e40-ac8f-08db4c8293b3 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 May 2023 09:33:10.9929 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eDAKFVIAj7b2qN9jgD/Yk9gWkFBBlrjNk/aD+yuAyPr6JtMCrGNUuke9ZZ+de7UGOvlLa71+rFzzz7XoHPbmu6ImSpaKuFKfzeNietFuFfs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR03MB8914 X-Proofpoint-GUID: vjyAbJriD-icjyqPmRKJL_QZO1Qh5wrr X-Proofpoint-ORIG-GUID: vjyAbJriD-icjyqPmRKJL_QZO1Qh5wrr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-04_06,2023-05-03_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=986 malwarescore=0 spamscore=0 adultscore=0 bulkscore=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 mlxscore=0 impostorscore=0 clxscore=1011 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2305040078 SGkgU3RlZmFubywNCg0KID4gVGhlIHRpbnkgInhlbixpb21tdS1lbDItdjEiIGRyaXZlciBjb3Vs ZCBiZSBiYWNrcG9ydGVkIHRvIHRoZSBzdGFibGUNCiA+IHRyZWVzLCBJIHdvdWxkIGltYWdpbmUu IE90aGVyd2lzZSwgZG8geW91IGhhdmUgYW5vdGhlciBzdWdnZXN0aW9uPw0KDQpUaGVyZSBpcyBz dHViIElPTU1VIGRyaXZlciBhbHJlYWR5IG1lcmdlZCB0byB0aGUgTGludXggS2VybmVsOg0KQ29t bWl0IDFjYTU1ZDUwZTUwYzc0NzQ3YTdiODg0NmRhYzMwNmZiZTVhYzRjZjUgKCJ4ZW4vZ3JhbnQt ZG1hLWlvbW11OiANCkludHJvZHVjZSBzdHViIElPTU1VIGRyaXZlciIgYWRkZWQgYnkgT2xla3Nh bmRyIFR5c2hjaGVua28uDQoNCkkgd2FzIGFibGUgdG8gdXNlIGl0IGFzIGFuIGVtcHR5IElPTU1V IGRyaXZlciBvbiBteSB0ZXN0IHNldHVwOg0KTWFkZSB0aGUgZm9sbG93aW5nIGRldmljZS10cmVl IGNoYW5nZXM6DQoNCnhlbl9pb21tdTogeGVuLWlvbW11IHsNCgljb21wYXRpYmxlID0gInhlbixn cmFudC1kbWEiOw0KCWlvbW11LWNlbGxzID0gPDA+Ow0KfTsNCg0KaTJjQGU2MGIwMDAwIHsNCglp b21tdXMgPSA8Jnhlbl9pb21tdSAweDA+Ow0KfTsNCg0KTWF5YmUgdGhpcyBkcml2ZXIgY2FuIGJl IHVzZWQgdG8gc29sdmUgdGhlIGRlZmVycmVkIHByb2JsZW0gd2l0aCBzb21lIA0KbW9kaWZpY2F0 aW9ucz8NCldoYXQgaXMgeW91ciBvcGluaW9uPw0KDQpCZXN0IHJlZ2FyZHMsDQpPbGVrc2lpLg== From xen-devel-bounces@lists.xenproject.org Thu May 04 09:56:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 09:56:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529658.824280 (Exim 4.92) (envelope-from ) id 1puVgj-0000KV-LJ; Thu, 04 May 2023 09:55:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529658.824280; Thu, 04 May 2023 09:55:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puVgj-0000KO-IC; Thu, 04 May 2023 09:55:49 +0000 Received: by outflank-mailman (input) for mailman id 529658; Thu, 04 May 2023 09:55:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puVgi-0000KI-3C for xen-devel@lists.xenproject.org; Thu, 04 May 2023 09:55:48 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0611.outbound.protection.outlook.com [2a01:111:f400:fe1f::611]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d7a67724-ea61-11ed-b226-6b7b168915f2; Thu, 04 May 2023 11:55:47 +0200 (CEST) Received: from DB8PR04CA0015.eurprd04.prod.outlook.com (2603:10a6:10:110::25) by AS8PR08MB6072.eurprd08.prod.outlook.com (2603:10a6:20b:296::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Thu, 4 May 2023 09:55:43 +0000 Received: from DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:110:cafe::34) by DB8PR04CA0015.outlook.office365.com (2603:10a6:10:110::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.25 via Frontend Transport; Thu, 4 May 2023 09:55:43 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT011.mail.protection.outlook.com (100.127.142.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26 via Frontend Transport; Thu, 4 May 2023 09:55:43 +0000 Received: ("Tessian outbound 99a3040377ca:v136"); Thu, 04 May 2023 09:55:43 +0000 Received: from b4f547a610d0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9F65F0B0-D926-43EF-899D-E88E5A2255D5.1; Thu, 04 May 2023 09:55:37 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b4f547a610d0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 04 May 2023 09:55:37 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by DU0PR08MB9558.eurprd08.prod.outlook.com (2603:10a6:10:44d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Thu, 4 May 2023 09:55:35 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::a4ab:cdfa:b445:7ecb]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::a4ab:cdfa:b445:7ecb%7]) with mapi id 15.20.6363.026; Thu, 4 May 2023 09:55:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d7a67724-ea61-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oT3cAAImx46iN9Cg877ANIWn8JL/IUJ158jZ8MQ4VBY=; b=eS5ZBkQziw7r33wwVJg6sx3NR+NAQ4wIb8+xPGsJU811DU9bxc/bi/VEb9/cwBVXZUnn7eJuAc3IOcUFoAkdiTNpZ8YNKQYVJQE3r4w68zHLJIru0ZtqGHW04nmjPAdSqQwUi8dwVPzjPSnWLthslcTrBpT5s+DfzPqCW3ek3Tg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 612cc924003d0784 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nRZyZRnXGhC9bUOUhhL2eebZ/6eLA7w27v0LsUOG5gJ7va5qvq/T8Gjp1uJKUNAWfEL0EcTsJ74jA20wlNfZ6WeB7VniAmKnMFHoUXd9MGDktHRY8oyAwuBIlqSW6+QWjjZwBczW9pv+YcGX1EdlAjc1GZFZSTimP3pnHR4U5sxis9ZqicUsjXFL8tu9qjLjp1ILPrs3FYz1iLs+0fXeW52CKXhdbtW9v8Usnvsx08iikbNtLTFmyMk+pploaqMlqUU4JvWc+08fRcORK1GMQfyK6UIprQxD8F/W6LeMDkjFaign2lU6stevtyJNQgr2hgbdllceGIbRmuFP0SldfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oT3cAAImx46iN9Cg877ANIWn8JL/IUJ158jZ8MQ4VBY=; b=dduKJGL8g/ek0QWvPyclcU1g6+FwgYI3Xi4iyD7OWatyGovEeIPW29kyhMWsvPKZFEDjxSNMFZ2E9FR5biQ00dnQcG88Aoh6hr61nwiZ3UbBh4OZxc1V1xPT2DCsVZ/T61R2fq/kaqxA4Bpdayti43c5ne52Uv5BcFwYN7vcsFsXFPr3Vn9MEuKO7r7KMw1Xf1A8RpqCAr7yUvqHzQrTGBR1gqyfpQwuHDxVbhRJYZbeURNfY0rSARX1QeMKXiU5JPW5xTpgp8VOuGeP1WSECTgDFfV7y4B6Ihr+D61NuJkUgYECWzvXynV3TwZSXCVB8kCvqf0Xk8I7SSC73fBrIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oT3cAAImx46iN9Cg877ANIWn8JL/IUJ158jZ8MQ4VBY=; b=eS5ZBkQziw7r33wwVJg6sx3NR+NAQ4wIb8+xPGsJU811DU9bxc/bi/VEb9/cwBVXZUnn7eJuAc3IOcUFoAkdiTNpZ8YNKQYVJQE3r4w68zHLJIru0ZtqGHW04nmjPAdSqQwUi8dwVPzjPSnWLthslcTrBpT5s+DfzPqCW3ek3Tg= From: Rahul Singh To: Stewart Hildebrand CC: Xen developer discussion , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm: pci: fix -Wtype-limits warning in pci-host-common.c Thread-Topic: [PATCH] xen/arm: pci: fix -Wtype-limits warning in pci-host-common.c Thread-Index: AQHZffQdsUu9XjzfjkKQkjxjNw1HC69J4TCA Date: Thu, 4 May 2023 09:55:35 +0000 Message-ID: <7E04E3DD-B260-49E4-8543-77BBF8715BCB@arm.com> References: <20230503191820.78322-1-stewart.hildebrand@amd.com> In-Reply-To: <20230503191820.78322-1-stewart.hildebrand@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7158:EE_|DU0PR08MB9558:EE_|DBAEUR03FT011:EE_|AS8PR08MB6072:EE_ X-MS-Office365-Filtering-Correlation-Id: 40dc0e22-1c9d-496a-1021-08db4c85b9d2 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: SR5rAQr7dIoqrJ2lQ6NyN7PzKmvjnIdOAJq07eIam7k4zv/i/pCHpEvMK7rA8lxfYYAlbtwQo4NI+qre28yF+ARSFuI/6OgObrtDVVXRjHqrs+SlHaOGaXrTGkShmAeZL4NLwLI2x2bRKdyEemAMwFCVePVlRExSRPLAoeMBMlfDQGB/AquhFH81etvrAEp8+ccH66FnCvyRFogEK/BjIIG7zKAWM7y+sv+pWZJm09HS89tA9Jv0o4JV6J+hLTn48d2b0tVW1GPFMCmrYchDVgOUqsYaOZz3T7HGq0v0/ho0KEeoMVWoKjYcmcdHfMJJBmBnM/MKKTI9dtUxcU6wHikxxyQGEsjSwRnQggrCzKTIJimeo8xEEsh2jY/SCBzJ7sil0TGdpp6QMicRORSBcf4Zq/8oEZsClBeAPXrQuIRYh4tCnbK2UvB7HxuBsrR3gQHUTlLqfs3zSk+AFzs2jRLwn5j33itZgB+bBMDB0G9HeFEHZmsYCF4AOUnNPEITLMwGCGHObDm8irx06atgn22wAYMvYterzkZFcW9d+qsAa2XUgILws7OkCC9lfyygpJeQBTzXi1GWuD603DFWdHkaR5w+ao4voVRKhmWaRueGjHZIkDVt6oAvHIFsvYexQu+/k0JqNl0CZ6OYxoskNg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(39860400002)(346002)(376002)(396003)(136003)(451199021)(66446008)(76116006)(2616005)(83380400001)(478600001)(186003)(91956017)(66556008)(54906003)(4326008)(64756008)(66476007)(6916009)(66946007)(53546011)(6486002)(26005)(71200400001)(6512007)(6506007)(316002)(8676002)(41300700001)(8936002)(5660300002)(2906002)(38100700002)(122000001)(4744005)(38070700005)(36756003)(33656002)(86362001)(45980500001);DIR:OUT;SFP:1101; Content-Type: multipart/alternative; boundary="_000_7E04E3DDB26049E4854377BBF8715BCBarmcom_" MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9558 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 49159545-3040-4820-4e7e-08db4c85b54d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UGaVWNNv+G6KBOwrDxGA3y72xZPqQ7Zh3dG9SSOYdEJYSATrINUBTJsEh4zgRncGfve+g4eQNR7efJQnZiEeQsgW/do+kszhI3tG0VsUGqMKQmRqBL/qLh19+Z4tmBF9oVqeAwdLO3J55J1YR7ganE0AXtBAc/TvuU/PFHv/9tG0uZkOXJPrbeO5XlOJWSx2VfWiaqzH0UEzLe1SZ5r/o3pdfAOpnr5w4PJDJ52SlgyGWlIqmjEwQ8WNHuIwVLGflHBu135NFPT4KXIv/I40O0TNo/UGKsx8Sp75pctFlyaNneMniy5RQpb/GtyP0uTUqdZcvB9pvroCO74TMUmG/yjy24lX21+YmiEfDFC0NEDtdT6+pdUKS+rFhzpAUlI9mC0D7IXPRCW44Ectq/NEjXyXJmduBXLIZkXLT8jWOFYcu1JVT9Rw6s00u6n7NMU6XI/sgp3av8mEOZGXZjvfmlp8S25RoSyTKfNTo60cA3dWs4I7yNTQkNcY9spnSzULf+02G53Tkw8CnELYnWV7Mqjt2lO1KTy/DLTISdnDkq2YDoElCJ2ffMHnRYB1ez0/9qNz4PehzQylBkNMudqsmOwlRMIQypbkSok2FBb03odcgKprPT8RdmNS8NPdSyXJWb2pTPdbeFGQhyMtVKINy9zrEpZW5IoW+yJ4KZVN625QJxyV/JaVIQxU+NYkXqjhj96oeq2iNBjrSRjCgfQURM3yVTvA6IXCRdsLyvchnhQ= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(136003)(396003)(346002)(451199021)(46966006)(36840700001)(40470700004)(40480700001)(45080400002)(478600001)(86362001)(34020700004)(107886003)(40460700003)(336012)(83380400001)(53546011)(47076005)(26005)(36860700001)(186003)(6506007)(6512007)(36756003)(2616005)(82740400003)(6486002)(82310400005)(33964004)(81166007)(33656002)(356005)(54906003)(6862004)(5660300002)(41300700001)(8936002)(8676002)(2906002)(316002)(70206006)(70586007)(4326008);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 09:55:43.4970 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 40dc0e22-1c9d-496a-1021-08db4c85b9d2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6072 --_000_7E04E3DDB26049E4854377BBF8715BCBarmcom_ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 SGkgU3Rld2FydCwNCg0KT24gMyBNYXkgMjAyMywgYXQgODoxOCBwbSwgU3Rld2FydCBIaWxkZWJy YW5kIDxTdGV3YXJ0LkhpbGRlYnJhbmRAYW1kLmNvbT4gd3JvdGU6DQoNCldoZW4gYnVpbGRpbmcg d2l0aCBFWFRSQV9DRkxBR1NfWEVOX0NPUkU9Ii1XdHlwZS1saW1pdHMiLCB3ZSBvYnNlcnZlIHRo ZQ0KZm9sbG93aW5nIHdhcm5pbmc6DQoNCmFyY2gvYXJtL3BjaS9wY2ktaG9zdC1jb21tb24uYzog SW4gZnVuY3Rpb24g4oCYcGNpX2hvc3RfY29tbW9uX3Byb2Jl4oCZOg0KYXJjaC9hcm0vcGNpL3Bj aS1ob3N0LWNvbW1vbi5jOjIzODoyNjogd2FybmluZzogY29tcGFyaXNvbiBpcyBhbHdheXMgZmFs c2UgZHVlIHRvIGxpbWl0ZWQgcmFuZ2Ugb2YgZGF0YSB0eXBlIFstV3R5cGUtbGltaXRzXQ0KIDIz OCB8ICAgICBpZiAoIGJyaWRnZS0+c2VnbWVudCA8IDAgKQ0KICAgICB8ICAgICAgICAgICAgICAg ICAgICAgICAgICBeDQoNClRoaXMgaXMgZHVlIHRvIGJyaWRnZS0+c2VnbWVudCBiZWluZyBhbiB1 bnNpZ25lZCB0eXBlLiBGaXggaXQgYnkgaW50cm9kdWNpbmcgYQ0KbmV3IHZhcmlhYmxlIG9mIHNp Z25lZCB0eXBlIHRvIHVzZSBpbiB0aGUgY29uZGl0aW9uLg0KDQpTaWduZWQtb2ZmLWJ5OiBTdGV3 YXJ0IEhpbGRlYnJhbmQgPHN0ZXdhcnQuaGlsZGVicmFuZEBhbWQuY29tPg0KDQpSZXZpZXdlZC1i eTogUmFodWwgU2luZ2ggPHJhaHVsLnNpbmdoQGFybS5jb208bWFpbHRvOnJhaHVsLnNpbmdoQGFy bS5jb20+Pg0KDQpSZWdhcmRzLA0KUmFodWwNCg0K --_000_7E04E3DDB26049E4854377BBF8715BCBarmcom_ Content-Type: text/html; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 PGh0bWw+DQo8aGVhZD4NCjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0i dGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4NCjwvaGVhZD4NCjxib2R5IHN0eWxlPSJvdmVyZmxv dy13cmFwOiBicmVhay13b3JkOyAtd2Via2l0LW5ic3AtbW9kZTogc3BhY2U7IGxpbmUtYnJlYWs6 IGFmdGVyLXdoaXRlLXNwYWNlOyI+DQo8ZGl2IGRpcj0iYXV0byIgc3R5bGU9Im92ZXJmbG93LXdy YXA6IGJyZWFrLXdvcmQ7IC13ZWJraXQtbmJzcC1tb2RlOiBzcGFjZTsgbGluZS1icmVhazogYWZ0 ZXItd2hpdGUtc3BhY2U7Ij4NCkhpIFN0ZXdhcnQsPGJyPg0KPGRpdj48YnI+DQo8YmxvY2txdW90 ZSB0eXBlPSJjaXRlIj4NCjxkaXY+T24gMyBNYXkgMjAyMywgYXQgODoxOCBwbSwgU3Rld2FydCBI aWxkZWJyYW5kICZsdDtTdGV3YXJ0LkhpbGRlYnJhbmRAYW1kLmNvbSZndDsgd3JvdGU6PC9kaXY+ DQo8YnIgY2xhc3M9IkFwcGxlLWludGVyY2hhbmdlLW5ld2xpbmUiPg0KPGRpdj4NCjxkaXY+V2hl biBidWlsZGluZyB3aXRoIEVYVFJBX0NGTEFHU19YRU5fQ09SRT0mcXVvdDstV3R5cGUtbGltaXRz JnF1b3Q7LCB3ZSBvYnNlcnZlIHRoZTxicj4NCmZvbGxvd2luZyB3YXJuaW5nOjxicj4NCjxicj4N CmFyY2gvYXJtL3BjaS9wY2ktaG9zdC1jb21tb24uYzogSW4gZnVuY3Rpb24g4oCYcGNpX2hvc3Rf Y29tbW9uX3Byb2Jl4oCZOjxicj4NCmFyY2gvYXJtL3BjaS9wY2ktaG9zdC1jb21tb24uYzoyMzg6 MjY6IHdhcm5pbmc6IGNvbXBhcmlzb24gaXMgYWx3YXlzIGZhbHNlIGR1ZSB0byBsaW1pdGVkIHJh bmdlIG9mIGRhdGEgdHlwZSBbLVd0eXBlLWxpbWl0c108YnI+DQombmJzcDsyMzggfCAmbmJzcDsm bmJzcDsmbmJzcDsmbmJzcDtpZiAoIGJyaWRnZS0mZ3Q7c2VnbWVudCAmbHQ7IDAgKTxicj4NCiZu YnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwO3wgJm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5i c3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7 Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5i c3A7Jm5ic3A7Xjxicj4NCjxicj4NClRoaXMgaXMgZHVlIHRvIGJyaWRnZS0mZ3Q7c2VnbWVudCBi ZWluZyBhbiB1bnNpZ25lZCB0eXBlLiBGaXggaXQgYnkgaW50cm9kdWNpbmcgYTxicj4NCm5ldyB2 YXJpYWJsZSBvZiBzaWduZWQgdHlwZSB0byB1c2UgaW4gdGhlIGNvbmRpdGlvbi48YnI+DQo8YnI+ DQpTaWduZWQtb2ZmLWJ5OiBTdGV3YXJ0IEhpbGRlYnJhbmQgJmx0O3N0ZXdhcnQuaGlsZGVicmFu ZEBhbWQuY29tJmd0Ozxicj4NCjwvZGl2Pg0KPC9kaXY+DQo8L2Jsb2NrcXVvdGU+DQo8ZGl2Pjxi cj4NCjwvZGl2Pg0KPGRpdj5SZXZpZXdlZC1ieTogUmFodWwgU2luZ2ggJmx0OzxhIGhyZWY9Im1h aWx0bzpyYWh1bC5zaW5naEBhcm0uY29tIj5yYWh1bC5zaW5naEBhcm0uY29tPC9hPiZndDs8L2Rp dj4NCjxkaXY+PGJyPg0KPC9kaXY+DQo8ZGl2PlJlZ2FyZHMsPC9kaXY+DQo8ZGl2PlJhaHVsPC9k aXY+DQo8L2Rpdj4NCiZuYnNwOzwvZGl2Pg0KPC9ib2R5Pg0KPC9odG1sPg0K --_000_7E04E3DDB26049E4854377BBF8715BCBarmcom_-- From xen-devel-bounces@lists.xenproject.org Thu May 04 10:11:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 10:11:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529663.824290 (Exim 4.92) (envelope-from ) id 1puVvQ-0002wS-3i; Thu, 04 May 2023 10:11:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529663.824290; Thu, 04 May 2023 10:11:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puVvP-0002wL-Vv; Thu, 04 May 2023 10:10:59 +0000 Received: by outflank-mailman (input) for mailman id 529663; Thu, 04 May 2023 10:10:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puVvP-0002wE-3P for xen-devel@lists.xenproject.org; Thu, 04 May 2023 10:10:59 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puVvN-0002PT-D6; Thu, 04 May 2023 10:10:57 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.4.157]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1puVvN-0000CW-59; Thu, 04 May 2023 10:10:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=0wRa0wnni9ASFXBeskJw0fRv7Mml4oo/YTejwSsw2C0=; b=gVvOXfcivJlVrxfzILrEreJ/N3 WWzt0793nq4JvBqMou8IzQkt0+igNSK31QmUt1L8+P1nyeNmN03BvxWvISVXSuBE+/mo2zbQ8ZUnZ yO7d76MFKkOOyi8NnvbCmS8CG/jCfl2PJXqqT3vgQfZGQuRrJdJgqfa6GNO+yWdaQYSM=; Message-ID: <4ca00734-8e1e-fe5b-b2a0-6f08f3835433@xen.org> Date: Thu, 4 May 2023 11:10:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] xen/arm: pci: fix -Wtype-limits warning in pci-host-common.c Content-Language: en-US To: Bertrand Marquis , Stewart Hildebrand Cc: Xen-devel , Stefano Stabellini , Volodymyr Babchuk References: <20230503191820.78322-1-stewart.hildebrand@amd.com> <5D298044-314C-473F-97AB-420DA3DA44A2@arm.com> From: Julien Grall In-Reply-To: <5D298044-314C-473F-97AB-420DA3DA44A2@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 04/05/2023 09:59, Bertrand Marquis wrote: > Hi Stewart, > >> On 3 May 2023, at 21:18, Stewart Hildebrand wrote: >> >> When building with EXTRA_CFLAGS_XEN_CORE="-Wtype-limits", we observe the >> following warning: >> >> arch/arm/pci/pci-host-common.c: In function ‘pci_host_common_probe’: >> arch/arm/pci/pci-host-common.c:238:26: warning: comparison is always false due to limited range of data type [-Wtype-limits] >> 238 | if ( bridge->segment < 0 ) >> | ^ >> >> This is due to bridge->segment being an unsigned type. Fix it by introducing a >> new variable of signed type to use in the condition. >> >> Signed-off-by: Stewart Hildebrand > > I would see this as a bug fix more than a compiler warning fix as the error code was > ignored before that. +1. Also there is a missing fixes tag. AFAICT this issue was introduced by 6ec9176d94ae. > > Anyway: > Reviewed-by: Bertrand Marquis Just to clarify, you are happy with the current commit message? If so, I can commit it later on with the Reviewed-by + fixes tag. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu May 04 10:20:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 10:20:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529666.824299 (Exim 4.92) (envelope-from ) id 1puW43-0003e6-V9; Thu, 04 May 2023 10:19:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529666.824299; Thu, 04 May 2023 10:19:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puW43-0003dz-SI; Thu, 04 May 2023 10:19:55 +0000 Received: by outflank-mailman (input) for mailman id 529666; Thu, 04 May 2023 10:19:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puW42-0003dt-4J for xen-devel@lists.xenproject.org; Thu, 04 May 2023 10:19:54 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3350d690-ea65-11ed-8611-37d641c3527e; Thu, 04 May 2023 12:19:50 +0200 (CEST) Received: from mail-dm6nam12lp2168.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 May 2023 06:19:42 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DS0PR03MB7204.namprd03.prod.outlook.com (2603:10b6:8:122::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Thu, 4 May 2023 10:19:40 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb%4]) with mapi id 15.20.6340.031; Thu, 4 May 2023 10:19:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3350d690-ea65-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683195590; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=JwqknuLbanHrBbQKXOwppLLuBzXBLyYx3ASMR+/7AdY=; b=G4DXBrLpLeaCtP+7Z+LEOmxZlmw4aQrKty877oac9GmQkhF41t9b1p6y aGuLTQUPT9Dp/nvkKSFoV7kf74R7kz68Y/DhqECNUkAGK5uh8LNDsQvYt lLiQI3JLALYXGoSKjsq/EsumBF7wIm2wn8M+qNP7DqA9DmtLatMSBCEjs E=; X-IronPort-RemoteIP: 104.47.59.168 X-IronPort-MID: 107165809 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Lfba7a6RpHkqwylLbcBhYQxRtBXGchMFZxGqfqrLsTDasY5as4F+v moWXzjTOP7eN2WmfIp1Ydjk8UMGvMTWz9Q2HVE//nw8Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+7ZwehBtC5gZlPa0T4AeH/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5ms vEcMTkcdAu5hLiT752rSM5vu84zM5y+VG8fkikIITDxK98DGMqGb4CUoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OnUoojuiF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNtKS+Tmq64y0TV/wEQuGkYobAW9scKZsUm0ZeBtM X5IoSoX+P1aGEuDC4OVsweDiHyOswMYWtFQO/Yn8wzLwa3Riy6GAkAUQzgHb8Yp3OcmSDpv2 lKXktfBAT10rKbTWX+b7q2Trz65JW4SN2BqWMMfZQ4M4t2mrIRtiBvKF4xnCPTs0I2zHizsy TeXqiR4n68UkcMAy6S8+xbAni6ooZ/KCAUy4207Q16Y0++wX6b9D6TA1LQRxa8owFqxJrVZg EU5pg== IronPort-HdrOrdr: A9a23:5/cgh6iawKCwC+NFcdqiYLwm5HBQXt4ji2hC6mlwRA09TyXPrb HLoB1773/JYVkqM03I9errBEDiexLhHPxOjrX5Zo3SOTUO0VHARL2Ki7GO/9SKIUPDH4BmuZ uJ3MJFebrN5fQRt7eY3OEYeexQouW6zA== X-Talos-CUID: 9a23:C0mGJWzTvvumcMh0DiuqBgVTF8Q8e2zH103TeWqXJnZrb76oQ0+PrfY= X-Talos-MUID: 9a23:RwYfswWURKRbhTnq/AL+3w9basF42ISVD0ozo6cciZXfNRUlbg== X-IronPort-AV: E=Sophos;i="5.99,249,1677560400"; d="scan'208";a="107165809" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tuv1ZuCnvtBzUSePmJXJUxaH9PCNvJ0LqMyhV+dojnUMgwO2e26uBm7Ax14w995PaLXfygWAa8KtLAsJZcoF6ycpyoXpdWBFJstq7LJ/SgW2pOh7qDfn1VDAk50iLYCD93JkeOuHS7ijm7dTaYHkrfBAiuxe40kYiGC5ngm1S7zZ+p4+QBY8Q2+2YaikjNhoEFo1a+CvTIc9nwMBPGywpKQgZ87bL4HRV3O9ArvGrlv76CLOrtOLBTWsECI2zZRQQe9Vo59gQqnzwl/ICRuR2azI91Ul8YUxunXMChQaB9w1GmfhYrqG4BadkK9CWti2AHNKQAuXeTsT67AzuodlOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JwqknuLbanHrBbQKXOwppLLuBzXBLyYx3ASMR+/7AdY=; b=V+Rw0mEnOsWiWwmnx+uXR6fNQbeWHMVLqfpFDbhH2jTtZNvgiFxGxl9AYjC+2TcfOqmsnAY870pGp3MWLdT4/PU/c64/u0EJapeNcqEXKHMPtr9RQrGdcNdutkQUcbGZZ/hGiX+wlqJgd1Ii+4CAgNcAAHvkkqx0QftLzWMMcPtQz5uJ2MC73/hFy7849IwJTKDifYG4GZ/cAW6xlJAKtsZckvXnxRxUXcPVTh0EzqRwqoGDtPI6NIB4ulHqlqROtVoAT4yyobsqW7NAmm3Ci+TSjUYDvLWGxRRp/F9SYUOIQuPeh+wNFF4TQXyvu9cVLPu8SZ62MA5czRH0R5kVxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JwqknuLbanHrBbQKXOwppLLuBzXBLyYx3ASMR+/7AdY=; b=bAR8YnmgTWwBXB9AydGWE8UqgTBuSUeTcWIdMGOaGQ7mifkOJG3tBqGFbSGxRXF4hfxqETeQDLN9bChic1SnLaQeV7tlw5R/EMSu8i+3sW9PZ2UN23Io+fxEKYdGkgfeM4fUCFfUSyZ9nWoS26rzOFv1zHt+DAsARbJf8ot/zk4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <82bca889-e412-c71c-a680-8cc1530cc06b@citrix.com> Date: Thu, 4 May 2023 11:19:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: Andrew Cooper Subject: Re: [PATCH] x86/ucode: Refresh raw CPU policy after microcode load Content-Language: en-GB To: Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230503185813.3050382-1-andrew.cooper3@citrix.com> <2b125ebf-53ed-27a9-2f04-be2a6cac7fd0@suse.com> In-Reply-To: <2b125ebf-53ed-27a9-2f04-be2a6cac7fd0@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0006.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ad::20) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|DS0PR03MB7204:EE_ X-MS-Office365-Filtering-Correlation-Id: 1bc68f9b-df22-42ee-d8a2-08db4c891207 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 15z0UuX5BGWx+LZuycy4syS3WvJru07IMNY+UvO8lg0Wx/VX7eYh/b5pQ0UX/8Jgoor4E6WYNFtI/IN5TPlG2eRnSVDRhe0WS5d1kb2ag5Qc8xnevjOQPsH8ebw0dM7xHTeZSChLjli/FF7HIROInzUvKM58VEyGr6fCO1RjZzwH24VDkMWw5jsDVJnUUVeGDAdPf+t37b4/Q0Z9vWjfMqth9F3ZaADOlCQcwgGIoqjsqx4w2+VqdneWhz7En+ifKQmMWXbWqHykdR4ptI9zp/d2VB80Lst+J+YzgnDgXuStQRGaM3UEw06GJT9jcEURKeK60W2Rkw8Topi3YKLs5nPqcSsYRyonZ1w2ZKAosExx0W1ke7YUsfA7m4JLDsyYAcZQY3HMU1PUjPTay2wn8JbZUrZAZXvvaFLnKNXyoEjmGYY4/cTudwbqvUu7Giz0AwHgMGnTsG2XevUqd2fQC3L79a1Xdz9jtkhACYcMyVXEcmoF9T/xIWh2IqHNSfxPpGnfQ9Ko3VXVhXJ2rdkSx0e6KWB0BMsCIwbPIODsLpV1ityYNowgQAvNFOmLa/EvBigKItZLC9WSIi71zI+5NWbF4HMzH1Bxr5fkikbNhrA7kg3U+MTXMP3u2DICS6Ite2dARiuuaZdv33DJ8wSOWw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(39860400002)(136003)(376002)(396003)(346002)(451199021)(31686004)(36756003)(5660300002)(38100700002)(2906002)(8936002)(31696002)(316002)(86362001)(8676002)(66476007)(66946007)(4326008)(66556008)(41300700001)(6916009)(82960400001)(83380400001)(186003)(6512007)(6506007)(26005)(53546011)(6486002)(478600001)(2616005)(6666004)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z0lxU0NzR2dhakU0bVFGZmpWNTVHbzFOK09hc0xQRnFJdDc5TFQ5NFVjVHA2?= =?utf-8?B?NTVoaEswcmxGWTR6bTR5c2RhSm9zTGE3aU1sVEJrRmdiLyt2a0k0WGdyQWNS?= =?utf-8?B?M1YvbGw2cG1DZWMvZW0yaVU1RDhPQlFkQS94V0x0VFFHUXl6VlErZ04yK2wx?= =?utf-8?B?dnZuekhmRHl5OTVvWDV3T0F1WHRkeVJTa3pKM1Q0SDFlUUtiTXFSOHo0b3hF?= =?utf-8?B?b0NLbnFPUVVGWEJIRTFYcFREQ1Z2Q3dUSjRyS3JVTmhHZlQ0eEV4RUR1d3Ft?= =?utf-8?B?cWFxd2tubVRQOU5JYW5RVzduQnFpY2VSUkpQb1pHRFRhc2lSUWxOcm5ReHBN?= =?utf-8?B?NWdKeHF3Tlp1bkh4azlCNDA3Ky9aLyttaVYvV3NMSkd1WUJ2bzE2WTRsNnhB?= =?utf-8?B?M1lMcHE5L1p0cU9FUFlvQWw0a3hrNno4and4U1VzcGV3TmpCYjZTejVSZmlt?= =?utf-8?B?ZXlGQ3pTY1FzaGJDbjlRZFIvSEtxQzlYamhsbkNTUzZ5aEJ2Z3dWSXpVdlRj?= =?utf-8?B?eVRhNDk3VVU1aE43RW9NV1J6K2dPbUpBc3NOajdxVFp1VUZEQXltUFpJUGh3?= =?utf-8?B?MWJsQ0F3ZXhLZDdUTnpPUHF6TzlPQUs0YkFONDlHSWphTUFKbW5Nb1ZDTEFD?= =?utf-8?B?WGZkUlFsTWdsYXBnMEpaTTdKUGEwWThsWisyRlJYZTVpNDViYk8wbmFuZEhl?= =?utf-8?B?bjBPcmp4NVVDZDNEUFVIZTdRY3RnTklqUkRUWDFwRDgwWFdNTnFyUEE5enlH?= =?utf-8?B?dEN5UGQ4Ym03cDZOaTVnK2xwYlhmRThFOHdKdklUSmdVN1NlRHU2WmdzR3hL?= =?utf-8?B?dUNQS3BqK1Y3bHhrR0NBZUgwaDA0RFprNGdZUWVNNkZZcmhKYmJ0dHRZMnk0?= =?utf-8?B?YWMxbTlZTi9mZi9XTHVwekVzTXp6cS83SCtVYnhVb2ZNNlBTK0RLQmtmbzJ1?= =?utf-8?B?S3NwYk5HZDlDOTEySlEvd3Q2UUllSWJrMW5tSlpTSXhYb1FXY1Fvd3ZnRGs4?= =?utf-8?B?cHV2Y0wrYWI4ZW5UTmNMTTlmTVFscVVoTG5jY2JYRERkbWUrNFRobU1VSWN2?= =?utf-8?B?T0R3bHp2NXJQTU9YOWd0U05KL014VzBNQzE5aHNaWjNCb2NLWTNLZk54ZzN5?= =?utf-8?B?NEFsNG93eFZmSFE2RDFNSUV3Q1pWck1HYlZQMlpWdzN3ano4UW83enpsWDVu?= =?utf-8?B?blVYY2NqRGRUckxNTEVmbTlvYnRBQytMUmNEd2JrMmNEaDFnM01OYkZ4a3Vu?= =?utf-8?B?SWZ2ZllhWXNDTk00UHpRWC8yQS83TjRGN2M2WXJEYStyRm9qWXhhNjg4WHVK?= =?utf-8?B?TW1jc1B6ZkFnVnNPQnhQbERFM1lMRDF0YXV1Rkh0YzdEcWR3Q2l6OWtUZC9R?= =?utf-8?B?eU15d0ZFZ04rT3dYbExQblVSeWZ5N2s0OHY5RzJxbFdlYVptZXVWRzlxdVE3?= =?utf-8?B?Z3Nzdi9Xdy9ZSmZCMTJWbUFNZnFzNU4xSk9RaEdtTVIzQkwwNThmdzJBU04v?= =?utf-8?B?NndYc0FBdy9NRUJNb3ZGb3E0SXBKL3ZsN3lWeUhzS0YzNWFBalhtUkM0MCt5?= =?utf-8?B?Tk5ZSlZ5MWxYVXo2TGtVbU1nc0l2blpzVUp5dURjemVSd0dMS2RVYVRPNWRq?= =?utf-8?B?czhucmJScEF5bkkxUTRIS2hUT3E5TmdxNGV1Qk9JakpnaW4ranM0UHh1NUp4?= =?utf-8?B?K05XRmdOZGU0N1hjbWl4Z0plYUdRK1J0NzludlVOc240aFRhMm5MaGNEdlVu?= =?utf-8?B?cFpuMjd5T0tld01RV2dneG5SdDJsNWVvS3dGeXhQdStDSC9rNTBCa1RaSG1Z?= =?utf-8?B?UkVhd3huUUVGOWR3SStCenhSRE9ZcE5WWW4xUmFuVE9jSGkxMklONGVLMG5K?= =?utf-8?B?ZUVyYnkzVDVDN3Y3cGRqTmt5TkwzSnpXRkRiN3F1akkzNk5MWXZtZzY1bGYz?= =?utf-8?B?NlRWdE5teEx5WVVCWDcyb1llSHl0TUxseTlYemJKKytWdHNIaDFaRVduVldr?= =?utf-8?B?RlFrSVpQUzRGS2dsZURERUo2VkhOM1dzKzFJUnhjSmRBdGpJWnF6THBOQksv?= =?utf-8?B?K0VieFhrOVRScEg0ZUdjbE9GWHJSMENpS25GRXZ4WEl3eFpQQlBvZWgxSmVu?= =?utf-8?B?R0ZFNTJxdEFLN20rQnMzZ0dla2I1YTdlQnRzMGk2VVAxNXZVTC9GbmU5OS9s?= =?utf-8?B?cEE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ZzBW7gUI2ksla1pMXxwucoxKXpTT7hwMPngptL2C8QqpTZZyADsxTAdlWhUQoZgEqXk1zYaw6hMfbpyUqyHO5Q+higWVZEceYNRlqZ1bjwhbY+/U+4i7Slh+9ILbGxHzFTDp5dMELzjlbf0wJtRO+jZ0N9jMej/5ZIfqTWX9mh9NDgaOzsfsauuekwagyul/w+K8jwIpzgYw/fb9013nKJfUyq1huIVAF2WMbl2cn4EUEw52FbjtCqSgNou+3D2KciiorEqJ0eQqUXGnJ0P3j3wmtWlX6Bh1OY+G0AqlJDuKfquw1X1EbsT/RAl6HfojCM5E0ci9WBPsxp42go8r1uZWv6kFew1nH5EIl8whv/h2cG66jrS9pStEFA1o74WwskKiUwfQcaeSCn5eAyth+j0MFUOE5MGNNsFj7wAh7D+eY+9Wd0qJvhU/64f0AcNNXUP+JVfSMofotaWKdzBzx1N1kWAxpOojx4fqvomCWNZxIxcje9LGSnPBTOuXdyOh9CqS7a11lUkugB+7PogLFfmcvbrdESV0g17D4nz1HlgWQ0fNnvP1bz7jXO4bAprV8uQ8ztgRR/eUPYrBpOo/RO3IWshEO9UKKzgV4hJqyaA4NPOn2mBDRtlnTsM99r8pQKZApcMvVMnSC0J0gNFM5r8xptFfQ50Uui0a828hdQF3bXFvZtZGSoJdW5Z/zL2anRElN887EdeiIa40QECMolfd2TP0NInTqoUJZ14sToqfQ+77O818GYPYcWQ3xLFQEV3ztGBHL6Tm8PSmWM7uwztlRKCH/F4gF5X3z1aqJSBXkJ6KmuidlQhmWF/I+jxt X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1bc68f9b-df22-42ee-d8a2-08db4c891207 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 10:19:40.2397 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: L7nUFkuLJE2m46bjhYR5FtZKrZBphZd4/JRx+QzduRtN4ut5dEnlL08FweL0LGjmgHxcRxu3FaEyyRi5cCfjlcS3rHdhorqdylBl3tu3CxM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR03MB7204 On 04/05/2023 9:17 am, Jan Beulich wrote: > On 04.05.2023 10:08, Andrew Cooper wrote: >> On 04/05/2023 8:08 am, Jan Beulich wrote: >>> On 03.05.2023 20:58, Andrew Cooper wrote: >>>> Loading microcode can cause new features to appear. >>> Or disappear (LWP)? While I don't think we want to panic() in this >>> case (we do on the S3 resume path when recheck_cpu_features() fails >>> on the BSP), it would seem to me that we want to go a step further >>> than you do and at least warn when a feature went amiss. Or is that >>> too much of a scope-creeping request right here? >> You're correct that I ought to discuss the disappear case.  But like >> livepatching, it's firmly in the realm of "the end user takes >> responsibility for trying this in their test system before running it in >> production". > Okay, with the case at least suitably mentioned > Reviewed-by: Jan Beulich Thanks, >> For LWP specifically, we ought to explicitly permit its disappearance in >> recheck_cpu_features(), because this specific example is known to exist, >> and known safe as Xen never used or virtualised LWP functionality.  > Right, but iirc we did expose it to guests earlier on. And I've used it as > a known example only anyway. Who knows what vendors decide to make disappear > the next time round ... It's true that we used to expose the CPUID bit to guests, but IIRC we never virtualised it correctly which was my justification for hiding the feature bit when I was doing the original work to rationalise what guests saw.   Removing LWP was an extraordinary situation, and AMD didn't do it lightly. What they did was sacrifice a fairly expensive LWP errata workaround to make space ucode space for IBPB instead.  They hid the CPUID bit (and specifically by modifying the CPUID mask MSR only) because there were no known production users of LWP, and a consequence of the patch, an errata got unfixed. On real AMD systems which used to enumerate LWP, and subsequently ceased to, it was only "normal virt" levels of feature hiding.  The LWP CPUID leaf still has real data in it, and you can still use %xcr0.lwp, and the LWP MSRs still function. Software which was genuinely using LWP, not tickling the errata case, and late loaded this patch wouldn't actually have anything malfunction underfoot. >> Crashing on S3 > I may guess you meant to continue "... is bad anyway"? Oops.  I was clearly in a rush for my morning meeting.  What I meant was "we probably shouldn't crash on S3 resume in this known-ok case". ~Andrew From xen-devel-bounces@lists.xenproject.org Thu May 04 10:26:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 10:26:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529670.824309 (Exim 4.92) (envelope-from ) id 1puWAM-00058r-Kd; Thu, 04 May 2023 10:26:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529670.824309; Thu, 04 May 2023 10:26:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puWAM-00058k-I4; Thu, 04 May 2023 10:26:26 +0000 Received: by outflank-mailman (input) for mailman id 529670; Thu, 04 May 2023 10:26:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puWAL-00058e-JM for xen-devel@lists.xenproject.org; Thu, 04 May 2023 10:26:25 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1d772e04-ea66-11ed-b226-6b7b168915f2; Thu, 04 May 2023 12:26:23 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d772e04-ea66-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683195983; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=6RwmabpMbB9/J7uHjepa/CNpM2RIXnmAeogNAZikKco=; b=TuSfCwHATmp8MXXwZ5jLwzFeWl38witb2GFd9ZojyVcHgeErjcxJOybk GvWL8aq94kiGTt6ZZoqnGEYe/ZdYdMJVMqW9+GMdDLuoc1uSzjUsxXx3v MNEsbKjHgkDbONljid+KVRmTznSbY/bOhXKA7zNw2Sf5FaVyK3hoMIJ+j 0=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 106600554 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:9DOO6anr1QDCcLvkcDm14Xno5gzwJkRdPkR7XQ2eYbSJt1+Wr1Gzt xIdCGDVPPqOZjbxLowlOd+3phgEvZSDxtcxHVQ//CpnESMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aWaVA8w5ARkPqgW5AOGzhH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 eIkcQhTTj/cvvOv6o2FULhwo8clJsa+aevzulk4pd3YJfMvQJSFSKTW/95Imjw3g6iiH96HO ZBfM2A2Kk2dPVsWYAx/5JEWxY9EglHWdTFCpU3Tjq0w+2XJlyR60aT3McqTcduPLSlQth/A+ DyepzmkXnn2MvSvxRu5+GC2iNPG3j7ZWpxDPZKq+tV11Qj7Kms7V0RNCArTTeOColG6c8JSL QoT4CVGhbg/8gmnQ8fwWzW8oWWYpVgMVtxICeo45QqRjK3O7G6xBGIJUzpAY9wOr9ItSHoh0 Vrhoj/yLWUx6vvPEyvbr+rK62roYkD5MFPuewcacVI9vfnM/7gilzjwcMwyDIu2iNf6TGSYL y+xkMQuu1kCpZdVh/7jpAqX3G3ESovhFVBsuFiONo6xxkYgPdP+OdT1gbTOxawYRLt1WGVtq 5TtdyK2yOkVRa+AmyWWKAnmNOH4vq3VWNEwbLMGInXAy9hO0yT5FWyoyGsiTHqFy+5dEdMTX GfduBlK+LhYN2awYKl8buqZUpp6lvG8TY29Dq+FM7Kih6RMmPKvpnkyNSZ8IUi0+KTTrU3PE cjCKpv9ZZrrIa9m0CC3V48g7FPf/QhnnTm7bcmin3yaPU+2OCb9pUEtbAHfMYjULcqs/G3oz jqoH5HUk04DDbegM3m/HEx6BQliEEXXzKve86R/HtNv6CI4cI39I5c9GY8cRrE= IronPort-HdrOrdr: A9a23:EIk5NKEFVmwxkz/BpLqEPceALOsnbusQ8zAXPiFKOHlom6mj/P xG88526faZslkssQgb6K690cq7MBHhHPxOgbX5Zo3SODUO0VHAROsO0WKF+VPd8kbFh41gPM lbEpSWAueAamSTqq7BkXDIa6dasaO62ZHtpsPXz3JgVmhRGt1dBn9Ce3um+pMffnghOXIAfK DsmfavDADQCEgqUg== X-Talos-CUID: =?us-ascii?q?9a23=3AAJbbVWsZBulxo2xCSbnbbm+D6Is7TiTlklf/fHa?= =?us-ascii?q?pEExWdqfEVXqT/qlrxp8=3D?= X-Talos-MUID: 9a23:outa3ATo0obGXgzrRXTciBBePtVy7ZinS10vk4tXkuaWOQdvbmI= X-IronPort-AV: E=Sophos;i="5.99,249,1677560400"; d="scan'208";a="106600554" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2] x86/ucode: Refresh raw CPU policy after microcode load Date: Thu, 4 May 2023 11:26:07 +0100 Message-ID: <20230504102607.3078223-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230503185813.3050382-1-andrew.cooper3@citrix.com> References: <20230503185813.3050382-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Loading microcode can cause new features to appear. This has happened routinely since Spectre/Meltdown, and even the presence of new status bits can sometimes mean the administrator has no further actions to perform. Conversely, loading microcode can occasionally cause features to disappear. As with livepatching, it is very much the administrators responsibility to confirm that a late microcode load is safe on the intended system before rolling it out in production. Refresh the raw CPU policy after late microcode load appears to have done something, so xen-cpuid can reflect the updated state of the system. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu This is also the first step of being able to livepatch support for new functionality in microcode. v2: * Discuss disappearing features in the commit message --- xen/arch/x86/cpu-policy.c | 6 +++--- xen/arch/x86/cpu/microcode/core.c | 4 ++++ xen/arch/x86/include/asm/cpu-policy.h | 6 ++++++ 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/cpu-policy.c b/xen/arch/x86/cpu-policy.c index a58bf6cad54e..ef6a2d0d180a 100644 --- a/xen/arch/x86/cpu-policy.c +++ b/xen/arch/x86/cpu-policy.c @@ -15,7 +15,7 @@ #include #include -struct cpu_policy __ro_after_init raw_cpu_policy; +struct cpu_policy __read_mostly raw_cpu_policy; struct cpu_policy __ro_after_init host_cpu_policy; #ifdef CONFIG_PV struct cpu_policy __ro_after_init pv_max_cpu_policy; @@ -343,7 +343,7 @@ static void recalculate_misc(struct cpu_policy *p) } } -static void __init calculate_raw_policy(void) +void calculate_raw_cpu_policy(void) { struct cpu_policy *p = &raw_cpu_policy; @@ -655,7 +655,7 @@ static void __init calculate_hvm_def_policy(void) void __init init_guest_cpu_policies(void) { - calculate_raw_policy(); + calculate_raw_cpu_policy(); calculate_host_policy(); if ( IS_ENABLED(CONFIG_PV) ) diff --git a/xen/arch/x86/cpu/microcode/core.c b/xen/arch/x86/cpu/microcode/core.c index 61cd36d601d6..cd456c476fbf 100644 --- a/xen/arch/x86/cpu/microcode/core.c +++ b/xen/arch/x86/cpu/microcode/core.c @@ -34,6 +34,7 @@ #include #include +#include #include #include #include @@ -677,6 +678,9 @@ static long cf_check microcode_update_helper(void *data) spin_lock(µcode_mutex); microcode_update_cache(patch); spin_unlock(µcode_mutex); + + /* Refresh the raw CPU policy, in case the features have changed. */ + calculate_raw_cpu_policy(); } else microcode_free_patch(patch); diff --git a/xen/arch/x86/include/asm/cpu-policy.h b/xen/arch/x86/include/asm/cpu-policy.h index b361537a602b..99d5a8e67eeb 100644 --- a/xen/arch/x86/include/asm/cpu-policy.h +++ b/xen/arch/x86/include/asm/cpu-policy.h @@ -24,4 +24,10 @@ void init_dom0_cpuid_policy(struct domain *d); /* Clamp the CPUID policy to reality. */ void recalculate_cpuid_policy(struct domain *d); +/* + * Collect the raw CPUID and MSR values. Called during boot, and after late + * microcode loading. + */ +void calculate_raw_cpu_policy(void); + #endif /* X86_CPU_POLICY_H */ -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Thu May 04 10:32:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 10:32:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529673.824320 (Exim 4.92) (envelope-from ) id 1puWFo-0006d8-8I; Thu, 04 May 2023 10:32:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529673.824320; Thu, 04 May 2023 10:32:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puWFo-0006d1-4s; Thu, 04 May 2023 10:32:04 +0000 Received: by outflank-mailman (input) for mailman id 529673; Thu, 04 May 2023 10:32:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puWFm-0006cv-RU for xen-devel@lists.xenproject.org; Thu, 04 May 2023 10:32:02 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e7612373-ea66-11ed-b226-6b7b168915f2; Thu, 04 May 2023 12:32:01 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7EE3A209F6; Thu, 4 May 2023 10:32:00 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7C1EE133F7; Thu, 4 May 2023 10:31:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id sf/UHJ+JU2ShewAAMHmgww (envelope-from ); Thu, 04 May 2023 10:31:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e7612373-ea66-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683196320; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SysVoVEKW+NX4qyVGu/niFlwGn5aiW8M5/2sd3Frq6w=; b=juSzgQlFlUDuBImH9ZJN/4cvnNQiKW1CsIfyP7OnP0w5p0L5JLGR4eMvuerD53YtoDxppF iCPh2YubO9R5cvjksS70oKLJ4ICxj2GC8yaeouEoRVXZdyQ6AV7PLoLgCnqQ5JJ9R9/XXD TURNTorKdCr0S6/Vh9F0rphyrPDr8dI= Message-ID: Date: Thu, 4 May 2023 12:31:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH RFC 16/43] x86-64: Use per-cpu stack canary if supported by compiler Content-Language: en-US To: Hou Wenlong , linux-kernel@vger.kernel.org Cc: Thomas Garnier , Lai Jiangshan , Kees Cook , Brian Gerst , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Andy Lutomirski , Boris Ostrovsky , Darren Hart , Andy Shevchenko , Nathan Chancellor , Nick Desaulniers , Tom Rix , Peter Zijlstra , "Mike Rapoport (IBM)" , Ashok Raj , Rick Edgecombe , Catalin Marinas , Guo Ren , Greg Kroah-Hartman , "Jason A. Donenfeld" , Pawan Gupta , Kim Phillips , David Woodhouse , Josh Poimboeuf , xen-devel@lists.xenproject.org, platform-driver-x86@vger.kernel.org, llvm@lists.linux.dev References: <7cee0c83225ffd8cf8fd0065bea9348f6db3b12a.1682673543.git.houwenlong.hwl@antgroup.com> From: Juergen Gross In-Reply-To: <7cee0c83225ffd8cf8fd0065bea9348f6db3b12a.1682673543.git.houwenlong.hwl@antgroup.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------dy9uFmhcjqIP2UV6JYsq3Ms5" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------dy9uFmhcjqIP2UV6JYsq3Ms5 Content-Type: multipart/mixed; boundary="------------ov0MDEHsfp47A5JSPZkJ0II7"; protected-headers="v1" From: Juergen Gross To: Hou Wenlong , linux-kernel@vger.kernel.org Cc: Thomas Garnier , Lai Jiangshan , Kees Cook , Brian Gerst , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Andy Lutomirski , Boris Ostrovsky , Darren Hart , Andy Shevchenko , Nathan Chancellor , Nick Desaulniers , Tom Rix , Peter Zijlstra , "Mike Rapoport (IBM)" , Ashok Raj , Rick Edgecombe , Catalin Marinas , Guo Ren , Greg Kroah-Hartman , "Jason A. Donenfeld" , Pawan Gupta , Kim Phillips , David Woodhouse , Josh Poimboeuf , xen-devel@lists.xenproject.org, platform-driver-x86@vger.kernel.org, llvm@lists.linux.dev Message-ID: Subject: Re: [PATCH RFC 16/43] x86-64: Use per-cpu stack canary if supported by compiler References: <7cee0c83225ffd8cf8fd0065bea9348f6db3b12a.1682673543.git.houwenlong.hwl@antgroup.com> In-Reply-To: <7cee0c83225ffd8cf8fd0065bea9348f6db3b12a.1682673543.git.houwenlong.hwl@antgroup.com> --------------ov0MDEHsfp47A5JSPZkJ0II7 Content-Type: multipart/mixed; boundary="------------AE0inQaMWfJGKdJPNCVK0Np8" --------------AE0inQaMWfJGKdJPNCVK0Np8 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjguMDQuMjMgMTE6NTAsIEhvdSBXZW5sb25nIHdyb3RlOg0KPiBGcm9tOiBCcmlhbiBH ZXJzdCA8YnJnZXJzdEBnbWFpbC5jb20+DQo+IA0KPiBGcm9tOiBCcmlhbiBHZXJzdCA8YnJn ZXJzdEBnbWFpbC5jb20+DQo+IA0KPiBJZiB0aGUgY29tcGlsZXIgc3VwcG9ydHMgaXQsIHVz ZSBhIHN0YW5kYXJkIHBlci1jcHUgdmFyaWFibGUgZm9yIHRoZQ0KPiBzdGFjayBwcm90ZWN0 b3IgaW5zdGVhZCBvZiB0aGUgb2xkIGZpeGVkIGxvY2F0aW9uLiAgS2VlcCB0aGUgZml4ZWQN Cj4gbG9jYXRpb24gY29kZSBmb3IgY29tcGF0aWJpbGl0eSB3aXRoIG9sZGVyIGNvbXBpbGVy cy4NCj4gDQo+IFtIb3UgV2VubG9uZzogRGlzYWJsZSBpdCBvbiBDbGFuZywgYWRhcHQgbmV3 IGNvZGUgY2hhbmdlIGFuZCBhZGFwdA0KPiBtaXNzaW5nIEdTIHNldCB1cCBwYXRoIGluIHB2 aF9zdGFydF94ZW4oKV0NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEJyaWFuIEdlcnN0IDxicmdl cnN0QGdtYWlsLmNvbT4NCj4gQ28tZGV2ZWxvcGVkLWJ5OiBIb3UgV2VubG9uZyA8aG91d2Vu bG9uZy5od2xAYW50Z3JvdXAuY29tPg0KPiBTaWduZWQtb2ZmLWJ5OiBIb3UgV2VubG9uZyA8 aG91d2VubG9uZy5od2xAYW50Z3JvdXAuY29tPg0KPiBDYzogVGhvbWFzIEdhcm5pZXIgPHRo Z2FybmllQGNocm9taXVtLm9yZz4NCj4gQ2M6IExhaSBKaWFuZ3NoYW4gPGppYW5nc2hhbi5s anNAYW50Z3JvdXAuY29tPg0KPiBDYzogS2VlcyBDb29rIDxrZWVzY29va0BjaHJvbWl1bS5v cmc+DQo+IC0tLQ0KPiAgIGFyY2gveDg2L0tjb25maWcgICAgICAgICAgICAgICAgICAgICAg fCAxMiArKysrKysrKysrKysNCj4gICBhcmNoL3g4Ni9NYWtlZmlsZSAgICAgICAgICAgICAg ICAgICAgIHwgMjEgKysrKysrKysrKysrKystLS0tLS0tDQo+ICAgYXJjaC94ODYvZW50cnkv ZW50cnlfNjQuUyAgICAgICAgICAgICB8ICA2ICsrKysrLQ0KPiAgIGFyY2gveDg2L2luY2x1 ZGUvYXNtL3Byb2Nlc3Nvci5oICAgICAgfCAxNyArKysrKysrKysrKystLS0tLQ0KPiAgIGFy Y2gveDg2L2luY2x1ZGUvYXNtL3N0YWNrcHJvdGVjdG9yLmggfCAxNiArKysrKysrLS0tLS0t LS0tDQo+ICAgYXJjaC94ODYva2VybmVsL2FzbS1vZmZzZXRzXzY0LmMgICAgICB8ICAyICst DQo+ICAgYXJjaC94ODYva2VybmVsL2NwdS9jb21tb24uYyAgICAgICAgICB8IDE1ICsrKysr KystLS0tLS0tLQ0KPiAgIGFyY2gveDg2L2tlcm5lbC9oZWFkXzY0LlMgICAgICAgICAgICAg fCAxNiArKysrKysrKysrLS0tLS0tDQo+ICAgYXJjaC94ODYva2VybmVsL3ZtbGludXgubGRz LlMgICAgICAgICB8ICA0ICsrKy0NCj4gICBhcmNoL3g4Ni9wbGF0Zm9ybS9wdmgvaGVhZC5T ICAgICAgICAgIHwgIDggKysrKysrKysNCj4gICBhcmNoL3g4Ni94ZW4veGVuLWhlYWQuUyAg ICAgICAgICAgICAgIHwgMTQgKysrKysrKysrLS0tLS0NCj4gICAxMSBmaWxlcyBjaGFuZ2Vk LCA4OCBpbnNlcnRpb25zKCspLCA0MyBkZWxldGlvbnMoLSkNCj4gDQoNCi4uLg0KDQo+IGRp ZmYgLS1naXQgYS9hcmNoL3g4Ni94ZW4veGVuLWhlYWQuUyBiL2FyY2gveDg2L3hlbi94ZW4t aGVhZC5TDQo+IGluZGV4IDY0M2QwMjkwMGZiYi4uMDllYWY1OWU4MDY2IDEwMDY0NA0KPiAt LS0gYS9hcmNoL3g4Ni94ZW4veGVuLWhlYWQuUw0KPiArKysgYi9hcmNoL3g4Ni94ZW4veGVu LWhlYWQuUw0KPiBAQCAtNTEsMTUgKzUxLDE5IEBAIFNZTV9DT0RFX1NUQVJUKHN0YXJ0dXBf eGVuKQ0KPiAgIA0KPiAgIAlsZWFxCShfX2VuZF9pbml0X3Rhc2sgLSBQVFJFR1NfU0laRSko JXJpcCksICVyc3ANCj4gICANCj4gLQkvKiBTZXQgdXAgJWdzLg0KPiAtCSAqDQo+IC0JICog VGhlIGJhc2Ugb2YgJWdzIGFsd2F5cyBwb2ludHMgdG8gZml4ZWRfcGVyY3B1X2RhdGEuICBJ ZiB0aGUNCj4gLQkgKiBzdGFjayBwcm90ZWN0b3IgY2FuYXJ5IGlzIGVuYWJsZWQsIGl0IGlz IGxvY2F0ZWQgYXQgJWdzOjQwLg0KPiArCS8qDQo+ICsJICogU2V0IHVwIEdTIGJhc2UuDQo+ ICAgCSAqIE5vdGUgdGhhdCwgb24gU01QLCB0aGUgYm9vdCBjcHUgdXNlcyBpbml0IGRhdGEg c2VjdGlvbiB1bnRpbA0KPiAgIAkgKiB0aGUgcGVyIGNwdSBhcmVhcyBhcmUgc2V0IHVwLg0K PiAgIAkgKi8NCj4gICAJbW92bAkkTVNSX0dTX0JBU0UsJWVjeA0KPiAtCW1vdnEJJElOSVRf UEVSX0NQVV9WQVIoZml4ZWRfcGVyY3B1X2RhdGEpLCVyYXgNCj4gKyNpZiBkZWZpbmVkKENP TkZJR19TVEFDS1BST1RFQ1RPUl9GSVhFRCkNCj4gKwlsZWFxCUlOSVRfUEVSX0NQVV9WQVIo Zml4ZWRfcGVyY3B1X2RhdGEpKCVyaXApLCAlcmR4DQo+ICsjZWxpZiBkZWZpbmVkKENPTkZJ R19TTVApDQo+ICsJbW92YWJzCSRfX3Blcl9jcHVfbG9hZCwgJXJkeA0KDQpTaG91bGRuJ3Qg YWJvdmUgMiB0YXJnZXRzIGJlICVyYXg/DQoNCj4gKyNlbHNlDQo+ICsJeG9ybAklZWF4LCAl ZWF4DQo+ICsjZW5kaWYNCj4gICAJY2RxDQo+ICAgCXdybXNyDQo+ICAgDQoNCg0KSnVlcmdl bg0K --------------AE0inQaMWfJGKdJPNCVK0Np8 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------AE0inQaMWfJGKdJPNCVK0Np8-- --------------ov0MDEHsfp47A5JSPZkJ0II7-- --------------dy9uFmhcjqIP2UV6JYsq3Ms5 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmRTiZ8FAwAAAAAACgkQsN6d1ii/Ey/C /Qf7BVOcd5ra8zfx6EPiAv74I4RpWlIuL3rn0B5v6bOo0FFa4n4zj9VOvcYOUGlraDWF3O8GumNw Cb2IMVqEVZErE9qRr7deURIsoKwrXg8XsZZjyjfJHu8zKP0vbrA0de6Vd5j4KtUt9Zbex5+iSI6o znSFEHTx2lXV8YGE6XnBxHulxsAoSOpevs72mkXEZvqkplnfYYm1wbXEdHz1Kv7YDAzhn8sDHmIc kXp/CLT/2dmoEhI/S5jdbBan7ywy6EL+49FsfPxbNoHu4grjSjXTW000ltfEWEQL8ZA3GPAsM3PX xoMnuhBcTopWMqDtZyEsrsTuG79jnYi0WXwT9+wWmQ== =o9bz -----END PGP SIGNATURE----- --------------dy9uFmhcjqIP2UV6JYsq3Ms5-- From xen-devel-bounces@lists.xenproject.org Thu May 04 10:32:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 10:32:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529678.824329 (Exim 4.92) (envelope-from ) id 1puWGN-0007Bb-Lx; Thu, 04 May 2023 10:32:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529678.824329; Thu, 04 May 2023 10:32:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puWGN-0007BU-JK; Thu, 04 May 2023 10:32:39 +0000 Received: by outflank-mailman (input) for mailman id 529678; Thu, 04 May 2023 10:32:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puWGM-0006cv-Ow for xen-devel@lists.xenproject.org; Thu, 04 May 2023 10:32:38 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on060f.outbound.protection.outlook.com [2a01:111:f400:fe0c::60f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fcccc8a3-ea66-11ed-b226-6b7b168915f2; Thu, 04 May 2023 12:32:37 +0200 (CEST) Received: from AM6P193CA0141.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:85::46) by DB9PR08MB8459.eurprd08.prod.outlook.com (2603:10a6:10:3d5::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Thu, 4 May 2023 10:32:34 +0000 Received: from AM7EUR03FT037.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:85:cafe::c9) by AM6P193CA0141.outlook.office365.com (2603:10a6:209:85::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26 via Frontend Transport; Thu, 4 May 2023 10:32:34 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT037.mail.protection.outlook.com (100.127.140.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.25 via Frontend Transport; Thu, 4 May 2023 10:32:34 +0000 Received: ("Tessian outbound 8b05220b4215:v136"); Thu, 04 May 2023 10:32:34 +0000 Received: from 271d7a319c8c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9592A008-E23D-425A-A8BD-D97393C9E3CB.1; Thu, 04 May 2023 10:32:27 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 271d7a319c8c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 04 May 2023 10:32:27 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AS8PR08MB9792.eurprd08.prod.outlook.com (2603:10a6:20b:613::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.21; Thu, 4 May 2023 10:32:23 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::9283:e527:bed8:ab23]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::9283:e527:bed8:ab23%7]) with mapi id 15.20.6363.022; Thu, 4 May 2023 10:32:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fcccc8a3-ea66-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gd/NjnaXxNh81P765sCdBk6OvwGARw4SD4t12/DyxQw=; b=ZyvS3wWe19J70ts/P63elgFhe3LB4hHIpsRk5ezjMvRdQ/NoYRD6rXDyiZsSWl55WO0J5CibrYej3B1M02JIv6wTNh8MbTViqFVhl1D7u8tV3Qoxoc86tLpjtyn+cqG02xpHPAh22el68Bq9EziRRFBs94wY1s7gq1VH+xeEzjU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 31291b0853fa72b4 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TIzjCFJz3L37hTwIw1CdETIrhR6uSxgwwQG/66xSrWotr5nHwlqLJqjrXavo+1uUsBDyK1IxbMmZMurU6algKceJhGXP9GPyXVPkZ+HhDDtzM/GPY4XiVGoDdoaZFZvCBSi71CUtve5nP+2KN0LuQSn2nT4R3nDAAMiLHgeYg9HosI2ZZKBJinlPzuVnkwJi89OBRA2KOp/XSHuszy19Xnqj0uVl4a666h7H5fm6c1EkKYwXH5hB2V+BzY+9Mq6anL3MaE6adXgOST1bWTEbhkwVIIVJCaCgOrm1Jl7AlV6uKTa11gUx+Dhhph9NP05afkXPAoEklbmF2rWB62jn3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gd/NjnaXxNh81P765sCdBk6OvwGARw4SD4t12/DyxQw=; b=HZc/CCtlnYBzuwiGvKLPBhHpmpxxxoAyOeAemgnrNFNnE3PDtZZPL//M99IBW1TiOKBftngkdgP/QHhz5WmOxp2O3n3O4ohUKevfMZw2i35yF0uOWC3ECS90we2PliIT+T8PC+YKV/megHBnYQZYoK4X3DfKbg7d123odC660uD4mqzutF56x2LCQZyWir8XnwZFfqkbhhoLrvzC0Au5i/e/ILKktIToVEY5ONMx6Tndy5O8NKZ0PFxv9I8JjZ2BsXU6LE8ms0DByKBEYrbTMImDP1Lno281NmsBPANYS4wP71iH3mR4zxmem72kWIgpxFYIEsXRq/OHnRrFcvWDJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gd/NjnaXxNh81P765sCdBk6OvwGARw4SD4t12/DyxQw=; b=ZyvS3wWe19J70ts/P63elgFhe3LB4hHIpsRk5ezjMvRdQ/NoYRD6rXDyiZsSWl55WO0J5CibrYej3B1M02JIv6wTNh8MbTViqFVhl1D7u8tV3Qoxoc86tLpjtyn+cqG02xpHPAh22el68Bq9EziRRFBs94wY1s7gq1VH+xeEzjU= From: Bertrand Marquis To: Julien Grall CC: Stewart Hildebrand , Xen-devel , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm: pci: fix -Wtype-limits warning in pci-host-common.c Thread-Topic: [PATCH] xen/arm: pci: fix -Wtype-limits warning in pci-host-common.c Thread-Index: AQHZffQTsmRRBKh80kOBQgH8fU6H2a9J0ZUAgAAT8ICAAAXxgA== Date: Thu, 4 May 2023 10:32:21 +0000 Message-ID: <837CD804-85F2-4D3C-87FD-3F65F22A8432@arm.com> References: <20230503191820.78322-1-stewart.hildebrand@amd.com> <5D298044-314C-473F-97AB-420DA3DA44A2@arm.com> <4ca00734-8e1e-fe5b-b2a0-6f08f3835433@xen.org> In-Reply-To: <4ca00734-8e1e-fe5b-b2a0-6f08f3835433@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.500.231) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|AS8PR08MB9792:EE_|AM7EUR03FT037:EE_|DB9PR08MB8459:EE_ X-MS-Office365-Filtering-Correlation-Id: 04514016-2f31-4239-2b36-08db4c8adfd0 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: qrUfNZv1o8scGQhui2K+/8TR4e44HRQJ7inq0tysho4x0zbgVObHCZSDoUf0YnZlEHy0qruu3ssnHAt/EjZvLBLokyXLfc7JILi9UpyqFg3GzyHiHThCth0zmUv6IiyAbyN3HxEkG9zFqtC3uKr89YRpoD5tCWz8PAFVKNCYFt9Hj7Qr4ch7lJNu09409Paw6FjXyr7YR8qYMLpzMfUxV8tIthS21Fn2uhgqVNDtFViMx+m/5Xjf6NP2vaeMPxyOb+JOzB36IhAJhMbXBC7sq8gDEBSpOdv8Hs0tnQKrt+ChEbh8gj+uGuBleMv4rcj5r1sL/RjlSRmO73e5usF2f43SChx/ga442dXYUKmEKBMYDmUGl5zq3OJNUziFl3JqR1KgvEbaypmRtpDCU6vddNht2PleKHC782q7SFy4k+pMGKpHREXP+usvSEAhO3SA30OjqL6t8jZsfLRKtGDL7YTbYwdFiTGsaxvMXDiJgjUB/TnhOBYLbTiuhnqeVCSjDE/o0nwAdLvRGBMIVb5Bl7u6L6A2i9oii9Ik9aAJbN8PgXefpkX198MDPrxFq4QRDr4hnty4YyAw/7kcpMqTkXkrU7PjSa1rZiVO5jDs5XIYqLlYAkNKb2UU2hlE+sVWe6DRfa4XYTICLhTv/bEcYA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(366004)(376002)(39860400002)(136003)(451199021)(54906003)(186003)(478600001)(6506007)(2616005)(6512007)(53546011)(71200400001)(6486002)(4326008)(6916009)(66446008)(41300700001)(66556008)(76116006)(64756008)(66476007)(91956017)(66946007)(316002)(83380400001)(5660300002)(8676002)(8936002)(122000001)(2906002)(38100700002)(38070700005)(36756003)(33656002)(86362001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9792 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5872a7cb-cf82-48f9-ab99-08db4c8ad7e8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9KP2eHYCyJTyPnBv5KPTeJ3tm9/wOmsgx50RZMVZ+1dPVltKWdP56KhlxPwWfhDHuk8Q761WrYH0EFC0gAnO4gJMkWvzWOEn1MN7JJW2CQOYMsKr2PgOQ9Rw+g/AcIU+JGWmyS+MUNUlCJbKf6uUvDhYpvsSQe26m7JqJqZ0f1mxuQO+6P1BaDRjQ8iBkFqkAf522NWXfcPa7KeFNKiGe05jib8Nrcqt4BSNzNkc2qqNezk4YwI3XjBL5CajewrPagbB/qCfnsGPL1la+s9wQgCzeqgLklcxKhh2XjTMMW+qi3ehbpGFAGSHVtsYvGAaDEmfK3/JtzqFjQ+vAP+XyRcu1JVaS527sHXtkwikA6na026VZs/14W99/ATX6dewdDsTdre92PmP3SXTpBex7taS6SGn77JE0kbA2+Rfjz9mjGfb0LjWRnN1GxJof5xgstk/EDTdHiTVgQJNgGKJFyleu7Zirbg+Nze/jvwAhomCyz/1UAy5lR6ZKRGrwByQ3PfX0CPCgAYx701IBWlspA4KwnP8geDH7XSv51g7rTW7TCoiaS16A6PBZ+vEyTKQn2k1COaaqtQOCNUcdUKZ0wt9jmAvKlcAaxVJ0/utxLTqGkM2w0mDX3RMMUouD0Z5pqwQ27I47zyClvBSXgKiL01i8Pm89F08DIP9BZiF56kf6NwUwQJuTMfKEWmDoUWUZWX1J8g0Omw7m4A2sresPtmQx/XONBXUvohVFoQdFeo= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(376002)(396003)(346002)(39860400002)(136003)(451199021)(46966006)(36840700001)(40470700004)(2906002)(316002)(4326008)(8936002)(8676002)(47076005)(82310400005)(2616005)(336012)(86362001)(5660300002)(6862004)(54906003)(40460700003)(41300700001)(36756003)(70206006)(70586007)(478600001)(33656002)(6486002)(40480700001)(53546011)(6512007)(6506007)(356005)(81166007)(36860700001)(26005)(186003)(107886003)(82740400003)(34020700004)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 10:32:34.6591 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 04514016-2f31-4239-2b36-08db4c8adfd0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8459 SGksDQoNCj4gT24gNCBNYXkgMjAyMywgYXQgMTI6MTAsIEp1bGllbiBHcmFsbCA8anVsaWVuQHhl bi5vcmc+IHdyb3RlOg0KPiANCj4gSGksDQo+IA0KPiBPbiAwNC8wNS8yMDIzIDA5OjU5LCBCZXJ0 cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4gSGkgU3Rld2FydCwNCj4+PiBPbiAzIE1heSAyMDIzLCBh dCAyMToxOCwgU3Rld2FydCBIaWxkZWJyYW5kIDxTdGV3YXJ0LkhpbGRlYnJhbmRAYW1kLmNvbT4g d3JvdGU6DQo+Pj4gDQo+Pj4gV2hlbiBidWlsZGluZyB3aXRoIEVYVFJBX0NGTEFHU19YRU5fQ09S RT0iLVd0eXBlLWxpbWl0cyIsIHdlIG9ic2VydmUgdGhlDQo+Pj4gZm9sbG93aW5nIHdhcm5pbmc6 DQo+Pj4gDQo+Pj4gYXJjaC9hcm0vcGNpL3BjaS1ob3N0LWNvbW1vbi5jOiBJbiBmdW5jdGlvbiDi gJhwY2lfaG9zdF9jb21tb25fcHJvYmXigJk6DQo+Pj4gYXJjaC9hcm0vcGNpL3BjaS1ob3N0LWNv bW1vbi5jOjIzODoyNjogd2FybmluZzogY29tcGFyaXNvbiBpcyBhbHdheXMgZmFsc2UgZHVlIHRv IGxpbWl0ZWQgcmFuZ2Ugb2YgZGF0YSB0eXBlIFstV3R5cGUtbGltaXRzXQ0KPj4+ICAyMzggfCAg ICAgaWYgKCBicmlkZ2UtPnNlZ21lbnQgPCAwICkNCj4+PiAgICAgIHwgICAgICAgICAgICAgICAg ICAgICAgICAgIF4NCj4+PiANCj4+PiBUaGlzIGlzIGR1ZSB0byBicmlkZ2UtPnNlZ21lbnQgYmVp bmcgYW4gdW5zaWduZWQgdHlwZS4gRml4IGl0IGJ5IGludHJvZHVjaW5nIGENCj4+PiBuZXcgdmFy aWFibGUgb2Ygc2lnbmVkIHR5cGUgdG8gdXNlIGluIHRoZSBjb25kaXRpb24uDQo+Pj4gDQo+Pj4g U2lnbmVkLW9mZi1ieTogU3Rld2FydCBIaWxkZWJyYW5kIDxzdGV3YXJ0LmhpbGRlYnJhbmRAYW1k LmNvbT4NCj4+IEkgd291bGQgc2VlIHRoaXMgYXMgYSBidWcgZml4IG1vcmUgdGhhbiBhIGNvbXBp bGVyIHdhcm5pbmcgZml4IGFzIHRoZSBlcnJvciBjb2RlIHdhcw0KPj4gaWdub3JlZCBiZWZvcmUg dGhhdC4NCj4gDQo+ICsxLiBBbHNvIHRoZXJlIGlzIGEgbWlzc2luZyBmaXhlcyB0YWcuIEFGQUlD VCB0aGlzIGlzc3VlIHdhcyBpbnRyb2R1Y2VkIGJ5IDZlYzkxNzZkOTRhZS4NCj4gDQo+PiBBbnl3 YXk6DQo+PiBSZXZpZXdlZC1ieTogQmVydHJhbmQgTWFycXVpcyA8YmVydHJhbmQubWFycXVpc0Bh cm0uY29tPg0KPiANCj4gSnVzdCB0byBjbGFyaWZ5LCB5b3UgYXJlIGhhcHB5IHdpdGggdGhlIGN1 cnJlbnQgY29tbWl0IG1lc3NhZ2U/IElmIHNvLCBJIGNhbiBjb21taXQgaXQgbGF0ZXIgb24gd2l0 aCB0aGUgUmV2aWV3ZWQtYnkgKyBmaXhlcyB0YWcuDQoNCldvdWxkIGJlIG5pY2UgdG8gYWRkIHRo ZSBwcm9wZXIgZml4ZXMgZmxhZyBpZiB5b3UgY2FuIGRvIGl0IG9uIGNvbW1pdCA6LSkNCg0KQ2hl ZXJzDQpCZXJ0cmFuZA0KDQo+IA0KPiBDaGVlcnMsDQo+IA0KPiAtLSANCj4gSnVsaWVuIEdyYWxs DQoNCg0K From xen-devel-bounces@lists.xenproject.org Thu May 04 10:48:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 10:48:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529682.824340 (Exim 4.92) (envelope-from ) id 1puWVH-0000Ue-10; Thu, 04 May 2023 10:48:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529682.824340; Thu, 04 May 2023 10:48:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puWVG-0000UX-Sy; Thu, 04 May 2023 10:48:02 +0000 Received: by outflank-mailman (input) for mailman id 529682; Thu, 04 May 2023 10:48:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puWVF-0000UQ-Aj for xen-devel@lists.xenproject.org; Thu, 04 May 2023 10:48:01 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 218ea07f-ea69-11ed-8611-37d641c3527e; Thu, 04 May 2023 12:47:58 +0200 (CEST) Received: from mail-dm6nam12lp2177.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 May 2023 06:47:56 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by DM4PR03MB6192.namprd03.prod.outlook.com (2603:10b6:5:39c::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Thu, 4 May 2023 10:47:52 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::b0b8:8f54:2603:54ec%3]) with mapi id 15.20.6340.031; Thu, 4 May 2023 10:47:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 218ea07f-ea69-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683197278; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=P2pHireLaG86uQAbiKAmSpJCeImRzsJeRL5SrU7VkXo=; b=YjC3AvPc9ea1/b/1RFlXEA/etTN77BnKqfSye7OSQmh1LugZVItk4Qf+ g34pjIrTtTKOJqrsbrYn0kfEYg2O2wtLt+fFVDgoI2Af0OZHa2rf57uGq ezY9sICuVOfRJkv7WP0eQWKUmabjXoEMrrnOAyjJ2KwaxGrCwkpz427Fj A=; X-IronPort-RemoteIP: 104.47.59.177 X-IronPort-MID: 107169153 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:kRsbQquMo9JJrpona8siKVQos+fnVHBfMUV32f8akzHdYApBsoF/q tZmKW6EafqPYzehfNpybIyw/U8A6pTQzdFlGQU5pH9hRCtD+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj6Vv0gnRkPaoQ5AKGyyFMZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwExxcTBusgNqM5LuDd7R0nvk/HvTmBdZK0p1g5Wmx4fcOZ7nmGv+PyfoGmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osgf60b4W9lt+iHK25mm6Co W3L5SLhCwwyP92D0zuVtHmrg4cjmAuiAN1LSuzhq6UCbFu7ySszDExPBAaCo/ylu0W6QOAOD UEN5X97xUQ13AnxJjXnZDWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOnM08SCEu1 1SJt8j0HjEpu7qQIVqC8p+EoDX0PjIaRVLufgcBRAoBptXm/oc6i0uVSs45SfHqyNroBTv33 jaG6jAkgKkehtIK0KP9+k3bhzWrpd7CSQtdChjrY19JJzhRPOaND7FEI3CChRqcBO51lmW8g UU= IronPort-HdrOrdr: A9a23:EMNG36oNWObjVr1ly/DdNQQaV5t9LNV00zEX/kB9WHVpm5Oj9/ xGzc576farslgssSkb6K690KnpewK7yXcH2/hhAV7CZniohILMFvAA0WKM+UybJ8STzJ846U 4kSdkANDSSNyk1sS+Z2njELz9I+rDum8rE6YiurQYJcegpUdAd0+4TMHfjLqQCfng8OXNPLu vl2iMonUvGRV0nKuCAQlUVVenKoNPG0Lj8ZwQdOhIh4A6SyRu19b/TCXGjr1YjegIK5Y1n3X nOkgT/6Knmmeq80AXg22ja6IkTsMf9y+FEGNeHhqEuW3XRY0eTFcdcso+5zXUISdKUmRIXeR 730lAd1vFImjHsl6eO0F3QMkfboW8TAjTZuC+laDPY0L/ErPhTMbsYuWqbGiGpsHbJxrtHof 92NznyjesKMfuF9x6NtuQhknlR5xCJSb5Lq59Ns5SZObFuNoO55LZvjn99AdMOGjn355sgF/ QrBMbA5OxOeVffdHzBuHJzqebcFEjbMy32CnTqgPblmAR+jTR81Q8V1cYflnAP+NY0TIRF/f 3NNuBtmKtVRsEbYKphDKNZKPHHRlDlUFbJKiafMF7nHKYINzbErIP2+qw84KWvdIYTxJU/lZ zdWBdTtHI0eUjpFcqStac7vyzlUSG4R3Dg28te7592tvn1Q6fqKzSKTBQ0n86ps5wkc4Tmsj aISeRr6tPYXBzT8NxyrnjDsrFpWA0jbPE= X-Talos-CUID: 9a23:HSXPBmOGgQ/9Au5DYwU21kU7HfgfVnTl8SrIO3KkO1tkcejA X-Talos-MUID: 9a23:gWY1lgaZhzLXH+BTuHjMgGA7ZZpR4aGyOUsJiqdXncSdKnkl X-IronPort-AV: E=Sophos;i="5.99,249,1677560400"; d="scan'208";a="107169153" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dyE0bEIhSSgQlHvEicsCEs/EetezhtA7zqB/+8kCAPR9bUDflY8CZzdqkKsptx7/UgI42uHPE8mgeeT3gjTVf++fBGJ/tNuFh7ooGSiwuTq2WLS4bP7n7s4lU+cLhZ/dgm0hunjyKhJZMWutH9HBMtC1wcL5Nd5CoXZfKLhfHitnXn+PVZ7XJscCMVvTp/dAFKdCw6hr+UxzMMiyUqYGxJLXz+J3Ru4KRdJEHajGOlZO5bbQ0qqM/t5rrWH1BkhF77NYNQzRKzStTKh3g+hjZpLoq/8/dxVPN4lU+2mbfoVDiNA9cAXV6aOAFLsLVQoyZTTVZfo8C59tinj/DfAD+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SfmadrDjcYOWOSGpeJtM2ZYjcsHOQEl/UXhaGNTYSgc=; b=hjiMeRxuIbQwqW/RaJ7Yiqb57idMXX9wV9ncKoq16d86N6oa3vC42dNrZ+CJCIQ6kjHIEMDVYpvEJmoS1ySCuL5ryH2yMjucpC0fFzNHTZnVDoFd6VrSNRWCZq7PaHfzY/AGaNLqzzAEFbEgTvT+SHQVt5awdl5WeWZ9cMxMRvFNV+XmIzSgwzZR9Y4l2d7H/9Sch+qcZwszy5ZUZcDbf0M4ohr+OGgmiQlqDK0u3Rssnj6L+ehNxubgJisxr9qXwjNwPMAB+QQicOo10tdbowN9ZhxDTOM8EVZXW9aGvWStL2cYDQ+g8yO54LKPC1fCiLQWviVI4Au66WmC59tZ4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SfmadrDjcYOWOSGpeJtM2ZYjcsHOQEl/UXhaGNTYSgc=; b=BxhZ5i8vCEXKX/jypZ9U4oPKEHhltRxTUgGxJwiy14Eq5IoogJyEa2plZ0YTF8rOcYtXjvvTm+UDbthAkieZ0UIUtYNSirRJTm6oqzC0IsrOebwVnJxFl6P9M4BFuwQK2y17gysHJC1Q66hDMvosiBVDD0gnYIIsTI16TldqR5I= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 4 May 2023 12:47:45 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: Xen-devel , Jan Beulich , Wei Liu Subject: Re: [PATCH v2] x86/ucode: Refresh raw CPU policy after microcode load Message-ID: References: <20230503185813.3050382-1-andrew.cooper3@citrix.com> <20230504102607.3078223-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230504102607.3078223-1-andrew.cooper3@citrix.com> X-ClientProxiedBy: LO3P265CA0028.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:387::11) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|DM4PR03MB6192:EE_ X-MS-Office365-Filtering-Correlation-Id: 333eac7b-4255-4466-9617-08db4c8d0286 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Lalpm72umfoLNCdnLYxChu+iOrMwi4REhaK0gnrPZ4pP6H0OvG75pLcGiBCkx/jPUkh/gHtBgiQVFbp0XOgSElgib3FPypWaSi3LOMQ9P3Kgecq9Rlo7WBkCvdYdzEgtfV1QqPOY1daTZ5p0lvKRDtRsWjrNf27ReBtnqAumDndUzsaKdeNhgfmCZ3wnROhumeAxHWMp+jsH7Y7oBVof+OKIUfE58q8XSV1nFSvtqqEmSYEzoXtOrYJS9lzlIWabFnQJNyVyxKpJ58Q343L6MoJHFP8NjYfZavPGtghYhJiTEYncJgyU8yjpAApuDg7KBmTGxJ+ruSfq3xm7ryFhCU2JNEA69EsLKyb6qzLHVS06RrJj6an9mrCR8qVibMCOCZ+Jcf7ZkYOvKTAiAKFGV2M8tepa1fBi8V37hdwe/jrjenlpdWy0FDLA0V9yWIUqQJ2pRZuIEyc/VhPfUAdymEMFRib1wVh5EE0isfkyJbjz6UUs/escDSJtSLi9t5e2ysQQNsblgJkWt0WM+IerPL3UEKksylBW6QbXKNSsmrg/8rWc61RwSlY7qSGqDPs5 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(7916004)(4636009)(136003)(396003)(39860400002)(376002)(346002)(366004)(451199021)(478600001)(8936002)(85182001)(316002)(6666004)(8676002)(4326008)(86362001)(41300700001)(6486002)(6636002)(33716001)(66476007)(82960400001)(5660300002)(66556008)(66946007)(6862004)(38100700002)(2906002)(83380400001)(54906003)(6512007)(9686003)(6506007)(186003)(26005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YXZqcHBNbG9LYSs1MHJxU2VTVnhTRU1vdXo5QXFlUkVkdGtPU2RycEZwczdD?= =?utf-8?B?TFVWMFNQMm1ITXMzbjQrWGdnRDJkU2VoTjI0dUVVL3RiczZFWTQxUkFYMWg3?= =?utf-8?B?TFYySmMxcytxZ0FZQ2E1WnhvTEsrbVgyTHJDckdEa2J0SW5jamtrRTBFRk83?= =?utf-8?B?N2x5dDF6QWVEb1RFOTBZZmQ0NDdXRVJxTEoyOVNwUHEvdXZRUjhtV1AzWGZp?= =?utf-8?B?cHNUT3RNUnFhWXA2b1JMV1pJVTI5K0JpN0NpYTJQWnNmNzhzMlR1K0tYTFg4?= =?utf-8?B?bHkzRFZIT0lvQnFWM3RTRVd6bGNIbmY3bGpiZisvV1V0WDJMYUtxY0x6K2lr?= =?utf-8?B?TndUSGs2ZnpST0NpQWs1dCt6WitTZDN1NFhHcWZ0Nkwzei9OcVhMd0duZ0Ns?= =?utf-8?B?MWh6QVhaR2FWRDlxaTJ5WnhSVW9HSnpjaVNNM3NlSEswUnNzT3Z2b1BzSmV6?= =?utf-8?B?TnNHL2NDYWRzejI4MXlveHFEWDYzLzNyMWFwMklsRXdZUUEyTzNlNkNrOVpk?= =?utf-8?B?dFJEQ3B2dVZIL2M2U1EySnNzdkVSTjlWdTJrU3ZZamRuaDY4RkRlT21NcjlQ?= =?utf-8?B?am1uSFpNNmFoeVNwcTR1T2U4L2kxOGdQaDBEeWU2ZGp5Z016OG5YakRDUnU0?= =?utf-8?B?bXhrd3d3R3JtWjdtYkY5WFNmOUFEMnBjWlRpdXBrNlpqYmVxTzB0cjJzSXBD?= =?utf-8?B?TXYzY2gxOUszY093TUhvRXh5KzQ2bmVXcWIrRzlwVWNJanBxdnhFQWlRbGhD?= =?utf-8?B?bEZtT21kOXBlbjdDajhCenFkOE1EL2RwZGVmY0x5eHFZZ3Mzd0ZrY3VLandB?= =?utf-8?B?TjlHWm1SOEV6Tjlqd0FvaVFJd2lmemlOYytVZEhtcE1KRnc5YUtNM3l3dUNp?= =?utf-8?B?SzJmNUM5OWwycXlhUGh3YXlKTDZYZ01sa0V6ekwrWEVXai9oWDNaWHFVRFR4?= =?utf-8?B?dUVFZGFkaUw2SFJEYTBzQlAxNjIyTXRCazFZWnkyWUxKTU93MTJTUVVwTkRi?= =?utf-8?B?aGs2bE5rSmUvSnZIU0hLSGZORUhEa2F6czF5RUFUOEpOSVNkN1ZtRFF6Tk9z?= =?utf-8?B?SllyV1Badm5SSDJPM3B0SzZ0cHErK1NLZjY5YUduRnZLbEFyZEhiZnVGU1Z5?= =?utf-8?B?bmhKbzVxMmh0UE56aUZQWkg1TzZSenkva01lcGJlNmRiNU5yYTlEOGZYRExu?= =?utf-8?B?N212TVU5QTlRalIycWMwU1NCMkdWUjZYZUxXV0pmUFZuQ1FvZFBDOWN0YTRM?= =?utf-8?B?RjFweXNpUDVSZnZWTEhyS2plNE9Xc0R3cEUvNWIyTUNTZ3FGQWZ6VnJ5UFdW?= =?utf-8?B?dVlTaXNHRmI5Y1hFYWhWbnFUencvNW05RkU4cWdsQ0M3WGN4ajdyWS9WQVN1?= =?utf-8?B?KzFmTjVEK0YwWFBJQU5yaEpaMkxESWJhZnc1V0h2bXhhK1h4VUR5cXN1TnZC?= =?utf-8?B?MUhBakNUTkdwS2VCbTVrN1l3djRSaE5oM3EzYjB3UXhmeUZ1b29xL1c5L1hH?= =?utf-8?B?SHZESUZWUnBQUGh2TjlSeHJOdlZnbFhwRjRwaWNabWFxb2IyUXVwNmx5UTNl?= =?utf-8?B?WWdhNWluRnJlUW1vN05WU2tTVUlDSUYzM2lLN3JMdVcwNzgybUMvNmlSTVAx?= =?utf-8?B?RkZUUU9lVmZ3azNoQkxHeFNaNVExMjhobFpITlZSWFQ5REZGUG5KRHhyeWNj?= =?utf-8?B?bmRRZlp3bXFFb2Ztdm5ybzRJUFJnQyt4UU1wTzN0YXVzZ1pZOFRGZ1FqVnNV?= =?utf-8?B?K01uZmlqa2tScTlRQjNOT1Z2NEt4S2d4UkkzYU4ydk9VcXNEL2plSVdYMUli?= =?utf-8?B?K0VENDZJMERqMGRVU2Mvcm5zOHBXK3RNTWlteUE4R3RGU0FRcW0xYUdabWJY?= =?utf-8?B?KzVVZVFXK0ZJM1ltR0xxdjR5dGpIV09Bb2ZIbDJJZTJkNkRjeTYyTUtyUzRB?= =?utf-8?B?U2FoQkxTcEsrU2FvNzFPRVE2bmpiYzErbiswcVEyT0VCMjM1WTdZdmd5TG1h?= =?utf-8?B?T1EzYjFTRDdHWTVVYlc4bFRIU29MQzJWdmJIWmVyOTJMTHNIOWpTY09FRk1r?= =?utf-8?B?OUl0dmFVY2FpWWt5dDJiN1VTSFk0SGtzSmVyQ05lM1g5M1NuWWtHMFlOaDhP?= =?utf-8?Q?eSNE9M+O620YEo+DKNV/Bw4ty?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: +r8kOmlHX6NVnQsCA9WOPBpvmtk0A0RMM4CS7uHUjcFHid43L40Rtwfz7Ny8v1N44pkXWGXrS1HybPt6WXa7sW09Ekcw/NvJH+TZLOysOKv5pNuEewpwD/O3W1pOS0nLe49jRdi8AlHfKNuErgP5H13rrn5qVIn05BR0p2rfatW/eYGBFlkaVehOmLXO1vKGwD2hAlplJ3wvyzHGfPoDZSUQls/cW+XiTNRIhcpqZewsx4eZyYMzd8aroaXppIHhvomN98EWDbpip9d59a+JpXT71mBuzZSniTnNC4NJ92t1uQLZkv+9IyCOyBxgzhCe9FKhk6TSYI4Y3X1OyPz3diRjE/4YJDj5U+PI6Vv3NzvDt9hKsnGuADk4WHl0Sd77gIhDbm94uhP2IinVkXcESCRvF2RlCUJZA9dzoPmqRkPXdhIjglPLkptNwISeHm1cCDRz/cy839Q7qLc5oSgznqg8oN/0OvCKcmP8oIbGCwzaV1OuMbqLcrSc92SBIWEuIy2SkudJD9aQLsjKmhgYzVPk0GDFIcfrgsv4oLomPhVEpV8kcvlscvSMbrqPxWGV6A9FidzHN3ePG7CHHSq6Mi9/dt+NMQKOzfnxTVnDeG4xDcGnsGcQc1sH7It4dTdzULfCG+Oy1v74WadWjXJ53lupVVbQ67UJzY4FDbqstsWNhSHpf5z6GfMrfnOqj9K2VL1c3ynXaNFJrgJ8/XFjQ4Lym1wFUOLnQaao3W9kTD2cSE1GPwBxNo1v+gKbRSR0/9BogGL48ZcuS38vVqlw4hVv2zxBA1IFhpeX8Tf7Pt7U8s+cO48B0p5HDBectyiZ X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 333eac7b-4255-4466-9617-08db4c8d0286 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 10:47:52.1108 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EG02X4l14x0SYl8pLGqZKr8IhmSJhYd6/GLCOXTvarYhEhk4GLTeGN1zgSRrpqhiQ3+z6fq1scAfxnmMEBCK6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6192 On Thu, May 04, 2023 at 11:26:07AM +0100, Andrew Cooper wrote: > Loading microcode can cause new features to appear. This has happened > routinely since Spectre/Meltdown, and even the presence of new status bits can > sometimes mean the administrator has no further actions to perform. > > Conversely, loading microcode can occasionally cause features to disappear. > As with livepatching, it is very much the administrators responsibility to > confirm that a late microcode load is safe on the intended system before > rolling it out in production. > > Refresh the raw CPU policy after late microcode load appears to have done > something, so xen-cpuid can reflect the updated state of the system. > > Signed-off-by: Andrew Cooper > Reviewed-by: Jan Beulich Acked-by: Roger Pau Monné I'm not fully sure it's worth calling calculate_raw_cpu_policy() if updated != nr_cores, as it's possible the current CPU where the policy is regenerated hasn't been updated. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu May 04 11:00:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 11:00:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529685.824350 (Exim 4.92) (envelope-from ) id 1puWhM-0002zr-5I; Thu, 04 May 2023 11:00:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529685.824350; Thu, 04 May 2023 11:00:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puWhM-0002zj-0G; Thu, 04 May 2023 11:00:32 +0000 Received: by outflank-mailman (input) for mailman id 529685; Thu, 04 May 2023 11:00:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puWhK-0002za-1G for xen-devel@lists.xenproject.org; Thu, 04 May 2023 11:00:30 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id df9734d9-ea6a-11ed-8611-37d641c3527e; Thu, 04 May 2023 13:00:27 +0200 (CEST) Received: from mail-dm6nam10lp2102.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.102]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 May 2023 07:00:19 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH7PR03MB7224.namprd03.prod.outlook.com (2603:10b6:510:244::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Thu, 4 May 2023 11:00:13 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb%4]) with mapi id 15.20.6340.031; Thu, 4 May 2023 11:00:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: df9734d9-ea6a-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683198027; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=6BFBWRNJT8gQpyjBB03kfOs52D8txaObxzukCNgKSwM=; b=hjp5r0SqJxirZFX9z8He3aDjITK8kvN+L/tf1VQh6G87+6zuwcNVK73M vyiDB51qQwXoAJhVx7tJzF5+SDfgrRhr65OH77aWVleB17+kenkqXg540 c+S/ghoA9Xl4Wrlv5IYuxwuUirhjFOqeXKwbBsEgyltsWlKZ8GEeX7t3w 8=; X-IronPort-RemoteIP: 104.47.58.102 X-IronPort-MID: 110287718 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:pUq2oK5/MYKorbHwjBWTBwxRtBXGchMFZxGqfqrLsTDasY5as4F+v mEZXWGEP/iDMWr9eNF2Ot/n9B4DvMTXz4RhTwBl/iFjHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+7ZwehBtC5gZlPa0T4AeH/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m1 OU7JQpOMzy5g++E+uPmUfJJueoRI5y+VG8fkikIITDxK98DGMiGb4CUoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OnEooiOKF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNtLTOfoqaEz0DV/wEQeLy8ZDXedkMKYk3ynC/54F XUS6BQx+P1aGEuDC4OVsweDiG6JuFsQVsRdF8U+6RqR0ezE7gCBHG8GQzVdLts8u6ceRzYny 1uIlNPBHiF0vfueTnf13qiQhSO/P24SN2BqWMMfZQ4M4t2mrIRtiBvKF45nCPTs1oezHizsy TeXqiR4n68UkcMAy6S8+xbAni6ooZ/KCAUy4207Q16Y0++wX6b9D6TA1LQRxa8owFqxJrVZg EU5pg== IronPort-HdrOrdr: A9a23:0eVjXaq46fcsqMRpJDudUKcaV5ujLNV00zEX/kB9WHVpm5Oj5q eTdaUgpHvJYWgqKRQdcIi7Sdu9qLbnhNdICYl4B8bZYOCUghrcEGgC1/qj/9SEIVzTygcz79 YfT0ETMqyJMbE+t7eI3ODaKadi/DDkytHYuQ629R4EJm0EBdACnmEJczp3CncXeOAFP+tIKH P23Ls7m9PUQwVpUi3NPAh4YwGsnayxqHo7CSR2ZSIP2U2igS6l4qP9CDi0mi4EVTlC260v/A H+4kbED5GYwrSGI1LnpjTuB1s/oqqh9vJzQOi3zuQFIDTljQilIKxnRr25pTgw5M2/9Vowl9 HIghE4e+B+8WnYcG2ZqQbkn1CI6kdy11bSjXujxVfzq83wQzw3T+JHmIJiaxPcr2Ywod1m16 pP/mSB875aFwnJkijR78XBEztqik23i3w/lvN7tQ0EbaIuLJtq6aAP9kJcF5kNWAr89YAcCe FrSPrR4f5HGGnqI0ww6gNUoeCEbzAWJFOrU0ICssua33x9h3Zi1XYVw8QZgzMp6I89Y4Ms3Z WXDo1Y0JV1CuMGZ6N0A+kMBeGtDHbWfB7KOGWOZXz6CaA8PW7XoZKf2sRn2AiTQu1c8HIOou WRbLoYjx9tR6vWM7zQ4HSfyGGcfI2/NQ6dh/22qaIJ+MypeFIsWRfzDGzG2PHQ18n3OferEM pa4vptcrnexFvVaMF0NkXFKu5vwFklIZQoU4UAKgqzSjSiEPyligQtGMyja4YFVwxUBl8Wbx M4LW/ODfQF02TucnL0gB+Uc2/xeyXEjLhNOZmfwsxW4IUBNooJixMShEiy++uMJDEqiN0aQG JOZI7C1o62oGmo8X2N1WVmPRJBEl1YiY+QeE9ilEs2FwfRWZYn/+6yU0xz41erYiJea+++Km RijmUyxIbyC7Sx4GQfN/KLW1j2s5PXzEj6Z6v1XsW4lO7YklRRNOdxZER8eD+7YSCdsTwa4F t+VA== X-Talos-CUID: 9a23:x0CT82wNl3CEj71CVkmtBgU1A+MoSD6A4E3ULn2CWDtyU5iqZ22frfY= X-Talos-MUID: 9a23:W/gM7QYKRlKAZuBTuhjei2lOEvZTwr2cERAhtqs/vdu6Knkl X-IronPort-AV: E=Sophos;i="5.99,249,1677560400"; d="scan'208";a="110287718" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qrk8bSQHTzdzlHYqqbQsxXSS+YV8LOYSk4miGAJzizONwQS8JcSCgKBeey0CrViFXVaGYgMMIpEiiNxx2Pw5D+c9fHW/7QLdeYNa5fKwqr9e10e4Cl2Weuu1sTgTEfPRh4bMCw7dk8SkN+9w7VxchmQs9AdGZiad6f9ZvCkrjCx6medDX9D98f4sYBMu2asChGsXyBUZs+xLOAxTxVlglsFkWOTjaYXpKXF2QW95eWzbmSOQ6+KyDssbFJ/V6DYf1OE/RuHMJINCWXXpT4jgN+C73TOUN/ErBL3U+wPp6IlVw2tqHqTdXmYFIj2XuNfrkl4wVsyEf9Rl/oYkOZcDJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kf6e6xuLsE0l5KJi49O5tulDMMCfKntruNGAkxmvoEY=; b=avE7O3nyofZMUqu5yyc/gCmd0u0nsGHeQMsMaiyrMbWHjOLlx8gsdnDpYZUZJLucSOIafst0yGtPTIhd3pijPxwj5BW9NrJlVEFTXK01Jg54/Ahuynr23I3ltukYkAnSgId6Dl+DHPfAHI/7m9st8URB2sH9+ZQIQ1miulJeVv5HQiwtFh4jmNYAMiG/Xz/pM/n7mYuSHXrbTk49HwsNQ9k+b0DIKyyNbEiNVXsidlMGj+bl8XRNmbiWXfRb6cgMi5iDUHCgrGJWQPqL/40IPp0Ziz+MUc+HgO21f/RjyZSoPY6FG0/nQx7zxkycBe1mxYT3Fk4C8OVCKII3F/N/Eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kf6e6xuLsE0l5KJi49O5tulDMMCfKntruNGAkxmvoEY=; b=E2D/51umChD67baLcQqn3tLDb8qeOeAngZQd2JJ93issaYvDVYcYUw9/o80H/noojIuapGCpZVTDLP2QAV4rXKSjFXjyuFVEzvoeP/3BXq7cONubNHC1MsNMdsHNjzKD4RnkN3VoAF6dGum6mlthSeTjW/eiBunMiWQlcTtfqSQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Thu, 4 May 2023 12:00:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: Andrew Cooper Subject: Re: [PATCH v2] x86/ucode: Refresh raw CPU policy after microcode load Content-Language: en-GB To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Xen-devel , Jan Beulich , Wei Liu References: <20230503185813.3050382-1-andrew.cooper3@citrix.com> <20230504102607.3078223-1-andrew.cooper3@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0441.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::21) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|PH7PR03MB7224:EE_ X-MS-Office365-Filtering-Correlation-Id: 0d8365ff-dc0f-44a3-a98b-08db4c8ebbeb X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /Ue5BuW7t6nQ8kRPetenfUcP24CJg2T0aXN8Rj1Zb75gx4EPL8oCK3QHWtTMzNg3nlER27sEikOPHwgHOKqzrJA30O/XQO0oOOPQDP5LX3KRQG7YpcvumDANNkEoMWZ6V/XS5KdJ0KolSy8AJT6sAHqAtUZCOJ9nLjdbIpXVyfy1LtIaXDyhO0HZSb+b8dp1Fq6k3aHnXqdGmIrM0sfdP6lvsOBOEw/k44IUpLGnnTp32cl7KaLZnjxaOPSq/1r316F4BOdCs+07JM3wdNYPhdkcyv7iaRwmlbFG4LcQgq3Vcyaicp8CxD172I19IAhdhXKStBAQUC7Ir4PPJ6z1r17nqWR2tmorflBHYl2pByH0aVSpvJgA3DasBnKmlMmHJuYP0yZv1tw46LK1Q4J/TpPotuwXHhfJHQ5ShN8TXSskbz4VGRsPDz3kiY8tNtPnv2HKpc+SR/gHjCJaX8I+U9KgmssS1ociVLoYvJAzRwPsFep5XtzKgg/pKKzhaUgK17NbSAt9lAlHLtzAAF7CRbgsmwEY9I5M6yORw9abD1dBiOAvswqScudYC0pn9A6dZixKSeHK7bZkpD9wGF4UT1Qu4ZyYuyMXrBBnb+rMtFkcBpRrIJ+7SOmTL/1nkeHMYebOhZk2cbIJH/qWraD4oA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(136003)(396003)(346002)(366004)(39860400002)(451199021)(36756003)(53546011)(31686004)(2616005)(83380400001)(186003)(6512007)(6636002)(6506007)(41300700001)(66556008)(4326008)(8676002)(66476007)(66946007)(6862004)(8936002)(5660300002)(2906002)(82960400001)(26005)(316002)(478600001)(37006003)(86362001)(54906003)(31696002)(6666004)(38100700002)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NU92aHJLMmVIa0JrVkdQbUZsYlpHYk80V0JIVERwMEU3QnNIdGJzUmo1bCti?= =?utf-8?B?L3ZiVTBpMXBNTy9JOWZBd1B4SDBOQ0M2VGhESkhrR2ZKNzdyM2Y4K2RjQkZW?= =?utf-8?B?NVJJL0NWRTlBL090OWliK0ZXR2t0VytKQklSZk9PejNiekpYZGpCMW95SmFk?= =?utf-8?B?UjdCT054ZTNzbDBqejZjdGk3Z25zMWF3Z1dEV2pvVjhwZmFuZ0pQZEdHTEI5?= =?utf-8?B?TGJ5NmovOEdvakpXTXdZUlc5dWZFYlFwYW41d1U0enlkb3lLR3g1K2tqTW84?= =?utf-8?B?Uzl2SUZ6d1I4K3RPREgrT3BReFVLTzNtcWlBRnpTYlBCL29YbnVBMmh4L3Bn?= =?utf-8?B?eVZjQWhwSGlOSWtlVFlPRmJSQWNwQ1RiVlluSk94TW5hd3JlUnNLUVkrcFIr?= =?utf-8?B?OTNreTB2bmwrck5VZExJZ1I2bk8ySFYzaWdqS3NGYW1zY1hNSW9MN0JuajFM?= =?utf-8?B?TTdrc3dtZlhXRUhxSndFdjV3ZWxnTlV2Vm1IRFpEVTdrcDk5Vk5yeU5xMktw?= =?utf-8?B?cklhczBlNjN5YzJ0ek8ydEJaRjBvWFVzMmhKNTFZRllKNlQ2cHAvM3NRZzhH?= =?utf-8?B?bE9laHRxeXFuNDQrWGlLT2NTZkRSM1F1Tjcra1dKaU15aE1DTjlrVEwzdTdS?= =?utf-8?B?QUxzR3JYc0svSllVQnRKSUNKbGN6c3hMOCsxOTFXRHg4SUd5em42aEk5amlt?= =?utf-8?B?YWtnMVhiK1FHbUNTNzhmbG9wdDR1WlVneHorSkxJSis1YTRzeWJsR2Jnck9V?= =?utf-8?B?YUE3NVlIR0VYSmxFcW9tTDExSlp5STduK1NqNHFvVE1oR1dGT1E3cWFxRUg1?= =?utf-8?B?NU1Ecnh2RXhKMEtsRmNWdURVanY3dzZnWDVKNlNyWXB3alNxajFHeFVVcldV?= =?utf-8?B?blhYN2FadWdZL0RjcnJEZlRBbGRPYUx5d296eS9UQlMrSHk5bG04QW9XektW?= =?utf-8?B?YmFUSjRXVlljRThPMVFna0RuNEpqWkRtOWpmcWcxOUovUXE5UTIweEpPYVd6?= =?utf-8?B?dUNkRGJBVjdBT2p6dnlLSGg2MFM1SkR1azFJVVZmcnlwU2NDaVBVN2hWSml0?= =?utf-8?B?SVFOV04xL3pTd09nWU8vS1RvQVFOTGZ5akNralVNRnhONTBJZjVPTURIWExv?= =?utf-8?B?VGQ4b1dFd0xvaHI4anRSWlJzR0R6bXE2SnhSYUJrNjVCeUFMMWV0MldtVi9J?= =?utf-8?B?Q3hZOU9BY3JqWmI1L1JhTGNNTE5vemJxTjF3L0N3RGpQeXE4dHNhR25mc0Q3?= =?utf-8?B?MXBybDBSOGVlSmRTdVM3cHhONXVFWmhYYjh2cVNnZGYzU3JTVlpuQ0dJWGhH?= =?utf-8?B?aVVaMG0zYkxTeDZhclVGKzlnTkoxenl3TW9WYjBEVzJZUnovUDVFcE9yeWc5?= =?utf-8?B?dWtvU0lOdVpjbE5FL2tvV1kzTEtnQ2ZlZy9pU1VBeDFiYzU1ZTZzQS9vbEtq?= =?utf-8?B?WlcxUGJPeHlOZzk0Vjd2blV4R1ZZWGNPYVJpdnJrZnczSDZrbkVHb3UrNE1O?= =?utf-8?B?SkEvVlZtRUVOMnZORUtqMDdCbGp1bDQ1NHFiSXFXaHNZS2hQNEFudEpMOG8x?= =?utf-8?B?NmFZMFgvd3dhbTBiVEl2dURRTklSZlZhRm1OcVdvNzhZZ1IwUDN1ZE92VjVk?= =?utf-8?B?ZUFYdkFhaDR5TVp3ZWVJSzg1N054UThtTkJmSWgrbnI5RG5PV2Z6dDdnMjZK?= =?utf-8?B?bUVvRTMvSFdUUXFFWUh4Q01TQXRmZk9tRENjdHFZbnVPbTZRUXhUUTlrZ2Vx?= =?utf-8?B?VTRuQnNudnFBSHJFeldOUCtoemowMEQzdkZmN1BlMktKYkJBdlVJd3poRGpn?= =?utf-8?B?MjlCZ1Z1TnJLTHFOOGZ2TTY3NEdXVmV2eE9ITFl1Wnc4UkhRZ01xc0dXTks4?= =?utf-8?B?UHZvNkZ3Q2tYWGlIdldrblkzNlIxN3JzNFdPWVZKUjJaVGIwTndWcDBkeHhN?= =?utf-8?B?alhEVVdTN2lCUmRvM2FtdUtlK21JaUNYRnhUTE1rRkhXdzFaZzRkQkhzZ0dp?= =?utf-8?B?Tm5GNUhEdFBkcmYvOW1mR2ZxYjZUNGtaNjNTVkRnWnhJMC95Wml2TDVIUjBo?= =?utf-8?B?ZXRFclAwWi9ZdDNXSXVIU1VSSFRIZUJycG82V01idjBmMGNpUHQ3d3BDRnBk?= =?utf-8?B?NlFwYlYyYWNuWW9LenpMMFJmWEI4c28vaVpLQXIwTmhVS2RHd0pTemU3RjFS?= =?utf-8?B?dXc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: bOtmzGK2bBs5p4SUJXBkwJmfRhgQaWO4yz0ptzGF3SO7/RpcZ0KsjNEnbMAEMa0OLsF5zjy/3GwEeY00ZxzMF+qIV/45gjGvcJ7dXLY+JHoKBUneOOMShjs1d4H9q0WE4T6rkOQyRHB/Hvv3oQF6ocRco7Dw7yq8WRjhffIr/GVI/kxHYlJE0+C9avryfESET1yIcK7FiCFO6kOzobuAh5jbyh8pPWZS8X3dEb/o1mMahYS0NoPh/ga2Xc8WgXwTLQFmrqIQ0OVo3fctYjtbDVOKavKHclKrbpl0af2fykO61yye9MxO+7FfZG6vYzl2LTEJ7Rc1nejOpBwBk43Zq4XenbkB0frINBWeTmntJcREeNDjgrXu8U57AJtiOpIt0Ytk5cYnk1Md5VZL9+jakprsHhNw7/E6SxKm8FmGF+5cembKSHbK5fdsC4dO8KykkrU57eIvWPCr2mSJCw48IgGpsgIq4mnhTWYggUIRZZ1wHi7X3r2bvJ2qCYwMpmXbHVU8tZ5CONfBh4mx5apVOU+FMBLKSX6Ez0QQ1pFwUwyXw8ardDhsswdeXBu8Rg7g4gPevMEA/yMlJ6kugZDyLR+/zU5yYmTPteiNjbQWZwbK96OR5XMyD70dEG/aHP7ydnSboFR2tNl7J3zmfM9OrgeexpHdwGMs85aaGVDBLl2SNSP9F/hAK5SRnaSXJRQvcYacDA/7xn6zxMDjZoOtolNpPWa1Jhepuba97dS9Wu59ZY0K32SXmqsU8sNvsfq+LTKS9+Fbj6OW8yF7L0INoQVlKDsrFF/sAJFwXjX64m5gLy/UanXZpfMwb4K31wf/ X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0d8365ff-dc0f-44a3-a98b-08db4c8ebbeb X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 11:00:12.9018 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZvV309/W5NsM/y4g14uMDgvugpWDTFjPQ6iqyBNMMXlzBaXIzIxr6sHP9c2HtCWfWallPG71SVpZkmzfwkXUTLuSIlgwFKZtFQiI43ij9Sg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR03MB7224 On 04/05/2023 11:47 am, Roger Pau Monné wrote: > On Thu, May 04, 2023 at 11:26:07AM +0100, Andrew Cooper wrote: >> Loading microcode can cause new features to appear. This has happened >> routinely since Spectre/Meltdown, and even the presence of new status bits can >> sometimes mean the administrator has no further actions to perform. >> >> Conversely, loading microcode can occasionally cause features to disappear. >> As with livepatching, it is very much the administrators responsibility to >> confirm that a late microcode load is safe on the intended system before >> rolling it out in production. >> >> Refresh the raw CPU policy after late microcode load appears to have done >> something, so xen-cpuid can reflect the updated state of the system. >> >> Signed-off-by: Andrew Cooper >> Reviewed-by: Jan Beulich > Acked-by: Roger Pau Monné Thanks. > I'm not fully sure it's worth calling calculate_raw_cpu_policy() if > updated != nr_cores, as it's possible the current CPU where the policy > is regenerated hasn't been updated. As said previously, updated != nr_cores may exist in principle, but it is not a corner case we should care about. If the system really is asymmetric after a late load, then it is probably not long for the world.  There is nothing Xen can do to recover. It is awkward that we're not on the BSP when collecting.  I think that part of the logic didn't survive the rebase over switching to stop-machine.  I'll add it to the gitlab ticket of minor ucode work, because it's not the end of the world. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu May 04 11:17:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 11:17:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529691.824360 (Exim 4.92) (envelope-from ) id 1puWx6-0004jy-It; Thu, 04 May 2023 11:16:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529691.824360; Thu, 04 May 2023 11:16:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puWx6-0004jr-G4; Thu, 04 May 2023 11:16:48 +0000 Received: by outflank-mailman (input) for mailman id 529691; Thu, 04 May 2023 11:16:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puWx5-0004jh-JF for xen-devel@lists.xenproject.org; Thu, 04 May 2023 11:16:47 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on062d.outbound.protection.outlook.com [2a01:111:f400:fe0e::62d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 273ec68d-ea6d-11ed-8611-37d641c3527e; Thu, 04 May 2023 13:16:45 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DUZPR04MB9793.eurprd04.prod.outlook.com (2603:10a6:10:4b0::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Thu, 4 May 2023 11:16:42 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6363.022; Thu, 4 May 2023 11:16:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 273ec68d-ea6d-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N64I1iwmbMxAKwEsaemQDBbUh78M9b+vl3vIpdg2byb4h15Ml2KyE4/FbqUjiBLsfAy+wEtv2pe47QduNqI13EZGjJtKOobaDJ3vmsBjpCMKZulOh9LbnpPIIItv4BDFw8mb/eBLsIuXEkeAt+/Wd8AJutbRn6CPfvm89S04SiVDQrXGxtINwnh+JUv4Aw/cPeMYqdqfbuuzRa2NsDRW6IF/rFy6Lo0AqhGr0uP2L3Dw7hjDzuvBNUByvgnShysbFpWIBXaYdh5GDi+Xr9OsLgMct3uy6nS+ZWQej2Ygdi1TSD5T/DCgJ4JMTTJ6EmjZbKX5A7ovIrdR8oHIh3EQlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2S3W2ejMYn/rH8lVeyeUbkQTvRytkuUemNf430mkBhQ=; b=RWzZlSFlSCpSS9pRfZHp7+gN4AiCw9sx7lVFLQXFvCw82wvRa4WB9A4/frYItAFccbX6WeeCn3ekSGbfSkwZHrbO9rKPNCT0Kpp6AcK8mOdDKgiWLG5daWuPByhF07VKdU1iu5BvXlKy3gddyO4RnVcp/M+LOE9/qzWjoBCbbzwSJoAZ84DzxuIj20vH3mPYpKKAacqDBXuilCLmgyM2b5Jy+9Ey/mllUHMQjheRmkuyh3ejaMvVSyqi2+3TbQRMAli+AWGdra648ARWR+1OF9EYBBKqHqLWiB7lKSniHGC8ZS/1IA9AF2QeJsNeF/V1v2fu41JghJoSnwfqWWwYtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2S3W2ejMYn/rH8lVeyeUbkQTvRytkuUemNf430mkBhQ=; b=ADer5v4rbHKDno4WhREKfnZZWNIPXp/jsi7xsA4Gw2yyH0LwVsYBYaNb/TgGuHmz39MvH8VTHG2R1Jpzr6N0+W/yKeMn/L2q1ShNBsC6p50B7eYWjCo90LcP5UY5vlRzGhnlrKJN98Btg2pbB45/XpOvIkamWRNJuX/oMwCAYFh0VKXBLSrJqDWIBVsvfGAqMq/zVrLHTi/UePR71AetgIbGEb5bNUkiXNZejH9LZntk1Qc6K2kPl9lA9QZT1VD4+DXZgh73IKKRI6GUlBKG7l6OoudNfr2V/xo7Q1ahYzgGSKoSkuE+x53wmXInwmcV78kGTGqHpBMiSm//orteSQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6e03df79-578b-165e-3935-58370b93e96d@suse.com> Date: Thu, 4 May 2023 13:16:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3 03/14 RESEND] cpufreq: Export intel_feature_detect Content-Language: en-US To: Jason Andryuk Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230501193034.88575-1-jandryuk@gmail.com> <20230501193034.88575-4-jandryuk@gmail.com> From: Jan Beulich In-Reply-To: <20230501193034.88575-4-jandryuk@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0130.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DUZPR04MB9793:EE_ X-MS-Office365-Filtering-Correlation-Id: fc258486-3d59-47f4-78b1-08db4c9109ea X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HIwKMs2YLwsCkBHnnJY+U0XWF+5LsfrgJvSlO/KrgIlaKc7E8uSWIOfRbnXT9CiG46cLJZVg2kDqTr0w1lZdcSK0I6+ilSpjitD8H+18jWqsf4deC9goPatvKsjS+yJBo0jViHGjifwpqxpWs/ygHXKVvfry5oA6GfA4V11A2ip9+YU8fetti8AlEWUA8YRV1vxBrkYY9e+vPZ57oBCfs7rO1CjtVBgKqJQRn6XOlirMBW/eg1Ncb4Lv9QM9CyFqVoB/4oP2Wiu5xzhPseIJnqAhqU/8NMhVt94dCiMqqSYthtT7pVEjgHV0ghBiUH6KBH32YrxQJ2B3BBDuI6urssOj5d6iO19JinWA0b64aonMxN/nyNLxPZjgZldVVvs3txFyfMlvHMZyTtmaIplFcWScomdWiY/6bYIsufL97yZeYw5HdV2D6k40uNxsvDWBMFsTtq/xvFmV7bG1O3wgY+1QVDcQHs0Luea5Htnj1DijIHwobJ5yEmRe86sx794Ml4pBp0EgZA9WtvRHBsUwEiouiT91lGjbzvw5Hi+DaN+t6CbW5eJV9OeNdmoLRoYGU5CNufgs29z1Ynk2BqVPYAJc98KFHmYrr/lXv3s87Fym4OLHRI9EiX3ruq15IUbhwyK4FEXM6Z/ijNHKiXXA8w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(376002)(366004)(346002)(39860400002)(136003)(451199021)(31696002)(6666004)(86362001)(41300700001)(6486002)(478600001)(36756003)(66476007)(66556008)(66946007)(4326008)(6916009)(558084003)(316002)(54906003)(5660300002)(2616005)(31686004)(6506007)(26005)(83380400001)(53546011)(6512007)(2906002)(186003)(8676002)(8936002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dWpJYXlEUU9jUk1wV3h4WHRKY3d5cFlHSGJWd1dLL0wyTENLb3NtVG11SEwv?= =?utf-8?B?Z052bGY2L2J6c1pxd3V6L1NFTHYrQmpYRzFiSkxmVmdBdloweFRkNXlnaFdx?= =?utf-8?B?dFFMNGJaNm9ZQkpabitsRVplUWhFbVNOWEY1TE52SDRERmZycFNkK3hhQ0VB?= =?utf-8?B?WTQxS2xTTGdUS2hHYWFyWDZCeS93OXB6UldJUURpTW1xTjlCWXdLOE1uZG93?= =?utf-8?B?K2RwVmdXMGZXMnA4cS85R2lUaHJRUDlSclBhbTRWbkJzcVdCbUMvSS9IZE52?= =?utf-8?B?cERTcngrL1RPQjZGdWNPdTFHSUJKZkdUR0h6NWdsVHdpVmNMRGZZQ2dTNnNK?= =?utf-8?B?d01CMzE5YVlsWURPYktFQ2Z0Snl6TzU3eXZTUXdkMHFwbndqTTU3S3AzZHlQ?= =?utf-8?B?dHlDNzErbW1WRXdVdXZ1WkJEL3FDTXBCNThMem40WVRTNjZPcFp5SUpuUXdL?= =?utf-8?B?SVl6M1FTMVloVG9oQ3hqSFJqSlJPOWpYc3VUc1lCYTdETEVJVWJLU2wwUWhw?= =?utf-8?B?TFM2YmdxdVpWeksvNW4wakNDNlRrWHdPTE94amRQTFpxaTlKaHhlTmJWQ1la?= =?utf-8?B?bzhab3NKZW0vdHBNdzZwRHlMZnBBUlY4TmtpTnFCMUtVSWZHMEphSGNIOGNZ?= =?utf-8?B?RDQ0eWZIbUV2WGFkQkNGMDZ1eGpwNGd4ZTk5SFc3TEhIamVHVER5VXcrQVVa?= =?utf-8?B?ZmV5YzFma2lHME1VQ2tJQ20rc0o5bFN5RldLYkZJQmdRMzJpN1RtN25WdVB0?= =?utf-8?B?Y1FIZ2w4YlBNSU1xc2VTV0tDYjNpLzlEeW1mU0pxeHA5N0ZURFVyd3pKOENv?= =?utf-8?B?d2NrMUVjcFlFaVUxQ0JMM0lIWnl1NW9vK0xveVIveUpzQ1JFVFFGekdmY2lS?= =?utf-8?B?bWQ0SW0yRUlnNzJHay9PQVZDYW55RlZQajFISWJ3RUVNS0lCb3B4VXdBNGhE?= =?utf-8?B?WjZsdE1zd0xSRzRNamQrNWx3VkpjSThabE1BOUhvTUhneUowTmFSbEcraGVy?= =?utf-8?B?SEVWOXM0TzdJVVFLeVFSMzJoRVJmdGFMWmFNZDZRRW5zVk8zN0IxWGV5azZ2?= =?utf-8?B?bzkxMXdQaExYdTlPcUpjWnR6dTQyRFVUbDMvYjFZU1BiM0FZa3V4K2tBLzVz?= =?utf-8?B?K29pdGVrUUhXZzV2bmpodnFGaW1Rd3kvN2k1b21uMFJaR3ZudW5GTDN2MzJy?= =?utf-8?B?aWdYU0NQU2pKdHRLVkRRZ3BKQ0dRaXZ4dTJ2MUVrTmRIenRnR0hjejJtMmpR?= =?utf-8?B?Y3FRMnhNTy93UXV4azc3L1RNWnBFTU5aRkJGTGdaSXl4d2ZqZTd0aUJzN25X?= =?utf-8?B?QXpiTWtUKy9ZR1hoa0xPQnhMMURUcHdNRFpHUldLcmJRS0VKOERJSkkxMGNU?= =?utf-8?B?dEhwaVZTdU02SlNjRHNrdDB5Mi8rR3BlVXJIalB6WEF2eWZsdmhtMzZncSs3?= =?utf-8?B?eTFSeFdtRjlwZllaeWtoWDhzVUZ1WTN6T3d2Rm5yVXZjOW5iSnFrNEpjeGts?= =?utf-8?B?clR3TmV6RU5yZnVsdUtXa0RnQVlDelQzTnJYMlJ0Sk44V04zWXBpa0J3T1FP?= =?utf-8?B?SUVNcFZiRFpLVXhrSnc5QVJiek42V2YwQnFUNzhSWXYrUVZCczJNWnVxbUR2?= =?utf-8?B?TVRHVXdvTXZtakd2NFJFV2MydHFTdlZOVytjOTVzalJDYW9PMmxmOUpkMjds?= =?utf-8?B?Q3oyMXpKL3NrWFIrSE1SanAwTGRNdHlTRUZqNGdtME1Pb2hIL1Y4eFJIcXRt?= =?utf-8?B?Y3pvTHV2UmE2YXkzOXljcldIT2d0a1BnTnhOTGRrMjNyS2hidmxNK2FtVnRp?= =?utf-8?B?NmtlQ00vWG9vT1hBQnlXSk40NFROZ0RCMlNIanE2WmFRUnNOSVBsbkxkR3JO?= =?utf-8?B?NjNDWGllajQwWmNjVVdRNDYwTmgxRzJQSENxdDJQUXJ5dTBxM2VrTjFubmcw?= =?utf-8?B?OTdUYkZSQXBpOUc4cnVhVlpNbXR5T2tUOXFIM1AxMWtXU3QyWFRsbjluU2FY?= =?utf-8?B?c3hERTVPUktCQ0U0MjMxeHg1d2R2cmYzU1FIRStURU9wLzNERTM0bTk0YjBU?= =?utf-8?B?YW5yR1Y3S1RDUHY3RFh2TkNndWEwbm0rL1ZFQXRYQ3RTUXlQZDVVZFJLSlAr?= =?utf-8?Q?4Dx370DvV7jUT4+Hv20Hnme4l?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc258486-3d59-47f4-78b1-08db4c9109ea X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 11:16:42.5134 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: M4U8hSPxoXLRjwgmBdo4RU0a/HVvVPoLKl1sRySQDGl4ou0pcIlYRbOuI5PxhR2twKFzwRFNGKemn7r+2ISLeg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DUZPR04MB9793 On 01.05.2023 21:30, Jason Andryuk wrote: > Export feature_detect as intel_feature_detect so it can be re-used by > HWP. > > Signed-off-by: Jason Andryuk Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Thu May 04 11:20:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 11:20:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529694.824370 (Exim 4.92) (envelope-from ) id 1puX07-0005Mb-2g; Thu, 04 May 2023 11:19:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529694.824370; Thu, 04 May 2023 11:19:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puX06-0005MU-V7; Thu, 04 May 2023 11:19:54 +0000 Received: by outflank-mailman (input) for mailman id 529694; Thu, 04 May 2023 11:19:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puX06-0005MO-5z for xen-devel@lists.xenproject.org; Thu, 04 May 2023 11:19:54 +0000 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [2a00:1450:4864:20::231]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 96bb6b96-ea6d-11ed-8611-37d641c3527e; Thu, 04 May 2023 13:19:52 +0200 (CEST) Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2ac770a99e2so4275701fa.3 for ; Thu, 04 May 2023 04:19:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 96bb6b96-ea6d-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1683199191; x=1685791191; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=dRu1hub18XXS79LypLt9yhwEdFG+s3JAgEck87ztnn4=; b=CD2xOqKJiY64uIDLEvUdH4nrCMj1/SaotQ5Vtl3OKvSDwx8OTFxkrTBN9fAxA7HIQJ kwVVL3ei/6R1l7gu35MAkAglzO9aapDx6qV63dAnkB2SFHjb0POAFkirRwEJTW6ZkFgY pk6MJt5AQATyZvFrEnLwcdG9tHP67E/3oiWME= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683199191; x=1685791191; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=dRu1hub18XXS79LypLt9yhwEdFG+s3JAgEck87ztnn4=; b=ltl2uhFlKERTRXZ/TJIu5esU+qinsbekhb0Fd8kQCxYb4mbuQ1/FazCckcqaMZqmDJ SVsjtD1Yzsliw2ghwAw4L06BwhiSzsHV4tzWpIH9Pwu4+B004UnpA9JyYbutlrc9tWwr CpoS9Oq8hjhFwxPxq/jerVwNEy6uXDpioqXIuG5mDpqAzmD4+ggwZicbyxbz2oxpwPrz wvlPruHAo4uphk13/r/RArEe+MZui17O/l5kVY3xzL3gU+eDPilipCiKMskp2ip7AZWx O36lZjzuH6PNY/i37gBNZHJSjUwaCprimLNzgvasl0x0wMX6ZO+coXza9axZYTR4pDmp r5uw== X-Gm-Message-State: AC+VfDzOwvlbW+iiEbV6aJmJmkKSLf/i1tkqeKXK62YiayKlVRKkm6qO rpMt1np1/4rLquLhn5NML+j5lHk0NvmY/mFedCruww54N7oy8+cZpXg= X-Google-Smtp-Source: ACHHUZ6rTR2qCy3sC0UC0jWppc45/LPmq3Oxk/pFN456EGX+D5pJJvnm0C5WyrxNeliUHm/f70ZVRtVb7sBA3YSErQg= X-Received: by 2002:a2e:8693:0:b0:2a9:f9d2:7b44 with SMTP id l19-20020a2e8693000000b002a9f9d27b44mr862210lji.40.1683199191120; Thu, 04 May 2023 04:19:51 -0700 (PDT) MIME-Version: 1.0 From: George Dunlap Date: Thu, 4 May 2023 12:19:39 +0100 Message-ID: Subject: [ANNOUNCE] Call for agenda items for 4 May Community Call @ 1500 UTC To: Xen-devel , Tamas K Lengyel , "intel-xen@intel.com" , "daniel.kiper@oracle.com" , Roger Pau Monne , Sergey Dyasli , Christopher Clark , Rich Persaud , Kevin Pearson , Juergen Gross , Paul Durrant , "Ji, John" , "edgar.iglesias@xilinx.com" , "robin.randhawa@arm.com" , Artem Mygaiev , Matt Spencer , Stewart Hildebrand , Volodymyr Babchuk , Jeff Kubascik , Stefano Stabellini , Julien Grall , Rian Quinn , "Daniel P. Smith" , =?UTF-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLRG91ZyBHb2xkc3RlaW4=?= , George Dunlap , David Woodhouse , =?UTF-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLQW1pdCBTaGFo?= , =?UTF-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLVmFyYWQgR2F1dGFt?= , Brian Woods , Robert Townley , Bobby Eshleman , =?UTF-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLQ29yZXkgTWlueWFyZA==?= , Olivier Lambert , Andrew Cooper , Ash Wilding , Rahul Singh , =?UTF-8?Q?Piotr_Kr=C3=B3l?= , Brendan Kerrigan , insurgo@riseup.net, Oleksandr Andrushchenko , Oleksandr Tyshchenko , Scott Davis , Anthony PERARD , Michal Orzel , Marc Ungeschikts , Zhiming Shen , Xenia Ragiadakou , =?UTF-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLSGVucnkgV2FuZw==?= , Per Bilse , Samuel Verschelde , Andrei Semenov , Yann Dirson , Bernhard Kaindl , =?UTF-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLTHVjYSBGYW5jZWxsdQ==?= , =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Content-Type: multipart/alternative; boundary="000000000000df92ab05fadc590f" --000000000000df92ab05fadc590f Content-Type: text/plain; charset="UTF-8" Hi all, The proposed agenda is in https://cryptpad.fr/pad/#/2/pad/edit/7Vv6erX9dwCazMfCZ4Hbnf8b/ and you can edit to add items. Alternatively, you can reply to this mail directly. Agenda items appreciated a few days before the call: please put your name besides items if you edit the document. Note the following administrative conventions for the call: * Unless, agreed in the previous meeting otherwise, the call is on the 1st Thursday of each month at 1600 British Time (either GMT or BST) * I usually send out a meeting reminder a few days before with a provisional agenda * To allow time to switch between meetings, we'll plan on starting the agenda at 16:05 sharp. Aim to join by 16:03 if possible to allocate time to sort out technical difficulties &c * If you want to be CC'ed please add or remove yourself from the sign-up-sheet at https://cryptpad.fr/pad/#/2/pad/edit/D9vGzihPxxAOe6RFPz0sRCf+/ Best Regards George == Dial-in Information == ## Meeting time 16:00 - 17:00 British time Further International meeting times: https://www.timeanddate.com/worldclock/meetingdetails.html?year=2023&month=5&day=4&hour=15&min=0&sec=0&p1=1234&p2=37&p3=224&p4=179 ## Dial in details Web: https://meet.jit.si/XenProjectCommunityCall Dial-in info and pin can be found here: https://meet.jit.si/static/dialInInfo.html?room=XenProjectCommunityCall --000000000000df92ab05fadc590f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Hi all,


The proposed agenda is in https:/= /cryptpad.fr/pad/#/2/pad/edit/7Vv6erX9dwCazMfCZ4Hbnf8b/=C2=A0and you ca= n edit to add items.=C2=A0 Alternatively, you can reply to this mail direct= ly.

Agenda items appreciated a few days before the call: please p= ut your name besides items if you edit the document.

Note the fol= lowing administrative conventions for the call:
* Unless, agreed in the = previous meeting otherwise, the call is on the 1st Thursday of each month a= t 1600 British Time (either GMT or BST)
* I usually send out a meeting r= eminder a few days before with a provisional agenda

* To allow ti= me to switch between meetings, we'll plan on starting the agenda at 16:= 05 sharp.=C2=A0 Aim to join by 16:03 if possible to allocate time to sort o= ut technical difficulties &c

* If you want to be CC'ed please= add or remove yourself from the sign-up-sheet at=C2=A0https://cryptpad.fr/= pad/#/2/pad/edit/D9vGzihPxxAOe6RFPz0sRCf+/

Best Regards
Ge= orge


=3D=3D Dial-in Information =3D=3D
## Meeting t= ime
16:00 - 17:00 British time
Further International meeting times:= =C2=A0https://www.timeanddate.com/worldclock/meetingdetails.html?year= =3D2023&month=3D5&day=3D4&hour=3D15&min=3D0&sec=3D0&= ;p1=3D1234&p2=3D37&p3=3D224&p4=3D179


## Dial = in details
Web:=C2=A0https://meet.jit.si/XenProjectCommunityCall

Dial-in info= and pin can be found here:

https://meet.jit.si/static= /dialInInfo.html?room=3DXenProjectCommunityCall

--000000000000df92ab05fadc590f-- From xen-devel-bounces@lists.xenproject.org Thu May 04 11:50:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 11:50:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529697.824380 (Exim 4.92) (envelope-from ) id 1puXTb-0001Ou-Gp; Thu, 04 May 2023 11:50:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529697.824380; Thu, 04 May 2023 11:50:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puXTb-0001On-Du; Thu, 04 May 2023 11:50:23 +0000 Received: by outflank-mailman (input) for mailman id 529697; Thu, 04 May 2023 11:45:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puXPA-0000SM-H5 for xen-devel@lists.xenproject.org; Thu, 04 May 2023 11:45:48 +0000 Received: from smtp-fw-2101.amazon.com (smtp-fw-2101.amazon.com [72.21.196.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 33c92210-ea71-11ed-8611-37d641c3527e; Thu, 04 May 2023 13:45:44 +0200 (CEST) Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-iad-1a-m6i4x-617e30c2.us-east-1.amazon.com) ([10.43.8.6]) by smtp-border-fw-2101.iad2.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2023 11:45:41 +0000 Received: from EX19D002EUA001.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan2.iad.amazon.com [10.40.163.34]) by email-inbound-relay-iad-1a-m6i4x-617e30c2.us-east-1.amazon.com (Postfix) with ESMTPS id CB41564DCA; Thu, 4 May 2023 11:45:39 +0000 (UTC) Received: from EX19D037EUB003.ant.amazon.com (10.252.61.119) by EX19D002EUA001.ant.amazon.com (10.252.50.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Thu, 4 May 2023 11:45:39 +0000 Received: from EX19D017EUB002.ant.amazon.com (10.252.51.51) by EX19D037EUB003.ant.amazon.com (10.252.61.119) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Thu, 4 May 2023 11:45:38 +0000 Received: from EX19D017EUB002.ant.amazon.com ([fe80::5ea2:5e50:d1b:734c]) by EX19D017EUB002.ant.amazon.com ([fe80::5ea2:5e50:d1b:734c%3]) with mapi id 15.02.1118.026; Thu, 4 May 2023 11:45:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 33c92210-ea71-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.co.uk; i=@amazon.co.uk; q=dns/txt; s=amazon201209; t=1683200745; x=1714736745; h=from:to:cc:subject:date:message-id:content-id: content-transfer-encoding:mime-version; bh=J0akEHc9aLCPKI1M4DlhScOC9UUiHnTvk5Sz2yRXswQ=; b=ginojQnXZR7cTsaj/KbEX48jTf4KZyoRRlIyhaIhJ6gP/IapAMO/un2P GhtZZHCEIzjFrDdkMEIOciC2QZ5s7xPnpGDGRSSsNUw6dZ01HiFyBTQ4/ +gh6imdtkIwXfESNw2OlAvCzeLrR+SxU+bZ783t721XvlZBSFBkgCxNO0 0=; X-IronPort-AV: E=Sophos;i="5.99,249,1677542400"; d="scan'208";a="321455840" From: "Hakobyan, Ruben" To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Jan Beulich CC: "xen-devel@lists.xenproject.org" , "Grall, Julien" , Andrew Cooper , Wei Liu Subject: Re: [PATCH] x86/msi: dynamically map pages for MSI-X tables Thread-Topic: [PATCH] x86/msi: dynamically map pages for MSI-X tables Thread-Index: AQHZfn3ya9GP9+Vv7EWd6l/G5jjEQQ== Date: Thu, 4 May 2023 11:45:38 +0000 Message-ID: <04EE5E8F-19DF-49B2-A63F-AC640D4BF9AE@amazon.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.106.82.18] Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 Precedence: Bulk T24gMDIvMDUvMjAyMywgMTE6MjMsIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6DQo+IE9uIFR1ZSwg TWF5IDAyLCAyMDIzIGF0IDEyOjE4OjA2UE0gKzAyMDAsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiA+ IE9uIDAyLjA1LjIwMjMgMTI6MTAsIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6DQo+ID4gPiBPbiBX ZWQsIEFwciAyNiwgMjAyMyBhdCAwMjo1NToyMFBNICswMDAwLCBSdWJlbiBIYWtvYnlhbiB3cm90 ZToNCj4gPiA+PiBYZW4gcmVzZXJ2ZXMgYSBjb25zdGFudCBudW1iZXIgb2YgcGFnZXMgdGhhdCBj YW4gYmUgdXNlZCBmb3IgbWFwcGluZw0KPiA+ID4+IE1TSS1YIHRhYmxlcy4gVGhpcyBsaW1pdCBp cyBkZWZpbmVkIGJ5IEZJWF9NU0lYX01BWF9QQUdFUyBpbiBmaXhtYXAuaC4NCj4gPiA+Pg0KPiA+ ID4+IFJlc2VydmluZyBhIGZpeGVkIG51bWJlciBvZiBwYWdlcyBjb3VsZCByZXN1bHQgaW4gYW4g LUVOT01FTSBpZiBhDQo+ID4gPj4gZGV2aWNlIHJlcXVlc3RzIGEgbmV3IHBhZ2Ugd2hlbiB0aGUg Zml4bWFwIGxpbWl0IGlzIGV4aGF1c3RlZCBhbmQgd2lsbA0KPiA+ID4+IG5lY2Vzc2l0YXRlIG1h bnVhbGx5IGFkanVzdGluZyB0aGUgbGltaXQgYmVmb3JlIGNvbXBpbGF0aW9uLg0KPiA+ID4+DQo+ ID4gPj4gVG8gYXZvaWQgdGhlIGlzc3VlcyB3aXRoIHRoZSBjdXJyZW50IGZpeG1hcCBpbXBsZW1l bnRhdGlvbiwgd2UgbW9kaWZ5DQo+ID4gPj4gdGhlIE1TSS1YIHBhZ2UgbWFwcGluZyBsb2dpYyB0 byBpbnN0ZWFkIGR5bmFtaWNhbGx5IG1hcCBuZXcgcGFnZXMgd2hlbg0KPiA+ID4+IHRoZXkgYXJl IG5lZWRlZCBieSBtYWtpbmcgdXNlIG9mIGlvcmVtYXAoKS4NCj4gPiA+DQo+ID4gPiBJIHdvbmRl ciBpZiBBcm0gcGxhbnMgdG8gcmV1c2UgdGhpcyBjb2RlLCBhbmQgd2hldGhlciB0aGVuIGFybTMy IHdvdWxkDQo+ID4gPiBiZXR0ZXIga2VlcCB0aGUgZml4bWFwIGltcGxlbWVudGF0aW9uIHRvIGF2 b2lkIGV4aGF1c3RpbmcgdmlydHVhbA0KPiA+ID4gYWRkcmVzcyBzcGFjZSBpbiB0aGF0IGNhc2Uu DQo+ID4NCj4gPiBJIHRoaW5rIHRoaXMgd291bGQgdGhlbiBuZWVkIHRvIGJlIHNvbWV0aGluZyB0 aGF0IDMyLWJpdCBhcmNoaXRlY3R1cmVzDQo+ID4gZG8gc3BlY2lhbGx5LiBSaWdodCBub3cgYWl1 aSBQQ0kgKGFuZCBoZW5jZSBNU0ktWCkgd29yayBvbiBBcm0gdGFyZ2V0cw0KPiA+IG9ubHkgQXJt NjQuDQo+ID4NCj4gPiA+IFRoaXMgYWxzbyBoYXZlIHRoZSBzaWRlIGVmZmVjdCBvZiBpb3JlbWFw KCkgbm93IHBvc3NpYmx5IGFsbG9jYXRpbmcgYQ0KPiA+ID4gcGFnZSBpbiBvcmRlciB0byBmaWxs IHRoZSBwYWdlIHRhYmxlIGZvciB0aGUgbmV3bHkgYWxsb2NhdGVkIFZBLg0KPiA+DQo+ID4gSW5k ZWVkLCBidXQgSSB0aGluayB0aGUgKHZhZ3VlKSBwbGFuIHRvIHN3aXRjaCB0byBpb3JlbWFwKCkg aGFzIGJlZW4NCj4gPiBhcm91bmQgZm9yIGEgcHJldHR5IGxvbmcgdGltZSAocGVyaGFwcyBmb3Jl dmVyIHNpbmNlIDMyLWJpdCBzdXBwb3J0DQo+ID4gd2FzIHB1cmdlZCkuDQo+DQo+DQo+IFl1cCwg SSdtIG5vdCBzYXlpbmcgdGhlIGFib3ZlIHNob3VsZCBibG9jayB0aGUgcGF0Y2gsIGJ1dCBtaWdo dCBiZQ0KPiB3b3J0aCBtZW50aW9uaW5nIGluIHRoZSBjb21taXQgbWVzc2FnZS4NCj4NCj4NCj4g Um9nZXIuDQoNClN1cmUsIEkgd2lsbCBhZGQgYSBub3RlIGluIHRoZSBjb21taXQgbWVzc2FnZSBy ZWdhcmRpbmcgdGhlIHBvc3NpYmxlIHVzZQ0Kb2YgdGhpcyBwYXRjaCBmb3IgMzItYml0IGFyY2hp dGVjdHVyZXMuDQoNClJlZ2FyZGluZyBvdGhlciBjb21tZW50cyB5b3UgbWFkZSBvbiB0aGUgcGF0 Y2gsIEkgaGF2ZSBub3RlZCB0aGVtIGFsbA0KYW5kIGFncmVlIHdpdGggeW91ciBzdWdnZXN0aW9u cy4gSSB3aWxsIHNlbmQgb3V0IGEgbmV3IHZlcnNpb24uDQoNClRoYW5rcyBmb3IgcmV2aWV3aW5n IHRoZSBwYXRjaCENCg0KUnViZW4uDQoNCg== From xen-devel-bounces@lists.xenproject.org Thu May 04 12:51:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 12:51:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529713.824390 (Exim 4.92) (envelope-from ) id 1puYQs-000060-46; Thu, 04 May 2023 12:51:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529713.824390; Thu, 04 May 2023 12:51:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puYQs-00005t-18; Thu, 04 May 2023 12:51:38 +0000 Received: by outflank-mailman (input) for mailman id 529713; Thu, 04 May 2023 12:51:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puYQq-00005l-On for xen-devel@lists.xenproject.org; Thu, 04 May 2023 12:51:36 +0000 Received: from so254-35.mailgun.net (so254-35.mailgun.net [198.61.254.35]) by se1-gles-sth1.inumbo.com (Halon) with UTF8SMTPS id 65cddc4c-ea7a-11ed-b226-6b7b168915f2; Thu, 04 May 2023 14:51:34 +0200 (CEST) Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) by 075b51505512 with SMTP id 6453aa548a040ae8e21ea421 (version=TLS1.3, cipher=TLS_AES_128_GCM_SHA256); Thu, 04 May 2023 12:51:32 GMT Received: by mail-yb1-f181.google.com with SMTP id 3f1490d57ef6-b9e2b65d006so699408276.3 for ; Thu, 04 May 2023 05:51:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 65cddc4c-ea7a-11ed-b226-6b7b168915f2 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=tklengyel.com; q=dns/txt; s=mailo; t=1683204692; x=1683211892; h=Content-Type: Cc: To: To: Subject: Subject: Message-ID: Date: From: From: In-Reply-To: References: MIME-Version: Sender: Sender; bh=tkmb9S4Tg8bEdHenLjg9YyLXaYTYGV68ajT5w+c8RTk=; b=CRnPQ7toi6oiH0sWpacXVwrTjYHyFZMcc1eRVgXHjdOpI3NILjg89tuJ0GOOXQathIbN80qP7WIj0yC1mBM21JBI28KHNquobZl9ozflLPijQNHxFR3eNSNrXhhnasHxRIqrLox99XeFodEV77Nfageu7AwUG59ESuW5CPY3Qd/m3auQFti2NVqgydvYMyZ1Uucu/IggAmbZdarBC5aIE8il0y5vyD8NKL6MdqJXudXGgYvvGoKo9rUZvrfoEFiX21KEpD/0K78xFc/FgmuB92G9DjnGlcabq4l5EqSJvYwrQ5hRwkOaUlLraUUvqW2d+ytvZPKdogB0ofujRjVqfg== X-Mailgun-Sending-Ip: 198.61.254.35 X-Mailgun-Sid: WyIyYTNmOCIsInhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZyIsImNkODQwIl0= Sender: tamas@tklengyel.com X-Gm-Message-State: AC+VfDz2uXMlH7itspENrfJSdwHWXJdlI4pK6zIlPSkX1Ev87IfvCWXB +AV7FuUUZeTpB7t/t0FtYiZgpytA/4QDxglG1FU= X-Google-Smtp-Source: ACHHUZ4ejql2sxB+MnupfVRD4actJYR8J2/WGcWm5vTmppRT4fbnkZIRRcRhFn5GKu8P5oyvrJ0mQbm+3sD8QuODJG0= X-Received: by 2002:a25:240c:0:b0:b99:58d3:7ea2 with SMTP id k12-20020a25240c000000b00b9958d37ea2mr23810039ybk.24.1683204692325; Thu, 04 May 2023 05:51:32 -0700 (PDT) MIME-Version: 1.0 References: <472f8314-9ad7-523a-32dc-d5c2138c2c8c@suse.com> In-Reply-To: From: Tamas K Lengyel Date: Thu, 4 May 2023 08:50:55 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 4/8] x86/mem-sharing: copy GADDR based shared guest areas To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Content-Type: multipart/alternative; boundary="000000000000c53e9205fadda1bd" --000000000000c53e9205fadda1bd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, May 4, 2023 at 3:44=E2=80=AFAM Jan Beulich wrot= e: > > On 03.05.2023 19:14, Tamas K Lengyel wrote: > >> @@ -1974,7 +2046,10 @@ int mem_sharing_fork_reset(struct domain > >> > >> state: > >> if ( reset_state ) > >> + { > >> rc =3D copy_settings(d, pd); > >> + /* TBD: What to do here with -ERESTART? */ > > > > Ideally we could avoid hitting code-paths that are restartable during fork > > reset since it gets called from vm_event replies that have no concept o= f > > handling errors. If we start having errors like this we would just have to > > drop the vm_event reply optimization and issue a standalone fork reset > > hypercall every time which isn't a big deal, it's just slower. > > I'm afraid I don't follow: We are in the process of fork-reset here. How > would issuing "a standalone fork reset hypercall every time" make this > any different? The possible need for a continuation here comes from a > failed spin_trylock() in map_guest_area(). That won't change the next > time round. Why not? Who is holding the lock and why wouldn't it ever relinquish it? If that's really true then there is a larger issue then just not being able to report the error back to the user on vm_event_resume path and we need to devise a way of being able to copy this from the parent bypassing this lock. The parent is paused and its state should not be changing while forks are active, so if the lock was turned into an rwlock of some sort so we can acquire the read-lock would perhaps be a possible way out of this. > > But perhaps I should say that till now I didn't even pay much attention > to the 2nd use of the function by vm_event_resume(); I was mainly > focused on the one from XENMEM_sharing_op_fork_reset, where no > continuation handling exists. Yet perhaps your comment is mainly > related to that use? > > I actually notice that the comment ahead of the function already has a > continuation related TODO, just that there thought is only of larger > memory footprint. With XENMEM_sharing_op_fork_reset the caller actually receives the error code and can decide what to do next. With vm_event_resume there is no path currently to notify the agent of an error. We could generate another vm_event to send such an error, but the expectation with fork_reset is that it will always work because the parent is paused, so not having that path for an error to get back to the agent isn't a big deal. Now, if it becomes the case that due to this locking we can get an error even while the parent is paused, that will render the vm_event_resume path unreliably so we would just switch to using XENMEM_sharing_op_fork_reset so that at least it can re-try in case of an issue. Of course, only if a reissue of the hypercall has any reasonable chance of succeeding. > > > My > > preference would actually be that after the initial forking is performed a > > local copy of the parent's state is maintained for the fork to reset to so > > there would be no case of hitting an error like this. It would also allow > > us in the future to unpause the parent for example.. > > Oh, I guess I didn't realize the parent was kept paused. Such state > copying / caching may then indeed be a possibility, but that's nothing > I can see myself deal with, even less so in the context of this series. > I need a solution to the problem at hand within the scope of what is > there right now (or based on what could be provided e.g. by you within > the foreseeable future). Bubbling up the need for continuation from the > XENMEM_sharing_op_fork_reset path is the most I could see me handle > myself ... For vm_event_resume() bubbling state up the domctl path > _may_ also be doable, but mem_sharing_notification() and friends don't > even check the function's return value. Sure, I wasn't expecting that work to be done as part of this series, just as something I would like to get to in the future. Tamas --000000000000c53e9205fadda1bd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Thu, May 4, 2023 at 3:44=E2=80=AFAM Jan Beulich= <jbeulich@suse.com> wrote:<= br>>
> On 03.05.2023 19:14, Tamas K Lengyel wrote:
> >>= ; @@ -1974,7 +2046,10 @@ int mem_sharing_fork_reset(struct domain
> &= gt;>
> >> =C2=A0 state:
> >> =C2=A0 =C2=A0 =C2= =A0if ( reset_state )
> >> + =C2=A0 =C2=A0{
> >> = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0rc =3D copy_settings(d, pd);
> >= > + =C2=A0 =C2=A0 =C2=A0 =C2=A0/* TBD: What to do here with -ERESTART? *= /
> >
> > Ideally we could avoid hitting code-paths that = are restartable during fork
> > reset since it gets called from vm= _event replies that have no concept of
> > handling errors. If we = start having errors like this we would just have to
> > drop the v= m_event reply optimization and issue a standalone fork reset
> > h= ypercall every time which isn't a big deal, it's just slower.
&g= t;
> I'm afraid I don't follow: We are in the process of fork= -reset here. How
> would issuing "a standalone fork reset hyperc= all every time" make this
> any different? The possible need for= a continuation here comes from a
> failed spin_trylock() in map_gues= t_area(). That won't change the next
> time round.

Why not? Who is holding the lock and why wouldn't it ev= er relinquish it? If that's really true then there is a larger issue th= en just not being able to report the error back to the user on vm_event_res= ume path and we need to devise a way of being able to copy this from the pa= rent bypassing this lock. The parent is paused and its state should not be = changing while forks are active, so if the lock was turned into an rwlock o= f some sort so we can acquire the read-lock would perhaps be a possible way= out of this.

>
> But perhaps I should say= that till now I didn't even pay much attention
> to the 2nd use = of the function by vm_event_resume(); I was mainly
> focused on the o= ne from XENMEM_sharing_op_fork_reset, where no
> continuation handlin= g exists. Yet perhaps your comment is mainly
> related to that use?>
> I actually notice that the comment ahead of the function alr= eady has a
> continuation related TODO, just that there thought is on= ly of larger
> memory footprint.

With= =20 XENMEM_sharing_op_fork_reset the caller actually receives the error code an= d can decide what to do next. With=20 vm_event_resume there is no path currently to notify the agent of an error.= We could generate another vm_event to send such an error, but the expectat= ion with fork_reset is that it will always work because the parent is pause= d, so not having that path for an error to get back to the agent isn't = a big deal.

Now, if it becomes the case that due t= o this locking we can get an error even while the parent is paused, that wi= ll render the=20 vm_event_resume path unreliably so we would just switch to using=20 XENMEM_sharing_op_fork_reset so that at least it can re-try in case of an i= ssue. Of course, only if a reissue of the hypercall has any reasonable chan= ce of succeeding.

>
> > My
> >= preference would actually be that after the initial forking is performed a=
> > local copy of the parent's state is maintained for the fo= rk to reset to so
> > there would be no case of hitting an error l= ike this. It would also allow
> > us in the future to unpause the = parent for example..
>
> Oh, I guess I didn't realize the p= arent was kept paused. Such state
> copying / caching may then indeed= be a possibility, but that's nothing
> I can see myself deal wit= h, even less so in the context of this series.
> I need a solution to= the problem at hand within the scope of what is
> there right now (o= r based on what could be provided e.g. by you within
> the foreseeabl= e future). Bubbling up the need for continuation from the
> XENMEM_sh= aring_op_fork_reset path is the most I could see me handle
> myself .= .. For vm_event_resume() bubbling state up the domctl path
> _may_ al= so be doable, but mem_sharing_notification() and friends don't
> = even check the function's return value.

Sure, I = wasn't expecting that work to be done as part of this series, just as s= omething I would like to get to in the future.

Tamas
--000000000000c53e9205fadda1bd-- From xen-devel-bounces@lists.xenproject.org Thu May 04 13:08:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 13:08:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529717.824400 (Exim 4.92) (envelope-from ) id 1puYgr-0001ph-B4; Thu, 04 May 2023 13:08:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529717.824400; Thu, 04 May 2023 13:08:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puYgr-0001pa-8C; Thu, 04 May 2023 13:08:09 +0000 Received: by outflank-mailman (input) for mailman id 529717; Thu, 04 May 2023 13:08:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puYgp-0001pM-GT for xen-devel@lists.xenproject.org; Thu, 04 May 2023 13:08:07 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b45a5c5c-ea7c-11ed-8611-37d641c3527e; Thu, 04 May 2023 15:08:05 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b45a5c5c-ea7c-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683205685; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=q8H9vCnPnI2+EX1f/tER0jjkt7DS5cboSTFX7RAPK34=; b=ai3EXpsEZguNyPe5am29NZO5H7W+iMCLvnQCAhyKqfxCeLys4fArHA4H HYiYmor6CdT3uQzVlVNU7xOYeamLg8as2rqNrzoIDyLZBQKjhrxIUjXRd PMs6kv2H5/YwD7tsWOXeu7peFdajmz9Mi9xd89YAAfkFcf7OdV3eOkryT Q=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 110302272 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:faUxaKm4w6kXsJfZ72YKe9zo5gz3JkRdPkR7XQ2eYbSJt1+Wr1Gzt xJOXGHUOPuIZWOge91xbom2oBwH7JDUzYJlTwVo/HpnRiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aWaVA8w5ARkPqgW5AOGzhH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 cRfBQwAUDW/vrKZ55a/FdFeip4/HOC+aevzulk4pd3YJfMvQJSFSKTW/95Imjw3g6iiH96HO ZBfM2A2Kk2dPVsWYAx/5JEWxY9EglHWdTFCpU3Tjq0w+2XJlyR60aT3McqTcduPLSlQth/B/ jmepT6mWHn2MvTc82O1+yiC3dWQkCyrSZAIEJqc6OJ11Qj7Kms7V0RNCArTTeOColG6c8JSL QoT4CVGhbg/8gmnQ8fwWzW8oWWYpVgMVtxICeo45QqRjK3O7G6xJEIJUzpAY9wOr9ItSHoh0 Vrhoj/yLWUx6vvPEyvbr+rK62roYkD5MFPuewc8CiY57ufGnLhjoTXrSolbIqLvku3cTGSYL y+xkMQuu1kCpZdVh/7jpAqX3G3ESovhFVBsuFiONo6xxkYgPdP+OdT1gbTOxawYRLt1WGVtq 5TtdyK2yOkVRa+AmyWWKAnmNOH4vq3VWNEwbLMGInXAy9hO0yT5FWyoyGsiTHqFy+5dEdMTX GfduBlK+LhYN2awYKl8buqZUpp6lvG8TY29Dq+FM7Kih6RMmPKvpnkyNSZ8IUi0+KTTrU3PE cjCKpv9ZZrrIa9m0CC3V48g7FPf/QhnnTm7bcmin3yaPU+2OCb9pUEtbAHfMYjULcqs/G3oz jqoH5HWk08HDrelPUE6M+c7dDg3EJTyPriuw+Q/SwJJClAO9L0JYxMJ/Y4cRg== IronPort-HdrOrdr: A9a23:KY/HHKpx2IEENzHASm/RS7EaV5pIeYIsimQD101hICG9E/b5qy nKpp8mPHDP5Qr5NEtLpTniAsi9qA3nmqKdiLN5VYtKNzOLhILHFu9f0bc= X-Talos-CUID: =?us-ascii?q?9a23=3AXO32XminQGZewHj0g++mM3mpCDJuSjrw8HruBnO?= =?us-ascii?q?BWUlObLnKcW2cor9Uup87?= X-Talos-MUID: 9a23:kjJfygg3njKSgrJtOx/BFsMpd/0x0630Jhs3zpgJ69iWLyhXHymBk2Hi X-IronPort-AV: E=Sophos;i="5.99,249,1677560400"; d="scan'208";a="110302272" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH] x86/bitops: Drop include of cpufeatureset Date: Thu, 4 May 2023 14:07:55 +0100 Message-ID: <20230504130755.3181176-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Nothing in x86/bitops uses anything from x86/cpufeatureset, and it is creating problems when trying to untangle other aspects of feature handling. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/arch/x86/include/asm/bitops.h | 1 - 1 file changed, 1 deletion(-) diff --git a/xen/arch/x86/include/asm/bitops.h b/xen/arch/x86/include/asm/bitops.h index 5a71afbc89d5..aa8bd65b4565 100644 --- a/xen/arch/x86/include/asm/bitops.h +++ b/xen/arch/x86/include/asm/bitops.h @@ -6,7 +6,6 @@ */ #include -#include /* * We specify the memory operand as both input and output because the memory -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Thu May 04 13:12:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 13:12:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529720.824410 (Exim 4.92) (envelope-from ) id 1puYkI-0003Iy-QL; Thu, 04 May 2023 13:11:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529720.824410; Thu, 04 May 2023 13:11:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puYkI-0003Ir-Nb; Thu, 04 May 2023 13:11:42 +0000 Received: by outflank-mailman (input) for mailman id 529720; Thu, 04 May 2023 13:11:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puYkH-0003Ie-Ce for xen-devel@lists.xenproject.org; Thu, 04 May 2023 13:11:41 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20613.outbound.protection.outlook.com [2a01:111:f400:7d00::613]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 34299245-ea7d-11ed-8611-37d641c3527e; Thu, 04 May 2023 15:11:38 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7431.eurprd04.prod.outlook.com (2603:10a6:10:1a1::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Thu, 4 May 2023 13:11:36 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6363.022; Thu, 4 May 2023 13:11:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 34299245-ea7d-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JzSqEBGb0UHn+h3Or2FyV13NN5nYKGVPLDaugGq8/nPhvyu7avrqX9orK83eBimLi4EdOrU/YjezCajc2MloRgg6/D+p6lALW2rfNdK0DF/hf3/5+9aW1F8Lp7xU3lhKpgjiIUXwdsrFASiIZDi5rU1r/nAJb7blOiM2y5FbNCia0br8RkoKyJNuRYFhL7MPMkPdoLl0tUqr5/Vh8c5jN0S/cdfJUM/u1gdI7FpxF5IZkImP+xzR3bFFqsR4OY+IZ2P02UB9IhTkn83iNXaFzUyfoAD62JUFQ01wCAqsObumpR9cSNfPXmsj6jhv6voMqxPqx49imfjrEYwxCbYrxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vivl20jtCFC6k7pDANCpn5BJUzOuWxfdeeF4eIOCzUQ=; b=LtH4ra8AsQb6hJaMiQNfP/PeuBEo5S3co+OLbJ+3dX344uZdmwCssw5rwJX9c3DPZxzo6YNcE+Hgcdm45bT2q/oAQySWyhO+DfTo3wbeE7yLnV7DbzJbJZHqlhgJaW2Q0zn8bENeVGT1l9btGrLowFIsDtAJjNUEPuUUQi88MCHfLkTES72VGtNsH8768tXHjVSZMoArx4HuLbMrN5nbfQsfGKmPTjTMi90rjHQh/V7yccHZ0KOf7ji/gFlibgJdxQxozWX97LV4NGIKOwk3qHkVFQEYU9FQYn2NAG17eEBr0dq1L3GZCL/LGmpuXbErsmLRYfQRev3ttPMCVifIgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vivl20jtCFC6k7pDANCpn5BJUzOuWxfdeeF4eIOCzUQ=; b=26ISd0m4R71j7+lGVz9mYBUrmOVToN3KUXD8SdHjNMSsUfRdVlsXIEYM4PF398SLGyWj/7jC68u52wPcEOP/tDBtKiR+UgIX55yR+93Iy6wIiAEKQYlmVA+ATOhOganC2eeaiWlWM5sfa6KCD1qEK0+RmLi8UCYFa3uFIK4pqyX9XqHcFrOOHEerHFf3TTlMLJ4LizBo2U2l+TXuDGoeZCGAluGJezip0QZ9n9zTlum9xC5j/XfzNYZ/CD3GDgRz5biq8zxtqDQxA9JYJWuyoS7s3u/Tfc5uP48H+Txtx9bXerBvScreBIFYe1MxbHLZYL8QNNB7w/5P/zcc6Psc2g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <43c519f7-577d-f657-a4b1-1a31bf7f093a@suse.com> Date: Thu, 4 May 2023 15:11:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3 04/14 RESEND] cpufreq: Add Hardware P-State (HWP) driver Content-Language: en-US To: Jason Andryuk Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20230501193034.88575-1-jandryuk@gmail.com> <20230501193034.88575-5-jandryuk@gmail.com> From: Jan Beulich In-Reply-To: <20230501193034.88575-5-jandryuk@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0111.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7431:EE_ X-MS-Office365-Filtering-Correlation-Id: 1b7dbdf3-3dd3-4983-5ba9-08db4ca11698 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: w+mtcKiVR+xmriAsIpd5sBxv46mpA5dLp1ih9jZY/fRnviN/qAsDASPM4dVJ6dSv55jt0ARvEkvxwFtIn/aBC6tdMW3RoiPg/gBXc+pikr2GP99B1ZLvtEBj1WsKehGrz+eMjM5RPKrogUyNNN7hkyxMQ0KaC74sErEtyHlceZdyi+cB+eUjUey+6zqyRPRQw2LTyfBn9PfPe5Dm8mUuGhiI/2P1lRiwK3bzyjyg0wFJgy3GqKiIfw7pdTmYXFEHrPjfeyyBAT9ZrF7j3by5iYtfy7p3ENE2K2qFKYa7KLFbtizDamGtxGodN6szBUExaae1AMcovIpiYBKalw446MApuSOq3DNBkajC9w/ZRwfC3e8OqzRl9ie39/ik/iCj4lfvJm2ROi5QSTGmGkLFAkoR3kuzsEXRfeDAxIbRKBLNowDEHp6o2GFt5Lvl6zPkq7Wo2lVtpUyMnfxrOoThgNn+bbglu69lQVIM2gD8Z3pJTR6Y6hcNUzem0TrhOLl9qC2jMGMT8f7wnEtbCKxpdGe7V+R3xols56zMUU6UF7QlP+tmI/Cf3EZhdFNbnQGOqq4dRZmTE56uaW9WNeF3cNTgenhYuULl5htuHBEDtgTFc+YrzBMGsKDiSsMnJTHuXXdeTCTT6hgWuMNL2jrHHg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(396003)(376002)(346002)(136003)(366004)(451199021)(478600001)(5660300002)(8676002)(38100700002)(8936002)(2616005)(6916009)(54906003)(86362001)(6512007)(6506007)(26005)(6666004)(31696002)(66476007)(66556008)(66946007)(36756003)(6486002)(4326008)(83380400001)(31686004)(316002)(186003)(2906002)(53546011)(41300700001)(30864003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UUR3YnlpSmt1OW5PM0tMbGR4YlBsOUZuZXFhV2lHVkJDeGZwckc1T01MeTZl?= =?utf-8?B?QjcwUHJDdmFBV0JtRFQvc2lUeVhsMHdLMHNLY2xNQk9jbEowMFNuVFFUbnFN?= =?utf-8?B?SkloMk9yNUMrUjVXTnNWaEFDUHc0K2MrQXRWR1VVc3hXWjFLZjNQaTM3WlRv?= =?utf-8?B?SXNKdTE1cXhxQ0x3a3hROXlUOEF1M2tKUXdjRXBzbTZ5c0pkWmZSenJxL1pH?= =?utf-8?B?UDVVZ2lJc1NIOW42NkVVRXRzU2xwTDBuWXFEYnkrbmQ3dVlYbnFaMDhXN0wx?= =?utf-8?B?S0RRU3RMUnN6N3YwMFRSOVBwc0t4bmluNkEwU1NWQ0xoZHhCb2pScjlhMGN5?= =?utf-8?B?ZzBiZ2FxUHhJeDc4MFpWR2E1QmJNdkI3QUxtSC9OS1MwUXczb09aL1ZXKzVM?= =?utf-8?B?VmZaVkVBWGpmNnBlREtpeDNkUWErYlJRNkV3cWJHSGR3YkFmWXFFRUJ6QnZi?= =?utf-8?B?ZVJLTjlyTi9QMDgwWUllMkNPdGp1bGJqTUpSaVNJL21FNEh6bGF6V2FEcFZG?= =?utf-8?B?VU9GQm0zZ3owQjdmdFQ0ZGZRL2lJSHYyWW11bXdhQk9MKzVzRXhIa2RGcG90?= =?utf-8?B?UG5oVmxhRzUwUU5hdDhRS0hhSXZCdmlSczlKeHJsbzhScjVDdytPNStFWFpD?= =?utf-8?B?WmZPaXlBckkwSUM1MnZaYm1HN05xMkg5am1HRVRrY3lVN3ZVTkFCWHU2Ti9I?= =?utf-8?B?OG9GWXVqNVVHMi96b2xIK2drakZtV01JSVVFT3h3ekswclhQZlU1b2RlVXdD?= =?utf-8?B?amlwR3hsYnlIYmlRVkRKRTZ5NmFIS1MwaUJCS2t4RTRSOHFBTUVRMlVkK0px?= =?utf-8?B?V001THRXV1dCQnl2TXk5ZkdDVlNNdnU4RDVuMkhwVkE3a2Q0UFdtcTlqcDls?= =?utf-8?B?T2VLUTNVTG5EaENUdzZsUFZlMk1UK0RSN0hWempLQXVSVTM2VmJSL0l1R1lp?= =?utf-8?B?aHRtQWN3eXFSMkRGdHkrWFJKZ1BlMVI3RDBiUmtueW9HVlg4ZnhGaytwM3pR?= =?utf-8?B?VmV0MEsyZk03dG43alBXY2YzNExka29RazhHamtNSXNGMnFGOGpib0pCcWtK?= =?utf-8?B?cGs2YnhIVy9IdDFabkJhUUdtQjY0NVp4RnoxN2ZtWlQ0Mmg5QUtKNHN1ZGJP?= =?utf-8?B?cE0yOHRhZTJUSmd2VEpCTWZPbmlZUCtCZW9GMThjT0NTSGFUNUxkYlVSRmVX?= =?utf-8?B?UjIvUHBXYXFPRjNKZjBVaTlSNHFLYy9scUlVYlRZMVVKdWl4QnY0UEJ2Zk5C?= =?utf-8?B?RXpXNkJ5ckpwYXhXWkJta3BpRm1jd2EvWUh1bVJaK2pNbnQ3YzB3cjRsNFJW?= =?utf-8?B?Q0pjcnU4WWRQVlR2cVFFQURWZmZJUStjcVc5dHVuaUcyTCtrWERIY29LQlVJ?= =?utf-8?B?SnhvYmtJUXNyZHhHdVdFQ2oxWGpDcmhrcmxvT1JyQm1sZ0M1V0RWc09wTEZh?= =?utf-8?B?RG9ZTkpuL3lUL1lXT3JCUW5EVWpRRU5kdDZhTjdKcGN4bEhCMVlVVklsWE05?= =?utf-8?B?azkwNEF4cEZDdWl0dnlPM2tBN0lvOHVkSVR3ajU4NHQrKytMYmtrblY1Yktz?= =?utf-8?B?aFBGZ09oUGg5aWNEeVYzU1lwRThJL0NPSFMrRnBOUi9GcUtoUEF3L1RjZlhI?= =?utf-8?B?V0N0MjJ3bWpFb0JSaE11RWs3RFY1Z2t2UnkxVFdLeVJ4RXBySFd4RktMS051?= =?utf-8?B?YWhVejQ1eTQ4a1N2MDRHY1JDWllUK3RLcWxQYS9INW5nYnBvSXF1SDRtYWd6?= =?utf-8?B?NkdmN05nZjl2SmZEb21ONHBPMXBJUXpqTVRrbEZZZHRhN080UzhtbDNmUmJP?= =?utf-8?B?MEg2dzhlTjNRM2p1dUhiZ0lsVHhUZ0o5U0NWb2RMWGp5eUpLNlMzeDVnL1By?= =?utf-8?B?cTRrSm5YN0ZVSlhGd202RVFHMlptclJXcGEwZnAzM1JoQ2xCVWY5OEtGS0kw?= =?utf-8?B?MDRpeVJtWncxd1F2MkJaN2dEbG1QNGhNcEwyTWFtcUZ3NGxXT0dLeTJVVTVo?= =?utf-8?B?TUZqQkRJT1hTdVRkRjV1bTBWRm5mLzhEMEtJa2VTb2Rwc1FuaU9paEliSU8y?= =?utf-8?B?U1RXcWFzaXBVd2RjSDNsMFNPL2NXeE5DQ090K0ZNeWo2UnpmamRyc1FGcWZu?= =?utf-8?Q?HyxSM8M6V45VQO7UimoNClBlT?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1b7dbdf3-3dd3-4983-5ba9-08db4ca11698 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 13:11:35.7148 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 14EQqvdH1cDAfBqfCgPZ3jbidm6LapNVtCNYV7ssd5WUvsBz1D08iNbaWaUREr5hIOOyCgV5D0zDCMOTr7WI/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7431 On 01.05.2023 21:30, Jason Andryuk wrote: > For cpufreq=xen:hwp, placing the option inside the governor wouldn't > work. Users would have to select the hwp-internal governor to turn off > hwp support. I'm afraid I don't understand this, and you'll find a comment towards this further down. Even when ... > hwp-internal isn't usable without hwp, and users wouldn't > be able to select a different governor. That doesn't matter while hwp > defaults off, but it would if or when hwp defaults to enabled. ... it starts defaulting to enabled, selecting another governor can simply have the side effect of turning off hwp. > Write to disable the interrupt - the linux pstate driver does this. We > don't use the interrupts, so we can just turn them off. We aren't ready > to handle them, so we don't want any. Unclear if this is necessary. > SDM says it's default disabled. Definitely better to be on the safe side. > --- a/docs/misc/xen-command-line.pandoc > +++ b/docs/misc/xen-command-line.pandoc > @@ -499,7 +499,7 @@ If set, force use of the performance counters for oprofile, rather than detectin > available support. > > ### cpufreq > -> `= none | {{ | xen } [:[powersave|performance|ondemand|userspace][,][,[][,[verbose]]]]} | dom0-kernel` > +> `= none | {{ | xen } [:[powersave|performance|ondemand|userspace][,][,[]][,[]][,[]][,[verbose]]]} | dom0-kernel` Considering you use a special internal governor, the 4 governor alternatives are meaningless for hwp. Hence at the command line level recognizing "hwp" as if it was another governor name would seem better to me. This would then also get rid of one of the two special "no-" prefix parsing cases (which I'm not overly happy about). Even if not done that way I'm puzzled by the way you spell out the interaction of "hwp" and "hdc": As you say in the description, "hdc" is meaningful only when "hwp" was specified, so even if not merged with the governors group "hwp" should come first, and "hdc" ought to be rejected if "hwp" wasn't first specified. (The way you've spelled it out it actually looks to be kind of the other way around.) Strictly speaking "maxfreq" and "minfreq" also should be objected to when "hwp" was specified. Overall I'm getting the impression that beyond your "verbose" related adjustment more is needed, if you're meaning to get things closer to how we parse the option (splitting across multiple lines to help see what I mean): `= none | {{ | xen } [:{powersave|performance|ondemand|userspace} [{,hwp[,hdc]|[,maxfreq=[,minfreq=]}] [,verbose]]} | dom0-kernel` (We're still parsing in a more relaxed way, e.g. minfreq may come ahead of maxfreq, but better be more tight in the doc than too relaxed.) Furthermore while max/min freq don't apply directly, there are still two MSRs controlling bounds at the package and logical processor levels. > --- /dev/null > +++ b/xen/arch/x86/acpi/cpufreq/hwp.c > @@ -0,0 +1,506 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * hwp.c cpufreq driver to run Intel Hardware P-States (HWP) > + * > + * Copyright (C) 2021 Jason Andryuk > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +static bool feature_hwp; > +static bool feature_hwp_notification; > +static bool feature_hwp_activity_window; > +static bool feature_hwp_energy_perf; > +static bool feature_hwp_pkg_level_ctl; > +static bool feature_hwp_peci; > + > +static bool feature_hdc; Most (all?) of these want to be __ro_after_init, I expect. > +__initdata bool opt_cpufreq_hwp = false; > +__initdata bool opt_cpufreq_hdc = true; Nit (style): Please put annotations after the type. > +#define HWP_ENERGY_PERF_BALANCE 0x80 > +#define IA32_ENERGY_BIAS_BALANCE 0x7 > +#define IA32_ENERGY_BIAS_MAX_POWERSAVE 0xf > +#define IA32_ENERGY_BIAS_MASK 0xf > + > +union hwp_request > +{ > + struct > + { > + uint64_t min_perf:8; > + uint64_t max_perf:8; > + uint64_t desired:8; > + uint64_t energy_perf:8; > + uint64_t activity_window:10; > + uint64_t package_control:1; > + uint64_t reserved:16; > + uint64_t activity_window_valid:1; > + uint64_t energy_perf_valid:1; > + uint64_t desired_valid:1; > + uint64_t max_perf_valid:1; > + uint64_t min_perf_valid:1; The boolean fields here would probably better be of type "bool". I also don't see the need for using uint64_t for any of the other fields - unsigned int will be quite fine, I think. Only ... > + }; > + uint64_t raw; ... this wants to keep this type. (Same again below then.) > +bool __init hwp_available(void) > +{ > + unsigned int eax, ecx, unused; > + bool use_hwp; > + > + if ( boot_cpu_data.cpuid_level < CPUID_PM_LEAF ) > + { > + hwp_verbose("cpuid_level (%#x) lacks HWP support\n", > + boot_cpu_data.cpuid_level); > + return false; > + } > + > + if ( boot_cpu_data.cpuid_level < 0x16 ) > + { > + hwp_info("HWP disabled: cpuid_level %#x < 0x16 lacks CPU freq info\n", > + boot_cpu_data.cpuid_level); > + return false; > + } > + > + cpuid(CPUID_PM_LEAF, &eax, &unused, &ecx, &unused); > + > + if ( !(eax & CPUID6_EAX_HWP_ENERGY_PERFORMANCE_PREFERENCE) && > + !(ecx & CPUID6_ECX_IA32_ENERGY_PERF_BIAS) ) > + { > + hwp_verbose("HWP disabled: No energy/performance preference available"); > + return false; > + } > + > + feature_hwp = eax & CPUID6_EAX_HWP; > + feature_hwp_notification = eax & CPUID6_EAX_HWP_NOTIFICATION; > + feature_hwp_activity_window = eax & CPUID6_EAX_HWP_ACTIVITY_WINDOW; > + feature_hwp_energy_perf = > + eax & CPUID6_EAX_HWP_ENERGY_PERFORMANCE_PREFERENCE; > + feature_hwp_pkg_level_ctl = eax & CPUID6_EAX_HWP_PACKAGE_LEVEL_REQUEST; > + feature_hwp_peci = eax & CPUID6_EAX_HWP_PECI; > + > + hwp_verbose("HWP: %d notify: %d act-window: %d energy-perf: %d pkg-level: %d peci: %d\n", > + feature_hwp, feature_hwp_notification, > + feature_hwp_activity_window, feature_hwp_energy_perf, > + feature_hwp_pkg_level_ctl, feature_hwp_peci); > + > + if ( !feature_hwp ) > + return false; > + > + feature_hdc = eax & CPUID6_EAX_HDC; > + > + hwp_verbose("HWP: Hardware Duty Cycling (HDC) %ssupported%s\n", > + feature_hdc ? "" : "not ", > + feature_hdc ? opt_cpufreq_hdc ? ", enabled" : ", disabled" > + : ""); > + > + feature_hdc = feature_hdc && opt_cpufreq_hdc; > + > + hwp_verbose("HWP: HW_FEEDBACK %ssupported\n", > + (eax & CPUID6_EAX_HW_FEEDBACK) ? "" : "not "); You report this, but you don't really use it? > + use_hwp = feature_hwp && opt_cpufreq_hwp; There's a lot of output you may produce until you make it here, which is largely meaningless when opt_cpufreq_hwp == false. Is there a reason you don't check that flag first thing in the function? > +static void hdc_set_pkg_hdc_ctl(bool val) > +{ > + uint64_t msr; > + > + if ( rdmsr_safe(MSR_IA32_PKG_HDC_CTL, msr) ) > + { > + hwp_err("error rdmsr_safe(MSR_IA32_PKG_HDC_CTL)\n"); > + > + return; > + } > + > + if ( val ) > + msr |= IA32_PKG_HDC_CTL_HDC_PKG_ENABLE; > + else > + msr &= ~IA32_PKG_HDC_CTL_HDC_PKG_ENABLE; > + > + if ( wrmsr_safe(MSR_IA32_PKG_HDC_CTL, msr) ) > + hwp_err("error wrmsr_safe(MSR_IA32_PKG_HDC_CTL): %016lx\n", msr); > +} > + > +static void hdc_set_pm_ctl1(bool val) > +{ > + uint64_t msr; > + > + if ( rdmsr_safe(MSR_IA32_PM_CTL1, msr) ) > + { > + hwp_err("error rdmsr_safe(MSR_IA32_PM_CTL1)\n"); > + > + return; > + } > + > + if ( val ) > + msr |= IA32_PM_CTL1_HDC_ALLOW_BLOCK; > + else > + msr &= ~IA32_PM_CTL1_HDC_ALLOW_BLOCK; > + > + if ( wrmsr_safe(MSR_IA32_PM_CTL1, msr) ) > + hwp_err("error wrmsr_safe(MSR_IA32_PM_CTL1): %016lx\n", msr); > +} For both functions: Elsewhere you also log the affected CPU in hwp_err(). Without this I'm not convinced the logging here is very useful. In fact I wonder whether hwp_err() shouldn't take care of this and/or the "error" part of the string literal. A HWP: prefix might also not be bad ... > +static void hwp_get_cpu_speeds(struct cpufreq_policy *policy) > +{ > + uint32_t base_khz, max_khz, bus_khz, edx; > + > + cpuid(0x16, &base_khz, &max_khz, &bus_khz, &edx); > + > + /* aperf/mperf scales base. */ > + policy->cpuinfo.perf_freq = base_khz * 1000; > + policy->cpuinfo.min_freq = base_khz * 1000; > + policy->cpuinfo.max_freq = max_khz * 1000; > + policy->min = base_khz * 1000; > + policy->max = max_khz * 1000; > + policy->cur = 0; What is the comment intended to be telling me here? > +static void cf_check hwp_init_msrs(void *info) > +{ > + struct cpufreq_policy *policy = info; > + struct hwp_drv_data *data = this_cpu(hwp_drv_data); > + uint64_t val; > + > + /* > + * Package level MSR, but we don't have a good idea of packages here, so > + * just do it everytime. > + */ > + if ( rdmsr_safe(MSR_IA32_PM_ENABLE, val) ) > + { > + hwp_err("CPU%u: error rdmsr_safe(MSR_IA32_PM_ENABLE)\n", policy->cpu); > + data->curr_req.raw = -1; > + return; > + } > + > + /* Ensure we don't generate interrupts */ > + if ( feature_hwp_notification ) > + wrmsr_safe(MSR_IA32_HWP_INTERRUPT, 0); > + > + hwp_verbose("CPU%u: MSR_IA32_PM_ENABLE: %016lx\n", policy->cpu, val); > + if ( !(val & IA32_PM_ENABLE_HWP_ENABLE) ) > + { > + val |= IA32_PM_ENABLE_HWP_ENABLE; > + if ( wrmsr_safe(MSR_IA32_PM_ENABLE, val) ) > + { > + hwp_err("CPU%u: error wrmsr_safe(MSR_IA32_PM_ENABLE, %lx)\n", > + policy->cpu, val); > + data->curr_req.raw = -1; > + return; > + } > + } > + > + if ( rdmsr_safe(MSR_IA32_HWP_CAPABILITIES, data->hwp_caps) ) > + { > + hwp_err("CPU%u: error rdmsr_safe(MSR_IA32_HWP_CAPABILITIES)\n", > + policy->cpu); > + data->curr_req.raw = -1; > + return; > + } > + > + if ( rdmsr_safe(MSR_IA32_HWP_REQUEST, data->curr_req.raw) ) > + { > + hwp_err("CPU%u: error rdmsr_safe(MSR_IA32_HWP_REQUEST)\n", policy->cpu); > + data->curr_req.raw = -1; > + return; > + } > + > + if ( !feature_hwp_energy_perf ) { Nit: Brace placement. > + if ( rdmsr_safe(MSR_IA32_ENERGY_PERF_BIAS, val) ) > + { > + hwp_err("error rdmsr_safe(MSR_IA32_ENERGY_PERF_BIAS)\n"); > + data->curr_req.raw = -1; > + > + return; > + } > + > + data->energy_perf = val & IA32_ENERGY_BIAS_MASK; > + } In order to not need to undo the "enable" you've already done, maybe that should move down here? With all the sanity checking you do here, maybe you should also check that the write of the enable bit actually took effect? > +/* val 0 - highest performance, 15 - maximum energy savings */ > +static void hwp_energy_perf_bias(const struct hwp_drv_data *data) > +{ > + uint64_t msr; > + uint8_t val = data->energy_perf; > + > + ASSERT(val <= IA32_ENERGY_BIAS_MAX_POWERSAVE); > + > + if ( rdmsr_safe(MSR_IA32_ENERGY_PERF_BIAS, msr) ) > + { > + hwp_err("error rdmsr_safe(MSR_IA32_ENERGY_PERF_BIAS)\n"); > + > + return; > + } > + > + msr &= ~IA32_ENERGY_BIAS_MASK; > + msr |= val; > + > + if ( wrmsr_safe(MSR_IA32_ENERGY_PERF_BIAS, msr) ) > + hwp_err("error wrmsr_safe(MSR_IA32_ENERGY_PERF_BIAS): %016lx\n", msr); > +} > + > +static void cf_check hwp_write_request(void *info) > +{ > + struct cpufreq_policy *policy = info; > + struct hwp_drv_data *data = this_cpu(hwp_drv_data); > + union hwp_request hwp_req = data->curr_req; > + > + BUILD_BUG_ON(sizeof(union hwp_request) != sizeof(uint64_t)); > + if ( wrmsr_safe(MSR_IA32_HWP_REQUEST, hwp_req.raw) ) > + { > + hwp_err("CPU%u: error wrmsr_safe(MSR_IA32_HWP_REQUEST, %lx)\n", > + policy->cpu, hwp_req.raw); > + rdmsr_safe(MSR_IA32_HWP_REQUEST, data->curr_req.raw); > + } > + > + if ( !feature_hwp_energy_perf ) > + hwp_energy_perf_bias(data); > + > +} > + > +static int cf_check hwp_cpufreq_target(struct cpufreq_policy *policy, > + unsigned int target_freq, > + unsigned int relation) > +{ > + unsigned int cpu = policy->cpu; > + struct hwp_drv_data *data = per_cpu(hwp_drv_data, cpu); > + /* Zero everything to ensure reserved bits are zero... */ > + union hwp_request hwp_req = { .raw = 0 }; > + > + /* .. and update from there */ > + hwp_req.min_perf = data->minimum; > + hwp_req.max_perf = data->maximum; > + hwp_req.desired = data->desired; > + if ( feature_hwp_energy_perf ) > + hwp_req.energy_perf = data->energy_perf; > + if ( feature_hwp_activity_window ) > + hwp_req.activity_window = data->activity_window; > + > + if ( hwp_req.raw == data->curr_req.raw ) > + return 0; > + > + data->curr_req = hwp_req; > + > + hwp_verbose("CPU%u: wrmsr HWP_REQUEST %016lx\n", cpu, hwp_req.raw); > + on_selected_cpus(cpumask_of(cpu), hwp_write_request, policy, 1); > + > + return 0; > +} If I'm not mistaken these 3 functions can only be reached from the user space tool (via set_cpufreq_para()). On that path I don't think there should be any hwp_err(); definitely not in non-verbose mode. Instead it would be good if a sensible error code could be reported back. (Same then for hwp_cpufreq_update() and its helper.) > --- a/xen/arch/x86/include/asm/cpufeature.h > +++ b/xen/arch/x86/include/asm/cpufeature.h > @@ -46,8 +46,17 @@ extern struct cpuinfo_x86 boot_cpu_data; > #define cpu_has(c, bit) test_bit(bit, (c)->x86_capability) > #define boot_cpu_has(bit) test_bit(bit, boot_cpu_data.x86_capability) > > -#define CPUID_PM_LEAF 6 > -#define CPUID6_ECX_APERFMPERF_CAPABILITY 0x1 > +#define CPUID_PM_LEAF 6 > +#define CPUID6_EAX_HWP (_AC(1, U) << 7) > +#define CPUID6_EAX_HWP_NOTIFICATION (_AC(1, U) << 8) > +#define CPUID6_EAX_HWP_ACTIVITY_WINDOW (_AC(1, U) << 9) > +#define CPUID6_EAX_HWP_ENERGY_PERFORMANCE_PREFERENCE (_AC(1, U) << 10) > +#define CPUID6_EAX_HWP_PACKAGE_LEVEL_REQUEST (_AC(1, U) << 11) > +#define CPUID6_EAX_HDC (_AC(1, U) << 13) > +#define CPUID6_EAX_HWP_PECI (_AC(1, U) << 16) > +#define CPUID6_EAX_HW_FEEDBACK (_AC(1, U) << 19) Perhaps better without open-coding BIT()? I also find it a little odd that e.g. bit 17 is left out here despite you declaring the 5 "valid" bits in union hwp_request (which are qualified by this CPUID bit afaict). > +#define CPUID6_ECX_APERFMPERF_CAPABILITY 0x1 > +#define CPUID6_ECX_IA32_ENERGY_PERF_BIAS 0x8 Why not the same form here? > --- a/xen/arch/x86/include/asm/msr-index.h > +++ b/xen/arch/x86/include/asm/msr-index.h > @@ -151,6 +151,13 @@ > > #define MSR_PKRS 0x000006e1 > > +#define MSR_IA32_PM_ENABLE 0x00000770 > +#define IA32_PM_ENABLE_HWP_ENABLE (_AC(1, ULL) << 0) > + > +#define MSR_IA32_HWP_CAPABILITIES 0x00000771 > +#define MSR_IA32_HWP_INTERRUPT 0x00000773 > +#define MSR_IA32_HWP_REQUEST 0x00000774 I think for new MSRs being added here in particular Andrew would like to see the IA32 infixes omitted. (I'd extend this then to CPUID6_ECX_IA32_ENERGY_PERF_BIAS as well.) > @@ -165,6 +172,11 @@ > #define PASID_PASID_MASK 0x000fffff > #define PASID_VALID (_AC(1, ULL) << 31) > > +#define MSR_IA32_PKG_HDC_CTL 0x00000db0 > +#define IA32_PKG_HDC_CTL_HDC_PKG_ENABLE (_AC(1, ULL) << 0) The name has two redundant infixes, which looks odd, but then I can't suggest any better without going too much out of sync with the SDM. > --- a/xen/drivers/cpufreq/cpufreq.c > +++ b/xen/drivers/cpufreq/cpufreq.c > @@ -565,6 +565,38 @@ static void cpufreq_cmdline_common_para(struct cpufreq_policy *new_policy) > > static int __init cpufreq_handle_common_option(const char *name, const char *val) > { > + if (!strcmp(name, "hdc")) { > + if (val) { > + int ret = parse_bool(val, NULL); > + if (ret != -1) { > + opt_cpufreq_hdc = ret; > + return 1; > + } > + } else { > + opt_cpufreq_hdc = true; > + return 1; > + } > + } else if (!strcmp(name, "no-hdc")) { > + opt_cpufreq_hdc = false; > + return 1; > + } I think recognizing a "no-" prefix would want to be separated out, and be restricted to val being NULL. It would result in val being pointed at the string "no" (or "off" or anything else parse_bool() recognizes as negative indicator). Yet if, as suggested above, "hwp" became a "fake" governor also when parsing the command line, "hdc" could actually be handled in its handle_option() hook. Jan From xen-devel-bounces@lists.xenproject.org Thu May 04 13:12:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 13:12:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529725.824420 (Exim 4.92) (envelope-from ) id 1puYlW-0003u9-9O; Thu, 04 May 2023 13:12:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529725.824420; Thu, 04 May 2023 13:12:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puYlW-0003u2-5m; Thu, 04 May 2023 13:12:58 +0000 Received: by outflank-mailman (input) for mailman id 529725; Thu, 04 May 2023 13:12:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puYlU-0003tK-NK for xen-devel@lists.xenproject.org; Thu, 04 May 2023 13:12:56 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 61776874-ea7d-11ed-b226-6b7b168915f2; Thu, 04 May 2023 15:12:54 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6E4F22F4; Thu, 4 May 2023 06:13:38 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CFCBC3F67D; Thu, 4 May 2023 06:12:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 61776874-ea7d-11ed-b226-6b7b168915f2 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Michal Orzel Subject: [PATCH 0/3] Fix and improvements to xen-analysis.py Date: Thu, 4 May 2023 14:12:42 +0100 Message-Id: <20230504131245.2985400-1-luca.fancellu@arm.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This serie includes a fix for a limitation of xen-analysis.py that when using cppcheck and make parallel build, it was spuriously failing. The second patch is enabling the tool to accept cppcheck version above 2.7 (excluding 2.8 for the reasons described in the documentation). The final one is a fix for the generated cppcheck text report to include the relative path from the repository, instead that the relative path from the /xen/xen directory. Luca Fancellu (3): xen/misra: xen-analysis.py: fix parallel analysis Cppcheck errors xen/misra: xen-analysis.py: allow cppcheck version above 2.7 xen/misra: xen-analysis.py: use the relative path from the ... xen/scripts/xen_analysis/cppcheck_analysis.py | 36 ++++++++++++------- xen/tools/cppcheck-cc.sh | 19 +++++++++- 2 files changed, 41 insertions(+), 14 deletions(-) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu May 04 13:12:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 13:12:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529726.824430 (Exim 4.92) (envelope-from ) id 1puYlX-00049z-Gr; Thu, 04 May 2023 13:12:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529726.824430; Thu, 04 May 2023 13:12:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puYlX-00049q-E4; Thu, 04 May 2023 13:12:59 +0000 Received: by outflank-mailman (input) for mailman id 529726; Thu, 04 May 2023 13:12:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puYlW-0003tK-9n for xen-devel@lists.xenproject.org; Thu, 04 May 2023 13:12:58 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 633d48c4-ea7d-11ed-b226-6b7b168915f2; Thu, 04 May 2023 15:12:57 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6418112FC; Thu, 4 May 2023 06:13:41 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E283A3F67D; Thu, 4 May 2023 06:12:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 633d48c4-ea7d-11ed-b226-6b7b168915f2 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH 2/3] xen/misra: xen-analysis.py: allow cppcheck version above 2.7 Date: Thu, 4 May 2023 14:12:44 +0100 Message-Id: <20230504131245.2985400-3-luca.fancellu@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230504131245.2985400-1-luca.fancellu@arm.com> References: <20230504131245.2985400-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Allow the use of Cppcheck version above 2.7, exception for 2.8 which is known and documented do be broken. Signed-off-by: Luca Fancellu --- xen/scripts/xen_analysis/cppcheck_analysis.py | 20 +++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/xen/scripts/xen_analysis/cppcheck_analysis.py b/xen/scripts/xen_analysis/cppcheck_analysis.py index 658795bb9f5b..c3783e8df343 100644 --- a/xen/scripts/xen_analysis/cppcheck_analysis.py +++ b/xen/scripts/xen_analysis/cppcheck_analysis.py @@ -157,13 +157,25 @@ def generate_cppcheck_deps(): "Error occured retrieving cppcheck version:\n{}\n\n{}" ) - version_regex = re.search('^Cppcheck (.*)$', invoke_cppcheck, flags=re.M) + version_regex = re.search('^Cppcheck (\d+).(\d+)(?:.\d+)?$', + invoke_cppcheck, flags=re.M) # Currently, only cppcheck version >= 2.7 is supported, but version 2.8 is # known to be broken, please refer to docs/misra/cppcheck.txt - if (not version_regex) or (not version_regex.group(1).startswith("2.7")): + if (not version_regex) or len(version_regex.groups()) < 2: raise CppcheckDepsPhaseError( - "Can't find cppcheck version or version is not 2.7" - ) + "Can't find cppcheck version or version not identified: " + "{}".format(invoke_cppcheck) + ) + major = int(version_regex.group(1)) + minor = int(version_regex.group(2)) + if major < 2 or (major == 2 and minor < 7): + raise CppcheckDepsPhaseError( + "Cppcheck version < 2.7 is not supported" + ) + if major == 2 and minor == 8: + raise CppcheckDepsPhaseError( + "Cppcheck version 2.8 is known to be broken, see the documentation" + ) # If misra option is selected, append misra addon and generate cppcheck # files for misra analysis -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu May 04 13:13:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 13:13:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529727.824440 (Exim 4.92) (envelope-from ) id 1puYlY-0004Q1-O1; Thu, 04 May 2023 13:13:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529727.824440; Thu, 04 May 2023 13:13:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puYlY-0004Pu-Ku; Thu, 04 May 2023 13:13:00 +0000 Received: by outflank-mailman (input) for mailman id 529727; Thu, 04 May 2023 13:12:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puYlX-00049n-Kx for xen-devel@lists.xenproject.org; Thu, 04 May 2023 13:12:59 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 626d8b4b-ea7d-11ed-8611-37d641c3527e; Thu, 04 May 2023 15:12:56 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F0003C14; Thu, 4 May 2023 06:13:39 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5F9C63F67D; Thu, 4 May 2023 06:12:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 626d8b4b-ea7d-11ed-8611-37d641c3527e From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Michal Orzel Subject: [PATCH 1/3] xen/misra: xen-analysis.py: fix parallel analysis Cppcheck errors Date: Thu, 4 May 2023 14:12:43 +0100 Message-Id: <20230504131245.2985400-2-luca.fancellu@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230504131245.2985400-1-luca.fancellu@arm.com> References: <20230504131245.2985400-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently Cppcheck has a limitation that prevents to use make with parallel build and have a parallel Cppcheck invocation on each translation unit (the .c files), because of spurious internal errors. The issue comes from the fact that when using the build directory, Cppcheck saves temporary files as .c., but this doesn't work well when files with the same name are being analysed at the same time, leading to race conditions. Fix the issue creating, under the build directory, the same directory structure of the file being analysed to avoid any clash. Fixes: 02b26c02c7c4 ("xen/scripts: add cppcheck tool to the xen-analysis.py script") Signed-off-by: Luca Fancellu --- xen/scripts/xen_analysis/cppcheck_analysis.py | 8 +++----- xen/tools/cppcheck-cc.sh | 19 ++++++++++++++++++- 2 files changed, 21 insertions(+), 6 deletions(-) diff --git a/xen/scripts/xen_analysis/cppcheck_analysis.py b/xen/scripts/xen_analysis/cppcheck_analysis.py index ab52ce38d502..658795bb9f5b 100644 --- a/xen/scripts/xen_analysis/cppcheck_analysis.py +++ b/xen/scripts/xen_analysis/cppcheck_analysis.py @@ -139,7 +139,6 @@ def generate_cppcheck_deps(): # Compiler defines are in compiler-def.h which is included in config.h # cppcheck_flags=""" ---cppcheck-build-dir={}/{} --max-ctu-depth=10 --enable=style,information,missingInclude --template=\'{{file}}({{line}},{{column}}):{{id}}:{{severity}}:{{message}}\' @@ -150,8 +149,7 @@ def generate_cppcheck_deps(): --suppress='unusedStructMember:*' --include={}/include/xen/config.h -DCPPCHECK -""".format(settings.outdir, CPPCHECK_BUILD_DIR, settings.xen_dir, - settings.outdir, settings.xen_dir) +""".format(settings.xen_dir, settings.outdir, settings.xen_dir) invoke_cppcheck = utils.invoke_command( "{} --version".format(settings.cppcheck_binpath), @@ -204,9 +202,9 @@ def generate_cppcheck_deps(): cppcheck_cc_flags = """--compiler={} --cppcheck-cmd={} {} --cppcheck-plat={}/cppcheck-plat --ignore-path=tools/ - --ignore-path=arch/x86/efi/check.c + --ignore-path=arch/x86/efi/check.c --build-dir={}/{} """.format(xen_cc, settings.cppcheck_binpath, cppcheck_flags, - settings.tools_dir) + settings.tools_dir, settings.outdir, CPPCHECK_BUILD_DIR) if settings.cppcheck_html: cppcheck_cc_flags = cppcheck_cc_flags + " --cppcheck-html" diff --git a/xen/tools/cppcheck-cc.sh b/xen/tools/cppcheck-cc.sh index f6728e4c1084..16a965edb7ec 100755 --- a/xen/tools/cppcheck-cc.sh +++ b/xen/tools/cppcheck-cc.sh @@ -24,6 +24,7 @@ Options: EOF } +BUILD_DIR="" CC_FILE="" COMPILER="" CPPCHECK_HTML="n" @@ -66,6 +67,10 @@ do help exit 0 ;; + --build-dir=*) + BUILD_DIR="${OPTION#*=}" + sm_tool_args="n" + ;; --compiler=*) COMPILER="${OPTION#*=}" sm_tool_args="n" @@ -107,6 +112,12 @@ then exit 1 fi +if [ "${BUILD_DIR}" = "" ] +then + echo "--build-dir arg is mandatory." + exit 1 +fi + function create_jcd() { local line="${1}" local arg_num=0 @@ -199,13 +210,18 @@ then exit 1 fi + # Generate build directory for the analysed file + cppcheck_build_dir="${BUILD_DIR}/${OBJTREE_PATH}" + mkdir -p "${cppcheck_build_dir}" + # Shellcheck complains about missing quotes on CPPCHECK_TOOL_ARGS, but # they can't be used here # shellcheck disable=SC2086 ${CPPCHECK_TOOL} ${CPPCHECK_TOOL_ARGS} \ --project="${JDB_FILE}" \ --output-file="${out_file}" \ - --platform="${platform}" + --platform="${platform}" \ + --cppcheck-build-dir=${cppcheck_build_dir} if [ "${CPPCHECK_HTML}" = "y" ] then @@ -216,6 +232,7 @@ then --project="${JDB_FILE}" \ --output-file="${out_file%.txt}.xml" \ --platform="${platform}" \ + --cppcheck-build-dir=${cppcheck_build_dir} \ -q \ --xml fi -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu May 04 13:13:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 13:13:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529728.824446 (Exim 4.92) (envelope-from ) id 1puYlZ-0004Tv-67; Thu, 04 May 2023 13:13:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529728.824446; Thu, 04 May 2023 13:13:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puYlY-0004SZ-UU; Thu, 04 May 2023 13:13:00 +0000 Received: by outflank-mailman (input) for mailman id 529728; Thu, 04 May 2023 13:12:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puYlX-0003tK-OS for xen-devel@lists.xenproject.org; Thu, 04 May 2023 13:12:59 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 64104f88-ea7d-11ed-b226-6b7b168915f2; Thu, 04 May 2023 15:12:59 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CC979139F; Thu, 4 May 2023 06:13:42 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 56C753F67D; Thu, 4 May 2023 06:12:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 64104f88-ea7d-11ed-b226-6b7b168915f2 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH 3/3] xen/misra: xen-analysis.py: use the relative path from the ... Date: Thu, 4 May 2023 14:12:45 +0100 Message-Id: <20230504131245.2985400-4-luca.fancellu@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230504131245.2985400-1-luca.fancellu@arm.com> References: <20230504131245.2985400-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit repository in the reports Currently the cppcheck report entries shows the relative file path from the /xen folder of the repository instead of the base folder. In order to ease the checks, for example, when looking a git diff output and the report, use the repository folder as base. Signed-off-by: Luca Fancellu --- xen/scripts/xen_analysis/cppcheck_analysis.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/xen/scripts/xen_analysis/cppcheck_analysis.py b/xen/scripts/xen_analysis/cppcheck_analysis.py index c3783e8df343..c8abbe0fca79 100644 --- a/xen/scripts/xen_analysis/cppcheck_analysis.py +++ b/xen/scripts/xen_analysis/cppcheck_analysis.py @@ -149,7 +149,7 @@ def generate_cppcheck_deps(): --suppress='unusedStructMember:*' --include={}/include/xen/config.h -DCPPCHECK -""".format(settings.xen_dir, settings.outdir, settings.xen_dir) +""".format(settings.repo_dir, settings.outdir, settings.xen_dir) invoke_cppcheck = utils.invoke_command( "{} --version".format(settings.cppcheck_binpath), @@ -240,7 +240,7 @@ def generate_cppcheck_report(): try: cppcheck_report_utils.cppcheck_merge_txt_fragments(fragments, report_filename, - [settings.xen_dir]) + [settings.repo_dir]) except cppcheck_report_utils.CppcheckTXTReportError as e: raise CppcheckReportPhaseError(e) @@ -257,7 +257,7 @@ def generate_cppcheck_report(): try: cppcheck_report_utils.cppcheck_merge_xml_fragments(fragments, xml_filename, - settings.xen_dir, + settings.repo_dir, settings.outdir) except cppcheck_report_utils.CppcheckHTMLReportError as e: raise CppcheckReportPhaseError(e) @@ -265,7 +265,7 @@ def generate_cppcheck_report(): utils.invoke_command( "{} --file={} --source-dir={} --report-dir={}/html --title=Xen" .format(settings.cppcheck_htmlreport_binpath, xml_filename, - settings.xen_dir, html_report_dir), + settings.repo_dir, html_report_dir), False, CppcheckReportPhaseError, "Error occured generating Cppcheck HTML report:\n{}" ) @@ -273,7 +273,7 @@ def generate_cppcheck_report(): html_files = utils.recursive_find_file(html_report_dir, r'.*\.html$') try: cppcheck_report_utils.cppcheck_strip_path_html(html_files, - (settings.xen_dir, + (settings.repo_dir, settings.outdir)) except cppcheck_report_utils.CppcheckHTMLReportError as e: raise CppcheckReportPhaseError(e) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu May 04 13:15:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 13:15:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529741.824459 (Exim 4.92) (envelope-from ) id 1puYnR-00067X-FI; Thu, 04 May 2023 13:14:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529741.824459; Thu, 04 May 2023 13:14:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puYnR-00067Q-CU; Thu, 04 May 2023 13:14:57 +0000 Received: by outflank-mailman (input) for mailman id 529741; Thu, 04 May 2023 13:14:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puYnP-00067C-Se for xen-devel@lists.xenproject.org; Thu, 04 May 2023 13:14:56 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2062e.outbound.protection.outlook.com [2a01:111:f400:7d00::62e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a7ef1a09-ea7d-11ed-8611-37d641c3527e; Thu, 04 May 2023 15:14:53 +0200 (CEST) Received: from DB6PR0301CA0043.eurprd03.prod.outlook.com (2603:10a6:4:54::11) by AS8PR08MB7306.eurprd08.prod.outlook.com (2603:10a6:20b:441::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.25; Thu, 4 May 2023 13:14:49 +0000 Received: from DBAEUR03FT032.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:54:cafe::67) by DB6PR0301CA0043.outlook.office365.com (2603:10a6:4:54::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.21 via Frontend Transport; Thu, 4 May 2023 13:14:49 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT032.mail.protection.outlook.com (100.127.142.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22 via Frontend Transport; Thu, 4 May 2023 13:14:49 +0000 Received: ("Tessian outbound 99a3040377ca:v136"); Thu, 04 May 2023 13:14:49 +0000 Received: from e843eb7c2d31.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id AF0832D5-E534-47FB-AD98-B11EF29AF27D.1; Thu, 04 May 2023 13:14:38 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e843eb7c2d31.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 04 May 2023 13:14:38 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB9PR08MB7399.eurprd08.prod.outlook.com (2603:10a6:10:371::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Thu, 4 May 2023 13:14:35 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::9283:e527:bed8:ab23]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::9283:e527:bed8:ab23%7]) with mapi id 15.20.6363.022; Thu, 4 May 2023 13:14:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a7ef1a09-ea7d-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=roH7IhSKNfhABtOeE1XmF3YdKI+Xv0DCyrgQ3HF6/MI=; b=Tq5C7d4Qi7OxmnLzcn9wfN9nV3v+hJnjt06Fl7KfRYpZ1QuhZQJZSaf0KH8MHx1174eMVL3OtsobNCuealxdk4EKrf/u3uXYdouwpWZLUWuhxK/Grsl0lo1yvUhgtYJzOvwXh3eNZBOzmC0JVl/L6gMNhKuXYBaklWAb32rQ5s0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 9c0a31e43e31591e X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EaUfYwiJc684TKhFtkWq6kGX71yD7YzPA5Nhi31uCuB5BuphFSD699gmbSebSW5Feag90DJEY8HvKd+jPnC8AWSLypruVVp0D20S2fpAW2DJ/Tme2TMNKu6lvOFHuhjPueKf/lNaM2YENq2lkW2xdMKIPoMv2B4tIg64Shp8RY4WL2JSUXKwJyoJg3PlG8NRxUfr42YLOjggrrnbOgT1pKif2LP8UiBrhuf2PE4DeFjsCVWut0SQgYwjl0OqAqAoKAWdm6basN0lNFolbgIDosGz9p7RxOrfgtu0TiZbbd/Af0N0uv8J4D0d/Z7LHxHf7Otz/AJ1ujV3oT02QxpHOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=roH7IhSKNfhABtOeE1XmF3YdKI+Xv0DCyrgQ3HF6/MI=; b=UKvX6WVAagqDjeve7zt9i2EiLSdxUGZZo1AkM1623gIqzIIaSX8qz0pN35qWZwtVLaCFnubkTbDtAkWe0vU4dTm1GsHyuHVH9f0rBSAtZZMBCYPo7eKGHCdpX9JRHZZrlHr0wPS97x7AO58lNP/BDRTpSFFZJmqaGq2znr6FchCcIEB9qiUoP9PoUBozVqX+t9hKfyEB6210HW+nWZNTUO+9AINekwzlwyN+CGkNv1INloiHDnGWSNgzIcZl/+akbm8PozzuMAesZsWN23YFFkh1kptAqW0wockSoPbLYvu1gvsFrAk2Ywoik6yPF2G0Sh2QY6dpWuSWCVDUBussfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=roH7IhSKNfhABtOeE1XmF3YdKI+Xv0DCyrgQ3HF6/MI=; b=Tq5C7d4Qi7OxmnLzcn9wfN9nV3v+hJnjt06Fl7KfRYpZ1QuhZQJZSaf0KH8MHx1174eMVL3OtsobNCuealxdk4EKrf/u3uXYdouwpWZLUWuhxK/Grsl0lo1yvUhgtYJzOvwXh3eNZBOzmC0JVl/L6gMNhKuXYBaklWAb32rQ5s0= From: Bertrand Marquis To: Andrew Cooper CC: Julien Grall , Xen-devel , Marc Bonnici , Achin Gupta , Stefano Stabellini , Volodymyr Babchuk , Jens Wiklander Subject: Re: [XEN PATCH v8 02/22] xen/arm: tee: add a primitive FF-A mediator Thread-Topic: [XEN PATCH v8 02/22] xen/arm: tee: add a primitive FF-A mediator Thread-Index: AQHZbdfHy/Y46nL9n0ej3opYe7XQ5q8pKpqAgAAQ9oCAAUdZgIAftheA Date: Thu, 4 May 2023 13:14:33 +0000 Message-ID: References: <20230413071424.3273490-1-jens.wiklander@linaro.org> <20230413071424.3273490-3-jens.wiklander@linaro.org> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.500.231) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|DB9PR08MB7399:EE_|DBAEUR03FT032:EE_|AS8PR08MB7306:EE_ X-MS-Office365-Filtering-Correlation-Id: a55a6ad9-75f6-4337-4b4f-08db4ca18a11 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Y7qKgTZ3ZQo3ElQhCLg+WiDHM8nyVwtz+rMDzhWzycgrHxtcKhWuQnWf4WhyyFs2+3vCJFuU+gluORp9TtQolgYPI2kOisld8yR0p7zpa1mvI6WNaGrIB6ItlpqIkUCmgTgT32ay4rZAZoMY+wraomatC66ooCt0LTVXrketbnRJ5cACxeP2TKxQJ2QUZOSrRjo8Ty14U3kC0bEsr948kJdxMFyy1o+bjSAq5w1Ik2RFhvBeL89lQ5slGloIEV6Y4sow//H9ovoByzg/ietZZiNs5uLR3ZIOgaKTHHdHApk1SN1oroXkRhCI/PbNYrcBTAFCqYYFfy/s3/oz9/nn6OH9I90vxEIL472DmegiAcYckttDuuMfT9x2dM+KOlHIshblN+e/ZQA+ZwVENul3IuXRaLx6GL/YGykpTAjyp8Zlr5bpj9aQzA3CnCmVHjuQLGSCnthjN65IBP6F6zuBcb4Nh20c5QrZ4fmcePVDggUcJRVIz804Gq12h8muKMqlrvlQuwU7QTIKjfwft732j4YO09pC/4P1v/KMxKqZVgxGNDRuQcDzAqXvCr+PQ6FpLhpR0E1FGibHK74AbGnycoToMRIViJ2bXM7MIafak1hsHNfw6bwGn0trmiTV86os3alYj0PWWSsu3Ls3jEoDrA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(39860400002)(366004)(376002)(136003)(396003)(451199021)(6486002)(186003)(71200400001)(83380400001)(6916009)(26005)(6506007)(6512007)(53546011)(54906003)(36756003)(2616005)(33656002)(478600001)(64756008)(66476007)(66446008)(76116006)(91956017)(66556008)(66946007)(316002)(122000001)(8676002)(38100700002)(8936002)(5660300002)(41300700001)(66899021)(86362001)(38070700005)(2906002)(4326008)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7399 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c029c3c3-b624-4129-eaec-08db4ca180a5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p9KoFi0dSxhBLDaEUz8086XVhxlMaxiEamJ0oEd3BSkabKcWXRoa6Pru4vkwkIQmIPMnHciaTpUXtp551wWCsOYHSWuIjQywwPzWvQVOjV0BSocWl0oY+kPszBS2tBcEFuUkB39MvLWG2F8kBPWk/z0dOyLewHVw2EF+OYktbeYAO7AvedOnfiixjLLwJEM6JLfPhsz9KUANXldCRTKmdC0ers/CiuvNTTEa2OrLEAiDQvUHX0vDbyYzaA6v528tWLystDh9UX5mzTJ6iVEvzd3IYsH9X0JPGSY0rq9Izan6+ATIWDqpIidRimHAL+DeQQr99GXeC0/CvY9GTFpuRMMG+dmKK7G5qn04M8niJFJ+2m7HPsU/jOcqHIavdQv6ndknS4xBqhhhPfSZK1KtBz6ELUUIIjcr81D1KRDPAmc40Jl1sMO9mtql0IUMURjLQL/UXkwLP8R8cqu0QlXMz4qIPgLp6+DmHxRhwzQcTwuTUNI0kEDj6+TL2f85Yqaq0VgQoLVRSe0JMz+C8oipGtuZ/4dcC1GGdcMVpV8bRFSSKHOwPX1qTIJDrfSq3JyM7hJ7FtjXqK2xVklgio+aq1PoYLFJBF2XZ5hWhfKDn1EZ1TSMuey/jAYnwgNLPcEQ5b2RqLDZR4NkZHUrOedE1E+PRWnCeOEQo9TkRLYn0PYkuavjSF93KWFFTO4t/WMnJCzqQNjs1RP+ghcix4am4lj7RPfAnATO8dTdgpOKxOo= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(136003)(396003)(39860400002)(451199021)(40470700004)(46966006)(36840700001)(40460700003)(66899021)(70206006)(4326008)(478600001)(70586007)(6486002)(316002)(54906003)(33656002)(36756003)(86362001)(336012)(83380400001)(53546011)(107886003)(2616005)(6512007)(6506007)(36860700001)(26005)(47076005)(186003)(8676002)(41300700001)(6862004)(8936002)(2906002)(5660300002)(82310400005)(40480700001)(82740400003)(356005)(81166007)(34020700004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 13:14:49.2891 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a55a6ad9-75f6-4337-4b4f-08db4ca18a11 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7306 SGkgQW5kcmV3LA0KDQo+IE9uIDE0IEFwciAyMDIzLCBhdCAxMDo1OCwgSmVucyBXaWtsYW5kZXIg PGplbnMud2lrbGFuZGVyQGxpbmFyby5vcmc+IHdyb3RlOg0KPiANCj4gSGksDQo+IA0KPiBPbiBU aHUsIEFwciAxMywgMjAyMyBhdCAzOjI34oCvUE0gQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3Bl cjNAY2l0cml4LmNvbT4gd3JvdGU6DQo+PiANCj4+IE9uIDEzLzA0LzIwMjMgMToyNiBwbSwgSnVs aWVuIEdyYWxsIHdyb3RlOg0KPj4+PiArc3RhdGljIGludCBmZmFfZG9tYWluX2luaXQoc3RydWN0 IGRvbWFpbiAqZCkNCj4+Pj4gK3sNCj4+Pj4gKyAgICBzdHJ1Y3QgZmZhX2N0eCAqY3R4Ow0KPj4+ PiArDQo+Pj4+ICsgICAgaWYgKCAhZmZhX3ZlcnNpb24gKQ0KPj4+PiArICAgICAgICByZXR1cm4g LUVOT0RFVjsNCj4+Pj4gKw0KPj4+PiArICAgIGN0eCA9IHh6YWxsb2Moc3RydWN0IGZmYV9jdHgp Ow0KPj4+PiArICAgIGlmICggIWN0eCApDQo+Pj4+ICsgICAgICAgIHJldHVybiAtRU5PTUVNOw0K Pj4+PiArDQo+Pj4+ICsgICAgZC0+YXJjaC50ZWUgPSBjdHg7DQo+Pj4+ICsNCj4+Pj4gKyAgICBy ZXR1cm4gMDsNCj4+Pj4gK30NCj4+Pj4gKw0KPj4+PiArLyogVGhpcyBmdW5jdGlvbiBpcyBzdXBw b3NlZCB0byB1bmRvIHdoYXQgZmZhX2RvbWFpbl9pbml0KCkgaGFzIGRvbmUgKi8NCj4+PiANCj4+ PiBJIHRoaW5rIHRoZXJlIGlzIGEgcHJvYmxlbSBpbiB0aGUgVEVFIGZyYW1ld29yay4gVGhlIGNh bGxiYWNrDQo+Pj4gLnJlbGlucXVpc2hfcmVzb3VyY2VzKCkgd2lsbCBub3QgYmUgY2FsbGVkIGlm IGRvbWFpbl9jcmVhdGUoKSBmYWlsZWQuDQo+Pj4gU28gdGhpcyB3aWxsIHJlc3VsdCB0byBhIG1l bW9yeSBsZWFrLg0KPj4+IA0KPj4+IFdlIGFsc28gY2FuJ3QgY2FsbCAucmVsaW5xdWlzaF9yZXNv dXJjZXMoKSBvbiBlYXJseSBkb21haW4gY3JlYXRpb24NCj4+PiBmYWlsdXJlIGJlY2F1c2UgcmVs aW5xdWlzaGluZyByZXNvdXJjZXMgY2FuIHRha2UgdGltZSBhbmQgdGhlcmVmb3JlDQo+Pj4gbmVl ZHMgdG8gYmUgcHJlZW1wdGlibGUuDQo+Pj4gDQo+Pj4gU28gSSB0aGluayB3ZSBuZWVkIHRvIGlu dHJvZHVjZSBhIG5ldyBjYWxsYmFjayBkb21haW5fZnJlZSgpIHRoYXQgd2lsbA0KPj4+IGJlIGNh bGxlZCBhcmNoX2RvbWFpbl9kZXN0cm95KCkuIElzIHRoaXMgc29tZXRoaW5nIHlvdSBjYW4gbG9v ayBhdD8NCj4+IA0KPj4gDQo+PiBDbGVhbnVwIG9mIGFuIGVhcmx5IGRvbWFpbiBjcmVhdGlvbiBm YWlsdXJlLCBob3dldmVyIHlvdSBkbyBpdCwgaXMgYXQNCj4+IG1vc3QgInRoZSBzYW1lIGFtb3Vu dCBvZiB0aW1lIGFnYWluIi4gIEl0IGNhbm5vdCAoYWJzZW50IG9mIGRldmVsb3BtZW50DQo+PiBl cnJvcnMpIHRha2UgdGhlIHNhbWUgaW5kZWZpbml0ZSB0aW1lIHBlcmlvZHMgb2YgdGltZSB0aGF0 IGEgZnVsbA0KPj4gZG9tYWluX2Rlc3Ryb3koKSBjYW4uDQo+PiANCj4+IFRoZSBlcnJvciBwYXRo IGluIGRvbWFpbl9jcmVhdGUoKSBleHBsaWNpdGx5IGRvZXMgY2FsbCBkb21haW5fdGVhcmRvd24o KQ0KPj4gc28gd2UgY2FuIChldmVudHVhbGx5KSBwdXJnZSB0aGVzZSBkdXBsaWNhdGUgY2xlYW51 cCBwYXRocy4gIFRoZXJlIGFyZQ0KPj4gZmFyIHRvbyBtYW55IGVhc3kgZXJyb3JzIHRvIGJlIG1h ZGUgd2hpY2ggb2NjdXIgZnJvbSBoYXZpbmcgc3BsaXQNCj4+IGNsZWFudXAsIGFuZCB3ZSBoYXZl IGhhZCB0byBpc3N1ZSBYU0FzIGluIHRoZSBwYXN0IHRvIGFkZHJlc3Mgc29tZSBvZg0KPj4gdGhl bS4gIChIZW5jZSB0aGUgZWZmb3J0IHRvIHRyeSBhbmQgc3BlY2lmaWNhbGx5IGNoYW5nZSB0aGlu Z3MsIGFuZA0KPj4gcmVtb3ZlIHRoZSBhYmlsaXR5IHRvIGludHJvZHVjZSB0aGUgZXJyb3JzIGlu IHRoZSBmaXJzdCBwbGFjZS4pDQo+PiANCj4+IA0KPj4gUmlnaHQgbm93LCBpdCBpcyBzcGVjaWZp Y2FsbHkgYXdrd2FyZCB0byBkbyB0aGlzIG5pY2VseSBiZWNhdXNlDQo+PiBkb21haW5fdGVhcmRv d24oKSBkb2Vzbid0IGNhbGwgaW50byBhIHN1aXRhYmxlIGFyY2ggaG9vay4NCj4+IA0KPj4gSU1P IHRoZSBiZXN0IG9wdGlvbiBoZXJlIGlzIGV4dGVuZCBkb21haW5fdGVhcmRvd24oKSB3aXRoIGFu DQo+PiBhcmNoX2RvbWFpbl90ZWFyZG93bigpIHN0YXRlL2hvb2ssIGFuZCB3aXJlIGluIHRoZSBU RUUgY2xlYW51cCBwYXRoIGludG8NCj4+IHRoaXMgdG9vLg0KPj4gDQo+PiBBbnl0aGluZyBlbHNl IGlzIGV4cGxpY2l0bHkgYWRkaW5nIHRvIHRlY2huaWNhbCBkZWJ0IHRoYXQgSSAob3Igc29tZW9u ZQ0KPj4gZWxzZSkgaXMgZ29pbmcgdG8gaGF2ZSB0byByZXZlcnQgZnVydGhlciBkb3duIHRoZSBs aW5lLg0KPj4gDQo+PiBJZiB5b3Ugd2FudCwgSSBhbSBoYXBweSB0byBwcm90b3R5cGUgdGhlIGFy Y2hfZG9tYWluX3RlYXJkb3duKCkgYml0IG9mDQo+PiB0aGUgZml4LCBidXQgSSB3aWxsIGhhdmUg dG8gZGVmZXIgd2lyaW5nIGluIHRoZSBURUUgcGFydCB0byBzb21lb25lDQo+PiBjYXBhYmxlIG9m IHRlc3RpbmcgaXQuDQo+IA0KPiBZb3UncmUgbW9yZSB0aGFuIHdlbGNvbWUgdG8gcHJvdG90eXBl IHRoZSBmaXgsIEkgY2FuIHRlc3QgaXQgYW5kIGFkZA0KPiBpdCB0byB0aGUgbmV4dCB2ZXJzaW9u IG9mIHRoZSBwYXRjaCBzZXQgd2hlbiB3ZSdyZSBoYXBweSB3aXRoIHRoZQ0KPiByZXN1bHQuDQoN Cg0KQ291bGQgeW91IHRlbGwgdXMgaWYgeW91IGFyZSBzdGlsbCBoYXBweSB0byB3b3JrIG9uIHRo ZSBwcm90b3R5cGUgZm9yDQphcmNoX2RvbWFpbl90ZWFyZG93biBhbmQgd2hlbiB5b3Ugd291bGQg YmUgYWJsZSB0byBnaXZlIGEgZmlyc3QgcHJvdG90eXBlID8NCg0KUmVnYXJkcw0KQmVydHJhbmQN Cg0K From xen-devel-bounces@lists.xenproject.org Thu May 04 13:20:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 13:20:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529746.824469 (Exim 4.92) (envelope-from ) id 1puYsL-0006wf-5G; Thu, 04 May 2023 13:20:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529746.824469; Thu, 04 May 2023 13:20:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puYsL-0006wY-2T; Thu, 04 May 2023 13:20:01 +0000 Received: by outflank-mailman (input) for mailman id 529746; Thu, 04 May 2023 13:20:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puYsJ-0006wS-Qc for xen-devel@lists.xenproject.org; Thu, 04 May 2023 13:20:00 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5c9f4431-ea7e-11ed-8611-37d641c3527e; Thu, 04 May 2023 15:19:57 +0200 (CEST) Received: from mail-sn1nam02lp2044.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.44]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 May 2023 09:19:54 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB6567.namprd03.prod.outlook.com (2603:10b6:a03:388::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Thu, 4 May 2023 13:19:50 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb%4]) with mapi id 15.20.6340.031; Thu, 4 May 2023 13:19:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5c9f4431-ea7e-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683206397; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=9RTdJ5ycvxry+uYHLjAUjcrAJrpCvO6544pUQYTLnho=; b=hpeHy8iM8vFfadR26IN6N3UhmqCBsP1cV+ukEwQRkBPgJnMhz0mnb/fO 5UTJAk9Jw8Z9pN8FIMFf8npneqfpFvgP11wJJdPEfvYc3sSLuNinwBDn7 hFwAUP+xu6Jj+LZ4njKgJ+FxwBCtB9e3bDqjVeHwf3qK2N3+FIrJQE/mg 4=; X-IronPort-RemoteIP: 104.47.57.44 X-IronPort-MID: 110304341 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:1AGOHasJJBfMiMb7xEctD6ZqLufnVMFfMUV32f8akzHdYApBsoF/q tZmKTrSPq6MN2Gjed53Otvk/UMAu5GHx9E2S1c5rio0Qi8b+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj6Vv0gnRkPaoQ5AKGyyFMZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwLGEcMDu7xPuP3b+mcNs0mMAHBZa2M9ZK0p1g5Wmx4fcOZ7nmG/+P3vkBmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osj/6xbLI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6TeTgraY22wHKroAVIBQzbHG9i/WXsXKBAexxC 0EM5zEDl6dnoSRHSfG4BXVUukWsugMXUpxeGusx5QWJ14Ld+QPfDW8BJhZRZdpjuMIoSDgC0 l6Sg8ivFTFpqKeSS3+W6vGTtzzaESIYN3MYbCkICw4M+cD+oZobhwjKCN1kFcadkdD0Xzrwz jaipTI7wb4UiKYj1a+24FTGiDKEvYXSQ0g+4QC/dmC46gJ0Yqa1aoru7kLUhd5bN5qQRFSFu HkCmuCd4foIAJXLkzaCKM0SGJm56vDDNyfT6WODBLEk/jWpvmWlJIZZ5WkkIF8zappYPzj0f EXUpAVdoodJO2enZrN2ZIT3DNk2ya/nFpLuUfW8gsdyX6WdvTSvpElGDXN8FUi0+KTwucnT4 aumTPs= IronPort-HdrOrdr: A9a23:qegiyqmS5nY/5xCUUqVTIKaKi4jpDfOtimdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WBjB8bZYOCGghriEGgG1+ffKlLbakrDH4JmtJ uINpIOcOEYbmIKx/oSgjPIderIqePvmM/HuQ6d9QYVcegAUdAD0+4NMHf+LqQAfngiOXNWLv qhz/sCgwDlVWUcb8y9CHVAdfPEvcf3mJXvZgNDLwI76SGV5AnYpILSIly95FMzQjlPybAt/S zuiAri/JiutPm911v1y3LT1ZJLg9Hso+EzS/Bky/JlZAkEuDzYJLiJaIfy/wzdZ9vfqmrCpe O84ivI+f4Drk85MFvF5ScFkDOQrQrGo0WStWNwx0GT7PARDQhKdPZplMZXdADU5FEnu8w52K VX33iBv54SFh/Ymj/hjuK4IS2Cu3DE1UbKq9Rj+EB3QM8bcvtcvIYf9ERaHNMJGz/78pkuFK 1rANvH7PhbfFuGZzSB11MfiOCETzA2BFOLU0ICssua33xfm2141VIRwIgakm0b/JwwRpFY76 DPM7hulrtJUsgKBJgNTdspUI+yECjAUBjMOGWdLRDuE7wGIWvEr9rt7LA89IiRCek1JNdYou WzbLqZjx9BR6vDM7z/4HQQyGGyfIyUZ0Wd9v1j X-Talos-CUID: 9a23:zX/l9W/d3GWxeuE+LmOVv0pFC54OSj7E9WrdPnWKUXhtbJTKFFDFrQ== X-Talos-MUID: =?us-ascii?q?9a23=3AC/DKmQzkcXT1JFyZzi6k0C1OxK+aqK2LMWoLu5k?= =?us-ascii?q?ogPW7bxJeGzqFkS+aeIByfw=3D=3D?= X-IronPort-AV: E=Sophos;i="5.99,249,1677560400"; d="scan'208";a="110304341" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IGbnkgxIKmZIO18QB4usrN37TLLNi5R4ewd+L/XJ1KauANr92jd7ufze4bTO8z9vLOPvaVnYo1nyaZN1k0RALLu4kBhTSM3xPks1oNoa1BNmnLNczcsBANU3c13w9OSMrSXIKL1DZAWSTsLnOG4xTBY/D47MvVsr+fwOBPbXPyaBmuoVDKtlSHBVlYS3tYtGhBTnQ2NgC/pz0Zp8ByOKIXl1G+OAh638uzT6oYxVXboVSJZLvpzbR5wcw9zRR+2cNoxfPZB+8mOtgK4wAldEX2fT7LvYvYvTGnR3550zRKnLYWXL8Bn9PWl0qYSjKgnvOncEDFIHXuimhUZ+Hn+Z8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iDyUL6c239KtTq3SoHXH9sj+wF/BRaLca3LyaXl6eQ0=; b=kUpNUk+r8j9TP+e9Nlx2hZTXnQlEnCSXkcpBlZY0IQI4bwZu+QdUHIjaN7TrbwHcCJlejRJEERwjIgDbt0NK+iQWqVXXr/jrB6upoZJM4csl8dBChxnXmfcX0jK1r33Sw+Q6UKMiqLjhLHy9Tn8bDHjiX+Og3wJfDPGw4pX28q6shjIMnh050unNKBWt4W9MQcqLaK/zpjUNnfq5nHgo3K6s0PQO6eF3g4X606aNaZnExgIN9yudi6cm2eHOBycaToITthVSTlltRQkjPFFSW8NizbG32K3c1tWfQ2GBp2XhsGSIanfRGTDjCMxJ7L2GDKy8Be+IYC1qY/X58aRB2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iDyUL6c239KtTq3SoHXH9sj+wF/BRaLca3LyaXl6eQ0=; b=lN5bY1Bg8+SgVcT6duhAU8rETNXEJiC9pgq8qRx2Q2r7Z6cj4eZ1DDRcvUE/SCEeDilH8LfXgdUWYfcU7nR8zO4KVRq5i9Jo6ZTMLs1QGYaVSrOJ8eZbV9f03izjKW0KVaaMY74xjyoKFTaMlhkiESOFV+LclZtrre+4EmeLKjo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Thu, 4 May 2023 14:19:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: Andrew Cooper Subject: Re: [PATCH 2/3] xen/misra: xen-analysis.py: allow cppcheck version above 2.7 Content-Language: en-GB To: Luca Fancellu , xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu References: <20230504131245.2985400-1-luca.fancellu@arm.com> <20230504131245.2985400-3-luca.fancellu@arm.com> In-Reply-To: <20230504131245.2985400-3-luca.fancellu@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0215.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:33a::15) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB6567:EE_ X-MS-Office365-Filtering-Correlation-Id: 993d094f-69dc-4235-f82a-08db4ca23cb6 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sWyjGs6+IxeRdoK97ahpyEhNAFJ00bkb4UcdkwjzK64+61WqZfZE4EoaN+8pjTH/HRnkRzDm6DKiFC7xZ00C4nF+UyCbbeHhqrRClR+6uhmnpJAKg5R7dH7/e+MnO0WQ0+1Cgn9HnSIZNmBDDOCkIx6sOKC7udOmoAII6oLGQZCIpn/VTCk4PUsyupM4ltPidimz+0UbI+s3/btbLBoUWgmCfiRc6pp6NB0KZV2HuGpcMuBiLy0Qg8zWYFSgyFrPn7bXFYNUkNnvN3FfNZYC43STknOuUrcuQsu/MZ0fVFc4muUlktw+KBH1mWM224A2Enkj5a0CPXcweeFL1D5uisR1PcnsmfViFclfmjov/9l3xC5ZfTRPjcITb6cOQiQYsc4mDxIznC3NZU4gbnyXdQlr7Z89RG4899hJ+XwITLAOycOxzoRSsMSjUP6Phrhl07oBms4oqwd2cBsXp9bu3iesALDvthA//sqZugqZZngqJMsewsEzcjnJgUcLUQ2ZMqMK4H4Exv30ACsCETFJOG1e+L5C3ENNb/dnPQPCt9ebDLzSuBSWLV7jnMjxmSAG0rKVN7eUZFqsRxy4Fgk3+90lpjDU0TAr1a0o3YAhrx9s6xg5Hq3gOQvTt9kE6CnHfEvTzIoykoA14sEtAgxrIA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(366004)(346002)(396003)(136003)(376002)(451199021)(316002)(82960400001)(38100700002)(186003)(54906003)(8936002)(8676002)(6512007)(53546011)(6506007)(26005)(5660300002)(86362001)(6666004)(2616005)(31686004)(83380400001)(2906002)(31696002)(478600001)(66476007)(66556008)(41300700001)(4326008)(66946007)(6486002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NEhOTlIwendhTzJBbU44NngvQTVHQ1JmeTVFeWY1aWd2R29zUDl1djAvVllP?= =?utf-8?B?WUR2Ty9GY2pqT3FJNTNlVENLZTh6MThORzVZUmhDVzRaV01yNU1lcVk5QjFo?= =?utf-8?B?b3pSbXZDd2V5a3A2STMzcWNjMDkvRFk0SnVRTndPS0c0NG02djZ3OGRETUZs?= =?utf-8?B?K0lJSmdrTVcrenROUXl0N3BGQ0xsWTJVUm1mNFhrRzJYcFd6REh0cWJhU0M1?= =?utf-8?B?NWphbEVFVHZVTWwrbCtSRTZISUZsY2xKQU4wbHAwNkdTYVIvKzlmdjNZbTdU?= =?utf-8?B?a2l3TzBIWkFpbEJoSG5hWS9PRTd2bjVqSHBBcE1US000blpYVVM5RU5JdVps?= =?utf-8?B?NzVCak4vYVY5a29GVWQyZE9hU3g2N2tVTmpWS0lLajBneHAxWDhJRWZicXhs?= =?utf-8?B?NTBYQWRQNGRjeWRqaDlVSGNiNlh0V0xacmI4ekhER3pYU25SYmhoUFJXTU9X?= =?utf-8?B?eVNsam1MNXNSSE0xbndFcGMrVmdHNTNCT3h2Qml2TzErUFlBVndOQWdTRjN6?= =?utf-8?B?TUtjMU1Gd1BER2RWNmVzNElYSEx4bHBibjZBQXc3MkJUakxxQm9yMm03QXp3?= =?utf-8?B?NnVTaWZiWDhjM25IVVhOMnZMbFkvSVkzWFJaZWhsSmlmSW93aTJDSml1R0Qx?= =?utf-8?B?Ulk1dEo2dEtDbTZPb2dtN1I1eHpqd2RtYlIxK3JyQ296WlkvMzJhZEM0YTkw?= =?utf-8?B?N3FNZ09MTzVFSFZLbFFMeGJkR3ZNZWdMbkt0WHN6bHNwUkJ0MHFhVHdGdmR1?= =?utf-8?B?WHJGYTFHUGpMMVVkdG5pTTRRaTBFSEtrdjlOaGFRaG9zZEJYSFJkem1GdER1?= =?utf-8?B?MnV3M29YV2ZkZ0ZtSzdDZGREdWxPQklUTUhpSkttcGJ0a3VQVTdST2RPTWow?= =?utf-8?B?S2NzTEpuSkVpeFVPb3hNNWw0YkZSeGx5TWl4VkxjWDhjZFUzOEVGQ0VRa1hi?= =?utf-8?B?dE5jc09iVFlFTldsczE5RFEvT3VBbjlMN0cvSmpDUENDOEw1QUdkUkYyN3lo?= =?utf-8?B?TG9uU1BmOEJDK0xFTm85WUo4RWE2RE1ENElUQ0ZoSE9zKzYxNUU2LzI0UVc4?= =?utf-8?B?eXBPUTRSenZnZWFpM001YXVwQ0xBWlJvbkIyREtsbUc0bHdyOTFLR2Y3QURm?= =?utf-8?B?RmdXY0NvNGVKS0sydi82SkpXc0I4TDRtY2VHOXczenlyT0tTVlR1SjlTYk5l?= =?utf-8?B?YU9DT0JVYXgzN2x2TU1IWlJHMU5TUXJocFFwM01UaGd3alFVSU9TYWg2QlBR?= =?utf-8?B?dXN2Q0hXWHNCOTY4QlVNa0x5VGRWY2JBU1VqRVVnb2xZYytxdnFxQVFHS2JU?= =?utf-8?B?enUvVkRQNXJnMXNWZis3bEpoaDZ2NE9wMFhDQU03UkNYSGtiLzEvYW1jd2FM?= =?utf-8?B?WDVmdXJnU1dCSGU4OXEraGRmbFBCdEo1YjBKdmdwZ0dDa2NaMTJtU3FXVmxR?= =?utf-8?B?bWlwWlROYWorbW9vMkZScnE0dzJuckxzQyt2NVJWNmtpWndHNVEzTFQwWlc4?= =?utf-8?B?a1B0d2dQRmN3QnVGalBYTUNKRzRTcnEzU0RJOXZEdk0zc2QvR2lrQzBNcUk1?= =?utf-8?B?UnVGdTJ5YmU2TmZtQXhyamZCellac3ZXSlhSSXVCeFRvWkJqaXNqajJIakxk?= =?utf-8?B?cGhCQjFsOUpaZ0JpUDUySHVWcTNOQVpTYlE1MnAyOEtvV1RvN1lDczFidTdS?= =?utf-8?B?NG5ST2N6L2pTcGdGQnZZQThNckN4WVhIOVlVM2drTXF4VXhjbWRBd3dRWE9N?= =?utf-8?B?MXBIbEEvTFhQcGNtcnB4WUdyVXlDcUpnaDVsZ25RT2ltYzluc1FmYzU3b0JB?= =?utf-8?B?c1ZsRmZCLzhGTzhSQVpkTEhSV2ZqbW5NWWVIYXNCTThEaC9JeFpZVkJhU2xj?= =?utf-8?B?aE5QWkhnbEpGVno0VWF6enNtMXJYemZZSzhuZXhCZ1BwQ1cvRm5zcFlJNUF1?= =?utf-8?B?ZWdnZGdSNXlOM1QwTTArc201NHdPY2tOQ2NGT2JXeFR5RE5KK29yUlFzUDJJ?= =?utf-8?B?VGxYbTY5Y24yUVlNYVh1ZFM1WW9yQ1k3ZE5OVkExbmNTTzBzM2lIUGFTdkMr?= =?utf-8?B?c05GQ3djOS9BQmdocHo4Ylp2RDExekFLRlBIL05LWGYrbFV0QWdUUmFhUUZ6?= =?utf-8?B?QS9oOU40WU5SZWlWOEV6MTdWUGw4OVNramhGVXJZTGtBUnF4TVVEbEUxWE1D?= =?utf-8?B?OWc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ZWsz7fOQUiZNXlWS3EdbNnkGHKkgwK1+LE3N5dCrYFFZREr7O4Bwxbymf+Mb34Hi7kz5Xkxcrj32s8LL1iETJ5QBsRrbG/lylHINrdHjX/pRiX0n+w4Y64ctRJb26VRRYlCOcDPqsb8mLJzdKmQwTi9VhIYa785PYX8KIExvRMieol1Vfp0pNe350nWZYuC6SuNpvBIrjPWxjvjfB1HhUTXA3tNl6IzKWuevjQdM4XL4S+BE4ixNvoAHAiI8yMNSYcxD4oTBHvoWgA5aA/Oj1vpHOXp9O3Kt/pJa0q9T6xApbwDeA+C+HvtSaJ70OUGREEHbC++aeSqONji6msW8ySsxULGEq68svt1BhtLaScLB81RXV538LodlWCmY24uOzZNRJ/80Puh4xd5MlU9agLBZUHzMxCtMGb+midiKbz3CqHVJ+GWoIJJ/lwvu2L89/G0b0499K/QB+WBLRpOoIAoIIeaR8NxX9o7nNapyEhHNyajLlJ03qwpVnbPOt1hKv5I5bKwF5YFfZjYODdaEUUOk8i/ohfgXm+XD7gw5EjyJt6jzzjBIYOQ8vjqOW9jZJ81rZFYulsYIDjC/BpAxMClVdaJhaEIXOkN6TT5c1er6zlNR3h96zo1msQWlLZh7T3uTPnkwv+4Lx4FTBagI2sgHjYjsYtasK8pNOvVq7n7bILllTda+runPj/zl2YQ2Fk3UJZ9E2oLC8gPcTHY2InVvdw8Jt6ib+hTeJAbXCv7ij22p9aupdeZKjSlQWrvrMHnzafbsQlNN3vrMmAg2oksTmaMTNXOJiaRiNqLciJLtryypsbBAhJQtXuNT814BsyrT2BKD6zWc/vW99nPHkG92EI1J/tHQtccST5dJcCrG2RtBXdPbg965urWwN+EB X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 993d094f-69dc-4235-f82a-08db4ca23cb6 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 13:19:49.4077 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nCxYHKv4zLQCc7BYi1h6DB1c7FEK8kxa+1D2GegS/V7xq2+JGvFlZst/0QFKMjxrd7zhfsqAZNS8QZkW4kTVKco3qtCI6PtSpSNvpAR1u7U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6567 On 04/05/2023 2:12 pm, Luca Fancellu wrote: > Allow the use of Cppcheck version above 2.7, exception for 2.8 which > is known and documented do be broken. > > Signed-off-by: Luca Fancellu > --- > xen/scripts/xen_analysis/cppcheck_analysis.py | 20 +++++++++++++++---- > 1 file changed, 16 insertions(+), 4 deletions(-) > > diff --git a/xen/scripts/xen_analysis/cppcheck_analysis.py b/xen/scripts/xen_analysis/cppcheck_analysis.py > index 658795bb9f5b..c3783e8df343 100644 > --- a/xen/scripts/xen_analysis/cppcheck_analysis.py > +++ b/xen/scripts/xen_analysis/cppcheck_analysis.py > @@ -157,13 +157,25 @@ def generate_cppcheck_deps(): > "Error occured retrieving cppcheck version:\n{}\n\n{}" > ) > > - version_regex = re.search('^Cppcheck (.*)$', invoke_cppcheck, flags=re.M) > + version_regex = re.search('^Cppcheck (\d+).(\d+)(?:.\d+)?$', > + invoke_cppcheck, flags=re.M) > # Currently, only cppcheck version >= 2.7 is supported, but version 2.8 is > # known to be broken, please refer to docs/misra/cppcheck.txt > - if (not version_regex) or (not version_regex.group(1).startswith("2.7")): > + if (not version_regex) or len(version_regex.groups()) < 2: > raise CppcheckDepsPhaseError( > - "Can't find cppcheck version or version is not 2.7" > - ) > + "Can't find cppcheck version or version not identified: " > + "{}".format(invoke_cppcheck) > + ) > + major = int(version_regex.group(1)) > + minor = int(version_regex.group(2)) > + if major < 2 or (major == 2 and minor < 7): > + raise CppcheckDepsPhaseError( > + "Cppcheck version < 2.7 is not supported" > + ) > + if major == 2 and minor == 8: > + raise CppcheckDepsPhaseError( > + "Cppcheck version 2.8 is known to be broken, see the documentation" > + ) Python sorts tuples the helpful way around, so for example v = (2, 9) if v < (2, 7) or v == (2, 8):     # handle error does what you want, and far more concisely. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu May 04 13:21:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 13:21:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529749.824480 (Exim 4.92) (envelope-from ) id 1puYtN-0008IU-Ex; Thu, 04 May 2023 13:21:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529749.824480; Thu, 04 May 2023 13:21:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puYtN-0008IN-Bz; Thu, 04 May 2023 13:21:05 +0000 Received: by outflank-mailman (input) for mailman id 529749; Thu, 04 May 2023 13:21:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puYtM-0008IH-9n for xen-devel@lists.xenproject.org; Thu, 04 May 2023 13:21:04 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20630.outbound.protection.outlook.com [2a01:111:f400:fe12::630]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8402c845-ea7e-11ed-8611-37d641c3527e; Thu, 04 May 2023 15:21:02 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8109.eurprd04.prod.outlook.com (2603:10a6:102:1c2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Thu, 4 May 2023 13:21:01 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6363.022; Thu, 4 May 2023 13:21:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8402c845-ea7e-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gm0bs90qeOG0WODSswUzUOhzkZ38lpvH8xbJmewoJqCIMpl/5jqJmehxgFvp3fKoFmehYKbgWrPy87LIpHupktbPM97b3V8Sl7M8ABmQleo9iTSXElA62QOvLSXx5hhkyf0kJ+7d7Xx+EvQ7VdwpkUjWmgj6o4cnADHJgZGLGoGZbxa8akOpWD4tfxFZY1xDdKJZnI+YYJHEF3z4Aq0ThNq8s6RvgQH3kn4an1hcMCksU3Kz9Nib/V6zA5x2M4lCXbU+lkVXO5gp7DMpl7LoG2y1oDzweSDE1eTS3+0BF6gtKzZAHNZEt1Zzu+qSE7tY9LXxGFAXCGMYAfrDwKwqAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X4lJ5TCVn+ArYoM6a9T+pkoACxd5SnywVsjoTgae4rU=; b=VzK4l8udJDs7dHKzUKpNQH4zv97ZrLhcflGMO2Zu6SF2BfNt+u8lvpbWOCOzPGetk73SvimjgHFaOH8UBOL8eKOIaCyRH8MDSCmAsXTtJMiC/tkVR7UxLjp3czKhjD7AiK7tQbD9ulDey4qpP0buZsGle9niFtLh3pTNooob6bF/BzCCr7qFfp59jPwKnKF71mH9ZCYjA5/V09+pC9NPbYiyiNXo++vHehuCojknBKtikCu+f+6EAfbkgWo1TcN+4okLdH8s/TtPbPkRAGZMvSF0PR2RrJyLQ3nzxtkOPdg+gKJUb05IKOjdpRbtefeE/elWIuc+109JLyri+PwwzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X4lJ5TCVn+ArYoM6a9T+pkoACxd5SnywVsjoTgae4rU=; b=m9mn00OWurukgjPA2dNPa7Bhi0HyOC9AR9uYW3SuD4wSZc2UaW2I9vY2whvuCc0E3jo1G1fybn6sKESfNTLH769Q7IapI4iK9wsondvH8l5K+Ib6OGtexNstYP3HKA7ec17FO4YQOwTDexP5dwpABo4qP2/mLjP5JdnjKVGD7jYLq7QwDamknhbXKQuJ7OAsGp4+tY4hFwG8RQOdXBM5pyFOI+4akbBq/RM7CGId7eR3qd9CLhHMpbJdHXUovtlO/6TO7WvoxuC2vn3LUhOXsgXVY3q3Bg9miFjLZl9NndT7bO/zX1lm9HDAaDx81PvHOqHhmgmoVgVxxouq7rqVUA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <12008cc4-965e-9d7d-b655-95c867b3bcb2@suse.com> Date: Thu, 4 May 2023 15:20:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH] x86/bitops: Drop include of cpufeatureset Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230504130755.3181176-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230504130755.3181176-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0149.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8109:EE_ X-MS-Office365-Filtering-Correlation-Id: 8e515585-10e6-4872-76b7-08db4ca26778 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OqaQLPii4qhrQGCqjMhKumNAtW29Lx8nCNbTOK1jnYA/2wSfy8zla+BlHLoTgd/+9U6DPleF5ovlTCW1DUWC7+sjiO91P6TwtjgnEdI5vcU0A6OjyK05K43DBJvYwKMVnA1LUrFSOqhwSHLE5yr4iM3c2KaEmI5SL7LS0ZIlY3A8USDxnTBnY4/b95fKFFACU9D75uIcQau36DvOARRsgzFL/wKPxaRKh6pTNTM0ljjFkV7eV3RLB7SEfk3UivzPfv4fyOilQS/H5AUJDD8VCIb/kYhpBD6Ys5Mz39YrK2g5BsQtysoyT5DJ/twkh9xjI6ODA+VrN0wst/XWGU0nfWoLyVQR9yrPdydfkp0xrxk2pzqQzHGY3lAOXUOpeVSPTWYl0mg2Hu6IL+EucU11T5TjtP98sLYSZ9iPzrUOOpEQhlrA8lkpEmePV4B2ZfLqG2JByfkdSWZ15KDukZi5GxAikzSKNj61q89iJTHyQGAdahc0uvFe11HjTfBtAY4Xe311kNHoOy5jQSvP/oZo9wMvrfzCYJrPTqTWqtKTz/D+E/ku5mhp6HnJN72KfaElCpUhUTXulBBrjZPQmrGmehx11gCGGf2saJV4B5DloA8SFjFx4h90UiyiVMwix/JJkQa01uMx5smh+IbIFJcc5A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(376002)(396003)(366004)(39860400002)(346002)(451199021)(83380400001)(54906003)(2906002)(478600001)(316002)(5660300002)(8936002)(66556008)(8676002)(41300700001)(66476007)(66946007)(6916009)(4326008)(31696002)(38100700002)(86362001)(6486002)(36756003)(186003)(6506007)(53546011)(6512007)(26005)(31686004)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UDZxZ3NUcXR4TitsMFJteDFFZnJrNFlNUWk2WTgzUWFSblc2R1BtSUhURlNT?= =?utf-8?B?REQ5YXdObkg0TUZlRlMwMGhXaVJUQVdTKzBwSElSb0Y5bng0WFR6Z0VGNys2?= =?utf-8?B?NWwrcWVHeDdoQXErMnd2bEhNZVdxQ3JTOFcyNWtqeXVaaGFHU05CYVM3T3Jo?= =?utf-8?B?UUFxVDNqQzFKeTd6QytqLzhsWElkdTVNS2VPVDlzaWFqd1RUaTJScDNrVUF3?= =?utf-8?B?Y2ZBN2N6WmdTUDJBbXNXSWpUS3kyY0JrYjNIQ1NNb2dMYTdzMnJoSjZGRTcv?= =?utf-8?B?MWNNSDRjOWYvTVBTNlN0bXA1UGJjekYxVmlGNXpmYWFRMUY4R085a0lEV2xZ?= =?utf-8?B?Z1Jlc2FKbytqdkJMNXhrVW9ic0w2MFVjd0NxYXN4K0ZuMWw3OXdBTFJ3Rzd6?= =?utf-8?B?cm11L1g1VkFsVXBNT0dUbGJRMzF4YmdmRUtVZW1JdXlMQTk1UmFlRHJ4TUUv?= =?utf-8?B?cjNOUzdDakErMUxtNU9WaVIvTVZjcjFQOFVjcDcyTTJEK0JHQStIM09Fblh3?= =?utf-8?B?UEVOdmIrbVowelU5aUFzZXRoS0tyOUZIQ1c1ZWpHQ0xPMVlxd3JXc1VJK0Fy?= =?utf-8?B?ODJPd3V1UFBYd0ltM1FIYldtSHZuRnhWNEJYT3NtNnRZV1ZFUkw5TDU4SFdX?= =?utf-8?B?ZFNOZVRXTjdkU1ZtQjFXZkk1STNiVlhVcTA2eHp3Z2R4N1IyWmpLckZIc1pV?= =?utf-8?B?WnZQdmZhNTU3alhWTHZySmp0NXdrZWJFSTNDdjd4QytTbzU5Nm9iL2k0V3lx?= =?utf-8?B?U05zeWxjSWR1Ykd6MzFoKy82aXFVNDVpT2VQdTAveEFKVHZHZFNXandsWFBr?= =?utf-8?B?S3FYdEsrY2NFVEgxMEVwejR5WUhEQjM3dVZjMjVqOXVsdFJvaE1wUjM5VWZ6?= =?utf-8?B?ZUNhbU5xNExMTHV5NEN1Y1ErdkkvOEJzZVF2dkE3eFVZQ3JMa2JNbHI3YjdF?= =?utf-8?B?NjZuaURBeHdTZFROUFBsaHFRbU9XSjRwNU5LV01RMGNJTmdEYmRLcUVzS2Zn?= =?utf-8?B?SmY4VEJGdCs3WlIyZTlIQ1N1d1hSSHJqUlhLdzdqN2JpZndGSWtGVG9xU0VV?= =?utf-8?B?a0lOMmhuSWFVcDNpbFMwUzJwdVZhUE1ZZks5bnU3OUhzRGwvSndUaUlQcnk3?= =?utf-8?B?Qi9WaElzL1AxMUFNYks4QWlQU2o0Q1lFL1plM3BKS09HMmVFTDhHWDVzTEQ0?= =?utf-8?B?R2liQlBJSjA2SmhhTExEbGNIQjkvMEovQ2s5V1M3eEU3aUhwVHVpMEZEWmZN?= =?utf-8?B?b011akcvVU94bEsweHk2UFhGY1FNc2k0UkVrOUdVclpOZmJnSk5lTWxpT0hJ?= =?utf-8?B?WWxzV1htWGMyVGZQZHNMYWJJOUxhaDhnUVNQRzhIbkZhU2dSWkIxU0dmZE03?= =?utf-8?B?b0hNcDRqbEJhT1dieHp4MWhSV1NWUHg1ZFhoU3pUUUE5QzBnNTdueFZqNUNZ?= =?utf-8?B?SnZBd3haSnVONUxhNG1KN0xFTTlWZ2NFazg0Zm9JMnhQM3RldGVDTThqOGVu?= =?utf-8?B?QkdYaG1zTkkwc1JjQXY4WDg5KzFoSzFkemdIRzVwR3VZaWNDSC9BTlNaMmlU?= =?utf-8?B?dmJtaTlrRFF0ZlVoUWlmWDZQZzFSamVJcmQyK0QxVU9remZKenlZSS95T0Vs?= =?utf-8?B?bVpMVzg1WDd2Yyt2ZU53UFNGZlUvYVEvSDdNdDBWUHkzMWxETHFpaHFad3Fm?= =?utf-8?B?Wk0yMDZub3VURVM0ak01cEl1T0V4Q1lNWERqYW1lai9Bak5FQ2xlRDE2ZWVG?= =?utf-8?B?NCtCaS9iS0ZrdFQrZW4zTG82MWRwbEE3Rkg4aEdjWFlzWjVUNmZIakZPcEh4?= =?utf-8?B?MENXcmdFQTkyOVo0NGNxWCs1clp4M2lJVEROVDhQUHBpbXNOZnJ5aE9CNEFQ?= =?utf-8?B?VFgvVTBRanhOcnp0aXlqSkNiMWI1MjRCNEVsQVkyL1BndVd0QlAzL1FXelhB?= =?utf-8?B?d09qSWdqaUE5VEFYU0tSNGxyODV1UjU3UTF4ZXRGZzFNVmpxWWZKOERRaC9v?= =?utf-8?B?d1hmd1hYUFdpME81S3hpc3NRbGRoRmpaYUxId0JFQTJERm1pZG5TUGVPbzRm?= =?utf-8?B?dkl4SG5QVjlsWndBZnRrWi8vMEN6SkxQM1ZlaWgzMFpOWFRKTGo3d3BhL0Zw?= =?utf-8?Q?OPAfcA+Mo5K7uE9dm6ec9B3O9?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e515585-10e6-4872-76b7-08db4ca26778 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 13:21:00.8562 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: y/ojy2G6to1WF50O+/Gs97rRqpuLcTsQYKdbcVDsY0UhalF5xSdq7eoemK4t3lz9UdVPBPdYgqvZNW3m65Uuiw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8109 On 04.05.2023 15:07, Andrew Cooper wrote: > Nothing in x86/bitops uses anything from x86/cpufeatureset, and it is creating > problems when trying to untangle other aspects of feature handling. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Wei Liu > --- > xen/arch/x86/include/asm/bitops.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/xen/arch/x86/include/asm/bitops.h b/xen/arch/x86/include/asm/bitops.h > index 5a71afbc89d5..aa8bd65b4565 100644 > --- a/xen/arch/x86/include/asm/bitops.h > +++ b/xen/arch/x86/include/asm/bitops.h > @@ -6,7 +6,6 @@ > */ > > #include > -#include Prior to your 44325775f724 ("x86/cpuid: Untangle the include hierachy") it was asm/cpufeature.h that was included here, presumably for the use of X86_FEATURE_BMI1 in __scanbit(). I guess that wants to be asm/cpufeatures.h now instead? Jan From xen-devel-bounces@lists.xenproject.org Thu May 04 13:24:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 13:24:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529752.824489 (Exim 4.92) (envelope-from ) id 1puYw5-0000Tw-Re; Thu, 04 May 2023 13:23:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529752.824489; Thu, 04 May 2023 13:23:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puYw5-0000Tp-P4; Thu, 04 May 2023 13:23:53 +0000 Received: by outflank-mailman (input) for mailman id 529752; Thu, 04 May 2023 13:23:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puYw4-0000SC-DT for xen-devel@lists.xenproject.org; Thu, 04 May 2023 13:23:52 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e813e0cf-ea7e-11ed-b226-6b7b168915f2; Thu, 04 May 2023 15:23:51 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e813e0cf-ea7e-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683206631; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=/pvEq/xZicrqe/jwH85spYOYRNCODnIg5BSH4wsVGzc=; b=Q4/eDSd3c2ItnxLGYWt0z7h9BvTejdvIfBcyxEfZ51J6rTdatfSLCO59 CzgFv/NwOQlTb1P9cQp/kNslloGooJa2Lpzk9X77zN4YRlih2gOpBjnDj 8Nq0AqVaadBikmhPc+QiMIxe/vZlafHxbr2Lvh0nqpmMCAvZL4l1ayskz k=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 107748272 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:948xPaOPQ9hc62fvrR3al8FynXyQoLVcMsEvi/4bfWQNrUok3zVRy 2BLCmDSO6rcZWX3e4pwat7joUMD657czNdrHAto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvPrRC9H5qyo42tF5gBmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0vRQIH1+y dNBEgIMay6boOSu56K+UPY506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI ZNEN3w2Nk+ojx5nYz/7DLo3mvuogX/uNSVVsluPqYI84nTJzRw327/oWDbQUoXSGpoJzhzH/ Aoq+UzlXC4kZYOY7Aa9qE/zg8TqgAqkUYENQejQGvlC3wTImz175ActfUS/iem0jFakXNBSI FBS/TAhxYA77EGxR8PxdwG5qnWD+BUbXrJ4A+A8rQ2A1KfQywKYHXQfCC5MbsQ8s807TiBs0 UWG9+4FHhQ27ufTEyjEsO7J83XrY3N9wXI+iTEsXywk/+nfj9gJvBPKcM5EFraSntjvBmSlq 9yVlxTSl4n/nOZSifXgpQmd023zznTaZlVrv1uKBwpJ+is8Pdf4PNLwtDA3+N4adO6kok+9U G/ociR0xMQHFtmzmSOEW43h95n5tq/eYFUwbbOCdqTNFghBGFb5J+i8GBkkeC9U3j8sIFcFm nP7twJL/4N0N3C3d6JxaI/ZI510nfO5SYy8DqiLP4cmjn1NSeN61Hs2OR74M57FySDAbp3Ty b/EKJ3xXB72+IxszSasRvd17ILHMhsWnDuJLbiilkTP7FZrTCLNIVvzGAfUP79RAWLtiFm9z uuzwOPQl00FCLOkOXa/HEx6BQliEEXXzKve86R/HtNv6CI/cI39I5c9GY8cRrE= IronPort-HdrOrdr: A9a23:7N5aD6qMMpAyQkxcl8ZjXIoaV5rveYIsimQD101hICG9Evb0qy nOpoV/6faQslwssR4b9uxoVJPvfZq+z+8W3WByB9eftWDd0QPFEGgL1+DfKlbbak7DH4BmtJ uJc8JFeafN5VoRt7eG3OFveexQvOVu88qT9JjjJ28Gd3APV0n5hT0JcjpyFCdNNW57LKt8Lr WwzOxdqQGtfHwGB/7LfUXsD4D41rv2fIuNW29+OyIa X-Talos-CUID: 9a23:mLhtnGM8gkpiE+5DSg5G6H4oNZkfQHzY8m/3JVefGWNzV+jA X-Talos-MUID: =?us-ascii?q?9a23=3AfLdoPg1klOxh+1mii7qGBMvHrDUj//qRNhFSlrA?= =?us-ascii?q?6g5O5ailbHiq00z20Xdpy?= X-IronPort-AV: E=Sophos;i="5.99,249,1677560400"; d="scan'208";a="107748272" Date: Thu, 4 May 2023 14:23:45 +0100 From: Anthony PERARD To: George Dunlap CC: , Anthony Perard , Wei Liu Subject: Re: [PATCH 1/2] xenalyze: Handle start-of-day ->RUNNING transitions Message-ID: <96a6a07f-b61a-4c11-9dcb-0c0bf1942bf3@perard> References: <20230327161326.48851-1-george.dunlap@cloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230327161326.48851-1-george.dunlap@cloud.com> On Mon, Mar 27, 2023 at 05:13:25PM +0100, George Dunlap wrote: > A recent xentrace highlighted an unhandled corner case in the vcpu > "start-of-day" logic, if the trace starts after the last running -> > non-running transition, but before the first non-running -> running > transition. Because start-of-day wasn't handled, vcpu_next_update() > was expecting p->current to be NULL, and tripping out with the > following error message when it wasn't: > > vcpu_next_update: FATAL: p->current not NULL! (d32768dv$p, runstate RUNSTATE_INIT) > > where 32768 is the DEFAULT_DOMAIN, and $p is the pcpu number. > > Instead of calling vcpu_start() piecemeal throughout > sched_runstate_process(), call it at the top of the function if the > vcpu in question is still in RUNSTATE_INIT, so that we can handle all > the cases in one place. > > Sketch out at the top of the function all cases which we need to > handle, and what to do in those cases. Some transitions tell us where > v is running; some transitions tell us about what is (or is not) > running on p; some transitions tell us neither. > > If a transition tells us where v is now running, update its state; > otherwise leave it in INIT, in order to avoid having to deal with TSC > skew on start-up. > > If a transition tells us what is or is not running on p, update > p->current (either to v or NULL). Otherwise leave it alone. > > If neither, do nothing. > > Reifying those rules: > > - If we're continuing to run, set v to RUNNING, and use p->first_tsc > as the runstate time. > > - If we're starting to run, set v to RUNNING, and use ri->tsc as the > runstate time. > > - If v is being deschedled, leave v in the INIT state to avoid dealing > with TSC skew; but set p->current to NULL so that whatever is > scheduled next won't trigger the assert in vcpu_next_update(). > > - If a vcpu is waking up (switching from one non-runnable state to > another non-runnable state), leave v in INIT, and p in whatever > state it's in (which may be the default domain, or some other vcpu > which has already run). > > While here, fix the comment above vcpu_start; it's called when the > vcpu state is INIT, not when current is the default domain. > > Signed-off-by: George Dunlap Acked-by: Anthony PERARD -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu May 04 13:24:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 13:24:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529753.824500 (Exim 4.92) (envelope-from ) id 1puYwO-0000sM-7N; Thu, 04 May 2023 13:24:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529753.824500; Thu, 04 May 2023 13:24:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puYwO-0000sF-3D; Thu, 04 May 2023 13:24:12 +0000 Received: by outflank-mailman (input) for mailman id 529753; Thu, 04 May 2023 13:24:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puYwM-0000qi-Ju for xen-devel@lists.xenproject.org; Thu, 04 May 2023 13:24:10 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f20e8753-ea7e-11ed-8611-37d641c3527e; Thu, 04 May 2023 15:24:08 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f20e8753-ea7e-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683206648; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=rJ+UqEziv1wa7BwSqkCSSHwlAp/FpZLFP6MYajFVB/U=; b=AMlxQBXlGmCqAI2N1U+aukLbyufSWTVSqGYpfe3zbd0JJe9HwnItIUqZ qzhbSAwGXoH80vzKwjTrfngmWJzSStTduzxPQ9LgHOZh8x4o0mbr+RBuS S4mbCbfESrrtqWq4PCyGz8gvuLrpRsXdvFdE/VvuoCyvfV4HsHOUPQHfH M=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 110304925 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:AhfKpqK6077jzOtTFE+Rp5UlxSXFcZb7ZxGr2PjKsXjdYENS0WAHm 2UYXzuGbveCYDCgKNB/Oo+z9kpQvpOGy98xQAJlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPSwP9TlK6q4mhA4wRiPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5QW21zp aQdOAs9USCDvPCVkPGiSsVz05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpNU6bC/FMEg5/5JYWleG0hn75YntApUicv6Yf6GnP1g1hlrPqNbI5f/TTHJ0OxhrJ/ D+uE2LRIz1DbcC08CK+o3epj9eImA/GALA4G+jtnhJtqALKnTFCYPEMbnOyufSjg1Syc85eI UcTvCEpqMAa60iDXtT7GRqirxasrhMaHtZdDeA+wAWM0bbPpRaUAHAeSTxMY8Bgs9U5LQHGz XfQwYmvX2Y29uTIFzTErOz8QS6O1TY9CjUOWH9cSBs+0+bToLohrUKMV9ZPD/vg5jHqIg0c0 wxmvQBn2eVI1ZdRh/rklbzUq2ny/8aUF2bZ8i2SBzv4tV0hOeZJcqTysTDmAeB8wJF1p7Vrl FwNgICg4e8HFvlhfwTdEbxWTNlFCxtoWQAwYGKD/LF7rVxBA1b5IehtDMhWfS+FyPosdz7ze 1P0sghM/pJVN3bCRfYpM9noV5xzlfC/RImNuhXoUzazSsIpKF/vEN9GPCZ8IFwBYGBzyPpia P93gO6nDGoACLQP8Qdas9w1iOdxrghnnDO7eHwO50j/uVZoTCLPGOht3ZrnRrxR0Z5oVy2Pr 44Fb5XQkEo3vS+XSnC/zLP/5GsidRATba0aYeQNHgJfCmKKwF0cNsI= IronPort-HdrOrdr: A9a23:bwKk9qNLCF2gIcBcTu+jsMiBIKoaSvp037BL7S9MoHluGfBw+P re+8jzuSWUtN9pYgBEpTniAse9qA3nhPpICNIqTNSftWDd0QPDQe1fBO3Zslvd8kbFltK1u5 0QCJSWIeeAb2RSvILX5xS5DsZl4PTvytHTuQ4G9QYVcei9UdAZ0ztE X-Talos-CUID: =?us-ascii?q?9a23=3A4lplDmjVifv3C8rTFuI+T2+qFjJuVSfR8SeIJl+?= =?us-ascii?q?DOVlZSIaHag/T4aNIjJ87?= X-Talos-MUID: 9a23:9INY5Qmj0qYYlB0P91OUdnpDGJ4x/4+XEHtclJAPg46BGREoCR2S2WE= X-IronPort-AV: E=Sophos;i="5.99,249,1677560400"; d="scan'208";a="110304925" Date: Thu, 4 May 2023 14:23:59 +0100 From: Anthony PERARD To: George Dunlap CC: , Wei Liu , Anthony PERARD Subject: Re: [PATCH 2/2] xenalyze: Basic TRC_HVM_EMUL handling Message-ID: References: <20230327161326.48851-1-george.dunlap@cloud.com> <20230327161326.48851-2-george.dunlap@cloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230327161326.48851-2-george.dunlap@cloud.com> On Mon, Mar 27, 2023 at 05:13:26PM +0100, George Dunlap wrote: > For now, mainly just do volume analysis and get rid of the warnings. > > Signed-off-by: George Dunlap Acked-by: Anthony PERARD -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu May 04 13:25:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 13:25:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529760.824509 (Exim 4.92) (envelope-from ) id 1puYxg-0001dl-HF; Thu, 04 May 2023 13:25:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529760.824509; Thu, 04 May 2023 13:25:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puYxg-0001de-Ea; Thu, 04 May 2023 13:25:32 +0000 Received: by outflank-mailman (input) for mailman id 529760; Thu, 04 May 2023 13:25:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puYxf-0001dU-3A; Thu, 04 May 2023 13:25:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puYxe-0006d4-Pq; Thu, 04 May 2023 13:25:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puYxe-000740-8R; Thu, 04 May 2023 13:25:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1puYxe-0007Z5-7w; Thu, 04 May 2023 13:25:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=PP6A64J4n0z3h6d7D66HKiUOdO/9/ZCP2ucff9ylkYA=; b=OKNJCbBbQ4zo3IYjnfNRHXA0yU 0IvoVGoS1raQDNXM4Kvvgu33+hMbzYYux4JOIukmsnlfaMNt1jaBM6Xbj/3raSUD6PsvuhfaqFtE6 ckv72ahG72o6CiM08p9sHayLLWYekm3hcLPY8UNL0LhcMItPG4KGZzb4Ke9vnvjAbr/Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 180522: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:heisenbug qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=044f8cf70a2fdf3b9e4c4d849c66e7855d2c446a X-Osstest-Versions-That: qemuu=c586691e676214eb7edf6a468e84e7ce3b314d43 From: osstest service owner Date: Thu, 04 May 2023 13:25:30 +0000 flight 180522 qemu-mainline real [real] flight 180529 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180522/ http://logs.test-lab.xenproject.org/osstest/logs/180529/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-pair 10 xen-install/src_host fail pass in 180529-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 180514 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180514 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail like 180514 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180514 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 180514 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 180514 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180514 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180514 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180514 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass version targeted for testing: qemuu 044f8cf70a2fdf3b9e4c4d849c66e7855d2c446a baseline version: qemuu c586691e676214eb7edf6a468e84e7ce3b314d43 Last test of basis 180514 2023-05-03 05:31:08 Z 1 days Testing same since 180522 2023-05-03 23:41:02 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alistair Francis Daniel Henrique Barboza Dickon Hood Juan Quintela Junqiang Wang Kiran Ostrolenk Nazar Kazakov Richard Henderson Weiwei Li jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git c586691e67..044f8cf70a 044f8cf70a2fdf3b9e4c4d849c66e7855d2c446a -> upstream-tested From xen-devel-bounces@lists.xenproject.org Thu May 04 13:28:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 13:28:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529765.824520 (Exim 4.92) (envelope-from ) id 1puZ0g-0002GA-WC; Thu, 04 May 2023 13:28:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529765.824520; Thu, 04 May 2023 13:28:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puZ0g-0002G3-TK; Thu, 04 May 2023 13:28:38 +0000 Received: by outflank-mailman (input) for mailman id 529765; Thu, 04 May 2023 13:28:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puZ0f-0002Fx-P5 for xen-devel@lists.xenproject.org; Thu, 04 May 2023 13:28:37 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 91d4ec42-ea7f-11ed-b226-6b7b168915f2; Thu, 04 May 2023 15:28:36 +0200 (CEST) Received: from mail-mw2nam12lp2042.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.42]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 May 2023 09:28:33 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BY1PR03MB7192.namprd03.prod.outlook.com (2603:10b6:a03:534::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Thu, 4 May 2023 13:28:28 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb%4]) with mapi id 15.20.6340.031; Thu, 4 May 2023 13:28:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 91d4ec42-ea7f-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683206916; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=tMhNF3tjmiLpEHIrd9aTonEoqOY14bSGzTOIv+x/trw=; b=KKHGK9vE0ZidBzIy4D/rsz5vvdFuXVHEc0ZRHjGO75YA5u4/SYL6xtaB 5pp2xqpG2VyH6uROz/oDT5E47632+knJmJB65HzyaCSvx7oKkjAuLCtSw GEHxQ8xTBtLsqCkKprqy8RWxt+Ut3RFcXXnpJ6oNjmzM48+CaYV0craQi k=; X-IronPort-RemoteIP: 104.47.66.42 X-IronPort-MID: 107883195 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:IzEegaPgnlvW/h7vrR2HlsFynXyQoLVcMsEvi/4bfWQNrUp3gTYOx jQbDW+AP/nbZGr9f9hyYY7i9EIPvpHRnd9jTQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvPrRC9H5qyo42tF5gBmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0rx4HjhFz fBfE2wUYxym186IxLaLTfY506zPLOGzVG8ekldJ6GiDSNMZG9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+/RxvzK7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prraXwnOrA9tDSdVU8NZnrGOTyUsXByc2UF6gsdiot0emBdJmf hl8Fi0G6PJaGFaQZtv3UgC8oXWElgUBQNcWGOo/gCmSzoLE7gDfAXILJhZRZdpjuMIoSDgC0 l6Sg8ivFTFpqKeSS3+W6vGTtzzaBMQOBWoLZCtBSBRf5dDm+ds3lkiXEowlF7OphNroHz222 yqNsCU1m7QUi4gMyrm/+lfExTmro/AlUzII2+keZUr9hisRWWJvT9bABYTzhRqYELukcw== IronPort-HdrOrdr: A9a23:qf7UOqnkZ6gdZOO83J9igm+Jz2XpDfMxiWdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0msjKKdkrNhWotKOzOWxVdATbsSl7cKpgeNJ8SQzJ8/6U 4NSdkaNDS0NykAsS+Y2njHLz9D+rm6GcmT7I+xrkuFDzsaE52Ihz0JdTpzeXcGIDWua6BJcq Z0qvA3xQZJLh8sH7iG7zQ+LqD+T5qhruOVXTc2QzocrCWehzKh77D3VzCewxclSjtKhZsy7G TflAT9x6O799W20AXV2WP/54lf3IKJ8KoOOOW8zuwubhn8gAehY4psH5WEoTAOuemqrHo6jd XWpB8kHsJrr1fcZHu8rxfB0xTplBwu93jh41mFhmaLm721eBsKT+56wa5JeBrQ7EQt+Pl6za Jwxmqc875aFwnJkijR78XBE0gCrDv/nVMS1cooy1BPW4oXb7Fc6aQZ4UNuCZ8FWAb38pouHu VCBNzVoNxWbVSZRXbEuXQH+q3mYl0DWjO9BmQSsM2c1DZb2Fh/0ksj3cQa2kwN8ZosIqM0kN jsA+BNrvVjX8UWZaVyCKMqWs2sEFHARhrKLSa7PUnnPLtvAQOMl7fHpJEOoM26cp0By5U/3L 7bVklDiGI0c0XyTeWTwZxw9AzXSmnVZ0Wt9ihn3ek6hlTAfsuvDcXaI2pe1/dI4s9vTPEzYs zDe66/WJTYXCzT8YUg5XyLZ3AdEwhZbCQvgKdJZ7u/mLO7FmTUjJ2qTB/yHsuaLd92YBK3Pl IzGB7OGe5n0meHHlfFvTm5YQKZRqW4x+M+LJTn X-Talos-CUID: 9a23:Ezu5Rm6tIC/7wRuSxdssrkELQ8sdfjrmkG7dL2roJVhtTI2SVgrF X-Talos-MUID: =?us-ascii?q?9a23=3AjkwdDQ7eUoJwhORvXUSA3cnXxoxlz5quB2cJnq8?= =?us-ascii?q?mvsyfJQ1hBj6F0jSOF9o=3D?= X-IronPort-AV: E=Sophos;i="5.99,249,1677560400"; d="scan'208";a="107883195" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d4d5dFsC43DHD09xJGtFYg87Mx/e+ZnBeEiEzaBU8ljIxpRQOzYMt90lFtDhyIHyAewL7Z2GWMTBSvrbiLn30FHsVE6EEwPyEH+tbbxIwWFkzgGv4b/e2DWi9dW/B709Ry0Q5T0eYgZjdElssundow07gXu3DKS/bgvWO7bS/0Rz4rVm/YqzL0N0s9oU9YJ0sk9ZR+MmlYxNrQ6z4tiRX2/T7DMA9wIq0eSrAUl0ilDUiVyaDrdvVBmzWyrcHcnl7mbhctX1qZMAOxcCM2lJWBCABOz43NxNBsGn4iSaZhdO61OBurDGlhu0U+hEIC5AAzX84LggDFJ5ILXgEQRClQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kMmuhkZuM146KCfqk1A9ON90F2AnP2kioSb1kYH7Asw=; b=Gkq+N1ixduwaTugOu8n3yxlKIdcSKvbgEAAaY/Lg3akN5ub7vlxRKhfcMs1vUVwbaMvk3EYjqvW2q/AqCwVmU31Kp9FBznXOj5fkjmlAuwvYfvsOy89SP2WauVYT+p0sGK4f8Q6ELq6U1C2b5o1WF8pI/MKAFerw4F6ha4nBK/Ef5jvk/ZYqGB8ACmX5wDo4AvkDNyqXEWJ/0VUvKJqHOzSTv1XZ2dw3eHklvd9AtI9V+OmlRMiO0JeBJKH5yv2qSv3FXMVhWdoOm5weLbhTRKevRyiwJ0JmmfS/NbfQaJJUJCCYz2IyI8T8/+/NUHHRIYeZ4sfsjoe3eZ2G04xKwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kMmuhkZuM146KCfqk1A9ON90F2AnP2kioSb1kYH7Asw=; b=IavGi9YWq5B3o6x6FVqBwq+KhAGhUFCgH30X+pKmE2qDmM2XL5bHzS9jrlxHuCfg0QjXzal12UjXN8UwFfICnJOu3LBv1L7j+JJr5UmX5x+CLB/OmkM+1QUh6raS4c7MOUOSJw55ZZae2JPeYsoXCyPoyZ+KvixldenO6/O/q6U= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <3b82513c-f726-61e3-d3c6-9ad41c5db6ac@citrix.com> Date: Thu, 4 May 2023 14:28:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: Andrew Cooper Subject: Re: [PATCH] x86/bitops: Drop include of cpufeatureset Content-Language: en-GB To: Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230504130755.3181176-1-andrew.cooper3@citrix.com> <12008cc4-965e-9d7d-b655-95c867b3bcb2@suse.com> In-Reply-To: <12008cc4-965e-9d7d-b655-95c867b3bcb2@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LNXP265CA0049.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5d::13) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BY1PR03MB7192:EE_ X-MS-Office365-Filtering-Correlation-Id: b6c81d71-2078-43bb-a51d-08db4ca37256 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kLxRdM1qBTUcJ8Wc2FffNyCHcNJFYEl1td7RzE4ZVtYZQiCVMp9A7xcS8vuNB6mIHVX3k/kSp8+l/a7BgEp2xtZY6n5APRT4EMrROzyvty45wkzoTwqN4gF98N2ntLv+T05hRT9WSSKcwwzrBP9aiul5oAJ8GlTnnySx01tnP8oO0EjDHUbwReuKLKONA2gQofKqGcO+gqMtzTtQbfO4xgDrd7X2PbyvVGy4FSiFZvSd2rhj2TF3GfZHekTq7WzOUDzSBmXoIlx1NrLw6RQFH88qfCeagb/YMXCI/t6yURI0mMTHOEEK1rgmX+0OpafyDoY+/5KeAaI3mesh6MSCXAm2TkxuqIZb+3U7Q8AZVzNqVBqB2Pl/to3/LdeROEXq6k8EFzLCL1Lkp2tfF47EKUq4z9mVW53xwHQ3sbCIcv7sJI+0UBDFO59+8J4s7zK/i7LK1hCKfHm5L9woPSu29KpXajGdOI+Kc9Bu+22ho01pma3mnmvu8fOQN54jIbD535BvL85mXTnKX9e+2BfvfZL738Sg5F0ivxzndRQrZMYC3YJsJthSCHV4D38bp6r9JBbXqspWxQ44OF/I91XRuzOKwgtdOW59cdyy0R+/6xahif+/iEjgVI0+X6oew+/TS1UuErRWSTxXq1Xa2PvexQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(366004)(376002)(396003)(136003)(451199021)(6512007)(6506007)(26005)(82960400001)(186003)(53546011)(83380400001)(38100700002)(41300700001)(8936002)(5660300002)(36756003)(31696002)(2616005)(6666004)(478600001)(2906002)(54906003)(316002)(6486002)(8676002)(4326008)(86362001)(66556008)(66476007)(6916009)(66946007)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WG5IMnc3RCtCS3JBbnppYk81NVBxN3pwRHU0T0JiSktpeDJWbzFudldXS3J5?= =?utf-8?B?QnFEQXBZZlJNbHIvOGFOSFVUME1PajBaWDhNdUtlbTJjZXl1dzN5ckI4cUV5?= =?utf-8?B?MklnS0FmNzBnYTBXdmpLNWJxUUVCYyt2eHZBZEN6L2pDckVkOGVOVStHKzBP?= =?utf-8?B?ZmQ5V1J2eFdkOUVKL050NDRVVWJVcXNtTGlxR2JIV3c3eVdiVzJMUnVVZm9w?= =?utf-8?B?bzM0bVYwcDgrOXJXN2hYN3BIQkRHaFVKYm15Qm1MYXk1MEFYNlR5cEpuazBF?= =?utf-8?B?TXRxa3RHN1NmOUN5WEN0Q1JVend4dDZFUEs0UlN0aDFTQy9qYytrSGdWaVB4?= =?utf-8?B?ei85azF6RzR2V2ZqQ3JtUWh4UXhDVjVwNW9SY0hSTkpPQnNrQjZQa1FoSWRa?= =?utf-8?B?SUQ5MlEwdUlPaXRSWFVLeC83K3pNTUhQYzVoTzJGWkpQUkJENHJmUmlKRkg1?= =?utf-8?B?bDdMeHY0d3RLWXJwNTZlQVRHNVpXSE9CVFhmOGJZRWVZZzhHbTRMQys0ZkFB?= =?utf-8?B?Y1dub0oreXZHaERLbVkvcDhUbEhTZk1ZZnU3MlFlTlk1bzNuWitYb1hQN0JE?= =?utf-8?B?NTZIYjNPdWZFUTM3ditmem0waHVhR1hKbjVjSm5wSFdMc1BWWEdENVNoajgy?= =?utf-8?B?TitFcFJOUXlBQTlDOGFSTWl5Z0sybElGYmpFVy9lUnJhV0hsSzgwUnMycHNr?= =?utf-8?B?b2dWek1SMFRWeEptSDNnbFlSZlNUQ0NrdkU0L3BYdTI1WE5MdWwzOEs1UTZJ?= =?utf-8?B?Z3MwaDUwZ1ZYRDRvNVVmaWpxbjZNellpU2U3akZOaHVMNFA0OWZNRWxiYitp?= =?utf-8?B?U2FpT3RyYmNzM0tvbzlzM1c4MEE5cTZFbFkvdDEyYVJMdHQxR1NVR3MzZm82?= =?utf-8?B?RzRQd1BPYnZPajJHMTU1c042N1lTaE5ITU8zb212VURXUlh1L1B1R0ppT1A4?= =?utf-8?B?RUFUZlg1RDliWkx0WkxyVHJkRlRyOHpyY2o0NjUyUmhxQzlPZmJocHVoSGFI?= =?utf-8?B?aHZ0THdKWmZ4ckt2MHZOV0psMThpLzdCQUxyeXZOL2NCeGVBaWZzSHVZZW96?= =?utf-8?B?L0xQVkVNTElwV1JWZVp6UXNveDdmMzEvQ1dyQlJZYmNSdFNYK2RFaUhnRFl6?= =?utf-8?B?Y0RvTUFhNXFzT2JubTFHd3VScmZWRHRBYjU2Z0NTUm9DdjN5VlR5RUF1dERn?= =?utf-8?B?Z1RZWnk0UVEzV1hmS0NyL0JySWRGKzRDVWJiTmJJRmxGdldVdUc3NDNSSitL?= =?utf-8?B?aDBEQ0VVaDAvcjg3NGJGM2Vjald3cElHeFllRWpqcllZOGhqc2IrQy9pczNx?= =?utf-8?B?U0NEMGxYTGJmZWJvR1lDNGQ3czlLZkNkV0lwOE92NTZCZmNkZlZtenRzVnk4?= =?utf-8?B?QVExQWRjMHVJVjloMXNxSlJqRStWY01oUlpKSTUyNStpc05Ic09XV2Jkd2lW?= =?utf-8?B?MlNIVzA0Z2pNOVNkU2V2ODZKTSs1ejN0SVZiOFNMRjZFSWM2RnVxSTdWbzk4?= =?utf-8?B?SElrY1lSNGZaYjZMNUZDMDZZWUxWL2xUUFJjbW95aXZhZ003ZjhCRlE0MHM1?= =?utf-8?B?V3BsNlpXaVMrNHowNHE1SHZET3Y0K2ZILzVQYUh3RVhyMkR5anNNdkd4UDJl?= =?utf-8?B?Mis1b0FOTllaMUlnaVgzSEpBZDB1Ylg0VlNxRURGMkhYdGp2OXRqRDN3SUR2?= =?utf-8?B?VGRzNTBIQU1Ib2Iza1piRkxxTmNpRGdaTEFpNG8vU3FkWnEra0cvQmllYW5H?= =?utf-8?B?Z0I1RTRTZU5qc3c4OTZYZmtxYnFodmUxZmdwSlBYZDBCOS9FS1d1bkZTUVQx?= =?utf-8?B?Qk1qcG1uVUw0bVJBbEtuU1BSbm55c2VQYjhZbnNYbUN6NVVZNVdUVWVxdXJq?= =?utf-8?B?L3ZROHpnczRRb3hmaFd0VUZIbXV0YWVUckJiSGtxNUFrbjdCVHRUNGRWWXla?= =?utf-8?B?WVZrRGtQSEdDZ2t2OC9uQUgzTkQ1Y0swaURhZkRhMndQeFRudUdxdWdPVUFo?= =?utf-8?B?a2o2NGxaVGUwejBqSG0wV0JKVDJIVmt0SnpNTzkraEdZeWNpbnJYK0J4VkVl?= =?utf-8?B?dmVYb3FyZHlyZktSdDZjenhleXdhZExNUllkL2Z2eU9sSGZOLzJnVVkrM0Zh?= =?utf-8?B?eWFoV3VPVm4wMWMvdDdwZGtrQm80T1VwWlZBQ2Q2L2dFTGVwaW5KNGRnWlR2?= =?utf-8?B?Znc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: dpwA8+zQ+JJcEqz1RmGsPXloTpCrfet5vjdVqNb59t4BzLTDIPRfAzZDuZt1I0rhz7dBpKl94Io+AaOep1PAdJp10vkJmxYK8oSpUd/NgoTK6yYObaq2P3zf9TuXZpO2B7AuxDgwfo7UpkIarWQ+JixXdGhvdDNdgfBSpNacEju6bkzN+HQRf7HWJI4z/NkR7SnsKZdx7cHV7z2N7TA/rbOZ1zX3PWJKPS6ZhtRyH6jwM2RJyTerQrfEh4e9MznWtAdiNSmhMTllqyeicCDDMPibrKztPUcV6oMXaVCGrqGlv8/uEJTuAh6Na3yCzn9QM0T6sgszNGBII+Rk5nrG097w/23DmpgqNFIisCdlIJ12EDSuFNlmf29U+PxR/9gEwdiFm4OBhnaVz6A/UWtUGtWTWN5C/vdIX7eKc9na2M7UFmUU3etJV7TbwRtdKsg4BHMswS/FGSB1cizA0WrD5MNi+2eSg56F85bWaov0/j0EcD0+r6MlIxy3zqw+t5cN6WVVTUtZ5VG3YekLvIYTpq1ufhmNKvjm1Lmk7ronO2EJOqmKr4Mr/R4ylT6uCQnojNY6Dj7C+tj5gycT4Byp5eJ3NcFqSusTNNR9/gNTEBycMFd0VAK7EkWUblvaWzkK/ivj2IOwMHaiHeBhqiFk6s5+fPeS+VrTTOeCUs+4b4m/dOC+1oycOuHHEdo8tiBSevgKL0n4cKNYirsKIuBpM4OG1+NNLkntl4dxnKCJqMZ93tJK5ZiIah6oitg1eFhbA6XkIRIybyrWMLjnad3R1C2K4Emp1XchZ0rO7S99D0/nRhUi2b6uye6hM9GGTMnX X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: b6c81d71-2078-43bb-a51d-08db4ca37256 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 13:28:28.7754 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J+TsBeQnU1ohS5BtHtKjZAZ62Lf2gQW+PrvRJR45TEIWzMdSWnHcVBR4y+Ca2fo0ZEFKWfrQLRiZfRhGe+r+DHfl3clLcPHG+Zu6jI7i8+w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB7192 On 04/05/2023 2:20 pm, Jan Beulich wrote: > On 04.05.2023 15:07, Andrew Cooper wrote: >> Nothing in x86/bitops uses anything from x86/cpufeatureset, and it is creating >> problems when trying to untangle other aspects of feature handling. >> >> Signed-off-by: Andrew Cooper >> --- >> CC: Jan Beulich >> CC: Roger Pau Monné >> CC: Wei Liu >> --- >> xen/arch/x86/include/asm/bitops.h | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/xen/arch/x86/include/asm/bitops.h b/xen/arch/x86/include/asm/bitops.h >> index 5a71afbc89d5..aa8bd65b4565 100644 >> --- a/xen/arch/x86/include/asm/bitops.h >> +++ b/xen/arch/x86/include/asm/bitops.h >> @@ -6,7 +6,6 @@ >> */ >> >> #include >> -#include > Prior to your 44325775f724 ("x86/cpuid: Untangle the > include hierachy") it was asm/cpufeature.h that was included here, > presumably for the use of X86_FEATURE_BMI1 in __scanbit(). I guess that > wants to be asm/cpufeatures.h now instead? Oh.  I missed that, but nothing fails to compile, which means that there's a prior path including cpufeatureset anyway. I think I'll drop this and leave the header rearranging to a later point.  I ended up having to do the untangling differently anyway. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu May 04 13:29:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 13:29:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529770.824530 (Exim 4.92) (envelope-from ) id 1puZ1j-0002vu-FS; Thu, 04 May 2023 13:29:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529770.824530; Thu, 04 May 2023 13:29:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puZ1j-0002vn-CF; Thu, 04 May 2023 13:29:43 +0000 Received: by outflank-mailman (input) for mailman id 529770; Thu, 04 May 2023 13:29:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puZ1i-0002vd-3o for xen-devel@lists.xenproject.org; Thu, 04 May 2023 13:29:42 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on20608.outbound.protection.outlook.com [2a01:111:f400:fe16::608]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b87d0ade-ea7f-11ed-8611-37d641c3527e; Thu, 04 May 2023 15:29:39 +0200 (CEST) Received: from DU2PR04CA0224.eurprd04.prod.outlook.com (2603:10a6:10:2b1::19) by AS2PR08MB8879.eurprd08.prod.outlook.com (2603:10a6:20b:5f6::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Thu, 4 May 2023 13:29:27 +0000 Received: from DBAEUR03FT027.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b1:cafe::c9) by DU2PR04CA0224.outlook.office365.com (2603:10a6:10:2b1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.25 via Frontend Transport; Thu, 4 May 2023 13:29:27 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT027.mail.protection.outlook.com (100.127.142.237) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22 via Frontend Transport; Thu, 4 May 2023 13:29:27 +0000 Received: ("Tessian outbound 3a01b65b5aad:v136"); Thu, 04 May 2023 13:29:27 +0000 Received: from a4358d686b9b.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2593CD0A-A6BF-41A1-AAC0-2B0613541D6F.1; Thu, 04 May 2023 13:29:15 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a4358d686b9b.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 04 May 2023 13:29:15 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by DB9PR08MB8409.eurprd08.prod.outlook.com (2603:10a6:10:3d7::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Thu, 4 May 2023 13:29:12 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::bce1:f206:86af:31be]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::bce1:f206:86af:31be%6]) with mapi id 15.20.6363.021; Thu, 4 May 2023 13:29:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b87d0ade-ea7f-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3ioYc2i7kK+BhRWyxLCx2x30+Dx/K6ksmcXzJy71rcM=; b=KfUgqdLpDH9LqZzqfKkq5wbuDve+oCWVumPMxI9LLvuyzOiRMN3TpeNq9FjHQGbN137ZTYRLa6esXh6im5CczOjMbYtXFwzAdVDJ+DEofNOQB2bPS1f9zXYRjPAh+WeVBUspUXw1gIjPklQXD/HWg03DqBLRgaKVDhqwEzOszvE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 1155cd88e01115dd X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B7RgcxXW/soawQ5XTGABrJh8CU985W/sUO8XR21NzCtAvH36uKy07ECEyoI5TLZHkqI8Ey2jMAKGnWYINLuVD05vF9qMN9BEOPOh0+fR4j6otT5QvBDe5Nh/ehOXjmFQTAHysSBMsySQo7FInjqRiWTYwq459gUUWiOZh1ri5RDxjSapu7aQiEG2NskWF18xXtq0G2lafb2qnPsMoGI6HDJokarQBULOdLu9/zff0ko6hxrP41cxGqnUdfzhsdMj4T8vFOEHn2q2WvnNwSMHENjBMctskEQxCaB1ImmWAAoh8Pb0I1kzMus1S1qhYfZsSuk1Xd8DGI8OryH4Gh3mFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3ioYc2i7kK+BhRWyxLCx2x30+Dx/K6ksmcXzJy71rcM=; b=HZt6A48AL0Y14l5trIvBleqIK1bP2aYPuYbYpuWrLW2bKmvW3VXBabIY7pEObqdBeC6JqavoHmoiQAhS34pN+7tpOou5fYOfjHFKZMVaZgzKTSW8IWqd0Kccw1WIrw66kyJXPX5HMrB6ixBgn5yLOo/IVDRlWG7GeUm+uOscAKxJeGwM7XS7USeCFw2cspw7YfKGA9boMepWEuEqRQ5rzVBdZidQ0q4olfRG8Zq0XvBjN8lby5BNIQI2nEu5Tc6VuJvasIKhCdJ5qH6sfgrg2RfYOJVlQ0Szcs20N6MpJGXSLCg8Mhgk8DNPH6mEv4Mm591WIapWnu8gg0kjTVdX2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3ioYc2i7kK+BhRWyxLCx2x30+Dx/K6ksmcXzJy71rcM=; b=KfUgqdLpDH9LqZzqfKkq5wbuDve+oCWVumPMxI9LLvuyzOiRMN3TpeNq9FjHQGbN137ZTYRLa6esXh6im5CczOjMbYtXFwzAdVDJ+DEofNOQB2bPS1f9zXYRjPAh+WeVBUspUXw1gIjPklQXD/HWg03DqBLRgaKVDhqwEzOszvE= From: Luca Fancellu To: Andrew Cooper CC: Xen-devel , Bertrand Marquis , Wei Chen , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH 2/3] xen/misra: xen-analysis.py: allow cppcheck version above 2.7 Thread-Topic: [PATCH 2/3] xen/misra: xen-analysis.py: allow cppcheck version above 2.7 Thread-Index: AQHZfooyZwW8K0Ij5Ua0WLJyhged2K9KGRcAgAACm4A= Date: Thu, 4 May 2023 13:29:12 +0000 Message-ID: <55F767F3-1963-4842-9FBB-9CEF547E9C6B@arm.com> References: <20230504131245.2985400-1-luca.fancellu@arm.com> <20230504131245.2985400-3-luca.fancellu@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.500.231) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|DB9PR08MB8409:EE_|DBAEUR03FT027:EE_|AS2PR08MB8879:EE_ X-MS-Office365-Filtering-Correlation-Id: 208d0b27-8878-4221-c09e-08db4ca39553 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 04f8WVWR8J4TBkAOx/PO+t5b7V8nbKI1Np1l/X4LXewaJXZEdS34L+m34LE7DhFBUPgX5163M9ksHE9cjIJP1tc1mwL9QMfI27/5qv9oocrGz3YG4Azy5Yn5alIxxrwcHEQPkdX6nQtbQ2KuMOlGTx3LYodHgMNgmdFFpM+rqvUxLcLI2sLXpN/JGcnOkBQ4FhoG7Bz41EyV9mlz7n7EhEtojb7BmU4OwL11XVu5APHchfdTCsZu70QaD1CRUu/CZ0nG5ZYavqLO8Z41aLSCBV11a9ywnaCKeWBysaa3J0dADgW//oo3dWP00JLIxpbWGUe+0/wPekzDvQ8AEDzrXAI1rPf8GfROm5HXTlN42cScJyxzefTTSwIPRmxgPhXN9f2oYo3TnOD+zmw6Nri4vIIIFK9+CVrjp3Yp1YJ5N1GXiNMABMFNhEGWhj97w2Yd34kVYSuD2SVmjzpu2h1tGp6iqWxV2C813bfkJYZG7euWg1Q7cY9PB7tvZ4ITLllA8TJweEgiHqkjaZgPcJ7a1Ma/VqUbQrJbXwmMz+S4lL8In3xeo564rYOWI5wThS8SPC8CmA82sOSmI4pHCSctbwva0DrZGdjNs94RodpY5xO9XTcEuVkI6XXbe23pl9uOXUhnSk1QXSFAupxdSq4dMg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(366004)(39860400002)(376002)(346002)(451199021)(83380400001)(5660300002)(54906003)(2906002)(76116006)(66946007)(38100700002)(186003)(316002)(122000001)(8676002)(8936002)(53546011)(6512007)(6506007)(26005)(38070700005)(41300700001)(91956017)(33656002)(2616005)(6486002)(36756003)(64756008)(66556008)(66476007)(66446008)(4326008)(6916009)(71200400001)(478600001)(86362001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <14A7FD90F52B5E408553DD35886720C4@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8409 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0aab4699-f55d-488a-3033-08db4ca38c5d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZoKO/XSerFvWa9lo4oFLhVIwXCCwebcTi6Xky5qV3jLp996Odyenq+dsRhPQyF4QwBWPQRbVIvNn2IdozxrcGg2kbyYUKAsgE0tt0/UDZoio8idTCfORzLtGma58N9XHWDmPpW8xjJe/SH/UXWKCk5rwpR/MOrshBi6gGPp439lxS1qoRtRVF1kyouYlBtCx3+7fOgaDXszaTCvLxEYfWGHpOOYSO+LQFDH4ftDZz4s/SCygd1xCU2aTU5VUlOi8mPUoWPdK4VrMugQzo8QXf/BWjSCK50m4zMhUppntHSQxK0pxnQrxMbFPti8OV6Ez0D6Zow/rm/RAybnhmSGvmoK9NcRC3RnBr4JCcG3A8SFZTMEcUYDMK8KHYvimEKtcB8+n6t9WSclk96WEyhIijjBAaifRLgvOo9dwnKm+/wGxHK/37JAdFE6ejPj/xeBnKolpytCx86aGu5xV19PwJGuvJ85alb/zXPJDmVBz6xzG+OBp+vb9tzXipKS+ddS3UebIe+EWp+UsymRmTcsHUpmlI1wkBYEdXRP4zrAQoZLTEqV0JGsQdHeASnyxhtsKT9Hokk+RygLPSq7KR5N9fjCIAeibEr9jxQ5XW6PN5SIPtDz7NPKrwsxFkzFGKsvC5b6pVWaIwvBJl+Vq91HRLY7U6+rmQaQaukh1rXBKNLCOWvhnPf9eIAiu/7tzNhDAqmicnkyAVPzIDrooc93GQKLNYGJI2TIDwAqFeDqlKxA= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(376002)(136003)(346002)(396003)(451199021)(40470700004)(36840700001)(46966006)(40460700003)(336012)(2616005)(2906002)(47076005)(316002)(6506007)(34020700004)(26005)(6512007)(53546011)(70206006)(4326008)(36860700001)(70586007)(54906003)(41300700001)(5660300002)(6486002)(8936002)(8676002)(6862004)(40480700001)(478600001)(83380400001)(186003)(81166007)(356005)(86362001)(33656002)(82310400005)(36756003)(82740400003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 13:29:27.1731 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 208d0b27-8878-4221-c09e-08db4ca39553 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8879 DQoNCj4gT24gNCBNYXkgMjAyMywgYXQgMTQ6MTksIEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29w ZXIzQGNpdHJpeC5jb20+IHdyb3RlOg0KPiANCj4gT24gMDQvMDUvMjAyMyAyOjEyIHBtLCBMdWNh IEZhbmNlbGx1IHdyb3RlOg0KPj4gQWxsb3cgdGhlIHVzZSBvZiBDcHBjaGVjayB2ZXJzaW9uIGFi b3ZlIDIuNywgZXhjZXB0aW9uIGZvciAyLjggd2hpY2gNCj4+IGlzIGtub3duIGFuZCBkb2N1bWVu dGVkIGRvIGJlIGJyb2tlbi4NCj4+IA0KPj4gU2lnbmVkLW9mZi1ieTogTHVjYSBGYW5jZWxsdSA8 bHVjYS5mYW5jZWxsdUBhcm0uY29tPg0KPj4gLS0tDQo+PiB4ZW4vc2NyaXB0cy94ZW5fYW5hbHlz aXMvY3BwY2hlY2tfYW5hbHlzaXMucHkgfCAyMCArKysrKysrKysrKysrKystLS0tDQo+PiAxIGZp bGUgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkNCj4+IA0KPj4gZGlm ZiAtLWdpdCBhL3hlbi9zY3JpcHRzL3hlbl9hbmFseXNpcy9jcHBjaGVja19hbmFseXNpcy5weSBi L3hlbi9zY3JpcHRzL3hlbl9hbmFseXNpcy9jcHBjaGVja19hbmFseXNpcy5weQ0KPj4gaW5kZXgg NjU4Nzk1YmI5ZjViLi5jMzc4M2U4ZGYzNDMgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vc2NyaXB0cy94 ZW5fYW5hbHlzaXMvY3BwY2hlY2tfYW5hbHlzaXMucHkNCj4+ICsrKyBiL3hlbi9zY3JpcHRzL3hl bl9hbmFseXNpcy9jcHBjaGVja19hbmFseXNpcy5weQ0KPj4gQEAgLTE1NywxMyArMTU3LDI1IEBA IGRlZiBnZW5lcmF0ZV9jcHBjaGVja19kZXBzKCk6DQo+PiAgICAgICAgICAgICAiRXJyb3Igb2Nj dXJlZCByZXRyaWV2aW5nIGNwcGNoZWNrIHZlcnNpb246XG57fVxuXG57fSINCj4+ICAgICAgICAg KQ0KPj4gDQo+PiAtICAgIHZlcnNpb25fcmVnZXggPSByZS5zZWFyY2goJ15DcHBjaGVjayAoLiop JCcsIGludm9rZV9jcHBjaGVjaywgZmxhZ3M9cmUuTSkNCj4+ICsgICAgdmVyc2lvbl9yZWdleCA9 IHJlLnNlYXJjaCgnXkNwcGNoZWNrIChcZCspLihcZCspKD86LlxkKyk/JCcsDQo+PiArICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgaW52b2tlX2NwcGNoZWNrLCBmbGFncz1yZS5NKQ0KPj4g ICAgICMgQ3VycmVudGx5LCBvbmx5IGNwcGNoZWNrIHZlcnNpb24gPj0gMi43IGlzIHN1cHBvcnRl ZCwgYnV0IHZlcnNpb24gMi44IGlzDQo+PiAgICAgIyBrbm93biB0byBiZSBicm9rZW4sIHBsZWFz ZSByZWZlciB0byBkb2NzL21pc3JhL2NwcGNoZWNrLnR4dA0KPj4gLSAgICBpZiAobm90IHZlcnNp b25fcmVnZXgpIG9yIChub3QgdmVyc2lvbl9yZWdleC5ncm91cCgxKS5zdGFydHN3aXRoKCIyLjci KSk6DQo+PiArICAgIGlmIChub3QgdmVyc2lvbl9yZWdleCkgb3IgbGVuKHZlcnNpb25fcmVnZXgu Z3JvdXBzKCkpIDwgMjoNCj4+ICAgICAgICAgcmFpc2UgQ3BwY2hlY2tEZXBzUGhhc2VFcnJvcigN Cj4+IC0gICAgICAgICAgICAgICAgIkNhbid0IGZpbmQgY3BwY2hlY2sgdmVyc2lvbiBvciB2ZXJz aW9uIGlzIG5vdCAyLjciDQo+PiAtICAgICAgICAgICAgICApDQo+PiArICAgICAgICAgICAgIkNh bid0IGZpbmQgY3BwY2hlY2sgdmVyc2lvbiBvciB2ZXJzaW9uIG5vdCBpZGVudGlmaWVkOiAiDQo+ PiArICAgICAgICAgICAgInt9Ii5mb3JtYXQoaW52b2tlX2NwcGNoZWNrKQ0KPj4gKyAgICAgICAg KQ0KPj4gKyAgICBtYWpvciA9IGludCh2ZXJzaW9uX3JlZ2V4Lmdyb3VwKDEpKQ0KPj4gKyAgICBt aW5vciA9IGludCh2ZXJzaW9uX3JlZ2V4Lmdyb3VwKDIpKQ0KPj4gKyAgICBpZiBtYWpvciA8IDIg b3IgKG1ham9yID09IDIgYW5kIG1pbm9yIDwgNyk6DQo+PiArICAgICAgICByYWlzZSBDcHBjaGVj a0RlcHNQaGFzZUVycm9yKA0KPj4gKyAgICAgICAgICAgICJDcHBjaGVjayB2ZXJzaW9uIDwgMi43 IGlzIG5vdCBzdXBwb3J0ZWQiDQo+PiArICAgICAgICApDQo+PiArICAgIGlmIG1ham9yID09IDIg YW5kIG1pbm9yID09IDg6DQo+PiArICAgICAgICByYWlzZSBDcHBjaGVja0RlcHNQaGFzZUVycm9y KA0KPj4gKyAgICAgICAgICAgICJDcHBjaGVjayB2ZXJzaW9uIDIuOCBpcyBrbm93biB0byBiZSBi cm9rZW4sIHNlZSB0aGUgZG9jdW1lbnRhdGlvbiINCj4+ICsgICAgICAgICkNCj4gDQo+IFB5dGhv biBzb3J0cyB0dXBsZXMgdGhlIGhlbHBmdWwgd2F5IGFyb3VuZCwgc28gZm9yIGV4YW1wbGUNCj4g DQo+IHYgPSAoMiwgOSkNCj4gDQo+IGlmIHYgPCAoMiwgNykgb3IgdiA9PSAoMiwgOCk6DQo+ICAg ICAjIGhhbmRsZSBlcnJvcg0KPiANCj4gZG9lcyB3aGF0IHlvdSB3YW50LCBhbmQgZmFyIG1vcmUg Y29uY2lzZWx5Lg0KDQpIaSBBbmRyZXcsDQoNClRoYW5rIHlvdSwgdGhpcyBpcyB2ZXJ5IGhlbHBm dWwsIGl04oCZcyBjbGVhciB0aGF0IEnigJltIGF0IG15IGZpcnN0IGV4cGVyaWVuY2VzIHdpdGgg UHl0aG9uLA0KSSB3aWxsIGNoYW5nZSB0aGUgY29kZSB0byB1c2UgdGhpcyBtb3JlIGNvaW5jaXNl IGZvcm0uDQoNCkNoZWVycywNCkx1Y2ENCg0KPiANCj4gfkFuZHJldw0KDQoNCg== From xen-devel-bounces@lists.xenproject.org Thu May 04 13:31:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 13:31:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529773.824539 (Exim 4.92) (envelope-from ) id 1puZ32-0004Lv-PY; Thu, 04 May 2023 13:31:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529773.824539; Thu, 04 May 2023 13:31:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puZ32-0004Lo-Mn; Thu, 04 May 2023 13:31:04 +0000 Received: by outflank-mailman (input) for mailman id 529773; Thu, 04 May 2023 13:31:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puZ31-0004Lh-Q0 for xen-devel@lists.xenproject.org; Thu, 04 May 2023 13:31:03 +0000 Received: from isrv.corpit.ru (isrv.corpit.ru [86.62.121.231]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e89b52f9-ea7f-11ed-8611-37d641c3527e; Thu, 04 May 2023 15:31:01 +0200 (CEST) Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id E39D4400FD; Thu, 4 May 2023 16:30:59 +0300 (MSK) Received: from [192.168.177.130] (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with ESMTP id E55BC9E; Thu, 4 May 2023 16:30:58 +0300 (MSK) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e89b52f9-ea7f-11ed-8611-37d641c3527e Message-ID: <5f7329f2-8d17-12de-4ea9-74a5932b80c5@msgid.tls.msk.ru> Date: Thu, 4 May 2023 16:30:58 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] 9pfs/xen: Fix segfault on shutdown Content-Language: en-US To: Jason Andryuk , qemu-devel@nongnu.org Cc: Greg Kurz , Christian Schoenebeck , Stefano Stabellini , Anthony Perard , Paul Durrant , "open list:X86 Xen CPUs" References: <20230502143722.15613-1-jandryuk@gmail.com> From: Michael Tokarev In-Reply-To: <20230502143722.15613-1-jandryuk@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit 02.05.2023 17:37, Jason Andryuk wrote: > xen_9pfs_free can't use gnttabdev since it is already closed and NULL-ed > out when free is called. Do the teardown in _disconnect(). This > matches the setup done in _connect(). Ping? /mjt From xen-devel-bounces@lists.xenproject.org Thu May 04 13:36:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 13:36:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529776.824550 (Exim 4.92) (envelope-from ) id 1puZ89-00050m-C0; Thu, 04 May 2023 13:36:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529776.824550; Thu, 04 May 2023 13:36:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puZ89-00050f-9L; Thu, 04 May 2023 13:36:21 +0000 Received: by outflank-mailman (input) for mailman id 529776; Thu, 04 May 2023 13:36:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puZ87-00050V-Uf; Thu, 04 May 2023 13:36:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puZ87-0006yx-OO; Thu, 04 May 2023 13:36:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puZ87-0007Nk-6O; Thu, 04 May 2023 13:36:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1puZ87-0005UF-5v; Thu, 04 May 2023 13:36:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MK1/6KrYMFAvN7ejZ09yhL58G40ImulP6+b5JDPPqfY=; b=cH20l5dJWr8mYUeSfC/n/VfqPj inC2VU/7Tg/MrxKf5MuqonA9ar4qJvhz+FOJU8eX3xJGFp9rXg3qpgE/q/ptAsZ/RfzbLOXMhYp+V TmGMQ8pTgc6a+qqxBEe5YCaG+0C52DMwf/VErNgjuF2BHEp4kIRlRnLrhWiZOdbqfMtk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180525: regressions - FAIL X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:build-arm64-pvops:kernel-build:fail:regression linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-examine:reboot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=1a5304fecee523060f26e2778d9d8e33c0562df3 X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Thu, 04 May 2023 13:36:19 +0000 flight 180525 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/180525/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 180278 build-arm64-pvops 6 kernel-build fail REGR. vs. 180278 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 8 xen-boot fail like 180278 test-armhf-armhf-xl-vhd 8 xen-boot fail like 180278 test-armhf-armhf-examine 8 reboot fail like 180278 test-armhf-armhf-libvirt-raw 8 xen-boot fail like 180278 test-armhf-armhf-xl-rtds 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180278 test-armhf-armhf-xl 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180278 test-armhf-armhf-xl-multivcpu 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail like 180278 test-armhf-armhf-xl-credit2 8 xen-boot fail like 180278 test-armhf-armhf-xl-arndale 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass version targeted for testing: linux 1a5304fecee523060f26e2778d9d8e33c0562df3 baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 17 days Failing since 180281 2023-04-17 06:24:36 Z 17 days 30 attempts Testing same since 180525 2023-05-04 05:05:04 Z 0 days 1 attempts ------------------------------------------------------------ 2224 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 272978 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 04 13:59:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 13:59:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529785.824560 (Exim 4.92) (envelope-from ) id 1puZU8-0007kT-C0; Thu, 04 May 2023 13:59:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529785.824560; Thu, 04 May 2023 13:59:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puZU8-0007kM-8c; Thu, 04 May 2023 13:59:04 +0000 Received: by outflank-mailman (input) for mailman id 529785; Thu, 04 May 2023 13:59:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puZU6-0007kG-Ry for xen-devel@lists.xenproject.org; Thu, 04 May 2023 13:59:02 +0000 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [2a00:1450:4864:20::32c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d22b68e6-ea83-11ed-b226-6b7b168915f2; Thu, 04 May 2023 15:59:00 +0200 (CEST) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-3f173af665fso4104285e9.3 for ; Thu, 04 May 2023 06:59:00 -0700 (PDT) Received: from [192.168.2.1] (82-64-138-184.subs.proxad.net. [82.64.138.184]) by smtp.googlemail.com with ESMTPSA id k1-20020a7bc301000000b003eddc6aa5fasm5024354wmj.39.2023.05.04.06.58.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 May 2023 06:58:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d22b68e6-ea83-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rabbit-lu.20221208.gappssmtp.com; s=20221208; t=1683208740; x=1685800740; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=741OYHclmnary9o8QuEmWBLI/yLKwj6EVSWqvcmDpPk=; b=Ktoj4Y2WCFKxcd/Bza2FkWvcDKZaHrNjIp9fNFMB/s8f2XwFstTADuCWQlqwahabB1 nuFtlvPM3aU9Iq5UhlTcalJERgrJGINvm1/05NnuA3L89nRgEPepkaJ+E0f3Dn5Qai6T y3Ny/8rjCrjgV6W1W3upx51duZdUMdIpG53mapkad30WPe2BE+uFBZx4vpf2yGzCerU7 Y8JDR4dxk1f+Uke9oXCEC6xoS4FO5POEs91cgFvpN7JBgDwmA/Xb43lX4kjZI2TWkuO3 rXYvU5SCfiykJGHPap2ki5o8eQj+8rGb9ExUgJG46GG4CIpLPdRuMrbXnM75F147QyH2 u46w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683208740; x=1685800740; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=741OYHclmnary9o8QuEmWBLI/yLKwj6EVSWqvcmDpPk=; b=dAV4FcsaE7TcXqwMSg1yCFz2opC72hm6EnD/llRVMUxzKr9A/ohX+TnwP+P9cM/Wzk HJQJXkhaXSwNsTwdaNgQJF76tnV5//Mvy8sFwXFqlIxmSC6LhyHIo23rs7PHjJTPHZ2t Xw25EaKjvONLdYBEe7sU7SSNtTMII/bgjeyxrOa8snQZNznhrIiHFfbxh6aTLL09hSBN m6L9/R/yfwku43fyss4xFqUhJGazcQu95ILJP5OFsJ/cC9ASgivSTBAwzeqsGtrS/8/I XNyzAAoJxJWaT2WKkZUlnT616uTEMzzYwlZUai1bxgYRbhiKgmw6v/3xNH2ittiue6Fs UMug== X-Gm-Message-State: AC+VfDwqeoXCwcJbMTfbE7xhpKWLZAsFz33GTjSrsNx4Ki+rgTtdtsc7 m+omT3P0lJpi9Vnw/Pca8FVc2Hya4w2HlQp8zm8uIw== X-Google-Smtp-Source: ACHHUZ4vGVlTodkKYjJUmbu4stY+lxNumSzjMlNzBnYPHHXxS4yamNQKYTPQb180khL0pdtR1pRp/A== X-Received: by 2002:a7b:c015:0:b0:3f1:662a:93d0 with SMTP id c21-20020a7bc015000000b003f1662a93d0mr17906533wmb.15.1683208740096; Thu, 04 May 2023 06:59:00 -0700 (PDT) Message-ID: <50bf6b82-965b-d17c-7c5a-49c703991504@rabbit.lu> Date: Thu, 4 May 2023 15:58:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: zithro Subject: Re: xenstored: EACCESS error accessing control/feature-balloon 1 To: xen-devel@lists.xenproject.org Cc: Juergen Gross , =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= , Julien Grall , Andrew Cooper , Yann Dirson References: <3065c524-07c7-6458-ff4c-ba68ff78c946@rabbit.lu> <474b531f-2067-a5d4-8b01-5b8ef1f7061d@citrix.com> <678df1ff-df18-b063-eda3-2a1aed6d40f8@vates.fr> Content-Language: en-US In-Reply-To: <678df1ff-df18-b063-eda3-2a1aed6d40f8@vates.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, [ snipped for brevity, report summary: XAPI daemon in domU tries to write to a non-existent xenstore node in a non-XAPI dom0 ] On 12 Apr 2023 18:41, Yann Dirson wrote: > Is there anything besides XAPI using this node, or the other data > published by xe-daemon? On my vanilla Xen (ie. non-XAPI), I have no node about "balloon"-ing in xenstore (either dom0 or domU nodes, but I'm not using ballooning in both). > Maybe the original issue is just that there is no reason to have > xe-guest-utilities installed in this setup? That's what I thought as I'm not using XAPI, so maybe the problem should only be addressed to the truenas team ? I posted on their forum but got no answer. I killed the 'xe-daemon' in both setups without loss of functionality. My wild guess is that 'xe-daemon', 'xe-update-guest-attrs' and all 'xenstore* commands' are leftovers from when Xen was working as a dom0 under FreeBSD (why would a *domU* have them ?). But Julien Grall went further by reacting to a suggestion by Yann Dirson (no snip here so you have the full patch details) : On 12 Apr 2023 22:04, Julien Grall wrote: > From a brief look, this is very similar to the patch below that was > sent 3 years ago. I bet no-one ever tested the driver against libxl. > > commit 30a970906038 > Author: Vitaly Kuznetsov > Date: Tue Sep 4 13:39:29 2018 +0200 > > libxl: create control/sysrq xenstore node > > 'xl sysrq' command doesn't work with modern Linux guests with the > following > message in guest's log: > > xen:manage: sysrq_handler: Error -13 writing sysrq in control/sysrq > > xenstore trace confirms: > > IN 0x24bd9a0 20180904 04:36:32 WRITE (control/sysrq ) > OUT 0x24bd9a0 20180904 04:36:32 ERROR (EACCES ) > > The problem seems to be in the fact that we don't pre-create > control/sysrq > xenstore node and libxl_send_sysrq() doing libxl__xs_printf() > creates it as > read-only. As we want to allow guests to clean 'control/sysrq' > after the > requested action is performed, we need to make this node writable. > > Signed-off-by: Vitaly Kuznetsov > Acked-by: Wei Liu > > diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c > index 60676304e9b5..dcfde7787e2c 100644 > --- a/tools/libxl/libxl_create.c > +++ b/tools/libxl/libxl_create.c > @@ -695,6 +695,9 @@ retry_transaction: > GCSPRINTF("%s/control/feature-s4", dom_path), > rwperm, ARRAY_SIZE(rwperm)); > } > + libxl__xs_mknod(gc, t, > + GCSPRINTF("%s/control/sysrq", dom_path), > + rwperm, ARRAY_SIZE(rwperm)); > libxl__xs_mknod(gc, t, > GCSPRINTF("%s/device/suspend/event-channel", > dom_path), > rwperm, ARRAY_SIZE(rwperm)); > >> >> I suspect the best (/least bad) thing to do here is formally introduce >> feature-ballon as a permitted node, and have the toolstack initialise it >> to "" like we do with all other nodes, after which TrueNAS ought to be >> able to set it successfully and not touch it a second time. > > +1. This would match how libxl already deal "feature-s3" & co. So, I will file a bug against truenas anyways, but are you going to alter the xenstore/toolstack ? In that case it may be good to tell them at the same time. Thanks all, Kind regards, zithro/Cyril From xen-devel-bounces@lists.xenproject.org Thu May 04 14:00:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 14:00:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529788.824570 (Exim 4.92) (envelope-from ) id 1puZVl-0000rH-Nx; Thu, 04 May 2023 14:00:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529788.824570; Thu, 04 May 2023 14:00:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puZVl-0000rA-Ke; Thu, 04 May 2023 14:00:45 +0000 Received: by outflank-mailman (input) for mailman id 529788; Thu, 04 May 2023 14:00:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puZVk-0000qe-5c for xen-devel@lists.xenproject.org; Thu, 04 May 2023 14:00:44 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on20612.outbound.protection.outlook.com [2a01:111:f400:7e8a::612]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0e351b29-ea84-11ed-b226-6b7b168915f2; Thu, 04 May 2023 16:00:42 +0200 (CEST) Received: from MW4PR04CA0275.namprd04.prod.outlook.com (2603:10b6:303:89::10) by SN7PR12MB7881.namprd12.prod.outlook.com (2603:10b6:806:34a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Thu, 4 May 2023 14:00:39 +0000 Received: from CO1NAM11FT087.eop-nam11.prod.protection.outlook.com (2603:10b6:303:89:cafe::9c) by MW4PR04CA0275.outlook.office365.com (2603:10b6:303:89::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26 via Frontend Transport; Thu, 4 May 2023 14:00:38 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT087.mail.protection.outlook.com (10.13.174.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.26 via Frontend Transport; Thu, 4 May 2023 14:00:37 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 4 May 2023 09:00:33 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 4 May 2023 07:00:16 -0700 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 4 May 2023 09:00:14 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0e351b29-ea84-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ak0MoNIYap4A0M0CeK7zlTBhhTMgl1lWLzlB/vXKbhLFRULVAN9wdoGmKRwlc/v//0uAsPUE0YnmTi5Acklrqyf92wFi2IDaMk3gk9bOLqCQQSFL3YT/u2poem9NhVaQt/Y3j5sf1XIeiTeQgFpHuT6dh5vVc6FA0BlWVi1/zcQe3UkSAMZpgwJDZlFEBW1yY2lLy+crpzltlh6YTxKP0qIogQuj3RWBpa3BUo5cYnp93OP8xBMH21C/FiZ6emXQPIzffr1envQcUuXp3X7heBU4mfhQmTysO4qVB8MI+PhwPtwrKwOLeD+IH4g71JV0Bz1sIknYkH7V4fjHruPz6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N/o1q/uGkkgP51iWgzuz8DL/hnCZg7fL5E1OxJ1E/Cg=; b=JYi5wBt2HfiFLLEcFGjdC5YM/7sabVMHyJsg2nQ1JljkBWRvSvLlCuZr6/m36S4H/LYsjh2EaZDg/++b9W4jHupE3P4MMydb7yZxg/CoyEHOvqgC5m2+KvPbdQMJANfQKfCAdTKzd0LJxKSBWj21MZP6ekFa1HCQt2TANSaeb+SOPKh4J8WooulI7CsFtVBDHkPGkDz/U4WvNtPxfrWf9zb5zQv2Z/1i7wqVWjxJDBny9GVbOzh1uoiW59DrT7JT6h2/eNyZclzOZOuFyo6NSxJvlxXeAcdSKuUmRutV9si2BVCU1p/5LbtkkaCnnZRuSG0HpWSZ0gYiyjJVLU+5mQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N/o1q/uGkkgP51iWgzuz8DL/hnCZg7fL5E1OxJ1E/Cg=; b=rrFKZbTlY58VKyxx99YsZFV1dUWLye9Nv3b5grPIPNOa2rThvOYhK3AQDlUBWtGnPwDM/fw6AkUnRvkwYql6x1n4C2/netTX/TydmJO1eoeUdzM4QeVYojC74ux+K6iHYClzNIRreFG0iY14IRy0xH18PqY0Bc+M+DN/pMDHbC4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <90c14bae-5071-fa19-7e94-307e939e8b9f@amd.com> Date: Thu, 4 May 2023 16:00:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [XEN v6 08/12] xen: dt: Replace u64 with uint64_t as the callback function parameters for dt_for_each_range() Content-Language: en-US To: Julien Grall , Ayan Kumar Halder , CC: , , , , , , , , References: <20230428175543.11902-1-ayan.kumar.halder@amd.com> <20230428175543.11902-9-ayan.kumar.halder@amd.com> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT087:EE_|SN7PR12MB7881:EE_ X-MS-Office365-Filtering-Correlation-Id: f93005e2-296d-45ce-4c16-08db4ca7f020 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1/RkK+FkGSRePVTC3mYXXZMAUEkfoh16ILTKrVXx3dheHWT1oLzCgcJldFHRei1npPvbpRJ5oN8SpKyG19gNLUAh40EmaazBiBy+BRCx/GY3OugtSahryhCIjSqeObzVChcuLVAoaIyKdhV/6Q6v3mdjXULxzjJzPYa5lB1SJrpvNMfwo/yZpK0KGLdsGay2I0Ko3LFk71dXsweUra+dRD5pk1+po2UphxgsCXkweyNQwMv3472ehlXWRcCcVf+AmfHYKNIxpr7MpElQ7TriPwX5vbkgaCqPoVXNd62HRQtchnYm1d/KWQXid/GuQV4z1SdQho288cpOm5DaFIArBWpC4tdfqUOQs61GiLgg+r9cwNiptC9T93oSOILriqZRyE1kxKltVCEwk4X7J+z2qM/1g+cuoyxgY4FB4n4j2922F2LCyRCLXW6ryCV8uGQIwS/FTXSN4O4mJ82j1WAVT4Y/yL0tXbAbXgTvCPP/SR2tD2zEj44Z4G+JZrswXBvQUw3e4MX1Py6Y1agCGAA6kGsjDy6fFDBZr3sJ8q1zPasSVj6huUoXtT6WwYFY+BUkL/6+cXPuFo3su7TDteNn711P0gHxigS3IRDo921KPBbzQp0PhWwhO7BC4By50h0AniSHaW7oT8GjU7Uzo0j5Ra8yOZfsQOUv0v8rSWuNNHYZ80AsMvFQ8KN0m3uuPGRyRc5TMEb/vFs6GcS9kGHlskvgshRWpFC3aV61cBBTcFTUziUrgWCah3ahDWz1n91TO6AuACEzWdNZJC7fskLiZw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(136003)(376002)(346002)(451199021)(40470700004)(36840700001)(46966006)(36756003)(7416002)(40460700003)(44832011)(478600001)(356005)(81166007)(40480700001)(8676002)(5660300002)(8936002)(82740400003)(110136005)(86362001)(54906003)(16576012)(82310400005)(26005)(31696002)(70206006)(70586007)(47076005)(426003)(4326008)(336012)(186003)(53546011)(41300700001)(2906002)(31686004)(4744005)(316002)(2616005)(36860700001)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 14:00:37.2767 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f93005e2-296d-45ce-4c16-08db4ca7f020 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT087.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7881 On 03/05/2023 14:08, Julien Grall wrote: > > > Hi, > > On 28/04/2023 18:55, Ayan Kumar Halder wrote: >> In the callback functions invoked by dt_for_each_range() ie handle_pci_range(), >> map_range_to_domain(), 'u64' should be replaced with 'uint64_t' as the data type >> for the parameters. > > Please explain why this needs to be replaced. I.e. Xen coding style > mention that u32 should be avoided. > >> Also dt_for_each_range() invokes the callback functions with >> 'uint64_t' arguments. >> >> There is another callback function ie is_bar_valid() which uses 'paddr_t' >> instead of 'u64' or 'uint64_t'. We will change it in the subsequent commit. > > I would rather prefer if this is folded in this patch. > With the Julien's comments fixed: Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Thu May 04 14:02:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 14:02:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529791.824580 (Exim 4.92) (envelope-from ) id 1puZXl-0001Rg-3A; Thu, 04 May 2023 14:02:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529791.824580; Thu, 04 May 2023 14:02:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puZXl-0001RZ-0B; Thu, 04 May 2023 14:02:49 +0000 Received: by outflank-mailman (input) for mailman id 529791; Thu, 04 May 2023 14:02:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puZXk-0001RS-18 for xen-devel@lists.xenproject.org; Thu, 04 May 2023 14:02:48 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20616.outbound.protection.outlook.com [2a01:111:f400:fe5b::616]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 57974971-ea84-11ed-8611-37d641c3527e; Thu, 04 May 2023 16:02:45 +0200 (CEST) Received: from MW4PR04CA0141.namprd04.prod.outlook.com (2603:10b6:303:84::26) by SJ2PR12MB8034.namprd12.prod.outlook.com (2603:10b6:a03:4c7::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Thu, 4 May 2023 14:02:42 +0000 Received: from CO1NAM11FT021.eop-nam11.prod.protection.outlook.com (2603:10b6:303:84:cafe::c8) by MW4PR04CA0141.outlook.office365.com (2603:10b6:303:84::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26 via Frontend Transport; Thu, 4 May 2023 14:02:42 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT021.mail.protection.outlook.com (10.13.175.51) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.26 via Frontend Transport; Thu, 4 May 2023 14:02:41 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 4 May 2023 09:02:38 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 4 May 2023 07:02:29 -0700 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 4 May 2023 09:02:27 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57974971-ea84-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nJRHdZQmxg0Es0JNCevGX8G2QRF48Blkqr8RKMYwZnWYmIbPSXXV/hL+gv8gquSQFhM3WdOd3Ay9eQL5Fi84e1T52iDUJtPddH5Olb3yYrH3c1U6RFGslPQzB/+Pxyp4PfRbuxNOUuCOuEXFSJzPddWqHXJ8ZGSPaH7+nVeNVJLXlAx51nb+JNPZPUETPoR0ozx4rGeTdOCm9y1mS46/KPzdjJEqnR8mRFw/73b2q0wEoaAMP/FHpp92qPyzLz6Wqqb0EWfc9YxQHm3WpID5xG7NcmCEqfUC3OHX3+NNve+6IJs+KlhtyFN4sM7mentxOQyEs3w1pBpzJy4ansbpHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/7oE9mA49/oLEJUa5lypAPBMHC8yVI2C9QFL9UWflj8=; b=i8hAokqmN1I8/l3aqQ7adZFb6fycX/ePDJ8pU7k5AJ3D3GMTPvpuhWn9RJKP+4rb/83zUBsfxSDP6/hIadR6bJBJYtkzTXqJqq2QeKJsKZAR91bSgVAqxxTRFAYAWhxTL0SCW7GB08UNkOTfVcJ/CfCM2bJgSeWWBcIWGNz8UXX8XiHY2WYIqZGF2XWpLQVCG8HnO2KZIOnEBTQehkIKTMPEPsMbhL7nswIyUEKhftjcK3FvL3WEXZ2pEkkb8DwxZaKzY5gas4jJcR9PuNcUTS6S5Oq19qQjIxHpQxR9U/YWMikwfXfJWurAiugRfQ82R4YI/p83cdILsGqRdbU5OA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/7oE9mA49/oLEJUa5lypAPBMHC8yVI2C9QFL9UWflj8=; b=cIxrvC7MNAdSF2yFPL3xujWKcvjVJeW92p1RkDjqGrBXV+2wWcqkyJW3MgWZMCVelmEUUXTY/INMQEpn61Cql5inku0C5Bea1Om2nrbwEGQaks4zSiszCD7r4IDx7eyMsRltvE+yE5tyyejZp/siMF9nN6VWfdh3Jeaqy7OYz6k= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <2f45ce2b-32f1-7289-005a-edbb694a36be@amd.com> Date: Thu, 4 May 2023 16:02:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [XEN v6 10/12] xen/arm: domain_build: Check if the address fits the range of physical address Content-Language: en-US To: Ayan Kumar Halder , CC: , , , , , , , , , References: <20230428175543.11902-1-ayan.kumar.halder@amd.com> <20230428175543.11902-11-ayan.kumar.halder@amd.com> From: Michal Orzel In-Reply-To: <20230428175543.11902-11-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT021:EE_|SJ2PR12MB8034:EE_ X-MS-Office365-Filtering-Correlation-Id: dd76ec00-cd36-486f-707b-08db4ca83a5a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Bekhy7+hLM8TbDX9vu6EFljfO6TOX47l5m2N9b4YJdN1NzW8Yntc61NHA+otsztDsh3fP3dpyuBbnWwgNL6NSOLXys/ZSZjM3mxjS8xM+pAzatk/fV9xdTmIxO/uUzU+BJaElwfWYiqbWQSVfWh9zGhq6RU1sh43b1T1GD78CFpKEBAraeG5t+JKZeoLrRYXzvmZ+iTco1BQJvEsZqBggLqJgioGnSxV2vqcTJNmg5wkL3YScDiRez1n3s/IDgtfkOH3Gc9oA7XS4uj0lW3P7rNPnHi+MU7BovHAhfl7JShMVbWvnAHmTo6xhmzRaCewE7ml0+epMAZv/or9tdUUvCghWteVqjVKQ31Eh0KE7yqmLzsnpTfnPP9hHQMS/JYzkDt7FyKt5WLuvAzoszR0gGxOqcH0qapH9p4Xh2kEnKrnmpJ1uZdgMfzUVOi0wNKuXv3mLdOkZ110Biv7ObJJ8lI4DHskyxkWi2PxSuCYyq0A9vfvSAoocmnyykBzX/ZZ7ER/1vX4erhifE4hi4dP9TK4/UloUGNrIjp3sR9Aie4VRRhBXxuErZ+dtunpUYsGnp8Je6lDlsLvp+N2YQL9iQYqj8odCE1z8t7dYI/BwR/CCeDylK2RA40IpSOpFFWp2mjGCbCc6MTQpk003cWYpsOPADPFiAod47vo83HZklltLL7jMMSCT9AcnDm6ZAk20Py2+sb+4fN3lmJNmvtS5t8DvdZYCbPaLFfsKqTmeGpQ6Rwk2jq+ZVHSePiPNxBbyoZgglMor5Lx/9ssxNswhQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(376002)(396003)(346002)(136003)(451199021)(46966006)(36840700001)(40470700004)(44832011)(54906003)(8936002)(36756003)(186003)(16576012)(8676002)(110136005)(7416002)(31686004)(5660300002)(26005)(426003)(53546011)(40460700003)(41300700001)(81166007)(2906002)(356005)(40480700001)(316002)(70586007)(47076005)(31696002)(2616005)(70206006)(36860700001)(478600001)(82310400005)(4326008)(82740400003)(83380400001)(86362001)(336012)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 14:02:41.8717 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dd76ec00-cd36-486f-707b-08db4ca83a5a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT021.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8034 On 28/04/2023 19:55, Ayan Kumar Halder wrote: > > > handle_pci_range() and map_range_to_domain() take addr and len as uint64_t > parameters. Then frame numbers are obtained from addr and len by right shifting > with PAGE_SHIFT. The frame numbers are expressed using unsigned long. > > Now if 64-bit >> PAGE_SHIFT, the result will have 52-bits as valid. On a 32-bit > system, 'unsigned long' is 32-bits. Thus, there is a potential loss of value > when the result is stored as 'unsigned long'. > > To mitigate this issue, we check if the starting and end address can be > contained within the range of physical address supported on the system. If not, > then an appropriate error is returned. > > Signed-off-by: Ayan Kumar Halder > --- > Changes from :- > v1...v4 - NA. New patch introduced in v5. > > v5 - 1. Updated the error message > 2. Used "(((paddr_t)~0 - addr) < len)" to check the limit on len. > 3. Changes in the prototype of "map_range_to_domain()" has been > addressed by the patch 8. > > xen/arch/arm/domain_build.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 9865340eac..719bb09845 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -1643,6 +1643,13 @@ static int __init handle_pci_range(const struct dt_device_node *dev, > paddr_t start, end; > int res; > > + if ( addr != (paddr_t)addr || (((paddr_t)~0 - addr) < len) ) Given that you enclose the second condition in parenthesis, I would expect the same for the first. > + { > + printk(XENLOG_ERR "%s: [0x%"PRIx64", 0x%"PRIx64"] exceeds the maximum allowed PA width (%u bits)", > + dt_node_full_name(dev), addr, (addr + len), PADDR_BITS); > + return -ERANGE; > + } > + > start = addr & PAGE_MASK; > end = PAGE_ALIGN(addr + len); > res = rangeset_remove_range(mem_holes, PFN_DOWN(start), PFN_DOWN(end - 1)); > @@ -2337,6 +2344,13 @@ int __init map_range_to_domain(const struct dt_device_node *dev, > struct domain *d = mr_data->d; > int res; > > + if ( addr != (paddr_t)addr || (((paddr_t)~0 - addr) < len) ) Same here. Other than that: Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Thu May 04 14:25:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 14:25:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529795.824600 (Exim 4.92) (envelope-from ) id 1puZtp-0004R2-7m; Thu, 04 May 2023 14:25:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529795.824600; Thu, 04 May 2023 14:25:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puZtp-0004Qt-4g; Thu, 04 May 2023 14:25:37 +0000 Received: by outflank-mailman (input) for mailman id 529795; Thu, 04 May 2023 14:25:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puZtn-00049d-Pd for xen-devel@lists.xenproject.org; Thu, 04 May 2023 14:25:35 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 87796bd0-ea87-11ed-b226-6b7b168915f2; Thu, 04 May 2023 16:25:34 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1BA6C2F4; Thu, 4 May 2023 07:26:17 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 987FB3F67D; Thu, 4 May 2023 07:25:31 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 87796bd0-ea87-11ed-b226-6b7b168915f2 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH 0/2] diff-report.py tool Date: Thu, 4 May 2023 15:25:21 +0100 Message-Id: <20230504142523.2989306-1-luca.fancellu@arm.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit -------------------------------------------------------------------------------- This serie is dependent on this patch: https://patchwork.kernel.org/project/xen-devel/patch/20230504131245.2985400-4-luca.fancellu@arm.com/ -------------------------------------------------------------------------------- Now that we have a tool (xen-analysis.py) that wraps cppcheck to generates reports, we have a generic overview of how many static analysis issues and non compliances to MISRA C we have for a certain revision of the codebase. This is great and eventually the work to be done should be just having less and less findings in the report until we reach zero. This is just an ideal trend, because in practice we might have issues that comes from existing code (macro for example) that are not going to be fixed soon for any reason, but we would like to check and see how many issues are introduced by the commits added (ideally zero, but if any is added and the fault resides outside the changed code, maintainers might decide to include it anyway). So the idea is to check the difference between the reports of the codebase: one called "baseline" which is basically the current codebase, the other one called "new report" that is the codebase after the changes. To check if any new finding is added, we need to have a look on every finding in the "new report" that is not listed in the "baseline". It seems very simple, but what can happen to existing findings in the code after a commit is applied? Basically existing findings can be shifted in position due to changes to unrelated lines, or they can be also deleted or fixed for changes involving the findings line (Michal was the first one to point that out). So comparing the two report now seems quite difficult, because if we compare them we will have all the new findings plus all the findings that changed position due to the changes applied. To overcome this, the diff-tool.py is created and it allows to "patch" the "baseline" report, looking into the changes applied to the baseline codebase, described by git diff. This serie is organised in two patch, I've tried to split the amount of code and to leave a meaning, so in the first patch you have everything you need to import cppcheck reports and do a "raw" diff between reports, this gives you an hint about new findings + old findings that has changed place. The second patch is adding the "patching" system, having a class that parses the git diff output and later "patching" the baseline before doing the comparison. This last option is activated only when passing the git diff changes to the tool, but everything is described (I hope) in the help. Some consideration needs to be made, this tool can translate in coordinates (file, line) the findings from the "baseline" to the "new report" using the git diff output as, let me say, a translation matrix. This doesn't mean it can understand the meaning of the findings and recognise them in the new codebase, so for example, a finding related to a line that is moved to another part of the file won't be recognised as "old finding" and will be just removed from the "baseline patched report", however we will find it in the new report unless it contains a fix for the reported issue. This means that the tool is not really suited to be a gatekeeper for the merge action, it is more suitable to help the maintainer to understand when a change is introducing new issues without having to check and compare manually two reports of (nowadays) hundreds of finding. Eventually we could run it in the CI and make the CI reply to the patchwork thread with its output! The tool has also a debug argument that when applied, generates extra files that can be checked against the original files, for example the reports are imported in the tool, and afterwards the debug code will generate them back from the imported data and they should be the same (if everything works). Another debug check is to export the representation of the parsed git diff output, so that the developer can check how and if the parser interpreted correctly the data. Future works for this tool might be to parse also Coverity reports and eventually (don't know if it is possible) also eclair text report. Luca Fancellu (2): xen/misra: add diff-report.py tool xen/misra: diff-report.py: add report patching feature xen/scripts/diff-report.py | 127 +++++++++++ .../xen_analysis/diff_tool/__init__.py | 0 .../xen_analysis/diff_tool/cppcheck_report.py | 41 ++++ xen/scripts/xen_analysis/diff_tool/debug.py | 55 +++++ xen/scripts/xen_analysis/diff_tool/report.py | 198 +++++++++++++++++ .../diff_tool/unified_format_parser.py | 202 ++++++++++++++++++ 6 files changed, 623 insertions(+) create mode 100755 xen/scripts/diff-report.py create mode 100644 xen/scripts/xen_analysis/diff_tool/__init__.py create mode 100644 xen/scripts/xen_analysis/diff_tool/cppcheck_report.py create mode 100644 xen/scripts/xen_analysis/diff_tool/debug.py create mode 100644 xen/scripts/xen_analysis/diff_tool/report.py create mode 100644 xen/scripts/xen_analysis/diff_tool/unified_format_parser.py -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu May 04 14:25:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 14:25:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529794.824590 (Exim 4.92) (envelope-from ) id 1puZtg-00049q-UK; Thu, 04 May 2023 14:25:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529794.824590; Thu, 04 May 2023 14:25:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puZtg-00049j-R0; Thu, 04 May 2023 14:25:28 +0000 Received: by outflank-mailman (input) for mailman id 529794; Thu, 04 May 2023 14:25:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puZtf-00049d-8g for xen-devel@lists.xenproject.org; Thu, 04 May 2023 14:25:27 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20619.outbound.protection.outlook.com [2a01:111:f400:fe12::619]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 82f98000-ea87-11ed-b226-6b7b168915f2; Thu, 04 May 2023 16:25:26 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB7047.eurprd04.prod.outlook.com (2603:10a6:20b:11b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Thu, 4 May 2023 14:25:23 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6363.022; Thu, 4 May 2023 14:25:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 82f98000-ea87-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LJ8YIXYlv0wodUpb+Y9Lgyyk7KE8iGNoQGSNl0WW+vtahVOm3MsWnLvXqd2hggPMrGtFZNRTJ0PnGdJ/ndaa2ujXQ0Xn4GyUhJ5NfHw/STsO/9IXWIB1+ew+mYtnBjvAD5NfgUMZWDWXonyRGAC6EUi0yJvtjpBoJTLWvaUUCsR0286N6nPkXUDg0FQ9jTpGKrKeQmbHP33Q4fqq7nYfFnembPyyvH0WdHUrVgpVoGRZkPDiTSXwXl6O91Ho5P05ZmOZJiLZ6DuK0pLwKEhIDjnz78bRSHYPUjtvJ+Yo3+3WSpBaOg5M0Y89xHGam2hq1w58gGZMZQs2JM9bgEsHuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lum0Eiv6pzZwVF+AjweRCSSqsAI33STHmq0Lr4LkbTY=; b=jGcuJwZeJJCZufQkMDR1D9RqJThgglAiWg+Y7NdVlNBN+5oTfMFrmLK7KuxTSN1aEdB4xeZ8IwH/RoHBSGDYKd9LoPT7ssCEMQOoOui5+ANAg9nPOkuRu2Xhtti+a4r9mXdu6kKWLYgB+aAC1T06l1hAHTg+XWyrj7AMfWaQeUYv8Lxnvhq6bdthTAYHzpyWcqytxeQLKurnHviBqRCZnx/uN+b+c28lySRcXW8pa8yCYi/9rVq7+nl5LafVhvSNrXfDPsF6Wm4Q6ciHQO0Ms8vlDKbZCkBPC7GYYdhHq+fCyRKPN5Dy4x2vkk/I0/AKqjhyuGV1e6bK/5EYISwQIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lum0Eiv6pzZwVF+AjweRCSSqsAI33STHmq0Lr4LkbTY=; b=EZ+hZG1ckR2suYHDG761VvlEbzK6IZ2cCmBeWSdSj8fZlVAGYOm1024JTIzLgpA9VCYO5fLRVnhB2bFKNP5iI8ALDSKkejrPrYRo0TLXoD2DuxeZO/liSA6yxt/zG3lrtJUgKLuVrPUDIRVGN78TO+NPXyBLGaB/5CyaqNGIoBZNCV1IHW/dtoEWNv2zkvCeI6Lwa/Y3vuD5o/rYI0xB52OIAhIvhbgQbWNw4Y5KCa25A1AcnInNIFTfE/3VzRogzYyukOl4SSFA/KgeKwSUTSUlUcUz7Rc5Kr6LrbpcuysL6M2A2dutjB5Vb3fNUKNr2tUKng6hWsx19FqSgqxIRQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 4 May 2023 16:25:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3 4/8] x86/mem-sharing: copy GADDR based shared guest areas Content-Language: en-US To: Tamas K Lengyel Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <472f8314-9ad7-523a-32dc-d5c2138c2c8c@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0083.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB7047:EE_ X-MS-Office365-Filtering-Correlation-Id: 2baf880f-0b94-43db-d672-08db4cab6586 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: m/c/58ZPd/5D9phK4KI3OS3cZOyTbjFjEYjCO7sWipHrEz12wBDhFElol1VucmV/hzVe0IxdXtJDzqqiqOD0q/ZFLk4eLsJ3P+eHtPPoo1jm6mELFjtBZyyrwq3eHX27vDaMCh4hE2xJ1oGUhDiKYoajuIB4t+si8p7h6ynOBgXAw7bGGYJuD7YK2Dih2GYM5Dgf9sghwvYyVzENqyRtanzAwLmKwaiO2TcHHgV41MYydGKETPn33jm93/p6/5mIvb1nCzgsw5DiJkiYx/MZbT2s2L/Pawu9av6yHwK74qN5HW/vNWfhcV1UcTA1oPiO/2+O3qNGy4oMxDJsNaO4TMI1YG/Lyl4shtc3ZMjGoEX3JDMiEobX2LcXYU4Vl67zMseHvJPI/PzEklAoFq2ZKUt3k1MhljcyNLNaWu7OF3yAqfJuSOoTlOjXxtni4GeEpq4pxgk54Khd4pMea6towk+h1IpX0OjNT1mKkz4e/V4Fn2a4DUJQqL28FRoAymJj9l78ze/dRuZGCrxZkcn9y6Hkw1No1FtlEEbCVQFelB/GbXvDs6h7+5UrK+62Z1lfzk5dlVJ/TXq19D81YpUiSKI5FWSXhcBdpVtOxnhDku9asybngqE58dmkywz3b/WYjXC9wyynMzlLoB1+ghLkcw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(396003)(376002)(346002)(136003)(366004)(451199021)(5660300002)(478600001)(38100700002)(8676002)(8936002)(54906003)(2616005)(86362001)(6512007)(6506007)(26005)(31686004)(31696002)(66476007)(66556008)(66946007)(6916009)(83380400001)(6486002)(4326008)(316002)(53546011)(2906002)(186003)(41300700001)(66899021)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UllPWTZ0SjFiNGR6T0RqY0VRQVpRUVZsV1piQW9LclBYUjNrenFxcG81enFU?= =?utf-8?B?R1lROEE1NjJET2hEbEVib2xpaXJsQ3pQTGR1aFBEdWQ5OFI0TExnT3VZOW85?= =?utf-8?B?ZTVNK1dWTG52RksyemhkNWZmS0x6SndycWdVY24wRXpYaFg1RzJtbVlaRmhk?= =?utf-8?B?dGdrclpWODRuNW8wdnlBdGFMK3gwOXQ4eWdHenlmUGNIVnNPeXVDdEhYRGE0?= =?utf-8?B?cytZVUhRQXE5VzRxaGZkSXdYVUpxOUNUZkF3ay9MbUY2ZVpjdGsybWRvZEdt?= =?utf-8?B?Wlg2ZHZ4ZFNNWndDLzZYcGQrN0sxSm00M2JCcElLZ1J4ZzJIdVdiSTYxdFhl?= =?utf-8?B?NllYaVRLazIvcnByL2kxaGc0SHB2MFM4TU5CSzVOQ3N2M0pobW5hR2dvOWNV?= =?utf-8?B?UmtuZlZWWWt2c1I5eUp1VnJkN2xHelRubHRpUUgwdHk2TVc1VlMxQmM3akp5?= =?utf-8?B?eEt1S3BBb25LL0JNWGsyQ2FpTFdMWlNqMVJ2K2gwMTZ4NkU4bTZxMXYvNUYr?= =?utf-8?B?YkZQY29kMWoxMkp4S1gzVjQybkc2anRnVklnL1hZdlBqQ0EzMWxleit6R0Y2?= =?utf-8?B?aFgwQWFMK1UwNlVUQm5yUFFrdElRbHlWUUpONVpwaVIwN2N1Y3BRdHNJM1ps?= =?utf-8?B?aFErK01CVzBTSmtubkJMTnI1QlN5YlFVWlpSWWtUYStEREs0VG5SSkVjMjhW?= =?utf-8?B?SllWbmdWMXBGSmxBejNzUHN1eHhoY28zMmVxcWJrMEFFaWg0M3B5cklnM0th?= =?utf-8?B?b0pzR3dWK2pvanZaK3N6SUtjclQ5TnpQWUR5ZDI3bmZNdmVHc1AxL0FIa0dw?= =?utf-8?B?SHFWZHhGaTZjcmlCU2YwK0M4a0FUMlN0QlhDMUJtL1poT2hQekxiUllOWld6?= =?utf-8?B?eVBnZUVhQnA0b2d5MkpjZUxMNVBjeVNxNnB3VkJpU1VxeVRnVFIrWGpFWGhq?= =?utf-8?B?bm5BandtaXhuSGx4TXJPUCtRU3l2YWVrM1o2RmdJanVOeUhmaWVMejNHMlNY?= =?utf-8?B?akFURlhMSzFOV0pzNENUZXM5bXJhNnQ4bUNuOEtqcHRoSlZqY2tycmJTRzNa?= =?utf-8?B?YzlUUXNYSWZiQXBmK0c2eVd2dVVLS2ZNMHJxZ3F0RlNkTGJuTEJyWnB4ZXhW?= =?utf-8?B?YmpReDM5U1BCNG40YU5sVlhZUnhwUkoxZWlYZFZQOE1jZnhnZ2ZCNDBFTHcv?= =?utf-8?B?NUF1N01DTzlHUWpTN3VBWVlUODIvYjRiN0Nkcm5QVllmVjVEMElVc2tnRkZV?= =?utf-8?B?Y1IxYzc3Yk9nMTNBeGd1YkZjeG9rWk8wMUhvd01wbEdlWmV4TDNMbHVjc09a?= =?utf-8?B?Sm9rL1hoZ0MyU01FU0lvV0swUlNiZ0VTVEtjZXZOblE1OXl0V21YTWZjTWp2?= =?utf-8?B?dXkybVpockUxVDlrSEYxWFd4SklYWDhlLzBvTzhLYzNBejhENVdOVGZ0UXlR?= =?utf-8?B?TUhkRE9qU21iWEZJU01MZCtXYjVjd084M1JtT3c5MUJiVnl0VHJUenFqNVNl?= =?utf-8?B?MUt1T3pxMmxabThEOGI0a0JmTHBsRmgyNFNlLzNDZnNoZzU1NVNBVFRuWlpv?= =?utf-8?B?cUFGbUkzUDIvOU1YUHgyUDNmSnBpZll1THFYMDZXUW9BaDlyTE1aWWlzall0?= =?utf-8?B?dUtibkM5UGk2Ulc4TVZlU2xxc0lUWFQrTVVHeDZQZVhtRzN2ZEVnQkZ3NXBl?= =?utf-8?B?SGlNK3pCd0Mya3FsSWsxcXBkZEVuN2hpb2hGbG1mTmZaRGRoM0gwV3c1aGFZ?= =?utf-8?B?eGRxSCtJOGMzVEs4Y0JERC9OK1RhOE5MRHZVQnoxb2NzVWJYcXhnS1orTUNR?= =?utf-8?B?TC8vZjBBOHZkQ0VRWmhGWTZ0bTFXeFlEZmpQdXlvaEpyeUdVamVHZWIxejl5?= =?utf-8?B?ZnZuUkNQc3U0ZHE2UjlQQXM2ek9GRnVqWUtOTlZoc0lTZ3NwcTlBNkNzVldl?= =?utf-8?B?MEhCdXFPZDY0ME8wNGgyeVRHSjkyU0JPNGRuUnVXM3YwYmhtRmx2a3RGQ25I?= =?utf-8?B?Y2wrQzZqeXlKVFhaRlpqU1Q3QzBEbFhzcVUwOFU1M0wzMERkaDVlL2xXZXVa?= =?utf-8?B?WTBVS1ByN2Z3VXpNNzFhRFVUalUxNEdqaVVPQWdrU0JlRU1kNDV3SVJOSkJS?= =?utf-8?Q?z5PfSyF8P8hD9glyefyuiwk4+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2baf880f-0b94-43db-d672-08db4cab6586 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 14:25:23.1298 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HtYWAvI2n6kyyxkItwRCq49qfgTeYr8NLP7WTfw0oa3ZVnw/Ef8BonQp5lWW09qMIYHo9cL2xM+pazDbbSSW0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7047 On 04.05.2023 14:50, Tamas K Lengyel wrote: > On Thu, May 4, 2023 at 3:44 AM Jan Beulich wrote: >> On 03.05.2023 19:14, Tamas K Lengyel wrote: >>>> @@ -1974,7 +2046,10 @@ int mem_sharing_fork_reset(struct domain >>>> >>>> state: >>>> if ( reset_state ) >>>> + { >>>> rc = copy_settings(d, pd); >>>> + /* TBD: What to do here with -ERESTART? */ >>> >>> Ideally we could avoid hitting code-paths that are restartable during > fork >>> reset since it gets called from vm_event replies that have no concept of >>> handling errors. If we start having errors like this we would just have > to >>> drop the vm_event reply optimization and issue a standalone fork reset >>> hypercall every time which isn't a big deal, it's just slower. >> >> I'm afraid I don't follow: We are in the process of fork-reset here. How >> would issuing "a standalone fork reset hypercall every time" make this >> any different? The possible need for a continuation here comes from a >> failed spin_trylock() in map_guest_area(). That won't change the next >> time round. > > Why not? Who is holding the lock and why wouldn't it ever relinquish it? What state is the fork in at that point in time? We're talking about the fork's hypercall deadlock mutex here, after all. Hence if we knew the fork is paused (just like the parent is), then I don't think -ERESTART can be coming back. (To be precise, both paths leading here are of interest, yet the state the fork is in may be different in both cases.) > If > that's really true then there is a larger issue then just not being able to > report the error back to the user on vm_event_resume path and we need to > devise a way of being able to copy this from the parent bypassing this > lock. The issue isn't that the lock will never become available. But we can't predict how many attempts it'll take. But my earlier question went in a different direction anyway: You did suggest to replace a fork-reset by "a standalone fork reset hypercall every time". I somehow don't get the difference (but it looks like some of your further reply down from here addresses that). > The parent is paused and its state should not be changing while forks > are active, so if the lock was turned into an rwlock of some sort so we can > acquire the read-lock would perhaps be a possible way out of this. Given the specific lock we're talking about here, an rwlock is out of question, I think. >> But perhaps I should say that till now I didn't even pay much attention >> to the 2nd use of the function by vm_event_resume(); I was mainly >> focused on the one from XENMEM_sharing_op_fork_reset, where no >> continuation handling exists. Yet perhaps your comment is mainly >> related to that use? >> >> I actually notice that the comment ahead of the function already has a >> continuation related TODO, just that there thought is only of larger >> memory footprint. > > With XENMEM_sharing_op_fork_reset the caller actually receives the error > code and can decide what to do next. With vm_event_resume there is no path > currently to notify the agent of an error. We could generate another > vm_event to send such an error, but the expectation with fork_reset is that > it will always work because the parent is paused, so not having that path > for an error to get back to the agent isn't a big deal. > > Now, if it becomes the case that due to this locking we can get an error > even while the parent is paused, that will render the vm_event_resume path > unreliably so we would just switch to using XENMEM_sharing_op_fork_reset so > that at least it can re-try in case of an issue. Of course, only if a > reissue of the hypercall has any reasonable chance of succeeding. (I think this is the explanation for the "standalone reset hypercall.) Jan From xen-devel-bounces@lists.xenproject.org Thu May 04 14:25:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 14:25:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529796.824610 (Exim 4.92) (envelope-from ) id 1puZtr-0004i8-Ek; Thu, 04 May 2023 14:25:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529796.824610; Thu, 04 May 2023 14:25:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puZtr-0004hm-Bw; Thu, 04 May 2023 14:25:39 +0000 Received: by outflank-mailman (input) for mailman id 529796; Thu, 04 May 2023 14:25:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puZtp-00049d-MN for xen-devel@lists.xenproject.org; Thu, 04 May 2023 14:25:37 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 8949c1f3-ea87-11ed-b226-6b7b168915f2; Thu, 04 May 2023 16:25:36 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2D3A4139F; Thu, 4 May 2023 07:26:20 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 90E7E3F67D; Thu, 4 May 2023 07:25:34 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8949c1f3-ea87-11ed-b226-6b7b168915f2 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH 2/2] xen/misra: diff-report.py: add report patching feature Date: Thu, 4 May 2023 15:25:23 +0100 Message-Id: <20230504142523.2989306-3-luca.fancellu@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230504142523.2989306-1-luca.fancellu@arm.com> References: <20230504142523.2989306-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a feature to the diff-report.py script that improves the comparison between two analysis report, one from a baseline codebase and the other from the changes applied to the baseline. The comparison between reports of different codebase is an issue because entries in the baseline could have been moved in position due to addition or deletion of unrelated lines or can disappear because of deletion of the interested line, making the comparison between two revisions of the code harder. Having a baseline report, a report of the codebase with the changes called "new report" and a git diff format file that describes the changes happened to the code from the baseline, this feature can understand which entries from the baseline report are deleted or shifted in position due to changes to unrelated lines and can modify them as they will appear in the "new report". Having the "patched baseline" and the "new report", now it's simple to make the diff between them and print only the entry that are new. Signed-off-by: Luca Fancellu --- xen/scripts/diff-report.py | 55 ++++- xen/scripts/xen_analysis/diff_tool/debug.py | 19 ++ xen/scripts/xen_analysis/diff_tool/report.py | 84 ++++++++ .../diff_tool/unified_format_parser.py | 202 ++++++++++++++++++ 4 files changed, 358 insertions(+), 2 deletions(-) create mode 100644 xen/scripts/xen_analysis/diff_tool/unified_format_parser.py diff --git a/xen/scripts/diff-report.py b/xen/scripts/diff-report.py index 4913fb43a8f9..17f707f5d34e 100755 --- a/xen/scripts/diff-report.py +++ b/xen/scripts/diff-report.py @@ -5,6 +5,10 @@ from argparse import ArgumentParser from xen_analysis.diff_tool.debug import Debug from xen_analysis.diff_tool.report import ReportError from xen_analysis.diff_tool.cppcheck_report import CppcheckReport +from xen_analysis.diff_tool.unified_format_parser import \ + (UnifiedFormatParser, UnifiedFormatParseError) +from xen_analysis.utils import invoke_command +from xen_analysis.settings import repo_dir def log_info(text, end='\n'): @@ -32,9 +36,32 @@ def main(argv): "against the baseline.") parser.add_argument("-v", "--verbose", action='store_true', help="Print more informations during the run.") + parser.add_argument("--patch", type=str, + help="The patch file containing the changes to the " + "code, from the baseline analysis result to the " + "'check report' analysis result.\n" + "Do not use with --baseline-rev/--report-rev") + parser.add_argument("--baseline-rev", type=str, + help="Revision or SHA of the codebase analysed to " + "create the baseline report.\n" + "Use together with --report-rev") + parser.add_argument("--report-rev", type=str, + help="Revision or SHA of the codebase analysed to " + "create the 'check report'.\n" + "Use together with --baseline-rev") args = parser.parse_args() + if args.patch and (args.baseline_rev or args.report_rev): + print("ERROR: '--patch' argument can't be used with '--baseline-rev'" + " or '--report-rev'.") + sys.exit(1) + + if bool(args.baseline_rev) != bool(args.report_rev): + print("ERROR: '--baseline-rev' must be used together with " + "'--report-rev'.") + sys.exit(1) + if args.out == "stdout": file_out = sys.stdout else: @@ -59,11 +86,35 @@ def main(argv): new_rep.parse() debug.debug_print_parsed_report(new_rep) log_info(" [OK]") - except ReportError as e: + diff_source = None + if args.patch: + diff_source = os.path.realpath(args.patch) + elif args.baseline_rev: + git_diff = invoke_command( + "git diff --git-dir={} -C -C {}..{}".format(repo_dir, + args.baseline_rev, + args.report_rev), + True, "Error occured invoking:\n{}\n\n{}" + ) + diff_source = git_diff.splitlines(keepends=True) + if diff_source: + log_info("Parsing changes...", "") + diffs = UnifiedFormatParser(diff_source) + debug.debug_print_parsed_diff(diffs) + log_info(" [OK]") + except (ReportError, UnifiedFormatParseError) as e: print("ERROR: {}".format(e)) sys.exit(1) - output = new_rep - baseline + if args.patch or args.baseline_rev: + log_info("Patching baseline...", "") + baseline_patched = baseline.patch(diffs) + debug.debug_print_patched_report(baseline_patched) + log_info(" [OK]") + output = new_rep - baseline_patched + else: + output = new_rep - baseline + print(output, end="", file=file_out) if len(output) > 0: diff --git a/xen/scripts/xen_analysis/diff_tool/debug.py b/xen/scripts/xen_analysis/diff_tool/debug.py index d46df3300d21..c314edbc8e38 100644 --- a/xen/scripts/xen_analysis/diff_tool/debug.py +++ b/xen/scripts/xen_analysis/diff_tool/debug.py @@ -2,6 +2,7 @@ import os from .report import Report +from .unified_format_parser import UnifiedFormatParser class Debug: @@ -34,3 +35,21 @@ class Debug: if not self.args.debug: return self.__debug_print_report(report, ".parsed") + + def debug_print_patched_report(self, report: Report) -> None: + if not self.args.debug: + return + # The patched report contains already .patched in its name + self.__debug_print_report(report, "") + + def debug_print_parsed_diff(self, diff: UnifiedFormatParser) -> None: + if not self.args.debug: + return + diff_filename = diff.get_diff_path() + out_pathname = self.__get_debug_out_filename(diff_filename, ".parsed") + try: + with open(out_pathname, "wt") as outfile: + for change_obj in diff.get_change_sets().values(): + print(change_obj, end="", file=outfile) + except OSError as e: + print("ERROR: Issue opening file {}: {}".format(out_pathname, e)) diff --git a/xen/scripts/xen_analysis/diff_tool/report.py b/xen/scripts/xen_analysis/diff_tool/report.py index d958d1816eb4..312d59682329 100644 --- a/xen/scripts/xen_analysis/diff_tool/report.py +++ b/xen/scripts/xen_analysis/diff_tool/report.py @@ -1,6 +1,7 @@ #!/usr/bin/env python3 import os +from .unified_format_parser import UnifiedFormatParser, ChangeSet class ReportError(Exception): @@ -65,6 +66,89 @@ class Report: self.__entries[entry_path] = [entry] self.__last_line_order += 1 + def remove_entries(self, entry_file_path: str) -> None: + del self.__entries[entry_file_path] + + def remove_entry(self, entry_path: str, line_id: int) -> None: + if entry_path in self.__entries.keys(): + len_entry_path = len(self.__entries[entry_path]) + if len_entry_path == 1: + del self.__entries[entry_path] + else: + if line_id in self.__entries[entry_path]: + self.__entries[entry_path].remove(line_id) + + def patch(self, diff_obj: UnifiedFormatParser) -> 'Report': + filename, file_extension = os.path.splitext(self.__path) + patched_report = self.__class__(filename + ".patched" + file_extension) + remove_files = [] + rename_files = [] + remove_entry = [] + ChangeMode = ChangeSet.ChangeMode + + # Copy entries from this report to the report we are going to patch + for entries in self.__entries.values(): + for entry in entries: + patched_report.add_entry(entry.file_path, entry.line_number, + entry.text) + + # Patch the output report + patched_rep_entries = patched_report.get_report_entries() + for file_diff, change_obj in diff_obj.get_change_sets().items(): + if change_obj.is_change_mode(ChangeMode.COPY): + # Copy the original entry pointed by change_obj.orig_file into + # a new key in the patched report named change_obj.dst_file, + # that here is file_diff variable content, because this + # change_obj is pushed into the change_sets with the + # change_obj.dst_file key + if change_obj.orig_file in self.__entries.keys(): + for entry in self.__entries[change_obj.orig_file]: + patched_report.add_entry(file_diff, + entry.line_number, + entry.text) + + if file_diff in patched_rep_entries.keys(): + if change_obj.is_change_mode(ChangeMode.DELETE): + # No need to check changes here, just remember to delete + # the file from the report + remove_files.append(file_diff) + continue + elif change_obj.is_change_mode(ChangeMode.RENAME): + # Remember to rename the file entry on this report + rename_files.append(change_obj) + + for line_num, change_type in change_obj.get_change_set(): + len_rep = len(patched_rep_entries[file_diff]) + for i in range(len_rep): + rep_item = patched_rep_entries[file_diff][i] + if change_type == ChangeSet.ChangeType.REMOVE: + if rep_item.line_number == line_num: + # This line is removed with this changes, + # append to the list of entries to be removed + remove_entry.append(rep_item) + elif rep_item.line_number > line_num: + rep_item.line_number -= 1 + elif change_type == ChangeSet.ChangeType.ADD: + if rep_item.line_number >= line_num: + rep_item.line_number += 1 + # Remove deleted entries from the list + if len(remove_entry) > 0: + for entry in remove_entry: + patched_report.remove_entry(entry.file_path, + entry.line_id) + remove_entry.clear() + + if len(remove_files) > 0: + for file_name in remove_files: + patched_report.remove_entries(file_name) + + if len(rename_files) > 0: + for change_obj in rename_files: + patched_rep_entries[change_obj.dst_file] = \ + patched_rep_entries.pop(change_obj.orig_file) + + return patched_report + def to_list(self) -> list: report_list = [] for _, entries in self.__entries.items(): diff --git a/xen/scripts/xen_analysis/diff_tool/unified_format_parser.py b/xen/scripts/xen_analysis/diff_tool/unified_format_parser.py new file mode 100644 index 000000000000..e34cc8ac063f --- /dev/null +++ b/xen/scripts/xen_analysis/diff_tool/unified_format_parser.py @@ -0,0 +1,202 @@ +#!/usr/bin/env python3 + +import re +from enum import Enum +from typing import Tuple + + +class UnifiedFormatParseError(Exception): + pass + + +class ParserState(Enum): + FIND_DIFF_HEADER = 0 + REGISTER_CHANGES = 1 + FIND_HUNK_OR_DIFF_HEADER = 2 + + +class ChangeSet: + class ChangeType(Enum): + REMOVE = 0 + ADD = 1 + + class ChangeMode(Enum): + NONE = 0 + CHANGE = 1 + RENAME = 2 + DELETE = 3 + COPY = 4 + + def __init__(self, a_file: str, b_file: str) -> None: + self.orig_file = a_file + self.dst_file = b_file + self.change_mode = ChangeSet.ChangeMode.NONE + self.__changes = [] + + def __str__(self) -> str: + str_out = "{}: {} -> {}:\n{}\n".format( + str(self.change_mode), self.orig_file, self.dst_file, + str(self.__changes) + ) + return str_out + + def set_change_mode(self, change_mode: ChangeMode) -> None: + self.change_mode = change_mode + + def is_change_mode(self, change_mode: ChangeMode) -> bool: + return self.change_mode == change_mode + + def add_change(self, line_number: int, change_type: ChangeType) -> None: + self.__changes.append((line_number, change_type)) + + def get_change_set(self) -> dict: + return self.__changes + + +class UnifiedFormatParser: + def __init__(self, args: str | list) -> None: + if isinstance(args, str): + self.__diff_file = args + try: + with open(self.__diff_file, "rt") as infile: + self.__diff_lines = infile.readlines() + except OSError as e: + raise UnifiedFormatParseError( + "Issue with reading file {}: {}" + .format(self.__diff_file, e) + ) + elif isinstance(args, list): + self.__diff_file = "git-diff-local.txt" + self.__diff_lines = args + else: + raise UnifiedFormatParseError( + "UnifiedFormatParser constructor called with wrong arguments") + + self.__git_diff_header = re.compile(r'^diff --git a/(.*) b/(.*)$') + self.__git_hunk_header = \ + re.compile(r'^@@ -\d+,(\d+) \+(\d+),(\d+) @@.*$') + self.__diff_set = {} + self.__parse() + + def get_diff_path(self) -> str: + return self.__diff_file + + def add_change_set(self, change_set: ChangeSet) -> None: + if not change_set.is_change_mode(ChangeSet.ChangeMode.NONE): + if change_set.is_change_mode(ChangeSet.ChangeMode.COPY): + # Add copy change mode items using the dst_file key, because + # there might be other changes for the orig_file in this diff + self.__diff_set[change_set.dst_file] = change_set + else: + self.__diff_set[change_set.orig_file] = change_set + + def __parse(self) -> None: + def parse_diff_header(line: str) -> ChangeSet | None: + change_item = None + diff_head = self.__git_diff_header.match(line) + if diff_head and diff_head.group(1) and diff_head.group(2): + change_item = ChangeSet(diff_head.group(1), diff_head.group(2)) + + return change_item + + def parse_hunk_header(line: str) -> Tuple[int, int, int]: + file_linenum = -1 + hunk_a_linemax = -1 + hunk_b_linemax = -1 + hunk_head = self.__git_hunk_header.match(line) + if hunk_head and hunk_head.group(1) and hunk_head.group(2) \ + and hunk_head.group(3): + file_linenum = int(hunk_head.group(2)) + hunk_a_linemax = int(hunk_head.group(1)) + hunk_b_linemax = int(hunk_head.group(3)) + + return (file_linenum, hunk_a_linemax, hunk_b_linemax) + + file_linenum = 0 + hunk_a_linemax = 0 + hunk_b_linemax = 0 + diff_elem = None + parse_state = ParserState.FIND_DIFF_HEADER + ChangeMode = ChangeSet.ChangeMode + ChangeType = ChangeSet.ChangeType + + for line in self.__diff_lines: + if parse_state == ParserState.FIND_DIFF_HEADER: + diff_elem = parse_diff_header(line) + if diff_elem: + # Found the diff header, go to the next stage + parse_state = ParserState.FIND_HUNK_OR_DIFF_HEADER + elif parse_state == ParserState.FIND_HUNK_OR_DIFF_HEADER: + # Here only these change modalities will be registered: + # deleted file mode + # rename from + # rename to + # copy from + # copy to + # + # These will be ignored: + # old mode + # new mode + # new file mode + # + # Also these info will be ignored + # similarity index + # dissimilarity index + # index .. + if line.startswith("deleted file"): + # If the file is deleted, register it but don't go through + # the changes that will be only a set of lines removed + diff_elem.set_change_mode(ChangeMode.DELETE) + parse_state = ParserState.FIND_DIFF_HEADER + elif line.startswith("new file"): + # If the file is new, skip it, as it doesn't give any + # useful information on the report translation + parse_state = ParserState.FIND_DIFF_HEADER + elif line.startswith("rename to"): + # Renaming operation can be a pure renaming or a rename + # and a set of change, so keep looking for the hunk + # header + diff_elem.set_change_mode(ChangeMode.RENAME) + elif line.startswith("copy to"): + # This is a copy operation, mark it + diff_elem.set_change_mode(ChangeMode.COPY) + else: + # Look for the hunk header + (file_linenum, hunk_a_linemax, hunk_b_linemax) = \ + parse_hunk_header(line) + if file_linenum >= 0: + if diff_elem.is_change_mode(ChangeMode.NONE): + # The file has only changes + diff_elem.set_change_mode(ChangeMode.CHANGE) + parse_state = ParserState.REGISTER_CHANGES + else: + # ... or there could be a diff header + new_diff_elem = parse_diff_header(line) + if new_diff_elem: + # Found a diff header, register the last change + # item + self.add_change_set(diff_elem) + diff_elem = new_diff_elem + elif parse_state == ParserState.REGISTER_CHANGES: + if (hunk_b_linemax > 0) and line.startswith("+"): + diff_elem.add_change(file_linenum, ChangeType.ADD) + hunk_b_linemax -= 1 + elif (hunk_a_linemax > 0) and line.startswith("-"): + diff_elem.add_change(file_linenum, ChangeType.REMOVE) + hunk_a_linemax -= 1 + file_linenum -= 1 + elif ((hunk_a_linemax + hunk_b_linemax) > 0) and \ + line.startswith(" "): + hunk_a_linemax -= 1 if (hunk_a_linemax > 0) else 0 + hunk_b_linemax -= 1 if (hunk_b_linemax > 0) else 0 + + if (hunk_a_linemax + hunk_b_linemax) <= 0: + parse_state = ParserState.FIND_HUNK_OR_DIFF_HEADER + + file_linenum += 1 + + if diff_elem is not None: + self.add_change_set(diff_elem) + + def get_change_sets(self) -> dict: + return self.__diff_set -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu May 04 14:25:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 14:25:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529797.824620 (Exim 4.92) (envelope-from ) id 1puZtu-00050N-MG; Thu, 04 May 2023 14:25:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529797.824620; Thu, 04 May 2023 14:25:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puZtu-00050C-JF; Thu, 04 May 2023 14:25:42 +0000 Received: by outflank-mailman (input) for mailman id 529797; Thu, 04 May 2023 14:25:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puZtt-0004cz-8Z for xen-devel@lists.xenproject.org; Thu, 04 May 2023 14:25:41 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 8850da65-ea87-11ed-8611-37d641c3527e; Thu, 04 May 2023 16:25:35 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9E006C14; Thu, 4 May 2023 07:26:18 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0D4213F67D; Thu, 4 May 2023 07:25:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8850da65-ea87-11ed-8611-37d641c3527e From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH 1/2] xen/misra: add diff-report.py tool Date: Thu, 4 May 2023 15:25:22 +0100 Message-Id: <20230504142523.2989306-2-luca.fancellu@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230504142523.2989306-1-luca.fancellu@arm.com> References: <20230504142523.2989306-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a new tool, diff-report.py that can be used to make diff between reports generated by xen-analysis.py tool. Currently this tool supports the Xen cppcheck text report format in its operations. The tool prints every finding that is in the report passed with -r (check report) which is not in the report passed with -b (baseline). Signed-off-by: Luca Fancellu --- xen/scripts/diff-report.py | 76 ++++++++++++ .../xen_analysis/diff_tool/__init__.py | 0 .../xen_analysis/diff_tool/cppcheck_report.py | 41 +++++++ xen/scripts/xen_analysis/diff_tool/debug.py | 36 ++++++ xen/scripts/xen_analysis/diff_tool/report.py | 114 ++++++++++++++++++ 5 files changed, 267 insertions(+) create mode 100755 xen/scripts/diff-report.py create mode 100644 xen/scripts/xen_analysis/diff_tool/__init__.py create mode 100644 xen/scripts/xen_analysis/diff_tool/cppcheck_report.py create mode 100644 xen/scripts/xen_analysis/diff_tool/debug.py create mode 100644 xen/scripts/xen_analysis/diff_tool/report.py diff --git a/xen/scripts/diff-report.py b/xen/scripts/diff-report.py new file mode 100755 index 000000000000..4913fb43a8f9 --- /dev/null +++ b/xen/scripts/diff-report.py @@ -0,0 +1,76 @@ +#!/usr/bin/env python3 + +import os, sys +from argparse import ArgumentParser +from xen_analysis.diff_tool.debug import Debug +from xen_analysis.diff_tool.report import ReportError +from xen_analysis.diff_tool.cppcheck_report import CppcheckReport + + +def log_info(text, end='\n'): + global args + global file_out + + if (args.verbose): + print(text, end=end, file=file_out) + + +def main(argv): + global args + global file_out + + parser = ArgumentParser(prog="diff-report.py") + parser.add_argument("-b", "--baseline", required=True, type=str, + help="Path to the baseline report.") + parser.add_argument("--debug", action='store_true', + help="Produce intermediate reports during operations.") + parser.add_argument("-o", "--out", default="stdout", type=str, + help="Where to print the tool output. Default is " + "stdout") + parser.add_argument("-r", "--report", required=True, type=str, + help="Path to the 'check report', the one checked " + "against the baseline.") + parser.add_argument("-v", "--verbose", action='store_true', + help="Print more informations during the run.") + + args = parser.parse_args() + + if args.out == "stdout": + file_out = sys.stdout + else: + try: + file_out = open(args.out, "wt") + except OSError as e: + print("ERROR: Issue opening file {}: {}".format(args.out, e)) + sys.exit(1) + + debug = Debug(args) + + try: + baseline_path = os.path.realpath(args.baseline) + log_info("Loading baseline report {}".format(baseline_path), "") + baseline = CppcheckReport(baseline_path) + baseline.parse() + debug.debug_print_parsed_report(baseline) + log_info(" [OK]") + new_rep_path = os.path.realpath(args.report) + log_info("Loading check report {}".format(new_rep_path), "") + new_rep = CppcheckReport(new_rep_path) + new_rep.parse() + debug.debug_print_parsed_report(new_rep) + log_info(" [OK]") + except ReportError as e: + print("ERROR: {}".format(e)) + sys.exit(1) + + output = new_rep - baseline + print(output, end="", file=file_out) + + if len(output) > 0: + sys.exit(1) + + sys.exit(0) + + +if __name__ == "__main__": + main(sys.argv[1:]) diff --git a/xen/scripts/xen_analysis/diff_tool/__init__.py b/xen/scripts/xen_analysis/diff_tool/__init__.py new file mode 100644 index 000000000000..e69de29bb2d1 diff --git a/xen/scripts/xen_analysis/diff_tool/cppcheck_report.py b/xen/scripts/xen_analysis/diff_tool/cppcheck_report.py new file mode 100644 index 000000000000..787a51aca583 --- /dev/null +++ b/xen/scripts/xen_analysis/diff_tool/cppcheck_report.py @@ -0,0 +1,41 @@ +#!/usr/bin/env python3 + +import re +from .report import Report, ReportError + + +class CppcheckReport(Report): + def __init__(self, report_path: str) -> None: + super().__init__(report_path) + # This matches a string like: + # path/to/file.c(,): + # and captures file name path and line number + # the last capture group is used for text substitution in __str__ + self.__report_entry_regex = re.compile(r'^(.*)\((\d+)(,\d+\):.*)$') + + def parse(self) -> None: + report_path = self.get_report_path() + try: + with open(report_path, "rt") as infile: + report_lines = infile.readlines() + except OSError as e: + raise ReportError("Issue with reading file {}: {}" + .format(report_path, e)) + for line in report_lines: + entry = self.__report_entry_regex.match(line) + if entry and entry.group(1) and entry.group(2): + file_path = entry.group(1) + line_number = int(entry.group(2)) + self.add_entry(file_path, line_number, line) + else: + raise ReportError("Malformed report entry in file {}:\n{}" + .format(report_path, line)) + + def __str__(self) -> str: + ret = "" + for entry in self.to_list(): + ret += re.sub(self.__report_entry_regex, + r'{}({}\3'.format(entry.file_path, + entry.line_number), + entry.text) + return ret diff --git a/xen/scripts/xen_analysis/diff_tool/debug.py b/xen/scripts/xen_analysis/diff_tool/debug.py new file mode 100644 index 000000000000..d46df3300d21 --- /dev/null +++ b/xen/scripts/xen_analysis/diff_tool/debug.py @@ -0,0 +1,36 @@ +#!/usr/bin/env python3 + +import os +from .report import Report + + +class Debug: + def __init__(self, args): + self.args = args + + def __get_debug_out_filename(self, path: str, type: str) -> str: + # Take basename + file_name = os.path.basename(path) + # Split in name and extension + file_name = os.path.splitext(file_name) + if self.args.out != "stdout": + out_folder = os.path.dirname(self.args.out) + else: + out_folder = "./" + dbg_report_path = out_folder + file_name[0] + type + file_name[1] + + return dbg_report_path + + def __debug_print_report(self, report: Report, type: str) -> None: + report_name = self.__get_debug_out_filename(report.get_report_path(), + type) + try: + with open(report_name, "wt") as outfile: + print(report, end="", file=outfile) + except OSError as e: + print("ERROR: Issue opening file {}: {}".format(report_name, e)) + + def debug_print_parsed_report(self, report: Report) -> None: + if not self.args.debug: + return + self.__debug_print_report(report, ".parsed") diff --git a/xen/scripts/xen_analysis/diff_tool/report.py b/xen/scripts/xen_analysis/diff_tool/report.py new file mode 100644 index 000000000000..d958d1816eb4 --- /dev/null +++ b/xen/scripts/xen_analysis/diff_tool/report.py @@ -0,0 +1,114 @@ +#!/usr/bin/env python3 + +import os + + +class ReportError(Exception): + pass + + +class Report: + class ReportEntry: + def __init__(self, file_path: str, line_number: int, + entry_text: list, line_id: int) -> None: + if not isinstance(line_number, int) or \ + not isinstance(line_id, int): + raise ReportError("ReportEntry constructor wrong type args") + self.file_path = file_path + self.line_number = line_number + self.text = entry_text + self.line_id = line_id + + def __str__(self) -> str: + ret = '' + header = 'File path:Count\n' + + for path in self.stats: + ret += f'{path}: {len(self.stats[path])}\n' + + if ret == '': + ret += 'No new issues introduced\n' + + ret = header + ret + + return ret + + def __len__(self) -> int: + ret = 0 + + for ln_list in self.stats.values(): + ret += len(ln_list) + + return ret + + def __init__(self, report_path: str) -> None: + self.__entries = {} + self.__path = report_path + self.__last_line_order = 0 + + def parse(self) -> None: + raise ReportError("Please create a specialised class from 'Report'.") + + def get_report_path(self) -> str: + return self.__path + + def get_report_entries(self) -> dict: + return self.__entries + + def add_entry(self, entry_path: str, entry_line_number: int, + entry_text: list) -> None: + entry = Report.ReportEntry(entry_path, entry_line_number, entry_text, + self.__last_line_order) + if entry_path in self.__entries.keys(): + self.__entries[entry_path].append(entry) + else: + self.__entries[entry_path] = [entry] + self.__last_line_order += 1 + + def to_list(self) -> list: + report_list = [] + for _, entries in self.__entries.items(): + for entry in entries: + report_list.append(entry) + + report_list.sort(key=lambda x: x.line_id) + return report_list + + def __str__(self) -> str: + ret = "" + for entry in self.to_list(): + ret += entry.file_path + ":" + entry.line_number + ":" + entry.text + + return ret + + def __len__(self) -> int: + return len(self.to_list()) + + def __sub__(self, report_b: 'Report') -> 'Report': + if self.__class__ != report_b.__class__: + raise ReportError("Diff of different type of report!") + + filename, file_extension = os.path.splitext(self.__path) + diff_report = self.__class__(filename + ".diff" + file_extension) + # Put in the diff report only records of this report that are not + # present in the report_b. + for file_path, entries in self.__entries.items(): + rep_b_entries = report_b.get_report_entries() + if file_path in rep_b_entries.keys(): + # File path exists in report_b, so check what entries of that + # file path doesn't exist in report_b and add them to the diff + rep_b_entries_num = [ + x.line_number for x in rep_b_entries[file_path] + ] + for entry in entries: + if entry.line_number not in rep_b_entries_num: + diff_report.add_entry(file_path, entry.line_number, + entry.text) + else: + # File path doesn't exist in report_b, so add every entry + # of that file path to the diff + for entry in entries: + diff_report.add_entry(file_path, entry.line_number, + entry.text) + + return diff_report -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu May 04 14:27:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 14:27:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529813.824630 (Exim 4.92) (envelope-from ) id 1puZvQ-0006Q1-8t; Thu, 04 May 2023 14:27:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529813.824630; Thu, 04 May 2023 14:27:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puZvQ-0006Pu-62; Thu, 04 May 2023 14:27:16 +0000 Received: by outflank-mailman (input) for mailman id 529813; Thu, 04 May 2023 14:27:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puZvO-0006Pe-Lj for xen-devel@lists.xenproject.org; Thu, 04 May 2023 14:27:14 +0000 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on20620.outbound.protection.outlook.com [2a01:111:f400:7e83::620]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c12773c4-ea87-11ed-8611-37d641c3527e; Thu, 04 May 2023 16:27:11 +0200 (CEST) Received: from MW4PR04CA0083.namprd04.prod.outlook.com (2603:10b6:303:6b::28) by IA1PR12MB7541.namprd12.prod.outlook.com (2603:10b6:208:42f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Thu, 4 May 2023 14:27:08 +0000 Received: from CO1NAM11FT101.eop-nam11.prod.protection.outlook.com (2603:10b6:303:6b:cafe::25) by MW4PR04CA0083.outlook.office365.com (2603:10b6:303:6b::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26 via Frontend Transport; Thu, 4 May 2023 14:27:07 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT101.mail.protection.outlook.com (10.13.175.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.26 via Frontend Transport; Thu, 4 May 2023 14:27:07 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 4 May 2023 09:27:05 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 4 May 2023 09:26:55 -0500 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 4 May 2023 09:26:53 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c12773c4-ea87-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WDcNXg2LdgacGaYFeU8pVvn6v3Aie+Yp8o6ardijkCDTKdESXTFbE1L0J1WEXMk3GQdmfPopJ+6hRoy5N2ci89qIro/3yG6//cZ4iwPjywdenoheOTenlCmltLETnOH0CfRdexhtwn2DONiaLwPUvQYrzkis+LVexY8g/0s01DBHsUL5YQzQLTNza1aVmUvQAPn0xn+oIMx4jALTjAdfzXi8JotrUBdxR6ihT1Wn63SDGSBSiTTxsyjLrsvUXOXyvGzFBaMfLT5DMivlt9pVo7Rhwwcx3yaBZWP3Dq/CGjNjtDGb2gtFM/MuYtl3rnKLAgYhk1a4yIM1G0wb6nYYEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yReBJkggtW9j5YlcdD87yqF+ZbDUNTJM8rmOi+qPKGQ=; b=CpjLRgWfDs8BsnbB47Q3aj1pWUyqiJYu+ClxoMrO11/LjZXvsO7B1Qlaq5HB16I59G4dhYgktaAJ9U8VTdyk43ZURO1ajuCXg9HD9mVjkMnYPcfevK/6kVIO2/+wYY2/uXUuZdF2gR3oXJkHdOPiUd3ac8jprfI86WTEQ5qUENYq42bSkWlSLUk2gbf8uwRx0Ym9elqcwvyz32GNiCbgeXvXTqSjpsK5SsdDCAwrfMUC8daL99rwp+f72ZqFa8gmGtO1CEnzCQVR0CuuRj4RksZ3Z2K+XVjHhWhDWkVOaWnHSKE9DqHOnqkPPdCZGrqdG+08IJPcst+1c/efZseiwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yReBJkggtW9j5YlcdD87yqF+ZbDUNTJM8rmOi+qPKGQ=; b=NKbihi94TR5t4BugvsGhA0I/oKidbt6pdCCHtFKuSBdgoMWv9u+Sa/BaZjKKrOedeccjWW8JXwHTAbQOOuH1w78yy8gh3OErasTsiviBeu1bfAeueijkok4+Icgti3cjHn568uvEzWNowE709lPl4OG/gLHkLS+TNOAGq1f/V/A= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <29c7bf6a-0db4-5192-b93d-3e3220fe6a2e@amd.com> Date: Thu, 4 May 2023 16:26:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [XEN v6 11/12] xen/arm: p2m: Use the pa_range_info table to support ARM_32 and ARM_64 Content-Language: en-US To: Julien Grall , Ayan Kumar Halder , CC: , , , , , , , , References: <20230428175543.11902-1-ayan.kumar.halder@amd.com> <20230428175543.11902-12-ayan.kumar.halder@amd.com> <63fa927e-72f5-1645-97c0-6986f2fdcabe@xen.org> <178f9c0f-2f72-daac-772b-c3c4221bea40@xen.org> From: Michal Orzel In-Reply-To: <178f9c0f-2f72-daac-772b-c3c4221bea40@xen.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT101:EE_|IA1PR12MB7541:EE_ X-MS-Office365-Filtering-Correlation-Id: 4d21ad43-6b9c-45b7-bc61-08db4caba3de X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SxZh8RKOhHH5pULoRBT8yc0+AAwfnujgqnvedg6RpqQhgedfi7BrpMes61WcsUvtvvdRfzrxVf+kdaAUI8FZ2B3LHfm8rRlXawi8RVwxMipMgETudHKmULRJ8rqrMJhJX5dGA28fN+ZfQzoQhR9uM+R2Rv+yj0sfSVVoaAGxx2R8QPwyNLQTs2ds20tPZpVx0nMhy5rvAzyWOOASXLzpyS2b0v3InwQ2kyz5Ee2jPZG3wR2xGRBSdYFtAlYtJXkhfIk5xgYVPndcWqO1ZINWatT0Z+5JgTykezBNeh+M+VWNvTykcTtxlOqgtVvPy8Bvtw7Fu4uorKQeoBPxhY+nPg+drYnCWzWi8MQ3mnz8K2xnho2hMZTXj6aanptEZ2LCmADamNeygG33SBVTZuGXg6R5O075xnr5J4WK4tXtABc5hlRiBUufOnxBeTcezvJq+ppw4puruExDqRVEDIgxWptzT3RF3ahFHnBbOIsMvHt6wH5MJ2+C+ONarq+6AbkFNLWyGkT5Rik1j/VDBXBUNZGulun6J9Evi+TvwIsItogHxfNrtjAXRiI79xFKW6/fWSaD4lHhIXKEC35pvCzqn6rtLO/cVFooKT9t2KqxBf9jcncl652Hyk5Re3hS5nQUzcNoSyrYOVUOc2gbV++YPfxgLPjz61eSYnowqY1UC324RA3D7nvtgDcB1ZEiRvT+/Iy9EzFX+YNF3QEVXKA3LlR0RhdK5EZ2ywdJ+NdTmlWKRABFkq2zfxdoLACvcdRexeawqkx3eVKt4ZjfUwPSwg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(136003)(396003)(346002)(451199021)(36840700001)(46966006)(40470700004)(40460700003)(31686004)(8936002)(82310400005)(8676002)(7416002)(2616005)(26005)(53546011)(336012)(426003)(36756003)(40480700001)(2906002)(47076005)(83380400001)(44832011)(186003)(478600001)(4326008)(5660300002)(41300700001)(70586007)(70206006)(356005)(316002)(16576012)(110136005)(54906003)(31696002)(82740400003)(36860700001)(86362001)(81166007)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 14:27:07.3896 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4d21ad43-6b9c-45b7-bc61-08db4caba3de X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT101.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7541 On 03/05/2023 14:35, Julien Grall wrote: > > > On 03/05/2023 13:20, Julien Grall wrote: >> Hi, >> >> On 28/04/2023 18:55, Ayan Kumar Halder wrote: >>> Restructure the code so that one can use pa_range_info[] table for both >>> ARM_32 as well as ARM_64. >>> >>> Also, removed the hardcoding for P2M_ROOT_ORDER and P2M_ROOT_LEVEL as >>> p2m_root_order can be obtained from the pa_range_info[].root_order and >>> p2m_root_level can be obtained from pa_range_info[].sl0. >>> >>> Refer ARM DDI 0406C.d ID040418, B3-1345, >>> "Use of concatenated first-level translation tables >>> >>> ...However, a 40-bit input address range with a translation >>> granularity of 4KB >>> requires a total of 28 bits of address resolution. Therefore, a stage 2 >>> translation that supports a 40-bit input address range requires two >>> concatenated >>> first-level translation tables,..." >>> >>> Thus, root-order is 1 for 40-bit IPA on ARM_32. >>> >>> Refer ARM DDI 0406C.d ID040418, B3-1348, >>> >>> "Determining the required first lookup level for stage 2 translations >>> >>> For a stage 2 translation, the output address range from the stage 1 >>> translations determines the required input address range for the stage 2 >>> translation. The permitted values of VTCR.SL0 are: >>> >>> 0b00 Stage 2 translation lookup must start at the second level. >>> 0b01 Stage 2 translation lookup must start at the first level. >>> >>> VTCR.T0SZ must indicate the required input address range. The size of >>> the input >>> address region is 2^(32-T0SZ) bytes." >>> >>> Thus VTCR.SL0 = 1 (maximum value) and VTCR.T0SZ = -8 when the size of >>> input >>> address region is 2^40 bytes. >>> >>> Thus, pa_range_info[].t0sz = 1 (VTCR.S) | 8 (VTCR.T0SZ) ie 11000b >>> which is 24. >>> >>> Signed-off-by: Ayan Kumar Halder >>> --- >>> Changes from - >>> >>> v3 - 1. New patch introduced in v4. >>> 2. Restructure the code such that pa_range_info[] is used both by >>> ARM_32 as >>> well as ARM_64. >>> >>> v4 - 1. Removed the hardcoded definitions of P2M_ROOT_ORDER and >>> P2M_ROOT_LEVEL. >>> The reason being root_order will not be always 1 (See the next patch). >>> 2. Updated the commit message to explain t0sz, sl0 and root_order >>> values for >>> 32-bit IPA on Arm32. >>> 3. Some sanity fixes. >>> >>> v5 - pa_range_info is indexed by system_cpuinfo.mm64.pa_range. ie >>> when PARange is 0, the PA size is 32, 1 -> 36 and so on. So >>> pa_range_info[] has >>> been updated accordingly. >>> For ARM_32 pa_range_info[0] = 0 and pa_range_info[1] = 0 as we do not >>> support >>> 32-bit, 36-bit physical address range yet. >>> >>> xen/arch/arm/include/asm/p2m.h |  8 +------- >>> xen/arch/arm/p2m.c | 32 ++++++++++++++++++-------------- >>> 2 files changed, 19 insertions(+), 21 deletions(-) >>> >>> diff --git a/xen/arch/arm/include/asm/p2m.h >>> b/xen/arch/arm/include/asm/p2m.h >>> index f67e9ddc72..4ddd4643d7 100644 >>> --- a/xen/arch/arm/include/asm/p2m.h >>> +++ b/xen/arch/arm/include/asm/p2m.h >>> @@ -14,16 +14,10 @@ >>> /* Holds the bit size of IPAs in p2m tables. */ >>> extern unsigned int p2m_ipa_bits; >>> -#ifdef CONFIG_ARM_64 >>> extern unsigned int p2m_root_order; >>> extern unsigned int p2m_root_level; >>> -#define P2M_ROOT_ORDER p2m_root_order >>> +#define P2M_ROOT_ORDER p2m_root_order >> >> This looks like a spurious change. >> >>> #define P2M_ROOT_LEVEL p2m_root_level >>> -#else >>> -/* First level P2M is always 2 consecutive pages */ >>> -#define P2M_ROOT_ORDER 1 >>> -#define P2M_ROOT_LEVEL 1 >>> -#endif >>> struct domain; >>> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c >>> index 418997843d..1fe3cccf46 100644 >>> --- a/xen/arch/arm/p2m.c >>> +++ b/xen/arch/arm/p2m.c >>> @@ -19,9 +19,9 @@ >>> #define INVALID_VMID 0 /* VMID 0 is reserved */ >>> -#ifdef CONFIG_ARM_64 >>> unsigned int __read_mostly p2m_root_order; >>> unsigned int __read_mostly p2m_root_level; >>> +#ifdef CONFIG_ARM_64 >>> static unsigned int __read_mostly max_vmid = MAX_VMID_8_BIT; >>> /* VMID is by default 8 bit width on AArch64 */ >>> #define MAX_VMID max_vmid >>> @@ -2247,16 +2247,6 @@ void __init setup_virt_paging(void) >>> /* Setup Stage 2 address translation */ >>> register_t val = >>> VTCR_RES1|VTCR_SH0_IS|VTCR_ORGN0_WBWA|VTCR_IRGN0_WBWA; >>> -#ifdef CONFIG_ARM_32 >>> - if ( p2m_ipa_bits < 40 ) >>> - panic("P2M: Not able to support %u-bit IPA at the moment\n", >>> - p2m_ipa_bits); >>> - >>> - printk("P2M: 40-bit IPA\n"); >>> - p2m_ipa_bits = 40; >>> - val |= VTCR_T0SZ(0x18); /* 40 bit IPA */ >>> - val |= VTCR_SL0(0x1); /* P2M starts at first level */ >>> -#else /* CONFIG_ARM_64 */ >>> static const struct { >>> unsigned int pabits; /* Physical Address Size */ >>> unsigned int t0sz; /* Desired T0SZ, minimum in comment */ >>> @@ -2265,19 +2255,26 @@ void __init setup_virt_paging(void) >>> } pa_range_info[] __initconst = { >>> /* T0SZ minimum and SL0 maximum from ARM DDI 0487H.a Table >>> D5-6 */ >>> /* PA size, t0sz(min), root-order, sl0(max) */ >>> + [2] = { 40, 24/*24*/, 1, 1 }, >> >> I don't like the fact that the index are not ordered anymore and... >> >>> +#ifdef CONFIG_ARM_64 >>> [0] = { 32, 32/*32*/, 0, 1 }, >>> [1] = { 36, 28/*28*/, 0, 1 }, >>> - [2] = { 40, 24/*24*/, 1, 1 }, >>> [3] = { 42, 22/*22*/, 3, 1 }, >>> [4] = { 44, 20/*20*/, 0, 2 }, >>> [5] = { 48, 16/*16*/, 0, 2 }, >>> [6] = { 52, 12/*12*/, 4, 2 }, >>> [7] = { 0 }  /* Invalid */ >>> +#else >>> + [0] = { 0 }, /* Invalid */ >>> + [1] = { 0 }, /* Invalid */ >>> + [3] = { 0 }  /* Invalid */ >>> +#endif >> >> ... it is not clear to me why we are adding 3 extra entries. I think it >> would be better if we do: >> >> #ifdef CONFIG_ARM_64 >> [0] ... >> [1] ... >> #endif >> [2] ... >> #ifdef CONFIG_ARM_64 >> [3] ... >> [4] ... >> ... >> #endif > > Looking at the next patch. An alternative would be to go back > duplicating the lines. So after the two patches we would have > > #ifdef CONFIG_ARM_64 > [0] ... > [7] ... > #else > { /* 32-bit */ } > { /* 40-bit */ } > #endif +1 for this approach ~Michal From xen-devel-bounces@lists.xenproject.org Thu May 04 14:32:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 14:32:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529816.824639 (Exim 4.92) (envelope-from ) id 1puZzt-00081Q-QM; Thu, 04 May 2023 14:31:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529816.824639; Thu, 04 May 2023 14:31:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puZzt-00081J-Nb; Thu, 04 May 2023 14:31:53 +0000 Received: by outflank-mailman (input) for mailman id 529816; Thu, 04 May 2023 14:31:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puZzs-00081D-Fe for xen-devel@lists.xenproject.org; Thu, 04 May 2023 14:31:52 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20619.outbound.protection.outlook.com [2a01:111:f400:fe1a::619]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 67515649-ea88-11ed-b226-6b7b168915f2; Thu, 04 May 2023 16:31:49 +0200 (CEST) Received: from DB8PR06CA0033.eurprd06.prod.outlook.com (2603:10a6:10:100::46) by AS8PR08MB8299.eurprd08.prod.outlook.com (2603:10a6:20b:56f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.21; Thu, 4 May 2023 14:31:47 +0000 Received: from DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:100:cafe::22) by DB8PR06CA0033.outlook.office365.com (2603:10a6:10:100::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26 via Frontend Transport; Thu, 4 May 2023 14:31:47 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT011.mail.protection.outlook.com (100.127.142.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26 via Frontend Transport; Thu, 4 May 2023 14:31:46 +0000 Received: ("Tessian outbound 5154e9d36775:v136"); Thu, 04 May 2023 14:31:46 +0000 Received: from 883d0a7524a4.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 78955CA4-2807-49F1-B95B-30FAA3DE5579.1; Thu, 04 May 2023 14:31:39 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 883d0a7524a4.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 04 May 2023 14:31:39 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by AM8PR08MB6436.eurprd08.prod.outlook.com (2603:10a6:20b:365::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.21; Thu, 4 May 2023 14:31:38 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::a4ab:cdfa:b445:7ecb]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::a4ab:cdfa:b445:7ecb%7]) with mapi id 15.20.6363.026; Thu, 4 May 2023 14:31:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 67515649-ea88-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TtzQXUYKMj+AdmzNXO2SGo6npQB/QyLYID7bcjuPU6I=; b=oP6tEUcnoF8CbHfAToc0wtN77NzoY969wUUUZrDkNGo3I293WxU61tVp/d6TUVJ9D5269o7Y9yEg6ULOj0JolCj7IV9o10iY9kyiOaW65MDDenpj05rVwyac7RZvoxBe2l9F9LLuxEz6DuNtjhIL32QIUzTPXFFJ1aRI+PUU9Yg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: a89e8712633c4e1c X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g8G18LqzIc64k+tDxq/EKlThpU8nnjlVFGJTUfTjr/n5Tb8XCQRCvbADkohE9dzJABDOAqalxCe9ITsWxx6aW6iaq4WoeiTC7c+q9CQAbr9o/wB5Id3FwH62RCFa1UqtM85FK61Wp9mb9X8aa8jZBAtWPFrYDVKQlwZ3cffAISF9m3gYYPZXoPxY+VAt4mZfyIQx/542Ac4CDHC0P9QRH4JUXWbdTtrDGiuFuY0LLFoInNRvAOamOkYnn1bMu09m49LLFOingZozRYbv+2xA5qISWu+oDffNsoYf9czMD20E/xSg/7lVrD5BoLGweCTzU859cWU779zywKmsceoGQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TtzQXUYKMj+AdmzNXO2SGo6npQB/QyLYID7bcjuPU6I=; b=KnsemLskmTl6iWxGV2GiSlZkfPNQxqYDHz7nlHVE9TEGULUQ1EM43QxrH+6JGXYeY1MGU+MAcmGr7pNxq/x4HJlMrtV+EuNxL7I9/XtxLkxEVPo8HNcWJP4Ct91kv4OgT/5PRtXjlwhlZdkhx/y4HTccdUg9zwl/hVn3bsPfZnMW4m175b3HSdfT8CJFmjwcOo0D3v65ySymdzH7Lv04/1uvLaq248JTBSDqty/E6N6qmJcPOiiziiaZJeCSym+iFbbuC27er5GApeBdrkSrqGERt/H7Rlsn0Jv1Ztf1FLAjDIKxwX0/iA4kqii7NanknJSriptkrnI+oWStukBTKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TtzQXUYKMj+AdmzNXO2SGo6npQB/QyLYID7bcjuPU6I=; b=oP6tEUcnoF8CbHfAToc0wtN77NzoY969wUUUZrDkNGo3I293WxU61tVp/d6TUVJ9D5269o7Y9yEg6ULOj0JolCj7IV9o10iY9kyiOaW65MDDenpj05rVwyac7RZvoxBe2l9F9LLuxEz6DuNtjhIL32QIUzTPXFFJ1aRI+PUU9Yg= From: Rahul Singh To: Michal Orzel CC: Ayan Kumar Halder , Xen developer discussion , Stefano Stabellini , "Stabellini, Stefano" , Julien Grall , "Volodymyr_Babchuk@epam.com" , Bertrand Marquis , "andrew.cooper3@citrix.com" , "george.dunlap@citrix.com" , "jbeulich@suse.com" , "wl@xen.org" Subject: Re: [XEN v6 04/12] xen/arm: smmu: Use writeq_relaxed_non_atomic() for writing to SMMU_CBn_TTBR0 Thread-Topic: [XEN v6 04/12] xen/arm: smmu: Use writeq_relaxed_non_atomic() for writing to SMMU_CBn_TTBR0 Thread-Index: AQHZefsV/U5NscHjSECspfoDYyGz6a9JwnmAgABzyIA= Date: Thu, 4 May 2023 14:31:37 +0000 Message-ID: <675F9B31-1720-4AD3-932A-67D98FDDF7DE@arm.com> References: <20230428175543.11902-1-ayan.kumar.halder@amd.com> <20230428175543.11902-5-ayan.kumar.halder@amd.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7158:EE_|AM8PR08MB6436:EE_|DBAEUR03FT011:EE_|AS8PR08MB8299:EE_ X-MS-Office365-Filtering-Correlation-Id: 5dc6f856-30cb-4b91-6906-08db4cac4a24 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: f1/OVeizTfDOGIwcwymgm9aa+ZdQ7MwQhX3knN+zTsdCZ2v3VgDMBE8KtknyjVmTjTi6h4XIX0/bKkRvGFNO9oReqbMnAhSYYTq2Pu4KVbK3tc4HclJyGF1TKwog3ABJDZVfuC/1jyd8tNTm79iZeK7u0NLKdJeFiYznXX1NLoFlst2rEe2hp/sfIyVfs7yb9IihyauBI7PN2lCLqfD4LoIaRCPEmtB3nigIWLnqMHxsXOIcMjSjuvmbWugMBCDQnWtETFMCgLqd6LfmEQSV1HHqml1p+g0su91jAz9a+MBdW/fGnY5fki6CfQ9CWROhmWMPX7YfGyM2poTLpYu2XKy9zZKirDts1C0I5p2Yc3qxP4uV6nVghv8iXqEjT2vOpc3TMbitIRMuUC5cjKJ4omDb1BEoKsViJCsx4gnMqrI0GJI+rpC4gd/kftSWELdnsbm7NIYMVhUW+/pDrKYb9jXDMqV1qeUbNubJk0t21re8n9qkLxx/a5pyh5ZcB0nBJHgNKjNJKXUilHYSuf9dIxGewfas6gp7LEvDOFxe1f/IMcJtsK+mfvo8fktchpE505kuAsTVzvnLlpTC+hQrqg5SKZZHvmHlN2azpVW9sNZZK2JZ2vhc/Us+VuYNCfNRKc1JBno7TTpI3r+S2Z5Swg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(346002)(39860400002)(396003)(376002)(136003)(451199021)(316002)(83380400001)(91956017)(71200400001)(6512007)(478600001)(6916009)(186003)(2616005)(26005)(54906003)(53546011)(6506007)(6486002)(76116006)(36756003)(122000001)(7416002)(2906002)(38100700002)(33656002)(5660300002)(4326008)(8936002)(66476007)(66446008)(8676002)(66556008)(66946007)(64756008)(41300700001)(38070700005)(86362001)(45980500001);DIR:OUT;SFP:1101; Content-Type: multipart/alternative; boundary="_000_675F9B3117204AD3932A67D98FDDF7DEarmcom_" MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6436 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: fd986f87-4cfd-4b50-359b-08db4cac4509 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IwS7ChGoMOHUo4PDaCMqwJlpC/ITlaB37nejg+7k1xvO8SQW87GcC398MLQAMO0FT6y5E8BE0AfV3roJSBPuK9mLU7q7PWo7KiiohrLSKKyieqPuzDZWJ77VSQSsNxkNHNmdmJj5mD4B4+julM9+u9mrlRgmGgpY/FVP5r9DTaI4rWG2Vm8G+MLpRTe6x4i5hlZ9YCqbXAZLZoi7YtnXmYri7JQym+RmxW1CRVLuFyj3L7TkmH0n0oToqdfwHpHxeuZF9ofMeCA1rXHthMx2kUk43QodP4bRG0KUtn1GUuBYIFVoMY2pTKDa5ihwz7cRqHkxzCZlbKL0oH8vYoHR6XU6NPqBSFOq+c7qIvlgRBE6L7zUKF+zWarXWtDUPMm1yrR1mnI0VnpUF5a4PejhqNht0SvVWEg/gawXVgejKPbcX/9O97dWjHmZcv2NmsIrpO1tBic6XR9yWrKq5EttnRXtaqi/MkaTIFSGTSSfDwH5P72Wn8RYxry2/sTHSXIh7m/Njvxv20uujdfcNJTvGLplkj7hJmzuXjndUfGrMQflkNrpfiYp0//7kHhwVL3y4T6vlkaOUG4m7z1e0yhiAlGAJHA59kx9JYHxM+d2AzEcBPXKyiahlOyKeuN7PkPqPMFtc3bBLYlWPha76LezPefPuMNbNXVcQFin6v5HFB3SYNreN4q88/q2wnSiR76pSm657Q0BVOO+pX78L03FQb+gZgmwr4C+2Ls7/Ysuroo= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(376002)(39860400002)(346002)(451199021)(46966006)(40470700004)(36840700001)(45080400002)(54906003)(186003)(478600001)(6506007)(2616005)(6512007)(53546011)(336012)(26005)(36860700001)(6486002)(47076005)(4326008)(70206006)(70586007)(41300700001)(316002)(34020700004)(83380400001)(6862004)(5660300002)(8676002)(8936002)(82740400003)(81166007)(2906002)(40460700003)(356005)(40480700001)(36756003)(33656002)(86362001)(82310400005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 14:31:46.5043 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5dc6f856-30cb-4b91-6906-08db4cac4a24 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8299 --_000_675F9B3117204AD3932A67D98FDDF7DEarmcom_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ayan, On 4 May 2023, at 8:37 am, Michal Orzel wrote: On 28/04/2023 19:55, Ayan Kumar Halder wrote: Refer ARM IHI 0062D.c ID070116 (SMMU 2.0 spec), 17-360, 17.3.9, SMMU_CBn_TTBR0 is a 64 bit register. Thus, one can use writeq_relaxed_non_atomic() to write to it instead of invoking writel_relaxed() twice for lower half and upper half of the register. This also helps us as p2maddr is 'paddr_t' (which may be u32 in future). Thus, one can assign p2maddr to a 64 bit register and do the bit manipulations on it, to generate the value for SMMU_CBn_TTBR0. Signed-off-by: Ayan Kumar Halder Reviewed-by: Stefano Stabellini --- Changes from - v1 - 1. Extracted the patch from "[XEN v1 8/9] xen/arm: Other adaptations r= equired to support 32bit paddr". Use writeq_relaxed_non_atomic() to write u64 register in a non-atomic fashion. v2 - 1. Added R-b. v3 - 1. No changes. v4 - 1. Reordered the R-b. No further changes. (This patch can be committed independent of the series). v5 - Used 'uint64_t' instead of u64. As the change looked trivial to me, I retained the R-b. xen/drivers/passthrough/arm/smmu.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/a= rm/smmu.c index 79281075ba..fb8bef5f69 100644 --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -499,8 +499,7 @@ enum arm_smmu_s2cr_privcfg { #define ARM_SMMU_CB_SCTLR 0x0 #define ARM_SMMU_CB_RESUME 0x8 #define ARM_SMMU_CB_TTBCR2 0x10 -#define ARM_SMMU_CB_TTBR0_LO 0x20 -#define ARM_SMMU_CB_TTBR0_HI 0x24 +#define ARM_SMMU_CB_TTBR0 0x20 #define ARM_SMMU_CB_TTBCR 0x30 #define ARM_SMMU_CB_S1_MAIR0 0x38 #define ARM_SMMU_CB_FSR 0x58 @@ -1083,6 +1082,7 @@ static void arm_smmu_flush_pgtable(struct arm_smmu_de= vice *smmu, void *addr, static void arm_smmu_init_context_bank(struct arm_smmu_domain *smmu_domain) { u32 reg; + uint64_t reg64; bool stage1; struct arm_smmu_cfg *cfg =3D &smmu_domain->cfg; struct arm_smmu_device *smmu =3D smmu_domain->smmu; @@ -1177,12 +1177,13 @@ static void arm_smmu_init_context_bank(struct arm_s= mmu_domain *smmu_domain) dev_notice(smmu->dev, "d%u: p2maddr 0x%"PRIpaddr"\n", smmu_domain->cfg.domain->domain_id, p2maddr); - reg =3D (p2maddr & ((1ULL << 32) - 1)); - writel_relaxed(reg, cb_base + ARM_SMMU_CB_TTBR0_LO); - reg =3D (p2maddr >> 32); + reg64 =3D p2maddr; + if (stage1) - reg |=3D ARM_SMMU_CB_ASID(cfg) << TTBRn_HI_ASID_SHIFT; - writel_relaxed(reg, cb_base + ARM_SMMU_CB_TTBR0_HI); + reg64 |=3D (((uint64_t) (ARM_SMMU_CB_ASID(cfg) << TTBRn_HI_= ASID_SHIFT)) + << 32); I think << should be aligned to the second '(' above. Reviewed-by: Michal Orzel > With the Michal comment fixed. Reviewed-by: Rahul Singh > Regards, Rahul --_000_675F9B3117204AD3932A67D98FDDF7DEarmcom_ Content-Type: text/html; charset="us-ascii" Content-ID: <341421C73333064887EE899DA89C9868@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable
Hi Ayan,

On 4 May 2023, at 8:37 am, Michal Orzel <michal.orzel@amd.com> w= rote:



On 28/04/2023 19:55, Ayan Kumar Halder wrote:


Refer ARM IHI 0062D.c ID070116 (SMMU 2.0 spec), 17-360, 17.3.9,
SMMU_CBn_TTBR0 is a 64 bit register. Thus, one can use
writeq_relaxed_non_atomic() to write to it instead of invoking
writel_relaxed() twice for lower half and upper half of the register.

This also helps us as p2maddr is 'paddr_t' (which may be u32 in future). Thus, one can assign p2maddr to a 64 bit register and do the bit
manipulations on it, to generate the value for SMMU_CBn_TTBR0.

Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@amd.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
Changes from -

v1 - 1. Extracted the patch from "[XEN v1 8/9] xen/arm: Other adaptati= ons required to support 32bit paddr".
Use writeq_relaxed_non_atomic() to write u64 register in a non-atomic
fashion.

v2 - 1. Added R-b.

v3 - 1. No changes.

v4 - 1. Reordered the R-b. No further changes.
(This patch can be committed independent of the series).

v5 - Used 'uint64_t' instead of u64. As the change looked trivial to me, I<= br> retained the R-b.

xen/drivers/passthrough/arm/smmu.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/a= rm/smmu.c
index 79281075ba..fb8bef5f69 100644
--- a/xen/drivers/passthrough/arm/smmu.c
+++ b/xen/drivers/passthrough/arm/smmu.c
@@ -499,8 +499,7 @@ enum arm_smmu_s2cr_privcfg {
#define ARM_SMMU_CB_SCTLR         &= nbsp;    0x0
#define ARM_SMMU_CB_RESUME         =     0x8
#define ARM_SMMU_CB_TTBCR2         =     0x10
-#define ARM_SMMU_CB_TTBR0_LO        &nb= sp;  0x20
-#define ARM_SMMU_CB_TTBR0_HI        &nb= sp;  0x24
+#define ARM_SMMU_CB_TTBR0         =      0x20
#define ARM_SMMU_CB_TTBCR         &= nbsp;    0x30
#define ARM_SMMU_CB_S1_MAIR0        &nbs= p;  0x38
#define ARM_SMMU_CB_FSR         &nb= sp;            =   0x58
@@ -1083,6 +1082,7 @@ static void arm_smmu_flush_pgtable(struct arm_smmu_de= vice *smmu, void *addr,
static void arm_smmu_init_context_bank(struct arm_smmu_domain *smmu_domain)=
{
       u32 reg;
+       uint64_t reg64;
       bool stage1;
       struct arm_smmu_cfg *cfg =3D &= ;smmu_domain->cfg;
       struct arm_smmu_device *smmu =3D = smmu_domain->smmu;
@@ -1177,12 +1177,13 @@ static void arm_smmu_init_context_bank(struct arm_s= mmu_domain *smmu_domain)
       dev_notice(smmu->dev, "d%= u: p2maddr 0x%"PRIpaddr"\n",
            &nb= sp;     smmu_domain->cfg.domain->domain_id, = p2maddr);

-       reg =3D (p2maddr & ((1ULL <<= ; 32) - 1));
-       writel_relaxed(reg, cb_base + ARM_SMM= U_CB_TTBR0_LO);
-       reg =3D (p2maddr >> 32);
+       reg64 =3D p2maddr;
+
       if (stage1)
-             &= nbsp; reg |=3D ARM_SMMU_CB_ASID(cfg) << TTBRn_HI_ASID_SHIFT;
-       writel_relaxed(reg, cb_base + ARM_SMM= U_CB_TTBR0_HI);
+             &= nbsp; reg64 |=3D (((uint64_t) (ARM_SMMU_CB_ASID(cfg) << TTBRn_HI= _ASID_SHIFT))
+             &= nbsp;          << 3= 2);
I think << should be aligned to the second '(' above.

Reviewe= d-by: Michal Orzel <michal.orz= el@amd.com>

With the Michal comment fixed.
Reviewed-by: Rahul Singh <ra= hul.singh@arm.com>

Regards,
Rahul

--_000_675F9B3117204AD3932A67D98FDDF7DEarmcom_-- From xen-devel-bounces@lists.xenproject.org Thu May 04 14:35:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 14:35:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529821.824650 (Exim 4.92) (envelope-from ) id 1pua3e-0000Fx-FR; Thu, 04 May 2023 14:35:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529821.824650; Thu, 04 May 2023 14:35:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pua3e-0000Fq-CZ; Thu, 04 May 2023 14:35:46 +0000 Received: by outflank-mailman (input) for mailman id 529821; Thu, 04 May 2023 14:35:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pua3c-0000FR-E6 for xen-devel@lists.xenproject.org; Thu, 04 May 2023 14:35:44 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2071.outbound.protection.outlook.com [40.107.7.71]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f2f891dc-ea88-11ed-b226-6b7b168915f2; Thu, 04 May 2023 16:35:43 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9367.eurprd04.prod.outlook.com (2603:10a6:102:2aa::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Thu, 4 May 2023 14:35:14 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6363.022; Thu, 4 May 2023 14:35:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f2f891dc-ea88-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RjPoXI9peTov5mIL79eiUWZc1JUtY2i2QVBYqiuu90q9TPd+nZAdUYwikXJOSU+pFGAtKqQFPC5Rr3MtuLkANtp0QoNvS7CY4wDvHgLkIWn6xvO6MFs/09Ptniz3dq7KA1DEKmelsfCPO2Bl0ovmyeUQ7gzlaQ/o02PrYQz9vK7DxTLk7/gExbkqEZZ18R29SqftqG2oEzQGdl/5ENeA4AsUsKriMXdD8IJrozB8GZXIuyIWcU8cQ9i2a2eclj8h7ttcVdBCvFgOO5gNoXu222IQ9j7AJEpxMrWQfJnV1Y+EMuBMSaDhDOpj1Am/la2UZcEQzjZ+qGgIyrf9EZv5mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dB4/rhLL5Ist8rEa+N+ZqWBPQdVApQyPPYPHHJTga2M=; b=XzkBiQYeoHkueUkEo3kTIZAdf/Ggh0K/TZmbKid/IJMYy6SNzmXxmFCg3LgQyWgT9mB21H8icy5Pz9UxMNbd7V/slYu+RC3viwCPHbVsSzgdUZ5Pf79MPS8amWWfOOHFYPGSB20nd6Fdo2pHF1OoTEoxWlVesfBXPBPMQDBGR/vvmb7/uNGhN4atTgJvZ15kpxe8nuq1hk7bIYvfRwBnRR6zZzCA8c+MfdLum5up3f+U9UUktw7fQ0MI9QuRNlQBCBaN6JTjjhOMyWaNFdfH44Ymrb14opUn5LCGPPt581GXnBsHEdAhcuPuH8VEsbVebEoPZxeUXoMu2jku+Gd4Dw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dB4/rhLL5Ist8rEa+N+ZqWBPQdVApQyPPYPHHJTga2M=; b=a5/OHWWAKR4pBPb4igWUG6XZ9kEDC17HKYF8G7QaJwWj7SjWhih8uBvhruirwNvrm8M1ve2k2B6N7sjOZoMbVH5Hya3LdW4etPMSlP/vKEjSvi3oiBpZ9gjgUwuQ4ke3W3n/b4TuHckYm4X3oRh80mag0Qe0hiQQdQEu+zZYBTZpkgvAeFZYg7d5JOfW0mMZbnUN11PHZW41sJhMMxZbkn9c6ZKb4R9HuAxOhC8o5WDMyTN28yMr2IqmDvjIXrD0Jm7aw6t5Bl3wvn8lAZn/QGrPVEjHWBNZyfbnmvrLQZs4Mu2p68bPJtxFxAmyL62YXWu4tRxUMZ5P1FESPQajnA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2864bf57-88cd-6fce-2d38-6f3a31abb440@suse.com> Date: Thu, 4 May 2023 16:35:12 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3 05/14 RESEND] xenpm: Change get-cpufreq-para output for internal Content-Language: en-US To: Jason Andryuk Cc: Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org References: <20230501193034.88575-1-jandryuk@gmail.com> <20230501193034.88575-6-jandryuk@gmail.com> From: Jan Beulich In-Reply-To: <20230501193034.88575-6-jandryuk@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0104.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9367:EE_ X-MS-Office365-Filtering-Correlation-Id: d99b4171-58ba-4a10-0e49-08db4cacc5ed X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: k4RBb+C4x0vBffGUfrekkmDs6ZdtCDyBKZYMCeFmiJGek00NoTfx6OBZVmZocdkE9JwGg2ROFeIKqOqHW8/GC+4VxQ8Yc4oYcB/h1rMp8Ix3owyZFmQhtLWPa+65O6wCjbdx4a2OIJmXLN/odCtEdCh7+4Q9GnCkD9uAnvYxWRajMCMInwm1t+8cuGEeDrxbFRMX2HVQphCvuehLvWEoGPHsD5x+oY1ZFY0hZiy1Aa2d0uHHTJC7DziX9hQvGBYHRMArcQ1Q1TMotigCWcfQCkkhYmTced7pdK06b0FpBYr6UmD5pndtQdbNBN+qQdH6sGpC6TshxycID1IY/HmnaNbdqBzqolwPEdFPoPKExQW+FSdsEuRUoSYCUXCgfeNeyMPSyWDLniQzWQ461idLzDvrnnyw8UuSsRnijRHJqApu1h4MRivs4hf81jQbsPlxRwjWoe2kLu69TLISU4DJZFaZLFIXsuBWIVre5d0R7CSXpxfrxzOZN9oVzenwaI4vsHc+oK6oLm2NNy3TcDc9VBP/8gOjs0HWRk67uvbiWXvanL87gvvPz2VgvazEyqsmRjkPRhQiqH4H5Np6CI42CiaAu5rmW7qRsx5eKnOYySioDOJAZ44kD2LtFLpTdg48lvakjLE4IaV8f6qY86pbpA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(376002)(366004)(346002)(396003)(136003)(451199021)(31696002)(8676002)(6916009)(316002)(86362001)(38100700002)(66476007)(66556008)(66946007)(478600001)(4326008)(54906003)(36756003)(41300700001)(8936002)(6486002)(2616005)(2906002)(5660300002)(6506007)(6512007)(31686004)(53546011)(26005)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Zk1sV21ROGtrdHp6WDJyNWdzN21waUVoVkpaYkxsS1lnQTF5cmt0bE14YzJm?= =?utf-8?B?c2VrVmt4cWIyK3o2YzhUUWtNTUFtSnNCUXJLMmZEWFdCTGxMWWNoMWFsTklP?= =?utf-8?B?ZkdjblBhYnQxK3ZhNXN6NTdWVGErRTh0ZmlpSDVCcUFCKzJYVFVpakRIbEIx?= =?utf-8?B?ZTk3YnFXQitHNm5zZ0t0WjFGQzFEcTN1eXNOQ0pqVGdSLzg4YWMrSEFkQTBx?= =?utf-8?B?bFBJdTZBRnBZYThHMG9uZ2tQYjE0V0x0d0NXNEZxWlNZdTQwMXc4YVBFV25E?= =?utf-8?B?V0Q5UnBaNnJCVXFXTDh2TWFodjRoaGpqa2k3cWI0T0Zza2hlRDZsc1FmbEhi?= =?utf-8?B?SE8yV3U1OUVIT1ErMTBqU29iUWtScW5qcEhsdEdtc1k4UDhlQVhkOWN0VFlJ?= =?utf-8?B?T0cwSXRZckJWdmkvM0pyNGtEYXNqWlZvdFV2TjNUM1hxVlVBVFhzN1FMbngw?= =?utf-8?B?c3EzcEw4ZGpFejNmNUtFWUZLc1VpWU9IZndoeXRUSVh3bTRhQmpseSt6cWFG?= =?utf-8?B?alZuL0dRYmlyU1ZxSWV0UFBpSlpGY0FpZnoxMEdjY2NneTIrdHBnNFpRQ3lW?= =?utf-8?B?bTZxQVVxbkhkRWlrT0gyYVdnb0xEZmw3bkVkN0JhU2dVQXJPOXNIK1h0VXkv?= =?utf-8?B?UGphUUcxYmxyVWFKeWdoZS9ybWNMMW5pb3prOUVqTnkzNjJBcnN2VTJqN3Ns?= =?utf-8?B?NTRQR1VQdVBIaUtOUVM4RU5DRXlvR2YzTkhINDE4bHBPYzJqNlNJeHkwSzhp?= =?utf-8?B?aU9QS1puaWJJSk5PV2hrckVzbFRNZk9GTjZyVzMyVEVTeEFJa1NZUkRNQ3Ar?= =?utf-8?B?VHpwUlBtTm1kV3N0WHBDS1UwWUNmNzRFNkRZV0J5ZFpIU2lsdFFHWW1LYUE2?= =?utf-8?B?Y2VSS0g5bHdDcnd1UFdvYXlsMWFyM3Q3Y1dhaEJIcW5NVnppWjFhRzIwOWpV?= =?utf-8?B?bVlXckpKSTVzQVdvM2ErQU4yaDFWM0tPZFR6T0JSZ2s5VmtHSW5FeGcvMlda?= =?utf-8?B?V21GMkZQNndwYVRaSU10NTFGSXRtR0d6SGd6TUpSMEVmK1dQcWRlMlpKZGND?= =?utf-8?B?N3JyeUUxM1hxK1M0WE4rQWF3ajVYNlpNRkdLVnBuTzZRTXNoR2VFYVd1RmdS?= =?utf-8?B?TzcxeWpSZDkyWjUyZVFxS2VCUy9pRTgzaWNDT3JNNSthaXBRb1FLTXVoMkdx?= =?utf-8?B?REx2M3NUU1IxYkw0Q04yQldpSWFXVVRscmdOMHNBL3RiSnNXekltZ3p0bStL?= =?utf-8?B?RitlNnBTcGVDTGtnR1NZMHFOaGd1NVdEOFRiUmEwL0VvcUVwTkJjdXFHYWVa?= =?utf-8?B?ajZydWIwTkMrYkZSMjl4QXhIak9WRjhtQnYzUDVzbDBwMlNVRDFDeUU1K3VM?= =?utf-8?B?YVZVR0Q0bGVCeFYwOXJLV0R0cDN5WEZXVkVUb1Vkd1BOSTBzS044N0FWS3pW?= =?utf-8?B?WnVyOVg5QVhyZWs4cmI1anh2OStwVXFMaDVHZzVGbWhQOUYvejFTZC93RXBs?= =?utf-8?B?aHgwZDdqS2I1K24yWktvZXlHV3NoWUIveUY0WE42bnRGanhMcTdaU2lzaWFv?= =?utf-8?B?NDg0YUFjMU9uMnFEenNlckZBaUppTzVaTG1kMFFwNmdNaGlCRThKVUltWnUr?= =?utf-8?B?TkxkTWpNTG1oWE1NV0l1c2hvNmlNRHNUOURTbGhEVWRCcEUxOVgxME8xNlNW?= =?utf-8?B?TSticTZHekNVVFZKSVdrenVEMEdlUjNjMWkrUFUxMEhqRVdXWVAzRDREZVdq?= =?utf-8?B?NWpFNklzQmJDVjUrVkl3VFIrMmVwbHkxdFMwZWwrR1JQeVNRcEp2aWF0QUcx?= =?utf-8?B?NnN5bWhVRFNIWW51LzdULzdHaXFqK1Z6aHdNMklyazdjcVRuNSttdXFubFgr?= =?utf-8?B?bTEweFhMbkkvMjdvMTU3N3pwSWIzVHdodFNXVmVJM3doN1VEaHl3SDBKNGkw?= =?utf-8?B?ZUQyYnJiTGo3VkM5aUVXNHZnbEYxM3Q5RXRNc2MwdzEyOFVSRW9HZWRyUmNL?= =?utf-8?B?UkZ3VjVucUJtay9uRERqZkc3eEFwY1BZSW1vNHJySTFMbytvNFJTTXZwNi92?= =?utf-8?B?enNuQjJidzc0cFRaVGM4eEpMckFjQkpRQnBXRmtiTkZRamYxWDJLWTZBcFJi?= =?utf-8?Q?kGEd2rFOfl+yHXNUXcBlwXXh/?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d99b4171-58ba-4a10-0e49-08db4cacc5ed X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 14:35:14.3773 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NufDsvLtqJR/cCqnK6jFtVOqMu8u+9dWjfN++GSIA1iW48hyTOObSJ/Wk/GVfiTMhhqM79k1FxbQMwL6+djkRA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9367 On 01.05.2023 21:30, Jason Andryuk wrote: > When using HWP, some of the returned data is not applicable. In that > case, we should just omit it to avoid confusing the user. So switch to > printing the base and turbo frequencies since those are relevant to HWP. > Similarly, stop printing the CPU frequencies since those do not apply. It vaguely feels like I have asked this before: Can you point me at a place in the SDM where it is said that CPUID 0x16's "Maximum Frequency" is the turbo frequency? Without such a reference I feel a little uneasy with ... > @@ -720,10 +721,15 @@ static void print_cpufreq_para(int cpuid, struct xc_get_cpufreq_para *p_cpufreq) > printf(" %d", p_cpufreq->affected_cpus[i]); > printf("\n"); > > - printf("cpuinfo frequency : max [%u] min [%u] cur [%u]\n", > - p_cpufreq->cpuinfo_max_freq, > - p_cpufreq->cpuinfo_min_freq, > - p_cpufreq->cpuinfo_cur_freq); > + if ( internal ) > + printf("cpuinfo frequency : base [%u] turbo [%u]\n", > + p_cpufreq->cpuinfo_min_freq, > + p_cpufreq->cpuinfo_max_freq); ... calling it "turbo" (and not "max") here. Jan > + else > + printf("cpuinfo frequency : max [%u] min [%u] cur [%u]\n", > + p_cpufreq->cpuinfo_max_freq, > + p_cpufreq->cpuinfo_min_freq, > + p_cpufreq->cpuinfo_cur_freq); > > printf("scaling_driver : %s\n", p_cpufreq->scaling_driver); > From xen-devel-bounces@lists.xenproject.org Thu May 04 14:50:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 14:50:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529825.824659 (Exim 4.92) (envelope-from ) id 1puaHE-00020t-L9; Thu, 04 May 2023 14:49:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529825.824659; Thu, 04 May 2023 14:49:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puaHE-00020m-IZ; Thu, 04 May 2023 14:49:48 +0000 Received: by outflank-mailman (input) for mailman id 529825; Thu, 04 May 2023 14:49:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puaHD-00020b-10 for xen-devel@lists.xenproject.org; Thu, 04 May 2023 14:49:47 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e7d01f25-ea8a-11ed-b226-6b7b168915f2; Thu, 04 May 2023 16:49:45 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e7d01f25-ea8a-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683211785; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=xqxetoyMuTWWLtSRIRr5hMNplwRXRxZMX6BsncNBeUw=; b=OgdmOvzSRIni0ODwPXnPyeHgGGIEiSeQG95HrhkRN6ulyxOlRzT4Ya9l KRTx6CHZqPZokC88Ac58Gev+Rf0uYyGE3zSVa58EC5Vqee8vjvIjWBMlD pmwnLdgcjaMQB3rOTgHpaRPRFloeOyEXtPnGl/5JOuuvnmygjzN+qZNJb o=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 106636820 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:06/cj6i7XSutAaAX/mgEg2MKX161SxAKZh0ujC45NGQN5FlHY01je htvCGCFP6uDMDf8Kt4ibd7joRkG7MSBmNFnGQI4pCo0EHgb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWj0N8klgZmP6sT4QeCzyB94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQnNQkfUCKZl96oxeO7E9Ruut45K+XkadZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJYw1MYH49tL7Aan3XejtEqFWTtOwv7nLa1gBZ27nxKtvFPNeNQK25m27B/ jyYpDqpWEly2Nq3z2Tf6020hd70uhj9Aa4vMufmr9pbnwjGroAUIEJPDgbqyRWjsWahX/pPJ kpS/TAhxYAp71CiRNT5Wxy+oVaHswQaVt4WFPc1gCmE0qfO6hyVLnQFRDVGLtchsaceRyEu1 1KPt8PkA3poqrL9YWKQ8PKYoC2/PQARLHQefmkUQA0d+d7hrYovyBXVQb5LEqS4k9n0EjHY2 C2RoW41gLB7sCIQ//zlpxad2Wvq/8WXCFdvvW07Q15J8CtGebe3Wb6y+WTF6KdAdbubckObu 1QLzp32AP81MX2dqMCcaLxTTOrxvqzVb2K0bU1HRMd4qWn0k5K3VcUJuWwleh80WioRUWWxC HI/rz+983O60JGCSaZsK7y8BM0xpUQLPYS0D6uEBjaij3UYSeNmwM2NTRTKt4wVuBJw+ZzTw L/CGSpWMV4UCL580B29TPoH3Lkgy0gWnD2DHsmnl03/ieXPORZ5rIs43KamNLhlvMtoXi2Mm zqgCyd640oGC7CvCsUm2YUSMUoLPRAGOHwCkOQOLrTrClM/SAkc5wr5netJl3pNw/4EyY8lP xiVBidl9bYIrSebcV/SNCo4N9sCn/9X9BoGAMDlBn7ws1BLXGplxP53m0cfFVX/yNFe8A== IronPort-HdrOrdr: A9a23:Y6K8Fq5ZXzBy4PPilQPXwDLXdLJyesId70hD6qkQc3FomwKj9/ xG/c5rsSMc7Qx6ZJhOo7+90cW7L080lqQFhLX5X43SPzUO0VHARO1fBOPZqAEIcBeOlNK1u5 0AT0B/YueAcGSTj6zBkXWF+wBL+qj5zEiq792usUuEVWtRGsZdB58SMHfhLqVxLjM2Y6YRJd 6nyedsgSGvQngTZtTTPAh+YwCSz+e77a4PeHQ9dmYa1DU= X-Talos-CUID: 9a23:NGFFx24OkvYl+VFD6tssy1MtCP4XaG3h0nKBIxaFC1pzUrq5RgrF X-Talos-MUID: 9a23:UhBTyAp6WsQ39osmVTIezzc8bt5X+6efM2c2l8wqhu/ea3VUCijI2Q== X-IronPort-AV: E=Sophos;i="5.99,249,1677560400"; d="scan'208";a="106636820" Date: Thu, 4 May 2023 15:49:27 +0100 From: Anthony PERARD To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , "Andrew Cooper" , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [PATCH v2 1/2] build: don't export building_out_of_srctree Message-ID: <30ef6706-5c01-441c-9c5e-08e578019166@perard> References: <2e3c8f9d-8007-638a-c88b-21ad2783d8d3@suse.com> <9e63c6e5-11cb-9f0e-b33e-0247b17e3785@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <9e63c6e5-11cb-9f0e-b33e-0247b17e3785@suse.com> On Wed, Mar 29, 2023 at 12:22:16PM +0200, Jan Beulich wrote: > I don't view a variable of this name as suitable for exporting, the more We could rename it. > that it carries entirely redundant information. The reasons for its The patch replace building_out_of_srctree with abs_objtree and abs_srctree which also carries redundant informations. abs_objtree can probably be replaced by $(CURDIR), abs_srctree can be recalculated from $(srctree). > introduction in Linux commit 051f278e9d81 ("kbuild: replace > KBUILD_SRCTREE with boolean building_out_of_srctree") also don't apply > to us. Ditch exporting of the variable, replacing uses suitably. > > Signed-off-by: Jan Beulich This patch feels like obfuscation of the intended test. Instead of reading a test for "out_of_tree", we now have to guess why the two paths are been compared. Anyway, there isn't that many use outside of the main Makefile, so I guess the patch is kind of ok: Reviewed-by: Anthony PERARD > For further reasons (besides the similar redundancy aspect) exporting > VPATH looks also suspicious: Its name being all uppercase makes it a > "non application private" variable, i.e. it or its (pre-existing) value > may have a purpose/use elsewhere. And exporting it looks to be easily This sounds like you don't know what VPATH is for, but I'm pretty sure you do. If there's an pre-existing value, we just ignore it. If VPATH is used by a program that our Makefile used and that program is intended to be used by build system then that a bug in that program for not knowing about makes' VPATH. So I don't think we need to worried about it been exported. > avoidable: Instead of setting it in xen/Makefile, it looks like it could > be set in xen/scripts/Kbuild.include. Thoughts? I'd rather not make that change unless there's a real issue with exporting VPATH. We are more likely to introduce a bug than to avoid one. Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu May 04 14:53:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 14:53:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529828.824670 (Exim 4.92) (envelope-from ) id 1puaKH-0003RB-4J; Thu, 04 May 2023 14:52:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529828.824670; Thu, 04 May 2023 14:52:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puaKH-0003R4-02; Thu, 04 May 2023 14:52:57 +0000 Received: by outflank-mailman (input) for mailman id 529828; Thu, 04 May 2023 14:52:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puaKF-0003Qw-UA for xen-devel@lists.xenproject.org; Thu, 04 May 2023 14:52:55 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 57f8dd66-ea8b-11ed-8611-37d641c3527e; Thu, 04 May 2023 16:52:53 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57f8dd66-ea8b-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683211973; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=1+g/k07CXD/gTtcKxuOaPCrh5JfZwNTbDY+vcD/fIfQ=; b=Tdj/cqwdkOpKttvQXSCMCNwqSMSgDnmfEqYYQcP0XVrGnxQ5HC438C7w 473oWEyQszQ6f4htO1qVANC2K6lqMdVgGfYnVeZLMyILrAIwOwbpP9/vj GTEofndyZVynLsxfEyPEoOJI/6S0tJjSS1QzqFUmy0rGY1eojtY1inaac I=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 107896292 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:W7jMc6+hxqWKOb0YEarfDrUDq36TJUtcMsCJ2f8bNWPcYEJGY0x3y 2EcDDzXb67ZazOneYh+b4jjoxtUvZCAm9JlSFNurSg8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kI+1BjOkGlA5AdmOKgX5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDkkNq Oc5AgImXiqT2dqu3peYEu9ijJ8KeZyD0IM34hmMzBncBPciB5vCX7/L9ZlT2zJYasJmRKiEI ZBDMHw2MUqGOkcUUrsUIMtWcOOAj3/jczpeuRSNqLA++WT7xw1tyrn9dtHSf7RmQO0MxhnI9 zycrj6R7hcyGO3E1yOc3niVg9CSoAHwRbIoT5e736s/6LGU7jNKU0BHPbehmtG7gEOjX9NUK 2QP5zEj66M18SSDXtT7GhG1vnOAlhodQMZLVf037hmXzajZ6BrfAXILJhZDddgnuckeVTEsk FiTkLvBHidzubeYTXac8La8rj6oPyURa2gYakcsUg8t89Tl5oYpgXrnR85uCqevgvXpGDv7x HaBqy1WulkIpZdVjePhpwmB2m/y4MGTFWbZ+zk7QErmsxhYTryOV7a4t2DD89NjdICXRAKo6 S1sd9el0AweMX2cvHXTEL5VRev5uKnt3C702gA2QcR4n9i50zv6JN0LvmkjTKt8GpxcEQIFd nM/ru+4CHV7GHKxJZF6bIuqYyjB5fixTI+1Phw4gzcnX3SQSONk1Hs0DaJo9zqx+HXAaIlmU XthTe6iDGwBFYNsxyesSuEW3NcDn35unjqPHcmjl0v2jNJygUKopUotagPSPojVEovdyOkqz zqvH5TTkEgOOAEPSiLW7ZQSPTg3EJTPPriv85Y/XrfacmJb9JQJV6e5LUUJJ9Y0wMy4V47go hmAZ6Ov4ACj3Sefd1/RNRiOqtrHBP5CkJ7yBgR0VX7A5pTpSd3HAHs3H3fvQYQayQ== IronPort-HdrOrdr: A9a23:sGUI4qFTmUGMtbzqpLqEHseALOsnbusQ8zAXPiBKJCC9vPb5qy nOpoV86faQslwssR4b9uxoVJPvfZqYz+8W3WBzB8bEYOCFghrKEGgK1+KLrwEIWReOk9K1vZ 0KT0EUMqyVMbEVt6fHCAnTKade/DGEmprY+9s3GR1WPHBXg6IL1XYINu6CeHcGPTWvnfACZe ehDswsnUvZRV0nKv6VK1MiROb5q9jChPvdEGI7705O0nj0sduwgoSKaSSl4g== X-Talos-CUID: =?us-ascii?q?9a23=3AxNJZNWlD+lSdNTL+/9cQJ5HjeBLXOT6A11b6EWS?= =?us-ascii?q?IM3Y3cKWLbHzI/q1uyOM7zg=3D=3D?= X-Talos-MUID: 9a23:CLg+PQuAtaHTuSfn8c2nqAA5Kt5xz66XDX9QrLcNpvm+bgZzEmLI X-IronPort-AV: E=Sophos;i="5.99,249,1677560400"; d="scan'208";a="107896292" Date: Thu, 4 May 2023 15:52:41 +0100 From: Anthony PERARD To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , "Andrew Cooper" , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [PATCH v2 2/2] build: omit "source" symlink when building hypervisor in-tree Message-ID: <9febc330-9586-4810-880d-f694a2b07b0d@perard> References: <2e3c8f9d-8007-638a-c88b-21ad2783d8d3@suse.com> <0d073a56-b3a0-a64d-6bf4-851c660c6155@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <0d073a56-b3a0-a64d-6bf4-851c660c6155@suse.com> On Wed, Mar 29, 2023 at 12:23:37PM +0200, Jan Beulich wrote: > This symlink is getting in the way of using e.g. "find" on the xen/ > subtree, and it isn't really needed when not building out-of-tree: > The one use that there was can easily be avoided. > > Signed-off-by: Jan Beulich Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu May 04 14:58:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 14:58:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529831.824679 (Exim 4.92) (envelope-from ) id 1puaPT-00046D-Lh; Thu, 04 May 2023 14:58:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529831.824679; Thu, 04 May 2023 14:58:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puaPT-000466-J5; Thu, 04 May 2023 14:58:19 +0000 Received: by outflank-mailman (input) for mailman id 529831; Thu, 04 May 2023 14:58:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puaPS-000460-6Y for xen-devel@lists.xenproject.org; Thu, 04 May 2023 14:58:18 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on20610.outbound.protection.outlook.com [2a01:111:f400:fe16::610]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 19c9d1f3-ea8c-11ed-b226-6b7b168915f2; Thu, 04 May 2023 16:58:17 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7862.eurprd04.prod.outlook.com (2603:10a6:20b:2a1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Thu, 4 May 2023 14:58:14 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6363.022; Thu, 4 May 2023 14:58:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 19c9d1f3-ea8c-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ip5WEMsvhoegzjaaoFKKD8bBekZoUcujBWmMfQy1g+ZHqJ5wxYqT3KJMJldbM/1l+rN59S1IiGNEAJiyce19IWLxozfm8chAxaZSc2luUScLX4mf19vKgf1gh1h97ZycW9Cn6WdDmVCcQ/+GYGQohCSy6Vl8p00Rl2Wy+MEzDGz0vDhJw+Hcyy4UM6i1asqgs+SWAKiVFeuvYRvbwPJ1lGgM3PflwvJPw3W5AnUeR0sWQpfSRpNqFIYcU/XIWVFzzqWUGhNnr47WS0uBzDnOI6LIzGjIffhGSippAnSm1VarCqwsQvcuC+T5E9isGBmWIhkGYb5P6RqvI23FTK0N1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pHns2eARKQnQVqrbuS0ItzjVrOdmKr1yaovuxzQ1684=; b=Ud6SN4gJCs+qN0TSG9SASeoalEyOMIbV7EWODlluUUAyOId0IfvlZWWJhkrN36zcjgRxLxMwvYQo6EeMCKX27sNg+Bft1t1I0h3RnA3loJUoG/W9InjqodGCxv46edieoITC0RhQMhDMGDaYWidcgfLPmylFjY+V01/JQSi0psaAOb+cnlIvfOGXqpIHZZU+aJjJw20LaroqJTCuZfcjkiNnGPs/mxsK7CcdFrkGuAootlGE7t1lJwCQFElpT+2J5lWINgEVwVcZ2nTjeg4tKUypwygYcPhSOyleAYBtdigRReK6i5odsn6Vg3u/kTFlwjXFHIPukj3vOMc9lZI3VQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pHns2eARKQnQVqrbuS0ItzjVrOdmKr1yaovuxzQ1684=; b=mz0Mn1EmVPG55MBs+EjBs5e5SDRcIIL9sz/HBgurGNMISPNYlbV549Uoan5gT+hn+5MtUT0ivmavSQeljfnxiwKX/LUghvz2kC1yDOn7p/UQb6fzQbHsutKA1ywkzat2SMClfb/ne+KwChW6TPJdQ2C76i8DySB6K/JeMMTgX0QP3QjvZX9esOWeqaCTx0/D1wjzZYpM0WFVvHoPVoeLj8dtF1ksGT10MHQGxG1jF2Bqf57VIDxNP6SnxIMIE/7x9tHH0idA28+kF95pvsFRrbMa099brS3cLZScyC3gb1d9PqRN//2RoCgZfaONE4J53X2oC2A1a8BIT8zed3Lu5g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <85820299-1a45-652d-283b-cca89edcf3b2@suse.com> Date: Thu, 4 May 2023 16:58:12 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v2 1/2] build: don't export building_out_of_srctree Content-Language: en-US To: Anthony PERARD Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <2e3c8f9d-8007-638a-c88b-21ad2783d8d3@suse.com> <9e63c6e5-11cb-9f0e-b33e-0247b17e3785@suse.com> <30ef6706-5c01-441c-9c5e-08e578019166@perard> From: Jan Beulich In-Reply-To: <30ef6706-5c01-441c-9c5e-08e578019166@perard> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0073.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7862:EE_ X-MS-Office365-Filtering-Correlation-Id: 27a7c445-87b7-4ef9-9640-08db4caffc93 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: weoX7mbyrYQfZ5jyynF1/ndma/cGqtBJN+D4pr8tJUvnoa/fdC/+wHjfMnRox/TCxlcvHay8GdYPLBBSoE2h2JocCGTcHIBLnD2qI2mTh4lJ+h5YTlybBSdklEU/R8ZpDTNhQLay1FtCUIYQ1kZydCQcdKAZM/nHOZjyZ3L7uuN7+vhNLcpMt7HTbTbN4/7lzsJYs8lOZVhk5JY++a4HyUdm4+MRLZlm6noGxgF1f4PCE/kVo3pL/WOyeUWBk4HckOd7WZfJZ6gS5kRobUieTpLaRRImcWBe7O9IX+Th8g0i6IjL1/jvSJHLvF00rbgdjIBslL2q7+5bVluGdRI7rydjOvkQK207viY77WnJxdmqsXHazypSG7OAneKUL6ekNXxhTdvxeJN7d4qECjqxkLtH1aUM5Lamel9XIQfDYKGb30EvY5wcTJuovDn0Dgk/VMTTuJ5aQOHakmPBO2HMzumVzjoTyJN3dm5h+YA18BJzAbSd0B+i1P8cHFMn1q/2yAZ8n/M9Njb9a+J1Cxt8GU4jBcy3FISaPupHSse3dZ1RlwoORPf0j/zkHUj0VdL16+GCdULI2dOqT4iuGGNI91eI6d6E/okGXhaViTiM8/Tc7v5l+25fiCc70ZWgiSM/DlEdn4HFAuYnsSbGt5xUEw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(39860400002)(376002)(396003)(136003)(366004)(451199021)(5660300002)(8676002)(478600001)(38100700002)(8936002)(54906003)(2616005)(6916009)(6506007)(31696002)(86362001)(66556008)(36756003)(66946007)(66476007)(31686004)(6486002)(4326008)(83380400001)(6512007)(26005)(186003)(2906002)(316002)(53546011)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SWFMUnV1b1g1cWg2UlVIWmp2VHJHOUFsa2xkcHJyYzdCK2xqaWpmN28xL1pu?= =?utf-8?B?dEpIQUpjNEdnOHgxeldmM1pRVW1kUnJWZ09sdnpkMmRCcGN2TG9mMUhOcEti?= =?utf-8?B?OHdVU3RWTDVveC95RWUwdmFsZ1BGNVUwUXdXYWtYK0Fqcmt6NENVMmRnajhq?= =?utf-8?B?alJUYk1aUERTYXh2M1ZKOHlld1Z2WkNkYUJucFlpUEhkR3BHaUNlUVZVOWVa?= =?utf-8?B?aTdRZ2R2TGQxbDdxK0p5UnorektRTHJRYlQ3SnhjeUNIN2IwZWtjeGdxWHow?= =?utf-8?B?NUh4Um1Qc3B6aHVicGRzTDNzdElSOWtDTWNrNGZod040Z0Z0b0ZDM2VTcFRU?= =?utf-8?B?NWlEUzJGa0dyeGhOeEtpemVUdUZLTXViWnB2c0dKMStHSHpXOGljY0t3QTNk?= =?utf-8?B?SEJZVDk0L1B3U3pWek1TSDByRW0vVFNuTFFwdURXU3hyd2JKWThoaXVBZzNS?= =?utf-8?B?bGI2RGtVNGVYeHdMWlR5MHNwdS9hbzZzY3I0TEZlZjNGRHkwMVlXWnlHRTBE?= =?utf-8?B?OUhUNmtrSXA5cVFLV2VvNE93RjNKMHhCK0hQWE91a3pDT3FXdnhuSHpqUjFI?= =?utf-8?B?bkN4WjQxNXBNeWRDRXVta295ZklJRDRDN3NZTTJPWEphV0dVS042eEtPQ1Jq?= =?utf-8?B?bW0wM05xM0xCUGtiL0x5ZUJjTWQ1d25qNlB5VnZIWC9sYy9aQktpbWdGZVdi?= =?utf-8?B?NjJESm5EYXF5bFQycnlEa1ZKWFZGL2c3YmVGQ3RJZU1oaTgwQXRSdDRvVDVo?= =?utf-8?B?WEhtZnViUGFhdExzYnFRZmp6bVNJRzdnNFFIbnRPa0hVZTN5aTZHR3FNbzJk?= =?utf-8?B?d2NaRFJlaE9GZit6LzN2dkZMSEl4bSt5eVVCRGZ6UlMzQ2R3SWRUNGF1L2tX?= =?utf-8?B?SnkxbVpldlNtazhnT1BuNmRycU1YaXBXSkYwMmpMSTZPTFdZZWJxcjM5Zk5B?= =?utf-8?B?S2tpMUw5bnpKYmFacUp1cDRnQVFtWThlbld0ZGR6c3RzOWVRMzZnV1FzNFlr?= =?utf-8?B?cTVUano4dXc0bW9sdEFockhLd0J4ak9kQUxkR3FEK1pWMUtVZ2VTV24wNmxN?= =?utf-8?B?RDM5RHE5ckk4VGplbjREZENvdzcwYzc1bXV3YVdvWlBYMUNVUUxaWFJlcVg0?= =?utf-8?B?NXpRVGo2SlVFanlBR3o1dXY3dWdUNjlEeFlZYWY1UWhuTTFXK0hiYkVEM01a?= =?utf-8?B?dTN1OVBXTmU0eWgrekZKeGRGdFFpK2c4SVl4OHZOUGY4RjFheXFCNi9jcGNC?= =?utf-8?B?RENvcVlEblc3cU5lTFJhaWxNWk1CVTAvRVdkZGRndGM1UHkxNDNRSW1IbWQr?= =?utf-8?B?eUF4d2gydVBGcUJTcW1YbWRmV05jU1NQR3NZckREV0pNcjEwZUx4eG95Vmhh?= =?utf-8?B?eVNlVlRxanlkdktqeEtoR3pWdWdjNzBCVEJxa2N3M1RpbjlGZjhsRk5rajVW?= =?utf-8?B?M2x0dWhnOHdqYmRaTE1Rd3hkaUttZXhMM3o3V2hJNzhQN3AyTTM3OWJDNDc4?= =?utf-8?B?cG5qTndpWWVXVWgzaDhyK095czZEWkEwYThINyt4bjc1WHJzQm5DRGRHZFRn?= =?utf-8?B?VDRSVTZyT0M1ajMvVGoyVEM0c2xONUEvUGpGelZFYjMvY2Z6ekNRNEppeXNs?= =?utf-8?B?TXZTYWs1STNEdzR6c3VqMm1vdnh5TEZuRUdOUkxOVHhzT0ZTaWZVcG10Y3Vx?= =?utf-8?B?S3Fodm1DOTRMWE51NHFpc3pSakZOLzVBSk1weEZWRmtuNUx2akN3UFIxQ0F6?= =?utf-8?B?WHpkM2NPenUySU1ZZWNZeFJwQll2Q2lyMGxsZUgvdzlkN1dVY08vTHE1OUtI?= =?utf-8?B?VmloMy8zdmowQ3VsSDJsVi80MVRPYUo2VkNEVDdJOUF4RlljREZ1aG42U0Vu?= =?utf-8?B?R0FqWW1zY21qa3JxMGF2ZlNJM29MU0tNQXltd3dNeVF3SXMzbGJjZ0ppbTd0?= =?utf-8?B?ZVBGeWlMZ1F5TS9sWURnTm90TFdNU0ZxTVpkK2dUVEV6NjZvNDlMN0taS2J3?= =?utf-8?B?TDlYSXBjWno0ZzFKbml5NmlUNDNnaEZmdDRPa2VSa0VOclBySmFoeHA0OU52?= =?utf-8?B?Tk0rU2hGbkNGZDEzODQrTDBDTGw4ZC9vNlRMMk1JWHVXYy96dy9xcTJpYnpn?= =?utf-8?Q?PH0LfQ5XMOsCqEP1qQoqBAwO9?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 27a7c445-87b7-4ef9-9640-08db4caffc93 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 14:58:14.4854 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: p1/qwZ6jpyws3BNJUtnAqd2UhnCPHMWFFXLaqJHkLV6xqWnaFnrKNCHkjPZP0LLpfPUXlr8MawJqmYX+hV0IyA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7862 On 04.05.2023 16:49, Anthony PERARD wrote: > On Wed, Mar 29, 2023 at 12:22:16PM +0200, Jan Beulich wrote: >> I don't view a variable of this name as suitable for exporting, the more > > We could rename it. > >> that it carries entirely redundant information. The reasons for its > > The patch replace building_out_of_srctree with abs_objtree and > abs_srctree which also carries redundant informations. abs_objtree can > probably be replaced by $(CURDIR), abs_srctree can be > recalculated from $(srctree). > >> introduction in Linux commit 051f278e9d81 ("kbuild: replace >> KBUILD_SRCTREE with boolean building_out_of_srctree") also don't apply >> to us. Ditch exporting of the variable, replacing uses suitably. >> >> Signed-off-by: Jan Beulich > > This patch feels like obfuscation of the intended test. Instead of > reading a test for "out_of_tree", we now have to guess why the two paths > are been compared. Hmm, it's quite the other way around for me: I view the variable as obfuscating, as it hides what it actually expresses (or better based on what properties it is actually set). > Anyway, there isn't that many use outside of the main Makefile, so I > guess the patch is kind of ok: > Reviewed-by: Anthony PERARD Thanks. >> For further reasons (besides the similar redundancy aspect) exporting >> VPATH looks also suspicious: Its name being all uppercase makes it a >> "non application private" variable, i.e. it or its (pre-existing) value >> may have a purpose/use elsewhere. And exporting it looks to be easily > > This sounds like you don't know what VPATH is for, but I'm pretty sure > you do. If there's an pre-existing value, we just ignore it. If VPATH is > used by a program that our Makefile used and that program is intended to > be used by build system then that a bug in that program for not knowing > about makes' VPATH. So I don't think we need to worried about it been > exported. We may use programs from our build system which aren't aware they might be used that way. No matter that I know what VPATH is for, I consider its name to violate the shell spec. >> avoidable: Instead of setting it in xen/Makefile, it looks like it could >> be set in xen/scripts/Kbuild.include. Thoughts? > > I'd rather not make that change unless there's a real issue with > exporting VPATH. We are more likely to introduce a bug than to avoid > one. Well, okay, it's surely (hopefully) a highly theoretical consideration anyway. Jan From xen-devel-bounces@lists.xenproject.org Thu May 04 16:00:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 16:00:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529836.824690 (Exim 4.92) (envelope-from ) id 1pubMt-0002js-7T; Thu, 04 May 2023 15:59:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529836.824690; Thu, 04 May 2023 15:59:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pubMt-0002jl-4X; Thu, 04 May 2023 15:59:43 +0000 Received: by outflank-mailman (input) for mailman id 529836; Thu, 04 May 2023 15:59:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pubMs-0002jd-37 for xen-devel@lists.xenproject.org; Thu, 04 May 2023 15:59:42 +0000 Received: from mail179-5.suw41.mandrillapp.com (mail179-5.suw41.mandrillapp.com [198.2.179.5]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id abfc2e99-ea94-11ed-8611-37d641c3527e; Thu, 04 May 2023 17:59:38 +0200 (CEST) Received: from pmta12.mandrill.prod.suw01.rsglab.com (localhost [127.0.0.1]) by mail179-5.suw41.mandrillapp.com (Mailchimp) with ESMTP id 4QBz613lkczG0CJtH for ; Thu, 4 May 2023 15:59:37 +0000 (GMT) Received: from [37.26.189.201] by mandrillapp.com id 89c15dbd916c406d8613d1770bab4013; Thu, 04 May 2023 15:59:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: abfc2e99-ea94-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.fr; s=mandrill; t=1683215977; x=1683476477; i=yann.dirson@vates.fr; bh=eLQjcR+VoTsYw7DiK+4fWqcd9Pnvu4j+lbS0pP71BjM=; h=From:Subject:Message-Id:To:Cc:References:In-Reply-To:Feedback-ID: Date:MIME-Version:Content-Type:Content-Transfer-Encoding:CC:Date: Subject:From; b=mNVDxbBRYGjgYdfHwOxyufsixN4lEv/t4B23lWarB7sRI22grC1upb9KQ75xCfC5R wEaAlu9q7w1ZQPwCPGHJkKbd8sd982Tv7IfVVuIWik0X75GmuTwtOu084nnYnCASjE jAylRwOuaR9IWsTM+N/nTUy9LJPfvypWz8gnmNXA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; i=@mandrillapp.com; q=dns/txt; s=mandrill; t=1683215977; h=From : Subject : Message-Id : To : Cc : References : In-Reply-To : Date : MIME-Version : Content-Type : Content-Transfer-Encoding : From : Subject : Date : X-Mandrill-User : List-Unsubscribe; bh=eLQjcR+VoTsYw7DiK+4fWqcd9Pnvu4j+lbS0pP71BjM=; b=pS6x3twT9m+jOK0BmMcIyQy6hyN84tmxRble+tp7zQc7rH0HB3hshTe9ZQOcxPc4x7iB9u IQG0P/4dlJr6hoUadFdcrWNbEuAppaGZBIHBnZYYRPq6khhOK803LI4hPpRT4YInu68u4t2k vWLfIfURuf8qTO9Z8AWaW0O7jWKJM= From: Yann Dirson Subject: =?utf-8?Q?Re:=20xenstored:=20EACCESS=20error=20accessing=20control/feature-balloon=201?= X-Bm-Disclaimer: Yes X-Bm-Milter-Handled: 9664e26d-c55d-4176-ac64-680cfb7c5564 X-Bm-Transport-Timestamp: 1683215968933 Message-Id: To: zithro , xen-devel@lists.xenproject.org Cc: Juergen Gross , =?utf-8?Q?Edwin=20T=C3=B6r=C3=B6k?= , Julien Grall , Andrew Cooper References: <3065c524-07c7-6458-ff4c-ba68ff78c946@rabbit.lu> <474b531f-2067-a5d4-8b01-5b8ef1f7061d@citrix.com> <678df1ff-df18-b063-eda3-2a1aed6d40f8@vates.fr> <50bf6b82-965b-d17c-7c5a-49c703991504@rabbit.lu> In-Reply-To: <50bf6b82-965b-d17c-7c5a-49c703991504@rabbit.lu> X-Native-Encoded: 1 X-Report-Abuse: =?UTF-8?Q?Please=20forward=20a=20copy=20of=20this=20message,=20including=20all=20headers,=20to=20abuse@mandrill.com.=20You=20can=20also=20report=20abuse=20here:=20https://mandrillapp.com/contact/abuse=3Fid=3D30504962.89c15dbd916c406d8613d1770bab4013?= X-Mandrill-User: md_30504962 Feedback-ID: 30504962:30504962.20230504:md Date: Thu, 04 May 2023 15:59:37 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 5/4/23 15:58, zithro wrote: > Hi, > > [ snipped for brevity, report summary: > XAPI daemon in domU tries to write to a non-existent xenstore node in > a non-XAPI dom0 ] > > On 12 Apr 2023 18:41, Yann Dirson wrote: >> Is there anything besides XAPI using this node, or the other data >> published by xe-daemon? > > On my vanilla Xen (ie. non-XAPI), I have no node about "balloon"-ing > in xenstore (either dom0 or domU nodes, but I'm not using ballooning > in both). > >> Maybe the original issue is just that there is no reason to have >> xe-guest-utilities installed in this setup? > > That's what I thought as I'm not using XAPI, so maybe the problem > should only be addressed to the truenas team ? I posted on their forum > but got no answer. > I killed the 'xe-daemon' in both setups without loss of functionality. > > My wild guess is that 'xe-daemon', 'xe-update-guest-attrs' and all > 'xenstore* commands' are leftovers from when Xen was working as a dom0 > under FreeBSD (why would a *domU* have them ?). That would not be correct: xenstore* are useful in guests, should you want to read/write to the XenStore manually or from scripts; xe-deamon and xe-update-guest-attrs both come from xe-guest-utilities 6.x, which is really a domU tool as well, but is there to support XAPI in dom0. Best regards, -- Yann Dirson | Vates Platform Developer XCP-ng & Xen Orchestra - Vates solutions w: vates.tech | xcp-ng.org | xen-orchestra.com Yann Dirson | Vates Platform Developer XCP-ng & Xen Orchestra - Vates solutions w: vates.fr | xcp-ng.org | xen-orchestra.com From xen-devel-bounces@lists.xenproject.org Thu May 04 16:16:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 16:16:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529839.824699 (Exim 4.92) (envelope-from ) id 1pubcz-0005qw-Jp; Thu, 04 May 2023 16:16:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529839.824699; Thu, 04 May 2023 16:16:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pubcz-0005qp-H0; Thu, 04 May 2023 16:16:21 +0000 Received: by outflank-mailman (input) for mailman id 529839; Thu, 04 May 2023 16:16:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pubcy-0005qj-1t for xen-devel@lists.xenproject.org; Thu, 04 May 2023 16:16:20 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2061e.outbound.protection.outlook.com [2a01:111:f400:7e1a::61e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ff74922b-ea96-11ed-8611-37d641c3527e; Thu, 04 May 2023 18:16:17 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6868.eurprd04.prod.outlook.com (2603:10a6:208:18c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Thu, 4 May 2023 16:16:15 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6363.022; Thu, 4 May 2023 16:16:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff74922b-ea96-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fAPZt5EH1bG/JD1PnkOnmqHz5Bm+krvubRyDUOZujf5iertOEbV/yRHRYrw11JQz3xag1Ksh0ZYUYsGIym1GsilgQg7ZoO+GY0gZa6OPEAGD8/33aOgfD2M7ZYJi3X2qtfFPdOxxDU5reCdlxv7Ez7I8QwrH0jUngUwc2TLkO99KHmJYNXoNY0d7PHAOh10dXyXWfHaCzh/5OddAj4MJApZvnyTWZ+14SBpFVS8cLeSkbBToZckG26e24bzuknV/8fQs6ROkJhMTOG89LLQnpsTHjtrni2uy6yqHHmhsrD7WasLEmulFks5Hf926VIpOMSwY0Ouw932KTr/0nKT7yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XShP+I010xYQHT+tjQ/t6tTbyUcOlkO/Qe5OKDnivA0=; b=jeYMry1EH9lkAX9Z5SgWbby6ko5SSBRl33BTGZKb0PtySXR7qXZpNT8a6niPJOsbq23dIFwy2Pu/GYd1fH/WTASO3AK+H26nDh9RpGVfVsTqYoRCsEwxWkoDBYic2/30wlOWDTGUcS1Ty2OdQ0UdrMRjP+F6OjyAiEYEUVxk7+K7vsFzV8mVXrm1JE0q/sW2EibTalklpNj8Uym6Lnq40ispg6b4T21Wo/2RXQpguO3CQVrnib2dH4EbvVHKpj1uj2UOk96kMvhgzs+Tf+YeAdwIZZBuwnn3OX0PNE0PZNgcAd+3rQhJC/UPpVpAUCme5z9UDDvPp1CJYAWs9DN/iQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XShP+I010xYQHT+tjQ/t6tTbyUcOlkO/Qe5OKDnivA0=; b=lzcg3IWpJg/9wzZ3pZugaXML+3og185wg/vNrd0XX5IzuPm0Bl0Hf2rwRSCDQqtsN5dJZBCYe0KEi2wML58WYo+xE2m6SSiJjo7fHdlNqJpBelMbKb5k7p6mRisaprqD17t1rqFFEGJCGqyezRYwiShSuAx/dpaYr1aX5clUwlBTA2YElZYVqlO7UadBYGaSQn4jix+GHHHsXeVmt/0U34GKZzTTtQg4u7r0EVGRAjL6ZBmxDKrga9e8g2jEXXRF36gUtY4w+AuAsbCs0l83HkGiGV/Q68FyeUrpx7tE04u1gGCxbl38wCrDtVI2iDXD69XBvDwkWvhJ0/9brHnMDw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <95467f2c-09ed-d34f-feef-5cd55c60f628@suse.com> Date: Thu, 4 May 2023 18:16:13 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Bobby Eshleman , Alistair Francis , Connor Davis , Anthony Perard From: Jan Beulich Subject: [PATCH] build: shorten macro references Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0117.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB6868:EE_ X-MS-Office365-Filtering-Correlation-Id: c9ae8391-1c8a-490f-f2e5-08db4cbae2a1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: z6DzkKvn/98KRYaJl7lCZMBlQ3F2I9Qi0Dlnhy0A6lSH6J7DhsIbTEzZQ9HCYdzKQcWiPEBjSK8idWpnYUERh/0X2fFy2xeGrwJuZyR3aYDZ5YtX6Odoy49TS7P/AX5vpbfEFx2jiRoBOr0bjO8V188FE72aLMN1+dNA2sD6k7bJTgv5UYnbzcDMRg28PC9/1j6WHcIo941wnrjHXr8CP/giGgNIm266v7VLEN1OpGXXD69CNcBD4VCe3BaK4bae/dbdkiOEsJYBp5yi+QUVDbT9lH3gnTVpM2uOgzy2bz0Gsgl3hR0jIJr2hZ0QElBwozg1PN2enO/F2Ggk9sTd7p6NMDSCDymQGS0n35gJNrTrq5Z4nYAn9FGDRdb1lU1f88sk35MXCux6O6z0Sv0mBaFhT+TLd7ucnchHAdfjPPVmpZm04khjrIK35qnUaDt/UoKtNqtjY5RWAAeBerO4Jx77d5WWuA+Kb7hMZO67LsaFVR/Mdtmr9ZPIfHDRYvGVhlg1IcnWn2WULDHC9kQwHXPoO2IBmb3IUyNon1GkMSZ5Ibr2lR3o9XK029bHXwpDnR/BCaCX3bfvru4UcJz7+1/zuv0jRKW410DIuqKclZxlGDQbGez/IAD/i5lRPKToNiTmywVE0rk1/tXYefwEaw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(136003)(346002)(396003)(366004)(39860400002)(451199021)(2616005)(6486002)(26005)(41300700001)(86362001)(36756003)(316002)(4326008)(6916009)(66476007)(66556008)(66946007)(31696002)(478600001)(2906002)(38100700002)(31686004)(186003)(5660300002)(54906003)(7416002)(8936002)(8676002)(6506007)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cnJvYnNyRnk4eHdMU1dUalhIZTlsN2pydjgrbHAzVDM0MjU0VGowdFlYcE1r?= =?utf-8?B?a3N5RTFHNXVDc0RGTWxyRVhlcTRleTlVRGNLak5WR29QNmFFMWM2cWtFSXJt?= =?utf-8?B?SllsUTEzKzFZbUdVY0FBejl3cVBsUGE2Y0c1OVlNUHUrSGZtV2NSWU1ZbDJF?= =?utf-8?B?Q05kQitlcmthVHBlZm85eUxsTjdna1lzR3F5amhUTTE1US94YzZzL1JZSDVt?= =?utf-8?B?NXVpRE5RUklLcmtPbVVvTDZwWDErWlhCS2tJeVhrR25DMTFPSm9vZG5wSHp0?= =?utf-8?B?MW0xZ2xKaWF3bTNoVTQzVC9Ybk5sRUU2Zk43MnIyUjJRYUl6RUpHaVJqY3RU?= =?utf-8?B?bzl0d3QxSklwemdTUEFXdWJLbWpWSzJla3QvZjkzU0l6d2FGZXpQN2RxWjNz?= =?utf-8?B?YzlVWmlQdldqL3loSlFuOEhaVkxlVlpydjdXeTlnWGFpU1NFVW42bnhRSG44?= =?utf-8?B?amVSNVZ3Tkx3U2p5UmxLTEVHV3VoY2R5NHNFL2pmekVJL0xtemVNMk14M3h1?= =?utf-8?B?c0FQQkM1dzlJVnB5MER1cUFidWR2bENGZnpIem9ycHBiZWczTjJuQzRvaWVE?= =?utf-8?B?UDRyM2tkK3d3R1VuMVk2c1daTFNEaDAxNnRTVlZlTlEvVXJETjdiRjNSWTZH?= =?utf-8?B?MXBNU2lCQ1ZTR3NuRjd2Rkp1d0VFbkxseWt4ajhZOCtzcXBOY1k5U1N3NXBQ?= =?utf-8?B?SUIrZjE2emhQblpFRlUxMzlydld6TmhMRzlVUzdaOUwyL24xUmJXbEY2WGVI?= =?utf-8?B?cHduQXUyTVdpaG5VQlVsTWFDR0JUYnljcjZMRWtYMGpqZU9nRzlCYWpDSk5X?= =?utf-8?B?R0VyNlFZaUNZd0JHRFRKUlhvbzlUamI0MzNQZEVlN3FxRUg0NElsT0ZLTk5C?= =?utf-8?B?V1U5WGg4S1NGb2FqbHJvWGhBVFNienNSSGU0bUNqQk1IRVNEUjBRaVNSL1FI?= =?utf-8?B?K0kwaTczeGVRbVVUTWZkVmt4UnZvQTVjMFNUM3o3MmNaMG9WUW0rMlBxVmhG?= =?utf-8?B?dW52SDU5N1NCRWdMaW9LTjJmejNuWXJYS0tQY2xSekJhQldVNGE3YTZVVzV0?= =?utf-8?B?R1JmMDJEMkVYUG9KdVo4dWV4UUVKcjM0elQ1WHllQzdkM1FXVnVhNFdNU3Fu?= =?utf-8?B?NkRUblBGeG9ON2VzZWUzc1ZBWDFaczVSSllYdGtZY0w1bVZUb2hBUGQxeWQ0?= =?utf-8?B?R29Vc0tTRkp0bk8ydk1hMWZaOU1Oc0dJQ3lMRi9JSHNyRndzQ3ZFT2ZBeWtn?= =?utf-8?B?Y1dvNW5mNXRLdHpEenB3NDRwSUVQNi9teFUvRlR2OGtQaEw3bytIUkg0TWFv?= =?utf-8?B?OXUxUUZPVGJTZjdraENkcnZuMXBxbkxnOTZlZzM4dWdvNlQ3bXhxWEsvRWxN?= =?utf-8?B?a1pELyt0UHJzYkJ4ZEhFYjhnN1VpeXA4Nm1UWHc4ekV6cy9BVEQzbTdyZjVt?= =?utf-8?B?T0xlUDNYOEZ0VjRSbWIvRUNCWkkwNFpwV0NKMXJyMHhzY2FUblRlMDM5YXl1?= =?utf-8?B?bFJZUmNIRFJ1aVdUaWtkZ1g0cjhzRTFva3dteTZkbWtxTHdLc01UVWkvcmtu?= =?utf-8?B?dG9raE5KdGVLbjNodGlLSkJuZUt4WWt5YUpBUUh5SG5FdU54aFVsNXRhRXg3?= =?utf-8?B?VHhJak1Zd0NHYVZrU3RTOCt1YWJkVzJudWs3bjRmZnVsSnJCT2JQaEFDeXZU?= =?utf-8?B?UVRQQUVWaFNuaDUxTkFVdzBEdFdBeHV2dVB1S1g3WFdDSWJrbHBQM3JmMWxS?= =?utf-8?B?NzV4Tk1rSjFmRENCam9kSUN0S2dvME44NFhSR0dPSm91cDRIWDV4NEJ0YWlU?= =?utf-8?B?WE01S2FvTUxnaFRGMDJEYWxDMjJTcjlZOFoyNjZpVGpRZHl2RjhtV2tmeGhz?= =?utf-8?B?WkRRSXYwOENFMDU4MzdaNnlMbFZzNFo1SFRJY3Y0ZndiMFhzay85MThlM0VI?= =?utf-8?B?K3ljQ1c0VHVENFR4ODZXSGxidGhCYkh4SThqMy9iWFFTRXRScUFySWFVNEV2?= =?utf-8?B?WDBRWis3aWpYMGpCZDFESFhibmZ6M21jOEpyWVJGcFBYSGFyaW9OelhNMTYv?= =?utf-8?B?am5VbUl3ekRzVGpGdTliSkh3VTJYZlpiMmlYbG9MMDBBalRhR205NGR3b2Vu?= =?utf-8?Q?hxcVA3Aps6FJlVEABrZnAzfkd?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c9ae8391-1c8a-490f-f2e5-08db4cbae2a1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 16:16:15.5234 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MdqUSzeXNVT569WwvUHoZxxMFjEk8BPau19nyl3Whln5glGFvgJWspIdGZAR67DoELwUE3iak1eYAVcxCfNPfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6868 Presumably by copy-and-paste we've accumulated a number of instances of $(@D)/$(@F), which really is nothing else than $@. The split form only needs using when we want to e.g. insert a leading . at the beginning of the file name portion of the full name. Signed-off-by: Jan Beulich --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -104,9 +104,9 @@ $(TARGET)-syms: $(objtree)/prelink.o $(o $(MAKE) $(build)=$(@D) $(@D)/.$(@F).1.o $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ $(@D)/.$(@F).1.o -o $@ - $(NM) -pa --format=sysv $(@D)/$(@F) \ + $(NM) -pa --format=sysv $@ \ | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ - >$(@D)/$(@F).map + >$@.map rm -f $(@D)/.$(@F).[0-9]* .PHONY: include --- a/xen/arch/riscv/Makefile +++ b/xen/arch/riscv/Makefile @@ -10,9 +10,9 @@ $(TARGET): $(TARGET)-syms $(TARGET)-syms: $(objtree)/prelink.o $(obj)/xen.lds $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) -o $@ - $(NM) -pa --format=sysv $(@D)/$(@F) \ + $(NM) -pa --format=sysv $@ \ | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ - >$(@D)/$(@F).map + >$@.map $(obj)/xen.lds: $(src)/xen.lds.S FORCE $(call if_changed_dep,cpp_lds_S) --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -150,9 +150,9 @@ $(TARGET)-syms: $(objtree)/prelink.o $(o $(MAKE) $(build)=$(@D) $(@D)/.$(@F).1.o $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ $(orphan-handling-y) $(@D)/.$(@F).1.o -o $@ - $(NM) -pa --format=sysv $(@D)/$(@F) \ + $(NM) -pa --format=sysv $@ \ | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ - >$(@D)/$(@F).map + >$@.map rm -f $(@D)/.$(@F).[0-9]* $(@D)/..$(@F).[0-9]* ifeq ($(CONFIG_XEN_IBT),y) $(SHELL) $(srctree)/tools/check-endbr.sh $@ @@ -224,8 +224,9 @@ endif $(MAKE) $(build)=$(@D) .$(@F).1r.o .$(@F).1s.o $(LD) $(call EFI_LDFLAGS,$(VIRT_BASE)) -T $(obj)/efi.lds -N $< \ $(@D)/.$(@F).1r.o $(@D)/.$(@F).1s.o $(orphan-handling-y) $(note_file_option) -o $@ - $(NM) -pa --format=sysv $(@D)/$(@F) \ - | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort >$(@D)/$(@F).map + $(NM) -pa --format=sysv $@ \ + | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ + >$@.map ifeq ($(CONFIG_DEBUG_INFO),y) $(if $(filter --strip-debug,$(EFI_LDFLAGS)),:$(space))$(OBJCOPY) -O elf64-x86-64 $@ $@.elf endif From xen-devel-bounces@lists.xenproject.org Thu May 04 16:54:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 16:54:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529842.824709 (Exim 4.92) (envelope-from ) id 1pucDr-00021q-FR; Thu, 04 May 2023 16:54:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529842.824709; Thu, 04 May 2023 16:54:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pucDr-00021j-Cj; Thu, 04 May 2023 16:54:27 +0000 Received: by outflank-mailman (input) for mailman id 529842; Thu, 04 May 2023 16:54:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pucDq-00021Z-4Q; Thu, 04 May 2023 16:54:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pucDp-0003gu-Qm; Thu, 04 May 2023 16:54:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pucDp-0007aK-7W; Thu, 04 May 2023 16:54:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pucDp-0006YS-74; Thu, 04 May 2023 16:54:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2VSiSqMJw6OPeqVOVIs9v6QVVvYymxnwbXIlHvPpsNs=; b=nFFBj1uADhiv0lleoGlDlSpjLK cZerlqVd6FdnYZK9xPe6PzAr1C2AEa1PrEFczh7lfZVFRtRqq4owwiR4OkSsz0mCuNV+4BFhB8/Bm q21h2QtprLuK/7q9PTrkJD/54ioUZ1qvzl8c2dNujWDZNreE/L64NeeJxGzV4EKhuMwU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 180524: regressions - FAIL X-Osstest-Failures: libvirt:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=2f197ab6959b2f2c39c922c3ffbdbf45aa6e8eb6 X-Osstest-Versions-That: libvirt=b4f5e6c91b9871173de205f81b51cf06a833fcb1 From: osstest service owner Date: Thu, 04 May 2023 16:54:25 +0000 flight 180524 libvirt real [real] flight 180533 libvirt real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180524/ http://logs.test-lab.xenproject.org/osstest/logs/180533/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 180513 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 180513 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 180513 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 180513 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: libvirt 2f197ab6959b2f2c39c922c3ffbdbf45aa6e8eb6 baseline version: libvirt b4f5e6c91b9871173de205f81b51cf06a833fcb1 Last test of basis 180513 2023-05-03 04:18:50 Z 1 days Testing same since 180524 2023-05-04 04:18:45 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrea Bolognani jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 2f197ab6959b2f2c39c922c3ffbdbf45aa6e8eb6 Author: Andrea Bolognani Date: Sun Apr 30 11:07:49 2023 +0200 meson: Fix qemu_{user,group} defaults for Arch The current values might have been accurate at the time when the logic was introduced, but these days Arch is using the same ones as Debian. Signed-off-by: Andrea Bolognani Reviewed-by: Erik Skultety From xen-devel-bounces@lists.xenproject.org Thu May 04 16:57:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 16:57:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529847.824720 (Exim 4.92) (envelope-from ) id 1pucGL-0002c3-V3; Thu, 04 May 2023 16:57:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529847.824720; Thu, 04 May 2023 16:57:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pucGL-0002bw-Rd; Thu, 04 May 2023 16:57:01 +0000 Received: by outflank-mailman (input) for mailman id 529847; Thu, 04 May 2023 16:57:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pucGK-0002bq-8H for xen-devel@lists.xenproject.org; Thu, 04 May 2023 16:57:00 +0000 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [2a00:1450:4864:20::62c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ae2025bc-ea9c-11ed-8611-37d641c3527e; Thu, 04 May 2023 18:56:57 +0200 (CEST) Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-94a34a14a54so144450166b.1 for ; Thu, 04 May 2023 09:56:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae2025bc-ea9c-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683219417; x=1685811417; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lbgmAvCwU1vduplWgvwbxfALqETkKPg+Klz1tE1pM5Y=; b=jb69VfEKkUjaHQLR2M/xs9Y+NjCU0b+Fq7yHJOer79PouvQWymx5syldLv97uKRuJi jTBJTuUWPvXJsafPw7tmxOXS9v+fkcJBigl7u0iyewajt2FxdNuDU43jcAyypiOSn+3F FbuQtoKsWxZTcHaWRc8Wpkxt2ZU1UM1glzIq6RGU8KY8+EaSwKkLw4PX7zMjR5iG32w6 kexzmp1SyulDQjB9ZU497cZljtZjzURytcMfGoizxe4bdx1xTdk5vqIvT5LTnYmO/NqJ 2FuFNMmVpf9iT08qnN7iwGMVD3SosIWpQ2wWyk6Xn76vGvWyVc/5Zq83Rzvs4KUoGGeX KTVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683219417; x=1685811417; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lbgmAvCwU1vduplWgvwbxfALqETkKPg+Klz1tE1pM5Y=; b=ApIom15PbmOaLxGey8yv9KKNVIx6vGYRtMldm2GgFe6lMY7tPJ0kAxG/PYT/URuD6B eV9AtccO0SXl6f5AP+7DAlZipEpa4S6RywPamojDqkLkBtXcV+ke1lz1jy7oS7YiMLxB LBRa6rT3hRSWVi+GwEBwPadRsbYLOSzB8rie3XkWWC0ZdawS03Zfi0BQL+58RC3gajB1 DxfCjFZeLtXXv5JUz3OXlJw0CjfkDcqPJaUM0MN69i5SWBCGw33OLpV6pP5DWXANuWBt dz8oFQNst8SPaOBiquqU7YCEjiVIZ6xqeawH8Ub92vm30bwF9knG68hxdFOTFEMgbuX2 Kp9Q== X-Gm-Message-State: AC+VfDzu1fA+i+i7BK2Pqt3Y27D/Px18NPl+fXwKzoa3SZ9aFhZKh18M P81FwqRXSqSRkFYVpDE35cJiWVbBDPKVOLn8/zrqph0+e1w= X-Google-Smtp-Source: ACHHUZ5zXJ2SAWr4/GWxWMzLDfvSB6dTtI5D7388SUaQuoRwULQP1Fm9g14+LAOGxxBqloPibNDOGbfJ42vuL+NO3FM= X-Received: by 2002:a17:906:c156:b0:94e:2db:533e with SMTP id dp22-20020a170906c15600b0094e02db533emr8725935ejc.49.1683219416969; Thu, 04 May 2023 09:56:56 -0700 (PDT) MIME-Version: 1.0 References: <20230501193034.88575-1-jandryuk@gmail.com> <20230501193034.88575-5-jandryuk@gmail.com> <43c519f7-577d-f657-a4b1-1a31bf7f093a@suse.com> In-Reply-To: <43c519f7-577d-f657-a4b1-1a31bf7f093a@suse.com> From: Jason Andryuk Date: Thu, 4 May 2023 12:56:44 -0400 Message-ID: Subject: Re: [PATCH v3 04/14 RESEND] cpufreq: Add Hardware P-State (HWP) driver To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , xen-devel@lists.xenproject.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, May 4, 2023 at 9:11=E2=80=AFAM Jan Beulich wrot= e: > > On 01.05.2023 21:30, Jason Andryuk wrote: > > For cpufreq=3Dxen:hwp, placing the option inside the governor wouldn't > > work. Users would have to select the hwp-internal governor to turn off > > hwp support. > > I'm afraid I don't understand this, and you'll find a comment towards > this further down. Even when ... > > > hwp-internal isn't usable without hwp, and users wouldn't > > be able to select a different governor. That doesn't matter while hwp > > defaults off, but it would if or when hwp defaults to enabled. > > ... it starts defaulting to enabled, selecting another governor can > simply have the side effect of turning off hwp. I didn't think of that - makes sense. > > Write to disable the interrupt - the linux pstate driver does this. We > > don't use the interrupts, so we can just turn them off. We aren't read= y > > to handle them, so we don't want any. Unclear if this is necessary. > > SDM says it's default disabled. > > Definitely better to be on the safe side. > > > --- a/docs/misc/xen-command-line.pandoc > > +++ b/docs/misc/xen-command-line.pandoc > > @@ -499,7 +499,7 @@ If set, force use of the performance counters for o= profile, rather than detectin > > available support. > > > > ### cpufreq > > -> `=3D none | {{ | xen } [:[powersave|performance|ondemand|u= serspace][,][,[][,[verbose]]]]} | dom0-kernel` > > +> `=3D none | {{ | xen } [:[powersave|performance|ondemand|u= serspace][,][,[]][,[]][,[]][,[verbose]]]} | dom= 0-kernel` > > Considering you use a special internal governor, the 4 governor alternati= ves are > meaningless for hwp. Hence at the command line level recognizing "hwp" as= if it > was another governor name would seem better to me. This would then also g= et rid > of one of the two special "no-" prefix parsing cases (which I'm not overl= y > happy about). > > Even if not done that way I'm puzzled by the way you spell out the intera= ction > of "hwp" and "hdc": As you say in the description, "hdc" is meaningful on= ly when > "hwp" was specified, so even if not merged with the governors group "hwp"= should > come first, and "hdc" ought to be rejected if "hwp" wasn't first specifie= d. (The > way you've spelled it out it actually looks to be kind of the other way a= round.) I placed them in alphabetical order, but, yes, it doesn't make sense. > Strictly speaking "maxfreq" and "minfreq" also should be objected to when= "hwp" > was specified. > > Overall I'm getting the impression that beyond your "verbose" related adj= ustment > more is needed, if you're meaning to get things closer to how we parse th= e > option (splitting across multiple lines to help see what I mean): > > `=3D none > | {{ | xen } [:{powersave|performance|ondemand|userspace} > [{,hwp[,hdc]|[,maxfreq=3D[,minfreq=3D<= minfreq>]}] > [,verbose]]} > | dom0-kernel` > > (We're still parsing in a more relaxed way, e.g. minfreq may come ahead o= f > maxfreq, but better be more tight in the doc than too relaxed.) > > Furthermore while max/min freq don't apply directly, there are still two = MSRs > controlling bounds at the package and logical processor levels. Well, we only program the logical processor level MSRs because we don't have a good idea of the packages to know when we can skip writing an MSR. How about this: `=3D none | {{ | xen } { [:{powersave|performance|ondemand|userspace}[,maxfreq=3D[,minfreq= =3D]] | [:hwp[,hdc]] } [,verbose]]} | dom0-kernel` i.e: xen:hwp,hdc > > --- /dev/null > > +++ b/xen/arch/x86/acpi/cpufreq/hwp.c > > @@ -0,0 +1,506 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +/* > > + * hwp.c cpufreq driver to run Intel Hardware P-States (HWP) > > + * > > + * Copyright (C) 2021 Jason Andryuk > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +static bool feature_hwp; > > +static bool feature_hwp_notification; > > +static bool feature_hwp_activity_window; > > +static bool feature_hwp_energy_perf; > > +static bool feature_hwp_pkg_level_ctl; > > +static bool feature_hwp_peci; > > + > > +static bool feature_hdc; > > Most (all?) of these want to be __ro_after_init, I expect. I think you are correct. (This pre-dates __ro_after_init and I didn't update it.) > > +__initdata bool opt_cpufreq_hwp =3D false; > > +__initdata bool opt_cpufreq_hdc =3D true; > > Nit (style): Please put annotations after the type. > > > +#define HWP_ENERGY_PERF_BALANCE 0x80 > > +#define IA32_ENERGY_BIAS_BALANCE 0x7 > > +#define IA32_ENERGY_BIAS_MAX_POWERSAVE 0xf > > +#define IA32_ENERGY_BIAS_MASK 0xf > > + > > +union hwp_request > > +{ > > + struct > > + { > > + uint64_t min_perf:8; > > + uint64_t max_perf:8; > > + uint64_t desired:8; > > + uint64_t energy_perf:8; > > + uint64_t activity_window:10; > > + uint64_t package_control:1; > > + uint64_t reserved:16; > > + uint64_t activity_window_valid:1; > > + uint64_t energy_perf_valid:1; > > + uint64_t desired_valid:1; > > + uint64_t max_perf_valid:1; > > + uint64_t min_perf_valid:1; > > The boolean fields here would probably better be of type "bool". I also > don't see the need for using uint64_t for any of the other fields - > unsigned int will be quite fine, I think. Only ... This is the hardware MSR format, so it seemed natural to use uint64_t and the bit fields. To me, uint64_t foo:$bits; better shows that we are dividing up a single hardware register using bit fields. Honestly, I'm unfamiliar with the finer points of laying out bitfields with bool. And the 10 bits of activity window throws off aligning to standard types. This seems to have the correct layout: struct { unsigned char min_perf; unsigned char max_perf; unsigned char desired; unsigned char energy_perf; unsigned int activity_window:10; bool package_control:1; unsigned int reserved:16; bool activity_window_valid:1; bool energy_perf_valid:1; bool desired_valid:1; bool max_perf_valid:1; bool min_perf_valid:1; } ; Or would you prefer the first 8 bit ones to be unsigned int min_perf:8? The bools seem to need :1, which doesn't seem to be gaining us much, IMO. I'd strongly prefer just keeping it as I have it, but I will change it however you like. > > + }; > > + uint64_t raw; > > ... this wants to keep this type. (Same again below then.) For "below", do you want: struct { unsigned char highest; unsigned char guaranteed; unsigned char most_efficient; unsigned char lowest; unsigned int reserved; } hw; ? > > +bool __init hwp_available(void) > > +{ > > + unsigned int eax, ecx, unused; > > + bool use_hwp; > > + > > + if ( boot_cpu_data.cpuid_level < CPUID_PM_LEAF ) > > + { > > + hwp_verbose("cpuid_level (%#x) lacks HWP support\n", > > + boot_cpu_data.cpuid_level); > > + return false; > > + } > > + > > + if ( boot_cpu_data.cpuid_level < 0x16 ) > > + { > > + hwp_info("HWP disabled: cpuid_level %#x < 0x16 lacks CPU freq = info\n", > > + boot_cpu_data.cpuid_level); > > + return false; > > + } > > + > > + cpuid(CPUID_PM_LEAF, &eax, &unused, &ecx, &unused); > > + > > + if ( !(eax & CPUID6_EAX_HWP_ENERGY_PERFORMANCE_PREFERENCE) && > > + !(ecx & CPUID6_ECX_IA32_ENERGY_PERF_BIAS) ) > > + { > > + hwp_verbose("HWP disabled: No energy/performance preference av= ailable"); > > + return false; > > + } > > + > > + feature_hwp =3D eax & CPUID6_EAX_HWP; > > + feature_hwp_notification =3D eax & CPUID6_EAX_HWP_NOTIFICATION; > > + feature_hwp_activity_window =3D eax & CPUID6_EAX_HWP_ACTIVITY_WIND= OW; > > + feature_hwp_energy_perf =3D > > + eax & CPUID6_EAX_HWP_ENERGY_PERFORMANCE_PREFERENCE; > > + feature_hwp_pkg_level_ctl =3D eax & CPUID6_EAX_HWP_PACKAGE_LEVEL= _REQUEST; > > + feature_hwp_peci =3D eax & CPUID6_EAX_HWP_PECI; > > + > > + hwp_verbose("HWP: %d notify: %d act-window: %d energy-perf: %d pkg= -level: %d peci: %d\n", > > + feature_hwp, feature_hwp_notification, > > + feature_hwp_activity_window, feature_hwp_energy_perf, > > + feature_hwp_pkg_level_ctl, feature_hwp_peci); > > + > > + if ( !feature_hwp ) > > + return false; > > + > > + feature_hdc =3D eax & CPUID6_EAX_HDC; > > + > > + hwp_verbose("HWP: Hardware Duty Cycling (HDC) %ssupported%s\n", > > + feature_hdc ? "" : "not ", > > + feature_hdc ? opt_cpufreq_hdc ? ", enabled" : ", disab= led" > > + : ""); > > + > > + feature_hdc =3D feature_hdc && opt_cpufreq_hdc; > > + > > + hwp_verbose("HWP: HW_FEEDBACK %ssupported\n", > > + (eax & CPUID6_EAX_HW_FEEDBACK) ? "" : "not "); > > You report this, but you don't really use it? Correct. I needed to know what capabilities my processors have. feature_hwp_pkg_level_ctl and feature_hwp_peci can also be dropped since they aren't used beyond printing their values. I'd still lean toward keeping their printing under verbose since otherwise there isn't a convenient way to know if they are available without recompiling. > > + use_hwp =3D feature_hwp && opt_cpufreq_hwp; > > There's a lot of output you may produce until you make it here, which is > largely meaningless when opt_cpufreq_hwp =3D=3D false. Is there a reason = you > don't check that flag first thing in the function? opt_cpufreq_hwp can be checked earlier for an early exit, yes. The code came about during development to print all the HWP capabilities even if it wasn't enabled. But eliminating it now makes sense. > > +static void hdc_set_pkg_hdc_ctl(bool val) > > +{ > > + uint64_t msr; > > + > > + if ( rdmsr_safe(MSR_IA32_PKG_HDC_CTL, msr) ) > > + { > > + hwp_err("error rdmsr_safe(MSR_IA32_PKG_HDC_CTL)\n"); > > + > > + return; > > + } > > + > > + if ( val ) > > + msr |=3D IA32_PKG_HDC_CTL_HDC_PKG_ENABLE; > > + else > > + msr &=3D ~IA32_PKG_HDC_CTL_HDC_PKG_ENABLE; > > + > > + if ( wrmsr_safe(MSR_IA32_PKG_HDC_CTL, msr) ) > > + hwp_err("error wrmsr_safe(MSR_IA32_PKG_HDC_CTL): %016lx\n", ms= r); > > +} > > + > > +static void hdc_set_pm_ctl1(bool val) > > +{ > > + uint64_t msr; > > + > > + if ( rdmsr_safe(MSR_IA32_PM_CTL1, msr) ) > > + { > > + hwp_err("error rdmsr_safe(MSR_IA32_PM_CTL1)\n"); > > + > > + return; > > + } > > + > > + if ( val ) > > + msr |=3D IA32_PM_CTL1_HDC_ALLOW_BLOCK; > > + else > > + msr &=3D ~IA32_PM_CTL1_HDC_ALLOW_BLOCK; > > + > > + if ( wrmsr_safe(MSR_IA32_PM_CTL1, msr) ) > > + hwp_err("error wrmsr_safe(MSR_IA32_PM_CTL1): %016lx\n", msr); > > +} > > For both functions: Elsewhere you also log the affected CPU in hwp_err(). > Without this I'm not convinced the logging here is very useful. In fact I > wonder whether hwp_err() shouldn't take care of this and/or the "error" > part of the string literal. A HWP: prefix might also not be bad ... Sounds good. I'll investigate. > > +static void hwp_get_cpu_speeds(struct cpufreq_policy *policy) > > +{ > > + uint32_t base_khz, max_khz, bus_khz, edx; > > + > > + cpuid(0x16, &base_khz, &max_khz, &bus_khz, &edx); > > + > > + /* aperf/mperf scales base. */ > > + policy->cpuinfo.perf_freq =3D base_khz * 1000; > > + policy->cpuinfo.min_freq =3D base_khz * 1000; > > + policy->cpuinfo.max_freq =3D max_khz * 1000; > > + policy->min =3D base_khz * 1000; > > + policy->max =3D max_khz * 1000; > > + policy->cur =3D 0; > > What is the comment intended to be telling me here? When I was surprised to discover that I needed to pass in the base frequency for proper aperf/mperf scaling, it seemed relevant at the time as it's the opposite of ACPI cpufreq. It can be dropped now. > > +static void cf_check hwp_init_msrs(void *info) > > +{ > > + struct cpufreq_policy *policy =3D info; > > + struct hwp_drv_data *data =3D this_cpu(hwp_drv_data); > > + uint64_t val; > > + > > + /* > > + * Package level MSR, but we don't have a good idea of packages he= re, so > > + * just do it everytime. > > + */ > > + if ( rdmsr_safe(MSR_IA32_PM_ENABLE, val) ) > > + { > > + hwp_err("CPU%u: error rdmsr_safe(MSR_IA32_PM_ENABLE)\n", polic= y->cpu); > > + data->curr_req.raw =3D -1; > > + return; > > + } > > + > > + /* Ensure we don't generate interrupts */ > > + if ( feature_hwp_notification ) > > + wrmsr_safe(MSR_IA32_HWP_INTERRUPT, 0); > > + > > + hwp_verbose("CPU%u: MSR_IA32_PM_ENABLE: %016lx\n", policy->cpu, va= l); > > + if ( !(val & IA32_PM_ENABLE_HWP_ENABLE) ) > > + { > > + val |=3D IA32_PM_ENABLE_HWP_ENABLE; > > + if ( wrmsr_safe(MSR_IA32_PM_ENABLE, val) ) > > + { > > + hwp_err("CPU%u: error wrmsr_safe(MSR_IA32_PM_ENABLE, %lx)\= n", > > + policy->cpu, val); > > + data->curr_req.raw =3D -1; > > + return; > > + } > > + } > > + > > + if ( rdmsr_safe(MSR_IA32_HWP_CAPABILITIES, data->hwp_caps) ) > > + { > > + hwp_err("CPU%u: error rdmsr_safe(MSR_IA32_HWP_CAPABILITIES)\n"= , > > + policy->cpu); > > + data->curr_req.raw =3D -1; > > + return; > > + } > > + > > + if ( rdmsr_safe(MSR_IA32_HWP_REQUEST, data->curr_req.raw) ) > > + { > > + hwp_err("CPU%u: error rdmsr_safe(MSR_IA32_HWP_REQUEST)\n", pol= icy->cpu); > > + data->curr_req.raw =3D -1; > > + return; > > + } > > + > > + if ( !feature_hwp_energy_perf ) { > > Nit: Brace placement. > > > + if ( rdmsr_safe(MSR_IA32_ENERGY_PERF_BIAS, val) ) > > + { > > + hwp_err("error rdmsr_safe(MSR_IA32_ENERGY_PERF_BIAS)\n"); > > + data->curr_req.raw =3D -1; > > + > > + return; > > + } > > + > > + data->energy_perf =3D val & IA32_ENERGY_BIAS_MASK; > > + } > > In order to not need to undo the "enable" you've already done, maybe that > should move down here? HWP needs to be enabled before the Capabilities and Request MSRs can be read. Reading them shouldn't fail, but it seems safer to use rdmsr_safe in case something goes wrong. I think I will rip out ENERGY_PERF_BIAS. The Linux driver doesn't support it. I thought it might be necessary, but my test machines don't need it. The Qubes report with SkyLake wasn't using ENERGY_PERF_BIAS, and SkyLake introduced HWP. So the set of machines needing it is probably small and older, so it probably isn't worth supporting. > With all the sanity checking you do here, maybe > you should also check that the write of the enable bit actually took > effect? I can add that. > > +/* val 0 - highest performance, 15 - maximum energy savings */ > > +static void hwp_energy_perf_bias(const struct hwp_drv_data *data) > > +{ > > + uint64_t msr; > > + uint8_t val =3D data->energy_perf; > > + > > + ASSERT(val <=3D IA32_ENERGY_BIAS_MAX_POWERSAVE); > > + > > + if ( rdmsr_safe(MSR_IA32_ENERGY_PERF_BIAS, msr) ) > > + { > > + hwp_err("error rdmsr_safe(MSR_IA32_ENERGY_PERF_BIAS)\n"); > > + > > + return; > > + } > > + > > + msr &=3D ~IA32_ENERGY_BIAS_MASK; > > + msr |=3D val; > > + > > + if ( wrmsr_safe(MSR_IA32_ENERGY_PERF_BIAS, msr) ) > > + hwp_err("error wrmsr_safe(MSR_IA32_ENERGY_PERF_BIAS): %016lx\n= ", msr); > > +} > > + > > +static void cf_check hwp_write_request(void *info) > > +{ > > + struct cpufreq_policy *policy =3D info; > > + struct hwp_drv_data *data =3D this_cpu(hwp_drv_data); > > + union hwp_request hwp_req =3D data->curr_req; > > + > > + BUILD_BUG_ON(sizeof(union hwp_request) !=3D sizeof(uint64_t)); > > + if ( wrmsr_safe(MSR_IA32_HWP_REQUEST, hwp_req.raw) ) > > + { > > + hwp_err("CPU%u: error wrmsr_safe(MSR_IA32_HWP_REQUEST, %lx)\n"= , > > + policy->cpu, hwp_req.raw); > > + rdmsr_safe(MSR_IA32_HWP_REQUEST, data->curr_req.raw); > > + } > > + > > + if ( !feature_hwp_energy_perf ) > > + hwp_energy_perf_bias(data); > > + > > +} > > + > > +static int cf_check hwp_cpufreq_target(struct cpufreq_policy *policy, > > + unsigned int target_freq, > > + unsigned int relation) > > +{ > > + unsigned int cpu =3D policy->cpu; > > + struct hwp_drv_data *data =3D per_cpu(hwp_drv_data, cpu); > > + /* Zero everything to ensure reserved bits are zero... */ > > + union hwp_request hwp_req =3D { .raw =3D 0 }; > > + > > + /* .. and update from there */ > > + hwp_req.min_perf =3D data->minimum; > > + hwp_req.max_perf =3D data->maximum; > > + hwp_req.desired =3D data->desired; > > + if ( feature_hwp_energy_perf ) > > + hwp_req.energy_perf =3D data->energy_perf; > > + if ( feature_hwp_activity_window ) > > + hwp_req.activity_window =3D data->activity_window; > > + > > + if ( hwp_req.raw =3D=3D data->curr_req.raw ) > > + return 0; > > + > > + data->curr_req =3D hwp_req; > > + > > + hwp_verbose("CPU%u: wrmsr HWP_REQUEST %016lx\n", cpu, hwp_req.raw)= ; > > + on_selected_cpus(cpumask_of(cpu), hwp_write_request, policy, 1); > > + > > + return 0; > > +} > > If I'm not mistaken these 3 functions can only be reached from the user > space tool (via set_cpufreq_para()). On that path I don't think there > should be any hwp_err(); definitely not in non-verbose mode. Instead it > would be good if a sensible error code could be reported back. (Same > then for hwp_cpufreq_update() and its helper.) I'll investigate this. I guess I'll have to stash a result in struct hwp_drv_data. > > --- a/xen/arch/x86/include/asm/cpufeature.h > > +++ b/xen/arch/x86/include/asm/cpufeature.h > > @@ -46,8 +46,17 @@ extern struct cpuinfo_x86 boot_cpu_data; > > #define cpu_has(c, bit) test_bit(bit, (c)->x86_capability= ) > > #define boot_cpu_has(bit) test_bit(bit, boot_cpu_data.x86_capabilit= y) > > > > -#define CPUID_PM_LEAF 6 > > -#define CPUID6_ECX_APERFMPERF_CAPABILITY 0x1 > > +#define CPUID_PM_LEAF 6 > > +#define CPUID6_EAX_HWP (_AC(1, U) << 7) > > +#define CPUID6_EAX_HWP_NOTIFICATION (_AC(1, U) << 8) > > +#define CPUID6_EAX_HWP_ACTIVITY_WINDOW (_AC(1, U) << 9) > > +#define CPUID6_EAX_HWP_ENERGY_PERFORMANCE_PREFERENCE (_AC(1, U) << 10) > > +#define CPUID6_EAX_HWP_PACKAGE_LEVEL_REQUEST (_AC(1, U) << 11) > > +#define CPUID6_EAX_HDC (_AC(1, U) << 13) > > +#define CPUID6_EAX_HWP_PECI (_AC(1, U) << 16) > > +#define CPUID6_EAX_HW_FEEDBACK (_AC(1, U) << 19) > > Perhaps better without open-coding BIT()? Ok. > I also find it a little odd that e.g. bit 17 is left out here despite you > declaring the 5 "valid" bits in union hwp_request (which are qualified by > this CPUID bit afaict). Well, I thought I wasn't supposed to introduce unused defines, so I didn't add one for 17. For union hwp_request, the "valid" bits are part of the register structure, so it makes sense to include them instead of an incomplete definition. IIRC, at some point I set the "valid" bits when I wasn't supposed to, and they caused the wrmsr calls to fail. That might have been because my test machines don't have package-level HWP. (I was confused when the CPUID section stated "Bit 17: Flexible HWP is supported if set.", but there are no further references to "Flexible HWP" in the SDM.) > > +#define CPUID6_ECX_APERFMPERF_CAPABILITY 0x1 > > +#define CPUID6_ECX_IA32_ENERGY_PERF_BIAS 0x8 > > Why not the same form here? I was re-indenting APERFMPERF, and added ENERGY_PERF_BIAS in a consistent style. I will update with BIT(). > > --- a/xen/arch/x86/include/asm/msr-index.h > > +++ b/xen/arch/x86/include/asm/msr-index.h > > @@ -151,6 +151,13 @@ > > > > #define MSR_PKRS 0x000006e1 > > > > +#define MSR_IA32_PM_ENABLE 0x00000770 > > +#define IA32_PM_ENABLE_HWP_ENABLE (_AC(1, ULL) << 0) > > + > > +#define MSR_IA32_HWP_CAPABILITIES 0x00000771 > > +#define MSR_IA32_HWP_INTERRUPT 0x00000773 > > +#define MSR_IA32_HWP_REQUEST 0x00000774 > > I think for new MSRs being added here in particular Andrew would like to > see the IA32 infixes omitted. (I'd extend this then to > CPUID6_ECX_IA32_ENERGY_PERF_BIAS as well.) Ok. > > @@ -165,6 +172,11 @@ > > #define PASID_PASID_MASK 0x000fffff > > #define PASID_VALID (_AC(1, ULL) << 31) > > > > +#define MSR_IA32_PKG_HDC_CTL 0x00000db0 > > +#define IA32_PKG_HDC_CTL_HDC_PKG_ENABLE (_AC(1, ULL) << 0) > > The name has two redundant infixes, which looks odd, but then I can't > suggest any better without going too much out of sync with the SDM. Yes, it's not a good name, but I was trying to keep close to the SDM. FAOD, these should drop IA32_ to become: MSR_PKG_HDC_CTL PKG_HDC_CTL_HDC_PKG_ENABLE ? > > --- a/xen/drivers/cpufreq/cpufreq.c > > +++ b/xen/drivers/cpufreq/cpufreq.c > > @@ -565,6 +565,38 @@ static void cpufreq_cmdline_common_para(struct cpu= freq_policy *new_policy) > > > > static int __init cpufreq_handle_common_option(const char *name, const= char *val) > > { > > + if (!strcmp(name, "hdc")) { > > + if (val) { > > + int ret =3D parse_bool(val, NULL); > > + if (ret !=3D -1) { > > + opt_cpufreq_hdc =3D ret; > > + return 1; > > + } > > + } else { > > + opt_cpufreq_hdc =3D true; > > + return 1; > > + } > > + } else if (!strcmp(name, "no-hdc")) { > > + opt_cpufreq_hdc =3D false; > > + return 1; > > + } > > I think recognizing a "no-" prefix would want to be separated out, and be > restricted to val being NULL. It would result in val being pointed at the > string "no" (or "off" or anything else parse_bool() recognizes as negativ= e > indicator). > > Yet if, as suggested above, "hwp" became a "fake" governor also when > parsing the command line, "hdc" could actually be handled in its > handle_option() hook. Makes sense. Thank you for taking the time to review this. Regards, Jason From xen-devel-bounces@lists.xenproject.org Thu May 04 17:00:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 17:00:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529852.824730 (Exim 4.92) (envelope-from ) id 1pucJl-0004Cg-H0; Thu, 04 May 2023 17:00:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529852.824730; Thu, 04 May 2023 17:00:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pucJl-0004CZ-E7; Thu, 04 May 2023 17:00:33 +0000 Received: by outflank-mailman (input) for mailman id 529852; Thu, 04 May 2023 17:00:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pucJj-0004CS-T7 for xen-devel@lists.xenproject.org; Thu, 04 May 2023 17:00:31 +0000 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [2a00:1450:4864:20::62d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2d583e48-ea9d-11ed-b226-6b7b168915f2; Thu, 04 May 2023 19:00:31 +0200 (CEST) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-95369921f8eso124766166b.0 for ; Thu, 04 May 2023 10:00:31 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2d583e48-ea9d-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683219630; x=1685811630; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Tf+akuAetUw5mPpaoTEl1gz7jnjlPFnuMgfEJt3WehQ=; b=Uvl1QsdyaTc70GUeTJPP3JIMIajiRrYckvtyXmpKr67WX29WXIeaMsl4j+pxDr4zKD e5cPgolphQTQ/3vIyQQjQbfrvCB1XEpJk8QZ7/9b9VvMzwUpNFqZCVxJIOaTc6tsxxLo ISD22iYuSqCasw1QC9eV71ZQMSQIq8b5AiYWFkrKpY9KGDqQkJ7tS/aZaNDiiL2sACdK j8lC3By3qzwyoigV/xh49IWRG9e0eGN9B+FMp8j9ow7T3DTnqxBsVgiQ12P/gNUE0gX9 Xs8mc0tAw4ME69ppQ1NzObb8ajPJT3K5520U26gyeImEDfvRKvV+KriTtJ20LP8zorTf ugLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683219630; x=1685811630; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Tf+akuAetUw5mPpaoTEl1gz7jnjlPFnuMgfEJt3WehQ=; b=Izip/uew1OeTMPYsEU47tBaHVAcIMR0JZpHP97hkp60bp/xlbN46G2AVJrIp4oIGyN bsCkd38pUddpo5nAsnVcw8ksm7Ikm1T5sM0peddy4hpPK9/OQl+ZzNOKV3OOZ+0cHmq7 AiGKa+zaW3aoY0nnVJvO1wR3bY1FwWmZMrOj+jXRdZjlO/UWShmr2KMnX2FNC0TqRXl+ odWUr5XSWAGFbpTv1YCHrDXz900nuFmBHH1dDj8QHEqQ5GieYgEkDm4d6tWZ508+ii6y zdzjCMjFqOm0BuY6WiL2aaPRFUFcSpQc3yIes4TLySzkm4+O2JDr8fWZIrHLqk/X/TLK pIcA== X-Gm-Message-State: AC+VfDz4PT7NcUWelkHiga2hHOk56mV7k+Iwmpq/Lj+GjYGDu3znBHyV b5HnqGe3sYlLff7RMbED3KAzIcP6jtd4DVObsN7keTT7 X-Google-Smtp-Source: ACHHUZ4EApKmy01ns7eRj4sQhVdkyd7+J6e/u+KRupmFVYz/e9IBl0/BGrOR/3Xi7dunPYOSCzA874bIj837NQPpHgo= X-Received: by 2002:a17:907:26c5:b0:953:4775:baa7 with SMTP id bp5-20020a17090726c500b009534775baa7mr7703348ejc.52.1683219630364; Thu, 04 May 2023 10:00:30 -0700 (PDT) MIME-Version: 1.0 References: <20230501193034.88575-1-jandryuk@gmail.com> <20230501193034.88575-6-jandryuk@gmail.com> <2864bf57-88cd-6fce-2d38-6f3a31abb440@suse.com> In-Reply-To: <2864bf57-88cd-6fce-2d38-6f3a31abb440@suse.com> From: Jason Andryuk Date: Thu, 4 May 2023 13:00:18 -0400 Message-ID: Subject: Re: [PATCH v3 05/14 RESEND] xenpm: Change get-cpufreq-para output for internal To: Jan Beulich Cc: Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, May 4, 2023 at 10:35=E2=80=AFAM Jan Beulich wro= te: > > On 01.05.2023 21:30, Jason Andryuk wrote: > > When using HWP, some of the returned data is not applicable. In that > > case, we should just omit it to avoid confusing the user. So switch to > > printing the base and turbo frequencies since those are relevant to HWP= . > > Similarly, stop printing the CPU frequencies since those do not apply. > > It vaguely feels like I have asked this before: Can you point me at a > place in the SDM where it is said that CPUID 0x16's "Maximum Frequency" > is the turbo frequency? Without such a reference I feel a little uneasy > with ... I don't have a reference, but I found it empirically to match the "turbo" frequency. For an Intel=C2=AE Core=E2=84=A2 i7-10810U, https://ark.intel.com/content/www/us/en/ark/products/201888/intel-core-i710= 810u-processor-12m-cache-up-to-4-90-ghz.html Max Turbo Frequency 4.90 GHz # xenpm get-cpufreq-para cpu id : 0 affected_cpus : 0 cpuinfo frequency : base [1600000] turbo [4900000] Turbo has to be enabled to reach (close to) that frequency. >From my cover letter: This is for a 10th gen 6-core 1600 MHz base 4900 MHZ max cpu. In the default balance mode, Turbo Boost doesn't exceed 4GHz. Tweaking the energy_perf preference with `xenpm set-cpufreq-hwp balance ene:64`, I've seen the CPU hit 4.7GHz before throttling down and bouncing around between 4.3 and 4.5 GHz. Curiously the other cores read ~4GHz when turbo boost takes affect. This was done after pinning all dom0 cores, and using taskset to pin to vCPU/pCPU 11 and running a bash tightloop. > > @@ -720,10 +721,15 @@ static void print_cpufreq_para(int cpuid, struct = xc_get_cpufreq_para *p_cpufreq) > > printf(" %d", p_cpufreq->affected_cpus[i]); > > printf("\n"); > > > > - printf("cpuinfo frequency : max [%u] min [%u] cur [%u]\n", > > - p_cpufreq->cpuinfo_max_freq, > > - p_cpufreq->cpuinfo_min_freq, > > - p_cpufreq->cpuinfo_cur_freq); > > + if ( internal ) > > + printf("cpuinfo frequency : base [%u] turbo [%u]\n", > > + p_cpufreq->cpuinfo_min_freq, > > + p_cpufreq->cpuinfo_max_freq); > > ... calling it "turbo" (and not "max") here. I'm fine with "max". I think I went with turbo since it's a value you cannot sustain but can only hit in short bursts. Regards, Jason From xen-devel-bounces@lists.xenproject.org Thu May 04 17:24:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 17:24:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529856.824742 (Exim 4.92) (envelope-from ) id 1puch9-0006oZ-Dp; Thu, 04 May 2023 17:24:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529856.824742; Thu, 04 May 2023 17:24:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puch9-0006oR-B7; Thu, 04 May 2023 17:24:43 +0000 Received: by outflank-mailman (input) for mailman id 529856; Thu, 04 May 2023 17:24:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puch7-0006oK-Rj for xen-devel@lists.xenproject.org; Thu, 04 May 2023 17:24:42 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8a6031ec-eaa0-11ed-b226-6b7b168915f2; Thu, 04 May 2023 19:24:40 +0200 (CEST) Received: from mail-mw2nam10lp2109.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.109]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 May 2023 13:24:14 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BY5PR03MB5154.namprd03.prod.outlook.com (2603:10b6:a03:22f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Thu, 4 May 2023 17:24:10 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb%4]) with mapi id 15.20.6340.031; Thu, 4 May 2023 17:24:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8a6031ec-eaa0-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683221080; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=Tmg3PgyDemi8W5IKw2e27HHKjzkW0qEODkFlV4QFPwM=; b=LVVqwZ/kCjhnfk9yOJBfegrxXnY3QF1jVlZdE8OaPZtmYdcSKGy5fKH+ 5EP6l9kleLvSXYlrnfOhZQrQvVJCxa6kjxJ4JQgvFVRqYcCDaslyJW71X VXpymGH/FHwPQTSJmpzTvi7m4eSZe6/EvibRfceDOT7ql41B1i1ZQTB7/ Q=; X-IronPort-RemoteIP: 104.47.55.109 X-IronPort-MID: 106659110 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Aenu8aDqpp8gJRVW/33jw5YqxClBgxIJ4kV8jS/XYbTApD0m3zdTm 2oZXjzVM6zeZ2H2edh/b9nipElTsZLVx4A3QQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFuspvlDs15K6p4G5A4gRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwwOpGH2Jny qQkKB8NMRnA1viq/+ilRbw57igjBJGD0II3nFhFlGmcKMl8BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI+Oxuuzm7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prraXw32mCdtLTNVU8NYxsmK52F5QFCQTRAeQs6OTsne4eOBQf hl8Fi0G6PJaGFaQZtv3UgC8oXWElgUBQNcWGOo/gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1 FKCg5XuHzMHmKKRYWKQ8PGTtzzaESoIKW4PYwcUQA1D5MPsyKkolQ7GRNtnFK+zj/X2FCv2z jTMqzIx750NisoM27S+7ErwiTumrZjUTSY4/gzSGGmi62tRboO/e5ah71Sd6P9aNZuYVXGIp n1CkM+bhMgECpuHhSGWQOEAGbivz/mAOTzYx1VoGvEJ/jCs4GKqfJoW7it3IkxoKe4bdTSva 0jW0Sta45lVO3mmZLF2eKq+Ds0rye7rEtGNaxzPRt9HY5w0cRDd+ihrPBaUxzq0yBlqlrwjM 5CGd8rqFWwdFals0DuxQaEazKMvwSc9g2jUQPgX0iia7FZXX1bNIZ9tDbdERrlnhE9YiG05K +piCvY= IronPort-HdrOrdr: A9a23:9YcdCq9gXQLyrNZh2c5uk+DEI+orL9Y04lQ7vn2ZKCYlEPBx9a iV9sjzsCWYtN9/Yh0dcLy7V5VoIkmslqKdg7NxAV7KZmCP01dASrsN0WKI+V3dJxE= X-Talos-CUID: =?us-ascii?q?9a23=3Aet5+OGuaK/ORl3zCUVHbtCLR6IsffkzDz17ve3O?= =?us-ascii?q?4JmY2Qf7EU0Ovor1rxp8=3D?= X-Talos-MUID: 9a23:0jFzvARk0ci6Em2QRXS3tg5IKvUr/52rGRwmg88sg/CCFh5/bmI= X-IronPort-AV: E=Sophos;i="5.99,250,1677560400"; d="scan'208";a="106659110" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e+xUITIv/b/7R2/rcYufXXmyS0zOOPnkqUV8J4K48Nj+wCXxSS0oo3vV7/6J+33k/pTmwjysqXT1PbxwHMp3mlFvZW4qioW1IFdgiFDEYL3b1CPzxfysnBQDhYv1IWlKUaW4iwOv4vOoW0GUmWOc/diUt/9sBZmpzEyD+6CO2OcAPz0HVlV0s2g1R91jfFzo/rHwvkyA2MBpvvxAkv9AGzT37P+ryFMlH8YvrmNIB5bpBsBVoLLb9wr3m4eF0xkaZabOgZu0kk1P4ZdxTO9Zh5dBornXIk/ldhWEabsbxsNNiph0NYhwzJCxrtsDBsKf4FGmlUgpxCZeTX0q5nr/Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C7kpFIEGXAL2jxrg3WLBllXm2JX23q3dB1NJO/X8Mnc=; b=jlEL/uwZ4VptMluEOGnyn2xRwyQj/3Lps9kDuWM+yVduNAYZs7dQNOB3HrRA3Rd7wuTfNw/VDdoFfHw9CIIZsenb7REqxueJhPl9bnjoMCRt8+G1SDBKqDnIFjIIrhBwXxbsWGeID4w+EtkkXblKovuTi8UsiyXxAfDBikMCSbvrksg9lrJcWgtKeu57o+/9w0iJDSzfxdelTj5WFD+rLhzdzUkF2len1peE82yCgHMmop3d+fKrbdmr6bvCuY4XHBwIv0gzohR3Kr/lZHLkNPQYxNmMzp14L5VNa1+wY7ed0/FFvZ2EFwcFvNomwziY5Lwx39+1ydwy2VDMguafBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C7kpFIEGXAL2jxrg3WLBllXm2JX23q3dB1NJO/X8Mnc=; b=a9bNWB0czrULeACNYufAhbB0njSuB7G7WhlEQnbCqxRzMmCNgm8AQl3fQK2NFs50/T1virNX2tohHikbKVOgl6DtCNDsVxbJOgBx9zWwdw98M6G4G0eKwgQVkjAemrbyNrogbu92aRdCBBw0eb1gqq71HJC+CeBMgkswSOlecCI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Thu, 4 May 2023 18:24:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: Andrew Cooper Subject: Re: [PATCH] build: shorten macro references Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Bobby Eshleman , Alistair Francis , Connor Davis , Anthony Perard References: <95467f2c-09ed-d34f-feef-5cd55c60f628@suse.com> In-Reply-To: <95467f2c-09ed-d34f-feef-5cd55c60f628@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0139.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c4::14) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BY5PR03MB5154:EE_ X-MS-Office365-Filtering-Correlation-Id: b8fd23aa-bf9c-4d7b-3be5-08db4cc45ee9 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KkCr7y8gikwIUmV7PH6AhySvaN+dlksWHARQPZp1I8sOeSTz9qh6jUVPhol6YYpDlMi8Zl7Zqsmh3ovnC5cJahob+MsdBwcMNtFBUYlUGhE/MuTYX5OLA90zhweJmX9QUBcMYTy8iU5n0eNYuji9wXdmRg77wHaACsui9/mfya9HBcINxGLNJ+uCcmjtTiNd4qEihDQre/G0DDVkagzaI5fHoEa4e2Fy9oe1+B4xkTwp6qf91kuYwSq/InhK9RDQOBYF3x0vcPhIr8S/+OBNzKScPOmjAPXKIrLr8gPtHd1yp81J8mxyskbSChxUVQHetfK+UvA2bJKcf8DDoBlDyLwCGM4D8IZ2g/CmNsQ1ea+i+oY27w3nhDkuQMPASB1oiTMouo6AzCSKiqUodOSUQ3F5uBVhtxiS7gldhxla12j2mF/i28wE5A7lkutFs6eUFuEs/BzC+0Jht3aQAafUGcXbXntfbUv8+dcF+HytZo/VYN580520pY/uVq1Y1xy/k+NxNqPk2lfOJXDthnbNGt1riWkggWYnnOtTbLyWIYMlGUlcU/AgenAk8JKGq7iMKANYbwnhdQ2P1kAVhjIMSjAcjFFdE8HZz6YX6gRLt4VUetp7ip81W+K/LrRXvmnfm0SdGShlvCU4fE0t8G6GOw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(366004)(376002)(136003)(346002)(451199021)(86362001)(31696002)(36756003)(6666004)(6486002)(54906003)(316002)(110136005)(4326008)(66946007)(66556008)(478600001)(66476007)(8936002)(5660300002)(41300700001)(2906002)(7416002)(8676002)(82960400001)(2616005)(186003)(38100700002)(53546011)(26005)(6512007)(6506007)(107886003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y3Rpa2tZT3NnYXhDU05YTDJ1N2o1Z2FSSDc1dEdSb054dkl3bzdWWEhPZXN0?= =?utf-8?B?TFFia2Rmd1dhMGhSblU0V3JjemRDOFlYU1paSEpDMEt2UEtHcEJWcFlVVjV3?= =?utf-8?B?SUY0RE5vZG4vR0VZWE1VeHA3KzQ4aEFQaTI5a1hWZDg5aFpzcExaVk1MVVJD?= =?utf-8?B?b3BKQTZBUVVUaElYQ3V3aCs5ZFdZb1RYVTluV01ndW5iMkFwWnAwdGFjN2lw?= =?utf-8?B?SG5JbEhvc1g3dXdnODBhTGIvSitFRmtvelYyOUh6MUphQzM3UXM2aEFnV2Ew?= =?utf-8?B?V0lQYVFIb3BrcFhzODIrQkd0QnJBUzRpUjdlVXQvaGJQeHVSQ2NQMlhUblMr?= =?utf-8?B?VGloaGVKRUhEREdPZW9QV1RQZFJJSG9zcTgvQTQzbXpUd1Znc2xPbjRqZktJ?= =?utf-8?B?U3N5amVScDQzREZjQXU0cjBsQjgzMnFSdndrb0V2Mkd4MkRpNHF5MDdHU2dp?= =?utf-8?B?TDJCbW1TcFFFQkQ0N0pCbmNuWHJ3Uk45RVR3djcwbElGaWtGVEpTMjczbGs2?= =?utf-8?B?dTNyY3J5ZFBHcFEzNmpMWWltZVUrNEZRYko1eDhsY3Z2anpkL1JDWjlqMTVO?= =?utf-8?B?ZkE5dTA2cTN0OCtLdlBaY1VPRS94MEpuQmhmMjVKTmE2SzN6a3gwR1ZzYkZY?= =?utf-8?B?VFpQTlVuNmd6TUp4U1NwUGl3SlNabHdoR2pHakdIYitvTUFNZUR4dmxlbWs2?= =?utf-8?B?NWg1aitqQkZTbFl2V29OemFLSEt2Zk9EZmFueDdJSjRQNGhsL2ltTDNFRlp3?= =?utf-8?B?RktzWDVra3F5a1ppdWlpK3FUejlSaXVZRXdEbk5BdXZ6M0wyUkkzMm9TWm5F?= =?utf-8?B?TDBNWVJtbkFsazlEZk0xVDhHSnhPTURqVGg3dEFNVWQxSzF3b2tmWE9SRlVF?= =?utf-8?B?a1lLT2tpTW9qRHJ3VXllUjZkL2Y2bENoSm8rMEhQak9wNG5wZy9hci9PL0w4?= =?utf-8?B?WUh5WDZZS2RpRGJIY3ovL1JqaFBkcEgvaFJIZGJOY2ZZVlZWakMvelB3WnUw?= =?utf-8?B?bXBBRTJxZERBVlllRGJMT283QzNlL1p2MzFiNDBIN09jK0dBVjQ3RUNRZ1JJ?= =?utf-8?B?R3Z5WjQ1bW56N3M2Qi93MGU5YURQS0dwbGZvTGVrREpXcFYyRDFLM0hIMXFu?= =?utf-8?B?RjRoSmxoc3U2cnc2OEovWUhVZmNiTEZhNkd1QnZCWFIwdEtobndtY1lDUkh5?= =?utf-8?B?RUlvN1k1Y3pwWXRhdE5UZGorTHFyMXgxUEFaSEw5TDZ0Umw1SkQwM3pmb2gv?= =?utf-8?B?d1ZIR0dXM0o5a2RTTUloV2JWeThUTnZJd2FaRWdkYlkySFpLSmt1SVdVcFBs?= =?utf-8?B?Z08xbXcyaEtidVpDcnVudlFuKy9xYUtHbEo5NUJITjhDall3b3RDSTMxM0xL?= =?utf-8?B?NER0My9jRzFOUVNiK3JmM0w1c09Ed3FMZkNmSS91V0lxSmQ4cmxkM0ZwVGRX?= =?utf-8?B?Nlpka2JPNFdOcHFTYWFwS2dpZ0lVK1NIdk5BdFlLMUE3NXA3aTVBeEk4ZHhC?= =?utf-8?B?M1VxZElzZUQ1NXF1NFhpL0cyclVvcXpEQWRjSXF2MnJYY1ZGRDhudVU5UnM5?= =?utf-8?B?QWpsUFhPbVJmNVFRTjByNk95M1dOUG1yQndkcnA4enlaREVUVmZuMy9TdUlZ?= =?utf-8?B?bmhER2NPbXRVQVNtZEpuN0tUOTZ3eENBTzYyTXI0SGlGY0dVa3hrNW1WWHJx?= =?utf-8?B?VGdQVzJsYkgyWU1OM3IzcG9ESXhLWmpCajlhbWlMZjJvaEE5VkNaRmJiRXN4?= =?utf-8?B?T2Yvd0JoSTQydlNEUTNSVmZ1N3ptcEZDNmZqc2xsK1ZLUTlkRjZJT2xJVnIw?= =?utf-8?B?U25aanR5NDVCVjY4NkpqSjQ2TWtkNkxQMnUrbzdjTWxISUZxQS80NGY4dDNk?= =?utf-8?B?dEZBRGxKV2NEUS9RZGYzSnhCWjlTWjBOaUkranFsQ0gxaEp1UjlxeVNsaXRn?= =?utf-8?B?NlI0S3RMK00vdUNiMGM1ZXJ5aHlWb1RTMFdQdHQyUm43UVFBVmdLWHZyalJ3?= =?utf-8?B?ck5jcVRXUjNhdEw5aVBlUDZiOUFDeDhldE9iMUJ1NVBxRWZpanYvNGFKaUQ3?= =?utf-8?B?OE5uV25idThRRVNnMDdkc2xoVWVCZUF5ZWRyOUt1NzFxcFlBSFpiUzR3TEwv?= =?utf-8?B?OVhDVHhFTHF0QWE3SWJtZWdONm4zTTdBWDMzRER4Tk9WTjVoUktoajBsZDh2?= =?utf-8?B?ZHc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?WnFKQ09ma1hSVWZUN2hrTkg1UGVrN0hYQnZTUWR2aTlZWlByVVo2b1pMcHRS?= =?utf-8?B?SE92UEVQYmNPQzFQUC9meDNPQlR0eERQemRoZTUydjByZ0piVVZOcGtwZzNP?= =?utf-8?B?Sk5HeWw2azlYL0ZobXlBbkE4WEk2bkpybXFnMHplSnUrcmNCVkY3amN0VzNN?= =?utf-8?B?YnZQTEF0dVVRSmx6cDZvSWhUeTllL3FIYm4zVVFhN3paeU9SdzNaSVdUd09B?= =?utf-8?B?Y2t2RTI3MGxVODIxUmh2eW14SzBJbjhaSW54WS9QaHYrNkV3S2JQbUZxMXBX?= =?utf-8?B?RGNmeXBlWU1tWUpBZ3BIV21NSXFwdzB6MUw2ZUUzdnB2WHlaUGorK2gwaS9E?= =?utf-8?B?QUp2czhWQnJaTDUvellFVlp3blNGYTFBYk1VeEZId3ozUFRrbXNHQmNDQVpr?= =?utf-8?B?Ty9qQVIzSzgwT3V4aWpWYjVvU25OZWtHbnNPVkN4bVZFaVUrVjNLZXZEbHZJ?= =?utf-8?B?cncrUnZDV0FmSkQ2aGEvYkdEZVpTNFJYODBtaml6cXRGVmxkclZYWS92MGFS?= =?utf-8?B?QkZVcUFoYnhxb0ZGNnRnM0YrejJseXZ1cU9HcThpRG9OL0owaHJGRm9ZRmJC?= =?utf-8?B?dFQ4UnprUm13QU43STBvQ1dhaUpCdndqdlVJZmhRSGhieGg2RGc2enhvMXMy?= =?utf-8?B?SWlGVUVsUUhrZUY1dFQzcml0YTlyM1hGTFhaRUpXS1FvZlR6ZTViVkc1WnpV?= =?utf-8?B?bmVTb2xxOXg3TTF0VWc3YTgyVlpCbk5RMEZMZW0rUGJ2UWltaGQyanpvUmI5?= =?utf-8?B?V3UxM01abnlBckZobURSZ2JVZ0wwb0Q5TG9wOUFldjF2eTV3VTZCWWVEcVZa?= =?utf-8?B?TUU5M0RoMHQyMEtmV0JQZERsZ1JRV3d3SDU4SUl0QVI4aUp4clcwcmt3K0NT?= =?utf-8?B?Z3JBV1RJSmdXZFloWWZ4b0tkM2NDRHVid2RiSG5yWWhsQXVwaEwvM21zUTNj?= =?utf-8?B?U2VySW40bCtIdTZndVN3bXgrYVdyMzdYSFV1S3llYkxUazRnM29qWjcxOTEx?= =?utf-8?B?cTJJck1QZjIzZTZFTHdXVVh1b1pXTkY1dTdVRHhrSnRZL3o0R3ZPK1ZiWkZy?= =?utf-8?B?TDg1c3V5TzlYOWdzUXVDL0VqTVNTcUoreHFLQ01SQmcyMEtJNlI4RkZaMkFh?= =?utf-8?B?K1lWM0x3SEt6VEY1WTdwenIvRFh5bmdlRDMzOFhPOVdWcDBMWkFrQ040c3VN?= =?utf-8?B?dkhSOTBTWlpubDR1Z0NOUzZ1SFV0Szc3YXViWVIrN0pWUzQ0SjdhM0l3Q0dr?= =?utf-8?Q?1ZgW3GtibGCWZpJ?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: b8fd23aa-bf9c-4d7b-3be5-08db4cc45ee9 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 17:24:09.7064 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kWVxmrHe7n4Q4UENgjtBsLadXRO5dADC2MT4BMDwlfuhZjMEvomMVedQbnW1gsBV0ffulx4irvdzUIesOMOJ3ZSzoWjTJvrlRcU9Rm5KLwo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5154 On 04/05/2023 5:16 pm, Jan Beulich wrote: > Presumably by copy-and-paste we've accumulated a number of instances of > $(@D)/$(@F), which really is nothing else than $@. The split form only > needs using when we want to e.g. insert a leading . at the beginning of > the file name portion of the full name. >From the Kbuild work, we have $(dot-target) now which is marginally more legible than $(@D)/.$(@F), and we ought to use it consistently. > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper , although ... > > --- a/xen/arch/arm/Makefile > +++ b/xen/arch/arm/Makefile > @@ -104,9 +104,9 @@ $(TARGET)-syms: $(objtree)/prelink.o $(o > $(MAKE) $(build)=$(@D) $(@D)/.$(@F).1.o > $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ > $(@D)/.$(@F).1.o -o $@ > - $(NM) -pa --format=sysv $(@D)/$(@F) \ > + $(NM) -pa --format=sysv $@ \ > | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ > - >$(@D)/$(@F).map > + >$@.map ... any chance we can get a space between > and $ like we do almost everywhere else? ~Andrew From xen-devel-bounces@lists.xenproject.org Thu May 04 17:52:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 17:52:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529859.824753 (Exim 4.92) (envelope-from ) id 1pud7i-0001vm-Hm; Thu, 04 May 2023 17:52:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529859.824753; Thu, 04 May 2023 17:52:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pud7i-0001vf-F3; Thu, 04 May 2023 17:52:10 +0000 Received: by outflank-mailman (input) for mailman id 529859; Thu, 04 May 2023 17:52:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pud7h-0001vZ-Nu for xen-devel@lists.xenproject.org; Thu, 04 May 2023 17:52:09 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6249d2d0-eaa4-11ed-b226-6b7b168915f2; Thu, 04 May 2023 19:52:08 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6249d2d0-eaa4-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683222728; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=+AX9GvpkHcVGZxhJWoF4UtlFKnkzWIF8vzMgw+7xYOc=; b=aap9eJAVbs8F9CGsX8ah4EbpcAsTYOtLZjds/HH3wWnIsz77bpllewow mTGE0v4EYmuln3+hUayJ69gt5hMBYH4oYyigdJ1asz3xZtiX1cc0+c8RU N3dByxeiIWoDr1vxp/B9VgLRaFReKb3occ9aq3fSDwYAusnU3AH+B+OFO k=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 106662397 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:zg5HPako7D49vO6JQTWjybHo5gz6JkRdPkR7XQ2eYbSJt1+Wr1Gzt xJLWDzXbvuNMDT1LYwlPYq28E4E68fRytdmHVds+yhmFSMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aWaVA8w5ARkPqgW5AOGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 aQKMCA0ZBuJvOun6eyraPRyt4cFLPC+aevzulk4pd3YJfMvQJSFSKTW/95Imjw3g6iiH96HO ZBfM2A2Kk2dPVsWYAx/5JEWxY9EglH9fjteqVyYv+w37nLZwRZt+LPsLMDUapqBQsA9ckOw/ zqYoTqjWUBFXDCZ4Rmo+HmFgrHioQ32ALgOBKGy/dh3uHTGkwT/DzVJDADm8JFVkHWWS99Zb kAZ5Ccqhawz71CwCMnwWQWip3yJtQJaXMBfe8U44gyQzqvf4y6CG3MJCDVGbbQOtsYwSSY7y 1yhkNbgBDgpu7qQIU9x7Z/N82n0Y3JMazZfO2ldF1BtD8TfTJ8b1gDXXu9pG6SOh8zcRyHS3 i677w4+vuBG5SIU7JlX7Wwrkhr1+MiSFldvtlqINo62xlgnPdD4PuRE/XCetK8dd9jBEzFtq VBew6CjAPYy4YZhfcBnaMEEB/mX6vmMK1UwanY/TsB6p1xBF5NOFL28AQ2Sx28zaK7ogRezP CfuVfp5vfe/xkeCY65teJ6WAM8316XmHtmNfqmKPoEXPsAoLFfYrXwGiaus4owQuBJ0zfFX1 WmzKK5A8kr2+Yw4lWHrFo/xIJcgxzwkxHO7eK0XOy+PiOLEDFbMEOdtDbd7RrxhhE9yiFmPo ok32grj40k3bdASlQGOqNZDcQxTcClibX00wuQOHtO+zsNdMDlJI5fsLXkJIOSJQ4w9ej/0w 0yA IronPort-HdrOrdr: A9a23:zh6RuKzQm7WbWefKIc4cKrPwPb1zdoMgy1knxilNoH1uH/Bw8v rE9sjzuiWE6wr5J0tQ++xoVJPvfZq+z/JICOsqXYtKNTOO0FdAR7sM0WKN+Vzd8iTFh4tg6Z s= X-Talos-CUID: 9a23:KvKc+WOS/WiKae5DADt/5HceEcoee2z0kmfyPlGJSkBpcejA X-Talos-MUID: =?us-ascii?q?9a23=3ALSFyTw3swXulUMv1MqChcaVVVTUjwImkA2kJz7g?= =?us-ascii?q?6lcTcDzBgJz2WqimPa9py?= X-IronPort-AV: E=Sophos;i="5.99,250,1677560400"; d="scan'208";a="106662397" From: Jennifer Herbert To: Xen-devel CC: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Jason Andryuk , Jennifer Herbert Subject: [PATCH v4 0/2] acpi: Make TPM version configurable. Date: Thu, 4 May 2023 17:51:44 +0000 Message-ID: <20230504175146.208936-1-jennifer.herbert@citrix.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit This patch series makes the TPM version, for which the ACPI library probes, configurable, and then add support for TPM version 2. Changes from version 3: * Omit tpm_version 0 case, to fallback to 1.2, previously intended for compatibility for unknown code. * Add checks for xenstore tpm_version field. * Convert copyright header to SPDX * Minor code style fixes. Jennifer Herbert (2): acpi: Make TPM version configurable. acpi: Add TPM2 interface definition. docs/misc/xenstore-paths.pandoc | 10 +++ tools/firmware/hvmloader/util.c | 39 +++++++++--- tools/libacpi/Makefile | 3 +- tools/libacpi/acpi2_0.h | 33 ++++++++++ tools/libacpi/build.c | 106 +++++++++++++++++++++++--------- tools/libacpi/libacpi.h | 4 +- tools/libacpi/ssdt_tpm2.asl | 27 ++++++++ 7 files changed, 184 insertions(+), 38 deletions(-) create mode 100644 tools/libacpi/ssdt_tpm2.asl -- 2.39.1 From xen-devel-bounces@lists.xenproject.org Thu May 04 17:52:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 17:52:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529860.824763 (Exim 4.92) (envelope-from ) id 1pud7w-0002Dr-QE; Thu, 04 May 2023 17:52:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529860.824763; Thu, 04 May 2023 17:52:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pud7w-0002Dk-Ne; Thu, 04 May 2023 17:52:24 +0000 Received: by outflank-mailman (input) for mailman id 529860; Thu, 04 May 2023 17:52:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pud7v-0002DN-EY for xen-devel@lists.xenproject.org; Thu, 04 May 2023 17:52:23 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 69803ca4-eaa4-11ed-8611-37d641c3527e; Thu, 04 May 2023 19:52:20 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 69803ca4-eaa4-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683222740; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5qFBWRn+htczPnXVdTK5WICwefSMT3Q2LMY9OHfchM4=; b=di6sE8CNnl09xf4LGxLiO+Kzt+0Aus/H6DQs5PSKnFT+lfi/wK82A32s y537SKQsYts/4NF03aJ7KmYegZiknnTjCuaBD0Nc/8up1TKY/HiWaIU4E qGgSY8XZ8wNjJx/kZtrB6NH0GtRpLQo86GFKvf0+u0+9rq2Dbujb3FZkC o=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 107227937 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:geWnQaqe30qjIUNIurtNiu97iL1eBmJjZRIvgKrLsJaIsI4StFCzt garIBmPOKmOZGb0eYx2O9+0o0MC68ODn9FmQQpp/i8zEStGopuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WJwUmAWP6gR5weDzyVNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXABdUVkimuf2Q+p74VcdVlNoKN8LpNoxK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFOUslWcOSA3xETdxVapVSTpKQ6+S7TwRZ73aLxGNHUZsaLVYNemUPwS mfupjymWEtFZYfAodaD2kD1p+iMpyHEZLk9Gp622v56jEaK1mNGXXX6UnPk+KLk2yZSQel3O 0ESvyYjs6U23EiqVcXmGQ21pmaeuRwRUMYWFPc1gCmPwKfJ5weSBkAfUyVMLtchsaceRzUs2 kWYgtDBCjlmsbnTQnWYnop4thvrZ3JTdzVbI3ZZE01cuYKLTJwPYgznaY9bSIuLkfvPNXLv7 QmYsgEljLcZgptev0mkxmwrkw5At7CQEF5uvlyNDj36hu9qTNX7PtL1sDA3+d4Fdd/EFQfZ4 RDojuDEtIgz4YexeDthqQnnNJWg/L67PTLVmjaD9LFxpm32qxZPkW29iQySxXuF0e5eI1cFm GeJ5WtsCGZ7ZRNGl5NfbYOrENgNxqP9D9njXf28RoMQMsMoKFfepHkxNBP4M4XRraTRuftnZ cfznTiEVB729piLPBLpHrxAgNfHNwg1xH/JRICT8ilLJYG2PSbPIZ9caQvmUwzMxP/cyOkj2 4oFZpTiJtQ2eLGWXxQ7BqZKdAhacSRiWMGvwyGVH8baSjdb9KgaI6e56dscl0ZNxcy5Ss+gE qmBZ3Jl IronPort-HdrOrdr: A9a23:TJyWZa2jJP94q5K3v9H7AgqjBHokLtp133Aq2lEZdPU1SL3kqy nKpp8mPHDP5gr5NEtMpTnCAsm9qArnhPhICNAqTM6ftWrd2VdATrsSl7cKqgeIc0fDH4hmpN xdmsNFZ+EYY2IXsS+02njaL/8QhPSK9aC2ifzPpk0dKD2DDMlbnn9E46ugYylLrU19dP0EPY vZ4sZcvTKvdVYafq2Adxs4Y9Q= X-Talos-CUID: =?us-ascii?q?9a23=3AN3k39Wo/6zK/wCVBvO1ZGb3mUed8SiX48mj2GWP?= =?us-ascii?q?7FkhQWqO8UlSS8qwxxg=3D=3D?= X-Talos-MUID: 9a23:1KeTzgWZMAshFj7q/A21pTYhDsVX35+BBmMDvZUWt9KdJSMlbg== X-IronPort-AV: E=Sophos;i="5.99,250,1677560400"; d="scan'208";a="107227937" From: Jennifer Herbert To: Xen-devel CC: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Jason Andryuk , Jennifer Herbert Subject: [PATCH v4 1/2] acpi: Make TPM version configurable. Date: Thu, 4 May 2023 17:51:45 +0000 Message-ID: <20230504175146.208936-2-jennifer.herbert@citrix.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230504175146.208936-1-jennifer.herbert@citrix.com> References: <20230504175146.208936-1-jennifer.herbert@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit This patch makes the TPM version, for which the ACPI library probes, configurable. If acpi_config.tpm_verison is set to 1, it indicates that 1.2 (TCPA) should be probed. I have also added to hvmloader an option to allow setting this new config, which can be triggered by setting the platform/tpm_verion xenstore key. Signed-off-by: Jennifer Herbert Reviewed-by: Jason Andryuk --- CC: Jan Beulich CC: Andrew Cooper CC: Roger Pau Monné CC: Jason Andryuk v4: * Omit tpm_version 0 case, to fallback to 1.2, previously intended for compatibility for unknown code. * Add checks for xenstore tpm_version field. * Minor code style fixes. v3: * Default to probing for 1.2 TPM, if xenstore tpm_version field missing or tpm flag set, but not the TPM version. (Functional revert change in v2) * Correct TPM flag setting v2: * Split patch into two. * Default not to probe a TPM, unless tpm_version xenstore field set. * Minor code style fixes. --- docs/misc/xenstore-paths.pandoc | 9 +++++ tools/firmware/hvmloader/util.c | 28 ++++++++++---- tools/libacpi/build.c | 68 ++++++++++++++++++--------------- tools/libacpi/libacpi.h | 3 +- 4 files changed, 70 insertions(+), 38 deletions(-) diff --git a/docs/misc/xenstore-paths.pandoc b/docs/misc/xenstore-paths.pandoc index 5cd5c8a3b9..e67e164855 100644 --- a/docs/misc/xenstore-paths.pandoc +++ b/docs/misc/xenstore-paths.pandoc @@ -269,6 +269,15 @@ at the guest physical address in HVM_PARAM_VM_GENERATION_ID_ADDR. See Microsoft's "Virtual Machine Generation ID" specification for the circumstances where the generation ID needs to be changed. + +#### ~/platform/tpm_version = INTEGER [HVM,INTERNAL] + +The TPM version to be probed for. + +A value of 1 indicates to probe for TPM 1.2. +A value of 0 or an invalid value will result in no TPM being probed. +If unset, a default of 1 is assumed. + ### Frontend device paths Paravirtual device frontends are generally specified by their own diff --git a/tools/firmware/hvmloader/util.c b/tools/firmware/hvmloader/util.c index 581b35e5cf..1b733a3091 100644 --- a/tools/firmware/hvmloader/util.c +++ b/tools/firmware/hvmloader/util.c @@ -920,6 +920,8 @@ void hvmloader_acpi_build_tables(struct acpi_config *config, { const char *s; struct acpi_ctxt ctxt; + long long tpm_version = 0; + char *end; /* Allocate and initialise the acpi info area. */ mem_hole_populate_ram(ACPI_INFO_PHYSICAL_ADDRESS >> PAGE_SHIFT, 1); @@ -967,8 +969,6 @@ void hvmloader_acpi_build_tables(struct acpi_config *config, s = xenstore_read("platform/generation-id", "0:0"); if ( s ) { - char *end; - config->vm_gid[0] = strtoll(s, &end, 0); config->vm_gid[1] = 0; if ( end && end[0] == ':' ) @@ -994,13 +994,27 @@ void hvmloader_acpi_build_tables(struct acpi_config *config, if ( !strncmp(xenstore_read("platform/acpi_laptop_slate", "0"), "1", 1) ) config->table_flags |= ACPI_HAS_SSDT_LAPTOP_SLATE; - config->table_flags |= (ACPI_HAS_TCPA | ACPI_HAS_IOAPIC | - ACPI_HAS_WAET | ACPI_HAS_PMTIMER | - ACPI_HAS_BUTTONS | ACPI_HAS_VGA | - ACPI_HAS_8042 | ACPI_HAS_CMOS_RTC); + config->table_flags |= (ACPI_HAS_IOAPIC | ACPI_HAS_WAET | + ACPI_HAS_PMTIMER | ACPI_HAS_BUTTONS | + ACPI_HAS_VGA | ACPI_HAS_8042 | + ACPI_HAS_CMOS_RTC); config->acpi_revision = 4; - config->tis_hdr = (uint16_t *)ACPI_TIS_HDR_ADDRESS; + config->tpm_version = 0; + s = xenstore_read("platform/tpm_version", "1"); + tpm_version = strtoll(s, &end, 0); + + if ( end && end[0] == '\0' ) + { + switch ( tpm_version ) + { + case 1: + config->table_flags |= ACPI_HAS_TPM; + config->tis_hdr = (uint16_t *)ACPI_TIS_HDR_ADDRESS; + config->tpm_version = 1; + break; + } + } config->numa.nr_vmemranges = nr_vmemranges; config->numa.nr_vnodes = nr_vnodes; diff --git a/tools/libacpi/build.c b/tools/libacpi/build.c index fe2db66a62..bb0d0557d4 100644 --- a/tools/libacpi/build.c +++ b/tools/libacpi/build.c @@ -409,38 +409,46 @@ static int construct_secondary_tables(struct acpi_ctxt *ctxt, memcpy(ssdt, ssdt_laptop_slate, sizeof(ssdt_laptop_slate)); table_ptrs[nr_tables++] = ctxt->mem_ops.v2p(ctxt, ssdt); } - - /* TPM TCPA and SSDT. */ - if ( (config->table_flags & ACPI_HAS_TCPA) && - (config->tis_hdr[0] != 0 && config->tis_hdr[0] != 0xffff) && - (config->tis_hdr[1] != 0 && config->tis_hdr[1] != 0xffff) ) + /* TPM and its SSDT. */ + if ( config->table_flags & ACPI_HAS_TPM ) { - ssdt = ctxt->mem_ops.alloc(ctxt, sizeof(ssdt_tpm), 16); - if (!ssdt) return -1; - memcpy(ssdt, ssdt_tpm, sizeof(ssdt_tpm)); - table_ptrs[nr_tables++] = ctxt->mem_ops.v2p(ctxt, ssdt); - - tcpa = ctxt->mem_ops.alloc(ctxt, sizeof(struct acpi_20_tcpa), 16); - if (!tcpa) return -1; - memset(tcpa, 0, sizeof(*tcpa)); - table_ptrs[nr_tables++] = ctxt->mem_ops.v2p(ctxt, tcpa); - - tcpa->header.signature = ACPI_2_0_TCPA_SIGNATURE; - tcpa->header.length = sizeof(*tcpa); - tcpa->header.revision = ACPI_2_0_TCPA_REVISION; - fixed_strcpy(tcpa->header.oem_id, ACPI_OEM_ID); - fixed_strcpy(tcpa->header.oem_table_id, ACPI_OEM_TABLE_ID); - tcpa->header.oem_revision = ACPI_OEM_REVISION; - tcpa->header.creator_id = ACPI_CREATOR_ID; - tcpa->header.creator_revision = ACPI_CREATOR_REVISION; - if ( (lasa = ctxt->mem_ops.alloc(ctxt, ACPI_2_0_TCPA_LAML_SIZE, 16)) != NULL ) + switch ( config->tpm_version ) { - tcpa->lasa = ctxt->mem_ops.v2p(ctxt, lasa); - tcpa->laml = ACPI_2_0_TCPA_LAML_SIZE; - memset(lasa, 0, tcpa->laml); - set_checksum(tcpa, - offsetof(struct acpi_header, checksum), - tcpa->header.length); + case 1: + if ( config->tis_hdr[0] == 0 || config->tis_hdr[0] == 0xffff || + config->tis_hdr[1] == 0 || config->tis_hdr[1] == 0xffff ) + break; + + ssdt = ctxt->mem_ops.alloc(ctxt, sizeof(ssdt_tpm), 16); + if (!ssdt) return -1; + memcpy(ssdt, ssdt_tpm, sizeof(ssdt_tpm)); + table_ptrs[nr_tables++] = ctxt->mem_ops.v2p(ctxt, ssdt); + + tcpa = ctxt->mem_ops.alloc(ctxt, sizeof(struct acpi_20_tcpa), 16); + if (!tcpa) return -1; + memset(tcpa, 0, sizeof(*tcpa)); + table_ptrs[nr_tables++] = ctxt->mem_ops.v2p(ctxt, tcpa); + + tcpa->header.signature = ACPI_2_0_TCPA_SIGNATURE; + tcpa->header.length = sizeof(*tcpa); + tcpa->header.revision = ACPI_2_0_TCPA_REVISION; + fixed_strcpy(tcpa->header.oem_id, ACPI_OEM_ID); + fixed_strcpy(tcpa->header.oem_table_id, ACPI_OEM_TABLE_ID); + tcpa->header.oem_revision = ACPI_OEM_REVISION; + tcpa->header.creator_id = ACPI_CREATOR_ID; + tcpa->header.creator_revision = ACPI_CREATOR_REVISION; + + lasa = ctxt->mem_ops.alloc(ctxt, ACPI_2_0_TCPA_LAML_SIZE, 16); + if ( lasa ) + { + tcpa->lasa = ctxt->mem_ops.v2p(ctxt, lasa); + tcpa->laml = ACPI_2_0_TCPA_LAML_SIZE; + memset(lasa, 0, tcpa->laml); + set_checksum(tcpa, + offsetof(struct acpi_header, checksum), + tcpa->header.length); + } + break; } } diff --git a/tools/libacpi/libacpi.h b/tools/libacpi/libacpi.h index a2efd23b0b..f69452401f 100644 --- a/tools/libacpi/libacpi.h +++ b/tools/libacpi/libacpi.h @@ -27,7 +27,7 @@ #define ACPI_HAS_SSDT_PM (1<<4) #define ACPI_HAS_SSDT_S3 (1<<5) #define ACPI_HAS_SSDT_S4 (1<<6) -#define ACPI_HAS_TCPA (1<<7) +#define ACPI_HAS_TPM (1<<7) #define ACPI_HAS_IOAPIC (1<<8) #define ACPI_HAS_WAET (1<<9) #define ACPI_HAS_PMTIMER (1<<10) @@ -66,6 +66,7 @@ struct acpi_config { uint32_t table_flags; uint8_t acpi_revision; + uint8_t tpm_version; uint64_t vm_gid[2]; unsigned long vm_gid_addr; /* OUT parameter */ -- 2.39.1 From xen-devel-bounces@lists.xenproject.org Thu May 04 17:52:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 17:52:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529861.824773 (Exim 4.92) (envelope-from ) id 1pud80-0002WD-6Q; Thu, 04 May 2023 17:52:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529861.824773; Thu, 04 May 2023 17:52:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pud80-0002W6-1x; Thu, 04 May 2023 17:52:28 +0000 Received: by outflank-mailman (input) for mailman id 529861; Thu, 04 May 2023 17:52:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pud7y-0002DN-1r for xen-devel@lists.xenproject.org; Thu, 04 May 2023 17:52:26 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6c357424-eaa4-11ed-8611-37d641c3527e; Thu, 04 May 2023 19:52:23 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6c357424-eaa4-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683222743; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=klOQO+gsr7z/KUFFtFG4HRRQMfRqAfQQnRF3fO14M6U=; b=aGrciT4Iyq2pK/SSWBJiIddXNqz2gGnHXeGji9TGW6BhfvKSBP5Nwucf OySzCWHvmSSMq+hi3xlbOFtWXomidDQofRd3uvt3esu8MR5rMz5Nb0ix6 BnwnrNDvLjPdvEKwq0qfoLB8Jr3Bnk5v4Gd62ZsDGturhtMXWz4uG6OOV Y=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 107227938 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:3MzBS6jCoJ3/JB+af6sWYyb2X161GxAKZh0ujC45NGQN5FlHY01je htvWWGFPfzZamXwc9FwbY63oE8P65CGzNNjSgBrpClgFHgb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWj0N8klgZmP6sT4QeCzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQ/cQhVSy6codiag62Vc/tyr98oLsPkadZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJYw1MYH49tL7Aan3XcTBerlObqLBx42XJxgFrzJDmMcbPe8zMTsJQ9qqdj jueoD6jXUBBZLRzzxKg1ViwnPSQkx/aG9o3TZe2sdwzrV2Mkzl75Bo+CgLg/KjRZlSFc8JSL QkY9zQjqYA29Ve3VZ/tUhugunmGsxUAHd1KHIUS6guA167V6AaxHXUfQ3hKb9lOnM0/QzAwx 0KKt9zsDD1r9raSTBqgGqy89G3of3JPdClbOHFCFFFeizX+nG0tpjWWdo5GLrGTtPG2Bh/J0 S6jtyM8jbpG2KbnyJ6HEUD7byOE/8aZFVZsvFWIAQpJ/SsiOtf7OtXABUzzqK8Zcd3HFgTpU G0swZD20QwYMX2aeMVhqs0pFarh2fuKOSa0bbVHT8h4rGTFF5JOkOltDNBCyKRBaJxslcfBO hO7hO+ozMY70IGWRaF2eZmtLM8h0LLtE9/oPtiNMIoVO8QpLVffo3AzDaJ1410BbWB2yf1vU XtlWZ/E4Ykm5VRPk2PtGrZ1PU4DzSEi32LDLa3GI+Cc+ePGPha9EO5VWGZim8hltMtoVi2Jq YcAXyZLoj0DONDDjt7/qNdLfQxWdCVqXPgbaaV/L4a+H+avI0l5Y9e5/F/rU9UNc3h9/gsQw kyAZw== IronPort-HdrOrdr: A9a23:nNu1qK+EDAiDNGvraoZuk+AQI+orL9Y04lQ7vn2ZKCYlD/Bw8v rEoB1173HJYVoqNU3I2urhBED4ewK7yXct2/hpAV7AZmjbUQmTXftfBOLZqlWLJ8SZzJ8n6U 4KScdD4bPLYWSSwvyKgzWQIpIMzNyG76yylY7lvhJQpWYDUdAZ0+7VMHf+LqQzfnggObMpUJ 6R/NBOqTaDdWR/VLXYOkU4 X-Talos-CUID: 9a23:kkGBPm/Zf6fBDyKU6VmVv2lNIpgATGL79luTPGGBG3hAU7aXQ1DFrQ== X-Talos-MUID: 9a23:4n35UQrnAxRonG6SXn4ezxRFHtty+PugNGFOybBfkcfDF3VdOyjI2Q== X-IronPort-AV: E=Sophos;i="5.99,250,1677560400"; d="scan'208";a="107227938" From: Jennifer Herbert To: Xen-devel CC: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Jason Andryuk , Jennifer Herbert Subject: [PATCH v4 2/2] acpi: Add TPM2 interface definition. Date: Thu, 4 May 2023 17:51:46 +0000 Message-ID: <20230504175146.208936-3-jennifer.herbert@citrix.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230504175146.208936-1-jennifer.herbert@citrix.com> References: <20230504175146.208936-1-jennifer.herbert@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit This patch introduces an optional TPM 2 interface definition to the ACPI table, which is to be used as part of a vTPM 2 implementation. Signed-off-by: Jennifer Herbert Reviewed-by: Jason Andryuk Acked-by: Jan Beulich --- CC: Jan Beulich CC: Andrew Cooper CC: Roger Pau Monné CC: Jason Andryuk v4: * Convert copyright header to SPDX * Continuation from patch 1 change of xenstore tpm_version field checking. * Minor code style fixes. v3: * Renamed TPM_CRB constants to better match the TPM specification. * Moved some ACPI register locations to acpi2_0.h to such that both TPM register offsets are defined together, with clearer relation. * Added additional comments to explain new constants. * Minor code style fixes. v2: * Patch split into two. * Move TPM log to 0xFED50000 * Minor code style fixes. --- docs/misc/xenstore-paths.pandoc | 3 ++- tools/firmware/hvmloader/util.c | 10 +++++++++ tools/libacpi/Makefile | 3 ++- tools/libacpi/acpi2_0.h | 33 +++++++++++++++++++++++++++ tools/libacpi/build.c | 40 +++++++++++++++++++++++++++++++++ tools/libacpi/libacpi.h | 1 + tools/libacpi/ssdt_tpm2.asl | 27 ++++++++++++++++++++++ 7 files changed, 115 insertions(+), 2 deletions(-) create mode 100644 tools/libacpi/ssdt_tpm2.asl diff --git a/docs/misc/xenstore-paths.pandoc b/docs/misc/xenstore-paths.pandoc index e67e164855..bffb8ea544 100644 --- a/docs/misc/xenstore-paths.pandoc +++ b/docs/misc/xenstore-paths.pandoc @@ -274,7 +274,8 @@ circumstances where the generation ID needs to be changed. The TPM version to be probed for. -A value of 1 indicates to probe for TPM 1.2. +A value of 1 indicates to probe for TPM 1.2, whereas a value of 2 +indicates that a TPM 2.0 using CRB should be probed. A value of 0 or an invalid value will result in no TPM being probed. If unset, a default of 1 is assumed. diff --git a/tools/firmware/hvmloader/util.c b/tools/firmware/hvmloader/util.c index 1b733a3091..b573a9c3cd 100644 --- a/tools/firmware/hvmloader/util.c +++ b/tools/firmware/hvmloader/util.c @@ -1013,6 +1013,16 @@ void hvmloader_acpi_build_tables(struct acpi_config *config, config->tis_hdr = (uint16_t *)ACPI_TIS_HDR_ADDRESS; config->tpm_version = 1; break; + + case 2: + config->table_flags |= ACPI_HAS_TPM; + config->crb_id = (uint16_t *)TPM_CRB_INTF_ID; + + mem_hole_populate_ram(TPM_LOG_AREA_ADDRESS >> PAGE_SHIFT, + TPM_LOG_SIZE >> PAGE_SHIFT); + memset((void *)TPM_LOG_AREA_ADDRESS, 0, TPM_LOG_SIZE); + config->tpm_version = 2; + break; } } diff --git a/tools/libacpi/Makefile b/tools/libacpi/Makefile index 60860eaa00..23278f6a61 100644 --- a/tools/libacpi/Makefile +++ b/tools/libacpi/Makefile @@ -25,7 +25,8 @@ C_SRC-$(CONFIG_X86) = dsdt_anycpu.c dsdt_15cpu.c dsdt_anycpu_qemu_xen.c dsdt_pvh C_SRC-$(CONFIG_ARM_64) = dsdt_anycpu_arm.c DSDT_FILES ?= $(C_SRC-y) C_SRC = $(addprefix $(ACPI_BUILD_DIR)/, $(DSDT_FILES)) -H_SRC = $(addprefix $(ACPI_BUILD_DIR)/, ssdt_s3.h ssdt_s4.h ssdt_pm.h ssdt_tpm.h ssdt_laptop_slate.h) +H_SRC = $(addprefix $(ACPI_BUILD_DIR)/, ssdt_s3.h ssdt_s4.h ssdt_pm.h) +H_SRC += $(addprefix $(ACPI_BUILD_DIR)/, ssdt_tpm.h ssdt_tpm2.h ssdt_laptop_slate.h) MKDSDT_CFLAGS-$(CONFIG_ARM_64) = -DCONFIG_ARM_64 MKDSDT_CFLAGS-$(CONFIG_X86) = -DCONFIG_X86 diff --git a/tools/libacpi/acpi2_0.h b/tools/libacpi/acpi2_0.h index 2619ba32db..3503eb3cfa 100644 --- a/tools/libacpi/acpi2_0.h +++ b/tools/libacpi/acpi2_0.h @@ -121,6 +121,37 @@ struct acpi_20_tcpa { }; #define ACPI_2_0_TCPA_LAML_SIZE (64*1024) +/* + * TPM2 + */ +struct acpi_20_tpm2 { + struct acpi_header header; + uint16_t platform_class; + uint16_t reserved; + uint64_t control_area_address; + uint32_t start_method; + uint8_t start_method_params[12]; + uint32_t log_area_minimum_length; + uint64_t log_area_start_address; +}; +#define TPM2_ACPI_CLASS_CLIENT 0 +#define TPM2_START_METHOD_CRB 7 + +/* + * TPM register I/O Mapped region, location of which defined in the + * TCG PC Client Platform TPM Profile Specification for TPM 2.0. + * See table 9 - Only Locality 0 is used here. This is emulated by QEMU. + * Definition of Register space is found in table 12. + */ +#define TPM_REGISTER_BASE 0xFED40000 +#define TPM_CRB_CTRL_REQ (TPM_REGISTER_BASE + 0x40) +#define TPM_CRB_INTF_ID (TPM_REGISTER_BASE + 0x30) + +#define TPM_LOG_AREA_ADDRESS 0xFED50000 + +#define TPM_LOG_AREA_MINIMUM_SIZE (64 << 10) +#define TPM_LOG_SIZE (64 << 10) + /* * Fixed ACPI Description Table Structure (FADT) in ACPI 1.0. */ @@ -431,6 +462,7 @@ struct acpi_20_slit { #define ACPI_2_0_RSDT_SIGNATURE ASCII32('R','S','D','T') #define ACPI_2_0_XSDT_SIGNATURE ASCII32('X','S','D','T') #define ACPI_2_0_TCPA_SIGNATURE ASCII32('T','C','P','A') +#define ACPI_2_0_TPM2_SIGNATURE ASCII32('T','P','M','2') #define ACPI_2_0_HPET_SIGNATURE ASCII32('H','P','E','T') #define ACPI_2_0_WAET_SIGNATURE ASCII32('W','A','E','T') #define ACPI_2_0_SRAT_SIGNATURE ASCII32('S','R','A','T') @@ -444,6 +476,7 @@ struct acpi_20_slit { #define ACPI_2_0_RSDT_REVISION 0x01 #define ACPI_2_0_XSDT_REVISION 0x01 #define ACPI_2_0_TCPA_REVISION 0x02 +#define ACPI_2_0_TPM2_REVISION 0x04 #define ACPI_2_0_HPET_REVISION 0x01 #define ACPI_2_0_WAET_REVISION 0x01 #define ACPI_1_0_FADT_REVISION 0x01 diff --git a/tools/libacpi/build.c b/tools/libacpi/build.c index bb0d0557d4..401113503c 100644 --- a/tools/libacpi/build.c +++ b/tools/libacpi/build.c @@ -19,6 +19,7 @@ #include "ssdt_s3.h" #include "ssdt_s4.h" #include "ssdt_tpm.h" +#include "ssdt_tpm2.h" #include "ssdt_pm.h" #include "ssdt_laptop_slate.h" #include @@ -350,6 +351,7 @@ static int construct_secondary_tables(struct acpi_ctxt *ctxt, struct acpi_20_hpet *hpet; struct acpi_20_waet *waet; struct acpi_20_tcpa *tcpa; + struct acpi_20_tpm2 *tpm2; unsigned char *ssdt; void *lasa; @@ -449,6 +451,44 @@ static int construct_secondary_tables(struct acpi_ctxt *ctxt, tcpa->header.length); } break; + + case 2: + /* + * Check VID stored in bits 37:32 (3rd 16 bit word) of CRB + * identifier register. See table 16 of TCG PC client platform + * TPM profile specification for TPM 2.0. + */ + if ( config->crb_id[2] == 0 || config->crb_id[2] == 0xffff ) + break; + + ssdt = ctxt->mem_ops.alloc(ctxt, sizeof(ssdt_tpm2), 16); + if (!ssdt) return -1; + memcpy(ssdt, ssdt_tpm2, sizeof(ssdt_tpm2)); + table_ptrs[nr_tables++] = ctxt->mem_ops.v2p(ctxt, ssdt); + + tpm2 = ctxt->mem_ops.alloc(ctxt, sizeof(struct acpi_20_tpm2), 16); + if (!tpm2) return -1; + memset(tpm2, 0, sizeof(*tpm2)); + table_ptrs[nr_tables++] = ctxt->mem_ops.v2p(ctxt, tpm2); + + tpm2->header.signature = ACPI_2_0_TPM2_SIGNATURE; + tpm2->header.length = sizeof(*tpm2); + tpm2->header.revision = ACPI_2_0_TPM2_REVISION; + fixed_strcpy(tpm2->header.oem_id, ACPI_OEM_ID); + fixed_strcpy(tpm2->header.oem_table_id, ACPI_OEM_TABLE_ID); + tpm2->header.oem_revision = ACPI_OEM_REVISION; + tpm2->header.creator_id = ACPI_CREATOR_ID; + tpm2->header.creator_revision = ACPI_CREATOR_REVISION; + tpm2->platform_class = TPM2_ACPI_CLASS_CLIENT; + tpm2->control_area_address = TPM_CRB_CTRL_REQ; + tpm2->start_method = TPM2_START_METHOD_CRB; + tpm2->log_area_minimum_length = TPM_LOG_AREA_MINIMUM_SIZE; + tpm2->log_area_start_address = TPM_LOG_AREA_ADDRESS; + + set_checksum(tpm2, + offsetof(struct acpi_header, checksum), + tpm2->header.length); + break; } } diff --git a/tools/libacpi/libacpi.h b/tools/libacpi/libacpi.h index f69452401f..0d19f9fc4d 100644 --- a/tools/libacpi/libacpi.h +++ b/tools/libacpi/libacpi.h @@ -80,6 +80,7 @@ struct acpi_config { const struct hvm_info_table *hvminfo; const uint16_t *tis_hdr; + const uint16_t *crb_id; /* * Address where acpi_info should be placed. diff --git a/tools/libacpi/ssdt_tpm2.asl b/tools/libacpi/ssdt_tpm2.asl new file mode 100644 index 0000000000..3df9d70556 --- /dev/null +++ b/tools/libacpi/ssdt_tpm2.asl @@ -0,0 +1,27 @@ +/* SPDX-License-Identifier: LGPL-2.1 */ +/* + * ssdt_tpm2.asl + * + * Copyright (c) 2018-2022, Citrix Systems, Inc. + */ + +/* SSDT for TPM CRB Interface for Xen with Qemu device model. */ + +DefinitionBlock ("SSDT_TPM2.aml", "SSDT", 2, "Xen", "HVM", 0) +{ + Device (TPM) + { + Name (_HID, "MSFT0101" /* TPM 2.0 Security Device */) // _HID: Hardware ID + Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings + { + Memory32Fixed (ReadWrite, + 0xFED40000, // Address Base + 0x00001000, // Address Length + ) + }) + Method (_STA, 0, NotSerialized) // _STA: Status + { + Return (0x0F) + } + } +} -- 2.39.1 From xen-devel-bounces@lists.xenproject.org Thu May 04 18:04:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 18:04:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529871.824783 (Exim 4.92) (envelope-from ) id 1pudJP-0004lS-8x; Thu, 04 May 2023 18:04:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529871.824783; Thu, 04 May 2023 18:04:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pudJP-0004lL-62; Thu, 04 May 2023 18:04:15 +0000 Received: by outflank-mailman (input) for mailman id 529871; Thu, 04 May 2023 18:04:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pudJO-0004lF-IJ for xen-devel@lists.xenproject.org; Thu, 04 May 2023 18:04:14 +0000 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [2a00:1450:4864:20::42e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 12baa79e-eaa6-11ed-8611-37d641c3527e; Thu, 04 May 2023 20:04:12 +0200 (CEST) Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-306281edf15so749146f8f.1 for ; Thu, 04 May 2023 11:04:11 -0700 (PDT) Received: from [192.168.2.1] (82-64-138-184.subs.proxad.net. [82.64.138.184]) by smtp.googlemail.com with ESMTPSA id q6-20020a5d5746000000b003063db8f45bsm6351649wrw.23.2023.05.04.11.04.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 May 2023 11:04:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 12baa79e-eaa6-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rabbit-lu.20221208.gappssmtp.com; s=20221208; t=1683223451; x=1685815451; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zPoy7ZjH0Hp3L3NSAKFAvrycApDT8quJeyk+IzfMzr8=; b=n740Nn8vCLMkAbNPdJ4Ss/Yj+iwdxeLduFRV5USOrUmS/rvP+eGovQmfo6kDZKkFk+ RkfGBLKiyFyqTwUTFQVmuYs51Uvfjuu9a1XBmZKadGPoJXjqrR7R9w3WRiVTEmXb191C 3gQXfFUJMYOYOdrVeuk+TZKTLNRCseERcSdLjCFxijIIr+Q8s5KrVOaURi1qd7dzAeJ3 CRGrecprB6gOoSXxKKgeCt30UH94YH3nl15ZwKBuk55omYVHA7a5mQ5P2+VU4TEy1z5v hm5p5lLC0WhYDQNp3Xp1iI+2vykSpUyh4vX+AWGYFBPiUTY8u6ojDD85i7Pv0bowga2Q YYyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683223451; x=1685815451; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zPoy7ZjH0Hp3L3NSAKFAvrycApDT8quJeyk+IzfMzr8=; b=S5LGlMmu2bu6l1IPVRnxG8jHi53d/seY9J6Klbb+2LjV777fvSGKqlXWB+nR/JGOnn pGmgPmpKF4fVBA/I2xrWeAJ8Dv4Fgh1zDglGwsWIR19vUOCgzDf1eKPhi99/A1ipWSsN 2rDz/NZpoYadYjTCRgCWVITYGs4DmCiUqW44rZjIX4FBtfDHiYDSgfgzGV55Qt3EZGz6 3/kWLQ3dBsIdE3fgUr5XI/1cpn/dcce/66XbCw2jdif01Lcu0EW8FQPUPHx1ChhwRT9l /mdxTa72m9I4ccBnR/MpkABqCL9ShvpnF2mQ9U1x4sU1j1KBYcgL2yxF/6UGyYhwFYYr 5vSA== X-Gm-Message-State: AC+VfDy0CLVE5fYnC6G942T+umybaxt2JmdNYW+G97H2SYwU6IARI9Wu S8o2gBdS3DqQf08VNR9v11aUOA== X-Google-Smtp-Source: ACHHUZ6Mo1nJZkoEy25euN2Nob3Y+z0UQWcQqryc3MNaJrMrtoUE/Nf6NS4SdUF8LM5x7J5pd1tCSw== X-Received: by 2002:a5d:42cf:0:b0:306:40dc:abd9 with SMTP id t15-20020a5d42cf000000b0030640dcabd9mr3376711wrr.71.1683223451453; Thu, 04 May 2023 11:04:11 -0700 (PDT) Message-ID: Date: Thu, 4 May 2023 20:04:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: xenstored: EACCESS error accessing control/feature-balloon 1 Content-Language: en-US To: Yann Dirson , xen-devel@lists.xenproject.org Cc: Juergen Gross , =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= , Julien Grall , Andrew Cooper References: <3065c524-07c7-6458-ff4c-ba68ff78c946@rabbit.lu> <474b531f-2067-a5d4-8b01-5b8ef1f7061d@citrix.com> <678df1ff-df18-b063-eda3-2a1aed6d40f8@vates.fr> <50bf6b82-965b-d17c-7c5a-49c703991504@rabbit.lu> From: zithro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 04 May 2023 17:59, Yann Dirson wrote: > > On 5/4/23 15:58, zithro wrote: >> Hi, >> >> [ snipped for brevity, report summary: >> XAPI daemon in domU tries to write to a non-existent xenstore node in >> a non-XAPI dom0 ] >> >> On 12 Apr 2023 18:41, Yann Dirson wrote: >>> Is there anything besides XAPI using this node, or the other data >>> published by xe-daemon? >> >> On my vanilla Xen (ie. non-XAPI), I have no node about "balloon"-ing >> in xenstore (either dom0 or domU nodes, but I'm not using ballooning >> in both). >> >>> Maybe the original issue is just that there is no reason to have >>> xe-guest-utilities installed in this setup? >> >> That's what I thought as I'm not using XAPI, so maybe the problem >> should only be addressed to the truenas team ? I posted on their forum >> but got no answer. >> I killed the 'xe-daemon' in both setups without loss of functionality. >> >> My wild guess is that 'xe-daemon', 'xe-update-guest-attrs' and all >> 'xenstore* commands' are leftovers from when Xen was working as a dom0 >> under FreeBSD (why would a *domU* have them ?). > > That would not be correct: xenstore* are useful in guests, should you > want to read/write to the XenStore manually or from scripts; Didn't know that, can you give some use cases (or URLs) for which it is useful, with or without XAPI ? I've read xenstore* man pages and could not infer a use case. Although I may already see some : updating ballooned memory values, or as Julien Grall pointed out, updating "feature-s3/4" values ? PS: small mistake in "man/xenstore-write.1.html" (from at least 4.14, and onward), the synopsis reads "xenstore-read" ieof "xenstore-read". Also, the -s option disappeared from unstable, although it may be expected. I don't know it's purpose either. > xe-deamon and xe-update-guest-attrs both come from xe-guest-utilities 6.x, which > is really a domU tool as well, but is there to support XAPI in dom0. I checked on freshports, this is effectively the last version in FreeBSD, hence FreeNAS (although the version number hasn't been updated since 2020, despite updates, so it's not clear which version I'm using). So next question is: shouldn't the installer detect if running on a XAPI Xen or not ? I imagine it's feasible, maybe via XAPI-specific xenstore nodes ? Have a nice evening From xen-devel-bounces@lists.xenproject.org Thu May 04 18:46:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 18:46:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529874.824792 (Exim 4.92) (envelope-from ) id 1pudy9-0000tK-C9; Thu, 04 May 2023 18:46:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529874.824792; Thu, 04 May 2023 18:46:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pudy9-0000tD-9B; Thu, 04 May 2023 18:46:21 +0000 Received: by outflank-mailman (input) for mailman id 529874; Thu, 04 May 2023 18:46:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pudy7-0000t7-MM for xen-devel@lists.xenproject.org; Thu, 04 May 2023 18:46:19 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f3d9d1ce-eaab-11ed-b226-6b7b168915f2; Thu, 04 May 2023 20:46:17 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f3d9d1ce-eaab-11ed-b226-6b7b168915f2 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683225976; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OIAcVs2YXBnNfaPvpuizW2PEW4lhJ1YnG6MUoZkO7aY=; b=3+tD+LTP2nHbLKQ6ayQSSKK8VpBIuQK3gXforAfUYbXvx4vM+fYGuufKzSpG2saVKOpTsV to0Q6mzIGbAQjDqsOQkje2Tja0U/TKz3F+TviP3kf+19hr3bEm6s4uGo2F+s+PdBgPIGkj gHjK9Yi0pM4GUZc5ZpONvd31Hppwcu+Bcbd8TlaOcVKhOuZIjToIAW5YXeXW3Go5sZpcCh htSi5EE8To3+PKCGlsNtyNrMRTsE8PlVdNzqWmd8pkRxZ1vMQC2VO2mXVu6cVctYauCbM0 4H8XFlx6BIILGrhdr/EBrOtC8Cm0866nFAfWkkLlHu0QtdUMHZ2jk6jWm8xf3Q== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683225976; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OIAcVs2YXBnNfaPvpuizW2PEW4lhJ1YnG6MUoZkO7aY=; b=pPb8Wqh2Bj6AkjBEVHoo9nA/DLOEH7EgQ6O+EgS1RtAjQlyepgF0Tr/3dF7rDdC5tR1PRC DisRQOSHrsQxZlDw== To: "Michael Kelley (LINUX)" , LKML Cc: "x86@kernel.org" , David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , David Woodhouse , Usama Arif , Juergen Gross , Boris Ostrovsky , "xen-devel@lists.xenproject.org" , Russell King , Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" , Catalin Marinas , Will Deacon , Guo Ren , "linux-csky@vger.kernel.org" , Thomas Bogendoerfer , "linux-mips@vger.kernel.org" , "James E.J. Bottomley" , Helge Deller , "linux-parisc@vger.kernel.org" , Paul Walmsley , Palmer Dabbelt , "linux-riscv@lists.infradead.org" , Mark Rutland , Sabin Rapan Subject: RE: [patch 00/37] cpu/hotplug, x86: Reworked parallel CPU bringup In-Reply-To: References: <20230414225551.858160935@linutronix.de> Date: Thu, 04 May 2023 20:46:15 +0200 Message-ID: <878re43pfs.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain Michael! On Thu, Apr 27 2023 at 14:48, Michael Kelley wrote: > From: Thomas Gleixner Sent: Friday, April 14, 2023 4:44 PM > > I smoke-tested several Linux guest configurations running on Hyper-V, > using the "kernel/git/tglx/devel.git hotplug" tree as updated on April 26th. > No functional issues, but encountered one cosmetic issue (details below). > > Configurations tested: > * 16 vCPUs and 32 vCPUs > * 1 NUMA node and 2 NUMA nodes > * Parallel bring-up enabled and disabled via kernel boot line > * "Normal" VMs and SEV-SNP VMs running with a paravisor on Hyper-V. > This config can use parallel bring-up because most of the SNP-ness is > hidden in the paravisor. I was glad to see this work properly. > > There's not much difference in performance with and without parallel > bring-up on the 32 vCPU VM. Without parallel, the time is about 26 > milliseconds. With parallel, it's about 24 ms. So bring-up is already > fast in the virtual environment. Depends on the environment :) > The cosmetic issue is in the dmesg log, and arises because Hyper-V > enumerates SMT CPUs differently from many other environments. In > a Hyper-V guest, the SMT threads in a core are numbered as > pairs. Guest CPUs #0 & #1 are SMT threads in core, as are #2 & #3, etc. With > parallel bring-up, here's the dmesg output: > > [ 0.444345] smp: Bringing up secondary CPUs ... > [ 0.445139] .... node #0, CPUs: #2 #4 #6 #8 #10 #12 #14 #16 #18 #20 #22 #24 #26 #28 #30 > [ 0.454112] x86: Booting SMP configuration: > [ 0.456035] #1 #3 #5 #7 #9 #11 #13 #15 #17 #19 #21 #23 #25 #27 #29 #31 > [ 0.466120] smp: Brought up 1 node, 32 CPUs > [ 0.467036] smpboot: Max logical packages: 1 > [ 0.468035] smpboot: Total of 32 processors activated (153240.06 BogoMIPS) > > The function announce_cpu() is specifically testing for CPU #1 to output the > "Booting SMP configuration" message. In a Hyper-V guest, CPU #1 is the second > SMT thread in a core, so it isn't started until all the even-numbered CPUs are > started. Ah. Didn't notice that because SMT siblings are usually enumerated after all primary ones in ACPI. > I don't know if this cosmetic issue is worth fixing, but I thought I'd point it out. That's trivial enough to fix. I'll amend the topmost patch before posting V2. Thanks for giving it a ride! tglx From xen-devel-bounces@lists.xenproject.org Thu May 04 18:48:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 18:48:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529877.824802 (Exim 4.92) (envelope-from ) id 1pudzf-0001Qp-NR; Thu, 04 May 2023 18:47:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529877.824802; Thu, 04 May 2023 18:47:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pudzf-0001Qi-Kh; Thu, 04 May 2023 18:47:55 +0000 Received: by outflank-mailman (input) for mailman id 529877; Thu, 04 May 2023 18:47:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pudzd-0001QU-Kq; Thu, 04 May 2023 18:47:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pudzd-0006Sp-Bw; Thu, 04 May 2023 18:47:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pudzc-0006Wb-SI; Thu, 04 May 2023 18:47:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pudzc-0003ar-Rm; Thu, 04 May 2023 18:47:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Jd4tqMh94nxAFtcL3IuvD56wAwIQCkHfrRc5dvBrkkQ=; b=paJQuS9CKXMztABLjimo1lFZ6J 2aT/wV84FHBQcysE3MNfnkmDMUD4fVJgQaAjp1DRddIxuiJv3+N4Bg1SfqL7eQTagHFsCShwm/iUF mSvhG3a+eUvfYCcYkoUt1YBPP6hn7+Hunp1vSspbrPUgZjPMdoUhh8NHeJqy8frmR4FQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180532: all pass - PUSHED X-Osstest-Versions-This: ovmf=4b02045f86d6aac8a617bf3f65f9cb2146630ce3 X-Osstest-Versions-That: ovmf=d6b42ed7ed1b0c4584097f0d76798cff74c96379 From: osstest service owner Date: Thu, 04 May 2023 18:47:52 +0000 flight 180532 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180532/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 4b02045f86d6aac8a617bf3f65f9cb2146630ce3 baseline version: ovmf d6b42ed7ed1b0c4584097f0d76798cff74c96379 Last test of basis 180508 2023-05-02 16:10:54 Z 2 days Testing same since 180532 2023-05-04 14:40:45 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Gerd Hoffmann Oliver Steffen Patrik Berglund Pierre Gondois jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git d6b42ed7ed..4b02045f86 4b02045f86d6aac8a617bf3f65f9cb2146630ce3 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu May 04 19:02:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:02:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529887.824843 (Exim 4.92) (envelope-from ) id 1pueDO-0004md-Om; Thu, 04 May 2023 19:02:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529887.824843; Thu, 04 May 2023 19:02:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDO-0004mU-LO; Thu, 04 May 2023 19:02:06 +0000 Received: by outflank-mailman (input) for mailman id 529887; Thu, 04 May 2023 19:02:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDN-00042k-Ol for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:05 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2854e7bf-eaae-11ed-8611-37d641c3527e; Thu, 04 May 2023 21:02:04 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2854e7bf-eaae-11ed-8611-37d641c3527e Message-ID: <20230504185936.480193035@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226923; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=Eo225NP0lj/KI2zgHR0OIjiIzH0Ctds/GymtbPvmwBU=; b=LT/pOG5ZQQZ4Xkdn780R40Y7lueqSZR9oNFurLJq5jRV+Eu/Z/jjyhKXcNyYjcCaq3OxeZ D2BFgv0ZO2Yf12YjG235klE3IV29/RVeRocRuGfGAjifygXZaaoDJGgVt3+VOUiu6ohxFY p+SEyhTtLcmwBOdSZGNp6YT7r03nx+0ZjhTXH5U8LULRcg9p9u1Xn+PZrAfH0AGtejHGc2 1WhTgb8mnl3tB5GijGDHQHQsbB76zY/aLri5dB0ODauWKsUjq6zqrj/wdK3i0TilxS51J9 6cNAT2zbq0mtuwkLISVz29ZrTYOY6WH2fUJB84fiM72rjbd3hSxTAIA7/5hPnQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226923; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=Eo225NP0lj/KI2zgHR0OIjiIzH0Ctds/GymtbPvmwBU=; b=c5fBzhVL9IXHiAIx3H5VnWToAYIP+2Zl7riSaIQdNQo8s6Prq7ZCnHaTOt6HvVUYoRs7oU ozupCaSo8Ov1mvAw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch V2 03/38] x86/smpboot: Avoid pointless delay calibration if TSC is synchronized References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:03 +0200 (CEST) From: Thomas Gleixner When TSC is synchronized across sockets then there is no reason to calibrate the delay for the first CPU which comes up on a socket. Just reuse the existing calibration value. This removes 100ms pointlessly wasted time from CPU hotplug per socket. Signed-off-by: Thomas Gleixner --- arch/x86/kernel/smpboot.c | 38 ++++++++++++++++++++++++-------------- arch/x86/kernel/tsc.c | 20 ++++++++++++++++---- 2 files changed, 40 insertions(+), 18 deletions(-) --- --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -178,10 +178,7 @@ static void smp_callin(void) */ apic_ap_setup(); - /* - * Save our processor parameters. Note: this information - * is needed for clock calibration. - */ + /* Save our processor parameters. */ smp_store_cpu_info(cpuid); /* @@ -192,14 +189,6 @@ static void smp_callin(void) ap_init_aperfmperf(); - /* - * Get our bogomips. - * Update loops_per_jiffy in cpu_data. Previous call to - * smp_store_cpu_info() stored a value that is close but not as - * accurate as the value just calculated. - */ - calibrate_delay(); - cpu_data(cpuid).loops_per_jiffy = loops_per_jiffy; pr_debug("Stack at about %p\n", &cpuid); wmb(); @@ -212,8 +201,24 @@ static void smp_callin(void) cpumask_set_cpu(cpuid, cpu_callin_mask); } +static void ap_calibrate_delay(void) +{ + /* + * Calibrate the delay loop and update loops_per_jiffy in cpu_data. + * smp_store_cpu_info() stored a value that is close but not as + * accurate as the value just calculated. + * + * As this is invoked after the TSC synchronization check, + * calibrate_delay_is_known() will skip the calibration routine + * when TSC is synchronized across sockets. + */ + calibrate_delay(); + cpu_data(smp_processor_id()).loops_per_jiffy = loops_per_jiffy; +} + static int cpu0_logical_apicid; static int enable_start_cpu0; + /* * Activate a secondary processor. */ @@ -240,10 +245,15 @@ static void notrace start_secondary(void /* otherwise gcc will move up smp_processor_id before the cpu_init */ barrier(); + /* Check TSC synchronization with the control CPU: */ + check_tsc_sync_target(); + /* - * Check TSC synchronization with the boot CPU: + * Calibrate the delay loop after the TSC synchronization check. + * This allows to skip the calibration when TSC is synchronized + * across sockets. */ - check_tsc_sync_target(); + ap_calibrate_delay(); speculative_store_bypass_ht_init(); --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -1598,10 +1598,7 @@ void __init tsc_init(void) #ifdef CONFIG_SMP /* - * If we have a constant TSC and are using the TSC for the delay loop, - * we can skip clock calibration if another cpu in the same socket has already - * been calibrated. This assumes that CONSTANT_TSC applies to all - * cpus in the socket - this should be a safe assumption. + * Check whether existing calibration data can be reused. */ unsigned long calibrate_delay_is_known(void) { @@ -1609,6 +1606,21 @@ unsigned long calibrate_delay_is_known(v int constant_tsc = cpu_has(&cpu_data(cpu), X86_FEATURE_CONSTANT_TSC); const struct cpumask *mask = topology_core_cpumask(cpu); + /* + * If TSC has constant frequency and TSC is synchronized across + * sockets then reuse CPU0 calibration. + */ + if (constant_tsc && !tsc_unstable) + return cpu_data(0).loops_per_jiffy; + + /* + * If TSC has constant frequency and TSC is not synchronized across + * sockets and this is not the first CPU in the socket, then reuse + * the calibration value of an already online CPU on that socket. + * + * This assumes that CONSTANT_TSC is consistent for all CPUs in a + * socket. + */ if (!constant_tsc || !mask) return 0; From xen-devel-bounces@lists.xenproject.org Thu May 04 19:02:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:02:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529885.824818 (Exim 4.92) (envelope-from ) id 1pueDM-00045K-CC; Thu, 04 May 2023 19:02:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529885.824818; Thu, 04 May 2023 19:02:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDM-00044v-6c; Thu, 04 May 2023 19:02:04 +0000 Received: by outflank-mailman (input) for mailman id 529885; Thu, 04 May 2023 19:02:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDK-00042k-Py for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:02 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 25ed47b2-eaae-11ed-8611-37d641c3527e; Thu, 04 May 2023 21:02:00 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 25ed47b2-eaae-11ed-8611-37d641c3527e Message-ID: <20230504185733.126511787@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226919; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc; bh=Owpn3VAzXYYF5pE4nW59O5YtNe6oATS3CJHH6pOEc+Q=; b=ydWEHvQKju6ua5QrgIvoNFizD1mp/ScmeGKoSzoDnG7Bbtt8/QnpnQ3+taJ6G0kL830h+i 7ID/utgQdKCvUYsl6w6CO2W2gJuO8HL9LCU4D0vVfB6YxemlrHUeCt4ToRjPCaRBB5yHoD U1z1RXcQdP2U5KMvTNzHXSugPczS5MTUtGDtT8qHk2Yf+N4IEi6AoiUHeLjn63zurjgLOd 4VlOYXYRkaR1ek5ywemLfh9oakl4kmjQRYWBDRl/UvRYBt4y2JOaZBadJTEhsdykMmsR/p RzfI1eYCgw7RPP+JveXpGF8/O3jsZY1WVFPEdOuBnlsQhWH5/KilpYnEwkhH7g== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226919; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc; bh=Owpn3VAzXYYF5pE4nW59O5YtNe6oATS3CJHH6pOEc+Q=; b=t9YK5Y1XQbyMkzjkBl9J4dD0O18uiVWSVJxE2v987VhpllLfPD1+SKL0rJE7GDXI8icRF3 WCaTcXYHj80XrzAw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch V2 00/38] cpu/hotplug, x86: Reworked parallel CPU bringup Date: Thu, 4 May 2023 21:01:58 +0200 (CEST) Hi! This is version 2 of the reworked parallel bringup series. Version 1 can be found here: https://lore.kernel.org/lkml/20230414225551.858160935@linutronix.de Background ---------- The reason why people are interested in parallel bringup is to shorten the (kexec) reboot time of cloud servers to reduce the downtime of the VM tenants. The current fully serialized bringup does the following per AP: 1) Prepare callbacks (allocate, intialize, create threads) 2) Kick the AP alive (e.g. INIT/SIPI on x86) 3) Wait for the AP to report alive state 4) Let the AP continue through the atomic bringup 5) Let the AP run the threaded bringup to full online state There are two significant delays: #3 The time for an AP to report alive state in start_secondary() on x86 has been measured in the range between 350us and 3.5ms depending on vendor and CPU type, BIOS microcode size etc. #4 The atomic bringup does the microcode update. This has been measured to take up to ~8ms on the primary threads depending on the microcode patch size to apply. On a two socket SKL server with 56 cores (112 threads) the boot CPU spends on current mainline about 800ms busy waiting for the APs to come up and apply microcode. That's more than 80% of the actual onlining procedure. By splitting the actual bringup mechanism into two parts this can be reduced to waiting for the first AP to report alive or if the system is large enough the first AP is already waiting when the boot CPU finished the wake-up of the last AP. That reduces the AP bringup time on that SKL from ~800ms to ~80ms. The actual gain varies wildly depending on the system, CPU, microcode patch size and other factors. The V1 cover letter has more details and a deep analysis. Changes vs. V1: 1) Switch APIC ID retrieval from CPUID to reading the APIC itself. This is required because CPUID based APIC ID retrieval can only provide the initial APIC ID, which might have been overruled by the firmware. Some AMD APUs come up with APIC ID = initial APIC ID + 0x10, so the APIC ID to CPU number lookup would fail miserably if based on CPUID. The only requirement is that the actual APIC IDs are consistent with the APCI/MADT table. 2) As a consequence of #1 parallel bootup support for SEV guest has been dropped. Reading the APIC ID in a SEV guest is done via RDMSR. That RDMSR is intercepted and raises #VC which cannot be handled at that point as there is no stack and no IDT. There is no GHCB protocol for RDMSR like there is for CPUID. Left as an exercise for SEV wizards. 3) Address review comments from Brian and the fallout reported by the kernel robot 4) Unbreak i386 which exploded when bringing up the secondary CPUs due to the unconditinal load_ucode_ap() invocation in start_secondary(). That happens because on 32-bit load_ucode_ap() is invoked on the secondary CPUs from assembly code before paging is initialized and therefore uses physical addresses which are obviously invalid after paging is enabled. 5) Small enhancements and comment updates. 6) Rebased on Linux tree (1a5304fecee5) The series applies on Linus tree and is also available from git: git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git hotplug Thanks, tglx --- Documentation/admin-guide/kernel-parameters.txt | 20 Documentation/core-api/cpu_hotplug.rst | 13 arch/Kconfig | 23 + arch/arm/Kconfig | 1 arch/arm/include/asm/smp.h | 2 arch/arm/kernel/smp.c | 18 arch/arm64/Kconfig | 1 arch/arm64/include/asm/smp.h | 2 arch/arm64/kernel/smp.c | 14 arch/csky/Kconfig | 1 arch/csky/include/asm/smp.h | 2 arch/csky/kernel/smp.c | 8 arch/mips/Kconfig | 1 arch/mips/cavium-octeon/smp.c | 1 arch/mips/include/asm/smp-ops.h | 1 arch/mips/kernel/smp-bmips.c | 1 arch/mips/kernel/smp-cps.c | 14 arch/mips/kernel/smp.c | 8 arch/mips/loongson64/smp.c | 1 arch/parisc/Kconfig | 1 arch/parisc/kernel/process.c | 4 arch/parisc/kernel/smp.c | 7 arch/riscv/Kconfig | 1 arch/riscv/include/asm/smp.h | 2 arch/riscv/kernel/cpu-hotplug.c | 14 arch/x86/Kconfig | 45 -- arch/x86/include/asm/apic.h | 5 arch/x86/include/asm/apicdef.h | 5 arch/x86/include/asm/cpu.h | 5 arch/x86/include/asm/cpumask.h | 5 arch/x86/include/asm/processor.h | 1 arch/x86/include/asm/realmode.h | 3 arch/x86/include/asm/smp.h | 24 - arch/x86/include/asm/topology.h | 23 - arch/x86/include/asm/tsc.h | 2 arch/x86/kernel/acpi/sleep.c | 9 arch/x86/kernel/apic/apic.c | 26 - arch/x86/kernel/callthunks.c | 4 arch/x86/kernel/cpu/amd.c | 2 arch/x86/kernel/cpu/cacheinfo.c | 21 arch/x86/kernel/cpu/common.c | 50 -- arch/x86/kernel/cpu/topology.c | 3 arch/x86/kernel/head_32.S | 14 arch/x86/kernel/head_64.S | 87 +++ arch/x86/kernel/sev.c | 2 arch/x86/kernel/smp.c | 3 arch/x86/kernel/smpboot.c | 526 ++++++++---------------- arch/x86/kernel/topology.c | 98 ---- arch/x86/kernel/tsc.c | 20 arch/x86/kernel/tsc_sync.c | 36 - arch/x86/power/cpu.c | 37 - arch/x86/realmode/init.c | 3 arch/x86/realmode/rm/trampoline_64.S | 27 + arch/x86/xen/enlighten_hvm.c | 11 arch/x86/xen/smp_hvm.c | 16 arch/x86/xen/smp_pv.c | 56 +- drivers/acpi/processor_idle.c | 4 include/linux/cpu.h | 4 include/linux/cpuhotplug.h | 17 kernel/cpu.c | 396 +++++++++++++++++- kernel/smp.c | 2 kernel/smpboot.c | 163 ------- 62 files changed, 934 insertions(+), 982 deletions(-) From xen-devel-bounces@lists.xenproject.org Thu May 04 19:02:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:02:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529886.824833 (Exim 4.92) (envelope-from ) id 1pueDN-0004Vw-Gb; Thu, 04 May 2023 19:02:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529886.824833; Thu, 04 May 2023 19:02:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDN-0004VM-Da; Thu, 04 May 2023 19:02:05 +0000 Received: by outflank-mailman (input) for mailman id 529886; Thu, 04 May 2023 19:02:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDM-00042k-2U for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:04 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 276b5184-eaae-11ed-8611-37d641c3527e; Thu, 04 May 2023 21:02:02 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 276b5184-eaae-11ed-8611-37d641c3527e Message-ID: <20230504185936.424138296@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226922; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=waVaB+iOXpEeeQbnpvRruizzYbSaWW2RRSBQj1T/hXA=; b=fL/KXBGwhDgZ0aNNihOGlOrNlSV1oXSPmnek3reTOPzGU26K9/7I6++pxRi1WwqUlxPjOt 5Tyij4lipwiE5wx00Ug/OlbZuQGzLQ5bz0yPSCT5LRqx0FtA/i9SOYFEBjjKXXhsEYmcX0 Syt5stMGuEr0o0+HSblbMnvWZeQN7TaTrhA7dHR9yfdBmu3FPAPBUqggwPcIQGD3m48Bt5 zOf6iElxOZzofzp19LMFZlMc7WEm/MIBFclvIFumjzIiZLJwDWozF9bZ+XBECVGvq7VpEs oWtzcnhMZlsuZosoXBPM96pPurYq5mz+wcdyir0ZGlT+xHDklreyFq9FgGAJog== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226922; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=waVaB+iOXpEeeQbnpvRruizzYbSaWW2RRSBQj1T/hXA=; b=FgatqUwh+JsOxmHUn9Bvq7DTwB3Lr8g2wziGsZ2rOwgPZthkB6nTAdx3egi9uzi5HZxDkx 9oTTBrbEEnqsEmDw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch V2 02/38] cpu/hotplug: Mark arch_disable_smp_support() and bringup_nonboot_cpus() __init References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:01 +0200 (CEST) From: Thomas Gleixner No point in keeping them around. Signed-off-by: Thomas Gleixner --- arch/x86/kernel/smpboot.c | 4 ++-- kernel/cpu.c | 2 +- kernel/smp.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) --- --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -1269,9 +1269,9 @@ int native_cpu_up(unsigned int cpu, stru } /** - * arch_disable_smp_support() - disables SMP support for x86 at runtime + * arch_disable_smp_support() - Disables SMP support for x86 at boottime */ -void arch_disable_smp_support(void) +void __init arch_disable_smp_support(void) { disable_ioapic_support(); } --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -1502,7 +1502,7 @@ int bringup_hibernate_cpu(unsigned int s return 0; } -void bringup_nonboot_cpus(unsigned int setup_max_cpus) +void __init bringup_nonboot_cpus(unsigned int setup_max_cpus) { unsigned int cpu; --- a/kernel/smp.c +++ b/kernel/smp.c @@ -892,7 +892,7 @@ EXPORT_SYMBOL(setup_max_cpus); * SMP mode to . */ -void __weak arch_disable_smp_support(void) { } +void __weak __init arch_disable_smp_support(void) { } static int __init nosmp(char *str) { From xen-devel-bounces@lists.xenproject.org Thu May 04 19:02:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:02:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529884.824813 (Exim 4.92) (envelope-from ) id 1pueDM-000432-2q; Thu, 04 May 2023 19:02:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529884.824813; Thu, 04 May 2023 19:02:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDL-00042v-Vs; Thu, 04 May 2023 19:02:03 +0000 Received: by outflank-mailman (input) for mailman id 529884; Thu, 04 May 2023 19:02:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDK-00042j-Fc for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:02 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 268624e9-eaae-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:02:01 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 268624e9-eaae-11ed-b226-6b7b168915f2 Message-ID: <20230504185936.367031787@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226920; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=Mxn87t9DPEW945il616r0H0SsMXLyUAeJz1AKeylD8A=; b=gN6osUOUj5A4g4ikKpXMxZ7xRrn0bkpwHrNdWYplv0k7rI8gYfItE27E6osNTA/nV1mrk6 WWlzivAwHb3vuxBg3D/Ns21CditKMkPPd9EuijqE+Nl5O62KUwKu3kPrFtGxrKeH/ZJJrC NGZ2k4dOGaPPd/q3/QBB7j+SwZjA+XWe0JSQ1Pjv2a+MTO268fjYE3GMmFpYdhCRR1vFB4 W35O70R3dhw4wdItVUsrhBSyeS38/14353iSux461nIW3VIT8Vl8zXmiSxiD/GMMsuMkzg wRMAaeVRVTGibV6maAbKj32s9VnEdmCl40bZStr+bAA0dwvsHXYOC5oLT4h4Jw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226920; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=Mxn87t9DPEW945il616r0H0SsMXLyUAeJz1AKeylD8A=; b=11ibvq89apUCBbI307f/UhkVNeawUcpQ0C+FqbsH6snqLrHmocC2FzctyE3MrTYESrxN+r cfzlPdKVby530BCw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch V2 01/38] x86/smpboot: Cleanup topology_phys_to_logical_pkg()/die() References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:00 +0200 (CEST) From: Thomas Gleixner Make topology_phys_to_logical_pkg_die() static as it's only used in smpboot.c and fixup the kernel-doc warnings for both functions. Signed-off-by: Thomas Gleixner --- arch/x86/include/asm/topology.h | 3 --- arch/x86/kernel/smpboot.c | 10 ++++++---- 2 files changed, 6 insertions(+), 7 deletions(-) --- --- a/arch/x86/include/asm/topology.h +++ b/arch/x86/include/asm/topology.h @@ -139,7 +139,6 @@ static inline int topology_max_smt_threa int topology_update_package_map(unsigned int apicid, unsigned int cpu); int topology_update_die_map(unsigned int dieid, unsigned int cpu); int topology_phys_to_logical_pkg(unsigned int pkg); -int topology_phys_to_logical_die(unsigned int die, unsigned int cpu); bool topology_is_primary_thread(unsigned int cpu); bool topology_smt_supported(void); #else @@ -149,8 +148,6 @@ topology_update_package_map(unsigned int static inline int topology_update_die_map(unsigned int dieid, unsigned int cpu) { return 0; } static inline int topology_phys_to_logical_pkg(unsigned int pkg) { return 0; } -static inline int topology_phys_to_logical_die(unsigned int die, - unsigned int cpu) { return 0; } static inline int topology_max_die_per_package(void) { return 1; } static inline int topology_max_smt_threads(void) { return 1; } static inline bool topology_is_primary_thread(unsigned int cpu) { return true; } --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -288,6 +288,7 @@ bool topology_smt_supported(void) /** * topology_phys_to_logical_pkg - Map a physical package id to a logical + * @phys_pkg: The physical package id to map * * Returns logical package id or -1 if not found */ @@ -304,15 +305,17 @@ int topology_phys_to_logical_pkg(unsigne return -1; } EXPORT_SYMBOL(topology_phys_to_logical_pkg); + /** * topology_phys_to_logical_die - Map a physical die id to logical + * @die_id: The physical die id to map + * @cur_cpu: The CPU for which the mapping is done * * Returns logical die id or -1 if not found */ -int topology_phys_to_logical_die(unsigned int die_id, unsigned int cur_cpu) +static int topology_phys_to_logical_die(unsigned int die_id, unsigned int cur_cpu) { - int cpu; - int proc_id = cpu_data(cur_cpu).phys_proc_id; + int cpu, proc_id = cpu_data(cur_cpu).phys_proc_id; for_each_possible_cpu(cpu) { struct cpuinfo_x86 *c = &cpu_data(cpu); @@ -323,7 +326,6 @@ int topology_phys_to_logical_die(unsigne } return -1; } -EXPORT_SYMBOL(topology_phys_to_logical_die); /** * topology_update_package_map - Update the physical to logical package map From xen-devel-bounces@lists.xenproject.org Thu May 04 19:02:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:02:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529888.824853 (Exim 4.92) (envelope-from ) id 1pueDR-00054I-3v; Thu, 04 May 2023 19:02:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529888.824853; Thu, 04 May 2023 19:02:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDR-00054B-0y; Thu, 04 May 2023 19:02:09 +0000 Received: by outflank-mailman (input) for mailman id 529888; Thu, 04 May 2023 19:02:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDP-00042k-ES for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:07 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 294fb817-eaae-11ed-8611-37d641c3527e; Thu, 04 May 2023 21:02:05 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 294fb817-eaae-11ed-8611-37d641c3527e Message-ID: <20230504185936.536756506@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=4k8WG2dAJ3uFYn2Qtg5bZA2RHhZEaXZ+bewsd+BJr/I=; b=bBh0CVpZWL+6hsvPUZtXnSdOBPa/K5CfY4sntqqXgNMtxpi+d2yUs3ECpJ289P0ZQAUrXv k7Gw7YnHFskIzQ/7fPEMWNfUyqW1tXD0Y5j9mjC9fHiZESm2nV58xOjcYTcUtICW4PGtib L7qAfpVjhgaAOAD2zQ57omRWjLADm+xmVTWvdqyhIzFRzilnUByYjHcwGeBKFMcYVRiiaY VaFLAq4WMscxLSALxvyX5KYN3LoP2rAtooUlf6qigkW3PSIl7OwVv0Em5tfeehe2sTShbV Tm0yzzDkfXdyeVnTbNUMouES/vmiS2pcR636jskZtx14ouKlyWxaen2mjAF6Eg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=4k8WG2dAJ3uFYn2Qtg5bZA2RHhZEaXZ+bewsd+BJr/I=; b=zT9oEAybbsH/w7G2lAyNh7UEoHso+OvSBYaHY787eM4NlqSRBZnZMUdOCeyvsS0fDgQH3V RekIpVEMD5NisxDQ== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch V2 04/38] x86/smpboot: Rename start_cpu0() to soft_restart_cpu() References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:04 +0200 (CEST) From: Thomas Gleixner This is used in the SEV play_dead() implementation to re-online CPUs. But that has nothing to do with CPU0. Signed-off-by: Thomas Gleixner Cc: Tom Lendacky --- arch/x86/include/asm/cpu.h | 2 +- arch/x86/kernel/callthunks.c | 2 +- arch/x86/kernel/head_32.S | 10 +++++----- arch/x86/kernel/head_64.S | 10 +++++----- arch/x86/kernel/sev.c | 2 +- 5 files changed, 13 insertions(+), 13 deletions(-) --- --- a/arch/x86/include/asm/cpu.h +++ b/arch/x86/include/asm/cpu.h @@ -30,7 +30,7 @@ struct x86_cpu { #ifdef CONFIG_HOTPLUG_CPU extern int arch_register_cpu(int num); extern void arch_unregister_cpu(int); -extern void start_cpu0(void); +extern void soft_restart_cpu(void); #ifdef CONFIG_DEBUG_HOTPLUG_CPU0 extern int _debug_hotplug_cpu(int cpu, int action); #endif --- a/arch/x86/kernel/callthunks.c +++ b/arch/x86/kernel/callthunks.c @@ -134,7 +134,7 @@ static bool skip_addr(void *dest) if (dest == ret_from_fork) return true; #ifdef CONFIG_HOTPLUG_CPU - if (dest == start_cpu0) + if (dest == soft_restart_cpu) return true; #endif #ifdef CONFIG_FUNCTION_TRACER --- a/arch/x86/kernel/head_32.S +++ b/arch/x86/kernel/head_32.S @@ -140,16 +140,16 @@ SYM_CODE_END(startup_32) #ifdef CONFIG_HOTPLUG_CPU /* - * Boot CPU0 entry point. It's called from play_dead(). Everything has been set - * up already except stack. We just set up stack here. Then call - * start_secondary(). + * Entry point for soft restart of a CPU. Invoked from xxx_play_dead() for + * restarting the boot CPU or for restarting SEV guest CPUs after CPU hot + * unplug. Everything is set up already except the stack. */ -SYM_FUNC_START(start_cpu0) +SYM_FUNC_START(soft_restart_cpu) movl initial_stack, %ecx movl %ecx, %esp call *(initial_code) 1: jmp 1b -SYM_FUNC_END(start_cpu0) +SYM_FUNC_END(soft_restart_cpu) #endif /* --- a/arch/x86/kernel/head_64.S +++ b/arch/x86/kernel/head_64.S @@ -377,11 +377,11 @@ SYM_CODE_END(secondary_startup_64) #ifdef CONFIG_HOTPLUG_CPU /* - * Boot CPU0 entry point. It's called from play_dead(). Everything has been set - * up already except stack. We just set up stack here. Then call - * start_secondary() via .Ljump_to_C_code. + * Entry point for soft restart of a CPU. Invoked from xxx_play_dead() for + * restarting the boot CPU or for restarting SEV guest CPUs after CPU hot + * unplug. Everything is set up already except the stack. */ -SYM_CODE_START(start_cpu0) +SYM_CODE_START(soft_restart_cpu) ANNOTATE_NOENDBR UNWIND_HINT_END_OF_STACK @@ -390,7 +390,7 @@ SYM_CODE_START(start_cpu0) movq TASK_threadsp(%rcx), %rsp jmp .Ljump_to_C_code -SYM_CODE_END(start_cpu0) +SYM_CODE_END(soft_restart_cpu) #endif #ifdef CONFIG_AMD_MEM_ENCRYPT --- a/arch/x86/kernel/sev.c +++ b/arch/x86/kernel/sev.c @@ -1328,7 +1328,7 @@ static void sev_es_play_dead(void) * If we get here, the VCPU was woken up again. Jump to CPU * startup code to get it back online. */ - start_cpu0(); + soft_restart_cpu(); } #else /* CONFIG_HOTPLUG_CPU */ #define sev_es_play_dead native_play_dead From xen-devel-bounces@lists.xenproject.org Thu May 04 19:02:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:02:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529889.824858 (Exim 4.92) (envelope-from ) id 1pueDR-00058F-Gz; Thu, 04 May 2023 19:02:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529889.824858; Thu, 04 May 2023 19:02:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDR-000581-B5; Thu, 04 May 2023 19:02:09 +0000 Received: by outflank-mailman (input) for mailman id 529889; Thu, 04 May 2023 19:02:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDQ-00042j-2o for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:08 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2a42af00-eaae-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:02:07 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2a42af00-eaae-11ed-b226-6b7b168915f2 Message-ID: <20230504185936.590281709@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226927; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=IjEqVwuDXy6l11CZOhb2Q9Y7uBHaszP86r8c69YcU4c=; b=1TjCsPNIyVe0J97AnMZ9IZuq5klCTmb8uOqmiS6QP7ZxFmpOciabd4+mZXTpZt5PKaBC3+ tShhthEpUYU1PR0O6G3TAKNFHt5nf1NpPdvBpi/KOT/ebUi2EI8FLEgU6k80VCWhJI6XJu rdlacFVoZAD33FbY1MiLPzbfOdt5caRuE6+hd9z2DCXlPIQ+LrOM0u1VlHpb9igmtMFSjX biJHT/ieDdtdnU2SskStM2vMbaj83W3ZNAkvtv4DHH1Q8FTO6wyJZvCKM2vsuaZPc/wXqB 4zIAc45oyX3TzFS3xg5Y4mqLrWDKm1CH9YSWlqdnpwKJWQa8TDMH4rl3Gug5TQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226927; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=IjEqVwuDXy6l11CZOhb2Q9Y7uBHaszP86r8c69YcU4c=; b=9diOKqSJbLdnSrqHxlovDTLpCZmCgBMmL7vKik0+pcztGx/FVE2OzspIn02s8YsczZddy6 W6MOr2qwUqkfM0DA== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch V2 05/38] x86/topology: Remove CPU0 hotplug option References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:06 +0200 (CEST) From: Thomas Gleixner This was introduced together with commit e1c467e69040 ("x86, hotplug: Wake up CPU0 via NMI instead of INIT, SIPI, SIPI") to eventually support physical hotplug of CPU0: "We'll change this code in the future to wake up hard offlined CPU0 if real platform and request are available." 11 years later this has not happened and physical hotplug is not officially supported. Remove the cruft. Signed-off-by: Thomas Gleixner --- Documentation/admin-guide/kernel-parameters.txt | 14 --- Documentation/core-api/cpu_hotplug.rst | 13 --- arch/x86/Kconfig | 43 ---------- arch/x86/include/asm/cpu.h | 3 arch/x86/kernel/topology.c | 98 ------------------------ arch/x86/power/cpu.c | 37 --------- 6 files changed, 6 insertions(+), 202 deletions(-) --- --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -818,20 +818,6 @@ Format: ,,,[,] - cpu0_hotplug [X86] Turn on CPU0 hotplug feature when - CONFIG_BOOTPARAM_HOTPLUG_CPU0 is off. - Some features depend on CPU0. Known dependencies are: - 1. Resume from suspend/hibernate depends on CPU0. - Suspend/hibernate will fail if CPU0 is offline and you - need to online CPU0 before suspend/hibernate. - 2. PIC interrupts also depend on CPU0. CPU0 can't be - removed if a PIC interrupt is detected. - It's said poweroff/reboot may depend on CPU0 on some - machines although I haven't seen such issues so far - after CPU0 is offline on a few tested machines. - If the dependencies are under your control, you can - turn on cpu0_hotplug. - cpuidle.off=1 [CPU_IDLE] disable the cpuidle sub-system --- a/Documentation/core-api/cpu_hotplug.rst +++ b/Documentation/core-api/cpu_hotplug.rst @@ -127,17 +127,8 @@ Once the CPU is shutdown, it will be rem $ echo 1 > /sys/devices/system/cpu/cpu4/online smpboot: Booting Node 0 Processor 4 APIC 0x1 -The CPU is usable again. This should work on all CPUs. CPU0 is often special -and excluded from CPU hotplug. On X86 the kernel option -*CONFIG_BOOTPARAM_HOTPLUG_CPU0* has to be enabled in order to be able to -shutdown CPU0. Alternatively the kernel command option *cpu0_hotplug* can be -used. Some known dependencies of CPU0: - -* Resume from hibernate/suspend. Hibernate/suspend will fail if CPU0 is offline. -* PIC interrupts. CPU0 can't be removed if a PIC interrupt is detected. - -Please let Fenghua Yu know if you find any dependencies -on CPU0. +The CPU is usable again. This should work on all CPUs, but CPU0 is often special +and excluded from CPU hotplug. The CPU hotplug coordination ============================ --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -2305,49 +2305,6 @@ config HOTPLUG_CPU def_bool y depends on SMP -config BOOTPARAM_HOTPLUG_CPU0 - bool "Set default setting of cpu0_hotpluggable" - depends on HOTPLUG_CPU - help - Set whether default state of cpu0_hotpluggable is on or off. - - Say Y here to enable CPU0 hotplug by default. If this switch - is turned on, there is no need to give cpu0_hotplug kernel - parameter and the CPU0 hotplug feature is enabled by default. - - Please note: there are two known CPU0 dependencies if you want - to enable the CPU0 hotplug feature either by this switch or by - cpu0_hotplug kernel parameter. - - First, resume from hibernate or suspend always starts from CPU0. - So hibernate and suspend are prevented if CPU0 is offline. - - Second dependency is PIC interrupts always go to CPU0. CPU0 can not - offline if any interrupt can not migrate out of CPU0. There may - be other CPU0 dependencies. - - Please make sure the dependencies are under your control before - you enable this feature. - - Say N if you don't want to enable CPU0 hotplug feature by default. - You still can enable the CPU0 hotplug feature at boot by kernel - parameter cpu0_hotplug. - -config DEBUG_HOTPLUG_CPU0 - def_bool n - prompt "Debug CPU0 hotplug" - depends on HOTPLUG_CPU - help - Enabling this option offlines CPU0 (if CPU0 can be offlined) as - soon as possible and boots up userspace with CPU0 offlined. User - can online CPU0 back after boot time. - - To debug CPU0 hotplug, you need to enable CPU0 offline/online - feature by either turning on CONFIG_BOOTPARAM_HOTPLUG_CPU0 during - compilation or giving cpu0_hotplug kernel parameter at boot. - - If unsure, say N. - config COMPAT_VDSO def_bool n prompt "Disable the 32-bit vDSO (needed for glibc 2.3.3)" --- a/arch/x86/include/asm/cpu.h +++ b/arch/x86/include/asm/cpu.h @@ -31,9 +31,6 @@ struct x86_cpu { extern int arch_register_cpu(int num); extern void arch_unregister_cpu(int); extern void soft_restart_cpu(void); -#ifdef CONFIG_DEBUG_HOTPLUG_CPU0 -extern int _debug_hotplug_cpu(int cpu, int action); -#endif #endif extern void ap_init_aperfmperf(void); --- a/arch/x86/kernel/topology.c +++ b/arch/x86/kernel/topology.c @@ -38,102 +38,12 @@ static DEFINE_PER_CPU(struct x86_cpu, cpu_devices); #ifdef CONFIG_HOTPLUG_CPU - -#ifdef CONFIG_BOOTPARAM_HOTPLUG_CPU0 -static int cpu0_hotpluggable = 1; -#else -static int cpu0_hotpluggable; -static int __init enable_cpu0_hotplug(char *str) -{ - cpu0_hotpluggable = 1; - return 1; -} - -__setup("cpu0_hotplug", enable_cpu0_hotplug); -#endif - -#ifdef CONFIG_DEBUG_HOTPLUG_CPU0 -/* - * This function offlines a CPU as early as possible and allows userspace to - * boot up without the CPU. The CPU can be onlined back by user after boot. - * - * This is only called for debugging CPU offline/online feature. - */ -int _debug_hotplug_cpu(int cpu, int action) -{ - int ret; - - if (!cpu_is_hotpluggable(cpu)) - return -EINVAL; - - switch (action) { - case 0: - ret = remove_cpu(cpu); - if (!ret) - pr_info("DEBUG_HOTPLUG_CPU0: CPU %u is now offline\n", cpu); - else - pr_debug("Can't offline CPU%d.\n", cpu); - break; - case 1: - ret = add_cpu(cpu); - if (ret) - pr_debug("Can't online CPU%d.\n", cpu); - - break; - default: - ret = -EINVAL; - } - - return ret; -} - -static int __init debug_hotplug_cpu(void) +int arch_register_cpu(int cpu) { - _debug_hotplug_cpu(0, 0); - return 0; -} - -late_initcall_sync(debug_hotplug_cpu); -#endif /* CONFIG_DEBUG_HOTPLUG_CPU0 */ - -int arch_register_cpu(int num) -{ - struct cpuinfo_x86 *c = &cpu_data(num); - - /* - * Currently CPU0 is only hotpluggable on Intel platforms. Other - * vendors can add hotplug support later. - * Xen PV guests don't support CPU0 hotplug at all. - */ - if (c->x86_vendor != X86_VENDOR_INTEL || - cpu_feature_enabled(X86_FEATURE_XENPV)) - cpu0_hotpluggable = 0; - - /* - * Two known BSP/CPU0 dependencies: Resume from suspend/hibernate - * depends on BSP. PIC interrupts depend on BSP. - * - * If the BSP dependencies are under control, one can tell kernel to - * enable BSP hotplug. This basically adds a control file and - * one can attempt to offline BSP. - */ - if (num == 0 && cpu0_hotpluggable) { - unsigned int irq; - /* - * We won't take down the boot processor on i386 if some - * interrupts only are able to be serviced by the BSP in PIC. - */ - for_each_active_irq(irq) { - if (!IO_APIC_IRQ(irq) && irq_has_action(irq)) { - cpu0_hotpluggable = 0; - break; - } - } - } - if (num || cpu0_hotpluggable) - per_cpu(cpu_devices, num).cpu.hotpluggable = 1; + struct x86_cpu *xc = per_cpu_ptr(&cpu_devices, cpu); - return register_cpu(&per_cpu(cpu_devices, num).cpu, num); + xc->cpu.hotpluggable = cpu > 0; + return register_cpu(&xc->cpu, cpu); } EXPORT_SYMBOL(arch_register_cpu); --- a/arch/x86/power/cpu.c +++ b/arch/x86/power/cpu.c @@ -351,43 +351,6 @@ static int bsp_pm_callback(struct notifi case PM_HIBERNATION_PREPARE: ret = bsp_check(); break; -#ifdef CONFIG_DEBUG_HOTPLUG_CPU0 - case PM_RESTORE_PREPARE: - /* - * When system resumes from hibernation, online CPU0 because - * 1. it's required for resume and - * 2. the CPU was online before hibernation - */ - if (!cpu_online(0)) - _debug_hotplug_cpu(0, 1); - break; - case PM_POST_RESTORE: - /* - * When a resume really happens, this code won't be called. - * - * This code is called only when user space hibernation software - * prepares for snapshot device during boot time. So we just - * call _debug_hotplug_cpu() to restore to CPU0's state prior to - * preparing the snapshot device. - * - * This works for normal boot case in our CPU0 hotplug debug - * mode, i.e. CPU0 is offline and user mode hibernation - * software initializes during boot time. - * - * If CPU0 is online and user application accesses snapshot - * device after boot time, this will offline CPU0 and user may - * see different CPU0 state before and after accessing - * the snapshot device. But hopefully this is not a case when - * user debugging CPU0 hotplug. Even if users hit this case, - * they can easily online CPU0 back. - * - * To simplify this debug code, we only consider normal boot - * case. Otherwise we need to remember CPU0's state and restore - * to that state and resolve racy conditions etc. - */ - _debug_hotplug_cpu(0, 0); - break; -#endif default: break; } From xen-devel-bounces@lists.xenproject.org Thu May 04 19:02:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:02:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529890.824874 (Exim 4.92) (envelope-from ) id 1pueDT-0005aX-00; Thu, 04 May 2023 19:02:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529890.824874; Thu, 04 May 2023 19:02:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDS-0005Yi-OU; Thu, 04 May 2023 19:02:10 +0000 Received: by outflank-mailman (input) for mailman id 529890; Thu, 04 May 2023 19:02:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDR-00042j-LX for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:09 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2b3552f1-eaae-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:02:08 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2b3552f1-eaae-11ed-b226-6b7b168915f2 Message-ID: <20230504185936.643128218@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=t1kFrxUQzoAGHqTqUkb/kf3JNUtNBt/869VYZMS78IM=; b=lPLKtt3lB9e6PQEqX4aRgKUFycBur1nGQsvwRP3go2MfvrlcnqU//JnJCNzp1o2Dm3QHM4 BxFFAwYb9s9oEKep2SSjD/7hHltKU07ND8S6ARP7AC1mhVPf/UMHQ17aKQGApwPht2fG55 pGZqOSdSNm5i8MM+NhojrwfieQkc4eO3Gbbf1xGarkf/7ZS4A/jqS/qZKd6Zg8bwYoy9bZ QY2GEqdFw31AQxktaZ3LQaLLlhtyiGvpvylK1LNZ0u5+rps4jsbRCFdKWxZZ38e4EbIGew Lh+wXXzuAWBjOvDHwNxF7ZIORMgCG3Jmr6XmbvnSMvq8EKmTQJC+Sll937gcBg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=t1kFrxUQzoAGHqTqUkb/kf3JNUtNBt/869VYZMS78IM=; b=gRTGa8QVKZ933uu1TIkd3rocCTd2HvDqOOJ8XSUIlwizxGixPYDURnH5KuGoBbbwky8MOG cfyCNtQxP40YHpCg== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch V2 06/38] x86/smpboot: Remove the CPU0 hotplug kludge References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:08 +0200 (CEST) From: Thomas Gleixner This was introduced with commit e1c467e69040 ("x86, hotplug: Wake up CPU0 via NMI instead of INIT, SIPI, SIPI") to eventually support physical hotplug of CPU0: "We'll change this code in the future to wake up hard offlined CPU0 if real platform and request are available." 11 years later this has not happened and physical hotplug is not officially supported. Remove the cruft. Signed-off-by: Thomas Gleixner --- arch/x86/include/asm/apic.h | 1 arch/x86/include/asm/smp.h | 1 arch/x86/kernel/smpboot.c | 170 +++--------------------------------------- drivers/acpi/processor_idle.c | 4 4 files changed, 14 insertions(+), 162 deletions(-) --- --- a/arch/x86/include/asm/apic.h +++ b/arch/x86/include/asm/apic.h @@ -377,7 +377,6 @@ extern struct apic *__apicdrivers[], *__ * APIC functionality to boot other CPUs - only used on SMP: */ #ifdef CONFIG_SMP -extern int wakeup_secondary_cpu_via_nmi(int apicid, unsigned long start_eip); extern int lapic_can_unplug_cpu(void); #endif --- a/arch/x86/include/asm/smp.h +++ b/arch/x86/include/asm/smp.h @@ -130,7 +130,6 @@ void native_play_dead(void); void play_dead_common(void); void wbinvd_on_cpu(int cpu); int wbinvd_on_all_cpus(void); -void cond_wakeup_cpu0(void); void native_smp_send_reschedule(int cpu); void native_send_call_func_ipi(const struct cpumask *mask); --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -216,9 +216,6 @@ static void ap_calibrate_delay(void) cpu_data(smp_processor_id()).loops_per_jiffy = loops_per_jiffy; } -static int cpu0_logical_apicid; -static int enable_start_cpu0; - /* * Activate a secondary processor. */ @@ -241,8 +238,6 @@ static void notrace start_secondary(void x86_cpuinit.early_percpu_clock_init(); smp_callin(); - enable_start_cpu0 = 0; - /* otherwise gcc will move up smp_processor_id before the cpu_init */ barrier(); /* Check TSC synchronization with the control CPU: */ @@ -410,7 +405,7 @@ void smp_store_cpu_info(int id) c->cpu_index = id; /* * During boot time, CPU0 has this setup already. Save the info when - * bringing up AP or offlined CPU0. + * bringing up an AP. */ identify_secondary_cpu(c); c->initialized = true; @@ -807,51 +802,14 @@ static void __init smp_quirk_init_udelay } /* - * Poke the other CPU in the eye via NMI to wake it up. Remember that the normal - * INIT, INIT, STARTUP sequence will reset the chip hard for us, and this - * won't ... remember to clear down the APIC, etc later. - */ -int -wakeup_secondary_cpu_via_nmi(int apicid, unsigned long start_eip) -{ - u32 dm = apic->dest_mode_logical ? APIC_DEST_LOGICAL : APIC_DEST_PHYSICAL; - unsigned long send_status, accept_status = 0; - int maxlvt; - - /* Target chip */ - /* Boot on the stack */ - /* Kick the second */ - apic_icr_write(APIC_DM_NMI | dm, apicid); - - pr_debug("Waiting for send to finish...\n"); - send_status = safe_apic_wait_icr_idle(); - - /* - * Give the other CPU some time to accept the IPI. - */ - udelay(200); - if (APIC_INTEGRATED(boot_cpu_apic_version)) { - maxlvt = lapic_get_maxlvt(); - if (maxlvt > 3) /* Due to the Pentium erratum 3AP. */ - apic_write(APIC_ESR, 0); - accept_status = (apic_read(APIC_ESR) & 0xEF); - } - pr_debug("NMI sent\n"); - - if (send_status) - pr_err("APIC never delivered???\n"); - if (accept_status) - pr_err("APIC delivery error (%lx)\n", accept_status); - - return (send_status | accept_status); -} - -static int -wakeup_secondary_cpu_via_init(int phys_apicid, unsigned long start_eip) + * Wake up AP by INIT, INIT, STARTUP sequence. + */ +static int wakeup_secondary_cpu_via_init(int phys_apicid, unsigned long start_eip) { unsigned long send_status = 0, accept_status = 0; int maxlvt, num_starts, j; + preempt_disable(); maxlvt = lapic_get_maxlvt(); /* @@ -957,6 +915,7 @@ wakeup_secondary_cpu_via_init(int phys_a if (accept_status) pr_err("APIC delivery error (%lx)\n", accept_status); + preempt_enable(); return (send_status | accept_status); } @@ -997,67 +956,6 @@ static void announce_cpu(int cpu, int ap node, cpu, apicid); } -static int wakeup_cpu0_nmi(unsigned int cmd, struct pt_regs *regs) -{ - int cpu; - - cpu = smp_processor_id(); - if (cpu == 0 && !cpu_online(cpu) && enable_start_cpu0) - return NMI_HANDLED; - - return NMI_DONE; -} - -/* - * Wake up AP by INIT, INIT, STARTUP sequence. - * - * Instead of waiting for STARTUP after INITs, BSP will execute the BIOS - * boot-strap code which is not a desired behavior for waking up BSP. To - * void the boot-strap code, wake up CPU0 by NMI instead. - * - * This works to wake up soft offlined CPU0 only. If CPU0 is hard offlined - * (i.e. physically hot removed and then hot added), NMI won't wake it up. - * We'll change this code in the future to wake up hard offlined CPU0 if - * real platform and request are available. - */ -static int -wakeup_cpu_via_init_nmi(int cpu, unsigned long start_ip, int apicid, - int *cpu0_nmi_registered) -{ - int id; - int boot_error; - - preempt_disable(); - - /* - * Wake up AP by INIT, INIT, STARTUP sequence. - */ - if (cpu) { - boot_error = wakeup_secondary_cpu_via_init(apicid, start_ip); - goto out; - } - - /* - * Wake up BSP by nmi. - * - * Register a NMI handler to help wake up CPU0. - */ - boot_error = register_nmi_handler(NMI_LOCAL, - wakeup_cpu0_nmi, 0, "wake_cpu0"); - - if (!boot_error) { - enable_start_cpu0 = 1; - *cpu0_nmi_registered = 1; - id = apic->dest_mode_logical ? cpu0_logical_apicid : apicid; - boot_error = wakeup_secondary_cpu_via_nmi(id, start_ip); - } - -out: - preempt_enable(); - - return boot_error; -} - int common_cpu_up(unsigned int cpu, struct task_struct *idle) { int ret; @@ -1086,8 +984,7 @@ int common_cpu_up(unsigned int cpu, stru * Returns zero if CPU booted OK, else error code from * ->wakeup_secondary_cpu. */ -static int do_boot_cpu(int apicid, int cpu, struct task_struct *idle, - int *cpu0_nmi_registered) +static int do_boot_cpu(int apicid, int cpu, struct task_struct *idle) { /* start_ip had better be page-aligned! */ unsigned long start_ip = real_mode_header->trampoline_start; @@ -1120,7 +1017,6 @@ static int do_boot_cpu(int apicid, int c * This grunge runs the startup process for * the targeted processor. */ - if (x86_platform.legacy.warm_reset) { pr_debug("Setting warm reset code and vector.\n"); @@ -1149,15 +1045,14 @@ static int do_boot_cpu(int apicid, int c * - Use a method from the APIC driver if one defined, with wakeup * straight to 64-bit mode preferred over wakeup to RM. * Otherwise, - * - Use an INIT boot APIC message for APs or NMI for BSP. + * - Use an INIT boot APIC message */ if (apic->wakeup_secondary_cpu_64) boot_error = apic->wakeup_secondary_cpu_64(apicid, start_ip); else if (apic->wakeup_secondary_cpu) boot_error = apic->wakeup_secondary_cpu(apicid, start_ip); else - boot_error = wakeup_cpu_via_init_nmi(cpu, start_ip, apicid, - cpu0_nmi_registered); + boot_error = wakeup_secondary_cpu_via_init(apicid, start_ip); if (!boot_error) { /* @@ -1206,9 +1101,8 @@ static int do_boot_cpu(int apicid, int c int native_cpu_up(unsigned int cpu, struct task_struct *tidle) { int apicid = apic->cpu_present_to_apicid(cpu); - int cpu0_nmi_registered = 0; unsigned long flags; - int err, ret = 0; + int err; lockdep_assert_irqs_enabled(); @@ -1247,11 +1141,10 @@ int native_cpu_up(unsigned int cpu, stru if (err) return err; - err = do_boot_cpu(apicid, cpu, tidle, &cpu0_nmi_registered); + err = do_boot_cpu(apicid, cpu, tidle); if (err) { pr_err("do_boot_cpu failed(%d) to wakeup CPU#%u\n", err, cpu); - ret = -EIO; - goto unreg_nmi; + return err; } /* @@ -1267,15 +1160,7 @@ int native_cpu_up(unsigned int cpu, stru touch_nmi_watchdog(); } -unreg_nmi: - /* - * Clean up the nmi handler. Do this after the callin and callout sync - * to avoid impact of possible long unregister time. - */ - if (cpu0_nmi_registered) - unregister_nmi_handler(NMI_LOCAL, "wake_cpu0"); - - return ret; + return 0; } /** @@ -1373,14 +1258,6 @@ static void __init smp_cpu_index_default } } -static void __init smp_get_logical_apicid(void) -{ - if (x2apic_mode) - cpu0_logical_apicid = apic_read(APIC_LDR); - else - cpu0_logical_apicid = GET_APIC_LOGICAL_ID(apic_read(APIC_LDR)); -} - void __init smp_prepare_cpus_common(void) { unsigned int i; @@ -1443,8 +1320,6 @@ void __init native_smp_prepare_cpus(unsi /* Setup local timer */ x86_init.timers.setup_percpu_clockev(); - smp_get_logical_apicid(); - pr_info("CPU0: "); print_cpu_info(&cpu_data(0)); @@ -1752,18 +1627,6 @@ void play_dead_common(void) local_irq_disable(); } -/** - * cond_wakeup_cpu0 - Wake up CPU0 if needed. - * - * If NMI wants to wake up CPU0, start CPU0. - */ -void cond_wakeup_cpu0(void) -{ - if (smp_processor_id() == 0 && enable_start_cpu0) - start_cpu0(); -} -EXPORT_SYMBOL_GPL(cond_wakeup_cpu0); - /* * We need to flush the caches before going to sleep, lest we have * dirty data in our caches when we come back up. @@ -1831,8 +1694,6 @@ static inline void mwait_play_dead(void) __monitor(mwait_ptr, 0, 0); mb(); __mwait(eax, 0); - - cond_wakeup_cpu0(); } } @@ -1841,11 +1702,8 @@ void __noreturn hlt_play_dead(void) if (__this_cpu_read(cpu_info.x86) >= 4) wbinvd(); - while (1) { + while (1) native_halt(); - - cond_wakeup_cpu0(); - } } void native_play_dead(void) --- a/drivers/acpi/processor_idle.c +++ b/drivers/acpi/processor_idle.c @@ -597,10 +597,6 @@ static int acpi_idle_play_dead(struct cp io_idle(cx->address); } else return -ENODEV; - -#if defined(CONFIG_X86) && defined(CONFIG_HOTPLUG_CPU) - cond_wakeup_cpu0(); -#endif } /* Never reached */ From xen-devel-bounces@lists.xenproject.org Thu May 04 19:02:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:02:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529891.824883 (Exim 4.92) (envelope-from ) id 1pueDV-0005vD-CC; Thu, 04 May 2023 19:02:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529891.824883; Thu, 04 May 2023 19:02:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDV-0005uu-7x; Thu, 04 May 2023 19:02:13 +0000 Received: by outflank-mailman (input) for mailman id 529891; Thu, 04 May 2023 19:02:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDT-00042j-Kl for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:11 +0000 Received: from galois.linutronix.de (galois.linutronix.de [2a0a:51c0:0:12e:550::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2c24286f-eaae-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:02:11 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c24286f-eaae-11ed-b226-6b7b168915f2 Message-ID: <20230504185936.696863260@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=oNktQrwN+fatH513QPoGkxuTXmWxbBJSO1kVQSmt5aw=; b=gBya4Wdiox20HXnYxId2o92/cZNTV4kT8ZfWJZEW8ITXjndCeX8dDH5GHwnbCKYq4N2LZ7 1Vliet33ezvFZfT7hZ49SRcTQY9GGkgXhlSt5j4FLFBbo8w2LMXaeiXjsd9i1J9IMUzHg1 sJN1go/y7aKDt6GemaqC60gjrJ2Y/O06s8spq6n5PMT68ouOvPdBNo/CzyJcNIvXElJXAl XdjDvEAOi1DHoGQz2s+P9J0LaJZ0aZZ0+hC8ebSl7akG4yKA5FQhYbj1MWyqNbSv7kr//g wKJSvQLOs5Ac6Rvs5KHpecAWJnrhruw0ihD4m2E9ZObgEFCoaikI3NMnkVCBlA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=oNktQrwN+fatH513QPoGkxuTXmWxbBJSO1kVQSmt5aw=; b=ne/7c8UNDxt/B5By5H8OrJEC2F33AGALC1UJsqUQEjBRB84Yn90Pp71hqA5iKSc8E1YfLo xVfQnGoIgwAl59BQ== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch V2 07/38] x86/smpboot: Restrict soft_restart_cpu() to SEV References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:09 +0200 (CEST) From: Thomas Gleixner Now that the CPU0 hotplug cruft is gone, the only user is AMD SEV. Signed-off-by: Thomas Gleixner Cc: Tom Lendacky --- arch/x86/kernel/callthunks.c | 2 +- arch/x86/kernel/head_32.S | 14 -------------- arch/x86/kernel/head_64.S | 2 +- 3 files changed, 2 insertions(+), 16 deletions(-) --- --- a/arch/x86/kernel/callthunks.c +++ b/arch/x86/kernel/callthunks.c @@ -133,7 +133,7 @@ static bool skip_addr(void *dest) /* Accounts directly */ if (dest == ret_from_fork) return true; -#ifdef CONFIG_HOTPLUG_CPU +#if defined(CONFIG_HOTPLUG_CPU) && defined(CONFIG_AMD_MEM_ENCRYPT) if (dest == soft_restart_cpu) return true; #endif --- a/arch/x86/kernel/head_32.S +++ b/arch/x86/kernel/head_32.S @@ -138,20 +138,6 @@ SYM_CODE_START(startup_32) jmp .Ldefault_entry SYM_CODE_END(startup_32) -#ifdef CONFIG_HOTPLUG_CPU -/* - * Entry point for soft restart of a CPU. Invoked from xxx_play_dead() for - * restarting the boot CPU or for restarting SEV guest CPUs after CPU hot - * unplug. Everything is set up already except the stack. - */ -SYM_FUNC_START(soft_restart_cpu) - movl initial_stack, %ecx - movl %ecx, %esp - call *(initial_code) -1: jmp 1b -SYM_FUNC_END(soft_restart_cpu) -#endif - /* * Non-boot CPU entry point; entered from trampoline.S * We can't lgdt here, because lgdt itself uses a data segment, but --- a/arch/x86/kernel/head_64.S +++ b/arch/x86/kernel/head_64.S @@ -375,7 +375,7 @@ SYM_CODE_END(secondary_startup_64) #include "verify_cpu.S" #include "sev_verify_cbit.S" -#ifdef CONFIG_HOTPLUG_CPU +#if defined(CONFIG_HOTPLUG_CPU) && defined(CONFIG_AMD_MEM_ENCRYPT) /* * Entry point for soft restart of a CPU. Invoked from xxx_play_dead() for * restarting the boot CPU or for restarting SEV guest CPUs after CPU hot From xen-devel-bounces@lists.xenproject.org Thu May 04 19:02:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:02:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529892.824888 (Exim 4.92) (envelope-from ) id 1pueDV-0005zi-Rw; Thu, 04 May 2023 19:02:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529892.824888; Thu, 04 May 2023 19:02:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDV-0005ym-KP; Thu, 04 May 2023 19:02:13 +0000 Received: by outflank-mailman (input) for mailman id 529892; Thu, 04 May 2023 19:02:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDU-00042j-UD for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:12 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2d2db0c5-eaae-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:02:12 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2d2db0c5-eaae-11ed-b226-6b7b168915f2 Message-ID: <20230504185936.750150196@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226932; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=Csk76nlugXhAU996VRssrwo8MVI1hAOPsGe3TXuIETM=; b=tpY2Pta11o5D+EBlLezP7+DQ0YHNLnnshfEKyGamHfMkSJSDc6pWd24jta33cQ6549e5n0 YoCRhsqkaZ0RzkSEFfE53xlP/wOrJKVGfAasd+i1K8FwsOnit2R8Qcbst29P+dph3dRJkn MWH3Lq9LgxU+JESzbQnOULIN1Fs0BetdOgLMsOeCIiVyyZnbX0XyK/efLbSuRFMNnGI3x6 cKRhbBjsP/glATrekoMoT4u4F+Pv2ebV/PeVUxNrAcjRy4EL78zxGMHmgOH903YOe9OGR3 DTNVfbTo3Z9BrgHrkycf+LctlaGconOxbeHGZGJUplx9zbo/SySM8/Japzc/+Q== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226932; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=Csk76nlugXhAU996VRssrwo8MVI1hAOPsGe3TXuIETM=; b=7clF0BS88qjmoiBaLOkVsFT638/SjDAHfzIc/R9HEwJjRQD5/6IkcSs7vkFzJfGoR95jo3 dYaej/CZ6HDpvPAA== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" , David Woodhouse Subject: [patch V2 08/38] x86/smpboot: Split up native_cpu_up() into separate phases and document them References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:11 +0200 (CEST) From: David Woodhouse There are four logical parts to what native_cpu_up() does on the BSP (or on the controlling CPU for a later hotplug): 1) Wake the AP by sending the INIT/SIPI/SIPI sequence. 2) Wait for the AP to make it as far as wait_for_master_cpu() which sets that CPU's bit in cpu_initialized_mask, then sets the bit in cpu_callout_mask to let the AP proceed through cpu_init(). 3) Wait for the AP to finish cpu_init() and get as far as the smp_callin() call, which sets that CPU's bit in cpu_callin_mask. 4) Perform the TSC synchronization and wait for the AP to actually mark itself online in cpu_online_mask. In preparation to allow these phases to operate in parallel on multiple APs, split them out into separate functions and document the interactions a little more clearly in both the BP and AP code paths. No functional change intended. Signed-off-by: David Woodhouse Signed-off-by: Thomas Gleixner --- arch/x86/kernel/smpboot.c | 187 +++++++++++++++++++++++++++++----------------- 1 file changed, 121 insertions(+), 66 deletions(-) --- --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -193,6 +193,10 @@ static void smp_callin(void) wmb(); + /* + * This runs the AP through all the cpuhp states to its target + * state (CPUHP_ONLINE in the case of serial bringup). + */ notify_cpu_starting(cpuid); /* @@ -233,14 +237,31 @@ static void notrace start_secondary(void load_cr3(swapper_pg_dir); __flush_tlb_all(); #endif + /* + * Sync point with wait_cpu_initialized(). Before proceeding through + * cpu_init(), the AP will call wait_for_master_cpu() which sets its + * own bit in cpu_initialized_mask and then waits for the BSP to set + * its bit in cpu_callout_mask to release it. + */ cpu_init_secondary(); rcu_cpu_starting(raw_smp_processor_id()); x86_cpuinit.early_percpu_clock_init(); + + /* + * Sync point with wait_cpu_callin(). The AP doesn't wait here + * but just sets the bit to let the controlling CPU (BSP) know that + * it's got this far. + */ smp_callin(); - /* otherwise gcc will move up smp_processor_id before the cpu_init */ + /* Otherwise gcc will move up smp_processor_id() before cpu_init() */ barrier(); - /* Check TSC synchronization with the control CPU: */ + + /* + * Check TSC synchronization with the control CPU, which will do + * its part of this from wait_cpu_online(), making it an implicit + * synchronization point. + */ check_tsc_sync_target(); /* @@ -259,6 +280,7 @@ static void notrace start_secondary(void * half valid vector space. */ lock_vector_lock(); + /* Sync point with do_wait_cpu_online() */ set_cpu_online(smp_processor_id(), true); lapic_online(); unlock_vector_lock(); @@ -981,17 +1003,13 @@ int common_cpu_up(unsigned int cpu, stru /* * NOTE - on most systems this is a PHYSICAL apic ID, but on multiquad * (ie clustered apic addressing mode), this is a LOGICAL apic ID. - * Returns zero if CPU booted OK, else error code from + * Returns zero if startup was successfully sent, else error code from * ->wakeup_secondary_cpu. */ static int do_boot_cpu(int apicid, int cpu, struct task_struct *idle) { - /* start_ip had better be page-aligned! */ unsigned long start_ip = real_mode_header->trampoline_start; - unsigned long boot_error = 0; - unsigned long timeout; - #ifdef CONFIG_X86_64 /* If 64-bit wakeup method exists, use the 64-bit mode trampoline IP */ if (apic->wakeup_secondary_cpu_64) @@ -1048,60 +1066,89 @@ static int do_boot_cpu(int apicid, int c * - Use an INIT boot APIC message */ if (apic->wakeup_secondary_cpu_64) - boot_error = apic->wakeup_secondary_cpu_64(apicid, start_ip); + return apic->wakeup_secondary_cpu_64(apicid, start_ip); else if (apic->wakeup_secondary_cpu) - boot_error = apic->wakeup_secondary_cpu(apicid, start_ip); - else - boot_error = wakeup_secondary_cpu_via_init(apicid, start_ip); + return apic->wakeup_secondary_cpu(apicid, start_ip); - if (!boot_error) { - /* - * Wait 10s total for first sign of life from AP - */ - boot_error = -1; - timeout = jiffies + 10*HZ; - while (time_before(jiffies, timeout)) { - if (cpumask_test_cpu(cpu, cpu_initialized_mask)) { - /* - * Tell AP to proceed with initialization - */ - cpumask_set_cpu(cpu, cpu_callout_mask); - boot_error = 0; - break; - } - schedule(); - } - } + return wakeup_secondary_cpu_via_init(apicid, start_ip); +} - if (!boot_error) { - /* - * Wait till AP completes initial initialization - */ - while (!cpumask_test_cpu(cpu, cpu_callin_mask)) { - /* - * Allow other tasks to run while we wait for the - * AP to come online. This also gives a chance - * for the MTRR work(triggered by the AP coming online) - * to be completed in the stop machine context. - */ - schedule(); - } - } +static int wait_cpu_cpumask(unsigned int cpu, const struct cpumask *mask) +{ + unsigned long timeout; - if (x86_platform.legacy.warm_reset) { - /* - * Cleanup possible dangling ends... - */ - smpboot_restore_warm_reset_vector(); + /* + * Wait up to 10s for the CPU to report in. + */ + timeout = jiffies + 10*HZ; + while (time_before(jiffies, timeout)) { + if (cpumask_test_cpu(cpu, mask)) + return 0; + + schedule(); } + return -1; +} - return boot_error; +/* + * Bringup step two: Wait for the target AP to reach cpu_init_secondary() + * and thus wait_for_master_cpu(), then set cpu_callout_mask to allow it + * to proceed. The AP will then proceed past setting its 'callin' bit + * and end up waiting in check_tsc_sync_target() until we reach + * do_wait_cpu_online() to tend to it. + */ +static int wait_cpu_initialized(unsigned int cpu) +{ + /* + * Wait for first sign of life from AP. + */ + if (wait_cpu_cpumask(cpu, cpu_initialized_mask)) + return -1; + + cpumask_set_cpu(cpu, cpu_callout_mask); + return 0; } -int native_cpu_up(unsigned int cpu, struct task_struct *tidle) +/* + * Bringup step three: Wait for the target AP to reach smp_callin(). + * The AP is not waiting for us here so we don't need to parallelise + * this step. Not entirely clear why we care about this, since we just + * proceed directly to TSC synchronization which is the next sync + * point with the AP anyway. + */ +static void wait_cpu_callin(unsigned int cpu) +{ + while (!cpumask_test_cpu(cpu, cpu_callin_mask)) + schedule(); +} + +/* + * Bringup step four: Synchronize the TSC and wait for the target AP + * to reach set_cpu_online() in start_secondary(). + */ +static void wait_cpu_online(unsigned int cpu) { - int apicid = apic->cpu_present_to_apicid(cpu); unsigned long flags; + + /* + * Check TSC synchronization with the AP (keep irqs disabled + * while doing so): + */ + local_irq_save(flags); + check_tsc_sync_source(cpu); + local_irq_restore(flags); + + /* + * Wait for the AP to mark itself online, so the core caller + * can drop sparse_irq_lock. + */ + while (!cpu_online(cpu)) + schedule(); +} + +static int native_kick_ap(unsigned int cpu, struct task_struct *tidle) +{ + int apicid = apic->cpu_present_to_apicid(cpu); int err; lockdep_assert_irqs_enabled(); @@ -1142,25 +1189,33 @@ int native_cpu_up(unsigned int cpu, stru return err; err = do_boot_cpu(apicid, cpu, tidle); - if (err) { + if (err) pr_err("do_boot_cpu failed(%d) to wakeup CPU#%u\n", err, cpu); - return err; - } - /* - * Check TSC synchronization with the AP (keep irqs disabled - * while doing so): - */ - local_irq_save(flags); - check_tsc_sync_source(cpu); - local_irq_restore(flags); + return err; +} - while (!cpu_online(cpu)) { - cpu_relax(); - touch_nmi_watchdog(); - } +int native_cpu_up(unsigned int cpu, struct task_struct *tidle) +{ + int ret; - return 0; + ret = native_kick_ap(cpu, tidle); + if (ret) + goto out; + + ret = wait_cpu_initialized(cpu); + if (ret) + goto out; + + wait_cpu_callin(cpu); + wait_cpu_online(cpu); + +out: + /* Cleanup possible dangling ends... */ + if (x86_platform.legacy.warm_reset) + smpboot_restore_warm_reset_vector(); + + return ret; } /** From xen-devel-bounces@lists.xenproject.org Thu May 04 19:02:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:02:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529893.824902 (Exim 4.92) (envelope-from ) id 1pueDY-0006Vy-7L; Thu, 04 May 2023 19:02:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529893.824902; Thu, 04 May 2023 19:02:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDY-0006Vl-2N; Thu, 04 May 2023 19:02:16 +0000 Received: by outflank-mailman (input) for mailman id 529893; Thu, 04 May 2023 19:02:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDW-00042j-AX for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:14 +0000 Received: from galois.linutronix.de (galois.linutronix.de [2a0a:51c0:0:12e:550::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2e1282a7-eaae-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:02:13 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e1282a7-eaae-11ed-b226-6b7b168915f2 Message-ID: <20230504185936.802783450@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226933; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=djhcX/6oz1v3ZZHjWNR6fK2ATXnp39FPHavEh8Z2jPk=; b=ga7wmIakplENkJi6T5NoX0Dl4GKg+ap6nn7fRMuH4AJ0N/j8tLX4hOYKXxI82FfjNe6bvd vJmMRr19EbOXhlvWVBPj00971oHJ7EVwTVpYtKkKm1bHOPAtWTEqef+PWJeugHX4N45lMG uoAym6vetzrOuFxrlyf44EwZaO13wrZDfo/XkIGx0LvkxSOhnQMBCiqIzIQDgAgSp3wxnj y26KQIzEJjp7eB7O+cYD+6cb4y96+ikG+vSFWeNtad9FTEpCRcUHe+gEoz7H09GJDNgB1J AKbp/YjUjDEWvORBc7uiaoZEw4Hkz37CASo4CL84FTmpzcTx9pDR5194rYnnxw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226933; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=djhcX/6oz1v3ZZHjWNR6fK2ATXnp39FPHavEh8Z2jPk=; b=9d54JiewPSGmVQNrhzbBmbqIIQ6FHVsRs8p39dYcszm+2PpRs6UAq3uJ7Lp1hIlyibfgPq eWLViIKxHt4DgPAQ== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch V2 09/38] x86/smpboot: Get rid of cpu_init_secondary() References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:13 +0200 (CEST) From: Thomas Gleixner The synchronization of the AP with the control CPU is a SMP boot problem and has nothing to do with cpu_init(). Open code cpu_init_secondary() in start_secondary() and move wait_for_master_cpu() into the SMP boot code. No functional change. Signed-off-by: Thomas Gleixner --- arch/x86/include/asm/processor.h | 1 - arch/x86/kernel/cpu/common.c | 27 --------------------------- arch/x86/kernel/smpboot.c | 24 +++++++++++++++++++----- 3 files changed, 19 insertions(+), 33 deletions(-) --- --- a/arch/x86/include/asm/processor.h +++ b/arch/x86/include/asm/processor.h @@ -551,7 +551,6 @@ extern void switch_gdt_and_percpu_base(i extern void load_direct_gdt(int); extern void load_fixmap_gdt(int); extern void cpu_init(void); -extern void cpu_init_secondary(void); extern void cpu_init_exception_handling(void); extern void cr4_init(void); --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -2123,19 +2123,6 @@ static void dbg_restore_debug_regs(void) #define dbg_restore_debug_regs() #endif /* ! CONFIG_KGDB */ -static void wait_for_master_cpu(int cpu) -{ -#ifdef CONFIG_SMP - /* - * wait for ACK from master CPU before continuing - * with AP initialization - */ - WARN_ON(cpumask_test_and_set_cpu(cpu, cpu_initialized_mask)); - while (!cpumask_test_cpu(cpu, cpu_callout_mask)) - cpu_relax(); -#endif -} - static inline void setup_getcpu(int cpu) { unsigned long cpudata = vdso_encode_cpunode(cpu, early_cpu_to_node(cpu)); @@ -2239,8 +2226,6 @@ void cpu_init(void) struct task_struct *cur = current; int cpu = raw_smp_processor_id(); - wait_for_master_cpu(cpu); - ucode_cpu_init(cpu); #ifdef CONFIG_NUMA @@ -2293,18 +2278,6 @@ void cpu_init(void) load_fixmap_gdt(cpu); } -#ifdef CONFIG_SMP -void cpu_init_secondary(void) -{ - /* - * Relies on the BP having set-up the IDT tables, which are loaded - * on this CPU in cpu_init_exception_handling(). - */ - cpu_init_exception_handling(); - cpu_init(); -} -#endif - #ifdef CONFIG_MICROCODE_LATE_LOADING /** * store_cpu_caps() - Store a snapshot of CPU capabilities --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -220,6 +220,17 @@ static void ap_calibrate_delay(void) cpu_data(smp_processor_id()).loops_per_jiffy = loops_per_jiffy; } +static void wait_for_master_cpu(int cpu) +{ + /* + * Wait for release by control CPU before continuing with AP + * initialization. + */ + WARN_ON(cpumask_test_and_set_cpu(cpu, cpu_initialized_mask)); + while (!cpumask_test_cpu(cpu, cpu_callout_mask)) + cpu_relax(); +} + /* * Activate a secondary processor. */ @@ -237,13 +248,16 @@ static void notrace start_secondary(void load_cr3(swapper_pg_dir); __flush_tlb_all(); #endif + cpu_init_exception_handling(); + /* - * Sync point with wait_cpu_initialized(). Before proceeding through - * cpu_init(), the AP will call wait_for_master_cpu() which sets its - * own bit in cpu_initialized_mask and then waits for the BSP to set - * its bit in cpu_callout_mask to release it. + * Sync point with wait_cpu_initialized(). Sets AP in + * cpu_initialized_mask and then waits for the control CPU + * to release it. */ - cpu_init_secondary(); + wait_for_master_cpu(raw_smp_processor_id()); + + cpu_init(); rcu_cpu_starting(raw_smp_processor_id()); x86_cpuinit.early_percpu_clock_init(); From xen-devel-bounces@lists.xenproject.org Thu May 04 19:02:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:02:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529894.824913 (Exim 4.92) (envelope-from ) id 1pueDZ-0006nG-Jv; Thu, 04 May 2023 19:02:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529894.824913; Thu, 04 May 2023 19:02:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDZ-0006mW-EI; Thu, 04 May 2023 19:02:17 +0000 Received: by outflank-mailman (input) for mailman id 529894; Thu, 04 May 2023 19:02:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDY-00042j-2P for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:16 +0000 Received: from galois.linutronix.de (galois.linutronix.de [2a0a:51c0:0:12e:550::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2f2befae-eaae-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:02:15 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2f2befae-eaae-11ed-b226-6b7b168915f2 Message-ID: <20230504185936.858063589@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226935; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=Oe/ZjwkRBSSl6siLO6072dd5g+eXgR8KPUDyURiw97E=; b=XFhnPlTMh9p61J4utErL2GrNxXeTPXLjb8cWdDUXCXr3KT5am1Ro8sgXd/oHEQe8xcfaKn XvBjK3bjPW274k7B3BA8GTqBl9J8B4hcaJ6fhMce4VcINARE+ROIpWv777g9FEinlrf3KP 2BncinPttT1cKxKjc1GNl7EgBMoSP2hFeg6lIh3qLpAkyqMMGNy1faixInDunKcxvGKZ/2 OqP65vuMXtHJ1FRwPGXBbsUOQZ6+3Am+8zuc5DTudqWBQfvITGZKgf6z6Jn8Uqd9+HB+x9 +wGxFdwo/EPews1TdSiM3V3T23ps0A6doGUh4PAL3mLBHykinvz3pA2i2ONykA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226935; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=Oe/ZjwkRBSSl6siLO6072dd5g+eXgR8KPUDyURiw97E=; b=2dY4x4BcncRyoBpkMaEwKJqbyCatsbUKyBYFOZIQcYW7WtnHHDD/v5wu7am6DZnlToQwCT FkpvVldlmNw8qgCw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch V2 10/38] x86/cpu/cacheinfo: Remove cpu_callout_mask dependency References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:14 +0200 (CEST) From: Thomas Gleixner cpu_callout_mask is used for the stop machine based MTRR/PAT init. In preparation of moving the BP/AP synchronization to the core hotplug code, use a private CPU mask for cacheinfo and manage it in the starting/dying hotplug state. Signed-off-by: Thomas Gleixner --- arch/x86/kernel/cpu/cacheinfo.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) --- --- a/arch/x86/kernel/cpu/cacheinfo.c +++ b/arch/x86/kernel/cpu/cacheinfo.c @@ -39,6 +39,8 @@ DEFINE_PER_CPU_READ_MOSTLY(cpumask_var_t /* Shared L2 cache maps */ DEFINE_PER_CPU_READ_MOSTLY(cpumask_var_t, cpu_l2c_shared_map); +static cpumask_var_t cpu_cacheinfo_mask; + /* Kernel controls MTRR and/or PAT MSRs. */ unsigned int memory_caching_control __ro_after_init; @@ -1172,8 +1174,10 @@ void cache_bp_restore(void) cache_cpu_init(); } -static int cache_ap_init(unsigned int cpu) +static int cache_ap_online(unsigned int cpu) { + cpumask_set_cpu(cpu, cpu_cacheinfo_mask); + if (!memory_caching_control || get_cache_aps_delayed_init()) return 0; @@ -1191,11 +1195,17 @@ static int cache_ap_init(unsigned int cp * lock to prevent MTRR entry changes */ stop_machine_from_inactive_cpu(cache_rendezvous_handler, NULL, - cpu_callout_mask); + cpu_cacheinfo_mask); return 0; } +static int cache_ap_offline(unsigned int cpu) +{ + cpumask_clear_cpu(cpu, cpu_cacheinfo_mask); + return 0; +} + /* * Delayed cache initialization for all AP's */ @@ -1210,9 +1220,12 @@ void cache_aps_init(void) static int __init cache_ap_register(void) { + zalloc_cpumask_var(&cpu_cacheinfo_mask, GFP_KERNEL); + cpumask_set_cpu(smp_processor_id(), cpu_cacheinfo_mask); + cpuhp_setup_state_nocalls(CPUHP_AP_CACHECTRL_STARTING, "x86/cachectrl:starting", - cache_ap_init, NULL); + cache_ap_online, cache_ap_offline); return 0; } -core_initcall(cache_ap_register); +early_initcall(cache_ap_register); From xen-devel-bounces@lists.xenproject.org Thu May 04 19:02:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:02:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529895.824923 (Exim 4.92) (envelope-from ) id 1pueDc-0007EZ-DL; Thu, 04 May 2023 19:02:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529895.824923; Thu, 04 May 2023 19:02:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDc-0007E2-66; Thu, 04 May 2023 19:02:20 +0000 Received: by outflank-mailman (input) for mailman id 529895; Thu, 04 May 2023 19:02:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDa-00042k-Ky for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:18 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 30037478-eaae-11ed-8611-37d641c3527e; Thu, 04 May 2023 21:02:17 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 30037478-eaae-11ed-8611-37d641c3527e Message-ID: <20230504185936.917560748@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226936; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=7w0pkJKfi5BfzTn7YraeCXszLQVgaQibx9fCVrsyYLw=; b=KF4OYjBu/WAVy3JeYBlPGuO/psPpP6BNMkGwUP4hVxM+/D+l51OxcfTtr1678q7sAM86+l pkSbimwtfW+4xdLulA4/Enq9nqbfEKxZaT/IcZ6t/X1KbwGa9K46/CqLa2h1H1kz8voODT y4AmfcuAbs0leulnqDLnh1gIEYzNbs3Hpt0le/7AsOwR44b/CdgLPyNGYtpoteTh4TSBz6 xBxTc2mzXrBGxYo6rlw1ZlvxoGPyU9ZhtpO28GI1g1d9zu8k+2yJftFOirkgMuWcP7q1P8 AsSeoEHmtH0f/Ry8sbvPf/V1KSj5/DXRuhM2P4J01rZzTyifP9FYxFi1Q1uu8g== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226936; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=7w0pkJKfi5BfzTn7YraeCXszLQVgaQibx9fCVrsyYLw=; b=AOLL7N8FlgTgX4Vpe4Ih6WqHRrBw5YfnEZjwda6Z8s/doyNG0e8UyHLJJ/7vaMaivGQ2TR 0D5J6mUQhC4iKrBA== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch V2 11/38] x86/smpboot: Move synchronization masks to SMP boot code References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:16 +0200 (CEST) From: Thomas Gleixner The usage is in smpboot.c and not in the CPU initialization code. The XEN_PV usage of cpu_callout_mask is obsolete as cpu_init() not longer waits and cacheinfo has its own CPU mask now, so cpu_callout_mask can be made static too. Signed-off-by: Thomas Gleixner --- arch/x86/include/asm/cpumask.h | 5 ----- arch/x86/kernel/cpu/common.c | 17 ----------------- arch/x86/kernel/smpboot.c | 16 ++++++++++++++++ arch/x86/xen/smp_pv.c | 3 --- 4 files changed, 16 insertions(+), 25 deletions(-) --- --- a/arch/x86/include/asm/cpumask.h +++ b/arch/x86/include/asm/cpumask.h @@ -4,11 +4,6 @@ #ifndef __ASSEMBLY__ #include -extern cpumask_var_t cpu_callin_mask; -extern cpumask_var_t cpu_callout_mask; -extern cpumask_var_t cpu_initialized_mask; -extern cpumask_var_t cpu_sibling_setup_mask; - extern void setup_cpu_local_masks(void); /* --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -67,14 +67,6 @@ u32 elf_hwcap2 __read_mostly; -/* all of these masks are initialized in setup_cpu_local_masks() */ -cpumask_var_t cpu_initialized_mask; -cpumask_var_t cpu_callout_mask; -cpumask_var_t cpu_callin_mask; - -/* representing cpus for which sibling maps can be computed */ -cpumask_var_t cpu_sibling_setup_mask; - /* Number of siblings per CPU package */ int smp_num_siblings = 1; EXPORT_SYMBOL(smp_num_siblings); @@ -169,15 +161,6 @@ static void ppin_init(struct cpuinfo_x86 clear_cpu_cap(c, info->feature); } -/* correctly size the local cpu masks */ -void __init setup_cpu_local_masks(void) -{ - alloc_bootmem_cpumask_var(&cpu_initialized_mask); - alloc_bootmem_cpumask_var(&cpu_callin_mask); - alloc_bootmem_cpumask_var(&cpu_callout_mask); - alloc_bootmem_cpumask_var(&cpu_sibling_setup_mask); -} - static void default_init(struct cpuinfo_x86 *c) { #ifdef CONFIG_X86_64 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -101,6 +101,13 @@ EXPORT_PER_CPU_SYMBOL(cpu_die_map); DEFINE_PER_CPU_READ_MOSTLY(struct cpuinfo_x86, cpu_info); EXPORT_PER_CPU_SYMBOL(cpu_info); +/* All of these masks are initialized in setup_cpu_local_masks() */ +static cpumask_var_t cpu_initialized_mask; +static cpumask_var_t cpu_callout_mask; +static cpumask_var_t cpu_callin_mask; +/* Representing CPUs for which sibling maps can be computed */ +static cpumask_var_t cpu_sibling_setup_mask; + /* Logical package management. We might want to allocate that dynamically */ unsigned int __max_logical_packages __read_mostly; EXPORT_SYMBOL(__max_logical_packages); @@ -1548,6 +1555,15 @@ early_param("possible_cpus", _setup_poss set_cpu_possible(i, true); } +/* correctly size the local cpu masks */ +void __init setup_cpu_local_masks(void) +{ + alloc_bootmem_cpumask_var(&cpu_initialized_mask); + alloc_bootmem_cpumask_var(&cpu_callin_mask); + alloc_bootmem_cpumask_var(&cpu_callout_mask); + alloc_bootmem_cpumask_var(&cpu_sibling_setup_mask); +} + #ifdef CONFIG_HOTPLUG_CPU /* Recompute SMT state for all CPUs on offline */ --- a/arch/x86/xen/smp_pv.c +++ b/arch/x86/xen/smp_pv.c @@ -254,15 +254,12 @@ cpu_initialize_context(unsigned int cpu, struct desc_struct *gdt; unsigned long gdt_mfn; - /* used to tell cpu_init() that it can proceed with initialization */ - cpumask_set_cpu(cpu, cpu_callout_mask); if (cpumask_test_and_set_cpu(cpu, xen_cpu_initialized_map)) return 0; ctxt = kzalloc(sizeof(*ctxt), GFP_KERNEL); if (ctxt == NULL) { cpumask_clear_cpu(cpu, xen_cpu_initialized_map); - cpumask_clear_cpu(cpu, cpu_callout_mask); return -ENOMEM; } From xen-devel-bounces@lists.xenproject.org Thu May 04 19:02:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:02:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529896.824933 (Exim 4.92) (envelope-from ) id 1pueDe-0007g9-SP; Thu, 04 May 2023 19:02:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529896.824933; Thu, 04 May 2023 19:02:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDe-0007ft-Mh; Thu, 04 May 2023 19:02:22 +0000 Received: by outflank-mailman (input) for mailman id 529896; Thu, 04 May 2023 19:02:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDc-00042k-Ar for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:20 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 30fe1cf7-eaae-11ed-8611-37d641c3527e; Thu, 04 May 2023 21:02:18 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 30fe1cf7-eaae-11ed-8611-37d641c3527e Message-ID: <20230504185936.974986973@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226938; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=RWqZkjYspaeM2luDJ1kekjLX+eDwzhj89fWzaE+vcuc=; b=TB5oV9Aq6dUI1CYTG3Mfudq6NtZlPsW1Oex7yGf2LM/kO8/BZ25DUu+2zHE2ckb9PInfKC ThIb3r9/3b15wBd6uRdROhA10S5AgTJxEM2bEGeorA2NaJWuHDmSYm2szq80TnIJGzO87r 81wUI2m9b4yt/h5OEp4tiu/Eej4ESXtZF7nf623HNABJkB4ypUwiLWY/CryJlS2D49iF4g VpdQdELsDbtjD2eM41gRwO8hH6r1xMhcJOplan7xyugn92wquyXDsHqitGavw4pzelheUe iefDvimqKcNsabrSPDXx2VGoczs/C1VurUq3fWakhAv9b6MMDMg5hc8nUdPY/A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226938; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=RWqZkjYspaeM2luDJ1kekjLX+eDwzhj89fWzaE+vcuc=; b=iEvC6KRjnzhtqcLL+LMevDrfOV+QfKnfRTDjoCA4Yw0ERn9sWjSc3oID7BBkVgcY89imxw v8or+5vf+SaSUADQ== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch V2 12/38] x86/smpboot: Make TSC synchronization function call based References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:17 +0200 (CEST) From: Thomas Gleixner Spin-waiting on the control CPU until the AP reaches the TSC synchronization is just a waste especially in the case that there is no synchronization required. As the synchronization has to run with interrupts disabled the control CPU part can just be done from a SMP function call. The upcoming AP issues that call async only in the case that synchronization is required. Signed-off-by: Thomas Gleixner --- arch/x86/include/asm/tsc.h | 2 -- arch/x86/kernel/smpboot.c | 20 +++----------------- arch/x86/kernel/tsc_sync.c | 36 +++++++++++------------------------- 3 files changed, 14 insertions(+), 44 deletions(-) --- --- a/arch/x86/include/asm/tsc.h +++ b/arch/x86/include/asm/tsc.h @@ -55,12 +55,10 @@ extern bool tsc_async_resets; #ifdef CONFIG_X86_TSC extern bool tsc_store_and_check_tsc_adjust(bool bootcpu); extern void tsc_verify_tsc_adjust(bool resume); -extern void check_tsc_sync_source(int cpu); extern void check_tsc_sync_target(void); #else static inline bool tsc_store_and_check_tsc_adjust(bool bootcpu) { return false; } static inline void tsc_verify_tsc_adjust(bool resume) { } -static inline void check_tsc_sync_source(int cpu) { } static inline void check_tsc_sync_target(void) { } #endif --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -278,11 +278,7 @@ static void notrace start_secondary(void /* Otherwise gcc will move up smp_processor_id() before cpu_init() */ barrier(); - /* - * Check TSC synchronization with the control CPU, which will do - * its part of this from wait_cpu_online(), making it an implicit - * synchronization point. - */ + /* Check TSC synchronization with the control CPU. */ check_tsc_sync_target(); /* @@ -1144,21 +1140,11 @@ static void wait_cpu_callin(unsigned int } /* - * Bringup step four: Synchronize the TSC and wait for the target AP - * to reach set_cpu_online() in start_secondary(). + * Bringup step four: Wait for the target AP to reach set_cpu_online() in + * start_secondary(). */ static void wait_cpu_online(unsigned int cpu) { - unsigned long flags; - - /* - * Check TSC synchronization with the AP (keep irqs disabled - * while doing so): - */ - local_irq_save(flags); - check_tsc_sync_source(cpu); - local_irq_restore(flags); - /* * Wait for the AP to mark itself online, so the core caller * can drop sparse_irq_lock. --- a/arch/x86/kernel/tsc_sync.c +++ b/arch/x86/kernel/tsc_sync.c @@ -245,7 +245,6 @@ bool tsc_store_and_check_tsc_adjust(bool */ static atomic_t start_count; static atomic_t stop_count; -static atomic_t skip_test; static atomic_t test_runs; /* @@ -344,21 +343,14 @@ static inline unsigned int loop_timeout( } /* - * Source CPU calls into this - it waits for the freshly booted - * target CPU to arrive and then starts the measurement: + * The freshly booted CPU initiates this via an async SMP function call. */ -void check_tsc_sync_source(int cpu) +static void check_tsc_sync_source(void *__cpu) { + unsigned int cpu = (unsigned long)__cpu; int cpus = 2; /* - * No need to check if we already know that the TSC is not - * synchronized or if we have no TSC. - */ - if (unsynchronized_tsc()) - return; - - /* * Set the maximum number of test runs to * 1 if the CPU does not provide the TSC_ADJUST MSR * 3 if the MSR is available, so the target can try to adjust @@ -368,16 +360,9 @@ void check_tsc_sync_source(int cpu) else atomic_set(&test_runs, 3); retry: - /* - * Wait for the target to start or to skip the test: - */ - while (atomic_read(&start_count) != cpus - 1) { - if (atomic_read(&skip_test) > 0) { - atomic_set(&skip_test, 0); - return; - } + /* Wait for the target to start. */ + while (atomic_read(&start_count) != cpus - 1) cpu_relax(); - } /* * Trigger the target to continue into the measurement too: @@ -397,14 +382,14 @@ void check_tsc_sync_source(int cpu) if (!nr_warps) { atomic_set(&test_runs, 0); - pr_debug("TSC synchronization [CPU#%d -> CPU#%d]: passed\n", + pr_debug("TSC synchronization [CPU#%d -> CPU#%u]: passed\n", smp_processor_id(), cpu); } else if (atomic_dec_and_test(&test_runs) || random_warps) { /* Force it to 0 if random warps brought us here */ atomic_set(&test_runs, 0); - pr_warn("TSC synchronization [CPU#%d -> CPU#%d]:\n", + pr_warn("TSC synchronization [CPU#%d -> CPU#%u]:\n", smp_processor_id(), cpu); pr_warn("Measured %Ld cycles TSC warp between CPUs, " "turning off TSC clock.\n", max_warp); @@ -457,11 +442,12 @@ void check_tsc_sync_target(void) * SoCs the TSC is frequency synchronized, but still the TSC ADJUST * register might have been wreckaged by the BIOS.. */ - if (tsc_store_and_check_tsc_adjust(false) || tsc_clocksource_reliable) { - atomic_inc(&skip_test); + if (tsc_store_and_check_tsc_adjust(false) || tsc_clocksource_reliable) return; - } + /* Kick the control CPU into the TSC synchronization function */ + smp_call_function_single(cpumask_first(cpu_online_mask), check_tsc_sync_source, + (unsigned long *)(unsigned long)cpu, 0); retry: /* * Register this CPU's participation and wait for the From xen-devel-bounces@lists.xenproject.org Thu May 04 19:02:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:02:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529898.824939 (Exim 4.92) (envelope-from ) id 1pueDf-0007or-Oy; Thu, 04 May 2023 19:02:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529898.824939; Thu, 04 May 2023 19:02:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDf-0007jd-3m; Thu, 04 May 2023 19:02:23 +0000 Received: by outflank-mailman (input) for mailman id 529898; Thu, 04 May 2023 19:02:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDc-00042j-S2 for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:20 +0000 Received: from galois.linutronix.de (galois.linutronix.de [2a0a:51c0:0:12e:550::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 31f3ebd1-eaae-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:02:20 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 31f3ebd1-eaae-11ed-b226-6b7b168915f2 Message-ID: <20230504185937.031599435@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226940; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=kEfrtWr4PgKjoC3uLMIgq7wwpzWxMcfb80JJcMYPrNo=; b=PmeJbSUkoSGxnlVzLJXUvjH48dikWh6/q5JUoaP/Nq1/Ww69G3R8FGSMzpcyfgrbQmJWPS L1voUlN08pCvhmk6/QZrwPjAlPy1WtF3SmmFaso8csKdSwgSj+Xrh0yxgNvs9UWRGz4C7i 363j0HgkKBjg4ZGOGH5SMTymlwml0+zJzHFJoBLLKJNEm7WITc1vHb3UDkvrXQbf+dNpB1 VNDwuviXGLHURwt2oOpvvRZjYyIp2mbeTsBXGfdQ/vyCHUYkflxEUN3y3vqtAgWpyktb4q t022EVpGgFL77pRnNi56GuH4R9mqq/EtBm5ZisWdMifcZ+kMZTibAs3llShwcg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226940; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=kEfrtWr4PgKjoC3uLMIgq7wwpzWxMcfb80JJcMYPrNo=; b=dKl/1HBoUECGor2iJDs5A3fYWbTcWkykgPuLe6FZ3+pVZqFoQN8p5o4X0DvHU0A/AOKXEN mUmNYqpZZv5DVhDw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch V2 13/38] x86/smpboot: Remove cpu_callin_mask References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:19 +0200 (CEST) From: Thomas Gleixner Now that TSC synchronization is SMP function call based there is no reason to wait for the AP to be set in smp_callin_mask. The control CPU waits for the AP to set itself in the online mask anyway. Signed-off-by: Thomas Gleixner --- arch/x86/kernel/smpboot.c | 61 +++++++--------------------------------------- 1 file changed, 10 insertions(+), 51 deletions(-) --- --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -104,7 +104,6 @@ EXPORT_PER_CPU_SYMBOL(cpu_info); /* All of these masks are initialized in setup_cpu_local_masks() */ static cpumask_var_t cpu_initialized_mask; static cpumask_var_t cpu_callout_mask; -static cpumask_var_t cpu_callin_mask; /* Representing CPUs for which sibling maps can be computed */ static cpumask_var_t cpu_sibling_setup_mask; @@ -167,21 +166,16 @@ static inline void smpboot_restore_warm_ */ static void smp_callin(void) { - int cpuid; + int cpuid = smp_processor_id(); /* * If waken up by an INIT in an 82489DX configuration - * cpu_callout_mask guarantees we don't get here before - * an INIT_deassert IPI reaches our local APIC, so it is - * now safe to touch our local APIC. - */ - cpuid = smp_processor_id(); - - /* - * the boot CPU has finished the init stage and is spinning - * on callin_map until we finish. We are free to set up this - * CPU, first the APIC. (this is probably redundant on most - * boards) + * cpu_callout_mask guarantees we don't get here before an + * INIT_deassert IPI reaches our local APIC, so it is now safe to + * touch our local APIC. + * + * Set up this CPU, first the APIC, which is probably redundant on + * most boards. */ apic_ap_setup(); @@ -192,7 +186,7 @@ static void smp_callin(void) * The topology information must be up to date before * calibrate_delay() and notify_cpu_starting(). */ - set_cpu_sibling_map(raw_smp_processor_id()); + set_cpu_sibling_map(cpuid); ap_init_aperfmperf(); @@ -205,11 +199,6 @@ static void smp_callin(void) * state (CPUHP_ONLINE in the case of serial bringup). */ notify_cpu_starting(cpuid); - - /* - * Allow the master to continue. - */ - cpumask_set_cpu(cpuid, cpu_callin_mask); } static void ap_calibrate_delay(void) @@ -268,11 +257,6 @@ static void notrace start_secondary(void rcu_cpu_starting(raw_smp_processor_id()); x86_cpuinit.early_percpu_clock_init(); - /* - * Sync point with wait_cpu_callin(). The AP doesn't wait here - * but just sets the bit to let the controlling CPU (BSP) know that - * it's got this far. - */ smp_callin(); /* Otherwise gcc will move up smp_processor_id() before cpu_init() */ @@ -1112,7 +1096,7 @@ static int wait_cpu_cpumask(unsigned int * and thus wait_for_master_cpu(), then set cpu_callout_mask to allow it * to proceed. The AP will then proceed past setting its 'callin' bit * and end up waiting in check_tsc_sync_target() until we reach - * do_wait_cpu_online() to tend to it. + * wait_cpu_online() to tend to it. */ static int wait_cpu_initialized(unsigned int cpu) { @@ -1127,20 +1111,7 @@ static int wait_cpu_initialized(unsigned } /* - * Bringup step three: Wait for the target AP to reach smp_callin(). - * The AP is not waiting for us here so we don't need to parallelise - * this step. Not entirely clear why we care about this, since we just - * proceed directly to TSC synchronization which is the next sync - * point with the AP anyway. - */ -static void wait_cpu_callin(unsigned int cpu) -{ - while (!cpumask_test_cpu(cpu, cpu_callin_mask)) - schedule(); -} - -/* - * Bringup step four: Wait for the target AP to reach set_cpu_online() in + * Bringup step three: Wait for the target AP to reach set_cpu_online() in * start_secondary(). */ static void wait_cpu_online(unsigned int cpu) @@ -1170,14 +1141,6 @@ static int native_kick_ap(unsigned int c } /* - * Already booted CPU? - */ - if (cpumask_test_cpu(cpu, cpu_callin_mask)) { - pr_debug("do_boot_cpu %d Already started\n", cpu); - return -ENOSYS; - } - - /* * Save current MTRR state in case it was changed since early boot * (e.g. by the ACPI SMI) to initialize new CPUs with MTRRs in sync: */ @@ -1214,7 +1177,6 @@ int native_cpu_up(unsigned int cpu, stru if (ret) goto out; - wait_cpu_callin(cpu); wait_cpu_online(cpu); out: @@ -1330,7 +1292,6 @@ void __init smp_prepare_cpus_common(void * Setup boot CPU information */ smp_store_boot_cpu_info(); /* Final full version of the data */ - cpumask_copy(cpu_callin_mask, cpumask_of(0)); mb(); for_each_possible_cpu(i) { @@ -1545,7 +1506,6 @@ early_param("possible_cpus", _setup_poss void __init setup_cpu_local_masks(void) { alloc_bootmem_cpumask_var(&cpu_initialized_mask); - alloc_bootmem_cpumask_var(&cpu_callin_mask); alloc_bootmem_cpumask_var(&cpu_callout_mask); alloc_bootmem_cpumask_var(&cpu_sibling_setup_mask); } @@ -1609,7 +1569,6 @@ static void remove_cpu_from_maps(int cpu { set_cpu_online(cpu, false); cpumask_clear_cpu(cpu, cpu_callout_mask); - cpumask_clear_cpu(cpu, cpu_callin_mask); /* was set by cpu_init() */ cpumask_clear_cpu(cpu, cpu_initialized_mask); numa_remove_cpu(cpu); From xen-devel-bounces@lists.xenproject.org Thu May 04 19:02:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:02:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529899.824942 (Exim 4.92) (envelope-from ) id 1pueDg-0007vg-7w; Thu, 04 May 2023 19:02:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529899.824942; Thu, 04 May 2023 19:02:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDf-0007u5-Qb; Thu, 04 May 2023 19:02:23 +0000 Received: by outflank-mailman (input) for mailman id 529899; Thu, 04 May 2023 19:02:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDe-00042j-9G for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:22 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 32e2137c-eaae-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:02:21 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 32e2137c-eaae-11ed-b226-6b7b168915f2 Message-ID: <20230504185937.088861348@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226941; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=waR3DpyQ6DyvK8jEESlEb5rxqBYC2I7FeZ3H8ZtIrVQ=; b=HKYLcl9cklgr6YO5/NspFjC+D2CCt/ZYWzxxiOOGuCX7u/7IGOq81DQhVq9PvbBHY6Kpcr SxWHo0Ub70GUTAFkoXjKOB1ZyWdtlCAv2pBsav0oFkFgcMqJgiDoblcu2Hnt6D2hLbDJE7 kec7wtFBfE1xoWI2cME3sJv8K73WrIvhYqzB8k1hCePY7f28tWiYPkzCL3lKJ1aAZjMvt+ kXyU82XPa0OHMGsQ8hlC+TxCd6BOdr1gglOHT1fZhwBJGZCjFBU2Yxs7+XALa+aaWrMaCV mvw2zjNCImLQQhSEXScVL50CeJT6NF1GH6WIuPs8AGymg+ULRPU3wowu71D4Lw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226941; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=waR3DpyQ6DyvK8jEESlEb5rxqBYC2I7FeZ3H8ZtIrVQ=; b=XDnjEy7a3qUl/tWMxBUIj3PidEk2DRdxC5hulFnew5UcHpu5yRDRS/g5aolbe6p1RMLJCX rQwCSliTpoNYDfAw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch V2 14/38] cpu/hotplug: Rework sparse_irq locking in bringup_cpu() References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:21 +0200 (CEST) From: Thomas Gleixner There is no harm to hold sparse_irq lock until the upcoming CPU completes in cpuhp_online_idle(). This allows to remove cpu_online() synchronization from architecture code. Signed-off-by: Thomas Gleixner --- kernel/cpu.c | 28 +++++++++++++++++++--------- 1 file changed, 19 insertions(+), 9 deletions(-) --- --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -558,7 +558,7 @@ static int cpuhp_kick_ap(int cpu, struct return ret; } -static int bringup_wait_for_ap(unsigned int cpu) +static int bringup_wait_for_ap_online(unsigned int cpu) { struct cpuhp_cpu_state *st = per_cpu_ptr(&cpuhp_state, cpu); @@ -579,15 +579,12 @@ static int bringup_wait_for_ap(unsigned */ if (!cpu_smt_allowed(cpu)) return -ECANCELED; - - if (st->target <= CPUHP_AP_ONLINE_IDLE) - return 0; - - return cpuhp_kick_ap(cpu, st, st->target); + return 0; } static int bringup_cpu(unsigned int cpu) { + struct cpuhp_cpu_state *st = per_cpu_ptr(&cpuhp_state, cpu); struct task_struct *idle = idle_thread_get(cpu); int ret; @@ -606,10 +603,23 @@ static int bringup_cpu(unsigned int cpu) /* Arch-specific enabling code. */ ret = __cpu_up(cpu, idle); - irq_unlock_sparse(); if (ret) - return ret; - return bringup_wait_for_ap(cpu); + goto out_unlock; + + ret = bringup_wait_for_ap_online(cpu); + if (ret) + goto out_unlock; + + irq_unlock_sparse(); + + if (st->target <= CPUHP_AP_ONLINE_IDLE) + return 0; + + return cpuhp_kick_ap(cpu, st, st->target); + +out_unlock: + irq_unlock_sparse(); + return ret; } static int finish_cpu(unsigned int cpu) From xen-devel-bounces@lists.xenproject.org Thu May 04 19:02:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:02:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529901.824958 (Exim 4.92) (envelope-from ) id 1pueDi-0000G2-Uy; Thu, 04 May 2023 19:02:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529901.824958; Thu, 04 May 2023 19:02:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDi-0000BF-BD; Thu, 04 May 2023 19:02:26 +0000 Received: by outflank-mailman (input) for mailman id 529901; Thu, 04 May 2023 19:02:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDf-00042j-Vf for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:23 +0000 Received: from galois.linutronix.de (galois.linutronix.de [2a0a:51c0:0:12e:550::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 33e3e5b7-eaae-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:02:23 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 33e3e5b7-eaae-11ed-b226-6b7b168915f2 Message-ID: <20230504185937.145906075@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=lJLvACyWoTrqBZOps4v6XbP7wlJ3d4Q7defz4e+9Zb8=; b=M3KgFVyzFkR4ccZ70dYavQ5/yqmJzYsNUe2w4AYa1zmqPGpOGfvnO2dLe+bqfdSYVxHNmg UzxBYDkuh0vO9FnTUv0U0boU0E1jTAuFuEPxGvjM1vNFxZkY4+YKEIRoL7asL6MLh7WY2k YHroxEZc/MyAi6EghJhWG+wOe//5AznxGGSpRWucK1h/BnTyT75KngcAYt8WZjiMtq166b mZZvUfn/tKwnN+lYf/c6UiDK6atXikbDlaDBZ4sMT8u+PU/SPukxmYsr0YlXnC0aFBugr6 4bUgvijH50TXxyxKZ9qydiyNaQwVfzl3UXTSijqX2pY50ezKH3gbSbXO2Pf/Zg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=lJLvACyWoTrqBZOps4v6XbP7wlJ3d4Q7defz4e+9Zb8=; b=YUlyUuTQQYH6MyD4cTuFQt3gYiD8H4Dxlm3l2cVGkFebVjVj9D7krF98nosGppSH1sXEJ5 189JeF0cp5TwVnAA== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch V2 15/38] x86/smpboot: Remove wait for cpu_online() References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:22 +0200 (CEST) From: Thomas Gleixner Now that the core code drops sparse_irq_lock after the idle thread synchronized, it's pointless to wait for the AP to mark itself online. Signed-off-by: Thomas Gleixner --- arch/x86/kernel/smpboot.c | 26 ++------------------------ 1 file changed, 2 insertions(+), 24 deletions(-) --- --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -281,7 +281,6 @@ static void notrace start_secondary(void * half valid vector space. */ lock_vector_lock(); - /* Sync point with do_wait_cpu_online() */ set_cpu_online(smp_processor_id(), true); lapic_online(); unlock_vector_lock(); @@ -1110,20 +1109,6 @@ static int wait_cpu_initialized(unsigned return 0; } -/* - * Bringup step three: Wait for the target AP to reach set_cpu_online() in - * start_secondary(). - */ -static void wait_cpu_online(unsigned int cpu) -{ - /* - * Wait for the AP to mark itself online, so the core caller - * can drop sparse_irq_lock. - */ - while (!cpu_online(cpu)) - schedule(); -} - static int native_kick_ap(unsigned int cpu, struct task_struct *tidle) { int apicid = apic->cpu_present_to_apicid(cpu); @@ -1170,16 +1155,9 @@ int native_cpu_up(unsigned int cpu, stru int ret; ret = native_kick_ap(cpu, tidle); - if (ret) - goto out; - - ret = wait_cpu_initialized(cpu); - if (ret) - goto out; - - wait_cpu_online(cpu); + if (!ret) + ret = wait_cpu_initialized(cpu); -out: /* Cleanup possible dangling ends... */ if (x86_platform.legacy.warm_reset) smpboot_restore_warm_reset_vector(); From xen-devel-bounces@lists.xenproject.org Thu May 04 19:02:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:02:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529907.824973 (Exim 4.92) (envelope-from ) id 1pueDq-0001n3-1E; Thu, 04 May 2023 19:02:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529907.824973; Thu, 04 May 2023 19:02:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDp-0001mL-R0; Thu, 04 May 2023 19:02:33 +0000 Received: by outflank-mailman (input) for mailman id 529907; Thu, 04 May 2023 19:02:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDo-00042k-HN for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:32 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 37c968b4-eaae-11ed-8611-37d641c3527e; Thu, 04 May 2023 21:02:30 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 37c968b4-eaae-11ed-8611-37d641c3527e Message-ID: <20230504185937.370022257@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=mat1riu4O6AbPNpAmsMwayxE5kfc1RXkToP7jRe4U7o=; b=xeQ5SCOYldQBRnXkZ526uAbaB3KT8qlhRpTTXdBUQxwAwpI82XKOL3tevipA06i7tc5ik1 /VIoaKs7slgXkoJFe/mtHfTaoLddU3MEOBEllwMSIf2d4NknWjTSWrq+h0v75+R1qK5t3r 8j7mXzu4SOfMAjxADMA1u0nZP2bTlZ1UBthabyfdIS8xqStZnpoA/DeBzH2/80q+vsgWeN FK2jo8/F0W9ovDdsnYpGGqEqqyguyf1eDfkchtVyJxwbc5saq03VkAo4AB8uim4+borl6r hmKF3zSrVJF46+/dF1reYrrlXBVWx9cYHY3XLgoVznWRXMJEKbMR9Q5+tqaJWQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=mat1riu4O6AbPNpAmsMwayxE5kfc1RXkToP7jRe4U7o=; b=rxfY29HsuqZlJnuRZ3LKPx2xJrN/rplKUe2pMIlsDATOFZW6zMzLCZaZHUFpor639GkOdB FN/fmxQ4O5AleqBA== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch V2 19/38] x86/smpboot: Switch to hotplug core state synchronization References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:29 +0200 (CEST) From: Thomas Gleixner The new AP state tracking and synchronization mechanism in the CPU hotplug core code allows to remove quite some x86 specific code: 1) The AP alive synchronization based on cpumasks 2) The decision whether an AP can be brought up again Signed-off-by: Thomas Gleixner Cc: Juergen Gross Cc: Boris Ostrovsky Cc: xen-devel@lists.xenproject.org --- V2: Use for_each_online_cpu() - Brian --- arch/x86/Kconfig | 1 arch/x86/include/asm/smp.h | 7 + arch/x86/kernel/smp.c | 1 arch/x86/kernel/smpboot.c | 161 ++++++++++----------------------------------- arch/x86/xen/smp_hvm.c | 16 +--- arch/x86/xen/smp_pv.c | 39 ++++++---- 6 files changed, 73 insertions(+), 152 deletions(-) --- --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -274,6 +274,7 @@ config X86 select HAVE_UNSTABLE_SCHED_CLOCK select HAVE_USER_RETURN_NOTIFIER select HAVE_GENERIC_VDSO + select HOTPLUG_CORE_SYNC_FULL if SMP select HOTPLUG_SMT if SMP select IRQ_FORCED_THREADING select NEED_PER_CPU_EMBED_FIRST_CHUNK --- a/arch/x86/include/asm/smp.h +++ b/arch/x86/include/asm/smp.h @@ -38,6 +38,8 @@ struct smp_ops { void (*crash_stop_other_cpus)(void); void (*smp_send_reschedule)(int cpu); + void (*cleanup_dead_cpu)(unsigned cpu); + void (*poll_sync_state)(void); int (*cpu_up)(unsigned cpu, struct task_struct *tidle); int (*cpu_disable)(void); void (*cpu_die)(unsigned int cpu); @@ -90,7 +92,8 @@ static inline int __cpu_disable(void) static inline void __cpu_die(unsigned int cpu) { - smp_ops.cpu_die(cpu); + if (smp_ops.cpu_die) + smp_ops.cpu_die(cpu); } static inline void __noreturn play_dead(void) @@ -123,8 +126,6 @@ void native_smp_cpus_done(unsigned int m int common_cpu_up(unsigned int cpunum, struct task_struct *tidle); int native_cpu_up(unsigned int cpunum, struct task_struct *tidle); int native_cpu_disable(void); -int common_cpu_die(unsigned int cpu); -void native_cpu_die(unsigned int cpu); void __noreturn hlt_play_dead(void); void native_play_dead(void); void play_dead_common(void); --- a/arch/x86/kernel/smp.c +++ b/arch/x86/kernel/smp.c @@ -269,7 +269,6 @@ struct smp_ops smp_ops = { .smp_send_reschedule = native_smp_send_reschedule, .cpu_up = native_cpu_up, - .cpu_die = native_cpu_die, .cpu_disable = native_cpu_disable, .play_dead = native_play_dead, --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -57,6 +57,7 @@ #include #include #include +#include #include #include @@ -101,9 +102,6 @@ EXPORT_PER_CPU_SYMBOL(cpu_die_map); DEFINE_PER_CPU_READ_MOSTLY(struct cpuinfo_x86, cpu_info); EXPORT_PER_CPU_SYMBOL(cpu_info); -/* All of these masks are initialized in setup_cpu_local_masks() */ -static cpumask_var_t cpu_initialized_mask; -static cpumask_var_t cpu_callout_mask; /* Representing CPUs for which sibling maps can be computed */ static cpumask_var_t cpu_sibling_setup_mask; @@ -169,8 +167,8 @@ static void smp_callin(void) int cpuid = smp_processor_id(); /* - * If waken up by an INIT in an 82489DX configuration - * cpu_callout_mask guarantees we don't get here before an + * If waken up by an INIT in an 82489DX configuration the alive + * synchronization guarantees we don't get here before an * INIT_deassert IPI reaches our local APIC, so it is now safe to * touch our local APIC. * @@ -216,17 +214,6 @@ static void ap_calibrate_delay(void) cpu_data(smp_processor_id()).loops_per_jiffy = loops_per_jiffy; } -static void wait_for_master_cpu(int cpu) -{ - /* - * Wait for release by control CPU before continuing with AP - * initialization. - */ - WARN_ON(cpumask_test_and_set_cpu(cpu, cpu_initialized_mask)); - while (!cpumask_test_cpu(cpu, cpu_callout_mask)) - cpu_relax(); -} - /* * Activate a secondary processor. */ @@ -247,11 +234,11 @@ static void notrace start_secondary(void cpu_init_exception_handling(); /* - * Sync point with wait_cpu_initialized(). Sets AP in - * cpu_initialized_mask and then waits for the control CPU - * to release it. + * Synchronization point with the hotplug core. Sets the + * synchronization state to ALIVE and waits for the control CPU to + * release this CPU for further bringup. */ - wait_for_master_cpu(raw_smp_processor_id()); + cpuhp_ap_sync_alive(); cpu_init(); rcu_cpu_starting(raw_smp_processor_id()); @@ -284,7 +271,6 @@ static void notrace start_secondary(void set_cpu_online(smp_processor_id(), true); lapic_online(); unlock_vector_lock(); - cpu_set_state_online(smp_processor_id()); x86_platform.nmi_init(); /* enable local interrupts */ @@ -735,9 +721,9 @@ static void impress_friends(void) * Allow the user to impress friends. */ pr_debug("Before bogomips\n"); - for_each_possible_cpu(cpu) - if (cpumask_test_cpu(cpu, cpu_callout_mask)) - bogosum += cpu_data(cpu).loops_per_jiffy; + for_each_online_cpu(cpu) + bogosum += cpu_data(cpu).loops_per_jiffy; + pr_info("Total of %d processors activated (%lu.%02lu BogoMIPS)\n", num_online_cpus(), bogosum/(500000/HZ), @@ -1009,6 +995,7 @@ int common_cpu_up(unsigned int cpu, stru static int do_boot_cpu(int apicid, int cpu, struct task_struct *idle) { unsigned long start_ip = real_mode_header->trampoline_start; + int ret; #ifdef CONFIG_X86_64 /* If 64-bit wakeup method exists, use the 64-bit mode trampoline IP */ @@ -1049,13 +1036,6 @@ static int do_boot_cpu(int apicid, int c } } - /* - * AP might wait on cpu_callout_mask in cpu_init() with - * cpu_initialized_mask set if previous attempt to online - * it timed-out. Clear cpu_initialized_mask so that after - * INIT/SIPI it could start with a clean state. - */ - cpumask_clear_cpu(cpu, cpu_initialized_mask); smp_mb(); /* @@ -1066,47 +1046,16 @@ static int do_boot_cpu(int apicid, int c * - Use an INIT boot APIC message */ if (apic->wakeup_secondary_cpu_64) - return apic->wakeup_secondary_cpu_64(apicid, start_ip); + ret = apic->wakeup_secondary_cpu_64(apicid, start_ip); else if (apic->wakeup_secondary_cpu) - return apic->wakeup_secondary_cpu(apicid, start_ip); - - return wakeup_secondary_cpu_via_init(apicid, start_ip); -} - -static int wait_cpu_cpumask(unsigned int cpu, const struct cpumask *mask) -{ - unsigned long timeout; - - /* - * Wait up to 10s for the CPU to report in. - */ - timeout = jiffies + 10*HZ; - while (time_before(jiffies, timeout)) { - if (cpumask_test_cpu(cpu, mask)) - return 0; - - schedule(); - } - return -1; -} - -/* - * Bringup step two: Wait for the target AP to reach cpu_init_secondary() - * and thus wait_for_master_cpu(), then set cpu_callout_mask to allow it - * to proceed. The AP will then proceed past setting its 'callin' bit - * and end up waiting in check_tsc_sync_target() until we reach - * wait_cpu_online() to tend to it. - */ -static int wait_cpu_initialized(unsigned int cpu) -{ - /* - * Wait for first sign of life from AP. - */ - if (wait_cpu_cpumask(cpu, cpu_initialized_mask)) - return -1; + ret = apic->wakeup_secondary_cpu(apicid, start_ip); + else + ret = wakeup_secondary_cpu_via_init(apicid, start_ip); - cpumask_set_cpu(cpu, cpu_callout_mask); - return 0; + /* If the wakeup mechanism failed, cleanup the warm reset vector */ + if (ret) + arch_cpuhp_cleanup_kick_cpu(cpu); + return ret; } static int native_kick_ap(unsigned int cpu, struct task_struct *tidle) @@ -1131,11 +1080,6 @@ static int native_kick_ap(unsigned int c */ mtrr_save_state(); - /* x86 CPUs take themselves offline, so delayed offline is OK. */ - err = cpu_check_up_prepare(cpu); - if (err && err != -EBUSY) - return err; - /* the FPU context is blank, nobody can own it */ per_cpu(fpu_fpregs_owner_ctx, cpu) = NULL; @@ -1152,17 +1096,29 @@ static int native_kick_ap(unsigned int c int native_cpu_up(unsigned int cpu, struct task_struct *tidle) { - int ret; - - ret = native_kick_ap(cpu, tidle); - if (!ret) - ret = wait_cpu_initialized(cpu); + return native_kick_ap(cpu, tidle); +} +void arch_cpuhp_cleanup_kick_cpu(unsigned int cpu) +{ /* Cleanup possible dangling ends... */ - if (x86_platform.legacy.warm_reset) + if (smp_ops.cpu_up == native_cpu_up && x86_platform.legacy.warm_reset) smpboot_restore_warm_reset_vector(); +} - return ret; +void arch_cpuhp_cleanup_dead_cpu(unsigned int cpu) +{ + if (smp_ops.cleanup_dead_cpu) + smp_ops.cleanup_dead_cpu(cpu); + + if (system_state == SYSTEM_RUNNING) + pr_info("CPU %u is now offline\n", cpu); +} + +void arch_cpuhp_sync_state_poll(void) +{ + if (smp_ops.poll_sync_state) + smp_ops.poll_sync_state(); } /** @@ -1354,9 +1310,6 @@ void __init native_smp_prepare_boot_cpu( if (!IS_ENABLED(CONFIG_SMP)) switch_gdt_and_percpu_base(me); - /* already set me in cpu_online_mask in boot_cpu_init() */ - cpumask_set_cpu(me, cpu_callout_mask); - cpu_set_state_online(me); native_pv_lock_init(); } @@ -1483,8 +1436,6 @@ early_param("possible_cpus", _setup_poss /* correctly size the local cpu masks */ void __init setup_cpu_local_masks(void) { - alloc_bootmem_cpumask_var(&cpu_initialized_mask); - alloc_bootmem_cpumask_var(&cpu_callout_mask); alloc_bootmem_cpumask_var(&cpu_sibling_setup_mask); } @@ -1546,9 +1497,6 @@ static void remove_siblinginfo(int cpu) static void remove_cpu_from_maps(int cpu) { set_cpu_online(cpu, false); - cpumask_clear_cpu(cpu, cpu_callout_mask); - /* was set by cpu_init() */ - cpumask_clear_cpu(cpu, cpu_initialized_mask); numa_remove_cpu(cpu); } @@ -1599,36 +1547,11 @@ int native_cpu_disable(void) return 0; } -int common_cpu_die(unsigned int cpu) -{ - int ret = 0; - - /* We don't do anything here: idle task is faking death itself. */ - - /* They ack this in play_dead() by setting CPU_DEAD */ - if (cpu_wait_death(cpu, 5)) { - if (system_state == SYSTEM_RUNNING) - pr_info("CPU %u is now offline\n", cpu); - } else { - pr_err("CPU %u didn't die...\n", cpu); - ret = -1; - } - - return ret; -} - -void native_cpu_die(unsigned int cpu) -{ - common_cpu_die(cpu); -} - void play_dead_common(void) { idle_task_exit(); - /* Ack it */ - (void)cpu_report_death(); - + cpuhp_ap_report_dead(); /* * With physical CPU hotplug, we should halt the cpu */ @@ -1730,12 +1653,6 @@ int native_cpu_disable(void) return -ENOSYS; } -void native_cpu_die(unsigned int cpu) -{ - /* We said "no" in __cpu_disable */ - BUG(); -} - void native_play_dead(void) { BUG(); --- a/arch/x86/xen/smp_hvm.c +++ b/arch/x86/xen/smp_hvm.c @@ -55,18 +55,16 @@ static void __init xen_hvm_smp_prepare_c } #ifdef CONFIG_HOTPLUG_CPU -static void xen_hvm_cpu_die(unsigned int cpu) +static void xen_hvm_cleanup_dead_cpu(unsigned int cpu) { - if (common_cpu_die(cpu) == 0) { - if (xen_have_vector_callback) { - xen_smp_intr_free(cpu); - xen_uninit_lock_cpu(cpu); - xen_teardown_timer(cpu); - } + if (xen_have_vector_callback) { + xen_smp_intr_free(cpu); + xen_uninit_lock_cpu(cpu); + xen_teardown_timer(cpu); } } #else -static void xen_hvm_cpu_die(unsigned int cpu) +static void xen_hvm_cleanup_dead_cpu(unsigned int cpu) { BUG(); } @@ -77,7 +75,7 @@ void __init xen_hvm_smp_init(void) smp_ops.smp_prepare_boot_cpu = xen_hvm_smp_prepare_boot_cpu; smp_ops.smp_prepare_cpus = xen_hvm_smp_prepare_cpus; smp_ops.smp_cpus_done = xen_smp_cpus_done; - smp_ops.cpu_die = xen_hvm_cpu_die; + smp_ops.cleanup_dead_cpu = xen_hvm_cleanup_dead_cpu; if (!xen_have_vector_callback) { #ifdef CONFIG_PARAVIRT_SPINLOCKS --- a/arch/x86/xen/smp_pv.c +++ b/arch/x86/xen/smp_pv.c @@ -62,6 +62,7 @@ static void cpu_bringup(void) int cpu; cr4_init(); + cpuhp_ap_sync_alive(); cpu_init(); touch_softlockup_watchdog(); @@ -83,7 +84,7 @@ static void cpu_bringup(void) set_cpu_online(cpu, true); - cpu_set_state_online(cpu); /* Implies full memory barrier. */ + smp_mb(); /* We can take interrupts now: we're officially "up". */ local_irq_enable(); @@ -323,14 +324,6 @@ static int xen_pv_cpu_up(unsigned int cp xen_setup_runstate_info(cpu); - /* - * PV VCPUs are always successfully taken down (see 'while' loop - * in xen_cpu_die()), so -EBUSY is an error. - */ - rc = cpu_check_up_prepare(cpu); - if (rc) - return rc; - /* make sure interrupts start blocked */ per_cpu(xen_vcpu, cpu)->evtchn_upcall_mask = 1; @@ -349,6 +342,11 @@ static int xen_pv_cpu_up(unsigned int cp return 0; } +static void xen_pv_poll_sync_state(void) +{ + HYPERVISOR_sched_op(SCHEDOP_yield, NULL); +} + #ifdef CONFIG_HOTPLUG_CPU static int xen_pv_cpu_disable(void) { @@ -364,18 +362,18 @@ static int xen_pv_cpu_disable(void) static void xen_pv_cpu_die(unsigned int cpu) { - while (HYPERVISOR_vcpu_op(VCPUOP_is_up, - xen_vcpu_nr(cpu), NULL)) { + while (HYPERVISOR_vcpu_op(VCPUOP_is_up, xen_vcpu_nr(cpu), NULL)) { __set_current_state(TASK_UNINTERRUPTIBLE); schedule_timeout(HZ/10); } +} - if (common_cpu_die(cpu) == 0) { - xen_smp_intr_free(cpu); - xen_uninit_lock_cpu(cpu); - xen_teardown_timer(cpu); - xen_pmu_finish(cpu); - } +static void xen_pv_cleanup_dead_cpu(unsigned int cpu) +{ + xen_smp_intr_free(cpu); + xen_uninit_lock_cpu(cpu); + xen_teardown_timer(cpu); + xen_pmu_finish(cpu); } static void __noreturn xen_pv_play_dead(void) /* used only with HOTPLUG_CPU */ @@ -397,6 +395,11 @@ static void xen_pv_cpu_die(unsigned int BUG(); } +static void xen_pv_cleanup_dead_cpu(unsigned int cpu) +{ + BUG(); +} + static void __noreturn xen_pv_play_dead(void) { BUG(); @@ -437,6 +440,8 @@ static const struct smp_ops xen_smp_ops .cpu_up = xen_pv_cpu_up, .cpu_die = xen_pv_cpu_die, + .cleanup_dead_cpu = xen_pv_cleanup_dead_cpu, + .poll_sync_state = xen_pv_poll_sync_state, .cpu_disable = xen_pv_cpu_disable, .play_dead = xen_pv_play_dead, From xen-devel-bounces@lists.xenproject.org Thu May 04 19:09:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:09:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529922.824982 (Exim 4.92) (envelope-from ) id 1pueKB-0005HU-Nw; Thu, 04 May 2023 19:09:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529922.824982; Thu, 04 May 2023 19:09:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueKB-0005HN-LL; Thu, 04 May 2023 19:09:07 +0000 Received: by outflank-mailman (input) for mailman id 529922; Thu, 04 May 2023 19:09:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueED-00042k-9y for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:57 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 47244339-eaae-11ed-8611-37d641c3527e; Thu, 04 May 2023 21:02:55 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 47244339-eaae-11ed-8611-37d641c3527e Message-ID: <20230504185938.232336513@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226975; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=PaGuo8GAZ65ZbtTn7wzwCB2xmjp/8CcdVtBqqK3zJyY=; b=WBrmRYfVh8Hf7VAtaZM+773NG/l2NaZEQY2PbsMWpwgijTHlkaPZNZwTTqZqSePaJs28Tp huH2qX95r4oDUOSFSd9zA+6+RZv5lgr0xa0QdgDkEncw9LVXBvKPVIlHpBCwardNQlPmIT cajVqbzngFG+dnpn2I0UeA+RYWcEBwo1QkYYSYABAtHiWYiay4DXWTSDKMd3/FerfS7z8b xwX6otdMILDZ1YbCULvPsUARGQzswNTUUkZzB3iKqcysyV9JxG2dUxCWqjPi7FUYFLn/3T jkRxQ4LmxpZMkrdtxeZw1NAb25wiC+Tx1duuJ885D0xawxhq7zhP9DRXxAmkFA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226975; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=PaGuo8GAZ65ZbtTn7wzwCB2xmjp/8CcdVtBqqK3zJyY=; b=G0tsDBn5b6jENP+Wz6pMSYtlj20+hRg4V3sQlU3KTcd+8sMa78JVCQNTfSLn2dU5TfjS5i VD5uznhB/0z5zkAQ== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch V2 35/38] x86/apic: Save the APIC virtual base address References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:55 +0200 (CEST) From: Thomas Gleixner For parallel CPU brinugp it's required to read the APIC ID in the low level startup code. The virtual APIC base address is a constant because its a fix-mapped address. Exposing that constant which is composed via macros to assembly code is non-trivial dues to header inclusion hell. Aside of that it's constant only because of the vsyscall ABI requirement. Once vsyscall is out of the picture the fixmap can be placed at runtime. Avoid header hell, stay flexible and store the address in a variable which can be exposed to the low level startup code. Signed-off-by: Thomas Gleixner --- arch/x86/include/asm/smp.h | 1 + arch/x86/kernel/apic/apic.c | 4 ++++ 2 files changed, 5 insertions(+) --- --- a/arch/x86/include/asm/smp.h +++ b/arch/x86/include/asm/smp.h @@ -196,6 +196,7 @@ extern void nmi_selftest(void); #endif extern unsigned int smpboot_control; +extern unsigned long apic_mmio_base; #endif /* !__ASSEMBLY__ */ --- a/arch/x86/kernel/apic/apic.c +++ b/arch/x86/kernel/apic/apic.c @@ -101,6 +101,9 @@ static int apic_extnmi __ro_after_init = */ static bool virt_ext_dest_id __ro_after_init; +/* For parallel bootup. */ +unsigned long apic_mmio_base __ro_after_init; + /* * Map cpu index to physical APIC ID */ @@ -2163,6 +2166,7 @@ void __init register_lapic_address(unsig if (!x2apic_mode) { set_fixmap_nocache(FIX_APIC_BASE, address); + apic_mmio_base = APIC_BASE; apic_printk(APIC_VERBOSE, "mapped APIC to %16lx (%16lx)\n", APIC_BASE, address); } From xen-devel-bounces@lists.xenproject.org Thu May 04 19:09:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:09:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529928.824993 (Exim 4.92) (envelope-from ) id 1pueKS-0005ec-0E; Thu, 04 May 2023 19:09:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529928.824993; Thu, 04 May 2023 19:09:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueKR-0005eT-TY; Thu, 04 May 2023 19:09:23 +0000 Received: by outflank-mailman (input) for mailman id 529928; Thu, 04 May 2023 19:09:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueEI-00042k-O1 for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:03:02 +0000 Received: from galois.linutronix.de (galois.linutronix.de [2a0a:51c0:0:12e:550::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4a29c51a-eaae-11ed-8611-37d641c3527e; Thu, 04 May 2023 21:03:00 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a29c51a-eaae-11ed-8611-37d641c3527e Message-ID: <20230504185938.393373946@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226980; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=DnnEFfJ8qHS51cV93bPVxAhJn4egJudPWNxPdxHp+6I=; b=3Ex1oay3deKBQTCKUX4Ih8IGgIbgjtd18ImqJ1vJckFzp4vqpeCRciYL26XaBXwtGetEt9 jQYdqvvfPpYi34oU2dU7fjuiZ3WyUQcsrd4BPREXrzjkH9groi0TU6YGHBW08cmpwip9QC vnXlEPucLe8Pxu/DAQZhHSJgvAG1br+71W5AkzFErVTB5fdbrjcZJ7I/PMvvfD3nV+Fpt+ Y9+eS6OIW46jTxBhE1zoqPIcGpnWyrhDXCq+doarlLORorIO2HSYQo2DibMTzYhsGwQ8ko wng2jKhRiMwK0oOD7H54yErcCMVtMuv2wW3qjiAj1OaBH6NB6N7JtXkq+JhyKQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226980; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=DnnEFfJ8qHS51cV93bPVxAhJn4egJudPWNxPdxHp+6I=; b=6kDZyW5GTa+KS1pHyq0SY7syfYnd6TB6StPbtFwCKnOC1peAStPMetQpfCSqmue8lUL4Wc NQ0I2S6hl8MhwzDA== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch V2 38/38] x86/smpboot/64: Implement arch_cpuhp_init_parallel_bringup() and enable it References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:03:00 +0200 (CEST) From: Thomas Gleixner Implement the validation function which tells the core code whether parallel bringup is possible. The only condition for now is that the kernel does not run in an encrypted guest as these will trap the RDMSR via #VC, which cannot be handled at that point in early startup. There was an earlier variant for AMD-SEV which used the GHBC protocol for retrieving the APIC ID via CPUID, but there is no guarantee that the initial APIC ID in CPUID is the same as the real APIC ID. There is no enforcement from the secure firmware and the hypervisor can assign APIC IDs as it sees fit as long as the ACPI/MADT table is consistent with that assignment. Unfortunately there is no RDMSR GHCB protocol at the moment, so enabling AMD-SEV guests for parallel startup needs some more thought. Intel-TDX provides a secure RDMSR hypercall, but supporting that is outside the scope of this change. Fixup announce_cpu() as e.g. on Hyper-V CPU1 is the secondary sibling of CPU0, which makes the @cpu == 1 logic in announce_cpu() fall apart. [ mikelley: Reported the announce_cpu() fallout Originally-by: David Woodhouse Signed-off-by: Thomas Gleixner --- V2: Fixup announce_cpu() - Michael Kelley --- arch/x86/Kconfig | 3 + arch/x86/kernel/cpu/common.c | 6 --- arch/x86/kernel/smpboot.c | 83 ++++++++++++++++++++++++++++++++++++------- 3 files changed, 73 insertions(+), 19 deletions(-) --- --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -274,8 +274,9 @@ config X86 select HAVE_UNSTABLE_SCHED_CLOCK select HAVE_USER_RETURN_NOTIFIER select HAVE_GENERIC_VDSO + select HOTPLUG_PARALLEL if SMP && X86_64 select HOTPLUG_SMT if SMP - select HOTPLUG_SPLIT_STARTUP if SMP + select HOTPLUG_SPLIT_STARTUP if SMP && X86_32 select IRQ_FORCED_THREADING select NEED_PER_CPU_EMBED_FIRST_CHUNK select NEED_PER_CPU_PAGE_FIRST_CHUNK --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -2128,11 +2128,7 @@ static inline void setup_getcpu(int cpu) } #ifdef CONFIG_X86_64 -static inline void ucode_cpu_init(int cpu) -{ - if (cpu) - load_ucode_ap(); -} +static inline void ucode_cpu_init(int cpu) { } static inline void tss_setup_ist(struct tss_struct *tss) { --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -58,6 +58,7 @@ #include #include #include +#include #include #include @@ -75,7 +76,7 @@ #include #include #include -#include +#include #include #include #include @@ -128,7 +129,6 @@ int arch_update_cpu_topology(void) return retval; } - static unsigned int smpboot_warm_reset_vector_count; static inline void smpboot_setup_warm_reset_vector(unsigned long start_eip) @@ -229,16 +229,43 @@ static void notrace start_secondary(void */ cr4_init(); -#ifdef CONFIG_X86_32 - /* switch away from the initial page table */ - load_cr3(swapper_pg_dir); - __flush_tlb_all(); -#endif + /* + * 32-bit specific. 64-bit reaches this code with the correct page + * table established. Yet another historical divergence. + */ + if (IS_ENABLED(CONFIG_X86_32)) { + /* switch away from the initial page table */ + load_cr3(swapper_pg_dir); + __flush_tlb_all(); + } + cpu_init_exception_handling(); /* - * Synchronization point with the hotplug core. Sets the - * synchronization state to ALIVE and waits for the control CPU to + * 32-bit systems load the microcode from the ASM startup code for + * historical reasons. + * + * On 64-bit systems load it before reaching the AP alive + * synchronization point below so it is not part of the full per + * CPU serialized bringup part when "parallel" bringup is enabled. + * + * That's even safe when hyperthreading is enabled in the CPU as + * the core code starts the primary threads first and leaves the + * secondary threads waiting for SIPI. Loading microcode on + * physical cores concurrently is a safe operation. + * + * This covers both the Intel specific issue that concurrent + * microcode loading on SMT siblings must be prohibited and the + * vendor independent issue`that microcode loading which changes + * CPUID, MSRs etc. must be strictly serialized to maintain + * software state correctness. + */ + if (IS_ENABLED(CONFIG_X86_64)) + load_ucode_ap(); + + /* + * Synchronization point with the hotplug core. Sets this CPUs + * synchronization state to ALIVE and spin-waits for the control CPU to * release this CPU for further bringup. */ cpuhp_ap_sync_alive(); @@ -934,10 +961,10 @@ static void announce_cpu(int cpu, int ap if (!node_width) node_width = num_digits(num_possible_nodes()) + 1; /* + '#' */ - if (cpu == 1) - printk(KERN_INFO "x86: Booting SMP configuration:\n"); - if (system_state < SYSTEM_RUNNING) { + if (num_online_cpus() == 1) + pr_info("x86: Booting SMP configuration:\n"); + if (node != current_node) { if (current_node > (-1)) pr_cont("\n"); @@ -948,7 +975,7 @@ static void announce_cpu(int cpu, int ap } /* Add padding for the BSP */ - if (cpu == 1) + if (num_online_cpus() == 1) pr_cont("%*s", width + 1, " "); pr_cont("%*s#%d", width - num_digits(cpu), " ", cpu); @@ -1242,6 +1269,36 @@ void __init smp_prepare_cpus_common(void set_cpu_sibling_map(0); } +#ifdef CONFIG_X86_64 +/* Establish whether parallel bringup can be supported. */ +bool __init arch_cpuhp_init_parallel_bringup(void) +{ + /* + * Encrypted guests require special handling. They enforce X2APIC + * mode but the RDMSR to read the APIC ID is intercepted and raises + * #VC or #VE which cannot be handled in the early startup code. + * + * AMD-SEV does not provide a RDMSR GHCB protocol so the early + * startup code cannot directly communicate with the secure + * firmware. The alternative solution to retrieve the APIC ID via + * CPUID(0xb), which is covered by the GHCB protocol, is not viable + * either because there is no enforcement of the CPUID(0xb) + * provided "initial" APIC ID to be the same as the real APIC ID. + * + * Intel-TDX has a secure RDMSR hypercall, but that needs to be + * implemented seperately in the low level startup ASM code. + */ + if (cc_platform_has(CC_ATTR_GUEST_STATE_ENCRYPT)) { + pr_info("Parallel CPU startup disabled due to guest state encryption\n"); + return false; + } + + smpboot_control = STARTUP_READ_APICID; + pr_debug("Parallel CPU startup enabled: 0x%08x\n", smpboot_control); + return true; +} +#endif + /* * Prepare for SMP bootup. * @max_cpus: configured maximum number of CPUs, It is a legacy parameter From xen-devel-bounces@lists.xenproject.org Thu May 04 19:09:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:09:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529931.825003 (Exim 4.92) (envelope-from ) id 1pueKV-00060U-Cm; Thu, 04 May 2023 19:09:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529931.825003; Thu, 04 May 2023 19:09:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueKV-00060L-9u; Thu, 04 May 2023 19:09:27 +0000 Received: by outflank-mailman (input) for mailman id 529931; Thu, 04 May 2023 19:09:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDw-00042j-22 for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:40 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3d7c3870-eaae-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:02:39 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3d7c3870-eaae-11ed-b226-6b7b168915f2 Message-ID: <20230504185937.700483457@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226959; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=o04fXgOhQs8+8CE7g0ZkhrpkLD4QHZg/LLM7Otp+9z8=; b=p4kcKoUjBHHJo7zBT76SAr4kx217XWJeqQlJZM4VxHPykLQrWLTEC/uzx8rVhbv5iqkHWl eKFtH9Dh+4qwsJ89ZP4rLm01HMJyfuh1U+U+HK5bkx7PCIfmaji3wiKDM0hoVurLEfzD81 Wt5Ubm2jEjitMnzdFcIqEG1m9GNIikM3c5w8xOJBg2D9IGfl3i1Bdd22uIIaFwPx6R+oIN 02fFHC7cYoeNHnd0KZn/7sG2vBaI1ZwTr6vd36gfFqo6mvp2OfPm/JhGUYVjsHiJsALYHO f8H4F6s4Sw0iVizvLScdCi66AVg3wSgMwKU7em9hN7nVzpd/ip3L0uFyKgVW2A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226959; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=o04fXgOhQs8+8CE7g0ZkhrpkLD4QHZg/LLM7Otp+9z8=; b=ZnZlGAwTWV21lQJdfFlOE3KOrdxbCyckyIQwnUuLhsAipHYSOksGllyP3kynqMPIKSFyh4 3HRt8jQRFFxBADCA== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch V2 25/38] parisc: Switch to hotplug core state synchronization References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:38 +0200 (CEST) From: Thomas Gleixner Switch to the CPU hotplug core state tracking and synchronization mechanim. No functional change intended. Signed-off-by: Thomas Gleixner Cc: "James E.J. Bottomley" Cc: Helge Deller Cc: linux-parisc@vger.kernel.org --- arch/parisc/Kconfig | 1 + arch/parisc/kernel/process.c | 4 ++-- arch/parisc/kernel/smp.c | 7 +++---- 3 files changed, 6 insertions(+), 6 deletions(-) --- --- a/arch/parisc/Kconfig +++ b/arch/parisc/Kconfig @@ -57,6 +57,7 @@ config PARISC select HAVE_ARCH_SECCOMP_FILTER select HAVE_ARCH_TRACEHOOK select HAVE_REGS_AND_STACK_ACCESS_API + select HOTPLUG_CORE_SYNC_DEAD if HOTPLUG_CPU select GENERIC_SCHED_CLOCK select GENERIC_IRQ_MIGRATION if SMP select HAVE_UNSTABLE_SCHED_CLOCK if SMP --- a/arch/parisc/kernel/process.c +++ b/arch/parisc/kernel/process.c @@ -166,8 +166,8 @@ void __noreturn arch_cpu_idle_dead(void) local_irq_disable(); - /* Tell __cpu_die() that this CPU is now safe to dispose of. */ - (void)cpu_report_death(); + /* Tell the core that this CPU is now safe to dispose of. */ + cpuhp_ap_report_dead(); /* Ensure that the cache lines are written out. */ flush_cache_all_local(); --- a/arch/parisc/kernel/smp.c +++ b/arch/parisc/kernel/smp.c @@ -500,11 +500,10 @@ int __cpu_disable(void) void __cpu_die(unsigned int cpu) { pdc_cpu_rendezvous_lock(); +} - if (!cpu_wait_death(cpu, 5)) { - pr_crit("CPU%u: cpu didn't die\n", cpu); - return; - } +void arch_cpuhp_cleanup_dead_cpu(unsigned int cpu) +{ pr_info("CPU%u: is shutting down\n", cpu); /* set task's state to interruptible sleep */ From xen-devel-bounces@lists.xenproject.org Thu May 04 19:09:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:09:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529934.825013 (Exim 4.92) (envelope-from ) id 1pueKZ-0006MH-KX; Thu, 04 May 2023 19:09:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529934.825013; Thu, 04 May 2023 19:09:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueKZ-0006MA-Gy; Thu, 04 May 2023 19:09:31 +0000 Received: by outflank-mailman (input) for mailman id 529934; Thu, 04 May 2023 19:09:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueE1-00042j-09 for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:45 +0000 Received: from galois.linutronix.de (galois.linutronix.de [2a0a:51c0:0:12e:550::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 406aadd9-eaae-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:02:44 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 406aadd9-eaae-11ed-b226-6b7b168915f2 Message-ID: <20230504185937.858955768@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226964; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=x1gYrMcqzm40p2bz6RsOmSrXlBcSvXXbnfB8HNeCbJU=; b=F9VwenKVSYd9QFli8bXNV/fz9qUSdzJcPELJ1ngRD9BxyzaHEgcu2cC0/b4kuprOfTMBsR NCkyPWtTcKTi4mTU6aAeMY6PYflFdg/QnWMligdTnr5DQ53G/59w7N1RxTuaJMuxKaB+6k fnxGx7t6MsQx4TP0A/Wv1B3YJqsjI01JirGXHQPo53zTdX5Z488sLyftTciloBgiN9k5k/ bzf3t4Qwlj6lxCy0qHukKPQMZGDuh3h1yP7MJWtYXWHVZt3htrK/Qtw9ul4ERCfXuX9Nze it6Ui4ad23Dml/cuVbhr6i6cHXzKyVbR3juE2BxVW820qfkeEJiZvG833WVS3g== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226964; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=x1gYrMcqzm40p2bz6RsOmSrXlBcSvXXbnfB8HNeCbJU=; b=PK3VhwCrlpzYLlITMOVdXxhPHsDqoA73a6Tz+/QOqHPRfKtGaiwEqnA7EtTcL4VMvMoxp6 ebRWKW/d8KnEHmAA== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" , David Woodhouse Subject: [patch V2 28/38] cpu/hotplug: Reset task stack state in _cpu_up() References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:43 +0200 (CEST) From: David Woodhouse Commit dce1ca0525bf ("sched/scs: Reset task stack state in bringup_cpu()") ensured that the shadow call stack and KASAN poisoning were removed from a CPU's stack each time that CPU is brought up, not just once. This is not incorrect. However, with parallel bringup the idle thread setup will happen at a different step. As a consequence the cleanup in bringup_cpu() would be too late. Move the SCS/KASAN cleanup to the generic _cpu_up() function instead, which already ensures that the new CPU's stack is available, purely to allow for early failure. This occurs when the CPU to be brought up is in the CPUHP_OFFLINE state, which should correctly do the cleanup any time the CPU has been taken down to the point where such is needed. Signed-off-by: David Woodhouse Signed-off-by: Thomas Gleixner Tested-by: Mark Rutland Reviewed-by: Mark Rutland --- kernel/cpu.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) --- --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -771,12 +771,6 @@ static int bringup_cpu(unsigned int cpu) return -EAGAIN; /* - * Reset stale stack state from the last time this CPU was online. - */ - scs_task_reset(idle); - kasan_unpoison_task_stack(idle); - - /* * Some architectures have to walk the irq descriptors to * setup the vector space for the cpu which comes online. * Prevent irq alloc/free across the bringup. @@ -1583,6 +1577,12 @@ static int _cpu_up(unsigned int cpu, int ret = PTR_ERR(idle); goto out; } + + /* + * Reset stale stack state from the last time this CPU was online. + */ + scs_task_reset(idle); + kasan_unpoison_task_stack(idle); } cpuhp_tasks_frozen = tasks_frozen; From xen-devel-bounces@lists.xenproject.org Thu May 04 19:09:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:09:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529935.825018 (Exim 4.92) (envelope-from ) id 1pueKa-0006Pw-1a; Thu, 04 May 2023 19:09:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529935.825018; Thu, 04 May 2023 19:09:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueKZ-0006PM-PN; Thu, 04 May 2023 19:09:31 +0000 Received: by outflank-mailman (input) for mailman id 529935; Thu, 04 May 2023 19:09:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueE2-00042j-Qd for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:46 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 415bc34c-eaae-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:02:46 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 415bc34c-eaae-11ed-b226-6b7b168915f2 Message-ID: <20230504185937.912510359@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=F8kXoaR1nBQ6o9VxPp8Uz6U2V5tkVIrZOYAD+Uqf6yU=; b=FHHwtM3MehcvxyTD3IIJz8sgSlPXUlchZh7xJFV6jf2jNACHHUSgTO098Ser6A+TKYqwby MlO+QBW9B7CBztPuD5tg+w+tvkSrJZeyBsoOwfT3EBQQwdnjzUEH5V/q7RLkoQV5ifNNa+ at9KsHlVkTZ1F4ajKTdjiM9iHVozExltMcmveGrXQs/fOlHDH8HgFUnTWmeo5rouQexRZ4 Xry4XkxaL7TCkZzvLR+YbuqgPQqwNW1A3kMmXVynnWeMARwsSVesHKDo20gZt3Skv9srif 0A1QbnYXe4Tj6Hfs/b/c+uuWIPdrOvy2KufgGEj/6EkbPvsEiWUj1xzdM/2/FQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=F8kXoaR1nBQ6o9VxPp8Uz6U2V5tkVIrZOYAD+Uqf6yU=; b=eKOKrA/+YsiD2CsaRIq67Pl+6fGbLOp23MnHr4M6jOIgCJwCHmPsKgxoXghxnT8I2GMUKL U9rUX94YG+zIxfDw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch V2 29/38] cpu/hotplug: Provide a split up CPUHP_BRINGUP mechanism References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:45 +0200 (CEST) From: Thomas Gleixner The bring up logic of a to be onlined CPU consists of several parts, which are considered to be a single hotplug state: 1) Control CPU issues the wake-up 2) To be onlined CPU starts up, does the minimal initialization, reports to be alive and waits for release into the complete bring-up. 3) Control CPU waits for the alive report and releases the upcoming CPU for the complete bring-up. Allow to split this into two states: 1) Control CPU issues the wake-up After that the to be onlined CPU starts up, does the minimal initialization, reports to be alive and waits for release into the full bring-up. As this can run after the control CPU dropped the hotplug locks the code which is executed on the AP before it reports alive has to be carefully audited to not violate any of the hotplug constraints, especially not modifying any of the various cpumasks. This is really only meant to avoid waiting for the AP to react on the wake-up. Of course an architecture can move strict CPU related setup functionality, e.g. microcode loading, with care before the synchronization point to save further pointless waiting time. 2) Control CPU waits for the alive report and releases the upcoming CPU for the complete bring-up. This allows that the two states can be split up to run all to be onlined CPUs up to state #1 on the control CPU and then at a later point run state #2. This spares some of the latencies of the full serialized per CPU bringup by avoiding the per CPU wakeup/wait serialization. The assumption is that the first AP already waits when the last AP has been woken up. This obvioulsy depends on the hardware latencies and depending on the timings this might still not completely eliminate all wait scenarios. This split is just a preparatory step for enabling the parallel bringup later. The boot time bringup is still fully serialized. It has a separate config switch so that architectures which want to support parallel bringup can test the split of the CPUHP_BRINGUG step separately. To enable this the architecture must support the CPU hotplug core sync mechanism and has to be audited that there are no implicit hotplug state dependencies which require a fully serialized bringup. Signed-off-by: Thomas Gleixner --- arch/Kconfig | 4 ++ include/linux/cpuhotplug.h | 4 ++ kernel/cpu.c | 70 +++++++++++++++++++++++++++++++++++++++++++-- 3 files changed, 76 insertions(+), 2 deletions(-) --- --- a/arch/Kconfig +++ b/arch/Kconfig @@ -49,6 +49,10 @@ config HOTPLUG_CORE_SYNC_FULL select HOTPLUG_CORE_SYNC_DEAD if HOTPLUG_CPU select HOTPLUG_CORE_SYNC +config HOTPLUG_SPLIT_STARTUP + bool + select HOTPLUG_CORE_SYNC_FULL + config GENERIC_ENTRY bool --- a/include/linux/cpuhotplug.h +++ b/include/linux/cpuhotplug.h @@ -133,6 +133,7 @@ enum cpuhp_state { CPUHP_MIPS_SOC_PREPARE, CPUHP_BP_PREPARE_DYN, CPUHP_BP_PREPARE_DYN_END = CPUHP_BP_PREPARE_DYN + 20, + CPUHP_BP_KICK_AP, CPUHP_BRINGUP_CPU, /* @@ -517,9 +518,12 @@ void cpuhp_online_idle(enum cpuhp_state static inline void cpuhp_online_idle(enum cpuhp_state state) { } #endif +struct task_struct; + void cpuhp_ap_sync_alive(void); void arch_cpuhp_sync_state_poll(void); void arch_cpuhp_cleanup_kick_cpu(unsigned int cpu); +int arch_cpuhp_kick_ap_alive(unsigned int cpu, struct task_struct *tidle); #ifdef CONFIG_HOTPLUG_CORE_SYNC_DEAD void cpuhp_ap_report_dead(void); --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -761,6 +761,47 @@ static int bringup_wait_for_ap_online(un return 0; } +#ifdef CONFIG_HOTPLUG_SPLIT_STARTUP +static int cpuhp_kick_ap_alive(unsigned int cpu) +{ + if (!cpuhp_can_boot_ap(cpu)) + return -EAGAIN; + + return arch_cpuhp_kick_ap_alive(cpu, idle_thread_get(cpu)); +} + +static int cpuhp_bringup_ap(unsigned int cpu) +{ + struct cpuhp_cpu_state *st = per_cpu_ptr(&cpuhp_state, cpu); + int ret; + + /* + * Some architectures have to walk the irq descriptors to + * setup the vector space for the cpu which comes online. + * Prevent irq alloc/free across the bringup. + */ + irq_lock_sparse(); + + ret = cpuhp_bp_sync_alive(cpu); + if (ret) + goto out_unlock; + + ret = bringup_wait_for_ap_online(cpu); + if (ret) + goto out_unlock; + + irq_unlock_sparse(); + + if (st->target <= CPUHP_AP_ONLINE_IDLE) + return 0; + + return cpuhp_kick_ap(cpu, st, st->target); + +out_unlock: + irq_unlock_sparse(); + return ret; +} +#else static int bringup_cpu(unsigned int cpu) { struct cpuhp_cpu_state *st = per_cpu_ptr(&cpuhp_state, cpu); @@ -777,7 +818,6 @@ static int bringup_cpu(unsigned int cpu) */ irq_lock_sparse(); - /* Arch-specific enabling code. */ ret = __cpu_up(cpu, idle); if (ret) goto out_unlock; @@ -801,6 +841,7 @@ static int bringup_cpu(unsigned int cpu) irq_unlock_sparse(); return ret; } +#endif static int finish_cpu(unsigned int cpu) { @@ -1940,13 +1981,38 @@ static struct cpuhp_step cpuhp_hp_states .startup.single = timers_prepare_cpu, .teardown.single = timers_dead_cpu, }, - /* Kicks the plugged cpu into life */ + +#ifdef CONFIG_HOTPLUG_SPLIT_STARTUP + /* + * Kicks the AP alive. AP will wait in cpuhp_ap_sync_alive() until + * the next step will release it. + */ + [CPUHP_BP_KICK_AP] = { + .name = "cpu:kick_ap", + .startup.single = cpuhp_kick_ap_alive, + }, + + /* + * Waits for the AP to reach cpuhp_ap_sync_alive() and then + * releases it for the complete bringup. + */ + [CPUHP_BRINGUP_CPU] = { + .name = "cpu:bringup", + .startup.single = cpuhp_bringup_ap, + .teardown.single = finish_cpu, + .cant_stop = true, + }, +#else + /* + * All-in-one CPU bringup state which includes the kick alive. + */ [CPUHP_BRINGUP_CPU] = { .name = "cpu:bringup", .startup.single = bringup_cpu, .teardown.single = finish_cpu, .cant_stop = true, }, +#endif /* Final state before CPU kills itself */ [CPUHP_AP_IDLE_DEAD] = { .name = "idle:dead", From xen-devel-bounces@lists.xenproject.org Thu May 04 19:09:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:09:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529936.825025 (Exim 4.92) (envelope-from ) id 1pueKa-0006UF-D0; Thu, 04 May 2023 19:09:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529936.825025; Thu, 04 May 2023 19:09:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueKa-0006S5-2y; Thu, 04 May 2023 19:09:32 +0000 Received: by outflank-mailman (input) for mailman id 529936; Thu, 04 May 2023 19:09:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDj-00042j-BA for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:27 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 35d37f1b-eaae-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:02:26 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 35d37f1b-eaae-11ed-b226-6b7b168915f2 Message-ID: <20230504185937.257347750@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226946; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=7K79vzHgMUP9R0A/9c85ZFgwBToV4EA8CXJkDqIYiAA=; b=UC7UBpzkmxaEWM2nz/Qw6Vjvrnn6fWsNM/KnljWxV7HMtz5u7vnaAfODd1M7vTr5ktTb20 nVojYUScHcp2OqOxJ8IqsoIvsDu/7IdzIUdDuRTyFO8wPuGlIHpnfYJUn5p8bx3AiClEX1 fRskIOaKRFHPshjjQegmMKxWZJiKU/W1wNR+46su4jgsn/9Va0iMm7QqwA01siEqX7wCZg cW+AbT9hwgRm2RTXxGoRlf6T+Y7L4Mnn/bxe5uXiXqUdghVOxD2GUZ9J1ZZ4wpm572Kggb lAqMgDTfSLuvpAL4aW6s90BbYxngLSPUP8QvW4PAuFXJ0OZBFaKLB/9XRIX9dw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226946; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=7K79vzHgMUP9R0A/9c85ZFgwBToV4EA8CXJkDqIYiAA=; b=y1BzbUsMle0wpOLNE2p2p2IO/b5quxM8T3suQns4J8s0UcXtZFuk8jCSoUG3pH8YtIQT2K ezemL9386MNKclAg== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch V2 17/38] x86/xen/hvm: Get rid of DEAD_FROZEN handling References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:25 +0200 (CEST) From: Thomas Gleixner No point in this conditional voodoo. Un-initializing the lock mechanism is safe to be called unconditionally even if it was already invoked when the CPU died. Remove the invocation of xen_smp_intr_free() as that has been already cleaned up in xen_cpu_dead_hvm(). Signed-off-by: Thomas Gleixner Cc: Juergen Gross Cc: Boris Ostrovsky Cc: xen-devel@lists.xenproject.org --- arch/x86/xen/enlighten_hvm.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) --- --- a/arch/x86/xen/enlighten_hvm.c +++ b/arch/x86/xen/enlighten_hvm.c @@ -161,13 +161,12 @@ static int xen_cpu_up_prepare_hvm(unsign int rc = 0; /* - * This can happen if CPU was offlined earlier and - * offlining timed out in common_cpu_die(). + * If a CPU was offlined earlier and offlining timed out then the + * lock mechanism is still initialized. Uninit it unconditionally + * as it's safe to call even if already uninited. Interrupts and + * timer have already been handled in xen_cpu_dead_hvm(). */ - if (cpu_report_state(cpu) == CPU_DEAD_FROZEN) { - xen_smp_intr_free(cpu); - xen_uninit_lock_cpu(cpu); - } + xen_uninit_lock_cpu(cpu); if (cpu_acpi_id(cpu) != U32_MAX) per_cpu(xen_vcpu_id, cpu) = cpu_acpi_id(cpu); From xen-devel-bounces@lists.xenproject.org Thu May 04 19:09:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:09:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529937.825029 (Exim 4.92) (envelope-from ) id 1pueKa-0006eq-Qc; Thu, 04 May 2023 19:09:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529937.825029; Thu, 04 May 2023 19:09:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueKa-0006bj-JT; Thu, 04 May 2023 19:09:32 +0000 Received: by outflank-mailman (input) for mailman id 529937; Thu, 04 May 2023 19:09:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueE6-00042k-V7 for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:50 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4349763a-eaae-11ed-8611-37d641c3527e; Thu, 04 May 2023 21:02:49 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4349763a-eaae-11ed-8611-37d641c3527e Message-ID: <20230504185938.019102098@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=/CyZEPJpAlcZassSDf6yPEl3fpuFiplGVJNrFAE1PjY=; b=JeZqr+iiqJKFh0frIQBEVa7KD1KSyYbB9ecZpoyy+Ss/8iF+SulZrNYmpNtbaINJPS+GKN Q6QZfpf+NIX8lp5U7q5IujAix4aBXn2NuS91LKTuT2EN4Wx27Sc9ozVGaKryZ1Xz3aRx2+ pp8GZXqg1tw/FM8H1JHmg09BpGTRsIUfCFt3B7zeMEtw/SuA3yHhIfdyfHSJKF8aaDmkKn qwpwBR9+GFxfv0EF2zQ4uLzx0BTfrYNVsAosc3zXIaKDTQTdRFy5RnXNSRt5/H9P60pdjJ D6kES7EIGSOfUpN+Y62CgSsoDjmz21DT61TP4zDe+YR8Qs5pB+Pp23YRydrpMw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=/CyZEPJpAlcZassSDf6yPEl3fpuFiplGVJNrFAE1PjY=; b=QiMfb78X11T9xHP4n7a/ByAPbBWoJBf5QSjjdz3uu1bRQb6HpSz+jFnI3924nrlMSI1nr3 XF1289B2KoIGXfCw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch V2 31/38] x86/apic: Provide cpu_primary_thread mask References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:48 +0200 (CEST) From: Thomas Gleixner Make the primary thread tracking CPU mask based in preparation for simpler handling of parallel bootup. Signed-off-by: Thomas Gleixner --- arch/x86/include/asm/apic.h | 2 -- arch/x86/include/asm/topology.h | 19 +++++++++++++++---- arch/x86/kernel/apic/apic.c | 20 +++++++++----------- arch/x86/kernel/smpboot.c | 12 +++--------- 4 files changed, 27 insertions(+), 26 deletions(-) --- --- a/arch/x86/include/asm/apic.h +++ b/arch/x86/include/asm/apic.h @@ -506,10 +506,8 @@ extern int default_check_phys_apicid_pre #endif /* CONFIG_X86_LOCAL_APIC */ #ifdef CONFIG_SMP -bool apic_id_is_primary_thread(unsigned int id); void apic_smt_update(void); #else -static inline bool apic_id_is_primary_thread(unsigned int id) { return false; } static inline void apic_smt_update(void) { } #endif --- a/arch/x86/include/asm/topology.h +++ b/arch/x86/include/asm/topology.h @@ -31,9 +31,9 @@ * CONFIG_NUMA. */ #include +#include #ifdef CONFIG_NUMA -#include #include #include @@ -139,9 +139,20 @@ static inline int topology_max_smt_threa int topology_update_package_map(unsigned int apicid, unsigned int cpu); int topology_update_die_map(unsigned int dieid, unsigned int cpu); int topology_phys_to_logical_pkg(unsigned int pkg); -bool topology_is_primary_thread(unsigned int cpu); bool topology_smt_supported(void); -#else + +extern struct cpumask __cpu_primary_thread_mask; +#define cpu_primary_thread_mask ((const struct cpumask *)&__cpu_primary_thread_mask) + +/** + * topology_is_primary_thread - Check whether CPU is the primary SMT thread + * @cpu: CPU to check + */ +static inline bool topology_is_primary_thread(unsigned int cpu) +{ + return cpumask_test_cpu(cpu, cpu_primary_thread_mask); +} +#else /* CONFIG_SMP */ #define topology_max_packages() (1) static inline int topology_update_package_map(unsigned int apicid, unsigned int cpu) { return 0; } @@ -152,7 +163,7 @@ static inline int topology_max_die_per_p static inline int topology_max_smt_threads(void) { return 1; } static inline bool topology_is_primary_thread(unsigned int cpu) { return true; } static inline bool topology_smt_supported(void) { return false; } -#endif +#endif /* !CONFIG_SMP */ static inline void arch_fix_phys_package_id(int num, u32 slot) { --- a/arch/x86/kernel/apic/apic.c +++ b/arch/x86/kernel/apic/apic.c @@ -2386,20 +2386,16 @@ bool arch_match_cpu_phys_id(int cpu, u64 } #ifdef CONFIG_SMP -/** - * apic_id_is_primary_thread - Check whether APIC ID belongs to a primary thread - * @apicid: APIC ID to check - */ -bool apic_id_is_primary_thread(unsigned int apicid) +static void cpu_mark_primary_thread(unsigned int cpu, unsigned int apicid) { - u32 mask; - - if (smp_num_siblings == 1) - return true; /* Isolate the SMT bit(s) in the APICID and check for 0 */ - mask = (1U << (fls(smp_num_siblings) - 1)) - 1; - return !(apicid & mask); + u32 mask = (1U << (fls(smp_num_siblings) - 1)) - 1; + + if (smp_num_siblings == 1 || !(apicid & mask)) + cpumask_set_cpu(cpu, &__cpu_primary_thread_mask); } +#else +static inline void cpu_mark_primary_thread(unsigned int cpu, unsigned int apicid) { } #endif /* @@ -2544,6 +2540,8 @@ int generic_processor_info(int apicid, i set_cpu_present(cpu, true); num_processors++; + cpu_mark_primary_thread(cpu, apicid); + return cpu; } --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -102,6 +102,9 @@ EXPORT_PER_CPU_SYMBOL(cpu_die_map); DEFINE_PER_CPU_READ_MOSTLY(struct cpuinfo_x86, cpu_info); EXPORT_PER_CPU_SYMBOL(cpu_info); +/* CPUs which are the primary SMT threads */ +struct cpumask __cpu_primary_thread_mask __read_mostly; + /* Representing CPUs for which sibling maps can be computed */ static cpumask_var_t cpu_sibling_setup_mask; @@ -283,15 +286,6 @@ static void notrace start_secondary(void } /** - * topology_is_primary_thread - Check whether CPU is the primary SMT thread - * @cpu: CPU to check - */ -bool topology_is_primary_thread(unsigned int cpu) -{ - return apic_id_is_primary_thread(per_cpu(x86_cpu_to_apicid, cpu)); -} - -/** * topology_smt_supported - Check whether SMT is supported by the CPUs */ bool topology_smt_supported(void) From xen-devel-bounces@lists.xenproject.org Thu May 04 19:09:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:09:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529949.825052 (Exim 4.92) (envelope-from ) id 1pueKo-0008MM-C9; Thu, 04 May 2023 19:09:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529949.825052; Thu, 04 May 2023 19:09:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueKo-0008MD-9H; Thu, 04 May 2023 19:09:46 +0000 Received: by outflank-mailman (input) for mailman id 529949; Thu, 04 May 2023 19:09:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueE9-00042j-3B for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:53 +0000 Received: from galois.linutronix.de (galois.linutronix.de [2a0a:51c0:0:12e:550::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 453fc104-eaae-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:02:52 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 453fc104-eaae-11ed-b226-6b7b168915f2 Message-ID: <20230504185938.126719312@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226972; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=C2xEv0EYOzjjBDOf0WNXDnbg3SxiEflVftHaff1ezNc=; b=R7TFizeMBd1vCDVjEXU0BtfNbQoQd0Q7O5Cmi/GhoH+A7DPO/eDCQYvwL8d0EzW6TZevXV zTSW3dCyZNMiwvAMbTbcTVfTHbY6pLve5Gv/afd1jzhLujx3f5ZspMS2zkpgXg0oDc3s5d kXcBYyWoHlipJH2VBBXdFP8QtRznLbAKZV10Ph92/Hk65CJwnRS+0u5oUwspH7khzqSQ/u SpYu0bcq4JwwE/JeCF3NwhBMiC+1RMRMfogzt5BdrL549/PBdPFpI4eEajMl9aEC63+JVF 9zu2Vsz02+ZJpxAIfDIw2+6pnaLRSdZXjwd9Lq61E8b+1bqiBtxkam2eHoBKxg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226972; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=C2xEv0EYOzjjBDOf0WNXDnbg3SxiEflVftHaff1ezNc=; b=L3yFFvyeaWcbSL4+w4FNUsUl3Xq9FYBhGlVedajTlxgN49PBR5/K5uqBP8Q/AEH8xz/YfX kk6rHy0rbLZe69Cw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch V2 33/38] x86/topology: Store extended topology leaf information References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:51 +0200 (CEST) From: Thomas Gleixner Save the extended topology leaf number if it exists and is valid in preparation of parallel CPU bringup. Signed-off-by: Thomas Gleixner --- arch/x86/include/asm/topology.h | 1 + arch/x86/kernel/cpu/topology.c | 3 +++ 2 files changed, 4 insertions(+) --- --- a/arch/x86/include/asm/topology.h +++ b/arch/x86/include/asm/topology.h @@ -121,6 +121,7 @@ extern unsigned int __max_die_per_packag #define topology_core_cpumask(cpu) (per_cpu(cpu_core_map, cpu)) #define topology_sibling_cpumask(cpu) (per_cpu(cpu_sibling_map, cpu)) +extern unsigned int topology_extended_leaf; extern unsigned int __max_logical_packages; #define topology_max_packages() (__max_logical_packages) --- a/arch/x86/kernel/cpu/topology.c +++ b/arch/x86/kernel/cpu/topology.c @@ -29,6 +29,8 @@ unsigned int __max_die_per_package __rea EXPORT_SYMBOL(__max_die_per_package); #ifdef CONFIG_SMP +unsigned int topology_extended_leaf __read_mostly; + /* * Check if given CPUID extended topology "leaf" is implemented */ @@ -72,6 +74,7 @@ int detect_extended_topology_early(struc if (leaf < 0) return -1; + topology_extended_leaf = leaf; set_cpu_cap(c, X86_FEATURE_XTOPOLOGY); cpuid_count(leaf, SMT_LEVEL, &eax, &ebx, &ecx, &edx); From xen-devel-bounces@lists.xenproject.org Thu May 04 19:09:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:09:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529958.825062 (Exim 4.92) (envelope-from ) id 1pueKt-0000bl-Jy; Thu, 04 May 2023 19:09:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529958.825062; Thu, 04 May 2023 19:09:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueKt-0000bV-HK; Thu, 04 May 2023 19:09:51 +0000 Received: by outflank-mailman (input) for mailman id 529958; Thu, 04 May 2023 19:09:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDh-00042j-KE for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:25 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 34e19d1e-eaae-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:02:25 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 34e19d1e-eaae-11ed-b226-6b7b168915f2 Message-ID: <20230504185937.201611990@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226944; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=8IR2ZEar7xSTX3+WcC3NFIdAp4AUTKg+YP70lXONDYs=; b=b5Dhpk7DXri1g+Jk4Fccefqph5HHh5m0O6WHx1dP1v8spz8TW/ZVEXRzP6Fu5Vyp4twGau 0WJ5VSOP7FkG0YM49DJA3ab9WsH+lMCnQQToJbW5YLIvGGqyCD5SuatG+70PddmmocvInY sbywrL3O4QW1MGnAo6cSBXhCM/VRCDBpxMydY3h/7/ooJkjuTTpet2ZIX0gkrKNjXC4iyZ NM25MYCPlURsUrvY1AdwvXfa3J2aswhoiO4UsIkjW2ZgbjIhOmU0uQ9SDbhRPFEyzNsNh0 mS7KdesNxpuJcwz0hAomc0k47L5YQTKWUQ3/pEIBgfRwzYecCD6MkvQPPrVSxw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226944; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=8IR2ZEar7xSTX3+WcC3NFIdAp4AUTKg+YP70lXONDYs=; b=dn+I2+Yxq6eST9WYLeBz7I//tSeh1zP1C4UnkiRYUPrB/Bi9OJVO0kV5NCl8mWHGp/F1Kx csRGXLzl80A3yQBw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch V2 16/38] x86/xen/smp_pv: Remove wait for CPU online References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:24 +0200 (CEST) From: Thomas Gleixner Now that the core code drops sparse_irq_lock after the idle thread synchronized, it's pointless to wait for the AP to mark itself online. Whether the control CPU runs in a wait loop or sleeps in the core code waiting for the online operation to complete makes no difference. Signed-off-by: Thomas Gleixner Cc: Juergen Gross Cc: Boris Ostrovsky Cc: xen-devel@lists.xenproject.org --- arch/x86/xen/smp_pv.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) --- --- a/arch/x86/xen/smp_pv.c +++ b/arch/x86/xen/smp_pv.c @@ -340,11 +340,11 @@ static int xen_pv_cpu_up(unsigned int cp xen_pmu_init(cpu); - rc = HYPERVISOR_vcpu_op(VCPUOP_up, xen_vcpu_nr(cpu), NULL); - BUG_ON(rc); - - while (cpu_report_state(cpu) != CPU_ONLINE) - HYPERVISOR_sched_op(SCHEDOP_yield, NULL); + /* + * Why is this a BUG? If the hypercall fails then everything can be + * rolled back, no? + */ + BUG_ON(HYPERVISOR_vcpu_op(VCPUOP_up, xen_vcpu_nr(cpu), NULL)); return 0; } From xen-devel-bounces@lists.xenproject.org Thu May 04 19:09:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:09:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529962.825069 (Exim 4.92) (envelope-from ) id 1pueKu-0000gv-42; Thu, 04 May 2023 19:09:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529962.825069; Thu, 04 May 2023 19:09:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueKt-0000ee-SK; Thu, 04 May 2023 19:09:51 +0000 Received: by outflank-mailman (input) for mailman id 529962; Thu, 04 May 2023 19:09:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueEF-00042j-UE for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:59 +0000 Received: from galois.linutronix.de (galois.linutronix.de [2a0a:51c0:0:12e:550::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 49347d17-eaae-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:02:59 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 49347d17-eaae-11ed-b226-6b7b168915f2 Message-ID: <20230504185938.339811042@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=upC4xkPPrMs610atpDkPLXATkmq4wC3sFnO5m7xr5Mk=; b=tYQKH5LD4/bbax8XIkS2IfxvQW+jtTqnFhM0UC2BJL7JwyxQQk35fQ4DnIpjghBefCJsm7 P+1s/BcE7c8Le2JQCtdXTEVe77jYdm91mOAH1a7Pas6H2yZPwUeewlGe6jf98m0L1QOOdl l8SUUcJVumcQ3CYnqLcAdr8T4FJi3NtquA7LjD1muU3H85kQUn83bT5W0gtnGSZT7Vo9+s 0EfEAbAL4lNPVIulxXJipEHdvdzaxlrN/rqc9fO2zc1ZFMWBa/L5rQJPYodzEY71Kx3u7w 1lIeT8YLpfIQhOcV4McTONWEkRR3daf5G8z27enuu98B/SK5Mo0nAa86XKEJqA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=upC4xkPPrMs610atpDkPLXATkmq4wC3sFnO5m7xr5Mk=; b=KFQyiHdPzE8IY2FhvYi2d28BxvSxl7bssB/iRxDq20Peb65/yNDsIpOVSz0WpIiOobDIBb Wudxsc+Jf6JAYLCw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" , David Woodhouse Subject: [patch V2 37/38] x86/smpboot: Support parallel startup of secondary CPUs References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:58 +0200 (CEST) From: David Woodhouse In parallel startup mode the APs are kicked alive by the control CPU quickly after each other and run through the early startup code in parallel. The real-mode startup code is already serialized with a bit-spinlock to protect the real-mode stack. In parallel startup mode the smpboot_control variable obviously cannot contain the Linux CPU number so the APs have to determine their Linux CPU number on their own. This is required to find the CPUs per CPU offset in order to find the idle task stack and other per CPU data. To achieve this, export the cpuid_to_apicid[] array so that each AP can find its own CPU number by searching therein based on its APIC ID. Introduce a flag in the top bits of smpboot_control which indicates that the AP should find its CPU number by reading the APIC ID from the APIC. This is required because CPUID based APIC ID retrieval can only provide the initial APIC ID, which might have been overruled by the firmware. Some AMD APUs come up with APIC ID = initial APIC ID + 0x10, so the APIC ID to CPU number lookup would fail miserably if based on CPUID. Also virtualization can make its own APIC ID assignements. The only requirement is that the APIC IDs are consistent with the APCI/MADT table. For the boot CPU or in case parallel bringup is disabled the control bits are empty and the CPU number is directly available in bit 0-23 of smpboot_control. [ tglx: Initial proof of concept patch with bitlock and APIC ID lookup ] [ dwmw2: Rework and testing, commit message, CPUID 0x1 and CPU0 support ] [ seanc: Fix stray override of initial_gs in common_cpu_up() ] [ Oleksandr Natalenko: reported suspend/resume issue fixed in x86_acpi_suspend_lowlevel ] [ tglx: Make it read the APIC ID from the APIC instead of using CPUID, split the bitlock part out ] Co-developed-by: Thomas Gleixner Signed-off-by: Thomas Gleixner Co-developed-by: Brian Gerst Signed-off-by: Brian Gerst Signed-off-by: David Woodhouse Signed-off-by: Thomas Gleixner --- arch/x86/include/asm/apic.h | 2 + arch/x86/include/asm/apicdef.h | 5 ++- arch/x86/include/asm/smp.h | 6 +++ arch/x86/kernel/acpi/sleep.c | 9 +++++ arch/x86/kernel/apic/apic.c | 2 - arch/x86/kernel/head_64.S | 62 +++++++++++++++++++++++++++++++++++++++++ arch/x86/kernel/smpboot.c | 2 - 7 files changed, 84 insertions(+), 4 deletions(-) --- --- a/arch/x86/include/asm/apic.h +++ b/arch/x86/include/asm/apic.h @@ -55,6 +55,8 @@ extern int local_apic_timer_c2_ok; extern int disable_apic; extern unsigned int lapic_timer_period; +extern int cpuid_to_apicid[]; + extern enum apic_intr_mode_id apic_intr_mode; enum apic_intr_mode_id { APIC_PIC, --- a/arch/x86/include/asm/apicdef.h +++ b/arch/x86/include/asm/apicdef.h @@ -138,7 +138,8 @@ #define APIC_EILVT_MASKED (1 << 16) #define APIC_BASE (fix_to_virt(FIX_APIC_BASE)) -#define APIC_BASE_MSR 0x800 +#define APIC_BASE_MSR 0x800 +#define APIC_X2APIC_ID_MSR 0x802 #define XAPIC_ENABLE (1UL << 11) #define X2APIC_ENABLE (1UL << 10) @@ -162,6 +163,7 @@ #define APIC_CPUID(apicid) ((apicid) & XAPIC_DEST_CPUS_MASK) #define NUM_APIC_CLUSTERS ((BAD_APICID + 1) >> XAPIC_DEST_CPUS_SHIFT) +#ifndef __ASSEMBLY__ /* * the local APIC register structure, memory mapped. Not terribly well * tested, but we might eventually use this one in the future - the @@ -435,4 +437,5 @@ enum apic_delivery_modes { APIC_DELIVERY_MODE_EXTINT = 7, }; +#endif /* !__ASSEMBLY__ */ #endif /* _ASM_X86_APICDEF_H */ --- a/arch/x86/include/asm/smp.h +++ b/arch/x86/include/asm/smp.h @@ -200,4 +200,10 @@ extern unsigned long apic_mmio_base; #endif /* !__ASSEMBLY__ */ +/* Control bits for startup_64 */ +#define STARTUP_READ_APICID 0x80000000 + +/* Top 8 bits are reserved for control */ +#define STARTUP_PARALLEL_MASK 0xFF000000 + #endif /* _ASM_X86_SMP_H */ --- a/arch/x86/kernel/acpi/sleep.c +++ b/arch/x86/kernel/acpi/sleep.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #include "../../realmode/rm/wakeup.h" @@ -127,7 +128,13 @@ int x86_acpi_suspend_lowlevel(void) * value is in the actual %rsp register. */ current->thread.sp = (unsigned long)temp_stack + sizeof(temp_stack); - smpboot_control = smp_processor_id(); + /* + * Ensure the CPU knows which one it is when it comes back, if + * it isn't in parallel mode and expected to work that out for + * itself. + */ + if (!(smpboot_control & STARTUP_PARALLEL_MASK)) + smpboot_control = smp_processor_id(); #endif initial_code = (unsigned long)wakeup_long64; saved_magic = 0x123456789abcdef0L; --- a/arch/x86/kernel/apic/apic.c +++ b/arch/x86/kernel/apic/apic.c @@ -2380,7 +2380,7 @@ static int nr_logical_cpuids = 1; /* * Used to store mapping between logical CPU IDs and APIC IDs. */ -static int cpuid_to_apicid[] = { +int cpuid_to_apicid[] = { [0 ... NR_CPUS - 1] = -1, }; --- a/arch/x86/kernel/head_64.S +++ b/arch/x86/kernel/head_64.S @@ -24,7 +24,9 @@ #include "../entry/calling.h" #include #include +#include #include +#include /* * We are not able to switch in one step to the final KERNEL ADDRESS SPACE @@ -234,8 +236,68 @@ SYM_INNER_LABEL(secondary_startup_64_no_ ANNOTATE_NOENDBR // above #ifdef CONFIG_SMP + /* + * For parallel boot, the APIC ID is read from the APIC, and then + * used to look up the CPU number. For booting a single CPU, the + * CPU number is encoded in smpboot_control. + * + * Bit 31 STARTUP_READ_APICID (Read APICID from APIC) + * Bit 0-23 CPU# if STARTUP_xx flags are not set + */ movl smpboot_control(%rip), %ecx + testl $STARTUP_READ_APICID, %ecx + jnz .Lread_apicid + /* + * No control bit set, single CPU bringup. CPU number is provided + * in bit 0-23. This is also the boot CPU case (CPU number 0). + */ + andl $(~STARTUP_PARALLEL_MASK), %ecx + jmp .Lsetup_cpu + +.Lread_apicid: + /* Check whether X2APIC mode is already enabled */ + mov $MSR_IA32_APICBASE, %ecx + rdmsr + testl $X2APIC_ENABLE, %eax + jnz .Lread_apicid_msr + + /* Read the APIC ID from the fix-mapped MMIO space. */ + movq apic_mmio_base(%rip), %rcx + addq $APIC_ID, %rcx + movl (%rcx), %eax + shr $24, %eax + jmp .Llookup_AP + +.Lread_apicid_msr: + mov $APIC_X2APIC_ID_MSR, %ecx + rdmsr + +.Llookup_AP: + /* EAX contains the APIC ID of the current CPU */ + xorq %rcx, %rcx + leaq cpuid_to_apicid(%rip), %rbx + +.Lfind_cpunr: + cmpl (%rbx,%rcx,4), %eax + jz .Lsetup_cpu + inc %ecx +#ifdef CONFIG_FORCE_NR_CPUS + cmpl $NR_CPUS, %ecx +#else + cmpl nr_cpu_ids(%rip), %ecx +#endif + jb .Lfind_cpunr + + /* APIC ID not found in the table. Drop the trampoline lock and bail. */ + movq trampoline_lock(%rip), %rax + lock + btrl $0, (%rax) + +1: cli + hlt + jmp 1b +.Lsetup_cpu: /* Get the per cpu offset for the given CPU# which is in ECX */ movq __per_cpu_offset(,%rcx,8), %rdx #else --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -1002,7 +1002,7 @@ static int do_boot_cpu(int apicid, int c if (IS_ENABLED(CONFIG_X86_32)) { early_gdt_descr.address = (unsigned long)get_cpu_gdt_rw(cpu); initial_stack = idle->thread.sp; - } else { + } else if (!(smpboot_control & STARTUP_PARALLEL_MASK)) { smpboot_control = cpu; } From xen-devel-bounces@lists.xenproject.org Thu May 04 19:09:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:09:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529963.825074 (Exim 4.92) (envelope-from ) id 1pueKu-0000oq-OH; Thu, 04 May 2023 19:09:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529963.825074; Thu, 04 May 2023 19:09:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueKu-0000kh-7H; Thu, 04 May 2023 19:09:52 +0000 Received: by outflank-mailman (input) for mailman id 529963; Thu, 04 May 2023 19:09:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDx-00042j-TZ for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:41 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3e871476-eaae-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:02:41 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e871476-eaae-11ed-b226-6b7b168915f2 Message-ID: <20230504185937.753526411@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=t+vCm64b4itQSl2LfKU8VrA27XKQ2KG5zUbd2mh4iV8=; b=ml6E+TXawV3yhhGCubFqgqufAZpTjpSiELyk/vrlZ3ms0dhrtAmXtDWQA1yMzAcLqw6EXj bFhc2tyQcBuQ33Bsz5zsKXgWIdU4zRB8yjhEhspCgWXshlokE4Q+JyTBI+TjRiiOk+rcml fl/hAT8Iw2GAj9Ot9oyk6BKqozcGuo7sJpNIvJzE2R06g9w52Mgyku0JBRkEGvJz486uRf KmExkb3oHx2qMv2bo4NLcSHevFECI+NeAIr4un5UMnquDQpRk4nWHteXJM1j5VItMYBQJc o8sXV0liH2x+qJwyn7FfgcHXOI887Tp59x5IcGaiawsgGKlKejdPBbAmAX9ZSw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=t+vCm64b4itQSl2LfKU8VrA27XKQ2KG5zUbd2mh4iV8=; b=9+U6SgXZ5rZ8A4IIpjwy8ijpc6qsJ1JIDkx+eqNJ7PC4GKp6PdTneYgE7ZC/9vOEWcjfFc AmLbek9quVdxpeCQ== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" , Palmer Dabbelt Subject: [patch V2 26/38] riscv: Switch to hotplug core state synchronization References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:40 +0200 (CEST) From: Thomas Gleixner Switch to the CPU hotplug core state tracking and synchronization mechanim. No functional change intended. Signed-off-by: Thomas Gleixner Acked-by: Palmer Dabbelt Cc: Paul Walmsley Cc: linux-riscv@lists.infradead.org --- arch/riscv/Kconfig | 1 + arch/riscv/include/asm/smp.h | 2 +- arch/riscv/kernel/cpu-hotplug.c | 14 +++++++------- 3 files changed, 9 insertions(+), 8 deletions(-) --- --- a/arch/riscv/Kconfig +++ b/arch/riscv/Kconfig @@ -122,6 +122,7 @@ config RISCV select HAVE_RSEQ select HAVE_STACKPROTECTOR select HAVE_SYSCALL_TRACEPOINTS + select HOTPLUG_CORE_SYNC_DEAD if HOTPLUG_CPU select IRQ_DOMAIN select IRQ_FORCED_THREADING select KASAN_VMALLOC if KASAN --- a/arch/riscv/include/asm/smp.h +++ b/arch/riscv/include/asm/smp.h @@ -70,7 +70,7 @@ asmlinkage void smp_callin(void); #if defined CONFIG_HOTPLUG_CPU int __cpu_disable(void); -void __cpu_die(unsigned int cpu); +static inline void __cpu_die(unsigned int cpu) { } #endif /* CONFIG_HOTPLUG_CPU */ #else --- a/arch/riscv/kernel/cpu-hotplug.c +++ b/arch/riscv/kernel/cpu-hotplug.c @@ -8,6 +8,7 @@ #include #include #include +#include #include #include #include @@ -49,17 +50,15 @@ int __cpu_disable(void) return ret; } +#ifdef CONFIG_HOTPLUG_CPU /* - * Called on the thread which is asking for a CPU to be shutdown. + * Called on the thread which is asking for a CPU to be shutdown, if the + * CPU reported dead to the hotplug core. */ -void __cpu_die(unsigned int cpu) +void arch_cpuhp_cleanup_dead_cpu(unsigned int cpu) { int ret = 0; - if (!cpu_wait_death(cpu, 5)) { - pr_err("CPU %u: didn't die\n", cpu); - return; - } pr_notice("CPU%u: off\n", cpu); /* Verify from the firmware if the cpu is really stopped*/ @@ -76,9 +75,10 @@ void __noreturn arch_cpu_idle_dead(void) { idle_task_exit(); - (void)cpu_report_death(); + cpuhp_ap_report_dead(); cpu_ops[smp_processor_id()]->cpu_stop(); /* It should never reach here */ BUG(); } +#endif From xen-devel-bounces@lists.xenproject.org Thu May 04 19:09:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:09:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529969.825093 (Exim 4.92) (envelope-from ) id 1pueKw-0001XP-Om; Thu, 04 May 2023 19:09:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529969.825093; Thu, 04 May 2023 19:09:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueKw-0001XC-KV; Thu, 04 May 2023 19:09:54 +0000 Received: by outflank-mailman (input) for mailman id 529969; Thu, 04 May 2023 19:09:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDr-00042k-HX for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:35 +0000 Received: from galois.linutronix.de (galois.linutronix.de [2a0a:51c0:0:12e:550::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 39a58b9c-eaae-11ed-8611-37d641c3527e; Thu, 04 May 2023 21:02:33 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 39a58b9c-eaae-11ed-8611-37d641c3527e Message-ID: <20230504185937.477649111@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226952; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=J5ghl8+CFsq8rw8xRo6ZeJvRj8tj82GRgWZ3Thf5XTs=; b=QenhqFcoejPtec/MlD+hqV1n9MlgT2acU00U3XD2Oc1Pol7q/9eI63VtS15ZCC/d+9WDGA KxchOK615tOJzZsBewTOkPd1Jd5+B3is2a42u/N5CTkPLatyJZrrvz8FEIqC7XWO8in3oU 53hbjDByv1h2xPpYpva0v6RgjUscQ2HfSl/jqKFOass4OpUQpzxo6UHcGhtLw9087/2M+Z tt8EMVFZ49ggeVcETqNdsJDpa2BsXfwNUKKIIKpi+M53OvsvG9KFTR5Ffn+WK+321Pqy5y ZzdinLtGlwMYQuT48xSu+HgHHks4RytPcjC2QUYQ0+Ziux8bRvvTSEM3m/LHVw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226952; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=J5ghl8+CFsq8rw8xRo6ZeJvRj8tj82GRgWZ3Thf5XTs=; b=jA8uBZa7TYtw4jZ6vKFGruDR2mfnjcH3f8p0I307i2kdUOd1y2C6N6fsUQhyOplmByw+pg yUiP5bOguA/FxuBw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch V2 21/38] ARM: smp: Switch to hotplug core state synchronization References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:32 +0200 (CEST) From: Thomas Gleixner Switch to the CPU hotplug core state tracking and synchronization mechanim. No functional change intended. Signed-off-by: Thomas Gleixner Cc: Russell King Cc: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org --- arch/arm/Kconfig | 1 + arch/arm/include/asm/smp.h | 2 +- arch/arm/kernel/smp.c | 18 +++++++----------- 3 files changed, 9 insertions(+), 12 deletions(-) --- --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -124,6 +124,7 @@ config ARM select HAVE_SYSCALL_TRACEPOINTS select HAVE_UID16 select HAVE_VIRT_CPU_ACCOUNTING_GEN + select HOTPLUG_CORE_SYNC_DEAD if HOTPLUG_CPU select IRQ_FORCED_THREADING select MODULES_USE_ELF_REL select NEED_DMA_MAP_STATE --- a/arch/arm/include/asm/smp.h +++ b/arch/arm/include/asm/smp.h @@ -64,7 +64,7 @@ extern void secondary_startup_arm(void); extern int __cpu_disable(void); -extern void __cpu_die(unsigned int cpu); +static inline void __cpu_die(unsigned int cpu) { } extern void arch_send_call_function_single_ipi(int cpu); extern void arch_send_call_function_ipi_mask(const struct cpumask *mask); --- a/arch/arm/kernel/smp.c +++ b/arch/arm/kernel/smp.c @@ -288,15 +288,11 @@ int __cpu_disable(void) } /* - * called on the thread which is asking for a CPU to be shutdown - - * waits until shutdown has completed, or it is timed out. + * called on the thread which is asking for a CPU to be shutdown after the + * shutdown completed. */ -void __cpu_die(unsigned int cpu) +void arch_cpuhp_cleanup_dead_cpu(unsigned int cpu) { - if (!cpu_wait_death(cpu, 5)) { - pr_err("CPU%u: cpu didn't die\n", cpu); - return; - } pr_debug("CPU%u: shutdown\n", cpu); clear_tasks_mm_cpumask(cpu); @@ -336,11 +332,11 @@ void __noreturn arch_cpu_idle_dead(void) flush_cache_louis(); /* - * Tell __cpu_die() that this CPU is now safe to dispose of. Once - * this returns, power and/or clocks can be removed at any point - * from this CPU and its cache by platform_cpu_kill(). + * Tell cpuhp_bp_sync_dead() that this CPU is now safe to dispose + * of. Once this returns, power and/or clocks can be removed at + * any point from this CPU and its cache by platform_cpu_kill(). */ - (void)cpu_report_death(); + cpuhp_ap_report_dead(); /* * Ensure that the cache lines associated with that completion are From xen-devel-bounces@lists.xenproject.org Thu May 04 19:09:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:09:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529970.825098 (Exim 4.92) (envelope-from ) id 1pueKx-0001bs-6N; Thu, 04 May 2023 19:09:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529970.825098; Thu, 04 May 2023 19:09:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueKx-0001bL-0M; Thu, 04 May 2023 19:09:55 +0000 Received: by outflank-mailman (input) for mailman id 529970; Thu, 04 May 2023 19:09:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueE7-00042j-LH for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:51 +0000 Received: from galois.linutronix.de (galois.linutronix.de [2a0a:51c0:0:12e:550::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 444a8d57-eaae-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:02:51 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 444a8d57-eaae-11ed-b226-6b7b168915f2 Message-ID: <20230504185938.073662723@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226970; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=uPvntfwXoWAcfAS+SI4cvobPK1ZyCeBK1UEsrRJoKHI=; b=pGPnJYtp3Tpg+MMWkzGo2xuJZap0dH1jxlVLp3HnSKPjWhKQ7lUp8uBcRJgQC6IITlm0cJ 1aGXFaHVXyvjBYzo9xhPU6Q9Hlb63Li5My1zMC5rKjhrcSFv9FrMoJC2AzdXeGim5XsZqz 9v+nMgLyDTt/fW+8fRbtwh/FoW+E8TIs7Of6L7ZL4PjyPe5sHR924eR8F6uIhyHQM8vAHb 4Q2e21rxSOrBXM8NWwvByPprou5mbPG7hQgLJJYj7UgEiLVag9IaPlw+QpmbIBOOjhqHUl BPFnbOSeBcOh1u6IqXuRouJv9SchS3OwdJYKx3EiyYmJQVnhihqfn9NcfJFqRg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226970; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=uPvntfwXoWAcfAS+SI4cvobPK1ZyCeBK1UEsrRJoKHI=; b=x2+bLbNKqKUzBlReY4wD0HaXB51VfG+zRONPZUd5afPPYXsV8jL1krzs8Tu9sGDHvinTTA c6yOUa4jvvA0hODA== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" , David Woodhouse Subject: [patch V2 32/38] cpu/hotplug: Allow "parallel" bringup up to CPUHP_BP_KICK_AP_STATE References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:50 +0200 (CEST) From: Thomas Gleixner There is often significant latency in the early stages of CPU bringup, and time is wasted by waking each CPU (e.g. with SIPI/INIT/INIT on x86) and then waiting for it to respond before moving on to the next. Allow a platform to enable parallel setup which brings all to be onlined CPUs up to the CPUHP_BP_KICK_AP state. While this state advancement on the control CPU (BP) is single-threaded the important part is the last state CPUHP_BP_KICK_AP which wakes the to be onlined CPUs up. This allows the CPUs to run up to the first sychronization point cpuhp_ap_sync_alive() where they wait for the control CPU to release them one by one for the full onlining procedure. This parallelism depends on the CPU hotplug core sync mechanism which ensures that the parallel brought up CPUs wait for release before touching any state which would make the CPU visible to anything outside the hotplug control mechanism. To handle the SMT constraints of X86 correctly the bringup happens in two iterations when CONFIG_HOTPLUG_SMT is enabled. The control CPU brings up the primary SMT threads of each core first, which can load the microcode without the need to rendevouz with the thread siblings. Once that's completed it brings up the secondary SMT threads. Co-developed-by: David Woodhouse Signed-off-by: David Woodhouse Signed-off-by: Thomas Gleixner --- Documentation/admin-guide/kernel-parameters.txt | 6 + arch/Kconfig | 4 include/linux/cpuhotplug.h | 1 kernel/cpu.c | 103 ++++++++++++++++++++++-- 4 files changed, 109 insertions(+), 5 deletions(-) --- --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -838,6 +838,12 @@ on every CPU online, such as boot, and resume from suspend. Default: 10000 + cpuhp.parallel= + [SMP] Enable/disable parallel bringup of secondary CPUs + Format: + Default is enabled if CONFIG_HOTPLUG_PARALLEL=y. Otherwise + the parameter has no effect. + crash_kexec_post_notifiers Run kdump after running panic-notifiers and dumping kmsg. This only for the users who doubt kdump always --- a/arch/Kconfig +++ b/arch/Kconfig @@ -53,6 +53,10 @@ config HOTPLUG_SPLIT_STARTUP bool select HOTPLUG_CORE_SYNC_FULL +config HOTPLUG_PARALLEL + bool + select HOTPLUG_SPLIT_STARTUP + config GENERIC_ENTRY bool --- a/include/linux/cpuhotplug.h +++ b/include/linux/cpuhotplug.h @@ -524,6 +524,7 @@ void cpuhp_ap_sync_alive(void); void arch_cpuhp_sync_state_poll(void); void arch_cpuhp_cleanup_kick_cpu(unsigned int cpu); int arch_cpuhp_kick_ap_alive(unsigned int cpu, struct task_struct *tidle); +bool arch_cpuhp_init_parallel_bringup(void); #ifdef CONFIG_HOTPLUG_CORE_SYNC_DEAD void cpuhp_ap_report_dead(void); --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -649,8 +649,23 @@ bool cpu_smt_possible(void) cpu_smt_control != CPU_SMT_NOT_SUPPORTED; } EXPORT_SYMBOL_GPL(cpu_smt_possible); + +static inline bool cpuhp_smt_aware(void) +{ + return topology_smt_supported(); +} + +static inline const struct cpumask *cpuhp_get_primary_thread_mask(void) +{ + return cpu_primary_thread_mask; +} #else static inline bool cpu_smt_allowed(unsigned int cpu) { return true; } +static inline bool cpuhp_smt_aware(void) { return false; } +static inline const struct cpumask *cpuhp_get_primary_thread_mask(void) +{ + return cpu_present_mask; +} #endif static inline enum cpuhp_state @@ -1743,16 +1758,94 @@ int bringup_hibernate_cpu(unsigned int s return 0; } -void __init bringup_nonboot_cpus(unsigned int setup_max_cpus) +static void __init cpuhp_bringup_mask(const struct cpumask *mask, unsigned int ncpus, + enum cpuhp_state target) { unsigned int cpu; - for_each_present_cpu(cpu) { - if (num_online_cpus() >= setup_max_cpus) + for_each_cpu(cpu, mask) { + struct cpuhp_cpu_state *st = per_cpu_ptr(&cpuhp_state, cpu); + + if (!--ncpus) break; - if (!cpu_online(cpu)) - cpu_up(cpu, CPUHP_ONLINE); + + if (cpu_up(cpu, target) && can_rollback_cpu(st)) { + /* + * If this failed then cpu_up() might have only + * rolled back to CPUHP_BP_KICK_AP for the final + * online. Clean it up. NOOP if already rolled back. + */ + WARN_ON(cpuhp_invoke_callback_range(false, cpu, st, CPUHP_OFFLINE)); + } + } +} + +#ifdef CONFIG_HOTPLUG_PARALLEL +static bool __cpuhp_parallel_bringup __ro_after_init = true; + +static int __init parallel_bringup_parse_param(char *arg) +{ + return kstrtobool(arg, &__cpuhp_parallel_bringup); +} +early_param("cpuhp.parallel", parallel_bringup_parse_param); + +/* + * On architectures which have enabled parallel bringup this invokes all BP + * prepare states for each of the to be onlined APs first. The last state + * sends the startup IPI to the APs. The APs proceed through the low level + * bringup code in parallel and then wait for the control CPU to release + * them one by one for the final onlining procedure. + * + * This avoids waiting for each AP to respond to the startup IPI in + * CPUHP_BRINGUP_CPU. + */ +static bool __init cpuhp_bringup_cpus_parallel(unsigned int ncpus) +{ + const struct cpumask *mask = cpu_present_mask; + + if (__cpuhp_parallel_bringup) + __cpuhp_parallel_bringup = arch_cpuhp_init_parallel_bringup(); + if (!__cpuhp_parallel_bringup) + return false; + + if (cpuhp_smt_aware()) { + const struct cpumask *pmask = cpuhp_get_primary_thread_mask(); + static struct cpumask tmp_mask __initdata; + + /* + * X86 requires to prevent that SMT siblings stopped while + * the primary thread does a microcode update for various + * reasons. Bring the primary threads up first. + */ + cpumask_and(&tmp_mask, mask, pmask); + cpuhp_bringup_mask(&tmp_mask, ncpus, CPUHP_BP_KICK_AP); + cpuhp_bringup_mask(&tmp_mask, ncpus, CPUHP_ONLINE); + /* Account for the online CPUs */ + ncpus -= num_online_cpus(); + if (!ncpus) + return true; + /* Create the mask for secondary CPUs */ + cpumask_andnot(&tmp_mask, mask, pmask); + mask = &tmp_mask; } + + /* Bring the not-yet started CPUs up */ + cpuhp_bringup_mask(mask, ncpus, CPUHP_BP_KICK_AP); + cpuhp_bringup_mask(mask, ncpus, CPUHP_ONLINE); + return true; +} +#else +static inline bool cpuhp_bringup_cpus_parallel(unsigned int ncpus) { return false; } +#endif /* CONFIG_HOTPLUG_PARALLEL */ + +void __init bringup_nonboot_cpus(unsigned int setup_max_cpus) +{ + /* Try parallel bringup optimization if enabled */ + if (cpuhp_bringup_cpus_parallel(setup_max_cpus)) + return; + + /* Full per CPU serialized bringup */ + cpuhp_bringup_mask(cpu_present_mask, setup_max_cpus, CPUHP_ONLINE); } #ifdef CONFIG_PM_SLEEP_SMP From xen-devel-bounces@lists.xenproject.org Thu May 04 19:09:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:09:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529971.825105 (Exim 4.92) (envelope-from ) id 1pueKx-0001l0-RO; Thu, 04 May 2023 19:09:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529971.825105; Thu, 04 May 2023 19:09:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueKx-0001jk-Gw; Thu, 04 May 2023 19:09:55 +0000 Received: by outflank-mailman (input) for mailman id 529971; Thu, 04 May 2023 19:09:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDz-00042k-ID for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:43 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3c993d89-eaae-11ed-8611-37d641c3527e; Thu, 04 May 2023 21:02:38 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3c993d89-eaae-11ed-8611-37d641c3527e Message-ID: <20230504185937.637064751@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=ALZqTI1WqQMy7B72Ez5E7IdIQ5oXhT4SB1G1mM+q//8=; b=mYnm5MYhl9rGIzht43o2lcVxhO0R8y3aB5aRyOtlB+9KK0J/QmknXcGx5x8PN1YVWVRD3B GUQu025b731mf+nEkF4GI7Ob8UvQa6VPVPqdlahyw70W2WOH/igwzfOVqHBxPSurCU6YxH wEkOpPoEv2xWwm6a7bLiW9tbt8M7692eEWBhWTyKA7OHmC/IgVgvkO72HGXojQ0SvaAoib /bQLIpJj1VFAg0Ej8YehB8/VUFNEcW2ew88JgN73+AojuUn//mB8Tv1GcP3eB1NNPqtphq S4khIQBFzuPtperawUGsq3BmEdOg4bh3XSPwjL4h9A1+3VCy4w0hb5wdRZyzeQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=ALZqTI1WqQMy7B72Ez5E7IdIQ5oXhT4SB1G1mM+q//8=; b=zeGslggBYWDsSd6dEoQqGkVdC/21I+ltkoKmpa5dw1d5iL4yHtQATpFjTDZBiPLB8z5y7b LQX/S5Chy8uvrCAw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch V2 24/38] MIPS: SMP_CPS: Switch to hotplug core state synchronization References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:37 +0200 (CEST) From: Thomas Gleixner Switch to the CPU hotplug core state tracking and synchronization mechanim. This unfortunately requires to add dead reporting to the non CPS platforms as CPS is the only user, but it allows an overall consolidation of this functionality. No functional change intended. Signed-off-by: Thomas Gleixner Cc: Thomas Bogendoerfer Cc: linux-mips@vger.kernel.org --- arch/mips/Kconfig | 1 + arch/mips/cavium-octeon/smp.c | 1 + arch/mips/include/asm/smp-ops.h | 1 + arch/mips/kernel/smp-bmips.c | 1 + arch/mips/kernel/smp-cps.c | 14 +++++--------- arch/mips/kernel/smp.c | 8 ++++++++ arch/mips/loongson64/smp.c | 1 + 7 files changed, 18 insertions(+), 9 deletions(-) --- --- a/arch/mips/Kconfig +++ b/arch/mips/Kconfig @@ -2285,6 +2285,7 @@ config MIPS_CPS select MIPS_CM select MIPS_CPS_PM if HOTPLUG_CPU select SMP + select HOTPLUG_CORE_SYNC_DEAD if HOTPLUG_CPU select SYNC_R4K if (CEVT_R4K || CSRC_R4K) select SYS_SUPPORTS_HOTPLUG_CPU select SYS_SUPPORTS_SCHED_SMT if CPU_MIPSR6 --- a/arch/mips/cavium-octeon/smp.c +++ b/arch/mips/cavium-octeon/smp.c @@ -345,6 +345,7 @@ void play_dead(void) int cpu = cpu_number_map(cvmx_get_core_num()); idle_task_exit(); + cpuhp_ap_report_dead(); octeon_processor_boot = 0xff; per_cpu(cpu_state, cpu) = CPU_DEAD; --- a/arch/mips/include/asm/smp-ops.h +++ b/arch/mips/include/asm/smp-ops.h @@ -33,6 +33,7 @@ struct plat_smp_ops { #ifdef CONFIG_HOTPLUG_CPU int (*cpu_disable)(void); void (*cpu_die)(unsigned int cpu); + void (*cleanup_dead_cpu)(unsigned cpu); #endif #ifdef CONFIG_KEXEC void (*kexec_nonboot_cpu)(void); --- a/arch/mips/kernel/smp-bmips.c +++ b/arch/mips/kernel/smp-bmips.c @@ -392,6 +392,7 @@ static void bmips_cpu_die(unsigned int c void __ref play_dead(void) { idle_task_exit(); + cpuhp_ap_report_dead(); /* flush data cache */ _dma_cache_wback_inv(0, ~0); --- a/arch/mips/kernel/smp-cps.c +++ b/arch/mips/kernel/smp-cps.c @@ -503,8 +503,7 @@ void play_dead(void) } } - /* This CPU has chosen its way out */ - (void)cpu_report_death(); + cpuhp_ap_report_dead(); cps_shutdown_this_cpu(cpu_death); @@ -527,7 +526,9 @@ static void wait_for_sibling_halt(void * } while (!(halted & TCHALT_H)); } -static void cps_cpu_die(unsigned int cpu) +static void cps_cpu_die(unsigned int cpu) { } + +static void cps_cleanup_dead_cpu(unsigned cpu) { unsigned core = cpu_core(&cpu_data[cpu]); unsigned int vpe_id = cpu_vpe_id(&cpu_data[cpu]); @@ -535,12 +536,6 @@ static void cps_cpu_die(unsigned int cpu unsigned stat; int err; - /* Wait for the cpu to choose its way out */ - if (!cpu_wait_death(cpu, 5)) { - pr_err("CPU%u: didn't offline\n", cpu); - return; - } - /* * Now wait for the CPU to actually offline. Without doing this that * offlining may race with one or more of: @@ -624,6 +619,7 @@ static const struct plat_smp_ops cps_smp #ifdef CONFIG_HOTPLUG_CPU .cpu_disable = cps_cpu_disable, .cpu_die = cps_cpu_die, + .cleanup_dead_cpu = cps_cleanup_dead_cpu, #endif #ifdef CONFIG_KEXEC .kexec_nonboot_cpu = cps_kexec_nonboot_cpu, --- a/arch/mips/kernel/smp.c +++ b/arch/mips/kernel/smp.c @@ -690,6 +690,14 @@ void flush_tlb_one(unsigned long vaddr) EXPORT_SYMBOL(flush_tlb_page); EXPORT_SYMBOL(flush_tlb_one); +#ifdef CONFIG_HOTPLUG_CPU +void arch_cpuhp_cleanup_dead_cpu(unsigned int cpu) +{ + if (mp_ops->cleanup_dead_cpu) + mp_ops->cleanup_dead_cpu(cpu); +} +#endif + #ifdef CONFIG_GENERIC_CLOCKEVENTS_BROADCAST static void tick_broadcast_callee(void *info) --- a/arch/mips/loongson64/smp.c +++ b/arch/mips/loongson64/smp.c @@ -775,6 +775,7 @@ void play_dead(void) void (*play_dead_at_ckseg1)(int *); idle_task_exit(); + cpuhp_ap_report_dead(); prid_imp = read_c0_prid() & PRID_IMP_MASK; prid_rev = read_c0_prid() & PRID_REV_MASK; From xen-devel-bounces@lists.xenproject.org Thu May 04 19:09:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:09:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529972.825123 (Exim 4.92) (envelope-from ) id 1pueL0-0002ZF-LW; Thu, 04 May 2023 19:09:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529972.825123; Thu, 04 May 2023 19:09:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueL0-0002Yt-Fp; Thu, 04 May 2023 19:09:58 +0000 Received: by outflank-mailman (input) for mailman id 529972; Thu, 04 May 2023 19:09:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDz-00042j-PH for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:43 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3f704063-eaae-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:02:42 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f704063-eaae-11ed-b226-6b7b168915f2 Message-ID: <20230504185937.806324260@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226962; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=PIHn3pYsUJ8IshGaa3kU/Fr0bIJzVI5udpOrlPrYz+E=; b=QNGmIIt+/To56nrNKLo3wlp/uoA0S+O2aHLtwODYUDkrU8Guyvv03S4Uol8KKlrIgPdDLI qPjhMQNUAIZdRs2om4WUPJMT1jXnWhngn8GF42pSedv+mPXqPDg6dporcNAvFdzUw+egQ+ Vqg53SlSVRiuRBZMIzV5FPs2l5GIv84C01a0Qxu+Mq65QbnphJFA5Ir3subA78ZM6E8kf2 ZWThMRZ9iqmdUJfsdKFtkK4qDI92/cMPImPqXf9PZUVb/qwqechT+XgrR1ZcB+r0K7YQf/ HeZhI+W/xkNZVJpDF4ppx/B//2tg7mVNz3rodO8pj9sfyrrX+kNXbJXXhJW8oA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226962; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=PIHn3pYsUJ8IshGaa3kU/Fr0bIJzVI5udpOrlPrYz+E=; b=wXxqyLYYRXuQOss/+ZoLBYE+oLaf2tb90zR4AxAwAajqpA22CmYoLXhycZjVGB2N2Jkdnq PQRh0paL0Sj8j3Bw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch V2 27/38] cpu/hotplug: Remove unused state functions References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:42 +0200 (CEST) From: Thomas Gleixner All users converted to the hotplug core mechanism. Signed-off-by: Thomas Gleixner --- include/linux/cpu.h | 2 - kernel/smpboot.c | 75 ---------------------------------------------------- 2 files changed, 77 deletions(-) --- --- a/include/linux/cpu.h +++ b/include/linux/cpu.h @@ -193,8 +193,6 @@ static inline void play_idle(unsigned lo } #ifdef CONFIG_HOTPLUG_CPU -bool cpu_wait_death(unsigned int cpu, int seconds); -bool cpu_report_death(void); void cpuhp_report_idle_dead(void); #else static inline void cpuhp_report_idle_dead(void) { } --- a/kernel/smpboot.c +++ b/kernel/smpboot.c @@ -325,78 +325,3 @@ void smpboot_unregister_percpu_thread(st cpus_read_unlock(); } EXPORT_SYMBOL_GPL(smpboot_unregister_percpu_thread); - -#ifndef CONFIG_HOTPLUG_CORE_SYNC -static DEFINE_PER_CPU(atomic_t, cpu_hotplug_state) = ATOMIC_INIT(CPU_POST_DEAD); - -#ifdef CONFIG_HOTPLUG_CPU -/* - * Wait for the specified CPU to exit the idle loop and die. - */ -bool cpu_wait_death(unsigned int cpu, int seconds) -{ - int jf_left = seconds * HZ; - int oldstate; - bool ret = true; - int sleep_jf = 1; - - might_sleep(); - - /* The outgoing CPU will normally get done quite quickly. */ - if (atomic_read(&per_cpu(cpu_hotplug_state, cpu)) == CPU_DEAD) - goto update_state_early; - udelay(5); - - /* But if the outgoing CPU dawdles, wait increasingly long times. */ - while (atomic_read(&per_cpu(cpu_hotplug_state, cpu)) != CPU_DEAD) { - schedule_timeout_uninterruptible(sleep_jf); - jf_left -= sleep_jf; - if (jf_left <= 0) - break; - sleep_jf = DIV_ROUND_UP(sleep_jf * 11, 10); - } -update_state_early: - oldstate = atomic_read(&per_cpu(cpu_hotplug_state, cpu)); -update_state: - if (oldstate == CPU_DEAD) { - /* Outgoing CPU died normally, update state. */ - smp_mb(); /* atomic_read() before update. */ - atomic_set(&per_cpu(cpu_hotplug_state, cpu), CPU_POST_DEAD); - } else { - /* Outgoing CPU still hasn't died, set state accordingly. */ - if (!atomic_try_cmpxchg(&per_cpu(cpu_hotplug_state, cpu), - &oldstate, CPU_BROKEN)) - goto update_state; - ret = false; - } - return ret; -} - -/* - * Called by the outgoing CPU to report its successful death. Return - * false if this report follows the surviving CPU's timing out. - * - * A separate "CPU_DEAD_FROZEN" is used when the surviving CPU - * timed out. This approach allows architectures to omit calls to - * cpu_check_up_prepare() and cpu_set_state_online() without defeating - * the next cpu_wait_death()'s polling loop. - */ -bool cpu_report_death(void) -{ - int oldstate; - int newstate; - int cpu = smp_processor_id(); - - oldstate = atomic_read(&per_cpu(cpu_hotplug_state, cpu)); - do { - if (oldstate != CPU_BROKEN) - newstate = CPU_DEAD; - else - newstate = CPU_DEAD_FROZEN; - } while (!atomic_try_cmpxchg(&per_cpu(cpu_hotplug_state, cpu), - &oldstate, newstate)); - return newstate == CPU_DEAD; -} - -#endif /* #ifdef CONFIG_HOTPLUG_CPU */ -#endif /* !CONFIG_HOTPLUG_CORE_SYNC */ From xen-devel-bounces@lists.xenproject.org Thu May 04 19:09:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:09:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529973.825129 (Exim 4.92) (envelope-from ) id 1pueL1-0002en-8w; Thu, 04 May 2023 19:09:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529973.825129; Thu, 04 May 2023 19:09:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueL0-0002dv-Va; Thu, 04 May 2023 19:09:58 +0000 Received: by outflank-mailman (input) for mailman id 529973; Thu, 04 May 2023 19:09:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueE5-00042k-Cm for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:49 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 425723d3-eaae-11ed-8611-37d641c3527e; Thu, 04 May 2023 21:02:47 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 425723d3-eaae-11ed-8611-37d641c3527e Message-ID: <20230504185937.966056940@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=OPmaW7DXf6JnyvIw0i7yNDoe4KbapH95hpIdiwQiys8=; b=OHQM462Vlb4JUW68TEIl6fNm2wkG4SDJ/WmVKvLWMnKsvspXVogdjc2LngewLspjgzA1Jq L9eSuPiamrsyKrs8ZIYXvKQpCwzQsD/75Jm/wrxCCu2OxmCX8aK3ZbXJ/x2bOGmRyErPSO atYwr+JfOvoX9acRV+IiSIOe7gwgCiejv0oRBsUcMHNCvvplg663yGDlt+xcKaV0X1m/XU a5X+xuwQ5SZKVhitdTR8euHAFdO4DSjfLUG5pj4Ay6ZQljwWh0/Wr2g/g1eJ5tOUZnZOcZ KSbTJC0Z3mA9V2DpMSFA7mFMz/TZyEqm0eNXH2mOdMyg3lCXhJt8qaKcz/vc6A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=OPmaW7DXf6JnyvIw0i7yNDoe4KbapH95hpIdiwQiys8=; b=2pZygmqrbSKaKtOa6782fVVLu32t0VpQpHaUmZC3Qqmhzk/7sEVd08EWFmIUQoV6w+fmeA aSMnAotAR3MHv7AA== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch V2 30/38] x86/smpboot: Enable split CPU startup References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:46 +0200 (CEST) From: Thomas Gleixner The x86 CPU bringup state currently does AP wake-up, wait for AP to respond and then release it for full bringup. It is safe to be split into a wake-up and and a separate wait+release state. Provide the required functions and enable the split CPU bringup, which prepares for parallel bringup, where the bringup of the non-boot CPUs takes two iterations: One to prepare and wake all APs and the second to wait and release them. Depending on timing this can eliminate the wait time completely. Signed-off-by: Thomas Gleixner --- arch/x86/Kconfig | 2 +- arch/x86/include/asm/smp.h | 9 ++------- arch/x86/kernel/smp.c | 2 +- arch/x86/kernel/smpboot.c | 8 ++++---- arch/x86/xen/smp_pv.c | 4 ++-- 5 files changed, 10 insertions(+), 15 deletions(-) --- --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -274,8 +274,8 @@ config X86 select HAVE_UNSTABLE_SCHED_CLOCK select HAVE_USER_RETURN_NOTIFIER select HAVE_GENERIC_VDSO - select HOTPLUG_CORE_SYNC_FULL if SMP select HOTPLUG_SMT if SMP + select HOTPLUG_SPLIT_STARTUP if SMP select IRQ_FORCED_THREADING select NEED_PER_CPU_EMBED_FIRST_CHUNK select NEED_PER_CPU_PAGE_FIRST_CHUNK --- a/arch/x86/include/asm/smp.h +++ b/arch/x86/include/asm/smp.h @@ -40,7 +40,7 @@ struct smp_ops { void (*cleanup_dead_cpu)(unsigned cpu); void (*poll_sync_state)(void); - int (*cpu_up)(unsigned cpu, struct task_struct *tidle); + int (*kick_ap_alive)(unsigned cpu, struct task_struct *tidle); int (*cpu_disable)(void); void (*cpu_die)(unsigned int cpu); void (*play_dead)(void); @@ -80,11 +80,6 @@ static inline void smp_cpus_done(unsigne smp_ops.smp_cpus_done(max_cpus); } -static inline int __cpu_up(unsigned int cpu, struct task_struct *tidle) -{ - return smp_ops.cpu_up(cpu, tidle); -} - static inline int __cpu_disable(void) { return smp_ops.cpu_disable(); @@ -124,7 +119,7 @@ void native_smp_prepare_cpus(unsigned in void calculate_max_logical_packages(void); void native_smp_cpus_done(unsigned int max_cpus); int common_cpu_up(unsigned int cpunum, struct task_struct *tidle); -int native_cpu_up(unsigned int cpunum, struct task_struct *tidle); +int native_kick_ap(unsigned int cpu, struct task_struct *tidle); int native_cpu_disable(void); void __noreturn hlt_play_dead(void); void native_play_dead(void); --- a/arch/x86/kernel/smp.c +++ b/arch/x86/kernel/smp.c @@ -268,7 +268,7 @@ struct smp_ops smp_ops = { #endif .smp_send_reschedule = native_smp_send_reschedule, - .cpu_up = native_cpu_up, + .kick_ap_alive = native_kick_ap, .cpu_disable = native_cpu_disable, .play_dead = native_play_dead, --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -1058,7 +1058,7 @@ static int do_boot_cpu(int apicid, int c return ret; } -static int native_kick_ap(unsigned int cpu, struct task_struct *tidle) +int native_kick_ap(unsigned int cpu, struct task_struct *tidle) { int apicid = apic->cpu_present_to_apicid(cpu); int err; @@ -1094,15 +1094,15 @@ static int native_kick_ap(unsigned int c return err; } -int native_cpu_up(unsigned int cpu, struct task_struct *tidle) +int arch_cpuhp_kick_ap_alive(unsigned int cpu, struct task_struct *tidle) { - return native_kick_ap(cpu, tidle); + return smp_ops.kick_ap_alive(cpu, tidle); } void arch_cpuhp_cleanup_kick_cpu(unsigned int cpu) { /* Cleanup possible dangling ends... */ - if (smp_ops.cpu_up == native_cpu_up && x86_platform.legacy.warm_reset) + if (smp_ops.kick_ap_alive == native_kick_ap && x86_platform.legacy.warm_reset) smpboot_restore_warm_reset_vector(); } --- a/arch/x86/xen/smp_pv.c +++ b/arch/x86/xen/smp_pv.c @@ -314,7 +314,7 @@ cpu_initialize_context(unsigned int cpu, return 0; } -static int xen_pv_cpu_up(unsigned int cpu, struct task_struct *idle) +static int xen_pv_kick_ap(unsigned int cpu, struct task_struct *idle) { int rc; @@ -438,7 +438,7 @@ static const struct smp_ops xen_smp_ops .smp_prepare_cpus = xen_pv_smp_prepare_cpus, .smp_cpus_done = xen_smp_cpus_done, - .cpu_up = xen_pv_cpu_up, + .kick_ap_alive = xen_pv_kick_ap, .cpu_die = xen_pv_cpu_die, .cleanup_dead_cpu = xen_pv_cleanup_dead_cpu, .poll_sync_state = xen_pv_poll_sync_state, From xen-devel-bounces@lists.xenproject.org Thu May 04 19:10:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:10:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529974.825135 (Exim 4.92) (envelope-from ) id 1pueL1-0002oW-Ub; Thu, 04 May 2023 19:09:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529974.825135; Thu, 04 May 2023 19:09:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueL1-0002ml-JA; Thu, 04 May 2023 19:09:59 +0000 Received: by outflank-mailman (input) for mailman id 529974; Thu, 04 May 2023 19:09:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueEE-00042j-Av for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:58 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4844a154-eaae-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:02:57 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4844a154-eaae-11ed-b226-6b7b168915f2 Message-ID: <20230504185938.285676159@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226977; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=PV6WWoQh1vSNv/X00PyVAYzPvMrMTPPv2Nyz2I8t2to=; b=ngwo/uGwLLzUyff7hlx9g/RxH5SaJg/lwXSYHXpqdS6uHQZR+3fUUQfO5oVYKvfxde06o+ +RefzZ3wy9tsLi/Hy8zZ6JDATGhXPUq/QZGaWvxRx4XQWUnhfUzD50bvR2y7xGwKDKLwGm X2C2HqxX/WfTRVLQ/0g6RaEnIOW09xcuy0eKhcHRqbtoKQXKdt82wFhNqtvbm9wFJV5YkB OALYtVjQEZsIWpsJDbJIBCW6VkLxJKc0h6Dc19Ep7b3dc7MH5JO49SLLpNpVovgHkV/qQu V+Pl5jVc8Rxfg5JATIDLK+m3hZbXbKpQITDQu4OVIIYiQysd2QZB5OGLMeokNg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226977; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=PV6WWoQh1vSNv/X00PyVAYzPvMrMTPPv2Nyz2I8t2to=; b=JP8BLAG9V88lZ5GHmeL8/xfbmLZJ07n8AFIskCcZbg4rYh3fxmVO9mzY0ohdj0bEvJKj2e XTgJfhIo5hUgrgBA== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" , David Woodhouse Subject: [patch V2 36/38] x86/smpboot: Implement a bit spinlock to protect the realmode stack References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:56 +0200 (CEST) From: Thomas Gleixner Parallel AP bringup requires that the APs can run fully parallel through the early startup code including the real mode trampoline. To prepare for this implement a bit-spinlock to serialize access to the real mode stack so that parallel upcoming APs are not going to corrupt each others stack while going through the real mode startup code. Co-developed-by: David Woodhouse Signed-off-by: David Woodhouse Signed-off-by: Thomas Gleixner --- arch/x86/include/asm/realmode.h | 3 +++ arch/x86/kernel/head_64.S | 13 +++++++++++++ arch/x86/realmode/init.c | 3 +++ arch/x86/realmode/rm/trampoline_64.S | 27 ++++++++++++++++++++++----- 4 files changed, 41 insertions(+), 5 deletions(-) --- --- a/arch/x86/include/asm/realmode.h +++ b/arch/x86/include/asm/realmode.h @@ -52,6 +52,7 @@ struct trampoline_header { u64 efer; u32 cr4; u32 flags; + u32 lock; #endif }; @@ -64,6 +65,8 @@ extern unsigned long initial_stack; extern unsigned long initial_vc_handler; #endif +extern u32 *trampoline_lock; + extern unsigned char real_mode_blob[]; extern unsigned char real_mode_relocs[]; --- a/arch/x86/kernel/head_64.S +++ b/arch/x86/kernel/head_64.S @@ -252,6 +252,17 @@ SYM_INNER_LABEL(secondary_startup_64_no_ movq TASK_threadsp(%rax), %rsp /* + * Now that this CPU is running on its own stack, drop the realmode + * protection. For the boot CPU the pointer is NULL! + */ + movq trampoline_lock(%rip), %rax + testq %rax, %rax + jz .Lsetup_gdt + lock + btrl $0, (%rax) + +.Lsetup_gdt: + /* * We must switch to a new descriptor in kernel space for the GDT * because soon the kernel won't have access anymore to the userspace * addresses where we're currently running on. We have to do that here @@ -433,6 +444,8 @@ SYM_DATA(initial_code, .quad x86_64_star #ifdef CONFIG_AMD_MEM_ENCRYPT SYM_DATA(initial_vc_handler, .quad handle_vc_boot_ghcb) #endif + +SYM_DATA(trampoline_lock, .quad 0); __FINITDATA __INIT --- a/arch/x86/realmode/init.c +++ b/arch/x86/realmode/init.c @@ -154,6 +154,9 @@ static void __init setup_real_mode(void) trampoline_header->flags = 0; + trampoline_lock = &trampoline_header->lock; + *trampoline_lock = 0; + trampoline_pgd = (u64 *) __va(real_mode_header->trampoline_pgd); /* Map the real mode stub as virtual == physical */ --- a/arch/x86/realmode/rm/trampoline_64.S +++ b/arch/x86/realmode/rm/trampoline_64.S @@ -37,6 +37,24 @@ .text .code16 +.macro LOAD_REALMODE_ESP + /* + * Make sure only one CPU fiddles with the realmode stack + */ +.Llock_rm\@: + btl $0, tr_lock + jnc 2f + pause + jmp .Llock_rm\@ +2: + lock + btsl $0, tr_lock + jc .Llock_rm\@ + + # Setup stack + movl $rm_stack_end, %esp +.endm + .balign PAGE_SIZE SYM_CODE_START(trampoline_start) cli # We should be safe anyway @@ -49,8 +67,7 @@ SYM_CODE_START(trampoline_start) mov %ax, %es mov %ax, %ss - # Setup stack - movl $rm_stack_end, %esp + LOAD_REALMODE_ESP call verify_cpu # Verify the cpu supports long mode testl %eax, %eax # Check for return code @@ -93,8 +110,7 @@ SYM_CODE_START(sev_es_trampoline_start) mov %ax, %es mov %ax, %ss - # Setup stack - movl $rm_stack_end, %esp + LOAD_REALMODE_ESP jmp .Lswitch_to_protected SYM_CODE_END(sev_es_trampoline_start) @@ -177,7 +193,7 @@ SYM_CODE_START(pa_trampoline_compat) * In compatibility mode. Prep ESP and DX for startup_32, then disable * paging and complete the switch to legacy 32-bit mode. */ - movl $rm_stack_end, %esp + LOAD_REALMODE_ESP movw $__KERNEL_DS, %dx movl $(CR0_STATE & ~X86_CR0_PG), %eax @@ -241,6 +257,7 @@ SYM_DATA_START(trampoline_header) SYM_DATA(tr_efer, .space 8) SYM_DATA(tr_cr4, .space 4) SYM_DATA(tr_flags, .space 4) + SYM_DATA(tr_lock, .space 4) SYM_DATA_END(trampoline_header) #include "trampoline_common.S" From xen-devel-bounces@lists.xenproject.org Thu May 04 19:10:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:10:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529975.825140 (Exim 4.92) (envelope-from ) id 1pueL2-0002yl-Pl; Thu, 04 May 2023 19:10:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529975.825140; Thu, 04 May 2023 19:10:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueL2-0002uE-6o; Thu, 04 May 2023 19:10:00 +0000 Received: by outflank-mailman (input) for mailman id 529975; Thu, 04 May 2023 19:09:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDt-00042k-Hm for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:37 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3aa69c1d-eaae-11ed-8611-37d641c3527e; Thu, 04 May 2023 21:02:34 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3aa69c1d-eaae-11ed-8611-37d641c3527e Message-ID: <20230504185937.531087176@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=Q8MXo4UxfGPWkYiCkH8SfFuLE8nd3MwYFSO4OPkEU0k=; b=bnUOgHwWBE9hQkfsy68hlWixo+U0yYAVZfCfMXKGJisrc20Q1Webu21cChSehhJQaLZl77 aYcKQ8Ytt2r2NeJhvWxidSRTpvTvE+EspS4m5s+LoGulbB1pCU2KCiI4sYoDI+vWCSHJkY pLu+grBlA9n7NODW06zxUNEt82sbImz6W8Kz7FepCq/gr5/IfItCe6Dkdodt5Q+vNIzgkQ Xn7Gz8k6gfZophc27B+l6J4sJeUpLR0bJXlF4TZA5eQidQJCcWgls2wS0/Py/vTS1AsL0f As3W35eXgUx29dMadPvgrCRe8Y9FS7s6QYZrLEoJyk9bohOWQId+pyuCBRum1w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=Q8MXo4UxfGPWkYiCkH8SfFuLE8nd3MwYFSO4OPkEU0k=; b=HogNRfK+WKVbHXq0EreqUC5qHXGSg3L8ztEoy1FUGNc1//IkmnGiuVjwLox91YGFbTshES iAwGBolutbMvD0Cw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch V2 22/38] arm64: smp: Switch to hotplug core state synchronization References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:34 +0200 (CEST) From: Thomas Gleixner Switch to the CPU hotplug core state tracking and synchronization mechanim. No functional change intended. Signed-off-by: Thomas Gleixner Tested-by: Mark Rutland Cc: Catalin Marinas Cc: Will Deacon Cc: linux-arm-kernel@lists.infradead.org --- arch/arm64/Kconfig | 1 + arch/arm64/include/asm/smp.h | 2 +- arch/arm64/kernel/smp.c | 14 +++++--------- 3 files changed, 7 insertions(+), 10 deletions(-) --- --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -222,6 +222,7 @@ config ARM64 select HAVE_KPROBES select HAVE_KRETPROBES select HAVE_GENERIC_VDSO + select HOTPLUG_CORE_SYNC_DEAD if HOTPLUG_CPU select IRQ_DOMAIN select IRQ_FORCED_THREADING select KASAN_VMALLOC if KASAN --- a/arch/arm64/include/asm/smp.h +++ b/arch/arm64/include/asm/smp.h @@ -99,7 +99,7 @@ static inline void arch_send_wakeup_ipi_ extern int __cpu_disable(void); -extern void __cpu_die(unsigned int cpu); +static inline void __cpu_die(unsigned int cpu) { } extern void __noreturn cpu_die(void); extern void __noreturn cpu_die_early(void); --- a/arch/arm64/kernel/smp.c +++ b/arch/arm64/kernel/smp.c @@ -332,17 +332,13 @@ static int op_cpu_kill(unsigned int cpu) } /* - * called on the thread which is asking for a CPU to be shutdown - - * waits until shutdown has completed, or it is timed out. + * Called on the thread which is asking for a CPU to be shutdown after the + * shutdown completed. */ -void __cpu_die(unsigned int cpu) +void arch_cpuhp_cleanup_dead_cpu(unsigned int cpu) { int err; - if (!cpu_wait_death(cpu, 5)) { - pr_crit("CPU%u: cpu didn't die\n", cpu); - return; - } pr_debug("CPU%u: shutdown\n", cpu); /* @@ -369,8 +365,8 @@ void __noreturn cpu_die(void) local_daif_mask(); - /* Tell __cpu_die() that this CPU is now safe to dispose of */ - (void)cpu_report_death(); + /* Tell cpuhp_bp_sync_dead() that this CPU is now safe to dispose of */ + cpuhp_ap_report_dead(); /* * Actually shutdown the CPU. This must never fail. The specific hotplug From xen-devel-bounces@lists.xenproject.org Thu May 04 19:10:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:10:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529978.825162 (Exim 4.92) (envelope-from ) id 1pueL8-0004Mh-6t; Thu, 04 May 2023 19:10:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529978.825162; Thu, 04 May 2023 19:10:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueL7-0004Kt-LI; Thu, 04 May 2023 19:10:05 +0000 Received: by outflank-mailman (input) for mailman id 529978; Thu, 04 May 2023 19:10:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDm-00042j-Bn for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:30 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 36d8d8f1-eaae-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:02:28 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 36d8d8f1-eaae-11ed-b226-6b7b168915f2 Message-ID: <20230504185937.314874897@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=80kCLRDMZbd9+iHbBsmneisFdctM67+RT5wquUUhx5I=; b=GQZls3V5BLNNRryAlLiFemgQiD0SpRgV3iLbWQvRpTmYB/4c20aGsFDBWXI8Uweg/5YWWM 12/ixEeO6WH/mwVBUzGqqUHfcNtCdkryRnIkY5kjUftL+C8Vj5d7X5voyN7S90aO+JUtGa QWqGgNPb9aB4YZ45GmT1B6RFWwT1VUmtodnu+ekNia7eOS//ayShRUnJRaze7yrTE/+nbI YLCwGu7Zqgfoq78Rwwsbz2qQezZsI5V8aOQCZJKpk+4sOYMq3egl0/9DC5HEt0dP2BRrx4 5e3+lx2Ovzoigk9nXaArk+xUOPBPz0jXa4oBuRkcRD2cRp3G5LGH9+UYpvQqzQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=80kCLRDMZbd9+iHbBsmneisFdctM67+RT5wquUUhx5I=; b=sdydGLJIcakndZUdj794su6Aylk7Gsh33YzKsSvlvoJrUbguKLp6hxQFCUOzGunVvVlCBM I+/zQvKwtvWmlkDg== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch V2 18/38] cpu/hotplug: Add CPU state tracking and synchronization References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:27 +0200 (CEST) From: Thomas Gleixner The CPU state tracking and synchronization mechanism in smpboot.c is completely independent of the hotplug code and all logic around it is implemented in architecture specific code. Except for the state reporting of the AP there is absolutely nothing architecture specific and the sychronization and decision functions can be moved into the generic hotplug core code. Provide an integrated variant and add the core synchronization and decision points. This comes in two flavours: 1) DEAD state synchronization Updated by the architecture code once the AP reaches the point where it is ready to be torn down by the control CPU, e.g. by removing power or clocks or tear down via the hypervisor. The control CPU waits for this state to be reached with a timeout. If the state is reached an architecture specific cleanup function is invoked. 2) Full state synchronization This extends #1 with AP alive synchronization. This is new functionality, which allows to replace architecture specific wait mechanims, e.g. cpumasks, completely. It also prevents that an AP which is in a limbo state can be brought up again. This can happen when an AP failed to report dead state during a previous off-line operation. The dead synchronization is what most architectures use. Only x86 makes a bringup decision based on that state at the moment. Signed-off-by: Thomas Gleixner --- arch/Kconfig | 15 +++ include/linux/cpuhotplug.h | 12 ++ kernel/cpu.c | 193 ++++++++++++++++++++++++++++++++++++++++++++- kernel/smpboot.c | 2 4 files changed, 221 insertions(+), 1 deletion(-) --- --- a/arch/Kconfig +++ b/arch/Kconfig @@ -34,6 +34,21 @@ config ARCH_HAS_SUBPAGE_FAULTS config HOTPLUG_SMT bool +# Selected by HOTPLUG_CORE_SYNC_DEAD or HOTPLUG_CORE_SYNC_FULL +config HOTPLUG_CORE_SYNC + bool + +# Basic CPU dead synchronization selected by architecture +config HOTPLUG_CORE_SYNC_DEAD + bool + select HOTPLUG_CORE_SYNC + +# Full CPU synchronization with alive state selected by architecture +config HOTPLUG_CORE_SYNC_FULL + bool + select HOTPLUG_CORE_SYNC_DEAD if HOTPLUG_CPU + select HOTPLUG_CORE_SYNC + config GENERIC_ENTRY bool --- a/include/linux/cpuhotplug.h +++ b/include/linux/cpuhotplug.h @@ -517,4 +517,16 @@ void cpuhp_online_idle(enum cpuhp_state static inline void cpuhp_online_idle(enum cpuhp_state state) { } #endif +void cpuhp_ap_sync_alive(void); +void arch_cpuhp_sync_state_poll(void); +void arch_cpuhp_cleanup_kick_cpu(unsigned int cpu); + +#ifdef CONFIG_HOTPLUG_CORE_SYNC_DEAD +void cpuhp_ap_report_dead(void); +void arch_cpuhp_cleanup_dead_cpu(unsigned int cpu); +#else +static inline void cpuhp_ap_report_dead(void) { } +static inline void arch_cpuhp_cleanup_dead_cpu(unsigned int cpu) { } +#endif + #endif --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include #include @@ -59,6 +60,7 @@ * @last: For multi-instance rollback, remember how far we got * @cb_state: The state for a single callback (install/uninstall) * @result: Result of the operation + * @ap_sync_state: State for AP synchronization * @done_up: Signal completion to the issuer of the task for cpu-up * @done_down: Signal completion to the issuer of the task for cpu-down */ @@ -76,6 +78,7 @@ struct cpuhp_cpu_state { struct hlist_node *last; enum cpuhp_state cb_state; int result; + atomic_t ap_sync_state; struct completion done_up; struct completion done_down; #endif @@ -276,6 +279,182 @@ static bool cpuhp_is_atomic_state(enum c return CPUHP_AP_IDLE_DEAD <= state && state < CPUHP_AP_ONLINE; } +/* Synchronization state management */ +enum cpuhp_sync_state { + SYNC_STATE_DEAD, + SYNC_STATE_KICKED, + SYNC_STATE_SHOULD_DIE, + SYNC_STATE_ALIVE, + SYNC_STATE_SHOULD_ONLINE, + SYNC_STATE_ONLINE, +}; + +#ifdef CONFIG_HOTPLUG_CORE_SYNC +/** + * cpuhp_ap_update_sync_state - Update synchronization state during bringup/teardown + * @state: The synchronization state to set + * + * No synchronization point. Just update of the synchronization state. + */ +static inline void cpuhp_ap_update_sync_state(enum cpuhp_sync_state state) +{ + atomic_t *st = this_cpu_ptr(&cpuhp_state.ap_sync_state); + int sync = atomic_read(st); + + while (!atomic_try_cmpxchg(st, &sync, state)); +} + +void __weak arch_cpuhp_sync_state_poll(void) { cpu_relax(); } + +static bool cpuhp_wait_for_sync_state(unsigned int cpu, enum cpuhp_sync_state state, + enum cpuhp_sync_state next_state) +{ + atomic_t *st = per_cpu_ptr(&cpuhp_state.ap_sync_state, cpu); + ktime_t now, end, start = ktime_get(); + int sync; + + end = start + 10ULL * NSEC_PER_SEC; + + sync = atomic_read(st); + while (1) { + if (sync == state) { + if (!atomic_try_cmpxchg(st, &sync, next_state)) + continue; + return true; + } + + now = ktime_get(); + if (now > end) { + /* Timeout. Leave the state unchanged */ + return false; + } else if (now - start < NSEC_PER_MSEC) { + /* Poll for one millisecond */ + arch_cpuhp_sync_state_poll(); + } else { + usleep_range_state(USEC_PER_MSEC, 2 * USEC_PER_MSEC, TASK_UNINTERRUPTIBLE); + } + sync = atomic_read(st); + } + return true; +} +#else /* CONFIG_HOTPLUG_CORE_SYNC */ +static inline void cpuhp_ap_update_sync_state(enum cpuhp_sync_state state) { } +#endif /* !CONFIG_HOTPLUG_CORE_SYNC */ + +#ifdef CONFIG_HOTPLUG_CORE_SYNC_DEAD +/** + * cpuhp_ap_report_dead - Update synchronization state to DEAD + * + * No synchronization point. Just update of the synchronization state. + */ +void cpuhp_ap_report_dead(void) +{ + cpuhp_ap_update_sync_state(SYNC_STATE_DEAD); +} + +void __weak arch_cpuhp_cleanup_dead_cpu(unsigned int cpu) { } + +/* + * Late CPU shutdown synchronization point. Cannot use cpuhp_state::done_down + * because the AP cannot issue complete() at this stage. + */ +static void cpuhp_bp_sync_dead(unsigned int cpu) +{ + atomic_t *st = per_cpu_ptr(&cpuhp_state.ap_sync_state, cpu); + int sync = atomic_read(st); + + do { + /* CPU can have reported dead already. Don't overwrite that! */ + if (sync == SYNC_STATE_DEAD) + break; + } while (!atomic_try_cmpxchg(st, &sync, SYNC_STATE_SHOULD_DIE)); + + if (cpuhp_wait_for_sync_state(cpu, SYNC_STATE_DEAD, SYNC_STATE_DEAD)) { + /* CPU reached dead state. Invoke the cleanup function */ + arch_cpuhp_cleanup_dead_cpu(cpu); + return; + } + + /* No further action possible. Emit message and give up. */ + pr_err("CPU%u failed to report dead state\n", cpu); +} +#else /* CONFIG_HOTPLUG_CORE_SYNC_DEAD */ +static inline void cpuhp_bp_sync_dead(unsigned int cpu) { } +#endif /* !CONFIG_HOTPLUG_CORE_SYNC_DEAD */ + +#ifdef CONFIG_HOTPLUG_CORE_SYNC_FULL +/** + * cpuhp_ap_sync_alive - Synchronize AP with the control CPU once it is alive + * + * Updates the AP synchronization state to SYNC_STATE_ALIVE and waits + * for the BP to release it. + */ +void cpuhp_ap_sync_alive(void) +{ + atomic_t *st = this_cpu_ptr(&cpuhp_state.ap_sync_state); + + cpuhp_ap_update_sync_state(SYNC_STATE_ALIVE); + + /* Wait for the control CPU to release it. */ + while (atomic_read(st) != SYNC_STATE_SHOULD_ONLINE) + cpu_relax(); +} + +static bool cpuhp_can_boot_ap(unsigned int cpu) +{ + atomic_t *st = per_cpu_ptr(&cpuhp_state.ap_sync_state, cpu); + int sync = atomic_read(st); + +again: + switch (sync) { + case SYNC_STATE_DEAD: + /* CPU is properly dead */ + break; + case SYNC_STATE_KICKED: + /* CPU did not come up in previous attempt */ + break; + case SYNC_STATE_ALIVE: + /* CPU is stuck cpuhp_ap_sync_alive(). */ + break; + default: + /* CPU failed to report online or dead and is in limbo state. */ + return false; + } + + /* Prepare for booting */ + if (!atomic_try_cmpxchg(st, &sync, SYNC_STATE_KICKED)) + goto again; + + return true; +} + +void __weak arch_cpuhp_cleanup_kick_cpu(unsigned int cpu) { } + +/* + * Early CPU bringup synchronization point. Cannot use cpuhp_state::done_up + * because the AP cannot issue complete() so early in the bringup. + */ +static int cpuhp_bp_sync_alive(unsigned int cpu) +{ + int ret = 0; + + if (!IS_ENABLED(CONFIG_HOTPLUG_CORE_SYNC_FULL)) + return 0; + + if (!cpuhp_wait_for_sync_state(cpu, SYNC_STATE_ALIVE, SYNC_STATE_SHOULD_ONLINE)) { + pr_err("CPU%u failed to report alive state\n", cpu); + ret = -EIO; + } + + /* Let the architecture cleanup the kick alive mechanics. */ + arch_cpuhp_cleanup_kick_cpu(cpu); + return ret; +} +#else /* CONFIG_HOTPLUG_CORE_SYNC_FULL */ +static inline int cpuhp_bp_sync_alive(unsigned int cpu) { return 0; } +static inline bool cpuhp_can_boot_ap(unsigned int cpu) { return true; } +#endif /* !CONFIG_HOTPLUG_CORE_SYNC_FULL */ + /* Serializes the updates to cpu_online_mask, cpu_present_mask */ static DEFINE_MUTEX(cpu_add_remove_lock); bool cpuhp_tasks_frozen; @@ -588,6 +767,9 @@ static int bringup_cpu(unsigned int cpu) struct task_struct *idle = idle_thread_get(cpu); int ret; + if (!cpuhp_can_boot_ap(cpu)) + return -EAGAIN; + /* * Reset stale stack state from the last time this CPU was online. */ @@ -606,6 +788,10 @@ static int bringup_cpu(unsigned int cpu) if (ret) goto out_unlock; + ret = cpuhp_bp_sync_alive(cpu); + if (ret) + goto out_unlock; + ret = bringup_wait_for_ap_online(cpu); if (ret) goto out_unlock; @@ -1109,6 +1295,8 @@ static int takedown_cpu(unsigned int cpu /* This actually kills the CPU. */ __cpu_die(cpu); + cpuhp_bp_sync_dead(cpu); + tick_cleanup_dead_cpu(cpu); rcutree_migrate_callbacks(cpu); return 0; @@ -1355,8 +1543,10 @@ void cpuhp_online_idle(enum cpuhp_state if (state != CPUHP_AP_ONLINE_IDLE) return; + cpuhp_ap_update_sync_state(SYNC_STATE_ONLINE); + /* - * Unpart the stopper thread before we start the idle loop (and start + * Unpark the stopper thread before we start the idle loop (and start * scheduling); this ensures the stopper task is always available. */ stop_machine_unpark(smp_processor_id()); @@ -2733,6 +2923,7 @@ void __init boot_cpu_hotplug_init(void) { #ifdef CONFIG_SMP cpumask_set_cpu(smp_processor_id(), &cpus_booted_once_mask); + atomic_set(this_cpu_ptr(&cpuhp_state.ap_sync_state), SYNC_STATE_ONLINE); #endif this_cpu_write(cpuhp_state.state, CPUHP_ONLINE); this_cpu_write(cpuhp_state.target, CPUHP_ONLINE); --- a/kernel/smpboot.c +++ b/kernel/smpboot.c @@ -326,6 +326,7 @@ void smpboot_unregister_percpu_thread(st } EXPORT_SYMBOL_GPL(smpboot_unregister_percpu_thread); +#ifndef CONFIG_HOTPLUG_CORE_SYNC static DEFINE_PER_CPU(atomic_t, cpu_hotplug_state) = ATOMIC_INIT(CPU_POST_DEAD); /* @@ -488,3 +489,4 @@ bool cpu_report_death(void) } #endif /* #ifdef CONFIG_HOTPLUG_CPU */ +#endif /* !CONFIG_HOTPLUG_CORE_SYNC */ From xen-devel-bounces@lists.xenproject.org Thu May 04 19:10:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:10:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529979.825169 (Exim 4.92) (envelope-from ) id 1pueL9-0004lj-NB; Thu, 04 May 2023 19:10:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529979.825169; Thu, 04 May 2023 19:10:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueL9-0004kI-9A; Thu, 04 May 2023 19:10:07 +0000 Received: by outflank-mailman (input) for mailman id 529979; Thu, 04 May 2023 19:10:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDo-00042j-CQ for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:32 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 38bfb97d-eaae-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:02:31 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 38bfb97d-eaae-11ed-b226-6b7b168915f2 Message-ID: <20230504185937.423370586@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226951; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=axTWYuKGRsLuY3sP+yWW8AcC0JvmEXRH4k+OCDSDm2U=; b=JAJHUpAZ99ml9kYEJFLumTtqdUWusgMhRKrkATvPmN/E+Np81ottt9W5maLBM9NBIbWnTJ ySXLTT+Kor4hdXfzIlODt/giO0VNStwSizmA019ybO7WFnSPuKbPIPcG3oj4yklxtxS7aU n5N8P25WOp3c7sKTlX7jtclRMC9dib+OWP5+g0u3XA7xjm7H0BSCVrqlJV/pGkhcRHSFVC ZhGGbdg5oKi9BMbxdVDZ/bAYmjvP7467rF6XY91JkA52gVUbdvWtKdomwEUWHzXE5dZyQO 7dxtw3w6CHviPJabbTdmg6NJJm327vynExXUs6x1WAljoJBJhWhlKD3vNmVT4w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226951; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=axTWYuKGRsLuY3sP+yWW8AcC0JvmEXRH4k+OCDSDm2U=; b=AkOrbIV4f+h48OPko5LlDDOWxYQnlMZwftJ+TMWfHtwe4frm64xHt5Hf1EzpPa/P2tJZ7D 0WESNcwn3qKK6QDA== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch V2 20/38] cpu/hotplug: Remove cpu_report_state() and related unused cruft References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:30 +0200 (CEST) From: Thomas Gleixner No more users. Signed-off-by: Thomas Gleixner --- include/linux/cpu.h | 2 - kernel/smpboot.c | 90 ---------------------------------------------------- 2 files changed, 92 deletions(-) --- --- a/include/linux/cpu.h +++ b/include/linux/cpu.h @@ -184,8 +184,6 @@ void arch_cpu_idle_enter(void); void arch_cpu_idle_exit(void); void __noreturn arch_cpu_idle_dead(void); -int cpu_report_state(int cpu); -int cpu_check_up_prepare(int cpu); void cpu_set_state_online(int cpu); void play_idle_precise(u64 duration_ns, u64 latency_ns); --- a/kernel/smpboot.c +++ b/kernel/smpboot.c @@ -329,97 +329,7 @@ EXPORT_SYMBOL_GPL(smpboot_unregister_per #ifndef CONFIG_HOTPLUG_CORE_SYNC static DEFINE_PER_CPU(atomic_t, cpu_hotplug_state) = ATOMIC_INIT(CPU_POST_DEAD); -/* - * Called to poll specified CPU's state, for example, when waiting for - * a CPU to come online. - */ -int cpu_report_state(int cpu) -{ - return atomic_read(&per_cpu(cpu_hotplug_state, cpu)); -} - -/* - * If CPU has died properly, set its state to CPU_UP_PREPARE and - * return success. Otherwise, return -EBUSY if the CPU died after - * cpu_wait_death() timed out. And yet otherwise again, return -EAGAIN - * if cpu_wait_death() timed out and the CPU still hasn't gotten around - * to dying. In the latter two cases, the CPU might not be set up - * properly, but it is up to the arch-specific code to decide. - * Finally, -EIO indicates an unanticipated problem. - * - * Note that it is permissible to omit this call entirely, as is - * done in architectures that do no CPU-hotplug error checking. - */ -int cpu_check_up_prepare(int cpu) -{ - if (!IS_ENABLED(CONFIG_HOTPLUG_CPU)) { - atomic_set(&per_cpu(cpu_hotplug_state, cpu), CPU_UP_PREPARE); - return 0; - } - - switch (atomic_read(&per_cpu(cpu_hotplug_state, cpu))) { - - case CPU_POST_DEAD: - - /* The CPU died properly, so just start it up again. */ - atomic_set(&per_cpu(cpu_hotplug_state, cpu), CPU_UP_PREPARE); - return 0; - - case CPU_DEAD_FROZEN: - - /* - * Timeout during CPU death, so let caller know. - * The outgoing CPU completed its processing, but after - * cpu_wait_death() timed out and reported the error. The - * caller is free to proceed, in which case the state - * will be reset properly by cpu_set_state_online(). - * Proceeding despite this -EBUSY return makes sense - * for systems where the outgoing CPUs take themselves - * offline, with no post-death manipulation required from - * a surviving CPU. - */ - return -EBUSY; - - case CPU_BROKEN: - - /* - * The most likely reason we got here is that there was - * a timeout during CPU death, and the outgoing CPU never - * did complete its processing. This could happen on - * a virtualized system if the outgoing VCPU gets preempted - * for more than five seconds, and the user attempts to - * immediately online that same CPU. Trying again later - * might return -EBUSY above, hence -EAGAIN. - */ - return -EAGAIN; - - case CPU_UP_PREPARE: - /* - * Timeout while waiting for the CPU to show up. Allow to try - * again later. - */ - return 0; - - default: - - /* Should not happen. Famous last words. */ - return -EIO; - } -} - -/* - * Mark the specified CPU online. - * - * Note that it is permissible to omit this call entirely, as is - * done in architectures that do no CPU-hotplug error checking. - */ -void cpu_set_state_online(int cpu) -{ - (void)atomic_xchg(&per_cpu(cpu_hotplug_state, cpu), CPU_ONLINE); -} - #ifdef CONFIG_HOTPLUG_CPU - /* * Wait for the specified CPU to exit the idle loop and die. */ From xen-devel-bounces@lists.xenproject.org Thu May 04 19:10:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:10:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529980.825174 (Exim 4.92) (envelope-from ) id 1pueLA-0004ue-KA; Thu, 04 May 2023 19:10:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529980.825174; Thu, 04 May 2023 19:10:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueL9-0004sp-UR; Thu, 04 May 2023 19:10:07 +0000 Received: by outflank-mailman (input) for mailman id 529980; Thu, 04 May 2023 19:10:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueEA-00042j-Mk for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:54 +0000 Received: from galois.linutronix.de (galois.linutronix.de [2a0a:51c0:0:12e:550::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 46390635-eaae-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:02:54 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46390635-eaae-11ed-b226-6b7b168915f2 Message-ID: <20230504185938.179661118@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=dh/52GRhLbpp4gh50fAuvfQix7j7Ih1160L/CdLI8l0=; b=O6cG1HBehiX74K9JFp369TIKx6mKBR2TPreNtZ0JIxAQi+1KIShpZOLr9yn98NyJ2DVeV2 KoRI+hkYEu5smHES9pGvnLyoWtwb4Bp/4BfVhvbHAfxZcdiWB7o0B0Ira+4IzxwLMlhRJ+ sMHMr6Be0jbWVJhRKWMRzaormlwxyZ+o2EofkewXORpIgLbjVpvUxjCQcSQl+YfTMlHZ9T UE8rmtHne4Y5TmubM7NIWK98QCHj+0F+rqBtOZSFGM77VBpgrVetzsILoS9DByN2vrAczS 5+Uo3R/A6vnceg12D8eqIMTFGAGJV6sRpxtSZ3hp8//m2IPi36uIIWtNhU3PLg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=dh/52GRhLbpp4gh50fAuvfQix7j7Ih1160L/CdLI8l0=; b=2Mr8xnCCJXQNYK40wYiyDitX1rtgKVSav9FlO5VPGJbI6wVmqI0M9y1M9rUGvQKL9tG1OS lphjzmGYwmWjK5CQ== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch V2 34/38] x86/cpu/amd; Invoke detect_extended_topology_early() on boot CPU References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:53 +0200 (CEST) From: Thomas Gleixner The early detection stores the extended topology leaf number which is required for parallel hotplug. Signed-off-by: Thomas Gleixner --- arch/x86/kernel/cpu/amd.c | 2 ++ 1 file changed, 2 insertions(+) --- --- a/arch/x86/kernel/cpu/amd.c +++ b/arch/x86/kernel/cpu/amd.c @@ -692,6 +692,8 @@ static void early_init_amd(struct cpuinf } } + detect_extended_topology_early(c); + if (cpu_has(c, X86_FEATURE_TOPOEXT)) smp_num_siblings = ((cpuid_ebx(0x8000001e) >> 8) & 0xff) + 1; } From xen-devel-bounces@lists.xenproject.org Thu May 04 19:10:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:10:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.529986.825184 (Exim 4.92) (envelope-from ) id 1pueLC-0005ZB-TJ; Thu, 04 May 2023 19:10:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 529986.825184; Thu, 04 May 2023 19:10:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueLC-0005VT-BD; Thu, 04 May 2023 19:10:10 +0000 Received: by outflank-mailman (input) for mailman id 529986; Thu, 04 May 2023 19:10:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueDv-00042k-Hl for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:02:39 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3b9b06d7-eaae-11ed-8611-37d641c3527e; Thu, 04 May 2023 21:02:36 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b9b06d7-eaae-11ed-8611-37d641c3527e Message-ID: <20230504185937.584277566@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683226956; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=wTNocxrIkrZERW1CgHrOxDfBd1NuTsgJS4AJ8mYPyyQ=; b=Mi46V8eHgoltNQxPJmnbu9i1N0WqNbjlBS5gXzUQdYuzDGSlRAwFIn42Fl4qTDQ9tpMOpi 9pMD9eqFIhnqecwmKQOcPdssVAfxr98Ufnj8kPfEnna6Jg1FJPiFDXjB5qyYPeKOEBzagH d9bGKI26ZnIO1dmzo62pzKDwF621ZdxsTsNqH8faar1/6RQwLMfz9EzVFpDrERESz08UzT RKiX6TWVgbEvDpDMLz5ptMwZldZAxWrvz613h9Whj+rnlmmRseJTa9scp2XVHyZRgXYYx9 W9B8x3jWUGKujnEYbsdrx7KzjQ+swT2YMyT9UZUBAmo9KzwEdkHLM2GZWs0XOQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683226956; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=wTNocxrIkrZERW1CgHrOxDfBd1NuTsgJS4AJ8mYPyyQ=; b=4wN87waBqOWq8wTSM62nHwIaB3nHKF5Odvy83jhqjVG4mxeKOSh6qxwJk2zaru4HlpMduu ieIS3XjNdw5x/MBw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch V2 23/38] csky/smp: Switch to hotplug core state synchronization References: <20230504185733.126511787@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 4 May 2023 21:02:35 +0200 (CEST) From: Thomas Gleixner Switch to the CPU hotplug core state tracking and synchronization mechanim. No functional change intended. Signed-off-by: Thomas Gleixner Cc: Guo Ren Cc: linux-csky@vger.kernel.org --- arch/csky/Kconfig | 1 + arch/csky/include/asm/smp.h | 2 +- arch/csky/kernel/smp.c | 8 ++------ 3 files changed, 4 insertions(+), 7 deletions(-) --- --- a/arch/csky/Kconfig +++ b/arch/csky/Kconfig @@ -96,6 +96,7 @@ config CSKY select HAVE_REGS_AND_STACK_ACCESS_API select HAVE_STACKPROTECTOR select HAVE_SYSCALL_TRACEPOINTS + select HOTPLUG_CORE_SYNC_DEAD if HOTPLUG_CPU select MAY_HAVE_SPARSE_IRQ select MODULES_USE_ELF_RELA if MODULES select OF --- a/arch/csky/include/asm/smp.h +++ b/arch/csky/include/asm/smp.h @@ -23,7 +23,7 @@ void __init set_send_ipi(void (*func)(co int __cpu_disable(void); -void __cpu_die(unsigned int cpu); +static inline void __cpu_die(unsigned int cpu) { } #endif /* CONFIG_SMP */ --- a/arch/csky/kernel/smp.c +++ b/arch/csky/kernel/smp.c @@ -291,12 +291,8 @@ int __cpu_disable(void) return 0; } -void __cpu_die(unsigned int cpu) +void arch_cpuhp_cleanup_dead_cpu(unsigned int cpu) { - if (!cpu_wait_death(cpu, 5)) { - pr_crit("CPU%u: shutdown failed\n", cpu); - return; - } pr_notice("CPU%u: shutdown\n", cpu); } @@ -304,7 +300,7 @@ void __noreturn arch_cpu_idle_dead(void) { idle_task_exit(); - cpu_report_death(); + cpuhp_ap_report_dead(); while (!secondary_stack) arch_cpu_idle(); From xen-devel-bounces@lists.xenproject.org Thu May 04 19:18:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:18:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530007.825203 (Exim 4.92) (envelope-from ) id 1pueT3-0001tY-P3; Thu, 04 May 2023 19:18:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530007.825203; Thu, 04 May 2023 19:18:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueT3-0001tR-MQ; Thu, 04 May 2023 19:18:17 +0000 Received: by outflank-mailman (input) for mailman id 530007; Thu, 04 May 2023 19:18:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueT2-0001tH-LX; Thu, 04 May 2023 19:18:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueT2-0007BZ-Fh; Thu, 04 May 2023 19:18:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueT1-0007TK-Sm; Thu, 04 May 2023 19:18:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pueT1-0006md-SE; Thu, 04 May 2023 19:18:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4Bo4v/HutPsvfpVlgU4XJGi9RIMyQ++bhbTswozKQgg=; b=MhumB86tfghEbqTi1GKUQKA3lc w7wBACp6uvKR7huM/cFha/fklYosTWJurYNR5g6WqGd0b9jcpinzBKjx8Fh6ngUUJxXr2bbixoc// CkaImOGKBbsqgDkwLVIofwt+8TVye4jGkfzmchI8ITzKHtzFfZCYbWHvCiUj+4urhGik=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180528: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=b95a72bb5b2df24ff1baaa27920e57947dc97d49 X-Osstest-Versions-That: xen=b033eddc9779109c06a26936321d27a2ef4e088b From: osstest service owner Date: Thu, 04 May 2023 19:18:15 +0000 flight 180528 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/180528/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180511 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180511 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180511 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180511 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180511 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180511 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 180511 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 180511 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail like 180511 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180511 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 180511 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180511 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180511 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: xen b95a72bb5b2df24ff1baaa27920e57947dc97d49 baseline version: xen b033eddc9779109c06a26936321d27a2ef4e088b Last test of basis 180511 2023-05-03 01:53:22 Z 1 days Failing since 180519 2023-05-03 15:38:32 Z 1 days 2 attempts Testing same since 180528 2023-05-04 08:14:17 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Henry Wang # CHANGELOG Jan Beulich Olaf Hering Roger Pau Monné Sergey Dyasli Viresh Kumar jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git b033eddc97..b95a72bb5b b95a72bb5b2df24ff1baaa27920e57947dc97d49 -> master From xen-devel-bounces@lists.xenproject.org Thu May 04 19:39:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:39:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530039.825266 (Exim 4.92) (envelope-from ) id 1pueng-0006HW-IR; Thu, 04 May 2023 19:39:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530039.825266; Thu, 04 May 2023 19:39:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueng-0006Gh-DF; Thu, 04 May 2023 19:39:36 +0000 Received: by outflank-mailman (input) for mailman id 530039; Thu, 04 May 2023 19:39:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puenf-00069W-P1 for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:39:35 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 650fb147-eab3-11ed-8611-37d641c3527e; Thu, 04 May 2023 21:39:33 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 650fb147-eab3-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683229173; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=8aejV8Ms7L6eLYNlIrFeJCAd+u3GgX1dUF2hUOuDAqc=; b=bMSQa8HD9Y18I4fZhvRN50W3irUMT2e5OkugtiVFEZE4Z08s0osCLB4d HELX/3mbHSlNMjclQvB6gSOsw1BvdnyGtPb1elFhhtfroxLORJgJTpMkt uIhxLmTPrB6IjEYxqmM04ClpxrojiJAjmd5z9xWvixpV09Y1ss8n6ORPB A=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 107797743 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:JkhA6Ki0Gqj2jcP4KvVDUeTmX161ERAKZh0ujC45NGQN5FlHY01je htvWmvUa/uPM2L1e41zYI7go0tSvpPQm9c2SQZvqSBjEigb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWj0N8klgZmP6sT4QeCzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tRCCQ8DUBahqd7mxavnRPBrxeYKC+/CadZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJYw1MYH49tL7Aan3XWjtUsl+K44Ew5HDe1ldZ27nxKtvFPNeNQK25m27B/ j2ZrjumXkpy2Nq31Xmhz2m2xcbzmj7/YqIMF4+p+/pnjwjGroAUIEJPDgbqyRWjsWahX/pPJ kpS/TAhxYAi+UruQtTjUhmQpH+fogVaS9dWC/c96gyG1uzT+QnxLkouQyNFadcmnNQrXjFs3 ViM9+4FHhQ27ufTEyjEsO7J83XrY3N9wXI+iTEsFyo67eflgq8P3hfWEth6F+2Xp/rTMGSlq 9yVlxTSl4n/nOZSifXgpQmd023zznTaZlVrv1uKBwpJ+is8Pdf4PNLwtDA3+N4adO6kok+9U G/ociR0xMQHFtmzmSOEW43h95n5tq/eYFUwbbOCdqTNFghBGFb5J+i8GBkkeC9U3j8sIFcFm nP7twJL/4N0N3C3d6JxaI/ZI510nfO6T4q5D6GMNYUmjn1NSeN61Hs2OR74M57FySDAbp3Ty b/EKJ3xXB72+IxszSasRvd17ILHMhsWnDuJLbiilkTP7FZrTCLNIVvzGAfUP79RAWLtiFm9z uuzwOPQlk4BDbekOXGImWPRRHhTRUUG6VnNg5Q/Xoa+zsBOQgnN19e5LWsdRrFY IronPort-HdrOrdr: A9a23:eEuL2qBISPMCaULlHemW55DYdb4zR+YMi2TC1yhKKCC9Ffbo7/ xG/c5rrCMc5wxhO03I9eruBEDEewK5yXcX2/h2AV7BZniFhILAFugLhuGOrwEIWReOkdK1vZ 0QCJSWY+eRMbEVt6jHCXGDYrMd/OU= X-Talos-CUID: 9a23:ePTaoW5hLF61aKfludssrm8rFP4jUFPhnHLJf0GhDiVLYZqzYArF X-Talos-MUID: 9a23:klefQgWJbJvTq6Xq/COvoAx5LoRB36OzDHotj5Y0qsSAOCMlbg== X-IronPort-AV: E=Sophos;i="5.99,250,1677560400"; d="scan'208";a="107797743" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 2/6] x86/cpuid: Rename NCAPINTS to X86_NR_CAPS Date: Thu, 4 May 2023 20:39:20 +0100 Message-ID: <20230504193924.3305496-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230504193924.3305496-1-andrew.cooper3@citrix.com> References: <20230504193924.3305496-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit The latter is more legible, and consistent with X86_NR_{SYNTH,BUG} which already exist. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/arch/x86/alternative.c | 2 +- xen/arch/x86/cpu/common.c | 12 ++++++------ xen/arch/x86/cpuid.c | 2 +- xen/arch/x86/include/asm/cpufeature.h | 2 +- xen/arch/x86/include/asm/cpufeatures.h | 2 +- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/xen/arch/x86/alternative.c b/xen/arch/x86/alternative.c index 99482766b51f..0434030693a9 100644 --- a/xen/arch/x86/alternative.c +++ b/xen/arch/x86/alternative.c @@ -200,7 +200,7 @@ static void init_or_livepatch _apply_alternatives(struct alt_instr *start, BUG_ON(a->repl_len > total_len); BUG_ON(total_len > sizeof(buf)); - BUG_ON(a->cpuid >= NCAPINTS * 32); + BUG_ON(a->cpuid >= X86_NR_CAPS * 32); /* * Detect sequences of alt_instr's patching the same origin site, and diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c index edc4db1335eb..1be049e332ce 100644 --- a/xen/arch/x86/cpu/common.c +++ b/xen/arch/x86/cpu/common.c @@ -55,8 +55,8 @@ unsigned int paddr_bits __read_mostly = 36; unsigned int hap_paddr_bits __read_mostly = 36; unsigned int vaddr_bits __read_mostly = VADDR_BITS; -static unsigned int cleared_caps[NCAPINTS]; -static unsigned int forced_caps[NCAPINTS]; +static unsigned int cleared_caps[X86_NR_CAPS]; +static unsigned int forced_caps[X86_NR_CAPS]; DEFINE_PER_CPU(bool, full_gdt_loaded); @@ -501,7 +501,7 @@ void identify_cpu(struct cpuinfo_x86 *c) #ifdef NOISY_CAPS printk(KERN_DEBUG "CPU: After vendor identify, caps:"); - for (i = 0; i < NCAPINTS; i++) + for (i = 0; i < X86_NR_CAPS; i++) printk(" %08x", c->x86_capability[i]); printk("\n"); #endif @@ -530,7 +530,7 @@ void identify_cpu(struct cpuinfo_x86 *c) for (i = 0; i < FSCAPINTS; ++i) c->x86_capability[i] &= known_features[i]; - for (i = 0 ; i < NCAPINTS ; ++i) { + for (i = 0 ; i < X86_NR_CAPS ; ++i) { c->x86_capability[i] |= forced_caps[i]; c->x86_capability[i] &= ~cleared_caps[i]; } @@ -548,7 +548,7 @@ void identify_cpu(struct cpuinfo_x86 *c) #ifdef NOISY_CAPS printk(KERN_DEBUG "CPU: After all inits, caps:"); - for (i = 0; i < NCAPINTS; i++) + for (i = 0; i < X86_NR_CAPS; i++) printk(" %08x", c->x86_capability[i]); printk("\n"); #endif @@ -585,7 +585,7 @@ void identify_cpu(struct cpuinfo_x86 *c) */ if ( c != &boot_cpu_data ) { /* AND the already accumulated flags with these */ - for ( i = 0 ; i < NCAPINTS ; i++ ) + for ( i = 0 ; i < X86_NR_CAPS ; i++ ) boot_cpu_data.x86_capability[i] &= c->x86_capability[i]; mcheck_init(c, false); diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c index 455a09b2dd22..fd8021c6f16c 100644 --- a/xen/arch/x86/cpuid.c +++ b/xen/arch/x86/cpuid.c @@ -19,7 +19,7 @@ bool recheck_cpu_features(unsigned int cpu) identify_cpu(&c); - for ( i = 0; i < NCAPINTS; ++i ) + for ( i = 0; i < X86_NR_CAPS; ++i ) { if ( !(~c.x86_capability[i] & bsp->x86_capability[i]) ) continue; diff --git a/xen/arch/x86/include/asm/cpufeature.h b/xen/arch/x86/include/asm/cpufeature.h index 4140ec0938b2..66bd4e296a18 100644 --- a/xen/arch/x86/include/asm/cpufeature.h +++ b/xen/arch/x86/include/asm/cpufeature.h @@ -26,7 +26,7 @@ struct cpuinfo_x86 { unsigned char x86_mask; int cpuid_level; /* Maximum supported CPUID level, -1=no CPUID */ unsigned int extended_cpuid_level; /* Maximum supported CPUID extended level */ - unsigned int x86_capability[NCAPINTS]; + unsigned int x86_capability[X86_NR_CAPS]; char x86_vendor_id[16]; char x86_model_id[64]; unsigned int x86_cache_size; /* in KB - valid only when supported */ diff --git a/xen/arch/x86/include/asm/cpufeatures.h b/xen/arch/x86/include/asm/cpufeatures.h index da0593de8542..e982ee920ce1 100644 --- a/xen/arch/x86/include/asm/cpufeatures.h +++ b/xen/arch/x86/include/asm/cpufeatures.h @@ -53,4 +53,4 @@ XEN_CPUFEATURE(IBPB_ENTRY_HVM, X86_SYNTH(29)) /* MSR_PRED_CMD used by Xen for #define X86_BUG_IBPB_NO_RET X86_BUG( 3) /* IBPB doesn't flush the RSB/RAS */ /* Total number of capability words, inc synth and bug words. */ -#define NCAPINTS (FSCAPINTS + X86_NR_SYNTH + X86_NR_BUG) /* N 32-bit words worth of info */ +#define X86_NR_CAPS (FSCAPINTS + X86_NR_SYNTH + X86_NR_BUG) /* N 32-bit words worth of info */ -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Thu May 04 19:39:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:39:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530040.825273 (Exim 4.92) (envelope-from ) id 1pueng-0006Mu-UU; Thu, 04 May 2023 19:39:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530040.825273; Thu, 04 May 2023 19:39:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueng-0006K7-L0; Thu, 04 May 2023 19:39:36 +0000 Received: by outflank-mailman (input) for mailman id 530040; Thu, 04 May 2023 19:39:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puenf-00069l-T7 for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:39:35 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 65d9d6e2-eab3-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:39:35 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 65d9d6e2-eab3-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683229175; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Jr5O2ho0oh2dy6YyNewvIFzCxvBrXOJlZmgmV269Q/k=; b=bs2AD/Fs7u8FRnFxMUlW3QRP1fUgBjsvmJorU8NJ2LZzdeKpZyrIfaSb rQ2yZAo16A/RlrVY1gQts8UuiF7iGAYzQCItZCYZL0ULaQrhMQKMFzNtb eoYjBsI3CgDXHg1XQhIOH1X6K3KnJgElM2PMXI6s+2SOKNi1vd1xQ4dxF k=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 107931611 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:kJpQzKuPcYcZMGFx809kXMhjeOfnVCdeMUV32f8akzHdYApBsoF/q tZmKTyCa6yKMGX2foh0aY209hkDu5SAxtFrHQVkpHsxHigR+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj6Vv0gnRkPaoQ5AKGyyFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwEz8saE25nNiPkY2FStA3r50DE5HxBdZK0p1g5Wmx4fcORJnCR+PB5MNC3Sd2jcdLdRrcT 5NHM3w1Nk2GOkARfA5NU/rSn8/x7pX7WxRepEiYuuwc5G/LwRYq+LPsLMDUapqBQsA9ckOw/ zqZrj+gXEhDXDCZ4WSP9nzzud3dpwDce4NIN7GX7uYyonTGkwT/DzVJDADm8JFVkHWWRNZ3O 0ESvC00osAa5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWbkAGRDNcbN0ttOctWCcnk FSOmrvU6SdH6ePPDyjHr/HN8G30YHJORYMfWcMaZTAKwt++mpoJt0PwcNZaS4fsruKtAwill lhmsxMCa6UvYd8jjvvrpgie2WLz+fAlXSZuuFyJAzvNAhdRIdf8Otf2sQWzAeNodt7xc7WXg JQTdyFyBsgqBIrFqiGCSf5l8FqBt6fca220bbKC8vAcG9WRF52LJ9o4DMlWfhsBDyr9UWaBj LXvkQ1Q/oRPG3ChcLV6ZYm8Y+xzk/i7T467CqmFNoERCnSUSDJrAQk0PRLAt4wTuBFEfV4D1 WezLp/3UCdy5VVPxzuqXeYNuYIWKtQF7TqLH/jTlk33uYdykVbJEd/pxnPSNLFmhE5FyS2Jm +ti2zyikUgEDrCkOHKPrub+7zkidBAGOHw/kOQPHsbrH+asMDtJ5yP5qV/5R7FYog== IronPort-HdrOrdr: A9a23:dcGjLqjOHA+0jiMQx7THnu5Q8nBQXg4ji2hC6mlwRA09TyX4rb HKoB1/73LJYVkqN03I9ervBED4ewK5yXct2/h3AV7AZniFhILLFu1fBOLZqlWLJ8SZzI9gPM 9bGJSWY+eAbmSS4/yb3OFte+xQueVu78iT9JjjJ2YEd3ANV0l/hz0JcjpzGHcGODWvWPICZe GhDtIunUvbRZwNBv7Le0U4Yw== X-Talos-CUID: 9a23:ujj73W9qBqA70R+GzX2Vv3UbO8Z4SGbn9SbvHU+BUk8waILNU2bFrQ== X-Talos-MUID: =?us-ascii?q?9a23=3AoOu8Lw9dfBjUJW2cTSXRQG6Qf5li56rxN3Ifq7Y?= =?us-ascii?q?hmMjeFiBfIy/Frh3iFw=3D=3D?= X-IronPort-AV: E=Sophos;i="5.99,250,1677560400"; d="scan'208";a="107931611" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 5/6] x86/cpu-policy: Disentangle X86_NR_FEAT and FEATURESET_NR_ENTRIES Date: Thu, 4 May 2023 20:39:23 +0100 Message-ID: <20230504193924.3305496-6-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230504193924.3305496-1-andrew.cooper3@citrix.com> References: <20230504193924.3305496-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit When adding new words to a featureset, there is a reasonable amount of boilerplate and it is preforable to split the addition into multiple patches. GCC 12 spotted a real (transient) error which occurs when splitting additions like this. Right now, FEATURESET_NR_ENTRIES is dynamically generated from the highest numeric XEN_CPUFEATURE() value, and can be less than what the FEATURESET_* constants suggest the length of a featureset bitmap ought to be. This causes the policy <-> featureset converters to genuinely access out-of-bounds on the featureset array. Rework X86_NR_FEAT to be related to FEATURESET_* alone, allowing it specifically to grow larger than FEATURESET_NR_ENTRIES. Reported-by: Jan Beulich Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu To preempt what I expect will be the first review question, no FEATURESET_* can't become an enumeration, because the constants undergo token concatination in the preprocess as part of making DECL_BITFIELD() work. --- xen/arch/x86/cpu-policy.c | 7 +++++++ xen/arch/x86/include/asm/cpufeatures.h | 5 +---- xen/include/xen/lib/x86/cpu-policy.h | 4 ++-- xen/include/xen/lib/x86/cpuid-consts.h | 2 ++ xen/lib/x86/cpuid.c | 6 +++--- 5 files changed, 15 insertions(+), 9 deletions(-) diff --git a/xen/arch/x86/cpu-policy.c b/xen/arch/x86/cpu-policy.c index 774c512a03bd..00416244a3d8 100644 --- a/xen/arch/x86/cpu-policy.c +++ b/xen/arch/x86/cpu-policy.c @@ -883,6 +883,13 @@ void __init init_dom0_cpuid_policy(struct domain *d) static void __init __maybe_unused build_assertions(void) { + /* + * Generally these are the same, but tend to differ when adding new + * infrastructure split across several patches. Simply confirm that the + * gen-cpuid.py X86_FEATURE_* bits fit within the bitmaps we operate on. + */ + BUILD_BUG_ON(FEATURESET_NR_ENTRIES > X86_NR_FEAT); + /* Find some more clever allocation scheme if this trips. */ BUILD_BUG_ON(sizeof(struct cpu_policy) > PAGE_SIZE); diff --git a/xen/arch/x86/include/asm/cpufeatures.h b/xen/arch/x86/include/asm/cpufeatures.h index 408ab4ba16a5..8989291bbfd6 100644 --- a/xen/arch/x86/include/asm/cpufeatures.h +++ b/xen/arch/x86/include/asm/cpufeatures.h @@ -2,10 +2,7 @@ * Explicitly intended for multiple inclusion. */ -#include - -/* Number of capability words covered by the featureset words. */ -#define X86_NR_FEAT FEATURESET_NR_ENTRIES +#include /* Synthetic words follow the featureset words. */ #define X86_NR_SYNTH 1 diff --git a/xen/include/xen/lib/x86/cpu-policy.h b/xen/include/xen/lib/x86/cpu-policy.h index e9bda14a7595..01431de056c8 100644 --- a/xen/include/xen/lib/x86/cpu-policy.h +++ b/xen/include/xen/lib/x86/cpu-policy.h @@ -370,12 +370,12 @@ struct cpu_policy_errors * Copy the featureset words out of a cpu_policy object. */ void x86_cpu_policy_to_featureset(const struct cpu_policy *p, - uint32_t fs[FEATURESET_NR_ENTRIES]); + uint32_t fs[X86_NR_FEAT]); /** * Copy the featureset words back into a cpu_policy object. */ -void x86_cpu_featureset_to_policy(const uint32_t fs[FEATURESET_NR_ENTRIES], +void x86_cpu_featureset_to_policy(const uint32_t fs[X86_NR_FEAT], struct cpu_policy *p); static inline uint64_t cpu_policy_xcr0_max(const struct cpu_policy *p) diff --git a/xen/include/xen/lib/x86/cpuid-consts.h b/xen/include/xen/lib/x86/cpuid-consts.h index 6ca8c39a3df4..9fe931b8e31f 100644 --- a/xen/include/xen/lib/x86/cpuid-consts.h +++ b/xen/include/xen/lib/x86/cpuid-consts.h @@ -21,6 +21,8 @@ #define FEATURESET_7c1 14 /* 0x00000007:1.ecx */ #define FEATURESET_7d1 15 /* 0x00000007:1.edx */ +#define X86_NR_FEAT (FEATURESET_7d1 + 1) + #endif /* !XEN_LIB_X86_CONSTS_H */ /* diff --git a/xen/lib/x86/cpuid.c b/xen/lib/x86/cpuid.c index 68aafb404927..76f26e92af8d 100644 --- a/xen/lib/x86/cpuid.c +++ b/xen/lib/x86/cpuid.c @@ -61,7 +61,7 @@ const char *x86_cpuid_vendor_to_str(unsigned int vendor) } void x86_cpu_policy_to_featureset( - const struct cpu_policy *p, uint32_t fs[FEATURESET_NR_ENTRIES]) + const struct cpu_policy *p, uint32_t fs[X86_NR_FEAT]) { fs[FEATURESET_1d] = p->basic._1d; fs[FEATURESET_1c] = p->basic._1c; @@ -82,7 +82,7 @@ void x86_cpu_policy_to_featureset( } void x86_cpu_featureset_to_policy( - const uint32_t fs[FEATURESET_NR_ENTRIES], struct cpu_policy *p) + const uint32_t fs[X86_NR_FEAT], struct cpu_policy *p) { p->basic._1d = fs[FEATURESET_1d]; p->basic._1c = fs[FEATURESET_1c]; @@ -285,7 +285,7 @@ const uint32_t *x86_cpu_policy_lookup_deep_deps(uint32_t feature) static const uint32_t deep_features[] = INIT_DEEP_FEATURES; static const struct { uint32_t feature; - uint32_t fs[FEATURESET_NR_ENTRIES]; + uint32_t fs[X86_NR_FEAT]; } deep_deps[] = INIT_DEEP_DEPS; unsigned int start = 0, end = ARRAY_SIZE(deep_deps); -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Thu May 04 19:39:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:39:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530041.825297 (Exim 4.92) (envelope-from ) id 1pueni-00075v-I2; Thu, 04 May 2023 19:39:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530041.825297; Thu, 04 May 2023 19:39:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueni-00075k-7a; Thu, 04 May 2023 19:39:38 +0000 Received: by outflank-mailman (input) for mailman id 530041; Thu, 04 May 2023 19:39:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueng-00069W-U1 for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:39:36 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6527462a-eab3-11ed-8611-37d641c3527e; Thu, 04 May 2023 21:39:35 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6527462a-eab3-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683229174; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=zzSgC6HAWJ6nHal+JPSc8THZj+muKjktvIIOzu9Oncs=; b=cF83aT6l8/tYaKNgyls/1FiSDoGc3pHbN7ueZNsHgXjfweStpxpGCjNB 9Grpmg7tQVQrJPgsP20Zp3i3wYVHnpu49BVSF89fePxiD6t0VRn8DbpC+ LltchoHfx0suwzmsR/SCrKDtZCxHRv8PTg2jjU98cfuc3KHEbEA+VZtft 8=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 107797746 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:xtR7A6qaSWy9tRyHh+JDUNRPxhxeBmJpZRIvgKrLsJaIsI4StFCzt garIBmGOPmMM2XyKNhzaYXkpEwE78ODmoRhSFNqrHs3ES1D85uZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WJwUmAWP6gR5weDzyVNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAHMmVTCFi8aX/Orhe7FXjPoxM8XoDrpK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFOUslWcOSA3xETdxVxrl6PqLVxyG/U1AFri5DmMcbPe8zMTsJQ9qqdj jueoDuoXU5GarRzzxKgzkywvu+MwhrbG5xOMLel79JAkly6kzl75Bo+CgLg/KjRZlSFc8JSL QkY9zQjqYA29Ve3VZ/tUhugunmGsxUAHd1KHIUSyiuA167V6AaxHXUfQ3hKb9lOnNAybSwn0 BmOhdyBONB0mOTLEzTHrO7S9G7sf3FPdgfueBPoUyNGyOLDpo0Xry6XFOc7K6SLnML5GgPJl mXiQDcFu1kDsSIa//zlrQuf2mj8+cehoh0dvVuOAD/8hu9tTMv8PtHztwCGhRpVBNzBJmRtq kTojCR3AAomKZiW3BKAT+wWdF1Cz6bUaWaM6bKD8nRIythMx5JAVdoKiN2GDB01WvvogBewC KMphStf5YVIIFyhZrJtboS6BqwClPawTo6/CKyNP4IVPfCdkTO6ENxGPxbMjwgBbmB1+U3AB XtrWZn1VitLYUiW5DG3W/0cwdcW+8zK/kuKHcqT503+gdKjiIu9Fe9t3K2mMrpos8tpYWz9r 75iCid9408CC7OjOHOMqdF7wJJjBSFTOK0aYvd/LoarSjeK0kl7YxMN6dvNo7BYopk= IronPort-HdrOrdr: A9a23:P+/wOKvIVTjVFEL5TrabSDgW7skDTtV00zEX/kB9WHVpmszxra 6TdZMgpGbJYVcqKRcdcL+7WJVoLUmxyXcx2/h1AV7AZniAhILLFvAA0WKK+VSJcEeSygce79 YFT0EXMqyJMbEQt6fHCWeDfOrIuOP3kpyVuQ== X-Talos-CUID: =?us-ascii?q?9a23=3ACHfxhGkBUSk+04PNzU9cOw5MZdHXOT7291fWL2u?= =?us-ascii?q?ZNT4zeeWuQ2GC569nofM7zg=3D=3D?= X-Talos-MUID: =?us-ascii?q?9a23=3AqQyYbA5W6tsc8JvWB0+MugbDxoxN35qyMEBOzqw?= =?us-ascii?q?m+NfYESZtIhu3njWeF9o=3D?= X-IronPort-AV: E=Sophos;i="5.99,250,1677560400"; d="scan'208";a="107797746" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 1/6] x86/cpu-policy: Drop build time cross-checks of featureset sizes Date: Thu, 4 May 2023 20:39:19 +0100 Message-ID: <20230504193924.3305496-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230504193924.3305496-1-andrew.cooper3@citrix.com> References: <20230504193924.3305496-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit These BUILD_BUG_ON()s exist to cover the curious absence of a diagnostic for code which looks like: uint32_t foo[1] = { 1, 2, 3 }; However, GCC 12 at least does now warn for this: foo.c:1:24: error: excess elements in array initializer [-Werror] 884 | uint32_t foo[1] = { 1, 2, 3 }; | ^ foo.c:1:24: note: (near initialization for 'foo') and has found other array length issues which we want to fix. Drop the cross check now tools can spot the problem case directly. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/arch/x86/cpu-policy.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/xen/arch/x86/cpu-policy.c b/xen/arch/x86/cpu-policy.c index ef6a2d0d180a..44c88debf958 100644 --- a/xen/arch/x86/cpu-policy.c +++ b/xen/arch/x86/cpu-policy.c @@ -883,12 +883,6 @@ void __init init_dom0_cpuid_policy(struct domain *d) static void __init __maybe_unused build_assertions(void) { - BUILD_BUG_ON(ARRAY_SIZE(known_features) != FSCAPINTS); - BUILD_BUG_ON(ARRAY_SIZE(pv_max_featuremask) != FSCAPINTS); - BUILD_BUG_ON(ARRAY_SIZE(hvm_shadow_max_featuremask) != FSCAPINTS); - BUILD_BUG_ON(ARRAY_SIZE(hvm_hap_max_featuremask) != FSCAPINTS); - BUILD_BUG_ON(ARRAY_SIZE(deep_features) != FSCAPINTS); - /* Find some more clever allocation scheme if this trips. */ BUILD_BUG_ON(sizeof(struct cpu_policy) > PAGE_SIZE); -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Thu May 04 19:39:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:39:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530042.825306 (Exim 4.92) (envelope-from ) id 1puenj-0007PH-MJ; Thu, 04 May 2023 19:39:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530042.825306; Thu, 04 May 2023 19:39:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puenj-0007O9-GG; Thu, 04 May 2023 19:39:39 +0000 Received: by outflank-mailman (input) for mailman id 530042; Thu, 04 May 2023 19:39:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueni-00069W-8I for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:39:38 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 667cad8e-eab3-11ed-8611-37d641c3527e; Thu, 04 May 2023 21:39:36 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 667cad8e-eab3-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683229175; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=8ce56R8LVcBJfEp4OPYpZgXky/uTBbu+6PODD4ktX/M=; b=ZXVEiBV20OPRjcoDnNVtzOJ1n+Lj96JLE/C8t1e13lI6XzGI6GEBXtwT e+Bs5Y6qp6Re/UNCNLJep03roQCqjs1dON45tTGjjsbOd+HooNKVzad6x dvtFg7Sie1VFlqNPmr70II+Iz2dKDNh1PNTFKcZWokZNYlXU7VZAVscW1 k=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 107797745 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:xdERWaOw/3iHgwzvrR3Ul8FynXyQoLVcMsEvi/4bfWQNrUoh32NSz mZNWWuBPvrYM2agKd5yatng8EoP7JfWzYVkGwto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvPrRC9H5qyo42tF5gBmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0rxWPm9w8 942FGAId0yNnuX14pucbMA506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI ZNEN3w2Nk+ojx5nYz/7DLoXmuuyi2a5WDpfsF+P/oI84nTJzRw327/oWDbQUoXSGpoEwRnE+ woq+UyjJBhdLvKWlwaMrGuKusSRxnmmQI87QejQGvlC3wTImz175ActfUu2p7y1h1CzX/pbK lcI4Ww+oK4q7kupQ9LhGRqirxasnDQRRt5RGO0S8xyWx+zf5APxLncAZi5MbpohrsBeeNAx/ gbXxZWzX2Up6eDLDyvHrd94sA9eJwBPDFAMWykmYzdV5sC/rpg0zTDmafBKRfvdYsLOJd3g/ 9ybhHFg1+5L1JRbiPrTEUPv2Gz1+MWQJuIhzkCOBz/+sFskDGKwT9bwgWU3+8qsO2pworOpm HEf0/aT4+kVZX1mvHzcGb5ddF1FChvsDdE9vbKMN8N7n9hV0yT/Fb28GRknTKuTDu4KeCXyf GjYsh5L6ZlYMROCNPEnONjrVZhznPC7SrwJs8zpgidmOMAtJGdrAgk3DaJv44wduBd1yvxuU XtqWc2tEWwbGcxa8dZCfM9EieVD7nlnlQvuqWXTk0zPPUy2OCTEFt/o8TKmMogE0U9ziF+Iq IgCbZHRk0o3vS+XSnC/zLP/5GsidRATba0aYeQNHgJfCmKKwF0cNsI= IronPort-HdrOrdr: A9a23:t+PfxKxYwKdSpjb00wbfKrPw6L1zdoMgy1knxilNoHxuH/Bw9v re+cjzsCWftN9/Yh4dcLy7VpVoIkmsl6Kdg7NwAV7KZmCP1FdARLsI0WKI+UyCJ8SRzI9gPa cLSdkFNDXzZ2IK8PoTNmODYqodKNrsytHWuQ/HpU0dKT2D88tbnn9E4gDwKDwQeCB2QaAXOb C7/cR9qz+paR0sH7+G7ilsZZmkmzXT/qiWGCI7Ow== X-Talos-CUID: 9a23:P7UCjG75lPudlrpMN9ssrm8rFP4jUFPhnHLJf0GhDiVLYZqzYArF X-Talos-MUID: =?us-ascii?q?9a23=3AzCLoiww91vxrdQwpVr1UkB6due2aqP6IAQcXv5x?= =?us-ascii?q?Yh8DaLApMEGnG1mmvT6Zyfw=3D=3D?= X-IronPort-AV: E=Sophos;i="5.99,250,1677560400"; d="scan'208";a="107797745" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 3/6] x86/cpuid: Rename FSCAPINTS to X86_NR_FEAT Date: Thu, 4 May 2023 20:39:21 +0100 Message-ID: <20230504193924.3305496-4-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230504193924.3305496-1-andrew.cooper3@citrix.com> References: <20230504193924.3305496-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit The latter is more legible, and consistent with X86_NR_{CAPS,SYNTH,BUG} which already exist. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/arch/x86/cpu-policy.c | 22 +++++++++++----------- xen/arch/x86/cpu/common.c | 4 ++-- xen/arch/x86/include/asm/cpufeatures.h | 8 ++++---- xen/arch/x86/include/asm/cpuid.h | 2 +- xen/arch/x86/sysctl.c | 8 ++++---- 5 files changed, 22 insertions(+), 22 deletions(-) diff --git a/xen/arch/x86/cpu-policy.c b/xen/arch/x86/cpu-policy.c index 44c88debf958..774c512a03bd 100644 --- a/xen/arch/x86/cpu-policy.c +++ b/xen/arch/x86/cpu-policy.c @@ -130,8 +130,8 @@ static int __init cf_check parse_xen_cpuid(const char *s) custom_param("cpuid", parse_xen_cpuid); static bool __initdata dom0_cpuid_cmdline; -static uint32_t __initdata dom0_enable_feat[FSCAPINTS]; -static uint32_t __initdata dom0_disable_feat[FSCAPINTS]; +static uint32_t __initdata dom0_enable_feat[X86_NR_FEAT]; +static uint32_t __initdata dom0_disable_feat[X86_NR_FEAT]; static void __init cf_check _parse_dom0_cpuid(unsigned int feat, bool val) { @@ -158,10 +158,10 @@ static void sanitise_featureset(uint32_t *fs) { /* for_each_set_bit() uses unsigned longs. Extend with zeroes. */ uint32_t disabled_features[ - ROUNDUP(FSCAPINTS, sizeof(unsigned long)/sizeof(uint32_t))] = {}; + ROUNDUP(X86_NR_FEAT, sizeof(unsigned long)/sizeof(uint32_t))] = {}; unsigned int i; - for ( i = 0; i < FSCAPINTS; ++i ) + for ( i = 0; i < X86_NR_FEAT; ++i ) { /* Clamp to known mask. */ fs[i] &= known_features[i]; @@ -181,7 +181,7 @@ static void sanitise_featureset(uint32_t *fs) ASSERT(dfs); /* deep_features[] should guarentee this. */ - for ( j = 0; j < FSCAPINTS; ++j ) + for ( j = 0; j < X86_NR_FEAT; ++j ) { fs[j] &= ~dfs[j]; disabled_features[j] &= ~dfs[j]; @@ -476,7 +476,7 @@ static void __init guest_common_feature_adjustments(uint32_t *fs) static void __init calculate_pv_max_policy(void) { struct cpu_policy *p = &pv_max_cpu_policy; - uint32_t fs[FSCAPINTS]; + uint32_t fs[X86_NR_FEAT]; unsigned int i; *p = host_cpu_policy; @@ -509,7 +509,7 @@ static void __init calculate_pv_max_policy(void) static void __init calculate_pv_def_policy(void) { struct cpu_policy *p = &pv_def_cpu_policy; - uint32_t fs[FSCAPINTS]; + uint32_t fs[X86_NR_FEAT]; unsigned int i; *p = pv_max_cpu_policy; @@ -529,7 +529,7 @@ static void __init calculate_pv_def_policy(void) static void __init calculate_hvm_max_policy(void) { struct cpu_policy *p = &hvm_max_cpu_policy; - uint32_t fs[FSCAPINTS]; + uint32_t fs[X86_NR_FEAT]; unsigned int i; const uint32_t *mask; @@ -625,7 +625,7 @@ static void __init calculate_hvm_max_policy(void) static void __init calculate_hvm_def_policy(void) { struct cpu_policy *p = &hvm_def_cpu_policy; - uint32_t fs[FSCAPINTS]; + uint32_t fs[X86_NR_FEAT]; unsigned int i; const uint32_t *mask; @@ -723,7 +723,7 @@ void recalculate_cpuid_policy(struct domain *d) const struct cpu_policy *max = is_pv_domain(d) ? (IS_ENABLED(CONFIG_PV) ? &pv_max_cpu_policy : NULL) : (IS_ENABLED(CONFIG_HVM) ? &hvm_max_cpu_policy : NULL); - uint32_t fs[FSCAPINTS], max_fs[FSCAPINTS]; + uint32_t fs[X86_NR_FEAT], max_fs[X86_NR_FEAT]; unsigned int i; if ( !max ) @@ -864,7 +864,7 @@ void __init init_dom0_cpuid_policy(struct domain *d) /* Apply dom0-cpuid= command line settings, if provided. */ if ( dom0_cpuid_cmdline ) { - uint32_t fs[FSCAPINTS]; + uint32_t fs[X86_NR_FEAT]; unsigned int i; x86_cpu_policy_to_featureset(p, fs); diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c index 1be049e332ce..d12ccea20350 100644 --- a/xen/arch/x86/cpu/common.c +++ b/xen/arch/x86/cpu/common.c @@ -80,7 +80,7 @@ void __init setup_clear_cpu_cap(unsigned int cap) if (!dfs) return; - for (i = 0; i < FSCAPINTS; ++i) { + for (i = 0; i < X86_NR_FEAT; ++i) { cleared_caps[i] |= dfs[i]; boot_cpu_data.x86_capability[i] &= ~dfs[i]; if (!(forced_caps[i] & dfs[i])) @@ -527,7 +527,7 @@ void identify_cpu(struct cpuinfo_x86 *c) * The vendor-specific functions might have changed features. Now * we do "generic changes." */ - for (i = 0; i < FSCAPINTS; ++i) + for (i = 0; i < X86_NR_FEAT; ++i) c->x86_capability[i] &= known_features[i]; for (i = 0 ; i < X86_NR_CAPS ; ++i) { diff --git a/xen/arch/x86/include/asm/cpufeatures.h b/xen/arch/x86/include/asm/cpufeatures.h index e982ee920ce1..408ab4ba16a5 100644 --- a/xen/arch/x86/include/asm/cpufeatures.h +++ b/xen/arch/x86/include/asm/cpufeatures.h @@ -5,11 +5,11 @@ #include /* Number of capability words covered by the featureset words. */ -#define FSCAPINTS FEATURESET_NR_ENTRIES +#define X86_NR_FEAT FEATURESET_NR_ENTRIES /* Synthetic words follow the featureset words. */ #define X86_NR_SYNTH 1 -#define X86_SYNTH(x) (FSCAPINTS * 32 + (x)) +#define X86_SYNTH(x) (X86_NR_FEAT * 32 + (x)) /* Synthetic features */ XEN_CPUFEATURE(CONSTANT_TSC, X86_SYNTH( 0)) /* TSC ticks at a constant rate */ @@ -45,7 +45,7 @@ XEN_CPUFEATURE(IBPB_ENTRY_HVM, X86_SYNTH(29)) /* MSR_PRED_CMD used by Xen for /* Bug words follow the synthetic words. */ #define X86_NR_BUG 1 -#define X86_BUG(x) ((FSCAPINTS + X86_NR_SYNTH) * 32 + (x)) +#define X86_BUG(x) ((X86_NR_FEAT + X86_NR_SYNTH) * 32 + (x)) #define X86_BUG_FPU_PTRS X86_BUG( 0) /* (F)X{SAVE,RSTOR} doesn't save/restore FOP/FIP/FDP. */ #define X86_BUG_NULL_SEG X86_BUG( 1) /* NULL-ing a selector preserves the base and limit. */ @@ -53,4 +53,4 @@ XEN_CPUFEATURE(IBPB_ENTRY_HVM, X86_SYNTH(29)) /* MSR_PRED_CMD used by Xen for #define X86_BUG_IBPB_NO_RET X86_BUG( 3) /* IBPB doesn't flush the RSB/RAS */ /* Total number of capability words, inc synth and bug words. */ -#define X86_NR_CAPS (FSCAPINTS + X86_NR_SYNTH + X86_NR_BUG) /* N 32-bit words worth of info */ +#define X86_NR_CAPS (X86_NR_FEAT + X86_NR_SYNTH + X86_NR_BUG) /* N 32-bit words worth of info */ diff --git a/xen/arch/x86/include/asm/cpuid.h b/xen/arch/x86/include/asm/cpuid.h index b32ba0bbfe5c..85b6ca0edb91 100644 --- a/xen/arch/x86/include/asm/cpuid.h +++ b/xen/arch/x86/include/asm/cpuid.h @@ -10,7 +10,7 @@ #include -extern const uint32_t known_features[FSCAPINTS]; +extern const uint32_t known_features[X86_NR_FEAT]; /* * Expected levelling capabilities (given cpuid vendor/family information), diff --git a/xen/arch/x86/sysctl.c b/xen/arch/x86/sysctl.c index c107f40c6283..9be0e796628c 100644 --- a/xen/arch/x86/sysctl.c +++ b/xen/arch/x86/sysctl.c @@ -308,13 +308,13 @@ long arch_do_sysctl( #endif }; const struct cpu_policy *p = NULL; - uint32_t featureset[FSCAPINTS]; + uint32_t featureset[X86_NR_FEAT]; unsigned int nr; /* Request for maximum number of features? */ if ( guest_handle_is_null(sysctl->u.cpu_featureset.features) ) { - sysctl->u.cpu_featureset.nr_features = FSCAPINTS; + sysctl->u.cpu_featureset.nr_features = X86_NR_FEAT; if ( __copy_field_to_guest(u_sysctl, sysctl, u.cpu_featureset.nr_features) ) ret = -EFAULT; @@ -323,7 +323,7 @@ long arch_do_sysctl( /* Clip the number of entries. */ nr = min_t(unsigned int, sysctl->u.cpu_featureset.nr_features, - FSCAPINTS); + X86_NR_FEAT); /* Look up requested featureset. */ if ( sysctl->u.cpu_featureset.index < ARRAY_SIZE(policy_table) ) @@ -352,7 +352,7 @@ long arch_do_sysctl( ret = -EFAULT; /* Inform the caller if there was more data to provide. */ - if ( !ret && nr < FSCAPINTS ) + if ( !ret && nr < X86_NR_FEAT ) ret = -ENOBUFS; break; -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Thu May 04 19:39:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:39:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530043.825311 (Exim 4.92) (envelope-from ) id 1puenk-0007Td-2O; Thu, 04 May 2023 19:39:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530043.825311; Thu, 04 May 2023 19:39:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puenj-0007Sm-SF; Thu, 04 May 2023 19:39:39 +0000 Received: by outflank-mailman (input) for mailman id 530043; Thu, 04 May 2023 19:39:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puenj-00069W-3g for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:39:39 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 672ce9c0-eab3-11ed-8611-37d641c3527e; Thu, 04 May 2023 21:39:37 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 672ce9c0-eab3-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683229177; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=9R0YIYGzst7iA1qXqPxFQ9NZvJDOOPfxgM5CuGK9bi0=; b=bikuqNEzzDFQ2Sf6I2FAkoVPskOLa973sYNn8vEWFMOGFl5lyQrQ30u5 /EvVrVGWRbweLgs+i7XQUjnYfXHVTIXd4p4/DevXudG10pLMYhfYpkXPR PAg1dK2hch0j0mGjogzNY5HlVx/oy0M8kYNXuVd2LpG1AOtgp2vPOf6vB w=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 107797747 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:+Wvn1ajqcahEGyv37WPFhN36X161ERAKZh0ujC45NGQN5FlHY01je htvWz2HafyDMGTye4twad+0o0gB75PXm4dqHQptpCo8Qigb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWj0N8klgZmP6sT4QeCzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tRbAwstaBynpt7umoPjceNSlNsvL/vSadZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJYw1MYH49tL7Aan3XWjtUsl+K44Ew5HDe1ldZ27nxKtvFPNeNQK25m27B/ j2ZrjumXk5y2Nq3zBiv6U2mh+v1hWD3XcFPRIGqyO86nwjGroAUIEJPDgbqyRWjsWauVtQaJ 0EK9y4Gqakp6FftXtT7Rwe/onOPolgbQdU4O88Q5RyJy6HUyx2EHWVCRTlEAPQ5sOcmSDps0 UWG9+4FHhQ27ufTEyjEsO7J83XrY3N9wXI+iTEsDiA+w9/vhKAP1kj+Fu1pLryqgt7HIGSlq 9yVlxTSl4n/nOZSifXgpQmd023zznTaZlVrv1uKBwpJ+is8Pdf4PNLwtDA3+N4adO6kok+9U G/ociR0xMQHFtmzmSOEW43h95n5tq/eYFUwbbOCdqTNFghBGFb5J+i8GBkkeC9U3j8sIFcFm nP7twJL/4N0N3C3d6JxaI/ZI510nfO6T4q5D6GMNYUmjn1NSeN61Hs2OR74M57FySDAbp3Ty b/EKJ3xXB72+IxszSasRvd17ILHMhsWnDuJLbiilkTP7FZrTCLNIVvzGAfUP79RAWLtiFm9z uuzwOPQlk4BDbekOXGImWPRRHhTRUUG6VnNg5Q/Xoa+zsBOQgnN19e5LWsdRrFY IronPort-HdrOrdr: A9a23:DDCJwqG4+wEztRPFpLqELMeALOsnbusQ8zAXPiBKJCC9E/bo8v xG+c5w6faaslkssR0b9+xoW5PwI080l6QU3WB5B97LMDUO0FHCEGgI1/qA/9SPIUzDHu4279 YbT0B9YueAcGSTW6zBkXWF+9VL+qj5zEix792uq0uE1WtRGtldBwESMHf9LmRGADNoKLAeD5 Sm6s9Ot1ObCA8qhpTSPAhiYwDbzee77a7bXQ== X-Talos-CUID: =?us-ascii?q?9a23=3AnvwvZWqHZzaKT4gwBTMBk1PmUYMOSV3bwFPxHxf?= =?us-ascii?q?iOD5SQoOHVlOTypoxxg=3D=3D?= X-Talos-MUID: 9a23:yZW1TQnAhHGdUB5UFoWydnpnFu1z3K6vDHoV0pkD+JTUCT5OKmeC2WE= X-IronPort-AV: E=Sophos;i="5.99,250,1677560400"; d="scan'208";a="107797747" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 4/6] x86/cpu-policy: Split cpuid-consts.h out of cpu-policy.h Date: Thu, 4 May 2023 20:39:22 +0100 Message-ID: <20230504193924.3305496-5-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230504193924.3305496-1-andrew.cooper3@citrix.com> References: <20230504193924.3305496-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit In order to disentangle X86_NR_FEAT from FEATURESET_NR_ENTRIES, we need to adjust asm/cpufeatures.h's inclusion of cpuid-autogen.h, and including all of cpu-policy.h ends with cyclic dependences and a mess. Split the FEATURESET_* constants out into a new header. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu I don't particularly like this, but I can't find a better alternative. --- xen/include/xen/lib/x86/cpu-policy.h | 19 +------------- xen/include/xen/lib/x86/cpuid-consts.h | 34 ++++++++++++++++++++++++++ 2 files changed, 35 insertions(+), 18 deletions(-) create mode 100644 xen/include/xen/lib/x86/cpuid-consts.h diff --git a/xen/include/xen/lib/x86/cpu-policy.h b/xen/include/xen/lib/x86/cpu-policy.h index bfa425060464..e9bda14a7595 100644 --- a/xen/include/xen/lib/x86/cpu-policy.h +++ b/xen/include/xen/lib/x86/cpu-policy.h @@ -2,24 +2,7 @@ #ifndef XEN_LIB_X86_POLICIES_H #define XEN_LIB_X86_POLICIES_H -#include - -#define FEATURESET_1d 0 /* 0x00000001.edx */ -#define FEATURESET_1c 1 /* 0x00000001.ecx */ -#define FEATURESET_e1d 2 /* 0x80000001.edx */ -#define FEATURESET_e1c 3 /* 0x80000001.ecx */ -#define FEATURESET_Da1 4 /* 0x0000000d:1.eax */ -#define FEATURESET_7b0 5 /* 0x00000007:0.ebx */ -#define FEATURESET_7c0 6 /* 0x00000007:0.ecx */ -#define FEATURESET_e7d 7 /* 0x80000007.edx */ -#define FEATURESET_e8b 8 /* 0x80000008.ebx */ -#define FEATURESET_7d0 9 /* 0x00000007:0.edx */ -#define FEATURESET_7a1 10 /* 0x00000007:1.eax */ -#define FEATURESET_e21a 11 /* 0x80000021.eax */ -#define FEATURESET_7b1 12 /* 0x00000007:1.ebx */ -#define FEATURESET_7d2 13 /* 0x00000007:2.edx */ -#define FEATURESET_7c1 14 /* 0x00000007:1.ecx */ -#define FEATURESET_7d1 15 /* 0x00000007:1.edx */ +#include struct cpuid_leaf { diff --git a/xen/include/xen/lib/x86/cpuid-consts.h b/xen/include/xen/lib/x86/cpuid-consts.h new file mode 100644 index 000000000000..6ca8c39a3df4 --- /dev/null +++ b/xen/include/xen/lib/x86/cpuid-consts.h @@ -0,0 +1,34 @@ +/* Common data structures and functions consumed by hypervisor and toolstack */ +#ifndef XEN_LIB_X86_CONSTS_H +#define XEN_LIB_X86_CONSTS_H + +#include + +#define FEATURESET_1d 0 /* 0x00000001.edx */ +#define FEATURESET_1c 1 /* 0x00000001.ecx */ +#define FEATURESET_e1d 2 /* 0x80000001.edx */ +#define FEATURESET_e1c 3 /* 0x80000001.ecx */ +#define FEATURESET_Da1 4 /* 0x0000000d:1.eax */ +#define FEATURESET_7b0 5 /* 0x00000007:0.ebx */ +#define FEATURESET_7c0 6 /* 0x00000007:0.ecx */ +#define FEATURESET_e7d 7 /* 0x80000007.edx */ +#define FEATURESET_e8b 8 /* 0x80000008.ebx */ +#define FEATURESET_7d0 9 /* 0x00000007:0.edx */ +#define FEATURESET_7a1 10 /* 0x00000007:1.eax */ +#define FEATURESET_e21a 11 /* 0x80000021.eax */ +#define FEATURESET_7b1 12 /* 0x00000007:1.ebx */ +#define FEATURESET_7d2 13 /* 0x00000007:2.edx */ +#define FEATURESET_7c1 14 /* 0x00000007:1.ecx */ +#define FEATURESET_7d1 15 /* 0x00000007:1.edx */ + +#endif /* !XEN_LIB_X86_CONSTS_H */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Thu May 04 19:39:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:39:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530038.825260 (Exim 4.92) (envelope-from ) id 1pueng-0006DJ-9m; Thu, 04 May 2023 19:39:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530038.825260; Thu, 04 May 2023 19:39:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pueng-0006CW-5q; Thu, 04 May 2023 19:39:36 +0000 Received: by outflank-mailman (input) for mailman id 530038; Thu, 04 May 2023 19:39:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puenf-00069l-6I for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:39:35 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6293b883-eab3-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:39:31 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6293b883-eab3-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683229173; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=kA0CoCvs9w9UnA8Cp8g4Yf97SdqOL/znbdWvnuGRE/s=; b=GnQ7M7m/PYMymFfO92HSaHE497UtluP5svWs9DlZzqe7Qz4/NVEZ7yFc SNOwy88h+tzBRKikEIvgkNjKm9UEk0eIk7+2rXO97u1XLaT3gqEQF36Fo bYC46F7kTGjUkJYhBvFbdGT99CB0NmFLcm6u4YIde+YxlJuoau2r/cfvb I=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 107931606 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:6OvrB6+gnEOK1t08d7VHDrUD0H6TJUtcMsCJ2f8bNWPcYEJGY0x3y 2QdD2+COPzcZmShc9p+PY3n9k9SupGDz4MwHgVl+yw8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kI+1BjOkGlA5AdmOKgX5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDkkTs thJBmEQXyqv3fOTwLyxYfZRvN0aeZyD0IM34hmMzBncBPciB5vCX7/L9ZlT2zJYasJmRKiEI ZBDMHw2MUqGOkcUUrsUIMtWcOOAr3/zaTBH7nmSorI6+TP7xw1tyrn9dtHSf7RmQO0MxhnJ/ TuYpzqR7hcyK5/HmAS1rC6WgLXQvgb0Q9o/G+aB+as/6LGU7jNKU0BHPbehmtGph0j7V99BJ kg8/is1sbN05EGtVsP6XRCzvDiDpBF0ZjZLO7RkskfXkPOSulvHQDFeFVatdeDKqudrAhh7+ A6UrunFXy1KsLOfYm2gzK6t+Gba1TcuEYMSWcMVZVJbs4K7+dtj0U2nosVLS/Ds0ICscd3k6 3XT9XVl2e1O5SIe///jlW0rlQ5AsXQgouQdwgzMFlyo4QpiDGJOT9z5sAOLhRqswWvwc7Vgg JTns5LEhAz2JcvR/BFhuc1UdF1T296LMSfHnXlkFIQ7+jKm9haLJN4Au2skehswY55fJlcFh XPuVf55vscPbBNGk4cuC25ONyja5fe5Tom0PhwlRtFPfoJwZGe6wc2aXmbJhzqFuBF1wckC1 WKzLZ7E4YAyVf42k1Jbho41jdcW+8zJ7TmOHs6mlU78ieX2ibz8Ye5tDWZip9sRtMusyDg5O f4GXydW432ziNHDXxQ= IronPort-HdrOrdr: A9a23:n00BHKOCaufrE8BcThWjsMiBIKoaSvp037BL7TEVdfUxSKGlfq +V88jzuSWbtN9pYgBFpTnYAtjmfZq+z+8W3WByB9uftWDd0QPDEGgF1+rfKlXbcBEWndQttp uIHZIfNDUlZWIK9PoT/2GDYqkdKMjuytHPuQ/Bp00dNT2CYZsQkzuQV26gYzZLrBEvP+tCKH KGjvA32gadRQ== X-Talos-CUID: 9a23:+Jhv3GwLDU6bHbvpqSYMBgVJXeR0XCzA/U38eV6dCWhjY6Koc0aprfY= X-Talos-MUID: 9a23:gY02lgpSBOzTJi5FAIAezy4hbJZW0/ryMkZXjrYjtNLcGCMrAjjI2Q== X-IronPort-AV: E=Sophos;i="5.99,250,1677560400"; d="scan'208";a="107931606" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper Subject: [PATCH 6/6] DO NOT APPLY: Example breakage Date: Thu, 4 May 2023 20:39:24 +0100 Message-ID: <20230504193924.3305496-7-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230504193924.3305496-1-andrew.cooper3@citrix.com> References: <20230504193924.3305496-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Prior to disentangling X86_NR_FEAT from FEATURESET_NR_ENTRIES, GCC 12 correctly notices: lib/x86/cpuid.c: In function 'x86_cpu_policy_to_featureset': lib/x86/cpuid.c:82:7: error: array subscript 16 is outside array bounds of 'uint32_t[16]' {aka 'unsigned int[16]'} [-Werror=array-bounds=] 82 | fs[FEATURESET_7a2] = p->feat._7a2; | ~~^~~~~~~~~~~~~~~~ lib/x86/cpuid.c:64:42: note: at offset 64 into object 'fs' of size [0, 64] Signed-off-by: Andrew Cooper --- xen/include/xen/lib/x86/cpu-policy.h | 6 +++++- xen/include/xen/lib/x86/cpuid-consts.h | 2 ++ xen/lib/x86/cpuid.c | 2 ++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/xen/include/xen/lib/x86/cpu-policy.h b/xen/include/xen/lib/x86/cpu-policy.h index 01431de056c8..164b3f4aac13 100644 --- a/xen/include/xen/lib/x86/cpu-policy.h +++ b/xen/include/xen/lib/x86/cpu-policy.h @@ -192,7 +192,11 @@ struct cpu_policy }; /* Subleaf 2. */ - uint32_t /* a */:32, /* b */:32, /* c */:32; + union { + uint32_t _7a2; + struct { DECL_BITFIELD(7a2); }; + }; + uint32_t /* b */:32, /* c */:32; union { uint32_t _7d2; struct { DECL_BITFIELD(7d2); }; diff --git a/xen/include/xen/lib/x86/cpuid-consts.h b/xen/include/xen/lib/x86/cpuid-consts.h index 9fe931b8e31f..5dd9727fec79 100644 --- a/xen/include/xen/lib/x86/cpuid-consts.h +++ b/xen/include/xen/lib/x86/cpuid-consts.h @@ -20,8 +20,10 @@ #define FEATURESET_7d2 13 /* 0x00000007:2.edx */ #define FEATURESET_7c1 14 /* 0x00000007:1.ecx */ #define FEATURESET_7d1 15 /* 0x00000007:1.edx */ +#define FEATURESET_7a2 16 #define X86_NR_FEAT (FEATURESET_7d1 + 1) +//#define X86_NR_FEAT (FEATURESET_7a2 + 1) #endif /* !XEN_LIB_X86_CONSTS_H */ diff --git a/xen/lib/x86/cpuid.c b/xen/lib/x86/cpuid.c index 76f26e92af8d..90bc82a18c30 100644 --- a/xen/lib/x86/cpuid.c +++ b/xen/lib/x86/cpuid.c @@ -79,6 +79,7 @@ void x86_cpu_policy_to_featureset( fs[FEATURESET_7d2] = p->feat._7d2; fs[FEATURESET_7c1] = p->feat._7c1; fs[FEATURESET_7d1] = p->feat._7d1; + fs[FEATURESET_7a2] = p->feat._7a2; } void x86_cpu_featureset_to_policy( @@ -100,6 +101,7 @@ void x86_cpu_featureset_to_policy( p->feat._7d2 = fs[FEATURESET_7d2]; p->feat._7c1 = fs[FEATURESET_7c1]; p->feat._7d1 = fs[FEATURESET_7d1]; + p->feat._7a2 = fs[FEATURESET_7a2]; } void x86_cpu_policy_recalc_synth(struct cpu_policy *p) -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Thu May 04 19:39:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:39:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530037.825256 (Exim 4.92) (envelope-from ) id 1pueng-0006A7-2T; Thu, 04 May 2023 19:39:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530037.825256; Thu, 04 May 2023 19:39:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puenf-00069v-Tq; Thu, 04 May 2023 19:39:35 +0000 Received: by outflank-mailman (input) for mailman id 530037; Thu, 04 May 2023 19:39:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puend-00069W-WF for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:39:34 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6254b545-eab3-11ed-8611-37d641c3527e; Thu, 04 May 2023 21:39:30 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6254b545-eab3-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683229170; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=B+Lt4o2YAn9fGf4aYwlSeUeSsUI9OhnNotrhhc/MbjE=; b=IOEHq8l7MPXu/neqgoRj3U5FDEusbnx01qEO/hig/y3bk0HbOPJIzu6v FXkPKG88s2OKFAXwrM/q208lsId+9YktYPP1Ip4ohcBuB2fd9U/+yY30s 8247UyCd+nUG/aPdjjDG7OLLApXUJjTU7Ur1o3t1OJAU9ULlKvz3x8wXC I=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 107797744 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:9NPEQKqiBM9uJR0MLDC4OmpJ9K5eBmJpZRIvgKrLsJaIsI4StFCzt garIBmCMqvcY2XxKtwlbdu0/UMOuZaDydBkSwQ+qCw2EHxH+ZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WJwUmAWP6gR5weDzyVNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAHMmVTCFi8aX/Orhe7FXjPoxM8XoDrpK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFOUslWcOSA3xETdxVxrl6PqLVxyG/U1AFri5DmMcbPe8zMTsJQ9qqdj jueoDuoXU5GaLRzzxKE/SKpoumVshnle5kVS76k6e9WqR66kzl75Bo+CgLg/KjRZlSFc8JSL QkY9zQjqYA29Ve3VZ/tUhugunmGsxUAHd1KHIUSyiuA167V6AaxHXUfQ3hKb9lOnNAybSwn0 BmOhdyBONB0mOTLEzTHrO7S9G7sf3FPdgfueBPoUyNGyOLDpo0Xry6XFOc7K6SLnML5GgPJl mXiQDcFu1kDsSIa//zlrQuf2mj8+cehoh0dvVuOAD/8hu9tTMv8PtHztwCGhRpVBNzBJmRtq kTojCR3AAomKZiW3BKAT+wWdF1Cz6bUaWaM6bKD8nRIythMx5JAVdoKiN2GDB01WvvogBewC KMphStf5YVIIFyhZrJtboS6BqwClPawTo6/CKyNP4IVPfCdkTO6ENxGPxbMjwgBbmB1+U3AB XtrWZn1VitLYUiW5DG3W/0cwdcW+8zK/kuKHcqT503+gdKjiIu9Fe9t3K2mMrpos8tpYWz9r 75iCid9408CC7OjOHOMqdF7wJJjBSFTOK0aYvd/LoarSjeK0kl7YxMN6dvNo7BYopk= IronPort-HdrOrdr: A9a23:dl1fZqj12NjW+WdERxt8gcM1C3BQXh4ji2hC6mlwRA09TyX5ra 2TdZUgpHrJYVMqMk3I9uruBEDtex3hHP1OkOss1NWZPDUO0VHARO1fBOPZqAEIcBeOldK1u5 0AT0B/YueAd2STj6zBkXSF+wBL+qj6zEiq792usEuEVWtRGsVdB58SMHfiLqVxLjM2YqYRJd 6nyedsgSGvQngTZtTTPAh/YwCSz+e78q4PeHQ9dmca1DU= X-Talos-CUID: 9a23:MIckimz2dJiLubaMQIBNBgVXMfsFdHH57UuIeX7gMmxXWqKZSm2prfY= X-Talos-MUID: =?us-ascii?q?9a23=3AgnhrGwzRw9BoVrx/cl3LaSNIfiiaqKWhWEUpl88?= =?us-ascii?q?pgdenLisvOCuCnQieAaZyfw=3D=3D?= X-IronPort-AV: E=Sophos;i="5.99,250,1677560400"; d="scan'208";a="107797744" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 0/6] x86: Fix transient build breakage with featureset additions Date: Thu, 4 May 2023 20:39:18 +0100 Message-ID: <20230504193924.3305496-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit See patch 5 for details. Patch 6 is just an example that demonstrates the fix working in practice. Andrew Cooper (6): x86/cpu-policy: Drop build time cross-checks of featureset sizes x86/cpuid: Rename NCAPINTS to X86_NR_CAPS x86/cpuid: Rename FSCAPINTS to X86_NR_FEAT x86/cpu-policy: Split cpuid-consts.h out of cpu-policy.h x86/cpu-policy: Disentangle X86_NR_FEAT and FEATURESET_NR_ENTRIES DO NOT APPLY: Example breakage xen/arch/x86/alternative.c | 2 +- xen/arch/x86/cpu-policy.c | 33 +++++++++++----------- xen/arch/x86/cpu/common.c | 16 +++++------ xen/arch/x86/cpuid.c | 2 +- xen/arch/x86/include/asm/cpufeature.h | 2 +- xen/arch/x86/include/asm/cpufeatures.h | 11 +++----- xen/arch/x86/include/asm/cpuid.h | 2 +- xen/arch/x86/sysctl.c | 8 +++--- xen/include/xen/lib/x86/cpu-policy.h | 29 ++++++-------------- xen/include/xen/lib/x86/cpuid-consts.h | 38 ++++++++++++++++++++++++++ xen/lib/x86/cpuid.c | 8 ++++-- 11 files changed, 88 insertions(+), 63 deletions(-) create mode 100644 xen/include/xen/lib/x86/cpuid-consts.h -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Thu May 04 19:53:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:53:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530062.825346 (Exim 4.92) (envelope-from ) id 1puf1N-0004G8-SV; Thu, 04 May 2023 19:53:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530062.825346; Thu, 04 May 2023 19:53:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf1N-0004Fy-Pq; Thu, 04 May 2023 19:53:45 +0000 Received: by outflank-mailman (input) for mailman id 530062; Thu, 04 May 2023 19:53:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf1M-0003xx-8V for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:53:44 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5e861438-eab5-11ed-8611-37d641c3527e; Thu, 04 May 2023 21:53:42 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-403-PWDrmmbSNeKjFAv3qLOnZg-1; Thu, 04 May 2023 15:53:37 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 31E0D109DCE5; Thu, 4 May 2023 19:53:36 +0000 (UTC) Received: from localhost (unknown [10.39.192.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id 59BEFC15BAD; Thu, 4 May 2023 19:53:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5e861438-eab5-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683230021; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2q86JTUb82jHsKou8iDv6+YsV2u1chyoHCqSrVQuj0g=; b=B5pQAGBnnAr0A+0xGh0wbuAruZ1+g+47gWo6+eRRnLbwl9zPOfvj1q63v6OuTe5vKic0M2 bvAcYiZhsT4glR8IbJYeqRoykfg+/DtaLLX8Zxd+7p20mKLEZMUvxn7GJjzKIwAVZC4QKu yLIcmabUUUiXUP7+hkyj2v2WoEDXtQ0= X-MC-Unique: PWDrmmbSNeKjFAv3qLOnZg-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Ronnie Sahlberg , Aarushi Mehta , qemu-block@nongnu.org, Paul Durrant , Anthony Perard , Peter Lieven , Stefan Weil , Xie Yongji , Kevin Wolf , Paolo Bonzini , "Michael S. Tsirkin" , Leonardo Bras , Peter Xu , Hanna Reitz , Stefano Stabellini , Richard Henderson , David Woodhouse , Coiby Xu , Eduardo Habkost , Stefano Garzarella , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Stefan Hajnoczi , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Juan Quintela , "Richard W.M. Jones" , Fam Zheng , Marcel Apfelbaum Subject: [PATCH v5 02/21] block-backend: split blk_do_set_aio_context() Date: Thu, 4 May 2023 15:53:08 -0400 Message-Id: <20230504195327.695107-3-stefanha@redhat.com> In-Reply-To: <20230504195327.695107-1-stefanha@redhat.com> References: <20230504195327.695107-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 blk_set_aio_context() is not fully transactional because blk_do_set_aio_context() updates blk->ctx outside the transaction. Most of the time this goes unnoticed but a BlockDevOps.drained_end() callback that invokes blk_get_aio_context() fails assert(ctx == blk->ctx). This happens because blk->ctx is only assigned after BlockDevOps.drained_end() is called and we're in an intermediate state where BlockDrvierState nodes already have the new context and the BlockBackend still has the old context. Making blk_set_aio_context() fully transactional solves this assertion failure because the BlockBackend's context is updated as part of the transaction (before BlockDevOps.drained_end() is called). Split blk_do_set_aio_context() in order to solve this assertion failure. This helper function actually serves two different purposes: 1. It drives blk_set_aio_context(). 2. It responds to BdrvChildClass->change_aio_ctx(). Get rid of the helper function. Do #1 inside blk_set_aio_context() and do #2 inside blk_root_set_aio_ctx_commit(). This simplifies the code. The only drawback of the fully transactional approach is that blk_set_aio_context() must contend with blk_root_set_aio_ctx_commit() being invoked as part of the AioContext change propagation. This can be solved by temporarily setting blk->allow_aio_context_change to true. Future patches call blk_get_aio_context() from BlockDevOps->drained_end(), so this patch will become necessary. Signed-off-by: Stefan Hajnoczi --- block/block-backend.c | 71 +++++++++++++++++-------------------------- 1 file changed, 28 insertions(+), 43 deletions(-) diff --git a/block/block-backend.c b/block/block-backend.c index fc530ded6a..68d38635bc 100644 --- a/block/block-backend.c +++ b/block/block-backend.c @@ -2205,52 +2205,31 @@ static AioContext *blk_aiocb_get_aio_context(BlockAIOCB *acb) return blk_get_aio_context(blk_acb->blk); } -static int blk_do_set_aio_context(BlockBackend *blk, AioContext *new_context, - bool update_root_node, Error **errp) -{ - BlockDriverState *bs = blk_bs(blk); - ThrottleGroupMember *tgm = &blk->public.throttle_group_member; - int ret; - - if (bs) { - bdrv_ref(bs); - - if (update_root_node) { - /* - * update_root_node MUST be false for blk_root_set_aio_ctx_commit(), - * as we are already in the commit function of a transaction. - */ - ret = bdrv_try_change_aio_context(bs, new_context, blk->root, errp); - if (ret < 0) { - bdrv_unref(bs); - return ret; - } - } - /* - * Make blk->ctx consistent with the root node before we invoke any - * other operations like drain that might inquire blk->ctx - */ - blk->ctx = new_context; - if (tgm->throttle_state) { - bdrv_drained_begin(bs); - throttle_group_detach_aio_context(tgm); - throttle_group_attach_aio_context(tgm, new_context); - bdrv_drained_end(bs); - } - - bdrv_unref(bs); - } else { - blk->ctx = new_context; - } - - return 0; -} - int blk_set_aio_context(BlockBackend *blk, AioContext *new_context, Error **errp) { + bool old_allow_change; + BlockDriverState *bs = blk_bs(blk); + int ret; + GLOBAL_STATE_CODE(); - return blk_do_set_aio_context(blk, new_context, true, errp); + + if (!bs) { + blk->ctx = new_context; + return 0; + } + + bdrv_ref(bs); + + old_allow_change = blk->allow_aio_context_change; + blk->allow_aio_context_change = true; + + ret = bdrv_try_change_aio_context(bs, new_context, NULL, errp); + + blk->allow_aio_context_change = old_allow_change; + + bdrv_unref(bs); + return ret; } typedef struct BdrvStateBlkRootContext { @@ -2262,8 +2241,14 @@ static void blk_root_set_aio_ctx_commit(void *opaque) { BdrvStateBlkRootContext *s = opaque; BlockBackend *blk = s->blk; + AioContext *new_context = s->new_ctx; + ThrottleGroupMember *tgm = &blk->public.throttle_group_member; - blk_do_set_aio_context(blk, s->new_ctx, false, &error_abort); + blk->ctx = new_context; + if (tgm->throttle_state) { + throttle_group_detach_aio_context(tgm); + throttle_group_attach_aio_context(tgm, new_context); + } } static TransactionActionDrv set_blk_root_context = { -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Thu May 04 19:53:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:53:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530063.825356 (Exim 4.92) (envelope-from ) id 1puf1P-0004WO-4j; Thu, 04 May 2023 19:53:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530063.825356; Thu, 04 May 2023 19:53:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf1P-0004WB-1s; Thu, 04 May 2023 19:53:47 +0000 Received: by outflank-mailman (input) for mailman id 530063; Thu, 04 May 2023 19:53:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf1N-0003xx-K1 for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:53:45 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5f943d10-eab5-11ed-8611-37d641c3527e; Thu, 04 May 2023 21:53:44 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-300-_aYTw-OjPuqtsu_BDqa0FQ-1; Thu, 04 May 2023 15:53:39 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8751C3813F32; Thu, 4 May 2023 19:53:38 +0000 (UTC) Received: from localhost (unknown [10.39.192.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id E2CA11410DD7; Thu, 4 May 2023 19:53:37 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5f943d10-eab5-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683230023; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XkgBmD/d+YGvrkKNM3PZYahxZ017Cf0e7HM4zKnGRyM=; b=hRN+vthTTk5GIzhy/fi6D2ClFGcQlDtxI7DX7m15PSDuLyMoaX2Pnf7iUoS/LJeFY9CFR3 UNesnjOaw7uQN8Q+A3WdAl9Y2qH9q0ybFlwPScOhC4jHKhf4p9dGNdAMVKAmoQAs0ay4CX hxqUNjxt3LmOaCFGwCE3Er4bPvr+oXM= X-MC-Unique: _aYTw-OjPuqtsu_BDqa0FQ-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Ronnie Sahlberg , Aarushi Mehta , qemu-block@nongnu.org, Paul Durrant , Anthony Perard , Peter Lieven , Stefan Weil , Xie Yongji , Kevin Wolf , Paolo Bonzini , "Michael S. Tsirkin" , Leonardo Bras , Peter Xu , Hanna Reitz , Stefano Stabellini , Richard Henderson , David Woodhouse , Coiby Xu , Eduardo Habkost , Stefano Garzarella , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Stefan Hajnoczi , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Juan Quintela , "Richard W.M. Jones" , Fam Zheng , Marcel Apfelbaum Subject: [PATCH v5 03/21] hw/qdev: introduce qdev_is_realized() helper Date: Thu, 4 May 2023 15:53:09 -0400 Message-Id: <20230504195327.695107-4-stefanha@redhat.com> In-Reply-To: <20230504195327.695107-1-stefanha@redhat.com> References: <20230504195327.695107-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 Add a helper function to check whether the device is realized without requiring the Big QEMU Lock. The next patch adds a second caller. The goal is to avoid spreading DeviceState field accesses throughout the code. Suggested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Hajnoczi --- include/hw/qdev-core.h | 17 ++++++++++++++--- hw/scsi/scsi-bus.c | 3 +-- 2 files changed, 15 insertions(+), 5 deletions(-) diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h index 7623703943..f1070d6dc7 100644 --- a/include/hw/qdev-core.h +++ b/include/hw/qdev-core.h @@ -1,6 +1,7 @@ #ifndef QDEV_CORE_H #define QDEV_CORE_H +#include "qemu/atomic.h" #include "qemu/queue.h" #include "qemu/bitmap.h" #include "qemu/rcu.h" @@ -168,9 +169,6 @@ typedef struct { /** * DeviceState: - * @realized: Indicates whether the device has been fully constructed. - * When accessed outside big qemu lock, must be accessed with - * qatomic_load_acquire() * @reset: ResettableState for the device; handled by Resettable interface. * * This structure should not be accessed directly. We declare it here @@ -339,6 +337,19 @@ DeviceState *qdev_new(const char *name); */ DeviceState *qdev_try_new(const char *name); +/** + * qdev_is_realized: + * @dev: The device to check. + * + * May be called outside big qemu lock. + * + * Returns: %true% if the device has been fully constructed, %false% otherwise. + */ +static inline bool qdev_is_realized(DeviceState *dev) +{ + return qatomic_load_acquire(&dev->realized); +} + /** * qdev_realize: Realize @dev. * @dev: device to realize diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c index 3c20b47ad0..8857ff41f6 100644 --- a/hw/scsi/scsi-bus.c +++ b/hw/scsi/scsi-bus.c @@ -60,8 +60,7 @@ static SCSIDevice *do_scsi_device_find(SCSIBus *bus, * the user access the device. */ - if (retval && !include_unrealized && - !qatomic_load_acquire(&retval->qdev.realized)) { + if (retval && !include_unrealized && !qdev_is_realized(&retval->qdev)) { retval = NULL; } -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Thu May 04 19:53:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:53:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530060.825326 (Exim 4.92) (envelope-from ) id 1puf1G-0003iQ-9K; Thu, 04 May 2023 19:53:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530060.825326; Thu, 04 May 2023 19:53:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf1G-0003iJ-6g; Thu, 04 May 2023 19:53:38 +0000 Received: by outflank-mailman (input) for mailman id 530060; Thu, 04 May 2023 19:53:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf1E-0003iB-Hz for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:53:36 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 598eaa43-eab5-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:53:34 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-600-HQNHFjJIMHiplNqYoaDlwg-1; Thu, 04 May 2023 15:53:31 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8C9BF3813F3C; Thu, 4 May 2023 19:53:30 +0000 (UTC) Received: from localhost (unknown [10.39.192.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id 562674020960; Thu, 4 May 2023 19:53:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 598eaa43-eab5-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683230012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9XCfQf87U8+YhGmnm4aQEFf11a+HXKX39xdjDXLXz/w=; b=PCrWMAxwV6XlwprH9mgZ6MQFY9ox4cOXJ/exukdB+LxPOiGzGAIISueVeSe7ivTIjZzabF WZdQSUV2W7P3vSeEKUF/mr++5RSUlJiqTDjgHCyZCLt13GdDWfPpiVIKbFuCyH9YLZec+u zkpvjssjtSI06mpMte+bpPUVCyElddg= X-MC-Unique: HQNHFjJIMHiplNqYoaDlwg-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Ronnie Sahlberg , Aarushi Mehta , qemu-block@nongnu.org, Paul Durrant , Anthony Perard , Peter Lieven , Stefan Weil , Xie Yongji , Kevin Wolf , Paolo Bonzini , "Michael S. Tsirkin" , Leonardo Bras , Peter Xu , Hanna Reitz , Stefano Stabellini , Richard Henderson , David Woodhouse , Coiby Xu , Eduardo Habkost , Stefano Garzarella , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Stefan Hajnoczi , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Juan Quintela , "Richard W.M. Jones" , Fam Zheng , Marcel Apfelbaum Subject: [PATCH v5 00/21] block: remove aio_disable_external() API Date: Thu, 4 May 2023 15:53:06 -0400 Message-Id: <20230504195327.695107-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 v5: - Use atomic accesses for in_flight counter in vhost-user-server.c [Kevin] - Stash SCSIDevice id/lun values for VIRTIO_SCSI_T_TRANSPORT_RESET event before unrealizing the SCSIDevice [Kevin] - Keep vhost-user-blk export .detach() callback so ctx is set to NULL [Kevin] - Narrow BdrvChildClass and BlockDriver drained_{begin/end/poll} callbacks from IO_OR_GS_CODE() to GLOBAL_STATE_CODE() [Kevin] - Include Kevin's "block: Fix use after free in blockdev_mark_auto_del()" to fix a latent bug that was exposed by this series v4: - Remove external_disable_cnt variable [Philippe] - Add Patch 1 to fix assertion failure in .drained_end() -> blk_get_aio_context() v3: - Resend full patch series. v2 was sent in the middle of a git rebase and was missing patches. [Eric] - Apply Reviewed-by tags. v2: - Do not rely on BlockBackend request queuing, implement .drained_begin/end() instead in xen-block, virtio-blk, and virtio-scsi [Paolo] - Add qdev_is_realized() API [Philippe] - Add patch to avoid AioContext lock around blk_exp_ref/unref() [Paolo] - Add patch to call .drained_begin/end() from main loop thread to simplify callback implementations The aio_disable_external() API temporarily suspends file descriptor monitoring in the event loop. The block layer uses this to prevent new I/O requests being submitted from the guest and elsewhere between bdrv_drained_begin() and bdrv_drained_end(). While the block layer still needs to prevent new I/O requests in drained sections, the aio_disable_external() API can be replaced with .drained_begin/end/poll() callbacks that have been added to BdrvChildClass and BlockDevOps. This newer .bdrained_begin/end/poll() approach is attractive because it works without specifying a specific AioContext. The block layer is moving towards multi-queue and that means multiple AioContexts may be processing I/O simultaneously. The aio_disable_external() was always somewhat hacky. It suspends all file descriptors that were registered with is_external=true, even if they have nothing to do with the BlockDriverState graph nodes that are being drained. It's better to solve a block layer problem in the block layer than to have an odd event loop API solution. The approach in this patch series is to implement BlockDevOps .drained_begin/end() callbacks that temporarily stop file descriptor handlers. This ensures that new I/O requests are not submitted in drained sections. Kevin Wolf (1): block: Fix use after free in blockdev_mark_auto_del() Stefan Hajnoczi (20): block-backend: split blk_do_set_aio_context() hw/qdev: introduce qdev_is_realized() helper virtio-scsi: avoid race between unplug and transport event virtio-scsi: stop using aio_disable_external() during unplug util/vhost-user-server: rename refcount to in_flight counter block/export: wait for vhost-user-blk requests when draining block/export: stop using is_external in vhost-user-blk server hw/xen: do not use aio_set_fd_handler(is_external=true) in xen_xenstore block: add blk_in_drain() API block: drain from main loop thread in bdrv_co_yield_to_drain() xen-block: implement BlockDevOps->drained_begin() hw/xen: do not set is_external=true on evtchn fds block/export: rewrite vduse-blk drain code block/export: don't require AioContext lock around blk_exp_ref/unref() block/fuse: do not set is_external=true on FUSE fd virtio: make it possible to detach host notifier from any thread virtio-blk: implement BlockDevOps->drained_begin() virtio-scsi: implement BlockDevOps->drained_begin() virtio: do not set is_external=true on host notifiers aio: remove aio_disable_external() API hw/block/dataplane/xen-block.h | 2 + include/block/aio.h | 57 --------- include/block/block_int-common.h | 90 +++++++------- include/block/export.h | 2 + include/hw/qdev-core.h | 17 ++- include/hw/scsi/scsi.h | 14 +++ include/qemu/vhost-user-server.h | 8 +- include/sysemu/block-backend-common.h | 25 ++-- include/sysemu/block-backend-global-state.h | 1 + util/aio-posix.h | 1 - block.c | 7 -- block/blkio.c | 15 +-- block/block-backend.c | 78 ++++++------ block/curl.c | 10 +- block/export/export.c | 13 +- block/export/fuse.c | 56 ++++++++- block/export/vduse-blk.c | 128 ++++++++++++++------ block/export/vhost-user-blk-server.c | 52 +++++++- block/io.c | 16 ++- block/io_uring.c | 4 +- block/iscsi.c | 3 +- block/linux-aio.c | 4 +- block/nfs.c | 5 +- block/nvme.c | 8 +- block/ssh.c | 4 +- block/win32-aio.c | 6 +- blockdev.c | 18 ++- hw/block/dataplane/virtio-blk.c | 19 ++- hw/block/dataplane/xen-block.c | 42 +++++-- hw/block/virtio-blk.c | 38 +++++- hw/block/xen-block.c | 24 +++- hw/i386/kvm/xen_xenstore.c | 2 +- hw/scsi/scsi-bus.c | 46 ++++++- hw/scsi/scsi-disk.c | 27 ++++- hw/scsi/virtio-scsi-dataplane.c | 31 +++-- hw/scsi/virtio-scsi.c | 127 ++++++++++++++----- hw/virtio/virtio.c | 6 +- hw/xen/xen-bus.c | 11 +- io/channel-command.c | 6 +- io/channel-file.c | 3 +- io/channel-socket.c | 3 +- migration/rdma.c | 16 +-- tests/unit/test-aio.c | 27 +---- tests/unit/test-bdrv-drain.c | 15 +-- tests/unit/test-fdmon-epoll.c | 73 ----------- util/aio-posix.c | 20 +-- util/aio-win32.c | 8 +- util/async.c | 3 +- util/fdmon-epoll.c | 18 +-- util/fdmon-io_uring.c | 8 +- util/fdmon-poll.c | 3 +- util/main-loop.c | 7 +- util/qemu-coroutine-io.c | 7 +- util/vhost-user-server.c | 33 ++--- hw/scsi/trace-events | 2 + tests/unit/meson.build | 3 - 56 files changed, 738 insertions(+), 534 deletions(-) delete mode 100644 tests/unit/test-fdmon-epoll.c -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Thu May 04 19:53:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:53:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530061.825336 (Exim 4.92) (envelope-from ) id 1puf1L-0003zZ-Nx; Thu, 04 May 2023 19:53:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530061.825336; Thu, 04 May 2023 19:53:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf1L-0003zS-JB; Thu, 04 May 2023 19:53:43 +0000 Received: by outflank-mailman (input) for mailman id 530061; Thu, 04 May 2023 19:53:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf1K-0003xx-MF for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:53:42 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5cb4c55b-eab5-11ed-8611-37d641c3527e; Thu, 04 May 2023 21:53:39 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-558-qVm4RSmtOvC22VNK6fWUTQ-1; Thu, 04 May 2023 15:53:34 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 50FFE101A550; Thu, 4 May 2023 19:53:33 +0000 (UTC) Received: from localhost (unknown [10.39.192.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id 78E421410F29; Thu, 4 May 2023 19:53:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5cb4c55b-eab5-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683230018; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7t7uQFODUsT7GUPKJzVAstWb4vuQdfLqZNy3S4rp+B4=; b=L1ntaQo24O9SYlpe8zmaJ8bo+st/9Q4rwHvj9Zrg8zQnW+ojLaaZQR/FR29jZveEx5Cilv QzWLdGbDJPbRHtkckNKB1ACx9X1I6FV57xGjT0oU3UCV3UF2JKazquhOytbUIQeTe1BrL6 F3A4stphdxrZNMpMl0U1dKu65r7kWLM= X-MC-Unique: qVm4RSmtOvC22VNK6fWUTQ-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Ronnie Sahlberg , Aarushi Mehta , qemu-block@nongnu.org, Paul Durrant , Anthony Perard , Peter Lieven , Stefan Weil , Xie Yongji , Kevin Wolf , Paolo Bonzini , "Michael S. Tsirkin" , Leonardo Bras , Peter Xu , Hanna Reitz , Stefano Stabellini , Richard Henderson , David Woodhouse , Coiby Xu , Eduardo Habkost , Stefano Garzarella , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Stefan Hajnoczi , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Juan Quintela , "Richard W.M. Jones" , Fam Zheng , Marcel Apfelbaum Subject: [PATCH v5 01/21] block: Fix use after free in blockdev_mark_auto_del() Date: Thu, 4 May 2023 15:53:07 -0400 Message-Id: <20230504195327.695107-2-stefanha@redhat.com> In-Reply-To: <20230504195327.695107-1-stefanha@redhat.com> References: <20230504195327.695107-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 From: Kevin Wolf job_cancel_locked() drops the job list lock temporarily and it may call aio_poll(). We must assume that the list has changed after this call. Also, with unlucky timing, it can end up freeing the job during job_completed_txn_abort_locked(), making the job pointer invalid, too. For both reasons, we can't just continue at block_job_next_locked(job). Instead, start at the head of the list again after job_cancel_locked() and skip those jobs that we already cancelled (or that are completing anyway). Signed-off-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Message-Id: <20230503140142.474404-1-kwolf@redhat.com> --- blockdev.c | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/blockdev.c b/blockdev.c index d7b5c18f0a..2c1752a403 100644 --- a/blockdev.c +++ b/blockdev.c @@ -153,12 +153,22 @@ void blockdev_mark_auto_del(BlockBackend *blk) JOB_LOCK_GUARD(); - for (job = block_job_next_locked(NULL); job; - job = block_job_next_locked(job)) { - if (block_job_has_bdrv(job, blk_bs(blk))) { + do { + job = block_job_next_locked(NULL); + while (job && (job->job.cancelled || + job->job.deferred_to_main_loop || + !block_job_has_bdrv(job, blk_bs(blk)))) + { + job = block_job_next_locked(job); + } + if (job) { + /* + * This drops the job lock temporarily and polls, so we need to + * restart processing the list from the start after this. + */ job_cancel_locked(&job->job, false); } - } + } while (job); dinfo->auto_del = 1; } -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Thu May 04 19:53:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:53:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530064.825367 (Exim 4.92) (envelope-from ) id 1puf1R-0004pe-H7; Thu, 04 May 2023 19:53:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530064.825367; Thu, 04 May 2023 19:53:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf1R-0004pT-Bc; Thu, 04 May 2023 19:53:49 +0000 Received: by outflank-mailman (input) for mailman id 530064; Thu, 04 May 2023 19:53:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf1P-0003iB-Vg for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:53:47 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6143fca3-eab5-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:53:47 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-349-OwK9rzciNzal1nFRcpiK8A-1; Thu, 04 May 2023 15:53:42 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 947371C06EDA; Thu, 4 May 2023 19:53:41 +0000 (UTC) Received: from localhost (unknown [10.39.192.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id A983B1121331; Thu, 4 May 2023 19:53:40 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6143fca3-eab5-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683230025; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=efhUpWQleoubyTXms1hMRDqrtRfLyC1vJzKA96dtfK0=; b=bxzTsnMduWC8nIrXWM4GHUKtiPAkZrs3sRFV/V32G3rD3k0zfHga9gOLMBV3sJujIuMZJR u8DRLyMo1t9ILk7VZkh8MdGYfc/kG05b/w53dN1NRANRnJQDCc49jftb3sYyOTWn90yw8v KyaijIWomhMC/kV2gkChFnofYN5MxHQ= X-MC-Unique: OwK9rzciNzal1nFRcpiK8A-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Ronnie Sahlberg , Aarushi Mehta , qemu-block@nongnu.org, Paul Durrant , Anthony Perard , Peter Lieven , Stefan Weil , Xie Yongji , Kevin Wolf , Paolo Bonzini , "Michael S. Tsirkin" , Leonardo Bras , Peter Xu , Hanna Reitz , Stefano Stabellini , Richard Henderson , David Woodhouse , Coiby Xu , Eduardo Habkost , Stefano Garzarella , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Stefan Hajnoczi , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Juan Quintela , "Richard W.M. Jones" , Fam Zheng , Marcel Apfelbaum , Daniil Tatianin Subject: [PATCH v5 04/21] virtio-scsi: avoid race between unplug and transport event Date: Thu, 4 May 2023 15:53:10 -0400 Message-Id: <20230504195327.695107-5-stefanha@redhat.com> In-Reply-To: <20230504195327.695107-1-stefanha@redhat.com> References: <20230504195327.695107-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Only report a transport reset event to the guest after the SCSIDevice has been unrealized by qdev_simple_device_unplug_cb(). qdev_simple_device_unplug_cb() sets the SCSIDevice's qdev.realized field to false so that scsi_device_find/get() no longer see it. scsi_target_emulate_report_luns() also needs to be updated to filter out SCSIDevices that are unrealized. Change virtio_scsi_push_event() to take event information as an argument instead of the SCSIDevice. This allows virtio_scsi_hotunplug() to emit a VIRTIO_SCSI_T_TRANSPORT_RESET event after the SCSIDevice has already been unrealized. These changes ensure that the guest driver does not see the SCSIDevice that's being unplugged if it responds very quickly to the transport reset event. Reviewed-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Reviewed-by: Daniil Tatianin Signed-off-by: Stefan Hajnoczi --- v5: - Stash SCSIDevice id/lun values for VIRTIO_SCSI_T_TRANSPORT_RESET event before unrealizing the SCSIDevice [Kevin] --- hw/scsi/scsi-bus.c | 3 +- hw/scsi/virtio-scsi.c | 86 ++++++++++++++++++++++++++++++------------- 2 files changed, 63 insertions(+), 26 deletions(-) diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c index 8857ff41f6..64013c8a24 100644 --- a/hw/scsi/scsi-bus.c +++ b/hw/scsi/scsi-bus.c @@ -487,7 +487,8 @@ static bool scsi_target_emulate_report_luns(SCSITargetReq *r) DeviceState *qdev = kid->child; SCSIDevice *dev = SCSI_DEVICE(qdev); - if (dev->channel == channel && dev->id == id && dev->lun != 0) { + if (dev->channel == channel && dev->id == id && dev->lun != 0 && + qdev_is_realized(&dev->qdev)) { store_lun(tmp, dev->lun); g_byte_array_append(buf, tmp, 8); len += 8; diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index 612c525d9d..ae314af3de 100644 --- a/hw/scsi/virtio-scsi.c +++ b/hw/scsi/virtio-scsi.c @@ -933,13 +933,27 @@ static void virtio_scsi_reset(VirtIODevice *vdev) s->events_dropped = false; } -static void virtio_scsi_push_event(VirtIOSCSI *s, SCSIDevice *dev, - uint32_t event, uint32_t reason) +typedef struct { + uint32_t event; + uint32_t reason; + union { + /* Used by messages specific to a device */ + struct { + uint32_t id; + uint32_t lun; + } address; + }; +} VirtIOSCSIEventInfo; + +static void virtio_scsi_push_event(VirtIOSCSI *s, + const VirtIOSCSIEventInfo *info) { VirtIOSCSICommon *vs = VIRTIO_SCSI_COMMON(s); VirtIOSCSIReq *req; VirtIOSCSIEvent *evt; VirtIODevice *vdev = VIRTIO_DEVICE(s); + uint32_t event = info->event; + uint32_t reason = info->reason; if (!(vdev->status & VIRTIO_CONFIG_S_DRIVER_OK)) { return; @@ -965,27 +979,28 @@ static void virtio_scsi_push_event(VirtIOSCSI *s, SCSIDevice *dev, memset(evt, 0, sizeof(VirtIOSCSIEvent)); evt->event = virtio_tswap32(vdev, event); evt->reason = virtio_tswap32(vdev, reason); - if (!dev) { - assert(event == VIRTIO_SCSI_T_EVENTS_MISSED); - } else { + if (event != VIRTIO_SCSI_T_EVENTS_MISSED) { evt->lun[0] = 1; - evt->lun[1] = dev->id; + evt->lun[1] = info->address.id; /* Linux wants us to keep the same encoding we use for REPORT LUNS. */ - if (dev->lun >= 256) { - evt->lun[2] = (dev->lun >> 8) | 0x40; + if (info->address.lun >= 256) { + evt->lun[2] = (info->address.lun >> 8) | 0x40; } - evt->lun[3] = dev->lun & 0xFF; + evt->lun[3] = info->address.lun & 0xFF; } trace_virtio_scsi_event(virtio_scsi_get_lun(evt->lun), event, reason); - + virtio_scsi_complete_req(req); } static void virtio_scsi_handle_event_vq(VirtIOSCSI *s, VirtQueue *vq) { if (s->events_dropped) { - virtio_scsi_push_event(s, NULL, VIRTIO_SCSI_T_NO_EVENT, 0); + VirtIOSCSIEventInfo info = { + .event = VIRTIO_SCSI_T_NO_EVENT, + }; + virtio_scsi_push_event(s, &info); } } @@ -1009,9 +1024,17 @@ static void virtio_scsi_change(SCSIBus *bus, SCSIDevice *dev, SCSISense sense) if (virtio_vdev_has_feature(vdev, VIRTIO_SCSI_F_CHANGE) && dev->type != TYPE_ROM) { + VirtIOSCSIEventInfo info = { + .event = VIRTIO_SCSI_T_PARAM_CHANGE, + .reason = sense.asc | (sense.ascq << 8), + .address = { + .id = dev->id, + .lun = dev->lun, + }, + }; + virtio_scsi_acquire(s); - virtio_scsi_push_event(s, dev, VIRTIO_SCSI_T_PARAM_CHANGE, - sense.asc | (sense.ascq << 8)); + virtio_scsi_push_event(s, &info); virtio_scsi_release(s); } } @@ -1046,10 +1069,17 @@ static void virtio_scsi_hotplug(HotplugHandler *hotplug_dev, DeviceState *dev, } if (virtio_vdev_has_feature(vdev, VIRTIO_SCSI_F_HOTPLUG)) { + VirtIOSCSIEventInfo info = { + .event = VIRTIO_SCSI_T_TRANSPORT_RESET, + .reason = VIRTIO_SCSI_EVT_RESET_RESCAN, + .address = { + .id = sd->id, + .lun = sd->lun, + }, + }; + virtio_scsi_acquire(s); - virtio_scsi_push_event(s, sd, - VIRTIO_SCSI_T_TRANSPORT_RESET, - VIRTIO_SCSI_EVT_RESET_RESCAN); + virtio_scsi_push_event(s, &info); scsi_bus_set_ua(&s->bus, SENSE_CODE(REPORTED_LUNS_CHANGED)); virtio_scsi_release(s); } @@ -1062,15 +1092,14 @@ static void virtio_scsi_hotunplug(HotplugHandler *hotplug_dev, DeviceState *dev, VirtIOSCSI *s = VIRTIO_SCSI(vdev); SCSIDevice *sd = SCSI_DEVICE(dev); AioContext *ctx = s->ctx ?: qemu_get_aio_context(); - - if (virtio_vdev_has_feature(vdev, VIRTIO_SCSI_F_HOTPLUG)) { - virtio_scsi_acquire(s); - virtio_scsi_push_event(s, sd, - VIRTIO_SCSI_T_TRANSPORT_RESET, - VIRTIO_SCSI_EVT_RESET_REMOVED); - scsi_bus_set_ua(&s->bus, SENSE_CODE(REPORTED_LUNS_CHANGED)); - virtio_scsi_release(s); - } + VirtIOSCSIEventInfo info = { + .event = VIRTIO_SCSI_T_TRANSPORT_RESET, + .reason = VIRTIO_SCSI_EVT_RESET_REMOVED, + .address = { + .id = sd->id, + .lun = sd->lun, + }, + }; aio_disable_external(ctx); qdev_simple_device_unplug_cb(hotplug_dev, dev, errp); @@ -1082,6 +1111,13 @@ static void virtio_scsi_hotunplug(HotplugHandler *hotplug_dev, DeviceState *dev, blk_set_aio_context(sd->conf.blk, qemu_get_aio_context(), NULL); virtio_scsi_release(s); } + + if (virtio_vdev_has_feature(vdev, VIRTIO_SCSI_F_HOTPLUG)) { + virtio_scsi_acquire(s); + virtio_scsi_push_event(s, &info); + scsi_bus_set_ua(&s->bus, SENSE_CODE(REPORTED_LUNS_CHANGED)); + virtio_scsi_release(s); + } } static struct SCSIBusInfo virtio_scsi_scsi_info = { -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Thu May 04 19:53:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:53:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530065.825376 (Exim 4.92) (envelope-from ) id 1puf1S-00058M-Sn; Thu, 04 May 2023 19:53:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530065.825376; Thu, 04 May 2023 19:53:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf1S-000587-PE; Thu, 04 May 2023 19:53:50 +0000 Received: by outflank-mailman (input) for mailman id 530065; Thu, 04 May 2023 19:53:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf1S-0003iB-6q for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:53:50 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 62cc8225-eab5-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:53:49 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-270-GII9Yb4pMlSDS5YQk3vVsA-1; Thu, 04 May 2023 15:53:45 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 145C8886064; Thu, 4 May 2023 19:53:44 +0000 (UTC) Received: from localhost (unknown [10.39.192.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6F9C31121331; Thu, 4 May 2023 19:53:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 62cc8225-eab5-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683230028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4aDv9+T5dXOUzGaYXYbFqi/phBTNlR0gw0d5Reej/CE=; b=RtWK7gEll8TwVEL8NE+0RnxDxnpO/js06J9+6G+jPK+WKu4bRKOg1RyDV31BTJPu6xh7Ub XST7dTb33KmjjnrNStDzpJuM6jcdxTpgA/SSUaYErf85suAJoB09DR/K9hIOIdF+MAkyy/ QeA4mB/e1Lz09zUD84XJq2L8LI+SCt8= X-MC-Unique: GII9Yb4pMlSDS5YQk3vVsA-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Ronnie Sahlberg , Aarushi Mehta , qemu-block@nongnu.org, Paul Durrant , Anthony Perard , Peter Lieven , Stefan Weil , Xie Yongji , Kevin Wolf , Paolo Bonzini , "Michael S. Tsirkin" , Leonardo Bras , Peter Xu , Hanna Reitz , Stefano Stabellini , Richard Henderson , David Woodhouse , Coiby Xu , Eduardo Habkost , Stefano Garzarella , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Stefan Hajnoczi , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Juan Quintela , "Richard W.M. Jones" , Fam Zheng , Marcel Apfelbaum , Zhengui Li , Daniil Tatianin Subject: [PATCH v5 05/21] virtio-scsi: stop using aio_disable_external() during unplug Date: Thu, 4 May 2023 15:53:11 -0400 Message-Id: <20230504195327.695107-6-stefanha@redhat.com> In-Reply-To: <20230504195327.695107-1-stefanha@redhat.com> References: <20230504195327.695107-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 This patch is part of an effort to remove the aio_disable_external() API because it does not fit in a multi-queue block layer world where many AioContexts may be submitting requests to the same disk. The SCSI emulation code is already in good shape to stop using aio_disable_external(). It was only used by commit 9c5aad84da1c ("virtio-scsi: fixed virtio_scsi_ctx_check failed when detaching scsi disk") to ensure that virtio_scsi_hotunplug() works while the guest driver is submitting I/O. Ensure virtio_scsi_hotunplug() is safe as follows: 1. qdev_simple_device_unplug_cb() -> qdev_unrealize() -> device_set_realized() calls qatomic_set(&dev->realized, false) so that future scsi_device_get() calls return NULL because they exclude SCSIDevices with realized=false. That means virtio-scsi will reject new I/O requests to this SCSIDevice with VIRTIO_SCSI_S_BAD_TARGET even while virtio_scsi_hotunplug() is still executing. We are protected against new requests! 2. scsi_device_unrealize() already contains a call to scsi_device_purge_requests() so that in-flight requests are cancelled synchronously. This ensures that no in-flight requests remain once qdev_simple_device_unplug_cb() returns. Thanks to these two conditions we don't need aio_disable_external() anymore. Cc: Zhengui Li Reviewed-by: Paolo Bonzini Reviewed-by: Daniil Tatianin Signed-off-by: Stefan Hajnoczi --- hw/scsi/virtio-scsi.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index ae314af3de..c1a7ea9ae2 100644 --- a/hw/scsi/virtio-scsi.c +++ b/hw/scsi/virtio-scsi.c @@ -1091,7 +1091,6 @@ static void virtio_scsi_hotunplug(HotplugHandler *hotplug_dev, DeviceState *dev, VirtIODevice *vdev = VIRTIO_DEVICE(hotplug_dev); VirtIOSCSI *s = VIRTIO_SCSI(vdev); SCSIDevice *sd = SCSI_DEVICE(dev); - AioContext *ctx = s->ctx ?: qemu_get_aio_context(); VirtIOSCSIEventInfo info = { .event = VIRTIO_SCSI_T_TRANSPORT_RESET, .reason = VIRTIO_SCSI_EVT_RESET_REMOVED, @@ -1101,9 +1100,7 @@ static void virtio_scsi_hotunplug(HotplugHandler *hotplug_dev, DeviceState *dev, }, }; - aio_disable_external(ctx); qdev_simple_device_unplug_cb(hotplug_dev, dev, errp); - aio_enable_external(ctx); if (s->ctx) { virtio_scsi_acquire(s); -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Thu May 04 19:53:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:53:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530066.825385 (Exim 4.92) (envelope-from ) id 1puf1U-0005Pi-7H; Thu, 04 May 2023 19:53:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530066.825385; Thu, 04 May 2023 19:53:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf1U-0005P9-4L; Thu, 04 May 2023 19:53:52 +0000 Received: by outflank-mailman (input) for mailman id 530066; Thu, 04 May 2023 19:53:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf1T-0003iB-C6 for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:53:51 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6378c682-eab5-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:53:50 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-471-Q3sOoSu5NLOST1Dr08hq8A-1; Thu, 04 May 2023 15:53:48 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D133A811E7B; Thu, 4 May 2023 19:53:46 +0000 (UTC) Received: from localhost (unknown [10.39.192.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id 35F9F1410F29; Thu, 4 May 2023 19:53:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6378c682-eab5-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683230029; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Uh9JsAzQBVO7FYeYzOSkBp65HQ8Exa/aGS/jTv3In5w=; b=EzZQBmmhNU4ngSGJiFO3DnxrSckJJBnghhkyNeVJXLS0C5BOvjHPSqdaNsbAB27GKPdln4 TZPPF56oof8Ztitpzo9qCrWwFS3b2PO6Dbr4/8nfab7sPM5rL6NQnlBwe8oSYm9u2an1Zc lVLQ13sCnnKTIaGjt41I5Qd5tcg/LXo= X-MC-Unique: Q3sOoSu5NLOST1Dr08hq8A-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Ronnie Sahlberg , Aarushi Mehta , qemu-block@nongnu.org, Paul Durrant , Anthony Perard , Peter Lieven , Stefan Weil , Xie Yongji , Kevin Wolf , Paolo Bonzini , "Michael S. Tsirkin" , Leonardo Bras , Peter Xu , Hanna Reitz , Stefano Stabellini , Richard Henderson , David Woodhouse , Coiby Xu , Eduardo Habkost , Stefano Garzarella , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Stefan Hajnoczi , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Juan Quintela , "Richard W.M. Jones" , Fam Zheng , Marcel Apfelbaum Subject: [PATCH v5 06/21] util/vhost-user-server: rename refcount to in_flight counter Date: Thu, 4 May 2023 15:53:12 -0400 Message-Id: <20230504195327.695107-7-stefanha@redhat.com> In-Reply-To: <20230504195327.695107-1-stefanha@redhat.com> References: <20230504195327.695107-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 The VuServer object has a refcount field and ref/unref APIs. The name is confusing because it's actually an in-flight request counter instead of a refcount. Normally a refcount destroys the object upon reaching zero. The VuServer counter is used to wake up the vhost-user coroutine when there are no more requests. Avoid confusing by renaming refcount and ref/unref to in_flight and inc/dec. Reviewed-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Hajnoczi --- include/qemu/vhost-user-server.h | 6 +++--- block/export/vhost-user-blk-server.c | 11 +++++++---- util/vhost-user-server.c | 14 +++++++------- 3 files changed, 17 insertions(+), 14 deletions(-) diff --git a/include/qemu/vhost-user-server.h b/include/qemu/vhost-user-server.h index 25c72433ca..bc0ac9ddb6 100644 --- a/include/qemu/vhost-user-server.h +++ b/include/qemu/vhost-user-server.h @@ -41,7 +41,7 @@ typedef struct { const VuDevIface *vu_iface; /* Protected by ctx lock */ - unsigned int refcount; + unsigned int in_flight; bool wait_idle; VuDev vu_dev; QIOChannel *ioc; /* The I/O channel with the client */ @@ -60,8 +60,8 @@ bool vhost_user_server_start(VuServer *server, void vhost_user_server_stop(VuServer *server); -void vhost_user_server_ref(VuServer *server); -void vhost_user_server_unref(VuServer *server); +void vhost_user_server_inc_in_flight(VuServer *server); +void vhost_user_server_dec_in_flight(VuServer *server); void vhost_user_server_attach_aio_context(VuServer *server, AioContext *ctx); void vhost_user_server_detach_aio_context(VuServer *server); diff --git a/block/export/vhost-user-blk-server.c b/block/export/vhost-user-blk-server.c index e56b92f2e2..841acb36e3 100644 --- a/block/export/vhost-user-blk-server.c +++ b/block/export/vhost-user-blk-server.c @@ -50,7 +50,10 @@ static void vu_blk_req_complete(VuBlkReq *req, size_t in_len) free(req); } -/* Called with server refcount increased, must decrease before returning */ +/* + * Called with server in_flight counter increased, must decrease before + * returning. + */ static void coroutine_fn vu_blk_virtio_process_req(void *opaque) { VuBlkReq *req = opaque; @@ -68,12 +71,12 @@ static void coroutine_fn vu_blk_virtio_process_req(void *opaque) in_num, out_num); if (in_len < 0) { free(req); - vhost_user_server_unref(server); + vhost_user_server_dec_in_flight(server); return; } vu_blk_req_complete(req, in_len); - vhost_user_server_unref(server); + vhost_user_server_dec_in_flight(server); } static void vu_blk_process_vq(VuDev *vu_dev, int idx) @@ -95,7 +98,7 @@ static void vu_blk_process_vq(VuDev *vu_dev, int idx) Coroutine *co = qemu_coroutine_create(vu_blk_virtio_process_req, req); - vhost_user_server_ref(server); + vhost_user_server_inc_in_flight(server); qemu_coroutine_enter(co); } } diff --git a/util/vhost-user-server.c b/util/vhost-user-server.c index 5b6216069c..1622f8cfb3 100644 --- a/util/vhost-user-server.c +++ b/util/vhost-user-server.c @@ -75,16 +75,16 @@ static void panic_cb(VuDev *vu_dev, const char *buf) error_report("vu_panic: %s", buf); } -void vhost_user_server_ref(VuServer *server) +void vhost_user_server_inc_in_flight(VuServer *server) { assert(!server->wait_idle); - server->refcount++; + server->in_flight++; } -void vhost_user_server_unref(VuServer *server) +void vhost_user_server_dec_in_flight(VuServer *server) { - server->refcount--; - if (server->wait_idle && !server->refcount) { + server->in_flight--; + if (server->wait_idle && !server->in_flight) { aio_co_wake(server->co_trip); } } @@ -192,13 +192,13 @@ static coroutine_fn void vu_client_trip(void *opaque) /* Keep running */ } - if (server->refcount) { + if (server->in_flight) { /* Wait for requests to complete before we can unmap the memory */ server->wait_idle = true; qemu_coroutine_yield(); server->wait_idle = false; } - assert(server->refcount == 0); + assert(server->in_flight == 0); vu_deinit(vu_dev); -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Thu May 04 19:53:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:53:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530068.825395 (Exim 4.92) (envelope-from ) id 1puf1Z-0005vK-Gc; Thu, 04 May 2023 19:53:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530068.825395; Thu, 04 May 2023 19:53:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf1Z-0005v2-DY; Thu, 04 May 2023 19:53:57 +0000 Received: by outflank-mailman (input) for mailman id 530068; Thu, 04 May 2023 19:53:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf1Y-0003xx-Bh for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:53:56 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 65cbde11-eab5-11ed-8611-37d641c3527e; Thu, 04 May 2023 21:53:54 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-569-tNtDfOKSMVq3AQX3nRbV7g-1; Thu, 04 May 2023 15:53:50 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 36B9A101A550; Thu, 4 May 2023 19:53:49 +0000 (UTC) Received: from localhost (unknown [10.39.192.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id 931081121339; Thu, 4 May 2023 19:53:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 65cbde11-eab5-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683230033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uqVEulc+YKH8du/OTtIOC0bNRzxnvgw0ufD9riF8H3c=; b=ZXxeazJeqhC4n051eeKdQiY8H06cimgZClzH2ZDzMvw4+Jirga4fZkLq2fKXl3IqTpDd3y F7Zfq75R/q9dufnBuyZDMM++8mpT5R6oOl4MJDfAZ4+tF227ZoXve/MGRIhIzwXI1BuYxu egnWeY26hjGFsmL2XPrSMDcLZIdGZ5s= X-MC-Unique: tNtDfOKSMVq3AQX3nRbV7g-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Ronnie Sahlberg , Aarushi Mehta , qemu-block@nongnu.org, Paul Durrant , Anthony Perard , Peter Lieven , Stefan Weil , Xie Yongji , Kevin Wolf , Paolo Bonzini , "Michael S. Tsirkin" , Leonardo Bras , Peter Xu , Hanna Reitz , Stefano Stabellini , Richard Henderson , David Woodhouse , Coiby Xu , Eduardo Habkost , Stefano Garzarella , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Stefan Hajnoczi , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Juan Quintela , "Richard W.M. Jones" , Fam Zheng , Marcel Apfelbaum Subject: [PATCH v5 07/21] block/export: wait for vhost-user-blk requests when draining Date: Thu, 4 May 2023 15:53:13 -0400 Message-Id: <20230504195327.695107-8-stefanha@redhat.com> In-Reply-To: <20230504195327.695107-1-stefanha@redhat.com> References: <20230504195327.695107-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Each vhost-user-blk request runs in a coroutine. When the BlockBackend enters a drained section we need to enter a quiescent state. Currently any in-flight requests race with bdrv_drained_begin() because it is unaware of vhost-user-blk requests. When blk_co_preadv/pwritev()/etc returns it wakes the bdrv_drained_begin() thread but vhost-user-blk request processing has not yet finished. The request coroutine continues executing while the main loop thread thinks it is in a drained section. One example where this is unsafe is for blk_set_aio_context() where bdrv_drained_begin() is called before .aio_context_detached() and .aio_context_attach(). If request coroutines are still running after bdrv_drained_begin(), then the AioContext could change underneath them and they race with new requests processed in the new AioContext. This could lead to virtqueue corruption, for example. (This example is theoretical, I came across this while reading the code and have not tried to reproduce it.) It's easy to make bdrv_drained_begin() wait for in-flight requests: add a .drained_poll() callback that checks the VuServer's in-flight counter. VuServer just needs an API that returns true when there are requests in flight. The in-flight counter needs to be atomic. Signed-off-by: Stefan Hajnoczi --- v5: - Use atomic accesses for in_flight counter in vhost-user-server.c [Kevin] --- include/qemu/vhost-user-server.h | 4 +++- block/export/vhost-user-blk-server.c | 13 +++++++++++++ util/vhost-user-server.c | 18 ++++++++++++------ 3 files changed, 28 insertions(+), 7 deletions(-) diff --git a/include/qemu/vhost-user-server.h b/include/qemu/vhost-user-server.h index bc0ac9ddb6..b1c1cda886 100644 --- a/include/qemu/vhost-user-server.h +++ b/include/qemu/vhost-user-server.h @@ -40,8 +40,9 @@ typedef struct { int max_queues; const VuDevIface *vu_iface; + unsigned int in_flight; /* atomic */ + /* Protected by ctx lock */ - unsigned int in_flight; bool wait_idle; VuDev vu_dev; QIOChannel *ioc; /* The I/O channel with the client */ @@ -62,6 +63,7 @@ void vhost_user_server_stop(VuServer *server); void vhost_user_server_inc_in_flight(VuServer *server); void vhost_user_server_dec_in_flight(VuServer *server); +bool vhost_user_server_has_in_flight(VuServer *server); void vhost_user_server_attach_aio_context(VuServer *server, AioContext *ctx); void vhost_user_server_detach_aio_context(VuServer *server); diff --git a/block/export/vhost-user-blk-server.c b/block/export/vhost-user-blk-server.c index 841acb36e3..f51a36a14f 100644 --- a/block/export/vhost-user-blk-server.c +++ b/block/export/vhost-user-blk-server.c @@ -272,7 +272,20 @@ static void vu_blk_exp_resize(void *opaque) vu_config_change_msg(&vexp->vu_server.vu_dev); } +/* + * Ensures that bdrv_drained_begin() waits until in-flight requests complete. + * + * Called with vexp->export.ctx acquired. + */ +static bool vu_blk_drained_poll(void *opaque) +{ + VuBlkExport *vexp = opaque; + + return vhost_user_server_has_in_flight(&vexp->vu_server); +} + static const BlockDevOps vu_blk_dev_ops = { + .drained_poll = vu_blk_drained_poll, .resize_cb = vu_blk_exp_resize, }; diff --git a/util/vhost-user-server.c b/util/vhost-user-server.c index 1622f8cfb3..68c3bf162f 100644 --- a/util/vhost-user-server.c +++ b/util/vhost-user-server.c @@ -78,17 +78,23 @@ static void panic_cb(VuDev *vu_dev, const char *buf) void vhost_user_server_inc_in_flight(VuServer *server) { assert(!server->wait_idle); - server->in_flight++; + qatomic_inc(&server->in_flight); } void vhost_user_server_dec_in_flight(VuServer *server) { - server->in_flight--; - if (server->wait_idle && !server->in_flight) { - aio_co_wake(server->co_trip); + if (qatomic_fetch_dec(&server->in_flight) == 1) { + if (server->wait_idle) { + aio_co_wake(server->co_trip); + } } } +bool vhost_user_server_has_in_flight(VuServer *server) +{ + return qatomic_load_acquire(&server->in_flight) > 0; +} + static bool coroutine_fn vu_message_read(VuDev *vu_dev, int conn_fd, VhostUserMsg *vmsg) { @@ -192,13 +198,13 @@ static coroutine_fn void vu_client_trip(void *opaque) /* Keep running */ } - if (server->in_flight) { + if (vhost_user_server_has_in_flight(server)) { /* Wait for requests to complete before we can unmap the memory */ server->wait_idle = true; qemu_coroutine_yield(); server->wait_idle = false; } - assert(server->in_flight == 0); + assert(!vhost_user_server_has_in_flight(server)); vu_deinit(vu_dev); -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Thu May 04 19:54:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:54:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530071.825405 (Exim 4.92) (envelope-from ) id 1puf1c-0006Qe-Ul; Thu, 04 May 2023 19:54:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530071.825405; Thu, 04 May 2023 19:54:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf1c-0006QR-Pu; Thu, 04 May 2023 19:54:00 +0000 Received: by outflank-mailman (input) for mailman id 530071; Thu, 04 May 2023 19:53:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf1b-0003iB-C9 for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:53:59 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 68646d91-eab5-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:53:58 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-544-TbrqFLPtO9Gbo9gH3K6ilQ-1; Thu, 04 May 2023 15:53:55 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1EC7E28004A1; Thu, 4 May 2023 19:53:54 +0000 (UTC) Received: from localhost (unknown [10.39.192.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id 45ECB492C13; Thu, 4 May 2023 19:53:52 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 68646d91-eab5-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683230037; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1fEremRCY5+rqiCKEtAZVyetsPRT+IQwYtOmlYy+nxY=; b=Zdw+c2FzDtVKCppbVvwL+91GFXW8cfH6HTo4hGJJO2IhBtXiMf9BWYn9lBKmCRzhVJA39D m/71AWM8S5TBpsXyc7sbTY7AIpMv/McNADPmaMvm/hSQVujBaYFufkyQJEgvwyI9n0xVtr DoNMVJZIgy/3ZPnUVIpWu7yEwtaJkmQ= X-MC-Unique: TbrqFLPtO9Gbo9gH3K6ilQ-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Ronnie Sahlberg , Aarushi Mehta , qemu-block@nongnu.org, Paul Durrant , Anthony Perard , Peter Lieven , Stefan Weil , Xie Yongji , Kevin Wolf , Paolo Bonzini , "Michael S. Tsirkin" , Leonardo Bras , Peter Xu , Hanna Reitz , Stefano Stabellini , Richard Henderson , David Woodhouse , Coiby Xu , Eduardo Habkost , Stefano Garzarella , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Stefan Hajnoczi , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Juan Quintela , "Richard W.M. Jones" , Fam Zheng , Marcel Apfelbaum , David Woodhouse Subject: [PATCH v5 09/21] hw/xen: do not use aio_set_fd_handler(is_external=true) in xen_xenstore Date: Thu, 4 May 2023 15:53:15 -0400 Message-Id: <20230504195327.695107-10-stefanha@redhat.com> In-Reply-To: <20230504195327.695107-1-stefanha@redhat.com> References: <20230504195327.695107-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 There is no need to suspend activity between aio_disable_external() and aio_enable_external(), which is mainly used for the block layer's drain operation. This is part of ongoing work to remove the aio_disable_external() API. Reviewed-by: David Woodhouse Reviewed-by: Paul Durrant Signed-off-by: Stefan Hajnoczi --- hw/i386/kvm/xen_xenstore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/kvm/xen_xenstore.c b/hw/i386/kvm/xen_xenstore.c index 900679af8a..6e81bc8791 100644 --- a/hw/i386/kvm/xen_xenstore.c +++ b/hw/i386/kvm/xen_xenstore.c @@ -133,7 +133,7 @@ static void xen_xenstore_realize(DeviceState *dev, Error **errp) error_setg(errp, "Xenstore evtchn port init failed"); return; } - aio_set_fd_handler(qemu_get_aio_context(), xen_be_evtchn_fd(s->eh), true, + aio_set_fd_handler(qemu_get_aio_context(), xen_be_evtchn_fd(s->eh), false, xen_xenstore_event, NULL, NULL, NULL, s); s->impl = xs_impl_create(xen_domid); -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Thu May 04 19:54:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:54:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530072.825412 (Exim 4.92) (envelope-from ) id 1puf1d-0006UN-HU; Thu, 04 May 2023 19:54:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530072.825412; Thu, 04 May 2023 19:54:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf1d-0006Ta-5U; Thu, 04 May 2023 19:54:01 +0000 Received: by outflank-mailman (input) for mailman id 530072; Thu, 04 May 2023 19:54:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf1c-0003xx-Ev for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:54:00 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 686588fd-eab5-11ed-8611-37d641c3527e; Thu, 04 May 2023 21:53:58 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-610-ZoYT6p5PP2qo_FQgwkpEwA-1; Thu, 04 May 2023 15:53:52 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 822BD185A78B; Thu, 4 May 2023 19:53:51 +0000 (UTC) Received: from localhost (unknown [10.39.192.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id E35D84020960; Thu, 4 May 2023 19:53:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 686588fd-eab5-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683230037; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9wCNZYyVdjWaoTznBC2Ylnqhccg5NnPq2nFPN+RMgeA=; b=gn2qlPFGkA6wq44f0pNjMqZc6MsNtnVMUSDckB9UI1xTHwv6IDfMKvekI7Ys4wOojFka3y st6usqnqwFeV5Fh4N8wuAv6YRxmJUyRCjknlVJjLFgATm8oGDryLDytx4GxsDMp46N65WT orxFiyYfYSt3UD3Lng0+W9bipT7njbM= X-MC-Unique: ZoYT6p5PP2qo_FQgwkpEwA-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Ronnie Sahlberg , Aarushi Mehta , qemu-block@nongnu.org, Paul Durrant , Anthony Perard , Peter Lieven , Stefan Weil , Xie Yongji , Kevin Wolf , Paolo Bonzini , "Michael S. Tsirkin" , Leonardo Bras , Peter Xu , Hanna Reitz , Stefano Stabellini , Richard Henderson , David Woodhouse , Coiby Xu , Eduardo Habkost , Stefano Garzarella , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Stefan Hajnoczi , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Juan Quintela , "Richard W.M. Jones" , Fam Zheng , Marcel Apfelbaum Subject: [PATCH v5 08/21] block/export: stop using is_external in vhost-user-blk server Date: Thu, 4 May 2023 15:53:14 -0400 Message-Id: <20230504195327.695107-9-stefanha@redhat.com> In-Reply-To: <20230504195327.695107-1-stefanha@redhat.com> References: <20230504195327.695107-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 vhost-user activity must be suspended during bdrv_drained_begin/end(). This prevents new requests from interfering with whatever is happening in the drained section. Previously this was done using aio_set_fd_handler()'s is_external argument. In a multi-queue block layer world the aio_disable_external() API cannot be used since multiple AioContext may be processing I/O, not just one. Switch to BlockDevOps->drained_begin/end() callbacks. Signed-off-by: Stefan Hajnoczi --- block/export/vhost-user-blk-server.c | 28 ++++++++++++++++++++++++++-- util/vhost-user-server.c | 10 +++++----- 2 files changed, 31 insertions(+), 7 deletions(-) diff --git a/block/export/vhost-user-blk-server.c b/block/export/vhost-user-blk-server.c index f51a36a14f..81b59761e3 100644 --- a/block/export/vhost-user-blk-server.c +++ b/block/export/vhost-user-blk-server.c @@ -212,15 +212,21 @@ static void blk_aio_attached(AioContext *ctx, void *opaque) { VuBlkExport *vexp = opaque; + /* + * The actual attach will happen in vu_blk_drained_end() and we just + * restore ctx here. + */ vexp->export.ctx = ctx; - vhost_user_server_attach_aio_context(&vexp->vu_server, ctx); } static void blk_aio_detach(void *opaque) { VuBlkExport *vexp = opaque; - vhost_user_server_detach_aio_context(&vexp->vu_server); + /* + * The actual detach already happened in vu_blk_drained_begin() but from + * this point on we must not access ctx anymore. + */ vexp->export.ctx = NULL; } @@ -272,6 +278,22 @@ static void vu_blk_exp_resize(void *opaque) vu_config_change_msg(&vexp->vu_server.vu_dev); } +/* Called with vexp->export.ctx acquired */ +static void vu_blk_drained_begin(void *opaque) +{ + VuBlkExport *vexp = opaque; + + vhost_user_server_detach_aio_context(&vexp->vu_server); +} + +/* Called with vexp->export.blk AioContext acquired */ +static void vu_blk_drained_end(void *opaque) +{ + VuBlkExport *vexp = opaque; + + vhost_user_server_attach_aio_context(&vexp->vu_server, vexp->export.ctx); +} + /* * Ensures that bdrv_drained_begin() waits until in-flight requests complete. * @@ -285,6 +307,8 @@ static bool vu_blk_drained_poll(void *opaque) } static const BlockDevOps vu_blk_dev_ops = { + .drained_begin = vu_blk_drained_begin, + .drained_end = vu_blk_drained_end, .drained_poll = vu_blk_drained_poll, .resize_cb = vu_blk_exp_resize, }; diff --git a/util/vhost-user-server.c b/util/vhost-user-server.c index 68c3bf162f..a12b2d1bba 100644 --- a/util/vhost-user-server.c +++ b/util/vhost-user-server.c @@ -278,7 +278,7 @@ set_watch(VuDev *vu_dev, int fd, int vu_evt, vu_fd_watch->fd = fd; vu_fd_watch->cb = cb; qemu_socket_set_nonblock(fd); - aio_set_fd_handler(server->ioc->ctx, fd, true, kick_handler, + aio_set_fd_handler(server->ioc->ctx, fd, false, kick_handler, NULL, NULL, NULL, vu_fd_watch); vu_fd_watch->vu_dev = vu_dev; vu_fd_watch->pvt = pvt; @@ -299,7 +299,7 @@ static void remove_watch(VuDev *vu_dev, int fd) if (!vu_fd_watch) { return; } - aio_set_fd_handler(server->ioc->ctx, fd, true, + aio_set_fd_handler(server->ioc->ctx, fd, false, NULL, NULL, NULL, NULL, NULL); QTAILQ_REMOVE(&server->vu_fd_watches, vu_fd_watch, next); @@ -362,7 +362,7 @@ void vhost_user_server_stop(VuServer *server) VuFdWatch *vu_fd_watch; QTAILQ_FOREACH(vu_fd_watch, &server->vu_fd_watches, next) { - aio_set_fd_handler(server->ctx, vu_fd_watch->fd, true, + aio_set_fd_handler(server->ctx, vu_fd_watch->fd, false, NULL, NULL, NULL, NULL, vu_fd_watch); } @@ -403,7 +403,7 @@ void vhost_user_server_attach_aio_context(VuServer *server, AioContext *ctx) qio_channel_attach_aio_context(server->ioc, ctx); QTAILQ_FOREACH(vu_fd_watch, &server->vu_fd_watches, next) { - aio_set_fd_handler(ctx, vu_fd_watch->fd, true, kick_handler, NULL, + aio_set_fd_handler(ctx, vu_fd_watch->fd, false, kick_handler, NULL, NULL, NULL, vu_fd_watch); } @@ -417,7 +417,7 @@ void vhost_user_server_detach_aio_context(VuServer *server) VuFdWatch *vu_fd_watch; QTAILQ_FOREACH(vu_fd_watch, &server->vu_fd_watches, next) { - aio_set_fd_handler(server->ctx, vu_fd_watch->fd, true, + aio_set_fd_handler(server->ctx, vu_fd_watch->fd, false, NULL, NULL, NULL, NULL, vu_fd_watch); } -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Thu May 04 19:54:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:54:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530078.825426 (Exim 4.92) (envelope-from ) id 1puf1l-0007Rz-QR; Thu, 04 May 2023 19:54:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530078.825426; Thu, 04 May 2023 19:54:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf1l-0007Ro-NM; Thu, 04 May 2023 19:54:09 +0000 Received: by outflank-mailman (input) for mailman id 530078; Thu, 04 May 2023 19:54:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf1j-0003xx-U2 for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:54:07 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6c9f016d-eab5-11ed-8611-37d641c3527e; Thu, 04 May 2023 21:54:05 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-578-Mxyocj34PQiIzWFYqCzlBA-1; Thu, 04 May 2023 15:53:57 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7FA16109DCE6; Thu, 4 May 2023 19:53:56 +0000 (UTC) Received: from localhost (unknown [10.39.192.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id E89F34020960; Thu, 4 May 2023 19:53:55 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6c9f016d-eab5-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683230044; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SzNG6z7bzqGXyIR92raSnZpugRplPdo5zETBQKXUCHA=; b=HuZdHGRXreTp69OP9K9ShnZSxMlFkSYNxaNfgU40Dh5apVw4fFYKQ1MjBbDdhKwyVqsayC 8t0WiBpvdljL/PWCpz4FGcFUfIaa/cbl06Nvl4e115j4dYbbrYE+8MGgHodhOuWSZ+8okM 1qxI8WvlLw2QBnF3UDW5fzoPjYyUhMs= X-MC-Unique: Mxyocj34PQiIzWFYqCzlBA-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Ronnie Sahlberg , Aarushi Mehta , qemu-block@nongnu.org, Paul Durrant , Anthony Perard , Peter Lieven , Stefan Weil , Xie Yongji , Kevin Wolf , Paolo Bonzini , "Michael S. Tsirkin" , Leonardo Bras , Peter Xu , Hanna Reitz , Stefano Stabellini , Richard Henderson , David Woodhouse , Coiby Xu , Eduardo Habkost , Stefano Garzarella , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Stefan Hajnoczi , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Juan Quintela , "Richard W.M. Jones" , Fam Zheng , Marcel Apfelbaum Subject: [PATCH v5 10/21] block: add blk_in_drain() API Date: Thu, 4 May 2023 15:53:16 -0400 Message-Id: <20230504195327.695107-11-stefanha@redhat.com> In-Reply-To: <20230504195327.695107-1-stefanha@redhat.com> References: <20230504195327.695107-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 The BlockBackend quiesce_counter is greater than zero during drained sections. Add an API to check whether the BlockBackend is in a drained section. The next patch will use this API. Signed-off-by: Stefan Hajnoczi --- include/sysemu/block-backend-global-state.h | 1 + block/block-backend.c | 7 +++++++ 2 files changed, 8 insertions(+) diff --git a/include/sysemu/block-backend-global-state.h b/include/sysemu/block-backend-global-state.h index 2b6d27db7c..ac7cbd6b5e 100644 --- a/include/sysemu/block-backend-global-state.h +++ b/include/sysemu/block-backend-global-state.h @@ -78,6 +78,7 @@ void blk_activate(BlockBackend *blk, Error **errp); int blk_make_zero(BlockBackend *blk, BdrvRequestFlags flags); void blk_aio_cancel(BlockAIOCB *acb); int blk_commit_all(void); +bool blk_in_drain(BlockBackend *blk); void blk_drain(BlockBackend *blk); void blk_drain_all(void); void blk_set_on_error(BlockBackend *blk, BlockdevOnError on_read_error, diff --git a/block/block-backend.c b/block/block-backend.c index 68d38635bc..96f03cae95 100644 --- a/block/block-backend.c +++ b/block/block-backend.c @@ -1270,6 +1270,13 @@ blk_check_byte_request(BlockBackend *blk, int64_t offset, int64_t bytes) return 0; } +/* Are we currently in a drained section? */ +bool blk_in_drain(BlockBackend *blk) +{ + GLOBAL_STATE_CODE(); /* change to IO_OR_GS_CODE(), if necessary */ + return qatomic_read(&blk->quiesce_counter); +} + /* To be called between exactly one pair of blk_inc/dec_in_flight() */ static void coroutine_fn blk_wait_while_drained(BlockBackend *blk) { -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Thu May 04 19:54:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:54:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530079.825433 (Exim 4.92) (envelope-from ) id 1puf1m-0007We-B9; Thu, 04 May 2023 19:54:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530079.825433; Thu, 04 May 2023 19:54:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf1m-0007V5-1A; Thu, 04 May 2023 19:54:10 +0000 Received: by outflank-mailman (input) for mailman id 530079; Thu, 04 May 2023 19:54:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf1k-0003xx-DI for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:54:08 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6c75c70b-eab5-11ed-8611-37d641c3527e; Thu, 04 May 2023 21:54:05 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-83-mf16-bP3ON6rSVB1WZdIzA-1; Thu, 04 May 2023 15:54:00 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E5EB4101A531; Thu, 4 May 2023 19:53:58 +0000 (UTC) Received: from localhost (unknown [10.39.192.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id 00AB54020962; Thu, 4 May 2023 19:53:57 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6c75c70b-eab5-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683230044; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TaJhEzn2xnk+TJZ+4gZYO3ndhDET6IVJHLdTW4Bnkp0=; b=OkR7Xgyrk9DRZ+GmfacqrWgXZ781Uwvtp77CWlpRDdaciJmLhCObMpDc78EIFyvv4qQ1ri 3co3ZB8Ber+KuqHQ91JXqRvsszqqCjSqyy5DNy+AQWoc286ncoAKHFaduZxCZOgSSONzv2 nGIRnXaUVCCnmXlw8aCYF7LfwZMNhmc= X-MC-Unique: mf16-bP3ON6rSVB1WZdIzA-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Ronnie Sahlberg , Aarushi Mehta , qemu-block@nongnu.org, Paul Durrant , Anthony Perard , Peter Lieven , Stefan Weil , Xie Yongji , Kevin Wolf , Paolo Bonzini , "Michael S. Tsirkin" , Leonardo Bras , Peter Xu , Hanna Reitz , Stefano Stabellini , Richard Henderson , David Woodhouse , Coiby Xu , Eduardo Habkost , Stefano Garzarella , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Stefan Hajnoczi , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Juan Quintela , "Richard W.M. Jones" , Fam Zheng , Marcel Apfelbaum Subject: [PATCH v5 11/21] block: drain from main loop thread in bdrv_co_yield_to_drain() Date: Thu, 4 May 2023 15:53:17 -0400 Message-Id: <20230504195327.695107-12-stefanha@redhat.com> In-Reply-To: <20230504195327.695107-1-stefanha@redhat.com> References: <20230504195327.695107-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 For simplicity, always run BlockDevOps .drained_begin/end/poll() callbacks in the main loop thread. This makes it easier to implement the callbacks and avoids extra locks. Move the function pointer declarations from the I/O Code section to the Global State section for BlockDevOps, BdrvChildClass, and BlockDriver. Narrow IO_OR_GS_CODE() to GLOBAL_STATE_CODE() where appropriate. The test-bdrv-drain test case calls bdrv_drain() from an IOThread. This is now only allowed from coroutine context, so update the test case to run in a coroutine. Signed-off-by: Stefan Hajnoczi --- include/block/block_int-common.h | 90 +++++++++++++-------------- include/sysemu/block-backend-common.h | 25 ++++---- block/io.c | 14 +++-- tests/unit/test-bdrv-drain.c | 14 +++-- 4 files changed, 76 insertions(+), 67 deletions(-) diff --git a/include/block/block_int-common.h b/include/block/block_int-common.h index 013d419444..f462a8be55 100644 --- a/include/block/block_int-common.h +++ b/include/block/block_int-common.h @@ -356,6 +356,21 @@ struct BlockDriver { void (*bdrv_attach_aio_context)(BlockDriverState *bs, AioContext *new_context); + /** + * bdrv_drain_begin is called if implemented in the beginning of a + * drain operation to drain and stop any internal sources of requests in + * the driver. + * bdrv_drain_end is called if implemented at the end of the drain. + * + * They should be used by the driver to e.g. manage scheduled I/O + * requests, or toggle an internal state. After the end of the drain new + * requests will continue normally. + * + * Implementations of both functions must not call aio_poll(). + */ + void (*bdrv_drain_begin)(BlockDriverState *bs); + void (*bdrv_drain_end)(BlockDriverState *bs); + /** * Try to get @bs's logical and physical block size. * On success, store them in @bsz and return zero. @@ -743,21 +758,6 @@ struct BlockDriver { void coroutine_fn GRAPH_RDLOCK_PTR (*bdrv_co_io_unplug)( BlockDriverState *bs); - /** - * bdrv_drain_begin is called if implemented in the beginning of a - * drain operation to drain and stop any internal sources of requests in - * the driver. - * bdrv_drain_end is called if implemented at the end of the drain. - * - * They should be used by the driver to e.g. manage scheduled I/O - * requests, or toggle an internal state. After the end of the drain new - * requests will continue normally. - * - * Implementations of both functions must not call aio_poll(). - */ - void (*bdrv_drain_begin)(BlockDriverState *bs); - void (*bdrv_drain_end)(BlockDriverState *bs); - bool (*bdrv_supports_persistent_dirty_bitmap)(BlockDriverState *bs); bool coroutine_fn GRAPH_RDLOCK_PTR (*bdrv_co_can_store_new_dirty_bitmap)( @@ -920,36 +920,6 @@ struct BdrvChildClass { void GRAPH_WRLOCK_PTR (*attach)(BdrvChild *child); void GRAPH_WRLOCK_PTR (*detach)(BdrvChild *child); - /* - * Notifies the parent that the filename of its child has changed (e.g. - * because the direct child was removed from the backing chain), so that it - * can update its reference. - */ - int (*update_filename)(BdrvChild *child, BlockDriverState *new_base, - const char *filename, Error **errp); - - bool (*change_aio_ctx)(BdrvChild *child, AioContext *ctx, - GHashTable *visited, Transaction *tran, - Error **errp); - - /* - * I/O API functions. These functions are thread-safe. - * - * See include/block/block-io.h for more information about - * the I/O API. - */ - - void (*resize)(BdrvChild *child); - - /* - * Returns a name that is supposedly more useful for human users than the - * node name for identifying the node in question (in particular, a BB - * name), or NULL if the parent can't provide a better name. - */ - const char *(*get_name)(BdrvChild *child); - - AioContext *(*get_parent_aio_context)(BdrvChild *child); - /* * If this pair of functions is implemented, the parent doesn't issue new * requests after returning from .drained_begin() until .drained_end() is @@ -970,6 +940,36 @@ struct BdrvChildClass { * activity on the child has stopped. */ bool (*drained_poll)(BdrvChild *child); + + /* + * Notifies the parent that the filename of its child has changed (e.g. + * because the direct child was removed from the backing chain), so that it + * can update its reference. + */ + int (*update_filename)(BdrvChild *child, BlockDriverState *new_base, + const char *filename, Error **errp); + + bool (*change_aio_ctx)(BdrvChild *child, AioContext *ctx, + GHashTable *visited, Transaction *tran, + Error **errp); + + /* + * I/O API functions. These functions are thread-safe. + * + * See include/block/block-io.h for more information about + * the I/O API. + */ + + void (*resize)(BdrvChild *child); + + /* + * Returns a name that is supposedly more useful for human users than the + * node name for identifying the node in question (in particular, a BB + * name), or NULL if the parent can't provide a better name. + */ + const char *(*get_name)(BdrvChild *child); + + AioContext *(*get_parent_aio_context)(BdrvChild *child); }; extern const BdrvChildClass child_of_bds; diff --git a/include/sysemu/block-backend-common.h b/include/sysemu/block-backend-common.h index 2391679c56..780cea7305 100644 --- a/include/sysemu/block-backend-common.h +++ b/include/sysemu/block-backend-common.h @@ -59,6 +59,19 @@ typedef struct BlockDevOps { */ bool (*is_medium_locked)(void *opaque); + /* + * Runs when the backend receives a drain request. + */ + void (*drained_begin)(void *opaque); + /* + * Runs when the backend's last drain request ends. + */ + void (*drained_end)(void *opaque); + /* + * Is the device still busy? + */ + bool (*drained_poll)(void *opaque); + /* * I/O API functions. These functions are thread-safe. * @@ -76,18 +89,6 @@ typedef struct BlockDevOps { * Runs when the size changed (e.g. monitor command block_resize) */ void (*resize_cb)(void *opaque); - /* - * Runs when the backend receives a drain request. - */ - void (*drained_begin)(void *opaque); - /* - * Runs when the backend's last drain request ends. - */ - void (*drained_end)(void *opaque); - /* - * Is the device still busy? - */ - bool (*drained_poll)(void *opaque); } BlockDevOps; /* diff --git a/block/io.c b/block/io.c index 6fa1993374..532c8c90c9 100644 --- a/block/io.c +++ b/block/io.c @@ -60,7 +60,7 @@ static void bdrv_parent_drained_begin(BlockDriverState *bs, BdrvChild *ignore) void bdrv_parent_drained_end_single(BdrvChild *c) { - IO_OR_GS_CODE(); + GLOBAL_STATE_CODE(); assert(c->quiesced_parent); c->quiesced_parent = false; @@ -108,7 +108,7 @@ static bool bdrv_parent_drained_poll(BlockDriverState *bs, BdrvChild *ignore, void bdrv_parent_drained_begin_single(BdrvChild *c) { - IO_OR_GS_CODE(); + GLOBAL_STATE_CODE(); assert(!c->quiesced_parent); c->quiesced_parent = true; @@ -248,7 +248,7 @@ typedef struct { bool bdrv_drain_poll(BlockDriverState *bs, BdrvChild *ignore_parent, bool ignore_bds_parents) { - IO_OR_GS_CODE(); + GLOBAL_STATE_CODE(); if (bdrv_parent_drained_poll(bs, ignore_parent, ignore_bds_parents)) { return true; @@ -335,7 +335,8 @@ static void coroutine_fn bdrv_co_yield_to_drain(BlockDriverState *bs, if (ctx != co_ctx) { aio_context_release(ctx); } - replay_bh_schedule_oneshot_event(ctx, bdrv_co_drain_bh_cb, &data); + replay_bh_schedule_oneshot_event(qemu_get_aio_context(), + bdrv_co_drain_bh_cb, &data); qemu_coroutine_yield(); /* If we are resumed from some other event (such as an aio completion or a @@ -358,6 +359,8 @@ static void bdrv_do_drained_begin(BlockDriverState *bs, BdrvChild *parent, return; } + GLOBAL_STATE_CODE(); + /* Stop things in parent-to-child order */ if (qatomic_fetch_inc(&bs->quiesce_counter) == 0) { aio_disable_external(bdrv_get_aio_context(bs)); @@ -400,11 +403,14 @@ static void bdrv_do_drained_end(BlockDriverState *bs, BdrvChild *parent) { int old_quiesce_counter; + IO_OR_GS_CODE(); + if (qemu_in_coroutine()) { bdrv_co_yield_to_drain(bs, false, parent, false); return; } assert(bs->quiesce_counter > 0); + GLOBAL_STATE_CODE(); /* Re-enable things in child-to-parent order */ old_quiesce_counter = qatomic_fetch_dec(&bs->quiesce_counter); diff --git a/tests/unit/test-bdrv-drain.c b/tests/unit/test-bdrv-drain.c index d9d3807062..dc3cb9e0e3 100644 --- a/tests/unit/test-bdrv-drain.c +++ b/tests/unit/test-bdrv-drain.c @@ -445,19 +445,19 @@ struct test_iothread_data { BlockDriverState *bs; enum drain_type drain_type; int *aio_ret; + bool co_done; }; -static void test_iothread_drain_entry(void *opaque) +static void coroutine_fn test_iothread_drain_co_entry(void *opaque) { struct test_iothread_data *data = opaque; - aio_context_acquire(bdrv_get_aio_context(data->bs)); do_drain_begin(data->drain_type, data->bs); g_assert_cmpint(*data->aio_ret, ==, 0); do_drain_end(data->drain_type, data->bs); - aio_context_release(bdrv_get_aio_context(data->bs)); - qemu_event_set(&done_event); + data->co_done = true; + aio_wait_kick(); } static void test_iothread_aio_cb(void *opaque, int ret) @@ -493,6 +493,7 @@ static void test_iothread_common(enum drain_type drain_type, int drain_thread) BlockDriverState *bs; BDRVTestState *s; BlockAIOCB *acb; + Coroutine *co; int aio_ret; struct test_iothread_data data; @@ -571,8 +572,9 @@ static void test_iothread_common(enum drain_type drain_type, int drain_thread) } break; case 1: - aio_bh_schedule_oneshot(ctx_a, test_iothread_drain_entry, &data); - qemu_event_wait(&done_event); + co = qemu_coroutine_create(test_iothread_drain_co_entry, &data); + aio_co_enter(ctx_a, co); + AIO_WAIT_WHILE_UNLOCKED(NULL, !data.co_done); break; default: g_assert_not_reached(); -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Thu May 04 19:59:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:59:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530094.825455 (Exim 4.92) (envelope-from ) id 1puf6o-0002Ox-4N; Thu, 04 May 2023 19:59:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530094.825455; Thu, 04 May 2023 19:59:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf6o-0002Oq-1a; Thu, 04 May 2023 19:59:22 +0000 Received: by outflank-mailman (input) for mailman id 530094; Thu, 04 May 2023 19:59:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf28-0003xx-K8 for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:54:32 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7b8f1ab9-eab5-11ed-8611-37d641c3527e; Thu, 04 May 2023 21:54:31 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-595-i1TCEUOyPMCxwUb6LaaevA-1; Thu, 04 May 2023 15:54:24 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A91B5811E7E; Thu, 4 May 2023 19:54:23 +0000 (UTC) Received: from localhost (unknown [10.39.192.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0E16B2166B31; Thu, 4 May 2023 19:54:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7b8f1ab9-eab5-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683230069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=peUabVxpb/f9SoCESFgzNkXObwSbZ6ll4imnzO2kIyY=; b=XoxQ/jxHYPKvkrOMDt7ssACzd/kVn1YwMjKNc5bk+7ES57V+Hchp9ORuWVUdH7ZbuIL7My 4ifEBGnlRAzo5DaMTj/T0Ze2lIe+yTFodtd+WYzg76uEg7TuJiPTfQJFRj69Zx567QsavY Zwc2tIB1tAnRDW/UOkGVdVHaJJ+/wSs= X-MC-Unique: i1TCEUOyPMCxwUb6LaaevA-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Ronnie Sahlberg , Aarushi Mehta , qemu-block@nongnu.org, Paul Durrant , Anthony Perard , Peter Lieven , Stefan Weil , Xie Yongji , Kevin Wolf , Paolo Bonzini , "Michael S. Tsirkin" , Leonardo Bras , Peter Xu , Hanna Reitz , Stefano Stabellini , Richard Henderson , David Woodhouse , Coiby Xu , Eduardo Habkost , Stefano Garzarella , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Stefan Hajnoczi , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Juan Quintela , "Richard W.M. Jones" , Fam Zheng , Marcel Apfelbaum Subject: [PATCH v5 20/21] virtio: do not set is_external=true on host notifiers Date: Thu, 4 May 2023 15:53:26 -0400 Message-Id: <20230504195327.695107-21-stefanha@redhat.com> In-Reply-To: <20230504195327.695107-1-stefanha@redhat.com> References: <20230504195327.695107-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Host notifiers can now use is_external=false since virtio-blk and virtio-scsi no longer rely on is_external=true for drained sections. Signed-off-by: Stefan Hajnoczi --- hw/virtio/virtio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 272d930721..9cdad7e550 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -3491,7 +3491,7 @@ static void virtio_queue_host_notifier_aio_poll_end(EventNotifier *n) void virtio_queue_aio_attach_host_notifier(VirtQueue *vq, AioContext *ctx) { - aio_set_event_notifier(ctx, &vq->host_notifier, true, + aio_set_event_notifier(ctx, &vq->host_notifier, false, virtio_queue_host_notifier_read, virtio_queue_host_notifier_aio_poll, virtio_queue_host_notifier_aio_poll_ready); @@ -3508,14 +3508,14 @@ void virtio_queue_aio_attach_host_notifier(VirtQueue *vq, AioContext *ctx) */ void virtio_queue_aio_attach_host_notifier_no_poll(VirtQueue *vq, AioContext *ctx) { - aio_set_event_notifier(ctx, &vq->host_notifier, true, + aio_set_event_notifier(ctx, &vq->host_notifier, false, virtio_queue_host_notifier_read, NULL, NULL); } void virtio_queue_aio_detach_host_notifier(VirtQueue *vq, AioContext *ctx) { - aio_set_event_notifier(ctx, &vq->host_notifier, true, NULL, NULL, NULL); + aio_set_event_notifier(ctx, &vq->host_notifier, false, NULL, NULL, NULL); /* Test and clear notifier before after disabling event, * in case poll callback didn't have time to run. */ virtio_queue_host_notifier_read(&vq->host_notifier); -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Thu May 04 19:59:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:59:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530093.825446 (Exim 4.92) (envelope-from ) id 1puf6l-00029b-TE; Thu, 04 May 2023 19:59:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530093.825446; Thu, 04 May 2023 19:59:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf6l-00029U-QM; Thu, 04 May 2023 19:59:19 +0000 Received: by outflank-mailman (input) for mailman id 530093; Thu, 04 May 2023 19:59:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf1v-0003xx-QK for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:54:19 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 732726f0-eab5-11ed-8611-37d641c3527e; Thu, 04 May 2023 21:54:16 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-311-pmj5n48DPI265atIoUKLhQ-1; Thu, 04 May 2023 15:54:12 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 78EBA855304; Thu, 4 May 2023 19:54:11 +0000 (UTC) Received: from localhost (unknown [10.39.192.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id DB4002166B30; Thu, 4 May 2023 19:54:10 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 732726f0-eab5-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683230055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pXsgzUQNPWG1ZQh/g83GoR8nnGiyShUYhUlRFMynpck=; b=LLvQInOb3cY5EaZPXCFCBQngtWgL2hlRshh00E2VEU/8EUi3VryPt+evBdNGoje4Ifbzeq ubrqBZEy6RlpJtvugbWI2NJTZUCJOhBfjzoB6YhQ2+yrQjZ8v0/c9254je/izmLXQvKx2D CqOWg14P8OWSNDy+XUKUU/BoZ+25+P4= X-MC-Unique: pmj5n48DPI265atIoUKLhQ-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Ronnie Sahlberg , Aarushi Mehta , qemu-block@nongnu.org, Paul Durrant , Anthony Perard , Peter Lieven , Stefan Weil , Xie Yongji , Kevin Wolf , Paolo Bonzini , "Michael S. Tsirkin" , Leonardo Bras , Peter Xu , Hanna Reitz , Stefano Stabellini , Richard Henderson , David Woodhouse , Coiby Xu , Eduardo Habkost , Stefano Garzarella , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Stefan Hajnoczi , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Juan Quintela , "Richard W.M. Jones" , Fam Zheng , Marcel Apfelbaum Subject: [PATCH v5 16/21] block/fuse: do not set is_external=true on FUSE fd Date: Thu, 4 May 2023 15:53:22 -0400 Message-Id: <20230504195327.695107-17-stefanha@redhat.com> In-Reply-To: <20230504195327.695107-1-stefanha@redhat.com> References: <20230504195327.695107-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 This is part of ongoing work to remove the aio_disable_external() API. Use BlockDevOps .drained_begin/end/poll() instead of aio_set_fd_handler(is_external=true). As a side-effect the FUSE export now follows AioContext changes like the other export types. Signed-off-by: Stefan Hajnoczi --- block/export/fuse.c | 56 +++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 54 insertions(+), 2 deletions(-) diff --git a/block/export/fuse.c b/block/export/fuse.c index 06fa41079e..adf3236b5a 100644 --- a/block/export/fuse.c +++ b/block/export/fuse.c @@ -50,6 +50,7 @@ typedef struct FuseExport { struct fuse_session *fuse_session; struct fuse_buf fuse_buf; + unsigned int in_flight; /* atomic */ bool mounted, fd_handler_set_up; char *mountpoint; @@ -78,6 +79,42 @@ static void read_from_fuse_export(void *opaque); static bool is_regular_file(const char *path, Error **errp); +static void fuse_export_drained_begin(void *opaque) +{ + FuseExport *exp = opaque; + + aio_set_fd_handler(exp->common.ctx, + fuse_session_fd(exp->fuse_session), false, + NULL, NULL, NULL, NULL, NULL); + exp->fd_handler_set_up = false; +} + +static void fuse_export_drained_end(void *opaque) +{ + FuseExport *exp = opaque; + + /* Refresh AioContext in case it changed */ + exp->common.ctx = blk_get_aio_context(exp->common.blk); + + aio_set_fd_handler(exp->common.ctx, + fuse_session_fd(exp->fuse_session), false, + read_from_fuse_export, NULL, NULL, NULL, exp); + exp->fd_handler_set_up = true; +} + +static bool fuse_export_drained_poll(void *opaque) +{ + FuseExport *exp = opaque; + + return qatomic_read(&exp->in_flight) > 0; +} + +static const BlockDevOps fuse_export_blk_dev_ops = { + .drained_begin = fuse_export_drained_begin, + .drained_end = fuse_export_drained_end, + .drained_poll = fuse_export_drained_poll, +}; + static int fuse_export_create(BlockExport *blk_exp, BlockExportOptions *blk_exp_args, Error **errp) @@ -101,6 +138,15 @@ static int fuse_export_create(BlockExport *blk_exp, } } + blk_set_dev_ops(exp->common.blk, &fuse_export_blk_dev_ops, exp); + + /* + * We handle draining ourselves using an in-flight counter and by disabling + * the FUSE fd handler. Do not queue BlockBackend requests, they need to + * complete so the in-flight counter reaches zero. + */ + blk_set_disable_request_queuing(exp->common.blk, true); + init_exports_table(); /* @@ -224,7 +270,7 @@ static int setup_fuse_export(FuseExport *exp, const char *mountpoint, g_hash_table_insert(exports, g_strdup(mountpoint), NULL); aio_set_fd_handler(exp->common.ctx, - fuse_session_fd(exp->fuse_session), true, + fuse_session_fd(exp->fuse_session), false, read_from_fuse_export, NULL, NULL, NULL, exp); exp->fd_handler_set_up = true; @@ -246,6 +292,8 @@ static void read_from_fuse_export(void *opaque) blk_exp_ref(&exp->common); + qatomic_inc(&exp->in_flight); + do { ret = fuse_session_receive_buf(exp->fuse_session, &exp->fuse_buf); } while (ret == -EINTR); @@ -256,6 +304,10 @@ static void read_from_fuse_export(void *opaque) fuse_session_process_buf(exp->fuse_session, &exp->fuse_buf); out: + if (qatomic_fetch_dec(&exp->in_flight) == 1) { + aio_wait_kick(); /* wake AIO_WAIT_WHILE() */ + } + blk_exp_unref(&exp->common); } @@ -268,7 +320,7 @@ static void fuse_export_shutdown(BlockExport *blk_exp) if (exp->fd_handler_set_up) { aio_set_fd_handler(exp->common.ctx, - fuse_session_fd(exp->fuse_session), true, + fuse_session_fd(exp->fuse_session), false, NULL, NULL, NULL, NULL, NULL); exp->fd_handler_set_up = false; } -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Thu May 04 19:59:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:59:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530095.825466 (Exim 4.92) (envelope-from ) id 1puf6s-0002hr-Gx; Thu, 04 May 2023 19:59:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530095.825466; Thu, 04 May 2023 19:59:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf6s-0002hf-DY; Thu, 04 May 2023 19:59:26 +0000 Received: by outflank-mailman (input) for mailman id 530095; Thu, 04 May 2023 19:59:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf1q-0003xx-Dp for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:54:14 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 708d161a-eab5-11ed-8611-37d641c3527e; Thu, 04 May 2023 21:54:12 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-127-Vlp1VFRtMiyjJOAA8uYRjg-1; Thu, 04 May 2023 15:54:08 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 66842A0F392; Thu, 4 May 2023 19:54:06 +0000 (UTC) Received: from localhost (unknown [10.39.192.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id BD6032166B31; Thu, 4 May 2023 19:54:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 708d161a-eab5-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683230051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7wSWNHCOtGu2HSsa9w9EnU6dW7eXmRIvTEr1l03At9A=; b=P9zEgIFjfrIgZ6OZCMauqbsLsASBuwBcr2L8tmHqwgKmN+dxLLl4f5JGOhRZOxG8Xl4FPY 01BueEG9KicSVoimaf53qGONqV0LEYkz1RmOw0jWfCIUnlrKajMNHFEAZqxOXvmb395TnP AubLXFXnVK5i6lI7TKU4dztP69/Y4R0= X-MC-Unique: Vlp1VFRtMiyjJOAA8uYRjg-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Ronnie Sahlberg , Aarushi Mehta , qemu-block@nongnu.org, Paul Durrant , Anthony Perard , Peter Lieven , Stefan Weil , Xie Yongji , Kevin Wolf , Paolo Bonzini , "Michael S. Tsirkin" , Leonardo Bras , Peter Xu , Hanna Reitz , Stefano Stabellini , Richard Henderson , David Woodhouse , Coiby Xu , Eduardo Habkost , Stefano Garzarella , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Stefan Hajnoczi , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Juan Quintela , "Richard W.M. Jones" , Fam Zheng , Marcel Apfelbaum Subject: [PATCH v5 14/21] block/export: rewrite vduse-blk drain code Date: Thu, 4 May 2023 15:53:20 -0400 Message-Id: <20230504195327.695107-15-stefanha@redhat.com> In-Reply-To: <20230504195327.695107-1-stefanha@redhat.com> References: <20230504195327.695107-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 vduse_blk_detach_ctx() waits for in-flight requests using AIO_WAIT_WHILE(). This is not allowed according to a comment in bdrv_set_aio_context_commit(): /* * Take the old AioContex when detaching it from bs. * At this point, new_context lock is already acquired, and we are now * also taking old_context. This is safe as long as bdrv_detach_aio_context * does not call AIO_POLL_WHILE(). */ Use this opportunity to rewrite the drain code in vduse-blk: - Use the BlockExport refcount so that vduse_blk_exp_delete() is only called when there are no more requests in flight. - Implement .drained_poll() so in-flight request coroutines are stopped by the time .bdrv_detach_aio_context() is called. - Remove AIO_WAIT_WHILE() from vduse_blk_detach_ctx() to solve the .bdrv_detach_aio_context() constraint violation. It's no longer needed due to the previous changes. - Always handle the VDUSE file descriptor, even in drained sections. The VDUSE file descriptor doesn't submit I/O, so it's safe to handle it in drained sections. This ensures that the VDUSE kernel code gets a fast response. - Suspend virtqueue fd handlers in .drained_begin() and resume them in .drained_end(). This eliminates the need for the aio_set_fd_handler(is_external=true) flag, which is being removed from QEMU. This is a long list but splitting it into individual commits would probably lead to git bisect failures - the changes are all related. Signed-off-by: Stefan Hajnoczi --- block/export/vduse-blk.c | 132 +++++++++++++++++++++++++++------------ 1 file changed, 93 insertions(+), 39 deletions(-) diff --git a/block/export/vduse-blk.c b/block/export/vduse-blk.c index b53ef39da0..a25556fe04 100644 --- a/block/export/vduse-blk.c +++ b/block/export/vduse-blk.c @@ -31,7 +31,8 @@ typedef struct VduseBlkExport { VduseDev *dev; uint16_t num_queues; char *recon_file; - unsigned int inflight; + unsigned int inflight; /* atomic */ + bool vqs_started; } VduseBlkExport; typedef struct VduseBlkReq { @@ -41,13 +42,24 @@ typedef struct VduseBlkReq { static void vduse_blk_inflight_inc(VduseBlkExport *vblk_exp) { - vblk_exp->inflight++; + if (qatomic_fetch_inc(&vblk_exp->inflight) == 0) { + /* Prevent export from being deleted */ + aio_context_acquire(vblk_exp->export.ctx); + blk_exp_ref(&vblk_exp->export); + aio_context_release(vblk_exp->export.ctx); + } } static void vduse_blk_inflight_dec(VduseBlkExport *vblk_exp) { - if (--vblk_exp->inflight == 0) { + if (qatomic_fetch_dec(&vblk_exp->inflight) == 1) { + /* Wake AIO_WAIT_WHILE() */ aio_wait_kick(); + + /* Now the export can be deleted */ + aio_context_acquire(vblk_exp->export.ctx); + blk_exp_unref(&vblk_exp->export); + aio_context_release(vblk_exp->export.ctx); } } @@ -124,8 +136,12 @@ static void vduse_blk_enable_queue(VduseDev *dev, VduseVirtq *vq) { VduseBlkExport *vblk_exp = vduse_dev_get_priv(dev); + if (!vblk_exp->vqs_started) { + return; /* vduse_blk_drained_end() will start vqs later */ + } + aio_set_fd_handler(vblk_exp->export.ctx, vduse_queue_get_fd(vq), - true, on_vduse_vq_kick, NULL, NULL, NULL, vq); + false, on_vduse_vq_kick, NULL, NULL, NULL, vq); /* Make sure we don't miss any kick afer reconnecting */ eventfd_write(vduse_queue_get_fd(vq), 1); } @@ -133,9 +149,14 @@ static void vduse_blk_enable_queue(VduseDev *dev, VduseVirtq *vq) static void vduse_blk_disable_queue(VduseDev *dev, VduseVirtq *vq) { VduseBlkExport *vblk_exp = vduse_dev_get_priv(dev); + int fd = vduse_queue_get_fd(vq); - aio_set_fd_handler(vblk_exp->export.ctx, vduse_queue_get_fd(vq), - true, NULL, NULL, NULL, NULL, NULL); + if (fd < 0) { + return; + } + + aio_set_fd_handler(vblk_exp->export.ctx, fd, false, + NULL, NULL, NULL, NULL, NULL); } static const VduseOps vduse_blk_ops = { @@ -152,42 +173,19 @@ static void on_vduse_dev_kick(void *opaque) static void vduse_blk_attach_ctx(VduseBlkExport *vblk_exp, AioContext *ctx) { - int i; - aio_set_fd_handler(vblk_exp->export.ctx, vduse_dev_get_fd(vblk_exp->dev), - true, on_vduse_dev_kick, NULL, NULL, NULL, + false, on_vduse_dev_kick, NULL, NULL, NULL, vblk_exp->dev); - for (i = 0; i < vblk_exp->num_queues; i++) { - VduseVirtq *vq = vduse_dev_get_queue(vblk_exp->dev, i); - int fd = vduse_queue_get_fd(vq); - - if (fd < 0) { - continue; - } - aio_set_fd_handler(vblk_exp->export.ctx, fd, true, - on_vduse_vq_kick, NULL, NULL, NULL, vq); - } + /* Virtqueues are handled by vduse_blk_drained_end() */ } static void vduse_blk_detach_ctx(VduseBlkExport *vblk_exp) { - int i; - - for (i = 0; i < vblk_exp->num_queues; i++) { - VduseVirtq *vq = vduse_dev_get_queue(vblk_exp->dev, i); - int fd = vduse_queue_get_fd(vq); - - if (fd < 0) { - continue; - } - aio_set_fd_handler(vblk_exp->export.ctx, fd, - true, NULL, NULL, NULL, NULL, NULL); - } aio_set_fd_handler(vblk_exp->export.ctx, vduse_dev_get_fd(vblk_exp->dev), - true, NULL, NULL, NULL, NULL, NULL); + false, NULL, NULL, NULL, NULL, NULL); - AIO_WAIT_WHILE(vblk_exp->export.ctx, vblk_exp->inflight > 0); + /* Virtqueues are handled by vduse_blk_drained_begin() */ } @@ -220,8 +218,55 @@ static void vduse_blk_resize(void *opaque) (char *)&config.capacity); } +static void vduse_blk_stop_virtqueues(VduseBlkExport *vblk_exp) +{ + for (uint16_t i = 0; i < vblk_exp->num_queues; i++) { + VduseVirtq *vq = vduse_dev_get_queue(vblk_exp->dev, i); + vduse_blk_disable_queue(vblk_exp->dev, vq); + } + + vblk_exp->vqs_started = false; +} + +static void vduse_blk_start_virtqueues(VduseBlkExport *vblk_exp) +{ + vblk_exp->vqs_started = true; + + for (uint16_t i = 0; i < vblk_exp->num_queues; i++) { + VduseVirtq *vq = vduse_dev_get_queue(vblk_exp->dev, i); + vduse_blk_enable_queue(vblk_exp->dev, vq); + } +} + +static void vduse_blk_drained_begin(void *opaque) +{ + BlockExport *exp = opaque; + VduseBlkExport *vblk_exp = container_of(exp, VduseBlkExport, export); + + vduse_blk_stop_virtqueues(vblk_exp); +} + +static void vduse_blk_drained_end(void *opaque) +{ + BlockExport *exp = opaque; + VduseBlkExport *vblk_exp = container_of(exp, VduseBlkExport, export); + + vduse_blk_start_virtqueues(vblk_exp); +} + +static bool vduse_blk_drained_poll(void *opaque) +{ + BlockExport *exp = opaque; + VduseBlkExport *vblk_exp = container_of(exp, VduseBlkExport, export); + + return qatomic_read(&vblk_exp->inflight) > 0; +} + static const BlockDevOps vduse_block_ops = { - .resize_cb = vduse_blk_resize, + .resize_cb = vduse_blk_resize, + .drained_begin = vduse_blk_drained_begin, + .drained_end = vduse_blk_drained_end, + .drained_poll = vduse_blk_drained_poll, }; static int vduse_blk_exp_create(BlockExport *exp, BlockExportOptions *opts, @@ -268,6 +313,7 @@ static int vduse_blk_exp_create(BlockExport *exp, BlockExportOptions *opts, vblk_exp->handler.serial = g_strdup(vblk_opts->serial ?: ""); vblk_exp->handler.logical_block_size = logical_block_size; vblk_exp->handler.writable = opts->writable; + vblk_exp->vqs_started = true; config.capacity = cpu_to_le64(blk_getlength(exp->blk) >> VIRTIO_BLK_SECTOR_BITS); @@ -322,14 +368,20 @@ static int vduse_blk_exp_create(BlockExport *exp, BlockExportOptions *opts, vduse_dev_setup_queue(vblk_exp->dev, i, queue_size); } - aio_set_fd_handler(exp->ctx, vduse_dev_get_fd(vblk_exp->dev), true, + aio_set_fd_handler(exp->ctx, vduse_dev_get_fd(vblk_exp->dev), false, on_vduse_dev_kick, NULL, NULL, NULL, vblk_exp->dev); blk_add_aio_context_notifier(exp->blk, blk_aio_attached, blk_aio_detach, vblk_exp); - blk_set_dev_ops(exp->blk, &vduse_block_ops, exp); + /* + * We handle draining ourselves using an in-flight counter and by disabling + * virtqueue fd handlers. Do not queue BlockBackend requests, they need to + * complete so the in-flight counter reaches zero. + */ + blk_set_disable_request_queuing(exp->blk, true); + return 0; err: vduse_dev_destroy(vblk_exp->dev); @@ -344,6 +396,9 @@ static void vduse_blk_exp_delete(BlockExport *exp) VduseBlkExport *vblk_exp = container_of(exp, VduseBlkExport, export); int ret; + assert(qatomic_read(&vblk_exp->inflight) == 0); + + vduse_blk_detach_ctx(vblk_exp); blk_remove_aio_context_notifier(exp->blk, blk_aio_attached, blk_aio_detach, vblk_exp); ret = vduse_dev_destroy(vblk_exp->dev); @@ -354,13 +409,12 @@ static void vduse_blk_exp_delete(BlockExport *exp) g_free(vblk_exp->handler.serial); } +/* Called with exp->ctx acquired */ static void vduse_blk_exp_request_shutdown(BlockExport *exp) { VduseBlkExport *vblk_exp = container_of(exp, VduseBlkExport, export); - aio_context_acquire(vblk_exp->export.ctx); - vduse_blk_detach_ctx(vblk_exp); - aio_context_acquire(vblk_exp->export.ctx); + vduse_blk_stop_virtqueues(vblk_exp); } const BlockExportDriver blk_exp_vduse_blk = { -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Thu May 04 19:59:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 19:59:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530096.825476 (Exim 4.92) (envelope-from ) id 1puf6t-0002yF-Ot; Thu, 04 May 2023 19:59:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530096.825476; Thu, 04 May 2023 19:59:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf6t-0002xx-L0; Thu, 04 May 2023 19:59:27 +0000 Received: by outflank-mailman (input) for mailman id 530096; Thu, 04 May 2023 19:59:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf1y-0003iB-Ae for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:54:22 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 75f0b3fa-eab5-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:54:21 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-37-JLyMG8AyOQ6Ztjf5K0NY6Q-1; Thu, 04 May 2023 15:54:17 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 24421101A531; Thu, 4 May 2023 19:54:16 +0000 (UTC) Received: from localhost (unknown [10.39.192.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5E4CA1121331; Thu, 4 May 2023 19:54:15 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 75f0b3fa-eab5-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683230060; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ruJgs45mwGYUnVoP6uIPKYhuhXIe1j+KFcN94nSbefs=; b=aMVbuSe9iyN4M9RlotmvoTWgdJEdpEiOCXkrmbFb+DGJW6eM/bzDVG909kUXfuQaUTQ6WC 03xS/T+8udfRyeJIZw0FoxBY75ORE0KmB4lH0wD7c3puVR7tnUovNmAuoQzhecjPa2wAsk McLai88FozIa1WR7r3xXEvFojNk/bck= X-MC-Unique: JLyMG8AyOQ6Ztjf5K0NY6Q-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Ronnie Sahlberg , Aarushi Mehta , qemu-block@nongnu.org, Paul Durrant , Anthony Perard , Peter Lieven , Stefan Weil , Xie Yongji , Kevin Wolf , Paolo Bonzini , "Michael S. Tsirkin" , Leonardo Bras , Peter Xu , Hanna Reitz , Stefano Stabellini , Richard Henderson , David Woodhouse , Coiby Xu , Eduardo Habkost , Stefano Garzarella , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Stefan Hajnoczi , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Juan Quintela , "Richard W.M. Jones" , Fam Zheng , Marcel Apfelbaum Subject: [PATCH v5 18/21] virtio-blk: implement BlockDevOps->drained_begin() Date: Thu, 4 May 2023 15:53:24 -0400 Message-Id: <20230504195327.695107-19-stefanha@redhat.com> In-Reply-To: <20230504195327.695107-1-stefanha@redhat.com> References: <20230504195327.695107-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Detach ioeventfds during drained sections to stop I/O submission from the guest. virtio-blk is no longer reliant on aio_disable_external() after this patch. This will allow us to remove the aio_disable_external() API once all other code that relies on it is converted. Take extra care to avoid attaching/detaching ioeventfds if the data plane is started/stopped during a drained section. This should be rare, but maybe the mirror block job can trigger it. Signed-off-by: Stefan Hajnoczi --- hw/block/dataplane/virtio-blk.c | 17 +++++++++------ hw/block/virtio-blk.c | 38 ++++++++++++++++++++++++++++++++- 2 files changed, 48 insertions(+), 7 deletions(-) diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c index 27eafa6c92..c0d2663abc 100644 --- a/hw/block/dataplane/virtio-blk.c +++ b/hw/block/dataplane/virtio-blk.c @@ -246,13 +246,15 @@ int virtio_blk_data_plane_start(VirtIODevice *vdev) } /* Get this show started by hooking up our callbacks */ - aio_context_acquire(s->ctx); - for (i = 0; i < nvqs; i++) { - VirtQueue *vq = virtio_get_queue(s->vdev, i); + if (!blk_in_drain(s->conf->conf.blk)) { + aio_context_acquire(s->ctx); + for (i = 0; i < nvqs; i++) { + VirtQueue *vq = virtio_get_queue(s->vdev, i); - virtio_queue_aio_attach_host_notifier(vq, s->ctx); + virtio_queue_aio_attach_host_notifier(vq, s->ctx); + } + aio_context_release(s->ctx); } - aio_context_release(s->ctx); return 0; fail_aio_context: @@ -318,7 +320,10 @@ void virtio_blk_data_plane_stop(VirtIODevice *vdev) trace_virtio_blk_data_plane_stop(s); aio_context_acquire(s->ctx); - aio_wait_bh_oneshot(s->ctx, virtio_blk_data_plane_stop_bh, s); + + if (!blk_in_drain(s->conf->conf.blk)) { + aio_wait_bh_oneshot(s->ctx, virtio_blk_data_plane_stop_bh, s); + } /* Wait for virtio_blk_dma_restart_bh() and in flight I/O to complete */ blk_drain(s->conf->conf.blk); diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index cefca93b31..d8dedc575c 100644 --- a/hw/block/virtio-blk.c +++ b/hw/block/virtio-blk.c @@ -1109,8 +1109,44 @@ static void virtio_blk_resize(void *opaque) aio_bh_schedule_oneshot(qemu_get_aio_context(), virtio_resize_cb, vdev); } +/* Suspend virtqueue ioeventfd processing during drain */ +static void virtio_blk_drained_begin(void *opaque) +{ + VirtIOBlock *s = opaque; + VirtIODevice *vdev = VIRTIO_DEVICE(opaque); + AioContext *ctx = blk_get_aio_context(s->conf.conf.blk); + + if (!s->dataplane || !s->dataplane_started) { + return; + } + + for (uint16_t i = 0; i < s->conf.num_queues; i++) { + VirtQueue *vq = virtio_get_queue(vdev, i); + virtio_queue_aio_detach_host_notifier(vq, ctx); + } +} + +/* Resume virtqueue ioeventfd processing after drain */ +static void virtio_blk_drained_end(void *opaque) +{ + VirtIOBlock *s = opaque; + VirtIODevice *vdev = VIRTIO_DEVICE(opaque); + AioContext *ctx = blk_get_aio_context(s->conf.conf.blk); + + if (!s->dataplane || !s->dataplane_started) { + return; + } + + for (uint16_t i = 0; i < s->conf.num_queues; i++) { + VirtQueue *vq = virtio_get_queue(vdev, i); + virtio_queue_aio_attach_host_notifier(vq, ctx); + } +} + static const BlockDevOps virtio_block_ops = { - .resize_cb = virtio_blk_resize, + .resize_cb = virtio_blk_resize, + .drained_begin = virtio_blk_drained_begin, + .drained_end = virtio_blk_drained_end, }; static void virtio_blk_device_realize(DeviceState *dev, Error **errp) -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Thu May 04 20:00:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 20:00:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530110.825486 (Exim 4.92) (envelope-from ) id 1puf7W-0005Az-45; Thu, 04 May 2023 20:00:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530110.825486; Thu, 04 May 2023 20:00:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf7V-0005As-VA; Thu, 04 May 2023 20:00:05 +0000 Received: by outflank-mailman (input) for mailman id 530110; Thu, 04 May 2023 20:00:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf1y-0003xx-0Y for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:54:22 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 752ae21e-eab5-11ed-8611-37d641c3527e; Thu, 04 May 2023 21:54:20 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-635-rnzRckGWN_uYxyN68Qx0aw-1; Thu, 04 May 2023 15:54:15 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A63E5101A531; Thu, 4 May 2023 19:54:13 +0000 (UTC) Received: from localhost (unknown [10.39.192.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id E92B763F3E; Thu, 4 May 2023 19:54:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 752ae21e-eab5-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683230059; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=94EbW6UEPYMLwV9zB8HOwndWfCZlP2kutpuX+h7WMqo=; b=TaCAoYoEpnhHFw4ZKWwTsG7GbZ0YvaDn5NTWcZ/jZDa3c4KlIcULOT36dZiExKMMTVnE7o UBao6Axld3t7VTAfWW3isW+Ye8ny5/OtoWfP+3Z2s7drTiyrp8aidxwNY9jwqu3QjltNcY p8HKKe6OkyZ4msncWm5i5djPhMndmko= X-MC-Unique: rnzRckGWN_uYxyN68Qx0aw-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Ronnie Sahlberg , Aarushi Mehta , qemu-block@nongnu.org, Paul Durrant , Anthony Perard , Peter Lieven , Stefan Weil , Xie Yongji , Kevin Wolf , Paolo Bonzini , "Michael S. Tsirkin" , Leonardo Bras , Peter Xu , Hanna Reitz , Stefano Stabellini , Richard Henderson , David Woodhouse , Coiby Xu , Eduardo Habkost , Stefano Garzarella , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Stefan Hajnoczi , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Juan Quintela , "Richard W.M. Jones" , Fam Zheng , Marcel Apfelbaum Subject: [PATCH v5 17/21] virtio: make it possible to detach host notifier from any thread Date: Thu, 4 May 2023 15:53:23 -0400 Message-Id: <20230504195327.695107-18-stefanha@redhat.com> In-Reply-To: <20230504195327.695107-1-stefanha@redhat.com> References: <20230504195327.695107-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 virtio_queue_aio_detach_host_notifier() does two things: 1. It removes the fd handler from the event loop. 2. It processes the virtqueue one last time. The first step can be peformed by any thread and without taking the AioContext lock. The second step may need the AioContext lock (depending on the device implementation) and runs in the thread where request processing takes place. virtio-blk and virtio-scsi therefore call virtio_queue_aio_detach_host_notifier() from a BH that is scheduled in AioContext Scheduling a BH is undesirable for .drained_begin() functions. The next patch will introduce a .drained_begin() function that needs to call virtio_queue_aio_detach_host_notifier(). Move the virtqueue processing out to the callers of virtio_queue_aio_detach_host_notifier() so that the function can be called from any thread. This is in preparation for the next patch. Signed-off-by: Stefan Hajnoczi --- hw/block/dataplane/virtio-blk.c | 2 ++ hw/scsi/virtio-scsi-dataplane.c | 9 +++++++++ 2 files changed, 11 insertions(+) diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c index a6202997ee..27eafa6c92 100644 --- a/hw/block/dataplane/virtio-blk.c +++ b/hw/block/dataplane/virtio-blk.c @@ -287,8 +287,10 @@ static void virtio_blk_data_plane_stop_bh(void *opaque) for (i = 0; i < s->conf->num_queues; i++) { VirtQueue *vq = virtio_get_queue(s->vdev, i); + EventNotifier *host_notifier = virtio_queue_get_host_notifier(vq); virtio_queue_aio_detach_host_notifier(vq, s->ctx); + virtio_queue_host_notifier_read(host_notifier); } } diff --git a/hw/scsi/virtio-scsi-dataplane.c b/hw/scsi/virtio-scsi-dataplane.c index 20bb91766e..81643445ed 100644 --- a/hw/scsi/virtio-scsi-dataplane.c +++ b/hw/scsi/virtio-scsi-dataplane.c @@ -71,12 +71,21 @@ static void virtio_scsi_dataplane_stop_bh(void *opaque) { VirtIOSCSI *s = opaque; VirtIOSCSICommon *vs = VIRTIO_SCSI_COMMON(s); + EventNotifier *host_notifier; int i; virtio_queue_aio_detach_host_notifier(vs->ctrl_vq, s->ctx); + host_notifier = virtio_queue_get_host_notifier(vs->ctrl_vq); + virtio_queue_host_notifier_read(host_notifier); + virtio_queue_aio_detach_host_notifier(vs->event_vq, s->ctx); + host_notifier = virtio_queue_get_host_notifier(vs->event_vq); + virtio_queue_host_notifier_read(host_notifier); + for (i = 0; i < vs->conf.num_queues; i++) { virtio_queue_aio_detach_host_notifier(vs->cmd_vqs[i], s->ctx); + host_notifier = virtio_queue_get_host_notifier(vs->cmd_vqs[i]); + virtio_queue_host_notifier_read(host_notifier); } } -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Thu May 04 20:00:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 20:00:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530114.825496 (Exim 4.92) (envelope-from ) id 1puf7a-0005XZ-Bg; Thu, 04 May 2023 20:00:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530114.825496; Thu, 04 May 2023 20:00:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf7a-0005XS-8d; Thu, 04 May 2023 20:00:10 +0000 Received: by outflank-mailman (input) for mailman id 530114; Thu, 04 May 2023 20:00:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf29-0003iB-86 for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:54:33 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7ba0c59d-eab5-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:54:31 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-197-qnKcAnexPNuFuzoeplb57A-1; Thu, 04 May 2023 15:54:28 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 220D33C0F66C; Thu, 4 May 2023 19:54:27 +0000 (UTC) Received: from localhost (unknown [10.39.192.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id D5CF340C2064; Thu, 4 May 2023 19:54:24 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7ba0c59d-eab5-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683230070; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DIrmY+4xB43BwQ7fJaY0YH2utqNnWk6FB76ZRZW5uOk=; b=C5Egk0MCk0umval0dUHvR5cPxYYrF5KxVdolEX2MgjQhngMh4DdlZwF3zlK5JPdGYN0g2Q YdTNiHBK5dJ8E9Q9U+2zZNsdV5j81w8B6ynuR1qkD+6IpPnLZxhps+zM87cULBMtoVCLLM QnX9ABO6t/ZOhz9LbyZJ+Z7KyRiUC0I= X-MC-Unique: qnKcAnexPNuFuzoeplb57A-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Ronnie Sahlberg , Aarushi Mehta , qemu-block@nongnu.org, Paul Durrant , Anthony Perard , Peter Lieven , Stefan Weil , Xie Yongji , Kevin Wolf , Paolo Bonzini , "Michael S. Tsirkin" , Leonardo Bras , Peter Xu , Hanna Reitz , Stefano Stabellini , Richard Henderson , David Woodhouse , Coiby Xu , Eduardo Habkost , Stefano Garzarella , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Stefan Hajnoczi , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Juan Quintela , "Richard W.M. Jones" , Fam Zheng , Marcel Apfelbaum Subject: [PATCH v5 21/21] aio: remove aio_disable_external() API Date: Thu, 4 May 2023 15:53:27 -0400 Message-Id: <20230504195327.695107-22-stefanha@redhat.com> In-Reply-To: <20230504195327.695107-1-stefanha@redhat.com> References: <20230504195327.695107-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 All callers now pass is_external=false to aio_set_fd_handler() and aio_set_event_notifier(). The aio_disable_external() API that temporarily disables fd handlers that were registered is_external=true is therefore dead code. Remove aio_disable_external(), aio_enable_external(), and the is_external arguments to aio_set_fd_handler() and aio_set_event_notifier(). The entire test-fdmon-epoll test is removed because its sole purpose was testing aio_disable_external(). Parts of this patch were generated using the following coccinelle (https://coccinelle.lip6.fr/) semantic patch: @@ expression ctx, fd, is_external, io_read, io_write, io_poll, io_poll_ready, opaque; @@ - aio_set_fd_handler(ctx, fd, is_external, io_read, io_write, io_poll, io_poll_ready, opaque) + aio_set_fd_handler(ctx, fd, io_read, io_write, io_poll, io_poll_ready, opaque) @@ expression ctx, notifier, is_external, io_read, io_poll, io_poll_ready; @@ - aio_set_event_notifier(ctx, notifier, is_external, io_read, io_poll, io_poll_ready) + aio_set_event_notifier(ctx, notifier, io_read, io_poll, io_poll_ready) Reviewed-by: Juan Quintela Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Hajnoczi --- include/block/aio.h | 57 --------------------------- util/aio-posix.h | 1 - block.c | 7 ---- block/blkio.c | 15 +++---- block/curl.c | 10 ++--- block/export/fuse.c | 8 ++-- block/export/vduse-blk.c | 10 ++--- block/io.c | 2 - block/io_uring.c | 4 +- block/iscsi.c | 3 +- block/linux-aio.c | 4 +- block/nfs.c | 5 +-- block/nvme.c | 8 ++-- block/ssh.c | 4 +- block/win32-aio.c | 6 +-- hw/i386/kvm/xen_xenstore.c | 2 +- hw/virtio/virtio.c | 6 +-- hw/xen/xen-bus.c | 8 ++-- io/channel-command.c | 6 +-- io/channel-file.c | 3 +- io/channel-socket.c | 3 +- migration/rdma.c | 16 ++++---- tests/unit/test-aio.c | 27 +------------ tests/unit/test-bdrv-drain.c | 1 - tests/unit/test-fdmon-epoll.c | 73 ----------------------------------- util/aio-posix.c | 20 +++------- util/aio-win32.c | 8 +--- util/async.c | 3 +- util/fdmon-epoll.c | 18 +++------ util/fdmon-io_uring.c | 8 +--- util/fdmon-poll.c | 3 +- util/main-loop.c | 7 ++-- util/qemu-coroutine-io.c | 7 ++-- util/vhost-user-server.c | 11 +++--- tests/unit/meson.build | 3 -- 35 files changed, 82 insertions(+), 295 deletions(-) delete mode 100644 tests/unit/test-fdmon-epoll.c diff --git a/include/block/aio.h b/include/block/aio.h index 89bbc536f9..32042e8905 100644 --- a/include/block/aio.h +++ b/include/block/aio.h @@ -225,8 +225,6 @@ struct AioContext { */ QEMUTimerListGroup tlg; - int external_disable_cnt; - /* Number of AioHandlers without .io_poll() */ int poll_disable_cnt; @@ -481,7 +479,6 @@ bool aio_poll(AioContext *ctx, bool blocking); */ void aio_set_fd_handler(AioContext *ctx, int fd, - bool is_external, IOHandler *io_read, IOHandler *io_write, AioPollFn *io_poll, @@ -497,7 +494,6 @@ void aio_set_fd_handler(AioContext *ctx, */ void aio_set_event_notifier(AioContext *ctx, EventNotifier *notifier, - bool is_external, EventNotifierHandler *io_read, AioPollFn *io_poll, EventNotifierHandler *io_poll_ready); @@ -626,59 +622,6 @@ static inline void aio_timer_init(AioContext *ctx, */ int64_t aio_compute_timeout(AioContext *ctx); -/** - * aio_disable_external: - * @ctx: the aio context - * - * Disable the further processing of external clients. - */ -static inline void aio_disable_external(AioContext *ctx) -{ - qatomic_inc(&ctx->external_disable_cnt); -} - -/** - * aio_enable_external: - * @ctx: the aio context - * - * Enable the processing of external clients. - */ -static inline void aio_enable_external(AioContext *ctx) -{ - int old; - - old = qatomic_fetch_dec(&ctx->external_disable_cnt); - assert(old > 0); - if (old == 1) { - /* Kick event loop so it re-arms file descriptors */ - aio_notify(ctx); - } -} - -/** - * aio_external_disabled: - * @ctx: the aio context - * - * Return true if the external clients are disabled. - */ -static inline bool aio_external_disabled(AioContext *ctx) -{ - return qatomic_read(&ctx->external_disable_cnt); -} - -/** - * aio_node_check: - * @ctx: the aio context - * @is_external: Whether or not the checked node is an external event source. - * - * Check if the node's is_external flag is okay to be polled by the ctx at this - * moment. True means green light. - */ -static inline bool aio_node_check(AioContext *ctx, bool is_external) -{ - return !is_external || !qatomic_read(&ctx->external_disable_cnt); -} - /** * aio_co_schedule: * @ctx: the aio context diff --git a/util/aio-posix.h b/util/aio-posix.h index 80b927c7f4..4264c518be 100644 --- a/util/aio-posix.h +++ b/util/aio-posix.h @@ -38,7 +38,6 @@ struct AioHandler { #endif int64_t poll_idle_timeout; /* when to stop userspace polling */ bool poll_ready; /* has polling detected an event? */ - bool is_external; }; /* Add a handler to a ready list */ diff --git a/block.c b/block.c index 5ec1a3897e..6239c8bc07 100644 --- a/block.c +++ b/block.c @@ -7268,9 +7268,6 @@ static void bdrv_detach_aio_context(BlockDriverState *bs) bs->drv->bdrv_detach_aio_context(bs); } - if (bs->quiesce_counter) { - aio_enable_external(bs->aio_context); - } bs->aio_context = NULL; } @@ -7280,10 +7277,6 @@ static void bdrv_attach_aio_context(BlockDriverState *bs, BdrvAioNotifier *ban, *ban_tmp; GLOBAL_STATE_CODE(); - if (bs->quiesce_counter) { - aio_disable_external(new_context); - } - bs->aio_context = new_context; if (bs->drv && bs->drv->bdrv_attach_aio_context) { diff --git a/block/blkio.c b/block/blkio.c index 0cdc99a729..72117fa005 100644 --- a/block/blkio.c +++ b/block/blkio.c @@ -306,23 +306,18 @@ static void blkio_attach_aio_context(BlockDriverState *bs, { BDRVBlkioState *s = bs->opaque; - aio_set_fd_handler(new_context, - s->completion_fd, - false, - blkio_completion_fd_read, - NULL, + aio_set_fd_handler(new_context, s->completion_fd, + blkio_completion_fd_read, NULL, blkio_completion_fd_poll, - blkio_completion_fd_poll_ready, - bs); + blkio_completion_fd_poll_ready, bs); } static void blkio_detach_aio_context(BlockDriverState *bs) { BDRVBlkioState *s = bs->opaque; - aio_set_fd_handler(bdrv_get_aio_context(bs), - s->completion_fd, - false, NULL, NULL, NULL, NULL, NULL); + aio_set_fd_handler(bdrv_get_aio_context(bs), s->completion_fd, NULL, NULL, + NULL, NULL, NULL); } /* Call with s->blkio_lock held to submit I/O after enqueuing a new request */ diff --git a/block/curl.c b/block/curl.c index 8bb39a134e..0fc42d03d7 100644 --- a/block/curl.c +++ b/block/curl.c @@ -132,7 +132,7 @@ static gboolean curl_drop_socket(void *key, void *value, void *opaque) CURLSocket *socket = value; BDRVCURLState *s = socket->s; - aio_set_fd_handler(s->aio_context, socket->fd, false, + aio_set_fd_handler(s->aio_context, socket->fd, NULL, NULL, NULL, NULL, NULL); return true; } @@ -180,20 +180,20 @@ static int curl_sock_cb(CURL *curl, curl_socket_t fd, int action, trace_curl_sock_cb(action, (int)fd); switch (action) { case CURL_POLL_IN: - aio_set_fd_handler(s->aio_context, fd, false, + aio_set_fd_handler(s->aio_context, fd, curl_multi_do, NULL, NULL, NULL, socket); break; case CURL_POLL_OUT: - aio_set_fd_handler(s->aio_context, fd, false, + aio_set_fd_handler(s->aio_context, fd, NULL, curl_multi_do, NULL, NULL, socket); break; case CURL_POLL_INOUT: - aio_set_fd_handler(s->aio_context, fd, false, + aio_set_fd_handler(s->aio_context, fd, curl_multi_do, curl_multi_do, NULL, NULL, socket); break; case CURL_POLL_REMOVE: - aio_set_fd_handler(s->aio_context, fd, false, + aio_set_fd_handler(s->aio_context, fd, NULL, NULL, NULL, NULL, NULL); break; } diff --git a/block/export/fuse.c b/block/export/fuse.c index adf3236b5a..3307b64089 100644 --- a/block/export/fuse.c +++ b/block/export/fuse.c @@ -84,7 +84,7 @@ static void fuse_export_drained_begin(void *opaque) FuseExport *exp = opaque; aio_set_fd_handler(exp->common.ctx, - fuse_session_fd(exp->fuse_session), false, + fuse_session_fd(exp->fuse_session), NULL, NULL, NULL, NULL, NULL); exp->fd_handler_set_up = false; } @@ -97,7 +97,7 @@ static void fuse_export_drained_end(void *opaque) exp->common.ctx = blk_get_aio_context(exp->common.blk); aio_set_fd_handler(exp->common.ctx, - fuse_session_fd(exp->fuse_session), false, + fuse_session_fd(exp->fuse_session), read_from_fuse_export, NULL, NULL, NULL, exp); exp->fd_handler_set_up = true; } @@ -270,7 +270,7 @@ static int setup_fuse_export(FuseExport *exp, const char *mountpoint, g_hash_table_insert(exports, g_strdup(mountpoint), NULL); aio_set_fd_handler(exp->common.ctx, - fuse_session_fd(exp->fuse_session), false, + fuse_session_fd(exp->fuse_session), read_from_fuse_export, NULL, NULL, NULL, exp); exp->fd_handler_set_up = true; @@ -320,7 +320,7 @@ static void fuse_export_shutdown(BlockExport *blk_exp) if (exp->fd_handler_set_up) { aio_set_fd_handler(exp->common.ctx, - fuse_session_fd(exp->fuse_session), false, + fuse_session_fd(exp->fuse_session), NULL, NULL, NULL, NULL, NULL); exp->fd_handler_set_up = false; } diff --git a/block/export/vduse-blk.c b/block/export/vduse-blk.c index e0455551f9..83b05548e7 100644 --- a/block/export/vduse-blk.c +++ b/block/export/vduse-blk.c @@ -137,7 +137,7 @@ static void vduse_blk_enable_queue(VduseDev *dev, VduseVirtq *vq) } aio_set_fd_handler(vblk_exp->export.ctx, vduse_queue_get_fd(vq), - false, on_vduse_vq_kick, NULL, NULL, NULL, vq); + on_vduse_vq_kick, NULL, NULL, NULL, vq); /* Make sure we don't miss any kick afer reconnecting */ eventfd_write(vduse_queue_get_fd(vq), 1); } @@ -151,7 +151,7 @@ static void vduse_blk_disable_queue(VduseDev *dev, VduseVirtq *vq) return; } - aio_set_fd_handler(vblk_exp->export.ctx, fd, false, + aio_set_fd_handler(vblk_exp->export.ctx, fd, NULL, NULL, NULL, NULL, NULL); } @@ -170,7 +170,7 @@ static void on_vduse_dev_kick(void *opaque) static void vduse_blk_attach_ctx(VduseBlkExport *vblk_exp, AioContext *ctx) { aio_set_fd_handler(vblk_exp->export.ctx, vduse_dev_get_fd(vblk_exp->dev), - false, on_vduse_dev_kick, NULL, NULL, NULL, + on_vduse_dev_kick, NULL, NULL, NULL, vblk_exp->dev); /* Virtqueues are handled by vduse_blk_drained_end() */ @@ -179,7 +179,7 @@ static void vduse_blk_attach_ctx(VduseBlkExport *vblk_exp, AioContext *ctx) static void vduse_blk_detach_ctx(VduseBlkExport *vblk_exp) { aio_set_fd_handler(vblk_exp->export.ctx, vduse_dev_get_fd(vblk_exp->dev), - false, NULL, NULL, NULL, NULL, NULL); + NULL, NULL, NULL, NULL, NULL); /* Virtqueues are handled by vduse_blk_drained_begin() */ } @@ -364,7 +364,7 @@ static int vduse_blk_exp_create(BlockExport *exp, BlockExportOptions *opts, vduse_dev_setup_queue(vblk_exp->dev, i, queue_size); } - aio_set_fd_handler(exp->ctx, vduse_dev_get_fd(vblk_exp->dev), false, + aio_set_fd_handler(exp->ctx, vduse_dev_get_fd(vblk_exp->dev), on_vduse_dev_kick, NULL, NULL, NULL, vblk_exp->dev); blk_add_aio_context_notifier(exp->blk, blk_aio_attached, blk_aio_detach, diff --git a/block/io.c b/block/io.c index 532c8c90c9..9f82d1009e 100644 --- a/block/io.c +++ b/block/io.c @@ -363,7 +363,6 @@ static void bdrv_do_drained_begin(BlockDriverState *bs, BdrvChild *parent, /* Stop things in parent-to-child order */ if (qatomic_fetch_inc(&bs->quiesce_counter) == 0) { - aio_disable_external(bdrv_get_aio_context(bs)); bdrv_parent_drained_begin(bs, parent); if (bs->drv && bs->drv->bdrv_drain_begin) { bs->drv->bdrv_drain_begin(bs); @@ -419,7 +418,6 @@ static void bdrv_do_drained_end(BlockDriverState *bs, BdrvChild *parent) bs->drv->bdrv_drain_end(bs); } bdrv_parent_drained_end(bs, parent); - aio_enable_external(bdrv_get_aio_context(bs)); } } diff --git a/block/io_uring.c b/block/io_uring.c index 989f9a99ed..b64a3e6285 100644 --- a/block/io_uring.c +++ b/block/io_uring.c @@ -406,7 +406,7 @@ int coroutine_fn luring_co_submit(BlockDriverState *bs, int fd, uint64_t offset, void luring_detach_aio_context(LuringState *s, AioContext *old_context) { - aio_set_fd_handler(old_context, s->ring.ring_fd, false, + aio_set_fd_handler(old_context, s->ring.ring_fd, NULL, NULL, NULL, NULL, s); qemu_bh_delete(s->completion_bh); s->aio_context = NULL; @@ -416,7 +416,7 @@ void luring_attach_aio_context(LuringState *s, AioContext *new_context) { s->aio_context = new_context; s->completion_bh = aio_bh_new(new_context, qemu_luring_completion_bh, s); - aio_set_fd_handler(s->aio_context, s->ring.ring_fd, false, + aio_set_fd_handler(s->aio_context, s->ring.ring_fd, qemu_luring_completion_cb, NULL, qemu_luring_poll_cb, qemu_luring_poll_ready, s); } diff --git a/block/iscsi.c b/block/iscsi.c index 9fc0bed90b..34f97ab646 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -363,7 +363,6 @@ iscsi_set_events(IscsiLun *iscsilun) if (ev != iscsilun->events) { aio_set_fd_handler(iscsilun->aio_context, iscsi_get_fd(iscsi), - false, (ev & POLLIN) ? iscsi_process_read : NULL, (ev & POLLOUT) ? iscsi_process_write : NULL, NULL, NULL, @@ -1540,7 +1539,7 @@ static void iscsi_detach_aio_context(BlockDriverState *bs) IscsiLun *iscsilun = bs->opaque; aio_set_fd_handler(iscsilun->aio_context, iscsi_get_fd(iscsilun->iscsi), - false, NULL, NULL, NULL, NULL, NULL); + NULL, NULL, NULL, NULL, NULL); iscsilun->events = 0; if (iscsilun->nop_timer) { diff --git a/block/linux-aio.c b/block/linux-aio.c index fc50cdd1bf..129908531a 100644 --- a/block/linux-aio.c +++ b/block/linux-aio.c @@ -443,7 +443,7 @@ int coroutine_fn laio_co_submit(int fd, uint64_t offset, QEMUIOVector *qiov, void laio_detach_aio_context(LinuxAioState *s, AioContext *old_context) { - aio_set_event_notifier(old_context, &s->e, false, NULL, NULL, NULL); + aio_set_event_notifier(old_context, &s->e, NULL, NULL, NULL); qemu_bh_delete(s->completion_bh); s->aio_context = NULL; } @@ -452,7 +452,7 @@ void laio_attach_aio_context(LinuxAioState *s, AioContext *new_context) { s->aio_context = new_context; s->completion_bh = aio_bh_new(new_context, qemu_laio_completion_bh, s); - aio_set_event_notifier(new_context, &s->e, false, + aio_set_event_notifier(new_context, &s->e, qemu_laio_completion_cb, qemu_laio_poll_cb, qemu_laio_poll_ready); diff --git a/block/nfs.c b/block/nfs.c index 006045d71a..8f89ece69f 100644 --- a/block/nfs.c +++ b/block/nfs.c @@ -195,7 +195,6 @@ static void nfs_set_events(NFSClient *client) int ev = nfs_which_events(client->context); if (ev != client->events) { aio_set_fd_handler(client->aio_context, nfs_get_fd(client->context), - false, (ev & POLLIN) ? nfs_process_read : NULL, (ev & POLLOUT) ? nfs_process_write : NULL, NULL, NULL, client); @@ -373,7 +372,7 @@ static void nfs_detach_aio_context(BlockDriverState *bs) NFSClient *client = bs->opaque; aio_set_fd_handler(client->aio_context, nfs_get_fd(client->context), - false, NULL, NULL, NULL, NULL, NULL); + NULL, NULL, NULL, NULL, NULL); client->events = 0; } @@ -391,7 +390,7 @@ static void nfs_client_close(NFSClient *client) if (client->context) { qemu_mutex_lock(&client->mutex); aio_set_fd_handler(client->aio_context, nfs_get_fd(client->context), - false, NULL, NULL, NULL, NULL, NULL); + NULL, NULL, NULL, NULL, NULL); qemu_mutex_unlock(&client->mutex); if (client->fh) { nfs_close(client->context, client->fh); diff --git a/block/nvme.c b/block/nvme.c index 5b744c2bda..17937d398d 100644 --- a/block/nvme.c +++ b/block/nvme.c @@ -862,7 +862,7 @@ static int nvme_init(BlockDriverState *bs, const char *device, int namespace, } aio_set_event_notifier(bdrv_get_aio_context(bs), &s->irq_notifier[MSIX_SHARED_IRQ_IDX], - false, nvme_handle_event, nvme_poll_cb, + nvme_handle_event, nvme_poll_cb, nvme_poll_ready); if (!nvme_identify(bs, namespace, errp)) { @@ -948,7 +948,7 @@ static void nvme_close(BlockDriverState *bs) g_free(s->queues); aio_set_event_notifier(bdrv_get_aio_context(bs), &s->irq_notifier[MSIX_SHARED_IRQ_IDX], - false, NULL, NULL, NULL); + NULL, NULL, NULL); event_notifier_cleanup(&s->irq_notifier[MSIX_SHARED_IRQ_IDX]); qemu_vfio_pci_unmap_bar(s->vfio, 0, s->bar0_wo_map, 0, sizeof(NvmeBar) + NVME_DOORBELL_SIZE); @@ -1546,7 +1546,7 @@ static void nvme_detach_aio_context(BlockDriverState *bs) aio_set_event_notifier(bdrv_get_aio_context(bs), &s->irq_notifier[MSIX_SHARED_IRQ_IDX], - false, NULL, NULL, NULL); + NULL, NULL, NULL); } static void nvme_attach_aio_context(BlockDriverState *bs, @@ -1556,7 +1556,7 @@ static void nvme_attach_aio_context(BlockDriverState *bs, s->aio_context = new_context; aio_set_event_notifier(new_context, &s->irq_notifier[MSIX_SHARED_IRQ_IDX], - false, nvme_handle_event, nvme_poll_cb, + nvme_handle_event, nvme_poll_cb, nvme_poll_ready); for (unsigned i = 0; i < s->queue_count; i++) { diff --git a/block/ssh.c b/block/ssh.c index b3b3352075..2748253d4a 100644 --- a/block/ssh.c +++ b/block/ssh.c @@ -1019,7 +1019,7 @@ static void restart_coroutine(void *opaque) AioContext *ctx = bdrv_get_aio_context(bs); trace_ssh_restart_coroutine(restart->co); - aio_set_fd_handler(ctx, s->sock, false, NULL, NULL, NULL, NULL, NULL); + aio_set_fd_handler(ctx, s->sock, NULL, NULL, NULL, NULL, NULL); aio_co_wake(restart->co); } @@ -1049,7 +1049,7 @@ static coroutine_fn void co_yield(BDRVSSHState *s, BlockDriverState *bs) trace_ssh_co_yield(s->sock, rd_handler, wr_handler); aio_set_fd_handler(bdrv_get_aio_context(bs), s->sock, - false, rd_handler, wr_handler, NULL, NULL, &restart); + rd_handler, wr_handler, NULL, NULL, &restart); qemu_coroutine_yield(); trace_ssh_co_yield_back(s->sock); } diff --git a/block/win32-aio.c b/block/win32-aio.c index ee87d6048f..6327861e1d 100644 --- a/block/win32-aio.c +++ b/block/win32-aio.c @@ -174,7 +174,7 @@ int win32_aio_attach(QEMUWin32AIOState *aio, HANDLE hfile) void win32_aio_detach_aio_context(QEMUWin32AIOState *aio, AioContext *old_context) { - aio_set_event_notifier(old_context, &aio->e, false, NULL, NULL, NULL); + aio_set_event_notifier(old_context, &aio->e, NULL, NULL, NULL); aio->aio_ctx = NULL; } @@ -182,8 +182,8 @@ void win32_aio_attach_aio_context(QEMUWin32AIOState *aio, AioContext *new_context) { aio->aio_ctx = new_context; - aio_set_event_notifier(new_context, &aio->e, false, - win32_aio_completion_cb, NULL, NULL); + aio_set_event_notifier(new_context, &aio->e, win32_aio_completion_cb, + NULL, NULL); } QEMUWin32AIOState *win32_aio_init(void) diff --git a/hw/i386/kvm/xen_xenstore.c b/hw/i386/kvm/xen_xenstore.c index 6e81bc8791..0b189c6ab8 100644 --- a/hw/i386/kvm/xen_xenstore.c +++ b/hw/i386/kvm/xen_xenstore.c @@ -133,7 +133,7 @@ static void xen_xenstore_realize(DeviceState *dev, Error **errp) error_setg(errp, "Xenstore evtchn port init failed"); return; } - aio_set_fd_handler(qemu_get_aio_context(), xen_be_evtchn_fd(s->eh), false, + aio_set_fd_handler(qemu_get_aio_context(), xen_be_evtchn_fd(s->eh), xen_xenstore_event, NULL, NULL, NULL, s); s->impl = xs_impl_create(xen_domid); diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 9cdad7e550..d48e240c37 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -3491,7 +3491,7 @@ static void virtio_queue_host_notifier_aio_poll_end(EventNotifier *n) void virtio_queue_aio_attach_host_notifier(VirtQueue *vq, AioContext *ctx) { - aio_set_event_notifier(ctx, &vq->host_notifier, false, + aio_set_event_notifier(ctx, &vq->host_notifier, virtio_queue_host_notifier_read, virtio_queue_host_notifier_aio_poll, virtio_queue_host_notifier_aio_poll_ready); @@ -3508,14 +3508,14 @@ void virtio_queue_aio_attach_host_notifier(VirtQueue *vq, AioContext *ctx) */ void virtio_queue_aio_attach_host_notifier_no_poll(VirtQueue *vq, AioContext *ctx) { - aio_set_event_notifier(ctx, &vq->host_notifier, false, + aio_set_event_notifier(ctx, &vq->host_notifier, virtio_queue_host_notifier_read, NULL, NULL); } void virtio_queue_aio_detach_host_notifier(VirtQueue *vq, AioContext *ctx) { - aio_set_event_notifier(ctx, &vq->host_notifier, false, NULL, NULL, NULL); + aio_set_event_notifier(ctx, &vq->host_notifier, NULL, NULL, NULL); /* Test and clear notifier before after disabling event, * in case poll callback didn't have time to run. */ virtio_queue_host_notifier_read(&vq->host_notifier); diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c index bf256d4da2..1e08cf027a 100644 --- a/hw/xen/xen-bus.c +++ b/hw/xen/xen-bus.c @@ -842,14 +842,14 @@ void xen_device_set_event_channel_context(XenDevice *xendev, } if (channel->ctx) - aio_set_fd_handler(channel->ctx, qemu_xen_evtchn_fd(channel->xeh), false, + aio_set_fd_handler(channel->ctx, qemu_xen_evtchn_fd(channel->xeh), NULL, NULL, NULL, NULL, NULL); channel->ctx = ctx; if (ctx) { aio_set_fd_handler(channel->ctx, qemu_xen_evtchn_fd(channel->xeh), - false, xen_device_event, NULL, xen_device_poll, - NULL, channel); + xen_device_event, NULL, xen_device_poll, NULL, + channel); } } @@ -923,7 +923,7 @@ void xen_device_unbind_event_channel(XenDevice *xendev, QLIST_REMOVE(channel, list); - aio_set_fd_handler(channel->ctx, qemu_xen_evtchn_fd(channel->xeh), false, + aio_set_fd_handler(channel->ctx, qemu_xen_evtchn_fd(channel->xeh), NULL, NULL, NULL, NULL, NULL); if (qemu_xen_evtchn_unbind(channel->xeh, channel->local_port) < 0) { diff --git a/io/channel-command.c b/io/channel-command.c index e7edd091af..7ed726c802 100644 --- a/io/channel-command.c +++ b/io/channel-command.c @@ -337,10 +337,8 @@ static void qio_channel_command_set_aio_fd_handler(QIOChannel *ioc, void *opaque) { QIOChannelCommand *cioc = QIO_CHANNEL_COMMAND(ioc); - aio_set_fd_handler(ctx, cioc->readfd, false, - io_read, NULL, NULL, NULL, opaque); - aio_set_fd_handler(ctx, cioc->writefd, false, - NULL, io_write, NULL, NULL, opaque); + aio_set_fd_handler(ctx, cioc->readfd, io_read, NULL, NULL, NULL, opaque); + aio_set_fd_handler(ctx, cioc->writefd, NULL, io_write, NULL, NULL, opaque); } diff --git a/io/channel-file.c b/io/channel-file.c index d76663e6ae..8b5821f452 100644 --- a/io/channel-file.c +++ b/io/channel-file.c @@ -198,8 +198,7 @@ static void qio_channel_file_set_aio_fd_handler(QIOChannel *ioc, void *opaque) { QIOChannelFile *fioc = QIO_CHANNEL_FILE(ioc); - aio_set_fd_handler(ctx, fioc->fd, false, io_read, io_write, - NULL, NULL, opaque); + aio_set_fd_handler(ctx, fioc->fd, io_read, io_write, NULL, NULL, opaque); } static GSource *qio_channel_file_create_watch(QIOChannel *ioc, diff --git a/io/channel-socket.c b/io/channel-socket.c index b0ea7d48b3..d99945ebec 100644 --- a/io/channel-socket.c +++ b/io/channel-socket.c @@ -899,8 +899,7 @@ static void qio_channel_socket_set_aio_fd_handler(QIOChannel *ioc, void *opaque) { QIOChannelSocket *sioc = QIO_CHANNEL_SOCKET(ioc); - aio_set_fd_handler(ctx, sioc->fd, false, - io_read, io_write, NULL, NULL, opaque); + aio_set_fd_handler(ctx, sioc->fd, io_read, io_write, NULL, NULL, opaque); } static GSource *qio_channel_socket_create_watch(QIOChannel *ioc, diff --git a/migration/rdma.c b/migration/rdma.c index 7e747b2595..afb8761a06 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -3110,15 +3110,15 @@ static void qio_channel_rdma_set_aio_fd_handler(QIOChannel *ioc, { QIOChannelRDMA *rioc = QIO_CHANNEL_RDMA(ioc); if (io_read) { - aio_set_fd_handler(ctx, rioc->rdmain->recv_comp_channel->fd, - false, io_read, io_write, NULL, NULL, opaque); - aio_set_fd_handler(ctx, rioc->rdmain->send_comp_channel->fd, - false, io_read, io_write, NULL, NULL, opaque); + aio_set_fd_handler(ctx, rioc->rdmain->recv_comp_channel->fd, io_read, + io_write, NULL, NULL, opaque); + aio_set_fd_handler(ctx, rioc->rdmain->send_comp_channel->fd, io_read, + io_write, NULL, NULL, opaque); } else { - aio_set_fd_handler(ctx, rioc->rdmaout->recv_comp_channel->fd, - false, io_read, io_write, NULL, NULL, opaque); - aio_set_fd_handler(ctx, rioc->rdmaout->send_comp_channel->fd, - false, io_read, io_write, NULL, NULL, opaque); + aio_set_fd_handler(ctx, rioc->rdmaout->recv_comp_channel->fd, io_read, + io_write, NULL, NULL, opaque); + aio_set_fd_handler(ctx, rioc->rdmaout->send_comp_channel->fd, io_read, + io_write, NULL, NULL, opaque); } } diff --git a/tests/unit/test-aio.c b/tests/unit/test-aio.c index 321d7ab01a..519440eed3 100644 --- a/tests/unit/test-aio.c +++ b/tests/unit/test-aio.c @@ -130,7 +130,7 @@ static void *test_acquire_thread(void *opaque) static void set_event_notifier(AioContext *ctx, EventNotifier *notifier, EventNotifierHandler *handler) { - aio_set_event_notifier(ctx, notifier, false, handler, NULL, NULL); + aio_set_event_notifier(ctx, notifier, handler, NULL, NULL); } static void dummy_notifier_read(EventNotifier *n) @@ -383,30 +383,6 @@ static void test_flush_event_notifier(void) event_notifier_cleanup(&data.e); } -static void test_aio_external_client(void) -{ - int i, j; - - for (i = 1; i < 3; i++) { - EventNotifierTestData data = { .n = 0, .active = 10, .auto_set = true }; - event_notifier_init(&data.e, false); - aio_set_event_notifier(ctx, &data.e, true, event_ready_cb, NULL, NULL); - event_notifier_set(&data.e); - for (j = 0; j < i; j++) { - aio_disable_external(ctx); - } - for (j = 0; j < i; j++) { - assert(!aio_poll(ctx, false)); - assert(event_notifier_test_and_clear(&data.e)); - event_notifier_set(&data.e); - aio_enable_external(ctx); - } - assert(aio_poll(ctx, false)); - set_event_notifier(ctx, &data.e, NULL); - event_notifier_cleanup(&data.e); - } -} - static void test_wait_event_notifier_noflush(void) { EventNotifierTestData data = { .n = 0 }; @@ -935,7 +911,6 @@ int main(int argc, char **argv) g_test_add_func("/aio/event/wait", test_wait_event_notifier); g_test_add_func("/aio/event/wait/no-flush-cb", test_wait_event_notifier_noflush); g_test_add_func("/aio/event/flush", test_flush_event_notifier); - g_test_add_func("/aio/external-client", test_aio_external_client); g_test_add_func("/aio/timer/schedule", test_timer_schedule); g_test_add_func("/aio/coroutine/queue-chaining", test_queue_chaining); diff --git a/tests/unit/test-bdrv-drain.c b/tests/unit/test-bdrv-drain.c index dc3cb9e0e3..9cac61c2bf 100644 --- a/tests/unit/test-bdrv-drain.c +++ b/tests/unit/test-bdrv-drain.c @@ -435,7 +435,6 @@ static void test_graph_change_drain_all(void) g_assert_cmpint(bs_b->quiesce_counter, ==, 0); g_assert_cmpint(b_s->drain_count, ==, 0); - g_assert_cmpint(qemu_get_aio_context()->external_disable_cnt, ==, 0); bdrv_unref(bs_b); blk_unref(blk_b); diff --git a/tests/unit/test-fdmon-epoll.c b/tests/unit/test-fdmon-epoll.c deleted file mode 100644 index ef5a856d09..0000000000 --- a/tests/unit/test-fdmon-epoll.c +++ /dev/null @@ -1,73 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ -/* - * fdmon-epoll tests - * - * Copyright (c) 2020 Red Hat, Inc. - */ - -#include "qemu/osdep.h" -#include "block/aio.h" -#include "qapi/error.h" -#include "qemu/main-loop.h" - -static AioContext *ctx; - -static void dummy_fd_handler(EventNotifier *notifier) -{ - event_notifier_test_and_clear(notifier); -} - -static void add_event_notifiers(EventNotifier *notifiers, size_t n) -{ - for (size_t i = 0; i < n; i++) { - event_notifier_init(¬ifiers[i], false); - aio_set_event_notifier(ctx, ¬ifiers[i], false, - dummy_fd_handler, NULL, NULL); - } -} - -static void remove_event_notifiers(EventNotifier *notifiers, size_t n) -{ - for (size_t i = 0; i < n; i++) { - aio_set_event_notifier(ctx, ¬ifiers[i], false, NULL, NULL, NULL); - event_notifier_cleanup(¬ifiers[i]); - } -} - -/* Check that fd handlers work when external clients are disabled */ -static void test_external_disabled(void) -{ - EventNotifier notifiers[100]; - - /* fdmon-epoll is only enabled when many fd handlers are registered */ - add_event_notifiers(notifiers, G_N_ELEMENTS(notifiers)); - - event_notifier_set(¬ifiers[0]); - assert(aio_poll(ctx, true)); - - aio_disable_external(ctx); - event_notifier_set(¬ifiers[0]); - assert(aio_poll(ctx, true)); - aio_enable_external(ctx); - - remove_event_notifiers(notifiers, G_N_ELEMENTS(notifiers)); -} - -int main(int argc, char **argv) -{ - /* - * This code relies on the fact that fdmon-io_uring disables itself when - * the glib main loop is in use. The main loop uses fdmon-poll and upgrades - * to fdmon-epoll when the number of fds exceeds a threshold. - */ - qemu_init_main_loop(&error_fatal); - ctx = qemu_get_aio_context(); - - while (g_main_context_iteration(NULL, false)) { - /* Do nothing */ - } - - g_test_init(&argc, &argv, NULL); - g_test_add_func("/fdmon-epoll/external-disabled", test_external_disabled); - return g_test_run(); -} diff --git a/util/aio-posix.c b/util/aio-posix.c index a8be940f76..934b1bbb85 100644 --- a/util/aio-posix.c +++ b/util/aio-posix.c @@ -99,7 +99,6 @@ static bool aio_remove_fd_handler(AioContext *ctx, AioHandler *node) void aio_set_fd_handler(AioContext *ctx, int fd, - bool is_external, IOHandler *io_read, IOHandler *io_write, AioPollFn *io_poll, @@ -144,7 +143,6 @@ void aio_set_fd_handler(AioContext *ctx, new_node->io_poll = io_poll; new_node->io_poll_ready = io_poll_ready; new_node->opaque = opaque; - new_node->is_external = is_external; if (is_new) { new_node->pfd.fd = fd; @@ -196,12 +194,11 @@ static void aio_set_fd_poll(AioContext *ctx, int fd, void aio_set_event_notifier(AioContext *ctx, EventNotifier *notifier, - bool is_external, EventNotifierHandler *io_read, AioPollFn *io_poll, EventNotifierHandler *io_poll_ready) { - aio_set_fd_handler(ctx, event_notifier_get_fd(notifier), is_external, + aio_set_fd_handler(ctx, event_notifier_get_fd(notifier), (IOHandler *)io_read, NULL, io_poll, (IOHandler *)io_poll_ready, notifier); } @@ -285,13 +282,11 @@ bool aio_pending(AioContext *ctx) /* TODO should this check poll ready? */ revents = node->pfd.revents & node->pfd.events; - if (revents & (G_IO_IN | G_IO_HUP | G_IO_ERR) && node->io_read && - aio_node_check(ctx, node->is_external)) { + if (revents & (G_IO_IN | G_IO_HUP | G_IO_ERR) && node->io_read) { result = true; break; } - if (revents & (G_IO_OUT | G_IO_ERR) && node->io_write && - aio_node_check(ctx, node->is_external)) { + if (revents & (G_IO_OUT | G_IO_ERR) && node->io_write) { result = true; break; } @@ -350,9 +345,7 @@ static bool aio_dispatch_handler(AioContext *ctx, AioHandler *node) QLIST_INSERT_HEAD(&ctx->poll_aio_handlers, node, node_poll); } if (!QLIST_IS_INSERTED(node, node_deleted) && - poll_ready && revents == 0 && - aio_node_check(ctx, node->is_external) && - node->io_poll_ready) { + poll_ready && revents == 0 && node->io_poll_ready) { node->io_poll_ready(node->opaque); /* @@ -364,7 +357,6 @@ static bool aio_dispatch_handler(AioContext *ctx, AioHandler *node) if (!QLIST_IS_INSERTED(node, node_deleted) && (revents & (G_IO_IN | G_IO_HUP | G_IO_ERR)) && - aio_node_check(ctx, node->is_external) && node->io_read) { node->io_read(node->opaque); @@ -375,7 +367,6 @@ static bool aio_dispatch_handler(AioContext *ctx, AioHandler *node) } if (!QLIST_IS_INSERTED(node, node_deleted) && (revents & (G_IO_OUT | G_IO_ERR)) && - aio_node_check(ctx, node->is_external) && node->io_write) { node->io_write(node->opaque); progress = true; @@ -436,8 +427,7 @@ static bool run_poll_handlers_once(AioContext *ctx, AioHandler *tmp; QLIST_FOREACH_SAFE(node, &ctx->poll_aio_handlers, node_poll, tmp) { - if (aio_node_check(ctx, node->is_external) && - node->io_poll(node->opaque)) { + if (node->io_poll(node->opaque)) { aio_add_poll_ready_handler(ready_list, node); node->poll_idle_timeout = now + POLL_IDLE_INTERVAL_NS; diff --git a/util/aio-win32.c b/util/aio-win32.c index 6bded009a4..948ef47a4d 100644 --- a/util/aio-win32.c +++ b/util/aio-win32.c @@ -32,7 +32,6 @@ struct AioHandler { GPollFD pfd; int deleted; void *opaque; - bool is_external; QLIST_ENTRY(AioHandler) node; }; @@ -64,7 +63,6 @@ static void aio_remove_fd_handler(AioContext *ctx, AioHandler *node) void aio_set_fd_handler(AioContext *ctx, int fd, - bool is_external, IOHandler *io_read, IOHandler *io_write, AioPollFn *io_poll, @@ -111,7 +109,6 @@ void aio_set_fd_handler(AioContext *ctx, node->opaque = opaque; node->io_read = io_read; node->io_write = io_write; - node->is_external = is_external; if (io_read) { bitmask |= FD_READ | FD_ACCEPT | FD_CLOSE; @@ -135,7 +132,6 @@ void aio_set_fd_handler(AioContext *ctx, void aio_set_event_notifier(AioContext *ctx, EventNotifier *e, - bool is_external, EventNotifierHandler *io_notify, AioPollFn *io_poll, EventNotifierHandler *io_poll_ready) @@ -161,7 +157,6 @@ void aio_set_event_notifier(AioContext *ctx, node->e = e; node->pfd.fd = (uintptr_t)event_notifier_get_handle(e); node->pfd.events = G_IO_IN; - node->is_external = is_external; QLIST_INSERT_HEAD_RCU(&ctx->aio_handlers, node, node); g_source_add_poll(&ctx->source, &node->pfd); @@ -368,8 +363,7 @@ bool aio_poll(AioContext *ctx, bool blocking) /* fill fd sets */ count = 0; QLIST_FOREACH_RCU(node, &ctx->aio_handlers, node) { - if (!node->deleted && node->io_notify - && aio_node_check(ctx, node->is_external)) { + if (!node->deleted && node->io_notify) { assert(count < MAXIMUM_WAIT_OBJECTS); events[count++] = event_notifier_get_handle(node->e); } diff --git a/util/async.c b/util/async.c index 055070ffbd..8f90ddc304 100644 --- a/util/async.c +++ b/util/async.c @@ -409,7 +409,7 @@ aio_ctx_finalize(GSource *source) g_free(bh); } - aio_set_event_notifier(ctx, &ctx->notifier, false, NULL, NULL, NULL); + aio_set_event_notifier(ctx, &ctx->notifier, NULL, NULL, NULL); event_notifier_cleanup(&ctx->notifier); qemu_rec_mutex_destroy(&ctx->lock); qemu_lockcnt_destroy(&ctx->list_lock); @@ -593,7 +593,6 @@ AioContext *aio_context_new(Error **errp) QSLIST_INIT(&ctx->scheduled_coroutines); aio_set_event_notifier(ctx, &ctx->notifier, - false, aio_context_notifier_cb, aio_context_notifier_poll, aio_context_notifier_poll_ready); diff --git a/util/fdmon-epoll.c b/util/fdmon-epoll.c index 1683aa1105..6b6a1a91f8 100644 --- a/util/fdmon-epoll.c +++ b/util/fdmon-epoll.c @@ -64,11 +64,6 @@ static int fdmon_epoll_wait(AioContext *ctx, AioHandlerList *ready_list, int i, ret = 0; struct epoll_event events[128]; - /* Fall back while external clients are disabled */ - if (qatomic_read(&ctx->external_disable_cnt)) { - return fdmon_poll_ops.wait(ctx, ready_list, timeout); - } - if (timeout > 0) { ret = qemu_poll_ns(&pfd, 1, timeout); if (ret > 0) { @@ -133,13 +128,12 @@ bool fdmon_epoll_try_upgrade(AioContext *ctx, unsigned npfd) return false; } - /* Do not upgrade while external clients are disabled */ - if (qatomic_read(&ctx->external_disable_cnt)) { - return false; - } - - if (npfd < EPOLL_ENABLE_THRESHOLD) { - return false; + if (npfd >= EPOLL_ENABLE_THRESHOLD) { + if (fdmon_epoll_try_enable(ctx)) { + return true; + } else { + fdmon_epoll_disable(ctx); + } } /* The list must not change while we add fds to epoll */ diff --git a/util/fdmon-io_uring.c b/util/fdmon-io_uring.c index ab43052dd7..17ec18b7bd 100644 --- a/util/fdmon-io_uring.c +++ b/util/fdmon-io_uring.c @@ -276,11 +276,6 @@ static int fdmon_io_uring_wait(AioContext *ctx, AioHandlerList *ready_list, unsigned wait_nr = 1; /* block until at least one cqe is ready */ int ret; - /* Fall back while external clients are disabled */ - if (qatomic_read(&ctx->external_disable_cnt)) { - return fdmon_poll_ops.wait(ctx, ready_list, timeout); - } - if (timeout == 0) { wait_nr = 0; /* non-blocking */ } else if (timeout > 0) { @@ -315,8 +310,7 @@ static bool fdmon_io_uring_need_wait(AioContext *ctx) return true; } - /* Are we falling back to fdmon-poll? */ - return qatomic_read(&ctx->external_disable_cnt); + return false; } static const FDMonOps fdmon_io_uring_ops = { diff --git a/util/fdmon-poll.c b/util/fdmon-poll.c index 5fe3b47865..17df917cf9 100644 --- a/util/fdmon-poll.c +++ b/util/fdmon-poll.c @@ -65,8 +65,7 @@ static int fdmon_poll_wait(AioContext *ctx, AioHandlerList *ready_list, assert(npfd == 0); QLIST_FOREACH_RCU(node, &ctx->aio_handlers, node) { - if (!QLIST_IS_INSERTED(node, node_deleted) && node->pfd.events - && aio_node_check(ctx, node->is_external)) { + if (!QLIST_IS_INSERTED(node, node_deleted) && node->pfd.events) { add_pollfd(node); } } diff --git a/util/main-loop.c b/util/main-loop.c index 7022f02ef8..014c795916 100644 --- a/util/main-loop.c +++ b/util/main-loop.c @@ -644,14 +644,13 @@ void qemu_set_fd_handler(int fd, void *opaque) { iohandler_init(); - aio_set_fd_handler(iohandler_ctx, fd, false, - fd_read, fd_write, NULL, NULL, opaque); + aio_set_fd_handler(iohandler_ctx, fd, fd_read, fd_write, NULL, NULL, + opaque); } void event_notifier_set_handler(EventNotifier *e, EventNotifierHandler *handler) { iohandler_init(); - aio_set_event_notifier(iohandler_ctx, e, false, - handler, NULL, NULL); + aio_set_event_notifier(iohandler_ctx, e, handler, NULL, NULL); } diff --git a/util/qemu-coroutine-io.c b/util/qemu-coroutine-io.c index d791932d63..364f4d5abf 100644 --- a/util/qemu-coroutine-io.c +++ b/util/qemu-coroutine-io.c @@ -74,8 +74,7 @@ typedef struct { static void fd_coroutine_enter(void *opaque) { FDYieldUntilData *data = opaque; - aio_set_fd_handler(data->ctx, data->fd, false, - NULL, NULL, NULL, NULL, NULL); + aio_set_fd_handler(data->ctx, data->fd, NULL, NULL, NULL, NULL, NULL); qemu_coroutine_enter(data->co); } @@ -87,7 +86,7 @@ void coroutine_fn yield_until_fd_readable(int fd) data.ctx = qemu_get_current_aio_context(); data.co = qemu_coroutine_self(); data.fd = fd; - aio_set_fd_handler( - data.ctx, fd, false, fd_coroutine_enter, NULL, NULL, NULL, &data); + aio_set_fd_handler(data.ctx, fd, fd_coroutine_enter, NULL, NULL, NULL, + &data); qemu_coroutine_yield(); } diff --git a/util/vhost-user-server.c b/util/vhost-user-server.c index a12b2d1bba..cd17fb5326 100644 --- a/util/vhost-user-server.c +++ b/util/vhost-user-server.c @@ -278,7 +278,7 @@ set_watch(VuDev *vu_dev, int fd, int vu_evt, vu_fd_watch->fd = fd; vu_fd_watch->cb = cb; qemu_socket_set_nonblock(fd); - aio_set_fd_handler(server->ioc->ctx, fd, false, kick_handler, + aio_set_fd_handler(server->ioc->ctx, fd, kick_handler, NULL, NULL, NULL, vu_fd_watch); vu_fd_watch->vu_dev = vu_dev; vu_fd_watch->pvt = pvt; @@ -299,8 +299,7 @@ static void remove_watch(VuDev *vu_dev, int fd) if (!vu_fd_watch) { return; } - aio_set_fd_handler(server->ioc->ctx, fd, false, - NULL, NULL, NULL, NULL, NULL); + aio_set_fd_handler(server->ioc->ctx, fd, NULL, NULL, NULL, NULL, NULL); QTAILQ_REMOVE(&server->vu_fd_watches, vu_fd_watch, next); g_free(vu_fd_watch); @@ -362,7 +361,7 @@ void vhost_user_server_stop(VuServer *server) VuFdWatch *vu_fd_watch; QTAILQ_FOREACH(vu_fd_watch, &server->vu_fd_watches, next) { - aio_set_fd_handler(server->ctx, vu_fd_watch->fd, false, + aio_set_fd_handler(server->ctx, vu_fd_watch->fd, NULL, NULL, NULL, NULL, vu_fd_watch); } @@ -403,7 +402,7 @@ void vhost_user_server_attach_aio_context(VuServer *server, AioContext *ctx) qio_channel_attach_aio_context(server->ioc, ctx); QTAILQ_FOREACH(vu_fd_watch, &server->vu_fd_watches, next) { - aio_set_fd_handler(ctx, vu_fd_watch->fd, false, kick_handler, NULL, + aio_set_fd_handler(ctx, vu_fd_watch->fd, kick_handler, NULL, NULL, NULL, vu_fd_watch); } @@ -417,7 +416,7 @@ void vhost_user_server_detach_aio_context(VuServer *server) VuFdWatch *vu_fd_watch; QTAILQ_FOREACH(vu_fd_watch, &server->vu_fd_watches, next) { - aio_set_fd_handler(server->ctx, vu_fd_watch->fd, false, + aio_set_fd_handler(server->ctx, vu_fd_watch->fd, NULL, NULL, NULL, NULL, vu_fd_watch); } diff --git a/tests/unit/meson.build b/tests/unit/meson.build index 3bc78d8660..b33298a444 100644 --- a/tests/unit/meson.build +++ b/tests/unit/meson.build @@ -122,9 +122,6 @@ if have_block if nettle.found() or gcrypt.found() tests += {'test-crypto-pbkdf': [io]} endif - if config_host_data.get('CONFIG_EPOLL_CREATE1') - tests += {'test-fdmon-epoll': [testblock]} - endif endif if have_system -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Thu May 04 20:00:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 20:00:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530115.825506 (Exim 4.92) (envelope-from ) id 1puf7c-0005q2-QB; Thu, 04 May 2023 20:00:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530115.825506; Thu, 04 May 2023 20:00:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf7c-0005pv-Mx; Thu, 04 May 2023 20:00:12 +0000 Received: by outflank-mailman (input) for mailman id 530115; Thu, 04 May 2023 20:00:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf21-0003xx-RY for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:54:25 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 77395080-eab5-11ed-8611-37d641c3527e; Thu, 04 May 2023 21:54:23 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-86-xBjZ8_DjNQ-jsqK3HPfxEg-1; Thu, 04 May 2023 15:54:20 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A1B9C886063; Thu, 4 May 2023 19:54:19 +0000 (UTC) Received: from localhost (unknown [10.39.192.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id 297BC4020960; Thu, 4 May 2023 19:54:17 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 77395080-eab5-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683230062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ckhE010jxhkqU+qGTRwp1CzCNoAx+VwzdwbJyrduiJo=; b=Rb7XL2IIisdNrWUxDLBtrFscNuTsQ6sFpEbq52XDXOMQMPFyEC1acEeFZT27SJrqtnY2G7 iiBND0pYGclRy4EwyoQaKk16KGQKhG+pVveJJVFjkZmo/9hZD+JqClrrjgc7X5nluvEHL7 ZYTlIsK7dgI5cZvZNnP9xXW9pBTNLKY= X-MC-Unique: xBjZ8_DjNQ-jsqK3HPfxEg-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Ronnie Sahlberg , Aarushi Mehta , qemu-block@nongnu.org, Paul Durrant , Anthony Perard , Peter Lieven , Stefan Weil , Xie Yongji , Kevin Wolf , Paolo Bonzini , "Michael S. Tsirkin" , Leonardo Bras , Peter Xu , Hanna Reitz , Stefano Stabellini , Richard Henderson , David Woodhouse , Coiby Xu , Eduardo Habkost , Stefano Garzarella , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Stefan Hajnoczi , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Juan Quintela , "Richard W.M. Jones" , Fam Zheng , Marcel Apfelbaum Subject: [PATCH v5 19/21] virtio-scsi: implement BlockDevOps->drained_begin() Date: Thu, 4 May 2023 15:53:25 -0400 Message-Id: <20230504195327.695107-20-stefanha@redhat.com> In-Reply-To: <20230504195327.695107-1-stefanha@redhat.com> References: <20230504195327.695107-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 The virtio-scsi Host Bus Adapter provides access to devices on a SCSI bus. Those SCSI devices typically have a BlockBackend. When the BlockBackend enters a drained section, the SCSI device must temporarily stop submitting new I/O requests. Implement this behavior by temporarily stopping virtio-scsi virtqueue processing when one of the SCSI devices enters a drained section. The new scsi_device_drained_begin() API allows scsi-disk to message the virtio-scsi HBA. scsi_device_drained_begin() uses a drain counter so that multiple SCSI devices can have overlapping drained sections. The HBA only sees one pair of .drained_begin/end() calls. After this commit, virtio-scsi no longer depends on hw/virtio's ioeventfd aio_set_event_notifier(is_external=true). This commit is a step towards removing the aio_disable_external() API. Signed-off-by: Stefan Hajnoczi --- include/hw/scsi/scsi.h | 14 ++++++++++++ hw/scsi/scsi-bus.c | 40 +++++++++++++++++++++++++++++++++ hw/scsi/scsi-disk.c | 27 +++++++++++++++++----- hw/scsi/virtio-scsi-dataplane.c | 22 ++++++++++-------- hw/scsi/virtio-scsi.c | 38 +++++++++++++++++++++++++++++++ hw/scsi/trace-events | 2 ++ 6 files changed, 129 insertions(+), 14 deletions(-) diff --git a/include/hw/scsi/scsi.h b/include/hw/scsi/scsi.h index 6f23a7a73e..e2bb1a2fbf 100644 --- a/include/hw/scsi/scsi.h +++ b/include/hw/scsi/scsi.h @@ -133,6 +133,16 @@ struct SCSIBusInfo { void (*save_request)(QEMUFile *f, SCSIRequest *req); void *(*load_request)(QEMUFile *f, SCSIRequest *req); void (*free_request)(SCSIBus *bus, void *priv); + + /* + * Temporarily stop submitting new requests between drained_begin() and + * drained_end(). Called from the main loop thread with the BQL held. + * + * Implement these callbacks if request processing is triggered by a file + * descriptor like an EventNotifier. Otherwise set them to NULL. + */ + void (*drained_begin)(SCSIBus *bus); + void (*drained_end)(SCSIBus *bus); }; #define TYPE_SCSI_BUS "SCSI" @@ -144,6 +154,8 @@ struct SCSIBus { SCSISense unit_attention; const SCSIBusInfo *info; + + int drain_count; /* protected by BQL */ }; /** @@ -213,6 +225,8 @@ void scsi_req_cancel_complete(SCSIRequest *req); void scsi_req_cancel(SCSIRequest *req); void scsi_req_cancel_async(SCSIRequest *req, Notifier *notifier); void scsi_req_retry(SCSIRequest *req); +void scsi_device_drained_begin(SCSIDevice *sdev); +void scsi_device_drained_end(SCSIDevice *sdev); void scsi_device_purge_requests(SCSIDevice *sdev, SCSISense sense); void scsi_device_set_ua(SCSIDevice *sdev, SCSISense sense); void scsi_device_report_change(SCSIDevice *dev, SCSISense sense); diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c index 64013c8a24..f80f4cb4fc 100644 --- a/hw/scsi/scsi-bus.c +++ b/hw/scsi/scsi-bus.c @@ -1669,6 +1669,46 @@ void scsi_device_purge_requests(SCSIDevice *sdev, SCSISense sense) scsi_device_set_ua(sdev, sense); } +void scsi_device_drained_begin(SCSIDevice *sdev) +{ + SCSIBus *bus = DO_UPCAST(SCSIBus, qbus, sdev->qdev.parent_bus); + if (!bus) { + return; + } + + assert(qemu_get_current_aio_context() == qemu_get_aio_context()); + assert(bus->drain_count < INT_MAX); + + /* + * Multiple BlockBackends can be on a SCSIBus and each may begin/end + * draining at any time. Keep a counter so HBAs only see begin/end once. + */ + if (bus->drain_count++ == 0) { + trace_scsi_bus_drained_begin(bus, sdev); + if (bus->info->drained_begin) { + bus->info->drained_begin(bus); + } + } +} + +void scsi_device_drained_end(SCSIDevice *sdev) +{ + SCSIBus *bus = DO_UPCAST(SCSIBus, qbus, sdev->qdev.parent_bus); + if (!bus) { + return; + } + + assert(qemu_get_current_aio_context() == qemu_get_aio_context()); + assert(bus->drain_count > 0); + + if (bus->drain_count-- == 1) { + trace_scsi_bus_drained_end(bus, sdev); + if (bus->info->drained_end) { + bus->info->drained_end(bus); + } + } +} + static char *scsibus_get_dev_path(DeviceState *dev) { SCSIDevice *d = SCSI_DEVICE(dev); diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 97c9b1c8cd..e0d79c7966 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -2360,6 +2360,20 @@ static void scsi_disk_reset(DeviceState *dev) s->qdev.scsi_version = s->qdev.default_scsi_version; } +static void scsi_disk_drained_begin(void *opaque) +{ + SCSIDiskState *s = opaque; + + scsi_device_drained_begin(&s->qdev); +} + +static void scsi_disk_drained_end(void *opaque) +{ + SCSIDiskState *s = opaque; + + scsi_device_drained_end(&s->qdev); +} + static void scsi_disk_resize_cb(void *opaque) { SCSIDiskState *s = opaque; @@ -2414,16 +2428,19 @@ static bool scsi_cd_is_medium_locked(void *opaque) } static const BlockDevOps scsi_disk_removable_block_ops = { - .change_media_cb = scsi_cd_change_media_cb, + .change_media_cb = scsi_cd_change_media_cb, + .drained_begin = scsi_disk_drained_begin, + .drained_end = scsi_disk_drained_end, .eject_request_cb = scsi_cd_eject_request_cb, - .is_tray_open = scsi_cd_is_tray_open, .is_medium_locked = scsi_cd_is_medium_locked, - - .resize_cb = scsi_disk_resize_cb, + .is_tray_open = scsi_cd_is_tray_open, + .resize_cb = scsi_disk_resize_cb, }; static const BlockDevOps scsi_disk_block_ops = { - .resize_cb = scsi_disk_resize_cb, + .drained_begin = scsi_disk_drained_begin, + .drained_end = scsi_disk_drained_end, + .resize_cb = scsi_disk_resize_cb, }; static void scsi_disk_unit_attention_reported(SCSIDevice *dev) diff --git a/hw/scsi/virtio-scsi-dataplane.c b/hw/scsi/virtio-scsi-dataplane.c index 81643445ed..1060038e13 100644 --- a/hw/scsi/virtio-scsi-dataplane.c +++ b/hw/scsi/virtio-scsi-dataplane.c @@ -153,14 +153,16 @@ int virtio_scsi_dataplane_start(VirtIODevice *vdev) s->dataplane_starting = false; s->dataplane_started = true; - aio_context_acquire(s->ctx); - virtio_queue_aio_attach_host_notifier(vs->ctrl_vq, s->ctx); - virtio_queue_aio_attach_host_notifier_no_poll(vs->event_vq, s->ctx); + if (s->bus.drain_count == 0) { + aio_context_acquire(s->ctx); + virtio_queue_aio_attach_host_notifier(vs->ctrl_vq, s->ctx); + virtio_queue_aio_attach_host_notifier_no_poll(vs->event_vq, s->ctx); - for (i = 0; i < vs->conf.num_queues; i++) { - virtio_queue_aio_attach_host_notifier(vs->cmd_vqs[i], s->ctx); + for (i = 0; i < vs->conf.num_queues; i++) { + virtio_queue_aio_attach_host_notifier(vs->cmd_vqs[i], s->ctx); + } + aio_context_release(s->ctx); } - aio_context_release(s->ctx); return 0; fail_host_notifiers: @@ -206,9 +208,11 @@ void virtio_scsi_dataplane_stop(VirtIODevice *vdev) } s->dataplane_stopping = true; - aio_context_acquire(s->ctx); - aio_wait_bh_oneshot(s->ctx, virtio_scsi_dataplane_stop_bh, s); - aio_context_release(s->ctx); + if (s->bus.drain_count == 0) { + aio_context_acquire(s->ctx); + aio_wait_bh_oneshot(s->ctx, virtio_scsi_dataplane_stop_bh, s); + aio_context_release(s->ctx); + } blk_drain_all(); /* ensure there are no in-flight requests */ diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index c1a7ea9ae2..4a8849cc7e 100644 --- a/hw/scsi/virtio-scsi.c +++ b/hw/scsi/virtio-scsi.c @@ -1117,6 +1117,42 @@ static void virtio_scsi_hotunplug(HotplugHandler *hotplug_dev, DeviceState *dev, } } +/* Suspend virtqueue ioeventfd processing during drain */ +static void virtio_scsi_drained_begin(SCSIBus *bus) +{ + VirtIOSCSI *s = container_of(bus, VirtIOSCSI, bus); + VirtIODevice *vdev = VIRTIO_DEVICE(s); + uint32_t total_queues = VIRTIO_SCSI_VQ_NUM_FIXED + + s->parent_obj.conf.num_queues; + + if (!s->dataplane_started) { + return; + } + + for (uint32_t i = 0; i < total_queues; i++) { + VirtQueue *vq = virtio_get_queue(vdev, i); + virtio_queue_aio_detach_host_notifier(vq, s->ctx); + } +} + +/* Resume virtqueue ioeventfd processing after drain */ +static void virtio_scsi_drained_end(SCSIBus *bus) +{ + VirtIOSCSI *s = container_of(bus, VirtIOSCSI, bus); + VirtIODevice *vdev = VIRTIO_DEVICE(s); + uint32_t total_queues = VIRTIO_SCSI_VQ_NUM_FIXED + + s->parent_obj.conf.num_queues; + + if (!s->dataplane_started) { + return; + } + + for (uint32_t i = 0; i < total_queues; i++) { + VirtQueue *vq = virtio_get_queue(vdev, i); + virtio_queue_aio_attach_host_notifier(vq, s->ctx); + } +} + static struct SCSIBusInfo virtio_scsi_scsi_info = { .tcq = true, .max_channel = VIRTIO_SCSI_MAX_CHANNEL, @@ -1131,6 +1167,8 @@ static struct SCSIBusInfo virtio_scsi_scsi_info = { .get_sg_list = virtio_scsi_get_sg_list, .save_request = virtio_scsi_save_request, .load_request = virtio_scsi_load_request, + .drained_begin = virtio_scsi_drained_begin, + .drained_end = virtio_scsi_drained_end, }; void virtio_scsi_common_realize(DeviceState *dev, diff --git a/hw/scsi/trace-events b/hw/scsi/trace-events index ab238293f0..bdd4e2c7c7 100644 --- a/hw/scsi/trace-events +++ b/hw/scsi/trace-events @@ -6,6 +6,8 @@ scsi_req_cancel(int target, int lun, int tag) "target %d lun %d tag %d" scsi_req_data(int target, int lun, int tag, int len) "target %d lun %d tag %d len %d" scsi_req_data_canceled(int target, int lun, int tag, int len) "target %d lun %d tag %d len %d" scsi_req_dequeue(int target, int lun, int tag) "target %d lun %d tag %d" +scsi_bus_drained_begin(void *bus, void *sdev) "bus %p sdev %p" +scsi_bus_drained_end(void *bus, void *sdev) "bus %p sdev %p" scsi_req_continue(int target, int lun, int tag) "target %d lun %d tag %d" scsi_req_continue_canceled(int target, int lun, int tag) "target %d lun %d tag %d" scsi_req_parsed(int target, int lun, int tag, int cmd, int mode, int xfer) "target %d lun %d tag %d command %d dir %d length %d" -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Thu May 04 20:00:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 20:00:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530116.825511 (Exim 4.92) (envelope-from ) id 1puf7d-0005tz-5D; Thu, 04 May 2023 20:00:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530116.825511; Thu, 04 May 2023 20:00:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf7c-0005so-V1; Thu, 04 May 2023 20:00:12 +0000 Received: by outflank-mailman (input) for mailman id 530116; Thu, 04 May 2023 20:00:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf1t-0003iB-Vn for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:54:17 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7358d671-eab5-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:54:17 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-94-EVERd-b1O6iV68LQZZKd_A-1; Thu, 04 May 2023 15:54:10 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EC0B6A0F389; Thu, 4 May 2023 19:54:08 +0000 (UTC) Received: from localhost (unknown [10.39.192.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id 51B294020960; Thu, 4 May 2023 19:54:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7358d671-eab5-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683230056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bn7vYKIN4BAATa1eS0drL+2+35bJodnZI5fsBJiYTKs=; b=E6pRBqtnxp0TP87WMNL+URfi5WzVeWaz1lK3LF8Jf47/gjBQowXxde02YVjVwNLuWbYNB6 /rdqsEIHgki4Ndsn5e4KruXtYhgcERq6rdpvSzIUwB4XwmDVj+6aHHHTb3nU8KQ4D9QD4j SzHpPG6CzzghWV6mKeKo/CVRplBXH5g= X-MC-Unique: EVERd-b1O6iV68LQZZKd_A-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Ronnie Sahlberg , Aarushi Mehta , qemu-block@nongnu.org, Paul Durrant , Anthony Perard , Peter Lieven , Stefan Weil , Xie Yongji , Kevin Wolf , Paolo Bonzini , "Michael S. Tsirkin" , Leonardo Bras , Peter Xu , Hanna Reitz , Stefano Stabellini , Richard Henderson , David Woodhouse , Coiby Xu , Eduardo Habkost , Stefano Garzarella , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Stefan Hajnoczi , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Juan Quintela , "Richard W.M. Jones" , Fam Zheng , Marcel Apfelbaum Subject: [PATCH v5 15/21] block/export: don't require AioContext lock around blk_exp_ref/unref() Date: Thu, 4 May 2023 15:53:21 -0400 Message-Id: <20230504195327.695107-16-stefanha@redhat.com> In-Reply-To: <20230504195327.695107-1-stefanha@redhat.com> References: <20230504195327.695107-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 The FUSE export calls blk_exp_ref/unref() without the AioContext lock. Instead of fixing the FUSE export, adjust blk_exp_ref/unref() so they work without the AioContext lock. This way it's less error-prone. Suggested-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- include/block/export.h | 2 ++ block/export/export.c | 13 ++++++------- block/export/vduse-blk.c | 4 ---- 3 files changed, 8 insertions(+), 11 deletions(-) diff --git a/include/block/export.h b/include/block/export.h index 7feb02e10d..f2fe0f8078 100644 --- a/include/block/export.h +++ b/include/block/export.h @@ -57,6 +57,8 @@ struct BlockExport { * Reference count for this block export. This includes strong references * both from the owner (qemu-nbd or the monitor) and clients connected to * the export. + * + * Use atomics to access this field. */ int refcount; diff --git a/block/export/export.c b/block/export/export.c index 62c7c22d45..ab007e9d31 100644 --- a/block/export/export.c +++ b/block/export/export.c @@ -202,11 +202,10 @@ fail: return NULL; } -/* Callers must hold exp->ctx lock */ void blk_exp_ref(BlockExport *exp) { - assert(exp->refcount > 0); - exp->refcount++; + assert(qatomic_read(&exp->refcount) > 0); + qatomic_inc(&exp->refcount); } /* Runs in the main thread */ @@ -229,11 +228,10 @@ static void blk_exp_delete_bh(void *opaque) aio_context_release(aio_context); } -/* Callers must hold exp->ctx lock */ void blk_exp_unref(BlockExport *exp) { - assert(exp->refcount > 0); - if (--exp->refcount == 0) { + assert(qatomic_read(&exp->refcount) > 0); + if (qatomic_fetch_dec(&exp->refcount) == 1) { /* Touch the block_exports list only in the main thread */ aio_bh_schedule_oneshot(qemu_get_aio_context(), blk_exp_delete_bh, exp); @@ -341,7 +339,8 @@ void qmp_block_export_del(const char *id, if (!has_mode) { mode = BLOCK_EXPORT_REMOVE_MODE_SAFE; } - if (mode == BLOCK_EXPORT_REMOVE_MODE_SAFE && exp->refcount > 1) { + if (mode == BLOCK_EXPORT_REMOVE_MODE_SAFE && + qatomic_read(&exp->refcount) > 1) { error_setg(errp, "export '%s' still in use", exp->id); error_append_hint(errp, "Use mode='hard' to force client " "disconnect\n"); diff --git a/block/export/vduse-blk.c b/block/export/vduse-blk.c index a25556fe04..e0455551f9 100644 --- a/block/export/vduse-blk.c +++ b/block/export/vduse-blk.c @@ -44,9 +44,7 @@ static void vduse_blk_inflight_inc(VduseBlkExport *vblk_exp) { if (qatomic_fetch_inc(&vblk_exp->inflight) == 0) { /* Prevent export from being deleted */ - aio_context_acquire(vblk_exp->export.ctx); blk_exp_ref(&vblk_exp->export); - aio_context_release(vblk_exp->export.ctx); } } @@ -57,9 +55,7 @@ static void vduse_blk_inflight_dec(VduseBlkExport *vblk_exp) aio_wait_kick(); /* Now the export can be deleted */ - aio_context_acquire(vblk_exp->export.ctx); blk_exp_unref(&vblk_exp->export); - aio_context_release(vblk_exp->export.ctx); } } -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Thu May 04 20:00:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 20:00:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530118.825523 (Exim 4.92) (envelope-from ) id 1puf7e-0006HF-Dd; Thu, 04 May 2023 20:00:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530118.825523; Thu, 04 May 2023 20:00:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf7e-0006GM-9J; Thu, 04 May 2023 20:00:14 +0000 Received: by outflank-mailman (input) for mailman id 530118; Thu, 04 May 2023 20:00:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf1m-0003xx-S4 for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:54:10 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6e900e4a-eab5-11ed-8611-37d641c3527e; Thu, 04 May 2023 21:54:09 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-288-xmcew5b9Mi60YoS0X3Y-pA-1; Thu, 04 May 2023 15:54:02 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 92EA73813F37; Thu, 4 May 2023 19:54:01 +0000 (UTC) Received: from localhost (unknown [10.39.192.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id EB53F2166B31; Thu, 4 May 2023 19:54:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e900e4a-eab5-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683230048; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UIROaLBR9j1PhaubFnxgRi7zZWyl4fJ5E1s3DXvyvk4=; b=RZA3vtrpky9fDgrT/OCu2Bro0R+jwMqhXEhxJI57kEGG1bb1HRtp8T5OtXqQyW4MwN+Jj/ 5MqnLrs8dBLqB3Vw6dVg1YdYQh0AprySzX/mPCeuT0XkJm3Y79a5vsDJWYumGygtwnGEfW cyoCsuo35ds39gchqgIU6UQoTdtv6Q0= X-MC-Unique: xmcew5b9Mi60YoS0X3Y-pA-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Ronnie Sahlberg , Aarushi Mehta , qemu-block@nongnu.org, Paul Durrant , Anthony Perard , Peter Lieven , Stefan Weil , Xie Yongji , Kevin Wolf , Paolo Bonzini , "Michael S. Tsirkin" , Leonardo Bras , Peter Xu , Hanna Reitz , Stefano Stabellini , Richard Henderson , David Woodhouse , Coiby Xu , Eduardo Habkost , Stefano Garzarella , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Stefan Hajnoczi , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Juan Quintela , "Richard W.M. Jones" , Fam Zheng , Marcel Apfelbaum Subject: [PATCH v5 12/21] xen-block: implement BlockDevOps->drained_begin() Date: Thu, 4 May 2023 15:53:18 -0400 Message-Id: <20230504195327.695107-13-stefanha@redhat.com> In-Reply-To: <20230504195327.695107-1-stefanha@redhat.com> References: <20230504195327.695107-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Detach event channels during drained sections to stop I/O submission from the ring. xen-block is no longer reliant on aio_disable_external() after this patch. This will allow us to remove the aio_disable_external() API once all other code that relies on it is converted. Extend xen_device_set_event_channel_context() to allow ctx=NULL. The event channel still exists but the event loop does not monitor the file descriptor. Event channel processing can resume by calling xen_device_set_event_channel_context() with a non-NULL ctx. Factor out xen_device_set_event_channel_context() calls in hw/block/dataplane/xen-block.c into attach/detach helper functions. Incidentally, these don't require the AioContext lock because aio_set_fd_handler() is thread-safe. It's safer to register BlockDevOps after the dataplane instance has been created. The BlockDevOps .drained_begin/end() callbacks depend on the dataplane instance, so move the blk_set_dev_ops() call after xen_block_dataplane_create(). Signed-off-by: Stefan Hajnoczi --- hw/block/dataplane/xen-block.h | 2 ++ hw/block/dataplane/xen-block.c | 42 +++++++++++++++++++++++++--------- hw/block/xen-block.c | 24 ++++++++++++++++--- hw/xen/xen-bus.c | 7 ++++-- 4 files changed, 59 insertions(+), 16 deletions(-) diff --git a/hw/block/dataplane/xen-block.h b/hw/block/dataplane/xen-block.h index 76dcd51c3d..7b8e9df09f 100644 --- a/hw/block/dataplane/xen-block.h +++ b/hw/block/dataplane/xen-block.h @@ -26,5 +26,7 @@ void xen_block_dataplane_start(XenBlockDataPlane *dataplane, unsigned int protocol, Error **errp); void xen_block_dataplane_stop(XenBlockDataPlane *dataplane); +void xen_block_dataplane_attach(XenBlockDataPlane *dataplane); +void xen_block_dataplane_detach(XenBlockDataPlane *dataplane); #endif /* HW_BLOCK_DATAPLANE_XEN_BLOCK_H */ diff --git a/hw/block/dataplane/xen-block.c b/hw/block/dataplane/xen-block.c index d8bc39d359..2597f38805 100644 --- a/hw/block/dataplane/xen-block.c +++ b/hw/block/dataplane/xen-block.c @@ -664,6 +664,30 @@ void xen_block_dataplane_destroy(XenBlockDataPlane *dataplane) g_free(dataplane); } +void xen_block_dataplane_detach(XenBlockDataPlane *dataplane) +{ + if (!dataplane || !dataplane->event_channel) { + return; + } + + /* Only reason for failure is a NULL channel */ + xen_device_set_event_channel_context(dataplane->xendev, + dataplane->event_channel, + NULL, &error_abort); +} + +void xen_block_dataplane_attach(XenBlockDataPlane *dataplane) +{ + if (!dataplane || !dataplane->event_channel) { + return; + } + + /* Only reason for failure is a NULL channel */ + xen_device_set_event_channel_context(dataplane->xendev, + dataplane->event_channel, + dataplane->ctx, &error_abort); +} + void xen_block_dataplane_stop(XenBlockDataPlane *dataplane) { XenDevice *xendev; @@ -674,13 +698,11 @@ void xen_block_dataplane_stop(XenBlockDataPlane *dataplane) xendev = dataplane->xendev; - aio_context_acquire(dataplane->ctx); - if (dataplane->event_channel) { - /* Only reason for failure is a NULL channel */ - xen_device_set_event_channel_context(xendev, dataplane->event_channel, - qemu_get_aio_context(), - &error_abort); + if (!blk_in_drain(dataplane->blk)) { + xen_block_dataplane_detach(dataplane); } + + aio_context_acquire(dataplane->ctx); /* Xen doesn't have multiple users for nodes, so this can't fail */ blk_set_aio_context(dataplane->blk, qemu_get_aio_context(), &error_abort); aio_context_release(dataplane->ctx); @@ -819,11 +841,9 @@ void xen_block_dataplane_start(XenBlockDataPlane *dataplane, blk_set_aio_context(dataplane->blk, dataplane->ctx, NULL); aio_context_release(old_context); - /* Only reason for failure is a NULL channel */ - aio_context_acquire(dataplane->ctx); - xen_device_set_event_channel_context(xendev, dataplane->event_channel, - dataplane->ctx, &error_abort); - aio_context_release(dataplane->ctx); + if (!blk_in_drain(dataplane->blk)) { + xen_block_dataplane_attach(dataplane); + } return; diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c index f5a744589d..f099914831 100644 --- a/hw/block/xen-block.c +++ b/hw/block/xen-block.c @@ -189,8 +189,26 @@ static void xen_block_resize_cb(void *opaque) xen_device_backend_printf(xendev, "state", "%u", state); } +/* Suspend request handling */ +static void xen_block_drained_begin(void *opaque) +{ + XenBlockDevice *blockdev = opaque; + + xen_block_dataplane_detach(blockdev->dataplane); +} + +/* Resume request handling */ +static void xen_block_drained_end(void *opaque) +{ + XenBlockDevice *blockdev = opaque; + + xen_block_dataplane_attach(blockdev->dataplane); +} + static const BlockDevOps xen_block_dev_ops = { - .resize_cb = xen_block_resize_cb, + .resize_cb = xen_block_resize_cb, + .drained_begin = xen_block_drained_begin, + .drained_end = xen_block_drained_end, }; static void xen_block_realize(XenDevice *xendev, Error **errp) @@ -242,8 +260,6 @@ static void xen_block_realize(XenDevice *xendev, Error **errp) return; } - blk_set_dev_ops(blk, &xen_block_dev_ops, blockdev); - if (conf->discard_granularity == -1) { conf->discard_granularity = conf->physical_block_size; } @@ -277,6 +293,8 @@ static void xen_block_realize(XenDevice *xendev, Error **errp) blockdev->dataplane = xen_block_dataplane_create(xendev, blk, conf->logical_block_size, blockdev->props.iothread); + + blk_set_dev_ops(blk, &xen_block_dev_ops, blockdev); } static void xen_block_frontend_changed(XenDevice *xendev, diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c index c59850b1de..b8f408c9ed 100644 --- a/hw/xen/xen-bus.c +++ b/hw/xen/xen-bus.c @@ -846,8 +846,11 @@ void xen_device_set_event_channel_context(XenDevice *xendev, NULL, NULL, NULL, NULL, NULL); channel->ctx = ctx; - aio_set_fd_handler(channel->ctx, qemu_xen_evtchn_fd(channel->xeh), true, - xen_device_event, NULL, xen_device_poll, NULL, channel); + if (ctx) { + aio_set_fd_handler(channel->ctx, qemu_xen_evtchn_fd(channel->xeh), + true, xen_device_event, NULL, xen_device_poll, NULL, + channel); + } } XenEventChannel *xen_device_bind_event_channel(XenDevice *xendev, -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Thu May 04 20:00:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 20:00:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530119.825536 (Exim 4.92) (envelope-from ) id 1puf7o-00071W-0M; Thu, 04 May 2023 20:00:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530119.825536; Thu, 04 May 2023 20:00:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf7n-00071K-QB; Thu, 04 May 2023 20:00:23 +0000 Received: by outflank-mailman (input) for mailman id 530119; Thu, 04 May 2023 20:00:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puf1p-0003iB-Sq for xen-devel@lists.xenproject.org; Thu, 04 May 2023 19:54:13 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 70e1dc82-eab5-11ed-b226-6b7b168915f2; Thu, 04 May 2023 21:54:13 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-310-3JUPVKmDMRukKNbAGsy8rA-1; Thu, 04 May 2023 15:54:05 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0DD063C0F428; Thu, 4 May 2023 19:54:04 +0000 (UTC) Received: from localhost (unknown [10.39.192.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4EFA440C2064; Thu, 4 May 2023 19:54:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 70e1dc82-eab5-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683230052; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YdqEYBGejD/PzTlXIgNRYCDgy4cvOgGgt6P2aeMbPY4=; b=iyJcOHhilUt2NLAzURmkERRvO0JXlScy+ZPZep5yEoHWgGyqGCYSTF77mBk1P1Us+qHjhs euIsShwn60iDjftuacIjG1RBffK8hxz2GGLK9NL8xilQ1byxzxlBWm+ps750DjxVouwB14 EPVkEEJZ23T2Vl0JU12uqwI/V5qBvsg= X-MC-Unique: 3JUPVKmDMRukKNbAGsy8rA-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Ronnie Sahlberg , Aarushi Mehta , qemu-block@nongnu.org, Paul Durrant , Anthony Perard , Peter Lieven , Stefan Weil , Xie Yongji , Kevin Wolf , Paolo Bonzini , "Michael S. Tsirkin" , Leonardo Bras , Peter Xu , Hanna Reitz , Stefano Stabellini , Richard Henderson , David Woodhouse , Coiby Xu , Eduardo Habkost , Stefano Garzarella , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Stefan Hajnoczi , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Juan Quintela , "Richard W.M. Jones" , Fam Zheng , Marcel Apfelbaum Subject: [PATCH v5 13/21] hw/xen: do not set is_external=true on evtchn fds Date: Thu, 4 May 2023 15:53:19 -0400 Message-Id: <20230504195327.695107-14-stefanha@redhat.com> In-Reply-To: <20230504195327.695107-1-stefanha@redhat.com> References: <20230504195327.695107-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 is_external=true suspends fd handlers between aio_disable_external() and aio_enable_external(). The block layer's drain operation uses this mechanism to prevent new I/O from sneaking in between bdrv_drained_begin() and bdrv_drained_end(). The previous commit converted the xen-block device to use BlockDevOps .drained_begin/end() callbacks. It no longer relies on is_external=true so it is safe to pass is_external=false. This is part of ongoing work to remove the aio_disable_external() API. Signed-off-by: Stefan Hajnoczi --- hw/xen/xen-bus.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c index b8f408c9ed..bf256d4da2 100644 --- a/hw/xen/xen-bus.c +++ b/hw/xen/xen-bus.c @@ -842,14 +842,14 @@ void xen_device_set_event_channel_context(XenDevice *xendev, } if (channel->ctx) - aio_set_fd_handler(channel->ctx, qemu_xen_evtchn_fd(channel->xeh), true, + aio_set_fd_handler(channel->ctx, qemu_xen_evtchn_fd(channel->xeh), false, NULL, NULL, NULL, NULL, NULL); channel->ctx = ctx; if (ctx) { aio_set_fd_handler(channel->ctx, qemu_xen_evtchn_fd(channel->xeh), - true, xen_device_event, NULL, xen_device_poll, NULL, - channel); + false, xen_device_event, NULL, xen_device_poll, + NULL, channel); } } @@ -923,7 +923,7 @@ void xen_device_unbind_event_channel(XenDevice *xendev, QLIST_REMOVE(channel, list); - aio_set_fd_handler(channel->ctx, qemu_xen_evtchn_fd(channel->xeh), true, + aio_set_fd_handler(channel->ctx, qemu_xen_evtchn_fd(channel->xeh), false, NULL, NULL, NULL, NULL, NULL); if (qemu_xen_evtchn_unbind(channel->xeh, channel->local_port) < 0) { -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Thu May 04 21:01:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 21:01:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530140.825545 (Exim 4.92) (envelope-from ) id 1pug4M-0006wH-Db; Thu, 04 May 2023 21:00:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530140.825545; Thu, 04 May 2023 21:00:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pug4M-0006wA-AW; Thu, 04 May 2023 21:00:54 +0000 Received: by outflank-mailman (input) for mailman id 530140; Thu, 04 May 2023 21:00:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pug4K-0006w3-Rt for xen-devel@lists.xenproject.org; Thu, 04 May 2023 21:00:53 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bde25d9b-eabe-11ed-8611-37d641c3527e; Thu, 04 May 2023 23:00:48 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-483-M4XYXSG0PgOjzbjEbNZBbw-1; Thu, 04 May 2023 17:00:43 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7B7253C0DDAA; Thu, 4 May 2023 21:00:42 +0000 (UTC) Received: from redhat.com (unknown [10.39.192.9]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 472A510DF8; Thu, 4 May 2023 21:00:37 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bde25d9b-eabe-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683234046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/tE35rOAAC2vyhAwuF/fixTME5fKR02RCLevjKZzkLM=; b=N8mohIMJWpdXWbC/dh7o9EA4up4B6E+0MyFGx2cKa6sSPYJaBg2W0esjDYWTchXdm8qX7+ CtzTXruZb9t7Co48PcVSp7S/TGxf/G8hkKdvGsiahyltVB5hpWl97+5wcEnK760kekYDkB WYWKsqwfHnmgb5U+XWdBTQpoMRmcY9A= X-MC-Unique: M4XYXSG0PgOjzbjEbNZBbw-1 Date: Thu, 4 May 2023 23:00:35 +0200 From: Kevin Wolf To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Juan Quintela , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Richard Henderson , Fam Zheng , "Michael S. Tsirkin" , Coiby Xu , David Woodhouse , Marcel Apfelbaum , Peter Lieven , Paul Durrant , "Richard W.M. Jones" , qemu-block@nongnu.org, Stefano Garzarella , Anthony Perard , Stefan Weil , Xie Yongji , Paolo Bonzini , Aarushi Mehta , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Eduardo Habkost , Stefano Stabellini , Hanna Reitz , Ronnie Sahlberg Subject: Re: [PATCH v4 16/20] virtio: make it possible to detach host notifier from any thread Message-ID: References: <20230425172716.1033562-1-stefanha@redhat.com> <20230425172716.1033562-17-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230425172716.1033562-17-stefanha@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Am 25.04.2023 um 19:27 hat Stefan Hajnoczi geschrieben: > virtio_queue_aio_detach_host_notifier() does two things: > 1. It removes the fd handler from the event loop. > 2. It processes the virtqueue one last time. > > The first step can be peformed by any thread and without taking the > AioContext lock. > > The second step may need the AioContext lock (depending on the device > implementation) and runs in the thread where request processing takes > place. virtio-blk and virtio-scsi therefore call > virtio_queue_aio_detach_host_notifier() from a BH that is scheduled in > AioContext > > Scheduling a BH is undesirable for .drained_begin() functions. The next > patch will introduce a .drained_begin() function that needs to call > virtio_queue_aio_detach_host_notifier(). Why is it undesirable? In my mental model, .drained_begin() is still free to start as many asynchronous things as it likes. The only important thing to take care of is that .drained_poll() returns true as long as the BH (or other asynchronous operation) is still pending. Of course, your way of doing things still seems to result in simpler code because you don't have to deal with a BH at all if you only really want the first part and not the second. > Move the virtqueue processing out to the callers of > virtio_queue_aio_detach_host_notifier() so that the function can be > called from any thread. This is in preparation for the next patch. Did you forget to remove it in virtio_queue_aio_detach_host_notifier()? If it's unchanged, I don't think the AioContext requirement is lifted. > Signed-off-by: Stefan Hajnoczi > --- > hw/block/dataplane/virtio-blk.c | 2 ++ > hw/scsi/virtio-scsi-dataplane.c | 9 +++++++++ > 2 files changed, 11 insertions(+) > diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c > index b28d81737e..bd7cc6e76b 100644 > --- a/hw/block/dataplane/virtio-blk.c > +++ b/hw/block/dataplane/virtio-blk.c > @@ -286,8 +286,10 @@ static void virtio_blk_data_plane_stop_bh(void *opaque) > > for (i = 0; i < s->conf->num_queues; i++) { > VirtQueue *vq = virtio_get_queue(s->vdev, i); > + EventNotifier *host_notifier = virtio_queue_get_host_notifier(vq); > > virtio_queue_aio_detach_host_notifier(vq, s->ctx); > + virtio_queue_host_notifier_read(host_notifier); > } > } The existing code in virtio_queue_aio_detach_host_notifier() has a comment before the read: /* Test and clear notifier before after disabling event, * in case poll callback didn't have time to run. */ Do we want to keep it around in the new places? (And also fix the "before after", I suppose, or replace it with a similar, but better comment that explains why we're reading here.) Kevin From xen-devel-bounces@lists.xenproject.org Thu May 04 21:09:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 21:09:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530143.825555 (Exim 4.92) (envelope-from ) id 1pugCK-0007aZ-7i; Thu, 04 May 2023 21:09:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530143.825555; Thu, 04 May 2023 21:09:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pugCK-0007aS-4y; Thu, 04 May 2023 21:09:08 +0000 Received: by outflank-mailman (input) for mailman id 530143; Thu, 04 May 2023 21:09:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pugCI-0007aI-L8; Thu, 04 May 2023 21:09:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pugCI-0001sl-Dw; Thu, 04 May 2023 21:09:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pugCH-0002lU-Uf; Thu, 04 May 2023 21:09:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pugCH-0004J9-UE; Thu, 04 May 2023 21:09:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TVQRSwTIB8gYeI19Xh2M1eV0SW3m1yRle7jL7c478I0=; b=s/+aG+o6iyrfuHb6zgkpfEAMO7 6jvLbvugp0LZw4Mq1q7gWqTwAOc1a6E8ArxKTKCTGXdGHo2YOoBLtQCP2BgSKZqYu2aAxGGJ6mqVQ IVI+iha+qm1IP85HJ0EdyqsE/kCzM6SqstIWyx4Zh8dxXFS3l/uW3VE7qicQBt/iMkug=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180535: all pass - PUSHED X-Osstest-Versions-This: ovmf=d992a05ade3d1bebc6e7a81aaf700286e0e217c8 X-Osstest-Versions-That: ovmf=4b02045f86d6aac8a617bf3f65f9cb2146630ce3 From: osstest service owner Date: Thu, 04 May 2023 21:09:05 +0000 flight 180535 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180535/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf d992a05ade3d1bebc6e7a81aaf700286e0e217c8 baseline version: ovmf 4b02045f86d6aac8a617bf3f65f9cb2146630ce3 Last test of basis 180532 2023-05-04 14:40:45 Z 0 days Testing same since 180535 2023-05-04 19:12:15 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Chasel Chiu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 4b02045f86..d992a05ade d992a05ade3d1bebc6e7a81aaf700286e0e217c8 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu May 04 21:13:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 21:13:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530148.825566 (Exim 4.92) (envelope-from ) id 1pugGy-0000Zo-Qm; Thu, 04 May 2023 21:13:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530148.825566; Thu, 04 May 2023 21:13:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pugGy-0000Zh-No; Thu, 04 May 2023 21:13:56 +0000 Received: by outflank-mailman (input) for mailman id 530148; Thu, 04 May 2023 21:13:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pugGy-0000Zb-4U for xen-devel@lists.xenproject.org; Thu, 04 May 2023 21:13:56 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 926bdd0f-eac0-11ed-8611-37d641c3527e; Thu, 04 May 2023 23:13:53 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-199-0jJU1yuvPWyStda8F5r-dw-1; Thu, 04 May 2023 17:13:48 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 81E11857F81; Thu, 4 May 2023 21:13:47 +0000 (UTC) Received: from redhat.com (unknown [10.39.192.9]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A4B891410F24; Thu, 4 May 2023 21:13:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 926bdd0f-eac0-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683234832; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PbtQd0T/eOvB2WwyzniyotLqfkl9lge5PBzlNU6yYaw=; b=UvzW2MQyUUInuBe+/PfgDFvELzIMm4LnxpFmgSHxl4cECgNgGrYnKvJTX41mwWSOwnW3nk yIYpo3wW5e2qWDHDcjHU1vqhuAIpgQx2GcWrp3V9VyOdr2PtfVfTuAkayUbZmJ/q8cxJcW 45qXT3LDRIuJhNVhnABR3z+dVpXfbNQ= X-MC-Unique: 0jJU1yuvPWyStda8F5r-dw-1 Date: Thu, 4 May 2023 23:13:42 +0200 From: Kevin Wolf To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Juan Quintela , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Richard Henderson , Fam Zheng , "Michael S. Tsirkin" , Coiby Xu , David Woodhouse , Marcel Apfelbaum , Peter Lieven , Paul Durrant , "Richard W.M. Jones" , qemu-block@nongnu.org, Stefano Garzarella , Anthony Perard , Stefan Weil , Xie Yongji , Paolo Bonzini , Aarushi Mehta , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Eduardo Habkost , Stefano Stabellini , Hanna Reitz , Ronnie Sahlberg Subject: Re: [PATCH v4 17/20] virtio-blk: implement BlockDevOps->drained_begin() Message-ID: References: <20230425172716.1033562-1-stefanha@redhat.com> <20230425172716.1033562-18-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230425172716.1033562-18-stefanha@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 Am 25.04.2023 um 19:27 hat Stefan Hajnoczi geschrieben: > Detach ioeventfds during drained sections to stop I/O submission from > the guest. virtio-blk is no longer reliant on aio_disable_external() > after this patch. This will allow us to remove the > aio_disable_external() API once all other code that relies on it is > converted. > > Take extra care to avoid attaching/detaching ioeventfds if the data > plane is started/stopped during a drained section. This should be rare, > but maybe the mirror block job can trigger it. > > Signed-off-by: Stefan Hajnoczi > --- > hw/block/dataplane/virtio-blk.c | 17 +++++++++------ > hw/block/virtio-blk.c | 38 ++++++++++++++++++++++++++++++++- > 2 files changed, 48 insertions(+), 7 deletions(-) > > diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c > index bd7cc6e76b..d77fc6028c 100644 > --- a/hw/block/dataplane/virtio-blk.c > +++ b/hw/block/dataplane/virtio-blk.c > @@ -245,13 +245,15 @@ int virtio_blk_data_plane_start(VirtIODevice *vdev) > } > > /* Get this show started by hooking up our callbacks */ > - aio_context_acquire(s->ctx); > - for (i = 0; i < nvqs; i++) { > - VirtQueue *vq = virtio_get_queue(s->vdev, i); > + if (!blk_in_drain(s->conf->conf.blk)) { > + aio_context_acquire(s->ctx); > + for (i = 0; i < nvqs; i++) { > + VirtQueue *vq = virtio_get_queue(s->vdev, i); > > - virtio_queue_aio_attach_host_notifier(vq, s->ctx); > + virtio_queue_aio_attach_host_notifier(vq, s->ctx); > + } > + aio_context_release(s->ctx); > } > - aio_context_release(s->ctx); > return 0; > > fail_aio_context: > @@ -317,7 +319,10 @@ void virtio_blk_data_plane_stop(VirtIODevice *vdev) > trace_virtio_blk_data_plane_stop(s); > > aio_context_acquire(s->ctx); > - aio_wait_bh_oneshot(s->ctx, virtio_blk_data_plane_stop_bh, s); > + > + if (!blk_in_drain(s->conf->conf.blk)) { > + aio_wait_bh_oneshot(s->ctx, virtio_blk_data_plane_stop_bh, s); > + } So here we actually get a semantic change: What you described as the second part in the previous patch, processing the virtqueue one last time, isn't done any more if the device is drained. If it's okay to just skip this during drain, why do we need to do it outside of drain? Kevin From xen-devel-bounces@lists.xenproject.org Thu May 04 21:25:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 21:25:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530151.825576 (Exim 4.92) (envelope-from ) id 1pugSD-00027H-Ri; Thu, 04 May 2023 21:25:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530151.825576; Thu, 04 May 2023 21:25:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pugSD-00027A-P7; Thu, 04 May 2023 21:25:33 +0000 Received: by outflank-mailman (input) for mailman id 530151; Thu, 04 May 2023 21:25:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pugSC-000274-CE for xen-devel@lists.xenproject.org; Thu, 04 May 2023 21:25:32 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 32193822-eac2-11ed-b226-6b7b168915f2; Thu, 04 May 2023 23:25:31 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-365-0JHXhtIDOzGjIqozYKIm0A-1; Thu, 04 May 2023 17:25:23 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BB301185A78B; Thu, 4 May 2023 21:25:22 +0000 (UTC) Received: from redhat.com (unknown [10.39.192.9]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1EA6640C2064; Thu, 4 May 2023 21:25:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 32193822-eac2-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683235530; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EXBTvckOEwAXoXWbpnPFajVuZsPXxwBJqTqoZHV9JvQ=; b=V2u7aBfrIH5B/lud3IMRO5flv/4nzzzBj6wm+PNJR0HVqdcYOyOxZnUltN/AFkx8SiZCeG VDAwJHC8aYJ6rnAkEOm1N56ay9LYPtIh3jkUuKhTm5DoA9zl6tB3teyVVKfPJCM0iIMPr3 JR5HPy+kg2Lws21G5Mpgg/UNQYzYRp4= X-MC-Unique: 0JHXhtIDOzGjIqozYKIm0A-1 Date: Thu, 4 May 2023 23:25:17 +0200 From: Kevin Wolf To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Juan Quintela , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Richard Henderson , Fam Zheng , "Michael S. Tsirkin" , Coiby Xu , David Woodhouse , Marcel Apfelbaum , Peter Lieven , Paul Durrant , "Richard W.M. Jones" , qemu-block@nongnu.org, Stefano Garzarella , Anthony Perard , Stefan Weil , Xie Yongji , Paolo Bonzini , Aarushi Mehta , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Eduardo Habkost , Stefano Stabellini , Hanna Reitz , Ronnie Sahlberg Subject: Re: [PATCH v4 18/20] virtio-scsi: implement BlockDevOps->drained_begin() Message-ID: References: <20230425172716.1033562-1-stefanha@redhat.com> <20230425172716.1033562-19-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230425172716.1033562-19-stefanha@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Am 25.04.2023 um 19:27 hat Stefan Hajnoczi geschrieben: > The virtio-scsi Host Bus Adapter provides access to devices on a SCSI > bus. Those SCSI devices typically have a BlockBackend. When the > BlockBackend enters a drained section, the SCSI device must temporarily > stop submitting new I/O requests. > > Implement this behavior by temporarily stopping virtio-scsi virtqueue > processing when one of the SCSI devices enters a drained section. The > new scsi_device_drained_begin() API allows scsi-disk to message the > virtio-scsi HBA. > > scsi_device_drained_begin() uses a drain counter so that multiple SCSI > devices can have overlapping drained sections. The HBA only sees one > pair of .drained_begin/end() calls. > > After this commit, virtio-scsi no longer depends on hw/virtio's > ioeventfd aio_set_event_notifier(is_external=true). This commit is a > step towards removing the aio_disable_external() API. > > Signed-off-by: Stefan Hajnoczi > @@ -206,9 +208,11 @@ void virtio_scsi_dataplane_stop(VirtIODevice *vdev) > } > s->dataplane_stopping = true; > > - aio_context_acquire(s->ctx); > - aio_wait_bh_oneshot(s->ctx, virtio_scsi_dataplane_stop_bh, s); > - aio_context_release(s->ctx); > + if (s->bus.drain_count == 0) { > + aio_context_acquire(s->ctx); > + aio_wait_bh_oneshot(s->ctx, virtio_scsi_dataplane_stop_bh, s); > + aio_context_release(s->ctx); > + } Same question as for virtio-blk: We lose processing the virtqueue one last time during drain. Is it okay, and if so, why do we need it outside of drain? Kevin From xen-devel-bounces@lists.xenproject.org Thu May 04 21:34:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 21:34:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530155.825586 (Exim 4.92) (envelope-from ) id 1pugat-0003aS-Lw; Thu, 04 May 2023 21:34:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530155.825586; Thu, 04 May 2023 21:34:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pugat-0003aL-JD; Thu, 04 May 2023 21:34:31 +0000 Received: by outflank-mailman (input) for mailman id 530155; Thu, 04 May 2023 21:34:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pugar-0003aF-Le for xen-devel@lists.xenproject.org; Thu, 04 May 2023 21:34:29 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 71c1c72b-eac3-11ed-8611-37d641c3527e; Thu, 04 May 2023 23:34:27 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-301-oftBbWKyPpm5UhTcIWwpiQ-1; Thu, 04 May 2023 17:34:23 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 20351185A7A2; Thu, 4 May 2023 21:34:22 +0000 (UTC) Received: from redhat.com (unknown [10.39.192.9]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5F7E82166B30; Thu, 4 May 2023 21:34:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 71c1c72b-eac3-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683236066; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Gi2dujXyOOsp2C2GzNI9fp0qtTuAHfyKycpA+LfupIY=; b=f+D9eg0FBnB1NY3jV8V1yvq9MIp96rcHolYq2LK3paPVShitP/PJbMWk7d/aryHjHdDbk/ ZWjNHOW00lPpaMmoiQJWS44Ak8nyghDEe0FwUB4udGtF2iZjQv5Mn4YX6I6Lng0p0DF4pQ EozO1CzqHwF0pcqw4bRXQy2yEc1CLQI= X-MC-Unique: oftBbWKyPpm5UhTcIWwpiQ-1 Date: Thu, 4 May 2023 23:34:17 +0200 From: Kevin Wolf To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Juan Quintela , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Richard Henderson , Fam Zheng , "Michael S. Tsirkin" , Coiby Xu , David Woodhouse , Marcel Apfelbaum , Peter Lieven , Paul Durrant , "Richard W.M. Jones" , qemu-block@nongnu.org, Stefano Garzarella , Anthony Perard , Stefan Weil , Xie Yongji , Paolo Bonzini , Aarushi Mehta , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Eduardo Habkost , Stefano Stabellini , Hanna Reitz , Ronnie Sahlberg Subject: Re: [PATCH v4 20/20] aio: remove aio_disable_external() API Message-ID: References: <20230425172716.1033562-1-stefanha@redhat.com> <20230425172716.1033562-21-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230425172716.1033562-21-stefanha@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Am 25.04.2023 um 19:27 hat Stefan Hajnoczi geschrieben: > All callers now pass is_external=false to aio_set_fd_handler() and > aio_set_event_notifier(). The aio_disable_external() API that > temporarily disables fd handlers that were registered is_external=true > is therefore dead code. > > Remove aio_disable_external(), aio_enable_external(), and the > is_external arguments to aio_set_fd_handler() and > aio_set_event_notifier(). > > The entire test-fdmon-epoll test is removed because its sole purpose was > testing aio_disable_external(). > > Parts of this patch were generated using the following coccinelle > (https://coccinelle.lip6.fr/) semantic patch: > > @@ > expression ctx, fd, is_external, io_read, io_write, io_poll, io_poll_ready, opaque; > @@ > - aio_set_fd_handler(ctx, fd, is_external, io_read, io_write, io_poll, io_poll_ready, opaque) > + aio_set_fd_handler(ctx, fd, io_read, io_write, io_poll, io_poll_ready, opaque) > > @@ > expression ctx, notifier, is_external, io_read, io_poll, io_poll_ready; > @@ > - aio_set_event_notifier(ctx, notifier, is_external, io_read, io_poll, io_poll_ready) > + aio_set_event_notifier(ctx, notifier, io_read, io_poll, io_poll_ready) > > Reviewed-by: Juan Quintela > Reviewed-by: Philippe Mathieu-Daud > Signed-off-by: Stefan Hajnoczi > diff --git a/util/fdmon-epoll.c b/util/fdmon-epoll.c > index 1683aa1105..6b6a1a91f8 100644 > --- a/util/fdmon-epoll.c > +++ b/util/fdmon-epoll.c > @@ -133,13 +128,12 @@ bool fdmon_epoll_try_upgrade(AioContext *ctx, unsigned npfd) > return false; > } > > - /* Do not upgrade while external clients are disabled */ > - if (qatomic_read(&ctx->external_disable_cnt)) { > - return false; > - } > - > - if (npfd < EPOLL_ENABLE_THRESHOLD) { > - return false; > + if (npfd >= EPOLL_ENABLE_THRESHOLD) { > + if (fdmon_epoll_try_enable(ctx)) { > + return true; > + } else { > + fdmon_epoll_disable(ctx); > + } > } > > /* The list must not change while we add fds to epoll */ I don't understand this hunk. Why are you changing more than just deleting the external_disable_cnt check? Is this a mismerge with your own commit e62da985? Kevin From xen-devel-bounces@lists.xenproject.org Thu May 04 21:45:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 21:45:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530185.825613 (Exim 4.92) (envelope-from ) id 1pugl5-00069V-4z; Thu, 04 May 2023 21:45:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530185.825613; Thu, 04 May 2023 21:45:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pugl5-00069O-1V; Thu, 04 May 2023 21:45:03 +0000 Received: by outflank-mailman (input) for mailman id 530185; Thu, 04 May 2023 21:45:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pugl4-00069I-2s for xen-devel@lists.xenproject.org; Thu, 04 May 2023 21:45:02 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eab4ca4d-eac4-11ed-8611-37d641c3527e; Thu, 04 May 2023 23:45:00 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-645-HnOtJYstOJWrNZLz1UfM9w-1; Thu, 04 May 2023 17:44:54 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 994CD85531A; Thu, 4 May 2023 21:44:53 +0000 (UTC) Received: from redhat.com (unknown [10.39.192.9]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6800363F3E; Thu, 4 May 2023 21:44:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eab4ca4d-eac4-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683236698; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4uQyhS4chih7E8Y8+j3wgbWTkP0aNND6XQO9VSCZB+8=; b=QqzhyulZJcSxtO71aQremSieAmDQzt4gL7EOMpT5iWsE0lOr57a7WtYA48cWkyVl6+ole/ wcxoRjau6hBoubpbUEuPksBmzeyFe82LaFjoVMzpC+SSGc/PH5ceIIg2FXiCgBskq9Ki3p +JsJXhTSz3yEFRUftZpEuW6/StVUZsY= X-MC-Unique: HnOtJYstOJWrNZLz1UfM9w-1 Date: Thu, 4 May 2023 23:44:42 +0200 From: Kevin Wolf To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Ronnie Sahlberg , Aarushi Mehta , qemu-block@nongnu.org, Paul Durrant , Anthony Perard , Peter Lieven , Stefan Weil , Xie Yongji , Paolo Bonzini , "Michael S. Tsirkin" , Leonardo Bras , Peter Xu , Hanna Reitz , Stefano Stabellini , Richard Henderson , David Woodhouse , Coiby Xu , Eduardo Habkost , Stefano Garzarella , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Juan Quintela , "Richard W.M. Jones" , Fam Zheng , Marcel Apfelbaum Subject: Re: [PATCH v5 00/21] block: remove aio_disable_external() API Message-ID: References: <20230504195327.695107-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230504195327.695107-1-stefanha@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Am 04.05.2023 um 21:53 hat Stefan Hajnoczi geschrieben: > v5: > - Use atomic accesses for in_flight counter in vhost-user-server.c [Kevin] > - Stash SCSIDevice id/lun values for VIRTIO_SCSI_T_TRANSPORT_RESET event > before unrealizing the SCSIDevice [Kevin] > - Keep vhost-user-blk export .detach() callback so ctx is set to NULL [Kevin] > - Narrow BdrvChildClass and BlockDriver drained_{begin/end/poll} callbacks from > IO_OR_GS_CODE() to GLOBAL_STATE_CODE() [Kevin] > - Include Kevin's "block: Fix use after free in blockdev_mark_auto_del()" to > fix a latent bug that was exposed by this series I only just finished reviewing v4 when you had already sent v5, but it hadn't arrived yet. I had a few more comments on what are now patches 17, 18, 19 and 21 in v5. I think they all still apply. Kevin From xen-devel-bounces@lists.xenproject.org Thu May 04 21:55:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 21:55:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530190.825623 (Exim 4.92) (envelope-from ) id 1pugui-0007dd-2p; Thu, 04 May 2023 21:55:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530190.825623; Thu, 04 May 2023 21:55:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puguh-0007dW-W8; Thu, 04 May 2023 21:54:59 +0000 Received: by outflank-mailman (input) for mailman id 530190; Thu, 04 May 2023 21:54:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pugug-0007dQ-3M for xen-devel@lists.xenproject.org; Thu, 04 May 2023 21:54:58 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on20612.outbound.protection.outlook.com [2a01:111:f400:7e8a::612]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4dd9c6aa-eac6-11ed-b226-6b7b168915f2; Thu, 04 May 2023 23:54:55 +0200 (CEST) Received: from BN9PR03CA0441.namprd03.prod.outlook.com (2603:10b6:408:113::26) by DM4PR12MB5793.namprd12.prod.outlook.com (2603:10b6:8:60::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Thu, 4 May 2023 21:54:52 +0000 Received: from BN8NAM11FT055.eop-nam11.prod.protection.outlook.com (2603:10b6:408:113:cafe::aa) by BN9PR03CA0441.outlook.office365.com (2603:10b6:408:113::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26 via Frontend Transport; Thu, 4 May 2023 21:54:52 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT055.mail.protection.outlook.com (10.13.177.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.27 via Frontend Transport; Thu, 4 May 2023 21:54:52 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 4 May 2023 16:54:51 -0500 Received: from [192.168.137.15] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 4 May 2023 16:54:50 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4dd9c6aa-eac6-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UI0rQ8W6fS9kZrnPWwZj57AG5PZnZD7JKDGWqEfTKxg2aI1i7ti+hVHccCnfqNxE9/KSDrwfcUr1oH8JXHUWRetuCxEssnvvVW1YQp6wG928ukXImat1WwxUma7qque+AI4v/qcOo0ZmZ06rH1+9KxZbgC6j4vDhL5memZLXfvWMQGIHHn01PsOsXmoGNz3e0GU3e6lIw1IhGvDFRPlC9e46TN54fESZUnzRMNLThudBpgbNfyjWZKVa9adPgNXdmR3phrxWU2yViIOcjlb5mZC6PQPBowbgFlwCMqYRIHQFbLbJlYCEzyXAzzLCOZs/9Pvheim9Xb/AitECu9FEZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1xP4MQBh+A/JD/hKH7vXg1eF4/RVQQqOEgguvhZSqKE=; b=KSoCxzjhRRhYSLlJjLaimG7iTv+MLEzbhqTh4o6wu6u+gDLw3WSkccBK2Q2vUABsc1W9vy+QKIQ2O5PhH2Q2JJMuaLXZf7cqQtsS8LT5JhA9lV3Nu9zfWCWL9mWMYBuNQ5Dw6eQvYVZExQGKholy4oJFuuom+7qUWPCFzi+KCmJYnRRnYXuFdjMkXqUE2zZ3lVfhVKORyNbjcIKKQf08uqB6tq8URJMhkAeeuofOmlyUaPhry51VpZv4NwTV4HONcbi7V5Z2ci7SgW56Wm4EvFHwSNYLXt1a315UGAYdZAQptcL0UlywhUKZ0DSW7emjWit5jBYcJKzQrVr6NsaErQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1xP4MQBh+A/JD/hKH7vXg1eF4/RVQQqOEgguvhZSqKE=; b=T2xg7h7s9Z8zssu5RDtw6pCYxUhsJq5hCa0RGbb3VHnEWmgEon+QfsgC3smuFWozsm0Y1XyhiLpWv85rUpyKcfbTlB04ncF85hQ7fkR1uz72WswSHEsx/kE+zElBKcMeuDFbmOb2labaR9icFJprxCC3IgliXLo1zSxggbFovnw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <6758ef37-bf66-99c3-1fd4-f2edfc12513a@amd.com> Date: Thu, 4 May 2023 17:54:45 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v1 3/6] iommu/arm: Introduce iommu_add_dt_pci_device API To: Jan Beulich CC: Oleksandr Tyshchenko , Stefano Stabellini , Julien Grall , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , References: <20230501200305.168058-1-stewart.hildebrand@amd.com> <20230501200305.168058-4-stewart.hildebrand@amd.com> <0e7404fe-e249-7b3f-0628-b8b8b1925765@suse.com> Content-Language: en-US From: Stewart Hildebrand In-Reply-To: <0e7404fe-e249-7b3f-0628-b8b8b1925765@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT055:EE_|DM4PR12MB5793:EE_ X-MS-Office365-Filtering-Correlation-Id: cb11320b-1065-42ef-ed84-08db4cea308d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9JKO9b0GWg3yaN6BepGwU2af10lkd/Ise3Rwvw5IQ4eLfTfYtQxf1T3mzqTuAs7aKC4mCHREg549Ox+5CTmT3szg4t9J6ULSUQElBKBq8cev+DquwTlfvgQQy8o2hBm3PXzO8qcYjPrYlVz/6imNeLb+wmykjEG9uMIm8sfSFJt2bhfajB5wtivBxDv7gE92jCeAU+wsn3vCnOKxB5yGZpGDllXK/uoMmooNDXR6asccGfnCIPfJJxS6HuTDtk4hzcMct4kOxgWK+KAoLEjxII0SxM3968LLUeOO45cjVmjCnfwpgnmcfr48MTjsZVLW28w6RFheCW3R8U0R4L1+1yoLqOZj2sS6kcNlosQg9ngAPj9mCnY/Qk3mGY5U68Y67bpDKepNpJwib1baDza1jmCyGddBu16uVEwb54ixHG0EVc5UM9tt4ruYOYFfbKhx7rpJbZffyICFzGAImxVT8QAh9BtNizY/SZk2ofje3B4X2EQkSvnGQbUqG5tUfRnlAB2PcF7E6Xa5OD4HaCFbtcvuOGKo6O4MgiEl6wxba/ezsJqbVrJGyZyZIsmBytO5TeRG5xqHCEUoow5Q39pNe/tjH9TnJMzS8ASYCsy0YyFOnX2Vx+V7Ya3xF8EqzxRJdW+JPZfMiWr8/LK3HkE2pKKcc9c0n0XopKgQGDBqsOkqA3Pn0mRhLkv6X+ZmMvSNHriQb1pNOuAn3PKFVMFbGJgzxljcUQdItqh98uapiF7nkZ62+fj+30dG65EbkYLw X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(396003)(39860400002)(346002)(451199021)(46966006)(36840700001)(40470700004)(40480700001)(26005)(53546011)(44832011)(40460700003)(186003)(16576012)(82310400005)(478600001)(41300700001)(54906003)(966005)(6666004)(36756003)(81166007)(356005)(5660300002)(8936002)(8676002)(2616005)(70206006)(36860700001)(316002)(4326008)(6916009)(70586007)(2906002)(336012)(31686004)(83380400001)(86362001)(426003)(31696002)(47076005)(82740400003)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 21:54:52.3254 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cb11320b-1065-42ef-ed84-08db4cea308d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT055.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5793 On 5/2/23 03:44, Jan Beulich wrote: > On 01.05.2023 22:03, Stewart Hildebrand wrote: >> @@ -228,6 +229,9 @@ int iommu_release_dt_devices(struct domain *d); >> * (IOMMU is not enabled/present or device is not connected to it). >> */ >> int iommu_add_dt_device(struct dt_device_node *np); >> +#ifdef CONFIG_HAS_PCI >> +int iommu_add_dt_pci_device(uint8_t devfn, struct pci_dev *pdev); >> +#endif > > Why the first parameter? Doesn't the 2nd one describe the device in full? It's related to phantom device/function handling, although this series unfortunately does not properly handle phantom devices. > If this is about phantom devices, then I'd expect the function to take > care of those (like iommu_add_device() does), rather than its caller. In the next patch ("[PATCH v1 4/6] pci/arm: Use iommu_add_dt_pci_device() instead of arch hook"), we will invoke iommu_add_dt_pci_device(devfn, pdev) from iommu_add_device(). Since iommu_add_device() iterates over the phantom functions, it would be redundant to also have such a loop inside of iommu_add_dt_pci_device(). If we are to properly handle phantom devices on ARM, the SMMU drivers (smmu.c/smmu-v3.c) would need some more work. In patches 5/6 and 6/6 in this series, we have: if ( devfn != pdev->devfn ) return -EOPNOTSUPP; Also, the ARM SMMU drivers in Xen currently only support a single AXI stream ID per device, so some development would need to occur in order to support phantom devices. Should phantom device support be part of this series, or would it be acceptable to introduce phantom device support on ARM as part of a future series? Lastly, I'd like to check my understanding since phantom devices are new to me. Here's my understanding: A phantom device is a device that advertises itself as single function, but actually has multiple phantom functions. These phantom functions will have unique requestor IDs (RID). The RID is essentially the BDF. To use a phantom device with Xen, we specify the pci-phantom command line option, and we identify phantom devices/functions in code by devfn != pdev->devfn. On ARM, we need to map/translate a BDF to an AXI stream ID in order for the SMMU to identify the device and apply translation. That BDF -> stream ID mapping is defined by the iommu-map/iommu-map-mask property in the device tree [1]. The BDF -> AXI stream ID mapping in DT could allow phantom devices (i.e. devices with phantom functions) to use different stream IDs based on the (phantom) function. So, in theory, on ARM, there is a possibility we may have a device that advertises itself as single function, but will issue AXI transactions with multiple different AXI stream IDs due to phantom functions. In this case, we will want each AXI stream ID to be programmed into the SMMU to avoid SMMU faults. Please correct me if I've misunderstood anything. [1] https://www.kernel.org/doc/Documentation/devicetree/bindings/pci/pci-iommu.txt From xen-devel-bounces@lists.xenproject.org Thu May 04 23:04:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 May 2023 23:04:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530194.825633 (Exim 4.92) (envelope-from ) id 1pui0A-0006P6-6M; Thu, 04 May 2023 23:04:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530194.825633; Thu, 04 May 2023 23:04:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pui0A-0006Oz-3a; Thu, 04 May 2023 23:04:42 +0000 Received: by outflank-mailman (input) for mailman id 530194; Thu, 04 May 2023 23:04:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pui08-0006Os-4U for xen-devel@lists.xenproject.org; Thu, 04 May 2023 23:04:40 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 099ffa0b-ead0-11ed-b226-6b7b168915f2; Fri, 05 May 2023 01:04:37 +0200 (CEST) Received: from mail-dm6nam12lp2168.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 May 2023 19:04:25 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DS7PR03MB5510.namprd03.prod.outlook.com (2603:10b6:5:2ce::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Thu, 4 May 2023 23:04:23 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb%4]) with mapi id 15.20.6340.031; Thu, 4 May 2023 23:04:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 099ffa0b-ead0-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683241477; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=btf+YDR09e31a7nJQt4TFhTa4ii9ccR3xjDeZADBtFU=; b=aMpbuEDa1DjgYxgbaMk6bn4kFhwps9xXWcp2d4jX9+H0XOsEnm5XxS2V Fe/jpcb9J1NuWxrVB7y4C2xbZFnJXAxFX/23Q89vh86lpRRg7chU1MpSr AAeeWit1LFS8UAkc3BcOYPnm8K832HgUHhtritnK0BP0lvSEgLncrv5Tz E=; X-IronPort-RemoteIP: 104.47.59.168 X-IronPort-MID: 110371711 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:b9ewj6rVwH7LF0/yLarrNn4OKf9eBmLUYxIvgKrLsJaIsI4StFCzt garIBmDOvnfYmLyLdx3aYi/oUhTvJOGmN43TgI//CE0Enka8puZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WJwUmAWP6gR5weDzyVNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXADkJUkClrOWR+bXlVPtVrNYiLujVP6pK7xmMzRmBZRonabbqZvyQoPN9gnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jemraYSFEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXhr6Yx3wTMnzV75Bs+Wkrrq9Xhpn+FSvliM WgE83oNt4QjzRn+JjX6d1jiyJKehTYAVN5AO+k77hyR0K3S4hbfCmVsZjpAbsE28cYsQHkp2 0WPktfBAT10rKbTSHST7L6YoDq+fy8PIgcqbiYYRA8E5Z/mqZsyiBvUZt95Fei+ididMS7xx zSiryUkgbgXy8kR2M2T8k3AmT+qjpvEVAg44kPQRG3Nxgd4YpO1Ioez6knz8/lNNsCaQ0OHs XxCnNKRhMgSFpuKmyGLTM0EGKmp7rCLKjTaglNpWZUsnxyk4XivVYlK5j10YktkWu4AeDn0c ArWuBtKzIFcMWHsbqJtZY+1TcMwwsDIGdnhUv3ORtVLct59eWev+CBoeF7Vx2n3kVMnub8wN I3dcsu2C3seT6N9w1KeX+4A1fk0zyQ73mfeVLjgzhqmz7fYb3mQIZ8dOV+LY/oR4KqOqgjR7 5BUMM7i4xFeVvDuJzPW6oUNBVQLNmQgQ5HwpdZeeuOKLkxhAm5JI/rY27BnYZF5m61Tms/B5 HT7UUhdoHLdjHjKMkOgbWx/b7brUIdXrXs9JiEqJV+yx34ue52v7b9ZfJwyFZEj9ep+3dZ9V fwBesOdErJIUDuB5jd1RYnwqslueQqmgSqKPjG5e34vcph4XQvL99T4OAz1+0EmBC2ttNB4p Ka8zATFWpkSbwN4Bc3SZbSkyFbZlXwcnv9iGkjFON9efG3y/4VwbS/8lPk6J4cLMxqr7ivKi S6VDA0eqO2LpJU6mPHFmqWb9a+oFeVkF0ZXFmWd6qy5XQHQ5GWu25RceOmNdDHZEmjz/c2Kb P9XxvfUNPwBgUYMsoxgHrItxqU7j/P3rbhc3AViHV3RYlirA68mKX6DteFXv7BJw7RakQi7Q ESC/p9dI7rhEN/lF1sYP0whY+KP3PoXixHb6PhzK0L/jAds8bOBU056MB6LhyhQarByNesNx uMsu9Uf7QClohwjLt+CgyZX8CKKJ3kNO40/s5wcEoLvog8szl5PZ9rZEiCw7JznQ9pUM0IhJ TuVrKvNjrBdzwzJdH9bPXzQ1uhUg9IKpRtIxVkFOXyGn9PEgrk82xg52SksRwFciBxd0uxbM Hl3OkF8I66DuTxvgaBrXW+2HBpaLAaE4UG3wFwM/EXCRkOyX3TEKkU0PO+f+0Zf+GVZFhBe/ bKVzGLoQB7vfcrr2TA1V1IjoPvmJeGd7SXHkcGjWsiAQZ8zZGO/hrf0PDRY7Rz6Hck2mUvL4 /Fw+/p9YrH6MihWpLAnD46d1vIbTxXsyHF+fMyNNZghRQn0EAxeExDXQ6xtUquh/8D3zHI= IronPort-HdrOrdr: A9a23:q7JOg6pxGXXkorUcmwt6pjYaV5oAeYIsimQD101hICG9E/bo8v xG+c5wuCMc5wx8ZJhNo7+90dC7MArhHP1OkOss1NWZPDUO0VHARL2Ki7GN/9SKIVycygcy78 Zdmp9FebnN5AhB5voSODPIaOrIGuP3lpxAWN2uqEuFkTsaE52IMT0JcDqmLg== X-Talos-CUID: 9a23:vjt1N2Mplw2XN+5DUS1bpGg/HeccdSPD3k76MU66KFhqYejA X-Talos-MUID: =?us-ascii?q?9a23=3AR/FKtA7NZl2ZTUmoxGCHD0SBxoxn8vSkJBghoK4?= =?us-ascii?q?XkPSeETx5axSHoCWOF9o=3D?= X-IronPort-AV: E=Sophos;i="5.99,250,1677560400"; d="scan'208";a="110371711" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ULuGhHlj2ISnghdgpqb4EG6URH8INlEONQvHxdgVsfW4QtxkPX6GoRxGQh8vyZg5RwiM4QStkhPkBk8cML8VjSPh79dOa8JljP494LZ6x7iWerrrpb+zzEUqCX8fJAYq+kltENCH9tmdv6PVqJWQOQZxnnmcKsiz0YzqMZ+D1HjzXnKyfIRUrzcG09FAj8HkKsEZNbPCpMyf1FWn2bFPm0zPq7ZIlEp6Vj9aOLxQ+NgOlnS8yAu8lGlFZiRIIg7VpjZDGSL1dtIesQ/qjFqg/RqTeJUHvqEUZMMRDpQ91k+oh34jQDZc7ThIEKNPAJhznEB3OaKd0qOVFmZ8F4rUfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=btf+YDR09e31a7nJQt4TFhTa4ii9ccR3xjDeZADBtFU=; b=GykOnQVztneNYAc0H2rAk5tUFdK3UNw6/9WWn5cunhlUOMXIbuFU67WlXh/AyfPKTnx8r8cnF0qMfOAM0+tNmUgSGd/GFPDNbd4gGIFkL540i8T6sz7v9dBJLWKX81glrMTGOEgsI6eiL/3ChMXzMXkK6a23t12wWtpMxxYH7odspoL4Q3yZBpXdioahTQAasEiSEKbD8f9ZuDKv9J+VfC5U5Dlh3IqnIXBWaYsqp5kGB5Fz4toL33fK8Z3EN50//Or7YOYxib+2N6NP7cqabtlRo7057Nh3s56gUm8lPoBCZ5T0cSynLLu9ogm7c2SANGwVCmgE1cuu3w21MFmEIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=btf+YDR09e31a7nJQt4TFhTa4ii9ccR3xjDeZADBtFU=; b=J90gB9GLYZwmXiu3bmiuqp8KNl2vYOikQyV62BGqXZa7nDm5xOUvdf3xhNlqrOWoGrYaWy07Eeb3rpF3OiQuJaLmHBOnLuCXTSSQ9Wg/WPo+LE7MZyHygC6gO7E5vmHZtRqEpGVJzVfpa5lEKbbSYihDv7tDNYSno8G6g/B5dqI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <38b259bb-050b-023e-4f43-212f95f022ac@citrix.com> Date: Fri, 5 May 2023 00:04:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: Andrew Cooper Subject: Re: [patch V2 34/38] x86/cpu/amd; Invoke detect_extended_topology_early() on boot CPU Content-Language: en-GB To: Thomas Gleixner , LKML Cc: x86@kernel.org, David Woodhouse , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" References: <20230504185733.126511787@linutronix.de> <20230504185938.179661118@linutronix.de> In-Reply-To: <20230504185938.179661118@linutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0473.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a8::10) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|DS7PR03MB5510:EE_ X-MS-Office365-Filtering-Correlation-Id: ddb066f3-8553-4af6-a2aa-08db4cf3e645 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KD0D68GVI57Fkqj8sMXyvLmEFZdB1+Xt/tcujv3JRziSTvGLC3LmYl0Q0o26xJbFwukSYHYgWGgqVAmfkmM6/z3nbvCAl+dV0NmmIrGH+/JoeUB0z73A2x+ltr6lRiwatqE4EOvo3U8RhHGXDnplF8XCKAsGZsC3bp6qywM5MNaVeIcijmqqPcRnhp9v/KaXUzRhczrprcV6YfAYSFbk3mZxV5TKB1rP4J2tSnKs89cGOJOD3Upg2p4lA3CLmFkZGPmz2ZOFs4e+aeUIrcUN5lnzA6kf8a4HaWhxp4Qc6z09TAUys8ND/+R0icaBN31FovcuUh9AMZDsznriMRyc7OMfNQBSmqSxuXtb73qpxA7LSyABUBdGaMokqPy02hVxAxccngzmVDiOLxd7zCG/CCD4jb4xC5LMyJhxuFtsbMOWt3EdVtE00x6jORAoYW8UUrcS8tsPJPhMYxlPIi7+R6qlH2VQbYta3G+2kNqXQ6wBSKNRuKQKSfn+r+rvQDAWYITrFivQv/KA937tbtlmcGGi4FAfBKh88UbmS5ovo+IxaEmZu+1iB7CX1O9TQLPkTct5Rx5m1F+2YrgSKfYKsApbkQ0SLooOyUg0cf79IwWpgJxnSDZltbuQx6l2FqzAyqExrt0z7yXtlisF9lPLlg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(376002)(366004)(136003)(346002)(451199021)(2906002)(4744005)(8676002)(31686004)(54906003)(41300700001)(66946007)(478600001)(5660300002)(316002)(8936002)(186003)(110136005)(6666004)(4326008)(66556008)(7406005)(7416002)(66476007)(6486002)(26005)(6512007)(6506007)(53546011)(82960400001)(36756003)(83380400001)(2616005)(31696002)(86362001)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aWt5ekN6YWVqNGdWc3czcS9tcU9ZYTB3YnQ3YUxOMGg4VDNXSXduRU5JQzVl?= =?utf-8?B?SWRYeWxETFNiTGFtWXNSRGRMNm92VDhmcUFwNm9OVW5QdWhjMmptZzYzWElz?= =?utf-8?B?WTZHU0p0OHEyckh6OXVjMy9ZTnQ2ZGp4eDVvVit2NGQ1YXVYaXpDSzYxeWVi?= =?utf-8?B?SjA1ZjZzQ0c1cEsyWUdVK2Q0Z2txenlYdXpPS3FPSzZCbkV6MDAwcS9DZ09v?= =?utf-8?B?ZytOM1hpdmN3QXdtNVhHYlpJZldtdUUvSVphVUxVSkNJay9WWmgzanRQVnNP?= =?utf-8?B?TXBmNkp0VWQwRE9nRHE3UGRkdGdwZTQ5dVkrVFdsam1ITHZBc0JXM3YyNHB6?= =?utf-8?B?UzVPNGExQ0tabSt3SFo1OE9VQkNrVWdWNmh1b3ZTbEtZazhBbTBOTGlMQlM4?= =?utf-8?B?aFc2dWgvU1hvbHZadnEyWG9aUFExVUxlZFhnVXliaVY3SHhjUmhiQW5DUUFk?= =?utf-8?B?R3dia3ZrMEpnUGhTeGVmNFVhV2RlTHFEM2pvREpTcG5tTVIzd2JpODdLM2xl?= =?utf-8?B?RGdyaDU1UVFtUCtTTkhUcEUwbW94ZVVGUkUxeG1YYS90ZWplSW1hbS9PSzZ0?= =?utf-8?B?aFRqd0hJM0lXVDBFNm9mcWJYT2N1NWlXVWVuOS9MUzkrL0VZeXhNZzBwL1Y1?= =?utf-8?B?bTlvN3FLTEV3Z1RzWjdRQjd0TG9CdXo2dEVoUVIzMDVmMEdneit5dXNGWEV0?= =?utf-8?B?M09RdSthaGRFUzdRUUpNSStZUmVuN1gyeWRsSmhMc29uUWxkUE1oMTlEcjYw?= =?utf-8?B?d1hMdXFpNlMvVnNlNU9TN0dBTVNBSW1hY0hHQ0hiZWQxMFcrYm5uVXFVQWc0?= =?utf-8?B?Wm9VMkkxWUR5NC8waVcrNUNBK2xKRnZkSy93K1JCMDR4cVFZN1NXWmVtSjly?= =?utf-8?B?aTVjT0ZwbkhGa2xMOGR6WHhXbUhqWFJOd0tZV2tjUmNKY2hvd1Jvc3FpVmh1?= =?utf-8?B?RUxPY1dOVzlORFcwT3VDSjhPZVJqdmRKU25xMFFrMWdzdTJzY1EzNjJvcDQ2?= =?utf-8?B?OThxbUxpY2dtTzdBL0kreW9Na1gwdTFlYTNWS0xSMC9GUDlMc3NVdmZNQlRQ?= =?utf-8?B?Slg2c3ZPYVJCdDdzdURUN3pxNURqRnZ0YktzbkNlSzgyTGxYWmhCWTJWMGU1?= =?utf-8?B?UVNBRTBMZ2kxLzJSb3QvQXpsS2hxQ1BDNGJYRjAwMitBRk9iN3dZc2ErekNQ?= =?utf-8?B?dGpNZWcyWVRsUGRTeDF2NnJtN2wrbEZqZkI3amxCemFFaGFSOW9UWUp2eDdz?= =?utf-8?B?djUzTWZiUGRURHBZNEV3azUxZzVwa0pMUWlFVm1rekRaQmNHWkxDeWhQeHh1?= =?utf-8?B?UDBSN0drdHRvMnRYcE5QUUJ1d2NjYWgrOWJJamN5UlE1WkRpNVF0M2UvbWpZ?= =?utf-8?B?b3UvUUNFd3NIekFpN1F1T3AwUHU2QnNNVE9TMzZLNlJOTkc1VS9OQVV2WXBh?= =?utf-8?B?Q3VEazZCMFl2bkJJcnpzdW1BTFA2aTRzTHR0bXp2YVV6Q1dLcWR1RW1RS2tm?= =?utf-8?B?N0x0WW95MUMyOFZUaExXb001M2RHWEF4blFZUUFvWU1qK29GeWtyNXNuT204?= =?utf-8?B?TlR1VXA3QjdyTnN6R1NiNHpBajBuSVI0eHA4TVBFdmxaOERCbTdTcDhUc2gw?= =?utf-8?B?dXRoNmZNa0lUSjFtRnVrRk0zOEZubFk5L0taZHI5Nk9zczlWSit1MTBKUlho?= =?utf-8?B?WHkvNnRQNUhsTG84dVN1UXp4YlJwc1R2STU4NFRsSUVMbkVVMGVITm5mVzVY?= =?utf-8?B?V2V1VWVPN2NUV0VKb3Q4SHd3aVNxN2FIQTRIN0I5U1JLQ2huQ0l0VjZkV0dx?= =?utf-8?B?OUdKQUV1djFaZUhWMnA1ZjJvSTNYQW9xd014VDMveTYxZDFIVDlQdUxuUXhE?= =?utf-8?B?QjhjWi9tbmtFS0l6VjMxeUM0dzczVDRxUGpZcklsRUc0RldrZi9aVEVyYnBx?= =?utf-8?B?VkxhRWlHWjNWV3IrWGNuQTVkSERxRXI4TmRiWm1VaHFwemxqcnhUM28zSnRI?= =?utf-8?B?VTQ2eFVrTDRxY0M4a3FucjBPVXgrc29uOHk2NXJNUVp0TVEzTzVSN1dFc0JD?= =?utf-8?B?ZG1VY0prSHE0TE1QMGVzNk5CSU1yUnZXZU10eHF4bkFUcDArU1BJU1UvWmFl?= =?utf-8?B?UVJRNlErdEFIQno3R0xhOWpxL3I4ZUNmRGJoaEViODJ0N0Vna0ZoMHVqU3Vq?= =?utf-8?B?ZVE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?ZE5oTXhTNjdUQjRtL0hadXhibmVmNHBXQTlmc25xYzE1ZXo4c1FiM29TREJv?= =?utf-8?B?c3RCRnlhL2NOSzQ5T0V0anVCc3J3ZGxrOXFLaUh0OFhUTnkxRUdGK2VSZG0r?= =?utf-8?B?cmVVYVdHYlBCTHJ4V1NVRFNZV2kzOVhSdlNOT1NLT2lJcEE2TlV2dlhOVW5N?= =?utf-8?B?VnBKbzlxdXFneUpqRWVXZkFjaWFUSEVVQi9SUFcweUFLVHhidjB2L1N3VmVP?= =?utf-8?B?TlhpdGRxTnpWWFFXZVk0UjFhOW1BZW5TZUh3VlQ0Tmh2YlRkeVpkWC9pMHZy?= =?utf-8?B?QjZza296S1ozOThHV0RPWVRhaXNUeDNCd2dxcG56OVc1YWxXT01jdG80VmR3?= =?utf-8?B?NWlaOWV4cnJnQUxITHFxNU9NM3pIR2NSSFdxYmdsbHBPQlhSY1NQWm4yZE5a?= =?utf-8?B?VmJTY25lUFZHTURGY3hFRDR1cmcyQzllclU2WS9BQzdwM2poQjA2VXd4UlFo?= =?utf-8?B?UWJnMjBlZFc4RmYxWkxxeWFKSTNMOUJURHpnOUc0S3VLeHlnbU54YmxDN0Zj?= =?utf-8?B?ZkgwNXdGVDlFTEtvNGs4aDFGaVB4QnROOGRnL3YzdlAzaXdobzZIWXlySEJK?= =?utf-8?B?UCtRMkc2SG9ZV3dBS0w4U05qMXJnVUxKMTYxc2x0bzFpci95b2FLQWk0MWxu?= =?utf-8?B?amwzeU5uOVNwSmxtNjdFZmk4ZklOb3d6RitiemRlRUl5QjNTUjNXZkUvTnpD?= =?utf-8?B?NGRDbkhVRmthZktxejlmN2s5MTFSaTg0Q1g4TktHb1NnelJYRWtLaFBUdnph?= =?utf-8?B?dmJvMGpndjhhMTBxRmJpVjk5Z1ZIem50SVU3aHRUdmEzY3pPazduVUhXaEFF?= =?utf-8?B?cDU0YVFEZEowR0hSaUFkL3FlOVNwRXhoKzVEN2xDR1NwRVMvbk9hdDVxVkxu?= =?utf-8?B?L1RTSE43ZEZlOFFIRHYzaWYrMHZSU1hObENFN3VUbE1acmRVYWZyK3JnUkR2?= =?utf-8?B?SDQxVUtwRmFQUWZWdWpUUjN1ME9yQTE1ZEZES3lBNXpDM3JkYzlud3p3SCtD?= =?utf-8?B?bVc2WTJOaTZ5blBjK2s2UTR6S3NLQTMxM1RQUlovQjlSSDdLalJKb1BQTnFJ?= =?utf-8?B?anVLTEhIYUIwTThxdFd4SXgwWERkMjhEcEs2WEVmeEdGMUU4Nmc2K3I2UmxC?= =?utf-8?B?VUlFR2VKVHpVKzE0TWp4TDFJd2FlNFl1TU8vR2t5ZDBoRFNRVGMyeFFHWnhW?= =?utf-8?B?ZEdVYkhmRU5nelVWRkFzNGIwUjQySnBVdXVDV2t0ZzNERlhpVWtQRjRVSjgx?= =?utf-8?B?YTB4eFd0b0dSc3BiN21CSERaVVpydDdMMmRkWFR0TU9Uc08vVFR3UEYxdU0r?= =?utf-8?B?NU04MkxLSHo5Uk85cXViaUdXMWJ4MDMvdVBOYnpCVmcrQU1lb0tqei9tTElk?= =?utf-8?B?eFM2Q0toU2UvNkVRUWlIb1NySG05bml4b1QvakRmQ09ZZ2dpZkZMZDd0dGtt?= =?utf-8?B?Z2hFV2M1amxtRjVvaVJIUUlTZGdRUk0ySytiK0FlVU1ZenVNV0hBVVJnaEM2?= =?utf-8?B?ZXcyREJjcDBZdmVYVkhPTFBwQ1U3alJmSUVid2VZS21sak5nMnk0Q1hxZmZn?= =?utf-8?B?WExlQnd2bmpXSWRFeWdHLytvdVpsK0drTGcvK0d2Ykoramh1eS92eXFCYXhS?= =?utf-8?B?SWloeTFkYXgwbDFZSEgrZDFPMlcxRTZvS0FHRDVsUmYwZWJ6N1lhbllVWE5I?= =?utf-8?B?SDZzK2o2T2IyZEZyVXE1UVQ1bzBubVVMc0V1bDJMdmwrcG85OW1VL25HSEpG?= =?utf-8?B?NitCelpBdmZjdGFCQjJYamdwVGFOWTd2WUlveWdxTHVlOVMyZEpSUU1FditT?= =?utf-8?B?VFpOdEcwT2h3dUc1QXYwVlpYTGEwZFJQaFNMalA1OTlpR3NQcHlhMW9jMVhM?= =?utf-8?B?OHdjZTJOWlZJRXJObXlyNzRDRzJ3aXlFaGx0Y2FSOHVUd2lKQ3I0bzhEVkhZ?= =?utf-8?B?TTZpdjVFNkNTQm1jdXJwYW00UjRpNVFEZTZDVk5iUWRFM3YzZ2dUcnpua0gz?= =?utf-8?B?WGU3cGZyU2FienVzNHZCM3duNHlQQy8zdzlYb2lTaDQ0RnN6STJXWE9uWERu?= =?utf-8?B?alRvVGMrWEhOdElvamVwNXVIdWlNQVR1M2V0Qy90WjJaWENaQ1RzV0swSWlM?= =?utf-8?B?Z1NiNThHQUlmL0x6ZCtuVE85T2pLZmRxSi93UnR4QmVaSVR5OFBuU2FEejJi?= =?utf-8?B?MktacDlnSngydzlGYnVPb1NBcE5xM3pQaWJabzBldDNGbWhrU2xTQ0ZaQ1VP?= =?utf-8?B?WjUrMVA1VmRjSFBHeG1pbFJxUW5RPT0=?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: ddb066f3-8553-4af6-a2aa-08db4cf3e645 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 23:04:23.2063 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: L3M8vqN1eZMqZZM08fyQ6wS6KeSqlN98nl5daeUcL2WR76YX3Aoej1X//2uBjOZ0V02Gwj//z4/8ArazEkfIn9M67MlzwwFXVX+7wRwXgFg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5510 On 04/05/2023 8:02 pm, Thomas Gleixner wrote: > From: Thomas Gleixner > > The early detection stores the extended topology leaf number which is > required for parallel hotplug. > > Signed-off-by: Thomas Gleixner It occurs to me that this and the previous patch are stale given that we no longer look at CPUID in the trampoline. They're probably useful changes in isolation, but the commit messages want adjusting to remove the association with parallel boot. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri May 05 00:35:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 00:35:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530199.825643 (Exim 4.92) (envelope-from ) id 1pujPs-0007mq-Um; Fri, 05 May 2023 00:35:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530199.825643; Fri, 05 May 2023 00:35:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pujPs-0007mj-QE; Fri, 05 May 2023 00:35:20 +0000 Received: by outflank-mailman (input) for mailman id 530199; Fri, 05 May 2023 00:35:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pujPs-0007mZ-78; Fri, 05 May 2023 00:35:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pujPr-0007GE-SX; Fri, 05 May 2023 00:35:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pujPr-0007TR-Ej; Fri, 05 May 2023 00:35:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pujPr-00033l-EG; Fri, 05 May 2023 00:35:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=XY7MAMu3USn7TULXagilGunIRzGVRp9BZiH/hQUWH4Y=; b=lHz3tydp5H+Ov7G6aAPinMLlbV 7c3h0M3H1/vMaJVK+e6/Y1bwgao9vE/zVKCrA6EfZk3LB3AjG0RWsjvoXfUzm+D4Cbu44+Ilb2VzW KxU6Y6SUYdEdoM4HSMK4Tz8Q3tCXl1C1Vt/BGd0huevjY6UCLTBfIjBWpJ2NP/C/qVBA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 180530: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=1488ccb9b64e76aab0843bc035ce3b1938df2517 X-Osstest-Versions-That: qemuu=044f8cf70a2fdf3b9e4c4d849c66e7855d2c446a From: osstest service owner Date: Fri, 05 May 2023 00:35:19 +0000 flight 180530 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/180530/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 180522 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180522 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180522 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 180522 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 180522 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180522 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180522 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180522 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass version targeted for testing: qemuu 1488ccb9b64e76aab0843bc035ce3b1938df2517 baseline version: qemuu 044f8cf70a2fdf3b9e4c4d849c66e7855d2c446a Last test of basis 180522 2023-05-03 23:41:02 Z 1 days Testing same since 180530 2023-05-04 13:29:10 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Eric Blake Richard Henderson Stefan Hajnoczi jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 044f8cf70a..1488ccb9b6 1488ccb9b64e76aab0843bc035ce3b1938df2517 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Fri May 05 03:10:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 03:10:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530205.825653 (Exim 4.92) (envelope-from ) id 1pulpn-0000UW-45; Fri, 05 May 2023 03:10:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530205.825653; Fri, 05 May 2023 03:10:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pulpn-0000UP-0C; Fri, 05 May 2023 03:10:15 +0000 Received: by outflank-mailman (input) for mailman id 530205; Fri, 05 May 2023 03:10:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pulpl-0000Sk-SN for xen-devel@lists.xenproject.org; Fri, 05 May 2023 03:10:13 +0000 Received: from out0-207.mail.aliyun.com (out0-207.mail.aliyun.com [140.205.0.207]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 55608d96-eaf2-11ed-8611-37d641c3527e; Fri, 05 May 2023 05:10:07 +0200 (CEST) Received: from localhost(mailfrom:houwenlong.hwl@antgroup.com fp:SMTPD_---.SYe4zj5_1683256196) by smtp.aliyun-inc.com; Fri, 05 May 2023 11:09:57 +0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55608d96-eaf2-11ed-8611-37d641c3527e X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R461e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018047188;MF=houwenlong.hwl@antgroup.com;NM=1;PH=DS;RN=34;SR=0;TI=SMTPD_---.SYe4zj5_1683256196; Date: Fri, 05 May 2023 11:09:56 +0800 From: "Hou Wenlong" To: Juergen Gross Cc: , "Thomas Garnier" , "Lai Jiangshan" , "Kees Cook" , "Brian Gerst" , "Thomas Gleixner" , "Ingo Molnar" , "Borislav Petkov" , "Dave Hansen" , , "H. Peter Anvin" , "Andy Lutomirski" , "Boris Ostrovsky" , "Darren Hart" , "Andy Shevchenko" , "Nathan Chancellor" , "Nick Desaulniers" , "Tom Rix" , "Peter Zijlstra" , "=?UTF-8?B?TWlrZSBSYXBvcG9ydCAoSUJNKQ==?=" , "Ashok Raj" , "Rick Edgecombe" , "Catalin Marinas" , "Guo Ren" , "Greg Kroah-Hartman" , "Jason A. Donenfeld" , "Pawan Gupta" , "Kim Phillips" , "David Woodhouse" , "Josh Poimboeuf" , , , Subject: Re: [PATCH RFC 16/43] x86-64: Use per-cpu stack canary if supported by compiler Message-ID: <20230505030956.GA103506@k08j02272.eu95sqa> References: <7cee0c83225ffd8cf8fd0065bea9348f6db3b12a.1682673543.git.houwenlong.hwl@antgroup.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) On Thu, May 04, 2023 at 12:31:59PM +0200, Juergen Gross wrote: > On 28.04.23 11:50, Hou Wenlong wrote: > >From: Brian Gerst > > > >From: Brian Gerst > > > >If the compiler supports it, use a standard per-cpu variable for the > >stack protector instead of the old fixed location. Keep the fixed > >location code for compatibility with older compilers. > > > >[Hou Wenlong: Disable it on Clang, adapt new code change and adapt > >missing GS set up path in pvh_start_xen()] > > > >Signed-off-by: Brian Gerst > >Co-developed-by: Hou Wenlong > >Signed-off-by: Hou Wenlong > >Cc: Thomas Garnier > >Cc: Lai Jiangshan > >Cc: Kees Cook > >--- > > arch/x86/Kconfig | 12 ++++++++++++ > > arch/x86/Makefile | 21 ++++++++++++++------- > > arch/x86/entry/entry_64.S | 6 +++++- > > arch/x86/include/asm/processor.h | 17 ++++++++++++----- > > arch/x86/include/asm/stackprotector.h | 16 +++++++--------- > > arch/x86/kernel/asm-offsets_64.c | 2 +- > > arch/x86/kernel/cpu/common.c | 15 +++++++-------- > > arch/x86/kernel/head_64.S | 16 ++++++++++------ > > arch/x86/kernel/vmlinux.lds.S | 4 +++- > > arch/x86/platform/pvh/head.S | 8 ++++++++ > > arch/x86/xen/xen-head.S | 14 +++++++++----- > > 11 files changed, 88 insertions(+), 43 deletions(-) > > > > ... > > >diff --git a/arch/x86/xen/xen-head.S b/arch/x86/xen/xen-head.S > >index 643d02900fbb..09eaf59e8066 100644 > >--- a/arch/x86/xen/xen-head.S > >+++ b/arch/x86/xen/xen-head.S > >@@ -51,15 +51,19 @@ SYM_CODE_START(startup_xen) > > leaq (__end_init_task - PTREGS_SIZE)(%rip), %rsp > >- /* Set up %gs. > >- * > >- * The base of %gs always points to fixed_percpu_data. If the > >- * stack protector canary is enabled, it is located at %gs:40. > >+ /* > >+ * Set up GS base. > > * Note that, on SMP, the boot cpu uses init data section until > > * the per cpu areas are set up. > > */ > > movl $MSR_GS_BASE,%ecx > >- movq $INIT_PER_CPU_VAR(fixed_percpu_data),%rax > >+#if defined(CONFIG_STACKPROTECTOR_FIXED) > >+ leaq INIT_PER_CPU_VAR(fixed_percpu_data)(%rip), %rdx > >+#elif defined(CONFIG_SMP) > >+ movabs $__per_cpu_load, %rdx > > Shouldn't above 2 targets be %rax? > Ah yes, my mistake. I didn't test it on XEN guest, sorry, I'll test XEN guest before the next submission. Thanks. > >+#else > >+ xorl %eax, %eax > >+#endif > > cdq > > wrmsr > > > Juergen > pub 2048R/28BF132F 2014-06-02 Juergen Gross > uid Juergen Gross > uid Juergen Gross > uid Juergen Gross > sub 2048R/16375B53 2014-06-02 From xen-devel-bounces@lists.xenproject.org Fri May 05 04:35:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 04:35:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530209.825663 (Exim 4.92) (envelope-from ) id 1pun9b-0000Hf-6z; Fri, 05 May 2023 04:34:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530209.825663; Fri, 05 May 2023 04:34:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pun9b-0000HP-30; Fri, 05 May 2023 04:34:47 +0000 Received: by outflank-mailman (input) for mailman id 530209; Fri, 05 May 2023 04:34:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pun9a-0000HF-H0; Fri, 05 May 2023 04:34:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pun9a-0006mC-8F; Fri, 05 May 2023 04:34:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pun9Z-0002Pn-KN; Fri, 05 May 2023 04:34:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pun9Z-0007NU-Iq; Fri, 05 May 2023 04:34:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ZKLpdVI7fAo9ICFG/vY0Y52V2+cNUw2Ao5juOwN75GM=; b=AcGIgpI4RPVoCwSSDkTYvrxir3 NUGANY8eSCivn5l24vMot/FQW2Qzcm84Z1+hubGYxYcC8m9fWHDv0gxYP/VDfBvsuSRASVg7uzGNf 3DJP17zoeTUF13YiWzAfZjZUYByo+WRUMOOfyjYfYH+d/P5DIp3j3rmf05ujtV2XH6uo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180531: regressions - FAIL X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:build-arm64-pvops:kernel-build:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:guest-start/debian.repeat:fail:heisenbug linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-examine:reboot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=1a5304fecee523060f26e2778d9d8e33c0562df3 X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Fri, 05 May 2023 04:34:45 +0000 flight 180531 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/180531/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 180278 build-arm64-pvops 6 kernel-build fail in 180525 REGR. vs. 180278 Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-qcow2 19 guest-start/debian.repeat fail pass in 180525 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 1 build-check(1) blocked in 180525 n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked in 180525 n/a test-arm64-arm64-xl 1 build-check(1) blocked in 180525 n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked in 180525 n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked in 180525 n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked in 180525 n/a test-arm64-arm64-examine 1 build-check(1) blocked in 180525 n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked in 180525 n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked in 180525 n/a test-armhf-armhf-libvirt 8 xen-boot fail like 180278 test-armhf-armhf-xl-vhd 8 xen-boot fail like 180278 test-armhf-armhf-examine 8 reboot fail like 180278 test-armhf-armhf-libvirt-raw 8 xen-boot fail like 180278 test-armhf-armhf-xl-rtds 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180278 test-armhf-armhf-xl 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180278 test-armhf-armhf-xl-multivcpu 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail like 180278 test-armhf-armhf-xl-credit2 8 xen-boot fail like 180278 test-armhf-armhf-xl-arndale 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 1a5304fecee523060f26e2778d9d8e33c0562df3 baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 18 days Failing since 180281 2023-04-17 06:24:36 Z 17 days 31 attempts Testing same since 180525 2023-05-04 05:05:04 Z 0 days 2 attempts ------------------------------------------------------------ 2224 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 272978 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 05 05:59:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 05:59:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530219.825673 (Exim 4.92) (envelope-from ) id 1puoTR-0000X2-9f; Fri, 05 May 2023 05:59:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530219.825673; Fri, 05 May 2023 05:59:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puoTR-0000Wv-6J; Fri, 05 May 2023 05:59:21 +0000 Received: by outflank-mailman (input) for mailman id 530219; Fri, 05 May 2023 05:59:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puoTP-0000Wp-Pi for xen-devel@lists.xenproject.org; Fri, 05 May 2023 05:59:19 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f8c3eedf-eb09-11ed-b226-6b7b168915f2; Fri, 05 May 2023 07:59:18 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7C4F221E44; Fri, 5 May 2023 05:59:17 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5799913513; Fri, 5 May 2023 05:59:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id OxTyEzWbVGTedQAAMHmgww (envelope-from ); Fri, 05 May 2023 05:59:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f8c3eedf-eb09-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683266357; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=B4hrcc2cZgLfaRZrHv5ILnE7WRWszh0eF+pWeBIt/DI=; b=bUIAvbfofH4x8PaIi+zNc3HF2sePEX7IJeN86HmLXJndFdaITErVc1EQ+KYzMe9OKiZnB9 RO6824ZfsTloOogdHZfT1dcxvHKqwmUMpOnd8vaJ3C+J2tsi24Muf61hp9ItyTlLMY+1HQ cU+SgqUDuWT4dXfkrJmukC28WHQZfK8= Message-ID: <30246788-c90e-e338-de4b-e7bb2e440f4e@suse.com> Date: Fri, 5 May 2023 07:59:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v1] xen/sched/null: avoid crash after failed domU creation Content-Language: en-US To: Stewart Hildebrand , xen-devel@lists.xenproject.org Cc: George Dunlap , Dario Faggioli References: <20230501203046.168856-1-stewart.hildebrand@amd.com> From: Juergen Gross In-Reply-To: <20230501203046.168856-1-stewart.hildebrand@amd.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------1r2vBuGWKZJSNerkRJ9qgZg8" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------1r2vBuGWKZJSNerkRJ9qgZg8 Content-Type: multipart/mixed; boundary="------------03jFee1iNTSgY4Evcw7jPZLX"; protected-headers="v1" From: Juergen Gross To: Stewart Hildebrand , xen-devel@lists.xenproject.org Cc: George Dunlap , Dario Faggioli Message-ID: <30246788-c90e-e338-de4b-e7bb2e440f4e@suse.com> Subject: Re: [PATCH v1] xen/sched/null: avoid crash after failed domU creation References: <20230501203046.168856-1-stewart.hildebrand@amd.com> In-Reply-To: <20230501203046.168856-1-stewart.hildebrand@amd.com> --------------03jFee1iNTSgY4Evcw7jPZLX Content-Type: multipart/mixed; boundary="------------08zeABpPTNQOu4WKvLXjlc0o" --------------08zeABpPTNQOu4WKvLXjlc0o Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDEuMDUuMjMgMjI6MzAsIFN0ZXdhcnQgSGlsZGVicmFuZCB3cm90ZToNCj4gV2hlbiBj cmVhdGluZyBhIGRvbVUsIGJ1dCB0aGUgY3JlYXRpb24gZmFpbHMsIHRoZXJlIGlzIGEgY29y bmVyIGNhc2UgdGhhdCBtYXkNCj4gbGVhZCB0byBhIGNyYXNoIGluIHRoZSBudWxsIHNjaGVk dWxlciB3aGVuIHJ1bm5pbmcgYSBkZWJ1ZyBidWlsZCBvZiBYZW4uDQo+IA0KPiAoWEVOKSAq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqDQo+IChYRU4pIFBhbmlj IG9uIENQVSAwOg0KPiAoWEVOKSBBc3NlcnRpb24gJ25wYy0+dW5pdCA9PSB1bml0JyBmYWls ZWQgYXQgY29tbW9uL3NjaGVkL251bGwuYzozNzkNCj4gKFhFTikgKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKg0KPiANCj4gVGhlIGV2ZW50cyBsZWFkaW5nIHRv IHRoZSBjcmFzaCBhcmU6DQo+IA0KPiAqIG51bGxfdW5pdF9pbnNlcnQoKSB3YXMgaW52b2tl ZCB3aXRoIHRoZSB1bml0IG9mZmxpbmUuIFNpbmNlIHRoZSB1bml0IHdhcw0KPiAgICBvZmZs aW5lLCB1bml0X2Fzc2lnbigpIHdhcyBub3QgY2FsbGVkLCBhbmQgbnVsbF91bml0X2luc2Vy dCgpIHJldHVybmVkLg0KPiAqIExhdGVyIGR1cmluZyBkb21haW4gY3JlYXRpb24sIHRoZSB1 bml0IHdhcyBvbmxpbmVkDQo+ICogRXZlbnR1YWxseSwgZG9tYWluIGNyZWF0aW9uIGZhaWxl ZCBkdWUgdG8gYmFkIGNvbmZpZ3VyYXRpb24NCj4gKiBudWxsX3VuaXRfcmVtb3ZlKCkgd2Fz IGludm9rZWQgd2l0aCB0aGUgdW5pdCBzdGlsbCBvbmxpbmUuIFNpbmNlIHRoZSB1bml0IHdh cw0KPiAgICBvbmxpbmUsIGl0IGNhbGxlZCB1bml0X2RlYXNzaWduKCkgYW5kIHRyaWdnZXJl ZCBhbiBBU1NFUlQuDQo+IA0KPiBUbyBmaXggdGhpcywgb25seSBjYWxsIHVuaXRfZGVhc3Np Z24oKSB3aGVuIG5wYy0+dW5pdCBpcyBub24tTlVMTCBpbg0KPiBudWxsX3VuaXRfcmVtb3Zl Lg0KPiANCj4gU2lnbmVkLW9mZi1ieTogU3Rld2FydCBIaWxkZWJyYW5kIDxzdGV3YXJ0Lmhp bGRlYnJhbmRAYW1kLmNvbT4NCg0KUmV2aWV3ZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9z c0BzdXNlLmNvbT4NCg0KDQpKdWVyZ2VuDQoNCg== --------------08zeABpPTNQOu4WKvLXjlc0o Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------08zeABpPTNQOu4WKvLXjlc0o-- --------------03jFee1iNTSgY4Evcw7jPZLX-- --------------1r2vBuGWKZJSNerkRJ9qgZg8 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmRUmzQFAwAAAAAACgkQsN6d1ii/Ey/l gAf+IbHz8hfyLQmPAE2DThyZ1ZaNXSc0mEoTGBoYsRoLm9PIpUSNAysxfqtBkOJq7YuUzReXsUgo QdV3XGKI/i/8m0GnxWMfRykDDtUFX+7vHH6gw1fAptLKz38ASEqezxrqy6kNx9UZxFVZ+TGKoD5Z HaxKw8OudFhg3Fd7NLDpfI2k4Vmj7z1eZlC/E7ZuNl2LYFkHVYNt/0su4mLMkvN/OSGev9KorGdN ezUYgpjGPbRofc4kSgfke9eg+DYzJzhRgrG9H3N0L7a9I9aiJGaDiSATIxXMGInsunIIMIqZj7T0 go6aqcv/n72TizkoCCsEjznwhxYSvrIh5721pLO73g== =7h+W -----END PGP SIGNATURE----- --------------1r2vBuGWKZJSNerkRJ9qgZg8-- From xen-devel-bounces@lists.xenproject.org Fri May 05 06:07:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 06:07:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530222.825683 (Exim 4.92) (envelope-from ) id 1puobN-00025d-2z; Fri, 05 May 2023 06:07:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530222.825683; Fri, 05 May 2023 06:07:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puobM-00025W-W8; Fri, 05 May 2023 06:07:32 +0000 Received: by outflank-mailman (input) for mailman id 530222; Fri, 05 May 2023 06:07:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puobL-00025Q-Lp for xen-devel@lists.xenproject.org; Fri, 05 May 2023 06:07:31 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0629.outbound.protection.outlook.com [2a01:111:f400:fe0e::629]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1e464c6e-eb0b-11ed-b226-6b7b168915f2; Fri, 05 May 2023 08:07:30 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AM9PR04MB8145.eurprd04.prod.outlook.com (2603:10a6:20b:3e1::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.27; Fri, 5 May 2023 06:07:27 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%7]) with mapi id 15.20.6363.027; Fri, 5 May 2023 06:07:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e464c6e-eb0b-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nlZIW4KjZY1+igXQEsb+pJOXns/C4h8Z03/Mdj5349P2YPB7qSZRWqSwW7yFRqpGkZ6uf+qJ9dPSoGuLmdAbC3ZHxc+eoJYFGi1Usw4tOVOXFat3U7G06/5bJ6CAiSc/Usm8PGuZGo8sqN0nCplhdp/097/D4of8asd6JfyQxcy1KJNVkCmdG54saxEdPWQAQrTYpYpnjtt/6zcpSDiNM8f2LEv3EenTJ+E12TxyoZ20c0u2Xo1pLrX1mnZA+xm/bQ+9DCWoCPVBbpoAs+ilVabYGpYsW/Pqjrudcoy2q9J75QtpGdSyNaC5wjtAC5VzrdF+62f0HPammpgGmpm9aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tyJsGgOmH1j6Xmps5DvUIVknIqyTkutnVPVaG5fiMeI=; b=KNpLwbWStd1hv5xFLDrppYxk89biHjKuq2VfmHpsd+nopjGh/CH96iofcsRo6m+Ep0U/0fECOxUFr19gsNiwwCKF4YpRYF0dvQCyIYbi4mdj2+KwgSpAuxEuJaod4+nUIT9lj9ia+iUylAREXNEqxFVFwjHTKt1+Smt+A322M/5t9WiCooJSqq6ERuta3pKlq65cJBXRQkiIcQ/bhSaKQVBAj+tlDCJX77tGk1GlmaGgJ28YMzlWCJiylBE5rDBItClhC2IlbNzzrlc8g4y6zJfsavpq3XPC93xznRVe//mQeXhqXzKit2VDXYRlQ2Jol3AYyHJOr+uBFc0xj2MEqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tyJsGgOmH1j6Xmps5DvUIVknIqyTkutnVPVaG5fiMeI=; b=A61dMT9lZX/HF1UlWvEepacjOGioHrroKVR6ClPHaDK3VE0/VZ7hGeRW8qgVdkvM1znTi5l9eEeZro2eeOec+PpNAdB7QCo2smFtUrOi8l8DrGk5IcUUc6d80Wi+Zj6HJYJ1IFhMK+iDQ4BiKXM1FK8qYCdja0lF295xlEH2FfGzzLj8rLCnpoHdxZKe4pRYER5JOTjkw856dS/40SVmVNheWcNANKAozQo1lYoupGohNMfZ6YY5WcPo4iYjXImWhdh9jZuMXG1aOrmaEuYubRmDfRYyHUqaRlcXwV2hrLyQe9ts1d0eV0Ejy6LT60/wgrQKwGGJeSgShSlYwgVWbQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <09655daa-97dc-75bf-4590-5c59af7ab84a@suse.com> Date: Fri, 5 May 2023 08:07:22 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH] build: shorten macro references Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Bobby Eshleman , Alistair Francis , Connor Davis , Anthony Perard , "xen-devel@lists.xenproject.org" References: <95467f2c-09ed-d34f-feef-5cd55c60f628@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: VI1PR08CA0221.eurprd08.prod.outlook.com (2603:10a6:802:15::30) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|AM9PR04MB8145:EE_ X-MS-Office365-Filtering-Correlation-Id: 956105b1-fd0e-4a43-154a-08db4d2f009d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Up2KQWLozvOpPlZToLxGKCLTDymBlIQUwACLAZW0prOS9gpAk3nVe4J2vCBu4VUyZXS2bmesqkGt5bE+uGYdLRJqsElCVul+RVX1VVFbtpmbqKzfp6OSpQJgmOrTSNdiBzs5ohqjfhnuLjRXQTrq+7d45KjpvfgT1p3v0FDceyabLYTKVnzb4Pyzb24wPKDlGnje/vF8P7QYEXbcGGmZA0SuVF1ZZfeaeyBx8Rc4Fwjk7VhACTc6BATDGoT3LRGN3YxOF3KRgWBHeSJyhVgLm2b+b425DYC1uIh4QWSDKmPPJ8J+wwXxiZKrWMfxTonfxRxNYuNem2qLY60XSJ3vhQZrQXefjr7WvRe7FlNvTKtiqyjELah7sNpbHnWcTVRyXzNZZ+1JqI7l9EbJRQnRiN17lSV5mk4+X+iqihBWsZ8BMbsf2YkGx56+pD8Meoc9dJgD5N3gz9XfuihaUz7u0hW5pIsCoBwOEjo65dwv4HuNvV8VcKvfa1Fuif8D/4hNm0HZKqys5Nr4+QNLBdDTvubVQxIFcW60HTLblEGDpiDHLPTs5Scb6UsyO8PRcqjqyjskLxva+ZlDoU6zWhxmOYf1Mr1Fs7qBB/cqUPtWMaLHb4gtHas6jYZKg9wuJ1FQmrn0aXktULqkykTVw7dvSQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(39860400002)(136003)(366004)(346002)(376002)(451199021)(31686004)(2616005)(6916009)(4326008)(41300700001)(38100700002)(8936002)(316002)(6506007)(53546011)(478600001)(66476007)(66556008)(66946007)(8676002)(31696002)(6512007)(26005)(6486002)(7416002)(86362001)(5660300002)(186003)(54906003)(2906002)(36756003)(6666004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3crSXVJdHUrVDN5cFlzbWhCSGUzNVkwZGRIT0pFSjFWSWUzalYyU2lscUhB?= =?utf-8?B?NTV6VFU1Q1puTDh3MldZbUk4RGlXU3lnaHZpa2ZOUnoyMlNDT2ZNSVFJMEdX?= =?utf-8?B?bHFpZ1Q0MkE1bmgvR2FmTmo1RlFOc1orTkRLS0tOamliYzZvSTBKQm93Z1Zi?= =?utf-8?B?NGsxNzBmd2hyTkluL2NOcjZWTUlLRjdNbVVhNHd3a3p3eWRmRnhIL2tkbi9i?= =?utf-8?B?K01jdVBpZEZNVEVjMnBwSGhkd2RQQjd6Tmg0WUhLUzkwUFJmUDgwTVZ5RmpC?= =?utf-8?B?bU5WQkRRU0RGMVJsWFNoQ1ovQVlFVkV0ZUhxSG4yWlJWckVwUWZQbU1uQWgw?= =?utf-8?B?WGhQajhuVEY0NkNaY1JHNkRrUHBJd1l3blVPS3htV05NaWxVQmtpZWVPYlBz?= =?utf-8?B?ckorMWMxOGs5cElrR2NmK2tEemJQZmpHSHNUQjBrVkRrWkdoSnBsdWFmVjZQ?= =?utf-8?B?MWhuWmdQK0FUdi9VSWNnQjYxVDhFTGVzWVhMeW1lQmwwUitPTncrWEVtVjJ0?= =?utf-8?B?M09palBqUE9haWp3b0lNekRUdTVZbnVad2ZTTTJVbExpcmljcjJrWWxzUHRU?= =?utf-8?B?b2R0YXhlQm9BeXkreDBiRjJ3bWwrcFA2cWhZSXdrbi9GOFdRSWYvYUNDY2Ro?= =?utf-8?B?L2p6NXlNSHlDN29MK2IyRkt1ZVFDNm4rWURzdEVwMzlyeklJeU5BU2RFWjcw?= =?utf-8?B?SmtIR2xIb2toY2lldWN2MUxWTlNVYm55MnBqVVJybkpSYWN2UWdBdUgxUldK?= =?utf-8?B?N2E5SmpYQ1hJTlVJeUU3eEswOTNPaFZFMWNRUVA1U2trb05jaENiNjBCV05F?= =?utf-8?B?MUZNNjZSYXNYK1dIbEtWMkQ1ZkFYcnBqRXBxdHpKYUVQb2JQQjB1MGRLL1VS?= =?utf-8?B?TWxOK1FUVXlnRVZ0SGtJakhzTXJmeTJkMlZtdE9PVkYzQm5kOENGdExhMUoy?= =?utf-8?B?M1pNQ3g3T3VQaW43L0p1YjNIekYwekorQlkwM3V6Q0J0c0lTMWhkcE5IOTFy?= =?utf-8?B?bHd0Y2NQSmo0S3BtYVJDOUo0MGJNT0p5UlllNUUvbkNtVmJvc0NzQmNucEE0?= =?utf-8?B?cGg5cUdpcDFUb2xHd2d3U3g2UjVlaU5naGRZaG13SytaRVQ1UDNrM1NPbFRr?= =?utf-8?B?NjN3d1Q3MVRYdkhvYlNXd2EvdGZvbC9Kc3VnUUVyNk55Wkc5MlE2Nk1FNmVt?= =?utf-8?B?ZTBxakRJQTZFd1dSZGE1a0xETE9tdnMrUlVTbUgzSllyY3g4WU5TM2ZNc0Uw?= =?utf-8?B?Rk5oQTA4TmpQbTd0bHp5cElaRnFxdDU1YWtUZmR2aXN5UHVyVHpVdmdkd0Qv?= =?utf-8?B?TW5ublFJSVdZdTBYaDN0b0I2dm9rYkRlMks4MmJwK2l1NDBiUVZaSk9wUDZk?= =?utf-8?B?QlhCdTE4UzM3VHZNUm9QMGlJL3pNS1haWVlBcFBJQURqaGp6VWpCcXBDdWhJ?= =?utf-8?B?K0FTejRETWxKaUVNWUlUYXFBMERRQk5IbUlYR3BUenAxQkduK3g0cUhUTVZ0?= =?utf-8?B?ODlya2xyeG9hTnpzdTNUTXFCT2N0dUw5Rm5zOW1iVUxHbFFQYVhQTTdIc0Rx?= =?utf-8?B?RWhCZHM5bVdsODVSSmFvQXZQeTNLNW5QeDkraEhzUDJ1RTVJc2xoWW1vQi9H?= =?utf-8?B?UW05amV3RjQvU2lOK2p3NThIdzhZSlV4S3F0bGlXbDhzVHdGZVA1RFFTWTdI?= =?utf-8?B?T1J2aGJWRTA2N2JsN1BmVDM4YW5mUXgyZ0FwUlpQUVRqMTA2bGVaTUFQYmRh?= =?utf-8?B?QUpaMkV6Skl1T2c1MHAvWmJmQWZRLzVVaUd5S1pSay9CVTNNL0dKRkNNWjd5?= =?utf-8?B?NFcwSmVxRjZBR2kxbXZoL1NyOHMyRzFkQ0NjYzdJcmo0ZjFSdC9VdDJLQXhU?= =?utf-8?B?YWxwTVVkQkZ2bWNqQ3RBaHFxVXdDYkFrL21Na0E5OTlrMzROdHdpKzZvTzdv?= =?utf-8?B?elU0NW1XbmpzWTFYYkYySXJCYmFoamxaeEk1UHpJazk5TXhYODNIeXp6c1ow?= =?utf-8?B?V3Y2RGNZSjQ3dVNWTTc1TzFtdlpwL0hXQktEbkRkQXVIRnQ3c0VOSStQcUFG?= =?utf-8?B?TUZHMFl1dXJvN2IvWXh0U3BZSmd3dURPMWpGVXFHeWYwTlRuTCswS2pCV1lz?= =?utf-8?Q?QvuJn5B/4vKQpVnP2VD2VR+rQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 956105b1-fd0e-4a43-154a-08db4d2f009d X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 06:07:27.5177 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: n37W+M8SQhaEEczschCbxg/QHXXCScO20OHlbwkBBqAvDoj8oIAZSq6qsUK/gAyWYX9dSe0q5wBWjhGs/Ra9AA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8145 On 04.05.2023 19:24, Andrew Cooper wrote: > On 04/05/2023 5:16 pm, Jan Beulich wrote: >> Presumably by copy-and-paste we've accumulated a number of instances of >> $(@D)/$(@F), which really is nothing else than $@. The split form only >> needs using when we want to e.g. insert a leading . at the beginning of >> the file name portion of the full name. > > From the Kbuild work, we have $(dot-target) now which is marginally more > legible than $(@D)/.$(@F), and we ought to use it consistently. Oh, right - let me make yet another patch on top. >> Signed-off-by: Jan Beulich > > Acked-by: Andrew Cooper , although ... Thanks. >> --- a/xen/arch/arm/Makefile >> +++ b/xen/arch/arm/Makefile >> @@ -104,9 +104,9 @@ $(TARGET)-syms: $(objtree)/prelink.o $(o >> $(MAKE) $(build)=$(@D) $(@D)/.$(@F).1.o >> $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ >> $(@D)/.$(@F).1.o -o $@ >> - $(NM) -pa --format=sysv $(@D)/$(@F) \ >> + $(NM) -pa --format=sysv $@ \ >> | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ >> - >$(@D)/$(@F).map >> + >$@.map > > ... any chance we can get a space between > and $ like we do almost > everywhere else? Since "almost everywhere else" wasn't quite right for xen/arch/*/Makefile I was first inclined to say no, but I can easily insert blanks when doing the $(dot-target) conversion as well, and then it looks like it'll end up fully consistent (in this one regard). Jan From xen-devel-bounces@lists.xenproject.org Fri May 05 06:19:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 06:19:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530225.825693 (Exim 4.92) (envelope-from ) id 1puon9-0003bF-4y; Fri, 05 May 2023 06:19:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530225.825693; Fri, 05 May 2023 06:19:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puon9-0003b8-27; Fri, 05 May 2023 06:19:43 +0000 Received: by outflank-mailman (input) for mailman id 530225; Fri, 05 May 2023 06:19:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puon8-0003b2-2p for xen-devel@lists.xen.org; Fri, 05 May 2023 06:19:42 +0000 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [2607:f8b0:4864:20::434]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cfddd581-eb0c-11ed-8611-37d641c3527e; Fri, 05 May 2023 08:19:39 +0200 (CEST) Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-64115eef620so17409889b3a.1 for ; Thu, 04 May 2023 23:19:38 -0700 (PDT) Received: from localhost ([122.172.85.8]) by smtp.gmail.com with ESMTPSA id x3-20020a17090a530300b0024bb36e6f56sm4246058pjh.16.2023.05.04.23.19.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 May 2023 23:19:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cfddd581-eb0c-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683267577; x=1685859577; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IhIxM6lGctKPZ0F4zj+ieY/NuAoHjD/llTiAiBzpgD4=; b=ENw0Ibe1GKhNMaBt5lpUTsl73D2uA6Mt5GHElRwdD7t1vn5sOz63TFt6LuUvTVvSRr RNPKxN0sSsgXZyZlZ5Af6I5+9YQlZFMVtDBa8y2RlY+m9oY9D2CB6iEGYnyxJue71Ebe jhIaDXePlaJhp007drvlVLIg7YroOxTsZfRdX9beoSZ6q8NBkbK+Ttvw7Hb9zkEG532G JU96QRickeXpswwKUAfugqXyoB9F18S6bbROrHBR+MAqUvhKLVm2p3x6p9qS6d2ACpCF eIUaieQFbcBIeuDl1C1ZvfI43YuMnCI3sP5W8a3zexCzN0XDCZcDZdfPalTnWWjXtVl2 Ac+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683267577; x=1685859577; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IhIxM6lGctKPZ0F4zj+ieY/NuAoHjD/llTiAiBzpgD4=; b=hmsWK94zNCydFEQ0U94gPTbClxX0OJ/SQ3QySpsA7XYPypjoTx9sftPiH7Equvigrd xIUflsWmUblU3FUSxU0frbisy7wX86lhO4GY7YtRvge8+TmBOEVRRzgd9ZvejN3i7DOc Cdwk5Esy4IsYiHEgWoFzftwy/6K7FTIBka8dvnw3iiOkbHQFPqQYcUhOd1PdnDpMfVKF eihxeCVylUIDeB7jnobpGdWKzBrlmp1g0uCWs6wxbJo3euByLx5v/Q2FSbvyU4QQqcRy /MW6CuSgexDrs+CirKblLjRYnklzupWQFyx+f4yXReaKhWl/Fe774wXyq29AetAnB0us 2l8w== X-Gm-Message-State: AC+VfDxt2li63SwIujH91ZxFNyxy9ypLLbvmZ53Wct0+ZMls+HI3yHqH 3eJy4gSVauc/aX3cHT0v1f8kgQ== X-Google-Smtp-Source: ACHHUZ7cdJ6d3QPoYAfskqtSPYVFeVoAqdh36Km+QYP02oUcudO5EtXRgvhgZ1XZ4ZBkMDLqNrapbA== X-Received: by 2002:a17:90a:9f87:b0:24e:201e:dcbd with SMTP id o7-20020a17090a9f8700b0024e201edcbdmr692274pjp.21.1683267577176; Thu, 04 May 2023 23:19:37 -0700 (PDT) Date: Fri, 5 May 2023 11:49:34 +0530 From: Viresh Kumar To: Oleksandr Tyshchenko Cc: Vincent Guittot , xen-devel@lists.xen.org, stratos-dev@op-lists.linaro.org, Juergen Gross , Julien Grall , Alex =?utf-8?Q?Benn=C3=A9e?= , Anthony PERARD , Mathieu Poirier , Erik Schilling Subject: Re: [PATCH] libxl: arm: Allow grant mappings for backends running on Dom0 Message-ID: <20230505061934.jm3bwjgsl5hf5rns@vireshk-i7> References: <817f0320316dd144826add0ac834618026b91160.1680165772.git.viresh.kumar@linaro.org> <25fb2b71-b663-b712-01cd-5c75aa4ccf9b@gmail.com> <20230404234228.vghxrrj6auy7zw4c@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230404234228.vghxrrj6auy7zw4c@vireshk-i7> On 05-04-23, 05:12, Viresh Kumar wrote: > On 04-04-23, 21:16, Oleksandr Tyshchenko wrote: > > ok, probably makes sense > > While testing both foreign and grant mappings I stumbled upon another > related problem. How do I control the creation of iommu node from > guest configuration file, irrespective of the domain backend is > running at ? This is what we have right now: > > - always create iommu nodes if backend-dom != 0 > - always create iommu nodes if forced_grant == 1 > > what I need to cover is > - don't create iommu nodes irrespective of the domain > > This is required if you want to test both foreign and grant memory > allocations, with different guests kernels. i.e. one guest kernel for > device with grant mappings and another guest for device with foreign > mappings. There is no way, that I know of, to disable the creation of > iommu nodes. Of course we would want to use the same images for kernel > and other stuff, so this needs to be controlled from guest > configuration file. Any input on this please ? -- viresh From xen-devel-bounces@lists.xenproject.org Fri May 05 06:20:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 06:20:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530228.825703 (Exim 4.92) (envelope-from ) id 1puoo8-0004xP-FL; Fri, 05 May 2023 06:20:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530228.825703; Fri, 05 May 2023 06:20:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puoo8-0004xI-Bx; Fri, 05 May 2023 06:20:44 +0000 Received: by outflank-mailman (input) for mailman id 530228; Fri, 05 May 2023 06:20:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puoo6-0004x8-SB for xen-devel@lists.xenproject.org; Fri, 05 May 2023 06:20:42 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2042.outbound.protection.outlook.com [40.107.7.42]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f53ffeab-eb0c-11ed-8611-37d641c3527e; Fri, 05 May 2023 08:20:40 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by VI1PR04MB9834.eurprd04.prod.outlook.com (2603:10a6:800:1d8::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Fri, 5 May 2023 06:20:10 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%7]) with mapi id 15.20.6363.027; Fri, 5 May 2023 06:20:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f53ffeab-eb0c-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iW+9YASDFAiHQ1cOYC1L31SClQjeEEcHNqOoJxh6jz1k3MG++Ebd9T++0AjmQR2UZLIHVY4IAbgXUPg52ZYqv9qTwVg6TRXe6/NOR8+4touxdF8DMPGXhoZMvlJPWB3qiPoByjREkW4RJgAXaRtxHG8LErR182UFgsTg//sjTx2esS3VL3/bMToyxOhi30xXOLWynhXHBUuEs+3RRggWsBJKXZz8iPLQbqJUd+Aj8AVV8Icf78UFQuYrq57137zoOSo7qeUnib7gipOr38We+gHWf3lr+Tkxr82pBLTyiJFrziI+7h1iEGa1WBiaAT3ydwSfWbzqKyvkqWPz3ndgEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l2XOraMKft/weyDy7v9639q6Tj2Q7kLZesPrPA1WRv8=; b=ex9g4BPHRtCAg5ZuhVbI3+GA8traZN9pMW9OT9Fih9VIQTInrjJVYsBx59Q2/XyaQCFl5pYxr9JaFAKxat3iIpjY2dkVXx6ahPxiqtVq8LO77jsDlLkrlqrvk5nI16Cz+AY/PLv954790KK+jGqo33pbIk87t3Ewo5b8BnajMuEidEOacR/GwUVuVLvd7CNG/P7UZu7QTQgMVR8dR71LXyrdPPWfHK1xsc36A2D3NFv7EHxjIEZTPDUq8n/1VnpxbgGejNBSHGG1I1omUHkD3Q5iIAEzfBA21pbuia7k5Cupm1MkOQFUABCLNpJ4Y3ZmQjgSBZMge62TUaDJRkIaXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l2XOraMKft/weyDy7v9639q6Tj2Q7kLZesPrPA1WRv8=; b=RzBppbgDs9KQXENfkvt191B7awboU34hgpn21a/HUwMHXZw36yi87/NeJwBHweSrF5bR70jT4XiyBDfCBfqqnWeWvM09cqfGyXThIszOaDKu17/QCZzw+EqnM0DMmUJ0trOLWhClIwCOGLgaHYLybS5SFIYp4/ZFwKVlucI3Fq2nb/cJbNlEvBGwuvf+ZJwhyUJg6POGKxjXxWvj+rN2BHOC9dSODicTR4Z0Bi7FM2HURQY4td8cCRjKdw7yvn8gKVRwAvpd7KyX0m1PiE0pKuikBJyQxzYn73wQxi97H9Y0/F1YvUtBqCeVH5wj54uke7vJpfh3T9Yz3mWB6YAcnA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <39f9548b-6a07-3d74-1975-8f17153f2d14@suse.com> Date: Fri, 5 May 2023 08:20:08 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v1 3/6] iommu/arm: Introduce iommu_add_dt_pci_device API Content-Language: en-US To: Stewart Hildebrand Cc: Oleksandr Tyshchenko , Stefano Stabellini , Julien Grall , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20230501200305.168058-1-stewart.hildebrand@amd.com> <20230501200305.168058-4-stewart.hildebrand@amd.com> <0e7404fe-e249-7b3f-0628-b8b8b1925765@suse.com> <6758ef37-bf66-99c3-1fd4-f2edfc12513a@amd.com> From: Jan Beulich In-Reply-To: <6758ef37-bf66-99c3-1fd4-f2edfc12513a@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0181.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9f::17) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|VI1PR04MB9834:EE_ X-MS-Office365-Filtering-Correlation-Id: 815c48f5-8092-4c98-9a5a-08db4d30c746 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P7khCtcfZuGVtTda07iRio+rgWc+4Non8tGRfMDNUe+cDXWyFQ2i/PBbZwR9M4YWy4A6FxjI5PiiExyY2fbklGVo2TsJ4cOOHTDFBbEYx0AoGJqIKJyBXHdfqcUPYQxOJSqa2ST+xpiAfOVn5yN6JKN5DjA4ZGbMmJ4EjjxMp9XVXsLzqlZ4QBv1Fq/YiPNv0r9wPK67lEgY8XmaomBy5Eb1jrAuELv60mDq4pLYzFrlBtdeVz+2lN84bW8FxP8He/SmrNJYP1QZnJIhYwP175CMFKTOV+wUH68fgMWTJEvuVgMm1O25qhwbgY6Xc5qCXSZPiGGjkyIzKLC8FTyjRqfN3e3KnB4rIlc6cvX3Cxx/unta6G1b5MQ5jGO6egfSmUAKrN6t8csw9OK92uHMOV5vLnB9NGZjaQSv1n6J3dgb7NH8tA4W3uwhX6Kv4bNmMlO8ABmuW7ZoRWCXKVdxLKorG2CxMXwSWjBTUmarBcemBkGX99oBZ7ZnEkeXOCSyl67CpFkNiH0yAtjStTTeleGGkXHlWjnXNNCWtGr10QMfD+2Ih6os34Fea2PDRXnPBkoy0nZQhtOs3nIVbZRhOrbCYBfLB9+tZNWS71Oo55o72alEU/Xc42UxZnFdER+h0Z+krymly1Tu1fJgE+sQ6A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(39850400004)(136003)(396003)(366004)(346002)(451199021)(5660300002)(8676002)(8936002)(966005)(6486002)(38100700002)(86362001)(26005)(83380400001)(31696002)(2616005)(53546011)(186003)(66556008)(66476007)(2906002)(66946007)(316002)(6916009)(6506007)(6512007)(41300700001)(4326008)(36756003)(54906003)(31686004)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZTZqemxGWk1wcmJod09JZlpKaWhjZXdMUTVZUGRzWktXc1pMRURUZ0paRE1B?= =?utf-8?B?V1pHenRmaEtDa3lESG9IamNQazdFdTRxbUNTbFhMbDI5QVN5RVlienVTdG85?= =?utf-8?B?b1BrOVQ1SWdlS1ZZNng0anBvbzdNeXlHYlA4bmRJeTZpSzhjaDBGWkdMY2c2?= =?utf-8?B?bGR2Q1RaZWwyR05CNlhITEFScENoT3A2aXpjNFFTaDhlNGxmWTVVeHVMckFj?= =?utf-8?B?eFZYblo2UXdMUmFJd1o0ejhqdHB3eUJnK2tEOTNDZjk5WjJBM0tjYjJjbE9C?= =?utf-8?B?eGdxN29jRnVsL053TUMwYVh5dVIxNWV5cFMxY1hWOE5MQzV0RU5qZUltTTdX?= =?utf-8?B?VDYrRUNQNUcvTVZmTDIrcXpyU0ZNdVZtUnhlcjZIMzhJM1FZWnpmSkkwMC9Q?= =?utf-8?B?bHhaZUkrU0pzYVA4cmgvTEhEY3VWOUJkdk52R1hmUFRmVkNnN0ZzbmRZbXds?= =?utf-8?B?T1crMUNCYlg5UFdzL25CcXdHWmFrTFhXY3BrZTVRY3ovb2dCVktxMmx6T0J5?= =?utf-8?B?SWJJdG1idXFod3k2TVhLTzBoVUFEaktla1dCdnVFWW5qQUZYdmdQU3hnV3Qw?= =?utf-8?B?c3MrYlpsWVhJZkxucHFTbzN2bWllOGgzZHp2dUF3ZHVXQ0w0UStiWFFJNVZY?= =?utf-8?B?TUFYNlpQS2hZWDZsenhkVzJudGxOV3RXZ29qQlkyeWRJSVlsdmYzSSt3Qys1?= =?utf-8?B?RnpSUnBLbHdPb0ZtYVNEVFd2L1RYdG5hNzB6UUJQMHNBU3NKL1AyYmNQYWgv?= =?utf-8?B?cjREay9ScXFBVTl0OURkdGdDYnErUTVadUJUQWZna2VrNFJuQVM5ZEE3NTYy?= =?utf-8?B?anRYQWxLQ002YkpkZVBnc3hiSklZVnNCbHBtYzc0a1huRTFlVmJ2anFaMmFu?= =?utf-8?B?cDJoeVNwSUMxa1ZvMDVscWEvaVVFZzh4VDBtTmxXcUpUazlCdGY0OTFIVnhy?= =?utf-8?B?UWNnYkNDb1FOU21USGJ3M0Y3UCt3Ri9BM1g1QlE3a09JKzgreSs3NmcrQThm?= =?utf-8?B?a0E5UllCajRodDBhK3lOam5SWW1KQjFrMkNzTGpySzZsMHgydWd2L0diQVBM?= =?utf-8?B?bGt0Sm45ZEMxWEpRUGJnMVVDbDdyaTNEQnhiamovTnBMT0dETDFzdDRnY1JS?= =?utf-8?B?bEV1QjFhVXR5bzV3alRjcEdkN2N4QTd2M0JaMCtKS1IwR01WcUhnTVVENzVt?= =?utf-8?B?SUN2QysxOGdROHBDRlJCSW1vbEswT0ZUQjk5ejc1K0ZTWk8xOTBtanJPR0NO?= =?utf-8?B?WFVuVEQzN0lIS0g2S1VwcmRpMThTWnYwOWNZc2QyRHlXNTB2Ni9mWDJZWU4x?= =?utf-8?B?RElab0s5eTRLNVlsQzZ3Zkt4R2dZb0RyQzdTelhYRjd1M0tZREsyckF0OXhw?= =?utf-8?B?dEh1cTR4cTdZZWlIOVhvL2dOajQwZTc0ZEgwM2p2cGZsV1Y0aFI4bVFmNjVq?= =?utf-8?B?SzZzQmxWY3pwYlRQeDhnWlJBWllXWUVnRTd6QjU2R2J1cThSZnNEczdUTEky?= =?utf-8?B?L2lUanNmMktJcVBmaUQzMldGdmxBbllObDdnY2ZoTnhjVnBKRmI5K3NLNFJt?= =?utf-8?B?RDVIS3JRWWRsZmJBdGdNVFZSNDl2T2lXaU0zclpXWUE3Ukh4QldJTkM1dFF2?= =?utf-8?B?aVJNc29ZM3VZaXI2cTFDd0pob1VqdU9WTCt4a01XQ3drMU15aGJYS1h3QlBw?= =?utf-8?B?SW1LVExDdEJ6UngyVDJPd2dVb1o1NXpkQmdtK0poSU9rRnRBN3M4dGpad2l1?= =?utf-8?B?cndFWk1IaUNRREd3T3pwUS90UzlZM1loS1RYZXZ1dFJPVEs5bHdtWWlnT0Fv?= =?utf-8?B?UENyc3BRTjJSazlFWG9vak1tOUwvTHlIZHk2Z3N0ekdGV3hmNEtLTElQRDFP?= =?utf-8?B?ZGp4Z2txTS9pOUxES2lZSXJBbzNNeEtLakpTSWtBM2Q1ZHc1ZmFhUkFBQWhX?= =?utf-8?B?dU0yRTEwTFBObXdlQjZkbmZOa2x1cDRtdGd5Zk5tdzNrS2J0ZkptcjNtVW1v?= =?utf-8?B?Z3J5NXc1NEdmQWFLUzRLWTdhdnFsZndhVS9EUHRWRzhJVFRkbjVlVU9QeUgw?= =?utf-8?B?TDh6YWRQT0V1MVlpRTZ4REE4ak9Od2Q3ZVpjNXZVbFNJMzVDZngrQVF3dmd1?= =?utf-8?Q?ZK6oyaiSvOguY5IuH4PBrYWCG?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 815c48f5-8092-4c98-9a5a-08db4d30c746 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 06:20:10.1132 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kg6ep13FrSSBGV2a/3Hp0Z4yJTlIXPxPDQ6g45eMRBCaJgDcA6+nSGH9OtsbD5M4YTi4RE2rUrUK5li14VMDJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB9834 On 04.05.2023 23:54, Stewart Hildebrand wrote: > On 5/2/23 03:44, Jan Beulich wrote: >> On 01.05.2023 22:03, Stewart Hildebrand wrote: >>> @@ -228,6 +229,9 @@ int iommu_release_dt_devices(struct domain *d); >>> * (IOMMU is not enabled/present or device is not connected to it). >>> */ >>> int iommu_add_dt_device(struct dt_device_node *np); >>> +#ifdef CONFIG_HAS_PCI >>> +int iommu_add_dt_pci_device(uint8_t devfn, struct pci_dev *pdev); >>> +#endif >> >> Why the first parameter? Doesn't the 2nd one describe the device in full? > > It's related to phantom device/function handling, although this series unfortunately does not properly handle phantom devices. > >> If this is about phantom devices, then I'd expect the function to take >> care of those (like iommu_add_device() does), rather than its caller. > > In the next patch ("[PATCH v1 4/6] pci/arm: Use iommu_add_dt_pci_device() instead of arch hook"), we will invoke iommu_add_dt_pci_device(devfn, pdev) from iommu_add_device(). Which I think I said there already I consider wrong. > Since iommu_add_device() iterates over the phantom functions, it would be redundant to also have such a loop inside of iommu_add_dt_pci_device(). > > If we are to properly handle phantom devices on ARM, the SMMU drivers (smmu.c/smmu-v3.c) would need some more work. In patches 5/6 and 6/6 in this series, we have: > > if ( devfn != pdev->devfn ) > return -EOPNOTSUPP; > > Also, the ARM SMMU drivers in Xen currently only support a single AXI stream ID per device, so some development would need to occur in order to support phantom devices. > > Should phantom device support be part of this series, or would it be acceptable to introduce phantom device support on ARM as part of a future series? I wouldn't view this as a strict requirement, so long as it is made clear in respective patch descriptions. > Lastly, I'd like to check my understanding since phantom devices are new to me. Here's my understanding: > > A phantom device is a device that advertises itself as single function, but actually has multiple phantom functions. These phantom functions will have unique requestor IDs (RID). The RID is essentially the BDF. To use a phantom device with Xen, we specify the pci-phantom command line option, and we identify phantom devices/functions in code by devfn != pdev->devfn. The command line option is there only to work around errata, i.e. devices behaving as if they had phantom functions without advertising themselves as such. See our use of PCI_EXP_DEVCAP_PHANTOM. As you can see, this being PCIe only, and legacy PCI device bevaing this way would require use of the command line option. > On ARM, we need to map/translate a BDF to an AXI stream ID in order for the SMMU to identify the device and apply translation. That BDF -> stream ID mapping is defined by the iommu-map/iommu-map-mask property in the device tree [1]. The BDF -> AXI stream ID mapping in DT could allow phantom devices (i.e. devices with phantom functions) to use different stream IDs based on the (phantom) function. > > So, in theory, on ARM, there is a possibility we may have a device that advertises itself as single function, but will issue AXI transactions with multiple different AXI stream IDs due to phantom functions. In this case, we will want each AXI stream ID to be programmed into the SMMU to avoid SMMU faults. Right, which of course first requires that you know the mapping between these IDs. Jan > Please correct me if I've misunderstood anything. > > [1] https://www.kernel.org/doc/Documentation/devicetree/bindings/pci/pci-iommu.txt From xen-devel-bounces@lists.xenproject.org Fri May 05 06:34:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 06:34:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530233.825713 (Exim 4.92) (envelope-from ) id 1pup19-0006b4-Ol; Fri, 05 May 2023 06:34:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530233.825713; Fri, 05 May 2023 06:34:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pup19-0006ax-M5; Fri, 05 May 2023 06:34:11 +0000 Received: by outflank-mailman (input) for mailman id 530233; Fri, 05 May 2023 06:34:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pup18-0006ar-5h for xen-devel@lists.xenproject.org; Fri, 05 May 2023 06:34:10 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2060e.outbound.protection.outlook.com [2a01:111:f400:7d00::60e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d65547c9-eb0e-11ed-8611-37d641c3527e; Fri, 05 May 2023 08:34:08 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by PA4PR04MB7933.eurprd04.prod.outlook.com (2603:10a6:102:b9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.27; Fri, 5 May 2023 06:34:05 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%7]) with mapi id 15.20.6363.027; Fri, 5 May 2023 06:34:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d65547c9-eb0e-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nyDMFero+j4xtOww9ukoRCDxK4qNarntpDODw0WM69xzK5d0ZLx5YtKWWkSoRETWPBPIz09bbchIg8cTJfq4uhpx8EHLwHrqx+Ddr9caESB8PhcrlubU0Lcas2R7FCc5X+eGpw7r1gl+cGX8ZxxFz95sVf3XrSkGm3B93ck0Zbvsh8yHAAlcrC83h++N79Gc6Optv1obEF2937WU8Z/m5uYWR29Q5CI0hMaiCk+EY9Etk9ZDN+UgGjcU4Wo7RgcTltQsJY/GR4eVJXzaF4vjcthevCOixagkrsPCdaRA9UJma2xF8We2cQZONtSfPpU3LDHVqImXXC1fEgJOJYYeQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IZxrcutvyKcp2criGjoajIUaUNjslOaTNy/anR2x1vY=; b=iLtAFIF0UqGThyy7/mcbanun0PlQf3jWwbYkcK+gdW5nKMNiuDOZSXxtrUuYnOZnh6eVvzIrVBsVgQ0Gf3LqX5+Iie2W3ey3IpT4fMTuYThGxUZIcTaYUpMMX1zOt1jNxCMuFSFOqHxNKxLtp7dm18ce6MPXr7mtyRlcDd8w1jy0obgjt8q9rZjYZmTajZcyfxh92Lzy0zuxukKa51hqMR+x8CVYcXmPBULJIhKzKBPS/YNfVI/VctOuspxrvfNRmaGa7nTxmGWhwx335i/u2MleS33OZv5/82PmviacHRsN2yj5xTtxegCMD09hI1GiJNtIgBd9YDMRWI2JnnJdow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IZxrcutvyKcp2criGjoajIUaUNjslOaTNy/anR2x1vY=; b=1bWPvwUIqNs5ue1sip3DpwajGquDg3zQ78R15qF9XeZ5b0wuw6I95JDNp0tVVNKurVJ27/LGsSoiiSMn2VaI5w8WTU5zZpdHeEQjqyv4zynhxlnxiwStjt2x57QrDE8a0tVu6Q2Qx8k49xUAgM9ZUxwenHzC+KQ7aUkL/TDATmJVQxeHYrqThShKLoPNMtoltIBjdkdGp4Koi308oZ0WlNp5imLMN+CR6GbTpcFVUNEQ+uOXgDwQrkgAemscTziYxIa69ZLfI45L5i4yndiUshFpWdyAljzWa+U98kxo4GeDL87FjwrEtsnhiE6t2eQZ3wwI2IpxdofoUul77iJ1Lw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 5 May 2023 08:34:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v4 1/2] acpi: Make TPM version configurable. Content-Language: en-US To: Jennifer Herbert Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jason Andryuk , Xen-devel References: <20230504175146.208936-1-jennifer.herbert@citrix.com> <20230504175146.208936-2-jennifer.herbert@citrix.com> From: Jan Beulich In-Reply-To: <20230504175146.208936-2-jennifer.herbert@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0090.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9b::8) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|PA4PR04MB7933:EE_ X-MS-Office365-Filtering-Correlation-Id: 0380a7f9-1c86-4e4a-b956-08db4d32b8ba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lsh9PRYR1wB2b4MjD+6FS18SN7Hosz/E1yjpEL7WXSBSytQn46BaD6ChMLXGhonoTf4MlkssAJZhcpYQhAyaBXRLuByH4PzXUuUOvT6BEjYfzwbEX+VL7riF37vqVbq+Hy7KYs33RnthsF2gTitqw9h2YeB8MWks07op+mTpzZaXtGjzR/if3THAFOoVPQ5GX5+yfwJwM7X2R2iz39k+qcTlIe0d72iDTgwEAfTbyF9gBELG2n8O9qsgc9+w/7HmQDuqoU0YJ/yNEzC4iZ3SDjHIeE3cTWw02ot5ZfbO3MCs3Fz3dYV5YZ0PTOjvmGl3Kbi8Ig703D/B6AgQrnDcXBTA6EazAC/zBNucN/BXeqvLj3OpJhwucMJejWk+12ekyKXbIBlfs4deQh/eNxntA590/OEhf77p9vASFTc4vTNmmFwn+x2afTl2RzN3aJzZPoG3p9iXNTXAgje9vCDi8eXaKGsTJex6MyAszNisboufFM3zCYdl86jZL8AD/0pPjjWmfTHUEToe/y9OmTwbpP+tqIGS7yydaTXxYMT+kokB010yky7+q8bNzTDfhTwS2TlKLldUJLQN265n3XhJEgxsFDR5RcOQ5ek3dYdmQT27S8AdoZ7flBrrKKiNswOjdzvInL9f6aEVsvSnrMKTbw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(376002)(39860400002)(366004)(396003)(346002)(451199021)(31696002)(6486002)(86362001)(36756003)(54906003)(316002)(66556008)(66476007)(6916009)(4326008)(66946007)(478600001)(41300700001)(8936002)(5660300002)(8676002)(2906002)(38100700002)(186003)(2616005)(26005)(53546011)(6506007)(6512007)(83380400001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T2JPOTkrUTBMU2REUnM3MVJCd0I5bmlWUUhJYktpRVJ3VGJjT1d1V3Z0cUY1?= =?utf-8?B?T0p2elNORm1RS2NtZnNNNytSNTU2NFNpVXBUSUQ0UTJJaVhTTUFxYjNWbVJO?= =?utf-8?B?MDBoYk4zSVJqcUFPODdTT2RmZUx1K0FKdmEwVWtRM2JRT2JyWFl0MkZmREF4?= =?utf-8?B?eWU2TVh3T0JiMlpNN3hqaWR2dU51RWgzcndxZkdQaUN0UHVESmtBaTBiY2VX?= =?utf-8?B?dGZOZzVDSHlCR3VwbU5vak03cDdlbzlWaklHMkliWmh3R2cwdXB2SGttT29J?= =?utf-8?B?eGxMYlJtZXBsemdoSWUzbGY3UndiZ2lKRDBwb2VDZFZOSG9tZzNLSUtUbk1Q?= =?utf-8?B?VThuVzg1T09Lcjk5dFQ4eEc4b2pnV2J5RnJoRVFUR1BhSTBzNDhmWmZBaytQ?= =?utf-8?B?bU03aTFkbXJ1QU4vNGhHKzNGbGJrS0QvczJMclNUNisvSHpFZ1BJRk85T1VQ?= =?utf-8?B?MmJvNkxzMkJWUzJkS0tGK3hzZ1M4azFJV2ZialFkdHhCQ3lNWWdxSitsV1Fn?= =?utf-8?B?WEQvVmJ6eVlwKzYrbWhoVFFHejhESHM3UkU1YldWd3VqSytiT08yWU9Sb1M3?= =?utf-8?B?dHRjSy96UXpDcG1ZTlNqTlg1MTNGQ2paVUFUZ3ZBd3k0Vlltb2gzOHhJZTUx?= =?utf-8?B?Q1JWejdhelVpMDlhSTVhd2tST2tqUXBvSlVETjdlYnZsc3hmSmZXMFFHTEdp?= =?utf-8?B?cVpNdDhJWWdUZlV5Y2dxc2FKTVhwa0FRUGEyS1AwMFVEbEJSUVRCYVhZbllx?= =?utf-8?B?U2NrVzEyeTdlOTFrUXNnOElWNWRpaTVtc0xWT3BjQ21uV2ZpbXI1NDJkcEVl?= =?utf-8?B?R1AySHpQeHVQemNxY2w0N2JaTU9RSm43bnZnc01STUZqMTFrakpVRnA0K21x?= =?utf-8?B?eHBwWjBvQWZXQ0JNTmxrMTNpd1BBb2NwcXVaQnZOckF6c0YxcjFOWDVkdW1j?= =?utf-8?B?WGtqRjc0bi9ZUXdWblIyVDRWQk9TRlhPUVd4Kzk4Wm90SnVXUXpaK0VlWGRO?= =?utf-8?B?L0hRMlFVN3BnMzIxQndiOHFaRFFkN2ExaGZUUWYxUGVWSklaSGNjL1NjN01o?= =?utf-8?B?ajh1TEhkaUJhZXg3d0RjZldpaDU2WDkwb1dUZlhhNHNMWUt3SDFuSEJJMGJV?= =?utf-8?B?a1prN0VuaXZWTE0zeGJkL0l2R0hwQnN4bjJIY1Y2QkkxZVFxckJMZFdpVmFT?= =?utf-8?B?Szk4ai9MUnR6MEU2QWxoTFBld3lpYlZyUlF5SjVJUEx2aU81TkhkbmVqS01p?= =?utf-8?B?N2hScERVM3l2RXhyVldEa0RTbGRZMDYraHZwaDIvZ0FiYkQxK0MvS0gzZlU5?= =?utf-8?B?Sm9qMDdiZFRnbnJqaTJsbnpZaUY1WWNPdzM1UVNFSXcwU1V4alYyckhDK0Y0?= =?utf-8?B?VWNDN1c3eTdpQkc1NjFuQlJJSkdtMVdmZDBtdEt4cE85UG5uVzB3b0p5VVFV?= =?utf-8?B?eTNrN2Q5Rnczck4zM2NhNzZLL1FPd1cwVzNEanRYWit5QW1JQlAwVk5BZVdZ?= =?utf-8?B?aHBpZ1VmUVRPUG5qaXBMWXJJcENJTGlGaTRqMlorM0tZeWlWSmhFaVdUY2RV?= =?utf-8?B?UCs3MDA3aWVEdWxzeGhTZWxkbGtpbFFBNlZscm9meE1MZFUxZGhVRldjTSt4?= =?utf-8?B?VGV3N3JvVG1XNzVISGJJN0Jia1VteUJVS25DOXM4cjN0L3NIZkErYnA2Q0I1?= =?utf-8?B?RnBMZys5ajVETGJMWVJtZEFEK1VVazlLNmllNzFDS0ZhQmZYMnI0eWJFczRs?= =?utf-8?B?TTlhRlhTSlVIUU8xVUFJMHpPZWVUaGk2WVZxVVA5NHg4M1VYdmx3WnBpUHNn?= =?utf-8?B?R3dPN2MzR0JRaWdRd203dCszRkc1YXpSbmF0UEFueks3bWVaY2gxWnhjdUtw?= =?utf-8?B?Si9JTXhNdi9HSitrMDQ3dTRQTHhKMXA0OUxVa0VkV0hkVUN2QVZzakhLbFFy?= =?utf-8?B?S2VranJXQzVaYWNyTm4vWi82OTJFUzVFbjNaTnc0RUJZUktzUllOOHVDL3VY?= =?utf-8?B?VURlVUN2dEU1bkc4cFFjZkZLV1dhaFoyR05KUDVvb1plQ1p5U21Va3FrRmNi?= =?utf-8?B?UkdSOWN2dlJyeHRNaUlyTHR0NTNyeFluMkROYU5nTVJqRVczZExwMUxxM3lY?= =?utf-8?Q?cuD0W8tdhVikA3jbGrcItqJPe?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0380a7f9-1c86-4e4a-b956-08db4d32b8ba X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 06:34:04.8055 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9JwNRcXF+jq12C3R8ZapxPB/PS4RPLvSfecmoy9vIenaPF4o3PSfOkjzwoSHgRbx8fNfwJSa07d3y5+EYSrHxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7933 On 04.05.2023 19:51, Jennifer Herbert wrote: > This patch makes the TPM version, for which the ACPI library probes, configurable. > If acpi_config.tpm_verison is set to 1, it indicates that 1.2 (TCPA) should be probed. > I have also added to hvmloader an option to allow setting this new config, which can > be triggered by setting the platform/tpm_verion xenstore key. > > Signed-off-by: Jennifer Herbert > Reviewed-by: Jason Andryuk Acked-by: Jan Beulich albeit with two minor further request (which I'd be happy to make while committing): > --- a/tools/firmware/hvmloader/util.c > +++ b/tools/firmware/hvmloader/util.c > @@ -920,6 +920,8 @@ void hvmloader_acpi_build_tables(struct acpi_config *config, > { > const char *s; > struct acpi_ctxt ctxt; > + long long tpm_version = 0; I don't see the need for an initializer here. > @@ -967,8 +969,6 @@ void hvmloader_acpi_build_tables(struct acpi_config *config, > s = xenstore_read("platform/generation-id", "0:0"); > if ( s ) > { > - char *end; > - > config->vm_gid[0] = strtoll(s, &end, 0); > config->vm_gid[1] = 0; > if ( end && end[0] == ':' ) While there is a similarly odd pattern here, ... > @@ -994,13 +994,27 @@ void hvmloader_acpi_build_tables(struct acpi_config *config, > if ( !strncmp(xenstore_read("platform/acpi_laptop_slate", "0"), "1", 1) ) > config->table_flags |= ACPI_HAS_SSDT_LAPTOP_SLATE; > > - config->table_flags |= (ACPI_HAS_TCPA | ACPI_HAS_IOAPIC | > - ACPI_HAS_WAET | ACPI_HAS_PMTIMER | > - ACPI_HAS_BUTTONS | ACPI_HAS_VGA | > - ACPI_HAS_8042 | ACPI_HAS_CMOS_RTC); > + config->table_flags |= (ACPI_HAS_IOAPIC | ACPI_HAS_WAET | > + ACPI_HAS_PMTIMER | ACPI_HAS_BUTTONS | > + ACPI_HAS_VGA | ACPI_HAS_8042 | > + ACPI_HAS_CMOS_RTC); > config->acpi_revision = 4; > > - config->tis_hdr = (uint16_t *)ACPI_TIS_HDR_ADDRESS; > + config->tpm_version = 0; > + s = xenstore_read("platform/tpm_version", "1"); > + tpm_version = strtoll(s, &end, 0); > + > + if ( end && end[0] == '\0' ) ... I don't think it should be further propagated. There's no need for the left hand part of the condition. Jan From xen-devel-bounces@lists.xenproject.org Fri May 05 07:01:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 07:01:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530236.825723 (Exim 4.92) (envelope-from ) id 1pupRZ-0001mr-SW; Fri, 05 May 2023 07:01:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530236.825723; Fri, 05 May 2023 07:01:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pupRZ-0001mk-Ph; Fri, 05 May 2023 07:01:29 +0000 Received: by outflank-mailman (input) for mailman id 530236; Fri, 05 May 2023 07:01:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pupRY-0001md-I8 for xen-devel@lists.xenproject.org; Fri, 05 May 2023 07:01:28 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20619.outbound.protection.outlook.com [2a01:111:f400:7d00::619]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a6c9b49d-eb12-11ed-b226-6b7b168915f2; Fri, 05 May 2023 09:01:26 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by PAWPR04MB9744.eurprd04.prod.outlook.com (2603:10a6:102:383::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.21; Fri, 5 May 2023 07:01:23 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%7]) with mapi id 15.20.6363.027; Fri, 5 May 2023 07:01:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a6c9b49d-eb12-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dGTTk7dAmbA7yDjmZxie2UWRpiddIQRcyd1hM5q5LDhDTd8Buecs31o0zTFqgFmAKsgrxNKFU1BQxXsn2R1X5SZ5QxaRbtZybwpaajhm+Yuwb+ezg2g9fhREZLX7rmwBjCZikOif/QMi39fKOCLpm7oRVKZEwoemLiweV3WDERHoLBKF+VtueVjpxa7ctJyrhU4F5JVSszZGl6vnJDW4jqvSvQol8O1fGMbSZS+e57OMz5/BIRDlrmePxm0DKfeTaKNdpINiCwBmTbE3S01xEb5u6krtCCYq3iauKosGvIv1wjszeMYhPbHpAatYiDFhDR9AKFF6ATDM6vGJwE+3CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fgP644fB4vQGDoxQzCaXmXM8Dvzoplud5+uNJrnPxAM=; b=MJnXEs6Bs09sbi6ZRm93LO/eiNTB3R4bL8smWQvG+tTP/Oi44J7x2d7XXme87mRaSQW0oY4BIprB9AQwqlPeySjKx4NQ/1w3/Cvzc/qgtYVZRoBf6MTV4iQULgpsgVtv4A+OhWntELRJ8gMZgnLkSX/IeiMp4kUUl4opHTkrvgvrs09HtMFKr7SwE3pXnqDwCgDXyaF535hGwGxS7/RRG+QAGzJRhQx51MpX9NnVVrtyYf1/PslXsfxhDW5c9CzzFe3sLUdK8mhqAORS6vvfQQIztB+n7oxcgb6PEov72KXh1EiYhRBExHZnbT0ztjfA2Jb/d51qn5v5YejXVtPuXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fgP644fB4vQGDoxQzCaXmXM8Dvzoplud5+uNJrnPxAM=; b=n1vBKnr64oUrQuwADTAKxY0FOemGeECZ0dCwWaLX+HrCFacSQ4I3l9IjZ5ZBoSEL0gZYqHNblN4j4Ax3DXpTCow0NCWGOOihWDMKCFwEL6kJmfZvqyruNgbBzGJbDSh03i7/3+8je41PkoZarXIVzafOT0QW9f+hK+Fh5NA7HXgFsWCYSpEAY/5Zo8QNMjK12eOz+ktrVrvBSJ+uD78fnpZX5bk0myWivhjV574rDNHm3WXX9gfZwLyAQkEjqRoiCRaRKnUfktEB6QE7h2vugfRfJo691YfOmIwnIBI+UPezTdUncnASCTjKayt3flTkNrAcPugW3U1ZqBFApXIpIA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7921d24d-7d4d-8829-44bf-b8c2ecd001c8@suse.com> Date: Fri, 5 May 2023 09:01:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3 04/14 RESEND] cpufreq: Add Hardware P-State (HWP) driver Content-Language: en-US To: Jason Andryuk Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20230501193034.88575-1-jandryuk@gmail.com> <20230501193034.88575-5-jandryuk@gmail.com> <43c519f7-577d-f657-a4b1-1a31bf7f093a@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0169.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:99::10) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|PAWPR04MB9744:EE_ X-MS-Office365-Filtering-Correlation-Id: f51735bd-96b2-46ea-5470-08db4d36893e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wImjxmVGKfJiO4dA0/jq1lkNIZKtYTyc55znVYGDc2hucEWorMPg1KPda9nG5W2PEOsMTAjWtonQk3R7NIOGThVJapkAtW2hg63iwQrbWoQopTTl3bZIVlIvEgVZYijTDkRRPJ7w3g/gmUUA/HNX2jwLZU5BzCH2OGMQR+xQj+3fC6/X0Hvye0cjh0DUsGsfKkpi6t87s5o1gMNQkLWbRYZD7zxXo5FEMgSUNsqaGy/9CSsOyud1hTRnUmPkxlrgRawartQMYX9CB6xBNtXVCnfTg86NtIkq7wZR6f8PULAqWvlnRMyXOY+eADZoAbwjLPnlye1IVzHitAuWpmVOQiNkYEqlMxA385lmNUVk4s02MbYHR0h2EViH+EQdYXZmD0Zx4swfFiMjIQTMNfGQlnyGS4COHiLKMVFYbAUP9exTK7d5rW+dboo2MfRpZOTRpiqMyu3VlcUHQkIvC2qTLGqCHWQ3sqZRzgRBAmRFNJfkQ2aqTx91cGjrBuHfBgx0fqZKFbpHS9x1oPciVvYD08F1V07uZ6X2gzjXdQa+Ds5nkkceEHdIxYY4kLls2hq3fRdu9Czctt9SiFJiWOaBqudAnE7X4hzm8RIYxI/uqJkpwnq+Ww9em2dF2Yw8L0Ovuvvn7aJVfzT6hRF9rWjTSQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(39860400002)(366004)(396003)(376002)(136003)(451199021)(186003)(2616005)(6916009)(6506007)(6486002)(478600001)(30864003)(41300700001)(26005)(53546011)(6512007)(54906003)(83380400001)(2906002)(36756003)(38100700002)(5660300002)(66476007)(66946007)(66556008)(4326008)(8936002)(31696002)(8676002)(316002)(86362001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ekhQdFYyOC9nMEhyY0VWRmZmY1pMNnlHV1Z5OG1GWWxKZnovVU50Z0U3bmVi?= =?utf-8?B?QWVqbytiYjFFaXZTcUxaeVYrNFM5Vk1sWWlIOFZzN091N25mMWowMWY1ZG5S?= =?utf-8?B?QnhmT1REQnVaK2dqTmVTOE9DR2hLdUJuQmViVW9XaU0yb1QvVjBUZWRBVmNL?= =?utf-8?B?MWtWQ2M2eC9qTFowS1FZM1dTSS9CbUIxQ1JXeTk4Qkw3TTlIUGZsQVJxRG5k?= =?utf-8?B?Ykt0MDVzeWVnQ0oyR0dDbUl4ZEdBMkh4MmMyMEg3MEJMbCszQlRjSzllV0Zy?= =?utf-8?B?bVZHTkV5TUdVUWJHY1VwVmltRGFTaHVTV2RUcjBqNm1IWkF2WU9UVXpSTWpl?= =?utf-8?B?d3RQWk83TUxjZnlhUndtUVVTY0I0MXlRQ2drWTZVL2F1dXRiUzA3SzdYME5U?= =?utf-8?B?TXN3MGMybEtremx2b3JtNDhvL0ltYlQ3bEhxOS82TUpzWXFXQXU1ckpIN1N5?= =?utf-8?B?MVRnSkRJTVpxRFppODJ0bVNWTGUycnZBWW9iZ0pyS3FlOW15NFNOTE4rWFBD?= =?utf-8?B?SjZ0RTVPYmZWaThuUXh4b21hU1FUWUwrdFN0K1hzekY3WWEveVBLci93akd1?= =?utf-8?B?UkhPajVDS2JhcGRtN0xheDMyZEVwRU8rR1dNSVJDUkdRdjY2M1Z3VjdtcHlz?= =?utf-8?B?R1FHUjlBZFpmcEFFZytCckFKMUhlcll1d0k1VnFnVGFPNHRoQk02SFA1M3RL?= =?utf-8?B?Rys5cjFjMW5zWTdEOWdKTXZPR3AwNC84UFc1akdrdUV3MTVLQTNKVmlUVXBI?= =?utf-8?B?TVQyeWNiems3MWZORmZ5MnlneUtqdW9QSlBLMlZ5NVJodElqZkErYURBWDFN?= =?utf-8?B?ckg5M01YYVBTZUt0THg5NmFGZHI5eTFabkhUZ3NacmFPTGlTaTl5SUlaU2Y1?= =?utf-8?B?bVhiWkduM3UyTzR0K1RxdURkb3VvSkVKQlhCNHFFM0RIcE9TUW5HSFZESGVu?= =?utf-8?B?TEVyWllvTlZ5ak9XdG1Ybm9GWmNVR3NaTWZaTTRNZW4zSUxlSXJzTnN3cWs5?= =?utf-8?B?c0dER0hlK0tpZ01TenVoY1dFNVVKdmxsV2lhY0NtOHVZeCtuVmVkaEVMMy9z?= =?utf-8?B?YWMrSExrQ2RLNWRLK1NwQ1BVVlZnaTUzRmloMEdpY0N0QVdRZUxHWW5IQlVu?= =?utf-8?B?NW1WTVpqV09qNlpJU293MTlyYklBNEs1UkVFTDVIamdic1pJY1hKWFdwVzJj?= =?utf-8?B?OEJmQTRzdDRVSERyVGRvbWZLcE80SWhxalVvS0x5YkxNSFZSWDFLMlBmOEpD?= =?utf-8?B?MkptZFFMTE1hMzhSdzdsZnpROUsvR200MzdyVmxEQnNDUWdWRGJ5ZXpxdFBC?= =?utf-8?B?NFQwc3RzZk1JQ2hES0JVbTNWWERuU0szRjlsWHErdzdGUU5UL2QvcTBNYjIx?= =?utf-8?B?TzBtd1pzQTRaaFRzRGx2eDBkRHE3Q2NwT1VDcEZvelFKYy83bm9nMUNRS0Zj?= =?utf-8?B?a3RPWmtsQWN2OWFNK2RHS0ZWVkdjVllUbWpZODVZaWRyeVNTMjhUQkRwM1Rn?= =?utf-8?B?dlBVd3RKaFBtVE1PekduVEkwY016T0RjWnU2TUlLUXY2U1VYUHVVemh5Sndt?= =?utf-8?B?TTNnbzFRSkRIMGk1SjRFL0x6OE1JdUFDSnliYzk1eno1VG9pMmlicDFXMUhT?= =?utf-8?B?Y0RtcERiTCsvL2RGVGVjM2N1NzNCamlGNWxRR0NSbytZM1hCYjNuSkgxWis2?= =?utf-8?B?ZysvOGRqeUJXTjE5THZWN0w1NUJJanRVdVI0VGJJTE5BRWYvZEFzOHdTRlV5?= =?utf-8?B?dks0TUJpREp1RW90K21oVGkwR2JPZWZVSk5wWHZNVXhYK09heUsyOWFFaDBi?= =?utf-8?B?ekFTeTZWSVc2bnF1MVY2WFpNOWlCN2EvaGhVVEJrZjl3OE9XRHdGcW0rZjYx?= =?utf-8?B?Z2l2MWdwMWk0K1RVWlBMbmVJSFhpNGpVU0FrN3laRGlDNGMvK3ljNnRCVU90?= =?utf-8?B?MEdsakJDSk9ERjM4NWN5U2dEQXppQ1RONVN3UUNiWnk3WmxzTU43cjFRQ3NG?= =?utf-8?B?YTlBdXlOWVVYd1NHWnpDczlNVDFvbkxNbStYMWhGWGhKWk9aT2xkUjhqL2V1?= =?utf-8?B?REcybDBFWk10aDhQOUM1WjkvV3I2d3RuWCtxdnRWbHVzOHVsQ3dDV0xZdkNy?= =?utf-8?Q?ctU/AawuOmetgGm8fbv1Qjse9?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f51735bd-96b2-46ea-5470-08db4d36893e X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 07:01:23.0142 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RqMHjUq133NACOGQE9ETWfrW7xkt2/aOYF7tocWtR5BCksiPFwD9sGsNITGKhti9w3lhAMbRZX4V++jOjurUvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB9744 On 04.05.2023 18:56, Jason Andryuk wrote: > On Thu, May 4, 2023 at 9:11 AM Jan Beulich wrote: >> On 01.05.2023 21:30, Jason Andryuk wrote: >>> --- a/docs/misc/xen-command-line.pandoc >>> +++ b/docs/misc/xen-command-line.pandoc >>> @@ -499,7 +499,7 @@ If set, force use of the performance counters for oprofile, rather than detectin >>> available support. >>> >>> ### cpufreq >>> -> `= none | {{ | xen } [:[powersave|performance|ondemand|userspace][,][,[][,[verbose]]]]} | dom0-kernel` >>> +> `= none | {{ | xen } [:[powersave|performance|ondemand|userspace][,][,[]][,[]][,[]][,[verbose]]]} | dom0-kernel` >> >> Considering you use a special internal governor, the 4 governor alternatives are >> meaningless for hwp. Hence at the command line level recognizing "hwp" as if it >> was another governor name would seem better to me. This would then also get rid >> of one of the two special "no-" prefix parsing cases (which I'm not overly >> happy about). >> >> Even if not done that way I'm puzzled by the way you spell out the interaction >> of "hwp" and "hdc": As you say in the description, "hdc" is meaningful only when >> "hwp" was specified, so even if not merged with the governors group "hwp" should >> come first, and "hdc" ought to be rejected if "hwp" wasn't first specified. (The >> way you've spelled it out it actually looks to be kind of the other way around.) > > I placed them in alphabetical order, but, yes, it doesn't make sense. > >> Strictly speaking "maxfreq" and "minfreq" also should be objected to when "hwp" >> was specified. >> >> Overall I'm getting the impression that beyond your "verbose" related adjustment >> more is needed, if you're meaning to get things closer to how we parse the >> option (splitting across multiple lines to help see what I mean): >> >> `= none >> | {{ | xen } [:{powersave|performance|ondemand|userspace} >> [{,hwp[,hdc]|[,maxfreq=[,minfreq=]}] >> [,verbose]]} >> | dom0-kernel` >> >> (We're still parsing in a more relaxed way, e.g. minfreq may come ahead of >> maxfreq, but better be more tight in the doc than too relaxed.) >> >> Furthermore while max/min freq don't apply directly, there are still two MSRs >> controlling bounds at the package and logical processor levels. > > Well, we only program the logical processor level MSRs because we > don't have a good idea of the packages to know when we can skip > writing an MSR. > > How about this: > `= none > | {{ | xen } { > [:{powersave|performance|ondemand|userspace}[,maxfreq=[,minfreq=]] > | [:hwp[,hdc]] } > [,verbose]]} > | dom0-kernel` Looks right, yes. >>> --- /dev/null >>> +++ b/xen/arch/x86/acpi/cpufreq/hwp.c >>> @@ -0,0 +1,506 @@ >>> +/* SPDX-License-Identifier: GPL-2.0 */ >>> +/* >>> + * hwp.c cpufreq driver to run Intel Hardware P-States (HWP) >>> + * >>> + * Copyright (C) 2021 Jason Andryuk >>> + */ >>> + >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> + >>> +static bool feature_hwp; >>> +static bool feature_hwp_notification; >>> +static bool feature_hwp_activity_window; >>> +static bool feature_hwp_energy_perf; >>> +static bool feature_hwp_pkg_level_ctl; >>> +static bool feature_hwp_peci; >>> + >>> +static bool feature_hdc; >> >> Most (all?) of these want to be __ro_after_init, I expect. > > I think you are correct. (This pre-dates __ro_after_init and I didn't > update it.) Yet even then they should have used __read_mostly. >>> +union hwp_request >>> +{ >>> + struct >>> + { >>> + uint64_t min_perf:8; >>> + uint64_t max_perf:8; >>> + uint64_t desired:8; >>> + uint64_t energy_perf:8; >>> + uint64_t activity_window:10; >>> + uint64_t package_control:1; >>> + uint64_t reserved:16; >>> + uint64_t activity_window_valid:1; >>> + uint64_t energy_perf_valid:1; >>> + uint64_t desired_valid:1; >>> + uint64_t max_perf_valid:1; >>> + uint64_t min_perf_valid:1; >> >> The boolean fields here would probably better be of type "bool". I also >> don't see the need for using uint64_t for any of the other fields - >> unsigned int will be quite fine, I think. Only ... > > This is the hardware MSR format, so it seemed natural to use uint64_t > and the bit fields. To me, uint64_t foo:$bits; better shows that we > are dividing up a single hardware register using bit fields. > Honestly, I'm unfamiliar with the finer points of laying out bitfields > with bool. And the 10 bits of activity window throws off aligning to > standard types. > > This seems to have the correct layout: > struct > { > unsigned char min_perf; > unsigned char max_perf; > unsigned char desired; > unsigned char energy_perf; > unsigned int activity_window:10; > bool package_control:1; > unsigned int reserved:16; > bool activity_window_valid:1; > bool energy_perf_valid:1; > bool desired_valid:1; > bool max_perf_valid:1; > bool min_perf_valid:1; > } ; > > Or would you prefer the first 8 bit ones to be unsigned int > min_perf:8? Personally I think using bitfields uniformly would be better. What you definitely cannot use if not using a bitfield is "unsigned char", it ought to by uint8_t then. If using a bitfield, as said, I think it's best to stick to unsigned int and bool, unless field width goes beyond 32 bits or fields cross a 32-bit boundary. > The bools seem to need :1, which doesn't seem to be > gaining us much, IMO. I'd strongly prefer just keeping it as I have > it, but I will change it however you like. It's not so much how I like it, but to follow (a) existing practice (for the boolean fields) and (b) ./CODING_STYLE (for the selection of types). >>> + }; >>> + uint64_t raw; >> >> ... this wants to keep this type. (Same again below then.) > > For "below", do you want: > > struct > { > unsigned char highest; > unsigned char guaranteed; > unsigned char most_efficient; > unsigned char lowest; > unsigned int reserved; > } hw; > ? No - it can only be bitfields or fixed-width types here. >>> +bool __init hwp_available(void) >>> +{ >>> + unsigned int eax, ecx, unused; >>> + bool use_hwp; >>> + >>> + if ( boot_cpu_data.cpuid_level < CPUID_PM_LEAF ) >>> + { >>> + hwp_verbose("cpuid_level (%#x) lacks HWP support\n", >>> + boot_cpu_data.cpuid_level); >>> + return false; >>> + } >>> + >>> + if ( boot_cpu_data.cpuid_level < 0x16 ) >>> + { >>> + hwp_info("HWP disabled: cpuid_level %#x < 0x16 lacks CPU freq info\n", >>> + boot_cpu_data.cpuid_level); >>> + return false; >>> + } >>> + >>> + cpuid(CPUID_PM_LEAF, &eax, &unused, &ecx, &unused); >>> + >>> + if ( !(eax & CPUID6_EAX_HWP_ENERGY_PERFORMANCE_PREFERENCE) && >>> + !(ecx & CPUID6_ECX_IA32_ENERGY_PERF_BIAS) ) >>> + { >>> + hwp_verbose("HWP disabled: No energy/performance preference available"); >>> + return false; >>> + } >>> + >>> + feature_hwp = eax & CPUID6_EAX_HWP; >>> + feature_hwp_notification = eax & CPUID6_EAX_HWP_NOTIFICATION; >>> + feature_hwp_activity_window = eax & CPUID6_EAX_HWP_ACTIVITY_WINDOW; >>> + feature_hwp_energy_perf = >>> + eax & CPUID6_EAX_HWP_ENERGY_PERFORMANCE_PREFERENCE; >>> + feature_hwp_pkg_level_ctl = eax & CPUID6_EAX_HWP_PACKAGE_LEVEL_REQUEST; >>> + feature_hwp_peci = eax & CPUID6_EAX_HWP_PECI; >>> + >>> + hwp_verbose("HWP: %d notify: %d act-window: %d energy-perf: %d pkg-level: %d peci: %d\n", >>> + feature_hwp, feature_hwp_notification, >>> + feature_hwp_activity_window, feature_hwp_energy_perf, >>> + feature_hwp_pkg_level_ctl, feature_hwp_peci); >>> + >>> + if ( !feature_hwp ) >>> + return false; >>> + >>> + feature_hdc = eax & CPUID6_EAX_HDC; >>> + >>> + hwp_verbose("HWP: Hardware Duty Cycling (HDC) %ssupported%s\n", >>> + feature_hdc ? "" : "not ", >>> + feature_hdc ? opt_cpufreq_hdc ? ", enabled" : ", disabled" >>> + : ""); >>> + >>> + feature_hdc = feature_hdc && opt_cpufreq_hdc; >>> + >>> + hwp_verbose("HWP: HW_FEEDBACK %ssupported\n", >>> + (eax & CPUID6_EAX_HW_FEEDBACK) ? "" : "not "); >> >> You report this, but you don't really use it? > > Correct. I needed to know what capabilities my processors have. > > feature_hwp_pkg_level_ctl and feature_hwp_peci can also be dropped > since they aren't used beyond printing their values. I'd still lean > toward keeping their printing under verbose since otherwise there > isn't a convenient way to know if they are available without > recompiling. That's fine, but wants mentioning in the description. Also respective variables would want to be __initdata then, be local to the function, or be dropped altogether. Plus you'd want to be consistent - either you use a helper variable for all print-only features, or you don't. >>> +static void hwp_get_cpu_speeds(struct cpufreq_policy *policy) >>> +{ >>> + uint32_t base_khz, max_khz, bus_khz, edx; >>> + >>> + cpuid(0x16, &base_khz, &max_khz, &bus_khz, &edx); >>> + >>> + /* aperf/mperf scales base. */ >>> + policy->cpuinfo.perf_freq = base_khz * 1000; >>> + policy->cpuinfo.min_freq = base_khz * 1000; >>> + policy->cpuinfo.max_freq = max_khz * 1000; >>> + policy->min = base_khz * 1000; >>> + policy->max = max_khz * 1000; >>> + policy->cur = 0; >> >> What is the comment intended to be telling me here? > > When I was surprised to discover that I needed to pass in the base > frequency for proper aperf/mperf scaling, it seemed relevant at the > time as it's the opposite of ACPI cpufreq. It can be dropped now. Well, I'm not insisting on dropping the comment. It could also be left, but then extended so it can be understood what is meant. >>> +static void cf_check hwp_init_msrs(void *info) >>> +{ >>> + struct cpufreq_policy *policy = info; >>> + struct hwp_drv_data *data = this_cpu(hwp_drv_data); >>> + uint64_t val; >>> + >>> + /* >>> + * Package level MSR, but we don't have a good idea of packages here, so >>> + * just do it everytime. >>> + */ >>> + if ( rdmsr_safe(MSR_IA32_PM_ENABLE, val) ) >>> + { >>> + hwp_err("CPU%u: error rdmsr_safe(MSR_IA32_PM_ENABLE)\n", policy->cpu); >>> + data->curr_req.raw = -1; >>> + return; >>> + } >>> + >>> + /* Ensure we don't generate interrupts */ >>> + if ( feature_hwp_notification ) >>> + wrmsr_safe(MSR_IA32_HWP_INTERRUPT, 0); >>> + >>> + hwp_verbose("CPU%u: MSR_IA32_PM_ENABLE: %016lx\n", policy->cpu, val); >>> + if ( !(val & IA32_PM_ENABLE_HWP_ENABLE) ) >>> + { >>> + val |= IA32_PM_ENABLE_HWP_ENABLE; >>> + if ( wrmsr_safe(MSR_IA32_PM_ENABLE, val) ) >>> + { >>> + hwp_err("CPU%u: error wrmsr_safe(MSR_IA32_PM_ENABLE, %lx)\n", >>> + policy->cpu, val); >>> + data->curr_req.raw = -1; >>> + return; >>> + } >>> + } >>> + >>> + if ( rdmsr_safe(MSR_IA32_HWP_CAPABILITIES, data->hwp_caps) ) >>> + { >>> + hwp_err("CPU%u: error rdmsr_safe(MSR_IA32_HWP_CAPABILITIES)\n", >>> + policy->cpu); >>> + data->curr_req.raw = -1; >>> + return; >>> + } >>> + >>> + if ( rdmsr_safe(MSR_IA32_HWP_REQUEST, data->curr_req.raw) ) >>> + { >>> + hwp_err("CPU%u: error rdmsr_safe(MSR_IA32_HWP_REQUEST)\n", policy->cpu); >>> + data->curr_req.raw = -1; >>> + return; >>> + } >>> + >>> + if ( !feature_hwp_energy_perf ) { >> >> Nit: Brace placement. >> >>> + if ( rdmsr_safe(MSR_IA32_ENERGY_PERF_BIAS, val) ) >>> + { >>> + hwp_err("error rdmsr_safe(MSR_IA32_ENERGY_PERF_BIAS)\n"); >>> + data->curr_req.raw = -1; >>> + >>> + return; >>> + } >>> + >>> + data->energy_perf = val & IA32_ENERGY_BIAS_MASK; >>> + } >> >> In order to not need to undo the "enable" you've already done, maybe that >> should move down here? > > HWP needs to be enabled before the Capabilities and Request MSRs can > be read. I must have missed this aspect in the SDM. Do you have a pointer? > Reading them shouldn't fail, but it seems safer to use > rdmsr_safe in case something goes wrong. Sure. But then the "enable" will need undoing in the unlikely event of failure. >>> --- a/xen/arch/x86/include/asm/cpufeature.h >>> +++ b/xen/arch/x86/include/asm/cpufeature.h >>> @@ -46,8 +46,17 @@ extern struct cpuinfo_x86 boot_cpu_data; >>> #define cpu_has(c, bit) test_bit(bit, (c)->x86_capability) >>> #define boot_cpu_has(bit) test_bit(bit, boot_cpu_data.x86_capability) >>> >>> -#define CPUID_PM_LEAF 6 >>> -#define CPUID6_ECX_APERFMPERF_CAPABILITY 0x1 >>> +#define CPUID_PM_LEAF 6 >>> +#define CPUID6_EAX_HWP (_AC(1, U) << 7) >>> +#define CPUID6_EAX_HWP_NOTIFICATION (_AC(1, U) << 8) >>> +#define CPUID6_EAX_HWP_ACTIVITY_WINDOW (_AC(1, U) << 9) >>> +#define CPUID6_EAX_HWP_ENERGY_PERFORMANCE_PREFERENCE (_AC(1, U) << 10) >>> +#define CPUID6_EAX_HWP_PACKAGE_LEVEL_REQUEST (_AC(1, U) << 11) >>> +#define CPUID6_EAX_HDC (_AC(1, U) << 13) >>> +#define CPUID6_EAX_HWP_PECI (_AC(1, U) << 16) >>> +#define CPUID6_EAX_HW_FEEDBACK (_AC(1, U) << 19) >> >> Perhaps better without open-coding BIT()? > > Ok. > >> I also find it a little odd that e.g. bit 17 is left out here despite you >> declaring the 5 "valid" bits in union hwp_request (which are qualified by >> this CPUID bit afaict). > > Well, I thought I wasn't supposed to introduce unused defines, so I > didn't add one for 17. For union hwp_request, the "valid" bits are > part of the register structure, so it makes sense to include them > instead of an incomplete definition. IIRC, at some point I set the > "valid" bits when I wasn't supposed to, and they caused the wrmsr > calls to fail. That might have been because my test machines don't > have package-level HWP. > > (I was confused when the CPUID section stated "Bit 17: Flexible HWP is > supported if set.", but there are no further references to "Flexible > HWP" in the SDM.) A not uncommon issue with the SDM. At least there is a place where bit 17's purpose is described in the HWP section. >>> @@ -165,6 +172,11 @@ >>> #define PASID_PASID_MASK 0x000fffff >>> #define PASID_VALID (_AC(1, ULL) << 31) >>> >>> +#define MSR_IA32_PKG_HDC_CTL 0x00000db0 >>> +#define IA32_PKG_HDC_CTL_HDC_PKG_ENABLE (_AC(1, ULL) << 0) >> >> The name has two redundant infixes, which looks odd, but then I can't >> suggest any better without going too much out of sync with the SDM. > > Yes, it's not a good name, but I was trying to keep close to the SDM. > FAOD, these should drop IA32_ to become: > MSR_PKG_HDC_CTL > PKG_HDC_CTL_HDC_PKG_ENABLE > ? Right. > Thank you for taking the time to review this. Well, it has taken me awfully long to get back to this. Jan From xen-devel-bounces@lists.xenproject.org Fri May 05 07:04:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 07:04:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530241.825732 (Exim 4.92) (envelope-from ) id 1pupUF-0002T6-Cw; Fri, 05 May 2023 07:04:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530241.825732; Fri, 05 May 2023 07:04:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pupUF-0002Sz-A0; Fri, 05 May 2023 07:04:15 +0000 Received: by outflank-mailman (input) for mailman id 530241; Fri, 05 May 2023 07:04:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pupUE-0002Sr-Gm for xen-devel@lists.xenproject.org; Fri, 05 May 2023 07:04:14 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20611.outbound.protection.outlook.com [2a01:111:f400:7e1a::611]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0a0d292e-eb13-11ed-b226-6b7b168915f2; Fri, 05 May 2023 09:04:12 +0200 (CEST) Received: from AM3PR03CA0053.eurprd03.prod.outlook.com (2603:10a6:207:5::11) by PA4PR08MB6013.eurprd08.prod.outlook.com (2603:10a6:102:eb::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.27; Fri, 5 May 2023 07:04:09 +0000 Received: from AM7EUR03FT051.eop-EUR03.prod.protection.outlook.com (2603:10a6:207:5:cafe::af) by AM3PR03CA0053.outlook.office365.com (2603:10a6:207:5::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.25 via Frontend Transport; Fri, 5 May 2023 07:04:09 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT051.mail.protection.outlook.com (100.127.140.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.27 via Frontend Transport; Fri, 5 May 2023 07:04:08 +0000 Received: ("Tessian outbound 5bb4c51d5a1f:v136"); Fri, 05 May 2023 07:04:08 +0000 Received: from b9120d170423.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1AD70569-9188-456B-987B-569953A840EC.1; Fri, 05 May 2023 07:04:01 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b9120d170423.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 05 May 2023 07:04:01 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AS8PR08MB6438.eurprd08.prod.outlook.com (2603:10a6:20b:33e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Fri, 5 May 2023 07:03:59 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::9283:e527:bed8:ab23]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::9283:e527:bed8:ab23%7]) with mapi id 15.20.6363.022; Fri, 5 May 2023 07:03:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a0d292e-eb13-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7yzR14qhZFTuVD2Nj9E0CJ0ZlwredMCBWPv253eudQE=; b=HFuk4KBTQ9X3tK76HKjjIxkK+g1DJu45Cd0rdvabwUV5gxC7R+BCRQkq10/oJyIAsOsJEWBP6MvCaP/ESUJ6KqbAmHUwvV/RD1WpO1wedm3uxrvP2QEF257uvZrrzlEe0EuohWVG9t8dfU+yOIClDU/n/fUWBIn/8mJWlUVws4c= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 96c056a29253d263 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PWNfV9eVrbcpWKBUGvGZMiFitfQSeuFVCt7utIwUF13qc+uyNVBf+lOJYCuoNF4R0PDNxX0UkN1x1RLNepyGAFH7LYUQnH9Q30GBLRDYlL6n/Mn5Y4u+yaNOaQPDeFnv/1qOcKfO92IzhcoBZ9NXdStDL0h0Zu8JvRe3N15NmRoPBOwSAMHuc2CJQKc9gOv/f5JMMx2dVCNKQ/y8czcUhLhTWqYfRFFIKURK9OVlTQft6Wjer5bkRm0QE2vug37eQz48lmkDXmDyClYYJOG6L2DBraUYbk1qYzvDX9M9PuRwzsKJG2eD4HV/PSt4zW3RIMjNh/ft2l7FF6CLAi4TsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7yzR14qhZFTuVD2Nj9E0CJ0ZlwredMCBWPv253eudQE=; b=e2KbgE3xyyKPJ7sAwzPWlOwY0SrqWByuC4dgWi/T9L//mtUrSQ1z8bZ1B88WMSoF7vIlMYsJIuK84X8ZqtTyYmnQTdSlc3MwkkEXsPFg7ZkPKMvD27WPALImiB5STOb52oNaRe8Au2gf9Ba8qwNGo4itF7lTowtz501O+udalh6AArbmeDSvcvfo1B3L7olCxG3+s+Jv+oRjWXBbuXEE1FCIYll8pkzFq+qQMGYyID5FZi5Pw1WmmrlIWlsoHZu+PjHBws33o9YaoBDzx2Ul9YNfAdci4Q71RFoyPHB0PuHqJSVXQ453YGhx057kCBwH/0b7W1nhdlVXEStms1Mr2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7yzR14qhZFTuVD2Nj9E0CJ0ZlwredMCBWPv253eudQE=; b=HFuk4KBTQ9X3tK76HKjjIxkK+g1DJu45Cd0rdvabwUV5gxC7R+BCRQkq10/oJyIAsOsJEWBP6MvCaP/ESUJ6KqbAmHUwvV/RD1WpO1wedm3uxrvP2QEF257uvZrrzlEe0EuohWVG9t8dfU+yOIClDU/n/fUWBIn/8mJWlUVws4c= From: Bertrand Marquis To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bobby Eshleman , Alistair Francis , Connor Davis , Anthony Perard Subject: Re: [PATCH] build: shorten macro references Thread-Topic: [PATCH] build: shorten macro references Thread-Index: AQHZfqPFJa3dHs9KjUu/MM/3AtGIR69LQjSA Date: Fri, 5 May 2023 07:03:59 +0000 Message-ID: References: <95467f2c-09ed-d34f-feef-5cd55c60f628@suse.com> In-Reply-To: <95467f2c-09ed-d34f-feef-5cd55c60f628@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.500.231) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|AS8PR08MB6438:EE_|AM7EUR03FT051:EE_|PA4PR08MB6013:EE_ X-MS-Office365-Filtering-Correlation-Id: 486871da-559a-47de-9db6-08db4d36ec1a x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Py///nuZCp5uqgh2FO+3Kgy09QJn3/U2L9xmc230HWg+ojMt7TuLm5okLHxf+v42O0Zx+DaPCbJuLMAvjaG3z6HFIfA/Wb/D3J0jZTyEMqpNrJcPZRgKXN437P8z2bI3g2m0QzyJE7qYcIC7spB1YHCC7lqLdznLccVP6J0zeMyIHlmyLg4f6IS7yL+YlsJDJvv296fLoETUYxpA/FS0jt2rP3CFRvCKYT93BwicyTEQaKHMYwo7gkt/RTutK4zfi1/d5AJqKTtn5qJ143A1QgQKdqMPkX8waZZqRF7P3e8z4cZbMZSnm3/v+5zFFZVrPWxvSeid6k/aQoxzc72aILRpXIuRG/g9YXtf2Ume1Hyo3f277YObVWNGnNtchum7YvS5FxL3Ys2t7GUPOQeclr+Hr0X4bAr/FLFYNtCbBOGt1js/PL8YP0JvX8zCy0Bz6STYtHkA1nu9/qx/3OC3kzb75b5JdiG/+VsZKIs4EMx3m1XrI61hn2cWdsbkHKYIrUtJQD67Uocti0R8D0ZR6rpidaqrTWMaZ+PgyzT7VcP7ycABt/HtCiho6qMAd185auahmBhIXxYNOCqiwC0S+Xb6aHXT68QAlh0EbZY2Ahdp7kJ4VaB1WvuZOad7Cjdigbzd670bP14cZeCFFE/nzQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(346002)(396003)(376002)(39860400002)(366004)(451199021)(316002)(33656002)(41300700001)(71200400001)(2906002)(53546011)(186003)(6512007)(86362001)(6486002)(4326008)(6916009)(64756008)(6506007)(66556008)(76116006)(91956017)(66476007)(66446008)(66946007)(36756003)(2616005)(38070700005)(54906003)(7416002)(8936002)(478600001)(122000001)(5660300002)(8676002)(38100700002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-ID: <2C712AB7273D004D84866F29E6E5C855@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6438 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6cb967cd-d0e8-4a03-2cb2-08db4d36e6b6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wdCnvY2SR/Jp9VHkF6i8OX53bYkb8GXocpkhXtECZvXdTQT78ml7mpr7mryJD1BU5pl2PAa+qdpYPHIq8z7CF3ZT2opgK3MlZYd/xNaUYhA6wvam0vzH9UPFw5y2BsoOkm47Wu4waCpIAoxKnccjqxOawNGEqVUC5IU9nZar9gA16x96PYPZCCvich2195r850c5h6cKHG/zfQWIGznDVtN86WwdwxbrZ5vN9V0E2u4aiW45a1gwE9Tc2Gk7pbegA7v7PutGW9NJ7CqC0J3Fw3RKP/fHJbhE1msgfLpJXkqSmgp6PYlgTFTiNGAiTWnLHKC+kouZV7I120l3Amj/ywIygaqcbJTgPbxZn5j3IRirPGZgJMtlFAB352xkxM8lRDu8uCP7bDdth+pzW/dvxeixN7Ifu+QV+YcDwBPC7xtf1m6A1bcoAFWJxxLezU5lBoT0lOv8P4fDKMzzZB3qSt4DgDHMloQeEeb/Rgc22IMR31ItIszDvhyAJ5TJCc+EZV5nJr58E54gJI5gTWAnsmJMqFRZIErkue6V1r+Lz8VFnb71i5lU5gYSMw15mpkAu5ZCFRcyB878FTGSlIqBdjH6elDuBSPgCKM/+C0Mim2NoVU7A4Mr4+2w8anxW9tH7etsJqGuso2IxJ6pVZTmais+LUn+J4BCXud/6LyUxMAlcVjylc8U9eIS7+orNA2C/YWHG5Mbty0MHD5f4jCmllZHfgyyKIosargYJDMYkoU= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(39860400002)(136003)(376002)(451199021)(40470700004)(46966006)(36840700001)(47076005)(2616005)(40460700003)(186003)(336012)(2906002)(34020700004)(40480700001)(36756003)(33656002)(86362001)(82310400005)(82740400003)(81166007)(356005)(36860700001)(8936002)(8676002)(6862004)(5660300002)(4326008)(70586007)(70206006)(41300700001)(6486002)(316002)(478600001)(107886003)(54906003)(6512007)(53546011)(26005)(6506007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 07:04:08.7328 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 486871da-559a-47de-9db6-08db4d36ec1a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6013 Hi Jan, > On 4 May 2023, at 18:16, Jan Beulich wrote: >=20 > Presumably by copy-and-paste we've accumulated a number of instances of > $(@D)/$(@F), which really is nothing else than $@. The split form only > needs using when we want to e.g. insert a leading . at the beginning of > the file name portion of the full name. >=20 > Signed-off-by: Jan Beulich Reviewed-by: Bertrand Marquis Cheers Bertrand >=20 > --- a/xen/arch/arm/Makefile > +++ b/xen/arch/arm/Makefile > @@ -104,9 +104,9 @@ $(TARGET)-syms: $(objtree)/prelink.o $(o > $(MAKE) $(build)=3D$(@D) $(@D)/.$(@F).1.o > $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ > $(@D)/.$(@F).1.o -o $@ > - $(NM) -pa --format=3Dsysv $(@D)/$(@F) \ > + $(NM) -pa --format=3Dsysv $@ \ > | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ > - >$(@D)/$(@F).map > + >$@.map > rm -f $(@D)/.$(@F).[0-9]* >=20 > .PHONY: include > --- a/xen/arch/riscv/Makefile > +++ b/xen/arch/riscv/Makefile > @@ -10,9 +10,9 @@ $(TARGET): $(TARGET)-syms >=20 > $(TARGET)-syms: $(objtree)/prelink.o $(obj)/xen.lds > $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) -o $@ > - $(NM) -pa --format=3Dsysv $(@D)/$(@F) \ > + $(NM) -pa --format=3Dsysv $@ \ > | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ > - >$(@D)/$(@F).map > + >$@.map >=20 > $(obj)/xen.lds: $(src)/xen.lds.S FORCE > $(call if_changed_dep,cpp_lds_S) > --- a/xen/arch/x86/Makefile > +++ b/xen/arch/x86/Makefile > @@ -150,9 +150,9 @@ $(TARGET)-syms: $(objtree)/prelink.o $(o > $(MAKE) $(build)=3D$(@D) $(@D)/.$(@F).1.o > $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ > $(orphan-handling-y) $(@D)/.$(@F).1.o -o $@ > - $(NM) -pa --format=3Dsysv $(@D)/$(@F) \ > + $(NM) -pa --format=3Dsysv $@ \ > | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ > - >$(@D)/$(@F).map > + >$@.map > rm -f $(@D)/.$(@F).[0-9]* $(@D)/..$(@F).[0-9]* > ifeq ($(CONFIG_XEN_IBT),y) > $(SHELL) $(srctree)/tools/check-endbr.sh $@ > @@ -224,8 +224,9 @@ endif > $(MAKE) $(build)=3D$(@D) .$(@F).1r.o .$(@F).1s.o > $(LD) $(call EFI_LDFLAGS,$(VIRT_BASE)) -T $(obj)/efi.lds -N $< \ > $(@D)/.$(@F).1r.o $(@D)/.$(@F).1s.o $(orphan-handling-y) $(note_file= _option) -o $@ > - $(NM) -pa --format=3Dsysv $(@D)/$(@F) \ > - | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort >$(@D)= /$(@F).map > + $(NM) -pa --format=3Dsysv $@ \ > + | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ > + >$@.map > ifeq ($(CONFIG_DEBUG_INFO),y) > $(if $(filter --strip-debug,$(EFI_LDFLAGS)),:$(space))$(OBJCOPY) -O elf64= -x86-64 $@ $@.elf > endif From xen-devel-bounces@lists.xenproject.org Fri May 05 07:05:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 07:05:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530244.825743 (Exim 4.92) (envelope-from ) id 1pupUt-00030O-LZ; Fri, 05 May 2023 07:04:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530244.825743; Fri, 05 May 2023 07:04:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pupUt-00030H-IT; Fri, 05 May 2023 07:04:55 +0000 Received: by outflank-mailman (input) for mailman id 530244; Fri, 05 May 2023 07:04:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pupUs-0002yh-PX for xen-devel@lists.xenproject.org; Fri, 05 May 2023 07:04:54 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2043.outbound.protection.outlook.com [40.107.7.43]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 21ee2907-eb13-11ed-8611-37d641c3527e; Fri, 05 May 2023 09:04:52 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DBAPR04MB7335.eurprd04.prod.outlook.com (2603:10a6:10:1b1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.27; Fri, 5 May 2023 07:04:23 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%7]) with mapi id 15.20.6363.027; Fri, 5 May 2023 07:04:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 21ee2907-eb13-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QmTA99hTVrFpkt8kVePZKrhUs/VB+A+dj/1GH7NkQX31EWjsRvkh6V9gAr/XA/rYZczsBGGfxQsqTPtaEOKXbhXcDbjqO9KInUcIyXgK3E+sb01nA+7t+zxPuI/Hb80/y9eNFwZ4tReFsOjU3pZC/842dUwpE+PtXXQq0xcOReApcaSUvbmS+f2Vo5rcjDCKHa6xwR0f8rbUWLDodgh/O4HfCFEqydbvFAFbgskTm9ECMpLUyMWh+9ww+fGBtRKUBeMQvZzKiAMOnYsMCdYSZhauQtaZrs14mwJnbZt84uuBsso+z/DMJpihiSOT5bwVuNm4VpGh5bcTuXnPIvOSuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3O0K/iRk1u8q9x+Hqf1l/IJHKu+M7pGBN80sM11F79g=; b=fLiwg3zesP3iNtNzzmWw2c8ufNNlwrtT2NJbRPbLwBoYKWewL/UWA5gyAG3xctVG4gQI6xRnb1JUspIfg8XGkXSeIK4FTeQQiENbL7QPAlfvBkI+AdO+YHrbQQ1EEgtzhQZG9Nt3ZXhlV3/+fLJftfvcB+OvJmgD+laU4283VvBnSWVQxBdnmrXEgEqMgM+C6iCGNCuaMelg4tJ3n3iexZ6SfzAqD6Q9WlsaZYmuSCtVE5DhE9yA0COCfcoKz+ysSCPW0I1uhp1My3KWTk6lwltRk7zs0MUY0l1URLDsdZim8Ia/D3cGcZHFv4PomfFsJyq/LqLX/ubneLSTJSGjhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3O0K/iRk1u8q9x+Hqf1l/IJHKu+M7pGBN80sM11F79g=; b=NxmrwjycbmcfRztSEjVjIH21o5VlWGMvKCk0FHq6r3kHUlYtPSCAT/lAz5iahIf9THM/UoZeqdtxAOaPkAfpaBo0/1wJ/nqGYYA5cOATBf/BgZqiYsR0B71pH8x3Ql8yT58qQz0f7eNyH5OaPNgk/y7BIHjO3xf4pR/5+jPu6FxWxUXh0Uyo3yUpdFpXzvaAdxm25LkOvx3h02JcI0phbPIhehHJLOZVNPTsn0diNgKSm9QIEhZPn1uPFWJ/L5VUlgDuwqkW6jYjaa81e5R+gCLEyWNcm7+Wn/UbEajWgojf+eaz+JGcACwBVYOwLN+neUjizr6KTzXXR1Yf9EXIKw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 5 May 2023 09:04:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3 05/14 RESEND] xenpm: Change get-cpufreq-para output for internal Content-Language: en-US To: Jason Andryuk Cc: Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org References: <20230501193034.88575-1-jandryuk@gmail.com> <20230501193034.88575-6-jandryuk@gmail.com> <2864bf57-88cd-6fce-2d38-6f3a31abb440@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0235.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b2::20) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|DBAPR04MB7335:EE_ X-MS-Office365-Filtering-Correlation-Id: d577a2da-ccf3-4788-acc7-08db4d36f4de X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fjZ0HNvntrF8zmpRZbroLjO/B3uq8m6bQZOaMc5n0ZKz7Q5k4cXzMKeVPoKjLFI9ApO7Qev1aAJx5uK2yml1UJjv1F4WH2KCOId4XR13l8oGtbcJt+/mFCxX69Wrp+qvkc3XFvDmqDZ3eGr/FrTOFzGV6xhTztQNWqq+1pvB1Xk1cDrSk6Bac7a5JAx4JruM9aQFui2HXFNfVjhOzZfWsu5HKBnbMpR3aSndcpktRBWBF2lzyu59f7t++kngS3YWsntRCR6VF1fgk+hi0wSi2DWGSETRfJFQI7gtNtY9yVfzZFxovnlDDTTKa47edakiyxdo5FhtirJ5VFPD9/EjQlMoscyL1LqLXEfN3peC/35cXlV9KwNIf391AgXZcCRwRDxFJxnDIFzNkj7jgmpe2f9lxJ/BwyqXuK4JRc7rRDHoCYln02wHj3feSTtdUHob7RFMIvVNe9APyz6UdtLXmchcXlBDculoouMN6DxP3wRcNel8Irsxzu5UQ+x84SDsy0M0YM8PvuV1XU1FMwUeoDrbCGrbBwZz349FO6SFs4pXFbGRGkn3piTTrBFB9xS9778TpT1aDsq2/YUY5B+qrh3BXFHCtg0r9ve5IWS48vJolKJmXQhJrkxs3r2LNX39U6gcyje1Wpilyq1s/2c+Zg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(346002)(39850400004)(376002)(366004)(136003)(451199021)(83380400001)(2616005)(186003)(2906002)(38100700002)(36756003)(31696002)(86362001)(41300700001)(8936002)(8676002)(5660300002)(966005)(6916009)(4326008)(66556008)(66476007)(66946007)(6486002)(316002)(31686004)(478600001)(54906003)(26005)(6506007)(6512007)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZS9MWXg0UWwwZ09lS3lTby8zMFYyNU5IWmFubE02cHVzMkhzdlRsWmF3Q0Z4?= =?utf-8?B?dUErL09iTExPTEV3YXZIV2h2OVVHeFdYVVhQd1VkODNnUEgyU3dkRC9CSGlV?= =?utf-8?B?bGxSd2dFQzlPaEQwYU0wZGFEc1ZNZWxVVkdxaUJUdGQxR0hPdC9KZGlKSFk1?= =?utf-8?B?VUhvc0FMSEN6Yyt3MGpoT0l3YWhkZ01Vdmo1VlBIWFRGRTFNazAyY0RMVXEx?= =?utf-8?B?dTVSZm0rcTNJdW1nRFEwTHZlaWVDSnVZOHpzMGptdG9vcHdESzJrK2V6YVE1?= =?utf-8?B?RU1WRitjclRBT2dSWjZUeU5tZ0M2b3FQYnZPaE1sejFXQ1k1MmRZOC9xTVA1?= =?utf-8?B?ZjJVYUowQkV5Wi9FZGhmb2xRWm1WN25XcUx2OUZZNDZ1TWtiYVV5d3FTRW8y?= =?utf-8?B?aUphSGdwQVIxQUZ4dTZRajNQc2tzMHY3ZGRJaitENzhhdVV4QjNEY2dQTUI0?= =?utf-8?B?WHhpOURXMnhiRlRpRTVnSjZ1N3ROL0ZUam5LYnNCaGpEVVdmWm4xL1BrMFFX?= =?utf-8?B?eWg2dGhxTFlSdlZXVGFtVFBxUUhBOXNFUFdjNmpBdDRqRGFYR0pKRVkzdkQ5?= =?utf-8?B?UWtwUVdPaFZkdXdESnZlYnpRMGczMzNrRUxuVEdwTW9mRTBVaEZLbXNwVHQ0?= =?utf-8?B?bUFmdVp3OW9wUk53U3NjSjdxQk9XRnVDKzJveUdNTSsyV0xwdEJPR1ZDSHla?= =?utf-8?B?bFlkMkl4bmlHVUJwUEdGZytGUyt4ZmRvUW5EcVBxb1Iwb3lKOFFSK3YxRGNM?= =?utf-8?B?RXhuR3k4UlI4V3hRV2hrSFBkUnlXSytQSlI3Qkc1cTdOOHRMbHNCUUNBQjZr?= =?utf-8?B?NFJRckhDNUJvQkkrSytvZDhDK3R4cVF3V0hhTzc2dlVmYXBQeXo5dE4yVDRj?= =?utf-8?B?UHpVdmJBbk9rWjFQdmlraXN3MG0reW1mWVZZMy93NFBoNFI4U2NGb280dERz?= =?utf-8?B?eE4yc3RoSTFQekRuSmV0RDh4UHNvNUxJOXFqOHNqdFRJb0dLZHRzVVVqZUFP?= =?utf-8?B?TUw3dm9oY2Y5TVR5K0I4VFp2TWVPbHNXRnJXRTZkUnd6NTNlaFFha2JER2lj?= =?utf-8?B?RkZ0S2VUTVJKV1lrUkdLQS9Va0MrYy8xcU9Pa0Z1MG5VTEp3N2dPNWtrNkhp?= =?utf-8?B?bTNtSS9WcFRMMm1UL1hsTWFUWHVtVEZjcTlNNkM5NDh0eGNLTFFtYnU1UFVU?= =?utf-8?B?UjFPVGZMMHVHa1ptMlB1QjNlT1pucTk0QVlKaWVoK3ZjNmxhc09DaHBEOEM4?= =?utf-8?B?VGs0ZW53TGVlb082elMwMms2NDhFMkI2VWhqQk1Ub1F6UE0xR2tZby9CWjVT?= =?utf-8?B?eDFUUUVzUXJuM0pWakR0b2R6TGt0MWRBaGowQit6MnJiUjdPWnU3czhFL2hs?= =?utf-8?B?ZitWQU16TnkwdWtwK3F1UHh0alJMSDJHczN0TXl2NUJmNDVvdXhkYnBCb0Zp?= =?utf-8?B?NUcvZ1dOeTZTOHFFVjZqSUpwMzMzd0Fzd3hSZ2RpclE5WW9hWFlSb2U0L3Ay?= =?utf-8?B?dEJUUFU2TG84OFVqTG1abkVES1V5eTAyNXdPamRXME5BNXRxMmYrbzZRZ3Iz?= =?utf-8?B?bDhZUHk0Q0RkV3FUMGNHOVRTdlhrOFNFOW9FZUpna3VGcnMwLzJLR3BSRFQy?= =?utf-8?B?by9nVU9uc1NCdkYyajUvektPQVMxSHIzcXhhK1k2ZUVBa2gzNUx0RUtBc2lW?= =?utf-8?B?YWYyTldUOWhra3BjSXM1Tm1lRTBSbmh5R2ZTVW5teWxVYlV2NDFBVG5yUjZl?= =?utf-8?B?ZW0zSFRJQjY3enlhVXlmYzFvcS9FSEZzMmYyK1ZYYThhQWJPRisrb0d5Vk5D?= =?utf-8?B?M29nOEJJbVl1cE1QNGpvRGNVWTRQQmozbzZFRno5aXQvcnU3a1o4VE5CTytt?= =?utf-8?B?ZjZRY2xva1RJc1lLNHVSU2lsUUlLVWRTRnYrV0hObm9NVTZ4Q2JwNGdqcHBw?= =?utf-8?B?eXlkZGFuV0FCZVRQbGRwUTNvMGRLeWVJUy9kMlo4OWRvMGN5aVdyS1JJaVZm?= =?utf-8?B?UWF2RytZRDBZcnVTK2FrMnppZE84NEZ1SVo4UzU2MUVtakRzYzdMeHBLbFBt?= =?utf-8?B?ckp3bXFFZERUZTV3cElHRVk4SFFxbTF5SGlxck00TnlwSjlHL290MXdlakN4?= =?utf-8?Q?fMdOhYfWww+kxTeyFur13EwgV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d577a2da-ccf3-4788-acc7-08db4d36f4de X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 07:04:23.5865 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Vxry6/KsYw48na1RrhI6kgJORQPkl9uuL7FuGklwCbFMemvCu98Z6FM1iRXdQoyX3fqClPH0D8nNd3MwUtEgzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7335 On 04.05.2023 19:00, Jason Andryuk wrote: > On Thu, May 4, 2023 at 10:35 AM Jan Beulich wrote: >> >> On 01.05.2023 21:30, Jason Andryuk wrote: >>> When using HWP, some of the returned data is not applicable. In that >>> case, we should just omit it to avoid confusing the user. So switch to >>> printing the base and turbo frequencies since those are relevant to HWP. >>> Similarly, stop printing the CPU frequencies since those do not apply. >> >> It vaguely feels like I have asked this before: Can you point me at a >> place in the SDM where it is said that CPUID 0x16's "Maximum Frequency" >> is the turbo frequency? Without such a reference I feel a little uneasy >> with ... > > I don't have a reference, but I found it empirically to match the > "turbo" frequency. > > For an Intel® Core™ i7-10810U, > https://ark.intel.com/content/www/us/en/ark/products/201888/intel-core-i710810u-processor-12m-cache-up-to-4-90-ghz.html > > Max Turbo Frequency 4.90 GHz > > # xenpm get-cpufreq-para > cpu id : 0 > affected_cpus : 0 > cpuinfo frequency : base [1600000] turbo [4900000] > > Turbo has to be enabled to reach (close to) that frequency. > > From my cover letter: > This is for a 10th gen 6-core 1600 MHz base 4900 MHZ max cpu. In the > default balance mode, Turbo Boost doesn't exceed 4GHz. Tweaking the > energy_perf preference with `xenpm set-cpufreq-hwp balance ene:64`, > I've seen the CPU hit 4.7GHz before throttling down and bouncing around > between 4.3 and 4.5 GHz. Curiously the other cores read ~4GHz when > turbo boost takes affect. This was done after pinning all dom0 cores, > and using taskset to pin to vCPU/pCPU 11 and running a bash tightloop. Right, but what matters for the longer term future is what gets committed (and the cover letter won't be). IOW ... >>> @@ -720,10 +721,15 @@ static void print_cpufreq_para(int cpuid, struct xc_get_cpufreq_para *p_cpufreq) >>> printf(" %d", p_cpufreq->affected_cpus[i]); >>> printf("\n"); >>> >>> - printf("cpuinfo frequency : max [%u] min [%u] cur [%u]\n", >>> - p_cpufreq->cpuinfo_max_freq, >>> - p_cpufreq->cpuinfo_min_freq, >>> - p_cpufreq->cpuinfo_cur_freq); >>> + if ( internal ) >>> + printf("cpuinfo frequency : base [%u] turbo [%u]\n", >>> + p_cpufreq->cpuinfo_min_freq, >>> + p_cpufreq->cpuinfo_max_freq); >> >> ... calling it "turbo" (and not "max") here. > > I'm fine with "max". I think I went with turbo since it's a value you > cannot sustain but can only hit in short bursts. ... I don't mind you sticking to "turbo" as long as the description makes clear why that was chosen despite the SDM not naming it this way. Jan From xen-devel-bounces@lists.xenproject.org Fri May 05 07:06:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 07:06:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530247.825753 (Exim 4.92) (envelope-from ) id 1pupWV-0003fQ-W8; Fri, 05 May 2023 07:06:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530247.825753; Fri, 05 May 2023 07:06:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pupWV-0003fH-TY; Fri, 05 May 2023 07:06:35 +0000 Received: by outflank-mailman (input) for mailman id 530247; Fri, 05 May 2023 07:06:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pupWU-0003f3-U7; Fri, 05 May 2023 07:06:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pupWU-00024s-M1; Fri, 05 May 2023 07:06:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pupWU-00037F-CX; Fri, 05 May 2023 07:06:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pupWU-0006KC-C0; Fri, 05 May 2023 07:06:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rFn4o8+zAAi6yzkB/TxryAda6Zjq1jCidQ/Gt0GSWZY=; b=bsKTxqphoR0YGckec+61IQpjc/ GQbEj2ihjQv1f/JU+G+h79GKPeimuG6GsHj1VJIPFw+wdeeXbvXgWGHVggnhsQe8ROE7eJ7jRT9gN 0oT+LFsbU6TdrjWOSBl2YBZs7xhvSzz6FqQ7oZPokIQY4Q/6z03HoiYMoE0m4Ro66zuM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180538: all pass - PUSHED X-Osstest-Versions-This: ovmf=ff7cb2d7c98f8b832180e054848459fc24a0910a X-Osstest-Versions-That: ovmf=d992a05ade3d1bebc6e7a81aaf700286e0e217c8 From: osstest service owner Date: Fri, 05 May 2023 07:06:34 +0000 flight 180538 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180538/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf ff7cb2d7c98f8b832180e054848459fc24a0910a baseline version: ovmf d992a05ade3d1bebc6e7a81aaf700286e0e217c8 Last test of basis 180535 2023-05-04 19:12:15 Z 0 days Testing same since 180538 2023-05-05 04:12:21 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Benny Lin Pedro Falcato jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git d992a05ade..ff7cb2d7c9 ff7cb2d7c98f8b832180e054848459fc24a0910a -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri May 05 08:24:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 08:24:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530256.825763 (Exim 4.92) (envelope-from ) id 1puqju-00049P-40; Fri, 05 May 2023 08:24:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530256.825763; Fri, 05 May 2023 08:24:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puqju-00049I-01; Fri, 05 May 2023 08:24:30 +0000 Received: by outflank-mailman (input) for mailman id 530256; Fri, 05 May 2023 08:24:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puqjr-000498-GW for xen-devel@lists.xenproject.org; Fri, 05 May 2023 08:24:28 +0000 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [2607:f8b0:4864:20::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3a2b559a-eb1e-11ed-b226-6b7b168915f2; Fri, 05 May 2023 10:24:18 +0200 (CEST) Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1aaf2ede38fso14157385ad.2 for ; Fri, 05 May 2023 01:24:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3a2b559a-eb1e-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683275057; x=1685867057; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=YPzxmB9FIePwlqxtbt/uuMFpqYIeF7DSqLXDc5GDEAs=; b=NcjzHf0UjOD3MJxJNJokdR8VZ3XJ7eyQ+AV1KTriBnIWNIY5sPW263X+JUj7qeQ8+R sglN+hUlW5/tlGBL7d9QmkJ79fdWQAiXEA6043Tu3zzj7MAZbYcEsUJoMgunPNdhEt0N Xu5hhRFEstR+/LnF1+3Zg/wj96Hp8axuHzhPOhLVWw+HNTJnI2ffx/WNpRMVvfYCMAVl xz3GP77AGEfpffHdSiLYt0IhPDYp/AZfioKKC2ejmnofQzMbCI50axMEUCa+31k3/kpi u2ZVYNPVY8SXxfGgArAkmJiyyyFjonwvTUnqgDm0ab5TU+aDziDQkC5U+2DkOwCbiFtV QIeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683275057; x=1685867057; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YPzxmB9FIePwlqxtbt/uuMFpqYIeF7DSqLXDc5GDEAs=; b=eD6V2zTgmivTV7F6L+kQ/JVz5pYXF2cX1zYvDXolPvdW4A96Al94L641aOgR6PIwQS lYYUbopGboZQCZapooi2r53DEhDJ7xOdInS+N1Wjbi62IS+zIAOULqwofW7KqlgIt4yh sLpqR1vfpsdUT2wTqPlYs86ATmoWfKXgNtsB6mzP2P0dyGd6bVYU+HbzIdlk/ChGIiDP mBYhBj27gntTYWq1JWr0uvukHcKoIgYcyRmwPF0TKKGS9uhH2JiUWYipJZUuAChUEHIp 6gN0Xnvfeu33qodUgmZz50Pi+Xw4MRkRU/fkAIG6QwULB8WTjeKrs/zIUs3YHI7QFaL+ AuaQ== X-Gm-Message-State: AC+VfDwdECS6c1ZYn/RZTJgf/HcnccdvtIKrAjM6EG8YslZuswhq2sug K8rAVC0EDO6Xf4GA0db3W9PdI1KPWEiW1eHxM20= X-Google-Smtp-Source: ACHHUZ5Jx4GL90foDMd3kgoy5wNT4T/8jw/xCRc7UpExGsRCZf3jQOoKQGOx0Dsydc8eeU9ffYjgAtzsptEa//4q044= X-Received: by 2002:a17:903:234c:b0:1ab:289f:65cf with SMTP id c12-20020a170903234c00b001ab289f65cfmr740923plh.54.1683275056513; Fri, 05 May 2023 01:24:16 -0700 (PDT) MIME-Version: 1.0 References: <43f5fdaa-47c7-6ec9-c477-dac62a5bceae@amd.com> In-Reply-To: From: Oleg Nikitenko Date: Fri, 5 May 2023 11:28:53 +0300 Message-ID: Subject: Re: xen cache colors in ARM To: Stefano Stabellini Cc: Michal Orzel , Julien Grall , "xen-devel@lists.xenproject.org" , Bertrand Marquis , Carlo Nonato , Stewart.Hildebrand@amd.com Content-Type: multipart/alternative; boundary="000000000000cd85bd05faee032e" --000000000000cd85bd05faee032e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Stefano, I would like to try a xen cache color property from this repo https://xenbits.xen.org/git-http/xen.git Could you tell whot branch I should use ? Regards, Oleg =D0=BF=D1=82, 28 =D0=B0=D0=BF=D1=80. 2023=E2=80=AF=D0=B3. =D0=B2 00:51, Ste= fano Stabellini : > I am familiar with the zcu102 but I don't know how you could possibly > generate a SError. > > I suggest to try to use ImageBuilder [1] to generate the boot > configuration as a test because that is known to work well for zcu102. > > [1] https://gitlab.com/xen-project/imagebuilder > > > On Thu, 27 Apr 2023, Oleg Nikitenko wrote: > > Hello Stefano, > > > > Thanks for clarification. > > We nighter use ImageBuilder nor uboot boot script. > > A model is zcu102 compatible. > > > > Regards, > > O. > > > > =D0=B2=D1=82, 25 =D0=B0=D0=BF=D1=80. 2023=E2=80=AF=D0=B3. =D0=B2 21:21,= Stefano Stabellini >: > > This is interesting. Are you using Xilinx hardware by any chance? > If so, > > which board? > > > > Are you using ImageBuilder to generate your boot.scr boot script? > If so, > > could you please post your ImageBuilder config file? If not, can > you > > post the source of your uboot boot script? > > > > SErrors are supposed to be related to a hardware failure of some > kind. > > You are not supposed to be able to trigger an SError easily by > > "mistake". I have not seen SErrors due to wrong cache coloring > > configurations on any Xilinx board before. > > > > The differences between Xen with and without cache coloring from = a > > hardware perspective are: > > > > - With cache coloring, the SMMU is enabled and does address > translations > > even for dom0. Without cache coloring the SMMU could be > disabled, and > > if enabled, the SMMU doesn't do any address translations for > Dom0. If > > there is a hardware failure related to SMMU address translation > it > > could only trigger with cache coloring. This would be my normal > > suggestion for you to explore, but the failure happens too earl= y > > before any DMA-capable device is programmed. So I don't think > this can > > be the issue. > > > > - With cache coloring, the memory allocation is very different so > you'll > > end up using different DDR regions for Dom0. So if your DDR is > > defective, you might only see a failure with cache coloring > enabled > > because you end up using different regions. > > > > > > On Tue, 25 Apr 2023, Oleg Nikitenko wrote: > > > Hi Stefano, > > > > > > Thank you. > > > If I build xen without colors support there is not this error. > > > All the domains are booted well. > > > Hense it can not be a hardware issue. > > > This panic arrived during unpacking the rootfs. > > > Here I attached the boot log xen/Dom0 without color. > > > A highlighted strings printed exactly after the place where 1-s= t > time panic arrived. > > > > > > Xen 4.16.1-pre > > > (XEN) Xen version 4.16.1-pre (nole2390@(none)) > (aarch64-portable-linux-gcc (GCC) 11.3.0) debug=3Dy 2023-04-21 > > > (XEN) Latest ChangeSet: Wed Apr 19 12:56:14 2023 +0300 > git:321687b231-dirty > > > (XEN) build-id: c1847258fdb1b79562fc710dda40008f96c0fde5 > > > (XEN) Processor: 00000000410fd034: "ARM Limited", variant: 0x0, > part 0xd03,rev 0x4 > > > (XEN) 64-bit Execution: > > > (XEN) Processor Features: 0000000000002222 0000000000000000 > > > (XEN) Exception Levels: EL3:64+32 EL2:64+32 EL1:64+32 > EL0:64+32 > > > (XEN) Extensions: FloatingPoint AdvancedSIMD > > > (XEN) Debug Features: 0000000010305106 0000000000000000 > > > (XEN) Auxiliary Features: 0000000000000000 0000000000000000 > > > (XEN) Memory Model Features: 0000000000001122 000000000000000= 0 > > > (XEN) ISA Features: 0000000000011120 0000000000000000 > > > (XEN) 32-bit Execution: > > > (XEN) Processor Features: 0000000000000131:0000000000011011 > > > (XEN) Instruction Sets: AArch32 A32 Thumb Thumb-2 Jazelle > > > (XEN) Extensions: GenericTimer Security > > > (XEN) Debug Features: 0000000003010066 > > > (XEN) Auxiliary Features: 0000000000000000 > > > (XEN) Memory Model Features: 0000000010201105 000000004000000= 0 > > > (XEN) 0000000001260000 000000000210221= 1 > > > (XEN) ISA Features: 0000000002101110 0000000013112111 > 0000000021232042 > > > (XEN) 0000000001112131 0000000000011142 > 0000000000011121 > > > (XEN) Using SMC Calling Convention v1.2 > > > (XEN) Using PSCI v1.1 > > > (XEN) SMP: Allowing 4 CPUs > > > (XEN) Generic Timer IRQ: phys=3D30 hyp=3D26 virt=3D27 Freq: 100= 000 KHz > > > (XEN) GICv2 initialization: > > > (XEN) gic_dist_addr=3D00000000f9010000 > > > (XEN) gic_cpu_addr=3D00000000f9020000 > > > (XEN) gic_hyp_addr=3D00000000f9040000 > > > (XEN) gic_vcpu_addr=3D00000000f9060000 > > > (XEN) gic_maintenance_irq=3D25 > > > (XEN) GICv2: Adjusting CPU interface base to 0xf902f000 > > > (XEN) GICv2: 192 lines, 4 cpus, secure (IID 0200143b). > > > (XEN) Using scheduler: null Scheduler (null) > > > (XEN) Initializing null scheduler > > > (XEN) WARNING: This is experimental software in development. > > > (XEN) Use at your own risk. > > > (XEN) Allocated console ring of 32 KiB. > > > (XEN) CPU0: Guest atomics will try 12 times before pausing the > domain > > > (XEN) Bringing up CPU1 > > > (XEN) CPU1: Guest atomics will try 13 times before pausing the > domain > > > (XEN) CPU 1 booted. > > > (XEN) Bringing up CPU2 > > > (XEN) CPU2: Guest atomics will try 13 times before pausing the > domain > > > (XEN) CPU 2 booted. > > > (XEN) Bringing up CPU3 > > > (XEN) CPU3: Guest atomics will try 13 times before pausing the > domain > > > (XEN) Brought up 4 CPUs > > > (XEN) CPU 3 booted. > > > (XEN) smmu: /axi/smmu@fd800000: probing hardware > configuration... > > > (XEN) smmu: /axi/smmu@fd800000: SMMUv2 with: > > > (XEN) smmu: /axi/smmu@fd800000: stage 2 translation > > > (XEN) smmu: /axi/smmu@fd800000: stream matching with 48 > register groups, mask 0x7fff<2>smmu: /axi/smmu@fd800000: 16 context > > banks (0 > > > stage-2 only) > > > (XEN) smmu: /axi/smmu@fd800000: Stage-2: 48-bit IPA -> 48-bit P= A > > > (XEN) smmu: /axi/smmu@fd800000: registered 29 master devices > > > (XEN) I/O virtualisation enabled > > > (XEN) - Dom0 mode: Relaxed > > > (XEN) P2M: 40-bit IPA with 40-bit PA and 8-bit VMID > > > (XEN) P2M: 3 levels with order-1 root, VTCR 0x0000000080023558 > > > (XEN) Scheduling granularity: cpu, 1 CPU per sched-resource > > > (XEN) alternatives: Patching with alt table 00000000002cc5c8 -> > 00000000002ccb2c > > > (XEN) *** LOADING DOMAIN 0 *** > > > (XEN) Loading d0 kernel from boot module @ 0000000001000000 > > > (XEN) Loading ramdisk from boot module @ 0000000002000000 > > > (XEN) Allocating 1:1 mappings totalling 1600MB for dom0: > > > (XEN) BANK[0] 0x00000010000000-0x00000020000000 (256MB) > > > (XEN) BANK[1] 0x00000024000000-0x00000028000000 (64MB) > > > (XEN) BANK[2] 0x00000030000000-0x00000080000000 (1280MB) > > > (XEN) Grant table range: 0x00000000e00000-0x00000000e40000 > > > (XEN) smmu: /axi/smmu@fd800000: d0: p2maddr 0x000000087bf94000 > > > (XEN) Allocating PPI 16 for event channel interrupt > > > (XEN) Extended region 0: 0x81200000->0xa0000000 > > > (XEN) Extended region 1: 0xb1200000->0xc0000000 > > > (XEN) Extended region 2: 0xc8000000->0xe0000000 > > > (XEN) Extended region 3: 0xf0000000->0xf9000000 > > > (XEN) Extended region 4: 0x100000000->0x600000000 > > > (XEN) Extended region 5: 0x880000000->0x8000000000 > > > (XEN) Extended region 6: 0x8001000000->0x10000000000 > > > (XEN) Loading zImage from 0000000001000000 to > 0000000010000000-0000000010e41008 > > > (XEN) Loading d0 initrd from 0000000002000000 to > 0x0000000013600000-0x000000001ff3a617 > > > (XEN) Loading d0 DTB to 0x0000000013400000-0x000000001340cbdc > > > (XEN) Initial low memory virq threshold set at 0x4000 pages. > > > (XEN) Std. Loglevel: All > > > (XEN) Guest Loglevel: All > > > (XEN) *** Serial input to DOM0 (type 'CTRL-a' three times to > switch input) > > > (XEN) null.c:353: 0 <-- d0v0 > > > (XEN) Freed 356kB init memory. > > > (XEN) d0v0 Unhandled SMC/HVC: 0x84000050 > > > (XEN) d0v0 Unhandled SMC/HVC: 0x8600ff01 > > > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to > ICACTIVER4 > > > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to > ICACTIVER8 > > > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to > ICACTIVER12 > > > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to > ICACTIVER16 > > > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to > ICACTIVER20 > > > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to > ICACTIVER0 > > > [ 0.000000] Booting Linux on physical CPU 0x0000000000 > [0x410fd034] > > > [ 0.000000] Linux version 5.15.72-xilinx-v2022.1 > (oe-user@oe-host) (aarch64-portable-linux-gcc (GCC) 11.3.0, GNU ld (GNU > > Binutils) > > > 2.38.20220708) #1 SMP Tue Feb 21 05:47:54 UTC 2023 > > > [ 0.000000] Machine model: D14 Viper Board - White Unit > > > [ 0.000000] Xen 4.16 support found > > > [ 0.000000] Zone ranges: > > > [ 0.000000] DMA [mem > 0x0000000010000000-0x000000007fffffff] > > > [ 0.000000] DMA32 empty > > > [ 0.000000] Normal empty > > > [ 0.000000] Movable zone start for each node > > > [ 0.000000] Early memory node ranges > > > [ 0.000000] node 0: [mem > 0x0000000010000000-0x000000001fffffff] > > > [ 0.000000] node 0: [mem > 0x0000000022000000-0x0000000022147fff] > > > [ 0.000000] node 0: [mem > 0x0000000022200000-0x0000000022347fff] > > > [ 0.000000] node 0: [mem > 0x0000000024000000-0x0000000027ffffff] > > > [ 0.000000] node 0: [mem > 0x0000000030000000-0x000000007fffffff] > > > [ 0.000000] Initmem setup node 0 [mem > 0x0000000010000000-0x000000007fffffff] > > > [ 0.000000] On node 0, zone DMA: 8192 pages in unavailable > ranges > > > [ 0.000000] On node 0, zone DMA: 184 pages in unavailable > ranges > > > [ 0.000000] On node 0, zone DMA: 7352 pages in unavailable > ranges > > > [ 0.000000] cma: Reserved 256 MiB at 0x000000006e000000 > > > [ 0.000000] psci: probing for conduit method from DT. > > > [ 0.000000] psci: PSCIv1.1 detected in firmware. > > > [ 0.000000] psci: Using standard PSCI v0.2 function IDs > > > [ 0.000000] psci: Trusted OS migration not required > > > [ 0.000000] psci: SMC Calling Convention v1.1 > > > [ 0.000000] percpu: Embedded 16 pages/cpu s32792 r0 d32744 > u65536 > > > [ 0.000000] Detected VIPT I-cache on CPU0 > > > [ 0.000000] CPU features: kernel page table isolation forced > ON by KASLR > > > [ 0.000000] CPU features: detected: Kernel page table > isolation (KPTI) > > > [ 0.000000] Built 1 zonelists, mobility grouping on. Total > pages: 403845 > > > [ 0.000000] Kernel command line: console=3Dhvc0 earlycon=3Dx= en > earlyprintk=3Dxen clk_ignore_unused fips=3D1 root=3D/dev/ram0 > > maxcpus=3D2 > > > [ 0.000000] Unknown kernel command line parameters > "earlyprintk=3Dxen fips=3D1", will be passed to user space. > > > [ 0.000000] Dentry cache hash table entries: 262144 (order: > 9, 2097152 bytes, linear) > > > [ 0.000000] Inode-cache hash table entries: 131072 (order: 8= , > 1048576 bytes, linear) > > > [ 0.000000] mem auto-init: stack:off, heap alloc:on, heap > free:on > > > [ 0.000000] mem auto-init: clearing system memory may take > some time... > > > [ 0.000000] Memory: 1121936K/1641024K available (9728K kerne= l > code, 836K rwdata, 2396K rodata, 1536K init, 262K bss, > > 256944K reserved, > > > 262144K cma-reserved) > > > [ 0.000000] SLUB: HWalign=3D64, Order=3D0-3, MinObjects=3D0, > CPUs=3D2, Nodes=3D1 > > > [ 0.000000] rcu: Hierarchical RCU implementation. > > > [ 0.000000] rcu: RCU event tracing is enabled. > > > [ 0.000000] rcu: RCU restricting CPUs from NR_CPUS=3D8 to > nr_cpu_ids=3D2. > > > [ 0.000000] rcu: RCU calculated value of scheduler-enlistmen= t > delay is 25 jiffies. > > > [ 0.000000] rcu: Adjusting geometry for rcu_fanout_leaf=3D16= , > nr_cpu_ids=3D2 > > > [ 0.000000] NR_IRQS: 64, nr_irqs: 64, preallocated irqs: 0 > > > [ 0.000000] Root IRQ handler: gic_handle_irq > > > [ 0.000000] arch_timer: cp15 timer(s) running at 100.00MHz > (virt). > > > [ 0.000000] clocksource: arch_sys_counter: mask: > 0xffffffffffffff max_cycles: 0x171024e7e0, max_idle_ns: 440795205315 ns > > > [ 0.000000] sched_clock: 56 bits at 100MHz, resolution 10ns, > wraps every 4398046511100ns > > > [ 0.000258] Console: colour dummy device 80x25 > > > [ 0.310231] printk: console [hvc0] enabled > > > [ 0.314403] Calibrating delay loop (skipped), value > calculated using timer frequency.. 200.00 BogoMIPS (lpj=3D400000) > > > [ 0.324851] pid_max: default: 32768 minimum: 301 > > > [ 0.329706] LSM: Security Framework initializing > > > [ 0.334204] Yama: becoming mindful. > > > [ 0.337865] Mount-cache hash table entries: 4096 (order: 3, > 32768 bytes, linear) > > > [ 0.345180] Mountpoint-cache hash table entries: 4096 (order= : > 3, 32768 bytes, linear) > > > [ 0.354743] xen:grant_table: Grant tables using version 1 > layout > > > [ 0.359132] Grant table initialized > > > [ 0.362664] xen:events: Using FIFO-based ABI > > > [ 0.366993] Xen: initializing cpu0 > > > [ 0.370515] rcu: Hierarchical SRCU implementation. > > > [ 0.375930] smp: Bringing up secondary CPUs ... > > > (XEN) null.c:353: 1 <-- d0v1 > > > (XEN) d0v1: vGICD: unhandled word write 0x000000ffffffff to > ICACTIVER0 > > > [ 0.382549] Detected VIPT I-cache on CPU1 > > > [ 0.388712] Xen: initializing cpu1 > > > [ 0.388743] CPU1: Booted secondary processor 0x0000000001 > [0x410fd034] > > > [ 0.388829] smp: Brought up 1 node, 2 CPUs > > > [ 0.406941] SMP: Total of 2 processors activated. > > > [ 0.411698] CPU features: detected: 32-bit EL0 Support > > > [ 0.416888] CPU features: detected: CRC32 instructions > > > [ 0.422121] CPU: All CPU(s) started at EL1 > > > [ 0.426248] alternatives: patching kernel code > > > [ 0.431424] devtmpfs: initialized > > > [ 0.441454] KASLR enabled > > > [ 0.441602] clocksource: jiffies: mask: 0xffffffff > max_cycles: 0xffffffff, max_idle_ns: 7645041785100000 ns > > > [ 0.448321] futex hash table entries: 512 (order: 3, 32768 > bytes, linear) > > > [ 0.496183] NET: Registered PF_NETLINK/PF_ROUTE protocol > family > > > [ 0.498277] DMA: preallocated 256 KiB GFP_KERNEL pool for > atomic allocations > > > [ 0.503772] DMA: preallocated 256 KiB GFP_KERNEL|GFP_DMA poo= l > for atomic allocations > > > [ 0.511610] DMA: preallocated 256 KiB GFP_KERNEL|GFP_DMA32 > pool for atomic allocations > > > [ 0.519478] audit: initializing netlink subsys (disabled) > > > [ 0.524985] audit: type=3D2000 audit(0.336:1): > state=3Dinitialized audit_enabled=3D0 res=3D1 > > > [ 0.529169] thermal_sys: Registered thermal governor > 'step_wise' > > > [ 0.533023] hw-breakpoint: found 6 breakpoint and 4 > watchpoint registers. > > > [ 0.545608] ASID allocator initialised with 32768 entries > > > [ 0.551030] xen:swiotlb_xen: Warning: only able to allocate = 4 > MB for software IO TLB > > > [ 0.559332] software IO TLB: mapped [mem > 0x0000000011800000-0x0000000011c00000] (4MB) > > > [ 0.583565] HugeTLB registered 1.00 GiB page size, > pre-allocated 0 pages > > > [ 0.584721] HugeTLB registered 32.0 MiB page size, > pre-allocated 0 pages > > > [ 0.591478] HugeTLB registered 2.00 MiB page size, > pre-allocated 0 pages > > > [ 0.598225] HugeTLB registered 64.0 KiB page size, > pre-allocated 0 pages > > > [ 0.636520] DRBG: Continuing without Jitter RNG > > > [ 0.737187] raid6: neonx8 gen() 2143 MB/s > > > [ 0.805294] raid6: neonx8 xor() 1589 MB/s > > > [ 0.873406] raid6: neonx4 gen() 2177 MB/s > > > [ 0.941499] raid6: neonx4 xor() 1556 MB/s > > > [ 1.009612] raid6: neonx2 gen() 2072 MB/s > > > [ 1.077715] raid6: neonx2 xor() 1430 MB/s > > > [ 1.145834] raid6: neonx1 gen() 1769 MB/s > > > [ 1.213935] raid6: neonx1 xor() 1214 MB/s > > > [ 1.282046] raid6: int64x8 gen() 1366 MB/s > > > [ 1.350132] raid6: int64x8 xor() 773 MB/s > > > [ 1.418259] raid6: int64x4 gen() 1602 MB/s > > > [ 1.486349] raid6: int64x4 xor() 851 MB/s > > > [ 1.554464] raid6: int64x2 gen() 1396 MB/s > > > [ 1.622561] raid6: int64x2 xor() 744 MB/s > > > [ 1.690687] raid6: int64x1 gen() 1033 MB/s > > > [ 1.758770] raid6: int64x1 xor() 517 MB/s > > > [ 1.758809] raid6: using algorithm neonx4 gen() 2177 MB/s > > > [ 1.762941] raid6: .... xor() 1556 MB/s, rmw enabled > > > [ 1.767957] raid6: using neon recovery algorithm > > > [ 1.772824] xen:balloon: Initialising balloon driver > > > [ 1.778021] iommu: Default domain type: Translated > > > [ 1.782584] iommu: DMA domain TLB invalidation policy: stric= t > mode > > > [ 1.789149] SCSI subsystem initialized > > > [ 1.792820] usbcore: registered new interface driver usbfs > > > [ 1.798254] usbcore: registered new interface driver hub > > > [ 1.803626] usbcore: registered new device driver usb > > > [ 1.808761] pps_core: LinuxPPS API ver. 1 registered > > > [ 1.813716] pps_core: Software ver. 5.3.6 - Copyright > 2005-2007 Rodolfo Giometti > > > [ 1.822903] PTP clock support registered > > > [ 1.826893] EDAC MC: Ver: 3.0.0 > > > [ 1.830375] zynqmp-ipi-mbox mailbox@ff990400: Registered > ZynqMP IPI mbox with TX/RX channels. > > > [ 1.838863] zynqmp-ipi-mbox mailbox@ff990600: Registered > ZynqMP IPI mbox with TX/RX channels. > > > [ 1.847356] zynqmp-ipi-mbox mailbox@ff990800: Registered > ZynqMP IPI mbox with TX/RX channels. > > > [ 1.855907] FPGA manager framework > > > [ 1.859952] clocksource: Switched to clocksource > arch_sys_counter > > > [ 1.871712] NET: Registered PF_INET protocol family > > > [ 1.871838] IP idents hash table entries: 32768 (order: 6, > 262144 bytes, linear) > > > [ 1.879392] tcp_listen_portaddr_hash hash table entries: 102= 4 > (order: 2, 16384 bytes, linear) > > > [ 1.887078] Table-perturb hash table entries: 65536 (order: > 6, 262144 bytes, linear) > > > [ 1.894846] TCP established hash table entries: 16384 (order= : > 5, 131072 bytes, linear) > > > [ 1.902900] TCP bind hash table entries: 16384 (order: 6, > 262144 bytes, linear) > > > [ 1.910350] TCP: Hash tables configured (established 16384 > bind 16384) > > > [ 1.916778] UDP hash table entries: 1024 (order: 3, 32768 > bytes, linear) > > > [ 1.923509] UDP-Lite hash table entries: 1024 (order: 3, > 32768 bytes, linear) > > > [ 1.930759] NET: Registered PF_UNIX/PF_LOCAL protocol family > > > [ 1.936834] RPC: Registered named UNIX socket transport > module. > > > [ 1.942342] RPC: Registered udp transport module. > > > [ 1.947088] RPC: Registered tcp transport module. > > > [ 1.951843] RPC: Registered tcp NFSv4.1 backchannel transpor= t > module. > > > [ 1.958334] PCI: CLS 0 bytes, default 64 > > > [ 1.962709] Trying to unpack rootfs image as initramfs... > > > [ 1.977090] workingset: timestamp_bits=3D62 max_order=3D19 > bucket_order=3D0 > > > [ 1.982863] Installing knfsd (copyright (C) 1996 > okir@monad.swb.de). > > > [ 2.021045] NET: Registered PF_ALG protocol family > > > [ 2.021122] xor: measuring software checksum speed > > > [ 2.029347] 8regs : 2366 MB/sec > > > [ 2.033081] 32regs : 2802 MB/sec > > > [ 2.038223] arm64_neon : 2320 MB/sec > > > [ 2.038385] xor: using function: 32regs (2802 MB/sec) > > > [ 2.043614] Block layer SCSI generic (bsg) driver version 0.= 4 > loaded (major 247) > > > [ 2.050959] io scheduler mq-deadline registered > > > [ 2.055521] io scheduler kyber registered > > > [ 2.068227] xen:xen_evtchn: Event-channel device installed > > > [ 2.069281] Serial: 8250/16550 driver, 4 ports, IRQ sharing > disabled > > > [ 2.076190] cacheinfo: Unable to detect cache hierarchy for > CPU 0 > > > [ 2.085548] brd: module loaded > > > [ 2.089290] loop: module loaded > > > [ 2.089341] Invalid max_queues (4), will use default max: 2. > > > [ 2.094565] tun: Universal TUN/TAP device driver, 1.6 > > > [ 2.098655] xen_netfront: Initialising Xen virtual ethernet > driver > > > [ 2.104156] usbcore: registered new interface driver rtl8150 > > > [ 2.109813] usbcore: registered new interface driver r8152 > > > [ 2.115367] usbcore: registered new interface driver asix > > > [ 2.120794] usbcore: registered new interface driver > ax88179_178a > > > [ 2.126934] usbcore: registered new interface driver cdc_eth= er > > > [ 2.132816] usbcore: registered new interface driver cdc_eem > > > [ 2.138527] usbcore: registered new interface driver net1080 > > > [ 2.144256] usbcore: registered new interface driver > cdc_subset > > > [ 2.150205] usbcore: registered new interface driver zaurus > > > [ 2.155837] usbcore: registered new interface driver cdc_ncm > > > [ 2.161550] usbcore: registered new interface driver r8153_e= cm > > > [ 2.168240] usbcore: registered new interface driver cdc_acm > > > [ 2.173109] cdc_acm: USB Abstract Control Model driver for > USB modems and ISDN adapters > > > [ 2.181358] usbcore: registered new interface driver uas > > > [ 2.186547] usbcore: registered new interface driver > usb-storage > > > [ 2.192643] usbcore: registered new interface driver ftdi_si= o > > > [ 2.198384] usbserial: USB Serial support registered for FTD= I > USB Serial Device > > > [ 2.206118] udc-core: couldn't find an available UDC - added > [g_mass_storage] to list of pending drivers > > > [ 2.215332] i2c_dev: i2c /dev entries driver > > > [ 2.220467] xen_wdt xen_wdt: initialized (timeout=3D60s, > nowayout=3D0) > > > [ 2.225923] device-mapper: uevent: version 1.0.3 > > > [ 2.230668] device-mapper: ioctl: 4.45.0-ioctl (2021-03-22) > initialised: dm-devel@redhat.com > > > [ 2.239315] EDAC MC0: Giving out device to module 1 > controller synps_ddr_controller: DEV synps_edac (INTERRUPT) > > > [ 2.249405] EDAC DEVICE0: Giving out device to module > zynqmp-ocm-edac controller zynqmp_ocm: DEV > > ff960000.memory-controller (INTERRUPT) > > > [ 2.261719] sdhci: Secure Digital Host Controller Interface > driver > > > [ 2.267487] sdhci: Copyright(c) Pierre Ossman > > > [ 2.271890] sdhci-pltfm: SDHCI platform and OF driver helper > > > [ 2.278157] ledtrig-cpu: registered to indicate activity on > CPUs > > > [ 2.283816] zynqmp_firmware_probe Platform Management API v1= .1 > > > [ 2.289554] zynqmp_firmware_probe Trustzone version v1.0 > > > [ 2.327875] securefw securefw: securefw probed > > > [ 2.328324] alg: No test for xilinx-zynqmp-aes (zynqmp-aes) > > > [ 2.332563] zynqmp_aes firmware:zynqmp-firmware:zynqmp-aes: > AES Successfully Registered > > > [ 2.341183] alg: No test for xilinx-zynqmp-rsa (zynqmp-rsa) > > > [ 2.347667] remoteproc remoteproc0: ff9a0000.rf5ss:r5f_0 is > available > > > [ 2.353003] remoteproc remoteproc1: ff9a0000.rf5ss:r5f_1 is > available > > > [ 2.362605] fpga_manager fpga0: Xilinx ZynqMP FPGA Manager > registered > > > [ 2.366540] viper-xen-proxy viper-xen-proxy: Viper Xen Proxy > registered > > > [ 2.372525] viper-vdpp a4000000.vdpp: Device Tree Probing > > > [ 2.377778] viper-vdpp a4000000.vdpp: VDPP Version: 1.3.9.0 > Info: 1.512.15.0 KeyLen: 32 > > > [ 2.386432] viper-vdpp a4000000.vdpp: Unable to register > tamper handler. Retrying... > > > [ 2.394094] viper-vdpp-net a5000000.vdpp_net: Device Tree > Probing > > > [ 2.399854] viper-vdpp-net a5000000.vdpp_net: Device > registered > > > [ 2.405931] viper-vdpp-stat a8000000.vdpp_stat: Device Tree > Probing > > > [ 2.412037] viper-vdpp-stat a8000000.vdpp_stat: Build > parameters: VTI Count: 512 Event Count: 32 > > > [ 2.420856] default preset > > > [ 2.423797] viper-vdpp-stat a8000000.vdpp_stat: Device > registered > > > [ 2.430054] viper-vdpp-rng ac000000.vdpp_rng: Device Tree > Probing > > > [ 2.435948] viper-vdpp-rng ac000000.vdpp_rng: Device > registered > > > [ 2.441976] vmcu driver init > > > [ 2.444922] VMCU: : (240:0) registered > > > [ 2.444956] In K81 Updater init > > > [ 2.449003] pktgen: Packet Generator for packet performance > testing. Version: 2.75 > > > [ 2.468833] Initializing XFRM netlink socket > > > [ 2.468902] NET: Registered PF_PACKET protocol family > > > [ 2.472729] Bridge firewalling registered > > > [ 2.476785] 8021q: 802.1Q VLAN Support v1.8 > > > [ 2.481341] registered taskstats version 1 > > > [ 2.486394] Btrfs loaded, crc32c=3Dcrc32c-generic, zoned=3Dn= o, > fsverity=3Dno > > > [ 2.503145] ff010000.serial: ttyPS1 at MMIO 0xff010000 (irq = =3D > 36, base_baud =3D 6250000) is a xuartps > > > [ 2.507103] of-fpga-region fpga-full: FPGA Region probed > > > [ 2.512986] xilinx-zynqmp-dma fd500000.dma-controller: ZynqM= P > DMA driver Probe success > > > [ 2.520267] xilinx-zynqmp-dma fd510000.dma-controller: ZynqM= P > DMA driver Probe success > > > [ 2.528239] xilinx-zynqmp-dma fd520000.dma-controller: ZynqM= P > DMA driver Probe success > > > [ 2.536152] xilinx-zynqmp-dma fd530000.dma-controller: ZynqM= P > DMA driver Probe success > > > [ 2.544153] xilinx-zynqmp-dma fd540000.dma-controller: ZynqM= P > DMA driver Probe success > > > [ 2.552127] xilinx-zynqmp-dma fd550000.dma-controller: ZynqM= P > DMA driver Probe success > > > [ 2.560178] xilinx-zynqmp-dma ffa80000.dma-controller: ZynqM= P > DMA driver Probe success > > > [ 2.567987] xilinx-zynqmp-dma ffa90000.dma-controller: ZynqM= P > DMA driver Probe success > > > [ 2.576018] xilinx-zynqmp-dma ffaa0000.dma-controller: ZynqM= P > DMA driver Probe success > > > [ 2.583889] xilinx-zynqmp-dma ffab0000.dma-controller: ZynqM= P > DMA driver Probe success > > > [ 2.946379] spi-nor spi0.0: mt25qu512a (131072 Kbytes) > > > [ 2.946467] 2 fixed-partitions partitions found on MTD devic= e > spi0.0 > > > [ 2.952393] Creating 2 MTD partitions on "spi0.0": > > > [ 2.957231] 0x000004000000-0x000008000000 : "bank A" > > > [ 2.963332] 0x000000000000-0x000004000000 : "bank B" > > > [ 2.968694] macb ff0b0000.ethernet: Not enabling partial > store and forward > > > [ 2.975333] macb ff0b0000.ethernet eth0: Cadence GEM rev > 0x50070106 at 0xff0b0000 irq 25 (18:41:fe:0f:ff:02) > > > [ 2.984472] macb ff0c0000.ethernet: Not enabling partial > store and forward > > > [ 2.992144] macb ff0c0000.ethernet eth1: Cadence GEM rev > 0x50070106 at 0xff0c0000 irq 26 (18:41:fe:0f:ff:03) > > > [ 3.001043] viper_enet viper_enet: Viper power GPIOs > initialised > > > [ 3.007313] viper_enet viper_enet vnet0 (uninitialized): > Validate interface QSGMII > > > [ 3.014914] viper_enet viper_enet vnet1 (uninitialized): > Validate interface QSGMII > > > [ 3.022138] viper_enet viper_enet vnet1 (uninitialized): > Validate interface type 18 > > > [ 3.030274] viper_enet viper_enet vnet2 (uninitialized): > Validate interface QSGMII > > > [ 3.037785] viper_enet viper_enet vnet3 (uninitialized): > Validate interface QSGMII > > > [ 3.045301] viper_enet viper_enet: Viper enet registered > > > [ 3.050958] xilinx-axipmon ffa00000.perf-monitor: Probed > Xilinx APM > > > [ 3.057135] xilinx-axipmon fd0b0000.perf-monitor: Probed > Xilinx APM > > > [ 3.063538] xilinx-axipmon fd490000.perf-monitor: Probed > Xilinx APM > > > [ 3.069920] xilinx-axipmon ffa10000.perf-monitor: Probed > Xilinx APM > > > [ 3.097729] si70xx: probe of 2-0040 failed with error -5 > > > [ 3.098042] cdns-wdt fd4d0000.watchdog: Xilinx Watchdog Time= r > with timeout 60s > > > [ 3.105111] cdns-wdt ff150000.watchdog: Xilinx Watchdog Time= r > with timeout 10s > > > [ 3.112457] viper-tamper viper-tamper: Device registered > > > [ 3.117593] active_bank active_bank: boot bank: 1 > > > [ 3.122184] active_bank active_bank: boot mode: (0x02) qspi3= 2 > > > [ 3.128247] viper-vdpp a4000000.vdpp: Device Tree Probing > > > [ 3.133439] viper-vdpp a4000000.vdpp: VDPP Version: 1.3.9.0 > Info: 1.512.15.0 KeyLen: 32 > > > [ 3.142151] viper-vdpp a4000000.vdpp: Tamper handler > registered > > > [ 3.147438] viper-vdpp a4000000.vdpp: Device registered > > > [ 3.153007] lpc55_l2 spi1.0: registered handler for protocol= 0 > > > [ 3.158582] lpc55_user lpc55_user: The major number for your > device is 236 > > > [ 3.165976] lpc55_l2 spi1.0: registered handler for protocol= 1 > > > [ 3.181999] rtc-lpc55 rtc_lpc55: lpc55_rtc_get_time: bad > result: 1 > > > [ 3.182856] rtc-lpc55 rtc_lpc55: registered as rtc0 > > > [ 3.188656] lpc55_l2 spi1.0: (2) mcu still not ready? > > > [ 3.193744] lpc55_l2 spi1.0: (3) mcu still not ready? > > > [ 3.198848] lpc55_l2 spi1.0: (4) mcu still not ready? > > > [ 3.202932] mmc0: SDHCI controller on ff160000.mmc > [ff160000.mmc] using ADMA 64-bit > > > [ 3.210689] lpc55_l2 spi1.0: (5) mcu still not ready? > > > [ 3.215694] lpc55_l2 spi1.0: rx error: -110 > > > [ 3.284438] mmc0: new HS200 MMC card at address 0001 > > > [ 3.285179] mmcblk0: mmc0:0001 SEM16G 14.6 GiB > > > [ 3.291784] mmcblk0: p1 p2 p3 p4 p5 p6 p7 p8 > > > [ 3.293915] mmcblk0boot0: mmc0:0001 SEM16G 4.00 MiB > > > [ 3.299054] mmcblk0boot1: mmc0:0001 SEM16G 4.00 MiB > > > [ 3.303905] mmcblk0rpmb: mmc0:0001 SEM16G 4.00 MiB, chardev > (244:0) > > > [ 3.582676] rtc-lpc55 rtc_lpc55: lpc55_rtc_get_time: bad > result: 1 > > > [ 3.583332] rtc-lpc55 rtc_lpc55: hctosys: unable to read the > hardware clock > > > [ 3.591252] cdns-i2c ff020000.i2c: recovery information > complete > > > [ 3.597085] at24 0-0050: supply vcc not found, using dummy > regulator > > > [ 3.603011] lpc55_l2 spi1.0: (2) mcu still not ready? > > > [ 3.608093] at24 0-0050: 256 byte spd EEPROM, read-only > > > [ 3.613620] lpc55_l2 spi1.0: (3) mcu still not ready? > > > [ 3.619362] lpc55_l2 spi1.0: (4) mcu still not ready? > > > [ 3.624224] rtc-rv3028 0-0052: registered as rtc1 > > > [ 3.628343] lpc55_l2 spi1.0: (5) mcu still not ready? > > > [ 3.633253] lpc55_l2 spi1.0: rx error: -110 > > > [ 3.639104] k81_bootloader 0-0010: probe > > > [ 3.641628] VMCU: : (235:0) registered > > > [ 3.641635] k81_bootloader 0-0010: probe completed > > > [ 3.668346] cdns-i2c ff020000.i2c: 400 kHz mmio ff020000 irq > 28 > > > [ 3.669154] cdns-i2c ff030000.i2c: recovery information > complete > > > [ 3.675412] lm75 1-0048: supply vs not found, using dummy > regulator > > > [ 3.682920] lm75 1-0048: hwmon1: sensor 'tmp112' > > > [ 3.686548] i2c i2c-1: Added multiplexed i2c bus 3 > > > [ 3.690795] i2c i2c-1: Added multiplexed i2c bus 4 > > > [ 3.695629] i2c i2c-1: Added multiplexed i2c bus 5 > > > [ 3.700492] i2c i2c-1: Added multiplexed i2c bus 6 > > > [ 3.705157] pca954x 1-0070: registered 4 multiplexed busses > for I2C switch pca9546 > > > [ 3.713049] at24 1-0054: supply vcc not found, using dummy > regulator > > > [ 3.720067] at24 1-0054: 1024 byte 24c08 EEPROM, read-only > > > [ 3.724761] cdns-i2c ff030000.i2c: 100 kHz mmio ff030000 irq > 29 > > > [ 3.731272] sfp viper_enet:sfp-eth1: Host maximum power 2.0W > > > [ 3.737549] sfp_register_socket: got sfp_bus > > > [ 3.740709] sfp_register_socket: register sfp_bus > > > [ 3.745459] sfp_register_bus: ops ok! > > > [ 3.749179] sfp_register_bus: Try to attach > > > [ 3.753419] sfp_register_bus: Attach succeeded > > > [ 3.757914] sfp_register_bus: upstream ops attach > > > [ 3.762677] sfp_register_bus: Bus registered > > > [ 3.766999] sfp_register_socket: register sfp_bus succeeded > > > [ 3.775870] of_cfs_init > > > [ 3.776000] of_cfs_init: OK > > > [ 3.778211] clk: Not disabling unused clocks > > > [ 11.278477] Freeing initrd memory: 206056K > > > [ 11.279406] Freeing unused kernel memory: 1536K > > > [ 11.314006] Checked W+X mappings: passed, no W+X pages found > > > [ 11.314142] Run /init as init process > > > INIT: version 3.01 booting > > > fsck (busybox 1.35.0) > > > /dev/mmcblk0p1: clean, 12/102400 files, 238162/409600 blocks > > > /dev/mmcblk0p2: clean, 12/102400 files, 171972/409600 blocks > > > /dev/mmcblk0p3 was not cleanly unmounted, check forced. > > > /dev/mmcblk0p3: 20/4096 files (0.0% non-contiguous), 663/16384 > blocks > > > [ 11.553073] EXT4-fs (mmcblk0p3): mounted filesystem without > journal. Opts: (null). Quota mode: disabled. > > > Starting random number generator daemon. > > > [ 11.580662] random: crng init done > > > Starting udev > > > [ 11.613159] udevd[142]: starting version 3.2.10 > > > [ 11.620385] udevd[143]: starting eudev-3.2.10 > > > [ 11.704481] macb ff0b0000.ethernet control_red: renamed from > eth0 > > > [ 11.720264] macb ff0c0000.ethernet control_black: renamed > from eth1 > > > [ 12.063396] ip_local_port_range: prefer different parity for > start/end values. > > > [ 12.084801] rtc-lpc55 rtc_lpc55: lpc55_rtc_get_time: bad > result: 1 > > > hwclock: RTC_RD_TIME: Invalid exchange > > > Mon Feb 27 08:40:53 UTC 2023 > > > [ 12.115309] rtc-lpc55 rtc_lpc55: lpc55_rtc_set_time: bad > result > > > hwclock: RTC_SET_TIME: Invalid exchange > > > [ 12.131027] rtc-lpc55 rtc_lpc55: lpc55_rtc_get_time: bad > result: 1 > > > Starting mcud > > > INIT: Entering runlevel: 5 > > > Configuring network interfaces... done. > > > resetting network interface > > > [ 12.718295] macb ff0b0000.ethernet control_red: PHY > [ff0b0000.ethernet-ffffffff:02] driver [Xilinx PCS/PMA PHY] (irq=3DPOLL) > > > [ 12.723919] macb ff0b0000.ethernet control_red: configuring > for phy/gmii link mode > > > [ 12.732151] pps pps0: new PPS source ptp0 > > > [ 12.735563] macb ff0b0000.ethernet: gem-ptp-timer ptp clock > registered. > > > [ 12.745724] macb ff0c0000.ethernet control_black: PHY > [ff0c0000.ethernet-ffffffff:01] driver [Xilinx PCS/PMA PHY] > > (irq=3DPOLL) > > > [ 12.753469] macb ff0c0000.ethernet control_black: configurin= g > for phy/gmii link mode > > > [ 12.761804] pps pps1: new PPS source ptp1 > > > [ 12.765398] macb ff0c0000.ethernet: gem-ptp-timer ptp clock > registered. > > > Auto-negotiation: off > > > Auto-negotiation: off > > > [ 16.828151] macb ff0b0000.ethernet control_red: unable to > generate target frequency: 125000000 Hz > > > [ 16.834553] macb ff0b0000.ethernet control_red: Link is Up - > 1Gbps/Full - flow control off > > > [ 16.860552] macb ff0c0000.ethernet control_black: unable to > generate target frequency: 125000000 Hz > > > [ 16.867052] macb ff0c0000.ethernet control_black: Link is Up > - 1Gbps/Full - flow control off > > > Starting Failsafe Secure Shell server in port 2222: sshd > > > done. > > > Starting rpcbind daemon...done. > > > > > > [ 17.093019] rtc-lpc55 rtc_lpc55: lpc55_rtc_get_time: bad > result: 1 > > > hwclock: RTC_RD_TIME: Invalid exchange > > > Starting State Manager Service > > > Start state-manager restarter... > > > (XEN) d0v1 Forwarding AES operation: 3254779951 > > > Starting /usr/sbin/xenstored....[ 17.265256] BTRFS: device > fsid 80efc224-c202-4f8e-a949-4dae7f04a0aa devid 1 transid 744 > > /dev/dm-0 > > > scanned by udevd (385) > > > [ 17.349933] BTRFS info (device dm-0): disk space caching is > enabled > > > [ 17.350670] BTRFS info (device dm-0): has skinny extents > > > [ 17.364384] BTRFS info (device dm-0): enabling ssd > optimizations > > > [ 17.830462] BTRFS: device fsid > 27ff666b-f4e5-4f90-9054-c210db5b2e2e devid 1 transid 6 > /dev/mapper/client_prov scanned by > > mkfs.btrfs > > > (526) > > > [ 17.872699] BTRFS info (device dm-1): using free space tree > > > [ 17.872771] BTRFS info (device dm-1): has skinny extents > > > [ 17.878114] BTRFS info (device dm-1): flagging fs with big > metadata feature > > > [ 17.894289] BTRFS info (device dm-1): enabling ssd > optimizations > > > [ 17.895695] BTRFS info (device dm-1): checking UUID tree > > > > > > Setting domain 0 name, domid and JSON config... > > > Done setting up Dom0 > > > Starting xenconsoled... > > > Starting QEMU as disk backend for dom0 > > > Starting domain watchdog daemon: xenwatchdogd startup > > > > > > [ 18.408647] BTRFS: device fsid > 5e08d5e9-bc2a-46b9-af6a-44c7087b8921 devid 1 transid 6 > /dev/mapper/client_config scanned by > > mkfs.btrfs > > > (574) > > > [done] > > > [ 18.465552] BTRFS info (device dm-2): using free space tree > > > [ 18.465629] BTRFS info (device dm-2): has skinny extents > > > [ 18.471002] BTRFS info (device dm-2): flagging fs with big > metadata feature > > > Starting crond: [ 18.482371] BTRFS info (device dm-2): > enabling ssd optimizations > > > [ 18.486659] BTRFS info (device dm-2): checking UUID tree > > > OK > > > starting rsyslogd ... Log partition ready after 0 poll loops > > > done > > > rsyslogd: cannot connect to 172.18.0.1:514: Network is > unreachable [v8.2208.0 try https://www.rsyslog.com/e/2027 ] > > > [ 18.670637] BTRFS: device fsid > 39d7d9e1-967d-478e-94ae-690deb722095 devid 1 transid 608 /dev/dm-3 scanne= d > by udevd (518) > > > > > > Please insert USB token and enter your role in login prompt. > > > > > > login: > > > > > > Regards, > > > O. > > > > > > > > > =D0=BF=D0=BD, 24 =D0=B0=D0=BF=D1=80. 2023=E2=80=AF=D0=B3. =D0= =B2 23:39, Stefano Stabellini < > sstabellini@kernel.org>: > > > Hi Oleg, > > > > > > Here is the issue from your logs: > > > > > > SError Interrupt on CPU0, code 0xbe000000 -- SError > > > > > > SErrors are special signals to notify software of serious > hardware > > > errors. Something is going very wrong. Defective hardwar= e > is a > > > possibility. Another possibility if software accessing > address ranges > > > that it is not supposed to, sometimes it causes SErrors. > > > > > > Cheers, > > > > > > Stefano > > > > > > > > > > > > On Mon, 24 Apr 2023, Oleg Nikitenko wrote: > > > > > > > Hello, > > > > > > > > Thanks guys. > > > > I found out where the problem was. > > > > Now dom0 booted more. But I have a new one. > > > > This is a kernel panic during Dom0 loading. > > > > Maybe someone is able to suggest something ? > > > > > > > > Regards, > > > > O. > > > > > > > > [ 3.771362] sfp_register_bus: upstream ops attach > > > > [ 3.776119] sfp_register_bus: Bus registered > > > > [ 3.780459] sfp_register_socket: register sfp_bus > succeeded > > > > [ 3.789399] of_cfs_init > > > > [ 3.789499] of_cfs_init: OK > > > > [ 3.791685] clk: Not disabling unused clocks > > > > [ 11.010355] SError Interrupt on CPU0, code 0xbe00000= 0 > -- SError > > > > [ 11.010380] CPU: 0 PID: 9 Comm: kworker/u4:0 Not > tainted 5.15.72-xilinx-v2022.1 #1 > > > > [ 11.010393] Workqueue: events_unbound > async_run_entry_fn > > > > [ 11.010414] pstate: 60000005 (nZCv daif -PAN -UAO > -TCO -DIT -SSBS BTYPE=3D--) > > > > [ 11.010422] pc : simple_write_end+0xd0/0x130 > > > > [ 11.010431] lr : generic_perform_write+0x118/0x1e0 > > > > [ 11.010438] sp : ffffffc00809b910 > > > > [ 11.010441] x29: ffffffc00809b910 x28: > 0000000000000000 x27: ffffffef69ba88c0 > > > > [ 11.010451] x26: 0000000000003eec x25: > ffffff807515db00 x24: 0000000000000000 > > > > [ 11.010459] x23: ffffffc00809ba90 x22: > 0000000002aac000 x21: ffffff807315a260 > > > > [ 11.010472] x20: 0000000000001000 x19: > fffffffe02000000 x18: 0000000000000000 > > > > [ 11.010481] x17: 00000000ffffffff x16: > 0000000000008000 x15: 0000000000000000 > > > > [ 11.010490] x14: 0000000000000000 x13: > 0000000000000000 x12: 0000000000000000 > > > > [ 11.010498] x11: 0000000000000000 x10: > 0000000000000000 x9 : 0000000000000000 > > > > [ 11.010507] x8 : 0000000000000000 x7 : > ffffffef693ba680 x6 : 000000002d89b700 > > > > [ 11.010515] x5 : fffffffe02000000 x4 : > ffffff807315a3c8 x3 : 0000000000001000 > > > > [ 11.010524] x2 : 0000000002aab000 x1 : > 0000000000000001 x0 : 0000000000000005 > > > > [ 11.010534] Kernel panic - not syncing: Asynchronous > SError Interrupt > > > > [ 11.010539] CPU: 0 PID: 9 Comm: kworker/u4:0 Not > tainted 5.15.72-xilinx-v2022.1 #1 > > > > [ 11.010545] Hardware name: D14 Viper Board - White > Unit (DT) > > > > [ 11.010548] Workqueue: events_unbound > async_run_entry_fn > > > > [ 11.010556] Call trace: > > > > [ 11.010558] dump_backtrace+0x0/0x1c4 > > > > [ 11.010567] show_stack+0x18/0x2c > > > > [ 11.010574] dump_stack_lvl+0x7c/0xa0 > > > > [ 11.010583] dump_stack+0x18/0x34 > > > > [ 11.010588] panic+0x14c/0x2f8 > > > > [ 11.010597] print_tainted+0x0/0xb0 > > > > [ 11.010606] arm64_serror_panic+0x6c/0x7c > > > > [ 11.010614] do_serror+0x28/0x60 > > > > [ 11.010621] el1h_64_error_handler+0x30/0x50 > > > > [ 11.010628] el1h_64_error+0x78/0x7c > > > > [ 11.010633] simple_write_end+0xd0/0x130 > > > > [ 11.010639] generic_perform_write+0x118/0x1e0 > > > > [ 11.010644] __generic_file_write_iter+0x138/0x1c4 > > > > [ 11.010650] generic_file_write_iter+0x78/0xd0 > > > > [ 11.010656] __kernel_write+0xfc/0x2ac > > > > [ 11.010665] kernel_write+0x88/0x160 > > > > [ 11.010673] xwrite+0x44/0x94 > > > > [ 11.010680] do_copy+0xa8/0x104 > > > > [ 11.010686] write_buffer+0x38/0x58 > > > > [ 11.010692] flush_buffer+0x4c/0xbc > > > > [ 11.010698] __gunzip+0x280/0x310 > > > > [ 11.010704] gunzip+0x1c/0x28 > > > > [ 11.010709] unpack_to_rootfs+0x170/0x2b0 > > > > [ 11.010715] do_populate_rootfs+0x80/0x164 > > > > [ 11.010722] async_run_entry_fn+0x48/0x164 > > > > [ 11.010728] process_one_work+0x1e4/0x3a0 > > > > [ 11.010736] worker_thread+0x7c/0x4c0 > > > > [ 11.010743] kthread+0x120/0x130 > > > > [ 11.010750] ret_from_fork+0x10/0x20 > > > > [ 11.010757] SMP: stopping secondary CPUs > > > > [ 11.010784] Kernel Offset: 0x2f61200000 from > 0xffffffc008000000 > > > > [ 11.010788] PHYS_OFFSET: 0x0 > > > > [ 11.010790] CPU features: 0x00000401,00000842 > > > > [ 11.010795] Memory Limit: none > > > > [ 11.277509] ---[ end Kernel panic - not syncing: > Asynchronous SError Interrupt ]--- > > > > > > > > =D0=BF=D1=82, 21 =D0=B0=D0=BF=D1=80. 2023=E2=80=AF=D0= =B3. =D0=B2 15:52, Michal Orzel < > michal.orzel@amd.com>: > > > > Hi Oleg, > > > > > > > > On 21/04/2023 14:49, Oleg Nikitenko wrote: > > > > > > > > > > > > > > > > > > > > Hello Michal, > > > > > > > > > > I was not able to enable earlyprintk in the xen > for now. > > > > > I decided to choose another way. > > > > > This is a xen's command line that I found out > completely. > > > > > > > > > > (XEN) $$$$ console=3Ddtuart dtuart=3Dserial0 > dom0_mem=3D1600M dom0_max_vcpus=3D2 dom0_vcpus_pin bootscrub=3D0 > > vwfi=3Dnative > > > sched=3Dnull > > > > timer_slop=3D0 > > > > Yes, adding a printk() in Xen was also a good ide= a. > > > > > > > > > > > > > > So you are absolutely right about a command lin= e. > > > > > Now I am going to find out why xen did not have > the correct parameters from the device tree. > > > > Maybe you will find this document helpful: > > > > > https://github.com/Xilinx/xen/blob/xlnx_rebase_4.16/docs/misc/arm/device-= tree/booting.txt > > > > > > > > ~Michal > > > > > > > > > > > > > > Regards, > > > > > Oleg > > > > > > > > > > =D0=BF=D1=82, 21 =D0=B0=D0=BF=D1=80. 2023=E2=80= =AF=D0=B3. =D0=B2 11:16, Michal Orzel < > michal.orzel@amd.com >: > > > > > > > > > > > > > > > On 21/04/2023 10:04, Oleg Nikitenko wrote: > > > > > > > > > > > > > > > > > > > > > > > > Hello Michal, > > > > > > > > > > > > Yes, I use yocto. > > > > > > > > > > > > Yesterday all day long I tried to follow > your suggestions. > > > > > > I faced a problem. > > > > > > Manually in the xen config build file I > pasted the strings: > > > > > In the .config file or in some Yocto file > (listing additional Kconfig options) added to SRC_URI? > > > > > You shouldn't really modify .config file bu= t > if you do, you should execute "make olddefconfig" > > afterwards. > > > > > > > > > > > > > > > > > CONFIG_EARLY_PRINTK > > > > > > CONFIG_EARLY_PRINTK_ZYNQMP > > > > > > CONFIG_EARLY_UART_CHOICE_CADENCE > > > > > I hope you added =3Dy to them. > > > > > > > > > > Anyway, you have at least the following > solutions: > > > > > 1) Run bitbake xen -c menuconfig to properl= y > set early printk > > > > > 2) Find out how you enable other Kconfig > options in your project (e.g. CONFIG_COLORING=3Dy that is not > > enabled by > > > default) > > > > > 3) Append the following to > "xen/arch/arm/configs/arm64_defconfig": > > > > > CONFIG_EARLY_PRINTK_ZYNQMP=3Dy > > > > > > > > > > ~Michal > > > > > > > > > > > > > > > > > Host hangs in build time. > > > > > > Maybe I did not set something in the > config build file ? > > > > > > > > > > > > Regards, > > > > > > Oleg > > > > > > > > > > > > =D1=87=D1=82, 20 =D0=B0=D0=BF=D1=80. 2023= =E2=80=AF=D0=B3. =D0=B2 11:57, Oleg > Nikitenko > > > > oleshiiwood@gmail.com>>>: > > > > > > > > > > > > Thanks Michal, > > > > > > > > > > > > You gave me an idea. > > > > > > I am going to try it today. > > > > > > > > > > > > Regards, > > > > > > O. > > > > > > > > > > > > =D1=87=D1=82, 20 =D0=B0=D0=BF=D1=80. = 2023=E2=80=AF=D0=B3. =D0=B2 11:56, Oleg > Nikitenko > > > > oleshiiwood@gmail.com>>>: > > > > > > > > > > > > Thanks Stefano. > > > > > > > > > > > > I am going to do it today. > > > > > > > > > > > > Regards, > > > > > > O. > > > > > > > > > > > > =D1=81=D1=80, 19 =D0=B0=D0=BF=D1= =80. 2023=E2=80=AF=D0=B3. =D0=B2 23:05, > Stefano Stabellini > > > > > sstabellini@kernel.org>>>: > > > > > > > > > > > > On Wed, 19 Apr 2023, Oleg > Nikitenko wrote: > > > > > > > Hi Michal, > > > > > > > > > > > > > > I corrected xen's command > line. > > > > > > > Now it is > > > > > > > xen,xen-bootargs =3D > "console=3Ddtuart dtuart=3Dserial0 dom0_mem=3D1600M dom0_max_vcpus=3D2 > > dom0_vcpus_pin > > > > bootscrub=3D0 vwfi=3Dnative sched=3Dnull > > > > > > > timer_slop=3D0 way_size=3D6= 5536 > xen_colors=3D0-3 dom0_colors=3D4-7"; > > > > > > > > > > > > 4 colors is way too many for > xen, just do xen_colors=3D0-0. There is no > > > > > > advantage in using more than = 1 > color for Xen. > > > > > > > > > > > > 4 colors is too few for dom0, > if you are giving 1600M of memory to Dom0. > > > > > > Each color is 256M. For 1600M > you should give at least 7 colors. Try: > > > > > > > > > > > > xen_colors=3D0-0 dom0_colors= =3D1-8 > > > > > > > > > > > > > > > > > > > > > > > > > Unfortunately the result wa= s > the same. > > > > > > > > > > > > > > (XEN) - Dom0 mode: Relaxed > > > > > > > (XEN) P2M: 40-bit IPA with > 40-bit PA and 8-bit VMID > > > > > > > (XEN) P2M: 3 levels with > order-1 root, VTCR 0x0000000080023558 > > > > > > > (XEN) Scheduling > granularity: cpu, 1 CPU per sched-resource > > > > > > > (XEN) Coloring general > information > > > > > > > (XEN) Way size: 64kB > > > > > > > (XEN) Max. number of colors > available: 16 > > > > > > > (XEN) Xen color(s): [ 0 ] > > > > > > > (XEN) alternatives: Patchin= g > with alt table 00000000002cc690 -> 00000000002ccc0c > > > > > > > (XEN) Color array allocatio= n > failed for dom0 > > > > > > > (XEN) > > > > > > > (XEN) > **************************************** > > > > > > > (XEN) Panic on CPU 0: > > > > > > > (XEN) Error creating domain= 0 > > > > > > > (XEN) > **************************************** > > > > > > > (XEN) > > > > > > > (XEN) Reboot in five > seconds... > > > > > > > > > > > > > > I am going to find out how > command line arguments passed and parsed. > > > > > > > > > > > > > > Regards, > > > > > > > Oleg > > > > > > > > > > > > > > =D1=81=D1=80, 19 =D0=B0=D0= =BF=D1=80. 2023=E2=80=AF=D0=B3. =D0=B2 11:25, > Oleg Nikitenko > > > > > oleshiiwood@gmail.com>>>: > > > > > > > Hi Michal, > > > > > > > > > > > > > > You put my nose into the > problem. Thank you. > > > > > > > I am going to use your poin= t. > > > > > > > Let's see what happens. > > > > > > > > > > > > > > Regards, > > > > > > > Oleg > > > > > > > > > > > > > > > > > > > > > =D1=81=D1=80, 19 =D0=B0=D0= =BF=D1=80. 2023=E2=80=AF=D0=B3. =D0=B2 10:37, > Michal Orzel > > > > > michal.orzel@amd.com>>>: > > > > > > > Hi Oleg, > > > > > > > > > > > > > > On 19/04/2023 09:03, > Oleg Nikitenko wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Hello Stefano, > > > > > > > > > > > > > > > > Thanks for the > clarification. > > > > > > > > My company uses > yocto for image generation. > > > > > > > > What kind of > information do you need to consult me in this case ? > > > > > > > > > > > > > > > > Maybe modules > sizes/addresses which were mentioned by @Julien Grall > > > > > > >> ? > > > > > > > > > > > > > > Sorry for jumping int= o > discussion, but FWICS the Xen command line you provided > > seems to be > > > not the > > > > one > > > > > > > Xen booted with. The > error you are observing most likely is due to dom0 colors > > > configuration not > > > > being > > > > > > > specified (i.e. lack > of dom0_colors=3D<> parameter). Although in the command line you > > > provided, this > > > > parameter > > > > > > > is set, I strongly > doubt that this is the actual command line in use. > > > > > > > > > > > > > > You wrote: > > > > > > > xen,xen-bootargs =3D > "console=3Ddtuart dtuart=3Dserial0 dom0_mem=3D1600M dom0_max_vcpus=3D2 > > > dom0_vcpus_pin > > > > bootscrub=3D0 vwfi=3Dnative > > > > > > > sched=3Dnull > timer_slop=3D0 way_szize=3D65536 xen_colors=3D0-3 dom0_colors=3D4-7"; > > > > > > > > > > > > > > but: > > > > > > > 1) way_szize has a ty= po > > > > > > > 2) you specified 4 > colors (0-3) for Xen, but the boot log says that Xen has only > > one: > > > > > > > (XEN) Xen color(s): [ > 0 ] > > > > > > > > > > > > > > This makes me believe > that no colors configuration actually end up in command line > > that Xen > > > booted > > > > with. > > > > > > > Single color for Xen > is a "default if not specified" and way size was probably > > calculated > > > by asking > > > > HW. > > > > > > > > > > > > > > So I would suggest to > first cross-check the command line in use. > > > > > > > > > > > > > > ~Michal > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Regards, > > > > > > > > Oleg > > > > > > > > > > > > > > > > =D0=B2=D1=82, 18 = =D0=B0=D0=BF=D1=80. 2023=E2=80=AF=D0=B3. > =D0=B2 20:44, Stefano Stabellini > > > sstabellini@kernel.org > > > > > > > sstabellini@kernel.org >>>: > > > > > > > > > > > > > > > > On Tue, 18 Apr > 2023, Oleg Nikitenko wrote: > > > > > > > > > Hi Julien, > > > > > > > > > > > > > > > > > > >> This > feature has not been merged in Xen upstream yet > > > > > > > > > > > > > > > > > > > would assum= e > that upstream + the series on the ML [1] work > > > > > > > > > > > > > > > > > > Please clarif= y > this point. > > > > > > > > > Because the > two thoughts are controversial. > > > > > > > > > > > > > > > > Hi Oleg, > > > > > > > > > > > > > > > > As Julien wrote= , > there is nothing controversial. As you are aware, > > > > > > > > Xilinx maintain= s > a separate Xen tree specific for Xilinx here: > > > > > > > > > https://github.com/xilinx/xen > > > > > > > < > https://github.com/xilinx/xen > > > > > > >> > > > > > > > > > > > > > > > > and the branch > you are using (xlnx_rebase_4.16) comes from there. > > > > > > > > > > > > > > > > > > > > > > > > Instead, the > upstream Xen tree lives here: > > > > > > > > > https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary > > > > < > https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary> < > https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary > > > > < > https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary>> < > https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary > > > > < > https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary> < > https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary > > > > < > https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary>>> > > > > > > > > > > > > > > > > > > > > > > > > The Cache > Coloring feature that you are trying to configure is present > > > > > > > > in > xlnx_rebase_4.16, but not yet present upstream (there is an > > > > > > > > outstanding > patch series to add cache coloring to Xen upstream but it > > > > > > > > hasn't been > merged yet.) > > > > > > > > > > > > > > > > > > > > > > > > Anyway, if you > are using xlnx_rebase_4.16 it doesn't matter too much for > > > > > > > > you as you > already have Cache Coloring as a feature there. > > > > > > > > > > > > > > > > > > > > > > > > I take you are > using ImageBuilder to generate the boot configuration? If > > > > > > > > so, please post > the ImageBuilder config file that you are using. > > > > > > > > > > > > > > > > But from the > boot message, it looks like the colors configuration for > > > > > > > > Dom0 is > incorrect. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --000000000000cd85bd05faee032e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: base64 PGRpdiBkaXI9Imx0ciI+PGRpdj5IZWxsbyBTdGVmYW5vLDwvZGl2PjxkaXY+PGJyPjwvZGl2Pjxk aXY+SSB3b3VsZCBsaWtlIHRvIHRyeSBhIHhlbiBjYWNoZSBjb2xvciBwcm9wZXJ0eSBmcm9tIHRo aXMgcmVwb8KgIDxhIGhyZWY9Imh0dHBzOi8veGVuYml0cy54ZW4ub3JnL2dpdC1odHRwL3hlbi5n aXQiPmh0dHBzOi8veGVuYml0cy54ZW4ub3JnL2dpdC1odHRwL3hlbi5naXQ8L2E+PC9kaXY+PGRp dj5Db3VsZCB5b3UgdGVsbCB3aG90IGJyYW5jaCBJIHNob3VsZCB1c2UgPzwvZGl2PjxkaXY+PGJy PjwvZGl2PjxkaXY+UmVnYXJkcyw8L2Rpdj48ZGl2Pk9sZWc8YnI+PC9kaXY+PC9kaXY+PGJyPjxk aXYgY2xhc3M9ImdtYWlsX3F1b3RlIj48ZGl2IGRpcj0ibHRyIiBjbGFzcz0iZ21haWxfYXR0ciI+ 0L/RgiwgMjgg0LDQv9GALiAyMDIz4oCv0LMuINCyIDAwOjUxLCBTdGVmYW5vIFN0YWJlbGxpbmkg Jmx0OzxhIGhyZWY9Im1haWx0bzpzc3RhYmVsbGluaUBrZXJuZWwub3JnIj5zc3RhYmVsbGluaUBr ZXJuZWwub3JnPC9hPiZndDs6PGJyPjwvZGl2PjxibG9ja3F1b3RlIGNsYXNzPSJnbWFpbF9xdW90 ZSIgc3R5bGU9Im1hcmdpbjowcHggMHB4IDBweCAwLjhleDtib3JkZXItbGVmdDoxcHggc29saWQg cmdiKDIwNCwyMDQsMjA0KTtwYWRkaW5nLWxlZnQ6MWV4Ij5JIGFtIGZhbWlsaWFyIHdpdGggdGhl IHpjdTEwMiBidXQgSSBkb24mIzM5O3Qga25vdyBob3cgeW91IGNvdWxkIHBvc3NpYmx5PGJyPg0K Z2VuZXJhdGUgYSBTRXJyb3IuPGJyPg0KPGJyPg0KSSBzdWdnZXN0IHRvIHRyeSB0byB1c2UgSW1h Z2VCdWlsZGVyIFsxXSB0byBnZW5lcmF0ZSB0aGUgYm9vdDxicj4NCmNvbmZpZ3VyYXRpb24gYXMg YSB0ZXN0IGJlY2F1c2UgdGhhdCBpcyBrbm93biB0byB3b3JrIHdlbGwgZm9yIHpjdTEwMi48YnI+ DQo8YnI+DQpbMV0gPGEgaHJlZj0iaHR0cHM6Ly9naXRsYWIuY29tL3hlbi1wcm9qZWN0L2ltYWdl YnVpbGRlciIgcmVsPSJub3JlZmVycmVyIiB0YXJnZXQ9Il9ibGFuayI+aHR0cHM6Ly9naXRsYWIu Y29tL3hlbi1wcm9qZWN0L2ltYWdlYnVpbGRlcjwvYT48YnI+DQo8YnI+DQo8YnI+DQpPbiBUaHUs IDI3IEFwciAyMDIzLCBPbGVnIE5pa2l0ZW5rbyB3cm90ZTo8YnI+DQomZ3Q7IEhlbGxvIFN0ZWZh bm8sPGJyPg0KJmd0OyA8YnI+DQomZ3Q7IFRoYW5rcyBmb3IgY2xhcmlmaWNhdGlvbi48YnI+DQom Z3Q7IFdlIG5pZ2h0ZXIgdXNlIEltYWdlQnVpbGRlciBub3IgdWJvb3QgYm9vdCBzY3JpcHQuPGJy Pg0KJmd0OyBBIG1vZGVsIGlzIHpjdTEwMiBjb21wYXRpYmxlLjxicj4NCiZndDsgPGJyPg0KJmd0 OyBSZWdhcmRzLDxicj4NCiZndDsgTy48YnI+DQomZ3Q7IDxicj4NCiZndDsg0LLRgiwgMjUg0LDQ v9GALiAyMDIz4oCv0LMuINCyIDIxOjIxLCBTdGVmYW5vIFN0YWJlbGxpbmkgJmx0OzxhIGhyZWY9 Im1haWx0bzpzc3RhYmVsbGluaUBrZXJuZWwub3JnIiB0YXJnZXQ9Il9ibGFuayI+c3N0YWJlbGxp bmlAa2VybmVsLm9yZzwvYT4mZ3Q7Ojxicj4NCiZndDvCoCDCoCDCoCDCoFRoaXMgaXMgaW50ZXJl c3RpbmcuIEFyZSB5b3UgdXNpbmcgWGlsaW54IGhhcmR3YXJlIGJ5IGFueSBjaGFuY2U/IElmIHNv LDxicj4NCiZndDvCoCDCoCDCoCDCoHdoaWNoIGJvYXJkPzxicj4NCiZndDsgPGJyPg0KJmd0O8Kg IMKgIMKgIMKgQXJlIHlvdSB1c2luZyBJbWFnZUJ1aWxkZXIgdG8gZ2VuZXJhdGUgeW91ciBib290 LnNjciBib290IHNjcmlwdD8gSWYgc28sPGJyPg0KJmd0O8KgIMKgIMKgIMKgY291bGQgeW91IHBs ZWFzZSBwb3N0IHlvdXIgSW1hZ2VCdWlsZGVyIGNvbmZpZyBmaWxlPyBJZiBub3QsIGNhbiB5b3U8 YnI+DQomZ3Q7wqAgwqAgwqAgwqBwb3N0IHRoZSBzb3VyY2Ugb2YgeW91ciB1Ym9vdCBib290IHNj cmlwdD88YnI+DQomZ3Q7IDxicj4NCiZndDvCoCDCoCDCoCDCoFNFcnJvcnMgYXJlIHN1cHBvc2Vk IHRvIGJlIHJlbGF0ZWQgdG8gYSBoYXJkd2FyZSBmYWlsdXJlIG9mIHNvbWUga2luZC48YnI+DQom Z3Q7wqAgwqAgwqAgwqBZb3UgYXJlIG5vdCBzdXBwb3NlZCB0byBiZSBhYmxlIHRvIHRyaWdnZXIg YW4gU0Vycm9yIGVhc2lseSBieTxicj4NCiZndDvCoCDCoCDCoCDCoCZxdW90O21pc3Rha2UmcXVv dDsuIEkgaGF2ZSBub3Qgc2VlbiBTRXJyb3JzIGR1ZSB0byB3cm9uZyBjYWNoZSBjb2xvcmluZzxi cj4NCiZndDvCoCDCoCDCoCDCoGNvbmZpZ3VyYXRpb25zIG9uIGFueSBYaWxpbnggYm9hcmQgYmVm b3JlLjxicj4NCiZndDsgPGJyPg0KJmd0O8KgIMKgIMKgIMKgVGhlIGRpZmZlcmVuY2VzIGJldHdl ZW4gWGVuIHdpdGggYW5kIHdpdGhvdXQgY2FjaGUgY29sb3JpbmcgZnJvbSBhPGJyPg0KJmd0O8Kg IMKgIMKgIMKgaGFyZHdhcmUgcGVyc3BlY3RpdmUgYXJlOjxicj4NCiZndDsgPGJyPg0KJmd0O8Kg IMKgIMKgIMKgLSBXaXRoIGNhY2hlIGNvbG9yaW5nLCB0aGUgU01NVSBpcyBlbmFibGVkIGFuZCBk b2VzIGFkZHJlc3MgdHJhbnNsYXRpb25zPGJyPg0KJmd0O8KgIMKgIMKgIMKgwqAgZXZlbiBmb3Ig ZG9tMC4gV2l0aG91dCBjYWNoZSBjb2xvcmluZyB0aGUgU01NVSBjb3VsZCBiZSBkaXNhYmxlZCwg YW5kPGJyPg0KJmd0O8KgIMKgIMKgIMKgwqAgaWYgZW5hYmxlZCwgdGhlIFNNTVUgZG9lc24mIzM5 O3QgZG8gYW55IGFkZHJlc3MgdHJhbnNsYXRpb25zIGZvciBEb20wLiBJZjxicj4NCiZndDvCoCDC oCDCoCDCoMKgIHRoZXJlIGlzIGEgaGFyZHdhcmUgZmFpbHVyZSByZWxhdGVkIHRvIFNNTVUgYWRk cmVzcyB0cmFuc2xhdGlvbiBpdDxicj4NCiZndDvCoCDCoCDCoCDCoMKgIGNvdWxkIG9ubHkgdHJp Z2dlciB3aXRoIGNhY2hlIGNvbG9yaW5nLiBUaGlzIHdvdWxkIGJlIG15IG5vcm1hbDxicj4NCiZn dDvCoCDCoCDCoCDCoMKgIHN1Z2dlc3Rpb24gZm9yIHlvdSB0byBleHBsb3JlLCBidXQgdGhlIGZh aWx1cmUgaGFwcGVucyB0b28gZWFybHk8YnI+DQomZ3Q7wqAgwqAgwqAgwqDCoCBiZWZvcmUgYW55 IERNQS1jYXBhYmxlIGRldmljZSBpcyBwcm9ncmFtbWVkLiBTbyBJIGRvbiYjMzk7dCB0aGluayB0 aGlzIGNhbjxicj4NCiZndDvCoCDCoCDCoCDCoMKgIGJlIHRoZSBpc3N1ZS48YnI+DQomZ3Q7IDxi cj4NCiZndDvCoCDCoCDCoCDCoC0gV2l0aCBjYWNoZSBjb2xvcmluZywgdGhlIG1lbW9yeSBhbGxv Y2F0aW9uIGlzIHZlcnkgZGlmZmVyZW50IHNvIHlvdSYjMzk7bGw8YnI+DQomZ3Q7wqAgwqAgwqAg wqDCoCBlbmQgdXAgdXNpbmcgZGlmZmVyZW50IEREUiByZWdpb25zIGZvciBEb20wLiBTbyBpZiB5 b3VyIEREUiBpczxicj4NCiZndDvCoCDCoCDCoCDCoMKgIGRlZmVjdGl2ZSwgeW91IG1pZ2h0IG9u bHkgc2VlIGEgZmFpbHVyZSB3aXRoIGNhY2hlIGNvbG9yaW5nIGVuYWJsZWQ8YnI+DQomZ3Q7wqAg wqAgwqAgwqDCoCBiZWNhdXNlIHlvdSBlbmQgdXAgdXNpbmcgZGlmZmVyZW50IHJlZ2lvbnMuPGJy Pg0KJmd0OyA8YnI+DQomZ3Q7IDxicj4NCiZndDvCoCDCoCDCoCDCoE9uIFR1ZSwgMjUgQXByIDIw MjMsIE9sZWcgTmlraXRlbmtvIHdyb3RlOjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgSGkgU3Rl ZmFubyw8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBU aGFuayB5b3UuPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBJZiBJIGJ1aWxkIHhlbiB3aXRob3V0 IGNvbG9ycyBzdXBwb3J0IHRoZXJlIGlzIG5vdCB0aGlzIGVycm9yLjxicj4NCiZndDvCoCDCoCDC oCDCoCZndDsgQWxsIHRoZSBkb21haW5zIGFyZSBib290ZWQgd2VsbC48YnI+DQomZ3Q7wqAgwqAg wqAgwqAmZ3Q7IEhlbnNlIGl0IGNhbiBub3QgYmUgYSBoYXJkd2FyZSBpc3N1ZS48YnI+DQomZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IFRoaXMgcGFuaWMgYXJyaXZlZCBkdXJpbmcgdW5wYWNraW5nIHRoZSBy b290ZnMuPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBIZXJlIEkgYXR0YWNoZWQgdGhlIGJvb3Qg bG9nIHhlbi9Eb20wIHdpdGhvdXQgY29sb3IuPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBBIGhp Z2hsaWdodGVkIHN0cmluZ3MgcHJpbnRlZCBleGFjdGx5IGFmdGVyIHRoZSBwbGFjZSB3aGVyZSAx LXN0IHRpbWUgcGFuaWMgYXJyaXZlZC48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0OyDCoFhlbiA0LjE2LjEtcHJlPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0 OyAoWEVOKSBYZW4gdmVyc2lvbiA0LjE2LjEtcHJlIChub2xlMjM5MEAobm9uZSkpIChhYXJjaDY0 LXBvcnRhYmxlLWxpbnV4LWdjYyAoR0NDKSAxMS4zLjApIGRlYnVnPXkgMjAyMy0wNC0yMTxicj4N CiZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgTGF0ZXN0IENoYW5nZVNldDogV2VkIEFwciAxOSAx Mjo1NjoxNCAyMDIzICswMzAwIGdpdDozMjE2ODdiMjMxLWRpcnR5PGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0OyAoWEVOKSBidWlsZC1pZDogYzE4NDcyNThmZGIxYjc5NTYyZmM3MTBkZGE0MDAwOGY5 NmMwZmRlNTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgUHJvY2Vzc29yOiAwMDAwMDAw MDQxMGZkMDM0OiAmcXVvdDtBUk0gTGltaXRlZCZxdW90OywgdmFyaWFudDogMHgwLCBwYXJ0IDB4 ZDAzLHJldiAweDQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIDY0LWJpdCBFeGVjdXRp b246PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSDCoCBQcm9jZXNzb3IgRmVhdHVyZXM6 IDAwMDAwMDAwMDAwMDIyMjIgMDAwMDAwMDAwMDAwMDAwMDxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDsgKFhFTikgwqAgwqAgRXhjZXB0aW9uIExldmVsczogRUwzOjY0KzMyIEVMMjo2NCszMiBFTDE6 NjQrMzIgRUwwOjY0KzMyPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSDCoCDCoCBFeHRl bnNpb25zOiBGbG9hdGluZ1BvaW50IEFkdmFuY2VkU0lNRDxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDsgKFhFTikgwqAgRGVidWcgRmVhdHVyZXM6IDAwMDAwMDAwMTAzMDUxMDYgMDAwMDAwMDAwMDAw MDAwMDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgwqAgQXV4aWxpYXJ5IEZlYXR1cmVz OiAwMDAwMDAwMDAwMDAwMDAwIDAwMDAwMDAwMDAwMDAwMDA8YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7IChYRU4pIMKgIE1lbW9yeSBNb2RlbCBGZWF0dXJlczogMDAwMDAwMDAwMDAwMTEyMiAwMDAw MDAwMDAwMDAwMDAwPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSDCoCBJU0EgRmVhdHVy ZXM6IMKgMDAwMDAwMDAwMDAxMTEyMCAwMDAwMDAwMDAwMDAwMDAwPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0OyAoWEVOKSAzMi1iaXQgRXhlY3V0aW9uOjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsg KFhFTikgwqAgUHJvY2Vzc29yIEZlYXR1cmVzOiAwMDAwMDAwMDAwMDAwMTMxOjAwMDAwMDAwMDAw MTEwMTE8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIMKgIMKgIEluc3RydWN0aW9uIFNl dHM6IEFBcmNoMzIgQTMyIFRodW1iIFRodW1iLTIgSmF6ZWxsZTxicj4NCiZndDvCoCDCoCDCoCDC oCZndDsgKFhFTikgwqAgwqAgRXh0ZW5zaW9uczogR2VuZXJpY1RpbWVyIFNlY3VyaXR5PGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSDCoCBEZWJ1ZyBGZWF0dXJlczogMDAwMDAwMDAwMzAx MDA2Njxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgwqAgQXV4aWxpYXJ5IEZlYXR1cmVz OiAwMDAwMDAwMDAwMDAwMDAwPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSDCoCBNZW1v cnkgTW9kZWwgRmVhdHVyZXM6IDAwMDAwMDAwMTAyMDExMDUgMDAwMDAwMDA0MDAwMDAwMDxicj4N CiZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAwMDAwMDAwMDAxMjYwMDAwIDAwMDAwMDAwMDIxMDIyMTE8YnI+DQomZ3Q7wqAgwqAg wqAgwqAmZ3Q7IChYRU4pIMKgIElTQSBGZWF0dXJlczogMDAwMDAwMDAwMjEwMTExMCAwMDAwMDAw MDEzMTEyMTExIDAwMDAwMDAwMjEyMzIwNDI8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4p IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIDAwMDAwMDAwMDExMTIxMzEgMDAwMDAwMDAwMDAxMTE0 MiAwMDAwMDAwMDAwMDExMTIxPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBVc2luZyBT TUMgQ2FsbGluZyBDb252ZW50aW9uIHYxLjI8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4p IFVzaW5nIFBTQ0kgdjEuMTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgU01QOiBBbGxv d2luZyA0IENQVXM8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIEdlbmVyaWMgVGltZXIg SVJROiBwaHlzPTMwIGh5cD0yNiB2aXJ0PTI3IEZyZXE6IDEwMDAwMCBLSHo8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7IChYRU4pIEdJQ3YyIGluaXRpYWxpemF0aW9uOjxicj4NCiZndDvCoCDCoCDC oCDCoCZndDsgKFhFTikgwqAgwqAgwqAgwqAgZ2ljX2Rpc3RfYWRkcj0wMDAwMDAwMGY5MDEwMDAw PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSDCoCDCoCDCoCDCoCBnaWNfY3B1X2FkZHI9 MDAwMDAwMDBmOTAyMDAwMDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgwqAgwqAgwqAg wqAgZ2ljX2h5cF9hZGRyPTAwMDAwMDAwZjkwNDAwMDA8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IChYRU4pIMKgIMKgIMKgIMKgIGdpY192Y3B1X2FkZHI9MDAwMDAwMDBmOTA2MDAwMDxicj4NCiZn dDvCoCDCoCDCoCDCoCZndDsgKFhFTikgwqAgwqAgwqAgwqAgZ2ljX21haW50ZW5hbmNlX2lycT0y NTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgR0lDdjI6IEFkanVzdGluZyBDUFUgaW50 ZXJmYWNlIGJhc2UgdG8gMHhmOTAyZjAwMDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikg R0lDdjI6IDE5MiBsaW5lcywgNCBjcHVzLCBzZWN1cmUgKElJRCAwMjAwMTQzYikuPGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBVc2luZyBzY2hlZHVsZXI6IG51bGwgU2NoZWR1bGVyIChu dWxsKTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgSW5pdGlhbGl6aW5nIG51bGwgc2No ZWR1bGVyPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBXQVJOSU5HOiBUaGlzIGlzIGV4 cGVyaW1lbnRhbCBzb2Z0d2FyZSBpbiBkZXZlbG9wbWVudC48YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7IChYRU4pIFVzZSBhdCB5b3VyIG93biByaXNrLjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsg KFhFTikgQWxsb2NhdGVkIGNvbnNvbGUgcmluZyBvZiAzMiBLaUIuPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0OyAoWEVOKSBDUFUwOiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDEyIHRpbWVzIGJlZm9y ZSBwYXVzaW5nIHRoZSBkb21haW48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIEJyaW5n aW5nIHVwIENQVTE8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIENQVTE6IEd1ZXN0IGF0 b21pY3Mgd2lsbCB0cnkgMTMgdGltZXMgYmVmb3JlIHBhdXNpbmcgdGhlIGRvbWFpbjxicj4NCiZn dDvCoCDCoCDCoCDCoCZndDsgKFhFTikgQ1BVIDEgYm9vdGVkLjxicj4NCiZndDvCoCDCoCDCoCDC oCZndDsgKFhFTikgQnJpbmdpbmcgdXAgQ1BVMjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgKFhF TikgQ1BVMjogR3Vlc3QgYXRvbWljcyB3aWxsIHRyeSAxMyB0aW1lcyBiZWZvcmUgcGF1c2luZyB0 aGUgZG9tYWluPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBDUFUgMiBib290ZWQuPGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBCcmluZ2luZyB1cCBDUFUzPGJyPg0KJmd0O8Kg IMKgIMKgIMKgJmd0OyAoWEVOKSBDUFUzOiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDEzIHRpbWVz IGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4p IEJyb3VnaHQgdXAgNCBDUFVzPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBDUFUgMyBi b290ZWQuPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBzbW11OiAvYXhpL3NtbXVAZmQ4 MDAwMDA6IHByb2JpbmcgaGFyZHdhcmUgY29uZmlndXJhdGlvbi4uLjxicj4NCiZndDvCoCDCoCDC oCDCoCZndDsgKFhFTikgc21tdTogL2F4aS9zbW11QGZkODAwMDAwOiBTTU1VdjIgd2l0aDo8YnI+ DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIHNtbXU6IC9heGkvc21tdUBmZDgwMDAwMDogc3Rh Z2UgMiB0cmFuc2xhdGlvbjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgc21tdTogL2F4 aS9zbW11QGZkODAwMDAwOiBzdHJlYW0gbWF0Y2hpbmcgd2l0aCA0OCByZWdpc3RlciBncm91cHMs IG1hc2sgMHg3ZmZmJmx0OzImZ3Q7c21tdTogL2F4aS9zbW11QGZkODAwMDAwOiAxNiBjb250ZXh0 PGJyPg0KJmd0O8KgIMKgIMKgIMKgYmFua3MgKDA8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IHN0 YWdlLTIgb25seSk8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIHNtbXU6IC9heGkvc21t dUBmZDgwMDAwMDogU3RhZ2UtMjogNDgtYml0IElQQSAtJmd0OyA0OC1iaXQgUEE8YnI+DQomZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIHNtbXU6IC9heGkvc21tdUBmZDgwMDAwMDogcmVnaXN0ZXJl ZCAyOSBtYXN0ZXIgZGV2aWNlczxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgSS9PIHZp cnR1YWxpc2F0aW9uIGVuYWJsZWQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIMKgLSBE b20wIG1vZGU6IFJlbGF4ZWQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIFAyTTogNDAt Yml0IElQQSB3aXRoIDQwLWJpdCBQQSBhbmQgOC1iaXQgVk1JRDxicj4NCiZndDvCoCDCoCDCoCDC oCZndDsgKFhFTikgUDJNOiAzIGxldmVscyB3aXRoIG9yZGVyLTEgcm9vdCwgVlRDUiAweDAwMDAw MDAwODAwMjM1NTg8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIFNjaGVkdWxpbmcgZ3Jh bnVsYXJpdHk6IGNwdSwgMSBDUFUgcGVyIHNjaGVkLXJlc291cmNlPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0OyAoWEVOKSBhbHRlcm5hdGl2ZXM6IFBhdGNoaW5nIHdpdGggYWx0IHRhYmxlIDAwMDAw MDAwMDAyY2M1YzggLSZndDsgMDAwMDAwMDAwMDJjY2IyYzxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDsgKFhFTikgKioqIExPQURJTkcgRE9NQUlOIDAgKioqPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0 OyAoWEVOKSBMb2FkaW5nIGQwIGtlcm5lbCBmcm9tIGJvb3QgbW9kdWxlIEAgMDAwMDAwMDAwMTAw MDAwMDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgTG9hZGluZyByYW1kaXNrIGZyb20g Ym9vdCBtb2R1bGUgQCAwMDAwMDAwMDAyMDAwMDAwPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyAo WEVOKSBBbGxvY2F0aW5nIDE6MSBtYXBwaW5ncyB0b3RhbGxpbmcgMTYwME1CIGZvciBkb20wOjxi cj4NCiZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgQkFOS1swXSAweDAwMDAwMDEwMDAwMDAwLTB4 MDAwMDAwMjAwMDAwMDAgKDI1Nk1CKTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgQkFO S1sxXSAweDAwMDAwMDI0MDAwMDAwLTB4MDAwMDAwMjgwMDAwMDAgKDY0TUIpPGJyPg0KJmd0O8Kg IMKgIMKgIMKgJmd0OyAoWEVOKSBCQU5LWzJdIDB4MDAwMDAwMzAwMDAwMDAtMHgwMDAwMDA4MDAw MDAwMCAoMTI4ME1CKTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgR3JhbnQgdGFibGUg cmFuZ2U6IDB4MDAwMDAwMDBlMDAwMDAtMHgwMDAwMDAwMGU0MDAwMDxicj4NCiZndDvCoCDCoCDC oCDCoCZndDsgKFhFTikgc21tdTogL2F4aS9zbW11QGZkODAwMDAwOiBkMDogcDJtYWRkciAweDAw MDAwMDA4N2JmOTQwMDA8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIEFsbG9jYXRpbmcg UFBJIDE2IGZvciBldmVudCBjaGFubmVsIGludGVycnVwdDxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDsgKFhFTikgRXh0ZW5kZWQgcmVnaW9uIDA6IDB4ODEyMDAwMDAtJmd0OzB4YTAwMDAwMDA8YnI+ DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIEV4dGVuZGVkIHJlZ2lvbiAxOiAweGIxMjAwMDAw LSZndDsweGMwMDAwMDAwPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBFeHRlbmRlZCBy ZWdpb24gMjogMHhjODAwMDAwMC0mZ3Q7MHhlMDAwMDAwMDxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDsgKFhFTikgRXh0ZW5kZWQgcmVnaW9uIDM6IDB4ZjAwMDAwMDAtJmd0OzB4ZjkwMDAwMDA8YnI+ DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIEV4dGVuZGVkIHJlZ2lvbiA0OiAweDEwMDAwMDAw MC0mZ3Q7MHg2MDAwMDAwMDA8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIEV4dGVuZGVk IHJlZ2lvbiA1OiAweDg4MDAwMDAwMC0mZ3Q7MHg4MDAwMDAwMDAwPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0OyAoWEVOKSBFeHRlbmRlZCByZWdpb24gNjogMHg4MDAxMDAwMDAwLSZndDsweDEwMDAw MDAwMDAwPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBMb2FkaW5nIHpJbWFnZSBmcm9t IDAwMDAwMDAwMDEwMDAwMDAgdG8gMDAwMDAwMDAxMDAwMDAwMC0wMDAwMDAwMDEwZTQxMDA4PGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBMb2FkaW5nIGQwIGluaXRyZCBmcm9tIDAwMDAw MDAwMDIwMDAwMDAgdG8gMHgwMDAwMDAwMDEzNjAwMDAwLTB4MDAwMDAwMDAxZmYzYTYxNzxicj4N CiZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgTG9hZGluZyBkMCBEVEIgdG8gMHgwMDAwMDAwMDEz NDAwMDAwLTB4MDAwMDAwMDAxMzQwY2JkYzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikg SW5pdGlhbCBsb3cgbWVtb3J5IHZpcnEgdGhyZXNob2xkIHNldCBhdCAweDQwMDAgcGFnZXMuPGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBTdGQuIExvZ2xldmVsOiBBbGw8YnI+DQomZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIEd1ZXN0IExvZ2xldmVsOiBBbGw8YnI+DQomZ3Q7wqAgwqAg wqAgwqAmZ3Q7IChYRU4pICoqKiBTZXJpYWwgaW5wdXQgdG8gRE9NMCAodHlwZSAmIzM5O0NUUkwt YSYjMzk7IHRocmVlIHRpbWVzIHRvIHN3aXRjaCBpbnB1dCk8YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7IChYRU4pIG51bGwuYzozNTM6IDAgJmx0Oy0tIGQwdjA8YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7IChYRU4pIEZyZWVkIDM1NmtCIGluaXQgbWVtb3J5Ljxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDsgKFhFTikgZDB2MCBVbmhhbmRsZWQgU01DL0hWQzogMHg4NDAwMDA1MDxicj4NCiZndDvCoCDC oCDCoCDCoCZndDsgKFhFTikgZDB2MCBVbmhhbmRsZWQgU01DL0hWQzogMHg4NjAwZmYwMTxicj4N CiZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgZDB2MDogdkdJQ0Q6IHVuaGFuZGxlZCB3b3JkIHdy aXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSNDxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDsgKFhFTikgZDB2MDogdkdJQ0Q6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZm ZmYgdG8gSUNBQ1RJVkVSODxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgZDB2MDogdkdJ Q0Q6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMTI8 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQgd29y ZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjE2PGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0OyAoWEVOKSBkMHYwOiB2R0lDRDogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBm ZmZmZmZmZiB0byBJQ0FDVElWRVIyMDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgZDB2 MDogdkdJQ0Q6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJ VkVSMDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMDAwMDAwXSBCb290aW5nIExp bnV4IG9uIHBoeXNpY2FsIENQVSAweDAwMDAwMDAwMDAgWzB4NDEwZmQwMzRdPGJyPg0KJmd0O8Kg IMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBdIExpbnV4IHZlcnNpb24gNS4xNS43Mi14aWxp bngtdjIwMjIuMSAob2UtdXNlckBvZS1ob3N0KSAoYWFyY2g2NC1wb3J0YWJsZS1saW51eC1nY2Mg KEdDQykgMTEuMy4wLCBHTlUgbGQgKEdOVTxicj4NCiZndDvCoCDCoCDCoCDCoEJpbnV0aWxzKTxi cj4NCiZndDvCoCDCoCDCoCDCoCZndDsgMi4zOC4yMDIyMDcwOCkgIzEgU01QIFR1ZSBGZWIgMjEg MDU6NDc6NTQgVVRDIDIwMjM8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjAwMDAw MF0gTWFjaGluZSBtb2RlbDogRDE0IFZpcGVyIEJvYXJkIC0gV2hpdGUgVW5pdDxicj4NCiZndDvC oCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMDAwMDAwXSBYZW4gNC4xNiBzdXBwb3J0IGZvdW5kPGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBdIFpvbmUgcmFuZ2VzOjxicj4N CiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMDAwMDAwXSDCoCBETUEgwqAgwqAgwqBbbWVt IDB4MDAwMDAwMDAxMDAwMDAwMC0weDAwMDAwMDAwN2ZmZmZmZmZdPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBdIMKgIERNQTMyIMKgIMKgZW1wdHk8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjAwMDAwMF0gwqAgTm9ybWFsIMKgIGVtcHR5PGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBdIE1vdmFibGUgem9uZSBzdGFydCBmb3Ig ZWFjaCBub2RlPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBdIEVhcmx5 IG1lbW9yeSBub2RlIHJhbmdlczxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMDAw MDAwXSDCoCBub2RlIMKgIDA6IFttZW0gMHgwMDAwMDAwMDEwMDAwMDAwLTB4MDAwMDAwMDAxZmZm ZmZmZl08YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjAwMDAwMF0gwqAgbm9kZSDC oCAwOiBbbWVtIDB4MDAwMDAwMDAyMjAwMDAwMC0weDAwMDAwMDAwMjIxNDdmZmZdPGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBdIMKgIG5vZGUgwqAgMDogW21lbSAweDAw MDAwMDAwMjIyMDAwMDAtMHgwMDAwMDAwMDIyMzQ3ZmZmXTxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDsgWyDCoCDCoDAuMDAwMDAwXSDCoCBub2RlIMKgIDA6IFttZW0gMHgwMDAwMDAwMDI0MDAwMDAw LTB4MDAwMDAwMDAyN2ZmZmZmZl08YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjAw MDAwMF0gwqAgbm9kZSDCoCAwOiBbbWVtIDB4MDAwMDAwMDAzMDAwMDAwMC0weDAwMDAwMDAwN2Zm ZmZmZmZdPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBdIEluaXRtZW0g c2V0dXAgbm9kZSAwIFttZW0gMHgwMDAwMDAwMDEwMDAwMDAwLTB4MDAwMDAwMDA3ZmZmZmZmZl08 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjAwMDAwMF0gT24gbm9kZSAwLCB6b25l IERNQTogODE5MiBwYWdlcyBpbiB1bmF2YWlsYWJsZSByYW5nZXM8YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7IFsgwqAgwqAwLjAwMDAwMF0gT24gbm9kZSAwLCB6b25lIERNQTogMTg0IHBhZ2VzIGlu IHVuYXZhaWxhYmxlIHJhbmdlczxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMDAw MDAwXSBPbiBub2RlIDAsIHpvbmUgRE1BOiA3MzUyIHBhZ2VzIGluIHVuYXZhaWxhYmxlIHJhbmdl czxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMDAwMDAwXSBjbWE6IFJlc2VydmVk IDI1NiBNaUIgYXQgMHgwMDAwMDAwMDZlMDAwMDAwPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBb IMKgIMKgMC4wMDAwMDBdIHBzY2k6IHByb2JpbmcgZm9yIGNvbmR1aXQgbWV0aG9kIGZyb20gRFQu PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBdIHBzY2k6IFBTQ0l2MS4x IGRldGVjdGVkIGluIGZpcm13YXJlLjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAu MDAwMDAwXSBwc2NpOiBVc2luZyBzdGFuZGFyZCBQU0NJIHYwLjIgZnVuY3Rpb24gSURzPGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBdIHBzY2k6IFRydXN0ZWQgT1MgbWln cmF0aW9uIG5vdCByZXF1aXJlZDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMDAw MDAwXSBwc2NpOiBTTUMgQ2FsbGluZyBDb252ZW50aW9uIHYxLjE8YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7IFsgwqAgwqAwLjAwMDAwMF0gcGVyY3B1OiBFbWJlZGRlZCAxNiBwYWdlcy9jcHUgczMy NzkyIHIwIGQzMjc0NCB1NjU1MzY8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjAw MDAwMF0gRGV0ZWN0ZWQgVklQVCBJLWNhY2hlIG9uIENQVTA8YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7IFsgwqAgwqAwLjAwMDAwMF0gQ1BVIGZlYXR1cmVzOiBrZXJuZWwgcGFnZSB0YWJsZSBpc29s YXRpb24gZm9yY2VkIE9OIGJ5IEtBU0xSPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKg MC4wMDAwMDBdIENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6IEtlcm5lbCBwYWdlIHRhYmxlIGlzb2xh dGlvbiAoS1BUSSk8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjAwMDAwMF0gQnVp bHQgMSB6b25lbGlzdHMsIG1vYmlsaXR5IGdyb3VwaW5nIG9uLsKgIFRvdGFsIHBhZ2VzOiA0MDM4 NDU8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjAwMDAwMF0gS2VybmVsIGNvbW1h bmQgbGluZTogY29uc29sZT1odmMwIGVhcmx5Y29uPXhlbiBlYXJseXByaW50az14ZW4gY2xrX2ln bm9yZV91bnVzZWQgZmlwcz0xIHJvb3Q9L2Rldi9yYW0wPGJyPg0KJmd0O8KgIMKgIMKgIMKgbWF4 Y3B1cz0yPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBdIFVua25vd24g a2VybmVsIGNvbW1hbmQgbGluZSBwYXJhbWV0ZXJzICZxdW90O2Vhcmx5cHJpbnRrPXhlbiBmaXBz PTEmcXVvdDssIHdpbGwgYmUgcGFzc2VkIHRvIHVzZXIgc3BhY2UuPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBdIERlbnRyeSBjYWNoZSBoYXNoIHRhYmxlIGVudHJpZXM6 IDI2MjE0NCAob3JkZXI6IDksIDIwOTcxNTIgYnl0ZXMsIGxpbmVhcik8YnI+DQomZ3Q7wqAgwqAg wqAgwqAmZ3Q7IFsgwqAgwqAwLjAwMDAwMF0gSW5vZGUtY2FjaGUgaGFzaCB0YWJsZSBlbnRyaWVz OiAxMzEwNzIgKG9yZGVyOiA4LCAxMDQ4NTc2IGJ5dGVzLCBsaW5lYXIpPGJyPg0KJmd0O8KgIMKg IMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBdIG1lbSBhdXRvLWluaXQ6IHN0YWNrOm9mZiwgaGVh cCBhbGxvYzpvbiwgaGVhcCBmcmVlOm9uPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKg MC4wMDAwMDBdIG1lbSBhdXRvLWluaXQ6IGNsZWFyaW5nIHN5c3RlbSBtZW1vcnkgbWF5IHRha2Ug c29tZSB0aW1lLi4uPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBdIE1l bW9yeTogMTEyMTkzNksvMTY0MTAyNEsgYXZhaWxhYmxlICg5NzI4SyBrZXJuZWwgY29kZSwgODM2 SyByd2RhdGEsIDIzOTZLIHJvZGF0YSwgMTUzNksgaW5pdCwgMjYySyBic3MsPGJyPg0KJmd0O8Kg IMKgIMKgIMKgMjU2OTQ0SyByZXNlcnZlZCw8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IDI2MjE0 NEsgY21hLXJlc2VydmVkKTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMDAwMDAw XSBTTFVCOiBIV2FsaWduPTY0LCBPcmRlcj0wLTMsIE1pbk9iamVjdHM9MCwgQ1BVcz0yLCBOb2Rl cz0xPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBdIHJjdTogSGllcmFy Y2hpY2FsIFJDVSBpbXBsZW1lbnRhdGlvbi48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAg wqAwLjAwMDAwMF0gcmN1OiBSQ1UgZXZlbnQgdHJhY2luZyBpcyBlbmFibGVkLjxicj4NCiZndDvC oCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMDAwMDAwXSByY3U6IFJDVSByZXN0cmljdGluZyBDUFVz IGZyb20gTlJfQ1BVUz04IHRvIG5yX2NwdV9pZHM9Mi48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IFsgwqAgwqAwLjAwMDAwMF0gcmN1OiBSQ1UgY2FsY3VsYXRlZCB2YWx1ZSBvZiBzY2hlZHVsZXIt ZW5saXN0bWVudCBkZWxheSBpcyAyNSBqaWZmaWVzLjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsg WyDCoCDCoDAuMDAwMDAwXSByY3U6IEFkanVzdGluZyBnZW9tZXRyeSBmb3IgcmN1X2Zhbm91dF9s ZWFmPTE2LCBucl9jcHVfaWRzPTI8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjAw MDAwMF0gTlJfSVJRUzogNjQsIG5yX2lycXM6IDY0LCBwcmVhbGxvY2F0ZWQgaXJxczogMDxicj4N CiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMDAwMDAwXSBSb290IElSUSBoYW5kbGVyOiBn aWNfaGFuZGxlX2lycTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMDAwMDAwXSBh cmNoX3RpbWVyOiBjcDE1IHRpbWVyKHMpIHJ1bm5pbmcgYXQgMTAwLjAwTUh6ICh2aXJ0KS48YnI+ DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjAwMDAwMF0gY2xvY2tzb3VyY2U6IGFyY2hf c3lzX2NvdW50ZXI6IG1hc2s6IDB4ZmZmZmZmZmZmZmZmZmYgbWF4X2N5Y2xlczogMHgxNzEwMjRl N2UwLCBtYXhfaWRsZV9uczogNDQwNzk1MjA1MzE1IG5zPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0 OyBbIMKgIMKgMC4wMDAwMDBdIHNjaGVkX2Nsb2NrOiA1NiBiaXRzIGF0IDEwME1IeiwgcmVzb2x1 dGlvbiAxMG5zLCB3cmFwcyBldmVyeSA0Mzk4MDQ2NTExMTAwbnM8YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7IFsgwqAgwqAwLjAwMDI1OF0gQ29uc29sZTogY29sb3VyIGR1bW15IGRldmljZSA4MHgy NTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMzEwMjMxXSBwcmludGs6IGNvbnNv bGUgW2h2YzBdIGVuYWJsZWQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjMxNDQw M10gQ2FsaWJyYXRpbmcgZGVsYXkgbG9vcCAoc2tpcHBlZCksIHZhbHVlIGNhbGN1bGF0ZWQgdXNp bmcgdGltZXIgZnJlcXVlbmN5Li4gMjAwLjAwIEJvZ29NSVBTIChscGo9NDAwMDAwKTxicj4NCiZn dDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMzI0ODUxXSBwaWRfbWF4OiBkZWZhdWx0OiAzMjc2 OCBtaW5pbXVtOiAzMDE8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjMyOTcwNl0g TFNNOiBTZWN1cml0eSBGcmFtZXdvcmsgaW5pdGlhbGl6aW5nPGJyPg0KJmd0O8KgIMKgIMKgIMKg Jmd0OyBbIMKgIMKgMC4zMzQyMDRdIFlhbWE6IGJlY29taW5nIG1pbmRmdWwuPGJyPg0KJmd0O8Kg IMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4zMzc4NjVdIE1vdW50LWNhY2hlIGhhc2ggdGFibGUgZW50 cmllczogNDA5NiAob3JkZXI6IDMsIDMyNzY4IGJ5dGVzLCBsaW5lYXIpPGJyPg0KJmd0O8KgIMKg IMKgIMKgJmd0OyBbIMKgIMKgMC4zNDUxODBdIE1vdW50cG9pbnQtY2FjaGUgaGFzaCB0YWJsZSBl bnRyaWVzOiA0MDk2IChvcmRlcjogMywgMzI3NjggYnl0ZXMsIGxpbmVhcik8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjM1NDc0M10geGVuOmdyYW50X3RhYmxlOiBHcmFudCB0YWJs ZXMgdXNpbmcgdmVyc2lvbiAxIGxheW91dDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDC oDAuMzU5MTMyXSBHcmFudCB0YWJsZSBpbml0aWFsaXplZDxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDsgWyDCoCDCoDAuMzYyNjY0XSB4ZW46ZXZlbnRzOiBVc2luZyBGSUZPLWJhc2VkIEFCSTxicj4N CiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMzY2OTkzXSBYZW46IGluaXRpYWxpemluZyBj cHUwPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4zNzA1MTVdIHJjdTogSGllcmFy Y2hpY2FsIFNSQ1UgaW1wbGVtZW50YXRpb24uPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKg IMKgMC4zNzU5MzBdIHNtcDogQnJpbmdpbmcgdXAgc2Vjb25kYXJ5IENQVXMgLi4uPGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBudWxsLmM6MzUzOiAxICZsdDstLSBkMHYxPGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBkMHYxOiB2R0lDRDogdW5oYW5kbGVkIHdvcmQgd3JpdGUg MHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVIwPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBb IMKgIMKgMC4zODI1NDldIERldGVjdGVkIFZJUFQgSS1jYWNoZSBvbiBDUFUxPGJyPg0KJmd0O8Kg IMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4zODg3MTJdIFhlbjogaW5pdGlhbGl6aW5nIGNwdTE8YnI+ DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjM4ODc0M10gQ1BVMTogQm9vdGVkIHNlY29u ZGFyeSBwcm9jZXNzb3IgMHgwMDAwMDAwMDAxIFsweDQxMGZkMDM0XTxicj4NCiZndDvCoCDCoCDC oCDCoCZndDsgWyDCoCDCoDAuMzg4ODI5XSBzbXA6IEJyb3VnaHQgdXAgMSBub2RlLCAyIENQVXM8 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjQwNjk0MV0gU01QOiBUb3RhbCBvZiAy IHByb2Nlc3NvcnMgYWN0aXZhdGVkLjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAu NDExNjk4XSBDUFUgZmVhdHVyZXM6IGRldGVjdGVkOiAzMi1iaXQgRUwwIFN1cHBvcnQ8YnI+DQom Z3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjQxNjg4OF0gQ1BVIGZlYXR1cmVzOiBkZXRlY3Rl ZDogQ1JDMzIgaW5zdHJ1Y3Rpb25zPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC40 MjIxMjFdIENQVTogQWxsIENQVShzKSBzdGFydGVkIGF0IEVMMTxicj4NCiZndDvCoCDCoCDCoCDC oCZndDsgWyDCoCDCoDAuNDI2MjQ4XSBhbHRlcm5hdGl2ZXM6IHBhdGNoaW5nIGtlcm5lbCBjb2Rl PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC40MzE0MjRdIGRldnRtcGZzOiBpbml0 aWFsaXplZDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuNDQxNDU0XSBLQVNMUiBl bmFibGVkPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC40NDE2MDJdIGNsb2Nrc291 cmNlOiBqaWZmaWVzOiBtYXNrOiAweGZmZmZmZmZmIG1heF9jeWNsZXM6IDB4ZmZmZmZmZmYsIG1h eF9pZGxlX25zOiA3NjQ1MDQxNzg1MTAwMDAwIG5zPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBb IMKgIMKgMC40NDgzMjFdIGZ1dGV4IGhhc2ggdGFibGUgZW50cmllczogNTEyIChvcmRlcjogMywg MzI3NjggYnl0ZXMsIGxpbmVhcik8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjQ5 NjE4M10gTkVUOiBSZWdpc3RlcmVkIFBGX05FVExJTksvUEZfUk9VVEUgcHJvdG9jb2wgZmFtaWx5 PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC40OTgyNzddIERNQTogcHJlYWxsb2Nh dGVkIDI1NiBLaUIgR0ZQX0tFUk5FTCBwb29sIGZvciBhdG9taWMgYWxsb2NhdGlvbnM8YnI+DQom Z3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjUwMzc3Ml0gRE1BOiBwcmVhbGxvY2F0ZWQgMjU2 IEtpQiBHRlBfS0VSTkVMfEdGUF9ETUEgcG9vbCBmb3IgYXRvbWljIGFsbG9jYXRpb25zPGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC41MTE2MTBdIERNQTogcHJlYWxsb2NhdGVkIDI1 NiBLaUIgR0ZQX0tFUk5FTHxHRlBfRE1BMzIgcG9vbCBmb3IgYXRvbWljIGFsbG9jYXRpb25zPGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC41MTk0NzhdIGF1ZGl0OiBpbml0aWFsaXpp bmcgbmV0bGluayBzdWJzeXMgKGRpc2FibGVkKTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDC oCDCoDAuNTI0OTg1XSBhdWRpdDogdHlwZT0yMDAwIGF1ZGl0KDAuMzM2OjEpOiBzdGF0ZT1pbml0 aWFsaXplZCBhdWRpdF9lbmFibGVkPTAgcmVzPTE8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsg wqAgwqAwLjUyOTE2OV0gdGhlcm1hbF9zeXM6IFJlZ2lzdGVyZWQgdGhlcm1hbCBnb3Zlcm5vciAm IzM5O3N0ZXBfd2lzZSYjMzk7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC41MzMw MjNdIGh3LWJyZWFrcG9pbnQ6IGZvdW5kIDYgYnJlYWtwb2ludCBhbmQgNCB3YXRjaHBvaW50IHJl Z2lzdGVycy48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjU0NTYwOF0gQVNJRCBh bGxvY2F0b3IgaW5pdGlhbGlzZWQgd2l0aCAzMjc2OCBlbnRyaWVzPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0OyBbIMKgIMKgMC41NTEwMzBdIHhlbjpzd2lvdGxiX3hlbjogV2FybmluZzogb25seSBh YmxlIHRvIGFsbG9jYXRlIDQgTUIgZm9yIHNvZnR3YXJlIElPIFRMQjxicj4NCiZndDvCoCDCoCDC oCDCoCZndDsgWyDCoCDCoDAuNTU5MzMyXSBzb2Z0d2FyZSBJTyBUTEI6IG1hcHBlZCBbbWVtIDB4 MDAwMDAwMDAxMTgwMDAwMC0weDAwMDAwMDAwMTFjMDAwMDBdICg0TUIpPGJyPg0KJmd0O8KgIMKg IMKgIMKgJmd0OyBbIMKgIMKgMC41ODM1NjVdIEh1Z2VUTEIgcmVnaXN0ZXJlZCAxLjAwIEdpQiBw YWdlIHNpemUsIHByZS1hbGxvY2F0ZWQgMCBwYWdlczxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsg WyDCoCDCoDAuNTg0NzIxXSBIdWdlVExCIHJlZ2lzdGVyZWQgMzIuMCBNaUIgcGFnZSBzaXplLCBw cmUtYWxsb2NhdGVkIDAgcGFnZXM8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjU5 MTQ3OF0gSHVnZVRMQiByZWdpc3RlcmVkIDIuMDAgTWlCIHBhZ2Ugc2l6ZSwgcHJlLWFsbG9jYXRl ZCAwIHBhZ2VzPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC41OTgyMjVdIEh1Z2VU TEIgcmVnaXN0ZXJlZCA2NC4wIEtpQiBwYWdlIHNpemUsIHByZS1hbGxvY2F0ZWQgMCBwYWdlczxi cj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuNjM2NTIwXSBEUkJHOiBDb250aW51aW5n IHdpdGhvdXQgSml0dGVyIFJORzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuNzM3 MTg3XSByYWlkNjogbmVvbng4IMKgIGdlbigpIMKgMjE0MyBNQi9zPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0OyBbIMKgIMKgMC44MDUyOTRdIHJhaWQ2OiBuZW9ueDggwqAgeG9yKCkgwqAxNTg5IE1C L3M8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjg3MzQwNl0gcmFpZDY6IG5lb254 NCDCoCBnZW4oKSDCoDIxNzcgTUIvczxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAu OTQxNDk5XSByYWlkNjogbmVvbng0IMKgIHhvcigpIMKgMTU1NiBNQi9zPGJyPg0KJmd0O8KgIMKg IMKgIMKgJmd0OyBbIMKgIMKgMS4wMDk2MTJdIHJhaWQ2OiBuZW9ueDIgwqAgZ2VuKCkgwqAyMDcy IE1CL3M8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjA3NzcxNV0gcmFpZDY6IG5l b254MiDCoCB4b3IoKSDCoDE0MzAgTUIvczxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDC oDEuMTQ1ODM0XSByYWlkNjogbmVvbngxIMKgIGdlbigpIMKgMTc2OSBNQi9zPGJyPg0KJmd0O8Kg IMKgIMKgIMKgJmd0OyBbIMKgIMKgMS4yMTM5MzVdIHJhaWQ2OiBuZW9ueDEgwqAgeG9yKCkgwqAx MjE0IE1CL3M8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjI4MjA0Nl0gcmFpZDY6 IGludDY0eDggwqBnZW4oKSDCoDEzNjYgTUIvczxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDC oCDCoDEuMzUwMTMyXSByYWlkNjogaW50NjR4OCDCoHhvcigpIMKgIDc3MyBNQi9zPGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMS40MTgyNTldIHJhaWQ2OiBpbnQ2NHg0IMKgZ2VuKCkg wqAxNjAyIE1CL3M8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjQ4NjM0OV0gcmFp ZDY6IGludDY0eDQgwqB4b3IoKSDCoCA4NTEgTUIvczxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsg WyDCoCDCoDEuNTU0NDY0XSByYWlkNjogaW50NjR4MiDCoGdlbigpIMKgMTM5NiBNQi9zPGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMS42MjI1NjFdIHJhaWQ2OiBpbnQ2NHgyIMKgeG9y KCkgwqAgNzQ0IE1CL3M8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjY5MDY4N10g cmFpZDY6IGludDY0eDEgwqBnZW4oKSDCoDEwMzMgTUIvczxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDsgWyDCoCDCoDEuNzU4NzcwXSByYWlkNjogaW50NjR4MSDCoHhvcigpIMKgIDUxNyBNQi9zPGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMS43NTg4MDldIHJhaWQ2OiB1c2luZyBhbGdv cml0aG0gbmVvbng0IGdlbigpIDIxNzcgTUIvczxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDC oCDCoDEuNzYyOTQxXSByYWlkNjogLi4uLiB4b3IoKSAxNTU2IE1CL3MsIHJtdyBlbmFibGVkPGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMS43Njc5NTddIHJhaWQ2OiB1c2luZyBuZW9u IHJlY292ZXJ5IGFsZ29yaXRobTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDEuNzcy ODI0XSB4ZW46YmFsbG9vbjogSW5pdGlhbGlzaW5nIGJhbGxvb24gZHJpdmVyPGJyPg0KJmd0O8Kg IMKgIMKgIMKgJmd0OyBbIMKgIMKgMS43NzgwMjFdIGlvbW11OiBEZWZhdWx0IGRvbWFpbiB0eXBl OiBUcmFuc2xhdGVkPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMS43ODI1ODRdIGlv bW11OiBETUEgZG9tYWluIFRMQiBpbnZhbGlkYXRpb24gcG9saWN5OiBzdHJpY3QgbW9kZTxicj4N CiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDEuNzg5MTQ5XSBTQ1NJIHN1YnN5c3RlbSBpbml0 aWFsaXplZDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDEuNzkyODIwXSB1c2Jjb3Jl OiByZWdpc3RlcmVkIG5ldyBpbnRlcmZhY2UgZHJpdmVyIHVzYmZzPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0OyBbIMKgIMKgMS43OTgyNTRdIHVzYmNvcmU6IHJlZ2lzdGVyZWQgbmV3IGludGVyZmFj ZSBkcml2ZXIgaHViPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMS44MDM2MjZdIHVz YmNvcmU6IHJlZ2lzdGVyZWQgbmV3IGRldmljZSBkcml2ZXIgdXNiPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0OyBbIMKgIMKgMS44MDg3NjFdIHBwc19jb3JlOiBMaW51eFBQUyBBUEkgdmVyLiAxIHJl Z2lzdGVyZWQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjgxMzcxNl0gcHBzX2Nv cmU6IFNvZnR3YXJlIHZlci4gNS4zLjYgLSBDb3B5cmlnaHQgMjAwNS0yMDA3IFJvZG9sZm8gR2lv bWV0dGkgJmx0OzxhIGhyZWY9Im1haWx0bzpnaW9tZXR0aUBsaW51eC5pdCIgdGFyZ2V0PSJfYmxh bmsiPmdpb21ldHRpQGxpbnV4Lml0PC9hPiZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsg wqAgwqAxLjgyMjkwM10gUFRQIGNsb2NrIHN1cHBvcnQgcmVnaXN0ZXJlZDxicj4NCiZndDvCoCDC oCDCoCDCoCZndDsgWyDCoCDCoDEuODI2ODkzXSBFREFDIE1DOiBWZXI6IDMuMC4wPGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMS44MzAzNzVdIHp5bnFtcC1pcGktbWJveCBtYWlsYm94 QGZmOTkwNDAwOiBSZWdpc3RlcmVkIFp5bnFNUCBJUEkgbWJveCB3aXRoIFRYL1JYIGNoYW5uZWxz Ljxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDEuODM4ODYzXSB6eW5xbXAtaXBpLW1i b3ggbWFpbGJveEBmZjk5MDYwMDogUmVnaXN0ZXJlZCBaeW5xTVAgSVBJIG1ib3ggd2l0aCBUWC9S WCBjaGFubmVscy48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjg0NzM1Nl0genlu cW1wLWlwaS1tYm94IG1haWxib3hAZmY5OTA4MDA6IFJlZ2lzdGVyZWQgWnlucU1QIElQSSBtYm94 IHdpdGggVFgvUlggY2hhbm5lbHMuPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMS44 NTU5MDddIEZQR0EgbWFuYWdlciBmcmFtZXdvcms8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsg wqAgwqAxLjg1OTk1Ml0gY2xvY2tzb3VyY2U6IFN3aXRjaGVkIHRvIGNsb2Nrc291cmNlIGFyY2hf c3lzX2NvdW50ZXI8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjg3MTcxMl0gTkVU OiBSZWdpc3RlcmVkIFBGX0lORVQgcHJvdG9jb2wgZmFtaWx5PGJyPg0KJmd0O8KgIMKgIMKgIMKg Jmd0OyBbIMKgIMKgMS44NzE4MzhdIElQIGlkZW50cyBoYXNoIHRhYmxlIGVudHJpZXM6IDMyNzY4 IChvcmRlcjogNiwgMjYyMTQ0IGJ5dGVzLCBsaW5lYXIpPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0 OyBbIMKgIMKgMS44NzkzOTJdIHRjcF9saXN0ZW5fcG9ydGFkZHJfaGFzaCBoYXNoIHRhYmxlIGVu dHJpZXM6IDEwMjQgKG9yZGVyOiAyLCAxNjM4NCBieXRlcywgbGluZWFyKTxicj4NCiZndDvCoCDC oCDCoCDCoCZndDsgWyDCoCDCoDEuODg3MDc4XSBUYWJsZS1wZXJ0dXJiIGhhc2ggdGFibGUgZW50 cmllczogNjU1MzYgKG9yZGVyOiA2LCAyNjIxNDQgYnl0ZXMsIGxpbmVhcik8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjg5NDg0Nl0gVENQIGVzdGFibGlzaGVkIGhhc2ggdGFibGUg ZW50cmllczogMTYzODQgKG9yZGVyOiA1LCAxMzEwNzIgYnl0ZXMsIGxpbmVhcik8YnI+DQomZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjkwMjkwMF0gVENQIGJpbmQgaGFzaCB0YWJsZSBlbnRy aWVzOiAxNjM4NCAob3JkZXI6IDYsIDI2MjE0NCBieXRlcywgbGluZWFyKTxicj4NCiZndDvCoCDC oCDCoCDCoCZndDsgWyDCoCDCoDEuOTEwMzUwXSBUQ1A6IEhhc2ggdGFibGVzIGNvbmZpZ3VyZWQg KGVzdGFibGlzaGVkIDE2Mzg0IGJpbmQgMTYzODQpPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBb IMKgIMKgMS45MTY3NzhdIFVEUCBoYXNoIHRhYmxlIGVudHJpZXM6IDEwMjQgKG9yZGVyOiAzLCAz Mjc2OCBieXRlcywgbGluZWFyKTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDEuOTIz NTA5XSBVRFAtTGl0ZSBoYXNoIHRhYmxlIGVudHJpZXM6IDEwMjQgKG9yZGVyOiAzLCAzMjc2OCBi eXRlcywgbGluZWFyKTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDEuOTMwNzU5XSBO RVQ6IFJlZ2lzdGVyZWQgUEZfVU5JWC9QRl9MT0NBTCBwcm90b2NvbCBmYW1pbHk8YnI+DQomZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjkzNjgzNF0gUlBDOiBSZWdpc3RlcmVkIG5hbWVkIFVO SVggc29ja2V0IHRyYW5zcG9ydCBtb2R1bGUuPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKg IMKgMS45NDIzNDJdIFJQQzogUmVnaXN0ZXJlZCB1ZHAgdHJhbnNwb3J0IG1vZHVsZS48YnI+DQom Z3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjk0NzA4OF0gUlBDOiBSZWdpc3RlcmVkIHRjcCB0 cmFuc3BvcnQgbW9kdWxlLjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDEuOTUxODQz XSBSUEM6IFJlZ2lzdGVyZWQgdGNwIE5GU3Y0LjEgYmFja2NoYW5uZWwgdHJhbnNwb3J0IG1vZHVs ZS48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjk1ODMzNF0gUENJOiBDTFMgMCBi eXRlcywgZGVmYXVsdCA2NDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDEuOTYyNzA5 XSBUcnlpbmcgdG8gdW5wYWNrIHJvb3RmcyBpbWFnZSBhcyBpbml0cmFtZnMuLi48YnI+DQomZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjk3NzA5MF0gd29ya2luZ3NldDogdGltZXN0YW1wX2Jp dHM9NjIgbWF4X29yZGVyPTE5IGJ1Y2tldF9vcmRlcj0wPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0 OyBbIMKgIMKgMS45ODI4NjNdIEluc3RhbGxpbmcga25mc2QgKGNvcHlyaWdodCAoQykgMTk5NiA8 YSBocmVmPSJtYWlsdG86b2tpckBtb25hZC5zd2IuZGUiIHRhcmdldD0iX2JsYW5rIj5va2lyQG1v bmFkLnN3Yi5kZTwvYT4pLjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMDIxMDQ1 XSBORVQ6IFJlZ2lzdGVyZWQgUEZfQUxHIHByb3RvY29sIGZhbWlseTxicj4NCiZndDvCoCDCoCDC oCDCoCZndDsgWyDCoCDCoDIuMDIxMTIyXSB4b3I6IG1lYXN1cmluZyBzb2Z0d2FyZSBjaGVja3N1 bSBzcGVlZDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMDI5MzQ3XSDCoCDCoDhy ZWdzIMKgIMKgIMKgIMKgIMKgIDogwqAyMzY2IE1CL3NlYzxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDsgWyDCoCDCoDIuMDMzMDgxXSDCoCDCoDMycmVncyDCoCDCoCDCoCDCoCDCoDogwqAyODAyIE1C L3NlYzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMDM4MjIzXSDCoCDCoGFybTY0 X25lb24gwqAgwqAgwqA6IMKgMjMyMCBNQi9zZWM8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsg wqAgwqAyLjAzODM4NV0geG9yOiB1c2luZyBmdW5jdGlvbjogMzJyZWdzICgyODAyIE1CL3NlYyk8 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjA0MzYxNF0gQmxvY2sgbGF5ZXIgU0NT SSBnZW5lcmljIChic2cpIGRyaXZlciB2ZXJzaW9uIDAuNCBsb2FkZWQgKG1ham9yIDI0Nyk8YnI+ DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjA1MDk1OV0gaW8gc2NoZWR1bGVyIG1xLWRl YWRsaW5lIHJlZ2lzdGVyZWQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjA1NTUy MV0gaW8gc2NoZWR1bGVyIGt5YmVyIHJlZ2lzdGVyZWQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IFsgwqAgwqAyLjA2ODIyN10geGVuOnhlbl9ldnRjaG46IEV2ZW50LWNoYW5uZWwgZGV2aWNlIGlu c3RhbGxlZDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMDY5MjgxXSBTZXJpYWw6 IDgyNTAvMTY1NTAgZHJpdmVyLCA0IHBvcnRzLCBJUlEgc2hhcmluZyBkaXNhYmxlZDxicj4NCiZn dDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMDc2MTkwXSBjYWNoZWluZm86IFVuYWJsZSB0byBk ZXRlY3QgY2FjaGUgaGllcmFyY2h5IGZvciBDUFUgMDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsg WyDCoCDCoDIuMDg1NTQ4XSBicmQ6IG1vZHVsZSBsb2FkZWQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7IFsgwqAgwqAyLjA4OTI5MF0gbG9vcDogbW9kdWxlIGxvYWRlZDxicj4NCiZndDvCoCDCoCDC oCDCoCZndDsgWyDCoCDCoDIuMDg5MzQxXSBJbnZhbGlkIG1heF9xdWV1ZXMgKDQpLCB3aWxsIHVz ZSBkZWZhdWx0IG1heDogMi48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjA5NDU2 NV0gdHVuOiBVbml2ZXJzYWwgVFVOL1RBUCBkZXZpY2UgZHJpdmVyLCAxLjY8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjA5ODY1NV0geGVuX25ldGZyb250OiBJbml0aWFsaXNpbmcg WGVuIHZpcnR1YWwgZXRoZXJuZXQgZHJpdmVyPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKg IMKgMi4xMDQxNTZdIHVzYmNvcmU6IHJlZ2lzdGVyZWQgbmV3IGludGVyZmFjZSBkcml2ZXIgcnRs ODE1MDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMTA5ODEzXSB1c2Jjb3JlOiBy ZWdpc3RlcmVkIG5ldyBpbnRlcmZhY2UgZHJpdmVyIHI4MTUyPGJyPg0KJmd0O8KgIMKgIMKgIMKg Jmd0OyBbIMKgIMKgMi4xMTUzNjddIHVzYmNvcmU6IHJlZ2lzdGVyZWQgbmV3IGludGVyZmFjZSBk cml2ZXIgYXNpeDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMTIwNzk0XSB1c2Jj b3JlOiByZWdpc3RlcmVkIG5ldyBpbnRlcmZhY2UgZHJpdmVyIGF4ODgxNzlfMTc4YTxicj4NCiZn dDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMTI2OTM0XSB1c2Jjb3JlOiByZWdpc3RlcmVkIG5l dyBpbnRlcmZhY2UgZHJpdmVyIGNkY19ldGhlcjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDC oCDCoDIuMTMyODE2XSB1c2Jjb3JlOiByZWdpc3RlcmVkIG5ldyBpbnRlcmZhY2UgZHJpdmVyIGNk Y19lZW08YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjEzODUyN10gdXNiY29yZTog cmVnaXN0ZXJlZCBuZXcgaW50ZXJmYWNlIGRyaXZlciBuZXQxMDgwPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0OyBbIMKgIMKgMi4xNDQyNTZdIHVzYmNvcmU6IHJlZ2lzdGVyZWQgbmV3IGludGVyZmFj ZSBkcml2ZXIgY2RjX3N1YnNldDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMTUw MjA1XSB1c2Jjb3JlOiByZWdpc3RlcmVkIG5ldyBpbnRlcmZhY2UgZHJpdmVyIHphdXJ1czxicj4N CiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMTU1ODM3XSB1c2Jjb3JlOiByZWdpc3RlcmVk IG5ldyBpbnRlcmZhY2UgZHJpdmVyIGNkY19uY208YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsg wqAgwqAyLjE2MTU1MF0gdXNiY29yZTogcmVnaXN0ZXJlZCBuZXcgaW50ZXJmYWNlIGRyaXZlciBy ODE1M19lY208YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjE2ODI0MF0gdXNiY29y ZTogcmVnaXN0ZXJlZCBuZXcgaW50ZXJmYWNlIGRyaXZlciBjZGNfYWNtPGJyPg0KJmd0O8KgIMKg IMKgIMKgJmd0OyBbIMKgIMKgMi4xNzMxMDldIGNkY19hY206IFVTQiBBYnN0cmFjdCBDb250cm9s IE1vZGVsIGRyaXZlciBmb3IgVVNCIG1vZGVtcyBhbmQgSVNETiBhZGFwdGVyczxicj4NCiZndDvC oCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMTgxMzU4XSB1c2Jjb3JlOiByZWdpc3RlcmVkIG5ldyBp bnRlcmZhY2UgZHJpdmVyIHVhczxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMTg2 NTQ3XSB1c2Jjb3JlOiByZWdpc3RlcmVkIG5ldyBpbnRlcmZhY2UgZHJpdmVyIHVzYi1zdG9yYWdl PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi4xOTI2NDNdIHVzYmNvcmU6IHJlZ2lz dGVyZWQgbmV3IGludGVyZmFjZSBkcml2ZXIgZnRkaV9zaW88YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7IFsgwqAgwqAyLjE5ODM4NF0gdXNic2VyaWFsOiBVU0IgU2VyaWFsIHN1cHBvcnQgcmVnaXN0 ZXJlZCBmb3IgRlRESSBVU0IgU2VyaWFsIERldmljZTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsg WyDCoCDCoDIuMjA2MTE4XSB1ZGMtY29yZTogY291bGRuJiMzOTt0IGZpbmQgYW4gYXZhaWxhYmxl IFVEQyAtIGFkZGVkIFtnX21hc3Nfc3RvcmFnZV0gdG8gbGlzdCBvZiBwZW5kaW5nIGRyaXZlcnM8 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjIxNTMzMl0gaTJjX2RldjogaTJjIC9k ZXYgZW50cmllcyBkcml2ZXI8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjIyMDQ2 N10geGVuX3dkdCB4ZW5fd2R0OiBpbml0aWFsaXplZCAodGltZW91dD02MHMsIG5vd2F5b3V0PTAp PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi4yMjU5MjNdIGRldmljZS1tYXBwZXI6 IHVldmVudDogdmVyc2lvbiAxLjAuMzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIu MjMwNjY4XSBkZXZpY2UtbWFwcGVyOiBpb2N0bDogNC40NS4wLWlvY3RsICgyMDIxLTAzLTIyKSBp bml0aWFsaXNlZDogPGEgaHJlZj0ibWFpbHRvOmRtLWRldmVsQHJlZGhhdC5jb20iIHRhcmdldD0i X2JsYW5rIj5kbS1kZXZlbEByZWRoYXQuY29tPC9hPjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsg WyDCoCDCoDIuMjM5MzE1XSBFREFDIE1DMDogR2l2aW5nIG91dCBkZXZpY2UgdG8gbW9kdWxlIDEg Y29udHJvbGxlciBzeW5wc19kZHJfY29udHJvbGxlcjogREVWIHN5bnBzX2VkYWMgKElOVEVSUlVQ VCk8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjI0OTQwNV0gRURBQyBERVZJQ0Uw OiBHaXZpbmcgb3V0IGRldmljZSB0byBtb2R1bGUgenlucW1wLW9jbS1lZGFjIGNvbnRyb2xsZXIg enlucW1wX29jbTogREVWPGJyPg0KJmd0O8KgIMKgIMKgIMKgZmY5NjAwMDAubWVtb3J5LWNvbnRy b2xsZXIgKElOVEVSUlVQVCk8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjI2MTcx OV0gc2RoY2k6IFNlY3VyZSBEaWdpdGFsIEhvc3QgQ29udHJvbGxlciBJbnRlcmZhY2UgZHJpdmVy PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi4yNjc0ODddIHNkaGNpOiBDb3B5cmln aHQoYykgUGllcnJlIE9zc21hbjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMjcx ODkwXSBzZGhjaS1wbHRmbTogU0RIQ0kgcGxhdGZvcm0gYW5kIE9GIGRyaXZlciBoZWxwZXI8YnI+ DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjI3ODE1N10gbGVkdHJpZy1jcHU6IHJlZ2lz dGVyZWQgdG8gaW5kaWNhdGUgYWN0aXZpdHkgb24gQ1BVczxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDsgWyDCoCDCoDIuMjgzODE2XSB6eW5xbXBfZmlybXdhcmVfcHJvYmUgUGxhdGZvcm0gTWFuYWdl bWVudCBBUEkgdjEuMTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMjg5NTU0XSB6 eW5xbXBfZmlybXdhcmVfcHJvYmUgVHJ1c3R6b25lIHZlcnNpb24gdjEuMDxicj4NCiZndDvCoCDC oCDCoCDCoCZndDsgWyDCoCDCoDIuMzI3ODc1XSBzZWN1cmVmdyBzZWN1cmVmdzogc2VjdXJlZncg cHJvYmVkPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi4zMjgzMjRdIGFsZzogTm8g dGVzdCBmb3IgeGlsaW54LXp5bnFtcC1hZXMgKHp5bnFtcC1hZXMpPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0OyBbIMKgIMKgMi4zMzI1NjNdIHp5bnFtcF9hZXMgZmlybXdhcmU6enlucW1wLWZpcm13 YXJlOnp5bnFtcC1hZXM6IEFFUyBTdWNjZXNzZnVsbHkgUmVnaXN0ZXJlZDxicj4NCiZndDvCoCDC oCDCoCDCoCZndDsgWyDCoCDCoDIuMzQxMTgzXSBhbGc6IE5vIHRlc3QgZm9yIHhpbGlueC16eW5x bXAtcnNhICh6eW5xbXAtcnNhKTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMzQ3 NjY3XSByZW1vdGVwcm9jIHJlbW90ZXByb2MwOiBmZjlhMDAwMC5yZjVzczpyNWZfMCBpcyBhdmFp bGFibGU8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjM1MzAwM10gcmVtb3RlcHJv YyByZW1vdGVwcm9jMTogZmY5YTAwMDAucmY1c3M6cjVmXzEgaXMgYXZhaWxhYmxlPGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi4zNjI2MDVdIGZwZ2FfbWFuYWdlciBmcGdhMDogWGls aW54IFp5bnFNUCBGUEdBIE1hbmFnZXIgcmVnaXN0ZXJlZDxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDsgWyDCoCDCoDIuMzY2NTQwXSB2aXBlci14ZW4tcHJveHkgdmlwZXIteGVuLXByb3h5OiBWaXBl ciBYZW4gUHJveHkgcmVnaXN0ZXJlZDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIu MzcyNTI1XSB2aXBlci12ZHBwIGE0MDAwMDAwLnZkcHA6IERldmljZSBUcmVlIFByb2Jpbmc8YnI+ DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjM3Nzc3OF0gdmlwZXItdmRwcCBhNDAwMDAw MC52ZHBwOiBWRFBQIFZlcnNpb246IDEuMy45LjAgSW5mbzogMS41MTIuMTUuMCBLZXlMZW46IDMy PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi4zODY0MzJdIHZpcGVyLXZkcHAgYTQw MDAwMDAudmRwcDogVW5hYmxlIHRvIHJlZ2lzdGVyIHRhbXBlciBoYW5kbGVyLiBSZXRyeWluZy4u Ljxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMzk0MDk0XSB2aXBlci12ZHBwLW5l dCBhNTAwMDAwMC52ZHBwX25ldDogRGV2aWNlIFRyZWUgUHJvYmluZzxicj4NCiZndDvCoCDCoCDC oCDCoCZndDsgWyDCoCDCoDIuMzk5ODU0XSB2aXBlci12ZHBwLW5ldCBhNTAwMDAwMC52ZHBwX25l dDogRGV2aWNlIHJlZ2lzdGVyZWQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjQw NTkzMV0gdmlwZXItdmRwcC1zdGF0IGE4MDAwMDAwLnZkcHBfc3RhdDogRGV2aWNlIFRyZWUgUHJv YmluZzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuNDEyMDM3XSB2aXBlci12ZHBw LXN0YXQgYTgwMDAwMDAudmRwcF9zdGF0OiBCdWlsZCBwYXJhbWV0ZXJzOiBWVEkgQ291bnQ6IDUx MiBFdmVudCBDb3VudDogMzI8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjQyMDg1 Nl0gZGVmYXVsdCBwcmVzZXQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjQyMzc5 N10gdmlwZXItdmRwcC1zdGF0IGE4MDAwMDAwLnZkcHBfc3RhdDogRGV2aWNlIHJlZ2lzdGVyZWQ8 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjQzMDA1NF0gdmlwZXItdmRwcC1ybmcg YWMwMDAwMDAudmRwcF9ybmc6IERldmljZSBUcmVlIFByb2Jpbmc8YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7IFsgwqAgwqAyLjQzNTk0OF0gdmlwZXItdmRwcC1ybmcgYWMwMDAwMDAudmRwcF9ybmc6 IERldmljZSByZWdpc3RlcmVkPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi40NDE5 NzZdIHZtY3UgZHJpdmVyIGluaXQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjQ0 NDkyMl0gVk1DVTogOiAoMjQwOjApIHJlZ2lzdGVyZWQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IFsgwqAgwqAyLjQ0NDk1Nl0gSW4gSzgxIFVwZGF0ZXIgaW5pdDxicj4NCiZndDvCoCDCoCDCoCDC oCZndDsgWyDCoCDCoDIuNDQ5MDAzXSBwa3RnZW46IFBhY2tldCBHZW5lcmF0b3IgZm9yIHBhY2tl dCBwZXJmb3JtYW5jZSB0ZXN0aW5nLiBWZXJzaW9uOiAyLjc1PGJyPg0KJmd0O8KgIMKgIMKgIMKg Jmd0OyBbIMKgIMKgMi40Njg4MzNdIEluaXRpYWxpemluZyBYRlJNIG5ldGxpbmsgc29ja2V0PGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi40Njg5MDJdIE5FVDogUmVnaXN0ZXJlZCBQ Rl9QQUNLRVQgcHJvdG9jb2wgZmFtaWx5PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKg Mi40NzI3MjldIEJyaWRnZSBmaXJld2FsbGluZyByZWdpc3RlcmVkPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0OyBbIMKgIMKgMi40NzY3ODVdIDgwMjFxOiA4MDIuMVEgVkxBTiBTdXBwb3J0IHYxLjg8 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjQ4MTM0MV0gcmVnaXN0ZXJlZCB0YXNr c3RhdHMgdmVyc2lvbiAxPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi40ODYzOTRd IEJ0cmZzIGxvYWRlZCwgY3JjMzJjPWNyYzMyYy1nZW5lcmljLCB6b25lZD1ubywgZnN2ZXJpdHk9 bm88YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjUwMzE0NV0gZmYwMTAwMDAuc2Vy aWFsOiB0dHlQUzEgYXQgTU1JTyAweGZmMDEwMDAwIChpcnEgPSAzNiwgYmFzZV9iYXVkID0gNjI1 MDAwMCkgaXMgYSB4dWFydHBzPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi41MDcx MDNdIG9mLWZwZ2EtcmVnaW9uIGZwZ2EtZnVsbDogRlBHQSBSZWdpb24gcHJvYmVkPGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi41MTI5ODZdIHhpbGlueC16eW5xbXAtZG1hIGZkNTAw MDAwLmRtYS1jb250cm9sbGVyOiBaeW5xTVAgRE1BIGRyaXZlciBQcm9iZSBzdWNjZXNzPGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi41MjAyNjddIHhpbGlueC16eW5xbXAtZG1hIGZk NTEwMDAwLmRtYS1jb250cm9sbGVyOiBaeW5xTVAgRE1BIGRyaXZlciBQcm9iZSBzdWNjZXNzPGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi41MjgyMzldIHhpbGlueC16eW5xbXAtZG1h IGZkNTIwMDAwLmRtYS1jb250cm9sbGVyOiBaeW5xTVAgRE1BIGRyaXZlciBQcm9iZSBzdWNjZXNz PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi41MzYxNTJdIHhpbGlueC16eW5xbXAt ZG1hIGZkNTMwMDAwLmRtYS1jb250cm9sbGVyOiBaeW5xTVAgRE1BIGRyaXZlciBQcm9iZSBzdWNj ZXNzPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi41NDQxNTNdIHhpbGlueC16eW5x bXAtZG1hIGZkNTQwMDAwLmRtYS1jb250cm9sbGVyOiBaeW5xTVAgRE1BIGRyaXZlciBQcm9iZSBz dWNjZXNzPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi41NTIxMjddIHhpbGlueC16 eW5xbXAtZG1hIGZkNTUwMDAwLmRtYS1jb250cm9sbGVyOiBaeW5xTVAgRE1BIGRyaXZlciBQcm9i ZSBzdWNjZXNzPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi41NjAxNzhdIHhpbGlu eC16eW5xbXAtZG1hIGZmYTgwMDAwLmRtYS1jb250cm9sbGVyOiBaeW5xTVAgRE1BIGRyaXZlciBQ cm9iZSBzdWNjZXNzPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi41Njc5ODddIHhp bGlueC16eW5xbXAtZG1hIGZmYTkwMDAwLmRtYS1jb250cm9sbGVyOiBaeW5xTVAgRE1BIGRyaXZl ciBQcm9iZSBzdWNjZXNzPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi41NzYwMThd IHhpbGlueC16eW5xbXAtZG1hIGZmYWEwMDAwLmRtYS1jb250cm9sbGVyOiBaeW5xTVAgRE1BIGRy aXZlciBQcm9iZSBzdWNjZXNzPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi41ODM4 ODldIHhpbGlueC16eW5xbXAtZG1hIGZmYWIwMDAwLmRtYS1jb250cm9sbGVyOiBaeW5xTVAgRE1B IGRyaXZlciBQcm9iZSBzdWNjZXNzPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi45 NDYzNzldIHNwaS1ub3Igc3BpMC4wOiBtdDI1cXU1MTJhICgxMzEwNzIgS2J5dGVzKTxicj4NCiZn dDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuOTQ2NDY3XSAyIGZpeGVkLXBhcnRpdGlvbnMgcGFy dGl0aW9ucyBmb3VuZCBvbiBNVEQgZGV2aWNlIHNwaTAuMDxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDsgWyDCoCDCoDIuOTUyMzkzXSBDcmVhdGluZyAyIE1URCBwYXJ0aXRpb25zIG9uICZxdW90O3Nw aTAuMCZxdW90Ozo8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjk1NzIzMV0gMHgw MDAwMDQwMDAwMDAtMHgwMDAwMDgwMDAwMDAgOiAmcXVvdDtiYW5rIEEmcXVvdDs8YnI+DQomZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjk2MzMzMl0gMHgwMDAwMDAwMDAwMDAtMHgwMDAwMDQw MDAwMDAgOiAmcXVvdDtiYW5rIEImcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAg wqAyLjk2ODY5NF0gbWFjYiBmZjBiMDAwMC5ldGhlcm5ldDogTm90IGVuYWJsaW5nIHBhcnRpYWwg c3RvcmUgYW5kIGZvcndhcmQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjk3NTMz M10gbWFjYiBmZjBiMDAwMC5ldGhlcm5ldCBldGgwOiBDYWRlbmNlIEdFTSByZXYgMHg1MDA3MDEw NiBhdCAweGZmMGIwMDAwIGlycSAyNSAoMTg6NDE6ZmU6MGY6ZmY6MDIpPGJyPg0KJmd0O8KgIMKg IMKgIMKgJmd0OyBbIMKgIMKgMi45ODQ0NzJdIG1hY2IgZmYwYzAwMDAuZXRoZXJuZXQ6IE5vdCBl bmFibGluZyBwYXJ0aWFsIHN0b3JlIGFuZCBmb3J3YXJkPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0 OyBbIMKgIMKgMi45OTIxNDRdIG1hY2IgZmYwYzAwMDAuZXRoZXJuZXQgZXRoMTogQ2FkZW5jZSBH RU0gcmV2IDB4NTAwNzAxMDYgYXQgMHhmZjBjMDAwMCBpcnEgMjYgKDE4OjQxOmZlOjBmOmZmOjAz KTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuMDAxMDQzXSB2aXBlcl9lbmV0IHZp cGVyX2VuZXQ6IFZpcGVyIHBvd2VyIEdQSU9zIGluaXRpYWxpc2VkPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0OyBbIMKgIMKgMy4wMDczMTNdIHZpcGVyX2VuZXQgdmlwZXJfZW5ldCB2bmV0MCAodW5p bml0aWFsaXplZCk6IFZhbGlkYXRlIGludGVyZmFjZSBRU0dNSUk8YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7IFsgwqAgwqAzLjAxNDkxNF0gdmlwZXJfZW5ldCB2aXBlcl9lbmV0IHZuZXQxICh1bmlu aXRpYWxpemVkKTogVmFsaWRhdGUgaW50ZXJmYWNlIFFTR01JSTxicj4NCiZndDvCoCDCoCDCoCDC oCZndDsgWyDCoCDCoDMuMDIyMTM4XSB2aXBlcl9lbmV0IHZpcGVyX2VuZXQgdm5ldDEgKHVuaW5p dGlhbGl6ZWQpOiBWYWxpZGF0ZSBpbnRlcmZhY2UgdHlwZSAxODxicj4NCiZndDvCoCDCoCDCoCDC oCZndDsgWyDCoCDCoDMuMDMwMjc0XSB2aXBlcl9lbmV0IHZpcGVyX2VuZXQgdm5ldDIgKHVuaW5p dGlhbGl6ZWQpOiBWYWxpZGF0ZSBpbnRlcmZhY2UgUVNHTUlJPGJyPg0KJmd0O8KgIMKgIMKgIMKg Jmd0OyBbIMKgIMKgMy4wMzc3ODVdIHZpcGVyX2VuZXQgdmlwZXJfZW5ldCB2bmV0MyAodW5pbml0 aWFsaXplZCk6IFZhbGlkYXRlIGludGVyZmFjZSBRU0dNSUk8YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7IFsgwqAgwqAzLjA0NTMwMV0gdmlwZXJfZW5ldCB2aXBlcl9lbmV0OiBWaXBlciBlbmV0IHJl Z2lzdGVyZWQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjA1MDk1OF0geGlsaW54 LWF4aXBtb24gZmZhMDAwMDAucGVyZi1tb25pdG9yOiBQcm9iZWQgWGlsaW54IEFQTTxicj4NCiZn dDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuMDU3MTM1XSB4aWxpbngtYXhpcG1vbiBmZDBiMDAw MC5wZXJmLW1vbml0b3I6IFByb2JlZCBYaWxpbnggQVBNPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0 OyBbIMKgIMKgMy4wNjM1MzhdIHhpbGlueC1heGlwbW9uIGZkNDkwMDAwLnBlcmYtbW9uaXRvcjog UHJvYmVkIFhpbGlueCBBUE08YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjA2OTky MF0geGlsaW54LWF4aXBtb24gZmZhMTAwMDAucGVyZi1tb25pdG9yOiBQcm9iZWQgWGlsaW54IEFQ TTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuMDk3NzI5XSBzaTcweHg6IHByb2Jl IG9mIDItMDA0MCBmYWlsZWQgd2l0aCBlcnJvciAtNTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsg WyDCoCDCoDMuMDk4MDQyXSBjZG5zLXdkdCBmZDRkMDAwMC53YXRjaGRvZzogWGlsaW54IFdhdGNo ZG9nIFRpbWVyIHdpdGggdGltZW91dCA2MHM8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAg wqAzLjEwNTExMV0gY2Rucy13ZHQgZmYxNTAwMDAud2F0Y2hkb2c6IFhpbGlueCBXYXRjaGRvZyBU aW1lciB3aXRoIHRpbWVvdXQgMTBzPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy4x MTI0NTddIHZpcGVyLXRhbXBlciB2aXBlci10YW1wZXI6IERldmljZSByZWdpc3RlcmVkPGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy4xMTc1OTNdIGFjdGl2ZV9iYW5rIGFjdGl2ZV9i YW5rOiBib290IGJhbms6IDE8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjEyMjE4 NF0gYWN0aXZlX2JhbmsgYWN0aXZlX2Jhbms6IGJvb3QgbW9kZTogKDB4MDIpIHFzcGkzMjxicj4N CiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuMTI4MjQ3XSB2aXBlci12ZHBwIGE0MDAwMDAw LnZkcHA6IERldmljZSBUcmVlIFByb2Jpbmc8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAg wqAzLjEzMzQzOV0gdmlwZXItdmRwcCBhNDAwMDAwMC52ZHBwOiBWRFBQIFZlcnNpb246IDEuMy45 LjAgSW5mbzogMS41MTIuMTUuMCBLZXlMZW46IDMyPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBb IMKgIMKgMy4xNDIxNTFdIHZpcGVyLXZkcHAgYTQwMDAwMDAudmRwcDogVGFtcGVyIGhhbmRsZXIg cmVnaXN0ZXJlZDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuMTQ3NDM4XSB2aXBl ci12ZHBwIGE0MDAwMDAwLnZkcHA6IERldmljZSByZWdpc3RlcmVkPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0OyBbIMKgIMKgMy4xNTMwMDddIGxwYzU1X2wyIHNwaTEuMDogcmVnaXN0ZXJlZCBoYW5k bGVyIGZvciBwcm90b2NvbCAwPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy4xNTg1 ODJdIGxwYzU1X3VzZXIgbHBjNTVfdXNlcjogVGhlIG1ham9yIG51bWJlciBmb3IgeW91ciBkZXZp Y2UgaXMgMjM2PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy4xNjU5NzZdIGxwYzU1 X2wyIHNwaTEuMDogcmVnaXN0ZXJlZCBoYW5kbGVyIGZvciBwcm90b2NvbCAxPGJyPg0KJmd0O8Kg IMKgIMKgIMKgJmd0OyBbIMKgIMKgMy4xODE5OTldIHJ0Yy1scGM1NSBydGNfbHBjNTU6IGxwYzU1 X3J0Y19nZXRfdGltZTogYmFkIHJlc3VsdDogMTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDC oCDCoDMuMTgyODU2XSBydGMtbHBjNTUgcnRjX2xwYzU1OiByZWdpc3RlcmVkIGFzIHJ0YzA8YnI+ DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjE4ODY1Nl0gbHBjNTVfbDIgc3BpMS4wOiAo MikgbWN1IHN0aWxsIG5vdCByZWFkeT88YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAz LjE5Mzc0NF0gbHBjNTVfbDIgc3BpMS4wOiAoMykgbWN1IHN0aWxsIG5vdCByZWFkeT88YnI+DQom Z3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjE5ODg0OF0gbHBjNTVfbDIgc3BpMS4wOiAoNCkg bWN1IHN0aWxsIG5vdCByZWFkeT88YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjIw MjkzMl0gbW1jMDogU0RIQ0kgY29udHJvbGxlciBvbiBmZjE2MDAwMC5tbWMgW2ZmMTYwMDAwLm1t Y10gdXNpbmcgQURNQSA2NC1iaXQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjIx MDY4OV0gbHBjNTVfbDIgc3BpMS4wOiAoNSkgbWN1IHN0aWxsIG5vdCByZWFkeT88YnI+DQomZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjIxNTY5NF0gbHBjNTVfbDIgc3BpMS4wOiByeCBlcnJv cjogLTExMDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuMjg0NDM4XSBtbWMwOiBu ZXcgSFMyMDAgTU1DIGNhcmQgYXQgYWRkcmVzcyAwMDAxPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0 OyBbIMKgIMKgMy4yODUxNzldIG1tY2JsazA6IG1tYzA6MDAwMSBTRU0xNkcgMTQuNiBHaUI8YnI+ DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjI5MTc4NF0gwqBtbWNibGswOiBwMSBwMiBw MyBwNCBwNSBwNiBwNyBwODxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuMjkzOTE1 XSBtbWNibGswYm9vdDA6IG1tYzA6MDAwMSBTRU0xNkcgNC4wMCBNaUI8YnI+DQomZ3Q7wqAgwqAg wqAgwqAmZ3Q7IFsgwqAgwqAzLjI5OTA1NF0gbW1jYmxrMGJvb3QxOiBtbWMwOjAwMDEgU0VNMTZH IDQuMDAgTWlCPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy4zMDM5MDVdIG1tY2Js azBycG1iOiBtbWMwOjAwMDEgU0VNMTZHIDQuMDAgTWlCLCBjaGFyZGV2ICgyNDQ6MCk8YnI+DQom Z3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjU4MjY3Nl0gcnRjLWxwYzU1IHJ0Y19scGM1NTog bHBjNTVfcnRjX2dldF90aW1lOiBiYWQgcmVzdWx0OiAxPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0 OyBbIMKgIMKgMy41ODMzMzJdIHJ0Yy1scGM1NSBydGNfbHBjNTU6IGhjdG9zeXM6IHVuYWJsZSB0 byByZWFkIHRoZSBoYXJkd2FyZSBjbG9jazxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDC oDMuNTkxMjUyXSBjZG5zLWkyYyBmZjAyMDAwMC5pMmM6IHJlY292ZXJ5IGluZm9ybWF0aW9uIGNv bXBsZXRlPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy41OTcwODVdIGF0MjQgMC0w MDUwOiBzdXBwbHkgdmNjIG5vdCBmb3VuZCwgdXNpbmcgZHVtbXkgcmVndWxhdG9yPGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy42MDMwMTFdIGxwYzU1X2wyIHNwaTEuMDogKDIpIG1j dSBzdGlsbCBub3QgcmVhZHk/PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy42MDgw OTNdIGF0MjQgMC0wMDUwOiAyNTYgYnl0ZSBzcGQgRUVQUk9NLCByZWFkLW9ubHk8YnI+DQomZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjYxMzYyMF0gbHBjNTVfbDIgc3BpMS4wOiAoMykgbWN1 IHN0aWxsIG5vdCByZWFkeT88YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjYxOTM2 Ml0gbHBjNTVfbDIgc3BpMS4wOiAoNCkgbWN1IHN0aWxsIG5vdCByZWFkeT88YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjYyNDIyNF0gcnRjLXJ2MzAyOCAwLTAwNTI6IHJlZ2lzdGVy ZWQgYXMgcnRjMTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuNjI4MzQzXSBscGM1 NV9sMiBzcGkxLjA6ICg1KSBtY3Ugc3RpbGwgbm90IHJlYWR5Pzxicj4NCiZndDvCoCDCoCDCoCDC oCZndDsgWyDCoCDCoDMuNjMzMjUzXSBscGM1NV9sMiBzcGkxLjA6IHJ4IGVycm9yOiAtMTEwPGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy42MzkxMDRdIGs4MV9ib290bG9hZGVyIDAt MDAxMDogcHJvYmU8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjY0MTYyOF0gVk1D VTogOiAoMjM1OjApIHJlZ2lzdGVyZWQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAz LjY0MTYzNV0gazgxX2Jvb3Rsb2FkZXIgMC0wMDEwOiBwcm9iZSBjb21wbGV0ZWQ8YnI+DQomZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjY2ODM0Nl0gY2Rucy1pMmMgZmYwMjAwMDAuaTJjOiA0 MDAga0h6IG1taW8gZmYwMjAwMDAgaXJxIDI4PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKg IMKgMy42NjkxNTRdIGNkbnMtaTJjIGZmMDMwMDAwLmkyYzogcmVjb3ZlcnkgaW5mb3JtYXRpb24g Y29tcGxldGU8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjY3NTQxMl0gbG03NSAx LTAwNDg6IHN1cHBseSB2cyBub3QgZm91bmQsIHVzaW5nIGR1bW15IHJlZ3VsYXRvcjxicj4NCiZn dDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuNjgyOTIwXSBsbTc1IDEtMDA0ODogaHdtb24xOiBz ZW5zb3IgJiMzOTt0bXAxMTImIzM5Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMu Njg2NTQ4XSBpMmMgaTJjLTE6IEFkZGVkIG11bHRpcGxleGVkIGkyYyBidXMgMzxicj4NCiZndDvC oCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuNjkwNzk1XSBpMmMgaTJjLTE6IEFkZGVkIG11bHRpcGxl eGVkIGkyYyBidXMgNDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuNjk1NjI5XSBp MmMgaTJjLTE6IEFkZGVkIG11bHRpcGxleGVkIGkyYyBidXMgNTxicj4NCiZndDvCoCDCoCDCoCDC oCZndDsgWyDCoCDCoDMuNzAwNDkyXSBpMmMgaTJjLTE6IEFkZGVkIG11bHRpcGxleGVkIGkyYyBi dXMgNjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuNzA1MTU3XSBwY2E5NTR4IDEt MDA3MDogcmVnaXN0ZXJlZCA0IG11bHRpcGxleGVkIGJ1c3NlcyBmb3IgSTJDIHN3aXRjaCBwY2E5 NTQ2PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy43MTMwNDldIGF0MjQgMS0wMDU0 OiBzdXBwbHkgdmNjIG5vdCBmb3VuZCwgdXNpbmcgZHVtbXkgcmVndWxhdG9yPGJyPg0KJmd0O8Kg IMKgIMKgIMKgJmd0OyBbIMKgIMKgMy43MjAwNjddIGF0MjQgMS0wMDU0OiAxMDI0IGJ5dGUgMjRj MDggRUVQUk9NLCByZWFkLW9ubHk8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjcy NDc2MV0gY2Rucy1pMmMgZmYwMzAwMDAuaTJjOiAxMDAga0h6IG1taW8gZmYwMzAwMDAgaXJxIDI5 PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy43MzEyNzJdIHNmcCB2aXBlcl9lbmV0 OnNmcC1ldGgxOiBIb3N0IG1heGltdW0gcG93ZXIgMi4wVzxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDsgWyDCoCDCoDMuNzM3NTQ5XSBzZnBfcmVnaXN0ZXJfc29ja2V0OiBnb3Qgc2ZwX2J1czxicj4N CiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuNzQwNzA5XSBzZnBfcmVnaXN0ZXJfc29ja2V0 OiByZWdpc3RlciBzZnBfYnVzPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy43NDU0 NTldIHNmcF9yZWdpc3Rlcl9idXM6IG9wcyBvayE8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsg wqAgwqAzLjc0OTE3OV0gc2ZwX3JlZ2lzdGVyX2J1czogVHJ5IHRvIGF0dGFjaDxicj4NCiZndDvC oCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuNzUzNDE5XSBzZnBfcmVnaXN0ZXJfYnVzOiBBdHRhY2gg c3VjY2VlZGVkPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy43NTc5MTRdIHNmcF9y ZWdpc3Rlcl9idXM6IHVwc3RyZWFtIG9wcyBhdHRhY2g8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IFsgwqAgwqAzLjc2MjY3N10gc2ZwX3JlZ2lzdGVyX2J1czogQnVzIHJlZ2lzdGVyZWQ8YnI+DQom Z3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjc2Njk5OV0gc2ZwX3JlZ2lzdGVyX3NvY2tldDog cmVnaXN0ZXIgc2ZwX2J1cyBzdWNjZWVkZWQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAg wqAzLjc3NTg3MF0gb2ZfY2ZzX2luaXQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAz Ljc3NjAwMF0gb2ZfY2ZzX2luaXQ6IE9LPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKg My43NzgyMTFdIGNsazogTm90IGRpc2FibGluZyB1bnVzZWQgY2xvY2tzPGJyPg0KJmd0O8KgIMKg IMKgIMKgJmd0OyBbIMKgIDExLjI3ODQ3N10gRnJlZWluZyBpbml0cmQgbWVtb3J5OiAyMDYwNTZL PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjI3OTQwNl0gRnJlZWluZyB1bnVzZWQg a2VybmVsIG1lbW9yeTogMTUzNks8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMzE0 MDA2XSBDaGVja2VkIFcrWCBtYXBwaW5nczogcGFzc2VkLCBubyBXK1ggcGFnZXMgZm91bmQ8YnI+ DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMzE0MTQyXSBSdW4gL2luaXQgYXMgaW5pdCBw cm9jZXNzPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBJTklUOiB2ZXJzaW9uIDMuMDEgYm9vdGlu Zzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgZnNjayAoYnVzeWJveCAxLjM1LjApPGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0OyAvZGV2L21tY2JsazBwMTogY2xlYW4sIDEyLzEwMjQwMCBmaWxlcywg MjM4MTYyLzQwOTYwMCBibG9ja3M8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IC9kZXYvbW1jYmxr MHAyOiBjbGVhbiwgMTIvMTAyNDAwIGZpbGVzLCAxNzE5NzIvNDA5NjAwIGJsb2Nrczxicj4NCiZn dDvCoCDCoCDCoCDCoCZndDsgL2Rldi9tbWNibGswcDMgd2FzIG5vdCBjbGVhbmx5IHVubW91bnRl ZCwgY2hlY2sgZm9yY2VkLjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgL2Rldi9tbWNibGswcDM6 IDIwLzQwOTYgZmlsZXMgKDAuMCUgbm9uLWNvbnRpZ3VvdXMpLCA2NjMvMTYzODQgYmxvY2tzPGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjU1MzA3M10gRVhUNC1mcyAobW1jYmxrMHAz KTogbW91bnRlZCBmaWxlc3lzdGVtIHdpdGhvdXQgam91cm5hbC4gT3B0czogKG51bGwpLiBRdW90 YSBtb2RlOiBkaXNhYmxlZC48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFN0YXJ0aW5nIHJhbmRv bSBudW1iZXIgZ2VuZXJhdG9yIGRhZW1vbi48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAg MTEuNTgwNjYyXSByYW5kb206IGNybmcgaW5pdCBkb25lPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0 OyBTdGFydGluZyB1ZGV2PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjYxMzE1OV0g dWRldmRbMTQyXTogc3RhcnRpbmcgdmVyc2lvbiAzLjIuMTA8YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7IFsgwqAgMTEuNjIwMzg1XSB1ZGV2ZFsxNDNdOiBzdGFydGluZyBldWRldi0zLjIuMTA8YnI+ DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuNzA0NDgxXSBtYWNiIGZmMGIwMDAwLmV0aGVy bmV0IGNvbnRyb2xfcmVkOiByZW5hbWVkIGZyb20gZXRoMDxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDsgWyDCoCAxMS43MjAyNjRdIG1hY2IgZmYwYzAwMDAuZXRoZXJuZXQgY29udHJvbF9ibGFjazog cmVuYW1lZCBmcm9tIGV0aDE8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTIuMDYzMzk2 XSBpcF9sb2NhbF9wb3J0X3JhbmdlOiBwcmVmZXIgZGlmZmVyZW50IHBhcml0eSBmb3Igc3RhcnQv ZW5kIHZhbHVlcy48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTIuMDg0ODAxXSBydGMt bHBjNTUgcnRjX2xwYzU1OiBscGM1NV9ydGNfZ2V0X3RpbWU6IGJhZCByZXN1bHQ6IDE8YnI+DQom Z3Q7wqAgwqAgwqAgwqAmZ3Q7IGh3Y2xvY2s6IFJUQ19SRF9USU1FOiBJbnZhbGlkIGV4Y2hhbmdl PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBNb24gRmViIDI3IDA4OjQwOjUzIFVUQyAyMDIzPGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDEyLjExNTMwOV0gcnRjLWxwYzU1IHJ0Y19scGM1 NTogbHBjNTVfcnRjX3NldF90aW1lOiBiYWQgcmVzdWx0PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0 OyBod2Nsb2NrOiBSVENfU0VUX1RJTUU6IEludmFsaWQgZXhjaGFuZ2U8YnI+DQomZ3Q7wqAgwqAg wqAgwqAmZ3Q7IFsgwqAgMTIuMTMxMDI3XSBydGMtbHBjNTUgcnRjX2xwYzU1OiBscGM1NV9ydGNf Z2V0X3RpbWU6IGJhZCByZXN1bHQ6IDE8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFN0YXJ0aW5n IG1jdWQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IElOSVQ6IEVudGVyaW5nIHJ1bmxldmVsOiA1 PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBDb25maWd1cmluZyBuZXR3b3JrIGludGVyZmFjZXMu Li4gZG9uZS48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IHJlc2V0dGluZyBuZXR3b3JrIGludGVy ZmFjZTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxMi43MTgyOTVdIG1hY2IgZmYwYjAw MDAuZXRoZXJuZXQgY29udHJvbF9yZWQ6IFBIWSBbZmYwYjAwMDAuZXRoZXJuZXQtZmZmZmZmZmY6 MDJdIGRyaXZlciBbWGlsaW54IFBDUy9QTUEgUEhZXSAoaXJxPVBPTEwpPGJyPg0KJmd0O8KgIMKg IMKgIMKgJmd0OyBbIMKgIDEyLjcyMzkxOV0gbWFjYiBmZjBiMDAwMC5ldGhlcm5ldCBjb250cm9s X3JlZDogY29uZmlndXJpbmcgZm9yIHBoeS9nbWlpIGxpbmsgbW9kZTxicj4NCiZndDvCoCDCoCDC oCDCoCZndDsgWyDCoCAxMi43MzIxNTFdIHBwcyBwcHMwOiBuZXcgUFBTIHNvdXJjZSBwdHAwPGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDEyLjczNTU2M10gbWFjYiBmZjBiMDAwMC5ldGhl cm5ldDogZ2VtLXB0cC10aW1lciBwdHAgY2xvY2sgcmVnaXN0ZXJlZC48YnI+DQomZ3Q7wqAgwqAg wqAgwqAmZ3Q7IFsgwqAgMTIuNzQ1NzI0XSBtYWNiIGZmMGMwMDAwLmV0aGVybmV0IGNvbnRyb2xf YmxhY2s6IFBIWSBbZmYwYzAwMDAuZXRoZXJuZXQtZmZmZmZmZmY6MDFdIGRyaXZlciBbWGlsaW54 IFBDUy9QTUEgUEhZXTxicj4NCiZndDvCoCDCoCDCoCDCoChpcnE9UE9MTCk8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7IFsgwqAgMTIuNzUzNDY5XSBtYWNiIGZmMGMwMDAwLmV0aGVybmV0IGNvbnRy b2xfYmxhY2s6IGNvbmZpZ3VyaW5nIGZvciBwaHkvZ21paSBsaW5rIG1vZGU8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7IFsgwqAgMTIuNzYxODA0XSBwcHMgcHBzMTogbmV3IFBQUyBzb3VyY2UgcHRw MTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxMi43NjUzOThdIG1hY2IgZmYwYzAwMDAu ZXRoZXJuZXQ6IGdlbS1wdHAtdGltZXIgcHRwIGNsb2NrIHJlZ2lzdGVyZWQuPGJyPg0KJmd0O8Kg IMKgIMKgIMKgJmd0OyBBdXRvLW5lZ290aWF0aW9uOiBvZmY8YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7IEF1dG8tbmVnb3RpYXRpb246IG9mZjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAx Ni44MjgxNTFdIG1hY2IgZmYwYjAwMDAuZXRoZXJuZXQgY29udHJvbF9yZWQ6IHVuYWJsZSB0byBn ZW5lcmF0ZSB0YXJnZXQgZnJlcXVlbmN5OiAxMjUwMDAwMDAgSHo8YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7IFsgwqAgMTYuODM0NTUzXSBtYWNiIGZmMGIwMDAwLmV0aGVybmV0IGNvbnRyb2xfcmVk OiBMaW5rIGlzIFVwIC0gMUdicHMvRnVsbCAtIGZsb3cgY29udHJvbCBvZmY8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7IFsgwqAgMTYuODYwNTUyXSBtYWNiIGZmMGMwMDAwLmV0aGVybmV0IGNvbnRy b2xfYmxhY2s6IHVuYWJsZSB0byBnZW5lcmF0ZSB0YXJnZXQgZnJlcXVlbmN5OiAxMjUwMDAwMDAg SHo8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTYuODY3MDUyXSBtYWNiIGZmMGMwMDAw LmV0aGVybmV0IGNvbnRyb2xfYmxhY2s6IExpbmsgaXMgVXAgLSAxR2Jwcy9GdWxsIC0gZmxvdyBj b250cm9sIG9mZjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgU3RhcnRpbmcgRmFpbHNhZmUgU2Vj dXJlIFNoZWxsIHNlcnZlciBpbiBwb3J0IDIyMjI6IHNzaGQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7IGRvbmUuPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBTdGFydGluZyBycGNiaW5kIGRhZW1v bi4uLmRvbmUuPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDsgWyDCoCAxNy4wOTMwMTldIHJ0Yy1scGM1NSBydGNfbHBjNTU6IGxwYzU1X3J0Y19nZXRfdGlt ZTogYmFkIHJlc3VsdDogMTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgaHdjbG9jazogUlRDX1JE X1RJTUU6IEludmFsaWQgZXhjaGFuZ2U8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFN0YXJ0aW5n IFN0YXRlIE1hbmFnZXIgU2VydmljZTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgU3RhcnQgc3Rh dGUtbWFuYWdlciByZXN0YXJ0ZXIuLi48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIGQw djEgRm9yd2FyZGluZyBBRVMgb3BlcmF0aW9uOiAzMjU0Nzc5OTUxPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0OyBTdGFydGluZyAvdXNyL3NiaW4veGVuc3RvcmVkLi4uLlsgwqAgMTcuMjY1MjU2XSBC VFJGUzogZGV2aWNlIGZzaWQgODBlZmMyMjQtYzIwMi00ZjhlLWE5NDktNGRhZTdmMDRhMGFhIGRl dmlkIDEgdHJhbnNpZCA3NDQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAvZGV2L2RtLTA8YnI+DQomZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IHNjYW5uZWQgYnkgdWRldmQgKDM4NSk8YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7IFsgwqAgMTcuMzQ5OTMzXSBCVFJGUyBpbmZvIChkZXZpY2UgZG0tMCk6IGRpc2sgc3Bh Y2UgY2FjaGluZyBpcyBlbmFibGVkPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDE3LjM1 MDY3MF0gQlRSRlMgaW5mbyAoZGV2aWNlIGRtLTApOiBoYXMgc2tpbm55IGV4dGVudHM8YnI+DQom Z3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTcuMzY0Mzg0XSBCVFJGUyBpbmZvIChkZXZpY2UgZG0t MCk6IGVuYWJsaW5nIHNzZCBvcHRpbWl6YXRpb25zPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBb IMKgIDE3LjgzMDQ2Ml0gQlRSRlM6IGRldmljZSBmc2lkIDI3ZmY2NjZiLWY0ZTUtNGY5MC05MDU0 LWMyMTBkYjViMmUyZSBkZXZpZCAxIHRyYW5zaWQgNiAvZGV2L21hcHBlci9jbGllbnRfcHJvdiBz Y2FubmVkIGJ5PGJyPg0KJmd0O8KgIMKgIMKgIMKgbWtmcy5idHJmczxicj4NCiZndDvCoCDCoCDC oCDCoCZndDsgKDUyNik8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTcuODcyNjk5XSBC VFJGUyBpbmZvIChkZXZpY2UgZG0tMSk6IHVzaW5nIGZyZWUgc3BhY2UgdHJlZTxicj4NCiZndDvC oCDCoCDCoCDCoCZndDsgWyDCoCAxNy44NzI3NzFdIEJUUkZTIGluZm8gKGRldmljZSBkbS0xKTog aGFzIHNraW5ueSBleHRlbnRzPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDE3Ljg3ODEx NF0gQlRSRlMgaW5mbyAoZGV2aWNlIGRtLTEpOiBmbGFnZ2luZyBmcyB3aXRoIGJpZyBtZXRhZGF0 YSBmZWF0dXJlPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDE3Ljg5NDI4OV0gQlRSRlMg aW5mbyAoZGV2aWNlIGRtLTEpOiBlbmFibGluZyBzc2Qgb3B0aW1pemF0aW9uczxicj4NCiZndDvC oCDCoCDCoCDCoCZndDsgWyDCoCAxNy44OTU2OTVdIEJUUkZTIGluZm8gKGRldmljZSBkbS0xKTog Y2hlY2tpbmcgVVVJRCB0cmVlPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDC oCDCoCDCoCZndDsgU2V0dGluZyBkb21haW4gMCBuYW1lLCBkb21pZCBhbmQgSlNPTiBjb25maWcu Li48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IERvbmUgc2V0dGluZyB1cCBEb20wPGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0OyBTdGFydGluZyB4ZW5jb25zb2xlZC4uLjxicj4NCiZndDvCoCDCoCDC oCDCoCZndDsgU3RhcnRpbmcgUUVNVSBhcyBkaXNrIGJhY2tlbmQgZm9yIGRvbTA8YnI+DQomZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IFN0YXJ0aW5nIGRvbWFpbiB3YXRjaGRvZyBkYWVtb246IHhlbndhdGNo ZG9nZCBzdGFydHVwPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDC oCZndDsgWyDCoCAxOC40MDg2NDddIEJUUkZTOiBkZXZpY2UgZnNpZCA1ZTA4ZDVlOS1iYzJhLTQ2 YjktYWY2YS00NGM3MDg3Yjg5MjEgZGV2aWQgMSB0cmFuc2lkIDYgL2Rldi9tYXBwZXIvY2xpZW50 X2NvbmZpZyBzY2FubmVkIGJ5PGJyPg0KJmd0O8KgIMKgIMKgIMKgbWtmcy5idHJmczxicj4NCiZn dDvCoCDCoCDCoCDCoCZndDsgKDU3NCk8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFtkb25lXTxi cj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxOC40NjU1NTJdIEJUUkZTIGluZm8gKGRldmlj ZSBkbS0yKTogdXNpbmcgZnJlZSBzcGFjZSB0cmVlPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBb IMKgIDE4LjQ2NTYyOV0gQlRSRlMgaW5mbyAoZGV2aWNlIGRtLTIpOiBoYXMgc2tpbm55IGV4dGVu dHM8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTguNDcxMDAyXSBCVFJGUyBpbmZvIChk ZXZpY2UgZG0tMik6IGZsYWdnaW5nIGZzIHdpdGggYmlnIG1ldGFkYXRhIGZlYXR1cmU8YnI+DQom Z3Q7wqAgwqAgwqAgwqAmZ3Q7IFN0YXJ0aW5nIGNyb25kOiBbIMKgIDE4LjQ4MjM3MV0gQlRSRlMg aW5mbyAoZGV2aWNlIGRtLTIpOiBlbmFibGluZyBzc2Qgb3B0aW1pemF0aW9uczxicj4NCiZndDvC oCDCoCDCoCDCoCZndDsgWyDCoCAxOC40ODY2NTldIEJUUkZTIGluZm8gKGRldmljZSBkbS0yKTog Y2hlY2tpbmcgVVVJRCB0cmVlPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBPSzxicj4NCiZndDvC oCDCoCDCoCDCoCZndDsgc3RhcnRpbmcgcnN5c2xvZ2QgLi4uIExvZyBwYXJ0aXRpb24gcmVhZHkg YWZ0ZXIgMCBwb2xsIGxvb3BzPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBkb25lPGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0OyByc3lzbG9nZDogY2Fubm90IGNvbm5lY3QgdG8gPGEgaHJlZj0iaHR0 cDovLzE3Mi4xOC4wLjE6NTE0IiByZWw9Im5vcmVmZXJyZXIiIHRhcmdldD0iX2JsYW5rIj4xNzIu MTguMC4xOjUxNDwvYT46IE5ldHdvcmsgaXMgdW5yZWFjaGFibGUgW3Y4LjIyMDguMCB0cnkgPGEg aHJlZj0iaHR0cHM6Ly93d3cucnN5c2xvZy5jb20vZS8yMDI3IiByZWw9Im5vcmVmZXJyZXIiIHRh cmdldD0iX2JsYW5rIj5odHRwczovL3d3dy5yc3lzbG9nLmNvbS9lLzIwMjc8L2E+IF08YnI+DQom Z3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTguNjcwNjM3XSBCVFJGUzogZGV2aWNlIGZzaWQgMzlk N2Q5ZTEtOTY3ZC00NzhlLTk0YWUtNjkwZGViNzIyMDk1IGRldmlkIDEgdHJhbnNpZCA2MDggL2Rl di9kbS0zIHNjYW5uZWQgYnkgdWRldmQgKDUxOCk8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBQbGVhc2UgaW5zZXJ0IFVTQiB0b2tlbiBhbmQgZW50ZXIg eW91ciByb2xlIGluIGxvZ2luIHByb21wdC48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0OyBsb2dpbjo8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0OyBSZWdhcmRzLDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgTy48 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZn dDvCoCDCoCDCoCDCoCZndDsg0L/QvSwgMjQg0LDQv9GALiAyMDIz4oCv0LMuINCyIDIzOjM5LCBT dGVmYW5vIFN0YWJlbGxpbmkgJmx0OzxhIGhyZWY9Im1haWx0bzpzc3RhYmVsbGluaUBrZXJuZWwu b3JnIiB0YXJnZXQ9Il9ibGFuayI+c3N0YWJlbGxpbmlAa2VybmVsLm9yZzwvYT4mZ3Q7Ojxicj4N CiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoEhpIE9sZWcsPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoEhlcmUgaXMgdGhlIGlz c3VlIGZyb20geW91ciBsb2dzOjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBTRXJyb3IgSW50ZXJydXB0IG9uIENQVTAsIGNvZGUgMHhi ZTAwMDAwMCAtLSBTRXJyb3I8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgU0Vycm9ycyBhcmUgc3BlY2lhbCBzaWduYWxzIHRvIG5vdGlm eSBzb2Z0d2FyZSBvZiBzZXJpb3VzIGhhcmR3YXJlPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgZXJyb3JzLsKgIFNvbWV0aGluZyBpcyBnb2luZyB2ZXJ5IHdyb25nLiBEZWZlY3Rp dmUgaGFyZHdhcmUgaXMgYTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoHBvc3Np YmlsaXR5LsKgIEFub3RoZXIgcG9zc2liaWxpdHkgaWYgc29mdHdhcmUgYWNjZXNzaW5nIGFkZHJl c3MgcmFuZ2VzPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgdGhhdCBpdCBpcyBu b3Qgc3VwcG9zZWQgdG8sIHNvbWV0aW1lcyBpdCBjYXVzZXMgU0Vycm9ycy48YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgQ2hlZXJzLDxi cj4NCiZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqBTdGVmYW5vPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgT24gTW9uLCAyNCBBcHIgMjAyMywgT2xlZyBOaWtpdGVua28gd3JvdGU6PGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg SGVsbG8sPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgVGhhbmtzIGd1eXMuPGJyPg0KJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBJIGZvdW5kIG91dCB3aGVyZSB0aGUgcHJvYmxlbSB3 YXMuPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBOb3cgZG9tMCBib290 ZWQgbW9yZS4gQnV0IEkgaGF2ZSBhIG5ldyBvbmUuPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0OyBUaGlzIGlzIGEga2VybmVsIHBhbmljIGR1cmluZyBEb20wIGxvYWRpbmcu PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBNYXliZSBzb21lb25lIGlz IGFibGUgdG8gc3VnZ2VzdCBzb21ldGhpbmcgPzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFJlZ2Fy ZHMsPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBPLjxicj4NCiZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjc3MTM2Ml0gc2ZwX3JlZ2lzdGVyX2J1czogdXBzdHJlYW0g b3BzIGF0dGFjaDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDC oDMuNzc2MTE5XSBzZnBfcmVnaXN0ZXJfYnVzOiBCdXMgcmVnaXN0ZXJlZDxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuNzgwNDU5XSBzZnBfcmVnaXN0ZXJf c29ja2V0OiByZWdpc3RlciBzZnBfYnVzIHN1Y2NlZWRlZDxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuNzg5Mzk5XSBvZl9jZnNfaW5pdDxicj4NCiZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuNzg5NDk5XSBvZl9jZnNfaW5p dDogT0s8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjc5 MTY4NV0gY2xrOiBOb3QgZGlzYWJsaW5nIHVudXNlZCBjbG9ja3M8YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwMzU1XSBTRXJyb3IgSW50ZXJydXB0IG9u IENQVTAsIGNvZGUgMHhiZTAwMDAwMCAtLSBTRXJyb3I8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwMzgwXSBDUFU6IDAgUElEOiA5IENvbW06IGt3b3Jr ZXIvdTQ6MCBOb3QgdGFpbnRlZCA1LjE1LjcyLXhpbGlueC12MjAyMi4xICMxPGJyPg0KJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDM5M10gV29ya3F1ZXVlOiBl dmVudHNfdW5ib3VuZCBhc3luY19ydW5fZW50cnlfZm48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNDE0XSBwc3RhdGU6IDYwMDAwMDA1IChuWkN2IGRh aWYgLVBBTiAtVUFPIC1UQ08gLURJVCAtU1NCUyBCVFlQRT0tLSk8YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNDIyXSBwYyA6IHNpbXBsZV93cml0ZV9l bmQrMHhkMC8weDEzMDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDC oCAxMS4wMTA0MzFdIGxyIDogZ2VuZXJpY19wZXJmb3JtX3dyaXRlKzB4MTE4LzB4MWUwPGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDQzOF0gc3AgOiBm ZmZmZmZjMDA4MDliOTEwPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBb IMKgIDExLjAxMDQ0MV0geDI5OiBmZmZmZmZjMDA4MDliOTEwIHgyODogMDAwMDAwMDAwMDAwMDAw MCB4Mjc6IGZmZmZmZmVmNjliYTg4YzA8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7IFsgwqAgMTEuMDEwNDUxXSB4MjY6IDAwMDAwMDAwMDAwMDNlZWMgeDI1OiBmZmZmZmY4 MDc1MTVkYjAwIHgyNDogMDAwMDAwMDAwMDAwMDAwMDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgWyDCoCAxMS4wMTA0NTldIHgyMzogZmZmZmZmYzAwODA5YmE5MCB4MjI6 IDAwMDAwMDAwMDJhYWMwMDAgeDIxOiBmZmZmZmY4MDczMTVhMjYwPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDQ3Ml0geDIwOiAwMDAwMDAwMDAwMDAx MDAwIHgxOTogZmZmZmZmZmUwMjAwMDAwMCB4MTg6IDAwMDAwMDAwMDAwMDAwMDA8YnI+DQomZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNDgxXSB4MTc6IDAwMDAw MDAwZmZmZmZmZmYgeDE2OiAwMDAwMDAwMDAwMDA4MDAwIHgxNTogMDAwMDAwMDAwMDAwMDAwMDxi cj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxMS4wMTA0OTBdIHgx NDogMDAwMDAwMDAwMDAwMDAwMCB4MTM6IDAwMDAwMDAwMDAwMDAwMDAgeDEyOiAwMDAwMDAwMDAw MDAwMDAwPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjAx MDQ5OF0geDExOiAwMDAwMDAwMDAwMDAwMDAwIHgxMDogMDAwMDAwMDAwMDAwMDAwMCB4OSA6IDAw MDAwMDAwMDAwMDAwMDA8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsg wqAgMTEuMDEwNTA3XSB4OCA6IDAwMDAwMDAwMDAwMDAwMDAgeDcgOiBmZmZmZmZlZjY5M2JhNjgw IHg2IDogMDAwMDAwMDAyZDg5YjcwMDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgWyDCoCAxMS4wMTA1MTVdIHg1IDogZmZmZmZmZmUwMjAwMDAwMCB4NCA6IGZmZmZmZjgw NzMxNWEzYzggeDMgOiAwMDAwMDAwMDAwMDAxMDAwPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDUyNF0geDIgOiAwMDAwMDAwMDAyYWFiMDAwIHgxIDog MDAwMDAwMDAwMDAwMDAwMSB4MCA6IDAwMDAwMDAwMDAwMDAwMDU8YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNTM0XSBLZXJuZWwgcGFuaWMgLSBub3Qg c3luY2luZzogQXN5bmNocm9ub3VzIFNFcnJvciBJbnRlcnJ1cHQ8YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNTM5XSBDUFU6IDAgUElEOiA5IENvbW06 IGt3b3JrZXIvdTQ6MCBOb3QgdGFpbnRlZCA1LjE1LjcyLXhpbGlueC12MjAyMi4xICMxPGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDU0NV0gSGFyZHdh cmUgbmFtZTogRDE0IFZpcGVyIEJvYXJkIC0gV2hpdGUgVW5pdCAoRFQpPGJyPg0KJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDU0OF0gV29ya3F1ZXVlOiBldmVu dHNfdW5ib3VuZCBhc3luY19ydW5fZW50cnlfZm48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNTU2XSBDYWxsIHRyYWNlOjxicj4NCiZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxMS4wMTA1NThdIMKgZHVtcF9iYWNrdHJhY2Ur MHgwLzB4MWM0PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDEx LjAxMDU2N10gwqBzaG93X3N0YWNrKzB4MTgvMHgyYzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgWyDCoCAxMS4wMTA1NzRdIMKgZHVtcF9zdGFja19sdmwrMHg3Yy8weGEw PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDU4M10g wqBkdW1wX3N0YWNrKzB4MTgvMHgzNDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgWyDCoCAxMS4wMTA1ODhdIMKgcGFuaWMrMHgxNGMvMHgyZjg8YnI+DQomZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNTk3XSDCoHByaW50X3RhaW50ZWQr MHgwLzB4YjA8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEu MDEwNjA2XSDCoGFybTY0X3NlcnJvcl9wYW5pYysweDZjLzB4N2M8YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNjE0XSDCoGRvX3NlcnJvcisweDI4LzB4 NjA8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNjIx XSDCoGVsMWhfNjRfZXJyb3JfaGFuZGxlcisweDMwLzB4NTA8YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNjI4XSDCoGVsMWhfNjRfZXJyb3IrMHg3OC8w eDdjPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDYz M10gwqBzaW1wbGVfd3JpdGVfZW5kKzB4ZDAvMHgxMzA8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNjM5XSDCoGdlbmVyaWNfcGVyZm9ybV93cml0ZSsw eDExOC8weDFlMDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAx MS4wMTA2NDRdIMKgX19nZW5lcmljX2ZpbGVfd3JpdGVfaXRlcisweDEzOC8weDFjNDxicj4NCiZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxMS4wMTA2NTBdIMKgZ2VuZXJp Y19maWxlX3dyaXRlX2l0ZXIrMHg3OC8weGQwPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyBbIMKgIDExLjAxMDY1Nl0gwqBfX2tlcm5lbF93cml0ZSsweGZjLzB4MmFjPGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDY2NV0gwqBr ZXJuZWxfd3JpdGUrMHg4OC8weDE2MDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgWyDCoCAxMS4wMTA2NzNdIMKgeHdyaXRlKzB4NDQvMHg5NDxicj4NCiZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxMS4wMTA2ODBdIMKgZG9fY29weSsweGE4LzB4 MTA0PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDY4 Nl0gwqB3cml0ZV9idWZmZXIrMHgzOC8weDU4PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyBbIMKgIDExLjAxMDY5Ml0gwqBmbHVzaF9idWZmZXIrMHg0Yy8weGJjPGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDY5OF0gwqBfX2d1 bnppcCsweDI4MC8weDMxMDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg WyDCoCAxMS4wMTA3MDRdIMKgZ3VuemlwKzB4MWMvMHgyODxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxMS4wMTA3MDldIMKgdW5wYWNrX3RvX3Jvb3RmcysweDE3 MC8weDJiMDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxMS4w MTA3MTVdIMKgZG9fcG9wdWxhdGVfcm9vdGZzKzB4ODAvMHgxNjQ8YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNzIyXSDCoGFzeW5jX3J1bl9lbnRyeV9m bisweDQ4LzB4MTY0PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKg IDExLjAxMDcyOF0gwqBwcm9jZXNzX29uZV93b3JrKzB4MWU0LzB4M2EwPGJyPg0KJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDczNl0gwqB3b3JrZXJfdGhyZWFk KzB4N2MvMHg0YzA8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAg MTEuMDEwNzQzXSDCoGt0aHJlYWQrMHgxMjAvMHgxMzA8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNzUwXSDCoHJldF9mcm9tX2ZvcmsrMHgxMC8weDIw PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDc1N10g U01QOiBzdG9wcGluZyBzZWNvbmRhcnkgQ1BVczxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgWyDCoCAxMS4wMTA3ODRdIEtlcm5lbCBPZmZzZXQ6IDB4MmY2MTIwMDAwMCBm cm9tIDB4ZmZmZmZmYzAwODAwMDAwMDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgWyDCoCAxMS4wMTA3ODhdIFBIWVNfT0ZGU0VUOiAweDA8YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNzkwXSBDUFUgZmVhdHVyZXM6IDB4MDAw MDA0MDEsMDAwMDA4NDI8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsg wqAgMTEuMDEwNzk1XSBNZW1vcnkgTGltaXQ6IG5vbmU8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMjc3NTA5XSAtLS1bIGVuZCBLZXJuZWwgcGFuaWMgLSBu b3Qgc3luY2luZzogQXN5bmNocm9ub3VzIFNFcnJvciBJbnRlcnJ1cHQgXS0tLTxicj4NCiZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7INC/0YIsIDIxINCw0L/RgC4gMjAyM+KAr9CzLiDQsiAxNTo1MiwgTWljaGFs IE9yemVsICZsdDs8YSBocmVmPSJtYWlsdG86bWljaGFsLm9yemVsQGFtZC5jb20iIHRhcmdldD0i X2JsYW5rIj5taWNoYWwub3J6ZWxAYW1kLmNvbTwvYT4mZ3Q7Ojxicj4NCiZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoEhpIE9sZWcsPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoE9uIDIxLzA0LzIwMjMgMTQ6NDksIE9sZWcgTmlraXRlbmtvIHdyb3Rl Ojxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0OyBIZWxsbyBNaWNoYWwsPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgSSB3YXMgbm90IGFibGUgdG8gZW5hYmxlIGVhcmx5cHJpbnRrIGluIHRo ZSB4ZW4gZm9yIG5vdy48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7IEkgZGVjaWRlZCB0byBjaG9vc2UgYW5vdGhlciB3YXkuPGJyPg0KJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBUaGlzIGlzIGEgeGVu JiMzOTtzIGNvbW1hbmQgbGluZSB0aGF0IEkgZm91bmQgb3V0IGNvbXBsZXRlbHkuPGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgJCQkJCBj b25zb2xlPWR0dWFydCBkdHVhcnQ9c2VyaWFsMCBkb20wX21lbT0xNjAwTSBkb20wX21heF92Y3B1 cz0yIGRvbTBfdmNwdXNfcGluIGJvb3RzY3J1Yj0wPGJyPg0KJmd0O8KgIMKgIMKgIMKgdndmaT1u YXRpdmU8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBzY2hlZD1udWxsPGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgdGltZXJfc2xvcD0w PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgWWVzLCBh ZGRpbmcgYSBwcmludGsoKSBpbiBYZW4gd2FzIGFsc28gYSBnb29kIGlkZWEuPGJyPg0KJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFNvIHlvdSBhcmUgYWJzb2x1dGVseSByaWdodCBhYm91 dCBhIGNvbW1hbmQgbGluZS48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IE5vdyBJIGFtIGdvaW5nIHRvIGZpbmQgb3V0IHdoeSB4ZW4gZGlkIG5v dCBoYXZlIHRoZSBjb3JyZWN0IHBhcmFtZXRlcnMgZnJvbSB0aGUgZGV2aWNlIHRyZWUuPGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgTWF5YmUgeW91IHdp bGwgZmluZCB0aGlzIGRvY3VtZW50IGhlbHBmdWw6PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgPGEgaHJlZj0iaHR0cHM6Ly9naXRodWIuY29tL1hpbGlu eC94ZW4vYmxvYi94bG54X3JlYmFzZV80LjE2L2RvY3MvbWlzYy9hcm0vZGV2aWNlLXRyZWUvYm9v dGluZy50eHQiIHJlbD0ibm9yZWZlcnJlciIgdGFyZ2V0PSJfYmxhbmsiPmh0dHBzOi8vZ2l0aHVi LmNvbS9YaWxpbngveGVuL2Jsb2IveGxueF9yZWJhc2VfNC4xNi9kb2NzL21pc2MvYXJtL2Rldmlj ZS10cmVlL2Jvb3RpbmcudHh0PC9hPjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqB+ TWljaGFsPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFJlZ2FyZHMsPGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBPbGVnPGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4N CiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg0L/Rgiwg MjEg0LDQv9GALiAyMDIz4oCv0LMuINCyIDExOjE2LCBNaWNoYWwgT3J6ZWwgJmx0OzxhIGhyZWY9 Im1haWx0bzptaWNoYWwub3J6ZWxAYW1kLmNvbSIgdGFyZ2V0PSJfYmxhbmsiPm1pY2hhbC5vcnpl bEBhbWQuY29tPC9hPiAmbHQ7bWFpbHRvOjxhIGhyZWY9Im1haWx0bzptaWNoYWwub3J6ZWxAYW1k LmNvbSIgdGFyZ2V0PSJfYmxhbmsiPm1pY2hhbC5vcnplbEBhbWQuY29tPC9hPiZndDsmZ3Q7Ojxi cj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+ DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg T24gMjEvMDQvMjAyMyAxMDowNCwgT2xlZyBOaWtpdGVua28gd3JvdGU6PGJyPg0KJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7IEhlbGxvIE1pY2hhbCw8YnI+DQom Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAm Z3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgJmd0OyBZZXMsIEkgdXNlIHlvY3RvLjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7IFllc3Rl cmRheSBhbGwgZGF5IGxvbmcgSSB0cmllZCB0byBmb2xsb3cgeW91ciBzdWdnZXN0aW9ucy48YnI+ DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAmZ3Q7IEkgZmFjZWQgYSBwcm9ibGVtLjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDsgTWFudWFsbHkgaW4gdGhlIHhlbiBj b25maWcgYnVpbGQgZmlsZSBJIHBhc3RlZCB0aGUgc3RyaW5nczo8YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqBJbiB0aGUgLmNvbmZp ZyBmaWxlIG9yIGluIHNvbWUgWW9jdG8gZmlsZSAobGlzdGluZyBhZGRpdGlvbmFsIEtjb25maWcg b3B0aW9ucykgYWRkZWQgdG8gU1JDX1VSST88YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqBZb3Ugc2hvdWxkbiYjMzk7dCByZWFsbHkg bW9kaWZ5IC5jb25maWcgZmlsZSBidXQgaWYgeW91IGRvLCB5b3Ugc2hvdWxkIGV4ZWN1dGUgJnF1 b3Q7bWFrZSBvbGRkZWZjb25maWcmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqBhZnRlcndhcmRz Ljxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgJmd0OyBDT05GSUdfRUFSTFlfUFJJTlRLPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0OyBDT05GSUdf RUFSTFlfUFJJTlRLX1pZTlFNUDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDsgQ09ORklHX0VBUkxZX1VBUlRfQ0hPSUNFX0NB REVOQ0U8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqBJIGhvcGUgeW91IGFkZGVkID15IHRvIHRoZW0uPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoEFueXdheSwgeW91IGhh dmUgYXQgbGVhc3QgdGhlIGZvbGxvd2luZyBzb2x1dGlvbnM6PGJyPg0KJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgMSkgUnVuIGJpdGJha2Ug eGVuIC1jIG1lbnVjb25maWcgdG8gcHJvcGVybHkgc2V0IGVhcmx5IHByaW50azxicj4NCiZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoDIpIEZp bmQgb3V0IGhvdyB5b3UgZW5hYmxlIG90aGVyIEtjb25maWcgb3B0aW9ucyBpbiB5b3VyIHByb2pl Y3QgKGUuZy4gQ09ORklHX0NPTE9SSU5HPXkgdGhhdCBpcyBub3Q8YnI+DQomZ3Q7wqAgwqAgwqAg wqBlbmFibGVkIGJ5PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgZGVmYXVsdCk8 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAzKSBBcHBlbmQgdGhlIGZvbGxvd2luZyB0byAmcXVvdDt4ZW4vYXJjaC9hcm0vY29uZmln cy9hcm02NF9kZWZjb25maWcmcXVvdDs6PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgQ09ORklHX0VBUkxZX1BSSU5US19aWU5RTVA9 eTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqB+TWljaGFsPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7IEhvc3QgaGFuZ3MgaW4gYnVpbGQgdGltZS7C oDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCZndDsgTWF5YmUgSSBkaWQgbm90IHNldCBzb21ldGhpbmcgaW4gdGhlIGNvbmZpZyBi dWlsZCBmaWxlID88YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0OyBSZWdhcmRzLDxicj4NCiZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDsgT2xlZzxi cj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAmZ3Q7INGH0YIsIDIwINCw0L/RgC4gMjAyM+KAr9CzLiDQsiAxMTo1Nywg T2xlZyBOaWtpdGVua28gJmx0OzxhIGhyZWY9Im1haWx0bzpvbGVzaGlpd29vZEBnbWFpbC5jb20i IHRhcmdldD0iX2JsYW5rIj5vbGVzaGlpd29vZEBnbWFpbC5jb208L2E+ICZsdDttYWlsdG86PGEg aHJlZj0ibWFpbHRvOm9sZXNoaWl3b29kQGdtYWlsLmNvbSIgdGFyZ2V0PSJfYmxhbmsiPm9sZXNo aWl3b29kQGdtYWlsLmNvbTwvYT4mZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86b2xlc2hpaXdvb2RA Z21haWwuY29tIiB0YXJnZXQ9Il9ibGFuayI+b2xlc2hpaXdvb2RAZ21haWwuY29tPC9hPiAmbHQ7 bWFpbHRvOjxhIGhyZWY9Im1haWx0bzpvbGVzaGlpd29vZEBnbWFpbC5jb20iIHRhcmdldD0iX2Js YW5rIj5vbGVzaGlpd29vZEBnbWFpbC5jb208L2E+Jmd0OyZndDsmZ3Q7Ojxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDs8YnI+ DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqBUaGFua3MgTWljaGFsLDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqBZ b3UgZ2F2ZSBtZSBhbiBpZGVhLjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoEkgYW0gZ29pbmcgdG8gdHJ5IGl0 IHRvZGF5Ljxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqBSZWdhcmRzLDxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDC oCDCoE8uPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoNGH0YIsIDIwINCw0L/RgC4gMjAyM+KA r9CzLiDQsiAxMTo1NiwgT2xlZyBOaWtpdGVua28gJmx0OzxhIGhyZWY9Im1haWx0bzpvbGVzaGlp d29vZEBnbWFpbC5jb20iIHRhcmdldD0iX2JsYW5rIj5vbGVzaGlpd29vZEBnbWFpbC5jb208L2E+ ICZsdDttYWlsdG86PGEgaHJlZj0ibWFpbHRvOm9sZXNoaWl3b29kQGdtYWlsLmNvbSIgdGFyZ2V0 PSJfYmxhbmsiPm9sZXNoaWl3b29kQGdtYWlsLmNvbTwvYT4mZ3Q7PGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmx0O21haWx0bzo8YSBocmVmPSJtYWls dG86b2xlc2hpaXdvb2RAZ21haWwuY29tIiB0YXJnZXQ9Il9ibGFuayI+b2xlc2hpaXdvb2RAZ21h aWwuY29tPC9hPiAmbHQ7bWFpbHRvOjxhIGhyZWY9Im1haWx0bzpvbGVzaGlpd29vZEBnbWFpbC5j b20iIHRhcmdldD0iX2JsYW5rIj5vbGVzaGlpd29vZEBnbWFpbC5jb208L2E+Jmd0OyZndDsmZ3Q7 Ojxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqBUaGFua3MgU3RlZmFuby48YnI+DQom Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAm Z3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgSSBhbSBnb2luZyB0byBkbyBpdCB0b2RheS48YnI+ DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgUmVnYXJkcyw8YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAgwqBPLjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqDRgdGALCAxOSDQsNC/0YAu IDIwMjPigK/Qsy4g0LIgMjM6MDUsIFN0ZWZhbm8gU3RhYmVsbGluaSAmbHQ7PGEgaHJlZj0ibWFp bHRvOnNzdGFiZWxsaW5pQGtlcm5lbC5vcmciIHRhcmdldD0iX2JsYW5rIj5zc3RhYmVsbGluaUBr ZXJuZWwub3JnPC9hPjxicj4NCiZndDvCoCDCoCDCoCDCoCZsdDttYWlsdG86PGEgaHJlZj0ibWFp bHRvOnNzdGFiZWxsaW5pQGtlcm5lbC5vcmciIHRhcmdldD0iX2JsYW5rIj5zc3RhYmVsbGluaUBr ZXJuZWwub3JnPC9hPiZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmbHQ7bWFpbHRvOjxhIGhyZWY9Im1haWx0bzpzc3RhYmVsbGluaUBrZXJuZWwu b3JnIiB0YXJnZXQ9Il9ibGFuayI+c3N0YWJlbGxpbmlAa2VybmVsLm9yZzwvYT4gJmx0O21haWx0 bzo8YSBocmVmPSJtYWlsdG86c3N0YWJlbGxpbmlAa2VybmVsLm9yZyIgdGFyZ2V0PSJfYmxhbmsi PnNzdGFiZWxsaW5pQGtlcm5lbC5vcmc8L2E+Jmd0OyZndDsmZ3Q7Ojxicj4NCiZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDs8YnI+DQom Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqBPbiBXZWQsIDE5IEFwciAyMDIzLCBPbGVnIE5pa2l0ZW5r byB3cm90ZTo8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7IEhpIE1pY2hhbCw8YnI+ DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKg IMKgJmd0OyBJIGNvcnJlY3RlZCB4ZW4mIzM5O3MgY29tbWFuZCBsaW5lLjxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCDCoCDCoCDCoCZndDsgTm93IGl0IGlzPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKg IMKgJmd0OyB4ZW4seGVuLWJvb3RhcmdzID0gJnF1b3Q7Y29uc29sZT1kdHVhcnQgZHR1YXJ0PXNl cmlhbDAgZG9tMF9tZW09MTYwME0gZG9tMF9tYXhfdmNwdXM9Mjxicj4NCiZndDvCoCDCoCDCoCDC oGRvbTBfdmNwdXNfcGluPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgYm9vdHNjcnViPTAgdndmaT1uYXRpdmUgc2NoZWQ9bnVsbDxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCDCoCDCoCDCoCZndDsgdGltZXJfc2xvcD0wIHdheV9zaXplPTY1NTM2IHhlbl9jb2xv cnM9MC0zIGRvbTBfY29sb3JzPTQtNyZxdW90Ozs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgIMKgIMKgIMKgNCBjb2xvcnMgaXMgd2F5IHRvbyBtYW55IGZvciB4ZW4sIGp1c3QgZG8geGVu X2NvbG9ycz0wLTAuIFRoZXJlIGlzIG5vPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgYWR2 YW50YWdlIGluIHVzaW5nIG1vcmUgdGhhbiAxIGNvbG9yIGZvciBYZW4uPGJyPg0KJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0Ozxicj4N CiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoDQgY29sb3JzIGlzIHRvbyBmZXcgZm9yIGRvbTAsIGlm IHlvdSBhcmUgZ2l2aW5nIDE2MDBNIG9mIG1lbW9yeSB0byBEb20wLjxicj4NCiZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCDCoCDCoCDCoEVhY2ggY29sb3IgaXMgMjU2TS4gRm9yIDE2MDBNIHlvdSBzaG91bGQgZ2l2 ZSBhdCBsZWFzdCA3IGNvbG9ycy4gVHJ5Ojxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAg wqAgwqAgwqB4ZW5fY29sb3JzPTAtMCBkb20wX2NvbG9ycz0xLTg8YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7PGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0 Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7IFVuZm9ydHVuYXRl bHkgdGhlIHJlc3VsdCB3YXMgdGhlIHNhbWUuPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKg Jmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDsgKFhFTikgwqAtIERvbTAgbW9k ZTogUmVsYXhlZDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDsgKFhFTikgUDJNOiA0 MC1iaXQgSVBBIHdpdGggNDAtYml0IFBBIGFuZCA4LWJpdCBWTUlEPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgIMKgIMKgIMKgJmd0OyAoWEVOKSBQMk06IDMgbGV2ZWxzIHdpdGggb3JkZXItMSByb290LCBW VENSIDB4MDAwMDAwMDA4MDAyMzU1ODxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDsg KFhFTikgU2NoZWR1bGluZyBncmFudWxhcml0eTogY3B1LCAxIENQVSBwZXIgc2NoZWQtcmVzb3Vy Y2U8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7IChYRU4pIENvbG9yaW5nIGdlbmVy YWwgaW5mb3JtYXRpb248YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7IChYRU4pIFdh eSBzaXplOiA2NGtCPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0OyAoWEVOKSBNYXgu IG51bWJlciBvZiBjb2xvcnMgYXZhaWxhYmxlOiAxNjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDC oCDCoCZndDsgKFhFTikgWGVuIGNvbG9yKHMpOiBbIDAgXTxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDC oCDCoCDCoCZndDsgKFhFTikgYWx0ZXJuYXRpdmVzOiBQYXRjaGluZyB3aXRoIGFsdCB0YWJsZSAw MDAwMDAwMDAwMmNjNjkwIC0mZ3Q7IDAwMDAwMDAwMDAyY2NjMGM8YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIENvbG9yIGFycmF5IGFsbG9jYXRpb24gZmFpbGVkIGZvciBk b20wPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0OyAoWEVOKTxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCDCoCDCoCDCoCZndDsgKFhFTikgKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDsgKFhFTikgUGFuaWMg b24gQ1BVIDA6PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0OyAoWEVOKSBFcnJvciBj cmVhdGluZyBkb21haW4gMDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDsgKFhFTikg KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKjxicj4NCiZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCDCoCDCoCDCoCZndDsgKFhFTik8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7 IChYRU4pIFJlYm9vdCBpbiBmaXZlIHNlY29uZHMuLi48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAg wqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0OyBJIGFtIGdvaW5nIHRv IGZpbmQgb3V0IGhvdyBjb21tYW5kIGxpbmUgYXJndW1lbnRzIHBhc3NlZCBhbmQgcGFyc2VkLjxi cj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAg wqAgwqAmZ3Q7IFJlZ2FyZHMsPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0OyBPbGVn PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDC oCDCoCDCoCZndDsg0YHRgCwgMTkg0LDQv9GALiAyMDIz4oCv0LMuINCyIDExOjI1LCBPbGVnIE5p a2l0ZW5rbyAmbHQ7PGEgaHJlZj0ibWFpbHRvOm9sZXNoaWl3b29kQGdtYWlsLmNvbSIgdGFyZ2V0 PSJfYmxhbmsiPm9sZXNoaWl3b29kQGdtYWlsLmNvbTwvYT48YnI+DQomZ3Q7wqAgwqAgwqAgwqAm bHQ7bWFpbHRvOjxhIGhyZWY9Im1haWx0bzpvbGVzaGlpd29vZEBnbWFpbC5jb20iIHRhcmdldD0i X2JsYW5rIj5vbGVzaGlpd29vZEBnbWFpbC5jb208L2E+Jmd0Ozxicj4NCiZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZsdDttYWlsdG86PGEgaHJlZj0ibWFpbHRv Om9sZXNoaWl3b29kQGdtYWlsLmNvbSIgdGFyZ2V0PSJfYmxhbmsiPm9sZXNoaWl3b29kQGdtYWls LmNvbTwvYT4gJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86b2xlc2hpaXdvb2RAZ21haWwuY29t IiB0YXJnZXQ9Il9ibGFuayI+b2xlc2hpaXdvb2RAZ21haWwuY29tPC9hPiZndDsmZ3Q7Jmd0Ozo8 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBIaSBNaWNoYWwsPGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDC oCDCoCZndDsgWW91IHB1dCBteSBub3NlIGludG8gdGhlIHByb2JsZW0uIFRoYW5rIHlvdS48YnI+ DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7IEkgYW0gZ29pbmcgdG8gdXNlIHlvdXIgcG9p bnQuPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0OyBMZXQmIzM5O3Mgc2VlIHdoYXQg aGFwcGVucy48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgIMKgIMKgIMKgJmd0OyBSZWdhcmRzLDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDC oCZndDsgT2xlZzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0OyDR gdGALCAxOSDQsNC/0YAuIDIwMjPigK/Qsy4g0LIgMTA6MzcsIE1pY2hhbCBPcnplbCAmbHQ7PGEg aHJlZj0ibWFpbHRvOm1pY2hhbC5vcnplbEBhbWQuY29tIiB0YXJnZXQ9Il9ibGFuayI+bWljaGFs Lm9yemVsQGFtZC5jb208L2E+PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmx0O21haWx0bzo8YSBocmVm PSJtYWlsdG86bWljaGFsLm9yemVsQGFtZC5jb20iIHRhcmdldD0iX2JsYW5rIj5taWNoYWwub3J6 ZWxAYW1kLmNvbTwvYT4mZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86bWljaGFsLm9yemVsQGFtZC5j b20iIHRhcmdldD0iX2JsYW5rIj5taWNoYWwub3J6ZWxAYW1kLmNvbTwvYT4gJmx0O21haWx0bzo8 YSBocmVmPSJtYWlsdG86bWljaGFsLm9yemVsQGFtZC5jb20iIHRhcmdldD0iX2JsYW5rIj5taWNo YWwub3J6ZWxAYW1kLmNvbTwvYT4mZ3Q7Jmd0OyZndDs6PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgSGkgT2xlZyw8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAg wqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgT24gMTkv MDQvMjAyMyAwOTowMywgT2xlZyBOaWtpdGVua28gd3JvdGU6PGJyPg0KJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IEhlbGxvIFN0ZWZhbm8sPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgVGhhbmtzIGZvciB0aGUgY2xhcmlmaWNhdGlvbi48YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IE15IGNvbXBhbnkgdXNlcyB5b2N0 byBmb3IgaW1hZ2UgZ2VuZXJhdGlvbi48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IFdoYXQga2luZCBvZiBpbmZvcm1hdGlvbiBkbyB5b3UgbmVlZCB0byBj b25zdWx0IG1lIGluIHRoaXMgY2FzZSA/PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDsgTWF5YmUgbW9kdWxlcyBzaXplcy9hZGRyZXNzZXMgd2hpY2ggd2VyZSBtZW50aW9u ZWQgYnkgQEp1bGllbiBHcmFsbDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZs dDttYWlsdG86PGEgaHJlZj0ibWFpbHRvOmp1bGllbkB4ZW4ub3JnIiB0YXJnZXQ9Il9ibGFuayI+ anVsaWVuQHhlbi5vcmc8L2E+PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86anVsaWVuQHhlbi5vcmciIHRh cmdldD0iX2JsYW5rIj5qdWxpZW5AeGVuLm9yZzwvYT4mZ3Q7ICZsdDttYWlsdG86PGEgaHJlZj0i bWFpbHRvOmp1bGllbkB4ZW4ub3JnIiB0YXJnZXQ9Il9ibGFuayI+anVsaWVuQHhlbi5vcmc8L2E+ ICZsdDttYWlsdG86PGEgaHJlZj0ibWFpbHRvOmp1bGllbkB4ZW4ub3JnIiB0YXJnZXQ9Il9ibGFu ayI+anVsaWVuQHhlbi5vcmc8L2E+Jmd0OyZndDsmZ3Q7ID88YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAg wqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg U29ycnkgZm9yIGp1bXBpbmcgaW50byBkaXNjdXNzaW9uLCBidXQgRldJQ1MgdGhlIFhlbiBjb21t YW5kIGxpbmUgeW91IHByb3ZpZGVkPGJyPg0KJmd0O8KgIMKgIMKgIMKgc2VlbXMgdG8gYmU8YnI+ DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBub3QgdGhlPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgb25lPGJyPg0KJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgWGVuIGJvb3RlZCB3aXRoLiBUaGUgZXJyb3IgeW91IGFy ZSBvYnNlcnZpbmcgbW9zdCBsaWtlbHkgaXMgZHVlIHRvIGRvbTAgY29sb3JzPGJyPg0KJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgY29uZmlndXJhdGlvbiBub3Q8YnI+DQomZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBiZWluZzxicj4NCiZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoHNwZWNpZmllZCAoaS5lLiBsYWNrIG9mIGRvbTBf Y29sb3JzPSZsdDsmZ3Q7IHBhcmFtZXRlcikuIEFsdGhvdWdoIGluIHRoZSBjb21tYW5kIGxpbmUg eW91PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgcHJvdmlkZWQsIHRoaXM8YnI+ DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBwYXJhbWV0ZXI8 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBpcyBzZXQsIEkgc3Ry b25nbHkgZG91YnQgdGhhdCB0aGlzIGlzIHRoZSBhY3R1YWwgY29tbWFuZCBsaW5lIGluIHVzZS48 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgWW91IHdyb3RlOjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoHhlbix4ZW4tYm9vdGFyZ3MgPSAmcXVvdDtjb25zb2xlPWR0dWFy dCBkdHVhcnQ9c2VyaWFsMCBkb20wX21lbT0xNjAwTSBkb20wX21heF92Y3B1cz0yPGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgZG9tMF92Y3B1c19waW48YnI+DQomZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBib290c2NydWI9MCB2d2ZpPW5hdGl2 ZTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoHNjaGVkPW51bGwg dGltZXJfc2xvcD0wIHdheV9zeml6ZT02NTUzNiB4ZW5fY29sb3JzPTAtMyBkb20wX2NvbG9ycz00 LTcmcXVvdDs7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoGJ1dDo8YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAxKSB3YXlfc3ppemUgaGFzIGEgdHlwbzxicj4NCiZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoDIpIHlvdSBzcGVjaWZpZWQgNCBjb2xv cnMgKDAtMykgZm9yIFhlbiwgYnV0IHRoZSBib290IGxvZyBzYXlzIHRoYXQgWGVuIGhhcyBvbmx5 PGJyPg0KJmd0O8KgIMKgIMKgIMKgb25lOjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoChYRU4pIFhlbiBjb2xvcihzKTogWyAwIF08YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgVGhpcyBtYWtlcyBtZSBiZWxpZXZlIHRoYXQgbm8gY29sb3JzIGNvbmZpZ3VyYXRpb24gYWN0 dWFsbHkgZW5kIHVwIGluIGNvbW1hbmQgbGluZTxicj4NCiZndDvCoCDCoCDCoCDCoHRoYXQgWGVu PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgYm9vdGVkPGJyPg0KJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgd2l0aC48YnI+DQomZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBTaW5nbGUgY29sb3IgZm9yIFhlbiBpcyBhICZx dW90O2RlZmF1bHQgaWYgbm90IHNwZWNpZmllZCZxdW90OyBhbmQgd2F5IHNpemUgd2FzIHByb2Jh Ymx5PGJyPg0KJmd0O8KgIMKgIMKgIMKgY2FsY3VsYXRlZDxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoGJ5IGFza2luZzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoEhXLjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDs8YnI+ DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBTbyBJIHdvdWxkIHN1Z2dl c3QgdG8gZmlyc3QgY3Jvc3MtY2hlY2sgdGhlIGNvbW1hbmQgbGluZSBpbiB1c2UuPGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoH5NaWNoYWw8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7PGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IFJlZ2FyZHMsPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0OyBPbGVnPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsg0LLRgiwgMTgg0LDQv9GALiAyMDIz4oCv0LMuINCyIDIwOjQ0LCBTdGVmYW5vIFN0YWJl bGxpbmkgJmx0OzxhIGhyZWY9Im1haWx0bzpzc3RhYmVsbGluaUBrZXJuZWwub3JnIiB0YXJnZXQ9 Il9ibGFuayI+c3N0YWJlbGxpbmlAa2VybmVsLm9yZzwvYT48YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmbHQ7bWFpbHRvOjxhIGhyZWY9Im1haWx0bzpz c3RhYmVsbGluaUBrZXJuZWwub3JnIiB0YXJnZXQ9Il9ibGFuayI+c3N0YWJlbGxpbmlAa2VybmVs Lm9yZzwvYT4mZ3Q7ICZsdDttYWlsdG86PGEgaHJlZj0ibWFpbHRvOnNzdGFiZWxsaW5pQGtlcm5l bC5vcmciIHRhcmdldD0iX2JsYW5rIj5zc3RhYmVsbGluaUBrZXJuZWwub3JnPC9hPiAmbHQ7bWFp bHRvOjxhIGhyZWY9Im1haWx0bzpzc3RhYmVsbGluaUBrZXJuZWwub3JnIiB0YXJnZXQ9Il9ibGFu ayI+c3N0YWJlbGxpbmlAa2VybmVsLm9yZzwvYT4mZ3Q7Jmd0Ozxicj4NCiZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZsdDttYWlsdG86PGEgaHJlZj0ibWFpbHRvOnNzdGFiZWxsaW5pQGtl cm5lbC5vcmciIHRhcmdldD0iX2JsYW5rIj5zc3RhYmVsbGluaUBrZXJuZWwub3JnPC9hPjxicj4N CiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZsdDttYWlsdG86 PGEgaHJlZj0ibWFpbHRvOnNzdGFiZWxsaW5pQGtlcm5lbC5vcmciIHRhcmdldD0iX2JsYW5rIj5z c3RhYmVsbGluaUBrZXJuZWwub3JnPC9hPiZndDsgJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86 c3N0YWJlbGxpbmlAa2VybmVsLm9yZyIgdGFyZ2V0PSJfYmxhbmsiPnNzdGFiZWxsaW5pQGtlcm5l bC5vcmc8L2E+ICZsdDttYWlsdG86PGEgaHJlZj0ibWFpbHRvOnNzdGFiZWxsaW5pQGtlcm5lbC5v cmciIHRhcmdldD0iX2JsYW5rIj5zc3RhYmVsbGluaUBrZXJuZWwub3JnPC9hPiZndDsmZ3Q7Jmd0 OyZndDs6PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxi cj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoE9u IFR1ZSwgMTggQXByIDIwMjMsIE9sZWcgTmlraXRlbmtvIHdyb3RlOjxicj4NCiZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDsgSGkgSnVsaWVuLDxi cj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZn dDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAmZ3Q7ICZndDsmZ3Q7IFRoaXMgZmVhdHVyZSBoYXMgbm90IGJlZW4gbWVyZ2VkIGluIFhlbiB1 cHN0cmVhbSB5ZXQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgJmd0OyAmZ3Q7IHdvdWxkIGFzc3VtZSB0aGF0IHVwc3RyZWFtICsgdGhl IHNlcmllcyBvbiB0aGUgTUwgWzFdIHdvcms8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0OyBQbGVhc2UgY2xhcmlmeSB0aGlzIHBv aW50Ljxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCZndDsgQmVjYXVzZSB0aGUgdHdvIHRob3VnaHRzIGFyZSBjb250cm92ZXJzaWFsLjxicj4N CiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqBIaSBPbGVnLDxicj4N CiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqBBcyBKdWxpZW4gd3Jv dGUsIHRoZXJlIGlzIG5vdGhpbmcgY29udHJvdmVyc2lhbC4gQXMgeW91IGFyZSBhd2FyZSw8YnI+ DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqBYaWxp bnggbWFpbnRhaW5zIGEgc2VwYXJhdGUgWGVuIHRyZWUgc3BlY2lmaWMgZm9yIFhpbGlueCBoZXJl Ojxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oDxhIGhyZWY9Imh0dHBzOi8vZ2l0aHViLmNvbS94aWxpbngveGVuIiByZWw9Im5vcmVmZXJyZXIi IHRhcmdldD0iX2JsYW5rIj5odHRwczovL2dpdGh1Yi5jb20veGlsaW54L3hlbjwvYT4gJmx0Ozxh IGhyZWY9Imh0dHBzOi8vZ2l0aHViLmNvbS94aWxpbngveGVuIiByZWw9Im5vcmVmZXJyZXIiIHRh cmdldD0iX2JsYW5rIj5odHRwczovL2dpdGh1Yi5jb20veGlsaW54L3hlbjwvYT4mZ3Q7PGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmx0OzxhIGhyZWY9Imh0dHBzOi8vZ2l0aHVi LmNvbS94aWxpbngveGVuIiByZWw9Im5vcmVmZXJyZXIiIHRhcmdldD0iX2JsYW5rIj5odHRwczov L2dpdGh1Yi5jb20veGlsaW54L3hlbjwvYT48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmbHQ7PGEgaHJlZj0iaHR0cHM6Ly9naXRodWIuY29tL3hpbGlu eC94ZW4iIHJlbD0ibm9yZWZlcnJlciIgdGFyZ2V0PSJfYmxhbmsiPmh0dHBzOi8vZ2l0aHViLmNv bS94aWxpbngveGVuPC9hPiZndDsmZ3Q7ICZsdDs8YSBocmVmPSJodHRwczovL2dpdGh1Yi5jb20v eGlsaW54L3hlbiIgcmVsPSJub3JlZmVycmVyIiB0YXJnZXQ9Il9ibGFuayI+aHR0cHM6Ly9naXRo dWIuY29tL3hpbGlueC94ZW48L2E+ICZsdDs8YSBocmVmPSJodHRwczovL2dpdGh1Yi5jb20veGls aW54L3hlbiIgcmVsPSJub3JlZmVycmVyIiB0YXJnZXQ9Il9ibGFuayI+aHR0cHM6Ly9naXRodWIu Y29tL3hpbGlueC94ZW48L2E+Jmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZsdDs8YSBocmVmPSJodHRwczovL2dpdGh1Yi5jb20veGlsaW54L3hlbiIgcmVsPSJub3JlZmVy cmVyIiB0YXJnZXQ9Il9ibGFuayI+aHR0cHM6Ly9naXRodWIuY29tL3hpbGlueC94ZW48L2E+PGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmx0OzxhIGhy ZWY9Imh0dHBzOi8vZ2l0aHViLmNvbS94aWxpbngveGVuIiByZWw9Im5vcmVmZXJyZXIiIHRhcmdl dD0iX2JsYW5rIj5odHRwczovL2dpdGh1Yi5jb20veGlsaW54L3hlbjwvYT4mZ3Q7Jmd0OyZndDs8 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgYW5kIHRoZSBi cmFuY2ggeW91IGFyZSB1c2luZyAoeGxueF9yZWJhc2VfNC4xNikgY29tZXMgZnJvbSB0aGVyZS48 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoEluc3RlYWQsIHRoZSB1cHN0 cmVhbSBYZW4gdHJlZSBsaXZlcyBoZXJlOjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoDxhIGhyZWY9Imh0dHBzOi8veGVuYml0cy54ZW4ub3Jn L2dpdHdlYi8/cD14ZW4uZ2l0O2E9c3VtbWFyeSIgcmVsPSJub3JlZmVycmVyIiB0YXJnZXQ9Il9i bGFuayI+aHR0cHM6Ly94ZW5iaXRzLnhlbi5vcmcvZ2l0d2ViLz9wPXhlbi5naXQ7YT1zdW1tYXJ5 PC9hPjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZs dDs8YSBocmVmPSJodHRwczovL3hlbmJpdHMueGVuLm9yZy9naXR3ZWIvP3A9eGVuLmdpdDthPXN1 bW1hcnkiIHJlbD0ibm9yZWZlcnJlciIgdGFyZ2V0PSJfYmxhbmsiPmh0dHBzOi8veGVuYml0cy54 ZW4ub3JnL2dpdHdlYi8/cD14ZW4uZ2l0O2E9c3VtbWFyeTwvYT4mZ3Q7ICZsdDs8YSBocmVmPSJo dHRwczovL3hlbmJpdHMueGVuLm9yZy9naXR3ZWIvP3A9eGVuLmdpdDthPXN1bW1hcnkiIHJlbD0i bm9yZWZlcnJlciIgdGFyZ2V0PSJfYmxhbmsiPmh0dHBzOi8veGVuYml0cy54ZW4ub3JnL2dpdHdl Yi8/cD14ZW4uZ2l0O2E9c3VtbWFyeTwvYT48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmbHQ7PGEgaHJlZj0iaHR0cHM6Ly94ZW5iaXRzLnhlbi5vcmcv Z2l0d2ViLz9wPXhlbi5naXQ7YT1zdW1tYXJ5IiByZWw9Im5vcmVmZXJyZXIiIHRhcmdldD0iX2Js YW5rIj5odHRwczovL3hlbmJpdHMueGVuLm9yZy9naXR3ZWIvP3A9eGVuLmdpdDthPXN1bW1hcnk8 L2E+Jmd0OyZndDsgJmx0OzxhIGhyZWY9Imh0dHBzOi8veGVuYml0cy54ZW4ub3JnL2dpdHdlYi8/ cD14ZW4uZ2l0O2E9c3VtbWFyeSIgcmVsPSJub3JlZmVycmVyIiB0YXJnZXQ9Il9ibGFuayI+aHR0 cHM6Ly94ZW5iaXRzLnhlbi5vcmcvZ2l0d2ViLz9wPXhlbi5naXQ7YT1zdW1tYXJ5PC9hPjxicj4N CiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZsdDs8YSBocmVm PSJodHRwczovL3hlbmJpdHMueGVuLm9yZy9naXR3ZWIvP3A9eGVuLmdpdDthPXN1bW1hcnkiIHJl bD0ibm9yZWZlcnJlciIgdGFyZ2V0PSJfYmxhbmsiPmh0dHBzOi8veGVuYml0cy54ZW4ub3JnL2dp dHdlYi8/cD14ZW4uZ2l0O2E9c3VtbWFyeTwvYT4mZ3Q7ICZsdDs8YSBocmVmPSJodHRwczovL3hl bmJpdHMueGVuLm9yZy9naXR3ZWIvP3A9eGVuLmdpdDthPXN1bW1hcnkiIHJlbD0ibm9yZWZlcnJl ciIgdGFyZ2V0PSJfYmxhbmsiPmh0dHBzOi8veGVuYml0cy54ZW4ub3JnL2dpdHdlYi8/cD14ZW4u Z2l0O2E9c3VtbWFyeTwvYT48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmbHQ7PGEgaHJlZj0iaHR0cHM6Ly94ZW5iaXRzLnhlbi5vcmcvZ2l0d2ViLz9w PXhlbi5naXQ7YT1zdW1tYXJ5IiByZWw9Im5vcmVmZXJyZXIiIHRhcmdldD0iX2JsYW5rIj5odHRw czovL3hlbmJpdHMueGVuLm9yZy9naXR3ZWIvP3A9eGVuLmdpdDthPXN1bW1hcnk8L2E+Jmd0OyZn dDsmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxi cj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqBUaGUgQ2FjaGUg Q29sb3JpbmcgZmVhdHVyZSB0aGF0IHlvdSBhcmUgdHJ5aW5nIHRvIGNvbmZpZ3VyZSBpcyBwcmVz ZW50PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgaW4geGxueF9yZWJhc2VfNC4xNiwgYnV0IG5vdCB5ZXQgcHJlc2VudCB1cHN0cmVhbSAodGhl cmUgaXMgYW48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqBvdXRzdGFuZGluZyBwYXRjaCBzZXJpZXMgdG8gYWRkIGNhY2hlIGNvbG9yaW5nIHRv IFhlbiB1cHN0cmVhbSBidXQgaXQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqBoYXNuJiMzOTt0IGJlZW4gbWVyZ2VkIHlldC4pPGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqBBbnl3YXksIGlmIHlvdSBhcmUgdXNpbmcg eGxueF9yZWJhc2VfNC4xNiBpdCBkb2VzbiYjMzk7dCBtYXR0ZXIgdG9vIG11Y2ggZm9yPGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgeW91IGFz IHlvdSBhbHJlYWR5IGhhdmUgQ2FjaGUgQ29sb3JpbmcgYXMgYSBmZWF0dXJlIHRoZXJlLjxicj4N CiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgSSB0YWtlIHlvdSBhcmUgdXNpbmcg SW1hZ2VCdWlsZGVyIHRvIGdlbmVyYXRlIHRoZSBib290IGNvbmZpZ3VyYXRpb24/IElmPGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgc28sIHBs ZWFzZSBwb3N0IHRoZSBJbWFnZUJ1aWxkZXIgY29uZmlnIGZpbGUgdGhhdCB5b3UgYXJlIHVzaW5n Ljxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQom Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqBCdXQgZnJv bSB0aGUgYm9vdCBtZXNzYWdlLCBpdCBsb29rcyBsaWtlIHRoZSBjb2xvcnMgY29uZmlndXJhdGlv biBmb3I8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqBEb20wIGlzIGluY29ycmVjdC48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0Ozxicj4NCiZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAm Z3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKg IMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7IDxicj4NCiZndDsg PGJyPg0KJmd0OyA8L2Jsb2NrcXVvdGU+PC9kaXY+DQo= --000000000000cd85bd05faee032e-- From xen-devel-bounces@lists.xenproject.org Fri May 05 08:34:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 08:34:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530262.825773 (Exim 4.92) (envelope-from ) id 1puqtq-0005j8-7g; Fri, 05 May 2023 08:34:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530262.825773; Fri, 05 May 2023 08:34:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puqtq-0005j1-4j; Fri, 05 May 2023 08:34:46 +0000 Received: by outflank-mailman (input) for mailman id 530262; Fri, 05 May 2023 08:34:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puqtp-0005it-0R for xen-devel@lists.xenproject.org; Fri, 05 May 2023 08:34:45 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on20605.outbound.protection.outlook.com [2a01:111:f400:fe5a::605]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id acff9be0-eb1f-11ed-b226-6b7b168915f2; Fri, 05 May 2023 10:34:41 +0200 (CEST) Received: from SJ0PR05CA0199.namprd05.prod.outlook.com (2603:10b6:a03:330::24) by BL0PR12MB4852.namprd12.prod.outlook.com (2603:10b6:208:1ce::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.27; Fri, 5 May 2023 08:34:36 +0000 Received: from DM6NAM11FT096.eop-nam11.prod.protection.outlook.com (2603:10b6:a03:330:cafe::d) by SJ0PR05CA0199.outlook.office365.com (2603:10b6:a03:330::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.12 via Frontend Transport; Fri, 5 May 2023 08:34:35 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT096.mail.protection.outlook.com (10.13.173.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.27 via Frontend Transport; Fri, 5 May 2023 08:34:35 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 5 May 2023 03:34:34 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 5 May 2023 03:34:33 -0500 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Fri, 5 May 2023 03:34:32 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: acff9be0-eb1f-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e3ajFTP8lcG8WNPAlIZCufT1G/Rs/3jegaB9W3dmBNfMvBiexDOasuTk8KmShg8SJhos5K+QKn5OgfeQU31SjU/QIA42fr8oux4ochuGm3q/9JxFWC7WcnKVP2ygZ3+6IkDGCXTPW9+pQOLIyCC6qXKaswN75dqOZiTj0jbOw6U0XNf0mfHik+aIjJUjeeYwbEtrXDV0FNQNpMqeNnDPdtsDJcVnTORXqzZdz33+978KoA3c8DF54z9rR7T2xyIiAejijfmm2QvN/oLJ0vojPILD/XC2m4s3gOo/h3Wh/fVcNDnDpmsdzgeNZvP8oADhmnvG8E3DbPaiq5UpxMccfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vY+LIJYnhkw13FpLb4lXUYI2NE+a9f0s+eO8yLAs6UM=; b=HGAHz6ZrMWrYf5A0LibBkqI6ETYCrZgUGLECjqNgC+Reo8jnRwEdti0u11Tl5hW/BZ7UcwkLmJ693ptLz+rokSGfTvbNiEmopv1m96BugcBb+hYLunZMGolC6M6y9hVJbJR1DRMF57a9wV20R5/utwl5Xmn4XRozz6/mRTaxQQX0jcQxONSL6RoRk/g01q6JfwqhBLywC9iQYs0wXlfCRAAhJkT4WIsvDB/rpYYs0zEhyyBU0OfbTI8vbiaPn/Qag93Uk29U0VS8pZkO+AutfE9xCJ7fiqYMgY1loh9/Frp5QxDibT5rtTh72/zKT/HPdJv3jWbvt4KqoHlth0cLMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vY+LIJYnhkw13FpLb4lXUYI2NE+a9f0s+eO8yLAs6UM=; b=b6AOiEazproNSU78ttKyZf8k56LSokVsZpTSCcylcgJAUd3mJJVm6OC1uWNEDRI+DW2dlC7zzOxkzC/f+j7Y7IzAi+VfRHdB87ntcCXcwlV0YiOD0AxLre7L5vjPYxmjNt2SBTjJXz/gmVfpHOgFeJJpS5ZWTZiZwFkuK47Ld2E= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <4e859659-8532-7ba2-63b9-a06d91cb0ffc@amd.com> Date: Fri, 5 May 2023 10:34:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: xen cache colors in ARM To: Oleg Nikitenko , Stefano Stabellini CC: Julien Grall , "xen-devel@lists.xenproject.org" , Bertrand Marquis , Carlo Nonato , References: <43f5fdaa-47c7-6ec9-c477-dac62a5bceae@amd.com> Content-Language: en-US From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT096:EE_|BL0PR12MB4852:EE_ X-MS-Office365-Filtering-Correlation-Id: 9feed9b6-56c9-4354-c1bd-08db4d438e86 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0yeCYLtgtSQig+JuW4sZCF7G6vEpK4p2Ob/gaQOMz8wQjaKXsrGhcG4BKYAcMzElkzihraehgCngmpObiOWAUNUEsjwdUBrrKqJQPafwU8RMxWvoQ1Y+jk3G8c5IVrCqIyVJrjsErlf1H3FqZqiUsD8gHIavXY2nS8FlKgW5DF60HOtUVGGSi3inLd18n8W8ey5cxG2PQ+xybZA4oMUmpcQhlJHMm98X56igUYZk6H38zurxCEpT4pwi+lWvUMHJ4G3TDUZZgMbPRGjrMeiBpm8/DgkLGsYG29fXrxYCkeuc6nRp3kKlEZQEJuisVufJnH6u2wKsH/jU2I6tkD6rCz0nlEJ9tktqbZtP/RXlKg89wOo/WowK4MCfkUWTv7H90J73Tot0A/HmcLiKCQn4T8h5FqttiHEsIJR2TJainBcBMhdI6SmbxO6LqnRGvYcy/PESzHQvnDRIbXzOm4DFfIwWXZTNY+OsI5BD46uUqHaYy2gcrz3MhvQHvf21ESDyz6kfw6WfS3GMubiy3/zsmpr6nhvycBYj8/reKi4lks9QM3cGA43rJuLPt4zq/G1v1e1gxo0l21k96u2mv/Zv/lWpb0OCid3CAUZ3wKRVQcCTQEajE34KFzjvDFl9sLt27ya2qSmKpRZgcNUFAonwzjjssEJJYUom5eHJdtwVOmEQ7rasxwyqCbUAzqEEPh247NdssAeT5KUjLF93drqKFSJ3iYUuM15noC+bZNqjjTOYBMCjZ1o5A6m2Fe0KbLOBpY+KcrEnOHbL9auKTW/qAyis3f+1mIsQt5FYSKGlGKKwwMyQpf4xM0EkkbqTFt6V X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(6019001)(4636009)(136003)(376002)(39860400002)(396003)(346002)(279900001)(451199021)(46966006)(36840700001)(40470700004)(31696002)(86362001)(36756003)(110136005)(16576012)(54906003)(316002)(4326008)(70206006)(70586007)(966005)(478600001)(41300700001)(40480700001)(82310400005)(8936002)(5660300002)(8676002)(44832011)(30864003)(2906002)(356005)(82740400003)(81166007)(186003)(2616005)(26005)(36860700001)(53546011)(47076005)(336012)(426003)(83380400001)(40460700003)(31686004)(36900700001)(43740500002)(579004)(559001)(139555002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 08:34:35.1619 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9feed9b6-56c9-4354-c1bd-08db4d438e86 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT096.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4852 Hi Oleg, Replying, so that you do not need to wait for Stefano. On 05/05/2023 10:28, Oleg Nikitenko wrote: > > > > Hello Stefano, > > I would like to try a xen cache color property from this repo  https://xenbits.xen.org/git-http/xen.git > Could you tell whot branch I should use ? Cache coloring feature is not part of the upstream tree and it is still under review. You can only find it integrated in the Xilinx Xen tree. ~Michal > > Regards, > Oleg > > пт, 28 апр. 2023 г. в 00:51, Stefano Stabellini >: > > I am familiar with the zcu102 but I don't know how you could possibly > generate a SError. > > I suggest to try to use ImageBuilder [1] to generate the boot > configuration as a test because that is known to work well for zcu102. > > [1] https://gitlab.com/xen-project/imagebuilder > > > On Thu, 27 Apr 2023, Oleg Nikitenko wrote: > > Hello Stefano, > > > > Thanks for clarification. > > We nighter use ImageBuilder nor uboot boot script. > > A model is zcu102 compatible. > > > > Regards, > > O. > > > > вт, 25 апр. 2023 г. в 21:21, Stefano Stabellini >: > >       This is interesting. Are you using Xilinx hardware by any chance? If so, > >       which board? > > > >       Are you using ImageBuilder to generate your boot.scr boot script? If so, > >       could you please post your ImageBuilder config file? If not, can you > >       post the source of your uboot boot script? > > > >       SErrors are supposed to be related to a hardware failure of some kind. > >       You are not supposed to be able to trigger an SError easily by > >       "mistake". I have not seen SErrors due to wrong cache coloring > >       configurations on any Xilinx board before. > > > >       The differences between Xen with and without cache coloring from a > >       hardware perspective are: > > > >       - With cache coloring, the SMMU is enabled and does address translations > >         even for dom0. Without cache coloring the SMMU could be disabled, and > >         if enabled, the SMMU doesn't do any address translations for Dom0. If > >         there is a hardware failure related to SMMU address translation it > >         could only trigger with cache coloring. This would be my normal > >         suggestion for you to explore, but the failure happens too early > >         before any DMA-capable device is programmed. So I don't think this can > >         be the issue. > > > >       - With cache coloring, the memory allocation is very different so you'll > >         end up using different DDR regions for Dom0. So if your DDR is > >         defective, you might only see a failure with cache coloring enabled > >         because you end up using different regions. > > > > > >       On Tue, 25 Apr 2023, Oleg Nikitenko wrote: > >       > Hi Stefano, > >       > > >       > Thank you. > >       > If I build xen without colors support there is not this error. > >       > All the domains are booted well. > >       > Hense it can not be a hardware issue. > >       > This panic arrived during unpacking the rootfs. > >       > Here I attached the boot log xen/Dom0 without color. > >       > A highlighted strings printed exactly after the place where 1-st time panic arrived. > >       > > >       >  Xen 4.16.1-pre > >       > (XEN) Xen version 4.16.1-pre (nole2390@(none)) (aarch64-portable-linux-gcc (GCC) 11.3.0) debug=y 2023-04-21 > >       > (XEN) Latest ChangeSet: Wed Apr 19 12:56:14 2023 +0300 git:321687b231-dirty > >       > (XEN) build-id: c1847258fdb1b79562fc710dda40008f96c0fde5 > >       > (XEN) Processor: 00000000410fd034: "ARM Limited", variant: 0x0, part 0xd03,rev 0x4 > >       > (XEN) 64-bit Execution: > >       > (XEN)   Processor Features: 0000000000002222 0000000000000000 > >       > (XEN)     Exception Levels: EL3:64+32 EL2:64+32 EL1:64+32 EL0:64+32 > >       > (XEN)     Extensions: FloatingPoint AdvancedSIMD > >       > (XEN)   Debug Features: 0000000010305106 0000000000000000 > >       > (XEN)   Auxiliary Features: 0000000000000000 0000000000000000 > >       > (XEN)   Memory Model Features: 0000000000001122 0000000000000000 > >       > (XEN)   ISA Features:  0000000000011120 0000000000000000 > >       > (XEN) 32-bit Execution: > >       > (XEN)   Processor Features: 0000000000000131:0000000000011011 > >       > (XEN)     Instruction Sets: AArch32 A32 Thumb Thumb-2 Jazelle > >       > (XEN)     Extensions: GenericTimer Security > >       > (XEN)   Debug Features: 0000000003010066 > >       > (XEN)   Auxiliary Features: 0000000000000000 > >       > (XEN)   Memory Model Features: 0000000010201105 0000000040000000 > >       > (XEN)                          0000000001260000 0000000002102211 > >       > (XEN)   ISA Features: 0000000002101110 0000000013112111 0000000021232042 > >       > (XEN)                 0000000001112131 0000000000011142 0000000000011121 > >       > (XEN) Using SMC Calling Convention v1.2 > >       > (XEN) Using PSCI v1.1 > >       > (XEN) SMP: Allowing 4 CPUs > >       > (XEN) Generic Timer IRQ: phys=30 hyp=26 virt=27 Freq: 100000 KHz > >       > (XEN) GICv2 initialization: > >       > (XEN)         gic_dist_addr=00000000f9010000 > >       > (XEN)         gic_cpu_addr=00000000f9020000 > >       > (XEN)         gic_hyp_addr=00000000f9040000 > >       > (XEN)         gic_vcpu_addr=00000000f9060000 > >       > (XEN)         gic_maintenance_irq=25 > >       > (XEN) GICv2: Adjusting CPU interface base to 0xf902f000 > >       > (XEN) GICv2: 192 lines, 4 cpus, secure (IID 0200143b). > >       > (XEN) Using scheduler: null Scheduler (null) > >       > (XEN) Initializing null scheduler > >       > (XEN) WARNING: This is experimental software in development. > >       > (XEN) Use at your own risk. > >       > (XEN) Allocated console ring of 32 KiB. > >       > (XEN) CPU0: Guest atomics will try 12 times before pausing the domain > >       > (XEN) Bringing up CPU1 > >       > (XEN) CPU1: Guest atomics will try 13 times before pausing the domain > >       > (XEN) CPU 1 booted. > >       > (XEN) Bringing up CPU2 > >       > (XEN) CPU2: Guest atomics will try 13 times before pausing the domain > >       > (XEN) CPU 2 booted. > >       > (XEN) Bringing up CPU3 > >       > (XEN) CPU3: Guest atomics will try 13 times before pausing the domain > >       > (XEN) Brought up 4 CPUs > >       > (XEN) CPU 3 booted. > >       > (XEN) smmu: /axi/smmu@fd800000: probing hardware configuration... > >       > (XEN) smmu: /axi/smmu@fd800000: SMMUv2 with: > >       > (XEN) smmu: /axi/smmu@fd800000: stage 2 translation > >       > (XEN) smmu: /axi/smmu@fd800000: stream matching with 48 register groups, mask 0x7fff<2>smmu: /axi/smmu@fd800000: 16 context > >       banks (0 > >       > stage-2 only) > >       > (XEN) smmu: /axi/smmu@fd800000: Stage-2: 48-bit IPA -> 48-bit PA > >       > (XEN) smmu: /axi/smmu@fd800000: registered 29 master devices > >       > (XEN) I/O virtualisation enabled > >       > (XEN)  - Dom0 mode: Relaxed > >       > (XEN) P2M: 40-bit IPA with 40-bit PA and 8-bit VMID > >       > (XEN) P2M: 3 levels with order-1 root, VTCR 0x0000000080023558 > >       > (XEN) Scheduling granularity: cpu, 1 CPU per sched-resource > >       > (XEN) alternatives: Patching with alt table 00000000002cc5c8 -> 00000000002ccb2c > >       > (XEN) *** LOADING DOMAIN 0 *** > >       > (XEN) Loading d0 kernel from boot module @ 0000000001000000 > >       > (XEN) Loading ramdisk from boot module @ 0000000002000000 > >       > (XEN) Allocating 1:1 mappings totalling 1600MB for dom0: > >       > (XEN) BANK[0] 0x00000010000000-0x00000020000000 (256MB) > >       > (XEN) BANK[1] 0x00000024000000-0x00000028000000 (64MB) > >       > (XEN) BANK[2] 0x00000030000000-0x00000080000000 (1280MB) > >       > (XEN) Grant table range: 0x00000000e00000-0x00000000e40000 > >       > (XEN) smmu: /axi/smmu@fd800000: d0: p2maddr 0x000000087bf94000 > >       > (XEN) Allocating PPI 16 for event channel interrupt > >       > (XEN) Extended region 0: 0x81200000->0xa0000000 > >       > (XEN) Extended region 1: 0xb1200000->0xc0000000 > >       > (XEN) Extended region 2: 0xc8000000->0xe0000000 > >       > (XEN) Extended region 3: 0xf0000000->0xf9000000 > >       > (XEN) Extended region 4: 0x100000000->0x600000000 > >       > (XEN) Extended region 5: 0x880000000->0x8000000000 > >       > (XEN) Extended region 6: 0x8001000000->0x10000000000 > >       > (XEN) Loading zImage from 0000000001000000 to 0000000010000000-0000000010e41008 > >       > (XEN) Loading d0 initrd from 0000000002000000 to 0x0000000013600000-0x000000001ff3a617 > >       > (XEN) Loading d0 DTB to 0x0000000013400000-0x000000001340cbdc > >       > (XEN) Initial low memory virq threshold set at 0x4000 pages. > >       > (XEN) Std. Loglevel: All > >       > (XEN) Guest Loglevel: All > >       > (XEN) *** Serial input to DOM0 (type 'CTRL-a' three times to switch input) > >       > (XEN) null.c:353: 0 <-- d0v0 > >       > (XEN) Freed 356kB init memory. > >       > (XEN) d0v0 Unhandled SMC/HVC: 0x84000050 > >       > (XEN) d0v0 Unhandled SMC/HVC: 0x8600ff01 > >       > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER4 > >       > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER8 > >       > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER12 > >       > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER16 > >       > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER20 > >       > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER0 > >       > [    0.000000] Booting Linux on physical CPU 0x0000000000 [0x410fd034] > >       > [    0.000000] Linux version 5.15.72-xilinx-v2022.1 (oe-user@oe-host) (aarch64-portable-linux-gcc (GCC) 11.3.0, GNU ld (GNU > >       Binutils) > >       > 2.38.20220708) #1 SMP Tue Feb 21 05:47:54 UTC 2023 > >       > [    0.000000] Machine model: D14 Viper Board - White Unit > >       > [    0.000000] Xen 4.16 support found > >       > [    0.000000] Zone ranges: > >       > [    0.000000]   DMA      [mem 0x0000000010000000-0x000000007fffffff] > >       > [    0.000000]   DMA32    empty > >       > [    0.000000]   Normal   empty > >       > [    0.000000] Movable zone start for each node > >       > [    0.000000] Early memory node ranges > >       > [    0.000000]   node   0: [mem 0x0000000010000000-0x000000001fffffff] > >       > [    0.000000]   node   0: [mem 0x0000000022000000-0x0000000022147fff] > >       > [    0.000000]   node   0: [mem 0x0000000022200000-0x0000000022347fff] > >       > [    0.000000]   node   0: [mem 0x0000000024000000-0x0000000027ffffff] > >       > [    0.000000]   node   0: [mem 0x0000000030000000-0x000000007fffffff] > >       > [    0.000000] Initmem setup node 0 [mem 0x0000000010000000-0x000000007fffffff] > >       > [    0.000000] On node 0, zone DMA: 8192 pages in unavailable ranges > >       > [    0.000000] On node 0, zone DMA: 184 pages in unavailable ranges > >       > [    0.000000] On node 0, zone DMA: 7352 pages in unavailable ranges > >       > [    0.000000] cma: Reserved 256 MiB at 0x000000006e000000 > >       > [    0.000000] psci: probing for conduit method from DT. > >       > [    0.000000] psci: PSCIv1.1 detected in firmware. > >       > [    0.000000] psci: Using standard PSCI v0.2 function IDs > >       > [    0.000000] psci: Trusted OS migration not required > >       > [    0.000000] psci: SMC Calling Convention v1.1 > >       > [    0.000000] percpu: Embedded 16 pages/cpu s32792 r0 d32744 u65536 > >       > [    0.000000] Detected VIPT I-cache on CPU0 > >       > [    0.000000] CPU features: kernel page table isolation forced ON by KASLR > >       > [    0.000000] CPU features: detected: Kernel page table isolation (KPTI) > >       > [    0.000000] Built 1 zonelists, mobility grouping on.  Total pages: 403845 > >       > [    0.000000] Kernel command line: console=hvc0 earlycon=xen earlyprintk=xen clk_ignore_unused fips=1 root=/dev/ram0 > >       maxcpus=2 > >       > [    0.000000] Unknown kernel command line parameters "earlyprintk=xen fips=1", will be passed to user space. > >       > [    0.000000] Dentry cache hash table entries: 262144 (order: 9, 2097152 bytes, linear) > >       > [    0.000000] Inode-cache hash table entries: 131072 (order: 8, 1048576 bytes, linear) > >       > [    0.000000] mem auto-init: stack:off, heap alloc:on, heap free:on > >       > [    0.000000] mem auto-init: clearing system memory may take some time... > >       > [    0.000000] Memory: 1121936K/1641024K available (9728K kernel code, 836K rwdata, 2396K rodata, 1536K init, 262K bss, > >       256944K reserved, > >       > 262144K cma-reserved) > >       > [    0.000000] SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=2, Nodes=1 > >       > [    0.000000] rcu: Hierarchical RCU implementation. > >       > [    0.000000] rcu: RCU event tracing is enabled. > >       > [    0.000000] rcu: RCU restricting CPUs from NR_CPUS=8 to nr_cpu_ids=2. > >       > [    0.000000] rcu: RCU calculated value of scheduler-enlistment delay is 25 jiffies. > >       > [    0.000000] rcu: Adjusting geometry for rcu_fanout_leaf=16, nr_cpu_ids=2 > >       > [    0.000000] NR_IRQS: 64, nr_irqs: 64, preallocated irqs: 0 > >       > [    0.000000] Root IRQ handler: gic_handle_irq > >       > [    0.000000] arch_timer: cp15 timer(s) running at 100.00MHz (virt). > >       > [    0.000000] clocksource: arch_sys_counter: mask: 0xffffffffffffff max_cycles: 0x171024e7e0, max_idle_ns: 440795205315 ns > >       > [    0.000000] sched_clock: 56 bits at 100MHz, resolution 10ns, wraps every 4398046511100ns > >       > [    0.000258] Console: colour dummy device 80x25 > >       > [    0.310231] printk: console [hvc0] enabled > >       > [    0.314403] Calibrating delay loop (skipped), value calculated using timer frequency.. 200.00 BogoMIPS (lpj=400000) > >       > [    0.324851] pid_max: default: 32768 minimum: 301 > >       > [    0.329706] LSM: Security Framework initializing > >       > [    0.334204] Yama: becoming mindful. > >       > [    0.337865] Mount-cache hash table entries: 4096 (order: 3, 32768 bytes, linear) > >       > [    0.345180] Mountpoint-cache hash table entries: 4096 (order: 3, 32768 bytes, linear) > >       > [    0.354743] xen:grant_table: Grant tables using version 1 layout > >       > [    0.359132] Grant table initialized > >       > [    0.362664] xen:events: Using FIFO-based ABI > >       > [    0.366993] Xen: initializing cpu0 > >       > [    0.370515] rcu: Hierarchical SRCU implementation. > >       > [    0.375930] smp: Bringing up secondary CPUs ... > >       > (XEN) null.c:353: 1 <-- d0v1 > >       > (XEN) d0v1: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER0 > >       > [    0.382549] Detected VIPT I-cache on CPU1 > >       > [    0.388712] Xen: initializing cpu1 > >       > [    0.388743] CPU1: Booted secondary processor 0x0000000001 [0x410fd034] > >       > [    0.388829] smp: Brought up 1 node, 2 CPUs > >       > [    0.406941] SMP: Total of 2 processors activated. > >       > [    0.411698] CPU features: detected: 32-bit EL0 Support > >       > [    0.416888] CPU features: detected: CRC32 instructions > >       > [    0.422121] CPU: All CPU(s) started at EL1 > >       > [    0.426248] alternatives: patching kernel code > >       > [    0.431424] devtmpfs: initialized > >       > [    0.441454] KASLR enabled > >       > [    0.441602] clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 7645041785100000 ns > >       > [    0.448321] futex hash table entries: 512 (order: 3, 32768 bytes, linear) > >       > [    0.496183] NET: Registered PF_NETLINK/PF_ROUTE protocol family > >       > [    0.498277] DMA: preallocated 256 KiB GFP_KERNEL pool for atomic allocations > >       > [    0.503772] DMA: preallocated 256 KiB GFP_KERNEL|GFP_DMA pool for atomic allocations > >       > [    0.511610] DMA: preallocated 256 KiB GFP_KERNEL|GFP_DMA32 pool for atomic allocations > >       > [    0.519478] audit: initializing netlink subsys (disabled) > >       > [    0.524985] audit: type=2000 audit(0.336:1): state=initialized audit_enabled=0 res=1 > >       > [    0.529169] thermal_sys: Registered thermal governor 'step_wise' > >       > [    0.533023] hw-breakpoint: found 6 breakpoint and 4 watchpoint registers. > >       > [    0.545608] ASID allocator initialised with 32768 entries > >       > [    0.551030] xen:swiotlb_xen: Warning: only able to allocate 4 MB for software IO TLB > >       > [    0.559332] software IO TLB: mapped [mem 0x0000000011800000-0x0000000011c00000] (4MB) > >       > [    0.583565] HugeTLB registered 1.00 GiB page size, pre-allocated 0 pages > >       > [    0.584721] HugeTLB registered 32.0 MiB page size, pre-allocated 0 pages > >       > [    0.591478] HugeTLB registered 2.00 MiB page size, pre-allocated 0 pages > >       > [    0.598225] HugeTLB registered 64.0 KiB page size, pre-allocated 0 pages > >       > [    0.636520] DRBG: Continuing without Jitter RNG > >       > [    0.737187] raid6: neonx8   gen()  2143 MB/s > >       > [    0.805294] raid6: neonx8   xor()  1589 MB/s > >       > [    0.873406] raid6: neonx4   gen()  2177 MB/s > >       > [    0.941499] raid6: neonx4   xor()  1556 MB/s > >       > [    1.009612] raid6: neonx2   gen()  2072 MB/s > >       > [    1.077715] raid6: neonx2   xor()  1430 MB/s > >       > [    1.145834] raid6: neonx1   gen()  1769 MB/s > >       > [    1.213935] raid6: neonx1   xor()  1214 MB/s > >       > [    1.282046] raid6: int64x8  gen()  1366 MB/s > >       > [    1.350132] raid6: int64x8  xor()   773 MB/s > >       > [    1.418259] raid6: int64x4  gen()  1602 MB/s > >       > [    1.486349] raid6: int64x4  xor()   851 MB/s > >       > [    1.554464] raid6: int64x2  gen()  1396 MB/s > >       > [    1.622561] raid6: int64x2  xor()   744 MB/s > >       > [    1.690687] raid6: int64x1  gen()  1033 MB/s > >       > [    1.758770] raid6: int64x1  xor()   517 MB/s > >       > [    1.758809] raid6: using algorithm neonx4 gen() 2177 MB/s > >       > [    1.762941] raid6: .... xor() 1556 MB/s, rmw enabled > >       > [    1.767957] raid6: using neon recovery algorithm > >       > [    1.772824] xen:balloon: Initialising balloon driver > >       > [    1.778021] iommu: Default domain type: Translated > >       > [    1.782584] iommu: DMA domain TLB invalidation policy: strict mode > >       > [    1.789149] SCSI subsystem initialized > >       > [    1.792820] usbcore: registered new interface driver usbfs > >       > [    1.798254] usbcore: registered new interface driver hub > >       > [    1.803626] usbcore: registered new device driver usb > >       > [    1.808761] pps_core: LinuxPPS API ver. 1 registered > >       > [    1.813716] pps_core: Software ver. 5.3.6 - Copyright 2005-2007 Rodolfo Giometti > > >       > [    1.822903] PTP clock support registered > >       > [    1.826893] EDAC MC: Ver: 3.0.0 > >       > [    1.830375] zynqmp-ipi-mbox mailbox@ff990400: Registered ZynqMP IPI mbox with TX/RX channels. > >       > [    1.838863] zynqmp-ipi-mbox mailbox@ff990600: Registered ZynqMP IPI mbox with TX/RX channels. > >       > [    1.847356] zynqmp-ipi-mbox mailbox@ff990800: Registered ZynqMP IPI mbox with TX/RX channels. > >       > [    1.855907] FPGA manager framework > >       > [    1.859952] clocksource: Switched to clocksource arch_sys_counter > >       > [    1.871712] NET: Registered PF_INET protocol family > >       > [    1.871838] IP idents hash table entries: 32768 (order: 6, 262144 bytes, linear) > >       > [    1.879392] tcp_listen_portaddr_hash hash table entries: 1024 (order: 2, 16384 bytes, linear) > >       > [    1.887078] Table-perturb hash table entries: 65536 (order: 6, 262144 bytes, linear) > >       > [    1.894846] TCP established hash table entries: 16384 (order: 5, 131072 bytes, linear) > >       > [    1.902900] TCP bind hash table entries: 16384 (order: 6, 262144 bytes, linear) > >       > [    1.910350] TCP: Hash tables configured (established 16384 bind 16384) > >       > [    1.916778] UDP hash table entries: 1024 (order: 3, 32768 bytes, linear) > >       > [    1.923509] UDP-Lite hash table entries: 1024 (order: 3, 32768 bytes, linear) > >       > [    1.930759] NET: Registered PF_UNIX/PF_LOCAL protocol family > >       > [    1.936834] RPC: Registered named UNIX socket transport module. > >       > [    1.942342] RPC: Registered udp transport module. > >       > [    1.947088] RPC: Registered tcp transport module. > >       > [    1.951843] RPC: Registered tcp NFSv4.1 backchannel transport module. > >       > [    1.958334] PCI: CLS 0 bytes, default 64 > >       > [    1.962709] Trying to unpack rootfs image as initramfs... > >       > [    1.977090] workingset: timestamp_bits=62 max_order=19 bucket_order=0 > >       > [    1.982863] Installing knfsd (copyright (C) 1996 okir@monad.swb.de ). > >       > [    2.021045] NET: Registered PF_ALG protocol family > >       > [    2.021122] xor: measuring software checksum speed > >       > [    2.029347]    8regs           :  2366 MB/sec > >       > [    2.033081]    32regs          :  2802 MB/sec > >       > [    2.038223]    arm64_neon      :  2320 MB/sec > >       > [    2.038385] xor: using function: 32regs (2802 MB/sec) > >       > [    2.043614] Block layer SCSI generic (bsg) driver version 0.4 loaded (major 247) > >       > [    2.050959] io scheduler mq-deadline registered > >       > [    2.055521] io scheduler kyber registered > >       > [    2.068227] xen:xen_evtchn: Event-channel device installed > >       > [    2.069281] Serial: 8250/16550 driver, 4 ports, IRQ sharing disabled > >       > [    2.076190] cacheinfo: Unable to detect cache hierarchy for CPU 0 > >       > [    2.085548] brd: module loaded > >       > [    2.089290] loop: module loaded > >       > [    2.089341] Invalid max_queues (4), will use default max: 2. > >       > [    2.094565] tun: Universal TUN/TAP device driver, 1.6 > >       > [    2.098655] xen_netfront: Initialising Xen virtual ethernet driver > >       > [    2.104156] usbcore: registered new interface driver rtl8150 > >       > [    2.109813] usbcore: registered new interface driver r8152 > >       > [    2.115367] usbcore: registered new interface driver asix > >       > [    2.120794] usbcore: registered new interface driver ax88179_178a > >       > [    2.126934] usbcore: registered new interface driver cdc_ether > >       > [    2.132816] usbcore: registered new interface driver cdc_eem > >       > [    2.138527] usbcore: registered new interface driver net1080 > >       > [    2.144256] usbcore: registered new interface driver cdc_subset > >       > [    2.150205] usbcore: registered new interface driver zaurus > >       > [    2.155837] usbcore: registered new interface driver cdc_ncm > >       > [    2.161550] usbcore: registered new interface driver r8153_ecm > >       > [    2.168240] usbcore: registered new interface driver cdc_acm > >       > [    2.173109] cdc_acm: USB Abstract Control Model driver for USB modems and ISDN adapters > >       > [    2.181358] usbcore: registered new interface driver uas > >       > [    2.186547] usbcore: registered new interface driver usb-storage > >       > [    2.192643] usbcore: registered new interface driver ftdi_sio > >       > [    2.198384] usbserial: USB Serial support registered for FTDI USB Serial Device > >       > [    2.206118] udc-core: couldn't find an available UDC - added [g_mass_storage] to list of pending drivers > >       > [    2.215332] i2c_dev: i2c /dev entries driver > >       > [    2.220467] xen_wdt xen_wdt: initialized (timeout=60s, nowayout=0) > >       > [    2.225923] device-mapper: uevent: version 1.0.3 > >       > [    2.230668] device-mapper: ioctl: 4.45.0-ioctl (2021-03-22) initialised: dm-devel@redhat.com > >       > [    2.239315] EDAC MC0: Giving out device to module 1 controller synps_ddr_controller: DEV synps_edac (INTERRUPT) > >       > [    2.249405] EDAC DEVICE0: Giving out device to module zynqmp-ocm-edac controller zynqmp_ocm: DEV > >       ff960000.memory-controller (INTERRUPT) > >       > [    2.261719] sdhci: Secure Digital Host Controller Interface driver > >       > [    2.267487] sdhci: Copyright(c) Pierre Ossman > >       > [    2.271890] sdhci-pltfm: SDHCI platform and OF driver helper > >       > [    2.278157] ledtrig-cpu: registered to indicate activity on CPUs > >       > [    2.283816] zynqmp_firmware_probe Platform Management API v1.1 > >       > [    2.289554] zynqmp_firmware_probe Trustzone version v1.0 > >       > [    2.327875] securefw securefw: securefw probed > >       > [    2.328324] alg: No test for xilinx-zynqmp-aes (zynqmp-aes) > >       > [    2.332563] zynqmp_aes firmware:zynqmp-firmware:zynqmp-aes: AES Successfully Registered > >       > [    2.341183] alg: No test for xilinx-zynqmp-rsa (zynqmp-rsa) > >       > [    2.347667] remoteproc remoteproc0: ff9a0000.rf5ss:r5f_0 is available > >       > [    2.353003] remoteproc remoteproc1: ff9a0000.rf5ss:r5f_1 is available > >       > [    2.362605] fpga_manager fpga0: Xilinx ZynqMP FPGA Manager registered > >       > [    2.366540] viper-xen-proxy viper-xen-proxy: Viper Xen Proxy registered > >       > [    2.372525] viper-vdpp a4000000.vdpp: Device Tree Probing > >       > [    2.377778] viper-vdpp a4000000.vdpp: VDPP Version: 1.3.9.0 Info: 1.512.15.0 KeyLen: 32 > >       > [    2.386432] viper-vdpp a4000000.vdpp: Unable to register tamper handler. Retrying... > >       > [    2.394094] viper-vdpp-net a5000000.vdpp_net: Device Tree Probing > >       > [    2.399854] viper-vdpp-net a5000000.vdpp_net: Device registered > >       > [    2.405931] viper-vdpp-stat a8000000.vdpp_stat: Device Tree Probing > >       > [    2.412037] viper-vdpp-stat a8000000.vdpp_stat: Build parameters: VTI Count: 512 Event Count: 32 > >       > [    2.420856] default preset > >       > [    2.423797] viper-vdpp-stat a8000000.vdpp_stat: Device registered > >       > [    2.430054] viper-vdpp-rng ac000000.vdpp_rng: Device Tree Probing > >       > [    2.435948] viper-vdpp-rng ac000000.vdpp_rng: Device registered > >       > [    2.441976] vmcu driver init > >       > [    2.444922] VMCU: : (240:0) registered > >       > [    2.444956] In K81 Updater init > >       > [    2.449003] pktgen: Packet Generator for packet performance testing. Version: 2.75 > >       > [    2.468833] Initializing XFRM netlink socket > >       > [    2.468902] NET: Registered PF_PACKET protocol family > >       > [    2.472729] Bridge firewalling registered > >       > [    2.476785] 8021q: 802.1Q VLAN Support v1.8 > >       > [    2.481341] registered taskstats version 1 > >       > [    2.486394] Btrfs loaded, crc32c=crc32c-generic, zoned=no, fsverity=no > >       > [    2.503145] ff010000.serial: ttyPS1 at MMIO 0xff010000 (irq = 36, base_baud = 6250000) is a xuartps > >       > [    2.507103] of-fpga-region fpga-full: FPGA Region probed > >       > [    2.512986] xilinx-zynqmp-dma fd500000.dma-controller: ZynqMP DMA driver Probe success > >       > [    2.520267] xilinx-zynqmp-dma fd510000.dma-controller: ZynqMP DMA driver Probe success > >       > [    2.528239] xilinx-zynqmp-dma fd520000.dma-controller: ZynqMP DMA driver Probe success > >       > [    2.536152] xilinx-zynqmp-dma fd530000.dma-controller: ZynqMP DMA driver Probe success > >       > [    2.544153] xilinx-zynqmp-dma fd540000.dma-controller: ZynqMP DMA driver Probe success > >       > [    2.552127] xilinx-zynqmp-dma fd550000.dma-controller: ZynqMP DMA driver Probe success > >       > [    2.560178] xilinx-zynqmp-dma ffa80000.dma-controller: ZynqMP DMA driver Probe success > >       > [    2.567987] xilinx-zynqmp-dma ffa90000.dma-controller: ZynqMP DMA driver Probe success > >       > [    2.576018] xilinx-zynqmp-dma ffaa0000.dma-controller: ZynqMP DMA driver Probe success > >       > [    2.583889] xilinx-zynqmp-dma ffab0000.dma-controller: ZynqMP DMA driver Probe success > >       > [    2.946379] spi-nor spi0.0: mt25qu512a (131072 Kbytes) > >       > [    2.946467] 2 fixed-partitions partitions found on MTD device spi0.0 > >       > [    2.952393] Creating 2 MTD partitions on "spi0.0": > >       > [    2.957231] 0x000004000000-0x000008000000 : "bank A" > >       > [    2.963332] 0x000000000000-0x000004000000 : "bank B" > >       > [    2.968694] macb ff0b0000.ethernet: Not enabling partial store and forward > >       > [    2.975333] macb ff0b0000.ethernet eth0: Cadence GEM rev 0x50070106 at 0xff0b0000 irq 25 (18:41:fe:0f:ff:02) > >       > [    2.984472] macb ff0c0000.ethernet: Not enabling partial store and forward > >       > [    2.992144] macb ff0c0000.ethernet eth1: Cadence GEM rev 0x50070106 at 0xff0c0000 irq 26 (18:41:fe:0f:ff:03) > >       > [    3.001043] viper_enet viper_enet: Viper power GPIOs initialised > >       > [    3.007313] viper_enet viper_enet vnet0 (uninitialized): Validate interface QSGMII > >       > [    3.014914] viper_enet viper_enet vnet1 (uninitialized): Validate interface QSGMII > >       > [    3.022138] viper_enet viper_enet vnet1 (uninitialized): Validate interface type 18 > >       > [    3.030274] viper_enet viper_enet vnet2 (uninitialized): Validate interface QSGMII > >       > [    3.037785] viper_enet viper_enet vnet3 (uninitialized): Validate interface QSGMII > >       > [    3.045301] viper_enet viper_enet: Viper enet registered > >       > [    3.050958] xilinx-axipmon ffa00000.perf-monitor: Probed Xilinx APM > >       > [    3.057135] xilinx-axipmon fd0b0000.perf-monitor: Probed Xilinx APM > >       > [    3.063538] xilinx-axipmon fd490000.perf-monitor: Probed Xilinx APM > >       > [    3.069920] xilinx-axipmon ffa10000.perf-monitor: Probed Xilinx APM > >       > [    3.097729] si70xx: probe of 2-0040 failed with error -5 > >       > [    3.098042] cdns-wdt fd4d0000.watchdog: Xilinx Watchdog Timer with timeout 60s > >       > [    3.105111] cdns-wdt ff150000.watchdog: Xilinx Watchdog Timer with timeout 10s > >       > [    3.112457] viper-tamper viper-tamper: Device registered > >       > [    3.117593] active_bank active_bank: boot bank: 1 > >       > [    3.122184] active_bank active_bank: boot mode: (0x02) qspi32 > >       > [    3.128247] viper-vdpp a4000000.vdpp: Device Tree Probing > >       > [    3.133439] viper-vdpp a4000000.vdpp: VDPP Version: 1.3.9.0 Info: 1.512.15.0 KeyLen: 32 > >       > [    3.142151] viper-vdpp a4000000.vdpp: Tamper handler registered > >       > [    3.147438] viper-vdpp a4000000.vdpp: Device registered > >       > [    3.153007] lpc55_l2 spi1.0: registered handler for protocol 0 > >       > [    3.158582] lpc55_user lpc55_user: The major number for your device is 236 > >       > [    3.165976] lpc55_l2 spi1.0: registered handler for protocol 1 > >       > [    3.181999] rtc-lpc55 rtc_lpc55: lpc55_rtc_get_time: bad result: 1 > >       > [    3.182856] rtc-lpc55 rtc_lpc55: registered as rtc0 > >       > [    3.188656] lpc55_l2 spi1.0: (2) mcu still not ready? > >       > [    3.193744] lpc55_l2 spi1.0: (3) mcu still not ready? > >       > [    3.198848] lpc55_l2 spi1.0: (4) mcu still not ready? > >       > [    3.202932] mmc0: SDHCI controller on ff160000.mmc [ff160000.mmc] using ADMA 64-bit > >       > [    3.210689] lpc55_l2 spi1.0: (5) mcu still not ready? > >       > [    3.215694] lpc55_l2 spi1.0: rx error: -110 > >       > [    3.284438] mmc0: new HS200 MMC card at address 0001 > >       > [    3.285179] mmcblk0: mmc0:0001 SEM16G 14.6 GiB > >       > [    3.291784]  mmcblk0: p1 p2 p3 p4 p5 p6 p7 p8 > >       > [    3.293915] mmcblk0boot0: mmc0:0001 SEM16G 4.00 MiB > >       > [    3.299054] mmcblk0boot1: mmc0:0001 SEM16G 4.00 MiB > >       > [    3.303905] mmcblk0rpmb: mmc0:0001 SEM16G 4.00 MiB, chardev (244:0) > >       > [    3.582676] rtc-lpc55 rtc_lpc55: lpc55_rtc_get_time: bad result: 1 > >       > [    3.583332] rtc-lpc55 rtc_lpc55: hctosys: unable to read the hardware clock > >       > [    3.591252] cdns-i2c ff020000.i2c: recovery information complete > >       > [    3.597085] at24 0-0050: supply vcc not found, using dummy regulator > >       > [    3.603011] lpc55_l2 spi1.0: (2) mcu still not ready? > >       > [    3.608093] at24 0-0050: 256 byte spd EEPROM, read-only > >       > [    3.613620] lpc55_l2 spi1.0: (3) mcu still not ready? > >       > [    3.619362] lpc55_l2 spi1.0: (4) mcu still not ready? > >       > [    3.624224] rtc-rv3028 0-0052: registered as rtc1 > >       > [    3.628343] lpc55_l2 spi1.0: (5) mcu still not ready? > >       > [    3.633253] lpc55_l2 spi1.0: rx error: -110 > >       > [    3.639104] k81_bootloader 0-0010: probe > >       > [    3.641628] VMCU: : (235:0) registered > >       > [    3.641635] k81_bootloader 0-0010: probe completed > >       > [    3.668346] cdns-i2c ff020000.i2c: 400 kHz mmio ff020000 irq 28 > >       > [    3.669154] cdns-i2c ff030000.i2c: recovery information complete > >       > [    3.675412] lm75 1-0048: supply vs not found, using dummy regulator > >       > [    3.682920] lm75 1-0048: hwmon1: sensor 'tmp112' > >       > [    3.686548] i2c i2c-1: Added multiplexed i2c bus 3 > >       > [    3.690795] i2c i2c-1: Added multiplexed i2c bus 4 > >       > [    3.695629] i2c i2c-1: Added multiplexed i2c bus 5 > >       > [    3.700492] i2c i2c-1: Added multiplexed i2c bus 6 > >       > [    3.705157] pca954x 1-0070: registered 4 multiplexed busses for I2C switch pca9546 > >       > [    3.713049] at24 1-0054: supply vcc not found, using dummy regulator > >       > [    3.720067] at24 1-0054: 1024 byte 24c08 EEPROM, read-only > >       > [    3.724761] cdns-i2c ff030000.i2c: 100 kHz mmio ff030000 irq 29 > >       > [    3.731272] sfp viper_enet:sfp-eth1: Host maximum power 2.0W > >       > [    3.737549] sfp_register_socket: got sfp_bus > >       > [    3.740709] sfp_register_socket: register sfp_bus > >       > [    3.745459] sfp_register_bus: ops ok! > >       > [    3.749179] sfp_register_bus: Try to attach > >       > [    3.753419] sfp_register_bus: Attach succeeded > >       > [    3.757914] sfp_register_bus: upstream ops attach > >       > [    3.762677] sfp_register_bus: Bus registered > >       > [    3.766999] sfp_register_socket: register sfp_bus succeeded > >       > [    3.775870] of_cfs_init > >       > [    3.776000] of_cfs_init: OK > >       > [    3.778211] clk: Not disabling unused clocks > >       > [   11.278477] Freeing initrd memory: 206056K > >       > [   11.279406] Freeing unused kernel memory: 1536K > >       > [   11.314006] Checked W+X mappings: passed, no W+X pages found > >       > [   11.314142] Run /init as init process > >       > INIT: version 3.01 booting > >       > fsck (busybox 1.35.0) > >       > /dev/mmcblk0p1: clean, 12/102400 files, 238162/409600 blocks > >       > /dev/mmcblk0p2: clean, 12/102400 files, 171972/409600 blocks > >       > /dev/mmcblk0p3 was not cleanly unmounted, check forced. > >       > /dev/mmcblk0p3: 20/4096 files (0.0% non-contiguous), 663/16384 blocks > >       > [   11.553073] EXT4-fs (mmcblk0p3): mounted filesystem without journal. Opts: (null). Quota mode: disabled. > >       > Starting random number generator daemon. > >       > [   11.580662] random: crng init done > >       > Starting udev > >       > [   11.613159] udevd[142]: starting version 3.2.10 > >       > [   11.620385] udevd[143]: starting eudev-3.2.10 > >       > [   11.704481] macb ff0b0000.ethernet control_red: renamed from eth0 > >       > [   11.720264] macb ff0c0000.ethernet control_black: renamed from eth1 > >       > [   12.063396] ip_local_port_range: prefer different parity for start/end values. > >       > [   12.084801] rtc-lpc55 rtc_lpc55: lpc55_rtc_get_time: bad result: 1 > >       > hwclock: RTC_RD_TIME: Invalid exchange > >       > Mon Feb 27 08:40:53 UTC 2023 > >       > [   12.115309] rtc-lpc55 rtc_lpc55: lpc55_rtc_set_time: bad result > >       > hwclock: RTC_SET_TIME: Invalid exchange > >       > [   12.131027] rtc-lpc55 rtc_lpc55: lpc55_rtc_get_time: bad result: 1 > >       > Starting mcud > >       > INIT: Entering runlevel: 5 > >       > Configuring network interfaces... done. > >       > resetting network interface > >       > [   12.718295] macb ff0b0000.ethernet control_red: PHY [ff0b0000.ethernet-ffffffff:02] driver [Xilinx PCS/PMA PHY] (irq=POLL) > >       > [   12.723919] macb ff0b0000.ethernet control_red: configuring for phy/gmii link mode > >       > [   12.732151] pps pps0: new PPS source ptp0 > >       > [   12.735563] macb ff0b0000.ethernet: gem-ptp-timer ptp clock registered. > >       > [   12.745724] macb ff0c0000.ethernet control_black: PHY [ff0c0000.ethernet-ffffffff:01] driver [Xilinx PCS/PMA PHY] > >       (irq=POLL) > >       > [   12.753469] macb ff0c0000.ethernet control_black: configuring for phy/gmii link mode > >       > [   12.761804] pps pps1: new PPS source ptp1 > >       > [   12.765398] macb ff0c0000.ethernet: gem-ptp-timer ptp clock registered. > >       > Auto-negotiation: off > >       > Auto-negotiation: off > >       > [   16.828151] macb ff0b0000.ethernet control_red: unable to generate target frequency: 125000000 Hz > >       > [   16.834553] macb ff0b0000.ethernet control_red: Link is Up - 1Gbps/Full - flow control off > >       > [   16.860552] macb ff0c0000.ethernet control_black: unable to generate target frequency: 125000000 Hz > >       > [   16.867052] macb ff0c0000.ethernet control_black: Link is Up - 1Gbps/Full - flow control off > >       > Starting Failsafe Secure Shell server in port 2222: sshd > >       > done. > >       > Starting rpcbind daemon...done. > >       > > >       > [   17.093019] rtc-lpc55 rtc_lpc55: lpc55_rtc_get_time: bad result: 1 > >       > hwclock: RTC_RD_TIME: Invalid exchange > >       > Starting State Manager Service > >       > Start state-manager restarter... > >       > (XEN) d0v1 Forwarding AES operation: 3254779951 > >       > Starting /usr/sbin/xenstored....[   17.265256] BTRFS: device fsid 80efc224-c202-4f8e-a949-4dae7f04a0aa devid 1 transid 744 > >       /dev/dm-0 > >       > scanned by udevd (385) > >       > [   17.349933] BTRFS info (device dm-0): disk space caching is enabled > >       > [   17.350670] BTRFS info (device dm-0): has skinny extents > >       > [   17.364384] BTRFS info (device dm-0): enabling ssd optimizations > >       > [   17.830462] BTRFS: device fsid 27ff666b-f4e5-4f90-9054-c210db5b2e2e devid 1 transid 6 /dev/mapper/client_prov scanned by > >       mkfs.btrfs > >       > (526) > >       > [   17.872699] BTRFS info (device dm-1): using free space tree > >       > [   17.872771] BTRFS info (device dm-1): has skinny extents > >       > [   17.878114] BTRFS info (device dm-1): flagging fs with big metadata feature > >       > [   17.894289] BTRFS info (device dm-1): enabling ssd optimizations > >       > [   17.895695] BTRFS info (device dm-1): checking UUID tree > >       > > >       > Setting domain 0 name, domid and JSON config... > >       > Done setting up Dom0 > >       > Starting xenconsoled... > >       > Starting QEMU as disk backend for dom0 > >       > Starting domain watchdog daemon: xenwatchdogd startup > >       > > >       > [   18.408647] BTRFS: device fsid 5e08d5e9-bc2a-46b9-af6a-44c7087b8921 devid 1 transid 6 /dev/mapper/client_config scanned by > >       mkfs.btrfs > >       > (574) > >       > [done] > >       > [   18.465552] BTRFS info (device dm-2): using free space tree > >       > [   18.465629] BTRFS info (device dm-2): has skinny extents > >       > [   18.471002] BTRFS info (device dm-2): flagging fs with big metadata feature > >       > Starting crond: [   18.482371] BTRFS info (device dm-2): enabling ssd optimizations > >       > [   18.486659] BTRFS info (device dm-2): checking UUID tree > >       > OK > >       > starting rsyslogd ... Log partition ready after 0 poll loops > >       > done > >       > rsyslogd: cannot connect to 172.18.0.1:514 : Network is unreachable [v8.2208.0 try https://www.rsyslog.com/e/2027 ] > >       > [   18.670637] BTRFS: device fsid 39d7d9e1-967d-478e-94ae-690deb722095 devid 1 transid 608 /dev/dm-3 scanned by udevd (518) > >       > > >       > Please insert USB token and enter your role in login prompt. > >       > > >       > login: > >       > > >       > Regards, > >       > O. > >       > > >       > > >       > пн, 24 апр. 2023 г. в 23:39, Stefano Stabellini >: > >       >       Hi Oleg, > >       > > >       >       Here is the issue from your logs: > >       > > >       >       SError Interrupt on CPU0, code 0xbe000000 -- SError > >       > > >       >       SErrors are special signals to notify software of serious hardware > >       >       errors.  Something is going very wrong. Defective hardware is a > >       >       possibility.  Another possibility if software accessing address ranges > >       >       that it is not supposed to, sometimes it causes SErrors. > >       > > >       >       Cheers, > >       > > >       >       Stefano > >       > > >       > > >       > > >       >       On Mon, 24 Apr 2023, Oleg Nikitenko wrote: > >       > > >       >       > Hello, > >       >       > > >       >       > Thanks guys. > >       >       > I found out where the problem was. > >       >       > Now dom0 booted more. But I have a new one. > >       >       > This is a kernel panic during Dom0 loading. > >       >       > Maybe someone is able to suggest something ? > >       >       > > >       >       > Regards, > >       >       > O. > >       >       > > >       >       > [    3.771362] sfp_register_bus: upstream ops attach > >       >       > [    3.776119] sfp_register_bus: Bus registered > >       >       > [    3.780459] sfp_register_socket: register sfp_bus succeeded > >       >       > [    3.789399] of_cfs_init > >       >       > [    3.789499] of_cfs_init: OK > >       >       > [    3.791685] clk: Not disabling unused clocks > >       >       > [   11.010355] SError Interrupt on CPU0, code 0xbe000000 -- SError > >       >       > [   11.010380] CPU: 0 PID: 9 Comm: kworker/u4:0 Not tainted 5.15.72-xilinx-v2022.1 #1 > >       >       > [   11.010393] Workqueue: events_unbound async_run_entry_fn > >       >       > [   11.010414] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) > >       >       > [   11.010422] pc : simple_write_end+0xd0/0x130 > >       >       > [   11.010431] lr : generic_perform_write+0x118/0x1e0 > >       >       > [   11.010438] sp : ffffffc00809b910 > >       >       > [   11.010441] x29: ffffffc00809b910 x28: 0000000000000000 x27: ffffffef69ba88c0 > >       >       > [   11.010451] x26: 0000000000003eec x25: ffffff807515db00 x24: 0000000000000000 > >       >       > [   11.010459] x23: ffffffc00809ba90 x22: 0000000002aac000 x21: ffffff807315a260 > >       >       > [   11.010472] x20: 0000000000001000 x19: fffffffe02000000 x18: 0000000000000000 > >       >       > [   11.010481] x17: 00000000ffffffff x16: 0000000000008000 x15: 0000000000000000 > >       >       > [   11.010490] x14: 0000000000000000 x13: 0000000000000000 x12: 0000000000000000 > >       >       > [   11.010498] x11: 0000000000000000 x10: 0000000000000000 x9 : 0000000000000000 > >       >       > [   11.010507] x8 : 0000000000000000 x7 : ffffffef693ba680 x6 : 000000002d89b700 > >       >       > [   11.010515] x5 : fffffffe02000000 x4 : ffffff807315a3c8 x3 : 0000000000001000 > >       >       > [   11.010524] x2 : 0000000002aab000 x1 : 0000000000000001 x0 : 0000000000000005 > >       >       > [   11.010534] Kernel panic - not syncing: Asynchronous SError Interrupt > >       >       > [   11.010539] CPU: 0 PID: 9 Comm: kworker/u4:0 Not tainted 5.15.72-xilinx-v2022.1 #1 > >       >       > [   11.010545] Hardware name: D14 Viper Board - White Unit (DT) > >       >       > [   11.010548] Workqueue: events_unbound async_run_entry_fn > >       >       > [   11.010556] Call trace: > >       >       > [   11.010558]  dump_backtrace+0x0/0x1c4 > >       >       > [   11.010567]  show_stack+0x18/0x2c > >       >       > [   11.010574]  dump_stack_lvl+0x7c/0xa0 > >       >       > [   11.010583]  dump_stack+0x18/0x34 > >       >       > [   11.010588]  panic+0x14c/0x2f8 > >       >       > [   11.010597]  print_tainted+0x0/0xb0 > >       >       > [   11.010606]  arm64_serror_panic+0x6c/0x7c > >       >       > [   11.010614]  do_serror+0x28/0x60 > >       >       > [   11.010621]  el1h_64_error_handler+0x30/0x50 > >       >       > [   11.010628]  el1h_64_error+0x78/0x7c > >       >       > [   11.010633]  simple_write_end+0xd0/0x130 > >       >       > [   11.010639]  generic_perform_write+0x118/0x1e0 > >       >       > [   11.010644]  __generic_file_write_iter+0x138/0x1c4 > >       >       > [   11.010650]  generic_file_write_iter+0x78/0xd0 > >       >       > [   11.010656]  __kernel_write+0xfc/0x2ac > >       >       > [   11.010665]  kernel_write+0x88/0x160 > >       >       > [   11.010673]  xwrite+0x44/0x94 > >       >       > [   11.010680]  do_copy+0xa8/0x104 > >       >       > [   11.010686]  write_buffer+0x38/0x58 > >       >       > [   11.010692]  flush_buffer+0x4c/0xbc > >       >       > [   11.010698]  __gunzip+0x280/0x310 > >       >       > [   11.010704]  gunzip+0x1c/0x28 > >       >       > [   11.010709]  unpack_to_rootfs+0x170/0x2b0 > >       >       > [   11.010715]  do_populate_rootfs+0x80/0x164 > >       >       > [   11.010722]  async_run_entry_fn+0x48/0x164 > >       >       > [   11.010728]  process_one_work+0x1e4/0x3a0 > >       >       > [   11.010736]  worker_thread+0x7c/0x4c0 > >       >       > [   11.010743]  kthread+0x120/0x130 > >       >       > [   11.010750]  ret_from_fork+0x10/0x20 > >       >       > [   11.010757] SMP: stopping secondary CPUs > >       >       > [   11.010784] Kernel Offset: 0x2f61200000 from 0xffffffc008000000 > >       >       > [   11.010788] PHYS_OFFSET: 0x0 > >       >       > [   11.010790] CPU features: 0x00000401,00000842 > >       >       > [   11.010795] Memory Limit: none > >       >       > [   11.277509] ---[ end Kernel panic - not syncing: Asynchronous SError Interrupt ]--- > >       >       > > >       >       > пт, 21 апр. 2023 г. в 15:52, Michal Orzel >: > >       >       >       Hi Oleg, > >       >       > > >       >       >       On 21/04/2023 14:49, Oleg Nikitenko wrote: > >       >       >       >        > >       >       >       > > >       >       >       > > >       >       >       > Hello Michal, > >       >       >       > > >       >       >       > I was not able to enable earlyprintk in the xen for now. > >       >       >       > I decided to choose another way. > >       >       >       > This is a xen's command line that I found out completely. > >       >       >       > > >       >       >       > (XEN) $$$$ console=dtuart dtuart=serial0 dom0_mem=1600M dom0_max_vcpus=2 dom0_vcpus_pin bootscrub=0 > >       vwfi=native > >       >       sched=null > >       >       >       timer_slop=0 > >       >       >       Yes, adding a printk() in Xen was also a good idea. > >       >       > > >       >       >       > > >       >       >       > So you are absolutely right about a command line. > >       >       >       > Now I am going to find out why xen did not have the correct parameters from the device tree. > >       >       >       Maybe you will find this document helpful: > >       >       >       https://github.com/Xilinx/xen/blob/xlnx_rebase_4.16/docs/misc/arm/device-tree/booting.txt > >       >       > > >       >       >       ~Michal > >       >       > > >       >       >       > > >       >       >       > Regards, > >       >       >       > Oleg > >       >       >       > > >       >       >       > пт, 21 апр. 2023 г. в 11:16, Michal Orzel >>: > >       >       >       > > >       >       >       > > >       >       >       >     On 21/04/2023 10:04, Oleg Nikitenko wrote: > >       >       >       >     >        > >       >       >       >     > > >       >       >       >     > > >       >       >       >     > Hello Michal, > >       >       >       >     > > >       >       >       >     > Yes, I use yocto. > >       >       >       >     > > >       >       >       >     > Yesterday all day long I tried to follow your suggestions. > >       >       >       >     > I faced a problem. > >       >       >       >     > Manually in the xen config build file I pasted the strings: > >       >       >       >     In the .config file or in some Yocto file (listing additional Kconfig options) added to SRC_URI? > >       >       >       >     You shouldn't really modify .config file but if you do, you should execute "make olddefconfig" > >       afterwards. > >       >       >       > > >       >       >       >     > > >       >       >       >     > CONFIG_EARLY_PRINTK > >       >       >       >     > CONFIG_EARLY_PRINTK_ZYNQMP > >       >       >       >     > CONFIG_EARLY_UART_CHOICE_CADENCE > >       >       >       >     I hope you added =y to them. > >       >       >       > > >       >       >       >     Anyway, you have at least the following solutions: > >       >       >       >     1) Run bitbake xen -c menuconfig to properly set early printk > >       >       >       >     2) Find out how you enable other Kconfig options in your project (e.g. CONFIG_COLORING=y that is not > >       enabled by > >       >       default) > >       >       >       >     3) Append the following to "xen/arch/arm/configs/arm64_defconfig": > >       >       >       >     CONFIG_EARLY_PRINTK_ZYNQMP=y > >       >       >       > > >       >       >       >     ~Michal > >       >       >       > > >       >       >       >     > > >       >       >       >     > Host hangs in build time.  > >       >       >       >     > Maybe I did not set something in the config build file ? > >       >       >       >     > > >       >       >       >     > Regards, > >       >       >       >     > Oleg > >       >       >       >     > > >       >       >       >     > чт, 20 апр. 2023 г. в 11:57, Oleg Nikitenko > > >       >       >        >>>: > >       >       >       >     > > >       >       >       >     >     Thanks Michal, > >       >       >       >     > > >       >       >       >     >     You gave me an idea. > >       >       >       >     >     I am going to try it today. > >       >       >       >     > > >       >       >       >     >     Regards, > >       >       >       >     >     O. > >       >       >       >     > > >       >       >       >     >     чт, 20 апр. 2023 г. в 11:56, Oleg Nikitenko > > >       >       >        >>>: > >       >       >       >     > > >       >       >       >     >         Thanks Stefano. > >       >       >       >     > > >       >       >       >     >         I am going to do it today. > >       >       >       >     > > >       >       >       >     >         Regards, > >       >       >       >     >         O. > >       >       >       >     > > >       >       >       >     >         ср, 19 апр. 2023 г. в 23:05, Stefano Stabellini > >       > > >       >       >        >>>: > >       >       >       >     > > >       >       >       >     >             On Wed, 19 Apr 2023, Oleg Nikitenko wrote: > >       >       >       >     >             > Hi Michal, > >       >       >       >     >             > > >       >       >       >     >             > I corrected xen's command line. > >       >       >       >     >             > Now it is > >       >       >       >     >             > xen,xen-bootargs = "console=dtuart dtuart=serial0 dom0_mem=1600M dom0_max_vcpus=2 > >       dom0_vcpus_pin > >       >       >       bootscrub=0 vwfi=native sched=null > >       >       >       >     >             > timer_slop=0 way_size=65536 xen_colors=0-3 dom0_colors=4-7"; > >       >       >       >     > > >       >       >       >     >             4 colors is way too many for xen, just do xen_colors=0-0. There is no > >       >       >       >     >             advantage in using more than 1 color for Xen. > >       >       >       >     > > >       >       >       >     >             4 colors is too few for dom0, if you are giving 1600M of memory to Dom0. > >       >       >       >     >             Each color is 256M. For 1600M you should give at least 7 colors. Try: > >       >       >       >     > > >       >       >       >     >             xen_colors=0-0 dom0_colors=1-8 > >       >       >       >     > > >       >       >       >     > > >       >       >       >     > > >       >       >       >     >             > Unfortunately the result was the same. > >       >       >       >     >             > > >       >       >       >     >             > (XEN)  - Dom0 mode: Relaxed > >       >       >       >     >             > (XEN) P2M: 40-bit IPA with 40-bit PA and 8-bit VMID > >       >       >       >     >             > (XEN) P2M: 3 levels with order-1 root, VTCR 0x0000000080023558 > >       >       >       >     >             > (XEN) Scheduling granularity: cpu, 1 CPU per sched-resource > >       >       >       >     >             > (XEN) Coloring general information > >       >       >       >     >             > (XEN) Way size: 64kB > >       >       >       >     >             > (XEN) Max. number of colors available: 16 > >       >       >       >     >             > (XEN) Xen color(s): [ 0 ] > >       >       >       >     >             > (XEN) alternatives: Patching with alt table 00000000002cc690 -> 00000000002ccc0c > >       >       >       >     >             > (XEN) Color array allocation failed for dom0 > >       >       >       >     >             > (XEN) > >       >       >       >     >             > (XEN) **************************************** > >       >       >       >     >             > (XEN) Panic on CPU 0: > >       >       >       >     >             > (XEN) Error creating domain 0 > >       >       >       >     >             > (XEN) **************************************** > >       >       >       >     >             > (XEN) > >       >       >       >     >             > (XEN) Reboot in five seconds... > >       >       >       >     >             > > >       >       >       >     >             > I am going to find out how command line arguments passed and parsed. > >       >       >       >     >             > > >       >       >       >     >             > Regards, > >       >       >       >     >             > Oleg > >       >       >       >     >             > > >       >       >       >     >             > ср, 19 апр. 2023 г. в 11:25, Oleg Nikitenko > >       > > >       >       >        >>>: > >       >       >       >     >             >       Hi Michal, > >       >       >       >     >             > > >       >       >       >     >             > You put my nose into the problem. Thank you. > >       >       >       >     >             > I am going to use your point. > >       >       >       >     >             > Let's see what happens. > >       >       >       >     >             > > >       >       >       >     >             > Regards, > >       >       >       >     >             > Oleg > >       >       >       >     >             > > >       >       >       >     >             > > >       >       >       >     >             > ср, 19 апр. 2023 г. в 10:37, Michal Orzel > >       > > >       >       >        >>>: > >       >       >       >     >             >       Hi Oleg, > >       >       >       >     >             > > >       >       >       >     >             >       On 19/04/2023 09:03, Oleg Nikitenko wrote: > >       >       >       >     >             >       >        > >       >       >       >     >             >       > > >       >       >       >     >             >       > > >       >       >       >     >             >       > Hello Stefano, > >       >       >       >     >             >       > > >       >       >       >     >             >       > Thanks for the clarification. > >       >       >       >     >             >       > My company uses yocto for image generation. > >       >       >       >     >             >       > What kind of information do you need to consult me in this case ? > >       >       >       >     >             >       > > >       >       >       >     >             >       > Maybe modules sizes/addresses which were mentioned by @Julien Grall > >       >        > >       >       >       > >>> ? > >       >       >       >     >             > > >       >       >       >     >             >       Sorry for jumping into discussion, but FWICS the Xen command line you provided > >       seems to be > >       >       not the > >       >       >       one > >       >       >       >     >             >       Xen booted with. The error you are observing most likely is due to dom0 colors > >       >       configuration not > >       >       >       being > >       >       >       >     >             >       specified (i.e. lack of dom0_colors=<> parameter). Although in the command line you > >       >       provided, this > >       >       >       parameter > >       >       >       >     >             >       is set, I strongly doubt that this is the actual command line in use. > >       >       >       >     >             > > >       >       >       >     >             >       You wrote: > >       >       >       >     >             >       xen,xen-bootargs = "console=dtuart dtuart=serial0 dom0_mem=1600M dom0_max_vcpus=2 > >       >       dom0_vcpus_pin > >       >       >       bootscrub=0 vwfi=native > >       >       >       >     >             >       sched=null timer_slop=0 way_szize=65536 xen_colors=0-3 dom0_colors=4-7"; > >       >       >       >     >             > > >       >       >       >     >             >       but: > >       >       >       >     >             >       1) way_szize has a typo > >       >       >       >     >             >       2) you specified 4 colors (0-3) for Xen, but the boot log says that Xen has only > >       one: > >       >       >       >     >             >       (XEN) Xen color(s): [ 0 ] > >       >       >       >     >             > > >       >       >       >     >             >       This makes me believe that no colors configuration actually end up in command line > >       that Xen > >       >       booted > >       >       >       with. > >       >       >       >     >             >       Single color for Xen is a "default if not specified" and way size was probably > >       calculated > >       >       by asking > >       >       >       HW. > >       >       >       >     >             > > >       >       >       >     >             >       So I would suggest to first cross-check the command line in use. > >       >       >       >     >             > > >       >       >       >     >             >       ~Michal > >       >       >       >     >             > > >       >       >       >     >             > > >       >       >       >     >             >       > > >       >       >       >     >             >       > Regards, > >       >       >       >     >             >       > Oleg > >       >       >       >     >             >       > > >       >       >       >     >             >       > вт, 18 апр. 2023 г. в 20:44, Stefano Stabellini > >       >       >       > >> > >       >        > >       >       >       > >>>>: > >       >       >       >     >             >       > > >       >       >       >     >             >       >     On Tue, 18 Apr 2023, Oleg Nikitenko wrote: > >       >       >       >     >             >       >     > Hi Julien, > >       >       >       >     >             >       >     > > >       >       >       >     >             >       >     > >> This feature has not been merged in Xen upstream yet > >       >       >       >     >             >       >     > > >       >       >       >     >             >       >     > > would assume that upstream + the series on the ML [1] work > >       >       >       >     >             >       >     > > >       >       >       >     >             >       >     > Please clarify this point. > >       >       >       >     >             >       >     > Because the two thoughts are controversial. > >       >       >       >     >             >       > > >       >       >       >     >             >       >     Hi Oleg, > >       >       >       >     >             >       > > >       >       >       >     >             >       >     As Julien wrote, there is nothing controversial. As you are aware, > >       >       >       >     >             >       >     Xilinx maintains a separate Xen tree specific for Xilinx here: > >       >       >       >     >             >       >     https://github.com/xilinx/xen > > >       >        > >       >       >       >> > > >       >        > >       >       >       >>> > >       >       >       >     >             >       > > >       >       >       >     >             >       >     and the branch you are using (xlnx_rebase_4.16) comes from there. > >       >       >       >     >             >       > > >       >       >       >     >             >       > > >       >       >       >     >             >       >     Instead, the upstream Xen tree lives here: > >       >       >       >     >             >       >     https://xenbits.xen.org/gitweb/?p=xen.git;a=summary > >       >       >       > > >       >       >       >> > >       >       >       > > >       >       >       >>> > >       >       >       >     >             >       > > >       >       >       >     >             >       > > >       >       >       >     >             >       >     The Cache Coloring feature that you are trying to configure is present > >       >       >       >     >             >       >     in xlnx_rebase_4.16, but not yet present upstream (there is an > >       >       >       >     >             >       >     outstanding patch series to add cache coloring to Xen upstream but it > >       >       >       >     >             >       >     hasn't been merged yet.) > >       >       >       >     >             >       > > >       >       >       >     >             >       > > >       >       >       >     >             >       >     Anyway, if you are using xlnx_rebase_4.16 it doesn't matter too much for > >       >       >       >     >             >       >     you as you already have Cache Coloring as a feature there. > >       >       >       >     >             >       > > >       >       >       >     >             >       > > >       >       >       >     >             >       >     I take you are using ImageBuilder to generate the boot configuration? If > >       >       >       >     >             >       >     so, please post the ImageBuilder config file that you are using. > >       >       >       >     >             >       > > >       >       >       >     >             >       >     But from the boot message, it looks like the colors configuration for > >       >       >       >     >             >       >     Dom0 is incorrect. > >       >       >       >     >             >       > > >       >       >       >     >             > > >       >       >       >     >             > > >       >       >       >     >             > > >       >       >       >     > > >       >       >       > > >       >       > > >       >       > > >       >       > > >       > > >       > > >       > > > > > > > > From xen-devel-bounces@lists.xenproject.org Fri May 05 08:44:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 08:44:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530268.825783 (Exim 4.92) (envelope-from ) id 1pur2s-0007JS-9Y; Fri, 05 May 2023 08:44:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530268.825783; Fri, 05 May 2023 08:44:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pur2s-0007JL-5M; Fri, 05 May 2023 08:44:06 +0000 Received: by outflank-mailman (input) for mailman id 530268; Fri, 05 May 2023 08:44:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pur2q-0007JF-3J for xen-devel@lists.xenproject.org; Fri, 05 May 2023 08:44:04 +0000 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [2607:f8b0:4864:20::436]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f91ddcf6-eb20-11ed-8611-37d641c3527e; Fri, 05 May 2023 10:43:57 +0200 (CEST) Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-64115e652eeso18121362b3a.0 for ; Fri, 05 May 2023 01:43:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f91ddcf6-eb20-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683276236; x=1685868236; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=vw6kZ952yrAaWMx7SJZC4/SO8ee5o9H9xwCBUNJO3WQ=; b=q5vxHqowYJsEvZiYTYE8jJaE75Z2AaIGdDNnw/mybr/dzyd+DVNxB/f9jWI7WYMDEK sepGZ8THHFd/ojh2El7FUVxuHHE4y6iipvNegTcAM2vEQ5UEaHGnClmTZpUAYVX/MkXX f92XlsO5eyvmSkVr7PqpRYXotkldgVGjbFAyOG4a4zatq7RtqlhhkdUrg+9Tr1xcSb4u PmpCEmXkGXI+o1V2L3YuEBVXiTGxomDqm3j5l0ezt8UKehHqbWuO6Xkd01OTbEda5rSY muvMebR+xuRWW9bcf/A9V0Gnj09VAUR/zk/DcafuL4fo73aGaZ1Bud4xGLt+jDvu91OY 7hmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683276236; x=1685868236; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vw6kZ952yrAaWMx7SJZC4/SO8ee5o9H9xwCBUNJO3WQ=; b=V/k1Eis2af7lQX3OLs37H6qwYq2dysZ9/+AwTBYo3vPv5qnZSReaLd2Bm6LuDOnsVN hWMmcrDgxwz9JHGwRS6kSGuV8xpF0/Zo3puPk6PyWNC6cxPHbYBuo8FO6sU/F0PU54ie vrZuoWifNxzlru2FKBzi8HpQRlVIhIqaJl8Dsrz9BTqs7n69kvPJUY8QBoKUCsdFHtlU 2UVlT7mAZ9CPj+PeemVtiXv9OT3FqTOuFr3dTzUzfMG+Kllmrvz6QL9Fvg/qd6e9C5+p bXLq4zDC0SKRMEYwZ8Tx5hT1NKCgmJcqggmUpFOXczS9kxLY37/7xX67gVWd2nWZf0Dj +pIg== X-Gm-Message-State: AC+VfDzV9VQWvOcf0khDL3C2LzMg1W/hapRLXdvNAp8bIo6jsONZJJhY tcp/InZHzM0C/3hetm9gGut4EiD2UCXiy4+j2x0= X-Google-Smtp-Source: ACHHUZ7hoVEwPRZvJMGOtBlHKeRtHJilY1GaWJWTJBi9bOV89NMERsJSVAhckgTPekM7rez84rj5HuXKhBdsRpxUzoc= X-Received: by 2002:a17:90a:688f:b0:24e:1d3:e6a with SMTP id a15-20020a17090a688f00b0024e01d30e6amr5949759pjd.17.1683276235756; Fri, 05 May 2023 01:43:55 -0700 (PDT) MIME-Version: 1.0 References: <43f5fdaa-47c7-6ec9-c477-dac62a5bceae@amd.com> <4e859659-8532-7ba2-63b9-a06d91cb0ffc@amd.com> In-Reply-To: <4e859659-8532-7ba2-63b9-a06d91cb0ffc@amd.com> From: Oleg Nikitenko Date: Fri, 5 May 2023 11:48:31 +0300 Message-ID: Subject: Re: xen cache colors in ARM To: Michal Orzel Cc: Stefano Stabellini , Julien Grall , "xen-devel@lists.xenproject.org" , Bertrand Marquis , Carlo Nonato , Stewart.Hildebrand@amd.com Content-Type: multipart/alternative; boundary="000000000000175b6a05faee4a1e" --000000000000175b6a05faee4a1e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Michal, Thanks. Regards, Oleg =D0=BF=D1=82, 5 =D0=BC=D0=B0=D1=8F 2023=E2=80=AF=D0=B3. =D0=B2 11:34, Micha= l Orzel : > Hi Oleg, > > Replying, so that you do not need to wait for Stefano. > > On 05/05/2023 10:28, Oleg Nikitenko wrote: > > > > > > > > Hello Stefano, > > > > I would like to try a xen cache color property from this repo > https://xenbits.xen.org/git-http/xen.git < > https://xenbits.xen.org/git-http/xen.git> > > Could you tell whot branch I should use ? > Cache coloring feature is not part of the upstream tree and it is still > under review. > You can only find it integrated in the Xilinx Xen tree. > > ~Michal > > > > > Regards, > > Oleg > > > > =D0=BF=D1=82, 28 =D0=B0=D0=BF=D1=80. 2023=E2=80=AF=D0=B3. =D0=B2 00:51,= Stefano Stabellini >: > > > > I am familiar with the zcu102 but I don't know how you could possib= ly > > generate a SError. > > > > I suggest to try to use ImageBuilder [1] to generate the boot > > configuration as a test because that is known to work well for > zcu102. > > > > [1] https://gitlab.com/xen-project/imagebuilder < > https://gitlab.com/xen-project/imagebuilder> > > > > > > On Thu, 27 Apr 2023, Oleg Nikitenko wrote: > > > Hello Stefano, > > > > > > Thanks for clarification. > > > We nighter use ImageBuilder nor uboot boot script. > > > A model is zcu102 compatible. > > > > > > Regards, > > > O. > > > > > > =D0=B2=D1=82, 25 =D0=B0=D0=BF=D1=80. 2023=E2=80=AF=D0=B3. =D0=B2 = 21:21, Stefano Stabellini < > sstabellini@kernel.org >: > > > This is interesting. Are you using Xilinx hardware by any > chance? If so, > > > which board? > > > > > > Are you using ImageBuilder to generate your boot.scr boot > script? If so, > > > could you please post your ImageBuilder config file? If not= , > can you > > > post the source of your uboot boot script? > > > > > > SErrors are supposed to be related to a hardware failure of > some kind. > > > You are not supposed to be able to trigger an SError easily > by > > > "mistake". I have not seen SErrors due to wrong cache > coloring > > > configurations on any Xilinx board before. > > > > > > The differences between Xen with and without cache coloring > from a > > > hardware perspective are: > > > > > > - With cache coloring, the SMMU is enabled and does address > translations > > > even for dom0. Without cache coloring the SMMU could be > disabled, and > > > if enabled, the SMMU doesn't do any address translations > for Dom0. If > > > there is a hardware failure related to SMMU address > translation it > > > could only trigger with cache coloring. This would be my > normal > > > suggestion for you to explore, but the failure happens to= o > early > > > before any DMA-capable device is programmed. So I don't > think this can > > > be the issue. > > > > > > - With cache coloring, the memory allocation is very > different so you'll > > > end up using different DDR regions for Dom0. So if your > DDR is > > > defective, you might only see a failure with cache > coloring enabled > > > because you end up using different regions. > > > > > > > > > On Tue, 25 Apr 2023, Oleg Nikitenko wrote: > > > > Hi Stefano, > > > > > > > > Thank you. > > > > If I build xen without colors support there is not this > error. > > > > All the domains are booted well. > > > > Hense it can not be a hardware issue. > > > > This panic arrived during unpacking the rootfs. > > > > Here I attached the boot log xen/Dom0 without color. > > > > A highlighted strings printed exactly after the place > where 1-st time panic arrived. > > > > > > > > Xen 4.16.1-pre > > > > (XEN) Xen version 4.16.1-pre (nole2390@(none)) > (aarch64-portable-linux-gcc (GCC) 11.3.0) debug=3Dy 2023-04-21 > > > > (XEN) Latest ChangeSet: Wed Apr 19 12:56:14 2023 +0300 > git:321687b231-dirty > > > > (XEN) build-id: c1847258fdb1b79562fc710dda40008f96c0fde5 > > > > (XEN) Processor: 00000000410fd034: "ARM Limited", variant= : > 0x0, part 0xd03,rev 0x4 > > > > (XEN) 64-bit Execution: > > > > (XEN) Processor Features: 0000000000002222 > 0000000000000000 > > > > (XEN) Exception Levels: EL3:64+32 EL2:64+32 EL1:64+32 > EL0:64+32 > > > > (XEN) Extensions: FloatingPoint AdvancedSIMD > > > > (XEN) Debug Features: 0000000010305106 0000000000000000 > > > > (XEN) Auxiliary Features: 0000000000000000 > 0000000000000000 > > > > (XEN) Memory Model Features: 0000000000001122 > 0000000000000000 > > > > (XEN) ISA Features: 0000000000011120 0000000000000000 > > > > (XEN) 32-bit Execution: > > > > (XEN) Processor Features: > 0000000000000131:0000000000011011 > > > > (XEN) Instruction Sets: AArch32 A32 Thumb Thumb-2 > Jazelle > > > > (XEN) Extensions: GenericTimer Security > > > > (XEN) Debug Features: 0000000003010066 > > > > (XEN) Auxiliary Features: 0000000000000000 > > > > (XEN) Memory Model Features: 0000000010201105 > 0000000040000000 > > > > (XEN) 0000000001260000 > 0000000002102211 > > > > (XEN) ISA Features: 0000000002101110 0000000013112111 > 0000000021232042 > > > > (XEN) 0000000001112131 0000000000011142 > 0000000000011121 > > > > (XEN) Using SMC Calling Convention v1.2 > > > > (XEN) Using PSCI v1.1 > > > > (XEN) SMP: Allowing 4 CPUs > > > > (XEN) Generic Timer IRQ: phys=3D30 hyp=3D26 virt=3D27 Fre= q: > 100000 KHz > > > > (XEN) GICv2 initialization: > > > > (XEN) gic_dist_addr=3D00000000f9010000 > > > > (XEN) gic_cpu_addr=3D00000000f9020000 > > > > (XEN) gic_hyp_addr=3D00000000f9040000 > > > > (XEN) gic_vcpu_addr=3D00000000f9060000 > > > > (XEN) gic_maintenance_irq=3D25 > > > > (XEN) GICv2: Adjusting CPU interface base to 0xf902f000 > > > > (XEN) GICv2: 192 lines, 4 cpus, secure (IID 0200143b). > > > > (XEN) Using scheduler: null Scheduler (null) > > > > (XEN) Initializing null scheduler > > > > (XEN) WARNING: This is experimental software in > development. > > > > (XEN) Use at your own risk. > > > > (XEN) Allocated console ring of 32 KiB. > > > > (XEN) CPU0: Guest atomics will try 12 times before pausin= g > the domain > > > > (XEN) Bringing up CPU1 > > > > (XEN) CPU1: Guest atomics will try 13 times before pausin= g > the domain > > > > (XEN) CPU 1 booted. > > > > (XEN) Bringing up CPU2 > > > > (XEN) CPU2: Guest atomics will try 13 times before pausin= g > the domain > > > > (XEN) CPU 2 booted. > > > > (XEN) Bringing up CPU3 > > > > (XEN) CPU3: Guest atomics will try 13 times before pausin= g > the domain > > > > (XEN) Brought up 4 CPUs > > > > (XEN) CPU 3 booted. > > > > (XEN) smmu: /axi/smmu@fd800000: probing hardware > configuration... > > > > (XEN) smmu: /axi/smmu@fd800000: SMMUv2 with: > > > > (XEN) smmu: /axi/smmu@fd800000: stage 2 translation > > > > (XEN) smmu: /axi/smmu@fd800000: stream matching with 48 > register groups, mask 0x7fff<2>smmu: /axi/smmu@fd800000: 16 context > > > banks (0 > > > > stage-2 only) > > > > (XEN) smmu: /axi/smmu@fd800000: Stage-2: 48-bit IPA -> > 48-bit PA > > > > (XEN) smmu: /axi/smmu@fd800000: registered 29 master > devices > > > > (XEN) I/O virtualisation enabled > > > > (XEN) - Dom0 mode: Relaxed > > > > (XEN) P2M: 40-bit IPA with 40-bit PA and 8-bit VMID > > > > (XEN) P2M: 3 levels with order-1 root, VTCR > 0x0000000080023558 > > > > (XEN) Scheduling granularity: cpu, 1 CPU per sched-resour= ce > > > > (XEN) alternatives: Patching with alt table > 00000000002cc5c8 -> 00000000002ccb2c > > > > (XEN) *** LOADING DOMAIN 0 *** > > > > (XEN) Loading d0 kernel from boot module @ 00000000010000= 00 > > > > (XEN) Loading ramdisk from boot module @ 0000000002000000 > > > > (XEN) Allocating 1:1 mappings totalling 1600MB for dom0: > > > > (XEN) BANK[0] 0x00000010000000-0x00000020000000 (256MB) > > > > (XEN) BANK[1] 0x00000024000000-0x00000028000000 (64MB) > > > > (XEN) BANK[2] 0x00000030000000-0x00000080000000 (1280MB) > > > > (XEN) Grant table range: 0x00000000e00000-0x00000000e4000= 0 > > > > (XEN) smmu: /axi/smmu@fd800000: d0: p2maddr > 0x000000087bf94000 > > > > (XEN) Allocating PPI 16 for event channel interrupt > > > > (XEN) Extended region 0: 0x81200000->0xa0000000 > > > > (XEN) Extended region 1: 0xb1200000->0xc0000000 > > > > (XEN) Extended region 2: 0xc8000000->0xe0000000 > > > > (XEN) Extended region 3: 0xf0000000->0xf9000000 > > > > (XEN) Extended region 4: 0x100000000->0x600000000 > > > > (XEN) Extended region 5: 0x880000000->0x8000000000 > > > > (XEN) Extended region 6: 0x8001000000->0x10000000000 > > > > (XEN) Loading zImage from 0000000001000000 to > 0000000010000000-0000000010e41008 > > > > (XEN) Loading d0 initrd from 0000000002000000 to > 0x0000000013600000-0x000000001ff3a617 > > > > (XEN) Loading d0 DTB to > 0x0000000013400000-0x000000001340cbdc > > > > (XEN) Initial low memory virq threshold set at 0x4000 > pages. > > > > (XEN) Std. Loglevel: All > > > > (XEN) Guest Loglevel: All > > > > (XEN) *** Serial input to DOM0 (type 'CTRL-a' three times > to switch input) > > > > (XEN) null.c:353: 0 <-- d0v0 > > > > (XEN) Freed 356kB init memory. > > > > (XEN) d0v0 Unhandled SMC/HVC: 0x84000050 > > > > (XEN) d0v0 Unhandled SMC/HVC: 0x8600ff01 > > > > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff > to ICACTIVER4 > > > > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff > to ICACTIVER8 > > > > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff > to ICACTIVER12 > > > > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff > to ICACTIVER16 > > > > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff > to ICACTIVER20 > > > > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff > to ICACTIVER0 > > > > [ 0.000000] Booting Linux on physical CPU 0x0000000000 > [0x410fd034] > > > > [ 0.000000] Linux version 5.15.72-xilinx-v2022.1 > (oe-user@oe-host) (aarch64-portable-linux-gcc (GCC) 11.3.0, GNU ld (GNU > > > Binutils) > > > > 2.38.20220708) #1 SMP Tue Feb 21 05:47:54 UTC 2023 > > > > [ 0.000000] Machine model: D14 Viper Board - White Uni= t > > > > [ 0.000000] Xen 4.16 support found > > > > [ 0.000000] Zone ranges: > > > > [ 0.000000] DMA [mem > 0x0000000010000000-0x000000007fffffff] > > > > [ 0.000000] DMA32 empty > > > > [ 0.000000] Normal empty > > > > [ 0.000000] Movable zone start for each node > > > > [ 0.000000] Early memory node ranges > > > > [ 0.000000] node 0: [mem > 0x0000000010000000-0x000000001fffffff] > > > > [ 0.000000] node 0: [mem > 0x0000000022000000-0x0000000022147fff] > > > > [ 0.000000] node 0: [mem > 0x0000000022200000-0x0000000022347fff] > > > > [ 0.000000] node 0: [mem > 0x0000000024000000-0x0000000027ffffff] > > > > [ 0.000000] node 0: [mem > 0x0000000030000000-0x000000007fffffff] > > > > [ 0.000000] Initmem setup node 0 [mem > 0x0000000010000000-0x000000007fffffff] > > > > [ 0.000000] On node 0, zone DMA: 8192 pages in > unavailable ranges > > > > [ 0.000000] On node 0, zone DMA: 184 pages in > unavailable ranges > > > > [ 0.000000] On node 0, zone DMA: 7352 pages in > unavailable ranges > > > > [ 0.000000] cma: Reserved 256 MiB at 0x000000006e00000= 0 > > > > [ 0.000000] psci: probing for conduit method from DT. > > > > [ 0.000000] psci: PSCIv1.1 detected in firmware. > > > > [ 0.000000] psci: Using standard PSCI v0.2 function ID= s > > > > [ 0.000000] psci: Trusted OS migration not required > > > > [ 0.000000] psci: SMC Calling Convention v1.1 > > > > [ 0.000000] percpu: Embedded 16 pages/cpu s32792 r0 > d32744 u65536 > > > > [ 0.000000] Detected VIPT I-cache on CPU0 > > > > [ 0.000000] CPU features: kernel page table isolation > forced ON by KASLR > > > > [ 0.000000] CPU features: detected: Kernel page table > isolation (KPTI) > > > > [ 0.000000] Built 1 zonelists, mobility grouping on. > Total pages: 403845 > > > > [ 0.000000] Kernel command line: console=3Dhvc0 > earlycon=3Dxen earlyprintk=3Dxen clk_ignore_unused fips=3D1 root=3D/dev/r= am0 > > > maxcpus=3D2 > > > > [ 0.000000] Unknown kernel command line parameters > "earlyprintk=3Dxen fips=3D1", will be passed to user space. > > > > [ 0.000000] Dentry cache hash table entries: 262144 > (order: 9, 2097152 bytes, linear) > > > > [ 0.000000] Inode-cache hash table entries: 131072 > (order: 8, 1048576 bytes, linear) > > > > [ 0.000000] mem auto-init: stack:off, heap alloc:on, > heap free:on > > > > [ 0.000000] mem auto-init: clearing system memory may > take some time... > > > > [ 0.000000] Memory: 1121936K/1641024K available (9728K > kernel code, 836K rwdata, 2396K rodata, 1536K init, 262K bss, > > > 256944K reserved, > > > > 262144K cma-reserved) > > > > [ 0.000000] SLUB: HWalign=3D64, Order=3D0-3, MinObject= s=3D0, > CPUs=3D2, Nodes=3D1 > > > > [ 0.000000] rcu: Hierarchical RCU implementation. > > > > [ 0.000000] rcu: RCU event tracing is enabled. > > > > [ 0.000000] rcu: RCU restricting CPUs from NR_CPUS=3D8= to > nr_cpu_ids=3D2. > > > > [ 0.000000] rcu: RCU calculated value of > scheduler-enlistment delay is 25 jiffies. > > > > [ 0.000000] rcu: Adjusting geometry for > rcu_fanout_leaf=3D16, nr_cpu_ids=3D2 > > > > [ 0.000000] NR_IRQS: 64, nr_irqs: 64, preallocated > irqs: 0 > > > > [ 0.000000] Root IRQ handler: gic_handle_irq > > > > [ 0.000000] arch_timer: cp15 timer(s) running at > 100.00MHz (virt). > > > > [ 0.000000] clocksource: arch_sys_counter: mask: > 0xffffffffffffff max_cycles: 0x171024e7e0, max_idle_ns: 440795205315 ns > > > > [ 0.000000] sched_clock: 56 bits at 100MHz, resolution > 10ns, wraps every 4398046511100ns > > > > [ 0.000258] Console: colour dummy device 80x25 > > > > [ 0.310231] printk: console [hvc0] enabled > > > > [ 0.314403] Calibrating delay loop (skipped), value > calculated using timer frequency.. 200.00 BogoMIPS (lpj=3D400000) > > > > [ 0.324851] pid_max: default: 32768 minimum: 301 > > > > [ 0.329706] LSM: Security Framework initializing > > > > [ 0.334204] Yama: becoming mindful. > > > > [ 0.337865] Mount-cache hash table entries: 4096 > (order: 3, 32768 bytes, linear) > > > > [ 0.345180] Mountpoint-cache hash table entries: 4096 > (order: 3, 32768 bytes, linear) > > > > [ 0.354743] xen:grant_table: Grant tables using versio= n > 1 layout > > > > [ 0.359132] Grant table initialized > > > > [ 0.362664] xen:events: Using FIFO-based ABI > > > > [ 0.366993] Xen: initializing cpu0 > > > > [ 0.370515] rcu: Hierarchical SRCU implementation. > > > > [ 0.375930] smp: Bringing up secondary CPUs ... > > > > (XEN) null.c:353: 1 <-- d0v1 > > > > (XEN) d0v1: vGICD: unhandled word write 0x000000ffffffff > to ICACTIVER0 > > > > [ 0.382549] Detected VIPT I-cache on CPU1 > > > > [ 0.388712] Xen: initializing cpu1 > > > > [ 0.388743] CPU1: Booted secondary processor > 0x0000000001 [0x410fd034] > > > > [ 0.388829] smp: Brought up 1 node, 2 CPUs > > > > [ 0.406941] SMP: Total of 2 processors activated. > > > > [ 0.411698] CPU features: detected: 32-bit EL0 Support > > > > [ 0.416888] CPU features: detected: CRC32 instructions > > > > [ 0.422121] CPU: All CPU(s) started at EL1 > > > > [ 0.426248] alternatives: patching kernel code > > > > [ 0.431424] devtmpfs: initialized > > > > [ 0.441454] KASLR enabled > > > > [ 0.441602] clocksource: jiffies: mask: 0xffffffff > max_cycles: 0xffffffff, max_idle_ns: 7645041785100000 ns > > > > [ 0.448321] futex hash table entries: 512 (order: 3, > 32768 bytes, linear) > > > > [ 0.496183] NET: Registered PF_NETLINK/PF_ROUTE > protocol family > > > > [ 0.498277] DMA: preallocated 256 KiB GFP_KERNEL pool > for atomic allocations > > > > [ 0.503772] DMA: preallocated 256 KiB > GFP_KERNEL|GFP_DMA pool for atomic allocations > > > > [ 0.511610] DMA: preallocated 256 KiB > GFP_KERNEL|GFP_DMA32 pool for atomic allocations > > > > [ 0.519478] audit: initializing netlink subsys > (disabled) > > > > [ 0.524985] audit: type=3D2000 audit(0.336:1): > state=3Dinitialized audit_enabled=3D0 res=3D1 > > > > [ 0.529169] thermal_sys: Registered thermal governor > 'step_wise' > > > > [ 0.533023] hw-breakpoint: found 6 breakpoint and 4 > watchpoint registers. > > > > [ 0.545608] ASID allocator initialised with 32768 > entries > > > > [ 0.551030] xen:swiotlb_xen: Warning: only able to > allocate 4 MB for software IO TLB > > > > [ 0.559332] software IO TLB: mapped [mem > 0x0000000011800000-0x0000000011c00000] (4MB) > > > > [ 0.583565] HugeTLB registered 1.00 GiB page size, > pre-allocated 0 pages > > > > [ 0.584721] HugeTLB registered 32.0 MiB page size, > pre-allocated 0 pages > > > > [ 0.591478] HugeTLB registered 2.00 MiB page size, > pre-allocated 0 pages > > > > [ 0.598225] HugeTLB registered 64.0 KiB page size, > pre-allocated 0 pages > > > > [ 0.636520] DRBG: Continuing without Jitter RNG > > > > [ 0.737187] raid6: neonx8 gen() 2143 MB/s > > > > [ 0.805294] raid6: neonx8 xor() 1589 MB/s > > > > [ 0.873406] raid6: neonx4 gen() 2177 MB/s > > > > [ 0.941499] raid6: neonx4 xor() 1556 MB/s > > > > [ 1.009612] raid6: neonx2 gen() 2072 MB/s > > > > [ 1.077715] raid6: neonx2 xor() 1430 MB/s > > > > [ 1.145834] raid6: neonx1 gen() 1769 MB/s > > > > [ 1.213935] raid6: neonx1 xor() 1214 MB/s > > > > [ 1.282046] raid6: int64x8 gen() 1366 MB/s > > > > [ 1.350132] raid6: int64x8 xor() 773 MB/s > > > > [ 1.418259] raid6: int64x4 gen() 1602 MB/s > > > > [ 1.486349] raid6: int64x4 xor() 851 MB/s > > > > [ 1.554464] raid6: int64x2 gen() 1396 MB/s > > > > [ 1.622561] raid6: int64x2 xor() 744 MB/s > > > > [ 1.690687] raid6: int64x1 gen() 1033 MB/s > > > > [ 1.758770] raid6: int64x1 xor() 517 MB/s > > > > [ 1.758809] raid6: using algorithm neonx4 gen() 2177 > MB/s > > > > [ 1.762941] raid6: .... xor() 1556 MB/s, rmw enabled > > > > [ 1.767957] raid6: using neon recovery algorithm > > > > [ 1.772824] xen:balloon: Initialising balloon driver > > > > [ 1.778021] iommu: Default domain type: Translated > > > > [ 1.782584] iommu: DMA domain TLB invalidation policy: > strict mode > > > > [ 1.789149] SCSI subsystem initialized > > > > [ 1.792820] usbcore: registered new interface driver > usbfs > > > > [ 1.798254] usbcore: registered new interface driver h= ub > > > > [ 1.803626] usbcore: registered new device driver usb > > > > [ 1.808761] pps_core: LinuxPPS API ver. 1 registered > > > > [ 1.813716] pps_core: Software ver. 5.3.6 - Copyright > 2005-2007 Rodolfo Giometti > > > > > [ 1.822903] PTP clock support registered > > > > [ 1.826893] EDAC MC: Ver: 3.0.0 > > > > [ 1.830375] zynqmp-ipi-mbox mailbox@ff990400: > Registered ZynqMP IPI mbox with TX/RX channels. > > > > [ 1.838863] zynqmp-ipi-mbox mailbox@ff990600: > Registered ZynqMP IPI mbox with TX/RX channels. > > > > [ 1.847356] zynqmp-ipi-mbox mailbox@ff990800: > Registered ZynqMP IPI mbox with TX/RX channels. > > > > [ 1.855907] FPGA manager framework > > > > [ 1.859952] clocksource: Switched to clocksource > arch_sys_counter > > > > [ 1.871712] NET: Registered PF_INET protocol family > > > > [ 1.871838] IP idents hash table entries: 32768 (order= : > 6, 262144 bytes, linear) > > > > [ 1.879392] tcp_listen_portaddr_hash hash table > entries: 1024 (order: 2, 16384 bytes, linear) > > > > [ 1.887078] Table-perturb hash table entries: 65536 > (order: 6, 262144 bytes, linear) > > > > [ 1.894846] TCP established hash table entries: 16384 > (order: 5, 131072 bytes, linear) > > > > [ 1.902900] TCP bind hash table entries: 16384 (order: > 6, 262144 bytes, linear) > > > > [ 1.910350] TCP: Hash tables configured (established > 16384 bind 16384) > > > > [ 1.916778] UDP hash table entries: 1024 (order: 3, > 32768 bytes, linear) > > > > [ 1.923509] UDP-Lite hash table entries: 1024 (order: > 3, 32768 bytes, linear) > > > > [ 1.930759] NET: Registered PF_UNIX/PF_LOCAL protocol > family > > > > [ 1.936834] RPC: Registered named UNIX socket transpor= t > module. > > > > [ 1.942342] RPC: Registered udp transport module. > > > > [ 1.947088] RPC: Registered tcp transport module. > > > > [ 1.951843] RPC: Registered tcp NFSv4.1 backchannel > transport module. > > > > [ 1.958334] PCI: CLS 0 bytes, default 64 > > > > [ 1.962709] Trying to unpack rootfs image as > initramfs... > > > > [ 1.977090] workingset: timestamp_bits=3D62 max_order= =3D19 > bucket_order=3D0 > > > > [ 1.982863] Installing knfsd (copyright (C) 1996 > okir@monad.swb.de ). > > > > [ 2.021045] NET: Registered PF_ALG protocol family > > > > [ 2.021122] xor: measuring software checksum speed > > > > [ 2.029347] 8regs : 2366 MB/sec > > > > [ 2.033081] 32regs : 2802 MB/sec > > > > [ 2.038223] arm64_neon : 2320 MB/sec > > > > [ 2.038385] xor: using function: 32regs (2802 MB/sec) > > > > [ 2.043614] Block layer SCSI generic (bsg) driver > version 0.4 loaded (major 247) > > > > [ 2.050959] io scheduler mq-deadline registered > > > > [ 2.055521] io scheduler kyber registered > > > > [ 2.068227] xen:xen_evtchn: Event-channel device > installed > > > > [ 2.069281] Serial: 8250/16550 driver, 4 ports, IRQ > sharing disabled > > > > [ 2.076190] cacheinfo: Unable to detect cache hierarch= y > for CPU 0 > > > > [ 2.085548] brd: module loaded > > > > [ 2.089290] loop: module loaded > > > > [ 2.089341] Invalid max_queues (4), will use default > max: 2. > > > > [ 2.094565] tun: Universal TUN/TAP device driver, 1.6 > > > > [ 2.098655] xen_netfront: Initialising Xen virtual > ethernet driver > > > > [ 2.104156] usbcore: registered new interface driver > rtl8150 > > > > [ 2.109813] usbcore: registered new interface driver > r8152 > > > > [ 2.115367] usbcore: registered new interface driver > asix > > > > [ 2.120794] usbcore: registered new interface driver > ax88179_178a > > > > [ 2.126934] usbcore: registered new interface driver > cdc_ether > > > > [ 2.132816] usbcore: registered new interface driver > cdc_eem > > > > [ 2.138527] usbcore: registered new interface driver > net1080 > > > > [ 2.144256] usbcore: registered new interface driver > cdc_subset > > > > [ 2.150205] usbcore: registered new interface driver > zaurus > > > > [ 2.155837] usbcore: registered new interface driver > cdc_ncm > > > > [ 2.161550] usbcore: registered new interface driver > r8153_ecm > > > > [ 2.168240] usbcore: registered new interface driver > cdc_acm > > > > [ 2.173109] cdc_acm: USB Abstract Control Model driver > for USB modems and ISDN adapters > > > > [ 2.181358] usbcore: registered new interface driver u= as > > > > [ 2.186547] usbcore: registered new interface driver > usb-storage > > > > [ 2.192643] usbcore: registered new interface driver > ftdi_sio > > > > [ 2.198384] usbserial: USB Serial support registered > for FTDI USB Serial Device > > > > [ 2.206118] udc-core: couldn't find an available UDC - > added [g_mass_storage] to list of pending drivers > > > > [ 2.215332] i2c_dev: i2c /dev entries driver > > > > [ 2.220467] xen_wdt xen_wdt: initialized (timeout=3D60= s, > nowayout=3D0) > > > > [ 2.225923] device-mapper: uevent: version 1.0.3 > > > > [ 2.230668] device-mapper: ioctl: 4.45.0-ioctl > (2021-03-22) initialised: dm-devel@redhat.com > > > > [ 2.239315] EDAC MC0: Giving out device to module 1 > controller synps_ddr_controller: DEV synps_edac (INTERRUPT) > > > > [ 2.249405] EDAC DEVICE0: Giving out device to module > zynqmp-ocm-edac controller zynqmp_ocm: DEV > > > ff960000.memory-controller (INTERRUPT) > > > > [ 2.261719] sdhci: Secure Digital Host Controller > Interface driver > > > > [ 2.267487] sdhci: Copyright(c) Pierre Ossman > > > > [ 2.271890] sdhci-pltfm: SDHCI platform and OF driver > helper > > > > [ 2.278157] ledtrig-cpu: registered to indicate > activity on CPUs > > > > [ 2.283816] zynqmp_firmware_probe Platform Management > API v1.1 > > > > [ 2.289554] zynqmp_firmware_probe Trustzone version v1= .0 > > > > [ 2.327875] securefw securefw: securefw probed > > > > [ 2.328324] alg: No test for xilinx-zynqmp-aes > (zynqmp-aes) > > > > [ 2.332563] zynqmp_aes > firmware:zynqmp-firmware:zynqmp-aes: AES Successfully Registered > > > > [ 2.341183] alg: No test for xilinx-zynqmp-rsa > (zynqmp-rsa) > > > > [ 2.347667] remoteproc remoteproc0: > ff9a0000.rf5ss:r5f_0 is available > > > > [ 2.353003] remoteproc remoteproc1: > ff9a0000.rf5ss:r5f_1 is available > > > > [ 2.362605] fpga_manager fpga0: Xilinx ZynqMP FPGA > Manager registered > > > > [ 2.366540] viper-xen-proxy viper-xen-proxy: Viper Xen > Proxy registered > > > > [ 2.372525] viper-vdpp a4000000.vdpp: Device Tree > Probing > > > > [ 2.377778] viper-vdpp a4000000.vdpp: VDPP Version: > 1.3.9.0 Info: 1.512.15.0 KeyLen: 32 > > > > [ 2.386432] viper-vdpp a4000000.vdpp: Unable to > register tamper handler. Retrying... > > > > [ 2.394094] viper-vdpp-net a5000000.vdpp_net: Device > Tree Probing > > > > [ 2.399854] viper-vdpp-net a5000000.vdpp_net: Device > registered > > > > [ 2.405931] viper-vdpp-stat a8000000.vdpp_stat: Device > Tree Probing > > > > [ 2.412037] viper-vdpp-stat a8000000.vdpp_stat: Build > parameters: VTI Count: 512 Event Count: 32 > > > > [ 2.420856] default preset > > > > [ 2.423797] viper-vdpp-stat a8000000.vdpp_stat: Device > registered > > > > [ 2.430054] viper-vdpp-rng ac000000.vdpp_rng: Device > Tree Probing > > > > [ 2.435948] viper-vdpp-rng ac000000.vdpp_rng: Device > registered > > > > [ 2.441976] vmcu driver init > > > > [ 2.444922] VMCU: : (240:0) registered > > > > [ 2.444956] In K81 Updater init > > > > [ 2.449003] pktgen: Packet Generator for packet > performance testing. Version: 2.75 > > > > [ 2.468833] Initializing XFRM netlink socket > > > > [ 2.468902] NET: Registered PF_PACKET protocol family > > > > [ 2.472729] Bridge firewalling registered > > > > [ 2.476785] 8021q: 802.1Q VLAN Support v1.8 > > > > [ 2.481341] registered taskstats version 1 > > > > [ 2.486394] Btrfs loaded, crc32c=3Dcrc32c-generic, > zoned=3Dno, fsverity=3Dno > > > > [ 2.503145] ff010000.serial: ttyPS1 at MMIO 0xff010000 > (irq =3D 36, base_baud =3D 6250000) is a xuartps > > > > [ 2.507103] of-fpga-region fpga-full: FPGA Region prob= ed > > > > [ 2.512986] xilinx-zynqmp-dma fd500000.dma-controller: > ZynqMP DMA driver Probe success > > > > [ 2.520267] xilinx-zynqmp-dma fd510000.dma-controller: > ZynqMP DMA driver Probe success > > > > [ 2.528239] xilinx-zynqmp-dma fd520000.dma-controller: > ZynqMP DMA driver Probe success > > > > [ 2.536152] xilinx-zynqmp-dma fd530000.dma-controller: > ZynqMP DMA driver Probe success > > > > [ 2.544153] xilinx-zynqmp-dma fd540000.dma-controller: > ZynqMP DMA driver Probe success > > > > [ 2.552127] xilinx-zynqmp-dma fd550000.dma-controller: > ZynqMP DMA driver Probe success > > > > [ 2.560178] xilinx-zynqmp-dma ffa80000.dma-controller: > ZynqMP DMA driver Probe success > > > > [ 2.567987] xilinx-zynqmp-dma ffa90000.dma-controller: > ZynqMP DMA driver Probe success > > > > [ 2.576018] xilinx-zynqmp-dma ffaa0000.dma-controller: > ZynqMP DMA driver Probe success > > > > [ 2.583889] xilinx-zynqmp-dma ffab0000.dma-controller: > ZynqMP DMA driver Probe success > > > > [ 2.946379] spi-nor spi0.0: mt25qu512a (131072 Kbytes) > > > > [ 2.946467] 2 fixed-partitions partitions found on MTD > device spi0.0 > > > > [ 2.952393] Creating 2 MTD partitions on "spi0.0": > > > > [ 2.957231] 0x000004000000-0x000008000000 : "bank A" > > > > [ 2.963332] 0x000000000000-0x000004000000 : "bank B" > > > > [ 2.968694] macb ff0b0000.ethernet: Not enabling > partial store and forward > > > > [ 2.975333] macb ff0b0000.ethernet eth0: Cadence GEM > rev 0x50070106 at 0xff0b0000 irq 25 (18:41:fe:0f:ff:02) > > > > [ 2.984472] macb ff0c0000.ethernet: Not enabling > partial store and forward > > > > [ 2.992144] macb ff0c0000.ethernet eth1: Cadence GEM > rev 0x50070106 at 0xff0c0000 irq 26 (18:41:fe:0f:ff:03) > > > > [ 3.001043] viper_enet viper_enet: Viper power GPIOs > initialised > > > > [ 3.007313] viper_enet viper_enet vnet0 > (uninitialized): Validate interface QSGMII > > > > [ 3.014914] viper_enet viper_enet vnet1 > (uninitialized): Validate interface QSGMII > > > > [ 3.022138] viper_enet viper_enet vnet1 > (uninitialized): Validate interface type 18 > > > > [ 3.030274] viper_enet viper_enet vnet2 > (uninitialized): Validate interface QSGMII > > > > [ 3.037785] viper_enet viper_enet vnet3 > (uninitialized): Validate interface QSGMII > > > > [ 3.045301] viper_enet viper_enet: Viper enet register= ed > > > > [ 3.050958] xilinx-axipmon ffa00000.perf-monitor: > Probed Xilinx APM > > > > [ 3.057135] xilinx-axipmon fd0b0000.perf-monitor: > Probed Xilinx APM > > > > [ 3.063538] xilinx-axipmon fd490000.perf-monitor: > Probed Xilinx APM > > > > [ 3.069920] xilinx-axipmon ffa10000.perf-monitor: > Probed Xilinx APM > > > > [ 3.097729] si70xx: probe of 2-0040 failed with error = -5 > > > > [ 3.098042] cdns-wdt fd4d0000.watchdog: Xilinx Watchdo= g > Timer with timeout 60s > > > > [ 3.105111] cdns-wdt ff150000.watchdog: Xilinx Watchdo= g > Timer with timeout 10s > > > > [ 3.112457] viper-tamper viper-tamper: Device register= ed > > > > [ 3.117593] active_bank active_bank: boot bank: 1 > > > > [ 3.122184] active_bank active_bank: boot mode: (0x02) > qspi32 > > > > [ 3.128247] viper-vdpp a4000000.vdpp: Device Tree > Probing > > > > [ 3.133439] viper-vdpp a4000000.vdpp: VDPP Version: > 1.3.9.0 Info: 1.512.15.0 KeyLen: 32 > > > > [ 3.142151] viper-vdpp a4000000.vdpp: Tamper handler > registered > > > > [ 3.147438] viper-vdpp a4000000.vdpp: Device registere= d > > > > [ 3.153007] lpc55_l2 spi1.0: registered handler for > protocol 0 > > > > [ 3.158582] lpc55_user lpc55_user: The major number fo= r > your device is 236 > > > > [ 3.165976] lpc55_l2 spi1.0: registered handler for > protocol 1 > > > > [ 3.181999] rtc-lpc55 rtc_lpc55: lpc55_rtc_get_time: > bad result: 1 > > > > [ 3.182856] rtc-lpc55 rtc_lpc55: registered as rtc0 > > > > [ 3.188656] lpc55_l2 spi1.0: (2) mcu still not ready? > > > > [ 3.193744] lpc55_l2 spi1.0: (3) mcu still not ready? > > > > [ 3.198848] lpc55_l2 spi1.0: (4) mcu still not ready? > > > > [ 3.202932] mmc0: SDHCI controller on ff160000.mmc > [ff160000.mmc] using ADMA 64-bit > > > > [ 3.210689] lpc55_l2 spi1.0: (5) mcu still not ready? > > > > [ 3.215694] lpc55_l2 spi1.0: rx error: -110 > > > > [ 3.284438] mmc0: new HS200 MMC card at address 0001 > > > > [ 3.285179] mmcblk0: mmc0:0001 SEM16G 14.6 GiB > > > > [ 3.291784] mmcblk0: p1 p2 p3 p4 p5 p6 p7 p8 > > > > [ 3.293915] mmcblk0boot0: mmc0:0001 SEM16G 4.00 MiB > > > > [ 3.299054] mmcblk0boot1: mmc0:0001 SEM16G 4.00 MiB > > > > [ 3.303905] mmcblk0rpmb: mmc0:0001 SEM16G 4.00 MiB, > chardev (244:0) > > > > [ 3.582676] rtc-lpc55 rtc_lpc55: lpc55_rtc_get_time: > bad result: 1 > > > > [ 3.583332] rtc-lpc55 rtc_lpc55: hctosys: unable to > read the hardware clock > > > > [ 3.591252] cdns-i2c ff020000.i2c: recovery informatio= n > complete > > > > [ 3.597085] at24 0-0050: supply vcc not found, using > dummy regulator > > > > [ 3.603011] lpc55_l2 spi1.0: (2) mcu still not ready? > > > > [ 3.608093] at24 0-0050: 256 byte spd EEPROM, read-onl= y > > > > [ 3.613620] lpc55_l2 spi1.0: (3) mcu still not ready? > > > > [ 3.619362] lpc55_l2 spi1.0: (4) mcu still not ready? > > > > [ 3.624224] rtc-rv3028 0-0052: registered as rtc1 > > > > [ 3.628343] lpc55_l2 spi1.0: (5) mcu still not ready? > > > > [ 3.633253] lpc55_l2 spi1.0: rx error: -110 > > > > [ 3.639104] k81_bootloader 0-0010: probe > > > > [ 3.641628] VMCU: : (235:0) registered > > > > [ 3.641635] k81_bootloader 0-0010: probe completed > > > > [ 3.668346] cdns-i2c ff020000.i2c: 400 kHz mmio > ff020000 irq 28 > > > > [ 3.669154] cdns-i2c ff030000.i2c: recovery informatio= n > complete > > > > [ 3.675412] lm75 1-0048: supply vs not found, using > dummy regulator > > > > [ 3.682920] lm75 1-0048: hwmon1: sensor 'tmp112' > > > > [ 3.686548] i2c i2c-1: Added multiplexed i2c bus 3 > > > > [ 3.690795] i2c i2c-1: Added multiplexed i2c bus 4 > > > > [ 3.695629] i2c i2c-1: Added multiplexed i2c bus 5 > > > > [ 3.700492] i2c i2c-1: Added multiplexed i2c bus 6 > > > > [ 3.705157] pca954x 1-0070: registered 4 multiplexed > busses for I2C switch pca9546 > > > > [ 3.713049] at24 1-0054: supply vcc not found, using > dummy regulator > > > > [ 3.720067] at24 1-0054: 1024 byte 24c08 EEPROM, > read-only > > > > [ 3.724761] cdns-i2c ff030000.i2c: 100 kHz mmio > ff030000 irq 29 > > > > [ 3.731272] sfp viper_enet:sfp-eth1: Host maximum powe= r > 2.0W > > > > [ 3.737549] sfp_register_socket: got sfp_bus > > > > [ 3.740709] sfp_register_socket: register sfp_bus > > > > [ 3.745459] sfp_register_bus: ops ok! > > > > [ 3.749179] sfp_register_bus: Try to attach > > > > [ 3.753419] sfp_register_bus: Attach succeeded > > > > [ 3.757914] sfp_register_bus: upstream ops attach > > > > [ 3.762677] sfp_register_bus: Bus registered > > > > [ 3.766999] sfp_register_socket: register sfp_bus > succeeded > > > > [ 3.775870] of_cfs_init > > > > [ 3.776000] of_cfs_init: OK > > > > [ 3.778211] clk: Not disabling unused clocks > > > > [ 11.278477] Freeing initrd memory: 206056K > > > > [ 11.279406] Freeing unused kernel memory: 1536K > > > > [ 11.314006] Checked W+X mappings: passed, no W+X pages > found > > > > [ 11.314142] Run /init as init process > > > > INIT: version 3.01 booting > > > > fsck (busybox 1.35.0) > > > > /dev/mmcblk0p1: clean, 12/102400 files, 238162/409600 > blocks > > > > /dev/mmcblk0p2: clean, 12/102400 files, 171972/409600 > blocks > > > > /dev/mmcblk0p3 was not cleanly unmounted, check forced. > > > > /dev/mmcblk0p3: 20/4096 files (0.0% non-contiguous), > 663/16384 blocks > > > > [ 11.553073] EXT4-fs (mmcblk0p3): mounted filesystem > without journal. Opts: (null). Quota mode: disabled. > > > > Starting random number generator daemon. > > > > [ 11.580662] random: crng init done > > > > Starting udev > > > > [ 11.613159] udevd[142]: starting version 3.2.10 > > > > [ 11.620385] udevd[143]: starting eudev-3.2.10 > > > > [ 11.704481] macb ff0b0000.ethernet control_red: rename= d > from eth0 > > > > [ 11.720264] macb ff0c0000.ethernet control_black: > renamed from eth1 > > > > [ 12.063396] ip_local_port_range: prefer different > parity for start/end values. > > > > [ 12.084801] rtc-lpc55 rtc_lpc55: lpc55_rtc_get_time: > bad result: 1 > > > > hwclock: RTC_RD_TIME: Invalid exchange > > > > Mon Feb 27 08:40:53 UTC 2023 > > > > [ 12.115309] rtc-lpc55 rtc_lpc55: lpc55_rtc_set_time: > bad result > > > > hwclock: RTC_SET_TIME: Invalid exchange > > > > [ 12.131027] rtc-lpc55 rtc_lpc55: lpc55_rtc_get_time: > bad result: 1 > > > > Starting mcud > > > > INIT: Entering runlevel: 5 > > > > Configuring network interfaces... done. > > > > resetting network interface > > > > [ 12.718295] macb ff0b0000.ethernet control_red: PHY > [ff0b0000.ethernet-ffffffff:02] driver [Xilinx PCS/PMA PHY] (irq=3DPOLL) > > > > [ 12.723919] macb ff0b0000.ethernet control_red: > configuring for phy/gmii link mode > > > > [ 12.732151] pps pps0: new PPS source ptp0 > > > > [ 12.735563] macb ff0b0000.ethernet: gem-ptp-timer ptp > clock registered. > > > > [ 12.745724] macb ff0c0000.ethernet control_black: PHY > [ff0c0000.ethernet-ffffffff:01] driver [Xilinx PCS/PMA PHY] > > > (irq=3DPOLL) > > > > [ 12.753469] macb ff0c0000.ethernet control_black: > configuring for phy/gmii link mode > > > > [ 12.761804] pps pps1: new PPS source ptp1 > > > > [ 12.765398] macb ff0c0000.ethernet: gem-ptp-timer ptp > clock registered. > > > > Auto-negotiation: off > > > > Auto-negotiation: off > > > > [ 16.828151] macb ff0b0000.ethernet control_red: unable > to generate target frequency: 125000000 Hz > > > > [ 16.834553] macb ff0b0000.ethernet control_red: Link i= s > Up - 1Gbps/Full - flow control off > > > > [ 16.860552] macb ff0c0000.ethernet control_black: > unable to generate target frequency: 125000000 Hz > > > > [ 16.867052] macb ff0c0000.ethernet control_black: Link > is Up - 1Gbps/Full - flow control off > > > > Starting Failsafe Secure Shell server in port 2222: sshd > > > > done. > > > > Starting rpcbind daemon...done. > > > > > > > > [ 17.093019] rtc-lpc55 rtc_lpc55: lpc55_rtc_get_time: > bad result: 1 > > > > hwclock: RTC_RD_TIME: Invalid exchange > > > > Starting State Manager Service > > > > Start state-manager restarter... > > > > (XEN) d0v1 Forwarding AES operation: 3254779951 > > > > Starting /usr/sbin/xenstored....[ 17.265256] BTRFS: > device fsid 80efc224-c202-4f8e-a949-4dae7f04a0aa devid 1 transid 744 > > > /dev/dm-0 > > > > scanned by udevd (385) > > > > [ 17.349933] BTRFS info (device dm-0): disk space > caching is enabled > > > > [ 17.350670] BTRFS info (device dm-0): has skinny exten= ts > > > > [ 17.364384] BTRFS info (device dm-0): enabling ssd > optimizations > > > > [ 17.830462] BTRFS: device fsid > 27ff666b-f4e5-4f90-9054-c210db5b2e2e devid 1 transid 6 > /dev/mapper/client_prov scanned by > > > mkfs.btrfs > > > > (526) > > > > [ 17.872699] BTRFS info (device dm-1): using free space > tree > > > > [ 17.872771] BTRFS info (device dm-1): has skinny exten= ts > > > > [ 17.878114] BTRFS info (device dm-1): flagging fs with > big metadata feature > > > > [ 17.894289] BTRFS info (device dm-1): enabling ssd > optimizations > > > > [ 17.895695] BTRFS info (device dm-1): checking UUID tr= ee > > > > > > > > Setting domain 0 name, domid and JSON config... > > > > Done setting up Dom0 > > > > Starting xenconsoled... > > > > Starting QEMU as disk backend for dom0 > > > > Starting domain watchdog daemon: xenwatchdogd startup > > > > > > > > [ 18.408647] BTRFS: device fsid > 5e08d5e9-bc2a-46b9-af6a-44c7087b8921 devid 1 transid 6 > /dev/mapper/client_config scanned by > > > mkfs.btrfs > > > > (574) > > > > [done] > > > > [ 18.465552] BTRFS info (device dm-2): using free space > tree > > > > [ 18.465629] BTRFS info (device dm-2): has skinny exten= ts > > > > [ 18.471002] BTRFS info (device dm-2): flagging fs with > big metadata feature > > > > Starting crond: [ 18.482371] BTRFS info (device dm-2): > enabling ssd optimizations > > > > [ 18.486659] BTRFS info (device dm-2): checking UUID tr= ee > > > > OK > > > > starting rsyslogd ... Log partition ready after 0 poll > loops > > > > done > > > > rsyslogd: cannot connect to 172.18.0.1:514 < > http://172.18.0.1:514>: Network is unreachable [v8.2208.0 try > https://www.rsyslog.com/e/2027 ] > > > > [ 18.670637] BTRFS: device fsid > 39d7d9e1-967d-478e-94ae-690deb722095 devid 1 transid 608 /dev/dm-3 scanne= d > by udevd (518) > > > > > > > > Please insert USB token and enter your role in login > prompt. > > > > > > > > login: > > > > > > > > Regards, > > > > O. > > > > > > > > > > > > =D0=BF=D0=BD, 24 =D0=B0=D0=BF=D1=80. 2023=E2=80=AF=D0=B3.= =D0=B2 23:39, Stefano Stabellini < > sstabellini@kernel.org >: > > > > Hi Oleg, > > > > > > > > Here is the issue from your logs: > > > > > > > > SError Interrupt on CPU0, code 0xbe000000 -- SError > > > > > > > > SErrors are special signals to notify software of > serious hardware > > > > errors. Something is going very wrong. Defective > hardware is a > > > > possibility. Another possibility if software > accessing address ranges > > > > that it is not supposed to, sometimes it causes > SErrors. > > > > > > > > Cheers, > > > > > > > > Stefano > > > > > > > > > > > > > > > > On Mon, 24 Apr 2023, Oleg Nikitenko wrote: > > > > > > > > > Hello, > > > > > > > > > > Thanks guys. > > > > > I found out where the problem was. > > > > > Now dom0 booted more. But I have a new one. > > > > > This is a kernel panic during Dom0 loading. > > > > > Maybe someone is able to suggest something ? > > > > > > > > > > Regards, > > > > > O. > > > > > > > > > > [ 3.771362] sfp_register_bus: upstream ops > attach > > > > > [ 3.776119] sfp_register_bus: Bus registered > > > > > [ 3.780459] sfp_register_socket: register > sfp_bus succeeded > > > > > [ 3.789399] of_cfs_init > > > > > [ 3.789499] of_cfs_init: OK > > > > > [ 3.791685] clk: Not disabling unused clocks > > > > > [ 11.010355] SError Interrupt on CPU0, code > 0xbe000000 -- SError > > > > > [ 11.010380] CPU: 0 PID: 9 Comm: kworker/u4:0 > Not tainted 5.15.72-xilinx-v2022.1 #1 > > > > > [ 11.010393] Workqueue: events_unbound > async_run_entry_fn > > > > > [ 11.010414] pstate: 60000005 (nZCv daif -PAN > -UAO -TCO -DIT -SSBS BTYPE=3D--) > > > > > [ 11.010422] pc : simple_write_end+0xd0/0x130 > > > > > [ 11.010431] lr : > generic_perform_write+0x118/0x1e0 > > > > > [ 11.010438] sp : ffffffc00809b910 > > > > > [ 11.010441] x29: ffffffc00809b910 x28: > 0000000000000000 x27: ffffffef69ba88c0 > > > > > [ 11.010451] x26: 0000000000003eec x25: > ffffff807515db00 x24: 0000000000000000 > > > > > [ 11.010459] x23: ffffffc00809ba90 x22: > 0000000002aac000 x21: ffffff807315a260 > > > > > [ 11.010472] x20: 0000000000001000 x19: > fffffffe02000000 x18: 0000000000000000 > > > > > [ 11.010481] x17: 00000000ffffffff x16: > 0000000000008000 x15: 0000000000000000 > > > > > [ 11.010490] x14: 0000000000000000 x13: > 0000000000000000 x12: 0000000000000000 > > > > > [ 11.010498] x11: 0000000000000000 x10: > 0000000000000000 x9 : 0000000000000000 > > > > > [ 11.010507] x8 : 0000000000000000 x7 : > ffffffef693ba680 x6 : 000000002d89b700 > > > > > [ 11.010515] x5 : fffffffe02000000 x4 : > ffffff807315a3c8 x3 : 0000000000001000 > > > > > [ 11.010524] x2 : 0000000002aab000 x1 : > 0000000000000001 x0 : 0000000000000005 > > > > > [ 11.010534] Kernel panic - not syncing: > Asynchronous SError Interrupt > > > > > [ 11.010539] CPU: 0 PID: 9 Comm: kworker/u4:0 > Not tainted 5.15.72-xilinx-v2022.1 #1 > > > > > [ 11.010545] Hardware name: D14 Viper Board - > White Unit (DT) > > > > > [ 11.010548] Workqueue: events_unbound > async_run_entry_fn > > > > > [ 11.010556] Call trace: > > > > > [ 11.010558] dump_backtrace+0x0/0x1c4 > > > > > [ 11.010567] show_stack+0x18/0x2c > > > > > [ 11.010574] dump_stack_lvl+0x7c/0xa0 > > > > > [ 11.010583] dump_stack+0x18/0x34 > > > > > [ 11.010588] panic+0x14c/0x2f8 > > > > > [ 11.010597] print_tainted+0x0/0xb0 > > > > > [ 11.010606] arm64_serror_panic+0x6c/0x7c > > > > > [ 11.010614] do_serror+0x28/0x60 > > > > > [ 11.010621] el1h_64_error_handler+0x30/0x50 > > > > > [ 11.010628] el1h_64_error+0x78/0x7c > > > > > [ 11.010633] simple_write_end+0xd0/0x130 > > > > > [ 11.010639] generic_perform_write+0x118/0x1e0 > > > > > [ 11.010644] > __generic_file_write_iter+0x138/0x1c4 > > > > > [ 11.010650] generic_file_write_iter+0x78/0xd0 > > > > > [ 11.010656] __kernel_write+0xfc/0x2ac > > > > > [ 11.010665] kernel_write+0x88/0x160 > > > > > [ 11.010673] xwrite+0x44/0x94 > > > > > [ 11.010680] do_copy+0xa8/0x104 > > > > > [ 11.010686] write_buffer+0x38/0x58 > > > > > [ 11.010692] flush_buffer+0x4c/0xbc > > > > > [ 11.010698] __gunzip+0x280/0x310 > > > > > [ 11.010704] gunzip+0x1c/0x28 > > > > > [ 11.010709] unpack_to_rootfs+0x170/0x2b0 > > > > > [ 11.010715] do_populate_rootfs+0x80/0x164 > > > > > [ 11.010722] async_run_entry_fn+0x48/0x164 > > > > > [ 11.010728] process_one_work+0x1e4/0x3a0 > > > > > [ 11.010736] worker_thread+0x7c/0x4c0 > > > > > [ 11.010743] kthread+0x120/0x130 > > > > > [ 11.010750] ret_from_fork+0x10/0x20 > > > > > [ 11.010757] SMP: stopping secondary CPUs > > > > > [ 11.010784] Kernel Offset: 0x2f61200000 from > 0xffffffc008000000 > > > > > [ 11.010788] PHYS_OFFSET: 0x0 > > > > > [ 11.010790] CPU features: 0x00000401,00000842 > > > > > [ 11.010795] Memory Limit: none > > > > > [ 11.277509] ---[ end Kernel panic - not > syncing: Asynchronous SError Interrupt ]--- > > > > > > > > > > =D0=BF=D1=82, 21 =D0=B0=D0=BF=D1=80. 2023=E2=80= =AF=D0=B3. =D0=B2 15:52, Michal Orzel < > michal.orzel@amd.com >: > > > > > Hi Oleg, > > > > > > > > > > On 21/04/2023 14:49, Oleg Nikitenko wrote: > > > > > > > > > > > > > > > > > > > > > > > > Hello Michal, > > > > > > > > > > > > I was not able to enable earlyprintk in > the xen for now. > > > > > > I decided to choose another way. > > > > > > This is a xen's command line that I found > out completely. > > > > > > > > > > > > (XEN) $$$$ console=3Ddtuart dtuart=3Dseri= al0 > dom0_mem=3D1600M dom0_max_vcpus=3D2 dom0_vcpus_pin bootscrub=3D0 > > > vwfi=3Dnative > > > > sched=3Dnull > > > > > timer_slop=3D0 > > > > > Yes, adding a printk() in Xen was also a > good idea. > > > > > > > > > > > > > > > > > So you are absolutely right about a > command line. > > > > > > Now I am going to find out why xen did no= t > have the correct parameters from the device tree. > > > > > Maybe you will find this document helpful: > > > > > > https://github.com/Xilinx/xen/blob/xlnx_rebase_4.16/docs/misc/arm/device-= tree/booting.txt > < > https://github.com/Xilinx/xen/blob/xlnx_rebase_4.16/docs/misc/arm/device-= tree/booting.txt > > > > > > > > > > > > ~Michal > > > > > > > > > > > > > > > > > Regards, > > > > > > Oleg > > > > > > > > > > > > =D0=BF=D1=82, 21 =D0=B0=D0=BF=D1=80. 2023= =E2=80=AF=D0=B3. =D0=B2 11:16, Michal Orzel < > michal.orzel@amd.com michal.orzel@amd.com >>: > > > > > > > > > > > > > > > > > > On 21/04/2023 10:04, Oleg Nikitenko > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > Hello Michal, > > > > > > > > > > > > > > Yes, I use yocto. > > > > > > > > > > > > > > Yesterday all day long I tried to > follow your suggestions. > > > > > > > I faced a problem. > > > > > > > Manually in the xen config build > file I pasted the strings: > > > > > > In the .config file or in some Yocto > file (listing additional Kconfig options) added to SRC_URI? > > > > > > You shouldn't really modify .config > file but if you do, you should execute "make olddefconfig" > > > afterwards. > > > > > > > > > > > > > > > > > > > > CONFIG_EARLY_PRINTK > > > > > > > CONFIG_EARLY_PRINTK_ZYNQMP > > > > > > > CONFIG_EARLY_UART_CHOICE_CADENCE > > > > > > I hope you added =3Dy to them. > > > > > > > > > > > > Anyway, you have at least the > following solutions: > > > > > > 1) Run bitbake xen -c menuconfig to > properly set early printk > > > > > > 2) Find out how you enable other > Kconfig options in your project (e.g. CONFIG_COLORING=3Dy that is not > > > enabled by > > > > default) > > > > > > 3) Append the following to > "xen/arch/arm/configs/arm64_defconfig": > > > > > > CONFIG_EARLY_PRINTK_ZYNQMP=3Dy > > > > > > > > > > > > ~Michal > > > > > > > > > > > > > > > > > > > > Host hangs in build time. > > > > > > > Maybe I did not set something in th= e > config build file ? > > > > > > > > > > > > > > Regards, > > > > > > > Oleg > > > > > > > > > > > > > > =D1=87=D1=82, 20 =D0=B0=D0=BF=D1=80= . 2023=E2=80=AF=D0=B3. =D0=B2 11:57, Oleg > Nikitenko oleshiiwood@gmail.com > > > > > > oleshiiwood@gmail.com> oleshiiwood@gmail.com>>>>: > > > > > > > > > > > > > > Thanks Michal, > > > > > > > > > > > > > > You gave me an idea. > > > > > > > I am going to try it today. > > > > > > > > > > > > > > Regards, > > > > > > > O. > > > > > > > > > > > > > > =D1=87=D1=82, 20 =D0=B0=D0=BF= =D1=80. 2023=E2=80=AF=D0=B3. =D0=B2 11:56, > Oleg Nikitenko > > > > > > > oleshiiwood@gmail.com> oleshiiwood@gmail.com>>>>: > > > > > > > > > > > > > > Thanks Stefano. > > > > > > > > > > > > > > I am going to do it today. > > > > > > > > > > > > > > Regards, > > > > > > > O. > > > > > > > > > > > > > > =D1=81=D1=80, 19 =D0=B0=D0= =BF=D1=80. 2023=E2=80=AF=D0=B3. =D0=B2 23:05, > Stefano Stabellini > > > sstabellini@kernel.org>> > > > > > sstabellini@kernel.org> sstabellini@kernel.org>>>>: > > > > > > > > > > > > > > On Wed, 19 Apr 2023, > Oleg Nikitenko wrote: > > > > > > > > Hi Michal, > > > > > > > > > > > > > > > > I corrected xen's > command line. > > > > > > > > Now it is > > > > > > > > xen,xen-bootargs =3D > "console=3Ddtuart dtuart=3Dserial0 dom0_mem=3D1600M dom0_max_vcpus=3D2 > > > dom0_vcpus_pin > > > > > bootscrub=3D0 vwfi=3Dnative sched=3Dnull > > > > > > > > timer_slop=3D0 > way_size=3D65536 xen_colors=3D0-3 dom0_colors=3D4-7"; > > > > > > > > > > > > > > 4 colors is way too man= y > for xen, just do xen_colors=3D0-0. There is no > > > > > > > advantage in using more > than 1 color for Xen. > > > > > > > > > > > > > > 4 colors is too few for > dom0, if you are giving 1600M of memory to Dom0. > > > > > > > Each color is 256M. For > 1600M you should give at least 7 colors. Try: > > > > > > > > > > > > > > xen_colors=3D0-0 > dom0_colors=3D1-8 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Unfortunately the > result was the same. > > > > > > > > > > > > > > > > (XEN) - Dom0 mode: > Relaxed > > > > > > > > (XEN) P2M: 40-bit IPA > with 40-bit PA and 8-bit VMID > > > > > > > > (XEN) P2M: 3 levels > with order-1 root, VTCR 0x0000000080023558 > > > > > > > > (XEN) Scheduling > granularity: cpu, 1 CPU per sched-resource > > > > > > > > (XEN) Coloring genera= l > information > > > > > > > > (XEN) Way size: 64kB > > > > > > > > (XEN) Max. number of > colors available: 16 > > > > > > > > (XEN) Xen color(s): [ > 0 ] > > > > > > > > (XEN) alternatives: > Patching with alt table 00000000002cc690 -> 00000000002ccc0c > > > > > > > > (XEN) Color array > allocation failed for dom0 > > > > > > > > (XEN) > > > > > > > > (XEN) > **************************************** > > > > > > > > (XEN) Panic on CPU 0: > > > > > > > > (XEN) Error creating > domain 0 > > > > > > > > (XEN) > **************************************** > > > > > > > > (XEN) > > > > > > > > (XEN) Reboot in five > seconds... > > > > > > > > > > > > > > > > I am going to find ou= t > how command line arguments passed and parsed. > > > > > > > > > > > > > > > > Regards, > > > > > > > > Oleg > > > > > > > > > > > > > > > > =D1=81=D1=80, 19 =D0= =B0=D0=BF=D1=80. 2023=E2=80=AF=D0=B3. =D0=B2 > 11:25, Oleg Nikitenko > > > > >> > > > > > oleshiiwood@gmail.com> oleshiiwood@gmail.com>>>>: > > > > > > > > Hi Michal, > > > > > > > > > > > > > > > > You put my nose into > the problem. Thank you. > > > > > > > > I am going to use you= r > point. > > > > > > > > Let's see what happen= s. > > > > > > > > > > > > > > > > Regards, > > > > > > > > Oleg > > > > > > > > > > > > > > > > > > > > > > > > =D1=81=D1=80, 19 =D0= =B0=D0=BF=D1=80. 2023=E2=80=AF=D0=B3. =D0=B2 > 10:37, Michal Orzel > > > > > > > > > michal.orzel@amd.com> michal.orzel@amd.com>>>>: > > > > > > > > Hi Oleg, > > > > > > > > > > > > > > > > On 19/04/2023 > 09:03, Oleg Nikitenko wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Hello Stefano= , > > > > > > > > > > > > > > > > > > Thanks for th= e > clarification. > > > > > > > > > My company > uses yocto for image generation. > > > > > > > > > What kind of > information do you need to consult me in this case ? > > > > > > > > > > > > > > > > > > Maybe modules > sizes/addresses which were mentioned by @Julien Grall > > > > > > > > > julien@xen.org>> julien@xen.org >>> ? > > > > > > > > > > > > > > > > Sorry for > jumping into discussion, but FWICS the Xen command line you provided > > > seems to be > > > > not the > > > > > one > > > > > > > > Xen booted with= . > The error you are observing most likely is due to dom0 colors > > > > configuration not > > > > > being > > > > > > > > specified (i.e. > lack of dom0_colors=3D<> parameter). Although in the command line you > > > > provided, this > > > > > parameter > > > > > > > > is set, I > strongly doubt that this is the actual command line in use. > > > > > > > > > > > > > > > > You wrote: > > > > > > > > xen,xen-bootarg= s > =3D "console=3Ddtuart dtuart=3Dserial0 dom0_mem=3D1600M dom0_max_vcpus=3D= 2 > > > > dom0_vcpus_pin > > > > > bootscrub=3D0 vwfi=3Dnative > > > > > > > > sched=3Dnull > timer_slop=3D0 way_szize=3D65536 xen_colors=3D0-3 dom0_colors=3D4-7"; > > > > > > > > > > > > > > > > but: > > > > > > > > 1) way_szize ha= s > a typo > > > > > > > > 2) you specifie= d > 4 colors (0-3) for Xen, but the boot log says that Xen has only > > > one: > > > > > > > > (XEN) Xen > color(s): [ 0 ] > > > > > > > > > > > > > > > > This makes me > believe that no colors configuration actually end up in command line > > > that Xen > > > > booted > > > > > with. > > > > > > > > Single color fo= r > Xen is a "default if not specified" and way size was probably > > > calculated > > > > by asking > > > > > HW. > > > > > > > > > > > > > > > > So I would > suggest to first cross-check the command line in use. > > > > > > > > > > > > > > > > ~Michal > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Regards, > > > > > > > > > Oleg > > > > > > > > > > > > > > > > > > =D0=B2=D1=82,= 18 =D0=B0=D0=BF=D1=80. > 2023=E2=80=AF=D0=B3. =D0=B2 20:44, Stefano Stabellini sstabellini@kernel.org> > > > > > sstabellini@kernel.org>> sstabellini@kernel.org> sstabellini@kernel.org>>> > > > > sstabellini@kernel.org> > > > > > sstabellini@kernel.org>> sstabellini@kernel.org> sstabellini@kernel.org>>>>>: > > > > > > > > > > > > > > > > > > On Tue, 1= 8 > Apr 2023, Oleg Nikitenko wrote: > > > > > > > > > > Hi > Julien, > > > > > > > > > > > > > > > > > > > > >> This > feature has not been merged in Xen upstream yet > > > > > > > > > > > > > > > > > > > > > would > assume that upstream + the series on the ML [1] work > > > > > > > > > > > > > > > > > > > > Please > clarify this point. > > > > > > > > > > Because > the two thoughts are controversial. > > > > > > > > > > > > > > > > > > Hi Oleg, > > > > > > > > > > > > > > > > > > As Julien > wrote, there is nothing controversial. As you are aware, > > > > > > > > > Xilinx > maintains a separate Xen tree specific for Xilinx here: > > > > > > > > > > https://github.com/xilinx/xen < > https://github.com/xilinx/xen > > > > > https://github.com/xilinx/xen> > > > > > https://github.com/xilinx/xen>>> https://github.com/xilinx/xen> https://github.com/xilinx/xen>> > > > > https://github.com/xilinx/xen> > > > > > https://github.com/xilinx/xen>>>> > > > > > > > > > > > > > > > > > > and the > branch you are using (xlnx_rebase_4.16) comes from there. > > > > > > > > > > > > > > > > > > > > > > > > > > > Instead, > the upstream Xen tree lives here: > > > > > > > > > > https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary < > https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary> > > > > > < > https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary < > https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary>> < > https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary < > https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary> > > > > > < > https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary < > https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary>>> < > https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary < > https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary> > > > > > < > https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary < > https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary>> < > https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary < > https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary> > > > > > < > https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary < > https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary>>>> > > > > > > > > > > > > > > > > > > > > > > > > > > > The Cache > Coloring feature that you are trying to configure is present > > > > > > > > > in > xlnx_rebase_4.16, but not yet present upstream (there is an > > > > > > > > > > outstanding patch series to add cache coloring to Xen upstream but it > > > > > > > > > hasn't > been merged yet.) > > > > > > > > > > > > > > > > > > > > > > > > > > > Anyway, i= f > you are using xlnx_rebase_4.16 it doesn't matter too much for > > > > > > > > > you as yo= u > already have Cache Coloring as a feature there. > > > > > > > > > > > > > > > > > > > > > > > > > > > I take yo= u > are using ImageBuilder to generate the boot configuration? If > > > > > > > > > so, pleas= e > post the ImageBuilder config file that you are using. > > > > > > > > > > > > > > > > > > But from > the boot message, it looks like the colors configuration for > > > > > > > > > Dom0 is > incorrect. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --000000000000175b6a05faee4a1e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: base64 PGRpdiBkaXI9Imx0ciI+PGRpdj5IaSBNaWNoYWwsPC9kaXY+PGRpdj48YnI+PC9kaXY+PGRpdj5U aGFua3MuPC9kaXY+PGRpdj48L2Rpdj48ZGl2Pjxicj48L2Rpdj48ZGl2PlJlZ2FyZHMsPC9kaXY+ PGRpdj5PbGVnPGJyPjwvZGl2PjwvZGl2Pjxicj48ZGl2IGNsYXNzPSJnbWFpbF9xdW90ZSI+PGRp diBkaXI9Imx0ciIgY2xhc3M9ImdtYWlsX2F0dHIiPtC/0YIsIDUg0LzQsNGPIDIwMjPigK/Qsy4g 0LIgMTE6MzQsIE1pY2hhbCBPcnplbCAmbHQ7PGEgaHJlZj0ibWFpbHRvOm1pY2hhbC5vcnplbEBh bWQuY29tIj5taWNoYWwub3J6ZWxAYW1kLmNvbTwvYT4mZ3Q7Ojxicj48L2Rpdj48YmxvY2txdW90 ZSBjbGFzcz0iZ21haWxfcXVvdGUiIHN0eWxlPSJtYXJnaW46MHB4IDBweCAwcHggMC44ZXg7Ym9y ZGVyLWxlZnQ6MXB4IHNvbGlkIHJnYigyMDQsMjA0LDIwNCk7cGFkZGluZy1sZWZ0OjFleCI+SGkg T2xlZyw8YnI+DQo8YnI+DQpSZXBseWluZywgc28gdGhhdCB5b3UgZG8gbm90IG5lZWQgdG8gd2Fp dCBmb3IgU3RlZmFuby48YnI+DQo8YnI+DQpPbiAwNS8wNS8yMDIzIDEwOjI4LCBPbGVnIE5pa2l0 ZW5rbyB3cm90ZTo8YnI+DQomZ3Q7wqAgwqAgwqAgwqA8YnI+DQomZ3Q7IDxicj4NCiZndDsgPGJy Pg0KJmd0OyBIZWxsbyBTdGVmYW5vLDxicj4NCiZndDsgPGJyPg0KJmd0OyBJIHdvdWxkIGxpa2Ug dG8gdHJ5IGEgeGVuIGNhY2hlIGNvbG9yIHByb3BlcnR5IGZyb20gdGhpcyByZXBvwqAgPGEgaHJl Zj0iaHR0cHM6Ly94ZW5iaXRzLnhlbi5vcmcvZ2l0LWh0dHAveGVuLmdpdCIgcmVsPSJub3JlZmVy cmVyIiB0YXJnZXQ9Il9ibGFuayI+aHR0cHM6Ly94ZW5iaXRzLnhlbi5vcmcvZ2l0LWh0dHAveGVu LmdpdDwvYT4gJmx0OzxhIGhyZWY9Imh0dHBzOi8veGVuYml0cy54ZW4ub3JnL2dpdC1odHRwL3hl bi5naXQiIHJlbD0ibm9yZWZlcnJlciIgdGFyZ2V0PSJfYmxhbmsiPmh0dHBzOi8veGVuYml0cy54 ZW4ub3JnL2dpdC1odHRwL3hlbi5naXQ8L2E+Jmd0Ozxicj4NCiZndDsgQ291bGQgeW91IHRlbGwg d2hvdCBicmFuY2ggSSBzaG91bGQgdXNlID88YnI+DQpDYWNoZSBjb2xvcmluZyBmZWF0dXJlIGlz IG5vdCBwYXJ0IG9mIHRoZSB1cHN0cmVhbSB0cmVlIGFuZCBpdCBpcyBzdGlsbCB1bmRlciByZXZp ZXcuPGJyPg0KWW91IGNhbiBvbmx5IGZpbmQgaXQgaW50ZWdyYXRlZCBpbiB0aGUgWGlsaW54IFhl biB0cmVlLjxicj4NCjxicj4NCn5NaWNoYWw8YnI+DQo8YnI+DQomZ3Q7IDxicj4NCiZndDsgUmVn YXJkcyw8YnI+DQomZ3Q7IE9sZWc8YnI+DQomZ3Q7IDxicj4NCiZndDsg0L/RgiwgMjgg0LDQv9GA LiAyMDIz4oCv0LMuINCyIDAwOjUxLCBTdGVmYW5vIFN0YWJlbGxpbmkgJmx0OzxhIGhyZWY9Im1h aWx0bzpzc3RhYmVsbGluaUBrZXJuZWwub3JnIiB0YXJnZXQ9Il9ibGFuayI+c3N0YWJlbGxpbmlA a2VybmVsLm9yZzwvYT4gJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86c3N0YWJlbGxpbmlAa2Vy bmVsLm9yZyIgdGFyZ2V0PSJfYmxhbmsiPnNzdGFiZWxsaW5pQGtlcm5lbC5vcmc8L2E+Jmd0OyZn dDs6PGJyPg0KJmd0OyA8YnI+DQomZ3Q7wqAgwqAgwqBJIGFtIGZhbWlsaWFyIHdpdGggdGhlIHpj dTEwMiBidXQgSSBkb24mIzM5O3Qga25vdyBob3cgeW91IGNvdWxkIHBvc3NpYmx5PGJyPg0KJmd0 O8KgIMKgIMKgZ2VuZXJhdGUgYSBTRXJyb3IuPGJyPg0KJmd0OyA8YnI+DQomZ3Q7wqAgwqAgwqBJ IHN1Z2dlc3QgdG8gdHJ5IHRvIHVzZSBJbWFnZUJ1aWxkZXIgWzFdIHRvIGdlbmVyYXRlIHRoZSBi b290PGJyPg0KJmd0O8KgIMKgIMKgY29uZmlndXJhdGlvbiBhcyBhIHRlc3QgYmVjYXVzZSB0aGF0 IGlzIGtub3duIHRvIHdvcmsgd2VsbCBmb3IgemN1MTAyLjxicj4NCiZndDsgPGJyPg0KJmd0O8Kg IMKgIMKgWzFdIDxhIGhyZWY9Imh0dHBzOi8vZ2l0bGFiLmNvbS94ZW4tcHJvamVjdC9pbWFnZWJ1 aWxkZXIiIHJlbD0ibm9yZWZlcnJlciIgdGFyZ2V0PSJfYmxhbmsiPmh0dHBzOi8vZ2l0bGFiLmNv bS94ZW4tcHJvamVjdC9pbWFnZWJ1aWxkZXI8L2E+ICZsdDs8YSBocmVmPSJodHRwczovL2dpdGxh Yi5jb20veGVuLXByb2plY3QvaW1hZ2VidWlsZGVyIiByZWw9Im5vcmVmZXJyZXIiIHRhcmdldD0i X2JsYW5rIj5odHRwczovL2dpdGxhYi5jb20veGVuLXByb2plY3QvaW1hZ2VidWlsZGVyPC9hPiZn dDs8YnI+DQomZ3Q7IDxicj4NCiZndDsgPGJyPg0KJmd0O8KgIMKgIMKgT24gVGh1LCAyNyBBcHIg MjAyMywgT2xlZyBOaWtpdGVua28gd3JvdGU6PGJyPg0KJmd0O8KgIMKgIMKgJmd0OyBIZWxsbyBT dGVmYW5vLDxicj4NCiZndDvCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7IFRoYW5r cyBmb3IgY2xhcmlmaWNhdGlvbi48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7IFdlIG5pZ2h0ZXIgdXNl IEltYWdlQnVpbGRlciBub3IgdWJvb3QgYm9vdCBzY3JpcHQuPGJyPg0KJmd0O8KgIMKgIMKgJmd0 OyBBIG1vZGVsIGlzIHpjdTEwMiBjb21wYXRpYmxlLjxicj4NCiZndDvCoCDCoCDCoCZndDs8YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7IFJlZ2FyZHMsPGJyPg0KJmd0O8KgIMKgIMKgJmd0OyBPLjxicj4N CiZndDvCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7INCy0YIsIDI1INCw0L/RgC4g MjAyM+KAr9CzLiDQsiAyMToyMSwgU3RlZmFubyBTdGFiZWxsaW5pICZsdDs8YSBocmVmPSJtYWls dG86c3N0YWJlbGxpbmlAa2VybmVsLm9yZyIgdGFyZ2V0PSJfYmxhbmsiPnNzdGFiZWxsaW5pQGtl cm5lbC5vcmc8L2E+ICZsdDttYWlsdG86PGEgaHJlZj0ibWFpbHRvOnNzdGFiZWxsaW5pQGtlcm5l bC5vcmciIHRhcmdldD0iX2JsYW5rIj5zc3RhYmVsbGluaUBrZXJuZWwub3JnPC9hPiZndDsmZ3Q7 Ojxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoFRoaXMgaXMgaW50ZXJlc3RpbmcuIEFy ZSB5b3UgdXNpbmcgWGlsaW54IGhhcmR3YXJlIGJ5IGFueSBjaGFuY2U/IElmIHNvLDxicj4NCiZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoHdoaWNoIGJvYXJkPzxicj4NCiZndDvCoCDCoCDCoCZn dDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBBcmUgeW91IHVzaW5nIEltYWdlQnVp bGRlciB0byBnZW5lcmF0ZSB5b3VyIGJvb3Quc2NyIGJvb3Qgc2NyaXB0PyBJZiBzbyw8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBjb3VsZCB5b3UgcGxlYXNlIHBvc3QgeW91ciBJbWFn ZUJ1aWxkZXIgY29uZmlnIGZpbGU/IElmIG5vdCwgY2FuIHlvdTxicj4NCiZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoHBvc3QgdGhlIHNvdXJjZSBvZiB5b3VyIHVib290IGJvb3Qgc2NyaXB0Pzxi cj4NCiZndDvCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBTRXJy b3JzIGFyZSBzdXBwb3NlZCB0byBiZSByZWxhdGVkIHRvIGEgaGFyZHdhcmUgZmFpbHVyZSBvZiBz b21lIGtpbmQuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgWW91IGFyZSBub3Qgc3Vw cG9zZWQgdG8gYmUgYWJsZSB0byB0cmlnZ2VyIGFuIFNFcnJvciBlYXNpbHkgYnk8YnI+DQomZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmcXVvdDttaXN0YWtlJnF1b3Q7LiBJIGhhdmUgbm90IHNl ZW4gU0Vycm9ycyBkdWUgdG8gd3JvbmcgY2FjaGUgY29sb3Jpbmc8YnI+DQomZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqBjb25maWd1cmF0aW9ucyBvbiBhbnkgWGlsaW54IGJvYXJkIGJlZm9yZS48 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgVGhl IGRpZmZlcmVuY2VzIGJldHdlZW4gWGVuIHdpdGggYW5kIHdpdGhvdXQgY2FjaGUgY29sb3Jpbmcg ZnJvbSBhPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgaGFyZHdhcmUgcGVyc3BlY3Rp dmUgYXJlOjxicj4NCiZndDvCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAtIFdpdGggY2FjaGUgY29sb3JpbmcsIHRoZSBTTU1VIGlzIGVuYWJsZWQgYW5kIGRvZXMg YWRkcmVzcyB0cmFuc2xhdGlvbnM8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqDCoCBl dmVuIGZvciBkb20wLiBXaXRob3V0IGNhY2hlIGNvbG9yaW5nIHRoZSBTTU1VIGNvdWxkIGJlIGRp c2FibGVkLCBhbmQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqDCoCBpZiBlbmFibGVk LCB0aGUgU01NVSBkb2VzbiYjMzk7dCBkbyBhbnkgYWRkcmVzcyB0cmFuc2xhdGlvbnMgZm9yIERv bTAuIElmPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgwqAgdGhlcmUgaXMgYSBoYXJk d2FyZSBmYWlsdXJlIHJlbGF0ZWQgdG8gU01NVSBhZGRyZXNzIHRyYW5zbGF0aW9uIGl0PGJyPg0K Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgwqAgY291bGQgb25seSB0cmlnZ2VyIHdpdGggY2Fj aGUgY29sb3JpbmcuIFRoaXMgd291bGQgYmUgbXkgbm9ybWFsPGJyPg0KJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgwqAgc3VnZ2VzdGlvbiBmb3IgeW91IHRvIGV4cGxvcmUsIGJ1dCB0aGUgZmFp bHVyZSBoYXBwZW5zIHRvbyBlYXJseTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoMKg IGJlZm9yZSBhbnkgRE1BLWNhcGFibGUgZGV2aWNlIGlzIHByb2dyYW1tZWQuIFNvIEkgZG9uJiMz OTt0IHRoaW5rIHRoaXMgY2FuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgwqAgYmUg dGhlIGlzc3VlLjxicj4NCiZndDvCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAtIFdpdGggY2FjaGUgY29sb3JpbmcsIHRoZSBtZW1vcnkgYWxsb2NhdGlvbiBpcyB2 ZXJ5IGRpZmZlcmVudCBzbyB5b3UmIzM5O2xsPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgwqAgZW5kIHVwIHVzaW5nIGRpZmZlcmVudCBERFIgcmVnaW9ucyBmb3IgRG9tMC4gU28gaWYg eW91ciBERFIgaXM8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqDCoCBkZWZlY3RpdmUs IHlvdSBtaWdodCBvbmx5IHNlZSBhIGZhaWx1cmUgd2l0aCBjYWNoZSBjb2xvcmluZyBlbmFibGVk PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgwqAgYmVjYXVzZSB5b3UgZW5kIHVwIHVz aW5nIGRpZmZlcmVudCByZWdpb25zLjxicj4NCiZndDvCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAg wqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgT24gVHVlLCAyNSBBcHIg MjAyMywgT2xlZyBOaWtpdGVua28gd3JvdGU6PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyBIaSBTdGVmYW5vLDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFRoYW5rIHlvdS48YnI+DQomZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IElmIEkgYnVpbGQgeGVuIHdpdGhvdXQgY29sb3Jz IHN1cHBvcnQgdGhlcmUgaXMgbm90IHRoaXMgZXJyb3IuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0OyBBbGwgdGhlIGRvbWFpbnMgYXJlIGJvb3RlZCB3ZWxsLjxicj4NCiZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgSGVuc2UgaXQgY2FuIG5vdCBiZSBhIGhhcmR3YXJl IGlzc3VlLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgVGhpcyBwYW5pYyBh cnJpdmVkIGR1cmluZyB1bnBhY2tpbmcgdGhlIHJvb3Rmcy48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IEhlcmUgSSBhdHRhY2hlZCB0aGUgYm9vdCBsb2cgeGVuL0RvbTAgd2l0 aG91dCBjb2xvci48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IEEgaGlnaGxp Z2h0ZWQgc3RyaW5ncyBwcmludGVkIGV4YWN0bHkgYWZ0ZXIgdGhlIHBsYWNlIHdoZXJlIDEtc3Qg dGltZSBwYW5pYyBhcnJpdmVkLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgWGVuIDQuMTYuMS1wcmU8YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIFhlbiB2ZXJzaW9uIDQuMTYu MS1wcmUgKG5vbGUyMzkwQChub25lKSkgKGFhcmNoNjQtcG9ydGFibGUtbGludXgtZ2NjIChHQ0Mp IDExLjMuMCkgZGVidWc9eSAyMDIzLTA0LTIxPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyAoWEVOKSBMYXRlc3QgQ2hhbmdlU2V0OiBXZWQgQXByIDE5IDEyOjU2OjE0IDIwMjMg KzAzMDAgZ2l0OjMyMTY4N2IyMzEtZGlydHk8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7IChYRU4pIGJ1aWxkLWlkOiBjMTg0NzI1OGZkYjFiNzk1NjJmYzcxMGRkYTQwMDA4Zjk2 YzBmZGU1PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBQcm9jZXNz b3I6IDAwMDAwMDAwNDEwZmQwMzQ6ICZxdW90O0FSTSBMaW1pdGVkJnF1b3Q7LCB2YXJpYW50OiAw eDAsIHBhcnQgMHhkMDMscmV2IDB4NDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgKFhFTikgNjQtYml0IEV4ZWN1dGlvbjo8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7IChYRU4pIMKgIFByb2Nlc3NvciBGZWF0dXJlczogMDAwMDAwMDAwMDAwMjIyMiAwMDAw MDAwMDAwMDAwMDAwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSDC oCDCoCBFeGNlcHRpb24gTGV2ZWxzOiBFTDM6NjQrMzIgRUwyOjY0KzMyIEVMMTo2NCszMiBFTDA6 NjQrMzI8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIMKgIMKgIEV4 dGVuc2lvbnM6IEZsb2F0aW5nUG9pbnQgQWR2YW5jZWRTSU1EPGJyPg0KJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSDCoCBEZWJ1ZyBGZWF0dXJlczogMDAwMDAwMDAxMDMwNTEw NiAwMDAwMDAwMDAwMDAwMDAwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAo WEVOKSDCoCBBdXhpbGlhcnkgRmVhdHVyZXM6IDAwMDAwMDAwMDAwMDAwMDAgMDAwMDAwMDAwMDAw MDAwMDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgwqAgTWVtb3J5 IE1vZGVsIEZlYXR1cmVzOiAwMDAwMDAwMDAwMDAxMTIyIDAwMDAwMDAwMDAwMDAwMDA8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIMKgIElTQSBGZWF0dXJlczogwqAw MDAwMDAwMDAwMDExMTIwIDAwMDAwMDAwMDAwMDAwMDA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7IChYRU4pIDMyLWJpdCBFeGVjdXRpb246PGJyPg0KJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSDCoCBQcm9jZXNzb3IgRmVhdHVyZXM6IDAwMDAwMDAwMDAw MDAxMzE6MDAwMDAwMDAwMDAxMTAxMTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgKFhFTikgwqAgwqAgSW5zdHJ1Y3Rpb24gU2V0czogQUFyY2gzMiBBMzIgVGh1bWIgVGh1bWIt MiBKYXplbGxlPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSDCoCDC oCBFeHRlbnNpb25zOiBHZW5lcmljVGltZXIgU2VjdXJpdHk8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIMKgIERlYnVnIEZlYXR1cmVzOiAwMDAwMDAwMDAzMDEwMDY2 PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSDCoCBBdXhpbGlhcnkg RmVhdHVyZXM6IDAwMDAwMDAwMDAwMDAwMDA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7IChYRU4pIMKgIE1lbW9yeSBNb2RlbCBGZWF0dXJlczogMDAwMDAwMDAxMDIwMTEwNSAw MDAwMDAwMDQwMDAwMDAwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVO KSDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoDAwMDAwMDAwMDEyNjAwMDAg MDAwMDAwMDAwMjEwMjIxMTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhF TikgwqAgSVNBIEZlYXR1cmVzOiAwMDAwMDAwMDAyMTAxMTEwIDAwMDAwMDAwMTMxMTIxMTEgMDAw MDAwMDAyMTIzMjA0Mjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgMDAwMDAwMDAwMTExMjEzMSAwMDAwMDAwMDAwMDExMTQy IDAwMDAwMDAwMDAwMTExMjE8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChY RU4pIFVzaW5nIFNNQyBDYWxsaW5nIENvbnZlbnRpb24gdjEuMjxicj4NCiZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDsgKFhFTikgVXNpbmcgUFNDSSB2MS4xPGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBTTVA6IEFsbG93aW5nIDQgQ1BVczxicj4NCiZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgR2VuZXJpYyBUaW1lciBJUlE6IHBoeXM9 MzAgaHlwPTI2IHZpcnQ9MjcgRnJlcTogMTAwMDAwIEtIejxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgKFhFTikgR0lDdjIgaW5pdGlhbGl6YXRpb246PGJyPg0KJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSDCoCDCoCDCoCDCoCBnaWNfZGlzdF9hZGRyPTAw MDAwMDAwZjkwMTAwMDA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4p IMKgIMKgIMKgIMKgIGdpY19jcHVfYWRkcj0wMDAwMDAwMGY5MDIwMDAwPGJyPg0KJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSDCoCDCoCDCoCDCoCBnaWNfaHlwX2FkZHI9MDAw MDAwMDBmOTA0MDAwMDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikg wqAgwqAgwqAgwqAgZ2ljX3ZjcHVfYWRkcj0wMDAwMDAwMGY5MDYwMDAwPGJyPg0KJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSDCoCDCoCDCoCDCoCBnaWNfbWFpbnRlbmFuY2Vf aXJxPTI1PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBHSUN2Mjog QWRqdXN0aW5nIENQVSBpbnRlcmZhY2UgYmFzZSB0byAweGY5MDJmMDAwPGJyPg0KJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBHSUN2MjogMTkyIGxpbmVzLCA0IGNwdXMsIHNl Y3VyZSAoSUlEIDAyMDAxNDNiKS48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IChYRU4pIFVzaW5nIHNjaGVkdWxlcjogbnVsbCBTY2hlZHVsZXIgKG51bGwpPGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBJbml0aWFsaXppbmcgbnVsbCBzY2hlZHVs ZXI8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIFdBUk5JTkc6IFRo aXMgaXMgZXhwZXJpbWVudGFsIHNvZnR3YXJlIGluIGRldmVsb3BtZW50Ljxicj4NCiZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgVXNlIGF0IHlvdXIgb3duIHJpc2suPGJyPg0K Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBBbGxvY2F0ZWQgY29uc29sZSBy aW5nIG9mIDMyIEtpQi48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4p IENQVTA6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTIgdGltZXMgYmVmb3JlIHBhdXNpbmcgdGhl IGRvbWFpbjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgQnJpbmdp bmcgdXAgQ1BVMTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgQ1BV MTogR3Vlc3QgYXRvbWljcyB3aWxsIHRyeSAxMyB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9t YWluPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBDUFUgMSBib290 ZWQuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBCcmluZ2luZyB1 cCBDUFUyPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBDUFUyOiBH dWVzdCBhdG9taWNzIHdpbGwgdHJ5IDEzIHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW48 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIENQVSAyIGJvb3RlZC48 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIEJyaW5naW5nIHVwIENQ VTM8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIENQVTM6IEd1ZXN0 IGF0b21pY3Mgd2lsbCB0cnkgMTMgdGltZXMgYmVmb3JlIHBhdXNpbmcgdGhlIGRvbWFpbjxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgQnJvdWdodCB1cCA0IENQVXM8 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIENQVSAzIGJvb3RlZC48 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIHNtbXU6IC9heGkvc21t dUBmZDgwMDAwMDogcHJvYmluZyBoYXJkd2FyZSBjb25maWd1cmF0aW9uLi4uPGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBzbW11OiAvYXhpL3NtbXVAZmQ4MDAwMDA6 IFNNTVV2MiB3aXRoOjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikg c21tdTogL2F4aS9zbW11QGZkODAwMDAwOiBzdGFnZSAyIHRyYW5zbGF0aW9uPGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBzbW11OiAvYXhpL3NtbXVAZmQ4MDAwMDA6 IHN0cmVhbSBtYXRjaGluZyB3aXRoIDQ4IHJlZ2lzdGVyIGdyb3VwcywgbWFzayAweDdmZmYmbHQ7 MiZndDtzbW11OiAvYXhpL3NtbXVAZmQ4MDAwMDA6IDE2IGNvbnRleHQ8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqBiYW5rcyAoMDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgc3RhZ2UtMiBvbmx5KTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg KFhFTikgc21tdTogL2F4aS9zbW11QGZkODAwMDAwOiBTdGFnZS0yOiA0OC1iaXQgSVBBIC0mZ3Q7 IDQ4LWJpdCBQQTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgc21t dTogL2F4aS9zbW11QGZkODAwMDAwOiByZWdpc3RlcmVkIDI5IG1hc3RlciBkZXZpY2VzPGJyPg0K Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBJL08gdmlydHVhbGlzYXRpb24g ZW5hYmxlZDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgwqAtIERv bTAgbW9kZTogUmVsYXhlZDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhF TikgUDJNOiA0MC1iaXQgSVBBIHdpdGggNDAtYml0IFBBIGFuZCA4LWJpdCBWTUlEPGJyPg0KJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBQMk06IDMgbGV2ZWxzIHdpdGggb3Jk ZXItMSByb290LCBWVENSIDB4MDAwMDAwMDA4MDAyMzU1ODxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgKFhFTikgU2NoZWR1bGluZyBncmFudWxhcml0eTogY3B1LCAxIENQVSBw ZXIgc2NoZWQtcmVzb3VyY2U8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChY RU4pIGFsdGVybmF0aXZlczogUGF0Y2hpbmcgd2l0aCBhbHQgdGFibGUgMDAwMDAwMDAwMDJjYzVj OCAtJmd0OyAwMDAwMDAwMDAwMmNjYjJjPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0OyAoWEVOKSAqKiogTE9BRElORyBET01BSU4gMCAqKio8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIExvYWRpbmcgZDAga2VybmVsIGZyb20gYm9vdCBtb2R1bGUg QCAwMDAwMDAwMDAxMDAwMDAwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAo WEVOKSBMb2FkaW5nIHJhbWRpc2sgZnJvbSBib290IG1vZHVsZSBAIDAwMDAwMDAwMDIwMDAwMDA8 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIEFsbG9jYXRpbmcgMTox IG1hcHBpbmdzIHRvdGFsbGluZyAxNjAwTUIgZm9yIGRvbTA6PGJyPg0KJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBCQU5LWzBdIDB4MDAwMDAwMTAwMDAwMDAtMHgwMDAwMDAy MDAwMDAwMCAoMjU2TUIpPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVO KSBCQU5LWzFdIDB4MDAwMDAwMjQwMDAwMDAtMHgwMDAwMDAyODAwMDAwMCAoNjRNQik8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIEJBTktbMl0gMHgwMDAwMDAzMDAw MDAwMC0weDAwMDAwMDgwMDAwMDAwICgxMjgwTUIpPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyAoWEVOKSBHcmFudCB0YWJsZSByYW5nZTogMHgwMDAwMDAwMGUwMDAwMC0weDAw MDAwMDAwZTQwMDAwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBz bW11OiAvYXhpL3NtbXVAZmQ4MDAwMDA6IGQwOiBwMm1hZGRyIDB4MDAwMDAwMDg3YmY5NDAwMDxi cj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgQWxsb2NhdGluZyBQUEkg MTYgZm9yIGV2ZW50IGNoYW5uZWwgaW50ZXJydXB0PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyAoWEVOKSBFeHRlbmRlZCByZWdpb24gMDogMHg4MTIwMDAwMC0mZ3Q7MHhhMDAw MDAwMDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgRXh0ZW5kZWQg cmVnaW9uIDE6IDB4YjEyMDAwMDAtJmd0OzB4YzAwMDAwMDA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIEV4dGVuZGVkIHJlZ2lvbiAyOiAweGM4MDAwMDAwLSZndDsw eGUwMDAwMDAwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBFeHRl bmRlZCByZWdpb24gMzogMHhmMDAwMDAwMC0mZ3Q7MHhmOTAwMDAwMDxicj4NCiZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgRXh0ZW5kZWQgcmVnaW9uIDQ6IDB4MTAwMDAwMDAw LSZndDsweDYwMDAwMDAwMDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhF TikgRXh0ZW5kZWQgcmVnaW9uIDU6IDB4ODgwMDAwMDAwLSZndDsweDgwMDAwMDAwMDA8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIEV4dGVuZGVkIHJlZ2lvbiA2OiAw eDgwMDEwMDAwMDAtJmd0OzB4MTAwMDAwMDAwMDA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7IChYRU4pIExvYWRpbmcgekltYWdlIGZyb20gMDAwMDAwMDAwMTAwMDAwMCB0byAw MDAwMDAwMDEwMDAwMDAwLTAwMDAwMDAwMTBlNDEwMDg8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7IChYRU4pIExvYWRpbmcgZDAgaW5pdHJkIGZyb20gMDAwMDAwMDAwMjAwMDAw MCB0byAweDAwMDAwMDAwMTM2MDAwMDAtMHgwMDAwMDAwMDFmZjNhNjE3PGJyPg0KJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBMb2FkaW5nIGQwIERUQiB0byAweDAwMDAwMDAw MTM0MDAwMDAtMHgwMDAwMDAwMDEzNDBjYmRjPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyAoWEVOKSBJbml0aWFsIGxvdyBtZW1vcnkgdmlycSB0aHJlc2hvbGQgc2V0IGF0IDB4 NDAwMCBwYWdlcy48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIFN0 ZC4gTG9nbGV2ZWw6IEFsbDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhF TikgR3Vlc3QgTG9nbGV2ZWw6IEFsbDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgKFhFTikgKioqIFNlcmlhbCBpbnB1dCB0byBET00wICh0eXBlICYjMzk7Q1RSTC1hJiMzOTsg dGhyZWUgdGltZXMgdG8gc3dpdGNoIGlucHV0KTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDsgKFhFTikgbnVsbC5jOjM1MzogMCAmbHQ7LS0gZDB2MDxicj4NCiZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgRnJlZWQgMzU2a0IgaW5pdCBtZW1vcnkuPGJyPg0K Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBkMHYwIFVuaGFuZGxlZCBTTUMv SFZDOiAweDg0MDAwMDUwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVO KSBkMHYwIFVuaGFuZGxlZCBTTUMvSFZDOiAweDg2MDBmZjAxPGJyPg0KJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBkMHYwOiB2R0lDRDogdW5oYW5kbGVkIHdvcmQgd3JpdGUg MHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVI0PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyAoWEVOKSBkMHYwOiB2R0lDRDogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAw MDBmZmZmZmZmZiB0byBJQ0FDVElWRVI4PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0OyAoWEVOKSBkMHYwOiB2R0lDRDogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZm ZmZmZiB0byBJQ0FDVElWRVIxMjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg KFhFTikgZDB2MDogdkdJQ0Q6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYg dG8gSUNBQ1RJVkVSMTY8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4p IGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElD QUNUSVZFUjIwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBkMHYw OiB2R0lDRDogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElW RVIwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBd IEJvb3RpbmcgTGludXggb24gcGh5c2ljYWwgQ1BVIDB4MDAwMDAwMDAwMCBbMHg0MTBmZDAzNF08 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjAwMDAwMF0gTGlu dXggdmVyc2lvbiA1LjE1LjcyLXhpbGlueC12MjAyMi4xIChvZS11c2VyQG9lLWhvc3QpIChhYXJj aDY0LXBvcnRhYmxlLWxpbnV4LWdjYyAoR0NDKSAxMS4zLjAsIEdOVSBsZCAoR05VPGJyPg0KJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgQmludXRpbHMpPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0OyAyLjM4LjIwMjIwNzA4KSAjMSBTTVAgVHVlIEZlYiAyMSAwNTo0Nzo1NCBV VEMgMjAyMzxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMDAw MDAwXSBNYWNoaW5lIG1vZGVsOiBEMTQgVmlwZXIgQm9hcmQgLSBXaGl0ZSBVbml0PGJyPg0KJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBdIFhlbiA0LjE2IHN1 cHBvcnQgZm91bmQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAw LjAwMDAwMF0gWm9uZSByYW5nZXM6PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 OyBbIMKgIMKgMC4wMDAwMDBdIMKgIERNQSDCoCDCoCDCoFttZW0gMHgwMDAwMDAwMDEwMDAwMDAw LTB4MDAwMDAwMDA3ZmZmZmZmZl08YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IFsgwqAgwqAwLjAwMDAwMF0gwqAgRE1BMzIgwqAgwqBlbXB0eTxicj4NCiZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMDAwMDAwXSDCoCBOb3JtYWwgwqAgZW1wdHk8YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjAwMDAwMF0gTW92YWJs ZSB6b25lIHN0YXJ0IGZvciBlYWNoIG5vZGU8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7IFsgwqAgwqAwLjAwMDAwMF0gRWFybHkgbWVtb3J5IG5vZGUgcmFuZ2VzPGJyPg0KJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBdIMKgIG5vZGUgwqAg MDogW21lbSAweDAwMDAwMDAwMTAwMDAwMDAtMHgwMDAwMDAwMDFmZmZmZmZmXTxicj4NCiZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMDAwMDAwXSDCoCBub2RlIMKgIDA6 IFttZW0gMHgwMDAwMDAwMDIyMDAwMDAwLTB4MDAwMDAwMDAyMjE0N2ZmZl08YnI+DQomZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjAwMDAwMF0gwqAgbm9kZSDCoCAwOiBb bWVtIDB4MDAwMDAwMDAyMjIwMDAwMC0weDAwMDAwMDAwMjIzNDdmZmZdPGJyPg0KJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBdIMKgIG5vZGUgwqAgMDogW21l bSAweDAwMDAwMDAwMjQwMDAwMDAtMHgwMDAwMDAwMDI3ZmZmZmZmXTxicj4NCiZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMDAwMDAwXSDCoCBub2RlIMKgIDA6IFttZW0g MHgwMDAwMDAwMDMwMDAwMDAwLTB4MDAwMDAwMDA3ZmZmZmZmZl08YnI+DQomZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjAwMDAwMF0gSW5pdG1lbSBzZXR1cCBub2RlIDAg W21lbSAweDAwMDAwMDAwMTAwMDAwMDAtMHgwMDAwMDAwMDdmZmZmZmZmXTxicj4NCiZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMDAwMDAwXSBPbiBub2RlIDAsIHpvbmUg RE1BOiA4MTkyIHBhZ2VzIGluIHVuYXZhaWxhYmxlIHJhbmdlczxicj4NCiZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMDAwMDAwXSBPbiBub2RlIDAsIHpvbmUgRE1BOiAx ODQgcGFnZXMgaW4gdW5hdmFpbGFibGUgcmFuZ2VzPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBdIE9uIG5vZGUgMCwgem9uZSBETUE6IDczNTIgcGFn ZXMgaW4gdW5hdmFpbGFibGUgcmFuZ2VzPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0OyBbIMKgIMKgMC4wMDAwMDBdIGNtYTogUmVzZXJ2ZWQgMjU2IE1pQiBhdCAweDAwMDAwMDAw NmUwMDAwMDA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjAw MDAwMF0gcHNjaTogcHJvYmluZyBmb3IgY29uZHVpdCBtZXRob2QgZnJvbSBEVC48YnI+DQomZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjAwMDAwMF0gcHNjaTogUFNDSXYx LjEgZGV0ZWN0ZWQgaW4gZmlybXdhcmUuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0OyBbIMKgIMKgMC4wMDAwMDBdIHBzY2k6IFVzaW5nIHN0YW5kYXJkIFBTQ0kgdjAuMiBmdW5j dGlvbiBJRHM8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjAw MDAwMF0gcHNjaTogVHJ1c3RlZCBPUyBtaWdyYXRpb24gbm90IHJlcXVpcmVkPGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBdIHBzY2k6IFNNQyBDYWxs aW5nIENvbnZlbnRpb24gdjEuMTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg WyDCoCDCoDAuMDAwMDAwXSBwZXJjcHU6IEVtYmVkZGVkIDE2IHBhZ2VzL2NwdSBzMzI3OTIgcjAg ZDMyNzQ0IHU2NTUzNjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDC oDAuMDAwMDAwXSBEZXRlY3RlZCBWSVBUIEktY2FjaGUgb24gQ1BVMDxicj4NCiZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMDAwMDAwXSBDUFUgZmVhdHVyZXM6IGtlcm5l bCBwYWdlIHRhYmxlIGlzb2xhdGlvbiBmb3JjZWQgT04gYnkgS0FTTFI8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjAwMDAwMF0gQ1BVIGZlYXR1cmVzOiBkZXRl Y3RlZDogS2VybmVsIHBhZ2UgdGFibGUgaXNvbGF0aW9uIChLUFRJKTxicj4NCiZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMDAwMDAwXSBCdWlsdCAxIHpvbmVsaXN0cywg bW9iaWxpdHkgZ3JvdXBpbmcgb24uwqAgVG90YWwgcGFnZXM6IDQwMzg0NTxicj4NCiZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMDAwMDAwXSBLZXJuZWwgY29tbWFuZCBs aW5lOiBjb25zb2xlPWh2YzAgZWFybHljb249eGVuIGVhcmx5cHJpbnRrPXhlbiBjbGtfaWdub3Jl X3VudXNlZCBmaXBzPTEgcm9vdD0vZGV2L3JhbTA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqBtYXhjcHVzPTI8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAg wqAwLjAwMDAwMF0gVW5rbm93biBrZXJuZWwgY29tbWFuZCBsaW5lIHBhcmFtZXRlcnMgJnF1b3Q7 ZWFybHlwcmludGs9eGVuIGZpcHM9MSZxdW90Oywgd2lsbCBiZSBwYXNzZWQgdG8gdXNlciBzcGFj ZS48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjAwMDAwMF0g RGVudHJ5IGNhY2hlIGhhc2ggdGFibGUgZW50cmllczogMjYyMTQ0IChvcmRlcjogOSwgMjA5NzE1 MiBieXRlcywgbGluZWFyKTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDC oCDCoDAuMDAwMDAwXSBJbm9kZS1jYWNoZSBoYXNoIHRhYmxlIGVudHJpZXM6IDEzMTA3MiAob3Jk ZXI6IDgsIDEwNDg1NzYgYnl0ZXMsIGxpbmVhcik8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7IFsgwqAgwqAwLjAwMDAwMF0gbWVtIGF1dG8taW5pdDogc3RhY2s6b2ZmLCBoZWFw IGFsbG9jOm9uLCBoZWFwIGZyZWU6b248YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IFsgwqAgwqAwLjAwMDAwMF0gbWVtIGF1dG8taW5pdDogY2xlYXJpbmcgc3lzdGVtIG1lbW9y eSBtYXkgdGFrZSBzb21lIHRpbWUuLi48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IFsgwqAgwqAwLjAwMDAwMF0gTWVtb3J5OiAxMTIxOTM2Sy8xNjQxMDI0SyBhdmFpbGFibGUg KDk3MjhLIGtlcm5lbCBjb2RlLCA4MzZLIHJ3ZGF0YSwgMjM5Nksgcm9kYXRhLCAxNTM2SyBpbml0 LCAyNjJLIGJzcyw8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAyNTY5NDRLIHJlc2Vy dmVkLDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgMjYyMTQ0SyBjbWEtcmVz ZXJ2ZWQpPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAw MDBdIFNMVUI6IEhXYWxpZ249NjQsIE9yZGVyPTAtMywgTWluT2JqZWN0cz0wLCBDUFVzPTIsIE5v ZGVzPTE8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjAwMDAw MF0gcmN1OiBIaWVyYXJjaGljYWwgUkNVIGltcGxlbWVudGF0aW9uLjxicj4NCiZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMDAwMDAwXSByY3U6IFJDVSBldmVudCB0cmFj aW5nIGlzIGVuYWJsZWQuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKg IMKgMC4wMDAwMDBdIHJjdTogUkNVIHJlc3RyaWN0aW5nIENQVXMgZnJvbSBOUl9DUFVTPTggdG8g bnJfY3B1X2lkcz0yLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDC oDAuMDAwMDAwXSByY3U6IFJDVSBjYWxjdWxhdGVkIHZhbHVlIG9mIHNjaGVkdWxlci1lbmxpc3Rt ZW50IGRlbGF5IGlzIDI1IGppZmZpZXMuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0OyBbIMKgIMKgMC4wMDAwMDBdIHJjdTogQWRqdXN0aW5nIGdlb21ldHJ5IGZvciByY3VfZmFu b3V0X2xlYWY9MTYsIG5yX2NwdV9pZHM9Mjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgWyDCoCDCoDAuMDAwMDAwXSBOUl9JUlFTOiA2NCwgbnJfaXJxczogNjQsIHByZWFsbG9j YXRlZCBpcnFzOiAwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKg MC4wMDAwMDBdIFJvb3QgSVJRIGhhbmRsZXI6IGdpY19oYW5kbGVfaXJxPGJyPg0KJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBdIGFyY2hfdGltZXI6IGNwMTUg dGltZXIocykgcnVubmluZyBhdCAxMDAuMDBNSHogKHZpcnQpLjxicj4NCiZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMDAwMDAwXSBjbG9ja3NvdXJjZTogYXJjaF9zeXNf Y291bnRlcjogbWFzazogMHhmZmZmZmZmZmZmZmZmZiBtYXhfY3ljbGVzOiAweDE3MTAyNGU3ZTAs IG1heF9pZGxlX25zOiA0NDA3OTUyMDUzMTUgbnM8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7IFsgwqAgwqAwLjAwMDAwMF0gc2NoZWRfY2xvY2s6IDU2IGJpdHMgYXQgMTAwTUh6 LCByZXNvbHV0aW9uIDEwbnMsIHdyYXBzIGV2ZXJ5IDQzOTgwNDY1MTExMDBuczxicj4NCiZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMDAwMjU4XSBDb25zb2xlOiBjb2xv dXIgZHVtbXkgZGV2aWNlIDgweDI1PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 OyBbIMKgIMKgMC4zMTAyMzFdIHByaW50azogY29uc29sZSBbaHZjMF0gZW5hYmxlZDxicj4NCiZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMzE0NDAzXSBDYWxpYnJhdGlu ZyBkZWxheSBsb29wIChza2lwcGVkKSwgdmFsdWUgY2FsY3VsYXRlZCB1c2luZyB0aW1lciBmcmVx dWVuY3kuLiAyMDAuMDAgQm9nb01JUFMgKGxwaj00MDAwMDApPGJyPg0KJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4zMjQ4NTFdIHBpZF9tYXg6IGRlZmF1bHQ6IDMyNzY4 IG1pbmltdW06IDMwMTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDC oDAuMzI5NzA2XSBMU006IFNlY3VyaXR5IEZyYW1ld29yayBpbml0aWFsaXppbmc8YnI+DQomZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjMzNDIwNF0gWWFtYTogYmVjb21p bmcgbWluZGZ1bC48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAw LjMzNzg2NV0gTW91bnQtY2FjaGUgaGFzaCB0YWJsZSBlbnRyaWVzOiA0MDk2IChvcmRlcjogMywg MzI3NjggYnl0ZXMsIGxpbmVhcik8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IFsgwqAgwqAwLjM0NTE4MF0gTW91bnRwb2ludC1jYWNoZSBoYXNoIHRhYmxlIGVudHJpZXM6IDQw OTYgKG9yZGVyOiAzLCAzMjc2OCBieXRlcywgbGluZWFyKTxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMzU0NzQzXSB4ZW46Z3JhbnRfdGFibGU6IEdyYW50IHRh YmxlcyB1c2luZyB2ZXJzaW9uIDEgbGF5b3V0PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyBbIMKgIMKgMC4zNTkxMzJdIEdyYW50IHRhYmxlIGluaXRpYWxpemVkPGJyPg0KJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4zNjI2NjRdIHhlbjpldmVudHM6 IFVzaW5nIEZJRk8tYmFzZWQgQUJJPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 OyBbIMKgIMKgMC4zNjY5OTNdIFhlbjogaW5pdGlhbGl6aW5nIGNwdTA8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjM3MDUxNV0gcmN1OiBIaWVyYXJjaGljYWwg U1JDVSBpbXBsZW1lbnRhdGlvbi48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IFsgwqAgwqAwLjM3NTkzMF0gc21wOiBCcmluZ2luZyB1cCBzZWNvbmRhcnkgQ1BVcyAuLi48YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIG51bGwuYzozNTM6IDEgJmx0 Oy0tIGQwdjE8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIGQwdjE6 IHZHSUNEOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZF UjA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjM4MjU0OV0g RGV0ZWN0ZWQgVklQVCBJLWNhY2hlIG9uIENQVTE8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7IFsgwqAgwqAwLjM4ODcxMl0gWGVuOiBpbml0aWFsaXppbmcgY3B1MTxicj4NCiZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMzg4NzQzXSBDUFUxOiBCb290 ZWQgc2Vjb25kYXJ5IHByb2Nlc3NvciAweDAwMDAwMDAwMDEgWzB4NDEwZmQwMzRdPGJyPg0KJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4zODg4MjldIHNtcDogQnJvdWdo dCB1cCAxIG5vZGUsIDIgQ1BVczxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg WyDCoCDCoDAuNDA2OTQxXSBTTVA6IFRvdGFsIG9mIDIgcHJvY2Vzc29ycyBhY3RpdmF0ZWQuPGJy Pg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC40MTE2OThdIENQVSBm ZWF0dXJlczogZGV0ZWN0ZWQ6IDMyLWJpdCBFTDAgU3VwcG9ydDxicj4NCiZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuNDE2ODg4XSBDUFUgZmVhdHVyZXM6IGRldGVjdGVk OiBDUkMzMiBpbnN0cnVjdGlvbnM8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IFsgwqAgwqAwLjQyMjEyMV0gQ1BVOiBBbGwgQ1BVKHMpIHN0YXJ0ZWQgYXQgRUwxPGJyPg0KJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC40MjYyNDhdIGFsdGVybmF0aXZl czogcGF0Y2hpbmcga2VybmVsIGNvZGU8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IFsgwqAgwqAwLjQzMTQyNF0gZGV2dG1wZnM6IGluaXRpYWxpemVkPGJyPg0KJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC40NDE0NTRdIEtBU0xSIGVuYWJsZWQ8YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjQ0MTYwMl0gY2xvY2tz b3VyY2U6IGppZmZpZXM6IG1hc2s6IDB4ZmZmZmZmZmYgbWF4X2N5Y2xlczogMHhmZmZmZmZmZiwg bWF4X2lkbGVfbnM6IDc2NDUwNDE3ODUxMDAwMDAgbnM8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjQ0ODMyMV0gZnV0ZXggaGFzaCB0YWJsZSBlbnRyaWVzOiA1 MTIgKG9yZGVyOiAzLCAzMjc2OCBieXRlcywgbGluZWFyKTxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuNDk2MTgzXSBORVQ6IFJlZ2lzdGVyZWQgUEZfTkVUTElO Sy9QRl9ST1VURSBwcm90b2NvbCBmYW1pbHk8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7IFsgwqAgwqAwLjQ5ODI3N10gRE1BOiBwcmVhbGxvY2F0ZWQgMjU2IEtpQiBHRlBfS0VS TkVMIHBvb2wgZm9yIGF0b21pYyBhbGxvY2F0aW9uczxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgWyDCoCDCoDAuNTAzNzcyXSBETUE6IHByZWFsbG9jYXRlZCAyNTYgS2lCIEdG UF9LRVJORUx8R0ZQX0RNQSBwb29sIGZvciBhdG9taWMgYWxsb2NhdGlvbnM8YnI+DQomZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjUxMTYxMF0gRE1BOiBwcmVhbGxvY2F0 ZWQgMjU2IEtpQiBHRlBfS0VSTkVMfEdGUF9ETUEzMiBwb29sIGZvciBhdG9taWMgYWxsb2NhdGlv bnM8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjUxOTQ3OF0g YXVkaXQ6IGluaXRpYWxpemluZyBuZXRsaW5rIHN1YnN5cyAoZGlzYWJsZWQpPGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC41MjQ5ODVdIGF1ZGl0OiB0eXBlPTIw MDAgYXVkaXQoMC4zMzY6MSk6IHN0YXRlPWluaXRpYWxpemVkIGF1ZGl0X2VuYWJsZWQ9MCByZXM9 MTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuNTI5MTY5XSB0 aGVybWFsX3N5czogUmVnaXN0ZXJlZCB0aGVybWFsIGdvdmVybm9yICYjMzk7c3RlcF93aXNlJiMz OTs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjUzMzAyM10g aHctYnJlYWtwb2ludDogZm91bmQgNiBicmVha3BvaW50IGFuZCA0IHdhdGNocG9pbnQgcmVnaXN0 ZXJzLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuNTQ1NjA4 XSBBU0lEIGFsbG9jYXRvciBpbml0aWFsaXNlZCB3aXRoIDMyNzY4IGVudHJpZXM8YnI+DQomZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjU1MTAzMF0geGVuOnN3aW90bGJf eGVuOiBXYXJuaW5nOiBvbmx5IGFibGUgdG8gYWxsb2NhdGUgNCBNQiBmb3Igc29mdHdhcmUgSU8g VExCPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC41NTkzMzJd IHNvZnR3YXJlIElPIFRMQjogbWFwcGVkIFttZW0gMHgwMDAwMDAwMDExODAwMDAwLTB4MDAwMDAw MDAxMWMwMDAwMF0gKDRNQik8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsg wqAgwqAwLjU4MzU2NV0gSHVnZVRMQiByZWdpc3RlcmVkIDEuMDAgR2lCIHBhZ2Ugc2l6ZSwgcHJl LWFsbG9jYXRlZCAwIHBhZ2VzPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBb IMKgIMKgMC41ODQ3MjFdIEh1Z2VUTEIgcmVnaXN0ZXJlZCAzMi4wIE1pQiBwYWdlIHNpemUsIHBy ZS1hbGxvY2F0ZWQgMCBwYWdlczxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg WyDCoCDCoDAuNTkxNDc4XSBIdWdlVExCIHJlZ2lzdGVyZWQgMi4wMCBNaUIgcGFnZSBzaXplLCBw cmUtYWxsb2NhdGVkIDAgcGFnZXM8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IFsgwqAgwqAwLjU5ODIyNV0gSHVnZVRMQiByZWdpc3RlcmVkIDY0LjAgS2lCIHBhZ2Ugc2l6ZSwg cHJlLWFsbG9jYXRlZCAwIHBhZ2VzPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 OyBbIMKgIMKgMC42MzY1MjBdIERSQkc6IENvbnRpbnVpbmcgd2l0aG91dCBKaXR0ZXIgUk5HPGJy Pg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC43MzcxODddIHJhaWQ2 OiBuZW9ueDggwqAgZ2VuKCkgwqAyMTQzIE1CL3M8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7IFsgwqAgwqAwLjgwNTI5NF0gcmFpZDY6IG5lb254OCDCoCB4b3IoKSDCoDE1ODkg TUIvczxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuODczNDA2 XSByYWlkNjogbmVvbng0IMKgIGdlbigpIMKgMjE3NyBNQi9zPGJyPg0KJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC45NDE0OTldIHJhaWQ2OiBuZW9ueDQgwqAgeG9yKCkg wqAxNTU2IE1CL3M8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAx LjAwOTYxMl0gcmFpZDY6IG5lb254MiDCoCBnZW4oKSDCoDIwNzIgTUIvczxicj4NCiZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDEuMDc3NzE1XSByYWlkNjogbmVvbngyIMKg IHhvcigpIMKgMTQzMCBNQi9zPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBb IMKgIMKgMS4xNDU4MzRdIHJhaWQ2OiBuZW9ueDEgwqAgZ2VuKCkgwqAxNzY5IE1CL3M8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjIxMzkzNV0gcmFpZDY6IG5l b254MSDCoCB4b3IoKSDCoDEyMTQgTUIvczxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgWyDCoCDCoDEuMjgyMDQ2XSByYWlkNjogaW50NjR4OCDCoGdlbigpIMKgMTM2NiBNQi9z PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMS4zNTAxMzJdIHJh aWQ2OiBpbnQ2NHg4IMKgeG9yKCkgwqAgNzczIE1CL3M8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjQxODI1OV0gcmFpZDY6IGludDY0eDQgwqBnZW4oKSDCoDE2 MDIgTUIvczxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDEuNDg2 MzQ5XSByYWlkNjogaW50NjR4NCDCoHhvcigpIMKgIDg1MSBNQi9zPGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMS41NTQ0NjRdIHJhaWQ2OiBpbnQ2NHgyIMKgZ2Vu KCkgwqAxMzk2IE1CL3M8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAg wqAxLjYyMjU2MV0gcmFpZDY6IGludDY0eDIgwqB4b3IoKSDCoCA3NDQgTUIvczxicj4NCiZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDEuNjkwNjg3XSByYWlkNjogaW50NjR4 MSDCoGdlbigpIMKgMTAzMyBNQi9zPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 OyBbIMKgIMKgMS43NTg3NzBdIHJhaWQ2OiBpbnQ2NHgxIMKgeG9yKCkgwqAgNTE3IE1CL3M8YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjc1ODgwOV0gcmFpZDY6 IHVzaW5nIGFsZ29yaXRobSBuZW9ueDQgZ2VuKCkgMjE3NyBNQi9zPGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMS43NjI5NDFdIHJhaWQ2OiAuLi4uIHhvcigpIDE1 NTYgTUIvcywgcm13IGVuYWJsZWQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IFsgwqAgwqAxLjc2Nzk1N10gcmFpZDY6IHVzaW5nIG5lb24gcmVjb3ZlcnkgYWxnb3JpdGhtPGJy Pg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMS43NzI4MjRdIHhlbjpi YWxsb29uOiBJbml0aWFsaXNpbmcgYmFsbG9vbiBkcml2ZXI8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjc3ODAyMV0gaW9tbXU6IERlZmF1bHQgZG9tYWluIHR5 cGU6IFRyYW5zbGF0ZWQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAg wqAxLjc4MjU4NF0gaW9tbXU6IERNQSBkb21haW4gVExCIGludmFsaWRhdGlvbiBwb2xpY3k6IHN0 cmljdCBtb2RlPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMS43 ODkxNDldIFNDU0kgc3Vic3lzdGVtIGluaXRpYWxpemVkPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0OyBbIMKgIMKgMS43OTI4MjBdIHVzYmNvcmU6IHJlZ2lzdGVyZWQgbmV3IGlu dGVyZmFjZSBkcml2ZXIgdXNiZnM8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IFsgwqAgwqAxLjc5ODI1NF0gdXNiY29yZTogcmVnaXN0ZXJlZCBuZXcgaW50ZXJmYWNlIGRyaXZl ciBodWI8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjgwMzYy Nl0gdXNiY29yZTogcmVnaXN0ZXJlZCBuZXcgZGV2aWNlIGRyaXZlciB1c2I8YnI+DQomZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjgwODc2MV0gcHBzX2NvcmU6IExpbnV4 UFBTIEFQSSB2ZXIuIDEgcmVnaXN0ZXJlZDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgWyDCoCDCoDEuODEzNzE2XSBwcHNfY29yZTogU29mdHdhcmUgdmVyLiA1LjMuNiAtIENv cHlyaWdodCAyMDA1LTIwMDcgUm9kb2xmbyBHaW9tZXR0aSAmbHQ7PGEgaHJlZj0ibWFpbHRvOmdp b21ldHRpQGxpbnV4Lml0IiB0YXJnZXQ9Il9ibGFuayI+Z2lvbWV0dGlAbGludXguaXQ8L2E+ICZs dDttYWlsdG86PGEgaHJlZj0ibWFpbHRvOmdpb21ldHRpQGxpbnV4Lml0IiB0YXJnZXQ9Il9ibGFu ayI+Z2lvbWV0dGlAbGludXguaXQ8L2E+Jmd0OyZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjgyMjkwM10gUFRQIGNsb2NrIHN1cHBvcnQgcmVnaXN0ZXJl ZDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDEuODI2ODkzXSBF REFDIE1DOiBWZXI6IDMuMC4wPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBb IMKgIMKgMS44MzAzNzVdIHp5bnFtcC1pcGktbWJveCBtYWlsYm94QGZmOTkwNDAwOiBSZWdpc3Rl cmVkIFp5bnFNUCBJUEkgbWJveCB3aXRoIFRYL1JYIGNoYW5uZWxzLjxicj4NCiZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDEuODM4ODYzXSB6eW5xbXAtaXBpLW1ib3ggbWFp bGJveEBmZjk5MDYwMDogUmVnaXN0ZXJlZCBaeW5xTVAgSVBJIG1ib3ggd2l0aCBUWC9SWCBjaGFu bmVscy48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjg0NzM1 Nl0genlucW1wLWlwaS1tYm94IG1haWxib3hAZmY5OTA4MDA6IFJlZ2lzdGVyZWQgWnlucU1QIElQ SSBtYm94IHdpdGggVFgvUlggY2hhbm5lbHMuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyBbIMKgIMKgMS44NTU5MDddIEZQR0EgbWFuYWdlciBmcmFtZXdvcms8YnI+DQomZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjg1OTk1Ml0gY2xvY2tzb3VyY2U6 IFN3aXRjaGVkIHRvIGNsb2Nrc291cmNlIGFyY2hfc3lzX2NvdW50ZXI8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjg3MTcxMl0gTkVUOiBSZWdpc3RlcmVkIFBG X0lORVQgcHJvdG9jb2wgZmFtaWx5PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 OyBbIMKgIMKgMS44NzE4MzhdIElQIGlkZW50cyBoYXNoIHRhYmxlIGVudHJpZXM6IDMyNzY4IChv cmRlcjogNiwgMjYyMTQ0IGJ5dGVzLCBsaW5lYXIpPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyBbIMKgIMKgMS44NzkzOTJdIHRjcF9saXN0ZW5fcG9ydGFkZHJfaGFzaCBoYXNo IHRhYmxlIGVudHJpZXM6IDEwMjQgKG9yZGVyOiAyLCAxNjM4NCBieXRlcywgbGluZWFyKTxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDEuODg3MDc4XSBUYWJsZS1w ZXJ0dXJiIGhhc2ggdGFibGUgZW50cmllczogNjU1MzYgKG9yZGVyOiA2LCAyNjIxNDQgYnl0ZXMs IGxpbmVhcik8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjg5 NDg0Nl0gVENQIGVzdGFibGlzaGVkIGhhc2ggdGFibGUgZW50cmllczogMTYzODQgKG9yZGVyOiA1 LCAxMzEwNzIgYnl0ZXMsIGxpbmVhcik8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IFsgwqAgwqAxLjkwMjkwMF0gVENQIGJpbmQgaGFzaCB0YWJsZSBlbnRyaWVzOiAxNjM4NCAo b3JkZXI6IDYsIDI2MjE0NCBieXRlcywgbGluZWFyKTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgWyDCoCDCoDEuOTEwMzUwXSBUQ1A6IEhhc2ggdGFibGVzIGNvbmZpZ3VyZWQg KGVzdGFibGlzaGVkIDE2Mzg0IGJpbmQgMTYzODQpPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyBbIMKgIMKgMS45MTY3NzhdIFVEUCBoYXNoIHRhYmxlIGVudHJpZXM6IDEwMjQg KG9yZGVyOiAzLCAzMjc2OCBieXRlcywgbGluZWFyKTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgWyDCoCDCoDEuOTIzNTA5XSBVRFAtTGl0ZSBoYXNoIHRhYmxlIGVudHJpZXM6 IDEwMjQgKG9yZGVyOiAzLCAzMjc2OCBieXRlcywgbGluZWFyKTxicj4NCiZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDEuOTMwNzU5XSBORVQ6IFJlZ2lzdGVyZWQgUEZfVU5J WC9QRl9MT0NBTCBwcm90b2NvbCBmYW1pbHk8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7IFsgwqAgwqAxLjkzNjgzNF0gUlBDOiBSZWdpc3RlcmVkIG5hbWVkIFVOSVggc29ja2V0 IHRyYW5zcG9ydCBtb2R1bGUuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBb IMKgIMKgMS45NDIzNDJdIFJQQzogUmVnaXN0ZXJlZCB1ZHAgdHJhbnNwb3J0IG1vZHVsZS48YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjk0NzA4OF0gUlBDOiBS ZWdpc3RlcmVkIHRjcCB0cmFuc3BvcnQgbW9kdWxlLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgWyDCoCDCoDEuOTUxODQzXSBSUEM6IFJlZ2lzdGVyZWQgdGNwIE5GU3Y0LjEg YmFja2NoYW5uZWwgdHJhbnNwb3J0IG1vZHVsZS48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7IFsgwqAgwqAxLjk1ODMzNF0gUENJOiBDTFMgMCBieXRlcywgZGVmYXVsdCA2NDxi cj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDEuOTYyNzA5XSBUcnlp bmcgdG8gdW5wYWNrIHJvb3RmcyBpbWFnZSBhcyBpbml0cmFtZnMuLi48YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjk3NzA5MF0gd29ya2luZ3NldDogdGltZXN0 YW1wX2JpdHM9NjIgbWF4X29yZGVyPTE5IGJ1Y2tldF9vcmRlcj0wPGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMS45ODI4NjNdIEluc3RhbGxpbmcga25mc2QgKGNv cHlyaWdodCAoQykgMTk5NiA8YSBocmVmPSJtYWlsdG86b2tpckBtb25hZC5zd2IuZGUiIHRhcmdl dD0iX2JsYW5rIj5va2lyQG1vbmFkLnN3Yi5kZTwvYT4gJmx0O21haWx0bzo8YSBocmVmPSJtYWls dG86b2tpckBtb25hZC5zd2IuZGUiIHRhcmdldD0iX2JsYW5rIj5va2lyQG1vbmFkLnN3Yi5kZTwv YT4mZ3Q7KS48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjAy MTA0NV0gTkVUOiBSZWdpc3RlcmVkIFBGX0FMRyBwcm90b2NvbCBmYW1pbHk8YnI+DQomZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjAyMTEyMl0geG9yOiBtZWFzdXJpbmcg c29mdHdhcmUgY2hlY2tzdW0gc3BlZWQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IFsgwqAgwqAyLjAyOTM0N10gwqAgwqA4cmVncyDCoCDCoCDCoCDCoCDCoCA6IMKgMjM2NiBN Qi9zZWM8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjAzMzA4 MV0gwqAgwqAzMnJlZ3MgwqAgwqAgwqAgwqAgwqA6IMKgMjgwMiBNQi9zZWM8YnI+DQomZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjAzODIyM10gwqAgwqBhcm02NF9uZW9u IMKgIMKgIMKgOiDCoDIzMjAgTUIvc2VjPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0OyBbIMKgIMKgMi4wMzgzODVdIHhvcjogdXNpbmcgZnVuY3Rpb246IDMycmVncyAoMjgwMiBN Qi9zZWMpPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi4wNDM2 MTRdIEJsb2NrIGxheWVyIFNDU0kgZ2VuZXJpYyAoYnNnKSBkcml2ZXIgdmVyc2lvbiAwLjQgbG9h ZGVkIChtYWpvciAyNDcpPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKg IMKgMi4wNTA5NTldIGlvIHNjaGVkdWxlciBtcS1kZWFkbGluZSByZWdpc3RlcmVkPGJyPg0KJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi4wNTU1MjFdIGlvIHNjaGVkdWxl ciBreWJlciByZWdpc3RlcmVkPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBb IMKgIMKgMi4wNjgyMjddIHhlbjp4ZW5fZXZ0Y2huOiBFdmVudC1jaGFubmVsIGRldmljZSBpbnN0 YWxsZWQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjA2OTI4 MV0gU2VyaWFsOiA4MjUwLzE2NTUwIGRyaXZlciwgNCBwb3J0cywgSVJRIHNoYXJpbmcgZGlzYWJs ZWQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjA3NjE5MF0g Y2FjaGVpbmZvOiBVbmFibGUgdG8gZGV0ZWN0IGNhY2hlIGhpZXJhcmNoeSBmb3IgQ1BVIDA8YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjA4NTU0OF0gYnJkOiBt b2R1bGUgbG9hZGVkPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKg Mi4wODkyOTBdIGxvb3A6IG1vZHVsZSBsb2FkZWQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7IFsgwqAgwqAyLjA4OTM0MV0gSW52YWxpZCBtYXhfcXVldWVzICg0KSwgd2lsbCB1 c2UgZGVmYXVsdCBtYXg6IDIuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBb IMKgIMKgMi4wOTQ1NjVdIHR1bjogVW5pdmVyc2FsIFRVTi9UQVAgZGV2aWNlIGRyaXZlciwgMS42 PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi4wOTg2NTVdIHhl bl9uZXRmcm9udDogSW5pdGlhbGlzaW5nIFhlbiB2aXJ0dWFsIGV0aGVybmV0IGRyaXZlcjxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMTA0MTU2XSB1c2Jjb3Jl OiByZWdpc3RlcmVkIG5ldyBpbnRlcmZhY2UgZHJpdmVyIHJ0bDgxNTA8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjEwOTgxM10gdXNiY29yZTogcmVnaXN0ZXJl ZCBuZXcgaW50ZXJmYWNlIGRyaXZlciByODE1Mjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDsgWyDCoCDCoDIuMTE1MzY3XSB1c2Jjb3JlOiByZWdpc3RlcmVkIG5ldyBpbnRlcmZh Y2UgZHJpdmVyIGFzaXg8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAg wqAyLjEyMDc5NF0gdXNiY29yZTogcmVnaXN0ZXJlZCBuZXcgaW50ZXJmYWNlIGRyaXZlciBheDg4 MTc5XzE3OGE8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjEy NjkzNF0gdXNiY29yZTogcmVnaXN0ZXJlZCBuZXcgaW50ZXJmYWNlIGRyaXZlciBjZGNfZXRoZXI8 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjEzMjgxNl0gdXNi Y29yZTogcmVnaXN0ZXJlZCBuZXcgaW50ZXJmYWNlIGRyaXZlciBjZGNfZWVtPGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi4xMzg1MjddIHVzYmNvcmU6IHJlZ2lz dGVyZWQgbmV3IGludGVyZmFjZSBkcml2ZXIgbmV0MTA4MDxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMTQ0MjU2XSB1c2Jjb3JlOiByZWdpc3RlcmVkIG5ldyBp bnRlcmZhY2UgZHJpdmVyIGNkY19zdWJzZXQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7IFsgwqAgwqAyLjE1MDIwNV0gdXNiY29yZTogcmVnaXN0ZXJlZCBuZXcgaW50ZXJmYWNl IGRyaXZlciB6YXVydXM8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAg wqAyLjE1NTgzN10gdXNiY29yZTogcmVnaXN0ZXJlZCBuZXcgaW50ZXJmYWNlIGRyaXZlciBjZGNf bmNtPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi4xNjE1NTBd IHVzYmNvcmU6IHJlZ2lzdGVyZWQgbmV3IGludGVyZmFjZSBkcml2ZXIgcjgxNTNfZWNtPGJyPg0K Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi4xNjgyNDBdIHVzYmNvcmU6 IHJlZ2lzdGVyZWQgbmV3IGludGVyZmFjZSBkcml2ZXIgY2RjX2FjbTxicj4NCiZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMTczMTA5XSBjZGNfYWNtOiBVU0IgQWJzdHJh Y3QgQ29udHJvbCBNb2RlbCBkcml2ZXIgZm9yIFVTQiBtb2RlbXMgYW5kIElTRE4gYWRhcHRlcnM8 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjE4MTM1OF0gdXNi Y29yZTogcmVnaXN0ZXJlZCBuZXcgaW50ZXJmYWNlIGRyaXZlciB1YXM8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjE4NjU0N10gdXNiY29yZTogcmVnaXN0ZXJl ZCBuZXcgaW50ZXJmYWNlIGRyaXZlciB1c2Itc3RvcmFnZTxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMTkyNjQzXSB1c2Jjb3JlOiByZWdpc3RlcmVkIG5ldyBp bnRlcmZhY2UgZHJpdmVyIGZ0ZGlfc2lvPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0OyBbIMKgIMKgMi4xOTgzODRdIHVzYnNlcmlhbDogVVNCIFNlcmlhbCBzdXBwb3J0IHJlZ2lz dGVyZWQgZm9yIEZUREkgVVNCIFNlcmlhbCBEZXZpY2U8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjIwNjExOF0gdWRjLWNvcmU6IGNvdWxkbiYjMzk7dCBmaW5k IGFuIGF2YWlsYWJsZSBVREMgLSBhZGRlZCBbZ19tYXNzX3N0b3JhZ2VdIHRvIGxpc3Qgb2YgcGVu ZGluZyBkcml2ZXJzPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKg Mi4yMTUzMzJdIGkyY19kZXY6IGkyYyAvZGV2IGVudHJpZXMgZHJpdmVyPGJyPg0KJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi4yMjA0NjddIHhlbl93ZHQgeGVuX3dkdDog aW5pdGlhbGl6ZWQgKHRpbWVvdXQ9NjBzLCBub3dheW91dD0wKTxicj4NCiZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMjI1OTIzXSBkZXZpY2UtbWFwcGVyOiB1ZXZlbnQ6 IHZlcnNpb24gMS4wLjM8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAg wqAyLjIzMDY2OF0gZGV2aWNlLW1hcHBlcjogaW9jdGw6IDQuNDUuMC1pb2N0bCAoMjAyMS0wMy0y MikgaW5pdGlhbGlzZWQ6IDxhIGhyZWY9Im1haWx0bzpkbS1kZXZlbEByZWRoYXQuY29tIiB0YXJn ZXQ9Il9ibGFuayI+ZG0tZGV2ZWxAcmVkaGF0LmNvbTwvYT4gJmx0O21haWx0bzo8YSBocmVmPSJt YWlsdG86ZG0tZGV2ZWxAcmVkaGF0LmNvbSIgdGFyZ2V0PSJfYmxhbmsiPmRtLWRldmVsQHJlZGhh dC5jb208L2E+Jmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDC oDIuMjM5MzE1XSBFREFDIE1DMDogR2l2aW5nIG91dCBkZXZpY2UgdG8gbW9kdWxlIDEgY29udHJv bGxlciBzeW5wc19kZHJfY29udHJvbGxlcjogREVWIHN5bnBzX2VkYWMgKElOVEVSUlVQVCk8YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjI0OTQwNV0gRURBQyBE RVZJQ0UwOiBHaXZpbmcgb3V0IGRldmljZSB0byBtb2R1bGUgenlucW1wLW9jbS1lZGFjIGNvbnRy b2xsZXIgenlucW1wX29jbTogREVWPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgZmY5 NjAwMDAubWVtb3J5LWNvbnRyb2xsZXIgKElOVEVSUlVQVCk8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjI2MTcxOV0gc2RoY2k6IFNlY3VyZSBEaWdpdGFsIEhv c3QgQ29udHJvbGxlciBJbnRlcmZhY2UgZHJpdmVyPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyBbIMKgIMKgMi4yNjc0ODddIHNkaGNpOiBDb3B5cmlnaHQoYykgUGllcnJlIE9z c21hbjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMjcxODkw XSBzZGhjaS1wbHRmbTogU0RIQ0kgcGxhdGZvcm0gYW5kIE9GIGRyaXZlciBoZWxwZXI8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjI3ODE1N10gbGVkdHJpZy1j cHU6IHJlZ2lzdGVyZWQgdG8gaW5kaWNhdGUgYWN0aXZpdHkgb24gQ1BVczxicj4NCiZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMjgzODE2XSB6eW5xbXBfZmlybXdhcmVf cHJvYmUgUGxhdGZvcm0gTWFuYWdlbWVudCBBUEkgdjEuMTxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMjg5NTU0XSB6eW5xbXBfZmlybXdhcmVfcHJvYmUgVHJ1 c3R6b25lIHZlcnNpb24gdjEuMDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg WyDCoCDCoDIuMzI3ODc1XSBzZWN1cmVmdyBzZWN1cmVmdzogc2VjdXJlZncgcHJvYmVkPGJyPg0K Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi4zMjgzMjRdIGFsZzogTm8g dGVzdCBmb3IgeGlsaW54LXp5bnFtcC1hZXMgKHp5bnFtcC1hZXMpPGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi4zMzI1NjNdIHp5bnFtcF9hZXMgZmlybXdhcmU6 enlucW1wLWZpcm13YXJlOnp5bnFtcC1hZXM6IEFFUyBTdWNjZXNzZnVsbHkgUmVnaXN0ZXJlZDxi cj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMzQxMTgzXSBhbGc6 IE5vIHRlc3QgZm9yIHhpbGlueC16eW5xbXAtcnNhICh6eW5xbXAtcnNhKTxicj4NCiZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMzQ3NjY3XSByZW1vdGVwcm9jIHJlbW90 ZXByb2MwOiBmZjlhMDAwMC5yZjVzczpyNWZfMCBpcyBhdmFpbGFibGU8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjM1MzAwM10gcmVtb3RlcHJvYyByZW1vdGVw cm9jMTogZmY5YTAwMDAucmY1c3M6cjVmXzEgaXMgYXZhaWxhYmxlPGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi4zNjI2MDVdIGZwZ2FfbWFuYWdlciBmcGdhMDog WGlsaW54IFp5bnFNUCBGUEdBIE1hbmFnZXIgcmVnaXN0ZXJlZDxicj4NCiZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMzY2NTQwXSB2aXBlci14ZW4tcHJveHkgdmlwZXIt eGVuLXByb3h5OiBWaXBlciBYZW4gUHJveHkgcmVnaXN0ZXJlZDxicj4NCiZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMzcyNTI1XSB2aXBlci12ZHBwIGE0MDAwMDAwLnZk cHA6IERldmljZSBUcmVlIFByb2Jpbmc8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IFsgwqAgwqAyLjM3Nzc3OF0gdmlwZXItdmRwcCBhNDAwMDAwMC52ZHBwOiBWRFBQIFZlcnNp b246IDEuMy45LjAgSW5mbzogMS41MTIuMTUuMCBLZXlMZW46IDMyPGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi4zODY0MzJdIHZpcGVyLXZkcHAgYTQwMDAwMDAu dmRwcDogVW5hYmxlIHRvIHJlZ2lzdGVyIHRhbXBlciBoYW5kbGVyLiBSZXRyeWluZy4uLjxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMzk0MDk0XSB2aXBlci12 ZHBwLW5ldCBhNTAwMDAwMC52ZHBwX25ldDogRGV2aWNlIFRyZWUgUHJvYmluZzxicj4NCiZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMzk5ODU0XSB2aXBlci12ZHBwLW5l dCBhNTAwMDAwMC52ZHBwX25ldDogRGV2aWNlIHJlZ2lzdGVyZWQ8YnI+DQomZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjQwNTkzMV0gdmlwZXItdmRwcC1zdGF0IGE4MDAw MDAwLnZkcHBfc3RhdDogRGV2aWNlIFRyZWUgUHJvYmluZzxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuNDEyMDM3XSB2aXBlci12ZHBwLXN0YXQgYTgwMDAwMDAu dmRwcF9zdGF0OiBCdWlsZCBwYXJhbWV0ZXJzOiBWVEkgQ291bnQ6IDUxMiBFdmVudCBDb3VudDog MzI8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjQyMDg1Nl0g ZGVmYXVsdCBwcmVzZXQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAg wqAyLjQyMzc5N10gdmlwZXItdmRwcC1zdGF0IGE4MDAwMDAwLnZkcHBfc3RhdDogRGV2aWNlIHJl Z2lzdGVyZWQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjQz MDA1NF0gdmlwZXItdmRwcC1ybmcgYWMwMDAwMDAudmRwcF9ybmc6IERldmljZSBUcmVlIFByb2Jp bmc8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjQzNTk0OF0g dmlwZXItdmRwcC1ybmcgYWMwMDAwMDAudmRwcF9ybmc6IERldmljZSByZWdpc3RlcmVkPGJyPg0K Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi40NDE5NzZdIHZtY3UgZHJp dmVyIGluaXQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjQ0 NDkyMl0gVk1DVTogOiAoMjQwOjApIHJlZ2lzdGVyZWQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjQ0NDk1Nl0gSW4gSzgxIFVwZGF0ZXIgaW5pdDxicj4NCiZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuNDQ5MDAzXSBwa3RnZW46IFBh Y2tldCBHZW5lcmF0b3IgZm9yIHBhY2tldCBwZXJmb3JtYW5jZSB0ZXN0aW5nLiBWZXJzaW9uOiAy Ljc1PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi40Njg4MzNd IEluaXRpYWxpemluZyBYRlJNIG5ldGxpbmsgc29ja2V0PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0OyBbIMKgIMKgMi40Njg5MDJdIE5FVDogUmVnaXN0ZXJlZCBQRl9QQUNLRVQg cHJvdG9jb2wgZmFtaWx5PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKg IMKgMi40NzI3MjldIEJyaWRnZSBmaXJld2FsbGluZyByZWdpc3RlcmVkPGJyPg0KJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi40NzY3ODVdIDgwMjFxOiA4MDIuMVEgVkxB TiBTdXBwb3J0IHYxLjg8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAg wqAyLjQ4MTM0MV0gcmVnaXN0ZXJlZCB0YXNrc3RhdHMgdmVyc2lvbiAxPGJyPg0KJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi40ODYzOTRdIEJ0cmZzIGxvYWRlZCwgY3Jj MzJjPWNyYzMyYy1nZW5lcmljLCB6b25lZD1ubywgZnN2ZXJpdHk9bm88YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjUwMzE0NV0gZmYwMTAwMDAuc2VyaWFsOiB0 dHlQUzEgYXQgTU1JTyAweGZmMDEwMDAwIChpcnEgPSAzNiwgYmFzZV9iYXVkID0gNjI1MDAwMCkg aXMgYSB4dWFydHBzPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKg Mi41MDcxMDNdIG9mLWZwZ2EtcmVnaW9uIGZwZ2EtZnVsbDogRlBHQSBSZWdpb24gcHJvYmVkPGJy Pg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi41MTI5ODZdIHhpbGlu eC16eW5xbXAtZG1hIGZkNTAwMDAwLmRtYS1jb250cm9sbGVyOiBaeW5xTVAgRE1BIGRyaXZlciBQ cm9iZSBzdWNjZXNzPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKg Mi41MjAyNjddIHhpbGlueC16eW5xbXAtZG1hIGZkNTEwMDAwLmRtYS1jb250cm9sbGVyOiBaeW5x TVAgRE1BIGRyaXZlciBQcm9iZSBzdWNjZXNzPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyBbIMKgIMKgMi41MjgyMzldIHhpbGlueC16eW5xbXAtZG1hIGZkNTIwMDAwLmRtYS1j b250cm9sbGVyOiBaeW5xTVAgRE1BIGRyaXZlciBQcm9iZSBzdWNjZXNzPGJyPg0KJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi41MzYxNTJdIHhpbGlueC16eW5xbXAtZG1h IGZkNTMwMDAwLmRtYS1jb250cm9sbGVyOiBaeW5xTVAgRE1BIGRyaXZlciBQcm9iZSBzdWNjZXNz PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi41NDQxNTNdIHhp bGlueC16eW5xbXAtZG1hIGZkNTQwMDAwLmRtYS1jb250cm9sbGVyOiBaeW5xTVAgRE1BIGRyaXZl ciBQcm9iZSBzdWNjZXNzPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKg IMKgMi41NTIxMjddIHhpbGlueC16eW5xbXAtZG1hIGZkNTUwMDAwLmRtYS1jb250cm9sbGVyOiBa eW5xTVAgRE1BIGRyaXZlciBQcm9iZSBzdWNjZXNzPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyBbIMKgIMKgMi41NjAxNzhdIHhpbGlueC16eW5xbXAtZG1hIGZmYTgwMDAwLmRt YS1jb250cm9sbGVyOiBaeW5xTVAgRE1BIGRyaXZlciBQcm9iZSBzdWNjZXNzPGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi41Njc5ODddIHhpbGlueC16eW5xbXAt ZG1hIGZmYTkwMDAwLmRtYS1jb250cm9sbGVyOiBaeW5xTVAgRE1BIGRyaXZlciBQcm9iZSBzdWNj ZXNzPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi41NzYwMThd IHhpbGlueC16eW5xbXAtZG1hIGZmYWEwMDAwLmRtYS1jb250cm9sbGVyOiBaeW5xTVAgRE1BIGRy aXZlciBQcm9iZSBzdWNjZXNzPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBb IMKgIMKgMi41ODM4ODldIHhpbGlueC16eW5xbXAtZG1hIGZmYWIwMDAwLmRtYS1jb250cm9sbGVy OiBaeW5xTVAgRE1BIGRyaXZlciBQcm9iZSBzdWNjZXNzPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0OyBbIMKgIMKgMi45NDYzNzldIHNwaS1ub3Igc3BpMC4wOiBtdDI1cXU1MTJh ICgxMzEwNzIgS2J5dGVzKTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDC oCDCoDIuOTQ2NDY3XSAyIGZpeGVkLXBhcnRpdGlvbnMgcGFydGl0aW9ucyBmb3VuZCBvbiBNVEQg ZGV2aWNlIHNwaTAuMDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDC oDIuOTUyMzkzXSBDcmVhdGluZyAyIE1URCBwYXJ0aXRpb25zIG9uICZxdW90O3NwaTAuMCZxdW90 Ozo8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjk1NzIzMV0g MHgwMDAwMDQwMDAwMDAtMHgwMDAwMDgwMDAwMDAgOiAmcXVvdDtiYW5rIEEmcXVvdDs8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjk2MzMzMl0gMHgwMDAwMDAw MDAwMDAtMHgwMDAwMDQwMDAwMDAgOiAmcXVvdDtiYW5rIEImcXVvdDs8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjk2ODY5NF0gbWFjYiBmZjBiMDAwMC5ldGhl cm5ldDogTm90IGVuYWJsaW5nIHBhcnRpYWwgc3RvcmUgYW5kIGZvcndhcmQ8YnI+DQomZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjk3NTMzM10gbWFjYiBmZjBiMDAwMC5l dGhlcm5ldCBldGgwOiBDYWRlbmNlIEdFTSByZXYgMHg1MDA3MDEwNiBhdCAweGZmMGIwMDAwIGly cSAyNSAoMTg6NDE6ZmU6MGY6ZmY6MDIpPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0OyBbIMKgIMKgMi45ODQ0NzJdIG1hY2IgZmYwYzAwMDAuZXRoZXJuZXQ6IE5vdCBlbmFibGlu ZyBwYXJ0aWFsIHN0b3JlIGFuZCBmb3J3YXJkPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyBbIMKgIMKgMi45OTIxNDRdIG1hY2IgZmYwYzAwMDAuZXRoZXJuZXQgZXRoMTogQ2Fk ZW5jZSBHRU0gcmV2IDB4NTAwNzAxMDYgYXQgMHhmZjBjMDAwMCBpcnEgMjYgKDE4OjQxOmZlOjBm OmZmOjAzKTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuMDAx MDQzXSB2aXBlcl9lbmV0IHZpcGVyX2VuZXQ6IFZpcGVyIHBvd2VyIEdQSU9zIGluaXRpYWxpc2Vk PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy4wMDczMTNdIHZp cGVyX2VuZXQgdmlwZXJfZW5ldCB2bmV0MCAodW5pbml0aWFsaXplZCk6IFZhbGlkYXRlIGludGVy ZmFjZSBRU0dNSUk8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAz LjAxNDkxNF0gdmlwZXJfZW5ldCB2aXBlcl9lbmV0IHZuZXQxICh1bmluaXRpYWxpemVkKTogVmFs aWRhdGUgaW50ZXJmYWNlIFFTR01JSTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgWyDCoCDCoDMuMDIyMTM4XSB2aXBlcl9lbmV0IHZpcGVyX2VuZXQgdm5ldDEgKHVuaW5pdGlh bGl6ZWQpOiBWYWxpZGF0ZSBpbnRlcmZhY2UgdHlwZSAxODxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuMDMwMjc0XSB2aXBlcl9lbmV0IHZpcGVyX2VuZXQgdm5l dDIgKHVuaW5pdGlhbGl6ZWQpOiBWYWxpZGF0ZSBpbnRlcmZhY2UgUVNHTUlJPGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy4wMzc3ODVdIHZpcGVyX2VuZXQgdmlw ZXJfZW5ldCB2bmV0MyAodW5pbml0aWFsaXplZCk6IFZhbGlkYXRlIGludGVyZmFjZSBRU0dNSUk8 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjA0NTMwMV0gdmlw ZXJfZW5ldCB2aXBlcl9lbmV0OiBWaXBlciBlbmV0IHJlZ2lzdGVyZWQ8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjA1MDk1OF0geGlsaW54LWF4aXBtb24gZmZh MDAwMDAucGVyZi1tb25pdG9yOiBQcm9iZWQgWGlsaW54IEFQTTxicj4NCiZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuMDU3MTM1XSB4aWxpbngtYXhpcG1vbiBmZDBiMDAw MC5wZXJmLW1vbml0b3I6IFByb2JlZCBYaWxpbnggQVBNPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0OyBbIMKgIMKgMy4wNjM1MzhdIHhpbGlueC1heGlwbW9uIGZkNDkwMDAwLnBl cmYtbW9uaXRvcjogUHJvYmVkIFhpbGlueCBBUE08YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7IFsgwqAgwqAzLjA2OTkyMF0geGlsaW54LWF4aXBtb24gZmZhMTAwMDAucGVyZi1t b25pdG9yOiBQcm9iZWQgWGlsaW54IEFQTTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgWyDCoCDCoDMuMDk3NzI5XSBzaTcweHg6IHByb2JlIG9mIDItMDA0MCBmYWlsZWQgd2l0 aCBlcnJvciAtNTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMu MDk4MDQyXSBjZG5zLXdkdCBmZDRkMDAwMC53YXRjaGRvZzogWGlsaW54IFdhdGNoZG9nIFRpbWVy IHdpdGggdGltZW91dCA2MHM8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsg wqAgwqAzLjEwNTExMV0gY2Rucy13ZHQgZmYxNTAwMDAud2F0Y2hkb2c6IFhpbGlueCBXYXRjaGRv ZyBUaW1lciB3aXRoIHRpbWVvdXQgMTBzPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0OyBbIMKgIMKgMy4xMTI0NTddIHZpcGVyLXRhbXBlciB2aXBlci10YW1wZXI6IERldmljZSBy ZWdpc3RlcmVkPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy4x MTc1OTNdIGFjdGl2ZV9iYW5rIGFjdGl2ZV9iYW5rOiBib290IGJhbms6IDE8YnI+DQomZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjEyMjE4NF0gYWN0aXZlX2JhbmsgYWN0 aXZlX2Jhbms6IGJvb3QgbW9kZTogKDB4MDIpIHFzcGkzMjxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuMTI4MjQ3XSB2aXBlci12ZHBwIGE0MDAwMDAwLnZkcHA6 IERldmljZSBUcmVlIFByb2Jpbmc8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IFsgwqAgwqAzLjEzMzQzOV0gdmlwZXItdmRwcCBhNDAwMDAwMC52ZHBwOiBWRFBQIFZlcnNpb246 IDEuMy45LjAgSW5mbzogMS41MTIuMTUuMCBLZXlMZW46IDMyPGJyPg0KJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy4xNDIxNTFdIHZpcGVyLXZkcHAgYTQwMDAwMDAudmRw cDogVGFtcGVyIGhhbmRsZXIgcmVnaXN0ZXJlZDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDsgWyDCoCDCoDMuMTQ3NDM4XSB2aXBlci12ZHBwIGE0MDAwMDAwLnZkcHA6IERldmlj ZSByZWdpc3RlcmVkPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKg My4xNTMwMDddIGxwYzU1X2wyIHNwaTEuMDogcmVnaXN0ZXJlZCBoYW5kbGVyIGZvciBwcm90b2Nv bCAwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy4xNTg1ODJd IGxwYzU1X3VzZXIgbHBjNTVfdXNlcjogVGhlIG1ham9yIG51bWJlciBmb3IgeW91ciBkZXZpY2Ug aXMgMjM2PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy4xNjU5 NzZdIGxwYzU1X2wyIHNwaTEuMDogcmVnaXN0ZXJlZCBoYW5kbGVyIGZvciBwcm90b2NvbCAxPGJy Pg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy4xODE5OTldIHJ0Yy1s cGM1NSBydGNfbHBjNTU6IGxwYzU1X3J0Y19nZXRfdGltZTogYmFkIHJlc3VsdDogMTxicj4NCiZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuMTgyODU2XSBydGMtbHBjNTUg cnRjX2xwYzU1OiByZWdpc3RlcmVkIGFzIHJ0YzA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7IFsgwqAgwqAzLjE4ODY1Nl0gbHBjNTVfbDIgc3BpMS4wOiAoMikgbWN1IHN0aWxs IG5vdCByZWFkeT88YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAz LjE5Mzc0NF0gbHBjNTVfbDIgc3BpMS4wOiAoMykgbWN1IHN0aWxsIG5vdCByZWFkeT88YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjE5ODg0OF0gbHBjNTVfbDIg c3BpMS4wOiAoNCkgbWN1IHN0aWxsIG5vdCByZWFkeT88YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjIwMjkzMl0gbW1jMDogU0RIQ0kgY29udHJvbGxlciBvbiBm ZjE2MDAwMC5tbWMgW2ZmMTYwMDAwLm1tY10gdXNpbmcgQURNQSA2NC1iaXQ8YnI+DQomZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjIxMDY4OV0gbHBjNTVfbDIgc3BpMS4w OiAoNSkgbWN1IHN0aWxsIG5vdCByZWFkeT88YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7IFsgwqAgwqAzLjIxNTY5NF0gbHBjNTVfbDIgc3BpMS4wOiByeCBlcnJvcjogLTExMDxi cj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuMjg0NDM4XSBtbWMw OiBuZXcgSFMyMDAgTU1DIGNhcmQgYXQgYWRkcmVzcyAwMDAxPGJyPg0KJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy4yODUxNzldIG1tY2JsazA6IG1tYzA6MDAwMSBTRU0x NkcgMTQuNiBHaUI8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAz LjI5MTc4NF0gwqBtbWNibGswOiBwMSBwMiBwMyBwNCBwNSBwNiBwNyBwODxicj4NCiZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuMjkzOTE1XSBtbWNibGswYm9vdDA6IG1t YzA6MDAwMSBTRU0xNkcgNC4wMCBNaUI8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IFsgwqAgwqAzLjI5OTA1NF0gbW1jYmxrMGJvb3QxOiBtbWMwOjAwMDEgU0VNMTZHIDQuMDAg TWlCPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy4zMDM5MDVd IG1tY2JsazBycG1iOiBtbWMwOjAwMDEgU0VNMTZHIDQuMDAgTWlCLCBjaGFyZGV2ICgyNDQ6MCk8 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjU4MjY3Nl0gcnRj LWxwYzU1IHJ0Y19scGM1NTogbHBjNTVfcnRjX2dldF90aW1lOiBiYWQgcmVzdWx0OiAxPGJyPg0K Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy41ODMzMzJdIHJ0Yy1scGM1 NSBydGNfbHBjNTU6IGhjdG9zeXM6IHVuYWJsZSB0byByZWFkIHRoZSBoYXJkd2FyZSBjbG9jazxi cj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuNTkxMjUyXSBjZG5z LWkyYyBmZjAyMDAwMC5pMmM6IHJlY292ZXJ5IGluZm9ybWF0aW9uIGNvbXBsZXRlPGJyPg0KJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy41OTcwODVdIGF0MjQgMC0wMDUw OiBzdXBwbHkgdmNjIG5vdCBmb3VuZCwgdXNpbmcgZHVtbXkgcmVndWxhdG9yPGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy42MDMwMTFdIGxwYzU1X2wyIHNwaTEu MDogKDIpIG1jdSBzdGlsbCBub3QgcmVhZHk/PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyBbIMKgIMKgMy42MDgwOTNdIGF0MjQgMC0wMDUwOiAyNTYgYnl0ZSBzcGQgRUVQUk9N LCByZWFkLW9ubHk8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAz LjYxMzYyMF0gbHBjNTVfbDIgc3BpMS4wOiAoMykgbWN1IHN0aWxsIG5vdCByZWFkeT88YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjYxOTM2Ml0gbHBjNTVfbDIg c3BpMS4wOiAoNCkgbWN1IHN0aWxsIG5vdCByZWFkeT88YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjYyNDIyNF0gcnRjLXJ2MzAyOCAwLTAwNTI6IHJlZ2lzdGVy ZWQgYXMgcnRjMTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMu NjI4MzQzXSBscGM1NV9sMiBzcGkxLjA6ICg1KSBtY3Ugc3RpbGwgbm90IHJlYWR5Pzxicj4NCiZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuNjMzMjUzXSBscGM1NV9sMiBz cGkxLjA6IHJ4IGVycm9yOiAtMTEwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 OyBbIMKgIMKgMy42MzkxMDRdIGs4MV9ib290bG9hZGVyIDAtMDAxMDogcHJvYmU8YnI+DQomZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjY0MTYyOF0gVk1DVTogOiAoMjM1 OjApIHJlZ2lzdGVyZWQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAg wqAzLjY0MTYzNV0gazgxX2Jvb3Rsb2FkZXIgMC0wMDEwOiBwcm9iZSBjb21wbGV0ZWQ8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjY2ODM0Nl0gY2Rucy1pMmMg ZmYwMjAwMDAuaTJjOiA0MDAga0h6IG1taW8gZmYwMjAwMDAgaXJxIDI4PGJyPg0KJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy42NjkxNTRdIGNkbnMtaTJjIGZmMDMwMDAw LmkyYzogcmVjb3ZlcnkgaW5mb3JtYXRpb24gY29tcGxldGU8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjY3NTQxMl0gbG03NSAxLTAwNDg6IHN1cHBseSB2cyBu b3QgZm91bmQsIHVzaW5nIGR1bW15IHJlZ3VsYXRvcjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgWyDCoCDCoDMuNjgyOTIwXSBsbTc1IDEtMDA0ODogaHdtb24xOiBzZW5zb3Ig JiMzOTt0bXAxMTImIzM5Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDC oCDCoDMuNjg2NTQ4XSBpMmMgaTJjLTE6IEFkZGVkIG11bHRpcGxleGVkIGkyYyBidXMgMzxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuNjkwNzk1XSBpMmMgaTJj LTE6IEFkZGVkIG11bHRpcGxleGVkIGkyYyBidXMgNDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgWyDCoCDCoDMuNjk1NjI5XSBpMmMgaTJjLTE6IEFkZGVkIG11bHRpcGxleGVk IGkyYyBidXMgNTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMu NzAwNDkyXSBpMmMgaTJjLTE6IEFkZGVkIG11bHRpcGxleGVkIGkyYyBidXMgNjxicj4NCiZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuNzA1MTU3XSBwY2E5NTR4IDEtMDA3 MDogcmVnaXN0ZXJlZCA0IG11bHRpcGxleGVkIGJ1c3NlcyBmb3IgSTJDIHN3aXRjaCBwY2E5NTQ2 PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy43MTMwNDldIGF0 MjQgMS0wMDU0OiBzdXBwbHkgdmNjIG5vdCBmb3VuZCwgdXNpbmcgZHVtbXkgcmVndWxhdG9yPGJy Pg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy43MjAwNjddIGF0MjQg MS0wMDU0OiAxMDI0IGJ5dGUgMjRjMDggRUVQUk9NLCByZWFkLW9ubHk8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjcyNDc2MV0gY2Rucy1pMmMgZmYwMzAwMDAu aTJjOiAxMDAga0h6IG1taW8gZmYwMzAwMDAgaXJxIDI5PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0OyBbIMKgIMKgMy43MzEyNzJdIHNmcCB2aXBlcl9lbmV0OnNmcC1ldGgxOiBI b3N0IG1heGltdW0gcG93ZXIgMi4wVzxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgWyDCoCDCoDMuNzM3NTQ5XSBzZnBfcmVnaXN0ZXJfc29ja2V0OiBnb3Qgc2ZwX2J1czxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuNzQwNzA5XSBzZnBfcmVn aXN0ZXJfc29ja2V0OiByZWdpc3RlciBzZnBfYnVzPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyBbIMKgIMKgMy43NDU0NTldIHNmcF9yZWdpc3Rlcl9idXM6IG9wcyBvayE8YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjc0OTE3OV0gc2ZwX3Jl Z2lzdGVyX2J1czogVHJ5IHRvIGF0dGFjaDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgWyDCoCDCoDMuNzUzNDE5XSBzZnBfcmVnaXN0ZXJfYnVzOiBBdHRhY2ggc3VjY2VlZGVk PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy43NTc5MTRdIHNm cF9yZWdpc3Rlcl9idXM6IHVwc3RyZWFtIG9wcyBhdHRhY2g8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjc2MjY3N10gc2ZwX3JlZ2lzdGVyX2J1czogQnVzIHJl Z2lzdGVyZWQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjc2 Njk5OV0gc2ZwX3JlZ2lzdGVyX3NvY2tldDogcmVnaXN0ZXIgc2ZwX2J1cyBzdWNjZWVkZWQ8YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjc3NTg3MF0gb2ZfY2Zz X2luaXQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjc3NjAw MF0gb2ZfY2ZzX2luaXQ6IE9LPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBb IMKgIMKgMy43NzgyMTFdIGNsazogTm90IGRpc2FibGluZyB1bnVzZWQgY2xvY2tzPGJyPg0KJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjI3ODQ3N10gRnJlZWluZyBpbml0 cmQgbWVtb3J5OiAyMDYwNTZLPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBb IMKgIDExLjI3OTQwNl0gRnJlZWluZyB1bnVzZWQga2VybmVsIG1lbW9yeTogMTUzNks8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMzE0MDA2XSBDaGVja2VkIFcr WCBtYXBwaW5nczogcGFzc2VkLCBubyBXK1ggcGFnZXMgZm91bmQ8YnI+DQomZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMzE0MTQyXSBSdW4gL2luaXQgYXMgaW5pdCBwcm9j ZXNzPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBJTklUOiB2ZXJzaW9uIDMu MDEgYm9vdGluZzxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgZnNjayAoYnVz eWJveCAxLjM1LjApPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAvZGV2L21t Y2JsazBwMTogY2xlYW4sIDEyLzEwMjQwMCBmaWxlcywgMjM4MTYyLzQwOTYwMCBibG9ja3M8YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IC9kZXYvbW1jYmxrMHAyOiBjbGVhbiwg MTIvMTAyNDAwIGZpbGVzLCAxNzE5NzIvNDA5NjAwIGJsb2Nrczxicj4NCiZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDsgL2Rldi9tbWNibGswcDMgd2FzIG5vdCBjbGVhbmx5IHVubW91bnRl ZCwgY2hlY2sgZm9yY2VkLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgL2Rl di9tbWNibGswcDM6IDIwLzQwOTYgZmlsZXMgKDAuMCUgbm9uLWNvbnRpZ3VvdXMpLCA2NjMvMTYz ODQgYmxvY2tzPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjU1 MzA3M10gRVhUNC1mcyAobW1jYmxrMHAzKTogbW91bnRlZCBmaWxlc3lzdGVtIHdpdGhvdXQgam91 cm5hbC4gT3B0czogKG51bGwpLiBRdW90YSBtb2RlOiBkaXNhYmxlZC48YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFN0YXJ0aW5nIHJhbmRvbSBudW1iZXIgZ2VuZXJhdG9yIGRh ZW1vbi48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuNTgwNjYy XSByYW5kb206IGNybmcgaW5pdCBkb25lPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0OyBTdGFydGluZyB1ZGV2PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBb IMKgIDExLjYxMzE1OV0gdWRldmRbMTQyXTogc3RhcnRpbmcgdmVyc2lvbiAzLjIuMTA8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuNjIwMzg1XSB1ZGV2ZFsxNDNd OiBzdGFydGluZyBldWRldi0zLjIuMTA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IFsgwqAgMTEuNzA0NDgxXSBtYWNiIGZmMGIwMDAwLmV0aGVybmV0IGNvbnRyb2xfcmVkOiBy ZW5hbWVkIGZyb20gZXRoMDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDC oCAxMS43MjAyNjRdIG1hY2IgZmYwYzAwMDAuZXRoZXJuZXQgY29udHJvbF9ibGFjazogcmVuYW1l ZCBmcm9tIGV0aDE8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTIu MDYzMzk2XSBpcF9sb2NhbF9wb3J0X3JhbmdlOiBwcmVmZXIgZGlmZmVyZW50IHBhcml0eSBmb3Ig c3RhcnQvZW5kIHZhbHVlcy48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsg wqAgMTIuMDg0ODAxXSBydGMtbHBjNTUgcnRjX2xwYzU1OiBscGM1NV9ydGNfZ2V0X3RpbWU6IGJh ZCByZXN1bHQ6IDE8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IGh3Y2xvY2s6 IFJUQ19SRF9USU1FOiBJbnZhbGlkIGV4Y2hhbmdlPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyBNb24gRmViIDI3IDA4OjQwOjUzIFVUQyAyMDIzPGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDEyLjExNTMwOV0gcnRjLWxwYzU1IHJ0Y19scGM1NTog bHBjNTVfcnRjX3NldF90aW1lOiBiYWQgcmVzdWx0PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyBod2Nsb2NrOiBSVENfU0VUX1RJTUU6IEludmFsaWQgZXhjaGFuZ2U8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTIuMTMxMDI3XSBydGMtbHBjNTUg cnRjX2xwYzU1OiBscGM1NV9ydGNfZ2V0X3RpbWU6IGJhZCByZXN1bHQ6IDE8YnI+DQomZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFN0YXJ0aW5nIG1jdWQ8YnI+DQomZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7IElOSVQ6IEVudGVyaW5nIHJ1bmxldmVsOiA1PGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBDb25maWd1cmluZyBuZXR3b3JrIGludGVyZmFjZXMu Li4gZG9uZS48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IHJlc2V0dGluZyBu ZXR3b3JrIGludGVyZmFjZTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDC oCAxMi43MTgyOTVdIG1hY2IgZmYwYjAwMDAuZXRoZXJuZXQgY29udHJvbF9yZWQ6IFBIWSBbZmYw YjAwMDAuZXRoZXJuZXQtZmZmZmZmZmY6MDJdIGRyaXZlciBbWGlsaW54IFBDUy9QTUEgUEhZXSAo aXJxPVBPTEwpPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDEyLjcy MzkxOV0gbWFjYiBmZjBiMDAwMC5ldGhlcm5ldCBjb250cm9sX3JlZDogY29uZmlndXJpbmcgZm9y IHBoeS9nbWlpIGxpbmsgbW9kZTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg WyDCoCAxMi43MzIxNTFdIHBwcyBwcHMwOiBuZXcgUFBTIHNvdXJjZSBwdHAwPGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDEyLjczNTU2M10gbWFjYiBmZjBiMDAwMC5l dGhlcm5ldDogZ2VtLXB0cC10aW1lciBwdHAgY2xvY2sgcmVnaXN0ZXJlZC48YnI+DQomZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTIuNzQ1NzI0XSBtYWNiIGZmMGMwMDAwLmV0 aGVybmV0IGNvbnRyb2xfYmxhY2s6IFBIWSBbZmYwYzAwMDAuZXRoZXJuZXQtZmZmZmZmZmY6MDFd IGRyaXZlciBbWGlsaW54IFBDUy9QTUEgUEhZXTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoChpcnE9UE9MTCk8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAg MTIuNzUzNDY5XSBtYWNiIGZmMGMwMDAwLmV0aGVybmV0IGNvbnRyb2xfYmxhY2s6IGNvbmZpZ3Vy aW5nIGZvciBwaHkvZ21paSBsaW5rIG1vZGU8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7IFsgwqAgMTIuNzYxODA0XSBwcHMgcHBzMTogbmV3IFBQUyBzb3VyY2UgcHRwMTxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxMi43NjUzOThdIG1hY2IgZmYw YzAwMDAuZXRoZXJuZXQ6IGdlbS1wdHAtdGltZXIgcHRwIGNsb2NrIHJlZ2lzdGVyZWQuPGJyPg0K Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBBdXRvLW5lZ290aWF0aW9uOiBvZmY8YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IEF1dG8tbmVnb3RpYXRpb246IG9mZjxi cj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxNi44MjgxNTFdIG1hY2Ig ZmYwYjAwMDAuZXRoZXJuZXQgY29udHJvbF9yZWQ6IHVuYWJsZSB0byBnZW5lcmF0ZSB0YXJnZXQg ZnJlcXVlbmN5OiAxMjUwMDAwMDAgSHo8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IFsgwqAgMTYuODM0NTUzXSBtYWNiIGZmMGIwMDAwLmV0aGVybmV0IGNvbnRyb2xfcmVkOiBM aW5rIGlzIFVwIC0gMUdicHMvRnVsbCAtIGZsb3cgY29udHJvbCBvZmY8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTYuODYwNTUyXSBtYWNiIGZmMGMwMDAwLmV0aGVy bmV0IGNvbnRyb2xfYmxhY2s6IHVuYWJsZSB0byBnZW5lcmF0ZSB0YXJnZXQgZnJlcXVlbmN5OiAx MjUwMDAwMDAgSHo8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTYu ODY3MDUyXSBtYWNiIGZmMGMwMDAwLmV0aGVybmV0IGNvbnRyb2xfYmxhY2s6IExpbmsgaXMgVXAg LSAxR2Jwcy9GdWxsIC0gZmxvdyBjb250cm9sIG9mZjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgU3RhcnRpbmcgRmFpbHNhZmUgU2VjdXJlIFNoZWxsIHNlcnZlciBpbiBwb3J0 IDIyMjI6IHNzaGQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IGRvbmUuPGJy Pg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBTdGFydGluZyBycGNiaW5kIGRhZW1v bi4uLmRvbmUuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxNy4wOTMwMTldIHJ0Yy1scGM1NSBydGNf bHBjNTU6IGxwYzU1X3J0Y19nZXRfdGltZTogYmFkIHJlc3VsdDogMTxicj4NCiZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDsgaHdjbG9jazogUlRDX1JEX1RJTUU6IEludmFsaWQgZXhjaGFu Z2U8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFN0YXJ0aW5nIFN0YXRlIE1h bmFnZXIgU2VydmljZTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgU3RhcnQg c3RhdGUtbWFuYWdlciByZXN0YXJ0ZXIuLi48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7IChYRU4pIGQwdjEgRm9yd2FyZGluZyBBRVMgb3BlcmF0aW9uOiAzMjU0Nzc5OTUxPGJy Pg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBTdGFydGluZyAvdXNyL3NiaW4veGVu c3RvcmVkLi4uLlsgwqAgMTcuMjY1MjU2XSBCVFJGUzogZGV2aWNlIGZzaWQgODBlZmMyMjQtYzIw Mi00ZjhlLWE5NDktNGRhZTdmMDRhMGFhIGRldmlkIDEgdHJhbnNpZCA3NDQ8YnI+DQomZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAvZGV2L2RtLTA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7IHNjYW5uZWQgYnkgdWRldmQgKDM4NSk8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7IFsgwqAgMTcuMzQ5OTMzXSBCVFJGUyBpbmZvIChkZXZpY2UgZG0tMCk6IGRp c2sgc3BhY2UgY2FjaGluZyBpcyBlbmFibGVkPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyBbIMKgIDE3LjM1MDY3MF0gQlRSRlMgaW5mbyAoZGV2aWNlIGRtLTApOiBoYXMgc2tp bm55IGV4dGVudHM8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTcu MzY0Mzg0XSBCVFJGUyBpbmZvIChkZXZpY2UgZG0tMCk6IGVuYWJsaW5nIHNzZCBvcHRpbWl6YXRp b25zPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDE3LjgzMDQ2Ml0g QlRSRlM6IGRldmljZSBmc2lkIDI3ZmY2NjZiLWY0ZTUtNGY5MC05MDU0LWMyMTBkYjViMmUyZSBk ZXZpZCAxIHRyYW5zaWQgNiAvZGV2L21hcHBlci9jbGllbnRfcHJvdiBzY2FubmVkIGJ5PGJyPg0K Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgbWtmcy5idHJmczxicj4NCiZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDsgKDUyNik8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IFsgwqAgMTcuODcyNjk5XSBCVFJGUyBpbmZvIChkZXZpY2UgZG0tMSk6IHVzaW5nIGZyZWUg c3BhY2UgdHJlZTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxNy44 NzI3NzFdIEJUUkZTIGluZm8gKGRldmljZSBkbS0xKTogaGFzIHNraW5ueSBleHRlbnRzPGJyPg0K Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDE3Ljg3ODExNF0gQlRSRlMgaW5m byAoZGV2aWNlIGRtLTEpOiBmbGFnZ2luZyBmcyB3aXRoIGJpZyBtZXRhZGF0YSBmZWF0dXJlPGJy Pg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDE3Ljg5NDI4OV0gQlRSRlMg aW5mbyAoZGV2aWNlIGRtLTEpOiBlbmFibGluZyBzc2Qgb3B0aW1pemF0aW9uczxicj4NCiZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxNy44OTU2OTVdIEJUUkZTIGluZm8gKGRl dmljZSBkbS0xKTogY2hlY2tpbmcgVVVJRCB0cmVlPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgU2V0dGluZyBk b21haW4gMCBuYW1lLCBkb21pZCBhbmQgSlNPTiBjb25maWcuLi48YnI+DQomZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7IERvbmUgc2V0dGluZyB1cCBEb20wPGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0OyBTdGFydGluZyB4ZW5jb25zb2xlZC4uLjxicj4NCiZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDsgU3RhcnRpbmcgUUVNVSBhcyBkaXNrIGJhY2tlbmQgZm9y IGRvbTA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFN0YXJ0aW5nIGRvbWFp biB3YXRjaGRvZyBkYWVtb246IHhlbndhdGNoZG9nZCBzdGFydHVwPGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg WyDCoCAxOC40MDg2NDddIEJUUkZTOiBkZXZpY2UgZnNpZCA1ZTA4ZDVlOS1iYzJhLTQ2YjktYWY2 YS00NGM3MDg3Yjg5MjEgZGV2aWQgMSB0cmFuc2lkIDYgL2Rldi9tYXBwZXIvY2xpZW50X2NvbmZp ZyBzY2FubmVkIGJ5PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgbWtmcy5idHJmczxi cj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKDU3NCk8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFtkb25lXTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDsgWyDCoCAxOC40NjU1NTJdIEJUUkZTIGluZm8gKGRldmljZSBkbS0yKTogdXNpbmcg ZnJlZSBzcGFjZSB0cmVlPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKg IDE4LjQ2NTYyOV0gQlRSRlMgaW5mbyAoZGV2aWNlIGRtLTIpOiBoYXMgc2tpbm55IGV4dGVudHM8 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTguNDcxMDAyXSBCVFJG UyBpbmZvIChkZXZpY2UgZG0tMik6IGZsYWdnaW5nIGZzIHdpdGggYmlnIG1ldGFkYXRhIGZlYXR1 cmU8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFN0YXJ0aW5nIGNyb25kOiBb IMKgIDE4LjQ4MjM3MV0gQlRSRlMgaW5mbyAoZGV2aWNlIGRtLTIpOiBlbmFibGluZyBzc2Qgb3B0 aW1pemF0aW9uczxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxOC40 ODY2NTldIEJUUkZTIGluZm8gKGRldmljZSBkbS0yKTogY2hlY2tpbmcgVVVJRCB0cmVlPGJyPg0K Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBPSzxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgc3RhcnRpbmcgcnN5c2xvZ2QgLi4uIExvZyBwYXJ0aXRpb24gcmVhZHkg YWZ0ZXIgMCBwb2xsIGxvb3BzPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBk b25lPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyByc3lzbG9nZDogY2Fubm90 IGNvbm5lY3QgdG8gPGEgaHJlZj0iaHR0cDovLzE3Mi4xOC4wLjE6NTE0IiByZWw9Im5vcmVmZXJy ZXIiIHRhcmdldD0iX2JsYW5rIj4xNzIuMTguMC4xOjUxNDwvYT4gJmx0OzxhIGhyZWY9Imh0dHA6 Ly8xNzIuMTguMC4xOjUxNCIgcmVsPSJub3JlZmVycmVyIiB0YXJnZXQ9Il9ibGFuayI+aHR0cDov LzE3Mi4xOC4wLjE6NTE0PC9hPiZndDs6IE5ldHdvcmsgaXMgdW5yZWFjaGFibGUgW3Y4LjIyMDgu MCB0cnkgPGEgaHJlZj0iaHR0cHM6Ly93d3cucnN5c2xvZy5jb20vZS8yMDI3IiByZWw9Im5vcmVm ZXJyZXIiIHRhcmdldD0iX2JsYW5rIj5odHRwczovL3d3dy5yc3lzbG9nLmNvbS9lLzIwMjc8L2E+ ICZsdDs8YSBocmVmPSJodHRwczovL3d3dy5yc3lzbG9nLmNvbS9lLzIwMjciIHJlbD0ibm9yZWZl cnJlciIgdGFyZ2V0PSJfYmxhbmsiPmh0dHBzOi8vd3d3LnJzeXNsb2cuY29tL2UvMjAyNzwvYT4m Z3Q7IF08YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTguNjcwNjM3 XSBCVFJGUzogZGV2aWNlIGZzaWQgMzlkN2Q5ZTEtOTY3ZC00NzhlLTk0YWUtNjkwZGViNzIyMDk1 IGRldmlkIDEgdHJhbnNpZCA2MDggL2Rldi9kbS0zIHNjYW5uZWQgYnkgdWRldmQgKDUxOCk8YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0OyBQbGVhc2UgaW5zZXJ0IFVTQiB0b2tlbiBhbmQgZW50ZXIgeW91ciByb2xl IGluIGxvZ2luIHByb21wdC48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJy Pg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBsb2dpbjo8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 OyBSZWdhcmRzLDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgTy48YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg0L/QvSwgMjQg 0LDQv9GALiAyMDIz4oCv0LMuINCyIDIzOjM5LCBTdGVmYW5vIFN0YWJlbGxpbmkgJmx0OzxhIGhy ZWY9Im1haWx0bzpzc3RhYmVsbGluaUBrZXJuZWwub3JnIiB0YXJnZXQ9Il9ibGFuayI+c3N0YWJl bGxpbmlAa2VybmVsLm9yZzwvYT4gJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86c3N0YWJlbGxp bmlAa2VybmVsLm9yZyIgdGFyZ2V0PSJfYmxhbmsiPnNzdGFiZWxsaW5pQGtlcm5lbC5vcmc8L2E+ Jmd0OyZndDs6PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg SGkgT2xlZyw8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgSGVyZSBpcyB0aGUgaXNzdWUgZnJv bSB5b3VyIGxvZ3M6PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoFNFcnJvciBJbnRlcnJ1cHQg b24gQ1BVMCwgY29kZSAweGJlMDAwMDAwIC0tIFNFcnJvcjxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqBTRXJyb3JzIGFyZSBzcGVjaWFsIHNpZ25hbHMgdG8gbm90aWZ5IHNvZnR3YXJlIG9mIHNl cmlvdXMgaGFyZHdhcmU8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqBlcnJvcnMuwqAgU29tZXRoaW5nIGlzIGdvaW5nIHZlcnkgd3JvbmcuIERlZmVjdGl2ZSBo YXJkd2FyZSBpcyBhPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgcG9zc2liaWxpdHkuwqAgQW5vdGhlciBwb3NzaWJpbGl0eSBpZiBzb2Z0d2FyZSBhY2Nlc3Np bmcgYWRkcmVzcyByYW5nZXM8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqB0aGF0IGl0IGlzIG5vdCBzdXBwb3NlZCB0bywgc29tZXRpbWVzIGl0IGNhdXNlcyBT RXJyb3JzLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBDaGVlcnMsPGJyPg0KJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoFN0ZWZhbm88YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqBPbiBNb24sIDI0IEFwciAyMDIzLCBPbGVnIE5pa2l0ZW5rbyB3cm90ZTo8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBIZWxsbyw8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBUaGFua3MgZ3V5cy48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IEkgZm91bmQgb3V0IHdoZXJlIHRoZSBwcm9i bGVtIHdhcy48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IE5vdyBkb20wIGJvb3RlZCBtb3JlLiBCdXQgSSBoYXZlIGEgbmV3IG9uZS48YnI+DQomZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFRoaXMgaXMgYSBrZXJu ZWwgcGFuaWMgZHVyaW5nIERvbTAgbG9hZGluZy48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IE1heWJlIHNvbWVvbmUgaXMgYWJsZSB0byBzdWdnZXN0 IHNvbWV0aGluZyA/PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgUmVnYXJkcyw8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7IE8uPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg WyDCoCDCoDMuNzcxMzYyXSBzZnBfcmVnaXN0ZXJfYnVzOiB1cHN0cmVhbSBvcHMgYXR0YWNoPGJy Pg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKg My43NzYxMTldIHNmcF9yZWdpc3Rlcl9idXM6IEJ1cyByZWdpc3RlcmVkPGJyPg0KJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy43ODA0NTldIHNm cF9yZWdpc3Rlcl9zb2NrZXQ6IHJlZ2lzdGVyIHNmcF9idXMgc3VjY2VlZGVkPGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy43ODkzOTld IG9mX2Nmc19pbml0PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyBbIMKgIMKgMy43ODk0OTldIG9mX2Nmc19pbml0OiBPSzxicj4NCiZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuNzkxNjg1XSBjbGs6 IE5vdCBkaXNhYmxpbmcgdW51c2VkIGNsb2Nrczxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxMS4wMTAzNTVdIFNFcnJvciBJbnRlcnJ1cHQg b24gQ1BVMCwgY29kZSAweGJlMDAwMDAwIC0tIFNFcnJvcjxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxMS4wMTAzODBdIENQVTogMCBQSUQ6 IDkgQ29tbToga3dvcmtlci91NDowIE5vdCB0YWludGVkIDUuMTUuNzIteGlsaW54LXYyMDIyLjEg IzE8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsg wqAgMTEuMDEwMzkzXSBXb3JrcXVldWU6IGV2ZW50c191bmJvdW5kIGFzeW5jX3J1bl9lbnRyeV9m bjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDC oCAxMS4wMTA0MTRdIHBzdGF0ZTogNjAwMDAwMDUgKG5aQ3YgZGFpZiAtUEFOIC1VQU8gLVRDTyAt RElUIC1TU0JTIEJUWVBFPS0tKTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgWyDCoCAxMS4wMTA0MjJdIHBjIDogc2ltcGxlX3dyaXRlX2VuZCsweGQw LzB4MTMwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 OyBbIMKgIDExLjAxMDQzMV0gbHIgOiBnZW5lcmljX3BlcmZvcm1fd3JpdGUrMHgxMTgvMHgxZTA8 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAg MTEuMDEwNDM4XSBzcCA6IGZmZmZmZmMwMDgwOWI5MTA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNDQxXSB4Mjk6IGZmZmZmZmMw MDgwOWI5MTAgeDI4OiAwMDAwMDAwMDAwMDAwMDAwIHgyNzogZmZmZmZmZWY2OWJhODhjMDxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxMS4w MTA0NTFdIHgyNjogMDAwMDAwMDAwMDAwM2VlYyB4MjU6IGZmZmZmZjgwNzUxNWRiMDAgeDI0OiAw MDAwMDAwMDAwMDAwMDAwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyBbIMKgIDExLjAxMDQ1OV0geDIzOiBmZmZmZmZjMDA4MDliYTkwIHgyMjogMDAw MDAwMDAwMmFhYzAwMCB4MjE6IGZmZmZmZjgwNzMxNWEyNjA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNDcyXSB4MjA6IDAwMDAw MDAwMDAwMDEwMDAgeDE5OiBmZmZmZmZmZTAyMDAwMDAwIHgxODogMDAwMDAwMDAwMDAwMDAwMDxi cj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAx MS4wMTA0ODFdIHgxNzogMDAwMDAwMDBmZmZmZmZmZiB4MTY6IDAwMDAwMDAwMDAwMDgwMDAgeDE1 OiAwMDAwMDAwMDAwMDAwMDAwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDQ5MF0geDE0OiAwMDAwMDAwMDAwMDAwMDAwIHgxMzog MDAwMDAwMDAwMDAwMDAwMCB4MTI6IDAwMDAwMDAwMDAwMDAwMDA8YnI+DQomZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNDk4XSB4MTE6IDAw MDAwMDAwMDAwMDAwMDAgeDEwOiAwMDAwMDAwMDAwMDAwMDAwIHg5IDogMDAwMDAwMDAwMDAwMDAw MDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDC oCAxMS4wMTA1MDddIHg4IDogMDAwMDAwMDAwMDAwMDAwMCB4NyA6IGZmZmZmZmVmNjkzYmE2ODAg eDYgOiAwMDAwMDAwMDJkODliNzAwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDUxNV0geDUgOiBmZmZmZmZmZTAyMDAwMDAwIHg0 IDogZmZmZmZmODA3MzE1YTNjOCB4MyA6IDAwMDAwMDAwMDAwMDEwMDA8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNTI0XSB4MiA6 IDAwMDAwMDAwMDJhYWIwMDAgeDEgOiAwMDAwMDAwMDAwMDAwMDAxIHgwIDogMDAwMDAwMDAwMDAw MDAwNTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg WyDCoCAxMS4wMTA1MzRdIEtlcm5lbCBwYW5pYyAtIG5vdCBzeW5jaW5nOiBBc3luY2hyb25vdXMg U0Vycm9yIEludGVycnVwdDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgWyDCoCAxMS4wMTA1MzldIENQVTogMCBQSUQ6IDkgQ29tbToga3dvcmtlci91 NDowIE5vdCB0YWludGVkIDUuMTUuNzIteGlsaW54LXYyMDIyLjEgIzE8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNTQ1XSBIYXJk d2FyZSBuYW1lOiBEMTQgVmlwZXIgQm9hcmQgLSBXaGl0ZSBVbml0IChEVCk8YnI+DQomZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNTQ4XSBX b3JrcXVldWU6IGV2ZW50c191bmJvdW5kIGFzeW5jX3J1bl9lbnRyeV9mbjxicj4NCiZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxMS4wMTA1NTZdIENh bGwgdHJhY2U6PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0OyBbIMKgIDExLjAxMDU1OF0gwqBkdW1wX2JhY2t0cmFjZSsweDAvMHgxYzQ8YnI+DQomZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNTY3 XSDCoHNob3dfc3RhY2srMHgxOC8weDJjPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDU3NF0gwqBkdW1wX3N0YWNrX2x2bCsweDdj LzB4YTA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IFsgwqAgMTEuMDEwNTgzXSDCoGR1bXBfc3RhY2srMHgxOC8weDM0PGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDU4OF0gwqBwYW5p YysweDE0Yy8weDJmODxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDsgWyDCoCAxMS4wMTA1OTddIMKgcHJpbnRfdGFpbnRlZCsweDAvMHhiMDxicj4NCiZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxMS4wMTA2 MDZdIMKgYXJtNjRfc2Vycm9yX3BhbmljKzB4NmMvMHg3Yzxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxMS4wMTA2MTRdIMKgZG9fc2Vycm9y KzB4MjgvMHg2MDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgWyDCoCAxMS4wMTA2MjFdIMKgZWwxaF82NF9lcnJvcl9oYW5kbGVyKzB4MzAvMHg1MDxi cj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAx MS4wMTA2MjhdIMKgZWwxaF82NF9lcnJvcisweDc4LzB4N2M8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNjMzXSDCoHNpbXBsZV93 cml0ZV9lbmQrMHhkMC8weDEzMDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgWyDCoCAxMS4wMTA2MzldIMKgZ2VuZXJpY19wZXJmb3JtX3dyaXRlKzB4 MTE4LzB4MWUwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0OyBbIMKgIDExLjAxMDY0NF0gwqBfX2dlbmVyaWNfZmlsZV93cml0ZV9pdGVyKzB4MTM4LzB4 MWM0PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBb IMKgIDExLjAxMDY1MF0gwqBnZW5lcmljX2ZpbGVfd3JpdGVfaXRlcisweDc4LzB4ZDA8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEw NjU2XSDCoF9fa2VybmVsX3dyaXRlKzB4ZmMvMHgyYWM8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNjY1XSDCoGtlcm5lbF93cml0 ZSsweDg4LzB4MTYwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyBbIMKgIDExLjAxMDY3M10gwqB4d3JpdGUrMHg0NC8weDk0PGJyPg0KJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDY4MF0gwqBk b19jb3B5KzB4YTgvMHgxMDQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNjg2XSDCoHdyaXRlX2J1ZmZlcisweDM4LzB4NTg8YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEu MDEwNjkyXSDCoGZsdXNoX2J1ZmZlcisweDRjLzB4YmM8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNjk4XSDCoF9fZ3VuemlwKzB4 MjgwLzB4MzEwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0OyBbIMKgIDExLjAxMDcwNF0gwqBndW56aXArMHgxYy8weDI4PGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDcwOV0gwqB1bnBh Y2tfdG9fcm9vdGZzKzB4MTcwLzB4MmIwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDcxNV0gwqBkb19wb3B1bGF0ZV9yb290ZnMr MHg4MC8weDE2NDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgWyDCoCAxMS4wMTA3MjJdIMKgYXN5bmNfcnVuX2VudHJ5X2ZuKzB4NDgvMHgxNjQ8YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEu MDEwNzI4XSDCoHByb2Nlc3Nfb25lX3dvcmsrMHgxZTQvMHgzYTA8YnI+DQomZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNzM2XSDCoHdvcmtl cl90aHJlYWQrMHg3Yy8weDRjMDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgWyDCoCAxMS4wMTA3NDNdIMKga3RocmVhZCsweDEyMC8weDEzMDxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxMS4w MTA3NTBdIMKgcmV0X2Zyb21fZm9yaysweDEwLzB4MjA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNzU3XSBTTVA6IHN0b3BwaW5n IHNlY29uZGFyeSBDUFVzPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyBbIMKgIDExLjAxMDc4NF0gS2VybmVsIE9mZnNldDogMHgyZjYxMjAwMDAwIGZy b20gMHhmZmZmZmZjMDA4MDAwMDAwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDc4OF0gUEhZU19PRkZTRVQ6IDB4MDxicj4NCiZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxMS4wMTA3 OTBdIENQVSBmZWF0dXJlczogMHgwMDAwMDQwMSwwMDAwMDg0Mjxicj4NCiZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxMS4wMTA3OTVdIE1lbW9yeSBM aW1pdDogbm9uZTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgWyDCoCAxMS4yNzc1MDldIC0tLVsgZW5kIEtlcm5lbCBwYW5pYyAtIG5vdCBzeW5jaW5n OiBBc3luY2hyb25vdXMgU0Vycm9yIEludGVycnVwdCBdLS0tPGJyPg0KJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg0L/RgiwgMjEg0LDQv9GALiAyMDIz4oCv0LMuINCy IDE1OjUyLCBNaWNoYWwgT3J6ZWwgJmx0OzxhIGhyZWY9Im1haWx0bzptaWNoYWwub3J6ZWxAYW1k LmNvbSIgdGFyZ2V0PSJfYmxhbmsiPm1pY2hhbC5vcnplbEBhbWQuY29tPC9hPiAmbHQ7bWFpbHRv OjxhIGhyZWY9Im1haWx0bzptaWNoYWwub3J6ZWxAYW1kLmNvbSIgdGFyZ2V0PSJfYmxhbmsiPm1p Y2hhbC5vcnplbEBhbWQuY29tPC9hPiZndDsmZ3Q7Ojxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoEhpIE9sZWcsPGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoE9uIDIxLzA0LzIw MjMgMTQ6NDksIE9sZWcgTmlraXRlbmtvIHdyb3RlOjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoDxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBIZWxsbyBNaWNoYWwsPGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgSSB3YXMgbm90IGFibGUgdG8gZW5hYmxlIGVhcmx5cHJpbnRrIGluIHRoZSB4ZW4gZm9yIG5v dy48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7IEkgZGVjaWRlZCB0byBjaG9vc2UgYW5vdGhlciB3YXkuPGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBU aGlzIGlzIGEgeGVuJiMzOTtzIGNvbW1hbmQgbGluZSB0aGF0IEkgZm91bmQgb3V0IGNvbXBsZXRl bHkuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgJCQkJCBjb25zb2xlPWR0dWFydCBkdHVhcnQ9 c2VyaWFsMCBkb20wX21lbT0xNjAwTSBkb20wX21heF92Y3B1cz0yIGRvbTBfdmNwdXNfcGluIGJv b3RzY3J1Yj0wPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgdndmaT1uYXRpdmU8YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBzY2hlZD1udWxsPGJy Pg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgdGltZXJfc2xvcD0wPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgWWVzLCBhZGRpbmcgYSBwcmludGsoKSBpbiBYZW4gd2FzIGFs c28gYSBnb29kIGlkZWEuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFNvIHlvdSBhcmUgYWJzb2x1dGVseSByaWdo dCBhYm91dCBhIGNvbW1hbmQgbGluZS48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IE5vdyBJIGFtIGdvaW5nIHRvIGZpbmQg b3V0IHdoeSB4ZW4gZGlkIG5vdCBoYXZlIHRoZSBjb3JyZWN0IHBhcmFtZXRlcnMgZnJvbSB0aGUg ZGV2aWNlIHRyZWUuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgTWF5YmUgeW91IHdpbGwgZmluZCB0aGlzIGRvY3VtZW50IGhlbHBm dWw6PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgPGEgaHJlZj0iaHR0cHM6Ly9naXRodWIuY29tL1hpbGlueC94ZW4vYmxvYi94bG54 X3JlYmFzZV80LjE2L2RvY3MvbWlzYy9hcm0vZGV2aWNlLXRyZWUvYm9vdGluZy50eHQiIHJlbD0i bm9yZWZlcnJlciIgdGFyZ2V0PSJfYmxhbmsiPmh0dHBzOi8vZ2l0aHViLmNvbS9YaWxpbngveGVu L2Jsb2IveGxueF9yZWJhc2VfNC4xNi9kb2NzL21pc2MvYXJtL2RldmljZS10cmVlL2Jvb3Rpbmcu dHh0PC9hPiAmbHQ7PGEgaHJlZj0iaHR0cHM6Ly9naXRodWIuY29tL1hpbGlueC94ZW4vYmxvYi94 bG54X3JlYmFzZV80LjE2L2RvY3MvbWlzYy9hcm0vZGV2aWNlLXRyZWUvYm9vdGluZy50eHQiIHJl bD0ibm9yZWZlcnJlciIgdGFyZ2V0PSJfYmxhbmsiPmh0dHBzOi8vZ2l0aHViLmNvbS9YaWxpbngv eGVuL2Jsb2IveGxueF9yZWJhc2VfNC4xNi9kb2NzL21pc2MvYXJtL2RldmljZS10cmVlL2Jvb3Rp bmcudHh0PC9hPiZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgfk1pY2hhbDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBSZWdhcmRzLDxicj4NCiZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg T2xlZzxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7INC/0YIsIDIxINCw0L/RgC4gMjAyM+KAr9CzLiDQsiAx MToxNiwgTWljaGFsIE9yemVsICZsdDs8YSBocmVmPSJtYWlsdG86bWljaGFsLm9yemVsQGFtZC5j b20iIHRhcmdldD0iX2JsYW5rIj5taWNoYWwub3J6ZWxAYW1kLmNvbTwvYT4gJmx0O21haWx0bzo8 YSBocmVmPSJtYWlsdG86bWljaGFsLm9yemVsQGFtZC5jb20iIHRhcmdldD0iX2JsYW5rIj5taWNo YWwub3J6ZWxAYW1kLmNvbTwvYT4mZ3Q7ICZsdDttYWlsdG86PGEgaHJlZj0ibWFpbHRvOm1pY2hh bC5vcnplbEBhbWQuY29tIiB0YXJnZXQ9Il9ibGFuayI+bWljaGFsLm9yemVsQGFtZC5jb208L2E+ ICZsdDttYWlsdG86PGEgaHJlZj0ibWFpbHRvOm1pY2hhbC5vcnplbEBhbWQuY29tIiB0YXJnZXQ9 Il9ibGFuayI+bWljaGFsLm9yemVsQGFtZC5jb208L2E+Jmd0OyZndDsmZ3Q7Ojxicj4NCiZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgT24gMjEvMDQvMjAyMyAxMDowNCwgT2xlZyBOaWtp dGVua28gd3JvdGU6PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgPGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7IEhl bGxvIE1pY2hhbCw8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0OyBZ ZXMsIEkgdXNlIHlvY3RvLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAm Z3Q7IFllc3RlcmRheSBhbGwgZGF5IGxvbmcgSSB0cmllZCB0byBmb2xsb3cgeW91ciBzdWdnZXN0 aW9ucy48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7IEkgZmFjZWQgYSBwcm9ibGVtLjxicj4NCiZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCZndDsgTWFudWFsbHkgaW4gdGhlIHhlbiBjb25maWcgYnVpbGQgZmlsZSBJIHBhc3Rl ZCB0aGUgc3RyaW5nczo8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqBJbiB0aGUgLmNvbmZpZyBmaWxlIG9yIGlu IHNvbWUgWW9jdG8gZmlsZSAobGlzdGluZyBhZGRpdGlvbmFsIEtjb25maWcgb3B0aW9ucykgYWRk ZWQgdG8gU1JDX1VSST88YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqBZb3Ugc2hvdWxkbiYjMzk7dCByZWFsbHkg bW9kaWZ5IC5jb25maWcgZmlsZSBidXQgaWYgeW91IGRvLCB5b3Ugc2hvdWxkIGV4ZWN1dGUgJnF1 b3Q7bWFrZSBvbGRkZWZjb25maWcmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqBhZnRlcndhcmRzLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgJmd0OyBDT05GSUdfRUFSTFlfUFJJTlRLPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0OyBDT05G SUdfRUFSTFlfUFJJTlRLX1pZTlFNUDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDsgQ09ORklHX0VBUkxZ X1VBUlRfQ0hPSUNFX0NBREVOQ0U8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqBJIGhvcGUgeW91IGFkZGVkID15 IHRvIHRoZW0uPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoEFueXdheSwgeW91IGhhdmUgYXQg bGVhc3QgdGhlIGZvbGxvd2luZyBzb2x1dGlvbnM6PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgMSkgUnVuIGJp dGJha2UgeGVuIC1jIG1lbnVjb25maWcgdG8gcHJvcGVybHkgc2V0IGVhcmx5IHByaW50azxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoDIpIEZpbmQgb3V0IGhvdyB5b3UgZW5hYmxlIG90aGVyIEtjb25maWcgb3B0 aW9ucyBpbiB5b3VyIHByb2plY3QgKGUuZy4gQ09ORklHX0NPTE9SSU5HPXkgdGhhdCBpcyBub3Q8 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBlbmFibGVkIGJ5PGJyPg0KJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgZGVmYXVsdCk8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAzKSBBcHBlbmQgdGhlIGZvbGxvd2luZyB0byAmcXVvdDt4ZW4vYXJjaC9hcm0vY29uZmlncy9h cm02NF9kZWZjb25maWcmcXVvdDs6PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgQ09ORklHX0VBUkxZX1BSSU5U S19aWU5RTVA9eTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqB+TWljaGFsPGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxi cj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7IEhvc3QgaGFuZ3MgaW4g YnVpbGQgdGltZS7CoDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDsgTWF5YmUgSSBkaWQgbm90IHNldCBz b21ldGhpbmcgaW4gdGhlIGNvbmZpZyBidWlsZCBmaWxlID88YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7 PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgJmd0OyBSZWdhcmRzLDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDsgT2xl Zzxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7INGH0YIsIDIwINCw 0L/RgC4gMjAyM+KAr9CzLiDQsiAxMTo1NywgT2xlZyBOaWtpdGVua28gJmx0OzxhIGhyZWY9Im1h aWx0bzpvbGVzaGlpd29vZEBnbWFpbC5jb20iIHRhcmdldD0iX2JsYW5rIj5vbGVzaGlpd29vZEBn bWFpbC5jb208L2E+ICZsdDttYWlsdG86PGEgaHJlZj0ibWFpbHRvOm9sZXNoaWl3b29kQGdtYWls LmNvbSIgdGFyZ2V0PSJfYmxhbmsiPm9sZXNoaWl3b29kQGdtYWlsLmNvbTwvYT4mZ3Q7ICZsdDtt YWlsdG86PGEgaHJlZj0ibWFpbHRvOm9sZXNoaWl3b29kQGdtYWlsLmNvbSIgdGFyZ2V0PSJfYmxh bmsiPm9sZXNoaWl3b29kQGdtYWlsLmNvbTwvYT4gJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86 b2xlc2hpaXdvb2RAZ21haWwuY29tIiB0YXJnZXQ9Il9ibGFuayI+b2xlc2hpaXdvb2RAZ21haWwu Y29tPC9hPiZndDsmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86b2xlc2hpaXdv b2RAZ21haWwuY29tIiB0YXJnZXQ9Il9ibGFuayI+b2xlc2hpaXdvb2RAZ21haWwuY29tPC9hPiAm bHQ7bWFpbHRvOjxhIGhyZWY9Im1haWx0bzpvbGVzaGlpd29vZEBnbWFpbC5jb20iIHRhcmdldD0i X2JsYW5rIj5vbGVzaGlpd29vZEBnbWFpbC5jb208L2E+Jmd0OyAmbHQ7bWFpbHRvOjxhIGhyZWY9 Im1haWx0bzpvbGVzaGlpd29vZEBnbWFpbC5jb20iIHRhcmdldD0iX2JsYW5rIj5vbGVzaGlpd29v ZEBnbWFpbC5jb208L2E+ICZsdDttYWlsdG86PGEgaHJlZj0ibWFpbHRvOm9sZXNoaWl3b29kQGdt YWlsLmNvbSIgdGFyZ2V0PSJfYmxhbmsiPm9sZXNoaWl3b29kQGdtYWlsLmNvbTwvYT4mZ3Q7Jmd0 OyZndDsmZ3Q7Ojxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqBUaGFua3MgTWljaGFsLDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqBZb3UgZ2F2ZSBtZSBhbiBpZGVhLjxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvC oCDCoCDCoEkgYW0gZ29pbmcgdG8gdHJ5IGl0IHRvZGF5Ljxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDs8 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqBSZWdhcmRzLDxicj4NCiZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoE8uPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvC oCDCoCDCoNGH0YIsIDIwINCw0L/RgC4gMjAyM+KAr9CzLiDQsiAxMTo1NiwgT2xlZyBOaWtpdGVu a28gJmx0OzxhIGhyZWY9Im1haWx0bzpvbGVzaGlpd29vZEBnbWFpbC5jb20iIHRhcmdldD0iX2Js YW5rIj5vbGVzaGlpd29vZEBnbWFpbC5jb208L2E+ICZsdDttYWlsdG86PGEgaHJlZj0ibWFpbHRv Om9sZXNoaWl3b29kQGdtYWlsLmNvbSIgdGFyZ2V0PSJfYmxhbmsiPm9sZXNoaWl3b29kQGdtYWls LmNvbTwvYT4mZ3Q7ICZsdDttYWlsdG86PGEgaHJlZj0ibWFpbHRvOm9sZXNoaWl3b29kQGdtYWls LmNvbSIgdGFyZ2V0PSJfYmxhbmsiPm9sZXNoaWl3b29kQGdtYWlsLmNvbTwvYT4gJmx0O21haWx0 bzo8YSBocmVmPSJtYWlsdG86b2xlc2hpaXdvb2RAZ21haWwuY29tIiB0YXJnZXQ9Il9ibGFuayI+ b2xlc2hpaXdvb2RAZ21haWwuY29tPC9hPiZndDsmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmx0O21haWx0bzo8YSBocmVm PSJtYWlsdG86b2xlc2hpaXdvb2RAZ21haWwuY29tIiB0YXJnZXQ9Il9ibGFuayI+b2xlc2hpaXdv b2RAZ21haWwuY29tPC9hPiAmbHQ7bWFpbHRvOjxhIGhyZWY9Im1haWx0bzpvbGVzaGlpd29vZEBn bWFpbC5jb20iIHRhcmdldD0iX2JsYW5rIj5vbGVzaGlpd29vZEBnbWFpbC5jb208L2E+Jmd0OyAm bHQ7bWFpbHRvOjxhIGhyZWY9Im1haWx0bzpvbGVzaGlpd29vZEBnbWFpbC5jb20iIHRhcmdldD0i X2JsYW5rIj5vbGVzaGlpd29vZEBnbWFpbC5jb208L2E+ICZsdDttYWlsdG86PGEgaHJlZj0ibWFp bHRvOm9sZXNoaWl3b29kQGdtYWlsLmNvbSIgdGFyZ2V0PSJfYmxhbmsiPm9sZXNoaWl3b29kQGdt YWlsLmNvbTwvYT4mZ3Q7Jmd0OyZndDsmZ3Q7Ojxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDs8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqBUaGFua3MgU3RlZmFuby48YnI+DQomZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgSSBhbSBnb2luZyB0 byBkbyBpdCB0b2RheS48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgIMKgUmVnYXJkcyw8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAg wqBPLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAgwqDRgdGALCAxOSDQsNC/0YAuIDIwMjPigK/Qsy4g0LIgMjM6MDUsIFN0ZWZhbm8gU3RhYmVs bGluaSAmbHQ7PGEgaHJlZj0ibWFpbHRvOnNzdGFiZWxsaW5pQGtlcm5lbC5vcmciIHRhcmdldD0i X2JsYW5rIj5zc3RhYmVsbGluaUBrZXJuZWwub3JnPC9hPiAmbHQ7bWFpbHRvOjxhIGhyZWY9Im1h aWx0bzpzc3RhYmVsbGluaUBrZXJuZWwub3JnIiB0YXJnZXQ9Il9ibGFuayI+c3N0YWJlbGxpbmlA a2VybmVsLm9yZzwvYT4mZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmx0O21h aWx0bzo8YSBocmVmPSJtYWlsdG86c3N0YWJlbGxpbmlAa2VybmVsLm9yZyIgdGFyZ2V0PSJfYmxh bmsiPnNzdGFiZWxsaW5pQGtlcm5lbC5vcmc8L2E+ICZsdDttYWlsdG86PGEgaHJlZj0ibWFpbHRv OnNzdGFiZWxsaW5pQGtlcm5lbC5vcmciIHRhcmdldD0iX2JsYW5rIj5zc3RhYmVsbGluaUBrZXJu ZWwub3JnPC9hPiZndDsmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86c3N0YWJl bGxpbmlAa2VybmVsLm9yZyIgdGFyZ2V0PSJfYmxhbmsiPnNzdGFiZWxsaW5pQGtlcm5lbC5vcmc8 L2E+ICZsdDttYWlsdG86PGEgaHJlZj0ibWFpbHRvOnNzdGFiZWxsaW5pQGtlcm5lbC5vcmciIHRh cmdldD0iX2JsYW5rIj5zc3RhYmVsbGluaUBrZXJuZWwub3JnPC9hPiZndDsgJmx0O21haWx0bzo8 YSBocmVmPSJtYWlsdG86c3N0YWJlbGxpbmlAa2VybmVsLm9yZyIgdGFyZ2V0PSJfYmxhbmsiPnNz dGFiZWxsaW5pQGtlcm5lbC5vcmc8L2E+ICZsdDttYWlsdG86PGEgaHJlZj0ibWFpbHRvOnNzdGFi ZWxsaW5pQGtlcm5lbC5vcmciIHRhcmdldD0iX2JsYW5rIj5zc3RhYmVsbGluaUBrZXJuZWwub3Jn PC9hPiZndDsmZ3Q7Jmd0OyZndDs6PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoE9uIFdlZCwgMTkgQXByIDIwMjMsIE9sZWcgTmlr aXRlbmtvIHdyb3RlOjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZn dDsgSGkgTWljaGFsLDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZn dDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7IEkgY29ycmVj dGVkIHhlbiYjMzk7cyBjb21tYW5kIGxpbmUuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgIMKgIMKgIMKgJmd0OyBOb3cgaXQgaXM8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAgwqAgwqAgwqAmZ3Q7IHhlbix4ZW4tYm9vdGFyZ3MgPSAmcXVvdDtjb25zb2xlPWR0dWFydCBk dHVhcnQ9c2VyaWFsMCBkb20wX21lbT0xNjAwTSBkb20wX21heF92Y3B1cz0yPGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgZG9tMF92Y3B1c19waW48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBib290c2NydWI9MCB2d2Zp PW5hdGl2ZSBzY2hlZD1udWxsPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKg IMKgJmd0OyB0aW1lcl9zbG9wPTAgd2F5X3NpemU9NjU1MzYgeGVuX2NvbG9ycz0wLTMgZG9tMF9j b2xvcnM9NC03JnF1b3Q7Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqA0IGNvbG9ycyBpcyB3YXkgdG9vIG1hbnkgZm9yIHhlbiwg anVzdCBkbyB4ZW5fY29sb3JzPTAtMC4gVGhlcmUgaXMgbm88YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAgwqAgwqAgwqBhZHZhbnRhZ2UgaW4gdXNpbmcgbW9yZSB0aGFuIDEgY29sb3Ig Zm9yIFhlbi48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgIMKgIMKgIMKgNCBjb2xvcnMgaXMgdG9vIGZldyBmb3IgZG9tMCwgaWYgeW91IGFyZSBn aXZpbmcgMTYwME0gb2YgbWVtb3J5IHRvIERvbTAuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgIMKgIMKgIMKgRWFjaCBjb2xvciBpcyAyNTZNLiBGb3IgMTYwME0geW91IHNob3VsZCBn aXZlIGF0IGxlYXN0IDcgY29sb3JzLiBUcnk6PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0Ozxicj4NCiZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoHhlbl9jb2xvcnM9MC0wIGRvbTBfY29s b3JzPTEtODxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7PGJyPg0K Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDC oCZndDsgVW5mb3J0dW5hdGVseSB0aGUgcmVzdWx0IHdhcyB0aGUgc2FtZS48YnI+DQomZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgIMKgIMKgIMKgJmd0OyAoWEVOKSDCoC0gRG9tMCBtb2RlOiBSZWxheGVkPGJyPg0K Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0OyAoWEVOKSBQMk06IDQwLWJp dCBJUEEgd2l0aCA0MC1iaXQgUEEgYW5kIDgtYml0IFZNSUQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7IChYRU4pIFAyTTogMyBsZXZlbHMgd2l0aCBvcmRlci0x IHJvb3QsIFZUQ1IgMHgwMDAwMDAwMDgwMDIzNTU4PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgIMKgIMKgIMKgJmd0OyAoWEVOKSBTY2hlZHVsaW5nIGdyYW51bGFyaXR5OiBjcHUsIDEg Q1BVIHBlciBzY2hlZC1yZXNvdXJjZTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDC oCDCoCDCoCZndDsgKFhFTikgQ29sb3JpbmcgZ2VuZXJhbCBpbmZvcm1hdGlvbjxicj4NCiZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDsgKFhFTikgV2F5IHNpemU6IDY0a0I8 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7IChYRU4pIE1heC4g bnVtYmVyIG9mIGNvbG9ycyBhdmFpbGFibGU6IDE2PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgIMKgIMKgIMKgJmd0OyAoWEVOKSBYZW4gY29sb3Iocyk6IFsgMCBdPGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0OyAoWEVOKSBhbHRlcm5hdGl2ZXM6IFBh dGNoaW5nIHdpdGggYWx0IHRhYmxlIDAwMDAwMDAwMDAyY2M2OTAgLSZndDsgMDAwMDAwMDAwMDJj Y2MwYzxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDsgKFhFTikg Q29sb3IgYXJyYXkgYWxsb2NhdGlvbiBmYWlsZWQgZm9yIGRvbTA8YnI+DQomZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7IChYRU4pPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgIMKgIMKgIMKgJmd0OyAoWEVOKSAqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0 OyAoWEVOKSBQYW5pYyBvbiBDUFUgMDo8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAg wqAgwqAgwqAmZ3Q7IChYRU4pIEVycm9yIGNyZWF0aW5nIGRvbWFpbiAwPGJyPg0KJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0OyAoWEVOKSAqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKg IMKgIMKgJmd0OyAoWEVOKTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDC oCZndDsgKFhFTikgUmVib290IGluIGZpdmUgc2Vjb25kcy4uLjxicj4NCiZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAgwqAgwqAgwqAmZ3Q7IEkgYW0gZ29pbmcgdG8gZmluZCBvdXQgaG93IGNvbW1hbmQgbGluZSBh cmd1bWVudHMgcGFzc2VkIGFuZCBwYXJzZWQuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDC oCZndDsgUmVnYXJkcyw8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAm Z3Q7IE9sZWc8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7PGJy Pg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0OyDRgdGALCAxOSDQsNC/ 0YAuIDIwMjPigK/Qsy4g0LIgMTE6MjUsIE9sZWcgTmlraXRlbmtvICZsdDs8YSBocmVmPSJtYWls dG86b2xlc2hpaXdvb2RAZ21haWwuY29tIiB0YXJnZXQ9Il9ibGFuayI+b2xlc2hpaXdvb2RAZ21h aWwuY29tPC9hPiAmbHQ7bWFpbHRvOjxhIGhyZWY9Im1haWx0bzpvbGVzaGlpd29vZEBnbWFpbC5j b20iIHRhcmdldD0iX2JsYW5rIj5vbGVzaGlpd29vZEBnbWFpbC5jb208L2E+Jmd0Ozxicj4NCiZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZsdDttYWlsdG86PGEgaHJlZj0ibWFpbHRvOm9sZXNo aWl3b29kQGdtYWlsLmNvbSIgdGFyZ2V0PSJfYmxhbmsiPm9sZXNoaWl3b29kQGdtYWlsLmNvbTwv YT4gJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86b2xlc2hpaXdvb2RAZ21haWwuY29tIiB0YXJn ZXQ9Il9ibGFuayI+b2xlc2hpaXdvb2RAZ21haWwuY29tPC9hPiZndDsmZ3Q7PGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmx0O21h aWx0bzo8YSBocmVmPSJtYWlsdG86b2xlc2hpaXdvb2RAZ21haWwuY29tIiB0YXJnZXQ9Il9ibGFu ayI+b2xlc2hpaXdvb2RAZ21haWwuY29tPC9hPiAmbHQ7bWFpbHRvOjxhIGhyZWY9Im1haWx0bzpv bGVzaGlpd29vZEBnbWFpbC5jb20iIHRhcmdldD0iX2JsYW5rIj5vbGVzaGlpd29vZEBnbWFpbC5j b208L2E+Jmd0OyAmbHQ7bWFpbHRvOjxhIGhyZWY9Im1haWx0bzpvbGVzaGlpd29vZEBnbWFpbC5j b20iIHRhcmdldD0iX2JsYW5rIj5vbGVzaGlpd29vZEBnbWFpbC5jb208L2E+ICZsdDttYWlsdG86 PGEgaHJlZj0ibWFpbHRvOm9sZXNoaWl3b29kQGdtYWlsLmNvbSIgdGFyZ2V0PSJfYmxhbmsiPm9s ZXNoaWl3b29kQGdtYWlsLmNvbTwvYT4mZ3Q7Jmd0OyZndDsmZ3Q7Ojxicj4NCiZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoEhpIE1pY2hhbCw8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0OyBZb3UgcHV0IG15IG5vc2UgaW50byB0aGUgcHJv YmxlbS4gVGhhbmsgeW91Ljxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDC oCZndDsgSSBhbSBnb2luZyB0byB1c2UgeW91ciBwb2ludC48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7IExldCYjMzk7cyBzZWUgd2hhdCBoYXBwZW5zLjxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7IFJlZ2FyZHMsPGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0OyBPbGVnPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDC oCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7 INGB0YAsIDE5INCw0L/RgC4gMjAyM+KAr9CzLiDQsiAxMDozNywgTWljaGFsIE9yemVsICZsdDs8 YSBocmVmPSJtYWlsdG86bWljaGFsLm9yemVsQGFtZC5jb20iIHRhcmdldD0iX2JsYW5rIj5taWNo YWwub3J6ZWxAYW1kLmNvbTwvYT4gJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86bWljaGFsLm9y emVsQGFtZC5jb20iIHRhcmdldD0iX2JsYW5rIj5taWNoYWwub3J6ZWxAYW1kLmNvbTwvYT4mZ3Q7 PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmx0O21haWx0bzo8YSBocmVmPSJtYWls dG86bWljaGFsLm9yemVsQGFtZC5jb20iIHRhcmdldD0iX2JsYW5rIj5taWNoYWwub3J6ZWxAYW1k LmNvbTwvYT4gJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86bWljaGFsLm9yemVsQGFtZC5jb20i IHRhcmdldD0iX2JsYW5rIj5taWNoYWwub3J6ZWxAYW1kLmNvbTwvYT4mZ3Q7Jmd0Ozxicj4NCiZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZs dDttYWlsdG86PGEgaHJlZj0ibWFpbHRvOm1pY2hhbC5vcnplbEBhbWQuY29tIiB0YXJnZXQ9Il9i bGFuayI+bWljaGFsLm9yemVsQGFtZC5jb208L2E+ICZsdDttYWlsdG86PGEgaHJlZj0ibWFpbHRv Om1pY2hhbC5vcnplbEBhbWQuY29tIiB0YXJnZXQ9Il9ibGFuayI+bWljaGFsLm9yemVsQGFtZC5j b208L2E+Jmd0OyAmbHQ7bWFpbHRvOjxhIGhyZWY9Im1haWx0bzptaWNoYWwub3J6ZWxAYW1kLmNv bSIgdGFyZ2V0PSJfYmxhbmsiPm1pY2hhbC5vcnplbEBhbWQuY29tPC9hPiAmbHQ7bWFpbHRvOjxh IGhyZWY9Im1haWx0bzptaWNoYWwub3J6ZWxAYW1kLmNvbSIgdGFyZ2V0PSJfYmxhbmsiPm1pY2hh bC5vcnplbEBhbWQuY29tPC9hPiZndDsmZ3Q7Jmd0OyZndDs6PGJyPg0KJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgSGkgT2xlZyw8YnI+DQomZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgT24gMTkvMDQvMjAyMyAwOTowMywgT2xl ZyBOaWtpdGVua28gd3JvdGU6PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IEhlbGxvIFN0ZWZh bm8sPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgVGhhbmtzIGZvciB0aGUgY2xhcmlmaWNhdGlvbi48YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IE15IGNvbXBhbnkg dXNlcyB5b2N0byBmb3IgaW1hZ2UgZ2VuZXJhdGlvbi48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFdoYXQga2luZCBvZiBpbmZvcm1h dGlvbiBkbyB5b3UgbmVlZCB0byBjb25zdWx0IG1lIGluIHRoaXMgY2FzZSA/PGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgTWF5 YmUgbW9kdWxlcyBzaXplcy9hZGRyZXNzZXMgd2hpY2ggd2VyZSBtZW50aW9uZWQgYnkgQEp1bGll biBHcmFsbDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZs dDttYWlsdG86PGEgaHJlZj0ibWFpbHRvOmp1bGllbkB4ZW4ub3JnIiB0YXJnZXQ9Il9ibGFuayI+ anVsaWVuQHhlbi5vcmc8L2E+ICZsdDttYWlsdG86PGEgaHJlZj0ibWFpbHRvOmp1bGllbkB4ZW4u b3JnIiB0YXJnZXQ9Il9ibGFuayI+anVsaWVuQHhlbi5vcmc8L2E+Jmd0Ozxicj4NCiZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZsdDttYWls dG86PGEgaHJlZj0ibWFpbHRvOmp1bGllbkB4ZW4ub3JnIiB0YXJnZXQ9Il9ibGFuayI+anVsaWVu QHhlbi5vcmc8L2E+ICZsdDttYWlsdG86PGEgaHJlZj0ibWFpbHRvOmp1bGllbkB4ZW4ub3JnIiB0 YXJnZXQ9Il9ibGFuayI+anVsaWVuQHhlbi5vcmc8L2E+Jmd0OyZndDsgJmx0O21haWx0bzo8YSBo cmVmPSJtYWlsdG86anVsaWVuQHhlbi5vcmciIHRhcmdldD0iX2JsYW5rIj5qdWxpZW5AeGVuLm9y ZzwvYT4gJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86anVsaWVuQHhlbi5vcmciIHRhcmdldD0i X2JsYW5rIj5qdWxpZW5AeGVuLm9yZzwvYT4mZ3Q7ICZsdDttYWlsdG86PGEgaHJlZj0ibWFpbHRv Omp1bGllbkB4ZW4ub3JnIiB0YXJnZXQ9Il9ibGFuayI+anVsaWVuQHhlbi5vcmc8L2E+ICZsdDtt YWlsdG86PGEgaHJlZj0ibWFpbHRvOmp1bGllbkB4ZW4ub3JnIiB0YXJnZXQ9Il9ibGFuayI+anVs aWVuQHhlbi5vcmc8L2E+Jmd0OyZndDsmZ3Q7Jmd0OyA/PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoFNvcnJ5IGZvciBqdW1waW5nIGludG8gZGlzY3Vzc2lvbiwg YnV0IEZXSUNTIHRoZSBYZW4gY29tbWFuZCBsaW5lIHlvdSBwcm92aWRlZDxicj4NCiZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoHNlZW1zIHRvIGJlPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgbm90IHRoZTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoG9uZTxicj4NCiZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoFhlbiBib290ZWQgd2l0aC4gVGhl IGVycm9yIHlvdSBhcmUgb2JzZXJ2aW5nIG1vc3QgbGlrZWx5IGlzIGR1ZSB0byBkb20wIGNvbG9y czxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoGNvbmZpZ3Vy YXRpb24gbm90PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgYmVpbmc8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqBzcGVjaWZpZWQgKGkuZS4gbGFjayBvZiBkb20wX2NvbG9ycz0m bHQ7Jmd0OyBwYXJhbWV0ZXIpLiBBbHRob3VnaCBpbiB0aGUgY29tbWFuZCBsaW5lIHlvdTxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoHByb3ZpZGVkLCB0aGlz PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgcGFyYW1ldGVyPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgaXMgc2V0LCBJIHN0cm9uZ2x5IGRvdWJ0IHRoYXQgdGhpcyBpcyB0aGUg YWN0dWFsIGNvbW1hbmQgbGluZSBpbiB1c2UuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoFlvdSB3cm90ZTo8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqB4ZW4seGVuLWJvb3RhcmdzID0gJnF1b3Q7Y29uc29s ZT1kdHVhcnQgZHR1YXJ0PXNlcmlhbDAgZG9tMF9tZW09MTYwME0gZG9tMF9tYXhfdmNwdXM9Mjxi cj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoGRvbTBfdmNwdXNf cGluPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgYm9vdHNjcnViPTAgdndmaT1uYXRpdmU8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBzY2hlZD1udWxsIHRpbWVyX3Nsb3A9MCB3 YXlfc3ppemU9NjU1MzYgeGVuX2NvbG9ycz0wLTMgZG9tMF9jb2xvcnM9NC03JnF1b3Q7Ozxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBidXQ6PGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgMSkgd2F5X3N6aXpl IGhhcyBhIHR5cG88YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAyKSB5b3Ugc3BlY2lmaWVkIDQgY29sb3JzICgwLTMpIGZvciBYZW4sIGJ1dCB0 aGUgYm9vdCBsb2cgc2F5cyB0aGF0IFhlbiBoYXMgb25seTxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoG9uZTo8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAoWEVOKSBYZW4gY29sb3Iocyk6IFsgMCBdPGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoFRoaXMgbWFrZXMgbWUgYmVsaWV2ZSB0aGF0IG5v IGNvbG9ycyBjb25maWd1cmF0aW9uIGFjdHVhbGx5IGVuZCB1cCBpbiBjb21tYW5kIGxpbmU8YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqB0aGF0IFhlbjxicj4NCiZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoGJvb3RlZDxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoHdpdGguPGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgU2luZ2xlIGNvbG9y IGZvciBYZW4gaXMgYSAmcXVvdDtkZWZhdWx0IGlmIG5vdCBzcGVjaWZpZWQmcXVvdDsgYW5kIHdh eSBzaXplIHdhcyBwcm9iYWJseTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoGNhbGN1 bGF0ZWQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBieSBh c2tpbmc8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqBIVy48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAm Z3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgU28gSSB3b3VsZCBzdWdnZXN0IHRvIGZpcnN0IGNyb3NzLWNoZWNrIHRoZSBjb21tYW5kIGxp bmUgaW4gdXNlLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDs8 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqB+ TWljaGFsPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0Ozxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBSZWdhcmRz LDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgT2xlZzxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7INCy0YIsIDE4INCw0L/RgC4gMjAyM+KAr9CzLiDQsiAyMDo0NCwg U3RlZmFubyBTdGFiZWxsaW5pICZsdDs8YSBocmVmPSJtYWlsdG86c3N0YWJlbGxpbmlAa2VybmVs Lm9yZyIgdGFyZ2V0PSJfYmxhbmsiPnNzdGFiZWxsaW5pQGtlcm5lbC5vcmc8L2E+ICZsdDttYWls dG86PGEgaHJlZj0ibWFpbHRvOnNzdGFiZWxsaW5pQGtlcm5lbC5vcmciIHRhcmdldD0iX2JsYW5r Ij5zc3RhYmVsbGluaUBrZXJuZWwub3JnPC9hPiZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmbHQ7bWFpbHRvOjxhIGhyZWY9 Im1haWx0bzpzc3RhYmVsbGluaUBrZXJuZWwub3JnIiB0YXJnZXQ9Il9ibGFuayI+c3N0YWJlbGxp bmlAa2VybmVsLm9yZzwvYT4gJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86c3N0YWJlbGxpbmlA a2VybmVsLm9yZyIgdGFyZ2V0PSJfYmxhbmsiPnNzdGFiZWxsaW5pQGtlcm5lbC5vcmc8L2E+Jmd0 OyZndDsgJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86c3N0YWJlbGxpbmlAa2VybmVsLm9yZyIg dGFyZ2V0PSJfYmxhbmsiPnNzdGFiZWxsaW5pQGtlcm5lbC5vcmc8L2E+ICZsdDttYWlsdG86PGEg aHJlZj0ibWFpbHRvOnNzdGFiZWxsaW5pQGtlcm5lbC5vcmciIHRhcmdldD0iX2JsYW5rIj5zc3Rh YmVsbGluaUBrZXJuZWwub3JnPC9hPiZndDsgJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86c3N0 YWJlbGxpbmlAa2VybmVsLm9yZyIgdGFyZ2V0PSJfYmxhbmsiPnNzdGFiZWxsaW5pQGtlcm5lbC5v cmc8L2E+ICZsdDttYWlsdG86PGEgaHJlZj0ibWFpbHRvOnNzdGFiZWxsaW5pQGtlcm5lbC5vcmci IHRhcmdldD0iX2JsYW5rIj5zc3RhYmVsbGluaUBrZXJuZWwub3JnPC9hPiZndDsmZ3Q7Jmd0Ozxi cj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZsdDttYWlsdG86 PGEgaHJlZj0ibWFpbHRvOnNzdGFiZWxsaW5pQGtlcm5lbC5vcmciIHRhcmdldD0iX2JsYW5rIj5z c3RhYmVsbGluaUBrZXJuZWwub3JnPC9hPiAmbHQ7bWFpbHRvOjxhIGhyZWY9Im1haWx0bzpzc3Rh YmVsbGluaUBrZXJuZWwub3JnIiB0YXJnZXQ9Il9ibGFuayI+c3N0YWJlbGxpbmlAa2VybmVsLm9y ZzwvYT4mZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86c3N0YWJlbGxpbmlAa2Vy bmVsLm9yZyIgdGFyZ2V0PSJfYmxhbmsiPnNzdGFiZWxsaW5pQGtlcm5lbC5vcmc8L2E+ICZsdDtt YWlsdG86PGEgaHJlZj0ibWFpbHRvOnNzdGFiZWxsaW5pQGtlcm5lbC5vcmciIHRhcmdldD0iX2Js YW5rIj5zc3RhYmVsbGluaUBrZXJuZWwub3JnPC9hPiZndDsmZ3Q7ICZsdDttYWlsdG86PGEgaHJl Zj0ibWFpbHRvOnNzdGFiZWxsaW5pQGtlcm5lbC5vcmciIHRhcmdldD0iX2JsYW5rIj5zc3RhYmVs bGluaUBrZXJuZWwub3JnPC9hPiAmbHQ7bWFpbHRvOjxhIGhyZWY9Im1haWx0bzpzc3RhYmVsbGlu aUBrZXJuZWwub3JnIiB0YXJnZXQ9Il9ibGFuayI+c3N0YWJlbGxpbmlAa2VybmVsLm9yZzwvYT4m Z3Q7ICZsdDttYWlsdG86PGEgaHJlZj0ibWFpbHRvOnNzdGFiZWxsaW5pQGtlcm5lbC5vcmciIHRh cmdldD0iX2JsYW5rIj5zc3RhYmVsbGluaUBrZXJuZWwub3JnPC9hPiAmbHQ7bWFpbHRvOjxhIGhy ZWY9Im1haWx0bzpzc3RhYmVsbGluaUBrZXJuZWwub3JnIiB0YXJnZXQ9Il9ibGFuayI+c3N0YWJl bGxpbmlAa2VybmVsLm9yZzwvYT4mZ3Q7Jmd0OyZndDsmZ3Q7Jmd0Ozo8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg T24gVHVlLCAxOCBBcHIgMjAyMywgT2xlZyBOaWtpdGVua28gd3JvdGU6PGJyPg0KJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0 OyBIaSBKdWxpZW4sPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDsgJmd0OyZndDsgVGhp cyBmZWF0dXJlIGhhcyBub3QgYmVlbiBtZXJnZWQgaW4gWGVuIHVwc3RyZWFtIHlldDxicj4NCiZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7ICZndDsgd291bGQgYXNzdW1lIHRoYXQgdXBzdHJlYW0g KyB0aGUgc2VyaWVzIG9uIHRoZSBNTCBbMV0gd29yazxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDs8YnI+DQomZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAmZ3Q7IFBsZWFzZSBjbGFyaWZ5IHRoaXMgcG9pbnQuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0OyBCZWNhdXNl IHRoZSB0d28gdGhvdWdodHMgYXJlIGNvbnRyb3ZlcnNpYWwuPGJyPg0KJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoEhpIE9s ZWcsPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoEFzIEp1bGllbiB3cm90ZSwgdGhlcmUgaXMgbm90aGluZyBjb250 cm92ZXJzaWFsLiBBcyB5b3UgYXJlIGF3YXJlLDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoFhpbGlueCBtYWludGFpbnMg YSBzZXBhcmF0ZSBYZW4gdHJlZSBzcGVjaWZpYyBmb3IgWGlsaW54IGhlcmU6PGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg PGEgaHJlZj0iaHR0cHM6Ly9naXRodWIuY29tL3hpbGlueC94ZW4iIHJlbD0ibm9yZWZlcnJlciIg dGFyZ2V0PSJfYmxhbmsiPmh0dHBzOi8vZ2l0aHViLmNvbS94aWxpbngveGVuPC9hPiAmbHQ7PGEg aHJlZj0iaHR0cHM6Ly9naXRodWIuY29tL3hpbGlueC94ZW4iIHJlbD0ibm9yZWZlcnJlciIgdGFy Z2V0PSJfYmxhbmsiPmh0dHBzOi8vZ2l0aHViLmNvbS94aWxpbngveGVuPC9hPiZndDsgJmx0Ozxh IGhyZWY9Imh0dHBzOi8vZ2l0aHViLmNvbS94aWxpbngveGVuIiByZWw9Im5vcmVmZXJyZXIiIHRh cmdldD0iX2JsYW5rIj5odHRwczovL2dpdGh1Yi5jb20veGlsaW54L3hlbjwvYT4gJmx0OzxhIGhy ZWY9Imh0dHBzOi8vZ2l0aHViLmNvbS94aWxpbngveGVuIiByZWw9Im5vcmVmZXJyZXIiIHRhcmdl dD0iX2JsYW5rIj5odHRwczovL2dpdGh1Yi5jb20veGlsaW54L3hlbjwvYT4mZ3Q7Jmd0Ozxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZsdDs8YSBocmVmPSJo dHRwczovL2dpdGh1Yi5jb20veGlsaW54L3hlbiIgcmVsPSJub3JlZmVycmVyIiB0YXJnZXQ9Il9i bGFuayI+aHR0cHM6Ly9naXRodWIuY29tL3hpbGlueC94ZW48L2E+ICZsdDs8YSBocmVmPSJodHRw czovL2dpdGh1Yi5jb20veGlsaW54L3hlbiIgcmVsPSJub3JlZmVycmVyIiB0YXJnZXQ9Il9ibGFu ayI+aHR0cHM6Ly9naXRodWIuY29tL3hpbGlueC94ZW48L2E+Jmd0Ozxicj4NCiZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZsdDs8YSBocmVm PSJodHRwczovL2dpdGh1Yi5jb20veGlsaW54L3hlbiIgcmVsPSJub3JlZmVycmVyIiB0YXJnZXQ9 Il9ibGFuayI+aHR0cHM6Ly9naXRodWIuY29tL3hpbGlueC94ZW48L2E+ICZsdDs8YSBocmVmPSJo dHRwczovL2dpdGh1Yi5jb20veGlsaW54L3hlbiIgcmVsPSJub3JlZmVycmVyIiB0YXJnZXQ9Il9i bGFuayI+aHR0cHM6Ly9naXRodWIuY29tL3hpbGlueC94ZW48L2E+Jmd0OyZndDsmZ3Q7ICZsdDs8 YSBocmVmPSJodHRwczovL2dpdGh1Yi5jb20veGlsaW54L3hlbiIgcmVsPSJub3JlZmVycmVyIiB0 YXJnZXQ9Il9ibGFuayI+aHR0cHM6Ly9naXRodWIuY29tL3hpbGlueC94ZW48L2E+ICZsdDs8YSBo cmVmPSJodHRwczovL2dpdGh1Yi5jb20veGlsaW54L3hlbiIgcmVsPSJub3JlZmVycmVyIiB0YXJn ZXQ9Il9ibGFuayI+aHR0cHM6Ly9naXRodWIuY29tL3hpbGlueC94ZW48L2E+Jmd0OyAmbHQ7PGEg aHJlZj0iaHR0cHM6Ly9naXRodWIuY29tL3hpbGlueC94ZW4iIHJlbD0ibm9yZWZlcnJlciIgdGFy Z2V0PSJfYmxhbmsiPmh0dHBzOi8vZ2l0aHViLmNvbS94aWxpbngveGVuPC9hPiAmbHQ7PGEgaHJl Zj0iaHR0cHM6Ly9naXRodWIuY29tL3hpbGlueC94ZW4iIHJlbD0ibm9yZWZlcnJlciIgdGFyZ2V0 PSJfYmxhbmsiPmh0dHBzOi8vZ2l0aHViLmNvbS94aWxpbngveGVuPC9hPiZndDsmZ3Q7PGJyPg0K Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmx0OzxhIGhyZWY9Imh0 dHBzOi8vZ2l0aHViLmNvbS94aWxpbngveGVuIiByZWw9Im5vcmVmZXJyZXIiIHRhcmdldD0iX2Js YW5rIj5odHRwczovL2dpdGh1Yi5jb20veGlsaW54L3hlbjwvYT4gJmx0OzxhIGhyZWY9Imh0dHBz Oi8vZ2l0aHViLmNvbS94aWxpbngveGVuIiByZWw9Im5vcmVmZXJyZXIiIHRhcmdldD0iX2JsYW5r Ij5odHRwczovL2dpdGh1Yi5jb20veGlsaW54L3hlbjwvYT4mZ3Q7PGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmx0OzxhIGhyZWY9 Imh0dHBzOi8vZ2l0aHViLmNvbS94aWxpbngveGVuIiByZWw9Im5vcmVmZXJyZXIiIHRhcmdldD0i X2JsYW5rIj5odHRwczovL2dpdGh1Yi5jb20veGlsaW54L3hlbjwvYT4gJmx0OzxhIGhyZWY9Imh0 dHBzOi8vZ2l0aHViLmNvbS94aWxpbngveGVuIiByZWw9Im5vcmVmZXJyZXIiIHRhcmdldD0iX2Js YW5rIj5odHRwczovL2dpdGh1Yi5jb20veGlsaW54L3hlbjwvYT4mZ3Q7Jmd0OyZndDsmZ3Q7PGJy Pg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoGFuZCB0aGUgYnJhbmNoIHlvdSBhcmUgdXNpbmcgKHhsbnhfcmViYXNlXzQu MTYpIGNvbWVzIGZyb20gdGhlcmUuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqBJbnN0ZWFkLCB0aGUgdXBz dHJlYW0gWGVuIHRyZWUgbGl2ZXMgaGVyZTo8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqA8YSBocmVmPSJodHRwczovL3hl bmJpdHMueGVuLm9yZy9naXR3ZWIvP3A9eGVuLmdpdDthPXN1bW1hcnkiIHJlbD0ibm9yZWZlcnJl ciIgdGFyZ2V0PSJfYmxhbmsiPmh0dHBzOi8veGVuYml0cy54ZW4ub3JnL2dpdHdlYi8/cD14ZW4u Z2l0O2E9c3VtbWFyeTwvYT4gJmx0OzxhIGhyZWY9Imh0dHBzOi8veGVuYml0cy54ZW4ub3JnL2dp dHdlYi8/cD14ZW4uZ2l0O2E9c3VtbWFyeSIgcmVsPSJub3JlZmVycmVyIiB0YXJnZXQ9Il9ibGFu ayI+aHR0cHM6Ly94ZW5iaXRzLnhlbi5vcmcvZ2l0d2ViLz9wPXhlbi5naXQ7YT1zdW1tYXJ5PC9h PiZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmbHQ7PGEgaHJlZj0iaHR0cHM6Ly94ZW5iaXRzLnhlbi5vcmcvZ2l0d2ViLz9w PXhlbi5naXQ7YT1zdW1tYXJ5IiByZWw9Im5vcmVmZXJyZXIiIHRhcmdldD0iX2JsYW5rIj5odHRw czovL3hlbmJpdHMueGVuLm9yZy9naXR3ZWIvP3A9eGVuLmdpdDthPXN1bW1hcnk8L2E+ICZsdDs8 YSBocmVmPSJodHRwczovL3hlbmJpdHMueGVuLm9yZy9naXR3ZWIvP3A9eGVuLmdpdDthPXN1bW1h cnkiIHJlbD0ibm9yZWZlcnJlciIgdGFyZ2V0PSJfYmxhbmsiPmh0dHBzOi8veGVuYml0cy54ZW4u b3JnL2dpdHdlYi8/cD14ZW4uZ2l0O2E9c3VtbWFyeTwvYT4mZ3Q7Jmd0OyAmbHQ7PGEgaHJlZj0i aHR0cHM6Ly94ZW5iaXRzLnhlbi5vcmcvZ2l0d2ViLz9wPXhlbi5naXQ7YT1zdW1tYXJ5IiByZWw9 Im5vcmVmZXJyZXIiIHRhcmdldD0iX2JsYW5rIj5odHRwczovL3hlbmJpdHMueGVuLm9yZy9naXR3 ZWIvP3A9eGVuLmdpdDthPXN1bW1hcnk8L2E+ICZsdDs8YSBocmVmPSJodHRwczovL3hlbmJpdHMu eGVuLm9yZy9naXR3ZWIvP3A9eGVuLmdpdDthPXN1bW1hcnkiIHJlbD0ibm9yZWZlcnJlciIgdGFy Z2V0PSJfYmxhbmsiPmh0dHBzOi8veGVuYml0cy54ZW4ub3JnL2dpdHdlYi8/cD14ZW4uZ2l0O2E9 c3VtbWFyeTwvYT4mZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmx0OzxhIGhyZWY9Imh0dHBzOi8veGVuYml0cy54ZW4ub3Jn L2dpdHdlYi8/cD14ZW4uZ2l0O2E9c3VtbWFyeSIgcmVsPSJub3JlZmVycmVyIiB0YXJnZXQ9Il9i bGFuayI+aHR0cHM6Ly94ZW5iaXRzLnhlbi5vcmcvZ2l0d2ViLz9wPXhlbi5naXQ7YT1zdW1tYXJ5 PC9hPiAmbHQ7PGEgaHJlZj0iaHR0cHM6Ly94ZW5iaXRzLnhlbi5vcmcvZ2l0d2ViLz9wPXhlbi5n aXQ7YT1zdW1tYXJ5IiByZWw9Im5vcmVmZXJyZXIiIHRhcmdldD0iX2JsYW5rIj5odHRwczovL3hl bmJpdHMueGVuLm9yZy9naXR3ZWIvP3A9eGVuLmdpdDthPXN1bW1hcnk8L2E+Jmd0OyZndDsmZ3Q7 ICZsdDs8YSBocmVmPSJodHRwczovL3hlbmJpdHMueGVuLm9yZy9naXR3ZWIvP3A9eGVuLmdpdDth PXN1bW1hcnkiIHJlbD0ibm9yZWZlcnJlciIgdGFyZ2V0PSJfYmxhbmsiPmh0dHBzOi8veGVuYml0 cy54ZW4ub3JnL2dpdHdlYi8/cD14ZW4uZ2l0O2E9c3VtbWFyeTwvYT4gJmx0OzxhIGhyZWY9Imh0 dHBzOi8veGVuYml0cy54ZW4ub3JnL2dpdHdlYi8/cD14ZW4uZ2l0O2E9c3VtbWFyeSIgcmVsPSJu b3JlZmVycmVyIiB0YXJnZXQ9Il9ibGFuayI+aHR0cHM6Ly94ZW5iaXRzLnhlbi5vcmcvZ2l0d2Vi Lz9wPXhlbi5naXQ7YT1zdW1tYXJ5PC9hPiZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmbHQ7PGEgaHJlZj0iaHR0cHM6Ly94 ZW5iaXRzLnhlbi5vcmcvZ2l0d2ViLz9wPXhlbi5naXQ7YT1zdW1tYXJ5IiByZWw9Im5vcmVmZXJy ZXIiIHRhcmdldD0iX2JsYW5rIj5odHRwczovL3hlbmJpdHMueGVuLm9yZy9naXR3ZWIvP3A9eGVu LmdpdDthPXN1bW1hcnk8L2E+ICZsdDs8YSBocmVmPSJodHRwczovL3hlbmJpdHMueGVuLm9yZy9n aXR3ZWIvP3A9eGVuLmdpdDthPXN1bW1hcnkiIHJlbD0ibm9yZWZlcnJlciIgdGFyZ2V0PSJfYmxh bmsiPmh0dHBzOi8veGVuYml0cy54ZW4ub3JnL2dpdHdlYi8/cD14ZW4uZ2l0O2E9c3VtbWFyeTwv YT4mZ3Q7Jmd0OyAmbHQ7PGEgaHJlZj0iaHR0cHM6Ly94ZW5iaXRzLnhlbi5vcmcvZ2l0d2ViLz9w PXhlbi5naXQ7YT1zdW1tYXJ5IiByZWw9Im5vcmVmZXJyZXIiIHRhcmdldD0iX2JsYW5rIj5odHRw czovL3hlbmJpdHMueGVuLm9yZy9naXR3ZWIvP3A9eGVuLmdpdDthPXN1bW1hcnk8L2E+ICZsdDs8 YSBocmVmPSJodHRwczovL3hlbmJpdHMueGVuLm9yZy9naXR3ZWIvP3A9eGVuLmdpdDthPXN1bW1h cnkiIHJlbD0ibm9yZWZlcnJlciIgdGFyZ2V0PSJfYmxhbmsiPmh0dHBzOi8veGVuYml0cy54ZW4u b3JnL2dpdHdlYi8/cD14ZW4uZ2l0O2E9c3VtbWFyeTwvYT4mZ3Q7PGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmx0OzxhIGhyZWY9 Imh0dHBzOi8veGVuYml0cy54ZW4ub3JnL2dpdHdlYi8/cD14ZW4uZ2l0O2E9c3VtbWFyeSIgcmVs PSJub3JlZmVycmVyIiB0YXJnZXQ9Il9ibGFuayI+aHR0cHM6Ly94ZW5iaXRzLnhlbi5vcmcvZ2l0 d2ViLz9wPXhlbi5naXQ7YT1zdW1tYXJ5PC9hPiAmbHQ7PGEgaHJlZj0iaHR0cHM6Ly94ZW5iaXRz Lnhlbi5vcmcvZ2l0d2ViLz9wPXhlbi5naXQ7YT1zdW1tYXJ5IiByZWw9Im5vcmVmZXJyZXIiIHRh cmdldD0iX2JsYW5rIj5odHRwczovL3hlbmJpdHMueGVuLm9yZy9naXR3ZWIvP3A9eGVuLmdpdDth PXN1bW1hcnk8L2E+Jmd0OyZndDsmZ3Q7Jmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgVGhlIENhY2hl IENvbG9yaW5nIGZlYXR1cmUgdGhhdCB5b3UgYXJlIHRyeWluZyB0byBjb25maWd1cmUgaXMgcHJl c2VudDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoGluIHhsbnhfcmViYXNlXzQuMTYsIGJ1dCBub3QgeWV0IHByZXNlbnQg dXBzdHJlYW0gKHRoZXJlIGlzIGFuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgb3V0c3RhbmRpbmcgcGF0Y2ggc2VyaWVz IHRvIGFkZCBjYWNoZSBjb2xvcmluZyB0byBYZW4gdXBzdHJlYW0gYnV0IGl0PGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg aGFzbiYjMzk7dCBiZWVuIG1lcmdlZCB5ZXQuKTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgQW55d2F5LCBp ZiB5b3UgYXJlIHVzaW5nIHhsbnhfcmViYXNlXzQuMTYgaXQgZG9lc24mIzM5O3QgbWF0dGVyIHRv byBtdWNoIGZvcjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoHlvdSBhcyB5b3UgYWxyZWFkeSBoYXZlIENhY2hlIENvbG9y aW5nIGFzIGEgZmVhdHVyZSB0aGVyZS48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoEkgdGFrZSB5b3UgYXJl IHVzaW5nIEltYWdlQnVpbGRlciB0byBnZW5lcmF0ZSB0aGUgYm9vdCBjb25maWd1cmF0aW9uPyBJ Zjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoHNvLCBwbGVhc2UgcG9zdCB0aGUgSW1hZ2VCdWlsZGVyIGNvbmZpZyBmaWxl IHRoYXQgeW91IGFyZSB1c2luZy48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgQnV0IGZyb20gdGhlIGJvb3QgbWVz c2FnZSwgaXQgbG9va3MgbGlrZSB0aGUgY29sb3JzIGNvbmZpZ3VyYXRpb24gZm9yPGJyPg0KJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgRG9tMCBpcyBpbmNvcnJlY3QuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAm Z3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0Ozxicj4NCiZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDs8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7IDxicj4NCiZndDsgPGJyPg0KPC9ibG9ja3F1b3RlPjwvZGl2Pg0K --000000000000175b6a05faee4a1e-- From xen-devel-bounces@lists.xenproject.org Fri May 05 09:38:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 09:38:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530274.825793 (Exim 4.92) (envelope-from ) id 1purth-0004UV-E3; Fri, 05 May 2023 09:38:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530274.825793; Fri, 05 May 2023 09:38:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1purth-0004UO-9Q; Fri, 05 May 2023 09:38:41 +0000 Received: by outflank-mailman (input) for mailman id 530274; Fri, 05 May 2023 09:38:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1purtg-0004UI-IO for xen-devel@lists.xen.org; Fri, 05 May 2023 09:38:40 +0000 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [2607:f8b0:4864:20::62e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9cf5b330-eb28-11ed-b226-6b7b168915f2; Fri, 05 May 2023 11:38:39 +0200 (CEST) Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1aae46e62e9so10933755ad.2 for ; Fri, 05 May 2023 02:38:39 -0700 (PDT) Received: from localhost ([122.172.85.8]) by smtp.gmail.com with ESMTPSA id j3-20020a63fc03000000b005140ce70582sm1225493pgi.44.2023.05.05.02.38.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 May 2023 02:38:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9cf5b330-eb28-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683279518; x=1685871518; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WaG+8ofRnnd64SI0wvpySFG9n+vU2w5MynZBpHLEkRw=; b=AgxI2FxlRg1mgszxPM93IGao7P+5a85jLdYesRgNPJ4Uk5ie5AM06VZszJaN91M+Xr le0HRmV+YUrfkE8h/LsxoE8Rk6HNh6+dJ+AaJCqg9JIm1g1I8BXNu/2PK8C0aYz1c/xY rdn5JdW99zMW/OgIpQgcsI0/hYa1oLAf20FJZmvjD+ncA3u8+y8UC79ph6yvF1/I3W6+ Z9bFhUfud89AQd3b2wVqG0rLGXFXQZ+wU3V+oTD4bDPAvJrNdHBB+kw0pbcxUoRLgW94 7//4r8LQLnG4jPF1+HOuQjcNwxs1WOkv5dKNJm+0IcKpOmWi0tWaxfkkaCg5/qWjV2Nu z6pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683279518; x=1685871518; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WaG+8ofRnnd64SI0wvpySFG9n+vU2w5MynZBpHLEkRw=; b=icUp3N0FKsw7dQViFinsbM24BhbQsosW32zMDcbig2Tst0y0/xvyiAc1JI/++QVYJh s2r5FtNGToxbCFNIe6qh3OljQCPAM4zYKHN/QqakJisyPtd4dCPD4j7yoSujQZz2yprH HGAmgj/yRsyV7uzOu7rhjhvBDncu+JltjTxZ98I9eKPoD36ZsjMIl67j0zcz0i0D/SvL NzuiSjNPDK8d94GSY5T+Dy+HI29Os4vJoJOEW/cGR7psajWI/gmCJckF/MILZvXXDZu5 zGBh9S602LI5Pk1IXooaO3ABeZwkfXbaVAqWnclUQw1Zpqhh92sPpJA7wNJG8FLd0bCt ccZw== X-Gm-Message-State: AC+VfDy9b8ZmxfWT5utcF5g3rmwz8+44cEzD2LWARqrquTaKk+d9XITs 0v6lSdVilbETOzqDLpx0F22Twg== X-Google-Smtp-Source: ACHHUZ4hkv3ImU5k++gFOf4/s2vPNYkPVZABtqaSq1SwoIqfgDQ4FUodHC/24r9E5PzsZRunFUo2LQ== X-Received: by 2002:a17:903:120d:b0:1a5:2993:8aa6 with SMTP id l13-20020a170903120d00b001a529938aa6mr889555plh.63.1683279517711; Fri, 05 May 2023 02:38:37 -0700 (PDT) Date: Fri, 5 May 2023 15:08:35 +0530 From: Viresh Kumar To: Anthony PERARD Cc: xen-devel@lists.xen.org, Juergen Gross , Julien Grall , Vincent Guittot , stratos-dev@op-lists.linaro.org, Alex =?utf-8?Q?Benn=C3=A9e?= , Mathieu Poirier , Oleksandr Tyshchenko , Erik Schilling Subject: Re: [PATCH] libxl: arm: Allow grant mappings for backends running on Dom0 Message-ID: <20230505093835.jcbwo6zjk5hcjvsm@vireshk-i7> References: <817f0320316dd144826add0ac834618026b91160.1680165772.git.viresh.kumar@linaro.org> <92c7f972-f617-40fc-bc5d-582c8154d03c@perard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <92c7f972-f617-40fc-bc5d-582c8154d03c@perard> Hi Anthony, On 02-05-23, 15:44, Anthony PERARD wrote: > > diff --git a/tools/libs/light/libxl_virtio.c b/tools/libs/light/libxl_virtio.c > > index faada49e184e..e1f15344ef97 100644 > > --- a/tools/libs/light/libxl_virtio.c > > +++ b/tools/libs/light/libxl_virtio.c > > @@ -48,11 +48,13 @@ static int libxl__set_xenstore_virtio(libxl__gc *gc, uint32_t domid, > > flexarray_append_pair(back, "base", GCSPRINTF("%#"PRIx64, virtio->base)); > > flexarray_append_pair(back, "type", GCSPRINTF("%s", virtio->type)); > > flexarray_append_pair(back, "transport", GCSPRINTF("%s", transport)); > > + flexarray_append_pair(back, "forced_grant", GCSPRINTF("%u", virtio->forced_grant)); > > > > flexarray_append_pair(front, "irq", GCSPRINTF("%u", virtio->irq)); > > flexarray_append_pair(front, "base", GCSPRINTF("%#"PRIx64, virtio->base)); > > flexarray_append_pair(front, "type", GCSPRINTF("%s", virtio->type)); > > flexarray_append_pair(front, "transport", GCSPRINTF("%s", transport)); > > + flexarray_append_pair(front, "forced_grant", GCSPRINTF("%u", virtio->forced_grant)); > > This "forced_grant" feels weird to me in the protocol, I feel like this > use of grant or not could be handled by the backend. For example in > "blkif" protocol, there's plenty of "feature-*" which allows both > front-end and back-end to advertise which feature they can or want to > use. > But maybe the fact that the device tree needs to be modified to be able > to accommodate grant mapping means that libxl needs to ask the backend to > use grant or not, and the frontend needs to now if it needs to use > grant. I am not sure if I fully understand what you are suggesting here. The eventual fronend drivers (like drivers/i2c/busses/i2c-virtio.c) aren't Xen aware and the respective virtio protocol doesn't talk about how memory is mapped for the guest. The guest kernel allows both memory mapping models and the decision is made based on the presence or absence of the iommu node in the DT. The backends in our case are hypervisor agnostic and aren't part of Xen or any other hypervisor. I am not sure how the backend can provide the mapping information to Xen, with which the creation of the iommu DT node can be controlled. Also, as I communicated in another email, the currently suggested option in this patch, "forced_grant", isn't enough for us. We also need a way to disable grant mappings. Right now we are creating iommu nodes by default all the time, if the backend domain isn't Dom0. What I need probably is something like: "use_grant", where setting it to 1 will always create the iommu node and setting it to 0 will not, irrespective of the backend domain, and this overrides the current model of defaulting to create the node when not mapped by Dom0. -- viresh From xen-devel-bounces@lists.xenproject.org Fri May 05 09:38:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 09:38:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530275.825803 (Exim 4.92) (envelope-from ) id 1purtw-0004mD-LR; Fri, 05 May 2023 09:38:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530275.825803; Fri, 05 May 2023 09:38:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1purtw-0004m4-Ha; Fri, 05 May 2023 09:38:56 +0000 Received: by outflank-mailman (input) for mailman id 530275; Fri, 05 May 2023 09:38:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1purtv-0004lV-1j for xen-devel@lists.xenproject.org; Fri, 05 May 2023 09:38:55 +0000 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2060e.outbound.protection.outlook.com [2a01:111:f400:7e8c::60e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a385b987-eb28-11ed-8611-37d641c3527e; Fri, 05 May 2023 11:38:51 +0200 (CEST) Received: from BY3PR05CA0002.namprd05.prod.outlook.com (2603:10b6:a03:254::7) by DM4PR12MB6376.namprd12.prod.outlook.com (2603:10b6:8:a0::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.27; Fri, 5 May 2023 09:38:45 +0000 Received: from DM6NAM11FT019.eop-nam11.prod.protection.outlook.com (2603:10b6:a03:254:cafe::6b) by BY3PR05CA0002.outlook.office365.com (2603:10b6:a03:254::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.12 via Frontend Transport; Fri, 5 May 2023 09:38:45 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT019.mail.protection.outlook.com (10.13.172.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.27 via Frontend Transport; Fri, 5 May 2023 09:38:44 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 5 May 2023 04:38:44 -0500 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Fri, 5 May 2023 04:38:43 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a385b987-eb28-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GR6gtOXpoC57t0HCacBTkIHeDuFNTDtoOhiwMl1S0NB31Zn4mX3CMYIMp3JlhZ6GZlNDSfmvUyKUDonfMSg5LB8gQTnU8pILRCSPP5q/JpAI6LSW61NDAlmPvzBq7jFAXPHS+9EA+lVodYp7rkfT0tl0TN/gpwbyo9Vkn6A7D6iCihd7Q1+3/B9wMEbc3dTwDw87bri34AKT3TAxriEV0NRchR7RqJPDsVN62U+Iwt3/u0AmSrXA+8VEnG8oa+fLlzlwOZzc0ye2PIGguv7zgiqK+vyBqZ8BF4pDCRARUoqL5PFDPJ1Xn1nW6HjaNcH9LZp9CDCbEJNFpTrBDYYrXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iPitrE6wIpj4ueq7bKbBJIHgmndspWRUr4v1ZWtVluk=; b=ExaaTXL4SpZi/s7k8WmlxbtcM+xaJ3E4uIM8krilBukWqac2/7SPRCVLgFah8oK17zgwZ0Bq6rtDRbVSU0A+QBCHL5Q9a+PQbpLgfPeOTREPg4Ij9OqKT6HOPaKm7x5aTZdLlf2l0lmuOMF5G0z+p3non15qqLzK4macH6rgoNeTDBIliX1U24v0L00WjcUKv7hXdTUYOYcG8dv9t7G9qC2HIPGK7JE565XvUSAWhCD4tQB2+icVBMICMQELgQccG+jvRlQSHinxCem4uS123J2kMzlmz96Vl8Sv9BE2KQiMsgSvnbGN6+KLUUjHw+6f/1ezzWqB2NS3C1R1Wfz61Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iPitrE6wIpj4ueq7bKbBJIHgmndspWRUr4v1ZWtVluk=; b=QeekNrC1mQiY24zng4JUAsFn8nqY9QayZPQ5ESW+7cVzwnSZLdhqmKsBi4sMDyTK45qdDFjyhnj/+0GCT0iP3ECkcaRXUu4m1GMAEaYTU4Oh843af9pwsJoSyvDfAhseETinGFPb7OKTI1vS0aNmx5zXSEmmkF8IfoWuYOfTrus= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <57937e19-e038-b36a-73aa-c2a95de7e525@amd.com> Date: Fri, 5 May 2023 11:38:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [XEN][PATCH v6 02/19] common/device_tree: handle memory allocation failure in __unflatten_device_tree() Content-Language: en-US To: Vikram Garhwal , CC: , Julien Grall References: <20230502233650.20121-1-vikram.garhwal@amd.com> <20230502233650.20121-3-vikram.garhwal@amd.com> From: Michal Orzel In-Reply-To: <20230502233650.20121-3-vikram.garhwal@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT019:EE_|DM4PR12MB6376:EE_ X-MS-Office365-Filtering-Correlation-Id: bb878aa9-5058-4563-07c8-08db4d4c8508 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yCaqO0KGybFwAdbjNwSE4DwJym2jIDSrvKBT+IDReINK/ahz6pTHvxsN9DVQsmuf5G34Sks9al3IQYKb4PqjswFhddO74zRPiP6guhuKnsCtskWB/sSmxLCSYIztGUCvn4r/r5y5TurnkJLr0x5qinHmxzBhhsHDp+ezCW+AezkEdn7QLCeazMTD2MtIfi/wBItuac+Hq8BqtVsx6RVRwiKidu1eiWUVjDbpqP8NQS0Pzdw0XFqcw9haP26cKfQsa+pCyeaH0QO4RmozFgEVJR9Otdr/HfUlyd+orhkpvaGXbgp7QYW9rZLtlWqvm8I5Vy7AEnpPtrUyRpQCybZzEwJFUXiyv/csrNmWImdH2aWiUoeyoAngYqyePKVs870+DkmJrGPxOerxLKO7oLdT5nMKiW5+p8ACpp2bHPgG6l2Tu9vLH/eADI/ekNAEKms6YtCaeQW2BJiZ+DO0XZF0bfpxM8Stxhqtl+2bz8V7eHms5EBiwH6Hhy8aVRnhczpazonKRh0YJkCKWsCuD49KH7zIli+ptIEVS3y1UMfkhqXPMUiMozzQHaXEP3myJqk9ZdUgjDCW24SDsB3s1MlOqRrArseX7YNJVMM+GtinBHX+/7SdWE+FcvosnhbEKipBMrqpZ7vQ+PCnFbCK09K2paPThrLPCklJiRkVlGbeo8sBOzcb7mKdRy33Ii2Nfvltri7sVWtBk/jnqWa6QLA7/6vvqlIKyrAKvOAFmxywKI1TLHKB4L0hLE2FcpYFPlxT1jvtG6qahS/vHj+TVso+9Q== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(376002)(136003)(346002)(451199021)(40470700004)(46966006)(36840700001)(47076005)(83380400001)(2616005)(336012)(426003)(40460700003)(186003)(2906002)(40480700001)(36756003)(82310400005)(86362001)(31696002)(82740400003)(81166007)(356005)(36860700001)(41300700001)(8936002)(8676002)(5660300002)(44832011)(4326008)(70206006)(70586007)(316002)(478600001)(31686004)(53546011)(26005)(16576012)(110136005)(54906003)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 09:38:44.7025 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bb878aa9-5058-4563-07c8-08db4d4c8508 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT019.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6376 On 03/05/2023 01:36, Vikram Garhwal wrote: > > > Change __unflatten_device_tree() return type to integer so it can propagate > memory allocation failure. Add panic() in dt_unflatten_host_device_tree() for > memory allocation failure during boot. > > Signed-off-by: Vikram Garhwal I think we are missing a Fixes tag. > --- > xen/common/device_tree.c | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c > index 5f7ae45304..fc38a0b3dd 100644 > --- a/xen/common/device_tree.c > +++ b/xen/common/device_tree.c > @@ -2056,8 +2056,8 @@ static unsigned long unflatten_dt_node(const void *fdt, > * @fdt: The fdt to expand > * @mynodes: The device_node tree created by the call > */ > -static void __init __unflatten_device_tree(const void *fdt, > - struct dt_device_node **mynodes) > +static int __init __unflatten_device_tree(const void *fdt, > + struct dt_device_node **mynodes) > { > unsigned long start, mem, size; > struct dt_device_node **allnextp = mynodes; > @@ -2078,6 +2078,8 @@ static void __init __unflatten_device_tree(const void *fdt, > > /* Allocate memory for the expanded device tree */ > mem = (unsigned long)_xmalloc (size + 4, __alignof__(struct dt_device_node)); > + if ( !mem ) > + return -ENOMEM; > > ((__be32 *)mem)[size / 4] = cpu_to_be32(0xdeadbeef); > > @@ -2095,6 +2097,8 @@ static void __init __unflatten_device_tree(const void *fdt, > *allnextp = NULL; > > dt_dprintk(" <- unflatten_device_tree()\n"); > + > + return 0; > } > > static void dt_alias_add(struct dt_alias_prop *ap, > @@ -2179,7 +2183,10 @@ dt_find_interrupt_controller(const struct dt_device_match *matches) > > void __init dt_unflatten_host_device_tree(void) > { > - __unflatten_device_tree(device_tree_flattened, &dt_host); > + int error = __unflatten_device_tree(device_tree_flattened, &dt_host); NIT: there should be a blank line between definitions and rest of the code > + if ( error ) > + panic("__unflatten_device_tree failed with error %d\n", error); > + > dt_alias_scan(); > } > > -- > 2.17.1 > > FWICS, patches 2 and 4 are not strictly related to DTBO and are fixing issues and propagating errors which is always good. Therefore by moving them to the start of the series, they could be merged right away reducing the number of patches to review. At the moment, they can't be because patch 3 placed in-between is strictly related to the series. @julien? ~Michal From xen-devel-bounces@lists.xenproject.org Fri May 05 10:06:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 10:06:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530282.825812 (Exim 4.92) (envelope-from ) id 1pusK8-0008VH-J9; Fri, 05 May 2023 10:06:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530282.825812; Fri, 05 May 2023 10:06:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pusK8-0008VA-GZ; Fri, 05 May 2023 10:06:00 +0000 Received: by outflank-mailman (input) for mailman id 530282; Fri, 05 May 2023 10:05:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pusK7-0008V4-BJ for xen-devel@lists.xenproject.org; Fri, 05 May 2023 10:05:59 +0000 Received: from kylie.crudebyte.com (kylie.crudebyte.com [5.189.157.229]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6e0f159c-eb2c-11ed-b226-6b7b168915f2; Fri, 05 May 2023 12:05:57 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e0f159c-eb2c-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=crudebyte.com; s=kylie; h=Content-Type:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Content-ID:Content-Description; bh=dQqO1khjEzEoVtLNIOKXHQ3bWHajiFN7+uL2OPfkzMc=; b=mdPsTpwATAWPjUrJsoF9GqrraD ajLSNGDetq1iGmRFud9L4vAHbADCzTD3E3c6yEdaLI3bbNGs1D4uyazX3g9WPHteinNh9oz30GZRE CO8h/8ds1IYxaYm2gkOCo7yB82NJf/CHy//A8XKS7wurt69xdA5mmKgLcqj8/Qjek+I2jKDWt/eP7 MUf5+MlWwrg3SzIYfYMzYZF4OBLVHR5ZqxuXqiJPfQAECq80PEl2Kdc0m86pSda+Ppxoi442OEqdO 06GMIvCgnIicQa5eekq+hFLlxYcWoOD6FN3s+7HFtT8nBKvE5J53fQO3t6EsUfKXr8KWuODtgBBxu MlCt7vSu6nU8XxBuAO4oon6qV8IQX7DrKh4D+3O94BsG6OReeTHKqKOzqIBJ4gzvxwD4qSSl9IWZG l7A0qMl3H8rZ+jj80Tx2SrBg+FKrFYd1DJC+iuTaIrnaibk3DWZhOFRDdUNAv5DG+NzAE2Whe0SPF V8rbCFG37AMef1xY+AxMloEZXIOAGM1m3edeEBVnPOQHL9fXA4OtsP17LmZUTqsh/kKAexb2RgY// FwZCdBD4uickZaxI4MJcwFtO/m3AL4f1b0ifFtnUgpStquuZ98puAJ+oPGsAGRWmmJ+TBYYnC2ZEA TNUaF0NX0WSuOJtxSSqcaHEl5uHf4J0kx6/+e/YN4=; From: Christian Schoenebeck To: qemu-devel@nongnu.org Cc: Jason Andryuk , Greg Kurz , Stefano Stabellini , Anthony Perard , Paul Durrant , "open list:X86 Xen CPUs" , Jason Andryuk Subject: Re: [PATCH] 9pfs/xen: Fix segfault on shutdown Date: Fri, 05 May 2023 12:05:45 +0200 Message-ID: <43162544.QFhiSxD2Za@silver> In-Reply-To: <20230502143722.15613-1-jandryuk@gmail.com> References: <20230502143722.15613-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Hi Jason, as this is a Xen specific change, I would like Stefano or another Xen developer to take a look at it, just few things from my side ... On Tuesday, May 2, 2023 4:37:22 PM CEST Jason Andryuk wrote: > xen_9pfs_free can't use gnttabdev since it is already closed and NULL-ed Where exactly does it do that access? A backtrace or another detailed commit log description would help. > out when free is called. Do the teardown in _disconnect(). This > matches the setup done in _connect(). > > trace-events are also added for the XenDevOps functions. > > Signed-off-by: Jason Andryuk > --- > hw/9pfs/trace-events | 5 +++++ > hw/9pfs/xen-9p-backend.c | 36 +++++++++++++++++++++++------------- > 2 files changed, 28 insertions(+), 13 deletions(-) > > diff --git a/hw/9pfs/trace-events b/hw/9pfs/trace-events > index 6c77966c0b..7b5b0b5a48 100644 > --- a/hw/9pfs/trace-events > +++ b/hw/9pfs/trace-events > @@ -48,3 +48,8 @@ v9fs_readlink(uint16_t tag, uint8_t id, int32_t fid) "tag %d id %d fid %d" > v9fs_readlink_return(uint16_t tag, uint8_t id, char* target) "tag %d id %d name %s" > v9fs_setattr(uint16_t tag, uint8_t id, int32_t fid, int32_t valid, int32_t mode, int32_t uid, int32_t gid, int64_t size, int64_t atime_sec, int64_t mtime_sec) "tag %u id %u fid %d iattr={valid %d mode %d uid %d gid %d size %"PRId64" atime=%"PRId64" mtime=%"PRId64" }" > v9fs_setattr_return(uint16_t tag, uint8_t id) "tag %u id %u" > + Nit-picking; missing leading comment: # xen-9p-backend.c > +xen_9pfs_alloc(char *name) "name %s" > +xen_9pfs_connect(char *name) "name %s" > +xen_9pfs_disconnect(char *name) "name %s" > +xen_9pfs_free(char *name) "name %s" > diff --git a/hw/9pfs/xen-9p-backend.c b/hw/9pfs/xen-9p-backend.c > index 0e266c552b..c646a0b3d1 100644 > --- a/hw/9pfs/xen-9p-backend.c > +++ b/hw/9pfs/xen-9p-backend.c > @@ -25,6 +25,8 @@ > #include "qemu/iov.h" > #include "fsdev/qemu-fsdev.h" > > +#include "trace.h" > + > #define VERSIONS "1" > #define MAX_RINGS 8 > #define MAX_RING_ORDER 9 > @@ -337,6 +339,8 @@ static void xen_9pfs_disconnect(struct XenLegacyDevice *xendev) > Xen9pfsDev *xen_9pdev = container_of(xendev, Xen9pfsDev, xendev); > int i; > > + trace_xen_9pfs_disconnect(xendev->name); > + > for (i = 0; i < xen_9pdev->num_rings; i++) { > if (xen_9pdev->rings[i].evtchndev != NULL) { > qemu_set_fd_handler(qemu_xen_evtchn_fd(xen_9pdev->rings[i].evtchndev), > @@ -345,40 +349,42 @@ static void xen_9pfs_disconnect(struct XenLegacyDevice *xendev) > xen_9pdev->rings[i].local_port); > xen_9pdev->rings[i].evtchndev = NULL; > } > - } > -} > - > -static int xen_9pfs_free(struct XenLegacyDevice *xendev) > -{ > - Xen9pfsDev *xen_9pdev = container_of(xendev, Xen9pfsDev, xendev); > - int i; > - > - if (xen_9pdev->rings[0].evtchndev != NULL) { > - xen_9pfs_disconnect(xendev); > - } > - > - for (i = 0; i < xen_9pdev->num_rings; i++) { > if (xen_9pdev->rings[i].data != NULL) { > xen_be_unmap_grant_refs(&xen_9pdev->xendev, > xen_9pdev->rings[i].data, > xen_9pdev->rings[i].intf->ref, > (1 << xen_9pdev->rings[i].ring_order)); > + xen_9pdev->rings[i].data = NULL; > } > if (xen_9pdev->rings[i].intf != NULL) { > xen_be_unmap_grant_ref(&xen_9pdev->xendev, > xen_9pdev->rings[i].intf, > xen_9pdev->rings[i].ref); > + xen_9pdev->rings[i].intf = NULL; > } > if (xen_9pdev->rings[i].bh != NULL) { > qemu_bh_delete(xen_9pdev->rings[i].bh); > + xen_9pdev->rings[i].bh = NULL; > } > } > > g_free(xen_9pdev->id); > + xen_9pdev->id = NULL; > g_free(xen_9pdev->tag); > + xen_9pdev->tag = NULL; > g_free(xen_9pdev->path); > + xen_9pdev->path = NULL; > g_free(xen_9pdev->security_model); > + xen_9pdev->security_model = NULL; > g_free(xen_9pdev->rings); > + xen_9pdev->rings = NULL; > + return; > +} > + > +static int xen_9pfs_free(struct XenLegacyDevice *xendev) > +{ > + trace_xen_9pfs_free(xendev->name); > + > return 0; > } xen_9pfs_free() doing nothing, that doesn't look right to me. Wouldn't it make sense to turn xen_9pfs_free() idempotent instead? > > @@ -390,6 +396,8 @@ static int xen_9pfs_connect(struct XenLegacyDevice *xendev) > V9fsState *s = &xen_9pdev->state; > QemuOpts *fsdev; > > + trace_xen_9pfs_connect(xendev->name); > + > if (xenstore_read_fe_int(&xen_9pdev->xendev, "num-rings", > &xen_9pdev->num_rings) == -1 || > xen_9pdev->num_rings > MAX_RINGS || xen_9pdev->num_rings < 1) { > @@ -499,6 +507,8 @@ out: > > static void xen_9pfs_alloc(struct XenLegacyDevice *xendev) > { > + trace_xen_9pfs_alloc(xendev->name); > + > xenstore_write_be_str(xendev, "versions", VERSIONS); > xenstore_write_be_int(xendev, "max-rings", MAX_RINGS); > xenstore_write_be_int(xendev, "max-ring-page-order", MAX_RING_ORDER); > From xen-devel-bounces@lists.xenproject.org Fri May 05 10:50:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 10:50:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530285.825822 (Exim 4.92) (envelope-from ) id 1put0f-0004Q6-S4; Fri, 05 May 2023 10:49:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530285.825822; Fri, 05 May 2023 10:49:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1put0f-0004Pz-PN; Fri, 05 May 2023 10:49:57 +0000 Received: by outflank-mailman (input) for mailman id 530285; Fri, 05 May 2023 10:49:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1put0e-0004PW-Gu; Fri, 05 May 2023 10:49:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1put0e-0007cm-9A; Fri, 05 May 2023 10:49:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1put0d-0006JW-Qy; Fri, 05 May 2023 10:49:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1put0d-0002Kr-QV; Fri, 05 May 2023 10:49:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=aZ4YPEUeltTxZDJ9naQnd4NpCEuEcAb3Pysn2T/C2uw=; b=pjxsSRnJLDJAHkFGKcAbN4RLvN iXkPvHTsw3LrdBZcJJg7+kwsbPuEK9IXnN3kP0HQlUDcpXdEpJkj9qw+MB7zx5QjoZ04+vdjIxSUf XDLCHoV26k+GNp/vENBjzdFGJkdf2jNE8Ds0j0gJ+VvVN7lPAq/MqzzHM+awfSEPxz18=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180542: all pass - PUSHED X-Osstest-Versions-This: ovmf=94c802e108a082d6f74c854bea8bd98fe7808453 X-Osstest-Versions-That: ovmf=ff7cb2d7c98f8b832180e054848459fc24a0910a From: osstest service owner Date: Fri, 05 May 2023 10:49:55 +0000 flight 180542 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180542/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 94c802e108a082d6f74c854bea8bd98fe7808453 baseline version: ovmf ff7cb2d7c98f8b832180e054848459fc24a0910a Last test of basis 180538 2023-05-05 04:12:21 Z 0 days Testing same since 180542 2023-05-05 08:42:19 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Liming Gao Michael Kubacki jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git ff7cb2d7c9..94c802e108 94c802e108a082d6f74c854bea8bd98fe7808453 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri May 05 12:06:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 12:06:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530301.825833 (Exim 4.92) (envelope-from ) id 1puuCK-0004UX-KR; Fri, 05 May 2023 12:06:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530301.825833; Fri, 05 May 2023 12:06:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puuCK-0004UQ-Gc; Fri, 05 May 2023 12:06:04 +0000 Received: by outflank-mailman (input) for mailman id 530301; Fri, 05 May 2023 12:06:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puuCI-0004UG-L5; Fri, 05 May 2023 12:06:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puuCI-0000vP-Hm; Fri, 05 May 2023 12:06:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puuCI-0008DP-2W; Fri, 05 May 2023 12:06:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1puuCI-0002ws-23; Fri, 05 May 2023 12:06:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=FjXxMNfX+upI/sQ+vfXsfFz9qONRQ/BH4CgicxKsC7g=; b=Q7gclpM0h7vs+O7TFRyS7N9HmI pQgXv14QJew+0r1uJDixH+6cRLOsS6N5TgmjmcOTeXoo9J5vyHsGUnXv0fWaB9k3rPGQS0W2pJdAx 0IL+HSkc/Sb7UjnEhjbSI/KnN2uPt4UZlyYmM1JCpvdwR5wjt9Pyyu18aZNx9Qb8tf0Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 180541: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e93e635e142d45e3904efb4a05e2b3b52a708b4f X-Osstest-Versions-That: xen=b95a72bb5b2df24ff1baaa27920e57947dc97d49 From: osstest service owner Date: Fri, 05 May 2023 12:06:02 +0000 flight 180541 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/180541/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen e93e635e142d45e3904efb4a05e2b3b52a708b4f baseline version: xen b95a72bb5b2df24ff1baaa27920e57947dc97d49 Last test of basis 180520 2023-05-03 18:03:28 Z 1 days Testing same since 180541 2023-05-05 08:01:57 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git b95a72bb5b..e93e635e14 e93e635e142d45e3904efb4a05e2b3b52a708b4f -> smoke From xen-devel-bounces@lists.xenproject.org Fri May 05 12:17:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 12:17:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530309.825843 (Exim 4.92) (envelope-from ) id 1puuNC-0005zl-JM; Fri, 05 May 2023 12:17:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530309.825843; Fri, 05 May 2023 12:17:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puuNC-0005ze-GS; Fri, 05 May 2023 12:17:18 +0000 Received: by outflank-mailman (input) for mailman id 530309; Fri, 05 May 2023 12:17:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puuNA-0005zU-SK; Fri, 05 May 2023 12:17:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puuNA-00016R-K8; Fri, 05 May 2023 12:17:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puuNA-0008Sf-5q; Fri, 05 May 2023 12:17:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1puuNA-0004C3-5K; Fri, 05 May 2023 12:17:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pGyCC/eh5cZH/VO+0R4qrBhP4ywbV+KCuZtMXRFJMXg=; b=Cp6OYZxRC3qF+AOX90MToIhXZA AWNqvr5Fd/ZPwJ0ZrkOfjsCLbrjpX1lo4+nmdKP1j+U6xSpou3rNVYa5aLFCAjMNmpKlntw+6xmo8 4nYm0SVczFaK4dGdo2Icq6WMJlZRyCbrmfH/CeqF7kICVz1rUEAmbSJhtkM5Loy1AeL8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 180536: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug qemu-mainline:test-amd64-coresched-amd64-xl:guest-localmigrate/x10:fail:heisenbug qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=f6b761bdbd8ba63cee7428d52fb6b46e4224ddab X-Osstest-Versions-That: qemuu=1488ccb9b64e76aab0843bc035ce3b1938df2517 From: osstest service owner Date: Fri, 05 May 2023 12:17:16 +0000 flight 180536 qemu-mainline real [real] flight 180543 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180536/ http://logs.test-lab.xenproject.org/osstest/logs/180543/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 180543-retest test-amd64-coresched-amd64-xl 20 guest-localmigrate/x10 fail pass in 180543-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 180530 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180530 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180530 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 180530 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 180530 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180530 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180530 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180530 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass version targeted for testing: qemuu f6b761bdbd8ba63cee7428d52fb6b46e4224ddab baseline version: qemuu 1488ccb9b64e76aab0843bc035ce3b1938df2517 Last test of basis 180530 2023-05-04 13:29:10 Z 0 days Testing same since 180536 2023-05-05 00:40:15 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Daniel Xu Kfir Manor Konstantin Kostiuk Mark Somerville Richard Henderson Thomas Huth jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 1488ccb9b6..f6b761bdbd f6b761bdbd8ba63cee7428d52fb6b46e4224ddab -> upstream-tested From xen-devel-bounces@lists.xenproject.org Fri May 05 12:26:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 12:26:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530315.825853 (Exim 4.92) (envelope-from ) id 1puuVn-0007UY-FN; Fri, 05 May 2023 12:26:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530315.825853; Fri, 05 May 2023 12:26:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puuVn-0007UR-CP; Fri, 05 May 2023 12:26:11 +0000 Received: by outflank-mailman (input) for mailman id 530315; Fri, 05 May 2023 12:26:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puuVl-0007UL-Dm for xen-devel@lists.xenproject.org; Fri, 05 May 2023 12:26:09 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id feaf0790-eb3f-11ed-b226-6b7b168915f2; Fri, 05 May 2023 14:26:02 +0200 (CEST) Received: from mail-mw2nam12lp2043.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.43]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 May 2023 08:25:52 -0400 Received: from DS7PR03MB5414.namprd03.prod.outlook.com (2603:10b6:5:2c2::6) by SN7PR03MB7183.namprd03.prod.outlook.com (2603:10b6:806:2e5::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Fri, 5 May 2023 12:25:50 +0000 Received: from DS7PR03MB5414.namprd03.prod.outlook.com ([fe80::fdfd:97e5:7c55:82d]) by DS7PR03MB5414.namprd03.prod.outlook.com ([fe80::fdfd:97e5:7c55:82d%7]) with mapi id 15.20.6363.027; Fri, 5 May 2023 12:25:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: feaf0790-eb3f-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683289562; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=CwCMoJsQ3XBHdfK27O+QOGL4OPl7EWw9dH3TIohe9kI=; b=RL1JbXLOZugSTa6NohvzFI1Dd1MWx+cb8TeGXtc1sDpN6aoUu+FZOV97 yVpS8c0d8WwWRwmW8hh7xiOyITHNaRgotb+yewo5TZVOVGE+Byzzin7hK 3oDnYPZsRMI6zkb8DAldBTIjLrX6cOQa8grtBJB01OmOHXZ7z0Or2JcEC k=; X-IronPort-RemoteIP: 104.47.66.43 X-IronPort-MID: 107321463 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:XdW1ZqPd7AaeBUXvrR2RlsFynXyQoLVcMsEvi/4bfWQNrUor3mEDm GIeDGuDPqnYNGugKNAiOd/gpEoOsMPdy9E3Sgto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvPrRC9H5qyo42tF5gFmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0u9FPDgQ/ uw4FG82Yg6jq7yw3ZG6Z+Y506zPLOGzVG8ekldJ6GiDSNMZG9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+/RxvzO7IA9ZidABNPLXd9qMRMtYhACYq 3jM8n7lKhobKMae2XyO9XfEaurnxHukA9hLSOPjnhJsqEaclnBKFC9NaUe6mN67qWP5ect8N lNBr0LCqoB3riRHVOLVXRe1vXqFtR40QMdLHqsx7wTl4qjd5QqDF3UHZjFEYd0i8sQxQFQCx lKP2t/kGzFrmLmUUm6GsKeZqyuoPioYJnNEYjULJTbp+PHmqYA3yxfQFNBqFffvisWvQW2rh TeXsCI5mrMfy9YR0Lm29kzGhDTqoYXVSgky5UPcWWfNAh5FWbNJrreAsTDzhcus5q7AJrVdl BDoQ/Sj0d0= IronPort-HdrOrdr: A9a23:M3qxiKqMx5vAsCtg4qLc2M0aV5rbeYIsimQD101hICG9Evb0qy nOpoV+6faQslwssR4b9uxoVJPvfZq+z+8R3WByB8bAYOCOggLBQL2Ki7GC/9SJIUbDH4VmpM VdmsZFaOEYdmIK6voT4GODYqodKNvsytHWuQ8JpU0dMz2DaMtbnnZE4h7wKDwReOHfb6BJbq Z14KB81kOdUEVSVOuXLF8fUdPOotXa/aiWHCLvV3YcmXGzZSrD0s+ALySl X-Talos-CUID: 9a23:2hlDD2MVRw10d+5DURtarRAfCuAZLUbR0lf8fUmlKmdER+jA X-Talos-MUID: 9a23:J5/JIAYY4OwHxuBTrDC8mGh+BpxU/6WXL0IuvNIkouqZKnkl X-IronPort-AV: E=Sophos;i="5.99,251,1677560400"; d="scan'208";a="107321463" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ndFfZerHGfQZonnG8svWg05xeygl7bpXUNx09q8tBMbbpJOmH5kDSyBDzj5PnP9tcDSEdkDVY+uQIrLnly8Ix/vlVoFgmmhmDkSUDF7vXtBz6p1KyYm2ls8HpMk5gzwLggfL8M2ZAj0v0/wqRuTs/5RrmAYInMTTlv1CeA5PCzG3P87/MtNciA07wxywqXCqa6fWK4OBdZrwEz2+jjRBfWM6w071v30kbfjQvbQbs+9WG4wkOueMnxFMrNq0Cwd+6EVveSfyzZWbUZtP04d5FGtsAZPunvXCmLJpYrzI1cyG9MAgNWuX6LNjdnMwE6VZRtAsYIJy9JO479QSfU7MBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CwCMoJsQ3XBHdfK27O+QOGL4OPl7EWw9dH3TIohe9kI=; b=WF1FrbqEZTA+JZu0SMPtipyKqTP6nqJVN0VkIKOWtSdSjA1Rp2t22Klwba4NWIXzBn+5N+99PBgdHVFElqmxGsWvxnJfH0bHyRDOWIqXOLUGyYAD9XpSWqqFlEQfNiLEptp9K6Ktmml8xoqmXjXYkqvVqq5VNhtJD/AuWhSJiiSaSGHkChfrERiGDZSRfvbf+ipA12dWYiTmiGkb37lnA6m7G5zhFVe6ghXciMTPPUM9xViXZr0PqzGLqbuDYm3qK3SL+7bgzNlf7MsphztptzFqg7H6MN8AJNi3r4FWY6LvaqQXzRm5di07n8hnWlUBlvx2aTvUZbQU61iSuNbG1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CwCMoJsQ3XBHdfK27O+QOGL4OPl7EWw9dH3TIohe9kI=; b=q1X6Gb7KFb1GsSgUQGZEjGm1qeWU5WzbTkXnZqlevSBLXuvNEdEs49KaUGbfXIJKrRSZRDQOZpXbeoprISFV7tIkLiS2UDOnFdVHyAdH1Ame7IoybPum8U7MbqSKjRJcr2opRftg7g+sbyhZy+4+K6v37reZULx/xNz5AxLyqhw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <462a2ed3-2e9c-b271-b8d5-255c12f409aa@citrix.com> Date: Fri, 5 May 2023 13:25:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v4 1/2] acpi: Make TPM version configurable. To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jason Andryuk , Xen-devel References: <20230504175146.208936-1-jennifer.herbert@citrix.com> <20230504175146.208936-2-jennifer.herbert@citrix.com> From: Jennifer Herbert In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0092.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:191::7) To DS7PR03MB5414.namprd03.prod.outlook.com (2603:10b6:5:2c2::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR03MB5414:EE_|SN7PR03MB7183:EE_ X-MS-Office365-Filtering-Correlation-Id: 07ff9139-2aab-4df3-209a-08db4d63dc5c X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: e6FFe/Cbnq2Trcq9t0bU0siokENxydNMi0v7D1pGqwIhDahhou577B6sQ4qpqMn/75jMpTxVIyB9bAUUhwB5yHW6rySD322O66C0xxbygbIvC6fPv4UGQxu+ismNPME48iOJnXvEZ3RUTD7O4R7Obj0V4XXNObC4gCLb7260dTyEPlaGnzemvviq/fK2G6gw9PYciCC7WIplI+YYImlMyHYQJjsUU6iOpJ+JMQr+BpF9Cqy2pn/+nnieVM5v9zFf6sFOgh6411XVv9f1px3MiudPn6O+AfhNV6niI7+pkFYFUkxNl+VWd3uf9aAMAodj2pnOFcq75SWi2v/UmUUaD8tHfc1Um3mE8TEDoPnnx2yberH+VRlxgqJv8bzK3d1tjRGpBkzhA5hj49aaAwd9LAo227TmA/t7esf5K2mAwQ3aOebbR7lYw3kfPzsSOzLB+GQarDECEnLEk8wnECCp3Kt6Uk+KN3lKorgD1C48RLT85uVXWb0REeNvwhlBqMVS7Qje0MCu11EoSfREIzha/w9mbR1PEzg8EZevXrME83Fcuy01BI5KI7D6wgLeKk1mQ/P4+71di8MZrTJpFSVRtIrqb60L8scu8ADgTdtRCiau7eWtbge+4PpxYKpTDtxqyyJX09rJx2z59hi9gi3aTw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5414.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(376002)(396003)(366004)(136003)(451199021)(44832011)(8676002)(5660300002)(478600001)(38100700002)(8936002)(82960400001)(54906003)(6512007)(6506007)(31696002)(6666004)(86362001)(66476007)(66946007)(66556008)(31686004)(4326008)(6916009)(6486002)(83380400001)(2906002)(36756003)(316002)(53546011)(186003)(41300700001)(26005)(4744005)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RHZmbzBzZ0R4VmhqblhQTE9Vc2tGcCtSeXhNVkJTYm5DK2lnY1FhWTN5Ungx?= =?utf-8?B?MUNQcFdiUDNoQ3ptL2c2UFMyYUpkcHFWT3cxc2k4SFZmRENvMmRHRkRYdzJj?= =?utf-8?B?QXNkYWlMT3ZXeVR3U3FLSGxuSmZJKzkvekJzNnJHdzg2YWErZXA1OCs5Rjhw?= =?utf-8?B?aG1BM01mWUJUSlhSUjBrdUI1YkEzRmNQOEdSUmpTRk9PSHpmeWhtT1ZaQUI0?= =?utf-8?B?TXBDWkRSK1h5alpJYVFoRWN5dVFMS1BLSGVyWmtzVlVkaGRGWGhLeWkrV2Nq?= =?utf-8?B?eEhCWVRmSEt3UERQUFRzRitVNGxPV25abzk4ZTJ5eC8wSU95MkxOUktIRnFN?= =?utf-8?B?WXRJbWVCSGVBREtVdTVEeGR1YlNqcUw2TW9SRm1pT0p5blVpRXJrSmZDSW1W?= =?utf-8?B?NUwzWVM4OFRZU0FOTUEvaUxuSHNjOE1yK20vWnFySjZXdWhJVFN6L2ZzSUNB?= =?utf-8?B?N0FNeW1rL2ZHdzdxendNRTNnU0pFWlhyMVVNelFtdkJNNWRoMi9qKzhvMEx6?= =?utf-8?B?YjY5Q1dNWXdXSXE4VlJvZi9HSlYwcWVDeG5QOTZRR2NtRk1KbEg1M0EwVzRF?= =?utf-8?B?YmtveURRTFlKWlIvT2ZZV3llTHJ1NGlPK3U5UHZ3emlOdnZKc0c2Y0NoUDV5?= =?utf-8?B?c0J6TEI0d0hLRlVqWFdBeHlyQklvbVJTbjVGVGZIL2UyK3BaRGVab1BmbVZo?= =?utf-8?B?UDFkOFV0aW5TbE50T0lkdXJTUmw4TEc5amNyd3N3eVJUU0lsQjZyRlZERTZn?= =?utf-8?B?YzI5bzZtVDlFT29MVjJsQlpKOXVMeWNZNHZTVzRCMW5sdW4yYllPTlMzTWc4?= =?utf-8?B?dFBtbG10YUhIZlY3VGc5RnNGT0pLTXRWblp5ZUswN1QreU1wQ2hicWNoeVI3?= =?utf-8?B?U0ltclArSksyWkdlcHhMYkx0K1FsajIxN0VudWQ5a1BNSFhlZUIyVlZkejJJ?= =?utf-8?B?SlFXaGVZTFRkSCtLa0xEYkxtWFFtVkZ1ZXVuVDdPNmNKekp2VEJQNjZwMFpK?= =?utf-8?B?ek80UEJRODlOdU1JM1Bic0dRVzRJNTB5YzJrMVRWaWlkNm1CNHdSNlZ4OGdi?= =?utf-8?B?WjlFNy92ZGtnTHdObEdZWThCUFhGZzVUdFZPZklIU2o4SE45Z2ozdWpURXc4?= =?utf-8?B?MXJ3MHYvb3Bjd1pycUM3ZHd0ZnNEUXBXVGhWdmF3eUNtU2h3dGcrTFYybXJt?= =?utf-8?B?Wkpoa0NNM2djcjR2cnVFQWo1aXNFUnc1OTVCK2JTVGxXR2RIWk5ZanE4WkFY?= =?utf-8?B?cVgvNDJUWW83QWZNZkRsN2kwTnNKdE51cExjVEVXT0dVQUdoWnB2anh1RkpX?= =?utf-8?B?aDdzTHY3dmNDdStwbVNrcFNEWmFZS3hQNEtiMHZyNjlSWUhCZ1ljWDJrSVhJ?= =?utf-8?B?bmdYNlN6b3IyM3c2TVdGL01VczdmYXljUDdKUVY1ZXRsMjBySmc2NU5CS3Z3?= =?utf-8?B?YzRnUDVNMDJzTjBwRHUyK0tkWUZnb2hpRlJBdEhZZ3NTVkxuWmNCMDNHSmlx?= =?utf-8?B?YWZ1WURHS1NsL0ZlOVVRQzVSYTQ2QmFQVThieGtNcGVRVmxJZk5WeDJqT2dP?= =?utf-8?B?UEJZdkNEemFBNlZFZHM5cWhIUzF1K2NaVWp2Uk4vdHp5K2lHMXpQWnNWU05r?= =?utf-8?B?bXdVV0RBeks0bEhvMWt4Q3ZmZ1RCQWZOYnpLNVZjWXFiQXdlQmUwUENDeFgr?= =?utf-8?B?OFpWOEMrcVVKQlFjdlNGUStqcXFWYXVlOWZPWnFpbVR6YjRVTmVDRlhZdjdI?= =?utf-8?B?U2JkSmFGTDhSdjlQeFlOUHZ0a2NOb1ljOTJURWQrcXNHb0ZlK3BhU20vazc0?= =?utf-8?B?VTlTTWJDREd1cjlPMnRmQVVTTlhXMit5N3ZkV0UvV3NoTlBxNkNXZnErMG1P?= =?utf-8?B?Q2ZGNWNqTCt3RSszYU5iMTBQeVhEK0lJOTNoRWQ0OFM3c245aklvTWF2elNr?= =?utf-8?B?aDNQMGdDOXRCZWNxZXI4Qm5kL1piNjh2cTlCSGovczBjOFZkZkxrcElCVitO?= =?utf-8?B?aEowc2NOM3NBbmdxR2VyNzdxWWVUWnB6K2pIWW5OdXhtSE9YdkxnNEtpaWhM?= =?utf-8?B?Rys2U3VGNG40VWxnVWhsN1IybzMwTGhJZ0k2MDlYUWFTZUF5VGNzNGhxYjVz?= =?utf-8?B?dG1vVk50aGhsOEpTM0F3YVkwV21MakNGZVpyVmR6R3dUOEVlZEcxRC9EUS9S?= =?utf-8?B?U1E9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: l+spBdfoiL03RFi1eE5UtzmfQViZFNnhMPrU8aYme/bFukfgwUZdtD19psTukkKNiLPMuZAevqGDEkM7vDv6WA2CmG04vFn6+P8wgeEcww7HkLC07FpDMNALAlnQTu5wdoIl5t2QH4ZBizTFQnNh0UPsUkz72GdRWKMftndawW2R/AJ3GTKgbbYXeI+42+KmTR+M4Z7mwUmZGWMY5I8eU/yO5Vd1AV7lcjT04/4Wm8iG2QonWYucUY+90tFj65ggaAztB6Pnp0YGeKCp0bWUReImvP6i8yPJtVII7zm9ozzFB2NvVWgeoS016aG4Mp6/itT6co2XLiKwKGBa0HkS7G5ILUUgTG8B7CSjZ2EIyps6Biief7/NQwtOD6GejAk8eULnkKXeZnsZxM3kngXPjmxOf2+WRoT32oZkAyEbjfAY6M4+/ML/qFFtlsZC86BbTWYLsxQNrl8Jjny23mWElAIe/o9a2qIIhvJAn+gY7srGPSbSi4AxeHmDH9qR8t+rhTUVg24wIzm8RsB4K52V6a8vqm6KUMXTmfranGLRTvgD6UurHS5WdrXX/eQ7xmPUMM/cOEjXfJLXbQi9VxXFfNoM4tJodiukrrYJOFNgNsbDBJblsUw/UK7a6481IoEUwAh6T0yO2obfwe+tmJc6u2cL+pcLBAEL0xUJkgN762S2s6r7pAzg+99uvH/FWyWs1JACkrLBSDIEOxroJ31YtpD6WsbBFhbaPJ7RM2EmRV9FfF5z73TmjcNJ2YkvNX2qGLfzSFE4jWbvrKQC9l2uboZ9lF+ddDag+v04wWxLKfzleNaH5ulqRlDpF1OIj1+GoVseAnvIgBqoJ0KMcahh1Q== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 07ff9139-2aab-4df3-209a-08db4d63dc5c X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5414.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 12:25:49.8949 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: X+39yR+t6m5Lw6WfsvCLzE7Ybsi85lr7GPYUFEUbUWNGyde1V4IKYgGZqYPbLO1ZtIGcrkhB4jJ2KnBhZ64L8FQ24jv4tZyeLOWyg23Fkyg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR03MB7183 On 05/05/2023 07:34, Jan Beulich wrote: > On 04.05.2023 19:51, Jennifer Herbert wrote: >> This patch makes the TPM version, for which the ACPI library probes, configurable. >> If acpi_config.tpm_verison is set to 1, it indicates that 1.2 (TCPA) should be probed. >> I have also added to hvmloader an option to allow setting this new config, which can >> be triggered by setting the platform/tpm_verion xenstore key. >> >> Signed-off-by: Jennifer Herbert >> Reviewed-by: Jason Andryuk > Acked-by: Jan Beulich > albeit with two minor further request (which I'd be happy to make while > committing): I agree, the NULL checks and tpm_verison initilizer are unnesery. So I'd be very happy if you made these changes as you commit them! Thankyou! -jenny From xen-devel-bounces@lists.xenproject.org Fri May 05 12:45:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 12:45:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530322.825863 (Exim 4.92) (envelope-from ) id 1puuoY-0001XU-6S; Fri, 05 May 2023 12:45:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530322.825863; Fri, 05 May 2023 12:45:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puuoY-0001XN-39; Fri, 05 May 2023 12:45:34 +0000 Received: by outflank-mailman (input) for mailman id 530322; Fri, 05 May 2023 12:45:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puuoV-0001XH-N8 for xen-devel@lists.xenproject.org; Fri, 05 May 2023 12:45:32 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b7505a15-eb42-11ed-8611-37d641c3527e; Fri, 05 May 2023 14:45:29 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b7505a15-eb42-11ed-8611-37d641c3527e From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683290728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ro/VOFl72UDWFwy8gwNK93pOtDrJEFznvt3NXDl6cF8=; b=NEssImE7oVj95z4/FBIZJnxzphr31CeA4k7oJeJinz1r5r1l9dXN1gppKxrfH844UqDO9z 4QSvSZ+MCzWy04loOUdVFWsJabtUy+6xAHaZOnUP3kDamwQqqChUVjh6yxS90kqh/3foQl BxPnqXdK0mEFhXKLhgXSM8yu090mNdF9FRSITtHjxNfxijznNsQsOy0jITHZ9ajNCFSUr7 ixcpybMXO0+Tte9hyNa1D9uPISenZGZ0GM57Wg5ua9BDE6mitsB+qwg3eCN369M6O0Jwe5 /MuZBe8FpjmVO3WPvPxa64u3KW+r1rcVtivlIiAVpuzcTFgSsngi+McsE/7vlQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683290728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ro/VOFl72UDWFwy8gwNK93pOtDrJEFznvt3NXDl6cF8=; b=65zpCtdzuEaRqOzhfQTeNfeiCJfu8TviFjuPm0aorQPKM8pLdEAQ4DrGamxrKih4/79CxI kPU4Ye7GnkFx6vAA== To: Andrew Cooper , LKML Cc: x86@kernel.org, David Woodhouse , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: Re: [patch V2 34/38] x86/cpu/amd; Invoke detect_extended_topology_early() on boot CPU In-Reply-To: <38b259bb-050b-023e-4f43-212f95f022ac@citrix.com> References: <20230504185733.126511787@linutronix.de> <20230504185938.179661118@linutronix.de> <38b259bb-050b-023e-4f43-212f95f022ac@citrix.com> Date: Fri, 05 May 2023 14:45:28 +0200 Message-ID: <87354b3q1j.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain On Fri, May 05 2023 at 00:04, Andrew Cooper wrote: > On 04/05/2023 8:02 pm, Thomas Gleixner wrote: >> From: Thomas Gleixner >> >> The early detection stores the extended topology leaf number which is >> required for parallel hotplug. >> >> Signed-off-by: Thomas Gleixner > > It occurs to me that this and the previous patch are stale given that we > no longer look at CPUID in the trampoline. > > They're probably useful changes in isolation, but the commit messages > want adjusting to remove the association with parallel boot. Duh. Indeed. Completely forgot about that. From xen-devel-bounces@lists.xenproject.org Fri May 05 13:05:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 13:05:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530327.825879 (Exim 4.92) (envelope-from ) id 1puv84-00043w-7u; Fri, 05 May 2023 13:05:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530327.825879; Fri, 05 May 2023 13:05:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puv84-00043P-0p; Fri, 05 May 2023 13:05:44 +0000 Received: by outflank-mailman (input) for mailman id 530327; Fri, 05 May 2023 13:05:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puv82-0003zO-OD for xen-devel@lists.xenproject.org; Fri, 05 May 2023 13:05:42 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 899ce7c8-eb45-11ed-b226-6b7b168915f2; Fri, 05 May 2023 15:05:41 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 899ce7c8-eb45-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683291942; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=4e+XjBWakkBin20cYWqiIerVP51elQbRzoIyhzyYm2o=; b=hakdqJd5ugNOJu+NI7hp7CCMJakGJ0XOh85aSLQzHfY/zjepDZYtQOBI 7ImEGnMgX8DCY90zs1SyY0+WccGI5EIis5aMRAc1cl/1eLZXZZCz00svK Hy+1byRfDqR/cxXUhMmjfGg47QOBjDx8KLLlmJT/16U3A32jNCC2eG/dL 4=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 108401386 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:3NIipq9xDPUPxShaHkxMDrUDmX6TJUtcMsCJ2f8bNWPcYEJGY0x3z GEfXjyOaKvbYjenKNgiaIiypEhU7Z+Ax4RrGQRo+Cg8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kI+1BjOkGlA5AdmOKgW5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDkl3z tIheWwEbSrEpNOO6oK3dvlPq8EseZyD0IM34hmMzBncBPciB5vCX7/L9ZlT2zJYasJmRKiEI ZBDMHw2MUqGOkcUUrsUIMtWcOOAr3/zaTBH7nmSorI6+TP7xw1tyrn9dtHSf7RmQO0MxhbE/ judrzqR7hcyFNCWwjO6/VCW1tTCw33LcoMqReyz36s/6LGU7jNKU0BHPbehmtGph0j7V99BJ kg8/is1sbN05EGtVsP6XRCzvDiDpBF0c/h6HvA+6QqN4rHJ+AvfDW8BJhZac8AvvsIyQT0s1 3eKksnvCDgpt6eaIVqC8p+EoDX0PjIaRUcAeCsFQA0t89Tl5oYpgXryos1LSfDvyIevQHepn m7M9XJl71kOsSIV/5yA02mW3zuvnN/qfzYf1gnrTkGI6wwsMeZJeLeUBUjnAedoddjJFQPc7 SFdxKBy/8hVU8jTyXXlrPElWejwuq3baGC0bUtHRcFJyti7x5K0kWm8ChlaLVwhDMsLcCSBj KT76VIIv8870JdHgMZKj2ON5ycCl/KI+SzNDKy8Uza3SsEZmPW71C9vf1WM+GvmjVIhl6oyU b/CL5b3VyxEVf02lGHpLwv47YLHOwhknT+DLXwF503PPUWiiI69Fu5ebQrmghER56KYugTFm +ti2z+x40wHCoXWO3CHmbP/2HhWdRDX87iq8Z0IHgNCSyI6cFwc5wj5nep9J9c/wPsIxo8lP BiVAydl9bY2vlWfQS3iV5ypQOqHsUpXxZ7jARERAA== IronPort-HdrOrdr: A9a23:oVL1Eq+3qKMuWJ8BjdJuk+DfI+orL9Y04lQ7vn2ZKCYlFPBw8v rF8cjzuiWUtN98YhEdcKm7VpVoIkmskqKdg7NhWItKNTOO0ACVxedZnOjfKlXbdxEWndQtsZ uIHZIOauEZ0jBB4voTh2GDYq8d/OU= X-Talos-CUID: =?us-ascii?q?9a23=3ARQHoHWuV73GsVFdrnZOoiJKA6IscSVPknSvZIHX?= =?us-ascii?q?/KldRYo2ZdU+z1aZrxp8=3D?= X-Talos-MUID: 9a23:f41KWAsS4PDmOULOs82npD1rP85X7IaUWHsAz8s2kci8ZH17EmLI X-IronPort-AV: E=Sophos;i="5.99,252,1677560400"; d="scan'208";a="108401386" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , George Dunlap , Jan Beulich , "Stefano Stabellini" , Wei Liu , Julien Grall Subject: [PATCH 1/2] LICENSES: Improve the legibility of these files Date: Fri, 5 May 2023 14:05:32 +0100 Message-ID: <20230505130533.3580545-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230505130533.3580545-1-andrew.cooper3@citrix.com> References: <20230505130533.3580545-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain A few newlines go a very long way Signed-off-by: Andrew Cooper --- CC: George Dunlap CC: Jan Beulich CC: Stefano Stabellini CC: Wei Liu CC: Julien Grall --- LICENSES/BSD-2-Clause | 4 ++++ LICENSES/BSD-3-Clause | 4 ++++ LICENSES/BSD-3-Clause-Clear | 4 ++++ LICENSES/CC-BY-4.0 | 5 +++++ LICENSES/GPL-2.0 | 5 +++++ LICENSES/LGPL-2.0 | 6 ++++++ LICENSES/LGPL-2.1 | 6 ++++++ LICENSES/MIT | 4 ++++ 8 files changed, 38 insertions(+) diff --git a/LICENSES/BSD-2-Clause b/LICENSES/BSD-2-Clause index da366e2ce50b..694d8c93221c 100644 --- a/LICENSES/BSD-2-Clause +++ b/LICENSES/BSD-2-Clause @@ -1,10 +1,14 @@ Valid-License-Identifier: BSD-2-Clause + SPDX-URL: https://spdx.org/licenses/BSD-2-Clause.html + Usage-Guide: + To use the BSD 2-clause "Simplified" License put the following SPDX tag/value pair into a comment according to the placement guidelines in the licensing rules documentation: SPDX-License-Identifier: BSD-2-Clause + License-Text: Copyright (c) . All rights reserved. diff --git a/LICENSES/BSD-3-Clause b/LICENSES/BSD-3-Clause index 34c7f057c8d5..1441947f92e0 100644 --- a/LICENSES/BSD-3-Clause +++ b/LICENSES/BSD-3-Clause @@ -1,10 +1,14 @@ Valid-License-Identifier: BSD-3-Clause + SPDX-URL: https://spdx.org/licenses/BSD-3-Clause.html + Usage-Guide: + To use the BSD 3-clause "New" or "Revised" License put the following SPDX tag/value pair into a comment according to the placement guidelines in the licensing rules documentation: SPDX-License-Identifier: BSD-3-Clause + License-Text: Copyright (c) . All rights reserved. diff --git a/LICENSES/BSD-3-Clause-Clear b/LICENSES/BSD-3-Clause-Clear index e53b56092b90..2b27f24a65a0 100644 --- a/LICENSES/BSD-3-Clause-Clear +++ b/LICENSES/BSD-3-Clause-Clear @@ -1,10 +1,14 @@ Valid-License-Identifier: BSD-3-Clause-Clear + SPDX-URL: https://spdx.org/licenses/BSD-3-Clause-Clear.html + Usage-Guide: + To use the BSD 3-clause "Clear" License put the following SPDX tag/value pair into a comment according to the placement guidelines in the licensing rules documentation: SPDX-License-Identifier: BSD-3-Clause-Clear + License-Text: The Clear BSD License diff --git a/LICENSES/CC-BY-4.0 b/LICENSES/CC-BY-4.0 index 27dfefa95ccf..4197ceb180ff 100644 --- a/LICENSES/CC-BY-4.0 +++ b/LICENSES/CC-BY-4.0 @@ -1,15 +1,20 @@ Valid-License-Identifier: CC-BY-4.0 + SPDX-URL: https://spdx.org/licenses/CC-BY-4.0 + Usage-Guide: + Do NOT use this license for code, but it's acceptable for content like artwork or documentation. When using it for the latter, it's best to use it together with a GPL2 compatible license using "OR", as CC-BY-4.0 texts processed by the kernel's build system might combine it with content taken from more restrictive licenses. + To use the Creative Commons Attribution 4.0 International license put the following SPDX tag/value pair into a comment according to the placement guidelines in the licensing rules documentation: SPDX-License-Identifier: CC-BY-4.0 + License-Text: Creative Commons Attribution 4.0 International diff --git a/LICENSES/GPL-2.0 b/LICENSES/GPL-2.0 index 9f09528a8bce..0022a7c17788 100644 --- a/LICENSES/GPL-2.0 +++ b/LICENSES/GPL-2.0 @@ -2,11 +2,15 @@ Valid-License-Identifier: GPL-2.0 Valid-License-Identifier: GPL-2.0-only Valid-License-Identifier: GPL-2.0+ Valid-License-Identifier: GPL-2.0-or-later + SPDX-URL: https://spdx.org/licenses/GPL-2.0.html + Usage-Guide: + To use this license in source code, put one of the following SPDX tag/value pairs into a comment according to the placement guidelines in the licensing rules documentation. + For 'GNU General Public License (GPL) version 2 only' use: SPDX-License-Identifier: GPL-2.0-only or (now deprecated) @@ -15,6 +19,7 @@ Usage-Guide: SPDX-License-Identifier: GPL-2.0+ or SPDX-License-Identifier: GPL-2.0-or-later + License-Text: GNU GENERAL PUBLIC LICENSE diff --git a/LICENSES/LGPL-2.0 b/LICENSES/LGPL-2.0 index 957d798fe037..2fa16d72eabf 100644 --- a/LICENSES/LGPL-2.0 +++ b/LICENSES/LGPL-2.0 @@ -1,15 +1,21 @@ Valid-License-Identifier: LGPL-2.0 Valid-License-Identifier: LGPL-2.0+ + SPDX-URL: https://spdx.org/licenses/LGPL-2.0.html + Usage-Guide: + To use this license in source code, put one of the following SPDX tag/value pairs into a comment according to the placement guidelines in the licensing rules documentation. + For 'GNU Library General Public License (LGPL) version 2.0 only' use: SPDX-License-Identifier: LGPL-2.0 + For 'GNU Library General Public License (LGPL) version 2.0 or any later version' use: SPDX-License-Identifier: LGPL-2.0+ + License-Text: GNU LIBRARY GENERAL PUBLIC LICENSE diff --git a/LICENSES/LGPL-2.1 b/LICENSES/LGPL-2.1 index 27bb4342a3e8..b366c7e49199 100644 --- a/LICENSES/LGPL-2.1 +++ b/LICENSES/LGPL-2.1 @@ -1,15 +1,21 @@ Valid-License-Identifier: LGPL-2.1 Valid-License-Identifier: LGPL-2.1+ + SPDX-URL: https://spdx.org/licenses/LGPL-2.1.html + Usage-Guide: + To use this license in source code, put one of the following SPDX tag/value pairs into a comment according to the placement guidelines in the licensing rules documentation. + For 'GNU Lesser General Public License (LGPL) version 2.1 only' use: SPDX-License-Identifier: LGPL-2.1 + For 'GNU Lesser General Public License (LGPL) version 2.1 or any later version' use: SPDX-License-Identifier: LGPL-2.1+ + License-Text: GNU LESSER GENERAL PUBLIC LICENSE diff --git a/LICENSES/MIT b/LICENSES/MIT index f33a68ceb3ea..eba1549f93e4 100644 --- a/LICENSES/MIT +++ b/LICENSES/MIT @@ -1,10 +1,14 @@ Valid-License-Identifier: MIT + SPDX-URL: https://spdx.org/licenses/MIT.html + Usage-Guide: + To use the MIT License put the following SPDX tag/value pair into a comment according to the placement guidelines in the licensing rules documentation: SPDX-License-Identifier: MIT + License-Text: MIT License -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Fri May 05 13:05:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 13:05:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530326.825873 (Exim 4.92) (envelope-from ) id 1puv83-0003zg-QZ; Fri, 05 May 2023 13:05:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530326.825873; Fri, 05 May 2023 13:05:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puv83-0003zZ-Nq; Fri, 05 May 2023 13:05:43 +0000 Received: by outflank-mailman (input) for mailman id 530326; Fri, 05 May 2023 13:05:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puv82-0003zO-Fn for xen-devel@lists.xenproject.org; Fri, 05 May 2023 13:05:42 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 87db2096-eb45-11ed-b226-6b7b168915f2; Fri, 05 May 2023 15:05:40 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 87db2096-eb45-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683291940; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=9MVcvLqzUK6qhH7+uSpDyPfF2OpcLaXOQ00IpCjwAPE=; b=K9xihGbGjbbYcA1Apd0CkxWjml2vKNd/UxPHvaZSBu7RU/s0uPLCrwNv HzbDm1m4xW4zl8G2kolMjjLFbOqdRw3CJZRUwXFc7aN7fELwjunhRbEsy nmzo4svr6ouA2scenvOk0VG4gxOotqdQ5AAB5/beTq2KdIJHsVC5tBdh5 4=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 108401385 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:0LvNqK7bmN5yQw1c4je0twxRtCHHchMFZxGqfqrLsTDasY5as4F+v mNOWGmBPvqNMDb8fdh2Ydu+px9XvJ6ByoVqSwI/qSA9Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+7ZwehBtC5gZlPa0T4QeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5mz Mc2EWFRZxO5wMGH+JiLRtV8pekmI5y+VG8fkikIITDxCP8nRdbIQrnQ5M8e1zA17ixMNa+AP YxDM2MpNUmeJUQVYT/7C7pn9AusrlD5fydVtxS+oq0v7nKI5AdwzKLsIJzefdniqcB9xx7I+ jqfpDSkav0cHPKV6RPe31fvus7SsjOqdaY9Pae8xNc/1TV/wURMUUZLBDNXu8KRkVWiUthSL 0gV/CsGrqUo8kGvCN7nUHWQv3qsrhMaHd1KHIUS6hyJy6fSyxaUAC4DVDEpQP4MudIyRDcq/ kSUhN6vDjtq2JWFRHTY+rqKoDeaPSkOMXREdSICVREC4dTovMc0lB2nczp4OPfr1JuvQ2i2m m3U6nFk3N3/kPLnyY2Cxn7+0m6lpaKObT8NzDXbYnKGwwZ2MdvNi5OT1bTL0RpRBN/HHgLb4 Sldwpf2APMmVs/UynHUKAkZNPTwvqvebmWB6bJ6N8N5nwlB7UJPamy5DNtWAE5yevgJdjbyC KM4kVMAvcQDVJdGgEIeXm5QNyjJ5fK6fTgdfqqIBueim7AoHON9wAlgZFSLw0fmm1U2nKc0N P+zKJj8VixAV/g+nWLtGI/xNIMWKt0WnzuPFfgXMTz+uVZhWJJlYehcawbfBgzIxKiFvB/U4 75iCid+8D0GCLeWSnCOoeYuwaUicSBT6Wbe95YGKYZu42NORAkcNhMm6e94J9A+xfsKy7egE 7PUchYw9WcTTEbvcW2iAk2Popu2NXqjhRrX5RARAGs= IronPort-HdrOrdr: A9a23:T4gJWqCV9fFsutTlHemr55DYdb4zR+YMi2TDtnoBLyC9F/bz+v xG88576faZslYssQgb9+xoW5PwJk80l6QFhLX5VI3KNGLbUQ2TXeJfBOPZrwEIcBeOktK1u5 0QEZSX17XLYmST6q7BkXCFL+o= X-Talos-CUID: 9a23:wQwmsWHH/ouQitEyqmJez2AtS5wscUea70boCX+0NXZKZbiaHAo= X-Talos-MUID: 9a23:BcY9uQQpwcNp3u90RXTCjhFLb+pNoJiPFW8dwLgilOCeMR5ZbmI= X-IronPort-AV: E=Sophos;i="5.99,252,1677560400"; d="scan'208";a="108401385" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , George Dunlap , Jan Beulich , "Stefano Stabellini" , Wei Liu , Julien Grall Subject: [PATCH 0/2] LICENSES improvements/corrections Date: Fri, 5 May 2023 14:05:31 +0100 Message-ID: <20230505130533.3580545-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Noticed in light of the recent LGPL changes to libacpi, but sadly only after the fact. Andrew Cooper (2): LICENSES: Improve the legibility of these files LICENSES: Remove the use of deprecated LGPL SPDX tags LICENSES/BSD-2-Clause | 4 ++++ LICENSES/BSD-3-Clause | 4 ++++ LICENSES/BSD-3-Clause-Clear | 4 ++++ LICENSES/CC-BY-4.0 | 5 +++++ LICENSES/GPL-2.0 | 17 +++++++++++------ LICENSES/LGPL-2.0 | 14 ++++++++++---- LICENSES/LGPL-2.1 | 14 ++++++++++---- LICENSES/MIT | 4 ++++ tools/libacpi/Makefile | 2 +- tools/libacpi/acpi2_0.h | 2 +- tools/libacpi/build.c | 2 +- tools/libacpi/dsdt.asl | 2 +- tools/libacpi/dsdt_acpi_info.asl | 2 +- tools/libacpi/libacpi.h | 2 +- tools/libacpi/mk_dsdt.c | 2 +- tools/libacpi/ssdt_laptop_slate.asl | 2 +- tools/libacpi/ssdt_pm.asl | 2 +- tools/libacpi/ssdt_s3.asl | 2 +- tools/libacpi/ssdt_s4.asl | 2 +- tools/libacpi/ssdt_tpm.asl | 2 +- tools/libacpi/static_tables.c | 2 +- 21 files changed, 65 insertions(+), 27 deletions(-) -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Fri May 05 13:05:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 13:05:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530328.825893 (Exim 4.92) (envelope-from ) id 1puv85-0004UK-CH; Fri, 05 May 2023 13:05:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530328.825893; Fri, 05 May 2023 13:05:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puv85-0004UD-9S; Fri, 05 May 2023 13:05:45 +0000 Received: by outflank-mailman (input) for mailman id 530328; Fri, 05 May 2023 13:05:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puv83-0003zO-Vt for xen-devel@lists.xenproject.org; Fri, 05 May 2023 13:05:43 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8a541022-eb45-11ed-b226-6b7b168915f2; Fri, 05 May 2023 15:05:42 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8a541022-eb45-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683291943; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=2bX75MfTm7xh700KZ13jcKWteUQ7dRrOiWoTRNhLPAY=; b=dYRbFxwfFlIYNr10Phm3SDW/0pzQHu6j3Oz9sesHXEKwmmSp2WLdO6zB HaYsxYBX5YEzskyOufH7ZUO1TrTS3L6huK3BtLIKpJnOHBAh+HEMgzLeU bD9pMPgBr9UHdMB7HM+p2OKm3ExuA15Iyx4qXGTsz1Jomi4qWZ74QljdP I=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 108401387 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:vn5UFaiUPoRXygEj5O7GNLDaX161eRAKZh0ujC45NGQN5FlHY01je htvXj+FM/7ZN2v3ctwnOd6290sA7ZSHztUwSwFtqS01ES0b9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWj0N8klgZmP6sT4QeDzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQhEx40P0yKhNjx44ODYNlgutQAAczkadZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJYw1MYH49tL7Aan3XWjtUsl+K44Ew5HDe1ldZ27nxKtvFPNeNQK25m27B/ jKapz2iUk5y2Nq32R+B1kKCl+/znhz7SJ0pBrKd3PBajwjGroAUIEJPDgbqyRWjsWalQM5WI UEQ/isorIAx+VatQ927WAe3yFabujYMVtwWFPc1gCmP167V7gCxFmUCCDlbZ7QOluU7WDgr3 V+hhM7yCHpkt7j9YWKQ8PKYoC2/PQARLHQefmkUQA0d+d7hrYovyBXVQb5e/LWd14OvX2uqm nbT8XZ43u9I5SIW60ml1Wn8rQv9+pHKdEkW1z39bm6Z/iBUYYHwMuRE9mPnAeZ8wJexFwfR5 yJZypHHs4jiHrnWynXTHbxl8KWBoq/cbWaC2QMH84wJrWzFxpK1QWxHDNiSzm9NO91MRzLma VS7Veh5tM4KZyvCgUOajuuM5yUWIUvIT46Nugj8NIYmX3SIXFbvENtSTUCRxXvxt0MnjLsyP 5yWGe71UyZBU/45kGPnH7xCuVPO+h3SOEuJHcyrp/hZ+eP2iIGppUctbwLVM7FRAFKsqwTJ6 ddPX/a3J+FkeLSmOEH/qNdDRW3m2FBnXfgaXeQLLL/cSuencUl9Y8LsLUQJJ9U5w/8PybiVr hlQmCZwkTLCuJEOEi3SAlgLVV8ldcwXQa4TVcD0AWuV5g== IronPort-HdrOrdr: A9a23:g7a6Ka4Z7h2xCF+HEAPXwM/XdLJyesId70hD6qkRc20yTiX8ra rCoB11737JYVoqOE3I4OrvBEDiewK6yXcW2/h1AV7KZmCP01dASrsSjrcKqweNJ8SUzJ846U 4PSdkdNDUuZWIUsS6ciDPIauod/A== X-Talos-CUID: =?us-ascii?q?9a23=3A7FiXjGpgGp8n1aa4XKKADqrmUfkeXESMkH7TGQi?= =?us-ascii?q?bOF5DeLGpWXy9/awxxg=3D=3D?= X-Talos-MUID: 9a23:pZ/JGAmvWLgeA+bgXzoldnpyEcNM04q/CHwOrpUWpPKWOglaNQeS2WE= X-IronPort-AV: E=Sophos;i="5.99,252,1677560400"; d="scan'208";a="108401387" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , George Dunlap , Jan Beulich , "Stefano Stabellini" , Wei Liu , Julien Grall Subject: [PATCH 2/2] LICENSES: Remove the use of deprecated LGPL SPDX tags Date: Fri, 5 May 2023 14:05:33 +0100 Message-ID: <20230505130533.3580545-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230505130533.3580545-1-andrew.cooper3@citrix.com> References: <20230505130533.3580545-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain The SPDX forms without an explicit -only or -or-later suffix are deprecated and should not be used. The recent changes to libacpi are the only examples in tree, so fix them all up. For GPL, we have many examples using deprecated tags. For now, just identify them as such recommend that no new instances get added. Signed-off-by: Andrew Cooper --- CC: George Dunlap CC: Jan Beulich CC: Stefano Stabellini CC: Wei Liu CC: Julien Grall Unsure whether this should get some Fixes: tags or not. Note also that Jenny's "[PATCH v4 2/2] acpi: Add TPM2 interface definition." wants its SPDX tag correcting as per this patch. --- LICENSES/GPL-2.0 | 12 ++++++------ LICENSES/LGPL-2.0 | 8 ++++---- LICENSES/LGPL-2.1 | 8 ++++---- tools/libacpi/Makefile | 2 +- tools/libacpi/acpi2_0.h | 2 +- tools/libacpi/build.c | 2 +- tools/libacpi/dsdt.asl | 2 +- tools/libacpi/dsdt_acpi_info.asl | 2 +- tools/libacpi/libacpi.h | 2 +- tools/libacpi/mk_dsdt.c | 2 +- tools/libacpi/ssdt_laptop_slate.asl | 2 +- tools/libacpi/ssdt_pm.asl | 2 +- tools/libacpi/ssdt_s3.asl | 2 +- tools/libacpi/ssdt_s4.asl | 2 +- tools/libacpi/ssdt_tpm.asl | 2 +- tools/libacpi/static_tables.c | 2 +- 16 files changed, 27 insertions(+), 27 deletions(-) diff --git a/LICENSES/GPL-2.0 b/LICENSES/GPL-2.0 index 0022a7c17788..dcd969aa85b5 100644 --- a/LICENSES/GPL-2.0 +++ b/LICENSES/GPL-2.0 @@ -1,8 +1,9 @@ -Valid-License-Identifier: GPL-2.0 Valid-License-Identifier: GPL-2.0-only -Valid-License-Identifier: GPL-2.0+ Valid-License-Identifier: GPL-2.0-or-later +Deprecated-Identifier: GPL-2.0 +Deprecated-Identifier: GPL-2.0+ + SPDX-URL: https://spdx.org/licenses/GPL-2.0.html Usage-Guide: @@ -13,13 +14,12 @@ Usage-Guide: For 'GNU General Public License (GPL) version 2 only' use: SPDX-License-Identifier: GPL-2.0-only - or (now deprecated) - SPDX-License-Identifier: GPL-2.0 For 'GNU General Public License (GPL) version 2 or any later version' use: - SPDX-License-Identifier: GPL-2.0+ - or SPDX-License-Identifier: GPL-2.0-or-later + The deprecated tags should not be used for any new additions. Where + possible, their existing uses should be phased out. + License-Text: GNU GENERAL PUBLIC LICENSE diff --git a/LICENSES/LGPL-2.0 b/LICENSES/LGPL-2.0 index 2fa16d72eabf..c960ba3ce3b8 100644 --- a/LICENSES/LGPL-2.0 +++ b/LICENSES/LGPL-2.0 @@ -1,5 +1,5 @@ -Valid-License-Identifier: LGPL-2.0 -Valid-License-Identifier: LGPL-2.0+ +Valid-License-Identifier: LGPL-2.0-only +Valid-License-Identifier: LGPL-2.0-or-later SPDX-URL: https://spdx.org/licenses/LGPL-2.0.html @@ -10,11 +10,11 @@ Usage-Guide: guidelines in the licensing rules documentation. For 'GNU Library General Public License (LGPL) version 2.0 only' use: - SPDX-License-Identifier: LGPL-2.0 + SPDX-License-Identifier: LGPL-2.0-only For 'GNU Library General Public License (LGPL) version 2.0 or any later version' use: - SPDX-License-Identifier: LGPL-2.0+ + SPDX-License-Identifier: LGPL-2.0-or-later License-Text: diff --git a/LICENSES/LGPL-2.1 b/LICENSES/LGPL-2.1 index b366c7e49199..4553664b76bf 100644 --- a/LICENSES/LGPL-2.1 +++ b/LICENSES/LGPL-2.1 @@ -1,5 +1,5 @@ -Valid-License-Identifier: LGPL-2.1 -Valid-License-Identifier: LGPL-2.1+ +Valid-License-Identifier: LGPL-2.1-only +Valid-License-Identifier: LGPL-2.1-or-later SPDX-URL: https://spdx.org/licenses/LGPL-2.1.html @@ -10,11 +10,11 @@ Usage-Guide: guidelines in the licensing rules documentation. For 'GNU Lesser General Public License (LGPL) version 2.1 only' use: - SPDX-License-Identifier: LGPL-2.1 + SPDX-License-Identifier: LGPL-2.1-only For 'GNU Lesser General Public License (LGPL) version 2.1 or any later version' use: - SPDX-License-Identifier: LGPL-2.1+ + SPDX-License-Identifier: LGPL-2.1-or-later License-Text: diff --git a/tools/libacpi/Makefile b/tools/libacpi/Makefile index aa9c520cbe85..bcfcd852f92f 100644 --- a/tools/libacpi/Makefile +++ b/tools/libacpi/Makefile @@ -1,4 +1,4 @@ -# SPDX-License-Identifier: LGPL-2.1 +# SPDX-License-Identifier: LGPL-2.1-only # # Copyright (c) 2004, Intel Corporation. diff --git a/tools/libacpi/acpi2_0.h b/tools/libacpi/acpi2_0.h index 212f5ab64182..e00b29854be0 100644 --- a/tools/libacpi/acpi2_0.h +++ b/tools/libacpi/acpi2_0.h @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: LGPL-2.1 */ +/* SPDX-License-Identifier: LGPL-2.1-only */ /* * Copyright (c) 2004, Intel Corporation. */ diff --git a/tools/libacpi/build.c b/tools/libacpi/build.c index 830d37c61f03..3142e0ac84c0 100644 --- a/tools/libacpi/build.c +++ b/tools/libacpi/build.c @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: LGPL-2.1 */ +/* SPDX-License-Identifier: LGPL-2.1-only */ /* * Copyright (c) 2004, Intel Corporation. * Copyright (c) 2006, Keir Fraser, XenSource Inc. diff --git a/tools/libacpi/dsdt.asl b/tools/libacpi/dsdt.asl index c6691b56a986..32b42f85ae9f 100644 --- a/tools/libacpi/dsdt.asl +++ b/tools/libacpi/dsdt.asl @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: LGPL-2.1 */ +/* SPDX-License-Identifier: LGPL-2.1-only */ /****************************************************************************** * DSDT for Xen with Qemu device model * diff --git a/tools/libacpi/dsdt_acpi_info.asl b/tools/libacpi/dsdt_acpi_info.asl index c6e82f1fe6a7..6e114fa23404 100644 --- a/tools/libacpi/dsdt_acpi_info.asl +++ b/tools/libacpi/dsdt_acpi_info.asl @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: LGPL-2.1 */ +/* SPDX-License-Identifier: LGPL-2.1-only */ Scope (\_SB) { diff --git a/tools/libacpi/libacpi.h b/tools/libacpi/libacpi.h index acf012e35578..7ae28525f604 100644 --- a/tools/libacpi/libacpi.h +++ b/tools/libacpi/libacpi.h @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: LGPL-2.1 */ +/* SPDX-License-Identifier: LGPL-2.1-only */ /****************************************************************************** * libacpi.h * diff --git a/tools/libacpi/mk_dsdt.c b/tools/libacpi/mk_dsdt.c index c74b270c0c5d..34f6753f6193 100644 --- a/tools/libacpi/mk_dsdt.c +++ b/tools/libacpi/mk_dsdt.c @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: LGPL-2.1 */ +/* SPDX-License-Identifier: LGPL-2.1-only */ #include #include diff --git a/tools/libacpi/ssdt_laptop_slate.asl b/tools/libacpi/ssdt_laptop_slate.asl index 494f2d048d0a..69fd504c19fc 100644 --- a/tools/libacpi/ssdt_laptop_slate.asl +++ b/tools/libacpi/ssdt_laptop_slate.asl @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: LGPL-2.1 */ +/* SPDX-License-Identifier: LGPL-2.1-only */ /* * ssdt_conv.asl * diff --git a/tools/libacpi/ssdt_pm.asl b/tools/libacpi/ssdt_pm.asl index e577e85c072b..db578d10ac3e 100644 --- a/tools/libacpi/ssdt_pm.asl +++ b/tools/libacpi/ssdt_pm.asl @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: LGPL-2.1 */ +/* SPDX-License-Identifier: LGPL-2.1-only */ /* * ssdt_pm.asl * diff --git a/tools/libacpi/ssdt_s3.asl b/tools/libacpi/ssdt_s3.asl index 8f3177ec5adc..f6e9636f4759 100644 --- a/tools/libacpi/ssdt_s3.asl +++ b/tools/libacpi/ssdt_s3.asl @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: LGPL-2.1 */ +/* SPDX-License-Identifier: LGPL-2.1-only */ /* * ssdt_s3.asl * diff --git a/tools/libacpi/ssdt_s4.asl b/tools/libacpi/ssdt_s4.asl index 979318eca1f5..8014f5fc9014 100644 --- a/tools/libacpi/ssdt_s4.asl +++ b/tools/libacpi/ssdt_s4.asl @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: LGPL-2.1 */ +/* SPDX-License-Identifier: LGPL-2.1-only */ /* * ssdt_s4.asl * diff --git a/tools/libacpi/ssdt_tpm.asl b/tools/libacpi/ssdt_tpm.asl index 6c3267218f3b..944658d25177 100644 --- a/tools/libacpi/ssdt_tpm.asl +++ b/tools/libacpi/ssdt_tpm.asl @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: LGPL-2.1 */ +/* SPDX-License-Identifier: LGPL-2.1-only */ /* * ssdt_tpm.asl * diff --git a/tools/libacpi/static_tables.c b/tools/libacpi/static_tables.c index 631fb911413b..715f46fee05c 100644 --- a/tools/libacpi/static_tables.c +++ b/tools/libacpi/static_tables.c @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: LGPL-2.1 */ +/* SPDX-License-Identifier: LGPL-2.1-only */ /* * Copyright (c) 2004, Intel Corporation. * Copyright (c) 2006, Keir Fraser, XenSource Inc. -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Fri May 05 13:06:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 13:06:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530339.825903 (Exim 4.92) (envelope-from ) id 1puv98-0005cG-SL; Fri, 05 May 2023 13:06:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530339.825903; Fri, 05 May 2023 13:06:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puv98-0005c9-PW; Fri, 05 May 2023 13:06:50 +0000 Received: by outflank-mailman (input) for mailman id 530339; Fri, 05 May 2023 13:06:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puv96-0005Hq-Q0 for xen-devel@lists.xenproject.org; Fri, 05 May 2023 13:06:48 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20622.outbound.protection.outlook.com [2a01:111:f400:7e1a::622]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b09b0e98-eb45-11ed-8611-37d641c3527e; Fri, 05 May 2023 15:06:47 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AS4PR04MB9337.eurprd04.prod.outlook.com (2603:10a6:20b:4e5::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Fri, 5 May 2023 13:06:44 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%7]) with mapi id 15.20.6363.027; Fri, 5 May 2023 13:06:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b09b0e98-eb45-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X6/3/Ys4PDb7OFaBf3sNTgJjxjHdbKYT3NtSSDR2vY8NwtEV61POKUWOFtxyhfo9YIUFojXQ4KsmP8VV2ZEyBDPzDk0D5OQatvHtFdsZbriUZOuduJ80LHU49kdA9ucEX4mQ94B0I3K582wBv/vm2cP08FBAeU6KhnPdscbJp7GnaAtu/Bc6qobY2wOnUJa1k1mKLsbOCCUmYv7hUBnS195oOCtFHugEhQZqUKr7lWwhSa6jpcAC8vB0hovXM0j2TVj1cNYc9he0gwnKk3Gl7GVmKEk0CksDA23qmC6HfoD6d+wumRNjdNeq/TbIf/kddm5Ne4pCoj6PhKf2vmY0tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5fi21jemoaQ/IahEePuXb4ql0t8nqpe0QrayBGOWBbM=; b=W2x3oeYCdAPHPsUfTD99rn2WKjzKRn7c0jm1z6Y4T1yrp5kO9c6Je898YsgWF6ej6bT51VHecaEqk3l9cnwakUlUAfKhuzC5XAIiUOM2/+6Q6kFtYrYeiw8W1YfyYzVcov56B2N4lQ0L9xk+QA6SrDZSZ24FY/FLq0otGI2/Pa7I/+QS/Mz/Mz5Kq4ZR/Fdud0+0oVPuwS+D4ql7DdwR47CrtISQX1197C4u9B6dsWK7Ov8VZUZA0HC/r8S/9/BHlmzfGFDF4BKlscR7suCXw2v9Tdi3P3x3sUbJ+dJRUuIJMWtIyfi8L1iCXZWpYYG0JnEwDHnTDX8DdPb18VgH/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5fi21jemoaQ/IahEePuXb4ql0t8nqpe0QrayBGOWBbM=; b=OYcQ+WXnHA0rYlh5HW02H8d/0dFnQRFbg9AeXmd3wyoUxepUbpM6L78XdJh97AJhoZ2jUDZKJShjRg1r74le/gWX5N+V9iwE52VoiI2xvI1pFIoC+gPKvldnc6MIvW2txpYcEDxQahfZPgcoWWFAYf2yAorhR2mjYXC4+pxc8WUgAChnTrdBxQSMsQqR5FHzrAI1IdUieHFied16YGMzYIgiUILiSRFS8JJVgLOMvcUIqqARzLhCywJ6K2FXJywcfwtxG6jsH5ZmSMp6qQwUTVor2k8Ek3O8mrTogQAiKvJ2ziZfOVR7q7yRFWMep4FbBUmEog+WplsNKBx6SgrgRg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 5 May 2023 15:06:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 1/2] LICENSES: Improve the legibility of these files Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Xen-devel References: <20230505130533.3580545-1-andrew.cooper3@citrix.com> <20230505130533.3580545-2-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230505130533.3580545-2-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0174.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b4::7) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|AS4PR04MB9337:EE_ X-MS-Office365-Filtering-Correlation-Id: cf45689d-f97e-4be8-bbb0-08db4d699383 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Bnyk6Wx3DJFMeLKeR/igUv4DCbFygvGeyk5QNqYrJ9WvNpBMPWBr9w3P1qqCLXJN9gJ/T2p2QuUSygI5j6qzGsE7gDZ6ryvMT1AkiQIs3M5xMd5j1gO9eAc9ylwL+NHMAGerp03RZQbccMNj2bdDyBpPTxWX984NXs4vBIYQ/HYcnhU3/yBdSK11WVovjLcpQKLtl76i8UmOm6kp7np09ner6l5litb04EvuwEpMrwN2Jt7gjC5ul07jPyNIsE9q5gBHEuJbiuVYziqWGY2R88TO4RNBUTYc5A2INoVeNUfq2B//6U1Sw62ouEnfod+bxpOaVO+oZvQyEGupadY1yQn7CpFAASe73X0B3dPp7tZHjMvtIIQ4JGHiwHeVZRgZtnO/uYfex4FsRuJQfB28z3aDOVL1frzFihn9crcXbw4muq2JuoOK5gwCPbwobZYHFEtyjrF/o80+FgPGHcFngR8D8sqlSzTW6TytjfKDZ8J3GOBpIuRoykzbHLGWTvg5azIDTi2WS86c3aoFOkKO6/qbkxc0sq+ZYFnhWwY88+BXabxu5w5kOqmDqq+AhCB5pp3i07ItTZ5Naah+v4foyOAZt1oHlQ2FH9CmXCh09DlbVlq392uXOklVGbu6ReLPI2wZqtPtn65pyo/3oXUVXQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(376002)(136003)(396003)(366004)(39860400002)(451199021)(6486002)(478600001)(54906003)(2616005)(53546011)(186003)(6512007)(6506007)(26005)(8676002)(2906002)(38100700002)(5660300002)(36756003)(558084003)(4326008)(8936002)(66556008)(66476007)(6916009)(41300700001)(66946007)(31696002)(86362001)(316002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aWpkWjJXc3U2aXplUFpvdExYYWlnakdPNFBNWFlKaytnVkFzMlN5bVNQQ1J3?= =?utf-8?B?dnhXTEUwY01vRmRjc2x3VVFpRURFTWhsbnhJSHp4TlMyZGZuM0tzQ28yK29I?= =?utf-8?B?b3QrUkZ0UUo3dkV5a1c1Q0xweVNGSy9vUWRMTVMvZmVKTUE4RWI1Nzl5alNw?= =?utf-8?B?b08rREprdWVYaGVVTjdOYTRYYzBRS2hsNllWbnA4NUtzZFNZT3E3b3RJZ01J?= =?utf-8?B?NWFzam9ENWdxVjFOVFNiK043TDdqLzZvclJoYXY2UTRPYUVMeVI0SnptRFRZ?= =?utf-8?B?VkhzMVAyaWFza0lmNTRTZUJuVkxhU2ttZ1JWZnhHUFpzMGp4MDVkTkZxMW8r?= =?utf-8?B?M0FPdVY4eU9EbnNhaHVTWHVqaXZXTExHbXo0dWlKZjh1RVl3cFRrbVI2UkhK?= =?utf-8?B?a0VRQVc2aUw3KzBxUGRiTTRWSlhyM3JFTy9OaE9lUC9QYmpqZEpudXRTL25W?= =?utf-8?B?SHk2QjErZlpxaFlzays2RE02bXhYL05GMFV3azVJZnM4cjVOSWJiT1Rnenh1?= =?utf-8?B?N0ZFbkRYUXdQZ1FlcTl5bzlabWVZRFRYekZONzAxVFFHYU1XaEJPbk1PY0Z4?= =?utf-8?B?b2RQVFBaZU1HSGx5QWF1Syt4ZER0ZVlKdEJOdDRENW1qNHhnTjdmOUVwSlZQ?= =?utf-8?B?Rml4TGdtcDdXc1E1QWFIRjNhUHZQTSs2V2xWeVZNOUF2Zy95RDlDNjZBZkVH?= =?utf-8?B?SXAwS2UzRnZPM29vSVhQVEJIVUtwaXZtajZJaWJsTnFGSXVvTzBacnRGR0Zr?= =?utf-8?B?ZmZQejFiYUQ2by80b1JpNDJvYmtDbW4yMkdvOG0rVU5zV3FuZ0FPMkpNeGRU?= =?utf-8?B?cXdsWWtJVnhsbm9pWGVCTzNkNzBoZnVrZDkySlA2MUY2dlRXam1xZ0RvWVRJ?= =?utf-8?B?eThyQzYzVnRqTWd4MkZIM2Jxc0NhZ3BsUzBNcktmdHdpdlZjRDNKcHdEcWJZ?= =?utf-8?B?YzVqeStDbTRGNDlhNnFvZ25qWDFoMy9nYWRrMWRyUjdGUXk5QTY0bTYzbms4?= =?utf-8?B?dndxcU0rbUdnVUFDQmlYb2tId2h1SWY5eEVIWXViTi9wTC92VUczamVVRlQ2?= =?utf-8?B?cDFjRWpoMUtBQ0NRelNOSjF0aWlwejAvdUNwalU4dVhrVDFYZFllR2grWE00?= =?utf-8?B?SjhHYnBORHBFZUZIYVJmTTdzajFYQm9BMExxNDNMOVEzODBsNGdKanpwVFJ1?= =?utf-8?B?Q0ROb2hEZ1ZoL3NPTnVPUTF4U3hIUWhjNHBvU0cvSENCdDlSZTBrdHVBSWpj?= =?utf-8?B?MkFFTDNzUVBaV0E2dVlXcUxrNVUvRUQvODNKaWEzUHh2b1pOUzFlZlFpYnd5?= =?utf-8?B?dDduMFJqcFhTWEl4MWFKRGp6cFR0a2JoU0l6STVjRSs5elZUVHNCRzBTTzNk?= =?utf-8?B?SUhqNzF0MmVJSXUzQWprRk1RaFIxeG9tcnMyRlNsYnFZbG9DbjFnanZaRzI4?= =?utf-8?B?RVFhbU9ROWxkM0ljcXBvYTBqZHdMTXBDSHBMb3ZIUnlUYTBlWHZHRzIwcE50?= =?utf-8?B?TnNPcTNxVUY2MldBWjdEU3dCb2JjQU5HTUtHMmdTSWN1YWpPZzNmdzVZVUpV?= =?utf-8?B?RjY1NjZHSEUwMnpqQTNYa2hrZ2gwKzd6YVNzM3hYK0M0VmpYR05SbFRNMmRj?= =?utf-8?B?cXBXVGZvRU9zV2daQVNNSHVKMGVLcW9wM2RaN2lVUGJBaEY4bjVFdk1uR0dP?= =?utf-8?B?QXRxRlhLQTR0Ni9taEZQVVpIRlFSYTNoWUpJcndSV0R3YTBYSnVpRFVwR1FQ?= =?utf-8?B?bDZpTEZid1FFRVBYc2RTZnFIK0pwZDNZVnI0azdKNUQ1c2wxZENZQURQdWsz?= =?utf-8?B?SWtoOVVCWURIYkQyQXBBb1QzeXRFeSswVjNwVXZ4QXFCbGtwaDRXblhqc2Vh?= =?utf-8?B?eU5ubEVsZWNFM3JOM0lZNjhDQmNYNWtQYXVGZkRrKzdVNXIxN21wbldWTFlw?= =?utf-8?B?UXR2VEhXQUlCaHZJUmFWUlg2bE5HakkxQjhHdVlwNHYyUmhsaENIc2NvaExU?= =?utf-8?B?SFFJYXFMU3RHUlI0bDVhMkx3UG1SajlxMCtnd1RQa2hRcHBqdHFKUit0eGFI?= =?utf-8?B?R1FXZXZOZEE5NWo2QXFjZWwrbkR1L1dKRmh3clZROThLcVpXOUMwdGNtTk43?= =?utf-8?Q?mCF0cKcPZOgjRz7XzFWK4pJLw?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf45689d-f97e-4be8-bbb0-08db4d699383 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 13:06:44.6295 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: szisnl/g/ITnM56g37H6Qb7/IMSpOuJPQFH9HR7bkLUv9yXoF7sNIGpNt/+47EFvLwvCUF8FKum+8zt8yol1yQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9337 On 05.05.2023 15:05, Andrew Cooper wrote: > A few newlines go a very long way > > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Fri May 05 13:11:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 13:11:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530344.825912 (Exim 4.92) (envelope-from ) id 1puvDm-00079c-Eo; Fri, 05 May 2023 13:11:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530344.825912; Fri, 05 May 2023 13:11:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puvDm-00079V-C6; Fri, 05 May 2023 13:11:38 +0000 Received: by outflank-mailman (input) for mailman id 530344; Fri, 05 May 2023 13:11:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puvDl-00079P-4g for xen-devel@lists.xen.org; Fri, 05 May 2023 13:11:37 +0000 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [2607:f8b0:4864:20::62c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5c691316-eb46-11ed-b226-6b7b168915f2; Fri, 05 May 2023 15:11:35 +0200 (CEST) Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1ab1ce53ca6so12546535ad.0 for ; Fri, 05 May 2023 06:11:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5c691316-eb46-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683292294; x=1685884294; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=kFXuBNBO1/GgAF8ppAIzcxSbDhbGubAz15oXF2l6RaU=; b=EmFSas1IcVTUjHuldQ2/6zNLezKywUWrBa9ONtWGtBr44Oh2n7g4qgPDHQfRrPVIf9 gFU79gd1sYWfdZ2HqumFD0Gb4FhK64HSYt7hYh810wzM7DUttkDzTJifoX65Yh5ajKdL kN1AP9DB9XkXBMjWa3Hi6/Og9NQ2q5JnKcBRoLGw+DECydT49kl/2q7stAzYhqAXG6kr o5zg221k5noTVc/+Z/zq7yoriUvoPSF7aC3T4qtleMQmOnRnNiUTRc80IM6ddiJ8d1Vi V8GZkhebIZ01+0X5bO7bCmMGZhftmMTe2YW3oZv7cg/SKmCwEBKj8NZEH4w6KXY73pmS cQzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683292294; x=1685884294; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kFXuBNBO1/GgAF8ppAIzcxSbDhbGubAz15oXF2l6RaU=; b=htw9xHRfSArlVktpEFtSw/fsGeZC99YTB0uFkF6E0liXKPkJGYAo1qUqnx6hg5tuyP 3No2b052UtLkzYKTvKrHjWoQzSx5gQIMlmkoiGrg5X+aPDZWIS4bAgNA9Yfaz5c3H2Oz auibYEMRK9jBprOglOcAhnIZCQx4v205kgDWtryKioPT2xJKdhjs97pqybkvfoHLJ1nk hIXQXg0C7HGyCAU0sVyM6A7tDA5ksWKnGviF/dtNhK3RgEdf6ZpQPMDx5TKtDZYdqVsG FbcwC7SU0LSkyjz3QBHL8M60MxoC5qPhv82z4VA3usRfRN57nf142TbTHEXg63qddohm Z2XQ== X-Gm-Message-State: AC+VfDxW2H2q8bXdXaPBY3aKl8fLYM5jIHz5hQobye//vYlO2rcBreW+ PlyThS0Ea3MyQbNbSm4KUDqtRr2FiVSZObg5Bm4= X-Google-Smtp-Source: ACHHUZ4ocOAy1V5T9RjnZJ17ugGMfoiOcHse95/8gKexFyzq4yZczoV1WVOyAJTomSbTL+cXt7IoIs33gFSE/LLcw0Y= X-Received: by 2002:a17:902:eb4b:b0:1a6:7632:2b20 with SMTP id i11-20020a170902eb4b00b001a676322b20mr1393189pli.40.1683292294302; Fri, 05 May 2023 06:11:34 -0700 (PDT) MIME-Version: 1.0 References: <817f0320316dd144826add0ac834618026b91160.1680165772.git.viresh.kumar@linaro.org> <25fb2b71-b663-b712-01cd-5c75aa4ccf9b@gmail.com> <20230404234228.vghxrrj6auy7zw4c@vireshk-i7> <20230505061934.jm3bwjgsl5hf5rns@vireshk-i7> In-Reply-To: <20230505061934.jm3bwjgsl5hf5rns@vireshk-i7> From: Oleksandr Tyshchenko Date: Fri, 5 May 2023 16:11:23 +0300 Message-ID: Subject: Re: [PATCH] libxl: arm: Allow grant mappings for backends running on Dom0 To: Viresh Kumar Cc: Vincent Guittot , xen-devel@lists.xen.org, stratos-dev@op-lists.linaro.org, Juergen Gross , Julien Grall , =?UTF-8?B?QWxleCBCZW5uw6ll?= , Anthony PERARD , Mathieu Poirier , Erik Schilling Content-Type: multipart/alternative; boundary="00000000000041518705faf207ed" --00000000000041518705faf207ed Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Viresh [sorry for the possible format issues] On Fri, May 5, 2023 at 9:19=E2=80=AFAM Viresh Kumar wrote: > On 05-04-23, 05:12, Viresh Kumar wrote: > > On 04-04-23, 21:16, Oleksandr Tyshchenko wrote: > > > ok, probably makes sense > > > > While testing both foreign and grant mappings I stumbled upon another > > related problem. How do I control the creation of iommu node from > > guest configuration file, irrespective of the domain backend is > > running at ? This is what we have right now: > > > > - always create iommu nodes if backend-dom !=3D 0 > > - always create iommu nodes if forced_grant =3D=3D 1 > > > > what I need to cover is > > - don't create iommu nodes irrespective of the domain > > > > This is required if you want to test both foreign and grant memory > > allocations, with different guests kernels. i.e. one guest kernel for > > device with grant mappings and another guest for device with foreign > > mappings. There is no way, that I know of, to disable the creation of > > iommu nodes. Of course we would want to use the same images for kernel > > and other stuff, so this needs to be controlled from guest > > configuration file. > > Any input on this please ? > I was going to propose an idea, but I have just realized that you already voiced it here [1] )) So what you proposed there sounds reasonable to me. I will just rephrase it according to my understanding: We probably need to consider transforming your "forced_grant" to something three-state, for example "grant_usage" (or "use_grant" as you suggested) which could be "default behaviour" or "always disabled", or "always enabled". With "grant_usage=3Ddefault" we will get exact what we have at the moment (only create iommu nodes if backend-domid !=3D 0) With "grant_usage=3Ddisabled" we will force grants to be always disabled (don't create iommu nodes irrespective of the domain) With "grant_usage=3Denabled" we will force grants to be always enabled (always create iommu nodes irrespective of the domain) [1] https://lore.kernel.org/xen-devel/20230505093835.jcbwo6zjk5hcjvsm@vireshk-i= 7/ > > -- > viresh > --=20 Regards, Oleksandr Tyshchenko --00000000000041518705faf207ed Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello Viresh
[sorry for the possible format issues]

On Fri, May 5, 2023 at 9= :19=E2=80=AFAM Viresh Kumar <viresh.kumar@linaro.org> wrote:
On 05-04-23, 05:12, Viresh Kumar w= rote:
> On 04-04-23, 21:16, Oleksandr Tyshchenko wrote:
> > ok, probably makes sense
>
> While testing both foreign and grant mappings I stumbled upon another<= br> > related problem. How do I control the creation of iommu node from
> guest configuration file, irrespective of the domain backend is
> running at ? This is what we have right now:
>
> - always create iommu nodes if backend-dom !=3D 0
> - always create iommu nodes if forced_grant =3D=3D 1
>
> what I need to cover is
> - don't create iommu nodes irrespective of the domain
>
> This is required if you want to test both foreign and grant memory
> allocations, with different guests kernels. i.e. one guest kernel for<= br> > device with grant mappings and another guest for device with foreign > mappings. There is no way, that I know of, to disable the creation of<= br> > iommu nodes. Of course we would want to use the same images for kernel=
> and other stuff, so this needs to be controlled from guest
> configuration file.

Any input on this please ?


I was going to propose an idea, but I have just realized that you alread= y voiced it here [1] ))
So what you proposed there sounds reasonable to = me.

I will just rephrase it according to my understanding:

We= probably need to consider transforming your "forced_grant" to so= mething three-state, for example
"grant_usage" (or "use_g= rant" as you suggested) which could be "default behaviour" o= r "always disabled", or "always enabled".

With &= quot;grant_usage=3Ddefault" we will get exact what we have at the mome= nt (only create iommu nodes if backend-domid !=3D 0)
With "grant_us= age=3Ddisabled" we will force grants to be always disabled (don't = create iommu nodes irrespective of the domain)
With "grant_usage=3D= enabled" we will force grants to be always enabled (always create iomm= u nodes irrespective of the domain)


=
=C2=A0

--
viresh


--
= Regards,

Oleksandr Tyshche= nko
--00000000000041518705faf207ed-- From xen-devel-bounces@lists.xenproject.org Fri May 05 13:14:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 13:14:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530347.825923 (Exim 4.92) (envelope-from ) id 1puvFz-0007iN-RR; Fri, 05 May 2023 13:13:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530347.825923; Fri, 05 May 2023 13:13:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puvFz-0007iG-OU; Fri, 05 May 2023 13:13:55 +0000 Received: by outflank-mailman (input) for mailman id 530347; Fri, 05 May 2023 13:13:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puvFz-0007iA-1i for xen-devel@lists.xenproject.org; Fri, 05 May 2023 13:13:55 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0629.outbound.protection.outlook.com [2a01:111:f400:fe0c::629]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aeaa9810-eb46-11ed-8611-37d641c3527e; Fri, 05 May 2023 15:13:53 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DU0PR04MB9321.eurprd04.prod.outlook.com (2603:10a6:10:354::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.27; Fri, 5 May 2023 13:13:51 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%7]) with mapi id 15.20.6363.027; Fri, 5 May 2023 13:13:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aeaa9810-eb46-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h1Ns65s5gzk3qVBjgG/e7doc1RcFesMfvCAY+ZYh5bF8O7j5WOVDj4ShIjE3THNT6Lg6k6QGxIcXA6kw2knQn9qxohiNgxBUG64PcDlBSBQBy+9iU/zx0Ol4TkmHU9vU06ydbXcDsNvRyhqYTq877GuhpITUnnD47q1xlmQt0azr0CiVTtPwULV6XAzT5JpyYvEhVLRd3GUWZq9Tm7WO8BU/ORFvjJEdyR7ZwmdZSD/TGbPT44do08eF0CdsO1lVV/BvTdOwSp9DUzgdy+rxYO5NVvgp4wp8wkxZK1w/CFRZWBn0cj7gVDneTFC/Mftm1493tRvSdRg42EALbib04w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sy7ekOGL7Ui1hZMNT3Lmp3AyM0dO+DQEghWHmulQAgA=; b=lkzAyPg3Nm7Hggv0ujhinXZ+KC3RpLBMUkdcO89ELUMHPHD2a0XH/g2oV+A8pOVHee7VarixSZUUkypWC7I7EY+FAczVjaJlnJMqNqSQucsTJjHmYUQ+kOe8KPSPp+oMYoBGuQoSOTnJGsux5quI1rjr/9QtUXw9wxKkpjwloTfgS139f+lD3nLZYUfoc6F9Gd1pC+qCfMfzfGX88vf57oFvmYSYAeyDY+MTTY4kHUAjL0ooTrIKh6BrZZD8W/3OXSWzezHbQn48GrvoH7P+kiPGoW47A6k7YAjg0GRpuf7qV4YaYGKPMugm8OcZWy97y8ib2pPu5oQCNzofvgh5Yw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sy7ekOGL7Ui1hZMNT3Lmp3AyM0dO+DQEghWHmulQAgA=; b=bn6WdBEh253JrxnLtrTntVDJ8OuZNn1+ei9U83v926DU8LeKt01OMUubtqBjef7R+elcECsaBKJY4Z09j9Hlj7mkri/FgQPu7bLUEkKGATzq77acLwz0X9N2OxTnoaYor06kvuiTK/6rcit9VkhSdWgc8UdsV7HcO4S9/+yKt/066zKcf9xtt/E9jioS9RWP8M3kQY9eYlEvoHHo3jqo9xvT/hqMQS3oqEnscoRvOgtfbwMua3SFZE7EMT1essFJ01bT+LQNaQQLa4bTDw+wgkAcIC1W2nuifjREzIMwZquZoFD2wEd91ovrDdaST3bH4n5ESVTlZQJlkoQ+yPIKNw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <40d70f11-37e7-ff29-37c1-a94d3e286455@suse.com> Date: Fri, 5 May 2023 15:13:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 2/2] LICENSES: Remove the use of deprecated LGPL SPDX tags Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Xen-devel References: <20230505130533.3580545-1-andrew.cooper3@citrix.com> <20230505130533.3580545-3-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230505130533.3580545-3-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0238.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b2::13) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|DU0PR04MB9321:EE_ X-MS-Office365-Filtering-Correlation-Id: 9a1c70ea-b93d-4ebd-76af-08db4d6a91ef X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oGOd4uxUd0desVQfbJFQq2WcbRIjz3mSImVXhQKeuOyJhdO3ZIS4ZMfsSIUBfG2FuRWt+BTbejxThlLeI99OjtXK4oLhpOACLGRPucj6+nf65rn7ONuEWOmz5GjqB7uG31VgWWqX+dYM/xUPBu1eDHCSlpw5bA7+D1C9C4LjV5+P1AkhxXCZMIl6qJyh0mYKcR5eaPXbn6z079panE57wACvT99x2fW2hb+UZYGYCI+/nk2kf/tfekkZ1N4ehz7g2UgWN+7iZqwebzyiaJAJFSYx7MeGcoy2QlXKRNhzikvEn/mMFwDex4jgc1ggb8WDUgITDwK56OH7CI9DfwOQlm/3MGdpcysS94pf8cbIHK1xFLtiPgpfZS3UBDxJTHpZKDYkxD6iARBU+2mrrFlN1+N3TotpnMpKhlnCxjOvdTEZYd94ijR+2u29MOyS5s/DispWvPx1UIvsThWRsNDpw6ODfdC/TQJc00GUF0aoHZfluFeJtan/WGDB8/j1kCin84pfj5ejUyAFAjUZt02gFAJkmFtO2NtifeXNH9+rHRgPapVkHEZwPjp3MI12How48LreYOJFCQHU58582BiRxs8CVA7BqRWQ++u07or87E6FnyHfB7fIHAv6v2ZolJGC X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(346002)(396003)(366004)(376002)(136003)(451199021)(31686004)(6916009)(4326008)(66946007)(66556008)(966005)(6486002)(478600001)(66476007)(316002)(54906003)(36756003)(31696002)(86362001)(2616005)(6506007)(53546011)(26005)(6512007)(8936002)(5660300002)(8676002)(4744005)(2906002)(41300700001)(38100700002)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SXp2a002VG51Q2F3aXdNMmY2M1ZGK080ZnRYZ0t1U1FGYUVDcWtEZ2FhNnNr?= =?utf-8?B?YWFWTjZielE4WGl3UzBoUEZtTW5PSC96emdUdDhaYmVMYUtwbmZWeHV6S2hq?= =?utf-8?B?MEJKOEZGS0pSSXZmTVRjUWZWS3pxVW5qbXBQRUQzalZlS2NlajhRL09DeDB6?= =?utf-8?B?RkFlcXByQVBGY0xFRW55YWlaV3dQd3YxVkJNenpFVzQvRklkdHcxelU2NklS?= =?utf-8?B?ZThQMkcyK21zRXRaQUw4Mm5EaHlhNUcxWGdESGJxNHc1ekN1eGlweGk1blht?= =?utf-8?B?RjVxQzEzK1dmSGlRd3hVZ3NWTlI1dWZxQVB4RG53eHpTR1ZubXRZNElpWE5s?= =?utf-8?B?Znk5YzU2N1V6QVFzeGJWWUZjNjR0cUEwQWNtdWZqYksyM014RXY2cjFqa0xY?= =?utf-8?B?RGk4TVFvWnc0VUFiR3o3VE5IdW03R3FrVzBJbjFPL0xjbWtRRUR2UXV0NjZC?= =?utf-8?B?OHhIbmhHczhrckVFa0tWZ3lIV3E5N1BpcFdlV0o0M2JERDdPOGJYMS9UdGFE?= =?utf-8?B?dVIzNDN4dlRJYWlOM3pUSmFHWVQ4ZHdwWnFDMG9uamRnMExaYytEUEs1Q2Mw?= =?utf-8?B?ZGVqM2JIc1JKYzYxa3NaeCtLZFNtM2lDeGVKVzl1bnFnYkxOS3h2NkxZWmNi?= =?utf-8?B?ZStyaXZwM2hGQlBNTXVRRHNNbkZLNjJYME9TcTQ0djBRUVRYaXZpd0UvUHV6?= =?utf-8?B?QXI1UVJTcXY2MEZjQzhITXV3amhmQU9TNlNRM2FvdExlWXZwcTdvbi9KZGQy?= =?utf-8?B?R2Q5dUdwVnVnY0cvUjNTU0VjeS9sdVRGRFpvcWY3VWI1Mk05MVBmWDhwVGFl?= =?utf-8?B?b2hSR2pieTdHVEJ2SWtacXBGdE1hN1dzRTZ2KzQ2dWJjWFF0UFNZZUJUWGph?= =?utf-8?B?OXJmZnB4Ukd2Z1NQT1JvMGIxeGJFNHJGWlhXNnJyVWkzcHdLckJzVGJBRVd1?= =?utf-8?B?ejlwWUgxYzBoOTZrckp4QmlkUTVsemIwS2UvZnJ2STRlOXVOTFZwYmhhdGNS?= =?utf-8?B?VXdqUEx5OEhsVVhEUkpyNUsyREphZ0M4TkozSEE0cFRaWDAySmM3ZEY4b3cx?= =?utf-8?B?Wm5nY1daNlV5bjQ4Skp4OG1rM0RTb1U5Y21kem5wUG1COS91dTVYSGdNby9j?= =?utf-8?B?RzhWSjZCQ2tuY1BHN29vOHNIUWI3RGt4dVg4U2dnejJTRE04azNrQ0tOS0xB?= =?utf-8?B?czhwdnhjZWN1VEsyWWVucUtydktFYVBTSzNEbStXRGgyUmJxaThrdld0Y0xI?= =?utf-8?B?QjA2aHNmZ0w2ZzYrODdsWmQ1c1U3aEpiYW5tcGg4ZXlFaXgza3B1VXBiOGUy?= =?utf-8?B?VXBkd2lKRS9TaytxYkJkNHdJY3VtZEVwODJrd3lYTDlva01lbkl0Ry82N055?= =?utf-8?B?QXF4MXJBWUd3ZFdEckNFSXp0cnBucm1HRnVRNmJxYWpBd0NEMTU3Q3gxbC9y?= =?utf-8?B?Ri90L0gwWXNtUTlheEdBU1V3TDFJbWY4OWtOU2NPOFFUc2pMcnRrRml3OGtL?= =?utf-8?B?c3FpcmNISkN0cVQ3Z2o0VDNuTjM4VXBjOHd3TmxRN0huOUNCQlVPaWcxbndu?= =?utf-8?B?NEJRa3ZQYXUzdVF0bmdTTG1Yb0puSFdKL05LM24zVWIzbTJRUVFlOUQ5Qy9B?= =?utf-8?B?TUFjaHVxaWxNUVhkYkJrK0F4aVdEbVoxcTluUVpPR01RK1cwU0JrOEFSV1pm?= =?utf-8?B?aU1nWG45U3VxbzNqVDdMb1haeHVCSlNPY3ByVFVuL1lxRXoweGdnZlpMSlhZ?= =?utf-8?B?VitJb1Vpek1ROHZoa0I4cVVmelo0ekRDUkpyMDJkRFl3cXAzbDJ1ZUFwU0VK?= =?utf-8?B?RXl0bStJQXhmYXFwSFpsYldIczc2RkNCV3FVZEZBM1NBSXZ4QnQwcnlhc0JT?= =?utf-8?B?NW5KZ2E2SkJ5S2g2OC9RT2hDZzF4ZWM5dEduUk9SdkNGTkd4d3hRQ0lZOVNL?= =?utf-8?B?RldBUFJFQlhtQkp2WVpvVzcxdkJlMldwdmI1RFd0d0xNcUk4TW12WkxNcU0v?= =?utf-8?B?ajJ0dTBQcEt1YTR2VnBqSmVRQS9aSlNoQ2ZwTXFQdkx1VEh2MVhIaFAwVTMz?= =?utf-8?B?NEVvWmhkc2xTTnpmM3hYdzduWHg4NVB2NEJ1RFFPQSttOG5oaHBtMlZrRzc5?= =?utf-8?Q?rYgsO6WU4WF5IHIDFMP3J/qOm?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a1c70ea-b93d-4ebd-76af-08db4d6a91ef X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 13:13:51.4415 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tv3qhfySMW7398sxvvVgOCWVq4RzkJu08LH5K8z6RKdlvMDruUlr4WuEl2icm7b8JX9367ge8NwJ5m2JhKLMlw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9321 On 05.05.2023 15:05, Andrew Cooper wrote: > The SPDX forms without an explicit -only or -or-later suffix are deprecated > and should not be used. I guess this wants a reference to where this is specified. In particular ... > --- a/LICENSES/LGPL-2.1 > +++ b/LICENSES/LGPL-2.1 > @@ -1,5 +1,5 @@ > -Valid-License-Identifier: LGPL-2.1 > -Valid-License-Identifier: LGPL-2.1+ > +Valid-License-Identifier: LGPL-2.1-only > +Valid-License-Identifier: LGPL-2.1-or-later > > SPDX-URL: https://spdx.org/licenses/LGPL-2.1.html ... I can't spot anything like this under e.g. this URL. Also is there a reason you add Deprecated-Identifier: only to GPL-2.0? Enumerating them would seem reasonable to me, not just for completeness, but also in case we end up importing a file with a deprecated tag. Jan From xen-devel-bounces@lists.xenproject.org Fri May 05 13:22:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 13:22:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530354.825933 (Exim 4.92) (envelope-from ) id 1puvON-0000pP-OB; Fri, 05 May 2023 13:22:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530354.825933; Fri, 05 May 2023 13:22:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puvON-0000pI-LX; Fri, 05 May 2023 13:22:35 +0000 Received: by outflank-mailman (input) for mailman id 530354; Fri, 05 May 2023 13:22:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puvOM-0000pC-NE for xen-devel@lists.xenproject.org; Fri, 05 May 2023 13:22:34 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e2f87e34-eb47-11ed-8611-37d641c3527e; Fri, 05 May 2023 15:22:31 +0200 (CEST) Received: from mail-co1nam11lp2177.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 May 2023 09:22:29 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH7PR03MB7486.namprd03.prod.outlook.com (2603:10b6:510:2ec::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.27; Fri, 5 May 2023 13:22:18 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb%4]) with mapi id 15.20.6363.027; Fri, 5 May 2023 13:22:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e2f87e34-eb47-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683292951; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=x7eLhQmfN/cz2GOpic1QkGwjjsDjXQ0u/FsR7r7PqTI=; b=K+nQJwv+2Ik1a/j64T5Mnz4wVd/mO1v2XzDEC/vRmiRK1/yIfPOWr3Pv yh++Ql81D1AEqwZYwrcs0G+rn+cfApgjDRtbZ1rW3dYpEoAV4x5qju7lW hM6czrOjLSCsvprDngKkkLJCTLHjRS+Iw7TyfqkFwheyoQ2xO4pgpxLFY I=; X-IronPort-RemoteIP: 104.47.56.177 X-IronPort-MID: 108403924 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:oxVoUa9LC4xb5vKLed7WDrUDVX+TJUtcMsCJ2f8bNWPcYEJGY0x3n 2RKDzqCPveLN2X9fNkkYdu19EpQv5LSx4BkSlRv+y88E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kI+1BjOkGlA5AdmOKgW5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDkkQ2 OYnATkSfCmGvN2pzY+VcMNchZoaeZyD0IM34hmMzBn/JNN/GNXoZPyP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWNilUuj9ABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTAdpCSOXjp6Q26LGV7nUdJzcPFmPkm/Ok1GOuSvtAK kxX4TV7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yx2CGmEOQzpFadonnMw7Xzon0 hmOhdyBLSNrmK2YTzSa7Lj8hTGvPSkYK0cSaClCShEKi/HzrYd2gh/RQ9JLFK+uksazCTz22 yqNriU1m/MUl8Fj6kmg1VXOgjbprZ+QSAcwv1zTRjj8sVw/Y5O5bYu171Sd9exHMIuSUliGu j4DhtSa6+cNS5qKkURhXdkwIV1g3N7dWBW0vLKlN8BJG+iFk5J7Qb1t3Q== IronPort-HdrOrdr: A9a23:CNfzjKyTcShuYgmpxxquKrPxF+gkLtp133Aq2lEZdPULSKylfp GV/cjziyWbtN9IYgBepTiBUJPwJk80hqQFn7X5XI3SEzUO11HYV72KgbGSpgEIXheOitK12J 0KT0EcMqy/MbEZt7eB3ODQKb9JqrTqn9HK9IXjJjVWPHxXgslbnl1E422gYytLrXx9dOIE/e 2nl7N6TlSbCBAqhhjSPAhYY8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzSIwxsEVDtL4LE6tU zIiRbw6KmPu+yyjka07R6S071m3P/ajvdTDs2FjcYYbh3qlwaTfYxkH5GSoTwvp+mryVAy1P 3BuQ0pMchf427YOku1vRzu8Q/91ytG0Q6i9XaoxV/Y5eDpTjMzDMRMwahDdAHC1kYmtNZglI pWwmOwrfNsfFD9tRW4w+KNewBhl0Kyr3Znu/UUlWZjXYwXb6IUhZAD/XlSDIwLEEvBmcIa+a hVfYThDcRtABSnhkPizy9SKRuXLy0O9yK9Mww/UwquomBrdT5CvhAlLYck7wY9HdoGOul5Dq L/Q/lVffh1P70rha4RPpZzfeKnTmPKWh7CK2SUPBDuE7wGIWvEr9rt7Kwy//zCQu1D8HIeou WIbLpjjx94R2v+TcmVmJFb+BHER2uwGTzr18FF/pB8/rnxXqDiPyGPQE0n15LImYRSPuTLH/ KofJ5GCf7qKmXjXY5Pwg3lQpFXbX0TStcctNo3U0+H5sjLNorpvOrGd+u7HsuhLR80HmfkRn cTVjn6I8tNqkitR3/jmRDUH2jgf0TulKgAWZQyP9JjvrTlGrc8xTT9027Jk/1jAQcyxpALQA == X-Talos-CUID: =?us-ascii?q?9a23=3AMEPR+WtWVZY5zk8xt5yajxDJ6It7X2fi5X7PMXa?= =?us-ascii?q?9Mll2RYC7c3Wg+/1dxp8=3D?= X-Talos-MUID: 9a23:+4WkGwas/RcT1eBTrjHDrighDJhS6bnwJVAcuIoHu4qfKnkl X-IronPort-AV: E=Sophos;i="5.99,252,1677560400"; d="scan'208";a="108403924" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TC4FzQsDZZ3cSFtsloVOCFyLSGyKiJWL9ofYcBFSqDcrRo+SEpBTcc457kjogj4+bvfex1ZLzi5ROAlvJ6uJaAmdw6hdsqTd0+MZvOECSm56PcDWcf1SCO6RSymQnvIQg59M0F0qZJ9ZLPD7BVyMNJ+C7efRUM1oBr2E006yXwFfpRczEIc80gmMZI5TRFzwEUDvSDPghTQI+DI+ut+z3Ov5/jm/+8NeJacpv8C+NIO7d5rPx4zsksL0RHsR9vtsNmF1tkEKr3RIFaf10uw7euRDlQCA/uWEYEsmmQH3XEOsb7QNQO6yUecV+b4wvoAtJJmq3wh8qUb/RcoUTgIIpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/e9y5U85C5VI0YC+fuBdqDQLKy7qs2gImICHi/mfPZw=; b=jpOFy99TTmb4Je9uBnUIdusE2vGRaX+kwdSi/gJqxwwKJK7BY6FN1KR/LYq2qNvLEfnUbn1O5xkPmT9XxONm/Z20VY1MzVC02hzM4J0pD8Ge2y8EaVnsLbgs/s8kmIgYL5NsQnqCi28TYCxsppEzjLRDpb1NQz0VsgplcoTSmpkbXBo6AATuiCx1p3szq6VMaqaoqMz7kurTRPjVytpdZ4uC3nUtoYplmo1vFHG9LKxhEc26JbN5WjCtjlT6XmTORITI7ohsQf3bVAWOy1czcIg77lNj4MqDwi4CQnY/JIdTHzzDtxmuBrDLsQuXFOVWFLm93Fak1qmczO1teJjpUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/e9y5U85C5VI0YC+fuBdqDQLKy7qs2gImICHi/mfPZw=; b=R+mm6/c3TJQBLtocLGQayx7KupuyLHA14CrKk7jxFMvAnEBywi8bx55nQkkEs5JHaLG/md0RfjKQafhRmifdKlXQ7zG+0BdzYUJ66FivF413vh2Gd/h68m92s7qO/0HCWEItYMzoa0UBzSTHdAv+kT23o+GbEmxomnCzgkHPT+A= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <8fa2cf23-4832-a033-cfc3-e3225eff0047@citrix.com> Date: Fri, 5 May 2023 14:22:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: Andrew Cooper Subject: Re: [PATCH 2/2] LICENSES: Remove the use of deprecated LGPL SPDX tags Content-Language: en-GB To: Jan Beulich Cc: George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Xen-devel References: <20230505130533.3580545-1-andrew.cooper3@citrix.com> <20230505130533.3580545-3-andrew.cooper3@citrix.com> <40d70f11-37e7-ff29-37c1-a94d3e286455@suse.com> In-Reply-To: <40d70f11-37e7-ff29-37c1-a94d3e286455@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0221.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a6::10) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|PH7PR03MB7486:EE_ X-MS-Office365-Filtering-Correlation-Id: 4695c6f1-8d1b-479e-718f-08db4d6bbf92 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZqBiaZENIhQBiX6cAREVb8hfiSgJHJpBtuoEKuh4nsUHfHlNpEVG7Lj1aAk9ElVzsxsamryJd6348OetPsuhnOni3EGWirAkfUAgv8QPYb12tcSxB2F63aVy0FizS/ksIQW6365YKoKcdTFLftY+XPgryzNJ6+HM/P89offRmCA69Qnvagjpm48yPmgQZfrLWYOalWEHVRxM/MQG6InPRbJwNtv86GUl0ptNyoMRu98SqXYKYqeIwKWWraPisYITw1SWgcqhDzn6Rfjz35icNy6php6ov8CuINrEfEHi2i252nECOJ9PJxRj9zfEW3YgtMEmcJqb4O/sXC/ULW6cqwUJZfUfjtlTr9Lsdz7Jdes6YtqZHWC0yMeDSxV22dlCZp5wG0Wf9BTlWmbUU29zSHu02IyPVxiSj/zlYc6bS7T9w6GaTMzoe/tKbw1TaYkFE5D7WaMgZ5T5QgQxA8TIbCugPYskJ9omar/S25nORpxDHVtw8zmMnDtIuR0DqPwCjLB+Ldi/l0f/NKarlZMPOpbU94g8XEp8sJO1PON/pLVkKOlYcJYdDHUoaz6sNnLwhpkHBzO+jbWoaljIrxJP8ad4zmZiHDfTizKSvWCzI+m9yYK6Gw2KO5cBo4v5pVwl X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(396003)(346002)(376002)(366004)(451199021)(2616005)(6512007)(83380400001)(2906002)(53546011)(186003)(6506007)(4326008)(66946007)(66556008)(66476007)(6916009)(316002)(41300700001)(6666004)(54906003)(478600001)(5660300002)(26005)(6486002)(966005)(8676002)(8936002)(38100700002)(82960400001)(86362001)(31696002)(36756003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WnRUeWRPNkZCSUREY09JN0diNlZtVEU2V3AvRVlaeC9KTTQ5NmE1Sk0vc0lH?= =?utf-8?B?VW1KeXF5RFF2Rlh6cUs2SU53eTM2VkFva0M2TGhDZ09UZlEvWkN3R2xFNVlE?= =?utf-8?B?d2M1VDU0dUdLTVZ3VDIzT0RGaEZGYndqeGpMS1V4d1N0Ynpud2cwRDE3M0ts?= =?utf-8?B?L09oK3pnVUN5MFp4c0FJek1pcXFiQm9ycWhmTlgwTE8zWkJnQzlta0NBdkR5?= =?utf-8?B?WGorVzFuV3lhdC95SFc5Znl1NitSTHFGbmNiQUtEMDZXc2VVN1ZHMVZtR3NL?= =?utf-8?B?b2FrdTdmWHkxZHE0L0dGRWc5aWQyeGJWaUFyTFVKRmZMazFScjRZSVJjTzht?= =?utf-8?B?VHRiQVBkRFpyRFMzUDBQSUs5VzRxVEVxaDVaMHhxRFB3Y1dRcU9EbjNuMmZB?= =?utf-8?B?Si9QS01aZTJtamFsZWgyM1JxUXJoQU1Ua0ErTytQQUczSVFUQUFGTEFyR3Nn?= =?utf-8?B?ZVVxamxOV1hOZ2NxT3NIbm5hL0pGd0Zpd0ZZaUlDdCt0aWMweG82Z0JGWVQw?= =?utf-8?B?SC9GUm1aelozTmt4SnFSRTNZby8vamFJS3BoL01rbHgzREVNN00vb0Ixb0xM?= =?utf-8?B?L2luZzVXdlJZVjA0Vmt5cUt5MjVDWTlqdmNtV3dGRWRhaEFLVUFYRTV0aVA1?= =?utf-8?B?MVNnZ1dJNHozak4vWWZYdk5GT2dXSGtIUUJCNTM0RHhyQWdSaU5ld2UzMWsx?= =?utf-8?B?ODU5eGkrOHdtTzdnU0VyWnVFcVJ4NjI2dHdSMWtZYXVLK0JKZHFESGdDQVM1?= =?utf-8?B?N2l6QXY4WW04cG5oU1NtV3RVZ0ZybXl6VUxmNnhJQ1JYSzJOYi9OaDZWc0F3?= =?utf-8?B?cmJ4TFQxQzdPVnQ0T2JxK1ppTis4elBWMGNMZU5rOUl2cEw5ckorRHZZdm1C?= =?utf-8?B?U205cnZ4Y1pST1NBM0VvOUswaXNYc3JCNllqbnNoNmY1d1NGRHJqWWpnUXk1?= =?utf-8?B?UGF0OVg0bGN3TGU4SkY4bi8rVnFWYnZnbmRUMExPc3VWVEpxTjZZUjFpY01N?= =?utf-8?B?b0R1Q1VHSXplYld1aUJVbkkzTnZzbWVmR2tpaWhMdFpka1NuUGtEMTVkbGZH?= =?utf-8?B?MjJqZEQ0cHQyOHRkYm1NUko1cGZzNWFFRGQwVDF4a2MrZVc1WWVkbXQ4cEJ4?= =?utf-8?B?cDYvVjliVEYwOXlvSUtibS92L3JTeDdENm1GYkZHdlR2amwyZWVySXlZZHIv?= =?utf-8?B?TWtCajhudjVDK25nWlZvZGxraHNibHl1WFNDbCt6RTFvekc2V2JGRWVJQlJw?= =?utf-8?B?ZkNieTJBQ25waDQwKzl1N1FyYnpNNkV6RFhwMkN4RlNxWHVyMytyN0h3bFZh?= =?utf-8?B?YUsrRnMzWVI3Tk1KcGlUUXdaS1VDSk5PaGp1anUrSWpEMlVlMlBidjRMUUM4?= =?utf-8?B?NUdCR0Via3Z2bEtXc2srVVZyaFRFV2I3bkF3c3N1KzVWWHI5YmFwT25BK296?= =?utf-8?B?MU4wdzNKdE9WZFBhNG1vRHdIRVJJUEYzUk5IMG9LRFh2dE54cUNKdzhxaXFj?= =?utf-8?B?SlpiTGN5TEFPbUpzSjFKdFA5enNjQm15Zlpiam1nRHNYN0QzSi9RUzNNcHd2?= =?utf-8?B?SFJ2WHhNU3h2dlo0ZEhkbzI2UUNISE1JMFVXTWpSU2RoeHF5dXp4NTFySWts?= =?utf-8?B?Y3ovdkpOMUpmRnRuRit6NkwvWUM0WFNnMkdoVEE3Rkp5dkMwdXYxNmZ5Yysx?= =?utf-8?B?TVFRc04vVVZBemdsRURvcFFyemRsNW9UQU9zV1M3emFhWGhlMjdhOENIdTZJ?= =?utf-8?B?K2Q1VWN2Y3U5eGlITDBVQS9hQUxBMUtyUWdmdVVHKzhGQ2NjRGw5dGxLbFFh?= =?utf-8?B?bjFtdkVGRmlieXAxOEFhc01TZ0xiZGttbWFFQnJKeUlsbnlmY1oza0NuWnNw?= =?utf-8?B?YUkzdklDdU1HTGlEdm9QWU5UeEFRTkV6VmxOSVJ2bFRyeWsvNFZZTU9uMFBq?= =?utf-8?B?RFZ4aHoxaXY1SlFEd1JVOWdtUVlaejRQN0VQUXZLKy9vT3NTZ21zWXlnOUt5?= =?utf-8?B?RXJ3RDRLRC9KYmcrdTQ2aDR2dDBNb3VOOFBTdUErOUxYbWJEUmdCUVdyYmNo?= =?utf-8?B?ODVtWlc2T054QXZDUTM5ZW9kVVdRajd1TWVTelRUd3FtK2d6MUl3NzdqWmVU?= =?utf-8?B?VG52UUpIeFNRQjBicWJhUGJmdU1sSzFHUXhjSTJwV1RWSlJ4WFFmcDRSeTZU?= =?utf-8?B?c2c9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: M3CEHc6XElKkNWb6tcfohcFmTMsdEyfvHJ9PPRZUJQIU68XtrbxHRmtX05BLGlsObeISlTCrJs4S/t3HqUtq3IFxo3S/a7rG9bawahvayxo3kZUbJT/B+vc+j49VAtkFZ/t82ML5RDLFuNwihPMbM+a7xu9uumCkL+yJf85VIuyIBHKvnTqXrA4cLnMbWuYix2RtrWnBdeAQau+1/7hmQU5+q8Ipj8poWyIWi3+ip19nIyM8X+FEX779EyzQmPqIn27p1VpEpZIgQ+h4kl8p8We6kJUZOxti2CJ3aHcmXXvwesz/BP/XvO21fscT8xaFE5Cn1odZdVA61veNnedbmZ9zvLguuz73Rn6lRInqlT86W9eaDwHF3XrDLwV8+qykg0lQ5YEpBFxzZKJt2VZfMztU7WpppgK0SweLRGEGYtNZJAH+rRvJhwIMCCBPY3QXRYWP4/XV/1eQCPESMGOcL82Z1h+lPpJ9I0FZ6YZ0nLnOjgpVA1MX/RNDh09BGrsYFbJdiYAJ+jBnonVyrG9uh5t1sRrKJuKDIPmsbBhWOmtbPbRe6tYLn4UgT3a0pz5HcSAa37NopeRlkBDsQycaiIF5g6n82pk49VFfskrwu+OJdB8oQ0NYuJYCdABot945RMLJWwjtNiBAkpuHO42V1+j0wOLdZ/rTKmnQ1+fw4xwnMPOc672JQuJ/0NP7XrgJIsqNDVJWXllRHlWGUYNBfz2Yty5TJXOuhX235oX8kgr53OihBDo+lJYnXco49H7OGDjWh14fu3meYbDrDX4riQTU0rn539k+gAOfoxVpQ38z8rfvTT/gUtUxXW8ZdJQLNGbzqsMFilOHyhEEOWvc7D9nbzruIxcKHvGRBLK1cmA= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4695c6f1-8d1b-479e-718f-08db4d6bbf92 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 13:22:17.7381 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ug6PCMtMI9TlXXjmHQjV/2UWOBbjEmjU04jXNUScAeEWn5+JqcGm4mJdnaFnXe2Ejjo0f9j//7ibOnruXFMZKpnrU2pIvyQvj8V8jwN4N0U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR03MB7486 On 05/05/2023 2:13 pm, Jan Beulich wrote: > On 05.05.2023 15:05, Andrew Cooper wrote: >> The SPDX forms without an explicit -only or -or-later suffix are deprecated >> and should not be used. > I guess this wants a reference to where this is specified. In particular ... > >> --- a/LICENSES/LGPL-2.1 >> +++ b/LICENSES/LGPL-2.1 >> @@ -1,5 +1,5 @@ >> -Valid-License-Identifier: LGPL-2.1 >> -Valid-License-Identifier: LGPL-2.1+ >> +Valid-License-Identifier: LGPL-2.1-only >> +Valid-License-Identifier: LGPL-2.1-or-later >> >> SPDX-URL: https://spdx.org/licenses/LGPL-2.1.html > ... I can't spot anything like this under e.g. this URL. Hmm yeah, it is irritating.  The statement is at https://spdx.org/licenses/ but only by virtue of two tables, the second of which is the list of deprecated identifiers. I'll put a paragraph about this in the commit message. > Also is there a reason you add Deprecated-Identifier: only to GPL-2.0? > Enumerating them would seem reasonable to me, not just for completeness, > but also in case we end up importing a file with a deprecated tag. We have problematic uses of GPL in tree, where we don't for LGPL. I'm considering a gitlab pass which will reject patches with use an identifier not in the permitted list, and reject in introduction of new uses of the deprecated ones.    For this, the deprecated-but-tolerated tags need calling out in some machine-readable way, but I don't think it's helpful to express the tolerating of a tag we don't have any violations of. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri May 05 13:31:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 13:31:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530358.825943 (Exim 4.92) (envelope-from ) id 1puvWr-0002Kc-Lt; Fri, 05 May 2023 13:31:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530358.825943; Fri, 05 May 2023 13:31:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puvWr-0002KV-HZ; Fri, 05 May 2023 13:31:21 +0000 Received: by outflank-mailman (input) for mailman id 530358; Fri, 05 May 2023 13:31:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puvWp-0002KP-Rc for xen-devel@lists.xenproject.org; Fri, 05 May 2023 13:31:19 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0628.outbound.protection.outlook.com [2a01:111:f400:fe02::628]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1d231b0b-eb49-11ed-8611-37d641c3527e; Fri, 05 May 2023 15:31:17 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AS8PR04MB8612.eurprd04.prod.outlook.com (2603:10a6:20b:427::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.27; Fri, 5 May 2023 13:31:16 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%7]) with mapi id 15.20.6363.027; Fri, 5 May 2023 13:31:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d231b0b-eb49-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XEi862MKvs2330hVwolviVItOAAYJTmjM2z61/iRVSfpw9xm30YEjz2/cd/M9p9fLyB0Grnya1XTFUdtBqAqAV1mRg7McUMPq6PxElD+1vDmWpqo1nLOkYH56s9qw+ChFvnOGK9rZooowNdVOdyWp6q27V11c1jJDE0LETXP+yv3c3HrpDcJJXBF4cH6z6OXIDfoH0kFXU353I0Q7ndmmRkW9nbd2XnRZOzQEejpJqf+9GO4KBsGLKXKJc2srjmCUVkAaJHP3UL/Oibt6V9eYJyuOvrqFZLcrD7rATPv8trbYzqthIIA2MN27GFlU4qG9jDQ/FV3igXW8oNDkzyAQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nemY/fDaSoviyXOfos5E6LNHFQh2y1QA6DiOYeeLb8o=; b=iWpyIl7/rX8V1iVUKGFrinJRAI2WsKXljjKiTL6zOdJG+e2gYllms06Nt0Z3u0ycbzYSAb3E1KEPlKafLKela+z4ct+qQsbS2eDyZMGO33GPp3vJzP+yt23K7/2WY9qx9ef8TDkuKc+kSVPcgN+ZJjqBHgftC+X6qSJDJ+MgtHCTZf85YZbmXliST9vbC5ol9044yLdCuc7Hk7Kc38kNWgWilR0KP2g0clETohiglKIyXDMeGDXu68BwdMpwMWNscdAsxFDw+RjMKZ20VDH3fMFS6cXsfR2lKyfLO/FNWRzkMy+Q3ka0Ggt4PuQR5TMpM3mLnlBLoHJQTO0tjSpFaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nemY/fDaSoviyXOfos5E6LNHFQh2y1QA6DiOYeeLb8o=; b=gJRbBGUWtfDaJcqZ1d2atOLjJcjBpbIHoAbp5DV5hb//IGOvrnJoS+3vSJVzqew3WsEMLhVIVrmZuNjxFiOQb1b4suYjp/uCfbDxCwhScu2Ke63qELyskvB6Y6WQ71vfsl1R6VL/uREzFHoAdIHfmrzjfH8eaukV561k6p50qAhsL9hLtcJ0qdyIAWdKMuZCdeKueDzAk5+LZ6+JmMKDgvlALCjd1afJ/6YEctzOGj8bdbx4kpktNh9N0mNGuByU+Ul2x9xO30TzW/i47krxnpr0WJ46fBDDoFXpixUBee11x+s/HHGSH4WIaKKOGEVnAN7ZPAEwz0ucY+l2kvpTvg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 5 May 2023 15:31:14 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 2/2] LICENSES: Remove the use of deprecated LGPL SPDX tags Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Xen-devel References: <20230505130533.3580545-1-andrew.cooper3@citrix.com> <20230505130533.3580545-3-andrew.cooper3@citrix.com> <40d70f11-37e7-ff29-37c1-a94d3e286455@suse.com> <8fa2cf23-4832-a033-cfc3-e3225eff0047@citrix.com> From: Jan Beulich In-Reply-To: <8fa2cf23-4832-a033-cfc3-e3225eff0047@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0136.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::18) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|AS8PR04MB8612:EE_ X-MS-Office365-Filtering-Correlation-Id: c6e74712-da14-46c7-1b79-08db4d6d00a0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ilk0LveS/NirsZc6yHXAZJe0Y9HxzBKbeURjXGm9FP40wtFg4sq7S3hv5uuCu0Hah/Fec2j2QhlazIW/tX837t6tOfJUMzdiHF3DKfKZfiN05hYNCNWlCUq5sQABu203T2+fcPzOPuX545QohZuzxufl/LntXK7J4HFiRdV5OExDj2+ZNV9FKyagF9RmheBTKQFdzP69a8mypYWBm0DRF3xTlrMdUYepp3EdD8ia186dCdqMZbkl3qnj+nAkG0ZdEYka2SSTbcMQD5j3Fwb6Fkspgiec0yI1Uy6K/TXNxHH18fpgc5VQoLgq4IUsIoLX0OWV67ZlZlR6TuW/XFhdMRigz80YJsDgIV2bReHeuSjFJsi8TUpA0TyPNq/SB+yX+cgE2thclQUtRHyKP6PmsNXpIFzRNasuLYzc57L3aPdx1OdFHN7+/f7eJcFK3Y9LtG0g7bcUF2ly9nobpt0GAXZEjAEXsSV6usF96/aWBhSzg3MtjqsAlZp34hv5OjTXjJMR8an2I1aIIRwlkaaylYJ46HsqWG+y1LvOZDk/eVcZUKYVvZukRXOKIh9xC/zQ0ykv5oBYzFnYDZp5FmzWehGYix74r3fqeys9mi+eweEl0vJqr7QTwxSDJQ6inoQz X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(39860400002)(346002)(136003)(396003)(366004)(451199021)(31686004)(83380400001)(2616005)(6916009)(4326008)(41300700001)(38100700002)(8936002)(316002)(6506007)(53546011)(478600001)(966005)(66476007)(66946007)(66556008)(8676002)(31696002)(6512007)(26005)(6486002)(86362001)(186003)(5660300002)(54906003)(36756003)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T1BoeEVNajR5L1kyVmtWd1hadXNDajNxeDhUWlZHdlFMOWJGYkozUng3VHVX?= =?utf-8?B?VFMvVWVoL2l1Rmx5a2pQZDhaQjM1RHhOdTFQN3B6RXBsQ0VRQndycm9kaVJo?= =?utf-8?B?Ykt4VlJFV2JGKzFTRnk5Sk50eWhKUUtoM0IzdnVLTngvcVhBRVpGaXp0S3I0?= =?utf-8?B?c0ltKzBwWjZCZFNQL0Q0cTYxaWNWQVQ5Ly81MzgybTN4T3VCRVRPZk0yeEZS?= =?utf-8?B?bFRkQldCVm5uSDFtRWkwSFp0bkpZa0Z3Y3doZVdjQ0FkWEJsRk1RMkV3Wjdq?= =?utf-8?B?WjBZcmRmdVlTVUdFRXFYeE1rMldnckhqdHUyNVpTK0dzY1VvVTJJOXlsNENT?= =?utf-8?B?REJzbGZVcXgvY09qRURKQi9sNXU1YjV4cjdXNG4veGdENkVjZFlBSUFkenky?= =?utf-8?B?akkzcDVXT05UQ2RIbUJhejg3UVdJamROTTdrdlhOaUNSOXU2NmRMQXU3TU5K?= =?utf-8?B?LzB1UmNnWVp1RE1rd3dXU3I0VmxIVjBzNDlvdmZDSlF6Nm9KOE1ZUVJMckJs?= =?utf-8?B?d2dCMDNRRExzTmU1NUtuRkpnb0NQdXVYRkd4bVdKZEF1T21QRFFFZ3RpeXlk?= =?utf-8?B?MHhLV0FXRWIrc2tZejF0eCswMlhDWmF0RTZkanBMWTllNmVHa1Zjd3h6eWU5?= =?utf-8?B?Si9sdExLdFQwN0FpUFdIUmk2Z25jc3FwQnRzTHREZ3VMSmJnNUlieVc2by9y?= =?utf-8?B?U1hWbDVjZGZHWmpvYndMellRZmFWYzdUSjZLTHJZNHlnbVc2b2hlRFJVak5p?= =?utf-8?B?VGNHUTdtVU82NkU3alZPUVlTSlB1eVNIOUNZTWpjLzJmNjJoanpmcGJIampl?= =?utf-8?B?WmRUS2gvbTZtMnA2d0RUeXd1ZW9xdWd5SGhodnBUOFk5cDk2TlUwNzE4UFBl?= =?utf-8?B?TFAzdThOT3lYdFlJbzV1VjUzMm82NEg4Tmw0V1Q1RTRVWll3NmduRjdxaUFt?= =?utf-8?B?MGFYY0xLNGFlSFJLUlZKcExaSnNGWHJGbHV5U2RicTVSSk9XNk1kV093eU5k?= =?utf-8?B?VU9sMnhISk5WQjByVEJvQ2dNN21URG43amoxdWlsNmpLbkNINnhKNEVheW9k?= =?utf-8?B?bjlpT0YrTEU4aTYzMHhZbyt0cUtlUjA3ZTNLQ1hiT3MybC8zY3BVMUYrTHlK?= =?utf-8?B?VjFmODZtcERsZ3cwK1l4YjJCUHdPTkQvZ1Y4dy82cmJyQTVJaW0rWXZ0aWwx?= =?utf-8?B?bCtPODJ5M3RoM0pjMEJGdEZPcUc5SnM0M3VWMER2SzUvY0cxQ1h3NGRCbjI2?= =?utf-8?B?eDkrYVNaMnArNHRCWStIaElTb004aEw0V1BmK3pEYnp0K1ZUQkU2VWVPblhk?= =?utf-8?B?ZGlnYjI5TEJvN0RpQk1Eay9JNWVBZTdaL0YrdlJyeFZhaCsxalp4M1hXTmVI?= =?utf-8?B?K2xERXA0THZTS2o3TlNlZ3NLdEVZOWVGSFF4elFMd2hLWDJiR3REZ2JlU2VI?= =?utf-8?B?cU5yNGgydjJocmZKQ1BDUmFQQ3ZyYjhxZGFvTzh1d3RZbWxlRFNxbGUxeU94?= =?utf-8?B?UjgrTXRpNlNOT3RKc0c1RUpuOW9VRUJ2YlJoREZidFdWMU8yL3hZMnRubHBa?= =?utf-8?B?OXZCRTNIc3Vmb05RN0phSlpoWmRYd0paZ1lpRlMyZUJBUHptYjgvYy9DTFZK?= =?utf-8?B?U2t0UlhIMk1YZnlQWktzNWYvUzB4SkpTUmozVUZVU2dqVWRjSjJ3TXJtUVNn?= =?utf-8?B?NFdwcEFLSlVQY3NVSnVyM2lucHQxNUsyNm9qK3lGaEkxcWt1cWYxd1hlYVpL?= =?utf-8?B?Vys2V281V3lZbkROQ0oyazNiTFgrWko1QUc4RmNYSEtqa2k0ei9GZUtaV01u?= =?utf-8?B?U3Y4bjkxaHVuOWFFNGpwQk9yeVVORk5rM082L2F4K3NYOWQ2a29JdEJid1FH?= =?utf-8?B?a0kxaGgvcFJ0NWNmY2k1dVFsZ3ozVGdXYVQ2akwwUG9CdTFkR05WcFJoYS9I?= =?utf-8?B?RFdjaXNkRVNRVEsxT1JibTJJc010ZS90VnZMNU40YkdNWGNwWnl5NmtaSzhF?= =?utf-8?B?eDlkb04xSndoVTdtSmJKUFR3NFgyVGZwUWZxWW1RVUxQYTZySWZuRlNUQ1Ev?= =?utf-8?B?ZngzRzlaWm9HeDgyR3ZwTXQxeDBqcktHbWFxb1Uya0M0YnFhR2RKUUY3VmJL?= =?utf-8?Q?UZCr7I0lD/PbIsvIguvtszyfJ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6e74712-da14-46c7-1b79-08db4d6d00a0 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 13:31:16.1528 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WBSdUWwHBeIjw7zZfBaXkIxa/WgcVKwE4fkTatnra5EQOig2lvxRWEp9OVPfx+/64oFOgbKE5jkzBcH+FK2VNg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8612 On 05.05.2023 15:22, Andrew Cooper wrote: > On 05/05/2023 2:13 pm, Jan Beulich wrote: >> On 05.05.2023 15:05, Andrew Cooper wrote: >>> The SPDX forms without an explicit -only or -or-later suffix are deprecated >>> and should not be used. >> I guess this wants a reference to where this is specified. In particular ... >> >>> --- a/LICENSES/LGPL-2.1 >>> +++ b/LICENSES/LGPL-2.1 >>> @@ -1,5 +1,5 @@ >>> -Valid-License-Identifier: LGPL-2.1 >>> -Valid-License-Identifier: LGPL-2.1+ >>> +Valid-License-Identifier: LGPL-2.1-only >>> +Valid-License-Identifier: LGPL-2.1-or-later >>> >>> SPDX-URL: https://spdx.org/licenses/LGPL-2.1.html >> ... I can't spot anything like this under e.g. this URL. > > Hmm yeah, it is irritating.  The statement is at > https://spdx.org/licenses/ but only by virtue of two tables, the second > of which is the list of deprecated identifiers. > > I'll put a paragraph about this in the commit message. > >> Also is there a reason you add Deprecated-Identifier: only to GPL-2.0? >> Enumerating them would seem reasonable to me, not just for completeness, >> but also in case we end up importing a file with a deprecated tag. > > We have problematic uses of GPL in tree, where we don't for LGPL. > > I'm considering a gitlab pass which will reject patches with use an > identifier not in the permitted list, and reject in introduction of new > uses of the deprecated ones.    For this, the deprecated-but-tolerated > tags need calling out in some machine-readable way, but I don't think > it's helpful to express the tolerating of a tag we don't have any > violations of. Hmm, okay. With the expanded commit message Acked-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Fri May 05 13:36:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 13:36:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530362.825953 (Exim 4.92) (envelope-from ) id 1puvbk-0002x5-6p; Fri, 05 May 2023 13:36:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530362.825953; Fri, 05 May 2023 13:36:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puvbk-0002wX-3y; Fri, 05 May 2023 13:36:24 +0000 Received: by outflank-mailman (input) for mailman id 530362; Fri, 05 May 2023 13:36:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puvbj-0002wR-BI for xen-devel@lists.xenproject.org; Fri, 05 May 2023 13:36:23 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d0ab8697-eb49-11ed-8611-37d641c3527e; Fri, 05 May 2023 15:36:20 +0200 (CEST) Received: from mail-mw2nam12lp2042.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.42]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 May 2023 09:36:10 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB6673.namprd03.prod.outlook.com (2603:10b6:a03:398::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Fri, 5 May 2023 13:36:08 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb%4]) with mapi id 15.20.6363.027; Fri, 5 May 2023 13:36:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d0ab8697-eb49-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683293780; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=aTwukeDh98r/JtbIfsvOG1co2CDLfI3A8dC8ocd0cUg=; b=AkNpv9sxBIjphBuj+NBMP9SPhaVEdAUkiWwPqc+Ng5p5I52MCSgOv2Wv nVwixYfDJvH2Xc45YpzbwytGQbRiOeOQQGOJiaNxGAIAuCWNxqqLHbE/b n0B3wRKFsfancdaFZXMvLgh1de0Sqw6nN0Dckf6WIaYE2d+VKVDnMuOVY E=; X-IronPort-RemoteIP: 104.47.66.42 X-IronPort-MID: 110447861 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:+ranJaAz53owRRVW/+Piw5YqxClBgxIJ4kV8jS/XYbTApD9x0TdVm 2MeDGrTPviJYmf0c9skYYXg80hQ6sWHm9VhQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFuspvlDs15K6p4G5A4wRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw1epQWURQz eMkGR8nRC6B29y5/++2Rbw57igjBJGD0II3nFhFlGucKMl8BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTL++xruQA/zyQouFTpGPPTdsaHWoN+mUGAq 3id12/4HgsbJJqUzj/tHneE37aXwX+kCNxLfFG+3txgp0+UzFINMzcxe36fvfCIiEGgVPsKf iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwBqW1qPe7gKdB24FZj1MctorsIkxXzNC/ kCNt8PkA3poqrL9YXCA8raZqxuiNC5TKnUNDQcUQA1A79T9rYUbihPUUs0lAKOzlsfyGzz73 3aNtidWulkIpcsC1qH++E+dhTup/8LNVlRtul+RWX+55ARkYoLjf5av9VXQ8fdHKsCeU0WFu 38H3cOZ6YjiEK2wqcBEe81VdJnB2hpPGGS0bYJHd3X5ywmQxg== IronPort-HdrOrdr: A9a23:2wCszK4x0xaVxNEm5wPXwD7XdLJyesId70hD6qkQc3Fom6uj5q eTdZUgpHvJYVMqMk3I9urwWpVoLUm9yXcX2+gs1NWZLW/bUQKTRekIgeSN/9SKIVyaygcy79 YCT4FOTOTqC150lMD75xT9PeoB7bC8gduVrNab9mxqSw5ybaFm8kNeMSa0VmNLZCQuP+tCKL OsovNdoTyuYHIWadn+PHkKc/nIosHHmPvdEGc77zhO0njzsdpt0s+DYmWl4is= X-Talos-CUID: =?us-ascii?q?9a23=3AYDGd0Gijdo9H4BzkpZSATFjVDDJuXXH6lFLOG1C?= =?us-ascii?q?EOElDYoOXFWGfx/5pnJ87?= X-Talos-MUID: 9a23:Q6CEcQYo6w92meBTlTXLljZoCtlTyYOALWQRmKQEtNeLHHkl X-IronPort-AV: E=Sophos;i="5.99,252,1677560400"; d="scan'208";a="110447861" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q+UqyigkdsytwZkYLZn0zoyFmbgEMsh8CiXAyeOip4eNDpnBuP6Sfz67ovI/h6BbKPeak+lf69oiFZoIQJdXBLjh7seD7PLI89Ywct74Dtdt/a6yfZsIoZ+8Lr+LbnU/dt0vZIB9+0yT7EjvHg9vGjFwTMfrhjIoUr9O9QfmDqMvI63yDvAVDVPeCxI8KwwqM3Z3Nbrdi9aAvjRQLjPO9c8x8wUeQ1wH8rSWVX97+J97v2X3iXGKBchQxUuKHiBLCT1YXDtTJlgHEK3O0dTyrBrIj/o/GMP+U2ra/TyFwt7DzcvTAjtXoVpPzwzBw5jUDx9Q9mzOeXPAEEUOKeFcKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bgDkydVTkHtXCOHYGpAUhRwTNDLOWQG5oFcoYqgo3C8=; b=c2wPqybdovOExTebKFN+r+wZSeiFuN58g2iER84E+Dq6osX6PAE7vUJJwb3paZZdeemN+zSNxZHRNFT7t5RE7NxMKXfF9IVo/vDCYPT1X176LPGI4lxoGYtzQcukevLCMQmna4gCK8PAQRmNJAZeWCYXFvrVtdqnjqqp3uKR0PsnB9k6MlRwFo+kMnd4XfDfXYkBDB/Z0b7bueuiJR5eyzWiVk1RtHeixpoDzveYLJyOzMHEDU+ZeyH9FswXToqaHEtyohYckvlh+iZMFWdkms+/x6SNYOMlsXcTvH74CxBpnpYOv5uc7IInK2gipjjxyOU20rm0VWlmn8q7Jjr3XA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bgDkydVTkHtXCOHYGpAUhRwTNDLOWQG5oFcoYqgo3C8=; b=XSbQKeJOVbnLLda7NDFPgQ2C80SI3vY1sbYKpwxJOYSG9t9PbPeWtcztezEt7Etbd6cWg09NjoOksl6WH+mdMS9mV0r2paM+srYbBVy7LYGFwAeIfLqn5cPGnwymIs/Ov92ysAhasok18kyA63lQDlfvbuRtaJP5CCF2yCBQoPo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Fri, 5 May 2023 14:36:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: Andrew Cooper Subject: Re: [PATCH 2/2] LICENSES: Remove the use of deprecated LGPL SPDX tags Content-Language: en-GB To: Jan Beulich Cc: George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Xen-devel References: <20230505130533.3580545-1-andrew.cooper3@citrix.com> <20230505130533.3580545-3-andrew.cooper3@citrix.com> <40d70f11-37e7-ff29-37c1-a94d3e286455@suse.com> <8fa2cf23-4832-a033-cfc3-e3225eff0047@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P123CA0082.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:138::15) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB6673:EE_ X-MS-Office365-Filtering-Correlation-Id: e920757b-65ff-4eb6-fa8e-08db4d6dae96 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: INs1AL5LAZ+sZ/IxKrFl5NVtE4/40ojjkIWmIqFg5IrLvqs1vlrEOyaLnzGZKoW0jrEssQNiqu9bizCNQKVDs+fwqahggq8fScyUU/72hCZduLKEPRAtjsPLFxkqlLaFO5DpDTMhXu0HdH2qA1EkWIkoevoeigy38IxawfzSJScogaTK+DQmE7IhniM6pvqnjQJxFT2QxMsgJbcRztmNXglin0GaR5m9tFqZmb+ji+N+wCs48RT/ik77XpdnNQ4ghrzwF3O8yyjCH8kwRoqGVe8eaTVCwWOjYXuORoxcZvZHt51o6rzzbJyfgd7Z34plKZ9Xvx+KI0OKiPqoKMx8l60/B9SjTdPWlQZG4Ar5jBtoXLcIxYbVozF/ErnN4uw2gtqlzGdOKzyh3ybOUMDXorYmFvWeHc3Yls3D8189HPQ+nGehDrWnf7EYnM+6SlSma898aVvpG3mFU6RDVlvxV1DzRZqoQnaLhOBATMfnX2S5bJLTh7OGEO1eTgQqMkSGmJXKgYcnwUkGAWNdW3h+Ha6fQsZYnTBKPF9n3ZxyJ4wc4roiJAwebdO3+WG7IBvnAqNODGq1lNwCvtEBIFbnj+e+R0EqOGmNn1d5b2BsMrXFPSxrfuz0MVaAyuM1Gp3vGV0+pc8a9Lj1uR2q0m8btw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(136003)(366004)(39860400002)(376002)(451199021)(8936002)(966005)(26005)(6512007)(2616005)(6506007)(8676002)(53546011)(186003)(82960400001)(5660300002)(316002)(66476007)(54906003)(66556008)(66946007)(6916009)(41300700001)(6486002)(478600001)(6666004)(4326008)(38100700002)(36756003)(86362001)(31696002)(83380400001)(2906002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WUt4WGpSTEZhSlAyZm9qeWJxdmdMR0hkc0w1dkpwSjNraXlwRXNiOWRVT1dH?= =?utf-8?B?SnVhb3BzRFhXajFvNTJldGhFTE1kNmprcnZmakg1OUhVV0NLQXhTZUovR2Rs?= =?utf-8?B?eWhrWHhGZ0dUUUhSc0xYK3B6V2d3SVZDa3lPMHlVTmdWSlhjZnFVZnhSaDI1?= =?utf-8?B?QkpEakp0SW5mVjBZTGdsbjRTZUJwaUptOFdJU3FYWnBzQnZYUzdjLzI2Zjl3?= =?utf-8?B?dVVkd1F5UkpZSmdSNlUwM1NMaUJIWklLRzB0QWxybyt1T0U3cjhTQmRLa0h2?= =?utf-8?B?T21BVnhSMmJtM2VqSlIxS2Z3Ykp2WnFGeGdLSWVHWDVYUkFBbzdBdkdHZ3Vy?= =?utf-8?B?aWdGTWNPUjBFUVYyVDQ5K25LODUrSmdIYlJJOVIrakhOcFArdTkvL21MYnlD?= =?utf-8?B?T2xjZDFKZ2ZzZ1lxZ1ViK2QrdVhSOUVSSTFXblk0a2dHdU8rSzkxcSt3TStp?= =?utf-8?B?aDJUQm9hekIwbk9HM0VNR1RyUmlUOFp3Sk5uM3ZKQnVzYm8vYyt0amRMRjhR?= =?utf-8?B?cklIbGhWK2ZVMHBSdSt1Q1Z5UG5haE5QTWlLdkE4UnMzeHd0S3pUeW5VcFQv?= =?utf-8?B?UEl0d2NiZVNqZmUxcHhwd3R6UTRIV0JRdjVoY3NIc2ZlbzB6by9FN2NGdE9U?= =?utf-8?B?OHNPWmlhdnUyeTdHRkpUTXRKa2VmWUhSSXY4eEZLd2l1dVo2SitWS3ZKNE9J?= =?utf-8?B?c0JwaFVWRUdiVjlKcStnYUczNjBYUFBVRHJlWmVYb3M2LzZidXRBaVZiSEdR?= =?utf-8?B?bzllNVJHcmVqeGhvTjBieGNRSmpOM0cyQk1kUno1MlpDNFlOQ2FxbjRvdUw2?= =?utf-8?B?Q0lFOU54OUdoYWc3S2JzYm05azhRb1dyeWRkY2QrRDF2aXhwaEhVU1o2cnBD?= =?utf-8?B?YjBpUzJZMy8wNGFQZU11WktsdzE2QVNpYjJGQndFZ2hxQ2g0eWtUK2pJK1Nv?= =?utf-8?B?WUQ3YUE4MXRUQkR4V09CWjkyRlFoR25uNTNuMVQwZ01SNHdnL3hhZW96d1Fo?= =?utf-8?B?NDdnOUdjd1JDNlIySFBJYmZ4M0NORU1WSFF4d1lBdWFLYy9LTGZvQm52Ykpv?= =?utf-8?B?US8wc1FwT3VaRDREc24xelQxUnBZbnB2aHovTnhzMCt6S3Flc2ZDdDEvQWhv?= =?utf-8?B?NTgxbjl1OVI3YkZURThKY253M3llSWpEL1R6bHpFWEI3bUZuOEh4UEN2YUJv?= =?utf-8?B?YzFRSTJyQlJRTTJjZjhXNE14YVNBZEVRRldYek5hSEVjR3BzWGFhbnM2MWRu?= =?utf-8?B?Q2VmMC9hV2xrWlRIbkdFSHJseFIzOW1xT0oyRkZmVkVBUUVZdkd2d25MM21V?= =?utf-8?B?eWNWbXhPdlMrS1JDVVR5MnJpTk1kUmVydG1ERlV1a2xWQ1lmampnWDJsczBo?= =?utf-8?B?c3kwWEo0bmlXampxemxxRU1iTjdscGJRYytEL05RaXd0Zmduelgyd2ZYRDZJ?= =?utf-8?B?bzJtcGZZa1A4cC81ZHY0VTRjZlBhcmRWblB3R2UwcXd3WGIvbnVYaWZVVmNL?= =?utf-8?B?dzhQbXFZdjBkdVhlbU1VdnFwcWhkdnU5Y0dXaHJCTnludllWbzJZYU84RThI?= =?utf-8?B?dExUZW5aVTlFcGZXVUVxalZNejdPNG4vd0hlWStFNCtKZU5HejdjSmpYZ3lw?= =?utf-8?B?YUdMSWdFdkxnbExtSmFpcjJvRk53NjZRN01QSVMrZkJaaWc0QlluZXU5NW00?= =?utf-8?B?bGlJNFcwMnVFdmNkajhRblMzYkhqRGNqcWN2N3loeUpDNmJYRWErbHB2SzRh?= =?utf-8?B?OFJYNnY4TEZKQVF0cG56cjIxNkxZWFpCYXhjdjBYRVExeEhWZTFMbjZvVURQ?= =?utf-8?B?QXhuZXV6TlQ4Nml6N1hhWFZ4WC9DTDBnMlVhRzU2VjlUbk9QcGgvNWg2djVN?= =?utf-8?B?UGt2ekR3YjRmaTN1d1hvKzB6Q3pwR1E5ZWNnSXFwakdBSFJnRUx5SnNGQm54?= =?utf-8?B?M2lCclZrRHFEYllzb0QrZ1pNNm5GTzcwVmZFakgrYzhlRCtrVS8wUE9TNFYy?= =?utf-8?B?NldBZVdTNlhpQUhSaUp0c1cwZWx3RERoKytaeHY3MGtHa3pBYjVlQTNpNEV1?= =?utf-8?B?Q0owMWFIdEFmRUZiTzVnTFJoUjgwektzMU1tUEU4UjFtSE1LYkRJcVVuUWZi?= =?utf-8?B?anZxbHFXTXhtTUljZGlRQTg2NHA5WXZVaklrbEt1L1pNNDNrTHRsQ1gzYkQ5?= =?utf-8?B?YVE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: IsllrZDxOjXJGTIn3EdzFwhDgFnFSoxYcEVAjeAWV1yDi8ZRKDGrZuuhXqfhb1wf/gitPqJX4UXZvrfeoRflq3pyvU896TehEE9aKQ1gQIvvj8fumYXNW/SHi+cPlDrhHrCBNtngcqWEbJJQRTk57HNGkE43MAZ7YtvOdfjRA1XThLi3Jogbt42nSfK6Q8W2a/A5vaBjsqaQZ+robydSaR6v3gInBVVnHvLztdjNBgX/1J9U5vvg1iAJRwl0tSSpcxm0s5kwllEJ55QeMSC50ebDALJPHANGFYAFK0ucpGTSJJngKKm3cq9W57vLCVMUlomSnFktHIIXVeSBvLh9hG6ciLwc0gRCzgWqLmo//4WbdojLRtesEltsZ3FE51aqtwraYv9gbCbQ1AfSc0YvFafAC0dwoge43aYXJPs4nE5HzygNmzYnt7vPv2bCkb6EFZM2Hu7PwMn4cBHdYZs3tKXT1kzCPrvMjo1oyIx1dw45DSgldRCQn6w7lHFW9wYWmt3QVPYtpJqxkNj4GSXw9Eq3yQm7gkYXddAys88QMILm9+1yt6Y0JtBXAolVpaKc5gHYhdYWGhoLxs3SgNP6vUcvCiPEIknxNiNJHAR5K/g2e5Tq81IElJ+Ys4f6ayyAhH2DAwhJ2Mn6cNz0Ohu5Ae16SDU+TYvhkINBb1LM+6eOaMvTGv3pyceFZqjVKuqxRxt+M8QioVMLw0fn1G/D134oSI5ybelFSbIhB4dSlPR5KR46isE079hSkHefqBySSpY+lLKritA45QV1qoCENvEBuMRWI+7R5DY8Eay3T+EBmS8gVUfQJI/xNUDXjerR7iytYLeR+MUDkm5LM4qf70yfmcwCmWllXnzmWdnkWZ8= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: e920757b-65ff-4eb6-fa8e-08db4d6dae96 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 13:36:08.2338 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8S133c1BZPdnfbVPik+rWgrJQYDh+vPh2f0QM6e95mIQr2UO+sKhZGIfTNeEz+ueqjFoCFBiChGXpuTUrfzEa60xVVeZmu+yBfmyDTqD5Sg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6673 On 05/05/2023 2:31 pm, Jan Beulich wrote: > On 05.05.2023 15:22, Andrew Cooper wrote: >> On 05/05/2023 2:13 pm, Jan Beulich wrote: >>> On 05.05.2023 15:05, Andrew Cooper wrote: >>>> The SPDX forms without an explicit -only or -or-later suffix are deprecated >>>> and should not be used. >>> I guess this wants a reference to where this is specified. In particular ... >>> >>>> --- a/LICENSES/LGPL-2.1 >>>> +++ b/LICENSES/LGPL-2.1 >>>> @@ -1,5 +1,5 @@ >>>> -Valid-License-Identifier: LGPL-2.1 >>>> -Valid-License-Identifier: LGPL-2.1+ >>>> +Valid-License-Identifier: LGPL-2.1-only >>>> +Valid-License-Identifier: LGPL-2.1-or-later >>>> >>>> SPDX-URL: https://spdx.org/licenses/LGPL-2.1.html >>> ... I can't spot anything like this under e.g. this URL. >> Hmm yeah, it is irritating.  The statement is at >> https://spdx.org/licenses/ but only by virtue of two tables, the second >> of which is the list of deprecated identifiers. >> >> I'll put a paragraph about this in the commit message. >> >>> Also is there a reason you add Deprecated-Identifier: only to GPL-2.0? >>> Enumerating them would seem reasonable to me, not just for completeness, >>> but also in case we end up importing a file with a deprecated tag. >> We have problematic uses of GPL in tree, where we don't for LGPL. >> >> I'm considering a gitlab pass which will reject patches with use an >> identifier not in the permitted list, and reject in introduction of new >> uses of the deprecated ones.    For this, the deprecated-but-tolerated >> tags need calling out in some machine-readable way, but I don't think >> it's helpful to express the tolerating of a tag we don't have any >> violations of. > Hmm, okay. With the expanded commit message > Acked-by: Jan Beulich Thanks.  FAOD, here's the full commit message with adjustment: LICENSES: Remove the use of deprecated LGPL SPDX tags The SPDX forms without an explicit -only or -or-later suffix are deprecated and should not be used. Somewhat unhelpfully at the time of writing, this only appears to be indicated by the separation of the two tables at https://spdx.org/licenses/     The recent changes to libacpi are the only examples of deprecated LGPL tags in tree, so fix them all up. For GPL, we have many examples using deprecated tags.  For now, just identify them as such and recommend that no new instances get added. Signed-off-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Fri May 05 13:51:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 13:51:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530377.825980 (Exim 4.92) (envelope-from ) id 1puvpy-00068s-VT; Fri, 05 May 2023 13:51:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530377.825980; Fri, 05 May 2023 13:51:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puvpy-00068l-Rs; Fri, 05 May 2023 13:51:06 +0000 Received: by outflank-mailman (input) for mailman id 530377; Fri, 05 May 2023 13:51:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puvpx-000677-Jv; Fri, 05 May 2023 13:51:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puvpx-0003PB-CA; Fri, 05 May 2023 13:51:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puvpw-0002NI-Th; Fri, 05 May 2023 13:51:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1puvpw-0005Vp-TH; Fri, 05 May 2023 13:51:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1Z0p4NsvHgRE8hBIfyDsX0pB+U+Uq/KCaHTWOd+Y0iQ=; b=a2HSVBH2dDESLbco+aQUfSedmn t79LJhZRxgrtzTT5oDdWdAkTZuGJkFhNji+OK0XH/9mvp+7mvVDzeUtedguoMK4qvV0ONAGyLmhNV ICX13QRabyeX5AkmfWFa3Vp/Uq6ti08dBc7jxQ5qDcQKReTvhQMFHwseGm9Zu8UE18Ho=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180544: all pass - PUSHED X-Osstest-Versions-This: ovmf=757f502a3b350436877102c3043744e021537c19 X-Osstest-Versions-That: ovmf=94c802e108a082d6f74c854bea8bd98fe7808453 From: osstest service owner Date: Fri, 05 May 2023 13:51:04 +0000 flight 180544 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180544/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 757f502a3b350436877102c3043744e021537c19 baseline version: ovmf 94c802e108a082d6f74c854bea8bd98fe7808453 Last test of basis 180542 2023-05-05 08:42:19 Z 0 days Testing same since 180544 2023-05-05 12:12:07 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michael D Kinney Rebecca Cran jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 94c802e108..757f502a3b 757f502a3b350436877102c3043744e021537c19 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri May 05 15:13:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 15:13:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530406.825989 (Exim 4.92) (envelope-from ) id 1pux6u-0006L6-Nw; Fri, 05 May 2023 15:12:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530406.825989; Fri, 05 May 2023 15:12:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pux6u-0006Kz-LL; Fri, 05 May 2023 15:12:40 +0000 Received: by outflank-mailman (input) for mailman id 530406; Fri, 05 May 2023 15:12:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pux6t-0006Kp-7p; Fri, 05 May 2023 15:12:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pux6s-0005Jy-Rz; Fri, 05 May 2023 15:12:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pux6s-0004Dy-CS; Fri, 05 May 2023 15:12:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pux6s-0004dT-C5; Fri, 05 May 2023 15:12:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ph6JG8TL+ijJwusBIya6RR0ONDZcAqfert5So9C/SZA=; b=XLHYxmyTM9YSYlOBbrFWXfhvzy R/icvQ7/FwVAWIQZIvCGRVr5fgfYMjy6M8rLopzkm/cdYM/x8uKSvpPonpDortvzYZ4wckd72Y6eD EGXLRczhWovJdCzb9Ic5JLsrD+rXnxeg90oZU9vidK81AllU+nwTKooNSy8t5+3BRrlY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180537: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=b95a72bb5b2df24ff1baaa27920e57947dc97d49 X-Osstest-Versions-That: xen=b95a72bb5b2df24ff1baaa27920e57947dc97d49 From: osstest service owner Date: Fri, 05 May 2023 15:12:38 +0000 flight 180537 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/180537/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail in 180528 pass in 180537 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 180528 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180528 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180528 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180528 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180528 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180528 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 180528 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180528 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 180528 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 180528 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180528 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180528 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180528 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass version targeted for testing: xen b95a72bb5b2df24ff1baaa27920e57947dc97d49 baseline version: xen b95a72bb5b2df24ff1baaa27920e57947dc97d49 Last test of basis 180537 2023-05-05 01:52:22 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Fri May 05 15:22:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 15:22:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530422.826039 (Exim 4.92) (envelope-from ) id 1puxGO-0000CY-Gp; Fri, 05 May 2023 15:22:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530422.826039; Fri, 05 May 2023 15:22:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puxGO-00007r-79; Fri, 05 May 2023 15:22:28 +0000 Received: by outflank-mailman (input) for mailman id 530422; Fri, 05 May 2023 15:22:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puxG0-0007pR-Uy for xen-devel@lists.xenproject.org; Fri, 05 May 2023 15:22:04 +0000 Received: from smtp-8fa9.mail.infomaniak.ch (smtp-8fa9.mail.infomaniak.ch [83.166.143.169]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9612e960-eb58-11ed-8611-37d641c3527e; Fri, 05 May 2023 17:22:02 +0200 (CEST) Received: from smtp-3-0000.mail.infomaniak.ch (unknown [10.4.36.107]) by smtp-2-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4QCZDB3g0SzMqb46; Fri, 5 May 2023 17:22:02 +0200 (CEST) Received: from unknown by smtp-3-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4QCZD96vnsz1jJ; Fri, 5 May 2023 17:22:01 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9612e960-eb58-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=digikod.net; s=20191114; t=1683300122; bh=ZzOynGNQaPpNtiJ0zd91Lcwn9zW2+9ulyf1drBQ/Prg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vaA3xKDBfcFF3nZ5ibwAf9TNvpVjn95vBk3M+IQ75Zbj+yeoIWJoXq+IK2rjSvz6J Ek6QJhVl0QOgjeidTZl8FeFQNrpxRWC0pFUxavnSrBqF5C1GDY1DYBVA7I141lj7uP nCrFgP2JPKXF3ssC9wKq84oe+CDtv4db+Lpg7rcs= From: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= To: Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Ingo Molnar , Kees Cook , Paolo Bonzini , Sean Christopherson , Thomas Gleixner , Vitaly Kuznetsov , Wanpeng Li Cc: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= , Alexander Graf , Forrest Yuan Yu , James Morris , John Andersen , Liran Alon , "Madhavan T . Venkataraman" , Marian Rotariu , =?UTF-8?q?Mihai=20Don=C8=9Bu?= , =?UTF-8?q?Nicu=C8=99or=20C=C3=AE=C8=9Bu?= , Rick Edgecombe , Thara Gopinath , Will Deacon , Zahra Tarkhani , =?UTF-8?q?=C8=98tefan=20=C8=98icleru?= , dev@lists.cloudhypervisor.org, kvm@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, x86@kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH v1 5/9] KVM: x86: Add new hypercall to lock control registers Date: Fri, 5 May 2023 17:20:42 +0200 Message-Id: <20230505152046.6575-6-mic@digikod.net> In-Reply-To: <20230505152046.6575-1-mic@digikod.net> References: <20230505152046.6575-1-mic@digikod.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Infomaniak-Routing: alpha This enables guests to lock their CR0 and CR4 registers with a subset of X86_CR0_WP, X86_CR4_SMEP, X86_CR4_SMAP, X86_CR4_UMIP, X86_CR4_FSGSBASE and X86_CR4_CET flags. The new KVM_HC_LOCK_CR_UPDATE hypercall takes two arguments. The first is to identify the control register, and the second is a bit mask to pin (i.e. mark as read-only). These register flags should already be pinned by Linux guests, but once compromised, this self-protection mechanism could be disabled, which is not the case with this dedicated hypercall. Cc: Borislav Petkov Cc: Dave Hansen Cc: H. Peter Anvin Cc: Ingo Molnar Cc: Kees Cook Cc: Madhavan T. Venkataraman Cc: Paolo Bonzini Cc: Sean Christopherson Cc: Thomas Gleixner Cc: Vitaly Kuznetsov Cc: Wanpeng Li Signed-off-by: Mickaël Salaün Link: https://lore.kernel.org/r/20230505152046.6575-6-mic@digikod.net --- Documentation/virt/kvm/x86/hypercalls.rst | 15 +++++ arch/x86/kernel/cpu/common.c | 2 +- arch/x86/kvm/vmx/vmx.c | 10 ++++ arch/x86/kvm/x86.c | 72 +++++++++++++++++++++++ arch/x86/kvm/x86.h | 16 +++++ include/linux/kvm_host.h | 3 + include/uapi/linux/kvm_para.h | 1 + 7 files changed, 118 insertions(+), 1 deletion(-) diff --git a/Documentation/virt/kvm/x86/hypercalls.rst b/Documentation/virt/kvm/x86/hypercalls.rst index 0ec79cc77f53..8aa5d28986e3 100644 --- a/Documentation/virt/kvm/x86/hypercalls.rst +++ b/Documentation/virt/kvm/x86/hypercalls.rst @@ -207,3 +207,18 @@ identified with set of physical page ranges (GFNs). The HEKI_ATTR_MEM_NOWRITE memory page range attribute forbids related modification to the guest. Returns 0 on success or a KVM error code otherwise. + +10. KVM_HC_LOCK_CR_UPDATE +------------------------- + +:Architecture: x86 +:Status: active +:Purpose: Request some control registers to be restricted. + +- a0: identify a control register +- a1: bit mask to make some flags read-only + +The hypercall lets a guest request control register flags to be pinned for +itself. + +Returns 0 on success or a KVM error code otherwise. diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c index f3cc7699e1e1..dd89379fe5ac 100644 --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -413,7 +413,7 @@ static __always_inline void setup_umip(struct cpuinfo_x86 *c) } /* These bits should not change their value after CPU init is finished. */ -static const unsigned long cr4_pinned_mask = +const unsigned long cr4_pinned_mask = X86_CR4_SMEP | X86_CR4_SMAP | X86_CR4_UMIP | X86_CR4_FSGSBASE | X86_CR4_CET; static DEFINE_STATIC_KEY_FALSE_RO(cr_pinning); diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c index 9870db887a62..931688edc8eb 100644 --- a/arch/x86/kvm/vmx/vmx.c +++ b/arch/x86/kvm/vmx/vmx.c @@ -3162,6 +3162,11 @@ void vmx_set_cr0(struct kvm_vcpu *vcpu, unsigned long cr0) struct vcpu_vmx *vmx = to_vmx(vcpu); unsigned long hw_cr0, old_cr0_pg; u32 tmp; + int res; + + res = heki_check_cr(vcpu->kvm, 0, cr0); + if (res) + return; old_cr0_pg = kvm_read_cr0_bits(vcpu, X86_CR0_PG); @@ -3323,6 +3328,11 @@ void vmx_set_cr4(struct kvm_vcpu *vcpu, unsigned long cr4) * this bit, even if host CR4.MCE == 0. */ unsigned long hw_cr4; + int res; + + res = heki_check_cr(vcpu->kvm, 4, cr4); + if (res) + return; hw_cr4 = (cr4_read_shadow() & X86_CR4_MCE) | (cr4 & ~X86_CR4_MCE); if (is_unrestricted_guest(vcpu)) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index ffab64d08de3..a529455359ac 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -7927,11 +7927,77 @@ static unsigned long emulator_get_cr(struct x86_emulate_ctxt *ctxt, int cr) return value; } +#ifdef CONFIG_HEKI + +extern unsigned long cr4_pinned_mask; + +static int heki_lock_cr(struct kvm *const kvm, const unsigned long cr, + unsigned long pin) +{ + if (!pin) + return -KVM_EINVAL; + + switch (cr) { + case 0: + /* Cf. arch/x86/kernel/cpu/common.c */ + if (!(pin & X86_CR0_WP)) + return -KVM_EINVAL; + + if ((read_cr0() & pin) != pin) + return -KVM_EINVAL; + + atomic_long_or(pin, &kvm->heki_pinned_cr0); + return 0; + case 4: + /* Checks for irrelevant bits. */ + if ((pin & cr4_pinned_mask) != pin) + return -KVM_EINVAL; + + /* Ignores bits not present in host. */ + pin &= __read_cr4(); + atomic_long_or(pin, &kvm->heki_pinned_cr4); + return 0; + } + return -KVM_EINVAL; +} + +int heki_check_cr(const struct kvm *const kvm, const unsigned long cr, + const unsigned long val) +{ + unsigned long pinned; + + switch (cr) { + case 0: + pinned = atomic_long_read(&kvm->heki_pinned_cr0); + if ((val & pinned) != pinned) { + pr_warn_ratelimited( + "heki-kvm: Blocked CR0 update: 0x%lx\n", val); + return -KVM_EPERM; + } + return 0; + case 4: + pinned = atomic_long_read(&kvm->heki_pinned_cr4); + if ((val & pinned) != pinned) { + pr_warn_ratelimited( + "heki-kvm: Blocked CR4 update: 0x%lx\n", val); + return -KVM_EPERM; + } + return 0; + } + return 0; +} + +#endif /* CONFIG_HEKI */ + static int emulator_set_cr(struct x86_emulate_ctxt *ctxt, int cr, ulong val) { struct kvm_vcpu *vcpu = emul_to_vcpu(ctxt); int res = 0; + res = heki_check_cr(vcpu->kvm, cr, val); + if (res) + return res; + switch (cr) { case 0: res = kvm_set_cr0(vcpu, mk_cr_64(kvm_read_cr0(vcpu), val)); @@ -9858,6 +9924,12 @@ int kvm_emulate_hypercall(struct kvm_vcpu *vcpu) else ret = heki_lock_mem_page_ranges(vcpu->kvm, a0, a1); break; + case KVM_HC_LOCK_CR_UPDATE: + if (a0 > U32_MAX) + ret = -KVM_EINVAL; + else + ret = heki_lock_cr(vcpu->kvm, a0, a1); + break; #endif /* CONFIG_HEKI */ default: ret = -KVM_ENOSYS; diff --git a/arch/x86/kvm/x86.h b/arch/x86/kvm/x86.h index 9de72586f406..3e80a60ecbd8 100644 --- a/arch/x86/kvm/x86.h +++ b/arch/x86/kvm/x86.h @@ -276,6 +276,22 @@ static inline bool kvm_check_has_quirk(struct kvm *kvm, u64 quirk) return !(kvm->arch.disabled_quirks & quirk); } +#ifdef CONFIG_HEKI + +int heki_check_cr(const struct kvm *kvm, unsigned long cr, unsigned long val); + +bool kvm_heki_is_exec_allowed(struct kvm_vcpu *vcpu, gpa_t gpa); + +#else /* CONFIG_HEKI */ + +static inline int heki_check_cr(const struct kvm *const kvm, + const unsigned long cr, const unsigned long val) +{ + return 0; +} + +#endif /* CONFIG_HEKI */ + void kvm_inject_realmode_interrupt(struct kvm_vcpu *vcpu, int irq, int inc_eip); u64 get_kvmclock_ns(struct kvm *kvm); diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h index 39a1bdc2ba42..ab9dc723bc89 100644 --- a/include/linux/kvm_host.h +++ b/include/linux/kvm_host.h @@ -812,6 +812,9 @@ struct kvm { #define HEKI_GFN_MAX 16 atomic_t heki_gfn_no_write_num; struct heki_gfn_range heki_gfn_no_write[HEKI_GFN_MAX]; + + atomic_long_t heki_pinned_cr0; + atomic_long_t heki_pinned_cr4; #endif /* CONFIG_HEKI */ #ifdef CONFIG_HAVE_KVM_PM_NOTIFIER diff --git a/include/uapi/linux/kvm_para.h b/include/uapi/linux/kvm_para.h index d7512a10880e..9f68d4ba646b 100644 --- a/include/uapi/linux/kvm_para.h +++ b/include/uapi/linux/kvm_para.h @@ -31,6 +31,7 @@ #define KVM_HC_SCHED_YIELD 11 #define KVM_HC_MAP_GPA_RANGE 12 #define KVM_HC_LOCK_MEM_PAGE_RANGES 13 +#define KVM_HC_LOCK_CR_UPDATE 14 /* * hypercalls use architecture specific -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Fri May 05 15:22:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 15:22:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530413.826005 (Exim 4.92) (envelope-from ) id 1puxGM-0007z8-Ki; Fri, 05 May 2023 15:22:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530413.826005; Fri, 05 May 2023 15:22:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puxGM-0007yS-Gc; Fri, 05 May 2023 15:22:26 +0000 Received: by outflank-mailman (input) for mailman id 530413; Fri, 05 May 2023 15:22:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puxFw-0007pX-AD for xen-devel@lists.xenproject.org; Fri, 05 May 2023 15:22:00 +0000 Received: from smtp-190f.mail.infomaniak.ch (smtp-190f.mail.infomaniak.ch [185.125.25.15]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 932ffb88-eb58-11ed-b226-6b7b168915f2; Fri, 05 May 2023 17:21:58 +0200 (CEST) Received: from smtp-3-0000.mail.infomaniak.ch (unknown [10.4.36.107]) by smtp-2-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4QCZD54cDqzMqZgk; Fri, 5 May 2023 17:21:57 +0200 (CEST) Received: from unknown by smtp-3-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4QCZD330PNz1j3; Fri, 5 May 2023 17:21:55 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 932ffb88-eb58-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=digikod.net; s=20191114; t=1683300117; bh=Sck5/KPfNUhl8VtyERkRdjhXvgnFmYNWT4AHdC4aHDg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Xy2uQqu3d6UyYIRq1FHdiksjhJdSOrSuJr5w83oL1hRdMuCXet7azQy+AgpzQUfui mWmlvk+7HFvNzEiU9UANLTHxNmTdUoA1IlKd2pKbr/FKAIab/IQO57y70uUQT1Y0RN NjhO3YHPUfCPweoKfcyI2ayyvi0vzx4JsaOeBc24= From: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= To: Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Ingo Molnar , Kees Cook , Paolo Bonzini , Sean Christopherson , Thomas Gleixner , Vitaly Kuznetsov , Wanpeng Li Cc: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= , Alexander Graf , Forrest Yuan Yu , James Morris , John Andersen , Liran Alon , "Madhavan T . Venkataraman" , Marian Rotariu , =?UTF-8?q?Mihai=20Don=C8=9Bu?= , =?UTF-8?q?Nicu=C8=99or=20C=C3=AE=C8=9Bu?= , Rick Edgecombe , Thara Gopinath , Will Deacon , Zahra Tarkhani , =?UTF-8?q?=C8=98tefan=20=C8=98icleru?= , dev@lists.cloudhypervisor.org, kvm@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, x86@kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH v1 1/9] KVM: x86: Add kvm_x86_ops.fault_gva() Date: Fri, 5 May 2023 17:20:38 +0200 Message-Id: <20230505152046.6575-2-mic@digikod.net> In-Reply-To: <20230505152046.6575-1-mic@digikod.net> References: <20230505152046.6575-1-mic@digikod.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Infomaniak-Routing: alpha This function is needed for kvm_mmu_page_fault() to create synthetic page faults. Code originally written by Mihai Donțu and Nicușor Cîțu: https://lore.kernel.org/r/20211006173113.26445-18-alazar@bitdefender.com Renamed fault_gla() to fault_gva() and use the new EPT_VIOLATION_GVA_IS_VALID. Cc: Borislav Petkov Cc: Dave Hansen Cc: H. Peter Anvin Cc: Ingo Molnar Cc: Kees Cook Cc: Madhavan T. Venkataraman Cc: Paolo Bonzini Cc: Sean Christopherson Cc: Thomas Gleixner Cc: Vitaly Kuznetsov Cc: Wanpeng Li Co-developed-by: Mihai Donțu Signed-off-by: Mihai Donțu Co-developed-by: Nicușor Cîțu Signed-off-by: Nicușor Cîțu Signed-off-by: Mickaël Salaün Link: https://lore.kernel.org/r/20230505152046.6575-2-mic@digikod.net --- arch/x86/include/asm/kvm-x86-ops.h | 1 + arch/x86/include/asm/kvm_host.h | 2 ++ arch/x86/kvm/svm/svm.c | 9 +++++++++ arch/x86/kvm/vmx/vmx.c | 10 ++++++++++ 4 files changed, 22 insertions(+) diff --git a/arch/x86/include/asm/kvm-x86-ops.h b/arch/x86/include/asm/kvm-x86-ops.h index abccd51dcfca..b761182a9444 100644 --- a/arch/x86/include/asm/kvm-x86-ops.h +++ b/arch/x86/include/asm/kvm-x86-ops.h @@ -131,6 +131,7 @@ KVM_X86_OP(msr_filter_changed) KVM_X86_OP(complete_emulated_msr) KVM_X86_OP(vcpu_deliver_sipi_vector) KVM_X86_OP_OPTIONAL_RET0(vcpu_get_apicv_inhibit_reasons); +KVM_X86_OP(fault_gva) #undef KVM_X86_OP #undef KVM_X86_OP_OPTIONAL diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h index 6aaae18f1854..f319bcdeb8bd 100644 --- a/arch/x86/include/asm/kvm_host.h +++ b/arch/x86/include/asm/kvm_host.h @@ -1706,6 +1706,8 @@ struct kvm_x86_ops { * Returns vCPU specific APICv inhibit reasons */ unsigned long (*vcpu_get_apicv_inhibit_reasons)(struct kvm_vcpu *vcpu); + + u64 (*fault_gva)(struct kvm_vcpu *vcpu); }; struct kvm_x86_nested_ops { diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c index 9a194aa1a75a..8b47b38aaf7f 100644 --- a/arch/x86/kvm/svm/svm.c +++ b/arch/x86/kvm/svm/svm.c @@ -4700,6 +4700,13 @@ static int svm_vm_init(struct kvm *kvm) return 0; } +static u64 svm_fault_gva(struct kvm_vcpu *vcpu) +{ + const struct vcpu_svm *svm = to_svm(vcpu); + + return svm->vcpu.arch.cr2 ? svm->vcpu.arch.cr2 : ~0ull; +} + static struct kvm_x86_ops svm_x86_ops __initdata = { .name = "kvm_amd", @@ -4826,6 +4833,8 @@ static struct kvm_x86_ops svm_x86_ops __initdata = { .vcpu_deliver_sipi_vector = svm_vcpu_deliver_sipi_vector, .vcpu_get_apicv_inhibit_reasons = avic_vcpu_get_apicv_inhibit_reasons, + + .fault_gva = svm_fault_gva, }; /* diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c index 7eec0226d56a..9870db887a62 100644 --- a/arch/x86/kvm/vmx/vmx.c +++ b/arch/x86/kvm/vmx/vmx.c @@ -8067,6 +8067,14 @@ static void vmx_vm_destroy(struct kvm *kvm) free_pages((unsigned long)kvm_vmx->pid_table, vmx_get_pid_table_order(kvm)); } +static u64 vmx_fault_gva(struct kvm_vcpu *vcpu) +{ + if (vcpu->arch.exit_qualification & EPT_VIOLATION_GVA_IS_VALID) + return vmcs_readl(GUEST_LINEAR_ADDRESS); + + return ~0ull; +} + static struct kvm_x86_ops vmx_x86_ops __initdata = { .name = "kvm_intel", @@ -8204,6 +8212,8 @@ static struct kvm_x86_ops vmx_x86_ops __initdata = { .complete_emulated_msr = kvm_complete_insn_gp, .vcpu_deliver_sipi_vector = kvm_vcpu_deliver_sipi_vector, + + .fault_gva = vmx_fault_gva, }; static unsigned int vmx_handle_intel_pt_intr(void) -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Fri May 05 15:22:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 15:22:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530415.826012 (Exim 4.92) (envelope-from ) id 1puxGN-000870-05; Fri, 05 May 2023 15:22:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530415.826012; Fri, 05 May 2023 15:22:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puxGM-00085e-RA; Fri, 05 May 2023 15:22:26 +0000 Received: by outflank-mailman (input) for mailman id 530415; Fri, 05 May 2023 15:22:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puxFx-0007pR-DR for xen-devel@lists.xenproject.org; Fri, 05 May 2023 15:22:01 +0000 Received: from smtp-42ab.mail.infomaniak.ch (smtp-42ab.mail.infomaniak.ch [84.16.66.171]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 93f51caf-eb58-11ed-8611-37d641c3527e; Fri, 05 May 2023 17:21:59 +0200 (CEST) Received: from smtp-3-0001.mail.infomaniak.ch (unknown [10.4.36.108]) by smtp-2-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4QCZD66dQnzMqFxM; Fri, 5 May 2023 17:21:58 +0200 (CEST) Received: from unknown by smtp-3-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4QCZD60R4vzMpxBm; Fri, 5 May 2023 17:21:58 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 93f51caf-eb58-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=digikod.net; s=20191114; t=1683300118; bh=SrFXUO04Nqgobaetk479001er96mJxIHBBoQ7lZlahM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wpaXL8F3FW0faPdmfsziq7KNPT5JCNQ53r4Uxr1P2zxnScOSqz2qoUmOrpuWgBv6i NuH/ri5XXTqceSyc0YP1flR3e6CIXrSsEa0s/oRFw99Emxppybi4No1rUvvsCb7yVM kRuXppKZpZtphifBIw5w6qtCumEL2JsEPthxKuz0= From: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= To: Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Ingo Molnar , Kees Cook , Paolo Bonzini , Sean Christopherson , Thomas Gleixner , Vitaly Kuznetsov , Wanpeng Li Cc: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= , Alexander Graf , Forrest Yuan Yu , James Morris , John Andersen , Liran Alon , "Madhavan T . Venkataraman" , Marian Rotariu , =?UTF-8?q?Mihai=20Don=C8=9Bu?= , =?UTF-8?q?Nicu=C8=99or=20C=C3=AE=C8=9Bu?= , Rick Edgecombe , Thara Gopinath , Will Deacon , Zahra Tarkhani , =?UTF-8?q?=C8=98tefan=20=C8=98icleru?= , dev@lists.cloudhypervisor.org, kvm@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, x86@kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH v1 2/9] KVM: x86/mmu: Add support for prewrite page tracking Date: Fri, 5 May 2023 17:20:39 +0200 Message-Id: <20230505152046.6575-3-mic@digikod.net> In-Reply-To: <20230505152046.6575-1-mic@digikod.net> References: <20230505152046.6575-1-mic@digikod.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Infomaniak-Routing: alpha Add a new page tracking mode to deny a page update and throw a page fault to the guest. This is useful for KVM to be able to make some pages non-writable (not read-only because it doesn't imply execution restrictions), see the next Heki commits. This kind of synthetic kernel page fault needs to be handled by the guest, which is not currently the case, making it try again and again. This will be part of a follow-up patch series. Update emulator_read_write_onepage() to handle X86EMUL_CONTINUE and X86EMUL_PROPAGATE_FAULT. Update page_fault_handle_page_track() to call kvm_slot_page_track_is_active() whenever this is required for KVM_PAGE_TRACK_PREWRITE and KVM_PAGE_TRACK_WRITE, even if one tracker already returned true. Invert the return code semantic for read_emulate() and write_emulate(): - from 1=Ok 0=Error - to X86EMUL_* return codes (e.g. X86EMUL_CONTINUE == 0) Imported the prewrite page tracking support part originally written by Mihai Donțu, Marian Rotariu, and Ștefan Șicleru: https://lore.kernel.org/r/20211006173113.26445-27-alazar@bitdefender.com https://lore.kernel.org/r/20211006173113.26445-28-alazar@bitdefender.com Removed the GVA changes for page tracking, removed the X86EMUL_RETRY_INSTR case, and some emulation part for now. Cc: Borislav Petkov Cc: Dave Hansen Cc: H. Peter Anvin Cc: Ingo Molnar Cc: Kees Cook Cc: Madhavan T. Venkataraman Cc: Marian Rotariu Cc: Mihai Donțu Cc: Paolo Bonzini Cc: Sean Christopherson Cc: Thomas Gleixner Cc: Vitaly Kuznetsov Cc: Wanpeng Li Cc: Ștefan Șicleru Signed-off-by: Mickaël Salaün Link: https://lore.kernel.org/r/20230505152046.6575-3-mic@digikod.net --- arch/x86/include/asm/kvm_page_track.h | 12 +++++ arch/x86/kvm/mmu/mmu.c | 64 ++++++++++++++++++++++----- arch/x86/kvm/mmu/page_track.c | 33 +++++++++++++- arch/x86/kvm/mmu/spte.c | 6 +++ arch/x86/kvm/x86.c | 27 +++++++---- 5 files changed, 122 insertions(+), 20 deletions(-) diff --git a/arch/x86/include/asm/kvm_page_track.h b/arch/x86/include/asm/kvm_page_track.h index eb186bc57f6a..a7fb4ff888e6 100644 --- a/arch/x86/include/asm/kvm_page_track.h +++ b/arch/x86/include/asm/kvm_page_track.h @@ -3,6 +3,7 @@ #define _ASM_X86_KVM_PAGE_TRACK_H enum kvm_page_track_mode { + KVM_PAGE_TRACK_PREWRITE, KVM_PAGE_TRACK_WRITE, KVM_PAGE_TRACK_MAX, }; @@ -22,6 +23,16 @@ struct kvm_page_track_notifier_head { struct kvm_page_track_notifier_node { struct hlist_node node; + /* + * It is called when guest is writing the write-tracked page + * and the write emulation didn't happened yet. + * + * @vcpu: the vcpu where the write access happened + * @gpa: the physical address written by guest + * @node: this nodet + */ + bool (*track_prewrite)(struct kvm_vcpu *vcpu, gpa_t gpa, + struct kvm_page_track_notifier_node *node); /* * It is called when guest is writing the write-tracked page * and write emulation is finished at that time. @@ -73,6 +84,7 @@ kvm_page_track_register_notifier(struct kvm *kvm, void kvm_page_track_unregister_notifier(struct kvm *kvm, struct kvm_page_track_notifier_node *n); +bool kvm_page_track_prewrite(struct kvm_vcpu *vcpu, gpa_t gpa); void kvm_page_track_write(struct kvm_vcpu *vcpu, gpa_t gpa, const u8 *new, int bytes); void kvm_page_track_flush_slot(struct kvm *kvm, struct kvm_memory_slot *slot); diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c index 835426254e76..e5d1e241ff0f 100644 --- a/arch/x86/kvm/mmu/mmu.c +++ b/arch/x86/kvm/mmu/mmu.c @@ -793,9 +793,13 @@ static void account_shadowed(struct kvm *kvm, struct kvm_mmu_page *sp) slot = __gfn_to_memslot(slots, gfn); /* the non-leaf shadow pages are keeping readonly. */ - if (sp->role.level > PG_LEVEL_4K) - return kvm_slot_page_track_add_page(kvm, slot, gfn, - KVM_PAGE_TRACK_WRITE); + if (sp->role.level > PG_LEVEL_4K) { + kvm_slot_page_track_add_page(kvm, slot, gfn, + KVM_PAGE_TRACK_PREWRITE); + kvm_slot_page_track_add_page(kvm, slot, gfn, + KVM_PAGE_TRACK_WRITE); + return; + } kvm_mmu_gfn_disallow_lpage(slot, gfn); @@ -840,9 +844,13 @@ static void unaccount_shadowed(struct kvm *kvm, struct kvm_mmu_page *sp) gfn = sp->gfn; slots = kvm_memslots_for_spte_role(kvm, sp->role); slot = __gfn_to_memslot(slots, gfn); - if (sp->role.level > PG_LEVEL_4K) - return kvm_slot_page_track_remove_page(kvm, slot, gfn, - KVM_PAGE_TRACK_WRITE); + if (sp->role.level > PG_LEVEL_4K) { + kvm_slot_page_track_remove_page(kvm, slot, gfn, + KVM_PAGE_TRACK_PREWRITE); + kvm_slot_page_track_remove_page(kvm, slot, gfn, + KVM_PAGE_TRACK_WRITE); + return; + } kvm_mmu_gfn_allow_lpage(slot, gfn); } @@ -2714,7 +2722,10 @@ int mmu_try_to_unsync_pages(struct kvm *kvm, const struct kvm_memory_slot *slot, * track machinery is used to write-protect upper-level shadow pages, * i.e. this guards the role.level == 4K assertion below! */ - if (kvm_slot_page_track_is_active(kvm, slot, gfn, KVM_PAGE_TRACK_WRITE)) + if (kvm_slot_page_track_is_active(kvm, slot, gfn, + KVM_PAGE_TRACK_PREWRITE) || + kvm_slot_page_track_is_active(kvm, slot, gfn, + KVM_PAGE_TRACK_WRITE)) return -EPERM; /* @@ -4103,6 +4114,8 @@ static int handle_mmio_page_fault(struct kvm_vcpu *vcpu, u64 addr, bool direct) static bool page_fault_handle_page_track(struct kvm_vcpu *vcpu, struct kvm_page_fault *fault) { + bool ret = false; + if (unlikely(fault->rsvd)) return false; @@ -4113,10 +4126,14 @@ static bool page_fault_handle_page_track(struct kvm_vcpu *vcpu, * guest is writing the page which is write tracked which can * not be fixed by page fault handler. */ - if (kvm_slot_page_track_is_active(vcpu->kvm, fault->slot, fault->gfn, KVM_PAGE_TRACK_WRITE)) - return true; + ret = kvm_slot_page_track_is_active(vcpu->kvm, fault->slot, fault->gfn, + KVM_PAGE_TRACK_PREWRITE) || + ret; + ret = kvm_slot_page_track_is_active(vcpu->kvm, fault->slot, fault->gfn, + KVM_PAGE_TRACK_WRITE) || + ret; - return false; + return ret; } static void shadow_page_table_clear_flood(struct kvm_vcpu *vcpu, gva_t addr) @@ -5600,6 +5617,33 @@ int noinline kvm_mmu_page_fault(struct kvm_vcpu *vcpu, gpa_t cr2_or_gpa, u64 err if (r != RET_PF_EMULATE) return 1; + if ((error_code & PFERR_WRITE_MASK) && + !kvm_page_track_prewrite(vcpu, cr2_or_gpa)) { + struct x86_exception fault = { + .vector = PF_VECTOR, + .error_code_valid = true, + .error_code = error_code, + .nested_page_fault = false, + /* + * TODO: This kind of kernel page fault needs to be handled by + * the guest, which is not currently the case, making it try + * again and again. + * + * You may want to test with cr2_or_gva to see the page + * fault caught by the guest kernel (thinking it is a + * user space fault). + */ + .address = static_call(kvm_x86_fault_gva)(vcpu), + .async_page_fault = false, + }; + + pr_warn_ratelimited( + "heki-kvm: Creating write #PF at 0x%016llx\n", + fault.address); + kvm_inject_page_fault(vcpu, &fault); + return RET_PF_INVALID; + } + /* * Before emulating the instruction, check if the error code * was due to a RO violation while translating the guest page. diff --git a/arch/x86/kvm/mmu/page_track.c b/arch/x86/kvm/mmu/page_track.c index 2e09d1b6249f..2454887cd48b 100644 --- a/arch/x86/kvm/mmu/page_track.c +++ b/arch/x86/kvm/mmu/page_track.c @@ -131,9 +131,10 @@ void kvm_slot_page_track_add_page(struct kvm *kvm, */ kvm_mmu_gfn_disallow_lpage(slot, gfn); - if (mode == KVM_PAGE_TRACK_WRITE) + if (mode == KVM_PAGE_TRACK_PREWRITE || mode == KVM_PAGE_TRACK_WRITE) { if (kvm_mmu_slot_gfn_write_protect(kvm, slot, gfn, PG_LEVEL_4K)) kvm_flush_remote_tlbs(kvm); + } } EXPORT_SYMBOL_GPL(kvm_slot_page_track_add_page); @@ -248,6 +249,36 @@ kvm_page_track_unregister_notifier(struct kvm *kvm, } EXPORT_SYMBOL_GPL(kvm_page_track_unregister_notifier); +/* + * Notify the node that a write access is about to happen. Returning false + * doesn't stop the other nodes from being called, but it will stop + * the emulation. + * + * The node should figure out if the written page is the one that the node + * is interested in by itself. + */ +bool kvm_page_track_prewrite(struct kvm_vcpu *vcpu, gpa_t gpa) +{ + struct kvm_page_track_notifier_head *head; + struct kvm_page_track_notifier_node *n; + int idx; + bool ret = true; + + head = &vcpu->kvm->arch.track_notifier_head; + + if (hlist_empty(&head->track_notifier_list)) + return ret; + + idx = srcu_read_lock(&head->track_srcu); + hlist_for_each_entry_srcu(n, &head->track_notifier_list, node, + srcu_read_lock_held(&head->track_srcu)) + if (n->track_prewrite) + if (!n->track_prewrite(vcpu, gpa, n)) + ret = false; + srcu_read_unlock(&head->track_srcu, idx); + return ret; +} + /* * Notify the node that write access is intercepted and write emulation is * finished at this time. diff --git a/arch/x86/kvm/mmu/spte.c b/arch/x86/kvm/mmu/spte.c index c0fd7e049b4e..639f220a1ed5 100644 --- a/arch/x86/kvm/mmu/spte.c +++ b/arch/x86/kvm/mmu/spte.c @@ -144,6 +144,12 @@ bool make_spte(struct kvm_vcpu *vcpu, struct kvm_mmu_page *sp, u64 spte = SPTE_MMU_PRESENT_MASK; bool wrprot = false; + if (kvm_slot_page_track_is_active(vcpu->kvm, slot, gfn, + KVM_PAGE_TRACK_PREWRITE) || + kvm_slot_page_track_is_active(vcpu->kvm, slot, gfn, + KVM_PAGE_TRACK_WRITE)) + pte_access &= ~ACC_WRITE_MASK; + WARN_ON_ONCE(!pte_access && !shadow_present_mask); if (sp->role.ad_disabled) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index a2c299d47e69..fd05f42c9913 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -7325,6 +7325,7 @@ static int kvm_write_guest_virt_helper(gva_t addr, void *val, unsigned int bytes r = X86EMUL_IO_NEEDED; goto out; } + kvm_page_track_write(vcpu, gpa, data, towrite); bytes -= towrite; data += towrite; @@ -7441,13 +7442,12 @@ static int vcpu_mmio_gva_to_gpa(struct kvm_vcpu *vcpu, unsigned long gva, int emulator_write_phys(struct kvm_vcpu *vcpu, gpa_t gpa, const void *val, int bytes) { - int ret; - - ret = kvm_vcpu_write_guest(vcpu, gpa, val, bytes); - if (ret < 0) - return 0; + if (!kvm_page_track_prewrite(vcpu, gpa)) + return X86EMUL_PROPAGATE_FAULT; + if (kvm_vcpu_write_guest(vcpu, gpa, val, bytes)) + return X86EMUL_UNHANDLEABLE; kvm_page_track_write(vcpu, gpa, val, bytes); - return 1; + return X86EMUL_CONTINUE; } struct read_write_emulator_ops { @@ -7477,7 +7477,9 @@ static int read_prepare(struct kvm_vcpu *vcpu, void *val, int bytes) static int read_emulate(struct kvm_vcpu *vcpu, gpa_t gpa, void *val, int bytes) { - return !kvm_vcpu_read_guest(vcpu, gpa, val, bytes); + if (kvm_vcpu_read_guest(vcpu, gpa, val, bytes)) + return X86EMUL_UNHANDLEABLE; + return X86EMUL_CONTINUE; } static int write_emulate(struct kvm_vcpu *vcpu, gpa_t gpa, @@ -7551,8 +7553,12 @@ static int emulator_read_write_onepage(unsigned long addr, void *val, return X86EMUL_PROPAGATE_FAULT; } - if (!ret && ops->read_write_emulate(vcpu, gpa, val, bytes)) - return X86EMUL_CONTINUE; + if (!ret) { + ret = ops->read_write_emulate(vcpu, gpa, val, bytes); + if (ret != X86EMUL_UNHANDLEABLE) + /* Handles X86EMUL_CONTINUE and X86EMUL_PROPAGATE_FAULT. */ + return ret; + } /* * Is this MMIO handled locally? @@ -7689,6 +7695,9 @@ static int emulator_cmpxchg_emulated(struct x86_emulate_ctxt *ctxt, if (kvm_is_error_hva(hva)) goto emul_write; + if (!kvm_page_track_prewrite(vcpu, gpa)) + return X86EMUL_PROPAGATE_FAULT; + hva += offset_in_page(gpa); switch (bytes) { -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Fri May 05 15:22:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 15:22:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530419.826025 (Exim 4.92) (envelope-from ) id 1puxGN-0008M8-L5; Fri, 05 May 2023 15:22:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530419.826025; Fri, 05 May 2023 15:22:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puxGN-0008Iz-FC; Fri, 05 May 2023 15:22:27 +0000 Received: by outflank-mailman (input) for mailman id 530419; Fri, 05 May 2023 15:22:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puxFz-0007pX-BI for xen-devel@lists.xenproject.org; Fri, 05 May 2023 15:22:03 +0000 Received: from smtp-8faa.mail.infomaniak.ch (smtp-8faa.mail.infomaniak.ch [2001:1600:4:17::8faa]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9535c569-eb58-11ed-b226-6b7b168915f2; Fri, 05 May 2023 17:22:02 +0200 (CEST) Received: from smtp-3-0001.mail.infomaniak.ch (unknown [10.4.36.108]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4QCZD81Wj3zMqHLq; Fri, 5 May 2023 17:22:00 +0200 (CEST) Received: from unknown by smtp-3-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4QCZD73gl0zMpxBk; Fri, 5 May 2023 17:21:59 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9535c569-eb58-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=digikod.net; s=20191114; t=1683300120; bh=lpToIjkPWA0duCR50VLguq+aftI5CkhRhLIM9+Y09DI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zFJPl8PCpV0TqwQBoPoSGHQX+/8+SSuy0c9K2NPBDqUtmLq0QmGY7FWD3HryhaVm/ 17tCkfTiTGYBupyQ9RSGCsspEYrGNJuhBEUcpQDTrOdzsDu04Esrk+DE1xaHkpmpk1 MM8P5jZUL4ILscFaudbqPEsff1UIBvirPP3WnImg= From: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= To: Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Ingo Molnar , Kees Cook , Paolo Bonzini , Sean Christopherson , Thomas Gleixner , Vitaly Kuznetsov , Wanpeng Li Cc: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= , Alexander Graf , Forrest Yuan Yu , James Morris , John Andersen , Liran Alon , "Madhavan T . Venkataraman" , Marian Rotariu , =?UTF-8?q?Mihai=20Don=C8=9Bu?= , =?UTF-8?q?Nicu=C8=99or=20C=C3=AE=C8=9Bu?= , Rick Edgecombe , Thara Gopinath , Will Deacon , Zahra Tarkhani , =?UTF-8?q?=C8=98tefan=20=C8=98icleru?= , dev@lists.cloudhypervisor.org, kvm@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, x86@kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH v1 3/9] virt: Implement Heki common code Date: Fri, 5 May 2023 17:20:40 +0200 Message-Id: <20230505152046.6575-4-mic@digikod.net> In-Reply-To: <20230505152046.6575-1-mic@digikod.net> References: <20230505152046.6575-1-mic@digikod.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Infomaniak-Routing: alpha From: Madhavan T. Venkataraman Hypervisor Enforced Kernel Integrity (Heki) is a feature that will use the hypervisor to enhance guest virtual machine security. Configuration ============= Define the config variables for the feature. This feature depends on support from the architecture as well as the hypervisor. Enabling HEKI ============= Define a kernel command line parameter "heki" to turn the feature on or off. By default, Heki is on. Feature initialization ====================== The linker script, vmlinux.lds.S, defines a number of sections that are loaded in kernel memory. Each of these sections has its own permissions. For instance, .text has HEKI_ATTR_MEM_EXEC | HEKI_ATTR_MEM_NOWRITE, and .rodata has HEKI_ATTR_MEM_NOWRITE. Define an architecture specific init function, heki_arch_init(). In this function, collect the ranges of all of the sections. These sections will be protected in the host page table with their respective permissions so that even if the guest kernel is compromised, their permissions cannot be changed. Define heki_early_init() to initialize the feature. For now, this function just checks if the feature is enabled and calls heki_arch_init(). Define heki_late_init() that protects the sections in the host page table. This needs hypervisor support which will be introduced in the future. This function is called at the end of kernel init. Cc: Borislav Petkov Cc: Dave Hansen Cc: H. Peter Anvin Cc: Ingo Molnar Cc: Kees Cook Cc: Madhavan T. Venkataraman Cc: Mickaël Salaün Cc: Paolo Bonzini Cc: Sean Christopherson Cc: Thomas Gleixner Cc: Vitaly Kuznetsov Cc: Wanpeng Li Signed-off-by: Madhavan T. Venkataraman Link: https://lore.kernel.org/r/20230505152046.6575-4-mic@digikod.net --- Kconfig | 2 + arch/x86/Kconfig | 1 + arch/x86/include/asm/sections.h | 4 + arch/x86/kernel/setup.c | 49 ++++++++++++ include/linux/heki.h | 90 +++++++++++++++++++++ init/main.c | 3 + virt/Makefile | 1 + virt/heki/Kconfig | 22 ++++++ virt/heki/Makefile | 3 + virt/heki/heki.c | 135 ++++++++++++++++++++++++++++++++ 10 files changed, 310 insertions(+) create mode 100644 include/linux/heki.h create mode 100644 virt/heki/Kconfig create mode 100644 virt/heki/Makefile create mode 100644 virt/heki/heki.c diff --git a/Kconfig b/Kconfig index 745bc773f567..0c844d9bcb03 100644 --- a/Kconfig +++ b/Kconfig @@ -29,4 +29,6 @@ source "lib/Kconfig" source "lib/Kconfig.debug" +source "virt/heki/Kconfig" + source "Documentation/Kconfig" diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 3604074a878b..5cf5a7a97811 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -297,6 +297,7 @@ config X86 select FUNCTION_ALIGNMENT_4B imply IMA_SECURE_AND_OR_TRUSTED_BOOT if EFI select HAVE_DYNAMIC_FTRACE_NO_PATCHABLE + select ARCH_SUPPORTS_HEKI if X86_64 config INSTRUCTION_DECODER def_bool y diff --git a/arch/x86/include/asm/sections.h b/arch/x86/include/asm/sections.h index a6e8373a5170..42ef1e33b8a5 100644 --- a/arch/x86/include/asm/sections.h +++ b/arch/x86/include/asm/sections.h @@ -18,6 +18,10 @@ extern char __end_of_kernel_reserve[]; extern unsigned long _brk_start, _brk_end; +extern int __start_orc_unwind_ip[], __stop_orc_unwind_ip[]; +extern struct orc_entry __start_orc_unwind[], __stop_orc_unwind[]; +extern unsigned int orc_lookup[], orc_lookup_end[]; + static inline bool arch_is_kernel_initmem_freed(unsigned long addr) { /* diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c index 88188549647c..f0ddaf24ab63 100644 --- a/arch/x86/kernel/setup.c +++ b/arch/x86/kernel/setup.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include #include @@ -850,6 +851,54 @@ static void __init x86_report_nx(void) } } +#ifdef CONFIG_HEKI + +/* + * Gather all of the statically defined sections so heki_late_init() can + * protect these sections in the host page table. + * + * The sections are defined under "SECTIONS" in vmlinux.lds.S + * Keep this array in sync with SECTIONS. + */ +struct heki_va_range __initdata heki_va_ranges[] = { + { + .va_start = _stext, + .va_end = _etext, + .attributes = HEKI_ATTR_MEM_NOWRITE | HEKI_ATTR_MEM_EXEC, + }, + { + .va_start = __start_rodata, + .va_end = __end_rodata, + .attributes = HEKI_ATTR_MEM_NOWRITE, + }, +#ifdef CONFIG_UNWINDER_ORC + { + .va_start = __start_orc_unwind_ip, + .va_end = __stop_orc_unwind_ip, + .attributes = HEKI_ATTR_MEM_NOWRITE, + }, + { + .va_start = __start_orc_unwind, + .va_end = __stop_orc_unwind, + .attributes = HEKI_ATTR_MEM_NOWRITE, + }, + { + .va_start = orc_lookup, + .va_end = orc_lookup_end, + .attributes = HEKI_ATTR_MEM_NOWRITE, + }, +#endif /* CONFIG_UNWINDER_ORC */ +}; + +void __init heki_arch_init(void) +{ + heki.num_static_ranges = ARRAY_SIZE(heki_va_ranges); + heki.static_ranges = + heki_alloc_pa_ranges(heki_va_ranges, heki.num_static_ranges); +} + +#endif /* CONFIG_HEKI */ + /* * Determine if we were loaded by an EFI loader. If so, then we have also been * passed the efi memmap, systab, etc., so we should use these data structures diff --git a/include/linux/heki.h b/include/linux/heki.h new file mode 100644 index 000000000000..e4a3192ba687 --- /dev/null +++ b/include/linux/heki.h @@ -0,0 +1,90 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Hypervisor Enforced Kernel Integrity (Heki) - Headers + * + * Copyright © 2023 Microsoft Corporation + */ + +#ifndef __HEKI_H__ +#define __HEKI_H__ + +#ifdef CONFIG_HEKI + +#include + +/* Heki attributes for memory pages. */ +/* clang-format off */ +#define HEKI_ATTR_MEM_NOWRITE (1ULL << 0) +#define HEKI_ATTR_MEM_EXEC (1ULL << 1) +/* clang-format on */ + +/* + * heki_va_range is used to specify a virtual address range within the kernel + * address space along with their attributes. + */ +struct heki_va_range { + void *va_start; + void *va_end; + u64 attributes; +}; + +/* + * heki_pa_range is passed to the VMM or hypervisor so it can be processed by + * the VMM or the hypervisor based on range attributes. Examples of ranges: + * + * - a range whose permissions need to be set in the host page table + * - a range that contains information needed for authentication + * + * When an array of these is passed to the Hypervisor or VMM, the array + * must be in physically contiguous memory. + */ +struct heki_pa_range { + gfn_t gfn_start; + gfn_t gfn_end; + u64 attributes; +}; + +/* + * A hypervisor that supports Heki will instantiate this structure to + * provide hypervisor specific functions for Heki. + */ +struct heki_hypervisor { + int (*protect_ranges)(struct heki_pa_range *ranges, int num_ranges); + int (*lock_crs)(void); +}; + +/* + * If the architecture supports Heki, it will initialize static_ranges in + * early boot. + * + * If the active hypervisor supports Heki, it will plug its heki_hypervisor + * pointer into this heki structure. + */ +struct heki { + struct heki_pa_range *static_ranges; + int num_static_ranges; + struct heki_hypervisor *hypervisor; +}; + +extern struct heki heki; + +void heki_early_init(void); +void heki_arch_init(void); +void heki_late_init(void); + +struct heki_pa_range *heki_alloc_pa_ranges(struct heki_va_range *va_ranges, + int num_ranges); +void heki_free_pa_ranges(struct heki_pa_range *pa_ranges, int num_ranges); + +#else /* !CONFIG_HEKI */ + +static inline void heki_early_init(void) +{ +} +static inline void heki_late_init(void) +{ +} + +#endif /* CONFIG_HEKI */ + +#endif /* __HEKI_H__ */ diff --git a/init/main.c b/init/main.c index e1c3911d7c70..8649dbb07f18 100644 --- a/init/main.c +++ b/init/main.c @@ -102,6 +102,7 @@ #include #include #include +#include #include #include @@ -999,6 +1000,7 @@ asmlinkage __visible void __init __no_sanitize_address start_kernel(void) sort_main_extable(); trap_init(); mm_init(); + heki_early_init(); poking_init(); ftrace_init(); @@ -1530,6 +1532,7 @@ static int __ref kernel_init(void *unused) exit_boot_config(); free_initmem(); mark_readonly(); + heki_late_init(); /* * Kernel mappings are now finalized - update the userspace page-table diff --git a/virt/Makefile b/virt/Makefile index 1cfea9436af9..4550dc624466 100644 --- a/virt/Makefile +++ b/virt/Makefile @@ -1,2 +1,3 @@ # SPDX-License-Identifier: GPL-2.0-only obj-y += lib/ +obj-$(CONFIG_HEKI) += heki/ diff --git a/virt/heki/Kconfig b/virt/heki/Kconfig new file mode 100644 index 000000000000..9858a827fe17 --- /dev/null +++ b/virt/heki/Kconfig @@ -0,0 +1,22 @@ +# SPDX-License-Identifier: GPL-2.0 +# +# Hypervisor Enforced Kernel Integrity (HEKI) +# + +config HEKI + bool "Hypervisor Enforced Kernel Integrity (Heki)" + default y + depends on !JUMP_LABEL && ARCH_SUPPORTS_HEKI + select KVM_EXTERNAL_WRITE_TRACKING if KVM + help + This feature enhances guest virtual machine security by taking + advantage of security features provided by the hypervisor for guests. + This feature is helpful in maintaining guest virtual machine security + even after the guest kernel has been compromised. + +config ARCH_SUPPORTS_HEKI + bool "Architecture support for HEKI" + help + An architecture should select this when it can successfully build + and run with CONFIG_HEKI. That is, it should provide all of the + architecture support required for the HEKI feature. diff --git a/virt/heki/Makefile b/virt/heki/Makefile new file mode 100644 index 000000000000..2bc2061c9dfc --- /dev/null +++ b/virt/heki/Makefile @@ -0,0 +1,3 @@ +# SPDX-License-Identifier: GPL-2.0-only + +obj-y += heki.o diff --git a/virt/heki/heki.c b/virt/heki/heki.c new file mode 100644 index 000000000000..c8cb1b84cceb --- /dev/null +++ b/virt/heki/heki.c @@ -0,0 +1,135 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Hypervisor Enforced Kernel Integrity (Heki) - Common code + * + * Copyright © 2023 Microsoft Corporation + */ + +#include +#include +#include +#include +#include +#include +#include + +#ifdef pr_fmt +#undef pr_fmt +#endif + +#define pr_fmt(fmt) "heki-guest: " fmt + +static bool heki_enabled __ro_after_init = true; + +struct heki heki = {}; + +struct heki_pa_range *heki_alloc_pa_ranges(struct heki_va_range *va_ranges, + int num_ranges) +{ + struct heki_pa_range *pa_ranges, *pa_range; + struct heki_va_range *va_range; + u64 attributes; + size_t size; + int i; + + size = PAGE_ALIGN(sizeof(struct heki_pa_range) * num_ranges); + pa_ranges = alloc_pages_exact(size, GFP_KERNEL); + if (!pa_ranges) + return NULL; + + for (i = 0; i < num_ranges; i++) { + va_range = &va_ranges[i]; + pa_range = &pa_ranges[i]; + + pa_range->gfn_start = PFN_DOWN(__pa_symbol(va_range->va_start)); + pa_range->gfn_end = PFN_UP(__pa_symbol(va_range->va_end)) - 1; + pa_range->attributes = va_range->attributes; + + /* + * WARNING: + * Leaks addresses, should only be kept for development. + */ + attributes = pa_range->attributes; + pr_warn("Configuring GFN 0x%llx-0x%llx with %s\n", + pa_range->gfn_start, pa_range->gfn_end, + (attributes & HEKI_ATTR_MEM_NOWRITE) ? "[nowrite]" : + ""); + } + + return pa_ranges; +} + +void heki_free_pa_ranges(struct heki_pa_range *pa_ranges, int num_ranges) +{ + size_t size; + + size = PAGE_ALIGN(sizeof(struct heki_pa_range) * num_ranges); + free_pages_exact(pa_ranges, size); +} + +void __init heki_early_init(void) +{ + if (!heki_enabled) { + pr_warn("Disabled\n"); + return; + } + pr_warn("Enabled\n"); + + heki_arch_init(); +} + +void heki_late_init(void) +{ + struct heki_hypervisor *hypervisor = heki.hypervisor; + int ret; + + if (!heki_enabled) + return; + + if (!heki.static_ranges) { + pr_warn("Architecture did not initialize static ranges\n"); + return; + } + + /* + * Hypervisor support will be added in the future. When it is, the + * hypervisor will be used to protect guest kernel memory and + * control registers. + */ + + if (!hypervisor) { + /* This happens for kernels running on bare metal as well. */ + pr_warn("No hypervisor support\n"); + goto out; + } + + /* Protects statically defined sections in the host page table. */ + ret = hypervisor->protect_ranges(heki.static_ranges, + heki.num_static_ranges); + if (WARN(ret, "Failed to protect static sections: %d\n", ret)) + goto out; + pr_warn("Static sections protected\n"); + + /* + * Locks control registers so a compromised guest cannot change + * them. + */ + ret = hypervisor->lock_crs(); + if (WARN(ret, "Failed to lock control registers: %d\n", ret)) + goto out; + pr_warn("Control registers locked\n"); + +out: + heki_free_pa_ranges(heki.static_ranges, heki.num_static_ranges); + heki.static_ranges = NULL; + heki.num_static_ranges = 0; +} + +static int __init heki_parse_config(char *str) +{ + if (strtobool(str, &heki_enabled)) + pr_warn("Invalid option string for heki: '%s'\n", str); + return 1; +} + +__setup("heki=", heki_parse_config); -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Fri May 05 15:22:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 15:22:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530421.826032 (Exim 4.92) (envelope-from ) id 1puxGO-0008Ul-3q; Fri, 05 May 2023 15:22:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530421.826032; Fri, 05 May 2023 15:22:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puxGN-0008ST-Qs; Fri, 05 May 2023 15:22:27 +0000 Received: by outflank-mailman (input) for mailman id 530421; Fri, 05 May 2023 15:22:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puxG0-0007pX-Qp for xen-devel@lists.xenproject.org; Fri, 05 May 2023 15:22:04 +0000 Received: from smtp-bc0e.mail.infomaniak.ch (smtp-bc0e.mail.infomaniak.ch [45.157.188.14]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 96cada29-eb58-11ed-b226-6b7b168915f2; Fri, 05 May 2023 17:22:04 +0200 (CEST) Received: from smtp-3-0001.mail.infomaniak.ch (unknown [10.4.36.108]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4QCZDC54NKzMqP0t; Fri, 5 May 2023 17:22:03 +0200 (CEST) Received: from unknown by smtp-3-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4QCZDB71wWzMpt9w; Fri, 5 May 2023 17:22:02 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 96cada29-eb58-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=digikod.net; s=20191114; t=1683300123; bh=DM23zXDS+uuGwMhWqh31C3FvKal04OOOYj6BCpV8eTU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xWSKWq8GRjQntbZQyjyc/hcLfD/4e9Eo9VEQ3TyJ15GAj81rIlqRsji0rYWtV6o9s DjYkgLxPq6tOCUL7E0ENshFSZ0cXEvowTkLwi08Dmqi/WhYCFJPWohunvkPKWdyymr yIWmw5cSKPerfUXYOOtVgs7cuuhvsEWWph9Se7ZE= From: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= To: Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Ingo Molnar , Kees Cook , Paolo Bonzini , Sean Christopherson , Thomas Gleixner , Vitaly Kuznetsov , Wanpeng Li Cc: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= , Alexander Graf , Forrest Yuan Yu , James Morris , John Andersen , Liran Alon , "Madhavan T . Venkataraman" , Marian Rotariu , =?UTF-8?q?Mihai=20Don=C8=9Bu?= , =?UTF-8?q?Nicu=C8=99or=20C=C3=AE=C8=9Bu?= , Rick Edgecombe , Thara Gopinath , Will Deacon , Zahra Tarkhani , =?UTF-8?q?=C8=98tefan=20=C8=98icleru?= , dev@lists.cloudhypervisor.org, kvm@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, x86@kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH v1 6/9] KVM: x86: Add Heki hypervisor support Date: Fri, 5 May 2023 17:20:43 +0200 Message-Id: <20230505152046.6575-7-mic@digikod.net> In-Reply-To: <20230505152046.6575-1-mic@digikod.net> References: <20230505152046.6575-1-mic@digikod.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Infomaniak-Routing: alpha From: Madhavan T. Venkataraman Each supported hypervisor in x86 implements a struct x86_hyper_init to define the init functions for the hypervisor. Define a new init_heki() entry point in struct x86_hyper_init. Hypervisors that support Heki must define this init_heki() function. Call init_heki() of the chosen hypervisor in init_hypervisor_platform(). Create a heki_hypervisor structure that each hypervisor can fill with its data and functions. This will allow the Heki feature to work in a hypervisor agnostic way. Declare and initialize a "heki_hypervisor" structure for KVM so KVM can support Heki. Define the init_heki() function for KVM. In init_heki(), set the hypervisor field in the generic "heki" structure to the KVM "heki_hypervisor". After this point, generic Heki code can access the KVM Heki data and functions. Cc: Borislav Petkov Cc: Dave Hansen Cc: H. Peter Anvin Cc: Ingo Molnar Cc: Kees Cook Cc: Paolo Bonzini Cc: Sean Christopherson Cc: Thomas Gleixner Cc: Vitaly Kuznetsov Cc: Wanpeng Li Co-developed-by: Mickaël Salaün Signed-off-by: Mickaël Salaün Signed-off-by: Madhavan T. Venkataraman Link: https://lore.kernel.org/r/20230505152046.6575-7-mic@digikod.net --- arch/x86/include/asm/x86_init.h | 2 + arch/x86/kernel/cpu/hypervisor.c | 1 + arch/x86/kernel/kvm.c | 72 ++++++++++++++++++++++++++++++++ arch/x86/kernel/x86_init.c | 1 + arch/x86/kvm/Kconfig | 1 + virt/heki/Kconfig | 9 +++- virt/heki/heki.c | 6 --- 7 files changed, 85 insertions(+), 7 deletions(-) diff --git a/arch/x86/include/asm/x86_init.h b/arch/x86/include/asm/x86_init.h index c1c8c581759d..0fc5041a66c6 100644 --- a/arch/x86/include/asm/x86_init.h +++ b/arch/x86/include/asm/x86_init.h @@ -119,6 +119,7 @@ struct x86_init_pci { * @msi_ext_dest_id: MSI supports 15-bit APIC IDs * @init_mem_mapping: setup early mappings during init_mem_mapping() * @init_after_bootmem: guest init after boot allocator is finished + * @init_heki: Hypervisor enforced kernel integrity */ struct x86_hyper_init { void (*init_platform)(void); @@ -127,6 +128,7 @@ struct x86_hyper_init { bool (*msi_ext_dest_id)(void); void (*init_mem_mapping)(void); void (*init_after_bootmem)(void); + void (*init_heki)(void); }; /** diff --git a/arch/x86/kernel/cpu/hypervisor.c b/arch/x86/kernel/cpu/hypervisor.c index 553bfbfc3a1b..6085c8129e0c 100644 --- a/arch/x86/kernel/cpu/hypervisor.c +++ b/arch/x86/kernel/cpu/hypervisor.c @@ -106,4 +106,5 @@ void __init init_hypervisor_platform(void) x86_hyper_type = h->type; x86_init.hyper.init_platform(); + x86_init.hyper.init_heki(); } diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c index 1cceac5984da..e53cebdcf3ac 100644 --- a/arch/x86/kernel/kvm.c +++ b/arch/x86/kernel/kvm.c @@ -29,6 +29,7 @@ #include #include #include +#include #include #include #include @@ -866,6 +867,45 @@ static void __init kvm_guest_init(void) hardlockup_detector_disable(); } +#ifdef CONFIG_HEKI + +static int kvm_protect_ranges(struct heki_pa_range *ranges, int num_ranges) +{ + size_t size; + long err; + + WARN_ON(in_interrupt()); + + size = sizeof(ranges[0]) * num_ranges; + err = kvm_hypercall3(KVM_HC_LOCK_MEM_PAGE_RANGES, __pa(ranges), size, 0); + if (WARN(err, "Failed to enforce memory protection: %ld\n", err)) + return err; + + return 0; +} + +extern unsigned long cr4_pinned_mask; + +/* + * TODO: Check SMP policy consistency, e.g. with + * this_cpu_read(cpu_tlbstate.cr4) + */ +static int kvm_lock_crs(void) +{ + unsigned long cr4; + int err; + + err = kvm_hypercall2(KVM_HC_LOCK_CR_UPDATE, 0, X86_CR0_WP); + if (err) + return err; + + cr4 = __read_cr4(); + err = kvm_hypercall2(KVM_HC_LOCK_CR_UPDATE, 4, cr4 & cr4_pinned_mask); + return err; +} + +#endif /* CONFIG_HEKI */ + static noinline uint32_t __kvm_cpuid_base(void) { if (boot_cpu_data.cpuid_level < 0) @@ -999,6 +1039,37 @@ static bool kvm_sev_es_hcall_finish(struct ghcb *ghcb, struct pt_regs *regs) } #endif +#ifdef CONFIG_HEKI + +static struct heki_hypervisor kvm_heki_hypervisor = { + .protect_ranges = kvm_protect_ranges, + .lock_crs = kvm_lock_crs, +}; + +static void kvm_init_heki(void) +{ + long err; + + if (!kvm_para_available()) + /* Cannot make KVM hypercalls. */ + return; + + err = kvm_hypercall3(KVM_HC_LOCK_MEM_PAGE_RANGES, -1, -1, -1); + if (err == -KVM_ENOSYS) + /* Ignores host. */ + return; + + heki.hypervisor = &kvm_heki_hypervisor; +} + +#else /* CONFIG_HEKI */ + +static void kvm_init_heki(void) +{ +} + +#endif /* CONFIG_HEKI */ + const __initconst struct hypervisor_x86 x86_hyper_kvm = { .name = "KVM", .detect = kvm_detect, @@ -1007,6 +1078,7 @@ const __initconst struct hypervisor_x86 x86_hyper_kvm = { .init.x2apic_available = kvm_para_available, .init.msi_ext_dest_id = kvm_msi_ext_dest_id, .init.init_platform = kvm_init_platform, + .init.init_heki = kvm_init_heki, #if defined(CONFIG_AMD_MEM_ENCRYPT) .runtime.sev_es_hcall_prepare = kvm_sev_es_hcall_prepare, .runtime.sev_es_hcall_finish = kvm_sev_es_hcall_finish, diff --git a/arch/x86/kernel/x86_init.c b/arch/x86/kernel/x86_init.c index ef80d361b463..0a023c24fcdb 100644 --- a/arch/x86/kernel/x86_init.c +++ b/arch/x86/kernel/x86_init.c @@ -114,6 +114,7 @@ struct x86_init_ops x86_init __initdata = { .msi_ext_dest_id = bool_x86_init_noop, .init_mem_mapping = x86_init_noop, .init_after_bootmem = x86_init_noop, + .init_heki = x86_init_noop, }, .acpi = { diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig index fbeaa9ddef59..ba355171ceeb 100644 --- a/arch/x86/kvm/Kconfig +++ b/arch/x86/kvm/Kconfig @@ -49,6 +49,7 @@ config KVM select SRCU select INTERVAL_TREE select HAVE_KVM_PM_NOTIFIER if PM + select HYPERVISOR_SUPPORTS_HEKI help Support hosting fully virtualized guest machines using hardware virtualization extensions. You will need a fairly recent diff --git a/virt/heki/Kconfig b/virt/heki/Kconfig index 9858a827fe17..96f18ce03013 100644 --- a/virt/heki/Kconfig +++ b/virt/heki/Kconfig @@ -6,7 +6,7 @@ config HEKI bool "Hypervisor Enforced Kernel Integrity (Heki)" default y - depends on !JUMP_LABEL && ARCH_SUPPORTS_HEKI + depends on !JUMP_LABEL && ARCH_SUPPORTS_HEKI && HYPERVISOR_SUPPORTS_HEKI select KVM_EXTERNAL_WRITE_TRACKING if KVM help This feature enhances guest virtual machine security by taking @@ -20,3 +20,10 @@ config ARCH_SUPPORTS_HEKI An architecture should select this when it can successfully build and run with CONFIG_HEKI. That is, it should provide all of the architecture support required for the HEKI feature. + +config HYPERVISOR_SUPPORTS_HEKI + bool "Hypervisor support for Heki" + help + A hypervisor should select this when it can successfully build + and run with CONFIG_HEKI. That is, it should provide all of the + hypervisor support required for the Heki feature. diff --git a/virt/heki/heki.c b/virt/heki/heki.c index c8cb1b84cceb..142b5dc98a2f 100644 --- a/virt/heki/heki.c +++ b/virt/heki/heki.c @@ -91,12 +91,6 @@ void heki_late_init(void) return; } - /* - * Hypervisor support will be added in the future. When it is, the - * hypervisor will be used to protect guest kernel memory and - * control registers. - */ - if (!hypervisor) { /* This happens for kernels running on bare metal as well. */ pr_warn("No hypervisor support\n"); -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Fri May 05 15:22:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 15:22:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530412.826000 (Exim 4.92) (envelope-from ) id 1puxGM-0007vS-B0; Fri, 05 May 2023 15:22:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530412.826000; Fri, 05 May 2023 15:22:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puxGM-0007vL-7z; Fri, 05 May 2023 15:22:26 +0000 Received: by outflank-mailman (input) for mailman id 530412; Fri, 05 May 2023 15:21:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puxFu-0007pR-Nd for xen-devel@lists.xenproject.org; Fri, 05 May 2023 15:21:59 +0000 Received: from smtp-42af.mail.infomaniak.ch (smtp-42af.mail.infomaniak.ch [84.16.66.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 91b3a163-eb58-11ed-8611-37d641c3527e; Fri, 05 May 2023 17:21:55 +0200 (CEST) Received: from smtp-2-0000.mail.infomaniak.ch (unknown [10.5.36.107]) by smtp-2-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4QCZD24pG9zMqLbT; Fri, 5 May 2023 17:21:54 +0200 (CEST) Received: from unknown by smtp-2-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4QCZCy4M9gzMpqZ9; Fri, 5 May 2023 17:21:50 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 91b3a163-eb58-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=digikod.net; s=20191114; t=1683300114; bh=Qvc7SESfj28DhibUMOxF8XDC2Dv9Nk03svVhSexGCDo=; h=From:To:Cc:Subject:Date:From; b=sdjSaTf+L8uD2OtYxlVlBp2/RF9APLo7BFa1o6O4wpLqtYohS60n6C+Xb7KWY8oWN 1ThaIncVJDSPEINsOmIciOHlJQ5lHfvGTzMJwRq9cC3H70enX0j5qGVkDZEv5T8RHU X7DMszBWczedvVBKFSwCEr6PDfJcgmy7Hfrc8dOE= From: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= To: Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Ingo Molnar , Kees Cook , Paolo Bonzini , Sean Christopherson , Thomas Gleixner , Vitaly Kuznetsov , Wanpeng Li Cc: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= , Alexander Graf , Forrest Yuan Yu , James Morris , John Andersen , Liran Alon , "Madhavan T . Venkataraman" , Marian Rotariu , =?UTF-8?q?Mihai=20Don=C8=9Bu?= , =?UTF-8?q?Nicu=C8=99or=20C=C3=AE=C8=9Bu?= , Rick Edgecombe , Thara Gopinath , Will Deacon , Zahra Tarkhani , =?UTF-8?q?=C8=98tefan=20=C8=98icleru?= , dev@lists.cloudhypervisor.org, kvm@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, x86@kernel.org, xen-devel@lists.xenproject.org Subject: [RFC PATCH v1 0/9] Hypervisor-Enforced Kernel Integrity Date: Fri, 5 May 2023 17:20:37 +0200 Message-Id: <20230505152046.6575-1-mic@digikod.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Infomaniak-Routing: alpha Hi, This patch series is a proof-of-concept that implements new KVM features (extended page tracking, MBEC support, CR pinning) and defines a new API to protect guest VMs. No VMM (e.g., Qemu) modification is required. The main idea being that kernel self-protection mechanisms should be delegated to a more privileged part of the system, hence the hypervisor. It is still the role of the guest kernel to request such restrictions according to its configuration. The high-level security guarantees provided by the hypervisor are semantically the same as a subset of those the kernel already enforces on itself (CR pinning hardening and memory page table protections), but with much higher guarantees. We'd like the mainline kernel to support such hardening features leveraging virtualization. We're looking for reviews and comments that can help mainline these two parts: the KVM implementation and the guest kernel API layer designed to support different hypervisors. The struct heki_hypervisor enables to plug in different backend implementations that are initialized with the heki_early_init() and heki_late_init() calls. This RFC is an initial call for collaboration. There is a lot to do, either on hypervisors, guest kernels or VMMs sides. We took inspiration from previous patches, mainly the KVMI [1] [2] and KVM CR-pinning [3] series, revamped and simplified relevant parts to fit well with our goal, added support for MBEC to enable a deny-by-default kernel execution policy (e.g., write xor execute), added two hypercalls, and created a kernel API for VMs to request protection in a generic way that can be leveraged by any hypervisor. This proof-of-concept is named Hypervisor-Enforced Kernel Integrity (Heki), which reflects the goal to empower guest kernels to protect themselves. This name is new to the kernel, and it enables to easily identify new code required for this set of features. This patch series is based on Linux 6.2 and requires the host to support MBEC. This can easily be checked with: grep ept_mode_based_exec /proc/cpuinfo You can test it by enabling CONFIG_HEKI, CONFIG_HEKI_TEST, CONFIG_KUNIT_DEFAULT_ENABLED, and adding the heki_test=N boot argument to the guest as explained in the last patch. Another way to test it is to try to load a kernel module in the guest: you'll see KVM creating synthetic page faults. This only works using a bare metal machine as KVM host; nested virtualization is not supported yet. # Threat model The initial threat model is a malicious user space process exploiting a kernel vulnerability to gain more privileges or to bypass the access-control system. An extended threat model could include attacks coming from network or storage data (e.g., malformed network packet, inconsistent drive content). Considering all potential ways to compromise a kernel, Heki's goal is to harden a sane kernel before a runtime attack to make it more difficult, and potentially to make such an attack failed. We consider the kernel itself to be partially malicious during its lifetime e.g., because a ROP attack that could disable kernel self-protection mechanisms and make kernel exploitation much easier. Indeed, an exploit is often split into several stages, each bypassing some security measures. Getting the guarantee that new kernel executable code is not possible increases the cost of an attack, hopefully to the point that it is not worth it. To protect against persistent attacks, complementary security mechanisms should be used (e.g., kernel module signing, IMA, IPE, Lockdown). # Prerequisites For this set of features to be useful, guest kernels must be trusted by the VM owners at boot time, before launching any user space processes nor receiving potentially malicious network packets. It is then required to have a security mechanism to provide or check this initial trust (e.g., secure boot, kernel module signing). # How does it work? This implementation mainly leverages KVM capabilities to control the Second Layer Address Translation (or the Two Dimensional Paging e.g., Intel's EPT or AMD's RVI/NPT) and Mode Based Execution Control (Intel's MBEC) introduced with the Kaby Lake (7th generation) architecture. This allows to set permissions on memory pages in a complementary way to the guest kernel's managed memory permissions. Once these permissions are set, they are locked and there is no way back. A first KVM_HC_LOCK_MEM_PAGE_RANGES hypercall enables the guest kernel to lock a set of its memory page ranges with either the HEKI_ATTR_MEM_NOWRITE or the HEKI_ATTR_MEM_EXEC attribute. The first one denies write access to a specific set of pages (allow-list approach), and the second only allows kernel execution for a set of pages (deny-list approach). The current implementation sets the whole kernel's .rodata (i.e., any const or __ro_after_init variables, which includes critical security data such as LSM parameters) and .text sections as non-writable, and the .text section is the only one where kernel execution is allowed. This is possible thanks to the new MBEC support also brough by this series (otherwise the vDSO would have to be executable). Thanks to this hardware support (VT-x, EPT and MBEC), the performance impact of such guest protection is negligible. The second KVM_HC_LOCK_CR_UPDATE hypercall enables guests to pin some of its CPU control register flags (e.g., X86_CR0_WP, X86_CR4_SMEP, X86_CR4_SMAP), which is another complementary hardening mechanism. Heki can be enabled with the heki=1 boot command argument. # Similar implementations Here is a non-exhaustive list of similar implementations that we looked at and took some ideas. Linux mainline doesn't support such security features, let's change that! Windows's Virtualization-Based Security is a proprietary technology relying that provides a superset of this kind of security mechanism, relying on Hyper-V and Virtual Trust Levels which enables to have light and secure VM enforcing restrictions on a full guest VM. This includes several components such as HVCI which is in charge of code authenticity, or HyperGuard which monitors and protects kernel code and data. Samsung's Real-time Kernel Protection (RKP) and Huawei Hypervisor Execution Environment (HHEE) rely on proprietary hypervisors to protect some Android devices. They monitor critical kernel data (e.g., page tables, credentials, selinux_enforcing). The iOS Kernel Patch Protection is a proprietary solution that relies on a secure enclave (dedicated hardware component) to monitor and protect critical parts of the kernel. Bitdefender's Hypervisor Memory Introspection (HVMI) is an open-source (but out of tree) set of components leveraging virtualization. HVMI implementation is very complex, and this approach implies potential semantic gap issues (i.e., kernel data structures may change from one version to another). Linux Kernel Runtime Guard is an open-source kernel module that can detect some kernel data illegitimate modifications. Because it is the same kernel as the compromised one, an attacker could also bypass or disable these checks. Intel's Virtualization Based Hardening [4] [5] is an open-source proof-of-concept of a thin hypervisor dedicated to guest protection. As such, it cannot be used to manage several VMs. # Similar Linux patches The VM introspection [1] [2] patch series proposed a set of features to put probes and introspect VMs for debugging and security reasons. We changed and included the prewrite page tracking and the fault_gva parts. Heki is much simpler because it focuses on guest hardening, not introspection. Paravirtualized Control Register pinning [3] added a set of KVM IOCTLs to restrict some flags to be set. Heki doesn't implement such user space interface, but only a dedicated hypercall to lock such registers. A superset of these flags is configurable with Heki. The Hypervisor Based Integrity patches [6] [7] only contain a generic IPC mechanism (KVM_HC_UCALL hypercall) to request protection to the VMM. The idea was to extend the KVM_SET_USER_MEMORY_REGION IOCTL to support more permission than read-only. # Current limitations The main limitation of this patch series is the statically enforced permissions. This is not an issue for kernels without module but this needs to be addressed. Mechanisms that dynamically impact kernel executable memory are not handled for now (e.g., kernel modules, tracepoints, eBPF JIT), and such code will need to be authenticated. Because the hypervisor is highly privileged and critical to the security of all the VMs, we don't want to implement a code authentication mechanism in the hypervisor itself but delegate this verification to something much less privileged. We are thinking of two ways to solve this: implement this verification in the VMM or spawn a dedicated special VM (similar to Windows's VBS). There are pros on cons to each approach: complexity, verification code ownership (guest's or VMM's), access to guest memory (i.e., confidential computing). Because the guest's virtual address translation is not protected by the hypervisor, a compromised kernel could map existing physical pages into arbitrary virtual addresses. The new Intel's Hypervisor-Managed Linear Address Translation [8] (HLAT) could be used to extend the current protection and cover this case. ROP is not covered by this patch series. Guest kernels can still jump to arbitrary executable pages according to their control-flow integrity protection. # Future work We think this kind of restrictions can be leveraged to log attempts of forbidden actions. Forwarding such signals to the VMM could help improve attack detection. Giving visibility to the VMM would also enable to migrate VMs. New dynamic restrictions could enable to improve the protected data by including security-sensitive data such as LSM states, seccomp filters, keyrings... This requires support outside of the hypervisor. An execute-only mode could also be useful (cf. XOM for KVM [9] [10]). Extending register pinning (e.g., MSRs). Being able to protect nested guests might be possible but we need to figure out the potential security implications. Protecting the host would be useful, but that doesn't really fit with the KVM model. The Protected KVM project is a first step to help in this direction [11]. We only tested this with an Intel CPU, but this approach should work the same with an AMD CPU starting with the Zen 2 generation and their Guest Mode Execute Trap (GMET) capability. We also kept some TODOs to highlight missing checks and code sharing issues, and some pr_warn() calls to help understand how it works. Tests need to be improved (e.g., invalid hypercall arguments). We'll present this work at the Linux Security Summit North America next week. [1] https://lore.kernel.org/all/20211006173113.26445-1-alazar@bitdefender.com/ [2] https://www.linux-kvm.org/images/7/72/KVMForum2017_Introspection.pdf [3] https://lore.kernel.org/all/20200617190757.27081-1-john.s.andersen@intel.com/ [4] https://github.com/intel/vbh [5] https://sched.co/TmwN [6] https://sched.co/eE3f [7] https://lore.kernel.org/all/20200501185147.208192-1-yuanyu@google.com/ [8] https://sched.co/eE4F [9] https://lore.kernel.org/kvm/20191003212400.31130-1-rick.p.edgecombe@intel.com/ [10] https://lpc.events/event/4/contributions/283/ [11] https://sched.co/eE24 Please reach out to us by replying to this thread, we're looking for people to join and collaborate on this project! Regards, Madhavan T. Venkataraman (2): virt: Implement Heki common code KVM: x86: Add Heki hypervisor support Mickaël Salaün (7): KVM: x86: Add kvm_x86_ops.fault_gva() KVM: x86/mmu: Add support for prewrite page tracking KVM: x86: Add new hypercall to set EPT permissions KVM: x86: Add new hypercall to lock control registers KVM: VMX: Add MBEC support KVM: x86/mmu: Enable guests to lock themselves thanks to MBEC virt: Add Heki KUnit tests Documentation/virt/kvm/x86/hypercalls.rst | 34 +++ Kconfig | 2 + arch/x86/Kconfig | 1 + arch/x86/include/asm/kvm-x86-ops.h | 1 + arch/x86/include/asm/kvm_host.h | 2 + arch/x86/include/asm/kvm_page_track.h | 12 + arch/x86/include/asm/sections.h | 4 + arch/x86/include/asm/vmx.h | 11 +- arch/x86/include/asm/x86_init.h | 2 + arch/x86/kernel/cpu/common.c | 2 +- arch/x86/kernel/cpu/hypervisor.c | 1 + arch/x86/kernel/kvm.c | 72 +++++ arch/x86/kernel/setup.c | 49 +++ arch/x86/kernel/x86_init.c | 1 + arch/x86/kvm/Kconfig | 1 + arch/x86/kvm/mmu.h | 3 +- arch/x86/kvm/mmu/mmu.c | 105 ++++++- arch/x86/kvm/mmu/mmutrace.h | 11 +- arch/x86/kvm/mmu/page_track.c | 33 +- arch/x86/kvm/mmu/paging_tmpl.h | 16 +- arch/x86/kvm/mmu/spte.c | 29 +- arch/x86/kvm/mmu/spte.h | 15 +- arch/x86/kvm/mmu/tdp_mmu.c | 73 +++++ arch/x86/kvm/mmu/tdp_mmu.h | 4 + arch/x86/kvm/svm/svm.c | 9 + arch/x86/kvm/vmx/capabilities.h | 7 + arch/x86/kvm/vmx/nested.c | 7 + arch/x86/kvm/vmx/vmx.c | 48 ++- arch/x86/kvm/vmx/vmx.h | 1 + arch/x86/kvm/x86.c | 352 +++++++++++++++++++++- arch/x86/kvm/x86.h | 23 ++ include/linux/heki.h | 90 ++++++ include/linux/kvm_host.h | 20 ++ include/uapi/linux/kvm_para.h | 2 + init/main.c | 3 + virt/Makefile | 1 + virt/heki/Kconfig | 41 +++ virt/heki/Makefile | 3 + virt/heki/heki.c | 321 ++++++++++++++++++++ virt/kvm/kvm_main.c | 5 + 40 files changed, 1377 insertions(+), 40 deletions(-) create mode 100644 include/linux/heki.h create mode 100644 virt/heki/Kconfig create mode 100644 virt/heki/Makefile create mode 100644 virt/heki/heki.c base-commit: c9c3395d5e3dcc6daee66c6908354d47bf98cb0c -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Fri May 05 15:22:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 15:22:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530417.826019 (Exim 4.92) (envelope-from ) id 1puxGN-0008FC-BA; Fri, 05 May 2023 15:22:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530417.826019; Fri, 05 May 2023 15:22:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puxGN-0008Cp-4Z; Fri, 05 May 2023 15:22:27 +0000 Received: by outflank-mailman (input) for mailman id 530417; Fri, 05 May 2023 15:22:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puxFy-0007pX-KZ for xen-devel@lists.xenproject.org; Fri, 05 May 2023 15:22:02 +0000 Received: from smtp-190e.mail.infomaniak.ch (smtp-190e.mail.infomaniak.ch [185.125.25.14]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9572491b-eb58-11ed-b226-6b7b168915f2; Fri, 05 May 2023 17:22:01 +0200 (CEST) Received: from smtp-3-0001.mail.infomaniak.ch (unknown [10.4.36.108]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4QCZD938BPzMq1NC; Fri, 5 May 2023 17:22:01 +0200 (CEST) Received: from unknown by smtp-3-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4QCZD85V0tzMpt9P; Fri, 5 May 2023 17:22:00 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9572491b-eb58-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=digikod.net; s=20191114; t=1683300121; bh=dkHjbqpuvSBmD/ZCnBFFFKsFtN1g9PxpijWtwL2weO4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FR+pYomIgtrTj0WI3JRDUSbHVrdlibfnwQU30RKu6bstMqwIWNnbYH/f3efnA/++Y PVW9ePmH83Lzuo5sF3eA8Zxiu6x5s8zasun6j41FzXtbI7LfAbR7ieVBarIcdhpBG1 xrxpuSnVobX97umCLQuu/zofOq0RUrhcLMOWIHuk= From: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= To: Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Ingo Molnar , Kees Cook , Paolo Bonzini , Sean Christopherson , Thomas Gleixner , Vitaly Kuznetsov , Wanpeng Li Cc: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= , Alexander Graf , Forrest Yuan Yu , James Morris , John Andersen , Liran Alon , "Madhavan T . Venkataraman" , Marian Rotariu , =?UTF-8?q?Mihai=20Don=C8=9Bu?= , =?UTF-8?q?Nicu=C8=99or=20C=C3=AE=C8=9Bu?= , Rick Edgecombe , Thara Gopinath , Will Deacon , Zahra Tarkhani , =?UTF-8?q?=C8=98tefan=20=C8=98icleru?= , dev@lists.cloudhypervisor.org, kvm@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, x86@kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH v1 4/9] KVM: x86: Add new hypercall to set EPT permissions Date: Fri, 5 May 2023 17:20:41 +0200 Message-Id: <20230505152046.6575-5-mic@digikod.net> In-Reply-To: <20230505152046.6575-1-mic@digikod.net> References: <20230505152046.6575-1-mic@digikod.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Infomaniak-Routing: alpha Add a new KVM_HC_LOCK_MEM_PAGE_RANGES hypercall that enables a guest to set EPT permissions on a set of page ranges. This hypercall takes three arguments. The first contains the GPA pointing to an array of struct heki_pa_range. The second argument is the size of the array, not the number of elements. The third argument is for future proofness and is designed to contains optional flags (e.g. to change the array type), but must be zero for now. The struct heki_pa_range contains a GFN that starts the range and another that is the indicate the last (included) page. A bit field of attributes are tied to this range. The HEKI_ATTR_MEM_NOWRITE attribute is interpreted as a removal of the EPT write permission to deny any write access from the guest through its lifetime. We choose "nowrite" because "read-only" exclude execution, it follows a deny-list approach, and most importantly because it is an incremental addition to the status quo (i.e., everything is allowed from the TDP point of view). This is implemented thanks to the KVM_PAGE_TRACK_PREWRITE mode previously introduced. The page ranges recording is currently implemented with a static array of 16 elements to make it simple, but this mechanism will be dynamic in a follow-up. Define a kernel command line parameter "heki" to turn the feature on or off. By default, Heki is turned on. Cc: Borislav Petkov Cc: Dave Hansen Cc: H. Peter Anvin Cc: Ingo Molnar Cc: Kees Cook Cc: Madhavan T. Venkataraman Cc: Paolo Bonzini Cc: Sean Christopherson Cc: Thomas Gleixner Cc: Vitaly Kuznetsov Cc: Wanpeng Li Signed-off-by: Mickaël Salaün Link: https://lore.kernel.org/r/20230505152046.6575-5-mic@digikod.net --- Documentation/virt/kvm/x86/hypercalls.rst | 17 +++ arch/x86/kvm/x86.c | 169 ++++++++++++++++++++++ include/linux/kvm_host.h | 13 ++ include/uapi/linux/kvm_para.h | 1 + virt/kvm/kvm_main.c | 4 + 5 files changed, 204 insertions(+) diff --git a/Documentation/virt/kvm/x86/hypercalls.rst b/Documentation/virt/kvm/x86/hypercalls.rst index 10db7924720f..0ec79cc77f53 100644 --- a/Documentation/virt/kvm/x86/hypercalls.rst +++ b/Documentation/virt/kvm/x86/hypercalls.rst @@ -190,3 +190,20 @@ the KVM_CAP_EXIT_HYPERCALL capability. Userspace must enable that capability before advertising KVM_FEATURE_HC_MAP_GPA_RANGE in the guest CPUID. In addition, if the guest supports KVM_FEATURE_MIGRATION_CONTROL, userspace must also set up an MSR filter to process writes to MSR_KVM_MIGRATION_CONTROL. + +9. KVM_HC_LOCK_MEM_PAGE_RANGES +------------------------------ + +:Architecture: x86 +:Status: active +:Purpose: Request memory page ranges to be restricted. + +- a0: physical address of a struct heki_pa_range array +- a1: size of the array +- a2: optional flags, must be 0 for now + +The hypercall lets a guest request memory permissions to be removed for itself, +identified with set of physical page ranges (GFNs). The HEKI_ATTR_MEM_NOWRITE +memory page range attribute forbids related modification to the guest. + +Returns 0 on success or a KVM error code otherwise. diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index fd05f42c9913..ffab64d08de3 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -59,6 +59,7 @@ #include #include #include +#include #include @@ -9596,6 +9597,161 @@ static void kvm_sched_yield(struct kvm_vcpu *vcpu, unsigned long dest_id) return; } +#ifdef CONFIG_HEKI + +static int heki_page_track_add(struct kvm *const kvm, const gfn_t gfn, + const enum kvm_page_track_mode mode) +{ + struct kvm_memory_slot *slot; + int idx; + + BUILD_BUG_ON(!IS_ENABLED(CONFIG_KVM_EXTERNAL_WRITE_TRACKING)); + + idx = srcu_read_lock(&kvm->srcu); + slot = gfn_to_memslot(kvm, gfn); + if (!slot) { + srcu_read_unlock(&kvm->srcu, idx); + return -EINVAL; + } + + write_lock(&kvm->mmu_lock); + kvm_slot_page_track_add_page(kvm, slot, gfn, mode); + write_unlock(&kvm->mmu_lock); + srcu_read_unlock(&kvm->srcu, idx); + return 0; +} + +static bool +heki_page_track_prewrite(struct kvm_vcpu *const vcpu, const gpa_t gpa, + struct kvm_page_track_notifier_node *const node) +{ + const gfn_t gfn = gpa_to_gfn(gpa); + const struct kvm *const kvm = vcpu->kvm; + size_t i; + + /* Checks if it is our own tracked pages, or those of someone else. */ + for (i = 0; i < HEKI_GFN_MAX; i++) { + if (gfn >= kvm->heki_gfn_no_write[i].start && + gfn <= kvm->heki_gfn_no_write[i].end) + return false; + } + + return true; +} + +static int kvm_heki_init_vm(struct kvm *const kvm) +{ + struct kvm_page_track_notifier_node *const node = + kzalloc(sizeof(*node), GFP_KERNEL); + + if (!node) + return -ENOMEM; + + node->track_prewrite = heki_page_track_prewrite; + kvm_page_track_register_notifier(kvm, node); + return 0; +} + +static bool is_gfn_overflow(unsigned long val) +{ + const gfn_t gfn_mask = gpa_to_gfn(~0); + + return (val | gfn_mask) != gfn_mask; +} + +#define HEKI_PA_RANGE_MAX_SIZE (sizeof(struct heki_pa_range) * HEKI_GFN_MAX) + +static int heki_lock_mem_page_ranges(struct kvm *const kvm, gpa_t mem_ranges, + unsigned long mem_ranges_size) +{ + int err; + size_t i, ranges_num; + struct heki_pa_range *ranges; + + if (mem_ranges_size > HEKI_PA_RANGE_MAX_SIZE) + return -KVM_E2BIG; + + if ((mem_ranges_size % sizeof(struct heki_pa_range)) != 0) + return -KVM_EINVAL; + + ranges = kzalloc(mem_ranges_size, GFP_KERNEL); + if (!ranges) + return -KVM_E2BIG; + + err = kvm_read_guest(kvm, mem_ranges, ranges, mem_ranges_size); + if (err) { + err = -KVM_EFAULT; + goto out_free_ranges; + } + + ranges_num = mem_ranges_size / sizeof(struct heki_pa_range); + for (i = 0; i < ranges_num; i++) { + const u64 attributes_mask = HEKI_ATTR_MEM_NOWRITE; + const gfn_t gfn_start = ranges[i].gfn_start; + const gfn_t gfn_end = ranges[i].gfn_end; + const u64 attributes = ranges[i].attributes; + + if (is_gfn_overflow(ranges[i].gfn_start)) { + err = -KVM_EINVAL; + goto out_free_ranges; + } + if (is_gfn_overflow(ranges[i].gfn_end)) { + err = -KVM_EINVAL; + goto out_free_ranges; + } + if (ranges[i].gfn_start > ranges[i].gfn_end) { + err = -KVM_EINVAL; + goto out_free_ranges; + } + if (!ranges[i].attributes) { + err = -KVM_EINVAL; + goto out_free_ranges; + } + if ((ranges[i].attributes | attributes_mask) != + attributes_mask) { + err = -KVM_EINVAL; + goto out_free_ranges; + } + + if (attributes & HEKI_ATTR_MEM_NOWRITE) { + unsigned long gfn; + size_t gfn_i; + + gfn_i = atomic_dec_if_positive( + &kvm->heki_gfn_no_write_num); + if (gfn_i == 0) { + err = -KVM_E2BIG; + goto out_free_ranges; + } + + gfn_i--; + kvm->heki_gfn_no_write[gfn_i].start = gfn_start; + kvm->heki_gfn_no_write[gfn_i].end = gfn_end; + + for (gfn = gfn_start; gfn <= gfn_end; gfn++) + WARN_ON_ONCE(heki_page_track_add( + kvm, gfn, KVM_PAGE_TRACK_PREWRITE)); + } + + pr_warn("heki-kvm: Locking GFN 0x%llx-0x%llx with %s\n", + gfn_start, gfn_end, + (attributes & HEKI_ATTR_MEM_NOWRITE) ? "[nowrite]" : ""); + } + +out_free_ranges: + kfree(ranges); + return err; +} + +#else /* CONFIG_HEKI */ + +static int kvm_heki_init_vm(struct kvm *const kvm) +{ + return 0; +} + +#endif /* CONFIG_HEKI */ + static int complete_hypercall_exit(struct kvm_vcpu *vcpu) { u64 ret = vcpu->run->hypercall.ret; @@ -9694,6 +9850,15 @@ int kvm_emulate_hypercall(struct kvm_vcpu *vcpu) vcpu->arch.complete_userspace_io = complete_hypercall_exit; return 0; } +#ifdef CONFIG_HEKI + case KVM_HC_LOCK_MEM_PAGE_RANGES: + /* No flags for now. */ + if (a2) + ret = -KVM_EINVAL; + else + ret = heki_lock_mem_page_ranges(vcpu->kvm, a0, a1); + break; +#endif /* CONFIG_HEKI */ default: ret = -KVM_ENOSYS; break; @@ -12126,6 +12291,10 @@ int kvm_arch_init_vm(struct kvm *kvm, unsigned long type) if (ret) goto out_page_track; + ret = kvm_heki_init_vm(kvm); + if (ret) + goto out_page_track; + ret = static_call(kvm_x86_vm_init)(kvm); if (ret) goto out_uninit_mmu; diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h index 4f26b244f6d0..39a1bdc2ba42 100644 --- a/include/linux/kvm_host.h +++ b/include/linux/kvm_host.h @@ -699,6 +699,13 @@ struct kvm_memslots { int node_idx; }; +#ifdef CONFIG_HEKI +struct heki_gfn_range { + gfn_t start; + gfn_t end; +}; +#endif /* CONFIG_HEKI */ + struct kvm { #ifdef KVM_HAVE_MMU_RWLOCK rwlock_t mmu_lock; @@ -801,6 +808,12 @@ struct kvm { bool vm_bugged; bool vm_dead; +#ifdef CONFIG_HEKI +#define HEKI_GFN_MAX 16 + atomic_t heki_gfn_no_write_num; + struct heki_gfn_range heki_gfn_no_write[HEKI_GFN_MAX]; +#endif /* CONFIG_HEKI */ + #ifdef CONFIG_HAVE_KVM_PM_NOTIFIER struct notifier_block pm_notifier; #endif diff --git a/include/uapi/linux/kvm_para.h b/include/uapi/linux/kvm_para.h index 960c7e93d1a9..d7512a10880e 100644 --- a/include/uapi/linux/kvm_para.h +++ b/include/uapi/linux/kvm_para.h @@ -30,6 +30,7 @@ #define KVM_HC_SEND_IPI 10 #define KVM_HC_SCHED_YIELD 11 #define KVM_HC_MAP_GPA_RANGE 12 +#define KVM_HC_LOCK_MEM_PAGE_RANGES 13 /* * hypercalls use architecture specific diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 9c60384b5ae0..4aea936dfe73 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -1230,6 +1230,10 @@ static struct kvm *kvm_create_vm(unsigned long type, const char *fdname) list_add(&kvm->vm_list, &vm_list); mutex_unlock(&kvm_lock); +#ifdef CONFIG_HEKI + atomic_set(&kvm->heki_gfn_no_write_num, HEKI_GFN_MAX + 1); +#endif /* CONFIG_HEKI */ + preempt_notifier_inc(); kvm_init_pm_notifier(kvm); -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Fri May 05 15:22:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 15:22:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530426.826057 (Exim 4.92) (envelope-from ) id 1puxGQ-0000eJ-9p; Fri, 05 May 2023 15:22:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530426.826057; Fri, 05 May 2023 15:22:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puxGP-0000aA-FV; Fri, 05 May 2023 15:22:29 +0000 Received: by outflank-mailman (input) for mailman id 530426; Fri, 05 May 2023 15:22:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puxG2-0007pX-5z for xen-devel@lists.xenproject.org; Fri, 05 May 2023 15:22:06 +0000 Received: from smtp-8fae.mail.infomaniak.ch (smtp-8fae.mail.infomaniak.ch [83.166.143.174]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 97796bb4-eb58-11ed-b226-6b7b168915f2; Fri, 05 May 2023 17:22:05 +0200 (CEST) Received: from smtp-3-0001.mail.infomaniak.ch (unknown [10.4.36.108]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4QCZDD5yVJzMqDN2; Fri, 5 May 2023 17:22:04 +0200 (CEST) Received: from unknown by smtp-3-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4QCZDD0z6dzMpxBc; Fri, 5 May 2023 17:22:04 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 97796bb4-eb58-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=digikod.net; s=20191114; t=1683300124; bh=numFKFwerBzb1GFmju5PzfUy3LvlXvoHGRlXH+KNT+c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aY8puWEd6eYwOhiBC5f3v2W8STDFR1ws5t4KGxnuMkV/veHF5dk9ikWYLtZACCzKL ZZHQs/vJJkdeZe4WGYydF7qoNq+EgiNGsn5zsfWYHRSGNlObVxnWCaLzSzlH/rsRqO 0NTmO3IcYiupEfrP7vmngHe/c3dwNtOvqClQ6aug= From: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= To: Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Ingo Molnar , Kees Cook , Paolo Bonzini , Sean Christopherson , Thomas Gleixner , Vitaly Kuznetsov , Wanpeng Li Cc: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= , Alexander Graf , Forrest Yuan Yu , James Morris , John Andersen , Liran Alon , "Madhavan T . Venkataraman" , Marian Rotariu , =?UTF-8?q?Mihai=20Don=C8=9Bu?= , =?UTF-8?q?Nicu=C8=99or=20C=C3=AE=C8=9Bu?= , Rick Edgecombe , Thara Gopinath , Will Deacon , Zahra Tarkhani , =?UTF-8?q?=C8=98tefan=20=C8=98icleru?= , dev@lists.cloudhypervisor.org, kvm@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, x86@kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH v1 7/9] KVM: VMX: Add MBEC support Date: Fri, 5 May 2023 17:20:44 +0200 Message-Id: <20230505152046.6575-8-mic@digikod.net> In-Reply-To: <20230505152046.6575-1-mic@digikod.net> References: <20230505152046.6575-1-mic@digikod.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Infomaniak-Routing: alpha This changes add support for VMX_FEATURE_MODE_BASED_EPT_EXEC (named ept_mode_based_exec in /proc/cpuinfo and MBEC elsewhere), which enables to separate EPT execution bits for supervisor vs. user. It transforms the semantic of VMX_EPT_EXECUTABLE_MASK from a global execution to a kernel execution, and use the VMX_EPT_USER_EXECUTABLE_MASK bit to identify user execution. The main use case is to be able to restrict kernel execution while ignoring user space execution from the hypervisor point of view. Indeed, user space execution can already be restricted by the guest kernel. This change enables MBEC but doesn't change the default configuration, which is to allow execution for all guest memory. However, the next commit levages MBEC to restrict kernel memory pages. MBEC can be configured with the new "enable_mbec" module parameter, set to true by default. However, MBEC is disable for L1 and L2 for now. Replace EPT_VIOLATION_RWX_MASK (3 bits) with 4 dedicated EPT_VIOLATION_READ, EPT_VIOLATION_WRITE, EPT_VIOLATION_KERNEL_INSTR, and EPT_VIOLATION_USER_INSTR bits. >From the Intel 64 and IA-32 Architectures Software Developer's Manual, Volume 3C (System Programming Guide), Part 3: SECONDARY_EXEC_MODE_BASED_EPT_EXEC (bit 22): If either the "unrestricted guest" VM-execution control or the "mode-based execute control for EPT" VM-execution control is 1, the "enable EPT" VM-execution control must also be 1. EPT_VIOLATION_KERNEL_INSTR_BIT (bit 5): The logical-AND of bit 2 in the EPT paging-structure entries used to translate the guest-physical address of the access causing the EPT violation. If the "mode-based execute control for EPT" VM-execution control is 0, this indicates whether the guest-physical address was executable. If that control is 1, this indicates whether the guest-physical address was executable for supervisor-mode linear addresses. EPT_VIOLATION_USER_INSTR_BIT (bit 6): If the "mode-based execute control" VM-execution control is 0, the value of this bit is undefined. If that control is 1, this bit is the logical-AND of bit 10 in the EPT paging-structures entries used to translate the guest-physical address of the access causing the EPT violation. In this case, it indicates whether the guest-physical address was executable for user-mode linear addresses. PT_USER_EXEC_MASK (bit 10): Execute access for user-mode linear addresses. If the "mode-based execute control for EPT" VM-execution control is 1, indicates whether instruction fetches are allowed from user-mode linear addresses in the 512-GByte region controlled by this entry. If that control is 0, this bit is ignored. Cc: Borislav Petkov Cc: Dave Hansen Cc: H. Peter Anvin Cc: Ingo Molnar Cc: Kees Cook Cc: Madhavan T. Venkataraman Cc: Paolo Bonzini Cc: Sean Christopherson Cc: Thomas Gleixner Cc: Vitaly Kuznetsov Cc: Wanpeng Li Signed-off-by: Mickaël Salaün Link: https://lore.kernel.org/r/20230505152046.6575-8-mic@digikod.net --- arch/x86/include/asm/vmx.h | 11 +++++++++-- arch/x86/kvm/mmu.h | 3 ++- arch/x86/kvm/mmu/mmu.c | 6 +++++- arch/x86/kvm/mmu/paging_tmpl.h | 16 ++++++++++++++-- arch/x86/kvm/mmu/spte.c | 4 +++- arch/x86/kvm/vmx/capabilities.h | 7 +++++++ arch/x86/kvm/vmx/nested.c | 7 +++++++ arch/x86/kvm/vmx/vmx.c | 28 +++++++++++++++++++++++++--- arch/x86/kvm/vmx/vmx.h | 1 + 9 files changed, 73 insertions(+), 10 deletions(-) diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h index 498dc600bd5c..452e7d153832 100644 --- a/arch/x86/include/asm/vmx.h +++ b/arch/x86/include/asm/vmx.h @@ -511,6 +511,7 @@ enum vmcs_field { #define VMX_EPT_IPAT_BIT (1ull << 6) #define VMX_EPT_ACCESS_BIT (1ull << 8) #define VMX_EPT_DIRTY_BIT (1ull << 9) +#define VMX_EPT_USER_EXECUTABLE_MASK (1ull << 10) #define VMX_EPT_RWX_MASK (VMX_EPT_READABLE_MASK | \ VMX_EPT_WRITABLE_MASK | \ VMX_EPT_EXECUTABLE_MASK) @@ -556,13 +557,19 @@ enum vm_entry_failure_code { #define EPT_VIOLATION_ACC_READ_BIT 0 #define EPT_VIOLATION_ACC_WRITE_BIT 1 #define EPT_VIOLATION_ACC_INSTR_BIT 2 -#define EPT_VIOLATION_RWX_SHIFT 3 +#define EPT_VIOLATION_READ_BIT 3 +#define EPT_VIOLATION_WRITE_BIT 4 +#define EPT_VIOLATION_KERNEL_INSTR_BIT 5 +#define EPT_VIOLATION_USER_INSTR_BIT 6 #define EPT_VIOLATION_GVA_IS_VALID_BIT 7 #define EPT_VIOLATION_GVA_TRANSLATED_BIT 8 #define EPT_VIOLATION_ACC_READ (1 << EPT_VIOLATION_ACC_READ_BIT) #define EPT_VIOLATION_ACC_WRITE (1 << EPT_VIOLATION_ACC_WRITE_BIT) #define EPT_VIOLATION_ACC_INSTR (1 << EPT_VIOLATION_ACC_INSTR_BIT) -#define EPT_VIOLATION_RWX_MASK (VMX_EPT_RWX_MASK << EPT_VIOLATION_RWX_SHIFT) +#define EPT_VIOLATION_READ (1 << EPT_VIOLATION_READ_BIT) +#define EPT_VIOLATION_WRITE (1 << EPT_VIOLATION_WRITE_BIT) +#define EPT_VIOLATION_KERNEL_INSTR (1 << EPT_VIOLATION_KERNEL_INSTR_BIT) +#define EPT_VIOLATION_USER_INSTR (1 << EPT_VIOLATION_USER_INSTR_BIT) #define EPT_VIOLATION_GVA_IS_VALID (1 << EPT_VIOLATION_GVA_IS_VALID_BIT) #define EPT_VIOLATION_GVA_TRANSLATED (1 << EPT_VIOLATION_GVA_TRANSLATED_BIT) diff --git a/arch/x86/kvm/mmu.h b/arch/x86/kvm/mmu.h index 6bdaacb6faa0..3c4fd4618cc1 100644 --- a/arch/x86/kvm/mmu.h +++ b/arch/x86/kvm/mmu.h @@ -24,6 +24,7 @@ extern bool __read_mostly enable_mmio_caching; #define PT_PAGE_SIZE_MASK (1ULL << PT_PAGE_SIZE_SHIFT) #define PT_PAT_MASK (1ULL << 7) #define PT_GLOBAL_MASK (1ULL << 8) +#define PT_USER_EXEC_MASK (1ULL << 10) #define PT64_NX_SHIFT 63 #define PT64_NX_MASK (1ULL << PT64_NX_SHIFT) @@ -102,7 +103,7 @@ static inline u8 kvm_get_shadow_phys_bits(void) void kvm_mmu_set_mmio_spte_mask(u64 mmio_value, u64 mmio_mask, u64 access_mask); void kvm_mmu_set_me_spte_mask(u64 me_value, u64 me_mask); -void kvm_mmu_set_ept_masks(bool has_ad_bits, bool has_exec_only); +void kvm_mmu_set_ept_masks(bool has_ad_bits, bool has_exec_only, bool has_mbec); void kvm_init_mmu(struct kvm_vcpu *vcpu); void kvm_init_shadow_npt_mmu(struct kvm_vcpu *vcpu, unsigned long cr0, diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c index e5d1e241ff0f..a47e63217eb8 100644 --- a/arch/x86/kvm/mmu/mmu.c +++ b/arch/x86/kvm/mmu/mmu.c @@ -27,6 +27,9 @@ #include "cpuid.h" #include "spte.h" +/* Required by paging_tmpl.h for enable_mbec */ +#include "../vmx/capabilities.h" + #include #include #include @@ -3763,7 +3766,8 @@ static int mmu_alloc_shadow_roots(struct kvm_vcpu *vcpu) */ pm_mask = PT_PRESENT_MASK | shadow_me_value; if (mmu->root_role.level >= PT64_ROOT_4LEVEL) { - pm_mask |= PT_ACCESSED_MASK | PT_WRITABLE_MASK | PT_USER_MASK; + pm_mask |= PT_ACCESSED_MASK | PT_WRITABLE_MASK | PT_USER_MASK | + PT_USER_EXEC_MASK; if (WARN_ON_ONCE(!mmu->pml4_root)) { r = -EIO; diff --git a/arch/x86/kvm/mmu/paging_tmpl.h b/arch/x86/kvm/mmu/paging_tmpl.h index 0f6455072055..12119d519c77 100644 --- a/arch/x86/kvm/mmu/paging_tmpl.h +++ b/arch/x86/kvm/mmu/paging_tmpl.h @@ -498,8 +498,20 @@ static int FNAME(walk_addr_generic)(struct guest_walker *walker, * Note, pte_access holds the raw RWX bits from the EPTE, not * ACC_*_MASK flags! */ - vcpu->arch.exit_qualification |= (pte_access & VMX_EPT_RWX_MASK) << - EPT_VIOLATION_RWX_SHIFT; + vcpu->arch.exit_qualification |= + !!(pte_access & VMX_EPT_READABLE_MASK) + << EPT_VIOLATION_READ_BIT; + vcpu->arch.exit_qualification |= + !!(pte_access & VMX_EPT_WRITABLE_MASK) + << EPT_VIOLATION_WRITE_BIT; + vcpu->arch.exit_qualification |= + !!(pte_access & VMX_EPT_EXECUTABLE_MASK) + << EPT_VIOLATION_KERNEL_INSTR_BIT; + if (enable_mbec) { + vcpu->arch.exit_qualification |= + !!(pte_access & VMX_EPT_USER_EXECUTABLE_MASK) + << EPT_VIOLATION_USER_INSTR_BIT; + } } #endif walker->fault.address = addr; diff --git a/arch/x86/kvm/mmu/spte.c b/arch/x86/kvm/mmu/spte.c index 639f220a1ed5..f1e2e3cad878 100644 --- a/arch/x86/kvm/mmu/spte.c +++ b/arch/x86/kvm/mmu/spte.c @@ -430,13 +430,15 @@ void kvm_mmu_set_me_spte_mask(u64 me_value, u64 me_mask) } EXPORT_SYMBOL_GPL(kvm_mmu_set_me_spte_mask); -void kvm_mmu_set_ept_masks(bool has_ad_bits, bool has_exec_only) +void kvm_mmu_set_ept_masks(bool has_ad_bits, bool has_exec_only, bool has_mbec) { shadow_user_mask = VMX_EPT_READABLE_MASK; shadow_accessed_mask = has_ad_bits ? VMX_EPT_ACCESS_BIT : 0ull; shadow_dirty_mask = has_ad_bits ? VMX_EPT_DIRTY_BIT : 0ull; shadow_nx_mask = 0ull; shadow_x_mask = VMX_EPT_EXECUTABLE_MASK; + if (has_mbec) + shadow_x_mask |= VMX_EPT_USER_EXECUTABLE_MASK; shadow_present_mask = has_exec_only ? 0ull : VMX_EPT_READABLE_MASK; /* * EPT overrides the host MTRRs, and so KVM must program the desired diff --git a/arch/x86/kvm/vmx/capabilities.h b/arch/x86/kvm/vmx/capabilities.h index cd2ac9536c99..2cc5d7d20144 100644 --- a/arch/x86/kvm/vmx/capabilities.h +++ b/arch/x86/kvm/vmx/capabilities.h @@ -13,6 +13,7 @@ extern bool __read_mostly enable_vpid; extern bool __read_mostly flexpriority_enabled; extern bool __read_mostly enable_ept; extern bool __read_mostly enable_unrestricted_guest; +extern bool __read_mostly enable_mbec; extern bool __read_mostly enable_ept_ad_bits; extern bool __read_mostly enable_pml; extern bool __read_mostly enable_ipiv; @@ -255,6 +256,12 @@ static inline bool cpu_has_vmx_xsaves(void) SECONDARY_EXEC_XSAVES; } +static inline bool cpu_has_vmx_mbec(void) +{ + return vmcs_config.cpu_based_2nd_exec_ctrl & + SECONDARY_EXEC_MODE_BASED_EPT_EXEC; +} + static inline bool cpu_has_vmx_waitpkg(void) { return vmcs_config.cpu_based_2nd_exec_ctrl & diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c index d93c715cda6a..3c381c75e2a9 100644 --- a/arch/x86/kvm/vmx/nested.c +++ b/arch/x86/kvm/vmx/nested.c @@ -2317,6 +2317,9 @@ static void prepare_vmcs02_early(struct vcpu_vmx *vmx, struct loaded_vmcs *vmcs0 /* VMCS shadowing for L2 is emulated for now */ exec_control &= ~SECONDARY_EXEC_SHADOW_VMCS; + /* MBEC is currently only handled for L0. */ + exec_control &= ~SECONDARY_EXEC_MODE_BASED_EPT_EXEC; + /* * Preset *DT exiting when emulating UMIP, so that vmx_set_cr4() * will not have to rewrite the controls just for this bit. @@ -6870,6 +6873,10 @@ void nested_vmx_setup_ctls_msrs(struct vmcs_config *vmcs_conf, u32 ept_caps) */ msrs->secondary_ctls_low = 0; + /* + * Currently, SECONDARY_EXEC_MODE_BASED_EPT_EXEC is only handled for + * L0 and doesn't need to be exposed to L1 nor L2. + */ msrs->secondary_ctls_high = vmcs_conf->cpu_based_2nd_exec_ctrl; msrs->secondary_ctls_high &= SECONDARY_EXEC_DESC | diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c index 931688edc8eb..004fd4e5e057 100644 --- a/arch/x86/kvm/vmx/vmx.c +++ b/arch/x86/kvm/vmx/vmx.c @@ -94,6 +94,9 @@ bool __read_mostly enable_unrestricted_guest = 1; module_param_named(unrestricted_guest, enable_unrestricted_guest, bool, S_IRUGO); +bool __read_mostly enable_mbec = true; +module_param_named(mbec, enable_mbec, bool, 0444); + bool __read_mostly enable_ept_ad_bits = 1; module_param_named(eptad, enable_ept_ad_bits, bool, S_IRUGO); @@ -4518,10 +4521,21 @@ static u32 vmx_secondary_exec_control(struct vcpu_vmx *vmx) exec_control &= ~SECONDARY_EXEC_ENABLE_VPID; if (!enable_ept) { exec_control &= ~SECONDARY_EXEC_ENABLE_EPT; + /* + * From Intel's SDM: + * If either the "unrestricted guest" VM-execution control or + * the "mode-based execute control for EPT" VM-execution + * control is 1, the "enable EPT" VM-execution control must + * also be 1. + */ enable_unrestricted_guest = 0; + enable_mbec = false; } if (!enable_unrestricted_guest) exec_control &= ~SECONDARY_EXEC_UNRESTRICTED_GUEST; + if (!enable_mbec) + exec_control &= ~SECONDARY_EXEC_MODE_BASED_EPT_EXEC; + if (kvm_pause_in_guest(vmx->vcpu.kvm)) exec_control &= ~SECONDARY_EXEC_PAUSE_LOOP_EXITING; if (!kvm_vcpu_apicv_active(vcpu)) @@ -5658,7 +5672,7 @@ static int handle_task_switch(struct kvm_vcpu *vcpu) static int handle_ept_violation(struct kvm_vcpu *vcpu) { - unsigned long exit_qualification; + unsigned long exit_qualification, rwx_mask; gpa_t gpa; u64 error_code; @@ -5688,7 +5702,11 @@ static int handle_ept_violation(struct kvm_vcpu *vcpu) error_code |= (exit_qualification & EPT_VIOLATION_ACC_INSTR) ? PFERR_FETCH_MASK : 0; /* ept page table entry is present? */ - error_code |= (exit_qualification & EPT_VIOLATION_RWX_MASK) + rwx_mask = EPT_VIOLATION_READ | EPT_VIOLATION_WRITE | + EPT_VIOLATION_KERNEL_INSTR; + if (enable_mbec) + rwx_mask |= EPT_VIOLATION_USER_INSTR; + error_code |= (exit_qualification & rwx_mask) ? PFERR_PRESENT_MASK : 0; error_code |= (exit_qualification & EPT_VIOLATION_GVA_TRANSLATED) != 0 ? @@ -8345,6 +8363,9 @@ static __init int hardware_setup(void) if (!cpu_has_vmx_unrestricted_guest() || !enable_ept) enable_unrestricted_guest = 0; + if (!cpu_has_vmx_mbec() || !enable_ept) + enable_mbec = false; + if (!cpu_has_vmx_flexpriority()) flexpriority_enabled = 0; @@ -8404,7 +8425,8 @@ static __init int hardware_setup(void) if (enable_ept) kvm_mmu_set_ept_masks(enable_ept_ad_bits, - cpu_has_vmx_ept_execute_only()); + cpu_has_vmx_ept_execute_only(), + enable_mbec); /* * Setup shadow_me_value/shadow_me_mask to include MKTME KeyID diff --git a/arch/x86/kvm/vmx/vmx.h b/arch/x86/kvm/vmx/vmx.h index a3da84f4ea45..815db44cd51e 100644 --- a/arch/x86/kvm/vmx/vmx.h +++ b/arch/x86/kvm/vmx/vmx.h @@ -585,6 +585,7 @@ static inline u8 vmx_get_rvi(void) SECONDARY_EXEC_ENABLE_VMFUNC | \ SECONDARY_EXEC_BUS_LOCK_DETECTION | \ SECONDARY_EXEC_NOTIFY_VM_EXITING | \ + SECONDARY_EXEC_MODE_BASED_EPT_EXEC | \ SECONDARY_EXEC_ENCLS_EXITING) #define KVM_REQUIRED_VMX_TERTIARY_VM_EXEC_CONTROL 0 -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Fri May 05 15:22:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 15:22:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530428.826059 (Exim 4.92) (envelope-from ) id 1puxGQ-0000oo-GI; Fri, 05 May 2023 15:22:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530428.826059; Fri, 05 May 2023 15:22:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puxGQ-0000jU-0Y; Fri, 05 May 2023 15:22:30 +0000 Received: by outflank-mailman (input) for mailman id 530428; Fri, 05 May 2023 15:22:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puxG5-0007pR-FO for xen-devel@lists.xenproject.org; Fri, 05 May 2023 15:22:09 +0000 Received: from smtp-bc0d.mail.infomaniak.ch (smtp-bc0d.mail.infomaniak.ch [45.157.188.13]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 98c50ca0-eb58-11ed-8611-37d641c3527e; Fri, 05 May 2023 17:22:07 +0200 (CEST) Received: from smtp-3-0001.mail.infomaniak.ch (unknown [10.4.36.108]) by smtp-2-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4QCZDH0FZXzMqc7P; Fri, 5 May 2023 17:22:07 +0200 (CEST) Received: from unknown by smtp-3-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4QCZDG2bp6zMpxBc; Fri, 5 May 2023 17:22:06 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 98c50ca0-eb58-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=digikod.net; s=20191114; t=1683300126; bh=6hEUXV1Yu+QqE06q6YV92ksgcTE4SSVMGFp/YRlUSqM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cCom6GYQLGlk2nCbcclR8AZKUkW0AJpZFC6wR92gff0rbAnNjJlFfzBd5J+3y++84 WAx+LLa8CAjewu98goOyt+2vh84ogydmCURfKSQ02P+jr2VYlfAmiT9Knsjn08r/LT Tng2aFdb73PL8bp/dTy6vPMFTznPlq63+NzYf8sI= From: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= To: Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Ingo Molnar , Kees Cook , Paolo Bonzini , Sean Christopherson , Thomas Gleixner , Vitaly Kuznetsov , Wanpeng Li Cc: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= , Alexander Graf , Forrest Yuan Yu , James Morris , John Andersen , Liran Alon , "Madhavan T . Venkataraman" , Marian Rotariu , =?UTF-8?q?Mihai=20Don=C8=9Bu?= , =?UTF-8?q?Nicu=C8=99or=20C=C3=AE=C8=9Bu?= , Rick Edgecombe , Thara Gopinath , Will Deacon , Zahra Tarkhani , =?UTF-8?q?=C8=98tefan=20=C8=98icleru?= , dev@lists.cloudhypervisor.org, kvm@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, x86@kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH v1 9/9] virt: Add Heki KUnit tests Date: Fri, 5 May 2023 17:20:46 +0200 Message-Id: <20230505152046.6575-10-mic@digikod.net> In-Reply-To: <20230505152046.6575-1-mic@digikod.net> References: <20230505152046.6575-1-mic@digikod.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Infomaniak-Routing: alpha This adds a new CONFIG_HEKI_TEST option to run tests at boot. Indeed, because this patch series forbids the loading of kernel modules after the boot, we need to make built-in tests. Furthermore, because we use some symbols not exported to modules (e.g., kernel_set_to_readonly) this could not work as modules. To run these tests, we need to boot the kernel with the heki_test=N boot argument with N selecting a specific test: 1. heki_test_cr_disable_smep: Check CR pinning and try to disable SMEP. 2. heki_test_write_to_const: Check .rodata (const) protection. 3. heki_test_write_to_ro_after_init: Check __ro_after_init protection. 4. heki_test_exec: Check non-executable kernel memory. This way to select tests should not be required when the kernel will properly handle the triggered synthetic page faults. For now, these page faults make the kernel loop. All these tests temporarily disable the related kernel self-protections and should then failed if Heki doesn't protect the kernel. They are verbose to make it easier to understand what is going on. Cc: Borislav Petkov Cc: Dave Hansen Cc: H. Peter Anvin Cc: Ingo Molnar Cc: Kees Cook Cc: Madhavan T. Venkataraman Cc: Paolo Bonzini Cc: Sean Christopherson Cc: Thomas Gleixner Cc: Vitaly Kuznetsov Cc: Wanpeng Li Signed-off-by: Mickaël Salaün Link: https://lore.kernel.org/r/20230505152046.6575-10-mic@digikod.net --- virt/heki/Kconfig | 12 +++ virt/heki/heki.c | 194 +++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 205 insertions(+), 1 deletion(-) diff --git a/virt/heki/Kconfig b/virt/heki/Kconfig index 96f18ce03013..806981f2b22d 100644 --- a/virt/heki/Kconfig +++ b/virt/heki/Kconfig @@ -27,3 +27,15 @@ config HYPERVISOR_SUPPORTS_HEKI A hypervisor should select this when it can successfully build and run with CONFIG_HEKI. That is, it should provide all of the hypervisor support required for the Heki feature. + +config HEKI_TEST + bool "Tests for Heki" if !KUNIT_ALL_TESTS + depends on HEKI && KUNIT=y + default KUNIT_ALL_TESTS + help + Run Heki tests at runtime according to the heki_test=N boot + parameter, with N identifying the test to run (between 1 and 4). + + Before launching the init process, the system might not respond + because of unhandled kernel page fault. This will be fixed in a + next patch series. diff --git a/virt/heki/heki.c b/virt/heki/heki.c index 142b5dc98a2f..361e7734e950 100644 --- a/virt/heki/heki.c +++ b/virt/heki/heki.c @@ -5,11 +5,13 @@ * Copyright © 2023 Microsoft Corporation */ +#include #include #include #include #include #include +#include #include #include @@ -78,13 +80,201 @@ void __init heki_early_init(void) heki_arch_init(); } +#ifdef CONFIG_HEKI_TEST + +/* Heki test data */ + +/* Takes two pages to not change permission of other read-only pages. */ +const char heki_test_const_buf[PAGE_SIZE * 2] = {}; +char heki_test_ro_after_init_buf[PAGE_SIZE * 2] __ro_after_init = {}; + +long heki_test_exec_data(long); +void _test_exec_data_end(void); + +/* Used to test ROP execution against the .rodata section. */ +/* clang-format off */ +asm( +".pushsection .rodata;" // NOT .text section +".global heki_test_exec_data;" +".type heki_test_exec_data, @function;" +"heki_test_exec_data:" +ASM_ENDBR +"movq %rdi, %rax;" +"inc %rax;" +ASM_RET +".size heki_test_exec_data, .-heki_test_exec_data;" +"_test_exec_data_end:" +".popsection"); +/* clang-format on */ + +static void heki_test_cr_disable_smep(struct kunit *test) +{ + unsigned long cr4; + + /* SMEP should be initially enabled. */ + KUNIT_ASSERT_TRUE(test, __read_cr4() & X86_CR4_SMEP); + + kunit_warn(test, + "Starting control register pinning tests with SMEP check\n"); + + /* + * Trying to disable SMEP, bypassing kernel self-protection by not + * using cr4_clear_bits(X86_CR4_SMEP). + */ + cr4 = __read_cr4() & ~X86_CR4_SMEP; + asm volatile("mov %0,%%cr4" : "+r"(cr4) : : "memory"); + + /* SMEP should still be enabled. */ + KUNIT_ASSERT_TRUE(test, __read_cr4() & X86_CR4_SMEP); +} + +static inline void print_addr(struct kunit *test, const char *const buf_name, + void *const buf) +{ + const pte_t pte = *virt_to_kpte((unsigned long)buf); + const phys_addr_t paddr = slow_virt_to_phys(buf); + bool present = pte_flags(pte) & (_PAGE_PRESENT); + bool accessible = pte_accessible(&init_mm, pte); + + kunit_warn( + test, + "%s vaddr:%llx paddr:%llx exec:%d write:%d present:%d accessible:%d\n", + buf_name, (unsigned long long)buf, paddr, !!pte_exec(pte), + !!pte_write(pte), present, accessible); +} + +extern int kernel_set_to_readonly; + +static void heki_test_write_to_rodata(struct kunit *test, + const char *const buf_name, + char *const ro_buf) +{ + print_addr(test, buf_name, (void *)ro_buf); + KUNIT_EXPECT_EQ(test, 0, *ro_buf); + + kunit_warn( + test, + "Bypassing kernel self-protection: mark memory as writable\n"); + kernel_set_to_readonly = 0; + /* + * Removes execute permission that might be set by bugdoor-exec, + * because change_page_attr_clear() is not use by set_memory_rw(). + * This is required since commit 652c5bf380ad ("x86/mm: Refuse W^X + * violations"). + */ + KUNIT_ASSERT_FALSE(test, set_memory_nx((unsigned long)PTR_ALIGN_DOWN( + ro_buf, PAGE_SIZE), + 1)); + KUNIT_ASSERT_FALSE(test, set_memory_rw((unsigned long)PTR_ALIGN_DOWN( + ro_buf, PAGE_SIZE), + 1)); + kernel_set_to_readonly = 1; + + kunit_warn(test, "Trying memory write\n"); + *ro_buf = 0x11; + KUNIT_EXPECT_EQ(test, 0, *ro_buf); + kunit_warn(test, "New content: 0x%02x\n", *ro_buf); +} + +static void heki_test_write_to_const(struct kunit *test) +{ + heki_test_write_to_rodata(test, "const_buf", + (void *)heki_test_const_buf); +} + +static void heki_test_write_to_ro_after_init(struct kunit *test) +{ + heki_test_write_to_rodata(test, "ro_after_init_buf", + (void *)heki_test_ro_after_init_buf); +} + +typedef long test_exec_t(long); + +static void heki_test_exec(struct kunit *test) +{ + const size_t exec_size = 7; + unsigned long nx_page_start = (unsigned long)PTR_ALIGN_DOWN( + (const void *const)heki_test_exec_data, PAGE_SIZE); + unsigned long nx_page_end = (unsigned long)PTR_ALIGN( + (const void *const)heki_test_exec_data + exec_size, PAGE_SIZE); + test_exec_t *exec = (test_exec_t *)heki_test_exec_data; + long ret; + + /* Starting non-executable memory tests. */ + print_addr(test, "test_exec_data", heki_test_exec_data); + + kunit_warn( + test, + "Bypassing kernel-self protection: mark memory as executable\n"); + kernel_set_to_readonly = 0; + KUNIT_ASSERT_FALSE(test, + set_memory_rox(nx_page_start, + PFN_UP(nx_page_end - nx_page_start))); + kernel_set_to_readonly = 1; + + kunit_warn( + test, + "Trying to execute data (ROP) in (initially) non-executable memory\n"); + ret = exec(3); + + /* This should not be reached because of the uncaught page fault. */ + KUNIT_EXPECT_EQ(test, 3, ret); + kunit_warn(test, "Result of execution: 3 + 1 = %ld\n", ret); +} + +const struct kunit_case heki_test_cases[] = { + KUNIT_CASE(heki_test_cr_disable_smep), + KUNIT_CASE(heki_test_write_to_const), + KUNIT_CASE(heki_test_write_to_ro_after_init), + KUNIT_CASE(heki_test_exec), + {} +}; + +static unsigned long heki_test __ro_after_init; + +static int __init parse_heki_test_config(char *str) +{ + if (kstrtoul(str, 10, &heki_test) || + heki_test > (ARRAY_SIZE(heki_test_cases) - 1)) + pr_warn("Invalid option string for heki_test: '%s'\n", str); + return 1; +} + +__setup("heki_test=", parse_heki_test_config); + +static void heki_run_test(void) +{ + struct kunit_case heki_test_case[2] = {}; + struct kunit_suite heki_test_suite = { + .name = "heki", + .test_cases = heki_test_case, + }; + struct kunit_suite *const test_suite = &heki_test_suite; + + if (!kunit_enabled() || heki_test == 0 || + heki_test >= ARRAY_SIZE(heki_test_cases)) + return; + + pr_warn("Running test #%lu\n", heki_test); + heki_test_case[0] = heki_test_cases[heki_test - 1]; + __kunit_test_suites_init(&test_suite, 1); +} + +#else /* CONFIG_HEKI_TEST */ + +static inline void heki_run_test(void) +{ +} + +#endif /* CONFIG_HEKI_TEST */ + void heki_late_init(void) { struct heki_hypervisor *hypervisor = heki.hypervisor; int ret; if (!heki_enabled) - return; + return heki_run_test(); if (!heki.static_ranges) { pr_warn("Architecture did not initialize static ranges\n"); @@ -113,6 +303,8 @@ void heki_late_init(void) goto out; pr_warn("Control registers locked\n"); + heki_run_test(); + out: heki_free_pa_ranges(heki.static_ranges, heki.num_static_ranges); heki.static_ranges = NULL; -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Fri May 05 15:22:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 15:22:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530430.826069 (Exim 4.92) (envelope-from ) id 1puxGR-0000z8-BK; Fri, 05 May 2023 15:22:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530430.826069; Fri, 05 May 2023 15:22:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puxGQ-0000uO-MM; Fri, 05 May 2023 15:22:30 +0000 Received: by outflank-mailman (input) for mailman id 530430; Fri, 05 May 2023 15:22:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puxG8-0007pX-Dm for xen-devel@lists.xenproject.org; Fri, 05 May 2023 15:22:12 +0000 Received: from smtp-1908.mail.infomaniak.ch (smtp-1908.mail.infomaniak.ch [185.125.25.8]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9b1ed6d0-eb58-11ed-b226-6b7b168915f2; Fri, 05 May 2023 17:22:11 +0200 (CEST) Received: from smtp-3-0001.mail.infomaniak.ch (unknown [10.4.36.108]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4QCZDF6ppRzMq81r; Fri, 5 May 2023 17:22:05 +0200 (CEST) Received: from unknown by smtp-3-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4QCZDF1ydFzMptBL; Fri, 5 May 2023 17:22:05 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b1ed6d0-eb58-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=digikod.net; s=20191114; t=1683300125; bh=PyAeGY6RXqTYQefM0sl5cf8gwLNcu9YypouNBS2PSvg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gx2MJRBQRK/Q7zeNftCJx4FHowj9XptOmH9PCuCsUSu0Bp7v+0qbMxJPxRE/O0jXB coJOo2nnquoJ+LYtPiXbpt1gGK6521yg3b0SbAlgonaVc1WJSFYSTnWf6gVnc0qPj3 BlSHXvPRMTfLaM2oFX0fm3FNVa7xLedl9XNnFLhY= From: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= To: Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Ingo Molnar , Kees Cook , Paolo Bonzini , Sean Christopherson , Thomas Gleixner , Vitaly Kuznetsov , Wanpeng Li Cc: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= , Alexander Graf , Forrest Yuan Yu , James Morris , John Andersen , Liran Alon , "Madhavan T . Venkataraman" , Marian Rotariu , =?UTF-8?q?Mihai=20Don=C8=9Bu?= , =?UTF-8?q?Nicu=C8=99or=20C=C3=AE=C8=9Bu?= , Rick Edgecombe , Thara Gopinath , Will Deacon , Zahra Tarkhani , =?UTF-8?q?=C8=98tefan=20=C8=98icleru?= , dev@lists.cloudhypervisor.org, kvm@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, x86@kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH v1 8/9] KVM: x86/mmu: Enable guests to lock themselves thanks to MBEC Date: Fri, 5 May 2023 17:20:45 +0200 Message-Id: <20230505152046.6575-9-mic@digikod.net> In-Reply-To: <20230505152046.6575-1-mic@digikod.net> References: <20230505152046.6575-1-mic@digikod.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Infomaniak-Routing: alpha This changes enable to enforce a deny-by-default execution security policy for guest kernels, leveraged by the Heki implementation. Create synthetic page faults when an access is denied by Heki. This kind of kernel page fault needs to be handled by guests, which is not currently the case, making it try again and again, but we are working to calm down such guests by teaching them how to handle such page faults. The MMU tracepoints are updated to reflect the difference between kernel and user space executions. kvm_heki_fix_all_ept_exec_perm() walks through all guest memory pages to set the configured default execution permissions (i.e. only allow configured executabel memory pages). The struct heki_mem_range's attribute field now understand HEKI_ATTR_MEM_EXEC, which allows the related kernel sections to be executable, and deny any other kernel memory from being executable for the whole lifetime of the guest. This obviously can only work with static kernels and we are exploring ways to handle authenticated and dynamic kernel memory permission updates. If the host doesn't have MBEC enabled, the KVM_HC_LOCK_MEM_PAGE_RANGES hypecall will return -KVM_EOPNOTSUPP and might only apply the previous ranges, if any. This is useful to develop this RFC and make sure execution restrictions are enforced (and not silently ignored), but this behavior might change in a future patch series. Guest kernels could check for MBEC support to not use the HEKI_ATTR_MEM_EXEC attribute. The number of configurable memory ranges per guest is 16 for now. This will change with a follow-up. There are currently some pr_warn() calls to make it easy to test this code. Cc: Borislav Petkov Cc: Dave Hansen Cc: H. Peter Anvin Cc: Ingo Molnar Cc: Kees Cook Cc: Madhavan T. Venkataraman Cc: Paolo Bonzini Cc: Sean Christopherson Cc: Thomas Gleixner Cc: Vitaly Kuznetsov Cc: Wanpeng Li Signed-off-by: Mickaël Salaün Link: https://lore.kernel.org/r/20230505152046.6575-9-mic@digikod.net --- Documentation/virt/kvm/x86/hypercalls.rst | 4 +- arch/x86/kvm/mmu/mmu.c | 35 ++++++++- arch/x86/kvm/mmu/mmutrace.h | 11 ++- arch/x86/kvm/mmu/spte.c | 19 ++++- arch/x86/kvm/mmu/spte.h | 15 +++- arch/x86/kvm/mmu/tdp_mmu.c | 73 ++++++++++++++++++ arch/x86/kvm/mmu/tdp_mmu.h | 4 + arch/x86/kvm/x86.c | 90 ++++++++++++++++++++++- arch/x86/kvm/x86.h | 7 ++ include/linux/kvm_host.h | 4 + virt/kvm/kvm_main.c | 1 + 11 files changed, 250 insertions(+), 13 deletions(-) diff --git a/Documentation/virt/kvm/x86/hypercalls.rst b/Documentation/virt/kvm/x86/hypercalls.rst index 8aa5d28986e3..5accf5f6de13 100644 --- a/Documentation/virt/kvm/x86/hypercalls.rst +++ b/Documentation/virt/kvm/x86/hypercalls.rst @@ -204,7 +204,9 @@ must also set up an MSR filter to process writes to MSR_KVM_MIGRATION_CONTROL. The hypercall lets a guest request memory permissions to be removed for itself, identified with set of physical page ranges (GFNs). The HEKI_ATTR_MEM_NOWRITE -memory page range attribute forbids related modification to the guest. +memory page range attribute forbids related modification to the guest. The +HEKI_ATTR_MEM_EXEC attribute allows execution on the specified pages while +removing it for all the others. Returns 0 on success or a KVM error code otherwise. diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c index a47e63217eb8..56a8bcac1b82 100644 --- a/arch/x86/kvm/mmu/mmu.c +++ b/arch/x86/kvm/mmu/mmu.c @@ -3313,7 +3313,7 @@ fast_pf_fix_direct_spte(struct kvm_vcpu *vcpu, struct kvm_page_fault *fault, static bool is_access_allowed(struct kvm_page_fault *fault, u64 spte) { if (fault->exec) - return is_executable_pte(spte); + return is_executable_pte(spte, !fault->user); if (fault->write) return is_writable_pte(spte); @@ -5602,6 +5602,39 @@ int noinline kvm_mmu_page_fault(struct kvm_vcpu *vcpu, gpa_t cr2_or_gpa, u64 err if (WARN_ON(!VALID_PAGE(vcpu->arch.mmu->root.hpa))) return RET_PF_RETRY; + /* Skips real page faults if not needed. */ + if ((error_code & PFERR_FETCH_MASK) && + !kvm_heki_is_exec_allowed(vcpu, cr2_or_gpa)) { + /* + * TODO: To avoid kvm_heki_is_exec_allowed() call, check + * enable_mbec and EPT_VIOLATION_KERNEL_INSTR, see + * handle_ept_violation(). + */ + struct x86_exception fault = { + .vector = PF_VECTOR, + .error_code_valid = true, + .error_code = error_code, + .nested_page_fault = false, + /* + * TODO: This kind of kernel page fault needs to be handled by + * the guest, which is not currently the case, making it try + * again and again. + * + * You may want to test with cr2_or_gva to see the page + * fault caught by the guest kernel (thinking it is a + * user space fault). + */ + .address = static_call(kvm_x86_fault_gva)(vcpu), + .async_page_fault = false, + }; + + pr_warn_ratelimited( + "heki-kvm: Creating fetch #PF at 0x%016llx\n", + fault.address); + kvm_inject_page_fault(vcpu, &fault); + return RET_PF_INVALID; + } + r = RET_PF_INVALID; if (unlikely(error_code & PFERR_RSVD_MASK)) { r = handle_mmio_page_fault(vcpu, cr2_or_gpa, direct); diff --git a/arch/x86/kvm/mmu/mmutrace.h b/arch/x86/kvm/mmu/mmutrace.h index ae86820cef69..cb7df95aec25 100644 --- a/arch/x86/kvm/mmu/mmutrace.h +++ b/arch/x86/kvm/mmu/mmutrace.h @@ -342,7 +342,8 @@ TRACE_EVENT( __field(u8, level) /* These depend on page entry type, so compute them now. */ __field(bool, r) - __field(bool, x) + __field(bool, kx) + __field(bool, ux) __field(signed char, u) ), @@ -352,15 +353,17 @@ TRACE_EVENT( __entry->sptep = virt_to_phys(sptep); __entry->level = level; __entry->r = shadow_present_mask || (__entry->spte & PT_PRESENT_MASK); - __entry->x = is_executable_pte(__entry->spte); + __entry->kx = is_executable_pte(__entry->spte, true); + __entry->ux = is_executable_pte(__entry->spte, false); __entry->u = shadow_user_mask ? !!(__entry->spte & shadow_user_mask) : -1; ), - TP_printk("gfn %llx spte %llx (%s%s%s%s) level %d at %llx", + TP_printk("gfn %llx spte %llx (%s%s%s%s%s) level %d at %llx", __entry->gfn, __entry->spte, __entry->r ? "r" : "-", __entry->spte & PT_WRITABLE_MASK ? "w" : "-", - __entry->x ? "x" : "-", + __entry->kx ? "X" : "-", + __entry->ux ? "x" : "-", __entry->u == -1 ? "" : (__entry->u ? "u" : "-"), __entry->level, __entry->sptep ) diff --git a/arch/x86/kvm/mmu/spte.c b/arch/x86/kvm/mmu/spte.c index f1e2e3cad878..c9fabb3c9cb2 100644 --- a/arch/x86/kvm/mmu/spte.c +++ b/arch/x86/kvm/mmu/spte.c @@ -184,10 +184,25 @@ bool make_spte(struct kvm_vcpu *vcpu, struct kvm_mmu_page *sp, pte_access &= ~ACC_EXEC_MASK; } - if (pte_access & ACC_EXEC_MASK) + if (pte_access & ACC_EXEC_MASK) { spte |= shadow_x_mask; - else +#ifdef CONFIG_HEKI + /* + * FIXME: Race condition (at boot) if no + * lockdep_assert_held_write(vcpu->kvm->mmu_lock); + */ + if (READ_ONCE(vcpu->kvm->heki_kernel_exec_locked)) { + if (!heki_exec_is_allowed(vcpu->kvm, gfn)) + spte &= ~VMX_EPT_EXECUTABLE_MASK; + else + pr_warn("heki-kvm: Allowing kernel execution " + "for GFN 0x%llx\n", + gfn); + } +#endif /* CONFIG_HEKI */ + } else { spte |= shadow_nx_mask; + } if (pte_access & ACC_USER_MASK) spte |= shadow_user_mask; diff --git a/arch/x86/kvm/mmu/spte.h b/arch/x86/kvm/mmu/spte.h index 6f54dc9409c9..30b250d03132 100644 --- a/arch/x86/kvm/mmu/spte.h +++ b/arch/x86/kvm/mmu/spte.h @@ -3,7 +3,10 @@ #ifndef KVM_X86_MMU_SPTE_H #define KVM_X86_MMU_SPTE_H +#include + #include "mmu_internal.h" +#include "../vmx/vmx.h" /* * A MMU present SPTE is backed by actual memory and may or may not be present @@ -307,9 +310,17 @@ static inline bool is_last_spte(u64 pte, int level) return (level == PG_LEVEL_4K) || is_large_pte(pte); } -static inline bool is_executable_pte(u64 spte) +static inline bool is_executable_pte(u64 spte, bool for_kernel_mode) { - return (spte & (shadow_x_mask | shadow_nx_mask)) == shadow_x_mask; + u64 x_mask = shadow_x_mask; + + if (enable_mbec) { + if (for_kernel_mode) + x_mask &= ~VMX_EPT_USER_EXECUTABLE_MASK; + else + x_mask &= ~VMX_EPT_EXECUTABLE_MASK; + } + return (spte & (x_mask | shadow_nx_mask)) == x_mask; } static inline kvm_pfn_t spte_to_pfn(u64 pte) diff --git a/arch/x86/kvm/mmu/tdp_mmu.c b/arch/x86/kvm/mmu/tdp_mmu.c index d6df38d371a0..0be34a9e90c0 100644 --- a/arch/x86/kvm/mmu/tdp_mmu.c +++ b/arch/x86/kvm/mmu/tdp_mmu.c @@ -7,7 +7,10 @@ #include "tdp_mmu.h" #include "spte.h" +#include "../x86.h" + #include +#include #include static bool __read_mostly tdp_mmu_enabled = true; @@ -1021,6 +1024,76 @@ void kvm_tdp_mmu_zap_all(struct kvm *kvm) } } +#ifdef CONFIG_HEKI + +/* TODO: Handle flush? */ +void kvm_heki_fix_all_ept_exec_perm(struct kvm *const kvm) +{ + int i; + struct kvm_mmu_page *root; + const gfn_t start = 0; + const gfn_t end = tdp_mmu_max_gfn_exclusive(); + + if (WARN_ON_ONCE(!is_tdp_mmu_enabled(kvm))) + return; + + if (WARN_ON_ONCE(!enable_mbec)) + return; + + write_lock(&kvm->mmu_lock); + + /* + * Because heki_exec_locked is only set with this code, it cannot be + * unlocked. This is protected against race condition thanks to + * mmu_lock. + */ + WRITE_ONCE(kvm->heki_kernel_exec_locked, true); + + for (i = 0; i < KVM_ADDRESS_SPACE_NUM; i++) { + for_each_tdp_mmu_root(kvm, root, i) { + struct tdp_iter iter; + + WARN_ON_ONCE(!refcount_read(&root->tdp_mmu_root_count)); + + /* + * TODO: Make sure + * !is_shadow_present_pte()/SPTE_MMU_PRESENT_MASK are + * well handled when they are present. + */ + + rcu_read_lock(); + tdp_root_for_each_leaf_pte(iter, root, start, end) { + u64 new_spte; + + if (heki_exec_is_allowed(kvm, iter.gfn)) { + pr_warn("heki-kvm: Allowing kernel " + "execution for GFN 0x%llx\n", + iter.gfn); + continue; + } + pr_warn("heki-kvm: Denying kernel execution " + "for GFN 0x%llx\n", + iter.gfn); + +retry: + new_spte = iter.old_spte & + ~VMX_EPT_EXECUTABLE_MASK; + if (new_spte == iter.old_spte) + continue; + + if (tdp_mmu_set_spte_atomic(kvm, &iter, + new_spte)) + goto retry; + } + rcu_read_unlock(); + } + } + write_unlock(&kvm->mmu_lock); + pr_warn("heki-kvm: Locked executable kernel memory\n"); +} + +#endif /* CONFIG_HEKI */ + /* * Zap all invalidated roots to ensure all SPTEs are dropped before the "fast * zap" completes. diff --git a/arch/x86/kvm/mmu/tdp_mmu.h b/arch/x86/kvm/mmu/tdp_mmu.h index d3714200b932..8b70b6af68d4 100644 --- a/arch/x86/kvm/mmu/tdp_mmu.h +++ b/arch/x86/kvm/mmu/tdp_mmu.h @@ -24,6 +24,10 @@ void kvm_tdp_mmu_zap_all(struct kvm *kvm); void kvm_tdp_mmu_invalidate_all_roots(struct kvm *kvm); void kvm_tdp_mmu_zap_invalidated_roots(struct kvm *kvm); +#ifdef CONFIG_HEKI +void kvm_heki_fix_all_ept_exec_perm(struct kvm *const kvm); +#endif /* CONFIG_HEKI */ + int kvm_tdp_mmu_map(struct kvm_vcpu *vcpu, struct kvm_page_fault *fault); bool kvm_tdp_mmu_unmap_gfn_range(struct kvm *kvm, struct kvm_gfn_range *range, diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index a529455359ac..7ac8d9fabc18 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -20,6 +20,7 @@ #include "irq.h" #include "ioapic.h" #include "mmu.h" +#include "mmu/tdp_mmu.h" #include "i8254.h" #include "tss.h" #include "kvm_cache_regs.h" @@ -31,6 +32,7 @@ #include "lapic.h" #include "xen.h" #include "smm.h" +#include "vmx/capabilities.h" #include #include @@ -9705,6 +9707,45 @@ heki_page_track_prewrite(struct kvm_vcpu *const vcpu, const gpa_t gpa, return true; } +bool heki_exec_is_allowed(const struct kvm *const kvm, const gfn_t gfn) +{ + unsigned int gfn_last; + + if (!READ_ONCE(kvm->heki_kernel_exec_locked)) + return true; + + /* + * heki_gfn_exec_last is initialized with (HEKI_GFN_MAX + 1), + * and 0 means that heki_gfn_exec_last is full. + */ + for (gfn_last = atomic_read(&kvm->heki_gfn_exec_last); + gfn_last > 0 && gfn_last <= HEKI_GFN_MAX;) { + gfn_last--; + + /* Ignores unused slots. */ + if (kvm->heki_gfn_exec[gfn_last].end == 0) + break; + + if (gfn >= kvm->heki_gfn_exec[gfn_last].start && + gfn <= kvm->heki_gfn_exec[gfn_last].end) { + /* TODO: Opportunistically shrink heki_gfn_exec. */ + return true; + } + } + return false; +} + +bool kvm_heki_is_exec_allowed(struct kvm_vcpu *vcpu, gpa_t gpa) +{ + const gfn_t gfn = gpa_to_gfn(gpa); + const struct kvm *const kvm = vcpu->kvm; + + if (heki_exec_is_allowed(kvm, gfn)) + return true; + + return false; +} + static int kvm_heki_init_vm(struct kvm *const kvm) { struct kvm_page_track_notifier_node *const node = @@ -9733,6 +9774,7 @@ static int heki_lock_mem_page_ranges(struct kvm *const kvm, gpa_t mem_ranges, int err; size_t i, ranges_num; struct heki_pa_range *ranges; + bool has_exec_restriction = false; if (mem_ranges_size > HEKI_PA_RANGE_MAX_SIZE) return -KVM_E2BIG; @@ -9752,7 +9794,8 @@ static int heki_lock_mem_page_ranges(struct kvm *const kvm, gpa_t mem_ranges, ranges_num = mem_ranges_size / sizeof(struct heki_pa_range); for (i = 0; i < ranges_num; i++) { - const u64 attributes_mask = HEKI_ATTR_MEM_NOWRITE; + const u64 attributes_mask = HEKI_ATTR_MEM_NOWRITE | + HEKI_ATTR_MEM_EXEC; const gfn_t gfn_start = ranges[i].gfn_start; const gfn_t gfn_end = ranges[i].gfn_end; const u64 attributes = ranges[i].attributes; @@ -9799,11 +9842,52 @@ static int heki_lock_mem_page_ranges(struct kvm *const kvm, gpa_t mem_ranges, kvm, gfn, KVM_PAGE_TRACK_PREWRITE)); } - pr_warn("heki-kvm: Locking GFN 0x%llx-0x%llx with %s\n", + /* + * Allow-list for execute permission, + * see kvm_heki_fix_all_ept_exec_perm(). + */ + if (attributes & HEKI_ATTR_MEM_EXEC) { + size_t gfn_i; + + if (!enable_mbec) { + /* + * Guests can check for MBEC support to avoid + * such error by not using HEKI_ATTR_MEM_EXEC. + */ + err = -KVM_EOPNOTSUPP; + pr_warn("heki-kvm: HEKI_ATTR_MEM_EXEC " + "depends on MBEC, which is disabled."); + /* + * We should continue partially applying + * restrictions, but it is useful for this RFC + * to exit early in case of missing MBEC + * support. + */ + goto out_free_ranges; + } + + has_exec_restriction = true; + gfn_i = atomic_dec_if_positive( + &kvm->heki_gfn_exec_last); + if (gfn_i == 0) { + err = -KVM_E2BIG; + goto out_free_ranges; + } + + gfn_i--; + kvm->heki_gfn_exec[gfn_i].start = gfn_start; + kvm->heki_gfn_exec[gfn_i].end = gfn_end; + } + + pr_warn("heki-kvm: Locking GFN 0x%llx-0x%llx with %s%s\n", gfn_start, gfn_end, - (attributes & HEKI_ATTR_MEM_NOWRITE) ? "[nowrite]" : ""); + (attributes & HEKI_ATTR_MEM_NOWRITE) ? "[nowrite]" : "", + (attributes & HEKI_ATTR_MEM_EXEC) ? "[exec]" : ""); } + if (has_exec_restriction) + kvm_heki_fix_all_ept_exec_perm(kvm); + out_free_ranges: kfree(ranges); return err; diff --git a/arch/x86/kvm/x86.h b/arch/x86/kvm/x86.h index 3e80a60ecbd8..2127e551202d 100644 --- a/arch/x86/kvm/x86.h +++ b/arch/x86/kvm/x86.h @@ -282,6 +282,8 @@ int heki_check_cr(const struct kvm *kvm, unsigned long cr, unsigned long val); bool kvm_heki_is_exec_allowed(struct kvm_vcpu *vcpu, gpa_t gpa); +bool heki_exec_is_allowed(const struct kvm *const kvm, const gfn_t gfn); + #else /* CONFIG_HEKI */ static inline int heki_check_cr(const struct kvm *const kvm, @@ -290,6 +292,11 @@ static inline int heki_check_cr(const struct kvm *const kvm, return 0; } +static inline bool kvm_heki_is_exec_allowed(struct kvm_vcpu *vcpu, gpa_t gpa) +{ + return true; +} + #endif /* CONFIG_HEKI */ void kvm_inject_realmode_interrupt(struct kvm_vcpu *vcpu, int irq, int inc_eip); diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h index ab9dc723bc89..82c7b02cbcc3 100644 --- a/include/linux/kvm_host.h +++ b/include/linux/kvm_host.h @@ -812,9 +812,13 @@ struct kvm { #define HEKI_GFN_MAX 16 atomic_t heki_gfn_no_write_num; struct heki_gfn_range heki_gfn_no_write[HEKI_GFN_MAX]; + atomic_t heki_gfn_exec_last; + struct heki_gfn_range heki_gfn_exec[HEKI_GFN_MAX]; atomic_long_t heki_pinned_cr0; atomic_long_t heki_pinned_cr4; + + bool heki_kernel_exec_locked; #endif /* CONFIG_HEKI */ #ifdef CONFIG_HAVE_KVM_PM_NOTIFIER diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 4aea936dfe73..a177f8ff5123 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -1232,6 +1232,7 @@ static struct kvm *kvm_create_vm(unsigned long type, const char *fdname) #ifdef CONFIG_HEKI atomic_set(&kvm->heki_gfn_no_write_num, HEKI_GFN_MAX + 1); + atomic_set(&kvm->heki_gfn_exec_last, HEKI_GFN_MAX + 1); #endif /* CONFIG_HEKI */ preempt_notifier_inc(); -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Fri May 05 15:31:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 15:31:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530475.826100 (Exim 4.92) (envelope-from ) id 1puxOp-0006Dm-Bj; Fri, 05 May 2023 15:31:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530475.826100; Fri, 05 May 2023 15:31:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puxOp-0006Df-8o; Fri, 05 May 2023 15:31:11 +0000 Received: by outflank-mailman (input) for mailman id 530475; Fri, 05 May 2023 15:31:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puxOn-0006DZ-Cm for xen-devel@lists.xenproject.org; Fri, 05 May 2023 15:31:09 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d91dfa4f-eb59-11ed-b226-6b7b168915f2; Fri, 05 May 2023 17:31:06 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d91dfa4f-eb59-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683300666; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=pd6I1EXHaLBuaVUf35P+v7jHRWsGbpVWYeZwKsxvbI4=; b=ZB0YRwaXS9HqLH8x2ILKW0zepcElfgKob2wJGOfujFO+GAavNbVJA/nW R5+6Ac5OnoMiG6HLksjs/nw7IL57UStapxr3z5PAFS4G5oxyCoHkduswZ 8CNU6GR/Ofa1rS7bSYUaDvHLtWOypAPFU/TqY6WTX9uFplb6K8Lbf37ah 8=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 106778848 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:sJsI5KoFxnawG7lFbZlWSLf1km5eBmIyZRIvgKrLsJaIsI4StFCzt garIBnXPquDZGPzctslYdm3oUlUucSAnIA2SVNqpS5kFi1Dp5uZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WJwUmAWP6gR5weDzyRNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAB9TTh+Fndm9+rmiWMln2sMAffPuB4xK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFOUslWcOSA3xETdxVRrk6VoqwmpXDe1gVr3JDmMcbPe8zMTsJQ9qqdj jueoTumUkFGZLRzzxKCrW/zvOHEhR/ZXb8KH7+hxNd1jEaMkzl75Bo+CgLg/KjRZlSFc8JSL QkY9zQjqYA29Ve3VZ/tUhugunmGsxUAHd1KHIUSyiuA167V6AaxHXUfQ3hKb9lOnNQtWTUg2 1uNntXoLT9iqruYTTSa7Lj8hSy2ETgYKykFfyBsZQkY59jupqkjgxSJScxseIa8ltDvECv86 yyLpiM5wb4UiKY2O76TpA6dxWj2/96QE1Bzv1+MNo640u9nTKH7R4Ou82PQ1/1ZPqaSEl6i7 UIBoMfLuYjiEqqxeDyxrPQlRe/5vKzYYWSF3jaDDLF6qW3zpifLkZR4pWgneRw3aptslSrBO he7hO9H2HNE0JJGh4dTapn5NcklxLOI+T/NBqGNNYomjnScmWa6EMBSia24hTqFfLAEy/1XB HtiWZ/E4YwmIapm1iGqYOwWzKUmwCszrUuKG8CglU75jePPPCXKIVvgDGZik8hjtP/UyOkr2 4832zS2J+V3D7SlP3i/HX87JlEWN3krba3LRzhsXrfbeGJOQThxY8I9NJt9I+SJaYwJzLaXl px8M2cEoGfCaYrvcFrRMS8/MuOxBf6SbxsTZEQRALph4FB7Ca7H0UvVX8FfkWUPnAC78cNJc g== IronPort-HdrOrdr: A9a23:qVE71q3T0ySNbBavHrvGcgqjBIgkLtp133Aq2lEZdPUCSL3+qy nIpoV56faUslYssR4b8uxoVJPrfZq+z/9ICOsqUotKBzOW3FdARbsKhbcKpQeMJ8SUzIBgPM lbH5SXp7fLfD5HZWqR2njbLz6AquP3lZyVuQ== X-Talos-CUID: =?us-ascii?q?9a23=3A9AH+I2iAWrmViYKK6NNScXjCKDJuXSP9w3HKGES?= =?us-ascii?q?CAn97aLbJTnzBwqZfnJ87?= X-Talos-MUID: =?us-ascii?q?9a23=3AbLj8Kw372EAKKl45AHLNV3l0tTUj5PuzV3oDmo0?= =?us-ascii?q?6mcy5LSdyIgW0kzisXdpy?= X-IronPort-AV: E=Sophos;i="5.99,252,1677560400"; d="scan'208";a="106778848" Date: Fri, 5 May 2023 16:30:52 +0100 From: Anthony PERARD To: Andrew Cooper CC: Xen-devel , George Dunlap , Jan Beulich , "Stefano Stabellini" , Wei Liu , Julien Grall Subject: Re: [PATCH 2/2] LICENSES: Remove the use of deprecated LGPL SPDX tags Message-ID: References: <20230505130533.3580545-1-andrew.cooper3@citrix.com> <20230505130533.3580545-3-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230505130533.3580545-3-andrew.cooper3@citrix.com> On Fri, May 05, 2023 at 02:05:33PM +0100, Andrew Cooper wrote: > --- > LICENSES/GPL-2.0 | 12 ++++++------ > LICENSES/LGPL-2.0 | 8 ++++---- > LICENSES/LGPL-2.1 | 8 ++++---- > > diff --git a/LICENSES/GPL-2.0 b/LICENSES/GPL-2.0 > index 0022a7c17788..dcd969aa85b5 100644 > --- a/LICENSES/GPL-2.0 > +++ b/LICENSES/GPL-2.0 > @@ -1,8 +1,9 @@ > -Valid-License-Identifier: GPL-2.0 > Valid-License-Identifier: GPL-2.0-only > -Valid-License-Identifier: GPL-2.0+ > Valid-License-Identifier: GPL-2.0-or-later > > +Deprecated-Identifier: GPL-2.0 > +Deprecated-Identifier: GPL-2.0+ > + > SPDX-URL: https://spdx.org/licenses/GPL-2.0.html You probably want to update the URLs as well, this one point to a page with a deprecated notice. New url is: https://spdx.org/licenses/GPL-2.0-only.html Same remark for the other licences file changed. Also, maybe they want to be renamed as well, to match the identifier, I'm not sure. Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri May 05 15:35:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 15:35:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530480.826110 (Exim 4.92) (envelope-from ) id 1puxTP-0006re-TN; Fri, 05 May 2023 15:35:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530480.826110; Fri, 05 May 2023 15:35:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puxTP-0006rX-QW; Fri, 05 May 2023 15:35:55 +0000 Received: by outflank-mailman (input) for mailman id 530480; Fri, 05 May 2023 15:35:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puxTN-0006rR-OX for xen-devel@lists.xenproject.org; Fri, 05 May 2023 15:35:53 +0000 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [2a00:1450:4864:20::629]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 84876bdc-eb5a-11ed-b226-6b7b168915f2; Fri, 05 May 2023 17:35:52 +0200 (CEST) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-965d2749e2eso188730766b.1 for ; Fri, 05 May 2023 08:35:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 84876bdc-eb5a-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683300952; x=1685892952; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=31qlMl6bkiI4bRzxC3N4JX9MyFjNBhP97o0bysyL4Rc=; b=niNGKM0LFFqkXMppAj+bYzmkzTsiisqFtDYz2Ro5WDODkbpBxHRUlWGeHheYpVWuK6 TmjoLen0WxGpuoBJ88btqLrqrpddqPupfNtcV4q2j5jHnCEsmWN31z0p/VdajBVEuVxP /HClno6FPtan36OMZs9l9VrpdNVwryYWwhnBlDZWBU9fv+X0v/wusYx8gp1LAYm1mYrG 1r43/L6DUmDygi5XIHnq3ZwyoA3U6deRTP2+iqjFHC9E3fmu6YF4JneN3nCd/Z7MrYau A8/SpQWEAIZlG9nhV22q1lNlgX8Fa+/XuPvcWJQoeyfpjntFfEjE6CckHOrnWUoZCExA DFBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683300952; x=1685892952; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=31qlMl6bkiI4bRzxC3N4JX9MyFjNBhP97o0bysyL4Rc=; b=cHX2kSGRBpik3pSyRwoUogdkcg897eLxXg5CjBrl7iQ86VZE7E83aP5oRaNDU5E/Af SABEWadpLdflgN3CrxQ/BIwBQ/5bWmJ4duUYDnweX/gKQb7a+b3ZAyYJEJuLRFQznMtY WGvFZHnDY7hZ2jGC2Vz2F6PmnBkGU+osSZrUAc6jXMgMvAT9S84utEsXLPjU5qZysHz5 rjqQxremf8G08p6UXjsbm6mLxvPS4xC/9QGWmvk1ehq4CtLwstvHd6QN9eFZtR/dN/vO edmI4D5rUBfOD1FbTHsHqAVDEos4MBGEP37Nbq51bLYiqQQ+QCljLYw5rDWZGoPUSZ3q Vcsg== X-Gm-Message-State: AC+VfDy9DU+uueU2V3Lg5nrAjN/KPPvLZEKlSo7xx9mB2wdA7P7W/RRK qvzOaWvJPjGdTQKDbZq2j7l41+NfsXmAo4VzxYcAfRBZ X-Google-Smtp-Source: ACHHUZ6K+ucZsTkXReKaSLyTS6MXHvsPgDI/+Lt4ZClDTgE2NQfoE9KEzyoCJh20jvOGkN5fGHmw7kAjBmMAo864o9k= X-Received: by 2002:a17:907:6287:b0:962:582d:89d7 with SMTP id nd7-20020a170907628700b00962582d89d7mr1758978ejc.38.1683300951588; Fri, 05 May 2023 08:35:51 -0700 (PDT) MIME-Version: 1.0 References: <20230501193034.88575-1-jandryuk@gmail.com> <20230501193034.88575-5-jandryuk@gmail.com> <43c519f7-577d-f657-a4b1-1a31bf7f093a@suse.com> <7921d24d-7d4d-8829-44bf-b8c2ecd001c8@suse.com> In-Reply-To: <7921d24d-7d4d-8829-44bf-b8c2ecd001c8@suse.com> From: Jason Andryuk Date: Fri, 5 May 2023 11:35:39 -0400 Message-ID: Subject: Re: [PATCH v3 04/14 RESEND] cpufreq: Add Hardware P-State (HWP) driver To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , xen-devel@lists.xenproject.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, May 5, 2023 at 3:01=E2=80=AFAM Jan Beulich wrot= e: > > On 04.05.2023 18:56, Jason Andryuk wrote: > > On Thu, May 4, 2023 at 9:11=E2=80=AFAM Jan Beulich = wrote: > >> On 01.05.2023 21:30, Jason Andryuk wrote: > >>> --- a/docs/misc/xen-command-line.pandoc > >>> +++ b/docs/misc/xen-command-line.pandoc > >>> @@ -499,7 +499,7 @@ If set, force use of the performance counters for= oprofile, rather than detectin > >>> available support. > >>> > >>> ### cpufreq > >>> -> `=3D none | {{ | xen } [:[powersave|performance|ondemand= |userspace][,][,[][,[verbose]]]]} | dom0-kernel` > >>> +> `=3D none | {{ | xen } [:[powersave|performance|ondemand= |userspace][,][,[]][,[]][,[]][,[verbose]]]} | d= om0-kernel` > >> > >> Considering you use a special internal governor, the 4 governor altern= atives are > >> meaningless for hwp. Hence at the command line level recognizing "hwp"= as if it > >> was another governor name would seem better to me. This would then als= o get rid > >> of one of the two special "no-" prefix parsing cases (which I'm not ov= erly > >> happy about). > >> > >> Even if not done that way I'm puzzled by the way you spell out the int= eraction > >> of "hwp" and "hdc": As you say in the description, "hdc" is meaningful= only when > >> "hwp" was specified, so even if not merged with the governors group "h= wp" should > >> come first, and "hdc" ought to be rejected if "hwp" wasn't first speci= fied. (The > >> way you've spelled it out it actually looks to be kind of the other wa= y around.) > > > > I placed them in alphabetical order, but, yes, it doesn't make sense. > > > >> Strictly speaking "maxfreq" and "minfreq" also should be objected to w= hen "hwp" > >> was specified. > >> > >> Overall I'm getting the impression that beyond your "verbose" related = adjustment > >> more is needed, if you're meaning to get things closer to how we parse= the > >> option (splitting across multiple lines to help see what I mean): > >> > >> `=3D none > >> | {{ | xen } [:{powersave|performance|ondemand|userspace} > >> [{,hwp[,hdc]|[,maxfreq=3D[,minfreq= =3D]}] > >> [,verbose]]} > >> | dom0-kernel` > >> > >> (We're still parsing in a more relaxed way, e.g. minfreq may come ahea= d of > >> maxfreq, but better be more tight in the doc than too relaxed.) > >> > >> Furthermore while max/min freq don't apply directly, there are still t= wo MSRs > >> controlling bounds at the package and logical processor levels. > > > > Well, we only program the logical processor level MSRs because we > > don't have a good idea of the packages to know when we can skip > > writing an MSR. > > > > How about this: > > `=3D none > > | {{ | xen } { > > [:{powersave|performance|ondemand|userspace}[,maxfreq=3D[,minf= req=3D]] > > | [:hwp[,hdc]] } > > [,verbose]]} > > | dom0-kernel` > > Looks right, yes. There is a wrinkle to using the hwp governor. The hwp governor was named "hwp-internal", so it needs to be renamed to "hwp" for use with command line parsing. That means the checking for "-internal" needs to change to just "hwp" which removes the generality of the original implementation. The other issue is that if you select "hwp" as the governor, but HWP hardware support is not available, then hwp_available() needs to reset the governor back to the default. This feels like a layering violation. I'm still investigating, but promoting hwp to a top level option - cpufreq=3Dhwp - might be a better arrangement. > >>> +union hwp_request > >>> +{ > >>> + struct > >>> + { > >>> + uint64_t min_perf:8; > >>> + uint64_t max_perf:8; > >>> + uint64_t desired:8; > >>> + uint64_t energy_perf:8; > >>> + uint64_t activity_window:10; > >>> + uint64_t package_control:1; > >>> + uint64_t reserved:16; > >>> + uint64_t activity_window_valid:1; > >>> + uint64_t energy_perf_valid:1; > >>> + uint64_t desired_valid:1; > >>> + uint64_t max_perf_valid:1; > >>> + uint64_t min_perf_valid:1; > >> > >> The boolean fields here would probably better be of type "bool". I als= o > >> don't see the need for using uint64_t for any of the other fields - > >> unsigned int will be quite fine, I think. Only ... > > > > This is the hardware MSR format, so it seemed natural to use uint64_t > > and the bit fields. To me, uint64_t foo:$bits; better shows that we > > are dividing up a single hardware register using bit fields. > > Honestly, I'm unfamiliar with the finer points of laying out bitfields > > with bool. And the 10 bits of activity window throws off aligning to > > standard types. > > > > This seems to have the correct layout: > > struct > > { > > unsigned char min_perf; > > unsigned char max_perf; > > unsigned char desired; > > unsigned char energy_perf; > > unsigned int activity_window:10; > > bool package_control:1; > > unsigned int reserved:16; > > bool activity_window_valid:1; > > bool energy_perf_valid:1; > > bool desired_valid:1; > > bool max_perf_valid:1; > > bool min_perf_valid:1; > > } ; > > > > Or would you prefer the first 8 bit ones to be unsigned int > > min_perf:8? > > Personally I think using bitfields uniformly would be better. What you > definitely cannot use if not using a bitfield is "unsigned char", it > ought to by uint8_t then. If using a bitfield, as said, I think it's > best to stick to unsigned int and bool, unless field width goes > beyond 32 bits or fields cross a 32-bit boundary. Ok, thanks. > >>> +bool __init hwp_available(void) > >>> +{ > >>> + unsigned int eax, ecx, unused; > >>> + bool use_hwp; > >>> + > >>> + if ( boot_cpu_data.cpuid_level < CPUID_PM_LEAF ) > >>> + { > >>> + hwp_verbose("cpuid_level (%#x) lacks HWP support\n", > >>> + boot_cpu_data.cpuid_level); > >>> + return false; > >>> + } > >>> + > >>> + if ( boot_cpu_data.cpuid_level < 0x16 ) > >>> + { > >>> + hwp_info("HWP disabled: cpuid_level %#x < 0x16 lacks CPU fre= q info\n", > >>> + boot_cpu_data.cpuid_level); > >>> + return false; > >>> + } > >>> + > >>> + cpuid(CPUID_PM_LEAF, &eax, &unused, &ecx, &unused); > >>> + > >>> + if ( !(eax & CPUID6_EAX_HWP_ENERGY_PERFORMANCE_PREFERENCE) && > >>> + !(ecx & CPUID6_ECX_IA32_ENERGY_PERF_BIAS) ) > >>> + { > >>> + hwp_verbose("HWP disabled: No energy/performance preference = available"); > >>> + return false; > >>> + } > >>> + > >>> + feature_hwp =3D eax & CPUID6_EAX_HWP; > >>> + feature_hwp_notification =3D eax & CPUID6_EAX_HWP_NOTIFICATIO= N; > >>> + feature_hwp_activity_window =3D eax & CPUID6_EAX_HWP_ACTIVITY_WI= NDOW; > >>> + feature_hwp_energy_perf =3D > >>> + eax & CPUID6_EAX_HWP_ENERGY_PERFORMANCE_PREFERENCE; > >>> + feature_hwp_pkg_level_ctl =3D eax & CPUID6_EAX_HWP_PACKAGE_LEV= EL_REQUEST; > >>> + feature_hwp_peci =3D eax & CPUID6_EAX_HWP_PECI; > >>> + > >>> + hwp_verbose("HWP: %d notify: %d act-window: %d energy-perf: %d p= kg-level: %d peci: %d\n", > >>> + feature_hwp, feature_hwp_notification, > >>> + feature_hwp_activity_window, feature_hwp_energy_perf= , > >>> + feature_hwp_pkg_level_ctl, feature_hwp_peci); > >>> + > >>> + if ( !feature_hwp ) > >>> + return false; > >>> + > >>> + feature_hdc =3D eax & CPUID6_EAX_HDC; > >>> + > >>> + hwp_verbose("HWP: Hardware Duty Cycling (HDC) %ssupported%s\n", > >>> + feature_hdc ? "" : "not ", > >>> + feature_hdc ? opt_cpufreq_hdc ? ", enabled" : ", dis= abled" > >>> + : ""); > >>> + > >>> + feature_hdc =3D feature_hdc && opt_cpufreq_hdc; > >>> + > >>> + hwp_verbose("HWP: HW_FEEDBACK %ssupported\n", > >>> + (eax & CPUID6_EAX_HW_FEEDBACK) ? "" : "not "); > >> > >> You report this, but you don't really use it? > > > > Correct. I needed to know what capabilities my processors have. > > > > feature_hwp_pkg_level_ctl and feature_hwp_peci can also be dropped > > since they aren't used beyond printing their values. I'd still lean > > toward keeping their printing under verbose since otherwise there > > isn't a convenient way to know if they are available without > > recompiling. > > That's fine, but wants mentioning in the description. Also respective > variables would want to be __initdata then, be local to the function, > or be dropped altogether. Plus you'd want to be consistent - either > you use a helper variable for all print-only features, or you don't. Got it, thanks. > >>> + if ( rdmsr_safe(MSR_IA32_ENERGY_PERF_BIAS, val) ) > >>> + { > >>> + hwp_err("error rdmsr_safe(MSR_IA32_ENERGY_PERF_BIAS)\n")= ; > >>> + data->curr_req.raw =3D -1; > >>> + > >>> + return; > >>> + } > >>> + > >>> + data->energy_perf =3D val & IA32_ENERGY_BIAS_MASK; > >>> + } > >> > >> In order to not need to undo the "enable" you've already done, maybe t= hat > >> should move down here? > > > > HWP needs to be enabled before the Capabilities and Request MSRs can > > be read. > > I must have missed this aspect in the SDM. Do you have a pointer? In 15.4.2 Enabling HWP Additional MSRs associated with HWP may only be accessed after HWP is enabled, with the exception of IA32_HWP_INTERRUPT and MSR_PPERF. Accessing the IA32_HWP_INTERRUPT MSR requires only HWP is present as enumerated by CPUID but does not require enabling HWP. > > Reading them shouldn't fail, but it seems safer to use > > rdmsr_safe in case something goes wrong. > > Sure. But then the "enable" will need undoing in the unlikely event of > failure. Yes. Regards, Jason From xen-devel-bounces@lists.xenproject.org Fri May 05 15:40:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 15:40:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530487.826120 (Exim 4.92) (envelope-from ) id 1puxXd-0008NS-H0; Fri, 05 May 2023 15:40:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530487.826120; Fri, 05 May 2023 15:40:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puxXd-0008NL-Dz; Fri, 05 May 2023 15:40:17 +0000 Received: by outflank-mailman (input) for mailman id 530487; Fri, 05 May 2023 15:40:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puxXc-0008NF-I3 for xen-devel@lists.xenproject.org; Fri, 05 May 2023 15:40:16 +0000 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [2a00:1450:4864:20::52c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 215d7988-eb5b-11ed-b226-6b7b168915f2; Fri, 05 May 2023 17:40:15 +0200 (CEST) Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-50bdd7b229cso3759013a12.0 for ; Fri, 05 May 2023 08:40:15 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 215d7988-eb5b-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683301215; x=1685893215; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ow8QnJEELfcaFY4U3gRJU7R7gd8Vy0C9uCYqlaaNapY=; b=UJVF30BB53uSjvbrTD6oKVNzfz6TfDRHMfyOgGso/nWY5ymTWFNtPYYRwZRH/LDlqt /5MKVnjkjBL8BprwfuDvqUSFowSPKS38klsPfqIQhATdM6T8WCikQDPdnYIgLTqEv1MG DpijPPb46l4jKugRYaV7xq4DnGZh/SOxClLjezuiCKL02ebh+SdExMO41Vw9htnKyPaY EIOtGdUajE8DbAR2ct6CIduXrCCKGA5AadsMQYh0eJ3q1BYUe67/oguPoKyg+vwh3dRF DWWlHLVQ0A77nDOJYsFZ0J7YHFahxCCEBKngLiuSXkhTAYu035a4S4M4XLUVQxj8u7Vs +4mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683301215; x=1685893215; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ow8QnJEELfcaFY4U3gRJU7R7gd8Vy0C9uCYqlaaNapY=; b=jyRWp8aYZ9ry5DtvqTUuF6E9xEGIOJSuqOokNiXbBP+KFEzyGzWaTacPkNdIPoydmm fZcw1PNAsjNHRswmiJ0auwcua94cOtyzrlkQWH3ny2O8vUC85rSQCqQeEEBXj7eEgm8a P3Xdp3bdZZtjF7f/0De5rLzg3NpYSCv274aRgDu1Wnpvc7rdeeyU3unP6DV8Saixqqhj qYxt6sxcxvV3IaJQ47HpPIW2bHXH8e3kA7mcReXh+c3sR1du8DFYsKXOFU0GdUWnR52w J54hGgPoaSy3heluc/DuRnF15drsfHoDsUpTdwSDPHNsgr3jPZA0vwov7MBiWVQ0XoAn ZiUA== X-Gm-Message-State: AC+VfDxSLtY3QzwXTPnyhSfybYDf3gGrkVWQLqa2pxm0sD1jq82/ojeP FT51VVDpeDct/NvDTP7P88MI5OGy8NaV8aBJY7I= X-Google-Smtp-Source: ACHHUZ7crrh2ZFeMxB9vLIkmKRR296a7g+ILEk7o9jF9gnSdA6hfcmgh1CbUnSfbrv2P2CYnu+Wyndo+qYrdI1Uu1vY= X-Received: by 2002:a17:907:7250:b0:965:ff38:2fbb with SMTP id ds16-20020a170907725000b00965ff382fbbmr402910ejc.1.1683301214830; Fri, 05 May 2023 08:40:14 -0700 (PDT) MIME-Version: 1.0 References: <20230501193034.88575-1-jandryuk@gmail.com> <20230501193034.88575-6-jandryuk@gmail.com> <2864bf57-88cd-6fce-2d38-6f3a31abb440@suse.com> In-Reply-To: From: Jason Andryuk Date: Fri, 5 May 2023 11:40:03 -0400 Message-ID: Subject: Re: [PATCH v3 05/14 RESEND] xenpm: Change get-cpufreq-para output for internal To: Jan Beulich Cc: Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, May 5, 2023 at 3:04=E2=80=AFAM Jan Beulich wrot= e: > >>> @@ -720,10 +721,15 @@ static void print_cpufreq_para(int cpuid, struc= t xc_get_cpufreq_para *p_cpufreq) > >>> printf(" %d", p_cpufreq->affected_cpus[i]); > >>> printf("\n"); > >>> > >>> - printf("cpuinfo frequency : max [%u] min [%u] cur [%u]\n", > >>> - p_cpufreq->cpuinfo_max_freq, > >>> - p_cpufreq->cpuinfo_min_freq, > >>> - p_cpufreq->cpuinfo_cur_freq); > >>> + if ( internal ) > >>> + printf("cpuinfo frequency : base [%u] turbo [%u]\n", > >>> + p_cpufreq->cpuinfo_min_freq, > >>> + p_cpufreq->cpuinfo_max_freq); > >> > >> ... calling it "turbo" (and not "max") here. > > > > I'm fine with "max". I think I went with turbo since it's a value you > > cannot sustain but can only hit in short bursts. > > ... I don't mind you sticking to "turbo" as long as the description makes > clear why that was chosen despite the SDM not naming it this way. I switched to "max" since as you point out that matches the SDM naming. Regards, Jason From xen-devel-bounces@lists.xenproject.org Fri May 05 15:47:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 15:47:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530491.826129 (Exim 4.92) (envelope-from ) id 1puxek-0000au-8e; Fri, 05 May 2023 15:47:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530491.826129; Fri, 05 May 2023 15:47:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puxek-0000an-5c; Fri, 05 May 2023 15:47:38 +0000 Received: by outflank-mailman (input) for mailman id 530491; Fri, 05 May 2023 15:47:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puxei-0000ah-JJ for xen-devel@lists.xenproject.org; Fri, 05 May 2023 15:47:36 +0000 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [2a00:1450:4864:20::629]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2701f279-eb5c-11ed-8611-37d641c3527e; Fri, 05 May 2023 17:47:34 +0200 (CEST) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-965fc25f009so47886666b.3 for ; Fri, 05 May 2023 08:47:34 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2701f279-eb5c-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683301654; x=1685893654; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=K7a6OP2ZbfbLEcN+mCIl6WNnEQ1CS2Knx9ltqA+VoLI=; b=R1AvNbZqAwJlA3H0R1A+T2HPJ2Zj5UVscGVZpjfbImE5rGBM4MNxQhYvQIR+XVBrFn 3m4JsqJAIFJxRw/njoLt56SrBW3FuBTSONMORidu89m3odaWR0ZIcYHieiQvRWUxj16H cVYSYp/X4VlUpXDksSCC5rIP4VRc3G1g7bQ+PVVNJ+iUO6eJ6nyaQWev6mscWktdNCaA hniLE82vr8l1yp1eOHHv6sEbJ2XSBjNtgr0XMSc+KdaSFBprcbOhltEnj2fWpp1ZXkJ2 kFSOlt0thoskG2rshZF7ShIznTKAFqnX6qHwZzUmFCVKXF6r+18C0lX9X0P9L2jBJ4js mD9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683301654; x=1685893654; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K7a6OP2ZbfbLEcN+mCIl6WNnEQ1CS2Knx9ltqA+VoLI=; b=jMLjoD24EkK48/TuELAqmgeFl3O3Qi0eP0/H8g12GxDvSRFI8cQvQuq0zbPngvFW3T 4prwYladS32JT19hKR/0HABE8RU7Mi1/jG48SnX76Y/kXe6+gv4q7L2Nlh43zpygs4Zy dUQFRuf148Qs2WU3n6KI2LnGZo2R3dl+eD1na58FSQEV2rk+JpRsQqh20g4+cYyetsxd p9TucxrrAurM36a4DIR2PdmeGt+3wo4JiXrWg3XbuI0bvH9CLOu/KFuCrLft9Dp9B5Fz n2Dzoiq8UtHNl/pen0xLUaP6aSs7udrF1FPW/18Kwj9QUSSgv8qhBClKuLPYb/W6J7ht 0qFA== X-Gm-Message-State: AC+VfDyoByORFVCyXUHK6wNnqtkjh4wTaxpxDYUD/A5Cb36jU2VGBblN NfmD2T8/hpsyFLN+N88cIBT4USo0Jp6jT9RYQ3g= X-Google-Smtp-Source: ACHHUZ6hX1NVNdLDX3FwK5tK/XaAcUVGlrMRV5iFAyo2jjZU3aDo2vBO2rgQqXR/dKciAHCN22PumPlOGHa3zLVan2Q= X-Received: by 2002:a17:906:dc92:b0:955:34a5:ae46 with SMTP id cs18-20020a170906dc9200b0095534a5ae46mr1654968ejc.77.1683301653862; Fri, 05 May 2023 08:47:33 -0700 (PDT) MIME-Version: 1.0 References: <20230502143722.15613-1-jandryuk@gmail.com> <43162544.QFhiSxD2Za@silver> In-Reply-To: <43162544.QFhiSxD2Za@silver> From: Jason Andryuk Date: Fri, 5 May 2023 11:47:22 -0400 Message-ID: Subject: Re: [PATCH] 9pfs/xen: Fix segfault on shutdown To: Christian Schoenebeck Cc: qemu-devel@nongnu.org, Greg Kurz , Stefano Stabellini , Anthony Perard , Paul Durrant , "open list:X86 Xen CPUs" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, May 5, 2023 at 6:05=E2=80=AFAM Christian Schoenebeck wrote: > > Hi Jason, > > as this is a Xen specific change, I would like Stefano or another Xen > developer to take a look at it, just few things from my side ... > > On Tuesday, May 2, 2023 4:37:22 PM CEST Jason Andryuk wrote: > > xen_9pfs_free can't use gnttabdev since it is already closed and NULL-e= d > > Where exactly does it do that access? A backtrace or another detailed com= mit > log description would help. The segfault is down in the xen grant libraries during the free callback. The call stack is roughly: xen_pv_del_xendev(struct XenLegacyDevice *xendev) xen_9pfs_free() (->free() callback) xen_be_unmap_grant_refs(&xen_9pdev->xendev, ...) qemu_xen_gnttab_unmap(xendev->gnttabdev, ...) xengnttab_unmap(xgt, ...) <- segfault. The device went through the "disconnect" state before free() is called, so xen_be_disconnect() already ran which did: if (xendev->gnttabdev) { qemu_xen_gnttab_close(xendev->gnttabdev); xendev->gnttabdev =3D NULL; } gnttabdev being used by xengnttab_unmap(). > > out when free is called. Do the teardown in _disconnect(). This > > matches the setup done in _connect(). > > > > trace-events are also added for the XenDevOps functions. > > > > Signed-off-by: Jason Andryuk > > --- > > hw/9pfs/trace-events | 5 +++++ > > hw/9pfs/xen-9p-backend.c | 36 +++++++++++++++++++++++------------- > > 2 files changed, 28 insertions(+), 13 deletions(-) > > > > diff --git a/hw/9pfs/trace-events b/hw/9pfs/trace-events > > index 6c77966c0b..7b5b0b5a48 100644 > > --- a/hw/9pfs/trace-events > > +++ b/hw/9pfs/trace-events > > @@ -48,3 +48,8 @@ v9fs_readlink(uint16_t tag, uint8_t id, int32_t fid) = "tag %d id %d fid %d" > > v9fs_readlink_return(uint16_t tag, uint8_t id, char* target) "tag %d i= d %d name %s" > > v9fs_setattr(uint16_t tag, uint8_t id, int32_t fid, int32_t valid, int= 32_t mode, int32_t uid, int32_t gid, int64_t size, int64_t atime_sec, int64= _t mtime_sec) "tag %u id %u fid %d iattr=3D{valid %d mode %d uid %d gid %d = size %"PRId64" atime=3D%"PRId64" mtime=3D%"PRId64" }" > > v9fs_setattr_return(uint16_t tag, uint8_t id) "tag %u id %u" > > + > > Nit-picking; missing leading comment: > > # xen-9p-backend.c Will do, thanks. > > +xen_9pfs_alloc(char *name) "name %s" > > +xen_9pfs_connect(char *name) "name %s" > > +xen_9pfs_disconnect(char *name) "name %s" > > +xen_9pfs_free(char *name) "name %s" > > diff --git a/hw/9pfs/xen-9p-backend.c b/hw/9pfs/xen-9p-backend.c > > index 0e266c552b..c646a0b3d1 100644 > > --- a/hw/9pfs/xen-9p-backend.c > > +++ b/hw/9pfs/xen-9p-backend.c > > @@ -25,6 +25,8 @@ > > #include "qemu/iov.h" > > #include "fsdev/qemu-fsdev.h" > > > > +#include "trace.h" > > + > > #define VERSIONS "1" > > #define MAX_RINGS 8 > > #define MAX_RING_ORDER 9 > > @@ -337,6 +339,8 @@ static void xen_9pfs_disconnect(struct XenLegacyDev= ice *xendev) > > Xen9pfsDev *xen_9pdev =3D container_of(xendev, Xen9pfsDev, xendev)= ; > > int i; > > > > + trace_xen_9pfs_disconnect(xendev->name); > > + > > for (i =3D 0; i < xen_9pdev->num_rings; i++) { > > if (xen_9pdev->rings[i].evtchndev !=3D NULL) { > > qemu_set_fd_handler(qemu_xen_evtchn_fd(xen_9pdev->rings[i]= .evtchndev), > > @@ -345,40 +349,42 @@ static void xen_9pfs_disconnect(struct XenLegacyD= evice *xendev) > > xen_9pdev->rings[i].local_port); > > xen_9pdev->rings[i].evtchndev =3D NULL; > > } > > - } > > -} > > - > > -static int xen_9pfs_free(struct XenLegacyDevice *xendev) > > -{ > > - Xen9pfsDev *xen_9pdev =3D container_of(xendev, Xen9pfsDev, xendev)= ; > > - int i; > > - > > - if (xen_9pdev->rings[0].evtchndev !=3D NULL) { > > - xen_9pfs_disconnect(xendev); > > - } > > - > > - for (i =3D 0; i < xen_9pdev->num_rings; i++) { > > if (xen_9pdev->rings[i].data !=3D NULL) { > > xen_be_unmap_grant_refs(&xen_9pdev->xendev, > > xen_9pdev->rings[i].data, > > xen_9pdev->rings[i].intf->ref, > > (1 << xen_9pdev->rings[i].ring_ord= er)); > > + xen_9pdev->rings[i].data =3D NULL; > > } > > if (xen_9pdev->rings[i].intf !=3D NULL) { > > xen_be_unmap_grant_ref(&xen_9pdev->xendev, > > xen_9pdev->rings[i].intf, > > xen_9pdev->rings[i].ref); > > + xen_9pdev->rings[i].intf =3D NULL; > > } > > if (xen_9pdev->rings[i].bh !=3D NULL) { > > qemu_bh_delete(xen_9pdev->rings[i].bh); > > + xen_9pdev->rings[i].bh =3D NULL; > > } > > } > > > > g_free(xen_9pdev->id); > > + xen_9pdev->id =3D NULL; > > g_free(xen_9pdev->tag); > > + xen_9pdev->tag =3D NULL; > > g_free(xen_9pdev->path); > > + xen_9pdev->path =3D NULL; > > g_free(xen_9pdev->security_model); > > + xen_9pdev->security_model =3D NULL; > > g_free(xen_9pdev->rings); > > + xen_9pdev->rings =3D NULL; > > + return; > > +} > > + > > +static int xen_9pfs_free(struct XenLegacyDevice *xendev) > > +{ > > + trace_xen_9pfs_free(xendev->name); > > + > > return 0; > > } > > xen_9pfs_free() doing nothing, that doesn't look right to me. Wouldn't it= make > sense to turn xen_9pfs_free() idempotent instead? The callbacks are: .alloc =3D xen_9pfs_alloc, .init =3D xen_9pfs_init, .initialise =3D xen_9pfs_connect, .disconnect =3D xen_9pfs_disconnect, .free =3D xen_9pfs_free, .initialise (connect) and .disconnect are matched operations. So .disconnect should be cleaning up from .connect, which this patch implements. Also, neither xen_9pfs_alloc() nor xen_9pfs_init,() perform any allocations, so that is why the .free callback is now empty. Thanks for taking a look! Regards, Jason From xen-devel-bounces@lists.xenproject.org Fri May 05 15:53:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 15:53:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530495.826140 (Exim 4.92) (envelope-from ) id 1puxk2-00022q-Te; Fri, 05 May 2023 15:53:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530495.826140; Fri, 05 May 2023 15:53:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puxk2-00022j-Q4; Fri, 05 May 2023 15:53:06 +0000 Received: by outflank-mailman (input) for mailman id 530495; Fri, 05 May 2023 15:53:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puxk1-00022d-6c for xen-devel@lists.xenproject.org; Fri, 05 May 2023 15:53:05 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id eaae084d-eb5c-11ed-b226-6b7b168915f2; Fri, 05 May 2023 17:53:04 +0200 (CEST) Received: from mail-mw2nam10lp2100.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.100]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 May 2023 11:53:01 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM4PR03MB6157.namprd03.prod.outlook.com (2603:10b6:5:398::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.27; Fri, 5 May 2023 15:52:57 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::4fc:e616:1cf0:57bb%4]) with mapi id 15.20.6363.027; Fri, 5 May 2023 15:52:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eaae084d-eb5c-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683301984; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=Sm0s9iLiLjSWIAhlHKEV5b7kBNV8HdDQ0OE9VOheIGc=; b=WQJG0GZjArUAdK9UPJTIrUIOspuuvapoQPpcdbeNLm97UD4H2rpLZx81 MaeZDGJDcELSec2lNEUP4T9SYwzm0ZsN8HQa+jvdCJJ/JfOSfppN+vpL8 nD5d5rifi7OgD7OFhHhaB6oshtD1vTzFoH5abTzt70bTUOpxhAFBH9EOm E=; X-IronPort-RemoteIP: 104.47.55.100 X-IronPort-MID: 106781722 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:jPI3pa/EMlGyIaVxqDWJDrUDVX+TJUtcMsCJ2f8bNWPcYEJGY0x3y WMeDGzXPviPa2CmKthwbNvi8hwHscXcy9JmQAQ9+Cs8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kI+1BjOkGlA5AdmOKgW5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklB1 tEbBzIRaSvZrOGM5+KAdrR+re4KeZyD0IM34hmMzBn/JNN/GdXmfP+P4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWOilUpiNABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTAdpMS+3hqaQw6LGV7jNMBF4JVH62m+W0iQmPB/EYc 3ZE5CV7+MDe82TuFLERRSaQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3OcUbzE30 l6Cn/vyGCdi9raSTBq17ayIpDm/PSwUK24qZiIeSwYBpd75r+kbkRbnXttlVqmvgbXdGyz0w j2MhDgzgfMUl8Fj6kmg1VXOgjbpo4eTSAcwv13TRjj8tls/Y5O5bYu171Sd9exHMIuSUliGu j4DhtSa6+cNS5qKkURhXdkwIV1g3N7dWBW0vLKlN8JJG+iFk5J7Qb1t3Q== IronPort-HdrOrdr: A9a23:mVFTCKg221Vv/9cObtyo9GDf93BQXmEji2hC6mlwRA09TyVXra GTdZMgpHnJYVcqKRYdcLW7UpVoLkmwyXcY2+Us1PKZLWrbUIXBFvAf0WKg+UycJ8XGntQtqp uICpIOduEYb2IbsS+K2njdLz96+qj/zEnAv463pEuFDzsaCZ2IiT0XNu/xKDwSeOApP/QE/b Onl7t6jgvlV3QLT9ixQkIIV/LEoLTw5ejbSC9DKR47yRWEyQil4r7iExSew34lIkhy6IZn32 jZshDzop6uufGjyhPayiv64plMlMH6o+EzdPCku4w6KijMlg3tXohnVrGY1QpF2N2S1A== X-Talos-CUID: 9a23:wMiFvmGef5vLcef8qmJo12MXNcI5dUaH53TqBB+DNTt7Y5e8HAo= X-Talos-MUID: 9a23:2uUruAVml9q7oCbq/GCziHJ9NeJl2bijCwc8zbZB4/PUKyMlbg== X-IronPort-AV: E=Sophos;i="5.99,252,1677560400"; d="scan'208";a="106781722" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=chCObT9cUWg4Nc/GOOjYrFuunw80VZy3hjHG3xAeG18yezY8Fo0X5gEprlyJRgidR79r31aYT5VD9pBoCJKnEYzqkRoRsn7/TX5mv7NLSE8jgeymCCDxDRYEFLpiNErVfO1RBjyzLRAETWqKYrpVChcmjt3N4A4X7kfiogCnNv8BFCDBhw8fUWwHvnEeIGZQxo1ot8Cwe7T/XdmjZGnxZy/51k3QQT55/NxD/wrcRSbLOqm5N0L0QdGj4b+FQiI+cRahjhlLJMvQPT2cwjMco3Mp+DbyiVomrW4kaxxqC238BQ2c3FYm0HVTtEReZiIo4A7VcF9WWczMF/CiISKYqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fydBFIE5i5DlViiY+5e/fD7VTQF/UTnKjl+sl9XhRgE=; b=g3YUyzYZRyB2RmrZklqlfLssmomabhJ5nIneI/h4ezjm5DMnhCdU5ZF/ykuYMZ5ScLldlgRPM+E7zcF6hFCaYJkcDCJwQpBAheGNF8UvM8RUuW1Ia9mPP0WArvV+uta21hTxAuwbeEl1SaF5gV3k8VhSB1kL7xPDFeqnwAe2bFeGBkNM49mk76U9ena73otjGekcF8cBqEXoxkSOVfT5OmF/Nfir9Vkoe/uOHqkFKlPpMOZthonu1+nURbt1Kudyne8pHUHeXwtBeJ/HB7vUcnAKHu6UxzPb9OdDGrSI6kPYRNdgO4seUP8gMbjaWMKWZkDsIrIrMwYCIKhs70urfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fydBFIE5i5DlViiY+5e/fD7VTQF/UTnKjl+sl9XhRgE=; b=EBj/G74iOGGASfENyf1UwE9BsQYSadthU8zTa3UIYm61lJ2zQCGO6AdoS5QDE2IjWYZ8JbU2x1wSqaFgF668+4N7Aj7UpI+sOEmmGyTT6ulR+NCfgTR5J8m5AS8e2rSglHOg+hsEtl6FMGRfFKJo/VDQnRxw/zb99Ot1irADJfM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <99d08cef-3797-ebe2-d9e9-8cf6dd49ed9c@citrix.com> Date: Fri, 5 May 2023 16:52:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: Andrew Cooper Subject: Re: [PATCH 2/2] LICENSES: Remove the use of deprecated LGPL SPDX tags Content-Language: en-GB To: Anthony PERARD Cc: Xen-devel , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Julien Grall References: <20230505130533.3580545-1-andrew.cooper3@citrix.com> <20230505130533.3580545-3-andrew.cooper3@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0417.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18b::8) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|DM4PR03MB6157:EE_ X-MS-Office365-Filtering-Correlation-Id: c2cb5b7b-152b-45e8-80f0-08db4d80cb05 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7QxzjctcORRJNHFGHAvF040qxnRYM1xse7wbpLvl+lK0YO9uHvKkEsTvhuuRlG7DUefHtp1jPa2iRIr+Tved5LYy6kv6528A/h68jL03mnkqFM8GXCanCxp7M3DaHmAellmt9FgRcYVyiHd2igyTlSbHELghD/Aw9DaUzQ+J0El4PLZ1iLp0hVZ9E+T9bdVSDkJcSF729bjsxMGyO9d2Zrmfxh35aKcKJLRyZfAQk2cBRU/RwfJMd35XBGkkOJafYsD7FEcAY+r1zWHGOPFter7SGSDBD3GgfTdncJFbXCi/C3g0A9xF4Sk3H/By2bGUI9vqPfDawhVus56JF6TlEnVjeOStJnMCBx1THBqW5y9h+MIkYBoKKoaVtwqD1DAPKUdHEIJbKTLtCh9qtr9wmUADpWIFTGrml/Pk3dO+cUmpb3+qn+jnPkAtKLvoMVOE9Q3LsmhvrLgpW47/h87/3uiSRfXIE63Na9qPYNH8QYUGyh2JzytK7MHjK1sP7dXexBM8AQvtwm2XyHOMkOH95TX+DtkbtUVQ0M2mmN46fCzOgcFIHqeTcOsdzblhfWrjRvUE71oqzlF8uE9L0yYWMkl6CCDbrkTBOXGOsQ+pqfczWw/9oAigsp9uTC6BAa9ZjgI4PP2nQ5yNTpFD1HH24A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(39860400002)(136003)(366004)(376002)(451199021)(31686004)(6666004)(6486002)(478600001)(36756003)(82960400001)(38100700002)(2616005)(83380400001)(2906002)(26005)(54906003)(37006003)(966005)(186003)(53546011)(6512007)(6506007)(5660300002)(41300700001)(8936002)(8676002)(6862004)(86362001)(31696002)(66476007)(66556008)(4326008)(6636002)(66946007)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzU1TFVJNWE0c2hlWHF0YVE5SHJ0M1h0QVE3MENwZm9SMlFCYXd0MEJtSzlR?= =?utf-8?B?bVZUdlI4a1VWODM3a1pLYndNcTBSMGdhV2FxdGt0VkZzd1dVTmNHc2JyY0dO?= =?utf-8?B?UVNvMFY1T1d2QnBkbXUyV3krY21lQTdiZ0ZtTVg2TmdpLzRnMXhhdDFldmZt?= =?utf-8?B?Vkl5SWc5YUw1ZXZtNldiM2ZuOHplT3MrRXcxKzhSOVFsLzU4VFhWTmd1UFk3?= =?utf-8?B?NFBiVUxMUDZ4VGk4UHBueUR3U3F2TmtUenZiczdzZG5pZm9Ga1VqRUNCanBj?= =?utf-8?B?U3REaGdPay9aa3p2VC9HQzltRjh1UTJiMU5uMjNsbUE1WDFvOVRaWnZ6Q3VP?= =?utf-8?B?c2JJelNZSGx0cmxsN0QwbEVEMHl6MDN4TURzYlhxTkZ3ZEl1bm1CK1gwZ0Fh?= =?utf-8?B?ZzcwZ1Q1RlJ5UzdCMmw0b1NFelRYamk1QWJQajg2bmJCckoyKzgrazM1Z08w?= =?utf-8?B?WWloV3E3M3Qzc0NIbGRyOUsrcEt5M1A4MzNqR0FGaldZUEE3UHpWMFZOWGJ4?= =?utf-8?B?UUxKOXpZYkYvSVdLcWVXbzk0U0dSRkp2UnhuRkplRGJWdU1TMmZ2QVVmL3J4?= =?utf-8?B?cHh4K1h5dHNqRVdUelNjL1ZqeDVKRWt3aExZb0dseTNkNzBMaUNmSnUrNmN4?= =?utf-8?B?WE1sK1NWQTVOTWEybU9PK2lmMWlFUW9GV2kzMDA0U1kzWkJ6OVV2bVc5dkJR?= =?utf-8?B?Y2QwVnB2TDI5UGp2ZmhTMk9Ya25iT1NyRFdDTVJTRTNWNEk1S2x5cDdoYUUx?= =?utf-8?B?bGYyWnF2N05oKzlHeTZMMzQ1S2VBZ1p3T01aSldaMEpOSnlZTzc2ejBiczRW?= =?utf-8?B?cDdwWHdUSmt6MTErUVp5ZEgwZkE2dTRDUmZXazAxZno5WlpDamNodk11NzRR?= =?utf-8?B?bWJIQjFnRkVodlVHeVdYMzUyV21IVUJ3d2oyckcrK0RZcUk2bU15azc0bDFI?= =?utf-8?B?d21tMHFvdVdjbVU4K3A4ODhZemtkMFlTRkdLRWpuZk5xTmFOUjBPMXpQQUtk?= =?utf-8?B?MUwrZ2lqanNMOXZtKy9xdk1zam0wcnlwUk1vM09XQmdJd2JLM3pwZjJranJr?= =?utf-8?B?eHZtaEkxeHA4TXJuRkxRbmpUNUdkdDBUTWpKbncvdSt5S1lHdldRanlwRysx?= =?utf-8?B?VFRMS04rc3AzUkV1cmNlYXNiK3AvS3VaQ1JpVURod0hSSGRDL3pHRFNkVkV4?= =?utf-8?B?VFl6ekRCbDQxYmd1M1l5ZzgzUEkwaW9VYzl6VWJWSHg0KzhLSXBwRWdlY081?= =?utf-8?B?UzdUbW95NkFYdmJDTXAwQlU4OWJJcG5uUkordFNIVlpmUzlvam50eTF6UEZ3?= =?utf-8?B?QU81ZVhkTVVzUnkrcFdkSnNQbnBnY2RGNVVtckFPb0JuZjBuaXYxczExbXh1?= =?utf-8?B?bjVJUEphOGhPeGZvN3hsT0RyQTJ4NGRMSFhNTG1IK0hzenNVcUs0Ky9uSmJM?= =?utf-8?B?R2Nkc3E1T3phSnpSZ2JBT0N4VE8rdEszcXVrNFVOdUhVYjJ0T0hERUJGZzFR?= =?utf-8?B?VWkrOU4xSWZDS1R5a0ZrR1haa2NGY2R3QkJrck1HdThBTjgvZzJXd2VjTDMy?= =?utf-8?B?QTE2WDZEVkVmc0s0ZjJDOVE3WTNQR2JoWFBVdm9qM2FlVWkzeHJiTVlVN1dB?= =?utf-8?B?MGVCcmNlK3hlVVBnaUpySW9rcW0weHBrYUhpRmUvNGlQK1VPWFNEYUxnZ1lY?= =?utf-8?B?Y1ErbFlDellsRmxpemtZbE5mSFNFemRsbk4zNFlPQnZ4bGtCT1BaYm9zbFg5?= =?utf-8?B?SDVjR1lURnpURmdacVlKUzNuZGwyNG54Q1dPWWNYSnFkK3FCakhHbUtqWUJY?= =?utf-8?B?SVNrSmZsb1JhQWtuVFE5Z2M3YjVoWmdkUUJTT3l4d2czK3JRcmEyYi91aStG?= =?utf-8?B?VkZ6OGh4ckRSRCs0MzU5TUU5SStVbFQ5K25VQnREZGZFcDVDcEtpTnNvVTJp?= =?utf-8?B?T2JTR0svQk0wK2JzRUlzcXF4SjQ4bE43WEl3eUFBSjJqaDdGQ0prcEtqNUx6?= =?utf-8?B?NXFNQzJ5RnVZSURENTcxTUNrbUhiZmFJS3NQdTVaRnFRUVFkVW5hWUJreGlR?= =?utf-8?B?QkZHa3pqc0t2U2k1aE5NMENhRnE0eFkzWVNTTE5xSjl5U0NyR2o1clM1aW9x?= =?utf-8?B?Vm42NlFiaFp0cjZIV2tBdWYvTHRpQXJWNkFPNVlBRGNDNmFwV1poWSt6NXNj?= =?utf-8?B?VlE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 4wjvGzmeYOZvvHlTi7vNURyutoInjjwRHCHL3K8tpc073zb5Yn4OfxZdBIUikdTfuSOPIsoFrNL1RWQnLtoM+XUcWxA3ANWC48re/WKD4wq7TIUwRDq0Etmu2fX4R23Qe46sIKJGoRK4AMgxMaIn2TF57tvHjVCLQEOVEkohgyZnBYq7P36rGxPXR+cs01XOY0kVvTK5wnJV+juuN4zUJT9NYguHQHPhAxikMP8MXeimCb3KXcur1rbda8TbM9VTEh67hDE5Fh6PPKYCuUTkTgUzkHywue1ppTrXxFvzjFTE97oPVs1zT9GiKmb7J0d3Da6hXAS035vpmUE8Cfix9ZD+B8YHa5XFp9K0e2kZbbOULp6VURADFlj1M+GWtoE6aX4+W2CVd1S1jt5nUZFqA+FpbDgNxwbSUsqMM3AiNmJVRg/dtNEqtkhhfM1C+D1U+UBb7vIb9XiZT/uv/u5nVLI4a/lDOj1t3Enjue95+qxY9uNT58KKG/mtVprVrnW47rtYq9mKh8QODLy5SGfBBk1PoGQV+tVqB74Q6o8zDudMoWXONgmZvXp0L3krp7l/TJw6GsIhP7Acale+12uRH+lBLuENBgyIvoZpPnwrtQw06YyQazoXkottCti5P6BtRxtelQGTrMNea9Y6ohNsVYrkY0epcsiUHXduhEOFH8wgPG/1R5xgaF1XdmNzqbMmhyqq5Bf0xdSLULfrSGLIgFIKiySZnzv7YsPqOFqxI6ngsU7jlvCVd1hLChTJM00uvmUvTMP5dfT/pwViDCimZsf6zccSpJIctj4qht9NUOPpvwnljn8LvyO6S6x8JxqawPREW9FQRRsUjW4IhXFl/rcasImQ/1247O+9T7y7t3M= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: c2cb5b7b-152b-45e8-80f0-08db4d80cb05 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 15:52:56.6417 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: p92S88biTvrHLcGhnd2jy7PuhDXKNcdrIw3g4VhCpteBeOFD4vxQG1zVjLYeTIs2OxWN4u6xeqV61Diw8DZZ7qQKoVjDxdD4Dlx9ezOVcos= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6157 On 05/05/2023 4:30 pm, Anthony PERARD wrote: > On Fri, May 05, 2023 at 02:05:33PM +0100, Andrew Cooper wrote: >> --- >> LICENSES/GPL-2.0 | 12 ++++++------ >> LICENSES/LGPL-2.0 | 8 ++++---- >> LICENSES/LGPL-2.1 | 8 ++++---- >> >> diff --git a/LICENSES/GPL-2.0 b/LICENSES/GPL-2.0 >> index 0022a7c17788..dcd969aa85b5 100644 >> --- a/LICENSES/GPL-2.0 >> +++ b/LICENSES/GPL-2.0 >> @@ -1,8 +1,9 @@ >> -Valid-License-Identifier: GPL-2.0 >> Valid-License-Identifier: GPL-2.0-only >> -Valid-License-Identifier: GPL-2.0+ >> Valid-License-Identifier: GPL-2.0-or-later >> >> +Deprecated-Identifier: GPL-2.0 >> +Deprecated-Identifier: GPL-2.0+ >> + >> SPDX-URL: https://spdx.org/licenses/GPL-2.0.html > You probably want to update the URLs as well, this one point to a page > with a deprecated notice. New url is: > https://spdx.org/licenses/GPL-2.0-only.html > > Same remark for the other licences file changed. > > Also, maybe they want to be renamed as well, to match the identifier, > I'm not sure. Hmm, all good points.  I'll update the URLs because that's easy. For the files however, the GPL ones already discuss both the "only" or "or-later" forms, so the filename already doesn't match the SDPX tag specifically.  I think I'll leave them as-are. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri May 05 16:08:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 16:08:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530500.826150 (Exim 4.92) (envelope-from ) id 1puxyu-0004CD-6w; Fri, 05 May 2023 16:08:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530500.826150; Fri, 05 May 2023 16:08:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puxyu-0004C6-2s; Fri, 05 May 2023 16:08:28 +0000 Received: by outflank-mailman (input) for mailman id 530500; Fri, 05 May 2023 16:08:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puxys-0004C0-MH for xen-devel@lists.xenproject.org; Fri, 05 May 2023 16:08:26 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0f2916e0-eb5f-11ed-b226-6b7b168915f2; Fri, 05 May 2023 18:08:24 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0f2916e0-eb5f-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683302904; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=WFyZWrUsXdHPFST0v+jPBBnw/xYyynxZT39SG+tzogw=; b=V8jpbFH0ZR3YqxEQNRVXXDUAL7SToqm/wncRY8ZpImVPjICow67ZotHl VrBCSxNxsRb0TfMBkp6hEGexAjGNzjyF4ylJrolkomTU/JIZTLJ2qn+Ks 2jKbp2Re+ESnfBqmFN4xb7yGyZT6DH/ThY1caOO4k41fnrFYA3MAaPaQk I=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 108428034 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:3+8r5qzNCsK8S2c4dyd6t+cdxirEfRIJ4+MujC+fZmUNrF6WrkUFz mMeWWjSOf+INjSnLtsnbYnko00DsZ/Sx9UwTQdu+CAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UIHUMja4mtC5QRjPa0T5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KWBU3 /YqNwxRUhKCibut/5bjZcZG3dt2eaEHPKtH0p1h5TTQDPJgSpHfWaTao9Rf2V/chOgXQ6yYP ZBAL2MyMlKZOUYn1lQ/UfrSmM+hgGX/dDtJ7kqYv6Mt70DYzRBr0airO93QEjCPbZwNzhrC9 jqdowwVBDkGEpuP6zyB9kvrobHzsz+4YIkvPuSBo6sCbFq7mTVIVUx+uUGAifuzh1O6WtlfA 1cJ4Sdopq83nGS7Q9+4UxCmrXqsuh8HR8EWA+A88BuKyKff/0CeHGdsZjxcbN0rsucmSDps0 UWG9/vyHiBmurCRTXOb95+XoCm0NCxTKnUNDQcbSSMV7t+lp5s85jrGVtt5GbS5psH0Ezr3h TuNqUADa6471JBRkf/hpBae3mzq/8KSJuIo2unJdmO/xAlLe7L5W46p5wHA0tIYA6mzFUbU6 RDohPOiAPAy4YClzXLdG79QTejwuJ5pIxWH3wcxQsBJGyCFvif6INsOuGwWyFJBaJ5sRNP/X KPEVeq9Drd3NWDiU6J4apnZ5y8Cnfm5ToSNuhw5g7NzjnlNmOyvpnsGiba4hTyFraTVufhX1 W2nWcitF20GLq9s0SC7QewQuZdymHBlnzmNGcmql0/4uVZ7WEN5tJ9faAfeBgzHxPrsTPrpH yZ3aJLRlkQ3vBzWaSjL648DRW03wYwALcmu8aR/L7fTSjeK7Ul9U5c9N5t9Id0690mU/8+Ul kyAtrhwkQWk3iKbc1XUMhiOqtrHBP5CkJ7yBgR0VX7A5pTpSdzHAHs3H3fvQYQayQ== IronPort-HdrOrdr: A9a23:R/nPka8LOhLzFriCjfxuk+DjI+orL9Y04lQ7vn2ZKCYlCvBw8v rF8cjzuiWE7Ar5NEtQ/+xoW5PgfZq/z+8R3WB5B97LNzUO3lHYT72KwrGSoQEIcBeOkdK1u5 0QCpSWy+eeMbG5t6rHCcWDferICePmzJyV X-Talos-CUID: =?us-ascii?q?9a23=3AZ4WfXGpkvYK46aH+gJGhaA7mUcE/WHfv00uMH02?= =?us-ascii?q?5Bz9yd5nNZnC6o7wxxg=3D=3D?= X-Talos-MUID: 9a23:13e6HwWJqmxYtDDq/CPKwyFAMsNs2uOJVnwjjdY+sPSubBUlbg== X-IronPort-AV: E=Sophos;i="5.99,252,1677560400"; d="scan'208";a="108428034" Date: Fri, 5 May 2023 17:08:12 +0100 From: Anthony PERARD To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , "Andrew Cooper" , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH RFC] build: respect top-level .config also for out-of-tree hypervisor builds Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Wed, Mar 15, 2023 at 03:58:59PM +0100, Jan Beulich wrote: > With in-tree builds Config.mk includes a .config file (if present) from > the top-level directory. Similar functionality is wanted with out-of- > tree builds. Yet the concept of "top-level directory" becomes fuzzy in > that case, because there is not really a requirement to have identical > top-level directory structure in the output tree; in fact there's no > need for anything top-level-ish there. Look for such a .config, but only > if the tree layout matches (read: if the directory we're building in is > named "xen"). Well, as long as the "xen/" part of the repository is the only build system to be able to build out-of-srctree, there isn't going to be a top-level .config possible in the build tree, as such .config will be outside of the build tree. Reading outside of the build tree or source tree might be problematic. It's a possibility that some project might want to just build the hypervisor, and they happened to name the build tree "xen", but they also have a ".config" use for something else. Kconfig is using ".config" for other reason for example, like we do to build Xen. It might be better to have a different name instead of ".config", and putting it in the build tree rather than the parent directory. Maybe ".xenbuild-config" ? I've been using the optional makefile named "xen-version" to adjust variable of the build system, with content like: export XEN_TARGET_ARCH=arm64 export CROSS_COMPILE=aarch64-linux-gnu- so that I can have multiple build tree for different arch, and not have to do anything other than running make and do the expected build. Maybe that's not possible because for some reason, the build system still reconfigure some variable when entering a sub-directory, but that's a start. > Signed-off-by: Jan Beulich > --- > RFC: The directory name based heuristic of course isn't nice. But I > couldn't think of anything better. Suggestions? I can only thing of looking at a file that is in the build-tree rather than outside of it. A file named ".xenbuild-config" proposed early for example. > RFC: There also being a .config in the top-level source dir would be a > little problematic: It would be included _after_ the one in the > object tree. Yet if such a scenario is to be expected/supported at > all, it makes more sense the other way around. Well, that would mean teaching Config.mk about out-of-tree build that part of the repository is capable of, or better would be to stop trying to read ".config" from Config.mk, and handle the file in the different sub-build systems. Or just let people writing ".config" files to handle the cases in those .config files. > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -236,8 +236,17 @@ endif > > include scripts/Kbuild.include > > -# Don't break if the build process wasn't called from the top level > -# we need XEN_TARGET_ARCH to generate the proper config > +# Don't break if the build process wasn't called from the top level. We need > +# XEN_TARGET_ARCH to generate the proper config. If building outside of the > +# source tree also check whether we need to include a "top-level" .config: > +# Config.mk, using $(XEN_ROOT)/.config, would look only in the source tree. > +ifeq ($(building_out_of_srctree),1) > +# Try to avoid including a random unrelated .config: Assume our parent dir > +# is a "top-level" one only when the objtree is .../xen. > +ifeq ($(patsubst %/xen,,$(abs_objtree)),) > +-include ../.config > +endif > +endif > include $(XEN_ROOT)/Config.mk > > # Set ARCH/SUBARCH appropriately. > --- a/xen/Rules.mk > +++ b/xen/Rules.mk > @@ -17,6 +17,13 @@ __build: > > -include $(objtree)/include/config/auto.conf > > +# See commentary around the similar contruct in Makefile. > +ifneq ($(abs_objtree),$(abs_srctree)) > +ifeq ($(patsubst %/xen,,$(abs_objtree)),) > +../.config: ; > +-include ../.config > +endif > +endif > include $(XEN_ROOT)/Config.mk > include $(srctree)/scripts/Kbuild.include There's another makefile, "scripts/Makefile.clean", doesn't this would need to be change as well? Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri May 05 16:18:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 16:18:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530506.826160 (Exim 4.92) (envelope-from ) id 1puy8j-0005lk-5w; Fri, 05 May 2023 16:18:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530506.826160; Fri, 05 May 2023 16:18:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puy8j-0005ld-2Z; Fri, 05 May 2023 16:18:37 +0000 Received: by outflank-mailman (input) for mailman id 530506; Fri, 05 May 2023 16:18:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puy8i-0005lR-NW; Fri, 05 May 2023 16:18:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puy8i-0007mo-Ey; Fri, 05 May 2023 16:18:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puy8i-0006LD-2T; Fri, 05 May 2023 16:18:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1puy8i-0002La-23; Fri, 05 May 2023 16:18:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=FTotJuaW/kVwuxIFvlNRhJTZkL4ORsVb+8QxO1S+ZPY=; b=6uX9KZ9MP926+PqHGANr+qAFc1 jwzsI/g2C7gbkHeR5NJ8rb8DL+vhVRyyzsF+N1RVzMcfYUPbD9vQzvatp0Js8RtOfvjSRPTeyP/w+ DTRBem9MWo7jk4Cbnc6MRYezeMNkh6rNgTChL7detcEGPXM0AAdZyPVCJtkRQ58OgGgY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180545: all pass - PUSHED X-Osstest-Versions-This: ovmf=b65c0eed6bc028388d790fe4e30a76770ebb46c4 X-Osstest-Versions-That: ovmf=757f502a3b350436877102c3043744e021537c19 From: osstest service owner Date: Fri, 05 May 2023 16:18:36 +0000 flight 180545 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180545/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b65c0eed6bc028388d790fe4e30a76770ebb46c4 baseline version: ovmf 757f502a3b350436877102c3043744e021537c19 Last test of basis 180544 2023-05-05 12:12:07 Z 0 days Testing same since 180545 2023-05-05 14:12:15 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Dongyan Qian jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 757f502a3b..b65c0eed6b b65c0eed6bc028388d790fe4e30a76770ebb46c4 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri May 05 16:23:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 16:23:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530512.826169 (Exim 4.92) (envelope-from ) id 1puyDQ-0007DC-Ok; Fri, 05 May 2023 16:23:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530512.826169; Fri, 05 May 2023 16:23:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puyDQ-0007D5-Lu; Fri, 05 May 2023 16:23:28 +0000 Received: by outflank-mailman (input) for mailman id 530512; Fri, 05 May 2023 16:23:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puyDP-0007Cz-4L for xen-devel@lists.xenproject.org; Fri, 05 May 2023 16:23:27 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2893022d-eb61-11ed-b226-6b7b168915f2; Fri, 05 May 2023 18:23:25 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2893022d-eb61-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683303805; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=LpW+04vmvMqG7/SbATjIMR3yKWBj0hCYyMl4I7nU1/Y=; b=CpIA3Fst/B9hO8TcBcKzDLXzc0qGYo8GjVfNveo7dxOAdPbXsv+8mNZX Cgqs1AgbJmtMNVOhWIwZT2byWuMFTnFaLEbhjJDA6h/2rndHB9sRuZaJa wjASqZ+7zs2B3kFV/lEyIb0XN+qWKPI849FyvQ+r4jdOMr1Fy5+felGVA w=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 108429655 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:ANXpP6AkbIPg/BVW//Hjw5YqxClBgxIJ4kV8jS/XYbTApDghgj1Tx 2sWXG/Ub/yMZGDwedl1bom19R4PvMTUyoVlQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFuspvlDs15K6p4G5A4wRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw1L1TDWQR2 c0iIRMOcg+HvPmI8Iqnc7w57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2M1N3wsYDUWUrsTIJs4gOevgGi5azBCoUiZjaE2/3LS3Ep6172F3N/9I4TaGZ8EwBvFz o7A10qgHU9KHYbE8DuM43zwrbDwhmT4U41HQdVU8dY12QbOlwT/EiY+cUawqL+Xg0i1VtZbN mQd4C9opq83nGS7Q9+4UxCmrXqsuh8HR8EWA+A88BuKyKff/0CeHGdsZhRMcsA8vck6Axkjz EaUnsjBDCZq9raSTBq1ybqV6xiyNC49JHUHIyQDSGMt/N3LsIw1yBXVQb5LCqmuhMfyHjL26 z+PpSk6wb4UiKYj1aqh+kvcqymxvZWPRQkwji3eRm+/5xl1TJKkbYevr1Pc6J59wJ2xFwfb+ iJewo7Hsb5IVMvW/MCQfAkTNJ/yw/qAbxHtu1dMHIU+8w+2xU6bYbkFtVmSO3xV3tY4lS7BO RGD4lkMtcYKYxNGfocsPdvvVp1CIbzIUI28C6uKNocmjo1ZLlfvwc14WaKHM4kBemAImLp3B 5qUeN3E4Z0yWfU+l2reqwvwPNYWKsECKYD7H8qTI+yPi+b2WZJsYe5t3KGyRu449riYhw7e7 sxSMcCHoz0GDr2lOHOJrddCdQtVRZTeOa0aVuQNLrLTSuaYMDhJ5wDtLUMJJNU+wvU9ehbg9 XChQE5IoGfCaYn8AVzSMBhLMeq/NauTWFpnZUTAy370gSl8CWtuhY9DH6YKkU4PrbM4lqEoF albI61twJ1nE1z6xtjUVrGlxKQKSfhhrVvm0/aNCNTnQ6Ndeg== IronPort-HdrOrdr: A9a23:vL7GIq9mD7ygrZMLMaVuk+AcI+orL9Y04lQ7vn2ZKSY5TiX4rb HKoB1/73XJYVkqN03I9ervBEDiewK/yXcW2+ks1N6ZNWGLhILBFupfBODZsl7d8kPFl9K01c 1bAtJD4N+bNykGsS4tijPIb+rJw7O8gd+Vbf+19QYIcenzAZsQlzuQDGygYypLbTgDP7UVPr yG6PFKojKxEE5nFfhSVhE+Lo7+T8SgruOeXSI7 X-Talos-CUID: 9a23:aYtV6W3x7/TEOXakRai9drxfNJsBfniC4EbqKmy7FXltc6areWeMwfYx X-Talos-MUID: 9a23:UehdgQjZSfBUqhLRyUqqusMpGp53vfSHUhs0kJwXtZWvahNrfDSWg2Hi X-IronPort-AV: E=Sophos;i="5.99,252,1677560400"; d="scan'208";a="108429655" Date: Fri, 5 May 2023 17:23:19 +0100 From: Anthony PERARD To: Luca Fancellu CC: Xen-devel , Bertrand Marquis , Wei Chen , Wei Liu , George Dunlap , Nick Rosbrook , Juergen Gross Subject: Re: [PATCH v6 10/12] xen/tools: add sve parameter in XL configuration Message-ID: References: <20230424060248.1488859-1-luca.fancellu@arm.com> <20230424060248.1488859-11-luca.fancellu@arm.com> <996db21b-e963-4259-884d-2131c548ca1e@perard> <8C3DC6ED-83D8-4DD0-9C99-B34449304373@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <8C3DC6ED-83D8-4DD0-9C99-B34449304373@arm.com> On Tue, May 02, 2023 at 07:54:19PM +0000, Luca Fancellu wrote: > > On 2 May 2023, at 18:06, Anthony PERARD wrote: > > On Mon, Apr 24, 2023 at 07:02:46AM +0100, Luca Fancellu wrote: > >> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c > >> index ddc7b2a15975..1e69dac2c4fa 100644 > >> --- a/tools/libs/light/libxl_arm.c > >> +++ b/tools/libs/light/libxl_arm.c > >> @@ -211,6 +213,12 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, > >> return ERROR_FAIL; > >> } > >> > >> + /* Parameter is sanitised in libxl__arch_domain_build_info_setdefault */ > >> + if (d_config->b_info.arch_arm.sve_vl) { > >> + /* Vector length is divided by 128 in struct xen_domctl_createdomain */ > >> + config->arch.sve_vl = d_config->b_info.arch_arm.sve_vl / 128U; > >> + } > >> + > >> return 0; > >> } > >> > >> @@ -1681,6 +1689,26 @@ int libxl__arch_domain_build_info_setdefault(libxl__gc *gc, > >> /* ACPI is disabled by default */ > >> libxl_defbool_setdefault(&b_info->acpi, false); > >> > >> + /* Sanitise SVE parameter */ > >> + if (b_info->arch_arm.sve_vl) { > >> + unsigned int max_sve_vl = > >> + arch_capabilities_arm_sve(physinfo->arch_capabilities); > >> + > >> + if (!max_sve_vl) { > >> + LOG(ERROR, "SVE is unsupported on this machine."); > >> + return ERROR_FAIL; > >> + } > >> + > >> + if (LIBXL_SVE_TYPE_HW == b_info->arch_arm.sve_vl) { > >> + b_info->arch_arm.sve_vl = max_sve_vl; > >> + } else if (b_info->arch_arm.sve_vl > max_sve_vl) { > >> + LOG(ERROR, > >> + "Invalid sve value: %d. Platform supports up to %u bits", > >> + b_info->arch_arm.sve_vl, max_sve_vl); > >> + return ERROR_FAIL; > >> + } > > > > You still need to check that sve_vl is one of the value from the enum, > > or that the value is divisible by 128. > > I have probably missed something, I thought that using the way below to > specify the input I had for free that the value is 0 or divisible by 128, is it > not the case? Who can write to b_info->arch_arm.sve_vl different value > from the enum we specified in the .idl? `xl` isn't the only user of `libxl`. There's `libvirt` as well. We also have libxl bindings for several languages. There's nothing stopping a developer to write a number into `sve_vl` instead of choosing one of the value from the enum. I think we should probably sanitize any input that comes from outside of libxl, that's probably the case, I'm not sure. So if valid values for `sve_vl` are only numbers divisible by 128, and some other discrete numbers, then we should check that they are, or check that the value is one defined by the enum. Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri May 05 16:28:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 16:28:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530516.826179 (Exim 4.92) (envelope-from ) id 1puyI2-0007pC-A6; Fri, 05 May 2023 16:28:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530516.826179; Fri, 05 May 2023 16:28:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puyI2-0007p5-7R; Fri, 05 May 2023 16:28:14 +0000 Received: by outflank-mailman (input) for mailman id 530516; Fri, 05 May 2023 16:28:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puyI1-0007ow-AZ for xen-devel@lists.xenproject.org; Fri, 05 May 2023 16:28:13 +0000 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [2607:f8b0:4864:20::114a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d33406e0-eb61-11ed-8611-37d641c3527e; Fri, 05 May 2023 18:28:11 +0200 (CEST) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-559e281c5dfso19662157b3.3 for ; Fri, 05 May 2023 09:28:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d33406e0-eb61-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1683304090; x=1685896090; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=tpG4xiqP3mzArRx9Ask1She9PnSIKi9NV0T7HckdUAY=; b=R7ZId5oM7hLrX+tcfVm/Bnk2u8JbAC1I8QSh2twc/YutVfGMASmtW7tbm2YP3uHqlk RwtPwL861jZAZsMdLif5CXyQc6HVUK4hq+Rsigm7g9H5SwYxxSrPZKroysdphn0wBKMc 5pkuhlqCX/BOp4yTuk4h5T1NCQgcpfPZ9KLIiem4KASWPyrgXBR48rcxQa06YhEaqMbn orfLSFQcdN2vNomHtco8b3soICbHS5a9W6R91ScgWRyqTuI6OJFa+omcbJE3G4QloJsc Zd/UhaIHTp9GBfbJO6BShFyMFzXWMH9S7e+yp/9GzVVu/Y2uZsmKlNFrDjrpY2RYPhtU 7R+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683304090; x=1685896090; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=tpG4xiqP3mzArRx9Ask1She9PnSIKi9NV0T7HckdUAY=; b=JZcmGMH0Sk7khgu/cTCb7OlxOtGYfhG7uzwjCfAALOyOMVhIR7NVjT6WzB7c+L5Qek ACtGA059m4FaZCbRSJ6UOBO/IZljlDlvYBfOnG6ST77PNJti86HuLL635G1s/ZF6o1kn GSmBod7sGZLPDLmdqhvhiT9xZr2nto3f6Qes7WX67lDhWKGo5vkUlDwKbvrAZzSSldeZ 41bHMDjsNTal9dxBDN4MkMLYmOymbx+oHZoOrxzmwiAfyi3n65dhdS3RK6g9RLyezhSZ bSuxQpkhDPUzVYtD6GmPa0qDS0VALRy+Ra/+ieLElIJQysaDI4gsI8ye1hxyYmxIOtVY 1sBw== X-Gm-Message-State: AC+VfDw9csWhAxSBmzSVe0ZGipJ3DIkVCdu1sNmCU/ISL4yqz5BkXAF5 5fir944kfNVsUDgb+omwMVsNMdTTtI8= X-Google-Smtp-Source: ACHHUZ6MaxIQ4e6CYkENF40G6p9cF+vIn2nNSO3VXw5131N/TbPSwiBkXRT2QEZKyWmorm0BLuruUfs9Bhg= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a81:ac24:0:b0:559:d859:d746 with SMTP id k36-20020a81ac24000000b00559d859d746mr1208880ywh.10.1683304090087; Fri, 05 May 2023 09:28:10 -0700 (PDT) Date: Fri, 5 May 2023 09:28:08 -0700 In-Reply-To: <20230505152046.6575-3-mic@digikod.net> Mime-Version: 1.0 References: <20230505152046.6575-1-mic@digikod.net> <20230505152046.6575-3-mic@digikod.net> Message-ID: Subject: Re: [PATCH v1 2/9] KVM: x86/mmu: Add support for prewrite page tracking From: Sean Christopherson To: "=?iso-8859-1?Q?Micka=EBl_Sala=FCn?=" Cc: Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Ingo Molnar , Kees Cook , Paolo Bonzini , Thomas Gleixner , Vitaly Kuznetsov , Wanpeng Li , Alexander Graf , Forrest Yuan Yu , James Morris , John Andersen , Liran Alon , "Madhavan T . Venkataraman" , Marian Rotariu , "Mihai =?utf-8?B?RG9uyJt1?=" , "=?utf-8?B?TmljdciZb3IgQ8OuyJt1?=" , Rick Edgecombe , Thara Gopinath , Will Deacon , Zahra Tarkhani , "=?utf-8?Q?=C8=98tefan_=C8=98icleru?=" , dev@lists.cloudhypervisor.org, kvm@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, x86@kernel.org, xen-devel@lists.xenproject.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable On Fri, May 05, 2023, Micka=EF=BF=BDl Sala=EF=BF=BDn wrote: > diff --git a/arch/x86/include/asm/kvm_page_track.h b/arch/x86/include/asm= /kvm_page_track.h > index eb186bc57f6a..a7fb4ff888e6 100644 > --- a/arch/x86/include/asm/kvm_page_track.h > +++ b/arch/x86/include/asm/kvm_page_track.h > @@ -3,6 +3,7 @@ > #define _ASM_X86_KVM_PAGE_TRACK_H > =20 > enum kvm_page_track_mode { > + KVM_PAGE_TRACK_PREWRITE, Heh, just when I decide to finally kill off support for multiple modes[1] := -) My assessment from that changelog still holds true for this case: Drop "support" for multiple page-track modes, as there is no evidence that array-based and refcounted metadata is the optimal solution for other modes, nor is there any evidence that other use cases, e.g. for access-tracking, will be a good fit for the page-track machinery in general. =20 E.g. one potential use case of access-tracking would be to prevent guest access to poisoned memory (from the guest's perspective). In that case, the number of poisoned pages is likely to be a very small percentage of the guest memory, and there is no need to reference count the number of access-tracking users, i.e. expanding gfn_track[] for a new mode would be grossly inefficient. And for poisoned memory, host userspace would also likely want to trap accesses, e.g. to inject #MC into the guest, and that isn't currently supported by the page-track framework. =20 A better alternative for that poisoned page use case is likely a variation of the proposed per-gfn attributes overlay (linked), which would allow efficiently tracking the sparse set of poisoned pages, and by default would exit to userspace on access. Of particular relevance: - Using the page-track machinery is inefficient because the guest is like= ly going to write-protect a minority of its memory. And this select KVM_EXTERNAL_WRITE_TRACKING if KVM is particularly nasty because simply enabling HEKI in the Kconfig will = cause KVM to allocate rmaps and gfn tracking. - There's no need to reference count the protection, i.e. 15 of the 16 bi= ts of gfn_track are dead weight. - As proposed, adding a second "mode" would double the cost of gfn tracki= ng. - Tying the protections to the memslots will create an impossible-to-main= tain ABI because the protections will be lost if the owning memslot is delet= ed and recreated. - The page-track framework provides incomplete protection and will lead t= o an ongoing game of whack-a-mole, e.g. this patch catches the obvious cases= by adding calls to kvm_page_track_prewrite(), but misses things like kvm_v= cpu_map(). - The scaling and maintenance issues will only get worse if/when someone = tries to support dropping read and/or execute permissions, e.g. for execute-o= nly. - The code is x86-only, and is likely to stay that way for the foreseeabl= e future. The proposed alternative is to piggyback the memory attributes implementati= on[2] that is being added (if all goes according to plan) for confidential VMs. = This use case (dropping permissions) came up not too long ago[3], which is why I= have a ready-made answer). I have no doubt that we'll need to solve performance and scaling issues wit= h the memory attributes implementation, e.g. to utilize xarray multi-range suppor= t instead of storing information on a per-4KiB-page basis, but AFAICT, the co= re idea is sound. And a very big positive from a maintenance perspective is t= hat any optimizations, fixes, etc. for one use case (CoCo vs. hardening) should= also benefit the other use case. [1] https://lore.kernel.org/all/20230311002258.852397-22-seanjc@google.com [2] https://lore.kernel.org/all/Y2WB48kD0J4VGynX@google.com [3] https://lore.kernel.org/all/Y1a1i9vbJ%2FpVmV9r@google.com From xen-devel-bounces@lists.xenproject.org Fri May 05 16:37:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 16:37:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530520.826190 (Exim 4.92) (envelope-from ) id 1puyQS-0000sG-5B; Fri, 05 May 2023 16:36:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530520.826190; Fri, 05 May 2023 16:36:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puyQS-0000s9-1m; Fri, 05 May 2023 16:36:56 +0000 Received: by outflank-mailman (input) for mailman id 530520; Fri, 05 May 2023 16:36:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puyQR-0000s3-47 for xen-devel@lists.xenproject.org; Fri, 05 May 2023 16:36:55 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2060d.outbound.protection.outlook.com [2a01:111:f400:7d00::60d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0a2ad505-eb63-11ed-b226-6b7b168915f2; Fri, 05 May 2023 18:36:52 +0200 (CEST) Received: from AS9PR06CA0617.eurprd06.prod.outlook.com (2603:10a6:20b:46e::28) by DBBPR08MB6010.eurprd08.prod.outlook.com (2603:10a6:10:20a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.27; Fri, 5 May 2023 16:36:49 +0000 Received: from AM7EUR03FT028.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46e:cafe::11) by AS9PR06CA0617.outlook.office365.com (2603:10a6:20b:46e::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.27 via Frontend Transport; Fri, 5 May 2023 16:36:49 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT028.mail.protection.outlook.com (100.127.140.192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.27 via Frontend Transport; Fri, 5 May 2023 16:36:49 +0000 Received: ("Tessian outbound 5154e9d36775:v136"); Fri, 05 May 2023 16:36:48 +0000 Received: from ca8a46735cf3.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7E47D95F-2933-4CDE-A313-4478EB5C3B26.1; Fri, 05 May 2023 16:36:38 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ca8a46735cf3.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 05 May 2023 16:36:38 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by DB5PR08MB10047.eurprd08.prod.outlook.com (2603:10a6:10:4a0::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.27; Fri, 5 May 2023 16:36:35 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::bce1:f206:86af:31be]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::bce1:f206:86af:31be%6]) with mapi id 15.20.6363.021; Fri, 5 May 2023 16:36:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a2ad505-eb63-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EBuac5j1CkQDJPxMr1oMigHqHJsCRs+q87fc4/OYyE0=; b=DpuC5N7HRaj+3ICHI5MvEHM7ZJ2HL26lkA2AA1AYHgoIViftYNazRLVkDmC99kt9+fZzDHkriDmb/k2bmRSCCzgETU5H0K5VxCtut6dfyosQjiHvoB+5E4+Cx5ttXwOKa9Pl2xSuvhFKfkuUpNDD6MI9tasyH/VTUj+qScM4rKY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 1ea9e56575b35ba4 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=niJXtgMVCJghSiylNfNhRlICut4mMpVOe4Qn8Mj8G3wbdWIAZuRw8eDyvN95nplB86Rgov93bHKJ6ySlDa7dR0HvMOX9qYjJ3cePe5AnZhiwbgIXM4KbeuR22RpPvydEopaRYJiYv4wj2ggMtcUoVWEMbs315T4qyW9y9BFxd1ZlgaKI5UM8uYp2v/G5zGeAMJBbAy57gsroxudGiMI6IRPn0qyEoAns1M0wPh0YjPBKK8wzRLuh0Nx7gchfBXraAYnj4ouAYbQoK4z+hFJyfc56VjT9BLyoF+jzKoEGeSVdLCamzrS7cvzFtWrsT/Xg6IeXyyx3IEIZkKH4RNdEEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EBuac5j1CkQDJPxMr1oMigHqHJsCRs+q87fc4/OYyE0=; b=FWFMTdF0GzUdHY80NDNwAQ4rlzwzoNkDJcWheWe8MSeuv4Ubz6mJuiu1pdiGW+MBS1ueXLlazjsk0dKQw0cUtZSVbou/jbAzYwZ926eDWCvU+1br+x2UCfFUc68m/Uq6DxdZs7KCmvrqvaacQ1Fugwhzxy3qX7q+n/c79+vBJSaLJtM+AuHsYuDFEx8hIe3Nlu5Hwi2FQaNn9sKSbnP1poKrhQbWLhA5QoYK2g+8ddcJ+d025IdY31bqKroEJ72d9ce/b2LPTyW2YN3BR2e7FUf14rca6ooYGFUt5IVpsoocU8H9OFPbpZMH3z2R2p/aH4K4kMrnS/yayeW4yoNaAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EBuac5j1CkQDJPxMr1oMigHqHJsCRs+q87fc4/OYyE0=; b=DpuC5N7HRaj+3ICHI5MvEHM7ZJ2HL26lkA2AA1AYHgoIViftYNazRLVkDmC99kt9+fZzDHkriDmb/k2bmRSCCzgETU5H0K5VxCtut6dfyosQjiHvoB+5E4+Cx5ttXwOKa9Pl2xSuvhFKfkuUpNDD6MI9tasyH/VTUj+qScM4rKY= From: Luca Fancellu To: Anthony PERARD CC: Xen-devel , Bertrand Marquis , Wei Chen , Wei Liu , George Dunlap , Nick Rosbrook , Juergen Gross Subject: Re: [PATCH v6 10/12] xen/tools: add sve parameter in XL configuration Thread-Topic: [PATCH v6 10/12] xen/tools: add sve parameter in XL configuration Thread-Index: AQHZdnKI1/ryq6h2kEuVT2yTgC4YMq9HQ+EAgAAu74CABHwZgIAAA6SA Date: Fri, 5 May 2023 16:36:32 +0000 Message-ID: References: <20230424060248.1488859-1-luca.fancellu@arm.com> <20230424060248.1488859-11-luca.fancellu@arm.com> <996db21b-e963-4259-884d-2131c548ca1e@perard> <8C3DC6ED-83D8-4DD0-9C99-B34449304373@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.500.231) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|DB5PR08MB10047:EE_|AM7EUR03FT028:EE_|DBBPR08MB6010:EE_ X-MS-Office365-Filtering-Correlation-Id: 89196cc3-0a0e-4432-1796-08db4d86ec91 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: VTOL/3PHStL0SwwFAPIuCSeaHr2LGELHedp7rT28YOUlqSfccPOCgbeq9t80/xWC90frd8jIdDq2DQzE5Ofe+qRt+BuMUbMpTYLQQUi+IsaWFM5PgvdWT/BM58/DZTD+k/JWza9oNglEVKsZEX25c41oqRcV0uh7LzIxANqm1O9xPpvS70QdbQNJLb9lx2qkw6jGcGNcgI5i6h6FFXnSD4XzQOQ98RWulLWObcoBuJd72NPXpRO2ceUjvwvY1TZgtJgdDoScd0QpgSbHygP/Z9QPcuUFYOsibE/nI5NxLWmNCa0FSrnqQcN+9EGMkIlnXvVLN1e/93LSrW+eCRztorhmUUo07rqOO29EO/zoft0vwURqAsNsJu4BKhnLkwTPqgP1DyeeaVH7y3P8Cp4vSZyA3n6zEaPD32NUJsB2wuaVbDOiflzw+4p6qE6mldZjWD0KCxbRa+zOgHTPopWuvgAqeyIJx9Ep+vafF0H+p/uPBuSKy8ZcOGa2dHqt9Sw1N45yz9t28yjfs3aUDo33kWeF6oVie/j4aeHUnscwtZhxaR+zuPeGpVEGjKNR4jAK3TzS6z6tU5JEVktV8FjtSDQGSxp5Fyy7cZ5UlNNsBOHjeJTcELhI2ZUldFp3QTDsOyQr57Xvm3wQ4BUVQPqS4A== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39850400004)(346002)(396003)(136003)(366004)(376002)(451199021)(36756003)(86362001)(33656002)(6666004)(6486002)(71200400001)(316002)(91956017)(54906003)(76116006)(66476007)(66556008)(66446008)(64756008)(6916009)(4326008)(478600001)(66946007)(8676002)(8936002)(5660300002)(41300700001)(2906002)(2616005)(38100700002)(38070700005)(122000001)(186003)(6506007)(6512007)(26005)(53546011)(83380400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <0CBE64C3515C9E4A9BE565F762B2E6D9@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR08MB10047 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3cf9d66b-249f-45b0-e003-08db4d86e279 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7q9ddN1LJ37biC3S/yuW1dQVpAHr9zKi+OgliZ4q9epaokqQVX6K3Rp5ohdRUlui3J7WB4fOD0NwDR5KPG5NQsNUgeY3PaFt9+OVZ0N3GhYxCSa3QVRO0mkWPRT3bB+7y3SOFIV7Ak5FmWVE6Httq9ROl3EXM1nZF/+F44I/9DdDsh61B4ZYfzYpJfSYF9Z3STpe36kzDRsFj6Z8y0zQMiDYEwA3TBsbMdGeOJBtiay9WGXMYKZfxqEspv5tcT02IyIHBOGMfKBb6xLSzDRzSJc1RQy4fr89dagVQKiIbLSdCCNsNOqo5BaspRtHk2+el9toavuBX+ujrCvCRMwj5U7wRizU8Or47wxh0TEmd1TXfcex52+jJ7k3uxeezMnVv4Z3564oDUnwyvMK6pvrBE7WzRY7C4tO6MWZln8DOq9jxBBKNE1QTEX99o4XdCvNEr+gtdKSmfk0HhVJU+Rk+jSGH4/vO0Hi8sMIm6BXDPwmaJMoLnpSlJW1pJjtE6/W4CufQooZaB+seX2PC5OGYSJx9QRY+9uhp2BAnw7vVuBlyDl5YRCuZ4l+l/1Au1eMpmcbFw+JqCDwKuo2F1fSwWu/KWtRKuy0O4oid0SGPMSzlZXeNJHl5OXvT6aIf6oud70kRBAAKj/MmneCPmPtZN65tPgA3j5mY6vodZJqxpj8BjVwqta/lJPJfhVkme597iXVg109PJe4hlp+4Qi62A== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(136003)(39860400002)(376002)(451199021)(40470700004)(46966006)(36840700001)(40460700003)(70586007)(70206006)(4326008)(6486002)(6666004)(316002)(54906003)(33656002)(86362001)(36756003)(478600001)(47076005)(336012)(83380400001)(6506007)(107886003)(26005)(53546011)(36860700001)(6512007)(2616005)(8936002)(8676002)(6862004)(5660300002)(41300700001)(82310400005)(40480700001)(2906002)(186003)(82740400003)(81166007)(356005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 16:36:49.2164 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 89196cc3-0a0e-4432-1796-08db4d86ec91 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6010 DQoNCj4gT24gNSBNYXkgMjAyMywgYXQgMTc6MjMsIEFudGhvbnkgUEVSQVJEIDxhbnRob255LnBl cmFyZEBjaXRyaXguY29tPiB3cm90ZToNCj4gDQo+IE9uIFR1ZSwgTWF5IDAyLCAyMDIzIGF0IDA3 OjU0OjE5UE0gKzAwMDAsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+Pj4gT24gMiBNYXkgMjAyMywg YXQgMTg6MDYsIEFudGhvbnkgUEVSQVJEIDxhbnRob255LnBlcmFyZEBjaXRyaXguY29tPiB3cm90 ZToNCj4+PiBPbiBNb24sIEFwciAyNCwgMjAyMyBhdCAwNzowMjo0NkFNICswMTAwLCBMdWNhIEZh bmNlbGx1IHdyb3RlOg0KPj4+PiBkaWZmIC0tZ2l0IGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF9h cm0uYyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJtLmMNCj4+Pj4gaW5kZXggZGRjN2IyYTE1 OTc1Li4xZTY5ZGFjMmM0ZmEgMTAwNjQ0DQo+Pj4+IC0tLSBhL3Rvb2xzL2xpYnMvbGlnaHQvbGli eGxfYXJtLmMNCj4+Pj4gKysrIGIvdG9vbHMvbGlicy9saWdodC9saWJ4bF9hcm0uYw0KPj4+PiBA QCAtMjExLDYgKzIxMywxMiBAQCBpbnQgbGlieGxfX2FyY2hfZG9tYWluX3ByZXBhcmVfY29uZmln KGxpYnhsX19nYyAqZ2MsDQo+Pj4+ICAgICAgICByZXR1cm4gRVJST1JfRkFJTDsNCj4+Pj4gICAg fQ0KPj4+PiANCj4+Pj4gKyAgICAvKiBQYXJhbWV0ZXIgaXMgc2FuaXRpc2VkIGluIGxpYnhsX19h cmNoX2RvbWFpbl9idWlsZF9pbmZvX3NldGRlZmF1bHQgKi8NCj4+Pj4gKyAgICBpZiAoZF9jb25m aWctPmJfaW5mby5hcmNoX2FybS5zdmVfdmwpIHsNCj4+Pj4gKyAgICAgICAgLyogVmVjdG9yIGxl bmd0aCBpcyBkaXZpZGVkIGJ5IDEyOCBpbiBzdHJ1Y3QgeGVuX2RvbWN0bF9jcmVhdGVkb21haW4g Ki8NCj4+Pj4gKyAgICAgICAgY29uZmlnLT5hcmNoLnN2ZV92bCA9IGRfY29uZmlnLT5iX2luZm8u YXJjaF9hcm0uc3ZlX3ZsIC8gMTI4VTsNCj4+Pj4gKyAgICB9DQo+Pj4+ICsNCj4+Pj4gICAgcmV0 dXJuIDA7DQo+Pj4+IH0NCj4+Pj4gDQo+Pj4+IEBAIC0xNjgxLDYgKzE2ODksMjYgQEAgaW50IGxp YnhsX19hcmNoX2RvbWFpbl9idWlsZF9pbmZvX3NldGRlZmF1bHQobGlieGxfX2djICpnYywNCj4+ Pj4gICAgLyogQUNQSSBpcyBkaXNhYmxlZCBieSBkZWZhdWx0ICovDQo+Pj4+ICAgIGxpYnhsX2Rl ZmJvb2xfc2V0ZGVmYXVsdCgmYl9pbmZvLT5hY3BpLCBmYWxzZSk7DQo+Pj4+IA0KPj4+PiArICAg IC8qIFNhbml0aXNlIFNWRSBwYXJhbWV0ZXIgKi8NCj4+Pj4gKyAgICBpZiAoYl9pbmZvLT5hcmNo X2FybS5zdmVfdmwpIHsNCj4+Pj4gKyAgICAgICAgdW5zaWduZWQgaW50IG1heF9zdmVfdmwgPQ0K Pj4+PiArICAgICAgICAgICAgYXJjaF9jYXBhYmlsaXRpZXNfYXJtX3N2ZShwaHlzaW5mby0+YXJj aF9jYXBhYmlsaXRpZXMpOw0KPj4+PiArDQo+Pj4+ICsgICAgICAgIGlmICghbWF4X3N2ZV92bCkg ew0KPj4+PiArICAgICAgICAgICAgTE9HKEVSUk9SLCAiU1ZFIGlzIHVuc3VwcG9ydGVkIG9uIHRo aXMgbWFjaGluZS4iKTsNCj4+Pj4gKyAgICAgICAgICAgIHJldHVybiBFUlJPUl9GQUlMOw0KPj4+ PiArICAgICAgICB9DQo+Pj4+ICsNCj4+Pj4gKyAgICAgICAgaWYgKExJQlhMX1NWRV9UWVBFX0hX ID09IGJfaW5mby0+YXJjaF9hcm0uc3ZlX3ZsKSB7DQo+Pj4+ICsgICAgICAgICAgICBiX2luZm8t PmFyY2hfYXJtLnN2ZV92bCA9IG1heF9zdmVfdmw7DQo+Pj4+ICsgICAgICAgIH0gZWxzZSBpZiAo Yl9pbmZvLT5hcmNoX2FybS5zdmVfdmwgPiBtYXhfc3ZlX3ZsKSB7DQo+Pj4+ICsgICAgICAgICAg ICBMT0coRVJST1IsDQo+Pj4+ICsgICAgICAgICAgICAgICAgIkludmFsaWQgc3ZlIHZhbHVlOiAl ZC4gUGxhdGZvcm0gc3VwcG9ydHMgdXAgdG8gJXUgYml0cyIsDQo+Pj4+ICsgICAgICAgICAgICAg ICAgYl9pbmZvLT5hcmNoX2FybS5zdmVfdmwsIG1heF9zdmVfdmwpOw0KPj4+PiArICAgICAgICAg ICAgcmV0dXJuIEVSUk9SX0ZBSUw7DQo+Pj4+ICsgICAgICAgIH0NCj4+PiANCj4+PiBZb3Ugc3Rp bGwgbmVlZCB0byBjaGVjayB0aGF0IHN2ZV92bCBpcyBvbmUgb2YgdGhlIHZhbHVlIGZyb20gdGhl IGVudW0sDQo+Pj4gb3IgdGhhdCB0aGUgdmFsdWUgaXMgZGl2aXNpYmxlIGJ5IDEyOC4NCj4+IA0K Pj4gSSBoYXZlIHByb2JhYmx5IG1pc3NlZCBzb21ldGhpbmcsIEkgdGhvdWdodCB0aGF0IHVzaW5n IHRoZSB3YXkgYmVsb3cgdG8NCj4+IHNwZWNpZnkgdGhlIGlucHV0IEkgaGFkIGZvciBmcmVlIHRo YXQgdGhlIHZhbHVlIGlzIDAgb3IgZGl2aXNpYmxlIGJ5IDEyOCwgaXMgaXQNCj4+IG5vdCB0aGUg Y2FzZT8gV2hvIGNhbiB3cml0ZSB0byBiX2luZm8tPmFyY2hfYXJtLnN2ZV92bCBkaWZmZXJlbnQg dmFsdWUNCj4+IGZyb20gdGhlIGVudW0gd2Ugc3BlY2lmaWVkIGluIHRoZSAuaWRsPw0KPiANCj4g YHhsYCBpc24ndCB0aGUgb25seSB1c2VyIG9mIGBsaWJ4bGAuIFRoZXJlJ3MgYGxpYnZpcnRgIGFz IHdlbGwuIFdlIGFsc28NCj4gaGF2ZSBsaWJ4bCBiaW5kaW5ncyBmb3Igc2V2ZXJhbCBsYW5ndWFn ZXMuDQoNClJpZ2h0LCB0aGlzIHBvaW50IHdhc27igJl0IGNsZWFyIHRvIG1lLCBJIHdpbGwgYWRk IHRoZSBjaGVjayB0aGVyZSwgdGhhbmsgeW91DQpmb3IgdGhlIGV4cGxhbmF0aW9uLg0KDQo+IFRo ZXJlJ3Mgbm90aGluZyBzdG9wcGluZyBhDQo+IGRldmVsb3BlciB0byB3cml0ZSBhIG51bWJlciBp bnRvIGBzdmVfdmxgIGluc3RlYWQgb2YgY2hvb3Npbmcgb25lIG9mIHRoZQ0KPiB2YWx1ZSBmcm9t IHRoZSBlbnVtLiBJIHRoaW5rIHdlIHNob3VsZCBwcm9iYWJseSBzYW5pdGl6ZSBhbnkgaW5wdXQg dGhhdA0KPiBjb21lcyBmcm9tIG91dHNpZGUgb2YgbGlieGwsIHRoYXQncyBwcm9iYWJseSB0aGUg Y2FzZSwgSSdtIG5vdCBzdXJlLg0KPiANCj4gU28gaWYgdmFsaWQgdmFsdWVzIGZvciBgc3ZlX3Zs YCBhcmUgb25seSBudW1iZXJzIGRpdmlzaWJsZSBieSAxMjgsIGFuZA0KPiBzb21lIG90aGVyIGRp c2NyZXRlIG51bWJlcnMsIHRoZW4gd2Ugc2hvdWxkIGNoZWNrIHRoYXQgdGhleSBhcmUsIG9yDQo+ IGNoZWNrIHRoYXQgdGhlIHZhbHVlIGlzIG9uZSBkZWZpbmVkIGJ5IHRoZSBlbnVtLg0KPiANCj4g Q2hlZXJzLA0KPiANCj4gLS0gDQo+IEFudGhvbnkgUEVSQVJEDQoNCg== From xen-devel-bounces@lists.xenproject.org Fri May 05 16:45:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 16:45:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530527.826200 (Exim 4.92) (envelope-from ) id 1puyY4-0002Ni-1w; Fri, 05 May 2023 16:44:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530527.826200; Fri, 05 May 2023 16:44:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puyY3-0002Nb-VG; Fri, 05 May 2023 16:44:47 +0000 Received: by outflank-mailman (input) for mailman id 530527; Fri, 05 May 2023 16:44:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puyY2-0002NV-BC for xen-devel@lists.xenproject.org; Fri, 05 May 2023 16:44:46 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 22aa0459-eb64-11ed-b226-6b7b168915f2; Fri, 05 May 2023 18:44:44 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 22aa0459-eb64-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683305084; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=OEtTTua7UCQiOx6mgjVmEFb8W/Gl1MOESQKAg0KNS0k=; b=NEKDr5Y0xpZdGge37xAK9TJ2UdZCqIV9O9fYTxUirjXTYKila5dIxB8K QIET8e0F/Xe3/wlar0+hNrMDbLQIeMWE3RrSQnOFUQDY5MHuWNi6NhMZB LPjiDSdB04VmgSatIM0xVwhtXJ2XNOpTvkvRbWzJsutFhhOrFXK2Ydemw Q=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 108049361 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:NSJfuKJ7iMxDYyKLFE+RW5UlxSXFcZb7ZxGr2PjKsXjdYENSgjUFm 2sYDGqEPPmLazajfNwnOoTg/EhQvpbdyt8ySQFlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPSwP9TlK6q4mhA4wRjPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5UPVpz+ 6Q4MAtVVSiqhLKPmombE+hz05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpNU6bC/FMEg5/5JYWleG0hn75YntApUicv6Yf6GnP1g1hlrPqNbI5f/TTHZUNwhfD+ DuuE2LRWAsqK9DH8H28qlWI19TsuQn2W4YfLejtnhJtqALKnTFCYPEMbnOfvPKwzGC3XdlSL 0gJ0iM0qO4580nDZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpQtE8qNU/QzBs8 1aThs7oHhRmqrjTQnWYnp+roDL0EigYK0cLfypCRgwAi/H5p5o5lBXITdBLH6u8j9mzEjb1q xiVqAAuirNVitQEv4258krAmCmEvYXSQ0g+4QC/dm6s8A5RfoOuYI2sr1/B4p5oKY+DS1Cbs Xssms6A7fsPB5WAiCyMRuoWGLijof2CNVX0iEZiBZA7+xyx+nSoesZb5zQWGatyGp9aI3mzO haV4F4PosYJZxNGcJObfaqSN/8Xw/DADe+9bcj9bYp3OKNRLQ6YqXQGiVGr44z9rKQ9ufhha czBLJf1VCly5bdPl2TvGbpEuVM/7mVnnD6IG8imp/iy+eDGDEN5X4vpJ7dnggoRyKqf6DvY/ N9EXydh40UOCbauCsU7HGN6ELzrEZTYLcqswyCvXrTfSjeK4Ul4YxMr/ZsvepZ+g4NenfrS8 3e2VydwkQSv3iedd1nTOyg4N9sDuKpCQY8TZ3RwbT5EJVB6CWpQ0EvvX8RuJuR2nACS5fV1U +MEa629Pxi7cRyeo251RcCk/ORfmOGD2Vrm09yNPGJuIPaNhmXhprfZQ+cY3HBRVXHo6ZFu/ eXIO8GyacNrejmOxf3+MJqHp25dd1BE8A6udyMk+uVuRXg= IronPort-HdrOrdr: A9a23:LOrwYqzUT4C4KCnOLoeWKrPw8b1zdoMgy1knxilNoH1uA6+lfq WV98jzuiWYtN98Yh0dcKm7SdW9qBDnlaKdg7N+AV74ZniFhILAFugLh7cKqAeAJ8SRzIFgPK 1bAs1D4PqZNykc/KCKmXjBL/8QhPqi+KCsify29QYWcegTUdAa0++mYjzrdnGffGF9dOcE/T Gnl7V6mwY= X-Talos-CUID: 9a23:Mz2+MWFmjkMcnR+AqmJEyHUpFJgFakaF90/5IB+BU11JEbyKHAo= X-Talos-MUID: 9a23:j5hMjQlmjXlt8DEG+F1Gdno4Lvd37/yXT3lVtrFXgOqgHyFzPzqk2WE= X-IronPort-AV: E=Sophos;i="5.99,252,1677560400"; d="scan'208";a="108049361" Date: Fri, 5 May 2023 17:44:37 +0100 From: Anthony PERARD To: Luca Fancellu CC: Xen-devel , Bertrand Marquis , Wei Chen , George Dunlap , Nick Rosbrook , Wei Liu , Juergen Gross , Christian Lindig , David Scott , Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= , Christian Lindig Subject: Re: [PATCH v6 09/12] tools: add physinfo arch_capabilities handling for Arm Message-ID: <9a0398b9-5b59-47aa-af34-a41133dc9e70@perard> References: <20230424060248.1488859-1-luca.fancellu@arm.com> <20230424060248.1488859-10-luca.fancellu@arm.com> <4e6758c0-dd81-4963-8989-d941eba2b257@perard> <34A79CE8-FEE8-426B-810C-1E928E207724@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <34A79CE8-FEE8-426B-810C-1E928E207724@arm.com> On Wed, May 03, 2023 at 09:23:19AM +0000, Luca Fancellu wrote: > > > > On 2 May 2023, at 17:13, Anthony PERARD wrote: > > > > On Mon, Apr 24, 2023 at 07:02:45AM +0100, Luca Fancellu wrote: > >> diff --git a/tools/include/xen-tools/arm-arch-capabilities.h b/tools/include/xen-tools/arm-arch-capabilities.h > >> new file mode 100644 > >> index 000000000000..ac44c8b14344 > >> --- /dev/null > >> +++ b/tools/include/xen-tools/arm-arch-capabilities.h > >> @@ -0,0 +1,28 @@ > >> +/* SPDX-License-Identifier: GPL-2.0 */ > > > > Do you mean GPL-2.0-only ? > > > > GPL-2.0 is deprecated by the SPDX project. > > > > https://spdx.org/licenses/GPL-2.0.html > > > > > > Besides that, patch looks fine: > > Reviewed-by: Anthony PERARD > > Thanks, I’ll fix in the next push and I’ll add your R-by Actually, could you use LGPL-2.1-only instead. As this code is to be included in libxl, and libxl is supposed to be LGPL-2.1-only, it might be better to be on the safe side and use LGPL for this new file. As I understand (from recent discussion about libacpi, and a quick search only), mixing GPL and LGPL code might mean the result is GPL. So just to be on the safe side, have this file been LGPL might be better. And it seems that it would still be fine to include that file in GPL projects. Would that be ok with you? Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri May 05 16:45:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 16:45:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530528.826210 (Exim 4.92) (envelope-from ) id 1puyYE-0002f8-8p; Fri, 05 May 2023 16:44:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530528.826210; Fri, 05 May 2023 16:44:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puyYE-0002f1-5x; Fri, 05 May 2023 16:44:58 +0000 Received: by outflank-mailman (input) for mailman id 530528; Fri, 05 May 2023 16:44:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puyYC-0002NV-At for xen-devel@lists.xenproject.org; Fri, 05 May 2023 16:44:56 +0000 Received: from mail-pj1-x104a.google.com (mail-pj1-x104a.google.com [2607:f8b0:4864:20::104a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 29997d9a-eb64-11ed-b226-6b7b168915f2; Fri, 05 May 2023 18:44:55 +0200 (CEST) Received: by mail-pj1-x104a.google.com with SMTP id 98e67ed59e1d1-24e33239357so1041248a91.1 for ; Fri, 05 May 2023 09:44:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 29997d9a-eb64-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1683305094; x=1685897094; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=9+i6WgJAJzJlKXvdjrc4sB18Bds1WwkbYsWdLgSqVp4=; b=5NLcQWofuV/YkKQ6oScIEQc8lVhhA2L4HU7CAnLH03mX0Px3HVPbbRo2D6swL6bYVC DUB3fcT4XujkVxCNaKYJ+P/Z7sNnX421VReM55ms1qzD5WRQCvJ/Kix0mSSaYy6Vuguo DWnNHQWNURLtT+6bY0K/Qi8QSq5fb73IsidEyosi5bDvhPv4lQKLP/WCp19+1EjcQYkT 2ZZ09LoscjMPBSeU10UZCNvLYrLZpvQ7Vt2oUZW3pPlG97XC7fwgw982zXDkvUJKrQ1i ngUKTQDZ0x71ie0DU+LnkH+jsC1SnJHoK6gBPF+WpYtjUSRSNwRS6UiypPvCgognd0bl qZfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683305094; x=1685897094; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=9+i6WgJAJzJlKXvdjrc4sB18Bds1WwkbYsWdLgSqVp4=; b=AYI6GWCXPBkbLQUCfNbNdU6P/BjvTCHSRKPJ2j4sCK2h5wNu05jaOU1/T2utj8Mixr UOwarWJ61aP21teZkmRR4bILikNL9QUkpFyrsbwGrBSMIeFGLclEMguVazBCsS/Q7v1M D5ettck/DHnjcwPqoSyY9yn6N/haqezFgNcyGQXk+hH/grqO5ChzVHBZVsITgl+hXHk0 9oZRG7vdXxUJrNLAyOjirqT4jFd0u9OKoqFfD0zAVm4t+VL8MkfRrOMCsDNISi2zYps2 Nkrk2oensuRGlWoOffkDy6EhICopFyr9lrXAbVKW1sNU1/91baQOmuc0OfZ76tWbexpG rNlQ== X-Gm-Message-State: AC+VfDxC0xjhEZ37sll1qUeGG2rkXzHnMJTFWSNXPFudKqeIyznhl5ZN 7X9rQfLsxw4F6JulLMlo2JKtrbAttqw= X-Google-Smtp-Source: ACHHUZ6aankmXvB8085gNTlbF2PCEyPixSX1tutA3Hp2uz+l8puQYKdMvvxlOn7gLaJGVxpHKJ9HgVKK2Lk= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:90a:ea0b:b0:24e:2787:405d with SMTP id w11-20020a17090aea0b00b0024e2787405dmr607921pjy.5.1683305093970; Fri, 05 May 2023 09:44:53 -0700 (PDT) Date: Fri, 5 May 2023 09:44:52 -0700 In-Reply-To: <20230505152046.6575-5-mic@digikod.net> Mime-Version: 1.0 References: <20230505152046.6575-1-mic@digikod.net> <20230505152046.6575-5-mic@digikod.net> Message-ID: Subject: Re: [PATCH v1 4/9] KVM: x86: Add new hypercall to set EPT permissions From: Sean Christopherson To: "=?iso-8859-1?Q?Micka=EBl_Sala=FCn?=" Cc: Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Ingo Molnar , Kees Cook , Paolo Bonzini , Thomas Gleixner , Vitaly Kuznetsov , Wanpeng Li , Alexander Graf , Forrest Yuan Yu , James Morris , John Andersen , Liran Alon , "Madhavan T . Venkataraman" , Marian Rotariu , "Mihai =?utf-8?B?RG9uyJt1?=" , "=?utf-8?B?TmljdciZb3IgQ8OuyJt1?=" , Rick Edgecombe , Thara Gopinath , Will Deacon , Zahra Tarkhani , "=?utf-8?Q?=C8=98tefan_=C8=98icleru?=" , dev@lists.cloudhypervisor.org, kvm@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, x86@kernel.org, xen-devel@lists.xenproject.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable On Fri, May 05, 2023, Micka=EF=BF=BDl Sala=EF=BF=BDn wrote: > Add a new KVM_HC_LOCK_MEM_PAGE_RANGES hypercall that enables a guest to > set EPT permissions on a set of page ranges. IMO, manipulation of protections, both for memory (this patch) and CPU stat= e (control registers in the next patch) should come from userspace. I have n= o objection to KVM providing plumbing if necessary, but I think userspace nee= ds to to have full control over the actual state. One of the things that caused Intel's control register pinning series to st= all out was how to handle edge cases like kexec() and reboot. Deferring to use= rspace means the kernel doesn't need to define policy, e.g. when to unprotect memo= ry, and avoids questions like "should userspace be able to overwrite pinned con= trol registers". And like the confidential VM use case, keeping userspace in the loop is a b= ig beneifit, e.g. the guest can't circumvent protections by coercing userspace= into writing to protected memory . From xen-devel-bounces@lists.xenproject.org Fri May 05 16:50:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 16:50:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530535.826221 (Exim 4.92) (envelope-from ) id 1puydB-0004JF-Va; Fri, 05 May 2023 16:50:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530535.826221; Fri, 05 May 2023 16:50:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puydB-0004J8-PS; Fri, 05 May 2023 16:50:05 +0000 Received: by outflank-mailman (input) for mailman id 530535; Fri, 05 May 2023 16:50:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puydB-0004EG-7O for xen-devel@lists.xenproject.org; Fri, 05 May 2023 16:50:05 +0000 Received: from smtp-8fac.mail.infomaniak.ch (smtp-8fac.mail.infomaniak.ch [83.166.143.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e11dbe8c-eb64-11ed-8611-37d641c3527e; Fri, 05 May 2023 18:50:02 +0200 (CEST) Received: from smtp-3-0001.mail.infomaniak.ch (unknown [10.4.36.108]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4QCc9j6pyZzMq29R; Fri, 5 May 2023 18:50:01 +0200 (CEST) Received: from unknown by smtp-3-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4QCc9f1ZprzMpt9p; Fri, 5 May 2023 18:49:58 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e11dbe8c-eb64-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=digikod.net; s=20191114; t=1683305401; bh=RPOWf6TexJXD2F61Y+MwwaWrFJGnJ6O8Bzm/vPfHfEg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=KFqsV29bRBQXZVMUZDnW9//LbmTjZRdZ5CYSCvQtHGOugYPQZro4kAj1y6BuQuLMI 6ri9TjVKDdRi4alwo2oX8l60NkGjcqHjRzeAjieP1C8UKm+ZX2LPynTNK6yGyQO8br /DpBAABiiqrinOuFsaScnqzH8PtKHmistKR3ODTI= Message-ID: <6412bf27-4d05-eab8-3db1-d4efa44af3aa@digikod.net> Date: Fri, 5 May 2023 18:49:57 +0200 MIME-Version: 1.0 User-Agent: Subject: Re: [PATCH v1 2/9] KVM: x86/mmu: Add support for prewrite page tracking Content-Language: en-US To: Sean Christopherson Cc: Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Ingo Molnar , Kees Cook , Paolo Bonzini , Thomas Gleixner , Vitaly Kuznetsov , Wanpeng Li , Alexander Graf , Forrest Yuan Yu , James Morris , John Andersen , Liran Alon , "Madhavan T . Venkataraman" , Marian Rotariu , =?UTF-8?Q?Mihai_Don=c8=9bu?= , =?UTF-8?B?TmljdciZb3IgQ8OuyJt1?= , Rick Edgecombe , Thara Gopinath , Will Deacon , Zahra Tarkhani , =?UTF-8?Q?=c8=98tefan_=c8=98icleru?= , dev@lists.cloudhypervisor.org, kvm@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, x86@kernel.org, xen-devel@lists.xenproject.org References: <20230505152046.6575-1-mic@digikod.net> <20230505152046.6575-3-mic@digikod.net> From: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Infomaniak-Routing: alpha On 05/05/2023 18:28, Sean Christopherson wrote: > On Fri, May 05, 2023, Micka�l Sala�n wrote: >> diff --git a/arch/x86/include/asm/kvm_page_track.h b/arch/x86/include/asm/kvm_page_track.h >> index eb186bc57f6a..a7fb4ff888e6 100644 >> --- a/arch/x86/include/asm/kvm_page_track.h >> +++ b/arch/x86/include/asm/kvm_page_track.h >> @@ -3,6 +3,7 @@ >> #define _ASM_X86_KVM_PAGE_TRACK_H >> >> enum kvm_page_track_mode { >> + KVM_PAGE_TRACK_PREWRITE, > > Heh, just when I decide to finally kill off support for multiple modes[1] :-) > > My assessment from that changelog still holds true for this case: > > Drop "support" for multiple page-track modes, as there is no evidence > that array-based and refcounted metadata is the optimal solution for > other modes, nor is there any evidence that other use cases, e.g. for > access-tracking, will be a good fit for the page-track machinery in > general. > > E.g. one potential use case of access-tracking would be to prevent guest > access to poisoned memory (from the guest's perspective). In that case, > the number of poisoned pages is likely to be a very small percentage of > the guest memory, and there is no need to reference count the number of > access-tracking users, i.e. expanding gfn_track[] for a new mode would be > grossly inefficient. And for poisoned memory, host userspace would also > likely want to trap accesses, e.g. to inject #MC into the guest, and that > isn't currently supported by the page-track framework. > > A better alternative for that poisoned page use case is likely a > variation of the proposed per-gfn attributes overlay (linked), which > would allow efficiently tracking the sparse set of poisoned pages, and by > default would exit to userspace on access. > > Of particular relevance: > > - Using the page-track machinery is inefficient because the guest is likely > going to write-protect a minority of its memory. And this > > select KVM_EXTERNAL_WRITE_TRACKING if KVM > > is particularly nasty because simply enabling HEKI in the Kconfig will cause > KVM to allocate rmaps and gfn tracking. > > - There's no need to reference count the protection, i.e. 15 of the 16 bits of > gfn_track are dead weight. > > - As proposed, adding a second "mode" would double the cost of gfn tracking. > > - Tying the protections to the memslots will create an impossible-to-maintain > ABI because the protections will be lost if the owning memslot is deleted and > recreated. > > - The page-track framework provides incomplete protection and will lead to an > ongoing game of whack-a-mole, e.g. this patch catches the obvious cases by > adding calls to kvm_page_track_prewrite(), but misses things like kvm_vcpu_map(). > > - The scaling and maintenance issues will only get worse if/when someone tries > to support dropping read and/or execute permissions, e.g. for execute-only. > > - The code is x86-only, and is likely to stay that way for the foreseeable > future. > > The proposed alternative is to piggyback the memory attributes implementation[2] > that is being added (if all goes according to plan) for confidential VMs. This > use case (dropping permissions) came up not too long ago[3], which is why I have > a ready-made answer). > > I have no doubt that we'll need to solve performance and scaling issues with the > memory attributes implementation, e.g. to utilize xarray multi-range support > instead of storing information on a per-4KiB-page basis, but AFAICT, the core > idea is sound. And a very big positive from a maintenance perspective is that > any optimizations, fixes, etc. for one use case (CoCo vs. hardening) should also > benefit the other use case. > > [1] https://lore.kernel.org/all/20230311002258.852397-22-seanjc@google.com > [2] https://lore.kernel.org/all/Y2WB48kD0J4VGynX@google.com > [3] https://lore.kernel.org/all/Y1a1i9vbJ%2FpVmV9r@google.com I agree, I used this mechanism because it was easier at first to rely on a previous work, but while I was working on the MBEC support, I realized that it's not the optimal way to do it. I was thinking about using a new special EPT bit similar to EPT_SPTE_HOST_WRITABLE, but it may not be portable though. What do you think? From xen-devel-bounces@lists.xenproject.org Fri May 05 16:57:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 16:57:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530540.826230 (Exim 4.92) (envelope-from ) id 1puykT-00052n-MJ; Fri, 05 May 2023 16:57:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530540.826230; Fri, 05 May 2023 16:57:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puykT-00052g-IZ; Fri, 05 May 2023 16:57:37 +0000 Received: by outflank-mailman (input) for mailman id 530540; Fri, 05 May 2023 16:57:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puykS-00052a-FB for xen-devel@lists.xenproject.org; Fri, 05 May 2023 16:57:36 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2054.outbound.protection.outlook.com [40.107.7.54]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id eed0fb2b-eb65-11ed-b226-6b7b168915f2; Fri, 05 May 2023 18:57:35 +0200 (CEST) Received: from ZR2P278CA0020.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:46::6) by GV1PR08MB9913.eurprd08.prod.outlook.com (2603:10a6:150:86::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.27; Fri, 5 May 2023 16:57:04 +0000 Received: from VI1EUR03FT060.eop-EUR03.prod.protection.outlook.com (2603:10a6:910:46:cafe::1c) by ZR2P278CA0020.outlook.office365.com (2603:10a6:910:46::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.27 via Frontend Transport; Fri, 5 May 2023 16:57:04 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT060.mail.protection.outlook.com (100.127.144.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.12 via Frontend Transport; Fri, 5 May 2023 16:57:02 +0000 Received: ("Tessian outbound 5bb4c51d5a1f:v136"); Fri, 05 May 2023 16:57:02 +0000 Received: from 87bf513720db.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F94D8FE1-D7DD-4F4F-9C8B-2C238BECE399.1; Fri, 05 May 2023 16:56:51 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 87bf513720db.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 05 May 2023 16:56:51 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by VI1PR08MB10029.eurprd08.prod.outlook.com (2603:10a6:800:1c6::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Fri, 5 May 2023 16:56:46 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::bce1:f206:86af:31be]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::bce1:f206:86af:31be%6]) with mapi id 15.20.6363.021; Fri, 5 May 2023 16:56:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eed0fb2b-eb65-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jB/0Hk7/nAxsOggP+UuejWY5jFRViXw4KZif78sQ5yI=; b=NAmXMzoMzeI9AwWThvqN9C9R8yktIETQ4RQnrNxhh5zEHKhup/B+cKY4sVir+dSfuR/NEwbqyE689br406ZJgNl6iGPn6+//Q5Wm/XkMpdSLrD3q+fM6ZTkogdBuyYMj3b9/gHA0DkG+M17Zzki0SD/i0LMXAXdzgIo+4WiwOtc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: fd9d954d9f968ac8 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F8p38Tk3nM7Zplfgsp92r0saq6ivKtnz29cXENpOslN41qnvomKrHNwK8rLJyuBAHS5gft8hkui8r06UaqlaGQsTov7s+dpCVu3KS4gEgbibvXNOsHYQfasTdva3cVTKWM43LY591sj1/lSBTLkWIAFZcaWZqdJt8v5IXAUJOR7HLtLBZjEzcPuMEbXBDIZpfR57elfXO0gQcVrDBW904H7N+89YYZAhXLggGK7r9+bAQSd3dkxbGXYN8dOvdvQnjyjTo2N88+1VRYlHbOgnyh9GzIUnfZlLrMvP6T0OazLJmjtQBSkTBIsHpToOXEWMXApORZIwhxu7/YpIcl5FJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jB/0Hk7/nAxsOggP+UuejWY5jFRViXw4KZif78sQ5yI=; b=kUsV96PDFHVrz33ERXm5sfeKVfQlq7hFumGUPO+toN7rW37gil8xkBbgm5NdGTZu6HERCyJGD9VnFN7vnzCPiZXwAnehJS285Ni4rhShPj81ObCX0ey71s5dauR4fxabwfPp9gs8YZD+RoWAKd322PQWKWUC7+GYG+QzxdWmJhG2usE6TJbmRtLhh/ULD89uWkJLXJlqpQ7ko+r5nLbmrix8G2iH4yoWSdobW0/cRAn6to9qn5qz4yfH4byutXurJNcemrqD3FKzGJFqF8+INpsi+ICGAj+NjT8H/0yuUpJJZRGiJYqIf3fQkZ9DzEkeEE8ASpi2xDUvpaTXs6izzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jB/0Hk7/nAxsOggP+UuejWY5jFRViXw4KZif78sQ5yI=; b=NAmXMzoMzeI9AwWThvqN9C9R8yktIETQ4RQnrNxhh5zEHKhup/B+cKY4sVir+dSfuR/NEwbqyE689br406ZJgNl6iGPn6+//Q5Wm/XkMpdSLrD3q+fM6ZTkogdBuyYMj3b9/gHA0DkG+M17Zzki0SD/i0LMXAXdzgIo+4WiwOtc= From: Luca Fancellu To: Anthony PERARD CC: Xen-devel , Bertrand Marquis , Wei Chen , George Dunlap , Nick Rosbrook , Wei Liu , Juergen Gross , Christian Lindig , David Scott , =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?= , Christian Lindig Subject: Re: [PATCH v6 09/12] tools: add physinfo arch_capabilities handling for Arm Thread-Topic: [PATCH v6 09/12] tools: add physinfo arch_capabilities handling for Arm Thread-Index: AQHZdnKCeDO91wnv7UqBsQsgLvHj6a9HNTmAgAEfoACAA6ADgIAAA1aA Date: Fri, 5 May 2023 16:56:44 +0000 Message-ID: References: <20230424060248.1488859-1-luca.fancellu@arm.com> <20230424060248.1488859-10-luca.fancellu@arm.com> <4e6758c0-dd81-4963-8989-d941eba2b257@perard> <34A79CE8-FEE8-426B-810C-1E928E207724@arm.com> <9a0398b9-5b59-47aa-af34-a41133dc9e70@perard> In-Reply-To: <9a0398b9-5b59-47aa-af34-a41133dc9e70@perard> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.500.231) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|VI1PR08MB10029:EE_|VI1EUR03FT060:EE_|GV1PR08MB9913:EE_ X-MS-Office365-Filtering-Correlation-Id: e8551b1c-db14-43e1-e020-08db4d89c005 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: EEeTPM0c3nGwDIQBNpHDDfsG+cGwk3IFvg5f6PDV6+oJbK0Oo2jC3srU3AQzyZdEiZUMI70kXRJlWUJ/ONWBtQhQU7Xjd+X+hnQmI3PUMFyQ5dXho2xOCY1WAuQPhZfwFV19bBO9fB4Ulco9+knfo1/axLrJjTwz6huNjR4ICsxZfxwhL7kKcjiLVvTiea+ij49wwLON6IxqLrZi8yF1iXDEVYBDbIdvXiTtKPhFMR2TlNzGr6pQVir6Ei/uUSOSsgKBTgAbvT+TUbxVbAwpRUEfNVFMaTZViOXowytOnUQ2dTrwY1ku8CL85VLSH3WvhIl6pFGyFb842GL1uiH4i7O4huiGlAYk+BBGkIySgg4hStSHZdbzwbku7gZdzCp2HlX4jbkAjq+sBWzvvnYj/adQweLtnrUBe105YyIrjr3bzM+pxTQmOfP6F2ErE0Tq0Ia2KkaS9bbsXUpL/l06KEW/TKdtnUbxIiol47+3J+0hYc3KqUyE9hAbkNpwkgdT3HxXtgYRE0wzI1uIabvEfKOwYqK24j/OawqW1KGIMmC+b5CUIFIac+O0kCGth3HQs8wo/9NA/W8ZjAZU0fNKjLPzJDJeHUU4BoDAOczGM9LPG9kzgHSdJZXtO7ME9L1S X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(136003)(39850400004)(396003)(346002)(376002)(451199021)(33656002)(6512007)(53546011)(6506007)(26005)(38070700005)(86362001)(4326008)(6916009)(76116006)(66946007)(66556008)(66476007)(41300700001)(64756008)(66446008)(91956017)(6486002)(36756003)(478600001)(2616005)(71200400001)(5660300002)(7416002)(54906003)(122000001)(38100700002)(2906002)(186003)(316002)(8936002)(966005)(8676002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <1AC788189CF5354B8C5F37045CC57B67@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB10029 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c38bae8a-dd42-4703-a975-08db4d89b4f1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RLWMURlZ4Ffv6Vgq6GKgk4+Gj3UUOd+b/H/sRVeegDUxTCH7WkL8Ta2bpGg3GCStpMLl5+aMoe2Db+mAo7TJgm8Oh4Y3p0/GZT414d0UEL8Ep6z59uYOn3+G7+x2tj69f2uehM8/nF8nJNrbubS1/JYT1wD5hSm7SYB2C+d6iry3q7GSI+EU9MgXhaXgv5y2r1h/FqRMIlEQgR1/l9TK868kl4Aj1IRYjXwZyW3J/SPka23/Q+ubJFD2Prg0EAeh2WURWmYVMRQKsUirpfDOAq3A1OcDghpNTMvfpKsYLShZHfroAYzogoKhMibSVCD7OUOHxHO6w2NRIVZpNoh8CdvIX8gz4Y4qd9T+RFC6JG7ttjKOCjtSJGdwUILSh+cCvs/lJda7J2DbciDndyeWJjRhSq77L7i3L3hJR8xoqhDfbHp9jEmqnkkqGtxWYSpkleHsOnk40fcpUVK3EZySz7YAw3X7jqpX6HzMhtT58ffBe5yi1z9r5/l8a2Hw1CKZju91gu6NIv3YKfYerlS9UAGQpnjZgFGEuupqIfKmv9j3N9Lr7JVnDTuNzwNmpAia5XkwM2DbuE+yXxnMjgaqnfckrXssxKQq8Dqn2bDg+XZvV3aj4FwHbEiBUCRCve8Wywjv2aDy7Th2IHuMDEka7poh6ps71GGKzzobGxYcOIzH+RlIVPEvEDElC9DFaUad X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(39860400002)(136003)(376002)(451199021)(36840700001)(46966006)(40470700004)(47076005)(2616005)(186003)(336012)(40460700003)(2906002)(40480700001)(36756003)(86362001)(33656002)(82310400005)(82740400003)(356005)(81166007)(36860700001)(5660300002)(41300700001)(8936002)(6862004)(8676002)(966005)(4326008)(70586007)(70206006)(6486002)(316002)(478600001)(54906003)(107886003)(6506007)(6512007)(26005)(53546011);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 16:57:02.9432 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e8551b1c-db14-43e1-e020-08db4d89c005 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB9913 DQoNCj4gT24gNSBNYXkgMjAyMywgYXQgMTc6NDQsIEFudGhvbnkgUEVSQVJEIDxhbnRob255LnBl cmFyZEBjaXRyaXguY29tPiB3cm90ZToNCj4gDQo+IE9uIFdlZCwgTWF5IDAzLCAyMDIzIGF0IDA5 OjIzOjE5QU0gKzAwMDAsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+PiANCj4+IA0KPj4+IE9uIDIg TWF5IDIwMjMsIGF0IDE3OjEzLCBBbnRob255IFBFUkFSRCA8YW50aG9ueS5wZXJhcmRAY2l0cml4 LmNvbT4gd3JvdGU6DQo+Pj4gDQo+Pj4gT24gTW9uLCBBcHIgMjQsIDIwMjMgYXQgMDc6MDI6NDVB TSArMDEwMCwgTHVjYSBGYW5jZWxsdSB3cm90ZToNCj4+Pj4gZGlmZiAtLWdpdCBhL3Rvb2xzL2lu Y2x1ZGUveGVuLXRvb2xzL2FybS1hcmNoLWNhcGFiaWxpdGllcy5oIGIvdG9vbHMvaW5jbHVkZS94 ZW4tdG9vbHMvYXJtLWFyY2gtY2FwYWJpbGl0aWVzLmgNCj4+Pj4gbmV3IGZpbGUgbW9kZSAxMDA2 NDQNCj4+Pj4gaW5kZXggMDAwMDAwMDAwMDAwLi5hYzQ0YzhiMTQzNDQNCj4+Pj4gLS0tIC9kZXYv bnVsbA0KPj4+PiArKysgYi90b29scy9pbmNsdWRlL3hlbi10b29scy9hcm0tYXJjaC1jYXBhYmls aXRpZXMuaA0KPj4+PiBAQCAtMCwwICsxLDI4IEBADQo+Pj4+ICsvKiBTUERYLUxpY2Vuc2UtSWRl bnRpZmllcjogR1BMLTIuMCAqLw0KPj4+IA0KPj4+IERvIHlvdSBtZWFuIEdQTC0yLjAtb25seSA/ DQo+Pj4gDQo+Pj4gR1BMLTIuMCBpcyBkZXByZWNhdGVkIGJ5IHRoZSBTUERYIHByb2plY3QuDQo+ Pj4gDQo+Pj4gaHR0cHM6Ly9zcGR4Lm9yZy9saWNlbnNlcy9HUEwtMi4wLmh0bWwNCj4+PiANCj4+ PiANCj4+PiBCZXNpZGVzIHRoYXQsIHBhdGNoIGxvb2tzIGZpbmU6DQo+Pj4gUmV2aWV3ZWQtYnk6 IEFudGhvbnkgUEVSQVJEIDxhbnRob255LnBlcmFyZEBjaXRyaXguY29tPg0KPj4gDQo+PiBUaGFu a3MsIEnigJlsbCBmaXggaW4gdGhlIG5leHQgcHVzaCBhbmQgSeKAmWxsIGFkZCB5b3VyIFItYnkN Cj4gDQo+IEFjdHVhbGx5LCBjb3VsZCB5b3UgdXNlIExHUEwtMi4xLW9ubHkgaW5zdGVhZC4gQXMg dGhpcyBjb2RlIGlzIHRvIGJlDQo+IGluY2x1ZGVkIGluIGxpYnhsLCBhbmQgbGlieGwgaXMgc3Vw cG9zZWQgdG8gYmUgTEdQTC0yLjEtb25seSwgaXQgbWlnaHQNCj4gYmUgYmV0dGVyIHRvIGJlIG9u IHRoZSBzYWZlIHNpZGUgYW5kIHVzZSBMR1BMIGZvciB0aGlzIG5ldyBmaWxlLg0KPiANCj4gQXMg SSB1bmRlcnN0YW5kIChmcm9tIHJlY2VudCBkaXNjdXNzaW9uIGFib3V0IGxpYmFjcGksIGFuZCBh IHF1aWNrIHNlYXJjaA0KPiBvbmx5KSwgbWl4aW5nIEdQTCBhbmQgTEdQTCBjb2RlIG1pZ2h0IG1l YW4gdGhlIHJlc3VsdCBpcyBHUEwuIFNvIGp1c3QgdG8NCj4gYmUgb24gdGhlIHNhZmUgc2lkZSwg aGF2ZSB0aGlzIGZpbGUgYmVlbiBMR1BMIG1pZ2h0IGJlIGJldHRlci4gQW5kIGl0DQo+IHNlZW1z IHRoYXQgaXQgd291bGQgc3RpbGwgYmUgZmluZSB0byBpbmNsdWRlIHRoYXQgZmlsZSBpbiBHUEwg cHJvamVjdHMuDQo+IA0KPiBXb3VsZCB0aGF0IGJlIG9rIHdpdGggeW91Pw0KDQpZZXMgc3VyZSwg SSB3aWxsIHVzZSBMR1BMLTIuMS1vbmx5IGluc3RlYWQsIG5vIHByb2JsZW1zDQoNCj4gDQo+IENo ZWVycywNCj4gDQo+IC0tIA0KPiBBbnRob255IFBFUkFSRA0KDQoNCg== From xen-devel-bounces@lists.xenproject.org Fri May 05 17:01:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 17:01:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530546.826239 (Exim 4.92) (envelope-from ) id 1puyoF-0006a6-7w; Fri, 05 May 2023 17:01:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530546.826239; Fri, 05 May 2023 17:01:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puyoF-0006Zz-53; Fri, 05 May 2023 17:01:31 +0000 Received: by outflank-mailman (input) for mailman id 530546; Fri, 05 May 2023 17:01:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puyoD-0006Zt-Gs for xen-devel@lists.xenproject.org; Fri, 05 May 2023 17:01:29 +0000 Received: from smtp-42ac.mail.infomaniak.ch (smtp-42ac.mail.infomaniak.ch [2001:1600:4:17::42ac]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 792b0485-eb66-11ed-8611-37d641c3527e; Fri, 05 May 2023 19:01:27 +0200 (CEST) Received: from smtp-2-0001.mail.infomaniak.ch (unknown [10.5.36.108]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4QCcQt2Hl7zMqBQp; Fri, 5 May 2023 19:01:26 +0200 (CEST) Received: from unknown by smtp-2-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4QCcQl2DxJzMpxhN; Fri, 5 May 2023 19:01:19 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 792b0485-eb66-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=digikod.net; s=20191114; t=1683306086; bh=Gz496lWCqtEQGiFhDAnNdISGi/Ti3+4r45rZfW9pMhA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=0n9dK6yocwQrPoCyZhLiYaFRP+Rrc+AesC8U5DRpIAduml7GS9dfUNu27anU/Nq9H X7nX6pZrCIdpSbikNeBpaLS6XS4cxGwP59sL8dmULJe3HbrVsb+7OJzRnuN4Tp0SIU jtv1NK7dS4Wb0Fq0T7+YdNL/W/Ml/YkRAsZVmseM= Message-ID: <39125b11-659f-35f4-ac7a-a3ba31365950@digikod.net> Date: Fri, 5 May 2023 19:01:18 +0200 MIME-Version: 1.0 User-Agent: Subject: Re: [PATCH v1 4/9] KVM: x86: Add new hypercall to set EPT permissions Content-Language: en-US To: Sean Christopherson Cc: Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Ingo Molnar , Kees Cook , Paolo Bonzini , Thomas Gleixner , Vitaly Kuznetsov , Wanpeng Li , Alexander Graf , Forrest Yuan Yu , James Morris , John Andersen , Liran Alon , "Madhavan T . Venkataraman" , Marian Rotariu , =?UTF-8?Q?Mihai_Don=c8=9bu?= , =?UTF-8?B?TmljdciZb3IgQ8OuyJt1?= , Rick Edgecombe , Thara Gopinath , Will Deacon , Zahra Tarkhani , =?UTF-8?Q?=c8=98tefan_=c8=98icleru?= , dev@lists.cloudhypervisor.org, kvm@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, x86@kernel.org, xen-devel@lists.xenproject.org References: <20230505152046.6575-1-mic@digikod.net> <20230505152046.6575-5-mic@digikod.net> From: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Infomaniak-Routing: alpha On 05/05/2023 18:44, Sean Christopherson wrote: > On Fri, May 05, 2023, Micka�l Sala�n wrote: >> Add a new KVM_HC_LOCK_MEM_PAGE_RANGES hypercall that enables a guest to >> set EPT permissions on a set of page ranges. > > IMO, manipulation of protections, both for memory (this patch) and CPU state > (control registers in the next patch) should come from userspace. I have no > objection to KVM providing plumbing if necessary, but I think userspace needs to > to have full control over the actual state. By user space, do you mean the host user space or the guest user space? About the guest user space, I see several issues to delegate this kind of control: - These are restrictions only relevant to the kernel. - The threat model is to protect against user space as early as possible. - It would be more complex for no obvious gain. This patch series is an extension of the kernel self-protections mechanisms, and they are not configured by user space. > > One of the things that caused Intel's control register pinning series to stall > out was how to handle edge cases like kexec() and reboot. Deferring to userspace > means the kernel doesn't need to define policy, e.g. when to unprotect memory, > and avoids questions like "should userspace be able to overwrite pinned control > registers". The idea is to authenticate every changes. For kexec, the VMM (or something else) would have to authenticate the new kernel. Do you have something else in mind that could legitimately require such memory or CR changes? > > And like the confidential VM use case, keeping userspace in the loop is a big > beneifit, e.g. the guest can't circumvent protections by coercing userspace into > writing to protected memory . I don't understand this part. Are you talking about the host user space? How the guest could circumvent protections? From xen-devel-bounces@lists.xenproject.org Fri May 05 17:18:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 17:18:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530550.826250 (Exim 4.92) (envelope-from ) id 1puz4I-0008Fx-LE; Fri, 05 May 2023 17:18:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530550.826250; Fri, 05 May 2023 17:18:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puz4I-0008Fq-Hr; Fri, 05 May 2023 17:18:06 +0000 Received: by outflank-mailman (input) for mailman id 530550; Fri, 05 May 2023 17:18:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puz4G-0008Fk-GK for xen-devel@lists.xenproject.org; Fri, 05 May 2023 17:18:04 +0000 Received: from mail-pg1-x549.google.com (mail-pg1-x549.google.com [2607:f8b0:4864:20::549]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c9d079b0-eb68-11ed-8611-37d641c3527e; Fri, 05 May 2023 19:18:02 +0200 (CEST) Received: by mail-pg1-x549.google.com with SMTP id 41be03b00d2f7-517baf1bc93so1573140a12.0 for ; Fri, 05 May 2023 10:18:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c9d079b0-eb68-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1683307081; x=1685899081; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=SxwNvfp9yRlruqDpvJxkAnrRtCk6mE67Bd3BubjypxQ=; b=cXXc3M6yYogaCUYe2c+SrQc2MIdAmLJbXRkHUS9zG7xhw6MiEu2sitOw7/Gs8N+qYL oXgYeStpeUI6b4JASS0HSftlcCCRj/X7n1N9WbKprVd/yNpe36+Ro8ZtPUj3p6Ld50JH pqxQnHXwImJi8vy3sHQBgx80mx2LtgRBbImqJGjt3ifJhQvYtGUkTdTjALM0pcmAV+1D 6vpr8yMdnFBHG32elxIu/SKRWE8X5JKVIrtIk1RplILzJzkSNycRYJAr+Iqs6tbgmR/S ugGjoODz+nslHOA/c91Rz89LssATB8IAOjXVho0NUWdysNmyIv7F6uQ3Fm1u7pfzIzFf Lo4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683307081; x=1685899081; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=SxwNvfp9yRlruqDpvJxkAnrRtCk6mE67Bd3BubjypxQ=; b=HYrL+5HltJa36ItWjhdifRWAQ01e5NypMS9Z6GIH4+CHoUK6oxNkoYVmpd0Fh83CH/ XVwLXv553eqBL2KA7/nHFfl9LnqMsD3ekHPQhcNduHOzZNiTMsk62qghSWlQXJiT2o+j NvQXcFD7cBzsAm36Hvm9MT5+TzOOstLWB4xXoy30lXaAevVUo5yhCfIjUR/B0p7Q0xs9 VuzSSJgsmKexZzGtu+YZtzrweMzTimxq1mjpbbXKyvUF6p/qR6Fezc8v+BxixeBfOTuy 4RZijT/it1ld8YX1fxJy8zBViaFiwLmfme6KjD7rLORescHyEylExiGB+MuLRO7qCFVM juzA== X-Gm-Message-State: AC+VfDyOI5KJYVxgXbCrXRNjLryp5ocSlV1v++n9ui6dEu9hbM5W91M9 sAnS38Ygj8G5taGK1/fJitnIMcb7jTY= X-Google-Smtp-Source: ACHHUZ6uHVJCOE/ldx1w0hZ4Jds3kKbtJzThF7Cs+tG2xUZ0aBKcfdgS0+FUqexTD5OeTy31Ux2XqzCsKXc= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a63:8ac1:0:b0:513:efd4:d76 with SMTP id y184-20020a638ac1000000b00513efd40d76mr529931pgd.5.1683307080808; Fri, 05 May 2023 10:18:00 -0700 (PDT) Date: Fri, 5 May 2023 10:17:59 -0700 In-Reply-To: <39125b11-659f-35f4-ac7a-a3ba31365950@digikod.net> Mime-Version: 1.0 References: <20230505152046.6575-1-mic@digikod.net> <20230505152046.6575-5-mic@digikod.net> <39125b11-659f-35f4-ac7a-a3ba31365950@digikod.net> Message-ID: Subject: Re: [PATCH v1 4/9] KVM: x86: Add new hypercall to set EPT permissions From: Sean Christopherson To: "=?iso-8859-1?Q?Micka=EBl_Sala=FCn?=" Cc: Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Ingo Molnar , Kees Cook , Paolo Bonzini , Thomas Gleixner , Vitaly Kuznetsov , Wanpeng Li , Alexander Graf , Forrest Yuan Yu , James Morris , John Andersen , Liran Alon , "Madhavan T . Venkataraman" , Marian Rotariu , "Mihai =?utf-8?B?RG9uyJt1?=" , "=?utf-8?B?TmljdciZb3IgQ8OuyJt1?=" , Rick Edgecombe , Thara Gopinath , Will Deacon , Zahra Tarkhani , "=?utf-8?Q?=C8=98tefan_=C8=98icleru?=" , dev@lists.cloudhypervisor.org, kvm@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, x86@kernel.org, xen-devel@lists.xenproject.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable On Fri, May 05, 2023, Micka=EF=BF=BDl Sala=EF=BF=BDn wrote: >=20 > On 05/05/2023 18:44, Sean Christopherson wrote: > > On Fri, May 05, 2023, Micka=EF=BF=BDl Sala=EF=BF=BDn wrote: > > > Add a new KVM_HC_LOCK_MEM_PAGE_RANGES hypercall that enables a guest = to > > > set EPT permissions on a set of page ranges. > >=20 > > IMO, manipulation of protections, both for memory (this patch) and CPU = state > > (control registers in the next patch) should come from userspace. I ha= ve no > > objection to KVM providing plumbing if necessary, but I think userspace= needs to > > to have full control over the actual state. >=20 > By user space, do you mean the host user space or the guest user space? Host userspace, a.k.a. the VMM. Definitely not guest userspace. > About the guest user space, I see several issues to delegate this kind of > control: > - These are restrictions only relevant to the kernel. > - The threat model is to protect against user space as early as possible. > - It would be more complex for no obvious gain. >=20 > This patch series is an extension of the kernel self-protections mechanis= ms, > and they are not configured by user space. >=20 >=20 > >=20 > > One of the things that caused Intel's control register pinning series t= o stall > > out was how to handle edge cases like kexec() and reboot. Deferring to= userspace > > means the kernel doesn't need to define policy, e.g. when to unprotect = memory, > > and avoids questions like "should userspace be able to overwrite pinned= control > > registers". >=20 > The idea is to authenticate every changes. For kexec, the VMM (or somethi= ng > else) would have to authenticate the new kernel. Do you have something el= se > in mind that could legitimately require such memory or CR changes? I think we're on the same page, the VMM (host userspace) would need to ack = any changes. FWIW, SMM is another wart as entry to SMM clobbers CRs. Now that CONFIG_KV= M_SMM is a thing, the easiest solution would be to disallow coexistence with SMM,= though that might not be an option for many use cases (IIUC, QEMU-based deployment= s use SMM to implement secure boot). > > And like the confidential VM use case, keeping userspace in the loop is= a big > > beneifit, e.g. the guest can't circumvent protections by coercing users= pace into > > writing to protected memory . >=20 > I don't understand this part. Are you talking about the host user space? = How > the guest could circumvent protections? Host userspace. Guest configures a device buffer in write-protected memory= , gets a host (synthetic) device to write into the memory. From xen-devel-bounces@lists.xenproject.org Fri May 05 17:31:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 17:31:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530555.826259 (Exim 4.92) (envelope-from ) id 1puzH8-0002IO-Oj; Fri, 05 May 2023 17:31:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530555.826259; Fri, 05 May 2023 17:31:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puzH8-0002IH-Ls; Fri, 05 May 2023 17:31:22 +0000 Received: by outflank-mailman (input) for mailman id 530555; Fri, 05 May 2023 17:31:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puzH7-0002IB-L2 for xen-devel@lists.xenproject.org; Fri, 05 May 2023 17:31:21 +0000 Received: from mail-pg1-x549.google.com (mail-pg1-x549.google.com [2607:f8b0:4864:20::549]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a432f184-eb6a-11ed-8611-37d641c3527e; Fri, 05 May 2023 19:31:18 +0200 (CEST) Received: by mail-pg1-x549.google.com with SMTP id 41be03b00d2f7-528ab7097afso1444091a12.1 for ; Fri, 05 May 2023 10:31:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a432f184-eb6a-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1683307876; x=1685899876; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=qAOxuvlzoNXvPjKXSolx+GWj91lIdWlZPd2J+lepu+A=; b=YajfbfW6/wtHmrsLEvn1JkH+xI6N003d6IHsKYEdYKyQ4XBOf/ltXYAA8TT//7kx7h 8wJuT8QRTxgAHxrmJYouhI/7YgQTZm4mO10KjPCgeJdJMeuE5+h/bLiahSr81Gm/ecKB zDx4TcPrzUJvkSrnc51y29YU+lehMTLTirJ8zF6Y7AvgQTUcfYtQ37OJnKLDHV7h0smL PJn351waqBTnvLrthFCgyYl4ojqlUIUMdMZ9mvD3/1gMVpPtasu86bb2kRnLpCKWJhO/ k73RbTIykvnJHtRsAnnJa8Km60QZxDXHqCZ+6V04mHM7fIYa6vKKdRMKt3CdepgXl1bi CXtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683307876; x=1685899876; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=qAOxuvlzoNXvPjKXSolx+GWj91lIdWlZPd2J+lepu+A=; b=C724/H88uLdTPA5yUEB/JDJWbpNGEyaKFzyEhRWHwOv8IXTFt4P5wFcsJtZq0F2sXI ERRWX7B6BhXeKmVkpigkc8hS/D7DVd+hw5TPiffisg9Huxjwcq+HehW2vfmKXCKtXrpJ VZqCZn8K8vmsN3l6nEzXD6OMAXpUAaNyQAbK3+BACljsu4nV7Ds1EQd1VQwDzUk2SJu7 YZE+ONtAPgWa7VPa0wFyGBbg2Yn8HlZosHCaO4sSpXQUaqFAyWpJaOX1jW5U4CxnK7uS BxS+2s5LL7uMGgBET65myJhxl4ICXHndMoKu4Ew+uFYRRrt9x9w+WnO6xk8e0HPPp512 cTkA== X-Gm-Message-State: AC+VfDxxHF2gPqg7yriZxhGvg53ykIMb/6wnkSe8oW6d8IqSYU87H4YD KOGNOkj/Ocm0hfBBVZvCDGkEZHv5QYs= X-Google-Smtp-Source: ACHHUZ5AKtrEhFxY1tyiq165vY9w3gn7Qqc7+wcBsvMx8OszEeBENNSnTQn/dNy8sL8BRZ1pG6YlJeRQjuk= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a63:152:0:b0:52c:407a:2279 with SMTP id 79-20020a630152000000b0052c407a2279mr529292pgb.0.1683307876644; Fri, 05 May 2023 10:31:16 -0700 (PDT) Date: Fri, 5 May 2023 10:31:15 -0700 In-Reply-To: <6412bf27-4d05-eab8-3db1-d4efa44af3aa@digikod.net> Mime-Version: 1.0 References: <20230505152046.6575-1-mic@digikod.net> <20230505152046.6575-3-mic@digikod.net> <6412bf27-4d05-eab8-3db1-d4efa44af3aa@digikod.net> Message-ID: Subject: Re: [PATCH v1 2/9] KVM: x86/mmu: Add support for prewrite page tracking From: Sean Christopherson To: "=?iso-8859-1?Q?Micka=EBl_Sala=FCn?=" Cc: Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Ingo Molnar , Kees Cook , Paolo Bonzini , Thomas Gleixner , Vitaly Kuznetsov , Wanpeng Li , Alexander Graf , Forrest Yuan Yu , James Morris , John Andersen , Liran Alon , "Madhavan T . Venkataraman" , Marian Rotariu , "Mihai =?utf-8?B?RG9uyJt1?=" , "=?utf-8?B?TmljdciZb3IgQ8OuyJt1?=" , Rick Edgecombe , Thara Gopinath , Will Deacon , Zahra Tarkhani , "=?utf-8?Q?=C8=98tefan_=C8=98icleru?=" , dev@lists.cloudhypervisor.org, kvm@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, x86@kernel.org, xen-devel@lists.xenproject.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable On Fri, May 05, 2023, Micka=EF=BF=BDl Sala=EF=BF=BDn wrote: >=20 > On 05/05/2023 18:28, Sean Christopherson wrote: > > I have no doubt that we'll need to solve performance and scaling issues= with the > > memory attributes implementation, e.g. to utilize xarray multi-range su= pport > > instead of storing information on a per-4KiB-page basis, but AFAICT, th= e core > > idea is sound. And a very big positive from a maintenance perspective = is that > > any optimizations, fixes, etc. for one use case (CoCo vs. hardening) sh= ould also > > benefit the other use case. > >=20 > > [1] https://lore.kernel.org/all/20230311002258.852397-22-seanjc@google.= com > > [2] https://lore.kernel.org/all/Y2WB48kD0J4VGynX@google.com > > [3] https://lore.kernel.org/all/Y1a1i9vbJ%2FpVmV9r@google.com >=20 > I agree, I used this mechanism because it was easier at first to rely on = a > previous work, but while I was working on the MBEC support, I realized th= at > it's not the optimal way to do it. >=20 > I was thinking about using a new special EPT bit similar to > EPT_SPTE_HOST_WRITABLE, but it may not be portable though. What do you > think? On x86, SPTEs are even more ephemeral than memslots. E.g. for historical r= easons, KVM zaps all SPTEs if _any_ memslot is deleted, which is problematic if the= guest is moving around BARs, using option ROMs, etc. ARM's pKVM tracks metadata in its stage-2 PTEs, i.e. doesn't need an xarray= to otrack attributes, but that works only because pKVM is more privileged than= the host kernel, and the shared vs. private memory attribute that pKVM cares ab= out is very, very restricted in how it can be used and changed. I tried shoehorning private vs. shared metadata into x86's SPTEs in the pas= t, and it ended up being a constant battle with the kernel, e.g. page migration, a= nd with KVM itself, e.g. the above memslot mess. From xen-devel-bounces@lists.xenproject.org Fri May 05 17:34:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 17:34:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530560.826270 (Exim 4.92) (envelope-from ) id 1puzJo-0002tZ-63; Fri, 05 May 2023 17:34:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530560.826270; Fri, 05 May 2023 17:34:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puzJo-0002tS-2g; Fri, 05 May 2023 17:34:08 +0000 Received: by outflank-mailman (input) for mailman id 530560; Fri, 05 May 2023 17:34:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puzJn-0002tI-1s; Fri, 05 May 2023 17:34:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puzJm-0001LA-QM; Fri, 05 May 2023 17:34:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puzJm-0002V6-BS; Fri, 05 May 2023 17:34:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1puzJm-0001Ke-Ag; Fri, 05 May 2023 17:34:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jbbwYn/ck0Rj7JLCnR9kJ2LOj8Kc7y9k209DyP2cFUw=; b=jS99WrV2hOKAv54FoLqnVltcIz lkTWdDXLK/W+vh2ql3fxJULHInL4KyOr/pnGf1ZflDFThjzP2+KkB/sIJRhvHqCtBj3bTkqdZwgzy bkDAwkkiqt0imO/F180Z7AvUSel4hDWLhP31/r+RlFOy4aJ+wzhkGTwWFouTJ0101xd0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 180539: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=4419e74117b3bb17c61cd7a612b5801ab99ad547 X-Osstest-Versions-That: libvirt=b4f5e6c91b9871173de205f81b51cf06a833fcb1 From: osstest service owner Date: Fri, 05 May 2023 17:34:06 +0000 flight 180539 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/180539/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 180513 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 180513 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 180513 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: libvirt 4419e74117b3bb17c61cd7a612b5801ab99ad547 baseline version: libvirt b4f5e6c91b9871173de205f81b51cf06a833fcb1 Last test of basis 180513 2023-05-03 04:18:50 Z 2 days Failing since 180524 2023-05-04 04:18:45 Z 1 days 2 attempts Testing same since 180539 2023-05-05 04:18:48 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrea Bolognani Daniel Henrique Barboza jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git b4f5e6c91b..4419e74117 4419e74117b3bb17c61cd7a612b5801ab99ad547 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri May 05 17:57:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 17:57:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530597.826324 (Exim 4.92) (envelope-from ) id 1puzgI-00077k-9L; Fri, 05 May 2023 17:57:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530597.826324; Fri, 05 May 2023 17:57:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puzgI-00077E-2L; Fri, 05 May 2023 17:57:22 +0000 Received: by outflank-mailman (input) for mailman id 530597; Fri, 05 May 2023 17:57:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puzgF-0006Yg-LX for xen-devel@lists.xenproject.org; Fri, 05 May 2023 17:57:19 +0000 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [2a00:1450:4864:20::334]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4724a395-eb6e-11ed-b226-6b7b168915f2; Fri, 05 May 2023 19:57:19 +0200 (CEST) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-3f315735514so108096885e9.1 for ; Fri, 05 May 2023 10:57:19 -0700 (PDT) Received: from localhost.localdomain (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id b12-20020adfe30c000000b00306423904d6sm3053844wrj.45.2023.05.05.10.57.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 May 2023 10:57:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4724a395-eb6e-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1683309438; x=1685901438; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=d6Xql5GXzmjj1oZIuAO041sn7FGeLxwpchTwgQr2k5s=; b=D0MY9e7uNVDRqXI8XB8j0kmwsJFPVA7488rLg9o/qJf8WaepewgG92ynTMnwvzhgog jnRDm8hfKRRxDpUVXyyGyt+JvmlmGkJY3xY6+QDL+STz9HxbWQxpNgRjSyMfgvqjnbwt rjXVlyagTW6MNShOmpa3YA6meVEmH44P4I7Gw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683309438; x=1685901438; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d6Xql5GXzmjj1oZIuAO041sn7FGeLxwpchTwgQr2k5s=; b=cxvPjfpLe6hYnoyjg9omWzzY8z/PiA4Z0jC6uHqsLPAIN58aCB7MEg9hpvebBJDaTK Fu9S6ACj/3yfhLToUuifSjRRHs9w1pNQS4g3ECGumw7JDFUb1r7+RKervez7Fv3UbPf6 ud0X9ZRfSB0ZJlNrXFsAg1a8sMVx+iv5mrlfEkf56flGVpIZJqrRjj7QiwZrpO7GqUV4 LA3aaMpG/X0fIrfSyYjrgEEc21tDZSYoEfpfMFFm3qrGVu79dr7KjIzqbe6f/RFql83g pXMWso2cbHW70fre956KHcfIi3ZuvRLTxlooLrv1YXIfwXFH+KMdRp4CKrx7Uo0oYouM JGWA== X-Gm-Message-State: AC+VfDxs88VZWpP9t2Uei2hVs4NBKYmRNWs499F+z6CWqQbdOyR5agIu PYIsl1gYCYkVzDiZ2JdJfOl4z3iXdCtmfR3MDJM= X-Google-Smtp-Source: ACHHUZ7HbbsoCdRLwpKFkeV3KYcoZ2tYunzSdAflnU/lJ4BAM1XJOaXtZDpyoaNJmG9s2CmAuNrwFQ== X-Received: by 2002:a05:600c:3d9a:b0:3f1:6ebd:d995 with SMTP id bi26-20020a05600c3d9a00b003f16ebdd995mr2286776wmb.0.1683309438059; Fri, 05 May 2023 10:57:18 -0700 (PDT) From: Alejandro Vallejo To: Xen-devel Cc: Alejandro Vallejo , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 3/3] x86: Use CpuidUserDis if an AMD HVM guest toggles CPUID faulting Date: Fri, 5 May 2023 18:57:05 +0100 Message-Id: <20230505175705.18098-4-alejandro.vallejo@cloud.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230505175705.18098-1-alejandro.vallejo@cloud.com> References: <20230505175705.18098-1-alejandro.vallejo@cloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This is in order to aid guests of AMD hardware that we have exposed CPUID faulting to. If they try to modify the Intel MSR that enables the feature, trigger levelling so AMD's version of it (CpuidUserDis) is used instead. Signed-off-by: Alejandro Vallejo --- xen/arch/x86/msr.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c index ecf126566d..984aedf180 100644 --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -431,6 +431,13 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val) { bool old_cpuid_faulting = msrs->misc_features_enables.cpuid_faulting; + /* + * The boot CPU must support Intel's CPUID faulting _or_ + * AMD's CpuidUserDis. + */ + bool can_fault_cpuid = cpu_has_cpuid_faulting || + boot_cpu_has(X86_FEATURE_CPUID_USER_DIS); + rsvd = ~0ull; if ( cp->platform_info.cpuid_faulting ) rsvd &= ~MSR_MISC_FEATURES_CPUID_FAULTING; @@ -440,7 +447,7 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val) msrs->misc_features_enables.raw = val; - if ( v == curr && is_hvm_domain(d) && cpu_has_cpuid_faulting && + if ( v == curr && is_hvm_domain(d) && can_fault_cpuid && (old_cpuid_faulting ^ msrs->misc_features_enables.cpuid_faulting) ) ctxt_switch_levelling(v); break; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri May 05 17:57:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 17:57:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530596.826317 (Exim 4.92) (envelope-from ) id 1puzgH-00073q-SA; Fri, 05 May 2023 17:57:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530596.826317; Fri, 05 May 2023 17:57:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puzgH-00073j-Ox; Fri, 05 May 2023 17:57:21 +0000 Received: by outflank-mailman (input) for mailman id 530596; Fri, 05 May 2023 17:57:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puzgF-0006ws-LN for xen-devel@lists.xenproject.org; Fri, 05 May 2023 17:57:19 +0000 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [2a00:1450:4864:20::32f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 46190858-eb6e-11ed-8611-37d641c3527e; Fri, 05 May 2023 19:57:17 +0200 (CEST) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-3f19a80a330so14429995e9.2 for ; Fri, 05 May 2023 10:57:17 -0700 (PDT) Received: from localhost.localdomain (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id b12-20020adfe30c000000b00306423904d6sm3053844wrj.45.2023.05.05.10.57.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 May 2023 10:57:15 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46190858-eb6e-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1683309436; x=1685901436; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ubIK+XYgAIIZcyqAhGOfgJDl4JEExigDY8ufylt9qvw=; b=iUVAAHDp7zE3tBjYt2RmDBRUg2mKNMFd53nbCBsmyRuBT8fWhlFV7g8QWARjB8ygI2 fxg29XQGaCSIq5vPpT61NLslfCNlWHG1Q7E7ijP3E62sfacQeSvj/Lnc2ncHdxFrUXSU CBqrGZcqBIQtYo6p8QFP051fkN/U9nmKodnyQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683309436; x=1685901436; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ubIK+XYgAIIZcyqAhGOfgJDl4JEExigDY8ufylt9qvw=; b=Q3a3nADK+czQJIQYO1kVngJ8+cs3bIyDet1zsveRPSuAsfFFUQ4KlkHcG3N0iPwhs1 yYJ+Usd1v6f/RDpc2WfZat8wWUbyIATnvQNvWiQLSCqbjkqH8GrJi7ZiPIrt34oypskH /CJUudRzwR/F/h6LnxylnoCY7u/SA7md3imHHyoZ2P8NVA53LbZg6yWnAJQCcHdfdAt3 cqjK+fPzkfk91uzhfeGHkSQbwWaSzbpsfRsv4c42gRhRndx1US1dATa0l8oSZpyh1rGD Za9/NT2xi9qznx9ADgB0CMwpZ6yCP2h+U2ja9GwoN4pTk2v15dRSyI5pe522ZEws93EH UIOQ== X-Gm-Message-State: AC+VfDw0zTscQzc4gF5wEzVtk98dYm+QqzW//AQD++jwN06rZLICgt/n 06GD2/6vTLYf1bs15+lB5nJatKSaG8kdI2Xxoc8= X-Google-Smtp-Source: ACHHUZ6CrKzTndC7mGLtHexYNG/IMPc8wRB57ggtG2k3REK1pCr2UWWgO52VIUGy8rend9Fb/kIOwg== X-Received: by 2002:a05:600c:257:b0:3f1:800f:cc61 with SMTP id 23-20020a05600c025700b003f1800fcc61mr1771921wmj.13.1683309436339; Fri, 05 May 2023 10:57:16 -0700 (PDT) From: Alejandro Vallejo To: Xen-devel Cc: Alejandro Vallejo , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 2/3] x86: Add support for CpuidUserDis Date: Fri, 5 May 2023 18:57:04 +0100 Message-Id: <20230505175705.18098-3-alejandro.vallejo@cloud.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230505175705.18098-1-alejandro.vallejo@cloud.com> References: <20230505175705.18098-1-alejandro.vallejo@cloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Includes a refactor to move vendor-specific probes to vendor-specific files. Furthermore, because CpuIdUserDis is reported in Cpuid itself, the extended leaf containing that bit must be retrieved before calling c_early_init() Signed-off-by: Alejandro Vallejo --- xen/arch/x86/cpu/amd.c | 29 ++++++++++++++++++- xen/arch/x86/cpu/common.c | 51 ++++++++++++++++++---------------- xen/arch/x86/cpu/intel.c | 11 +++++++- xen/arch/x86/include/asm/amd.h | 1 + 4 files changed, 66 insertions(+), 26 deletions(-) diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c index caafe44740..9269015edd 100644 --- a/xen/arch/x86/cpu/amd.c +++ b/xen/arch/x86/cpu/amd.c @@ -271,8 +271,20 @@ static void __init noinline amd_init_levelling(void) { const struct cpuidmask *m = NULL; - if (probe_cpuid_faulting()) + /* + * If there's support for CpuidUserDis or CPUID faulting then + * we can skip levelling because CPUID accesses are trapped anyway. + * + * CPUID faulting is an Intel feature analogous to CpuidUserDis, so + * that can only be present when Xen is itself virtualized (because + * it can be emulated) + */ + if ((cpu_has_hypervisor && probe_cpuid_faulting()) || + boot_cpu_has(X86_FEATURE_CPUID_USER_DIS)) { + expected_levelling_cap |= LCAP_faulting; + levelling_caps |= LCAP_faulting; return; + } probe_masking_msrs(); @@ -363,6 +375,21 @@ static void __init noinline amd_init_levelling(void) ctxt_switch_masking = amd_ctxt_switch_masking; } +void amd_set_cpuid_user_dis(bool enable) +{ + const uint64_t msr_addr = MSR_K8_HWCR; + const uint64_t bit = K8_HWCR_CPUID_USER_DIS; + uint64_t val; + + rdmsrl(msr_addr, val); + + if (!!(val & bit) == enable) + return; + + val ^= bit; + wrmsrl(msr_addr, val); +} + /* * Check for the presence of an AMD erratum. Arguments are defined in amd.h * for each known erratum. Return 1 if erratum is found. diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c index edc4db1335..9bbb385db4 100644 --- a/xen/arch/x86/cpu/common.c +++ b/xen/arch/x86/cpu/common.c @@ -4,6 +4,7 @@ #include #include +#include #include #include #include @@ -131,17 +132,6 @@ bool __init probe_cpuid_faulting(void) uint64_t val; int rc; - /* - * Don't bother looking for CPUID faulting if we aren't virtualised on - * AMD or Hygon hardware - it won't be present. Likewise for Fam0F - * Intel hardware. - */ - if (((boot_cpu_data.x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) || - ((boot_cpu_data.x86_vendor == X86_VENDOR_INTEL) && - boot_cpu_data.x86 == 0xf)) && - !cpu_has_hypervisor) - return false; - if ((rc = rdmsr_safe(MSR_INTEL_PLATFORM_INFO, val)) == 0) raw_cpu_policy.platform_info.cpuid_faulting = val & MSR_PLATFORM_INFO_CPUID_FAULTING; @@ -155,8 +145,6 @@ bool __init probe_cpuid_faulting(void) return false; } - expected_levelling_cap |= LCAP_faulting; - levelling_caps |= LCAP_faulting; setup_force_cpu_cap(X86_FEATURE_CPUID_FAULTING); return true; @@ -179,8 +167,10 @@ static void set_cpuid_faulting(bool enable) void ctxt_switch_levelling(const struct vcpu *next) { const struct domain *nextd = next ? next->domain : NULL; + bool enable_cpuid_faulting; - if (cpu_has_cpuid_faulting) { + if (cpu_has_cpuid_faulting || + boot_cpu_has(X86_FEATURE_CPUID_USER_DIS)) { /* * No need to alter the faulting setting if we are switching * to idle; it won't affect any code running in idle context. @@ -201,12 +191,18 @@ void ctxt_switch_levelling(const struct vcpu *next) * an interim escape hatch in the form of * `dom0=no-cpuid-faulting` to restore the older behaviour. */ - set_cpuid_faulting(nextd && (opt_dom0_cpuid_faulting || - !is_control_domain(nextd) || - !is_pv_domain(nextd)) && - (is_pv_domain(nextd) || - next->arch.msrs-> - misc_features_enables.cpuid_faulting)); + enable_cpuid_faulting = nextd && (opt_dom0_cpuid_faulting || + !is_control_domain(nextd) || + !is_pv_domain(nextd)) && + (is_pv_domain(nextd) || + next->arch.msrs-> + misc_features_enables.cpuid_faulting); + + if (cpu_has_cpuid_faulting) + set_cpuid_faulting(enable_cpuid_faulting); + else + amd_set_cpuid_user_dis(enable_cpuid_faulting); + return; } @@ -415,6 +411,17 @@ static void generic_identify(struct cpuinfo_x86 *c) c->apicid = phys_pkg_id((ebx >> 24) & 0xFF, 0); c->phys_proc_id = c->apicid; + eax = cpuid_eax(0x80000000); + if ((eax >> 16) == 0x8000) + c->extended_cpuid_level = eax; + + /* + * These AMD-defined flags are out of place, but we need + * them early for the CPUID faulting probe code + */ + if (c->extended_cpuid_level >= 0x80000021) + c->x86_capability[FEATURESET_e21a] = cpuid_eax(0x80000021); + if (this_cpu->c_early_init) this_cpu->c_early_init(c); @@ -431,10 +438,6 @@ static void generic_identify(struct cpuinfo_x86 *c) (cpuid_ecx(CPUID_PM_LEAF) & CPUID6_ECX_APERFMPERF_CAPABILITY) ) __set_bit(X86_FEATURE_APERFMPERF, c->x86_capability); - eax = cpuid_eax(0x80000000); - if ((eax >> 16) == 0x8000) - c->extended_cpuid_level = eax; - /* AMD-defined flags: level 0x80000001 */ if (c->extended_cpuid_level >= 0x80000001) cpuid(0x80000001, &tmp, &tmp, diff --git a/xen/arch/x86/cpu/intel.c b/xen/arch/x86/cpu/intel.c index 71fc1a1e18..7e5c657758 100644 --- a/xen/arch/x86/cpu/intel.c +++ b/xen/arch/x86/cpu/intel.c @@ -226,8 +226,17 @@ static void cf_check intel_ctxt_switch_masking(const struct vcpu *next) */ static void __init noinline intel_init_levelling(void) { - if (probe_cpuid_faulting()) + /* Intel Fam0f is old enough that probing for CPUID faulting support + * introduces spurious #GP(0) when the appropriate MSRs are read, + * so skip it altogether. In the case where Xen is virtualized these + * MSRs may be emulated though, so we allow it in that case. + */ + if ((cpu_has_hypervisor || boot_cpu_data.x86 !=0xf) && + probe_cpuid_faulting()) { + expected_levelling_cap |= LCAP_faulting; + levelling_caps |= LCAP_faulting; return; + } probe_masking_msrs(); diff --git a/xen/arch/x86/include/asm/amd.h b/xen/arch/x86/include/asm/amd.h index a975d3de26..09ee52dc1c 100644 --- a/xen/arch/x86/include/asm/amd.h +++ b/xen/arch/x86/include/asm/amd.h @@ -155,5 +155,6 @@ extern bool amd_legacy_ssbd; extern bool amd_virt_spec_ctrl; bool amd_setup_legacy_ssbd(void); void amd_set_legacy_ssbd(bool enable); +void amd_set_cpuid_user_dis(bool enable); #endif /* __AMD_H__ */ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri May 05 17:57:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 17:57:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530595.826303 (Exim 4.92) (envelope-from ) id 1puzgE-0006cO-MU; Fri, 05 May 2023 17:57:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530595.826303; Fri, 05 May 2023 17:57:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puzgE-0006bM-HR; Fri, 05 May 2023 17:57:18 +0000 Received: by outflank-mailman (input) for mailman id 530595; Fri, 05 May 2023 17:57:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puzgD-0006Yg-6R for xen-devel@lists.xenproject.org; Fri, 05 May 2023 17:57:17 +0000 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [2a00:1450:4864:20::32e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 452f0c61-eb6e-11ed-b226-6b7b168915f2; Fri, 05 May 2023 19:57:15 +0200 (CEST) Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-3f18335a870so14131365e9.0 for ; Fri, 05 May 2023 10:57:15 -0700 (PDT) Received: from localhost.localdomain (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id b12-20020adfe30c000000b00306423904d6sm3053844wrj.45.2023.05.05.10.57.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 May 2023 10:57:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 452f0c61-eb6e-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1683309435; x=1685901435; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2enxHJVvB53hhS6w5p4MreN4cLpgSnyXWT9wrZUvS/4=; b=S6WP4jZQqFuckveRJuLLwmmlAWJchVAJAb9jg7PVGcyB+N56rwpZ2AwOxLV671Sz+Q FE2T1YlC1BiiUjDV2uZ8Nf7jEsflLCwPGXr13DpeKCJpId6dtgybo09rgCJXJtEamKwj 4KmLO8o+npkY8s8YD/XtuytYHkOev4UdELeDc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683309435; x=1685901435; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2enxHJVvB53hhS6w5p4MreN4cLpgSnyXWT9wrZUvS/4=; b=dyFGTTtTIzDFPoWnYnalHt6XIBX5P+U+N9mhMCc/bToBPbc16rc2O8qrM6eDeFjlgZ 5uWLn14Jyg52kGqfeYw6AsXWP6by89P+Bk1yxb1g+/xJP6ENip//huhCmJWmSLKC2vb9 JAkhGDSXX9VVmXsuV9ID5Eb0UyHXhVDbmWWbGk6Z3HVtBx2ybwjC1Qf1/O7pGmlhVRUk 870kGyeQ5iN2uIkZ0HqfZR8JlCrUXH0z1vW3SRxZZlDdLvmCTIMqpnJb4XlJdiLie8Qx B1dMRpLaZzF7b6Uu99ryc1klcbyu/psciB3wFyk+aFhLZckwLV65WUEOFIaXkhxwjoaB NeFQ== X-Gm-Message-State: AC+VfDzV5gCsQncdbCCJAFPutJXlTvGeEnEoKfYb6Q0v0l+Lu4gFfDFH A+1FXNpq1V5HLYbEyaazgGjLvmIxJo32bWzQjAE= X-Google-Smtp-Source: ACHHUZ5sPykgAxfLbTpChhsume9wrclYkH7/nFknVv7g/8xzCXnmQiEIye5TXtK5me/BScAefzZtWg== X-Received: by 2002:a05:600c:2310:b0:3f3:fe82:ee79 with SMTP id 16-20020a05600c231000b003f3fe82ee79mr1707787wmo.23.1683309434835; Fri, 05 May 2023 10:57:14 -0700 (PDT) From: Alejandro Vallejo To: Xen-devel Cc: Alejandro Vallejo , Wei Liu , Anthony PERARD , Juergen Gross , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH 1/3] x86: Add AMD's CpuidUserDis bit definitions Date: Fri, 5 May 2023 18:57:03 +0100 Message-Id: <20230505175705.18098-2-alejandro.vallejo@cloud.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230505175705.18098-1-alejandro.vallejo@cloud.com> References: <20230505175705.18098-1-alejandro.vallejo@cloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit AMD reports support for CpuidUserDis in CPUID and provides the toggle in HWCR. This patch adds the positions of both of those bits to both xen and tools. No functional change. Signed-off-by: Alejandro Vallejo --- tools/libs/light/libxl_cpuid.c | 1 + tools/misc/xen-cpuid.c | 2 ++ xen/arch/x86/include/asm/msr-index.h | 1 + xen/include/public/arch-x86/cpufeatureset.h | 1 + 4 files changed, 5 insertions(+) diff --git a/tools/libs/light/libxl_cpuid.c b/tools/libs/light/libxl_cpuid.c index 5f0bf93810..4d2fab5414 100644 --- a/tools/libs/light/libxl_cpuid.c +++ b/tools/libs/light/libxl_cpuid.c @@ -317,6 +317,7 @@ int libxl_cpuid_parse_config(libxl_cpuid_policy_list *cpuid, const char* str) {"lfence+", 0x80000021, NA, CPUID_REG_EAX, 2, 1}, {"nscb", 0x80000021, NA, CPUID_REG_EAX, 6, 1}, + {"cpuid-user-dis", 0x80000021, NA, CPUID_REG_EAX, 17, 1}, {"maxhvleaf", 0x40000000, NA, CPUID_REG_EAX, 0, 8}, diff --git a/tools/misc/xen-cpuid.c b/tools/misc/xen-cpuid.c index d7efc59d31..8ec143ebc8 100644 --- a/tools/misc/xen-cpuid.c +++ b/tools/misc/xen-cpuid.c @@ -199,6 +199,8 @@ static const char *const str_e21a[32] = { [ 2] = "lfence+", [ 6] = "nscb", + + /* 16 */ [17] = "cpuid-user-dis", }; static const char *const str_7b1[32] = diff --git a/xen/arch/x86/include/asm/msr-index.h b/xen/arch/x86/include/asm/msr-index.h index fa771ed0b5..082fb2e0d9 100644 --- a/xen/arch/x86/include/asm/msr-index.h +++ b/xen/arch/x86/include/asm/msr-index.h @@ -337,6 +337,7 @@ #define MSR_K8_HWCR 0xc0010015 #define K8_HWCR_TSC_FREQ_SEL (1ULL << 24) +#define K8_HWCR_CPUID_USER_DIS (1ULL << 35) #define MSR_K7_FID_VID_CTL 0xc0010041 #define MSR_K7_FID_VID_STATUS 0xc0010042 diff --git a/xen/include/public/arch-x86/cpufeatureset.h b/xen/include/public/arch-x86/cpufeatureset.h index 12e3dc80c6..623dcb1bce 100644 --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -287,6 +287,7 @@ XEN_CPUFEATURE(AVX_IFMA, 10*32+23) /*A AVX-IFMA Instructions */ /* AMD-defined CPU features, CPUID level 0x80000021.eax, word 11 */ XEN_CPUFEATURE(LFENCE_DISPATCH, 11*32+ 2) /*A LFENCE always serializing */ XEN_CPUFEATURE(NSCB, 11*32+ 6) /*A Null Selector Clears Base (and limit too) */ +XEN_CPUFEATURE(CPUID_USER_DIS, 11*32+17) /* CPUID disable for non-privileged software */ /* Intel-defined CPU features, CPUID level 0x00000007:1.ebx, word 12 */ XEN_CPUFEATURE(INTEL_PPIN, 12*32+ 0) /* Protected Processor Inventory Number */ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri May 05 17:57:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 17:57:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530594.826297 (Exim 4.92) (envelope-from ) id 1puzgE-0006Z0-E1; Fri, 05 May 2023 17:57:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530594.826297; Fri, 05 May 2023 17:57:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puzgE-0006Yt-AN; Fri, 05 May 2023 17:57:18 +0000 Received: by outflank-mailman (input) for mailman id 530594; Fri, 05 May 2023 17:57:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puzgC-0006Yg-Gj for xen-devel@lists.xenproject.org; Fri, 05 May 2023 17:57:16 +0000 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [2a00:1450:4864:20::32f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 44447875-eb6e-11ed-b226-6b7b168915f2; Fri, 05 May 2023 19:57:15 +0200 (CEST) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-3f178da21afso14987995e9.1 for ; Fri, 05 May 2023 10:57:14 -0700 (PDT) Received: from localhost.localdomain (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id b12-20020adfe30c000000b00306423904d6sm3053844wrj.45.2023.05.05.10.57.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 May 2023 10:57:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 44447875-eb6e-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1683309433; x=1685901433; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=q1h9+sOy91h+3M0AKDC27QolVTLW8C6xg301Hs3wQXQ=; b=NUt+BCXAFaIMCWuvrEKzAzsu+FJJ0FZB1k8sG8goSYxw5RnMZSuDvCbxdo8aMCjwB8 FXzaSVlQQ5g81Ek0bfrH1Zf00cyXAi4RN++m14nbcMCFbdFQVc9A7W6/N9mQpNL8k4/Z EMw7vlgtIJrqy/I/QMDdx9a3MMIYdd7repEjY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683309433; x=1685901433; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=q1h9+sOy91h+3M0AKDC27QolVTLW8C6xg301Hs3wQXQ=; b=XFz9bxiDSE7pmes0mQN0QP4Hg/p5POeY5dmGGnL133UK2s2mnaPM8cOElMtEnccco2 1ESgywIjgjk6NQg/b35zZvxS079OnNEnlMTRg0J+BvHXHH28+zwnj4MImTn3ySwB0TmH tgRn3UIA5AryLktgjYK781K4rmwEi1exwLgUxNaogvPgkPAsaiAO/A+soNTf3vL9c7pF JbeXaCJQAJRmuUHPZUK3JcPVAhJA2jT94nxBkQckpFHlhZTkRZr3s2ARbwNNBqUkXX8x b9bvYFyn/gbm7qlTq8wckjj1OvmTJuJJd2f09EnlP3EDVdi4Wtj0KdmcIhB1TP7UF7K4 wZCg== X-Gm-Message-State: AC+VfDzovUQnLXlFiYoymaJfiV5wnyvi2UAMrTHiwwaYjbhNa0Jeaf0r wc57xCDFWm1ZLQo2vM0Ll2gpD9wz/I9jJHGP13g= X-Google-Smtp-Source: ACHHUZ7G8+HYT3oqu2wvuuAHP58jwcanfBtV62hU5W0nwG7NX2mhAIPVxD5VmNHQXpKHIg0M18Bqug== X-Received: by 2002:a7b:c44c:0:b0:3ed:f5b5:37fc with SMTP id l12-20020a7bc44c000000b003edf5b537fcmr1589134wmi.1.1683309432993; Fri, 05 May 2023 10:57:12 -0700 (PDT) From: Alejandro Vallejo To: Xen-devel Cc: Alejandro Vallejo , Wei Liu , Anthony PERARD , Juergen Gross , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH 0/3] Add CpuidUserDis support Date: Fri, 5 May 2023 18:57:02 +0100 Message-Id: <20230505175705.18098-1-alejandro.vallejo@cloud.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Nowadays AMD supports trapping the CPUID instruction from ring3 to ring0, (CpuidUserDis) akin to Intel's "CPUID faulting". There is a difference in that the toggle bit is in a different MSR and the support bit is in CPUID itself rather than yet another MSR. This patch enables AMD hosts to use it when supported in order to provide correct CPUID contents to PV guests. Also allows HVM guests to use CpuidUserDis via emulated "CPUID faulting". Patch 1 merely adds definitions to various places in CPUID and MSR Patch 2 adds support for CpuidUserDis, hooking it in the probing path and the context switching path. Patch 3 enables HVM guests to use CpuidUserDis as if it was CPUID faulting, saving an avoidable roundtrip through the hypervisor at fault handling. Alejandro Vallejo (3): x86: Add AMD's CpuidUserDis bit definitions x86: Add support for CpuidUserDis x86: Use CpuidUserDis if an AMD HVM guest toggles CPUID faulting tools/libs/light/libxl_cpuid.c | 1 + tools/misc/xen-cpuid.c | 2 + xen/arch/x86/cpu/amd.c | 29 +++++++++++- xen/arch/x86/cpu/common.c | 51 +++++++++++---------- xen/arch/x86/cpu/intel.c | 11 ++++- xen/arch/x86/include/asm/amd.h | 1 + xen/arch/x86/include/asm/msr-index.h | 1 + xen/arch/x86/msr.c | 9 +++- xen/include/public/arch-x86/cpufeatureset.h | 1 + 9 files changed, 79 insertions(+), 27 deletions(-) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri May 05 18:16:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 18:16:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530607.826336 (Exim 4.92) (envelope-from ) id 1puzy5-0002Jw-PA; Fri, 05 May 2023 18:15:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530607.826336; Fri, 05 May 2023 18:15:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puzy5-0002Jp-MI; Fri, 05 May 2023 18:15:45 +0000 Received: by outflank-mailman (input) for mailman id 530607; Fri, 05 May 2023 18:15:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puzy4-0002Jh-Ag for xen-devel@lists.xenproject.org; Fri, 05 May 2023 18:15:44 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d6d0f8cc-eb70-11ed-8611-37d641c3527e; Fri, 05 May 2023 20:15:40 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d6d0f8cc-eb70-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683310540; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=YVh+aeiq4kunPj4X2l6hp6BB23HOhzrXAxxBHMLanWU=; b=IqamYFkJhiLKp4/BBN7UYgMWgRT+DNu4/7ihKNNrzHVcxs7IaPFQZZta asyPmSu3EPR5iPLFPIhOb/r+Te487QeapfGwFlCmTPdPqPhkbxJ84jWJA dsKESNIKsMBJd+J7wL27JeyGG3iQuPJ2pjaCMWgDBE82vexua6fy/Pkvs w=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 108058101 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:aGceR62GQmxPirbjD/bD5YNxkn2cJEfYwER7XKvMYLTBsI5bpz0Ez zcWDzzQaPuDZDbzLd90Otvjph4FvJSAnd9rQFA/pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS+XuDgNyo4GlD5gFmOKgR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfI1929 PIJFgg3YD+Jmr2Q4K6pdPtJr5F2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP ZNfMGcxKk2aOHWjOX9OYH46tM6uimPybHtzr1WNqLBsy2PS0BZwwP7mN9+9ltmiHJ0FxhvI/ zqfl4j/KhpGLsKi9wjfy232xbD0wTH8G4YcLLLto5aGh3XMnzdOWXX6T2CTsfS/z0KzRd9bA 0gV4TY167g/8lSxSdvwVAH+p2SL1iPwQPIJTbd8slvUjPOJvUDAXDNsoiN9hMIOlvEORDI76 GezkfzjGGNJkKGHd2C43+LBxd+tAhT5PVPudAddE1teuYSy+dhs5v7cZo09SfDo17UZDRm1m mnX93Zm2t3/mOZRj82GEUb7byVAT3QjZio8/U3pU22s9WuVj6b1NtXzuTA3ARutRbt1r2VtX 1BewaByFMhUUfmweNWlGY3h5o2B6fefKyH7ilVyBZQn/DnF0yf9LdsKum8ifRYxaZlsldrVX aMukVkJuM870IWCNMebnL5d++x1lPO9RLwJp9jfb8ZUY4gZSTJrCBpGPBbKt0i0yRhErE3KE cvDGSpaJSpAWPsPIfvfb7t17ILHMQhknDKJGc6jk0j2uVdcDVbMIYo43JK1RrhRxMu5TM/9q r6z6+PiJ81jbdDD IronPort-HdrOrdr: A9a23:vkstY6FprdPlgHFlpLqEGMeALOsnbusQ8zAXPiBKJCC9E/bo8/ xG+c5w6faaslkssR0b9+xoW5PwJE80l6QFgrX5VI3KNGXbUQ2TTb2KhbGI/9SKIVydygcy78 ddmtNFebrN5VgRt7eH3OG7eexQv+VuJsqT9JnjJ3QGd3AaV0l5hT0JbDpyiidNNXN77ZxSLu vk2uN34wCOVF4wdcqBCnwMT4H41qD2fMKPW29/O/Y/gjP+9g+V1A== X-Talos-CUID: 9a23:vLLr225C7EuUA7wjNNss1nAsG840TEXnwljaPhCeKXp7dq+wYArF X-Talos-MUID: 9a23:pBUAvAROuaMk+To9RXTn2Ct8CflauZ2xUgNSqskUvIqAOxR/bmI= X-IronPort-AV: E=Sophos;i="5.99,252,1677560400"; d="scan'208";a="108058101" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper Subject: [PATCH v2 0/2] LICENSES improvements/corrections Date: Fri, 5 May 2023 19:15:26 +0100 Message-ID: <20230505181528.3587485-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Noticed in light of the recent LGPL changes to libacpi, but sadly only after the fact. Minor updates in the second patch. Andrew Cooper (2): LICENSES: Improve the legibility of these files LICENSES: Remove the use of deprecated SPDX tags LICENSES/BSD-2-Clause | 4 ++++ LICENSES/BSD-3-Clause | 4 ++++ LICENSES/BSD-3-Clause-Clear | 4 ++++ LICENSES/CC-BY-4.0 | 5 +++++ LICENSES/GPL-2.0 | 21 ++++++++++++++------- LICENSES/LGPL-2.0 | 17 ++++++++++++----- LICENSES/LGPL-2.1 | 17 ++++++++++++----- LICENSES/MIT | 4 ++++ tools/libacpi/Makefile | 2 +- tools/libacpi/acpi2_0.h | 2 +- tools/libacpi/build.c | 2 +- tools/libacpi/dsdt.asl | 2 +- tools/libacpi/dsdt_acpi_info.asl | 2 +- tools/libacpi/libacpi.h | 2 +- tools/libacpi/mk_dsdt.c | 2 +- tools/libacpi/ssdt_laptop_slate.asl | 2 +- tools/libacpi/ssdt_pm.asl | 2 +- tools/libacpi/ssdt_s3.asl | 2 +- tools/libacpi/ssdt_s4.asl | 2 +- tools/libacpi/ssdt_tpm.asl | 2 +- tools/libacpi/static_tables.c | 2 +- 21 files changed, 72 insertions(+), 30 deletions(-) base-commit: e93e635e142d45e3904efb4a05e2b3b52a708b4f -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Fri May 05 18:16:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 18:16:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530608.826347 (Exim 4.92) (envelope-from ) id 1puzyJ-0002cR-5h; Fri, 05 May 2023 18:15:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530608.826347; Fri, 05 May 2023 18:15:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puzyJ-0002cK-2p; Fri, 05 May 2023 18:15:59 +0000 Received: by outflank-mailman (input) for mailman id 530608; Fri, 05 May 2023 18:15:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puzyH-0002Jh-C3 for xen-devel@lists.xenproject.org; Fri, 05 May 2023 18:15:57 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id df830fc7-eb70-11ed-8611-37d641c3527e; Fri, 05 May 2023 20:15:55 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: df830fc7-eb70-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683310555; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=E0aZkvgxxKojXoFk3hMdpQ/EPEKioiMdFoNuS2VCJ6c=; b=YHf2gqZXFdDXCTIqNXC/4ekQw7m2RQOlKA+xP9j1S14KCz1o/n7n4Mia RF0ep75VvHlczBPadilQAVvLUanwnWaZPTOIKkV6F8S2/9DHxGLHyH5+o ZRBfuvXER0GZwusYp/UJ8HmJk99owbMWo/TuNmQS0/eEse2FPruhayR3+ o=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 110484431 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:lwgeXqKav5MbL6mWFE+RyJUlxSXFcZb7ZxGr2PjKsXjdYENS0GYHy DEWWGnUa/2MN2Okctl/OYi1pBxQv8KAmoMwTwtlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPSwP9TlK6q4mhA4wRjPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c56JT9Q0 qEyNAwwTRaBjNy4kZWETuxV05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpNU6bC/FMEg5/5JYWteGknHTgNRZfr0qYv/Ef6GnP1g1hlrPqNbI5f/TTHJ0JzhrE/ TuuE2LRXCEVL+y6khO+ymu3gsXSjCjYV8FJLejtnhJtqALKnTFCYPEMbnOguuWwgEO6X9NZK mQX9zAooKx081akJvHiWzWorXjCuQQTM/JSDuk75Qel2qfSpQGDCQAsTDRMddgnv88eXiEx2 xmCmNaBLSxitviZRGyQ8p+QrCiuIm4FIGkafygGQAAZpd75r+kOYgnnF4g5VvTv15usRG+2m mrRxMQju1kNpcMvibucoHrbvw+PoJrCcABkwTrTW1vwu2uVe7WZi5yUBUnztKgQd9zEHwDY4 xDoiODFsrlQUMjleDilBbxUQer3v6vt3Cj02wYHInU3y9i6F5dPl6h06So2GkpmO91sldTBM B6K4lM5CHO+0RKXgU5Lj2GZUZ5CIVDIT4iNaxwtRoMmjmJNXAGG5jpyQkWbwnrglkMh+YlmZ 8fAK5zyUS9LUf84pNZTe9rxLJdxnnxurY8tbcmTI+ubPUq2OyfOFOZt3KqmZeEl9qKUyDjoH yJkH5LSkX13CbSuChQ7BKZPdTjm21BnX8GpwyGWH8bfSjdb9JYJUaaAm+9/I9A5zsy4VI7gp xmAZ6OR83Kn7VWvFOlAQioLhG/HNXqnkU8GAA== IronPort-HdrOrdr: A9a23:7VfDn6gLuWahrjDjHmeJ6yK0aXBQXioji2hC6mlwRA09TyX5ra 2TdZUgpHvJYVMqMk3I9uruBEDtex3hHP1OkOws1NWZLWrbUQKTRekP0WKF+Vzd8kXFndK1vp 0QEZSWZueRMbEAt7ec3OG5eexQvOVu8sqT9JjjJ6EGd3AVV0lihT0JezpyCidNNW977QJSLu vn2iJAzQDQAEg/X4CAKVQuefPMnNHPnIKOW296O/Z2gDP+9Q9B8dTBYmOl4is= X-Talos-CUID: =?us-ascii?q?9a23=3AS+gvzWrnMFi8+sXQzgQT8BXmUc0BLGP6kV3MH3K?= =?us-ascii?q?bD2RidrPEbmCU/Zoxxg=3D=3D?= X-Talos-MUID: =?us-ascii?q?9a23=3AQuCpGAxDjWEA7q8buBmhWg+dl6yaqPqeB1s9tM4?= =?us-ascii?q?vgPGdLihaJiaWrzv0GbZyfw=3D=3D?= X-IronPort-AV: E=Sophos;i="5.99,252,1677560400"; d="scan'208";a="110484431" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Julien Grall Subject: [PATCH v2 1/2] LICENSES: Improve the legibility of these files Date: Fri, 5 May 2023 19:15:27 +0100 Message-ID: <20230505181528.3587485-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230505181528.3587485-1-andrew.cooper3@citrix.com> References: <20230505181528.3587485-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain A few newlines go a very long way. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich --- CC: George Dunlap CC: Jan Beulich CC: Stefano Stabellini CC: Wei Liu CC: Julien Grall --- LICENSES/BSD-2-Clause | 4 ++++ LICENSES/BSD-3-Clause | 4 ++++ LICENSES/BSD-3-Clause-Clear | 4 ++++ LICENSES/CC-BY-4.0 | 5 +++++ LICENSES/GPL-2.0 | 6 ++++++ LICENSES/LGPL-2.0 | 6 ++++++ LICENSES/LGPL-2.1 | 6 ++++++ LICENSES/MIT | 4 ++++ 8 files changed, 39 insertions(+) diff --git a/LICENSES/BSD-2-Clause b/LICENSES/BSD-2-Clause index da366e2ce50b..694d8c93221c 100644 --- a/LICENSES/BSD-2-Clause +++ b/LICENSES/BSD-2-Clause @@ -1,10 +1,14 @@ Valid-License-Identifier: BSD-2-Clause + SPDX-URL: https://spdx.org/licenses/BSD-2-Clause.html + Usage-Guide: + To use the BSD 2-clause "Simplified" License put the following SPDX tag/value pair into a comment according to the placement guidelines in the licensing rules documentation: SPDX-License-Identifier: BSD-2-Clause + License-Text: Copyright (c) . All rights reserved. diff --git a/LICENSES/BSD-3-Clause b/LICENSES/BSD-3-Clause index 34c7f057c8d5..1441947f92e0 100644 --- a/LICENSES/BSD-3-Clause +++ b/LICENSES/BSD-3-Clause @@ -1,10 +1,14 @@ Valid-License-Identifier: BSD-3-Clause + SPDX-URL: https://spdx.org/licenses/BSD-3-Clause.html + Usage-Guide: + To use the BSD 3-clause "New" or "Revised" License put the following SPDX tag/value pair into a comment according to the placement guidelines in the licensing rules documentation: SPDX-License-Identifier: BSD-3-Clause + License-Text: Copyright (c) . All rights reserved. diff --git a/LICENSES/BSD-3-Clause-Clear b/LICENSES/BSD-3-Clause-Clear index e53b56092b90..2b27f24a65a0 100644 --- a/LICENSES/BSD-3-Clause-Clear +++ b/LICENSES/BSD-3-Clause-Clear @@ -1,10 +1,14 @@ Valid-License-Identifier: BSD-3-Clause-Clear + SPDX-URL: https://spdx.org/licenses/BSD-3-Clause-Clear.html + Usage-Guide: + To use the BSD 3-clause "Clear" License put the following SPDX tag/value pair into a comment according to the placement guidelines in the licensing rules documentation: SPDX-License-Identifier: BSD-3-Clause-Clear + License-Text: The Clear BSD License diff --git a/LICENSES/CC-BY-4.0 b/LICENSES/CC-BY-4.0 index 27dfefa95ccf..4197ceb180ff 100644 --- a/LICENSES/CC-BY-4.0 +++ b/LICENSES/CC-BY-4.0 @@ -1,15 +1,20 @@ Valid-License-Identifier: CC-BY-4.0 + SPDX-URL: https://spdx.org/licenses/CC-BY-4.0 + Usage-Guide: + Do NOT use this license for code, but it's acceptable for content like artwork or documentation. When using it for the latter, it's best to use it together with a GPL2 compatible license using "OR", as CC-BY-4.0 texts processed by the kernel's build system might combine it with content taken from more restrictive licenses. + To use the Creative Commons Attribution 4.0 International license put the following SPDX tag/value pair into a comment according to the placement guidelines in the licensing rules documentation: SPDX-License-Identifier: CC-BY-4.0 + License-Text: Creative Commons Attribution 4.0 International diff --git a/LICENSES/GPL-2.0 b/LICENSES/GPL-2.0 index 9f09528a8bce..fa5c66236fe9 100644 --- a/LICENSES/GPL-2.0 +++ b/LICENSES/GPL-2.0 @@ -2,19 +2,25 @@ Valid-License-Identifier: GPL-2.0 Valid-License-Identifier: GPL-2.0-only Valid-License-Identifier: GPL-2.0+ Valid-License-Identifier: GPL-2.0-or-later + SPDX-URL: https://spdx.org/licenses/GPL-2.0.html + Usage-Guide: + To use this license in source code, put one of the following SPDX tag/value pairs into a comment according to the placement guidelines in the licensing rules documentation. + For 'GNU General Public License (GPL) version 2 only' use: SPDX-License-Identifier: GPL-2.0-only or (now deprecated) SPDX-License-Identifier: GPL-2.0 + For 'GNU General Public License (GPL) version 2 or any later version' use: SPDX-License-Identifier: GPL-2.0+ or SPDX-License-Identifier: GPL-2.0-or-later + License-Text: GNU GENERAL PUBLIC LICENSE diff --git a/LICENSES/LGPL-2.0 b/LICENSES/LGPL-2.0 index 957d798fe037..2fa16d72eabf 100644 --- a/LICENSES/LGPL-2.0 +++ b/LICENSES/LGPL-2.0 @@ -1,15 +1,21 @@ Valid-License-Identifier: LGPL-2.0 Valid-License-Identifier: LGPL-2.0+ + SPDX-URL: https://spdx.org/licenses/LGPL-2.0.html + Usage-Guide: + To use this license in source code, put one of the following SPDX tag/value pairs into a comment according to the placement guidelines in the licensing rules documentation. + For 'GNU Library General Public License (LGPL) version 2.0 only' use: SPDX-License-Identifier: LGPL-2.0 + For 'GNU Library General Public License (LGPL) version 2.0 or any later version' use: SPDX-License-Identifier: LGPL-2.0+ + License-Text: GNU LIBRARY GENERAL PUBLIC LICENSE diff --git a/LICENSES/LGPL-2.1 b/LICENSES/LGPL-2.1 index 27bb4342a3e8..b366c7e49199 100644 --- a/LICENSES/LGPL-2.1 +++ b/LICENSES/LGPL-2.1 @@ -1,15 +1,21 @@ Valid-License-Identifier: LGPL-2.1 Valid-License-Identifier: LGPL-2.1+ + SPDX-URL: https://spdx.org/licenses/LGPL-2.1.html + Usage-Guide: + To use this license in source code, put one of the following SPDX tag/value pairs into a comment according to the placement guidelines in the licensing rules documentation. + For 'GNU Lesser General Public License (LGPL) version 2.1 only' use: SPDX-License-Identifier: LGPL-2.1 + For 'GNU Lesser General Public License (LGPL) version 2.1 or any later version' use: SPDX-License-Identifier: LGPL-2.1+ + License-Text: GNU LESSER GENERAL PUBLIC LICENSE diff --git a/LICENSES/MIT b/LICENSES/MIT index f33a68ceb3ea..eba1549f93e4 100644 --- a/LICENSES/MIT +++ b/LICENSES/MIT @@ -1,10 +1,14 @@ Valid-License-Identifier: MIT + SPDX-URL: https://spdx.org/licenses/MIT.html + Usage-Guide: + To use the MIT License put the following SPDX tag/value pair into a comment according to the placement guidelines in the licensing rules documentation: SPDX-License-Identifier: MIT + License-Text: MIT License -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Fri May 05 18:16:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 18:16:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530609.826356 (Exim 4.92) (envelope-from ) id 1puzyK-0002s8-Dj; Fri, 05 May 2023 18:16:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530609.826356; Fri, 05 May 2023 18:16:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puzyK-0002rv-AL; Fri, 05 May 2023 18:16:00 +0000 Received: by outflank-mailman (input) for mailman id 530609; Fri, 05 May 2023 18:15:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1puzyJ-0002Jh-No for xen-devel@lists.xenproject.org; Fri, 05 May 2023 18:15:59 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e1b163f8-eb70-11ed-8611-37d641c3527e; Fri, 05 May 2023 20:15:57 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e1b163f8-eb70-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1683310557; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1TQCZfeuZrxoYx6xAHLXfz0lWk/9oAGfIUvqEwt1EAY=; b=bck/AeeL2Q10dE+omKlXGA4dFSg3UvzWK2O5/jrvWh7nTWw7EjKCirch YP8GSNshhPRpSKQZh3hlEf74CyufL4zAYhvE72Dfu1PJj1srmdUjMLDw8 WpDQpLM2Jl+gDwDB414/ugXwLW6l7jyVSfqm/un9Gix2h/wiO/S7WwWAu 4=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 110484432 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:N56p7qlkX3X9MgmaceCoa6bo5gyYJkRdPkR7XQ2eYbSJt1+Wr1Gzt xIbX2DUOfuCZmP8f992aY3joRhU7MLVndU2TgJkrn1mQyMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aWaVA8w5ARkPqgW5AKGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 aUKGAwiS06mvOXsz6qaZcBOhppyLda+aevzulk4pd3YJfMvQJSFSKTW/95Imjw3g6iiH96HO ZBfM2A2Kk2dPVsWYAx/5JEWxY9EglHWdTFCpU3Tjq0w+2XJlyR60aT3McqTcduPLSlQth/B/ j6WoziiWHn2MvS7mB2GwjGL2NbTnCPFG6BOHaXmzvd11Qj7Kms7V0RNCArTTeOCol6zXZdTJ lIZ/gIqrLMu7wq7Q9/lRRq6rXWY+BkGVLJ4Eec39QWMwar8+BuCCy4PSTspQMc9qMY8SDgu1 1mIt9DkHzpitPuSU3313qiQhSO/P24SN2BqTS0ZSQoI5fHzrYd1iQjAJuuPC4bs0IezQ2uph WnX8m5n3e57YdM3O7uTpEL3vx2J+L3ySVQ6/iT4d0ClsFJ4e9vwD2C30mQ3/cqsPa7AEAna5 iVVwpHBhAwdJcrTzXLQGY3hCJnsvq/Ya2OE3DaDCrF7r1yQF2ifkZe8Cd2UDGNgKY46dDDge yc/UisBtcYIbBNGgUKaCr9d6vjGLoC6T7wJrtiOMrJzjmFZLWdrBh1Ga0+KxHzKm0Mxi6w5M przWZ/yXS1AU/o7lWvuHLh1PVoX+8zD7TmLGcCTI+qPiNJym0J5uZ9aaQDTP4jVHYuPoRnP8 sY3CvZmPy53CbWkCgGOqN57ELz/BSRjbXwAg5ANJ7Hrz8sPMD1JNsI9Npt7It0/w/oNyruZl px/M2cBoGfCabT8AV3iQhhehHnHBv6TcVpT0fQQAGuV IronPort-HdrOrdr: A9a23:mwvKjawAML+aSZ6e0BgRKrPw3L1zdoMgy1knxilNoHxuH/Bw9v re+MjzsCWftN9/Yh4dcLy7VpVoIkmskKKdg7NhXotKNTOO0AeVxedZjLcKqweKJ8SUzJ8+6U 4PSchD4abLfD9HZcaR2njFLz4jquP3j5xBU43lvglQpQIBUdAQ0+9gYDzrdHGf3GN9dOAE/J z33Ls/mxOQPU45Q+6cHXc/U+3Kt7Tw5e/biU5vPW9e1OGW5wnYk4LHLw== X-Talos-CUID: 9a23:Th/WcG7hWet5+YNtWtssrVwkJu8ALFjmyy3fO26XIERpFuyUVgrF X-Talos-MUID: 9a23:0KCkDwtfXb6SUV25zs2noGBFN/crxPqXFEENr9Yk58CcaxR5JGLI X-IronPort-AV: E=Sophos;i="5.99,252,1677560400"; d="scan'208";a="110484432" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Julien Grall Subject: [PATCH v2 2/2] LICENSES: Remove the use of deprecated SPDX tags Date: Fri, 5 May 2023 19:15:28 +0100 Message-ID: <20230505181528.3587485-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230505181528.3587485-1-andrew.cooper3@citrix.com> References: <20230505181528.3587485-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain The GPL and LGPL SPDX forms without an explicit -only or -or-later suffix are deprecated and should not be used. Update the documention. Somewhat unhelpfully at the time of writing, this only appears to be indicated by the separation of the two tables at https://spdx.org/licenses/ The recent changes to libacpi are the only examples of deprecated LGPL tags in tree, so fix them all up. For GPL, we have many examples using deprecated tags. For now, just identify them as such and recommend that no new instances get added. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich --- CC: George Dunlap CC: Jan Beulich CC: Stefano Stabellini CC: Wei Liu CC: Julien Grall Unsure whether this should get some Fixes: tags or not. Note also that Jenny's "[PATCH v4 2/2] acpi: Add TPM2 interface definition." wants its SPDX tag correcting as per this patch. v2: * Extend commit message to include https://spdx.org/licenses/ * Update the URLs too --- LICENSES/GPL-2.0 | 15 ++++++++------- LICENSES/LGPL-2.0 | 11 ++++++----- LICENSES/LGPL-2.1 | 11 ++++++----- tools/libacpi/Makefile | 2 +- tools/libacpi/acpi2_0.h | 2 +- tools/libacpi/build.c | 2 +- tools/libacpi/dsdt.asl | 2 +- tools/libacpi/dsdt_acpi_info.asl | 2 +- tools/libacpi/libacpi.h | 2 +- tools/libacpi/mk_dsdt.c | 2 +- tools/libacpi/ssdt_laptop_slate.asl | 2 +- tools/libacpi/ssdt_pm.asl | 2 +- tools/libacpi/ssdt_s3.asl | 2 +- tools/libacpi/ssdt_s4.asl | 2 +- tools/libacpi/ssdt_tpm.asl | 2 +- tools/libacpi/static_tables.c | 2 +- 16 files changed, 33 insertions(+), 30 deletions(-) diff --git a/LICENSES/GPL-2.0 b/LICENSES/GPL-2.0 index fa5c66236fe9..07f332641ccd 100644 --- a/LICENSES/GPL-2.0 +++ b/LICENSES/GPL-2.0 @@ -1,9 +1,11 @@ -Valid-License-Identifier: GPL-2.0 Valid-License-Identifier: GPL-2.0-only -Valid-License-Identifier: GPL-2.0+ Valid-License-Identifier: GPL-2.0-or-later -SPDX-URL: https://spdx.org/licenses/GPL-2.0.html +SPDX-URL: https://spdx.org/licenses/GPL-2.0-only.html +SPDX-URL: https://spdx.org/licenses/GPL-2.0-or-later.html + +Deprecated-Identifier: GPL-2.0 +Deprecated-Identifier: GPL-2.0+ Usage-Guide: @@ -13,14 +15,13 @@ Usage-Guide: For 'GNU General Public License (GPL) version 2 only' use: SPDX-License-Identifier: GPL-2.0-only - or (now deprecated) - SPDX-License-Identifier: GPL-2.0 For 'GNU General Public License (GPL) version 2 or any later version' use: - SPDX-License-Identifier: GPL-2.0+ - or SPDX-License-Identifier: GPL-2.0-or-later + The deprecated tags should not be used for any new additions. Where + possible, their existing uses should be phased out. + License-Text: GNU GENERAL PUBLIC LICENSE diff --git a/LICENSES/LGPL-2.0 b/LICENSES/LGPL-2.0 index 2fa16d72eabf..100c72c6db8c 100644 --- a/LICENSES/LGPL-2.0 +++ b/LICENSES/LGPL-2.0 @@ -1,7 +1,8 @@ -Valid-License-Identifier: LGPL-2.0 -Valid-License-Identifier: LGPL-2.0+ +Valid-License-Identifier: LGPL-2.0-only +Valid-License-Identifier: LGPL-2.0-or-later -SPDX-URL: https://spdx.org/licenses/LGPL-2.0.html +SPDX-URL: https://spdx.org/licenses/LGPL-2.0-only.html +SPDX-URL: https://spdx.org/licenses/LGPL-2.0-or-later.html Usage-Guide: @@ -10,11 +11,11 @@ Usage-Guide: guidelines in the licensing rules documentation. For 'GNU Library General Public License (LGPL) version 2.0 only' use: - SPDX-License-Identifier: LGPL-2.0 + SPDX-License-Identifier: LGPL-2.0-only For 'GNU Library General Public License (LGPL) version 2.0 or any later version' use: - SPDX-License-Identifier: LGPL-2.0+ + SPDX-License-Identifier: LGPL-2.0-or-later License-Text: diff --git a/LICENSES/LGPL-2.1 b/LICENSES/LGPL-2.1 index b366c7e49199..d3e213c39c26 100644 --- a/LICENSES/LGPL-2.1 +++ b/LICENSES/LGPL-2.1 @@ -1,7 +1,8 @@ -Valid-License-Identifier: LGPL-2.1 -Valid-License-Identifier: LGPL-2.1+ +Valid-License-Identifier: LGPL-2.1-only +Valid-License-Identifier: LGPL-2.1-or-later -SPDX-URL: https://spdx.org/licenses/LGPL-2.1.html +SPDX-URL: https://spdx.org/licenses/LGPL-2.1-only.html +SPDX-URL: https://spdx.org/licenses/LGPL-2.1-or-later.html Usage-Guide: @@ -10,11 +11,11 @@ Usage-Guide: guidelines in the licensing rules documentation. For 'GNU Lesser General Public License (LGPL) version 2.1 only' use: - SPDX-License-Identifier: LGPL-2.1 + SPDX-License-Identifier: LGPL-2.1-only For 'GNU Lesser General Public License (LGPL) version 2.1 or any later version' use: - SPDX-License-Identifier: LGPL-2.1+ + SPDX-License-Identifier: LGPL-2.1-or-later License-Text: diff --git a/tools/libacpi/Makefile b/tools/libacpi/Makefile index aa9c520cbe85..bcfcd852f92f 100644 --- a/tools/libacpi/Makefile +++ b/tools/libacpi/Makefile @@ -1,4 +1,4 @@ -# SPDX-License-Identifier: LGPL-2.1 +# SPDX-License-Identifier: LGPL-2.1-only # # Copyright (c) 2004, Intel Corporation. diff --git a/tools/libacpi/acpi2_0.h b/tools/libacpi/acpi2_0.h index 212f5ab64182..e00b29854be0 100644 --- a/tools/libacpi/acpi2_0.h +++ b/tools/libacpi/acpi2_0.h @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: LGPL-2.1 */ +/* SPDX-License-Identifier: LGPL-2.1-only */ /* * Copyright (c) 2004, Intel Corporation. */ diff --git a/tools/libacpi/build.c b/tools/libacpi/build.c index 830d37c61f03..3142e0ac84c0 100644 --- a/tools/libacpi/build.c +++ b/tools/libacpi/build.c @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: LGPL-2.1 */ +/* SPDX-License-Identifier: LGPL-2.1-only */ /* * Copyright (c) 2004, Intel Corporation. * Copyright (c) 2006, Keir Fraser, XenSource Inc. diff --git a/tools/libacpi/dsdt.asl b/tools/libacpi/dsdt.asl index c6691b56a986..32b42f85ae9f 100644 --- a/tools/libacpi/dsdt.asl +++ b/tools/libacpi/dsdt.asl @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: LGPL-2.1 */ +/* SPDX-License-Identifier: LGPL-2.1-only */ /****************************************************************************** * DSDT for Xen with Qemu device model * diff --git a/tools/libacpi/dsdt_acpi_info.asl b/tools/libacpi/dsdt_acpi_info.asl index c6e82f1fe6a7..6e114fa23404 100644 --- a/tools/libacpi/dsdt_acpi_info.asl +++ b/tools/libacpi/dsdt_acpi_info.asl @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: LGPL-2.1 */ +/* SPDX-License-Identifier: LGPL-2.1-only */ Scope (\_SB) { diff --git a/tools/libacpi/libacpi.h b/tools/libacpi/libacpi.h index acf012e35578..7ae28525f604 100644 --- a/tools/libacpi/libacpi.h +++ b/tools/libacpi/libacpi.h @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: LGPL-2.1 */ +/* SPDX-License-Identifier: LGPL-2.1-only */ /****************************************************************************** * libacpi.h * diff --git a/tools/libacpi/mk_dsdt.c b/tools/libacpi/mk_dsdt.c index c74b270c0c5d..34f6753f6193 100644 --- a/tools/libacpi/mk_dsdt.c +++ b/tools/libacpi/mk_dsdt.c @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: LGPL-2.1 */ +/* SPDX-License-Identifier: LGPL-2.1-only */ #include #include diff --git a/tools/libacpi/ssdt_laptop_slate.asl b/tools/libacpi/ssdt_laptop_slate.asl index 494f2d048d0a..69fd504c19fc 100644 --- a/tools/libacpi/ssdt_laptop_slate.asl +++ b/tools/libacpi/ssdt_laptop_slate.asl @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: LGPL-2.1 */ +/* SPDX-License-Identifier: LGPL-2.1-only */ /* * ssdt_conv.asl * diff --git a/tools/libacpi/ssdt_pm.asl b/tools/libacpi/ssdt_pm.asl index e577e85c072b..db578d10ac3e 100644 --- a/tools/libacpi/ssdt_pm.asl +++ b/tools/libacpi/ssdt_pm.asl @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: LGPL-2.1 */ +/* SPDX-License-Identifier: LGPL-2.1-only */ /* * ssdt_pm.asl * diff --git a/tools/libacpi/ssdt_s3.asl b/tools/libacpi/ssdt_s3.asl index 8f3177ec5adc..f6e9636f4759 100644 --- a/tools/libacpi/ssdt_s3.asl +++ b/tools/libacpi/ssdt_s3.asl @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: LGPL-2.1 */ +/* SPDX-License-Identifier: LGPL-2.1-only */ /* * ssdt_s3.asl * diff --git a/tools/libacpi/ssdt_s4.asl b/tools/libacpi/ssdt_s4.asl index 979318eca1f5..8014f5fc9014 100644 --- a/tools/libacpi/ssdt_s4.asl +++ b/tools/libacpi/ssdt_s4.asl @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: LGPL-2.1 */ +/* SPDX-License-Identifier: LGPL-2.1-only */ /* * ssdt_s4.asl * diff --git a/tools/libacpi/ssdt_tpm.asl b/tools/libacpi/ssdt_tpm.asl index 6c3267218f3b..944658d25177 100644 --- a/tools/libacpi/ssdt_tpm.asl +++ b/tools/libacpi/ssdt_tpm.asl @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: LGPL-2.1 */ +/* SPDX-License-Identifier: LGPL-2.1-only */ /* * ssdt_tpm.asl * diff --git a/tools/libacpi/static_tables.c b/tools/libacpi/static_tables.c index 631fb911413b..715f46fee05c 100644 --- a/tools/libacpi/static_tables.c +++ b/tools/libacpi/static_tables.c @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: LGPL-2.1 */ +/* SPDX-License-Identifier: LGPL-2.1-only */ /* * Copyright (c) 2004, Intel Corporation. * Copyright (c) 2006, Keir Fraser, XenSource Inc. -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Fri May 05 21:26:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 21:26:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530652.826400 (Exim 4.92) (envelope-from ) id 1pv2wP-0007Sk-C0; Fri, 05 May 2023 21:26:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530652.826400; Fri, 05 May 2023 21:26:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pv2wP-0007Rv-6l; Fri, 05 May 2023 21:26:13 +0000 Received: by outflank-mailman (input) for mailman id 530652; Fri, 05 May 2023 21:26:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pv2wN-0007NI-P1 for xen-devel@lists.xenproject.org; Fri, 05 May 2023 21:26:11 +0000 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6caaa018-eb8b-11ed-8611-37d641c3527e; Fri, 05 May 2023 23:26:01 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 2E3833200925; Fri, 5 May 2023 17:25:57 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 05 May 2023 17:25:57 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 5 May 2023 17:25:55 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6caaa018-eb8b-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1683321956; x=1683408356; bh=o3 13F4hQU5uB9lSLjfIs/1QY2b4KHS2capUoYZqcCPE=; b=YbtXIMljxxLWmuYvxf y1JLmQC7zAOrNuWB4kWv9vRaC5WRRAjHJcAZXfo2InEXMZNa8HnDkXWfF6mh5VIK EX9J8INupy/u1s7+1JiVPIXsTJqRRMPATUV07MMXlWLsFT0xV/L44PNOcxvOB4rn +fIhVUWLMq8JdlCyzxX84w/rQbSRgE//T2M8kIDEK0rB0LioBF3EzawWbjBy8NO7 L7vjcvY8hkT8JoDsQF3Vic3vTmJZfcoeUkZU6orpMY1jRT1EIMly0ZHAPOnbMhjL Qkbd7GzDZX8Vc2CpzAFhBw20RJzzdohKmJo40ZsHes43EOjhpcGzVWlLaHPor4QG MA5Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1683321956; x=1683408356; bh=o313F4hQU5uB9lSLjfIs/1QY2b4KHS2capU oYZqcCPE=; b=iIVEDxKz2wS0FPUx5c/Huwdjf/aMYHODZN3qBIYt6neXuDVowjq qJOrajoHVZws9Ep9klcHQPhZr/lex1RH5kbw5sVei8dcsI2wTwTeU3A6xvOMQaQ7 6SRBQcceM14/GMe9iY+qAW3h2afXezUp5xHi511DC1KLCP+IbZ0qBVUfXItBwLPj sGZlFQcDG1YcRsXyVj4O7aLUVPeeomEJLsgmDzb/2Rn0Cy6GL4StXdqs5RHgtMCY +wctBroiIQViiIOZDN+xNW6ExmlQ23LGG82KnBdgJCWuFEWzhrY4TCF+vvG7m9h+ 9NudkzDHpj7otKZDNmoN2E50GZcHZT9b+YA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeefvddgudeifecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfgggtgfesthekredtredtjeenucfhrhhomhepofgr rhgvkhcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghkse hinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhep gfeuudehgfdvfeehhedujeehfeduveeugefhkefhheelgeevudetueeiudfggfffnecuve hluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghr vghksehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Paul Durrant , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 1/2] x86/mm: add API for marking only part of a MMIO page read only Date: Fri, 5 May 2023 23:25:35 +0200 Message-Id: X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In some cases, only few registers on a page needs to be write-protected. Examples include USB3 console (64 bytes worth of registers) or MSI-X's PBA table (which doesn't need to span the whole table either), although in the latter case the spec forbids placing other registers on the same page. Current API allows only marking whole pages pages read-only, which sometimes may cover other registers that guest may need to write into. Currently, when a guest tries to write to an MMIO page on the mmio_ro_ranges, it's either immediately crashed on EPT violation - if that's HVM, or if PV, it gets #PF. In case of Linux PV, if access was from userspace (like, /dev/mem), it will try to fixup by updating page tables (that Xen again will force to read-only) and will hit that #PF again (looping endlessly). Both behaviors are undesirable if guest could actually be allowed the write. Introduce an API that allows marking part of a page read-only. Since sub-page permissions are not a thing in page tables (they are in EPT, but not granular enough), do this via emulation (or simply page fault handler for PV) that handles writes that are supposed to be allowed. The new subpage_mmio_ro_add() takes a start physical address and the region size in bytes. Both start address and the size need to be 8-byte aligned, as a practical simplification (allows using smaller bitmask, and a smaller granularity isn't really necessary right now). It will internally add relevant pages to mmio_ro_ranges, but if either start or end address is not page-aligned, it additionally adds that page to a list for sub-page R/O handling. The list holds a bitmask which dwords are supposed to be read-only and an address where page is mapped for write emulation - this mapping is done only on the first access. A plain list is used instead of more efficient structure, because there isn't supposed to be many pages needing this precise r/o control. The mechanism this API is plugged in is slightly different for PV and HVM. For both paths, it's plugged into mmio_ro_emulated_write(). For PV, it's already called for #PF on read-only MMIO page. For HVM however, EPT violation on p2m_mmio_direct page results in a direct domain_crash(). To reach mmio_ro_emulated_write(), change how write violations for p2m_mmio_direct are handled - specifically, check if they relate to such partially protected page via subpage_mmio_write_accept() and if so, call hvm_emulate_one_mmio() for them too. This decodes what guest is trying write and finally calls mmio_ro_emulated_write(). Note that hitting EPT write violation for p2m_mmio_direct page can only happen if the page was on mmio_ro_ranges (see ept_p2m_type_to_flags()), so there is no need for checking that again. Both of those paths need an MFN to which guest tried to write (to check which part of the page is supposed to be read-only, and where the page is mapped for writes). This information currently isn't available directly in mmio_ro_emulated_write(), but in both cases it is already resolved somewhere higher in the call tree. Pass it down to mmio_ro_emulated_write() via new mmio_ro_emulate_ctxt.mfn field. Signed-off-by: Marek Marczykowski-Górecki --- Shadow mode is not tested, but I don't expect it to work differently than HAP in areas related to this patch. Changes in v2: - Simplify subpage_mmio_ro_add() parameters - add to mmio_ro_ranges from within subpage_mmio_ro_add() - use ioremap() instead of caller-provided fixmap - use 8-bytes granularity (largest supported single write) and a bitmap instead of a rangeset - clarify commit message - change how it's plugged in for HVM domain, to not change the behavior for read-only parts (keep it hitting domain_crash(), instead of ignoring write) - remove unused subpage_mmio_ro_remove() --- xen/arch/x86/hvm/emulate.c | 2 +- xen/arch/x86/hvm/hvm.c | 8 +- xen/arch/x86/include/asm/mm.h | 15 ++- xen/arch/x86/mm.c | 253 +++++++++++++++++++++++++++++++++- xen/arch/x86/pv/ro-page-fault.c | 1 +- 5 files changed, 278 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/hvm/emulate.c b/xen/arch/x86/hvm/emulate.c index 75ee98a73be8..0a64636fd9da 100644 --- a/xen/arch/x86/hvm/emulate.c +++ b/xen/arch/x86/hvm/emulate.c @@ -2732,7 +2732,7 @@ int hvm_emulate_one_mmio(unsigned long mfn, unsigned long gla) .write = mmio_ro_emulated_write, .validate = hvmemul_validate, }; - struct mmio_ro_emulate_ctxt mmio_ro_ctxt = { .cr2 = gla }; + struct mmio_ro_emulate_ctxt mmio_ro_ctxt = { .cr2 = gla, .mfn = _mfn(mfn) }; struct hvm_emulate_ctxt ctxt; const struct x86_emulate_ops *ops; unsigned int seg, bdf; diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index d7d31b53937a..0ed7ce31d5cf 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -1990,6 +1990,14 @@ int hvm_hap_nested_page_fault(paddr_t gpa, unsigned long gla, goto out_put_gfn; } + if ( (p2mt == p2m_mmio_direct) && npfec.write_access && npfec.present && + subpage_mmio_write_accept(mfn, gla) && + (hvm_emulate_one_mmio(mfn_x(mfn), gla) == X86EMUL_OKAY) ) + { + rc = 1; + goto out_put_gfn; + } + /* If we fell through, the vcpu will retry now that access restrictions have * been removed. It may fault again if the p2m entry type still requires so. * Otherwise, this is an error condition. */ diff --git a/xen/arch/x86/include/asm/mm.h b/xen/arch/x86/include/asm/mm.h index db29e3e2059f..3867a92d2dfa 100644 --- a/xen/arch/x86/include/asm/mm.h +++ b/xen/arch/x86/include/asm/mm.h @@ -522,9 +522,24 @@ extern struct rangeset *mmio_ro_ranges; void memguard_guard_stack(void *p); void memguard_unguard_stack(void *p); +/* + * Add more precise r/o marking for a MMIO page. Bytes range specified here + * will still be R/O, but the rest of the page (nor marked as R/O via another + * call) will have writes passed through. + * The start address and the size must be aligned to SUBPAGE_MMIO_RO_ALIGN. + * + * Return values: + * - negative: error + * - 0: success + */ +#define SUBPAGE_MMIO_RO_ALIGN 8 +int subpage_mmio_ro_add(paddr_t start, size_t size); +bool subpage_mmio_write_accept(mfn_t mfn, unsigned long gla); + struct mmio_ro_emulate_ctxt { unsigned long cr2; unsigned int seg, bdf; + mfn_t mfn; }; int cf_check mmio_ro_emulated_write( diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 9741d28cbc96..59941a56c821 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -154,6 +154,19 @@ bool __read_mostly machine_to_phys_mapping_valid; struct rangeset *__read_mostly mmio_ro_ranges; +/* Handling sub-page read-only MMIO regions */ +struct subpage_ro_range { + struct list_head list; + mfn_t mfn; + void __iomem *mapped; + DECLARE_BITMAP(ro_qwords, PAGE_SIZE / SUBPAGE_MMIO_RO_ALIGN); + struct rcu_head rcu; +}; + +static LIST_HEAD(subpage_ro_ranges); +static DEFINE_RCU_READ_LOCK(subpage_ro_rcu); +static DEFINE_SPINLOCK(subpage_ro_lock); + static uint32_t base_disallow_mask; /* Global bit is allowed to be set on L1 PTEs. Intended for user mappings. */ #define L1_DISALLOW_MASK ((base_disallow_mask | _PAGE_GNTTAB) & ~_PAGE_GLOBAL) @@ -4882,6 +4895,243 @@ long arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg) return 0; } +/* This needs subpage_ro_lock already taken */ +static int __init subpage_mmio_ro_add_page( + mfn_t mfn, unsigned int offset_s, unsigned int offset_e) +{ + struct subpage_ro_range *entry = NULL, *iter; + int i; + + list_for_each_entry(iter, &subpage_ro_ranges, list) + { + if ( mfn_eq(iter->mfn, mfn) ) + { + entry = iter; + break; + } + } + if ( !entry ) + { + /* iter==NULL marks it was a newly allocated entry */ + iter = NULL; + entry = xzalloc(struct subpage_ro_range); + if ( !entry ) + return -ENOMEM; + entry->mfn = mfn; + } + + for ( i = offset_s; i <= offset_e; i += SUBPAGE_MMIO_RO_ALIGN ) + set_bit(i / SUBPAGE_MMIO_RO_ALIGN, entry->ro_qwords); + + if ( !iter ) + list_add_rcu(&entry->list, &subpage_ro_ranges); + + return 0; +} + +static void __init subpage_mmio_ro_free(struct rcu_head *rcu) +{ + struct subpage_ro_range *entry = container_of( + rcu, struct subpage_ro_range, rcu); + + ASSERT(bitmap_empty(entry->ro_qwords, PAGE_SIZE / SUBPAGE_MMIO_RO_ALIGN)); + + if ( entry->mapped ) + iounmap(entry->mapped); + xfree(entry); +} + +/* This needs subpage_ro_lock already taken */ +static int __init subpage_mmio_ro_remove_page( + mfn_t mfn, + int offset_s, + int offset_e) +{ + struct subpage_ro_range *entry = NULL, *iter; + int rc, i; + + list_for_each_entry_rcu(iter, &subpage_ro_ranges, list) + { + if ( mfn_eq(iter->mfn, mfn) ) + { + entry = iter; + break; + } + } + if ( !entry ) + return -ENOENT; + + for ( i = offset_s; i <= offset_e; i += SUBPAGE_MMIO_RO_ALIGN ) + clear_bit(i / SUBPAGE_MMIO_RO_ALIGN, entry->ro_qwords); + + if ( !bitmap_empty(entry->ro_qwords, PAGE_SIZE / SUBPAGE_MMIO_RO_ALIGN) ) + return 0; + + list_del_rcu(&entry->list); + call_rcu(&entry->rcu, subpage_mmio_ro_free); + return rc; +} + + +int __init subpage_mmio_ro_add( + paddr_t start, + size_t size) +{ + mfn_t mfn_start = maddr_to_mfn(start); + paddr_t end = start + size - 1; + mfn_t mfn_end = maddr_to_mfn(end); + int offset_end = 0; + int rc; + + ASSERT(IS_ALIGNED(start, SUBPAGE_MMIO_RO_ALIGN)); + ASSERT(IS_ALIGNED(size, SUBPAGE_MMIO_RO_ALIGN)); + + if ( !size ) + return 0; + + rc = rangeset_add_range(mmio_ro_ranges, mfn_x(mfn_start), mfn_x(mfn_end)); + if ( rc ) + return rc; + + spin_lock(&subpage_ro_lock); + + if ( PAGE_OFFSET(start) || + (mfn_eq(mfn_start, mfn_end) && PAGE_OFFSET(end) != PAGE_SIZE - 1) ) + { + offset_end = mfn_eq(mfn_start, mfn_end) ? + PAGE_OFFSET(end) : + (PAGE_SIZE - 1); + rc = subpage_mmio_ro_add_page(mfn_start, + PAGE_OFFSET(start), + offset_end); + if ( rc ) + goto err_unlock; + } + + if ( !mfn_eq(mfn_start, mfn_end) && PAGE_OFFSET(end) != PAGE_SIZE - 1 ) + { + rc = subpage_mmio_ro_add_page(mfn_end, 0, PAGE_OFFSET(end)); + if ( rc ) + goto err_unlock_remove; + } + + spin_unlock(&subpage_ro_lock); + + return 0; + + err_unlock_remove: + if ( offset_end ) + subpage_mmio_ro_remove_page(mfn_start, PAGE_OFFSET(start), offset_end); + + err_unlock: + spin_unlock(&subpage_ro_lock); + if ( rangeset_remove_range(mmio_ro_ranges, mfn_x(mfn_start), mfn_x(mfn_end)) ) + printk(XENLOG_ERR "Failed to cleanup on failed subpage_mmio_ro_add()\n"); + return rc; +} + +static void __iomem *subpage_mmio_get_page(struct subpage_ro_range *entry) +{ + if ( entry->mapped ) + return entry->mapped; + + spin_lock(&subpage_ro_lock); + /* Re-check under the lock */ + if ( entry->mapped ) + goto out_unlock; + + entry->mapped = ioremap(mfn_x(entry->mfn) << PAGE_SHIFT, PAGE_SIZE); + + out_unlock: + spin_unlock(&subpage_ro_lock); + return entry->mapped; +} + +static void subpage_mmio_write_emulate( + mfn_t mfn, + unsigned int offset, + const void *data, + unsigned int len) +{ + struct subpage_ro_range *entry; + void __iomem *addr; + + rcu_read_lock(&subpage_ro_rcu); + + list_for_each_entry_rcu(entry, &subpage_ro_ranges, list) + { + if ( mfn_eq(entry->mfn, mfn) ) + { + if ( test_bit(offset / SUBPAGE_MMIO_RO_ALIGN, entry->ro_qwords) ) + goto write_ignored; + + addr = subpage_mmio_get_page(entry); + if ( !addr ) + { + gprintk(XENLOG_ERR, + "Failed to map page for MMIO write at 0x%"PRI_mfn"%03x\n", + mfn_x(mfn), offset); + goto out_unlock; + } + + switch ( len ) + { + case 1: + writeb(*(uint8_t*)data, addr); + break; + case 2: + writew(*(uint16_t*)data, addr); + break; + case 4: + writel(*(uint32_t*)data, addr); + break; + case 8: + writeq(*(uint64_t*)data, addr); + break; + default: + /* mmio_ro_emulated_write() already validated the size */ + ASSERT_UNREACHABLE(); + goto write_ignored; + } + goto out_unlock; + } + } + /* Do not print message for pages without any writable parts. */ + goto out_unlock; + + write_ignored: + gprintk(XENLOG_WARNING, + "ignoring write to R/O MMIO 0x%"PRI_mfn"%03x len %u\n", + mfn_x(mfn), offset, len); + + out_unlock: + rcu_read_unlock(&subpage_ro_rcu); +} + +bool subpage_mmio_write_accept(mfn_t mfn, unsigned long gla) +{ + unsigned int offset = PAGE_OFFSET(gla); + const struct subpage_ro_range *entry; + + rcu_read_lock(&subpage_ro_rcu); + + list_for_each_entry_rcu(entry, &subpage_ro_ranges, list) + if ( mfn_eq(entry->mfn, mfn) && + !test_bit(offset / SUBPAGE_MMIO_RO_ALIGN, entry->ro_qwords) ) + { + /* + * We don't know the write seize at this point yet, so it could be + * an unalligned write, but accept it here anyway and deal with it + * later. + */ + rcu_read_unlock(&subpage_ro_rcu); + return true; + } + + rcu_read_unlock(&subpage_ro_rcu); + return false; +} + int cf_check mmio_ro_emulated_write( enum x86_segment seg, unsigned long offset, @@ -4900,6 +5150,9 @@ int cf_check mmio_ro_emulated_write( return X86EMUL_UNHANDLEABLE; } + subpage_mmio_write_emulate(mmio_ro_ctxt->mfn, PAGE_OFFSET(offset), + p_data, bytes); + return X86EMUL_OKAY; } diff --git a/xen/arch/x86/pv/ro-page-fault.c b/xen/arch/x86/pv/ro-page-fault.c index cad28ef928ad..578bb4caaf0b 100644 --- a/xen/arch/x86/pv/ro-page-fault.c +++ b/xen/arch/x86/pv/ro-page-fault.c @@ -330,6 +330,7 @@ static int mmio_ro_do_page_fault(struct x86_emulate_ctxt *ctxt, return X86EMUL_UNHANDLEABLE; } + mmio_ro_ctxt.mfn = mfn; ctxt->data = &mmio_ro_ctxt; if ( pci_ro_mmcfg_decode(mfn_x(mfn), &mmio_ro_ctxt.seg, &mmio_ro_ctxt.bdf) ) return x86_emulate(ctxt, &mmcfg_intercept_ops); -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Fri May 05 21:26:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 21:26:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530650.826384 (Exim 4.92) (envelope-from ) id 1pv2wF-00077W-Mg; Fri, 05 May 2023 21:26:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530650.826384; Fri, 05 May 2023 21:26:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pv2wF-00077P-Jo; Fri, 05 May 2023 21:26:03 +0000 Received: by outflank-mailman (input) for mailman id 530650; Fri, 05 May 2023 21:26:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pv2wD-00077H-Vw for xen-devel@lists.xenproject.org; Fri, 05 May 2023 21:26:02 +0000 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6bd93315-eb8b-11ed-b226-6b7b168915f2; Fri, 05 May 2023 23:25:58 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 881393200A89; Fri, 5 May 2023 17:25:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 05 May 2023 17:25:54 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 5 May 2023 17:25:53 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6bd93315-eb8b-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to; s=fm3; t=1683321954; x=1683408354; bh=PDyU9NZ51sl5yKnOCnEilGWUm ShNFHrjw6ME6jDLwyk=; b=F3ywGpqE1Gk1X+Ee/uUhu90/cf6R3KNn8afKN0HBa Vh/JJObuRQqWhFRRvA2CWIN2vjjhBN3QRVo14OoD/8I3wzuWgDltg3G4CtzJFplY np+utE9vbQjoCNcjP9ekGQTx2suVusPWVo6PsJsDuDipymkukJBO0/S2dOCFoo5y zSVBL5udoao/1TXCOAqZh9pzvB3ic5ThSA39wUfS2pDBtP/cUn2zzlJ2P4ftzv1U FCDosrLmJnc6zoDK/x+REa6fu1lAHuQO1ZWbgq3GYC82GbxIAFTtUYhmApc98NsY +bmhpEtaiLb1c65nZOiP8MBb2LxJRnES98x1FtkJbRRLw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1683321954; x=1683408354; bh=P DyU9NZ51sl5yKnOCnEilGWUmShNFHrjw6ME6jDLwyk=; b=b42mZxKjd/kl2DIbQ EGglrWR82TZxRBPi7XubYm/Tn+g7zv+9NO4HzFmg591yDXE1nb+J+mf7TJDeSmtz OVIAnhynPSmnt0mM8NFmftIsNAEq4W2UT51B7X6VA+NTuIvh++ZAGhDmj3VoLKMj Qnc1PkcMaM4m1fBt8gxUsNVPffFXZ1cABtALf+t2EvMGjkMnncer0/a2PmYsC3Eq 4f4S8Lzsvj1ly1/AQHU1B9OD3KWDGagnxuP0I29DF0vPa9FEoMNnqGsKvSKZWoFK xlF5mc4fW2tT6xz5iQSoq1f9JSt3fAhqCGbe9kPtTxK6A6gAiOkVo6De0GUnJIv6 arKqQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeefvddgudeifecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofggtgfgsehtke ertdertdejnecuhfhrohhmpeforghrvghkucforghrtgiihihkohifshhkihdqifpkrhgv tghkihcuoehmrghrmhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtoh hmqeenucggtffrrghtthgvrhhnpeelkefhudelteelleelteetveeffeetffekteetjeeh lefggeekleeghefhtdehvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpehmrghrmhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgshhlrggs rdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= Subject: [PATCH v2 0/2] Add API for making parts of a MMIO page R/O and use it in XHCI console Date: Fri, 5 May 2023 23:25:34 +0200 Message-Id: X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On older systems, XHCI xcap had a layout that no other (interesting) registers were placed on the same page as the debug capability, so Linux was fine with making the whole page R/O. But at least on Tiger Lake and Alder Lake, Linux needs to write to some other registers on the same page too. Add a generic API for making just parts of an MMIO page R/O and use it to fix USB3 console with share=yes or share=hwdom options. More details in commit messages. Marek Marczykowski-Górecki (2): x86/mm: add API for marking only part of a MMIO page read only drivers/char: Use sub-page ro API to make just xhci dbc cap RO xen/arch/x86/hvm/emulate.c | 2 +- xen/arch/x86/hvm/hvm.c | 8 +- xen/arch/x86/include/asm/mm.h | 15 ++- xen/arch/x86/mm.c | 253 +++++++++++++++++++++++++++++++++- xen/arch/x86/pv/ro-page-fault.c | 1 +- xen/drivers/char/xhci-dbc.c | 14 +-- 6 files changed, 284 insertions(+), 9 deletions(-) base-commit: 99a9c3d7141063ae3f357892c6181cfa3be8a280 -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Fri May 05 21:26:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 21:26:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530651.826393 (Exim 4.92) (envelope-from ) id 1pv2wP-0007PD-14; Fri, 05 May 2023 21:26:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530651.826393; Fri, 05 May 2023 21:26:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pv2wO-0007P6-UX; Fri, 05 May 2023 21:26:12 +0000 Received: by outflank-mailman (input) for mailman id 530651; Fri, 05 May 2023 21:26:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pv2wN-0007NI-IB for xen-devel@lists.xenproject.org; Fri, 05 May 2023 21:26:11 +0000 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6e6fb91b-eb8b-11ed-8611-37d641c3527e; Fri, 05 May 2023 23:26:01 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 154E53200985; Fri, 5 May 2023 17:26:00 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 05 May 2023 17:26:00 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 5 May 2023 17:25:58 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e6fb91b-eb8b-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1683321959; x=1683408359; bh=uL hx0P6xBZxBZBxNEJgIiazgGFs2Lty/Wyht3mdpQIM=; b=pm2zuDECQQrRQaXpcm Qfpec60lFWjgj74E/Dk/vlOfOUOWJ7YpPwlW4XkPgXrtt0gnEnl1kaAATL+238PL vJeA/9EQhRFwMcVY62bETZYUyRQmM5wrwczCVfMCEMf2PGDfOOu12zQCE2SSMtaQ wM2FbDLdawwyZt8PR6NmHsXCF4RK88TtwSUJyQs/L+gqAqDvpKZQBjkLRn+Rwjqn dOwdLOuUHxw9zehmfXUZ4CMc+iIbe8mXfKoObHw+OkuRDTLhmNOjIs0+P7UfmAji 2Lvr3DFR6uty99E1cvQ13UK56ekgtjcAOZEo2dxOd/KhwYO/kNU2cbY4UPEq3mGF K13A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1683321959; x=1683408359; bh=uLhx0P6xBZxBZBxNEJgIiazgGFs2Lty/Wyh t3mdpQIM=; b=OFSdM02IPRy0XvJlK7BqPWyE8gxN6e21UPb0aN1FSK2ttWVRRX+ ruVtBzaAiUo/NjMzb4Cd64clIHFomEoUVehziMx6YmSSATZxlGoldVlsLQCcl6Sn Z5zzWrQJpZeyjujCY7pjQG/x1abC0zHzxgqV80bgl2SW5gwli+Reasa1ShQ6Yvgh 4aexAZVcbJ9X0ZzL9TNtO4uIKjFK5oe+UceLuJX6VAldvT1M34Jhv8KZZyg6mqbK qg+xjKjSfHKb4Jw/8oQ7WbPYTZG8zUTY36xp1WamEzhpfOGTwxgpFlCALRX/INW3 L5WFFBjsKCQVgVf7eu+l9AereZGi2CtI5fA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeefvddgudeifecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfgggtgfesthekredtredtjeenucfhrhhomhepofgr rhgvkhcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghkse hinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhep gfeuudehgfdvfeehhedujeehfeduveeugefhkefhheelgeevudetueeiudfggfffnecuve hluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghr vghksehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v2 2/2] drivers/char: Use sub-page ro API to make just xhci dbc cap RO Date: Fri, 5 May 2023 23:25:36 +0200 Message-Id: <1f9909dacfd7822a1c7d30ba03bbec93fa2ff6fd.1683321183.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Not the whole page, which may contain other registers too. In fact on Tiger Lake and newer (at least), this page do contain other registers that Linux tries to use. And with share=yes, a domU would use them too. Without this patch, PV dom0 would fail to initialize the controller, while HVM would be killed on EPT violation. Signed-off-by: Marek Marczykowski-Górecki --- Changes in v2: - adjust for simplified subpage_mmio_ro_add() API --- xen/drivers/char/xhci-dbc.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c index 60b781f87202..8e368364c933 100644 --- a/xen/drivers/char/xhci-dbc.c +++ b/xen/drivers/char/xhci-dbc.c @@ -1221,14 +1221,12 @@ static void __init cf_check dbc_uart_init_postirq(struct serial_port *port) * Linux's XHCI driver (as of 5.18) works without writting to the whole * page, so keep it simple. */ - if ( rangeset_add_range(mmio_ro_ranges, - PFN_DOWN((uart->dbc.bar_val & PCI_BASE_ADDRESS_MEM_MASK) + - uart->dbc.xhc_dbc_offset), - PFN_UP((uart->dbc.bar_val & PCI_BASE_ADDRESS_MEM_MASK) + - uart->dbc.xhc_dbc_offset + - sizeof(*uart->dbc.dbc_reg)) - 1) ) - printk(XENLOG_INFO - "Error while adding MMIO range of device to mmio_ro_ranges\n"); + if ( subpage_mmio_ro_add( + (uart->dbc.bar_val & PCI_BASE_ADDRESS_MEM_MASK) + + uart->dbc.xhc_dbc_offset, + sizeof(*uart->dbc.dbc_reg)) ) + printk(XENLOG_WARNING + "Error while marking MMIO range of XHCI console as R/O\n"); #endif } -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Fri May 05 21:48:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 21:48:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530668.826413 (Exim 4.92) (envelope-from ) id 1pv3I0-0002Nv-2k; Fri, 05 May 2023 21:48:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530668.826413; Fri, 05 May 2023 21:48:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pv3Hz-0002No-W6; Fri, 05 May 2023 21:48:31 +0000 Received: by outflank-mailman (input) for mailman id 530668; Fri, 05 May 2023 21:48:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pv3Hy-0002Ng-F8 for xen-devel@lists.xenproject.org; Fri, 05 May 2023 21:48:30 +0000 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 90e2af1c-eb8e-11ed-8611-37d641c3527e; Fri, 05 May 2023 23:48:27 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 0462C32002FB; Fri, 5 May 2023 17:48:24 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 05 May 2023 17:48:25 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 5 May 2023 17:48:22 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 90e2af1c-eb8e-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to; s=fm3; t=1683323304; x=1683409704; bh=63RaELZf0bZZdNao1GuFs3vFD Am34PcStRchPykUHYs=; b=g4cW2l8rkHmfM8cL4Kfrd3fptPg848oUPhuCXcs6J U3FDMOY1eqDrQ6xQSbodW3pDeq1j0CUnCuaXvb4Tgp+RrNjj4VggdeJg/kKR3WGr Ud2gQCni7nLWTVvSUn4KAdRZaio48MySCH0YJAHEYT5efF9+G26re1ZkoC+VRzky SyT6WRosYuHNkSbqeAonschZ0v6NAFyYcwwME5AGRJUlWUQ2I/i/VcL8tOf4G190 Qpy6LBwx2LDz068e6cpr7u4JjQiyczEtSBZyXr3nfXM6zFg/NnDSFuw2MLU42DD8 RM0m7PwJqGd6xd9GQSsmJPjwx+SirBVIgX4HPlMzYCSxA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1683323304; x=1683409704; bh=6 3RaELZf0bZZdNao1GuFs3vFDAm34PcStRchPykUHYs=; b=DWyn4fEISOpJSSncY xcOaePj4xLw1A55hu+5JxyWyn5eqtuW0eddWMFKbD9l/opNYg6ccWq1LZRLykatB 3PUQtcGZhoMzHey8I2pdrgVVp8MYZtyugNLQhQbGBm4TS7WZYYbDx4oDRqgkLtq7 i0ckYS3myC479neV4z4RYmj+RemC7dH6QUR1hxLrAv949s47MEdajYEPUvrP/giQ Y4V0cAxXj9pDPvpVUlP57sMcUJ+n0OL4AH5751L1R0RX3O62j+4zhfH9iA5gYWeK ctJG5IZ38ezFhdDqZAFKa1T9Na00qNilCA26MNxaGCJZQGA5JTXTjDcPwCDBc2SU 2Dwww== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeeffedgtddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofggtgfgsehtkeertdertdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeelkefh udelteelleelteetveeffeetffekteetjeehlefggeekleeghefhtdehvdenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v3] ns16550: enable memory decoding on MMIO-based PCI console card Date: Fri, 5 May 2023 23:48:10 +0200 Message-Id: <20230505214810.406061-1-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit pci_serial_early_init() enables PCI_COMMAND_IO for IO-based UART devices, add setting PCI_COMMAND_MEMORY for MMIO-based UART devices too. Note the MMIO-based devices in practice need a "pci" sub-option, otherwise a few parameters are not initialized (including bar_idx, reg_shift, reg_width etc). The "pci" is not supposed to be used with explicit BDF, so do not key setting PCI_COMMAND_MEMORY on explicit BDF being set. Contrary to the IO-based UART, pci_serial_early_init() will not attempt to set BAR0 address, even if user provided io_base manually - in most cases, those are with an offest and the current cmdline syntax doesn't allow expressing it. Due to this, enable PCI_COMMAND_MEMORY only if uart->bar is already populated. In similar spirit, this patch does not support setting BAR0 of the bridge. Signed-off-by: Marek Marczykowski-Górecki --- This fixes the issue I was talking about on #xendevel. Thanks Roger for the hint. Changes in v2: - check if uart->bar instead of uart->io_base - move it ahead of !uart->ps_bdf_enable return - expand commit message. Changes in v3: - restore io_base check --- xen/drivers/char/ns16550.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c index 1b21eb93c45f..ae845a720f7a 100644 --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -272,6 +272,14 @@ static int cf_check ns16550_getc(struct serial_port *port, char *pc) static void pci_serial_early_init(struct ns16550 *uart) { #ifdef NS16550_PCI + if ( uart->bar && uart->io_base >= 0x10000) + { + pci_conf_write16(PCI_SBDF(0, uart->ps_bdf[0], uart->ps_bdf[1], + uart->ps_bdf[2]), + PCI_COMMAND, PCI_COMMAND_MEMORY); + return; + } + if ( !uart->ps_bdf_enable || uart->io_base >= 0x10000 ) return; -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Fri May 05 22:26:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 22:26:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530675.826424 (Exim 4.92) (envelope-from ) id 1pv3sn-0006s8-4w; Fri, 05 May 2023 22:26:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530675.826424; Fri, 05 May 2023 22:26:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pv3sn-0006s1-1G; Fri, 05 May 2023 22:26:33 +0000 Received: by outflank-mailman (input) for mailman id 530675; Fri, 05 May 2023 22:26:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pv3sm-0006rr-3V; Fri, 05 May 2023 22:26:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pv3sl-00082i-3t; Fri, 05 May 2023 22:26:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pv3sk-0001LU-Ex; Fri, 05 May 2023 22:26:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pv3sk-0007Zg-EY; Fri, 05 May 2023 22:26:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=eA/F8pAMjbBG4X1HTffoC5NimbmB0c22VWChNptmhw8=; b=fL6yHIzliFWSx0MURs0/HuCjjc ylGTNon4W90dy8E1YT7Ss1g847FdvYMlxuvAuaMBGvr0rF1YpPRBzK6IjpQhjAmu0SFa554yc9sz9 zr7jUyRHg0v5zwMZR0sIt2H2OJmz0oN41rTvrf0AtynhDFeJYTfbbehna0diQcNmDl4k=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180540: regressions - FAIL X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=78b421b6a7c6dbb6a213877c742af52330f5026d X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Fri, 05 May 2023 22:26:30 +0000 flight 180540 linux-linus real [real] flight 180548 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180540/ http://logs.test-lab.xenproject.org/osstest/logs/180548/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 180278 Tests which did not succeed, but are not blocking: test-armhf-armhf-examine 8 reboot fail like 180278 test-armhf-armhf-libvirt 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-raw 8 xen-boot fail like 180278 test-armhf-armhf-xl-rtds 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180278 test-armhf-armhf-xl 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180278 test-armhf-armhf-xl-multivcpu 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail like 180278 test-armhf-armhf-xl-credit2 8 xen-boot fail like 180278 test-armhf-armhf-xl-vhd 8 xen-boot fail like 180278 test-armhf-armhf-xl-arndale 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 78b421b6a7c6dbb6a213877c742af52330f5026d baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 19 days Failing since 180281 2023-04-17 06:24:36 Z 18 days 32 attempts Testing same since 180540 2023-05-05 04:38:37 Z 0 days 1 attempts ------------------------------------------------------------ 2247 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 276065 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 05 22:29:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 22:29:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530681.826434 (Exim 4.92) (envelope-from ) id 1pv3vc-0007Ru-Iu; Fri, 05 May 2023 22:29:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530681.826434; Fri, 05 May 2023 22:29:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pv3vc-0007Rn-G7; Fri, 05 May 2023 22:29:28 +0000 Received: by outflank-mailman (input) for mailman id 530681; Fri, 05 May 2023 22:29:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pv3vb-0007Rb-8c for xen-devel@lists.xenproject.org; Fri, 05 May 2023 22:29:27 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 49a0db73-eb94-11ed-8611-37d641c3527e; Sat, 06 May 2023 00:29:24 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BADCD64146; Fri, 5 May 2023 22:29:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3104EC433EF; Fri, 5 May 2023 22:29:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 49a0db73-eb94-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683325763; bh=4dYx1LJPZVLQb1DyajVpkYkYKikgBEG6wKEEOq6JRDg=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=rjIi2K6y9Ut6lOg/KzWnKSLDajpG0zFPHnWWbWbJIfSaJgmTHJiGSSrLkVx1djFJ3 soJ2msK2aNMWijGDvAQN+PYGueCOwtRmuUHOYkCGLLFV5s+h2lktuaqZAfwuWzDjh0 o2Qe2SXqg5pa9Yr9zFoGZiEK723uw+2hqX2kOwMdQjfhfibiOt0Xlc6pkUXvYjdVs0 qGZB9aJrqj6zUEkf7wZDl4XctCSMEo//yNsy3NRdbMsuiOiMtO1XkCtVoSO6sVGY/c yhJUwWhW6KCL8RudA7kUeRK/AqOhJ60pHUrpybbxT6VVicbFhldEZeAT+haPvL6Eit NIHNv/ABwHYQg== Date: Fri, 5 May 2023 15:29:19 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Xen-devel Subject: Re: [PATCH 1/2] LICENSES: Improve the legibility of these files In-Reply-To: Message-ID: References: <20230505130533.3580545-1-andrew.cooper3@citrix.com> <20230505130533.3580545-2-andrew.cooper3@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 5 May 2023, Jan Beulich wrote: > On 05.05.2023 15:05, Andrew Cooper wrote: > > A few newlines go a very long way > > > > Signed-off-by: Andrew Cooper > > Acked-by: Jan Beulich Although I don't mind either way it should be noted that the LICENSES files came from Linux, and Linux doesn't have the extra spaces. That said, these are licenses files not code, so we don't necessarily need to keep them in sync over time I think. So I am fine with this. I am also fine if you drop this patch. Acked-by: Stefano Stabellini From xen-devel-bounces@lists.xenproject.org Fri May 05 22:35:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 May 2023 22:35:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530685.826443 (Exim 4.92) (envelope-from ) id 1pv40o-0000Ru-4w; Fri, 05 May 2023 22:34:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530685.826443; Fri, 05 May 2023 22:34:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pv40o-0000Rn-2M; Fri, 05 May 2023 22:34:50 +0000 Received: by outflank-mailman (input) for mailman id 530685; Fri, 05 May 2023 22:34:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pv40m-0000Rh-LW for xen-devel@lists.xenproject.org; Fri, 05 May 2023 22:34:48 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 09b6a312-eb95-11ed-b226-6b7b168915f2; Sat, 06 May 2023 00:34:47 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D31DB64151; Fri, 5 May 2023 22:34:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C84DC433D2; Fri, 5 May 2023 22:34:44 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 09b6a312-eb95-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683326085; bh=C/tyMP0on/mJnQfCVGm2XWdaMp5GF2+MJvI5FCXTLqw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=DgNoqDqYcVbOWM3f1/A10Xt2InPUysmrPBBiqkpFrPuF89iQLuhs84grhdxWLq8qJ 8Zi8OKJOy1SgtK4YkipQD3naH/FzZsIotDzXMu0Jq95aQaiQj5kXm8nHKGdnrY12Tt V/xZtvlupwWCOmgr5AmSaMsjBERFG1avpPqrQ+NNEVkvWmH0ARbdDQr9WVdG74gSAo NRnPCaMp+aiRbUtRETTtZ1cwsDMlP9+m0DJtkcD8kDEwwDldiqOj/I+GwOz3q7vWBL HUVgIthV5MSAvNzY5I1gNJWZVJvpin43ztSXsYdcgVl+mOFfYBwZ7N+flRGKcAoM7F /ajPZcMvRlHbQ== Date: Fri, 5 May 2023 15:34:41 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Andrew Cooper cc: Xen-devel , Jan Beulich , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Julien Grall Subject: Re: [PATCH v2 2/2] LICENSES: Remove the use of deprecated SPDX tags In-Reply-To: <20230505181528.3587485-3-andrew.cooper3@citrix.com> Message-ID: References: <20230505181528.3587485-1-andrew.cooper3@citrix.com> <20230505181528.3587485-3-andrew.cooper3@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 5 May 2023, Andrew Cooper wrote: > The GPL and LGPL SPDX forms without an explicit -only or -or-later suffix are > deprecated and should not be used. Update the documention. > > Somewhat unhelpfully at the time of writing, this only appears to be indicated > by the separation of the two tables at https://spdx.org/licenses/ > > The recent changes to libacpi are the only examples of deprecated LGPL tags in > tree, so fix them all up. > > For GPL, we have many examples using deprecated tags. For now, just identify > them as such and recommend that no new instances get added. > > Signed-off-by: Andrew Cooper > Acked-by: Jan Beulich Acked-by: Stefano Stabellini > --- > CC: George Dunlap > CC: Jan Beulich > CC: Stefano Stabellini > CC: Wei Liu > CC: Julien Grall > > Unsure whether this should get some Fixes: tags or not. Note also that > Jenny's "[PATCH v4 2/2] acpi: Add TPM2 interface definition." wants its SPDX > tag correcting as per this patch. > > v2: > * Extend commit message to include https://spdx.org/licenses/ > * Update the URLs too > --- > LICENSES/GPL-2.0 | 15 ++++++++------- > LICENSES/LGPL-2.0 | 11 ++++++----- > LICENSES/LGPL-2.1 | 11 ++++++----- > tools/libacpi/Makefile | 2 +- > tools/libacpi/acpi2_0.h | 2 +- > tools/libacpi/build.c | 2 +- > tools/libacpi/dsdt.asl | 2 +- > tools/libacpi/dsdt_acpi_info.asl | 2 +- > tools/libacpi/libacpi.h | 2 +- > tools/libacpi/mk_dsdt.c | 2 +- > tools/libacpi/ssdt_laptop_slate.asl | 2 +- > tools/libacpi/ssdt_pm.asl | 2 +- > tools/libacpi/ssdt_s3.asl | 2 +- > tools/libacpi/ssdt_s4.asl | 2 +- > tools/libacpi/ssdt_tpm.asl | 2 +- > tools/libacpi/static_tables.c | 2 +- > 16 files changed, 33 insertions(+), 30 deletions(-) > > diff --git a/LICENSES/GPL-2.0 b/LICENSES/GPL-2.0 > index fa5c66236fe9..07f332641ccd 100644 > --- a/LICENSES/GPL-2.0 > +++ b/LICENSES/GPL-2.0 > @@ -1,9 +1,11 @@ > -Valid-License-Identifier: GPL-2.0 > Valid-License-Identifier: GPL-2.0-only > -Valid-License-Identifier: GPL-2.0+ > Valid-License-Identifier: GPL-2.0-or-later > > -SPDX-URL: https://spdx.org/licenses/GPL-2.0.html > +SPDX-URL: https://spdx.org/licenses/GPL-2.0-only.html > +SPDX-URL: https://spdx.org/licenses/GPL-2.0-or-later.html > + > +Deprecated-Identifier: GPL-2.0 > +Deprecated-Identifier: GPL-2.0+ > > Usage-Guide: > > @@ -13,14 +15,13 @@ Usage-Guide: > > For 'GNU General Public License (GPL) version 2 only' use: > SPDX-License-Identifier: GPL-2.0-only > - or (now deprecated) > - SPDX-License-Identifier: GPL-2.0 > > For 'GNU General Public License (GPL) version 2 or any later version' use: > - SPDX-License-Identifier: GPL-2.0+ > - or > SPDX-License-Identifier: GPL-2.0-or-later > > + The deprecated tags should not be used for any new additions. Where > + possible, their existing uses should be phased out. > + > License-Text: > > GNU GENERAL PUBLIC LICENSE > diff --git a/LICENSES/LGPL-2.0 b/LICENSES/LGPL-2.0 > index 2fa16d72eabf..100c72c6db8c 100644 > --- a/LICENSES/LGPL-2.0 > +++ b/LICENSES/LGPL-2.0 > @@ -1,7 +1,8 @@ > -Valid-License-Identifier: LGPL-2.0 > -Valid-License-Identifier: LGPL-2.0+ > +Valid-License-Identifier: LGPL-2.0-only > +Valid-License-Identifier: LGPL-2.0-or-later > > -SPDX-URL: https://spdx.org/licenses/LGPL-2.0.html > +SPDX-URL: https://spdx.org/licenses/LGPL-2.0-only.html > +SPDX-URL: https://spdx.org/licenses/LGPL-2.0-or-later.html > > Usage-Guide: > > @@ -10,11 +11,11 @@ Usage-Guide: > guidelines in the licensing rules documentation. > > For 'GNU Library General Public License (LGPL) version 2.0 only' use: > - SPDX-License-Identifier: LGPL-2.0 > + SPDX-License-Identifier: LGPL-2.0-only > > For 'GNU Library General Public License (LGPL) version 2.0 or any later > version' use: > - SPDX-License-Identifier: LGPL-2.0+ > + SPDX-License-Identifier: LGPL-2.0-or-later > > License-Text: > > diff --git a/LICENSES/LGPL-2.1 b/LICENSES/LGPL-2.1 > index b366c7e49199..d3e213c39c26 100644 > --- a/LICENSES/LGPL-2.1 > +++ b/LICENSES/LGPL-2.1 > @@ -1,7 +1,8 @@ > -Valid-License-Identifier: LGPL-2.1 > -Valid-License-Identifier: LGPL-2.1+ > +Valid-License-Identifier: LGPL-2.1-only > +Valid-License-Identifier: LGPL-2.1-or-later > > -SPDX-URL: https://spdx.org/licenses/LGPL-2.1.html > +SPDX-URL: https://spdx.org/licenses/LGPL-2.1-only.html > +SPDX-URL: https://spdx.org/licenses/LGPL-2.1-or-later.html > > Usage-Guide: > > @@ -10,11 +11,11 @@ Usage-Guide: > guidelines in the licensing rules documentation. > > For 'GNU Lesser General Public License (LGPL) version 2.1 only' use: > - SPDX-License-Identifier: LGPL-2.1 > + SPDX-License-Identifier: LGPL-2.1-only > > For 'GNU Lesser General Public License (LGPL) version 2.1 or any later > version' use: > - SPDX-License-Identifier: LGPL-2.1+ > + SPDX-License-Identifier: LGPL-2.1-or-later > > License-Text: > > diff --git a/tools/libacpi/Makefile b/tools/libacpi/Makefile > index aa9c520cbe85..bcfcd852f92f 100644 > --- a/tools/libacpi/Makefile > +++ b/tools/libacpi/Makefile > @@ -1,4 +1,4 @@ > -# SPDX-License-Identifier: LGPL-2.1 > +# SPDX-License-Identifier: LGPL-2.1-only > # > # Copyright (c) 2004, Intel Corporation. > > diff --git a/tools/libacpi/acpi2_0.h b/tools/libacpi/acpi2_0.h > index 212f5ab64182..e00b29854be0 100644 > --- a/tools/libacpi/acpi2_0.h > +++ b/tools/libacpi/acpi2_0.h > @@ -1,4 +1,4 @@ > -/* SPDX-License-Identifier: LGPL-2.1 */ > +/* SPDX-License-Identifier: LGPL-2.1-only */ > /* > * Copyright (c) 2004, Intel Corporation. > */ > diff --git a/tools/libacpi/build.c b/tools/libacpi/build.c > index 830d37c61f03..3142e0ac84c0 100644 > --- a/tools/libacpi/build.c > +++ b/tools/libacpi/build.c > @@ -1,4 +1,4 @@ > -/* SPDX-License-Identifier: LGPL-2.1 */ > +/* SPDX-License-Identifier: LGPL-2.1-only */ > /* > * Copyright (c) 2004, Intel Corporation. > * Copyright (c) 2006, Keir Fraser, XenSource Inc. > diff --git a/tools/libacpi/dsdt.asl b/tools/libacpi/dsdt.asl > index c6691b56a986..32b42f85ae9f 100644 > --- a/tools/libacpi/dsdt.asl > +++ b/tools/libacpi/dsdt.asl > @@ -1,4 +1,4 @@ > -/* SPDX-License-Identifier: LGPL-2.1 */ > +/* SPDX-License-Identifier: LGPL-2.1-only */ > /****************************************************************************** > * DSDT for Xen with Qemu device model > * > diff --git a/tools/libacpi/dsdt_acpi_info.asl b/tools/libacpi/dsdt_acpi_info.asl > index c6e82f1fe6a7..6e114fa23404 100644 > --- a/tools/libacpi/dsdt_acpi_info.asl > +++ b/tools/libacpi/dsdt_acpi_info.asl > @@ -1,4 +1,4 @@ > -/* SPDX-License-Identifier: LGPL-2.1 */ > +/* SPDX-License-Identifier: LGPL-2.1-only */ > > Scope (\_SB) > { > diff --git a/tools/libacpi/libacpi.h b/tools/libacpi/libacpi.h > index acf012e35578..7ae28525f604 100644 > --- a/tools/libacpi/libacpi.h > +++ b/tools/libacpi/libacpi.h > @@ -1,4 +1,4 @@ > -/* SPDX-License-Identifier: LGPL-2.1 */ > +/* SPDX-License-Identifier: LGPL-2.1-only */ > /****************************************************************************** > * libacpi.h > * > diff --git a/tools/libacpi/mk_dsdt.c b/tools/libacpi/mk_dsdt.c > index c74b270c0c5d..34f6753f6193 100644 > --- a/tools/libacpi/mk_dsdt.c > +++ b/tools/libacpi/mk_dsdt.c > @@ -1,4 +1,4 @@ > -/* SPDX-License-Identifier: LGPL-2.1 */ > +/* SPDX-License-Identifier: LGPL-2.1-only */ > > #include > #include > diff --git a/tools/libacpi/ssdt_laptop_slate.asl b/tools/libacpi/ssdt_laptop_slate.asl > index 494f2d048d0a..69fd504c19fc 100644 > --- a/tools/libacpi/ssdt_laptop_slate.asl > +++ b/tools/libacpi/ssdt_laptop_slate.asl > @@ -1,4 +1,4 @@ > -/* SPDX-License-Identifier: LGPL-2.1 */ > +/* SPDX-License-Identifier: LGPL-2.1-only */ > /* > * ssdt_conv.asl > * > diff --git a/tools/libacpi/ssdt_pm.asl b/tools/libacpi/ssdt_pm.asl > index e577e85c072b..db578d10ac3e 100644 > --- a/tools/libacpi/ssdt_pm.asl > +++ b/tools/libacpi/ssdt_pm.asl > @@ -1,4 +1,4 @@ > -/* SPDX-License-Identifier: LGPL-2.1 */ > +/* SPDX-License-Identifier: LGPL-2.1-only */ > /* > * ssdt_pm.asl > * > diff --git a/tools/libacpi/ssdt_s3.asl b/tools/libacpi/ssdt_s3.asl > index 8f3177ec5adc..f6e9636f4759 100644 > --- a/tools/libacpi/ssdt_s3.asl > +++ b/tools/libacpi/ssdt_s3.asl > @@ -1,4 +1,4 @@ > -/* SPDX-License-Identifier: LGPL-2.1 */ > +/* SPDX-License-Identifier: LGPL-2.1-only */ > /* > * ssdt_s3.asl > * > diff --git a/tools/libacpi/ssdt_s4.asl b/tools/libacpi/ssdt_s4.asl > index 979318eca1f5..8014f5fc9014 100644 > --- a/tools/libacpi/ssdt_s4.asl > +++ b/tools/libacpi/ssdt_s4.asl > @@ -1,4 +1,4 @@ > -/* SPDX-License-Identifier: LGPL-2.1 */ > +/* SPDX-License-Identifier: LGPL-2.1-only */ > /* > * ssdt_s4.asl > * > diff --git a/tools/libacpi/ssdt_tpm.asl b/tools/libacpi/ssdt_tpm.asl > index 6c3267218f3b..944658d25177 100644 > --- a/tools/libacpi/ssdt_tpm.asl > +++ b/tools/libacpi/ssdt_tpm.asl > @@ -1,4 +1,4 @@ > -/* SPDX-License-Identifier: LGPL-2.1 */ > +/* SPDX-License-Identifier: LGPL-2.1-only */ > /* > * ssdt_tpm.asl > * > diff --git a/tools/libacpi/static_tables.c b/tools/libacpi/static_tables.c > index 631fb911413b..715f46fee05c 100644 > --- a/tools/libacpi/static_tables.c > +++ b/tools/libacpi/static_tables.c > @@ -1,4 +1,4 @@ > -/* SPDX-License-Identifier: LGPL-2.1 */ > +/* SPDX-License-Identifier: LGPL-2.1-only */ > /* > * Copyright (c) 2004, Intel Corporation. > * Copyright (c) 2006, Keir Fraser, XenSource Inc. > -- > 2.30.2 > From xen-devel-bounces@lists.xenproject.org Sat May 06 00:35:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 May 2023 00:35:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530751.826488 (Exim 4.92) (envelope-from ) id 1pv5to-0007Br-Nf; Sat, 06 May 2023 00:35:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530751.826488; Sat, 06 May 2023 00:35:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pv5to-0007Bk-Kp; Sat, 06 May 2023 00:35:44 +0000 Received: by outflank-mailman (input) for mailman id 530751; Sat, 06 May 2023 00:35:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pv5tn-0007Be-4p for xen-devel@lists.xenproject.org; Sat, 06 May 2023 00:35:43 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ecd62efd-eba5-11ed-8611-37d641c3527e; Sat, 06 May 2023 02:35:40 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0079763C2E; Sat, 6 May 2023 00:35:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4DED8C433D2; Sat, 6 May 2023 00:35:37 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ecd62efd-eba5-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683333338; bh=bP/3aHvZYOXH3zu8B4TUIjOV1o/FusNOt/78mT12AFw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=FA6qHKtIZCoo7JyMA/TPj5q9THuxlE3xbt1wUPQos+XP7Llr1DVlqSqtI9CtwtEnz ZtUpCdFFsQR/gq0RuBDEBWUmNytLi/26Er/7E5CNzoXvyhvX11CvehWdgMcSyFl5cZ 3HzhQ/SrPomJvST5vkoMFoGPniwB7pf7KCH8NLBEl5KAntmYPPE51DFaGvltpnRcUH HwWJN2Z7vYd8UykRhHmNmOONUvwc3qz1+hw8RfD3ILXha6BvLupOEUlSSxKnAeUsjz p2hwvi5X8C8gabXB+E3EvyS/+uNsd1Knj9l/hxSPto3NSsb+r7k38IJIl4nGDQLUHr o4yTLuUOaVS/w== Date: Fri, 5 May 2023 17:35:35 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jason Andryuk cc: qemu-devel@nongnu.org, Greg Kurz , Christian Schoenebeck , Stefano Stabellini , Anthony Perard , Paul Durrant , "open list:X86 Xen CPUs" Subject: Re: [PATCH] 9pfs/xen: Fix segfault on shutdown In-Reply-To: <20230502143722.15613-1-jandryuk@gmail.com> Message-ID: References: <20230502143722.15613-1-jandryuk@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 2 May 2023, Jason Andryuk wrote: > xen_9pfs_free can't use gnttabdev since it is already closed and NULL-ed > out when free is called. Do the teardown in _disconnect(). This > matches the setup done in _connect(). > > trace-events are also added for the XenDevOps functions. > > Signed-off-by: Jason Andryuk > --- > hw/9pfs/trace-events | 5 +++++ > hw/9pfs/xen-9p-backend.c | 36 +++++++++++++++++++++++------------- > 2 files changed, 28 insertions(+), 13 deletions(-) > > diff --git a/hw/9pfs/trace-events b/hw/9pfs/trace-events > index 6c77966c0b..7b5b0b5a48 100644 > --- a/hw/9pfs/trace-events > +++ b/hw/9pfs/trace-events > @@ -48,3 +48,8 @@ v9fs_readlink(uint16_t tag, uint8_t id, int32_t fid) "tag %d id %d fid %d" > v9fs_readlink_return(uint16_t tag, uint8_t id, char* target) "tag %d id %d name %s" > v9fs_setattr(uint16_t tag, uint8_t id, int32_t fid, int32_t valid, int32_t mode, int32_t uid, int32_t gid, int64_t size, int64_t atime_sec, int64_t mtime_sec) "tag %u id %u fid %d iattr={valid %d mode %d uid %d gid %d size %"PRId64" atime=%"PRId64" mtime=%"PRId64" }" > v9fs_setattr_return(uint16_t tag, uint8_t id) "tag %u id %u" > + > +xen_9pfs_alloc(char *name) "name %s" > +xen_9pfs_connect(char *name) "name %s" > +xen_9pfs_disconnect(char *name) "name %s" > +xen_9pfs_free(char *name) "name %s" > diff --git a/hw/9pfs/xen-9p-backend.c b/hw/9pfs/xen-9p-backend.c > index 0e266c552b..c646a0b3d1 100644 > --- a/hw/9pfs/xen-9p-backend.c > +++ b/hw/9pfs/xen-9p-backend.c > @@ -25,6 +25,8 @@ > #include "qemu/iov.h" > #include "fsdev/qemu-fsdev.h" > > +#include "trace.h" > + > #define VERSIONS "1" > #define MAX_RINGS 8 > #define MAX_RING_ORDER 9 > @@ -337,6 +339,8 @@ static void xen_9pfs_disconnect(struct XenLegacyDevice *xendev) > Xen9pfsDev *xen_9pdev = container_of(xendev, Xen9pfsDev, xendev); > int i; > > + trace_xen_9pfs_disconnect(xendev->name); > + > for (i = 0; i < xen_9pdev->num_rings; i++) { > if (xen_9pdev->rings[i].evtchndev != NULL) { > qemu_set_fd_handler(qemu_xen_evtchn_fd(xen_9pdev->rings[i].evtchndev), > @@ -345,40 +349,42 @@ static void xen_9pfs_disconnect(struct XenLegacyDevice *xendev) > xen_9pdev->rings[i].local_port); > xen_9pdev->rings[i].evtchndev = NULL; > } > - } > -} > - > -static int xen_9pfs_free(struct XenLegacyDevice *xendev) > -{ > - Xen9pfsDev *xen_9pdev = container_of(xendev, Xen9pfsDev, xendev); > - int i; > - > - if (xen_9pdev->rings[0].evtchndev != NULL) { > - xen_9pfs_disconnect(xendev); > - } > - > - for (i = 0; i < xen_9pdev->num_rings; i++) { > if (xen_9pdev->rings[i].data != NULL) { > xen_be_unmap_grant_refs(&xen_9pdev->xendev, > xen_9pdev->rings[i].data, > xen_9pdev->rings[i].intf->ref, > (1 << xen_9pdev->rings[i].ring_order)); > + xen_9pdev->rings[i].data = NULL; > } > if (xen_9pdev->rings[i].intf != NULL) { > xen_be_unmap_grant_ref(&xen_9pdev->xendev, > xen_9pdev->rings[i].intf, > xen_9pdev->rings[i].ref); > + xen_9pdev->rings[i].intf = NULL; > } > if (xen_9pdev->rings[i].bh != NULL) { > qemu_bh_delete(xen_9pdev->rings[i].bh); > + xen_9pdev->rings[i].bh = NULL; > } > } > > g_free(xen_9pdev->id); > + xen_9pdev->id = NULL; > g_free(xen_9pdev->tag); > + xen_9pdev->tag = NULL; > g_free(xen_9pdev->path); > + xen_9pdev->path = NULL; > g_free(xen_9pdev->security_model); > + xen_9pdev->security_model = NULL; > g_free(xen_9pdev->rings); > + xen_9pdev->rings = NULL; > + return; NIT: this return is redudant. Aside from that: Reviewed-by: Stefano Stabellini > +} > + > +static int xen_9pfs_free(struct XenLegacyDevice *xendev) > +{ > + trace_xen_9pfs_free(xendev->name); > + > return 0; > } > > @@ -390,6 +396,8 @@ static int xen_9pfs_connect(struct XenLegacyDevice *xendev) > V9fsState *s = &xen_9pdev->state; > QemuOpts *fsdev; > > + trace_xen_9pfs_connect(xendev->name); > + > if (xenstore_read_fe_int(&xen_9pdev->xendev, "num-rings", > &xen_9pdev->num_rings) == -1 || > xen_9pdev->num_rings > MAX_RINGS || xen_9pdev->num_rings < 1) { > @@ -499,6 +507,8 @@ out: > > static void xen_9pfs_alloc(struct XenLegacyDevice *xendev) > { > + trace_xen_9pfs_alloc(xendev->name); > + > xenstore_write_be_str(xendev, "versions", VERSIONS); > xenstore_write_be_int(xendev, "max-rings", MAX_RINGS); > xenstore_write_be_int(xendev, "max-ring-page-order", MAX_RING_ORDER); > -- > 2.40.1 > From xen-devel-bounces@lists.xenproject.org Sat May 06 00:53:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 May 2023 00:53:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530756.826498 (Exim 4.92) (envelope-from ) id 1pv6AM-0001Bs-55; Sat, 06 May 2023 00:52:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530756.826498; Sat, 06 May 2023 00:52:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pv6AM-0001Bl-2I; Sat, 06 May 2023 00:52:50 +0000 Received: by outflank-mailman (input) for mailman id 530756; Sat, 06 May 2023 00:52:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pv6AL-0001Be-53 for xen-devel@lists.xenproject.org; Sat, 06 May 2023 00:52:49 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 50950233-eba8-11ed-b226-6b7b168915f2; Sat, 06 May 2023 02:52:46 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4FF0F6348A; Sat, 6 May 2023 00:52:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54D14C433D2; Sat, 6 May 2023 00:52:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50950233-eba8-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683334364; bh=ALHPOAtna/tjSpwcldHIbCxstSQu3IlIOdXMLK1ymAk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=s0yzFH9qRgGUP+ca4jtTQerypoWoG51VOS6A+g3VEyKBY2xNAE7TKOqWi16rxNGti CAgY2oYIOq1jxq0wfZKej6MBEJ8cfsIOJ/BXrRLcKwC5SRzzDzbVJvZZhqftMjE5IE +YWk9Sn14B1chGnGsANBCTQFCwxpqrkF7l6oP87N3+8avr1HsnY9i9odXT2lWMQP7n 0dSvqSi1R8iDGRoY76Ir8wPc1bftYPConBgX+NmkoXDYAVb0YyjApB8MyHWFvlngkh R+HySXoRmobwFj6V7unKA1BzJZlYgc2MbEnllsFt7wmQGvpS0ZpiSQF+a6eu43w32G S07IPWkMiPmgg== Date: Fri, 5 May 2023 17:52:40 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Rahul Singh cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Samuel Holland , Boris Ostrovsky , Marc Zyngier , Jane Malalane , David Woodhouse Subject: Re: [PATCH] xen/evtchn: Introduce new IOCTL to bind static evtchn In-Reply-To: <48d30a439e37f6917b9a667289792c2b3f548d6d.1682685294.git.rahul.singh@arm.com> Message-ID: References: <48d30a439e37f6917b9a667289792c2b3f548d6d.1682685294.git.rahul.singh@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1916755753-1683334363=:974517" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1916755753-1683334363=:974517 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Fri, 28 Apr 2023, Rahul Singh wrote: > Xen 4.17 supports the creation of static evtchns. To allow user space > application to bind static evtchns introduce new ioctl > "IOCTL_EVTCHN_BIND_STATIC". Existing IOCTL doing more than binding > that’s why we need to introduce the new IOCTL to only bind the static > event channels. > > Also, static evtchns to be available for use during the lifetime of the > guest. When the application exits, __unbind_from_irq() end up > being called from release() fop because of that static evtchns are > getting closed. To avoid closing the static event channel, add the new > bool variable "is_static" in "struct irq_info" to mark the event channel > static when creating the event channel to avoid closing the static > evtchn. > > Signed-off-by: Rahul Singh I think the patch is OK but evtchn_bind_to_user on the error path calls EVTCHNOP_close. Could that be a problem for static evtchns? I wonder if we need to skip that EVTCHNOP_close call too. err: /* bind failed, should close the port now */ close.port = port; if (HYPERVISOR_event_channel_op(EVTCHNOP_close, &close) != 0) BUG(); del_evtchn(u, evtchn); > --- > drivers/xen/events/events_base.c | 7 +++++-- > drivers/xen/evtchn.c | 22 +++++++++++++++++----- > include/uapi/xen/evtchn.h | 9 +++++++++ > include/xen/events.h | 2 +- > 4 files changed, 32 insertions(+), 8 deletions(-) > > diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c > index c7715f8bd452..31f2d3634ad5 100644 > --- a/drivers/xen/events/events_base.c > +++ b/drivers/xen/events/events_base.c > @@ -112,6 +112,7 @@ struct irq_info { > unsigned int irq_epoch; /* If eoi_cpu valid: irq_epoch of event */ > u64 eoi_time; /* Time in jiffies when to EOI. */ > raw_spinlock_t lock; > + u8 is_static; /* Is event channel static */ > > union { > unsigned short virq; > @@ -982,7 +983,8 @@ static void __unbind_from_irq(unsigned int irq) > unsigned int cpu = cpu_from_irq(irq); > struct xenbus_device *dev; > > - xen_evtchn_close(evtchn); > + if (!info->is_static) > + xen_evtchn_close(evtchn); > > switch (type_from_irq(irq)) { > case IRQT_VIRQ: > @@ -1574,7 +1576,7 @@ int xen_set_irq_priority(unsigned irq, unsigned priority) > } > EXPORT_SYMBOL_GPL(xen_set_irq_priority); > > -int evtchn_make_refcounted(evtchn_port_t evtchn) > +int evtchn_make_refcounted(evtchn_port_t evtchn, bool is_static) > { > int irq = get_evtchn_to_irq(evtchn); > struct irq_info *info; > @@ -1590,6 +1592,7 @@ int evtchn_make_refcounted(evtchn_port_t evtchn) > WARN_ON(info->refcnt != -1); > > info->refcnt = 1; > + info->is_static = is_static; > > return 0; > } > diff --git a/drivers/xen/evtchn.c b/drivers/xen/evtchn.c > index c99415a70051..47681d4c696b 100644 > --- a/drivers/xen/evtchn.c > +++ b/drivers/xen/evtchn.c > @@ -366,7 +366,8 @@ static int evtchn_resize_ring(struct per_user_data *u) > return 0; > } > > -static int evtchn_bind_to_user(struct per_user_data *u, evtchn_port_t port) > +static int evtchn_bind_to_user(struct per_user_data *u, evtchn_port_t port, > + bool is_static) > { > struct user_evtchn *evtchn; > struct evtchn_close close; > @@ -402,7 +403,7 @@ static int evtchn_bind_to_user(struct per_user_data *u, evtchn_port_t port) > if (rc < 0) > goto err; > > - rc = evtchn_make_refcounted(port); > + rc = evtchn_make_refcounted(port, is_static); > return rc; > > err: > @@ -456,7 +457,7 @@ static long evtchn_ioctl(struct file *file, > if (rc != 0) > break; > > - rc = evtchn_bind_to_user(u, bind_virq.port); > + rc = evtchn_bind_to_user(u, bind_virq.port, false); > if (rc == 0) > rc = bind_virq.port; > break; > @@ -482,7 +483,7 @@ static long evtchn_ioctl(struct file *file, > if (rc != 0) > break; > > - rc = evtchn_bind_to_user(u, bind_interdomain.local_port); > + rc = evtchn_bind_to_user(u, bind_interdomain.local_port, false); > if (rc == 0) > rc = bind_interdomain.local_port; > break; > @@ -507,7 +508,7 @@ static long evtchn_ioctl(struct file *file, > if (rc != 0) > break; > > - rc = evtchn_bind_to_user(u, alloc_unbound.port); > + rc = evtchn_bind_to_user(u, alloc_unbound.port, false); > if (rc == 0) > rc = alloc_unbound.port; > break; > @@ -536,6 +537,17 @@ static long evtchn_ioctl(struct file *file, > break; > } > > + case IOCTL_EVTCHN_BIND_STATIC: { > + struct ioctl_evtchn_bind bind; > + > + rc = -EFAULT; > + if (copy_from_user(&bind, uarg, sizeof(bind))) > + break; > + > + rc = evtchn_bind_to_user(u, bind.port, true); > + break; > + } > + > case IOCTL_EVTCHN_NOTIFY: { > struct ioctl_evtchn_notify notify; > struct user_evtchn *evtchn; > diff --git a/include/uapi/xen/evtchn.h b/include/uapi/xen/evtchn.h > index 7fbf732f168f..aef2b75f3413 100644 > --- a/include/uapi/xen/evtchn.h > +++ b/include/uapi/xen/evtchn.h > @@ -101,4 +101,13 @@ struct ioctl_evtchn_restrict_domid { > domid_t domid; > }; > > +/* > + * Bind statically allocated @port. > + */ > +#define IOCTL_EVTCHN_BIND_STATIC \ > + _IOC(_IOC_NONE, 'E', 7, sizeof(struct ioctl_evtchn_bind)) > +struct ioctl_evtchn_bind { > + unsigned int port; > +}; > + > #endif /* __LINUX_PUBLIC_EVTCHN_H__ */ > diff --git a/include/xen/events.h b/include/xen/events.h > index 44c2855c76d1..962f0bbc7ce1 100644 > --- a/include/xen/events.h > +++ b/include/xen/events.h > @@ -69,7 +69,7 @@ int xen_set_irq_priority(unsigned irq, unsigned priority); > /* > * Allow extra references to event channels exposed to userspace by evtchn > */ > -int evtchn_make_refcounted(evtchn_port_t evtchn); > +int evtchn_make_refcounted(evtchn_port_t evtchn, bool is_static); > int evtchn_get(evtchn_port_t evtchn); > void evtchn_put(evtchn_port_t evtchn); > > -- > 2.25.1 > --8323329-1916755753-1683334363=:974517-- From xen-devel-bounces@lists.xenproject.org Sat May 06 00:54:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 May 2023 00:54:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530761.826508 (Exim 4.92) (envelope-from ) id 1pv6BT-0001hd-Fp; Sat, 06 May 2023 00:53:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530761.826508; Sat, 06 May 2023 00:53:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pv6BT-0001hW-Cj; Sat, 06 May 2023 00:53:59 +0000 Received: by outflank-mailman (input) for mailman id 530761; Sat, 06 May 2023 00:53:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pv6BR-0001gm-HF for xen-devel@lists.xenproject.org; Sat, 06 May 2023 00:53:57 +0000 Received: from DM5PR00CU002.outbound.protection.outlook.com (mail-cusazlp170110003.outbound.protection.outlook.com [2a01:111:f403:c111::3]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7967c960-eba8-11ed-8611-37d641c3527e; Sat, 06 May 2023 02:53:55 +0200 (CEST) Received: from BYAPR21MB1688.namprd21.prod.outlook.com (2603:10b6:a02:bf::26) by CY5PR21MB3447.namprd21.prod.outlook.com (2603:10b6:930:c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.11; Sat, 6 May 2023 00:53:50 +0000 Received: from BYAPR21MB1688.namprd21.prod.outlook.com ([fe80::9a0f:a04d:69bd:e622]) by BYAPR21MB1688.namprd21.prod.outlook.com ([fe80::9a0f:a04d:69bd:e622%4]) with mapi id 15.20.6387.012; Sat, 6 May 2023 00:53:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7967c960-eba8-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LS1MpF61S0SiLXzXzkxI7LfoQ3vW7euzQ8IObApn5AwVo268iqb2hPiVgffH26wRbnOSvoININAgKdMuHZtzm/XhuFSWDLGcRFjtEEmWto3/vQ8r0hupl8d3Kp3Ca/drU8weVeKiFev/5xlgvAYeXP9SuaXKQxx1EzWiKNU/bSA5eqkbzPF78UkbeFqs4vXGuHjgC0kS6cIvJmNIyzlTIDtYTtn/kh9N9dru1Dz1Lm5bNgmHM3wC/yq0A/DLCX20Nvwr2+ChjmPjIF08Xnpx2eoOpKVKbFaxM2OBaQW3sM5U6mACJPohKTBzIrjRnUjIkpSI71ntOmR+WY95rdOAoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sK/IQvGZxUgMCa0K1Eigw1rYj2UhiPgrotGAq3MSiR4=; b=kHfC5XSovSYGyS/+5jTV0QwQSwNaV9i7AbzrU842xsrZOvuXe4PaMeRdSjeA0tGIhfwLOiGlmhfbcetXSZJgbfsv6/QAjCuebaxkCKLMzSyLTgwmklbBVw+SzcWaqfT9TmBUOpiQaEjikyVMvNQo1Y1WD1+zeuTVjc9v3Kk+VpHErHFtjBNeUSvZFJ74Ffy4JWr/eHFxyIe+W66n7/aVh0NRoI2HEyScVohriKYD9xtcoLS38mNHCVYW+Ckthx3YPLkvTnmAMt19fpoib/1He0tIdm7eeZwKM0VQuTO6sSBPwO/a2QKcafw0ubfLmUc3gTnlrilHtWMoXmSMRiAW8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sK/IQvGZxUgMCa0K1Eigw1rYj2UhiPgrotGAq3MSiR4=; b=b/hnm1GFlBHcj/2O4ssVnTDvGc/uQDdR+tpq5T/NLUTGLwLHywgdHx/bCkEsGChRv9b6csldT8JyqwDxaGT6WwxxBRewBKNFvGp+HKBcpSyfUYL/2zLgIQyrCUhHOEXHjyeJCeery1RjvkNPQoTh+JcjUURgUMWkGFp5q84viWE= From: "Michael Kelley (LINUX)" To: Thomas Gleixner , LKML CC: "x86@kernel.org" , David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , "xen-devel@lists.xenproject.org" , Russell King , Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" , Catalin Marinas , Will Deacon , Guo Ren , "linux-csky@vger.kernel.org" , Thomas Bogendoerfer , "linux-mips@vger.kernel.org" , "James E.J. Bottomley" , Helge Deller , "linux-parisc@vger.kernel.org" , Paul Walmsley , Palmer Dabbelt , "linux-riscv@lists.infradead.org" , Mark Rutland , Sabin Rapan Subject: RE: [patch V2 38/38] x86/smpboot/64: Implement arch_cpuhp_init_parallel_bringup() and enable it Thread-Topic: [patch V2 38/38] x86/smpboot/64: Implement arch_cpuhp_init_parallel_bringup() and enable it Thread-Index: AQHZfrsPO9aHmT4GeE2OzCti+2hGJa9Macrg Date: Sat, 6 May 2023 00:53:50 +0000 Message-ID: References: <20230504185733.126511787@linutronix.de> <20230504185938.393373946@linutronix.de> In-Reply-To: <20230504185938.393373946@linutronix.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=48817eed-6fcb-49bc-9a01-6a43bf5b9b82;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2023-05-06T00:42:24Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR21MB1688:EE_|CY5PR21MB3447:EE_ x-ms-office365-filtering-correlation-id: ede41693-710a-42e8-4c62-08db4dcc5b7b x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UOc9Db0wWrh2du3sbXN0q2e69LdewzzfxnEuAoaxPnLtsxOnJnAB9i5KvkPtcUvLUcYvZBqs2LsO/Op4kmGLXv3b53PL7TZ3cuVWyzCXcqCI2qnWoM6iAmETAT7kQPx8lNlJE3c5M1LfwEirdynbOqzw2x+ZnesUsUcpgjqKJZMp9fuIYAzO4+vyNgmeueiyEMKZgt6vRRLoszEtZeFrGzCjHQmN2Fkiz5T7qtnh6Vwxl7aZ5g5ywZtikNZK6HURstJAg8bBygsc49lnxmKrpknDPNVprVXI+KQuGFuJtguW0sayTwbCSyOiRE02N1L7wxFWU4MMYpqrAE+e3keyXLsHgB5Tz3v8Xb/TnXJwyQqNrkwnbMmY3Uorg6zno8dOiyAJiTtyCwTVWosokiYsQaJbqlTRpp4oel/CKQl+VSOT92d8tUsEa2mpDh49VwwMjvbWPlZoZ4wzG9QY388dS5Ea07jeqR6cpjlmLlcvfLyLeA6W/n0kxpzdaL5oimNGNxsQ3s/xc02EOcvSJLguKtDrIuZ2243EzD6Y3kYG438lBjO56Di1RKYe75hDOLB/nXrbxgoLqb7WEQv803wlVcmQKAflpagVQoN5fXvd2+m+MF1yqCgj280TK7fYzgcHQv0G/aKj5gsn0iT9WlGYD6a/UJ4/6N2HCHcxbOnl2eI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR21MB1688.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(366004)(39860400002)(396003)(376002)(451199021)(38100700002)(8676002)(8936002)(5660300002)(7406005)(52536014)(83380400001)(2906002)(38070700005)(82960400001)(316002)(82950400001)(786003)(7416002)(66556008)(4326008)(66946007)(8990500004)(76116006)(6506007)(26005)(66446008)(9686003)(64756008)(66476007)(71200400001)(54906003)(110136005)(41300700001)(122000001)(7696005)(55016003)(186003)(33656002)(10290500003)(86362001)(478600001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MVVTR0xkZ0lpelRrMnRGYXB0dDVnNTM1Q3dPVnhheXNHRkIyRjlvYVEvdjFL?= =?utf-8?B?RFN4cjB6MS9talI2MnNIZTJtZHViUCswNkMrMUU4UVZ3TDFxRWZpUllGQW9I?= =?utf-8?B?bVJOVncydDR4TXdvNWZmL3NJd1J4bW01U3pncjFlZ0hJeDJPOEpBZWpUd1Vt?= =?utf-8?B?YVgzMkJhY2ErVVRsSDErYVZwM3pkME45MG8zYy9Sd0NHSFI5RkNtUzRLUjBJ?= =?utf-8?B?dHdVUCt1THlsYjErWDF3ZHZsU2hhL1J0ODdJcWVoWGpGejJtWWdyeS9UcFU4?= =?utf-8?B?SmFIeGF3YUx2cDZqNktSTERYSkhrR2tIQjZBaHZHWHBlS0tSVHFOWlppUW9T?= =?utf-8?B?dUE1WXhxbG5tNnA4R1FzZ3lXdzcwMXFsNURPTmRSSWpYY1g4UGVzK211SUp5?= =?utf-8?B?WVNWcml0NThtN3Y4cU4xM0l3S1Npb3RJV2swMzNOVDkwYnBWN2UwclhsZTJq?= =?utf-8?B?bEFYMTBnWHRIUDN2cWkrNlErdHd4TWxIdnBBNHZWcTUxWFBrbUhIZ3VFMzZY?= =?utf-8?B?WkN3bVdrWGdDbE1RakNUSEREcVJOWGNBV0lULzlCSysrN0Y4ek9wUWw2ZXp3?= =?utf-8?B?WGZMRWlUQkx3dDBXUUtoa2RUQ21GSlFlQ2xXOGhGdXQwdElwbTZwdDZsczVi?= =?utf-8?B?QVBSTDRiQkpNNms1MTJUanZRa0F3QU1lb2FDLzA0S3pCYzA3SGFzL0ZGRmdF?= =?utf-8?B?L1dlYUplcS9rZEJiVFRpM3VIVHpTcTYyZ2Q3VkpvY0NSSFNMWjliejM4VHVu?= =?utf-8?B?dWRQaTlsUHZUMXhyMStQMjBkdjU3THNhMitDa05NL0JKT0NycHJPWExZbXpI?= =?utf-8?B?N2dObEFueVNsbkV1ZXp4R1laWHZKOWE0ZmdUTVBrY2lYSnJONWwzS2VYMjNX?= =?utf-8?B?dlNhSWlsMWpqN3ZHSXBtWjZ4VzYxaFlKbG1uR3RIc0tJZDR3TXZyVDU1NTVt?= =?utf-8?B?dlB6VzNuQjRVa0ZOMUVjRkYvcDZPZFYzTGZDOTQwM2plQVQxS3llK2FHT0NH?= =?utf-8?B?QWxhbTVsdW1yUEJoaWk0QWpUK2E2ZDZ5NDVCUUlNdjdyMTZHbk84R3lCMFp5?= =?utf-8?B?b0xqWkV6MktvWkYvbDk1TGc1RVFKbHgrRVBSUjdmS0h5V0tCV0pUK3ZFZHR5?= =?utf-8?B?ZlFkN2xvcGo3S2pmNUZ0c0k0VTNQRW1GRXhCUlhZbW1YZ3hHK3g4eHpsODN5?= =?utf-8?B?Ni94cFgxeENZeWlWK0w5cjRxM0pKL2ZGaXFjYXJ3NEM3VXh0ejNUaDd6dzda?= =?utf-8?B?YnFXTWVZWUpZOWlqeU9WdEMxMDBTQUhyZmhZcUZPYlByUmVPMmlYNDRwR01B?= =?utf-8?B?cjMvb1BTcUZVVDNWMDNnZmp4V0o5WGpIRnJjN2c4dVZacFl4c2szcStnM0w1?= =?utf-8?B?eTJ2QnhMUjVibHZvWGN6bHEydGl1cGw2cHoyakFUdUExblF0T2NNSTVacEFS?= =?utf-8?B?T1o0a0Q4TlVQMmgxZkw2VnNEVC8xRlNXekFUcGkzWk5nMlJQNVI0eVB1OGdr?= =?utf-8?B?UUg3UGdGcGhaYk55WHhQMU1sNHJlNSthTThIalpmT2sxelhvWWtkbVltMW85?= =?utf-8?B?UnVaK2VnUWxMRlpSdkhhS1ZTSHlHdUVIZE9IOENoVGdPN2VMUUNMTE1JVEhr?= =?utf-8?B?bzBrRTEraXNVNFEwZFViaUxROENpNnYrM0x6M0dYNjR3RFZ3SE80UXFGclow?= =?utf-8?B?RytDZlNpbllzNFRNamcyc0F5MUxUN3ZDSnNwdnRBaDRQdFgxOHF5NWhSbUNh?= =?utf-8?B?OXRlK1hQNG5LV3czbEdaeDR0Qlk5UzFkdUlGbURoQjRPVnRDMmZ2ODhBRXAy?= =?utf-8?B?WDM5Q0NrMFBXVmVtdE1wZkFpcTJHdXAvMWVpaVhSQlpIb000Q0hSWW0zZzRz?= =?utf-8?B?SjZHY0NBRm1RSUgvaHNFSy9NdXoxSmxpclBmeForY0RiY3RWYm9oVzROeVpK?= =?utf-8?B?WldOMm5sVm5Pd2dEbGdCRTJWK29aRmV0YVFmbmQ2N295N3JmTllaV0JWZjRa?= =?utf-8?B?bnpJMGsvbjZZRFNld3pNaXJkUy9scFVKV1U5VEJYRU5XUit0N0h2NlFoWlFq?= =?utf-8?B?TmRMUW5CaTdtMmNMK1J4RzFET3VJdXdEWkg4NXQ3RkxaekdwZmp0M3FIVFlF?= =?utf-8?B?bE5ucTlNOUFFZElDYk1JbmI3Z1NUNEdOUS9HWk15TEthWG5aVmhPeUxpdmta?= =?utf-8?B?Y2c9PQ==?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR21MB1688.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ede41693-710a-42e8-4c62-08db4dcc5b7b X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2023 00:53:50.6070 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5f63waM6CyyNfW9fBBr2sRx9cC18cFX9lz+N40ZowcuYvVqDxvJLM4ohL5Diajh7fXh+UFKh20WcZBTRuMpfqoZiiLRuRDrQycKnms7QMlQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR21MB3447 RnJvbTogVGhvbWFzIEdsZWl4bmVyIDx0Z2x4QGxpbnV0cm9uaXguZGU+IFNlbnQ6IFRodXJzZGF5 LCBNYXkgNCwgMjAyMyAxMjowMyBQTQ0KPiANCj4gSW1wbGVtZW50IHRoZSB2YWxpZGF0aW9uIGZ1 bmN0aW9uIHdoaWNoIHRlbGxzIHRoZSBjb3JlIGNvZGUgd2hldGhlcg0KPiBwYXJhbGxlbCBicmlu Z3VwIGlzIHBvc3NpYmxlLg0KPiANCj4gVGhlIG9ubHkgY29uZGl0aW9uIGZvciBub3cgaXMgdGhh dCB0aGUga2VybmVsIGRvZXMgbm90IHJ1biBpbiBhbiBlbmNyeXB0ZWQNCj4gZ3Vlc3QgYXMgdGhl c2Ugd2lsbCB0cmFwIHRoZSBSRE1TUiB2aWEgI1ZDLCB3aGljaCBjYW5ub3QgYmUgaGFuZGxlZCBh dCB0aGF0DQo+IHBvaW50IGluIGVhcmx5IHN0YXJ0dXAuDQo+IA0KPiBUaGVyZSB3YXMgYW4gZWFy bGllciB2YXJpYW50IGZvciBBTUQtU0VWIHdoaWNoIHVzZWQgdGhlIEdIQkMgcHJvdG9jb2wgZm9y DQo+IHJldHJpZXZpbmcgdGhlIEFQSUMgSUQgdmlhIENQVUlELCBidXQgdGhlcmUgaXMgbm8gZ3Vh cmFudGVlIHRoYXQgdGhlDQo+IGluaXRpYWwgQVBJQyBJRCBpbiBDUFVJRCBpcyB0aGUgc2FtZSBh cyB0aGUgcmVhbCBBUElDIElELiBUaGVyZSBpcyBubw0KPiBlbmZvcmNlbWVudCBmcm9tIHRoZSBz ZWN1cmUgZmlybXdhcmUgYW5kIHRoZSBoeXBlcnZpc29yIGNhbiBhc3NpZ24gQVBJQyBJRHMNCj4g YXMgaXQgc2VlcyBmaXQgYXMgbG9uZyBhcyB0aGUgQUNQSS9NQURUIHRhYmxlIGlzIGNvbnNpc3Rl bnQgd2l0aCB0aGF0DQo+IGFzc2lnbm1lbnQuDQo+IA0KPiBVbmZvcnR1bmF0ZWx5IHRoZXJlIGlz IG5vIFJETVNSIEdIQ0IgcHJvdG9jb2wgYXQgdGhlIG1vbWVudCwgc28gZW5hYmxpbmcNCj4gQU1E LVNFViBndWVzdHMgZm9yIHBhcmFsbGVsIHN0YXJ0dXAgbmVlZHMgc29tZSBtb3JlIHRob3VnaHQu DQo+IA0KPiBJbnRlbC1URFggcHJvdmlkZXMgYSBzZWN1cmUgUkRNU1IgaHlwZXJjYWxsLCBidXQg c3VwcG9ydGluZyB0aGF0IGlzIG91dHNpZGUNCj4gdGhlIHNjb3BlIG9mIHRoaXMgY2hhbmdlLg0K PiANCj4gRml4dXAgYW5ub3VuY2VfY3B1KCkgYXMgZS5nLiBvbiBIeXBlci1WIENQVTEgaXMgdGhl IHNlY29uZGFyeSBzaWJsaW5nIG9mDQo+IENQVTAsIHdoaWNoIG1ha2VzIHRoZSBAY3B1ID09IDEg bG9naWMgaW4gYW5ub3VuY2VfY3B1KCkgZmFsbCBhcGFydC4NCj4gDQo+IFsgbWlrZWxsZXk6IFJl cG9ydGVkIHRoZSBhbm5vdW5jZV9jcHUoKSBmYWxsb3V0DQo+IA0KPiBPcmlnaW5hbGx5LWJ5OiBE YXZpZCBXb29kaG91c2UgPGR3bXdAYW1hem9uLmNvLnVrPg0KPiBTaWduZWQtb2ZmLWJ5OiBUaG9t YXMgR2xlaXhuZXIgPHRnbHhAbGludXRyb25peC5kZT4NCj4gLS0tDQo+IFYyOiBGaXh1cCBhbm5v dW5jZV9jcHUoKSAtIE1pY2hhZWwgS2VsbGV5DQo+IC0tLQ0KPiAgYXJjaC94ODYvS2NvbmZpZyAg ICAgICAgICAgICB8ICAgIDMgKw0KPiAgYXJjaC94ODYva2VybmVsL2NwdS9jb21tb24uYyB8ICAg IDYgLS0tDQo+ICBhcmNoL3g4Ni9rZXJuZWwvc21wYm9vdC5jICAgIHwgICA4MyArKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKystLS0tDQo+IC0tLQ0KDQpbc25pcF0NCg0KPiBAQCAt OTM0LDEwICs5NjEsMTAgQEAgc3RhdGljIHZvaWQgYW5ub3VuY2VfY3B1KGludCBjcHUsIGludCBh cA0KPiAgCWlmICghbm9kZV93aWR0aCkNCj4gIAkJbm9kZV93aWR0aCA9IG51bV9kaWdpdHMobnVt X3Bvc3NpYmxlX25vZGVzKCkpICsgMTsgLyogKyAnIycgKi8NCj4gDQo+IC0JaWYgKGNwdSA9PSAx KQ0KPiAtCQlwcmludGsoS0VSTl9JTkZPICJ4ODY6IEJvb3RpbmcgU01QIGNvbmZpZ3VyYXRpb246 XG4iKTsNCj4gLQ0KPiAgCWlmIChzeXN0ZW1fc3RhdGUgPCBTWVNURU1fUlVOTklORykgew0KPiAr CQlpZiAobnVtX29ubGluZV9jcHVzKCkgPT0gMSkNCg0KVW5mb3J0dW5hdGVseSwgdGhpcyBuZXcg Y2hlY2sgZG9lc24ndCB3b3JrLiAgSGVyZSdzIHRoZSBvdXRwdXQgSSBnZXQ6DQoNClsgICAgMC43 MjEzODRdIHNtcDogQnJpbmdpbmcgdXAgc2Vjb25kYXJ5IENQVXMgLi4uDQpbICAgIDAuNzI1MzU5 XSBzbXBib290OiB4ODY6IEJvb3RpbmcgU01QIGNvbmZpZ3VyYXRpb246DQpbICAgIDAuNzI5MjQ5 XSAuLi4uIG5vZGUgICMwLCBDUFVzOiAgICAgICAgIzINClsgICAgMC43Mjk2NTRdIHNtcGJvb3Q6 IHg4NjogQm9vdGluZyBTTVAgY29uZmlndXJhdGlvbjoNClsgICAgMC43MzcyNDddICAgICAgICM0 DQpbICAgIDAuNzM3NTExXSBzbXBib290OiB4ODY6IEJvb3RpbmcgU01QIGNvbmZpZ3VyYXRpb246 DQpbICAgIDAuNzQxMjQ2XSAgICAgICAjNg0KWyAgICAwLjc0MTUwOF0gc21wYm9vdDogeDg2OiBC b290aW5nIFNNUCBjb25maWd1cmF0aW9uOg0KWyAgICAwLjc0NTI0OF0gICAgICAgIzgNClsgICAg MC43NDU1MDddIHNtcGJvb3Q6IHg4NjogQm9vdGluZyBTTVAgY29uZmlndXJhdGlvbjoNClsgICAg MC43NDkyNTBdICAgICAgIzEwDQpbICAgIDAuNzQ5NTE0XSBzbXBib290OiB4ODY6IEJvb3Rpbmcg U01QIGNvbmZpZ3VyYXRpb246DQpbICAgIDAuNzUzMjQ4XSAgICAgICMxMg0KWyAgICAwLjc1MzQ5 Ml0gc21wYm9vdDogeDg2OiBCb290aW5nIFNNUCBjb25maWd1cmF0aW9uOg0KWyAgICAwLjc1NzI0 OV0gICAgICAjMTQgICMxICAjMyAgIzUgICM3ICAjOSAjMTEgIzEzICMxNQ0KWyAgICAwLjc2OTMx N10gc21wOiBCcm91Z2h0IHVwIDEgbm9kZSwgMTYgQ1BVcw0KWyAgICAwLjc3MzI0Nl0gc21wYm9v dDogTWF4IGxvZ2ljYWwgcGFja2FnZXM6IDENClsgICAgMC43NzcyNTddIHNtcGJvb3Q6IFRvdGFs IG9mIDE2IHByb2Nlc3NvcnMgYWN0aXZhdGVkICg3ODI1My43OSBCb2dvTUlQUykNCg0KRXZpZGVu dGx5IG51bV9vbmxpbmVfY3B1cygpIGlzbid0IHVwZGF0ZWQgdW50aWwgYWZ0ZXIgYWxsIHRoZSBw cmltYXJ5DQpzaWJsaW5ncyBnZXQgc3RhcnRlZC4NCg0KV2hlbiBib290aW5nIHdpdGggY3B1aHAu cGFyYWxsZWw9MCwgdGhlIG91dHB1dCBpcyBnb29kLg0KDQpNaWNoYWVsDQoNCj4gKwkJCXByX2lu Zm8oIng4NjogQm9vdGluZyBTTVAgY29uZmlndXJhdGlvbjpcbiIpOw0KPiArDQo+ICAJCWlmIChu b2RlICE9IGN1cnJlbnRfbm9kZSkgew0KPiAgCQkJaWYgKGN1cnJlbnRfbm9kZSA+ICgtMSkpDQo+ ICAJCQkJcHJfY29udCgiXG4iKTsNCj4gQEAgLTk0OCw3ICs5NzUsNyBAQCBzdGF0aWMgdm9pZCBh bm5vdW5jZV9jcHUoaW50IGNwdSwgaW50IGFwDQo+ICAJCX0NCj4gDQo+ICAJCS8qIEFkZCBwYWRk aW5nIGZvciB0aGUgQlNQICovDQo+IC0JCWlmIChjcHUgPT0gMSkNCj4gKwkJaWYgKG51bV9vbmxp bmVfY3B1cygpID09IDEpDQo+ICAJCQlwcl9jb250KCIlKnMiLCB3aWR0aCArIDEsICIgIik7DQo+ IA0KPiAgCQlwcl9jb250KCIlKnMjJWQiLCB3aWR0aCAtIG51bV9kaWdpdHMoY3B1KSwgIiAiLCBj cHUpOw0K From xen-devel-bounces@lists.xenproject.org Sat May 06 01:13:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 May 2023 01:13:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530769.826517 (Exim 4.92) (envelope-from ) id 1pv6UP-0006LW-7p; Sat, 06 May 2023 01:13:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530769.826517; Sat, 06 May 2023 01:13:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pv6UP-0006LP-5G; Sat, 06 May 2023 01:13:33 +0000 Received: by outflank-mailman (input) for mailman id 530769; Sat, 06 May 2023 01:13:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pv6UO-0006LJ-1H for xen-devel@lists.xenproject.org; Sat, 06 May 2023 01:13:32 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 35f1d39d-ebab-11ed-b226-6b7b168915f2; Sat, 06 May 2023 03:13:30 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 316E4641D3; Sat, 6 May 2023 01:13:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 803CCC433D2; Sat, 6 May 2023 01:13:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 35f1d39d-ebab-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683335608; bh=kbfyCZ/OIOcwupFcFbstNbToCUDi6rMZBmq26a28eDA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=AdAbF1L56MX8vHqQ6MzWKJGRAbRAMP3R1IXMtemOzD2oN9rzpV3BZDxQr7u9YS4Of LZIB5myzBjj/w/uKDLFBKVDBSTxK9TRF5Q0arZk1rPDNQ4Xd7nqfWro5SdxegzDF/f qkGQU0GRkxngpXz3UmTh1pAgjmrC0dZL8QFUw9IRbSQ80c4F89MBiyeFt645FTgT9E 5mYfdiIkLhtesYcnxz37VWLPlPMpa4xMkwiWhhyZtdFTp2yHODj6E22PlQq/JN4vrU x6h7+WyyOtXQJZAv521wU6F2lXpPxHuH1N3vrf0iy/p2fq+gumzQMrplu9SrdfYrUQ +yvMevRdK6tvA== Date: Fri, 5 May 2023 18:13:25 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Mark Syms cc: qemu-devel@nongnu.org, sstabellini@kernel.org, anthony.perard@citrix.com, paul@xen.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH 0/1] Updated: Ensure PV ring is drained on disconenct In-Reply-To: <20230420102014.647446-1-mark.syms@citrix.com> Message-ID: References: <20230329105344.3465706-2-mark.syms@citrix.com> <20230420102014.647446-1-mark.syms@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 20 Apr 2023, Mark Syms wrote: > Updated patch to address intermittent SIGSEGV on domain disconnect/shutdown. > > Mark Syms (1): > Ensure the PV ring is drained on disconnect > > hw/block/dataplane/xen-block.c | 31 +++++++++++++++++++++++++------ > 1 file changed, 25 insertions(+), 6 deletions(-) > > -- > 2.40.0 > > >From 21724baa15a72534d98aa2653e9ec39e83559319 Mon Sep 17 00:00:00 2001 > From: Mark Syms > Date: Thu, 20 Apr 2023 11:08:34 +0100 > Subject: [PATCH 1/1] Ensure the PV ring is drained on disconnect > > Also ensure all pending AIO is complete. Hi Mark, can you please add more info on the problem you are trying to solve? Also add any stacktrace if you get any due to this error. > Signed-off-by: Mark Syms > --- > hw/block/dataplane/xen-block.c | 31 +++++++++++++++++++++++++------ > 1 file changed, 25 insertions(+), 6 deletions(-) > > diff --git a/hw/block/dataplane/xen-block.c b/hw/block/dataplane/xen-block.c > index 734da42ea7..d9da4090bf 100644 > --- a/hw/block/dataplane/xen-block.c > +++ b/hw/block/dataplane/xen-block.c > @@ -523,6 +523,10 @@ static bool xen_block_handle_requests(XenBlockDataPlane *dataplane) > > dataplane->more_work = 0; > > + if (dataplane->sring == 0) { > + return done_something; done_something cannot be changed by now, so I would just do return false; > + } > + > rc = dataplane->rings.common.req_cons; > rp = dataplane->rings.common.sring->req_prod; > xen_rmb(); /* Ensure we see queued requests up to 'rp'. */ > @@ -666,14 +670,35 @@ void xen_block_dataplane_destroy(XenBlockDataPlane *dataplane) > void xen_block_dataplane_stop(XenBlockDataPlane *dataplane) > { > XenDevice *xendev; > + XenBlockRequest *request, *next; > > if (!dataplane) { > return; > } > > + /* We're about to drain the ring. We can cancel the scheduling of any > + * bottom half now */ > + qemu_bh_cancel(dataplane->bh); > + > + /* Ensure we have drained the ring */ > + aio_context_acquire(dataplane->ctx); Would it make sense to move the 2 loops below under the existing aio_context_acquire also below? > + do { > + xen_block_handle_requests(dataplane); > + } while (dataplane->more_work); > + aio_context_release(dataplane->ctx); > + > + /* Now ensure that all inflight requests are complete */ > + while (!QLIST_EMPTY(&dataplane->inflight)) { > + QLIST_FOREACH_SAFE(request, &dataplane->inflight, list, next) { > + blk_aio_flush(request->dataplane->blk, xen_block_complete_aio, > + request); > + } > + } especially because I would think that blk_aio_flush needs to be called with aio_context_acquired ? > xendev = dataplane->xendev; > > aio_context_acquire(dataplane->ctx); > + move the new code here > if (dataplane->event_channel) { > /* Only reason for failure is a NULL channel */ > xen_device_set_event_channel_context(xendev, dataplane->event_channel, > @@ -684,12 +709,6 @@ void xen_block_dataplane_stop(XenBlockDataPlane *dataplane) > blk_set_aio_context(dataplane->blk, qemu_get_aio_context(), &error_abort); > aio_context_release(dataplane->ctx); > > - /* > - * Now that the context has been moved onto the main thread, cancel > - * further processing. > - */ > - qemu_bh_cancel(dataplane->bh); > - > if (dataplane->event_channel) { > Error *local_err = NULL; > > -- > 2.40.0 > From xen-devel-bounces@lists.xenproject.org Sat May 06 04:36:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 May 2023 04:36:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530804.826544 (Exim 4.92) (envelope-from ) id 1pv9f0-0002Zp-J3; Sat, 06 May 2023 04:36:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530804.826544; Sat, 06 May 2023 04:36:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pv9f0-0002Zi-FX; Sat, 06 May 2023 04:36:42 +0000 Received: by outflank-mailman (input) for mailman id 530804; Sat, 06 May 2023 04:36:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pv9ez-0002ZS-6l; Sat, 06 May 2023 04:36:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pv9ez-00033T-1g; Sat, 06 May 2023 04:36:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pv9ey-00078l-Hz; Sat, 06 May 2023 04:36:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pv9ey-0006ex-Gw; Sat, 06 May 2023 04:36:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Z7XMCM2W4HZR0TEuWoFJSBnV01a+YUyw0LPxBUDiDOs=; b=3D7agQYKaZZ4UNBW+B34ZJereG qroaAijTG9dNffxP07MwWp4BOTgNMRbnCONtZGWvzp+vrW631CgiWuHpO8WCVEeS/eEMNSU8f+qQU ihGGe4g4HDDRa5vSfWjOEmmnXir2gGbawAE5Ixtl1KTx2BMnioMW221eIM+OSXy6LRTk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 180546: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:windows-install:fail:heisenbug qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=a9fe9e191b4305b88c356a1ed9ac3baf89eb18aa X-Osstest-Versions-That: qemuu=f6b761bdbd8ba63cee7428d52fb6b46e4224ddab From: osstest service owner Date: Sat, 06 May 2023 04:36:40 +0000 flight 180546 qemu-mainline real [real] flight 180550 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180546/ http://logs.test-lab.xenproject.org/osstest/logs/180550/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-win7-amd64 12 windows-install fail pass in 180550-retest Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail in 180550 like 180536 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail like 180536 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 180536 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180536 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180536 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 180536 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 180536 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180536 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180536 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass version targeted for testing: qemuu a9fe9e191b4305b88c356a1ed9ac3baf89eb18aa baseline version: qemuu f6b761bdbd8ba63cee7428d52fb6b46e4224ddab Last test of basis 180536 2023-05-05 00:40:15 Z 1 days Testing same since 180546 2023-05-05 15:15:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alexandre Ghiti Alistair Francis Bin Meng Conor Dooley Daniel Henrique Barboza Fei Wu Irina Ryapolova Ivan Klokov Junqiang Wang LIU Zhiwei Mayuresh Chitale Philipp Tomsich Rahul Pathak Richard Henderson Weiwei Li Yi Chen jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git f6b761bdbd..a9fe9e191b a9fe9e191b4305b88c356a1ed9ac3baf89eb18aa -> upstream-tested From xen-devel-bounces@lists.xenproject.org Sat May 06 06:23:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 May 2023 06:23:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530812.826555 (Exim 4.92) (envelope-from ) id 1pvBKV-0005sJ-2G; Sat, 06 May 2023 06:23:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530812.826555; Sat, 06 May 2023 06:23:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvBKU-0005sC-V2; Sat, 06 May 2023 06:23:38 +0000 Received: by outflank-mailman (input) for mailman id 530812; Sat, 06 May 2023 06:23:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvBKU-0005s0-9V; Sat, 06 May 2023 06:23:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvBKT-0006pD-Cy; Sat, 06 May 2023 06:23:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvBKS-0001tB-Qs; Sat, 06 May 2023 06:23:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pvBKS-0006ss-QI; Sat, 06 May 2023 06:23:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vbP5B3N524j7AcPgLpPl9qdVs/36ZP1Nla6Fb2xdiss=; b=KSPxPeNZZ8mnN+4ZM6YkYE2AFT P/FQxDwQPVd6ktgpSoL60Br9cRqGK0IU7UhVFn9pr1ltupBByy3yzlF0qL+/VTNuTutHCV+vDYYbB kJiCVbxCcsz3t5pyCHvFqwVJQtESqwH8mHW4ZY9239wXDu5Km9fTb1m8HT33WDB570vY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180551: all pass - PUSHED X-Osstest-Versions-This: ovmf=eabaeb0613c0b459db950ab655f99ada9389d0cf X-Osstest-Versions-That: ovmf=b65c0eed6bc028388d790fe4e30a76770ebb46c4 From: osstest service owner Date: Sat, 06 May 2023 06:23:36 +0000 flight 180551 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180551/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf eabaeb0613c0b459db950ab655f99ada9389d0cf baseline version: ovmf b65c0eed6bc028388d790fe4e30a76770ebb46c4 Last test of basis 180545 2023-05-05 14:12:15 Z 0 days Testing same since 180551 2023-05-06 04:10:42 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Gerd Hoffmann jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git b65c0eed6b..eabaeb0613 eabaeb0613c0b459db950ab655f99ada9389d0cf -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat May 06 06:51:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 May 2023 06:51:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530818.826565 (Exim 4.92) (envelope-from ) id 1pvBle-00011k-8v; Sat, 06 May 2023 06:51:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530818.826565; Sat, 06 May 2023 06:51:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvBle-00011d-60; Sat, 06 May 2023 06:51:42 +0000 Received: by outflank-mailman (input) for mailman id 530818; Sat, 06 May 2023 06:51:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvBlc-00011S-Q3 for xen-devel@lists.xenproject.org; Sat, 06 May 2023 06:51:40 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0606.outbound.protection.outlook.com [2a01:111:f400:fe0c::606]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 70754649-ebda-11ed-8611-37d641c3527e; Sat, 06 May 2023 08:51:36 +0200 (CEST) Received: from AM5PR0201CA0005.eurprd02.prod.outlook.com (2603:10a6:203:3d::15) by DBBPR08MB6091.eurprd08.prod.outlook.com (2603:10a6:10:1f4::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.29; Sat, 6 May 2023 06:51:28 +0000 Received: from AM7EUR03FT011.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:3d:cafe::ea) by AM5PR0201CA0005.outlook.office365.com (2603:10a6:203:3d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.29 via Frontend Transport; Sat, 6 May 2023 06:51:28 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT011.mail.protection.outlook.com (100.127.140.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.12 via Frontend Transport; Sat, 6 May 2023 06:51:27 +0000 Received: ("Tessian outbound 8b05220b4215:v136"); Sat, 06 May 2023 06:51:27 +0000 Received: from 67331670f6fd.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B0709909-C424-4563-9817-60DCB1B43D7A.1; Sat, 06 May 2023 06:51:21 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 67331670f6fd.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sat, 06 May 2023 06:51:21 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by AS8PR08MB7744.eurprd08.prod.outlook.com (2603:10a6:20b:508::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.29; Sat, 6 May 2023 06:51:18 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::bce1:f206:86af:31be]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::bce1:f206:86af:31be%6]) with mapi id 15.20.6363.029; Sat, 6 May 2023 06:51:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 70754649-ebda-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mVyhQTvLKKOubA6U89Gm0zkMBBxJJEVKwnYtVKMTve0=; b=eNTxJo0yuJaMfu4c0QlMvY8ODb3fzzGuyz2IRTpXd9INvjl0oTStIydtUyIXgH82yWgQyFAr246gkn93msU/sTetUD/+am2/E7DQ/oW8OjyXlikigI7HRhXea+36A1k8gBnFvLJHnyZQtA4ni09rqp2YYuLFgsVg4mvqfGYml6s= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: b26a26440f20b42d X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=grr97IDhQhDq7Cu1TiCy+vt8VtHmScGWTNrvAV14xsq2wrVq5bHYu9FNxfe+YBUiMdDMgcctMve8ELIuyxVPU+yVynQ0kpNY3z7/yEqdib1c+3cIZvN8hNkxZy5TpzZq3CQKuxNTodQ4HsneMv5UDhzP7jnusQ9buu6cYJD1Z7Nj2sxTXUIhgRekYmxP5Rqj8Wr8SiOrXyo5PXuvsEoOcH2aTIJjyHJ45lpFfYtX5Hzp3qsSz3luqH/RHwWK3KxkldXRGjd78YhSsZxeGXkLKMX6+8a9/sqkFotRhkgcbaF6LRQV9L/b6tkwZpEY96brwGWe6jz2v33j054aNISmZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mVyhQTvLKKOubA6U89Gm0zkMBBxJJEVKwnYtVKMTve0=; b=UQU9cnvjdMF2cDYT3Oqj/U3tS3tFsuwFAFewLNZk2RF/y/5/4LNrwVU2QJl3WSRrRnVg7JLdFk7r3JjoxXsWMFD4MvSaR49hzm0YIMoVRdOkzBNV3j8Y7d5V5mHlkW00E1D4rv2IEP14nvmNuXAjXbMuLgvUVHn32nOyrvVL33TimoAhk7udlIbrZ10Aq+NxucgKQZO9Pk1oiFAXrbppe9QXE7soBtDTVvE1w9jLzAT6wAt7zwfaZ48Q+UHpH+il19l6ZrbPNy7TPWEr+cQmGlnYPLa+CrfOPZXoChsKw4n0tzRQBK2Ce21VVz5mWmgvzAUgbPdSA6xSQGKwxTPH4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mVyhQTvLKKOubA6U89Gm0zkMBBxJJEVKwnYtVKMTve0=; b=eNTxJo0yuJaMfu4c0QlMvY8ODb3fzzGuyz2IRTpXd9INvjl0oTStIydtUyIXgH82yWgQyFAr246gkn93msU/sTetUD/+am2/E7DQ/oW8OjyXlikigI7HRhXea+36A1k8gBnFvLJHnyZQtA4ni09rqp2YYuLFgsVg4mvqfGYml6s= From: Luca Fancellu To: Xen-devel CC: Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH 1/2] xen/misra: add diff-report.py tool Thread-Topic: [PATCH 1/2] xen/misra: add diff-report.py tool Thread-Index: AQHZfpRaHhveqUOI3U+Goaz/TE5FAK9M0RwA Date: Sat, 6 May 2023 06:51:18 +0000 Message-ID: References: <20230504142523.2989306-1-luca.fancellu@arm.com> <20230504142523.2989306-2-luca.fancellu@arm.com> In-Reply-To: <20230504142523.2989306-2-luca.fancellu@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.500.231) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|AS8PR08MB7744:EE_|AM7EUR03FT011:EE_|DBBPR08MB6091:EE_ X-MS-Office365-Filtering-Correlation-Id: 8bbe4589-4068-4e37-18e0-08db4dfe5101 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: AP735fWgScDxGpOa8A4s/RsZrSnO4XB5XaXFsKI6KEICJrgsXXelV0UafaZxDdO9W6pBkOnS8R8KGjajMM/JwtBw4NCO/mdHTT0e8NlqWKH0eIuwr8Ur2rc5g/cO1SAmMeEwGBueMuCEzhSgF67Rj0s47qyNJ6pX2r8ioUhDNana7Vjpco1oxWzrbT+XI6cS7KeMqomgUIzKmiPtkqKNcBR2QhhYjE4PEc3iFGjWlBlSWt1IxcVNUFklNYToNkdo65+JBwAFsw5h8p9JxQzzPCefSqtQyGIlB/4u0LyUSc5FpsG3V3UBM54ZFNJlQEJSrOmPFQr8rNQJW/me9fohyq1G/ubk5gHPX+8XvDVGVO934p25OlmT7/K2Ki08i9HXDQCf9edNcEUsEh6HG7s9RWgOjZeP2uRhMz97M1ZL6WyMqQiIV/TBfGZ1yQPxxHws5kGJ4NoguNXhg5cvCELK2JwtHHkaqr6nFt9G69KrbV5Ds48/bj76tDQYkaKOADzeqdP8vaJ6uc3+zlYxEXFjpVSJWfCHU2Y9vlRHAOILBCbCujTWrcvtjpdeuVPH/lVV4fbMJgyOhewk07yCrCy1CK5OBGTGgBlYbW13/2Bx+fb73aGEULfH5dFiVaNj7TAYUwRPy9iWWt1U6avMtN6Nvw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(366004)(376002)(39860400002)(451199021)(53546011)(6512007)(6506007)(26005)(8676002)(8936002)(2616005)(30864003)(5660300002)(186003)(316002)(54906003)(66946007)(66556008)(66476007)(66446008)(64756008)(76116006)(91956017)(6916009)(4326008)(41300700001)(6486002)(478600001)(71200400001)(122000001)(38100700002)(86362001)(36756003)(33656002)(38070700005)(83380400001)(2906002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7744 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0c019ed6-69ab-475e-f43d-08db4dfe4b71 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ov6R0R6K6P1kbBStindOJ1QDCowARXVnoackpEcrBEQWjDCsZTcd55kKw+tRbLeM4wcnHmlp1fFgv9DAkoTdFyt8fIRjg1GavK8VlRxM6T70q+VZXV2K6DMpooEZDIWsVrwbjY+fLsdRf2g2gp5sUhWAXxXEQXxKd+S3Yt14CNRIWZb/iGtMsCMheW6QYU2ajw0LiMialvhAwBdWebcPadS2MU0UnH8eRTI5nMw4MqvHMIzBh8F5uIu2q+OM85b/rKoizojeChvAFfiREKNesi0pyApzh6LXRZyNdzq5Jik7yUlvX8rXtzPMoCL1KEYKOuqq7NVcVeqLBMEVnB0FAg5uvJtC3CbpmVPPLcYRAO4x/A/NGiiAxWLpK43iqquVxMYEGuJISSmPccqyy5eHVL2LfigwGZ6s50y79ShS6G10Qb60CgdOb6XLX3PaapzzMgCPAJ+LMMqyhndFbs7cfjdKSi4jZfd/EUnDxfAmz5EEQqBqw8o0n3NCJtRjbQTY/g6+arM4mvhTMkkLizjwHKHEJroHAD0EK5qGE6OxamXkh1Ge/XnpMLR8viF65MeRsRdQFHZ4Z7JT9y23YKk5gs2UMklHW2ym5RjRBb42oOYxBGsgdTnRc5dX4FAkBGYIbDtgMh23m1N0Lpsv/j6DhF9YfNjS0P057WLVQsZduxj5uQPpP6TzBvTGB3a6uUsjaKiyxGmA9RYK+VktaPr4Wg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(39860400002)(376002)(396003)(136003)(451199021)(36840700001)(46966006)(40470700004)(36860700001)(33656002)(36756003)(40460700003)(2906002)(30864003)(8676002)(8936002)(5660300002)(86362001)(40480700001)(316002)(70206006)(70586007)(4326008)(82310400005)(41300700001)(6916009)(82740400003)(81166007)(356005)(47076005)(336012)(83380400001)(54906003)(186003)(6512007)(6506007)(26005)(53546011)(6486002)(478600001)(2616005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2023 06:51:27.8334 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8bbe4589-4068-4e37-18e0-08db4dfe5101 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6091 DQoNCj4gT24gNCBNYXkgMjAyMywgYXQgMTU6MjUsIEx1Y2EgRmFuY2VsbHUgPEx1Y2EuRmFuY2Vs bHVAYXJtLmNvbT4gd3JvdGU6DQo+IA0KPiBBZGQgYSBuZXcgdG9vbCwgZGlmZi1yZXBvcnQucHkg dGhhdCBjYW4gYmUgdXNlZCB0byBtYWtlIGRpZmYgYmV0d2Vlbg0KPiByZXBvcnRzIGdlbmVyYXRl ZCBieSB4ZW4tYW5hbHlzaXMucHkgdG9vbC4NCj4gQ3VycmVudGx5IHRoaXMgdG9vbCBzdXBwb3J0 cyB0aGUgWGVuIGNwcGNoZWNrIHRleHQgcmVwb3J0IGZvcm1hdCBpbg0KPiBpdHMgb3BlcmF0aW9u cy4NCj4gDQo+IFRoZSB0b29sIHByaW50cyBldmVyeSBmaW5kaW5nIHRoYXQgaXMgaW4gdGhlIHJl cG9ydCBwYXNzZWQgd2l0aCAtcg0KPiAoY2hlY2sgcmVwb3J0KSB3aGljaCBpcyBub3QgaW4gdGhl IHJlcG9ydCBwYXNzZWQgd2l0aCAtYiAoYmFzZWxpbmUpLg0KPiANCj4gU2lnbmVkLW9mZi1ieTog THVjYSBGYW5jZWxsdSA8bHVjYS5mYW5jZWxsdUBhcm0uY29tPg0KPiAtLS0NCj4geGVuL3Njcmlw dHMvZGlmZi1yZXBvcnQucHkgICAgICAgICAgICAgICAgICAgIHwgIDc2ICsrKysrKysrKysrKw0K PiAuLi4veGVuX2FuYWx5c2lzL2RpZmZfdG9vbC9fX2luaXRfXy5weSAgICAgICAgfCAgIDANCj4g Li4uL3hlbl9hbmFseXNpcy9kaWZmX3Rvb2wvY3BwY2hlY2tfcmVwb3J0LnB5IHwgIDQxICsrKysr KysNCj4geGVuL3NjcmlwdHMveGVuX2FuYWx5c2lzL2RpZmZfdG9vbC9kZWJ1Zy5weSAgIHwgIDM2 ICsrKysrKw0KPiB4ZW4vc2NyaXB0cy94ZW5fYW5hbHlzaXMvZGlmZl90b29sL3JlcG9ydC5weSAg fCAxMTQgKysrKysrKysrKysrKysrKysrDQo+IDUgZmlsZXMgY2hhbmdlZCwgMjY3IGluc2VydGlv bnMoKykNCj4gY3JlYXRlIG1vZGUgMTAwNzU1IHhlbi9zY3JpcHRzL2RpZmYtcmVwb3J0LnB5DQo+ IGNyZWF0ZSBtb2RlIDEwMDY0NCB4ZW4vc2NyaXB0cy94ZW5fYW5hbHlzaXMvZGlmZl90b29sL19f aW5pdF9fLnB5DQo+IGNyZWF0ZSBtb2RlIDEwMDY0NCB4ZW4vc2NyaXB0cy94ZW5fYW5hbHlzaXMv ZGlmZl90b29sL2NwcGNoZWNrX3JlcG9ydC5weQ0KPiBjcmVhdGUgbW9kZSAxMDA2NDQgeGVuL3Nj cmlwdHMveGVuX2FuYWx5c2lzL2RpZmZfdG9vbC9kZWJ1Zy5weQ0KPiBjcmVhdGUgbW9kZSAxMDA2 NDQgeGVuL3NjcmlwdHMveGVuX2FuYWx5c2lzL2RpZmZfdG9vbC9yZXBvcnQucHkNCj4gDQo+IGRp ZmYgLS1naXQgYS94ZW4vc2NyaXB0cy9kaWZmLXJlcG9ydC5weSBiL3hlbi9zY3JpcHRzL2RpZmYt cmVwb3J0LnB5DQo+IG5ldyBmaWxlIG1vZGUgMTAwNzU1DQo+IGluZGV4IDAwMDAwMDAwMDAwMC4u NDkxM2ZiNDNhOGY5DQo+IC0tLSAvZGV2L251bGwNCj4gKysrIGIveGVuL3NjcmlwdHMvZGlmZi1y ZXBvcnQucHkNCj4gQEAgLTAsMCArMSw3NiBAQA0KPiArIyEvdXNyL2Jpbi9lbnYgcHl0aG9uMw0K PiArDQo+ICtpbXBvcnQgb3MsIHN5cw0KPiArZnJvbSBhcmdwYXJzZSBpbXBvcnQgQXJndW1lbnRQ YXJzZXINCj4gK2Zyb20geGVuX2FuYWx5c2lzLmRpZmZfdG9vbC5kZWJ1ZyBpbXBvcnQgRGVidWcN Cj4gK2Zyb20geGVuX2FuYWx5c2lzLmRpZmZfdG9vbC5yZXBvcnQgaW1wb3J0IFJlcG9ydEVycm9y DQo+ICtmcm9tIHhlbl9hbmFseXNpcy5kaWZmX3Rvb2wuY3BwY2hlY2tfcmVwb3J0IGltcG9ydCBD cHBjaGVja1JlcG9ydA0KPiArDQo+ICsNCj4gK2RlZiBsb2dfaW5mbyh0ZXh0LCBlbmQ9J1xuJyk6 DQo+ICsgICAgZ2xvYmFsIGFyZ3MNCj4gKyAgICBnbG9iYWwgZmlsZV9vdXQNCj4gKw0KPiArICAg IGlmIChhcmdzLnZlcmJvc2UpOg0KPiArICAgICAgICBwcmludCh0ZXh0LCBlbmQ9ZW5kLCBmaWxl PWZpbGVfb3V0KQ0KPiArDQo+ICsNCj4gK2RlZiBtYWluKGFyZ3YpOg0KPiArICAgIGdsb2JhbCBh cmdzDQo+ICsgICAgZ2xvYmFsIGZpbGVfb3V0DQo+ICsNCj4gKyAgICBwYXJzZXIgPSBBcmd1bWVu dFBhcnNlcihwcm9nPSJkaWZmLXJlcG9ydC5weSIpDQo+ICsgICAgcGFyc2VyLmFkZF9hcmd1bWVu dCgiLWIiLCAiLS1iYXNlbGluZSIsIHJlcXVpcmVkPVRydWUsIHR5cGU9c3RyLA0KPiArICAgICAg ICAgICAgICAgICAgICAgICAgaGVscD0iUGF0aCB0byB0aGUgYmFzZWxpbmUgcmVwb3J0LiIpDQo+ ICsgICAgcGFyc2VyLmFkZF9hcmd1bWVudCgiLS1kZWJ1ZyIsIGFjdGlvbj0nc3RvcmVfdHJ1ZScs DQo+ICsgICAgICAgICAgICAgICAgICAgICAgICBoZWxwPSJQcm9kdWNlIGludGVybWVkaWF0ZSBy ZXBvcnRzIGR1cmluZyBvcGVyYXRpb25zLiIpDQo+ICsgICAgcGFyc2VyLmFkZF9hcmd1bWVudCgi LW8iLCAiLS1vdXQiLCBkZWZhdWx0PSJzdGRvdXQiLCB0eXBlPXN0ciwNCj4gKyAgICAgICAgICAg ICAgICAgICAgICAgIGhlbHA9IldoZXJlIHRvIHByaW50IHRoZSB0b29sIG91dHB1dC4gRGVmYXVs dCBpcyAiDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJzdGRvdXQiKQ0KPiArICAg IHBhcnNlci5hZGRfYXJndW1lbnQoIi1yIiwgIi0tcmVwb3J0IiwgcmVxdWlyZWQ9VHJ1ZSwgdHlw ZT1zdHIsDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICBoZWxwPSJQYXRoIHRvIHRoZSAnY2hl Y2sgcmVwb3J0JywgdGhlIG9uZSBjaGVja2VkICINCj4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgImFnYWluc3QgdGhlIGJhc2VsaW5lLiIpDQo+ICsgICAgcGFyc2VyLmFkZF9hcmd1bWVu dCgiLXYiLCAiLS12ZXJib3NlIiwgYWN0aW9uPSdzdG9yZV90cnVlJywNCj4gKyAgICAgICAgICAg ICAgICAgICAgICAgIGhlbHA9IlByaW50IG1vcmUgaW5mb3JtYXRpb25zIGR1cmluZyB0aGUgcnVu LiIpDQo+ICsNCj4gKyAgICBhcmdzID0gcGFyc2VyLnBhcnNlX2FyZ3MoKQ0KPiArDQo+ICsgICAg aWYgYXJncy5vdXQgPT0gInN0ZG91dCI6DQo+ICsgICAgICAgIGZpbGVfb3V0ID0gc3lzLnN0ZG91 dA0KPiArICAgIGVsc2U6DQo+ICsgICAgICAgIHRyeToNCj4gKyAgICAgICAgICAgIGZpbGVfb3V0 ID0gb3BlbihhcmdzLm91dCwgInd0IikNCj4gKyAgICAgICAgZXhjZXB0IE9TRXJyb3IgYXMgZToN Cj4gKyAgICAgICAgICAgIHByaW50KCJFUlJPUjogSXNzdWUgb3BlbmluZyBmaWxlIHt9OiB7fSIu Zm9ybWF0KGFyZ3Mub3V0LCBlKSkNCj4gKyAgICAgICAgICAgIHN5cy5leGl0KDEpDQo+ICsNCj4g KyAgICBkZWJ1ZyA9IERlYnVnKGFyZ3MpDQo+ICsNCj4gKyAgICB0cnk6DQo+ICsgICAgICAgIGJh c2VsaW5lX3BhdGggPSBvcy5wYXRoLnJlYWxwYXRoKGFyZ3MuYmFzZWxpbmUpDQo+ICsgICAgICAg IGxvZ19pbmZvKCJMb2FkaW5nIGJhc2VsaW5lIHJlcG9ydCB7fSIuZm9ybWF0KGJhc2VsaW5lX3Bh dGgpLCAiIikNCj4gKyAgICAgICAgYmFzZWxpbmUgPSBDcHBjaGVja1JlcG9ydChiYXNlbGluZV9w YXRoKQ0KPiArICAgICAgICBiYXNlbGluZS5wYXJzZSgpDQo+ICsgICAgICAgIGRlYnVnLmRlYnVn X3ByaW50X3BhcnNlZF9yZXBvcnQoYmFzZWxpbmUpDQo+ICsgICAgICAgIGxvZ19pbmZvKCIgW09L XSIpDQo+ICsgICAgICAgIG5ld19yZXBfcGF0aCA9IG9zLnBhdGgucmVhbHBhdGgoYXJncy5yZXBv cnQpDQo+ICsgICAgICAgIGxvZ19pbmZvKCJMb2FkaW5nIGNoZWNrIHJlcG9ydCB7fSIuZm9ybWF0 KG5ld19yZXBfcGF0aCksICIiKQ0KPiArICAgICAgICBuZXdfcmVwID0gQ3BwY2hlY2tSZXBvcnQo bmV3X3JlcF9wYXRoKQ0KPiArICAgICAgICBuZXdfcmVwLnBhcnNlKCkNCj4gKyAgICAgICAgZGVi dWcuZGVidWdfcHJpbnRfcGFyc2VkX3JlcG9ydChuZXdfcmVwKQ0KPiArICAgICAgICBsb2dfaW5m bygiIFtPS10iKQ0KPiArICAgIGV4Y2VwdCBSZXBvcnRFcnJvciBhcyBlOg0KPiArICAgICAgICBw cmludCgiRVJST1I6IHt9Ii5mb3JtYXQoZSkpDQo+ICsgICAgICAgIHN5cy5leGl0KDEpDQo+ICsN Cj4gKyAgICBvdXRwdXQgPSBuZXdfcmVwIC0gYmFzZWxpbmUNCj4gKyAgICBwcmludChvdXRwdXQs IGVuZD0iIiwgZmlsZT1maWxlX291dCkNCj4gKw0KPiArICAgIGlmIGxlbihvdXRwdXQpID4gMDoN Cj4gKyAgICAgICAgc3lzLmV4aXQoMSkNCj4gKw0KPiArICAgIHN5cy5leGl0KDApDQo+ICsNCj4g Kw0KPiAraWYgX19uYW1lX18gPT0gIl9fbWFpbl9fIjoNCj4gKyAgICBtYWluKHN5cy5hcmd2WzE6 XSkNCj4gZGlmZiAtLWdpdCBhL3hlbi9zY3JpcHRzL3hlbl9hbmFseXNpcy9kaWZmX3Rvb2wvX19p bml0X18ucHkgYi94ZW4vc2NyaXB0cy94ZW5fYW5hbHlzaXMvZGlmZl90b29sL19faW5pdF9fLnB5 DQo+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0DQo+IGluZGV4IDAwMDAwMDAwMDAwMC4uZTY5ZGUyOWJi MmQxDQo+IGRpZmYgLS1naXQgYS94ZW4vc2NyaXB0cy94ZW5fYW5hbHlzaXMvZGlmZl90b29sL2Nw cGNoZWNrX3JlcG9ydC5weSBiL3hlbi9zY3JpcHRzL3hlbl9hbmFseXNpcy9kaWZmX3Rvb2wvY3Bw Y2hlY2tfcmVwb3J0LnB5DQo+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0DQo+IGluZGV4IDAwMDAwMDAw MDAwMC4uNzg3YTUxYWNhNTgzDQo+IC0tLSAvZGV2L251bGwNCj4gKysrIGIveGVuL3NjcmlwdHMv eGVuX2FuYWx5c2lzL2RpZmZfdG9vbC9jcHBjaGVja19yZXBvcnQucHkNCj4gQEAgLTAsMCArMSw0 MSBAQA0KPiArIyEvdXNyL2Jpbi9lbnYgcHl0aG9uMw0KPiArDQo+ICtpbXBvcnQgcmUNCj4gK2Zy b20gLnJlcG9ydCBpbXBvcnQgUmVwb3J0LCBSZXBvcnRFcnJvcg0KPiArDQo+ICsNCj4gK2NsYXNz IENwcGNoZWNrUmVwb3J0KFJlcG9ydCk6DQo+ICsgICAgZGVmIF9faW5pdF9fKHNlbGYsIHJlcG9y dF9wYXRoOiBzdHIpIC0+IE5vbmU6DQo+ICsgICAgICAgIHN1cGVyKCkuX19pbml0X18ocmVwb3J0 X3BhdGgpDQo+ICsgICAgICAgICMgVGhpcyBtYXRjaGVzIGEgc3RyaW5nIGxpa2U6DQo+ICsgICAg ICAgICMgcGF0aC90by9maWxlLmMoPGxpbmUgbnVtYmVyPiw8ZGlnaXRzPik6PHdoYXRldmVyPg0K PiArICAgICAgICAjIGFuZCBjYXB0dXJlcyBmaWxlIG5hbWUgcGF0aCBhbmQgbGluZSBudW1iZXIN Cj4gKyAgICAgICAgIyB0aGUgbGFzdCBjYXB0dXJlIGdyb3VwIGlzIHVzZWQgZm9yIHRleHQgc3Vi c3RpdHV0aW9uIGluIF9fc3RyX18NCj4gKyAgICAgICAgc2VsZi5fX3JlcG9ydF9lbnRyeV9yZWdl eCA9IHJlLmNvbXBpbGUocideKC4qKVwoKFxkKykoLFxkK1wpOi4qKSQnKQ0KPiArDQo+ICsgICAg ZGVmIHBhcnNlKHNlbGYpIC0+IE5vbmU6DQo+ICsgICAgICAgIHJlcG9ydF9wYXRoID0gc2VsZi5n ZXRfcmVwb3J0X3BhdGgoKQ0KPiArICAgICAgICB0cnk6DQo+ICsgICAgICAgICAgICB3aXRoIG9w ZW4ocmVwb3J0X3BhdGgsICJydCIpIGFzIGluZmlsZToNCj4gKyAgICAgICAgICAgICAgICByZXBv cnRfbGluZXMgPSBpbmZpbGUucmVhZGxpbmVzKCkNCj4gKyAgICAgICAgZXhjZXB0IE9TRXJyb3Ig YXMgZToNCj4gKyAgICAgICAgICAgIHJhaXNlIFJlcG9ydEVycm9yKCJJc3N1ZSB3aXRoIHJlYWRp bmcgZmlsZSB7fToge30iDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAuZm9ybWF0 KHJlcG9ydF9wYXRoLCBlKSkNCj4gKyAgICAgICAgZm9yIGxpbmUgaW4gcmVwb3J0X2xpbmVzOg0K PiArICAgICAgICAgICAgZW50cnkgPSBzZWxmLl9fcmVwb3J0X2VudHJ5X3JlZ2V4Lm1hdGNoKGxp bmUpDQo+ICsgICAgICAgICAgICBpZiBlbnRyeSBhbmQgZW50cnkuZ3JvdXAoMSkgYW5kIGVudHJ5 Lmdyb3VwKDIpOg0KPiArICAgICAgICAgICAgICAgIGZpbGVfcGF0aCA9IGVudHJ5Lmdyb3VwKDEp DQo+ICsgICAgICAgICAgICAgICAgbGluZV9udW1iZXIgPSBpbnQoZW50cnkuZ3JvdXAoMikpDQo+ ICsgICAgICAgICAgICAgICAgc2VsZi5hZGRfZW50cnkoZmlsZV9wYXRoLCBsaW5lX251bWJlciwg bGluZSkNCj4gKyAgICAgICAgICAgIGVsc2U6DQo+ICsgICAgICAgICAgICAgICAgcmFpc2UgUmVw b3J0RXJyb3IoIk1hbGZvcm1lZCByZXBvcnQgZW50cnkgaW4gZmlsZSB7fTpcbnt9Ig0KPiArICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC5mb3JtYXQocmVwb3J0X3BhdGgsIGxpbmUp KQ0KPiArDQo+ICsgICAgZGVmIF9fc3RyX18oc2VsZikgLT4gc3RyOg0KPiArICAgICAgICByZXQg PSAiIg0KPiArICAgICAgICBmb3IgZW50cnkgaW4gc2VsZi50b19saXN0KCk6DQo+ICsgICAgICAg ICAgICByZXQgKz0gcmUuc3ViKHNlbGYuX19yZXBvcnRfZW50cnlfcmVnZXgsDQo+ICsgICAgICAg ICAgICAgICAgICAgICAgICAgIHIne30oe31cMycuZm9ybWF0KGVudHJ5LmZpbGVfcGF0aCwNCj4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZW50cnkubGluZV9u dW1iZXIpLA0KPiArICAgICAgICAgICAgICAgICAgICAgICAgICBlbnRyeS50ZXh0KQ0KPiArICAg ICAgICByZXR1cm4gcmV0DQo+IGRpZmYgLS1naXQgYS94ZW4vc2NyaXB0cy94ZW5fYW5hbHlzaXMv ZGlmZl90b29sL2RlYnVnLnB5IGIveGVuL3NjcmlwdHMveGVuX2FuYWx5c2lzL2RpZmZfdG9vbC9k ZWJ1Zy5weQ0KPiBuZXcgZmlsZSBtb2RlIDEwMDY0NA0KPiBpbmRleCAwMDAwMDAwMDAwMDAuLmQ0 NmRmMzMwMGQyMQ0KPiAtLS0gL2Rldi9udWxsDQo+ICsrKyBiL3hlbi9zY3JpcHRzL3hlbl9hbmFs eXNpcy9kaWZmX3Rvb2wvZGVidWcucHkNCj4gQEAgLTAsMCArMSwzNiBAQA0KPiArIyEvdXNyL2Jp bi9lbnYgcHl0aG9uMw0KPiArDQo+ICtpbXBvcnQgb3MNCj4gK2Zyb20gLnJlcG9ydCBpbXBvcnQg UmVwb3J0DQo+ICsNCj4gKw0KPiArY2xhc3MgRGVidWc6DQo+ICsgICAgZGVmIF9faW5pdF9fKHNl bGYsIGFyZ3MpOg0KPiArICAgICAgICBzZWxmLmFyZ3MgPSBhcmdzDQo+ICsNCj4gKyAgICBkZWYg X19nZXRfZGVidWdfb3V0X2ZpbGVuYW1lKHNlbGYsIHBhdGg6IHN0ciwgdHlwZTogc3RyKSAtPiBz dHI6DQo+ICsgICAgICAgICMgVGFrZSBiYXNlbmFtZQ0KPiArICAgICAgICBmaWxlX25hbWUgPSBv cy5wYXRoLmJhc2VuYW1lKHBhdGgpDQo+ICsgICAgICAgICMgU3BsaXQgaW4gbmFtZSBhbmQgZXh0 ZW5zaW9uDQo+ICsgICAgICAgIGZpbGVfbmFtZSA9IG9zLnBhdGguc3BsaXRleHQoZmlsZV9uYW1l KQ0KPiArICAgICAgICBpZiBzZWxmLmFyZ3Mub3V0ICE9ICJzdGRvdXQiOg0KPiArICAgICAgICAg ICAgb3V0X2ZvbGRlciA9IG9zLnBhdGguZGlybmFtZShzZWxmLmFyZ3Mub3V0KQ0KPiArICAgICAg ICBlbHNlOg0KPiArICAgICAgICAgICAgb3V0X2ZvbGRlciA9ICIuLyINCj4gKyAgICAgICAgZGJn X3JlcG9ydF9wYXRoID0gb3V0X2ZvbGRlciArIGZpbGVfbmFtZVswXSArIHR5cGUgKyBmaWxlX25h bWVbMV0NCj4gKw0KPiArICAgICAgICByZXR1cm4gZGJnX3JlcG9ydF9wYXRoDQo+ICsNCj4gKyAg ICBkZWYgX19kZWJ1Z19wcmludF9yZXBvcnQoc2VsZiwgcmVwb3J0OiBSZXBvcnQsIHR5cGU6IHN0 cikgLT4gTm9uZToNCj4gKyAgICAgICAgcmVwb3J0X25hbWUgPSBzZWxmLl9fZ2V0X2RlYnVnX291 dF9maWxlbmFtZShyZXBvcnQuZ2V0X3JlcG9ydF9wYXRoKCksDQo+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdHlwZSkNCj4gKyAgICAgICAgdHJ5 Og0KPiArICAgICAgICAgICAgd2l0aCBvcGVuKHJlcG9ydF9uYW1lLCAid3QiKSBhcyBvdXRmaWxl Og0KPiArICAgICAgICAgICAgICAgIHByaW50KHJlcG9ydCwgZW5kPSIiLCBmaWxlPW91dGZpbGUp DQo+ICsgICAgICAgIGV4Y2VwdCBPU0Vycm9yIGFzIGU6DQo+ICsgICAgICAgICAgICBwcmludCgi RVJST1I6IElzc3VlIG9wZW5pbmcgZmlsZSB7fToge30iLmZvcm1hdChyZXBvcnRfbmFtZSwgZSkp DQo+ICsNCj4gKyAgICBkZWYgZGVidWdfcHJpbnRfcGFyc2VkX3JlcG9ydChzZWxmLCByZXBvcnQ6 IFJlcG9ydCkgLT4gTm9uZToNCj4gKyAgICAgICAgaWYgbm90IHNlbGYuYXJncy5kZWJ1ZzoNCj4g KyAgICAgICAgICAgIHJldHVybg0KPiArICAgICAgICBzZWxmLl9fZGVidWdfcHJpbnRfcmVwb3J0 KHJlcG9ydCwgIi5wYXJzZWQiKQ0KPiBkaWZmIC0tZ2l0IGEveGVuL3NjcmlwdHMveGVuX2FuYWx5 c2lzL2RpZmZfdG9vbC9yZXBvcnQucHkgYi94ZW4vc2NyaXB0cy94ZW5fYW5hbHlzaXMvZGlmZl90 b29sL3JlcG9ydC5weQ0KPiBuZXcgZmlsZSBtb2RlIDEwMDY0NA0KPiBpbmRleCAwMDAwMDAwMDAw MDAuLmQ5NThkMTgxNmViNA0KPiAtLS0gL2Rldi9udWxsDQo+ICsrKyBiL3hlbi9zY3JpcHRzL3hl bl9hbmFseXNpcy9kaWZmX3Rvb2wvcmVwb3J0LnB5DQo+IEBAIC0wLDAgKzEsMTE0IEBADQo+ICsj IS91c3IvYmluL2VudiBweXRob24zDQo+ICsNCj4gK2ltcG9ydCBvcw0KPiArDQo+ICsNCj4gK2Ns YXNzIFJlcG9ydEVycm9yKEV4Y2VwdGlvbik6DQo+ICsgICAgcGFzcw0KPiArDQo+ICsNCj4gK2Ns YXNzIFJlcG9ydDoNCj4gKyAgICBjbGFzcyBSZXBvcnRFbnRyeToNCj4gKyAgICAgICAgZGVmIF9f aW5pdF9fKHNlbGYsIGZpbGVfcGF0aDogc3RyLCBsaW5lX251bWJlcjogaW50LA0KPiArICAgICAg ICAgICAgICAgICAgICAgZW50cnlfdGV4dDogbGlzdCwgbGluZV9pZDogaW50KSAtPiBOb25lOg0K PiArICAgICAgICAgICAgaWYgbm90IGlzaW5zdGFuY2UobGluZV9udW1iZXIsIGludCkgb3IgXA0K PiArICAgICAgICAgICAgICAgbm90IGlzaW5zdGFuY2UobGluZV9pZCwgaW50KToNCj4gKyAgICAg ICAgICAgICAgICByYWlzZSBSZXBvcnRFcnJvcigiUmVwb3J0RW50cnkgY29uc3RydWN0b3Igd3Jv bmcgdHlwZSBhcmdzIikNCj4gKyAgICAgICAgICAgIHNlbGYuZmlsZV9wYXRoID0gZmlsZV9wYXRo DQo+ICsgICAgICAgICAgICBzZWxmLmxpbmVfbnVtYmVyID0gbGluZV9udW1iZXINCj4gKyAgICAg ICAgICAgIHNlbGYudGV4dCA9IGVudHJ5X3RleHQNCj4gKyAgICAgICAgICAgIHNlbGYubGluZV9p ZCA9IGxpbmVfaWQNCj4gKw0KDQpJIHJlYWxpc2Ugbm93IHRoYXQgSSBoYWQgYSByZWJhc2UgbWlz dGFrZSBoZXJlLCB0aGUgY2xhc3MgUmVwb3J0RW50cnkgc2hvdWxkIG5vdA0KaGF2ZSB0aGVzZSB0 d28gZnVuY3Rpb25zLCBpdCB3YXMgcGFydCBvZiBhbm90aGVyIGJyYW5jaCwgSSB3aWxsIGZpeCB0 aGlzIGluIHRoZSBuZXh0DQp2ZXJzaW9uLCBpbiB0aGUgbWVhbiB0aW1lIEnigJlsbCB3YWl0IGZv ciBvdGhlciBwb3NzaWJsZSBmaW5kaW5ncyBmb3IgdGhpcyBwYXRjaC4NCg0KPGRlbGV0ZSBmcm9t IGhlcmU+DQoNCj4gKyAgICAgICAgZGVmIF9fc3RyX18oc2VsZikgLT4gc3RyOg0KPiArICAgICAg ICAgICAgcmV0ID0gJycNCj4gKyAgICAgICAgICAgIGhlYWRlciA9ICdGaWxlIHBhdGg6Q291bnRc bicNCj4gKw0KPiArICAgICAgICAgICAgZm9yIHBhdGggaW4gc2VsZi5zdGF0czoNCj4gKyAgICAg ICAgICAgICAgICByZXQgKz0gZid7cGF0aH06IHtsZW4oc2VsZi5zdGF0c1twYXRoXSl9XG4nDQo+ ICsNCj4gKyAgICAgICAgICAgIGlmIHJldCA9PSAnJzoNCj4gKyAgICAgICAgICAgICAgICByZXQg Kz0gJ05vIG5ldyBpc3N1ZXMgaW50cm9kdWNlZFxuJw0KPiArDQo+ICsgICAgICAgICAgICByZXQg PSBoZWFkZXIgKyByZXQNCj4gKw0KPiArICAgICAgICAgICAgcmV0dXJuIHJldA0KPiArDQo+ICsg ICAgICAgIGRlZiBfX2xlbl9fKHNlbGYpIC0+IGludDoNCj4gKyAgICAgICAgICAgIHJldCA9IDAN Cj4gKw0KPiArICAgICAgICAgICAgZm9yIGxuX2xpc3QgaW4gc2VsZi5zdGF0cy52YWx1ZXMoKToN Cj4gKyAgICAgICAgICAgICAgICByZXQgKz0gbGVuKGxuX2xpc3QpDQo+ICsNCj4gKyAgICAgICAg ICAgIHJldHVybiByZXQNCg0KPHRvIGhlcmU+DQoNCj4gKw0KPiArICAgIGRlZiBfX2luaXRfXyhz ZWxmLCByZXBvcnRfcGF0aDogc3RyKSAtPiBOb25lOg0KPiArICAgICAgICBzZWxmLl9fZW50cmll cyA9IHt9DQo+ICsgICAgICAgIHNlbGYuX19wYXRoID0gcmVwb3J0X3BhdGgNCj4gKyAgICAgICAg c2VsZi5fX2xhc3RfbGluZV9vcmRlciA9IDANCj4gKw0KPiArICAgIGRlZiBwYXJzZShzZWxmKSAt PiBOb25lOg0KPiArICAgICAgICByYWlzZSBSZXBvcnRFcnJvcigiUGxlYXNlIGNyZWF0ZSBhIHNw ZWNpYWxpc2VkIGNsYXNzIGZyb20gJ1JlcG9ydCcuIikNCj4gKw0KPiArICAgIGRlZiBnZXRfcmVw b3J0X3BhdGgoc2VsZikgLT4gc3RyOg0KPiArICAgICAgICByZXR1cm4gc2VsZi5fX3BhdGgNCj4g Kw0KPiArICAgIGRlZiBnZXRfcmVwb3J0X2VudHJpZXMoc2VsZikgLT4gZGljdDoNCj4gKyAgICAg ICAgcmV0dXJuIHNlbGYuX19lbnRyaWVzDQo+ICsNCj4gKyAgICBkZWYgYWRkX2VudHJ5KHNlbGYs IGVudHJ5X3BhdGg6IHN0ciwgZW50cnlfbGluZV9udW1iZXI6IGludCwNCj4gKyAgICAgICAgICAg ICAgICAgIGVudHJ5X3RleHQ6IGxpc3QpIC0+IE5vbmU6DQo+ICsgICAgICAgIGVudHJ5ID0gUmVw b3J0LlJlcG9ydEVudHJ5KGVudHJ5X3BhdGgsIGVudHJ5X2xpbmVfbnVtYmVyLCBlbnRyeV90ZXh0 LA0KPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzZWxmLl9fbGFzdF9saW5l X29yZGVyKQ0KPiArICAgICAgICBpZiBlbnRyeV9wYXRoIGluIHNlbGYuX19lbnRyaWVzLmtleXMo KToNCj4gKyAgICAgICAgICAgIHNlbGYuX19lbnRyaWVzW2VudHJ5X3BhdGhdLmFwcGVuZChlbnRy eSkNCj4gKyAgICAgICAgZWxzZToNCj4gKyAgICAgICAgICAgIHNlbGYuX19lbnRyaWVzW2VudHJ5 X3BhdGhdID0gW2VudHJ5XQ0KPiArICAgICAgICBzZWxmLl9fbGFzdF9saW5lX29yZGVyICs9IDEN Cj4gKw0KPiArICAgIGRlZiB0b19saXN0KHNlbGYpIC0+IGxpc3Q6DQo+ICsgICAgICAgIHJlcG9y dF9saXN0ID0gW10NCj4gKyAgICAgICAgZm9yIF8sIGVudHJpZXMgaW4gc2VsZi5fX2VudHJpZXMu aXRlbXMoKToNCj4gKyAgICAgICAgICAgIGZvciBlbnRyeSBpbiBlbnRyaWVzOg0KPiArICAgICAg ICAgICAgICAgIHJlcG9ydF9saXN0LmFwcGVuZChlbnRyeSkNCj4gKw0KPiArICAgICAgICByZXBv cnRfbGlzdC5zb3J0KGtleT1sYW1iZGEgeDogeC5saW5lX2lkKQ0KPiArICAgICAgICByZXR1cm4g cmVwb3J0X2xpc3QNCj4gKw0KPiArICAgIGRlZiBfX3N0cl9fKHNlbGYpIC0+IHN0cjoNCj4gKyAg ICAgICAgcmV0ID0gIiINCj4gKyAgICAgICAgZm9yIGVudHJ5IGluIHNlbGYudG9fbGlzdCgpOg0K PiArICAgICAgICAgICAgcmV0ICs9IGVudHJ5LmZpbGVfcGF0aCArICI6IiArIGVudHJ5LmxpbmVf bnVtYmVyICsgIjoiICsgZW50cnkudGV4dA0KPiArDQo+ICsgICAgICAgIHJldHVybiByZXQNCj4g Kw0KPiArICAgIGRlZiBfX2xlbl9fKHNlbGYpIC0+IGludDoNCj4gKyAgICAgICAgcmV0dXJuIGxl bihzZWxmLnRvX2xpc3QoKSkNCj4gKw0KPiArICAgIGRlZiBfX3N1Yl9fKHNlbGYsIHJlcG9ydF9i OiAnUmVwb3J0JykgLT4gJ1JlcG9ydCc6DQo+ICsgICAgICAgIGlmIHNlbGYuX19jbGFzc19fICE9 IHJlcG9ydF9iLl9fY2xhc3NfXzoNCj4gKyAgICAgICAgICAgIHJhaXNlIFJlcG9ydEVycm9yKCJE aWZmIG9mIGRpZmZlcmVudCB0eXBlIG9mIHJlcG9ydCEiKQ0KPiArDQo+ICsgICAgICAgIGZpbGVu YW1lLCBmaWxlX2V4dGVuc2lvbiA9IG9zLnBhdGguc3BsaXRleHQoc2VsZi5fX3BhdGgpDQo+ICsg ICAgICAgIGRpZmZfcmVwb3J0ID0gc2VsZi5fX2NsYXNzX18oZmlsZW5hbWUgKyAiLmRpZmYiICsg ZmlsZV9leHRlbnNpb24pDQo+ICsgICAgICAgICMgUHV0IGluIHRoZSBkaWZmIHJlcG9ydCBvbmx5 IHJlY29yZHMgb2YgdGhpcyByZXBvcnQgdGhhdCBhcmUgbm90DQo+ICsgICAgICAgICMgcHJlc2Vu dCBpbiB0aGUgcmVwb3J0X2IuDQo+ICsgICAgICAgIGZvciBmaWxlX3BhdGgsIGVudHJpZXMgaW4g c2VsZi5fX2VudHJpZXMuaXRlbXMoKToNCj4gKyAgICAgICAgICAgIHJlcF9iX2VudHJpZXMgPSBy ZXBvcnRfYi5nZXRfcmVwb3J0X2VudHJpZXMoKQ0KPiArICAgICAgICAgICAgaWYgZmlsZV9wYXRo IGluIHJlcF9iX2VudHJpZXMua2V5cygpOg0KPiArICAgICAgICAgICAgICAgICMgRmlsZSBwYXRo IGV4aXN0cyBpbiByZXBvcnRfYiwgc28gY2hlY2sgd2hhdCBlbnRyaWVzIG9mIHRoYXQNCj4gKyAg ICAgICAgICAgICAgICAjIGZpbGUgcGF0aCBkb2Vzbid0IGV4aXN0IGluIHJlcG9ydF9iIGFuZCBh ZGQgdGhlbSB0byB0aGUgZGlmZg0KPiArICAgICAgICAgICAgICAgIHJlcF9iX2VudHJpZXNfbnVt ID0gWw0KPiArICAgICAgICAgICAgICAgICAgICB4LmxpbmVfbnVtYmVyIGZvciB4IGluIHJlcF9i X2VudHJpZXNbZmlsZV9wYXRoXQ0KPiArICAgICAgICAgICAgICAgIF0NCj4gKyAgICAgICAgICAg ICAgICBmb3IgZW50cnkgaW4gZW50cmllczoNCj4gKyAgICAgICAgICAgICAgICAgICAgaWYgZW50 cnkubGluZV9udW1iZXIgbm90IGluIHJlcF9iX2VudHJpZXNfbnVtOg0KPiArICAgICAgICAgICAg ICAgICAgICAgICAgZGlmZl9yZXBvcnQuYWRkX2VudHJ5KGZpbGVfcGF0aCwgZW50cnkubGluZV9u dW1iZXIsDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ZW50cnkudGV4dCkNCj4gKyAgICAgICAgICAgIGVsc2U6DQo+ICsgICAgICAgICAgICAgICAgIyBG aWxlIHBhdGggZG9lc24ndCBleGlzdCBpbiByZXBvcnRfYiwgc28gYWRkIGV2ZXJ5IGVudHJ5DQo+ ICsgICAgICAgICAgICAgICAgIyBvZiB0aGF0IGZpbGUgcGF0aCB0byB0aGUgZGlmZg0KPiArICAg ICAgICAgICAgICAgIGZvciBlbnRyeSBpbiBlbnRyaWVzOg0KPiArICAgICAgICAgICAgICAgICAg ICBkaWZmX3JlcG9ydC5hZGRfZW50cnkoZmlsZV9wYXRoLCBlbnRyeS5saW5lX251bWJlciwNCj4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGVudHJ5LnRleHQpDQo+ ICsNCj4gKyAgICAgICAgcmV0dXJuIGRpZmZfcmVwb3J0DQo+IC0tIA0KPiAyLjM0LjENCj4gDQo+ IA0KDQo= From xen-devel-bounces@lists.xenproject.org Sat May 06 08:33:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 May 2023 08:33:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530827.826574 (Exim 4.92) (envelope-from ) id 1pvDLW-0003Qj-U8; Sat, 06 May 2023 08:32:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530827.826574; Sat, 06 May 2023 08:32:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvDLW-0003Qc-RM; Sat, 06 May 2023 08:32:50 +0000 Received: by outflank-mailman (input) for mailman id 530827; Sat, 06 May 2023 08:32:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvDLV-0003QS-H5; Sat, 06 May 2023 08:32:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvDLV-0003j9-AU; Sat, 06 May 2023 08:32:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvDLU-0007TZ-Uu; Sat, 06 May 2023 08:32:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pvDLU-0001MI-UY; Sat, 06 May 2023 08:32:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=tVREe1QnPo5ZN1WVLsPBzvu66dAEv9NC76xuwWSaxvc=; b=bEcyJOvPumzu5xitcjpU1/j4pi HTFdz36xvszCatPefMHV9jxnw7emsnVpZCWpmc0o2VcCaK4brUvUk8+bOxlL7stHIujVNjwnoBdkO 0Y1agO3PH+LC3MXVyhBHH8mJVZlMIBBJEInR+3mENZaOicVg1hcsiy7/XNglAFRzx2hU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180547: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:heisenbug xen-unstable:test-amd64-i386-xl-xsm:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e93e635e142d45e3904efb4a05e2b3b52a708b4f X-Osstest-Versions-That: xen=b95a72bb5b2df24ff1baaa27920e57947dc97d49 From: osstest service owner Date: Sat, 06 May 2023 08:32:48 +0000 flight 180547 xen-unstable real [real] flight 180554 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180547/ http://logs.test-lab.xenproject.org/osstest/logs/180554/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail pass in 180554-retest test-amd64-i386-xl-xsm 7 xen-install fail pass in 180554-retest test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail pass in 180554-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180537 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180537 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180537 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180537 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180537 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 180537 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180537 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 180537 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 180537 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180537 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180537 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180537 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass version targeted for testing: xen e93e635e142d45e3904efb4a05e2b3b52a708b4f baseline version: xen b95a72bb5b2df24ff1baaa27920e57947dc97d49 Last test of basis 180537 2023-05-05 01:52:22 Z 1 days Testing same since 180547 2023-05-05 15:40:37 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git b95a72bb5b..e93e635e14 e93e635e142d45e3904efb4a05e2b3b52a708b4f -> master From xen-devel-bounces@lists.xenproject.org Sat May 06 11:36:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 May 2023 11:36:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530838.826597 (Exim 4.92) (envelope-from ) id 1pvGDG-0004h4-0T; Sat, 06 May 2023 11:36:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530838.826597; Sat, 06 May 2023 11:36:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvGDF-0004gx-Tz; Sat, 06 May 2023 11:36:29 +0000 Received: by outflank-mailman (input) for mailman id 530838; Sat, 06 May 2023 11:36:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvGDE-0004go-KZ for xen-devel@lists.xenproject.org; Sat, 06 May 2023 11:36:28 +0000 Received: from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de [130.133.4.66]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3ba43fe7-ec02-11ed-b226-6b7b168915f2; Sat, 06 May 2023 13:36:25 +0200 (CEST) Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.95) with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1pvGCa-002hVY-AY; Sat, 06 May 2023 13:35:48 +0200 Received: from p57bd9cee.dip0.t-ipconnect.de ([87.189.156.238] helo=suse-laptop.fritz.box) by inpost2.zedat.fu-berlin.de (Exim 4.95) with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1pvGCZ-000Sf9-Vs; Sat, 06 May 2023 13:35:48 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ba43fe7-ec02-11ed-b226-6b7b168915f2 Message-ID: Subject: Re: [PATCH v2 30/34] sh: Convert pte_free_tlb() to use ptdescs From: John Paul Adrian Glaubitz To: "Vishal Moola (Oracle)" , Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Yoshinori Sato Date: Sat, 06 May 2023 13:35:46 +0200 In-Reply-To: <20230501192829.17086-31-vishal.moola@gmail.com> References: <20230501192829.17086-1-vishal.moola@gmail.com> <20230501192829.17086-31-vishal.moola@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.1 MIME-Version: 1.0 X-Original-Sender: glaubitz@physik.fu-berlin.de X-Originating-IP: 87.189.156.238 X-ZEDAT-Hint: PO Hi Vishal! On Mon, 2023-05-01 at 12:28 -0700, Vishal Moola (Oracle) wrote: > Part of the conversions to replace pgtable constructor/destructors with > ptdesc equivalents. Also cleans up some spacing issues. >=20 > Signed-off-by: Vishal Moola (Oracle) > --- > arch/sh/include/asm/pgalloc.h | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) >=20 > diff --git a/arch/sh/include/asm/pgalloc.h b/arch/sh/include/asm/pgalloc.= h > index a9e98233c4d4..ce2ba99dbd84 100644 > --- a/arch/sh/include/asm/pgalloc.h > +++ b/arch/sh/include/asm/pgalloc.h > @@ -2,6 +2,7 @@ > #ifndef __ASM_SH_PGALLOC_H > #define __ASM_SH_PGALLOC_H > =20 > +#include > #include > =20 > #define __HAVE_ARCH_PMD_ALLOC_ONE > @@ -31,10 +32,10 @@ static inline void pmd_populate(struct mm_struct *mm,= pmd_t *pmd, > set_pmd(pmd, __pmd((unsigned long)page_address(pte))); > } > =20 > -#define __pte_free_tlb(tlb,pte,addr) \ > -do { \ > - pgtable_pte_page_dtor(pte); \ > - tlb_remove_page((tlb), (pte)); \ > +#define __pte_free_tlb(tlb, pte, addr) \ > +do { \ > + ptdesc_pte_dtor(page_ptdesc(pte)); \ > + tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); \ > } while (0) > =20 > #endif /* __ASM_SH_PGALLOC_H */ Looking at the patch which introduces tlb_remove_page_ptdesc() [1], it seem= s that tlb_remove_page_ptdesc() already calls tlb_remove_page() with ptdesc_page(p= t), so I'm not sure whether the above tlb_remove_page_ptdesc((tlb), (page_ptdesc(p= te))) is correct. Shouldn't it just be tlb_remove_page_ptdesc((tlb), (pte))? Thanks, Adrian > [1] https://lore.kernel.org/linux-mm/20230417205048.15870-5-vishal.moola@= gmail.com/ --=20 .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 From xen-devel-bounces@lists.xenproject.org Sat May 06 13:41:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 May 2023 13:41:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530853.826606 (Exim 4.92) (envelope-from ) id 1pvI9m-0001CB-6w; Sat, 06 May 2023 13:41:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530853.826606; Sat, 06 May 2023 13:41:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvI9m-0001C4-3y; Sat, 06 May 2023 13:41:02 +0000 Received: by outflank-mailman (input) for mailman id 530853; Sat, 06 May 2023 13:41:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvI9k-0001Bu-NG; Sat, 06 May 2023 13:41:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvI9k-0005Mz-G4; Sat, 06 May 2023 13:41:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvI9j-0006aL-S6; Sat, 06 May 2023 13:40:59 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pvI9j-00013k-Rb; Sat, 06 May 2023 13:40:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=XEjZOjBQi4Gte2ewLu8J/PTgKbMgeaNHUDgHWjFclcY=; b=2ZX6PCzzMyaoLLuQZafzXNXtCZ g22t+36DSfbOXzmVg0u5twjZ5du/tM41Bi3x8ZXgCQnpvbU7xVqsuU/i+hgWpySBTF3K9/NfqfcXY YHOvp1/EHHNvet6uCHzTS1WZGaETQIHB9khUD01CF/EBnUdeyByhFZX++EVVj2pX97XI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180549: regressions - FAIL X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:guest-start/debian.repeat:fail:heisenbug linux-linus:test-armhf-armhf-examine:reboot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=418d5c98319f67b9ae651babea031b5394425c18 X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Sat, 06 May 2023 13:40:59 +0000 flight 180549 linux-linus real [real] flight 180556 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180549/ http://logs.test-lab.xenproject.org/osstest/logs/180556/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 180278 Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-qcow2 19 guest-start/debian.repeat fail pass in 180556-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-examine 8 reboot fail like 180278 test-armhf-armhf-libvirt 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-raw 8 xen-boot fail like 180278 test-armhf-armhf-xl-rtds 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180278 test-armhf-armhf-xl 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180278 test-armhf-armhf-xl-multivcpu 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail like 180278 test-armhf-armhf-xl-credit2 8 xen-boot fail like 180278 test-armhf-armhf-xl-vhd 8 xen-boot fail like 180278 test-armhf-armhf-xl-arndale 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 418d5c98319f67b9ae651babea031b5394425c18 baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 19 days Failing since 180281 2023-04-17 06:24:36 Z 19 days 33 attempts Testing same since 180549 2023-05-05 22:43:18 Z 0 days 1 attempts ------------------------------------------------------------ 2276 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 278899 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 06 13:48:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 May 2023 13:48:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530886.826635 (Exim 4.92) (envelope-from ) id 1pvIGI-0002oq-Cm; Sat, 06 May 2023 13:47:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530886.826635; Sat, 06 May 2023 13:47:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvIGI-0002oj-7t; Sat, 06 May 2023 13:47:46 +0000 Received: by outflank-mailman (input) for mailman id 530886; Sat, 06 May 2023 13:47:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvIGH-0002oZ-8T; Sat, 06 May 2023 13:47:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvIGH-0005TA-0H; Sat, 06 May 2023 13:47:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvIGG-0006kM-Kg; Sat, 06 May 2023 13:47:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pvIGG-0003ZZ-K7; Sat, 06 May 2023 13:47:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=AZ19yHs3nHZTK3/hZqj9ryIw+z1Ut/aCkKvjmtUoWyQ=; b=LEinwPdVUqTkluuRxmo8CGxEg7 jd8jRTbmcy0kFUhcdrfAt5aqMu/V1AwA9TKtHjD5zQEvHKfqb/ASbGLy+Y6muSwmAO6CT4iQllbe9 TD7ZcV4csjNhLGU212D6k/OhTih4x19HiWI4li0JQ28f/ibNRyvXANFflfY/lWxnexMs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 180552: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=9b8bb536ff999fa61e41869bd98a026b8e23378f X-Osstest-Versions-That: libvirt=4419e74117b3bb17c61cd7a612b5801ab99ad547 From: osstest service owner Date: Sat, 06 May 2023 13:47:44 +0000 flight 180552 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/180552/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 180539 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 180539 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 180539 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: libvirt 9b8bb536ff999fa61e41869bd98a026b8e23378f baseline version: libvirt 4419e74117b3bb17c61cd7a612b5801ab99ad547 Last test of basis 180539 2023-05-05 04:18:48 Z 1 days Testing same since 180552 2023-05-06 04:18:49 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrea Bolognani Peter Krempa jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 4419e74117..9b8bb536ff 9b8bb536ff999fa61e41869bd98a026b8e23378f -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat May 06 13:55:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 May 2023 13:55:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530896.826643 (Exim 4.92) (envelope-from ) id 1pvINF-0004IS-3M; Sat, 06 May 2023 13:54:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530896.826643; Sat, 06 May 2023 13:54:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvINF-0004IL-0G; Sat, 06 May 2023 13:54:57 +0000 Received: by outflank-mailman (input) for mailman id 530896; Sat, 06 May 2023 13:54:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvINE-0004IB-Eu; Sat, 06 May 2023 13:54:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvINE-0005b9-6V; Sat, 06 May 2023 13:54:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvIND-0006x8-LR; Sat, 06 May 2023 13:54:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pvIND-0006Tf-L2; Sat, 06 May 2023 13:54:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=C624UMaRNrPshzCsbmq0VJSEVGQn5UNPkrffHcGnjRI=; b=fFqpY6uBVMXH/snz/fKAon6vuX a67AGYO0UxfnuYcl8aJHZ4fGgzbB/eg0M4o4d6X591rXaB+P5TZhto5be1tcnEEpYuAVyvsgGx1Rq pDA5AuUnNfr4ldH05ANGPq3LlC93Hf8fOequo1Zr8ZZNLwwfFU4Povg1rluD1ht965BQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 180553: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression qemu-mainline:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:build-arm64-pvops:kernel-build:fail:regression qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=eb5c3932a383ba1ef3a911232c644f2e053ef66c X-Osstest-Versions-That: qemuu=a9fe9e191b4305b88c356a1ed9ac3baf89eb18aa From: osstest service owner Date: Sat, 06 May 2023 13:54:55 +0000 flight 180553 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/180553/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 180546 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail REGR. vs. 180546 build-arm64-pvops 6 kernel-build fail REGR. vs. 180546 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail blocked in 180546 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180546 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180546 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 180546 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 180546 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 180546 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180546 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180546 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass version targeted for testing: qemuu eb5c3932a383ba1ef3a911232c644f2e053ef66c baseline version: qemuu a9fe9e191b4305b88c356a1ed9ac3baf89eb18aa Last test of basis 180546 2023-05-05 15:15:28 Z 0 days Testing same since 180553 2023-05-06 04:39:17 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Dorinda Bassey Juan Quintela Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 343 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 06 16:23:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 May 2023 16:23:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530907.826656 (Exim 4.92) (envelope-from ) id 1pvKgF-0003GJ-NJ; Sat, 06 May 2023 16:22:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530907.826656; Sat, 06 May 2023 16:22:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvKgF-0003GC-Kk; Sat, 06 May 2023 16:22:43 +0000 Received: by outflank-mailman (input) for mailman id 530907; Sat, 06 May 2023 16:22:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvKgE-0003G6-K3 for xen-devel@lists.xenproject.org; Sat, 06 May 2023 16:22:42 +0000 Received: from galois.linutronix.de (galois.linutronix.de [2a0a:51c0:0:12e:550::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 38252c96-ec2a-11ed-b226-6b7b168915f2; Sat, 06 May 2023 18:22:40 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 38252c96-ec2a-11ed-b226-6b7b168915f2 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683390158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NXHfBgcGHt/ZfPwa+T595dnepfFJKJnpLjR3JhBl6Q0=; b=1czMZh1cRjeqiQ2TZA6GbMVHHXEF93eQIVvQioB8FE/pRwMNCJ9iNbT002o3Vf8Q1PmjjT pMzD7AC5NROe0zWPr/xkstx8tP21FQigIYhXnCedHf48++FNK52empvCyZE4IMSf7ryah7 wwDm68n14K3LZeFvyQ99Fwubq6JJjmTxOyIllycil0ZJfXjm8tULzw2/ivE/eeRZ3vZ2Ce eFzoWJEYtyiUQ3YTBmQpXzsA8QFgMuJS8CeTY8f2OfEh+NvACDq69zDAubztHsM41nl1p1 k+Q1vY7kiaQqTaWRFrb4KJC+127qTmzlxib6lozIfkeM3gQq7L3F5SIRCIw/xg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683390158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NXHfBgcGHt/ZfPwa+T595dnepfFJKJnpLjR3JhBl6Q0=; b=qtQ0xS4FhuHdv2/qWAJNtp26GqvWQxksH6Mo/Q1MgLXE9WE0n6Pih7C913p3eWGR7QXk2c rCYD41DUjLVIXsBw== To: "Michael Kelley (LINUX)" , LKML Cc: "x86@kernel.org" , David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , "xen-devel@lists.xenproject.org" , Russell King , Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" , Catalin Marinas , Will Deacon , Guo Ren , "linux-csky@vger.kernel.org" , Thomas Bogendoerfer , "linux-mips@vger.kernel.org" , "James E.J. Bottomley" , Helge Deller , "linux-parisc@vger.kernel.org" , Paul Walmsley , Palmer Dabbelt , "linux-riscv@lists.infradead.org" , Mark Rutland , Sabin Rapan Subject: RE: [patch V2 38/38] x86/smpboot/64: Implement arch_cpuhp_init_parallel_bringup() and enable it In-Reply-To: References: <20230504185733.126511787@linutronix.de> <20230504185938.393373946@linutronix.de> Date: Sat, 06 May 2023 18:22:37 +0200 Message-ID: <87sfc92zw2.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain On Sat, May 06 2023 at 00:53, Michael Kelley wrote: > From: Thomas Gleixner Sent: Thursday, May 4, 2023 12:03 PM > [snip] > >> @@ -934,10 +961,10 @@ static void announce_cpu(int cpu, int ap >> if (!node_width) >> node_width = num_digits(num_possible_nodes()) + 1; /* + '#' */ >> >> - if (cpu == 1) >> - printk(KERN_INFO "x86: Booting SMP configuration:\n"); >> - >> if (system_state < SYSTEM_RUNNING) { >> + if (num_online_cpus() == 1) > > Unfortunately, this new check doesn't work. Here's the output I get: > > [ 0.721384] smp: Bringing up secondary CPUs ... > [ 0.725359] smpboot: x86: Booting SMP configuration: > [ 0.729249] .... node #0, CPUs: #2 > [ 0.729654] smpboot: x86: Booting SMP configuration: > [ 0.737247] #4 > > Evidently num_online_cpus() isn't updated until after all the primary > siblings get started. Duh. Where is that brown paperbag? > When booting with cpuhp.parallel=0, the output is good. Exactly that was on the command line when I quickly booted that change :( The below should fix it for real. Thanks, tglx --- --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -951,9 +951,9 @@ static int wakeup_secondary_cpu_via_init /* reduce the number of lines printed when booting a large cpu count system */ static void announce_cpu(int cpu, int apicid) { + static int width, node_width, first = 1; static int current_node = NUMA_NO_NODE; int node = early_cpu_to_node(cpu); - static int width, node_width; if (!width) width = num_digits(num_possible_cpus()) + 1; /* + '#' sign */ @@ -962,7 +962,7 @@ static void announce_cpu(int cpu, int ap node_width = num_digits(num_possible_nodes()) + 1; /* + '#' */ if (system_state < SYSTEM_RUNNING) { - if (num_online_cpus() == 1) + if (first) pr_info("x86: Booting SMP configuration:\n"); if (node != current_node) { @@ -975,11 +975,11 @@ static void announce_cpu(int cpu, int ap } /* Add padding for the BSP */ - if (num_online_cpus() == 1) + if (first) pr_cont("%*s", width + 1, " "); + first = 0; pr_cont("%*s#%d", width - num_digits(cpu), " ", cpu); - } else pr_info("Booting Node %d Processor %d APIC 0x%x\n", node, cpu, apicid); From xen-devel-bounces@lists.xenproject.org Sat May 06 19:45:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 May 2023 19:45:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530919.826673 (Exim 4.92) (envelope-from ) id 1pvNqZ-0006Zp-9B; Sat, 06 May 2023 19:45:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530919.826673; Sat, 06 May 2023 19:45:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvNqZ-0006Zi-6S; Sat, 06 May 2023 19:45:35 +0000 Received: by outflank-mailman (input) for mailman id 530919; Sat, 06 May 2023 19:45:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvNqY-0006ZY-9s; Sat, 06 May 2023 19:45:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvNqX-000678-9i; Sat, 06 May 2023 19:45:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvNqW-0007IA-RM; Sat, 06 May 2023 19:45:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pvNqW-00023F-Qx; Sat, 06 May 2023 19:45:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4t9kWov/D6pD6hCwzJt5oE+rJNjPLkcdWtgnbB7IRTo=; b=wJ9/kmdCda1pYDphDxNpdSNIqp oRwdxGyDQwiRh3K+wdEk+1mGUYPJ2AS8lc7TeHVlHquXk+t0BuV7VekBGAhJwFymINsr5X9vJ6gYl ApqHdAbkwsnPcq+HNN92W9BWzvT0AxkZL0MaECEYLfDAnY11KAO4QqRWqVKAWMPQp2Go=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180555: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e93e635e142d45e3904efb4a05e2b3b52a708b4f X-Osstest-Versions-That: xen=e93e635e142d45e3904efb4a05e2b3b52a708b4f From: osstest service owner Date: Sat, 06 May 2023 19:45:32 +0000 flight 180555 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/180555/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail like 180547 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180547 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180547 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180547 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 180547 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180547 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180547 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 180547 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180547 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 180547 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180547 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180547 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180547 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass version targeted for testing: xen e93e635e142d45e3904efb4a05e2b3b52a708b4f baseline version: xen e93e635e142d45e3904efb4a05e2b3b52a708b4f Last test of basis 180555 2023-05-06 08:36:36 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sat May 06 20:08:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 May 2023 20:08:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530977.826689 (Exim 4.92) (envelope-from ) id 1pvOD5-0000oX-6M; Sat, 06 May 2023 20:08:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530977.826689; Sat, 06 May 2023 20:08:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvOD5-0000oQ-2P; Sat, 06 May 2023 20:08:51 +0000 Received: by outflank-mailman (input) for mailman id 530977; Sat, 06 May 2023 20:08:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvOD4-0000oG-IR; Sat, 06 May 2023 20:08:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvOD4-0006mF-HX; Sat, 06 May 2023 20:08:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvOD4-0007vW-5y; Sat, 06 May 2023 20:08:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pvOD4-0005vL-5T; Sat, 06 May 2023 20:08:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=e4q7PLn1wtlnoOg3zz0Xc63GOAkt76WegN9PZoCrfnI=; b=pafL3zMv2MjWaBFAELP7ZSVngT NPXTWsNu5G/+Ekxe/08D6HVXWLxw4j49E9A6QjqeUwhbTU1Zm5q7DDJjABSv3YQrgOYCkhLo7yq83 bSWgVcAsYXvkRQsmXmFyyJPGTl5f7vWG8y5Qn11dIbMgO2ZUeT7vpNwKrE3s6hZWWICQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180561: all pass - PUSHED X-Osstest-Versions-This: ovmf=66494e532450c1205be93015740580c1e7b8877a X-Osstest-Versions-That: ovmf=eabaeb0613c0b459db950ab655f99ada9389d0cf From: osstest service owner Date: Sat, 06 May 2023 20:08:50 +0000 flight 180561 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180561/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 66494e532450c1205be93015740580c1e7b8877a baseline version: ovmf eabaeb0613c0b459db950ab655f99ada9389d0cf Last test of basis 180551 2023-05-06 04:10:42 Z 0 days Testing same since 180561 2023-05-06 18:10:51 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michael D Kinney jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git eabaeb0613..66494e5324 66494e532450c1205be93015740580c1e7b8877a -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat May 06 22:15:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 May 2023 22:15:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.530999.826704 (Exim 4.92) (envelope-from ) id 1pvQBV-0005mB-Fr; Sat, 06 May 2023 22:15:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530999.826704; Sat, 06 May 2023 22:15:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvQBV-0005m4-D7; Sat, 06 May 2023 22:15:21 +0000 Received: by outflank-mailman (input) for mailman id 530999; Sat, 06 May 2023 22:15:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvQBU-0005ld-Em; Sat, 06 May 2023 22:15:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvQBT-0001XJ-Fw; Sat, 06 May 2023 22:15:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvQBT-0002ok-8c; Sat, 06 May 2023 22:15:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pvQBT-00078p-85; Sat, 06 May 2023 22:15:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=d/oEbbG38Fk474cI3wx2c3jal1laJxMgOQKxRDrOwqg=; b=roV+sMay7T+A63MUTXtf8mbflL nDilSdVX7MFTsHUb/Q4gwKKmwAW91VQjBCaak4bH+nzjCsyz8g0DBFkh+hE0f+zbVi6VoEdillhPz 8SzOZ88m8sNdX1od8FgBKZpSwIAiEsxLxSCem1bim3w3+kkNDlBC/Z2rFs4kTxyLcqgA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180563: all pass - PUSHED X-Osstest-Versions-This: ovmf=4dea9e4a0e9db431240434279be9fbe45fd1651b X-Osstest-Versions-That: ovmf=66494e532450c1205be93015740580c1e7b8877a From: osstest service owner Date: Sat, 06 May 2023 22:15:19 +0000 flight 180563 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180563/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 4dea9e4a0e9db431240434279be9fbe45fd1651b baseline version: ovmf 66494e532450c1205be93015740580c1e7b8877a Last test of basis 180561 2023-05-06 18:10:51 Z 0 days Testing same since 180563 2023-05-06 20:11:20 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michael D Kinney jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 66494e5324..4dea9e4a0e 4dea9e4a0e9db431240434279be9fbe45fd1651b -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sun May 07 02:01:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 07 May 2023 02:01:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531012.826715 (Exim 4.92) (envelope-from ) id 1pvTho-0006Hw-LD; Sun, 07 May 2023 02:00:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531012.826715; Sun, 07 May 2023 02:00:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvTho-0006Ho-Ea; Sun, 07 May 2023 02:00:56 +0000 Received: by outflank-mailman (input) for mailman id 531012; Sun, 07 May 2023 02:00:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvThn-0006He-DK; Sun, 07 May 2023 02:00:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvThn-00028b-4L; Sun, 07 May 2023 02:00:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvThm-00089C-F2; Sun, 07 May 2023 02:00:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pvThm-0007bP-Ed; Sun, 07 May 2023 02:00:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vxsmsC3bVoBIaZxBPiimbscWbVahVgIrm0TgGYRJ3Hg=; b=v4v4tMFc5zJkNKYfKa95/DVxY0 J8TyaUtGkvJm0tXU3FQ1zdk20bps7X0dv+oEi8MjepY4hNd51KtSnNgoe4+kuFGwPk64heapD+gqU ExH0NGAOjko/tiRXyVIu3RGwUTbuoiPWNlyoTFZ6I55B43Yw9jgP9j/Xp3kQL6Tynb5I=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180557: regressions - FAIL X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:leak-check/check:fail:heisenbug linux-linus:test-armhf-armhf-examine:reboot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=2e1e1337881b0e9844d687982aa54b31b1269b11 X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Sun, 07 May 2023 02:00:54 +0000 flight 180557 linux-linus real [real] flight 180565 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180557/ http://logs.test-lab.xenproject.org/osstest/logs/180565/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 180278 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 23 leak-check/check fail pass in 180565-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-examine 8 reboot fail like 180278 test-armhf-armhf-libvirt 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-raw 8 xen-boot fail like 180278 test-armhf-armhf-xl-rtds 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180278 test-armhf-armhf-xl 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180278 test-armhf-armhf-xl-multivcpu 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail like 180278 test-armhf-armhf-xl-credit2 8 xen-boot fail like 180278 test-armhf-armhf-xl-vhd 8 xen-boot fail like 180278 test-armhf-armhf-xl-arndale 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 2e1e1337881b0e9844d687982aa54b31b1269b11 baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 20 days Failing since 180281 2023-04-17 06:24:36 Z 19 days 34 attempts Testing same since 180557 2023-05-06 13:43:44 Z 0 days 1 attempts ------------------------------------------------------------ 2304 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 281563 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 07 04:14:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 07 May 2023 04:14:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531020.826725 (Exim 4.92) (envelope-from ) id 1pvVmt-0002ws-Sq; Sun, 07 May 2023 04:14:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531020.826725; Sun, 07 May 2023 04:14:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvVmt-0002wW-Mc; Sun, 07 May 2023 04:14:19 +0000 Received: by outflank-mailman (input) for mailman id 531020; Sun, 07 May 2023 04:14:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvVms-0002wQ-36 for xen-devel@lists.xenproject.org; Sun, 07 May 2023 04:14:18 +0000 Received: from DM6FTOPR00CU001.outbound.protection.outlook.com (mail-cusazlp170100000.outbound.protection.outlook.com [2a01:111:f403:c111::]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9f5eccaf-ec8d-11ed-8611-37d641c3527e; Sun, 07 May 2023 06:14:14 +0200 (CEST) Received: from BYAPR21MB1688.namprd21.prod.outlook.com (2603:10b6:a02:bf::26) by BL0PR2101MB1330.namprd21.prod.outlook.com (2603:10b6:208:92::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.1; Sun, 7 May 2023 04:14:09 +0000 Received: from BYAPR21MB1688.namprd21.prod.outlook.com ([fe80::9a0f:a04d:69bd:e622]) by BYAPR21MB1688.namprd21.prod.outlook.com ([fe80::9a0f:a04d:69bd:e622%4]) with mapi id 15.20.6411.001; Sun, 7 May 2023 04:14:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9f5eccaf-ec8d-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HgnllY60NA2knDjebBuJ09rGPOHOpdonOv0P9PLzY+zYpEo8LTZPIsd74baBbQ//vFyOx+4wg8Hd4CyAqZ3+7cF/wcrwNLGvwZKjrfDZPy65spPoVKmW7VteNgJbfTJ/vOzXKBXL6K3PUI436ByiAk2MRm0kUwbROWZzaPrFMyFOlWTDDofeMTZUvhQ/hboktMfj2ZQCgZ7b8xIs85o7PX1RyZrWBWjuOkNBfzQ7eG+SvjEzN75K7LITuK5JYLsF0dOA4Hae44bbsImNmx8r3WdWiJwVdlXysFY67vIIXlFFLrmxqkeBb6hBrwBmAckexrqbe/qsJMM6tk9WRqVuRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tY+33LB3hpYbL+5KySOOuT2kgudd0q8zip8Km+tZUW0=; b=HsbO2Hg/BfAWKLCq3ms5vQtUdu90499l2F02MZEUB2OOug5qU0GDLmIQb+gHCs24WETGvcw4dFl/4BwHgAxR8t7A4CJEsMdRS3oZcT7gTfalYWwDqxiAzyovFVtQx6wbD/u0g75bd8VChDffhWJxFUpHPTDx3yu3eE6f8XwFiltVl5XGstJzF/yUDvHypLduT+Qf35KyWlYvaPZX54HE8IDLV4YbcbN/saO2tpYyz/n02dOjZGmsLAdF9vR5bvuTvw4oec7Hx/x8evkEXqTCbAM6xIVPTjIeJxaDVQ77RQHBbBdua1PnzS7DBoMs4MZihDW6u8JmnKNX/sZQ9nHI2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tY+33LB3hpYbL+5KySOOuT2kgudd0q8zip8Km+tZUW0=; b=Gl5dthcrtDqT0ZEU2+vNpfSqJMAVVcebESZC3e92llUNLHoBpEz3orQzinxr9GFOPAvkA5CDdFoE953M814HAv10BFO3Lwwp1aqOH1X+aYnrfC3AdWq9oXhomvzZsDCYBEXjElbQbAuArmtGY1YO6+cMhWesspDHM9FpLWpWQek= From: "Michael Kelley (LINUX)" To: Thomas Gleixner , LKML CC: "x86@kernel.org" , David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , "xen-devel@lists.xenproject.org" , Russell King , Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" , Catalin Marinas , Will Deacon , Guo Ren , "linux-csky@vger.kernel.org" , Thomas Bogendoerfer , "linux-mips@vger.kernel.org" , "James E.J. Bottomley" , Helge Deller , "linux-parisc@vger.kernel.org" , Paul Walmsley , Palmer Dabbelt , "linux-riscv@lists.infradead.org" , Mark Rutland , Sabin Rapan Subject: RE: [patch V2 38/38] x86/smpboot/64: Implement arch_cpuhp_init_parallel_bringup() and enable it Thread-Topic: [patch V2 38/38] x86/smpboot/64: Implement arch_cpuhp_init_parallel_bringup() and enable it Thread-Index: AQHZfrsPO9aHmT4GeE2OzCti+2hGJa9MacrggAEGsICAAMVzgA== Date: Sun, 7 May 2023 04:14:08 +0000 Message-ID: References: <20230504185733.126511787@linutronix.de> <20230504185938.393373946@linutronix.de> <87sfc92zw2.ffs@tglx> In-Reply-To: <87sfc92zw2.ffs@tglx> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=56484d60-8d00-4ff5-b5f8-f0c240f99b2d;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2023-05-07T04:09:18Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR21MB1688:EE_|BL0PR2101MB1330:EE_ x-ms-office365-filtering-correlation-id: d2a9855f-6ecc-44e8-ad10-08db4eb18117 x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Pb14TKVPccx1vLCQs4eRlRzYXHVFHH59/7A2ShGhhIsvercQIIFPQtRK5tTfroxEBlHgTnggZvPnyUm+VsjEvMwyoOQS1/z1ofXcPzEfAIhRPxftL3Yh4EZww8uHXXKVY427W7ynwAeSO+SlZ6pCMh7XkD9MXp4FgkpFO5GQ0RLjo0Dgg22zWsiyQ33C7YEI2PnUxGbpW0TJ6JIRG/u+vucSesCosp+MeHJAOaoSrFmuaw788Nvx1K0VrEWBz/GfrY+2gs2SSExMQFWZJhLzUxZJnPuBQGfCOycrFo3VchIvRHelvk7crBN2YcUcna772LtatamGN2zpOiwnPCTPYWdV1ZVtZ9QNNEQxEN2CCWxLHzTP9tSUAWQDAD89A5prOTPEDUShF/Gg0+/6kTkOsXr+moLbT8N/IM11CtWk1Rnj1ZwCDyLWtw/XFjIyf1GUNBRCsKQRf2cCs8wgYT5MY+NlLSocQX5Mhgz8mQuD7BcRnvAeKx3AAOy9gv62UiND4Jary1QGZBMwJv5R4KGxcfl9RKoVTkptldyM1ZjU6n+iB5CNh7Fnt5bv1DrPYkHV2BmIvwmLdqsX2kQ0knlQ0f4gIJTJV3baN6Q9s8/2+0prTV+0VHPfsL0bdsi9PY2sCA22ied3nu+9RLV0BBYQzdD4DokLSPJgJfzzsvzqJbw= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR21MB1688.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(376002)(366004)(346002)(136003)(396003)(451199021)(55016003)(8676002)(8936002)(9686003)(6506007)(26005)(7406005)(7416002)(2906002)(83380400001)(41300700001)(4326008)(76116006)(478600001)(10290500003)(316002)(52536014)(5660300002)(186003)(786003)(110136005)(66946007)(66556008)(66476007)(66446008)(64756008)(54906003)(7696005)(71200400001)(33656002)(8990500004)(86362001)(38070700005)(122000001)(38100700002)(82950400001)(82960400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?z0aqLtKFIy4X2xpEiS9mMQ4+5lLnex6ibca9LtOq2LbE+x1rS/7Sm3dEDZq3?= =?us-ascii?Q?s++E9MprvXS2cnxe8posYjK2HQdLjlVKIj3svAbzaa4qrXh5lkAR9jRdEgsj?= =?us-ascii?Q?5hgwImtAKMv5da3Sf8wlxZTwI7E8We5sqmdIsZWvUnJEjRYvAAXxBBlKxSTk?= =?us-ascii?Q?a0kx3E6PnMEPGTaeULuLhNclZziiz3r1kMtDBYseaGSEHAsYTmfjmJW9iBaO?= =?us-ascii?Q?LV4fc+97zXi0UflD6k5GJECzVIn44omntZlNIQrX0pVEW9qgYeuWI2cufSDb?= =?us-ascii?Q?UpJggbisruSvV8mBvrZBxup1WqoPF/0gEcA0RUXH7iOLAx6dKSHA6I4iAaEp?= =?us-ascii?Q?Ai3n2ocUtzX7veOptz60VGVCPUV3Euzd4wkA9suFpCQ3a6BHF8418LghejCp?= =?us-ascii?Q?9DnK0TsMSUISZD8GhLXyUGPPZvUhDOEIw9kvlyzCTy5z9DofGP6PK/ZQeAxA?= =?us-ascii?Q?Qnla8HHAo0OWugb1TCgYYEi6v3iC33byigPPA4go9Br93v+64BNPC1nf0ELh?= =?us-ascii?Q?vw9oYiCFyzHs40G2atVGmfFaJAGXCNtUmXQI73LQy2Ng5zIOwfHprdvnJejG?= =?us-ascii?Q?pwNSNGGLLqqg7y5UlOB6eA3h8pWWLF5AbWNDn2GSNqfcxry8DmqbTKNJykjM?= =?us-ascii?Q?HY3qvbo8WtdGBnQf0/XW3kp0w8xzDsE58LiYXeAx3OGBcE64WwpYqPxY5TJ2?= =?us-ascii?Q?A/14FLGDw5LuV+QbLrX12rprd85VurwxmnisQDG+UwmV1V9CHSKohVcJgacK?= =?us-ascii?Q?uNmG6ClxtW8pF7cIZpc7KVgEFyUd5kSlW9i5/xAx8YujzU7jgdhiaWFI213j?= =?us-ascii?Q?NKoqX3UOnR4DwHeJfWQR9I9xGbILpo2tKJvp6vjQ1jPGv2F/IiTH/GeKUk4+?= =?us-ascii?Q?ahbJ3Qmpc0eMaNFlSYXYzukhwF+vKVkXUonz3owEGJd+xU97mQ9o8prTUfVv?= =?us-ascii?Q?Q8bHLDP0HokxyGua/lVUiRQgidZM67622lIwbsm/uHsTUXiVeerC6iz9Q/x4?= =?us-ascii?Q?DMu5LVjsZmgxAKClmiO4Ik40w3qsh8CRbO9tiMxqoKDAxcOvIK1MjCro4+IU?= =?us-ascii?Q?mpv+dG9RiNhhXfELN0nLiBZb1g7apAc8rooIQYtJe3dC/0wUoXq9Dmb7jg6O?= =?us-ascii?Q?l2mT3pLhE/Wd0HKNfu4IqKkbCR2q2/CwweWVYq4p22a1G3d4rSMiT9MmzI6R?= =?us-ascii?Q?97sIH2xkKJbfFx1tZTr27sqsnqaW4NAlRbjMyxmL5c7MlN24cklKs+XnA6AV?= =?us-ascii?Q?Dw4y9WXP9VLHPxN7cfUXvWa2Fv6Ky447PEnTkNuQQ7Qsz8vozOHsy5EdiYs/?= =?us-ascii?Q?ri1etBGeiGS9QZIidf6Y2b1zdLGQ3BoRAOty1cMLaleNS4ZbWMiwUm0Cf/hl?= =?us-ascii?Q?3q0nys4JPbDvETnlS6NY1Lj4Xr3vOdld8BIshI8OGXdjgF8rwacr5Q9qREWq?= =?us-ascii?Q?c8P6EsakQXzYroPIQ4yfqSmuvG+Azn5S62l1MYx5pd38qdTHc4Syh5EB86lB?= =?us-ascii?Q?eYMoplvic0qW8BBrqSF6OhrAyouce7msBO/X8f5eBYwstLNJspXyKMYjJVGr?= =?us-ascii?Q?zzhpUKZ2k+j1dZZUiaDplfn3cCDGWKMj+kLy/61gL0UWItLDCS+c/mpteDgt?= =?us-ascii?Q?QA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR21MB1688.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d2a9855f-6ecc-44e8-ad10-08db4eb18117 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2023 04:14:08.4773 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /2wc1Blo+i32hKbcJuYuEh2AjgD9x8NsYa714HHvOCBKIZfz4f2amMVxJ/MZXr5GCi6+eqQjdr7SRGZDqhB3VIBK5fKEPc41CaxMMvYAeyc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR2101MB1330 From: Thomas Gleixner Sent: Saturday, May 6, 2023 9:23= AM >=20 > On Sat, May 06 2023 at 00:53, Michael Kelley wrote: > > From: Thomas Gleixner Sent: Thursday, May 4, 2023 = 12:03 PM > > [snip] > > > >> @@ -934,10 +961,10 @@ static void announce_cpu(int cpu, int ap > >> if (!node_width) > >> node_width =3D num_digits(num_possible_nodes()) + 1; /* + '#' */ > >> > >> - if (cpu =3D=3D 1) > >> - printk(KERN_INFO "x86: Booting SMP configuration:\n"); > >> - > >> if (system_state < SYSTEM_RUNNING) { > >> + if (num_online_cpus() =3D=3D 1) > > > > Unfortunately, this new check doesn't work. Here's the output I get: > > > > [ 0.721384] smp: Bringing up secondary CPUs ... > > [ 0.725359] smpboot: x86: Booting SMP configuration: > > [ 0.729249] .... node #0, CPUs: #2 > > [ 0.729654] smpboot: x86: Booting SMP configuration: > > [ 0.737247] #4 > > > > Evidently num_online_cpus() isn't updated until after all the primary > > siblings get started. >=20 > Duh. Where is that brown paperbag? >=20 > > When booting with cpuhp.parallel=3D0, the output is good. >=20 > Exactly that was on the command line when I quickly booted that change :( >=20 > The below should fix it for real. >=20 > Thanks, >=20 > tglx > --- > --- a/arch/x86/kernel/smpboot.c > +++ b/arch/x86/kernel/smpboot.c > @@ -951,9 +951,9 @@ static int wakeup_secondary_cpu_via_init > /* reduce the number of lines printed when booting a large cpu count sys= tem */ > static void announce_cpu(int cpu, int apicid) > { > + static int width, node_width, first =3D 1; > static int current_node =3D NUMA_NO_NODE; > int node =3D early_cpu_to_node(cpu); > - static int width, node_width; >=20 > if (!width) > width =3D num_digits(num_possible_cpus()) + 1; /* + '#' sign */ > @@ -962,7 +962,7 @@ static void announce_cpu(int cpu, int ap > node_width =3D num_digits(num_possible_nodes()) + 1; /* + '#' */ >=20 > if (system_state < SYSTEM_RUNNING) { > - if (num_online_cpus() =3D=3D 1) > + if (first) > pr_info("x86: Booting SMP configuration:\n"); >=20 > if (node !=3D current_node) { > @@ -975,11 +975,11 @@ static void announce_cpu(int cpu, int ap > } >=20 > /* Add padding for the BSP */ > - if (num_online_cpus() =3D=3D 1) > + if (first) > pr_cont("%*s", width + 1, " "); > + first =3D 0; >=20 > pr_cont("%*s#%d", width - num_digits(cpu), " ", cpu); > - > } else > pr_info("Booting Node %d Processor %d APIC 0x%x\n", > node, cpu, apicid); This works. dmesg output is clean for these guest VM combinations on Hyper-V that I tested: * Normal VM: 16 vCPUs in 1 NUMA node and 32 vCPUs in 2 NUMA nodes * Same configs for a SEV-SNP Confidential VM with paravisor Tested with and without cpuhp.parallel=3D0 For the entire series: Tested-by: Michael Kelley From xen-devel-bounces@lists.xenproject.org Sun May 07 05:31:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 07 May 2023 05:31:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531028.826734 (Exim 4.92) (envelope-from ) id 1pvWzZ-0003R5-Ga; Sun, 07 May 2023 05:31:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531028.826734; Sun, 07 May 2023 05:31:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvWzZ-0003Qy-DE; Sun, 07 May 2023 05:31:29 +0000 Received: by outflank-mailman (input) for mailman id 531028; Sun, 07 May 2023 05:31:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvWzY-0003Qo-LC; Sun, 07 May 2023 05:31:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvWzY-0007R2-Dt; Sun, 07 May 2023 05:31:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvWzX-00020j-5A; Sun, 07 May 2023 05:31:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pvWzW-00039n-Of; Sun, 07 May 2023 05:31:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HIlqPHRtHL47VFKk8YNtI5znvTNRRtXFMkGY9BhOJgc=; b=Ve7ekYQ+1w/uhWd+dsIJL/XD0c /DBY3VBNJj6icdsnXFzF/a2VwcATsE37/oyovP//6IWF5zBlr+8pVJKhkQGWD5MaO8DkS3SwW1+40 z1IcKKU9Zp8TVuXx0AU/zvquLGTDa+K071daer6qO0YNh0b8mvQYvgS45CRh4spl37Qk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 180559: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=792f77f376adef944f9a03e601f6ad90c2f891b2 X-Osstest-Versions-That: qemuu=a9fe9e191b4305b88c356a1ed9ac3baf89eb18aa From: osstest service owner Date: Sun, 07 May 2023 05:31:26 +0000 flight 180559 qemu-mainline real [real] flight 180568 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180559/ http://logs.test-lab.xenproject.org/osstest/logs/180568/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail pass in 180568-retest Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail blocked in 180546 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail like 180546 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180546 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180546 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 180546 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 180546 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 180546 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180546 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180546 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass version targeted for testing: qemuu 792f77f376adef944f9a03e601f6ad90c2f891b2 baseline version: qemuu a9fe9e191b4305b88c356a1ed9ac3baf89eb18aa Last test of basis 180546 2023-05-05 15:15:28 Z 1 days Failing since 180553 2023-05-06 04:39:17 Z 1 days 2 attempts Testing same since 180559 2023-05-06 14:16:57 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Bennée BALATON Zoltan Daniel Henrique Barboza David Hildenbrand Dorinda Bassey Harsh Prateek Bora John Platts Juan Quintela Mark Cave-Ayland Richard Henderson Shivaprasad G Bhat Song Gao Taylor Simpson Thomas Huth Vaibhav Jain jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git a9fe9e191b..792f77f376 792f77f376adef944f9a03e601f6ad90c2f891b2 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Sun May 07 11:59:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 07 May 2023 11:59:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531092.826745 (Exim 4.92) (envelope-from ) id 1pvd37-0000G2-2d; Sun, 07 May 2023 11:59:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531092.826745; Sun, 07 May 2023 11:59:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvd36-0000Fv-VY; Sun, 07 May 2023 11:59:32 +0000 Received: by outflank-mailman (input) for mailman id 531092; Sun, 07 May 2023 11:59:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvd35-0000Fl-Lc; Sun, 07 May 2023 11:59:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvd35-0008Ar-9X; Sun, 07 May 2023 11:59:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvd34-0007h4-PV; Sun, 07 May 2023 11:59:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pvd34-0002So-Nt; Sun, 07 May 2023 11:59:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TIdYIDHKqB1o++HV4yhcdc+czSumHlxqXyHe/W5cOAo=; b=ZACOsW4hQZ9THMGxEtQf2SVZrr vIn8pXgrSOsMrqzfSNFh7fMy2cQcuuJFj5MzHjhtTDvzHZK3U4B0LJVGt2Pmi1I300YMJlodL+zWR bfRDWXl57V+1pLCZ4bgMp9N6ir5EC0qgjDRf+w6VKjrcWlZK42edr2lUGThaubo+Gnmc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180566: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-localmigrate/x10:fail:heisenbug xen-unstable:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e93e635e142d45e3904efb4a05e2b3b52a708b4f X-Osstest-Versions-That: xen=e93e635e142d45e3904efb4a05e2b3b52a708b4f From: osstest service owner Date: Sun, 07 May 2023 11:59:30 +0000 flight 180566 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/180566/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt 7 xen-install fail pass in 180555 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 18 guest-localmigrate/x10 fail pass in 180555 Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail in 180555 like 180547 test-amd64-i386-libvirt 15 migrate-support-check fail in 180555 never pass test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail like 180547 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180555 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180555 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180555 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 180555 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180555 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180555 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 180555 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180555 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 180555 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180555 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180555 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180555 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass version targeted for testing: xen e93e635e142d45e3904efb4a05e2b3b52a708b4f baseline version: xen e93e635e142d45e3904efb4a05e2b3b52a708b4f Last test of basis 180566 2023-05-07 01:52:22 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun May 07 14:45:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 07 May 2023 14:45:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531138.826755 (Exim 4.92) (envelope-from ) id 1pvfdq-0000gf-Uy; Sun, 07 May 2023 14:45:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531138.826755; Sun, 07 May 2023 14:45:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvfdq-0000gY-SD; Sun, 07 May 2023 14:45:38 +0000 Received: by outflank-mailman (input) for mailman id 531138; Sun, 07 May 2023 14:45:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvfdq-0000gO-Fa; Sun, 07 May 2023 14:45:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvfdq-0003Rw-BJ; Sun, 07 May 2023 14:45:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvfdp-00031E-RW; Sun, 07 May 2023 14:45:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pvfdp-0001jz-R6; Sun, 07 May 2023 14:45:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7VZ2pH50TOpI9NMZ5O2TYb8t9mMoa4nUqwN66FTWrvs=; b=heczHIC8KoRSmUcdYnYOfiAKIP s+0eDfFOtBgSrPKx4tnJhiT0V+D1R4t7nBNWF/MUDq5PerZ/rmCK7BXnpSWnHgkdBCWcDGllWXQ8y C7CzhxMaWQirfB7b2q/pEEWTykNyrlcGIeqvEQcqL0sa1iL5VovS/rCRf62wCa3VSlXE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180567: regressions - FAIL X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=fc4354c6e5c21257cf4a50b32f7c11c7d65c55b3 X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Sun, 07 May 2023 14:45:37 +0000 flight 180567 linux-linus real [real] flight 180569 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180567/ http://logs.test-lab.xenproject.org/osstest/logs/180569/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 180278 Tests which did not succeed, but are not blocking: test-armhf-armhf-examine 8 reboot fail like 180278 test-armhf-armhf-libvirt 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-raw 8 xen-boot fail like 180278 test-armhf-armhf-xl-rtds 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180278 test-armhf-armhf-xl 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180278 test-armhf-armhf-xl-multivcpu 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail like 180278 test-armhf-armhf-xl-credit2 8 xen-boot fail like 180278 test-armhf-armhf-xl-vhd 8 xen-boot fail like 180278 test-armhf-armhf-xl-arndale 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux fc4354c6e5c21257cf4a50b32f7c11c7d65c55b3 baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 20 days Failing since 180281 2023-04-17 06:24:36 Z 20 days 35 attempts Testing same since 180567 2023-05-07 02:05:07 Z 0 days 1 attempts ------------------------------------------------------------ 2326 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 283282 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 07 21:49:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 07 May 2023 21:49:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531194.826766 (Exim 4.92) (envelope-from ) id 1pvmFg-0000lo-Pd; Sun, 07 May 2023 21:49:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531194.826766; Sun, 07 May 2023 21:49:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvmFg-0000lh-Ka; Sun, 07 May 2023 21:49:08 +0000 Received: by outflank-mailman (input) for mailman id 531194; Sun, 07 May 2023 21:49:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvmFe-0000lX-OU; Sun, 07 May 2023 21:49:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvmFe-00055C-IQ; Sun, 07 May 2023 21:49:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvmFe-0007Zq-3Z; Sun, 07 May 2023 21:49:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pvmFe-0002dJ-33; Sun, 07 May 2023 21:49:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=kcJ7NMyj4diQqk6DYu3WFsRuJeySkpKqHXq4+awghbY=; b=a9GD9/yJ2Nwn2/1gnYonYA8tBT N3PLBXaePYq72DtvPS0ZYLv1dIz3gTECTlUsuoUH7sRlwGevcdfqYji/mbBmpO9cIPxrtSd4Hg8wE E+nb1ZPXXdDdlAfOLE70+EIA4g0ntm0NEINcdnMQchfSS4OCEFGRAkp+ctP4bVIqhrkc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180570: regressions - FAIL X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start/debian.repeat:fail:heisenbug linux-linus:test-armhf-armhf-examine:reboot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=fc4354c6e5c21257cf4a50b32f7c11c7d65c55b3 X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Sun, 07 May 2023 21:49:06 +0000 flight 180570 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/180570/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 180278 Tests which are failing intermittently (not blocking): test-amd64-amd64-dom0pvh-xl-amd 22 guest-start/debian.repeat fail pass in 180567 Tests which did not succeed, but are not blocking: test-armhf-armhf-examine 8 reboot fail like 180278 test-armhf-armhf-libvirt 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-raw 8 xen-boot fail like 180278 test-armhf-armhf-xl-rtds 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180278 test-armhf-armhf-xl 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180278 test-armhf-armhf-xl-multivcpu 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail like 180278 test-armhf-armhf-xl-credit2 8 xen-boot fail like 180278 test-armhf-armhf-xl-vhd 8 xen-boot fail like 180278 test-armhf-armhf-xl-arndale 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux fc4354c6e5c21257cf4a50b32f7c11c7d65c55b3 baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 21 days Failing since 180281 2023-04-17 06:24:36 Z 20 days 36 attempts Testing same since 180567 2023-05-07 02:05:07 Z 0 days 2 attempts ------------------------------------------------------------ 2326 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 283282 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 08 03:25:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 03:25:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531226.826775 (Exim 4.92) (envelope-from ) id 1pvrUl-0003l0-7Z; Mon, 08 May 2023 03:25:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531226.826775; Mon, 08 May 2023 03:25:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvrUl-0003ks-2f; Mon, 08 May 2023 03:25:03 +0000 Received: by outflank-mailman (input) for mailman id 531226; Mon, 08 May 2023 03:25:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvrUj-0003ki-KG; Mon, 08 May 2023 03:25:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvrUj-0007Xb-BZ; Mon, 08 May 2023 03:25:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvrUi-0002VT-O5; Mon, 08 May 2023 03:25:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pvrUi-0002df-Nf; Mon, 08 May 2023 03:25:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GXWjfL2vJZbr+Zq5vH0Y5UXHwq47bdOLA1raDgHJBCw=; b=Wig8C8yfLXbR9G64jnnoE3ebJX Q9oPHHXwBvOwk3d40MuwfstmXYeV5iAjx9/BjaUepbym3PPS27IPUyaxyeXaN1fLhrCahlQmsd+LD m9Sh+hxIAMPRXcnYCaD/z/u67Yq7yWy675Wz96r5SzlwxO6UWckX8p8j0HUbUHJnciL0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180571: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-qcow2:guest-start/debian.repeat:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:build-arm64-pvops:kernel-build:fail:regression linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-examine:reboot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=ac9a78681b921877518763ba0e89202254349d1b X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Mon, 08 May 2023 03:25:00 +0000 flight 180571 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/180571/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-qcow2 19 guest-start/debian.repeat fail REGR. vs. 180278 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 180278 build-arm64-pvops 6 kernel-build fail REGR. vs. 180278 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-examine 8 reboot fail like 180278 test-armhf-armhf-libvirt 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-raw 8 xen-boot fail like 180278 test-armhf-armhf-xl-rtds 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180278 test-armhf-armhf-xl 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180278 test-armhf-armhf-xl-multivcpu 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail like 180278 test-armhf-armhf-xl-credit2 8 xen-boot fail like 180278 test-armhf-armhf-xl-vhd 8 xen-boot fail like 180278 test-armhf-armhf-xl-arndale 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass version targeted for testing: linux ac9a78681b921877518763ba0e89202254349d1b baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 21 days Failing since 180281 2023-04-17 06:24:36 Z 20 days 37 attempts Testing same since 180571 2023-05-07 22:11:42 Z 0 days 1 attempts ------------------------------------------------------------ 2359 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 296910 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 08 04:09:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 04:09:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531234.826785 (Exim 4.92) (envelope-from ) id 1pvsBq-000051-MA; Mon, 08 May 2023 04:09:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531234.826785; Mon, 08 May 2023 04:09:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvsBq-00004s-Ig; Mon, 08 May 2023 04:09:34 +0000 Received: by outflank-mailman (input) for mailman id 531234; Mon, 08 May 2023 04:09:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvsBq-0008WS-4O for xen-devel@lists.xen.org; Mon, 08 May 2023 04:09:34 +0000 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [2607:f8b0:4864:20::1033]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2235c1b5-ed56-11ed-b226-6b7b168915f2; Mon, 08 May 2023 06:09:32 +0200 (CEST) Received: by mail-pj1-x1033.google.com with SMTP id 98e67ed59e1d1-24e4e23f378so2820130a91.3 for ; Sun, 07 May 2023 21:09:32 -0700 (PDT) Received: from localhost ([122.172.85.8]) by smtp.gmail.com with ESMTPSA id y22-20020a17090abd1600b00246b7b8b43asm16729893pjr.49.2023.05.07.21.09.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 May 2023 21:09:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2235c1b5-ed56-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683518971; x=1686110971; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=N2IiV5e2VeZOoaD5QZ3Kdrzs73EZjFRQz5WCvDTUYTQ=; b=L7ROSK+H7ZSYsOSTbYcv7GKTQOIjgRDDWt0LF9LyA7zPvb1jjZYcG37nzKo4rmxnPQ hNPYJIx/4bYOZB6CBKybMKdZcSFh6O1mWZy4O+/oWnHS1YaUySWNhJg2V0DvGZwMN2RU iW3byJVF5+dOtacAdUcY14b5aSDamahwbgEK5szN7BXvu37jYc25H7LXqUK6uMmvctxJ 56u0RSz1aOeykvTTSFZuChNR7+8fcO7PpJj81P9qHRjgxIh/C1eSmmwIu5DqZUb4E8dY zlZBTnjNF5QZl3HY/PK6ldU697nWVGDoB9Qv1tuF0VVDl73npG3LubwZYH19WQP4X5av YTUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683518971; x=1686110971; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=N2IiV5e2VeZOoaD5QZ3Kdrzs73EZjFRQz5WCvDTUYTQ=; b=dKSGgHTeXu2YZRCPFaVYXb0zItSmiO6mPFxcW9KPps9/K1hroI7d5IMsdq6u+1gM/x 83MAlo5t8YY+L0WpixLFVVRyYRIJGEhfD4K1CbcFtOKwKshnCcl0SA601kEt4/IvU144 1KzSjgNXZkLvYiqS9Hi+o950Vdkdcl0/oqrJ6Atd2b8n1h3/t5TZtD53KBsU9+RcYouD ZaZCTcsI7r7q4M0DQdMrZPGI8it02u8Da/h6323b2lBjzxyCHDKk3/ryxFrwKhaMftu1 unQHlbdqeV3Gdc59bZ3/+IDwWe8xGm46WJjuG0Vq+gPSY9Tdh+0fVr4xEJZjTZMW7TKm ZZLg== X-Gm-Message-State: AC+VfDwFKH4b81FZptpgcQniuithMkhvZSS9r31HuDZQClHK2JjyBfqa wmxzurrpOlUNl7I9ZiOHvxYVFg== X-Google-Smtp-Source: ACHHUZ58x2dVjYWbAJEc7OvaS/dGnIyhye24/cjjOgFWN2/xdIp+Ti0FF7hm+UNLovjV+LqfHUE7pg== X-Received: by 2002:a17:90a:5581:b0:24d:f159:d28b with SMTP id c1-20020a17090a558100b0024df159d28bmr8905534pji.47.1683518970803; Sun, 07 May 2023 21:09:30 -0700 (PDT) Date: Mon, 8 May 2023 09:39:27 +0530 From: Viresh Kumar To: Oleksandr Tyshchenko Cc: Vincent Guittot , xen-devel@lists.xen.org, stratos-dev@op-lists.linaro.org, Juergen Gross , Julien Grall , Alex =?utf-8?Q?Benn=C3=A9e?= , Anthony PERARD , Mathieu Poirier , Erik Schilling Subject: Re: [PATCH] libxl: arm: Allow grant mappings for backends running on Dom0 Message-ID: <20230508040927.uhgwfkhknwyvsowu@vireshk-i7> References: <817f0320316dd144826add0ac834618026b91160.1680165772.git.viresh.kumar@linaro.org> <25fb2b71-b663-b712-01cd-5c75aa4ccf9b@gmail.com> <20230404234228.vghxrrj6auy7zw4c@vireshk-i7> <20230505061934.jm3bwjgsl5hf5rns@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 05-05-23, 16:11, Oleksandr Tyshchenko wrote: > I was going to propose an idea, but I have just realized that you already > voiced it here [1] )) > So what you proposed there sounds reasonable to me. > > I will just rephrase it according to my understanding: > > We probably need to consider transforming your "forced_grant" to something > three-state, for example > "grant_usage" (or "use_grant" as you suggested) which could be "default > behaviour" or "always disabled", or "always enabled". > > With "grant_usage=default" we will get exact what we have at the moment > (only create iommu nodes if backend-domid != 0) > With "grant_usage=disabled" we will force grants to be always disabled > (don't create iommu nodes irrespective of the domain) > With "grant_usage=enabled" we will force grants to be always enabled > (always create iommu nodes irrespective of the domain) I was wondering if "grant_usage=default" can be interpreted by the absence of the grant_usage parameter. So just grant_usage=1 or 0, which would mean enabled or disabled and if grant_usage isn't passed, we would switch back to default. -- viresh From xen-devel-bounces@lists.xenproject.org Mon May 08 05:42:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 05:42:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531242.826794 (Exim 4.92) (envelope-from ) id 1pvtd5-0003LN-DK; Mon, 08 May 2023 05:41:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531242.826794; Mon, 08 May 2023 05:41:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvtd5-0003LG-Ak; Mon, 08 May 2023 05:41:47 +0000 Received: by outflank-mailman (input) for mailman id 531242; Mon, 08 May 2023 05:41:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvtd3-0003L2-B5; Mon, 08 May 2023 05:41:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvtd3-0002sj-4O; Mon, 08 May 2023 05:41:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvtd2-0002hS-I8; Mon, 08 May 2023 05:41:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pvtd2-00005b-Hc; Mon, 08 May 2023 05:41:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=9RK+Icn0wF6vIImiHl2T+zrR/QLLtKOEBpQEINF+IWk=; b=u3YATFJ2c/YsRtORvbNVmk+mM9 9KSCBFzT7xw6zpb5YLqEgDsV/MGaAVRmBx/6c1tYlg/EClT/d6JJwkYn3ig4HTAhi/H1YSXVJzGiC bJtJn5eWmuvl0nIqdci61y1QyAKUGthvUWdu9x3IBnOSf6FGUuSa/I5mSO1+m1/D+6vM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180573: all pass - PUSHED X-Osstest-Versions-This: ovmf=8dbf868e02c71b407e31f9b41b5266169c702812 X-Osstest-Versions-That: ovmf=4dea9e4a0e9db431240434279be9fbe45fd1651b From: osstest service owner Date: Mon, 08 May 2023 05:41:44 +0000 flight 180573 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180573/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 8dbf868e02c71b407e31f9b41b5266169c702812 baseline version: ovmf 4dea9e4a0e9db431240434279be9fbe45fd1651b Last test of basis 180563 2023-05-06 20:11:20 Z 1 days Testing same since 180573 2023-05-08 02:10:45 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michael Kubacki Oliver Smith-Denny jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 4dea9e4a0e..8dbf868e02 8dbf868e02c71b407e31f9b41b5266169c702812 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon May 08 06:24:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 06:24:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531250.826804 (Exim 4.92) (envelope-from ) id 1pvuI6-0000JC-EV; Mon, 08 May 2023 06:24:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531250.826804; Mon, 08 May 2023 06:24:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvuI6-0000Is-BG; Mon, 08 May 2023 06:24:10 +0000 Received: by outflank-mailman (input) for mailman id 531250; Mon, 08 May 2023 06:24:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvuI4-0000Im-PA for xen-devel@lists.xenproject.org; Mon, 08 May 2023 06:24:09 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2062c.outbound.protection.outlook.com [2a01:111:f400:7e1b::62c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eedcf41e-ed68-11ed-8611-37d641c3527e; Mon, 08 May 2023 08:24:06 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VE1PR04MB7375.eurprd04.prod.outlook.com (2603:10a6:800:1a8::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Mon, 8 May 2023 06:24:03 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c%4]) with mapi id 15.20.6363.031; Mon, 8 May 2023 06:24:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eedcf41e-ed68-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z/aV0V46Qv1TyEFYvvoOt/ek8QU/netFTfHpRhbqrfXwQ238f4iCNjWY7wEchUlOzfFaT3JR+A3Sa9A1Q7XOcPvmFhgtY3TXfa77sQsHj1XmLfYVnJ6DKLcajFWhw2BNUBBGLcn4zBfhHLHtzXDYSXk9yfSbVZPyZ2eZc6tGyBuqcqoTA+VFMdIf4s3yFBiIWqPEG+CWUEgdUYL9+ASCsyoI4DHAyBK4QmPG2JmRQAUHrDAObMfl4cltc6I4Zb7bKvw4228azL3c5DDim3izJz7fgoZDsa7cjxWUKKBqe5+g/W4SjORPjwq/QrtUgbq4phhGRTLqfMNB5EXmOGXJ+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JB9+/PxeRHja8l0ODby24uhpNc/UoW2s+UreyHmDFow=; b=g3mr+DdHUyu1CVOxwRFaYVHD6Mot7lga4g4pal5aRZxzPVfQ+TGEZu3BOqXOrbN9dG4oEEVfpSEoPTI9kilvKF0LHlxNsSLU43a9T8KJSxCyHBUGi+MoDF0ZP/FodXBKWd4SH7TLz4c+iF3l+StNZAW/CChHjNFlFKw1prqEXQcQ6kD+NCCin4d6cA9QYQx4xlNF7HuFGjx0MnS5k31ZmLFEznwSHbqpJL9f1Ls26+YJOrMfW81Ch/OwjHHnttHGyOeVYyzCq9db0P2o0Oqo/k3VRLISYPL5EV+qxvvB4ISR60mPDLMgERkKd+OquWMMVBX2nEtTnv4fKo+BfOCWIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JB9+/PxeRHja8l0ODby24uhpNc/UoW2s+UreyHmDFow=; b=GlMtKBdmCW3UqGm72FyAclReVidKOeqmxOA5lmLbwxgZBBLOGVa+NgRzMr7DnoP0wZ+Z+RzhBG8tgeTsRQTag6ld9EFiKOt2X8pEh/40ZrZF6NE6lSRnHY316IbBhiwPw0gqJnW9vrb3Jh52F8n6ViFq259xDtEtADbjKb8wxnNd4Zs0flGxn864+mh5dj6HXEKSQ6RGzR5Ge90HiJs4tFMmXKlJxPKHNjukoFuJNeuqD/bU2Dc8BSkjQ0gNwThlsBJF9IgqTBTRmRi2KqyOtxaiu90tBEvSB085Sxqz0CsKjns0q65p7OGmO4BTjIeNnyz/TV5FwWiAVCq3XtpAaA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3c9f8fd2-b60b-5540-00be-87351fec656e@suse.com> Date: Mon, 8 May 2023 08:23:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH RFC] build: respect top-level .config also for out-of-tree hypervisor builds To: Anthony PERARD Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu References: Content-Language: en-US From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0115.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9d::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VE1PR04MB7375:EE_ X-MS-Office365-Filtering-Correlation-Id: 057f1c76-042e-49ad-7cea-08db4f8cd10e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uIbJH/qmN0hxsQdD4g7cCk9cmhSTFCVePkDzprjbXAkvq8WJ7r2nH/PNR5kC24wsVrJaGOrbtu+I0VUrCeb9uJeWYGY8HugJ1PJKsEyV1A0b/PZpPaFXd6EUSIkj+oJylXGS/G6DNFMD/JxLONHJKx1OXfOLohAvBzFKmAanW/X8cPCFRvcM1dnuUt52FEk9WQ36+lCDOEHUnjYDOSclvArt0FNKo914gmOrPMwbRlb0NTB5mF597AmyoEdPMiUGbokUYYEjJq5vRi1jmVzyN61xLtu0REOpfpYRhr2LPff5yYrThDlfLZmEw1obA6Bdb9+bM0Bo5mxlYmIZLoit3EPe/z+X4wD4koUq9qBqhCNuiucyU/VCKXsxMDj5idYdI60EDsfwwkbtmB9WINMNP2vPBAuqmJPJ/GpIB1j6YeSnNjUT7OMoffkvg4rxrbGQoNfIpBz3h7pVUBiH+Fcv4ek0vYPTJ1z23L1OTlitpXj+/wENVsCWWPfBqfObpUkwskNDyj4xVHBv+4Q5aZQBbaz0hqKfbS9RoiRM6CMDnB/eiHWKWr4FRA3tAe/FrG+6t7SSb04hXSjpG2Fu+APuuXuZJt/flyG/ol2h3lGYh2/QCmw9W+Kt1DFqPCAoNpaToitpqXorSt+dvtl01isGuTH60tKIVsYuXoigTBbys7PFjyYLl684jE7uVbGLPalU X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39850400004)(366004)(136003)(346002)(396003)(376002)(451199021)(316002)(2906002)(53546011)(41300700001)(6512007)(66556008)(186003)(6666004)(31696002)(86362001)(66946007)(26005)(6506007)(6916009)(66476007)(36756003)(4326008)(6486002)(31686004)(54906003)(2616005)(478600001)(5660300002)(8936002)(8676002)(38100700002)(142923001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUttRFNSaG10VjhiY2VHUnYxdDF0TFJIMzQyZjFhNEg0WE1vaTdVY1NtRzYy?= =?utf-8?B?WGNBb3NGSU9WZXptQVp2OFpvTzRhNktDaWxPM3MwbHZyWlV5ekswb3I5U0xJ?= =?utf-8?B?bktVTnJlRjhxZ3lJV1pmWUVkYlBWWnEyaXg4cENWU3M1SUd0S3lJaCtvY2VY?= =?utf-8?B?cGw4aHlCSDFCU05CVllxNC9JYlphZFBMelFKNyt4NFpUU0ZLSHBMcnJlVnVm?= =?utf-8?B?MEZqbVp5bUVHdW8xdVhkK09mbU4wdFNYRGo0VDlxQ0xoYzZSa29BM2p3Qi9I?= =?utf-8?B?NWVMRjd3eTlvajRtcS9oVmcvOGltWlh4TGN6WmlLMGZTL2QrZFdOakpidWhk?= =?utf-8?B?R2NiSFAvL29oL2lPc3psZ1BIeEx0bkVkWnNmYTljK3lIL2kyZXluMEF4Y2J6?= =?utf-8?B?YW9XNSt3TVRPMzJkQlVKaitmYnhVWjBXdWRTVlUyd2haZDlGMjFnSVEwRitJ?= =?utf-8?B?WHNEcnh5eTVHQ1NkOE9FUUVwcStFeEI3b3ovMUtzamhkcC9kUzdZQXVXT1RO?= =?utf-8?B?KytpV2xGSStMbnZGNS80cy9ydEhxVHBjay9yc3o3TVBPczNYMklPaDVBcXc0?= =?utf-8?B?YWkxdEl6NWF3ZzdwY0k2VWZCNEJzS0tZczJsQzhXckFhYjczMG1ZaC9GSHZH?= =?utf-8?B?SWtnNS9qUmtkZmtDdTJIeE1jOERUWVlzY2MrbGJlVHE5bms1Rm0rcm1nSGwr?= =?utf-8?B?NVJmRTBQOWQxYWV2S2g0UHpyU3dhUUh0bmx3Nis3YzNidk15dVg2NHFaMDF6?= =?utf-8?B?aEZLeDFUdEYvdGNvdUlWTnNZZHd3end5TUVodnliZlJYeXJmZ0ZRV05jbUty?= =?utf-8?B?SUtHTlpiSUlhWk1wNXRMdHh2R3ZwVmJmd1cyZ0kzQ2p0S3BTVUtXbXl0ZW9w?= =?utf-8?B?YXFlNEhHN1hraFNxRHZuZmpOZVVvMEtPNGhBbmRGandqanZSYmlhUXRKQnpH?= =?utf-8?B?U3dnLzRiVnNXL3I5MFZUUnVLbXgvQlFWNUlvL2xuTjV6WVhIOWpIZll1cWtV?= =?utf-8?B?SS9JTG5uRXZyOTdDY0ZTc0ZFSG9pZmZjbXM0bzZTTmVZc0tUYzJ4blZzUHZI?= =?utf-8?B?K0pRRlR1cnJZK2RLMTdVUGN4NXlYMHozemRrTmNaeXhETGtjK01hTlh2NTN3?= =?utf-8?B?TkczRlpnNGk0K2NHUi9QdlJDZ0EzSDVPdUUwZCs5SGRHNVorbk9JcVl2d2tM?= =?utf-8?B?THMvMlBFQjM3L0RCaHVhYmpka0VYdzVnemhwZmFWdlBDK2h4cWcxUU9wMGpr?= =?utf-8?B?eW5tZVNKS2h4cVIyc2luZnp4bWxRTUY2UUNmZ20yYU9sTE1IeDE3UlRJYzF3?= =?utf-8?B?eVhlTHZmYW5tUTBvdE5MY2F1Q3h2T3Jsc2NjRnM0SmtNR0ZtaDRPQkpRS09S?= =?utf-8?B?UW1zem1yRFFMSXBVNnF1eHg4VDNiYW9CbmNzUDFENHJzdHMwRHliSUpGcWhi?= =?utf-8?B?by9PUVlRZGlRNGlTWEFJSXl3anNJM3F5K0hOVFNkVis0Ky90OStweCtYOWZ6?= =?utf-8?B?SjNQdm04QUJiRG9qeVJWMnpUbE5GZjhoa1ZkQUJranlkT1ZPcG1abHJRVEN2?= =?utf-8?B?c2NrY1hubS9nQjIvT1NscFV6dGtTTFQvWjI5aUNJTit6UncwV09sOXZUWEtB?= =?utf-8?B?bG5EbHhjYldMaUtYM2I4cjM4Wmw4V200T0wweEllbHhHSXE3RW9JcWIrL0pF?= =?utf-8?B?LzNqb29SbFhQMVg0OGYxaURMMFJRT01kdjlIMGNKdHZpZkNlZ2dvVVZNWFIz?= =?utf-8?B?N2Z0RUlGdmp1M0lDa3RGT240NldON3YyWlhvWkU0dXFNWnpIL0N6Tm1XSVJM?= =?utf-8?B?L2xZc0Q5YUgva09aaGhXTmJWcXRNcVBYYm9jWHd1THp2dnpBRElkZzZ2Z0JS?= =?utf-8?B?YkVDd0FabzIzL2JzREpXRk9ab0dDMGNvZ3FxbTA0VEJCV0RWYjRaSUd5M1NF?= =?utf-8?B?L1oyc1pEUHhOMVpGY2tzVUVVS0FXTGM0dXFYRTYxUkp3bHh3Yk1TM2RQMXdR?= =?utf-8?B?VWs4MTJZSFkrZXNDV2J3bHgrUnRDYUF2OHZabDFFQzZ0MFJ4Tk9Uay9Uck5x?= =?utf-8?B?MmpUaEF5K0JmaThwSk5HNVdDZG9NRkdhblpzNW1HWWwvT1oxdWVRbFNrNUhr?= =?utf-8?Q?rxqvYBnXSpfVb8jE9XDzRwjPF?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 057f1c76-042e-49ad-7cea-08db4f8cd10e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 06:24:02.6943 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: V91gJRFgwlJGW3w/h8jfgC0/wtlGz7NaYYrDfziSLMS7BCTn658Z+xVxII8ZL6Vy+W4uGHt9t2wyBEFh9GXOLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7375 On 05.05.2023 18:08, Anthony PERARD wrote: > On Wed, Mar 15, 2023 at 03:58:59PM +0100, Jan Beulich wrote: >> With in-tree builds Config.mk includes a .config file (if present) from >> the top-level directory. Similar functionality is wanted with out-of- >> tree builds. Yet the concept of "top-level directory" becomes fuzzy in >> that case, because there is not really a requirement to have identical >> top-level directory structure in the output tree; in fact there's no >> need for anything top-level-ish there. Look for such a .config, but only >> if the tree layout matches (read: if the directory we're building in is >> named "xen"). > > Well, as long as the "xen/" part of the repository is the only build > system to be able to build out-of-srctree, there isn't going to be a > top-level .config possible in the build tree, as such .config will be > outside of the build tree. Reading outside of the build tree or source > tree might be problematic. > > It's a possibility that some project might want to just build the > hypervisor, and they happened to name the build tree "xen", but they > also have a ".config" use for something else. Kconfig is using ".config" > for other reason for example, like we do to build Xen. Right, that's what my first RFC remark is about. > It might be better to have a different name instead of ".config", and > putting it in the build tree rather than the parent directory. Maybe > ".xenbuild-config" ? Using a less ambiguous name is clearly an option. Putting the file in the (Xen) build directory, otoh, imo isn't: In the hope that further sub-trees would be enabled to build out-of-tree (qemu for instance in principle can already, and I guess at least some of stubdom's sub- packages also can), the present functionality of the top-level .config (or whatever its new name) also controlling those builds would better be retained. > I've been using the optional makefile named "xen-version" to adjust > variable of the build system, with content like: > > export XEN_TARGET_ARCH=arm64 > export CROSS_COMPILE=aarch64-linux-gnu- > > so that I can have multiple build tree for different arch, and not have > to do anything other than running make and do the expected build. Maybe > that's not possible because for some reason, the build system still > reconfigure some variable when entering a sub-directory, but that's a > start. Hmm, interesting idea. I could (ab)use this at least in the short term. Yet even then the file would further need including from Rules.mk. Requiring all variables defined there to be exported isn't a good idea, imo. Iirc not all make variables can usefully be exported. For example, I have a local extension to CROSS_COMPILE in place, which uses a variable with a dash in its name. >> Signed-off-by: Jan Beulich >> --- >> RFC: The directory name based heuristic of course isn't nice. But I >> couldn't think of anything better. Suggestions? > > I can only thing of looking at a file that is in the build-tree rather > than outside of it. A file named ".xenbuild-config" proposed early for > example. > >> RFC: There also being a .config in the top-level source dir would be a >> little problematic: It would be included _after_ the one in the >> object tree. Yet if such a scenario is to be expected/supported at >> all, it makes more sense the other way around. > > Well, that would mean teaching Config.mk about out-of-tree build that > part of the repository is capable of, or better would be to stop trying > to read ".config" from Config.mk, and handle the file in the different > sub-build systems. Hmm, is that a viable option? Or put differently: Wouldn't this mean doing away with ./Config.mk altogether? Which in turn would mean no central place anymore where XEN_TARGET_ARCH and friends could be overridden. (I view this as a capability that we want to retain, if nothing else then for the - see above - future option of allowing more than just xen/ to be built out-of-tree.) > Or just let people writing ".config" files to handle > the cases in those .config files. I'm afraid I don't see what you mean here. >> --- a/xen/Makefile >> +++ b/xen/Makefile >> @@ -236,8 +236,17 @@ endif >> >> include scripts/Kbuild.include >> >> -# Don't break if the build process wasn't called from the top level >> -# we need XEN_TARGET_ARCH to generate the proper config >> +# Don't break if the build process wasn't called from the top level. We need >> +# XEN_TARGET_ARCH to generate the proper config. If building outside of the >> +# source tree also check whether we need to include a "top-level" .config: >> +# Config.mk, using $(XEN_ROOT)/.config, would look only in the source tree. >> +ifeq ($(building_out_of_srctree),1) >> +# Try to avoid including a random unrelated .config: Assume our parent dir >> +# is a "top-level" one only when the objtree is .../xen. >> +ifeq ($(patsubst %/xen,,$(abs_objtree)),) >> +-include ../.config >> +endif >> +endif >> include $(XEN_ROOT)/Config.mk >> >> # Set ARCH/SUBARCH appropriately. >> --- a/xen/Rules.mk >> +++ b/xen/Rules.mk >> @@ -17,6 +17,13 @@ __build: >> >> -include $(objtree)/include/config/auto.conf >> >> +# See commentary around the similar contruct in Makefile. >> +ifneq ($(abs_objtree),$(abs_srctree)) >> +ifeq ($(patsubst %/xen,,$(abs_objtree)),) >> +../.config: ; >> +-include ../.config >> +endif >> +endif >> include $(XEN_ROOT)/Config.mk >> include $(srctree)/scripts/Kbuild.include > > There's another makefile, "scripts/Makefile.clean", doesn't this would > need to be change as well? In theory - maybe. But in practice: What override might there be that one needs to put in place to run "clean". XEN_TARGET_ARCH, for example, better wouldn't be needed for cleaning. Furthermore the top-level .config hasn't been included there either, afaict. Jan From xen-devel-bounces@lists.xenproject.org Mon May 08 06:33:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 06:33:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531255.826814 (Exim 4.92) (envelope-from ) id 1pvuRA-00022v-AB; Mon, 08 May 2023 06:33:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531255.826814; Mon, 08 May 2023 06:33:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvuRA-00022o-7a; Mon, 08 May 2023 06:33:32 +0000 Received: by outflank-mailman (input) for mailman id 531255; Mon, 08 May 2023 06:33:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvuR9-00021T-3a for xen-devel@lists.xenproject.org; Mon, 08 May 2023 06:33:31 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0624.outbound.protection.outlook.com [2a01:111:f400:fe0e::624]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3f187d1a-ed6a-11ed-b226-6b7b168915f2; Mon, 08 May 2023 08:33:30 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7399.eurprd04.prod.outlook.com (2603:10a6:10:1a8::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Mon, 8 May 2023 06:33:28 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c%4]) with mapi id 15.20.6363.031; Mon, 8 May 2023 06:33:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f187d1a-ed6a-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZWJ/AxrNZ0y+upsEEMLi6SG/3eIDfw+64OzzdTCKJuhAiH/dEwrIH2b1JT88ScPGyh7JbKPLVJh69W9ev0Qw544r+bFGZCbgVMdQyNuPZu/4Yb5gblwb+oFIgqXHzk9DY04xAH1Z6fe/FLtu9l/znsfWZFq/c6Btq1KbI6xk5NeTU3uA9wKySSy4LEMLmz+rv9tqAtQDIDePsHZU+MxD7Ud4GEaetHQ3oOQqxMDMa0st/6+w+o0bz4DmzROOPm50ccP3hKbjLlU470lv24rLthiSn1Vp847166PNQVx7wqMu38vXgpiOi4xh9MaD6mC1LVJfRpnePxAShqXMz18m8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9c5O7KY9QSWascfGNjL6Q66F/DwxuFFAclnLFTBRS6Q=; b=axo79+BPAmJFVE4KYOd3e1IHJhDfFCWX/lBlAMTi4cvWIgggpnwhb6u30/S6WHWDoqSJuLgdU6Oevbmh7oCWOCKuF7OZYevXpI/y4rkxqlCNA1VNXSfQzXRzw5VTnv1qHvwqUyKaLSZEywFv9B/gl3w694AlQ7FLQixTSxdeUHIJT3LBVJZlVIym63POBVb/Fllw4KEyw9cKyPZcwylPwD1woKb/eUXzoEhzu3xpsIgAXcQ134cKBnl/LXUNaSy0B+06WsRnZ1pAEt5oPYeQI54j054pCyeXCClrr18nzZWXv18iNUH4tGiA7jssqVYAIwXZ2gOFCcK9G613urHdvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9c5O7KY9QSWascfGNjL6Q66F/DwxuFFAclnLFTBRS6Q=; b=a2dG1uxhVIT0MSURjh9a+JmR83A/8TFzfMeY1DSdsHlG8UgJMO26Ji2ND72SEH2c7bz2mAB9/o7TsdC15vkzWuO3NypQ+m9H2WlvrFfHTM6tehFoq75fVwd9BkO38zHLNTolxNm0dAkAraWmin2t/YHGkgTXaqOi4ZrtbohEMsVb/uXCszd6xc412xrGQsrSp4r8u5gRub+4+pwPIQjuGFOMtRxD/sVWNtbayl9r3+D0Ti3IuQdhriv0l1JnJ425M347KgqHhaF6XfmlKR5McnBtDeFf62EGez5InBXEVp3fGUgEQL6I0P9lkqkufZbuiGnaXA+naB6HAFxWMvwu5A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4bf60ae8-7757-7440-1a4c-95260c0f0578@suse.com> Date: Mon, 8 May 2023 08:33:18 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3 04/14 RESEND] cpufreq: Add Hardware P-State (HWP) driver Content-Language: en-US To: Jason Andryuk Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20230501193034.88575-1-jandryuk@gmail.com> <20230501193034.88575-5-jandryuk@gmail.com> <43c519f7-577d-f657-a4b1-1a31bf7f093a@suse.com> <7921d24d-7d4d-8829-44bf-b8c2ecd001c8@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS4P190CA0043.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:5d1::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7399:EE_ X-MS-Office365-Filtering-Correlation-Id: 28a6ff3c-ef62-4532-8175-08db4f8e224b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YD+lO2PjHBs9ZsWhTnLA1UyK91pClsJqNHVPwnSulhSA8+pBImeapAuLKtJyGDELsnbhvrrt5n82Aj6sPl3V2AYxt44bvpq4uX7mHBe2+KId4ISkO5ZnONvTbrJXsKOHK2y0HSk+rHuFhlJRP9l7WJm21hKExXg+F7RJm4r2Gxykz4sa9B6/r8Kq3nL58EAucJv16xwyeSgQ201QGeKIj7niGjMK0p+onZEnoCy6nEjH13/1hjMpsXKh8uVjRTdDpFQ2DRsLHSmTib0YlClLG2qYOj9tuMt/ybYfo2hlPZ56/xPhBiJV6/sBvwRRWDYCy9DSJrCc2aWcPJr+qRRC8LWBZxn40NYCV1s0MKeXuErX5fxzfcFx/tkrgDhqYopmHbPDZR138QzGDz4QHgSGM9VReFOtMv9gQR/hN8YsvhZ1RVi1IawrZaBKPAO5jFYksulgmfWlmATVP3AMJFw46iZs4BN5kmCYnlNZsKfvxiOe5K/LAju9qGWy0TI40uf2jqr2i5CHJhIgcvxiWOaFgkMQIsFPhbNUogs6ZP/1VUymbWR4IUGogKpJssOGmtt3IijuvFFzCGSsfpoTq+LY5IuwWrgoE7UjpCim0UsQpC7MV56UilW67wAdM1kJgHjtHBjVktNsJYPpeoC5g8jWPQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(136003)(376002)(39850400004)(346002)(396003)(451199021)(31686004)(478600001)(54906003)(2906002)(8936002)(8676002)(316002)(66476007)(66556008)(6916009)(4326008)(5660300002)(41300700001)(6666004)(66946007)(6486002)(6512007)(6506007)(53546011)(26005)(186003)(2616005)(36756003)(83380400001)(38100700002)(31696002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d2NEN3A2c1VnVmxaQlJCWTJVWWwrSjU4MEJqckxsN2h6cnB6TGJQRnBndXFn?= =?utf-8?B?ZFJXQzVDdDU3ZVV4YjYwVkJhbERPYjY4a1FDanpxOTA0SkJ1N0V3b2VGZWRn?= =?utf-8?B?K2RSb1Y4VEJDWjV5eXp6V3JYU3JwNVNocGdEdmtXaTZUMUFwQ0tsNlVKd0Jx?= =?utf-8?B?emtqbzBQUU5hZ1RNcytJS3UxMWZsclg3VGtBRkFEUnUyUDBSK0FWR3RwRzJ6?= =?utf-8?B?VzhiRlU5RUpxVWFBMWhwYkFDWFVnR2ZmQWF6MlpkWU13S2hMZ2JuZDAraUV1?= =?utf-8?B?aEpIaG5teUN6REpoVFN0L09oeFduV2psNHc3TW03VFNrR1hDb1hDaWhreW1j?= =?utf-8?B?U2xaUXBWazZEa2t6Y0F2bkVlNi9Ycy96em44ZnRIMnBZdVA1c2krWEtScEN0?= =?utf-8?B?cHVVRGxVVU9oVngrT3lYdHhLUU8yS0lFQTZNT2NnY0JRQ3hIMW5hRytwY0ta?= =?utf-8?B?TnVOVFZNN2pqTXZVMDZZREFucXhUdnROK0VNL1ZyWnIzbVNkK1Z0a2p5am1J?= =?utf-8?B?RTAwdkg5RDFCRHBqczBaUkUyM01rcVlmYzZtNm9FdkxjamJEc1RPMnVLdlpp?= =?utf-8?B?YXlKY3YyYWQzSUtScnNHR3ZleGhMRytrZlNmdzhkUzIxVjVnUmpheHVROWp4?= =?utf-8?B?OVhLKzJwZFJLZGc1ZzNBN0ZtZ2xRTW1oNFV4Z0MzQ2VSYmd0WmFRN2tLQklG?= =?utf-8?B?TkZOOUsvSEliU1RqVGR2ajcvdkhrL1hNM0hIUzc5bnNvMUJhRy8wQ2FpdnFq?= =?utf-8?B?eXN1MzROcUduWHVvSFhzYmV0cndQWDN6QUVhUWQ2dllTNzhQU25TQlRpWkhN?= =?utf-8?B?UmE2d205aDFGa3U2UGNnYXZEeDFzT1RhQ2FRbEdwRG1tZzg4cHVRS2JtWlVx?= =?utf-8?B?RGdrVllWOWZBTVRyR3VMSFdhdDdkaXdHeXI5ejFqVitzM2xtQWkrTlFZNzFB?= =?utf-8?B?dmQwTUVwRE14WVBrcXZJS0hSWnh2ajlkV21ITjE4UmpGSnlzMXVCZ0Qra0N6?= =?utf-8?B?UEsxSi9CU051Kzd6NFpJazM0SHlIb2NPWGR3WHVMSWw2WWN3STBzZ3BHQjVR?= =?utf-8?B?Wk9LSTd6dEtUNitHTFpqTGJFM1plVDdtUHJNMVphMEMreUVTclR1SXNMcDJP?= =?utf-8?B?a1lqMURlNnZhUnFpQm00OFlwY3Jqd3A2ZDdYa2tIc1hqR0dHU1YzME5vSThx?= =?utf-8?B?TXFsb2hqb3R3a2lzTlFacEN4dlVTeEQvU05WN004SkVkUHpyRnBLN1N5UEUx?= =?utf-8?B?bDlqOHF1T0VMMXFoeTloYTZBeFlpQ1Zzb2RCOGt4cmd6N2xVM0l0MWtqK1M2?= =?utf-8?B?cEJqMXBMcWI2OWJMejh2aHhlOVF0dGtsVm1yM3lCb2ZrUlhhcUZCOC9pbDV3?= =?utf-8?B?bVFJMlFuRngvSkl2KzFtdFlsa2JOeklkZzhkeTAwajlHekEvdVBrdktrTk02?= =?utf-8?B?aTl3b1V5WmphS3d5UHZhYzd4MVZuYVA2akZtUU10MnJyOGFueFdNSEZDS1Y1?= =?utf-8?B?bHNESURMTG1QTU1jRTBWbkRZWGZBZ1hQM3BFdWZLdFAzdWhPQTlZRWpxendJ?= =?utf-8?B?Rnc3eDlBZjRMb1lCazY2NTVqeEFwbWEvYlBzWW02emFoSmlVTnJ4bGxCZmE4?= =?utf-8?B?UWJhdHNxYXU2dlhvSDJ6S0N3UjN2aXFXVFVPa0hodElZYThjemd6QVI1VEJh?= =?utf-8?B?Ti9CRERDRTd3MU9NQk45MHFYQmYyRHYrUlF4K2d0UlBZMEJQc1RVRWJVRVpV?= =?utf-8?B?NWNnUExyWVh5M1diZzdkU1hlTThiLzQyTXhHNk1YUmQ2V2IrOXFTcUVGM2Fs?= =?utf-8?B?TVNNYzFINHFDREYvWk5hbFR3bHYxY0FXR0U3TFQvcWZiYUo4bEM2U1FHWTB0?= =?utf-8?B?dFZId05XV09lQXRsdTNPNmhtOVVxTjRIUGRVdS9iOWMxdVFiS2xWU2JwdDZX?= =?utf-8?B?Z28yTlVSOW1mZC8wYU5xNHplSHlVU1pGeGtQUnNud2pXSWhTN0x6UjVqNW52?= =?utf-8?B?Nlp4U2xVM2NnVDZMVHkyNmt2Yng0MW5ZMmo1ZytHNUZwN2FWMEk5WmJSZmYr?= =?utf-8?B?dGtTZE5yMmVCbmVjNFN2d09ycEdHUzBkNSsyaXFGWEVSNzZGcmc2NzFTZXdT?= =?utf-8?Q?U7V6ayHzUQIjQ5qVq2tPY7gMy?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28a6ff3c-ef62-4532-8175-08db4f8e224b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 06:33:28.4321 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YMCw4J6PcPUFk4QI3R5EdliN2OwHAYkJFex9Hvwn0FJM/wgW+8Xkxc41C4JWWBlNM4ttY4rfpmNumB26m+3zGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7399 On 05.05.2023 17:35, Jason Andryuk wrote: > On Fri, May 5, 2023 at 3:01 AM Jan Beulich wrote: >> >> On 04.05.2023 18:56, Jason Andryuk wrote: >>> On Thu, May 4, 2023 at 9:11 AM Jan Beulich wrote: >>>> On 01.05.2023 21:30, Jason Andryuk wrote: >>>>> --- a/docs/misc/xen-command-line.pandoc >>>>> +++ b/docs/misc/xen-command-line.pandoc >>>>> @@ -499,7 +499,7 @@ If set, force use of the performance counters for oprofile, rather than detectin >>>>> available support. >>>>> >>>>> ### cpufreq >>>>> -> `= none | {{ | xen } [:[powersave|performance|ondemand|userspace][,][,[][,[verbose]]]]} | dom0-kernel` >>>>> +> `= none | {{ | xen } [:[powersave|performance|ondemand|userspace][,][,[]][,[]][,[]][,[verbose]]]} | dom0-kernel` >>>> >>>> Considering you use a special internal governor, the 4 governor alternatives are >>>> meaningless for hwp. Hence at the command line level recognizing "hwp" as if it >>>> was another governor name would seem better to me. This would then also get rid >>>> of one of the two special "no-" prefix parsing cases (which I'm not overly >>>> happy about). >>>> >>>> Even if not done that way I'm puzzled by the way you spell out the interaction >>>> of "hwp" and "hdc": As you say in the description, "hdc" is meaningful only when >>>> "hwp" was specified, so even if not merged with the governors group "hwp" should >>>> come first, and "hdc" ought to be rejected if "hwp" wasn't first specified. (The >>>> way you've spelled it out it actually looks to be kind of the other way around.) >>> >>> I placed them in alphabetical order, but, yes, it doesn't make sense. >>> >>>> Strictly speaking "maxfreq" and "minfreq" also should be objected to when "hwp" >>>> was specified. >>>> >>>> Overall I'm getting the impression that beyond your "verbose" related adjustment >>>> more is needed, if you're meaning to get things closer to how we parse the >>>> option (splitting across multiple lines to help see what I mean): >>>> >>>> `= none >>>> | {{ | xen } [:{powersave|performance|ondemand|userspace} >>>> [{,hwp[,hdc]|[,maxfreq=[,minfreq=]}] >>>> [,verbose]]} >>>> | dom0-kernel` >>>> >>>> (We're still parsing in a more relaxed way, e.g. minfreq may come ahead of >>>> maxfreq, but better be more tight in the doc than too relaxed.) >>>> >>>> Furthermore while max/min freq don't apply directly, there are still two MSRs >>>> controlling bounds at the package and logical processor levels. >>> >>> Well, we only program the logical processor level MSRs because we >>> don't have a good idea of the packages to know when we can skip >>> writing an MSR. >>> >>> How about this: >>> `= none >>> | {{ | xen } { >>> [:{powersave|performance|ondemand|userspace}[,maxfreq=[,minfreq=]] >>> | [:hwp[,hdc]] } >>> [,verbose]]} >>> | dom0-kernel` >> >> Looks right, yes. > > There is a wrinkle to using the hwp governor. The hwp governor was > named "hwp-internal", so it needs to be renamed to "hwp" for use with > command line parsing. That means the checking for "-internal" needs > to change to just "hwp" which removes the generality of the original > implementation. I'm afraid I don't see why this would strictly be necessary or a consequence. > The other issue is that if you select "hwp" as the governor, but HWP > hardware support is not available, then hwp_available() needs to reset > the governor back to the default. This feels like a layering > violation. Layering violation - yes. But why would the governor need resetting in this case? If HWP was asked for but isn't available, I don't think any other cpufreq handling (and hence governor) should be put in place. And turning off cpufreq altogether (if necessary in the first place) wouldn't, to me, feel as much like a layering violation. > I'm still investigating, but promoting hwp to a top level option - > cpufreq=hwp - might be a better arrangement. Might be an alternative, yes. Jan From xen-devel-bounces@lists.xenproject.org Mon May 08 06:48:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 06:48:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531261.826824 (Exim 4.92) (envelope-from ) id 1pvuf4-00043H-Mn; Mon, 08 May 2023 06:47:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531261.826824; Mon, 08 May 2023 06:47:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvuf4-00043A-K8; Mon, 08 May 2023 06:47:54 +0000 Received: by outflank-mailman (input) for mailman id 531261; Mon, 08 May 2023 06:47:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvuf3-000430-Vi for xen-devel@lists.xenproject.org; Mon, 08 May 2023 06:47:53 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20627.outbound.protection.outlook.com [2a01:111:f400:fe12::627]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 403e2d84-ed6c-11ed-b226-6b7b168915f2; Mon, 08 May 2023 08:47:51 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS4PR04MB9623.eurprd04.prod.outlook.com (2603:10a6:20b:4cd::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.31; Mon, 8 May 2023 06:47:48 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c%4]) with mapi id 15.20.6363.031; Mon, 8 May 2023 06:47:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 403e2d84-ed6c-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cjdfPY20SLys+79uzy3JuzD8RelYB5oOUxnczN5aaF+OC5Zjp4V1L+inrdUIYfrUT10AaczZ9PKuePmBF9PbwHOFCUuu0fh8NPOHSLO9GWPWm+OwiTGZceP/qhEbHZqhfFLFBKd2bYw6n+PlqgONYsb2xpG7MaGLlUY1VB8+GcyghbMKfMgF878cuAaqJ6PY81K0VaGMEGyPLpgUNBq05c8OO4M55851OeF/9y/zjVNRFEz0bkwFAUdrbsRtXRgemrBDYypjRV8G6QSJuG/ZnpJU8LA91HRL1QwnUt65ZAKQPVcbVWvdr+0wzRrYSgwDUNIRN01KMJpi0AMfKUIT0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hchJlrRfsacPsTKLPlIoSqERfo9BbLE4ltWKo+IyKQ8=; b=aSXOvM5spfhFIAM09Ja0glGPauzTxC8hi/F9Buual1tDZDIztCbKSGK87lqTyVo+NxlqgpeQ0f0mS2jhgeASWPk/TVcotsiJ5W+iudKtpOqEZeopIVKyHFni2cpOun6Kts/2WZXllTlSSnRsqf+JnpjQgDLVtbNLHoO1MVwxjKvdeYW+820wVRhFx80AGc4eZWGBIf1QtQt/EiSmsA2xTVdM47cO5uJxCOcrPJYB7BX9kQInTXoRUPFn/5vg+OwVe9z/DOeQAnTjtMMmzCa/P8SNq6je+P3psGoO4aSlH95kqIqQxJQUrXg38G15E6FrbdAPhEx2X4rLsvf0zVBuaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hchJlrRfsacPsTKLPlIoSqERfo9BbLE4ltWKo+IyKQ8=; b=PF20BQpSyzuHJoYoh5p2Fy0TArJfXzqUhjG4nUVX5pFJ4mG9IERCg5rMgKWzNF1y+m5t1rrCm4TFarFqaAwJe5uhagk/lfBDclcs1ZWmKdZIgYilEAzXKpsbZ8D7GrKbWu43fpup50Egyr7iDWVMXQu6vc3cZDt3YsHD3whzM7xmCPJI+SDOXXhDQdvmtJ2KHEykuGGcd4PJvdSJuL++rr0CcFg7MXdVtHtHON+uM5Y6ICpfocOowgd6TEfnRYAD8uescPt4Cyt8HRYSp3jmjT/4Y8pgL0wOS2OiyuyqoKNwxXpVFUJkGqSaK9Gx7WbXQcxLADK4hzxgH1U+sn9YpQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6531df09-7f7f-a1e2-5993-bd2a14e22421@suse.com> Date: Mon, 8 May 2023 08:47:29 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 1/6] x86/cpu-policy: Drop build time cross-checks of featureset sizes Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230504193924.3305496-1-andrew.cooper3@citrix.com> <20230504193924.3305496-2-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230504193924.3305496-2-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0109.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS4PR04MB9623:EE_ X-MS-Office365-Filtering-Correlation-Id: 298d4b9b-2929-44db-5210-08db4f9022a8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LLwvp3bhhzoSJyM4/CCY1voqXA/qHlj2l/0oe1TuCeEm2HLr0q6vyf1d1u4gyYdtdZTLa+Wkz2pMZMKrFzqzVzvQDSfpvEO1OgByqTWbwl0mn6KIzy8fSzu8s6fCbu7SVwcWMf2wAecBXM19nXUZGHN1H+3oUZOYVljJW7p/QKcPzYlurAD05mDS/nOC704sStkWPNtvWoHlv69Y3DvdLOv6y3B10vh1BTl5HtKvJ5LjYHF+r7M2wOjfh6coDh/TB5MRl5XGom3LN5CEzFbBCRTWzuxO1MWDcMiQy9JTDcLEm9wVO61eB4Dy/ObeyBmAMQYylsEBMBXQ/Sg9TTg7urhlw2CMPXEW+AQg2DVjdB1WAFQjmic/yWK5/V/sXkdBDMN9UX7iHE6TQ+AJNUZ0Bdq5o/EP7e5je7vdUq36ssIyZCdQPG8IChnuEOk+U74JYOO7uhYAXO3dOVzR0l6LVRi2lzCywXpvw8VCvcAHbKhbQC+oHavyD8WQ1d4jmCwNzkWGyNqW2fO+OPCqaU9JW8CnqD8GRoy7TRrBdKHs01QmkO8WqpIN+YQup+cWY3uTfxgFmcI27nrrCm9UMsZ7vrg1HILu8tugqI5/TTOQLKDM1242fLKVbW/7hxKlaPJpcAyF4A9rIEYtHMalsijrRw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(39860400002)(396003)(136003)(366004)(346002)(451199021)(31686004)(36756003)(38100700002)(2906002)(8676002)(8936002)(5660300002)(316002)(31696002)(86362001)(66476007)(66556008)(66946007)(6916009)(41300700001)(4326008)(83380400001)(53546011)(186003)(6512007)(6506007)(26005)(6486002)(478600001)(6666004)(2616005)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?elhtQXRneHAxMzNIdStTNzJwQ1M4YkRPQkROOUd6aitTYml5OHZaNzYyek9Z?= =?utf-8?B?b0VWT0RKeHduOWZVZVpFM1RQTjkyY241U25jSDIzK1JTNENuSVA3SWtLYi9V?= =?utf-8?B?T2JQa216Sm9mMW5HSXVJRG5pWWdZZWpzUjNiOW9GelJYWjN5OEN6WjcwYnZh?= =?utf-8?B?R2t5S2gzVDViOEkzdVJSc3lZazYwaDNqV0ZjVDVzQ2ZNZy9pY3BIY3dmdXg0?= =?utf-8?B?aktCT01jNyt6WnhIdXJkV0sveis1eWt4d09MSlVLR01yQ3dhZ1cxVTVBRWg5?= =?utf-8?B?dkFNRXFzeEZYcWNwU0lXZUQwQ0RkVGVyeE5DMUxrSkhyWkhUS1lvTDRGb25r?= =?utf-8?B?OXhzN3ozRVRtRTN3K0VBK2NsUkU4eUJzeXdkVHd5RklIYXdDOVVmWVNucDBa?= =?utf-8?B?azlWaGNpOGhGU1FVb0R4Qm5zQ1ZiNWwzQ1kvc2NrdnpqMXZuZlJaTTNMMkdy?= =?utf-8?B?WndZZXdQdE90SnRJbFEweS9yZHg1aWxvV3RaV2N4TmMwNGFyc2tPdEZrTGpO?= =?utf-8?B?QVZnemN5bnFqdGpOcEc2OTk0ZGYvaWJXV1hqaFFqZUVtSy80Q2txWDdsU1hY?= =?utf-8?B?N2pJeHpycDJMeHVpSTB2Vm13U0NyM3BLaEp5VlJnSWdPTjRtY0p6Ylo1Y2Zx?= =?utf-8?B?RmpkTDV3cDROdFgwK2R2aFNnYis4cnJ0OUFFWUwwais1aE9EdzIzc0VKa0Jk?= =?utf-8?B?eVplc2hvT3hXVGI2YjlsZkZmWmNsYXQxaExjK2kwSHozaEoyc3oxSGNTV0pz?= =?utf-8?B?N3cweWhqZWxSc2wvcWpMZjA5MDc2bkVxa29HTk9CS3kyQXhMVW4yYUdHNzlH?= =?utf-8?B?Ty9PdG52YmlUQzl6eXZoK3F1UnVxY1NLQS8yRlBnQ1RKeUZ0SVJtVVpncjJB?= =?utf-8?B?NmxzR3M4RzFvV29Iam85WVZ2Zi85c0MvMzdFWmU0ZGlUSUpYMjRlOVA2S2Rn?= =?utf-8?B?SmgzdnFWWVhPL1liUXVtK2FZbHcvVTF4TUhteEVVVHZTN3pBMWtKZm5FKzYx?= =?utf-8?B?YWM0VldKaC9zRGJyVDBieHVkMVo1dkxHeUZ4QlRJZmk3QVFEenRMbFlGZVVJ?= =?utf-8?B?cEtnMEF4c0laVDJEd0VkVGJqM2hBU0g4Yjd0QmhTbWpiMUhJbkRuUkdOOWM3?= =?utf-8?B?UFhLMDVlUlEvZlVkc0RDUENCTDR1TUpkakhsakkzTmVibUkybm9hdTd1K3Jz?= =?utf-8?B?SU9Oc0ZiTm5CdjVyUXBxWGZadVc2b1Y3WUJDWVRaSHBpSlJma2RUTGw0dy82?= =?utf-8?B?NzZab0JyT0psdUwzRVM3VkVRdHFMVC8zRkU0MEgrY3JVV2VsVldPS05NT1N3?= =?utf-8?B?aHA0WVJyeWFHMHBVZ1FGeUlmc3A2Skw0VU1hKy9VSjI1YWRkcjIwM3BSM2ZS?= =?utf-8?B?bDRrbkp4TngrT1JqMHZxRzhrWVl2dHliMGRZZXJCYWdtSStFcmFtWjc1VzFj?= =?utf-8?B?Q2NyaUJtbUluRitKVy9YdGlqSTR2MzcvcDFGaGd0cW4xMExTNTRkeUpPQnhF?= =?utf-8?B?Y2JSeS9rTlhZK1FJU0lmamVSSVVpWkFqaU02M0hxYVdQcUorNW0zc3ZYUTl0?= =?utf-8?B?ZGlISi9vR25EcmM5aXNQcFQwSStLUXBTMlNJUkFQeUZ5Vy85R2lqRFA3UDUr?= =?utf-8?B?aWFDMWZZUVN3UFZ0SkF5Z1FUdUdEL3k4Um45TXNWaEVnZEd1ZEZaRWtHUlRy?= =?utf-8?B?K0Fob2hxYTVsQTkrL0VJVWxLVHVudUExMEsrWEV0T3A4RmU3V1pERmxZWUgw?= =?utf-8?B?YWkwbldCOUhHVUdRb0k2RTAvajBacG1BU3FXRjJrL203NVNMV0tObkU3cHkx?= =?utf-8?B?VWhtdkVJN1dqWHdqV0xhUTdXSG42MlRSOENkR1l6czBFRjNzcENYRnROMGtu?= =?utf-8?B?NWxPUmV2cCt6T21PSFpwM0owSjVVVHVXQkw0NnRDSU00cXNjMnAxeXpZQ3Nj?= =?utf-8?B?ei9xTlA0bCt0dmlFTjI4Z0NobGJQdkh2d3liek1vb0RyOWl4WCs5OGJ6M3BB?= =?utf-8?B?MzZtV3hla3Y2MGlJRFViQlcwNlB4TmR1OW5tOWR3Vzc4V1YxVEUyNldnNjBY?= =?utf-8?B?YVNscm1hREp1MFRLbVVwcmtsMm1BM0lUSktVWi9aNVgrSWFEL3ZLd080WjJZ?= =?utf-8?Q?QLPt32wgi/bsQR2f+yiwE5Eut?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 298d4b9b-2929-44db-5210-08db4f9022a8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 06:47:47.9399 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /kUS8EGBWpyBLQKRCwrqKTAQ0ANF78njD4hEgCFMF/4NigqJ2E7hxx3gCbrY902teLkGuJCzYGPb+zFHKHGI2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9623 On 04.05.2023 21:39, Andrew Cooper wrote: > These BUILD_BUG_ON()s exist to cover the curious absence of a diagnostic for > code which looks like: > > uint32_t foo[1] = { 1, 2, 3 }; > > However, GCC 12 at least does now warn for this: > > foo.c:1:24: error: excess elements in array initializer [-Werror] > 884 | uint32_t foo[1] = { 1, 2, 3 }; > | ^ > foo.c:1:24: note: (near initialization for 'foo') I'm pretty sure all gcc versions we support diagnose such cases. In turn the arrays in question don't have explicit dimensions at their definition sites, and hence they derive their dimensions from their initializers. So the build-time-checks are about the arrays in fact obtaining the right dimensions, i.e. the initializers being suitable. With the core part of the reasoning not being applicable, I'm afraid I can't even say "okay with an adjusted description". Jan > and has found other array length issues which we want to fix. Drop the cross > check now tools can spot the problem case directly. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Wei Liu > --- > xen/arch/x86/cpu-policy.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/xen/arch/x86/cpu-policy.c b/xen/arch/x86/cpu-policy.c > index ef6a2d0d180a..44c88debf958 100644 > --- a/xen/arch/x86/cpu-policy.c > +++ b/xen/arch/x86/cpu-policy.c > @@ -883,12 +883,6 @@ void __init init_dom0_cpuid_policy(struct domain *d) > > static void __init __maybe_unused build_assertions(void) > { > - BUILD_BUG_ON(ARRAY_SIZE(known_features) != FSCAPINTS); > - BUILD_BUG_ON(ARRAY_SIZE(pv_max_featuremask) != FSCAPINTS); > - BUILD_BUG_ON(ARRAY_SIZE(hvm_shadow_max_featuremask) != FSCAPINTS); > - BUILD_BUG_ON(ARRAY_SIZE(hvm_hap_max_featuremask) != FSCAPINTS); > - BUILD_BUG_ON(ARRAY_SIZE(deep_features) != FSCAPINTS); > - > /* Find some more clever allocation scheme if this trips. */ > BUILD_BUG_ON(sizeof(struct cpu_policy) > PAGE_SIZE); > From xen-devel-bounces@lists.xenproject.org Mon May 08 06:55:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 06:55:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531265.826834 (Exim 4.92) (envelope-from ) id 1pvumP-0005nB-Dh; Mon, 08 May 2023 06:55:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531265.826834; Mon, 08 May 2023 06:55:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvumP-0005n4-B9; Mon, 08 May 2023 06:55:29 +0000 Received: by outflank-mailman (input) for mailman id 531265; Mon, 08 May 2023 06:55:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvumN-0005mx-Sq for xen-devel@lists.xenproject.org; Mon, 08 May 2023 06:55:27 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20620.outbound.protection.outlook.com [2a01:111:f400:7eaf::620]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4ff77995-ed6d-11ed-b226-6b7b168915f2; Mon, 08 May 2023 08:55:26 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7351.eurprd04.prod.outlook.com (2603:10a6:10:1b2::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Mon, 8 May 2023 06:55:25 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c%4]) with mapi id 15.20.6363.031; Mon, 8 May 2023 06:55:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4ff77995-ed6d-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UEy0RALmbGAB2alOZ96cfOKjYLBmaJMbhZLd4zkShaRW7sx7YPzsa6UGPZfCgBV7yYn8PxaC/MiWVE8jWLv0YfKmlVau817fixqvwfw86tYf7d4pcJQ8iG4XYqxd0XGngoE3nZbwa9LEsTZteZ+ri2+AVT2aP6yihGBNnoLeH2wqrp6P0Eqk9vq/EdTOgT/kjk8vtgti4hX1me6grATIc7IBzQwBiM9peEnJF4WoCjzAtLUWErlJrA1m89WubbS7+ZVoJsO8oW1IGlSe8w224PkdEIepj4KKnRFV+b3RGIARnZ1v7BkET1yLWHTC4j4c/VecFv0/HqFineC9B2apbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hdXLfsRIT6/1HTTPg8tyCJ0DN0VEt440lgmkVWRuqeU=; b=ErCFIrqiKqTl6RoSOYfx8ysqF+qynuoa/qwuda6IuT76rZyVK+trviGIhiyL5wVM9aJbflHVk1OxQv/ltSlSQc+mA78N37q0lbJMHo3/CZvnXb9DUanS65jzEGDh3jHSM7QeUJzXJuFVyElsRS4uu3AOZc1pt3PBjQlEym29PKunmudHkJBkcDlsODEHN5jKCPydcfZC1FuWZWhRaDsvGc+wzUdXq7UBu/146lCSWgNJFdKfbC05uBkK+Nrbf1ACctwNnNpdlbSdE+a+wwowLQHvSF5dCc/WypQ8EC6yIbcOJBTcw3Oqx5Pim9pYDHCWcZAynB0laBhkArL0EqMycw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hdXLfsRIT6/1HTTPg8tyCJ0DN0VEt440lgmkVWRuqeU=; b=okHImzc9zT2A6zM+zRplEereDUDkpxUAhwLtu7AMoahBWPX9ZydzyVu9CfiPdo7XpjPD82/i5+CHTUPSETohacGJCNY5Caw8Lx+32ATIGwCGCltfYRFEeneyKXQioAF0Kvpvg/JszKJZfGcAAZUN9fTEAPRBAfVXwAqP3mA7bLhT4B43wLYwkTEZVPkSP+UrffizdtbPlWv8OwjT7YCInZOYSBcKOjfvxyTp3zpuminxu+J9IaakJEHkvIhh/k2PshUfMC0pg3ktWE+XWHl10LZZ3bAklxBZMl4r00Aw83EEGr2wE4pNeZ27TIZzOEQCXO+FBmmZYzV6G1uQxp3bWQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <76d4b625-2864-4452-86fb-70a4413bb886@suse.com> Date: Mon, 8 May 2023 08:55:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 2/6] x86/cpuid: Rename NCAPINTS to X86_NR_CAPS Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230504193924.3305496-1-andrew.cooper3@citrix.com> <20230504193924.3305496-3-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230504193924.3305496-3-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0103.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7351:EE_ X-MS-Office365-Filtering-Correlation-Id: 5b106de3-d88b-457e-0256-08db4f91335c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DYBulBXXqqEQLqM5iRKPOzaNldxVL3ziuteYHkwU2GRL7NC63fvJs/pTkCcvTeoMP+BCajLMu9DzIJGjrXK9dkNOLdIIf1J6PE98Mt1t+ZXvhTnkk0U3ZbTWmTtLUYq4Xcpy/uZGnRwxeepdlw/+zOVqYPCbw7u+csVSRmbgTYZ9ZhTxEEdp/MM2AXNGFtMGKgzYZl4CHH9m3FSR8PgSS4d88YThEnOOk3CaU4HLfI93YODtuy4fbM1lBqBgN+yPwfJdJ8SormTqe1Kstuc0pqNwXFw2XUcWB/StlBMGdIMXAQdAxwuULJ/BY4HSp0jGDRzQewQkIkNnMXWnYbAVrZRgkF0N5ykKGiQe79WB9353OOxZ7/eGhdRDMoQUDVKHe+uC76AaIy/jlOR0n47nUGYf7eAM80jkdi1rbRMlfqXPwK4QbqH2yDunz6Ol6+E+pVrZBQwdKZXb35HiehFB6zhAFBnE1lgV6D4OOJ1k0s6w++Azi0pJz4Z2Y8sz07tYxZPwyF3iMNQJph7xgHsIIc5YoEs/vJlImW9qykkQsdmsMfkmYE+irMIWFjKyu50pr03A0Z9ZS2HpMmUbVmEDO1E6RaJQXfBWRTFu2YhSXUpYjn5BpyK7D0tS5wnsJwP6pafyKO/a7C4+jShh6OzKqA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(396003)(376002)(366004)(39850400004)(136003)(451199021)(31686004)(6916009)(38100700002)(41300700001)(4326008)(36756003)(8676002)(8936002)(316002)(6512007)(6506007)(26005)(53546011)(6486002)(478600001)(66946007)(66476007)(66556008)(2616005)(31696002)(5660300002)(86362001)(186003)(54906003)(2906002)(6666004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WXBIU0pxbitrZmxCU3hUTVB2c3NkcmZ2QVZzTll1V0JsdDFCN3FFN2RneXJz?= =?utf-8?B?T3N5RFhFMXR6RXhyWTZHbkw4aGxrYUNaTktSVHZZd3o0dWdycFJkQUx6bm1k?= =?utf-8?B?SGdwU1NiYnhjd2hORDVmYy82UkVlYkNoeWFnUDVQaWFQRWZqVjBBQWNaUURJ?= =?utf-8?B?NjgrTkluSlk2SG1EZ3NLVVJHc1NQV3ZGVjN3LzZVaXFQSGdQc2hFTGRUR3d1?= =?utf-8?B?bUV2emQ0czRMTDFoaWRWZzF6a3hZZkdWdk1kUm52TnQ4bXg5dEh1WEU2ODdu?= =?utf-8?B?eWcwQytKYXZRUUNFOTNPTTlYd0VIektxOElGQVdWWGdidzBIVmRMZTNSQ0tL?= =?utf-8?B?RFIrTWpMbG9CYk53dEFyUnpmOFlEcmduT2RRSFdHZHpkTDBrd0VqWFc4WlNT?= =?utf-8?B?OXVNNnp3a2lHcnVLenJqMVVYdkhiaFVzME8vRWVCdVRnbmlERUhMNGV2MnZu?= =?utf-8?B?M2FLWU81WGpIRklDdUhMd2s4QkFzR1pQVE9GU3FQS1E4SmVhWGJtM2pZT242?= =?utf-8?B?Y29wYytVc0FMdEROY3FqY25vY0Z6dFkwaFBTZGhpTkRQQThoNW9XT1VvZTF3?= =?utf-8?B?eW9nNy9scW5kYUtJYzl5dWo2THFPTnc2MXZXWm0raFJrVEpGZ1NhNFY1Ym1K?= =?utf-8?B?ZEJhNDhTRDlCUHhKODZCbDlNSkRMcHZqWWU1MWI4cGM0SHF1cnhGdTl5bmQz?= =?utf-8?B?TFE4eDJIRk5CZTdmRVZqdkJvUnk2WXNha2ZPOThzcHU0SHlCRU5DVzNGc0pU?= =?utf-8?B?N1JwMElNeWFCSWgxTHd0Y3doNklscmRkTDYrd3hGSmZDYW5EMTRDZUtPTGZT?= =?utf-8?B?ZGZkQ1dMQ2wrYWdwYzlqTGlJd05kNTl4NFZFMVp1NUhmRXM0bTN6TVExRlB0?= =?utf-8?B?WElIekg4OXp4ZHVJNm82czh3cjcrbFlVUDZXY3lSZit2R0ZVanVlVGFqUkla?= =?utf-8?B?eEsyWUdPTGNoZ0dkQmhybDJTRkFVbElsblZScDd0K3oyeVNweE9wek5hRUV6?= =?utf-8?B?cWVvY0x6eC9zRnRvZk9paDRWUDVWSVdhSWtLcVhPM3dFeXA5Szg4QVJBV3Rh?= =?utf-8?B?aE8yTk1XdzZocUN2OTZia0hKK0hrbWFFMHoyWUsxQ2s4bmdiNkpTdmluU3h4?= =?utf-8?B?Ukg1Rk0rbDZLVnlvbHdOZkxyZG1jUjVkMVZFUWV6dHpiL2xlblRnVnR1R1kx?= =?utf-8?B?WUtFai9nbVlpQUY5SzhlSGhjSGNsZ3dhOHFuWFR6UVA5cGZsbnRxeHhjRGZn?= =?utf-8?B?N3pFbVFKcTJCVVM4RmF3TWh3WGt6bHloVTIvUDBrTFBTYk9yVTFUaElYWlpN?= =?utf-8?B?WGljZE0wcGwvZnFycEs0dzZWQ0g4TGl0QlJKTHhSdUxzdldUaW1kdkl1cHAw?= =?utf-8?B?WVUwNnZvOVo1MThtbDNucVhzOGp0QXJZeDZuSEwreG1sRGxKZEpueDh3S1dT?= =?utf-8?B?OWRKMDBaSzNqZVlaa09YMDE3ekptV25SMDg4SC91YzBHZ2tLTVFNeFFlTWdp?= =?utf-8?B?dFZFZFRhdENIRWJBUDlqNmFtS2Vwdm1pbFpBSHZtZUptNWF3TnhwNTd5VzhF?= =?utf-8?B?ZG8zOVZBWXdBamU5TDNqMmFWdUpLa2EveHFhdDNIYlR1L0t4NS92RDB1TE5O?= =?utf-8?B?bjJpUmx3N0tsd2QrR2h4bERjOFJEbUVySUNuWWVkUGZKWngxdzRYdHAySkZj?= =?utf-8?B?aStibWNObnpaZVp1dXNOaWZTazdkdUdrVDNHeVd3MGU1UCtFeWF1MkZMZkhi?= =?utf-8?B?eWtxRCtGdnUyTUhnWUl4b2QyTzJRZktHV0FEQ2JrUnc3aUYzSDRTcjhvaWtv?= =?utf-8?B?Si8zcUFHYU8yNHlSdUpnY0FtSVhVWm41QlRqZTQ2ZzQyV2tKREFpT1A0bXNG?= =?utf-8?B?UVB2bHdFZXpYbTZXZVF3bElpaEpPemFsZkRBNTJiYkRjVDFSTTRqRnEwN0lr?= =?utf-8?B?Z1IzQ1ZJSUZ1aG1BMEcvd1UzV3RwUmdwaHRwT0V4ZVBTMmlES3R4c2VvOXNK?= =?utf-8?B?SkQ1amlOOFN4a08rdzZCaFFMR0RsbmI5SjRLL2JyZjEvNkM1Ulk4RFJjZjUr?= =?utf-8?B?SlRoLzZNcVByY1QxRU5JZTJxK0JsRTdZb1oxRWgrWDJlMjFUcElLTm1sNG81?= =?utf-8?Q?gOkP2K/4Ojt4DpdBpJZCjbfvU?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b106de3-d88b-457e-0256-08db4f91335c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 06:55:25.4509 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pFc8F1MXy/Lsl0Qs+eYnV7zqSnjhYXWfGgUk7mAIKMprrMTdCKO+vG50+JqtiFIZyUsw0yBvPYcLulPidVIuZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7351 On 04.05.2023 21:39, Andrew Cooper wrote: > The latter is more legible, and consistent with X86_NR_{SYNTH,BUG} which > already exist. > > No functional change. > > Signed-off-by: Andrew Cooper I can live with this as-is, so Acked-by: Jan Beulich yet ... > --- a/xen/arch/x86/include/asm/cpufeatures.h > +++ b/xen/arch/x86/include/asm/cpufeatures.h > @@ -53,4 +53,4 @@ XEN_CPUFEATURE(IBPB_ENTRY_HVM, X86_SYNTH(29)) /* MSR_PRED_CMD used by Xen for > #define X86_BUG_IBPB_NO_RET X86_BUG( 3) /* IBPB doesn't flush the RSB/RAS */ > > /* Total number of capability words, inc synth and bug words. */ > -#define NCAPINTS (FSCAPINTS + X86_NR_SYNTH + X86_NR_BUG) /* N 32-bit words worth of info */ > +#define X86_NR_CAPS (FSCAPINTS + X86_NR_SYNTH + X86_NR_BUG) /* N 32-bit words worth of info */ ... the way the value is computed suggests to me that "CAPS" (i.e. "capabilities") isn't quite the right term. "features" sadly isn't, either (or else I'd have suggested that without hesitating), as neither of the two really fits the inclusion of "bugs", but feels - to me as a non-native English speaker - still slightly better. Then again "CAPS" fits x86_capability[] best ... Jan From xen-devel-bounces@lists.xenproject.org Mon May 08 06:57:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 06:57:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531269.826845 (Exim 4.92) (envelope-from ) id 1pvuoT-0006Qi-Qm; Mon, 08 May 2023 06:57:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531269.826845; Mon, 08 May 2023 06:57:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvuoT-0006Qb-NK; Mon, 08 May 2023 06:57:37 +0000 Received: by outflank-mailman (input) for mailman id 531269; Mon, 08 May 2023 06:57:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvuoS-0006QT-0n for xen-devel@lists.xenproject.org; Mon, 08 May 2023 06:57:36 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0630.outbound.protection.outlook.com [2a01:111:f400:fe1f::630]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9b0fb0df-ed6d-11ed-8611-37d641c3527e; Mon, 08 May 2023 08:57:34 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7351.eurprd04.prod.outlook.com (2603:10a6:10:1b2::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Mon, 8 May 2023 06:57:31 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c%4]) with mapi id 15.20.6363.031; Mon, 8 May 2023 06:57:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b0fb0df-ed6d-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YAD64Mg4IsVRJutXtFIyTfGHN6ne3i+pj8shU+hnYN9c8zLAV4m8DojUEeVOGx2nAmwReHtyxt3pifK6NJce8LpAXMJfflLW+V4z0NtdyPcPpOg7yFlMDNMmUD63SR+3s+EqITkyvKxELDvTHodnznZiO1VW8rvrlF3dn9G4IMErHPA+INZdj+VQkubcqsZkzQF2Ia7Z0M/Kk3F1c6N6Qyr5grq6ayy0Cllmwrg6Qx0GfPHIK6RHklAPqIRf0zkdDb1GtzrN2I0M21S9hPhqIMqA5iPXD761xJTFmpS8jrQnPkGdR0+L1cT0xPMqCCB+1qTKc1fMUbhUGk79qnZGPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nt2NJz22ENuOlKjutZ54L4hE9P3SR48KwWTodLGBkk0=; b=T0Xyw7tcHJqe25UyZXEhvaxxcvrhTWoHcnmjK65kVceMlcvbh08TiNuv1x0jj7Hr7Ll1SpFFTH+yECe09vKD6TeNRSu2h3taa8b1I5v0+Qe6sHCwXjZLtDtR+fHVV6f9RrKmHuHBZjerSidBSl1XM3DZtQuS1sfnkk5tt2Vp8t7Dj6ANqen7w0Bj+BoRb2pkWikVQIRl95qNiD8tbduWVzhfDFTMmR5a9eTzKbvHziVneeQoL7+N3YKMQ2yBRq8M5Ro2G28l5Uig29aeno+G9utsjLbX4GI7BbxWzqPb+Bu/9wCVuVn7I1IksoSnc08cyvxx6Yw/j9Wfyo5t1SrP2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nt2NJz22ENuOlKjutZ54L4hE9P3SR48KwWTodLGBkk0=; b=c4F84VgF3VYNLietC/CA5yN5LOc6uV0eV74wNC3PtWPWvd19MmG8MeWUTq8L7+c0zdLDXz7egiG62B+GkobWd/LTCXw0TxAUFmnbuXQDWLGYL8ZrLj2vFYDPUVAysb4PH94SFwcIrPnTlcYRR0Re6LfHgLQn1aHuxrtudzsbCuI+KdAudF9pW5sZEIz+JlEzevBbJqG3BE9//koH4W5u3GSAIVKMjKXZ3p6HOmBOMntizBJkhleTxxVCmMPIF6dqZ4wc+ApHv3Rom97iNbtUuuSdp/2kqB6R7uYE22VuBmSZXmUrMfd/VUiRQUeYhHKXvPP3VRYH6lFYQGe7Zzqa3g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 8 May 2023 08:57:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 3/6] x86/cpuid: Rename FSCAPINTS to X86_NR_FEAT Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230504193924.3305496-1-andrew.cooper3@citrix.com> <20230504193924.3305496-4-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230504193924.3305496-4-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR02CA0074.eurprd02.prod.outlook.com (2603:10a6:208:154::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7351:EE_ X-MS-Office365-Filtering-Correlation-Id: 19a6e9f7-cc58-4c80-df15-08db4f917e36 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: n1Od0eWNjtNhp5Uh+scAWwZKzbWzgNhGL/qVUgvVvU7ZzJdx+aic3jNxsv94SiPicd1OQ2LUHzgxfwjUd+LHYCHhCz0c8tHax4NPXwubFNbvSZOuuD1HhihwfeYm6y7WJ9fOHbRErtF1X7sVnXgFtgq1wMDWtjEJmjcaowRL9RBqINDNABOHTyDUlTrMxh4lIuJOUv/8JL8GZnQW6i1y4y/C1m8S29pQQcibwG4Tt4ETOrxceS1k0gdlb1zyiR5iSxF+fFbCTiU5pCRBXGlumV+yLdMVGb6ozIhZftczpZSnvSEC4GLAjcCVDs8cyjN5K1tctpxFDFvcMt9lbSLrRxRMhQkEaQUw8Eo2647Kg1crNEJXdho+2hHj6DVPLkL/aTkpMu5mycGHr0UYXgnjW89ue/hkZVaT9s6L0iNGaBg6F1//XhnELapSbNGXc/NAxxinVMp1EHhEMpxQGqjsindojRQ3sf50dR2PoPfEkOly8v9aKfNatNRzGHQJhYa3PmHuWa+3KTsqp2EHLasN0JkXp+yBxAE4zele4/Tjlxguqjn1Aq+yKqRoI3lrzZAtLAjrjL0dPjs61xICtw19HsmmsScyRjtQ/B8TvezbBsrhI5Kq1aHwFJViNiRb4yDhQsZsiagzTQCHjrI4cizhZQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(396003)(376002)(366004)(39850400004)(136003)(451199021)(31686004)(6916009)(38100700002)(41300700001)(4326008)(36756003)(8676002)(8936002)(316002)(6512007)(6506007)(26005)(53546011)(6486002)(478600001)(66946007)(66476007)(66556008)(2616005)(31696002)(5660300002)(86362001)(186003)(54906003)(2906002)(4744005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZitZVlFxTzI1aGdYWG1kUXV2RHQyMHhpUkFDemtXSXNRSzJENE5rbXpseENk?= =?utf-8?B?LzNvYXFHRmlmclAzUklsbEQwSmNCM0kxQ0NoWERTem11REcrMHAyR2R2ZGxy?= =?utf-8?B?K3haVGlTSVB5QytSNDBJajNOYTBwWWNGbEpqZ256OUFHOTd6U2dnU1dUdkVR?= =?utf-8?B?TVhZVkxmSm14a3ltU2JuaGxXSWk4NDlPMkxyOVBoNEF1TWxZSlpsMEh6Nk1Y?= =?utf-8?B?S2VRVWFFYTN1Vm9wakRTd0dRd3ZwQVFlQ2RSVW1NUlowc1Y5NGc0M1NoZW5G?= =?utf-8?B?QVdiY21wVlpqRUJBOFFJWmovbkRZQXM1cUw2MXhGOXd5cVFzZmlMZlRRUk1r?= =?utf-8?B?Q1R3UzUyaWRVSDJkQmlhUlJPZlJMZ0NjSzRRM2h5VllTQTFYRGRDMFA5T2ta?= =?utf-8?B?RFE3emZQd3B4SE5IRVpWTkJWK2NQUzBncS9IUkx0Z0R2Z3hlTTVQTDhRWW1i?= =?utf-8?B?a1EwWlByNDdpR1VQbzFBbFF4OFJ1M0xzb3czWmhsOVhDNGRUcnJxeUFrcnlL?= =?utf-8?B?VmFVa0NkbnE1N0w2Zm5UanFQY2kyczJlM0lxTXhVVG41V1UreXFxN2JxU2Ro?= =?utf-8?B?c3A1YkVlV0hOMWxKQk0yczVwNFBTWXRMUTBUVEM3NVNtd1dpcUNhUWJjTE5y?= =?utf-8?B?cFQwNnRjdW5WdE4vOEdlVWczVFB2UmNUd0FkYTE5UzRjVERWWEdXZktFQUJR?= =?utf-8?B?N3dPcHFIRThCdjFzdExHQjRvRmVvYS8vUXdlK3Fha1VqaEtWTTdqY3oraE12?= =?utf-8?B?dExkTU9VcVRSS0NGZTF0ajI1Z3VmNjdCMVJvdEU5UmUvSGZhRDVnNVl3WDNN?= =?utf-8?B?eHJ5Y1hoZHFwQXQ5OHVGc2NXSUd2bkF6azZVY1NPYmpnOGs5bElMZDZXaGZ2?= =?utf-8?B?bTk5d0hqZGI2b0EwMzg0UGtpbTl4Y0U4ZEV1WkloOVNJODRLMjVUeEE1Qk1I?= =?utf-8?B?amFaVHp0NWllcjdNVWFaWXhJR2RTczVtT3VqSHJ2d05mUnBobERpMk91b1Jq?= =?utf-8?B?SVJ1VU1RL0JIQndrZS9wYVdLNk9CZXlCUDh4YUxJOWNZdkN0U3Y3bDhieUZr?= =?utf-8?B?WHU3QUo4Z0ltS21EczNyUmRMekJBOEd5bDdLQXl0QXlvSFhZSjFsRzNUWHg4?= =?utf-8?B?MzZ6ekozcWhHdEdjbFVsSmN3YlFtRzU1VzNjL0FFci8vRE55bm1yZmlZVjZR?= =?utf-8?B?Y1oxdWpaUXhzdnNIdFhZMlgvWDNiQm5oTDN6V2hQaVc2SkpzR0xLK1l2bTJa?= =?utf-8?B?Y2xOTUE1RStycjl0RC9OVDhLUVVxbU9QNyt0YUYyOTlJOTREd3JJU0hBTDdv?= =?utf-8?B?Q2Q0cnJnUVNVdjFvZVRSVXZQL2pHbi9iZ1ZzTkZrWkVSMlZjaEttOUFnMHk3?= =?utf-8?B?eDI0NzBwRmh1WEhzZWNjMUI0amhJcFJtRitBOHVRUTNOencrd0dQNEJzaFR1?= =?utf-8?B?U3MrclZoN01iWDUxVFUrN1Zhc2hwZjJaWXBvYkNtZWIyNElkNERJQ3JVM0dl?= =?utf-8?B?SjVlRUdDa0xRYm1NakNNRWVyb05tRk1NZkp0bEFNK3FGcXI0UG14bUtFQnQ0?= =?utf-8?B?d2NKNi92MVhmbnI1Zm1hMTRpMHpNVy8zclpPWFFCRnlvcFlWSHhUcDd6bDQy?= =?utf-8?B?Wk5mcXE2ckJSWDgwZmwrQk1nVWZmYUhvZWlBMDZZY2tBUitobFU1NFduWlJx?= =?utf-8?B?TlhkcXJVRXd5TXdOV1Vna2p0emZMN0kxQnZzQ1BRZFg1RXBveEJoRGh3ekdk?= =?utf-8?B?N1RVU3RxaWhIcFMyVWlrN0NacEcwQ0hhUFQyUno2OTk2c0VvMEF6SDk0Wk0z?= =?utf-8?B?em02WDBYRHFoZmJQZmFsUnk2YTNnZG5pOXU5VWV3VEZ2eEg3MzBQQksrWUd1?= =?utf-8?B?MVVKQmxOZHZza0xGcGFhOUtwQjR5aEg1eXBzWUJ0NlVEWDhUYzVLSHBnWVJa?= =?utf-8?B?dTNYOWM4QThlaW1BVjBHdWxOSHNYN3NtK2tvWGJFcW1wRUQweTB2dzNsbWE0?= =?utf-8?B?bkJpMGlUTzZlMWlpcTE2Y2ZrcmxDRmQyZzJkalFrYnIwVXloaGhneFRMZFN4?= =?utf-8?B?Q0xrL0EyVFA4UnNyUmtnbzVWVCtDSHNuUTRkWDhxdnJyWHBWTHhYa1RlUkxD?= =?utf-8?Q?bTIjTofEQt6oU+x/umiEv3N23?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 19a6e9f7-cc58-4c80-df15-08db4f917e36 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 06:57:31.2550 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IN+WWWBIuvbOCCPZ7LhXA00fe/yHA1TQDiHtDj9AW/oDCT1qG77/V0+W2BygddkEXpFFNgN2+DzPqVi5A6QfIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7351 On 04.05.2023 21:39, Andrew Cooper wrote: > The latter is more legible, and consistent with X86_NR_{CAPS,SYNTH,BUG} which > already exist. > > No functional change. > > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich And in the light of this the name choice in the earlier patch is probably indeed the least bad one. (I'm sorry, I should have paid attention to the title of this patch here when replying there.) Jan From xen-devel-bounces@lists.xenproject.org Mon May 08 07:02:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 07:02:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531275.826855 (Exim 4.92) (envelope-from ) id 1pvut6-00087L-Gs; Mon, 08 May 2023 07:02:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531275.826855; Mon, 08 May 2023 07:02:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvut6-00087E-CL; Mon, 08 May 2023 07:02:24 +0000 Received: by outflank-mailman (input) for mailman id 531275; Mon, 08 May 2023 07:02:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvut5-000875-20 for xen-devel@lists.xen.org; Mon, 08 May 2023 07:02:23 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 475b669a-ed6e-11ed-b226-6b7b168915f2; Mon, 08 May 2023 09:02:21 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8C44F22038; Mon, 8 May 2023 07:02:21 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3F0C81346B; Mon, 8 May 2023 07:02:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id b1GqDX2eWGT/KAAAMHmgww (envelope-from ); Mon, 08 May 2023 07:02:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 475b669a-ed6e-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683529341; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NLWDrEm93LZyOFp9xeXo6/XT6xDUF7ihv0pjc2/CGE4=; b=G5rh8vPRZ3AJXEFa9qc8uv/cQ6qd63PNGotWqAGoOyNk9W1u6bDIc/lviWZoL0eGt5KG4o uMogbfhwDjVZ5o/cLe2m1kmzSxj5wZ1jQf+B9Gshok8mwd9LdXn107jT/NWaz9dhtYB6XD /UfZ7bukKYbQWU3gvj9kDMWcDs6YTt4= Message-ID: <016edde8-e47e-a988-e5c1-f5aad0d4b60d@suse.com> Date: Mon, 8 May 2023 09:02:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH] libxl: arm: Allow grant mappings for backends running on Dom0 Content-Language: en-US To: Viresh Kumar , Oleksandr Tyshchenko Cc: Vincent Guittot , xen-devel@lists.xen.org, stratos-dev@op-lists.linaro.org, Julien Grall , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Anthony PERARD , Mathieu Poirier , Erik Schilling References: <817f0320316dd144826add0ac834618026b91160.1680165772.git.viresh.kumar@linaro.org> <25fb2b71-b663-b712-01cd-5c75aa4ccf9b@gmail.com> <20230404234228.vghxrrj6auy7zw4c@vireshk-i7> <20230505061934.jm3bwjgsl5hf5rns@vireshk-i7> <20230508040927.uhgwfkhknwyvsowu@vireshk-i7> From: Juergen Gross In-Reply-To: <20230508040927.uhgwfkhknwyvsowu@vireshk-i7> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------8TdY1rGaWKCJvGGRqi62EHVh" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------8TdY1rGaWKCJvGGRqi62EHVh Content-Type: multipart/mixed; boundary="------------LljxTwaMiE7SpQZT1QMO5GRq"; protected-headers="v1" From: Juergen Gross To: Viresh Kumar , Oleksandr Tyshchenko Cc: Vincent Guittot , xen-devel@lists.xen.org, stratos-dev@op-lists.linaro.org, Julien Grall , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Anthony PERARD , Mathieu Poirier , Erik Schilling Message-ID: <016edde8-e47e-a988-e5c1-f5aad0d4b60d@suse.com> Subject: Re: [PATCH] libxl: arm: Allow grant mappings for backends running on Dom0 References: <817f0320316dd144826add0ac834618026b91160.1680165772.git.viresh.kumar@linaro.org> <25fb2b71-b663-b712-01cd-5c75aa4ccf9b@gmail.com> <20230404234228.vghxrrj6auy7zw4c@vireshk-i7> <20230505061934.jm3bwjgsl5hf5rns@vireshk-i7> <20230508040927.uhgwfkhknwyvsowu@vireshk-i7> In-Reply-To: <20230508040927.uhgwfkhknwyvsowu@vireshk-i7> --------------LljxTwaMiE7SpQZT1QMO5GRq Content-Type: multipart/mixed; boundary="------------SfLWA0MwlAA6q5B9qosBCs3a" --------------SfLWA0MwlAA6q5B9qosBCs3a Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDguMDUuMjMgMDY6MDksIFZpcmVzaCBLdW1hciB3cm90ZToNCj4gT24gMDUtMDUtMjMs IDE2OjExLCBPbGVrc2FuZHIgVHlzaGNoZW5rbyB3cm90ZToNCj4+IEkgd2FzIGdvaW5nIHRv IHByb3Bvc2UgYW4gaWRlYSwgYnV0IEkgaGF2ZSBqdXN0IHJlYWxpemVkIHRoYXQgeW91IGFs cmVhZHkNCj4+IHZvaWNlZCBpdCBoZXJlIFsxXSApKQ0KPj4gU28gd2hhdCB5b3UgcHJvcG9z ZWQgdGhlcmUgc291bmRzIHJlYXNvbmFibGUgdG8gbWUuDQo+Pg0KPj4gSSB3aWxsIGp1c3Qg cmVwaHJhc2UgaXQgYWNjb3JkaW5nIHRvIG15IHVuZGVyc3RhbmRpbmc6DQo+Pg0KPj4gV2Ug cHJvYmFibHkgbmVlZCB0byBjb25zaWRlciB0cmFuc2Zvcm1pbmcgeW91ciAiZm9yY2VkX2dy YW50IiB0byBzb21ldGhpbmcNCj4+IHRocmVlLXN0YXRlLCBmb3IgZXhhbXBsZQ0KPj4gImdy YW50X3VzYWdlIiAob3IgInVzZV9ncmFudCIgYXMgeW91IHN1Z2dlc3RlZCkgd2hpY2ggY291 bGQgYmUgImRlZmF1bHQNCj4+IGJlaGF2aW91ciIgb3IgImFsd2F5cyBkaXNhYmxlZCIsIG9y ICJhbHdheXMgZW5hYmxlZCIuDQo+Pg0KPj4gV2l0aCAiZ3JhbnRfdXNhZ2U9ZGVmYXVsdCIg d2Ugd2lsbCBnZXQgZXhhY3Qgd2hhdCB3ZSBoYXZlIGF0IHRoZSBtb21lbnQNCj4+IChvbmx5 IGNyZWF0ZSBpb21tdSBub2RlcyBpZiBiYWNrZW5kLWRvbWlkICE9IDApDQo+PiBXaXRoICJn cmFudF91c2FnZT1kaXNhYmxlZCIgd2Ugd2lsbCBmb3JjZSBncmFudHMgdG8gYmUgYWx3YXlz IGRpc2FibGVkDQo+PiAoZG9uJ3QgY3JlYXRlIGlvbW11IG5vZGVzIGlycmVzcGVjdGl2ZSBv ZiB0aGUgZG9tYWluKQ0KPj4gV2l0aCAiZ3JhbnRfdXNhZ2U9ZW5hYmxlZCIgd2Ugd2lsbCBm b3JjZSBncmFudHMgdG8gYmUgYWx3YXlzIGVuYWJsZWQNCj4+IChhbHdheXMgY3JlYXRlIGlv bW11IG5vZGVzIGlycmVzcGVjdGl2ZSBvZiB0aGUgZG9tYWluKQ0KPiANCj4gSSB3YXMgd29u ZGVyaW5nIGlmICJncmFudF91c2FnZT1kZWZhdWx0IiBjYW4gYmUgaW50ZXJwcmV0ZWQgYnkg dGhlDQo+IGFic2VuY2Ugb2YgdGhlIGdyYW50X3VzYWdlIHBhcmFtZXRlci4gU28ganVzdCBn cmFudF91c2FnZT0xIG9yIDAsDQo+IHdoaWNoIHdvdWxkIG1lYW4gZW5hYmxlZCBvciBkaXNh YmxlZCBhbmQgaWYgZ3JhbnRfdXNhZ2UgaXNuJ3QgcGFzc2VkLA0KPiB3ZSB3b3VsZCBzd2l0 Y2ggYmFjayB0byBkZWZhdWx0Lg0KDQpJIGRvbid0IHRoaW5rIHRoaXMgaXMgYSBnb29kIGlk ZWEuIEkgdGhpbmsgeW91J2QgbmVlZCB0aGUgM3JkIHN0YXRlIGFscmVhZHkNCmluIHRoZSBp bnRlcmZhY2UgYmV0d2VlbiB4bCBhbmQgbGlieGwuDQoNCg0KSnVlcmdlbg0KDQo= --------------SfLWA0MwlAA6q5B9qosBCs3a Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------SfLWA0MwlAA6q5B9qosBCs3a-- --------------LljxTwaMiE7SpQZT1QMO5GRq-- --------------8TdY1rGaWKCJvGGRqi62EHVh Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmRYnnwFAwAAAAAACgkQsN6d1ii/Ey/L LwgAm1/ilqFa/bVlI3stWVraQeJ83u7kj8C+bB1tElWemvPL7UjiGuxuRKJhEH5jQY35HvcEZk1i PKiTecPd9ze0ZvuPFq2nh7cSszAOlAJK6EMluAzd3TaEfPNv6PqfB08+qbm9ZG0aX0XsqeJ383lf aMXoa+F+DBVjFKIMANswxVtrDkowGFTD9T8wLGY5jncavIKDI4ko6EJgUc8XvF5aIvNbhDgbw8dC 53j7ya9EVEiJaFPiTamJhtHewit3ZOJAujvltf4IQGA5XlHQuIJUubZM56rCt11V+tke4k/Nq5VW EULruSEA7aNdOywxiAFT4g8HpKnTSKwPeKX2UGq9TA== =MC4x -----END PGP SIGNATURE----- --------------8TdY1rGaWKCJvGGRqi62EHVh-- From xen-devel-bounces@lists.xenproject.org Mon May 08 07:45:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 07:45:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531280.826865 (Exim 4.92) (envelope-from ) id 1pvvYx-0005M7-Ox; Mon, 08 May 2023 07:45:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531280.826865; Mon, 08 May 2023 07:45:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvvYx-0005M0-LI; Mon, 08 May 2023 07:45:39 +0000 Received: by outflank-mailman (input) for mailman id 531280; Mon, 08 May 2023 07:45:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvvYw-0005Lr-6G for xen-devel@lists.xenproject.org; Mon, 08 May 2023 07:45:38 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2079.outbound.protection.outlook.com [40.107.7.79]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 51c184ab-ed74-11ed-b226-6b7b168915f2; Mon, 08 May 2023 09:45:36 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB9403.eurprd04.prod.outlook.com (2603:10a6:10:369::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Mon, 8 May 2023 07:45:07 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c%4]) with mapi id 15.20.6363.031; Mon, 8 May 2023 07:45:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51c184ab-ed74-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a6Kz6wu6MRyTEIaVm6Ll6lwcA6/xHpS13SDnfxLVA/ejx+LYqM38HmIxCRUozi1sURkpqtRyN0NBWPC14O8fEUDR6dFoBhFt9zuJ/43ddcni+DPNXZmupFfUYmNhVe+60NHZAIoxg0JyV/3ssCq9OlKYEBcOyRgzOQP5Q/67EvypZyusMv20PazcypBv+mDV7jSHOLfkA6NfMR5QMNlcZLhBnklN4M+Nd4e2t89GK/fEALAawyxcJg0TM+QieS6A96m74JIJJ1CHmxOB6jg8tZWCJRLy8TfoRmDgXVyIx++sSh1bV/W0xfHKgtokSi9M4QbZNFq6VmJafJjDpK4VmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8rvEpc3Y1x9ckkFXedQ+0A6kTrYUJrxDOiToGFbCa60=; b=WxTYRNnM+cEcK9qAwGvXhaHHCuETqI46JBDZPT9IQTUHXP8Rk1ppbBcN+LUipWxInd1JN171qAp28EM7c39LYIdlwIVcW+cZE8Q/ibDfoc2YP+tptYszPZ4/OwemHyrk34U6CffdduzpvVTK0WZW3GS9QkNxDrvZVn4RqSjNc6TGrZnVPNP6U2I0/guqdMAUXJ+z5Oj/zD7XHe5Qq8nm7flo5u4LRB0rpbCaNxlDs62/Mkmr6dMikhNk31pprK0kNKc/gv3AHi9OHc2Ln744d6vshbJ55gITcbSPkclrQYHzT/1qlYi2qr7aI6q0Lygog6xBWEw0An/GbOFv/2XYUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8rvEpc3Y1x9ckkFXedQ+0A6kTrYUJrxDOiToGFbCa60=; b=FKM1oUvXFnw1CuJhrBgok6kQ5f1YXB5yp8WdeyrwVY3i1jXF6PND10KXJET0+nosDSXgJ7sDAxrFrbl+xSJHVLJHYEllTM6i27VuirQm7Se1+SJ+dgzCTQh/Wlh5fInqB+88ncffuGxsJBSwddwwToLeiiQXMwdPFajddSselku6jDdgsg0bXQskiUd9SNBdvW4NeDJZnEseJbNbe++tuGYlao3bB2ZGUzsFLJm8e+gttFCsyyLOYudiMD6gex1vqzdHYC2F2NLmgaYNaqZZXkjVgvPm1AkT/jvGgW5WYZg1wNQ65QnSlAV61l0z2q5DNihwk6aFqlwLIU0B8FcVOg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9613df3b-c49f-6034-ff99-7a6ea9286f0f@suse.com> Date: Mon, 8 May 2023 09:45:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 5/6] x86/cpu-policy: Disentangle X86_NR_FEAT and FEATURESET_NR_ENTRIES Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230504193924.3305496-1-andrew.cooper3@citrix.com> <20230504193924.3305496-6-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230504193924.3305496-6-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS4P251CA0025.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:5d3::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB9403:EE_ X-MS-Office365-Filtering-Correlation-Id: c4df971d-cd86-4453-3361-08db4f982495 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ki74BeomotXVuxrdxTXZl3H0nM2lQvncrr54BwUy8XVHQiBS11ecd7e5QB9zSInsnsBbL9Poow8jww7v6NssB8A3/9bLVM2bGBnZgivq49ZogQEZfAYlcI4w6vJjExDJqxjgsJJDuf1PHM/B0T9bc5vmmXYct8Sd7kJcp3S194y3T0J4ZZgEFaB0GBsYdi4IXGsUAwxn89tr1VYy9Mg7DNGj2bMfR+DBsGylYH/LZG31sNyXu6YLywv2HWBtmEykjqgNkZIod+9b0PNFBqwAWsqwU7umbYJL2ei6EYsIzSi/KFRLX95w6j91Kbwe+fl5BX/ZhlqRgDAdFfYsTUBOUEaJYzdCXFWeM+qLgtjWScI0tXrAouyfKQ2POEqmFt2XVKVrgNw8Hh4nXBhIYqLeRo8b5I3gGsEjr7RkcrL3u9dGztZzbEkaRDa4dhasj38NGWaP4265ipAElRmj0EocRmaH2fOdDOjAOIeN2NAh2B9jt+HLMHtLA07WRzmocMHKhuWfY1IjlECisJZToG3tGjlvIsoSXKbBwAFMGFd0Ny7HynhHjdggNBrZWM1rphd7YpI4GnI1ReS1Vzughe+D0zN67raFvscPmi3+Lqp+DZDiKgKcJoJ609Y95umQ9Y6UaRQJQvxEOb4xmYOD0EMLmxyhEAUNfNH+a2WZEoUpHk6s/Ndx0a89hxd2aJ4QoQd5 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(396003)(346002)(376002)(136003)(366004)(451199021)(6512007)(6506007)(53546011)(26005)(6486002)(83380400001)(36756003)(2616005)(38100700002)(31696002)(86362001)(186003)(41300700001)(478600001)(2906002)(54906003)(31686004)(5660300002)(66476007)(66556008)(6916009)(4326008)(316002)(8936002)(8676002)(66946007)(66899021)(522954003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TEcyODlvN3JwUG1mckE4V0QwalpmR290bWVEcTVuZlMxSU1tZU9DYnYrSXUx?= =?utf-8?B?OWJXWmtKWXFySVVRekY0eGFZaEhMTUhjUjNlbUVCd3pjeEYzUStLRW85cVFF?= =?utf-8?B?a1lxY0xDVlJWZHcxQyt0ZU9zVU9mZGN1SFZnNzE5aWVhbWxMUDJYWlpDOFoy?= =?utf-8?B?K1AxWWw2SU9WOVZJNDJPRUgzMmFEcEhvcUp6dXdpVmhGSVpKSFA5Y1M5bm9U?= =?utf-8?B?OXpjN3Y1U0ZQYTFKNERsclhINGhRREFFV28vV2lDOHFHcTZjVjlJb1Vxd2Vt?= =?utf-8?B?ZXV0WEhoT2NSZnZQOURtYnJxY3VDK0xLNUVNT3F6L2NpQ2w4dVliVFVmTVJs?= =?utf-8?B?MnlWRGdzNU1DOWZjV0Y2bENrMHowMkk0eWdyUlc1OEhFajJoZVpBWnVRL3ZU?= =?utf-8?B?MHVodlNtcWoycmxEeTU2R25HVlYwbmxYZUVCWUM4Z0xmM3E3WDVPOGZnUzNU?= =?utf-8?B?ZzV3YnFPL2ZhRWVleWNpa1QwdEJwTE03aXVUL2EwOHdyOGtQL3ltOUZleDNT?= =?utf-8?B?Z3pMVnNDUWd6Mmc5LzFaenc0VDN3amRiNWVzK0gzclJOU3NwQ0Q3TmdsSnFX?= =?utf-8?B?N3o0bHFaY2FTcmVUb25KRjMxckoxWUpnbXUvMFNyZjJEWlVFTVI3UFZRR3po?= =?utf-8?B?Sks3aktlZzllbmd2SVhMeFJxaGw3NHJYOUlZT0o4SnlOSGJhZTJsdjFsKzZU?= =?utf-8?B?UGtrMW5QM0p1QjFxci9XMFRpMm95WktXUVk3ZGpaZHlvaEp2K29RbERtanNo?= =?utf-8?B?Y2lyUUlCZ1JDTnJXQ2RERmJ3TXVkb0drRnlXdERvbGZoUEF2djdDR0s2Y3pW?= =?utf-8?B?Ly95Ym84bkN0bTRWQUhMRlJDaGREZ0pleUdXVDh3N2tSYkVoWUQrZUc0NGhn?= =?utf-8?B?aGdGV2FYU0w2OWd1RE9rbDgwallEQnViNVZobWJrdDl3OG9rdTJsTE9admc0?= =?utf-8?B?T0I5WlF6cHp4YW5ZTk9RbUFEY1ZZQ29qMlBoeFdUY1ROUnRKNHVvWU1WRzBI?= =?utf-8?B?Siszbm9PcHArR3lQWGdJT3BKdnFtVXJPaUZSR2dSanhaWXh3OWVIcGt5blNK?= =?utf-8?B?QUFDV2V2RVBZbTJSRGFhNlRRY2kxUTBqc1lWV1VKR1ZEQUFVOWI0dE16OTgx?= =?utf-8?B?bmdLb3lEd0JVZ043aDNzNHF4YWc2bGs2ZUhJc2Nib2FwS2RtZU53VEVhWFZz?= =?utf-8?B?eVJLUmRKaDZmL2xoMkwxOS9mZTdKbFk3OXgvSGRBaDNhdUJSVFBzWDlSdVZJ?= =?utf-8?B?cUlRdjZlUVhvZVh1cGxaVE5mcXJxMm5LQWI5OXZvQkpXL2VtaXhQYitnZ29Q?= =?utf-8?B?Yk9NNzFaOWNpL2RFdXNEV0c5Zlp0Q1VWcEo5aVlCenRyZ3RZakFhUnduVm9a?= =?utf-8?B?VjJ2Z3NjZXhCSjZ1dUNlWkZaTjZ3R2pWZ1IxTGJqc1doU082YTJmTTVNU29p?= =?utf-8?B?cWl5TjNMRm1CLzNESTZYc2N1azZwSkZvU1JGd3RqVHVUdis1d0ZWUGxyb2hn?= =?utf-8?B?VXJ6TEhlbU5kbEl4bTFhTitYTVZQT2UyVDJDcXYreE42RklobHZYazdxVmE5?= =?utf-8?B?RllMcUpEV1lxUlV4YzQ4N0plWVNScitneGpPdDllVVRYekpkWmRXYW40WG5F?= =?utf-8?B?ZTMwam5ES1RHclZOOGxIbXNBbTMySjNuMm5TV3Fva2FZeHl4dkhOVFdRSS9a?= =?utf-8?B?V1N3L3BRWUpxenFsV3lNMDhpcnQ5aTRMamtUZlM4TUJSU3JUTHhlM3lvVDdR?= =?utf-8?B?USttb1dwUGdiQVNZSjBrM2RrUUg5RlYrU0wrL2VKbUJnaDNJWCtXT2p0SU1R?= =?utf-8?B?T0hVenlzR0MxZXA3Smh0VnBDNFZjQ1lJUFJGWFlJNnNSU1Ztb0llQkVWSWRJ?= =?utf-8?B?UWl6NHZVeW50cVhOdVY3d2RqTENGSUdKdGRuUDljY3FkTi9sTjhQQUQvU2Fa?= =?utf-8?B?amprSGp1WVI1QU1HNHhLM2IzazdreFcwTGM3UitnMFZPV24wRDZUYVo3VkhO?= =?utf-8?B?SmNOclNqWWlxWCtBK1AzTUFFVFFzRVRtTC91bEhRamJQdC9pTklBZ0NaTkZX?= =?utf-8?B?TnQxUTFiZ3JwLzlodXJoVktKamFHeVdOME4xVEMyU3RIL2hQRFZmQS9FbmYz?= =?utf-8?Q?M5uO+ThGr3Kopmx8x0jm/QbfA?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c4df971d-cd86-4453-3361-08db4f982495 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 07:45:07.2080 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bpC4a1X7/d7AsYtoNRWfAL7DQFkM6gt8Gty0S7yQ95f9eXoZWXvk9z+ltUAkXiq5eki3j2HqV4QSGgN785belw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9403 On 04.05.2023 21:39, Andrew Cooper wrote: > When adding new words to a featureset, there is a reasonable amount of > boilerplate and it is preforable to split the addition into multiple patches. > > GCC 12 spotted a real (transient) error which occurs when splitting additions > like this. Right now, FEATURESET_NR_ENTRIES is dynamically generated from the > highest numeric XEN_CPUFEATURE() value, and can be less than what the > FEATURESET_* constants suggest the length of a featureset bitmap ought to be. > > This causes the policy <-> featureset converters to genuinely access > out-of-bounds on the featureset array. > > Rework X86_NR_FEAT to be related to FEATURESET_* alone, allowing it > specifically to grow larger than FEATURESET_NR_ENTRIES. > > Reported-by: Jan Beulich > Signed-off-by: Andrew Cooper While, like you, I could live with the previous patch even if I don't particularly like it, I'm not convinced of the route you take here. Can't we instead improve build-time checking, so the issue spotted late in the build by gcc12 can be spotted earlier and/or be connected better to the underlying reason? One idea I have would deal with another aspect I don't like about our present XEN_CPUFEATURE() as well: The *32 that's there in every use of the macro. How about XEN_CPUFEATURE(FSRCS, 10, 12) /*A Fast Short REP CMPSB/SCASB */ as the common use and e.g. XEN_CPUFEATURE(16) or (if that ends up easier in gen-cpuid-py and/or the public header) something like XEN_CPUFEATURE(, 16, ) as the placeholder required for (at least trailing) unpopulated slots? Of course the macro used may also be one of a different name, which may even be necessary to keep the public header reasonably simple; maybe as much as avoiding use of compiler extensions there. (This would then mean to leave alone XEN_CPUFEATURE(), and my secondary adjustment would perhaps become an independent change to make.) > To preempt what I expect will be the first review question, no FEATURESET_* > can't become an enumeration, because the constants undergo token concatination > in the preprocess as part of making DECL_BITFIELD() work. Just as a remark: I had trouble understanding this. Which was a result of you referring to token concatenation being the problem (which is fine when the results are enumerators), when really the issue is with the result of the concatenation wanting to be expanded to a literal number. Then again - do CPUID_BITFIELD_ really need to be named that way? Couldn't they equally well be CPUID_BITFIELD_1d, CPUID_BITFIELD_e1c, and alike, thus removing the need for intermediate macro expansion? Jan From xen-devel-bounces@lists.xenproject.org Mon May 08 08:59:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 08:59:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531302.826875 (Exim 4.92) (envelope-from ) id 1pvwhj-0005Oa-7Y; Mon, 08 May 2023 08:58:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531302.826875; Mon, 08 May 2023 08:58:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvwhj-0005OE-1I; Mon, 08 May 2023 08:58:47 +0000 Received: by outflank-mailman (input) for mailman id 531302; Mon, 08 May 2023 08:58:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvwhh-0005O8-LX for xen-devel@lists.xenproject.org; Mon, 08 May 2023 08:58:45 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0609.outbound.protection.outlook.com [2a01:111:f400:fe02::609]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 882dd0b1-ed7e-11ed-8611-37d641c3527e; Mon, 08 May 2023 10:58:43 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS1PR04MB9455.eurprd04.prod.outlook.com (2603:10a6:20b:4d8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.25; Mon, 8 May 2023 08:58:40 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c%4]) with mapi id 15.20.6363.031; Mon, 8 May 2023 08:58:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 882dd0b1-ed7e-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fPgeT+f6Yjxm99p+kwwV3Na2TYYFl7636mLjD5uXp72T/0kD/nA9aRN8OBrmOz+XB95yH5sqYSxirZYnIY4gGpfS0zp3m0fMMX9/37hgz98pODAswg4TOFnApwAW9mSS1PS/4tkYIrzE/1RZpOzYXfyTEu/3RVqQbDSnvO/7XihNNW08FVajejzhC2kiWv2ufe6JvyyVmWkhKms4qbXTIWmCFd+kE//abVSozGuSQ5n+Oxz0+KDvFQNpJYwKjJCrqT16uSV4AIQBxlOcEXs0V0mCkZRSl2214qd1XDGl1/0oKRkCzNmSQiz1L/jn9hVLKlSONXHIgy5MJRyG2QechA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3EL6ZrgkM24n1dJrDjr80nVR/ElPrBMW09G6XzgUZYk=; b=UqFVz0vfUiv2fa4lK7KRUunQlk1SK1oE2NSmt0tLSr7Z6T/Co4pLgVuDu/DN6b8jiSiYUYyPkLO9CqZ68tdt7w1dx07A5GwQDX2ncpbl9YjbGrLTnBi68AIchPb7EQAFhMPl+iuS/7NGeBaqjYUqi4VU4WDvVtGU6Jhh59lyTcILWhfweHU5ZkNFNcQddCfeYGzFjh7DNBIR5F9w51oiwNGjMlWCIRXnlkuhXRjl74Q76vPi8nqSbejwgxbbp9SLbuFWqG+D4I1yhZNQk938kmMQXSkmM0gy8xlA155IFkYcDvRBeLcRW9xtg9hS51RW8jCN+z43M7cEzm+1Ua8Njw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3EL6ZrgkM24n1dJrDjr80nVR/ElPrBMW09G6XzgUZYk=; b=HWmivzP/XgSoqU4zxE3FiUMe1XhY9IfVFGlEbob/80qSYHXmSDilcL27xbG40aFsPLI090T+M8nwvjX0O43/zDmf0+r+4kLN192euTYh6990jXgKwnZi+tb8/ymFYolKbK4DbVtCQ2HZLngIqPVOIT9gQJ1feKLiiH4F1AnFrFzY2XewaSzkmilZHrl5po8PzYUVySxCBzRnGAjeHAgRWgDOLwVJ4P5rJzWQRCqVkTtxw46PvVpSQjBtn8PcoN7LLcEIdcgUdhMiPjWqXK5ESx1U/iZqAcuTBYUoEJA551pkfv0ZKv6RVinKZCQMumwwM9J0g+oOdsA+a2FN5ehEag== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0533b045-f4cb-0834-ae88-9229bd816cf2@suse.com> Date: Mon, 8 May 2023 10:58:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v6 2/4] xen/riscv: introduce setup_initial_pages Content-Language: en-US To: Oleksii Kurochko Cc: Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR04CA0117.eurprd04.prod.outlook.com (2603:10a6:208:55::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS1PR04MB9455:EE_ X-MS-Office365-Filtering-Correlation-Id: 7b094322-54b8-4480-149e-08db4fa26a82 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +bXLWORfFJYX7l6WtLwL04HkLxaxFPJRd3f+cr8b2UCbZPPwHRvrI3yMnWJyNf5XYp/bLsHX82FnuDwzEh4YcF5uSNy0Rm5aTgJSEArxeUCYmBakiywKk5Sycj4BGmncg3X4GOH4IVbWZVyXnvd0iSVttjjgBU4pCULnbsZdosxu1GlSMByTrtdu47Cpic9if+iERCafu95GGfMpspKekvPlJKtIC+vvj4wFFgYvu841YCykbZfqipFFo6OkioZb3JmUPfj5+nAaQfsA+K9LUJxC4dC0UVlUtWbMD/IwS+vGSB0nSBEK9glIhgfF4gTEKw2W1VAMB7vzASZ4q1ldFsbnZxAlRW4uoLT4um3bdtvpwXHDZyq7t7T9iXbfOCPrZSvdk6LmHMSjyx1gTBafkRpVPsaW50cHP7uUdE0TDXJ7H0vFL1Pd8+MC8uyJ3epiX6b+LiaqRxoXsFTWBpx15ERUd+LVZRhtcZ35Ndf+zYvgj7cn2TBegMGYQz5Vc8AUD5VCHjX8Re61Coimei8jXhZaEuUKIxe8FW81ABVBRwJsrU7Stfe8RNcPFF1QHXHAisyH7/0XjfyHTw92yY6bmBty9wVFMquiQvoyVX0nS3NiPfLtJkN031jYmCLYPzEvxjTYW3Wp4Hu9cs4Y9NuJyA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(136003)(376002)(346002)(39860400002)(366004)(451199021)(31686004)(66946007)(66556008)(66476007)(6916009)(4326008)(478600001)(6486002)(316002)(6666004)(54906003)(86362001)(31696002)(36756003)(83380400001)(2616005)(53546011)(6512007)(6506007)(26005)(8936002)(5660300002)(41300700001)(8676002)(30864003)(2906002)(186003)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S3NLcCtYemFubVo2RW4xUlRidEpXM0x2WVZxb0I1aEpBSVhpU1hKb1YxeEJz?= =?utf-8?B?TmVlemVaYUZ2TG9yclNneFVXTUphb2tFNUFDNTZLSk9ESjRqWnpPbjhMV2Iy?= =?utf-8?B?T2FXRS9UWklTOFN4SXFlLzhwNVl6K2hxdG9sWVFJMmp2eW9lRVFxcHkxcCsy?= =?utf-8?B?Q2xKOHIzb1o1MWZvaC9DVWRUN05wMGh0VE1rTDcvN0pUMm50OFFBcWVIQU5x?= =?utf-8?B?ZFRaWFdoLzVubC9xU2JjZDZsVy9mSEh3eDFNczREUVNiclJEcVlsdkYvRm00?= =?utf-8?B?ZytQNkdYVzZWTG5KZnhBdFl1R09TQU5kOTRBN09oRmRrZ1ZpaGF2RUxmSUdN?= =?utf-8?B?WFczdnJQQlpOcEw1c0xVR0k2VXRvd01waXBUYUZGWHRuWkxUUWJvanU0czJC?= =?utf-8?B?WjA1ckp5NXNnR2plbkpPM09meWx3QlNOeTVwU3RVb2dCbEp3SGh4bmd4STE5?= =?utf-8?B?UHR2dFQ2d0NJU2Z2ZW5nVDYwRXp6dFphVnA5YmlmS3NLSkJFbzk1cXVUbCtn?= =?utf-8?B?aWJrLzlyVHdSTnJyVmFRT2lweEw2SkZpaFNOdmdCSlZmd2dVZVlOVHVpTjBL?= =?utf-8?B?eFh5ZENGSWd0bmRKdnErUDZGVStBU1kvWVFWUzhsU2hhV0tILzlnMHhNc0dQ?= =?utf-8?B?d1Z2aXlLK2ErOHlsajZxOFpUMS9uRUJJY3d6aFVHZ09XUG5tOUdqbTltVEVk?= =?utf-8?B?bGNyTGlWSHpIY0Z3QmlTTzVDMnVxaE1yRVdPK0x0anQwVnlKMDZIZk1zS2FE?= =?utf-8?B?Z1p1Z1AvbzdxcFpqWU55REJGb3hnUDlSTk9TelpzTHZpZVhxd0NKeXJwSyt1?= =?utf-8?B?cjk0NjBFT25td2pieHc5TGV4akIzZ0RQY2w3b0ptSXZUZVpUenlxcFpGQ3dl?= =?utf-8?B?VnQ0NlljOXJWcU5jUnhOcUIrWlE5MnlwZktsNEhha1pYN3owNTdWV01HL0t6?= =?utf-8?B?Rk1RUjFFQk80a28yMTh5Z2x3eUNlUTk3VE1aTmFaMjVxaHVXTndaRTNrNitS?= =?utf-8?B?MDd1VG5IR1dWOFlHU0V4TXhVdkpIa2dTc3FTckloZW44KzhFNjBycVMzelBp?= =?utf-8?B?cDlrSksvbGlpS2F3dXRQTnlpRDlSZHNWMDdEa2QyZ0k0ZEtyR3NrYUpiMGhH?= =?utf-8?B?WDVHaEZ2VUlNcGJYazdyVTNubGlFY2Z2VmVnc0g4eWhscWJTblZscE8xMFFZ?= =?utf-8?B?VmtkaVN1cm1vOE9FT1hnYTZCZkllbWRnNi9BWjA3YjduT2NsMWdrSjBiTXFP?= =?utf-8?B?S3N0T21UY3RaRXEzc3JjVEdJaDhpNC81QVFXT0ZFSE5FcVF6Vm9aK1RjUFlC?= =?utf-8?B?MEVHK2RNbmlEYVNMUHowZFlER29wbHViNzFudENVYXJOSnZBTjJNTm5FVHdU?= =?utf-8?B?Skdlc3Rya0dnZlQwTHRYMzJkTUMwNVNjYkdZeko1NWVJV0hJVmk2N1BiYk5Q?= =?utf-8?B?bkNhRkxzaWxVUnhHdlpKaHMrNncyWDBrbEJKZTZoUnVKeSt1S0FqMnVIVnBF?= =?utf-8?B?Tmx2SGM5SGRRdEhTckwrMDQ2RE15dHhFVkp1a25oOW1CTTVJWXAvZmNDL0JI?= =?utf-8?B?WklEWEwra2FDaGlPUlQySm1aS2ZmTFAxNCt1UWI1bVpoRndDdjlJRXo1MW1V?= =?utf-8?B?Y1ZnckppY3cxc0ZtZk1TeHRuTW9OQlJ0N3kxR3JjOEtlNE84Q2RZcXBUM3lD?= =?utf-8?B?cThlb2VWYWhreDhzNXNWWlV4SWdVeUh5Rnh0ZXBmNlZXaWNHUXlEb2x5MVZZ?= =?utf-8?B?YlU1RG9wdzJjUjZZNnZrUDJxVXo1MVdZV3E4Z0I4bUxRZjc5MHUvQ29mOWNs?= =?utf-8?B?YWVmbTBZUXNMcUthK2lYVHBCYnNaSE1qSDJaOTNBQ3BSb2dIby9HWFN1eVNX?= =?utf-8?B?bWlMYjliR1lQVWVhS3o4ZFJpQUx3OTVCQVl4MEc5Y1p4S2d3d0o4ZU5IZ3Ur?= =?utf-8?B?KzROT3ZadHVndVFQMGsrZVhlMzY4YmRjbGE2cjNmbWlOYlZtL1hQMVlDRVdF?= =?utf-8?B?c01QNDlDWXFJVi9ONWdzMksrd2k2SzlSVnVaUjRwMnhrYlBtOXRWbkwzaHB2?= =?utf-8?B?ekhDTWJRRnlCdy8xbTVPWDNiRXhJZDFoZERvOGo3R0NmR1lDVEJJN1crMVI1?= =?utf-8?Q?5H6mqrezS52OJ5IWlUIdPGU6S?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b094322-54b8-4480-149e-08db4fa26a82 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 08:58:39.4982 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: do41envXp+MuNom/I54rbH9pmSbC7B9VZkCu/9etSKZ31sAJiNuNwRwnHzq3CLAly2Lh6mdUsICJSKfATyafyg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9455 On 03.05.2023 18:31, Oleksii Kurochko wrote: > --- a/xen/arch/riscv/include/asm/config.h > +++ b/xen/arch/riscv/include/asm/config.h > @@ -70,12 +70,23 @@ > name: > #endif > > -#define XEN_VIRT_START _AT(UL, 0x80200000) > +#ifdef CONFIG_RISCV_64 > +#define XEN_VIRT_START 0xFFFFFFFFC0000000 /* (_AC(-1, UL) + 1 - GB(1)) */ > +#else > +#error "RV32 isn't supported" > +#endif > > #define SMP_CACHE_BYTES (1 << 6) > > #define STACK_SIZE PAGE_SIZE > > +#ifdef CONFIG_RISCV_64 > +#define CONFIG_PAGING_LEVELS 3 > +#define RV_STAGE1_MODE SATP_MODE_SV39 > +#else #define CONFIG_PAGING_LEVELS 2 (or else I would think ... > +#define RV_STAGE1_MODE SATP_MODE_SV32 ... this and hence the entire "#else" should also be omitted) > --- /dev/null > +++ b/xen/arch/riscv/include/asm/current.h > @@ -0,0 +1,10 @@ > +#ifndef __ASM_CURRENT_H > +#define __ASM_CURRENT_H > + > +#define switch_stack_and_jump(stack, fn) \ > + asm volatile ( \ > + "mv sp, %0 \n" \ > + "j " #fn :: "r" (stack) : \ > + ) Nit: Style. Our normal way of writing this would be #define switch_stack_and_jump(stack, fn) \ asm volatile ( \ "mv sp, %0\n" \ "j " #fn :: "r" (stack) ) i.e. unnecessary colon omitted, no trailin blank on any generated assembly line, and closing paren not placed on its own line (only closing figure braces would normally live on their own lines). However, as to the 3rd colon: Can you really get away here without a memory clobber (i.e. the construct being a full compiler barrier)? Further I think you want to make the use of "fn" visible to the compiler, by using an "X" constraint just like Arm does. Finally I think you want to add unreachable(), like both Arm and x86 have it. Plus the "noreturn" on relevant functions. > --- /dev/null > +++ b/xen/arch/riscv/include/asm/page.h > @@ -0,0 +1,62 @@ > +#ifndef _ASM_RISCV_PAGE_H > +#define _ASM_RISCV_PAGE_H > + > +#include > +#include > + > +#define VPN_MASK ((unsigned long)(PAGETABLE_ENTRIES - 1)) > + > +#define XEN_PT_LEVEL_ORDER(lvl) ((lvl) * PAGETABLE_ORDER) > +#define XEN_PT_LEVEL_SHIFT(lvl) (XEN_PT_LEVEL_ORDER(lvl) + PAGE_SHIFT) > +#define XEN_PT_LEVEL_SIZE(lvl) (_AT(paddr_t, 1) << XEN_PT_LEVEL_SHIFT(lvl)) > +#define XEN_PT_LEVEL_MAP_MASK(lvl) (~(XEN_PT_LEVEL_SIZE(lvl) - 1)) > +#define XEN_PT_LEVEL_MASK(lvl) (VPN_MASK << XEN_PT_LEVEL_SHIFT(lvl)) > + > +#define PTE_VALID BIT(0, UL) > +#define PTE_READABLE BIT(1, UL) > +#define PTE_WRITABLE BIT(2, UL) > +#define PTE_EXECUTABLE BIT(3, UL) > +#define PTE_USER BIT(4, UL) > +#define PTE_GLOBAL BIT(5, UL) > +#define PTE_ACCESSED BIT(6, UL) > +#define PTE_DIRTY BIT(7, UL) > +#define PTE_RSW (BIT(8, UL) | BIT(9, UL)) > + > +#define PTE_LEAF_DEFAULT (PTE_VALID | PTE_READABLE | PTE_WRITABLE) > +#define PTE_TABLE (PTE_VALID) > + > +/* Calculate the offsets into the pagetables for a given VA */ > +#define pt_linear_offset(lvl, va) ((va) >> XEN_PT_LEVEL_SHIFT(lvl)) > + > +#define pt_index(lvl, va) pt_linear_offset(lvl, (va) & XEN_PT_LEVEL_MASK(lvl)) Maybe better #define pt_index(lvl, va) (pt_linear_offset(lvl, va) & VPN_MASK) as the involved constant will be easier to use for the compiler? > +/* Page Table entry */ > +typedef struct { > +#ifdef CONFIG_RISCV_64 > + uint64_t pte; > +#else > + uint32_t pte; > +#endif > +} pte_t; > + > +#define pte_to_addr(x) (((paddr_t)(x) >> PTE_PPN_SHIFT) << PAGE_SHIFT) > + > +#define addr_to_pte(x) (((x) >> PAGE_SHIFT) << PTE_PPN_SHIFT) Are these two macros useful on their own? I ask because I still consider them somewhat misnamed, as they don't produce / consume a PTE (but the raw value). Yet generally you want to avoid any code operating on raw values, using pte_t instead. IOW I would hope to be able to convince you to ... > +static inline pte_t paddr_to_pte(paddr_t paddr, > + unsigned int permissions) > +{ > + return (pte_t) { .pte = addr_to_pte(paddr) | permissions }; > +} > + > +static inline paddr_t pte_to_paddr(pte_t pte) > +{ > + return pte_to_addr(pte.pte); > +} ... expand them in the two inline functions and then drop the macros. > --- /dev/null > +++ b/xen/arch/riscv/mm.c > @@ -0,0 +1,315 @@ > +#include > +#include > +#include > +#include > + > +#include > +#include No inclusion of asm/config.h (or xen/config.h) in any new code please. For quite some time xen/config.h has been forcefully included everywhere by the build system. > +/* > + * It is expected that Xen won't be more then 2 MB. > + * The check in xen.lds.S guarantees that. > + * At least 3 page (in case of Sv39 ) > + * tables are needed to cover 2 MB. I guess this reads a little better as "At least 3 page tables (in case of Sv39) ..." or "At least 3 (in case of Sv39) page tables ..." Also could I talk you into using the full 80 columns instead of wrapping early in the middle of a sentence? > One for each page level > + * table with PAGE_SIZE = 4 Kb > + * > + * One L0 page table can cover 2 MB > + * (512 entries of one page table * PAGE_SIZE). > + * > + */ > +#define PGTBL_INITIAL_COUNT ((CONFIG_PAGING_LEVELS - 1) + 1) Hmm, did you lose the part of the comment explaining the "+ 1"? Or did the need for that actually go away (and you should drop it here)? > +#define PGTBL_ENTRY_AMOUNT (PAGE_SIZE / sizeof(pte_t)) Isn't this PAGETABLE_ENTRIES (and the constant hence unnecessary)? > +static void __init setup_initial_mapping(struct mmu_desc *mmu_desc, > + unsigned long map_start, > + unsigned long map_end, > + unsigned long pa_start, > + unsigned int permissions) What use is the last parameter, when the sole caller passes PTE_LEAF_DEFAULT (i.e. a build-time constant)? Then ... > +{ > + unsigned int index; > + pte_t *pgtbl; > + unsigned long page_addr; > + pte_t pte_to_be_written; > + unsigned long paddr; > + unsigned int tmp_permissions; ... this variable (which would better be of more narrow scope anyway, like perhaps several more of the above) could also have its tmp_ prefix dropped afaict. > + if ( (unsigned long)_start % XEN_PT_LEVEL_SIZE(0) ) > + { > + early_printk("(XEN) Xen should be loaded at 4k boundary\n"); > + die(); > + } > + > + if ( map_start & ~XEN_PT_LEVEL_MAP_MASK(0) || > + pa_start & ~XEN_PT_LEVEL_MAP_MASK(0) ) > + { > + early_printk("(XEN) map and pa start addresses should be aligned\n"); > + /* panic(), BUG() or ASSERT() aren't ready now. */ > + die(); > + } > + > + for ( page_addr = map_start; page_addr < map_end; page_addr += XEN_PT_LEVEL_SIZE(0) ) Nit: Style (line looks to be too long now). for ( page_addr = map_start; page_addr < map_end; page_addr += XEN_PT_LEVEL_SIZE(0) ) is the way we would typically wrap it, but for ( page_addr = map_start; page_addr < map_end; page_addr += XEN_PT_LEVEL_SIZE(0) ) would of course also be okay if you preferred that. > + { > + pgtbl = mmu_desc->pgtbl_base; > + > + switch ( mmu_desc->num_levels ) > + { > + case 4: /* Level 3 */ > + HANDLE_PGTBL(3); > + case 3: /* Level 2 */ > + HANDLE_PGTBL(2); > + case 2: /* Level 1 */ > + HANDLE_PGTBL(1); > + case 1: /* Level 0 */ > + index = pt_index(0, page_addr); > + paddr = (page_addr - map_start) + pa_start; > + > + tmp_permissions = permissions; > + > + if ( is_kernel_text(LINK_TO_LOAD(page_addr)) || > + is_kernel_inittext(LINK_TO_LOAD(page_addr)) ) Nit: Style (and I'm pretty sure I did comment on this kind of too deep indentation already). > + tmp_permissions = > + PTE_EXECUTABLE | PTE_READABLE | PTE_VALID; > + > + if ( is_kernel_rodata(LINK_TO_LOAD(page_addr)) ) > + tmp_permissions = PTE_READABLE | PTE_VALID; > + > + pte_to_be_written = paddr_to_pte(paddr, tmp_permissions); > + > + if ( !pte_is_valid(pgtbl[index]) ) > + pgtbl[index] = pte_to_be_written; > + else > + { > + /* > + * get an adresses of current pte and that one to > + * be written > + */ Nit: Style (one missing blank each in the last three lines, and comment text wants to start with a capital letter). > + unsigned long curr_pte = > + pgtbl[index].pte & ~(PTE_DIRTY | PTE_ACCESSED); While technically "unsigned long" is okay to use here (afaict), I'd still recommend ... > + pte_to_be_written.pte &= ~(PTE_DIRTY | PTE_ACCESSED); > + > + if ( curr_pte != pte_to_be_written.pte ) ... doing everything in terms of pte_t: pte_t curr_pte = pgtbl[index]; curr_pte.pte &= ~(PTE_DIRTY | PTE_ACCESSED); pte_to_be_written.pte &= ~(PTE_DIRTY | PTE_ACCESSED); if ( curr_pte.pte != pte_to_be_written.pte ) or perhaps even simply if ( (pgtbl[index].pte ^ pte_to_be_written.pte) & ~(PTE_DIRTY | PTE_ACCESSED) ) > + { > + early_printk("PTE overridden has occurred\n"); > + /* panic(), aren't ready now. */ > + die(); > + } > + } > + } > + } > + #undef HANDLE_PGTBL Nit: Such an #undef, even if technically okay either way, would imo better live in the same scope (and have the same indentation) as the corresponding #define. Since your #define is ahead of the function, it would ... > +} ... then live here. > +static void __init calc_pgtbl_lvls_num(struct mmu_desc *mmu_desc) Nit: Double blank after "struct". > +{ > + unsigned long satp_mode = RV_STAGE1_MODE; > + > + /* Number of page table levels */ > + switch (satp_mode) > + { > + case SATP_MODE_SV32: > + mmu_desc->num_levels = 2; > + break; > + case SATP_MODE_SV39: > + mmu_desc->num_levels = 3; > + break; > + case SATP_MODE_SV48: > + mmu_desc->num_levels = 4; > + break; > + default: > + early_printk("(XEN) Unsupported SATP_MODE\n"); > + die(); > + } > +} Do you really need this function anymore? Isn't it now simply mmu_desc.num_levels = CONFIG_PAGING_LEVELS? in the caller? WHich could then even be the variable's initializer there? > +static bool __init check_pgtbl_mode_support(struct mmu_desc *mmu_desc, > + unsigned long load_start, > + unsigned long satp_mode) > +{ > + bool is_mode_supported = false; > + unsigned int index; > + unsigned int page_table_level = (mmu_desc->num_levels - 1); > + unsigned level_map_mask = XEN_PT_LEVEL_MAP_MASK(page_table_level); > + > + unsigned long aligned_load_start = load_start & level_map_mask; > + unsigned long aligned_page_size = XEN_PT_LEVEL_SIZE(page_table_level); > + unsigned long xen_size = (unsigned long)(_end - start); > + > + if ( (load_start + xen_size) > (aligned_load_start + aligned_page_size) ) > + { > + early_printk("please place Xen to be in range of PAGE_SIZE " > + "where PAGE_SIZE is XEN_PT_LEVEL_SIZE( {L3 | L2 | L1} ) " > + "depending on expected SATP_MODE \n" > + "XEN_PT_LEVEL_SIZE is defined in \n"); > + die(); > + } > + > + index = pt_index(page_table_level, aligned_load_start); > + stage1_pgtbl_root[index] = paddr_to_pte(aligned_load_start, > + PTE_LEAF_DEFAULT | PTE_EXECUTABLE); > + > + asm volatile ( "sfence.vma" ); > + csr_write(CSR_SATP, > + PFN_DOWN((unsigned long)stage1_pgtbl_root) | > + satp_mode << SATP_MODE_SHIFT); > + > + if ( (csr_read(CSR_SATP) >> SATP_MODE_SHIFT) == satp_mode ) > + is_mode_supported = true; Just as a remark: While plain shift is kind of okay here, because the field is the top-most one in the register, generally you will want to get used to MASK_EXTR() (and MASK_INSR()) in cases like this one. > + csr_write(CSR_SATP, 0); > + > + /* Clean MMU root page table */ > + stage1_pgtbl_root[index] = paddr_to_pte(0x0, 0x0); > + > + asm volatile ( "sfence.vma" ); Doesn't this want to move between the SATP write and the clearing of the root table slot? Also here and elsewhere - don't these asm()s need memory clobbers? And anyway - could I talk you into introducing an inline wrapper (e.g. named sfence_vma()) so all uses end up consistent? > +void __init setup_initial_pagetables(void) > +{ > + struct mmu_desc mmu_desc = { 0, 0, NULL, NULL }; > + > + /* > + * Access to _stard, _end is always PC-relative Nit: Typo-ed symbol name. Also ... > + * thereby when access them we will get load adresses > + * of start and end of Xen > + * To get linker addresses LOAD_TO_LINK() is required > + * to use > + */ see the earlier line wrapping remark again. Finally in multi-sentence comments full stops are required. > + unsigned long load_start = (unsigned long)_start; > + unsigned long load_end = (unsigned long)_end; > + unsigned long linker_start = LOAD_TO_LINK(load_start); > + unsigned long linker_end = LOAD_TO_LINK(load_end); > + > + if ( (linker_start != load_start) && > + (linker_start <= load_end) && (load_start <= linker_end) ) > + { > + early_printk("(XEN) linker and load address ranges overlap\n"); > + die(); > + } > + > + calc_pgtbl_lvls_num(&mmu_desc); > + > + if ( !check_pgtbl_mode_support(&mmu_desc, load_start, RV_STAGE1_MODE) ) It is again questionable here whether passing a constant to a function at its sole call site is really useful. > +void __init noinline enable_mmu() > +{ > + /* > + * Calculate a linker time address of the mmu_is_enabled > + * label and update CSR_STVEC with it. > + * MMU is configured in a way where linker addresses are mapped > + * on load addresses so in a case when linker addresses are not equal > + * to load addresses, after MMU is enabled, it will cause > + * an exception and jump to linker time addresses. > + * Otherwise if load addresses are equal to linker addresses the code > + * after mmu_is_enabled label will be executed without exception. > + */ > + csr_write(CSR_STVEC, LOAD_TO_LINK((unsigned long)&&mmu_is_enabled)); > + > + /* Ensure page table writes precede loading the SATP */ > + asm volatile ( "sfence.vma" ); > + > + /* Enable the MMU and load the new pagetable for Xen */ > + csr_write(CSR_SATP, > + PFN_DOWN((unsigned long)stage1_pgtbl_root) | > + RV_STAGE1_MODE << SATP_MODE_SHIFT); > + > + asm volatile ( ".align 2" ); May I suggest to avoid .align, and to prefer .balign and .p2align instead? This helps people coming from different architectures, as which of the two .align resolves to is arch-dependent. > --- a/xen/arch/riscv/riscv64/head.S > +++ b/xen/arch/riscv/riscv64/head.S > @@ -1,4 +1,5 @@ > #include > +#include > #include > > .section .text.header, "ax", %progbits How does a need for this arise all of the sudden, without other changes to this file? Is this maybe a leftover which wants dropping? > --- a/xen/arch/riscv/xen.lds.S > +++ b/xen/arch/riscv/xen.lds.S > @@ -137,6 +137,7 @@ SECTIONS > __init_end = .; > > .bss : { /* BSS */ > + . = ALIGN(POINTER_ALIGN); > __bss_start = .; > *(.bss.stack_aligned) > . = ALIGN(PAGE_SIZE); Doesn't this want to be a separate change? Jan From xen-devel-bounces@lists.xenproject.org Mon May 08 09:01:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 09:01:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531309.826885 (Exim 4.92) (envelope-from ) id 1pvwkD-0006rk-Ol; Mon, 08 May 2023 09:01:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531309.826885; Mon, 08 May 2023 09:01:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvwkD-0006rd-LJ; Mon, 08 May 2023 09:01:21 +0000 Received: by outflank-mailman (input) for mailman id 531309; Mon, 08 May 2023 09:01:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvwkC-0006rX-BF for xen-devel@lists.xenproject.org; Mon, 08 May 2023 09:01:20 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20610.outbound.protection.outlook.com [2a01:111:f400:7eaf::610]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e5b0439a-ed7e-11ed-b226-6b7b168915f2; Mon, 08 May 2023 11:01:19 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS1PR04MB9455.eurprd04.prod.outlook.com (2603:10a6:20b:4d8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.25; Mon, 8 May 2023 09:01:18 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c%4]) with mapi id 15.20.6363.031; Mon, 8 May 2023 09:01:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e5b0439a-ed7e-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jKPQS3CSGm5j+Ov/BNyzfGf9DAZyYfSk0BbwErMLvK4c0UoFHrbiRcBFbL4cd0kB6204mGEC3Uq5Qdnq/VnvKxbL6a1k7lc6mhcccDCojzCnXGrfDcMqC9N1lNq1Rw55GZ59TdBcsrZ0bTW1JEOT8MRpqI2Kpfm2g4nc8D7bvqgXFOkCWJH+Dgtb+offIeXI2ZAZmSlNRKal9DY6QLYJ/VMl+PJ/zdi+88XONYK2x1Hhf3YlEROSO2SWqh7yib/4QBTWwWsbtA39cwBu5huUZLBkFfnZJsv2b0nH66YZX9Ld77V6uWG3xKwzCOhVGxNPJWW+3+6N7yhuKfeEsqw5AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8zg/eu4y+GGpwMvhH3GrfsmAH38DH55fmk8Qi+m0M+w=; b=GOEjCXb3x+DBzX1OoesCnFda/u3uf1SOuo5+a1jFH5VUSs1ROZxh4Qb0Gd6xh3D6ENNnvPdBOsTTTdqB8F9iLI90r44nEAXEb4REaBd9llVjoU09r2i7trW1TlFI/+9c9t//t5b9yDFt7E7cPBoEn1Z2dEPlJ+KOHcai/f1Op7rQfhbXztTpvi6yj3vmQQdHXqmY72jiPT74A4bFl2qh1mIqdl/86namLdKD5ATI87MBnWlGDoUH/za04ryJbclZz7RGxOdN0gjzDvz6Bo/wDGKSgtYLP9BSvw2efjFMW1uhocLvP0CbgWxyBttrHBtH+56NRwTrNXzsvgToFTeZiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8zg/eu4y+GGpwMvhH3GrfsmAH38DH55fmk8Qi+m0M+w=; b=GY/U4FSASxTKySe6MrR7bB65dMvTxCc45DfsWBTK54QgyxfbyFfZ+bFbM4eC1b0JhWHFqrM4DQsZ+bI0pg2TvElEAEyLtQYL6OyE/1b7a7+QD5t4EaOZn1T5tkWjZWmp9tSMDg1G6Yd5So2Rvjf0XCSIUO6ZT6NPe5e0fOYwqbdF2AX0nl9zCI+ocEsPizehxjFYy8D10k9Mtg6+8fke+Pq3IQfgYLFXJHZAqi1SRBjOMJgCfwhKHsQwsBuas+CieN2mRifeL034yk7JMPwqfdZOXSplJdS7SFqzPo/w66EuIdDOEWyu39W1gq+ripJKhnbNUkygpJOGjNfqEolbKg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <763df4ee-95d7-be20-212f-7450f3fd431e@suse.com> Date: Mon, 8 May 2023 11:01:18 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3] ns16550: enable memory decoding on MMIO-based PCI console card Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20230505214810.406061-1-marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <20230505214810.406061-1-marmarek@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0111.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS1PR04MB9455:EE_ X-MS-Office365-Filtering-Correlation-Id: 15e0d617-609c-4337-b64d-08db4fa2c937 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2ywJKYuUS4sY3Xl/nQ9gg3gSCHbQn6xqxNWBKylRjWW707Y+suP467gXearmqlx08TPaQp47GdMQrj+T3+neRCAeV8+YTbPEHjBKdv39mOTh37CBgZaeMf97MNtmwa9Zbv9zqobX0sMs1WKLVGbwa8qLIoCGxlT8+tOO1LyWra/8ddA0g6BUfPf0uYYZ2sTpx93Ku6ZFZMrYOo6DIOJeaEGSjuUEOPJhZHJHXBVwD2wEToG1B2EEqmnjftlJ6YwYMV4H8KaQE8SNd+mVATObU62R5vnN119P/PihOeGjPkMPl6AdXPxjstBSpEjSW9Wimzt0V0/AHgZzqu9RmLU6tPFbaESCgdN3I1qd3O2PwPCss1SqJsYku55QkjnP60N8tqVPWqG/XnsMA+22kEzB3IB4EpwG9PxvQ44cH290j1KLkbBVswaQiCwvGw3C3+4hZze6DTeEGh3tbMkOoCALqKhs90c4xfKtMtNEZgTPhuHVHLM29axt8ukq6aOC/eemJtaSUAXLqU1HxRHL0dSAJCmdi9jWJSdhQXq1sQP42U91syr0XAdKsbnrtXZ8E94Z0Sg9NeHlJ5SkerTjeZqWvIXG0zG/MLl7nkoWP9HhPq5jZ3xfOOlxyKM69Tj8PcV4ONsWOIM5MEY8ICpyJegNcA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(136003)(376002)(346002)(39860400002)(366004)(451199021)(31686004)(66946007)(66556008)(66476007)(6916009)(4326008)(478600001)(6486002)(316002)(54906003)(86362001)(31696002)(36756003)(2616005)(53546011)(6512007)(6506007)(26005)(8936002)(5660300002)(41300700001)(8676002)(2906002)(186003)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bGxOZk81Z1JudUxPR29vOS9MSW96RVZnRSs1WlEzVjJzWVVnMTFHeFluMHBr?= =?utf-8?B?d1ZoczVhMTd1REdVeURiaHprOU5BSjZENXU0dGxYQlEwVENsTDVvV3RIUHAw?= =?utf-8?B?RUZlRm03RnpCMUlWUi9LRy8ydlVBZ0U1MERwejhpTjVDSW9HT1hxSzh5UWFC?= =?utf-8?B?dUtiWGM0anllOVRiMEZ2TkU0TzBMdGQ3eHJvWUF1YUtsRHVJanJ2emZSWXFX?= =?utf-8?B?ZTlOb0xremFNWlVLb0k4eFJhRDNMcEdtM2xHUnBTc0crY3dVR2NJd0FPdHRW?= =?utf-8?B?NnM5K3JGSWRzQnIvNHppcjkzMlMrZkx5cFZEc0ZUUW4zRCs2NXc2Y2ovajVk?= =?utf-8?B?TTY5V0VOSXdZT2ZDNkdva2I2UzF4NjRnQzJFUUdYWHZWdGgwQ0ZwNEZuZ1Uy?= =?utf-8?B?OUsrSXY1ZHowMmNYQVlCNDZhL0M2UXpzbm9pWGI2K3lCM0FITGttOVhWRFBp?= =?utf-8?B?TFBZNFpSREV1c3JJY2pHbWFXeFNBRTdldFVWVkJidkVrK295aVZjWEFjRlVj?= =?utf-8?B?YkxQMWhCZC9TN3FFdm9zTUhxSW5GYWt3OCsxekZiWW5IZThWWkxTNmtsM0dt?= =?utf-8?B?dkZVYk52UEE3d0tIbWJYemhuUGNUdHQvcjVOY3RMMXdVcDAraGU5MWR3ZU5D?= =?utf-8?B?VUNPR0U4VDFMMDdlTi96ZUhBQzRQd1Y5bkNiZWFObk8zNVh2dFlGTVZqWlUz?= =?utf-8?B?RFV1UmxjUE5wYUZCZncxREV1Mzd5bE9kS1Y3Wm96QWJrRmlOWnBzM2c4SmxV?= =?utf-8?B?M3gzTmRBZ0lVb01tTXRJNG4xbDNlVXFPNTl1WmxQVEl3V20vSWxCOU0xSmRP?= =?utf-8?B?TzFtTmF3YnNoaTM1VU9LZm4yeVVVdUdKZVFKbWVYRlFRNFl0TWVuNXFjdCtM?= =?utf-8?B?a0JsVlV5Ly9TRVNpS3QxOGlWWjZwS0syenpBbzN6VDR2ZDJFRklocFF3ckF1?= =?utf-8?B?d3F1WlVrN1R5QXBMYnNZR3dHVkh1M3FyY0hsc3ErRWhmc0ttTTU2RXVMbnVx?= =?utf-8?B?Wk55RXhjWUFRN1JJeVpBVDZQbnUwcitwb1o1Y3NGSERMSUcvUnphRzJmaUVs?= =?utf-8?B?NmlsU0ZtMkprR0JiR0NXNU92WjB1UzNzemdXb1ZnaUVRRTRCbjBxRDh2dTM3?= =?utf-8?B?c2JYUFgzNVdmV25vRHk4Vk1nbnFWQjlRN2Q2VGd4VzZ2Y05HekNkcVJUZ2wz?= =?utf-8?B?WlA3NjhwRkgyT2hoQ29xaXZQVDltTjRwRHh6SWI1bEVSRm4yUnBHRnczQnZF?= =?utf-8?B?b2VxNmNCNnFmL0JOcDVtN3cyei9jbDBCSnVPUC9VY0c4RHlvQ1dZdlFsVWhh?= =?utf-8?B?Rzg0LzVkR2ZYQ1dvQUNkQloxTjFtc3ArSFRxWFREOVRXSUdiQ3ZFRitDcEUr?= =?utf-8?B?Z2tZUjBJQWptejNYVkhJcFdzQVowTnhPMFRnTi9BdVBZNWlYaTdsY0dKU2xT?= =?utf-8?B?eTlEcFBmMzBJUlp2Yy9nMXMzOTN5ZGxibVhyMGlpczJDZVVxMnVrUWlvR2tE?= =?utf-8?B?NkVqb0JZTmZLdUpiYzFXRGc1VWpOU1I4S21YZWFhbks5V3pzOUNQc00wY1Z5?= =?utf-8?B?N2FhRFF3UUQxSkF1UG4wN0lSSlRRM2NzSFFQN2tiTkVvTnNsa3VWd2RzU2I4?= =?utf-8?B?UGhxZklQN2pVd3dLam5zbnhxNTVqZFdQb2pqT0tQRk9ZZnF4Nko1VVRUSm9u?= =?utf-8?B?RGVLQVl6YWc1djNKYzRSZ0FiU3FIOGxyV25rSlVBdGdhQW5FUlJoRWhvcnhz?= =?utf-8?B?Y2JFQTBmS1RtWWp5c0F5V1hHL3V6Y3pnUWJQdjNQZDlLajRqVS9xd1lJOU9Y?= =?utf-8?B?RjBpdWpRMWdIUHptUFdvS3ZTQVIyS1c3R0x5T29DV0ZIODV3S3d4NFJtWk5m?= =?utf-8?B?NjB0bzZuQXFOUEVyM0NWV21sWFRabGNRVjB5cHBhRzRLRzdHUzVwOW1VOE9M?= =?utf-8?B?NTQyL1oxRHk1L3NIYzRDZDNBSEEvTllmWmM4OE9yYno4bis0RmJER2FQVjh1?= =?utf-8?B?OU9xSnNGL2lGRFlScUJzMDNjTk50aHVIQkFjYkZtU3VwZjdIQXR4eUFmUC9O?= =?utf-8?B?N0EydVQwaWt1VnJwUFdRUDlNWmdxOHR3dnBJa2RtQXlDb0w2U2t4dTlxTkp1?= =?utf-8?Q?tmW2ylXjON9AWGjLWNqpmUCWy?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 15e0d617-609c-4337-b64d-08db4fa2c937 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 09:01:18.3807 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JJMZkf7NNndEpn7k8R2OzFoDecCX8nJ6PVfE3saH4wu1yR3jlTJQeikd+djvt5CXCMBxk2JryIpOYYNZ/EPz0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9455 On 05.05.2023 23:48, Marek Marczykowski-Górecki wrote: > pci_serial_early_init() enables PCI_COMMAND_IO for IO-based UART > devices, add setting PCI_COMMAND_MEMORY for MMIO-based UART devices too. > Note the MMIO-based devices in practice need a "pci" sub-option, > otherwise a few parameters are not initialized (including bar_idx, > reg_shift, reg_width etc). The "pci" is not supposed to be used with > explicit BDF, so do not key setting PCI_COMMAND_MEMORY on explicit BDF > being set. Contrary to the IO-based UART, pci_serial_early_init() will > not attempt to set BAR0 address, even if user provided io_base manually > - in most cases, those are with an offest and the current cmdline syntax > doesn't allow expressing it. Due to this, enable PCI_COMMAND_MEMORY only > if uart->bar is already populated. In similar spirit, this patch does > not support setting BAR0 of the bridge. > > Signed-off-by: Marek Marczykowski-Górecki Acked-by: Jan Beulich with ... > --- a/xen/drivers/char/ns16550.c > +++ b/xen/drivers/char/ns16550.c > @@ -272,6 +272,14 @@ static int cf_check ns16550_getc(struct serial_port *port, char *pc) > static void pci_serial_early_init(struct ns16550 *uart) > { > #ifdef NS16550_PCI > + if ( uart->bar && uart->io_base >= 0x10000) ... (nit) the missing blank inserted, which I'll be happy to do while committing. Jan From xen-devel-bounces@lists.xenproject.org Mon May 08 09:06:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 09:06:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531313.826894 (Exim 4.92) (envelope-from ) id 1pvwoy-0007Vn-9n; Mon, 08 May 2023 09:06:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531313.826894; Mon, 08 May 2023 09:06:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvwoy-0007Vg-7C; Mon, 08 May 2023 09:06:16 +0000 Received: by outflank-mailman (input) for mailman id 531313; Mon, 08 May 2023 09:06:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvwow-0007Va-Nm for xen-devel@lists.xenproject.org; Mon, 08 May 2023 09:06:14 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9485aec0-ed7f-11ed-b226-6b7b168915f2; Mon, 08 May 2023 11:06:13 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 63D5121F84; Mon, 8 May 2023 09:06:12 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 396E11346B; Mon, 8 May 2023 09:06:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id /nl8DIS7WGSXYwAAMHmgww (envelope-from ); Mon, 08 May 2023 09:06:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9485aec0-ed7f-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683536772; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Jx1vHKXG9BsC/fOShussz6KjHmMB37fDHsvcq+nBraY=; b=gIAwOVQHFUi0RkRmgYdaf57/kV8Sw8hK6dbWT0iFmVPTb5NwknXSuZfb9onV2+oe+Ge1o6 cjNo69FO+380vyG4x0IX+NsDXo0G0+Md7T6LM+bpOXwKhzl1pRllrB50nKEtEW7BfpZY7G +NyrBRy/aCIppyb66PLOgaNes0bBlhk= Message-ID: Date: Mon, 8 May 2023 11:06:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v1] tools: convert bitfields to unsigned type Content-Language: en-US To: Olaf Hering , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD , George Dunlap References: <20230503150142.4987-1-olaf@aepfle.de> From: Juergen Gross In-Reply-To: <20230503150142.4987-1-olaf@aepfle.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------yLil7GVoUqhlZCx4zmNgOb4n" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------yLil7GVoUqhlZCx4zmNgOb4n Content-Type: multipart/mixed; boundary="------------LOjdMT803timFkv0B3Ya03KN"; protected-headers="v1" From: Juergen Gross To: Olaf Hering , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD , George Dunlap Message-ID: Subject: Re: [PATCH v1] tools: convert bitfields to unsigned type References: <20230503150142.4987-1-olaf@aepfle.de> In-Reply-To: <20230503150142.4987-1-olaf@aepfle.de> --------------LOjdMT803timFkv0B3Ya03KN Content-Type: multipart/mixed; boundary="------------cwzj5DxJhdEW0LCD3VU5Lqq2" --------------cwzj5DxJhdEW0LCD3VU5Lqq2 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMDUuMjMgMTc6MDEsIE9sYWYgSGVyaW5nIHdyb3RlOg0KPiBjbGFuZyBjb21wbGFp bnMgYWJvdXQgdGhlIHNpZ25lZCB0eXBlOg0KPiANCj4gaW1wbGljaXQgdHJ1bmNhdGlvbiBm cm9tICdpbnQnIHRvIGEgb25lLWJpdCB3aWRlIGJpdC1maWVsZCBjaGFuZ2VzIHZhbHVlIGZy b20gMSB0byAtMSBbLVdzaW5nbGUtYml0LWJpdGZpZWxkLWNvbnN0YW50LWNvbnZlcnNpb25d DQo+IA0KPiBUaGUgcG90ZW50aWFsIEFCSSBjaGFuZ2UgaW4gbGlieGVudmNoYW4gaXMgY292 ZXJlZCBieSB0aGUgWGVuIHZlcnNpb24gYmFzZWQgU09OQU1FLg0KPiANCj4gVGhlIHhlbmFs eXplIGNoYW5nZSBmb2xsb3dzIHRoZSBleGlzdGluZyBwYXR0ZXJuIGluIHRoYXQgZmlsZS4N Cj4gDQo+IFNpZ25lZC1vZmYtYnk6IE9sYWYgSGVyaW5nIDxvbGFmQGFlcGZsZS5kZT4NCj4g LS0tDQo+ICAgdG9vbHMvaW5jbHVkZS9saWJ4ZW52Y2hhbi5oIHwgNiArKystLS0NCj4gICB0 b29scy94ZW50cmFjZS94ZW5hbHl6ZS5jICAgfCAyICstDQo+ICAgMiBmaWxlcyBjaGFuZ2Vk LCA0IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEv dG9vbHMvaW5jbHVkZS9saWJ4ZW52Y2hhbi5oIGIvdG9vbHMvaW5jbHVkZS9saWJ4ZW52Y2hh bi5oDQo+IGluZGV4IDMwY2M3M2NmOTcuLjNkM2I4YWE4ZGQgMTAwNjQ0DQo+IC0tLSBhL3Rv b2xzL2luY2x1ZGUvbGlieGVudmNoYW4uaA0KPiArKysgYi90b29scy9pbmNsdWRlL2xpYnhl bnZjaGFuLmgNCj4gQEAgLTc5LDExICs3OSwxMSBAQCBzdHJ1Y3QgbGlieGVudmNoYW4gew0K PiAgIAl4ZW5ldnRjaG5faGFuZGxlICpldmVudDsNCj4gICAJdWludDMyX3QgZXZlbnRfcG9y dDsNCj4gICAJLyogaW5mb3JtYXRpdmUgZmxhZ3M6IGFyZSB3ZSBhY3RpbmcgYXMgc2VydmVy PyAqLw0KPiAtCWludCBpc19zZXJ2ZXI6MTsNCj4gKwl1bnNpZ25lZCBpbnQgaXNfc2VydmVy OjE7DQo+ICAgCS8qIHRydWUgaWYgc2VydmVyIHJlbWFpbnMgYWN0aXZlIHdoZW4gY2xpZW50 IGNsb3NlcyAoYWxsb3dzIHJlY29ubmVjdGlvbikgKi8NCj4gLQlpbnQgc2VydmVyX3BlcnNp c3Q6MTsNCj4gKwl1bnNpZ25lZCBpbnQgc2VydmVyX3BlcnNpc3Q6MTsNCj4gICAJLyogdHJ1 ZSBpZiBvcGVyYXRpb25zIHNob3VsZCBibG9jayBpbnN0ZWFkIG9mIHJldHVybmluZyAwICov DQo+IC0JaW50IGJsb2NraW5nOjE7DQo+ICsJdW5zaWduZWQgaW50IGJsb2NraW5nOjE7DQo+ ICAgCS8qIGNvbW11bmljYXRpb24gcmluZ3MgKi8NCj4gICAJc3RydWN0IGxpYnhlbnZjaGFu X3JpbmcgcmVhZCwgd3JpdGU7DQo+ICAgCS8qKg0KPiBkaWZmIC0tZ2l0IGEvdG9vbHMveGVu dHJhY2UveGVuYWx5emUuYyBiL3Rvb2xzL3hlbnRyYWNlL3hlbmFseXplLmMNCj4gaW5kZXgg MTJkY2NhOTY0Ni4uMWI0YTE4OGFhYSAxMDA2NDQNCj4gLS0tIGEvdG9vbHMveGVudHJhY2Uv eGVuYWx5emUuYw0KPiArKysgYi90b29scy94ZW50cmFjZS94ZW5hbHl6ZS5jDQo+IEBAIC0x Mzc3LDcgKzEzNzcsNyBAQCBzdHJ1Y3QgaHZtX2RhdGEgew0KPiAgICAgICB0c2NfdCBleGl0 X3RzYywgYXJjX2N5Y2xlcywgZW50cnlfdHNjOw0KPiAgICAgICB1bnNpZ25lZCBsb25nIGxv bmcgcmlwOw0KPiAgICAgICB1bnNpZ25lZCBleGl0X3JlYXNvbiwgZXZlbnRfaGFuZGxlcjsN Cj4gLSAgICBpbnQgc2hvcnRfc3VtbWFyeV9kb25lOjEsIHByZWFsbG9jX3VucGluOjEsIHdy bWFwX2JmOjE7DQo+ICsgICAgdW5zaWduZWQgc2hvcnRfc3VtbWFyeV9kb25lOjEsIHByZWFs bG9jX3VucGluOjEsIHdybWFwX2JmOjE7DQoNClBsZWFzZSB1c2UgInVuc2lnbmVkIGludCIg aW5zdGVhZCBvZiBhIHB1cmUgInVuc2lnbmVkIi4NCg0KV2l0aCB0aGF0IHlvdSBjYW4gYWRk IG15Og0KDQpSZXZpZXdlZC1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0K DQoNCkp1ZXJnZW4NCg== --------------cwzj5DxJhdEW0LCD3VU5Lqq2 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------cwzj5DxJhdEW0LCD3VU5Lqq2-- --------------LOjdMT803timFkv0B3Ya03KN-- --------------yLil7GVoUqhlZCx4zmNgOb4n Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmRYu4MFAwAAAAAACgkQsN6d1ii/Ey8E lwf9E7Qh8x7RzZ0pzgW2fJVNlQTx9ySnBNQ8MuixNnBRkJkpFqxD9UVRvdhr5t/C7HzGEgylFrmn Sa3ZeyRcxgnNpwwAIG4D0WFPPeHD6OBLe+JyGGZDQRoLxusmytN/Hgq3YFvZBImsWjulLeR+G3cR SrnKr/S/xgyaSg3lAT0SGDtfuIYwk/MQDf2J535dgt7tBV2AW0QnNkaW9SuGUH9vOI2AQe4baZi2 R5HYyh/rI1sT7vJ9hmqnag5j0IENZzqDjwQbxgvSIeroBOcA17KjPMPjfyA4o/9tSMKpHm3UXbnv tDJUrV3UhvHRCJHtZqhbV4tjKX79KrMaplydeqYJ8Q== =J5NL -----END PGP SIGNATURE----- --------------yLil7GVoUqhlZCx4zmNgOb4n-- From xen-devel-bounces@lists.xenproject.org Mon May 08 09:06:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 09:06:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531315.826904 (Exim 4.92) (envelope-from ) id 1pvwpa-00080h-K0; Mon, 08 May 2023 09:06:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531315.826904; Mon, 08 May 2023 09:06:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvwpa-00080a-GU; Mon, 08 May 2023 09:06:54 +0000 Received: by outflank-mailman (input) for mailman id 531315; Mon, 08 May 2023 09:06:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvwpZ-0007yZ-EM for xen-devel@lists.xenproject.org; Mon, 08 May 2023 09:06:53 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20621.outbound.protection.outlook.com [2a01:111:f400:7e1a::621]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id abc41864-ed7f-11ed-8611-37d641c3527e; Mon, 08 May 2023 11:06:52 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7914.eurprd04.prod.outlook.com (2603:10a6:10:1f0::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Mon, 8 May 2023 09:06:50 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c%4]) with mapi id 15.20.6363.031; Mon, 8 May 2023 09:06:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: abc41864-ed7f-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d3E2U2j9hj7ITOMupBLBdqJoAIfMfLXyZ1GdXZ1I6PfIEMj4QrqUwRiYj5P+C/CNOgZqi+n+GDuZJvyJqukYLTm594mx2BtcIdLstMVV4bwB8VQOBwL5sP/f60zE7sxaX61bY5AD+SFTvlGa15tivsSK0nDtI8reSUoAGVjjpB/gZWm5r2JdvG78lXMkFwFHZ6t1sK6yjQL7RsIpQUpgTl0gr72wV0NxsQOBp1pn/W/u/Y/2zqyO0h/jcju507/YtoQreWC5+vO21Kz11XQ8yGymlX/Bkn4qqTc+4t7b0+ATsY5kAeqYE/9Dr406d56g6P+2OCNdmjs6FqCPmQindQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3iR+3mk6Pn9vKssQCx3/HtfIvIl3z3pMrxq7NHaT7Tg=; b=cUHjSiuZCFpHw+3pn+wn3yQuJOitk/gdbnXMuT7S3AGyeLneqsCA0YST/j+y3pFTVOIV9uuRJwn6/WCB99f5VfbeyOL4cwzg166LHZH2sGgDP9XXEqbleEIGpQTlUPa/pmm77Wq05FRf+mYB48/go6O4wUOE4lDReMUkbwPhtJNXWjmEMi/8E+kzEjkHmocWQ/klKMS2JyBhTdT+rD18LxHm+n2BzNjS8ISeBP9YidDWd6Fn8RxoQsU1FaweQKjiMrMIuomYg3BZY0U7DN8mNAMHGgmDzxQ3SBI6/J4xjbIrWRgK8VnnCbnh5i6GACvRrZR8SUzka5D3gGEBWQa1eA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3iR+3mk6Pn9vKssQCx3/HtfIvIl3z3pMrxq7NHaT7Tg=; b=ZQm2dgMe29WxG+WOl6KPrdV3M3E50/Mu/yv2sNTB0wi2QK7fjpPK3TcUlyW+Ci3VeCbChXu3mH0Br13fKwV9HEqpUSVfbbWyaFsvxQJgQ0d+bG3M4d+Kgym5FtE6NjjFJ4775ifiBywPb5YkvsJ103dfYaCMSOQt2knHpoV1i9JaAzYAckrPD59DeGRv6OEdXKoUnDd6/abAvIM5R6ITBScNZL9C+77sQ9+y2nqsxsu27SJE5G8hS40TqPYmnOW7dIslTrunD3Ktp4iB1Gn2dTD89hdrZbJUurk2coo2vSEfR6N0rmkAR7Z3CJslK28XohG1Y5K82khIk+yt+TUgqQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <05b27f59-f906-79af-6c3c-6b6fae7cb1a9@suse.com> Date: Mon, 8 May 2023 11:06:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 0/3] Add CpuidUserDis support Content-Language: en-US To: Alejandro Vallejo Cc: Wei Liu , Anthony PERARD , Juergen Gross , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Xen-devel References: <20230505175705.18098-1-alejandro.vallejo@cloud.com> From: Jan Beulich In-Reply-To: <20230505175705.18098-1-alejandro.vallejo@cloud.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0088.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7914:EE_ X-MS-Office365-Filtering-Correlation-Id: d0078734-529c-433b-9eb0-08db4fa38ee5 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xA6FRKwtCGVMjMxi81FMuQLHiqqOYt5t0tuH/g2uOn1aDjkIIW1A/7VP1jYN3S4P+/I+iMWVa6iJST2+Nt+RlvIT8sMKubJC0tueFhQWaUn2k74IUloGXjVBI34O0iivgmRqMbt1dTqvrmr+xl4nn1jHEsjkMNC7z94W8MVX/fm5NtiQVbkhZfP0nZrMIhjqLkHWLti/A6RDJStHal1cAkg+Ds4DakfI47uKi6RYJsWOnisCOV7nyV7Pa413J3V7mIqZESKjx1e/KTZJUUlN9INiaO7kIJ6XKBQ6StKbJOlTFgMvfstmdCeCEINF5DBxdZOjIqMZkiPZjWvJvK2lw2iM5D64Yh6TVC7g45F30rrTpiGxGopdSS0K2C1RF6VPP9JdTL5Nkp14jt7KwSfhta5NlO2RozwrJh73QJyzhycOA/q9k+QjxpSzJzhLXjVGDM6WjIuxbItiDeBwAjlOHjfWSofc+Fkpj7hXzRiMoANrzrxv1Q6z1T6tejssq3mWuT1xVoOtsGnC3q3Cx/YHCdKHpvK8Uls38SylyMPlFIckssHkwl3YQZce5M8Dp/ZwI0n1TDW255hSP0egKUboXtPqOhRnC/lHjjqFBg1NAsZOuMgGO5XmzXP8E0LV2E3kARPaQXyYL7w/rVb4NIEcaw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(376002)(366004)(346002)(136003)(396003)(451199021)(31686004)(36756003)(38100700002)(2906002)(8676002)(8936002)(5660300002)(316002)(31696002)(86362001)(6916009)(66946007)(66556008)(41300700001)(66476007)(4326008)(83380400001)(53546011)(186003)(6512007)(6506007)(26005)(6486002)(478600001)(6666004)(2616005)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SnE3cnV4c1QyOVp3WE9QY1BFeVlIS0xZdFR2L2w1clJ1MzdPVmZkOUhzOHJC?= =?utf-8?B?OElXVkJJVjFhUjZoQlZpZnMvZk9DQzd6cmJOQk9QbDJXbGptSGo0d0R5QXUx?= =?utf-8?B?L2Y1WmNXaEYwUmR4QnpKYXZCcXBldXg1ekw3SmQyQjllcmVEVXFmYTU0NEZZ?= =?utf-8?B?QTFmY0licFVTSUtHQzlXUTNFRGRFTEVmNFdzV0hBWEw1bVo1ZDlteHZjc2tU?= =?utf-8?B?Mm1CQUZDVGZSeE05L0VQRW5ZcFFzZm5MZURJQkZaRzJGWEQxMUJFYk9tbWQv?= =?utf-8?B?WXF3SjZvaHN6MGd5Zzl2TktiT0pvWjR1cWFPeUxNSTB0dTEyeW05dGdHcUUw?= =?utf-8?B?S29zcStFdUZoMlZZWlRNb3pTdVdoczZnSllIblBDSTNFVXd5VUZFZTQrbnpw?= =?utf-8?B?Y2FUb2lUMjdadDAySllnd3dVS1VkK1lzVy9RVWg1OE03NGlUNHYrcC9GaWpO?= =?utf-8?B?dWNNRmhlTCs5UlNUWmdjYnY2V1gyUm9jQUYzTmRUenpYdy9tUFh1dGF5N0RG?= =?utf-8?B?enM3a1hzelhEdzVpZFJrbzYrYll3Zm5aNEp2NmVXM0dSa3VLV1c1R2ZKb2s0?= =?utf-8?B?S0VqU0FwSUtDVWY5dFovNDBxMGhTVDVJTnFaeXZwUVNvbml4V2FmR3paZWY4?= =?utf-8?B?TE44TTlnVTNNb2NJMVhJdlpucG9FdVdyZHZ3K3UxYm0zNksrSHhvZ0txRDZh?= =?utf-8?B?RzBRWnhpZ3NoTE1VdkNpbnp4VGFWYmF1ck1kWHY5a0I0SllZdnloVGd5Uk5P?= =?utf-8?B?QjdVbWVyVlVpVGRQemI2SXpaN2N1RU5oUm9VUmtTUXJVWmFKNkIweWdLUkMw?= =?utf-8?B?UStYVTNmcmh5L0VFRWxCSnRJLzVoUmRSYTRrMUxwVFgycEJnRW1pbGR5UkY2?= =?utf-8?B?ZUZzNktSUDFCS1dmaFBsR2Nhc09qL09CK3RjaGhNZ3NUV1NkbGhpbVRTbGlF?= =?utf-8?B?QjJnWUdXQ1YvQ1lOWXVORmljVHg2YTh6WHkwbHdkcEwwbkVHQ2VGNGJ4dU5F?= =?utf-8?B?S255c1hqVWJVa0dHT3FDeGdNVXhoYlZ6dDg2OHJWL1QzeWVSenJia3hrdUVq?= =?utf-8?B?MXdQODRibWxwNnpwR1pkQU04SS9zTFpBV0tRKzZvM0NPL0JrWVo4SXVBME9J?= =?utf-8?B?Z2UvOTE5R3JPa0RHVnVLNU16dkN2UVg0WGkza0orOTI2QkdjVUV2SkdiSHVG?= =?utf-8?B?clQyT0FIMDk2Yk5CT0dlM1NuVVJ3azdaeGMzMlM2NVQzNG1ubHJKSDF2VVRP?= =?utf-8?B?NmlYMGtaSkQ1b2JaU05LaEFnVzQvZjZTSnQvMEptU0pST2pZVzhOWHBIVDlN?= =?utf-8?B?Q084L1FFRFpkdGxXVUs2UWFVelVTTVdsbHEyWGpaWFR3OGdQemtKd2pubkxs?= =?utf-8?B?UU9reE1USVlpbnlDRFhVbndGbkJ0UWdSWjFPUlFGWmIzZ3p4NU9XcmVaVlVV?= =?utf-8?B?aFd4Wk1wK2djYkNFL0VoZnpyejRNYjJiOW0ya1ZTdWpDNDJYMUtUcmtVR2Zj?= =?utf-8?B?TGxtV3d1TmZObDZqK1gybG5ra0t2VlZRdm5IMklxRTFoL2R3NWJ4d2lPV01t?= =?utf-8?B?ZnE4c2haTTYrU1lHbUJWSUZCY1llY3hJdU9zei9zdmYrWkJCTHZ0MC8vQk1a?= =?utf-8?B?bDhka0xmb2VhbGVpZGNUZnhDZ3ViVEVSSVV3cjlIak1LYkF4cDlOZjU0bERN?= =?utf-8?B?dDRKQUwzT0Y0bXlxSnVpM3lFOXNJOFlBMzRDRzQ5d0JqT0xOUDlwL0ZmMHM5?= =?utf-8?B?Vk5CVitnU2hjRjVjRUxEWjIzL1VxZVNpaGQ3VFRoSkg2amR0R1NaZTZSdHhE?= =?utf-8?B?cnpsZkk1VEs0MDRoZnkvbDdGYWhQbU9VZ0hDSkV3aER3K3Ira3dmd29pd3R3?= =?utf-8?B?M08zazBjYXQ1WitvNm5EbFNYalM2SzdRYjdXNTd4Rjg2SWFMQnRwQzJ4Qi9j?= =?utf-8?B?dXhrbzloN2l6SjdudGUyalh5SkpicWRHSkNIWkQ0Mm9UMEZYQmExNEhRTUVx?= =?utf-8?B?ZUNWZXJSelJKTG5IeUNBRHFBdjZ5Tmp4Y1FEU1AzMHVlazNnUE4yVXg1Zko4?= =?utf-8?B?QXFZeGdRb1dYaVpSb1Jxd1pxY05tZVRua2pvVzhHdUMwb1NvWHVycHh1WC9T?= =?utf-8?Q?YxcL9ETBkv5PS2BcYGnKCr9LT?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0078734-529c-433b-9eb0-08db4fa38ee5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 09:06:50.0121 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pYds6VyWT7hVBkNSi5LuZtTxkwGgtk/bJdyZ5DLIVCejPI/SK2lMGZ00vRzjt61mK6Ar688jv+U1JwtQXZyzTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7914 On 05.05.2023 19:57, Alejandro Vallejo wrote: > Nowadays AMD supports trapping the CPUID instruction from ring3 to ring0, Since it's relevant for PV32: Their doc talks about CPL > 0, i.e. not just ring 3. Therefore I wonder whether ... > (CpuidUserDis) ... we shouldn't deviate from the PM and avoid the misleading use of "user" in our internal naming. Jan > akin to Intel's "CPUID faulting". There is a difference in > that the toggle bit is in a different MSR and the support bit is in CPUID > itself rather than yet another MSR. This patch enables AMD hosts to use it > when supported in order to provide correct CPUID contents to PV guests. Also > allows HVM guests to use CpuidUserDis via emulated "CPUID faulting". > > Patch 1 merely adds definitions to various places in CPUID and MSR > > Patch 2 adds support for CpuidUserDis, hooking it in the probing path and > the context switching path. > > Patch 3 enables HVM guests to use CpuidUserDis as if it was CPUID faulting, > saving an avoidable roundtrip through the hypervisor at fault handling. > > Alejandro Vallejo (3): > x86: Add AMD's CpuidUserDis bit definitions > x86: Add support for CpuidUserDis > x86: Use CpuidUserDis if an AMD HVM guest toggles CPUID faulting > > tools/libs/light/libxl_cpuid.c | 1 + > tools/misc/xen-cpuid.c | 2 + > xen/arch/x86/cpu/amd.c | 29 +++++++++++- > xen/arch/x86/cpu/common.c | 51 +++++++++++---------- > xen/arch/x86/cpu/intel.c | 11 ++++- > xen/arch/x86/include/asm/amd.h | 1 + > xen/arch/x86/include/asm/msr-index.h | 1 + > xen/arch/x86/msr.c | 9 +++- > xen/include/public/arch-x86/cpufeatureset.h | 1 + > 9 files changed, 79 insertions(+), 27 deletions(-) > From xen-devel-bounces@lists.xenproject.org Mon May 08 09:18:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 09:18:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531324.826915 (Exim 4.92) (envelope-from ) id 1pvx0C-0001Ff-OA; Mon, 08 May 2023 09:17:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531324.826915; Mon, 08 May 2023 09:17:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvx0C-0001FY-Ku; Mon, 08 May 2023 09:17:52 +0000 Received: by outflank-mailman (input) for mailman id 531324; Mon, 08 May 2023 09:17:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvx0A-0001FQ-LF for xen-devel@lists.xenproject.org; Mon, 08 May 2023 09:17:50 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20616.outbound.protection.outlook.com [2a01:111:f400:7e1a::616]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 33555c9f-ed81-11ed-b226-6b7b168915f2; Mon, 08 May 2023 11:17:49 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8309.eurprd04.prod.outlook.com (2603:10a6:20b:3fe::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Mon, 8 May 2023 09:17:47 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c%4]) with mapi id 15.20.6363.031; Mon, 8 May 2023 09:17:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 33555c9f-ed81-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Uw4yqoCB39j7A7aQvDRriBboaP6Fc9DRv/A81ICOFTEG33FsjwY+bum04HZTgQfZbNGICFoJSiElpk79vRqrTLQTS/MrFp4CleomOk7/QBqmQENgXdWOPDCItWZHfOBw4uWbNDjZ844s5LEf5WP9Jebj+0RCKM+JIaf/013vIFb/XbNolWpozrrgze80mfBP2f+3K5DAK+ZfC2kGWcBP15Dj+mjlVzvrY9MHz2GMY9y3VAmzi764v9ZRw+Zy9WxqB0kZ3tWyXiFkB9LGYCAKT57A1hVKNf9OeMtpmaQDhKU4R2fprUnp7hDvkwEWIMov0Y/RL8IgjrbqequbDyd2Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2u83bdCLKqnnbdakJJyL+ltqn29nF2/1TNG5EbGKPzM=; b=c/TRlfR0otQ4K6XztKJwXeA3zj3dGQ/IFGFyBnuQfqMme8Jc7AhhY0PTy/qeXW1mWy9t7wg2fngtAsUE3X8cKTIQ6Ey9w9tjQUgNkrBc6Ln0jpSwRx9HcY6B0WyQIZQZEKf9MQwHdbRE60XxOgqPTB3Fy834APz9tfQQdJo4ZsafHJA3gacVZoau+inWtcc6fJmfWU1rfV5OqOpHfn9jWkoKS9kJVF/mOaGSF1EQhd64fxZce58+L6VUcH63fGhxwb0cgL/M5D4cB0Zs0CrmrTyRqnfd5tho65E6nNwVO5eOnCathJamqiC/KD/HwBfVIFDw9AV9xrRud5/HONz9xQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2u83bdCLKqnnbdakJJyL+ltqn29nF2/1TNG5EbGKPzM=; b=P1QFS6PuDRoEPaOCUUI503OByZ3hqeXhdbmjh5TeKRiJ83+IVeB1SwP7hK0zYY2nW/xXnfg0CSfr/rAwbsXB8PocG1I1SQuY1hSP1Wmc1/QV2rnKpUy3ldjrfpckY0b4KUa1Xz2A5Qlbq2oL5Cuoo16jrXEqRI3++UASNj2EiVp90XOUSPrfewOocW+v4MDzgtlpc+0rT2LHHpEi9kA2RprsVkPjbi1ShCw+FwjU5QZ2HGfMQCOZTp5XuFDs3LEKxI9KPpnry/gaD/Qhb8Ib01I16vBiV6hoCWaw2OEogKMykzA6LAqxdx+FP+zOHGKZkypY00n8GRrzqem2uq9juA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <166be666-7ba2-c2c8-5b46-19d49aa90f93@suse.com> Date: Mon, 8 May 2023 11:17:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 2/3] x86: Add support for CpuidUserDis Content-Language: en-US To: Alejandro Vallejo Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230505175705.18098-1-alejandro.vallejo@cloud.com> <20230505175705.18098-3-alejandro.vallejo@cloud.com> From: Jan Beulich In-Reply-To: <20230505175705.18098-3-alejandro.vallejo@cloud.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS4P192CA0013.EURP192.PROD.OUTLOOK.COM (2603:10a6:20b:5da::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8309:EE_ X-MS-Office365-Filtering-Correlation-Id: 3a7c03f1-26b2-4ef3-3eb5-08db4fa5169d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QumaP+B9bD8yY9jg9gMvSwp/QqzTxVjEI06Y/qvbuDUI097zSkYh+jiriYXiKQUiKYI7/VKKdNf+cICpTGhffKDDTD2kb4U3T4/rM09xTK1/DdzRHYSDkQy/jQNza4Qy4AeXyXVn1AuSVHDWfvARnLZJxkZ36nwqN7XuWhIB7zBsbFEH4TL8WMcgbEYB9coN63eCme73VR+XHAyai6MHEC385veLbBjGBnxQseF9i0PLlg1PL+VpK4DcMeJrCPqct66ol5b2m6MACVSiOXWbgveq/MyChpQtUYGtQ1Jtbbs74DbA5GOjIJOWEYAKjYFQPurNhQ0gN/09XNsk3os9S2A3moKmjxklV/C3EbIoRjGcqhGPmGnQdLMINNcvYuKWHQiFOeirKctIoecr8JLzt6d1in9n473EaGLHZr8e8eC4lHOyKgZHpyq6pVz689nYGY6BkjgEjKD3OcU211CttBcfGguq1tP5Iykj9CybnaDvCN6B4PYRUlRHAgPUYfGuhB4Ixaay8jVb/MdOOMi63Zr/50s/C/zFcIqocFvc7Z8SSX87sZwlfFnj7ozxgtH7GMdyT+zKreYroMGIii+kkWM30VNCXd/Jrx9mvozG/HWaByaLXT0oardQVKaQEIgBSvFCVGng55HnRxY/luwHyg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(136003)(396003)(346002)(376002)(366004)(451199021)(31686004)(6916009)(5660300002)(4326008)(478600001)(66556008)(8676002)(8936002)(66476007)(54906003)(66946007)(2906002)(316002)(41300700001)(6486002)(6506007)(26005)(6512007)(53546011)(186003)(2616005)(36756003)(83380400001)(38100700002)(86362001)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bnhjZE9ZRTNXd2k0ZDF2SmpIWUgzS1dQdS8rdlRydlg2amFoVStVTDFOZVhw?= =?utf-8?B?VHZBOHdua0R0SnFYckJUNllPQS94UUZUQkY4bWkrVmx3MGFFVHBsR2ltdGhG?= =?utf-8?B?NGw1RDQwNG5GQiswSHNmRDdSM2ZlQTJQNHcwaG9mWUdCdmZLUWYrSmdGZEkz?= =?utf-8?B?WXVOazBIaTkvZE52aWpvMHZjTU14a29weHdHUFZQcUNzZEJNY0JPdDYxdDc1?= =?utf-8?B?ZzMwUFMvK2c1UmhXTEl2azd4WEE3VDd5cEtjWTFyblBZU2F2d2lpV3c3YUlG?= =?utf-8?B?Nk1UUjlNRG4wWkUxdHlXSEd2anRXQUVFYzMxQUp0cTJUU2hHVnB5NWlNVHZH?= =?utf-8?B?aWFObGszTi9XZmpiYjVaYlAya3lvUGplUHJNd0l3OGtZVCtjR3JTZFVEMVJW?= =?utf-8?B?cDZxaDJPd2F2Z0dQWnhCYXY4L0loaFk4MHZNZTdtaFhyRTRvSGtlcmRVZ2kx?= =?utf-8?B?SHAwdjJyZzQ2aUxtZDRSRGJpbSt2SFFCendaNkVDYTlkcFV1ditFY2dFQVZZ?= =?utf-8?B?bzhyUGtoMzI5K0lWR2thYmY5ZGhUMVVFUTNKS1NZdHRVU3RBcUtyQytITTVG?= =?utf-8?B?WEdjUEJXd0dwcGtlYUxSUjNHcFlmM3ljbE41WjhYMFhtU1NMaStGSk0xbGlr?= =?utf-8?B?THFUQkdoMXVFNjNYSnBKblVXeWhFaXF2VG9UU3FCYlJjelg2cDdHVU9TQXlC?= =?utf-8?B?dzlYRi9LdE90Q3BkdFVTL1dsZUxCVG0rR3orUjF4UGpTR0M3WTMvL0RxOXhP?= =?utf-8?B?bGtMSTY3ZFFUL1c3azhWZXYvTSt6R1pYOUxrQnYzV3IvSm9tdVA2NlY2TXF6?= =?utf-8?B?NGVzWnJFdFZ3eXZBSjZsSXNTL1JzK3pJbTV3T3hLM2tGWTQ0NFcrak9OVlZz?= =?utf-8?B?RWE5L3hkd1NLZkRETVdBdnRGVE5NeGNYUGVnanVGSWdJdWgxY3FvS1FPWkNl?= =?utf-8?B?Ujl5TFZuWjRNZHh5cSthUFVsVUFiVGlJTTQxcjgzV0FGck1MZTg2T2hCeDh5?= =?utf-8?B?c0wwM3hyODFFRm1FK0Vra3lIajFhdHN6VUtZakhlRXVXanEwZGg1V2xVQlZV?= =?utf-8?B?RXhRWEhRQUc3MTNSUFBGaWdJMXdOMVQzbjhUSmN1b3ZOSVZ0cnhaaU8zOWVU?= =?utf-8?B?eTJvd0krbStpY0NYY0s3Z1JPT1oyZzNxUzZTQ0NxTGtwT096L0gxQ0czL3da?= =?utf-8?B?U1lCMEROYVR4ajJmN3g4MHF6dlFEZzIzRE9OeTVGUlNwTFFudjlBRkIreXls?= =?utf-8?B?clJOY1M0SEFicTlGODB3NWtublFYdkdvam1GUTlZcVNlblV6amFzUHd6eWhB?= =?utf-8?B?N1k2cHlHZVBsM1ZCaFNLVzRyMFhVLzVodGplSVIwKytrQk9rc0NYYkxSR00y?= =?utf-8?B?N1FkeXhoYWw5QUNNZUExQnJUajlVNFNBUUZLS2ZkZ3J6TG9FVGV2NUR1cmpF?= =?utf-8?B?S2FIM0FOYmdIWHd4Z0V6Rkd3NFhCK2VmQzltUmlieGlmK0hFSnMvcm9jQXU2?= =?utf-8?B?VWpCMXlCNEsrbXJYSVVjT21uOVJsM1R1T2ZDbjFzTWllZFgreW0rZVNCL2Rl?= =?utf-8?B?OXF6SWxtQ3hqSllERE5zN1Z6TC81bEdibVhKTTFobWl0ekROQmZpcUtIby9O?= =?utf-8?B?d0NxK0tjcklzMnhXaTQvUERWUUFQVkMvWVlLTVFxWGh1YzlWZ3BROU5sTnVn?= =?utf-8?B?dWY2Mi92T3ZlQkpNVVI4WkFaRzFvQ1ZXVW1WMExJSElqUmtUWEFyNTRTUUdy?= =?utf-8?B?eFhiM29QU1pvQWRFanZQY2MrcGU2NlZSYmV5T2h2RXVML00zTk1HS2h0aEZV?= =?utf-8?B?NzdQbFhaZ0Y1V0hUUTQ5MmdPVGhOTUU4Q3M2VzVrV2YwUWxhZzhTVkZvMnVp?= =?utf-8?B?WjRpTHZCSld5emhjQ0UxK25FOHVWdjV2RXNjZ3FsY0xzWFpSRTVNZGh1em5K?= =?utf-8?B?OGdOaFNXV3V3UGswVGU3RFc1Q1VvTGhwSFF4NkhyMzgyRm0vL0RRM255QlRE?= =?utf-8?B?RVJRQzdKSENGTS90emJhMVBzd0dVL2JWZU8wOFdtanp4Y3UrTk9LRWVMWHFh?= =?utf-8?B?dlY0N3RISzl4UkZ0WlQvWUVOVE4zcjlCL0k1R21PU3o3ejBDREVpQk9PS3NK?= =?utf-8?Q?/jsPcQkgict7c/P1smZUTVPz9?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3a7c03f1-26b2-4ef3-3eb5-08db4fa5169d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 09:17:47.2832 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RVvGFbPiKc30cn9Niek7Ioxq2VIB7JJzbHSgHV0KbfsVvlXm2VXZ8crOokPgIbX8neDW8UZ5tg3jkIlhzbPgZg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8309 On 05.05.2023 19:57, Alejandro Vallejo wrote: > Includes a refactor to move vendor-specific probes to vendor-specific > files. I wonder whether the refactoring parts wouldn't better be split off. > @@ -363,6 +375,21 @@ static void __init noinline amd_init_levelling(void) > ctxt_switch_masking = amd_ctxt_switch_masking; > } > > +void amd_set_cpuid_user_dis(bool enable) > +{ > + const uint64_t msr_addr = MSR_K8_HWCR; Nit: No MSR index is ever a 64-bit quantity. I'd recommend using MSR_K8_HWCR directly in the two accesses below anyway, but otherwise the variable wants to be "const unsigned int". > + const uint64_t bit = K8_HWCR_CPUID_USER_DIS; > + uint64_t val; > + > + rdmsrl(msr_addr, val); > + > + if (!!(val & bit) == enable) > + return; > + > + val ^= bit; > + wrmsrl(msr_addr, val); > +} >[...] > --- a/xen/arch/x86/cpu/intel.c > +++ b/xen/arch/x86/cpu/intel.c > @@ -226,8 +226,17 @@ static void cf_check intel_ctxt_switch_masking(const struct vcpu *next) > */ > static void __init noinline intel_init_levelling(void) > { > - if (probe_cpuid_faulting()) > + /* Intel Fam0f is old enough that probing for CPUID faulting support Nit: Style (/* on its own line). > + * introduces spurious #GP(0) when the appropriate MSRs are read, > + * so skip it altogether. In the case where Xen is virtualized these > + * MSRs may be emulated though, so we allow it in that case. > + */ > + if ((cpu_has_hypervisor || boot_cpu_data.x86 !=0xf) && Nit: Style (blanks around binary operators). I'd also suggest swapping both sides of the ||, to have the commonly true case first. Jan From xen-devel-bounces@lists.xenproject.org Mon May 08 09:38:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 09:38:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531329.826925 (Exim 4.92) (envelope-from ) id 1pvxKG-0003lW-El; Mon, 08 May 2023 09:38:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531329.826925; Mon, 08 May 2023 09:38:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvxKG-0003lP-Ae; Mon, 08 May 2023 09:38:36 +0000 Received: by outflank-mailman (input) for mailman id 531329; Mon, 08 May 2023 09:38:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvxKF-0003lF-0Y; Mon, 08 May 2023 09:38:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvxKE-0002eW-Tr; Mon, 08 May 2023 09:38:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvxKE-0005OS-FU; Mon, 08 May 2023 09:38:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pvxKE-0003gx-F3; Mon, 08 May 2023 09:38:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=t0QXuejOLMFhkVDdq4K2uIBdkcnUddrR9SYGL3ZFuK4=; b=qnFCcaLspj3D3IEI0FbmZPzGbX /QQBBSUmDaeSBFy9xrlILXVLdeTXuU6962QpmJawvhrjovAeB1Xp9LldpuLEtttjpvCXIv1H9GSEr lQgtb3heKkReKUM6JIjOTTCwnCfxol9sByjQI8blc40Ourzo/s2tPJ/pUG6Fb7LbEW20=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180572: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-localmigrate/x10:fail:heisenbug xen-unstable:test-amd64-i386-examine-uefi:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e93e635e142d45e3904efb4a05e2b3b52a708b4f X-Osstest-Versions-That: xen=e93e635e142d45e3904efb4a05e2b3b52a708b4f From: osstest service owner Date: Mon, 08 May 2023 09:38:34 +0000 flight 180572 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/180572/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt 7 xen-install fail in 180566 pass in 180572 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 18 guest-localmigrate/x10 fail in 180566 pass in 180572 test-amd64-i386-examine-uefi 6 xen-install fail pass in 180566 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 180566 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail in 180566 like 180547 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail like 180555 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180566 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180566 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180566 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 180566 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180566 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180566 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 180566 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180566 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 180566 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180566 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180566 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180566 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass version targeted for testing: xen e93e635e142d45e3904efb4a05e2b3b52a708b4f baseline version: xen e93e635e142d45e3904efb4a05e2b3b52a708b4f Last test of basis 180572 2023-05-08 01:53:35 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi fail test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon May 08 09:54:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 09:54:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531339.826935 (Exim 4.92) (envelope-from ) id 1pvxZP-0006DN-Td; Mon, 08 May 2023 09:54:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531339.826935; Mon, 08 May 2023 09:54:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvxZP-0006DG-Ph; Mon, 08 May 2023 09:54:15 +0000 Received: by outflank-mailman (input) for mailman id 531339; Mon, 08 May 2023 09:54:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvxZP-0006DA-6R for xen-devel@lists.xenproject.org; Mon, 08 May 2023 09:54:15 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2057.outbound.protection.outlook.com [40.107.7.57]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4960d106-ed86-11ed-8611-37d641c3527e; Mon, 08 May 2023 11:54:13 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS4PR04MB9243.eurprd04.prod.outlook.com (2603:10a6:20b:4e2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Mon, 8 May 2023 09:53:44 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c%4]) with mapi id 15.20.6363.031; Mon, 8 May 2023 09:53:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4960d106-ed86-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UZmxu9xAj3O930y7bTTSf9fNCpB6pbgCA6bfKxSuHj8SRY2VCwlZSVo7R/HKGII6hzB7Yg2+kCBf70Ji/3TUDbDnIc/xcEjWLUz5XbICY2D0m0whiLx+1sVTFE2UQOHFCe9unMvH1HpcK+9GutZJZ4QLc/MckPI9iNCuO6QJvrgfOIshSasHLOCHOIUThFu9l0P3/PD9X8Br6e5rch4HvCNJaV9TiCdNPFWTKBc95XsYHgOCX6lYc/A4irRMfYO4d1/eJaEgtgfgk1vtCF799lzsFopdHGKncoCy5xZ1CDd4WKWGP0ib8z0g65KiFxGC3mbf/YF06a3lqrfPAoQhuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AIrHFTZ2UvRvRf56oE/0zxFn6W4wqe81S1kRnPkSL84=; b=nnT6kWS9QYpWtrGRT/9nSZ6O012Va6a2FwqnBC3uki4FIOAX+cbk5ZyA7NTfKWMiFVQs6qeD1YlTNhkEG0bV0Wl+3dkv6Sp0T8cUFj+NgsFBMT6p3TkV9ztUQF/C+SVtjoAzGjBE1j6G9piSylz3l1TgtZmoG4gEqV/T8Vcu+A/RlVUHaqCL0TOWZruUOpz1wXt2F1eQL0rDAXW3+CGPnaOni8SLGnGVj5447I4+p3aIpMuBsvwL3twmPz/PMsMt8tDOWDkno6juWmQSSI7YJQ54PP1Pf/sl6/hI/K7JNuhhxLSwA2N6hq3x3Jz0t/joeeyVEinjjFmYhLXonOy2pw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AIrHFTZ2UvRvRf56oE/0zxFn6W4wqe81S1kRnPkSL84=; b=pfgi1dLsdG6gfwX9Kp981dS5bK+00U5NHAaTVQ+8wohObcRE+nOjzvQ6YoLhhKWmVBhJqOWsHnfc9aYeJfCG05ujKkykbS2ASGHxnLSCpCO/gfTjXbNiNf2a3AE8ja+YezrU5ERxkjaNvJ0UMfw7SyxnKjL00jux0vtZ5bgG963OLIgGldmx2Un5S1QfBR1xETaAg5A/xAX6IZu6JqcCySR0MypRD7I4+1xFEIc5B37FgKoxBqRt9knK4hAmc+DoSxFIlPySUbQQzifvltraV6zlvTxhA4SNaZdGoHVMUF+AyrJ2yd75i5orpk8oYxl2O74atRz+XiO6/maXJyrzzQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 8 May 2023 11:53:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3 06/14 RESEND] xen/x86: Tweak PDC bits when using HWP Content-Language: en-US To: Jason Andryuk Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230501193034.88575-1-jandryuk@gmail.com> <20230501193034.88575-7-jandryuk@gmail.com> From: Jan Beulich In-Reply-To: <20230501193034.88575-7-jandryuk@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR02CA0003.eurprd02.prod.outlook.com (2603:10a6:208:3e::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS4PR04MB9243:EE_ X-MS-Office365-Filtering-Correlation-Id: 28c32217-2317-4bea-f561-08db4faa1c5c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nrQJEyU3LH2U7XScrQlHAohBOGh01oZfNhOdO9a/nM4V5XJfPKSbVpKun+Hu3sv529a2Jrash8nhEUeH5yglqurOT6Rw5GND7VUCAsa2mgtjDIq40BdD9uWsHbwT087LZii9osUvGdgNhO4l5U8JxwmvnBKIYdCile3Y195xDwhtTQGcElYXyQhC77mwWEk60ecOCXcFhxDiFZCNbfHfMnq5FqRnXrQKUk4ijhTbmmgx7UVYaFHPg3nh1XsRcSKSZmJnthfPHrte3N9Pu8XC5x7MXpLfpNLuXRkdJTKlIGYcc6nKWUcOK+8WIU0xP45lcLKKTQBvV7F1wDAjcp33AZfn+GO63mblEQd/IABH4kERSrGpZit/BbF4biUcy/MVPvoW59epyZmIiPVN/stbnqG5fSUYtD9NHmaByIv58ZymOJ4DW1YLuzQgXzOFzOVfftOSEEVQdk4FMh4ofKvJnb7ghcomugk4/xNkWL2b2l0djwPSDCUHOMr1dClaXdyK/1NEtewaoKwMYGBZtaSFxyBgLezKqyudM2+5qvrbtTPJ1EUb3L5JuK0lP6SQxhp5qbdMmPX4YKW9oUEkvsnxeRMCnnOcKE/dW8WVEn5g5yRphR8l4EXReYcb3xGuX7beJV81AWjJvUHYzj5QGFKWsw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(39860400002)(366004)(136003)(396003)(376002)(451199021)(86362001)(31696002)(66556008)(36756003)(54906003)(316002)(66946007)(66476007)(6916009)(4326008)(6486002)(478600001)(8936002)(5660300002)(8676002)(2906002)(4744005)(41300700001)(38100700002)(186003)(2616005)(6512007)(6506007)(26005)(53546011)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGp6andNcE1YYjgyNk54ZnpaSVZsMWFnaDlWWFluSFNrUVJxOFIvdVFYNGtw?= =?utf-8?B?aHJ6RlljcENha2hmV3I5bmFmSmVOMnZvV0VqY3NNTE53MTVieFlzbVNFNWdM?= =?utf-8?B?WVo0YVFSSlpXcUMrNWR2WWZ1djBrNHRGYXhsYTdZQnhhWE05WE5yYnpGeVdQ?= =?utf-8?B?ZW52TGN6Mk1qQUc0eXJmc3M1b0lTK3BLU0d0UW95Rm1LYWlieVozVFhyVHR1?= =?utf-8?B?eVl4YWg1RUJMSXVqQXo2QXpiZG9pbGRwbjVhQ214d0dUZ2QzZlpoSFFYS0Zy?= =?utf-8?B?dDcrQ1Y5blBzZGg0WURhc2RvN0JTdDJ4WmViQlhLRk01ZDhDVGtJNjZDWFNi?= =?utf-8?B?MUp0Y0NSOTBFL0VLYnZjNkFUcXI0QXBKY1VnR1pCUDhEU1NqY3d3d3ZGYWxI?= =?utf-8?B?OEdzckZCaEpjQktkRmdHaUJDNnBaOU1EZVRiZ3Avd01qR1dHVC9TQmc1bWxG?= =?utf-8?B?N2RLYTQ4VUt0NFdIZDlrWlk0VE1OalRZSTVCWno2YTQ5NEwwY24wdVdtZjI4?= =?utf-8?B?U0VVMkZxVUk3YWxNckpiVzg3bUdCN1BMQ0FkSUFpckZueW1PY2lwb25wZnZi?= =?utf-8?B?cDRnWWdpcGsyR1FHZVFXREk0azlsaG1FQ1c0SXVYR2liaDV6UGZ5cHhqa0M5?= =?utf-8?B?VllIQWpoUVVwSkdXVnlCSlVEcjRPZE9KMWN2T0hzOXUwakpaMG03QnhnYmJB?= =?utf-8?B?U2cxS2hWaWtCKzdHMXZhTGt6RzVRbjZJT0JOK0E0VURnWmcvMHpWc3d6blc2?= =?utf-8?B?UUlvR1pZczM3K0NWSnNia3dEdkhxMk1tSHVWY1JZVllWT2ZMMTlveVdOYXZ2?= =?utf-8?B?WUVVakNGalFOYWpSZjR3YVpRdDNmVGVPOGVNTWdidHJtbG54cWg5emVVM2d3?= =?utf-8?B?R0QrZmdESFJXY1hZUDhEeUxNcDVmWFhlMkQyTmU0KzBIeThhRXpJRXkwZ3hq?= =?utf-8?B?UzFMSHI3UjRvUmQ0MnhNUytuT3ZkajVCOFE0aTJxR2tldzdtRDlRaGNKSDVH?= =?utf-8?B?czFBMEJ1c3ZNUVpxWEhuU01Wb3hVVDBQK3Raakk5NjRYaUpKa0VYaExLbEh3?= =?utf-8?B?c2hrY01RdUFHTUV4OHJLQTRUN0N5bXg3WC92d2JsVkJ0REFVcWFEQWRhTXRD?= =?utf-8?B?dGEzbk8xR21NQUFhbkU4Ti9QeW5hV2t2UDhESTVYbDJOM3BoSUplbTA3ckdV?= =?utf-8?B?SEJTV3Z2aVNPWStsbVJKVFJPRU1JU0RzRWYxVksxTHlGWGQrRis4YXJqQnFa?= =?utf-8?B?UHZGUzI4cWRiaTJicjVkQmJqSjRZTno4M3d4QUdpdGxDcjJXWDJkaUZLSGxM?= =?utf-8?B?aG1KZGovYTFvd05BRk56eDB4M1lobHM0cjR5R2E3OW5sRzluSVJFTmh5OVEy?= =?utf-8?B?YTAxOWNIU2ZobnFGb2NNQ2dJUVd0aTlVKzR4Ym9ZNTd0bXJGMnE3NnFsWmN5?= =?utf-8?B?V24wNTYrWU9PT0hJTGdnT2FhRkhubWJYaEVINFR1TWVSb01DbTJ6eEc0dTVO?= =?utf-8?B?MGYzbkZZQkhXbUF1ajJCUlFUL3VDekFBNVpXeUFvUFVsb1EwckFsUmRBNjJr?= =?utf-8?B?WHBkeEJVSlZOZnZIR01zRkRJdU5tdGkyM3lTYzVCQW9ONVBGQXdtYU1acWQ4?= =?utf-8?B?ZU5wSE5GVE9pbUJUWXhIUExBTzNaa0Y3MjVyTHU3REprbHN3K0VHaGt4dEkr?= =?utf-8?B?T0dOSFFzS293RWY5ZzRpVStvQ2JiL0ZNVUU3c0J0cGtWblE3NHZadUFobDhu?= =?utf-8?B?NWZPbVZIVnh0WS85NjBhcXdXZTMvZzM2WGNOQTdOaGMvNGNoNTB6R210UEpD?= =?utf-8?B?Mlp6R1VKSC9LS0JxMTJBV0ZhQUtYWHJHNHJsbTg3YjI1QUJlR2swbkVGa2dJ?= =?utf-8?B?YzB0Ykdxak4zWnBqbklRV2JZMEZyaWtJdFF0Mk5sVS9SV0lQNTRVOHpUcytl?= =?utf-8?B?SEVnV3lqaFdjMlRTc1RMMmwrMkNkNStpWWtjRkVRc2Vzd2sreGxqOW1Pb3ZR?= =?utf-8?B?V0F1Uk85UHdTSDhYenY0SUh5NWcyUTM0T2xScDBkckViRzFlaXRwR0ZrN1Zy?= =?utf-8?B?eVBSWFYybU5nQmZsWnI5dXpRUjBpeDRWdGlHdjJUald2eVdoSTRleGhsaHIw?= =?utf-8?Q?jUJW2pru5MCmYtWOPWgf0agKY?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28c32217-2317-4bea-f561-08db4faa1c5c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 09:53:44.3971 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ckl610/XuD9ncqB9myUUDZ/LSEGyNzQvHrh57dPqU4dcaD+eX2W2rRo0TzejGBPr2p4nrg9rEc0D6p151iiKqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9243 On 01.05.2023 21:30, Jason Andryuk wrote: > --- a/xen/arch/x86/acpi/cpufreq/hwp.c > +++ b/xen/arch/x86/acpi/cpufreq/hwp.c > @@ -13,6 +13,8 @@ > #include > #include > > +static bool hwp_in_use; __ro_after_init again, please. > --- a/xen/include/acpi/pdc_intel.h > +++ b/xen/include/acpi/pdc_intel.h > @@ -17,6 +17,7 @@ > #define ACPI_PDC_C_C1_FFH (0x0100) > #define ACPI_PDC_C_C2C3_FFH (0x0200) > #define ACPI_PDC_SMP_P_HWCOORD (0x0800) > +#define ACPI_PDC_CPPC_NTV_INT (0x1000) I can probably live with NTV (albeit I'd prefer NATIVE), but INT is too ambiguous for my taste: Can at least that become INTR, please? With at least the minimal adjustments Reviewed-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Mon May 08 10:01:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 10:01:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531344.826945 (Exim 4.92) (envelope-from ) id 1pvxfy-0007lM-Jy; Mon, 08 May 2023 10:01:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531344.826945; Mon, 08 May 2023 10:01:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvxfy-0007lF-H7; Mon, 08 May 2023 10:01:02 +0000 Received: by outflank-mailman (input) for mailman id 531344; Mon, 08 May 2023 10:01:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvxfx-0007l9-7i for xen-devel@lists.xenproject.org; Mon, 08 May 2023 10:01:01 +0000 Received: from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de [81.169.146.160]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3be2076e-ed87-11ed-b226-6b7b168915f2; Mon, 08 May 2023 12:01:00 +0200 (CEST) Received: from sender by smtp.strato.de (RZmta 49.4.0 AUTH) with ESMTPSA id x6987cz48A0qzp8 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Mon, 8 May 2023 12:00:52 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3be2076e-ed87-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1683540053; cv=none; d=strato.com; s=strato-dkim-0002; b=C8RfRDt9q8ZIHNKnF/GJYgSvQ3FPjV6nUWGp+BeLTCzZMWxLTD6uEKsvGxVwyzYr// ll0H1DEmJQlaR1s/HK4j5XRQOwuGgN0C1JwKX4wEbrdUTk+u2DsbITSCxalUh1G9AFzi LKVzCmJP2ZyUbNnCOG0W+aKBXCyQdRlTs7zh+ZzwF5mZ/Bw4hhfA5fMmY6hRu2bEvW4G Flo9pp1jvY8x9faf45+9A8mPpSLYaOjOwpnD2gwW8r0O+VLbx5pyEZ+buRiFbuL8+j7f cSWXrEWARbJRW8n3IEn8wj2fr9EZDiMmph5ZNxL9SjjCHm6l89vrl4jqqCv278SWd9Rq 8daQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1683540053; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=aZByrSjFH0yqleLqhT4Rj8ItPXbhzHGznL0O1xXh5es=; b=DmgxL+VoKlAXTEoz6y2lQYGA4g2J3O7ktfXsHjrrBNWz68WB/1tGxSIWZlhw12OZZ9 uglZvxX7rxSVGJug9Lc6dukDqeNuozpd4JliNRcrEEr/i2JU9gL7jQdtHcARnNL2oc0m 929hKAzm6jiDypqnmJGk6CHuoppzMwa74DAZXxRTblPEOlToa+918CTBUFFFcvcGCFvT xzBMoYl7CuvJvm5RhSCfJ3mSZ+42F8pJ+FIQyIjhJM47Grani1eM9J+sIZTW8JWrorAF 8wGppusiVfhs8il0XTEKzP2u14WkI67ravE4c9VWUi2yg1MnMmPtL6cmPZlFAq1JKBsP J2/A== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1683540053; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=aZByrSjFH0yqleLqhT4Rj8ItPXbhzHGznL0O1xXh5es=; b=iNVj+Vwpk0J+vuDQ+0IIeOQC5VRWdFjoW+FN3WutVjwuKW7E/Du7RlWdvpui+41pt0 J44oxXQ3O60DJ3KT8I9ZLjxqHC7Vghate9aWEE9WDvKaP5UUphAXIymZ0N/3he49c9y7 MYefUOvfrwytlLokcJ2k3j8L/ZblRSmW+ineTY5DEsTHqF78apBSvN8CmLQR3B4cY2jK Aj9VT6Ujg1DOTyUg33a68DxwE/SfwXQrTDh5xJX/npvU193iat2UpSKm50ukCE052Jtx 1R2Ubu3QMDOjYe12mUeYXASbIfyDyv9PfvrrxbrKu+ljEv8VK3vd0wrTptGRKIObN4Yh rlIw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1683540053; s=strato-dkim-0003; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=aZByrSjFH0yqleLqhT4Rj8ItPXbhzHGznL0O1xXh5es=; b=ZJi7MYJMkFleSzwr4FB01GFsS2M/NnmtxNBZ/azVkqNqUxO2xvmZLu8VJv61PJ1zDr 4xW6elgnBS4ERlHfnnBg== X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisR4ARWIYxzstZKeVom+bauo0LKSCjuo5iX5xLikmg==" Date: Mon, 8 May 2023 12:00:38 +0200 From: Olaf Hering To: Juergen Gross Cc: xen-devel@lists.xenproject.org, Wei Liu , Anthony PERARD , George Dunlap Subject: Re: [PATCH v1] tools: convert bitfields to unsigned type Message-ID: <20230508120038.74246111.olaf@aepfle.de> In-Reply-To: References: <20230503150142.4987-1-olaf@aepfle.de> X-Mailer: Claws Mail 20230504T161344.b05adb60 hat ein Softwareproblem, kann man nichts machen. MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/glmW5p0I8X7ORaw7EpscoEJ"; protocol="application/pgp-signature"; micalg=pgp-sha256 Content-Transfer-Encoding: 7bit --Sig_/glmW5p0I8X7ORaw7EpscoEJ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Mon, 8 May 2023 11:06:11 +0200 Juergen Gross : > > - int short_summary_done:1, prealloc_unpin:1, wrmap_bf:1; > > + unsigned short_summary_done:1, prealloc_unpin:1, wrmap_bf:1; =20 > Please use "unsigned int" instead of a pure "unsigned". The entire file uses just 'unsigned' for bitfields. Olaf --Sig_/glmW5p0I8X7ORaw7EpscoEJ Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmRYyEYACgkQ86SN7mm1 DoA6uw//RLr3DtYxH/Z1tht+kPZQeqyhjfeErQeBDI6NxJ1V9gldO7GhcKBQ72nv iFf10IdLrcPgRpNlpkhbglMSk6og2sBvN0gngWRfGlR8Bf5223mZpECyod9S93iR EcXb6ZzA/KDxzynDjddFr7MVBYY77bp6gHs5Bs7PjCrtSaV7ziSHvrn4lZYrbhjj QDlCWcWKOVPlsNPDkr4hCOcHJ865L/xi6l9Uyz/KgXgAsO078/RYXjVA03Cc0M8Y kR7vOijzt6F1/4oYwrcMwK5Hsf5/H9aSwTXvxfmfGMTlDvLPsipoHtHdLMY5J9nA LWLpiHj7zBtkBio2tEmLOa0tKJ2YQzjEVifz/gZgKiGFucMu14QX62jewRw/ssTC s4EdGAd3st/V03R84p7Yz0a+EgL3fLpzPqC1WsM4LhP0gWS/X8vysOTmk499jXE0 HvFwMCVLgdAApvcqbCdGeyLhskMslUeibQoKJf+XJ+PeAQCoUjYeiMxMz8j2OgGN 7yVEzxX1RTZzRztaSA4nDqOrh68Wc4nq6gh4/yia5IOqdPOAbTFNhFbvsCoRTTs7 taV3iwwS7rz0lSj/QRfekPfKS6EuU7f9gO5xykJiUQJ6YCiMs1D9e/eXeVxveNIr K9hurDOp2H2tOskQUzFLAyu1WLy3pkxVPdcGJncQND/fEEoD6ag= =KWgt -----END PGP SIGNATURE----- --Sig_/glmW5p0I8X7ORaw7EpscoEJ-- From xen-devel-bounces@lists.xenproject.org Mon May 08 10:26:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 10:26:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531357.826955 (Exim 4.92) (envelope-from ) id 1pvy4M-0001sD-Eq; Mon, 08 May 2023 10:26:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531357.826955; Mon, 08 May 2023 10:26:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvy4M-0001s6-Be; Mon, 08 May 2023 10:26:14 +0000 Received: by outflank-mailman (input) for mailman id 531357; Mon, 08 May 2023 10:26:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvy4K-0001s0-K8 for xen-devel@lists.xenproject.org; Mon, 08 May 2023 10:26:12 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20630.outbound.protection.outlook.com [2a01:111:f400:7d00::630]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id be847a7d-ed8a-11ed-b226-6b7b168915f2; Mon, 08 May 2023 12:26:08 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by GV1PR04MB9516.eurprd04.prod.outlook.com (2603:10a6:150:29::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.31; Mon, 8 May 2023 10:26:03 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c%4]) with mapi id 15.20.6363.031; Mon, 8 May 2023 10:26:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be847a7d-ed8a-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WqX4YNv1ss9a71FGly4Tj5FKhsgvh4kZjqvBbp14dNKSiKXYvr1YVNpBShTtJ8JkthHLxk1w+eXqCoIjVHKbszkcmOwDSjEEk+XiBEQto5gyIKd8diZ8Oksis1eLLIgSpvAMoRX0FSBd2LrVPaJquFQAq/7tc+V26kLt8PDr9cNXIyxdTkQVxDsN/VuWdi8H6PbEglw8TeCpWyNVTDc94azuPz3zvs1oOdXiFr3GmF8MO/p+VO7l4s7sudg0r+AvYGEPfaS5dGlYmqRDgwKSIpdPbUPnkKC3e31pIGMKVkzM6GZvjBWnJPjHDkSm1KFWoari7DplIRre2rshROn+eA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VEr9T4xbk3VHvgP500GYHqgmh3Go+O1E/iTwnb/XR6M=; b=g3xpMVN0r43uX9r8L085gX3aaIayOjeLWQPLH7FB/ZqltyRQbDcta9pK9dVfz306LTMSVkhZbnuFbENB9CGOYXJ8ym2llddc1Pv0u5zB1HUZehnhrA+R6j227/PAV060bGdSGJd3GmO2FpMfR0M82YvKk9WhAMw1mtT7WGX80z4sDr48y4ThRwCo8lTBPR4L3SNMTvewkkKJym8B4m0StmuEc7zPoQmes4DMJTlx/s9GOv0EAWauK5fW9iP6BmZe4V8ylJpQanu3qsWMNS1/p7dEjYFU1V6ueDIR9LSuwFTwydg4ecihNb79ruFBQ2/ikQkmGxi1SSQOG1aQrHn6iQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VEr9T4xbk3VHvgP500GYHqgmh3Go+O1E/iTwnb/XR6M=; b=MhekFcRTWJrelCU7gvQvWLWM1Tq66BklVJGTRlVhWvK9YqxpxgMBN9RA59FCXLX3ccr5sFgJPJFJCAgneLRAuF+fHsSpXrLmLAUg2exzMeQ12NKjH6pSrY/kafp6dRFBQiO8hGXQ8VRGAk83ZZfgyeecQ6+fmrYX1qlFVBTWL0hwCUVyMq9XRgBUvlvEi88TwQlO8VehehH68rweoDfEDeqhubXSsUiAVb/USbvZslOWaP23//RLU7GzwwenpgYWQDy7MC/KLsHxbGSHOm9QKrUVZsN7oLL0E2GDuRkFx9gDlHF45hWXy8nbxEbRkVbDWHpvCWukEtaitlDhr678GA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7db38688-1233-bc16-03f3-7afdc3394054@suse.com> Date: Mon, 8 May 2023 12:25:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3 07/14 RESEND] cpufreq: Export HWP parameters to userspace Content-Language: en-US To: Jason Andryuk Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20230501193034.88575-1-jandryuk@gmail.com> <20230501193034.88575-8-jandryuk@gmail.com> From: Jan Beulich In-Reply-To: <20230501193034.88575-8-jandryuk@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM3PR05CA0100.eurprd05.prod.outlook.com (2603:10a6:207:1::26) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|GV1PR04MB9516:EE_ X-MS-Office365-Filtering-Correlation-Id: 05a1de6c-5a8c-4282-642b-08db4fae9ff5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yhzfp7HfkF/iFuuLkRLLJbbXB7YfO2p4rdofOQsVPGMy6sbOU7p1sK+Rw2akUl1up9jHKHETy29DlTrz+PE5BSfPaf9SdtoQkKUycg3NdcnHc409OqkvBEETy21YKnQfYf/ykCNEwWsDgE70WzsRHnDCNTbtstpxpgPQWJ3n1zzUwTMLDLcB8arRw2v7/qBlT/Zddth/+li6VCHO9p7tS2XC7SbIX825uoXN/Dn1hd67Tuaio/aDuFk2BT9vkMR/SylvhItowPUNwIP8oUeeTZk7kDwOVKMLcmSaSSYRB/Tbc3XGiGJWptfJ+GuyxT0U15WC3Z84EbCT5rDBbj1LzDlEu/5w5vv13qeVuxgh9sxKod1quY0l6YlOm23edBhrN09wCup7xQcGeRaRfapiEMjyaMniM7+YUauhNAj4wmNS20y1JMy8SxyQ/JNJca+0KpeKu9YTweSWF8a19DTpBhvECKgYKtrEGA0wprZ1wtaDca+z2zzVzc3+84mebcpxlBTN2rqijBw8L8kaFVMgOYQbgVrP+7Zotzi2639G9jIUH+552NxNIdf7xyrCMYMtSaigIqXzWCgUmR6iWZ1L77bV1EGHSPF4spMfzsHbeZQePtFe3xqwq3NfWFDcigfertCI0fUNWILM/9BUZVCl8w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(136003)(396003)(39860400002)(376002)(346002)(451199021)(83380400001)(2906002)(2616005)(186003)(36756003)(38100700002)(86362001)(31696002)(5660300002)(8936002)(8676002)(66556008)(66476007)(66946007)(6916009)(4326008)(6666004)(41300700001)(6486002)(316002)(478600001)(54906003)(31686004)(26005)(6512007)(6506007)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bHd5VXNXaENDeWp6Y3FkVjJkZ1dXWW5kZThHTURwa2FaMVEwR3crKzRWV0NX?= =?utf-8?B?K21sZERFaTNhdFM4WEtneWhSZER6WkdvOUhpZktsdGlaeTZXaHFWNDZlNzF5?= =?utf-8?B?NWZhOVFXV2JOQUtlK2wvcGZsTGRSNnR5d3JTOVhISWk3RnlKZVVqU1hlODRN?= =?utf-8?B?NExBbDhHME05MFcyYi93WDIzRjBWOXFUalNwOVNSZmFydTBrRm9JcE0zQnNW?= =?utf-8?B?YUJUUkxyMGk5NDNRSGNidWdhdERpU1VheW5JL3VnaW9xSmVoNlJZS1BwQ2pC?= =?utf-8?B?RmV3eFdsaVlaMVcrTUwxRndwU2kvb3FTNU9IdWpPa1NDQzg2ZDNTTmY4b09K?= =?utf-8?B?NlQyenRERFkrN0Q5RU80QXhUOW81N0RiVDlRaDVNVFB0Y2kxTmJvc01sVFBw?= =?utf-8?B?K0dBb2g2SGhJa0VVNlU1UkNLYm5zVzlGOTJkNTZEMkR6bENDUmRISlU0a1Jo?= =?utf-8?B?blA0OHRXUGowWTNKekVXRnhlV0FnRWJaNk40azVNUEk1cFJ5UHcyMWNkUndN?= =?utf-8?B?YjNKdmxyWnVKQnRQRTNiL21FTExHMGFhL1hkSG9uelByY25wbmpGZ1pCbHpQ?= =?utf-8?B?MnAvdTExVFVSTk5uTFdweGhYc0dhTFN3UVF3QnZ4TEU0dmVuMUVRdmhoSlNn?= =?utf-8?B?Tno2YWV2K3BlQVFGaUNVUEpVK1daSC84c0FPMWJ3MVFWNXpFU0hSeVVYSzFI?= =?utf-8?B?bWtIZWxIVitXcE9DTktPUENYN2thZ2JVNGJTdm1QaHl4UmR5dDZPaFc0TzZw?= =?utf-8?B?bUZnY3k0OUNpaktrTmd4MjV5dENXM3JaRlNqKzNpUUtEUEFFazZsT04xbnFl?= =?utf-8?B?Z0lROVVSWkc0YUVVcGJJRkZpV1hOUHJVSk55SzZmWSs1cnZiVmc2dEpUMnpS?= =?utf-8?B?RFJXUkI5V3FINkNlRlpIR0tyOWZQVzVrcHFZSDVJT24yc0FuUjBKbnBsVHlZ?= =?utf-8?B?aVhiY2JRa0hKY1M1QWExV3A4Y0tXM1NZYjFma1VzQWRZcFRJdndUUWx6NVRz?= =?utf-8?B?WGIrRlpiWmNTTDhUeU1KMmFGY1F1ZEFUV3Z2ODN3QTVPZlJoUmY1ckRMK1dM?= =?utf-8?B?a0hqRUJOempjOWFuOUVTc3dQaHp1RlQyME9LalNkS0xaYlVsTzU3dmlneGVG?= =?utf-8?B?b1VJZDdzcWV3eUtvcHhsLzdWTm1xVTR2Z1BhWGtGTGY4VUUxRFJaOEtOQ1dN?= =?utf-8?B?Q055dXlpVS9BTE1FSHVJMXBuSmRZS1BhejZKcmtQb21aLzJTUEQ3SkhlbTA0?= =?utf-8?B?cXRUNktWNHc5WUY1YlJUZEticUJzQlBNNEg1QTZJZm84YzcwMUl6c2tDQjQr?= =?utf-8?B?QlFRWVBGRjRlSldlbDQwNUJwelh5MWM4WXAzWUpYMlNZcmhDcStJN0FaRGNw?= =?utf-8?B?NG9sMGpGRHRsTUdlUUtiUThPYWRWNnBkZXdqOVM1T1ZVbDErd2Zmd3BuOW5Z?= =?utf-8?B?UkxZeThYaGlYdUlwblh3WTdYcm5KL1ZzMVhKVjQwUitHOHkxNzkzSnpyWEtZ?= =?utf-8?B?cW1aREhodjExby9rMGNJa2l2SitUak14c0pVcmtiZm9pYUQ0cmtsTkhVbTA3?= =?utf-8?B?aEg1Rm5Cb21oVHhFMVduTEczOHA1bjU4VjNnWHlQWTF1RDlVUWkxdEszYTlJ?= =?utf-8?B?cEh4dGVIRG1RajhkYWtlUVBQMVF0TDdQWmFRMzlEUUVMclBMajNUZjR2RE5a?= =?utf-8?B?eDZKdnVzVlFtTm5pLzhtd1hiMUlBVTB1eFdqOGJrdzZ5dGlKMGRUZkwxdU52?= =?utf-8?B?c1o4QWs1Q0cxTkxIMmVubGNzRldPSzRaMWRMaWlEbWxvL29mWUhHd3VzQWNP?= =?utf-8?B?RHVnOWZQRFdpNmErNnpyUWh5RS9sb2VZbmgxWTF3WkhBaUwrVUdpQkZUblJq?= =?utf-8?B?RXNDdFhFcW5XVStaLzFBQlBPakhBY2kvQTBvbCtGZnUyZDlVd0E1WThuZzMv?= =?utf-8?B?ZjAzMksrMkJlUmgxT1N3VlF3MTlNVDVDdkRkUDdzU2FFUTViUTJSL3A4N3Y1?= =?utf-8?B?S010dGFVay8yclYzUnhEUFRsSldDQzU4UkJBNzlwYXJNYVNPOFlmRXBNdTly?= =?utf-8?B?S1FGNzEza3gydmIrWGVzYWU5M1RWeDB5Q1dpT2U1M1VQUDlHMEUxYVhSbklJ?= =?utf-8?Q?BaHi3wCASH7uaVDF0Q0lXOak1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 05a1de6c-5a8c-4282-642b-08db4fae9ff5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 10:26:03.1200 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5kxID9A2ZrzYjgE2jq9Rz0VEIYsyk02/cuKViyHpxSnPdvbTUA6Dj96PP3n/7U5aT778lB0ydR9zBjtm4bV8PA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9516 On 01.05.2023 21:30, Jason Andryuk wrote: > Extend xen_get_cpufreq_para to return hwp parameters. These match the > hardware rather closely. > > We need the features bitmask to indicated fields supported by the actual > hardware. > > The use of uint8_t parameters matches the hardware size. uint32_t > entries grows the sysctl_t past the build assertion in setup.c. The > uint8_t ranges are supported across multiple generations, so hopefully > they won't change. Still it feels a little odd for values to be this narrow. Aiui the scaling_governor[] and scaling_{max,min}_freq fields aren't (really) used by HWP. So you could widen the union in struct xen_get_cpufreq_para (in a binary but not necessarily source compatible manner), gaining you 6 more uint32_t slots. Possibly the somewhat oddly placed scaling_cur_freq could be included as well ... > --- a/xen/arch/x86/acpi/cpufreq/hwp.c > +++ b/xen/arch/x86/acpi/cpufreq/hwp.c > @@ -506,6 +506,31 @@ static const struct cpufreq_driver __initconstrel hwp_cpufreq_driver = > .update = hwp_cpufreq_update, > }; > > +int get_hwp_para(const struct cpufreq_policy *policy, While I don't really mind a policy being passed into here, ... > + struct xen_hwp_para *hwp_para) > +{ > + unsigned int cpu = policy->cpu; ... this is its only use afaics, and hence the caller could as well pass in just a CPU number? > --- a/xen/include/public/sysctl.h > +++ b/xen/include/public/sysctl.h > @@ -292,6 +292,31 @@ struct xen_ondemand { > uint32_t up_threshold; > }; > > +struct xen_hwp_para { > + /* > + * bits 6:0 - 7bit mantissa > + * bits 9:7 - 3bit base-10 exponent > + * btis 15:10 - Unused - must be 0 > + */ > +#define HWP_ACT_WINDOW_MANTISSA_MASK 0x7f > +#define HWP_ACT_WINDOW_EXPONENT_MASK 0x7 > +#define HWP_ACT_WINDOW_EXPONENT_SHIFT 7 > + uint16_t activity_window; > + /* energy_perf range 0-255 if 1. Otherwise 0-15 */ > +#define XEN_SYSCTL_HWP_FEAT_ENERGY_PERF (1 << 0) > + /* activity_window supported if 1 */ > +#define XEN_SYSCTL_HWP_FEAT_ACT_WINDOW (1 << 1) > + uint8_t features; /* bit flags for features */ > + uint8_t lowest; > + uint8_t most_efficient; > + uint8_t guaranteed; > + uint8_t highest; > + uint8_t minimum; > + uint8_t maximum; > + uint8_t desired; > + uint8_t energy_perf; These fields could do with some more commentary. To be honest I had trouble figuring (from the SDM) what exact meaning specific numeric values have. Readers of this header should at the very least be told where they can turn to in order to understand what these fields communicate. (FTAOD this could be section names, but please not section numbers. The latter are fine to use in a discussion, but they're changing too frequently to make them useful in code comments.) > +}; Also, if you decide to stick to uint8_t, then the trailing padding field (another uint8_t) wants making explicit. I'm on the edge whether to ask to also check the field: Right here the struct is "get only", and peeking ahead you look to be introducing a separate sub-op for "set". Perhaps if you added /* OUT */ at the top of the new struct? (But if you don't check the field for being zero, then you'll want to set it to zero for forward compatibility.) Jan From xen-devel-bounces@lists.xenproject.org Mon May 08 10:44:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 10:44:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531364.826966 (Exim 4.92) (envelope-from ) id 1pvyLa-0004Hy-0X; Mon, 08 May 2023 10:44:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531364.826966; Mon, 08 May 2023 10:44:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvyLZ-0004Hr-Rl; Mon, 08 May 2023 10:44:01 +0000 Received: by outflank-mailman (input) for mailman id 531364; Mon, 08 May 2023 10:44:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvyLY-0004Hi-Fj for xen-devel@lists.xenproject.org; Mon, 08 May 2023 10:44:00 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2052.outbound.protection.outlook.com [40.107.13.52]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3b65f0c1-ed8d-11ed-8611-37d641c3527e; Mon, 08 May 2023 12:43:57 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8972.eurprd04.prod.outlook.com (2603:10a6:20b:40b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Mon, 8 May 2023 10:43:26 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c%4]) with mapi id 15.20.6363.031; Mon, 8 May 2023 10:43:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b65f0c1-ed8d-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hQK67h19T/9ze0UJVawzQDmmgiW3nt5uAK9TJ8VtSz6qZslE6dhaCDY291n2hSteeizN5bxekdTt/1p/LFpcOfbVgt4cAJSxVdKhFP3P6UJbBIebQh2uvSUlnoHN423QmECS/L6+w8KK9NY/nglB5afMTSjKHMoS/dd/lWr7aZmQO96mG7LfMMuqu8tVXxlH7q7qaDIu7f3fCg2RHifs4nukyMEKNKKWoBtWxJ1nGU1egPCBt605qVaIbgszrD9dbTRCKqst1UYKOB76iw7r4yHuA8hr6llFQQ0Snei2govYMl6qN2Wbl+8yv0YeDsbAboT4ZB8kLjlNyQSJGPSgIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+Vnj8BGxFdOpi+mDnv+mAqFum0KzLAlOAdeTOWLMjIs=; b=B0OgsHvxVQR3kafYFbv1tVDuEUFk+v1OqHZhKouVZPxbF9qteT5wNMAY5Kh9imsflZN89uKM7ZN5sA4GHPqjuHeTkLNO4xNVamouwaLxq3CkzkWwkPQaAa7TSd7ap8tHgOMxIYElhgXj0G+DgxG535YSzqVp57a8AsUTPSFvwau/S9XF3VgWkSTM7MzYXXftsVkp5LYKTWf0PbAUxpcohxjxXURKhbCy0PpXlzGl096SzLwoPCeHXbadDOztIBtvNqA5eySStdTxIP2eakOl0oGcOF7V8nW6zDTg8XyysnxIeaX9esqqXW8yo5m5LFjp4ToKXTtmBljQux8+S3mNGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+Vnj8BGxFdOpi+mDnv+mAqFum0KzLAlOAdeTOWLMjIs=; b=Wz8ESupLngXCenUVeARG9XeFNiZsQfkroTdHbTb99c3fj7lWW9PpW8RqGTS8cxqNZY0bFWJX61NJyU4pqb4q3lTgolkZGZgY8JkUyOQac/qH7qzHfvm0FULC9UnQk5cTZsvK9pjZwVUIpm1DRAX0o6EyT+4tKIF34SSgGv/zP4eS9jb+y8kp+O2tuItQB9LXCUyWL2J7FaW83FLjjDtNoNcpc6tdaBIz9PDr6CFsQzvwcsEoLZOnS3tkdUplxXC5E3URF+AW1sqbpajtab0C/lsvPLGl0M9fwRDNfRN7/yJzNzMe+Gl9u7KZ3LoC0A2Wr683BIDMnKbGj1DtuzcKqg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <256fc66c-066f-3f0c-b34b-a237e9268f22@suse.com> Date: Mon, 8 May 2023 12:43:14 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3 09/14 RESEND] xenpm: Print HWP parameters Content-Language: en-US To: Jason Andryuk Cc: Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org References: <20230501193034.88575-1-jandryuk@gmail.com> <20230501193034.88575-10-jandryuk@gmail.com> From: Jan Beulich In-Reply-To: <20230501193034.88575-10-jandryuk@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR02CA0001.eurprd02.prod.outlook.com (2603:10a6:208:3e::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8972:EE_ X-MS-Office365-Filtering-Correlation-Id: 65287fbd-5e2d-49b6-483a-08db4fb10db0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7JpMww0oG3sIX830c0JnR9B3CuR8bo58MZ7MR8zcVDBZVXtFMq6tPErsNKPsDNHgz5N2fom6MFnqSu8ZLzY85r8/rZ5l7qjoJL3MzMUukfTq/gEmZdAuHLMrJUVrLFjDCyGwoMf1KcOzr+070m/KCyWhKLYz8lVsGVLO/B6pyr88WvyHYgGQyhK+ozpSPHB6+8x39kZtePFJS6wRBtFho4j+y2DhfslvZH/TGOJEPggNOV3q3ALzyjQKjPg9wUJGL5utns80zCihEkYSuzp9aAB4FedRWjZBgrIjvGDfo9n9O4jIxMiKXLO2XyJZMI32p82LJVKuR4v3idvVyVUcy0wimI+/x3jNYf6U8wkspiDbO7Puvim1UplULidJhqv91kg9QyFj9janRRC4Y1/NP9qf8ht04N3FbNaF3zmR76QJSkOk/Fn6ZhsTo6kOU/qP6wZhpA0mf363evgLC861zZPed8hRKc2jT9JqVSyA1ljCoLlD23C2theDwmT6Eao33BppXTwxVwVU/5kmeSgV/A0w7kdftAj5rZeoV9dCi/KqfuLAlXrjeFTOL3EkX+dgq48E37fuBPq8fZeUlFHYCspRcVBBUkv0YXLhz1vyoDb0bmeSEmZVlR+r/jSOKIJcCMFHiM56HUpRlEl5g0NUeA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(346002)(366004)(376002)(136003)(396003)(451199021)(31686004)(66556008)(6916009)(4326008)(66476007)(6666004)(478600001)(66946007)(6486002)(54906003)(316002)(86362001)(31696002)(36756003)(26005)(53546011)(2616005)(6512007)(6506007)(83380400001)(5660300002)(8936002)(8676002)(2906002)(41300700001)(38100700002)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dG4vdlRSTFI4OWhhRGJrKy9kZmRzZCtRVFZqamxoWitLZjNYSDVQMXRrWkNJ?= =?utf-8?B?cTBRUklBbUQ2Y3YxS1lTajFjWUw1NHc3dnNBWmlHTml5NHE5L0t1eXQ1TGp5?= =?utf-8?B?bnd0TWk4MGI2OGFEN0JLMWFaT0pUVGl1V1ZwUUVRNjI1SmJDNGVTWUw1TVc5?= =?utf-8?B?SGFQMGJLeG1JMDRSRTNhdm82SkdUZzY3REpHK0ZMUGwrdmxwSFhmWmZTNGJ6?= =?utf-8?B?RDhvUFlhdGx4cXd2RHF3d3F0cFQ4OFJocFdzQmM1RmxNaDQxbEtPWHlGK1NJ?= =?utf-8?B?SjFwMHNLU1BEa1ZYN3pYTm4wdmVKVStJR0E1TnEzNlJlRm9ZdEwyUVUvNitM?= =?utf-8?B?VlNqVE81SkFvZTJpcFFoRUpaNG1TYmx5NkQ1STliN2I2ajNsTU1oVUI1Nkww?= =?utf-8?B?OFJ0a2FnckxWVXB4NXN5MFcvSEtudzFoY0FvenBhcC9QOE1FazFHdGpuSVdN?= =?utf-8?B?Y3JEVjdVVGRGZXNrNThobFR0ZEQ1V2hHbUV2Yy83Z0FIQjdYZm5SM1FQMkZG?= =?utf-8?B?ZmNwNGl2SFlBTGRwcjVSc2VFTTV2N2YvbXZmRGxKS2tGaHlKdWV1YS9DSEsw?= =?utf-8?B?Q1lrOGVQalcwUGVzS0V3bDRLMjM1ZVcyTlFOT2FpSFZNUzBSem5yaVNMMFFq?= =?utf-8?B?QjVDZjZhcUQ2ZG1Ob0p1Z2dNN1o0TXdaS205Q1NwVmhJa29WVk5xK3dleS9l?= =?utf-8?B?RVNCWG5tYzNLbENYclBiaGZkZFd3N0FSK0pLbHUreXdCbFE1dmtOYzZ3ekFT?= =?utf-8?B?UWc2S1VpZ3JxMHNNRzhjT1UrRmZOTy8zUUJFb3ZvMmhRZVhmeFlsdXF3dlFP?= =?utf-8?B?WTFkNStuNGpRQUw1clJBcXhDZVhWeDZ5YU9yQVJITlZlMFc4dlRwNzlVeVhx?= =?utf-8?B?ZEtyQkttb2o0a0gyalZaK0dIUXpaODdGd2lQenpsV2lSbzBPVENoVkI4SGs5?= =?utf-8?B?ZnhFTzlURnRQWTduUG0xSTdRbEJLVCtvTGFsNVZua2VBWEI2amJ6dEthRTVn?= =?utf-8?B?NWxvdVdreHJsVjN3MkozSVplZlNlMWpOWk9DbllJSXRkTkV1NXNBYm5MS3Bv?= =?utf-8?B?Qytsc05uT1BqUVBJOVN2aWkrWXVKSkRsbEM1NDNaZk9ZMDlneVhxWmppUTl0?= =?utf-8?B?K1UvZkRBZ0NDSUpvekpmZ2NvbXNCQUo5M1dTS0JPWEd3WE5oTnVhSTlJdkw3?= =?utf-8?B?eUF5dkhFYWdkQllnQlNFdHZXMlRtYjVNNG9udm4rNk1YY0lGKytRRGQvb0Vu?= =?utf-8?B?ZndtUHVIdkt1Q0xWTHJWdGxwUWlZUWtKL0lvMm1Ia29aTC95NlNBbVV4TmlE?= =?utf-8?B?dE9scm5JWjRYYzFZcGZMMmxuS3NyVnhwdjIyNm5XbkNhN0poeWRvZFJXaE00?= =?utf-8?B?TlVsZzBTN2g1Skx5cG92WTY4Y05uUHdRa2E5djIwZ2cwbjNhREVJYzNmWGlm?= =?utf-8?B?L0xuWElHNGY5QkhvT0FPVUhuRXpONDdrNmhNYlRMZjJQa013U2xNNmVjYnVO?= =?utf-8?B?NXlKMUUzYWJBS2hTTHNTTmF2OFpnWDRxNkhyUXc3cnRnZVJqL0JmU3A0TmFR?= =?utf-8?B?S01PZ2tVVk1nMzFnelZsczM0M0Q3ZHNBd0xTbXhPZXIxZHVnNkttR1lXSW1T?= =?utf-8?B?NFhYd0V0eldhT3dvYXR6WDdVOUNPbmxmUGRVdVpSR2l1Q1dERUg5Wk1mcEJL?= =?utf-8?B?UHlTTUpxOVI2cGozNFExaENidi96KzZjc2xMTmg4Vmw5VjhnUDgvaHpYRzhP?= =?utf-8?B?cThxK2dpbnhJbkZpa2JZYUthK1JtUU5NelVIVSt4SjFGL2ltY0ZHR2MxNkMy?= =?utf-8?B?aTNOTktBckppWXVZZ1BUaTY0NXM0MnhlZTVuUkl4MmIxeXJ3VU85QVQ2anpO?= =?utf-8?B?aG40NERvd2JrMWZ1cHF4L0orSktqQ0cvUmt2c1l2NHNsNnNsREpyK0dpYnRz?= =?utf-8?B?Z2lzNDdNY2xCRVFIQlZ1V1dudFU4NkF2VkFoaWsvanMraTN0bVdOZ1JiQnFN?= =?utf-8?B?cmh6WG9kK2JoUElEQjFGaVo2M1Y2bU8wMy83bHhubVVsMDNMYU9wWVNSZUZF?= =?utf-8?B?SWxubCtIc0N3VmE3TS93cGVzMW9VVUJBT0pVRFhac0VNQjcwUWV3ckJaUmhB?= =?utf-8?Q?B76mF5kTZ7048QP6Vnw/oGmqf?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 65287fbd-5e2d-49b6-483a-08db4fb10db0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 10:43:26.1957 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PcdBNKK5KMSswbJt3ZLf8qUEcPDMrr5oUwxQAkK6zd9GZLyPij3FzveVd5SQSnV8DYq1lCGkOA71DllRamfJlg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8972 On 01.05.2023 21:30, Jason Andryuk wrote: > Print HWP-specific parameters. Some are always present, but others > depend on hardware support. > > Signed-off-by: Jason Andryuk > --- > v2: > Style fixes > Declare i outside loop > Replace repearted hardware/configured limits with spaces > Fixup for hw_ removal > Use XEN_HWP_GOVERNOR > Use HWP_ACT_WINDOW_EXPONENT_* > Remove energy_perf hw autonomous - 0 doesn't mean autonomous > --- > tools/misc/xenpm.c | 65 ++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 65 insertions(+) > > diff --git a/tools/misc/xenpm.c b/tools/misc/xenpm.c > index ce8d7644d0..b2defde0d4 100644 > --- a/tools/misc/xenpm.c > +++ b/tools/misc/xenpm.c > @@ -708,6 +708,44 @@ void start_gather_func(int argc, char *argv[]) > pause(); > } > > +static void calculate_hwp_activity_window(const xc_hwp_para_t *hwp, > + unsigned int *activity_window, > + const char **units) The function's return value would be nice to use for one of the two values that are being returned. > +{ > + unsigned int mantissa = hwp->activity_window & HWP_ACT_WINDOW_MANTISSA_MASK; > + unsigned int exponent = > + (hwp->activity_window >> HWP_ACT_WINDOW_EXPONENT_SHIFT) & > + HWP_ACT_WINDOW_EXPONENT_MASK; I wish we had MASK_EXTR() in common-macros.h. While really a comment on patch 7 - HWP_ACT_WINDOW_EXPONENT_SHIFT is redundant information and should imo be omitted from the public interface, in favor of just a (suitably shifted) mask value. Also note how those constants all lack proper XEN_ prefixes. > + unsigned int multiplier = 1; > + unsigned int i; > + > + if ( hwp->activity_window == 0 ) > + { > + *units = "hardware selected"; > + *activity_window = 0; > + > + return; > + } While in line with documentation, any mantissa of 0 results in a 0us window, which I assume would then also mean "hardware selected". > @@ -773,6 +811,33 @@ static void print_cpufreq_para(int cpuid, struct xc_get_cpufreq_para *p_cpufreq) > p_cpufreq->scaling_cur_freq); > } > > + if ( strcmp(p_cpufreq->scaling_governor, XEN_HWP_GOVERNOR) == 0 ) > + { > + const xc_hwp_para_t *hwp = &p_cpufreq->u.hwp_para; > + > + printf("hwp variables :\n"); > + printf(" hardware limits : lowest [%u] most_efficient [%u]\n", Here and ... > + hwp->lowest, hwp->most_efficient); > + printf(" : guaranteed [%u] highest [%u]\n", > + hwp->guaranteed, hwp->highest); > + printf(" configured limits : min [%u] max [%u] energy_perf [%u]\n", ... here I wonder what use the underscores are in produced output. I'd use blanks. If you really want a separator there, then please use dashes. Jan From xen-devel-bounces@lists.xenproject.org Mon May 08 10:47:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 10:47:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531370.826975 (Exim 4.92) (envelope-from ) id 1pvyOg-0004wI-Ga; Mon, 08 May 2023 10:47:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531370.826975; Mon, 08 May 2023 10:47:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvyOg-0004wB-DV; Mon, 08 May 2023 10:47:14 +0000 Received: by outflank-mailman (input) for mailman id 531370; Mon, 08 May 2023 10:47:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvyOf-0004w5-U2 for xen-devel@lists.xenproject.org; Mon, 08 May 2023 10:47:13 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2062b.outbound.protection.outlook.com [2a01:111:f400:7d00::62b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aff92e3e-ed8d-11ed-8611-37d641c3527e; Mon, 08 May 2023 12:47:12 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9688.eurprd04.prod.outlook.com (2603:10a6:102:271::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Mon, 8 May 2023 10:47:08 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c%4]) with mapi id 15.20.6363.031; Mon, 8 May 2023 10:47:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aff92e3e-ed8d-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mLIr+16dX+1jZG6XvZ6yCRWHYMvDnuDI9QrOyhWtgBN0G2thX8qdXVs8UHipgXAOzD01vhtn0lyOg0922CmobgnFKFj6/gkn0EIOA2M+2VoJnVpQ4IeW7lus7ewwfBczEC2+PyB4zPNLgInA3ilzAgK5TNEEJGbVYI2QJBTwzazJrLeqsDhLJmAg6kzFO2gzn7KkN6g+KqpcHQ1mqVG/FSgOXo1WXYOArZg6W1kw6gf49eob2Rf1chxkitYnFKbW3vD6Ph+r+NZpU3Z42b7x5CGb7qZ/YxQfX9UJFoVVumOqIzFL4i5PQoR0ghsTyfyJqYtKXyC6ZjZTkjarzuLExQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3Kbj56+TveSb8xyuNr5L5tBwkr4DcPGmlHwHBe74nP4=; b=cnOIc0qBpjpZIFPj6f662s+MUfLUHzpcK7jFVdQReAUfn5VSkP7vQe1TC2xRPbo4gUTNMhivfYMKDjsDvsybD2jTilRlY+ITdRFViIq9mzsIV4OROgML4IujaRaLC55VFv4Ot1FgX3VMyEf8Wmirk9ZsILFKE5Km8Q5KJEaVmZvhgaI5YoJpZQ/4Pr09QrXWolTtz5zoM/aoc0BNpaLiU27HzSLpRKALTrrsR9EvZsr1N4XZcG7I3LMB194zDltJnsBcSTb+GUoVJXNV3KMGnnCy/i6osyOAYCjeZd38GPiPoLO4089aFvZazA66uRjW2cRB+gMIpoMP0U8Kap0YRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Kbj56+TveSb8xyuNr5L5tBwkr4DcPGmlHwHBe74nP4=; b=t6C5y6x9uCega+2hV4KmSkVpCrs/QF/lMGPnd1Ch/9eOMreLU9K5fyAcMIKrkWSY+ErJ2hx5yNdz+DIa2afrHC7PJbofAtzLBOG3SWTX4yuWklEgmoHEF5mSuJrLCIxOo025pxGHzU7E3eNggjqrU1cKv3LSHu+w77cepE0d2i/nPc982AjxFZRV2MYOlgnhWpJ9zUn8raiAGyxRSeqgF9ykXbYyFzlvzNmSwNTIhOwkabBbmLdtNVrhRkAiWOjbNv2qbc5P74tPej27DoSy6IAK0D4g1/d4kziOTlvZ6c9RowGQmca/SSvD6EltdgfQhZQYeQJ+OZNdaWqCiEK/WQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9cf71407-6209-296a-489a-9732b1928246@suse.com> Date: Mon, 8 May 2023 12:46:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3 07/14 RESEND] cpufreq: Export HWP parameters to userspace Content-Language: en-US From: Jan Beulich To: Jason Andryuk Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20230501193034.88575-1-jandryuk@gmail.com> <20230501193034.88575-8-jandryuk@gmail.com> <7db38688-1233-bc16-03f3-7afdc3394054@suse.com> In-Reply-To: <7db38688-1233-bc16-03f3-7afdc3394054@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM3PR07CA0135.eurprd07.prod.outlook.com (2603:10a6:207:8::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9688:EE_ X-MS-Office365-Filtering-Correlation-Id: 7a9d2bfc-b34b-4ad5-8d05-08db4fb1924a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: F1iUrSBeA6vGRW32HBZvCze9jZbl9KXLddW9oVmtTlB2ozTGEJnqDHaOzrJ+OJu6eUZuh4Fm2oVeEUJnyp78KmkK9gK19JvCzaDSl8cWDny7WRXYsGT7snP3ZHr0so5sbzdBch4nAvgIzz71S5N6rCWjhEZpXUmW2oH/7QxLad79mI0dI0luLEA2ea5pXoXWddvJjeom9QUWY+9/78+LxYjVeHpIuF3oQB9AWo55F71Vdhba0/zi7GBc9FSkH3fwP4SYQ9xfXu8kE5o45XJTBxu9RgvPq1/o1J90mhi1k/2YFKOzlhtpsUXzuM8cFey6XbJIU4WJfmCg/0U5WeWDj8r6rL67YupUWQpKnVUZz+vmGWaLcAtCRR7Ep6W0PlW3FxqLj4bBi5/xqvKhkHGwph0Lea/ssZn1DpySnnohRfN633+g16dGhhxnSH2r1Khfo3cxBRYL7fpog2d5xn/GE5BsQmCBH3j33vY4n00izePnylfaelRDMa6k6/4RUQyLrjjsq9041L4nS066i5UzPLvw/41JWv/n2Fa7nrmavwDSYuaI/l2dI7Terv28FqgpLclFR6seaxDxiIMifzZJsDdABDS3G91f5EK2XcUDaMs9jQoxsy4t7etzvPFVylCPJpe5xi9YW1mg6NwzioKUTA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(136003)(366004)(346002)(376002)(396003)(451199021)(83380400001)(6486002)(478600001)(6666004)(54906003)(2616005)(6512007)(6506007)(26005)(186003)(53546011)(2906002)(38100700002)(36756003)(6916009)(66946007)(66476007)(4326008)(66556008)(41300700001)(8936002)(8676002)(31696002)(86362001)(5660300002)(316002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QTRMYjd6Z3llcTR2ZXRqRlJWL1FWMThOWm1PRm5vejJ3ZFdlRGthYzJmcTZO?= =?utf-8?B?Ty9zRGRWaytXN3VPNkVHalhLWjlobUhyMFY0bFhha2N5cTNZa2hYVTNVNDJU?= =?utf-8?B?NHdZYURCZHBncFhiamtudUhTREFpdGU2TFNZeStvSGhpS2NnSU82Sk9ybXgr?= =?utf-8?B?OEdsdEV2Nk9LcTluaG8xTGlBSkFqQ1V0OUZpYkZVbVBtcmkrMXVoRXhFQTlx?= =?utf-8?B?TkU2Z2RrdTVmUk5RUWRRUVI5OENQWXIzajlzUW9va211WjYwdUFvNEJoT0t0?= =?utf-8?B?MlFRUjRhUHBJakRnV1V1WWRValp5SHVjbEpoRVR6bFkrZTcxa3ZNRWZvb3Nt?= =?utf-8?B?MnRhMGJFMW1KR3ppa0J2QW9VUkl0OWNSTFpNSnJoWVpaOTdNWmpRUU1OWmpT?= =?utf-8?B?MWhycnFERWd2V0VuaVFCaGZpWm1PVVV5U00xVnBLU1NYWG42VG82VnFRLzZT?= =?utf-8?B?SkxNT1V3bThxclU0WnZ4M09SLzdKenFDcUZEQWJ2RllYcFB6VDJKblJ1Vy9p?= =?utf-8?B?SUV3ejdRVFNNUXQvV01FK3lBYjNiQzR2bTNxQzlkd1VtVXViRHZzQURaZDNL?= =?utf-8?B?S1ZNT3BlanVkTnpLUHJNR0JHdWhHRzJZZHJ0em16Y1hGdmpYc3lpUFIwMnpD?= =?utf-8?B?ODZTZHBBWG9QVVZvSENoN29Xdjk3cExXRnIrU1pmWWRVTTJSQndoWkMwR3FU?= =?utf-8?B?SG1Hb244cVJKOEMyeS9iYWw5Q3RwSnBaR3Q0bmlsUXRwS0ZJT3k0dmExam41?= =?utf-8?B?dVJXVXE4K0UzK2JXZUhSY0J6ejJ6TlhtbWZXcXlpbmZEV3puOWtMNXJ2bDJ5?= =?utf-8?B?bUp3TUpsV0orS1JrU3FvTllzSXVmb2Fld1hUT2hCU0hjRzFUeml4UEttR2VG?= =?utf-8?B?aDVDVENid2wzWlR0MVRrUjF4eTd3dHdhenFTWnlySSs5QXFGU001SjB4UkFN?= =?utf-8?B?M2ZEc0xVQ2Z0REdZdGRJc01DR2M1WGNoU3NoNGhha2x6eG42c2lDYlppSnhw?= =?utf-8?B?NWI3MXdMQ0dBZUJGSThXZ2ljdWZySlZKbzVIR1JCOXIzZFp0YXJqMksva3hD?= =?utf-8?B?UWd5bVorL2M5U3E3VjBvNDdDQWVYdTRHRGdEdkRIYVRBcGZaZXU3VWJLajRq?= =?utf-8?B?WGEzUG5lQ3BKK0xsUlRSa3N5V1JqSUh3ajR0TGREQWpRTHVmcG9Ea3JZZm5Q?= =?utf-8?B?TlVTOS80UWluVWpvVndNNVJqcWprY1F0WEF2a3B3bkNZSXQ4MDkyRjhlK2dE?= =?utf-8?B?VHZyRDBvK1AwZ2I2bmZvWktlUzlCOHcwS09RditnZzE5SXhBbnhDSjBLNlFM?= =?utf-8?B?T1pNOGtlZWFEYU1PTUNHeGs0OWlvQkFuZVZaQTRLeGJJN0RtU3BLd01McXpM?= =?utf-8?B?ektCdk9xRDN2Y2x0RWZQUXVPdFFNZllPUC9VbWY2clVsWllpSnlod0o1aWxD?= =?utf-8?B?cjRFUWVXSkp6K0RJUVB2UTBJYTV4N0IwWk91Mnd6RllLZ0puTmpJVWJmcFNZ?= =?utf-8?B?cWdmK0RZUC9mRUUxOHpoT2MyL0h1WGFWSzRxeFBKZmt5bWlzWXN4K2Nucm9u?= =?utf-8?B?NzBPOTVRNzAwWGtSNHFGU0UxR0Q5ZERseVRGdHlmaDJKdno1bG1uKzNWeWZu?= =?utf-8?B?TXFsSWJEN1lHYzJ4T0dteTc2THBsa2Y3bTVJQ3dBaFhvNnBSZGV2UU1qT3hs?= =?utf-8?B?ZkNuN0txWjJhSkZ3cDNzem5VZzVQdWhzWk8zTWR6T3A1L1JzN2dOMStDandL?= =?utf-8?B?YlhFUC8rOW43MjY5dWNkQkNUam1mSzlsMkNvYTNPOXRGNkFWUEgrT2FVdUk5?= =?utf-8?B?VjMvdHBYYWF2aHY1YkJGVi9pTEFsdU1jYWRRU3AyRUJOT2ZuMUJHOHdqQWkz?= =?utf-8?B?Rzd1TStBVis5VnBDK0tEYi9Tc2pDTjRrNW1QMzFkRENUcU5Ub0FaeDBqSWFJ?= =?utf-8?B?aWVLQ3hUSjNNTjVrL004Z1FUaFBkd2xuekdCZW03Q0VPbHUrMTNpVTJUWlk2?= =?utf-8?B?VVo2SkNDRW5OUGhvSlNMa2lFRnVtN0RlbDBhRDJSb3Q4L01lRlZaR0Q0b1lV?= =?utf-8?B?UzZtS0lTZ3hlYWZyajkrb20xRzFyTUlaZ1FWSFdHVHhwUU1VQVUwcDhyS1hJ?= =?utf-8?Q?AhASMWBdUUsvWNaC7QVN11CAb?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a9d2bfc-b34b-4ad5-8d05-08db4fb1924a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 10:47:08.6760 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FJ1m/iz1Ue1+VGlu/huyDtlF7ZvzQTS6l6q1mJrivHoTqYysK8O3cEuqtVlpsOMYiZ7YdrCQj/Z6kYlnHBbMNw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9688 On 08.05.2023 12:25, Jan Beulich wrote: > On 01.05.2023 21:30, Jason Andryuk wrote: >> Extend xen_get_cpufreq_para to return hwp parameters. These match the >> hardware rather closely. >> >> We need the features bitmask to indicated fields supported by the actual >> hardware. >> >> The use of uint8_t parameters matches the hardware size. uint32_t >> entries grows the sysctl_t past the build assertion in setup.c. The >> uint8_t ranges are supported across multiple generations, so hopefully >> they won't change. > > Still it feels a little odd for values to be this narrow. Aiui the > scaling_governor[] and scaling_{max,min}_freq fields aren't (really) > used by HWP. So you could widen the union in struct > xen_get_cpufreq_para (in a binary but not necessarily source compatible > manner), gaining you 6 more uint32_t slots. Possibly the somewhat oddly > placed scaling_cur_freq could be included as well ... Having seen patch 9 now as well, I wonder whether here (or in a separate patch) you don't want to limit providing inapplicable data (for example not filling *scaling_available_governors would even avoid an allocation, thus removing a possible reason for failure), while there (or again in a separate patch) you'd also limit what the tool reports (inapplicable output causes confusion / questions at best). Jan From xen-devel-bounces@lists.xenproject.org Mon May 08 11:23:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 11:23:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531383.826984 (Exim 4.92) (envelope-from ) id 1pvyxq-0000sm-37; Mon, 08 May 2023 11:23:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531383.826984; Mon, 08 May 2023 11:23:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvyxq-0000sf-08; Mon, 08 May 2023 11:23:34 +0000 Received: by outflank-mailman (input) for mailman id 531383; Mon, 08 May 2023 11:23:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvyxp-0000ru-81 for xen-devel@lists.xenproject.org; Mon, 08 May 2023 11:23:33 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c13d83fa-ed92-11ed-8611-37d641c3527e; Mon, 08 May 2023 13:23:31 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CE2151FE34; Mon, 8 May 2023 11:23:27 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 95B2F1346B; Mon, 8 May 2023 11:23:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id t5UXI6/bWGQ2KgAAMHmgww (envelope-from ); Mon, 08 May 2023 11:23:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c13d83fa-ed92-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683545007; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BvpHVm1k2zYQtgm6kSRpmTVy7RWuaY1Ad2jZD6vQ65s=; b=q/KpXFUXmdwfU74NLloJMeqsObhR6H7BQPN0IWdMYTvOgvoXaHhPhOSgjUOVns2NMVsU8Y CDksf+Jmr7Zg6n1KyMSYdnv8ClNXYcnEZ+lkx8kk5M2RIkGGAwnHJaj8tlx9JTKOarMUOE gXvgQW7Wgqjru2ox4r9Xb8mzPuJ/qEo= Message-ID: <324fd699-dcd8-9881-a276-167be38622b1@suse.com> Date: Mon, 8 May 2023 13:23:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v1] tools: convert bitfields to unsigned type Content-Language: en-US To: Olaf Hering Cc: xen-devel@lists.xenproject.org, Wei Liu , Anthony PERARD , George Dunlap References: <20230503150142.4987-1-olaf@aepfle.de> <20230508120038.74246111.olaf@aepfle.de> From: Juergen Gross In-Reply-To: <20230508120038.74246111.olaf@aepfle.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------GucqRMVKOv2enaXkTjBlexBR" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------GucqRMVKOv2enaXkTjBlexBR Content-Type: multipart/mixed; boundary="------------nttb7OYmMOnGDlecJH2qQa0o"; protected-headers="v1" From: Juergen Gross To: Olaf Hering Cc: xen-devel@lists.xenproject.org, Wei Liu , Anthony PERARD , George Dunlap Message-ID: <324fd699-dcd8-9881-a276-167be38622b1@suse.com> Subject: Re: [PATCH v1] tools: convert bitfields to unsigned type References: <20230503150142.4987-1-olaf@aepfle.de> <20230508120038.74246111.olaf@aepfle.de> In-Reply-To: <20230508120038.74246111.olaf@aepfle.de> --------------nttb7OYmMOnGDlecJH2qQa0o Content-Type: multipart/mixed; boundary="------------WkhGyOghj6QDnSnCZmAhIFRK" --------------WkhGyOghj6QDnSnCZmAhIFRK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDguMDUuMjMgMTI6MDAsIE9sYWYgSGVyaW5nIHdyb3RlOg0KPiBNb24sIDggTWF5IDIw MjMgMTE6MDY6MTEgKzAyMDAgSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPjoNCj4g DQo+Pj4gLSAgICBpbnQgc2hvcnRfc3VtbWFyeV9kb25lOjEsIHByZWFsbG9jX3VucGluOjEs IHdybWFwX2JmOjE7DQo+Pj4gKyAgICB1bnNpZ25lZCBzaG9ydF9zdW1tYXJ5X2RvbmU6MSwg cHJlYWxsb2NfdW5waW46MSwgd3JtYXBfYmY6MTsNCj4+IFBsZWFzZSB1c2UgInVuc2lnbmVk IGludCIgaW5zdGVhZCBvZiBhIHB1cmUgInVuc2lnbmVkIi4NCj4gDQo+IFRoZSBlbnRpcmUg ZmlsZSB1c2VzIGp1c3QgJ3Vuc2lnbmVkJyBmb3IgYml0ZmllbGRzLg0KDQpJIGhhdmUgZm91 bmQgMTggbGluZXMgdXNpbmcgInVuc2lnbmVkIGludCIgZm9yIGJpdGZpZWxkcyBpbiB0aGlz IGZpbGUuDQoNCg0KSnVlcmdlbg0K --------------WkhGyOghj6QDnSnCZmAhIFRK Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------WkhGyOghj6QDnSnCZmAhIFRK-- --------------nttb7OYmMOnGDlecJH2qQa0o-- --------------GucqRMVKOv2enaXkTjBlexBR Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmRY268FAwAAAAAACgkQsN6d1ii/Ey+3 Mgf/WAyWGxiLFA687yBCTRCN6wg5/pHH+F1oRL2M9yJpgar9Bd+l47X6Afkkcat+bZz8NejrLqLF twC27U34pP+U54+zL+pQZBArpvmjRY1rZWK1A/C2IaOEt4TRjzR1TyuNxWropLBNLabmbulvP6Su WAu5aD/Nax1WLIvq93sgiIqN7sUoV3hhhNWqxw+IrBvywCL29HOouCUaDMcraVChacaA2TR8+Pvr L2N8fdmLu14jrW6bq6TBf30Vo9UHChVAe4Kd1Xbesgoz2hnE3KvIg6attO97XG+RzAbQnciKjoIr vwUG1FSIR+WQGuJj3m9Pu/a386NMOYvf+XvQGIkExg== =4z1t -----END PGP SIGNATURE----- --------------GucqRMVKOv2enaXkTjBlexBR-- From xen-devel-bounces@lists.xenproject.org Mon May 08 11:28:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 11:28:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531387.826996 (Exim 4.92) (envelope-from ) id 1pvz2V-0001VS-Oj; Mon, 08 May 2023 11:28:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531387.826996; Mon, 08 May 2023 11:28:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvz2V-0001VL-JH; Mon, 08 May 2023 11:28:23 +0000 Received: by outflank-mailman (input) for mailman id 531387; Mon, 08 May 2023 11:28:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvz2U-0001VF-4m for xen-devel@lists.xenproject.org; Mon, 08 May 2023 11:28:22 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2075.outbound.protection.outlook.com [40.107.7.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6f950244-ed93-11ed-b226-6b7b168915f2; Mon, 08 May 2023 13:28:20 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by GV1PR04MB9150.eurprd04.prod.outlook.com (2603:10a6:150:25::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Mon, 8 May 2023 11:27:51 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c%4]) with mapi id 15.20.6363.031; Mon, 8 May 2023 11:27:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f950244-ed93-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gFMRv3ym8Pc7NjnPfWcAfPcTdv+0wLCL0JJ5GDZQt4PgaVKv18kMcnlFacH2Ha0IYzd80U2PtXjCVi9Okl86qWPwasev3dKr+B1bi8jEirG2OUmu3M2XjpWEloruoKQqC+kd16gODEZbBixHLjRgPHD0LxBwZHUxUxgTgk7ziQRuk11Hexec8m0W1l2sN9I2UU6dYlJerpQ2vn3i4h2qx+vgVl86C3W0uW3crvJ3Tld7qQfS3q2yJSK/ggHyAdGVh4kuW/qkuw8RasO1mGuDMAyCvElDnaSs+76FlK9Oz6+vIA7kZgzNxLiyaIM4CDCcTlBRZtIYYB15a9+p89awcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hNwRBae2FyJhvSroKSc0n+S74kYsmrTh60e1kp0Gh28=; b=g2HVoY4jUHBpeBRRhsqCYL4RQB3i4Z8q/wjH8KoqjSCQi5KQNc5oEfx+wdCbz10xs7fI/uQnvCEr1jonVKQTd5oQJf0dxdpTM4zE53Qb2O7fcWMgV6UBqsjcUbI9YKsYIoBSzZTHPNpmlcwA6JSXqgjdDnnvFNHR9tKkcHqFoXbYYbJJlmX6/bzBumPSeJCKC875E4ZFOQ7pSzR9d/CKIDGsJ0ZaBDPAksCAldF6z5yOssljg6OhU3WBs7ZbUjlJDJax/EMiweRCD4CJXSzFzAQnLS8OrVX39bq9YdTOyOf28jkuO1UU6p5DKcgkQ3izT5o8VX+oKi92RCxGeUnIEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hNwRBae2FyJhvSroKSc0n+S74kYsmrTh60e1kp0Gh28=; b=W8eAfH3bsbmQt8TQ9V6OpjSlYGjNLljX59/YCzPGhCWJwP4BXecqMN1UoVGKU+dGutHOa6X3LTJOylKxQjo1XD0CjVW1klWC5gEQQycd1+PCF9l/AJ5b/UAI1Dm7gyNjflf0r2kKjxGc9f2rpaiRVvZm40WKy1IMxyy/l3rw9PaAWKM8KCFfR+/XKuY9rm6lDqP0SeM3MWOX0d7n7qU2XHq8LunuTjGE8xSQu4YcllWTUy+5HrKbvWUMh6hsk8vY7Xn9nXhHD8QXgb7i/gTzxQpx6GWl5c+4dulxM586+KxHf+DHLywku6JU/jQBpDqsMw7HV35APdlnCXXS6Ldobg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1166bdf1-4d54-30bb-bdf9-65dfaeb6b29e@suse.com> Date: Mon, 8 May 2023 13:27:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3 10/14 RESEND] xen: Add SET_CPUFREQ_HWP xen_sysctl_pm_op Content-Language: en-US To: Jason Andryuk Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20230501193034.88575-1-jandryuk@gmail.com> <20230501193034.88575-11-jandryuk@gmail.com> From: Jan Beulich In-Reply-To: <20230501193034.88575-11-jandryuk@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR10CA0116.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:e6::33) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|GV1PR04MB9150:EE_ X-MS-Office365-Filtering-Correlation-Id: d35bf528-654c-4010-551e-08db4fb7423f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pqtKeKQUCsgLA1AyQW+7VySHBmSpMaKgbsyjqfohuN5LqyvzSiSDygmWGP1dDDyciXWXeXA4fWam4XK8UhFdx1sg6H/XyfqBmq3zJAOL4MpHx+xZy1Kn/702zoDKpv6CVYzbTXPrk3q6Ut4z4DMa7PtdJQF6koG/hbPGyU2dC0teu6JoKHTf6UU9Un1SqFLHpdTyeHJAQtLqPBSElUl/e634p/yntXYIc64GpzJxc54bT2BTByeYf9dAHsJZOL2amp44AZHz1gGZu9zIQX14usIabjeyipkcIwrtG2rSaDJMfNyPILwUtVJ6kjDKPSIWX7JFDFtUko5fYCTRaXr6HykCxNiwXM91abJO/sDc/hF/GMfoQ1I90OgW+bvfk8bLuOuF6I/fP+6FaTSejnzUcgW/dY75gDt05JPNMZZ0ZJXGDSKtaN44+eZvp7SRa5YhDh4sDmA4xG0bOtCjp9Jph6/UBfdSMDn9x6Bapq2ZMdBJUtdIcaHOelz49fW9+XmaRk2DyOmuHAvcXD1EGqs++iK9MIMXIKmcDoeB2K0W/NW0x+7N5dmU+LnWu08qV8WQLgV3WDrwHfVU7P92JOFE6G4iVoqRr5oZxgdmE/nTQ2qJSllLbdK0WVNVunylAQVNeIHTdvFePgerBj7u6vzb4w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(366004)(396003)(376002)(346002)(136003)(451199021)(6512007)(53546011)(26005)(6506007)(6486002)(83380400001)(36756003)(2616005)(38100700002)(86362001)(31696002)(186003)(41300700001)(2906002)(54906003)(31686004)(5660300002)(6916009)(4326008)(66476007)(66556008)(316002)(8936002)(8676002)(478600001)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dHNuQzFoYWFqZVplNk96a05reWI3NHhuZk9JRU83em53cklWUjFRbk9tb1Ax?= =?utf-8?B?UzdTRkJsSTJxeVZKT1VaOXNGemZoWVpvb2pxVUxrTlNYREZoZHBUbEErbWVs?= =?utf-8?B?alJkSU1heXZrTXExdEZuWGg2czhIRm45Y3VoaDl3Rys2WlNraEpDeEpSQ0x0?= =?utf-8?B?Kys3MlFlRWNlSnFnS1llcHo0ei9Za1g1cnlocmU4bkZvMHVSY1NEOTdkV2tB?= =?utf-8?B?U1NLZHB1cWlvbDJoenVJelRBdkJUVEIvUnFWbklnVC90QWlQZHltbnJ2Mmll?= =?utf-8?B?d3NqUVlWODlKWGVudzJ0V1B6dW9KUWgzMW1QWDA0QlJrenh5ZlVDSzdLcGNB?= =?utf-8?B?akM0R3pxRUpoelRicDBENnM5eDVjaE5Ga3QvRTU5M0lPOStUb21FTmRITng5?= =?utf-8?B?TEhiMC9DMlNueXlHQmNvMzBtRG9vRjVqTjgwKzJmVjZXQU5oL2kwQmU5Mi9o?= =?utf-8?B?OTNSekNrdTY0T1RJL3dPTHhyeUUxWmd4N3ZKZTd3R3Y1OWRzUTloajkxaGxs?= =?utf-8?B?SU5uZ3QvYTg4NnVNMmJBdmVGYlNXRDRiRU5zN21HZDVWeS82SnNsNFFldUN3?= =?utf-8?B?ZFMyWm4xbC84MVNLcDllVUhuOUVaT1U4a1cxVDF3eWxzVzRlNDNERlpiS3hs?= =?utf-8?B?TmRnTmN4QUJ6ZldQZnB0UnFWb2dLWjF5SEIwNDFmcHhJZHhHcHdrUHZsMlVq?= =?utf-8?B?eW9Sd2h6dnR1L0ZydmhnN2NWS2JLT2M4cVF3djFtVXJJUVVVRGZoSVpnTFc4?= =?utf-8?B?aGUrSkN6ZUNvbkZpa1lSSU52V2tSbk9uSnFPRk5hZkVLM2k0dlJJb2I5Q2NV?= =?utf-8?B?aDhBMlZRdWR1OGhXNHpuRGZaOFVGSUxKV3FNVllsUXlyN2lXeEJkbmxFaDVk?= =?utf-8?B?WUhZZGRWZTJlNVdLZ05Ta0ExSWtRbHhrRmJENVJMNEhyTUtPTjg2aXBlTXdu?= =?utf-8?B?UFo2ekRCVVNLTXNxODcwWE4zNkhzQm5zVysyeFUyeU1lWlZzQjl6MWxIcm1G?= =?utf-8?B?Q0tQcWJQK0VHUEpaaWU2OU9lVkdSYUhMcEkzQVE1dGFDYnRreE1hUzF2Z3By?= =?utf-8?B?M2ViWngvUElTZmYxdExJc1MwOU9ldm5PS1VtQXV5YVI3MjBJSEIvS1FjVXVI?= =?utf-8?B?ZllKQS8xd3BYNkxLQlM4bC9CRFhpKzdjY25DMGMvRU9PMXpPL3pWQmcremJi?= =?utf-8?B?OWV5TktMQk5tdzVuSFBxT0xQTDA0ZXF2Tm1oaVNrSWdyZmlsa0FvejJNdWlx?= =?utf-8?B?MnVDNytSak5ZUFZGSEZmMUpSYlMwTWk2ekV1RVBhVVBXemtKaGlZdG41Q2pY?= =?utf-8?B?YVlIZDkrUW5JN2NibFNvazBzVTRSZ0xsQy9VTGRqV1NWeVIxS3NzYmUvMHZj?= =?utf-8?B?SU1BeHUvWUFHNzFCRUpMZjZ3VmhtSXZ3NGlmenVwZXZHMXZHSmthWDJvTEJH?= =?utf-8?B?NXhjNEdjRGFnYTdMd1RaMHVuZkY5MGFzek5IVDFhcTdvWGFsTlhVNnkyc25x?= =?utf-8?B?UmxwbVdYU3Q1RWxkbHF6aEhKZTBmcUprRVVCQzFrNk53bWFVbzAxdC83N1c0?= =?utf-8?B?aDBLbXI3TDc4RitYb0E4aFFTME1rNXJpZlJ4REIyQnUyNzc5eXZUUUl1Y2FO?= =?utf-8?B?SDBFVDQyRU9EbjB2SWViejBvQWpqRlFzZDg4dmF4RGNrZWNoVUdSNXZvSDM3?= =?utf-8?B?aE9iZHNnQlJqUmk0cnNZOFN3QlZNamlEVmVBUzR1R2N4aCs0aWltKzUyRXRk?= =?utf-8?B?djMvVklxb3lBUE5TWDhmL21uTjJRM05yTVNKQ25OS0FjMlFVTWVQQVBIbnNn?= =?utf-8?B?QWJYQWpiZ1hoQjVzVFJvU0pPMXZxWlVHb2FVQ0dtWjdjbTZCalJCRU1aeExD?= =?utf-8?B?R05BREg0STA1dW5idm5VRnMrS3hLSXA2Z29iVW96ZGpUUVFCSkl3WkdEWVNQ?= =?utf-8?B?SUVXR3FGaHVKY2tmQk1QMVh5eG5aVnQzZzdmcEhrelY1ZzRKbFVpS2JJSWNF?= =?utf-8?B?aWlhY1NJbTlZZGNtWi9YMTZhOHVQcmIyQzVXQmJSSDJ5dE1PMWdnREpWWEZ1?= =?utf-8?B?V3ZiNFdQQmdIYzFBRXVjSU8yYkJIeEJoK1JDT095bVovcTN6bkd4RkRIYkQw?= =?utf-8?Q?Ai3f4sTJQPRCPQQYjeWK3TxcC?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d35bf528-654c-4010-551e-08db4fb7423f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 11:27:51.3751 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WXA2Y6g1vU9EaC19HnlF/hafsPB1Yq4wFzZtViPvydwTGAo7yayMxVN89bQRiYQjH2LnYBL7xR7Pu/T9gXMYWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9150 On 01.05.2023 21:30, Jason Andryuk wrote: > @@ -531,6 +533,100 @@ int get_hwp_para(const struct cpufreq_policy *policy, > return 0; > } > > +int set_hwp_para(struct cpufreq_policy *policy, > + struct xen_set_hwp_para *set_hwp) const? > +{ > + unsigned int cpu = policy->cpu; > + struct hwp_drv_data *data = per_cpu(hwp_drv_data, cpu); > + > + if ( data == NULL ) > + return -EINVAL; > + > + /* Validate all parameters first */ > + if ( set_hwp->set_params & ~XEN_SYSCTL_HWP_SET_PARAM_MASK ) > + return -EINVAL; > + > + if ( set_hwp->activity_window & ~XEN_SYSCTL_HWP_ACT_WINDOW_MASK ) > + return -EINVAL; Below you limit checks to when the respective control bit is set. I think you want the same here. > + if ( !feature_hwp_energy_perf && > + (set_hwp->set_params & XEN_SYSCTL_HWP_SET_ENERGY_PERF) && > + set_hwp->energy_perf > IA32_ENERGY_BIAS_MAX_POWERSAVE ) > + return -EINVAL; > + > + if ( (set_hwp->set_params & XEN_SYSCTL_HWP_SET_DESIRED) && > + set_hwp->desired != 0 && > + (set_hwp->desired < data->hw.lowest || > + set_hwp->desired > data->hw.highest) ) > + return -EINVAL; > + > + /* > + * minimum & maximum are not validated as hardware doesn't seem to care > + * and the SDM says CPUs will clip internally. > + */ > + > + /* Apply presets */ > + switch ( set_hwp->set_params & XEN_SYSCTL_HWP_SET_PRESET_MASK ) > + { > + case XEN_SYSCTL_HWP_SET_PRESET_POWERSAVE: > + data->minimum = data->hw.lowest; > + data->maximum = data->hw.lowest; > + data->activity_window = 0; > + if ( feature_hwp_energy_perf ) > + data->energy_perf = HWP_ENERGY_PERF_MAX_POWERSAVE; > + else > + data->energy_perf = IA32_ENERGY_BIAS_MAX_POWERSAVE; > + data->desired = 0; > + break; > + > + case XEN_SYSCTL_HWP_SET_PRESET_PERFORMANCE: > + data->minimum = data->hw.highest; > + data->maximum = data->hw.highest; > + data->activity_window = 0; > + data->energy_perf = HWP_ENERGY_PERF_MAX_PERFORMANCE; > + data->desired = 0; > + break; > + > + case XEN_SYSCTL_HWP_SET_PRESET_BALANCE: > + data->minimum = data->hw.lowest; > + data->maximum = data->hw.highest; > + data->activity_window = 0; > + if ( feature_hwp_energy_perf ) > + data->energy_perf = HWP_ENERGY_PERF_BALANCE; > + else > + data->energy_perf = IA32_ENERGY_BIAS_BALANCE; > + data->desired = 0; > + break; > + > + case XEN_SYSCTL_HWP_SET_PRESET_NONE: > + break; > + > + default: > + return -EINVAL; > + } So presets set all the values for which the individual item control bits are clear. That's not exactly what I would have expected, and it took me reading the code several times until I realized that you write life per- CPU data fields here, not fields of some intermediate variable. I think this could do with saying explicitly in the public header (if indeed the intended model). > + /* Further customize presets if needed */ > + if ( set_hwp->set_params & XEN_SYSCTL_HWP_SET_MINIMUM ) > + data->minimum = set_hwp->minimum; > + > + if ( set_hwp->set_params & XEN_SYSCTL_HWP_SET_MAXIMUM ) > + data->maximum = set_hwp->maximum; > + > + if ( set_hwp->set_params & XEN_SYSCTL_HWP_SET_ENERGY_PERF ) > + data->energy_perf = set_hwp->energy_perf; > + > + if ( set_hwp->set_params & XEN_SYSCTL_HWP_SET_DESIRED ) > + data->desired = set_hwp->desired; > + > + if ( set_hwp->set_params & XEN_SYSCTL_HWP_SET_ACT_WINDOW ) > + data->activity_window = set_hwp->activity_window & > + XEN_SYSCTL_HWP_ACT_WINDOW_MASK; > + > + hwp_cpufreq_target(policy, 0, 0); > + > + return 0; I don't think you should assume here that hwp_cpufreq_target() will only ever return 0. Plus by returning its return value here you allow the compiler to tail-call optimize this code. > --- a/xen/drivers/acpi/pmstat.c > +++ b/xen/drivers/acpi/pmstat.c > @@ -398,6 +398,20 @@ static int set_cpufreq_para(struct xen_sysctl_pm_op *op) > return ret; > } > > +static int set_cpufreq_hwp(struct xen_sysctl_pm_op *op) const? > --- a/xen/include/public/sysctl.h > +++ b/xen/include/public/sysctl.h > @@ -317,6 +317,34 @@ struct xen_hwp_para { > uint8_t energy_perf; > }; > > +/* set multiple values simultaneously when set_args bit is set */ What "set_args bit" does this comment refer to? > +struct xen_set_hwp_para { > +#define XEN_SYSCTL_HWP_SET_DESIRED (1U << 0) > +#define XEN_SYSCTL_HWP_SET_ENERGY_PERF (1U << 1) > +#define XEN_SYSCTL_HWP_SET_ACT_WINDOW (1U << 2) > +#define XEN_SYSCTL_HWP_SET_MINIMUM (1U << 3) > +#define XEN_SYSCTL_HWP_SET_MAXIMUM (1U << 4) > +#define XEN_SYSCTL_HWP_SET_PRESET_MASK 0xf000 > +#define XEN_SYSCTL_HWP_SET_PRESET_NONE 0x0000 > +#define XEN_SYSCTL_HWP_SET_PRESET_BALANCE 0x1000 > +#define XEN_SYSCTL_HWP_SET_PRESET_POWERSAVE 0x2000 > +#define XEN_SYSCTL_HWP_SET_PRESET_PERFORMANCE 0x3000 > +#define XEN_SYSCTL_HWP_SET_PARAM_MASK ( \ > + XEN_SYSCTL_HWP_SET_PRESET_MASK | \ > + XEN_SYSCTL_HWP_SET_DESIRED | \ > + XEN_SYSCTL_HWP_SET_ENERGY_PERF | \ > + XEN_SYSCTL_HWP_SET_ACT_WINDOW | \ > + XEN_SYSCTL_HWP_SET_MINIMUM | \ > + XEN_SYSCTL_HWP_SET_MAXIMUM ) > + uint16_t set_params; /* bitflags for valid values */ > +#define XEN_SYSCTL_HWP_ACT_WINDOW_MASK 0x03ff > + uint16_t activity_window; /* See comment in struct xen_hwp_para */ > + uint8_t minimum; > + uint8_t maximum; > + uint8_t desired; > + uint8_t energy_perf; /* 0-255 or 0-15 depending on HW support */ Instead of (or in addition to) the "HW support" reference, could this gain a reference to the "get para" bit determining which range to use? Jan From xen-devel-bounces@lists.xenproject.org Mon May 08 11:48:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 11:48:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531395.827004 (Exim 4.92) (envelope-from ) id 1pvzLV-00040T-Ds; Mon, 08 May 2023 11:48:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531395.827004; Mon, 08 May 2023 11:48:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzLV-00040M-BJ; Mon, 08 May 2023 11:48:01 +0000 Received: by outflank-mailman (input) for mailman id 531395; Mon, 08 May 2023 11:48:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzLU-00040G-JD for xen-devel@lists.xenproject.org; Mon, 08 May 2023 11:48:00 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2cae1b69-ed96-11ed-8611-37d641c3527e; Mon, 08 May 2023 13:47:57 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 85DCD1FE44; Mon, 8 May 2023 11:47:56 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 44BD51346B; Mon, 8 May 2023 11:47:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id j+RjD2zhWGTiNgAAMHmgww (envelope-from ); Mon, 08 May 2023 11:47:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2cae1b69-ed96-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683546476; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=sHByFjc6g+J1m3gjwq+ynzSH/6Ec1w8cHibOV3GDZ7A=; b=m97MgFUcOtTsPRfofXMMa2qlEy+GUybkjWqkCG890oJyLhdegdYK5NAWAEXhLtnAROsnks 8Yp/3Bm8jGSgiLAlkOHBJWFgr25Rm3F359+baZmzDS4eQjsBVKMoVJG1Gf4zcIVrFOU8D5 3KnV3NcOsKwxalk53/rmFLIotEADQ7I= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini Subject: [PATCH v5 00/14] tools/xenstore: rework internal accounting Date: Mon, 8 May 2023 13:47:40 +0200 Message-Id: <20230508114754.31514-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series reworks the Xenstore internal accounting to use a uniform generic framework. It is adding some additional useful diagnostic information, like accounting trace and max. per-domain and global quota values seen. Changes in V2: - added patch 1 (leftover from previous series) - rebase Changes in V3: - addressed comments Changes in V4: - fixed patch 3 Changes in V5: - addressed comments Juergen Gross (14): tools/xenstore: take transaction internal nodes into account for quota tools/xenstore: manage per-transaction domain accounting data in an array tools/xenstore: introduce accounting data array for per-domain values tools/xenstore: add framework to commit accounting data on success only tools/xenstore: use accounting buffering for node accounting tools/xenstore: add current connection to domain_memory_add() parameters tools/xenstore: use accounting data array for per-domain values tools/xenstore: add accounting trace support tools/xenstore: add TDB access trace support tools/xenstore: switch transaction accounting to generic accounting tools/xenstore: remember global and per domain max accounting values tools/xenstore: use generic accounting for remaining quotas tools/xenstore: switch get_optval_int() to get_optval_uint() tools/xenstore: switch quota management to be table based docs/misc/xenstore.txt | 5 +- tools/xenstore/xenstored_control.c | 65 ++-- tools/xenstore/xenstored_core.c | 176 +++++----- tools/xenstore/xenstored_core.h | 24 +- tools/xenstore/xenstored_domain.c | 432 ++++++++++++++++++------- tools/xenstore/xenstored_domain.h | 59 +++- tools/xenstore/xenstored_transaction.c | 24 +- tools/xenstore/xenstored_watch.c | 15 +- 8 files changed, 521 insertions(+), 279 deletions(-) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon May 08 11:48:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 11:48:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531396.827015 (Exim 4.92) (envelope-from ) id 1pvzLY-0004Fc-LD; Mon, 08 May 2023 11:48:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531396.827015; Mon, 08 May 2023 11:48:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzLY-0004FV-Hs; Mon, 08 May 2023 11:48:04 +0000 Received: by outflank-mailman (input) for mailman id 531396; Mon, 08 May 2023 11:48:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzLX-0004FA-FD for xen-devel@lists.xenproject.org; Mon, 08 May 2023 11:48:03 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2fe7edf1-ed96-11ed-b226-6b7b168915f2; Mon, 08 May 2023 13:48:02 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2EBB71FE44; Mon, 8 May 2023 11:48:02 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E3D831346B; Mon, 8 May 2023 11:48:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id gPc8NnHhWGTqNgAAMHmgww (envelope-from ); Mon, 08 May 2023 11:48:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2fe7edf1-ed96-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683546482; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jR2CaVJDZ2qBizxTmbgLfYMIkR5bcQwiTfYf2yndaVw=; b=pehhPTg8kefxiDW5MIBGt/y393LQvpAZR7F5d+4PVz12T+VQQKbZhkX/8Zf6pwY/ODnIWD dRDm7rhx+bTK8yU34cxJRGR9B2ZM/f0oEDOZrKQiGwdO9HZ5QCzb6f3nVENVjAfkPxyIdx 8wqG/A7vfacW6kIo/sGGdPwxTrU4Gm0= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD , Julien Grall Subject: [PATCH v5 01/14] tools/xenstore: take transaction internal nodes into account for quota Date: Mon, 8 May 2023 13:47:41 +0200 Message-Id: <20230508114754.31514-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230508114754.31514-1-jgross@suse.com> References: <20230508114754.31514-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The accounting for the number of nodes of a domain in an active transaction is not working correctly, as it is checking the node quota only against the number of nodes outside the transaction. This can result in the transaction finally failing, as node quota is checked at the end of the transaction again. On the other hand even in a transaction deleting many nodes, new nodes might not be creatable, in case the node quota was already reached at the start of the transaction. Signed-off-by: Juergen Gross Acked-by: Julien Grall --- V3: - rewrite of commit message (Julien Grall) --- tools/xenstore/xenstored_domain.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index f62be2245c..dbbf97accc 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -1116,9 +1116,8 @@ int domain_nbentry_fix(unsigned int domid, int num, bool update) int domain_nbentry(struct connection *conn) { - return (domain_is_unprivileged(conn)) - ? conn->domain->nbentry - : 0; + return domain_is_unprivileged(conn) + ? domain_nbentry_add(conn, conn->id, 0, true) : 0; } static bool domain_chk_quota(struct domain *domain, int mem) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon May 08 11:48:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 11:48:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531397.827024 (Exim 4.92) (envelope-from ) id 1pvzLd-0004YE-TJ; Mon, 08 May 2023 11:48:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531397.827024; Mon, 08 May 2023 11:48:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzLd-0004Y2-QG; Mon, 08 May 2023 11:48:09 +0000 Received: by outflank-mailman (input) for mailman id 531397; Mon, 08 May 2023 11:48:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzLc-0004FA-Fh for xen-devel@lists.xenproject.org; Mon, 08 May 2023 11:48:08 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3336086b-ed96-11ed-b226-6b7b168915f2; Mon, 08 May 2023 13:48:08 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B137E21D1E; Mon, 8 May 2023 11:48:07 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 80C6A1346B; Mon, 8 May 2023 11:48:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id udAbHnfhWGT4NgAAMHmgww (envelope-from ); Mon, 08 May 2023 11:48:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3336086b-ed96-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683546487; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JlFoqnoU3I4JMyJapnFZtevlraEzWmolnTL1zQ4kqcs=; b=RbdltfRyJoMH9SRYvb9HQ+Lr0cZYfBo7WeUPq/xQonJDXSPa46co4U2wQOba4Lj1D+s+8H 7p52xBfu6pJ6f8abdDiTOXDvO0gGqO4hUFTPKalIWlgHIVnJLWPbOU76kmvf7hadmUq9l6 vWXXakXfqn3AZktYeWTRDZelTD14qcg= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD , Julien Grall Subject: [PATCH v5 02/14] tools/xenstore: manage per-transaction domain accounting data in an array Date: Mon, 8 May 2023 13:47:42 +0200 Message-Id: <20230508114754.31514-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230508114754.31514-1-jgross@suse.com> References: <20230508114754.31514-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In order to prepare keeping accounting data in an array instead of using independent fields, switch the struct changed_domain accounting data to that scheme, for now only using an array with one element. In order to be able to extend this scheme add the needed indexing enum to xenstored_domain.h. Signed-off-by: Juergen Gross Reviewed-by: Julien Grall --- V2: - make "what" parameter of acc_add_changed_dom() an enum type, and assert() that it won't exceed the accounting array (Julien Grall) --- tools/xenstore/xenstored_domain.c | 19 +++++++++++-------- tools/xenstore/xenstored_domain.h | 10 ++++++++++ 2 files changed, 21 insertions(+), 8 deletions(-) diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index dbbf97accc..609a9a13ab 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -99,8 +99,8 @@ struct changed_domain /* Identifier of the changed domain. */ unsigned int domid; - /* Amount by which this domain's nbentry field has changed. */ - int nbentry; + /* Accounting data. */ + int acc[ACC_TR_N]; }; static struct hashtable *domhash; @@ -550,7 +550,7 @@ int acc_fix_domains(struct list_head *head, bool chk_quota, bool update) int cnt; list_for_each_entry(cd, head, list) { - cnt = domain_nbentry_fix(cd->domid, cd->nbentry, update); + cnt = domain_nbentry_fix(cd->domid, cd->acc[ACC_NODES], update); if (!update) { if (chk_quota && cnt >= quota_nb_entry_per_domain) return ENOSPC; @@ -595,19 +595,21 @@ static struct changed_domain *acc_get_changed_domain(const void *ctx, return cd; } -static int acc_add_dom_nbentry(const void *ctx, struct list_head *head, int val, - unsigned int domid) +static int acc_add_changed_dom(const void *ctx, struct list_head *head, + enum accitem what, int val, unsigned int domid) { struct changed_domain *cd; + assert(what < ARRAY_SIZE(cd->acc)); + cd = acc_get_changed_domain(ctx, head, domid); if (!cd) return 0; errno = 0; - cd->nbentry += val; + cd->acc[what] += val; - return cd->nbentry; + return cd->acc[what]; } static void domain_conn_reset(struct domain *domain) @@ -1071,7 +1073,8 @@ static int domain_nbentry_add(struct connection *conn, unsigned int domid, if (conn && conn->transaction) { head = transaction_get_changed_domains(conn->transaction); - ret = acc_add_dom_nbentry(conn->transaction, head, add, domid); + ret = acc_add_changed_dom(conn->transaction, head, ACC_NODES, + add, domid); if (errno) { fail_transaction(conn->transaction); return -1; diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index 279cccb3ad..40803574f6 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -19,6 +19,16 @@ #ifndef _XENSTORED_DOMAIN_H #define _XENSTORED_DOMAIN_H +/* + * All accounting data is stored in a per-domain array. + * Depending on the account item there might be other scopes as well, like e.g. + * a per transaction array. + */ +enum accitem { + ACC_NODES, + ACC_TR_N, /* Number of elements per transaction. */ +}; + void handle_event(void); void check_domains(void); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon May 08 11:48:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 11:48:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531398.827034 (Exim 4.92) (envelope-from ) id 1pvzLl-0004xT-5M; Mon, 08 May 2023 11:48:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531398.827034; Mon, 08 May 2023 11:48:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzLl-0004xJ-2R; Mon, 08 May 2023 11:48:17 +0000 Received: by outflank-mailman (input) for mailman id 531398; Mon, 08 May 2023 11:48:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzLj-00040G-RD for xen-devel@lists.xenproject.org; Mon, 08 May 2023 11:48:15 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 36938dd8-ed96-11ed-8611-37d641c3527e; Mon, 08 May 2023 13:48:13 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6599B21D1E; Mon, 8 May 2023 11:48:13 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 368661346B; Mon, 8 May 2023 11:48:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9+IeDH3hWGQFNwAAMHmgww (envelope-from ); Mon, 08 May 2023 11:48:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 36938dd8-ed96-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683546493; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=no4Yd3rxrRD6C77O0adarS1Qkx7TupRDK427VBM6jfA=; b=eDYC3tqJ3vpCroHTALl4hX9lBQna379LF6BgYbfXwgWCCBtwnXuvWdp9kJcSd1PxQvMEhe RY4S+j8sa0jJARI7LtuwOx3pvAVKAv4/nT8wDEmvvXCsy0GHozb5ow5OI81YgIXaDF8E3z jGxuqGUYoN/mHFl0yfEn99p74m+7wT0= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD , Julien Grall Subject: [PATCH v5 03/14] tools/xenstore: introduce accounting data array for per-domain values Date: Mon, 8 May 2023 13:47:43 +0200 Message-Id: <20230508114754.31514-4-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230508114754.31514-1-jgross@suse.com> References: <20230508114754.31514-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Introduce the scheme of an accounting data array for per-domain accounting data and use it initially for the number of nodes owned by a domain. Make the accounting data type to be unsigned int, as no data is allowed to be negative at any time. Signed-off-by: Juergen Gross Reviewed-by: Julien Grall --- V3: - remove domid parameter from domain_acc_add_chk() (Julien Grall) - rename domain_acc_add_chk() (Julien Grall) - modify overflow check (Julien Grall) V4: - fix overflow check --- tools/xenstore/xenstored_domain.c | 70 ++++++++++++++++++------------- tools/xenstore/xenstored_domain.h | 3 +- 2 files changed, 43 insertions(+), 30 deletions(-) diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 609a9a13ab..30fb9acec6 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -69,8 +69,8 @@ struct domain /* Has domain been officially introduced? */ bool introduced; - /* number of entry from this domain in the store */ - int nbentry; + /* Accounting data for this domain. */ + unsigned int acc[ACC_N]; /* Amount of memory allocated for this domain. */ int memory; @@ -246,7 +246,7 @@ static int domain_tree_remove_sub(const void *ctx, struct connection *conn, if (keep_orphans) { set_tdb_key(node->name, &key); - domain->nbentry--; + domain_nbentry_dec(NULL, domain->domid); node->perms.p[0].id = priv_domid; node->acc.memory = 0; domain_nbentry_inc(NULL, priv_domid); @@ -270,7 +270,7 @@ static int domain_tree_remove_sub(const void *ctx, struct connection *conn, ret = WALK_TREE_SKIP_CHILDREN; } - return domain->nbentry > 0 ? ret : WALK_TREE_SUCCESS_STOP; + return domain->acc[ACC_NODES] ? ret : WALK_TREE_SUCCESS_STOP; } static void domain_tree_remove(struct domain *domain) @@ -278,7 +278,7 @@ static void domain_tree_remove(struct domain *domain) int ret; struct walk_funcs walkfuncs = { .enter = domain_tree_remove_sub }; - if (domain->nbentry > 0) { + if (domain->acc[ACC_NODES]) { ret = walk_node_tree(domain, NULL, "/", &walkfuncs, domain); if (ret == WALK_TREE_ERROR_STOP) syslog(LOG_ERR, @@ -437,7 +437,7 @@ int domain_get_quota(const void *ctx, struct connection *conn, resp = talloc_asprintf_append(resp, "%-16s: %8d\n", #t, e); \ if (!resp) return ENOMEM - ent(nodes, d->nbentry); + ent(nodes, d->acc[ACC_NODES]); ent(watches, d->nbwatch); ent(transactions, ta); ent(outstanding, d->nboutstanding); @@ -1047,8 +1047,27 @@ int domain_adjust_node_perms(struct node *node) return 0; } -static int domain_nbentry_add(struct connection *conn, unsigned int domid, - int add, bool no_dom_alloc) +static int domain_acc_add_valid(struct domain *d, enum accitem what, int add) +{ + assert(what < ARRAY_SIZE(d->acc)); + + if ((add < 0 && -add > d->acc[what]) || + (add > 0 && (INT_MAX - d->acc[what]) < add)) { + /* + * In a transaction when a node is being added/removed AND the + * same node has been added/removed outside the transaction in + * parallel, the resulting value will be wrong. This is no + * problem, as the transaction will fail due to the resulting + * conflict. + */ + return (add < 0) ? 0 : INT_MAX; + } + + return d->acc[what] + add; +} + +static int domain_acc_add(struct connection *conn, unsigned int domid, + enum accitem what, int add, bool no_dom_alloc) { struct domain *d; struct list_head *head; @@ -1071,56 +1090,49 @@ static int domain_nbentry_add(struct connection *conn, unsigned int domid, } } - if (conn && conn->transaction) { + if (conn && conn->transaction && what < ACC_TR_N) { head = transaction_get_changed_domains(conn->transaction); - ret = acc_add_changed_dom(conn->transaction, head, ACC_NODES, + ret = acc_add_changed_dom(conn->transaction, head, what, add, domid); if (errno) { fail_transaction(conn->transaction); return -1; } - /* - * In a transaction when a node is being added/removed AND the - * same node has been added/removed outside the transaction in - * parallel, the resulting number of nodes will be wrong. This - * is no problem, as the transaction will fail due to the - * resulting conflict. - * In the node remove case the resulting number can be even - * negative, which should be avoided. - */ - return max(d->nbentry + ret, 0); + return domain_acc_add_valid(d, what, ret); } - d->nbentry += add; + d->acc[what] = domain_acc_add_valid(d, what, add); - return d->nbentry; + return d->acc[what]; } int domain_nbentry_inc(struct connection *conn, unsigned int domid) { - return (domain_nbentry_add(conn, domid, 1, false) < 0) ? errno : 0; + return (domain_acc_add(conn, domid, ACC_NODES, 1, false) < 0) + ? errno : 0; } int domain_nbentry_dec(struct connection *conn, unsigned int domid) { - return (domain_nbentry_add(conn, domid, -1, true) < 0) ? errno : 0; + return (domain_acc_add(conn, domid, ACC_NODES, -1, true) < 0) + ? errno : 0; } int domain_nbentry_fix(unsigned int domid, int num, bool update) { int ret; - ret = domain_nbentry_add(NULL, domid, update ? num : 0, update); + ret = domain_acc_add(NULL, domid, ACC_NODES, update ? num : 0, update); if (ret < 0 || update) return ret; return domid_is_unprivileged(domid) ? ret + num : 0; } -int domain_nbentry(struct connection *conn) +unsigned int domain_nbentry(struct connection *conn) { return domain_is_unprivileged(conn) - ? domain_nbentry_add(conn, conn->id, 0, true) : 0; + ? domain_acc_add(conn, conn->id, ACC_NODES, 0, true) : 0; } static bool domain_chk_quota(struct domain *domain, int mem) @@ -1597,7 +1609,7 @@ static int domain_check_acc_init_sub(const void *k, void *v, void *arg) * If everything is correct incrementing the value for each node will * result in dom->nodes being 0 at the end. */ - dom->nodes = -d->nbentry; + dom->nodes = -d->acc[ACC_NODES]; if (!hashtable_insert(domains, &dom->domid, dom)) { talloc_free(dom); @@ -1652,7 +1664,7 @@ static int domain_check_acc_cb(const void *k, void *v, void *arg) if (!d) return 0; - d->nbentry += dom->nodes; + d->acc[ACC_NODES] += dom->nodes; return 0; } diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index 40803574f6..9d05eb01da 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -27,6 +27,7 @@ enum accitem { ACC_NODES, ACC_TR_N, /* Number of elements per transaction. */ + ACC_N = ACC_TR_N, /* Number of elements per domain. */ }; void handle_event(void); @@ -77,7 +78,7 @@ int domain_alloc_permrefs(struct node_perms *perms); int domain_nbentry_inc(struct connection *conn, unsigned int domid); int domain_nbentry_dec(struct connection *conn, unsigned int domid); int domain_nbentry_fix(unsigned int domid, int num, bool update); -int domain_nbentry(struct connection *conn); +unsigned int domain_nbentry(struct connection *conn); int domain_memory_add(unsigned int domid, int mem, bool no_quota_check); /* -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon May 08 11:48:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 11:48:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531400.827045 (Exim 4.92) (envelope-from ) id 1pvzLq-0005QJ-Ez; Mon, 08 May 2023 11:48:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531400.827045; Mon, 08 May 2023 11:48:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzLq-0005Q8-Bz; Mon, 08 May 2023 11:48:22 +0000 Received: by outflank-mailman (input) for mailman id 531400; Mon, 08 May 2023 11:48:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzLp-00040G-33 for xen-devel@lists.xenproject.org; Mon, 08 May 2023 11:48:21 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 39e68f3d-ed96-11ed-8611-37d641c3527e; Mon, 08 May 2023 13:48:19 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id F3B5222029; Mon, 8 May 2023 11:48:18 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C87061346B; Mon, 8 May 2023 11:48:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 3lSYL4LhWGQTNwAAMHmgww (envelope-from ); Mon, 08 May 2023 11:48:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 39e68f3d-ed96-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683546499; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XSQk4VtF6UBQcxOc0jYUSMTnf9LF8gFmH+yoqj3aCZQ=; b=qEHA+HzaLDyJ48+fP2LIJJZwgxxEVXAprBWPw/uUmXibRu2tRKMuHzIEvkDDaNYzgyxhi+ +pL2S6MKx28ASCj5ncvhDxFzcxajKXvIVNR56WoJ42++cETl5UuRZXndii9SPRAM9ULW/g SMD9miJX0QZE/04YKkNtSnszzbZVZu8= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH v5 04/14] tools/xenstore: add framework to commit accounting data on success only Date: Mon, 8 May 2023 13:47:44 +0200 Message-Id: <20230508114754.31514-5-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230508114754.31514-1-jgross@suse.com> References: <20230508114754.31514-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of modifying accounting data and undo those modifications in case of an error during further processing, add a framework for collecting the needed changes and commit them only when the whole operation has succeeded. This scheme can reuse large parts of the per transaction accounting. The changed_domain handling can be reused, but the array size of the accounting data should be possible to be different for both use cases. Signed-off-by: Juergen Gross --- V3: - call acc_commit() earlier (Julien Grall) - add assert() to acc_commit() - use fixed sized acc array in struct changed_domain (Julien Grall) V5: - set conn->in to NULL only locally in acc_commit() (Julien Grall) - define ACC_CHD_N in enum (Julien Grall) --- tools/xenstore/xenstored_core.c | 7 ++++ tools/xenstore/xenstored_core.h | 3 ++ tools/xenstore/xenstored_domain.c | 54 ++++++++++++++++++++++++++++++- tools/xenstore/xenstored_domain.h | 6 +++- 4 files changed, 68 insertions(+), 2 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 3ca68681e3..8392bdec9b 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -1023,6 +1023,9 @@ static void send_error(struct connection *conn, int error) break; } } + + acc_drop(conn); + send_reply(conn, XS_ERROR, xsd_errors[i].errstring, strlen(xsd_errors[i].errstring) + 1); } @@ -1034,6 +1037,9 @@ void send_reply(struct connection *conn, enum xsd_sockmsg_type type, assert(type != XS_WATCH_EVENT); + /* Commit accounting now, as later errors won't undo any changes. */ + acc_commit(conn); + if ( len > XENSTORE_PAYLOAD_MAX ) { send_error(conn, E2BIG); return; @@ -2195,6 +2201,7 @@ struct connection *new_connection(const struct interface_funcs *funcs) new->is_stalled = false; new->transaction_started = 0; INIT_LIST_HEAD(&new->out_list); + INIT_LIST_HEAD(&new->acc_list); INIT_LIST_HEAD(&new->ref_list); INIT_LIST_HEAD(&new->watches); INIT_LIST_HEAD(&new->transaction_list); diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h index c59b06551f..1f811f38cb 100644 --- a/tools/xenstore/xenstored_core.h +++ b/tools/xenstore/xenstored_core.h @@ -139,6 +139,9 @@ struct connection struct list_head out_list; uint64_t timeout_msec; + /* Not yet committed accounting data (valid if in != NULL). */ + struct list_head acc_list; + /* Referenced requests no longer pending. */ struct list_head ref_list; diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 30fb9acec6..e59e40088e 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -100,7 +100,7 @@ struct changed_domain unsigned int domid; /* Accounting data. */ - int acc[ACC_TR_N]; + int acc[ACC_CHD_N]; }; static struct hashtable *domhash; @@ -1070,6 +1070,7 @@ static int domain_acc_add(struct connection *conn, unsigned int domid, enum accitem what, int add, bool no_dom_alloc) { struct domain *d; + struct changed_domain *cd; struct list_head *head; int ret; @@ -1090,6 +1091,22 @@ static int domain_acc_add(struct connection *conn, unsigned int domid, } } + /* Temporary accounting data until final commit? */ + if (conn && conn->in && what < ACC_REQ_N) { + /* Consider transaction local data. */ + ret = 0; + if (conn->transaction && what < ACC_TR_N) { + head = transaction_get_changed_domains( + conn->transaction); + cd = acc_find_changed_domain(head, domid); + if (cd) + ret = cd->acc[what]; + } + ret += acc_add_changed_dom(conn->in, &conn->acc_list, what, + add, domid); + return errno ? -1 : domain_acc_add_valid(d, what, ret); + } + if (conn && conn->transaction && what < ACC_TR_N) { head = transaction_get_changed_domains(conn->transaction); ret = acc_add_changed_dom(conn->transaction, head, what, @@ -1106,6 +1123,41 @@ static int domain_acc_add(struct connection *conn, unsigned int domid, return d->acc[what]; } +void acc_drop(struct connection *conn) +{ + struct changed_domain *cd; + + while ((cd = list_top(&conn->acc_list, struct changed_domain, list))) { + list_del(&cd->list); + talloc_free(cd); + } +} + +void acc_commit(struct connection *conn) +{ + struct changed_domain *cd; + enum accitem what; + struct buffered_data *in = conn->in; + + /* + * Make sure domain_acc_add() below can't add additional data to + * to be committed accounting records. + */ + conn->in = NULL; + + while ((cd = list_top(&conn->acc_list, struct changed_domain, list))) { + list_del(&cd->list); + for (what = 0; what < ACC_REQ_N; what++) + if (cd->acc[what]) + domain_acc_add(conn, cd->domid, what, + cd->acc[what], true); + + talloc_free(cd); + } + + conn->in = in; +} + int domain_nbentry_inc(struct connection *conn, unsigned int domid) { return (domain_acc_add(conn, domid, ACC_NODES, 1, false) < 0) diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index 9d05eb01da..e40657216b 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -25,8 +25,10 @@ * a per transaction array. */ enum accitem { - ACC_NODES, + ACC_REQ_N, /* Number of elements per request. */ + ACC_NODES = ACC_REQ_N, ACC_TR_N, /* Number of elements per transaction. */ + ACC_CHD_N = ACC_TR_N, /* max(ACC_REQ_N, ACC_TR_N), for changed dom. */ ACC_N = ACC_TR_N, /* Number of elements per domain. */ }; @@ -113,6 +115,8 @@ int domain_get_quota(const void *ctx, struct connection *conn, * If "update" is true, "chk_quota" is ignored. */ int acc_fix_domains(struct list_head *head, bool chk_quota, bool update); +void acc_drop(struct connection *conn); +void acc_commit(struct connection *conn); /* Write rate limiting */ -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon May 08 11:48:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 11:48:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531401.827055 (Exim 4.92) (envelope-from ) id 1pvzLu-0005tX-Q2; Mon, 08 May 2023 11:48:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531401.827055; Mon, 08 May 2023 11:48:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzLu-0005tK-N0; Mon, 08 May 2023 11:48:26 +0000 Received: by outflank-mailman (input) for mailman id 531401; Mon, 08 May 2023 11:48:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzLt-0004FA-9j for xen-devel@lists.xenproject.org; Mon, 08 May 2023 11:48:25 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3d402bad-ed96-11ed-b226-6b7b168915f2; Mon, 08 May 2023 13:48:24 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8EDE11FE45; Mon, 8 May 2023 11:48:24 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 623961346B; Mon, 8 May 2023 11:48:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id heugFojhWGQeNwAAMHmgww (envelope-from ); Mon, 08 May 2023 11:48:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3d402bad-ed96-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683546504; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e3gBj5zfxkpTLBUN5UffF19V51EVI0dt3OZ8371Y2g4=; b=QDQkK6m/wEb45LS3of0LKGp9TMCrzRREqdkFLFZ44LT7ZlKaD3WtMLBx6emedlKIiX3YsU pbCgDkGhrsKLDNNFbJZji5wMkLUGas75fPYfykiD8mZu7K9izYZlKjLhPnt4c2vlGluVT+ xZ0DnjcQedm5VotHJ6Rvbv6pzrwT4RM= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH v5 05/14] tools/xenstore: use accounting buffering for node accounting Date: Mon, 8 May 2023 13:47:45 +0200 Message-Id: <20230508114754.31514-6-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230508114754.31514-1-jgross@suse.com> References: <20230508114754.31514-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the node accounting to the accounting information buffering in order to avoid having to undo it in case of failure. This requires to call domain_nbentry_dec() before any changes to the data base, as it can return an error now. Signed-off-by: Juergen Gross --- V5: - add error handling after domain_nbentry_dec() calls (Julien Grall) --- tools/xenstore/xenstored_core.c | 29 +++++++---------------------- tools/xenstore/xenstored_domain.h | 4 ++-- 2 files changed, 9 insertions(+), 24 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 8392bdec9b..22da434e2a 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -1454,7 +1454,6 @@ static void destroy_node_rm(struct connection *conn, struct node *node) static int destroy_node(struct connection *conn, struct node *node) { destroy_node_rm(conn, node); - domain_nbentry_dec(conn, get_node_owner(node)); /* * It is not possible to easily revert the changes in a transaction. @@ -1645,6 +1644,9 @@ static int delnode_sub(const void *ctx, struct connection *conn, if (ret > 0) return WALK_TREE_SUCCESS_STOP; + if (domain_nbentry_dec(conn, get_node_owner(node))) + return WALK_TREE_ERROR_STOP; + /* In case of error stop the walk. */ if (!ret && do_tdb_delete(conn, &key, &node->acc)) return WALK_TREE_SUCCESS_STOP; @@ -1657,8 +1659,6 @@ static int delnode_sub(const void *ctx, struct connection *conn, watch_exact = strcmp(root, node->name); fire_watches(conn, ctx, node->name, node, watch_exact, NULL); - domain_nbentry_dec(conn, get_node_owner(node)); - return WALK_TREE_RM_CHILDENTRY; } @@ -1797,29 +1797,14 @@ static int do_set_perms(const void *ctx, struct connection *conn, return EPERM; old_perms = node->perms; - domain_nbentry_dec(conn, get_node_owner(node)); + if (domain_nbentry_dec(conn, get_node_owner(node))) + return ENOMEM; node->perms = perms; - if (domain_nbentry_inc(conn, get_node_owner(node))) { - node->perms = old_perms; - /* - * This should never fail because we had a reference on the - * domain before and Xenstored is single-threaded. - */ - domain_nbentry_inc(conn, get_node_owner(node)); + if (domain_nbentry_inc(conn, get_node_owner(node))) return ENOMEM; - } - - if (write_node(conn, node, false)) { - int saved_errno = errno; - domain_nbentry_dec(conn, get_node_owner(node)); - node->perms = old_perms; - /* No failure possible as above. */ - domain_nbentry_inc(conn, get_node_owner(node)); - - errno = saved_errno; + if (write_node(conn, node, false)) return errno; - } fire_watches(conn, ctx, name, node, false, &old_perms); send_ack(conn, XS_SET_PERMS); diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index e40657216b..466549709f 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -25,9 +25,9 @@ * a per transaction array. */ enum accitem { + ACC_NODES, ACC_REQ_N, /* Number of elements per request. */ - ACC_NODES = ACC_REQ_N, - ACC_TR_N, /* Number of elements per transaction. */ + ACC_TR_N = ACC_REQ_N, /* Number of elements per transaction. */ ACC_CHD_N = ACC_TR_N, /* max(ACC_REQ_N, ACC_TR_N), for changed dom. */ ACC_N = ACC_TR_N, /* Number of elements per domain. */ }; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon May 08 11:48:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 11:48:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531403.827064 (Exim 4.92) (envelope-from ) id 1pvzM2-0006TV-2K; Mon, 08 May 2023 11:48:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531403.827064; Mon, 08 May 2023 11:48:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzM1-0006TC-VA; Mon, 08 May 2023 11:48:33 +0000 Received: by outflank-mailman (input) for mailman id 531403; Mon, 08 May 2023 11:48:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzM0-00040G-6o for xen-devel@lists.xenproject.org; Mon, 08 May 2023 11:48:32 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4095bc72-ed96-11ed-8611-37d641c3527e; Mon, 08 May 2023 13:48:30 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 33AAC1FE44; Mon, 8 May 2023 11:48:30 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 004991346B; Mon, 8 May 2023 11:48:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id oI9sOo3hWGQpNwAAMHmgww (envelope-from ); Mon, 08 May 2023 11:48:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4095bc72-ed96-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683546510; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uSFUIHMqpZd+uno5jSiEak73wbg4pmWrSCfAkw/DVuI=; b=nartOVTodCD5LxExgRYiIAIDUNDWm0iU5ZYpe6tB89NGhDRP/XVllyFxnDuePQ/1FlrPXy BwwVBOJLNMfQ/vyyhtNz11oorrVJWKYU61b8/pKP9mR/dP2AidSjY6rIzgXLmxrgRdtW+6 41csvUG61XYzOFD6UZgZ/DHjadywr2g= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD , Julien Grall Subject: [PATCH v5 06/14] tools/xenstore: add current connection to domain_memory_add() parameters Date: Mon, 8 May 2023 13:47:46 +0200 Message-Id: <20230508114754.31514-7-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230508114754.31514-1-jgross@suse.com> References: <20230508114754.31514-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In order to enable switching memory accounting to the generic array based accounting, add the current connection to the parameters of domain_memory_add(). This requires to add the connection to some other functions, too. Signed-off-by: Juergen Gross Acked-by: Julien Grall --- tools/xenstore/xenstored_core.c | 28 ++++++++++++++++------------ tools/xenstore/xenstored_domain.c | 3 ++- tools/xenstore/xenstored_domain.h | 14 +++++++++----- tools/xenstore/xenstored_watch.c | 11 ++++++----- 4 files changed, 33 insertions(+), 23 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 22da434e2a..4d1debeba1 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -246,7 +246,8 @@ static void free_buffered_data(struct buffered_data *out, } } - domain_memory_add_nochk(conn->id, -out->hdr.msg.len - sizeof(out->hdr)); + domain_memory_add_nochk(conn, conn->id, + -out->hdr.msg.len - sizeof(out->hdr)); if (out->hdr.msg.type == XS_WATCH_EVENT) { req = out->pend.req; @@ -631,24 +632,25 @@ int do_tdb_write(struct connection *conn, TDB_DATA *key, TDB_DATA *data, * nodes to new owners. */ if (old_acc.memory) - domain_memory_add_nochk(old_domid, + domain_memory_add_nochk(conn, old_domid, -old_acc.memory - key->dsize); - ret = domain_memory_add(new_domid, data->dsize + key->dsize, - no_quota_check); + ret = domain_memory_add(conn, new_domid, + data->dsize + key->dsize, no_quota_check); if (ret) { /* Error path, so no quota check. */ if (old_acc.memory) - domain_memory_add_nochk(old_domid, + domain_memory_add_nochk(conn, old_domid, old_acc.memory + key->dsize); return ret; } /* TDB should set errno, but doesn't even set ecode AFAICT. */ if (tdb_store(tdb_ctx, *key, *data, TDB_REPLACE) != 0) { - domain_memory_add_nochk(new_domid, -data->dsize - key->dsize); + domain_memory_add_nochk(conn, new_domid, + -data->dsize - key->dsize); /* Error path, so no quota check. */ if (old_acc.memory) - domain_memory_add_nochk(old_domid, + domain_memory_add_nochk(conn, old_domid, old_acc.memory + key->dsize); errno = EIO; return errno; @@ -683,7 +685,7 @@ int do_tdb_delete(struct connection *conn, TDB_DATA *key, if (acc->memory) { domid = get_acc_domid(conn, key, acc->domid); - domain_memory_add_nochk(domid, -acc->memory - key->dsize); + domain_memory_add_nochk(conn, domid, -acc->memory - key->dsize); } return 0; @@ -1055,11 +1057,13 @@ void send_reply(struct connection *conn, enum xsd_sockmsg_type type, if (len <= DEFAULT_BUFFER_SIZE) { bdata->buffer = bdata->default_buffer; /* Don't check quota, path might be used for returning error. */ - domain_memory_add_nochk(conn->id, len + sizeof(bdata->hdr)); + domain_memory_add_nochk(conn, conn->id, + len + sizeof(bdata->hdr)); } else { bdata->buffer = talloc_array(bdata, char, len); if (!bdata->buffer || - domain_memory_add_chk(conn->id, len + sizeof(bdata->hdr))) { + domain_memory_add_chk(conn, conn->id, + len + sizeof(bdata->hdr))) { send_error(conn, ENOMEM); return; } @@ -1124,7 +1128,7 @@ void send_event(struct buffered_data *req, struct connection *conn, } } - if (domain_memory_add_chk(conn->id, len + sizeof(bdata->hdr))) { + if (domain_memory_add_chk(conn, conn->id, len + sizeof(bdata->hdr))) { talloc_free(bdata); return; } @@ -3326,7 +3330,7 @@ static void add_buffered_data(struct buffered_data *bdata, * be smaller. So ignore it. The limit will be applied for any resource * after the state has been fully restored. */ - domain_memory_add_nochk(conn->id, len + sizeof(bdata->hdr)); + domain_memory_add_nochk(conn, conn->id, len + sizeof(bdata->hdr)); } void read_state_buffered_data(const void *ctx, struct connection *conn, diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index e59e40088e..7770c4f395 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -1236,7 +1236,8 @@ static bool domain_chk_quota(struct domain *domain, int mem) return false; } -int domain_memory_add(unsigned int domid, int mem, bool no_quota_check) +int domain_memory_add(struct connection *conn, unsigned int domid, int mem, + bool no_quota_check) { struct domain *domain; diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index 466549709f..b94548fd7d 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -81,25 +81,29 @@ int domain_nbentry_inc(struct connection *conn, unsigned int domid); int domain_nbentry_dec(struct connection *conn, unsigned int domid); int domain_nbentry_fix(unsigned int domid, int num, bool update); unsigned int domain_nbentry(struct connection *conn); -int domain_memory_add(unsigned int domid, int mem, bool no_quota_check); +int domain_memory_add(struct connection *conn, unsigned int domid, int mem, + bool no_quota_check); /* * domain_memory_add_chk(): to be used when memory quota should be checked. * Not to be used when specifying a negative mem value, as lowering the used * memory should always be allowed. */ -static inline int domain_memory_add_chk(unsigned int domid, int mem) +static inline int domain_memory_add_chk(struct connection *conn, + unsigned int domid, int mem) { - return domain_memory_add(domid, mem, false); + return domain_memory_add(conn, domid, mem, false); } + /* * domain_memory_add_nochk(): to be used when memory quota should not be * checked, e.g. when lowering memory usage, or in an error case for undoing * a previous memory adjustment. */ -static inline void domain_memory_add_nochk(unsigned int domid, int mem) +static inline void domain_memory_add_nochk(struct connection *conn, + unsigned int domid, int mem) { - domain_memory_add(domid, mem, true); + domain_memory_add(conn, domid, mem, true); } void domain_watch_inc(struct connection *conn); void domain_watch_dec(struct connection *conn); diff --git a/tools/xenstore/xenstored_watch.c b/tools/xenstore/xenstored_watch.c index 8ad0229df6..e30cd89be3 100644 --- a/tools/xenstore/xenstored_watch.c +++ b/tools/xenstore/xenstored_watch.c @@ -199,7 +199,7 @@ static struct watch *add_watch(struct connection *conn, char *path, char *token, watch->token = talloc_strdup(watch, token); if (!watch->node || !watch->token) goto nomem; - if (domain_memory_add(conn->id, strlen(path) + strlen(token), + if (domain_memory_add(conn, conn->id, strlen(path) + strlen(token), no_quota_check)) goto nomem; @@ -274,8 +274,9 @@ int do_unwatch(const void *ctx, struct connection *conn, list_for_each_entry(watch, &conn->watches, list) { if (streq(watch->node, node) && streq(watch->token, vec[1])) { list_del(&watch->list); - domain_memory_add_nochk(conn->id, -strlen(watch->node) - - strlen(watch->token)); + domain_memory_add_nochk(conn, conn->id, + -strlen(watch->node) - + strlen(watch->token)); talloc_free(watch); domain_watch_dec(conn); send_ack(conn, XS_UNWATCH); @@ -291,8 +292,8 @@ void conn_delete_all_watches(struct connection *conn) while ((watch = list_top(&conn->watches, struct watch, list))) { list_del(&watch->list); - domain_memory_add_nochk(conn->id, -strlen(watch->node) - - strlen(watch->token)); + domain_memory_add_nochk(conn, conn->id, -strlen(watch->node) - + strlen(watch->token)); talloc_free(watch); domain_watch_dec(conn); } -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon May 08 11:48:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 11:48:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531408.827075 (Exim 4.92) (envelope-from ) id 1pvzM6-0006yY-Bf; Mon, 08 May 2023 11:48:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531408.827075; Mon, 08 May 2023 11:48:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzM6-0006yP-8K; Mon, 08 May 2023 11:48:38 +0000 Received: by outflank-mailman (input) for mailman id 531408; Mon, 08 May 2023 11:48:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzM5-00040G-Sw for xen-devel@lists.xenproject.org; Mon, 08 May 2023 11:48:37 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 43e66c34-ed96-11ed-8611-37d641c3527e; Mon, 08 May 2023 13:48:36 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BBEA61FE49; Mon, 8 May 2023 11:48:35 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 925FB1346B; Mon, 8 May 2023 11:48:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id aatfIpPhWGQzNwAAMHmgww (envelope-from ); Mon, 08 May 2023 11:48:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 43e66c34-ed96-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683546515; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QRtofhElFKAPAVu2ut+tgG7Lb4CqCOPPZR3Nz1CeFJk=; b=l5YIgBheeU6YqvxCaW6EO4JfCt0K0poacuMCaXfy1glSNuSsX9P7iz0jrNf6Z0AWO4BG3P t10T4GfrPopYt/QQIwp2JF3wIYwNIk1uhRbbIO3Q//G5F/aKL/5mQ9N7ErpzOVVk/dSGl9 XuJbuWoUk0nhUmBbpxFxfOlJj2b+dek= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH v5 07/14] tools/xenstore: use accounting data array for per-domain values Date: Mon, 8 May 2023 13:47:47 +0200 Message-Id: <20230508114754.31514-8-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230508114754.31514-1-jgross@suse.com> References: <20230508114754.31514-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the accounting of per-domain usage of Xenstore memory, watches, and outstanding requests to the array based mechanism. Signed-off-by: Juergen Gross --- V5: - drop domid parameter from domain_outstanding_inc() (Julien Grall) --- tools/xenstore/xenstored_core.c | 4 +- tools/xenstore/xenstored_domain.c | 109 +++++++++++------------------- tools/xenstore/xenstored_domain.h | 8 ++- 3 files changed, 48 insertions(+), 73 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 4d1debeba1..e7f86f9487 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -255,7 +255,7 @@ static void free_buffered_data(struct buffered_data *out, req->pend.ref.event_cnt--; if (!req->pend.ref.event_cnt && !req->on_out_list) { if (req->on_ref_list) { - domain_outstanding_domid_dec( + domain_outstanding_dec(conn, req->pend.ref.domid); list_del(&req->list); } @@ -271,7 +271,7 @@ static void free_buffered_data(struct buffered_data *out, out->on_ref_list = true; return; } else - domain_outstanding_dec(conn); + domain_outstanding_dec(conn, conn->id); talloc_free(out); } diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 7770c4f395..a35ed97fd7 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -72,19 +72,12 @@ struct domain /* Accounting data for this domain. */ unsigned int acc[ACC_N]; - /* Amount of memory allocated for this domain. */ - int memory; + /* Memory quota data for this domain. */ bool soft_quota_reported; bool hard_quota_reported; time_t mem_last_msg; #define MEM_WARN_MINTIME_SEC 10 - /* number of watch for this domain */ - int nbwatch; - - /* Number of outstanding requests. */ - int nboutstanding; - /* write rate limit */ wrl_creditt wrl_credit; /* [ -wrl_config_writecost, +_dburst ] */ struct wrl_timestampt wrl_timestamp; @@ -200,14 +193,15 @@ static bool domain_can_write(struct connection *conn) static bool domain_can_read(struct connection *conn) { - struct xenstore_domain_interface *intf = conn->domain->interface; + struct domain *domain = conn->domain; + struct xenstore_domain_interface *intf = domain->interface; if (domain_is_unprivileged(conn)) { - if (conn->domain->wrl_credit < 0) + if (domain->wrl_credit < 0) return false; - if (conn->domain->nboutstanding >= quota_req_outstanding) + if (domain->acc[ACC_OUTST] >= quota_req_outstanding) return false; - if (conn->domain->memory >= quota_memory_per_domain_hard && + if (domain->acc[ACC_MEM] >= quota_memory_per_domain_hard && quota_memory_per_domain_hard) return false; } @@ -438,10 +432,10 @@ int domain_get_quota(const void *ctx, struct connection *conn, if (!resp) return ENOMEM ent(nodes, d->acc[ACC_NODES]); - ent(watches, d->nbwatch); + ent(watches, d->acc[ACC_WATCH]); ent(transactions, ta); - ent(outstanding, d->nboutstanding); - ent(memory, d->memory); + ent(outstanding, d->acc[ACC_OUTST]); + ent(memory, d->acc[ACC_MEM]); #undef ent @@ -1187,14 +1181,16 @@ unsigned int domain_nbentry(struct connection *conn) ? domain_acc_add(conn, conn->id, ACC_NODES, 0, true) : 0; } -static bool domain_chk_quota(struct domain *domain, int mem) +static bool domain_chk_quota(struct connection *conn, unsigned int mem) { time_t now; + struct domain *domain; - if (!domain || !domid_is_unprivileged(domain->domid) || - (domain->conn && domain->conn->is_ignored)) + if (!conn || !domid_is_unprivileged(conn->id) || + conn->is_ignored) return false; + domain = conn->domain; now = time(NULL); if (mem >= quota_memory_per_domain_hard && @@ -1239,80 +1235,57 @@ static bool domain_chk_quota(struct domain *domain, int mem) int domain_memory_add(struct connection *conn, unsigned int domid, int mem, bool no_quota_check) { - struct domain *domain; + int ret; - domain = find_domain_struct(domid); - if (domain) { - /* - * domain_chk_quota() will print warning and also store whether - * the soft/hard quota has been hit. So check no_quota_check - * *after*. - */ - if (domain_chk_quota(domain, domain->memory + mem) && - !no_quota_check) - return ENOMEM; - domain->memory += mem; - } else { - /* - * The domain the memory is to be accounted for should always - * exist, as accounting is done either for a domain related to - * the current connection, or for the domain owning a node - * (which is always existing, as the owner of the node is - * tested to exist and deleted or replaced by domid 0 if not). - * So not finding the related domain MUST be an error in the - * data base. - */ - errno = ENOENT; - corrupt(NULL, "Accounting called for non-existing domain %u\n", - domid); - return ENOENT; - } + ret = domain_acc_add(conn, domid, ACC_MEM, 0, true); + if (ret < 0) + return -ret; + + /* + * domain_chk_quota() will print warning and also store whether the + * soft/hard quota has been hit. So check no_quota_check *after*. + */ + if (domain_chk_quota(conn, ret + mem) && !no_quota_check) + return ENOMEM; + + /* + * The domain the memory is to be accounted for should always exist, + * as accounting is done either for a domain related to the current + * connection, or for the domain owning a node (which is always + * existing, as the owner of the node is tested to exist and deleted + * or replaced by domid 0 if not). + * So not finding the related domain MUST be an error in the data base. + */ + domain_acc_add(conn, domid, ACC_MEM, mem, true); return 0; } void domain_watch_inc(struct connection *conn) { - if (!conn || !conn->domain) - return; - conn->domain->nbwatch++; + domain_acc_add(conn, conn->id, ACC_WATCH, 1, true); } void domain_watch_dec(struct connection *conn) { - if (!conn || !conn->domain) - return; - if (conn->domain->nbwatch) - conn->domain->nbwatch--; + domain_acc_add(conn, conn->id, ACC_WATCH, -1, true); } int domain_watch(struct connection *conn) { return (domain_is_unprivileged(conn)) - ? conn->domain->nbwatch + ? domain_acc_add(conn, conn->id, ACC_WATCH, 0, true) : 0; } void domain_outstanding_inc(struct connection *conn) { - if (!conn || !conn->domain) - return; - conn->domain->nboutstanding++; + domain_acc_add(conn, conn->id, ACC_OUTST, 1, true); } -void domain_outstanding_dec(struct connection *conn) +void domain_outstanding_dec(struct connection *conn, unsigned int domid) { - if (!conn || !conn->domain) - return; - conn->domain->nboutstanding--; -} - -void domain_outstanding_domid_dec(unsigned int domid) -{ - struct domain *d = find_domain_by_domid(domid); - - if (d) - d->nboutstanding--; + domain_acc_add(conn, domid, ACC_OUTST, -1, true); } static wrl_creditt wrl_config_writecost = WRL_FACTOR; diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index b94548fd7d..086133407b 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -29,7 +29,10 @@ enum accitem { ACC_REQ_N, /* Number of elements per request. */ ACC_TR_N = ACC_REQ_N, /* Number of elements per transaction. */ ACC_CHD_N = ACC_TR_N, /* max(ACC_REQ_N, ACC_TR_N), for changed dom. */ - ACC_N = ACC_TR_N, /* Number of elements per domain. */ + ACC_WATCH = ACC_TR_N, + ACC_OUTST, + ACC_MEM, + ACC_N, /* Number of elements per domain. */ }; void handle_event(void); @@ -109,8 +112,7 @@ void domain_watch_inc(struct connection *conn); void domain_watch_dec(struct connection *conn); int domain_watch(struct connection *conn); void domain_outstanding_inc(struct connection *conn); -void domain_outstanding_dec(struct connection *conn); -void domain_outstanding_domid_dec(unsigned int domid); +void domain_outstanding_dec(struct connection *conn, unsigned int domid); int domain_get_quota(const void *ctx, struct connection *conn, unsigned int domid); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon May 08 11:48:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 11:48:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531415.827085 (Exim 4.92) (envelope-from ) id 1pvzMB-0007S9-L8; Mon, 08 May 2023 11:48:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531415.827085; Mon, 08 May 2023 11:48:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzMB-0007S0-Hc; Mon, 08 May 2023 11:48:43 +0000 Received: by outflank-mailman (input) for mailman id 531415; Mon, 08 May 2023 11:48:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzMA-0004FA-BZ for xen-devel@lists.xenproject.org; Mon, 08 May 2023 11:48:42 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 474ba90e-ed96-11ed-b226-6b7b168915f2; Mon, 08 May 2023 13:48:41 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 687D81FE43; Mon, 8 May 2023 11:48:41 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2AD791346B; Mon, 8 May 2023 11:48:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id IpQiCZnhWGRJNwAAMHmgww (envelope-from ); Mon, 08 May 2023 11:48:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 474ba90e-ed96-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683546521; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HoO5vhLxJfHeUF6CaN4B5hMFR55WKl59O7dl7jFaRfo=; b=Yz3s02wIMFCTIEwsPY87/4US/J/9IK8jK5QOI19zTpnkV5jTVuuwlHFacpPhig//JplOeA +2UgwIzGy6D00Eh2C19Udvu9LoX0bkWQNaQTzkRujwPMJtb9i02aAOWU/pDNJYz/eQvoih xIWnQ1eZcXqhAgqu+4Ug8dc78QTZ33I= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD , Julien Grall Subject: [PATCH v5 08/14] tools/xenstore: add accounting trace support Date: Mon, 8 May 2023 13:47:48 +0200 Message-Id: <20230508114754.31514-9-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230508114754.31514-1-jgross@suse.com> References: <20230508114754.31514-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a new trace switch "acc" and the related trace calls. The "acc" switch is off per default. Signed-off-by: Juergen Gross Reviewed-by: Julien Grall --- tools/xenstore/xenstored_core.c | 2 +- tools/xenstore/xenstored_core.h | 1 + tools/xenstore/xenstored_domain.c | 10 ++++++++++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index e7f86f9487..15654730a6 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -2750,7 +2750,7 @@ static void set_quota(const char *arg, bool soft) /* Sorted by bit values of TRACE_* flags. Flag is (1u << index). */ const char *const trace_switches[] = { - "obj", "io", "wrl", + "obj", "io", "wrl", "acc", NULL }; diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h index 1f811f38cb..3e0734a6c6 100644 --- a/tools/xenstore/xenstored_core.h +++ b/tools/xenstore/xenstored_core.h @@ -302,6 +302,7 @@ extern unsigned int trace_flags; #define TRACE_OBJ 0x00000001 #define TRACE_IO 0x00000002 #define TRACE_WRL 0x00000004 +#define TRACE_ACC 0x00000008 extern const char *const trace_switches[]; int set_trace_switch(const char *arg); diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index a35ed97fd7..03825ca24b 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -538,6 +538,12 @@ static struct domain *find_domain_by_domid(unsigned int domid) return (d && d->introduced) ? d : NULL; } +#define trace_acc(...) \ +do { \ + if (trace_flags & TRACE_ACC) \ + trace("acc: " __VA_ARGS__); \ +} while (0) + int acc_fix_domains(struct list_head *head, bool chk_quota, bool update) { struct changed_domain *cd; @@ -601,6 +607,8 @@ static int acc_add_changed_dom(const void *ctx, struct list_head *head, return 0; errno = 0; + trace_acc("local change domid %u: what=%u %d add %d\n", domid, what, + cd->acc[what], val); cd->acc[what] += val; return cd->acc[what]; @@ -1112,6 +1120,8 @@ static int domain_acc_add(struct connection *conn, unsigned int domid, return domain_acc_add_valid(d, what, ret); } + trace_acc("global change domid %u: what=%u %u add %d\n", domid, what, + d->acc[what], add); d->acc[what] = domain_acc_add_valid(d, what, add); return d->acc[what]; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon May 08 11:48:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 11:48:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531420.827094 (Exim 4.92) (envelope-from ) id 1pvzMN-0008Jp-W6; Mon, 08 May 2023 11:48:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531420.827094; Mon, 08 May 2023 11:48:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzMN-0008Ii-TJ; Mon, 08 May 2023 11:48:55 +0000 Received: by outflank-mailman (input) for mailman id 531420; Mon, 08 May 2023 11:48:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzMM-00040G-IB for xen-devel@lists.xenproject.org; Mon, 08 May 2023 11:48:54 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4df9619e-ed96-11ed-8611-37d641c3527e; Mon, 08 May 2023 13:48:52 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A482E1FE46; Mon, 8 May 2023 11:48:52 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 713EF1346B; Mon, 8 May 2023 11:48:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6TECGqThWGRrNwAAMHmgww (envelope-from ); Mon, 08 May 2023 11:48:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4df9619e-ed96-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683546532; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WygQN3u5bQxjz80/E369O7e/SKWPMMg7pxJNcjOOWFg=; b=mvlYw5GR4eaquZyEsApbJk1NuKRWSUXDggk7PfmrKXIZZygpP9dh8q6X9ic/dw1zp6BvhV IVNf8T6aJLqpgXRtrIiyHROxWYy3ESsNET0ASkNexOJsFHiGTUZB1mXUTUlGvj4qtrEnHV ZEEit0tOUdX5l545/bDkQo3EFzy0lRA= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH v5 10/14] tools/xenstore: switch transaction accounting to generic accounting Date: Mon, 8 May 2023 13:47:50 +0200 Message-Id: <20230508114754.31514-11-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230508114754.31514-1-jgross@suse.com> References: <20230508114754.31514-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As transaction accounting is active for unprivileged domains only, it can easily be added to the generic per-domain accounting. Signed-off-by: Juergen Gross --- V5: - use list_empty(&conn->transaction_list) for detection of "no transaction active" (Julien Grall) --- tools/xenstore/xenstored_core.c | 3 +-- tools/xenstore/xenstored_core.h | 1 - tools/xenstore/xenstored_domain.c | 21 ++++++++++++++++++--- tools/xenstore/xenstored_domain.h | 4 ++++ tools/xenstore/xenstored_transaction.c | 14 ++++++-------- 5 files changed, 29 insertions(+), 14 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 3caf9e45dc..c98d30561f 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -2087,7 +2087,7 @@ static void consider_message(struct connection *conn) * stalled. This will ignore new requests until Live-Update happened * or it was aborted. */ - if (lu_is_pending() && conn->transaction_started == 0 && + if (lu_is_pending() && list_empty(&conn->transaction_list) && conn->in->hdr.msg.type == XS_TRANSACTION_START) { trace("Delaying transaction start for connection %p req_id %u\n", conn, conn->in->hdr.msg.req_id); @@ -2194,7 +2194,6 @@ struct connection *new_connection(const struct interface_funcs *funcs) new->funcs = funcs; new->is_ignored = false; new->is_stalled = false; - new->transaction_started = 0; INIT_LIST_HEAD(&new->out_list); INIT_LIST_HEAD(&new->acc_list); INIT_LIST_HEAD(&new->ref_list); diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h index 5a11dc1231..3564d85d7d 100644 --- a/tools/xenstore/xenstored_core.h +++ b/tools/xenstore/xenstored_core.h @@ -151,7 +151,6 @@ struct connection /* List of in-progress transactions. */ struct list_head transaction_list; uint32_t next_transaction_id; - unsigned int transaction_started; time_t ta_start_time; /* List of delayed requests. */ diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 03825ca24b..25c6d20036 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -417,12 +417,10 @@ int domain_get_quota(const void *ctx, struct connection *conn, { struct domain *d = find_domain_struct(domid); char *resp; - int ta; if (!d) return ENOENT; - ta = d->conn ? d->conn->transaction_started : 0; resp = talloc_asprintf(ctx, "Domain %u:\n", domid); if (!resp) return ENOMEM; @@ -433,7 +431,7 @@ int domain_get_quota(const void *ctx, struct connection *conn, ent(nodes, d->acc[ACC_NODES]); ent(watches, d->acc[ACC_WATCH]); - ent(transactions, ta); + ent(transactions, d->acc[ACC_TRANS]); ent(outstanding, d->acc[ACC_OUTST]); ent(memory, d->acc[ACC_MEM]); @@ -1298,6 +1296,23 @@ void domain_outstanding_dec(struct connection *conn, unsigned int domid) domain_acc_add(conn, domid, ACC_OUTST, -1, true); } +void domain_transaction_inc(struct connection *conn) +{ + domain_acc_add(conn, conn->id, ACC_TRANS, 1, true); +} + +void domain_transaction_dec(struct connection *conn) +{ + domain_acc_add(conn, conn->id, ACC_TRANS, -1, true); +} + +unsigned int domain_transaction_get(struct connection *conn) +{ + return (domain_is_unprivileged(conn)) + ? domain_acc_add(conn, conn->id, ACC_TRANS, 0, true) + : 0; +} + static wrl_creditt wrl_config_writecost = WRL_FACTOR; static wrl_creditt wrl_config_rate = WRL_RATE * WRL_FACTOR; static wrl_creditt wrl_config_dburst = WRL_DBURST * WRL_FACTOR; diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index 086133407b..01b6f1861b 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -32,6 +32,7 @@ enum accitem { ACC_WATCH = ACC_TR_N, ACC_OUTST, ACC_MEM, + ACC_TRANS, ACC_N, /* Number of elements per domain. */ }; @@ -113,6 +114,9 @@ void domain_watch_dec(struct connection *conn); int domain_watch(struct connection *conn); void domain_outstanding_inc(struct connection *conn); void domain_outstanding_dec(struct connection *conn, unsigned int domid); +void domain_transaction_inc(struct connection *conn); +void domain_transaction_dec(struct connection *conn); +unsigned int domain_transaction_get(struct connection *conn); int domain_get_quota(const void *ctx, struct connection *conn, unsigned int domid); diff --git a/tools/xenstore/xenstored_transaction.c b/tools/xenstore/xenstored_transaction.c index 11c8bcec84..b9e9d76a1f 100644 --- a/tools/xenstore/xenstored_transaction.c +++ b/tools/xenstore/xenstored_transaction.c @@ -479,8 +479,7 @@ int do_transaction_start(const void *ctx, struct connection *conn, if (conn->transaction) return EBUSY; - if (domain_is_unprivileged(conn) && - conn->transaction_started > quota_max_transaction) + if (domain_transaction_get(conn) > quota_max_transaction) return ENOSPC; /* Attach transaction to ctx for autofree until it's complete */ @@ -502,12 +501,12 @@ int do_transaction_start(const void *ctx, struct connection *conn, } while (!IS_ERR(exists)); /* Now we own it. */ + if (list_empty(&conn->transaction_list)) + conn->ta_start_time = time(NULL); list_add_tail(&trans->list, &conn->transaction_list); talloc_steal(conn, trans); talloc_set_destructor(trans, destroy_transaction); - if (!conn->transaction_started) - conn->ta_start_time = time(NULL); - conn->transaction_started++; + domain_transaction_inc(conn); wrl_ntransactions++; snprintf(id_str, sizeof(id_str), "%u", trans->id); @@ -533,8 +532,8 @@ int do_transaction_end(const void *ctx, struct connection *conn, conn->transaction = NULL; list_del(&trans->list); - conn->transaction_started--; - if (!conn->transaction_started) + domain_transaction_dec(conn); + if (list_empty(&conn->transaction_list)) conn->ta_start_time = 0; chk_quota = trans->node_created && domain_is_unprivileged(conn); @@ -588,7 +587,6 @@ void conn_delete_all_transactions(struct connection *conn) assert(conn->transaction == NULL); - conn->transaction_started = 0; conn->ta_start_time = 0; } -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon May 08 11:56:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 11:56:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531426.827105 (Exim 4.92) (envelope-from ) id 1pvzTO-00026H-OE; Mon, 08 May 2023 11:56:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531426.827105; Mon, 08 May 2023 11:56:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzTO-00026A-L9; Mon, 08 May 2023 11:56:10 +0000 Received: by outflank-mailman (input) for mailman id 531426; Mon, 08 May 2023 11:56:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzTN-000264-98 for xen-devel@lists.xenproject.org; Mon, 08 May 2023 11:56:09 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on20602.outbound.protection.outlook.com [2a01:111:f400:fe13::602]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5079e5b5-ed97-11ed-8611-37d641c3527e; Mon, 08 May 2023 13:56:06 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7844.eurprd04.prod.outlook.com (2603:10a6:20b:236::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Mon, 8 May 2023 11:56:03 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c%4]) with mapi id 15.20.6363.031; Mon, 8 May 2023 11:56:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5079e5b5-ed97-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HpGmM0UUgZrEV38xVmJtBOIR1PduVJ8W/4cqJNJJ2yRxzoLt5BVR9G0KuDz5QaFio8W192vv57CghefcYc+VstJ9/DoK1e4XlV6TlyVCrJpp9uyFBjLH5tcMpYZsui1wyVqMvwL+YpOUFTYEalpR3w1LlpELLkcOdazHtdNeQsctxjvDluelwZghRnIWTEPb57bttyyJcAbeOxK+dp/SBSellWFpNJXZIFsVGWIZHexttqsRkCmD697ikUr4376OCmRB4Fn0nPQBdmIetyTSlNegyDzGPkVPqGguJY8WyPYVXvvkEMPrFpDSnSsX3ccUPVs5rjcKLT5XinYju5x4gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L9NBcAHi0ygGzgQqrKQSGrRdSqMpi5l15+rO1KHm1tQ=; b=cF5aTCjasSGNb1cTTw9s+E/t3Y7dCAey7lgOvWHuHFG4T998Hpk40IvM2OQSLbHBQGaRsjTQp4UXu0upRlOHjT6YpPG0BNc/DwhlDWIAx322PULxBE2CvjJ+iMbkKA2P9mE1pfSHeTBMEccf8mo1R520qSmI9VqNw3QdXGMLLlX0YKEWqzrcT9Bdk1y1z7sGgRoSUaFQYTdQqAs6MYQ8eKKHmS+5ME+S8GkA4rjv3KXZ3gt8DLYjn7eFIQeGmlg/nAfFWLo19F+7hYb2N2idaTTIFghTr4IWuFKheW1yTx6lzwdIxdEZ+nftppoetN6YBxlGL+GD0OT49iAuXvfAIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L9NBcAHi0ygGzgQqrKQSGrRdSqMpi5l15+rO1KHm1tQ=; b=AKHQT4cq39zSYN/n9aAcs3dFIzneUR9/09tRzw1rH0vvj0htoG5cWjAzeyz4pa3EexQRu/rdMOfXEkQvkGkc6/Knjf5Jq5rnKQNKyyHH3QVmT8/zwwHd4acbGoo7K/OO5RWBgkLhhKnvEG6gSZzSBYgKSmYAEqYx/LgudKaKRwhHubCYZKLittipHrHn3M6ea/M09qWdJcDQqQCYU5S3i+18+Bvi5EWr2UnKf4p//KRySFA9K3jFbL89L15wo2ijfyLr5FcKwYgpKFVJ6Emo/KP8//4eatc3afzkXaH6cqKo6J5PvrjsyEwyCafep93KhoOKVa4fzWpdajbHCW7p/A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <46c46e0b-0fba-2f3f-6289-f68737a3d8d9@suse.com> Date: Mon, 8 May 2023 13:56:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3 13/14 RESEND] xenpm: Add set-cpufreq-hwp subcommand Content-Language: en-US To: Jason Andryuk Cc: Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org References: <20230501193034.88575-1-jandryuk@gmail.com> <20230501193034.88575-14-jandryuk@gmail.com> From: Jan Beulich In-Reply-To: <20230501193034.88575-14-jandryuk@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0135.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7844:EE_ X-MS-Office365-Filtering-Correlation-Id: fee3b09a-2cee-4c02-c211-08db4fbb32d0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +gY3tpuhIroDVaoODJKH2Q2vh6Nb4En5Uyt2KtoO0x8iAuUxnk3+cyQlBGwUxexAeeuNfA7MdwNMoZ+l38kSbq9AixIP+pdi9cKrbtoZeDXqnAzxLIvw+UM7pphLJ5rqTp7BZRX0smjI1BeRxY/a7ITz1nJ04uxJ2f2F44MgPz7e28qcdKBiBtPdDjrllWHR8WPFxWT9zZCrPJTGbnkjFe9J0nTiv1DvQtTk/mtMu1Tm3VfQOluqaJMgrgZPtmvJ+1G4m4xyHMuTxSz9LtXX/qzIz/mTfc3RK729cDG3a9RpiDAoBBmxxkS32EWIhRsJRLZS7jW2SRpjohbAMyuyUrb2aQirpFGDci2O/Hc8dSNSH2WL5vPZ4Kmg9sRO4t5YJowhyO3PC7Zt8lDuMd21E5vnI1QTMLfKo0jwbWep2rW2ptw/Iqh6lBDq9AR55DkbTUI/5yUGNrWUC/ZrU1KLSAs+WX1A9UQZGzJVQ9MUGu6qeh87Y0h3ChvpCjWjEYWEfTLt3qlLiagWuttJ+jNWEIiX8MN9yv3ATkZU3CcG4rdZYPq3DHPD61+PQpxHQKKFC+E9dsH0eCLpn50TjBxlqO6nWCJe0Liy2XusQaF+Qs7sE+gSJfiVnNy4X7V8ROQa7lIs5RVN2l/5AR8Vd9FySw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(366004)(39860400002)(376002)(136003)(396003)(451199021)(6506007)(6512007)(26005)(53546011)(6486002)(83380400001)(66574015)(36756003)(2616005)(38100700002)(86362001)(31696002)(186003)(6916009)(5660300002)(4326008)(66476007)(54906003)(66946007)(2906002)(478600001)(8676002)(8936002)(66556008)(31686004)(41300700001)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dmRJVXdJVTNjWFlBTlFsN094MFQvUmRseFM3aHNjVDZWUUFEMGlCTllFQW9Z?= =?utf-8?B?dzIwVGpWRUtuMTgxd1RnZXpxem1VZW5Wejd3M2d4WmQ5RlVCalZiNTdxZnFZ?= =?utf-8?B?MXN4YUlZWXdWRlBwSEp2YThBWDVBRXpET01SUmpMbGVZZng2NGo5UWxTeWdB?= =?utf-8?B?bG9BNnMrdVBDbnNESG01R2J4WXh2SnZ3d1FPNXpNbWUwUTBONTNwc29hOGw5?= =?utf-8?B?WlpwNHJWSkJRSFZJUVJubHk2c2E1TEcwL2FiMFRBc0FkZ1laZW9LU1Y2Q3d4?= =?utf-8?B?NENpQzZRdkM5VTJ3dk1HWURFTXI4V21PWmhPeWVudjQ0U1FDa0xFckFtS0E4?= =?utf-8?B?SUNHVURzcS96OTFScXhYREdlOGJ1LzNJZlFpVVd0SWFqb1pDc0xsc3VYZ2tr?= =?utf-8?B?c0hUcS95TEZaaHBXTG5BTXZhV2liZjFpSFUyaUJuS0x0OGJIbVNma2dBV3Vk?= =?utf-8?B?dHRFZ0E2Mjd3dVo3RlphYUlqTmlNbGMyVmpxa29TR0x0SEQzRXR5YUQyQnNT?= =?utf-8?B?dUFjMDM0WnRyeUo5ZTJmRkp4Y3JpR1d1SVg3MVNLYmNwa0Z4dHpiTVRVaUFw?= =?utf-8?B?SVd2dUNndzJmQ09POTFkdkV0TXVZTXJpQWZZVmx1R2g1bkFHQ3FmZXZDc250?= =?utf-8?B?SXVPS1FlbERlQU5MNVN5a2I4N1h3WmRBbFZoM0Rja3dZTnhxcTRWNDkyeWxo?= =?utf-8?B?cWlUSUVFNGVrS3ByTnE1a3p3emduNVJlMWZGUGZjLzdFek5PUWdsQ28wYlpv?= =?utf-8?B?T0JRbXBIOThVWEdrMWUrZjhzV2hoalFIaWc1WEtlZ3JTRzc3VXRwc1E2c0Jr?= =?utf-8?B?THI0b1MyY0hjQWNIbyt6WDA3K3lGV2dsZ0pWWFFYbGZPL2JGeTV4R0MxZmZm?= =?utf-8?B?VnU1ZGdSekRUUVE2OS9PVmd6cUUxREdKR20ybXhyNmxFQmcrUktJL1hqc2x2?= =?utf-8?B?TTRjY0l3TlhrTWlrNUJJM2NJNnYzeXZDRHlndlI5VkVDdXdDWkl1QU1DOC9l?= =?utf-8?B?Uy9tZTJPNVdabXlvbnBYM0VBN2xzRk9iN0U3cHdyVmhFcGx4cmF3RkRwK2wv?= =?utf-8?B?Q1VZSWQvbWxjaWZMY29Cdm01K1Y1cVU3dWYxaVZjdXlCeWIyQ01UdXhvbTN4?= =?utf-8?B?NGxaOXlwRE1IMyt5Rk1YQWdsbWJxbVQ0cHJmWWZnVG1OaU1ORXRHVG4vWmgr?= =?utf-8?B?US9DclN0MUM1d1R6Z0Z6VEJ4ZzB0RGlkcjB4NER3RzR0MlBObks1NmZBTWtq?= =?utf-8?B?TEhyYXZOK1dkUFlpSHgzbGlwK1RHaDJ2L25URWNVcUhqWjBzRlZZeENoMFRN?= =?utf-8?B?QWFsQytJSy81ZzJJb2JSd2RBcTlsWmorWTlHTnZNUmNCcWZXQ1pPSldiN1lY?= =?utf-8?B?dEE4ZlhEMkRRUW1DUXdVcW90M2luT2VDYnhNcjFBRTF4MElpdDUybzVOUHFu?= =?utf-8?B?RERWay9iQlFXZ0FQb0pydk90dGlsck9DRGxsRy9ERWUyOUVkMmNJalR0MnRm?= =?utf-8?B?OG1PUEsvMDVPaTdiQmw3RVJtV20vZEhlNDZXbkp3dG5ZUTZjUE52ek51VThV?= =?utf-8?B?MEJyaXlHd0J5ZEZMWHNNSmZyak90RkUwQm05bHd0NHZSSHZ6K0ZjTjljay9t?= =?utf-8?B?elh1ZzVZREpZRVdZblAxNU9jL0VHZjhFRG43N3B0OW8wT0xHcitoWk4xc2I2?= =?utf-8?B?RVZLaG1JZ0dzSTJkbUFGRk1qL3RndWJlUEVvbGp0eDN4cS9YSFJWRldqSEZv?= =?utf-8?B?WjJOekRnZk9qeXVYWHJHZHU1MzhSWngrd3Y5eGMzaEduM2FETzRFNjN1aWY3?= =?utf-8?B?ditKUUErN3BWWUJzUS9iZWROMDVGUkhOOFRzY1JaVFFjaGdvcEh0bWhnOWNU?= =?utf-8?B?QXp0S3dNaGdZN3gyYThOOFRLNlE2RTkyOFBHTFlXbS9FV29YOWs3bGcvK0Fh?= =?utf-8?B?SkI5c1UrWlhRamVTdFF6Y2dVL0wrdCtCdUUyTXYrUGl3V1JpQVNzWklnSEdU?= =?utf-8?B?Z2F5MS9KaTVMV2JHUWVlRGpWM1JGRnliUXkyNm5jRWRhTFBBclpnbzZFVEZN?= =?utf-8?B?ck5oVXA5a0YrOVd2Uno4cEdjLzI1bis2UmZudFFtVW55ZGtRajNQOVVPcytC?= =?utf-8?Q?I6taH1HKawKBuishngmytKhfi?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fee3b09a-2cee-4c02-c211-08db4fbb32d0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 11:56:03.5553 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: M/a0WTVx6eRfsXY8CGCX4ygE797Cnps5lKZ5h0JzGKXbATqV5YNUbVyRO9fS5z8PkCH5qhlOzSIaoEydiZe+7g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7844 On 01.05.2023 21:30, Jason Andryuk wrote: > @@ -67,6 +68,27 @@ void show_help(void) > " set-max-cstate |'unlimited' [|'unlimited']\n" > " set the C-State limitation ( >= 0) and\n" > " optionally the C-sub-state limitation ( >= 0)\n" > + " set-cpufreq-hwp [cpuid] [balance|performance|powersave] *\n" > + " set Hardware P-State (HWP) parameters\n" > + " optionally a preset of one of\n" > + " balance|performance|powersave\n" > + " an optional list of param:val arguments\n" > + " minimum:N lowest ... highest\n" > + " maximum:N lowest ... highest\n" > + " desired:N lowest ... highest\n" Personally I consider these three uses of "lowest ... highest" confusing: It's not clear at all whether they're part of the option or merely mean to express the allowable range for N (which I think they do). Perhaps ... > + " Set explicit performance target.\n" > + " non-zero disables auto-HWP mode.\n" > + " energy-perf:0-255 (or 0-15)\n" ..., also taking this into account: " energy-perf:N (0-255 or 0-15)\n" and then use parentheses as well for the earlier value range explanations (and again below)? Also up from here you suddenly start having full stops on the lines. I guess you also want to be consistent in your use of capital letters at the start of lines (I didn't go check how consistent pre-existing code is in this regard). > @@ -1299,6 +1321,213 @@ void disable_turbo_mode(int argc, char *argv[]) > errno, strerror(errno)); > } > > +/* > + * Parse activity_window:NNN{us,ms,s} and validate range. > + * > + * Activity window is a 7bit mantissa (0-127) with a 3bit exponent (0-7) base > + * 10 in microseconds. So the range is 1 microsecond to 1270 seconds. A value > + * of 0 lets the hardware autonomously select the window. > + * > + * Return 0 on success > + * -1 on error > + */ > +static int parse_activity_window(xc_set_hwp_para_t *set_hwp, unsigned long u, > + const char *suffix) > +{ > + unsigned int exponent = 0; > + unsigned int multiplier = 1; > + > + if ( suffix && suffix[0] ) > + { > + if ( strcasecmp(suffix, "s") == 0 ) > + { > + multiplier = 1000 * 1000; > + exponent = 6; > + } > + else if ( strcasecmp(suffix, "ms") == 0 ) > + { > + multiplier = 1000; > + exponent = 3; > + } > + else if ( strcasecmp(suffix, "us") == 0 ) > + { > + multiplier = 1; > + exponent = 0; > + } Considering the initializers, this "else if" body isn't really needed, and ... > + else ... instead this could become "else if ( strcmp() != 0 )". Note also that I use strcmp() there - none of s, ms, or us are commonly expressed by capital letters. (I wonder though whether μs shouldn't also be recognized.) > + { > + fprintf(stderr, "invalid activity window units: \"%s\"\n", suffix); > + > + return -1; > + } > + } > + > + /* u * multipler > 1270 * 1000 * 1000 transformed to avoid overflow. */ > + if ( u > 1270 * 1000 * 1000 / multiplier ) > + { > + fprintf(stderr, "activity window is too large\n"); > + > + return -1; > + } > + > + /* looking for 7 bits of mantissa and 3 bits of exponent */ > + while ( u > 127 ) > + { > + u += 5; /* Round up to mitigate truncation rounding down > + e.g. 128 -> 120 vs 128 -> 130. */ > + u /= 10; > + exponent += 1; > + } > + > + set_hwp->activity_window = (exponent & HWP_ACT_WINDOW_EXPONENT_MASK) << > + HWP_ACT_WINDOW_EXPONENT_SHIFT | The shift wants parenthesizing against the | and the shift amount wants indenting slightly less. (Really this would want to be MASK_INSR().) > + (u & HWP_ACT_WINDOW_MANTISSA_MASK); > + set_hwp->set_params |= XEN_SYSCTL_HWP_SET_ACT_WINDOW; > + > + return 0; > +} > + > +static int parse_hwp_opts(xc_set_hwp_para_t *set_hwp, int *cpuid, > + int argc, char *argv[]) > +{ > + int i = 0; > + > + if ( argc < 1 ) { > + fprintf(stderr, "Missing arguments\n"); > + return -1; > + } > + > + if ( parse_cpuid_non_fatal(argv[i], cpuid) == 0 ) > + { > + i++; > + } I don't think you need the earlier patch and the separate helper: Whether a CPU number is present can be told by checking isdigit(argv[i][0]). Also (nit) note how you're mixing brace placement throughout this function. Jan From xen-devel-bounces@lists.xenproject.org Mon May 08 11:57:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 11:57:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531436.827125 (Exim 4.92) (envelope-from ) id 1pvzUu-0002lX-O7; Mon, 08 May 2023 11:57:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531436.827125; Mon, 08 May 2023 11:57:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzUu-0002j5-F6; Mon, 08 May 2023 11:57:44 +0000 Received: by outflank-mailman (input) for mailman id 531436; Mon, 08 May 2023 11:57:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzMF-0004FA-N4 for xen-devel@lists.xenproject.org; Mon, 08 May 2023 11:48:47 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4a9abe30-ed96-11ed-b226-6b7b168915f2; Mon, 08 May 2023 13:48:47 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EF49B21D1E; Mon, 8 May 2023 11:48:46 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C037C1346B; Mon, 8 May 2023 11:48:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4nikLZ7hWGRbNwAAMHmgww (envelope-from ); Mon, 08 May 2023 11:48:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a9abe30-ed96-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683546526; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mnbpAA3QXKNUb/jFQV/tu/cKYwrbS8V5R6aaB8qSn9w=; b=k1qGxR8D1soRWuKzMkIo7SCy0iOrTAzKydaicZsfSJ0WLR2XbBA+fbli+PcJ37z+8CMwWc p5dLNvt6OycJ7CkuPZUkeX0b8ZSFMF1gqhFG3gucESij+n7k0ca5kGXhMYaDMZhsWutWUJ NU5FBPgE/nx3LHn6PySQ2RiAGrmEJkg= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD , Julien Grall Subject: [PATCH v5 09/14] tools/xenstore: add TDB access trace support Date: Mon, 8 May 2023 13:47:49 +0200 Message-Id: <20230508114754.31514-10-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230508114754.31514-1-jgross@suse.com> References: <20230508114754.31514-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a new trace switch "tdb" and the related trace calls. The "tdb" switch is off per default. Signed-off-by: Juergen Gross Reviewed-by: Julien Grall --- tools/xenstore/xenstored_core.c | 8 +++++++- tools/xenstore/xenstored_core.h | 7 +++++++ tools/xenstore/xenstored_transaction.c | 7 ++++++- 3 files changed, 20 insertions(+), 2 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 15654730a6..3caf9e45dc 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -589,6 +589,8 @@ static void get_acc_data(TDB_DATA *key, struct node_account_data *acc) if (old_data.dptr == NULL) { acc->memory = 0; } else { + trace_tdb("read %s size %zu\n", key->dptr, + old_data.dsize + key->dsize); hdr = (void *)old_data.dptr; acc->memory = old_data.dsize; acc->domid = hdr->perms[0].id; @@ -655,6 +657,7 @@ int do_tdb_write(struct connection *conn, TDB_DATA *key, TDB_DATA *data, errno = EIO; return errno; } + trace_tdb("store %s size %zu\n", key->dptr, data->dsize + key->dsize); if (acc) { /* Don't use new_domid, as it might be a transaction node. */ @@ -682,6 +685,7 @@ int do_tdb_delete(struct connection *conn, TDB_DATA *key, errno = EIO; return errno; } + trace_tdb("delete %s\n", key->dptr); if (acc->memory) { domid = get_acc_domid(conn, key, acc->domid); @@ -731,6 +735,8 @@ struct node *read_node(struct connection *conn, const void *ctx, goto error; } + trace_tdb("read %s size %zu\n", key.dptr, data.dsize + key.dsize); + node->parent = NULL; talloc_steal(node, data.dptr); @@ -2750,7 +2756,7 @@ static void set_quota(const char *arg, bool soft) /* Sorted by bit values of TRACE_* flags. Flag is (1u << index). */ const char *const trace_switches[] = { - "obj", "io", "wrl", "acc", + "obj", "io", "wrl", "acc", "tdb", NULL }; diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h index 3e0734a6c6..5a11dc1231 100644 --- a/tools/xenstore/xenstored_core.h +++ b/tools/xenstore/xenstored_core.h @@ -303,9 +303,16 @@ extern unsigned int trace_flags; #define TRACE_IO 0x00000002 #define TRACE_WRL 0x00000004 #define TRACE_ACC 0x00000008 +#define TRACE_TDB 0x00000010 extern const char *const trace_switches[]; int set_trace_switch(const char *arg); +#define trace_tdb(...) \ +do { \ + if (trace_flags & TRACE_TDB) \ + trace("tdb: " __VA_ARGS__); \ +} while (0) + extern TDB_CONTEXT *tdb_ctx; extern int dom0_domid; extern int dom0_event; diff --git a/tools/xenstore/xenstored_transaction.c b/tools/xenstore/xenstored_transaction.c index 2b15506953..11c8bcec84 100644 --- a/tools/xenstore/xenstored_transaction.c +++ b/tools/xenstore/xenstored_transaction.c @@ -374,8 +374,11 @@ static int finalize_transaction(struct connection *conn, if (tdb_error(tdb_ctx) != TDB_ERR_NOEXIST) return EIO; gen = NO_GENERATION; - } else + } else { + trace_tdb("read %s size %zu\n", key.dptr, + key.dsize + data.dsize); gen = hdr->generation; + } talloc_free(data.dptr); if (i->generation != gen) return EAGAIN; @@ -399,6 +402,8 @@ static int finalize_transaction(struct connection *conn, set_tdb_key(i->trans_name, &ta_key); data = tdb_fetch(tdb_ctx, ta_key); if (data.dptr) { + trace_tdb("read %s size %zu\n", ta_key.dptr, + ta_key.dsize + data.dsize); hdr = (void *)data.dptr; hdr->generation = ++generation; *is_corrupt |= do_tdb_write(conn, &key, &data, -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon May 08 11:57:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 11:57:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531434.827120 (Exim 4.92) (envelope-from ) id 1pvzUu-0002hl-Ds; Mon, 08 May 2023 11:57:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531434.827120; Mon, 08 May 2023 11:57:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzUu-0002h7-7A; Mon, 08 May 2023 11:57:44 +0000 Received: by outflank-mailman (input) for mailman id 531434; Mon, 08 May 2023 11:57:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzMY-00040G-8w for xen-devel@lists.xenproject.org; Mon, 08 May 2023 11:49:06 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 54e40935-ed96-11ed-8611-37d641c3527e; Mon, 08 May 2023 13:49:04 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 434BC21CC2; Mon, 8 May 2023 11:49:04 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1772D1346B; Mon, 8 May 2023 11:49:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id bsVJBLDhWGSDNwAAMHmgww (envelope-from ); Mon, 08 May 2023 11:49:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 54e40935-ed96-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683546544; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ogLX0B6M+gJkDXPcurjCLFiofA0y8aWlvBWQPF5qvcM=; b=V6Lyts8dgLZRyxGTgTpMKz66OzBRVvAH1I7MRu+X6/1dIq3Yor9W9kSsoz2VuXFfjqhvsR cBdtb9woXuq3GWKLoFTxclRzMXp6JtP6OTyavx4f0YlteV2DAdZOGsEADsCZWQBrpJ/Dmk MDmEGhVWPry+LGhX4P9DXE9WXAmY5c0= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH v5 12/14] tools/xenstore: use generic accounting for remaining quotas Date: Mon, 8 May 2023 13:47:52 +0200 Message-Id: <20230508114754.31514-13-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230508114754.31514-1-jgross@suse.com> References: <20230508114754.31514-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The maxrequests, node size, number of node permissions, and path length quota are a little bit special, as they are either active in transactions only (maxrequests), or they are just per item instead of count values. Nevertheless being able to know the maximum number of those quota related values per domain would be beneficial, so add them to the generic accounting. The per domain value will never show current numbers other than zero, but the maximum number seen can be gathered the same way as the number of nodes during a transaction. To be able to use the const qualifier for a new function switch domain_is_unprivileged() to take a const pointer, too. For printing the quota/max values, adapt the print format string to the longest quota name (now 17 characters long). Signed-off-by: Juergen Gross --- V5: - add comment (Julien Grall) - add missing quota printing (Julien Grall) --- tools/xenstore/xenstored_core.c | 15 +++++---- tools/xenstore/xenstored_core.h | 2 +- tools/xenstore/xenstored_domain.c | 45 +++++++++++++++++++++----- tools/xenstore/xenstored_domain.h | 6 ++++ tools/xenstore/xenstored_transaction.c | 4 +-- tools/xenstore/xenstored_watch.c | 2 +- 6 files changed, 55 insertions(+), 19 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index c98d30561f..fce73b883e 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -799,8 +799,9 @@ int write_node_raw(struct connection *conn, TDB_DATA *key, struct node *node, + node->perms.num * sizeof(node->perms.p[0]) + node->datalen + node->childlen; - if (!no_quota_check && domain_is_unprivileged(conn) && - data.dsize >= quota_max_entry_size) { + /* Call domain_max_chk() in any case in order to record max values. */ + if (domain_max_chk(conn, ACC_NODESZ, data.dsize, quota_max_entry_size) + && !no_quota_check) { errno = ENOSPC; return errno; } @@ -1170,7 +1171,7 @@ static bool valid_chars(const char *node) "0123456789-/_@") == strlen(node)); } -bool is_valid_nodename(const char *node) +bool is_valid_nodename(const struct connection *conn, const char *node) { int local_off = 0; unsigned int domid; @@ -1190,7 +1191,8 @@ bool is_valid_nodename(const char *node) if (sscanf(node, "/local/domain/%5u/%n", &domid, &local_off) != 1) local_off = 0; - if (strlen(node) > local_off + quota_max_path_len) + if (domain_max_chk(conn, ACC_PATHLEN, strlen(node) - local_off, + quota_max_path_len)) return false; return valid_chars(node); @@ -1252,7 +1254,7 @@ static struct node *get_node_canonicalized(struct connection *conn, *canonical_name = canonicalize(conn, ctx, name); if (!*canonical_name) return NULL; - if (!is_valid_nodename(*canonical_name)) { + if (!is_valid_nodename(conn, *canonical_name)) { errno = EINVAL; return NULL; } @@ -1778,8 +1780,7 @@ static int do_set_perms(const void *ctx, struct connection *conn, return EINVAL; perms.num--; - if (domain_is_unprivileged(conn) && - perms.num > quota_nb_perms_per_node) + if (domain_max_chk(conn, ACC_NPERM, perms.num, quota_nb_perms_per_node)) return ENOSPC; permstr = in->buffer + strlen(in->buffer) + 1; diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h index 3564d85d7d..9339820156 100644 --- a/tools/xenstore/xenstored_core.h +++ b/tools/xenstore/xenstored_core.h @@ -258,7 +258,7 @@ void check_store(void); void corrupt(struct connection *conn, const char *fmt, ...); /* Is this a valid node name? */ -bool is_valid_nodename(const char *node); +bool is_valid_nodename(const struct connection *conn, const char *node); /* Get name of parent node. */ char *get_parent(const void *ctx, const char *node); diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 6f3a27765a..b3a719569e 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -431,7 +431,7 @@ int domain_get_quota(const void *ctx, struct connection *conn, return ENOMEM; #define ent(t, e) \ - resp = talloc_asprintf_append(resp, "%-16s: %8u (max: %8u\n", #t, \ + resp = talloc_asprintf_append(resp, "%-17s: %8u (max: %8u\n", #t, \ d->acc[e].val, d->acc[e].max); \ if (!resp) return ENOMEM @@ -440,6 +440,10 @@ int domain_get_quota(const void *ctx, struct connection *conn, ent(transactions, ACC_TRANS); ent(outstanding, ACC_OUTST); ent(memory, ACC_MEM); + ent(transaction-nodes, ACC_TRANSNODES); + ent(node-permissions, ACC_NPERM); + ent(path-length, ACC_PATHLEN); + ent(node-size, ACC_NODESZ); #undef ent @@ -457,7 +461,7 @@ int domain_max_global_acc(const void *ctx, struct connection *conn) return ENOMEM; #define ent(t, e) \ - resp = talloc_asprintf_append(resp, "%-16s: %8u\n", #t, \ + resp = talloc_asprintf_append(resp, "%-17s: %8u\n", #t, \ acc_global_max[e]); \ if (!resp) return ENOMEM @@ -466,6 +470,10 @@ int domain_max_global_acc(const void *ctx, struct connection *conn) ent(transactions, ACC_TRANS); ent(outstanding, ACC_OUTST); ent(memory, ACC_MEM); + ent(transaction-nodes, ACC_TRANSNODES); + ent(node-permissions, ACC_NPERM); + ent(path-length, ACC_PATHLEN); + ent(node-size, ACC_NODESZ); #undef ent @@ -1079,12 +1087,22 @@ int domain_adjust_node_perms(struct node *node) return 0; } +static void domain_acc_valid_max(struct domain *d, enum accitem what, + unsigned int val) +{ + assert(what < ARRAY_SIZE(d->acc)); + assert(what < ARRAY_SIZE(acc_global_max)); + + if (val > d->acc[what].max) + d->acc[what].max = val; + if (val > acc_global_max[what] && domid_is_unprivileged(d->domid)) + acc_global_max[what] = val; +} + static int domain_acc_add_valid(struct domain *d, enum accitem what, int add) { unsigned int val; - assert(what < ARRAY_SIZE(d->acc)); - if ((add < 0 && -add > d->acc[what].val) || (add > 0 && (INT_MAX - d->acc[what].val) < add)) { /* @@ -1098,10 +1116,7 @@ static int domain_acc_add_valid(struct domain *d, enum accitem what, int add) } val = d->acc[what].val + add; - if (val > d->acc[what].max) - d->acc[what].max = val; - if (val > acc_global_max[what] && domid_is_unprivileged(d->domid)) - acc_global_max[what] = val; + domain_acc_valid_max(d, what, val); return val; } @@ -1222,6 +1237,20 @@ void domain_reset_global_acc(void) hashtable_iterate(domhash, domain_reset_global_acc_sub, NULL); } +bool domain_max_chk(const struct connection *conn, enum accitem what, + unsigned int val, unsigned int quota) +{ + if (!conn || !conn->domain) + return false; + + if (domain_is_unprivileged(conn) && val > quota) + return true; + + domain_acc_valid_max(conn->domain, what, val); + + return false; +} + int domain_nbentry_inc(struct connection *conn, unsigned int domid) { return (domain_acc_add(conn, domid, ACC_NODES, 1, false) < 0) diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index 416df25cb2..78ca434531 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -33,6 +33,10 @@ enum accitem { ACC_OUTST, ACC_MEM, ACC_TRANS, + ACC_TRANSNODES, + ACC_NPERM, + ACC_PATHLEN, + ACC_NODESZ, ACC_N, /* Number of elements per domain. */ }; @@ -129,6 +133,8 @@ void acc_drop(struct connection *conn); void acc_commit(struct connection *conn); int domain_max_global_acc(const void *ctx, struct connection *conn); void domain_reset_global_acc(void); +bool domain_max_chk(const struct connection *conn, unsigned int what, + unsigned int val, unsigned int quota); /* Write rate limiting */ diff --git a/tools/xenstore/xenstored_transaction.c b/tools/xenstore/xenstored_transaction.c index b9e9d76a1f..cecaf27018 100644 --- a/tools/xenstore/xenstored_transaction.c +++ b/tools/xenstore/xenstored_transaction.c @@ -252,8 +252,8 @@ int access_node(struct connection *conn, struct node *node, i = find_accessed_node(trans, node->name); if (!i) { - if (trans->nodes >= quota_trans_nodes && - domain_is_unprivileged(conn)) { + if (domain_max_chk(conn, ACC_TRANSNODES, trans->nodes + 1, + quota_trans_nodes)) { ret = ENOSPC; goto err; } diff --git a/tools/xenstore/xenstored_watch.c b/tools/xenstore/xenstored_watch.c index e30cd89be3..61b1e3421e 100644 --- a/tools/xenstore/xenstored_watch.c +++ b/tools/xenstore/xenstored_watch.c @@ -176,7 +176,7 @@ static int check_watch_path(struct connection *conn, const void *ctx, *path = canonicalize(conn, ctx, *path); if (!*path) return errno; - if (!is_valid_nodename(*path)) + if (!is_valid_nodename(conn, *path)) goto inval; } -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon May 08 11:57:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 11:57:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531433.827115 (Exim 4.92) (envelope-from ) id 1pvzUu-0002gU-3R; Mon, 08 May 2023 11:57:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531433.827115; Mon, 08 May 2023 11:57:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzUu-0002gN-01; Mon, 08 May 2023 11:57:44 +0000 Received: by outflank-mailman (input) for mailman id 531433; Mon, 08 May 2023 11:57:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzMU-00040G-26 for xen-devel@lists.xenproject.org; Mon, 08 May 2023 11:49:02 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 518ed7b4-ed96-11ed-8611-37d641c3527e; Mon, 08 May 2023 13:48:58 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A6B5722029; Mon, 8 May 2023 11:48:58 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 621971346B; Mon, 8 May 2023 11:48:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id IFMzFqrhWGR5NwAAMHmgww (envelope-from ); Mon, 08 May 2023 11:48:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 518ed7b4-ed96-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683546538; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ia066ss6DTXiD5PD3QIOik+sQxxMkgbmr/cEVOihzyk=; b=CScXZUnssTNF4jzDhv0ru86vmo6122s8dsxArWVZLUi2HAWvKivd4TB0bHXt51GFAoXo3e 7LB03/jCVyCxkYCturVvFvefbDlabxEZg/tAWXm0lGer1oHcPOaQvdf1vMj/GOckHAfyzq sDNnSjCTg94CI6JvTLR3ysy/h84IiRc= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Anthony PERARD , Julien Grall Subject: [PATCH v5 11/14] tools/xenstore: remember global and per domain max accounting values Date: Mon, 8 May 2023 13:47:51 +0200 Message-Id: <20230508114754.31514-12-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230508114754.31514-1-jgross@suse.com> References: <20230508114754.31514-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add saving the maximum values of the different accounting data seen per domain and (for unprivileged domains) globally, and print those values via the xenstore-control quota command. Add a sub-command for resetting the global maximum values seen. This should help for a decision how to set the related quotas. Signed-off-by: Juergen Gross Reviewed-by: Julien Grall --- docs/misc/xenstore.txt | 5 +- tools/xenstore/xenstored_control.c | 22 ++++++- tools/xenstore/xenstored_domain.c | 100 +++++++++++++++++++++++------ tools/xenstore/xenstored_domain.h | 2 + 4 files changed, 108 insertions(+), 21 deletions(-) diff --git a/docs/misc/xenstore.txt b/docs/misc/xenstore.txt index d807ef0709..38015835b1 100644 --- a/docs/misc/xenstore.txt +++ b/docs/misc/xenstore.txt @@ -426,7 +426,7 @@ CONTROL |[|] print| print to syslog (xenstore runs as daemon) or to console (xenstore runs as stubdom) - quota|[set |] + quota|[set ||max [-r]] without parameters: print the current quota settings with "set ": set the quota to new value (The admin should make sure all the domain usage is @@ -435,6 +435,9 @@ CONTROL |[|] violating the new quota setting isn't increased further) with "": print quota related accounting data for the domain + with "max [-r]": show global per-domain maximum values of all + unprivileged domains, optionally reset the values by adding + "-r" quota-soft|[set ] like the "quota" command, but for soft-quota. help diff --git a/tools/xenstore/xenstored_control.c b/tools/xenstore/xenstored_control.c index 403295788a..620a7da997 100644 --- a/tools/xenstore/xenstored_control.c +++ b/tools/xenstore/xenstored_control.c @@ -306,6 +306,22 @@ static int quota_get(const void *ctx, struct connection *conn, return domain_get_quota(ctx, conn, atoi(vec[0])); } +static int quota_max(const void *ctx, struct connection *conn, + char **vec, int num) +{ + if (num > 1) + return EINVAL; + + if (num == 1) { + if (!strcmp(vec[0], "-r")) + domain_reset_global_acc(); + else + return EINVAL; + } + + return domain_max_global_acc(ctx, conn); +} + static int do_control_quota(const void *ctx, struct connection *conn, char **vec, int num) { @@ -315,6 +331,9 @@ static int do_control_quota(const void *ctx, struct connection *conn, if (!strcmp(vec[0], "set")) return quota_set(ctx, conn, vec + 1, num - 1, hard_quotas); + if (!strcmp(vec[0], "max")) + return quota_max(ctx, conn, vec + 1, num - 1); + return quota_get(ctx, conn, vec, num); } @@ -978,7 +997,8 @@ static struct cmd_s cmds[] = { { "memreport", do_control_memreport, "[]" }, #endif { "print", do_control_print, "" }, - { "quota", do_control_quota, "[set |]" }, + { "quota", do_control_quota, + "[set ||max [-r]]" }, { "quota-soft", do_control_quota_s, "[set ]" }, { "help", do_control_help, "" }, }; diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 25c6d20036..6f3a27765a 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -43,6 +43,8 @@ static evtchn_port_t virq_port; xenevtchn_handle *xce_handle = NULL; +static unsigned int acc_global_max[ACC_N]; + struct domain { /* The id of this domain */ @@ -70,7 +72,10 @@ struct domain bool introduced; /* Accounting data for this domain. */ - unsigned int acc[ACC_N]; + struct acc { + unsigned int val; + unsigned int max; + } acc[ACC_N]; /* Memory quota data for this domain. */ bool soft_quota_reported; @@ -199,9 +204,9 @@ static bool domain_can_read(struct connection *conn) if (domain_is_unprivileged(conn)) { if (domain->wrl_credit < 0) return false; - if (domain->acc[ACC_OUTST] >= quota_req_outstanding) + if (domain->acc[ACC_OUTST].val >= quota_req_outstanding) return false; - if (domain->acc[ACC_MEM] >= quota_memory_per_domain_hard && + if (domain->acc[ACC_MEM].val >= quota_memory_per_domain_hard && quota_memory_per_domain_hard) return false; } @@ -264,7 +269,7 @@ static int domain_tree_remove_sub(const void *ctx, struct connection *conn, ret = WALK_TREE_SKIP_CHILDREN; } - return domain->acc[ACC_NODES] ? ret : WALK_TREE_SUCCESS_STOP; + return domain->acc[ACC_NODES].val ? ret : WALK_TREE_SUCCESS_STOP; } static void domain_tree_remove(struct domain *domain) @@ -272,7 +277,7 @@ static void domain_tree_remove(struct domain *domain) int ret; struct walk_funcs walkfuncs = { .enter = domain_tree_remove_sub }; - if (domain->acc[ACC_NODES]) { + if (domain->acc[ACC_NODES].val) { ret = walk_node_tree(domain, NULL, "/", &walkfuncs, domain); if (ret == WALK_TREE_ERROR_STOP) syslog(LOG_ERR, @@ -426,14 +431,41 @@ int domain_get_quota(const void *ctx, struct connection *conn, return ENOMEM; #define ent(t, e) \ - resp = talloc_asprintf_append(resp, "%-16s: %8d\n", #t, e); \ + resp = talloc_asprintf_append(resp, "%-16s: %8u (max: %8u\n", #t, \ + d->acc[e].val, d->acc[e].max); \ + if (!resp) return ENOMEM + + ent(nodes, ACC_NODES); + ent(watches, ACC_WATCH); + ent(transactions, ACC_TRANS); + ent(outstanding, ACC_OUTST); + ent(memory, ACC_MEM); + +#undef ent + + send_reply(conn, XS_CONTROL, resp, strlen(resp) + 1); + + return 0; +} + +int domain_max_global_acc(const void *ctx, struct connection *conn) +{ + char *resp; + + resp = talloc_asprintf(ctx, "Max. seen accounting values:\n"); + if (!resp) + return ENOMEM; + +#define ent(t, e) \ + resp = talloc_asprintf_append(resp, "%-16s: %8u\n", #t, \ + acc_global_max[e]); \ if (!resp) return ENOMEM - ent(nodes, d->acc[ACC_NODES]); - ent(watches, d->acc[ACC_WATCH]); - ent(transactions, d->acc[ACC_TRANS]); - ent(outstanding, d->acc[ACC_OUTST]); - ent(memory, d->acc[ACC_MEM]); + ent(nodes, ACC_NODES); + ent(watches, ACC_WATCH); + ent(transactions, ACC_TRANS); + ent(outstanding, ACC_OUTST); + ent(memory, ACC_MEM); #undef ent @@ -1049,10 +1081,12 @@ int domain_adjust_node_perms(struct node *node) static int domain_acc_add_valid(struct domain *d, enum accitem what, int add) { + unsigned int val; + assert(what < ARRAY_SIZE(d->acc)); - if ((add < 0 && -add > d->acc[what]) || - (add > 0 && (INT_MAX - d->acc[what]) < add)) { + if ((add < 0 && -add > d->acc[what].val) || + (add > 0 && (INT_MAX - d->acc[what].val) < add)) { /* * In a transaction when a node is being added/removed AND the * same node has been added/removed outside the transaction in @@ -1063,7 +1097,13 @@ static int domain_acc_add_valid(struct domain *d, enum accitem what, int add) return (add < 0) ? 0 : INT_MAX; } - return d->acc[what] + add; + val = d->acc[what].val + add; + if (val > d->acc[what].max) + d->acc[what].max = val; + if (val > acc_global_max[what] && domid_is_unprivileged(d->domid)) + acc_global_max[what] = val; + + return val; } static int domain_acc_add(struct connection *conn, unsigned int domid, @@ -1119,10 +1159,10 @@ static int domain_acc_add(struct connection *conn, unsigned int domid, } trace_acc("global change domid %u: what=%u %u add %d\n", domid, what, - d->acc[what], add); - d->acc[what] = domain_acc_add_valid(d, what, add); + d->acc[what].val, add); + d->acc[what].val = domain_acc_add_valid(d, what, add); - return d->acc[what]; + return d->acc[what].val; } void acc_drop(struct connection *conn) @@ -1160,6 +1200,28 @@ void acc_commit(struct connection *conn) conn->in = in; } +static int domain_reset_global_acc_sub(const void *k, void *v, void *arg) +{ + struct domain *d = v; + unsigned int i; + + for (i = 0; i < ACC_N; i++) + d->acc[i].max = d->acc[i].val; + + return 0; +} + +void domain_reset_global_acc(void) +{ + unsigned int i; + + for (i = 0; i < ACC_N; i++) + acc_global_max[i] = 0; + + /* Set current max values seen. */ + hashtable_iterate(domhash, domain_reset_global_acc_sub, NULL); +} + int domain_nbentry_inc(struct connection *conn, unsigned int domid) { return (domain_acc_add(conn, domid, ACC_NODES, 1, false) < 0) @@ -1660,7 +1722,7 @@ static int domain_check_acc_init_sub(const void *k, void *v, void *arg) * If everything is correct incrementing the value for each node will * result in dom->nodes being 0 at the end. */ - dom->nodes = -d->acc[ACC_NODES]; + dom->nodes = -d->acc[ACC_NODES].val; if (!hashtable_insert(domains, &dom->domid, dom)) { talloc_free(dom); @@ -1715,7 +1777,7 @@ static int domain_check_acc_cb(const void *k, void *v, void *arg) if (!d) return 0; - d->acc[ACC_NODES] += dom->nodes; + d->acc[ACC_NODES].val += dom->nodes; return 0; } diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index 01b6f1861b..416df25cb2 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -127,6 +127,8 @@ int domain_get_quota(const void *ctx, struct connection *conn, int acc_fix_domains(struct list_head *head, bool chk_quota, bool update); void acc_drop(struct connection *conn); void acc_commit(struct connection *conn); +int domain_max_global_acc(const void *ctx, struct connection *conn); +void domain_reset_global_acc(void); /* Write rate limiting */ -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon May 08 11:57:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 11:57:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531441.827133 (Exim 4.92) (envelope-from ) id 1pvzUv-0002xC-5c; Mon, 08 May 2023 11:57:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531441.827133; Mon, 08 May 2023 11:57:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzUu-0002ui-W3; Mon, 08 May 2023 11:57:44 +0000 Received: by outflank-mailman (input) for mailman id 531441; Mon, 08 May 2023 11:57:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzMc-0004FA-L0 for xen-devel@lists.xenproject.org; Mon, 08 May 2023 11:49:10 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 583cc118-ed96-11ed-b226-6b7b168915f2; Mon, 08 May 2023 13:49:10 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D0FD921FBD; Mon, 8 May 2023 11:49:09 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A49951346B; Mon, 8 May 2023 11:49:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id G+OqJrXhWGSUNwAAMHmgww (envelope-from ); Mon, 08 May 2023 11:49:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 583cc118-ed96-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683546549; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/kKszQ9GbTiBVpwvUDCT+QKEBlgA1iwA78V+6Rsue9o=; b=Em0i6C0a8i6U1/nWs5J9ugR/q0r/fa7JqrQ5wQ3y7DNWAwJXeJhqSVhWQ2U0HAX3wLvGus ZIaD2Yf3zxLnHmMiZBhflv6MPzYaZXVhWISdDyu6sl//n9FqMvqz8kOYueOPd9H5CtVcK/ 08qnxiY9NM7rXbwhFD79fE2SeKszQv0= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH v5 13/14] tools/xenstore: switch get_optval_int() to get_optval_uint() Date: Mon, 8 May 2023 13:47:53 +0200 Message-Id: <20230508114754.31514-14-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230508114754.31514-1-jgross@suse.com> References: <20230508114754.31514-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Let get_optval_int() return an unsigned value and rename it accordingly. Signed-off-by: Juergen Gross --- V5: - new patch, carved out from next patch in series (Julien Grall) --- tools/xenstore/xenstored_core.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index fce73b883e..86ec7ab446 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -2700,13 +2700,13 @@ int dom0_domid = 0; int dom0_event = 0; int priv_domid = 0; -static int get_optval_int(const char *arg) +static unsigned int get_optval_uint(const char *arg) { char *end; - long val; + unsigned long val; - val = strtol(arg, &end, 10); - if (!*arg || *end || val < 0 || val > INT_MAX) + val = strtoul(arg, &end, 10); + if (!*arg || *end || val > INT_MAX) barf("invalid parameter value \"%s\"\n", arg); return val; @@ -2726,7 +2726,7 @@ static void set_timeout(const char *arg) if (!eq) barf("quotas must be specified via =\n"); - val = get_optval_int(eq + 1); + val = get_optval_uint(eq + 1); if (what_matches(arg, "watch-event")) timeout_watch_event_msec = val * 1000; else @@ -2740,7 +2740,7 @@ static void set_quota(const char *arg, bool soft) if (!eq) barf("quotas must be specified via =\n"); - val = get_optval_int(eq + 1); + val = get_optval_uint(eq + 1); if (what_matches(arg, "outstanding") && !soft) quota_req_outstanding = val; else if (what_matches(arg, "transaction-nodes") && !soft) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon May 08 11:57:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 11:57:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531445.827140 (Exim 4.92) (envelope-from ) id 1pvzUv-00035p-KY; Mon, 08 May 2023 11:57:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531445.827140; Mon, 08 May 2023 11:57:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzUv-00033Q-9F; Mon, 08 May 2023 11:57:45 +0000 Received: by outflank-mailman (input) for mailman id 531445; Mon, 08 May 2023 11:57:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzMi-0004FA-TZ for xen-devel@lists.xenproject.org; Mon, 08 May 2023 11:49:17 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5b98b6ad-ed96-11ed-b226-6b7b168915f2; Mon, 08 May 2023 13:49:15 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 74E341FE43; Mon, 8 May 2023 11:49:15 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 461631346B; Mon, 8 May 2023 11:49:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id HLQAD7vhWGSvNwAAMHmgww (envelope-from ); Mon, 08 May 2023 11:49:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5b98b6ad-ed96-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683546555; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dcmeTEE9hVukRZJ0Dtyrk1eYeEJPS+eKlkdJh/h3FLo=; b=foQkqBNjW2yrIkKI/yb0yX2ZvZMZAlx7enzUVKzYjJUOtgnVknvq3iR4Cygv5DabFBLefC HTmKPZI7+zD+J8O/25xMjwx/1Yl8H/WPK3yyaf8/zkYhOQ4u0wlQe6gDDW8IUJUZosN1X4 dAqYVbDZvlZg/eWYNa92WNjn4wkXJqA= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH v5 14/14] tools/xenstore: switch quota management to be table based Date: Mon, 8 May 2023 13:47:54 +0200 Message-Id: <20230508114754.31514-15-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230508114754.31514-1-jgross@suse.com> References: <20230508114754.31514-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of having individual quota variables switch to a table based approach like the generic accounting. Include all the related data in the same table and add accessor functions. This enables to use the command line --quota parameter for setting all possible quota values, keeping the previous parameters for compatibility. Signed-off-by: Juergen Gross --- V2: - new patch One further remark: it would be rather easy to add soft-quota for all the other quotas (similar to the memory one). This could be used as an early warning for the need to raise global quota. V5: - fix what_matches() (Julien Grall) --- tools/xenstore/xenstored_control.c | 43 ++------ tools/xenstore/xenstored_core.c | 80 +++++++------- tools/xenstore/xenstored_core.h | 10 -- tools/xenstore/xenstored_domain.c | 138 ++++++++++++++++--------- tools/xenstore/xenstored_domain.h | 12 ++- tools/xenstore/xenstored_transaction.c | 5 +- tools/xenstore/xenstored_watch.c | 2 +- 7 files changed, 152 insertions(+), 138 deletions(-) diff --git a/tools/xenstore/xenstored_control.c b/tools/xenstore/xenstored_control.c index 620a7da997..ed80924ee4 100644 --- a/tools/xenstore/xenstored_control.c +++ b/tools/xenstore/xenstored_control.c @@ -221,35 +221,6 @@ static int do_control_log(const void *ctx, struct connection *conn, return 0; } -struct quota { - const char *name; - int *quota; - const char *descr; -}; - -static const struct quota hard_quotas[] = { - { "nodes", "a_nb_entry_per_domain, "Nodes per domain" }, - { "watches", "a_nb_watch_per_domain, "Watches per domain" }, - { "transactions", "a_max_transaction, "Transactions per domain" }, - { "outstanding", "a_req_outstanding, - "Outstanding requests per domain" }, - { "transaction-nodes", "a_trans_nodes, - "Max. number of accessed nodes per transaction" }, - { "memory", "a_memory_per_domain_hard, - "Total Xenstore memory per domain (error level)" }, - { "node-size", "a_max_entry_size, "Max. size of a node" }, - { "path-max", "a_max_path_len, "Max. length of a node path" }, - { "permissions", "a_nb_perms_per_node, - "Max. number of permissions per node" }, - { NULL, NULL, NULL } -}; - -static const struct quota soft_quotas[] = { - { "memory", "a_memory_per_domain_soft, - "Total Xenstore memory per domain (warning level)" }, - { NULL, NULL, NULL } -}; - static int quota_show_current(const void *ctx, struct connection *conn, const struct quota *quotas) { @@ -260,9 +231,11 @@ static int quota_show_current(const void *ctx, struct connection *conn, if (!resp) return ENOMEM; - for (i = 0; quotas[i].quota; i++) { + for (i = 0; i < ACC_N; i++) { + if (!quotas[i].name) + continue; resp = talloc_asprintf_append(resp, "%-17s: %8d %s\n", - quotas[i].name, *quotas[i].quota, + quotas[i].name, quotas[i].val, quotas[i].descr); if (!resp) return ENOMEM; @@ -274,7 +247,7 @@ static int quota_show_current(const void *ctx, struct connection *conn, } static int quota_set(const void *ctx, struct connection *conn, - char **vec, int num, const struct quota *quotas) + char **vec, int num, struct quota *quotas) { unsigned int i; int val; @@ -286,9 +259,9 @@ static int quota_set(const void *ctx, struct connection *conn, if (val < 1) return EINVAL; - for (i = 0; quotas[i].quota; i++) { - if (!strcmp(vec[0], quotas[i].name)) { - *quotas[i].quota = val; + for (i = 0; i < ACC_N; i++) { + if (quotas[i].name && !strcmp(vec[0], quotas[i].name)) { + quotas[i].val = val; send_ack(conn, XS_CONTROL); return 0; } diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 86ec7ab446..4ebb75e5e9 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -89,17 +89,6 @@ unsigned int trace_flags = TRACE_OBJ | TRACE_IO; static const char *sockmsg_string(enum xsd_sockmsg_type type); -int quota_nb_entry_per_domain = 1000; -int quota_nb_watch_per_domain = 128; -int quota_max_entry_size = 2048; /* 2K */ -int quota_max_transaction = 10; -int quota_nb_perms_per_node = 5; -int quota_trans_nodes = 1024; -int quota_max_path_len = XENSTORE_REL_PATH_MAX; -int quota_req_outstanding = 20; -int quota_memory_per_domain_soft = 2 * 1024 * 1024; /* 2 MB */ -int quota_memory_per_domain_hard = 2 * 1024 * 1024 + 512 * 1024; /* 2.5 MB */ - unsigned int timeout_watch_event_msec = 20000; void trace(const char *fmt, ...) @@ -800,8 +789,7 @@ int write_node_raw(struct connection *conn, TDB_DATA *key, struct node *node, + node->datalen + node->childlen; /* Call domain_max_chk() in any case in order to record max values. */ - if (domain_max_chk(conn, ACC_NODESZ, data.dsize, quota_max_entry_size) - && !no_quota_check) { + if (domain_max_chk(conn, ACC_NODESZ, data.dsize) && !no_quota_check) { errno = ENOSPC; return errno; } @@ -1191,8 +1179,7 @@ bool is_valid_nodename(const struct connection *conn, const char *node) if (sscanf(node, "/local/domain/%5u/%n", &domid, &local_off) != 1) local_off = 0; - if (domain_max_chk(conn, ACC_PATHLEN, strlen(node) - local_off, - quota_max_path_len)) + if (domain_max_chk(conn, ACC_PATHLEN, strlen(node) - local_off)) return false; return valid_chars(node); @@ -1504,7 +1491,7 @@ static struct node *create_node(struct connection *conn, const void *ctx, for (i = node; i; i = i->parent) { /* i->parent is set for each new node, so check quota. */ if (i->parent && - domain_nbentry(conn) >= quota_nb_entry_per_domain) { + domain_nbentry(conn) >= hard_quotas[ACC_NODES].val) { ret = ENOSPC; goto err; } @@ -1780,7 +1767,7 @@ static int do_set_perms(const void *ctx, struct connection *conn, return EINVAL; perms.num--; - if (domain_max_chk(conn, ACC_NPERM, perms.num, quota_nb_perms_per_node)) + if (domain_max_chk(conn, ACC_NPERM, perms.num)) return ENOSPC; permstr = in->buffer + strlen(in->buffer) + 1; @@ -2649,7 +2636,16 @@ static void usage(void) " memory: total used memory per domain for nodes,\n" " transactions, watches and requests, above\n" " which Xenstore will stop talking to domain\n" +" nodes: number nodes owned by a domain\n" +" node-permissions: number of access permissions per\n" +" node\n" +" node-size: total size of a node (permissions +\n" +" children names + content)\n" " outstanding: number of outstanding requests\n" +" path-length: length of a node path\n" +" transactions: number of concurrent transactions\n" +" per domain\n" +" watches: number of watches per domain" " -q, --quota-soft = set a soft quota to the value ,\n" " causing a warning to be issued via syslog() if the\n" " limit is violated, allowed quotas are:\n" @@ -2714,15 +2710,19 @@ static unsigned int get_optval_uint(const char *arg) static bool what_matches(const char *arg, const char *what) { - unsigned int what_len = strlen(what); + unsigned int what_len; + + if (!what) + return false; + what_len = strlen(what); return !strncmp(arg, what, what_len) && arg[what_len] == '='; } static void set_timeout(const char *arg) { const char *eq = strchr(arg, '='); - int val; + unsigned int val; if (!eq) barf("quotas must be specified via =\n"); @@ -2736,22 +2736,22 @@ static void set_timeout(const char *arg) static void set_quota(const char *arg, bool soft) { const char *eq = strchr(arg, '='); - int val; + struct quota *q = soft ? soft_quotas : hard_quotas; + unsigned int val; + unsigned int i; if (!eq) barf("quotas must be specified via =\n"); val = get_optval_uint(eq + 1); - if (what_matches(arg, "outstanding") && !soft) - quota_req_outstanding = val; - else if (what_matches(arg, "transaction-nodes") && !soft) - quota_trans_nodes = val; - else if (what_matches(arg, "memory")) { - if (soft) - quota_memory_per_domain_soft = val; - else - quota_memory_per_domain_hard = val; - } else - barf("unknown quota \"%s\"\n", arg); + + for (i = 0; i < ACC_N; i++) { + if (what_matches(arg, q[i].name)) { + q[i].val = val; + return; + } + } + + barf("unknown quota \"%s\"\n", arg); } /* Sorted by bit values of TRACE_* flags. Flag is (1u << index). */ @@ -2813,7 +2813,7 @@ int main(int argc, char *argv[]) no_domain_init = true; break; case 'E': - quota_nb_entry_per_domain = strtol(optarg, NULL, 10); + hard_quotas[ACC_NODES].val = strtoul(optarg, NULL, 10); break; case 'F': pidfile = optarg; @@ -2831,10 +2831,10 @@ int main(int argc, char *argv[]) recovery = false; break; case 'S': - quota_max_entry_size = strtol(optarg, NULL, 10); + hard_quotas[ACC_NODESZ].val = strtoul(optarg, NULL, 10); break; case 't': - quota_max_transaction = strtol(optarg, NULL, 10); + hard_quotas[ACC_TRANS].val = strtoul(optarg, NULL, 10); break; case 'T': tracefile = optarg; @@ -2854,15 +2854,17 @@ int main(int argc, char *argv[]) verbose = true; break; case 'W': - quota_nb_watch_per_domain = strtol(optarg, NULL, 10); + hard_quotas[ACC_WATCH].val = strtoul(optarg, NULL, 10); break; case 'A': - quota_nb_perms_per_node = strtol(optarg, NULL, 10); + hard_quotas[ACC_NPERM].val = strtoul(optarg, NULL, 10); break; case 'M': - quota_max_path_len = strtol(optarg, NULL, 10); - quota_max_path_len = min(XENSTORE_REL_PATH_MAX, - quota_max_path_len); + hard_quotas[ACC_PATHLEN].val = + strtoul(optarg, NULL, 10); + hard_quotas[ACC_PATHLEN].val = + min((unsigned int)XENSTORE_REL_PATH_MAX, + hard_quotas[ACC_PATHLEN].val); break; case 'Q': set_quota(optarg, false); diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h index 9339820156..92d5b50f3c 100644 --- a/tools/xenstore/xenstored_core.h +++ b/tools/xenstore/xenstored_core.h @@ -316,16 +316,6 @@ extern TDB_CONTEXT *tdb_ctx; extern int dom0_domid; extern int dom0_event; extern int priv_domid; -extern int quota_nb_watch_per_domain; -extern int quota_max_transaction; -extern int quota_max_entry_size; -extern int quota_nb_perms_per_node; -extern int quota_max_path_len; -extern int quota_nb_entry_per_domain; -extern int quota_req_outstanding; -extern int quota_trans_nodes; -extern int quota_memory_per_domain_soft; -extern int quota_memory_per_domain_hard; extern bool keep_orphans; extern unsigned int timeout_watch_event_msec; diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index b3a719569e..04f911b111 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -43,7 +43,61 @@ static evtchn_port_t virq_port; xenevtchn_handle *xce_handle = NULL; -static unsigned int acc_global_max[ACC_N]; +struct quota hard_quotas[ACC_N] = { + [ACC_NODES] = { + .name = "nodes", + .descr = "Nodes per domain", + .val = 1000, + }, + [ACC_WATCH] = { + .name = "watches", + .descr = "Watches per domain", + .val = 128, + }, + [ACC_OUTST] = { + .name = "outstanding", + .descr = "Outstanding requests per domain", + .val = 20, + }, + [ACC_MEM] = { + .name = "memory", + .descr = "Total Xenstore memory per domain (error level)", + .val = 2 * 1024 * 1024 + 512 * 1024, /* 2.5 MB */ + }, + [ACC_TRANS] = { + .name = "transactions", + .descr = "Active transactions per domain", + .val = 10, + }, + [ACC_TRANSNODES] = { + .name = "transaction-nodes", + .descr = "Max. number of accessed nodes per transaction", + .val = 1024, + }, + [ACC_NPERM] = { + .name = "node-permissions", + .descr = "Max. number of permissions per node", + .val = 5, + }, + [ACC_PATHLEN] = { + .name = "path-max", + .descr = "Max. length of a node path", + .val = XENSTORE_REL_PATH_MAX, + }, + [ACC_NODESZ] = { + .name = "node-size", + .descr = "Max. size of a node", + .val = 2048, + }, +}; + +struct quota soft_quotas[ACC_N] = { + [ACC_MEM] = { + .name = "memory", + .descr = "Total Xenstore memory per domain (warning level)", + .val = 2 * 1024 * 1024, /* 2.0 MB */ + }, +}; struct domain { @@ -204,10 +258,10 @@ static bool domain_can_read(struct connection *conn) if (domain_is_unprivileged(conn)) { if (domain->wrl_credit < 0) return false; - if (domain->acc[ACC_OUTST].val >= quota_req_outstanding) + if (domain->acc[ACC_OUTST].val >= hard_quotas[ACC_OUTST].val) return false; - if (domain->acc[ACC_MEM].val >= quota_memory_per_domain_hard && - quota_memory_per_domain_hard) + if (domain->acc[ACC_MEM].val >= hard_quotas[ACC_MEM].val && + hard_quotas[ACC_MEM].val) return false; } @@ -422,6 +476,7 @@ int domain_get_quota(const void *ctx, struct connection *conn, { struct domain *d = find_domain_struct(domid); char *resp; + unsigned int i; if (!d) return ENOENT; @@ -430,22 +485,15 @@ int domain_get_quota(const void *ctx, struct connection *conn, if (!resp) return ENOMEM; -#define ent(t, e) \ - resp = talloc_asprintf_append(resp, "%-17s: %8u (max: %8u\n", #t, \ - d->acc[e].val, d->acc[e].max); \ - if (!resp) return ENOMEM - - ent(nodes, ACC_NODES); - ent(watches, ACC_WATCH); - ent(transactions, ACC_TRANS); - ent(outstanding, ACC_OUTST); - ent(memory, ACC_MEM); - ent(transaction-nodes, ACC_TRANSNODES); - ent(node-permissions, ACC_NPERM); - ent(path-length, ACC_PATHLEN); - ent(node-size, ACC_NODESZ); - -#undef ent + for (i = 0; i < ACC_N; i++) { + if (!hard_quotas[i].name) + continue; + resp = talloc_asprintf_append(resp, "%-17s: %8u (max %8u)\n", + hard_quotas[i].name, + d->acc[i].val, d->acc[i].max); + if (!resp) + return ENOMEM; + } send_reply(conn, XS_CONTROL, resp, strlen(resp) + 1); @@ -455,27 +503,21 @@ int domain_get_quota(const void *ctx, struct connection *conn, int domain_max_global_acc(const void *ctx, struct connection *conn) { char *resp; + unsigned int i; resp = talloc_asprintf(ctx, "Max. seen accounting values:\n"); if (!resp) return ENOMEM; -#define ent(t, e) \ - resp = talloc_asprintf_append(resp, "%-17s: %8u\n", #t, \ - acc_global_max[e]); \ - if (!resp) return ENOMEM - - ent(nodes, ACC_NODES); - ent(watches, ACC_WATCH); - ent(transactions, ACC_TRANS); - ent(outstanding, ACC_OUTST); - ent(memory, ACC_MEM); - ent(transaction-nodes, ACC_TRANSNODES); - ent(node-permissions, ACC_NPERM); - ent(path-length, ACC_PATHLEN); - ent(node-size, ACC_NODESZ); - -#undef ent + for (i = 0; i < ACC_N; i++) { + if (!hard_quotas[i].name) + continue; + resp = talloc_asprintf_append(resp, "%-17s: %8u\n", + hard_quotas[i].name, + hard_quotas[i].max); + if (!resp) + return ENOMEM; + } send_reply(conn, XS_CONTROL, resp, strlen(resp) + 1); @@ -590,7 +632,7 @@ int acc_fix_domains(struct list_head *head, bool chk_quota, bool update) list_for_each_entry(cd, head, list) { cnt = domain_nbentry_fix(cd->domid, cd->acc[ACC_NODES], update); if (!update) { - if (chk_quota && cnt >= quota_nb_entry_per_domain) + if (chk_quota && cnt >= hard_quotas[ACC_NODES].val) return ENOSPC; if (cnt < 0) return ENOMEM; @@ -1091,12 +1133,12 @@ static void domain_acc_valid_max(struct domain *d, enum accitem what, unsigned int val) { assert(what < ARRAY_SIZE(d->acc)); - assert(what < ARRAY_SIZE(acc_global_max)); + assert(what < ARRAY_SIZE(hard_quotas)); if (val > d->acc[what].max) d->acc[what].max = val; - if (val > acc_global_max[what] && domid_is_unprivileged(d->domid)) - acc_global_max[what] = val; + if (val > hard_quotas[what].max && domid_is_unprivileged(d->domid)) + hard_quotas[what].max = val; } static int domain_acc_add_valid(struct domain *d, enum accitem what, int add) @@ -1231,19 +1273,19 @@ void domain_reset_global_acc(void) unsigned int i; for (i = 0; i < ACC_N; i++) - acc_global_max[i] = 0; + hard_quotas[i].max = 0; /* Set current max values seen. */ hashtable_iterate(domhash, domain_reset_global_acc_sub, NULL); } bool domain_max_chk(const struct connection *conn, enum accitem what, - unsigned int val, unsigned int quota) + unsigned int val) { if (!conn || !conn->domain) return false; - if (domain_is_unprivileged(conn) && val > quota) + if (domain_is_unprivileged(conn) && val > hard_quotas[what].val) return true; domain_acc_valid_max(conn->domain, what, val); @@ -1292,8 +1334,7 @@ static bool domain_chk_quota(struct connection *conn, unsigned int mem) domain = conn->domain; now = time(NULL); - if (mem >= quota_memory_per_domain_hard && - quota_memory_per_domain_hard) { + if (mem >= hard_quotas[ACC_MEM].val && hard_quotas[ACC_MEM].val) { if (domain->hard_quota_reported) return true; syslog(LOG_ERR, "Domain %u exceeds hard memory quota, Xenstore interface to domain stalled\n", @@ -1310,15 +1351,14 @@ static bool domain_chk_quota(struct connection *conn, unsigned int mem) syslog(LOG_INFO, "Domain %u below hard memory quota again\n", domain->domid); } - if (mem >= quota_memory_per_domain_soft && - quota_memory_per_domain_soft && - !domain->soft_quota_reported) { + if (mem >= soft_quotas[ACC_MEM].val && + soft_quotas[ACC_MEM].val && !domain->soft_quota_reported) { domain->mem_last_msg = now; domain->soft_quota_reported = true; syslog(LOG_WARNING, "Domain %u exceeds soft memory quota\n", domain->domid); } - if (mem < quota_memory_per_domain_soft && + if (mem < soft_quotas[ACC_MEM].val && domain->soft_quota_reported) { domain->mem_last_msg = now; domain->soft_quota_reported = false; diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index 78ca434531..5123453f6c 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -40,6 +40,16 @@ enum accitem { ACC_N, /* Number of elements per domain. */ }; +struct quota { + const char *name; + const char *descr; + unsigned int val; + unsigned int max; +}; + +extern struct quota hard_quotas[ACC_N]; +extern struct quota soft_quotas[ACC_N]; + void handle_event(void); void check_domains(void); @@ -134,7 +144,7 @@ void acc_commit(struct connection *conn); int domain_max_global_acc(const void *ctx, struct connection *conn); void domain_reset_global_acc(void); bool domain_max_chk(const struct connection *conn, unsigned int what, - unsigned int val, unsigned int quota); + unsigned int val); /* Write rate limiting */ diff --git a/tools/xenstore/xenstored_transaction.c b/tools/xenstore/xenstored_transaction.c index cecaf27018..f2650f5d05 100644 --- a/tools/xenstore/xenstored_transaction.c +++ b/tools/xenstore/xenstored_transaction.c @@ -252,8 +252,7 @@ int access_node(struct connection *conn, struct node *node, i = find_accessed_node(trans, node->name); if (!i) { - if (domain_max_chk(conn, ACC_TRANSNODES, trans->nodes + 1, - quota_trans_nodes)) { + if (domain_max_chk(conn, ACC_TRANSNODES, trans->nodes + 1)) { ret = ENOSPC; goto err; } @@ -479,7 +478,7 @@ int do_transaction_start(const void *ctx, struct connection *conn, if (conn->transaction) return EBUSY; - if (domain_transaction_get(conn) > quota_max_transaction) + if (domain_transaction_get(conn) > hard_quotas[ACC_TRANS].val) return ENOSPC; /* Attach transaction to ctx for autofree until it's complete */ diff --git a/tools/xenstore/xenstored_watch.c b/tools/xenstore/xenstored_watch.c index 61b1e3421e..e8eb35de02 100644 --- a/tools/xenstore/xenstored_watch.c +++ b/tools/xenstore/xenstored_watch.c @@ -239,7 +239,7 @@ int do_watch(const void *ctx, struct connection *conn, struct buffered_data *in) return EEXIST; } - if (domain_watch(conn) > quota_nb_watch_per_domain) + if (domain_watch(conn) > hard_quotas[ACC_WATCH].val) return E2BIG; watch = add_watch(conn, vec[0], vec[1], relative, false); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon May 08 11:58:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 11:58:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531466.827164 (Exim 4.92) (envelope-from ) id 1pvzVb-0005LW-2f; Mon, 08 May 2023 11:58:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531466.827164; Mon, 08 May 2023 11:58:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzVa-0005LP-W5; Mon, 08 May 2023 11:58:26 +0000 Received: by outflank-mailman (input) for mailman id 531466; Mon, 08 May 2023 11:58:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzVZ-0004mF-L3 for xen-devel@lists.xenproject.org; Mon, 08 May 2023 11:58:25 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a2299642-ed97-11ed-8611-37d641c3527e; Mon, 08 May 2023 13:58:23 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3A8D122094; Mon, 8 May 2023 11:58:23 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0748F1346B; Mon, 8 May 2023 11:58:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id tuUfAN/jWGS3PAAAMHmgww (envelope-from ); Mon, 08 May 2023 11:58:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a2299642-ed97-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683547103; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n5la5HdDyFDWRwDuAjJZPMu94UDPo4M8jI+4gdZynGQ=; b=RwTGeKjh8QjmX/DSmTvaAt9qy0B+poou0f6w4bY6TP25Py4A/HxKGRfjUnqvVtyqkZ5at3 DGERyS1S0dGc9arJRsZ6pqidf1L3IWvoYgmkC6gLRbYXnIt8OtNKZ6fkUPHATLiYEUr81X CZ19g4i6SJSq8G+VLsSoIOCqy6dDlyg= Message-ID: <63321442-ee0d-c525-ba20-e99cf135399c@suse.com> Date: Mon, 8 May 2023 13:58:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 15/22] xen/pvcalls: Use alloc_ordered_workqueue() to create ordered workqueues Content-Language: en-US To: Tejun Heo , jiangshanlai@gmail.com Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com, Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org References: <20230421025046.4008499-1-tj@kernel.org> <20230421025046.4008499-16-tj@kernel.org> From: Juergen Gross In-Reply-To: <20230421025046.4008499-16-tj@kernel.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------Dglk4qYyyprX0NlIxjCYwpTm" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------Dglk4qYyyprX0NlIxjCYwpTm Content-Type: multipart/mixed; boundary="------------sf1MvrCR4PwyBby3JUNqu6Sc"; protected-headers="v1" From: Juergen Gross To: Tejun Heo , jiangshanlai@gmail.com Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com, Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org Message-ID: <63321442-ee0d-c525-ba20-e99cf135399c@suse.com> Subject: Re: [PATCH 15/22] xen/pvcalls: Use alloc_ordered_workqueue() to create ordered workqueues References: <20230421025046.4008499-1-tj@kernel.org> <20230421025046.4008499-16-tj@kernel.org> In-Reply-To: <20230421025046.4008499-16-tj@kernel.org> --------------sf1MvrCR4PwyBby3JUNqu6Sc Content-Type: multipart/mixed; boundary="------------NFpaZFlUybo8IS9YTRCX05u6" --------------NFpaZFlUybo8IS9YTRCX05u6 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjEuMDQuMjMgMDQ6NTAsIFRlanVuIEhlbyB3cm90ZToNCj4gQkFDS0dST1VORA0KPiA9 PT09PT09PT09DQo+IA0KPiBXaGVuIG11bHRpcGxlIHdvcmsgaXRlbXMgYXJlIHF1ZXVlZCB0 byBhIHdvcmtxdWV1ZSwgdGhlaXIgZXhlY3V0aW9uIG9yZGVyDQo+IGRvZXNuJ3QgbWF0Y2gg dGhlIHF1ZXVlaW5nIG9yZGVyLiBUaGV5IG1heSBnZXQgZXhlY3V0ZWQgaW4gYW55IG9yZGVy IGFuZA0KPiBzaW11bHRhbmVvdXNseS4gV2hlbiBmdWxseSBzZXJpYWxpemVkIGV4ZWN1dGlv biAtIG9uZSBieSBvbmUgaW4gdGhlIHF1ZXVlaW5nDQo+IG9yZGVyIC0gaXMgbmVlZGVkLCBh biBvcmRlcmVkIHdvcmtxdWV1ZSBzaG91bGQgYmUgdXNlZCB3aGljaCBjYW4gYmUgY3JlYXRl ZA0KPiB3aXRoIGFsbG9jX29yZGVyZWRfd29ya3F1ZXVlKCkuDQo+IA0KPiBIb3dldmVyLCBh bGxvY19vcmRlcmVkX3dvcmtxdWV1ZSgpIHdhcyBhIGxhdGVyIGFkZGl0aW9uLiBCZWZvcmUg aXQsIGFuDQo+IG9yZGVyZWQgd29ya3F1ZXVlIGNvdWxkIGJlIG9idGFpbmVkIGJ5IGNyZWF0 aW5nIGFuIFVOQk9VTkQgd29ya3F1ZXVlIHdpdGgNCj4gQG1heF9hY3RpdmU9PTEuIFRoaXMg b3JpZ2luYWxseSB3YXMgYW4gaW1wbGVtZW50YXRpb24gc2lkZS1lZmZlY3Qgd2hpY2ggd2Fz DQo+IGJyb2tlbiBieSA0YzE2YmQzMjdjNzQgKCJ3b3JrcXVldWU6IHJlc3RvcmUgV1FfVU5C T1VORC9tYXhfYWN0aXZlPT0xIHRvIGJlDQo+IG9yZGVyZWQiKS4gQmVjYXVzZSB0aGVyZSB3 ZXJlIHVzZXJzIHRoYXQgZGVwZW5kZWQgb24gdGhlIG9yZGVyZWQgZXhlY3V0aW9uLA0KPiA1 YzAzMzhjNjg3MDYgKCJ3b3JrcXVldWU6IHJlc3RvcmUgV1FfVU5CT1VORC9tYXhfYWN0aXZl PT0xIHRvIGJlIG9yZGVyZWQiKQ0KPiBtYWRlIHdvcmtxdWV1ZSBhbGxvY2F0aW9uIHBhdGgg dG8gaW1wbGljaXRseSBwcm9tb3RlIFVOQk9VTkQgd29ya3F1ZXVlcyB3Lw0KPiBAbWF4X2Fj dGl2ZT09MSB0byBvcmRlcmVkIHdvcmtxdWV1ZXMuDQo+IA0KPiBXaGlsZSB0aGlzIGhhcyB3 b3JrZWQgb2theSwgb3ZlcmxvYWRpbmcgdGhlIFVOQk9VTkQgYWxsb2NhdGlvbiBpbnRlcmZh Y2UNCj4gdGhpcyB3YXkgY3JlYXRlcyBvdGhlciBpc3N1ZXMuIEl0J3MgZGlmZmljdWx0IHRv IHRlbGwgd2hldGhlciBhIGdpdmVuDQo+IHdvcmtxdWV1ZSBhY3R1YWxseSBuZWVkcyB0byBi ZSBvcmRlcmVkIGFuZCB1c2VycyB0aGF0IGxlZ2l0aW1hdGVseSB3YW50IGENCj4gbWluIGNv bmN1cnJlbmN5IGxldmVsIHdxIHVuZXhwZWN0ZWRseSBnZXRzIGFuIG9yZGVyZWQgb25lIGlu c3RlYWQuIFdpdGgNCj4gcGxhbm5lZCBVTkJPVU5EIHdvcmtxdWV1ZSB1cGRhdGVzIHRvIGlt cHJvdmUgZXhlY3V0aW9uIGxvY2FsaXR5IGFuZCBtb3JlDQo+IHByZXZhbGVuY2Ugb2YgY2hp cGxldCBkZXNpZ25zIHdoaWNoIGNhbiBiZW5lZml0IGZyb20gc3VjaCBpbXByb3ZlbWVudHMs IHRoaXMNCj4gaXNuJ3QgYSBzdGF0ZSB3ZSB3YW5uYSBiZSBpbiBmb3JldmVyLg0KPiANCj4g VGhpcyBwYXRjaCBzZXJpZXMgYXVkaXRzIGFsbCBjYWxsc2l0ZXMgdGhhdCBjcmVhdGUgYW4g VU5CT1VORCB3b3JrcXVldWUgdy8NCj4gQG1heF9hY3RpdmU9PTEgYW5kIGNvbnZlcnRzIHRo ZW0gdG8gYWxsb2Nfb3JkZXJlZF93b3JrcXVldWUoKSBhcyBuZWNlc3NhcnkuDQo+IA0KPiBX SEFUIFRPIExPT0sgRk9SDQo+ID09PT09PT09PT09PT09PT0NCj4gDQo+IFRoZSBjb252ZXJz aW9ucyBhcmUgZnJvbQ0KPiANCj4gICAgYWxsb2Nfd29ya3F1ZXVlKFdRX1VOQk9VTkQgfCBm bGFncywgMSwgYXJncy4uKQ0KPiANCj4gdG8NCj4gDQo+ICAgIGFsbG9jX29yZGVyZWRfd29y a3F1ZXVlKGZsYWdzLCBhcmdzLi4uKQ0KPiANCj4gd2hpY2ggZG9uJ3QgY2F1c2UgYW55IGZ1 bmN0aW9uYWwgY2hhbmdlcy4gSWYgeW91IGtub3cgdGhhdCBmdWxseSBvcmRlcmVkDQo+IGV4 ZWN1dGlvbiBpcyBub3QgbmNlc3NhcnksIHBsZWFzZSBsZXQgbWUga25vdy4gSSdsbCBkcm9w IHRoZSBjb252ZXJzaW9uIGFuZA0KPiBpbnN0ZWFkIGFkZCBhIGNvbW1lbnQgbm90aW5nIHRo ZSBmYWN0IHRvIHJlZHVjZSBjb25mdXNpb24gd2hpbGUgY29udmVyc2lvbg0KPiBpcyBpbiBw cm9ncmVzcy4NCj4gDQo+IElmIHlvdSBhcmVuJ3QgZnVsbHkgc3VyZSwgaXQncyBjb21wbGV0 ZWx5IGZpbmUgdG8gbGV0IHRoZSBjb252ZXJzaW9uDQo+IHRocm91Z2guIFRoZSBiZWhhdmlv ciB3aWxsIHN0YXkgZXhhY3RseSB0aGUgc2FtZSBhbmQgd2UgY2FuIGFsd2F5cw0KPiByZWNv bnNpZGVyIGxhdGVyLg0KPiANCj4gQXMgdGhlcmUgYXJlIGZvbGxvdy11cCB3b3JrcXVldWUg Y29yZSBjaGFuZ2VzLCBJJ2QgcmVhbGx5IGFwcHJlY2lhdGUgaWYgdGhlDQo+IHBhdGNoIGNh biBiZSByb3V0ZWQgdGhyb3VnaCB0aGUgd29ya3F1ZXVlIHRyZWUgdy8geW91ciBhY2tzLiBU aGFua3MuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBUZWp1biBIZW8gPHRqQGtlcm5lbC5vcmc+ DQo+IENjOiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+IENjOiBTdGVmYW5v IFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+DQo+IENjOiBPbGVrc2FuZHIg VHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+DQo+IENjOiB4ZW4t ZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcNCg0KQWNrZWQtYnk6IEp1ZXJnZW4gR3Jvc3Mg PGpncm9zc0BzdXNlLmNvbT4NCg0KDQpKdWVyZ2VuDQoNCg== --------------NFpaZFlUybo8IS9YTRCX05u6 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------NFpaZFlUybo8IS9YTRCX05u6-- --------------sf1MvrCR4PwyBby3JUNqu6Sc-- --------------Dglk4qYyyprX0NlIxjCYwpTm Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmRY494FAwAAAAAACgkQsN6d1ii/Ey/7 Bwf+OJXAmz1RWO7eG2WkDpbZH+arNDyS1afUPhFyYrSPPmoceOw9jhDlK/AC2CDZifAKdsZgKtKv zc98yqEYW3/Cy+uRAgvvOCzA0JXQ2/c/OnlYK14G+3PE/AItI9v0lLghC9wb1y9U6vS5Igau+fAD BfcWkg2WunVKz0B+cS6kcyDUU6aMxpED7j0SKee57XqeIKZmYnUSEo6rH045DEU+WbnWt1eyz28y D7z0bAHFq592inBwBgeTMD6ojcclmACl55JPfKX8PCJhupcc1lhhS6coAtYdmlvDm8US+RSC02HA HTNySfrIso+OURph0Lln2Laj0I0Mw4H9QpAeUi6YGQ== =Yiej -----END PGP SIGNATURE----- --------------Dglk4qYyyprX0NlIxjCYwpTm-- From xen-devel-bounces@lists.xenproject.org Mon May 08 12:00:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 12:00:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531471.827175 (Exim 4.92) (envelope-from ) id 1pvzXH-0006yA-Hi; Mon, 08 May 2023 12:00:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531471.827175; Mon, 08 May 2023 12:00:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzXH-0006y3-Du; Mon, 08 May 2023 12:00:11 +0000 Received: by outflank-mailman (input) for mailman id 531471; Mon, 08 May 2023 12:00:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzXG-0006xr-0b for xen-devel@lists.xenproject.org; Mon, 08 May 2023 12:00:10 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20612.outbound.protection.outlook.com [2a01:111:f400:7e1a::612]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e0c40356-ed97-11ed-b226-6b7b168915f2; Mon, 08 May 2023 14:00:09 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8509.eurprd04.prod.outlook.com (2603:10a6:102:210::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Mon, 8 May 2023 12:00:07 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c%4]) with mapi id 15.20.6363.031; Mon, 8 May 2023 12:00:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e0c40356-ed97-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FWaarnc7WHtr7skPNu0spU4YFksv3ExLcY+5q1UpCD5HsHzSq1OND2FxcjKoOiONeLy7syofS8W3bUWLafkpnbTANhDXzLJTDont1K8hlEF4RafyBE2Cef227MbJSsG/OhGmCJmg2u6K9B8bOSrN9KYMYjZ+cCuK4uVTi9njNKtQKYoYIu4Lu5VV8b7hGcIfqYodSqGbyGGqkJCcMS/gWRqyn+Xb6m6uDdNjoM+sdnJADEnV/kBIEKW2PrF1h9Qxpkjd+x9sXIO1JHiYGc3yy6ek5TTBfAyuqeCWVbd9qKJst3wBK8OIk8OWU8RaOz7P9GYetnrqF7jhwS2a4sxnSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4M0gQIPPWYu6lNbkmP6JNCTOctzFQmfMgVZacHhWJYc=; b=YKUJ8BH9tHGliB0FlMrj0Pi/THqin9aP7QmmEJ62WgI2viDyyjVEH6Gj5WSFsjBXwpN5bo5g9Os5IsnDTlWLygqHw62p3zeifiMbWaPB+0ZqTsqJPl8VjHGN/3H3rFJziq6acbXuV8bFmbKnrD/1/qz39kK7VqkD0ul5LKphCPDBgmmBzShqcQXqnlZgzQ34x+ofbvGIPE86Qg1+FLK0fh6GLDZ7z80krkptmNu3s1/ZGfARIxs9eQODJv/16DPh5sMntS97Clx1x3+Q1zVljnaH8OnGpQoBB8q7HKOyt8sgynxJ0eQsylfR53/X9rvaxhTvrcIYJbcQ61PCs1XGcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4M0gQIPPWYu6lNbkmP6JNCTOctzFQmfMgVZacHhWJYc=; b=sY7bmbQ1RYJqjvbxdVPK14hVVbewwh67RX5CQTeTRL5xs77xOQETlRntXIyeKYnj18+7D2cID4InxqCr8LYYXSmViiSdT3F4jf2UfT8ne4N2EvVhZBRRPgGa4nFl1h2cdkllYihDQsrk0j9bFR5vriV/qxu7xJ53LB+8fqf3S2HKPce9tmIYoNsUVysEx1/GEVCtzWIAyB12PrpRg7z+A2JTDiFECSrIgjwy/8LWxMVfwGwWZGO0X3GlLeBcelxHbSCfqtAyh45gqPisEDILk1nyHGs4KeQIeWjgfyFXKHYpEY2g/z42oXA/hu2XvQr8lFFNDh/RPuOqpgLc/dAZpQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1f0d8b88-7c5a-670a-c966-2fd7d764f2fd@suse.com> Date: Mon, 8 May 2023 14:00:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3 13/14 RESEND] xenpm: Add set-cpufreq-hwp subcommand Content-Language: en-US From: Jan Beulich To: Jason Andryuk Cc: Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org References: <20230501193034.88575-1-jandryuk@gmail.com> <20230501193034.88575-14-jandryuk@gmail.com> <46c46e0b-0fba-2f3f-6289-f68737a3d8d9@suse.com> In-Reply-To: <46c46e0b-0fba-2f3f-6289-f68737a3d8d9@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FRYP281CA0010.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8509:EE_ X-MS-Office365-Filtering-Correlation-Id: 7272546f-c7b2-4185-2bb9-08db4fbbc3ef X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Vk+B0341oYyBOx0QAsfOSVU0i/sLt1hsazBr8PObYvW+QCO23wpXfJDhjUnPJztldkczpyg9rs+s5ilwtUsM+oDOxmY6H+pA1RGxZjOakU9NBXzCIYChlHzp2TtsQsyJjBk8KfVr8tYVLI+CPfWn+Tqr+Qo8ub+t2xtpwK65SzpTwreDpJai0mtAG7dAxUK5CwGkAgPsT0KuQbpYQw6fxEpVXOslrGnClGx4/sqS4i5EmYTiUgADCDCM9ldoC5v+hOAGL02jL3FGazMTGrAAQEN+XUor54FkMbEESyV8kjWxQ+QV7ShhnfoO9Mle0VS4J40xrRtv9n6TX4O0UczxtkjhwNQ/Vujxc2R0358NEyfvYiZUlGScDokqby1ddycZI6dTKAIJ+T9ilop9MpTuUnIRJ3GdRoyKhz0Af74esrjqU8e81W1tL43yzqXA312v4nZKU9Zf7QCqcZuL8dbvht7xHq6Z4I6ocTsObKC08GUNi5mFc2PNIBNlqLSnVYbt03nNgRwlfMembtt2XLzDpTiA2GwbPl6m6ZilJnTU8JjoBTM1GXJbOc6hOXuY+DF//seTFCA3Cl0oVDdPx9bYKytH/b+Qrnvn00vnLBpKwsZqcs92KxhbGM1gr45V2NAQ/yc4FbZVPGyIJujYqszQrA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(366004)(396003)(376002)(346002)(136003)(451199021)(6512007)(53546011)(26005)(6506007)(6486002)(36756003)(2616005)(38100700002)(86362001)(31696002)(186003)(41300700001)(2906002)(54906003)(31686004)(4744005)(5660300002)(6916009)(4326008)(66476007)(66556008)(316002)(8936002)(8676002)(478600001)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dEZLenRpd0J3cWt6cVdyQ3JDbHVIaFBnMkFkOFRReExId2JIMVlBaGd3b0pN?= =?utf-8?B?T1EzUnFFclExZWY0K2lBRlJBQ1Y0RjZYbmpYaUJKYTlyU2JXTTJ6VFo1QTVN?= =?utf-8?B?WDd6S1hwdXFtaEsxVFd5UlYyVCsrQi9OY0RJVUN0aGJQVEh6WFNjWHpsNHhT?= =?utf-8?B?c3NFQ2VnZWh5MHFiWFY2aWw0NG9MLzhTZmRUSm5yeXREaWxXdm01aFY2MVBx?= =?utf-8?B?Mk9Ja3dqRjJmeWdBNVNZZDMwdDZGVmpPVkNHU2NUSXdVRmthMjBaK2l0R0o1?= =?utf-8?B?eUVsZUFYZytVZHRYbHN4QXF4dUxUbnU2UktScysvdGxuYnkyaHlWN1dKN1FX?= =?utf-8?B?MEgvRGQ3cHVQT2doK3l0emMxc04zYmMxdWRpalpPTHlHWFhEM2xURzhyY1Ux?= =?utf-8?B?WFZjOExQb2pxVkRHRXhPWGNJc2huUklNc0tnSXc3eSsyWmk0amlaZTg3ZlQ2?= =?utf-8?B?b1JVZnBWSHJUZVloRlp4RHNGQVA1aXJkYm1jVG1PNm1NMVdJL2VncHB0TTRm?= =?utf-8?B?WFJGQU5YNTdhNGlIK2RZSDZud25KYnI1aDNSRWhsSmNxV0Q1U3NwTWtMKzVr?= =?utf-8?B?RVJvOUFHRFJ0YXJMNThZNVorSUJJMTFNUGZRT0dHeUZIWXNNSHR3RVU1eno1?= =?utf-8?B?MVRQdzhpb0RVZ29xaEY2M1lPK0NjOTQ0ZnArbTFmTVcwcFVKcnF4QVNiTEhh?= =?utf-8?B?bUhydnYzaWZuVVI5S3lKN1JTazUrR0tFSmtqYVlLUUF1YzBpMGtFVkxzeU9t?= =?utf-8?B?am5BV0I5bWQ4N0wzMnpGOUowSUgxa0NmdTRjZVpoOTMvY3lQazBWTGdIYjVv?= =?utf-8?B?Q1BldnFLNHpHWG1PSWI0MGFidTl5UTlheVh4anBpZWRibitiN01zcFQzdzFz?= =?utf-8?B?TkpHQVN5MTB6NjNMckxEMXh5R3YvZjd6czh0MGRZSjhHMXpPVGZibHhMQXdQ?= =?utf-8?B?em9vL2s1RVpkSnJtNzJRZnEyS0lucWlTd0c4ZEVlY0NrRS9FdHZONm9QcEQ4?= =?utf-8?B?bGEyT1d1SEdWOCtZcWI5azBTTXJFZjcrczlsNlJYb2tOK3R4U0t6NjY4YXdi?= =?utf-8?B?SUZnUDZWNnhmT0pJOEdaY1lzYVZjRE5Wb253SXpuMUpkekdZMVVrbkZvaUQ0?= =?utf-8?B?K29lazVmV1RVY2pZTExlVndJay8vM1NTQ1pWMnRSYUNtWkNxZjBvd0hYSTJn?= =?utf-8?B?bDlkNnYwWGs0NzVVK3FmVXIvOU1vM3pGOFc3NTl6R0ZwUFBsb252TFVOWnBJ?= =?utf-8?B?UCt0KzExbHVLa0pKbFo4TzEyM2FLcFdoSnpLNG5LVk5mdjhaQ2FWTEVQTFJl?= =?utf-8?B?QmtDckxtZXhHMVFmdGRpTys2UC9SOEozeFM0bTc0aC9Zem9GaG9lK3I1Zm5R?= =?utf-8?B?ZGRBUktWMjB0RlNRWUZxOVBuOFRYOFBYTDhCL1JQcVc1TFlYSVdiTmdwcjVZ?= =?utf-8?B?KzVGZ1NmdVdOSFJpUzJNVjFFSnFvZVNwdisrZU16T2k3bHZNZ3Q4b1JxMkZJ?= =?utf-8?B?U0NFTXg4dVVrUGNhejA4OGhDU1RnemVERENVd3NLVVpYTFpNNGtaamNDOExS?= =?utf-8?B?Q3liRWNHVVA4bVFmenhzL3pLQzdrbWRlZG9ydXlpSk1TSGc1SjVvczVObk8z?= =?utf-8?B?UDkyanI1WGhHbFJTeDRUSTdvczRWbXE4T0Y0aHhTTmxHUms2Q2F2bkUreGoz?= =?utf-8?B?QVcwdzZIYVNScXhyZytCK29UZHd6b29aYk1SZDdtOU13UGs0QlFEbzd0TU9j?= =?utf-8?B?QXJOSXd2U2dKMVJuWUtmRG45SUl3NnIvZmpDSHB6ZVVlekNrMCtCSWN1b3cz?= =?utf-8?B?WnJDeXcrL1NwTGtHKzJTRjRvdUdhMGlycTVRZlN3QmJNc09jVG1XNStyUnJT?= =?utf-8?B?cU1BWDVjZDUyaFAvSGh0czAxNk0xUmFpTFBHdW13RmJnQ1JVdnhXNis2c3Zn?= =?utf-8?B?MlgrWml0NTF5QlVTaEhtcmVyV09zRjVvVGtyb1FjVVg3SWYvdHA5dzNmcWFJ?= =?utf-8?B?eENEaVdUOVF2WU5nTFVjRjNqa0o0RUliMExBWnlqazFBcFZlTS9TaFREV0JC?= =?utf-8?B?U1ZlbjFmUUdyc2ZaYy81cExZdTl2T0dRSkU4bG93UFJBM1A2K3BaZ1NqNkYy?= =?utf-8?Q?eNVF4LA/RJ85OomU8rwdr8zuB?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7272546f-c7b2-4185-2bb9-08db4fbbc3ef X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 12:00:06.9052 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kerhk2eflNk7jvrzRSOBQIs2NbuhSlSSNr193ww4zNRLKVCRl/hY31WR9obtxsqmeOeZe6sE305zLJtDeC7Fzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8509 On 08.05.2023 13:56, Jan Beulich wrote: > On 01.05.2023 21:30, Jason Andryuk wrote: >> +static int parse_hwp_opts(xc_set_hwp_para_t *set_hwp, int *cpuid, >> + int argc, char *argv[]) >> +{ >> + int i = 0; >> + >> + if ( argc < 1 ) { >> + fprintf(stderr, "Missing arguments\n"); >> + return -1; >> + } >> + >> + if ( parse_cpuid_non_fatal(argv[i], cpuid) == 0 ) >> + { >> + i++; >> + } > > I don't think you need the earlier patch and the separate helper: > Whether a CPU number is present can be told by checking > isdigit(argv[i][0]). Hmm, yes, there is "all", but your help text doesn't mention it and since you're handling a variable number of arguments anyway, there's not need for anyone to say "all" - they can simply omit the optional argument. Jan From xen-devel-bounces@lists.xenproject.org Mon May 08 12:02:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 12:02:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531477.827184 (Exim 4.92) (envelope-from ) id 1pvzZC-0007bp-SN; Mon, 08 May 2023 12:02:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531477.827184; Mon, 08 May 2023 12:02:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzZC-0007bi-Pf; Mon, 08 May 2023 12:02:10 +0000 Received: by outflank-mailman (input) for mailman id 531477; Mon, 08 May 2023 12:02:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pvzZC-0007bc-0j for xen-devel@lists.xenproject.org; Mon, 08 May 2023 12:02:10 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2072.outbound.protection.outlook.com [40.107.7.72]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 28888e36-ed98-11ed-b226-6b7b168915f2; Mon, 08 May 2023 14:02:09 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8352.eurprd04.prod.outlook.com (2603:10a6:102:1cd::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Mon, 8 May 2023 12:01:39 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c%4]) with mapi id 15.20.6363.031; Mon, 8 May 2023 12:01:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 28888e36-ed98-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MToV/TB1E+2uBMoQPaO2FQBZJb76tbKhqNA3SdYF0HJtpLYPL4U9OyMilRtRBx39kMI/1F36YPrDuPmQpbZCOU9ql5ClF1CTnLbDhGvbIKZ3Cci2Nynv4Sofy/B85sZrRv6mxTHEDf+5EQ6LR6hlHn3jHSRMa54vdVY8QxKCKQlG8BR37udykFO+Gaw1SnVA4CGAqD11KaCVITa1xZVJQuSrrkcT0n9FVoJSg79DZAmlKSASvh/JvIdynmnxJRxO6PNQln8WjGcb33IIuGJs+kjVFxvxFEKe7Cb/4+ZJyoBwcCfAG2YlO2hDZM/MNUPd0nUhZvWr7v3z5047hBwQ8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P7kDkVV1bON4Xwcn4ICUJBwyjXPzXnP6fiusd2Z9+aw=; b=nJ/361o3DZ4/3/6cvgrK5KxP5u8FdeInQcwIor1wsN9gbajlogh3XPN+UnUN6zQciqV5O+rt98EgY016UaKQ1lC5PeGPrqLm4YHSxf0dyYVnZZqZFi3RToId/hZAZKQozRKku/7ASV09IgCR+ra40M2yy5CUwcSpJBUfN6NPXYMiz6a2DxLE+p9O7jwtgUunWFkakhFcwAolqPaGQVL/ThuSwy3jCBnVjPVi+5jNYdVXYYpMMR6fCl/qQKIQEpNxqXBqMFR0QS/CpNAhUT45Sk5S8wM01q5cQ0LglfC5Ppfn6PMrrj0XcnB27/sBP+yqfqYnSmqWErT9WEzuPL8nQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P7kDkVV1bON4Xwcn4ICUJBwyjXPzXnP6fiusd2Z9+aw=; b=G8T/qXcRbm97ZNl7SMBaEFCqPU+DALmwg/p3GT4/xdnaJQTgTf77NP58q2Ktg5HoaDSBH6POsLZXJW+wEQ1d9GInU0Abv4ziRUNn4SYQZRZQS547YuGrUm7iCYdc7gIwBUyz2t/zW0etha9qw/2nVvj9EXakqrukgP79JoLUv9j/7TJ93ahI1GXXZvpsWaYkbTkcKhZSYJE6GtM78TfwXhPenG5B66EqANGUlSjONxqoE3tMzkorqG9KVTWEk6ZIuVf/sAZ4LXPC2f1fP6BpsU5F8Z97T11Yqx2MpRTy03c3Slm9XOx1AMGohuYVc6ztAzBOqu6s8ioEVlN6orevCw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <938a8260-d05a-feef-82f2-ed680db1cf90@suse.com> Date: Mon, 8 May 2023 14:01:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3 12/14 RESEND] xenpm: Factor out a non-fatal cpuid_parse variant Content-Language: en-US To: Jason Andryuk Cc: Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org References: <20230501193034.88575-1-jandryuk@gmail.com> <20230501193034.88575-13-jandryuk@gmail.com> From: Jan Beulich In-Reply-To: <20230501193034.88575-13-jandryuk@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0063.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8352:EE_ X-MS-Office365-Filtering-Correlation-Id: 30a870ef-4c92-4b1a-229c-08db4fbbfac9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lYFtfDl4Syoq01yxV7s6UaBPdcKuVmjYHav6/Ax7k/P1e2JEfc8gw1SUa4hV9IDMvg26Yne8hMDv1U1qkkBsLuHSkFIERaKIKHrV3cEANRQfcDpgt1hJ/iMnZyZoKN+K0pg2WVIgNXn3pdDpiY8zs5hsRRZ6N8d2KwHLSkFBIa4dSA2wHufs99Qgo1VZm1KDq+oz25+t3IDHvW6+iVUfjDWoug/6K077QPNZchjnv+MVE1NYYJk+1Q73NOzHTEgLi8ZpOT6KxcggKle09uFdZ0L4XsVFDVnhFmjhgMdgtBrzyp1XnCNQtTFjRX/qfe1KfeAgFKZkjuW/KIxb17ZXTiLtySkxLyTgB50UohrR3rsu9O/3WKMAWqDtEhj88/EoY7Q5TeHh0Sft4QGpWsHvhxILlVlQYYENtHNsOtYEhBXrL/HP8B9H6ztVGPM/AnslFIUgSvqblEvkzYHslRygZ8f1iVMWwQbfIBkrnmdO0T9vaaXE/aPimPcoRHSFAjAXq8FVUJv8IhQ0rO4C5bv11IvZgyE+utGCEBFXh05u9W5SSnD/dfodoNE1R1B2lbVv25myKHonjLajRQni1GgYuI+VL1KUy7kdQ11sU/y08jgLPElYoN9e2P+sGXzpU1/y9rl43swJridpR8lvVSPAJw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(396003)(346002)(136003)(366004)(39860400002)(451199021)(2616005)(186003)(36756003)(38100700002)(31696002)(86362001)(2906002)(6486002)(8936002)(8676002)(316002)(41300700001)(5660300002)(54906003)(31686004)(66946007)(6916009)(66556008)(4326008)(66476007)(478600001)(53546011)(26005)(6506007)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NWlzbWtUWHdyeTFZZjF0bjd5V3BiU1NYMms4MUZBWm9sYjVaaEhDR2RVZExG?= =?utf-8?B?dUlHekRtMmloWDRFRlBpU01pcWRWenMvV2R0NmxyNFZHTzc2bGdPSkl2ZVRO?= =?utf-8?B?VWhTQ1JPYzJRbkRqak4xblExSEdkUzhBeXB4ZHU0SnhSc0V3ald0SEFZd1Nr?= =?utf-8?B?d25HMUo4ajVtckV2UWkyWitocWdjL04wNXFtL2JnYmhhNE51M2FrRENlWEVW?= =?utf-8?B?SFhIbUF1ZjJEM2MyaERwVGcraUpkQlNBNmVQeXp4ekZnVlRvMTFQU0lkQlZ6?= =?utf-8?B?cEcxWVJFMGc0SS9LeDRWZitXZThkL2pOUmlFVWN5ZzJRcHk2cmNpa3VYRUFN?= =?utf-8?B?RnpIVzd1aEpGTjVZdjlwekxaZGIwcUFLM3drSGhHeXBmWlk5TFRLSmpPZGVX?= =?utf-8?B?bEJxeG84SC9mUXduVzBuQWxFS00wREFyU2plZzNNakk5RW9ucUdRQS9WNFFW?= =?utf-8?B?MDFnaG5YMTE2djl5bE80QS9KcldmUUI0VWhmeWdTUzBHZ3JuYnpJcHFtbjFK?= =?utf-8?B?RHpzd3FreldXRTJOUXAwT3p3Q3VZc3JBbWtNdHRWRlZFYldTam80cWFmdWhV?= =?utf-8?B?cDUzazV5MllQY24rK0JzNS8ycE9jZW9vQktyaktQTlk5QlRDQ3NpSFlQSUhU?= =?utf-8?B?elRiL2JDd3dUeTM3Qm1JbTJhelVmWU1WV1JEZjg0dzBSMGgyZnNxRlJvd25w?= =?utf-8?B?elppc3grK2U0TzJVVUZDMDVOOVhJRUMwRkxTaG8yTjgwNDFCNk5KMVlwaGVo?= =?utf-8?B?SEFvaFo3cXZvMjdWTVVHVWhoV1UxWXZwU2tUNnh2ZEdvY0svOE93OTF3NGM3?= =?utf-8?B?L1dEL2pjVjNidVlxSWk0M1JTUFVPRVFnV3ozOGJRL0lKcHZxYjZRQnV4ZUpG?= =?utf-8?B?OCthTkYzaHYyVVlmbW5wUml6WHBMcDdEOU5TT21jR1htdjBNM1IwR0F5N3FS?= =?utf-8?B?bm9hMkd2RmNNN3haZnUvU2NxWm9GTjF4cUgwSFJwbnZtZDVWWkdqdEpDMHRO?= =?utf-8?B?dERlbk10a1FWK3hpSGNoeGhlaVdUVm1VekpRQkQ3ak5LWnNPL3JORzdnM2tL?= =?utf-8?B?MkV3NDFBT0NVbTdyVGE1U0NMakZ2MzR5MTBvM2VOMzhkbUd5amsxUEVDakcy?= =?utf-8?B?ZVJYcTArQ3JCejVJQ1VZckVZWEpsazZhcEFwVGxXRVlkUDhDMTRaaVdaWSsz?= =?utf-8?B?VnFHYnF0REtNK09IWUY4bFFVVzV0ejZyUGpJZmpHcHp0NDFYYS9rYlNhcThP?= =?utf-8?B?M2hOT3JWODBGMDhPMm94dGJxOHpjUTBSL1VPZUE2ek1TRlM2ZkpJTmcyOFRn?= =?utf-8?B?Q1RNWVQ5T1JSQjI5VlBkN0ZQV2RSZ0pQTTh3aUxaeHBDTWRXN3lIbll4QmNj?= =?utf-8?B?eTZTSHNPRlBWUWUxbnpvTm1RRUZzNUdmajlHM1EzYWVTUURkOWtic2VDejRq?= =?utf-8?B?WkpqWmsrYlo2N1B5V0FoUVJoMmVZeWlDY0liVnZYWElla2ttd2x3dis0dWtI?= =?utf-8?B?UDBURFZJTVIvWHdGSFhBOUdEd3JXaitqOG8xb1FsWjFsb3ZxaEdmU2pRQ0Zu?= =?utf-8?B?SjNidHRUYXRaR2tHNUJhRjFBODFKdFdoRGVBeXdCZzFUdE5BSjNnR3hxS3lP?= =?utf-8?B?SCtTajgxcXVLNW41Uy9FdWs4dXJ4bWEvOUhaUHUyb2U5Q3ZKWERPdDZBeDN0?= =?utf-8?B?aVRoZXJXS1F1TGMxT20zakFPM3BRc0NrejQyUHh2Qy9WSUdFcVRCWFpJMkVV?= =?utf-8?B?WEtmaHBFdEtRNHFmVmtFVVFxWnh4ZW5RZmI3UUU1RllrcEFHY1d1b2NyWUY2?= =?utf-8?B?Wm5WdExoamtwbmxad2xib0JhQm1sYnFzK3laOHVmR21kV0lJRm8wTWdaajhD?= =?utf-8?B?Q3VkNHF0WUhucGUzdVBkcDYzZ0pKZXU5TVlnMEo0em4xR0xYRjk4aytLOXY2?= =?utf-8?B?b3J4MDVBSkIweWhTTzVQSXBaY3NrbHg0N2FmVyt6OFd2YlN5aVNsM01LMEpa?= =?utf-8?B?b3ZuUjhRb3JuL0p3QW5jV2FwVWpmV09wQ25lQ2lMZnp4QmlQbVNYaGF0RFJF?= =?utf-8?B?VTZNTjArUk5qQWhMTHN1ZEVrTW9mUllLbVdsUCt0cTdrUlR3NWdURTgxajlK?= =?utf-8?Q?9hexHQF96wxYscogASMy9P8pv?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 30a870ef-4c92-4b1a-229c-08db4fbbfac9 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 12:01:38.9917 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ySqZQZFhC1qKTEWTt7T9+XIXvMOk9lm50FpkJDnldCQInZExpqSaj29qa2gxAKnom1B4T774pJOVc9OSCuEDKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8352 On 01.05.2023 21:30, Jason Andryuk wrote: > Allow cpuid_parse to be re-used without terminating xenpm. HWP will > re-use it to optionally parse a cpuid. Unlike other uses of > cpuid_parse, parse_hwp_opts will take a variable number of arguments and > cannot just check argc. > > Signed-off-by: Jason Andryuk > --- > v2: > Retained because cpuid_parse handles numeric cpu numbers and "all". Assuming you can convince me of retaining this patch: > --- a/tools/misc/xenpm.c > +++ b/tools/misc/xenpm.c > @@ -79,17 +79,26 @@ void help_func(int argc, char *argv[]) > show_help(); > } > > -static void parse_cpuid(const char *arg, int *cpuid) > +static int parse_cpuid_non_fatal(const char *arg, int *cpuid) > { > if ( sscanf(arg, "%d", cpuid) != 1 || *cpuid < 0 ) > { > if ( strcasecmp(arg, "all") ) > - { > - fprintf(stderr, "Invalid CPU identifier: '%s'\n", arg); > - exit(EINVAL); > - } > + return -1; > + > *cpuid = -1; > } > + > + return 0; > +} Looks like this function wants to return bool? Jan From xen-devel-bounces@lists.xenproject.org Mon May 08 12:31:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 12:31:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531487.827195 (Exim 4.92) (envelope-from ) id 1pw01I-0002e6-1X; Mon, 08 May 2023 12:31:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531487.827195; Mon, 08 May 2023 12:31:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw01H-0002dz-TC; Mon, 08 May 2023 12:31:11 +0000 Received: by outflank-mailman (input) for mailman id 531487; Mon, 08 May 2023 12:31:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw01H-0002dt-5w for xen-devel@lists.xenproject.org; Mon, 08 May 2023 12:31:11 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20600.outbound.protection.outlook.com [2a01:111:f400:7e1a::600]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 33c4ca0a-ed9c-11ed-b226-6b7b168915f2; Mon, 08 May 2023 14:31:06 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VE1PR04MB7295.eurprd04.prod.outlook.com (2603:10a6:800:1ac::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Mon, 8 May 2023 12:31:03 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c%4]) with mapi id 15.20.6363.031; Mon, 8 May 2023 12:31:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 33c4ca0a-ed9c-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H+z+ScDij6RZZ+fcDvMogE/+wNvDipT3fhhklDFmrG2+nwQ5a8wXAHbSJtMbx5UPKLEsTvlQ2gs4a/uIP5q3QMiOJp4Ymtl8vYvhkyCkHhii7S6qmYzJLhcV8k7lYmWXqK811hCiXtjM9SESQMn5ngTgZm/VgMUHv02ojDg6XG6YBX7mPyan0o+HTNdOlMShYRKp5+aZJ7f5CS4vjstWhVQ60p+zZinF0AsTURGGU0ceNzJXsnFCvbBBXw5TI+veW83y0rmi0dhwAawiDTS5MaEgkFnNCEx5RhRIUmOBzYc3TP0XNhC7qJjdlWbgVvNKuNaiOEv0CXSxNHBNRTcbCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M5UVgGCt7HFd6QpACbVczcENgH/UCk8cUe0fCdquCg4=; b=VDFQ6wd0GBDDF8yGclvg8V6pSo58JwPoWXi+fYEM9OL3ZG7MCeuKpsfRVfiUiHqQLD5J4tcivgScg9cMElFCmZ5imJNwAbp7F3+Icoz0bULhEAKqv9qPBP7u+x1bU7UGNfMi4miPrqjFtnxTXT0qCJ5q8JRzWhWAw7yNz0e7ShZ40cyb93qy2HvoKxhfHOfgJDtf9avVC+rNUObCnTkJ5X11xxR6ApeMuBRKAzZrmI3jETHGYaUDa6QT5Vw5i/vXS9rPL8zVaJfkBneA7i8Yp0+Jf5t7ZSKmocZdvgZPSXRLSFE1TvQCpqhJUEWZIgCt/oyhX5jYnBNfSQt6s36wSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M5UVgGCt7HFd6QpACbVczcENgH/UCk8cUe0fCdquCg4=; b=3GU+/ihArZcdilCAqaZOXlBhNFw/9TICS0xg+h0yvfZgaAeayRB2XXzJrGTDtIJ862jluyDWzh2aCg47H1IyEwyK1aCCFigdXKMm0rNeBQsoWhWOHdk/xAC6FgeHTZWslrYOHTpuUJrOx4KW63AAMqBbStHmF7lKpkZyj/YBPliKxsvM1hw9ZdY7xAJWYuz1XVrznPbQXgho1OdFLF5hXiUCQjiW6LMl1QMIlxVOGE7yyfoz6a9CHHZTgQeRzM6nzqtPQ2YddTz9qpGIxj4Ls+UKFPjNVwXdamQ5hZbffSwVsFGKJDnPC9gmTFHZBXFZpCU2Al16RAcSn5Sjkeh6vg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0b2a4e8c-ab43-4e6e-2c51-027dcdf1425d@suse.com> Date: Mon, 8 May 2023 14:31:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 From: Jan Beulich Subject: [PATCH v2 0/4] x86emul: misc additions To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0051.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:92::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VE1PR04MB7295:EE_ X-MS-Office365-Filtering-Correlation-Id: af34bd62-b7fa-4f8d-a448-08db4fc0161b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x2s8dJwPa701iSoFm+RCxs6OYxNvbVUnyzYJqdd1gh/JquLW/Peb8A0v/pA5jIGO0GWOQOU/yopV4gZRqpzPXRF9YZGOu2z87q0v1aAXzP+8uQ9Dyu7KE6YCQC0ypPxNfng/iCt45qwhdHo5T0p6AWPwxIScCD2wnXthWAmY0LA5O3wcaLcR2g0xPSq1MApcpkotykZjhTOiWjhVY840+SwSnP0BxnbPRDfgM9Q1Z3pMR6EqkATVhzEHAjhdgspJ4YSYZNz9UYy3sR9mmsniREAi7/KtHUzNHZ3yAPcum3aWjR2obuH6fpLD8wMIlfj08AoPTsKHBQlbnbCp1V6B+Yb3uw8hiywUjDr5KTCKeMR7ofp6IOrAHOnTo1x2vJ4HNexawLv3nKogQn5kdgDxlI0KJuWXqCuWtQ0dNpue/0dxWWABJD4q6njnTQx4El6dT58cJqdEvOY2AcU//fcrEQWYdmzPawHjBp1QM5xgcE1enzW6I7UYs08NJQM0NI2LRCuqgFt6thEB0TxDrNuRU56zKrfM0npeifKDfUrORBmz2Kas0QmJjUWrx6C74q3VLj8OAhLp90NKfDZUfg2o/oQpn9TtatI5HA/gXxNoBV90w3RlIPqfeLswtJfcI0qLmIkOKgZB+gnHy7S/l9YWpg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39850400004)(376002)(136003)(366004)(396003)(346002)(451199021)(66476007)(86362001)(31696002)(36756003)(54906003)(66556008)(6916009)(4326008)(66946007)(6486002)(316002)(478600001)(5660300002)(8676002)(2906002)(4744005)(41300700001)(8936002)(38100700002)(186003)(2616005)(6506007)(26005)(6512007)(83380400001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?clBZRk5SWUZiZG96TFhJV1BPNmhhZDBRbWt4eVJBcTRtaFR6dkZpQ0xFall6?= =?utf-8?B?M1RVVEV0UGk1VWduZ2lmT2R4YWNYYktQYSsxOHlBSTlBVVBVL1ZqNDc0WWVB?= =?utf-8?B?My96WXdONVN4dlBUMFVwSHd0UW5JUVNYVEdpMVJCL0VQM0FXdm43ZHBKRDF5?= =?utf-8?B?Mi9kd1BQRVBZbDZhSFBQZ1cxYy9RYmt1RDhWK1JNM05hZHo2L2ZWSHoyUUhL?= =?utf-8?B?c05IVE5xQUl3alhmRHZ2bDJQaWw3UTBacUx1TVR3S1cwT0l3ZDdWTUE0eEh1?= =?utf-8?B?eHZKTUJuK3BsdGU5b0lEZkdVTVMwbHNtNU0zcngvNFRxNnZVOU9mOFFCOUln?= =?utf-8?B?eWEvWWRPdXhvd09tZTQ1YUxPS2VkMjArZ2lKK2hvSmtTTXBacXVNZEk4Q0hm?= =?utf-8?B?RlMvYUlzby8zTVYxTWdVdE10T1ZGMzNrTytDZGRpTlViNk9GdnNXQk45NWJq?= =?utf-8?B?NnhaOXpHczh1SXlWRkFQd1Z4UkFPbVdwSWJHU1BIZFJiclF6ZGZuRFBNSDJz?= =?utf-8?B?WXRYUTRyN3d6bHNScElUbnN5d2lJMUt2dzJyNzIwYWpqQng1Um51V3hhakUy?= =?utf-8?B?eEkySFBzMEpzb3YvSFJZTTJIQ2ZpZWR4OXVGYVBVZW5jNnNLZXJicG9HNFpq?= =?utf-8?B?MXdlaXZMUHBHbURCdjFzTnBJeGxrdERCK21jdUM1RUxwZUI2QlVCeTQvY2Zu?= =?utf-8?B?cDJYWDBhSExQMjZGcko5LzNENW82d1VQTXdtcU0zbzMyNHdMWm9VR0RGVHRu?= =?utf-8?B?NUJCM0kwOHZPeHNETURsaG5Ca3JnOVVoTDJPaFUzWmRQZnZ5cUFMcnV4dWhx?= =?utf-8?B?UHp1dDgwVFRXSHJ2T3Z1QTMyQ0R5L0U4VHNTMDhINEtONVQ4bGNheDQvZ0s5?= =?utf-8?B?dHhUWEN5aTBCdHpaU2NHRnpWWVlHa28yVDRpemhyQzBVNjFWcXczZGxyTVk1?= =?utf-8?B?aTJkdXBnN0FBRVhzVlhIV2RIbE5Dc1k0SEgvOXRDckh0K2s5Sys1TStsb25s?= =?utf-8?B?RnFFQmsrS0djUGFER0ZlSVNCbVcwR0NHVm9TNGNvQzg2RlVzQTcxZUFNZWdj?= =?utf-8?B?VWM3SkZQRVNWYW15VU9tVFdQOWpOcG1MSGViSENJTHpEUWJSczFkd09tNDBl?= =?utf-8?B?dWRXK2l0cU5xZXhJcjF0Z1F1SHVxUXc3U3h0NXV3Ymh5ZExKaFpreWV3M05k?= =?utf-8?B?TE1haUtSbnh5dWRPU25hZ3RqT0ZlSkYvdXNyVlJpTVQ2NnFwS3hjdFBReWRW?= =?utf-8?B?T25IUVRhL0M2cCtFSU00MVFDZFJLMjVacVpZUEYwTEY0UTVMVkFxdWxTR1RU?= =?utf-8?B?QmRjdExhaG00SE9ZTnF1cUtnNThoM2lWMEIyY0M5NllTNFVhR0p5OWZtb2Zs?= =?utf-8?B?MkFTOHR4cEJxaEtpQTlpelduby81MnlOTGZzYkhLMGswd21NQ3kySXFVZmps?= =?utf-8?B?L0xWKzJhVlkxaldsVE9FVTY1MWNLRXAvVXBkT2Z0Tm5pSlZ0OUN3YkI3NER3?= =?utf-8?B?em5qZDROc0dsWVN3VjVNc3NtaXBuTVNlQ3FLMVFKUFkyb0kxTjVNdTAyc2ND?= =?utf-8?B?TGw3S2hXKzZ1NEVxNlYvWDRudVNWRWVsbjNFcEJRS21KLzhFWWlQT1VsUkNS?= =?utf-8?B?ZUJVT2pyUkFQRjFrdGM4Q2Fsa2hhQU9BUHc3ZUxKbC9NdW8xeC9IYTJCbmE4?= =?utf-8?B?bEFKTGdqTUpwei9pRlJnT3VWZHNOcVlxWVIxVm5hSktxU3FWZVJhY1QvcGdK?= =?utf-8?B?SkxYREFsemlJTHVQTXZKeTVoQUN6L0pRdkRpZ0VWTHYzUjRiYVJBdExsN2JO?= =?utf-8?B?dXFVcWtDQUdObmxldjZnVzY2cEdDaEY2NVBtK1VSU2VsWXZzK3BzY2EyRzdZ?= =?utf-8?B?bzBlcXIvUTd0bDRzK29Qa3pRRStBaHhaTElpeU5WQS9IaUVVNFRIUU8yMHdr?= =?utf-8?B?cVZ3SGlUZHk5K2tDMTZ6VSsrODNjd3hqQ044dk5kUlJsWFN1OUNuU1dsNUZQ?= =?utf-8?B?THA4QU5vUGJIR2ZGVUV6MDcyRWcvdElXejJGblVzYko1bDFXRytrOVk1WnJk?= =?utf-8?B?T2x6aEFDNlExZlBMUVJKUXlGRnZDMFRzYVFYZlZ6Wk5Yc3BSVDF6UzJnQXNC?= =?utf-8?Q?es98iVNgx+6tzoCEBO8NBOAVb?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: af34bd62-b7fa-4f8d-a448-08db4fc0161b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 12:31:02.7902 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rBRAFiwro7iwPnjipZFkcJfoutmDQ9PdtIHV7AjZFIfniKwOlVPfCoEJtmlzciHtmpHQAW5rooy1l1bgLh/zCA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7295 This series adds support for a number of more or less recently announced ISA extensions. The series interacts mildly (and only contextually) with the AVX512-FP16 one. Note that the last patch is kind of incomplete: It doesn't enable the feature for guest use, for lack of detail in the specification. 1: x86emul: support LKGS 2: x86emul: support CMPccXADD 3: VMX: tertiary execution control infrastructure 4: x86emul+VMX: support {RD,WR}MSRLIST Jan From xen-devel-bounces@lists.xenproject.org Mon May 08 12:31:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 12:31:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531492.827205 (Exim 4.92) (envelope-from ) id 1pw01z-0003CD-E1; Mon, 08 May 2023 12:31:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531492.827205; Mon, 08 May 2023 12:31:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw01z-0003C6-AI; Mon, 08 May 2023 12:31:55 +0000 Received: by outflank-mailman (input) for mailman id 531492; Mon, 08 May 2023 12:31:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw01y-0002dt-AW for xen-devel@lists.xenproject.org; Mon, 08 May 2023 12:31:54 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20606.outbound.protection.outlook.com [2a01:111:f400:7e1a::606]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4fe1b792-ed9c-11ed-b226-6b7b168915f2; Mon, 08 May 2023 14:31:53 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VE1PR04MB7295.eurprd04.prod.outlook.com (2603:10a6:800:1ac::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Mon, 8 May 2023 12:31:51 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c%4]) with mapi id 15.20.6363.031; Mon, 8 May 2023 12:31:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4fe1b792-ed9c-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CgUqpLVM9osGYUCCHVtiLDUssvjgYEB7tTIeQqFMUDUQM+2gNjFBQ2FkJA5viNURw89rBYUzqbe9RpfrDrrmnmmhoHUZtjjCsLD6W0c2iokMPpTSBDqxzypH0iL2/FOaIr9ZCyccvftw16TytMgLkfNWYiwzRpBSnwz3NI7zfsrDHXnQaDQEQWjPfbl8oSkAq/gE+R5qvPIN8FQWBeY6eUN/fb/D4YTlcnTXfbHzj4K3GDP6cLPOtACZuRtF55/tz2VbLSFOWfEuAoidfwOGnF9mzaKDbGWbzs/MlEBQvJspdM4nPQ+ztK9jW30ESu7LYg9untlwuxNqBrMc4ve5Vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CrPGkiGtKBG+qztGkkVUfaZrvhhRCY5QnAOoKkRTviA=; b=DVk7adZOKnJV/1afhWsAxaH858C6T4nXKz1wjAUPbqiogaYdWg/TSgckBJ26jt2L+/HTqD3tRkY125XnA0I0yoqg8QseCH3+AIdGoyI3oRZ8yrqufaMugAcDaCXcVAruVlUp9FfLQTBAMyCd4VUyob8LQdCH2zXU+fx7cS4sOV8FjJWj+ZN7BQ13dHtk/ezr/RJoZRi9CzIkZ2jRGhroLw7kgBXHCSDuPKYHr/v7el3HZFkKx5L2mWT3/ARWz8O/ExhoWgszOmsd4F7LO0HoLLtZLzyihmkr+hH9GFIHK9x0EyQzuAqivTil+SP2PbqmsYTVftGeDAPIritDB86G5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CrPGkiGtKBG+qztGkkVUfaZrvhhRCY5QnAOoKkRTviA=; b=XKCaGV2E+S4YRgwLx8E41DpuF+jIVfBqx4jiRB7x0/OJ6brmE76xlvkIDp+jjAxX39ViCo/C1sC/BecMei3MbXBwxu4UoefZ6ux94AIzW/YJcaqbLGHLaWcDqv5eY143fMm71XEqFz3vbmgfIxWUIWDv7q8JvesA76VVy4l551nc8472e3Bc6Sxko/0GOtZBVsaVEfWBQWtEqA1/azliUR0Mx3ajVGteVdgrpRq2fxn3tdV4Y75BWnJ6Ams3wq1AV77fTjkpNAP2OKpWuOxx570+IQiqIz9LOfGlTf36hYz64gS4FeQ2AOiAyhnqwSZi7y3p1xBOXCKV9Rv9o+0nxw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <45cc879f-5c98-e0c5-e791-7c297ed1eb41@suse.com> Date: Mon, 8 May 2023 14:31:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: [PATCH v2 1/4] x86emul: support LKGS Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <0b2a4e8c-ab43-4e6e-2c51-027dcdf1425d@suse.com> In-Reply-To: <0b2a4e8c-ab43-4e6e-2c51-027dcdf1425d@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0037.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:92::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VE1PR04MB7295:EE_ X-MS-Office365-Filtering-Correlation-Id: a4af7b62-c000-4906-c034-08db4fc03335 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HbLWawHKETiXsIm2+lJd9OK+CEWuGwwZMuYpw17Fl+SfP+NbDfSoZ0LmACpOBhWJgHagVpbTCNlJmJAas6DXataCbW2/TfMzED8W0fuUEK/xXLvmUAojg/mtuF92h5HhpPUbIUNKCnhbiKwu87cWy5OIbPT6l4P96kE/j3ZwWALUD+UBYpzilL2se3NN2Fpywtl2PyVM+UY9WgfjMTJLjNrCwZxuz9MwgIzrKrhoaRQA/z8DfxNSKgoHz38ZC2ch4Vvpm5AqvQU/rbFtfOwk7QjtTQP+E+j82mVSEAmF7VG5u687Ca6X/TJ+C+AMHlIrMc7r4jjrcMPVus8vjUJTg4JS8JyXJmw9B+pjqZWo1vF4rY8/M+lq0DVSyKSeN6j5lnFcPg1E15rUYB1Fd79n+/MxKj9h312JI2yakYYVTAitfUY3oOGotjuBfknAAqQcqrZEumyLXJtJ+XPu29y0MJot/k4kWKcv+NDR8ik5aENIh1QM+wEH/vGGBXP9oE9sT1dAuGMhlyJtH9ZpJXLg4tnCGNRJS6DDQx45Lf2FfA0ZqDqjJQC7IeRQ8qg6X+dy/DEAyxJNe0/cLhr00tyDT98Tr6eV9XmRKgtBixmX75hv51sEGTMPqwi7fpb3F1ejrnEQ9fjMJWy/cCc1VWOBNA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39850400004)(376002)(136003)(366004)(396003)(346002)(451199021)(66476007)(86362001)(31696002)(36756003)(54906003)(66556008)(6916009)(4326008)(66946007)(6486002)(316002)(478600001)(5660300002)(8676002)(2906002)(41300700001)(8936002)(38100700002)(186003)(2616005)(6506007)(26005)(6512007)(83380400001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MnhUdkFFUjVtUWU3ZVhkbS9RQWt0RDVYSHR2VVdXSDNQRkFRNUh4V3AxT00z?= =?utf-8?B?SnkrRDltbUZlclJUaVVxalArd0xxT2xOa0ZwTGFaWFpjSm1rQ0pHUFkvaDJZ?= =?utf-8?B?WG0yNzd5cTczQ0pJWCtlb254MnJWMHlBWDBTSnVFZ0dGQ1N5K0l0UUY2WDI3?= =?utf-8?B?Tjh3dkdPc1hwS3VuSTJ6OCsyZThsRXBVZ3JTcldZTHIzNFIvRzJJQ0YrcVhO?= =?utf-8?B?NS9sU3VRY052UC9nR21yeDRaaGNYTGQ2MTJya05JaGI2M08rQkgweENDVHMr?= =?utf-8?B?T1VWeVg5bWU2WUVCSHV2OTJOaGsyODkyK3VMK0plN0FDY0IrTjNQWUhpclVD?= =?utf-8?B?Y2kyZzhZbkZmV1hXSGhpK1c0VGxaZkc2TmxuK1pnUUxxbnM0R1IzMWxkRWlO?= =?utf-8?B?RWIyWlJqWXJQMnV0L2Q3VUlYb0xSU0V4M09aRlY3QVBOc2VLMzN2TFRjczFU?= =?utf-8?B?Y3Zwbk1qTDJ5MFpYMG5xWWxudHFmK3R1MDV5ODJKWDZqaE1TODlXaFQ3Ulpp?= =?utf-8?B?dU9MZUJ0U2Q2UG1udEp4U2VFVzNIUm9GYVNYYUsrRHdYWTE2ZUwrelFubzFL?= =?utf-8?B?aTQ0Umx4K3gyd3pBbEdscXE3NWdvVXF4K2t3SWcyNW9jSzkzWkNXUGl5TVVY?= =?utf-8?B?WFAxbDFkYUZUZ0ZzS3FTZXZPU0Y1Q3JyZWpjbFYzYllYSG92QU9KSVhoK3Na?= =?utf-8?B?T2p4WHRtaFhWS3hpL1VVTXpSUlFQdWJlcW04ZWsyZ0g3SGZlQktXUHJKSlZ4?= =?utf-8?B?TjIzSFlyY1Fkb0E5aFFPQnFFM0h5SXlXWlRDYVpXYW00dFJUYTRvaVhKOXps?= =?utf-8?B?V0ZhOTVIU2RRbE5aNGFROE1yeUtrUVQ4VURsbzF0NUV0VC92NDF0c2hQUUNH?= =?utf-8?B?UG41ZTAzRGhOVmFuTllFVXN5Sk5qV0tDY0RwYkIySVhTdDZvS2NaakNmN3ZL?= =?utf-8?B?NVNodWlYK21rNFJKb1dTVEFLODNQMjBqR2tTYUtjRjdFZFJNbVJlUWtpMzhO?= =?utf-8?B?QTRURHFzSjUzWUtPOHJPSjVtakxaQnpNWEI0S29ZL05nK3Q0aDI5bktmOFhR?= =?utf-8?B?VmluOUNabzBFQVRGWVNTbG9KMzRCclVKRlljTE1UdXBndGg2YURveENWZ29R?= =?utf-8?B?aGNRYWxZNnpLS2M2cjROT0xGRVYzY05CNDM4VnBkZW9wMkluNGlmU3lsa0Iy?= =?utf-8?B?S0ppd0lnSERERE0zTjZ5SzRqS2xtSWg3Nk5ocjNVYzhnQXlKMEZwa1A4dkJH?= =?utf-8?B?WTRYeWZCaGM3STRRVE15dTU3a01GYjFHRWR2VzRaZDZ2c1lDeXJpS2NmSXRk?= =?utf-8?B?QStSL1BsTTlscVhSWDAvTG9yUWs5cFp4Q3ZERC9GcjgzSXpDc3BGWUVQZ2Q2?= =?utf-8?B?eWNZdElLV2p3Znp1WDkxRnZ0RW02SmZIQzF1dmU0bjRkUFNoMS9yY1psUml0?= =?utf-8?B?VHFIOWRHRWdPam5HTzJTRXlocE9KdXZFN0cwYWlwclNDWWR6dmkyMkY2VTUy?= =?utf-8?B?NGhXNWpxZk4wUUMvZmE4WTQxbVd0MG5aTEpEUmdUOXRYUGlPYUI2TDJwTmtv?= =?utf-8?B?d2YxaFFYYTBva25xdkt2SWxTclRpbG52bVVLUlBUTVNDbnMySCtDTEk3QU5Y?= =?utf-8?B?TDY1aUwwRDhVbTJQNU1jSDBCM1Baak83YmlYOEFaYVRENWNKUlNLRDNEMlVC?= =?utf-8?B?Q3JJQTA0N0JqOEdXVWxaeFJRQ1hvUjdDZE9oem1WVnMrekE2cHdxQ0lMRGFH?= =?utf-8?B?ZDZpd1BvZ1FMcW5Dc2JROGpLYU5xeURFNVJoYkVPRVY5bHFONXc2MHJLK0dR?= =?utf-8?B?enhyL2JTRWNTVDZUODRrc2libFlMTTRxUitDSzhaRkxQTGJrUTFSTC9rdXpq?= =?utf-8?B?dzQvWHg5V1Rob3lOblV2Y1FUakhYOHdIWGp4SHJZSjdkVG5GeW9ObURkWTE2?= =?utf-8?B?WFF3VFpVRlpUOFlaMVpldGZBZlJKTVpwZnE5SUlRd3Rnc3ZHWE1oeWhMR1g2?= =?utf-8?B?L2VNQVJOTzlyNnI3aWxHMEVma2xwSHhoMTR0NXNTalhrT2hnL3owR1Z3Zlln?= =?utf-8?B?RFJBZVpqZFNhOXVDWjdlc2tnNkZFS3VkVS9Gci9OUFEwSUY4TWlWRWIrZlhv?= =?utf-8?Q?HEfI0UcUamx8dRxvmOQcFFCF4?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a4af7b62-c000-4906-c034-08db4fc03335 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 12:31:51.6077 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rY3IlyLE57KTMgd9iqgBZl+wZ1u/2iZ2HWbmqt270FUcNdMBB6XuBIuJmQvHir+7g39vjPebMZ2hHumcjY19jw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7295 Provide support for this insn, which is a prereq to FRED. CPUID-wise introduce both its and FRED's bit at this occasion, thus allowing to also express the dependency right away. While adding a testcase, also add a SWAPGS one. In order to not affect the behavior of pre-existing tests, install write_{segment,msr} hooks only transiently. Signed-off-by: Jan Beulich --- Instead of ->read_segment() we could of course also use ->read_msr() to fetch the original GS base. I don't think I can see a clear advantage of either approach; the way it's done it matches how we handle SWAPGS. For PV save_segments() would need adjustment, but the insn being restricted to ring 0 means PV guests can't use it anyway (unless we wanted to emulate it as another privileged insn). --- v2: Use X86_EXC_*. Add comments. --- a/tools/libs/light/libxl_cpuid.c +++ b/tools/libs/light/libxl_cpuid.c @@ -235,6 +235,8 @@ int libxl_cpuid_parse_config(libxl_cpuid {"fzrm", 0x00000007, 1, CPUID_REG_EAX, 10, 1}, {"fsrs", 0x00000007, 1, CPUID_REG_EAX, 11, 1}, {"fsrcs", 0x00000007, 1, CPUID_REG_EAX, 12, 1}, + {"fred", 0x00000007, 1, CPUID_REG_EAX, 17, 1}, + {"lkgs", 0x00000007, 1, CPUID_REG_EAX, 18, 1}, {"wrmsrns", 0x00000007, 1, CPUID_REG_EAX, 19, 1}, {"avx-ifma", 0x00000007, 1, CPUID_REG_EAX, 23, 1}, --- a/tools/misc/xen-cpuid.c +++ b/tools/misc/xen-cpuid.c @@ -190,7 +190,8 @@ static const char *const str_7a1[32] = [10] = "fzrm", [11] = "fsrs", [12] = "fsrcs", - /* 18 */ [19] = "wrmsrns", + /* 16 */ [17] = "fred", + [18] = "lkgs", [19] = "wrmsrns", /* 22 */ [23] = "avx-ifma", }; --- a/tools/tests/x86_emulator/predicates.c +++ b/tools/tests/x86_emulator/predicates.c @@ -326,6 +326,7 @@ static const struct { { { 0x00, 0x18 }, { 2, 2 }, T, R }, /* ltr */ { { 0x00, 0x20 }, { 2, 2 }, T, R }, /* verr */ { { 0x00, 0x28 }, { 2, 2 }, T, R }, /* verw */ + { { 0x00, 0x30 }, { 0, 2 }, T, R, pfx_f2 }, /* lkgs */ { { 0x01, 0x00 }, { 2, 2 }, F, W }, /* sgdt */ { { 0x01, 0x08 }, { 2, 2 }, F, W }, /* sidt */ { { 0x01, 0x10 }, { 2, 2 }, F, R }, /* lgdt */ --- a/tools/tests/x86_emulator/test_x86_emulator.c +++ b/tools/tests/x86_emulator/test_x86_emulator.c @@ -666,6 +666,10 @@ static int blk( return x86_emul_blk((void *)offset, p_data, bytes, eflags, state, ctxt); } +#ifdef __x86_64__ +static unsigned long gs_base, gs_base_shadow; +#endif + static int read_segment( enum x86_segment seg, struct segment_register *reg, @@ -675,8 +679,30 @@ static int read_segment( return X86EMUL_UNHANDLEABLE; memset(reg, 0, sizeof(*reg)); reg->p = 1; + +#ifdef __x86_64__ + if ( seg == x86_seg_gs ) + reg->base = gs_base; +#endif + + return X86EMUL_OKAY; +} + +#ifdef __x86_64__ +static int write_segment( + enum x86_segment seg, + const struct segment_register *reg, + struct x86_emulate_ctxt *ctxt) +{ + if ( !is_x86_user_segment(seg) ) + return X86EMUL_UNHANDLEABLE; + + if ( seg == x86_seg_gs ) + gs_base = reg->base; + return X86EMUL_OKAY; } +#endif static int read_msr( unsigned int reg, @@ -689,6 +715,20 @@ static int read_msr( *val = ctxt->addr_size > 32 ? 0x500 /* LME|LMA */ : 0; return X86EMUL_OKAY; +#ifdef __x86_64__ + case 0xc0000101: /* GS_BASE */ + if ( ctxt->addr_size < 64 ) + break; + *val = gs_base; + return X86EMUL_OKAY; + + case 0xc0000102: /* SHADOW_GS_BASE */ + if ( ctxt->addr_size < 64 ) + break; + *val = gs_base_shadow; + return X86EMUL_OKAY; +#endif + case 0xc0000103: /* TSC_AUX */ #define TSC_AUX_VALUE 0xCACACACA *val = TSC_AUX_VALUE; @@ -698,6 +738,31 @@ static int read_msr( return X86EMUL_UNHANDLEABLE; } +#ifdef __x86_64__ +static int write_msr( + unsigned int reg, + uint64_t val, + struct x86_emulate_ctxt *ctxt) +{ + switch ( reg ) + { + case 0xc0000101: /* GS_BASE */ + if ( ctxt->addr_size < 64 || !is_canonical_address(val) ) + break; + gs_base = val; + return X86EMUL_OKAY; + + case 0xc0000102: /* SHADOW_GS_BASE */ + if ( ctxt->addr_size < 64 || !is_canonical_address(val) ) + break; + gs_base_shadow = val; + return X86EMUL_OKAY; + } + + return X86EMUL_UNHANDLEABLE; +} +#endif + #define INVPCID_ADDR 0x12345678 #define INVPCID_PCID 0x123 @@ -1331,6 +1396,41 @@ int main(int argc, char **argv) printf("%u bytes read - ", bytes_read); goto fail; } + printf("okay\n"); + + emulops.write_segment = write_segment; + emulops.write_msr = write_msr; + + printf("%-40s", "Testing swapgs..."); + instr[0] = 0x0f; instr[1] = 0x01; instr[2] = 0xf8; + regs.eip = (unsigned long)&instr[0]; + gs_base = 0xffffeeeecccc8888UL; + gs_base_shadow = 0x0000111122224444UL; + rc = x86_emulate(&ctxt, &emulops); + if ( (rc != X86EMUL_OKAY) || + (regs.eip != (unsigned long)&instr[3]) || + (gs_base != 0x0000111122224444UL) || + (gs_base_shadow != 0xffffeeeecccc8888UL) ) + goto fail; + printf("okay\n"); + + printf("%-40s", "Testing lkgs 2(%rdx)..."); + instr[0] = 0xf2; instr[1] = 0x0f; instr[2] = 0x00; instr[3] = 0x72; instr[4] = 0x02; + regs.eip = (unsigned long)&instr[0]; + regs.edx = (unsigned long)res; + res[0] = 0x00004444; + res[1] = 0x8888cccc; + i = cp.extd.nscb; cp.extd.nscb = true; /* for AMD */ + rc = x86_emulate(&ctxt, &emulops); + if ( (rc != X86EMUL_OKAY) || + (regs.eip != (unsigned long)&instr[5]) || + (gs_base != 0x0000111122224444UL) || + gs_base_shadow ) + goto fail; + + cp.extd.nscb = i; + emulops.write_segment = NULL; + emulops.write_msr = NULL; #endif printf("okay\n"); --- a/tools/tests/x86_emulator/x86-emulate.c +++ b/tools/tests/x86_emulator/x86-emulate.c @@ -86,6 +86,7 @@ bool emul_test_init(void) cp.feat.adx = true; cp.feat.avx512pf = cp.feat.avx512f; cp.feat.rdpid = true; + cp.feat.lkgs = true; cp.feat.wrmsrns = true; cp.extd.clzero = true; --- a/xen/arch/x86/x86_emulate/decode.c +++ b/xen/arch/x86/x86_emulate/decode.c @@ -734,8 +734,12 @@ decode_twobyte(struct x86_emulate_state case 0: s->desc |= DstMem | SrcImplicit | Mov; break; + case 6: + if ( !(s->modrm_reg & 1) && mode_64bit() ) + { case 2: case 4: - s->desc |= SrcMem16; + s->desc |= SrcMem16; + } break; } break; --- a/xen/arch/x86/x86_emulate/private.h +++ b/xen/arch/x86/x86_emulate/private.h @@ -583,6 +583,7 @@ amd_like(const struct x86_emulate_ctxt * #define vcpu_has_tsxldtrk() (ctxt->cpuid->feat.tsxldtrk) #define vcpu_has_avx_vnni() (ctxt->cpuid->feat.avx_vnni) #define vcpu_has_avx512_bf16() (ctxt->cpuid->feat.avx512_bf16) +#define vcpu_has_lkgs() (ctxt->cpuid->feat.lkgs) #define vcpu_has_wrmsrns() (ctxt->cpuid->feat.wrmsrns) #define vcpu_has_avx_ifma() (ctxt->cpuid->feat.avx_ifma) #define vcpu_has_avx_vnni_int8() (ctxt->cpuid->feat.avx_vnni_int8) --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -2853,8 +2853,35 @@ x86_emulate( break; } break; - default: - generate_exception_if(true, X86_EXC_UD); + case 6: /* lkgs */ + generate_exception_if((modrm_reg & 1) || vex.pfx != vex_f2, + X86_EXC_UD); + generate_exception_if(!mode_64bit() || !mode_ring0(), X86_EXC_UD); + vcpu_must_have(lkgs); + fail_if(!ops->read_segment || !ops->read_msr || + !ops->write_segment || !ops->write_msr); + if ( (rc = ops->read_msr(MSR_SHADOW_GS_BASE, &msr_val, + ctxt)) != X86EMUL_OKAY || + (rc = ops->read_segment(x86_seg_gs, &sreg, + ctxt)) != X86EMUL_OKAY ) + goto done; + dst.orig_val = sreg.base; /* Preserve full GS Base. */ + if ( (rc = protmode_load_seg(x86_seg_gs, src.val, false, &sreg, + ctxt, ops)) != X86EMUL_OKAY || + /* Write (32-bit) base into SHADOW_GS. */ + (rc = ops->write_msr(MSR_SHADOW_GS_BASE, sreg.base, + ctxt)) != X86EMUL_OKAY ) + goto done; + sreg.base = dst.orig_val; /* Reinstate full GS Base. */ + if ( (rc = ops->write_segment(x86_seg_gs, &sreg, + ctxt)) != X86EMUL_OKAY ) + { + /* Best effort unwind (i.e. no real error checking). */ + if ( ops->write_msr(MSR_SHADOW_GS_BASE, msr_val, + ctxt) == X86EMUL_EXCEPTION ) + x86_emul_reset_event(ctxt); + goto done; + } break; } break; --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -281,6 +281,8 @@ XEN_CPUFEATURE(AVX512_BF16, 10*32+ 5) / XEN_CPUFEATURE(FZRM, 10*32+10) /*A Fast Zero-length REP MOVSB */ XEN_CPUFEATURE(FSRS, 10*32+11) /*A Fast Short REP STOSB */ XEN_CPUFEATURE(FSRCS, 10*32+12) /*A Fast Short REP CMPSB/SCASB */ +XEN_CPUFEATURE(FRED, 10*32+17) /* Flexible Return and Event Delivery */ +XEN_CPUFEATURE(LKGS, 10*32+18) /*S Load Kernel GS Base */ XEN_CPUFEATURE(WRMSRNS, 10*32+19) /*S WRMSR Non-Serialising */ XEN_CPUFEATURE(AVX_IFMA, 10*32+23) /*A AVX-IFMA Instructions */ --- a/xen/tools/gen-cpuid.py +++ b/xen/tools/gen-cpuid.py @@ -295,6 +295,9 @@ def crunch_numbers(state): # In principle the TSXLDTRK insns could also be considered independent. RTM: [TSXLDTRK], + + # FRED builds on the LKGS instruction. + LKGS: [FRED], } deep_features = tuple(sorted(deps.keys())) From xen-devel-bounces@lists.xenproject.org Mon May 08 12:32:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 12:32:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531496.827214 (Exim 4.92) (envelope-from ) id 1pw02u-0003km-MI; Mon, 08 May 2023 12:32:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531496.827214; Mon, 08 May 2023 12:32:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw02u-0003kf-Je; Mon, 08 May 2023 12:32:52 +0000 Received: by outflank-mailman (input) for mailman id 531496; Mon, 08 May 2023 12:32:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw02t-0003kR-BP for xen-devel@lists.xenproject.org; Mon, 08 May 2023 12:32:51 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2054.outbound.protection.outlook.com [40.107.7.54]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 71ce1d66-ed9c-11ed-b226-6b7b168915f2; Mon, 08 May 2023 14:32:50 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9318.eurprd04.prod.outlook.com (2603:10a6:102:2a5::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.31; Mon, 8 May 2023 12:32:19 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c%4]) with mapi id 15.20.6363.031; Mon, 8 May 2023 12:32:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 71ce1d66-ed9c-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fEZMnXKndzpA6XdwcjBjIfNx4MtGsrAvH0l8/f+fJicKwj0I32vZPWGqLYj/RKFUmUSAVBuocPPUAscGxVxEgBw/Chl1qHuaBJA6EXFo6mGXrA1UodZ7aQVAv57S/CwOvzItznAVdFdW1eiTlYddCd9e23z69mj/UQ4uVBWv5/fh8vyVUq4UgSlqh6VVP4+BbXfEu/IVNB6Q7SJSncOaaMq9WQYty8w4u7MHMo2mEHIGWMjRAaUxCLWtjYEP1XjxS24A1XOqlOOZ+mop/9NNvvvVtOCQEykIhMUH+NKDdWgkFjTjdm1zS1SGC4fwgk94LEVyXZgek0PT80g3roH7cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+5Qg+ImWbYH/+Yy12xrDGChaMfeAnfUy605gAGbDUlA=; b=KqOShkVIKSGzntf6Yk05TEy3TJ1h9cKDMK1i6FZ8LnlhFz4J2MGsDe0ruHMFBqJBeR/L8gL/U0rZQDgAblo2YCv+Q8elmxbPed7n7ZDFwMCCRTrGoHPgLOd8xjjDd5P33Uhby0nh4Tm3ZxpZlvuDkbCUibL3dM2QBcQ5yUnF+nAUv25z9TNjcp8zqhDn4AtEcuG3llArjL4UC+/Xl4bQhZlR1ND2IEhuGxz/z0lK62SCx1A4nxypRpwCz6l1kDqrQqqhAXY4eb68kq5H1UwmXX7uWKvOTf0d8fhOJ7066I2QBPdiA7K/kus8+VH18CkTjpg0YwZSEZseZCxV1nlnWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+5Qg+ImWbYH/+Yy12xrDGChaMfeAnfUy605gAGbDUlA=; b=vzjTYd75GRABI0iKJy2LBxUD9KbP9jPkUiLdL0vTSq/6rk7d4aqou2wuPpP/jcGYspevO4u/pdywmP/dSL6BV6cUg9/NNvY0MNEkAbFTLX1b5QJDZ8Nj+tWAcMwrzuty1FNAcHlvjfUWr7hay3CQy/JiSqn7PtiMChenQetjkicMFmxvwNSib4FpR5vHGQhea3ILog8SmUTjGG/xwzhLt6TNnGQpkdXwHBE8cL1z/iUMGMjCPEC/uc0iToOxp6i79dBNeGKKx9xHHlA2G3ld2g/UZq5Dd6ro8PW5f7eARJSk2L+Yu6zgfQJNenTW0I9KiRY73BSR3Gte/cl8OCoiDw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <33865bc0-2c90-0501-0ef5-65818973f417@suse.com> Date: Mon, 8 May 2023 14:32:18 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: [PATCH v2 2/4] x86emul: support CMPccXADD Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <0b2a4e8c-ab43-4e6e-2c51-027dcdf1425d@suse.com> In-Reply-To: <0b2a4e8c-ab43-4e6e-2c51-027dcdf1425d@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0101.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9318:EE_ X-MS-Office365-Filtering-Correlation-Id: 9874a92e-9590-4418-c82b-08db4fc043fd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xtrCO/0lSJTrZeYluK7qH4Lm7FkziCgFFCtBkwDZEbStLXRp/JhxgVqOaytRLX5yWz03G31ByERGPT5C3K1SXvQV+JikAv2Cmj2B3F9lm3az7HvZU6p4OQBS+1EOK3v/STHj5CEh5XcrFFsS/V0l66pljNadi0+pZhc3IjcjMIpv6YAckHiMgDGCURwpqSomrWecCJJbWJ0+NknJFM2n8tNT5AufPckBbVkXJVPzIMi8tgImOOq8Dz8eME+zLWVb853w+z89ebMJCmw8Yh/BfpWy9Bw+5vnUxrEm8UnKcdMi8clxaTM1N7ppjQe/9BzNWmEizY353jDGlvld9ocBjdsXvOmFMaRmwaoNwnV7Eps5qPBQQLmCFf4OikVSaFCbfhJ4l8qmMTWa4qYMXznUq8POP29kF0XE+geV28q18NWAz+v8heTnMz02FzvtW6kW8vmIr/Om/jbLGSLHwDFPUuPOrKTG9Pf33Qa/artioaXxfPRWk1U4UKIMUXOG6jxsXob8u0mh411RjWk50xsV2tPZkAK/v/01u730c9wDd+JdHEKi173xlUwnSxeKvtBht8ecnyDJBAf2rgxXk0TV2qsdJy2SMPi2ZTOoQwf6nq0UcnKAmnmOkbYsN7BPzR/i48kgxwov0Cy0PI0SpPWJrw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(396003)(366004)(376002)(346002)(136003)(451199021)(31686004)(36756003)(38100700002)(2906002)(30864003)(8676002)(5660300002)(316002)(86362001)(31696002)(8936002)(6916009)(66556008)(66946007)(41300700001)(66476007)(4326008)(83380400001)(66574015)(186003)(6512007)(6506007)(26005)(6486002)(478600001)(2616005)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SUlmYllmTWQwbUtEOEEvYkFTVVdXL3pwamdmMHkwZzF4clpONHJFVDNwdTVs?= =?utf-8?B?YmI1QzRHamUzMDIzM0lJTmJwQUZla2lDTXRxaENqb21MZzl4TUdiK3hGRVhz?= =?utf-8?B?WGNXQVdPdjdiNWtOZnRJSnZDS2JzVWJjVFZCVitsRnBBSnE5WXFjQ3A5UC9n?= =?utf-8?B?ZTBBRjBhdjk5VU1qSERTRHpQS2pSRFBXMHN5TWZoUTVQamlsNGVqODdlRUpH?= =?utf-8?B?OG1JQ2hKWW8wcXpjQjJxc1p1TEM0a1ZSaDdXQkhaUVpjYTJITzYyYzJzMnRn?= =?utf-8?B?dHFuYjEycis1bWdkeFVwUWxsWkFyQko1MHNoL0tMa0hlakQrV0NqOWNZb2dS?= =?utf-8?B?ODZjWk9IaTNNbEI2VUFBOThVWXY1VmtjcWZVOEk2Y251Z2lDM3VuQVRnWHpw?= =?utf-8?B?NnJDZ0RRMVlEMmh3bnhzQ3pPVVZTT1FrOGUza3VnaFQ4Tk1RTnE3dTY5dnQy?= =?utf-8?B?M05oOUJvbVVIdi8yd1ZiMjBOVHdPNzZPa3JqVXc5SzRkVWZnTWg1S2tmSmlD?= =?utf-8?B?MmRidzFiTzlEZnhRelVRZnI2WmxPLy9lb0k1c0V1NGxhMitxdG9KSzJJZWF2?= =?utf-8?B?ZU56Q2ltMExaTHoyZmRtcjJva20xMUp3UjJRa0VKc2pWc1ErcnozaWd2UWxm?= =?utf-8?B?OTY1L0crbEVNa3RiSUVIenlCdVNGNlJKQnRyZk0rVnMySGlrWFBQVXBTQ3R2?= =?utf-8?B?d21iNGowOThoZTd1WGdtWXR4WXhzYWxBTDZqZVE0eG9Gc3Uwb0lkclYxbU0r?= =?utf-8?B?Vmc5V0hGQnhjWmhSdTNLSkJlVWNYMXFRUUNaNGZDMk4wS1pKMCsxNXgwTldC?= =?utf-8?B?WVM3bGpVbXBOOHZad2RZYTNBbTU4Nm01US9pWm5DejlnbUVLa1VxWE5ONHBX?= =?utf-8?B?Um5rYjB3dGRFKzJkTWJUcVVMQXVvaTJCRnl4Vi9Za2xndkZwLytDSGtyRUdy?= =?utf-8?B?U2tHbjg1OGI1cHVTUC9IVG9lN2FTeW81aFZhSnJ3T2pyL2hoMkNCTkswNWFo?= =?utf-8?B?enRGanRkUWMwWFZHQW9NbzU3b0pUeUVsQWtaS21KRHdxNUhkNkdJSWZuZ0gy?= =?utf-8?B?bWVEMEFBVXVmR2tKblIxOS9KT09nOFBENHZoRkhNRisyNWJTSVpXL3lwY3F4?= =?utf-8?B?bTVyQ0Q5NU5tNElpNEZrUkNUTTd1QVlRc2pKakhJSGNsMkhYUXg1eXFoa3Rz?= =?utf-8?B?ankxeWxDWGFjQWlseXRDOWhwc0cyWURUWElNZ2NTWnp0M2t3U2RmRXVUZytz?= =?utf-8?B?REtiU0lBcDFIZmVjaVVSc3FaRHAvZzdQMEJ4MTJkMzZ0UGRZdHhEbmQwOGxP?= =?utf-8?B?akNlZzQ1RkNFWmNWV0N0cmRPdUdJaEN3UW1SWUVYQkxsUkRGa0pyckhpd0Mz?= =?utf-8?B?K3RQWlgzVHlKRWFrZ3VhL2J1TVVySElLaG05dGUyU0lIc1VsU0FYa0ZsTWJy?= =?utf-8?B?L24zd0xqUXNacFFCYUZhQWJiNEpkWk14U0l1NENoR3B0cTJZQW1TcUtvSmc0?= =?utf-8?B?SWhUeXYxUTN2bDFJVkFFbUs1NGFPVjZjVjFhbWFWTDZSY016dDRsaW9HMnB3?= =?utf-8?B?K1RPT2ZzOFRZTkxBNG1pUDhmVHBXa1c3a3dpYTc1N0o4dStSTk5kSXdNemtN?= =?utf-8?B?ZUNnZnJUaW95TXI2bzc3bkRycTNGTWJzZkVES2FGdUpING9JMTVpZTdIaDEw?= =?utf-8?B?bFV4S29nZHpUaDZSYU9DNkhFcWExRXlHa1ZJc29lVlNBSDRQNHZkNEFJUGg3?= =?utf-8?B?ZGJsbklUMFFEcndqMlAvcnlzQ2RDalN4bVVvaWc4S3cvWGdUNStMb0VKUlBU?= =?utf-8?B?c1RnUEFYc0NESjVxZWpxbDNOc0llN1htZ3VvdUxEN3NheEhSdnRONU4rYW9T?= =?utf-8?B?U0JER3RCRk1TOXkxaVNVWCsrQWxYRWNDM3ZIcE4rL2JhTDF2ZXM0UE8wdUpO?= =?utf-8?B?MzZnSFlHU2xFNUl3Ty9JWFZDdzNRbFlPZll6WGxjc1ZudkFqZFZHM05NTlpG?= =?utf-8?B?U0xaemxrckw3cWFMUmhrbURCdzkrMVQ0ZGlJSVRKNHE1cWVDalh0NGs1a0hy?= =?utf-8?B?dHh6SE1SUVM0UmYzQjFZQVJDbHVDTHNXVkQ1RVg1OXNMdjc3K3h2RVVkZmhq?= =?utf-8?Q?ObURvX23XcXao5nR0hPbGL0C+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9874a92e-9590-4418-c82b-08db4fc043fd X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 12:32:19.7984 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JoU+21pGfpQlgWgEL/BK0UcrR7pGm2gbchRraPljI3p2lgtfmQbBLXl9jPR3/tairSfRAiR+Gt56URYR6S95XQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9318 Unconditionally wire this through the ->rmw() hook. Since x86_emul_rmw() now wants to construct and invoke a stub, make stub_exn available to it via a new field in the emulator state structure. Signed-off-by: Jan Beulich --- v2: Use X86_EXC_*. Move past introduction of stub_exn in struct x86_emulate_state. Keep feature at just "a" for now. --- SDE: -grr or -srf --- a/tools/libs/light/libxl_cpuid.c +++ b/tools/libs/light/libxl_cpuid.c @@ -232,6 +232,7 @@ int libxl_cpuid_parse_config(libxl_cpuid {"avx-vnni", 0x00000007, 1, CPUID_REG_EAX, 4, 1}, {"avx512-bf16", 0x00000007, 1, CPUID_REG_EAX, 5, 1}, + {"cmpccxadd", 0x00000007, 1, CPUID_REG_EAX, 7, 1}, {"fzrm", 0x00000007, 1, CPUID_REG_EAX, 10, 1}, {"fsrs", 0x00000007, 1, CPUID_REG_EAX, 11, 1}, {"fsrcs", 0x00000007, 1, CPUID_REG_EAX, 12, 1}, --- a/tools/misc/xen-cpuid.c +++ b/tools/misc/xen-cpuid.c @@ -186,6 +186,7 @@ static const char *const str_7d0[32] = static const char *const str_7a1[32] = { [ 4] = "avx-vnni", [ 5] = "avx512-bf16", + /* 6 */ [ 7] = "cmpccxadd", [10] = "fzrm", [11] = "fsrs", [12] = "fsrcs", --- a/tools/tests/x86_emulator/predicates.c +++ b/tools/tests/x86_emulator/predicates.c @@ -1403,6 +1403,22 @@ static const struct vex { { { 0xdd }, 2, T, R, pfx_66, WIG, Ln }, /* vaesenclast */ { { 0xde }, 2, T, R, pfx_66, WIG, Ln }, /* vaesdec */ { { 0xdf }, 2, T, R, pfx_66, WIG, Ln }, /* vaesdeclast */ + { { 0xe0 }, 2, F, W, pfx_66, Wn, L0 }, /* cmpoxadd */ + { { 0xe1 }, 2, F, W, pfx_66, Wn, L0 }, /* cmpnoxadd */ + { { 0xe2 }, 2, F, W, pfx_66, Wn, L0 }, /* cmpbxadd */ + { { 0xe3 }, 2, F, W, pfx_66, Wn, L0 }, /* cmpnbxadd */ + { { 0xe4 }, 2, F, W, pfx_66, Wn, L0 }, /* cmpexadd */ + { { 0xe5 }, 2, F, W, pfx_66, Wn, L0 }, /* cmpnexadd */ + { { 0xe6 }, 2, F, W, pfx_66, Wn, L0 }, /* cmpbexadd */ + { { 0xe7 }, 2, F, W, pfx_66, Wn, L0 }, /* cmpaxadd */ + { { 0xe8 }, 2, F, W, pfx_66, Wn, L0 }, /* cmpsxadd */ + { { 0xe9 }, 2, F, W, pfx_66, Wn, L0 }, /* cmpnsxadd */ + { { 0xea }, 2, F, W, pfx_66, Wn, L0 }, /* cmppxadd */ + { { 0xeb }, 2, F, W, pfx_66, Wn, L0 }, /* cmpnpxadd */ + { { 0xec }, 2, F, W, pfx_66, Wn, L0 }, /* cmplxadd */ + { { 0xed }, 2, F, W, pfx_66, Wn, L0 }, /* cmpgexadd */ + { { 0xee }, 2, F, W, pfx_66, Wn, L0 }, /* cmplexadd */ + { { 0xef }, 2, F, W, pfx_66, Wn, L0 }, /* cmpgxadd */ { { 0xf2 }, 2, T, R, pfx_no, Wn, L0 }, /* andn */ { { 0xf3, 0x08 }, 2, T, R, pfx_no, Wn, L0 }, /* blsr */ { { 0xf3, 0x10 }, 2, T, R, pfx_no, Wn, L0 }, /* blsmsk */ --- a/tools/tests/x86_emulator/test_x86_emulator.c +++ b/tools/tests/x86_emulator/test_x86_emulator.c @@ -1398,6 +1398,78 @@ int main(int argc, char **argv) } printf("okay\n"); + printf("%-40s", "Testing cmpbxadd %rbx,%r9,(%rdx)..."); + if ( stack_exec && cpu_has_cmpccxadd ) + { + instr[0] = 0xc4; instr[1] = 0x62; instr[2] = 0xe1; instr[3] = 0xe2; instr[4] = 0x0a; + regs.rip = (unsigned long)&instr[0]; + regs.eflags = EFLAGS_ALWAYS_SET; + res[0] = 0x11223344; + res[1] = 0x01020304; + regs.rdx = (unsigned long)res; + regs.r9 = 0x0001020300112233UL; + regs.rbx = 0x0101010101010101UL; + rc = x86_emulate(&ctxt, &emulops); + if ( (rc != X86EMUL_OKAY) || + (regs.eip != (unsigned long)&instr[5]) || + (regs.r9 != 0x0102030411223344UL) || + (regs.rbx != 0x0101010101010101UL) || + ((regs.eflags & EFLAGS_MASK) != + (X86_EFLAGS_PF | EFLAGS_ALWAYS_SET)) || + (res[0] != 0x11223344) || + (res[1] != 0x01020304) ) + goto fail; + + regs.rip = (unsigned long)&instr[0]; + regs.r9 <<= 8; + rc = x86_emulate(&ctxt, &emulops); + if ( (rc != X86EMUL_OKAY) || + (regs.eip != (unsigned long)&instr[5]) || + (regs.r9 != 0x0102030411223344UL) || + (regs.rbx != 0x0101010101010101UL) || + ((regs.eflags & EFLAGS_MASK) != + (X86_EFLAGS_CF | X86_EFLAGS_PF | X86_EFLAGS_SF | + EFLAGS_ALWAYS_SET)) || + (res[0] != 0x12233445) || + (res[1] != 0x02030405) ) + goto fail; + printf("okay\n"); + + printf("%-40s", "Testing cmpsxadd %r9d,%ebx,4(%r10)..."); + instr[1] = 0xc2; instr[2] = 0x31; instr[3] = 0xe8; instr[4] = 0x5a; instr[5] = 0x04; + regs.rip = (unsigned long)&instr[0]; + res[2] = res[0] = ~0; + regs.r10 = (unsigned long)res; + rc = x86_emulate(&ctxt, &emulops); + if ( (rc != X86EMUL_OKAY) || + (regs.eip != (unsigned long)&instr[6]) || + (regs.r9 != 0x0102030411223344UL) || + (regs.rbx != 0x02030405) || + ((regs.eflags & EFLAGS_MASK) != EFLAGS_ALWAYS_SET) || + (res[0] + 1) || + (res[1] != 0x02030405) || + (res[2] + 1) ) + goto fail; + + regs.rip = (unsigned long)&instr[0]; + regs.rbx <<= 8; + rc = x86_emulate(&ctxt, &emulops); + if ( (rc != X86EMUL_OKAY) || + (regs.eip != (unsigned long)&instr[6]) || + (regs.r9 != 0x0102030411223344UL) || + (regs.rbx != 0x02030405) || + ((regs.eflags & EFLAGS_MASK) != + (X86_EFLAGS_CF | X86_EFLAGS_PF | X86_EFLAGS_SF | + EFLAGS_ALWAYS_SET)) || + (res[0] + 1) || + (res[1] != 0x13253749) || + (res[2] + 1) ) + goto fail; + printf("okay\n"); + } + else + printf("skipped\n"); + emulops.write_segment = write_segment; emulops.write_msr = write_msr; --- a/tools/tests/x86_emulator/x86-emulate.h +++ b/tools/tests/x86_emulator/x86-emulate.h @@ -185,6 +185,7 @@ void wrpkru(unsigned int val); #define cpu_has_serialize cp.feat.serialize #define cpu_has_avx_vnni (cp.feat.avx_vnni && xcr0_mask(6)) #define cpu_has_avx512_bf16 (cp.feat.avx512_bf16 && xcr0_mask(0xe6)) +#define cpu_has_cmpccxadd cp.feat.cmpccxadd #define cpu_has_avx_ifma (cp.feat.avx_ifma && xcr0_mask(6)) #define cpu_has_avx_vnni_int8 (cp.feat.avx_vnni_int8 && xcr0_mask(6)) #define cpu_has_avx_ne_convert (cp.feat.avx_ne_convert && xcr0_mask(6)) --- a/xen/arch/x86/include/asm/cpufeature.h +++ b/xen/arch/x86/include/asm/cpufeature.h @@ -170,6 +170,7 @@ extern struct cpuinfo_x86 boot_cpu_data; /* CPUID level 0x00000007:1.eax */ #define cpu_has_avx_vnni boot_cpu_has(X86_FEATURE_AVX_VNNI) #define cpu_has_avx512_bf16 boot_cpu_has(X86_FEATURE_AVX512_BF16) +#define cpu_has_cmpccxadd boot_cpu_has(X86_FEATURE_CMPCCXADD) #define cpu_has_avx_ifma boot_cpu_has(X86_FEATURE_AVX_IFMA) /* CPUID level 0x00000007:1.edx */ --- a/xen/arch/x86/x86_emulate/decode.c +++ b/xen/arch/x86/x86_emulate/decode.c @@ -433,6 +433,7 @@ static const struct ext0f38_table { [0xcf] = { .simd_size = simd_packed_int, .d8s = d8s_vl }, [0xdb] = { .simd_size = simd_packed_int, .two_op = 1 }, [0xdc ... 0xdf] = { .simd_size = simd_packed_int, .d8s = d8s_vl }, + [0xe0 ... 0xef] = { .to_mem = 1 }, [0xf0] = { .two_op = 1 }, [0xf1] = { .to_mem = 1, .two_op = 1 }, [0xf2 ... 0xf3] = {}, @@ -924,6 +925,8 @@ decode_0f38(struct x86_emulate_state *s, ctxt->opcode |= MASK_INSR(s->vex.pfx, X86EMUL_OPC_PFX_MASK); break; + case X86EMUL_OPC_VEX_66(0, 0xe0) ... + X86EMUL_OPC_VEX_66(0, 0xef): /* cmpxadd */ case X86EMUL_OPC_VEX(0, 0xf2): /* andn */ case X86EMUL_OPC_VEX(0, 0xf3): /* Grp 17 */ case X86EMUL_OPC_VEX(0, 0xf5): /* bzhi */ --- a/xen/arch/x86/x86_emulate/private.h +++ b/xen/arch/x86/x86_emulate/private.h @@ -253,6 +253,7 @@ struct x86_emulate_state { rmw_btc, rmw_btr, rmw_bts, + rmw_cmpccxadd, rmw_dec, rmw_inc, rmw_neg, @@ -583,6 +584,7 @@ amd_like(const struct x86_emulate_ctxt * #define vcpu_has_tsxldtrk() (ctxt->cpuid->feat.tsxldtrk) #define vcpu_has_avx_vnni() (ctxt->cpuid->feat.avx_vnni) #define vcpu_has_avx512_bf16() (ctxt->cpuid->feat.avx512_bf16) +#define vcpu_has_cmpccxadd() (ctxt->cpuid->feat.cmpccxadd) #define vcpu_has_lkgs() (ctxt->cpuid->feat.lkgs) #define vcpu_has_wrmsrns() (ctxt->cpuid->feat.wrmsrns) #define vcpu_has_avx_ifma() (ctxt->cpuid->feat.avx_ifma) --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -6888,6 +6888,15 @@ x86_emulate( #endif /* !X86EMUL_NO_SIMD */ + case X86EMUL_OPC_VEX_66(0x0f38, 0xe0) ... + X86EMUL_OPC_VEX_66(0x0f38, 0xef): /* cmpxadd r,r,m */ + generate_exception_if(!mode_64bit() || dst.type != OP_MEM || vex.l, + X86_EXC_UD); + host_and_vcpu_must_have(cmpccxadd); + fail_if(!ops->rmw); + state->rmw = rmw_cmpccxadd; + break; + case X86EMUL_OPC(0x0f38, 0xf0): /* movbe m,r */ case X86EMUL_OPC(0x0f38, 0xf1): /* movbe r,m */ vcpu_must_have(movbe); @@ -7949,14 +7958,20 @@ x86_emulate( { ea.val = src.val; op_bytes = dst.bytes; + state->stub_exn = &stub_exn; rc = ops->rmw(dst.mem.seg, dst.mem.off, dst.bytes, &_regs.eflags, state, ctxt); +#ifdef __XEN__ + if ( rc == X86EMUL_stub_failure ) + goto emulation_stub_failure; +#endif if ( rc != X86EMUL_OKAY ) goto done; /* Some operations require a register to be written. */ switch ( state->rmw ) { + case rmw_cmpccxadd: case rmw_xchg: case rmw_xadd: switch ( dst.bytes ) @@ -8233,6 +8248,7 @@ int x86_emul_rmw( uint32_t *eflags, struct x86_emulate_state *state, struct x86_emulate_ctxt *ctxt) +#define stub_exn (*state->stub_exn) /* for invoke_stub() */ { unsigned long *dst = ptr; @@ -8298,6 +8314,37 @@ int x86_emul_rmw( #undef BINOP #undef SHIFT +#ifdef __x86_64__ + case rmw_cmpccxadd: + { + struct x86_emulate_stub stub = {}; + uint8_t *buf = get_stub(stub); + typeof(state->vex) *pvex = container_of(buf + 1, typeof(state->vex), + raw[0]); + unsigned long dummy; + + buf[0] = 0xc4; + *pvex = state->vex; + pvex->b = 1; + pvex->r = 1; + pvex->reg = 0xf; /* rAX */ + buf[3] = ctxt->opcode; + buf[4] = 0x11; /* reg=rDX r/m=(%RCX) */ + buf[5] = 0xc3; + + *eflags &= ~EFLAGS_MASK; + invoke_stub("", + _POST_EFLAGS("[eflags]", "[mask]", "[tmp]"), + "+m" (*dst), "+d" (state->ea.val), + [tmp] "=&r" (dummy), [eflags] "+g" (*eflags) + : "a" (*decode_vex_gpr(state->vex.reg, ctxt->regs, ctxt)), + "c" (dst), [mask] "i" (EFLAGS_MASK)); + + put_stub(stub); + break; + } +#endif + case rmw_not: switch ( state->op_bytes ) { @@ -8393,7 +8440,13 @@ int x86_emul_rmw( #undef JCXZ return X86EMUL_OKAY; + +#if defined(__XEN__) && defined(__x86_64__) + emulation_stub_failure: + return X86EMUL_stub_failure; +#endif } +#undef stub_exn static void __init __maybe_unused build_assertions(void) { --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -278,6 +278,7 @@ XEN_CPUFEATURE(SSBD, 9*32+31) / /* Intel-defined CPU features, CPUID level 0x00000007:1.eax, word 10 */ XEN_CPUFEATURE(AVX_VNNI, 10*32+ 4) /*A AVX-VNNI Instructions */ XEN_CPUFEATURE(AVX512_BF16, 10*32+ 5) /*A AVX512 BFloat16 Instructions */ +XEN_CPUFEATURE(CMPCCXADD, 10*32+ 7) /*a CMPccXADD Instructions */ XEN_CPUFEATURE(FZRM, 10*32+10) /*A Fast Zero-length REP MOVSB */ XEN_CPUFEATURE(FSRS, 10*32+11) /*A Fast Short REP STOSB */ XEN_CPUFEATURE(FSRCS, 10*32+12) /*A Fast Short REP CMPSB/SCASB */ From xen-devel-bounces@lists.xenproject.org Mon May 08 12:33:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 12:33:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531503.827225 (Exim 4.92) (envelope-from ) id 1pw03d-0004MY-3C; Mon, 08 May 2023 12:33:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531503.827225; Mon, 08 May 2023 12:33:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw03d-0004MP-0F; Mon, 08 May 2023 12:33:37 +0000 Received: by outflank-mailman (input) for mailman id 531503; Mon, 08 May 2023 12:33:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw03b-0003kR-Uu for xen-devel@lists.xenproject.org; Mon, 08 May 2023 12:33:36 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2053.outbound.protection.outlook.com [40.107.7.53]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8c1e543f-ed9c-11ed-b226-6b7b168915f2; Mon, 08 May 2023 14:33:35 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9318.eurprd04.prod.outlook.com (2603:10a6:102:2a5::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.31; Mon, 8 May 2023 12:33:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c%4]) with mapi id 15.20.6363.031; Mon, 8 May 2023 12:33:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8c1e543f-ed9c-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eu3/82MsRMb+Xg735h6svvjGT8GvOsmLqaOVIQsKJ3cO9Enva5jsuZUxZqhxjMcK1/Ag4yYEiUSmBqm4n1Kfc52mbWI2lCZ0X3S/VDtdGZe3+jfTbhYmd7KOsiOisG86PlArmCwVh1g22FBSTXnZ3qZHMlSbKaW+8EYGR14M6boXDQao0auwfPWbGgszV3dxceewtdDtW4fzE9AFWvhDRVYIZs2JIzGKvcChdW4y2InzUEmP0q9CbnD45i2r9u30Y5RzR9bQ2GHcySVW+UpCxksPcCvCAVMfYHM38f67rv3mh3zYUVeEa3RuN2qw3hBaYHD7rkxTtTa62WKWKNN0HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zhas7AbeMgoLdGDJZhnhFI7UMWReMRLI7GR1/taFIZY=; b=bYb7OqMW1l/j/F1uzfs7MC/9s5bokkatFXAHsfpUPSiNIkF5g4AdPZZN97pvbQSq33L8oBRt7qFFQQ+TkMCfaTJy2Z8N9rblziCT1FLx/gb6guZYGlL7rYTXhLj7yD42XOO94f0zoGMQeCs2+NM9P6A3u/tiFjqTIYmzDgfG/UysnGPw2Uu0pWG8gxWRhzxr2hFF9rSXBP0yJyIYaT7n5Z4vzPc6TxQVRd71H7urIJXIXyTIHtV3hcEoL27l5ONxmg0h06jWQlRqfue6KLxdy4v39wFAa+gzJEqckHAm2II9H6cllq01QZo/f5ZJ//D0Y5jBbiRgRuCl9SN084smtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zhas7AbeMgoLdGDJZhnhFI7UMWReMRLI7GR1/taFIZY=; b=iQpyTqRHXgUwDexql+X39Veb4ywEhj52pOZdKnc4ijT/tcAhj3jkVMkiQSFhhbMDATnCPvnq0jnXxZYarTJ7xDmFbWW4WqVFY4tSUEpqi8Ngdefzk2Th1GzzwTK0BEr0dcWhu+Qzc6+B/kjGD4PMH3ABCr4zc2/qk9maqrgA6csJ/GyaKhTpFM7P6JZN66yT5uzGlDwT0+x+5b68j/hu8n4j2ujYWL8ryhB9yjrFCJEhpWd6TcAD1mklrPQOJTVewPRxNosfzXFUPUramN2Q7cBsqpMAiwc+xSPwUHpQM9cTNQhaTx+eLO2iugc9veO3+VK5xTo5lCO60tuiWrxydQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 8 May 2023 14:33:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: [PATCH v2 3/4] VMX: tertiary execution control infrastructure Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Kevin Tian , Jun Nakajima References: <0b2a4e8c-ab43-4e6e-2c51-027dcdf1425d@suse.com> In-Reply-To: <0b2a4e8c-ab43-4e6e-2c51-027dcdf1425d@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0107.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9318:EE_ X-MS-Office365-Filtering-Correlation-Id: 894566cc-d6b5-471d-9cc9-08db4fc05f63 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NK1oHSgzst9vZzeZga3Z+xHv99CxtFl1Cm2mKi04S2SGA9+lSucMxCl3KSD7kGrXqHzetzwtvKSgDtcvJzDqgdmSa++LQ8CicnnM13LZOO2fXkhp3Dp3TbraJp4MOglAFeKGCpoFxMMROfQzGd5LT1dvL4+dYSmrzYE0azb6QKeNmwSJ7pW7pZn9nEamCPBGmAdyFjvg/5s3hkKISDsPmkwV6L5pk45grpA8Am9ljnW9ULljP4rQ9+/MfYJWji2OixN/UG/B9awXbGUR9kNpF0KAnBYeZPNfCQUkJ7zY4kOZCjAUX5XinwNpHVAWGVkT+ypO7XeMNK2U8iCX31z8p7/NIbZkYsDxIFBDVKYacshlfIKQfUs74CYJRxG8h3Tbm7pG+PWKl2PGYIQ2CDedcEV+tQzH6/KvQzbsrgikfDLitFcUWfBNtixZr5V8Vyx69Nb0mMt/DSsbh+D5d15+zMzPvfYgiCiAyhpIEGGKm33IFufDftiL7PmTHFTi4yFL8ybjUO907Ak4m9UHDXG3ssizgJISuDo77SwZfB9I3XJafNaY2Kg4AKtkmLr3MaX3IwqTydN5qUUy8/KwPB84XiPKVVMbagqMzvzaddUsxfLWLYPQ4PBMMm+6MhKfQZN+X01ltjqTC76zWPvV0MxZyA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(396003)(366004)(376002)(346002)(136003)(451199021)(31686004)(36756003)(38100700002)(2906002)(8676002)(5660300002)(316002)(86362001)(31696002)(8936002)(6916009)(66556008)(66946007)(41300700001)(66476007)(4326008)(83380400001)(186003)(6512007)(6506007)(26005)(6486002)(478600001)(2616005)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUN2OW5iL1grQ2YyQXBwejNXOUdGb1NmaStQclZXcjZRQnQ4ZitlVVNSSzhE?= =?utf-8?B?cEtsVG9WU2VqU3YrTVJ4dWJDVUlvejNxQ0JodG9rSjFuVzYvZzBNQ3pmdS9a?= =?utf-8?B?L09SWWJHRXZqVUhLaU5qR0RocitaVzgvRjRlWnZJS0R1Q1hPanJJZEh1M2w5?= =?utf-8?B?ZCtrS0VZc0dsSDZqMlZMZlBma0VjOXFCeStnbnpneG5CaDR6TCtPYlBJTS92?= =?utf-8?B?MGcxQ3F4NlYvNUJaWVpsMUc3TjA5czRMdzBzVkNzNmdsM29IckN1dkZSTDBH?= =?utf-8?B?dUFQOHhPaGdCaE55NjlPL0t0VXhiUXZYMStEM2ZjRVd3SXhqU0dnakZtUEUr?= =?utf-8?B?akZNOTVqd2FOV0RLKzUvMWJPb2I2UXpTTVd4SXA3UXFBRWQ5YzlWNVg4cFg5?= =?utf-8?B?NWJzNjZMamZ0aGxoTkFQSUdKbU5Ja1IwNHJ1cURabnlDTy8wUHlzbmJrR25Y?= =?utf-8?B?YnNMR2lVeXl3aGEwVjdRK0EwUHcxcDFLY3QyVkp4NkxJWUV4bDJYOHR4MEZC?= =?utf-8?B?Rk1QSnpZZXY5Y3BnK0pRa2JGWkZjSm0rbDQrWjZZSzNiOTV2aXF0Uk11M3p2?= =?utf-8?B?cFRoRGN3azRPZk9razFlLzNyMnE2eWxoUEYzZFk2eU50MEJJUDIvbDBqWmd5?= =?utf-8?B?Rkd5UEd2UW50V0dBVFdHdHJqVTJvcGlhc0wySUgrMitVRUJ1bVFKeWUranBZ?= =?utf-8?B?ajZ5emhOSWo2ZlNBVUp2bi9xcDhEY2Yzc0E5cysvakJTWjR5V2kxemxRSjNO?= =?utf-8?B?YlZaanNzaTNGdDd3Qldkc1BWWmY0cnRMT1BkaFplLytnWGMwMWFlRGZLOXoy?= =?utf-8?B?MFNXMlM0dmp6L2tsd01LMHNCOXRjcVhJOWZNMUlsaGdrUm4rR2IrSE5URnFn?= =?utf-8?B?YXNJM3RaNVdSY054Z0llVzhNWFJrRlJmQnZnVUlNRkl2M25xTVF5MGlHZEp6?= =?utf-8?B?TjB4S0k0RXFMYTdicTR3eWlCSm1tV2NUeWQwVTRoZGZadGp5ZCtXL1VPaW9r?= =?utf-8?B?SldPcTc5dFZ4US8zcTJPMENiTmp4Q05QeWpyWDFqWEpHbEpEelJkWHdrc20y?= =?utf-8?B?ZHJuWGYrMVVXcFRPalk5SzVxQktMU2gvUnp5OHFVdTNQMzBGa1dnYmRHRjB1?= =?utf-8?B?bk1lVFFxTHhTVytwMlM2Y1hvTUxrNzg2MHpMa3BwOExvNm12VkhXc0wvbGY4?= =?utf-8?B?ck93SE9nQUJLNWJzckMrZ2ZSdG5yc0JGVmR0Y1lIbG94eWxUV0pYS295cEFC?= =?utf-8?B?NVZpSFJXSy9BZEVYSEpObk9IZzd3Qlc1dnhPL21oQXZieFVHenZCTXZVOHNl?= =?utf-8?B?cTBlOU16RjBlU3NkV2wwMXlGaGJFUnBCYW4wVnZSN2hIcWRGakZOUlkwMEsx?= =?utf-8?B?UW9Rb0xEZUY0ZjErOHhhWWRvWFJ1WlFFakMwYUg3Nlh3UDdNYnVkYnA0eE50?= =?utf-8?B?djBzSHFwaWcxbnVGell4dHZZWnRpSERUNW5LNC9MQkdDMGVkSzVrVzZBaW9x?= =?utf-8?B?dW1zcVdBUEg0NURaWkxOVGNFZHE1bEo2NGdIQklEMHdXaDM0KzlVTmtYQ0Np?= =?utf-8?B?eWdDNEJrcTljTXFZQ3NVdk84ZTQraE5YNUE0VHZzQTJXK0dmUXNBN1FHeGVS?= =?utf-8?B?Yml4anUremt6cC90KzNSaWxDZjRzNUR6UVhnQzQzOXNyaG5OZ3dWWkVPZXRS?= =?utf-8?B?bm5TcERTVmxFL1FtKzI1RnVUUmFrcWVRUDJkaHYwdDFTK1QySmhsRlBGcldq?= =?utf-8?B?a3o1Wlc0cGg4YlA5RUsvd20vSjNHWG9TV1dEMDE2dk9kbkxjYTFjcW5aR2VN?= =?utf-8?B?UXZMV1lOcHVNdW5kTDRYTGlESmpKM1JwVVVSaFlMdldSVFRTV09LOGZIZ0I0?= =?utf-8?B?UHRnN3RDL3cwZ2Fnb3J4ZXRJOHFWM2Q0MjZpSkI5SUpCajZzVnhZYmhRcUVq?= =?utf-8?B?cFU1Q1h6bWZYODkvMnIzWnVSMDA0Y21tSWtHb0JubmZZMVQ3U1ZNZlNHTUhJ?= =?utf-8?B?Q05xamh2TWxMVE5BalByOHFlcHB4ajlTSXA5U2F0NENCZnRTU3NQYUtYTkt6?= =?utf-8?B?a0tJa29JWlJmOVkzTnUvR2lod2NiWGhyemlkeU40ODJZUnNyazdYMHJPUjhu?= =?utf-8?Q?Gb+W02zxAdGwKqVU0VCJkKZW9?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 894566cc-d6b5-471d-9cc9-08db4fc05f63 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 12:33:05.6933 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VRijHlB1aNuOVndKmzJoQxzy21Pd/Wbqbw8VmnxENBqC/b/4CoTc4hCqv3xvQ1lUDfEgZSZRkWEFpVE3R3YFjQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9318 This is a prereq to enabling the MSRLIST feature. Note that the PROCBASED_CTLS3 MSR is different from other VMX feature reporting MSRs, in that all 64 bits report allowed 1-settings. vVMX code is left alone, though, for the time being. Signed-off-by: Jan Beulich --- v2: New. --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -164,6 +164,7 @@ static int cf_check parse_ept_param_runt u32 vmx_pin_based_exec_control __read_mostly; u32 vmx_cpu_based_exec_control __read_mostly; u32 vmx_secondary_exec_control __read_mostly; +uint64_t vmx_tertiary_exec_control __read_mostly; u32 vmx_vmexit_control __read_mostly; u32 vmx_vmentry_control __read_mostly; u64 vmx_ept_vpid_cap __read_mostly; @@ -229,10 +230,32 @@ static u32 adjust_vmx_controls( return ctl; } -static bool_t cap_check(const char *name, u32 expected, u32 saw) +static uint64_t adjust_vmx_controls2( + const char *name, uint64_t ctl_min, uint64_t ctl_opt, unsigned int msr, + bool *mismatch) +{ + uint64_t vmx_msr, ctl = ctl_min | ctl_opt; + + rdmsrl(msr, vmx_msr); + + ctl &= vmx_msr; /* bit == 0 ==> must be zero */ + + /* Ensure minimum (required) set of control bits are supported. */ + if ( ctl_min & ~ctl ) + { + *mismatch = true; + printk("VMX: CPU%u has insufficient %s (%#lx; requires %#lx)\n", + smp_processor_id(), name, ctl, ctl_min); + } + + return ctl; +} + +static bool cap_check( + const char *name, unsigned long expected, unsigned long saw) { if ( saw != expected ) - printk("VMX %s: saw %#x expected %#x\n", name, saw, expected); + printk("VMX %s: saw %#lx expected %#lx\n", name, saw, expected); return saw != expected; } @@ -242,6 +265,7 @@ static int vmx_init_vmcs_config(bool bsp u32 _vmx_pin_based_exec_control; u32 _vmx_cpu_based_exec_control; u32 _vmx_secondary_exec_control = 0; + uint64_t _vmx_tertiary_exec_control = 0; u64 _vmx_ept_vpid_cap = 0; u64 _vmx_misc_cap = 0; u32 _vmx_vmexit_control; @@ -275,7 +299,8 @@ static int vmx_init_vmcs_config(bool bsp opt = (CPU_BASED_ACTIVATE_MSR_BITMAP | CPU_BASED_TPR_SHADOW | CPU_BASED_MONITOR_TRAP_FLAG | - CPU_BASED_ACTIVATE_SECONDARY_CONTROLS); + CPU_BASED_ACTIVATE_SECONDARY_CONTROLS | + CPU_BASED_ACTIVATE_TERTIARY_CONTROLS); _vmx_cpu_based_exec_control = adjust_vmx_controls( "CPU-Based Exec Control", min, opt, MSR_IA32_VMX_PROCBASED_CTLS, &mismatch); @@ -339,6 +364,15 @@ static int vmx_init_vmcs_config(bool bsp MSR_IA32_VMX_PROCBASED_CTLS2, &mismatch); } + if ( _vmx_cpu_based_exec_control & CPU_BASED_ACTIVATE_TERTIARY_CONTROLS ) + { + uint64_t opt = 0; + + _vmx_tertiary_exec_control = adjust_vmx_controls2( + "Tertiary Exec Control", 0, opt, + MSR_IA32_VMX_PROCBASED_CTLS3, &mismatch); + } + /* The IA32_VMX_EPT_VPID_CAP MSR exists only when EPT or VPID available */ if ( _vmx_secondary_exec_control & (SECONDARY_EXEC_ENABLE_EPT | SECONDARY_EXEC_ENABLE_VPID) ) @@ -469,6 +503,7 @@ static int vmx_init_vmcs_config(bool bsp vmx_pin_based_exec_control = _vmx_pin_based_exec_control; vmx_cpu_based_exec_control = _vmx_cpu_based_exec_control; vmx_secondary_exec_control = _vmx_secondary_exec_control; + vmx_tertiary_exec_control = _vmx_tertiary_exec_control; vmx_ept_vpid_cap = _vmx_ept_vpid_cap; vmx_vmexit_control = _vmx_vmexit_control; vmx_vmentry_control = _vmx_vmentry_control; @@ -505,6 +540,9 @@ static int vmx_init_vmcs_config(bool bsp "Secondary Exec Control", vmx_secondary_exec_control, _vmx_secondary_exec_control); mismatch |= cap_check( + "Tertiary Exec Control", + vmx_tertiary_exec_control, _vmx_tertiary_exec_control); + mismatch |= cap_check( "VMExit Control", vmx_vmexit_control, _vmx_vmexit_control); mismatch |= cap_check( @@ -1082,6 +1120,7 @@ static int construct_vmcs(struct vcpu *v v->arch.hvm.vmx.exec_control |= CPU_BASED_RDTSC_EXITING; v->arch.hvm.vmx.secondary_exec_control = vmx_secondary_exec_control; + v->arch.hvm.vmx.tertiary_exec_control = vmx_tertiary_exec_control; /* * Disable features which we don't want active by default: @@ -1136,6 +1175,10 @@ static int construct_vmcs(struct vcpu *v __vmwrite(SECONDARY_VM_EXEC_CONTROL, v->arch.hvm.vmx.secondary_exec_control); + if ( cpu_has_vmx_tertiary_exec_control ) + __vmwrite(TERTIARY_VM_EXEC_CONTROL, + v->arch.hvm.vmx.tertiary_exec_control); + /* MSR access bitmap. */ if ( cpu_has_vmx_msr_bitmap ) { @@ -2071,10 +2114,12 @@ void vmcs_dump_vcpu(struct vcpu *v) vmr(HOST_PERF_GLOBAL_CTRL)); printk("*** Control State ***\n"); - printk("PinBased=%08x CPUBased=%08x SecondaryExec=%08x\n", + printk("PinBased=%08x CPUBased=%08x\n", vmr32(PIN_BASED_VM_EXEC_CONTROL), - vmr32(CPU_BASED_VM_EXEC_CONTROL), - vmr32(SECONDARY_VM_EXEC_CONTROL)); + vmr32(CPU_BASED_VM_EXEC_CONTROL)); + printk("SecondaryExec=%08x TertiaryExec=%08lx\n", + vmr32(SECONDARY_VM_EXEC_CONTROL), + vmr(TERTIARY_VM_EXEC_CONTROL)); printk("EntryControls=%08x ExitControls=%08x\n", vmentry_ctl, vmexit_ctl); printk("ExceptionBitmap=%08x PFECmask=%08x PFECmatch=%08x\n", vmr32(EXCEPTION_BITMAP), --- a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h @@ -114,6 +114,7 @@ struct vmx_vcpu { /* Cache of cpu execution control. */ u32 exec_control; u32 secondary_exec_control; + uint64_t tertiary_exec_control; u32 exception_bitmap; uint64_t shadow_gs; @@ -196,6 +197,7 @@ void vmx_vmcs_reload(struct vcpu *v); #define CPU_BASED_RDTSC_EXITING 0x00001000 #define CPU_BASED_CR3_LOAD_EXITING 0x00008000 #define CPU_BASED_CR3_STORE_EXITING 0x00010000 +#define CPU_BASED_ACTIVATE_TERTIARY_CONTROLS 0x00020000 #define CPU_BASED_CR8_LOAD_EXITING 0x00080000 #define CPU_BASED_CR8_STORE_EXITING 0x00100000 #define CPU_BASED_TPR_SHADOW 0x00200000 @@ -260,6 +262,13 @@ extern u32 vmx_vmentry_control; #define SECONDARY_EXEC_NOTIFY_VM_EXITING 0x80000000 extern u32 vmx_secondary_exec_control; +#define TERTIARY_EXEC_LOADIWKEY_EXITING BIT(0, UL) +#define TERTIARY_EXEC_ENABLE_HLAT BIT(1, UL) +#define TERTIARY_EXEC_EPT_PAGING_WRITE BIT(2, UL) +#define TERTIARY_EXEC_GUEST_PAGING_VERIFY BIT(3, UL) +#define TERTIARY_EXEC_IPI_VIRT BIT(4, UL) +extern uint64_t vmx_tertiary_exec_control; + #define VMX_EPT_EXEC_ONLY_SUPPORTED 0x00000001 #define VMX_EPT_WALK_LENGTH_4_SUPPORTED 0x00000040 #define VMX_EPT_MEMORY_TYPE_UC 0x00000100 @@ -295,6 +304,8 @@ extern u64 vmx_ept_vpid_cap; (vmx_cpu_based_exec_control & CPU_BASED_ACTIVATE_MSR_BITMAP) #define cpu_has_vmx_secondary_exec_control \ (vmx_cpu_based_exec_control & CPU_BASED_ACTIVATE_SECONDARY_CONTROLS) +#define cpu_has_vmx_tertiary_exec_control \ + (vmx_cpu_based_exec_control & CPU_BASED_ACTIVATE_TERTIARY_CONTROLS) #define cpu_has_vmx_ept \ (vmx_secondary_exec_control & SECONDARY_EXEC_ENABLE_EPT) #define cpu_has_vmx_dt_exiting \ @@ -418,6 +429,7 @@ enum vmcs_field { VIRT_EXCEPTION_INFO = 0x0000202a, XSS_EXIT_BITMAP = 0x0000202c, TSC_MULTIPLIER = 0x00002032, + TERTIARY_VM_EXEC_CONTROL = 0x00002034, GUEST_PHYSICAL_ADDRESS = 0x00002400, VMCS_LINK_POINTER = 0x00002800, GUEST_IA32_DEBUGCTL = 0x00002802, --- a/xen/arch/x86/include/asm/msr-index.h +++ b/xen/arch/x86/include/asm/msr-index.h @@ -320,6 +320,7 @@ #define MSR_IA32_VMX_TRUE_EXIT_CTLS 0x48f #define MSR_IA32_VMX_TRUE_ENTRY_CTLS 0x490 #define MSR_IA32_VMX_VMFUNC 0x491 +#define MSR_IA32_VMX_PROCBASED_CTLS3 0x492 /* K7/K8 MSRs. Not complete. See the architecture manual for a more complete list. */ --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -760,6 +760,12 @@ void vmx_update_secondary_exec_control(s v->arch.hvm.vmx.secondary_exec_control); } +void vmx_update_tertiary_exec_control(struct vcpu *v) +{ + __vmwrite(TERTIARY_VM_EXEC_CONTROL, + v->arch.hvm.vmx.tertiary_exec_control); +} + void vmx_update_exception_bitmap(struct vcpu *v) { u32 bitmap = unlikely(v->arch.hvm.vmx.vmx_realmode) --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h @@ -80,6 +80,7 @@ void vmx_realmode(struct cpu_user_regs * void vmx_update_exception_bitmap(struct vcpu *v); void vmx_update_cpu_exec_control(struct vcpu *v); void vmx_update_secondary_exec_control(struct vcpu *v); +void vmx_update_tertiary_exec_control(struct vcpu *v); #define POSTED_INTR_ON 0 #define POSTED_INTR_SN 1 From xen-devel-bounces@lists.xenproject.org Mon May 08 12:34:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 12:34:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531511.827235 (Exim 4.92) (envelope-from ) id 1pw04d-0004yE-H0; Mon, 08 May 2023 12:34:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531511.827235; Mon, 08 May 2023 12:34:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw04d-0004y7-Do; Mon, 08 May 2023 12:34:39 +0000 Received: by outflank-mailman (input) for mailman id 531511; Mon, 08 May 2023 12:34:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw04c-0004xq-Ev for xen-devel@lists.xenproject.org; Mon, 08 May 2023 12:34:38 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2055.outbound.protection.outlook.com [40.107.7.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b1017243-ed9c-11ed-8611-37d641c3527e; Mon, 08 May 2023 14:34:36 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9318.eurprd04.prod.outlook.com (2603:10a6:102:2a5::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.31; Mon, 8 May 2023 12:34:07 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c%4]) with mapi id 15.20.6363.031; Mon, 8 May 2023 12:34:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b1017243-ed9c-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HxdU93t7+5+vK03c3Y/4FxpB/K5u62wQDgU25mATLLyA7LuPENXtBeLQe4MpsU51Rjfu17FWskKLE8nK2O84bKDvWXZ9qQvORSm8NQvWeKdrzuqBZVDUPB5y8I6BYwbAyWwFOwm2K0p1d5Xg+xN4qsfu1hhHQq57K0XA5s2xcwHNML0+nnK5dJGLW3i/kxOEcVP3Ssrr6HCC9HXT1KZyz8wpCSNiGRND8MfFXY2Ntwpj5ZxzdeDRA+ltjHgoLgsBglcxmvKHbipUHHwXwCm8BZ3AgqPFfJMD9bCisa+IPDX0jqRNsZrn3o31vWxY6RW3olB2DRYJf8N+ocOrPu9DnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I2BSQaE2keFaf3Lw5g+cGKquavmTPmGFtbCScr9TRZs=; b=P4sPCkoHlNmXsNGABwFD3JrUM4tbY7H1MGYIDUNnSeoIyObUZSxeCMeJTEoILO+GHLRERm2svdW0jZC1PXwHIkF4C9kNT7ZBdrnV6LIhE9nXMvp2QOmBdmUeg6T206GCWG0dmuetOv2hAlQnTuWWXhXx45nYVSQuRmGGThSgnuvo0gYaHjOaf/qBr308Hew2MwPPBMW2i836JI/V6WJQDvWAfCRMQqumkzqzgpLo1/65AvaF+28MVXCdtDjS8yeJQVObUdsbZdWYYCytW2Wu+qtQGk7mx4yRIChbEKoVCNA77Y4kKsZsmhJSsEPjDHlqn7V2fkfc5cMU/5F/FfMaSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I2BSQaE2keFaf3Lw5g+cGKquavmTPmGFtbCScr9TRZs=; b=occT+vGWOTEB5LzRpJeqdLOyJT4GtsUNGeL/HgtckEb6HFzx8lT4T7aFOAAer6RY5Q3zq8wUp1XNxCvOMn1Zp1wdewoFU+rdSYaHKDjYclCIMjb4JL6l/xO2LpgiyVyGOsquYfSjVUVy96JGibm8cqE4ZYrqo5kwvnwZ6lGXxqqNqkE0kuXKQ4vsw4xRCawNXlsLW4qYv8QHl0/mxp9prVW4y6ukzPfyH90aoI1pxv2q90G44JP84T/z6DffB/W3wiunr6wjTTtlL0ueej+DIoggBeBO1eUvMyuQ1KcZFblEvK9VIVnGm2RU5DAKfkar0aWePfPexDZ38ttMY0N1Cg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <87e7af8b-67e7-1bf9-ee91-48547b2e5a39@suse.com> Date: Mon, 8 May 2023 14:33:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: [PATCH v2 4/4] x86emul+VMX: support {RD,WR}MSRLIST Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Kevin Tian , Jun Nakajima References: <0b2a4e8c-ab43-4e6e-2c51-027dcdf1425d@suse.com> In-Reply-To: <0b2a4e8c-ab43-4e6e-2c51-027dcdf1425d@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0005.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9318:EE_ X-MS-Office365-Filtering-Correlation-Id: 33c2dec3-9676-42a7-31ec-08db4fc07899 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mqermCcjJ7CNjtr8TCFnVo88SHAcII3kvUaX5lnoIiEkKqhYOqfXqBkiCPpubkkJS8VZ8U+G1d08TEHexF/wW+AgTmJxuqrARJVNxSAgxAz2twp8QPqNbrqJZ9Yx0r9Nde4i0snrJvZDK6qV81YzRPBGIobQyNg0sLbNYBD7hSHzdgeUiOhLIhGZH1/USd4FwK+AK3nuIxLHV5Udn+0sYxKQ45CphMUZcKuqZPysSe5sEfbfE7Bfan7bRFz+2OOdpJxyTZ5BVqKK2GJeZqGAxqhhmNsKaowZXLXH5tpipoRXm9S3Qp6Zj5cpvVB9zqogVCN52eA7MBf2xCsEUHTSOvCmQFUltBOtRkJiVTReTzK3aKF20rW3+6z+077T8ACJcgk7Dbb8Vitd/uN5Tqln/s1AYzt2McCecCQOVwLT4Y7122vDmU299PX8zMxsfGv0jK2BUYgNsEWpj9P2HQgXZI7PFcM69EgblLQTtzVB3Qo4ZtWj8tD3141Qt8t5o27AOUoMJyov7oueneyosMaxYFMrhXzTl5UrwZhmNbY32oghiTvnbnkr4AzfXNOv4M45JLzDfQSCTkHbvMB24+WB6ndK6UFF3dzPGms/Lh/UAvPKFEC/fpfWGoV4ocqNDmhAXfiH8YRxa+lgCr2HG474wQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(396003)(366004)(376002)(346002)(136003)(451199021)(31686004)(36756003)(38100700002)(2906002)(30864003)(8676002)(5660300002)(316002)(86362001)(31696002)(8936002)(6916009)(66556008)(66946007)(41300700001)(66476007)(4326008)(83380400001)(186003)(6512007)(6506007)(26005)(6486002)(478600001)(6666004)(2616005)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZXRIT3IzcTVwdmM4ZUQ4ZE1sb3VUSERFaVQ0d0RVMnROTzhybUVIdldHQWtV?= =?utf-8?B?VUhDQWIxTmRMOWFCSW12UU12Y2k5bnpoSnRsamdwSXpxUEJ3MS9xYTlMd2t3?= =?utf-8?B?VTNwTURhWDd3QXdqUkFVQjRqamJyV3dhWkswK1dJLzk3TWlqS3ZUN0lzT3gz?= =?utf-8?B?WDB6ZGhSV3FQdEVEdVRzSER0NklDOS9xQ0VFWTlrMFIzbkhmWkxFTVlMem9I?= =?utf-8?B?SXZ2ZlpkZEFRZzZyTk9IQlBtNkxFR1dTa3RtclhlcmdydFlxZEhweEZzVEtK?= =?utf-8?B?ZUJpYktiNy9mNkZKd21KckZvWU53T2xPQjdzL25GSlpTQ3FGV1lma1FYMHJz?= =?utf-8?B?cnlOVER1eXl3eklIT2pIWFUrYjExRVNMaXhSbXJ1aStoUUtFSU9Pam1DcjZV?= =?utf-8?B?eUdQODZkVzlmWCtuMmVIUFpyRERHYVNmKzlMcGd6OVZPU3czUTI0bGQ3a2J2?= =?utf-8?B?MXFRbUJiUFFTMXVzSFAvbGdkNGkwVGlGdUdiQTlOVDlJM1R5d3BOV2hiWXo2?= =?utf-8?B?akpSeG1zcEVXWi9wd1l5RjhkRmZTc09QSDJwM1JBN21HVGxvOU5ReEN3THgw?= =?utf-8?B?OFAzK29ZTjViTTlJbjZ1UGlBSjkxSG1WWkF4YXFSbmZaN0lmVk1iendNVXBB?= =?utf-8?B?TllTTXpKK0JKVytFcUlGc2NIakZ3eVBIazc2dndXSkN4UjBMSWpQNTExdE5N?= =?utf-8?B?Z3lnSzFGU2g4SDFSZnJyUFcyNnJ1ZWpyTjNwK2JJSHB0bjFhRXdVNFJ1azA0?= =?utf-8?B?bUxXS1Q4WHJzNkJDc0xWWCtZM0w5VUl2cWFpKys3UXFzY2M0TXZSWmVoWGNt?= =?utf-8?B?Y0pKd1JpUFpOVmJOb3c5QjdyT2JaOWx1emZxSUFhRER2Zy9wN2F1bmt2L2Nl?= =?utf-8?B?a1dXbk53bE15Y09iKzFDbXNTQTN0UTFzWnZ2ZkIzSk56NlRXRy8rNnV3SjlU?= =?utf-8?B?NHpxUEdOVCs4R2VTZHdIRUNMZVQyYktUNmRveGVOd3Iya0FndnlBb2JiTzRs?= =?utf-8?B?QWVqeXl3ZnBWdjNLSHdHZldsY2pMWkFERjk0OFVad3JldTNuS0hZczVHU0ZI?= =?utf-8?B?MHZUbC9nWDVzNHZhYVlsUDZJblhFQXVIOXIyT0JkUlRVaE1uNkhITnI3UXpr?= =?utf-8?B?NkhYdDBiZ3NtYmpqNm0yREdMTFBOVld3QXNsNGRIMzNqeGR6OTVmM1hoN1gw?= =?utf-8?B?S3VPTWVPTjJhcnNvOXZoUG0zc2RObVRMV01QVEd2VkIxR3hUeUFsV3Ixamp4?= =?utf-8?B?M0NpN3c1WGR3aWN1Rnh5enNKNWp2MURYMzREeXBtU0sxWDF6MU1kc3BVQ0lk?= =?utf-8?B?dlZjbWVBek5ORWlFZE1RRk9CRys0Zit1bGluakpGS0kvb2lMa256MkpjN3A5?= =?utf-8?B?Y2RRemdOSWZTbmpmenRqdDZhc1pvOHMyL05zZGQxd2RqaC9mSC90NEl5WEM0?= =?utf-8?B?bUx5bUdzUU5rU2NVelA2Z3o5NFZvdDNoV3ZlTTAvdlpTK1R1U0Nha1AwOUV6?= =?utf-8?B?MzRMMFdjbE11TEhPNi9UMld4MmJDZHRPbnMyUXVpTGNUQ3hIOFdxS2dVSjk1?= =?utf-8?B?K0FhOVhrTkZ0K1pmRG5mdXg2OTFTTkIvMFRUdzNWSWVJRHJHRmxFSDNUaVFM?= =?utf-8?B?NEgwWkpkYVRRVHp0aTNsOGVUQmFLK242Zm5XTXBNeHF5Sllod1NLZWExWTlI?= =?utf-8?B?V010UUc3UU9sUmVScWRVWVVYMVRvd0tLVG9LWklCb29Bc0h1aHhmam5tTCtD?= =?utf-8?B?ZkZYdHRBVGVmZW5vYjdTNk1YV2JXQlNmRXAzai9Ud0s4Rjc0Ui9vM0NmYUhx?= =?utf-8?B?MFBDNHhLbXA3am84aEptWU5iUm5JSzhiZHdXeFZZSkkyT1lCejRMdzI2eVJN?= =?utf-8?B?Q016bFhLcHY4VU9FeFVRc1p3RVArSmFaTTZlWXJCVUpuUFMzdDFQSzBVSm0x?= =?utf-8?B?YWpJdDhRUzErZWdVWWNmODJQVktMWUt3YXIvSTBVdTF3TjZSRGNoUHRzOEgz?= =?utf-8?B?bnI4aW1FMXpIYlJ0Z2hzRTVjZ2RwV2hoOWVSMHdyMmJzTWE4ZkZqSXBDNnAv?= =?utf-8?B?TDdIaEFSR3hVa3FCWWtpM2VTbXZZMk9yZFM2bmpsNVkzYVNTRU1JQUtiQXZr?= =?utf-8?Q?K5Xx5uSFm+l9Kl71u4N+yYlFJ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33c2dec3-9676-42a7-31ec-08db4fc07899 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 12:34:07.2317 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /zf3fX9RteFjaRak6P5mo6iD+aEOpSQ31gUsAfZZkEnIMQxwDs5iaBc9+mDhcmk8GaYyERxWinxL/YBSGY+mZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9318 These are "compound" instructions to issue a series of RDMSR / WRMSR respectively. In the emulator we can therefore implement them by using the existing msr_{read,write}() hooks. The memory accesses utilize that the HVM ->read() / ->write() hooks are already linear-address (x86_seg_none) aware (by way of hvmemul_virtual_to_linear() handling this case). Preemption is being checked for in WRMSRLIST handling only, as only MSR writes are expected to possibly take long. Signed-off-by: Jan Beulich --- TODO: Once VMX tertiary execution control bit is known (see //todo) further adjust cpufeatureset.h. RFC: In vmx_vmexit_handler() handling is forwarded to the emulator blindly. Alternatively we could consult the exit qualification and process just a single MSR at a time (without involving the emulator), exiting back to the guest after every iteration. (I don't think a mix of both models makes a lot of sense.) With the VMX side of the spec still unclear (tertiary execution control bit still unspecified in ISE 048) we can't enable the insn yet for (HVM) guest use. The precise behavior of MSR_BARRIER is also not spelled out, so the (minimal) implementation is a guess for now. --- v2: Use X86_EXC_*. Add preemption checking to WRMSRLIST handling. Remove the feature from "max" when the VMX counterpart isn't available. --- a/tools/libs/light/libxl_cpuid.c +++ b/tools/libs/light/libxl_cpuid.c @@ -240,6 +240,7 @@ int libxl_cpuid_parse_config(libxl_cpuid {"lkgs", 0x00000007, 1, CPUID_REG_EAX, 18, 1}, {"wrmsrns", 0x00000007, 1, CPUID_REG_EAX, 19, 1}, {"avx-ifma", 0x00000007, 1, CPUID_REG_EAX, 23, 1}, + {"msrlist", 0x00000007, 1, CPUID_REG_EAX, 27, 1}, {"avx-vnni-int8",0x00000007, 1, CPUID_REG_EDX, 4, 1}, {"avx-ne-convert",0x00000007, 1, CPUID_REG_EDX, 5, 1}, --- a/tools/misc/xen-cpuid.c +++ b/tools/misc/xen-cpuid.c @@ -195,6 +195,8 @@ static const char *const str_7a1[32] = [18] = "lkgs", [19] = "wrmsrns", /* 22 */ [23] = "avx-ifma", + + /* 26 */ [27] = "msrlist", }; static const char *const str_e21a[32] = --- a/tools/tests/x86_emulator/predicates.c +++ b/tools/tests/x86_emulator/predicates.c @@ -342,6 +342,8 @@ static const struct { { { 0x01, 0xc4 }, { 2, 2 }, F, N }, /* vmxoff */ { { 0x01, 0xc5 }, { 2, 2 }, F, N }, /* pconfig */ { { 0x01, 0xc6 }, { 2, 2 }, F, N }, /* wrmsrns */ + { { 0x01, 0xc6 }, { 0, 2 }, F, W, pfx_f2 }, /* rdmsrlist */ + { { 0x01, 0xc6 }, { 0, 2 }, F, R, pfx_f3 }, /* wrmsrlist */ { { 0x01, 0xc8 }, { 2, 2 }, F, N }, /* monitor */ { { 0x01, 0xc9 }, { 2, 2 }, F, N }, /* mwait */ { { 0x01, 0xca }, { 2, 2 }, F, N }, /* clac */ --- a/tools/tests/x86_emulator/test_x86_emulator.c +++ b/tools/tests/x86_emulator/test_x86_emulator.c @@ -589,6 +589,7 @@ static int read( default: if ( !is_x86_user_segment(seg) ) return X86EMUL_UNHANDLEABLE; + case x86_seg_none: bytes_read += bytes; break; } @@ -619,7 +620,7 @@ static int write( if ( verbose ) printf("** %s(%u, %p,, %u,)\n", __func__, seg, (void *)offset, bytes); - if ( !is_x86_user_segment(seg) ) + if ( !is_x86_user_segment(seg) && seg != x86_seg_none ) return X86EMUL_UNHANDLEABLE; memcpy((void *)offset, p_data, bytes); return X86EMUL_OKAY; @@ -711,6 +712,10 @@ static int read_msr( { switch ( reg ) { + case 0x0000002f: /* BARRIER */ + *val = 0; + return X86EMUL_OKAY; + case 0xc0000080: /* EFER */ *val = ctxt->addr_size > 32 ? 0x500 /* LME|LMA */ : 0; return X86EMUL_OKAY; @@ -1499,9 +1504,53 @@ int main(int argc, char **argv) (gs_base != 0x0000111122224444UL) || gs_base_shadow ) goto fail; + printf("okay\n"); cp.extd.nscb = i; emulops.write_segment = NULL; + + printf("%-40s", "Testing rdmsrlist..."); + instr[0] = 0xf2; instr[1] = 0x0f; instr[2] = 0x01; instr[3] = 0xc6; + regs.rip = (unsigned long)&instr[0]; + regs.rsi = (unsigned long)(res + 0x80); + regs.rdi = (unsigned long)(res + 0x80 + 0x40 * 2); + regs.rcx = 0x0002000100008000UL; + gs_base_shadow = 0x0000222244446666UL; + memset(res + 0x80, ~0, 0x40 * 8 * 2); + res[0x80 + 0x0f * 2] = 0xc0000101; /* GS_BASE */ + res[0x80 + 0x0f * 2 + 1] = 0; + res[0x80 + 0x20 * 2] = 0xc0000102; /* SHADOW_GS_BASE */ + res[0x80 + 0x20 * 2 + 1] = 0; + res[0x80 + 0x31 * 2] = 0x2f; /* BARRIER */ + res[0x80 + 0x31 * 2 + 1] = 0; + rc = x86_emulate(&ctxt, &emulops); + if ( (rc != X86EMUL_OKAY) || + (regs.rip != (unsigned long)&instr[4]) || + regs.rcx || + (res[0x80 + (0x40 + 0x0f) * 2] != (unsigned int)gs_base) || + (res[0x80 + (0x40 + 0x0f) * 2 + 1] != (gs_base >> (8 * sizeof(int)))) || + (res[0x80 + (0x40 + 0x20) * 2] != (unsigned int)gs_base_shadow) || + (res[0x80 + (0x40 + 0x20) * 2 + 1] != (gs_base_shadow >> (8 * sizeof(int)))) || + res[0x80 + (0x40 + 0x31) * 2] || res[0x80 + (0x40 + 0x31) * 2 + 1] ) + goto fail; + printf("okay\n"); + + printf("%-40s", "Testing wrmsrlist..."); + instr[0] = 0xf3; instr[1] = 0x0f; instr[2] = 0x01; instr[3] = 0xc6; + regs.eip = (unsigned long)&instr[0]; + regs.rsi -= 0x11 * 8; + regs.rdi -= 0x11 * 8; + regs.rcx = 0x0002000100000000UL; + res[0x80 + 0x0f * 2] = 0xc0000102; /* SHADOW_GS_BASE */ + res[0x80 + 0x20 * 2] = 0xc0000101; /* GS_BASE */ + rc = x86_emulate(&ctxt, &emulops); + if ( (rc != X86EMUL_OKAY) || + (regs.rip != (unsigned long)&instr[4]) || + regs.rcx || + (gs_base != 0x0000222244446666UL) || + (gs_base_shadow != 0x0000111122224444UL) ) + goto fail; + emulops.write_msr = NULL; #endif printf("okay\n"); --- a/tools/tests/x86_emulator/x86-emulate.c +++ b/tools/tests/x86_emulator/x86-emulate.c @@ -88,6 +88,7 @@ bool emul_test_init(void) cp.feat.rdpid = true; cp.feat.lkgs = true; cp.feat.wrmsrns = true; + cp.feat.msrlist = true; cp.extd.clzero = true; if ( cpu_has_xsave ) --- a/xen/arch/x86/cpu-policy.c +++ b/xen/arch/x86/cpu-policy.c @@ -601,6 +601,9 @@ static void __init calculate_hvm_max_pol __clear_bit(X86_FEATURE_XSAVES, fs); } + if ( !cpu_has_vmx_msrlist ) + __clear_bit(X86_FEATURE_MSRLIST, fs); + /* * Xen doesn't use PKS, so the guest support for it has opted to not use * the VMCS load/save controls for efficiency reasons. This depends on --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -830,6 +830,20 @@ static void cf_check vmx_cpuid_policy_ch else vmx_set_msr_intercept(v, MSR_PKRS, VMX_MSR_RW); + if ( cp->feat.msrlist ) + { + vmx_clear_msr_intercept(v, MSR_BARRIER, VMX_MSR_RW); + v->arch.hvm.vmx.tertiary_exec_control |= TERTIARY_EXEC_ENABLE_MSRLIST; + vmx_update_tertiary_exec_control(v); + } + else if ( v->arch.hvm.vmx.tertiary_exec_control & + TERTIARY_EXEC_ENABLE_MSRLIST ) + { + vmx_set_msr_intercept(v, MSR_BARRIER, VMX_MSR_RW); + v->arch.hvm.vmx.tertiary_exec_control &= ~TERTIARY_EXEC_ENABLE_MSRLIST; + vmx_update_tertiary_exec_control(v); + } + out: vmx_vmcs_exit(v); @@ -3700,6 +3714,22 @@ gp_fault: return X86EMUL_EXCEPTION; } +static bool cf_check is_msrlist( + const struct x86_emulate_state *state, const struct x86_emulate_ctxt *ctxt) +{ + + if ( ctxt->opcode == X86EMUL_OPC(0x0f, 0x01) ) + { + unsigned int rm, reg; + int mode = x86_insn_modrm(state, &rm, ®); + + /* This also includes WRMSRNS; should be okay. */ + return mode == 3 && rm == 6 && !reg; + } + + return false; +} + static void vmx_do_extint(struct cpu_user_regs *regs) { unsigned long vector; @@ -4507,6 +4537,17 @@ void vmx_vmexit_handler(struct cpu_user_ } break; + case EXIT_REASON_RDMSRLIST: + case EXIT_REASON_WRMSRLIST: + if ( vmx_guest_x86_mode(v) != 8 || !currd->arch.cpuid->feat.msrlist ) + { + ASSERT_UNREACHABLE(); + hvm_inject_hw_exception(X86_EXC_UD, X86_EVENT_NO_EC); + } + else if ( !hvm_emulate_one_insn(is_msrlist, "MSR list") ) + hvm_inject_hw_exception(X86_EXC_GP, 0); + break; + case EXIT_REASON_VMXOFF: case EXIT_REASON_VMXON: case EXIT_REASON_VMCLEAR: --- a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h @@ -267,6 +267,7 @@ extern u32 vmx_secondary_exec_control; #define TERTIARY_EXEC_EPT_PAGING_WRITE BIT(2, UL) #define TERTIARY_EXEC_GUEST_PAGING_VERIFY BIT(3, UL) #define TERTIARY_EXEC_IPI_VIRT BIT(4, UL) +#define TERTIARY_EXEC_ENABLE_MSRLIST 0//todo extern uint64_t vmx_tertiary_exec_control; #define VMX_EPT_EXEC_ONLY_SUPPORTED 0x00000001 @@ -352,6 +353,8 @@ extern u64 vmx_ept_vpid_cap; (vmx_secondary_exec_control & SECONDARY_EXEC_BUS_LOCK_DETECTION) #define cpu_has_vmx_notify_vm_exiting \ (vmx_secondary_exec_control & SECONDARY_EXEC_NOTIFY_VM_EXITING) +#define cpu_has_vmx_msrlist \ + (vmx_tertiary_exec_control & TERTIARY_EXEC_ENABLE_MSRLIST) #define VMCS_RID_TYPE_MASK 0x80000000 --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h @@ -201,6 +201,8 @@ static inline void pi_clear_sn(struct pi #define EXIT_REASON_XRSTORS 64 #define EXIT_REASON_BUS_LOCK 74 #define EXIT_REASON_NOTIFY 75 +#define EXIT_REASON_RDMSRLIST 78 +#define EXIT_REASON_WRMSRLIST 79 /* Remember to also update VMX_PERF_EXIT_REASON_SIZE! */ /* --- a/xen/arch/x86/include/asm/msr-index.h +++ b/xen/arch/x86/include/asm/msr-index.h @@ -24,6 +24,8 @@ #define APIC_BASE_ENABLE (_AC(1, ULL) << 11) #define APIC_BASE_ADDR_MASK 0x000ffffffffff000ULL +#define MSR_BARRIER 0x0000002f + #define MSR_TEST_CTRL 0x00000033 #define TEST_CTRL_SPLITLOCK_DETECT (_AC(1, ULL) << 29) #define TEST_CTRL_SPLITLOCK_DISABLE (_AC(1, ULL) << 31) --- a/xen/arch/x86/include/asm/perfc_defn.h +++ b/xen/arch/x86/include/asm/perfc_defn.h @@ -6,7 +6,7 @@ PERFCOUNTER_ARRAY(exceptions, #ifdef CONFIG_HVM -#define VMX_PERF_EXIT_REASON_SIZE 76 +#define VMX_PERF_EXIT_REASON_SIZE 80 #define VMEXIT_NPF_PERFC 143 #define SVM_PERF_EXIT_REASON_SIZE (VMEXIT_NPF_PERFC + 1) PERFCOUNTER_ARRAY(vmexits, "vmexits", --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -72,6 +72,12 @@ int guest_rdmsr(struct vcpu *v, uint32_t case MSR_AMD_PPIN: goto gp_fault; + case MSR_BARRIER: + if ( !cp->feat.msrlist ) + goto gp_fault; + *val = 0; + break; + case MSR_IA32_FEATURE_CONTROL: /* * Architecturally, availability of this MSR is enumerated by the @@ -341,6 +347,7 @@ int guest_wrmsr(struct vcpu *v, uint32_t uint64_t rsvd; /* Read-only */ + case MSR_BARRIER: case MSR_IA32_PLATFORM_ID: case MSR_CORE_CAPABILITIES: case MSR_INTEL_CORE_THREAD_COUNT: --- a/xen/arch/x86/x86_emulate/0f01.c +++ b/xen/arch/x86/x86_emulate/0f01.c @@ -11,6 +11,7 @@ #include "private.h" #ifdef __XEN__ +#include #include #endif @@ -28,6 +29,7 @@ int x86emul_0f01(struct x86_emulate_stat switch ( s->modrm ) { unsigned long base, limit, cr0, cr0w, cr4; + unsigned int n; struct segment_register sreg; uint64_t msr_val; @@ -42,6 +44,64 @@ int x86emul_0f01(struct x86_emulate_stat ((uint64_t)regs->r(dx) << 32) | regs->eax, ctxt); goto done; + + case vex_f3: /* wrmsrlist */ + vcpu_must_have(msrlist); + generate_exception_if(!mode_64bit(), X86_EXC_UD); + generate_exception_if(!mode_ring0() || (regs->r(si) & 7) || + (regs->r(di) & 7), + X86_EXC_GP, 0); + fail_if(!ops->write_msr); + while ( regs->r(cx) ) + { + n = __builtin_ffsl(regs->r(cx)) - 1; + if ( (rc = ops->read(x86_seg_none, regs->r(si) + n * 8, + &msr_val, 8, ctxt)) != X86EMUL_OKAY ) + break; + generate_exception_if(msr_val != (uint32_t)msr_val, + X86_EXC_GP, 0); + base = msr_val; + if ( (rc = ops->read(x86_seg_none, regs->r(di) + n * 8, + &msr_val, 8, ctxt)) != X86EMUL_OKAY || + (rc = ops->write_msr(base, msr_val, ctxt)) != X86EMUL_OKAY ) + break; + regs->r(cx) &= ~(1UL << n); + +#ifdef __XEN__ + if ( regs->r(cx) && local_events_need_delivery() ) + { + rc = X86EMUL_RETRY; + break; + } +#endif + } + goto done; + + case vex_f2: /* rdmsrlist */ + vcpu_must_have(msrlist); + generate_exception_if(!mode_64bit(), X86_EXC_UD); + generate_exception_if(!mode_ring0() || (regs->r(si) & 7) || + (regs->r(di) & 7), + X86_EXC_GP, 0); + fail_if(!ops->read_msr || !ops->write); + while ( regs->r(cx) ) + { + n = __builtin_ffsl(regs->r(cx)) - 1; + if ( (rc = ops->read(x86_seg_none, regs->r(si) + n * 8, + &msr_val, 8, ctxt)) != X86EMUL_OKAY ) + break; + generate_exception_if(msr_val != (uint32_t)msr_val, + X86_EXC_GP, 0); + if ( (rc = ops->read_msr(msr_val, &msr_val, + ctxt)) != X86EMUL_OKAY || + (rc = ops->write(x86_seg_none, regs->r(di) + n * 8, + &msr_val, 8, ctxt)) != X86EMUL_OKAY ) + break; + regs->r(cx) &= ~(1UL << n); + } + if ( rc != X86EMUL_OKAY ) + ctxt->regs->r(cx) = regs->r(cx); + goto done; } generate_exception(X86_EXC_UD); --- a/xen/arch/x86/x86_emulate/private.h +++ b/xen/arch/x86/x86_emulate/private.h @@ -588,6 +588,7 @@ amd_like(const struct x86_emulate_ctxt * #define vcpu_has_lkgs() (ctxt->cpuid->feat.lkgs) #define vcpu_has_wrmsrns() (ctxt->cpuid->feat.wrmsrns) #define vcpu_has_avx_ifma() (ctxt->cpuid->feat.avx_ifma) +#define vcpu_has_msrlist() (ctxt->cpuid->feat.msrlist) #define vcpu_has_avx_vnni_int8() (ctxt->cpuid->feat.avx_vnni_int8) #define vcpu_has_avx_ne_convert() (ctxt->cpuid->feat.avx_ne_convert) --- a/xen/arch/x86/x86_emulate/util.c +++ b/xen/arch/x86/x86_emulate/util.c @@ -100,6 +100,9 @@ bool cf_check x86_insn_is_mem_access(con break; case X86EMUL_OPC(0x0f, 0x01): + /* {RD,WR}MSRLIST */ + if ( mode_64bit() && s->modrm == 0xc6 ) + return s->vex.pfx >= vex_f3; /* Cover CLZERO. */ return (s->modrm_rm & 7) == 4 && (s->modrm_reg & 7) == 7; } @@ -160,7 +163,11 @@ bool cf_check x86_insn_is_mem_write(cons case 0xff: /* Grp5 */ break; - case X86EMUL_OPC(0x0f, 0x01): /* CLZERO is the odd one. */ + case X86EMUL_OPC(0x0f, 0x01): + /* RDMSRLIST */ + if ( mode_64bit() && s->modrm == 0xc6 ) + return s->vex.pfx == vex_f2; + /* CLZERO is another odd one. */ return (s->modrm_rm & 7) == 4 && (s->modrm_reg & 7) == 7; default: --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -286,6 +286,7 @@ XEN_CPUFEATURE(FRED, 10*32+17) / XEN_CPUFEATURE(LKGS, 10*32+18) /*S Load Kernel GS Base */ XEN_CPUFEATURE(WRMSRNS, 10*32+19) /*S WRMSR Non-Serialising */ XEN_CPUFEATURE(AVX_IFMA, 10*32+23) /*A AVX-IFMA Instructions */ +XEN_CPUFEATURE(MSRLIST, 10*32+27) /* MSR list instructions */ /* AMD-defined CPU features, CPUID level 0x80000021.eax, word 11 */ XEN_CPUFEATURE(LFENCE_DISPATCH, 11*32+ 2) /*A LFENCE always serializing */ From xen-devel-bounces@lists.xenproject.org Mon May 08 12:34:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 12:34:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531505.827245 (Exim 4.92) (envelope-from ) id 1pw04v-0005TU-Sy; Mon, 08 May 2023 12:34:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531505.827245; Mon, 08 May 2023 12:34:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw04v-0005TN-QL; Mon, 08 May 2023 12:34:57 +0000 Received: by outflank-mailman (input) for mailman id 531505; Mon, 08 May 2023 12:33:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw03o-0003kR-3C for xen-devel@lists.xenproject.org; Mon, 08 May 2023 12:33:48 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on20624.outbound.protection.outlook.com [2a01:111:f400:fe5a::624]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 92141580-ed9c-11ed-b226-6b7b168915f2; Mon, 08 May 2023 14:33:45 +0200 (CEST) Received: from MN0PR12MB6079.namprd12.prod.outlook.com (2603:10b6:208:3c9::13) by BL0PR12MB5009.namprd12.prod.outlook.com (2603:10b6:208:1c2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Mon, 8 May 2023 12:33:41 +0000 Received: from MN0PR12MB6079.namprd12.prod.outlook.com ([fe80::e454:fcba:69ae:728f]) by MN0PR12MB6079.namprd12.prod.outlook.com ([fe80::e454:fcba:69ae:728f%7]) with mapi id 15.20.6363.032; Mon, 8 May 2023 12:33:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 92141580-ed9c-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j/QLxgqsx5B1hvVHaVJ3JEwWLaXBDFG+ertJ0/kjccuo3BeW4I2nZRA3gUAYjtCPwmGI2qjb7IaTQ6261CQErMFIQKkB3jr6Y0RvJE7pj7z0bUBI3ccfRHja0suVZxjF5ISrwKy10J5lK1m0fhZofIGSUc8934itBmxMeWVNl7ZTxMDQbohqlLPdppP8CXjZDCLo6oaD3YMN2scFp5pjL0iZ38+lsmupDsEB4nuDDwYmQuwDKokuy+qEjNlUFylchVMQo3OIVcf+5czOKj4zuL6LvuqqYsnbh6/uVIAU1DqfRv0KE2Q3lfFnBQgz8Cq4M/rrU8l2QffGg0cW1eGBZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WYqWbYuXDvj6TSNImC7BXmYK/ywqaOpoS6YFN0CCBBw=; b=AzoPsgTKOfXS9fQGUbWCw9lpvEZcwQeqDYHQFQoEKwlDKXsaFybDQCRz7pSssCK6mSPlMuJ9ktyBgeQPbNtO1UYtwEtJbEglPXfV0eexoe5YiXJ/EBLuqwcHhWZua1MB2egJD5bHZrRPOlvoK7DBL2Yg26v15AykgggQ+660B2ciSZl+EGEgbtycltTgkWTZHbN4xoQSWvWhnif7puCVng74voCnjwHE2Rp3+hsOmyGPR5mFjgfnNjs6qaIIYoGIziGJLChCJLcaCZJGwb+SwG2RxSa9p89veGnpFIJ7NNFHqvTaZnE7PibyqzXUnj54gi1v8gmFWZmjVZ5wnbWByQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WYqWbYuXDvj6TSNImC7BXmYK/ywqaOpoS6YFN0CCBBw=; b=5L+W9vKai6y9mPcOCmien2x6k/bCmqPxLj+GMf3pH6RjYxLbClagWYSOUsScwaAeNtZIlP+3BEkhhSa4vNEdhCYUu99u1in1UUzu4I15yftqwIndnsCfxpA8Z5xi7yprewaPP2XjPqrgzs7QdEMq4ZgmauA6XrNRH9kHw3VXjf4= From: "Mallela, RaghavendraPrasad (Raghavendra Prasad)" To: "xen-devel@lists.xenproject.org" , "xen-users@lists.xenproject.org" CC: "SHARMA, JYOTIRMOY" , "Stabellini, Stefano" Subject: Camera Virtualization Thread-Topic: Camera Virtualization Thread-Index: AdmBp7+i8bgPkutESA2yV0wZFwMI9w== Date: Mon, 8 May 2023 12:33:41 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-05-08T12:33:39Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=fe803404-e6b6-4be7-b52d-f6f8ca114558; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN0PR12MB6079:EE_|BL0PR12MB5009:EE_ x-ms-office365-filtering-correlation-id: c0ec9681-896f-4378-8597-08db4fc074c1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7CqGVRd1TziMRAyaXfFX6brV28XOtGeMKE9L9uaGdATBAa/r/ReQCzv1kJQ6X6HvtXGttrSCt1znIDzfTAInzPgzIB4/eD2mqsAkf8vGLmu9i8lBUfxU6CzqjW04hf6EZaGUXLknNV3WwoZLLcNfGayhbWEZfzf+AFtr93RrHSeyyb2VyJ1W8dx4ICd5L2v/GBD7MWHzLUq5nAoAxTZs7n3aUPn6fLHfEQ/b4eKhx+9iVninb3xjOYdqBKobsiGFOtQtIV6AxUSAjMPzUw4ofj4OMw1OP6VKn2BbEYP4PsHoIo9MrLkT5KXYdGMkJoh2T46knmxJqdf/LqCi1IouDY/JsJ+uoU6exMOOfquUuhfWh+5kiRjfEa0PM1dxfLIXiJanohsR3GKs1EycL+9ZXg9bWUe9pySpsdS5MldgIEWHms4K6V4cuaCq6RZcUqROO9H3tofcD2QseFlVNwWAk5kk7yvHYz3WFAzGsm7njbHRySDFSof3wQaJLXsbjepX8Nh3MyEZfKEQoRhkTMfBm9GupqmVajRTE0k/ZnyKCwFalI9B04VAJhfaFgK4S4b1YTlN7JRNpXTY05cwF7CiszVM/Q99esA7+9xRngbl+OnZZm/c3v1J1Toi1AbCTjM0r7i63Eqv9/8xy8XuUKwnRQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN0PR12MB6079.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(366004)(346002)(136003)(396003)(376002)(451199021)(4744005)(2906002)(7116003)(52536014)(5660300002)(38070700005)(166002)(38100700002)(122000001)(33656002)(86362001)(3480700007)(55016003)(54906003)(110136005)(6506007)(9686003)(478600001)(186003)(26005)(450100002)(966005)(7696005)(71200400001)(316002)(8936002)(66446008)(64756008)(66556008)(8676002)(41300700001)(66476007)(76116006)(66946007)(4326008)(83380400001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IzWGawMNeW1P6N030XyAlNkislZcCAhLPLVVnCIwYgTbGG2/GvN2w564Pbcg?= =?us-ascii?Q?RLGBF73FPV0cVzN4q1tcYDdCPWI/6hyYiC5R8umrc9oNdwm0YD+kQlnR4tZm?= =?us-ascii?Q?xeTr00oALwstHnCGeOpNgzjRzwtRajPj7tUV4f7JVwmEC+jR85jnrc9NW1rR?= =?us-ascii?Q?Xa6sdr7R3uY1Qv5si3m+5NnQ2IldJZgSjGbOcTxOWAa+nEZuDj0rnMe7d8nh?= =?us-ascii?Q?9Z/m8Aw8tqhfSjK32eZYlDwkZ+bOOROneXob7PK8yKF7EznlTM7jV3BwCADX?= =?us-ascii?Q?xRT5ishTv2IX1GBG3KQFP9csF+BV6AhjhsSbxk8cA2KQb/FJs/ghE8VngNeq?= =?us-ascii?Q?Nsh6M1hUX9g/e3m8DcpHYhk0ZWDl/gWt4mW2mhQMuRGOyA/mg7dDAuyu3Lf0?= =?us-ascii?Q?RYBAQ6hwwGnM2J3Lpj6I4qJLv5nSALvM5F9pXbgvjZC97ctxAMcgKDGbX2QD?= =?us-ascii?Q?+LNlbbuViBVydbZbo7Cg0iD/k044ZxhMZLUKvyl80YrlBRrIDqf47Lix0LB6?= =?us-ascii?Q?EgUbXDkjh3oOGcfE92nlZ8HrCmWRbmUfwv/pRKLbrqFbAvFGsw09vnbtuV9p?= =?us-ascii?Q?g/HZb15sWd7tuoCRSO+yMoBcttB4OPeCWjeYj12xMAMvMvZS6u+HOyqyavVV?= =?us-ascii?Q?qJ54DWEOaRnSUaQfhpEfi6ymRJEbEaUCBpbak+E1dwtZyoF8OXBO+U796eYq?= =?us-ascii?Q?YHad8egdeKRbRdIqQ9pCYgC5LCjWTNWQ63Y7uhAuf6XhAHG/fX8wxGa9qJjJ?= =?us-ascii?Q?0v6Sh4dYdwu4vCq66ZLpeDiD0icCFlQvUnIcfl02FAEEy3kkmWJ4uczqMDuU?= =?us-ascii?Q?0K2caCBvyEd6Yh/oMBRewAzmyof829lWFcyKmj4WT/3U7KQCCooJVgjp8pVQ?= =?us-ascii?Q?lmlh40CYXCyATltaWIFvZ46ZRG+OQgSUhR1KzNpHCTDVn9pyIXs+lxQreFtH?= =?us-ascii?Q?NJ5Xj5ZcTZr635WhJenEg2SHT5faAj3nTiuJ35SOoJAXRc3TuC0ZnxaAeHWs?= =?us-ascii?Q?9tc4Muqw/wz5tLXCJJIL2bu9quTERyuLbCqplm8hYOZQ5FT49duve5AGaQQ8?= =?us-ascii?Q?uRnk6CbrqErDbMklQKCxFMjnD/aTwrrbxbhIruj6a4oCBkCQJ7IBpkcXQUTp?= =?us-ascii?Q?yhXzNJocCvh/wfZvKuhQCAb8eDKs+9QgZELyvq+icw07LJ2wxAeI18S+cw4R?= =?us-ascii?Q?RyrceKtnvzvYgT9/q/vMK/a56IUmkXpYIKGrkWQ3UTujL0M+vreHOBWSDZz2?= =?us-ascii?Q?jnCZpxi9+N8RtOfuYuCVbXCRzoxqhDYxijvn72+BUBuN3Bc80jNUI4n7UgcP?= =?us-ascii?Q?yW4rCzrokjEl1Pw7HQp5gBnke1/aeP0damjtj1c4lpRtinIewc6vOhYj2xMz?= =?us-ascii?Q?muQz+OqU1KIHhdDRiqXvC2obGQmxIZOHn+bcycJvXJcORxIGPqJSxkxwTUAI?= =?us-ascii?Q?0yclQPAbmXUHipy2jGQ3dtyc/5mAUrEzMHIvpI7Sh6kcsvgw2knRmbQQ9Zxn?= =?us-ascii?Q?FJ5aDd06/T7Ie3hbYQBODeQHLvIOIiq+9JEL66hOY/eIOMVVlJW8s+zUJtUM?= =?us-ascii?Q?XY2CuwFeyTcp7VdKLAE=3D?= Content-Type: multipart/alternative; boundary="_000_MN0PR12MB6079CF8A38A6EB9FA7B97F29F5719MN0PR12MB6079namp_" MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6079.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c0ec9681-896f-4378-8597-08db4fc074c1 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2023 12:33:41.3813 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iTNvPclckLvaOzMb5JN27HTLFjZrPvjEI3x828bea4pVVUZXwKBeuni0D85yi5ULaDc1pDvhhqGoD5I4tfLXMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB5009 --_000_MN0PR12MB6079CF8A38A6EB9FA7B97F29F5719MN0PR12MB6079namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hello all, We want to virtualize the camera that uses the V4L2 Linux drivers i.e.., wa= nted to use the Camera APP in DOMU. Searched online and found 2 approaches to virtualize the camera. FE and BE: FrontEnd Driver is available at https://github.com/andr2000/linux/commits/c= amera_front_v1/drivers/media/xen BackEnd Driver is available at https://github.com/andr2000/camera_be VirtIO Implementation: Collabora implemented the VirtIO Camera implementation and is available at = https://gitlab.collabora.com/collabora/virtio-camera Does anyone used above implementations? Please guide us on which approach is best to use for Camera Virtualization? Raghavendra M --_000_MN0PR12MB6079CF8A38A6EB9FA7B97F29F5719MN0PR12MB6079namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

[AMD Official Use O= nly - General]


 

Hello all,

 

We want to virtualize the camera that uses the V4L2 = Linux drivers i.e.., wanted to use the Camera APP in DOMU.

Searched online and found 2 approaches to virtualize= the camera.

 

FE and BE:

FrontEnd Driver is available at https://github.com/andr2000/linux/commits/camera_front_v1/drivers/media/xen=

BackEnd Driver is available at https://github.com/andr2000/camera_be

 

VirtIO Implementation:

Collabora implemented the VirtIO Camera implementati= on and is available at  https://gitlab.collabora.com/collabora/virtio-camera=

 

Does anyone used above implementations?

Please guide us on which approach is best to use for= Camera Virtualization?

 

Raghavendra M

--_000_MN0PR12MB6079CF8A38A6EB9FA7B97F29F5719MN0PR12MB6079namp_-- From xen-devel-bounces@lists.xenproject.org Mon May 08 12:42:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 12:42:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531521.827254 (Exim 4.92) (envelope-from ) id 1pw0CU-0007A9-P8; Mon, 08 May 2023 12:42:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531521.827254; Mon, 08 May 2023 12:42:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw0CU-0007A2-MZ; Mon, 08 May 2023 12:42:46 +0000 Received: by outflank-mailman (input) for mailman id 531521; Mon, 08 May 2023 12:41:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw0Aw-00077B-Sm for xen-devel@lists.xenproject.org; Mon, 08 May 2023 12:41:10 +0000 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 98b1103a-ed9d-11ed-b226-6b7b168915f2; Mon, 08 May 2023 14:41:08 +0200 (CEST) Received: from dggpemm500005.china.huawei.com (unknown [172.30.72.55]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4QFLTg4rC7zpWDH; Mon, 8 May 2023 20:39:51 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by dggpemm500005.china.huawei.com (7.185.36.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 8 May 2023 20:41:03 +0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 98b1103a-ed9d-11ed-b226-6b7b168915f2 From: Yunsheng Lin To: CC: , , , , , , , , , , , Subject: [PATCH RFC 2/2] net: remove __skb_frag_set_page() Date: Mon, 8 May 2023 20:39:22 +0800 Message-ID: <20230508123922.39284-3-linyunsheng@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20230508123922.39284-1-linyunsheng@huawei.com> References: <20230508123922.39284-1-linyunsheng@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500005.china.huawei.com (7.185.36.74) X-CFilter-Loop: Reflected The remaining users calling __skb_frag_set_page() with page being NULL seems to doing defensive programming, as shinfo->nr_frags is already decremented, so remove them. Signed-off-by: Yunsheng Lin --- drivers/net/ethernet/broadcom/bnx2.c | 1 - drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 - include/linux/skbuff.h | 12 ------------ 3 files changed, 14 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnx2.c b/drivers/net/ethernet/broadcom/bnx2.c index 466e1d62bcf6..0d917a9699c5 100644 --- a/drivers/net/ethernet/broadcom/bnx2.c +++ b/drivers/net/ethernet/broadcom/bnx2.c @@ -2955,7 +2955,6 @@ bnx2_reuse_rx_skb_pages(struct bnx2 *bp, struct bnx2_rx_ring_info *rxr, shinfo = skb_shinfo(skb); shinfo->nr_frags--; page = skb_frag_page(&shinfo->frags[shinfo->nr_frags]); - __skb_frag_set_page(&shinfo->frags[shinfo->nr_frags], NULL); cons_rx_pg->page = page; dev_kfree_skb(skb); diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index efaff5018af8..f3f08660ec30 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -1105,7 +1105,6 @@ static u32 __bnxt_rx_agg_pages(struct bnxt *bp, unsigned int nr_frags; nr_frags = --shinfo->nr_frags; - __skb_frag_set_page(&shinfo->frags[nr_frags], NULL); cons_rx_buf->page = page; /* Update prod since possibly some pages have been diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 0d1027ea81e0..a3c448757b4e 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -3491,18 +3491,6 @@ static inline void skb_frag_page_copy(skb_frag_t *fragto, fragto->bv_page = fragfrom->bv_page; } -/** - * __skb_frag_set_page - sets the page contained in a paged fragment - * @frag: the paged fragment - * @page: the page to set - * - * Sets the fragment @frag to contain @page. - */ -static inline void __skb_frag_set_page(skb_frag_t *frag, struct page *page) -{ - frag->bv_page = page; -} - bool skb_page_frag_refill(unsigned int sz, struct page_frag *pfrag, gfp_t prio); /** -- 2.33.0 From xen-devel-bounces@lists.xenproject.org Mon May 08 12:42:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 12:42:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531522.827260 (Exim 4.92) (envelope-from ) id 1pw0CV-0007DX-1r; Mon, 08 May 2023 12:42:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531522.827260; Mon, 08 May 2023 12:42:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw0CU-0007DQ-UK; Mon, 08 May 2023 12:42:46 +0000 Received: by outflank-mailman (input) for mailman id 531522; Mon, 08 May 2023 12:41:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw0Ax-00077B-Hm for xen-devel@lists.xenproject.org; Mon, 08 May 2023 12:41:11 +0000 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 98b13109-ed9d-11ed-b226-6b7b168915f2; Mon, 08 May 2023 14:41:07 +0200 (CEST) Received: from dggpemm500005.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4QFLQG4gGLz18LFB; Mon, 8 May 2023 20:36:54 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by dggpemm500005.china.huawei.com (7.185.36.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 8 May 2023 20:41:02 +0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 98b13109-ed9d-11ed-b226-6b7b168915f2 From: Yunsheng Lin To: CC: , , , , , , , , , , , Subject: [PATCH RFC 1/2] net: introduce and use skb_frag_fill_page_desc() Date: Mon, 8 May 2023 20:39:21 +0800 Message-ID: <20230508123922.39284-2-linyunsheng@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20230508123922.39284-1-linyunsheng@huawei.com> References: <20230508123922.39284-1-linyunsheng@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500005.china.huawei.com (7.185.36.74) X-CFilter-Loop: Reflected Most users use __skb_frag_set_page()/skb_frag_off_set()/ skb_frag_size_set() to fill the page desc for a skb frag. Introduce skb_frag_fill_page_desc() to do that. net/bpf/test_run.c does not call skb_frag_off_set() to set the offset, "copy_from_user(page_address(page), ...)" suggest that it is assuming offset to be initialized as zero, so call skb_frag_fill_page_desc() with offset being zero for this case. Also, skb_frag_set_page() is not used anymore, so remove it. Signed-off-by: Yunsheng Lin --- .../net/ethernet/aquantia/atlantic/aq_ring.c | 6 ++-- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 5 ++-- drivers/net/ethernet/chelsio/cxgb3/sge.c | 5 ++-- drivers/net/ethernet/emulex/benet/be_main.c | 30 +++++++++---------- drivers/net/ethernet/freescale/enetc/enetc.c | 5 ++-- .../net/ethernet/fungible/funeth/funeth_rx.c | 5 ++-- drivers/net/ethernet/marvell/mvneta.c | 5 ++-- .../net/ethernet/mellanox/mlx5/core/en_rx.c | 4 +-- drivers/net/ethernet/sun/cassini.c | 8 ++--- drivers/net/virtio_net.c | 4 +-- drivers/net/vmxnet3/vmxnet3_drv.c | 4 +-- drivers/net/xen-netback/netback.c | 4 +-- include/linux/skbuff.h | 27 +++++++---------- net/bpf/test_run.c | 3 +- net/core/gro.c | 4 +-- net/core/pktgen.c | 13 ++++---- net/core/skbuff.c | 7 ++--- net/tls/tls_device.c | 10 +++---- net/xfrm/xfrm_ipcomp.c | 5 +--- 19 files changed, 62 insertions(+), 92 deletions(-) diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c index 7f933175cbda..4de22eed099a 100644 --- a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c @@ -532,10 +532,10 @@ static bool aq_add_rx_fragment(struct device *dev, buff_->rxdata.pg_off, buff_->len, DMA_FROM_DEVICE); - skb_frag_off_set(frag, buff_->rxdata.pg_off); - skb_frag_size_set(frag, buff_->len); sinfo->xdp_frags_size += buff_->len; - __skb_frag_set_page(frag, buff_->rxdata.page); + skb_frag_fill_page_desc(frag, buff_->rxdata.page, + buff_->rxdata.pg_off, + buff_->len); buff_->is_cleaned = 1; diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index dcd9367f05af..efaff5018af8 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -1085,9 +1085,8 @@ static u32 __bnxt_rx_agg_pages(struct bnxt *bp, RX_AGG_CMP_LEN) >> RX_AGG_CMP_LEN_SHIFT; cons_rx_buf = &rxr->rx_agg_ring[cons]; - skb_frag_off_set(frag, cons_rx_buf->offset); - skb_frag_size_set(frag, frag_len); - __skb_frag_set_page(frag, cons_rx_buf->page); + skb_frag_fill_page_desc(frag, cons_rx_buf->page, + cons_rx_buf->offset, frag_len); shinfo->nr_frags = i + 1; __clear_bit(cons, rxr->rx_agg_bmap); diff --git a/drivers/net/ethernet/chelsio/cxgb3/sge.c b/drivers/net/ethernet/chelsio/cxgb3/sge.c index efa7f401529e..2e9a74fe0970 100644 --- a/drivers/net/ethernet/chelsio/cxgb3/sge.c +++ b/drivers/net/ethernet/chelsio/cxgb3/sge.c @@ -2184,9 +2184,8 @@ static void lro_add_page(struct adapter *adap, struct sge_qset *qs, len -= offset; rx_frag += nr_frags; - __skb_frag_set_page(rx_frag, sd->pg_chunk.page); - skb_frag_off_set(rx_frag, sd->pg_chunk.offset + offset); - skb_frag_size_set(rx_frag, len); + skb_frag_fill_page_desc(rx_frag, sd->pg_chunk.page, + sd->pg_chunk.offset + offset, len); skb->len += len; skb->data_len += len; diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index 7e408bcc88de..49b6a0e28840 100644 --- a/drivers/net/ethernet/emulex/benet/be_main.c +++ b/drivers/net/ethernet/emulex/benet/be_main.c @@ -2343,11 +2343,10 @@ static void skb_fill_rx_data(struct be_rx_obj *rxo, struct sk_buff *skb, hdr_len = ETH_HLEN; memcpy(skb->data, start, hdr_len); skb_shinfo(skb)->nr_frags = 1; - skb_frag_set_page(skb, 0, page_info->page); - skb_frag_off_set(&skb_shinfo(skb)->frags[0], - page_info->page_offset + hdr_len); - skb_frag_size_set(&skb_shinfo(skb)->frags[0], - curr_frag_len - hdr_len); + skb_frag_fill_page_desc(&skb_shinfo(skb)->frags[0], + page_info->page, + page_info->page_offset + hdr_len, + curr_frag_len - hdr_len); skb->data_len = curr_frag_len - hdr_len; skb->truesize += rx_frag_size; skb->tail += hdr_len; @@ -2369,16 +2368,16 @@ static void skb_fill_rx_data(struct be_rx_obj *rxo, struct sk_buff *skb, if (page_info->page_offset == 0) { /* Fresh page */ j++; - skb_frag_set_page(skb, j, page_info->page); - skb_frag_off_set(&skb_shinfo(skb)->frags[j], - page_info->page_offset); - skb_frag_size_set(&skb_shinfo(skb)->frags[j], 0); + skb_frag_fill_page_desc(&skb_shinfo(skb)->frags[j], + page_info->page, + page_info->page_offset, + curr_frag_len); skb_shinfo(skb)->nr_frags++; } else { put_page(page_info->page); + skb_frag_size_add(&skb_shinfo(skb)->frags[j], curr_frag_len); } - skb_frag_size_add(&skb_shinfo(skb)->frags[j], curr_frag_len); skb->len += curr_frag_len; skb->data_len += curr_frag_len; skb->truesize += rx_frag_size; @@ -2451,14 +2450,15 @@ static void be_rx_compl_process_gro(struct be_rx_obj *rxo, if (i == 0 || page_info->page_offset == 0) { /* First frag or Fresh page */ j++; - skb_frag_set_page(skb, j, page_info->page); - skb_frag_off_set(&skb_shinfo(skb)->frags[j], - page_info->page_offset); - skb_frag_size_set(&skb_shinfo(skb)->frags[j], 0); + skb_frag_fill_page_desc(&skb_shinfo(skb)->frags[j], + page_info->page, + page_info->page_offset, + curr_frag_len); } else { put_page(page_info->page); + skb_frag_size_add(&skb_shinfo(skb)->frags[j], curr_frag_len); } - skb_frag_size_add(&skb_shinfo(skb)->frags[j], curr_frag_len); + skb->truesize += rx_frag_size; remaining -= curr_frag_len; memset(page_info, 0, sizeof(*page_info)); diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c b/drivers/net/ethernet/freescale/enetc/enetc.c index 3c4fa26f0f9b..63854294ac33 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc.c +++ b/drivers/net/ethernet/freescale/enetc/enetc.c @@ -1445,9 +1445,8 @@ static void enetc_add_rx_buff_to_xdp(struct enetc_bdr *rx_ring, int i, xdp_buff_set_frag_pfmemalloc(xdp_buff); frag = &shinfo->frags[shinfo->nr_frags]; - skb_frag_off_set(frag, rx_swbd->page_offset); - skb_frag_size_set(frag, size); - __skb_frag_set_page(frag, rx_swbd->page); + skb_frag_fill_page_desc(frag, rx_swbd->page, rx_swbd->page_offset, + size); shinfo->nr_frags++; } diff --git a/drivers/net/ethernet/fungible/funeth/funeth_rx.c b/drivers/net/ethernet/fungible/funeth/funeth_rx.c index 29a6c2ede43a..7e2584895de3 100644 --- a/drivers/net/ethernet/fungible/funeth/funeth_rx.c +++ b/drivers/net/ethernet/fungible/funeth/funeth_rx.c @@ -323,9 +323,8 @@ static int fun_gather_pkt(struct funeth_rxq *q, unsigned int tot_len, if (ref_ok) ref_ok |= buf->node; - __skb_frag_set_page(frags, buf->page); - skb_frag_off_set(frags, q->buf_offset); - skb_frag_size_set(frags++, frag_len); + skb_frag_fill_page_desc(frags++, buf->page, q->buf_offset, + frag_len); tot_len -= frag_len; if (!tot_len) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index 2cad76d0a50e..01b0312977d6 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -2369,9 +2369,8 @@ mvneta_swbm_add_rx_fragment(struct mvneta_port *pp, if (data_len > 0 && sinfo->nr_frags < MAX_SKB_FRAGS) { skb_frag_t *frag = &sinfo->frags[sinfo->nr_frags++]; - skb_frag_off_set(frag, pp->rx_offset_correction); - skb_frag_size_set(frag, data_len); - __skb_frag_set_page(frag, page); + skb_frag_fill_page_desc(frag, page, + pp->rx_offset_correction, data_len); if (!xdp_buff_has_frags(xdp)) { sinfo->xdp_frags_size = *size; diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c index 69634829558e..704b022cd1f0 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c @@ -491,9 +491,7 @@ mlx5e_add_skb_shared_info_frag(struct mlx5e_rq *rq, struct skb_shared_info *sinf } frag = &sinfo->frags[sinfo->nr_frags++]; - __skb_frag_set_page(frag, frag_page->page); - skb_frag_off_set(frag, frag_offset); - skb_frag_size_set(frag, len); + skb_frag_fill_page_desc(frag, frag_page->page, frag_offset, len); if (page_is_pfmemalloc(frag_page->page)) xdp_buff_set_frag_pfmemalloc(xdp); diff --git a/drivers/net/ethernet/sun/cassini.c b/drivers/net/ethernet/sun/cassini.c index 4ef05bad4613..2d52f54ebb45 100644 --- a/drivers/net/ethernet/sun/cassini.c +++ b/drivers/net/ethernet/sun/cassini.c @@ -1998,10 +1998,8 @@ static int cas_rx_process_pkt(struct cas *cp, struct cas_rx_comp *rxc, skb->truesize += hlen - swivel; skb->len += hlen - swivel; - __skb_frag_set_page(frag, page->buffer); + skb_frag_fill_page_desc(frag, page->buffer, off, hlen - swivel); __skb_frag_ref(frag); - skb_frag_off_set(frag, off); - skb_frag_size_set(frag, hlen - swivel); /* any more data? */ if ((words[0] & RX_COMP1_SPLIT_PKT) && ((dlen -= hlen) > 0)) { @@ -2024,10 +2022,8 @@ static int cas_rx_process_pkt(struct cas *cp, struct cas_rx_comp *rxc, skb->len += hlen; frag++; - __skb_frag_set_page(frag, page->buffer); + skb_frag_fill_page_desc(frag, page->buffer, 0, hlen); __skb_frag_ref(frag); - skb_frag_off_set(frag, 0); - skb_frag_size_set(frag, hlen); RX_USED_ADD(page, hlen + cp->crc_size); } diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 8d8038538fc4..b4c0d1acb3ae 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -1153,9 +1153,7 @@ static int virtnet_build_xdp_buff_mrg(struct net_device *dev, } frag = &shinfo->frags[shinfo->nr_frags++]; - __skb_frag_set_page(frag, page); - skb_frag_off_set(frag, offset); - skb_frag_size_set(frag, len); + skb_frag_fill_page_desc(frag, page, offset, len); if (page_is_pfmemalloc(page)) xdp_buff_set_frag_pfmemalloc(xdp); diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index f2b76ee866a4..7fa74b8b2100 100644 --- a/drivers/net/vmxnet3/vmxnet3_drv.c +++ b/drivers/net/vmxnet3/vmxnet3_drv.c @@ -686,9 +686,7 @@ vmxnet3_append_frag(struct sk_buff *skb, struct Vmxnet3_RxCompDesc *rcd, BUG_ON(skb_shinfo(skb)->nr_frags >= MAX_SKB_FRAGS); - __skb_frag_set_page(frag, rbi->page); - skb_frag_off_set(frag, 0); - skb_frag_size_set(frag, rcd->len); + skb_frag_fill_page_desc(frag, rbi->page, 0, rcd->len); skb->data_len += rcd->len; skb->truesize += PAGE_SIZE; skb_shinfo(skb)->nr_frags++; diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index c1501f41e2d8..3d79b35eb577 100644 --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -1128,9 +1128,7 @@ static int xenvif_handle_frag_list(struct xenvif_queue *queue, struct sk_buff *s BUG(); offset += len; - __skb_frag_set_page(&frags[i], page); - skb_frag_off_set(&frags[i], 0); - skb_frag_size_set(&frags[i], len); + skb_frag_fill_page_desc(&frags[i], page, 0, len); } /* Release all the original (foreign) frags. */ diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 738776ab8838..0d1027ea81e0 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -2411,6 +2411,15 @@ static inline unsigned int skb_pagelen(const struct sk_buff *skb) return skb_headlen(skb) + __skb_pagelen(skb); } +static inline void skb_frag_fill_page_desc(skb_frag_t *frag, + struct page *page, + int off, int size) +{ + frag->bv_page = page; + frag->bv_offset = off; + skb_frag_size_set(frag, size); +} + static inline void __skb_fill_page_desc_noacc(struct skb_shared_info *shinfo, int i, struct page *page, int off, int size) @@ -2422,9 +2431,7 @@ static inline void __skb_fill_page_desc_noacc(struct skb_shared_info *shinfo, * that not all callers have unique ownership of the page but rely * on page_is_pfmemalloc doing the right thing(tm). */ - frag->bv_page = page; - frag->bv_offset = off; - skb_frag_size_set(frag, size); + skb_frag_fill_page_desc(frag, page, off, size); } /** @@ -3496,20 +3503,6 @@ static inline void __skb_frag_set_page(skb_frag_t *frag, struct page *page) frag->bv_page = page; } -/** - * skb_frag_set_page - sets the page contained in a paged fragment of an skb - * @skb: the buffer - * @f: the fragment offset - * @page: the page to set - * - * Sets the @f'th fragment of @skb to contain @page. - */ -static inline void skb_frag_set_page(struct sk_buff *skb, int f, - struct page *page) -{ - __skb_frag_set_page(&skb_shinfo(skb)->frags[f], page); -} - bool skb_page_frag_refill(unsigned int sz, struct page_frag *pfrag, gfp_t prio); /** diff --git a/net/bpf/test_run.c b/net/bpf/test_run.c index e79e3a415ca9..98143b86a9dd 100644 --- a/net/bpf/test_run.c +++ b/net/bpf/test_run.c @@ -1415,11 +1415,10 @@ int bpf_prog_test_run_xdp(struct bpf_prog *prog, const union bpf_attr *kattr, } frag = &sinfo->frags[sinfo->nr_frags++]; - __skb_frag_set_page(frag, page); data_len = min_t(u32, kattr->test.data_size_in - size, PAGE_SIZE); - skb_frag_size_set(frag, data_len); + skb_frag_fill_page_desc(frag, page, 0, data_len); if (copy_from_user(page_address(page), data_in + size, data_len)) { diff --git a/net/core/gro.c b/net/core/gro.c index 2d84165cb4f1..6783a47a6136 100644 --- a/net/core/gro.c +++ b/net/core/gro.c @@ -239,9 +239,7 @@ int skb_gro_receive(struct sk_buff *p, struct sk_buff *skb) pinfo->nr_frags = nr_frags + 1 + skbinfo->nr_frags; - __skb_frag_set_page(frag, page); - skb_frag_off_set(frag, first_offset); - skb_frag_size_set(frag, first_size); + skb_frag_fill_page_desc(frag, page, first_offset, first_size); memcpy(frag + 1, skbinfo->frags, sizeof(*frag) * skbinfo->nr_frags); /* We dont need to clear skbinfo->nr_frags here */ diff --git a/net/core/pktgen.c b/net/core/pktgen.c index 760238196db1..f56b8d697014 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -2785,14 +2785,17 @@ static void pktgen_finalize_skb(struct pktgen_dev *pkt_dev, struct sk_buff *skb, break; } get_page(pkt_dev->page); - skb_frag_set_page(skb, i, pkt_dev->page); - skb_frag_off_set(&skb_shinfo(skb)->frags[i], 0); + /*last fragment, fill rest of data*/ if (i == (frags - 1)) - skb_frag_size_set(&skb_shinfo(skb)->frags[i], - (datalen < PAGE_SIZE ? datalen : PAGE_SIZE)); + skb_frag_fill_page_desc(&skb_shinfo(skb)->frags[i], + pkt_dev->page, 0, + (datalen < PAGE_SIZE ? + datalen : PAGE_SIZE)); else - skb_frag_size_set(&skb_shinfo(skb)->frags[i], frag_len); + skb_frag_fill_page_desc(&skb_shinfo(skb)->frags[i], + pkt_dev->page, 0, frag_len); + datalen -= skb_frag_size(&skb_shinfo(skb)->frags[i]); skb->len += skb_frag_size(&skb_shinfo(skb)->frags[i]); skb->data_len += skb_frag_size(&skb_shinfo(skb)->frags[i]); diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 2112146092bf..06a94cb50945 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -4241,10 +4241,9 @@ static inline skb_frag_t skb_head_frag_to_page_desc(struct sk_buff *frag_skb) struct page *page; page = virt_to_head_page(frag_skb->head); - __skb_frag_set_page(&head_frag, page); - skb_frag_off_set(&head_frag, frag_skb->data - - (unsigned char *)page_address(page)); - skb_frag_size_set(&head_frag, skb_headlen(frag_skb)); + skb_frag_fill_page_desc(&head_frag, page, frag_skb->data - + (unsigned char *)page_address(page), + skb_headlen(frag_skb)); return head_frag; } diff --git a/net/tls/tls_device.c b/net/tls/tls_device.c index a7cc4f9faac2..daeff54bdbfa 100644 --- a/net/tls/tls_device.c +++ b/net/tls/tls_device.c @@ -268,9 +268,8 @@ static void tls_append_frag(struct tls_record_info *record, skb_frag_size_add(frag, size); } else { ++frag; - __skb_frag_set_page(frag, pfrag->page); - skb_frag_off_set(frag, pfrag->offset); - skb_frag_size_set(frag, size); + skb_frag_fill_page_desc(frag, pfrag->page, pfrag->offset, + size); ++record->num_frags; get_page(pfrag->page); } @@ -357,9 +356,8 @@ static int tls_create_new_record(struct tls_offload_context_tx *offload_ctx, return -ENOMEM; frag = &record->frags[0]; - __skb_frag_set_page(frag, pfrag->page); - skb_frag_off_set(frag, pfrag->offset); - skb_frag_size_set(frag, prepend_size); + skb_frag_fill_page_desc(frag, pfrag->page, pfrag->offset, + prepend_size); get_page(pfrag->page); pfrag->offset += prepend_size; diff --git a/net/xfrm/xfrm_ipcomp.c b/net/xfrm/xfrm_ipcomp.c index 80143360bf09..9c0fa0e1786a 100644 --- a/net/xfrm/xfrm_ipcomp.c +++ b/net/xfrm/xfrm_ipcomp.c @@ -74,14 +74,11 @@ static int ipcomp_decompress(struct xfrm_state *x, struct sk_buff *skb) if (!page) return -ENOMEM; - __skb_frag_set_page(frag, page); - len = PAGE_SIZE; if (dlen < len) len = dlen; - skb_frag_off_set(frag, 0); - skb_frag_size_set(frag, len); + skb_frag_fill_page_desc(frag, page, 0, len); memcpy(skb_frag_address(frag), scratch, len); skb->truesize += len; -- 2.33.0 From xen-devel-bounces@lists.xenproject.org Mon May 08 12:42:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 12:42:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531523.827266 (Exim 4.92) (envelope-from ) id 1pw0CV-0007LJ-CJ; Mon, 08 May 2023 12:42:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531523.827266; Mon, 08 May 2023 12:42:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw0CV-0007KO-7N; Mon, 08 May 2023 12:42:47 +0000 Received: by outflank-mailman (input) for mailman id 531523; Mon, 08 May 2023 12:41:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw0Ax-00077H-NL for xen-devel@lists.xenproject.org; Mon, 08 May 2023 12:41:11 +0000 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 98a72755-ed9d-11ed-8611-37d641c3527e; Mon, 08 May 2023 14:41:08 +0200 (CEST) Received: from dggpemm500005.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4QFLSw0tyHzsRLP; Mon, 8 May 2023 20:39:12 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by dggpemm500005.china.huawei.com (7.185.36.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 8 May 2023 20:41:02 +0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 98a72755-ed9d-11ed-8611-37d641c3527e From: Yunsheng Lin To: CC: , , , , , , , , , , , Subject: [PATCH RFC 0/2] introduce skb_frag_fill_page_desc() Date: Mon, 8 May 2023 20:39:20 +0800 Message-ID: <20230508123922.39284-1-linyunsheng@huawei.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500005.china.huawei.com (7.185.36.74) X-CFilter-Loop: Reflected Most users use __skb_frag_set_page()/skb_frag_off_set()/ skb_frag_size_set() to fill the page desc for a skb frag. It does not make much sense to calling __skb_frag_set_page() without calling skb_frag_off_set(), as the offset may depend on whether the page is head page or tail page, so add skb_frag_fill_page_desc() to fill the page desc for a skb frag. In the future, we can make sure the page in the frag is head page of compound page or a base page, if not, we may warn about that and convert the tail page to head page and update the offset accordingly, if we see a warning about that, we also fix the caller to fill the head page in the frag. when the fixing is done, we may remove the warning and converting. In this way, we can remove the compound_head() or use page_ref_*() like the below case: https://elixir.bootlin.com/linux/latest/source/net/core/page_pool.c#L881 https://elixir.bootlin.com/linux/latest/source/include/linux/skbuff.h#L3383 It may also convert stack to use the folio easier. Yunsheng Lin (2): net: introduce and use skb_frag_fill_page_desc() net: remove __skb_frag_set_page() .../net/ethernet/aquantia/atlantic/aq_ring.c | 6 +-- drivers/net/ethernet/broadcom/bnx2.c | 1 - drivers/net/ethernet/broadcom/bnxt/bnxt.c | 6 +-- drivers/net/ethernet/chelsio/cxgb3/sge.c | 5 +-- drivers/net/ethernet/emulex/benet/be_main.c | 30 +++++++------- drivers/net/ethernet/freescale/enetc/enetc.c | 5 +-- .../net/ethernet/fungible/funeth/funeth_rx.c | 5 +-- drivers/net/ethernet/marvell/mvneta.c | 5 +-- .../net/ethernet/mellanox/mlx5/core/en_rx.c | 4 +- drivers/net/ethernet/sun/cassini.c | 8 +--- drivers/net/virtio_net.c | 4 +- drivers/net/vmxnet3/vmxnet3_drv.c | 4 +- drivers/net/xen-netback/netback.c | 4 +- include/linux/skbuff.h | 39 +++++-------------- net/bpf/test_run.c | 3 +- net/core/gro.c | 4 +- net/core/pktgen.c | 13 ++++--- net/core/skbuff.c | 7 ++-- net/tls/tls_device.c | 10 ++--- net/xfrm/xfrm_ipcomp.c | 5 +-- 20 files changed, 62 insertions(+), 106 deletions(-) -- 2.33.0 From xen-devel-bounces@lists.xenproject.org Mon May 08 12:57:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 12:57:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531540.827285 (Exim 4.92) (envelope-from ) id 1pw0Qj-0001WF-MA; Mon, 08 May 2023 12:57:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531540.827285; Mon, 08 May 2023 12:57:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw0Qj-0001W8-JO; Mon, 08 May 2023 12:57:29 +0000 Received: by outflank-mailman (input) for mailman id 531540; Mon, 08 May 2023 12:57:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw0Qi-0001W0-16 for xen-devel@lists.xenproject.org; Mon, 08 May 2023 12:57:28 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0605.outbound.protection.outlook.com [2a01:111:f400:fe0c::605]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e0f2bc2f-ed9f-11ed-8611-37d641c3527e; Mon, 08 May 2023 14:57:25 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8674.eurprd04.prod.outlook.com (2603:10a6:20b:429::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Mon, 8 May 2023 12:57:23 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c%4]) with mapi id 15.20.6363.031; Mon, 8 May 2023 12:57:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e0f2bc2f-ed9f-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PoHMv6woAZ5h7Z6SDA9NvQP/DYc1BEofPVeZgcdZHlvQTCRCYTQS+j4H8TXufbkJdZl8Oebmfjh4w5jTV+AMO+uR3lWl8qD49P1j8GPOfl1hXgGO1E44q/S+9vCmlriDaNXXkhYMwBR9LxlQObqng2++toPoi72+p6h7B0nihdw2ZpQ7EqF9NAxUpWy1adVc5iN4w4f8jL97xBoG+BnE1bLhc0dkX3PMUzGURoCT3HdwAOy4EkhO3ohxtGJKW8vTMTCB5bGTjpEYsftrxu3AuPsngrNn0dlyAMeeUrGGQgD/n4vlwlwMpySqJuDShGDQsWhPuJ/1Hp/gQTMe+h7IBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oZd97VnJuH85htric0UZmxZ08snwYPDQyqs2n1VbUkU=; b=PYs2CFXbojMmjlHo3W2lQACey/mjp27KcUpbufkv90Lu3brNnWbL8gJ9aiJd14tDsLYnqnbUmqMEQv6ZzQTHBpTQvAPsbWkKylvIN4r+H3c+8c4tULsaxlBkfJz2YXr3kauCX9aOw0ti40qh7Pd0wsLROM4jvtEJz5Su7jJfmlYMuJdCdqVkfJN0/WPa2W/IRZBKPNDBYU3JmZBi6ubniUS4oY0YmdpkMBP58abz3M1hz+KPwZVXaXq34m/HfyLIeg8MMa2LDxDT81wcDOp3kpb1wzTzr5I/zh89pcg2kMpjgdxzSmtTYACo4psoB557bCZUkiazCBIcnYCW3osibQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oZd97VnJuH85htric0UZmxZ08snwYPDQyqs2n1VbUkU=; b=5TsnUWAb2BTfL9BlFENtWRf2qPZNZkkhC0AmkTk5+oRlcB6jaflcRfP8P7hwKMRj23/kz7X+aNX6NM6+MIABCa/Bze6Dxm/vthS/zBoT6PX6nH0XXfClbecz+rE12eLvy5xq9PMwnLfuZWtLN4S/C4HHJ7okt+jWzerjlLIqn5b+KBq5esT7CQv0tUyf2WKaVpqp9pOreliQRlt04/l6j1VodE5OZ46Pyfl3GLhSvThqR0s50gd3cPcYKrixnPH/D8OPk6C3KBVduDvjDun42NaydFB2r+5dRawLhP9Tb0Qt+soPIPw+uuJHHB+UZE+5GNVJo/0p+fdf80Vru/MdYg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 8 May 2023 14:57:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Bobby Eshleman , Alistair Francis , Connor Davis From: Jan Beulich Subject: [PATCH v2 0/2] build: improve macro references Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0002.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8674:EE_ X-MS-Office365-Filtering-Correlation-Id: 8ebec046-321a-464a-cc9e-08db4fc3c414 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0/hwL6mqy69Eqp4vzxXT8WdzFnMRlFKGs+jJQUwjpSYWQu85jZUbGOw1GrMp9VfKEJbGBSnSM0OumwE2vbJwgKRNlP7QaVncUvtYEpr9tNzrof4RJaJN47/ekMb5KNde6LtMz0cqB0q8FowWhmc7qVSF8xq45pAxjXvHpCZICkwF+NXL/sJCuJ7FQYOeDYCECNpzBmv3D8KJUJR39W54o9kP7pK/Yi9QsxBs/ifeMZcBNTaxyh8ja1LE2ViTGU0RlTe0X1JUC7exjHm+BNuP1SpN1sg9Eyr6lHXyuCuIAg+t6VUzIUM125GrDF04vhUV8CAaIU/AuQ/rDyDdOXgfh2QyvQKrYbwMDlF1ZCn0p3zbuVOQ34L8LyAv6QTm+PgOxzTTmUBEdY4jgi5XxuslQgj6p+kx3QoQMHEdYPvNsTnH+ryL5mmL1dkMNWOOT5SOPkw4mS1e6iuxEqQvvb2sLYuxdUP2Hw9YpbZQi9KQPuopbNFlNut+zXgpdU/VGoOf7WpDebX1YI1dKFwxC7/CHfzwOhdE5x/c67ibIZpegHcF9hzg6htGim3AzpUoIWWhHxV8lTRemEfqgzHIbczP2Qp7Ayqp9p4NGIveh5aLPLbbT6mncTb8mfo5IHRHccvWIFnZGsHfOjyEOvj9vyTWuQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(376002)(346002)(396003)(366004)(39860400002)(451199021)(31686004)(54906003)(2906002)(8936002)(8676002)(316002)(478600001)(6916009)(4326008)(66476007)(5660300002)(66556008)(41300700001)(7416002)(66946007)(6486002)(6512007)(26005)(6506007)(186003)(36756003)(2616005)(558084003)(38100700002)(86362001)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UUgyVXFOWnlkVHplb1huVE5vREpPdnhqY2wvcGtLMm9tQVhTdEFYTFpWa1Js?= =?utf-8?B?bkkzSVArQ085Mko3MjFSMDJBVHZWY1FwOXFZZVJlOGlmeFpoNzRXRzdJYzd3?= =?utf-8?B?cVlESW9BNFo0andNemZPVHI0eXVZcmNtb08zK01HMERoeEd3ZEdOallpbWpJ?= =?utf-8?B?dVNMbzdURy9lQlM5RFd5L2x5RlJZRUNUT3hReTVVcFlPUVVHT1krYytmY1Fa?= =?utf-8?B?UWZkZkxRZzVva2x1c0FTQ1oreW5ybEV3Y25ucnloZlZZcUtjb3BZZ1VFZmV4?= =?utf-8?B?Z1N5aVZwZldoaE5kV2UzZVdwQ3o2eTlzKzIxZFdzVTFyM3hORFM4cVlEemhO?= =?utf-8?B?d2krbVdZbzh4NVlJeXJxUzk2T1RleTFEZTQ2eEI2Q1JNYnBaVW1HM2srVWJZ?= =?utf-8?B?MzZwa3lWWWlad1FSN1NFWGp5VW1jUmdHSlRzdm9NV0F4aHUralhmNGZMdHNx?= =?utf-8?B?N3RiZlpDTVQ3dGRsU0dpZ3hWMWo5d3NtQ1NoUThnd3JGUTVPZmpIRzlhT3Ez?= =?utf-8?B?TnlXalBWWGVMZkFXTExOYU1wYmltUFpmYi9CMFRxN1cyaDZtVG1nZXdFY09S?= =?utf-8?B?c2dTckNkTk1CekhXOXBFMzB1ZmUrakFwNUNKb3NtVWpDdlpKd1E2WTc2UjZr?= =?utf-8?B?eHNvamd5L2N5aW5hWHd4bWJSUGJ3WEVBQjlqdHdaeHBrYmpsLzB3NHMrbXFZ?= =?utf-8?B?Q05oaDZhYzczcXc1bnc3ZjBWc1Y3YUJybjNRbHRuZ085Q2pjR2tMUXdocFZr?= =?utf-8?B?SjFEWGw2VWdKRmgxSEl4TEdaQW9XZWlpYWNWSTdQbUxzdHQzWDRNeWwra1VF?= =?utf-8?B?Um5uQW1IK3N5akVjWnYxZU5IRmNGS2ZnUUI4UkhXYWFXQVIvcmhXVFgxc2di?= =?utf-8?B?RkNNUENBY0ZiL2JDYy95bnltcm04ME4xSTR4WjlhOHJZbEtsTTAzbkZSdGtX?= =?utf-8?B?VGduSUtTcFdFV2RGQXhWYnMyb0ZFWXlkenlmVEhlTkVkaHlxcXc4ZGJnbXVx?= =?utf-8?B?UkZzcDhReXVlMXZ6Ry9Mc0RodW9WVnhOcFBNN1g2alJJTmVhUDdNU3liZnJ0?= =?utf-8?B?SGV0bXRmc1lwc0pMb2dPZFdhakxrR2crRUEwRDFVWVM1dXNOSFlPeUlicDA0?= =?utf-8?B?bmNwVFdBdzdZbUMzK0F4L3RGbUN0bW8zUVRWQmJZVkRPbVlleVZkdWJpYzlB?= =?utf-8?B?Y2lTWWkwdWErV1ZZWTh3UVYzclltWnR1VUNVZU1MQ2ZSWUR3YWRqdW9QZG1C?= =?utf-8?B?ZUJwd0VBRGZCNEZRV3BKYTlqQitmcVlTZWRtU3YvWGJWYUFyVU04SWZJT1c4?= =?utf-8?B?RGlFZkVpZEtaSFJTa0tSN01Pa0pMbHBJcElkUHdYZTR6SWNQakkyODRZb1Fl?= =?utf-8?B?bWpHckRmNVA1eFZZMndlcjF4K3JYOEYzUWlKQ2s4NENyNjVTaExJREZyL05R?= =?utf-8?B?cklZUzNtZVc3d0dhNTQ3Smg3OHloWlNCc3V3L2prRXhwNlVGenFVUjJLTmdX?= =?utf-8?B?SnQrT2ZWU3Q0MVppbnZKTDBNc1dTOWFsZ0lIQjg4RW94Z1psMHdkRFI5cUtz?= =?utf-8?B?WFV0SjRocVp4Y3Z4bElmNmhHaklmNnJ6QXhjYU1QTERIbm1nU1VxRUI0bXZU?= =?utf-8?B?OGloeFhFNmdJeFBLUHZxTFBZKzFwTmx4QkU4dXRDQkk0eXNROXZ4d2pvT1dK?= =?utf-8?B?RlZ6dVJ2Z1hqT2g0ZndER2IyRHJSVmZ6eEd3NmhwOGdKdUljc0VXeDJvQm1B?= =?utf-8?B?ZEY4T1JNNitvcldiT1cyeGo1TVk4Z1YvRWlZZjNmem5CQ0RsUjBNemZrYXZv?= =?utf-8?B?WitSTUNtZU52NDc1ckhpalBRMWxML3ExQ3RYRVBCZ1FyL1pnUGZpUUpFR1NC?= =?utf-8?B?SnB0U3ZFZW9PQlB3c3g5c0lRK01hemo2blZRWEozeWpGN2F3NVdhSDZ4TDBt?= =?utf-8?B?cjBzV1JMSXowODQ1c0pXVDNwaFM4dTdWZitiYXJsNEVieXlRcCtZK3d0NzdV?= =?utf-8?B?SC9oVW9JUnJGTGh4M2pjOFJjWkRqL2lTQzlYNTZIejB5TlJqR2RXTndVc1Zj?= =?utf-8?B?RjlJbEpMZ0dqZUlrUXJNdEYvUkJDRTE5dHc5eVRFcEhvOTJpVlFYTU9USStP?= =?utf-8?Q?1rrWuVzHJshELcADOTFDjBjnM?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ebec046-321a-464a-cc9e-08db4fc3c414 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 12:57:23.2058 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bvejrorUrFcg2ywYVIHIlIDz9VfJWT78JklpUOYjdhHeXvchdGXOSSge86AqR7kGnT4Kec7EjqApsSC7rl43jA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8674 Re-posting patch 1 merely because of the still missing RISC-V ack, while the new patch 2 contextually depends on it. 1: shorten macro references 2: use $(dot-target) Jan From xen-devel-bounces@lists.xenproject.org Mon May 08 12:58:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 12:58:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531542.827294 (Exim 4.92) (envelope-from ) id 1pw0RR-000230-VU; Mon, 08 May 2023 12:58:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531542.827294; Mon, 08 May 2023 12:58:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw0RR-00022t-Sx; Mon, 08 May 2023 12:58:13 +0000 Received: by outflank-mailman (input) for mailman id 531542; Mon, 08 May 2023 12:58:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw0RQ-00022e-Oi for xen-devel@lists.xenproject.org; Mon, 08 May 2023 12:58:12 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on060f.outbound.protection.outlook.com [2a01:111:f400:fe0c::60f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fbe7fe27-ed9f-11ed-8611-37d641c3527e; Mon, 08 May 2023 14:58:10 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8674.eurprd04.prod.outlook.com (2603:10a6:20b:429::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Mon, 8 May 2023 12:58:08 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c%4]) with mapi id 15.20.6363.031; Mon, 8 May 2023 12:58:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fbe7fe27-ed9f-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AgoIzciQBZD2QD6lfkwZoZWIIe0fFDaUwyz7kDDe1GAeAyNXTGRk4sVONe/kzjP7WkLwmDY4Sguao5ZCNtUEAtiJr4xKoRjIilpGB1h1hy6B/0lqQthp72gdSyflS0MBykDFH12TGXrzN1yZHtkg3MRnW55d6aY5AWWJEcX7cZh8mSUtsu4xN4CieXr+lG9ZmYnE7qnmHwHcTTvpjxGUFEuqTjVIzbbbKeISs+oJHxu4qSDVPWZRoKxdTjjbVquxRIOXV042sU09RCynsrhtfokXQHHYYvQk293CFZWLsiYEBXWcLCbDuqm2v0xC/G4rimKmcpVrSj9kOzC2WFpAHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fglwV5hSyATtXnFfIAt/M+iOmywYI9rQMwaKbY12iBs=; b=li2L7Mrs3Zt3e0BJZw4puX2LA9M2pt9gpW0CgKMhKsAfF7h6mknONhKorQlhew/w3f3ZnKtbzbax5rJ7wZnWF6NeLzjbECb2F3rQqP2ecifU5RfwgOTULvUPptaEa6XRAsh/fN+M6/sWWT0zb84224kCkGHY2ayrGzAApQbRZH4eFFnKw5GLN+EYqsiLhmGBtgG0rhhDJ+dSUUVollBqb6hYse8BtG/iPH4jwNTjilY7LMd1sMUvLTTAjwg1yeWO3VtZ+Lt+RheVeo280TYp6jTmVmmhmwOqBM/fdVq3wgTe6eozLLQ7C1CbHPu43G6Ix56Tf7rxK3CQ58+bhieCjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fglwV5hSyATtXnFfIAt/M+iOmywYI9rQMwaKbY12iBs=; b=EqZCbrQu5RlTIcHiurZkKOwHqWTgRb07ab3GPerxUnbSDOb+OvtVWUuh960C8mYQasEfYSvC0+zdVMPGGHLFqzL/DBoM6pNwkmDbqnXbq+fb9pNPBR7kXF6XEFLNAIac86ZwnnOaxCZbptMPR6JTQ9lWNxy3ngV8sLWQUfyto4vl80OdLm5W78COojIlCdr0bLElPda3tGgpB3/QT4Oz2heKDbRkYxBCAi3oGNvzGPnErXxoZjNaQO9EV84O9Z0Cbwfne1tNKO+mm0wCgwEcRLSNYQRQpDgl8vvcGpjF9rbOuNADUQ7r4XUkrMd1PjJ2Q7AYl7OEGcxMqY8XvWdSTw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 8 May 2023 14:58:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: [PATCH v2 1/2] build: shorten macro references Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Bobby Eshleman , Alistair Francis , Connor Davis References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0004.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8674:EE_ X-MS-Office365-Filtering-Correlation-Id: 86563cf3-bae1-4a0b-5659-08db4fc3df4d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pLKH/3zYOnjIB3eINaldLzjZfjqiwG91OAFqByml+dq3liBo73mCuo7gxHtI3SmqIsH6Fl2kgJjpVVv6enO26MBY4YarPiG4NV4lcwWJsKdtG3BPbSJUUruTnVC3Tb8J3ZP3FsY1b72iywh90gB6sCqWRb7yv/QbcXw+vxzJCd/jp5pTTmlphtI2oVfRKXqSIpssJjfVFYXmOjux4iez0P907IiT9QauOK/EcKSVLM3VC47LwtOmjiawj4Q7VjULjl8u2A7AcP1TDVmmPu7KzyQoiGDfZjTGElsgzkN1rBjMan/lebzxTDmhtew7x1URCLSz7389KCsOgXJ8btRT25ODT2+t+6rHeK3YLmH56b0rVx4GBDx1PYzm8Xi1vRUcoMGguSF/n0obzUyrzoonoZUFk7Yi4AeFGA1vSZqRPjqbTpnYls9GeOHgISXFM027oJYVRtcLn8uGX2yw3kJec5CjdIT5tPNSPraxEy9XcwvlESCbWrv/qSoG7aVaiLgKB/1451KW1TM72frM4XdcmrZSu7Tm1U2XmaHo6ziHgnawPOCuZIOqYMZq6Z3+ae7AUElqVupcLt9SU8zD2JzKAyjM//MhMKiCwaMB9USjOMJHA5FkYilOizrNxtms1s0gZI2Iu+doYT6UTAs08uKEDQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(376002)(346002)(396003)(366004)(39860400002)(451199021)(31686004)(54906003)(2906002)(8936002)(8676002)(316002)(478600001)(6916009)(4326008)(66476007)(5660300002)(66556008)(41300700001)(7416002)(66946007)(6486002)(6512007)(26005)(6506007)(186003)(36756003)(2616005)(38100700002)(86362001)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b1E4R0xnLzl4WWpqa2VHdmlYVUxSdCtWR2Y3cjY3T2d0ODE5eUZiajNkSHFW?= =?utf-8?B?d2xYWWNDMVMwK1dPUHkrQWR0VVg3VFRxVXF2VWZtWnlEd2hhVTNYODk5eXF6?= =?utf-8?B?azY1ZVJiSG43bHZaa3hxWWYvdnEzalF4OGwyQnZuWkNDdkpha3U0UDljb0VK?= =?utf-8?B?Q0lHOGF0TW92cmhscFRkYWlMZTF5UWsxQjA3TjVvclBhd1dCeElYeFhvVWxT?= =?utf-8?B?c0RhTG5pY1NabFNyWXdhVW1VSFRsRnpFbG9QbzBnL3d5VEVTT3V5Rzl4UmJz?= =?utf-8?B?YXg4SnVlNU5JT0FZQkpMeUFsRC9iY25MMWVyZFJ2MWZudnp3dk16eUYvSWhF?= =?utf-8?B?dUo5YUphc09lMjc1NE5Kai9PKzdISkhvTlhLM1BBRzlXNkFzK2YxNTliZDU0?= =?utf-8?B?YmNJTno1YUl1YmJIM3FWQzh6eUNMMURwekY2ZEV6c24wNlNlNUR1Ti8zckNB?= =?utf-8?B?OGVPUEplU3JodXJaZ01xN1BnNzVLdFhia0lxbEFYWnk2Y3VnaEpNMGs1OXJ1?= =?utf-8?B?SzhVSm14K0V2WVphaVpmOU9LK2VoYlp5aUtjR1BKYm10SEtKZW9TeVNrYThy?= =?utf-8?B?MzJPSWNYMElodjc4OXFaWk9qRS9Ncmx2ZjJMQlZmWXdnTStjMVdmLzA2MlFQ?= =?utf-8?B?NGZtVkNMalJkN3lodjRGVlUvQ1dNdU52TVFQZVNVYXFsQ0dqNU54YmZ0ZGhO?= =?utf-8?B?L2xnUGt3WTlXcWpPL3NIZHJpKytxQklLcGpGU0Z3dXE1Vm8yUktLVGhtV2c4?= =?utf-8?B?TWhzenNMUWNScGlBMk05bVlMOTVacGhIZmFJelBDem0zUVZibDVhUC9iVCtQ?= =?utf-8?B?cWlWRXN2SC9vdkl5Z0hjbmw5cGZ1UnZXQWh6U01HNkRQSWxWVDdtWEZDWlB0?= =?utf-8?B?Wmw2SkxyTlBvdXp2TVJiSDFCSjk1ZWJWSms1ZFY0Zm1NVFVRVWpqZ1BqNVlQ?= =?utf-8?B?WjduZmYzT1VPZlgwVHFIUEVNWDBTVTZYeXg4RmFVUEVpNWI1WTAzcXp3ZGI4?= =?utf-8?B?bThZNlpKUHU3eDIyd29HSWN0bnczdjRPVnJqYWZzUUs2Y0RsMFVRaDJNelRN?= =?utf-8?B?SGN5NlY2UTY5R0xva1hTcXZlQWZOY2FGaHBQdlUxTy95enJsb2paRnM1QUlo?= =?utf-8?B?REF5Uy9Ic0l2djZUWXlrYjR5TUg3MGRoSUlCMlkxNTBTU2lUU2ZOUm1OemRo?= =?utf-8?B?Rk9GZHNqQXZZWVZBNCt0NVFjTDR0OVp5bGQzQ1d3MFlBQmIxTWFZcmdmQmlG?= =?utf-8?B?VUFMZ0NsS3V1SUYyVnFacUR5c3BQY2JjMjZRaDFiTVAvbkY2TjdiZnNjSW50?= =?utf-8?B?Q2lMaGJXbHlWbStJbmt2MFBjdzVCU0VnTVF4ZnVuZEV6enJ2YnZsR1c0RTk2?= =?utf-8?B?aG9hRklBQm1GTUN6QlRxZ1VoQjY0V2pDa2txbDJZM2k2NHdieFIzWkJtbkNn?= =?utf-8?B?eHlmczArWHJxY3JUVWREanBJdWo1cTdHVUtaOUQ1V2kyOXZBNDFUUngyWCto?= =?utf-8?B?Qk9jdlMwMWs1OWJmZzlieHpWMUJkaENMdUI3eFk4NmFpcUkxUlI3eWYvNm9p?= =?utf-8?B?Sjk5VjNFUUp2TTFmaW52b3lHNzdXRnVnVzQ3anBVQkp4eU05anpMZkhGOVpl?= =?utf-8?B?Y01BbHRCWVJnajhibXJ5clJ0MWZaQ2p6NXhUeWpBTENlNXR6YkowckNDZm9Q?= =?utf-8?B?emk3T3RUWFh1Nm85RVdNc1VIenQwSWZIekxxN1hROVNUK0l3Mm11T0pWSHU1?= =?utf-8?B?b1ZMWXZkNWgwTFpjVGcrb1dDbzJrb3IvdHozUHRpbWlvdi9vM3duWGJnRVNt?= =?utf-8?B?TlFNQWZFb0VzQVFSMFk2YkY1VGpDTkNKeGVJYXp1Z3lxTUV1SXJIQkNyb1M1?= =?utf-8?B?VDMyK3A0R3g4aFdBdVJpcDFNV2dSNXAxQlBqV3RaOTVIOGxYbE0xS1dTWm52?= =?utf-8?B?SXVjUms5UDRtYlBnRmdpRzlRRU4reDgzbzI4c1VpUEUzSW0xLzBqWUVON1g0?= =?utf-8?B?ZEtLOHArM29wNkg4UUtvVjZjejQwa2d2RHhOeFh2V2xvTkdYOTZtRmVoY1Ix?= =?utf-8?B?TGlZMFNFK3g3dndra2o3bkhHaFJha2tFU2t3Y3E4OWRTTUwxcnpyaEhyNG1L?= =?utf-8?Q?gl4+ccmfAI3kuKRlfmGmEttP0?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 86563cf3-bae1-4a0b-5659-08db4fc3df4d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 12:58:08.7816 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IhxlAmTa2/E1NFyj36HhP3C8r8ha9giQVFN8vzFiQnVubcU5cHl9NCVKrtBElBYaE+RGoR9iyBiReCZXRaZGAw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8674 Presumably by copy-and-paste we've accumulated a number of instances of $(@D)/$(@F), which really is nothing else than $@. The split form only needs using when we want to e.g. insert a leading . at the beginning of the file name portion of the full name. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper Reviewed-by: Bertrand Marquis --- v2: Insert blanks after ">". --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -104,9 +104,9 @@ $(TARGET)-syms: $(objtree)/prelink.o $(o $(MAKE) $(build)=$(@D) $(@D)/.$(@F).1.o $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ $(@D)/.$(@F).1.o -o $@ - $(NM) -pa --format=sysv $(@D)/$(@F) \ + $(NM) -pa --format=sysv $@ \ | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ - >$(@D)/$(@F).map + > $@.map rm -f $(@D)/.$(@F).[0-9]* .PHONY: include --- a/xen/arch/riscv/Makefile +++ b/xen/arch/riscv/Makefile @@ -10,9 +10,9 @@ $(TARGET): $(TARGET)-syms $(TARGET)-syms: $(objtree)/prelink.o $(obj)/xen.lds $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) -o $@ - $(NM) -pa --format=sysv $(@D)/$(@F) \ + $(NM) -pa --format=sysv $@ \ | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ - >$(@D)/$(@F).map + > $@.map $(obj)/xen.lds: $(src)/xen.lds.S FORCE $(call if_changed_dep,cpp_lds_S) --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -150,9 +150,9 @@ $(TARGET)-syms: $(objtree)/prelink.o $(o $(MAKE) $(build)=$(@D) $(@D)/.$(@F).1.o $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ $(orphan-handling-y) $(@D)/.$(@F).1.o -o $@ - $(NM) -pa --format=sysv $(@D)/$(@F) \ + $(NM) -pa --format=sysv $@ \ | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ - >$(@D)/$(@F).map + > $@.map rm -f $(@D)/.$(@F).[0-9]* $(@D)/..$(@F).[0-9]* ifeq ($(CONFIG_XEN_IBT),y) $(SHELL) $(srctree)/tools/check-endbr.sh $@ @@ -224,8 +224,9 @@ endif $(MAKE) $(build)=$(@D) .$(@F).1r.o .$(@F).1s.o $(LD) $(call EFI_LDFLAGS,$(VIRT_BASE)) -T $(obj)/efi.lds -N $< \ $(@D)/.$(@F).1r.o $(@D)/.$(@F).1s.o $(orphan-handling-y) $(note_file_option) -o $@ - $(NM) -pa --format=sysv $(@D)/$(@F) \ - | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort >$(@D)/$(@F).map + $(NM) -pa --format=sysv $@ \ + | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ + > $@.map ifeq ($(CONFIG_DEBUG_INFO),y) $(if $(filter --strip-debug,$(EFI_LDFLAGS)),:$(space))$(OBJCOPY) -O elf64-x86-64 $@ $@.elf endif From xen-devel-bounces@lists.xenproject.org Mon May 08 12:59:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 12:59:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531547.827305 (Exim 4.92) (envelope-from ) id 1pw0S6-0002aa-BY; Mon, 08 May 2023 12:58:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531547.827305; Mon, 08 May 2023 12:58:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw0S6-0002aT-6v; Mon, 08 May 2023 12:58:54 +0000 Received: by outflank-mailman (input) for mailman id 531547; Mon, 08 May 2023 12:58:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw0S5-0002aJ-4r for xen-devel@lists.xenproject.org; Mon, 08 May 2023 12:58:53 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0622.outbound.protection.outlook.com [2a01:111:f400:fe0c::622]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1437805a-eda0-11ed-8611-37d641c3527e; Mon, 08 May 2023 14:58:51 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8674.eurprd04.prod.outlook.com (2603:10a6:20b:429::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Mon, 8 May 2023 12:58:49 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c%4]) with mapi id 15.20.6363.031; Mon, 8 May 2023 12:58:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1437805a-eda0-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lqWCsZ3wiHEq++gmGNGyHg3Vhmx0W7jmgW0yyPO2i7+uf/UQT2O4dQo4YpsDZ5hVNpexIYKY780zIAsjXcr9qRO2F6Z4XCcRHLWbcuwAjPwfm2KPp8RdaPKAsIxWn4oEtR7K1qRgXqEfYxaAoAo463xk8N2+2QEUg1eQ8REoRnO2uMV0sOzUdl6StiBy1mGtHPnvpw9+UmHaNOVWV//Vthj4I15tng3G5/SE7zuYEYVOk9cVYRGdTF9CqahG9cIuX/2BjRBnhcX3njR4RyvYo8IRKbrlfFo+OBq5qktAFtrh6yXeNOnxrZgwo36tI8u38yo6kfev/5ok8XD4CiU7Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bHHkwJRRJgd96xEOMAOZhq2iePtG+6G1NYpCQL/zg1U=; b=kIpnEUTTqWCEgkJZWBta46WAgUEk2hAXj78hfhnn/Rs0fCeLY5kyiIfEwqNx0FQcaEudWIGI6b26Y9Nef/y8KZ47rKIL23kFa+mDY6ypTXU4m84bVrSzXNPJcihmFwSdasDL0YdP3Krw5VribuoyfChU/+7G/X0Yz0pUarWt3ny/lI69MSDBtPWJ9yMruo3+VSDzKj59grs97voQeEM9qV2IuKNh0ADHcmwKV55+XHJqcm8UY2gcKt+jVfdKT6p2ZAcBU4Y2iKqL13qmFGbMl3Xu53gqTKlh8a9WYiM5B5zSOMyU69IPVcYiB2BqVttoUptpld1d88qz3Xpk8V9dlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bHHkwJRRJgd96xEOMAOZhq2iePtG+6G1NYpCQL/zg1U=; b=5zgk+P+vClAQrjKkL+zGFmZMjg+N0Y87gBYJ4nEBNLPKD/W/m3F7t683lncQVOw/z5h7rcJLACtUe6WkXQeQvEt9utJ8DHBCncQx6jBSYrrxMaiCSOL8xKi4JkfCVEEfu9zY+NYDtX52YMUDw0Gp3ei3tHjj2lXOTe0XObNSTdAb4V+Pvpj5+AIHONHSxWPkjsL/3nOHzskr0S2+EvorLpfJpKKlW1iynUSQTqFT/ReFc4sKqOpj+cTeLgd0I/BGSoj1Kdqb1a4H8F/MJfOxHzwHexXBY8uMr0/aBk1a/JpAJ6Gt3BU8hixmSr1OET1WdyDgKqX0EONnwRsseueJIA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9bc7544b-659f-4c09-f54d-647641483605@suse.com> Date: Mon, 8 May 2023 14:58:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: [PATCH v2 2/2] build: use $(dot-target) Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0179.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8674:EE_ X-MS-Office365-Filtering-Correlation-Id: cb520c61-304b-4e10-e692-08db4fc3f796 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +qcLVVbR2tPQvT/Hwjz1Tf79eKVRjPm75hAUbw2M9KbIVeViFSRSuL2kj3xsGGAesHdxJurjZd/rItXUqgB2FBrxy6/LcaY4unMxwEjVqCAaGDa+2L5UXOOZGkyoBfFVlHcEHl1WauJLBA9ZTXYsQUMRGBrmcQqA73j2nlc2RZSfuhlJ8o4dkCm64Hadv2MQdvGZ65dUEl5QaRIPSfBVhyKYJVE4IvqY8GOSqgHOxn/HFFUHsRa/lunvp1kh8BSWkN25O0XOpSReZMdlXua0LaMELicgYjnHPosDj/UEghmk0eEWuUB9ARH4N+Vs121KRgrsbNzdIQFdv2u1dGq9mbC23K43b/yFdtz+ewmjQiLsHwIMVB1cqfoFpIUYYz46LKZuB7R11RvtNmodIsHgQm/0fG7AdwUv4Ee/DHcuDJAPyEV27wgvz9EZkrOmPPvTwnQ2mWMygw38TyQJGxmK+TW/8ZIvM9UMv4V+g+YBQyF40b4KkI5NRObQmAsGt5lBryy4Vxoy4zRoYYcVF8GRBwd+W9vVtvZMGbN0NBtJUz4ytyGV8NTAFFpWpjHiz2vYDrxhNwuXO+Ufmzdo3uDkqW/h0llGFzkTUhoO2m+11btDg/NEX75sWpiAuTzJic0IUAr9Gy5d3lP6KWUPdjQ1oQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(376002)(346002)(396003)(366004)(39860400002)(451199021)(31686004)(54906003)(2906002)(8936002)(8676002)(316002)(478600001)(6916009)(4326008)(66476007)(5660300002)(66556008)(41300700001)(66946007)(6486002)(6512007)(26005)(6506007)(186003)(36756003)(2616005)(38100700002)(86362001)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VjQvOUVCWVNpVmZrVHFobDlFNHlpMmJBYUgyL20vRUxvUTlIUmRjTC92MDkv?= =?utf-8?B?OGM4Z3JiV1BQT09PLzhTcFBMSXdxbkw1SUFSTWx3RHJyZGtXTHg0OGsydGJj?= =?utf-8?B?WjlqMkF5SlhJaHk4THRCb3NvcVpSWXpzMjJmc3NRLzZrTHk3dnhKMmlYUjQv?= =?utf-8?B?YXpNZm9Wd09HNnZ1T1BoeHRxWXVxWERvMlZjMjltNmxyTW1YZjBhWE5FV2Zw?= =?utf-8?B?SWI1M3VZTVQ1QUFvZUxXdlJEK1NtYUJyNVF1bElwSUxnd3AyNDVMdW1KQnlC?= =?utf-8?B?Rm4vZmdFRzNhUytGaDVhS1lDSWFWcWMrNzlRcVFvcUVmekFPaE9BcmdjdEZT?= =?utf-8?B?ZnN0eG5jKytCRlNHZkhQTGl2Q3NiSWMwcUlPMWxMd1Vra0s3RzVFQ2s0M1Z6?= =?utf-8?B?UzY5TmVzaEtBY0ViZkdOekkybGdmeFFCejRVSWxHU2RjaFRzc1hobWJGaloy?= =?utf-8?B?MXVYRzFObHE4ZDdNbGNMTUtyeW9RckF6dFFwWlhKenR3S1p5T1dQa0RTem5P?= =?utf-8?B?Unc3Zm4yOFlSN0Y5VjFGUjN5MkhFSXgzM0Y1T2V6c0doU0s1UExpbjZ2SGsv?= =?utf-8?B?b3hiSmZFV0xwV3NqSlBGR211Y1V3d1ZYYTVGdmdHMkRaOHJxSDQ5cHhWbkJr?= =?utf-8?B?M0ZlTVBaWFl2dzdDMmNjUTBmT3BvaEZFdEdxWUFuWEc5d2Q2cWp0dDQxclFN?= =?utf-8?B?RHg3UzN4bkQ2TGdBRGhjaVFsZlJnMGNzN0t1bmpZSzhROUYvZjlwelF0VXU4?= =?utf-8?B?cVVBaGNVdDI1MWY5VE1xYWF4Y3hDdnU5ZkZHdXMvMUxCVmh2b0grNk8zUHVm?= =?utf-8?B?SVd2ekRYRkZhZmRaeFZQcEg0RTFtd1FQbXA0VUFGSzByaE1pSXJsa2VjVGJP?= =?utf-8?B?YVVQcHBqSEhCQ3JwMWVwT2NJS2FOTUlJbVNlT2dDRnpnS2wrcDJ6Zmk1WlZV?= =?utf-8?B?eUpwNG9OemFIK09NMHY1OTVqd1R4OE1HcUQyWHRlYkV1cUQwYmFGWG5EeEZM?= =?utf-8?B?ZlJDY2xpWUdaR0pqaGxkY05wcFU0K2R1RUhpdTkwa083TkhzenRoOHN4RXFX?= =?utf-8?B?aUF2Nk5VUlRqblNsSWRyVWhBZTllbi9LU0o5WVNjSmN4OVhsWUNObGNLRTRr?= =?utf-8?B?Qll5VkpybHFSVjFVNFlLRVl6TzNzai9VSWgra0dmVklmSlIwVVUyZkx5MDB6?= =?utf-8?B?Q3Y3NVo2d0h3dkIrVmpwYmY4cW1JV1lCU1R1bThOZ1paWjZDZ09GaGxGeHFp?= =?utf-8?B?STZlcHp0SVJEeU85V0VPVHFVMG1aTmRqTWdUQ2Y0OVB1VEswU1ZBZDBXQlhm?= =?utf-8?B?QVJTMXpxMGo2em5QWDZzeW8wSUNqNk5PYzFXMEFyMjlWOVBSYmMyWDJGdWlX?= =?utf-8?B?eW5CZ3RWdjJTcmpxdnF4UUtXUUsraXduNUR4ekZCV00wSk95SmYrcEFNbnhM?= =?utf-8?B?M1pFZmJUczhZS0RNakNpZlZ5U3RHR1BWaVo3RkdJbm5ITldTZW1qN2c4YkRH?= =?utf-8?B?MUdlS0d0T1JIdkc5cE5xTHBWMDhnT25oRzcxdXNUaUpmQ2lwR2ZTR1pocFJv?= =?utf-8?B?MUFETHBsSlh1NkVvVnp2eng5cjI4MW5pd2lKYTZzTVRsYmN2VmVxd081QU5I?= =?utf-8?B?TlFMTWpVR1JxT1FvZDhFaEtFWnNTUzRLaEdoYm9GdlFEMkpDamJOYkxBaE8z?= =?utf-8?B?OEwwR3NoakZaVDlMNk9QYWhRdWVGTFVDU2hhb1IrYW8yVDdVZUlFNEJ4akhY?= =?utf-8?B?N3ZJZEE3cWdKNkdWMklSS3NXR1UzS2srbHhHQllJVDR4SkU0U2MwNjZUWHE2?= =?utf-8?B?RmlKSjNwOGJiYVRVN1k1TnVmUUl5SkRiNXZOd1BUeGQyL0pPNTgrNjlpaEVl?= =?utf-8?B?NUhHdnpVOUpMaENJaCtYcldJK0JXR3BXNlRWWTF1dGVKTlJWd0VqN2NtTnFF?= =?utf-8?B?cFFTT3ZCaTA0Nk9mdU04MEk4MGgzaUxET2NxY0tVZE9BRFdVSE1nSVRrVTlG?= =?utf-8?B?TUFMUkxId1pCUm05ZXhDWUx1bTgxVHBxSmM1Qno3eVE1SStGM1dEOENLVmh0?= =?utf-8?B?bkU1RlFUdUY0S1pnbzhjV2ZWWENOOWxQMlkxSDh0emxXQW1ndENkaTAzSlFV?= =?utf-8?Q?5F+2T5miaiaDt/hVFXK6/oBnS?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb520c61-304b-4e10-e692-08db4fc3f796 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 12:58:49.5245 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Wjonmp//N/rTjPMR8ZsH+G6Ut/Uy+D2Kkb0m4ymSAXwbMdK1KYaEEHTFQquZG0OrYCOhle7zwkYwDD5nc0FLgw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8674 While slightly longer, I agree with Andrew that using it helps readability. Where touching them anyway, also wrap some overly long lines. Suggested-by: Andrew Cooper Signed-off-by: Jan Beulich --- v2: New. --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -93,17 +93,19 @@ endif $(TARGET)-syms: $(objtree)/prelink.o $(obj)/xen.lds $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< \ - $(objtree)/common/symbols-dummy.o -o $(@D)/.$(@F).0 - $(NM) -pa --format=sysv $(@D)/.$(@F).0 \ - | $(objtree)/tools/symbols $(all_symbols) --sysv --sort >$(@D)/.$(@F).0.S - $(MAKE) $(build)=$(@D) $(@D)/.$(@F).0.o + $(objtree)/common/symbols-dummy.o -o $(dot-target).0 + $(NM) -pa --format=sysv $(dot-target).0 \ + | $(objtree)/tools/symbols $(all_symbols) --sysv --sort \ + > $(dot-target).0.S + $(MAKE) $(build)=$(@D) $(dot-target).0.o $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< \ - $(@D)/.$(@F).0.o -o $(@D)/.$(@F).1 - $(NM) -pa --format=sysv $(@D)/.$(@F).1 \ - | $(objtree)/tools/symbols $(all_symbols) --sysv --sort >$(@D)/.$(@F).1.S - $(MAKE) $(build)=$(@D) $(@D)/.$(@F).1.o + $(dot-target).0.o -o $(dot-target).1 + $(NM) -pa --format=sysv $(dot-target).1 \ + | $(objtree)/tools/symbols $(all_symbols) --sysv --sort \ + > $(dot-target).1.S + $(MAKE) $(build)=$(@D) $(dot-target).1.o $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ - $(@D)/.$(@F).1.o -o $@ + $(dot-target).1.o -o $@ $(NM) -pa --format=sysv $@ \ | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ > $@.map --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -123,7 +123,7 @@ syms-warn-dup-$(CONFIG_ENFORCE_UNIQUE_SY orphan-handling-$(call ld-option,--orphan-handling=warn) += --orphan-handling=warn -$(TARGET): TMP = $(@D)/.$(@F).elf32 +$(TARGET): TMP = $(dot-target).elf32 $(TARGET): $(TARGET)-syms $(efi-y) $(obj)/boot/mkelf32 $(obj)/boot/mkelf32 $(notes_phdrs) $(TARGET)-syms $(TMP) $(XEN_IMG_OFFSET) \ `$(NM) $(TARGET)-syms | sed -ne 's/^\([^ ]*\) . __2M_rwdata_end$$/0x\1/p'` @@ -137,23 +137,23 @@ CFLAGS-$(XEN_BUILD_EFI) += -DXEN_BUILD_E $(TARGET)-syms: $(objtree)/prelink.o $(obj)/xen.lds $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ - $(objtree)/common/symbols-dummy.o -o $(@D)/.$(@F).0 - $(NM) -pa --format=sysv $(@D)/.$(@F).0 \ + $(objtree)/common/symbols-dummy.o -o $(dot-target).0 + $(NM) -pa --format=sysv $(dot-target).0 \ | $(objtree)/tools/symbols $(all_symbols) --sysv --sort \ - >$(@D)/.$(@F).0.S - $(MAKE) $(build)=$(@D) $(@D)/.$(@F).0.o + > $(dot-target).0.S + $(MAKE) $(build)=$(@D) $(dot-target).0.o $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ - $(@D)/.$(@F).0.o -o $(@D)/.$(@F).1 - $(NM) -pa --format=sysv $(@D)/.$(@F).1 \ + $(dot-target).0.o -o $(dot-target).1 + $(NM) -pa --format=sysv $(dot-target).1 \ | $(objtree)/tools/symbols $(all_symbols) --sysv --sort $(syms-warn-dup-y) \ - >$(@D)/.$(@F).1.S - $(MAKE) $(build)=$(@D) $(@D)/.$(@F).1.o + > $(dot-target).1.S + $(MAKE) $(build)=$(@D) $(dot-target).1.o $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ - $(orphan-handling-y) $(@D)/.$(@F).1.o -o $@ + $(orphan-handling-y) $(dot-target).1.o -o $@ $(NM) -pa --format=sysv $@ \ | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ > $@.map - rm -f $(@D)/.$(@F).[0-9]* $(@D)/..$(@F).[0-9]* + rm -f $(dot-target).[0-9]* $(@D)/..$(@F).[0-9]* ifeq ($(CONFIG_XEN_IBT),y) $(SHELL) $(srctree)/tools/check-endbr.sh $@ endif @@ -210,27 +210,34 @@ ifeq ($(CONFIG_DEBUG_INFO),y) endif $(foreach base, $(VIRT_BASE) $(ALT_BASE), \ $(LD) $(call EFI_LDFLAGS,$(base)) -T $(obj)/efi.lds -N $< $(relocs-dummy) \ - $(objtree)/common/symbols-dummy.o $(note_file_option) -o $(@D)/.$(@F).$(base).0 &&) : - $(MKRELOC) $(foreach base,$(VIRT_BASE) $(ALT_BASE),$(@D)/.$(@F).$(base).0) >$(@D)/.$(@F).0r.S - $(NM) -pa --format=sysv $(@D)/.$(@F).$(VIRT_BASE).0 \ - | $(objtree)/tools/symbols $(all_symbols) --sysv --sort >$(@D)/.$(@F).0s.S + $(objtree)/common/symbols-dummy.o $(note_file_option) \ + -o $(dot-target).$(base).0 &&) : + $(MKRELOC) $(foreach base,$(VIRT_BASE) $(ALT_BASE),$(dot-target).$(base).0) \ + > $(dot-target).0r.S + $(NM) -pa --format=sysv $(dot-target).$(VIRT_BASE).0 \ + | $(objtree)/tools/symbols $(all_symbols) --sysv --sort \ + > $(dot-target).0s.S $(MAKE) $(build)=$(@D) .$(@F).0r.o .$(@F).0s.o $(foreach base, $(VIRT_BASE) $(ALT_BASE), \ $(LD) $(call EFI_LDFLAGS,$(base)) -T $(obj)/efi.lds -N $< \ - $(@D)/.$(@F).0r.o $(@D)/.$(@F).0s.o $(note_file_option) -o $(@D)/.$(@F).$(base).1 &&) : - $(MKRELOC) $(foreach base,$(VIRT_BASE) $(ALT_BASE),$(@D)/.$(@F).$(base).1) >$(@D)/.$(@F).1r.S - $(NM) -pa --format=sysv $(@D)/.$(@F).$(VIRT_BASE).1 \ - | $(objtree)/tools/symbols $(all_symbols) --sysv --sort >$(@D)/.$(@F).1s.S + $(dot-target).0r.o $(dot-target).0s.o $(note_file_option) \ + -o $(dot-target).$(base).1 &&) : + $(MKRELOC) $(foreach base,$(VIRT_BASE) $(ALT_BASE),$(dot-target).$(base).1) \ + > $(dot-target).1r.S + $(NM) -pa --format=sysv $(dot-target).$(VIRT_BASE).1 \ + | $(objtree)/tools/symbols $(all_symbols) --sysv --sort \ + > $(dot-target).1s.S $(MAKE) $(build)=$(@D) .$(@F).1r.o .$(@F).1s.o $(LD) $(call EFI_LDFLAGS,$(VIRT_BASE)) -T $(obj)/efi.lds -N $< \ - $(@D)/.$(@F).1r.o $(@D)/.$(@F).1s.o $(orphan-handling-y) $(note_file_option) -o $@ + $(dot-target).1r.o $(dot-target).1s.o $(orphan-handling-y) \ + $(note_file_option) -o $@ $(NM) -pa --format=sysv $@ \ | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ > $@.map ifeq ($(CONFIG_DEBUG_INFO),y) $(if $(filter --strip-debug,$(EFI_LDFLAGS)),:$(space))$(OBJCOPY) -O elf64-x86-64 $@ $@.elf endif - rm -f $(@D)/.$(@F).[0-9]* $(@D)/..$(@F).[0-9]* + rm -f $(dot-target).[0-9]* $(@D)/..$(@F).[0-9]* ifeq ($(CONFIG_XEN_IBT),y) $(SHELL) $(srctree)/tools/check-endbr.sh $@ endif From xen-devel-bounces@lists.xenproject.org Mon May 08 13:01:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 13:01:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531554.827315 (Exim 4.92) (envelope-from ) id 1pw0U1-000488-Q6; Mon, 08 May 2023 13:00:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531554.827315; Mon, 08 May 2023 13:00:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw0U1-000481-NA; Mon, 08 May 2023 13:00:53 +0000 Received: by outflank-mailman (input) for mailman id 531554; Mon, 08 May 2023 13:00:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw0U0-00047l-MC; Mon, 08 May 2023 13:00:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw0U0-0007aH-JG; Mon, 08 May 2023 13:00:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw0Tz-0001dC-Te; Mon, 08 May 2023 13:00:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pw0Tz-0001Dh-TB; Mon, 08 May 2023 13:00:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0UbqY4+zBLVl0og9KoSVd61a0MTwPxmC32m3yj5RHZY=; b=Xxoq0gVY1t7bpTytF66gdaSP4e +yMmep7vvsFcBzGHmHCMX7+XCQEV1W5PTxgVNPcrxz91hWTa802XYb6iIFhWg5wSaEUzpIUEGe8Cz Zcyv4SBVVzky1A3KgBn2kjgKc5Z0opQpRm0y8aNCC+Uoz6qEtmv5pyxNsZ81zan105zU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180574: regressions - FAIL X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=ac9a78681b921877518763ba0e89202254349d1b X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Mon, 08 May 2023 13:00:51 +0000 flight 180574 linux-linus real [real] flight 180576 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180574/ http://logs.test-lab.xenproject.org/osstest/logs/180576/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 180278 Tests which did not succeed, but are not blocking: test-armhf-armhf-examine 8 reboot fail like 180278 test-armhf-armhf-libvirt 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-raw 8 xen-boot fail like 180278 test-armhf-armhf-xl-rtds 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180278 test-armhf-armhf-xl 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180278 test-armhf-armhf-xl-multivcpu 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail like 180278 test-armhf-armhf-xl-credit2 8 xen-boot fail like 180278 test-armhf-armhf-xl-vhd 8 xen-boot fail like 180278 test-armhf-armhf-xl-arndale 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux ac9a78681b921877518763ba0e89202254349d1b baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 21 days Failing since 180281 2023-04-17 06:24:36 Z 21 days 38 attempts Testing same since 180571 2023-05-07 22:11:42 Z 0 days 2 attempts ------------------------------------------------------------ 2359 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 296910 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 08 13:18:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 13:18:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531565.827324 (Exim 4.92) (envelope-from ) id 1pw0l0-0005pE-8f; Mon, 08 May 2023 13:18:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531565.827324; Mon, 08 May 2023 13:18:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw0l0-0005p7-64; Mon, 08 May 2023 13:18:26 +0000 Received: by outflank-mailman (input) for mailman id 531565; Mon, 08 May 2023 13:18:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw0kz-0005od-B9 for xen-devel@lists.xenproject.org; Mon, 08 May 2023 13:18:25 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20623.outbound.protection.outlook.com [2a01:111:f400:7e1b::623]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cfb06236-eda2-11ed-b226-6b7b168915f2; Mon, 08 May 2023 15:18:24 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB6960.eurprd04.prod.outlook.com (2603:10a6:803:12d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Mon, 8 May 2023 13:18:23 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c%4]) with mapi id 15.20.6363.031; Mon, 8 May 2023 13:18:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cfb06236-eda2-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KfWN+H1uAMUpoMXaldDpKZ/Z42pc2mh7q4TGXESMhcPIwv1NrCn+wWkbGz/XeQyNH4sR/5nvBVBuAm2+WFBF6757/GCfO0SQ4mAr+rAKCABa3XIi06dg6OxYqklW8PUS7xFVh4SkUcKq305gtGqDbI/XRTCat8BMXFrjtQ6HjdUaLWgdC01nEpJmvKySjCyyFj/66IELgQGFBQthxL12G9108+3ok8hhYnBFwVXRB79zxlbXLCwk00oBhMaNYUAe/yHakeXw0Ft4O7mD8LfYoTfdJY+0fZwUFGFR1jfhZbuL2BkRs4Y1n1TfnLQQQbSjlqpNpwWURT9EUOob8H2wRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fWRPL6YneaoJ91jGEXzcRq759h8bxvZnyP2YvrxalZQ=; b=JezcqsJmsQEbTP45NYM7m2gml4Xw+4tG3wE02FRrI5AyPoaMcNl411mqeflATSJRUzu3YTNhJcg4h5NaOslhneUSy0YEDobDqgf66nAoiRIyePOi5c9ChpjF4EBXsEgYJFawRFiAPlRD+67VHCxLhN3J138s0RIH9bLnCxKsxCcXYTGuZf4Vx2tQeIPo5brXsdnZHFtOaydM0RsVTQsjYmqjVB/mMbEHJaWq9+n9EvhYfTLlKefMX7/yza0wzivpH3glF3HBvsMO4b65WFiQDh6qoZVbbHgky3Nq1MI+WafxuMIJITtoh+rxo+NWDXVrJ1HKR3/V2vtZ/gDvKQepYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fWRPL6YneaoJ91jGEXzcRq759h8bxvZnyP2YvrxalZQ=; b=Glm/1kuGBMwg1S9vunwndR48fmCjYwRwcKR51FHsXYvJct9aosctaLMEnJuoB5DPUBB+0kEBGudI0caRC929CCFdqddKvrXLs+dkzHn9sHchEz007Onx7QAESE2SCLvR2pZ3xJEK8Jr5+Z/mVACFqvQnvObdEm8RqcGPFsIreQFOqguQ1WAtP7owkv9M2Mb1y/whweHCXLFefG0MrGFs2peM1AOEHpj62rW46iluvcAnQ66ixHOGfj+gCsgSkhsgRenYwYDnCl/vJqCc+s3oWRt69M6ePF+RXDGS/MzprsGOlqG346fWIC/eoL0wMUm2n0oNjAH10z4cZFd2vXylIQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 8 May 2023 15:18:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 3/3] x86: Use CpuidUserDis if an AMD HVM guest toggles CPUID faulting Content-Language: en-US To: Alejandro Vallejo Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230505175705.18098-1-alejandro.vallejo@cloud.com> <20230505175705.18098-4-alejandro.vallejo@cloud.com> From: Jan Beulich In-Reply-To: <20230505175705.18098-4-alejandro.vallejo@cloud.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0210.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ad::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB6960:EE_ X-MS-Office365-Filtering-Correlation-Id: 281687fc-17d3-4262-a086-08db4fc6b2ca X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UyctBTik5JSqZ9P4vksq2NsXMP80FY0ZNyHrBxCZ12G17RpK/6CZg8wRNknn4ZGdob8+7FSw+kzFRXlwGMRGrOeoAQ5FKNGAYW5MR+vExEJ9cJJeq8CU31vz0j8JRmtAc0bhZduRyvZIUkA0OjMsr3VgYSUGErAyLjh0OG86UVh3wOZOF7JISZnXZELO7QT7xgaShD529jPVNgnP2zVYSlQubtzI760CIDCo6wN+O2+nJeNChI7J/gg0bYptuy91dFYSCoytW2AAKLkKHs5HSvoY/Qky4DOfnZnaGb/F8Cxe5z7ylMY6tUp7BqODoAQHiL4zAxHfAvCZWchqkYcH4JKb56KEkbteOu3mGG1IhySohRumrPnMJN8dFvl9grdDj2i/+su7N9G2uPFiLqyd0DxaGx2lHYLNHOUeuDbiesm7b6VtVLqt68pRfToyiFEiwuUFK51/NvVCqyLauVChUWgJQN59ModLaLLYpGsugjAHpI8IifL0zgdPxg6X4ZCZ46f/7o6Oqtwn7k3bQ4fRzEbvTYCr10pfsXimh3eBQWTu0Jf6Nd1yiqmcSQxtSOcF6+t44jMnuCNn25Gzkx4OXpFBC+PrNouDcwxloRHkG5yM1tLkyrGWRvPRW+iU7cUu7kGVjF7RtOJkd//NDiwSGw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(346002)(396003)(136003)(366004)(39850400004)(451199021)(31686004)(66556008)(6916009)(4326008)(66946007)(316002)(478600001)(6486002)(54906003)(86362001)(31696002)(66476007)(36756003)(83380400001)(2616005)(6506007)(26005)(6512007)(53546011)(5660300002)(41300700001)(8936002)(8676002)(2906002)(38100700002)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SGJRVkZybmhUbjJFWU1wWE9GWnQ5MGRKNFFxVkhJY2YzWU93MG5hRHlsKzZF?= =?utf-8?B?YUFhOW5uWEFUaFFMMXk3MWh1WnNPcjE0Z2t5MmpweGtIeWh1d1VLZXRoY1hK?= =?utf-8?B?am4xWU9vSUNUTlkwUHN6UE95ZjZEbVhMYWJqSUx5UkZCQkJCbFB0Qk5wU20r?= =?utf-8?B?ZFFyQ0tZcHNjSi9uWmk3WCtRRXdyQ3FOWDlmL0VXTjdFUStKQXVmdVFqWGUr?= =?utf-8?B?bTFVT1h0R0RNMTRpSG9uMlBnUFpEU2lsSHdrTHc3d0RIN1MzWGZicU04VU9U?= =?utf-8?B?RzRGYTh2R2NpOERUcGlxYnRLVnpubURwNXR2WHgzcllYN2JCQXo1NzFSUk5I?= =?utf-8?B?b2JrdDNLWjJsL1ZaYWpXRE53QXFjQ0E2OGtSNVpNc1RoNjVHczI2dEZDT2Rz?= =?utf-8?B?anBHaVVxTE9WM2hZTFdsaEdCcVhmTFYzK0pPM3ZqSGZLVFJteTlPV3FQVFN3?= =?utf-8?B?R2ZQZm5RM1A4NmRDN0J4bDFzUUVmQnhWQW1TTXlTY1hPSVgra3hZUmVYT0xK?= =?utf-8?B?Nmh4czZOc2p0MWM5RUJTSzN3SW4zUWg1a2lROTVPTXh2S1V4dGZhV1RBaEFQ?= =?utf-8?B?ZS91Y2hweGIveUVFcnppMG54bDNPamV0VXhvOCtSTTdwSjBHeUdUZHBTYzF5?= =?utf-8?B?UkRldjBhUEZISk9lT0pGTzhKMnczVkJPajhGcEFlT1lMRXBIekVPVFhiY0xG?= =?utf-8?B?Mm5UK05lTWpzaEYxQmNKWS9qSFpqZWNrY2lMd05VWGI1MVNlYUNSWHRrUXQ4?= =?utf-8?B?S3B5QWJkZFZ5SlRyaXN2VHVKRGRKbzJ3c2tYcnlzeE0zNUJzSEF5WTRCNUZ4?= =?utf-8?B?NVhHSGZuZ2k5djE0dlc5aDlRWHpoYUx2YnJDZm9pbU1tWnR3ZW9OTGtHbmdI?= =?utf-8?B?MTFjRlN2YzB1dnYvalF2amQyM3ViN0VMWkdPM0U2M0pBM1krOXhlM09RYjhY?= =?utf-8?B?aTk1bmNtUmdoY3paWkVYMEQzVGkwRUlLK29wMGpMaTRaMVZBa1ZUc3VteTA5?= =?utf-8?B?SER5K0JQN3BxWHprOUdtVXhWWTZDWVh5bkR6djJUVldOT0dpQkhGVllKcFBs?= =?utf-8?B?c05LMkNkNU1ucm05Skd0bVkvTnlmUlhqaGI1UUliK25tM095WGF6UFVTRlho?= =?utf-8?B?RGhXcE1tVlBOVVhWa3ZhYjhyQ3plYmhEaVdkL0lhQ1ZaejRYUGRwb1Nwb1RS?= =?utf-8?B?dmduOUxCNlBialBFTzViYXRybW00T3pLY2Zic2QzTFpESHA5S3RVK2xUQ3Ar?= =?utf-8?B?eFJvd1IvVHVJVVFXemQ5QVE5bk5oT2tFdVNxV2NMWGd2SjJPSTVWcVo1RUtx?= =?utf-8?B?Z3FramY2R3dvZ1VNbjN1MEFWTnJtN1hwWlczVTZNQ2NWZTBMSndxbC9VUUhK?= =?utf-8?B?Q1hKeVgvL05hNDZZZWpjclRTS3V0VmVsK1hsMkpWZVZFUlVWRVRoeGVYM3U4?= =?utf-8?B?a3RuQWlTV0Q4ZkY5M1lkdHdYTnZWQVpyT3dqVmlEanQwb1lVbUdRN0JUcVJp?= =?utf-8?B?QWgzTFRzajNsMGJON0RicTdGQmR4TG95NGhRRmZTTVhsZkJSRSs1VlRLYXkx?= =?utf-8?B?MlVYWi9XWHJuU2hyWC9DekY4REpsMVlmcFB4RzZ4dFNrazhzZ1NrVUFpdFRx?= =?utf-8?B?MWdpbE9TNDRXSFVDUDJGWjlqT0hZWng3Q096aFRya3F2TFIxaFl1ZlRDNjg3?= =?utf-8?B?Vi9LS1RmWS94SytBcjVCb3N5Q2RscjNOaUtoeUdZcXYvUFhBY0NEeWh0ODkz?= =?utf-8?B?VXNhcEkvOU0xMnFjS2hlSlBieGRCYjVHazJ3My9DKzYrcUdSRit2Q01YZ0Uv?= =?utf-8?B?WDNiam5jTkRyQ0crenpFMERRZGR0VE9XRFZMeURoR0xJMnJPajVhS0NybzlO?= =?utf-8?B?NTJYSmhUSlVnR3pKa3NPWGtUbWpGRis2QjMvUks0NDArSFkxdnpBWHE2d0V4?= =?utf-8?B?RVFZaTVRYVM4UUlPS2F2RHRVSllZbXJIM1lKdldUbTZlQy9tL0RFVHhtVXUz?= =?utf-8?B?eHFodFlQelB2enpYRGVMaC9uMmJOdWxlNUxSUXpkd04zQm1pQ05YMktxdjA2?= =?utf-8?B?VHRoQzRjNjY0QlpnYzYzK28rWGpvMXYrNXZkcVgvY29xUnZpeC9YWndSMDlI?= =?utf-8?Q?wWkgeAqMsLmPQORjvPs800Npm?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 281687fc-17d3-4262-a086-08db4fc6b2ca X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 13:18:22.6322 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /8Gb5HPm8gE9PVNJvmQOVHVh8hk9MoI6+9m7jaFjdydQSe21v/rXHpIfO+Fx16JmWlvVtAL/DDKAYvFxx+CVqw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6960 On 05.05.2023 19:57, Alejandro Vallejo wrote: > This is in order to aid guests of AMD hardware that we have exposed > CPUID faulting to. If they try to modify the Intel MSR that enables > the feature, trigger levelling so AMD's version of it (CpuidUserDis) > is used instead. > > Signed-off-by: Alejandro Vallejo > --- > xen/arch/x86/msr.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) Don't you also need to update cpu-policy.c:calculate_host_policy() for the guest to actually know it can use the functionality? Which in turn would appear to require some form of adjustment to lib/x86/policy.c:x86_cpu_policies_are_compatible(). > --- a/xen/arch/x86/msr.c > +++ b/xen/arch/x86/msr.c > @@ -431,6 +431,13 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val) > { > bool old_cpuid_faulting = msrs->misc_features_enables.cpuid_faulting; > > + /* > + * The boot CPU must support Intel's CPUID faulting _or_ > + * AMD's CpuidUserDis. > + */ > + bool can_fault_cpuid = cpu_has_cpuid_faulting || > + boot_cpu_has(X86_FEATURE_CPUID_USER_DIS); I'd like to suggest that in such a comment it not be emphasized that it's the boot CPU (alone) we check. In fact I'm not convinced any comment is needed here at all. I'm further inclined to suggest to omit this (single-use) variable altogether. Jan From xen-devel-bounces@lists.xenproject.org Mon May 08 13:33:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 13:33:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531575.827335 (Exim 4.92) (envelope-from ) id 1pw0zU-0008SH-Gq; Mon, 08 May 2023 13:33:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531575.827335; Mon, 08 May 2023 13:33:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw0zU-0008SA-Dv; Mon, 08 May 2023 13:33:24 +0000 Received: by outflank-mailman (input) for mailman id 531575; Mon, 08 May 2023 13:33:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw0zS-0008S0-Tk; Mon, 08 May 2023 13:33:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw0zS-0008I2-OR; Mon, 08 May 2023 13:33:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw0zS-0002Pj-CA; Mon, 08 May 2023 13:33:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pw0zS-0001Z8-Bg; Mon, 08 May 2023 13:33:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=oxj5pLGURD1+vKzwlYEowwAh0303qy0RZFRiWUrOUMo=; b=u/2nXEEkXx2ph3Qk/+lMjiSGYM MBEVzcdlWFvFiuXNhjZlKvdVoIkwCMGo3cuMNQ3QOmLWi8dUgFohbfd8Y/Hwm6rfSl8f6Iye2tjgV FFruKaYK3L71KFjEP08KTSGT9VEogjjMGu5FWu7TJdUTuY4nXEqY43DaZ+t0g3mAfOhc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180575: all pass - PUSHED X-Osstest-Versions-This: ovmf=d89492456f79e014679cb6c29b144ea26b910918 X-Osstest-Versions-That: ovmf=8dbf868e02c71b407e31f9b41b5266169c702812 From: osstest service owner Date: Mon, 08 May 2023 13:33:22 +0000 flight 180575 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180575/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf d89492456f79e014679cb6c29b144ea26b910918 baseline version: ovmf 8dbf868e02c71b407e31f9b41b5266169c702812 Last test of basis 180573 2023-05-08 02:10:45 Z 0 days Testing same since 180575 2023-05-08 11:43:41 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Linus Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 8dbf868e02..d89492456f d89492456f79e014679cb6c29b144ea26b910918 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon May 08 14:13:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 14:13:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531585.827345 (Exim 4.92) (envelope-from ) id 1pw1bh-0004gk-IH; Mon, 08 May 2023 14:12:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531585.827345; Mon, 08 May 2023 14:12:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw1bh-0004gd-FR; Mon, 08 May 2023 14:12:53 +0000 Received: by outflank-mailman (input) for mailman id 531585; Mon, 08 May 2023 14:12:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw1bf-0004gX-Q5 for xen-devel@lists.xenproject.org; Mon, 08 May 2023 14:12:51 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20601.outbound.protection.outlook.com [2a01:111:f400:7eae::601]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 698ea6ab-edaa-11ed-b226-6b7b168915f2; Mon, 08 May 2023 16:12:50 +0200 (CEST) Received: from BN8PR04CA0019.namprd04.prod.outlook.com (2603:10b6:408:70::32) by DM6PR12MB4090.namprd12.prod.outlook.com (2603:10b6:5:217::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Mon, 8 May 2023 14:12:44 +0000 Received: from BN8NAM11FT087.eop-nam11.prod.protection.outlook.com (2603:10b6:408:70:cafe::26) by BN8PR04CA0019.outlook.office365.com (2603:10b6:408:70::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32 via Frontend Transport; Mon, 8 May 2023 14:12:44 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT087.mail.protection.outlook.com (10.13.177.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.33 via Frontend Transport; Mon, 8 May 2023 14:12:44 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 8 May 2023 09:12:43 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 8 May 2023 07:12:42 -0700 Received: from [192.168.137.15] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 8 May 2023 09:12:42 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 698ea6ab-edaa-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iXQyMI35v3ND2QJyPMNGVlEIRsOUo+Io2Rj/9CeUuGSe+0OVfaKmOKnzoRKcYufRRgyGTHralB96HNGX68B06LzTda+N4lh3IVMNosqCafD1ZI6qOGA6i/MgBsROtllKNf7gi2KPf7ENdThnui/l6V3I5hqWx74FbJHRv0xgpSKNopOwkzxk8wUuvoeClJBBptnTFuMgUm/xWwBH4opFjuNNS6cJdeKYhVotDYDn8Fi7dXDE/WRu2eTdRrzpaE1brwRtULEzTXf+wHAi+8YfDAdd0pmCwyfGO3zghPRA8ffEPL7zsi9e8+veLUyeSe02jFLH/Q8LGkBpd4yEyDw85g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GeJaDIJJReWZD9EkDq23oZ61Jfq8KZPalADMHBqnzQ4=; b=JnunmsxoHvie1DOg1XFccF+Kjz81S3R3CLZejx5z5VmzjKIN7okwyTIVzAHGy0VByGfQapo5cpPoJ3pO1P3mjxrlD9Z59Zf5A1cN6XHUg0QFtKJ0Tnr0Rzq5/iAzPi+lHeUenbSyq/oxegVkLBKZ5Y8JTgd4MHPknNNoCGuV+3/yUTPHd1qxUDhTwxD2WU+9BRquFE1MP1ug46fBrd7rtwr+2nMtNFmAAxoIkFoxcaBg5mpAdpg8Gff/74U7/xtBnfx/Gtl92mHyxdU2UhFaxnKiospUoEjl2NW4iqEQHXrr8xtSvTK/Ng4Sq48v7NixP6OiyQdrYfkuokjV1EmMcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GeJaDIJJReWZD9EkDq23oZ61Jfq8KZPalADMHBqnzQ4=; b=y1KpK0j85jCbv77MCwgciHaenNWmaUVPRIHBzMK2NsJapOqmYVcrspMO6xTPEafmeD2YfCsBc0C4vrzdA5gDLL7mnk2KgQQGEmJWTpseVl4eitBgSaPKkpMGxJ7um3L0kowyYNyl62I4M3WGMnIFGu3+hmME7hjH23Jb4Lnt85E= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: Date: Mon, 8 May 2023 10:12:41 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v1 3/6] iommu/arm: Introduce iommu_add_dt_pci_device API Content-Language: en-US To: Jan Beulich CC: Oleksandr Tyshchenko , Stefano Stabellini , Julien Grall , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , References: <20230501200305.168058-1-stewart.hildebrand@amd.com> <20230501200305.168058-4-stewart.hildebrand@amd.com> <0e7404fe-e249-7b3f-0628-b8b8b1925765@suse.com> <6758ef37-bf66-99c3-1fd4-f2edfc12513a@amd.com> <39f9548b-6a07-3d74-1975-8f17153f2d14@suse.com> From: Stewart Hildebrand In-Reply-To: <39f9548b-6a07-3d74-1975-8f17153f2d14@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT087:EE_|DM6PR12MB4090:EE_ X-MS-Office365-Filtering-Correlation-Id: 948428bc-5a85-461c-5224-08db4fce4ae9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2zcNkg+heGGd2LLiqpDI0siIXoSAMirqCqHYo7ObFYnZ2Lxb65Ec5wXCnDRab6Lu/piTCOa1Sww77QGi3BbU0RpbwPDPrTxKHfFfiegVidnFaraZEy6ntWznQarx5/Yj58WlrRLNpFmNoAbN/utjg3uBwZ39uanVtk1jnb3FwfOQUQdgCkefzp99clLe7BxGrZZpvHHa5OidXlU89kie8eYIcLRRgDwaGwUwPhqLK9xCZYW1xDJCdtZJMsWlvqIWw5WCMU6qS8UXS4RSVouWCOavz2UV5wgvkOPB30kgVwhMf+NMXu9zoSRV35l9saGux9AFonEqLFvxAuQOTthn6niv19+pP365wIzgW1ksC2MjTlKvCP1k9enxi2sjzftkIuxF2UsDFEWM/LaDnS/XtDurIKtSqFCBNyuTgCzlrEVhX/SmrJATSCPd4VGBhKgDDRPJvSdeW52myBHqJxhoC9l32ITTfkGKLkPD4NvKb/yURn+L6q4rmuTtdxvCIV/y90e/SsYs2xqD8fU8rujB5EuhA/rpPoWDHoNq9QgV91dDR6bnfbhQvnfdPKHKpeY2b/a3c493b0aiP8dyiOxga52KCXcFisthMl2LL9rQLg4ZrPtEP6eq+1j/AWfkErhmho0UTU3F7Ol/NLdxR7UBI6EE5c5fV6AMXGmZStcQ6v0yrb5gJYXZYfOYvu6Azqs5b9QbvhxeV6sgJ7UmUSifDAIVvdQVD9hUM9cTC0RuH4rctfpiXlLWpmrUeDFcbaPx+n3XjnhsEGEMjUzwAN/VqQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(346002)(376002)(136003)(451199021)(40470700004)(36840700001)(46966006)(53546011)(26005)(83380400001)(336012)(40480700001)(426003)(36860700001)(36756003)(2616005)(81166007)(356005)(86362001)(31696002)(82310400005)(82740400003)(186003)(40460700003)(47076005)(41300700001)(16576012)(2906002)(54906003)(31686004)(5660300002)(6916009)(4326008)(316002)(8936002)(8676002)(478600001)(44832011)(70586007)(70206006)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 14:12:44.1406 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 948428bc-5a85-461c-5224-08db4fce4ae9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT087.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4090 On 5/5/23 02:20, Jan Beulich wrote: > On 04.05.2023 23:54, Stewart Hildebrand wrote: >> On 5/2/23 03:44, Jan Beulich wrote: >>> On 01.05.2023 22:03, Stewart Hildebrand wrote: >>>> @@ -228,6 +229,9 @@ int iommu_release_dt_devices(struct domain *d); >>>> * (IOMMU is not enabled/present or device is not connected to it). >>>> */ >>>> int iommu_add_dt_device(struct dt_device_node *np); >>>> +#ifdef CONFIG_HAS_PCI >>>> +int iommu_add_dt_pci_device(uint8_t devfn, struct pci_dev *pdev); >>>> +#endif >>> >>> Why the first parameter? Doesn't the 2nd one describe the device in full? >> >> It's related to phantom device/function handling, although this series unfortunately does not properly handle phantom devices. >> >>> If this is about phantom devices, then I'd expect the function to take >>> care of those (like iommu_add_device() does), rather than its caller. >> >> In the next patch ("[PATCH v1 4/6] pci/arm: Use iommu_add_dt_pci_device() instead of arch hook"), we will invoke iommu_add_dt_pci_device(devfn, pdev) from iommu_add_device(). > > Which I think I said there already I consider wrong. Okay, I'm following now. Right, so, the first parameter is not needed. >> Since iommu_add_device() iterates over the phantom functions, it would be redundant to also have such a loop inside of iommu_add_dt_pci_device(). >> >> If we are to properly handle phantom devices on ARM, the SMMU drivers (smmu.c/smmu-v3.c) would need some more work. In patches 5/6 and 6/6 in this series, we have: >> >> if ( devfn != pdev->devfn ) >> return -EOPNOTSUPP; >> >> Also, the ARM SMMU drivers in Xen currently only support a single AXI stream ID per device, so some development would need to occur in order to support phantom devices. I spoke too soon, the SMMU drivers do appear to support multiple IDs. >> >> Should phantom device support be part of this series, or would it be acceptable to introduce phantom device support on ARM as part of a future series? > > I wouldn't view this as a strict requirement, so long as it is made clear in > respective patch descriptions. After doing a little more investigation, I should be able to add in the plumbing to iterate over the phantom functions in iommu_add_dt_pci_device(). Stay tuned for v2 of this series. >> Lastly, I'd like to check my understanding since phantom devices are new to me. Here's my understanding: >> >> A phantom device is a device that advertises itself as single function, but actually has multiple phantom functions. These phantom functions will have unique requestor IDs (RID). The RID is essentially the BDF. To use a phantom device with Xen, we specify the pci-phantom command line option, and we identify phantom devices/functions in code by devfn != pdev->devfn. > > The command line option is there only to work around errata, i.e. devices > behaving as if they had phantom functions without advertising themselves > as such. See our use of PCI_EXP_DEVCAP_PHANTOM. As you can see, this being > PCIe only, and legacy PCI device bevaing this way would require use of the > command line option. > >> On ARM, we need to map/translate a BDF to an AXI stream ID in order for the SMMU to identify the device and apply translation. That BDF -> stream ID mapping is defined by the iommu-map/iommu-map-mask property in the device tree [1]. The BDF -> AXI stream ID mapping in DT could allow phantom devices (i.e. devices with phantom functions) to use different stream IDs based on the (phantom) function. >> >> So, in theory, on ARM, there is a possibility we may have a device that advertises itself as single function, but will issue AXI transactions with multiple different AXI stream IDs due to phantom functions. In this case, we will want each AXI stream ID to be programmed into the SMMU to avoid SMMU faults. > > Right, which of course first requires that you know the mapping between > these IDs. Thanks for clarifying! Stewart From xen-devel-bounces@lists.xenproject.org Mon May 08 14:16:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 14:16:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531590.827354 (Exim 4.92) (envelope-from ) id 1pw1ez-0005Hq-1L; Mon, 08 May 2023 14:16:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531590.827354; Mon, 08 May 2023 14:16:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw1ey-0005Hj-Ux; Mon, 08 May 2023 14:16:16 +0000 Received: by outflank-mailman (input) for mailman id 531590; Mon, 08 May 2023 14:16:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw1ex-0005HZ-Ev for xen-devel@lists.xenproject.org; Mon, 08 May 2023 14:16:15 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2060b.outbound.protection.outlook.com [2a01:111:f400:fe5a::60b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e0ceb653-edaa-11ed-8611-37d641c3527e; Mon, 08 May 2023 16:16:10 +0200 (CEST) Received: from MW4PR04CA0310.namprd04.prod.outlook.com (2603:10b6:303:82::15) by PH7PR12MB8013.namprd12.prod.outlook.com (2603:10b6:510:27c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Mon, 8 May 2023 14:16:06 +0000 Received: from CO1NAM11FT023.eop-nam11.prod.protection.outlook.com (2603:10b6:303:82:cafe::67) by MW4PR04CA0310.outlook.office365.com (2603:10b6:303:82::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32 via Frontend Transport; Mon, 8 May 2023 14:16:05 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT023.mail.protection.outlook.com (10.13.175.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6363.32 via Frontend Transport; Mon, 8 May 2023 14:16:05 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 8 May 2023 09:16:04 -0500 Received: from [192.168.137.15] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 8 May 2023 09:16:04 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e0ceb653-edaa-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hQMT5htmryGeYazIRpQR41F4hFEmIRZ3+fgpR/huG7vdquIwh2SWUILEqNx0WJq3dqSea+wgdrYf393oA7AvC7QBW6k99gJWao4a1Z5MQWvBcxOB/lu28/64g0FAmBPduDRG6XAtku59m7e5GJOrYQq80XI98j3IKPnhmm26ZHf9LlGU7I5zfe+Jpl0wGqdAIbFdudlbWqXZk8LZtZR44xnnAOuTe12Olg3ci3mzds8ZjE9tZvUPoq9b1ud+T6dqWBs9Sj0l8SJQFwUlQsO/vLCww17bWnwxTRWwE+9UCzCM05rESCK8FzXo/Zc7DZM7pX5wCIx8MIBnkUpbMupUUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZxyRAMPyNArOT31T7QCsvLYjetxz3AUpOEcPbV16r98=; b=KXvyD6+41+XPNgDNNNciwTeWID18+Q7nMoGmWA8cxV3fyQEWQNTU902VMmr/Kj5fM+c33/MM5vx3UD4x9uwAhy+jxy0ityh+cYiRG7tv02bEDjr/B49wIsvoi+6g2OXDhJ55Q4fLg0psZ0voegv1xMbzLTQOFJfT0wK6c6V/WL1vdo3nDLUWbOxf5ws16FVv8cH4d5XRwRPEPfF50efNJW7IQ1EKIFdGJnMQnFUlAm/Eo7Ydfamj07PkQWjY7LcOZWi9Bvi+5F3nAC2cSndVMc//1+kENIbHjoACiSAYhafld7l4TQsmlqtM/qwm8H/gyZrjk0mFaeDbEVUw6WELgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZxyRAMPyNArOT31T7QCsvLYjetxz3AUpOEcPbV16r98=; b=LLouR+ChQQE1xice0b9QgKYKdT/f9cKIM475uXls+1IebGx9O2WUBFGw4tAoDWBmSjxPF4FXJwgovvR083ftD7C7QaN6lMzXCrJNZGdPQX9hVaRuSIbR1yjBKiJThyIcx1PlONKWd5eq8r7QjU6KrCWJ5o6FugLa2qXg1c4l57g= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <8591236e-5dc2-7da7-fe3a-7cb2ae1ed7d0@amd.com> Date: Mon, 8 May 2023 10:16:03 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v1 4/6] pci/arm: Use iommu_add_dt_pci_device() instead of arch hook Content-Language: en-US To: Jan Beulich CC: Oleksandr Tyshchenko , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , References: <20230501200305.168058-1-stewart.hildebrand@amd.com> <20230501200305.168058-5-stewart.hildebrand@amd.com> From: Stewart Hildebrand In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT023:EE_|PH7PR12MB8013:EE_ X-MS-Office365-Filtering-Correlation-Id: 5af86cf0-4090-4b29-454c-08db4fcec31b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pOG1PcJYov8H5dMUKjYBRyneTA6SS0OQM8wdxbjTPsyOP2kpoKnhQWogvJt1xqg8+Vf593dMmd4ivQYWfiKALQRctFpiipXXLtV2cXO8St1IcD9Dem8kaJZIMyvD3k9oDph6WStGQXoIbDibf6NUmD/aXwB99elabRD8ny5TdDgX6J2FTvrFG2jIAcNOcz+rGX1UPDaW52AU2Bt0i4A9JZYiUvcxqiGcyKhY0FXt+K3I52EhOhlPVUE6YyauVi7RBofTvh4zRaZmwYcLBBkdsdKZXL7OnWn+YQv6c3qFhixU2OKtezK9g7vHY0os4FjtUN2iFTfjDRXHGxEguJqmencXoaZsw6Gjk+q73NvDe6PE0r8K5R+qKApLVUvSRGWNO+eFa7Fdpr4LQ93qoppfXWW7QqeiuHz/q8O3H7S6mXMFIXLeCYPFTqBFfVMXEr1ToyYh2mX0nVAyxZ1WTKy7aCJsXlLaNxUTSY1ue/r23zxHOXk68WPHukJPL5Fe0hArgqf1+7Kw4iZsE5XaVt92HwxmrmpI14Hb7k6Bp4AEbhh0gsReMBZ109fAKcUG8dGqaMfw5Pi3uCMNofKf48YmS8FS6P/5b+GTWni7rC4BK8IJ5rBDtsIsVJgS1k2iSxGTebGr/bCTvcmNqUXEcuG4kfVk9FcMbvBT9n2RulFTlvukN6c+o/5FXlCyuppzW+5A1nku7FmptCpdPPNVDksR3DETWslTOSIb3Q99h6+mDNerZCSDYJqxVEHsdlWcnh2TOhXBcS8/OoZwtha3kbbe/A== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(396003)(39860400002)(136003)(451199021)(36840700001)(46966006)(40470700004)(40480700001)(81166007)(356005)(82740400003)(36860700001)(47076005)(2616005)(426003)(26005)(186003)(336012)(83380400001)(53546011)(70586007)(2906002)(8676002)(44832011)(8936002)(36756003)(478600001)(31696002)(40460700003)(54906003)(16576012)(86362001)(316002)(6916009)(5660300002)(4326008)(41300700001)(70206006)(82310400005)(31686004)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 14:16:05.6540 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5af86cf0-4090-4b29-454c-08db4fcec31b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT023.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8013 On 5/2/23 03:50, Jan Beulich wrote: > On 01.05.2023 22:03, Stewart Hildebrand wrote: >> --- a/xen/drivers/passthrough/pci.c >> +++ b/xen/drivers/passthrough/pci.c >> @@ -1305,7 +1305,7 @@ __initcall(setup_dump_pcidevs); >> >> static int iommu_add_device(struct pci_dev *pdev) >> { >> - const struct domain_iommu *hd; >> + const struct domain_iommu *hd __maybe_unused; >> int rc; >> unsigned int devfn = pdev->devfn; >> >> @@ -1318,17 +1318,30 @@ static int iommu_add_device(struct pci_dev *pdev) >> if ( !is_iommu_enabled(pdev->domain) ) >> return 0; >> >> +#ifdef CONFIG_HAS_DEVICE_TREE >> + rc = iommu_add_dt_pci_device(devfn, pdev); >> +#else >> rc = iommu_call(hd->platform_ops, add_device, devfn, pci_to_dev(pdev)); >> - if ( rc || !pdev->phantom_stride ) >> +#endif >> + if ( rc < 0 || !pdev->phantom_stride ) >> + { >> + if ( rc < 0 ) >> + printk(XENLOG_WARNING "IOMMU: add %pp failed (%d)\n", >> + &pdev->sbdf, rc); >> return rc; >> + } >> >> for ( ; ; ) >> { >> devfn += pdev->phantom_stride; >> if ( PCI_SLOT(devfn) != PCI_SLOT(pdev->devfn) ) >> return 0; >> +#ifdef CONFIG_HAS_DEVICE_TREE >> + rc = iommu_add_dt_pci_device(devfn, pdev); >> +#else >> rc = iommu_call(hd->platform_ops, add_device, devfn, pci_to_dev(pdev)); >> - if ( rc ) >> +#endif >> + if ( rc < 0 ) >> printk(XENLOG_WARNING "IOMMU: add %pp failed (%d)\n", >> &PCI_SBDF(pdev->seg, pdev->bus, devfn), rc); >> } > > Such #ifdef-ary may be okay at the call site(s), but replacing a per- > IOMMU hook with a system-wide DT function here looks wrong to me. Perhaps a better approach would be to rely on the existing iommu add_device call. This might look something like: #ifdef CONFIG_HAS_DEVICE_TREE rc = iommu_add_dt_pci_device(pdev); if ( !rc ) /* or rc >= 0, or something... */ #endif rc = iommu_call(hd->platform_ops, add_device, devfn, pci_to_dev(pdev)); There would be no need to call iommu_add_dt_pci_device() in the loop iterating over phantom functions, as I will handle those inside iommu_add_dt_pci_device() in v2. > The != 0 => < 0 changes also would want, after respective auditing, > clarifying that they're indeed no functional change to existing code. Okay. Stewart From xen-devel-bounces@lists.xenproject.org Mon May 08 14:40:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 14:40:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531596.827364 (Exim 4.92) (envelope-from ) id 1pw224-0000FQ-05; Mon, 08 May 2023 14:40:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531596.827364; Mon, 08 May 2023 14:40:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw223-0000FJ-Tj; Mon, 08 May 2023 14:40:07 +0000 Received: by outflank-mailman (input) for mailman id 531596; Mon, 08 May 2023 14:31:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw1tt-0007go-PR for xen-devel@lists.xenproject.org; Mon, 08 May 2023 14:31:41 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2071c.outbound.protection.outlook.com [2a01:111:f400:fe5a::71c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 098fad6e-edad-11ed-8611-37d641c3527e; Mon, 08 May 2023 16:31:38 +0200 (CEST) Received: from PH0PR13MB4842.namprd13.prod.outlook.com (2603:10b6:510:78::6) by BY3PR13MB4913.namprd13.prod.outlook.com (2603:10b6:a03:364::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Mon, 8 May 2023 14:31:29 +0000 Received: from PH0PR13MB4842.namprd13.prod.outlook.com ([fe80::f416:544d:18b7:bb34]) by PH0PR13MB4842.namprd13.prod.outlook.com ([fe80::f416:544d:18b7:bb34%5]) with mapi id 15.20.6363.032; Mon, 8 May 2023 14:31:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 098fad6e-edad-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JOPnvtcWRS00h2H1ELQximqgO0pZdIvZXY6u1deEUuC//PltgduwnDCGdKZZArok2EVEDmfyLhb7b5YqaCLYBN0GUitpjBKi/PWuQASYSjQ31i1jKwxrFNO60orrSlp6BUpIhnUd9HZGvRhVeRIEr7hypPXGtlAvnLlk8OXZEUs0aS+cNIJpRUUlmtW0fCKlOpMQZtczLbHt7KCPutJ7PzJtLDrNWGkEQ7LzuJygSlhx3d6pS9qeHzNyt0suI+AjsZMMUkThrFeq66m/e8lImKVbRNNhL94l+rtbyExYq0R5kkDbY8t7iZUEraMZA10e80ksSL1a15BBEPwMXnUktQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QWHFB7hQg4+3+Z/Kov4mvbp9ZaOMHz+OyvOUtUL64qU=; b=O6wj9HG0SuckzQ6nfabxIDbVQPSBah283PxlOayQ2YTpeuIDbvSlK9dDvidWpVhR6wXXe88LKyEqSjzygdbEKSTWnQ/5F+juT3tN1xGN5xrM8DjTyy6bamk8VcSnopf4liQbknCTURS7fAmDAbQTNBL4Io6qOyx1xLO/sIUqzFp/0+OOorf3JErUhSX4K2qLJrXAVb96Yz6DhSodLdNM/49gJVIvCVf6taovKT/DsFMM9UEkxOxOfjIEenb+z7n0LQzTSsAJP2BgsDXo7p25eKald2Sl+PdfDMWVGEjbOOXU2/rJv2UQ7qD/8IeHFHdEtT6N6vf7eS0CEU07Q6m74A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QWHFB7hQg4+3+Z/Kov4mvbp9ZaOMHz+OyvOUtUL64qU=; b=UZ1kFLh6N/UUZaysCnvKi1HOrNlAY8XLjlJMKi3hV0cwb3kaxDDHzEDpBUlelrlm8CMmqqLEgYJWsh7t0gKlJdrWpFX3MaWjDKcW0Or7ZAIBEvz8gsP3Z4pEu2agITrfDlavuFsttW5cx4FZn1nqfMr56cmxrEGe4vW0JzFkiOQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Date: Mon, 8 May 2023 16:31:22 +0200 From: Simon Horman To: Yunsheng Lin Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, edumazet@google.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, alexanderduyck@fb.com, jbrouer@redhat.com, ilias.apalodimas@linaro.org Subject: Re: [PATCH RFC 2/2] net: remove __skb_frag_set_page() Message-ID: References: <20230508123922.39284-1-linyunsheng@huawei.com> <20230508123922.39284-3-linyunsheng@huawei.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230508123922.39284-3-linyunsheng@huawei.com> X-ClientProxiedBy: AS4PR10CA0014.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:5dc::18) To PH0PR13MB4842.namprd13.prod.outlook.com (2603:10b6:510:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR13MB4842:EE_|BY3PR13MB4913:EE_ X-MS-Office365-Filtering-Correlation-Id: 9731ce74-4abe-44d5-f641-08db4fd0e9a0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5dNvbxKWS9XzMLeoQtaatZgxcWBBz0PUQmxiJb5DU6EhqHZYM/maOgqjTbW1wWVVQCn7N2FpD3XUVNS01jpdjX3ZCRfMFB1GCr+Th+UbTe2B3sc0d3JgLpFpmCFklegFCmxtbazSb9gRkgpFZU31nxG3h9XixQuTCo8Mz5vgJMq9dTQUg2Z9BnFoougkMrjdt5/dHqIT766496PQMXBoc3BbyMpmfupZFfC7n/rfy7FnpmBBC+lPMwutxg6HSHMQMDF82PxrJ5LaQUJG8T0pVNYwhE3Vc3+2W4B4jOBK5hwYTsIjXWjFHOmy2whe7MWrcvLfnobwONoBx6lBl1NtV7F7JcwYz47SUYhl83P2Xi0oE8/ybKWgdZVmRcEdLipIAuqfWXNZD9EXMSbPxSrMmxosTjtETuTl0c2/VgbQ8b99vs82/snW3GrGNCi1RgbeJ2Gx+7NEY8Tppqu0t1MxYwxfXIvitcq4tFNmGAjt9Sh82tZIhhYz5g9sSF0FoQeaGRa6TS3VWZcI9MCF7VjrVH2eqpOkyN8bVeDkD/Upgk2AAizzhxc1GlFyQ/7KBkn/Q097geVLTF1AL/JE8wAkq4d7RHSojIHeGfJ5reJM07w= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR13MB4842.namprd13.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(39840400004)(376002)(396003)(346002)(366004)(451199021)(2616005)(186003)(36756003)(38100700002)(86362001)(2906002)(6486002)(8936002)(8676002)(316002)(6666004)(41300700001)(4744005)(7416002)(5660300002)(66946007)(6916009)(66556008)(4326008)(66476007)(478600001)(44832011)(6506007)(6512007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cN84bJh2d6pjo0zorxwYHiIln/mvP1cDBKvJYx3LiRZBb2LQFvS6Sb4Mc6ha?= =?us-ascii?Q?vGMVsIiRmKzBcrt8yZIjX18ZdrWyLoIXExonKUj4/k4IdkJdCNe447+wL8b5?= =?us-ascii?Q?ahXgms2O0O12VPiGtrGlxnnoJ5KfxhnwOHqOjwBgbIvlFPTHiXMutDAPi8YX?= =?us-ascii?Q?Pub8/S1Urv2UTYiDgUL00tGIINYWWMn7HotskbgaqFJUvJMkXflsFaskbUs2?= =?us-ascii?Q?+5Z4zQHoqIij9U9qn0jwjnzIzv+0ioLxQRTp5mZfDpKSMpTjNSUNbEE6Aa/q?= =?us-ascii?Q?I3RR58AjwQKz+mb8KjK1pBPcpsz7+VTjYKAv3wVD6B+UHLVd/9bYQ2AwnGQd?= =?us-ascii?Q?wdAjbSL6NO9wTjvPGPmA7QOmEMG/DWRvuEBJGfJcMpGU972nbJtwrZ9+aMHt?= =?us-ascii?Q?M5mAeVmc+5Dc7/Syx1ZIE1NUUS/skhEJAUUhJofS1KUrC4/SQMJ0T9tbC6tN?= =?us-ascii?Q?YfWihH40Q7asygFRlRMJPtjuMcpwbP0+2WVZILJeg61DToT9zLGs9S3cmK+2?= =?us-ascii?Q?B7i+d0qkWE3uL7Wki5pfpJrxxVNMCcr7icPdVvMpon3QSXb3PAbUzdmnu15E?= =?us-ascii?Q?o5njwCeA2P/yMg9qxxEj4xik4GlgXSaSsOK0YjyG8D3hCjB1lDMYia7kVChg?= =?us-ascii?Q?kl+VcngiXTZunIU2eBAA2/JjlT0UC7XkmwgC2O1z8Ou+CbbLFE6PSz2hQraC?= =?us-ascii?Q?qGouR+rDsi5plrNZhLN861PdMsP0jYdNrEqUAzlxhE36sOToQFiAeKGATnAB?= =?us-ascii?Q?fevHO3bqjE3saHpYqXNrANdn7wQLJnzpOAeU8PFt94ApXGjfFcdkzbiTQxrR?= =?us-ascii?Q?XOPmoUlTeJD1fwzi+fpS5WIDUJ7kaXuAVgBZ1RB1+O/S+qFKwi4qPMz3GpU6?= =?us-ascii?Q?ab6vA/LYAx3JjgHTjNLXLs4AntbbjGSXyn5iAtxELhpQgCmOAruhmQGVYRHZ?= =?us-ascii?Q?qP4ZuGBeV0eBT71zotsyaBgY/Krm8nvLc0s9IFd16Vr8ogBmO49J2pnwlpIH?= =?us-ascii?Q?Vz873wyoLbMAbYqKJnk+cbG9nfHwVn/nvxGRhI4L750q3o+0vBtUwgDceaPt?= =?us-ascii?Q?/KdA7uHiuOreiVAYb/RAMMiylSAjX52Ktm5M2ZmbJEXJXYtSDe70JE3tIeKz?= =?us-ascii?Q?UnxvNtWB8UKjRw3BFL+arxq0Fej8lT0UyuuJRwihQm9mdag5C82Iq/ZJidUE?= =?us-ascii?Q?9U/QMOCJXW06ByoK9WdjYYEfn24zhgE187lcH5ce7xQv9cVg2CqW9UUbhnmH?= =?us-ascii?Q?1qFOGd0tpM6Yj7Eq7Crm6qTXzbMTstKE5Ub2hVtIEIgYI20+NK075z6iLRSf?= =?us-ascii?Q?ux3bIATB+1NInBgGd1GZqEB7abQdmqfeyLcLuaGFmYXHu47Z+3mYZDObuk8/?= =?us-ascii?Q?2Mzs1FatRNSYF5UIoxnxXpZklLGEN+i3j3jWPS1fKlQtGUF1ZLM7egYWknwb?= =?us-ascii?Q?Oy9Pgvril1LAQOAXwp9HG/3QH2LisP7PKgcZwbreiHkNUOA8sAJ2vf40cr4K?= =?us-ascii?Q?J7gjpcti57++EJgcmXwfTf8Khtnhgh8PLeqAT6dR43XTFNg3xawHsPhTTWfZ?= =?us-ascii?Q?TNFidIuQqtCldx2Mdoqf7PgkJ/ZmyvGxhZckJean4Fj81Z2LDvYfA7kbHqXb?= =?us-ascii?Q?Fj7UDQXbqY6n6IPfqcksqcGghpacO97ACz+saMfiTZKcPY7akUDAaokSl9s6?= =?us-ascii?Q?Ryvtxg=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9731ce74-4abe-44d5-f641-08db4fd0e9a0 X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 14:31:29.6325 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: u6hSWBRqOay5n8SVgV3DO8Jpj+AO+w/kQ2MhQ0MC5eFU8Many1hPg/r4wpMpQTXka5VdQx+3HXd4ZAJ+v+eaNix/d8aRuy1JBKZ02wKUGvE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR13MB4913 On Mon, May 08, 2023 at 08:39:22PM +0800, Yunsheng Lin wrote: > The remaining users calling __skb_frag_set_page() with > page being NULL seems to doing defensive programming, as > shinfo->nr_frags is already decremented, so remove them. > > Signed-off-by: Yunsheng Lin ... > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c > index efaff5018af8..f3f08660ec30 100644 > --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c > @@ -1105,7 +1105,6 @@ static u32 __bnxt_rx_agg_pages(struct bnxt *bp, > unsigned int nr_frags; > > nr_frags = --shinfo->nr_frags; Hi Yunsheng, nr_frags is now unused, other than being set on the line above. Probably this local variable can be removed. > - __skb_frag_set_page(&shinfo->frags[nr_frags], NULL); > cons_rx_buf->page = page; > ... From xen-devel-bounces@lists.xenproject.org Mon May 08 14:45:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 14:45:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531603.827375 (Exim 4.92) (envelope-from ) id 1pw27S-0000xG-Mf; Mon, 08 May 2023 14:45:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531603.827375; Mon, 08 May 2023 14:45:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw27S-0000x9-Jd; Mon, 08 May 2023 14:45:42 +0000 Received: by outflank-mailman (input) for mailman id 531603; Mon, 08 May 2023 14:45:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw27Q-0000x3-Pq for xen-devel@lists.xenproject.org; Mon, 08 May 2023 14:45:41 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fe45e7e3-edae-11ed-8611-37d641c3527e; Mon, 08 May 2023 16:45:38 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 2B0C35C0198; Mon, 8 May 2023 10:45:36 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 08 May 2023 10:45:36 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 8 May 2023 10:45:33 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fe45e7e3-edae-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1683557136; x=1683643536; bh=GalsNTfBovyiQ3QbCYOoCXADHgE91GHkBa5 DzKiFpNI=; b=oxAmWlhgkuGMEXFUunr3DNH47p7sDDyAhVCjzNf1POru5DcOEjg ZNKo3q+5t342BaL2JbQv4H3sZV7NEc3OtlQaj8KMTts16ffvbkJq+TNqJad5V2Ij Z/vvIJwZO5FQuzSGXaV55dZ8irXMU4R9NftdW4J88eGoOm+7OFbQw4KelssJjf/3 xPL+hau3pSRwBgEWXYzx+Do4uWs9CHYHNK7g2PvRu1YQ7OD5Q3/YqzTFd/HncLTs X8FrcU8tnH4xQdyV3VB1HU7qolgGT2KPQRcKayyTZeHPmLH6uR3bQ6cVYUvgeM5l rjuLcpzQwBea0e+xYEkMMGHXyneV/N/OP9A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1683557136; x=1683643536; bh=GalsNTfBovyiQ 3QbCYOoCXADHgE91GHkBa5DzKiFpNI=; b=EMILixeZBAaHHJgYOgzUtcNpUVCfF Ib9jyNVK2C/cckyKIr18HtNT02OaOw5bbZECLwtKC4yj0GL8YXrSHii8HLl/GV3B N+svB//1zwstwrQkXQCdbMNzNJoFlY9DNBYGLzMQ6+rY8y1Cb2fyQhnN2TQBXZAf +CB32UbcCrtZpfMcbHU3LdVKG2h3usuMZ8kZGzryfXa7hgijRKoB3N7SlhhUGedu PPFM2ed/nfDPWKVbpJfK4GzvPCgi3fJ3STUJX8UGaOKNG5GrlpZmILKpyWUrVRH4 DbExOUgqHUFPRuBLFzAtdWni0ZmuObKUcGUCj8edNPN5Bfuu9Yd9QiEPw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeefkedgkeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfdu leetfeevhfefheeiteeliefhjefhleduveetteekveettddvgeeuteefjedunecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Mon, 8 May 2023 16:45:30 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH v3] ns16550: enable memory decoding on MMIO-based PCI console card Message-ID: References: <20230505214810.406061-1-marmarek@invisiblethingslab.com> <763df4ee-95d7-be20-212f-7450f3fd431e@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MYnSo1kS/nFwL/fs" Content-Disposition: inline In-Reply-To: <763df4ee-95d7-be20-212f-7450f3fd431e@suse.com> --MYnSo1kS/nFwL/fs Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 8 May 2023 16:45:30 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH v3] ns16550: enable memory decoding on MMIO-based PCI console card On Mon, May 08, 2023 at 11:01:18AM +0200, Jan Beulich wrote: > On 05.05.2023 23:48, Marek Marczykowski-G=C3=B3recki wrote: > > pci_serial_early_init() enables PCI_COMMAND_IO for IO-based UART > > devices, add setting PCI_COMMAND_MEMORY for MMIO-based UART devices too. > > Note the MMIO-based devices in practice need a "pci" sub-option, > > otherwise a few parameters are not initialized (including bar_idx, > > reg_shift, reg_width etc). The "pci" is not supposed to be used with > > explicit BDF, so do not key setting PCI_COMMAND_MEMORY on explicit BDF > > being set. Contrary to the IO-based UART, pci_serial_early_init() will > > not attempt to set BAR0 address, even if user provided io_base manually > > - in most cases, those are with an offest and the current cmdline syntax > > doesn't allow expressing it. Due to this, enable PCI_COMMAND_MEMORY only > > if uart->bar is already populated. In similar spirit, this patch does > > not support setting BAR0 of the bridge. > >=20 > > Signed-off-by: Marek Marczykowski-G=C3=B3recki >=20 > Acked-by: Jan Beulich > with ... >=20 > > --- a/xen/drivers/char/ns16550.c > > +++ b/xen/drivers/char/ns16550.c > > @@ -272,6 +272,14 @@ static int cf_check ns16550_getc(struct serial_por= t *port, char *pc) > > static void pci_serial_early_init(struct ns16550 *uart) > > { > > #ifdef NS16550_PCI > > + if ( uart->bar && uart->io_base >=3D 0x10000) >=20 > ... (nit) the missing blank inserted, which I'll be happy to do while > committing. Thanks! --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --MYnSo1kS/nFwL/fs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmRZCwoACgkQ24/THMrX 1yweDgf/VYoswpWnZMdtshzSzmFxmIltDCjRlXb2573ThI7Wwjx6t2M28F+om1qh J8bkD+fISFpIZnuDB9+x/BntvgwvpCsUXX0U/kuldnYTFi5MuJeopjlTn6u8db35 MnJQ4gTIghv2IBLZTHHIbWDMf/l+eWKARRrxUG31vvYsooiptRi1gLGYtcQpPjXs UWRi3DmEqR4kGS/1QRUgIthuzv9zPfppFAD83OPZ11CTJhoeKtUxyhMjKAopQk7N wtbNQOFDONcZOKNaq+/obF7oZEmoGLVvIjcxd+9Na5IalOrGEoNbVOgPh4/CV+yP KpYsHSyW1hHaoi+83yn3DEGXzZFpfg== =ltDc -----END PGP SIGNATURE----- --MYnSo1kS/nFwL/fs-- From xen-devel-bounces@lists.xenproject.org Mon May 08 14:51:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 14:51:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531608.827385 (Exim 4.92) (envelope-from ) id 1pw2DE-0002Q1-BQ; Mon, 08 May 2023 14:51:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531608.827385; Mon, 08 May 2023 14:51:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw2DE-0002Pu-7s; Mon, 08 May 2023 14:51:40 +0000 Received: by outflank-mailman (input) for mailman id 531608; Mon, 08 May 2023 14:51:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw2DC-0002Po-AL for xen-devel@lists.xenproject.org; Mon, 08 May 2023 14:51:38 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20601.outbound.protection.outlook.com [2a01:111:f400:7e1b::601]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d50847cd-edaf-11ed-b226-6b7b168915f2; Mon, 08 May 2023 16:51:37 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU0PR04MB9635.eurprd04.prod.outlook.com (2603:10a6:10:31f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Mon, 8 May 2023 14:51:35 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::8e41:82b6:a27f:2e0c%4]) with mapi id 15.20.6363.031; Mon, 8 May 2023 14:51:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d50847cd-edaf-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ddRfcf6ZrdbL89IckrwLHwNf4gq+xT8+OrlUqAMslMuoKDAbufhocNJEIBql/DP9kJePRcf2KeY2vsLv4rs2cgu2kMcadU+SX+Wn9YkvSJuMZiAyWIR8QJEk19Eo8l0IH9+9AP2dtQpuWbjPa+GUVJ62zEE/QaqdC+d78dZ7m/kp8/VvWhxUae908YBC22aN4N3hlB/fyQZoFiF034kp3+xduoP42EvpIjZyFQKEM2IXHy+UTkyjs/L+9MY3dbPquBk4aiYz50FK91c80kbpZdByMVUQa5UMJzrj3s9TAoGesVMuz7vdytc0EGvwBJec9kDN0ERgViMIBxTNBoVCWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yAGXXn/fj1TWLxwadDhIw8IrxVrgzziidtcjMLL+RBw=; b=BcR2QKbQIpMeYYsxPbH37dSzdQ/Z+1WsV+84J3H6o78QmGxutnKhaq2WHb/N6jVy9Y4sJ9vvai0B+o3Z0ILDjcKawUJqlYx9jxz/q+MXZL/c31rlY7V/c2i+x257lTey6jlcT2GFJF5HkxlBtQ4fT6NYvXHNpXPj5B/jUpmmBgKZJL7DQ00U7sGw4Db2ElLfmEcZkzUNhaPSXtxk8HyGV7fJ5nyrUgq6veWYwRn105OeBWQpzVaQEbMkgX0LGeU1Lm/HllW4GJZdE6iD6hbmEeKTb60gbUOvzhL7Afzquusgc3UvKtNtIYelPZjG/fMoAk74KttQSnQLWqtC/50xuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yAGXXn/fj1TWLxwadDhIw8IrxVrgzziidtcjMLL+RBw=; b=5NWz4z/+IeeKkXBUTncI8qa/5u3guiE76Mmp5DPOlwNYLHjinIEt/IPDU+DqdXizzwAVhEQyspOrMMfdKghHiHLGnlluYWaBx8tV6VsYoOMWVCv5IHxhkgb4RK/KohAQwNLPpOBhV8W1TXjWxi+IDFhJl2BnPW0EbfmcNh+WoA6VaEclV/G6licaJQtZz4GfarqtfJcemapmRQLuEcwLZaXxhp/19pzZ+6bLK1I/6YavJBFuLYkiuWFzmoZGOWs5LwWJpO+WsVbpPvX4JfQjDiQwjhrDV+Xni2oVgZf0Ik77PulcCcZq3ocQ3WQZOTmC5N3z4MdaAMEG4+U5FoKPKw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <462657d4-72e7-6266-6ea5-2b9e443f9813@suse.com> Date: Mon, 8 May 2023 16:51:32 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v1 4/6] pci/arm: Use iommu_add_dt_pci_device() instead of arch hook Content-Language: en-US To: Stewart Hildebrand Cc: Oleksandr Tyshchenko , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20230501200305.168058-1-stewart.hildebrand@amd.com> <20230501200305.168058-5-stewart.hildebrand@amd.com> <8591236e-5dc2-7da7-fe3a-7cb2ae1ed7d0@amd.com> From: Jan Beulich In-Reply-To: <8591236e-5dc2-7da7-fe3a-7cb2ae1ed7d0@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0172.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b4::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU0PR04MB9635:EE_ X-MS-Office365-Filtering-Correlation-Id: c8354ee9-00bc-41b4-67d0-08db4fd3b783 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KhLzzCuRodTH+oRcoAAo4O3kcR4dBB2lmRIVmPr8c2RIuJz4HrkYsmauHztugOIQzpjSFlC58QCJyJ+vZuVsu7LUHILhnl2jN+iS+Z72zRpHhRLnsW2G0agXsqwpjA6TmnbtTlUdRd6E1zC4Jm5TB5P5OqsMlKsRXEG0hHCvFDW0mR31hqdih82SpqNFuty4wGtcNuOIOkb6eFWtJBhMYdnvaaBfjTfU8N+mxErG6TMDHbsafBWvtsmNOL0q9HBHnInYjpT4sasNAJJEffPdiDS54UjsBtoLSyTQcYSBacKWZ7yQK50rArhkIusm003jmhWDA6PnvBsym/r34EetpoRfbOMxhtCwbIZd0kd71MGSjRaZ14OMuV0XCsL1pSdqvT+9MwhxXOyz+sLviZA3sYrbmDsxEpqG+InjrTx46ZS/zMOrDAmhN/lmX2FWMjFrWsjI72Da/h9+xI+BCcFeWoMAQODC4h3VfTtrxdcpkX3dD78yvM6bo6olqh9DFgI92PlGrzyKlBy3urVKPPnLcqpUXIH/FTj65a12MsdkOnPQ4IUQJhZaE24vo7go/jNnAZkgPDPYQIU/4D2xf6aEbk7jsUuxBYpnHVoymJ2iTAxODLB0uxDFfpvfU0xplwY0W3F0Fn0Kw7N7IZ1h/1+gUA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(396003)(39860400002)(376002)(346002)(366004)(451199021)(6486002)(36756003)(66476007)(4326008)(6916009)(66556008)(66946007)(54906003)(2906002)(31696002)(86362001)(41300700001)(316002)(5660300002)(8936002)(8676002)(38100700002)(478600001)(186003)(53546011)(26005)(6506007)(6512007)(83380400001)(31686004)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZzB2NHpHSlVYdllXbkpRVjNpZmsrbnovdVo2S3ZDZkFveE12dS9HMGZpeVhj?= =?utf-8?B?U2ZpdTRrVk1FVmJ2NUNFL2Jmc3BpeTRRUVhJTEF5UTZacndjK01UbXlhUUFO?= =?utf-8?B?WnZLeTFqL1QyRDFkRnRzRnlGbmlueTlzd0VjRkgyaFlwTFRqd1dZNkp1NE5a?= =?utf-8?B?VisvblB1ekkxSWJYdThTYjRuNE91dmhnQWx6OElTeUplQy9mUndzQUNWbWJR?= =?utf-8?B?eCtic2dJZXlWM1JkWFNFOEVNVEJqU00rMlV2Qy9FMTEreWpibmt3K3VHVWZ4?= =?utf-8?B?cStxTDVQS24wams2VEdvOTFDYzVtNnVjUWg5c0lUVlRoUThLcXVjNFFmOWo0?= =?utf-8?B?bFBGVFdZVWNreUFEa285enJGcEFzVTdLNTVoKzNuc1MwQzVlWXBDUzJQZmFC?= =?utf-8?B?S3kzdXlGTUZ5WlVDK2cvZDg2dmJPZndiV3lseklrcDBkQkdrU0hFNWdCSkNx?= =?utf-8?B?Nld5SUk1N2p1b0xOLzZNdlNDTnlNZDFhSGcwU0tUTFFveURwTEZESTJqVGl4?= =?utf-8?B?eTJ2QUlaSytKTmpsSkMvejlGSEdzUXZqd1ZlZ3hkSXhyZDdLeklvdHR5TUFw?= =?utf-8?B?SUZIalVycUsrOUcyR09YOFlpMGhiMldlQlpLUTlyd2lnUXdRbWF5bi82TzR5?= =?utf-8?B?alJ0K3gvOGhnNGFwMk1mQkRkR0NSMS9LV0tGZDQzRGFSNW5lWUUrejRMRkxm?= =?utf-8?B?K0JWUmFreE1rc3NLV3c2NTVDQ25OdTNCZU04ODNMazVwRnJqcVNPS0Yyb3Qr?= =?utf-8?B?YTJsL3dZUURWU1AwWnRnM2M4V0JnRnhOcytZdnJuaGNLN1hPSnRmYVh1cDh4?= =?utf-8?B?bURDQjJsRktQcitMNlUrUlhiSGdLcXRsZ3BZQngvLzJCN1Yzb1g3alRrbUQw?= =?utf-8?B?UjdHQThUUVJ2UDFjK3BKR3grSEx3bm9HQzJCazFvZzdNTTExWTQwdHE3U3Fk?= =?utf-8?B?QW5QRTNIVU9VanFVVTF5ZUNmenVHbHVhRHlndHc4b1E0U3BPVUpxWjJYM3F3?= =?utf-8?B?dXEzbDRENTNXRlBVVXNpeklveSsyaFRqeVk2L0l3Wk9Kc0tWREpKS2d0cUV3?= =?utf-8?B?OEFOOFhmTmVCelZLamZzSWozNHdsN25DaW5zeTB1R0dYQjAzaWxmZHdtdDJu?= =?utf-8?B?dlRlemVPOUFSS2syUjlQVVRKZk4wa3cxeGJnMTd0YzdzSmRTSGt4Y3o2c3hM?= =?utf-8?B?dEVmOXk4Sm9GcmhaMHNITm1FSVNoMzh5OWU0U2grTHkzdmhOMkxhZ1BkcHBn?= =?utf-8?B?UDJWOFZSbVppMWNrRFhoK2I5R05RUFRqYlllMmVSSUY3bjliWGVyU0tJcVht?= =?utf-8?B?anpZbktjTCtsVHV4T3VSRHpzcW16U2FBVWVDWklFUTRtV2szTVI0L2dhT2pU?= =?utf-8?B?MmpnL1piaE5SOHl4QklWNlN6aGhWWUgycDZBTWYvYno1d0VhYlc3VTFFb25V?= =?utf-8?B?a0hzTHVwbElFTWV6MGFwaFZFNkpsQjRPTVZMdUxZWWJuTmladEd0Y0REbDVG?= =?utf-8?B?blFqekxnaWpSWWVVYUNoR3hHc0xEV0ZQWHNwcEpHekt6RlpORStkMlNoeDZt?= =?utf-8?B?UStyelRBTFd3SDcxSzVzQlVPb1RVQ2pTbjFVNXFaUXhBanQwVEZ2TTV5SEtQ?= =?utf-8?B?N0R3Q3VDU3NMbTNEUyt4cWVGaGR6bEE3dk1MMUlrbWs4Wk92WXNma1hKaUli?= =?utf-8?B?ZjFyTkhEazJBaUFabjRuUy8rNituSjJyTnBkYXRXd014Q0F3Tm9vRFZlZitU?= =?utf-8?B?TWhaNjFwMTFQMHRSa1pPd1JQRnZDYWtnejZlbFVFVFpzM1lCUnJQeDYxVTBj?= =?utf-8?B?Tnh3Wm5UaXZ3VnErbjJ6QmlxRVptUlBDWmVrcUpheEpjeXNLZk1uU3ZOc1Uy?= =?utf-8?B?T20zR1FCVXRYRnBMSXEzSmVOWmJRU3NNd203MEp2MTNIVFBOWVF6eTZhSzBt?= =?utf-8?B?TFlVWnZUdkU4ejRHWVFEZmR2YWJEdTA0eGgvdHRJdTZ2bmszS0k1bFdpMHJD?= =?utf-8?B?cTZjWTlBeEgwaTVuYXhLakpVMWRpTC91VmJZRXVvY3V4K2hPSGsxdkduNjNh?= =?utf-8?B?TGV0ZVMvRnFtMkdKenYvc0FaM01hUEpkYy9zUWVIQXRnbFVIanpaOEllSXpD?= =?utf-8?Q?RNxKgQF6dPl+zx5C7uy6jzmxV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c8354ee9-00bc-41b4-67d0-08db4fd3b783 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 14:51:34.1122 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bUN+gU34u+P+vV39s7VwJGf5HbDhnU+lezm+p91NKNaVymutdTA5uYUIHx2K5KA4hAImD+8z7oBUD3Jhy+sxuw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9635 On 08.05.2023 16:16, Stewart Hildebrand wrote: > On 5/2/23 03:50, Jan Beulich wrote: >> On 01.05.2023 22:03, Stewart Hildebrand wrote: >>> --- a/xen/drivers/passthrough/pci.c >>> +++ b/xen/drivers/passthrough/pci.c >>> @@ -1305,7 +1305,7 @@ __initcall(setup_dump_pcidevs); >>> >>> static int iommu_add_device(struct pci_dev *pdev) >>> { >>> - const struct domain_iommu *hd; >>> + const struct domain_iommu *hd __maybe_unused; >>> int rc; >>> unsigned int devfn = pdev->devfn; >>> >>> @@ -1318,17 +1318,30 @@ static int iommu_add_device(struct pci_dev *pdev) >>> if ( !is_iommu_enabled(pdev->domain) ) >>> return 0; >>> >>> +#ifdef CONFIG_HAS_DEVICE_TREE >>> + rc = iommu_add_dt_pci_device(devfn, pdev); >>> +#else >>> rc = iommu_call(hd->platform_ops, add_device, devfn, pci_to_dev(pdev)); >>> - if ( rc || !pdev->phantom_stride ) >>> +#endif >>> + if ( rc < 0 || !pdev->phantom_stride ) >>> + { >>> + if ( rc < 0 ) >>> + printk(XENLOG_WARNING "IOMMU: add %pp failed (%d)\n", >>> + &pdev->sbdf, rc); >>> return rc; >>> + } >>> >>> for ( ; ; ) >>> { >>> devfn += pdev->phantom_stride; >>> if ( PCI_SLOT(devfn) != PCI_SLOT(pdev->devfn) ) >>> return 0; >>> +#ifdef CONFIG_HAS_DEVICE_TREE >>> + rc = iommu_add_dt_pci_device(devfn, pdev); >>> +#else >>> rc = iommu_call(hd->platform_ops, add_device, devfn, pci_to_dev(pdev)); >>> - if ( rc ) >>> +#endif >>> + if ( rc < 0 ) >>> printk(XENLOG_WARNING "IOMMU: add %pp failed (%d)\n", >>> &PCI_SBDF(pdev->seg, pdev->bus, devfn), rc); >>> } >> >> Such #ifdef-ary may be okay at the call site(s), but replacing a per- >> IOMMU hook with a system-wide DT function here looks wrong to me. > > Perhaps a better approach would be to rely on the existing iommu add_device call. > > This might look something like: > > #ifdef CONFIG_HAS_DEVICE_TREE > rc = iommu_add_dt_pci_device(pdev); > if ( !rc ) /* or rc >= 0, or something... */ > #endif > rc = iommu_call(hd->platform_ops, add_device, devfn, pci_to_dev(pdev)); > > There would be no need to call iommu_add_dt_pci_device() in the loop iterating over phantom functions, as I will handle those inside iommu_add_dt_pci_device() in v2. But that still leaves #ifdef-ary inside the function. If for whatever reason the hd->platform_ops hook isn't suitable (which I still don't understand), then - as said - I'd view such #ifdef as possibly okay at the call site of iommu_add_device(), but not inside. Jan From xen-devel-bounces@lists.xenproject.org Mon May 08 15:22:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 15:22:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531622.827395 (Exim 4.92) (envelope-from ) id 1pw2gV-0005xH-Lj; Mon, 08 May 2023 15:21:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531622.827395; Mon, 08 May 2023 15:21:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw2gV-0005xA-IP; Mon, 08 May 2023 15:21:55 +0000 Received: by outflank-mailman (input) for mailman id 531622; Mon, 08 May 2023 15:21:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw2gU-0005x0-4R; Mon, 08 May 2023 15:21:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw2gU-0002Lp-1s; Mon, 08 May 2023 15:21:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw2gT-00061W-KW; Mon, 08 May 2023 15:21:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pw2gT-0001HJ-K0; Mon, 08 May 2023 15:21:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=PyNgi0ojZt4A+GcLwAii4XZMRRqfzom2tmBpFk9imag=; b=e2QLxvHIPN8FtmKYco7USgLrm8 KYPMhNdEuMjAKFD1Aa4DlCFyu7qfLUPCazzPGLfu1zBGfheqrUD2mXePWVFkcJ9f9CQIUzJeO/sPu WRdOzpitVoXTwLDh+d0MomI3vhBmEnocvNdtIV1KSN5toUwWS75EFR76OWcIA5x87N40=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 180577: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=a16fb78515d54be95f81c0d1c0a3a7b954a54d0a X-Osstest-Versions-That: xen=e93e635e142d45e3904efb4a05e2b3b52a708b4f From: osstest service owner Date: Mon, 08 May 2023 15:21:53 +0000 flight 180577 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/180577/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen a16fb78515d54be95f81c0d1c0a3a7b954a54d0a baseline version: xen e93e635e142d45e3904efb4a05e2b3b52a708b4f Last test of basis 180541 2023-05-05 08:01:57 Z 3 days Testing same since 180577 2023-05-08 13:03:54 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Jennifer Herbert Marek Marczykowski-Górecki jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git e93e635e14..a16fb78515 a16fb78515d54be95f81c0d1c0a3a7b954a54d0a -> smoke From xen-devel-bounces@lists.xenproject.org Mon May 08 15:41:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 15:41:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531632.827405 (Exim 4.92) (envelope-from ) id 1pw2yn-0008P5-8o; Mon, 08 May 2023 15:40:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531632.827405; Mon, 08 May 2023 15:40:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw2yn-0008Oy-5W; Mon, 08 May 2023 15:40:49 +0000 Received: by outflank-mailman (input) for mailman id 531632; Mon, 08 May 2023 15:40:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw2ym-0008Os-9l for xen-devel@lists.xenproject.org; Mon, 08 May 2023 15:40:48 +0000 Received: from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de [81.169.146.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b2ddfa58-edb6-11ed-b226-6b7b168915f2; Mon, 08 May 2023 17:40:46 +0200 (CEST) Received: from sender by smtp.strato.de (RZmta 49.4.0 AUTH) with ESMTPSA id x6987cz48Fec1Vb (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Mon, 8 May 2023 17:40:38 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b2ddfa58-edb6-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1683560438; cv=none; d=strato.com; s=strato-dkim-0002; b=LiemzYZrSKziM+y0QPXCKHxyEer0ip+WguU0P9L3lHLZHV+GHN4u66Lh8mHiiLC2R1 SfMTx6UHgQUicJLkwv597duEDnSOTYDrfnkEIW8bGkLHB/rMSs8z3EMXWPqR95TN24we dmYofIL6GbFa/nE+xurTSJHbuXL5dHQafvHc9quXu1cuk/NAMjt8ZTKt7ZzFHyoKUxJh 9DbBaK7IdsMKMSAOK8nB7DegbfFUbfRCe5iknXxiuZYN0sgxMIQ1ytsomYo2ZreVkWva VG7Hb6c9lamGd8jezH72pDtatkwIIc78wZbCyrV8k7O+c1E7H+8kD124eVIoYwKxrXgM 8LDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1683560438; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=GD4pD2lagECFcggREhpTpdjv2A2W+Z6MdThgJKqvj/8=; b=KJE4h3TpSUrwe25SXEJMpm3b6rtyVAHYE/yPZ5FBiRl7OG+ZjpBTK9ev5vp0ahF1lC L2tvrc93nC+DrPrKLWCOIG5obPjrHQwxYZnZR5K8zf3AXsojG4YZJ4xtcwQIP0TdVfpW /eAMR+ek7cycL9FSAmzWNnOmcQibcB05v9fwJ/43QqJYPCPKBdYA+l95AjuBRqkwO66I IhUqDdWoMHbz/6+NuFuQWhiuhJjOmDb7GCPeR25oVl41F23XY9AKqvjDt34g4HAXsEbN cdFdfWhTED0tCUZbvE2kWNOwhZfc3sWB2RTE+AVMy+suqRPkWm1A1Pd1ywLJqTS4Zus2 jfMg== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1683560438; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=GD4pD2lagECFcggREhpTpdjv2A2W+Z6MdThgJKqvj/8=; b=jjUN8//RmNZlKrZjZPfjh4TNkajm2kxsYnIITkJbPM/WeCavI4c4cWRfwCUMymMfET 6R1UWi6uoyP6aRBPEzDPkJMhCPBK8hSTLBuTlHnKTFoAfvf+eMDoQvzocZ76smVWbfxj WDWs1nTUn9nSHwnTftOJBqfX0Q36+DcWq4WEClbaqJULI42ZKeYr8+gE36q1El6G7RjO Byyf8feYqqCgyDi2zXlRBDq0GkS1SYwaSt5LUw55p6cdaYmJy1wdDWwtDZVSkjVjbgFE dFUQfCrHP1WK9QBVNJ1SntAjn9V8UgXj7x6AHgfutiPU7ynIFv28Extff8CdI2V6oKaF /ylg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1683560438; s=strato-dkim-0003; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=GD4pD2lagECFcggREhpTpdjv2A2W+Z6MdThgJKqvj/8=; b=bwHBSPksmyEi/70m2Fo195zb2zZuw2V8D4hYnF6DH2rxvdFWtC2uQHnKurGsbUpqs0 1WWCqNJW9kLTgQN/afCA== X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisR4ARWIYxzstZKeVom+bauo0LKSCjuo5iX5xLikmg==" Date: Mon, 8 May 2023 17:40:31 +0200 From: Olaf Hering To: Juergen Gross Cc: xen-devel@lists.xenproject.org, Wei Liu , Anthony PERARD , George Dunlap Subject: Re: [PATCH v1] tools: convert bitfields to unsigned type Message-ID: <20230508174031.585a3288.olaf@aepfle.de> In-Reply-To: <324fd699-dcd8-9881-a276-167be38622b1@suse.com> References: <20230503150142.4987-1-olaf@aepfle.de> <20230508120038.74246111.olaf@aepfle.de> <324fd699-dcd8-9881-a276-167be38622b1@suse.com> X-Mailer: Claws Mail 20230504T161344.b05adb60 hat ein Softwareproblem, kann man nichts machen. MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/Q0Z3jrQHA4gLbAwmBtbq3Fq"; protocol="application/pgp-signature"; micalg=pgp-sha256 Content-Transfer-Encoding: 7bit --Sig_/Q0Z3jrQHA4gLbAwmBtbq3Fq Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Mon, 8 May 2023 13:23:27 +0200 Juergen Gross : > I have found 18 lines using "unsigned int" for bitfields in this file. There is indeed a mix of both variants in this file. I scrolled just down to line 6999, only looking for ':1'. Olaf --Sig_/Q0Z3jrQHA4gLbAwmBtbq3Fq Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmRZF+8ACgkQ86SN7mm1 DoCJ4A//Q79FIn5hVwGknH3nmxusiPSNdYqcfyRo0QJrCR9gDnZiVMb0zQOgeO61 6fCcMX9UcV1/Dp2M+Z5K6Sgj4g0hLxBiQ+NrHMh4O2tHaPPe++l97i6HCC4b00EY zdwaW1/oYbO9rXFG45aIlc4CmBvvc2bKEn/6mt1HBsR1IXWQBDBawX+G1CjmOWFR 0niXKVIFkzqaROtaHjwVnCvSahKNRNqhrcXycV0hxYO4ftmtkBbPhhqZofuYnNqy TYpEXf/A6JgpryoDHOeDD5LfIcETgIQcnZfrS4Jp8e0xWtBlbs5ag3ljISbxHpAf 7hc7RaL+uBrnqQ7YVOGautRMjxHgDsRZfmn4o7LBqsM2wfIIfcVJjLUZB5ChPQ8R 2Ox6xsMPn4RQl9HciQG9wSrfp5cRRzHD8HHrU8Mg+kSEVyc1k7wBlE4Qa2VS55Fu XW3DykpUd6Wgjr1YZsacDYRpQQtt0dnTO3WvtBsm6VU4VqXmDgApf2dSzPseg7Zh TO2Ra5SHeSOb4bbXNPjalqKH4zqMAKNoBykHjsUJzdRH4wkeAInZ51t7XdqmWuCQ HI3f///lG44uwyJQtHzA+mlQQPAKrjq/+AfhSQB27gUii4j613ZTT8dtvLXjQuE1 1gCFWcTs8vAfpfUS0wV6SA731xTtP9PECfQRe9g0LyG0CAwB64U= =pZnR -----END PGP SIGNATURE----- --Sig_/Q0Z3jrQHA4gLbAwmBtbq3Fq-- From xen-devel-bounces@lists.xenproject.org Mon May 08 15:53:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 15:53:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531645.827414 (Exim 4.92) (envelope-from ) id 1pw3B6-0001af-GI; Mon, 08 May 2023 15:53:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531645.827414; Mon, 08 May 2023 15:53:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw3B6-0001aY-Df; Mon, 08 May 2023 15:53:32 +0000 Received: by outflank-mailman (input) for mailman id 531645; Mon, 08 May 2023 15:53:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw3B5-0001a6-Bf for xen-devel@lists.xenproject.org; Mon, 08 May 2023 15:53:31 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 79e06d9a-edb8-11ed-8611-37d641c3527e; Mon, 08 May 2023 17:53:29 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 02C4F21DB3; Mon, 8 May 2023 15:53:29 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 809EE1346B; Mon, 8 May 2023 15:53:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id y8mUHfgaWWQfOQAAMHmgww (envelope-from ); Mon, 08 May 2023 15:53:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 79e06d9a-edb8-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683561209; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=enCmPKVL/QYyWJsvjc1siLNro32aXyEZpjP4ToWLEys=; b=ithED1KI1jXI4dpx1wT8kE5Q567qTNV290ZWYDHVsYekplRXDrxtJQ+EvU5F7c90fBjv19 TB5/cxMwkMWg5B9aAl5f6H/hSokrfNUEno+6Xt156PNgM0Dk2JrTcpTPyZexNh7ip4e8ou tWXTL7Rb7w06LMHD/hNPWswPX0spdsY= Message-ID: <3ce78def-659c-a3c2-3633-26e5b0a212b1@suse.com> Date: Mon, 8 May 2023 17:53:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH] x86/pci/xen: populate MSI sysfs entries Content-Language: en-US To: Maximilian Heyne Cc: Bjorn Helgaas , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Marc Zyngier , Kevin Tian , Jason Gunthorpe , Ashok Raj , "Ahmed S. Darwish" , Greg Kroah-Hartman , xen-devel@lists.xenproject.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230503131656.15928-1-mheyne@amazon.de> From: Juergen Gross In-Reply-To: <20230503131656.15928-1-mheyne@amazon.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------qUSNF0DqSSSO09uggR0ul3al" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------qUSNF0DqSSSO09uggR0ul3al Content-Type: multipart/mixed; boundary="------------2VgdL2ARHnFdKP06t0hm3NRa"; protected-headers="v1" From: Juergen Gross To: Maximilian Heyne Cc: Bjorn Helgaas , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Marc Zyngier , Kevin Tian , Jason Gunthorpe , Ashok Raj , "Ahmed S. Darwish" , Greg Kroah-Hartman , xen-devel@lists.xenproject.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <3ce78def-659c-a3c2-3633-26e5b0a212b1@suse.com> Subject: Re: [PATCH] x86/pci/xen: populate MSI sysfs entries References: <20230503131656.15928-1-mheyne@amazon.de> In-Reply-To: <20230503131656.15928-1-mheyne@amazon.de> --------------2VgdL2ARHnFdKP06t0hm3NRa Content-Type: multipart/mixed; boundary="------------5l1refLpYoFuAkuHwmsfSyyJ" --------------5l1refLpYoFuAkuHwmsfSyyJ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMDUuMjMgMTU6MTYsIE1heGltaWxpYW4gSGV5bmUgd3JvdGU6DQo+IENvbW1pdCBi ZjVlNzU4ZjAyZmMgKCJnZW5pcnEvbXNpOiBTaW1wbGlmeSBzeXNmcyBoYW5kbGluZyIpIHJl d29ya2VkIHRoZQ0KPiBjcmVhdGlvbiBvZiBzeXNmcyBlbnRyaWVzIGZvciBNU0kgSVJRcy4g VGhlIGNyZWF0aW9uIHVzZWQgdG8gYmUgaW4NCj4gbXNpX2RvbWFpbl9hbGxvY19pcnFzX2Rl c2NzX2xvY2tlZCBhZnRlciBjYWxsaW5nIG9wcy0+ZG9tYWluX2FsbG9jX2lycXMuDQo+IFRo ZW4gaXQgbW92ZWQgaW50byBfX21zaV9kb21haW5fYWxsb2NfaXJxcyB3aGljaCBpcyBhbiBp bXBsZW1lbnRhdGlvbiBvZg0KPiBkb21haW5fYWxsb2NfaXJxcy4gSG93ZXZlciwgWGVuIGNv bWVzIHdpdGggdGhlIG9ubHkgb3RoZXIgaW1wbGVtZW50YXRpb24NCj4gb2YgZG9tYWluX2Fs bG9jX2lycXMgYW5kIGhlbmNlIGRvZXNuJ3QgcnVuIHRoZSBzeXNmcyBwb3B1bGF0aW9uIGNv ZGUNCj4gYW55bW9yZS4NCj4gDQo+IENvbW1pdCA2Yzc5Njk5NmVlNzAgKCJ4ODYvcGNpL3hl bjogRml4dXAgZmFsbG91dCBmcm9tIHRoZSBQQ0kvTVNJDQo+IG92ZXJoYXVsIikgc2V0IHRo ZSBmbGFnIE1TSV9GTEFHX0RFVl9TWVNGUyBmb3IgdGhlIHhlbiBtc2lfZG9tYWluX2luZm8N Cj4gYnV0IHRoYXQgZG9lc24ndCBhY3R1YWxseSBoYXZlIGFuIGVmZmVjdCBiZWNhdXNlIFhl biB1c2VzIGl0J3Mgb3duDQo+IGRvbWFpbl9hbGxvY19pcnFzIGltcGxlbWVudGF0aW9uLg0K PiANCj4gRml4IHRoaXMgYnkgbWFraW5nIHVzZSBvZiB0aGUgZmFsbGJhY2sgZnVuY3Rpb25z IGZvciBzeXNmcyBwb3B1bGF0aW9uLg0KPiANCj4gRml4ZXM6IGJmNWU3NThmMDJmYyAoImdl bmlycS9tc2k6IFNpbXBsaWZ5IHN5c2ZzIGhhbmRsaW5nIikNCj4gU2lnbmVkLW9mZi1ieTog TWF4aW1pbGlhbiBIZXluZSA8bWhleW5lQGFtYXpvbi5kZT4NCg0KUmV2aWV3ZWQtYnk6IEp1 ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCg0KDQpKdWVyZ2VuDQoNCg== --------------5l1refLpYoFuAkuHwmsfSyyJ Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------5l1refLpYoFuAkuHwmsfSyyJ-- --------------2VgdL2ARHnFdKP06t0hm3NRa-- --------------qUSNF0DqSSSO09uggR0ul3al Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmRZGvgFAwAAAAAACgkQsN6d1ii/Ey93 MQf/cxKVXhKe0gAEAMln7DmZGr6S7zdybp9iDiXoHMLt9maAVZlKd7AoiwoDqsSRJCkaxoZWtPfC 1ShfFUXQrH3X+RXM0xoOZbwErxXDCnT06ZAtV4muq8RUWfw6wTppfnvd0t0WxuYhEtvdbU40zH0u +K26n/zsBHSUygZ6kpnHLvMAI/BarkuOamBar8fkKQ3SxhKdOtpNWSn7UgmyvO0tDyepG3GciLy6 cMrI5ibjjWIOeOJD93KNpihT0QlSlVVfQ2MYr58QUyTmi4VLtIJ2LPI/H6whMc1d399u16pzjpfJ gIE01xfP/1/0PoBJhnL3Y+9LNzY1ZGzF/iKfnTxP7Q== =cQFh -----END PGP SIGNATURE----- --------------qUSNF0DqSSSO09uggR0ul3al-- From xen-devel-bounces@lists.xenproject.org Mon May 08 15:57:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 15:57:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531649.827425 (Exim 4.92) (envelope-from ) id 1pw3En-0002Bl-0X; Mon, 08 May 2023 15:57:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531649.827425; Mon, 08 May 2023 15:57:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw3Em-0002Be-Sr; Mon, 08 May 2023 15:57:20 +0000 Received: by outflank-mailman (input) for mailman id 531649; Mon, 08 May 2023 15:57:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw3El-0002BY-Tr for xen-devel@lists.xenproject.org; Mon, 08 May 2023 15:57:19 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0250432e-edb9-11ed-b226-6b7b168915f2; Mon, 08 May 2023 17:57:18 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id ED6AE21E9C; Mon, 8 May 2023 15:57:17 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BB4481346B; Mon, 8 May 2023 15:57:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id EbczLN0bWWQqOwAAMHmgww (envelope-from ); Mon, 08 May 2023 15:57:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0250432e-edb9-11ed-b226-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683561437; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uJsZCdyVn5207Vye65VsGviklEd6AocSi/qGBd7aHkI=; b=AgB+dU+oP9plsZBFhGD+WPMqLBj8LtSrFz8Z8g1HZIZuZZbycHFYaCWnAtY0KNbh/Cybig ZtQUnMFz3v2c6S/MyUMiXXKSL9ACf8v3Cf7Hhp3Fhosbhb3IVhvKXHwR4w2dlipITC5BVg xvd+S3fAJywGgjvvAPWaXgABg+jnQIo= Message-ID: Date: Mon, 8 May 2023 17:57:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH] xen/pvcalls-back: fix double frees with pvcalls_new_active_socket() Content-Language: en-US To: Dan Carpenter , Stefano Stabellini Cc: Oleksandr Tyshchenko , Boris Ostrovsky , xen-devel@lists.xenproject.org, kernel-janitors@vger.kernel.org References: From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------GQgp9aeO0OpOmH1pBanwsEqn" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------GQgp9aeO0OpOmH1pBanwsEqn Content-Type: multipart/mixed; boundary="------------qLcoMchTk1vUtg8ADvS0YEfR"; protected-headers="v1" From: Juergen Gross To: Dan Carpenter , Stefano Stabellini Cc: Oleksandr Tyshchenko , Boris Ostrovsky , xen-devel@lists.xenproject.org, kernel-janitors@vger.kernel.org Message-ID: Subject: Re: [PATCH] xen/pvcalls-back: fix double frees with pvcalls_new_active_socket() References: In-Reply-To: --------------qLcoMchTk1vUtg8ADvS0YEfR Content-Type: multipart/mixed; boundary="------------XKdA7KkFzwvrNm5B0HXEBVTK" --------------XKdA7KkFzwvrNm5B0HXEBVTK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMDUuMjMgMTc6MTEsIERhbiBDYXJwZW50ZXIgd3JvdGU6DQo+IEluIHRoZSBwdmNh bGxzX25ld19hY3RpdmVfc29ja2V0KCkgZnVuY3Rpb24sIG1vc3QgZXJyb3IgcGF0aHMgY2Fs bA0KPiBwdmNhbGxzX2JhY2tfcmVsZWFzZV9hY3RpdmUoZmVkYXRhLT5kZXYsIGZlZGF0YSwg bWFwKSB3aGljaCBjYWxscw0KPiBzb2NrX3JlbGVhc2UoKSBvbiAic29jayIuICBUaGUgYnVn IGlzIHRoYXQgdGhlIGNhbGxlciBhbHNvIGZyZWVzIHNvY2suDQo+IA0KPiBGaXggdGhpcyBi eSBtYWtpbmcgZXZlcnkgZXJyb3IgcGF0aCBpbiBwdmNhbGxzX25ld19hY3RpdmVfc29ja2V0 KCkNCj4gcmVsZWFzZSB0aGUgc29jaywgYW5kIGRvbid0IGZyZWUgaXQgaW4gdGhlIGNhbGxl ci4NCj4gDQo+IEZpeGVzOiA1ZGI0ZDI4NmE4ZWYgKCJ4ZW4vcHZjYWxsczogaW1wbGVtZW50 IGNvbm5lY3QgY29tbWFuZCIpDQo+IFNpZ25lZC1vZmYtYnk6IERhbiBDYXJwZW50ZXIgPGRh bi5jYXJwZW50ZXJAbGluYXJvLm9yZz4NCg0KUmV2aWV3ZWQtYnk6IEp1ZXJnZW4gR3Jvc3Mg PGpncm9zc0BzdXNlLmNvbT4NCg0KDQpKdWVyZ2VuDQoNCg== --------------XKdA7KkFzwvrNm5B0HXEBVTK Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------XKdA7KkFzwvrNm5B0HXEBVTK-- --------------qLcoMchTk1vUtg8ADvS0YEfR-- --------------GQgp9aeO0OpOmH1pBanwsEqn Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmRZG90FAwAAAAAACgkQsN6d1ii/Ey9p CAf/UjzlrR65HDDHfmlqqsZfml3j7ueSzKVzrj7j4Ak/rlQupbNWb/03mifKyEBPoBJ8+qEV2yhZ VGm1S9mL6iXq4+tJWIwiHEAB+a/JkCREjiMARkT7s3OuFi60SDWIbJJzNeZFk2zf+EhhvKrygjP5 19rB2nfHdjc1kRuHTh8jwUKihsxam/LuprDgq77gN+3HO/Y4AjR+/AIrtGifuza+do4YPc9ECHv4 xrO8kjf04JUQVZsS7vDDNBQc4NJChg/vIFP7P56hJdSjTl+DU5hLqtAldYs2ModCd43J0gGoKyTV rEPYka4jLtmTJFzyLYxwFnMkII2qzV3lcc9pHpb31w== =IZyW -----END PGP SIGNATURE----- --------------GQgp9aeO0OpOmH1pBanwsEqn-- From xen-devel-bounces@lists.xenproject.org Mon May 08 16:24:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 16:24:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531662.827434 (Exim 4.92) (envelope-from ) id 1pw3et-00066X-0s; Mon, 08 May 2023 16:24:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531662.827434; Mon, 08 May 2023 16:24:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw3es-00066Q-UX; Mon, 08 May 2023 16:24:18 +0000 Received: by outflank-mailman (input) for mailman id 531662; Mon, 08 May 2023 16:24:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw3er-00066G-N5; Mon, 08 May 2023 16:24:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw3er-0004Fd-Jq; Mon, 08 May 2023 16:24:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw3er-0008Na-84; Mon, 08 May 2023 16:24:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pw3er-0006IE-7Y; Mon, 08 May 2023 16:24:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7T/Mf8EIeVQAtInc3rUYrcfmXoVWfLE/3x/1YA1UFkg=; b=RBjTSEB5GemIBRusAkzl42JITy awyInhWcIVNAdfW4IQ1qFsBgz1ZKkHEn6Df+U72zBvUtfmELqHRU1JKMTA/2Y0ceZX8UDjWu/dmqX bsJ25w62o2b2xJWkknsDzTCLOsZgDanXxpAkWJFFu2AELatJgRbKhN2cMCgBaDCsmSbo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180579: all pass - PUSHED X-Osstest-Versions-This: ovmf=6eeb58ece38060be3b0f7111649a93cc8b2dca49 X-Osstest-Versions-That: ovmf=d89492456f79e014679cb6c29b144ea26b910918 From: osstest service owner Date: Mon, 08 May 2023 16:24:17 +0000 flight 180579 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180579/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 6eeb58ece38060be3b0f7111649a93cc8b2dca49 baseline version: ovmf d89492456f79e014679cb6c29b144ea26b910918 Last test of basis 180575 2023-05-08 11:43:41 Z 0 days Testing same since 180579 2023-05-08 13:40:39 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Minh Nguyen Nhi Pham Vu Nguyen jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git d89492456f..6eeb58ece3 6eeb58ece38060be3b0f7111649a93cc8b2dca49 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon May 08 16:46:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 16:46:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531668.827444 (Exim 4.92) (envelope-from ) id 1pw40S-00009X-P5; Mon, 08 May 2023 16:46:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531668.827444; Mon, 08 May 2023 16:46:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw40S-00009Q-MJ; Mon, 08 May 2023 16:46:36 +0000 Received: by outflank-mailman (input) for mailman id 531668; Mon, 08 May 2023 16:46:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw40Q-000094-Mv for xen-devel@lists.xenproject.org; Mon, 08 May 2023 16:46:34 +0000 Received: from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de [85.215.255.23]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e2bcf59e-edbf-11ed-b226-6b7b168915f2; Mon, 08 May 2023 18:46:32 +0200 (CEST) Received: from sender by smtp.strato.de (RZmta 49.4.0 AUTH) with ESMTPSA id x6987cz48GkL1ei (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Mon, 8 May 2023 18:46:21 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e2bcf59e-edbf-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1683564381; cv=none; d=strato.com; s=strato-dkim-0002; b=aQOBJvQhWb1t5tnqeVzHgWO/YtjOx3rNfKHaYf6UwWeC+MkYJiCW6nVylCffa88lSq rxywtfvj3AtpTtoxlKpAeE4d7M7PP7Jpm/WbNNNcb73Ij/TqE2erALOQFRhZcwmgtt6x Mjhg75RwKlvhrs0+85eJmM+nVXGzhGsJ1XrhOP5Y0zXGoj3blIyezNeI45wgpqvuOk9p AD7tSc+6GhenaDRaGJaO+oiPusdN7s/FMVw0+oRj4hoeDUcNWNYoyPMOF6qQUJWpOBHG jyayKvdqHKxnVoPxjQJapLW/IHBC5li5C7gPqcf2HYrd8c1PQfjUGkIAuAmKHcb38HoR cgJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1683564381; s=strato-dkim-0002; d=strato.com; h=Message-Id:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=ckiWL2I0mA50zkvrZeK7N1+RfhrIURHzeKf776Hu3nE=; b=sA2c/UTSPr2n7ftMly/N4kZ+4i/RdAraMSv6OKQJzoMMS31a4YiFXk317NdQ8JDecl UZ3YSpJiHy4jOftrucQE2aQwBKabxU/6Mg86o/MfTEktpulYnCrA7ngx18K8YJ77gPkF VcB3npY+fxOlecInxj2vvi026+WWT2z/rOzFnVQjfCNjXeTnpza3x/GBuYUsV5L/2qUa KhDA1kudFXhh8eMON1SO2Vlb9IHdbexSPZwtOh3HjlI1sppc0BI/FEEw9UzINc3agVbZ KuVMnRfa1JoWmeg0klSPaOyyt6lvUt6NsboUaR+VItTy7lxuhOGUSwd7l7lrYt3cI9TU DBmw== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1683564381; s=strato-dkim-0002; d=aepfle.de; h=Message-Id:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=ckiWL2I0mA50zkvrZeK7N1+RfhrIURHzeKf776Hu3nE=; b=DYlKtcZN7zjBC8XassEpnx4dkpk7e+6kblL6C/sXsfFuSVud0v/JrJWX0/jFftfBNB EQeYLWdSZ3xsZ/WJfX0hz/gA5177SlhTDVIx3qo40NVDsNmMiDickNOZWWDt1Vw6+Uh6 SvgFrMp4rP2ik9yU5YUcD4szOKk3myQheW9DQTPuvCKUjdUzHBoRHJ1dMDsY53UuRiUq 27NNBL2ui3LtZN7Kb6ZQSI5kZSZ5qRYHtZgT5EOKBMLGh2mbGDdSGdP44WlhGzOg8IxW jmkSnshwncGbb/Q7VO/lZW7t1AF8l8nhXMaLC45fp1m8xgIWfIpPIGWeskhPLyzyvfZY /6+Q== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1683564381; s=strato-dkim-0003; d=aepfle.de; h=Message-Id:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=ckiWL2I0mA50zkvrZeK7N1+RfhrIURHzeKf776Hu3nE=; b=R/ogvXlolyxT7xoTrk9JeByV/QKhwCZGA0U4eQmaLX3o5UhMKPO6iBpLAuUruMwFvW odSG+o0vcbpzzlmCDfCQ== X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg4xr137Gpot26qU4O0oDB37weYobhAHKAaiA4NsOg==" From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD , Juergen Gross , George Dunlap Subject: [PATCH v2] tools: convert bitfields to unsigned type Date: Mon, 8 May 2023 16:46:18 +0000 Message-Id: <20230508164618.21496-1-olaf@aepfle.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="us-ascii" clang complains about the signed type: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Wsingle-bit-bitfield-constant-conversion] The potential ABI change in libxenvchan is covered by the Xen version based SONAME. Signed-off-by: Olaf Hering --- v2: cover one more case in xenalyze tools/include/libxenvchan.h | 6 +++--- tools/xentrace/xenalyze.c | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/tools/include/libxenvchan.h b/tools/include/libxenvchan.h index 30cc73cf97..3d3b8aa8dd 100644 --- a/tools/include/libxenvchan.h +++ b/tools/include/libxenvchan.h @@ -79,11 +79,11 @@ struct libxenvchan { xenevtchn_handle *event; uint32_t event_port; /* informative flags: are we acting as server? */ - int is_server:1; + unsigned int is_server:1; /* true if server remains active when client closes (allows reconnection) */ - int server_persist:1; + unsigned int server_persist:1; /* true if operations should block instead of returning 0 */ - int blocking:1; + unsigned int blocking:1; /* communication rings */ struct libxenvchan_ring read, write; /** diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c index 12dcca9646..a50538e9a8 100644 --- a/tools/xentrace/xenalyze.c +++ b/tools/xentrace/xenalyze.c @@ -1377,7 +1377,7 @@ struct hvm_data { tsc_t exit_tsc, arc_cycles, entry_tsc; unsigned long long rip; unsigned exit_reason, event_handler; - int short_summary_done:1, prealloc_unpin:1, wrmap_bf:1; + unsigned int short_summary_done:1, prealloc_unpin:1, wrmap_bf:1; /* Immediate processing */ void *d; @@ -8235,13 +8235,13 @@ void mem_set_p2m_entry_process(struct pcpu_info *p) struct { uint64_t gfn, mfn; - int p2mt; - int d:16,order:16; + uint32_t p2mt; + uint16_t d, order; } *r = (typeof(r))ri->d; if ( opt.dump_all ) { - printf(" %s set_p2m_entry d%d o%d t %d g %llx m %llx\n", + printf(" %s set_p2m_entry d%u o%u t %u g %llx m %llx\n", ri->dump_header, r->d, r->order, r->p2mt, From xen-devel-bounces@lists.xenproject.org Mon May 08 17:15:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 17:15:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531682.827454 (Exim 4.92) (envelope-from ) id 1pw4Ro-0003dl-TF; Mon, 08 May 2023 17:14:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531682.827454; Mon, 08 May 2023 17:14:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw4Ro-0003de-Pm; Mon, 08 May 2023 17:14:52 +0000 Received: by outflank-mailman (input) for mailman id 531682; Mon, 08 May 2023 17:14:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw4Rn-0003cn-K1 for xen-devel@lists.xenproject.org; Mon, 08 May 2023 17:14:51 +0000 Received: from mo4-p01-ob.smtp.rzone.de (mo4-p01-ob.smtp.rzone.de [85.215.255.53]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d70ff816-edc3-11ed-b226-6b7b168915f2; Mon, 08 May 2023 19:14:50 +0200 (CEST) Received: from sender by smtp.strato.de (RZmta 49.4.0 AUTH) with ESMTPSA id x6987cz48HEj1iE (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Mon, 8 May 2023 19:14:45 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d70ff816-edc3-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1683566085; cv=none; d=strato.com; s=strato-dkim-0002; b=tE6YHuHy5lVgdjuDoGDmTwSBgXKtuS1zDa+h/S810xaL3xbUpjKNwYeQHYaBy2RvFl XpZuEd8VLlxKqHAEIc6ga5n58BAziTQas967IHhukhcGU0EDv2VsvjZ7VEaqrihJ2Y9/ i0Vh4ngEwa0bPncFQPvXLsOHMVorH7YoZ/dzlDlOWjPIgm8mif3tAGTWiCrnKCCsRpx5 3p479Zye8lgUFoWvbLH1feNVbJbESCTKFSG1ntDBw8jU7975kRDXEu7X0WX7prpco4nY 8IA6BOJYLF39Ln+EoVt4zk6X+h1daiCLOmcQ3KbsYczTIh/wB+29XuPf70rWREdCAzxP zuOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1683566085; s=strato-dkim-0002; d=strato.com; h=Message-Id:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=y0EEjOUz8ZL2cVZEIRcJ/bDf+Ceoz247L+uHTHcTrAo=; b=b05BlS4jHDUWuizJL3NhuJotZtOLwERDH4ZMFsEmvbs1CocwbRm41A3tZEBaDUksS1 bObD3J8ePYHUk56GTqUyNvuIIyr0TpW5RGBlTbFg2B+8kZ1iKGYar6S9pIcE4v2EoUEQ Aiif6AdOVQ2p43r4o49yQt8SkH3UCdRzJGUEJWmir2/yaSTfISyhavMHQmrOrdzTssTL Uy+8oDr+ixK9Q8+QuM/NvGZlMiF9/OM7ERoOIn7MdwiqlqeRQq061xtFbRdponjbMUyj par6x6S8IudAulCdUcHgTeeAc3I/J5elU9eXBxQl5yTrnaQwhbczQ43Nu5CdN53R0mnr 5qZg== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo01 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1683566085; s=strato-dkim-0002; d=aepfle.de; h=Message-Id:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=y0EEjOUz8ZL2cVZEIRcJ/bDf+Ceoz247L+uHTHcTrAo=; b=WfTnRdjagb5Qlqlvp773aVY/NuQaV7jGY/PlS4dKa71IgRcOYO6ew27kbArysI/G4B NBRDn20uoaNrc2WE+6ct3b07XSY+Eoa/8cKTCYhlLLZhNWGaTLBR2TL8/TFPfD+ATE/0 bwCc52HlIp3OxyY0qeId8K1ML943XhRviSODWacIDH44dHDBWemI/90VI1gNvxd5moF3 T8Xq2hYL9hi0hZGiVXsvkdRGXIB+RIRQqYV71l+1Aa8nN9VqmR4okXlvqENWBrs8AphC SfYsqLG4ToE8gaC/ITXOTvYJCXu3m+WyZLHmMWfgBelPihBJsltJyS2mJYNi+wQ2M48c HlOQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1683566085; s=strato-dkim-0003; d=aepfle.de; h=Message-Id:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=y0EEjOUz8ZL2cVZEIRcJ/bDf+Ceoz247L+uHTHcTrAo=; b=mCQQC+FJHISBFELfPTHBHvCVe1SjmVm6K6kDqRAgGoenlST0+wBHtE71uQq1U4//KB rFjD9jOEkEWyFKMDY4Bg== X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg4xr137Gpot26qU4O0oDB37weYobhAHKAaiA4NsOg==" From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Wei Liu , Anthony PERARD Subject: [PATCH v2] Fix install.sh for systemd Date: Mon, 8 May 2023 17:14:37 +0000 Message-Id: <20230508171437.27424-1-olaf@aepfle.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="us-ascii" On a fedora system, if you run `sudo sh install.sh` you break your system. The installation clobbers /var/run, a symlink to /run. A subsequent boot fails when /var/run and /run are different since accesses through /var/run can't find items that now only exist in /run and vice-versa. Skip populating /var/run/xen during make install. The directory is already created by some scripts. Adjust all remaining scripts to create XEN_RUN_DIR at runtime. XEN_RUN_STORED is covered by XEN_RUN_DIR because xenstored is usually started afterwards. Reported-by: Jason Andryuk Signed-off-by: Olaf Hering --- tools/Makefile | 2 -- tools/hotplug/FreeBSD/rc.d/xencommons.in | 1 + tools/hotplug/FreeBSD/rc.d/xendriverdomain.in | 1 + tools/hotplug/Linux/init.d/xendriverdomain.in | 1 + tools/hotplug/Linux/systemd/xenconsoled.service.in | 2 +- tools/hotplug/NetBSD/rc.d/xendriverdomain.in | 2 +- 6 files changed, 5 insertions(+), 4 deletions(-) diff --git a/tools/Makefile b/tools/Makefile index 4906fdbc23..1ff90ddfa0 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -58,9 +58,7 @@ build all: subdirs-all install: $(INSTALL_DIR) -m 700 $(DESTDIR)$(XEN_DUMP_DIR) $(INSTALL_DIR) $(DESTDIR)$(XEN_LOG_DIR) - $(INSTALL_DIR) $(DESTDIR)$(XEN_RUN_DIR) $(INSTALL_DIR) $(DESTDIR)$(XEN_LIB_DIR) - $(INSTALL_DIR) $(DESTDIR)$(XEN_RUN_STORED) $(INSTALL_DIR) $(DESTDIR)$(PKG_INSTALLDIR) $(MAKE) subdirs-install diff --git a/tools/hotplug/FreeBSD/rc.d/xencommons.in b/tools/hotplug/FreeBSD/rc.d/xencommons.in index 7f7cda289f..1cf217d418 100644 --- a/tools/hotplug/FreeBSD/rc.d/xencommons.in +++ b/tools/hotplug/FreeBSD/rc.d/xencommons.in @@ -34,6 +34,7 @@ xen_startcmd() local time=0 local timeout=30 + mkdir -p "@XEN_RUN_DIR@" xenstored_pid=$(check_pidfile ${XENSTORED_PIDFILE} ${XENSTORED}) if test -z "$xenstored_pid"; then printf "Starting xenservices: xenstored, xenconsoled." diff --git a/tools/hotplug/FreeBSD/rc.d/xendriverdomain.in b/tools/hotplug/FreeBSD/rc.d/xendriverdomain.in index a032822e33..030d104024 100644 --- a/tools/hotplug/FreeBSD/rc.d/xendriverdomain.in +++ b/tools/hotplug/FreeBSD/rc.d/xendriverdomain.in @@ -27,6 +27,7 @@ xendriverdomain_start() { printf "Starting xenservices: xl devd." + mkdir -p "@XEN_RUN_DIR@" PATH="${bindir}:${sbindir}:$PATH" ${sbindir}/xl devd --pidfile ${XLDEVD_PIDFILE} ${XLDEVD_ARGS} printf "\n" diff --git a/tools/hotplug/Linux/init.d/xendriverdomain.in b/tools/hotplug/Linux/init.d/xendriverdomain.in index c63060f62a..1055d0b942 100644 --- a/tools/hotplug/Linux/init.d/xendriverdomain.in +++ b/tools/hotplug/Linux/init.d/xendriverdomain.in @@ -49,6 +49,7 @@ fi do_start () { echo Starting xl devd... + mkdir -m700 -p @XEN_RUN_DIR@ ${sbindir}/xl devd --pidfile=$XLDEVD_PIDFILE $XLDEVD_ARGS } do_stop () { diff --git a/tools/hotplug/Linux/systemd/xenconsoled.service.in b/tools/hotplug/Linux/systemd/xenconsoled.service.in index 1f03de9041..d84c09aa9c 100644 --- a/tools/hotplug/Linux/systemd/xenconsoled.service.in +++ b/tools/hotplug/Linux/systemd/xenconsoled.service.in @@ -11,7 +11,7 @@ Environment=XENCONSOLED_TRACE=none Environment=XENCONSOLED_LOG_DIR=@XEN_LOG_DIR@/console EnvironmentFile=-@CONFIG_DIR@/@CONFIG_LEAF_DIR@/xencommons ExecStartPre=/bin/grep -q control_d /proc/xen/capabilities -ExecStartPre=/bin/mkdir -p ${XENCONSOLED_LOG_DIR} +ExecStartPre=/bin/mkdir -p ${XENCONSOLED_LOG_DIR} @XEN_RUN_DIR@ ExecStart=@sbindir@/xenconsoled -i --log=${XENCONSOLED_TRACE} --log-dir=${XENCONSOLED_LOG_DIR} $XENCONSOLED_ARGS [Install] diff --git a/tools/hotplug/NetBSD/rc.d/xendriverdomain.in b/tools/hotplug/NetBSD/rc.d/xendriverdomain.in index f47b0b189c..23a5352502 100644 --- a/tools/hotplug/NetBSD/rc.d/xendriverdomain.in +++ b/tools/hotplug/NetBSD/rc.d/xendriverdomain.in @@ -23,7 +23,7 @@ XLDEVD_PIDFILE="@XEN_RUN_DIR@/xldevd.pid" xendriverdomain_precmd() { - : + mkdir -p "@XEN_RUN_DIR@" } xendriverdomain_startcmd() From xen-devel-bounces@lists.xenproject.org Mon May 08 17:17:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 17:17:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531687.827464 (Exim 4.92) (envelope-from ) id 1pw4U6-0004CF-8W; Mon, 08 May 2023 17:17:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531687.827464; Mon, 08 May 2023 17:17:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw4U6-0004C8-5e; Mon, 08 May 2023 17:17:14 +0000 Received: by outflank-mailman (input) for mailman id 531687; Mon, 08 May 2023 17:17:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw4U4-0004C2-TP for xen-devel@lists.xenproject.org; Mon, 08 May 2023 17:17:12 +0000 Received: from mo4-p02-ob.smtp.rzone.de (mo4-p02-ob.smtp.rzone.de [85.215.255.82]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2b8a7262-edc4-11ed-b226-6b7b168915f2; Mon, 08 May 2023 19:17:12 +0200 (CEST) Received: from sender by smtp.strato.de (RZmta 49.4.0 AUTH) with ESMTPSA id x6987cz48HH81ia (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Mon, 8 May 2023 19:17:08 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2b8a7262-edc4-11ed-b226-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1683566228; cv=none; d=strato.com; s=strato-dkim-0002; b=W5kIyWZBRtirVB8R8ABRp+GuE5Wdlf/KkMElpiFRHAMl2TRgu409DRaik8UZw4yFGA yQf9a4wkZpC5JiSKUQF7fVv3BZX8Ytg5tHqBWdA1/hK0Jm/NfQ83S1BZfFAFDqDQz93k pXP0Z8Wm7W69gVy9kZsoXWbmpdxn6dXbolcUIH3py5K+u2oskLf9p9IipiwzZXVhN97c cRqh/5Ye3oql+1/dUnpZq31cnE2t8q/cIWar5JH6Bw5j18k8xN0MjLP+d5D88oeLgWQq KDrrRyPki4+isDRxIpfX6QJf61lfjzDz04C0GTg2qow2rHm1ulMZxy91fXEydMVOclQP YdMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1683566228; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=JJjjfI8cGGCBUnmE7uP1IovAWHC+stQjDcKDTynV5EM=; b=anb+H1BggY9Al/43BWLcTC6X3IacWo/qQC4SmycI/M9NADwN4GrV4JoUpnxeo24WRd r/ucRm0likxPTCNxVPO/V8tcGo6V3MA5w/PbmVa+0+nwnxS3rJferrioafr2A5XXfdwA sK51kyLMgCO8gvpTs91SvPRyjByZT4iX1L6WNI7lqIWu8ZxR3VW2Vun8ScM4S/9YNPBy gcLzH87e4K6F4Kqnd7L84QKzb8fguresfuLOBS3ykjqFcJRHnLoyXK+XOK4kr/kLHSs6 8ILHMf9hE8bjPc3g03O/hGhmjVPF6XrzBQwi3v6D5gDl/mYNnat3bgTOxxoF5/HJbAOF 1C5Q== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo02 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1683566228; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=JJjjfI8cGGCBUnmE7uP1IovAWHC+stQjDcKDTynV5EM=; b=tEAdgWKY31K7pXA5G0cggg6Y4/f8HBazh+jQCxX7I8ez45pRqBiwcrdNJ7R8MAMVup JdG7DyBG26j1slFLo87EuG4HPfaK/2l6IdnXYVyAYIRwIR5qvj+ktiHmFMwXFq6ALsAQ TjDCsaHPMokqOHPDrv4ljRAqQpzXBqVSwUPzlIskyVCGyCenMT53ZK3dYPh9e78Wf6c3 YYTvmQ0BIKSj6MjGIOZvMFCW+M/kEBgoEImNphIasmA9XSKAWR6SYCUiWpirrqDkUa90 +ISilLlNm7Un2ghGS960EeZDZhHmbIOQYf8XHnPTPYqym7QVSeoS8woIkm7GB1lTgugo q3rQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1683566228; s=strato-dkim-0003; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=JJjjfI8cGGCBUnmE7uP1IovAWHC+stQjDcKDTynV5EM=; b=W9ktGnwlemDpkX5JnkPK040mp1hkOagfgwP/AQz/vdF6GheLbB8plTGXInrSFpgpRI Qaeo7Cbqb5ErMQRGPRCg== X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisR4ARWIYxzstZKeVom+bauo0LKSCjuo5iX5xLikmg==" Date: Mon, 8 May 2023 19:17:06 +0200 From: Olaf Hering To: Jason Andryuk Cc: Jan Beulich , xen-devel@lists.xenproject.org, Wei Liu , Anthony PERARD Subject: Re: [PATCH] Fix install.sh for systemd Message-ID: <20230508191706.52cd21f4.olaf@aepfle.de> In-Reply-To: References: <20230425194622.114869-1-jandryuk@gmail.com> <20230426091533.68324d8d.olaf@aepfle.de> <650a7f6e-be82-0312-05f2-bb69e51e828d@suse.com> <20230426104754.78845a19.olaf@aepfle.de> <9dfb4f01-979e-e225-214e-34ddb51a9199@suse.com> <20230426124051.24c2a9a6.olaf@aepfle.de> X-Mailer: Claws Mail 20230504T161344.b05adb60 hat ein Softwareproblem, kann man nichts machen. MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/kem2mED/kyqZYZrf0a0a5uZ"; protocol="application/pgp-signature"; micalg=pgp-sha256 Content-Transfer-Encoding: 7bit --Sig_/kem2mED/kyqZYZrf0a0a5uZ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Wed, 26 Apr 2023 09:31:44 -0400 Jason Andryuk : > On Wed, Apr 26, 2023 at 6:40=E2=80=AFAM Olaf Hering wrot= e: > > +++ b/tools/hotplug/Linux/init.d/xendriverdomain.in > > @@ -49,6 +49,7 @@ fi > > > > do_start () { > > echo Starting xl devd... > > + mkdir -m700 -p ${XEN_RUN_DIR} =20 > This one should be "@XEN_RUN_DIR@"? I changed it, it was a result of copy&paste from another file. Since hotplug.sh is included in many scripts, all such users could be conve= rted to a shell variable. But this would be a separate change. Olaf --Sig_/kem2mED/kyqZYZrf0a0a5uZ Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmRZLpIACgkQ86SN7mm1 DoDHRw//SmBrqDmjqaXIMqVXSNyzP2zU33erPjdoQixcOeigyLisfJZUMfCDSnOV oWKgd6wsEIdNP/0iXfoXwXwL8LYfM16gIaJ40SJ8ZFryTF4TC9Z1ySnJPp1rfjG+ R5/j/4caUJA0BW3mKAtENZ1YScQU2vM76IgeXcXfxIOhZLKnfFiolXI02ZR16OR9 kRrR0H3JisqEvv60xj8J1D2y4mUw3nbnB6Bim1Aqnyby/XuJP6DbZPtSmsGUhg4a KNTtu137lZELkE4t1H55zlUFle/d/s0JLu1qstD6O633K/DbemPME6mNaDrrE74k 8MgHpM2nsEpPcnnpSxzwSfSv8tk8pOnO+i/LBjZaTQq0uqTlWcLVzxP87ffb/qgT oGe8Qx/stp7H5rL4OOXl0GhlSyTgcEDvJhckg+FIk9wJ2riGEvs6Kr3aXj29PDTi EjFO6D7y9V+txzdtu+xyxkHBcXYEZJvAlyEf4QFcndq1F9pSdoguMcT/Jwwd6HoG C2RCX5SSykX0nDqE56RhAG6v2uqppk1bbrInpogMJxUWssB5FWNn/x2SWJY3UBO9 WOHfHdfM6faZSj2dmbps6YJEf8yUaYpQ9Ux+21Vq3POyaJU/R3iBkcd/1ayaAOef FFIMgLJmtWkJ17+Btip0y0zz0YQFpLddeqsg1G6vmlAmS/woLDw= =VZWr -----END PGP SIGNATURE----- --Sig_/kem2mED/kyqZYZrf0a0a5uZ-- From xen-devel-bounces@lists.xenproject.org Mon May 08 17:30:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 17:30:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531694.827475 (Exim 4.92) (envelope-from ) id 1pw4gF-0005kq-CA; Mon, 08 May 2023 17:29:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531694.827475; Mon, 08 May 2023 17:29:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw4gF-0005kj-8n; Mon, 08 May 2023 17:29:47 +0000 Received: by outflank-mailman (input) for mailman id 531694; Mon, 08 May 2023 17:29:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw4gE-0005kd-BZ for xen-devel@lists.xenproject.org; Mon, 08 May 2023 17:29:46 +0000 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ebfd1c59-edc5-11ed-b226-6b7b168915f2; Mon, 08 May 2023 19:29:45 +0200 (CEST) Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-6439bbc93b6so3004198b3a.1 for ; Mon, 08 May 2023 10:29:45 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([20.69.120.36]) by smtp.gmail.com with ESMTPSA id i4-20020aa787c4000000b0063d2d9990ecsm232036pfo.87.2023.05.08.10.29.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 May 2023 10:29:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ebfd1c59-edc5-11ed-b226-6b7b168915f2 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683566983; x=1686158983; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3rfke9qB1DRHiCuMEOyzzXuV8oi0P7zjijqnIYynp3o=; b=PXcyir2XDkklOuGPiNzcz5Kv++6+ZR18LlHpIM5iK2H/hLAGM6dLX8P3ym0awZFide hyl3t4W+OWFLBV9Pdp9aqsiq+4xZmRRWwA3TxhTfX+t5zusnI7K9+rSNVDjcTqxZqXdH 5/8OPK7mgTLz0RSFtEPsSBOsaU9gsids09s9zpPzlDsHr3pyToTQLjhfl6ymlXCdxUfJ yCDN7xJld0ez525YX03T0zOgnCkp02Uxnb42EH/3Crfk/jDbROadD1lj4EggnwZBmGAj Ex4VH3ZAxsfi9VCsYKXZUhoKAuM+5etoDw3GYPKuBzmtXOklDfV65eZTcxzo5xQOM8XJ hWdg== X-Gm-Message-State: AC+VfDymeHvftx864ayDzXBbxi/zFeL18p0LeMQ4/iIom4ZFn+DkXROx APk6uaoIEMURJMP40pfxS+k= X-Google-Smtp-Source: ACHHUZ75U4lCk4iijzyP5tOZ0JsVrz/EkvkWJ7HQDBXg3iSt23KVdFrierjfNZySz59EZ1uNpntsKQ== X-Received: by 2002:a05:6a20:a107:b0:ff:7c74:a799 with SMTP id q7-20020a056a20a10700b000ff7c74a799mr11302220pzk.9.1683566983497; Mon, 08 May 2023 10:29:43 -0700 (PDT) Date: Mon, 8 May 2023 17:29:41 +0000 From: Wei Liu To: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= Cc: Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Ingo Molnar , Kees Cook , Paolo Bonzini , Sean Christopherson , Thomas Gleixner , Vitaly Kuznetsov , Wanpeng Li , Alexander Graf , Forrest Yuan Yu , James Morris , John Andersen , Liran Alon , "Madhavan T . Venkataraman" , Marian Rotariu , Mihai =?utf-8?B?RG9uyJt1?= , =?utf-8?B?TmljdciZb3IgQ8OuyJt1?= , Rick Edgecombe , Thara Gopinath , Will Deacon , Zahra Tarkhani , =?utf-8?Q?=C8=98tefan_=C8=98icleru?= , dev@lists.cloudhypervisor.org, kvm@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, x86@kernel.org, xen-devel@lists.xenproject.org, Wei Liu Subject: Re: [PATCH v1 3/9] virt: Implement Heki common code Message-ID: References: <20230505152046.6575-1-mic@digikod.net> <20230505152046.6575-4-mic@digikod.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230505152046.6575-4-mic@digikod.net> On Fri, May 05, 2023 at 05:20:40PM +0200, Mickal Salan wrote: > From: Madhavan T. Venkataraman > > Hypervisor Enforced Kernel Integrity (Heki) is a feature that will use > the hypervisor to enhance guest virtual machine security. > > Configuration > ============= > > Define the config variables for the feature. This feature depends on > support from the architecture as well as the hypervisor. > > Enabling HEKI > ============= > > Define a kernel command line parameter "heki" to turn the feature on or > off. By default, Heki is on. For such a newfangled feature can we have it off by default? Especially when there are unsolved issues around dynamically loaded code. > [...] > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 3604074a878b..5cf5a7a97811 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -297,6 +297,7 @@ config X86 > select FUNCTION_ALIGNMENT_4B > imply IMA_SECURE_AND_OR_TRUSTED_BOOT if EFI > select HAVE_DYNAMIC_FTRACE_NO_PATCHABLE > + select ARCH_SUPPORTS_HEKI if X86_64 Why is there a restriction on X86_64? > > config INSTRUCTION_DECODER > def_bool y > diff --git a/arch/x86/include/asm/sections.h b/arch/x86/include/asm/sections.h > index a6e8373a5170..42ef1e33b8a5 100644 > --- a/arch/x86/include/asm/sections.h > +++ b/arch/x86/include/asm/sections.h [...] > > +#ifdef CONFIG_HEKI > + > +/* > + * Gather all of the statically defined sections so heki_late_init() can > + * protect these sections in the host page table. > + * > + * The sections are defined under "SECTIONS" in vmlinux.lds.S > + * Keep this array in sync with SECTIONS. > + */ This seems a bit fragile, because it requires constant attention from people who care about this functionality. Can this table be automatically generated? Thanks, Wei. > +struct heki_va_range __initdata heki_va_ranges[] = { > + { > + .va_start = _stext, > + .va_end = _etext, > + .attributes = HEKI_ATTR_MEM_NOWRITE | HEKI_ATTR_MEM_EXEC, > + }, > + { > + .va_start = __start_rodata, > + .va_end = __end_rodata, > + .attributes = HEKI_ATTR_MEM_NOWRITE, > + }, > +#ifdef CONFIG_UNWINDER_ORC > + { > + .va_start = __start_orc_unwind_ip, > + .va_end = __stop_orc_unwind_ip, > + .attributes = HEKI_ATTR_MEM_NOWRITE, > + }, > + { > + .va_start = __start_orc_unwind, > + .va_end = __stop_orc_unwind, > + .attributes = HEKI_ATTR_MEM_NOWRITE, > + }, > + { > + .va_start = orc_lookup, > + .va_end = orc_lookup_end, > + .attributes = HEKI_ATTR_MEM_NOWRITE, > + }, > +#endif /* CONFIG_UNWINDER_ORC */ > +}; > + From xen-devel-bounces@lists.xenproject.org Mon May 08 19:43:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:43:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531750.827566 (Exim 4.92) (envelope-from ) id 1pw6lp-0005wj-8s; Mon, 08 May 2023 19:43:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531750.827566; Mon, 08 May 2023 19:43:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6lp-0005vp-1q; Mon, 08 May 2023 19:43:41 +0000 Received: by outflank-mailman (input) for mailman id 531750; Mon, 08 May 2023 19:43:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6ln-0004GB-6u for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:43:39 +0000 Received: from galois.linutronix.de (galois.linutronix.de [2a0a:51c0:0:12e:550::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a0e19a96-edd8-11ed-b226-6b7b168915f2; Mon, 08 May 2023 21:43:38 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a0e19a96-edd8-11ed-b226-6b7b168915f2 Message-ID: <20230508185217.618219949@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575018; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=Nq+EVjEHwGvHRlseUbUpbAQd2uYa+p7t28i6JGIOJ78=; b=l050jCE5Rr8v/gugpUq1Ss+TlvOTAU6bHW5tmCokiaoqtw5CJrnjAQqxTBqzm46r10H8V/ PN/C85twXsUJTaTtz1N6lrClgA/Gywes1nzaKTKsIwa99M6sRy4sGklJiGciZ0ImlUVQ80 BCh6GCvig4h53NBkh/6pnZ/bEmQ5POZmqaNW5u1zjMqAwqiP+mkv0AM8PZR2tBTf7vMFzv Vk5CiVSe4cZsa28TSPkqrniRc0oqqy9ISXDKayjUa0EChnVUegmMMNAcBSr7NGh9c0+rJ5 gYcfpjceJWyADjwArci8tisYfWTvchOJq06bNOx2RJdGtIqY/RHVI8A1x+wuBg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575018; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=Nq+EVjEHwGvHRlseUbUpbAQd2uYa+p7t28i6JGIOJ78=; b=OBLEtPDPwv/0EcuR38ddNfg8WWZsz2t8tgAu+g3ffoBnaypodVLNrO9gR6tjF5qfnG9zHm 9+H9v5nuCGMGmXAw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch v3 07/36] x86/smpboot: Restrict soft_restart_cpu() to SEV References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:43:37 +0200 (CEST) From: Thomas Gleixner Now that the CPU0 hotplug cruft is gone, the only user is AMD SEV. Signed-off-by: Thomas Gleixner Tested-by: Michael Kelley --- arch/x86/kernel/callthunks.c | 2 +- arch/x86/kernel/head_32.S | 14 -------------- arch/x86/kernel/head_64.S | 2 +- 3 files changed, 2 insertions(+), 16 deletions(-) --- --- a/arch/x86/kernel/callthunks.c +++ b/arch/x86/kernel/callthunks.c @@ -133,7 +133,7 @@ static bool skip_addr(void *dest) /* Accounts directly */ if (dest == ret_from_fork) return true; -#ifdef CONFIG_HOTPLUG_CPU +#if defined(CONFIG_HOTPLUG_CPU) && defined(CONFIG_AMD_MEM_ENCRYPT) if (dest == soft_restart_cpu) return true; #endif --- a/arch/x86/kernel/head_32.S +++ b/arch/x86/kernel/head_32.S @@ -138,20 +138,6 @@ SYM_CODE_START(startup_32) jmp .Ldefault_entry SYM_CODE_END(startup_32) -#ifdef CONFIG_HOTPLUG_CPU -/* - * Entry point for soft restart of a CPU. Invoked from xxx_play_dead() for - * restarting the boot CPU or for restarting SEV guest CPUs after CPU hot - * unplug. Everything is set up already except the stack. - */ -SYM_FUNC_START(soft_restart_cpu) - movl initial_stack, %ecx - movl %ecx, %esp - call *(initial_code) -1: jmp 1b -SYM_FUNC_END(soft_restart_cpu) -#endif - /* * Non-boot CPU entry point; entered from trampoline.S * We can't lgdt here, because lgdt itself uses a data segment, but --- a/arch/x86/kernel/head_64.S +++ b/arch/x86/kernel/head_64.S @@ -375,7 +375,7 @@ SYM_CODE_END(secondary_startup_64) #include "verify_cpu.S" #include "sev_verify_cbit.S" -#ifdef CONFIG_HOTPLUG_CPU +#if defined(CONFIG_HOTPLUG_CPU) && defined(CONFIG_AMD_MEM_ENCRYPT) /* * Entry point for soft restart of a CPU. Invoked from xxx_play_dead() for * restarting the boot CPU or for restarting SEV guest CPUs after CPU hot From xen-devel-bounces@lists.xenproject.org Mon May 08 19:43:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:43:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531749.827562 (Exim 4.92) (envelope-from ) id 1pw6lo-0005td-SD; Mon, 08 May 2023 19:43:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531749.827562; Mon, 08 May 2023 19:43:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6lo-0005tS-OT; Mon, 08 May 2023 19:43:40 +0000 Received: by outflank-mailman (input) for mailman id 531749; Mon, 08 May 2023 19:43:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6lm-0004Y5-Ro for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:43:38 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9feb5f3f-edd8-11ed-8611-37d641c3527e; Mon, 08 May 2023 21:43:37 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9feb5f3f-edd8-11ed-8611-37d641c3527e Message-ID: <20230508185217.564850214@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=dWwLkoa+CxUjsSK7qf2Y5jZ2cGq23YEvo1MW7nbjWN0=; b=Lbsq5RCoehz/zeQ46Kql0DxBJ16qoGQI1FM4XaAZJbLbjajj7ITHBDJGs95sO0pMop0NoQ 7f4Rhr7rPQAc/6P66xjPMduhyAGVTekvjPLIl4pGJBWHVmMSCtw2Den9wSosh90IVyneVN d0wYFDA8BRyvXCF0AlMOKoc/w2SrWhQdphMR4YYOq67IfoCSmiWvqziIPGaTXrjFLVNYT5 v2aExqc7xj8oXY+cp3ngOjhAtQEX6T8jphKJj54KFkmr8IOd75w8gei4vtXfH0pQZXJnmF FjzIikFSa9a+embThcwnko4mbExq6fkzBS8G3txl24LTaj5eef7mkZL4VtFyCQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=dWwLkoa+CxUjsSK7qf2Y5jZ2cGq23YEvo1MW7nbjWN0=; b=yBxVgF62QfhOKRNoOvqWQGE+yadZ+RtYU17bgeMhSlxSxnbKX3E7zuIX3FHR8qFHE44iZ8 MVVgGQHKacYfRdAg== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch v3 06/36] x86/smpboot: Remove the CPU0 hotplug kludge References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:43:36 +0200 (CEST) From: Thomas Gleixner This was introduced with commit e1c467e69040 ("x86, hotplug: Wake up CPU0 via NMI instead of INIT, SIPI, SIPI") to eventually support physical hotplug of CPU0: "We'll change this code in the future to wake up hard offlined CPU0 if real platform and request are available." 11 years later this has not happened and physical hotplug is not officially supported. Remove the cruft. Signed-off-by: Thomas Gleixner Tested-by: Michael Kelley --- arch/x86/include/asm/apic.h | 1 arch/x86/include/asm/smp.h | 1 arch/x86/kernel/smpboot.c | 170 +++--------------------------------------- drivers/acpi/processor_idle.c | 4 4 files changed, 14 insertions(+), 162 deletions(-) --- --- a/arch/x86/include/asm/apic.h +++ b/arch/x86/include/asm/apic.h @@ -377,7 +377,6 @@ extern struct apic *__apicdrivers[], *__ * APIC functionality to boot other CPUs - only used on SMP: */ #ifdef CONFIG_SMP -extern int wakeup_secondary_cpu_via_nmi(int apicid, unsigned long start_eip); extern int lapic_can_unplug_cpu(void); #endif --- a/arch/x86/include/asm/smp.h +++ b/arch/x86/include/asm/smp.h @@ -130,7 +130,6 @@ void native_play_dead(void); void play_dead_common(void); void wbinvd_on_cpu(int cpu); int wbinvd_on_all_cpus(void); -void cond_wakeup_cpu0(void); void native_smp_send_reschedule(int cpu); void native_send_call_func_ipi(const struct cpumask *mask); --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -216,9 +216,6 @@ static void ap_calibrate_delay(void) cpu_data(smp_processor_id()).loops_per_jiffy = loops_per_jiffy; } -static int cpu0_logical_apicid; -static int enable_start_cpu0; - /* * Activate a secondary processor. */ @@ -241,8 +238,6 @@ static void notrace start_secondary(void x86_cpuinit.early_percpu_clock_init(); smp_callin(); - enable_start_cpu0 = 0; - /* otherwise gcc will move up smp_processor_id before the cpu_init */ barrier(); /* Check TSC synchronization with the control CPU: */ @@ -410,7 +405,7 @@ void smp_store_cpu_info(int id) c->cpu_index = id; /* * During boot time, CPU0 has this setup already. Save the info when - * bringing up AP or offlined CPU0. + * bringing up an AP. */ identify_secondary_cpu(c); c->initialized = true; @@ -807,51 +802,14 @@ static void __init smp_quirk_init_udelay } /* - * Poke the other CPU in the eye via NMI to wake it up. Remember that the normal - * INIT, INIT, STARTUP sequence will reset the chip hard for us, and this - * won't ... remember to clear down the APIC, etc later. - */ -int -wakeup_secondary_cpu_via_nmi(int apicid, unsigned long start_eip) -{ - u32 dm = apic->dest_mode_logical ? APIC_DEST_LOGICAL : APIC_DEST_PHYSICAL; - unsigned long send_status, accept_status = 0; - int maxlvt; - - /* Target chip */ - /* Boot on the stack */ - /* Kick the second */ - apic_icr_write(APIC_DM_NMI | dm, apicid); - - pr_debug("Waiting for send to finish...\n"); - send_status = safe_apic_wait_icr_idle(); - - /* - * Give the other CPU some time to accept the IPI. - */ - udelay(200); - if (APIC_INTEGRATED(boot_cpu_apic_version)) { - maxlvt = lapic_get_maxlvt(); - if (maxlvt > 3) /* Due to the Pentium erratum 3AP. */ - apic_write(APIC_ESR, 0); - accept_status = (apic_read(APIC_ESR) & 0xEF); - } - pr_debug("NMI sent\n"); - - if (send_status) - pr_err("APIC never delivered???\n"); - if (accept_status) - pr_err("APIC delivery error (%lx)\n", accept_status); - - return (send_status | accept_status); -} - -static int -wakeup_secondary_cpu_via_init(int phys_apicid, unsigned long start_eip) + * Wake up AP by INIT, INIT, STARTUP sequence. + */ +static int wakeup_secondary_cpu_via_init(int phys_apicid, unsigned long start_eip) { unsigned long send_status = 0, accept_status = 0; int maxlvt, num_starts, j; + preempt_disable(); maxlvt = lapic_get_maxlvt(); /* @@ -957,6 +915,7 @@ wakeup_secondary_cpu_via_init(int phys_a if (accept_status) pr_err("APIC delivery error (%lx)\n", accept_status); + preempt_enable(); return (send_status | accept_status); } @@ -997,67 +956,6 @@ static void announce_cpu(int cpu, int ap node, cpu, apicid); } -static int wakeup_cpu0_nmi(unsigned int cmd, struct pt_regs *regs) -{ - int cpu; - - cpu = smp_processor_id(); - if (cpu == 0 && !cpu_online(cpu) && enable_start_cpu0) - return NMI_HANDLED; - - return NMI_DONE; -} - -/* - * Wake up AP by INIT, INIT, STARTUP sequence. - * - * Instead of waiting for STARTUP after INITs, BSP will execute the BIOS - * boot-strap code which is not a desired behavior for waking up BSP. To - * void the boot-strap code, wake up CPU0 by NMI instead. - * - * This works to wake up soft offlined CPU0 only. If CPU0 is hard offlined - * (i.e. physically hot removed and then hot added), NMI won't wake it up. - * We'll change this code in the future to wake up hard offlined CPU0 if - * real platform and request are available. - */ -static int -wakeup_cpu_via_init_nmi(int cpu, unsigned long start_ip, int apicid, - int *cpu0_nmi_registered) -{ - int id; - int boot_error; - - preempt_disable(); - - /* - * Wake up AP by INIT, INIT, STARTUP sequence. - */ - if (cpu) { - boot_error = wakeup_secondary_cpu_via_init(apicid, start_ip); - goto out; - } - - /* - * Wake up BSP by nmi. - * - * Register a NMI handler to help wake up CPU0. - */ - boot_error = register_nmi_handler(NMI_LOCAL, - wakeup_cpu0_nmi, 0, "wake_cpu0"); - - if (!boot_error) { - enable_start_cpu0 = 1; - *cpu0_nmi_registered = 1; - id = apic->dest_mode_logical ? cpu0_logical_apicid : apicid; - boot_error = wakeup_secondary_cpu_via_nmi(id, start_ip); - } - -out: - preempt_enable(); - - return boot_error; -} - int common_cpu_up(unsigned int cpu, struct task_struct *idle) { int ret; @@ -1086,8 +984,7 @@ int common_cpu_up(unsigned int cpu, stru * Returns zero if CPU booted OK, else error code from * ->wakeup_secondary_cpu. */ -static int do_boot_cpu(int apicid, int cpu, struct task_struct *idle, - int *cpu0_nmi_registered) +static int do_boot_cpu(int apicid, int cpu, struct task_struct *idle) { /* start_ip had better be page-aligned! */ unsigned long start_ip = real_mode_header->trampoline_start; @@ -1120,7 +1017,6 @@ static int do_boot_cpu(int apicid, int c * This grunge runs the startup process for * the targeted processor. */ - if (x86_platform.legacy.warm_reset) { pr_debug("Setting warm reset code and vector.\n"); @@ -1149,15 +1045,14 @@ static int do_boot_cpu(int apicid, int c * - Use a method from the APIC driver if one defined, with wakeup * straight to 64-bit mode preferred over wakeup to RM. * Otherwise, - * - Use an INIT boot APIC message for APs or NMI for BSP. + * - Use an INIT boot APIC message */ if (apic->wakeup_secondary_cpu_64) boot_error = apic->wakeup_secondary_cpu_64(apicid, start_ip); else if (apic->wakeup_secondary_cpu) boot_error = apic->wakeup_secondary_cpu(apicid, start_ip); else - boot_error = wakeup_cpu_via_init_nmi(cpu, start_ip, apicid, - cpu0_nmi_registered); + boot_error = wakeup_secondary_cpu_via_init(apicid, start_ip); if (!boot_error) { /* @@ -1206,9 +1101,8 @@ static int do_boot_cpu(int apicid, int c int native_cpu_up(unsigned int cpu, struct task_struct *tidle) { int apicid = apic->cpu_present_to_apicid(cpu); - int cpu0_nmi_registered = 0; unsigned long flags; - int err, ret = 0; + int err; lockdep_assert_irqs_enabled(); @@ -1247,11 +1141,10 @@ int native_cpu_up(unsigned int cpu, stru if (err) return err; - err = do_boot_cpu(apicid, cpu, tidle, &cpu0_nmi_registered); + err = do_boot_cpu(apicid, cpu, tidle); if (err) { pr_err("do_boot_cpu failed(%d) to wakeup CPU#%u\n", err, cpu); - ret = -EIO; - goto unreg_nmi; + return err; } /* @@ -1267,15 +1160,7 @@ int native_cpu_up(unsigned int cpu, stru touch_nmi_watchdog(); } -unreg_nmi: - /* - * Clean up the nmi handler. Do this after the callin and callout sync - * to avoid impact of possible long unregister time. - */ - if (cpu0_nmi_registered) - unregister_nmi_handler(NMI_LOCAL, "wake_cpu0"); - - return ret; + return 0; } /** @@ -1373,14 +1258,6 @@ static void __init smp_cpu_index_default } } -static void __init smp_get_logical_apicid(void) -{ - if (x2apic_mode) - cpu0_logical_apicid = apic_read(APIC_LDR); - else - cpu0_logical_apicid = GET_APIC_LOGICAL_ID(apic_read(APIC_LDR)); -} - void __init smp_prepare_cpus_common(void) { unsigned int i; @@ -1443,8 +1320,6 @@ void __init native_smp_prepare_cpus(unsi /* Setup local timer */ x86_init.timers.setup_percpu_clockev(); - smp_get_logical_apicid(); - pr_info("CPU0: "); print_cpu_info(&cpu_data(0)); @@ -1752,18 +1627,6 @@ void play_dead_common(void) local_irq_disable(); } -/** - * cond_wakeup_cpu0 - Wake up CPU0 if needed. - * - * If NMI wants to wake up CPU0, start CPU0. - */ -void cond_wakeup_cpu0(void) -{ - if (smp_processor_id() == 0 && enable_start_cpu0) - start_cpu0(); -} -EXPORT_SYMBOL_GPL(cond_wakeup_cpu0); - /* * We need to flush the caches before going to sleep, lest we have * dirty data in our caches when we come back up. @@ -1831,8 +1694,6 @@ static inline void mwait_play_dead(void) __monitor(mwait_ptr, 0, 0); mb(); __mwait(eax, 0); - - cond_wakeup_cpu0(); } } @@ -1841,11 +1702,8 @@ void __noreturn hlt_play_dead(void) if (__this_cpu_read(cpu_info.x86) >= 4) wbinvd(); - while (1) { + while (1) native_halt(); - - cond_wakeup_cpu0(); - } } void native_play_dead(void) --- a/drivers/acpi/processor_idle.c +++ b/drivers/acpi/processor_idle.c @@ -597,10 +597,6 @@ static int acpi_idle_play_dead(struct cp io_idle(cx->address); } else return -ENODEV; - -#if defined(CONFIG_X86) && defined(CONFIG_HOTPLUG_CPU) - cond_wakeup_cpu0(); -#endif } /* Never reached */ From xen-devel-bounces@lists.xenproject.org Mon May 08 19:43:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:43:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531744.827505 (Exim 4.92) (envelope-from ) id 1pw6lg-0004Ju-7H; Mon, 08 May 2023 19:43:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531744.827505; Mon, 08 May 2023 19:43:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6lg-0004Iq-38; Mon, 08 May 2023 19:43:32 +0000 Received: by outflank-mailman (input) for mailman id 531744; Mon, 08 May 2023 19:43:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6lf-0004GB-0k for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:43:31 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9b2f47c9-edd8-11ed-b226-6b7b168915f2; Mon, 08 May 2023 21:43:29 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b2f47c9-edd8-11ed-b226-6b7b168915f2 Message-ID: <20230508185217.287533369@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=TIFcpQKDkUA3tA8gujt3zKN0CCqeTM3e8ZIS8vByT1c=; b=Wf4mqDxFrL1eWhI5cpdoRdFllQIJr50VWM3iPhe3WsbZ/Iw75OzzMXvNpDiX4/F1RlUka/ FuaadHz8U/UJgoRuNI+eiueis1okBnBTdsW7K3h/5cJff54TU9cNXi2Eo25oxatOtt8Ped uqIwnl5vpuaeMpBtb7hOTKugxduUe8Augp4O7OKVi2nBKgfwEY926yQ5SmqvUi7xIbg97V fQtSCNhqHK3HwtnrdayfMk5OYNYQqF7Po1kCsNkOoJVvrU6F54wA+I/A0Pn8m/abs0ww8P YoKjgZ69Z9J+x/KjldafuRP3SwFynPh5Zr2/PtLG0H6Hu60gav2dDq7D6S6DFA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=TIFcpQKDkUA3tA8gujt3zKN0CCqeTM3e8ZIS8vByT1c=; b=LftWUnhcnLdQ0KvHaFRp+CDhSV7AuCp+oemkbqukqx/mhhoAfEVrKqqXitjKTnGoiLrrvy h0+2Iv+MwcjSr/DA== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch v3 01/36] [patch V2 01/38] x86/smpboot: Cleanup topology_phys_to_logical_pkg()/die() References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:43:28 +0200 (CEST) From: Thomas Gleixner Make topology_phys_to_logical_pkg_die() static as it's only used in smpboot.c and fixup the kernel-doc warnings for both functions. Signed-off-by: Thomas Gleixner Tested-by: Michael Kelley --- arch/x86/include/asm/topology.h | 3 --- arch/x86/kernel/smpboot.c | 10 ++++++---- 2 files changed, 6 insertions(+), 7 deletions(-) --- --- a/arch/x86/include/asm/topology.h +++ b/arch/x86/include/asm/topology.h @@ -139,7 +139,6 @@ static inline int topology_max_smt_threa int topology_update_package_map(unsigned int apicid, unsigned int cpu); int topology_update_die_map(unsigned int dieid, unsigned int cpu); int topology_phys_to_logical_pkg(unsigned int pkg); -int topology_phys_to_logical_die(unsigned int die, unsigned int cpu); bool topology_is_primary_thread(unsigned int cpu); bool topology_smt_supported(void); #else @@ -149,8 +148,6 @@ topology_update_package_map(unsigned int static inline int topology_update_die_map(unsigned int dieid, unsigned int cpu) { return 0; } static inline int topology_phys_to_logical_pkg(unsigned int pkg) { return 0; } -static inline int topology_phys_to_logical_die(unsigned int die, - unsigned int cpu) { return 0; } static inline int topology_max_die_per_package(void) { return 1; } static inline int topology_max_smt_threads(void) { return 1; } static inline bool topology_is_primary_thread(unsigned int cpu) { return true; } --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -288,6 +288,7 @@ bool topology_smt_supported(void) /** * topology_phys_to_logical_pkg - Map a physical package id to a logical + * @phys_pkg: The physical package id to map * * Returns logical package id or -1 if not found */ @@ -304,15 +305,17 @@ int topology_phys_to_logical_pkg(unsigne return -1; } EXPORT_SYMBOL(topology_phys_to_logical_pkg); + /** * topology_phys_to_logical_die - Map a physical die id to logical + * @die_id: The physical die id to map + * @cur_cpu: The CPU for which the mapping is done * * Returns logical die id or -1 if not found */ -int topology_phys_to_logical_die(unsigned int die_id, unsigned int cur_cpu) +static int topology_phys_to_logical_die(unsigned int die_id, unsigned int cur_cpu) { - int cpu; - int proc_id = cpu_data(cur_cpu).phys_proc_id; + int cpu, proc_id = cpu_data(cur_cpu).phys_proc_id; for_each_possible_cpu(cpu) { struct cpuinfo_x86 *c = &cpu_data(cpu); @@ -323,7 +326,6 @@ int topology_phys_to_logical_die(unsigne } return -1; } -EXPORT_SYMBOL(topology_phys_to_logical_die); /** * topology_update_package_map - Update the physical to logical package map From xen-devel-bounces@lists.xenproject.org Mon May 08 19:43:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:43:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531743.827502 (Exim 4.92) (envelope-from ) id 1pw6lf-0004GW-VK; Mon, 08 May 2023 19:43:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531743.827502; Mon, 08 May 2023 19:43:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6lf-0004GP-Se; Mon, 08 May 2023 19:43:31 +0000 Received: by outflank-mailman (input) for mailman id 531743; Mon, 08 May 2023 19:43:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6le-0004GB-BE for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:43:30 +0000 Received: from galois.linutronix.de (galois.linutronix.de [2a0a:51c0:0:12e:550::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9a860726-edd8-11ed-b226-6b7b168915f2; Mon, 08 May 2023 21:43:28 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9a860726-edd8-11ed-b226-6b7b168915f2 Message-ID: <20230508181633.089804905@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575007; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc; bh=cSONB8rAwM/DhP8pLyA+5ZPUbC2lOuuQwaVdJRn5WDM=; b=TUKnHdyKCm2jhBxD5IlUGRPEG/QaxWUEEk5j+F5TiwGQh75MzfKnWvvga1ogV0FWpqsAk0 Z/VqPwKzVgozvsmFgeZHc6fKtgAWVGs7xGme4vq54PLJoTakzMDfDNVCbcO2rny0q4HnR6 qlFXb43Qt1L8lTxJDtVVOKBuzxeXABCLtAFoVNNIdEV1p8ow/ukbkpiR2uIVB/FYpjA6p3 h6hKX4cZFsqIirm+tNd9G+ACRA1lcKi+gtx7U3umktHuz9juvrtG2mgbwLKrM2SK5QyvS3 r9jvL2zUpq3y0guhjpTb2zQUgu9MH/0dN+oTlFfspWYXJjDrCu5rao9nchjzhw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575007; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc; bh=cSONB8rAwM/DhP8pLyA+5ZPUbC2lOuuQwaVdJRn5WDM=; b=i5YP5va30wPZDaaNSG4+BZNoSkYS91jOjq0F96kx0dzX5lZgVd2tGOGcKaXMK8erIbX4td IGoM8wVZMNo8tHAg== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch v3 00/36] cpu/hotplug, x86: Reworked parallel CPU bringup Date: Mon, 8 May 2023 21:43:26 +0200 (CEST) Hi! This is version 3 of the reworked parallel bringup series. Version 2 can be found here: https://lore.kernel.org/lkml/20230504185733.126511787@linutronix.de This is just a quick reiteration to address the following details: 1) Drop the two extended topology leaf patches as they are not longer relevant (Andrew Cooper) 2) Make the announce_cpu() fixup work for real (Micheal Kelley) Other than that there are no changes and the other details are all the same as in V2. Thanks, tglx From xen-devel-bounces@lists.xenproject.org Mon May 08 19:43:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:43:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531747.827542 (Exim 4.92) (envelope-from ) id 1pw6lk-0005Fx-3L; Mon, 08 May 2023 19:43:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531747.827542; Mon, 08 May 2023 19:43:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6lj-0005F8-Uo; Mon, 08 May 2023 19:43:35 +0000 Received: by outflank-mailman (input) for mailman id 531747; Mon, 08 May 2023 19:43:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6li-0004GB-EW for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:43:34 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9dfae0e5-edd8-11ed-b226-6b7b168915f2; Mon, 08 May 2023 21:43:33 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9dfae0e5-edd8-11ed-b226-6b7b168915f2 Message-ID: <20230508185217.458393998@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=YVvAw0WAsVmopE5OIHIsJcpjHcWT9bVzoHoSegD/6OE=; b=G8jY8noRcocsOMuudUmnigMS5g2D2j/illqfnrAKMDSwZNAyNByW7W91CB5A0qyup8xoLU ju1ecTOFYCXG1ZOzwfeLNIWu4WEoDoD6p+1D+AqZKyOSugeGaOehdmkoA/nlGtcew2jUOh DzAZFh9YTiogntfcZ4P9+UPNch+6emIC0ae/WUtPo0aud1Iu4QPNUMUDCBmri2TlGBp9jT AA6L+H6VK8adYXgBNCf9r3PVCVhzwleTI15/nfJTmsMFQVq+7axqKZpItAeazqI90AqRIf nMTxkJ3sBvJwkZTMIR7xYS+DUgVAJRQlg/jUyMsipvPSuiu4phOaq20wyRyl4g== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=YVvAw0WAsVmopE5OIHIsJcpjHcWT9bVzoHoSegD/6OE=; b=s+ViDYzSQVsqYkVETBJLWwXeFyinDS8d3eNTrYKk8dlzptBDC/K8uzHkO4TXLBIVOdRrGS hKy0R6/dTZ++mCAg== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch v3 04/36] x86/smpboot: Rename start_cpu0() to soft_restart_cpu() References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:43:33 +0200 (CEST) From: Thomas Gleixner This is used in the SEV play_dead() implementation to re-online CPUs. But that has nothing to do with CPU0. Signed-off-by: Thomas Gleixner Tested-by: Michael Kelley --- arch/x86/include/asm/cpu.h | 2 +- arch/x86/kernel/callthunks.c | 2 +- arch/x86/kernel/head_32.S | 10 +++++----- arch/x86/kernel/head_64.S | 10 +++++----- arch/x86/kernel/sev.c | 2 +- 5 files changed, 13 insertions(+), 13 deletions(-) --- --- a/arch/x86/include/asm/cpu.h +++ b/arch/x86/include/asm/cpu.h @@ -30,7 +30,7 @@ struct x86_cpu { #ifdef CONFIG_HOTPLUG_CPU extern int arch_register_cpu(int num); extern void arch_unregister_cpu(int); -extern void start_cpu0(void); +extern void soft_restart_cpu(void); #ifdef CONFIG_DEBUG_HOTPLUG_CPU0 extern int _debug_hotplug_cpu(int cpu, int action); #endif --- a/arch/x86/kernel/callthunks.c +++ b/arch/x86/kernel/callthunks.c @@ -134,7 +134,7 @@ static bool skip_addr(void *dest) if (dest == ret_from_fork) return true; #ifdef CONFIG_HOTPLUG_CPU - if (dest == start_cpu0) + if (dest == soft_restart_cpu) return true; #endif #ifdef CONFIG_FUNCTION_TRACER --- a/arch/x86/kernel/head_32.S +++ b/arch/x86/kernel/head_32.S @@ -140,16 +140,16 @@ SYM_CODE_END(startup_32) #ifdef CONFIG_HOTPLUG_CPU /* - * Boot CPU0 entry point. It's called from play_dead(). Everything has been set - * up already except stack. We just set up stack here. Then call - * start_secondary(). + * Entry point for soft restart of a CPU. Invoked from xxx_play_dead() for + * restarting the boot CPU or for restarting SEV guest CPUs after CPU hot + * unplug. Everything is set up already except the stack. */ -SYM_FUNC_START(start_cpu0) +SYM_FUNC_START(soft_restart_cpu) movl initial_stack, %ecx movl %ecx, %esp call *(initial_code) 1: jmp 1b -SYM_FUNC_END(start_cpu0) +SYM_FUNC_END(soft_restart_cpu) #endif /* --- a/arch/x86/kernel/head_64.S +++ b/arch/x86/kernel/head_64.S @@ -377,11 +377,11 @@ SYM_CODE_END(secondary_startup_64) #ifdef CONFIG_HOTPLUG_CPU /* - * Boot CPU0 entry point. It's called from play_dead(). Everything has been set - * up already except stack. We just set up stack here. Then call - * start_secondary() via .Ljump_to_C_code. + * Entry point for soft restart of a CPU. Invoked from xxx_play_dead() for + * restarting the boot CPU or for restarting SEV guest CPUs after CPU hot + * unplug. Everything is set up already except the stack. */ -SYM_CODE_START(start_cpu0) +SYM_CODE_START(soft_restart_cpu) ANNOTATE_NOENDBR UNWIND_HINT_END_OF_STACK @@ -390,7 +390,7 @@ SYM_CODE_START(start_cpu0) movq TASK_threadsp(%rcx), %rsp jmp .Ljump_to_C_code -SYM_CODE_END(start_cpu0) +SYM_CODE_END(soft_restart_cpu) #endif #ifdef CONFIG_AMD_MEM_ENCRYPT --- a/arch/x86/kernel/sev.c +++ b/arch/x86/kernel/sev.c @@ -1328,7 +1328,7 @@ static void sev_es_play_dead(void) * If we get here, the VCPU was woken up again. Jump to CPU * startup code to get it back online. */ - start_cpu0(); + soft_restart_cpu(); } #else /* CONFIG_HOTPLUG_CPU */ #define sev_es_play_dead native_play_dead From xen-devel-bounces@lists.xenproject.org Mon May 08 19:43:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:43:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531748.827552 (Exim 4.92) (envelope-from ) id 1pw6ll-0005XG-CK; Mon, 08 May 2023 19:43:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531748.827552; Mon, 08 May 2023 19:43:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6ll-0005X7-8y; Mon, 08 May 2023 19:43:37 +0000 Received: by outflank-mailman (input) for mailman id 531748; Mon, 08 May 2023 19:43:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6lk-0004GB-CL for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:43:36 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9ef6a7fd-edd8-11ed-b226-6b7b168915f2; Mon, 08 May 2023 21:43:35 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9ef6a7fd-edd8-11ed-b226-6b7b168915f2 Message-ID: <20230508185217.511579580@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575015; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=SosWLf7ByWh3YMm1K9ndiB9cuSmcQMV7NcxWhF9A3kI=; b=RxIY2+NGJMVR7IR/st90ytSTmlXQsFTiFea99c/lKKxj1EB1q7hquMHWhtzdUNbWMNcbrM CnwJRgUBfMd2jL4iqtNC/N/c0jTglRRfq2OxvXjlOeJUe9UV5oIypcCkWD/al9xzufAzFi MPKvMUBIHPUjsOZ5nZYGDi0di8/Lx5vCXWMf6RqNjjuVGFMedci3sMZdVSB+S1ZFC6xrJb okqsHQtnu340k8mccnfdU1E4uotcI24/fyWVoduhFx1fhit6P/t9BzkXewcwomKJxshvcQ bS6VrEc7RyZlHtIKOWsn9nV7oGXuQ5C8JHSKVY1pW+2LCdY/5v0m9cy4sSFTNw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575015; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=SosWLf7ByWh3YMm1K9ndiB9cuSmcQMV7NcxWhF9A3kI=; b=fN1ysvSc4RZkQU6RxlQ3edeUZTJeyhE4L52lxIV6AQR8CpkXxixTOvSAkXm7BXO2oN4A4n CA7Uf5KlMR0J2bDQ== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch v3 05/36] x86/topology: Remove CPU0 hotplug option References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:43:34 +0200 (CEST) From: Thomas Gleixner This was introduced together with commit e1c467e69040 ("x86, hotplug: Wake up CPU0 via NMI instead of INIT, SIPI, SIPI") to eventually support physical hotplug of CPU0: "We'll change this code in the future to wake up hard offlined CPU0 if real platform and request are available." 11 years later this has not happened and physical hotplug is not officially supported. Remove the cruft. Signed-off-by: Thomas Gleixner Tested-by: Michael Kelley --- Documentation/admin-guide/kernel-parameters.txt | 14 --- Documentation/core-api/cpu_hotplug.rst | 13 --- arch/x86/Kconfig | 43 ---------- arch/x86/include/asm/cpu.h | 3 arch/x86/kernel/topology.c | 98 ------------------------ arch/x86/power/cpu.c | 37 --------- 6 files changed, 6 insertions(+), 202 deletions(-) --- --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -818,20 +818,6 @@ Format: ,,,[,] - cpu0_hotplug [X86] Turn on CPU0 hotplug feature when - CONFIG_BOOTPARAM_HOTPLUG_CPU0 is off. - Some features depend on CPU0. Known dependencies are: - 1. Resume from suspend/hibernate depends on CPU0. - Suspend/hibernate will fail if CPU0 is offline and you - need to online CPU0 before suspend/hibernate. - 2. PIC interrupts also depend on CPU0. CPU0 can't be - removed if a PIC interrupt is detected. - It's said poweroff/reboot may depend on CPU0 on some - machines although I haven't seen such issues so far - after CPU0 is offline on a few tested machines. - If the dependencies are under your control, you can - turn on cpu0_hotplug. - cpuidle.off=1 [CPU_IDLE] disable the cpuidle sub-system --- a/Documentation/core-api/cpu_hotplug.rst +++ b/Documentation/core-api/cpu_hotplug.rst @@ -127,17 +127,8 @@ Once the CPU is shutdown, it will be rem $ echo 1 > /sys/devices/system/cpu/cpu4/online smpboot: Booting Node 0 Processor 4 APIC 0x1 -The CPU is usable again. This should work on all CPUs. CPU0 is often special -and excluded from CPU hotplug. On X86 the kernel option -*CONFIG_BOOTPARAM_HOTPLUG_CPU0* has to be enabled in order to be able to -shutdown CPU0. Alternatively the kernel command option *cpu0_hotplug* can be -used. Some known dependencies of CPU0: - -* Resume from hibernate/suspend. Hibernate/suspend will fail if CPU0 is offline. -* PIC interrupts. CPU0 can't be removed if a PIC interrupt is detected. - -Please let Fenghua Yu know if you find any dependencies -on CPU0. +The CPU is usable again. This should work on all CPUs, but CPU0 is often special +and excluded from CPU hotplug. The CPU hotplug coordination ============================ --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -2305,49 +2305,6 @@ config HOTPLUG_CPU def_bool y depends on SMP -config BOOTPARAM_HOTPLUG_CPU0 - bool "Set default setting of cpu0_hotpluggable" - depends on HOTPLUG_CPU - help - Set whether default state of cpu0_hotpluggable is on or off. - - Say Y here to enable CPU0 hotplug by default. If this switch - is turned on, there is no need to give cpu0_hotplug kernel - parameter and the CPU0 hotplug feature is enabled by default. - - Please note: there are two known CPU0 dependencies if you want - to enable the CPU0 hotplug feature either by this switch or by - cpu0_hotplug kernel parameter. - - First, resume from hibernate or suspend always starts from CPU0. - So hibernate and suspend are prevented if CPU0 is offline. - - Second dependency is PIC interrupts always go to CPU0. CPU0 can not - offline if any interrupt can not migrate out of CPU0. There may - be other CPU0 dependencies. - - Please make sure the dependencies are under your control before - you enable this feature. - - Say N if you don't want to enable CPU0 hotplug feature by default. - You still can enable the CPU0 hotplug feature at boot by kernel - parameter cpu0_hotplug. - -config DEBUG_HOTPLUG_CPU0 - def_bool n - prompt "Debug CPU0 hotplug" - depends on HOTPLUG_CPU - help - Enabling this option offlines CPU0 (if CPU0 can be offlined) as - soon as possible and boots up userspace with CPU0 offlined. User - can online CPU0 back after boot time. - - To debug CPU0 hotplug, you need to enable CPU0 offline/online - feature by either turning on CONFIG_BOOTPARAM_HOTPLUG_CPU0 during - compilation or giving cpu0_hotplug kernel parameter at boot. - - If unsure, say N. - config COMPAT_VDSO def_bool n prompt "Disable the 32-bit vDSO (needed for glibc 2.3.3)" --- a/arch/x86/include/asm/cpu.h +++ b/arch/x86/include/asm/cpu.h @@ -31,9 +31,6 @@ struct x86_cpu { extern int arch_register_cpu(int num); extern void arch_unregister_cpu(int); extern void soft_restart_cpu(void); -#ifdef CONFIG_DEBUG_HOTPLUG_CPU0 -extern int _debug_hotplug_cpu(int cpu, int action); -#endif #endif extern void ap_init_aperfmperf(void); --- a/arch/x86/kernel/topology.c +++ b/arch/x86/kernel/topology.c @@ -38,102 +38,12 @@ static DEFINE_PER_CPU(struct x86_cpu, cpu_devices); #ifdef CONFIG_HOTPLUG_CPU - -#ifdef CONFIG_BOOTPARAM_HOTPLUG_CPU0 -static int cpu0_hotpluggable = 1; -#else -static int cpu0_hotpluggable; -static int __init enable_cpu0_hotplug(char *str) -{ - cpu0_hotpluggable = 1; - return 1; -} - -__setup("cpu0_hotplug", enable_cpu0_hotplug); -#endif - -#ifdef CONFIG_DEBUG_HOTPLUG_CPU0 -/* - * This function offlines a CPU as early as possible and allows userspace to - * boot up without the CPU. The CPU can be onlined back by user after boot. - * - * This is only called for debugging CPU offline/online feature. - */ -int _debug_hotplug_cpu(int cpu, int action) -{ - int ret; - - if (!cpu_is_hotpluggable(cpu)) - return -EINVAL; - - switch (action) { - case 0: - ret = remove_cpu(cpu); - if (!ret) - pr_info("DEBUG_HOTPLUG_CPU0: CPU %u is now offline\n", cpu); - else - pr_debug("Can't offline CPU%d.\n", cpu); - break; - case 1: - ret = add_cpu(cpu); - if (ret) - pr_debug("Can't online CPU%d.\n", cpu); - - break; - default: - ret = -EINVAL; - } - - return ret; -} - -static int __init debug_hotplug_cpu(void) +int arch_register_cpu(int cpu) { - _debug_hotplug_cpu(0, 0); - return 0; -} - -late_initcall_sync(debug_hotplug_cpu); -#endif /* CONFIG_DEBUG_HOTPLUG_CPU0 */ - -int arch_register_cpu(int num) -{ - struct cpuinfo_x86 *c = &cpu_data(num); - - /* - * Currently CPU0 is only hotpluggable on Intel platforms. Other - * vendors can add hotplug support later. - * Xen PV guests don't support CPU0 hotplug at all. - */ - if (c->x86_vendor != X86_VENDOR_INTEL || - cpu_feature_enabled(X86_FEATURE_XENPV)) - cpu0_hotpluggable = 0; - - /* - * Two known BSP/CPU0 dependencies: Resume from suspend/hibernate - * depends on BSP. PIC interrupts depend on BSP. - * - * If the BSP dependencies are under control, one can tell kernel to - * enable BSP hotplug. This basically adds a control file and - * one can attempt to offline BSP. - */ - if (num == 0 && cpu0_hotpluggable) { - unsigned int irq; - /* - * We won't take down the boot processor on i386 if some - * interrupts only are able to be serviced by the BSP in PIC. - */ - for_each_active_irq(irq) { - if (!IO_APIC_IRQ(irq) && irq_has_action(irq)) { - cpu0_hotpluggable = 0; - break; - } - } - } - if (num || cpu0_hotpluggable) - per_cpu(cpu_devices, num).cpu.hotpluggable = 1; + struct x86_cpu *xc = per_cpu_ptr(&cpu_devices, cpu); - return register_cpu(&per_cpu(cpu_devices, num).cpu, num); + xc->cpu.hotpluggable = cpu > 0; + return register_cpu(&xc->cpu, cpu); } EXPORT_SYMBOL(arch_register_cpu); --- a/arch/x86/power/cpu.c +++ b/arch/x86/power/cpu.c @@ -351,43 +351,6 @@ static int bsp_pm_callback(struct notifi case PM_HIBERNATION_PREPARE: ret = bsp_check(); break; -#ifdef CONFIG_DEBUG_HOTPLUG_CPU0 - case PM_RESTORE_PREPARE: - /* - * When system resumes from hibernation, online CPU0 because - * 1. it's required for resume and - * 2. the CPU was online before hibernation - */ - if (!cpu_online(0)) - _debug_hotplug_cpu(0, 1); - break; - case PM_POST_RESTORE: - /* - * When a resume really happens, this code won't be called. - * - * This code is called only when user space hibernation software - * prepares for snapshot device during boot time. So we just - * call _debug_hotplug_cpu() to restore to CPU0's state prior to - * preparing the snapshot device. - * - * This works for normal boot case in our CPU0 hotplug debug - * mode, i.e. CPU0 is offline and user mode hibernation - * software initializes during boot time. - * - * If CPU0 is online and user application accesses snapshot - * device after boot time, this will offline CPU0 and user may - * see different CPU0 state before and after accessing - * the snapshot device. But hopefully this is not a case when - * user debugging CPU0 hotplug. Even if users hit this case, - * they can easily online CPU0 back. - * - * To simplify this debug code, we only consider normal boot - * case. Otherwise we need to remember CPU0's state and restore - * to that state and resolve racy conditions etc. - */ - _debug_hotplug_cpu(0, 0); - break; -#endif default: break; } From xen-devel-bounces@lists.xenproject.org Mon May 08 19:43:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:43:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531746.827527 (Exim 4.92) (envelope-from ) id 1pw6li-0004nA-Sp; Mon, 08 May 2023 19:43:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531746.827527; Mon, 08 May 2023 19:43:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6li-0004me-Mi; Mon, 08 May 2023 19:43:34 +0000 Received: by outflank-mailman (input) for mailman id 531746; Mon, 08 May 2023 19:43:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6lg-0004Y5-Ts for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:43:32 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9c161b0a-edd8-11ed-8611-37d641c3527e; Mon, 08 May 2023 21:43:30 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9c161b0a-edd8-11ed-8611-37d641c3527e Message-ID: <20230508185217.347553670@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575010; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=S9LsovJrwK7U1/6r/D/tJ1OdnJxm0UpeZcX2eXUL15I=; b=C5NEL7Sc3xFfKL0CxGkuq3u1SI/3MBmp8kg2JO4gnaU2mJzbEGpxk1b+m4QK7KTPpH4pVj Je5YQoIAQw415ZdCKvoZrpOxEKSNL3+6l5SO/FrWT4Ni5Ew2CIek1ECZ03FWVa1H7bKFIY LtzTqoDPPuHjD06VN2npWHg8rtixxSjX0ftouZEEd0Sf7pS2qYVGbOuU6h7xDtyTYslukj RHbaiW/MH2YP0HMjKAgYUFdeqyVOkzsdpwguiZgepsxXygbQqBa+QVNMrwxQBM3ZdZlm5u Q1RjNUaXEpp4826qTOW50h9LZGHuPZq497+v7TvVBOTfkKOpxxTiLHhDN67CUw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575010; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=S9LsovJrwK7U1/6r/D/tJ1OdnJxm0UpeZcX2eXUL15I=; b=zSCuoKEKQteV6nPjwNnN8p1R7pY/jEKhW4RIT67a4neXwQLEhCVtxH6R7aW9FeOFUi4146 WzFetV3Y74q63+Bg== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch v3 02/36] cpu/hotplug: Mark arch_disable_smp_support() and bringup_nonboot_cpus() __init References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:43:29 +0200 (CEST) From: Thomas Gleixner No point in keeping them around. Signed-off-by: Thomas Gleixner Tested-by: Michael Kelley --- arch/x86/kernel/smpboot.c | 4 ++-- kernel/cpu.c | 2 +- kernel/smp.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) --- --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -1269,9 +1269,9 @@ int native_cpu_up(unsigned int cpu, stru } /** - * arch_disable_smp_support() - disables SMP support for x86 at runtime + * arch_disable_smp_support() - Disables SMP support for x86 at boottime */ -void arch_disable_smp_support(void) +void __init arch_disable_smp_support(void) { disable_ioapic_support(); } --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -1502,7 +1502,7 @@ int bringup_hibernate_cpu(unsigned int s return 0; } -void bringup_nonboot_cpus(unsigned int setup_max_cpus) +void __init bringup_nonboot_cpus(unsigned int setup_max_cpus) { unsigned int cpu; --- a/kernel/smp.c +++ b/kernel/smp.c @@ -892,7 +892,7 @@ EXPORT_SYMBOL(setup_max_cpus); * SMP mode to . */ -void __weak arch_disable_smp_support(void) { } +void __weak __init arch_disable_smp_support(void) { } static int __init nosmp(char *str) { From xen-devel-bounces@lists.xenproject.org Mon May 08 19:43:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:43:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531745.827522 (Exim 4.92) (envelope-from ) id 1pw6li-0004ks-JA; Mon, 08 May 2023 19:43:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531745.827522; Mon, 08 May 2023 19:43:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6li-0004kd-Ez; Mon, 08 May 2023 19:43:34 +0000 Received: by outflank-mailman (input) for mailman id 531745; Mon, 08 May 2023 19:43:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6lg-0004GB-Sv for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:43:32 +0000 Received: from galois.linutronix.de (galois.linutronix.de [2a0a:51c0:0:12e:550::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9d08aa25-edd8-11ed-b226-6b7b168915f2; Mon, 08 May 2023 21:43:32 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9d08aa25-edd8-11ed-b226-6b7b168915f2 Message-ID: <20230508185217.405187204@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=HvbbbIiCrteaI1bndI/LX3oIuQfCpfxndnpojb5RiKc=; b=BfN8q4YGZrvvr3hwXOfVCQXAM0cSaY1SEoSphmNTsut/rUAni3XtelvN4CHoNkC2+34Ymi TExugThNdfAh5Fp1/heIMO4QUnZPoX/5/+WK/OdLeyR3RF9vIZeGhZsFY4OLhi5HdKiIER /YIJWQAT9QzRFGpqH7CAPTxY9UkNRCpCd4alyqj4+UmOC+6AxHr5xWXJsqeSXPmKwFhv1A ubCJW6/Egd3JKzrvz6jHP0y5xHT+UfGDn1rLC92NRh5X9Mx/ylbzv+ZZQOLMPjHx0w/hZY PLLJPmQ9Y1thsJxqAo8DO9T8VrZNf4ZCHtIxyjWM81zadG9cxhkbFRB3VFi7xA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=HvbbbIiCrteaI1bndI/LX3oIuQfCpfxndnpojb5RiKc=; b=TGUqtBVLw37zc5671ZnaxyCwD1VN/ytP+JSMajykmRFyOCcIZ2eBHNHYynrijOrC/OQEpW IDlSUjUrSbEGPyCw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch v3 03/36] x86/smpboot: Avoid pointless delay calibration if TSC is synchronized References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:43:31 +0200 (CEST) From: Thomas Gleixner When TSC is synchronized across sockets then there is no reason to calibrate the delay for the first CPU which comes up on a socket. Just reuse the existing calibration value. This removes 100ms pointlessly wasted time from CPU hotplug per socket. Signed-off-by: Thomas Gleixner Tested-by: Michael Kelley --- arch/x86/kernel/smpboot.c | 38 ++++++++++++++++++++++++-------------- arch/x86/kernel/tsc.c | 20 ++++++++++++++++---- 2 files changed, 40 insertions(+), 18 deletions(-) --- --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -178,10 +178,7 @@ static void smp_callin(void) */ apic_ap_setup(); - /* - * Save our processor parameters. Note: this information - * is needed for clock calibration. - */ + /* Save our processor parameters. */ smp_store_cpu_info(cpuid); /* @@ -192,14 +189,6 @@ static void smp_callin(void) ap_init_aperfmperf(); - /* - * Get our bogomips. - * Update loops_per_jiffy in cpu_data. Previous call to - * smp_store_cpu_info() stored a value that is close but not as - * accurate as the value just calculated. - */ - calibrate_delay(); - cpu_data(cpuid).loops_per_jiffy = loops_per_jiffy; pr_debug("Stack at about %p\n", &cpuid); wmb(); @@ -212,8 +201,24 @@ static void smp_callin(void) cpumask_set_cpu(cpuid, cpu_callin_mask); } +static void ap_calibrate_delay(void) +{ + /* + * Calibrate the delay loop and update loops_per_jiffy in cpu_data. + * smp_store_cpu_info() stored a value that is close but not as + * accurate as the value just calculated. + * + * As this is invoked after the TSC synchronization check, + * calibrate_delay_is_known() will skip the calibration routine + * when TSC is synchronized across sockets. + */ + calibrate_delay(); + cpu_data(smp_processor_id()).loops_per_jiffy = loops_per_jiffy; +} + static int cpu0_logical_apicid; static int enable_start_cpu0; + /* * Activate a secondary processor. */ @@ -240,10 +245,15 @@ static void notrace start_secondary(void /* otherwise gcc will move up smp_processor_id before the cpu_init */ barrier(); + /* Check TSC synchronization with the control CPU: */ + check_tsc_sync_target(); + /* - * Check TSC synchronization with the boot CPU: + * Calibrate the delay loop after the TSC synchronization check. + * This allows to skip the calibration when TSC is synchronized + * across sockets. */ - check_tsc_sync_target(); + ap_calibrate_delay(); speculative_store_bypass_ht_init(); --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -1598,10 +1598,7 @@ void __init tsc_init(void) #ifdef CONFIG_SMP /* - * If we have a constant TSC and are using the TSC for the delay loop, - * we can skip clock calibration if another cpu in the same socket has already - * been calibrated. This assumes that CONSTANT_TSC applies to all - * cpus in the socket - this should be a safe assumption. + * Check whether existing calibration data can be reused. */ unsigned long calibrate_delay_is_known(void) { @@ -1609,6 +1606,21 @@ unsigned long calibrate_delay_is_known(v int constant_tsc = cpu_has(&cpu_data(cpu), X86_FEATURE_CONSTANT_TSC); const struct cpumask *mask = topology_core_cpumask(cpu); + /* + * If TSC has constant frequency and TSC is synchronized across + * sockets then reuse CPU0 calibration. + */ + if (constant_tsc && !tsc_unstable) + return cpu_data(0).loops_per_jiffy; + + /* + * If TSC has constant frequency and TSC is not synchronized across + * sockets and this is not the first CPU in the socket, then reuse + * the calibration value of an already online CPU on that socket. + * + * This assumes that CONSTANT_TSC is consistent for all CPUs in a + * socket. + */ if (!constant_tsc || !mask) return 0; From xen-devel-bounces@lists.xenproject.org Mon May 08 19:43:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:43:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531751.827582 (Exim 4.92) (envelope-from ) id 1pw6lr-0006V7-HB; Mon, 08 May 2023 19:43:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531751.827582; Mon, 08 May 2023 19:43:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6lr-0006Uv-Bm; Mon, 08 May 2023 19:43:43 +0000 Received: by outflank-mailman (input) for mailman id 531751; Mon, 08 May 2023 19:43:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6lq-0004GB-Gf for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:43:42 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a2c93318-edd8-11ed-b226-6b7b168915f2; Mon, 08 May 2023 21:43:41 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a2c93318-edd8-11ed-b226-6b7b168915f2 Message-ID: <20230508185217.725507622@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575021; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=l2ZAdiTSxc4Ph8TyhAnDuEUhjcNUoY+vPQjmK9rgSOw=; b=gaT1OuAZ/GfjuakxTEJ2KYFHHzuQGSX55lDDjTfN7H14JbYbNLMM4m5KEMtJmbQjf5dGd8 u6xaJZJ4RDdDY8AEhdNSWuCFNXk+TTJsi8/yzR94kBccocw9u25EGL8O6o4TOYanqr+EXt NhIFRD+lDCv3rQ1zF9CsAlmwrDH3WUd0arfpWQUXnSr9BmI2oikrsACB3KufetuUHeTXx6 Dfmr70iicTai9wWJcUCYXfrT+e3fQNAy7f7bAiHZh1hN8Pw4PKOZApdT4wEEG7OYby4pO/ J0L7EIGZ0mmjG5HI8U9pfnUs9mQdXGK6TXfo6ya7SFw/bbUl1OddNzvQqalhdg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575021; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=l2ZAdiTSxc4Ph8TyhAnDuEUhjcNUoY+vPQjmK9rgSOw=; b=DHa8pWb6DR3SZOX4vG2QWSchsl3pME0lzD5CYQrhDWXg/TvCY5mWEc+2tWrjc+r9aOnyjo ukEASnIuuQDnS6AQ== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch v3 09/36] x86/smpboot: Get rid of cpu_init_secondary() References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:43:41 +0200 (CEST) From: Thomas Gleixner The synchronization of the AP with the control CPU is a SMP boot problem and has nothing to do with cpu_init(). Open code cpu_init_secondary() in start_secondary() and move wait_for_master_cpu() into the SMP boot code. No functional change. Signed-off-by: Thomas Gleixner Tested-by: Michael Kelley --- arch/x86/include/asm/processor.h | 1 - arch/x86/kernel/cpu/common.c | 27 --------------------------- arch/x86/kernel/smpboot.c | 24 +++++++++++++++++++----- 3 files changed, 19 insertions(+), 33 deletions(-) --- --- a/arch/x86/include/asm/processor.h +++ b/arch/x86/include/asm/processor.h @@ -551,7 +551,6 @@ extern void switch_gdt_and_percpu_base(i extern void load_direct_gdt(int); extern void load_fixmap_gdt(int); extern void cpu_init(void); -extern void cpu_init_secondary(void); extern void cpu_init_exception_handling(void); extern void cr4_init(void); --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -2123,19 +2123,6 @@ static void dbg_restore_debug_regs(void) #define dbg_restore_debug_regs() #endif /* ! CONFIG_KGDB */ -static void wait_for_master_cpu(int cpu) -{ -#ifdef CONFIG_SMP - /* - * wait for ACK from master CPU before continuing - * with AP initialization - */ - WARN_ON(cpumask_test_and_set_cpu(cpu, cpu_initialized_mask)); - while (!cpumask_test_cpu(cpu, cpu_callout_mask)) - cpu_relax(); -#endif -} - static inline void setup_getcpu(int cpu) { unsigned long cpudata = vdso_encode_cpunode(cpu, early_cpu_to_node(cpu)); @@ -2239,8 +2226,6 @@ void cpu_init(void) struct task_struct *cur = current; int cpu = raw_smp_processor_id(); - wait_for_master_cpu(cpu); - ucode_cpu_init(cpu); #ifdef CONFIG_NUMA @@ -2293,18 +2278,6 @@ void cpu_init(void) load_fixmap_gdt(cpu); } -#ifdef CONFIG_SMP -void cpu_init_secondary(void) -{ - /* - * Relies on the BP having set-up the IDT tables, which are loaded - * on this CPU in cpu_init_exception_handling(). - */ - cpu_init_exception_handling(); - cpu_init(); -} -#endif - #ifdef CONFIG_MICROCODE_LATE_LOADING /** * store_cpu_caps() - Store a snapshot of CPU capabilities --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -220,6 +220,17 @@ static void ap_calibrate_delay(void) cpu_data(smp_processor_id()).loops_per_jiffy = loops_per_jiffy; } +static void wait_for_master_cpu(int cpu) +{ + /* + * Wait for release by control CPU before continuing with AP + * initialization. + */ + WARN_ON(cpumask_test_and_set_cpu(cpu, cpu_initialized_mask)); + while (!cpumask_test_cpu(cpu, cpu_callout_mask)) + cpu_relax(); +} + /* * Activate a secondary processor. */ @@ -237,13 +248,16 @@ static void notrace start_secondary(void load_cr3(swapper_pg_dir); __flush_tlb_all(); #endif + cpu_init_exception_handling(); + /* - * Sync point with wait_cpu_initialized(). Before proceeding through - * cpu_init(), the AP will call wait_for_master_cpu() which sets its - * own bit in cpu_initialized_mask and then waits for the BSP to set - * its bit in cpu_callout_mask to release it. + * Sync point with wait_cpu_initialized(). Sets AP in + * cpu_initialized_mask and then waits for the control CPU + * to release it. */ - cpu_init_secondary(); + wait_for_master_cpu(raw_smp_processor_id()); + + cpu_init(); rcu_cpu_starting(raw_smp_processor_id()); x86_cpuinit.early_percpu_clock_init(); From xen-devel-bounces@lists.xenproject.org Mon May 08 19:43:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:43:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531752.827592 (Exim 4.92) (envelope-from ) id 1pw6ls-0006m6-R7; Mon, 08 May 2023 19:43:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531752.827592; Mon, 08 May 2023 19:43:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6ls-0006ks-LP; Mon, 08 May 2023 19:43:44 +0000 Received: by outflank-mailman (input) for mailman id 531752; Mon, 08 May 2023 19:43:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6lr-0004Y5-58 for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:43:43 +0000 Received: from galois.linutronix.de (galois.linutronix.de [2a0a:51c0:0:12e:550::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a1cf5cbf-edd8-11ed-8611-37d641c3527e; Mon, 08 May 2023 21:43:41 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a1cf5cbf-edd8-11ed-8611-37d641c3527e Message-ID: <20230508185217.671595388@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575020; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=0q1aETu6bFeN3kD2/0xHoCf/51ZXAzUMjn9pP2AnX0s=; b=cVh3jWdyX+zcrRH936wg6/kt9IRtzA5ofxglmadS4D7yqxXjL+vTnFNlQsOMEiiXu8XUFn oOgQ7PQuxs7incQUDCiP1F1nybF0Kpl9Rx7yedKtJv18/UtElco0r+y+ebysJ8v8BmVIMf tzuEGK9VFeV1JAjK0Rj0BmHngpw8FuJJSGigGCnANdFiBVVRiGWMdyHiHbTp9127mH2nr9 ExHcBiTrkoX8YaNmTVJycyoKtdznubwLMVJnHxRoPZNsXHvb5tjynNcMh7iWyq39QScM1f ydIGmovKSBPRr3E0k5xQldSo30IfRQmhDh/Bo/a3TW3dGSYKRC7eC/Me28ck1Q== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575020; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=0q1aETu6bFeN3kD2/0xHoCf/51ZXAzUMjn9pP2AnX0s=; b=wG2ubOdBEVCcWDlSU4MGXW9jUu84w7IsaGsYdweGau1DadNC3D/VSWHEhMpzsnuTaDB8jW jkp8XTT9SW4h9uCw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" , David Woodhouse Subject: [patch v3 08/36] x86/smpboot: Split up native_cpu_up() into separate phases and document them References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:43:39 +0200 (CEST) From: David Woodhouse There are four logical parts to what native_cpu_up() does on the BSP (or on the controlling CPU for a later hotplug): 1) Wake the AP by sending the INIT/SIPI/SIPI sequence. 2) Wait for the AP to make it as far as wait_for_master_cpu() which sets that CPU's bit in cpu_initialized_mask, then sets the bit in cpu_callout_mask to let the AP proceed through cpu_init(). 3) Wait for the AP to finish cpu_init() and get as far as the smp_callin() call, which sets that CPU's bit in cpu_callin_mask. 4) Perform the TSC synchronization and wait for the AP to actually mark itself online in cpu_online_mask. In preparation to allow these phases to operate in parallel on multiple APs, split them out into separate functions and document the interactions a little more clearly in both the BP and AP code paths. No functional change intended. Signed-off-by: David Woodhouse Signed-off-by: Thomas Gleixner Tested-by: Michael Kelley --- arch/x86/kernel/smpboot.c | 187 +++++++++++++++++++++++++++++----------------- 1 file changed, 121 insertions(+), 66 deletions(-) --- --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -193,6 +193,10 @@ static void smp_callin(void) wmb(); + /* + * This runs the AP through all the cpuhp states to its target + * state (CPUHP_ONLINE in the case of serial bringup). + */ notify_cpu_starting(cpuid); /* @@ -233,14 +237,31 @@ static void notrace start_secondary(void load_cr3(swapper_pg_dir); __flush_tlb_all(); #endif + /* + * Sync point with wait_cpu_initialized(). Before proceeding through + * cpu_init(), the AP will call wait_for_master_cpu() which sets its + * own bit in cpu_initialized_mask and then waits for the BSP to set + * its bit in cpu_callout_mask to release it. + */ cpu_init_secondary(); rcu_cpu_starting(raw_smp_processor_id()); x86_cpuinit.early_percpu_clock_init(); + + /* + * Sync point with wait_cpu_callin(). The AP doesn't wait here + * but just sets the bit to let the controlling CPU (BSP) know that + * it's got this far. + */ smp_callin(); - /* otherwise gcc will move up smp_processor_id before the cpu_init */ + /* Otherwise gcc will move up smp_processor_id() before cpu_init() */ barrier(); - /* Check TSC synchronization with the control CPU: */ + + /* + * Check TSC synchronization with the control CPU, which will do + * its part of this from wait_cpu_online(), making it an implicit + * synchronization point. + */ check_tsc_sync_target(); /* @@ -259,6 +280,7 @@ static void notrace start_secondary(void * half valid vector space. */ lock_vector_lock(); + /* Sync point with do_wait_cpu_online() */ set_cpu_online(smp_processor_id(), true); lapic_online(); unlock_vector_lock(); @@ -981,17 +1003,13 @@ int common_cpu_up(unsigned int cpu, stru /* * NOTE - on most systems this is a PHYSICAL apic ID, but on multiquad * (ie clustered apic addressing mode), this is a LOGICAL apic ID. - * Returns zero if CPU booted OK, else error code from + * Returns zero if startup was successfully sent, else error code from * ->wakeup_secondary_cpu. */ static int do_boot_cpu(int apicid, int cpu, struct task_struct *idle) { - /* start_ip had better be page-aligned! */ unsigned long start_ip = real_mode_header->trampoline_start; - unsigned long boot_error = 0; - unsigned long timeout; - #ifdef CONFIG_X86_64 /* If 64-bit wakeup method exists, use the 64-bit mode trampoline IP */ if (apic->wakeup_secondary_cpu_64) @@ -1048,60 +1066,89 @@ static int do_boot_cpu(int apicid, int c * - Use an INIT boot APIC message */ if (apic->wakeup_secondary_cpu_64) - boot_error = apic->wakeup_secondary_cpu_64(apicid, start_ip); + return apic->wakeup_secondary_cpu_64(apicid, start_ip); else if (apic->wakeup_secondary_cpu) - boot_error = apic->wakeup_secondary_cpu(apicid, start_ip); - else - boot_error = wakeup_secondary_cpu_via_init(apicid, start_ip); + return apic->wakeup_secondary_cpu(apicid, start_ip); - if (!boot_error) { - /* - * Wait 10s total for first sign of life from AP - */ - boot_error = -1; - timeout = jiffies + 10*HZ; - while (time_before(jiffies, timeout)) { - if (cpumask_test_cpu(cpu, cpu_initialized_mask)) { - /* - * Tell AP to proceed with initialization - */ - cpumask_set_cpu(cpu, cpu_callout_mask); - boot_error = 0; - break; - } - schedule(); - } - } + return wakeup_secondary_cpu_via_init(apicid, start_ip); +} - if (!boot_error) { - /* - * Wait till AP completes initial initialization - */ - while (!cpumask_test_cpu(cpu, cpu_callin_mask)) { - /* - * Allow other tasks to run while we wait for the - * AP to come online. This also gives a chance - * for the MTRR work(triggered by the AP coming online) - * to be completed in the stop machine context. - */ - schedule(); - } - } +static int wait_cpu_cpumask(unsigned int cpu, const struct cpumask *mask) +{ + unsigned long timeout; - if (x86_platform.legacy.warm_reset) { - /* - * Cleanup possible dangling ends... - */ - smpboot_restore_warm_reset_vector(); + /* + * Wait up to 10s for the CPU to report in. + */ + timeout = jiffies + 10*HZ; + while (time_before(jiffies, timeout)) { + if (cpumask_test_cpu(cpu, mask)) + return 0; + + schedule(); } + return -1; +} - return boot_error; +/* + * Bringup step two: Wait for the target AP to reach cpu_init_secondary() + * and thus wait_for_master_cpu(), then set cpu_callout_mask to allow it + * to proceed. The AP will then proceed past setting its 'callin' bit + * and end up waiting in check_tsc_sync_target() until we reach + * do_wait_cpu_online() to tend to it. + */ +static int wait_cpu_initialized(unsigned int cpu) +{ + /* + * Wait for first sign of life from AP. + */ + if (wait_cpu_cpumask(cpu, cpu_initialized_mask)) + return -1; + + cpumask_set_cpu(cpu, cpu_callout_mask); + return 0; } -int native_cpu_up(unsigned int cpu, struct task_struct *tidle) +/* + * Bringup step three: Wait for the target AP to reach smp_callin(). + * The AP is not waiting for us here so we don't need to parallelise + * this step. Not entirely clear why we care about this, since we just + * proceed directly to TSC synchronization which is the next sync + * point with the AP anyway. + */ +static void wait_cpu_callin(unsigned int cpu) +{ + while (!cpumask_test_cpu(cpu, cpu_callin_mask)) + schedule(); +} + +/* + * Bringup step four: Synchronize the TSC and wait for the target AP + * to reach set_cpu_online() in start_secondary(). + */ +static void wait_cpu_online(unsigned int cpu) { - int apicid = apic->cpu_present_to_apicid(cpu); unsigned long flags; + + /* + * Check TSC synchronization with the AP (keep irqs disabled + * while doing so): + */ + local_irq_save(flags); + check_tsc_sync_source(cpu); + local_irq_restore(flags); + + /* + * Wait for the AP to mark itself online, so the core caller + * can drop sparse_irq_lock. + */ + while (!cpu_online(cpu)) + schedule(); +} + +static int native_kick_ap(unsigned int cpu, struct task_struct *tidle) +{ + int apicid = apic->cpu_present_to_apicid(cpu); int err; lockdep_assert_irqs_enabled(); @@ -1142,25 +1189,33 @@ int native_cpu_up(unsigned int cpu, stru return err; err = do_boot_cpu(apicid, cpu, tidle); - if (err) { + if (err) pr_err("do_boot_cpu failed(%d) to wakeup CPU#%u\n", err, cpu); - return err; - } - /* - * Check TSC synchronization with the AP (keep irqs disabled - * while doing so): - */ - local_irq_save(flags); - check_tsc_sync_source(cpu); - local_irq_restore(flags); + return err; +} - while (!cpu_online(cpu)) { - cpu_relax(); - touch_nmi_watchdog(); - } +int native_cpu_up(unsigned int cpu, struct task_struct *tidle) +{ + int ret; - return 0; + ret = native_kick_ap(cpu, tidle); + if (ret) + goto out; + + ret = wait_cpu_initialized(cpu); + if (ret) + goto out; + + wait_cpu_callin(cpu); + wait_cpu_online(cpu); + +out: + /* Cleanup possible dangling ends... */ + if (x86_platform.legacy.warm_reset) + smpboot_restore_warm_reset_vector(); + + return ret; } /** From xen-devel-bounces@lists.xenproject.org Mon May 08 19:43:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:43:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531753.827602 (Exim 4.92) (envelope-from ) id 1pw6lu-000798-K3; Mon, 08 May 2023 19:43:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531753.827602; Mon, 08 May 2023 19:43:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6lu-000782-Dr; Mon, 08 May 2023 19:43:46 +0000 Received: by outflank-mailman (input) for mailman id 531753; Mon, 08 May 2023 19:43:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6lt-0004Y5-3r for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:43:45 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a3ccb2dc-edd8-11ed-8611-37d641c3527e; Mon, 08 May 2023 21:43:43 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a3ccb2dc-edd8-11ed-8611-37d641c3527e Message-ID: <20230508185217.779457690@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575023; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=hGYrzvnylJOzDXAat75Sb7qGF0AwMNGvLNaazC51fRk=; b=CF0aLnbIsxwy11PPaGSo9/qeT6BDOr9z6WOZ1n5alNxMpu2v9rWR0KwWbfAKKSqQHnu2Hn NnnSo+WQJLNlwX0V8RASx7bUePgeQQucrN8jozqHWn53CWFEZvXdW6Y2qKuXf2sMuO8LFd vPFSd9/cKf6jPiVXrKOCNBpqoC5p2O4AreHmLXAsBLw7vhozQ4sYeaLwrKGhc6krbZC3oC pq7zyVxdn/hqe1GUvju73Vol+z3Myrurw5iGjanI0WSm1tR559wW7/7IR9FR2DUET3Pet6 d9J7XLK6/DSrSBUNRugaS2ELxaaKrUV3h9/hQgurMpa7sjjcuL3FKGuJi92j9w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575023; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=hGYrzvnylJOzDXAat75Sb7qGF0AwMNGvLNaazC51fRk=; b=zBhk/M4G/ZDNvqYEqQApQE+J8NOSpsSrbhi32/stcCYNqlxvc9b49l1CCvmbf0GB531PSJ vM0+Vo+LFsbAPKDw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch v3 10/36] [patch V2 10/38] x86/cpu/cacheinfo: Remove cpu_callout_mask dependency References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:43:42 +0200 (CEST) From: Thomas Gleixner cpu_callout_mask is used for the stop machine based MTRR/PAT init. In preparation of moving the BP/AP synchronization to the core hotplug code, use a private CPU mask for cacheinfo and manage it in the starting/dying hotplug state. Signed-off-by: Thomas Gleixner Tested-by: Michael Kelley --- arch/x86/kernel/cpu/cacheinfo.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) --- --- a/arch/x86/kernel/cpu/cacheinfo.c +++ b/arch/x86/kernel/cpu/cacheinfo.c @@ -39,6 +39,8 @@ DEFINE_PER_CPU_READ_MOSTLY(cpumask_var_t /* Shared L2 cache maps */ DEFINE_PER_CPU_READ_MOSTLY(cpumask_var_t, cpu_l2c_shared_map); +static cpumask_var_t cpu_cacheinfo_mask; + /* Kernel controls MTRR and/or PAT MSRs. */ unsigned int memory_caching_control __ro_after_init; @@ -1172,8 +1174,10 @@ void cache_bp_restore(void) cache_cpu_init(); } -static int cache_ap_init(unsigned int cpu) +static int cache_ap_online(unsigned int cpu) { + cpumask_set_cpu(cpu, cpu_cacheinfo_mask); + if (!memory_caching_control || get_cache_aps_delayed_init()) return 0; @@ -1191,11 +1195,17 @@ static int cache_ap_init(unsigned int cp * lock to prevent MTRR entry changes */ stop_machine_from_inactive_cpu(cache_rendezvous_handler, NULL, - cpu_callout_mask); + cpu_cacheinfo_mask); return 0; } +static int cache_ap_offline(unsigned int cpu) +{ + cpumask_clear_cpu(cpu, cpu_cacheinfo_mask); + return 0; +} + /* * Delayed cache initialization for all AP's */ @@ -1210,9 +1220,12 @@ void cache_aps_init(void) static int __init cache_ap_register(void) { + zalloc_cpumask_var(&cpu_cacheinfo_mask, GFP_KERNEL); + cpumask_set_cpu(smp_processor_id(), cpu_cacheinfo_mask); + cpuhp_setup_state_nocalls(CPUHP_AP_CACHECTRL_STARTING, "x86/cachectrl:starting", - cache_ap_init, NULL); + cache_ap_online, cache_ap_offline); return 0; } -core_initcall(cache_ap_register); +early_initcall(cache_ap_register); From xen-devel-bounces@lists.xenproject.org Mon May 08 19:43:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:43:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531754.827607 (Exim 4.92) (envelope-from ) id 1pw6lv-0007GI-FR; Mon, 08 May 2023 19:43:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531754.827607; Mon, 08 May 2023 19:43:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6lu-0007E9-WD; Mon, 08 May 2023 19:43:47 +0000 Received: by outflank-mailman (input) for mailman id 531754; Mon, 08 May 2023 19:43:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6lt-0004GB-P8 for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:43:45 +0000 Received: from galois.linutronix.de (galois.linutronix.de [2a0a:51c0:0:12e:550::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a4b9aeee-edd8-11ed-b226-6b7b168915f2; Mon, 08 May 2023 21:43:45 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a4b9aeee-edd8-11ed-b226-6b7b168915f2 Message-ID: <20230508185217.839754797@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=yktK43K4z764grg4BmbpcU4theMKSXX2FJzQQqhK61Y=; b=GsDJK3tbruELvka1DJRhV/NBIkEqIqahXpk513esIXbZhzEt6LuYtLjMDEjqNsgBuNYBBU aogjszWzzpxIt3n/b6+BHZRPD/S6sHUTKNWfWdl+Xo0wlW8L3AezHNpIPhfG93IQnTMvae qL9nms1W2O4Q3FhzXhqnL6cf8KHcJYkuSVfabZ9D24qarslVQp6/AGSHZJDpf9mdAlyCIJ 8lekxmNQK/wp/CGIZjgt/h3NQHQ7GA1QXrdHbpcPshOA1VWYYllwHhFTGFo5DbH6WHnVTj oRS58V/dRLnQ+faNYo+4+8F9UBa9CvlRP+S+Biy7Pmm3Y33zvsFUXJAJeAv3BA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=yktK43K4z764grg4BmbpcU4theMKSXX2FJzQQqhK61Y=; b=CE24QWMJnuzTO1rGtdtOgbz8b1f7ITzm1kMtGlaJ2lzycziTmEj4vdfomqHlwq+kXe//gG VsHYBMMe+F6IB+Bw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch v3 11/36] [patch V2 11/38] x86/smpboot: Move synchronization masks to SMP boot code References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:43:44 +0200 (CEST) From: Thomas Gleixner The usage is in smpboot.c and not in the CPU initialization code. The XEN_PV usage of cpu_callout_mask is obsolete as cpu_init() not longer waits and cacheinfo has its own CPU mask now, so cpu_callout_mask can be made static too. Signed-off-by: Thomas Gleixner Tested-by: Michael Kelley --- arch/x86/include/asm/cpumask.h | 5 ----- arch/x86/kernel/cpu/common.c | 17 ----------------- arch/x86/kernel/smpboot.c | 16 ++++++++++++++++ arch/x86/xen/smp_pv.c | 3 --- 4 files changed, 16 insertions(+), 25 deletions(-) --- --- a/arch/x86/include/asm/cpumask.h +++ b/arch/x86/include/asm/cpumask.h @@ -4,11 +4,6 @@ #ifndef __ASSEMBLY__ #include -extern cpumask_var_t cpu_callin_mask; -extern cpumask_var_t cpu_callout_mask; -extern cpumask_var_t cpu_initialized_mask; -extern cpumask_var_t cpu_sibling_setup_mask; - extern void setup_cpu_local_masks(void); /* --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -67,14 +67,6 @@ u32 elf_hwcap2 __read_mostly; -/* all of these masks are initialized in setup_cpu_local_masks() */ -cpumask_var_t cpu_initialized_mask; -cpumask_var_t cpu_callout_mask; -cpumask_var_t cpu_callin_mask; - -/* representing cpus for which sibling maps can be computed */ -cpumask_var_t cpu_sibling_setup_mask; - /* Number of siblings per CPU package */ int smp_num_siblings = 1; EXPORT_SYMBOL(smp_num_siblings); @@ -169,15 +161,6 @@ static void ppin_init(struct cpuinfo_x86 clear_cpu_cap(c, info->feature); } -/* correctly size the local cpu masks */ -void __init setup_cpu_local_masks(void) -{ - alloc_bootmem_cpumask_var(&cpu_initialized_mask); - alloc_bootmem_cpumask_var(&cpu_callin_mask); - alloc_bootmem_cpumask_var(&cpu_callout_mask); - alloc_bootmem_cpumask_var(&cpu_sibling_setup_mask); -} - static void default_init(struct cpuinfo_x86 *c) { #ifdef CONFIG_X86_64 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -101,6 +101,13 @@ EXPORT_PER_CPU_SYMBOL(cpu_die_map); DEFINE_PER_CPU_READ_MOSTLY(struct cpuinfo_x86, cpu_info); EXPORT_PER_CPU_SYMBOL(cpu_info); +/* All of these masks are initialized in setup_cpu_local_masks() */ +static cpumask_var_t cpu_initialized_mask; +static cpumask_var_t cpu_callout_mask; +static cpumask_var_t cpu_callin_mask; +/* Representing CPUs for which sibling maps can be computed */ +static cpumask_var_t cpu_sibling_setup_mask; + /* Logical package management. We might want to allocate that dynamically */ unsigned int __max_logical_packages __read_mostly; EXPORT_SYMBOL(__max_logical_packages); @@ -1548,6 +1555,15 @@ early_param("possible_cpus", _setup_poss set_cpu_possible(i, true); } +/* correctly size the local cpu masks */ +void __init setup_cpu_local_masks(void) +{ + alloc_bootmem_cpumask_var(&cpu_initialized_mask); + alloc_bootmem_cpumask_var(&cpu_callin_mask); + alloc_bootmem_cpumask_var(&cpu_callout_mask); + alloc_bootmem_cpumask_var(&cpu_sibling_setup_mask); +} + #ifdef CONFIG_HOTPLUG_CPU /* Recompute SMT state for all CPUs on offline */ --- a/arch/x86/xen/smp_pv.c +++ b/arch/x86/xen/smp_pv.c @@ -254,15 +254,12 @@ cpu_initialize_context(unsigned int cpu, struct desc_struct *gdt; unsigned long gdt_mfn; - /* used to tell cpu_init() that it can proceed with initialization */ - cpumask_set_cpu(cpu, cpu_callout_mask); if (cpumask_test_and_set_cpu(cpu, xen_cpu_initialized_map)) return 0; ctxt = kzalloc(sizeof(*ctxt), GFP_KERNEL); if (ctxt == NULL) { cpumask_clear_cpu(cpu, xen_cpu_initialized_map); - cpumask_clear_cpu(cpu, cpu_callout_mask); return -ENOMEM; } From xen-devel-bounces@lists.xenproject.org Mon May 08 19:43:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:43:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531756.827622 (Exim 4.92) (envelope-from ) id 1pw6lx-0007vJ-MJ; Mon, 08 May 2023 19:43:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531756.827622; Mon, 08 May 2023 19:43:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6lx-0007tc-FE; Mon, 08 May 2023 19:43:49 +0000 Received: by outflank-mailman (input) for mailman id 531756; Mon, 08 May 2023 19:43:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6lw-0004Y5-F4 for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:43:48 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a5b515e3-edd8-11ed-8611-37d641c3527e; Mon, 08 May 2023 21:43:46 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a5b515e3-edd8-11ed-8611-37d641c3527e Message-ID: <20230508185217.898282342@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575026; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=WRyTY63fFKNT8NNe9pdrXSxP97ZO9fcfInZz6PguA8M=; b=1cHMH34GyxfIxkvmlBecr+5mzqthYk0E5c5P4+XqqcL8e6XurHWWxoOFIeJNtH/QSimVPW 18V4fky6NzTdKRpcATR0yTdNUZbSMxJNRORImkmezodXTP7pe74xPQQAr7BpbhkgTBLmJ9 9+OjV54jcwTxOTA+n9J3KUmsDNgl2gb3hdT1mCXG5keQW7p23s7uTtMRmJhNI8qHCATek2 VFYxci2MRuYhxjE+yAzrFzousZ3auxKM0KBHlEanvL+LGxBtvIkKatD++/+hdxq+0bTgJP Q8JQ6UU2zRO8a9/lotv6c8YTYGM7ip1GcZN4ZI6sLMyO//NiTtDVmoUIAZOoIQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575026; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=WRyTY63fFKNT8NNe9pdrXSxP97ZO9fcfInZz6PguA8M=; b=a+XTx0gdMg20467/DY65JXjTt0K7JO0GQA4Eac40m+yQL/vp4DDGDsEbZstdM86jzLh2iO AyCWRRDCHHJEPTBg== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch v3 12/36] [patch V2 12/38] x86/smpboot: Make TSC synchronization function call based References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:43:46 +0200 (CEST) From: Thomas Gleixner Spin-waiting on the control CPU until the AP reaches the TSC synchronization is just a waste especially in the case that there is no synchronization required. As the synchronization has to run with interrupts disabled the control CPU part can just be done from a SMP function call. The upcoming AP issues that call async only in the case that synchronization is required. Signed-off-by: Thomas Gleixner Tested-by: Michael Kelley --- arch/x86/include/asm/tsc.h | 2 -- arch/x86/kernel/smpboot.c | 20 +++----------------- arch/x86/kernel/tsc_sync.c | 36 +++++++++++------------------------- 3 files changed, 14 insertions(+), 44 deletions(-) --- --- a/arch/x86/include/asm/tsc.h +++ b/arch/x86/include/asm/tsc.h @@ -55,12 +55,10 @@ extern bool tsc_async_resets; #ifdef CONFIG_X86_TSC extern bool tsc_store_and_check_tsc_adjust(bool bootcpu); extern void tsc_verify_tsc_adjust(bool resume); -extern void check_tsc_sync_source(int cpu); extern void check_tsc_sync_target(void); #else static inline bool tsc_store_and_check_tsc_adjust(bool bootcpu) { return false; } static inline void tsc_verify_tsc_adjust(bool resume) { } -static inline void check_tsc_sync_source(int cpu) { } static inline void check_tsc_sync_target(void) { } #endif --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -278,11 +278,7 @@ static void notrace start_secondary(void /* Otherwise gcc will move up smp_processor_id() before cpu_init() */ barrier(); - /* - * Check TSC synchronization with the control CPU, which will do - * its part of this from wait_cpu_online(), making it an implicit - * synchronization point. - */ + /* Check TSC synchronization with the control CPU. */ check_tsc_sync_target(); /* @@ -1144,21 +1140,11 @@ static void wait_cpu_callin(unsigned int } /* - * Bringup step four: Synchronize the TSC and wait for the target AP - * to reach set_cpu_online() in start_secondary(). + * Bringup step four: Wait for the target AP to reach set_cpu_online() in + * start_secondary(). */ static void wait_cpu_online(unsigned int cpu) { - unsigned long flags; - - /* - * Check TSC synchronization with the AP (keep irqs disabled - * while doing so): - */ - local_irq_save(flags); - check_tsc_sync_source(cpu); - local_irq_restore(flags); - /* * Wait for the AP to mark itself online, so the core caller * can drop sparse_irq_lock. --- a/arch/x86/kernel/tsc_sync.c +++ b/arch/x86/kernel/tsc_sync.c @@ -245,7 +245,6 @@ bool tsc_store_and_check_tsc_adjust(bool */ static atomic_t start_count; static atomic_t stop_count; -static atomic_t skip_test; static atomic_t test_runs; /* @@ -344,21 +343,14 @@ static inline unsigned int loop_timeout( } /* - * Source CPU calls into this - it waits for the freshly booted - * target CPU to arrive and then starts the measurement: + * The freshly booted CPU initiates this via an async SMP function call. */ -void check_tsc_sync_source(int cpu) +static void check_tsc_sync_source(void *__cpu) { + unsigned int cpu = (unsigned long)__cpu; int cpus = 2; /* - * No need to check if we already know that the TSC is not - * synchronized or if we have no TSC. - */ - if (unsynchronized_tsc()) - return; - - /* * Set the maximum number of test runs to * 1 if the CPU does not provide the TSC_ADJUST MSR * 3 if the MSR is available, so the target can try to adjust @@ -368,16 +360,9 @@ void check_tsc_sync_source(int cpu) else atomic_set(&test_runs, 3); retry: - /* - * Wait for the target to start or to skip the test: - */ - while (atomic_read(&start_count) != cpus - 1) { - if (atomic_read(&skip_test) > 0) { - atomic_set(&skip_test, 0); - return; - } + /* Wait for the target to start. */ + while (atomic_read(&start_count) != cpus - 1) cpu_relax(); - } /* * Trigger the target to continue into the measurement too: @@ -397,14 +382,14 @@ void check_tsc_sync_source(int cpu) if (!nr_warps) { atomic_set(&test_runs, 0); - pr_debug("TSC synchronization [CPU#%d -> CPU#%d]: passed\n", + pr_debug("TSC synchronization [CPU#%d -> CPU#%u]: passed\n", smp_processor_id(), cpu); } else if (atomic_dec_and_test(&test_runs) || random_warps) { /* Force it to 0 if random warps brought us here */ atomic_set(&test_runs, 0); - pr_warn("TSC synchronization [CPU#%d -> CPU#%d]:\n", + pr_warn("TSC synchronization [CPU#%d -> CPU#%u]:\n", smp_processor_id(), cpu); pr_warn("Measured %Ld cycles TSC warp between CPUs, " "turning off TSC clock.\n", max_warp); @@ -457,11 +442,12 @@ void check_tsc_sync_target(void) * SoCs the TSC is frequency synchronized, but still the TSC ADJUST * register might have been wreckaged by the BIOS.. */ - if (tsc_store_and_check_tsc_adjust(false) || tsc_clocksource_reliable) { - atomic_inc(&skip_test); + if (tsc_store_and_check_tsc_adjust(false) || tsc_clocksource_reliable) return; - } + /* Kick the control CPU into the TSC synchronization function */ + smp_call_function_single(cpumask_first(cpu_online_mask), check_tsc_sync_source, + (unsigned long *)(unsigned long)cpu, 0); retry: /* * Register this CPU's participation and wait for the From xen-devel-bounces@lists.xenproject.org Mon May 08 19:43:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:43:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531758.827632 (Exim 4.92) (envelope-from ) id 1pw6m0-00009I-6k; Mon, 08 May 2023 19:43:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531758.827632; Mon, 08 May 2023 19:43:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6m0-00008c-0T; Mon, 08 May 2023 19:43:52 +0000 Received: by outflank-mailman (input) for mailman id 531758; Mon, 08 May 2023 19:43:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6ly-0004Y5-72 for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:43:50 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a69df5ca-edd8-11ed-8611-37d641c3527e; Mon, 08 May 2023 21:43:48 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a69df5ca-edd8-11ed-8611-37d641c3527e Message-ID: <20230508185217.956149661@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=Wg+c42iei99IoWm1nks371E2WLpclL3rCuBzgiDxS/4=; b=hGH5Q6f/HoQLGtMGK7WJz/A7zrmv2hn0bYeL983aivgiXf4v9b+ajqaNl5i7LW/QDWn3Yv CjzyVuJhnnT2MTQ6URv7UGI69UsvsBWG1zH7dPI2EwrDbRFg8OckIikBMyGhGBovnfWD8V XmUIz/yp7zubm8zlGMWbg7fj6ZqT5JLEYrr3wv5vcieD7M3QALS6GCdBf3ROCwVWVU38hB NOEIIr0t8m3I9Gdi/vpb2zh2U9a/Xkq4UfM9fwUrsg+hKlBQKHaw4qrKw8pPxIK+qO4RFh x8liDY4krDFiCCbp6VzznQNqaXHfRG8xHd/bDSpXekLIHcAgYb9cNaeMexc6Vg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=Wg+c42iei99IoWm1nks371E2WLpclL3rCuBzgiDxS/4=; b=XGQUrkXzd8odT1L5UrSSf3572AUI0YZOsKhlh13Qy6i38K6kH4yV2eXaFVhbV5nn1D4aBF GzlCkIWzf1cwWLBg== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch v3 13/36] x86/smpboot: Remove cpu_callin_mask References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:43:47 +0200 (CEST) From: Thomas Gleixner Now that TSC synchronization is SMP function call based there is no reason to wait for the AP to be set in smp_callin_mask. The control CPU waits for the AP to set itself in the online mask anyway. Signed-off-by: Thomas Gleixner Tested-by: Michael Kelley --- arch/x86/kernel/smpboot.c | 61 +++++++--------------------------------------- 1 file changed, 10 insertions(+), 51 deletions(-) --- --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -104,7 +104,6 @@ EXPORT_PER_CPU_SYMBOL(cpu_info); /* All of these masks are initialized in setup_cpu_local_masks() */ static cpumask_var_t cpu_initialized_mask; static cpumask_var_t cpu_callout_mask; -static cpumask_var_t cpu_callin_mask; /* Representing CPUs for which sibling maps can be computed */ static cpumask_var_t cpu_sibling_setup_mask; @@ -167,21 +166,16 @@ static inline void smpboot_restore_warm_ */ static void smp_callin(void) { - int cpuid; + int cpuid = smp_processor_id(); /* * If waken up by an INIT in an 82489DX configuration - * cpu_callout_mask guarantees we don't get here before - * an INIT_deassert IPI reaches our local APIC, so it is - * now safe to touch our local APIC. - */ - cpuid = smp_processor_id(); - - /* - * the boot CPU has finished the init stage and is spinning - * on callin_map until we finish. We are free to set up this - * CPU, first the APIC. (this is probably redundant on most - * boards) + * cpu_callout_mask guarantees we don't get here before an + * INIT_deassert IPI reaches our local APIC, so it is now safe to + * touch our local APIC. + * + * Set up this CPU, first the APIC, which is probably redundant on + * most boards. */ apic_ap_setup(); @@ -192,7 +186,7 @@ static void smp_callin(void) * The topology information must be up to date before * calibrate_delay() and notify_cpu_starting(). */ - set_cpu_sibling_map(raw_smp_processor_id()); + set_cpu_sibling_map(cpuid); ap_init_aperfmperf(); @@ -205,11 +199,6 @@ static void smp_callin(void) * state (CPUHP_ONLINE in the case of serial bringup). */ notify_cpu_starting(cpuid); - - /* - * Allow the master to continue. - */ - cpumask_set_cpu(cpuid, cpu_callin_mask); } static void ap_calibrate_delay(void) @@ -268,11 +257,6 @@ static void notrace start_secondary(void rcu_cpu_starting(raw_smp_processor_id()); x86_cpuinit.early_percpu_clock_init(); - /* - * Sync point with wait_cpu_callin(). The AP doesn't wait here - * but just sets the bit to let the controlling CPU (BSP) know that - * it's got this far. - */ smp_callin(); /* Otherwise gcc will move up smp_processor_id() before cpu_init() */ @@ -1112,7 +1096,7 @@ static int wait_cpu_cpumask(unsigned int * and thus wait_for_master_cpu(), then set cpu_callout_mask to allow it * to proceed. The AP will then proceed past setting its 'callin' bit * and end up waiting in check_tsc_sync_target() until we reach - * do_wait_cpu_online() to tend to it. + * wait_cpu_online() to tend to it. */ static int wait_cpu_initialized(unsigned int cpu) { @@ -1127,20 +1111,7 @@ static int wait_cpu_initialized(unsigned } /* - * Bringup step three: Wait for the target AP to reach smp_callin(). - * The AP is not waiting for us here so we don't need to parallelise - * this step. Not entirely clear why we care about this, since we just - * proceed directly to TSC synchronization which is the next sync - * point with the AP anyway. - */ -static void wait_cpu_callin(unsigned int cpu) -{ - while (!cpumask_test_cpu(cpu, cpu_callin_mask)) - schedule(); -} - -/* - * Bringup step four: Wait for the target AP to reach set_cpu_online() in + * Bringup step three: Wait for the target AP to reach set_cpu_online() in * start_secondary(). */ static void wait_cpu_online(unsigned int cpu) @@ -1170,14 +1141,6 @@ static int native_kick_ap(unsigned int c } /* - * Already booted CPU? - */ - if (cpumask_test_cpu(cpu, cpu_callin_mask)) { - pr_debug("do_boot_cpu %d Already started\n", cpu); - return -ENOSYS; - } - - /* * Save current MTRR state in case it was changed since early boot * (e.g. by the ACPI SMI) to initialize new CPUs with MTRRs in sync: */ @@ -1214,7 +1177,6 @@ int native_cpu_up(unsigned int cpu, stru if (ret) goto out; - wait_cpu_callin(cpu); wait_cpu_online(cpu); out: @@ -1330,7 +1292,6 @@ void __init smp_prepare_cpus_common(void * Setup boot CPU information */ smp_store_boot_cpu_info(); /* Final full version of the data */ - cpumask_copy(cpu_callin_mask, cpumask_of(0)); mb(); for_each_possible_cpu(i) { @@ -1545,7 +1506,6 @@ early_param("possible_cpus", _setup_poss void __init setup_cpu_local_masks(void) { alloc_bootmem_cpumask_var(&cpu_initialized_mask); - alloc_bootmem_cpumask_var(&cpu_callin_mask); alloc_bootmem_cpumask_var(&cpu_callout_mask); alloc_bootmem_cpumask_var(&cpu_sibling_setup_mask); } @@ -1609,7 +1569,6 @@ static void remove_cpu_from_maps(int cpu { set_cpu_online(cpu, false); cpumask_clear_cpu(cpu, cpu_callout_mask); - cpumask_clear_cpu(cpu, cpu_callin_mask); /* was set by cpu_init() */ cpumask_clear_cpu(cpu, cpu_initialized_mask); numa_remove_cpu(cpu); From xen-devel-bounces@lists.xenproject.org Mon May 08 19:43:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:43:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531759.827638 (Exim 4.92) (envelope-from ) id 1pw6m1-0000OM-IN; Mon, 08 May 2023 19:43:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531759.827638; Mon, 08 May 2023 19:43:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6m1-0000K1-0u; Mon, 08 May 2023 19:43:53 +0000 Received: by outflank-mailman (input) for mailman id 531759; Mon, 08 May 2023 19:43:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6lz-0004Y5-H2 for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:43:51 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a79d0dee-edd8-11ed-8611-37d641c3527e; Mon, 08 May 2023 21:43:50 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a79d0dee-edd8-11ed-8611-37d641c3527e Message-ID: <20230508185218.013044883@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575029; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=BOT3gWwQF7O/1lZ9KsTIy5NWCf87k83rCpCfGL29bzE=; b=Vtkw853T/g2LgebBW2u5NvRyk/o8vkE9DVNbCjOgfsv8NQAdQ+PiRmVE3YRjVR9zyaPDpW A0CpqtisqwiF90SMSTT3dgMD9wfCYwYlyM9zgdWNPZBK6ove/DWKBEfTIBavRYG3mLpwGW gj5/U4hTXI1gfU5gMpT9O+3nSrnlgwHXON5jO7YTMsIZWUpGn1lUA7aXp/3y1CXCUYBa6o 4saDTE36mpdN94ZK/rdI32a5+qd4XpBBQ9/jSvxCD81AEctXSXlca21oVxip2aNe/i6362 k8ifgTHs2omVUbliI/3cpRSjuph/X6qOreGlkue5SVagGH6iBXC3i5IxD3kMEg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575029; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=BOT3gWwQF7O/1lZ9KsTIy5NWCf87k83rCpCfGL29bzE=; b=z0rzXlV5+Y57E7wE/hgSxsOIOaBBLImivYo4M54wyRCUx4IHVjFSQS7chfIs3CglORkucG Op/Ji4IG3mTcrvAw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch v3 14/36] [patch V2 14/38] cpu/hotplug: Rework sparse_irq locking in bringup_cpu() References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:43:49 +0200 (CEST) From: Thomas Gleixner There is no harm to hold sparse_irq lock until the upcoming CPU completes in cpuhp_online_idle(). This allows to remove cpu_online() synchronization from architecture code. Signed-off-by: Thomas Gleixner Tested-by: Michael Kelley --- kernel/cpu.c | 28 +++++++++++++++++++--------- 1 file changed, 19 insertions(+), 9 deletions(-) --- --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -558,7 +558,7 @@ static int cpuhp_kick_ap(int cpu, struct return ret; } -static int bringup_wait_for_ap(unsigned int cpu) +static int bringup_wait_for_ap_online(unsigned int cpu) { struct cpuhp_cpu_state *st = per_cpu_ptr(&cpuhp_state, cpu); @@ -579,15 +579,12 @@ static int bringup_wait_for_ap(unsigned */ if (!cpu_smt_allowed(cpu)) return -ECANCELED; - - if (st->target <= CPUHP_AP_ONLINE_IDLE) - return 0; - - return cpuhp_kick_ap(cpu, st, st->target); + return 0; } static int bringup_cpu(unsigned int cpu) { + struct cpuhp_cpu_state *st = per_cpu_ptr(&cpuhp_state, cpu); struct task_struct *idle = idle_thread_get(cpu); int ret; @@ -606,10 +603,23 @@ static int bringup_cpu(unsigned int cpu) /* Arch-specific enabling code. */ ret = __cpu_up(cpu, idle); - irq_unlock_sparse(); if (ret) - return ret; - return bringup_wait_for_ap(cpu); + goto out_unlock; + + ret = bringup_wait_for_ap_online(cpu); + if (ret) + goto out_unlock; + + irq_unlock_sparse(); + + if (st->target <= CPUHP_AP_ONLINE_IDLE) + return 0; + + return cpuhp_kick_ap(cpu, st, st->target); + +out_unlock: + irq_unlock_sparse(); + return ret; } static int finish_cpu(unsigned int cpu) From xen-devel-bounces@lists.xenproject.org Mon May 08 19:43:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:43:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531761.827644 (Exim 4.92) (envelope-from ) id 1pw6m2-0000ir-Ip; Mon, 08 May 2023 19:43:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531761.827644; Mon, 08 May 2023 19:43:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6m2-0000fj-3K; Mon, 08 May 2023 19:43:54 +0000 Received: by outflank-mailman (input) for mailman id 531761; Mon, 08 May 2023 19:43:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6m0-0004GB-BN for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:43:52 +0000 Received: from galois.linutronix.de (galois.linutronix.de [2a0a:51c0:0:12e:550::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a8b44ada-edd8-11ed-b226-6b7b168915f2; Mon, 08 May 2023 21:43:51 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a8b44ada-edd8-11ed-b226-6b7b168915f2 Message-ID: <20230508185218.070008578@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575031; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=DpwezFnftgf/NwnjaJYg18wbFoZRAK6UuAmlsWmBJR4=; b=i1TFZjgCtddkAakfxkISXw55XmrEJvUVPuQTFOFgS+oTTKVcNGhuqDExhfxWr3kSGXHZ9h Q+ujpZNUZEK3gioXPoyRZ+NzfuV4aL+sQupa7bIw509g00exAtAYyYGseE5+d40Ye/9iSn kyYz5rdl/ounEY4O9wO7ubw04Cyxxy6DTnoJB2oO2RietlbB/OitKYLkOQ8iHZAyHbfy1W bv+Q2OEIWcacTVCd+tTm0xqwTwSoZ8e7RLxQJArbSe8S99eF/7jfVItjSmrC275mG9pAip lscg+orwTig3a1iTNLS2jmVzL558VHIKrCz5q1WCRCIfLCf1r3Xa3vOeSE+ulQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575031; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=DpwezFnftgf/NwnjaJYg18wbFoZRAK6UuAmlsWmBJR4=; b=p4MipbJWjxb6AbwUz07UF9If0ACyXBwES1Mx0lUk9qi+e9Q63raPnhjjqmne+YvfK1SUP6 eRiNkcZ4g3zeVxBg== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch v3 15/36] x86/smpboot: Remove wait for cpu_online() References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:43:51 +0200 (CEST) From: Thomas Gleixner Now that the core code drops sparse_irq_lock after the idle thread synchronized, it's pointless to wait for the AP to mark itself online. Signed-off-by: Thomas Gleixner Tested-by: Michael Kelley --- arch/x86/kernel/smpboot.c | 26 ++------------------------ 1 file changed, 2 insertions(+), 24 deletions(-) --- --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -281,7 +281,6 @@ static void notrace start_secondary(void * half valid vector space. */ lock_vector_lock(); - /* Sync point with do_wait_cpu_online() */ set_cpu_online(smp_processor_id(), true); lapic_online(); unlock_vector_lock(); @@ -1110,20 +1109,6 @@ static int wait_cpu_initialized(unsigned return 0; } -/* - * Bringup step three: Wait for the target AP to reach set_cpu_online() in - * start_secondary(). - */ -static void wait_cpu_online(unsigned int cpu) -{ - /* - * Wait for the AP to mark itself online, so the core caller - * can drop sparse_irq_lock. - */ - while (!cpu_online(cpu)) - schedule(); -} - static int native_kick_ap(unsigned int cpu, struct task_struct *tidle) { int apicid = apic->cpu_present_to_apicid(cpu); @@ -1170,16 +1155,9 @@ int native_cpu_up(unsigned int cpu, stru int ret; ret = native_kick_ap(cpu, tidle); - if (ret) - goto out; - - ret = wait_cpu_initialized(cpu); - if (ret) - goto out; - - wait_cpu_online(cpu); + if (!ret) + ret = wait_cpu_initialized(cpu); -out: /* Cleanup possible dangling ends... */ if (x86_platform.legacy.warm_reset) smpboot_restore_warm_reset_vector(); From xen-devel-bounces@lists.xenproject.org Mon May 08 19:43:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:43:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531765.827658 (Exim 4.92) (envelope-from ) id 1pw6m5-0001bj-AX; Mon, 08 May 2023 19:43:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531765.827658; Mon, 08 May 2023 19:43:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6m5-0001ZA-0T; Mon, 08 May 2023 19:43:57 +0000 Received: by outflank-mailman (input) for mailman id 531765; Mon, 08 May 2023 19:43:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6m3-0004Y5-69 for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:43:55 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a9a82ceb-edd8-11ed-8611-37d641c3527e; Mon, 08 May 2023 21:43:53 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9a82ceb-edd8-11ed-8611-37d641c3527e Message-ID: <20230508185218.127315637@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=3mTnL+eNa5W0nTjOIkPEr4xfOzLcS1B04oILYIrEMyg=; b=eXpNMch9880MTyH+0Fz++N2mu/WFctp1eVVZZiPgiFCXMrCyTDadzskT0l9z0ZwlHcQvpi 9kOXC1Ff+g7cp+JCq8d1S0oE842eFc1UxgDKQQeOqkarfCqFbRshssa2KqOorq+nJ88tDD fEwDRj+DjeBHMdKLi4HMvK6U1AZG5K1eaPpGnaB41VL5++7xyatSf8XaejDnLahfRNMaFZ tRdTESS436fnKAXT9YC2WSG2YnfEsRaEZ1La5POAwvfbErvcr0mQIh0UqhWVl9XCwRW6hl L0VvqXarQ/4OtLm/Xar1BiBIJIO4YV8immaktE8lAUNSC0Bjdpx+QwPKR8ozZQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=3mTnL+eNa5W0nTjOIkPEr4xfOzLcS1B04oILYIrEMyg=; b=cOcWhFITcchL8q9j8XJqY4yP565IAGOCYm0IG0oNwqVPTKDJpWdAXEM1GM1oNZ+wZdo+zX mjuMRPU8QuqrdVDQ== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch v3 16/36] x86/xen/smp_pv: Remove wait for CPU online References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:43:52 +0200 (CEST) From: Thomas Gleixner Now that the core code drops sparse_irq_lock after the idle thread synchronized, it's pointless to wait for the AP to mark itself online. Whether the control CPU runs in a wait loop or sleeps in the core code waiting for the online operation to complete makes no difference. Signed-off-by: Thomas Gleixner Tested-by: Michael Kelley --- arch/x86/xen/smp_pv.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) --- --- a/arch/x86/xen/smp_pv.c +++ b/arch/x86/xen/smp_pv.c @@ -340,11 +340,11 @@ static int xen_pv_cpu_up(unsigned int cp xen_pmu_init(cpu); - rc = HYPERVISOR_vcpu_op(VCPUOP_up, xen_vcpu_nr(cpu), NULL); - BUG_ON(rc); - - while (cpu_report_state(cpu) != CPU_ONLINE) - HYPERVISOR_sched_op(SCHEDOP_yield, NULL); + /* + * Why is this a BUG? If the hypercall fails then everything can be + * rolled back, no? + */ + BUG_ON(HYPERVISOR_vcpu_op(VCPUOP_up, xen_vcpu_nr(cpu), NULL)); return 0; } From xen-devel-bounces@lists.xenproject.org Mon May 08 19:47:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:47:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531785.827683 (Exim 4.92) (envelope-from ) id 1pw6pc-0005bd-Ko; Mon, 08 May 2023 19:47:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531785.827683; Mon, 08 May 2023 19:47:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6pc-0005Y7-E3; Mon, 08 May 2023 19:47:36 +0000 Received: by outflank-mailman (input) for mailman id 531785; Mon, 08 May 2023 19:47:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6mE-0004Y5-Hm for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:44:06 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b0758392-edd8-11ed-8611-37d641c3527e; Mon, 08 May 2023 21:44:04 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b0758392-edd8-11ed-8611-37d641c3527e Message-ID: <20230508185218.525901017@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575044; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=p1bTZcu/tFFl7ZFXZHrWEevEsbPzi9oWCJbzAEjoRvU=; b=ro1G7PpJ83X6+w8xekc1Z+eWqsLGpjtOzo4PP6r5XIV4J/QSzXaoSgHSrgfE8UoFXJAtVZ ddPmGBBvhizIfL5MKQAHxiueGiD7SaKd8SVF5xoPIMD87HT7xLkes0Mcannkaqabpdim7S 3JJn+0HsTPLVLlf7o4k4xojJ0ha9PM09J1xPq/22Ii89ON2+9r5obP9K+fx8VKe6+Ofd/g p7PvjLDXUy1B93tSth06IG3OPn/RKQSfM5HzHrKJn2PQ/N/AB81EoHej+RLOqJotuRy5u1 RqZ9dU8p9XQKefuuGDTYHgGekuJbpsfN6iEzcsmbpxKC9VJxb72TeG+/ixZKCA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575044; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=p1bTZcu/tFFl7ZFXZHrWEevEsbPzi9oWCJbzAEjoRvU=; b=+JfvJZKkBGEOkJ0Rz4Oc2ENXcMdWjC9X0M7zDLfKJYbzqf6/zAZPUYwnaqTXpxX83jhfM1 Eek8gh5PJeZxIPBw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch v3 23/36] [patch V2 23/38] csky/smp: Switch to hotplug core state synchronization References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:44:04 +0200 (CEST) From: Thomas Gleixner Switch to the CPU hotplug core state tracking and synchronization mechanim. No functional change intended. Signed-off-by: Thomas Gleixner Tested-by: Michael Kelley --- arch/csky/Kconfig | 1 + arch/csky/include/asm/smp.h | 2 +- arch/csky/kernel/smp.c | 8 ++------ 3 files changed, 4 insertions(+), 7 deletions(-) --- --- a/arch/csky/Kconfig +++ b/arch/csky/Kconfig @@ -96,6 +96,7 @@ config CSKY select HAVE_REGS_AND_STACK_ACCESS_API select HAVE_STACKPROTECTOR select HAVE_SYSCALL_TRACEPOINTS + select HOTPLUG_CORE_SYNC_DEAD if HOTPLUG_CPU select MAY_HAVE_SPARSE_IRQ select MODULES_USE_ELF_RELA if MODULES select OF --- a/arch/csky/include/asm/smp.h +++ b/arch/csky/include/asm/smp.h @@ -23,7 +23,7 @@ void __init set_send_ipi(void (*func)(co int __cpu_disable(void); -void __cpu_die(unsigned int cpu); +static inline void __cpu_die(unsigned int cpu) { } #endif /* CONFIG_SMP */ --- a/arch/csky/kernel/smp.c +++ b/arch/csky/kernel/smp.c @@ -291,12 +291,8 @@ int __cpu_disable(void) return 0; } -void __cpu_die(unsigned int cpu) +void arch_cpuhp_cleanup_dead_cpu(unsigned int cpu) { - if (!cpu_wait_death(cpu, 5)) { - pr_crit("CPU%u: shutdown failed\n", cpu); - return; - } pr_notice("CPU%u: shutdown\n", cpu); } @@ -304,7 +300,7 @@ void __noreturn arch_cpu_idle_dead(void) { idle_task_exit(); - cpu_report_death(); + cpuhp_ap_report_dead(); while (!secondary_stack) arch_cpu_idle(); From xen-devel-bounces@lists.xenproject.org Mon May 08 19:47:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:47:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531784.827677 (Exim 4.92) (envelope-from ) id 1pw6pc-0005WG-AZ; Mon, 08 May 2023 19:47:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531784.827677; Mon, 08 May 2023 19:47:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6pc-0005Ur-5P; Mon, 08 May 2023 19:47:36 +0000 Received: by outflank-mailman (input) for mailman id 531784; Mon, 08 May 2023 19:47:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6mJ-0004Y5-88 for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:44:11 +0000 Received: from galois.linutronix.de (galois.linutronix.de [2a0a:51c0:0:12e:550::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b35bcc9b-edd8-11ed-8611-37d641c3527e; Mon, 08 May 2023 21:44:09 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b35bcc9b-edd8-11ed-8611-37d641c3527e Message-ID: <20230508185218.696553809@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575049; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=3tzd3hEIt5mPiFNhB7mGn6+j5PGwWpl970beJ0OUc/w=; b=C9XC5JI8zhwnnoQtLMIubfpUrFZX045J0qH0esdV5efaL1DfV2riv76m/cVjfmJF0fN9eF Dg9M8YbSEWBbAOdQKsXxR5bxpQ7opMqC9KZ7LG3mnhfF2YiHhuyNa2uxYzQh+4oA7V/0+Y cYy3VXWPussLtl1gvcbp245haJ5E4+9ssxa8XZloSJNIOQi4zAFNxq77aqQQmu5H6aGbpR XU+KqCkEIHDUAbHLQ4CVUIfkHOtLfNXQ5l22br1Rpz/dhbFOz00hUN+6cf2I0hZ8tRIa+X 2TI0s8Q/f+BqbSNzvYN5ujjjPbaZrYZMoD26kttduUli9cAwakgVH+aefPZcgg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575049; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=3tzd3hEIt5mPiFNhB7mGn6+j5PGwWpl970beJ0OUc/w=; b=iemtyuzb0UI5fQ6Aq9I7tT3PTD5UcdGEt1e/CnmmJ3j7zbcR7ak/dMGG4/JiCkppeVPKaa xBpQm1dpjEEo1dBQ== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" , Palmer Dabbelt Subject: [patch v3 26/36] riscv: Switch to hotplug core state synchronization References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:44:08 +0200 (CEST) From: Thomas Gleixner Switch to the CPU hotplug core state tracking and synchronization mechanim. No functional change intended. Signed-off-by: Thomas Gleixner Acked-by: Palmer Dabbelt Tested-by: Michael Kelley --- arch/riscv/Kconfig | 1 + arch/riscv/include/asm/smp.h | 2 +- arch/riscv/kernel/cpu-hotplug.c | 14 +++++++------- 3 files changed, 9 insertions(+), 8 deletions(-) --- --- a/arch/riscv/Kconfig +++ b/arch/riscv/Kconfig @@ -122,6 +122,7 @@ config RISCV select HAVE_RSEQ select HAVE_STACKPROTECTOR select HAVE_SYSCALL_TRACEPOINTS + select HOTPLUG_CORE_SYNC_DEAD if HOTPLUG_CPU select IRQ_DOMAIN select IRQ_FORCED_THREADING select KASAN_VMALLOC if KASAN --- a/arch/riscv/include/asm/smp.h +++ b/arch/riscv/include/asm/smp.h @@ -70,7 +70,7 @@ asmlinkage void smp_callin(void); #if defined CONFIG_HOTPLUG_CPU int __cpu_disable(void); -void __cpu_die(unsigned int cpu); +static inline void __cpu_die(unsigned int cpu) { } #endif /* CONFIG_HOTPLUG_CPU */ #else --- a/arch/riscv/kernel/cpu-hotplug.c +++ b/arch/riscv/kernel/cpu-hotplug.c @@ -8,6 +8,7 @@ #include #include #include +#include #include #include #include @@ -49,17 +50,15 @@ int __cpu_disable(void) return ret; } +#ifdef CONFIG_HOTPLUG_CPU /* - * Called on the thread which is asking for a CPU to be shutdown. + * Called on the thread which is asking for a CPU to be shutdown, if the + * CPU reported dead to the hotplug core. */ -void __cpu_die(unsigned int cpu) +void arch_cpuhp_cleanup_dead_cpu(unsigned int cpu) { int ret = 0; - if (!cpu_wait_death(cpu, 5)) { - pr_err("CPU %u: didn't die\n", cpu); - return; - } pr_notice("CPU%u: off\n", cpu); /* Verify from the firmware if the cpu is really stopped*/ @@ -76,9 +75,10 @@ void __noreturn arch_cpu_idle_dead(void) { idle_task_exit(); - (void)cpu_report_death(); + cpuhp_ap_report_dead(); cpu_ops[smp_processor_id()]->cpu_stop(); /* It should never reach here */ BUG(); } +#endif From xen-devel-bounces@lists.xenproject.org Mon May 08 19:47:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:47:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531782.827672 (Exim 4.92) (envelope-from ) id 1pw6pc-0005T0-27; Mon, 08 May 2023 19:47:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531782.827672; Mon, 08 May 2023 19:47:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6pb-0005Sa-Ti; Mon, 08 May 2023 19:47:35 +0000 Received: by outflank-mailman (input) for mailman id 531782; Mon, 08 May 2023 19:47:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6mY-0004GB-Vg for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:44:26 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bd2a9f97-edd8-11ed-b226-6b7b168915f2; Mon, 08 May 2023 21:44:26 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bd2a9f97-edd8-11ed-b226-6b7b168915f2 Message-ID: <20230508185219.230287961@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575065; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=3NBWNJYu3OFWIUCmAc5GXW8QVPdUswJXSMxcyKJq1tg=; b=K6CA2AWS2i4RYcmGQF5izhhtRvEH4Lqy1zX4leSX1xCbJyu2fRUt2bE/H/K1KBaD4mhPbX DXbEEuDfyoRsRnWOS+Az/SwmgLHy0tkGFwSi+d9yJ7tMxgkcQqSUw6UAeTo9FkUMHY3IUg T/DcJN7g9UpndwKZO+NAaBwlV2ov/Q5kI7PbzfEk3wlLHqSoSVXJmbX27DqtE0LGcHeJ5/ uMD6H0ks6CuxavlZamlO82S2b8EL75FhHxK4jbfs4N8WF5LaIuaXPH1KPg0hu/77zltt9Q FxeGNYCpIMpzLNNpAb0Z1xP21rZ/1pqRbky5sY5CgPzxIzrF2nbI5kpsiH2C4A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575065; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=3NBWNJYu3OFWIUCmAc5GXW8QVPdUswJXSMxcyKJq1tg=; b=wmV5ftrL9XveDdj42u5NoraYPGMS4sHOk5l7sWwCFijJk9PW7V8wwmY2iynLMZfkCTudZu C7051zfZnT0NNeAQ== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch v3 36/36] x86/smpboot/64: Implement arch_cpuhp_init_parallel_bringup() and enable it References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:44:25 +0200 (CEST) From: Thomas Gleixner Implement the validation function which tells the core code whether parallel bringup is possible. The only condition for now is that the kernel does not run in an encrypted guest as these will trap the RDMSR via #VC, which cannot be handled at that point in early startup. There was an earlier variant for AMD-SEV which used the GHBC protocol for retrieving the APIC ID via CPUID, but there is no guarantee that the initial APIC ID in CPUID is the same as the real APIC ID. There is no enforcement from the secure firmware and the hypervisor can assign APIC IDs as it sees fit as long as the ACPI/MADT table is consistent with that assignment. Unfortunately there is no RDMSR GHCB protocol at the moment, so enabling AMD-SEV guests for parallel startup needs some more thought. Intel-TDX provides a secure RDMSR hypercall, but supporting that is outside the scope of this change. Fixup announce_cpu() as e.g. on Hyper-V CPU1 is the secondary sibling of CPU0, which makes the @cpu == 1 logic in announce_cpu() fall apart. [ mikelley: Reported the announce_cpu() fallout Originally-by: David Woodhouse Signed-off-by: Thomas Gleixner Tested-by: Michael Kelley --- V2: Fixup announce_cpu() - Michael Kelley V3: Fixup announce_cpu() for real - Michael Kelley --- arch/x86/Kconfig | 3 - arch/x86/kernel/cpu/common.c | 6 -- arch/x86/kernel/smpboot.c | 87 +++++++++++++++++++++++++++++++++++-------- 3 files changed, 75 insertions(+), 21 deletions(-) --- --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -274,8 +274,9 @@ config X86 select HAVE_UNSTABLE_SCHED_CLOCK select HAVE_USER_RETURN_NOTIFIER select HAVE_GENERIC_VDSO + select HOTPLUG_PARALLEL if SMP && X86_64 select HOTPLUG_SMT if SMP - select HOTPLUG_SPLIT_STARTUP if SMP + select HOTPLUG_SPLIT_STARTUP if SMP && X86_32 select IRQ_FORCED_THREADING select NEED_PER_CPU_EMBED_FIRST_CHUNK select NEED_PER_CPU_PAGE_FIRST_CHUNK --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -2128,11 +2128,7 @@ static inline void setup_getcpu(int cpu) } #ifdef CONFIG_X86_64 -static inline void ucode_cpu_init(int cpu) -{ - if (cpu) - load_ucode_ap(); -} +static inline void ucode_cpu_init(int cpu) { } static inline void tss_setup_ist(struct tss_struct *tss) { --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -58,6 +58,7 @@ #include #include #include +#include #include #include @@ -75,7 +76,7 @@ #include #include #include -#include +#include #include #include #include @@ -128,7 +129,6 @@ int arch_update_cpu_topology(void) return retval; } - static unsigned int smpboot_warm_reset_vector_count; static inline void smpboot_setup_warm_reset_vector(unsigned long start_eip) @@ -229,16 +229,43 @@ static void notrace start_secondary(void */ cr4_init(); -#ifdef CONFIG_X86_32 - /* switch away from the initial page table */ - load_cr3(swapper_pg_dir); - __flush_tlb_all(); -#endif + /* + * 32-bit specific. 64-bit reaches this code with the correct page + * table established. Yet another historical divergence. + */ + if (IS_ENABLED(CONFIG_X86_32)) { + /* switch away from the initial page table */ + load_cr3(swapper_pg_dir); + __flush_tlb_all(); + } + cpu_init_exception_handling(); /* - * Synchronization point with the hotplug core. Sets the - * synchronization state to ALIVE and waits for the control CPU to + * 32-bit systems load the microcode from the ASM startup code for + * historical reasons. + * + * On 64-bit systems load it before reaching the AP alive + * synchronization point below so it is not part of the full per + * CPU serialized bringup part when "parallel" bringup is enabled. + * + * That's even safe when hyperthreading is enabled in the CPU as + * the core code starts the primary threads first and leaves the + * secondary threads waiting for SIPI. Loading microcode on + * physical cores concurrently is a safe operation. + * + * This covers both the Intel specific issue that concurrent + * microcode loading on SMT siblings must be prohibited and the + * vendor independent issue`that microcode loading which changes + * CPUID, MSRs etc. must be strictly serialized to maintain + * software state correctness. + */ + if (IS_ENABLED(CONFIG_X86_64)) + load_ucode_ap(); + + /* + * Synchronization point with the hotplug core. Sets this CPUs + * synchronization state to ALIVE and spin-waits for the control CPU to * release this CPU for further bringup. */ cpuhp_ap_sync_alive(); @@ -924,9 +951,9 @@ static int wakeup_secondary_cpu_via_init /* reduce the number of lines printed when booting a large cpu count system */ static void announce_cpu(int cpu, int apicid) { + static int width, node_width, first = 1; static int current_node = NUMA_NO_NODE; int node = early_cpu_to_node(cpu); - static int width, node_width; if (!width) width = num_digits(num_possible_cpus()) + 1; /* + '#' sign */ @@ -934,10 +961,10 @@ static void announce_cpu(int cpu, int ap if (!node_width) node_width = num_digits(num_possible_nodes()) + 1; /* + '#' */ - if (cpu == 1) - printk(KERN_INFO "x86: Booting SMP configuration:\n"); - if (system_state < SYSTEM_RUNNING) { + if (first) + pr_info("x86: Booting SMP configuration:\n"); + if (node != current_node) { if (current_node > (-1)) pr_cont("\n"); @@ -948,11 +975,11 @@ static void announce_cpu(int cpu, int ap } /* Add padding for the BSP */ - if (cpu == 1) + if (first) pr_cont("%*s", width + 1, " "); + first = 0; pr_cont("%*s#%d", width - num_digits(cpu), " ", cpu); - } else pr_info("Booting Node %d Processor %d APIC 0x%x\n", node, cpu, apicid); @@ -1242,6 +1269,36 @@ void __init smp_prepare_cpus_common(void set_cpu_sibling_map(0); } +#ifdef CONFIG_X86_64 +/* Establish whether parallel bringup can be supported. */ +bool __init arch_cpuhp_init_parallel_bringup(void) +{ + /* + * Encrypted guests require special handling. They enforce X2APIC + * mode but the RDMSR to read the APIC ID is intercepted and raises + * #VC or #VE which cannot be handled in the early startup code. + * + * AMD-SEV does not provide a RDMSR GHCB protocol so the early + * startup code cannot directly communicate with the secure + * firmware. The alternative solution to retrieve the APIC ID via + * CPUID(0xb), which is covered by the GHCB protocol, is not viable + * either because there is no enforcement of the CPUID(0xb) + * provided "initial" APIC ID to be the same as the real APIC ID. + * + * Intel-TDX has a secure RDMSR hypercall, but that needs to be + * implemented seperately in the low level startup ASM code. + */ + if (cc_platform_has(CC_ATTR_GUEST_STATE_ENCRYPT)) { + pr_info("Parallel CPU startup disabled due to guest state encryption\n"); + return false; + } + + smpboot_control = STARTUP_READ_APICID; + pr_debug("Parallel CPU startup enabled: 0x%08x\n", smpboot_control); + return true; +} +#endif + /* * Prepare for SMP bootup. * @max_cpus: configured maximum number of CPUs, It is a legacy parameter From xen-devel-bounces@lists.xenproject.org Mon May 08 19:47:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:47:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531786.827701 (Exim 4.92) (envelope-from ) id 1pw6pe-0006A8-48; Mon, 08 May 2023 19:47:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531786.827701; Mon, 08 May 2023 19:47:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6pe-000697-0E; Mon, 08 May 2023 19:47:38 +0000 Received: by outflank-mailman (input) for mailman id 531786; Mon, 08 May 2023 19:47:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6mX-0004GB-Dl for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:44:25 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bc32fc7e-edd8-11ed-b226-6b7b168915f2; Mon, 08 May 2023 21:44:24 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bc32fc7e-edd8-11ed-b226-6b7b168915f2 Message-ID: <20230508185219.176824543@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575064; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=aMiZ8OZ6vDaTJDCLruBwx0VdtP/fC3sP/hWfkyTStdQ=; b=yuDnwG7zN3SLTmatxCLQi6G3M2r5niq2jqlm9COB92lTFmTMZaYgZryIJ+rzTHsCHONba6 vWo0dxyJs4ESGXbgE0lFP3hCB3L6owshuQVhMMGyIHPKxrbdF1XesOdpTLgoP9tB48W8oh mouC0wKak7b/sNfOgtGV8ddHlzYxwPPZi9y6XIo/ya2YHeA0kMFIv3cjw+uxxSpUsxWDUr 9/ia6goJRJHQwRV1fF/1M6+Sa2hR4Xaf5N6IFcpZwOon0DvYoweKWPqBcr5ZaIifGmqw9E 7BWWTQJenDmhznIV/zB3Diw5xpR2mScuFAmY1LhjlhzH3b1XVCnrQpwUO8SbWw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575064; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=aMiZ8OZ6vDaTJDCLruBwx0VdtP/fC3sP/hWfkyTStdQ=; b=z+Qn0Pl/QKCqJ4Eb8oVMoc5d6bP6ce6mJl3mcAgcLTAEC9qajSvfk3Z5fjH3P38dAJ+nTB ojjVcTl/IJG6D+Dg== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" , David Woodhouse Subject: [patch v3 35/36] x86/smpboot: Support parallel startup of secondary CPUs References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:44:23 +0200 (CEST) From: David Woodhouse In parallel startup mode the APs are kicked alive by the control CPU quickly after each other and run through the early startup code in parallel. The real-mode startup code is already serialized with a bit-spinlock to protect the real-mode stack. In parallel startup mode the smpboot_control variable obviously cannot contain the Linux CPU number so the APs have to determine their Linux CPU number on their own. This is required to find the CPUs per CPU offset in order to find the idle task stack and other per CPU data. To achieve this, export the cpuid_to_apicid[] array so that each AP can find its own CPU number by searching therein based on its APIC ID. Introduce a flag in the top bits of smpboot_control which indicates that the AP should find its CPU number by reading the APIC ID from the APIC. This is required because CPUID based APIC ID retrieval can only provide the initial APIC ID, which might have been overruled by the firmware. Some AMD APUs come up with APIC ID = initial APIC ID + 0x10, so the APIC ID to CPU number lookup would fail miserably if based on CPUID. Also virtualization can make its own APIC ID assignements. The only requirement is that the APIC IDs are consistent with the APCI/MADT table. For the boot CPU or in case parallel bringup is disabled the control bits are empty and the CPU number is directly available in bit 0-23 of smpboot_control. [ tglx: Initial proof of concept patch with bitlock and APIC ID lookup ] [ dwmw2: Rework and testing, commit message, CPUID 0x1 and CPU0 support ] [ seanc: Fix stray override of initial_gs in common_cpu_up() ] [ Oleksandr Natalenko: reported suspend/resume issue fixed in x86_acpi_suspend_lowlevel ] [ tglx: Make it read the APIC ID from the APIC instead of using CPUID, split the bitlock part out ] Co-developed-by: Thomas Gleixner Co-developed-by: Brian Gerst Signed-off-by: Thomas Gleixner Signed-off-by: Brian Gerst Signed-off-by: David Woodhouse Signed-off-by: Thomas Gleixner Tested-by: Michael Kelley --- arch/x86/include/asm/apic.h | 2 + arch/x86/include/asm/apicdef.h | 5 ++- arch/x86/include/asm/smp.h | 6 +++ arch/x86/kernel/acpi/sleep.c | 9 +++++ arch/x86/kernel/apic/apic.c | 2 - arch/x86/kernel/head_64.S | 62 +++++++++++++++++++++++++++++++++++++++++ arch/x86/kernel/smpboot.c | 2 - 7 files changed, 84 insertions(+), 4 deletions(-) --- --- a/arch/x86/include/asm/apic.h +++ b/arch/x86/include/asm/apic.h @@ -55,6 +55,8 @@ extern int local_apic_timer_c2_ok; extern int disable_apic; extern unsigned int lapic_timer_period; +extern int cpuid_to_apicid[]; + extern enum apic_intr_mode_id apic_intr_mode; enum apic_intr_mode_id { APIC_PIC, --- a/arch/x86/include/asm/apicdef.h +++ b/arch/x86/include/asm/apicdef.h @@ -138,7 +138,8 @@ #define APIC_EILVT_MASKED (1 << 16) #define APIC_BASE (fix_to_virt(FIX_APIC_BASE)) -#define APIC_BASE_MSR 0x800 +#define APIC_BASE_MSR 0x800 +#define APIC_X2APIC_ID_MSR 0x802 #define XAPIC_ENABLE (1UL << 11) #define X2APIC_ENABLE (1UL << 10) @@ -162,6 +163,7 @@ #define APIC_CPUID(apicid) ((apicid) & XAPIC_DEST_CPUS_MASK) #define NUM_APIC_CLUSTERS ((BAD_APICID + 1) >> XAPIC_DEST_CPUS_SHIFT) +#ifndef __ASSEMBLY__ /* * the local APIC register structure, memory mapped. Not terribly well * tested, but we might eventually use this one in the future - the @@ -435,4 +437,5 @@ enum apic_delivery_modes { APIC_DELIVERY_MODE_EXTINT = 7, }; +#endif /* !__ASSEMBLY__ */ #endif /* _ASM_X86_APICDEF_H */ --- a/arch/x86/include/asm/smp.h +++ b/arch/x86/include/asm/smp.h @@ -200,4 +200,10 @@ extern unsigned long apic_mmio_base; #endif /* !__ASSEMBLY__ */ +/* Control bits for startup_64 */ +#define STARTUP_READ_APICID 0x80000000 + +/* Top 8 bits are reserved for control */ +#define STARTUP_PARALLEL_MASK 0xFF000000 + #endif /* _ASM_X86_SMP_H */ --- a/arch/x86/kernel/acpi/sleep.c +++ b/arch/x86/kernel/acpi/sleep.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #include "../../realmode/rm/wakeup.h" @@ -127,7 +128,13 @@ int x86_acpi_suspend_lowlevel(void) * value is in the actual %rsp register. */ current->thread.sp = (unsigned long)temp_stack + sizeof(temp_stack); - smpboot_control = smp_processor_id(); + /* + * Ensure the CPU knows which one it is when it comes back, if + * it isn't in parallel mode and expected to work that out for + * itself. + */ + if (!(smpboot_control & STARTUP_PARALLEL_MASK)) + smpboot_control = smp_processor_id(); #endif initial_code = (unsigned long)wakeup_long64; saved_magic = 0x123456789abcdef0L; --- a/arch/x86/kernel/apic/apic.c +++ b/arch/x86/kernel/apic/apic.c @@ -2380,7 +2380,7 @@ static int nr_logical_cpuids = 1; /* * Used to store mapping between logical CPU IDs and APIC IDs. */ -static int cpuid_to_apicid[] = { +int cpuid_to_apicid[] = { [0 ... NR_CPUS - 1] = -1, }; --- a/arch/x86/kernel/head_64.S +++ b/arch/x86/kernel/head_64.S @@ -24,7 +24,9 @@ #include "../entry/calling.h" #include #include +#include #include +#include /* * We are not able to switch in one step to the final KERNEL ADDRESS SPACE @@ -234,8 +236,68 @@ SYM_INNER_LABEL(secondary_startup_64_no_ ANNOTATE_NOENDBR // above #ifdef CONFIG_SMP + /* + * For parallel boot, the APIC ID is read from the APIC, and then + * used to look up the CPU number. For booting a single CPU, the + * CPU number is encoded in smpboot_control. + * + * Bit 31 STARTUP_READ_APICID (Read APICID from APIC) + * Bit 0-23 CPU# if STARTUP_xx flags are not set + */ movl smpboot_control(%rip), %ecx + testl $STARTUP_READ_APICID, %ecx + jnz .Lread_apicid + /* + * No control bit set, single CPU bringup. CPU number is provided + * in bit 0-23. This is also the boot CPU case (CPU number 0). + */ + andl $(~STARTUP_PARALLEL_MASK), %ecx + jmp .Lsetup_cpu + +.Lread_apicid: + /* Check whether X2APIC mode is already enabled */ + mov $MSR_IA32_APICBASE, %ecx + rdmsr + testl $X2APIC_ENABLE, %eax + jnz .Lread_apicid_msr + + /* Read the APIC ID from the fix-mapped MMIO space. */ + movq apic_mmio_base(%rip), %rcx + addq $APIC_ID, %rcx + movl (%rcx), %eax + shr $24, %eax + jmp .Llookup_AP + +.Lread_apicid_msr: + mov $APIC_X2APIC_ID_MSR, %ecx + rdmsr + +.Llookup_AP: + /* EAX contains the APIC ID of the current CPU */ + xorq %rcx, %rcx + leaq cpuid_to_apicid(%rip), %rbx + +.Lfind_cpunr: + cmpl (%rbx,%rcx,4), %eax + jz .Lsetup_cpu + inc %ecx +#ifdef CONFIG_FORCE_NR_CPUS + cmpl $NR_CPUS, %ecx +#else + cmpl nr_cpu_ids(%rip), %ecx +#endif + jb .Lfind_cpunr + + /* APIC ID not found in the table. Drop the trampoline lock and bail. */ + movq trampoline_lock(%rip), %rax + lock + btrl $0, (%rax) + +1: cli + hlt + jmp 1b +.Lsetup_cpu: /* Get the per cpu offset for the given CPU# which is in ECX */ movq __per_cpu_offset(,%rcx,8), %rdx #else --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -1002,7 +1002,7 @@ static int do_boot_cpu(int apicid, int c if (IS_ENABLED(CONFIG_X86_32)) { early_gdt_descr.address = (unsigned long)get_cpu_gdt_rw(cpu); initial_stack = idle->thread.sp; - } else { + } else if (!(smpboot_control & STARTUP_PARALLEL_MASK)) { smpboot_control = cpu; } From xen-devel-bounces@lists.xenproject.org Mon May 08 19:47:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:47:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531789.827707 (Exim 4.92) (envelope-from ) id 1pw6pe-0006G2-Ki; Mon, 08 May 2023 19:47:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531789.827707; Mon, 08 May 2023 19:47:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6pe-0006En-CI; Mon, 08 May 2023 19:47:38 +0000 Received: by outflank-mailman (input) for mailman id 531789; Mon, 08 May 2023 19:47:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6mW-0004Y5-IW for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:44:24 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bb3b1bbb-edd8-11ed-8611-37d641c3527e; Mon, 08 May 2023 21:44:22 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bb3b1bbb-edd8-11ed-8611-37d641c3527e Message-ID: <20230508185219.123719053@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=6WUCUG1CCgVCdNI4CLJSTwJWrFInFv2K4B15hgoY0Kw=; b=2Bs14rnpSX2uI3czdlUR6dxpOrB8cEiRoXze+GgpUpTrI18Aq7yjGjS1XrIAZlUcMz3uMd 81Ee1d8CAuUMu/Cea+MINgrvBWHwWj7aDMuNr9CKHOJX1LeWVUg0eeYcWQU9yCm43mA5jI nFRUbISTZF5fup1DHvzKGJ2Ro5zcwHRYKT108/qXaIregxzdzIyi6qtb0OSPviLcC3U5Mv hOogc1YJR/1XoEgdejSpRreCY8gNmg522997lkxJczmDMtlDTe0lWlFMtvRe2lPbkikk5B AJmhANjWq9Jk3iE2vBuDwP6T9O4FvPd4wQJubneDx2wjQYPHoPvHEFI2vraUuA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=6WUCUG1CCgVCdNI4CLJSTwJWrFInFv2K4B15hgoY0Kw=; b=hCFX0auSqHWTem7lXZILDzRTaJhCgFeurJJC+rgTLqc9kN9+C6WS+qXnmDMKwZNzqpefKl nTGLqooH8Ea+o8DQ== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" , David Woodhouse Subject: [patch v3 34/36] x86/smpboot: Implement a bit spinlock to protect the realmode stack References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:44:22 +0200 (CEST) From: Thomas Gleixner Parallel AP bringup requires that the APs can run fully parallel through the early startup code including the real mode trampoline. To prepare for this implement a bit-spinlock to serialize access to the real mode stack so that parallel upcoming APs are not going to corrupt each others stack while going through the real mode startup code. Co-developed-by: David Woodhouse Signed-off-by: David Woodhouse Signed-off-by: Thomas Gleixner Tested-by: Michael Kelley --- arch/x86/include/asm/realmode.h | 3 +++ arch/x86/kernel/head_64.S | 13 +++++++++++++ arch/x86/realmode/init.c | 3 +++ arch/x86/realmode/rm/trampoline_64.S | 27 ++++++++++++++++++++++----- 4 files changed, 41 insertions(+), 5 deletions(-) --- --- a/arch/x86/include/asm/realmode.h +++ b/arch/x86/include/asm/realmode.h @@ -52,6 +52,7 @@ struct trampoline_header { u64 efer; u32 cr4; u32 flags; + u32 lock; #endif }; @@ -64,6 +65,8 @@ extern unsigned long initial_stack; extern unsigned long initial_vc_handler; #endif +extern u32 *trampoline_lock; + extern unsigned char real_mode_blob[]; extern unsigned char real_mode_relocs[]; --- a/arch/x86/kernel/head_64.S +++ b/arch/x86/kernel/head_64.S @@ -252,6 +252,17 @@ SYM_INNER_LABEL(secondary_startup_64_no_ movq TASK_threadsp(%rax), %rsp /* + * Now that this CPU is running on its own stack, drop the realmode + * protection. For the boot CPU the pointer is NULL! + */ + movq trampoline_lock(%rip), %rax + testq %rax, %rax + jz .Lsetup_gdt + lock + btrl $0, (%rax) + +.Lsetup_gdt: + /* * We must switch to a new descriptor in kernel space for the GDT * because soon the kernel won't have access anymore to the userspace * addresses where we're currently running on. We have to do that here @@ -433,6 +444,8 @@ SYM_DATA(initial_code, .quad x86_64_star #ifdef CONFIG_AMD_MEM_ENCRYPT SYM_DATA(initial_vc_handler, .quad handle_vc_boot_ghcb) #endif + +SYM_DATA(trampoline_lock, .quad 0); __FINITDATA __INIT --- a/arch/x86/realmode/init.c +++ b/arch/x86/realmode/init.c @@ -154,6 +154,9 @@ static void __init setup_real_mode(void) trampoline_header->flags = 0; + trampoline_lock = &trampoline_header->lock; + *trampoline_lock = 0; + trampoline_pgd = (u64 *) __va(real_mode_header->trampoline_pgd); /* Map the real mode stub as virtual == physical */ --- a/arch/x86/realmode/rm/trampoline_64.S +++ b/arch/x86/realmode/rm/trampoline_64.S @@ -37,6 +37,24 @@ .text .code16 +.macro LOAD_REALMODE_ESP + /* + * Make sure only one CPU fiddles with the realmode stack + */ +.Llock_rm\@: + btl $0, tr_lock + jnc 2f + pause + jmp .Llock_rm\@ +2: + lock + btsl $0, tr_lock + jc .Llock_rm\@ + + # Setup stack + movl $rm_stack_end, %esp +.endm + .balign PAGE_SIZE SYM_CODE_START(trampoline_start) cli # We should be safe anyway @@ -49,8 +67,7 @@ SYM_CODE_START(trampoline_start) mov %ax, %es mov %ax, %ss - # Setup stack - movl $rm_stack_end, %esp + LOAD_REALMODE_ESP call verify_cpu # Verify the cpu supports long mode testl %eax, %eax # Check for return code @@ -93,8 +110,7 @@ SYM_CODE_START(sev_es_trampoline_start) mov %ax, %es mov %ax, %ss - # Setup stack - movl $rm_stack_end, %esp + LOAD_REALMODE_ESP jmp .Lswitch_to_protected SYM_CODE_END(sev_es_trampoline_start) @@ -177,7 +193,7 @@ SYM_CODE_START(pa_trampoline_compat) * In compatibility mode. Prep ESP and DX for startup_32, then disable * paging and complete the switch to legacy 32-bit mode. */ - movl $rm_stack_end, %esp + LOAD_REALMODE_ESP movw $__KERNEL_DS, %dx movl $(CR0_STATE & ~X86_CR0_PG), %eax @@ -241,6 +257,7 @@ SYM_DATA_START(trampoline_header) SYM_DATA(tr_efer, .space 8) SYM_DATA(tr_cr4, .space 4) SYM_DATA(tr_flags, .space 4) + SYM_DATA(tr_lock, .space 4) SYM_DATA_END(trampoline_header) #include "trampoline_common.S" From xen-devel-bounces@lists.xenproject.org Mon May 08 19:47:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:47:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531791.827721 (Exim 4.92) (envelope-from ) id 1pw6pg-0006i2-1k; Mon, 08 May 2023 19:47:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531791.827721; Mon, 08 May 2023 19:47:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6pf-0006hS-P6; Mon, 08 May 2023 19:47:39 +0000 Received: by outflank-mailman (input) for mailman id 531791; Mon, 08 May 2023 19:47:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6mT-0004Y5-83 for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:44:21 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b9373003-edd8-11ed-8611-37d641c3527e; Mon, 08 May 2023 21:44:19 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b9373003-edd8-11ed-8611-37d641c3527e Message-ID: <20230508185219.016841363@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575059; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=209TLBvRBeEafFURgM0Y1ht7eQ7Y0xFjxVmui7BNI1o=; b=n00hUXstsdyfUPFcrDAYr9qfqXyIIcwLYM+NMXKmbpRXuAwK6NgEAWLRBbou/zHFnXIEod 8New7so5w76Tb6aP+ykkJPN+I2CJwBwHZMzePhRQEpwGX52DB5Z1gdG558koxONpDK5vHV Nw3vZn8ZYXWXENECHg8/+P4uLipUY5x32lSL0Ye9CYi84jhqQ0/1HAPCNaEXglJl15NFbz zfcfgBtb+CGqOrVf91xrpFIeSR0Cfa5oQ5LpNyu3yK2Hb8OUT10cao1Vz6GemRAHhna574 D0JjHpAmGP3ofXOD9DehizPjgrf0doKL7iorp17NI6K6epm+KVwswpLQO+EHLA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575059; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=209TLBvRBeEafFURgM0Y1ht7eQ7Y0xFjxVmui7BNI1o=; b=HZPvGLiAxw+6fgkpd1LobrgVgwanW2gWFTwlrLJ+Qy03Ucp5K4TQSj/S8iTBeqfZ2ooZAu VgXE2xAvT1s4U6AA== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" , David Woodhouse Subject: [patch v3 32/36] cpu/hotplug: Allow "parallel" bringup up to CPUHP_BP_KICK_AP_STATE References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:44:18 +0200 (CEST) From: Thomas Gleixner There is often significant latency in the early stages of CPU bringup, and time is wasted by waking each CPU (e.g. with SIPI/INIT/INIT on x86) and then waiting for it to respond before moving on to the next. Allow a platform to enable parallel setup which brings all to be onlined CPUs up to the CPUHP_BP_KICK_AP state. While this state advancement on the control CPU (BP) is single-threaded the important part is the last state CPUHP_BP_KICK_AP which wakes the to be onlined CPUs up. This allows the CPUs to run up to the first sychronization point cpuhp_ap_sync_alive() where they wait for the control CPU to release them one by one for the full onlining procedure. This parallelism depends on the CPU hotplug core sync mechanism which ensures that the parallel brought up CPUs wait for release before touching any state which would make the CPU visible to anything outside the hotplug control mechanism. To handle the SMT constraints of X86 correctly the bringup happens in two iterations when CONFIG_HOTPLUG_SMT is enabled. The control CPU brings up the primary SMT threads of each core first, which can load the microcode without the need to rendevouz with the thread siblings. Once that's completed it brings up the secondary SMT threads. Co-developed-by: David Woodhouse Signed-off-by: David Woodhouse Signed-off-by: Thomas Gleixner Tested-by: Michael Kelley --- Documentation/admin-guide/kernel-parameters.txt | 6 + arch/Kconfig | 4 include/linux/cpuhotplug.h | 1 kernel/cpu.c | 103 ++++++++++++++++++++++-- 4 files changed, 109 insertions(+), 5 deletions(-) --- --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -838,6 +838,12 @@ on every CPU online, such as boot, and resume from suspend. Default: 10000 + cpuhp.parallel= + [SMP] Enable/disable parallel bringup of secondary CPUs + Format: + Default is enabled if CONFIG_HOTPLUG_PARALLEL=y. Otherwise + the parameter has no effect. + crash_kexec_post_notifiers Run kdump after running panic-notifiers and dumping kmsg. This only for the users who doubt kdump always --- a/arch/Kconfig +++ b/arch/Kconfig @@ -53,6 +53,10 @@ config HOTPLUG_SPLIT_STARTUP bool select HOTPLUG_CORE_SYNC_FULL +config HOTPLUG_PARALLEL + bool + select HOTPLUG_SPLIT_STARTUP + config GENERIC_ENTRY bool --- a/include/linux/cpuhotplug.h +++ b/include/linux/cpuhotplug.h @@ -524,6 +524,7 @@ void cpuhp_ap_sync_alive(void); void arch_cpuhp_sync_state_poll(void); void arch_cpuhp_cleanup_kick_cpu(unsigned int cpu); int arch_cpuhp_kick_ap_alive(unsigned int cpu, struct task_struct *tidle); +bool arch_cpuhp_init_parallel_bringup(void); #ifdef CONFIG_HOTPLUG_CORE_SYNC_DEAD void cpuhp_ap_report_dead(void); --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -649,8 +649,23 @@ bool cpu_smt_possible(void) cpu_smt_control != CPU_SMT_NOT_SUPPORTED; } EXPORT_SYMBOL_GPL(cpu_smt_possible); + +static inline bool cpuhp_smt_aware(void) +{ + return topology_smt_supported(); +} + +static inline const struct cpumask *cpuhp_get_primary_thread_mask(void) +{ + return cpu_primary_thread_mask; +} #else static inline bool cpu_smt_allowed(unsigned int cpu) { return true; } +static inline bool cpuhp_smt_aware(void) { return false; } +static inline const struct cpumask *cpuhp_get_primary_thread_mask(void) +{ + return cpu_present_mask; +} #endif static inline enum cpuhp_state @@ -1743,16 +1758,94 @@ int bringup_hibernate_cpu(unsigned int s return 0; } -void __init bringup_nonboot_cpus(unsigned int setup_max_cpus) +static void __init cpuhp_bringup_mask(const struct cpumask *mask, unsigned int ncpus, + enum cpuhp_state target) { unsigned int cpu; - for_each_present_cpu(cpu) { - if (num_online_cpus() >= setup_max_cpus) + for_each_cpu(cpu, mask) { + struct cpuhp_cpu_state *st = per_cpu_ptr(&cpuhp_state, cpu); + + if (!--ncpus) break; - if (!cpu_online(cpu)) - cpu_up(cpu, CPUHP_ONLINE); + + if (cpu_up(cpu, target) && can_rollback_cpu(st)) { + /* + * If this failed then cpu_up() might have only + * rolled back to CPUHP_BP_KICK_AP for the final + * online. Clean it up. NOOP if already rolled back. + */ + WARN_ON(cpuhp_invoke_callback_range(false, cpu, st, CPUHP_OFFLINE)); + } + } +} + +#ifdef CONFIG_HOTPLUG_PARALLEL +static bool __cpuhp_parallel_bringup __ro_after_init = true; + +static int __init parallel_bringup_parse_param(char *arg) +{ + return kstrtobool(arg, &__cpuhp_parallel_bringup); +} +early_param("cpuhp.parallel", parallel_bringup_parse_param); + +/* + * On architectures which have enabled parallel bringup this invokes all BP + * prepare states for each of the to be onlined APs first. The last state + * sends the startup IPI to the APs. The APs proceed through the low level + * bringup code in parallel and then wait for the control CPU to release + * them one by one for the final onlining procedure. + * + * This avoids waiting for each AP to respond to the startup IPI in + * CPUHP_BRINGUP_CPU. + */ +static bool __init cpuhp_bringup_cpus_parallel(unsigned int ncpus) +{ + const struct cpumask *mask = cpu_present_mask; + + if (__cpuhp_parallel_bringup) + __cpuhp_parallel_bringup = arch_cpuhp_init_parallel_bringup(); + if (!__cpuhp_parallel_bringup) + return false; + + if (cpuhp_smt_aware()) { + const struct cpumask *pmask = cpuhp_get_primary_thread_mask(); + static struct cpumask tmp_mask __initdata; + + /* + * X86 requires to prevent that SMT siblings stopped while + * the primary thread does a microcode update for various + * reasons. Bring the primary threads up first. + */ + cpumask_and(&tmp_mask, mask, pmask); + cpuhp_bringup_mask(&tmp_mask, ncpus, CPUHP_BP_KICK_AP); + cpuhp_bringup_mask(&tmp_mask, ncpus, CPUHP_ONLINE); + /* Account for the online CPUs */ + ncpus -= num_online_cpus(); + if (!ncpus) + return true; + /* Create the mask for secondary CPUs */ + cpumask_andnot(&tmp_mask, mask, pmask); + mask = &tmp_mask; } + + /* Bring the not-yet started CPUs up */ + cpuhp_bringup_mask(mask, ncpus, CPUHP_BP_KICK_AP); + cpuhp_bringup_mask(mask, ncpus, CPUHP_ONLINE); + return true; +} +#else +static inline bool cpuhp_bringup_cpus_parallel(unsigned int ncpus) { return false; } +#endif /* CONFIG_HOTPLUG_PARALLEL */ + +void __init bringup_nonboot_cpus(unsigned int setup_max_cpus) +{ + /* Try parallel bringup optimization if enabled */ + if (cpuhp_bringup_cpus_parallel(setup_max_cpus)) + return; + + /* Full per CPU serialized bringup */ + cpuhp_bringup_mask(cpu_present_mask, setup_max_cpus, CPUHP_ONLINE); } #ifdef CONFIG_PM_SLEEP_SMP From xen-devel-bounces@lists.xenproject.org Mon May 08 19:47:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:47:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531792.827728 (Exim 4.92) (envelope-from ) id 1pw6pg-0006qx-SZ; Mon, 08 May 2023 19:47:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531792.827728; Mon, 08 May 2023 19:47:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6pg-0006pV-JT; Mon, 08 May 2023 19:47:40 +0000 Received: by outflank-mailman (input) for mailman id 531792; Mon, 08 May 2023 19:47:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6mA-0004GB-3l for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:44:02 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ae6cacde-edd8-11ed-b226-6b7b168915f2; Mon, 08 May 2023 21:44:01 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae6cacde-edd8-11ed-b226-6b7b168915f2 Message-ID: <20230508185218.413540718@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575041; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=38nzuLvukobfje6Ccppy0BhMMd+JJk7+K0e3k3P15Wg=; b=x5uunjrfWzFDxVEDVb12W2XtAz1xdLN26NVHk7bMNEu2wIJNaum7qGKPG0dROx5n0HhLC+ FzBIUNB9IVFoDocC8+UO+48hmJZTHkBagkRSbcBi10tPYzBz2N+KBu3+t/DwlLjK8qgbHm Zyl2slxhswI4y0jqXj5mdHQ7jfB6T53pzIasGJrkcbdNjcE/FqTbh3cIh4s2CI2dpENglT jZGblTZh1KTfeLW19FXrR8et4/tPPGpgkP+CMulFHzL902fUKU7E5w1yXi6/rZi2EGU8tO CSr4Jls1MoB22W6EUMLB/NCwWjqQzCr6exaZi0Y+dcSIy9UXOvzD4rMbjXRcvg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575041; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=38nzuLvukobfje6Ccppy0BhMMd+JJk7+K0e3k3P15Wg=; b=OFaURbehZY+bjBk6HdPJsuKX1EooATeyF0S/YDbEsa+/7byZljllwL7I/PloYv0yfuXe68 qGHlWRIfIq35xrAg== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch v3 21/36] [patch V2 21/38] ARM: smp: Switch to hotplug core state synchronization References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:44:00 +0200 (CEST) From: Thomas Gleixner Switch to the CPU hotplug core state tracking and synchronization mechanim. No functional change intended. Signed-off-by: Thomas Gleixner Tested-by: Michael Kelley --- arch/arm/Kconfig | 1 + arch/arm/include/asm/smp.h | 2 +- arch/arm/kernel/smp.c | 18 +++++++----------- 3 files changed, 9 insertions(+), 12 deletions(-) --- --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -124,6 +124,7 @@ config ARM select HAVE_SYSCALL_TRACEPOINTS select HAVE_UID16 select HAVE_VIRT_CPU_ACCOUNTING_GEN + select HOTPLUG_CORE_SYNC_DEAD if HOTPLUG_CPU select IRQ_FORCED_THREADING select MODULES_USE_ELF_REL select NEED_DMA_MAP_STATE --- a/arch/arm/include/asm/smp.h +++ b/arch/arm/include/asm/smp.h @@ -64,7 +64,7 @@ extern void secondary_startup_arm(void); extern int __cpu_disable(void); -extern void __cpu_die(unsigned int cpu); +static inline void __cpu_die(unsigned int cpu) { } extern void arch_send_call_function_single_ipi(int cpu); extern void arch_send_call_function_ipi_mask(const struct cpumask *mask); --- a/arch/arm/kernel/smp.c +++ b/arch/arm/kernel/smp.c @@ -288,15 +288,11 @@ int __cpu_disable(void) } /* - * called on the thread which is asking for a CPU to be shutdown - - * waits until shutdown has completed, or it is timed out. + * called on the thread which is asking for a CPU to be shutdown after the + * shutdown completed. */ -void __cpu_die(unsigned int cpu) +void arch_cpuhp_cleanup_dead_cpu(unsigned int cpu) { - if (!cpu_wait_death(cpu, 5)) { - pr_err("CPU%u: cpu didn't die\n", cpu); - return; - } pr_debug("CPU%u: shutdown\n", cpu); clear_tasks_mm_cpumask(cpu); @@ -336,11 +332,11 @@ void __noreturn arch_cpu_idle_dead(void) flush_cache_louis(); /* - * Tell __cpu_die() that this CPU is now safe to dispose of. Once - * this returns, power and/or clocks can be removed at any point - * from this CPU and its cache by platform_cpu_kill(). + * Tell cpuhp_bp_sync_dead() that this CPU is now safe to dispose + * of. Once this returns, power and/or clocks can be removed at + * any point from this CPU and its cache by platform_cpu_kill(). */ - (void)cpu_report_death(); + cpuhp_ap_report_dead(); /* * Ensure that the cache lines associated with that completion are From xen-devel-bounces@lists.xenproject.org Mon May 08 19:47:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:47:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531795.827733 (Exim 4.92) (envelope-from ) id 1pw6ph-0006zW-Gb; Mon, 08 May 2023 19:47:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531795.827733; Mon, 08 May 2023 19:47:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6ph-0006xp-1q; Mon, 08 May 2023 19:47:41 +0000 Received: by outflank-mailman (input) for mailman id 531795; Mon, 08 May 2023 19:47:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6mO-0004Y5-Eu for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:44:16 +0000 Received: from galois.linutronix.de (galois.linutronix.de [2a0a:51c0:0:12e:550::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b658fe77-edd8-11ed-8611-37d641c3527e; Mon, 08 May 2023 21:44:14 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b658fe77-edd8-11ed-8611-37d641c3527e Message-ID: <20230508185218.856286839@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575054; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=S1u0Rr9+GOXQtpnupcrVF2C6hZgp3Qx9VyPMOZrmGUo=; b=oISYDK58uyxEqUGHyMJl0yjUCJNOL5/7EGvOZggKHrsRbzI+Zfvw/3LqoASrcYSbpSofdk smv5bYqSUgI37EvCpKk1bIpdP6plTO/QVQFaxEN/bX+VNPLK6e9fxhxLFDKIXJiJ8+kSiF cQZuVcY4mwsCMKCnQL+NO+4vqzlN0ZiMTQ6qbV+dFndB1QkTtSbQxRgBNU1jh3+qlg559v oxQCzKKAnn8gCc+1y89JF3fvz5z1Xn99zAaSiyaLuoBN6+lOS/ZxYYzwXkZkWIhNnC+9+0 MzcZbiKvl223hH1JPAYQnBF6gNdXhbpmdcQST4cZ+iIm+WtHU0bzyy3U3O2+oQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575054; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=S1u0Rr9+GOXQtpnupcrVF2C6hZgp3Qx9VyPMOZrmGUo=; b=AZidL7FELSVa1ikq306vI32X2wbks/dMZeZ9LLRMIVoxLB22DPBpW8f+vd00DqVCG0ZwZH HJ9bhkUAS1wb3vBg== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch v3 29/36] [patch V2 29/38] cpu/hotplug: Provide a split up CPUHP_BRINGUP mechanism References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:44:13 +0200 (CEST) From: Thomas Gleixner The bring up logic of a to be onlined CPU consists of several parts, which are considered to be a single hotplug state: 1) Control CPU issues the wake-up 2) To be onlined CPU starts up, does the minimal initialization, reports to be alive and waits for release into the complete bring-up. 3) Control CPU waits for the alive report and releases the upcoming CPU for the complete bring-up. Allow to split this into two states: 1) Control CPU issues the wake-up After that the to be onlined CPU starts up, does the minimal initialization, reports to be alive and waits for release into the full bring-up. As this can run after the control CPU dropped the hotplug locks the code which is executed on the AP before it reports alive has to be carefully audited to not violate any of the hotplug constraints, especially not modifying any of the various cpumasks. This is really only meant to avoid waiting for the AP to react on the wake-up. Of course an architecture can move strict CPU related setup functionality, e.g. microcode loading, with care before the synchronization point to save further pointless waiting time. 2) Control CPU waits for the alive report and releases the upcoming CPU for the complete bring-up. This allows that the two states can be split up to run all to be onlined CPUs up to state #1 on the control CPU and then at a later point run state #2. This spares some of the latencies of the full serialized per CPU bringup by avoiding the per CPU wakeup/wait serialization. The assumption is that the first AP already waits when the last AP has been woken up. This obvioulsy depends on the hardware latencies and depending on the timings this might still not completely eliminate all wait scenarios. This split is just a preparatory step for enabling the parallel bringup later. The boot time bringup is still fully serialized. It has a separate config switch so that architectures which want to support parallel bringup can test the split of the CPUHP_BRINGUG step separately. To enable this the architecture must support the CPU hotplug core sync mechanism and has to be audited that there are no implicit hotplug state dependencies which require a fully serialized bringup. Signed-off-by: Thomas Gleixner Tested-by: Michael Kelley --- arch/Kconfig | 4 ++ include/linux/cpuhotplug.h | 4 ++ kernel/cpu.c | 70 +++++++++++++++++++++++++++++++++++++++++++-- 3 files changed, 76 insertions(+), 2 deletions(-) --- --- a/arch/Kconfig +++ b/arch/Kconfig @@ -49,6 +49,10 @@ config HOTPLUG_CORE_SYNC_FULL select HOTPLUG_CORE_SYNC_DEAD if HOTPLUG_CPU select HOTPLUG_CORE_SYNC +config HOTPLUG_SPLIT_STARTUP + bool + select HOTPLUG_CORE_SYNC_FULL + config GENERIC_ENTRY bool --- a/include/linux/cpuhotplug.h +++ b/include/linux/cpuhotplug.h @@ -133,6 +133,7 @@ enum cpuhp_state { CPUHP_MIPS_SOC_PREPARE, CPUHP_BP_PREPARE_DYN, CPUHP_BP_PREPARE_DYN_END = CPUHP_BP_PREPARE_DYN + 20, + CPUHP_BP_KICK_AP, CPUHP_BRINGUP_CPU, /* @@ -517,9 +518,12 @@ void cpuhp_online_idle(enum cpuhp_state static inline void cpuhp_online_idle(enum cpuhp_state state) { } #endif +struct task_struct; + void cpuhp_ap_sync_alive(void); void arch_cpuhp_sync_state_poll(void); void arch_cpuhp_cleanup_kick_cpu(unsigned int cpu); +int arch_cpuhp_kick_ap_alive(unsigned int cpu, struct task_struct *tidle); #ifdef CONFIG_HOTPLUG_CORE_SYNC_DEAD void cpuhp_ap_report_dead(void); --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -761,6 +761,47 @@ static int bringup_wait_for_ap_online(un return 0; } +#ifdef CONFIG_HOTPLUG_SPLIT_STARTUP +static int cpuhp_kick_ap_alive(unsigned int cpu) +{ + if (!cpuhp_can_boot_ap(cpu)) + return -EAGAIN; + + return arch_cpuhp_kick_ap_alive(cpu, idle_thread_get(cpu)); +} + +static int cpuhp_bringup_ap(unsigned int cpu) +{ + struct cpuhp_cpu_state *st = per_cpu_ptr(&cpuhp_state, cpu); + int ret; + + /* + * Some architectures have to walk the irq descriptors to + * setup the vector space for the cpu which comes online. + * Prevent irq alloc/free across the bringup. + */ + irq_lock_sparse(); + + ret = cpuhp_bp_sync_alive(cpu); + if (ret) + goto out_unlock; + + ret = bringup_wait_for_ap_online(cpu); + if (ret) + goto out_unlock; + + irq_unlock_sparse(); + + if (st->target <= CPUHP_AP_ONLINE_IDLE) + return 0; + + return cpuhp_kick_ap(cpu, st, st->target); + +out_unlock: + irq_unlock_sparse(); + return ret; +} +#else static int bringup_cpu(unsigned int cpu) { struct cpuhp_cpu_state *st = per_cpu_ptr(&cpuhp_state, cpu); @@ -777,7 +818,6 @@ static int bringup_cpu(unsigned int cpu) */ irq_lock_sparse(); - /* Arch-specific enabling code. */ ret = __cpu_up(cpu, idle); if (ret) goto out_unlock; @@ -801,6 +841,7 @@ static int bringup_cpu(unsigned int cpu) irq_unlock_sparse(); return ret; } +#endif static int finish_cpu(unsigned int cpu) { @@ -1940,13 +1981,38 @@ static struct cpuhp_step cpuhp_hp_states .startup.single = timers_prepare_cpu, .teardown.single = timers_dead_cpu, }, - /* Kicks the plugged cpu into life */ + +#ifdef CONFIG_HOTPLUG_SPLIT_STARTUP + /* + * Kicks the AP alive. AP will wait in cpuhp_ap_sync_alive() until + * the next step will release it. + */ + [CPUHP_BP_KICK_AP] = { + .name = "cpu:kick_ap", + .startup.single = cpuhp_kick_ap_alive, + }, + + /* + * Waits for the AP to reach cpuhp_ap_sync_alive() and then + * releases it for the complete bringup. + */ + [CPUHP_BRINGUP_CPU] = { + .name = "cpu:bringup", + .startup.single = cpuhp_bringup_ap, + .teardown.single = finish_cpu, + .cant_stop = true, + }, +#else + /* + * All-in-one CPU bringup state which includes the kick alive. + */ [CPUHP_BRINGUP_CPU] = { .name = "cpu:bringup", .startup.single = bringup_cpu, .teardown.single = finish_cpu, .cant_stop = true, }, +#endif /* Final state before CPU kills itself */ [CPUHP_AP_IDLE_DEAD] = { .name = "idle:dead", From xen-devel-bounces@lists.xenproject.org Mon May 08 19:47:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:47:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531796.827739 (Exim 4.92) (envelope-from ) id 1pw6pi-00077S-48; Mon, 08 May 2023 19:47:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531796.827739; Mon, 08 May 2023 19:47:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6ph-00074D-N0; Mon, 08 May 2023 19:47:41 +0000 Received: by outflank-mailman (input) for mailman id 531796; Mon, 08 May 2023 19:47:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6m5-0004GB-K5 for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:43:57 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ab9a95f9-edd8-11ed-b226-6b7b168915f2; Mon, 08 May 2023 21:43:56 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab9a95f9-edd8-11ed-b226-6b7b168915f2 Message-ID: <20230508185218.240871842@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575036; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=/nqzDu5xfHXjN7n3gGaKe3Qp9xgjuZPS5IpPjnAT+f4=; b=Y9osvnDWdCFR42wS3Sq9455tPTExWH6chOdVK5t+mElOJ7bmi/rBIUzKmrZFhLMAryyWI9 42k5ASwHdZKGQdxaJo7QXjrfzOtyqL45DfKI3fQNAjyGFICTT/FAvhaW+FpMAE/idsBhLd szNwKYPH7EhFVR3AkF2Ir5xe1+1ylMBRrM5mJp72cb88zxQyAVq9cHCCmxD2WbikZ+TEzW o3Vo+irhC2HNz6lB8iyeyWXwtTlgXUlJKwaa+XkY0BRUkQCMhfQNf/vofmV4FtVDwALeB6 HMpdhCe+3uQSS6EgGde3TvQ49KubdZK17ErrXoAMJsr0uMdRNS+eaVdMHMxoew== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575036; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=/nqzDu5xfHXjN7n3gGaKe3Qp9xgjuZPS5IpPjnAT+f4=; b=5t4mMAnQWernMb+O3GXjrwM8U6FkU2jP3+/SU36NRq2BqU7xPkCTiHjSiyuzYfTY/O48DX SQFLh5owzs5njNDw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch v3 18/36] [patch V2 18/38] cpu/hotplug: Add CPU state tracking and synchronization References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:43:55 +0200 (CEST) From: Thomas Gleixner The CPU state tracking and synchronization mechanism in smpboot.c is completely independent of the hotplug code and all logic around it is implemented in architecture specific code. Except for the state reporting of the AP there is absolutely nothing architecture specific and the sychronization and decision functions can be moved into the generic hotplug core code. Provide an integrated variant and add the core synchronization and decision points. This comes in two flavours: 1) DEAD state synchronization Updated by the architecture code once the AP reaches the point where it is ready to be torn down by the control CPU, e.g. by removing power or clocks or tear down via the hypervisor. The control CPU waits for this state to be reached with a timeout. If the state is reached an architecture specific cleanup function is invoked. 2) Full state synchronization This extends #1 with AP alive synchronization. This is new functionality, which allows to replace architecture specific wait mechanims, e.g. cpumasks, completely. It also prevents that an AP which is in a limbo state can be brought up again. This can happen when an AP failed to report dead state during a previous off-line operation. The dead synchronization is what most architectures use. Only x86 makes a bringup decision based on that state at the moment. Signed-off-by: Thomas Gleixner Tested-by: Michael Kelley --- arch/Kconfig | 15 +++ include/linux/cpuhotplug.h | 12 ++ kernel/cpu.c | 193 ++++++++++++++++++++++++++++++++++++++++++++- kernel/smpboot.c | 2 4 files changed, 221 insertions(+), 1 deletion(-) --- --- a/arch/Kconfig +++ b/arch/Kconfig @@ -34,6 +34,21 @@ config ARCH_HAS_SUBPAGE_FAULTS config HOTPLUG_SMT bool +# Selected by HOTPLUG_CORE_SYNC_DEAD or HOTPLUG_CORE_SYNC_FULL +config HOTPLUG_CORE_SYNC + bool + +# Basic CPU dead synchronization selected by architecture +config HOTPLUG_CORE_SYNC_DEAD + bool + select HOTPLUG_CORE_SYNC + +# Full CPU synchronization with alive state selected by architecture +config HOTPLUG_CORE_SYNC_FULL + bool + select HOTPLUG_CORE_SYNC_DEAD if HOTPLUG_CPU + select HOTPLUG_CORE_SYNC + config GENERIC_ENTRY bool --- a/include/linux/cpuhotplug.h +++ b/include/linux/cpuhotplug.h @@ -517,4 +517,16 @@ void cpuhp_online_idle(enum cpuhp_state static inline void cpuhp_online_idle(enum cpuhp_state state) { } #endif +void cpuhp_ap_sync_alive(void); +void arch_cpuhp_sync_state_poll(void); +void arch_cpuhp_cleanup_kick_cpu(unsigned int cpu); + +#ifdef CONFIG_HOTPLUG_CORE_SYNC_DEAD +void cpuhp_ap_report_dead(void); +void arch_cpuhp_cleanup_dead_cpu(unsigned int cpu); +#else +static inline void cpuhp_ap_report_dead(void) { } +static inline void arch_cpuhp_cleanup_dead_cpu(unsigned int cpu) { } +#endif + #endif --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include #include @@ -59,6 +60,7 @@ * @last: For multi-instance rollback, remember how far we got * @cb_state: The state for a single callback (install/uninstall) * @result: Result of the operation + * @ap_sync_state: State for AP synchronization * @done_up: Signal completion to the issuer of the task for cpu-up * @done_down: Signal completion to the issuer of the task for cpu-down */ @@ -76,6 +78,7 @@ struct cpuhp_cpu_state { struct hlist_node *last; enum cpuhp_state cb_state; int result; + atomic_t ap_sync_state; struct completion done_up; struct completion done_down; #endif @@ -276,6 +279,182 @@ static bool cpuhp_is_atomic_state(enum c return CPUHP_AP_IDLE_DEAD <= state && state < CPUHP_AP_ONLINE; } +/* Synchronization state management */ +enum cpuhp_sync_state { + SYNC_STATE_DEAD, + SYNC_STATE_KICKED, + SYNC_STATE_SHOULD_DIE, + SYNC_STATE_ALIVE, + SYNC_STATE_SHOULD_ONLINE, + SYNC_STATE_ONLINE, +}; + +#ifdef CONFIG_HOTPLUG_CORE_SYNC +/** + * cpuhp_ap_update_sync_state - Update synchronization state during bringup/teardown + * @state: The synchronization state to set + * + * No synchronization point. Just update of the synchronization state. + */ +static inline void cpuhp_ap_update_sync_state(enum cpuhp_sync_state state) +{ + atomic_t *st = this_cpu_ptr(&cpuhp_state.ap_sync_state); + int sync = atomic_read(st); + + while (!atomic_try_cmpxchg(st, &sync, state)); +} + +void __weak arch_cpuhp_sync_state_poll(void) { cpu_relax(); } + +static bool cpuhp_wait_for_sync_state(unsigned int cpu, enum cpuhp_sync_state state, + enum cpuhp_sync_state next_state) +{ + atomic_t *st = per_cpu_ptr(&cpuhp_state.ap_sync_state, cpu); + ktime_t now, end, start = ktime_get(); + int sync; + + end = start + 10ULL * NSEC_PER_SEC; + + sync = atomic_read(st); + while (1) { + if (sync == state) { + if (!atomic_try_cmpxchg(st, &sync, next_state)) + continue; + return true; + } + + now = ktime_get(); + if (now > end) { + /* Timeout. Leave the state unchanged */ + return false; + } else if (now - start < NSEC_PER_MSEC) { + /* Poll for one millisecond */ + arch_cpuhp_sync_state_poll(); + } else { + usleep_range_state(USEC_PER_MSEC, 2 * USEC_PER_MSEC, TASK_UNINTERRUPTIBLE); + } + sync = atomic_read(st); + } + return true; +} +#else /* CONFIG_HOTPLUG_CORE_SYNC */ +static inline void cpuhp_ap_update_sync_state(enum cpuhp_sync_state state) { } +#endif /* !CONFIG_HOTPLUG_CORE_SYNC */ + +#ifdef CONFIG_HOTPLUG_CORE_SYNC_DEAD +/** + * cpuhp_ap_report_dead - Update synchronization state to DEAD + * + * No synchronization point. Just update of the synchronization state. + */ +void cpuhp_ap_report_dead(void) +{ + cpuhp_ap_update_sync_state(SYNC_STATE_DEAD); +} + +void __weak arch_cpuhp_cleanup_dead_cpu(unsigned int cpu) { } + +/* + * Late CPU shutdown synchronization point. Cannot use cpuhp_state::done_down + * because the AP cannot issue complete() at this stage. + */ +static void cpuhp_bp_sync_dead(unsigned int cpu) +{ + atomic_t *st = per_cpu_ptr(&cpuhp_state.ap_sync_state, cpu); + int sync = atomic_read(st); + + do { + /* CPU can have reported dead already. Don't overwrite that! */ + if (sync == SYNC_STATE_DEAD) + break; + } while (!atomic_try_cmpxchg(st, &sync, SYNC_STATE_SHOULD_DIE)); + + if (cpuhp_wait_for_sync_state(cpu, SYNC_STATE_DEAD, SYNC_STATE_DEAD)) { + /* CPU reached dead state. Invoke the cleanup function */ + arch_cpuhp_cleanup_dead_cpu(cpu); + return; + } + + /* No further action possible. Emit message and give up. */ + pr_err("CPU%u failed to report dead state\n", cpu); +} +#else /* CONFIG_HOTPLUG_CORE_SYNC_DEAD */ +static inline void cpuhp_bp_sync_dead(unsigned int cpu) { } +#endif /* !CONFIG_HOTPLUG_CORE_SYNC_DEAD */ + +#ifdef CONFIG_HOTPLUG_CORE_SYNC_FULL +/** + * cpuhp_ap_sync_alive - Synchronize AP with the control CPU once it is alive + * + * Updates the AP synchronization state to SYNC_STATE_ALIVE and waits + * for the BP to release it. + */ +void cpuhp_ap_sync_alive(void) +{ + atomic_t *st = this_cpu_ptr(&cpuhp_state.ap_sync_state); + + cpuhp_ap_update_sync_state(SYNC_STATE_ALIVE); + + /* Wait for the control CPU to release it. */ + while (atomic_read(st) != SYNC_STATE_SHOULD_ONLINE) + cpu_relax(); +} + +static bool cpuhp_can_boot_ap(unsigned int cpu) +{ + atomic_t *st = per_cpu_ptr(&cpuhp_state.ap_sync_state, cpu); + int sync = atomic_read(st); + +again: + switch (sync) { + case SYNC_STATE_DEAD: + /* CPU is properly dead */ + break; + case SYNC_STATE_KICKED: + /* CPU did not come up in previous attempt */ + break; + case SYNC_STATE_ALIVE: + /* CPU is stuck cpuhp_ap_sync_alive(). */ + break; + default: + /* CPU failed to report online or dead and is in limbo state. */ + return false; + } + + /* Prepare for booting */ + if (!atomic_try_cmpxchg(st, &sync, SYNC_STATE_KICKED)) + goto again; + + return true; +} + +void __weak arch_cpuhp_cleanup_kick_cpu(unsigned int cpu) { } + +/* + * Early CPU bringup synchronization point. Cannot use cpuhp_state::done_up + * because the AP cannot issue complete() so early in the bringup. + */ +static int cpuhp_bp_sync_alive(unsigned int cpu) +{ + int ret = 0; + + if (!IS_ENABLED(CONFIG_HOTPLUG_CORE_SYNC_FULL)) + return 0; + + if (!cpuhp_wait_for_sync_state(cpu, SYNC_STATE_ALIVE, SYNC_STATE_SHOULD_ONLINE)) { + pr_err("CPU%u failed to report alive state\n", cpu); + ret = -EIO; + } + + /* Let the architecture cleanup the kick alive mechanics. */ + arch_cpuhp_cleanup_kick_cpu(cpu); + return ret; +} +#else /* CONFIG_HOTPLUG_CORE_SYNC_FULL */ +static inline int cpuhp_bp_sync_alive(unsigned int cpu) { return 0; } +static inline bool cpuhp_can_boot_ap(unsigned int cpu) { return true; } +#endif /* !CONFIG_HOTPLUG_CORE_SYNC_FULL */ + /* Serializes the updates to cpu_online_mask, cpu_present_mask */ static DEFINE_MUTEX(cpu_add_remove_lock); bool cpuhp_tasks_frozen; @@ -588,6 +767,9 @@ static int bringup_cpu(unsigned int cpu) struct task_struct *idle = idle_thread_get(cpu); int ret; + if (!cpuhp_can_boot_ap(cpu)) + return -EAGAIN; + /* * Reset stale stack state from the last time this CPU was online. */ @@ -606,6 +788,10 @@ static int bringup_cpu(unsigned int cpu) if (ret) goto out_unlock; + ret = cpuhp_bp_sync_alive(cpu); + if (ret) + goto out_unlock; + ret = bringup_wait_for_ap_online(cpu); if (ret) goto out_unlock; @@ -1109,6 +1295,8 @@ static int takedown_cpu(unsigned int cpu /* This actually kills the CPU. */ __cpu_die(cpu); + cpuhp_bp_sync_dead(cpu); + tick_cleanup_dead_cpu(cpu); rcutree_migrate_callbacks(cpu); return 0; @@ -1355,8 +1543,10 @@ void cpuhp_online_idle(enum cpuhp_state if (state != CPUHP_AP_ONLINE_IDLE) return; + cpuhp_ap_update_sync_state(SYNC_STATE_ONLINE); + /* - * Unpart the stopper thread before we start the idle loop (and start + * Unpark the stopper thread before we start the idle loop (and start * scheduling); this ensures the stopper task is always available. */ stop_machine_unpark(smp_processor_id()); @@ -2733,6 +2923,7 @@ void __init boot_cpu_hotplug_init(void) { #ifdef CONFIG_SMP cpumask_set_cpu(smp_processor_id(), &cpus_booted_once_mask); + atomic_set(this_cpu_ptr(&cpuhp_state.ap_sync_state), SYNC_STATE_ONLINE); #endif this_cpu_write(cpuhp_state.state, CPUHP_ONLINE); this_cpu_write(cpuhp_state.target, CPUHP_ONLINE); --- a/kernel/smpboot.c +++ b/kernel/smpboot.c @@ -326,6 +326,7 @@ void smpboot_unregister_percpu_thread(st } EXPORT_SYMBOL_GPL(smpboot_unregister_percpu_thread); +#ifndef CONFIG_HOTPLUG_CORE_SYNC static DEFINE_PER_CPU(atomic_t, cpu_hotplug_state) = ATOMIC_INIT(CPU_POST_DEAD); /* @@ -488,3 +489,4 @@ bool cpu_report_death(void) } #endif /* #ifdef CONFIG_HOTPLUG_CPU */ +#endif /* !CONFIG_HOTPLUG_CORE_SYNC */ From xen-devel-bounces@lists.xenproject.org Mon May 08 19:47:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:47:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531805.827762 (Exim 4.92) (envelope-from ) id 1pw6pm-0008AX-MX; Mon, 08 May 2023 19:47:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531805.827762; Mon, 08 May 2023 19:47:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6pm-00089t-GO; Mon, 08 May 2023 19:47:46 +0000 Received: by outflank-mailman (input) for mailman id 531805; Mon, 08 May 2023 19:47:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6mP-0004Y5-Rf for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:44:17 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b7436e10-edd8-11ed-8611-37d641c3527e; Mon, 08 May 2023 21:44:16 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b7436e10-edd8-11ed-8611-37d641c3527e Message-ID: <20230508185218.909138139@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=kwmqj85oJPkZidDSe6wGXZxA0ULq99wzodNu0T1h+kk=; b=wg1uBLGtSoxcaJSU0iEE4x0UcfBChTrLt0gyE4M5PDuGfK5fjT22t8ZTBBC2tynpzI6HHh 6Y7wX0lp4t6osRCyrG3TT1YgnOHCxIFJnJkEGdJWSzb30rEUBKI5nxlG8O7tNjZVGxOjHb SANeefFOJGw6DUXAVXM56kO2xHkef7AW/0tPOsy0YwgLmgzJMjuxG1N7Phieoka0kZqbc+ SwamRLfl76kZk/gDSsJbzFLV/CAY9FezjErFfEBAxnMp56mRQxgPmpsjeFT7Dxl3HIxRAN Y1+kfoeoNJM9pmRMjeHWlK/tpJMX+RNO6kr+gmNFYozmaU/eCEE9q4itJyCt1A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=kwmqj85oJPkZidDSe6wGXZxA0ULq99wzodNu0T1h+kk=; b=hBj0Uqf6QiSA9MqtLkZVoZtNNYgv3nBK9gQda39ezyZ0ekHS2uiMmy5gmQpbYtX4lR0BfY +Xmymckx4LlMyoDw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch v3 30/36] x86/smpboot: Enable split CPU startup References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:44:15 +0200 (CEST) From: Thomas Gleixner The x86 CPU bringup state currently does AP wake-up, wait for AP to respond and then release it for full bringup. It is safe to be split into a wake-up and and a separate wait+release state. Provide the required functions and enable the split CPU bringup, which prepares for parallel bringup, where the bringup of the non-boot CPUs takes two iterations: One to prepare and wake all APs and the second to wait and release them. Depending on timing this can eliminate the wait time completely. Signed-off-by: Thomas Gleixner Tested-by: Michael Kelley --- arch/x86/Kconfig | 2 +- arch/x86/include/asm/smp.h | 9 ++------- arch/x86/kernel/smp.c | 2 +- arch/x86/kernel/smpboot.c | 8 ++++---- arch/x86/xen/smp_pv.c | 4 ++-- 5 files changed, 10 insertions(+), 15 deletions(-) --- --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -274,8 +274,8 @@ config X86 select HAVE_UNSTABLE_SCHED_CLOCK select HAVE_USER_RETURN_NOTIFIER select HAVE_GENERIC_VDSO - select HOTPLUG_CORE_SYNC_FULL if SMP select HOTPLUG_SMT if SMP + select HOTPLUG_SPLIT_STARTUP if SMP select IRQ_FORCED_THREADING select NEED_PER_CPU_EMBED_FIRST_CHUNK select NEED_PER_CPU_PAGE_FIRST_CHUNK --- a/arch/x86/include/asm/smp.h +++ b/arch/x86/include/asm/smp.h @@ -40,7 +40,7 @@ struct smp_ops { void (*cleanup_dead_cpu)(unsigned cpu); void (*poll_sync_state)(void); - int (*cpu_up)(unsigned cpu, struct task_struct *tidle); + int (*kick_ap_alive)(unsigned cpu, struct task_struct *tidle); int (*cpu_disable)(void); void (*cpu_die)(unsigned int cpu); void (*play_dead)(void); @@ -80,11 +80,6 @@ static inline void smp_cpus_done(unsigne smp_ops.smp_cpus_done(max_cpus); } -static inline int __cpu_up(unsigned int cpu, struct task_struct *tidle) -{ - return smp_ops.cpu_up(cpu, tidle); -} - static inline int __cpu_disable(void) { return smp_ops.cpu_disable(); @@ -124,7 +119,7 @@ void native_smp_prepare_cpus(unsigned in void calculate_max_logical_packages(void); void native_smp_cpus_done(unsigned int max_cpus); int common_cpu_up(unsigned int cpunum, struct task_struct *tidle); -int native_cpu_up(unsigned int cpunum, struct task_struct *tidle); +int native_kick_ap(unsigned int cpu, struct task_struct *tidle); int native_cpu_disable(void); void __noreturn hlt_play_dead(void); void native_play_dead(void); --- a/arch/x86/kernel/smp.c +++ b/arch/x86/kernel/smp.c @@ -268,7 +268,7 @@ struct smp_ops smp_ops = { #endif .smp_send_reschedule = native_smp_send_reschedule, - .cpu_up = native_cpu_up, + .kick_ap_alive = native_kick_ap, .cpu_disable = native_cpu_disable, .play_dead = native_play_dead, --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -1058,7 +1058,7 @@ static int do_boot_cpu(int apicid, int c return ret; } -static int native_kick_ap(unsigned int cpu, struct task_struct *tidle) +int native_kick_ap(unsigned int cpu, struct task_struct *tidle) { int apicid = apic->cpu_present_to_apicid(cpu); int err; @@ -1094,15 +1094,15 @@ static int native_kick_ap(unsigned int c return err; } -int native_cpu_up(unsigned int cpu, struct task_struct *tidle) +int arch_cpuhp_kick_ap_alive(unsigned int cpu, struct task_struct *tidle) { - return native_kick_ap(cpu, tidle); + return smp_ops.kick_ap_alive(cpu, tidle); } void arch_cpuhp_cleanup_kick_cpu(unsigned int cpu) { /* Cleanup possible dangling ends... */ - if (smp_ops.cpu_up == native_cpu_up && x86_platform.legacy.warm_reset) + if (smp_ops.kick_ap_alive == native_kick_ap && x86_platform.legacy.warm_reset) smpboot_restore_warm_reset_vector(); } --- a/arch/x86/xen/smp_pv.c +++ b/arch/x86/xen/smp_pv.c @@ -314,7 +314,7 @@ cpu_initialize_context(unsigned int cpu, return 0; } -static int xen_pv_cpu_up(unsigned int cpu, struct task_struct *idle) +static int xen_pv_kick_ap(unsigned int cpu, struct task_struct *idle) { int rc; @@ -438,7 +438,7 @@ static const struct smp_ops xen_smp_ops .smp_prepare_cpus = xen_pv_smp_prepare_cpus, .smp_cpus_done = xen_smp_cpus_done, - .cpu_up = xen_pv_cpu_up, + .kick_ap_alive = xen_pv_kick_ap, .cpu_die = xen_pv_cpu_die, .cleanup_dead_cpu = xen_pv_cleanup_dead_cpu, .poll_sync_state = xen_pv_poll_sync_state, From xen-devel-bounces@lists.xenproject.org Mon May 08 19:47:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:47:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531809.827769 (Exim 4.92) (envelope-from ) id 1pw6pn-0008Md-RS; Mon, 08 May 2023 19:47:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531809.827769; Mon, 08 May 2023 19:47:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6pn-0008Kx-I3; Mon, 08 May 2023 19:47:47 +0000 Received: by outflank-mailman (input) for mailman id 531809; Mon, 08 May 2023 19:47:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6mQ-0004GB-Gu for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:44:18 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b83f9151-edd8-11ed-b226-6b7b168915f2; Mon, 08 May 2023 21:44:17 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b83f9151-edd8-11ed-b226-6b7b168915f2 Message-ID: <20230508185218.962208640@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575057; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=7J6qDuLCrgdvR1kG/InEcQTSLCUqJ2Io10qHE6FCHaM=; b=0Hv0AspymKyYz8qW0hj6Fb0vUtVHsdGmkvWcUakIBtshYh+zVy/vlvZHR1/vJJLPlas4D8 PRzzSySwBkg1+JPbOBNLLdT/hp7seWkZBvoftuEF+vw8QuQjWUJ4K4oLdS5xDTwEjJHE7A gNOv1k4J4BrzZeGVnOAKkMmcblUqN/FYihcmxHZv2nEClm+/K+rhv+En8fpkOo6ZMhekbP fp0J8Mycqhuh4vaLIP3ZaeDDy7dR7H2M1G6jiZF8zqKNY6sfFE8cTQVtJvDtVzZmYHGBDI A83cW4yHAFFLmlY1u2nMBkF0J3x6Dy2QTQscDGxCprr2i8ihRMilmaPq8wHcbw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575057; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=7J6qDuLCrgdvR1kG/InEcQTSLCUqJ2Io10qHE6FCHaM=; b=3bCOAPoiV1ViDB0Ns+pjgu6fuq8OhbzSh5tZOLe9PQ/YwBWzawJVTSPOhF+994y0l1r8Gv bZKIMX08LnDG7gCA== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch v3 31/36] x86/apic: Provide cpu_primary_thread mask References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:44:17 +0200 (CEST) From: Thomas Gleixner Make the primary thread tracking CPU mask based in preparation for simpler handling of parallel bootup. Signed-off-by: Thomas Gleixner Tested-by: Michael Kelley --- arch/x86/include/asm/apic.h | 2 -- arch/x86/include/asm/topology.h | 19 +++++++++++++++---- arch/x86/kernel/apic/apic.c | 20 +++++++++----------- arch/x86/kernel/smpboot.c | 12 +++--------- 4 files changed, 27 insertions(+), 26 deletions(-) --- --- a/arch/x86/include/asm/apic.h +++ b/arch/x86/include/asm/apic.h @@ -506,10 +506,8 @@ extern int default_check_phys_apicid_pre #endif /* CONFIG_X86_LOCAL_APIC */ #ifdef CONFIG_SMP -bool apic_id_is_primary_thread(unsigned int id); void apic_smt_update(void); #else -static inline bool apic_id_is_primary_thread(unsigned int id) { return false; } static inline void apic_smt_update(void) { } #endif --- a/arch/x86/include/asm/topology.h +++ b/arch/x86/include/asm/topology.h @@ -31,9 +31,9 @@ * CONFIG_NUMA. */ #include +#include #ifdef CONFIG_NUMA -#include #include #include @@ -139,9 +139,20 @@ static inline int topology_max_smt_threa int topology_update_package_map(unsigned int apicid, unsigned int cpu); int topology_update_die_map(unsigned int dieid, unsigned int cpu); int topology_phys_to_logical_pkg(unsigned int pkg); -bool topology_is_primary_thread(unsigned int cpu); bool topology_smt_supported(void); -#else + +extern struct cpumask __cpu_primary_thread_mask; +#define cpu_primary_thread_mask ((const struct cpumask *)&__cpu_primary_thread_mask) + +/** + * topology_is_primary_thread - Check whether CPU is the primary SMT thread + * @cpu: CPU to check + */ +static inline bool topology_is_primary_thread(unsigned int cpu) +{ + return cpumask_test_cpu(cpu, cpu_primary_thread_mask); +} +#else /* CONFIG_SMP */ #define topology_max_packages() (1) static inline int topology_update_package_map(unsigned int apicid, unsigned int cpu) { return 0; } @@ -152,7 +163,7 @@ static inline int topology_max_die_per_p static inline int topology_max_smt_threads(void) { return 1; } static inline bool topology_is_primary_thread(unsigned int cpu) { return true; } static inline bool topology_smt_supported(void) { return false; } -#endif +#endif /* !CONFIG_SMP */ static inline void arch_fix_phys_package_id(int num, u32 slot) { --- a/arch/x86/kernel/apic/apic.c +++ b/arch/x86/kernel/apic/apic.c @@ -2386,20 +2386,16 @@ bool arch_match_cpu_phys_id(int cpu, u64 } #ifdef CONFIG_SMP -/** - * apic_id_is_primary_thread - Check whether APIC ID belongs to a primary thread - * @apicid: APIC ID to check - */ -bool apic_id_is_primary_thread(unsigned int apicid) +static void cpu_mark_primary_thread(unsigned int cpu, unsigned int apicid) { - u32 mask; - - if (smp_num_siblings == 1) - return true; /* Isolate the SMT bit(s) in the APICID and check for 0 */ - mask = (1U << (fls(smp_num_siblings) - 1)) - 1; - return !(apicid & mask); + u32 mask = (1U << (fls(smp_num_siblings) - 1)) - 1; + + if (smp_num_siblings == 1 || !(apicid & mask)) + cpumask_set_cpu(cpu, &__cpu_primary_thread_mask); } +#else +static inline void cpu_mark_primary_thread(unsigned int cpu, unsigned int apicid) { } #endif /* @@ -2544,6 +2540,8 @@ int generic_processor_info(int apicid, i set_cpu_present(cpu, true); num_processors++; + cpu_mark_primary_thread(cpu, apicid); + return cpu; } --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -102,6 +102,9 @@ EXPORT_PER_CPU_SYMBOL(cpu_die_map); DEFINE_PER_CPU_READ_MOSTLY(struct cpuinfo_x86, cpu_info); EXPORT_PER_CPU_SYMBOL(cpu_info); +/* CPUs which are the primary SMT threads */ +struct cpumask __cpu_primary_thread_mask __read_mostly; + /* Representing CPUs for which sibling maps can be computed */ static cpumask_var_t cpu_sibling_setup_mask; @@ -283,15 +286,6 @@ static void notrace start_secondary(void } /** - * topology_is_primary_thread - Check whether CPU is the primary SMT thread - * @cpu: CPU to check - */ -bool topology_is_primary_thread(unsigned int cpu) -{ - return apic_id_is_primary_thread(per_cpu(x86_cpu_to_apicid, cpu)); -} - -/** * topology_smt_supported - Check whether SMT is supported by the CPUs */ bool topology_smt_supported(void) From xen-devel-bounces@lists.xenproject.org Mon May 08 19:47:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:47:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531806.827768 (Exim 4.92) (envelope-from ) id 1pw6pn-0008F8-L0; Mon, 08 May 2023 19:47:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531806.827768; Mon, 08 May 2023 19:47:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6pm-0008CV-VJ; Mon, 08 May 2023 19:47:46 +0000 Received: by outflank-mailman (input) for mailman id 531806; Mon, 08 May 2023 19:47:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6mL-0004GB-TI for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:44:13 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b55ad22d-edd8-11ed-b226-6b7b168915f2; Mon, 08 May 2023 21:44:13 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b55ad22d-edd8-11ed-b226-6b7b168915f2 Message-ID: <20230508185218.802324532@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575052; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=HVjUF1EbgoHvP2JET34IHqSOI4Hcbuoi5HyMhczyA/0=; b=f87S8Ive1ie4K+DuiLg7usxJY5CRCksJCqSgCkxD5uZH7y4x+OJFuZWNm0Taip1XPPiDD6 MNH0b+hp2o5RbiOVox1gno/kYayr67OXDsY3LQy/XL1EajtZ65KomNmMKrjSPGzPHIQ6mt Bc0Q0qOP9/5ItgD7CpD7wNvTDGfz7YuG1nQmd5y2Lv904N1i53sg9+MQ+HioP83fuoz27l K0h3votn/bkWzE6uLiONR6KdsjL/p4GqVASZ+gwe2bmO48I4HcfU9n8eyvXRqDwkYb7s44 Njvuj3M2dK+aBiLKQsshzndlNWX014TMRWinVJi/9FwvNn2qCERvNBTYOkZNDg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575052; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=HVjUF1EbgoHvP2JET34IHqSOI4Hcbuoi5HyMhczyA/0=; b=0jP1z8zyc9UIx2xHWlL0pghnJTSR5ytXBwb/OqMmY//ybrAvid6zf5b8IChN8VPr3CVlpG 1ard2l2bnsfXlBBQ== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" , David Woodhouse Subject: [patch v3 28/36] cpu/hotplug: Reset task stack state in _cpu_up() References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:44:12 +0200 (CEST) From: David Woodhouse Commit dce1ca0525bf ("sched/scs: Reset task stack state in bringup_cpu()") ensured that the shadow call stack and KASAN poisoning were removed from a CPU's stack each time that CPU is brought up, not just once. This is not incorrect. However, with parallel bringup the idle thread setup will happen at a different step. As a consequence the cleanup in bringup_cpu() would be too late. Move the SCS/KASAN cleanup to the generic _cpu_up() function instead, which already ensures that the new CPU's stack is available, purely to allow for early failure. This occurs when the CPU to be brought up is in the CPUHP_OFFLINE state, which should correctly do the cleanup any time the CPU has been taken down to the point where such is needed. Signed-off-by: David Woodhouse Signed-off-by: Thomas Gleixner Tested-by: Mark Rutland Reviewed-by: Mark Rutland Tested-by: Michael Kelley --- kernel/cpu.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) --- --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -771,12 +771,6 @@ static int bringup_cpu(unsigned int cpu) return -EAGAIN; /* - * Reset stale stack state from the last time this CPU was online. - */ - scs_task_reset(idle); - kasan_unpoison_task_stack(idle); - - /* * Some architectures have to walk the irq descriptors to * setup the vector space for the cpu which comes online. * Prevent irq alloc/free across the bringup. @@ -1583,6 +1577,12 @@ static int _cpu_up(unsigned int cpu, int ret = PTR_ERR(idle); goto out; } + + /* + * Reset stale stack state from the last time this CPU was online. + */ + scs_task_reset(idle); + kasan_unpoison_task_stack(idle); } cpuhp_tasks_frozen = tasks_frozen; From xen-devel-bounces@lists.xenproject.org Mon May 08 19:47:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:47:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531814.827777 (Exim 4.92) (envelope-from ) id 1pw6pp-0000AC-3b; Mon, 08 May 2023 19:47:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531814.827777; Mon, 08 May 2023 19:47:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6po-0008WT-MG; Mon, 08 May 2023 19:47:48 +0000 Received: by outflank-mailman (input) for mailman id 531814; Mon, 08 May 2023 19:47:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6mD-0004Y5-Hj for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:44:05 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id af9025bb-edd8-11ed-8611-37d641c3527e; Mon, 08 May 2023 21:44:03 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: af9025bb-edd8-11ed-8611-37d641c3527e Message-ID: <20230508185218.472786557@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=/iWTZekX5kQrNbDZ4qzevgkextn6cmGYi8Qwr8K2wd0=; b=lOv5CV/JU1toOLovRLqZlTvcRCZ8ltOCGkp6Tu2FEmBz8l2BhYz8Z5gaEUl2tvbeMaUktu naeM1OYPPOb/TMivhvW1pX2QwmNH1QEr1EYdTMeEJicu1SC1DRtYs7/3EGdirqV+PjAVb4 fEhKbiUZ+Ma4Qf+7o2PWQhcdfityfGcgCU0bnUUvTHKObm1jWKBFtPw2zMaDQdulrkbawI +xLgFfoRyCWbU/EZ1Kt9ViC/DeiNSYKzoja1i6f6FtvQCBkZdP+kJFuq9OJu18AL6ddLsp pM+tuBp7BqzPFWb2FuWk5s0zh/tMRx3ZrKdi4WuN3YRev8DqBKVO4GAYXrxTKQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=/iWTZekX5kQrNbDZ4qzevgkextn6cmGYi8Qwr8K2wd0=; b=KbtCrmqgK+WkhRxMq4lpiF9CN1ShevgS463Q/CW1CH+7hVRAoy+HCJrLtfTvSHjNpPNlk0 gXiYZp/kgdvkEdAQ== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch v3 22/36] arm64: smp: Switch to hotplug core state synchronization References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:44:02 +0200 (CEST) From: Thomas Gleixner Switch to the CPU hotplug core state tracking and synchronization mechanim. No functional change intended. Signed-off-by: Thomas Gleixner Tested-by: Mark Rutland Tested-by: Michael Kelley --- arch/arm64/Kconfig | 1 + arch/arm64/include/asm/smp.h | 2 +- arch/arm64/kernel/smp.c | 14 +++++--------- 3 files changed, 7 insertions(+), 10 deletions(-) --- --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -222,6 +222,7 @@ config ARM64 select HAVE_KPROBES select HAVE_KRETPROBES select HAVE_GENERIC_VDSO + select HOTPLUG_CORE_SYNC_DEAD if HOTPLUG_CPU select IRQ_DOMAIN select IRQ_FORCED_THREADING select KASAN_VMALLOC if KASAN --- a/arch/arm64/include/asm/smp.h +++ b/arch/arm64/include/asm/smp.h @@ -99,7 +99,7 @@ static inline void arch_send_wakeup_ipi_ extern int __cpu_disable(void); -extern void __cpu_die(unsigned int cpu); +static inline void __cpu_die(unsigned int cpu) { } extern void __noreturn cpu_die(void); extern void __noreturn cpu_die_early(void); --- a/arch/arm64/kernel/smp.c +++ b/arch/arm64/kernel/smp.c @@ -332,17 +332,13 @@ static int op_cpu_kill(unsigned int cpu) } /* - * called on the thread which is asking for a CPU to be shutdown - - * waits until shutdown has completed, or it is timed out. + * Called on the thread which is asking for a CPU to be shutdown after the + * shutdown completed. */ -void __cpu_die(unsigned int cpu) +void arch_cpuhp_cleanup_dead_cpu(unsigned int cpu) { int err; - if (!cpu_wait_death(cpu, 5)) { - pr_crit("CPU%u: cpu didn't die\n", cpu); - return; - } pr_debug("CPU%u: shutdown\n", cpu); /* @@ -369,8 +365,8 @@ void __noreturn cpu_die(void) local_daif_mask(); - /* Tell __cpu_die() that this CPU is now safe to dispose of */ - (void)cpu_report_death(); + /* Tell cpuhp_bp_sync_dead() that this CPU is now safe to dispose of */ + cpuhp_ap_report_dead(); /* * Actually shutdown the CPU. This must never fail. The specific hotplug From xen-devel-bounces@lists.xenproject.org Mon May 08 19:47:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:47:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531815.827788 (Exim 4.92) (envelope-from ) id 1pw6pr-0000nG-4x; Mon, 08 May 2023 19:47:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531815.827788; Mon, 08 May 2023 19:47:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6pq-0000jr-OU; Mon, 08 May 2023 19:47:50 +0000 Received: by outflank-mailman (input) for mailman id 531815; Mon, 08 May 2023 19:47:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6mG-0004Y5-4M for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:44:08 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b1711425-edd8-11ed-8611-37d641c3527e; Mon, 08 May 2023 21:44:06 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b1711425-edd8-11ed-8611-37d641c3527e Message-ID: <20230508185218.578643863@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=i+dpCSWhwU+6bxlys4Er8+x/ffOHETyJWzg+gvnggWo=; b=3YwCUqtcytN4aZ861iesyIkZVFpl/8iL7JOPtbTJ0r8YY9O0hA7PFKQWP/VhOladl6YVHd oXNqHi6CaE4fWqff5AfQx90V5PHNtVWab0q5q+CzuVLQ5ClyvMceIGCQoA0U4NdI74Hytu Y3+HQXGflBDUkC3QrjVDyzDuu8vc8DF+sOcub1w+SQcfQYuMDSr3sl8AKEXss71YCzdSNs K7FTL0G2EvbmjosCTFqcQQ7qoBmKw+7tjhjizRZuxtJ5Q9gW/83BR4ZSbhIvjd7P97RrbH UnZ5DsNlB/OjkMSIOge9mTydw1E/0zyqU08V3gaeRZYJK9GS0p6p4RbTCnf4YQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=i+dpCSWhwU+6bxlys4Er8+x/ffOHETyJWzg+gvnggWo=; b=0A6YOWIgV3ASET2u6qXUkyJUtq2zMc+7jX705tummCTsCytwDoD9pqfjOP2BrOuDpfQPwG r85LDKJye1tnlVAA== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch v3 24/36] [patch V2 24/38] MIPS: SMP_CPS: Switch to hotplug core state synchronization References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:44:05 +0200 (CEST) From: Thomas Gleixner Switch to the CPU hotplug core state tracking and synchronization mechanim. This unfortunately requires to add dead reporting to the non CPS platforms as CPS is the only user, but it allows an overall consolidation of this functionality. No functional change intended. Signed-off-by: Thomas Gleixner Tested-by: Michael Kelley --- arch/mips/Kconfig | 1 + arch/mips/cavium-octeon/smp.c | 1 + arch/mips/include/asm/smp-ops.h | 1 + arch/mips/kernel/smp-bmips.c | 1 + arch/mips/kernel/smp-cps.c | 14 +++++--------- arch/mips/kernel/smp.c | 8 ++++++++ arch/mips/loongson64/smp.c | 1 + 7 files changed, 18 insertions(+), 9 deletions(-) --- --- a/arch/mips/Kconfig +++ b/arch/mips/Kconfig @@ -2285,6 +2285,7 @@ config MIPS_CPS select MIPS_CM select MIPS_CPS_PM if HOTPLUG_CPU select SMP + select HOTPLUG_CORE_SYNC_DEAD if HOTPLUG_CPU select SYNC_R4K if (CEVT_R4K || CSRC_R4K) select SYS_SUPPORTS_HOTPLUG_CPU select SYS_SUPPORTS_SCHED_SMT if CPU_MIPSR6 --- a/arch/mips/cavium-octeon/smp.c +++ b/arch/mips/cavium-octeon/smp.c @@ -345,6 +345,7 @@ void play_dead(void) int cpu = cpu_number_map(cvmx_get_core_num()); idle_task_exit(); + cpuhp_ap_report_dead(); octeon_processor_boot = 0xff; per_cpu(cpu_state, cpu) = CPU_DEAD; --- a/arch/mips/include/asm/smp-ops.h +++ b/arch/mips/include/asm/smp-ops.h @@ -33,6 +33,7 @@ struct plat_smp_ops { #ifdef CONFIG_HOTPLUG_CPU int (*cpu_disable)(void); void (*cpu_die)(unsigned int cpu); + void (*cleanup_dead_cpu)(unsigned cpu); #endif #ifdef CONFIG_KEXEC void (*kexec_nonboot_cpu)(void); --- a/arch/mips/kernel/smp-bmips.c +++ b/arch/mips/kernel/smp-bmips.c @@ -392,6 +392,7 @@ static void bmips_cpu_die(unsigned int c void __ref play_dead(void) { idle_task_exit(); + cpuhp_ap_report_dead(); /* flush data cache */ _dma_cache_wback_inv(0, ~0); --- a/arch/mips/kernel/smp-cps.c +++ b/arch/mips/kernel/smp-cps.c @@ -503,8 +503,7 @@ void play_dead(void) } } - /* This CPU has chosen its way out */ - (void)cpu_report_death(); + cpuhp_ap_report_dead(); cps_shutdown_this_cpu(cpu_death); @@ -527,7 +526,9 @@ static void wait_for_sibling_halt(void * } while (!(halted & TCHALT_H)); } -static void cps_cpu_die(unsigned int cpu) +static void cps_cpu_die(unsigned int cpu) { } + +static void cps_cleanup_dead_cpu(unsigned cpu) { unsigned core = cpu_core(&cpu_data[cpu]); unsigned int vpe_id = cpu_vpe_id(&cpu_data[cpu]); @@ -535,12 +536,6 @@ static void cps_cpu_die(unsigned int cpu unsigned stat; int err; - /* Wait for the cpu to choose its way out */ - if (!cpu_wait_death(cpu, 5)) { - pr_err("CPU%u: didn't offline\n", cpu); - return; - } - /* * Now wait for the CPU to actually offline. Without doing this that * offlining may race with one or more of: @@ -624,6 +619,7 @@ static const struct plat_smp_ops cps_smp #ifdef CONFIG_HOTPLUG_CPU .cpu_disable = cps_cpu_disable, .cpu_die = cps_cpu_die, + .cleanup_dead_cpu = cps_cleanup_dead_cpu, #endif #ifdef CONFIG_KEXEC .kexec_nonboot_cpu = cps_kexec_nonboot_cpu, --- a/arch/mips/kernel/smp.c +++ b/arch/mips/kernel/smp.c @@ -690,6 +690,14 @@ void flush_tlb_one(unsigned long vaddr) EXPORT_SYMBOL(flush_tlb_page); EXPORT_SYMBOL(flush_tlb_one); +#ifdef CONFIG_HOTPLUG_CPU +void arch_cpuhp_cleanup_dead_cpu(unsigned int cpu) +{ + if (mp_ops->cleanup_dead_cpu) + mp_ops->cleanup_dead_cpu(cpu); +} +#endif + #ifdef CONFIG_GENERIC_CLOCKEVENTS_BROADCAST static void tick_broadcast_callee(void *info) --- a/arch/mips/loongson64/smp.c +++ b/arch/mips/loongson64/smp.c @@ -775,6 +775,7 @@ void play_dead(void) void (*play_dead_at_ckseg1)(int *); idle_task_exit(); + cpuhp_ap_report_dead(); prid_imp = read_c0_prid() & PRID_IMP_MASK; prid_rev = read_c0_prid() & PRID_REV_MASK; From xen-devel-bounces@lists.xenproject.org Mon May 08 19:47:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:47:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531816.827793 (Exim 4.92) (envelope-from ) id 1pw6ps-00011T-4V; Mon, 08 May 2023 19:47:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531816.827793; Mon, 08 May 2023 19:47:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6pr-0000zA-K3; Mon, 08 May 2023 19:47:51 +0000 Received: by outflank-mailman (input) for mailman id 531816; Mon, 08 May 2023 19:47:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6m4-0004GB-CO for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:43:56 +0000 Received: from galois.linutronix.de (galois.linutronix.de [2a0a:51c0:0:12e:550::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id aaa15205-edd8-11ed-b226-6b7b168915f2; Mon, 08 May 2023 21:43:55 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aaa15205-edd8-11ed-b226-6b7b168915f2 Message-ID: <20230508185218.183895955@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=JFZgPCXfk4YqrkWgB2iOW/w2n4X/0HLpXczGoD+v1Vc=; b=dUhrJJpkQ4m0PAJlXgFQayguIDRYj4DbGKW+17HOquchCD5OkCNG5p+ivglj6Zp0QU+I0O sjDl2ZSA2qdGYXZhUvFPnbPFXnAtHugvx2GI+wQbJ19qs9tz5O+rWnDYC86GVW88KAAeKE Y1tCVHUnxg/G/GD2y2S3k8oy8xdR5u5wsZrKD02jMrshweqjIs0USPtzbNHtBjzyPjuZYP bnHk9lUQIZYMlOyOmAOBq9jij07nAxoPfgUgAqbfHUg2W+wm48VsfVgoz2u1VnDCsiAyNh 0QgIUd501thJfEkajmTlocFpAZEG7qATCMndUXAIFuG7nTRHlZ0qw32Bk/xexg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=JFZgPCXfk4YqrkWgB2iOW/w2n4X/0HLpXczGoD+v1Vc=; b=w6a2Le7411PlZc47ukf/lNrWYBsIfR8a67l/rnpzfLfXCU2HTbN7zdy8QxM7z6Q1BG3dst HEreuKgJSAkc7vCQ== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch v3 17/36] x86/xen/hvm: Get rid of DEAD_FROZEN handling References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:43:54 +0200 (CEST) From: Thomas Gleixner No point in this conditional voodoo. Un-initializing the lock mechanism is safe to be called unconditionally even if it was already invoked when the CPU died. Remove the invocation of xen_smp_intr_free() as that has been already cleaned up in xen_cpu_dead_hvm(). Signed-off-by: Thomas Gleixner Tested-by: Michael Kelley --- arch/x86/xen/enlighten_hvm.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) --- --- a/arch/x86/xen/enlighten_hvm.c +++ b/arch/x86/xen/enlighten_hvm.c @@ -161,13 +161,12 @@ static int xen_cpu_up_prepare_hvm(unsign int rc = 0; /* - * This can happen if CPU was offlined earlier and - * offlining timed out in common_cpu_die(). + * If a CPU was offlined earlier and offlining timed out then the + * lock mechanism is still initialized. Uninit it unconditionally + * as it's safe to call even if already uninited. Interrupts and + * timer have already been handled in xen_cpu_dead_hvm(). */ - if (cpu_report_state(cpu) == CPU_DEAD_FROZEN) { - xen_smp_intr_free(cpu); - xen_uninit_lock_cpu(cpu); - } + xen_uninit_lock_cpu(cpu); if (cpu_acpi_id(cpu) != U32_MAX) per_cpu(xen_vcpu_id, cpu) = cpu_acpi_id(cpu); From xen-devel-bounces@lists.xenproject.org Mon May 08 19:47:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:47:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531819.827804 (Exim 4.92) (envelope-from ) id 1pw6pu-0001V6-3W; Mon, 08 May 2023 19:47:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531819.827804; Mon, 08 May 2023 19:47:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6pt-0001Ox-Az; Mon, 08 May 2023 19:47:53 +0000 Received: by outflank-mailman (input) for mailman id 531819; Mon, 08 May 2023 19:47:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6m8-0004Y5-5l for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:44:00 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ac877e76-edd8-11ed-8611-37d641c3527e; Mon, 08 May 2023 21:43:58 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ac877e76-edd8-11ed-8611-37d641c3527e Message-ID: <20230508185218.297596481@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575038; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=XQhJ+YJbo0fWro2ruFVKTtipcCHrQUMCrvr4JNW/4mg=; b=4HZ0gY7/qD3Jz2ZNiBgE//AXQYDH/HeFjZDh4WjRi76jcqRWL6r1IWSArSsgLl2nlNQFR6 g3oTCdwyHjjeeSH6oYG4P6dDHDqPyrm4XsYm9t4qbqxeqX6w9TMM6v51TRol9UuzaVyIPk O8sLnZGl0vrJEr5urbSAYXzeA0ustuVEtlwl/eDhsKlBBr4ajx+3nr3yXmbpdfkWsah1Lk odDCU1HmUFyvF+/Y8OceVNiymvFXX2ukC/Gxal6fq+3UJSIiNFsGWISmsq8MY4xbzh0Twx 2YA2DgvNmC6y7rxMRpj43UMudtuAPgUtDjD8EJmrsJnCusfYrI4PMDU4n2KO7A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575038; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=XQhJ+YJbo0fWro2ruFVKTtipcCHrQUMCrvr4JNW/4mg=; b=K1/k56pLiZSNgtdyMkDW8r9Mred4paXTZmDhXCdZZLJnLWAWM+LVFaD5vra+tfT4KvzwFJ SeTJHuTiUJpAhFAw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch v3 19/36] x86/smpboot: Switch to hotplug core state synchronization References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:43:57 +0200 (CEST) From: Thomas Gleixner The new AP state tracking and synchronization mechanism in the CPU hotplug core code allows to remove quite some x86 specific code: 1) The AP alive synchronization based on cpumasks 2) The decision whether an AP can be brought up again Signed-off-by: Thomas Gleixner Tested-by: Michael Kelley --- V2: Use for_each_online_cpu() - Brian --- arch/x86/Kconfig | 1 arch/x86/include/asm/smp.h | 7 + arch/x86/kernel/smp.c | 1 arch/x86/kernel/smpboot.c | 161 ++++++++++----------------------------------- arch/x86/xen/smp_hvm.c | 16 +--- arch/x86/xen/smp_pv.c | 39 ++++++---- 6 files changed, 73 insertions(+), 152 deletions(-) --- --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -274,6 +274,7 @@ config X86 select HAVE_UNSTABLE_SCHED_CLOCK select HAVE_USER_RETURN_NOTIFIER select HAVE_GENERIC_VDSO + select HOTPLUG_CORE_SYNC_FULL if SMP select HOTPLUG_SMT if SMP select IRQ_FORCED_THREADING select NEED_PER_CPU_EMBED_FIRST_CHUNK --- a/arch/x86/include/asm/smp.h +++ b/arch/x86/include/asm/smp.h @@ -38,6 +38,8 @@ struct smp_ops { void (*crash_stop_other_cpus)(void); void (*smp_send_reschedule)(int cpu); + void (*cleanup_dead_cpu)(unsigned cpu); + void (*poll_sync_state)(void); int (*cpu_up)(unsigned cpu, struct task_struct *tidle); int (*cpu_disable)(void); void (*cpu_die)(unsigned int cpu); @@ -90,7 +92,8 @@ static inline int __cpu_disable(void) static inline void __cpu_die(unsigned int cpu) { - smp_ops.cpu_die(cpu); + if (smp_ops.cpu_die) + smp_ops.cpu_die(cpu); } static inline void __noreturn play_dead(void) @@ -123,8 +126,6 @@ void native_smp_cpus_done(unsigned int m int common_cpu_up(unsigned int cpunum, struct task_struct *tidle); int native_cpu_up(unsigned int cpunum, struct task_struct *tidle); int native_cpu_disable(void); -int common_cpu_die(unsigned int cpu); -void native_cpu_die(unsigned int cpu); void __noreturn hlt_play_dead(void); void native_play_dead(void); void play_dead_common(void); --- a/arch/x86/kernel/smp.c +++ b/arch/x86/kernel/smp.c @@ -269,7 +269,6 @@ struct smp_ops smp_ops = { .smp_send_reschedule = native_smp_send_reschedule, .cpu_up = native_cpu_up, - .cpu_die = native_cpu_die, .cpu_disable = native_cpu_disable, .play_dead = native_play_dead, --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -57,6 +57,7 @@ #include #include #include +#include #include #include @@ -101,9 +102,6 @@ EXPORT_PER_CPU_SYMBOL(cpu_die_map); DEFINE_PER_CPU_READ_MOSTLY(struct cpuinfo_x86, cpu_info); EXPORT_PER_CPU_SYMBOL(cpu_info); -/* All of these masks are initialized in setup_cpu_local_masks() */ -static cpumask_var_t cpu_initialized_mask; -static cpumask_var_t cpu_callout_mask; /* Representing CPUs for which sibling maps can be computed */ static cpumask_var_t cpu_sibling_setup_mask; @@ -169,8 +167,8 @@ static void smp_callin(void) int cpuid = smp_processor_id(); /* - * If waken up by an INIT in an 82489DX configuration - * cpu_callout_mask guarantees we don't get here before an + * If waken up by an INIT in an 82489DX configuration the alive + * synchronization guarantees we don't get here before an * INIT_deassert IPI reaches our local APIC, so it is now safe to * touch our local APIC. * @@ -216,17 +214,6 @@ static void ap_calibrate_delay(void) cpu_data(smp_processor_id()).loops_per_jiffy = loops_per_jiffy; } -static void wait_for_master_cpu(int cpu) -{ - /* - * Wait for release by control CPU before continuing with AP - * initialization. - */ - WARN_ON(cpumask_test_and_set_cpu(cpu, cpu_initialized_mask)); - while (!cpumask_test_cpu(cpu, cpu_callout_mask)) - cpu_relax(); -} - /* * Activate a secondary processor. */ @@ -247,11 +234,11 @@ static void notrace start_secondary(void cpu_init_exception_handling(); /* - * Sync point with wait_cpu_initialized(). Sets AP in - * cpu_initialized_mask and then waits for the control CPU - * to release it. + * Synchronization point with the hotplug core. Sets the + * synchronization state to ALIVE and waits for the control CPU to + * release this CPU for further bringup. */ - wait_for_master_cpu(raw_smp_processor_id()); + cpuhp_ap_sync_alive(); cpu_init(); rcu_cpu_starting(raw_smp_processor_id()); @@ -284,7 +271,6 @@ static void notrace start_secondary(void set_cpu_online(smp_processor_id(), true); lapic_online(); unlock_vector_lock(); - cpu_set_state_online(smp_processor_id()); x86_platform.nmi_init(); /* enable local interrupts */ @@ -735,9 +721,9 @@ static void impress_friends(void) * Allow the user to impress friends. */ pr_debug("Before bogomips\n"); - for_each_possible_cpu(cpu) - if (cpumask_test_cpu(cpu, cpu_callout_mask)) - bogosum += cpu_data(cpu).loops_per_jiffy; + for_each_online_cpu(cpu) + bogosum += cpu_data(cpu).loops_per_jiffy; + pr_info("Total of %d processors activated (%lu.%02lu BogoMIPS)\n", num_online_cpus(), bogosum/(500000/HZ), @@ -1009,6 +995,7 @@ int common_cpu_up(unsigned int cpu, stru static int do_boot_cpu(int apicid, int cpu, struct task_struct *idle) { unsigned long start_ip = real_mode_header->trampoline_start; + int ret; #ifdef CONFIG_X86_64 /* If 64-bit wakeup method exists, use the 64-bit mode trampoline IP */ @@ -1049,13 +1036,6 @@ static int do_boot_cpu(int apicid, int c } } - /* - * AP might wait on cpu_callout_mask in cpu_init() with - * cpu_initialized_mask set if previous attempt to online - * it timed-out. Clear cpu_initialized_mask so that after - * INIT/SIPI it could start with a clean state. - */ - cpumask_clear_cpu(cpu, cpu_initialized_mask); smp_mb(); /* @@ -1066,47 +1046,16 @@ static int do_boot_cpu(int apicid, int c * - Use an INIT boot APIC message */ if (apic->wakeup_secondary_cpu_64) - return apic->wakeup_secondary_cpu_64(apicid, start_ip); + ret = apic->wakeup_secondary_cpu_64(apicid, start_ip); else if (apic->wakeup_secondary_cpu) - return apic->wakeup_secondary_cpu(apicid, start_ip); - - return wakeup_secondary_cpu_via_init(apicid, start_ip); -} - -static int wait_cpu_cpumask(unsigned int cpu, const struct cpumask *mask) -{ - unsigned long timeout; - - /* - * Wait up to 10s for the CPU to report in. - */ - timeout = jiffies + 10*HZ; - while (time_before(jiffies, timeout)) { - if (cpumask_test_cpu(cpu, mask)) - return 0; - - schedule(); - } - return -1; -} - -/* - * Bringup step two: Wait for the target AP to reach cpu_init_secondary() - * and thus wait_for_master_cpu(), then set cpu_callout_mask to allow it - * to proceed. The AP will then proceed past setting its 'callin' bit - * and end up waiting in check_tsc_sync_target() until we reach - * wait_cpu_online() to tend to it. - */ -static int wait_cpu_initialized(unsigned int cpu) -{ - /* - * Wait for first sign of life from AP. - */ - if (wait_cpu_cpumask(cpu, cpu_initialized_mask)) - return -1; + ret = apic->wakeup_secondary_cpu(apicid, start_ip); + else + ret = wakeup_secondary_cpu_via_init(apicid, start_ip); - cpumask_set_cpu(cpu, cpu_callout_mask); - return 0; + /* If the wakeup mechanism failed, cleanup the warm reset vector */ + if (ret) + arch_cpuhp_cleanup_kick_cpu(cpu); + return ret; } static int native_kick_ap(unsigned int cpu, struct task_struct *tidle) @@ -1131,11 +1080,6 @@ static int native_kick_ap(unsigned int c */ mtrr_save_state(); - /* x86 CPUs take themselves offline, so delayed offline is OK. */ - err = cpu_check_up_prepare(cpu); - if (err && err != -EBUSY) - return err; - /* the FPU context is blank, nobody can own it */ per_cpu(fpu_fpregs_owner_ctx, cpu) = NULL; @@ -1152,17 +1096,29 @@ static int native_kick_ap(unsigned int c int native_cpu_up(unsigned int cpu, struct task_struct *tidle) { - int ret; - - ret = native_kick_ap(cpu, tidle); - if (!ret) - ret = wait_cpu_initialized(cpu); + return native_kick_ap(cpu, tidle); +} +void arch_cpuhp_cleanup_kick_cpu(unsigned int cpu) +{ /* Cleanup possible dangling ends... */ - if (x86_platform.legacy.warm_reset) + if (smp_ops.cpu_up == native_cpu_up && x86_platform.legacy.warm_reset) smpboot_restore_warm_reset_vector(); +} - return ret; +void arch_cpuhp_cleanup_dead_cpu(unsigned int cpu) +{ + if (smp_ops.cleanup_dead_cpu) + smp_ops.cleanup_dead_cpu(cpu); + + if (system_state == SYSTEM_RUNNING) + pr_info("CPU %u is now offline\n", cpu); +} + +void arch_cpuhp_sync_state_poll(void) +{ + if (smp_ops.poll_sync_state) + smp_ops.poll_sync_state(); } /** @@ -1354,9 +1310,6 @@ void __init native_smp_prepare_boot_cpu( if (!IS_ENABLED(CONFIG_SMP)) switch_gdt_and_percpu_base(me); - /* already set me in cpu_online_mask in boot_cpu_init() */ - cpumask_set_cpu(me, cpu_callout_mask); - cpu_set_state_online(me); native_pv_lock_init(); } @@ -1483,8 +1436,6 @@ early_param("possible_cpus", _setup_poss /* correctly size the local cpu masks */ void __init setup_cpu_local_masks(void) { - alloc_bootmem_cpumask_var(&cpu_initialized_mask); - alloc_bootmem_cpumask_var(&cpu_callout_mask); alloc_bootmem_cpumask_var(&cpu_sibling_setup_mask); } @@ -1546,9 +1497,6 @@ static void remove_siblinginfo(int cpu) static void remove_cpu_from_maps(int cpu) { set_cpu_online(cpu, false); - cpumask_clear_cpu(cpu, cpu_callout_mask); - /* was set by cpu_init() */ - cpumask_clear_cpu(cpu, cpu_initialized_mask); numa_remove_cpu(cpu); } @@ -1599,36 +1547,11 @@ int native_cpu_disable(void) return 0; } -int common_cpu_die(unsigned int cpu) -{ - int ret = 0; - - /* We don't do anything here: idle task is faking death itself. */ - - /* They ack this in play_dead() by setting CPU_DEAD */ - if (cpu_wait_death(cpu, 5)) { - if (system_state == SYSTEM_RUNNING) - pr_info("CPU %u is now offline\n", cpu); - } else { - pr_err("CPU %u didn't die...\n", cpu); - ret = -1; - } - - return ret; -} - -void native_cpu_die(unsigned int cpu) -{ - common_cpu_die(cpu); -} - void play_dead_common(void) { idle_task_exit(); - /* Ack it */ - (void)cpu_report_death(); - + cpuhp_ap_report_dead(); /* * With physical CPU hotplug, we should halt the cpu */ @@ -1730,12 +1653,6 @@ int native_cpu_disable(void) return -ENOSYS; } -void native_cpu_die(unsigned int cpu) -{ - /* We said "no" in __cpu_disable */ - BUG(); -} - void native_play_dead(void) { BUG(); --- a/arch/x86/xen/smp_hvm.c +++ b/arch/x86/xen/smp_hvm.c @@ -55,18 +55,16 @@ static void __init xen_hvm_smp_prepare_c } #ifdef CONFIG_HOTPLUG_CPU -static void xen_hvm_cpu_die(unsigned int cpu) +static void xen_hvm_cleanup_dead_cpu(unsigned int cpu) { - if (common_cpu_die(cpu) == 0) { - if (xen_have_vector_callback) { - xen_smp_intr_free(cpu); - xen_uninit_lock_cpu(cpu); - xen_teardown_timer(cpu); - } + if (xen_have_vector_callback) { + xen_smp_intr_free(cpu); + xen_uninit_lock_cpu(cpu); + xen_teardown_timer(cpu); } } #else -static void xen_hvm_cpu_die(unsigned int cpu) +static void xen_hvm_cleanup_dead_cpu(unsigned int cpu) { BUG(); } @@ -77,7 +75,7 @@ void __init xen_hvm_smp_init(void) smp_ops.smp_prepare_boot_cpu = xen_hvm_smp_prepare_boot_cpu; smp_ops.smp_prepare_cpus = xen_hvm_smp_prepare_cpus; smp_ops.smp_cpus_done = xen_smp_cpus_done; - smp_ops.cpu_die = xen_hvm_cpu_die; + smp_ops.cleanup_dead_cpu = xen_hvm_cleanup_dead_cpu; if (!xen_have_vector_callback) { #ifdef CONFIG_PARAVIRT_SPINLOCKS --- a/arch/x86/xen/smp_pv.c +++ b/arch/x86/xen/smp_pv.c @@ -62,6 +62,7 @@ static void cpu_bringup(void) int cpu; cr4_init(); + cpuhp_ap_sync_alive(); cpu_init(); touch_softlockup_watchdog(); @@ -83,7 +84,7 @@ static void cpu_bringup(void) set_cpu_online(cpu, true); - cpu_set_state_online(cpu); /* Implies full memory barrier. */ + smp_mb(); /* We can take interrupts now: we're officially "up". */ local_irq_enable(); @@ -323,14 +324,6 @@ static int xen_pv_cpu_up(unsigned int cp xen_setup_runstate_info(cpu); - /* - * PV VCPUs are always successfully taken down (see 'while' loop - * in xen_cpu_die()), so -EBUSY is an error. - */ - rc = cpu_check_up_prepare(cpu); - if (rc) - return rc; - /* make sure interrupts start blocked */ per_cpu(xen_vcpu, cpu)->evtchn_upcall_mask = 1; @@ -349,6 +342,11 @@ static int xen_pv_cpu_up(unsigned int cp return 0; } +static void xen_pv_poll_sync_state(void) +{ + HYPERVISOR_sched_op(SCHEDOP_yield, NULL); +} + #ifdef CONFIG_HOTPLUG_CPU static int xen_pv_cpu_disable(void) { @@ -364,18 +362,18 @@ static int xen_pv_cpu_disable(void) static void xen_pv_cpu_die(unsigned int cpu) { - while (HYPERVISOR_vcpu_op(VCPUOP_is_up, - xen_vcpu_nr(cpu), NULL)) { + while (HYPERVISOR_vcpu_op(VCPUOP_is_up, xen_vcpu_nr(cpu), NULL)) { __set_current_state(TASK_UNINTERRUPTIBLE); schedule_timeout(HZ/10); } +} - if (common_cpu_die(cpu) == 0) { - xen_smp_intr_free(cpu); - xen_uninit_lock_cpu(cpu); - xen_teardown_timer(cpu); - xen_pmu_finish(cpu); - } +static void xen_pv_cleanup_dead_cpu(unsigned int cpu) +{ + xen_smp_intr_free(cpu); + xen_uninit_lock_cpu(cpu); + xen_teardown_timer(cpu); + xen_pmu_finish(cpu); } static void __noreturn xen_pv_play_dead(void) /* used only with HOTPLUG_CPU */ @@ -397,6 +395,11 @@ static void xen_pv_cpu_die(unsigned int BUG(); } +static void xen_pv_cleanup_dead_cpu(unsigned int cpu) +{ + BUG(); +} + static void __noreturn xen_pv_play_dead(void) { BUG(); @@ -437,6 +440,8 @@ static const struct smp_ops xen_smp_ops .cpu_up = xen_pv_cpu_up, .cpu_die = xen_pv_cpu_die, + .cleanup_dead_cpu = xen_pv_cleanup_dead_cpu, + .poll_sync_state = xen_pv_poll_sync_state, .cpu_disable = xen_pv_cpu_disable, .play_dead = xen_pv_play_dead, From xen-devel-bounces@lists.xenproject.org Mon May 08 19:48:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:48:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531846.827832 (Exim 4.92) (envelope-from ) id 1pw6q2-0003dY-C4; Mon, 08 May 2023 19:48:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531846.827832; Mon, 08 May 2023 19:48:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6q2-0003d7-4Z; Mon, 08 May 2023 19:48:02 +0000 Received: by outflank-mailman (input) for mailman id 531846; Mon, 08 May 2023 19:48:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6mG-0004GB-SD for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:44:08 +0000 Received: from galois.linutronix.de (galois.linutronix.de [2a0a:51c0:0:12e:550::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b266ad52-edd8-11ed-b226-6b7b168915f2; Mon, 08 May 2023 21:44:08 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b266ad52-edd8-11ed-b226-6b7b168915f2 Message-ID: <20230508185218.643400362@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575047; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=hx5fWQqpBJqFhc3VD4cFl0lkC1fEFtezXeQ/kkMDuYM=; b=dMSiYiyMCD3/kfD6ycKkp08Cs2yGyR46ibmTbUZ4EPuuwnERkLqo1DPunwf9Bd+Lh282Kk iyz5crAqn34/Z1DU1FdeHq8w2ICxkwvwPupWSapQM5bKWcd06oqKMF65CPiBv3i5Jdq5GK No9UCLkO9a75FWDWNjS5cUfUlOLyZkVKjYuIut6Mde17+klVjF/vsV/x/8XZgC94CcLGgL esCNz6eRqlPWNCIMyIyPzBMIvNBVYenPTUQOWaJr4izZS/Q4K0oHTNZvGzzHj78cMSROKA 7adYzjGge8G4Bi2MTD6vyk5VOcXBsF4npN+FHo+bMYD6KtCMSa31T9g3imKuVQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575047; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=hx5fWQqpBJqFhc3VD4cFl0lkC1fEFtezXeQ/kkMDuYM=; b=5H4Y1AwaHO6MuLieAAEsSuc7IElwyyxQTr8AXtmBcHORWW1C5BYTyvmgYBKAcPiBa35CdM lrZnB79si3SXI4BQ== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch v3 25/36] parisc: Switch to hotplug core state synchronization References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:44:07 +0200 (CEST) From: Thomas Gleixner Switch to the CPU hotplug core state tracking and synchronization mechanim. No functional change intended. Signed-off-by: Thomas Gleixner Tested-by: Michael Kelley --- arch/parisc/Kconfig | 1 + arch/parisc/kernel/process.c | 4 ++-- arch/parisc/kernel/smp.c | 7 +++---- 3 files changed, 6 insertions(+), 6 deletions(-) --- --- a/arch/parisc/Kconfig +++ b/arch/parisc/Kconfig @@ -57,6 +57,7 @@ config PARISC select HAVE_ARCH_SECCOMP_FILTER select HAVE_ARCH_TRACEHOOK select HAVE_REGS_AND_STACK_ACCESS_API + select HOTPLUG_CORE_SYNC_DEAD if HOTPLUG_CPU select GENERIC_SCHED_CLOCK select GENERIC_IRQ_MIGRATION if SMP select HAVE_UNSTABLE_SCHED_CLOCK if SMP --- a/arch/parisc/kernel/process.c +++ b/arch/parisc/kernel/process.c @@ -166,8 +166,8 @@ void __noreturn arch_cpu_idle_dead(void) local_irq_disable(); - /* Tell __cpu_die() that this CPU is now safe to dispose of. */ - (void)cpu_report_death(); + /* Tell the core that this CPU is now safe to dispose of. */ + cpuhp_ap_report_dead(); /* Ensure that the cache lines are written out. */ flush_cache_all_local(); --- a/arch/parisc/kernel/smp.c +++ b/arch/parisc/kernel/smp.c @@ -500,11 +500,10 @@ int __cpu_disable(void) void __cpu_die(unsigned int cpu) { pdc_cpu_rendezvous_lock(); +} - if (!cpu_wait_death(cpu, 5)) { - pr_crit("CPU%u: cpu didn't die\n", cpu); - return; - } +void arch_cpuhp_cleanup_dead_cpu(unsigned int cpu) +{ pr_info("CPU%u: is shutting down\n", cpu); /* set task's state to interruptible sleep */ From xen-devel-bounces@lists.xenproject.org Mon May 08 19:48:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:48:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531848.827837 (Exim 4.92) (envelope-from ) id 1pw6q3-0003jH-2w; Mon, 08 May 2023 19:48:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531848.827837; Mon, 08 May 2023 19:48:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6q2-0003hx-Nl; Mon, 08 May 2023 19:48:02 +0000 Received: by outflank-mailman (input) for mailman id 531848; Mon, 08 May 2023 19:48:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6mJ-0004GB-V4 for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:44:11 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b458d500-edd8-11ed-b226-6b7b168915f2; Mon, 08 May 2023 21:44:11 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b458d500-edd8-11ed-b226-6b7b168915f2 Message-ID: <20230508185218.749244209@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=4bj8ZvYTo7h4ovclEum+b6WsfhLEcO8uNjPMgn9Q5x4=; b=luptazBGQl/6gwCsUF/buYWxkBAEoJNYHx7Kxq0OeppfP1uF6F7NgOCw3LqRVTaT31I9h4 D5XOFiRqBn9YmzEHb1c8fA6wh7ZzDtnqoGVuN2a4blplprkdtDd8R1N5BUJ7dY//ynam4z 9nOeEaXVbMYGsvANvqaAzHwNiaL+IZrNUZNLb8PdkXNIsgQJ3JnLHxTcMWQHPktfZ7p1+I valh5s3/2GsrRw0m8GhQn7EqA30eWJMKuxbBma4fWLJDjf3ostL0yMHCO5slcxoZThfFtJ ateRKwD80dVM75IN8sPMyv58NxXIKSeUEGcWX63SCtgZbvKN9Mfqco6vLkvfkg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=4bj8ZvYTo7h4ovclEum+b6WsfhLEcO8uNjPMgn9Q5x4=; b=Irrw/2b9WZnFSWO4H5T5IOf9dImpiZr2fFBeiX3HwHII5+jw+y4xy+lPuveYMabu3EDI57 iXBQKFEgrrdQwlAQ== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch v3 27/36] cpu/hotplug: Remove unused state functions References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:44:10 +0200 (CEST) From: Thomas Gleixner All users converted to the hotplug core mechanism. Signed-off-by: Thomas Gleixner Tested-by: Michael Kelley --- include/linux/cpu.h | 2 - kernel/smpboot.c | 75 ---------------------------------------------------- 2 files changed, 77 deletions(-) --- --- a/include/linux/cpu.h +++ b/include/linux/cpu.h @@ -193,8 +193,6 @@ static inline void play_idle(unsigned lo } #ifdef CONFIG_HOTPLUG_CPU -bool cpu_wait_death(unsigned int cpu, int seconds); -bool cpu_report_death(void); void cpuhp_report_idle_dead(void); #else static inline void cpuhp_report_idle_dead(void) { } --- a/kernel/smpboot.c +++ b/kernel/smpboot.c @@ -325,78 +325,3 @@ void smpboot_unregister_percpu_thread(st cpus_read_unlock(); } EXPORT_SYMBOL_GPL(smpboot_unregister_percpu_thread); - -#ifndef CONFIG_HOTPLUG_CORE_SYNC -static DEFINE_PER_CPU(atomic_t, cpu_hotplug_state) = ATOMIC_INIT(CPU_POST_DEAD); - -#ifdef CONFIG_HOTPLUG_CPU -/* - * Wait for the specified CPU to exit the idle loop and die. - */ -bool cpu_wait_death(unsigned int cpu, int seconds) -{ - int jf_left = seconds * HZ; - int oldstate; - bool ret = true; - int sleep_jf = 1; - - might_sleep(); - - /* The outgoing CPU will normally get done quite quickly. */ - if (atomic_read(&per_cpu(cpu_hotplug_state, cpu)) == CPU_DEAD) - goto update_state_early; - udelay(5); - - /* But if the outgoing CPU dawdles, wait increasingly long times. */ - while (atomic_read(&per_cpu(cpu_hotplug_state, cpu)) != CPU_DEAD) { - schedule_timeout_uninterruptible(sleep_jf); - jf_left -= sleep_jf; - if (jf_left <= 0) - break; - sleep_jf = DIV_ROUND_UP(sleep_jf * 11, 10); - } -update_state_early: - oldstate = atomic_read(&per_cpu(cpu_hotplug_state, cpu)); -update_state: - if (oldstate == CPU_DEAD) { - /* Outgoing CPU died normally, update state. */ - smp_mb(); /* atomic_read() before update. */ - atomic_set(&per_cpu(cpu_hotplug_state, cpu), CPU_POST_DEAD); - } else { - /* Outgoing CPU still hasn't died, set state accordingly. */ - if (!atomic_try_cmpxchg(&per_cpu(cpu_hotplug_state, cpu), - &oldstate, CPU_BROKEN)) - goto update_state; - ret = false; - } - return ret; -} - -/* - * Called by the outgoing CPU to report its successful death. Return - * false if this report follows the surviving CPU's timing out. - * - * A separate "CPU_DEAD_FROZEN" is used when the surviving CPU - * timed out. This approach allows architectures to omit calls to - * cpu_check_up_prepare() and cpu_set_state_online() without defeating - * the next cpu_wait_death()'s polling loop. - */ -bool cpu_report_death(void) -{ - int oldstate; - int newstate; - int cpu = smp_processor_id(); - - oldstate = atomic_read(&per_cpu(cpu_hotplug_state, cpu)); - do { - if (oldstate != CPU_BROKEN) - newstate = CPU_DEAD; - else - newstate = CPU_DEAD_FROZEN; - } while (!atomic_try_cmpxchg(&per_cpu(cpu_hotplug_state, cpu), - &oldstate, newstate)); - return newstate == CPU_DEAD; -} - -#endif /* #ifdef CONFIG_HOTPLUG_CPU */ -#endif /* !CONFIG_HOTPLUG_CORE_SYNC */ From xen-devel-bounces@lists.xenproject.org Mon May 08 19:48:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:48:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531851.827843 (Exim 4.92) (envelope-from ) id 1pw6q4-00041T-BQ; Mon, 08 May 2023 19:48:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531851.827843; Mon, 08 May 2023 19:48:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6q3-0003xB-Up; Mon, 08 May 2023 19:48:03 +0000 Received: by outflank-mailman (input) for mailman id 531851; Mon, 08 May 2023 19:48:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6m9-0004Y5-HR for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:44:01 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ad7f2531-edd8-11ed-8611-37d641c3527e; Mon, 08 May 2023 21:43:59 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad7f2531-edd8-11ed-8611-37d641c3527e Message-ID: <20230508185218.354392116@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575039; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=XHpNsJs5kSVxMByUTgiKML4QfVv98dxDjLlAQchlqtk=; b=Ki8zOz4u2YoGQTHxRWvDCdJpS9rUfG7Rt8el1sEQonOE93FQ2t/Ouh6saOF5zSGR/sUwqy RGwztYnIhjpNbF8b2PGA4CfI6IE5cG/4pkd5Q33EfIphmoL8ll1Ul99/6dF/RDkEojrYjr EB5pH//XxOfXbRz5/okajpcb/SRh9nL9WoyZaL+b0N+3wBhaYWzQ0JAad4Cix7Pxxq45EN qoUV3fffrtSRueog+x/R851Gsai56IVP/bi8/TS243MY3shbpmrcRDIo+w8Qw8dLxfZrAJ 3jwxSYmT//Hz16/1k1wHeOTfsamwVnUrPFdDAmzXRODZAUOo/yfyrnt7BniKSQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575039; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=XHpNsJs5kSVxMByUTgiKML4QfVv98dxDjLlAQchlqtk=; b=nQqE0LEqpdin/188ms5Eh3E7UO6uD16LhW/aIhEdUgOoCpO7X2+xXn/WMrcSUx9PqrxIEc Yg+NuqTDvr5KtUBA== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch v3 20/36] cpu/hotplug: Remove cpu_report_state() and related unused cruft References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:43:59 +0200 (CEST) From: Thomas Gleixner No more users. Signed-off-by: Thomas Gleixner Tested-by: Michael Kelley --- include/linux/cpu.h | 2 - kernel/smpboot.c | 90 ---------------------------------------------------- 2 files changed, 92 deletions(-) --- --- a/include/linux/cpu.h +++ b/include/linux/cpu.h @@ -184,8 +184,6 @@ void arch_cpu_idle_enter(void); void arch_cpu_idle_exit(void); void __noreturn arch_cpu_idle_dead(void); -int cpu_report_state(int cpu); -int cpu_check_up_prepare(int cpu); void cpu_set_state_online(int cpu); void play_idle_precise(u64 duration_ns, u64 latency_ns); --- a/kernel/smpboot.c +++ b/kernel/smpboot.c @@ -329,97 +329,7 @@ EXPORT_SYMBOL_GPL(smpboot_unregister_per #ifndef CONFIG_HOTPLUG_CORE_SYNC static DEFINE_PER_CPU(atomic_t, cpu_hotplug_state) = ATOMIC_INIT(CPU_POST_DEAD); -/* - * Called to poll specified CPU's state, for example, when waiting for - * a CPU to come online. - */ -int cpu_report_state(int cpu) -{ - return atomic_read(&per_cpu(cpu_hotplug_state, cpu)); -} - -/* - * If CPU has died properly, set its state to CPU_UP_PREPARE and - * return success. Otherwise, return -EBUSY if the CPU died after - * cpu_wait_death() timed out. And yet otherwise again, return -EAGAIN - * if cpu_wait_death() timed out and the CPU still hasn't gotten around - * to dying. In the latter two cases, the CPU might not be set up - * properly, but it is up to the arch-specific code to decide. - * Finally, -EIO indicates an unanticipated problem. - * - * Note that it is permissible to omit this call entirely, as is - * done in architectures that do no CPU-hotplug error checking. - */ -int cpu_check_up_prepare(int cpu) -{ - if (!IS_ENABLED(CONFIG_HOTPLUG_CPU)) { - atomic_set(&per_cpu(cpu_hotplug_state, cpu), CPU_UP_PREPARE); - return 0; - } - - switch (atomic_read(&per_cpu(cpu_hotplug_state, cpu))) { - - case CPU_POST_DEAD: - - /* The CPU died properly, so just start it up again. */ - atomic_set(&per_cpu(cpu_hotplug_state, cpu), CPU_UP_PREPARE); - return 0; - - case CPU_DEAD_FROZEN: - - /* - * Timeout during CPU death, so let caller know. - * The outgoing CPU completed its processing, but after - * cpu_wait_death() timed out and reported the error. The - * caller is free to proceed, in which case the state - * will be reset properly by cpu_set_state_online(). - * Proceeding despite this -EBUSY return makes sense - * for systems where the outgoing CPUs take themselves - * offline, with no post-death manipulation required from - * a surviving CPU. - */ - return -EBUSY; - - case CPU_BROKEN: - - /* - * The most likely reason we got here is that there was - * a timeout during CPU death, and the outgoing CPU never - * did complete its processing. This could happen on - * a virtualized system if the outgoing VCPU gets preempted - * for more than five seconds, and the user attempts to - * immediately online that same CPU. Trying again later - * might return -EBUSY above, hence -EAGAIN. - */ - return -EAGAIN; - - case CPU_UP_PREPARE: - /* - * Timeout while waiting for the CPU to show up. Allow to try - * again later. - */ - return 0; - - default: - - /* Should not happen. Famous last words. */ - return -EIO; - } -} - -/* - * Mark the specified CPU online. - * - * Note that it is permissible to omit this call entirely, as is - * done in architectures that do no CPU-hotplug error checking. - */ -void cpu_set_state_online(int cpu) -{ - (void)atomic_xchg(&per_cpu(cpu_hotplug_state, cpu), CPU_ONLINE); -} - #ifdef CONFIG_HOTPLUG_CPU - /* * Wait for the specified CPU to exit the idle loop and die. */ From xen-devel-bounces@lists.xenproject.org Mon May 08 19:48:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 19:48:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531860.827862 (Exim 4.92) (envelope-from ) id 1pw6q8-00054j-5n; Mon, 08 May 2023 19:48:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531860.827862; Mon, 08 May 2023 19:48:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6q7-00052m-RJ; Mon, 08 May 2023 19:48:07 +0000 Received: by outflank-mailman (input) for mailman id 531860; Mon, 08 May 2023 19:48:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw6mT-0004GB-QM for xen-devel@lists.xenproject.org; Mon, 08 May 2023 19:44:21 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ba44802f-edd8-11ed-b226-6b7b168915f2; Mon, 08 May 2023 21:44:21 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ba44802f-edd8-11ed-b226-6b7b168915f2 Message-ID: <20230508185219.070274100@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683575061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=rNSjycztoby2JMftnREWdlBREDazVhJLVJwM8M2fPkk=; b=OpZe9lLKyKO6h5IfhQv2j9WvmIn2yf65zqaHV7y3wQleqSqr+f6etMGdIS9Efc2LFhQWS0 5ftRjwED05+6AZBpiAUMBSD+9Bs4XI7ErbN7ZPJB/dWcAHVXO0162v680HbB1xi5BIj6b6 2VmnddYXWQAy5QrMp52rjUb0ug4Nu5d4+araY9u5t682iYzuMEwChigCf9eS54/VMeAbyp FHpBHrvUOTNlGmggxAiWaYQoqPnvlTGipZEoQY9ETwz7wg7cLp6+qhnkF8oJI3QMQlbXXd MwefEeZHkRCA3XHukRzDC06izW3/O9wI5c+MU2Y7YPlYsyj6psxCoZFPmRCp2g== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683575061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=rNSjycztoby2JMftnREWdlBREDazVhJLVJwM8M2fPkk=; b=L+J15yNAu9kuVnMklFhkCkOJaiMb9jA+tCWcI3g0yk74oGzDCt/9UexPGrZp3cttAT1h/e UE8ijpRbZRAquYDA== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: [patch v3 33/36] x86/apic: Save the APIC virtual base address References: <20230508181633.089804905@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Mon, 8 May 2023 21:44:20 +0200 (CEST) From: Thomas Gleixner For parallel CPU brinugp it's required to read the APIC ID in the low level startup code. The virtual APIC base address is a constant because its a fix-mapped address. Exposing that constant which is composed via macros to assembly code is non-trivial dues to header inclusion hell. Aside of that it's constant only because of the vsyscall ABI requirement. Once vsyscall is out of the picture the fixmap can be placed at runtime. Avoid header hell, stay flexible and store the address in a variable which can be exposed to the low level startup code. Signed-off-by: Thomas Gleixner Tested-by: Michael Kelley --- arch/x86/include/asm/smp.h | 1 + arch/x86/kernel/apic/apic.c | 4 ++++ 2 files changed, 5 insertions(+) --- --- a/arch/x86/include/asm/smp.h +++ b/arch/x86/include/asm/smp.h @@ -196,6 +196,7 @@ extern void nmi_selftest(void); #endif extern unsigned int smpboot_control; +extern unsigned long apic_mmio_base; #endif /* !__ASSEMBLY__ */ --- a/arch/x86/kernel/apic/apic.c +++ b/arch/x86/kernel/apic/apic.c @@ -101,6 +101,9 @@ static int apic_extnmi __ro_after_init = */ static bool virt_ext_dest_id __ro_after_init; +/* For parallel bootup. */ +unsigned long apic_mmio_base __ro_after_init; + /* * Map cpu index to physical APIC ID */ @@ -2163,6 +2166,7 @@ void __init register_lapic_address(unsig if (!x2apic_mode) { set_fixmap_nocache(FIX_APIC_BASE, address); + apic_mmio_base = APIC_BASE; apic_printk(APIC_VERBOSE, "mapped APIC to %16lx (%16lx)\n", APIC_BASE, address); } From xen-devel-bounces@lists.xenproject.org Mon May 08 20:53:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 20:53:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531909.827871 (Exim 4.92) (envelope-from ) id 1pw7rF-00079A-QL; Mon, 08 May 2023 20:53:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531909.827871; Mon, 08 May 2023 20:53:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw7rF-000793-Nf; Mon, 08 May 2023 20:53:21 +0000 Received: by outflank-mailman (input) for mailman id 531909; Mon, 08 May 2023 20:53:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw7rD-00078t-LS; Mon, 08 May 2023 20:53:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw7rD-0002T9-J5; Mon, 08 May 2023 20:53:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw7rC-000661-Vm; Mon, 08 May 2023 20:53:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pw7rC-0000Zp-UQ; Mon, 08 May 2023 20:53:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=hNnDSUl9bZpecRe2kcUwMrPPEQpb64bR+kWhZ8EwxO0=; b=MK4TAmzuCiRG+tpt3hAeDIk0ER 7unkdsyt+j+71WMhPpz/DEb9MbEdPFlkpjZ5NF0hY7J9ly0DmgICFe3nGL1xpVO6vaFhN4DvcfYRz 4mWu2ymuEmlvFovW0dWWnehKbRKVlQt98V5GTGJV4N+g5cgGwnH0zAmwL0gBetmLw6Vs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180578: regressions - FAIL X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-linus:test-armhf-armhf-examine:reboot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=ac9a78681b921877518763ba0e89202254349d1b X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Mon, 08 May 2023 20:53:18 +0000 flight 180578 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/180578/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 180278 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 180574 Tests which did not succeed, but are not blocking: test-armhf-armhf-examine 8 reboot fail like 180278 test-armhf-armhf-libvirt 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-raw 8 xen-boot fail like 180278 test-armhf-armhf-xl-rtds 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180278 test-armhf-armhf-xl 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180278 test-armhf-armhf-xl-multivcpu 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail like 180278 test-armhf-armhf-xl-credit2 8 xen-boot fail like 180278 test-armhf-armhf-xl-vhd 8 xen-boot fail like 180278 test-armhf-armhf-xl-arndale 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux ac9a78681b921877518763ba0e89202254349d1b baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 22 days Failing since 180281 2023-04-17 06:24:36 Z 21 days 39 attempts Testing same since 180571 2023-05-07 22:11:42 Z 0 days 3 attempts ------------------------------------------------------------ 2359 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 296910 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 08 21:12:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 21:12:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531915.827882 (Exim 4.92) (envelope-from ) id 1pw89E-0001Cz-AQ; Mon, 08 May 2023 21:11:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531915.827882; Mon, 08 May 2023 21:11:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw89E-0001Cs-7J; Mon, 08 May 2023 21:11:56 +0000 Received: by outflank-mailman (input) for mailman id 531915; Mon, 08 May 2023 21:11:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw89D-0001Cm-0G for xen-devel@lists.xenproject.org; Mon, 08 May 2023 21:11:55 +0000 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f3b1f9d1-ede4-11ed-b226-6b7b168915f2; Mon, 08 May 2023 23:11:53 +0200 (CEST) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1aad6f2be8eso47446215ad.3 for ; Mon, 08 May 2023 14:11:52 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([20.69.120.36]) by smtp.gmail.com with ESMTPSA id k14-20020a170902760e00b0019aeddce6casm7648553pll.205.2023.05.08.14.11.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 May 2023 14:11:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f3b1f9d1-ede4-11ed-b226-6b7b168915f2 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683580311; x=1686172311; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NFnNeAlUj9C+huN2rBEcxkVDG8OipZYXhgLegmZBDMk=; b=T2Gihf/TB44KBcPKItW7mTEncGsIA+xFO2igp+BadB2b9EAQ8JFjoTr6VumeRXkmMV 2carEAlSnI9T5CmasnTDIpArCW3KRHr2J/zVEwn+17X8VTZzQHKsX5ecIYNgZMNPFr7D oUNKPo1viLNPDjH2JCDjYMMLGrDdrGq4DQomkMX7UDwPrXk9sVLp6Yx6qcvYISjmxV96 dVFa8xzFOCeP8Vgz16w++S7QCKXRqUpbqQsE5QaPtkBhFdqg6b8jPHR5M8CcRvLY3fma 0W1q0CDnTbgqz593EV8hMIaQdiP4K4ZXa9JPkD7aw5ir2SVylcNlOt6hR4aJmSR3qx8s UTKQ== X-Gm-Message-State: AC+VfDwQOdRSoONmLnfu67cO5O4e6hMpqU38g38t04KFUVNUqromtnOQ eqDegmbsbHuW5ohnALlkxsk= X-Google-Smtp-Source: ACHHUZ6BtFvSoF+wcEO4loE9NZdFfCT+I/PFTdAZhqBSeRBB8gma6+CJUbrsA8zRjfVrnuCD3KU/Lw== X-Received: by 2002:a17:90a:65cb:b0:248:8399:1f7c with SMTP id i11-20020a17090a65cb00b0024883991f7cmr11239406pjs.38.1683580310757; Mon, 08 May 2023 14:11:50 -0700 (PDT) Date: Mon, 8 May 2023 21:11:48 +0000 From: Wei Liu To: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= Cc: Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Ingo Molnar , Kees Cook , Paolo Bonzini , Sean Christopherson , Thomas Gleixner , Vitaly Kuznetsov , Wanpeng Li , Alexander Graf , Forrest Yuan Yu , James Morris , John Andersen , Liran Alon , "Madhavan T . Venkataraman" , Marian Rotariu , Mihai =?utf-8?B?RG9uyJt1?= , =?utf-8?B?TmljdciZb3IgQ8OuyJt1?= , Rick Edgecombe , Thara Gopinath , Will Deacon , Zahra Tarkhani , =?utf-8?Q?=C8=98tefan_=C8=98icleru?= , dev@lists.cloudhypervisor.org, kvm@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, x86@kernel.org, xen-devel@lists.xenproject.org, Wei Liu Subject: Re: [PATCH v1 5/9] KVM: x86: Add new hypercall to lock control registers Message-ID: References: <20230505152046.6575-1-mic@digikod.net> <20230505152046.6575-6-mic@digikod.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230505152046.6575-6-mic@digikod.net> On Fri, May 05, 2023 at 05:20:42PM +0200, Mickal Salan wrote: > This enables guests to lock their CR0 and CR4 registers with a subset of > X86_CR0_WP, X86_CR4_SMEP, X86_CR4_SMAP, X86_CR4_UMIP, X86_CR4_FSGSBASE > and X86_CR4_CET flags. > > The new KVM_HC_LOCK_CR_UPDATE hypercall takes two arguments. The first > is to identify the control register, and the second is a bit mask to > pin (i.e. mark as read-only). > > These register flags should already be pinned by Linux guests, but once > compromised, this self-protection mechanism could be disabled, which is > not the case with this dedicated hypercall. > > Cc: Borislav Petkov > Cc: Dave Hansen > Cc: H. Peter Anvin > Cc: Ingo Molnar > Cc: Kees Cook > Cc: Madhavan T. Venkataraman > Cc: Paolo Bonzini > Cc: Sean Christopherson > Cc: Thomas Gleixner > Cc: Vitaly Kuznetsov > Cc: Wanpeng Li > Signed-off-by: Mickal Salan > Link: https://lore.kernel.org/r/20230505152046.6575-6-mic@digikod.net [...] > hw_cr4 = (cr4_read_shadow() & X86_CR4_MCE) | (cr4 & ~X86_CR4_MCE); > if (is_unrestricted_guest(vcpu)) > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index ffab64d08de3..a529455359ac 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -7927,11 +7927,77 @@ static unsigned long emulator_get_cr(struct x86_emulate_ctxt *ctxt, int cr) > return value; > } > > +#ifdef CONFIG_HEKI > + > +extern unsigned long cr4_pinned_mask; > + Can this be moved to a header file? > +static int heki_lock_cr(struct kvm *const kvm, const unsigned long cr, > + unsigned long pin) > +{ > + if (!pin) > + return -KVM_EINVAL; > + > + switch (cr) { > + case 0: > + /* Cf. arch/x86/kernel/cpu/common.c */ > + if (!(pin & X86_CR0_WP)) > + return -KVM_EINVAL; > + > + if ((read_cr0() & pin) != pin) > + return -KVM_EINVAL; > + > + atomic_long_or(pin, &kvm->heki_pinned_cr0); > + return 0; > + case 4: > + /* Checks for irrelevant bits. */ > + if ((pin & cr4_pinned_mask) != pin) > + return -KVM_EINVAL; > + It is enforcing the host mask on the guest, right? If the guest's set is a super set of the host's then it will get rejected. > + /* Ignores bits not present in host. */ > + pin &= __read_cr4(); > + atomic_long_or(pin, &kvm->heki_pinned_cr4); > + return 0; > + } > + return -KVM_EINVAL; > +} > + > +int heki_check_cr(const struct kvm *const kvm, const unsigned long cr, > + const unsigned long val) > +{ > + unsigned long pinned; > + > + switch (cr) { > + case 0: > + pinned = atomic_long_read(&kvm->heki_pinned_cr0); > + if ((val & pinned) != pinned) { > + pr_warn_ratelimited( > + "heki-kvm: Blocked CR0 update: 0x%lx\n", val); I think if the message contains the VM and VCPU identifier it will become more useful. Thanks, Wei. From xen-devel-bounces@lists.xenproject.org Mon May 08 21:18:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 21:18:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531923.827892 (Exim 4.92) (envelope-from ) id 1pw8Ff-0001uf-51; Mon, 08 May 2023 21:18:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531923.827892; Mon, 08 May 2023 21:18:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw8Ff-0001uY-1L; Mon, 08 May 2023 21:18:35 +0000 Received: by outflank-mailman (input) for mailman id 531923; Mon, 08 May 2023 21:18:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw8Fe-0001uS-Ch for xen-devel@lists.xenproject.org; Mon, 08 May 2023 21:18:34 +0000 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e2a80f5a-ede5-11ed-b226-6b7b168915f2; Mon, 08 May 2023 23:18:33 +0200 (CEST) Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-52c30fbccd4so4605531a12.0 for ; Mon, 08 May 2023 14:18:33 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([20.69.120.36]) by smtp.gmail.com with ESMTPSA id c35-20020a631c23000000b00513ec871c01sm6699252pgc.16.2023.05.08.14.18.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 May 2023 14:18:31 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e2a80f5a-ede5-11ed-b226-6b7b168915f2 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683580712; x=1686172712; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Z9LwMl3SaVI5b8sezFDQVcUBEvYrPsuHk5i8fgGhI70=; b=dRQ1o2a4swNAtvDeAqk3PDLdsymy1sdiyBuuLqn4CboEusFBPZexHSnnvjPJTWgSpe zCUqFQyMIf7rkb+qBz8Mtte+Vz8mQkmmq7vXnaLN5oZsrYJwtyAVg+VUGMkLrYXajkNE uIsTfxF5YT05vwcRwaMFAkIpVT0rseiBwvSF6CV34GHSdhL06ypC+eLcPa3lHEUbP+9j Cf8iip0ZU9V91tJdIE+PXW46H7ug0NcQnbIuYU/a6Y402qJ3gRakFK7jkNrp6kuVd+Zv sV+u6DrSu9+P+c77oK+FC7CesSPowOxXqDHIzVn+1/ZwY5cMU/Jeidz5CxnY/g9q8Ipg BcIg== X-Gm-Message-State: AC+VfDxieX762xRAOk/wOH6GIjUGYXkBABinObUxujFviZSMMZidKtL0 9TfMQfFBwtqHb+jRKFpTL8g= X-Google-Smtp-Source: ACHHUZ6kteuJnNZnZsRe+bisWrFQUndJSqajeCoEM2/rFLcMVskwkNxu1jPZifG3ayQwvJCBSdGnnA== X-Received: by 2002:a05:6a20:1591:b0:f0:ec64:f3de with SMTP id h17-20020a056a20159100b000f0ec64f3demr15058351pzj.25.1683580711711; Mon, 08 May 2023 14:18:31 -0700 (PDT) Date: Mon, 8 May 2023 21:18:29 +0000 From: Wei Liu To: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= Cc: Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Ingo Molnar , Kees Cook , Paolo Bonzini , Sean Christopherson , Thomas Gleixner , Vitaly Kuznetsov , Wanpeng Li , Alexander Graf , Forrest Yuan Yu , James Morris , John Andersen , Liran Alon , "Madhavan T . Venkataraman" , Marian Rotariu , Mihai =?utf-8?B?RG9uyJt1?= , =?utf-8?B?TmljdciZb3IgQ8OuyJt1?= , Rick Edgecombe , Thara Gopinath , Will Deacon , Zahra Tarkhani , =?utf-8?Q?=C8=98tefan_=C8=98icleru?= , dev@lists.cloudhypervisor.org, kvm@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, x86@kernel.org, xen-devel@lists.xenproject.org, Wei Liu Subject: Re: [PATCH v1 6/9] KVM: x86: Add Heki hypervisor support Message-ID: References: <20230505152046.6575-1-mic@digikod.net> <20230505152046.6575-7-mic@digikod.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230505152046.6575-7-mic@digikod.net> On Fri, May 05, 2023 at 05:20:43PM +0200, Mickal Salan wrote: > From: Madhavan T. Venkataraman > > Each supported hypervisor in x86 implements a struct x86_hyper_init to > define the init functions for the hypervisor. Define a new init_heki() > entry point in struct x86_hyper_init. Hypervisors that support Heki > must define this init_heki() function. Call init_heki() of the chosen > hypervisor in init_hypervisor_platform(). > > Create a heki_hypervisor structure that each hypervisor can fill > with its data and functions. This will allow the Heki feature to work > in a hypervisor agnostic way. > > Declare and initialize a "heki_hypervisor" structure for KVM so KVM can > support Heki. Define the init_heki() function for KVM. In init_heki(), > set the hypervisor field in the generic "heki" structure to the KVM > "heki_hypervisor". After this point, generic Heki code can access the > KVM Heki data and functions. > [...] > +static void kvm_init_heki(void) > +{ > + long err; > + > + if (!kvm_para_available()) > + /* Cannot make KVM hypercalls. */ > + return; > + > + err = kvm_hypercall3(KVM_HC_LOCK_MEM_PAGE_RANGES, -1, -1, -1); Why not do a proper version check or capability check here? If the ABI or supported features ever change then we have something to rely on? Thanks, Wei. From xen-devel-bounces@lists.xenproject.org Mon May 08 21:33:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 21:33:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531928.827901 (Exim 4.92) (envelope-from ) id 1pw8UE-0004JH-Bu; Mon, 08 May 2023 21:33:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531928.827901; Mon, 08 May 2023 21:33:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw8UE-0004JA-9B; Mon, 08 May 2023 21:33:38 +0000 Received: by outflank-mailman (input) for mailman id 531928; Mon, 08 May 2023 21:33:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw8UC-0004Ih-KA; Mon, 08 May 2023 21:33:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw8UC-0003MS-Ht; Mon, 08 May 2023 21:33:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pw8UC-0007l7-64; Mon, 08 May 2023 21:33:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pw8UC-0006O6-5j; Mon, 08 May 2023 21:33:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YzKdj2q9rZV8iecyJaiAQVw9XNRhMFpMLQpRfKrT5CM=; b=Uc2cmsDQECULQceSiIRF8sL0C0 scd/pb3/dYxhPnmQ1QJdSmbffLHGycM4o5L8+/Py52CPh6/+PitQHJhorkWpWYsfgIwNG0b7Fk0LS XU4eetoJeKWuoMWFsJh7vYIU2mVvMgWJmAP3oddMr15JC9jIp8P3MBSVQET2eh01kalA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 180581: all pass - PUSHED X-Osstest-Versions-This: ovmf=5215cd5baf6609e54050c69909273b7f5161c59e X-Osstest-Versions-That: ovmf=6eeb58ece38060be3b0f7111649a93cc8b2dca49 From: osstest service owner Date: Mon, 08 May 2023 21:33:36 +0000 flight 180581 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180581/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 5215cd5baf6609e54050c69909273b7f5161c59e baseline version: ovmf 6eeb58ece38060be3b0f7111649a93cc8b2dca49 Last test of basis 180579 2023-05-08 13:40:39 Z 0 days Testing same since 180581 2023-05-08 19:13:38 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Rebecca Cran jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 6eeb58ece3..5215cd5baf 5215cd5baf6609e54050c69909273b7f5161c59e -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon May 08 23:59:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 May 2023 23:59:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531940.827912 (Exim 4.92) (envelope-from ) id 1pwAl9-0001W6-JH; Mon, 08 May 2023 23:59:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531940.827912; Mon, 08 May 2023 23:59:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pwAl9-0001Vz-Ew; Mon, 08 May 2023 23:59:15 +0000 Received: by outflank-mailman (input) for mailman id 531940; Mon, 08 May 2023 23:59:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pwAl8-0001Vt-9S for xen-devel@lists.xenproject.org; Mon, 08 May 2023 23:59:14 +0000 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [2607:f8b0:4864:20::636]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 534dac68-edfc-11ed-8611-37d641c3527e; Tue, 09 May 2023 01:59:11 +0200 (CEST) Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1ab14cb3aaeso36432505ad.2 for ; Mon, 08 May 2023 16:59:11 -0700 (PDT) Received: from localhost (2603-800c-1a02-1bae-a7fa-157f-969a-4cde.res6.spectrum.com. [2603:800c:1a02:1bae:a7fa:157f:969a:4cde]) by smtp.gmail.com with ESMTPSA id t24-20020a170902b21800b001a505f04a06sm45882plr.190.2023.05.08.16.59.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 May 2023 16:59:09 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 534dac68-edfc-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683590350; x=1686182350; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=2YJeCVahMakSFFIeHkE0L5vaAYWzeS9qst+vBo++bi0=; b=TPN5cpDiUj++UaBuLClkHYKSZJQANDd2z/20VxIZVWHMxUq8xHaiESgezp9rxD7Gua kwQsYUXcUlV+z/TE10zkBILwoSSFW9HIsSnlJiytJoJy7FpjLcJSkMTQ5FwrG0ZhPqpv mNklxZ3suiwvDBCj7EVZBtRDY5IACqgNnR8WuwKVGfhpG2I7i1f+Mkf7pj595ha9os6j TJJUiDx5lGMYJli6SFP6m5BzTEv5qxMT9T42KuwnS05NEL9gk7D+TTxRe4Ne2ObBXqzJ tDju3HLcbYeZK1v2hcxZ5e6OH+eh3geSlD4uCw+dEJXNmHBvdg/GJYTwaPZT50EygaGc RMPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683590350; x=1686182350; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2YJeCVahMakSFFIeHkE0L5vaAYWzeS9qst+vBo++bi0=; b=N5CDiXqdbeTJeLyORa6q43ZQYcTEFRMLxDRKlMvDnsOILvQOXXDuvb7Wu95SRH+43y yinCKEaLaHTGixDMJ4vYrBlmh/TqfBt2ot/s6cvSh2tLGzo2OMu5y/kxURA9X8pll49e n8XO9BcabH3wO7SQB+ZHThHM69M+grJ6zmckRm8j8xDJE1znbIpt/TNkltVOEeeTCWQT 9yP2tkn0Hf+zlPvGY1bPy4pD4lWMX0wWc2M6SH3ZQ4xOkjagrvlRy23RKTkXzxov4KfW LRtzqLy2euO319cT6jFh9G9L/GQK4JylLU24wRfxpGA2/UqUUJBIuJzbpsi7ISW8e3kF FnJg== X-Gm-Message-State: AC+VfDz3aaEpPpzvPnsXWxczmI/Y1Nk0LJMq/HxsvhR5PASC6vd/ktea lbq+kGgwWDIYnlbg57bgbdY= X-Google-Smtp-Source: ACHHUZ7b+WkCZIE72n5uctblOVhF8S4nx7C/p93x2y2+UjUpxZ3gKtCgsPeB10q3QmlKSF1IQOuFjA== X-Received: by 2002:a17:902:a583:b0:1aa:f818:7a23 with SMTP id az3-20020a170902a58300b001aaf8187a23mr12371985plb.27.1683590349547; Mon, 08 May 2023 16:59:09 -0700 (PDT) Sender: Tejun Heo Date: Mon, 8 May 2023 13:59:07 -1000 From: Tejun Heo To: jiangshanlai@gmail.com Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org Subject: Re: [PATCH 15/22] xen/pvcalls: Use alloc_ordered_workqueue() to create ordered workqueues Message-ID: References: <20230421025046.4008499-1-tj@kernel.org> <20230421025046.4008499-16-tj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230421025046.4008499-16-tj@kernel.org> Applied to wq/for-6.5-cleanup-ordered. Thanks. -- tejun From xen-devel-bounces@lists.xenproject.org Tue May 09 00:51:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 May 2023 00:51:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531944.827922 (Exim 4.92) (envelope-from ) id 1pwBZV-0008QZ-F9; Tue, 09 May 2023 00:51:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531944.827922; Tue, 09 May 2023 00:51:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pwBZV-0008QS-C5; Tue, 09 May 2023 00:51:17 +0000 Received: by outflank-mailman (input) for mailman id 531944; Tue, 09 May 2023 00:51:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pwBZU-0008QM-Mt for xen-devel@lists.xenproject.org; Tue, 09 May 2023 00:51:16 +0000 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 96be2e78-ee03-11ed-b226-6b7b168915f2; Tue, 09 May 2023 02:51:12 +0200 (CEST) Received: from dggpemm500005.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4QFfh404RszpWF8; Tue, 9 May 2023 08:49:56 +0800 (CST) Received: from [10.69.30.204] (10.69.30.204) by dggpemm500005.china.huawei.com (7.185.36.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 9 May 2023 08:51:07 +0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 96be2e78-ee03-11ed-b226-6b7b168915f2 Subject: Re: [PATCH RFC 2/2] net: remove __skb_frag_set_page() To: Simon Horman CC: , , , , , , , , , , , , References: <20230508123922.39284-1-linyunsheng@huawei.com> <20230508123922.39284-3-linyunsheng@huawei.com> From: Yunsheng Lin Message-ID: Date: Tue, 9 May 2023 08:51:07 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.69.30.204] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500005.china.huawei.com (7.185.36.74) X-CFilter-Loop: Reflected On 2023/5/8 22:31, Simon Horman wrote: > On Mon, May 08, 2023 at 08:39:22PM +0800, Yunsheng Lin wrote: >> The remaining users calling __skb_frag_set_page() with >> page being NULL seems to doing defensive programming, as >> shinfo->nr_frags is already decremented, so remove them. >> >> Signed-off-by: Yunsheng Lin > > ... > >> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c >> index efaff5018af8..f3f08660ec30 100644 >> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c >> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c >> @@ -1105,7 +1105,6 @@ static u32 __bnxt_rx_agg_pages(struct bnxt *bp, >> unsigned int nr_frags; >> >> nr_frags = --shinfo->nr_frags; > > Hi Yunsheng, > > nr_frags is now unused, other than being set on the line above. > Probably this local variable can be removed. Yes, will remove that. Thanks. From xen-devel-bounces@lists.xenproject.org Tue May 09 01:26:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 May 2023 01:26:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531951.827944 (Exim 4.92) (envelope-from ) id 1pwC7D-0001wT-6W; Tue, 09 May 2023 01:26:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531951.827944; Tue, 09 May 2023 01:26:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pwC7D-0001wM-3C; Tue, 09 May 2023 01:26:07 +0000 Received: by outflank-mailman (input) for mailman id 531951; Tue, 09 May 2023 01:26:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pwC7C-0001wC-1y; Tue, 09 May 2023 01:26:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pwC7B-0007mK-Vi; Tue, 09 May 2023 01:26:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pwC7B-0008TF-Cr; Tue, 09 May 2023 01:26:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pwC7B-0003VR-CP; Tue, 09 May 2023 01:26:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=AqTehIPyTriyPxUrAkxoTYK8iEuuU/f6ysUwPTqJt8s=; b=D2YorN+tbMEd2gcndeilR97xtC RsCjDQsuXEhll3mh25osrjvmenNnHSpd9A23VDw/gozxtLg7TlW71py5hm6iF6OihVEWxrp+vJheg eCH51nX0nJBDrlEIGedNsNBKJJsfR2j6UBHfEK3yTcxFnfz4f55RGoDdPrybsta0a7+g=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 180580: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt-raw:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=a16fb78515d54be95f81c0d1c0a3a7b954a54d0a X-Osstest-Versions-That: xen=e93e635e142d45e3904efb4a05e2b3b52a708b4f From: osstest service owner Date: Tue, 09 May 2023 01:26:05 +0000 flight 180580 xen-unstable real [real] flight 180583 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180580/ http://logs.test-lab.xenproject.org/osstest/logs/180583/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-raw 7 xen-install fail pass in 180583-retest Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-raw 14 migrate-support-check fail in 180583 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180572 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 180572 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180572 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 180572 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 180572 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 180572 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 180572 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180572 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 180572 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180572 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 180572 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180572 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass version targeted for testing: xen a16fb78515d54be95f81c0d1c0a3a7b954a54d0a baseline version: xen e93e635e142d45e3904efb4a05e2b3b52a708b4f Last test of basis 180572 2023-05-08 01:53:35 Z 0 days Testing same since 180580 2023-05-08 15:37:24 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Jennifer Herbert Marek Marczykowski-Górecki jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git e93e635e14..a16fb78515 a16fb78515d54be95f81c0d1c0a3a7b954a54d0a -> master From xen-devel-bounces@lists.xenproject.org Tue May 09 06:53:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 May 2023 06:53:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531968.827954 (Exim 4.92) (envelope-from ) id 1pwHE3-0001rh-56; Tue, 09 May 2023 06:53:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531968.827954; Tue, 09 May 2023 06:53:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pwHE3-0001ra-1G; Tue, 09 May 2023 06:53:31 +0000 Received: by outflank-mailman (input) for mailman id 531968; Tue, 09 May 2023 06:53:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pwHE0-0001rP-MH for xen-devel@lists.xenproject.org; Tue, 09 May 2023 06:53:29 +0000 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [2607:f8b0:4864:20::636]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2fea2a31-ee36-11ed-8611-37d641c3527e; Tue, 09 May 2023 08:53:22 +0200 (CEST) Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1ab13da70a3so53776715ad.1 for ; Mon, 08 May 2023 23:53:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2fea2a31-ee36-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683615201; x=1686207201; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5m8y8qVVSPfQ/fcaKQsBhFMEoo/I0V1CEIhBkXCm97g=; b=gWAE6hIn1z/KtzhyKwhEGQV8g/1Wi7Hr8hS7u4tgRcT5wm+jY8ODLb4GVRG3kEJYwB lBSDyrtsfO3EkS981tYdtW7LSe/pemsc5YHLhD9cchAuHpR+p3EyQI6xGPifpmgu1Fo9 qjVSnyj0qqoytSsC130yZ2o70iK1EuAhrutHKtooZQWntIqNOZTtd5RRKJzZvfQ3TNH4 g8iAJbydiu/mW69n2yBBpUSI4d42n8WWDbxvi+ct7GWDhkwLi+RbeSqwIdRbbgP2j56n +kVQEdF8nPxU6cZ8bdNPQwJTUStqPh2g99aoiok6W9XYALVwGNEPDlpoNMf5MyUgwxWQ GXhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683615201; x=1686207201; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5m8y8qVVSPfQ/fcaKQsBhFMEoo/I0V1CEIhBkXCm97g=; b=im7jhyfq1eksz5Epn+O7vkiwvoBtcnM9ocOTXsucgHtgDsVIhYhoycjFUU4T+41T3n +PRYML9ZtIaCGlqd2JZrHwxYpFIXPh2kcgnDZ3rnzMbFiTvU78+kbkVUtAE1qWGvBjL+ ukpESEx57BadqmOW8+IdXxUuKb5BCv7RBQHURqmhJTcY0QZlhIY9gqjMSy2eKWO+EshW rxPY29ZApNhv3RghNL7futbb78TPcNq/HRDT4BOLHi6BGYArGklN0P33AfgFK5ySHKdp JB2yBFktyxRSN04yBTYJ0a6H2MJSrDsOh3kYKq7T2d+yTyiU6olCeTfEnmcM2ULZxrPJ F1Qg== X-Gm-Message-State: AC+VfDxsoqusvkAkNdIWPscy9nT0CFT2osyzL9zPXs4as2aPNQ7d7J7U vX2oKogTT4m5b5XB3xzf5w0jtc7yyvojxBrh24M= X-Google-Smtp-Source: ACHHUZ4qPRDtKPZ+fz9q/4M3Obw7XM/rNocBKNqPEIYW304IifHDbAvgqsf5n0TajM1QGdYvkX9wN64ukfe9AwJZHto= X-Received: by 2002:a17:903:1206:b0:19c:be57:9c82 with SMTP id l6-20020a170903120600b0019cbe579c82mr14881245plh.65.1683615200462; Mon, 08 May 2023 23:53:20 -0700 (PDT) MIME-Version: 1.0 References: <43f5fdaa-47c7-6ec9-c477-dac62a5bceae@amd.com> <4e859659-8532-7ba2-63b9-a06d91cb0ffc@amd.com> In-Reply-To: From: Oleg Nikitenko Date: Tue, 9 May 2023 09:58:04 +0300 Message-ID: Subject: Re: xen cache colors in ARM To: Michal Orzel Cc: Stefano Stabellini , Julien Grall , "xen-devel@lists.xenproject.org" , Bertrand Marquis , Carlo Nonato , Stewart.Hildebrand@amd.com Content-Type: multipart/alternative; boundary="000000000000f64c8c05fb3d35d5" --000000000000f64c8c05fb3d35d5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello guys, I have a couple of more questions. Have you ever run xen with the cache coloring at Zynq UltraScale+ MPSoC zcu102 xczu15eg ? When did you run xen with the cache coloring last time ? What kernel version did you use for Dom0 when you ran xen with the cache coloring last time ? Regards, Oleg =D0=BF=D1=82, 5 =D0=BC=D0=B0=D1=8F 2023=E2=80=AF=D0=B3. =D0=B2 11:48, Oleg = Nikitenko : > Hi Michal, > > Thanks. > > Regards, > Oleg > > =D0=BF=D1=82, 5 =D0=BC=D0=B0=D1=8F 2023=E2=80=AF=D0=B3. =D0=B2 11:34, Mic= hal Orzel : > >> Hi Oleg, >> >> Replying, so that you do not need to wait for Stefano. >> >> On 05/05/2023 10:28, Oleg Nikitenko wrote: >> > >> > >> > >> > Hello Stefano, >> > >> > I would like to try a xen cache color property from this repo >> https://xenbits.xen.org/git-http/xen.git < >> https://xenbits.xen.org/git-http/xen.git> >> > Could you tell whot branch I should use ? >> Cache coloring feature is not part of the upstream tree and it is still >> under review. >> You can only find it integrated in the Xilinx Xen tree. >> >> ~Michal >> >> > >> > Regards, >> > Oleg >> > >> > =D0=BF=D1=82, 28 =D0=B0=D0=BF=D1=80. 2023=E2=80=AF=D0=B3. =D0=B2 00:51= , Stefano Stabellini > >: >> > >> > I am familiar with the zcu102 but I don't know how you could >> possibly >> > generate a SError. >> > >> > I suggest to try to use ImageBuilder [1] to generate the boot >> > configuration as a test because that is known to work well for >> zcu102. >> > >> > [1] https://gitlab.com/xen-project/imagebuilder < >> https://gitlab.com/xen-project/imagebuilder> >> > >> > >> > On Thu, 27 Apr 2023, Oleg Nikitenko wrote: >> > > Hello Stefano, >> > > >> > > Thanks for clarification. >> > > We nighter use ImageBuilder nor uboot boot script. >> > > A model is zcu102 compatible. >> > > >> > > Regards, >> > > O. >> > > >> > > =D0=B2=D1=82, 25 =D0=B0=D0=BF=D1=80. 2023=E2=80=AF=D0=B3. =D0=B2= 21:21, Stefano Stabellini < >> sstabellini@kernel.org >: >> > > This is interesting. Are you using Xilinx hardware by any >> chance? If so, >> > > which board? >> > > >> > > Are you using ImageBuilder to generate your boot.scr boot >> script? If so, >> > > could you please post your ImageBuilder config file? If >> not, can you >> > > post the source of your uboot boot script? >> > > >> > > SErrors are supposed to be related to a hardware failure o= f >> some kind. >> > > You are not supposed to be able to trigger an SError easil= y >> by >> > > "mistake". I have not seen SErrors due to wrong cache >> coloring >> > > configurations on any Xilinx board before. >> > > >> > > The differences between Xen with and without cache colorin= g >> from a >> > > hardware perspective are: >> > > >> > > - With cache coloring, the SMMU is enabled and does addres= s >> translations >> > > even for dom0. Without cache coloring the SMMU could be >> disabled, and >> > > if enabled, the SMMU doesn't do any address translations >> for Dom0. If >> > > there is a hardware failure related to SMMU address >> translation it >> > > could only trigger with cache coloring. This would be my >> normal >> > > suggestion for you to explore, but the failure happens >> too early >> > > before any DMA-capable device is programmed. So I don't >> think this can >> > > be the issue. >> > > >> > > - With cache coloring, the memory allocation is very >> different so you'll >> > > end up using different DDR regions for Dom0. So if your >> DDR is >> > > defective, you might only see a failure with cache >> coloring enabled >> > > because you end up using different regions. >> > > >> > > >> > > On Tue, 25 Apr 2023, Oleg Nikitenko wrote: >> > > > Hi Stefano, >> > > > >> > > > Thank you. >> > > > If I build xen without colors support there is not this >> error. >> > > > All the domains are booted well. >> > > > Hense it can not be a hardware issue. >> > > > This panic arrived during unpacking the rootfs. >> > > > Here I attached the boot log xen/Dom0 without color. >> > > > A highlighted strings printed exactly after the place >> where 1-st time panic arrived. >> > > > >> > > > Xen 4.16.1-pre >> > > > (XEN) Xen version 4.16.1-pre (nole2390@(none)) >> (aarch64-portable-linux-gcc (GCC) 11.3.0) debug=3Dy 2023-04-21 >> > > > (XEN) Latest ChangeSet: Wed Apr 19 12:56:14 2023 +0300 >> git:321687b231-dirty >> > > > (XEN) build-id: c1847258fdb1b79562fc710dda40008f96c0fde5 >> > > > (XEN) Processor: 00000000410fd034: "ARM Limited", >> variant: 0x0, part 0xd03,rev 0x4 >> > > > (XEN) 64-bit Execution: >> > > > (XEN) Processor Features: 0000000000002222 >> 0000000000000000 >> > > > (XEN) Exception Levels: EL3:64+32 EL2:64+32 EL1:64+3= 2 >> EL0:64+32 >> > > > (XEN) Extensions: FloatingPoint AdvancedSIMD >> > > > (XEN) Debug Features: 0000000010305106 000000000000000= 0 >> > > > (XEN) Auxiliary Features: 0000000000000000 >> 0000000000000000 >> > > > (XEN) Memory Model Features: 0000000000001122 >> 0000000000000000 >> > > > (XEN) ISA Features: 0000000000011120 0000000000000000 >> > > > (XEN) 32-bit Execution: >> > > > (XEN) Processor Features: >> 0000000000000131:0000000000011011 >> > > > (XEN) Instruction Sets: AArch32 A32 Thumb Thumb-2 >> Jazelle >> > > > (XEN) Extensions: GenericTimer Security >> > > > (XEN) Debug Features: 0000000003010066 >> > > > (XEN) Auxiliary Features: 0000000000000000 >> > > > (XEN) Memory Model Features: 0000000010201105 >> 0000000040000000 >> > > > (XEN) 0000000001260000 >> 0000000002102211 >> > > > (XEN) ISA Features: 0000000002101110 0000000013112111 >> 0000000021232042 >> > > > (XEN) 0000000001112131 0000000000011142 >> 0000000000011121 >> > > > (XEN) Using SMC Calling Convention v1.2 >> > > > (XEN) Using PSCI v1.1 >> > > > (XEN) SMP: Allowing 4 CPUs >> > > > (XEN) Generic Timer IRQ: phys=3D30 hyp=3D26 virt=3D27 Fr= eq: >> 100000 KHz >> > > > (XEN) GICv2 initialization: >> > > > (XEN) gic_dist_addr=3D00000000f9010000 >> > > > (XEN) gic_cpu_addr=3D00000000f9020000 >> > > > (XEN) gic_hyp_addr=3D00000000f9040000 >> > > > (XEN) gic_vcpu_addr=3D00000000f9060000 >> > > > (XEN) gic_maintenance_irq=3D25 >> > > > (XEN) GICv2: Adjusting CPU interface base to 0xf902f000 >> > > > (XEN) GICv2: 192 lines, 4 cpus, secure (IID 0200143b). >> > > > (XEN) Using scheduler: null Scheduler (null) >> > > > (XEN) Initializing null scheduler >> > > > (XEN) WARNING: This is experimental software in >> development. >> > > > (XEN) Use at your own risk. >> > > > (XEN) Allocated console ring of 32 KiB. >> > > > (XEN) CPU0: Guest atomics will try 12 times before >> pausing the domain >> > > > (XEN) Bringing up CPU1 >> > > > (XEN) CPU1: Guest atomics will try 13 times before >> pausing the domain >> > > > (XEN) CPU 1 booted. >> > > > (XEN) Bringing up CPU2 >> > > > (XEN) CPU2: Guest atomics will try 13 times before >> pausing the domain >> > > > (XEN) CPU 2 booted. >> > > > (XEN) Bringing up CPU3 >> > > > (XEN) CPU3: Guest atomics will try 13 times before >> pausing the domain >> > > > (XEN) Brought up 4 CPUs >> > > > (XEN) CPU 3 booted. >> > > > (XEN) smmu: /axi/smmu@fd800000: probing hardware >> configuration... >> > > > (XEN) smmu: /axi/smmu@fd800000: SMMUv2 with: >> > > > (XEN) smmu: /axi/smmu@fd800000: stage 2 translation >> > > > (XEN) smmu: /axi/smmu@fd800000: stream matching with 48 >> register groups, mask 0x7fff<2>smmu: /axi/smmu@fd800000: 16 context >> > > banks (0 >> > > > stage-2 only) >> > > > (XEN) smmu: /axi/smmu@fd800000: Stage-2: 48-bit IPA -> >> 48-bit PA >> > > > (XEN) smmu: /axi/smmu@fd800000: registered 29 master >> devices >> > > > (XEN) I/O virtualisation enabled >> > > > (XEN) - Dom0 mode: Relaxed >> > > > (XEN) P2M: 40-bit IPA with 40-bit PA and 8-bit VMID >> > > > (XEN) P2M: 3 levels with order-1 root, VTCR >> 0x0000000080023558 >> > > > (XEN) Scheduling granularity: cpu, 1 CPU per >> sched-resource >> > > > (XEN) alternatives: Patching with alt table >> 00000000002cc5c8 -> 00000000002ccb2c >> > > > (XEN) *** LOADING DOMAIN 0 *** >> > > > (XEN) Loading d0 kernel from boot module @ >> 0000000001000000 >> > > > (XEN) Loading ramdisk from boot module @ 000000000200000= 0 >> > > > (XEN) Allocating 1:1 mappings totalling 1600MB for dom0: >> > > > (XEN) BANK[0] 0x00000010000000-0x00000020000000 (256MB) >> > > > (XEN) BANK[1] 0x00000024000000-0x00000028000000 (64MB) >> > > > (XEN) BANK[2] 0x00000030000000-0x00000080000000 (1280MB) >> > > > (XEN) Grant table range: 0x00000000e00000-0x00000000e400= 00 >> > > > (XEN) smmu: /axi/smmu@fd800000: d0: p2maddr >> 0x000000087bf94000 >> > > > (XEN) Allocating PPI 16 for event channel interrupt >> > > > (XEN) Extended region 0: 0x81200000->0xa0000000 >> > > > (XEN) Extended region 1: 0xb1200000->0xc0000000 >> > > > (XEN) Extended region 2: 0xc8000000->0xe0000000 >> > > > (XEN) Extended region 3: 0xf0000000->0xf9000000 >> > > > (XEN) Extended region 4: 0x100000000->0x600000000 >> > > > (XEN) Extended region 5: 0x880000000->0x8000000000 >> > > > (XEN) Extended region 6: 0x8001000000->0x10000000000 >> > > > (XEN) Loading zImage from 0000000001000000 to >> 0000000010000000-0000000010e41008 >> > > > (XEN) Loading d0 initrd from 0000000002000000 to >> 0x0000000013600000-0x000000001ff3a617 >> > > > (XEN) Loading d0 DTB to >> 0x0000000013400000-0x000000001340cbdc >> > > > (XEN) Initial low memory virq threshold set at 0x4000 >> pages. >> > > > (XEN) Std. Loglevel: All >> > > > (XEN) Guest Loglevel: All >> > > > (XEN) *** Serial input to DOM0 (type 'CTRL-a' three time= s >> to switch input) >> > > > (XEN) null.c:353: 0 <-- d0v0 >> > > > (XEN) Freed 356kB init memory. >> > > > (XEN) d0v0 Unhandled SMC/HVC: 0x84000050 >> > > > (XEN) d0v0 Unhandled SMC/HVC: 0x8600ff01 >> > > > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff >> to ICACTIVER4 >> > > > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff >> to ICACTIVER8 >> > > > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff >> to ICACTIVER12 >> > > > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff >> to ICACTIVER16 >> > > > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff >> to ICACTIVER20 >> > > > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff >> to ICACTIVER0 >> > > > [ 0.000000] Booting Linux on physical CPU 0x000000000= 0 >> [0x410fd034] >> > > > [ 0.000000] Linux version 5.15.72-xilinx-v2022.1 >> (oe-user@oe-host) (aarch64-portable-linux-gcc (GCC) 11.3.0, GNU ld (GNU >> > > Binutils) >> > > > 2.38.20220708) #1 SMP Tue Feb 21 05:47:54 UTC 2023 >> > > > [ 0.000000] Machine model: D14 Viper Board - White Un= it >> > > > [ 0.000000] Xen 4.16 support found >> > > > [ 0.000000] Zone ranges: >> > > > [ 0.000000] DMA [mem >> 0x0000000010000000-0x000000007fffffff] >> > > > [ 0.000000] DMA32 empty >> > > > [ 0.000000] Normal empty >> > > > [ 0.000000] Movable zone start for each node >> > > > [ 0.000000] Early memory node ranges >> > > > [ 0.000000] node 0: [mem >> 0x0000000010000000-0x000000001fffffff] >> > > > [ 0.000000] node 0: [mem >> 0x0000000022000000-0x0000000022147fff] >> > > > [ 0.000000] node 0: [mem >> 0x0000000022200000-0x0000000022347fff] >> > > > [ 0.000000] node 0: [mem >> 0x0000000024000000-0x0000000027ffffff] >> > > > [ 0.000000] node 0: [mem >> 0x0000000030000000-0x000000007fffffff] >> > > > [ 0.000000] Initmem setup node 0 [mem >> 0x0000000010000000-0x000000007fffffff] >> > > > [ 0.000000] On node 0, zone DMA: 8192 pages in >> unavailable ranges >> > > > [ 0.000000] On node 0, zone DMA: 184 pages in >> unavailable ranges >> > > > [ 0.000000] On node 0, zone DMA: 7352 pages in >> unavailable ranges >> > > > [ 0.000000] cma: Reserved 256 MiB at 0x000000006e0000= 00 >> > > > [ 0.000000] psci: probing for conduit method from DT. >> > > > [ 0.000000] psci: PSCIv1.1 detected in firmware. >> > > > [ 0.000000] psci: Using standard PSCI v0.2 function I= Ds >> > > > [ 0.000000] psci: Trusted OS migration not required >> > > > [ 0.000000] psci: SMC Calling Convention v1.1 >> > > > [ 0.000000] percpu: Embedded 16 pages/cpu s32792 r0 >> d32744 u65536 >> > > > [ 0.000000] Detected VIPT I-cache on CPU0 >> > > > [ 0.000000] CPU features: kernel page table isolation >> forced ON by KASLR >> > > > [ 0.000000] CPU features: detected: Kernel page table >> isolation (KPTI) >> > > > [ 0.000000] Built 1 zonelists, mobility grouping on. >> Total pages: 403845 >> > > > [ 0.000000] Kernel command line: console=3Dhvc0 >> earlycon=3Dxen earlyprintk=3Dxen clk_ignore_unused fips=3D1 root=3D/dev/= ram0 >> > > maxcpus=3D2 >> > > > [ 0.000000] Unknown kernel command line parameters >> "earlyprintk=3Dxen fips=3D1", will be passed to user space. >> > > > [ 0.000000] Dentry cache hash table entries: 262144 >> (order: 9, 2097152 bytes, linear) >> > > > [ 0.000000] Inode-cache hash table entries: 131072 >> (order: 8, 1048576 bytes, linear) >> > > > [ 0.000000] mem auto-init: stack:off, heap alloc:on, >> heap free:on >> > > > [ 0.000000] mem auto-init: clearing system memory may >> take some time... >> > > > [ 0.000000] Memory: 1121936K/1641024K available (9728= K >> kernel code, 836K rwdata, 2396K rodata, 1536K init, 262K bss, >> > > 256944K reserved, >> > > > 262144K cma-reserved) >> > > > [ 0.000000] SLUB: HWalign=3D64, Order=3D0-3, MinObjec= ts=3D0, >> CPUs=3D2, Nodes=3D1 >> > > > [ 0.000000] rcu: Hierarchical RCU implementation. >> > > > [ 0.000000] rcu: RCU event tracing is enabled. >> > > > [ 0.000000] rcu: RCU restricting CPUs from NR_CPUS=3D= 8 >> to nr_cpu_ids=3D2. >> > > > [ 0.000000] rcu: RCU calculated value of >> scheduler-enlistment delay is 25 jiffies. >> > > > [ 0.000000] rcu: Adjusting geometry for >> rcu_fanout_leaf=3D16, nr_cpu_ids=3D2 >> > > > [ 0.000000] NR_IRQS: 64, nr_irqs: 64, preallocated >> irqs: 0 >> > > > [ 0.000000] Root IRQ handler: gic_handle_irq >> > > > [ 0.000000] arch_timer: cp15 timer(s) running at >> 100.00MHz (virt). >> > > > [ 0.000000] clocksource: arch_sys_counter: mask: >> 0xffffffffffffff max_cycles: 0x171024e7e0, max_idle_ns: 440795205315 ns >> > > > [ 0.000000] sched_clock: 56 bits at 100MHz, resolutio= n >> 10ns, wraps every 4398046511100ns >> > > > [ 0.000258] Console: colour dummy device 80x25 >> > > > [ 0.310231] printk: console [hvc0] enabled >> > > > [ 0.314403] Calibrating delay loop (skipped), value >> calculated using timer frequency.. 200.00 BogoMIPS (lpj=3D400000) >> > > > [ 0.324851] pid_max: default: 32768 minimum: 301 >> > > > [ 0.329706] LSM: Security Framework initializing >> > > > [ 0.334204] Yama: becoming mindful. >> > > > [ 0.337865] Mount-cache hash table entries: 4096 >> (order: 3, 32768 bytes, linear) >> > > > [ 0.345180] Mountpoint-cache hash table entries: 4096 >> (order: 3, 32768 bytes, linear) >> > > > [ 0.354743] xen:grant_table: Grant tables using >> version 1 layout >> > > > [ 0.359132] Grant table initialized >> > > > [ 0.362664] xen:events: Using FIFO-based ABI >> > > > [ 0.366993] Xen: initializing cpu0 >> > > > [ 0.370515] rcu: Hierarchical SRCU implementation. >> > > > [ 0.375930] smp: Bringing up secondary CPUs ... >> > > > (XEN) null.c:353: 1 <-- d0v1 >> > > > (XEN) d0v1: vGICD: unhandled word write 0x000000ffffffff >> to ICACTIVER0 >> > > > [ 0.382549] Detected VIPT I-cache on CPU1 >> > > > [ 0.388712] Xen: initializing cpu1 >> > > > [ 0.388743] CPU1: Booted secondary processor >> 0x0000000001 [0x410fd034] >> > > > [ 0.388829] smp: Brought up 1 node, 2 CPUs >> > > > [ 0.406941] SMP: Total of 2 processors activated. >> > > > [ 0.411698] CPU features: detected: 32-bit EL0 Suppor= t >> > > > [ 0.416888] CPU features: detected: CRC32 instruction= s >> > > > [ 0.422121] CPU: All CPU(s) started at EL1 >> > > > [ 0.426248] alternatives: patching kernel code >> > > > [ 0.431424] devtmpfs: initialized >> > > > [ 0.441454] KASLR enabled >> > > > [ 0.441602] clocksource: jiffies: mask: 0xffffffff >> max_cycles: 0xffffffff, max_idle_ns: 7645041785100000 ns >> > > > [ 0.448321] futex hash table entries: 512 (order: 3, >> 32768 bytes, linear) >> > > > [ 0.496183] NET: Registered PF_NETLINK/PF_ROUTE >> protocol family >> > > > [ 0.498277] DMA: preallocated 256 KiB GFP_KERNEL pool >> for atomic allocations >> > > > [ 0.503772] DMA: preallocated 256 KiB >> GFP_KERNEL|GFP_DMA pool for atomic allocations >> > > > [ 0.511610] DMA: preallocated 256 KiB >> GFP_KERNEL|GFP_DMA32 pool for atomic allocations >> > > > [ 0.519478] audit: initializing netlink subsys >> (disabled) >> > > > [ 0.524985] audit: type=3D2000 audit(0.336:1): >> state=3Dinitialized audit_enabled=3D0 res=3D1 >> > > > [ 0.529169] thermal_sys: Registered thermal governor >> 'step_wise' >> > > > [ 0.533023] hw-breakpoint: found 6 breakpoint and 4 >> watchpoint registers. >> > > > [ 0.545608] ASID allocator initialised with 32768 >> entries >> > > > [ 0.551030] xen:swiotlb_xen: Warning: only able to >> allocate 4 MB for software IO TLB >> > > > [ 0.559332] software IO TLB: mapped [mem >> 0x0000000011800000-0x0000000011c00000] (4MB) >> > > > [ 0.583565] HugeTLB registered 1.00 GiB page size, >> pre-allocated 0 pages >> > > > [ 0.584721] HugeTLB registered 32.0 MiB page size, >> pre-allocated 0 pages >> > > > [ 0.591478] HugeTLB registered 2.00 MiB page size, >> pre-allocated 0 pages >> > > > [ 0.598225] HugeTLB registered 64.0 KiB page size, >> pre-allocated 0 pages >> > > > [ 0.636520] DRBG: Continuing without Jitter RNG >> > > > [ 0.737187] raid6: neonx8 gen() 2143 MB/s >> > > > [ 0.805294] raid6: neonx8 xor() 1589 MB/s >> > > > [ 0.873406] raid6: neonx4 gen() 2177 MB/s >> > > > [ 0.941499] raid6: neonx4 xor() 1556 MB/s >> > > > [ 1.009612] raid6: neonx2 gen() 2072 MB/s >> > > > [ 1.077715] raid6: neonx2 xor() 1430 MB/s >> > > > [ 1.145834] raid6: neonx1 gen() 1769 MB/s >> > > > [ 1.213935] raid6: neonx1 xor() 1214 MB/s >> > > > [ 1.282046] raid6: int64x8 gen() 1366 MB/s >> > > > [ 1.350132] raid6: int64x8 xor() 773 MB/s >> > > > [ 1.418259] raid6: int64x4 gen() 1602 MB/s >> > > > [ 1.486349] raid6: int64x4 xor() 851 MB/s >> > > > [ 1.554464] raid6: int64x2 gen() 1396 MB/s >> > > > [ 1.622561] raid6: int64x2 xor() 744 MB/s >> > > > [ 1.690687] raid6: int64x1 gen() 1033 MB/s >> > > > [ 1.758770] raid6: int64x1 xor() 517 MB/s >> > > > [ 1.758809] raid6: using algorithm neonx4 gen() 2177 >> MB/s >> > > > [ 1.762941] raid6: .... xor() 1556 MB/s, rmw enabled >> > > > [ 1.767957] raid6: using neon recovery algorithm >> > > > [ 1.772824] xen:balloon: Initialising balloon driver >> > > > [ 1.778021] iommu: Default domain type: Translated >> > > > [ 1.782584] iommu: DMA domain TLB invalidation policy= : >> strict mode >> > > > [ 1.789149] SCSI subsystem initialized >> > > > [ 1.792820] usbcore: registered new interface driver >> usbfs >> > > > [ 1.798254] usbcore: registered new interface driver >> hub >> > > > [ 1.803626] usbcore: registered new device driver usb >> > > > [ 1.808761] pps_core: LinuxPPS API ver. 1 registered >> > > > [ 1.813716] pps_core: Software ver. 5.3.6 - Copyright >> 2005-2007 Rodolfo Giometti = > >> > > > [ 1.822903] PTP clock support registered >> > > > [ 1.826893] EDAC MC: Ver: 3.0.0 >> > > > [ 1.830375] zynqmp-ipi-mbox mailbox@ff990400: >> Registered ZynqMP IPI mbox with TX/RX channels. >> > > > [ 1.838863] zynqmp-ipi-mbox mailbox@ff990600: >> Registered ZynqMP IPI mbox with TX/RX channels. >> > > > [ 1.847356] zynqmp-ipi-mbox mailbox@ff990800: >> Registered ZynqMP IPI mbox with TX/RX channels. >> > > > [ 1.855907] FPGA manager framework >> > > > [ 1.859952] clocksource: Switched to clocksource >> arch_sys_counter >> > > > [ 1.871712] NET: Registered PF_INET protocol family >> > > > [ 1.871838] IP idents hash table entries: 32768 >> (order: 6, 262144 bytes, linear) >> > > > [ 1.879392] tcp_listen_portaddr_hash hash table >> entries: 1024 (order: 2, 16384 bytes, linear) >> > > > [ 1.887078] Table-perturb hash table entries: 65536 >> (order: 6, 262144 bytes, linear) >> > > > [ 1.894846] TCP established hash table entries: 16384 >> (order: 5, 131072 bytes, linear) >> > > > [ 1.902900] TCP bind hash table entries: 16384 (order= : >> 6, 262144 bytes, linear) >> > > > [ 1.910350] TCP: Hash tables configured (established >> 16384 bind 16384) >> > > > [ 1.916778] UDP hash table entries: 1024 (order: 3, >> 32768 bytes, linear) >> > > > [ 1.923509] UDP-Lite hash table entries: 1024 (order: >> 3, 32768 bytes, linear) >> > > > [ 1.930759] NET: Registered PF_UNIX/PF_LOCAL protocol >> family >> > > > [ 1.936834] RPC: Registered named UNIX socket >> transport module. >> > > > [ 1.942342] RPC: Registered udp transport module. >> > > > [ 1.947088] RPC: Registered tcp transport module. >> > > > [ 1.951843] RPC: Registered tcp NFSv4.1 backchannel >> transport module. >> > > > [ 1.958334] PCI: CLS 0 bytes, default 64 >> > > > [ 1.962709] Trying to unpack rootfs image as >> initramfs... >> > > > [ 1.977090] workingset: timestamp_bits=3D62 max_order= =3D19 >> bucket_order=3D0 >> > > > [ 1.982863] Installing knfsd (copyright (C) 1996 >> okir@monad.swb.de ). >> > > > [ 2.021045] NET: Registered PF_ALG protocol family >> > > > [ 2.021122] xor: measuring software checksum speed >> > > > [ 2.029347] 8regs : 2366 MB/sec >> > > > [ 2.033081] 32regs : 2802 MB/sec >> > > > [ 2.038223] arm64_neon : 2320 MB/sec >> > > > [ 2.038385] xor: using function: 32regs (2802 MB/sec) >> > > > [ 2.043614] Block layer SCSI generic (bsg) driver >> version 0.4 loaded (major 247) >> > > > [ 2.050959] io scheduler mq-deadline registered >> > > > [ 2.055521] io scheduler kyber registered >> > > > [ 2.068227] xen:xen_evtchn: Event-channel device >> installed >> > > > [ 2.069281] Serial: 8250/16550 driver, 4 ports, IRQ >> sharing disabled >> > > > [ 2.076190] cacheinfo: Unable to detect cache >> hierarchy for CPU 0 >> > > > [ 2.085548] brd: module loaded >> > > > [ 2.089290] loop: module loaded >> > > > [ 2.089341] Invalid max_queues (4), will use default >> max: 2. >> > > > [ 2.094565] tun: Universal TUN/TAP device driver, 1.6 >> > > > [ 2.098655] xen_netfront: Initialising Xen virtual >> ethernet driver >> > > > [ 2.104156] usbcore: registered new interface driver >> rtl8150 >> > > > [ 2.109813] usbcore: registered new interface driver >> r8152 >> > > > [ 2.115367] usbcore: registered new interface driver >> asix >> > > > [ 2.120794] usbcore: registered new interface driver >> ax88179_178a >> > > > [ 2.126934] usbcore: registered new interface driver >> cdc_ether >> > > > [ 2.132816] usbcore: registered new interface driver >> cdc_eem >> > > > [ 2.138527] usbcore: registered new interface driver >> net1080 >> > > > [ 2.144256] usbcore: registered new interface driver >> cdc_subset >> > > > [ 2.150205] usbcore: registered new interface driver >> zaurus >> > > > [ 2.155837] usbcore: registered new interface driver >> cdc_ncm >> > > > [ 2.161550] usbcore: registered new interface driver >> r8153_ecm >> > > > [ 2.168240] usbcore: registered new interface driver >> cdc_acm >> > > > [ 2.173109] cdc_acm: USB Abstract Control Model drive= r >> for USB modems and ISDN adapters >> > > > [ 2.181358] usbcore: registered new interface driver >> uas >> > > > [ 2.186547] usbcore: registered new interface driver >> usb-storage >> > > > [ 2.192643] usbcore: registered new interface driver >> ftdi_sio >> > > > [ 2.198384] usbserial: USB Serial support registered >> for FTDI USB Serial Device >> > > > [ 2.206118] udc-core: couldn't find an available UDC = - >> added [g_mass_storage] to list of pending drivers >> > > > [ 2.215332] i2c_dev: i2c /dev entries driver >> > > > [ 2.220467] xen_wdt xen_wdt: initialized (timeout=3D6= 0s, >> nowayout=3D0) >> > > > [ 2.225923] device-mapper: uevent: version 1.0.3 >> > > > [ 2.230668] device-mapper: ioctl: 4.45.0-ioctl >> (2021-03-22) initialised: dm-devel@redhat.com > > >> > > > [ 2.239315] EDAC MC0: Giving out device to module 1 >> controller synps_ddr_controller: DEV synps_edac (INTERRUPT) >> > > > [ 2.249405] EDAC DEVICE0: Giving out device to module >> zynqmp-ocm-edac controller zynqmp_ocm: DEV >> > > ff960000.memory-controller (INTERRUPT) >> > > > [ 2.261719] sdhci: Secure Digital Host Controller >> Interface driver >> > > > [ 2.267487] sdhci: Copyright(c) Pierre Ossman >> > > > [ 2.271890] sdhci-pltfm: SDHCI platform and OF driver >> helper >> > > > [ 2.278157] ledtrig-cpu: registered to indicate >> activity on CPUs >> > > > [ 2.283816] zynqmp_firmware_probe Platform Management >> API v1.1 >> > > > [ 2.289554] zynqmp_firmware_probe Trustzone version >> v1.0 >> > > > [ 2.327875] securefw securefw: securefw probed >> > > > [ 2.328324] alg: No test for xilinx-zynqmp-aes >> (zynqmp-aes) >> > > > [ 2.332563] zynqmp_aes >> firmware:zynqmp-firmware:zynqmp-aes: AES Successfully Registered >> > > > [ 2.341183] alg: No test for xilinx-zynqmp-rsa >> (zynqmp-rsa) >> > > > [ 2.347667] remoteproc remoteproc0: >> ff9a0000.rf5ss:r5f_0 is available >> > > > [ 2.353003] remoteproc remoteproc1: >> ff9a0000.rf5ss:r5f_1 is available >> > > > [ 2.362605] fpga_manager fpga0: Xilinx ZynqMP FPGA >> Manager registered >> > > > [ 2.366540] viper-xen-proxy viper-xen-proxy: Viper Xe= n >> Proxy registered >> > > > [ 2.372525] viper-vdpp a4000000.vdpp: Device Tree >> Probing >> > > > [ 2.377778] viper-vdpp a4000000.vdpp: VDPP Version: >> 1.3.9.0 Info: 1.512.15.0 KeyLen: 32 >> > > > [ 2.386432] viper-vdpp a4000000.vdpp: Unable to >> register tamper handler. Retrying... >> > > > [ 2.394094] viper-vdpp-net a5000000.vdpp_net: Device >> Tree Probing >> > > > [ 2.399854] viper-vdpp-net a5000000.vdpp_net: Device >> registered >> > > > [ 2.405931] viper-vdpp-stat a8000000.vdpp_stat: Devic= e >> Tree Probing >> > > > [ 2.412037] viper-vdpp-stat a8000000.vdpp_stat: Build >> parameters: VTI Count: 512 Event Count: 32 >> > > > [ 2.420856] default preset >> > > > [ 2.423797] viper-vdpp-stat a8000000.vdpp_stat: Devic= e >> registered >> > > > [ 2.430054] viper-vdpp-rng ac000000.vdpp_rng: Device >> Tree Probing >> > > > [ 2.435948] viper-vdpp-rng ac000000.vdpp_rng: Device >> registered >> > > > [ 2.441976] vmcu driver init >> > > > [ 2.444922] VMCU: : (240:0) registered >> > > > [ 2.444956] In K81 Updater init >> > > > [ 2.449003] pktgen: Packet Generator for packet >> performance testing. Version: 2.75 >> > > > [ 2.468833] Initializing XFRM netlink socket >> > > > [ 2.468902] NET: Registered PF_PACKET protocol family >> > > > [ 2.472729] Bridge firewalling registered >> > > > [ 2.476785] 8021q: 802.1Q VLAN Support v1.8 >> > > > [ 2.481341] registered taskstats version 1 >> > > > [ 2.486394] Btrfs loaded, crc32c=3Dcrc32c-generic, >> zoned=3Dno, fsverity=3Dno >> > > > [ 2.503145] ff010000.serial: ttyPS1 at MMIO 0xff01000= 0 >> (irq =3D 36, base_baud =3D 6250000) is a xuartps >> > > > [ 2.507103] of-fpga-region fpga-full: FPGA Region >> probed >> > > > [ 2.512986] xilinx-zynqmp-dma fd500000.dma-controller= : >> ZynqMP DMA driver Probe success >> > > > [ 2.520267] xilinx-zynqmp-dma fd510000.dma-controller= : >> ZynqMP DMA driver Probe success >> > > > [ 2.528239] xilinx-zynqmp-dma fd520000.dma-controller= : >> ZynqMP DMA driver Probe success >> > > > [ 2.536152] xilinx-zynqmp-dma fd530000.dma-controller= : >> ZynqMP DMA driver Probe success >> > > > [ 2.544153] xilinx-zynqmp-dma fd540000.dma-controller= : >> ZynqMP DMA driver Probe success >> > > > [ 2.552127] xilinx-zynqmp-dma fd550000.dma-controller= : >> ZynqMP DMA driver Probe success >> > > > [ 2.560178] xilinx-zynqmp-dma ffa80000.dma-controller= : >> ZynqMP DMA driver Probe success >> > > > [ 2.567987] xilinx-zynqmp-dma ffa90000.dma-controller= : >> ZynqMP DMA driver Probe success >> > > > [ 2.576018] xilinx-zynqmp-dma ffaa0000.dma-controller= : >> ZynqMP DMA driver Probe success >> > > > [ 2.583889] xilinx-zynqmp-dma ffab0000.dma-controller= : >> ZynqMP DMA driver Probe success >> > > > [ 2.946379] spi-nor spi0.0: mt25qu512a (131072 Kbytes= ) >> > > > [ 2.946467] 2 fixed-partitions partitions found on MT= D >> device spi0.0 >> > > > [ 2.952393] Creating 2 MTD partitions on "spi0.0": >> > > > [ 2.957231] 0x000004000000-0x000008000000 : "bank A" >> > > > [ 2.963332] 0x000000000000-0x000004000000 : "bank B" >> > > > [ 2.968694] macb ff0b0000.ethernet: Not enabling >> partial store and forward >> > > > [ 2.975333] macb ff0b0000.ethernet eth0: Cadence GEM >> rev 0x50070106 at 0xff0b0000 irq 25 (18:41:fe:0f:ff:02) >> > > > [ 2.984472] macb ff0c0000.ethernet: Not enabling >> partial store and forward >> > > > [ 2.992144] macb ff0c0000.ethernet eth1: Cadence GEM >> rev 0x50070106 at 0xff0c0000 irq 26 (18:41:fe:0f:ff:03) >> > > > [ 3.001043] viper_enet viper_enet: Viper power GPIOs >> initialised >> > > > [ 3.007313] viper_enet viper_enet vnet0 >> (uninitialized): Validate interface QSGMII >> > > > [ 3.014914] viper_enet viper_enet vnet1 >> (uninitialized): Validate interface QSGMII >> > > > [ 3.022138] viper_enet viper_enet vnet1 >> (uninitialized): Validate interface type 18 >> > > > [ 3.030274] viper_enet viper_enet vnet2 >> (uninitialized): Validate interface QSGMII >> > > > [ 3.037785] viper_enet viper_enet vnet3 >> (uninitialized): Validate interface QSGMII >> > > > [ 3.045301] viper_enet viper_enet: Viper enet >> registered >> > > > [ 3.050958] xilinx-axipmon ffa00000.perf-monitor: >> Probed Xilinx APM >> > > > [ 3.057135] xilinx-axipmon fd0b0000.perf-monitor: >> Probed Xilinx APM >> > > > [ 3.063538] xilinx-axipmon fd490000.perf-monitor: >> Probed Xilinx APM >> > > > [ 3.069920] xilinx-axipmon ffa10000.perf-monitor: >> Probed Xilinx APM >> > > > [ 3.097729] si70xx: probe of 2-0040 failed with error >> -5 >> > > > [ 3.098042] cdns-wdt fd4d0000.watchdog: Xilinx >> Watchdog Timer with timeout 60s >> > > > [ 3.105111] cdns-wdt ff150000.watchdog: Xilinx >> Watchdog Timer with timeout 10s >> > > > [ 3.112457] viper-tamper viper-tamper: Device >> registered >> > > > [ 3.117593] active_bank active_bank: boot bank: 1 >> > > > [ 3.122184] active_bank active_bank: boot mode: (0x02= ) >> qspi32 >> > > > [ 3.128247] viper-vdpp a4000000.vdpp: Device Tree >> Probing >> > > > [ 3.133439] viper-vdpp a4000000.vdpp: VDPP Version: >> 1.3.9.0 Info: 1.512.15.0 KeyLen: 32 >> > > > [ 3.142151] viper-vdpp a4000000.vdpp: Tamper handler >> registered >> > > > [ 3.147438] viper-vdpp a4000000.vdpp: Device register= ed >> > > > [ 3.153007] lpc55_l2 spi1.0: registered handler for >> protocol 0 >> > > > [ 3.158582] lpc55_user lpc55_user: The major number >> for your device is 236 >> > > > [ 3.165976] lpc55_l2 spi1.0: registered handler for >> protocol 1 >> > > > [ 3.181999] rtc-lpc55 rtc_lpc55: lpc55_rtc_get_time: >> bad result: 1 >> > > > [ 3.182856] rtc-lpc55 rtc_lpc55: registered as rtc0 >> > > > [ 3.188656] lpc55_l2 spi1.0: (2) mcu still not ready? >> > > > [ 3.193744] lpc55_l2 spi1.0: (3) mcu still not ready? >> > > > [ 3.198848] lpc55_l2 spi1.0: (4) mcu still not ready? >> > > > [ 3.202932] mmc0: SDHCI controller on ff160000.mmc >> [ff160000.mmc] using ADMA 64-bit >> > > > [ 3.210689] lpc55_l2 spi1.0: (5) mcu still not ready? >> > > > [ 3.215694] lpc55_l2 spi1.0: rx error: -110 >> > > > [ 3.284438] mmc0: new HS200 MMC card at address 0001 >> > > > [ 3.285179] mmcblk0: mmc0:0001 SEM16G 14.6 GiB >> > > > [ 3.291784] mmcblk0: p1 p2 p3 p4 p5 p6 p7 p8 >> > > > [ 3.293915] mmcblk0boot0: mmc0:0001 SEM16G 4.00 MiB >> > > > [ 3.299054] mmcblk0boot1: mmc0:0001 SEM16G 4.00 MiB >> > > > [ 3.303905] mmcblk0rpmb: mmc0:0001 SEM16G 4.00 MiB, >> chardev (244:0) >> > > > [ 3.582676] rtc-lpc55 rtc_lpc55: lpc55_rtc_get_time: >> bad result: 1 >> > > > [ 3.583332] rtc-lpc55 rtc_lpc55: hctosys: unable to >> read the hardware clock >> > > > [ 3.591252] cdns-i2c ff020000.i2c: recovery >> information complete >> > > > [ 3.597085] at24 0-0050: supply vcc not found, using >> dummy regulator >> > > > [ 3.603011] lpc55_l2 spi1.0: (2) mcu still not ready? >> > > > [ 3.608093] at24 0-0050: 256 byte spd EEPROM, read-on= ly >> > > > [ 3.613620] lpc55_l2 spi1.0: (3) mcu still not ready? >> > > > [ 3.619362] lpc55_l2 spi1.0: (4) mcu still not ready? >> > > > [ 3.624224] rtc-rv3028 0-0052: registered as rtc1 >> > > > [ 3.628343] lpc55_l2 spi1.0: (5) mcu still not ready? >> > > > [ 3.633253] lpc55_l2 spi1.0: rx error: -110 >> > > > [ 3.639104] k81_bootloader 0-0010: probe >> > > > [ 3.641628] VMCU: : (235:0) registered >> > > > [ 3.641635] k81_bootloader 0-0010: probe completed >> > > > [ 3.668346] cdns-i2c ff020000.i2c: 400 kHz mmio >> ff020000 irq 28 >> > > > [ 3.669154] cdns-i2c ff030000.i2c: recovery >> information complete >> > > > [ 3.675412] lm75 1-0048: supply vs not found, using >> dummy regulator >> > > > [ 3.682920] lm75 1-0048: hwmon1: sensor 'tmp112' >> > > > [ 3.686548] i2c i2c-1: Added multiplexed i2c bus 3 >> > > > [ 3.690795] i2c i2c-1: Added multiplexed i2c bus 4 >> > > > [ 3.695629] i2c i2c-1: Added multiplexed i2c bus 5 >> > > > [ 3.700492] i2c i2c-1: Added multiplexed i2c bus 6 >> > > > [ 3.705157] pca954x 1-0070: registered 4 multiplexed >> busses for I2C switch pca9546 >> > > > [ 3.713049] at24 1-0054: supply vcc not found, using >> dummy regulator >> > > > [ 3.720067] at24 1-0054: 1024 byte 24c08 EEPROM, >> read-only >> > > > [ 3.724761] cdns-i2c ff030000.i2c: 100 kHz mmio >> ff030000 irq 29 >> > > > [ 3.731272] sfp viper_enet:sfp-eth1: Host maximum >> power 2.0W >> > > > [ 3.737549] sfp_register_socket: got sfp_bus >> > > > [ 3.740709] sfp_register_socket: register sfp_bus >> > > > [ 3.745459] sfp_register_bus: ops ok! >> > > > [ 3.749179] sfp_register_bus: Try to attach >> > > > [ 3.753419] sfp_register_bus: Attach succeeded >> > > > [ 3.757914] sfp_register_bus: upstream ops attach >> > > > [ 3.762677] sfp_register_bus: Bus registered >> > > > [ 3.766999] sfp_register_socket: register sfp_bus >> succeeded >> > > > [ 3.775870] of_cfs_init >> > > > [ 3.776000] of_cfs_init: OK >> > > > [ 3.778211] clk: Not disabling unused clocks >> > > > [ 11.278477] Freeing initrd memory: 206056K >> > > > [ 11.279406] Freeing unused kernel memory: 1536K >> > > > [ 11.314006] Checked W+X mappings: passed, no W+X page= s >> found >> > > > [ 11.314142] Run /init as init process >> > > > INIT: version 3.01 booting >> > > > fsck (busybox 1.35.0) >> > > > /dev/mmcblk0p1: clean, 12/102400 files, 238162/409600 >> blocks >> > > > /dev/mmcblk0p2: clean, 12/102400 files, 171972/409600 >> blocks >> > > > /dev/mmcblk0p3 was not cleanly unmounted, check forced. >> > > > /dev/mmcblk0p3: 20/4096 files (0.0% non-contiguous), >> 663/16384 blocks >> > > > [ 11.553073] EXT4-fs (mmcblk0p3): mounted filesystem >> without journal. Opts: (null). Quota mode: disabled. >> > > > Starting random number generator daemon. >> > > > [ 11.580662] random: crng init done >> > > > Starting udev >> > > > [ 11.613159] udevd[142]: starting version 3.2.10 >> > > > [ 11.620385] udevd[143]: starting eudev-3.2.10 >> > > > [ 11.704481] macb ff0b0000.ethernet control_red: >> renamed from eth0 >> > > > [ 11.720264] macb ff0c0000.ethernet control_black: >> renamed from eth1 >> > > > [ 12.063396] ip_local_port_range: prefer different >> parity for start/end values. >> > > > [ 12.084801] rtc-lpc55 rtc_lpc55: lpc55_rtc_get_time: >> bad result: 1 >> > > > hwclock: RTC_RD_TIME: Invalid exchange >> > > > Mon Feb 27 08:40:53 UTC 2023 >> > > > [ 12.115309] rtc-lpc55 rtc_lpc55: lpc55_rtc_set_time: >> bad result >> > > > hwclock: RTC_SET_TIME: Invalid exchange >> > > > [ 12.131027] rtc-lpc55 rtc_lpc55: lpc55_rtc_get_time: >> bad result: 1 >> > > > Starting mcud >> > > > INIT: Entering runlevel: 5 >> > > > Configuring network interfaces... done. >> > > > resetting network interface >> > > > [ 12.718295] macb ff0b0000.ethernet control_red: PHY >> [ff0b0000.ethernet-ffffffff:02] driver [Xilinx PCS/PMA PHY] (irq=3DPOLL) >> > > > [ 12.723919] macb ff0b0000.ethernet control_red: >> configuring for phy/gmii link mode >> > > > [ 12.732151] pps pps0: new PPS source ptp0 >> > > > [ 12.735563] macb ff0b0000.ethernet: gem-ptp-timer ptp >> clock registered. >> > > > [ 12.745724] macb ff0c0000.ethernet control_black: PHY >> [ff0c0000.ethernet-ffffffff:01] driver [Xilinx PCS/PMA PHY] >> > > (irq=3DPOLL) >> > > > [ 12.753469] macb ff0c0000.ethernet control_black: >> configuring for phy/gmii link mode >> > > > [ 12.761804] pps pps1: new PPS source ptp1 >> > > > [ 12.765398] macb ff0c0000.ethernet: gem-ptp-timer ptp >> clock registered. >> > > > Auto-negotiation: off >> > > > Auto-negotiation: off >> > > > [ 16.828151] macb ff0b0000.ethernet control_red: unabl= e >> to generate target frequency: 125000000 Hz >> > > > [ 16.834553] macb ff0b0000.ethernet control_red: Link >> is Up - 1Gbps/Full - flow control off >> > > > [ 16.860552] macb ff0c0000.ethernet control_black: >> unable to generate target frequency: 125000000 Hz >> > > > [ 16.867052] macb ff0c0000.ethernet control_black: Lin= k >> is Up - 1Gbps/Full - flow control off >> > > > Starting Failsafe Secure Shell server in port 2222: sshd >> > > > done. >> > > > Starting rpcbind daemon...done. >> > > > >> > > > [ 17.093019] rtc-lpc55 rtc_lpc55: lpc55_rtc_get_time: >> bad result: 1 >> > > > hwclock: RTC_RD_TIME: Invalid exchange >> > > > Starting State Manager Service >> > > > Start state-manager restarter... >> > > > (XEN) d0v1 Forwarding AES operation: 3254779951 >> > > > Starting /usr/sbin/xenstored....[ 17.265256] BTRFS: >> device fsid 80efc224-c202-4f8e-a949-4dae7f04a0aa devid 1 transid 744 >> > > /dev/dm-0 >> > > > scanned by udevd (385) >> > > > [ 17.349933] BTRFS info (device dm-0): disk space >> caching is enabled >> > > > [ 17.350670] BTRFS info (device dm-0): has skinny >> extents >> > > > [ 17.364384] BTRFS info (device dm-0): enabling ssd >> optimizations >> > > > [ 17.830462] BTRFS: device fsid >> 27ff666b-f4e5-4f90-9054-c210db5b2e2e devid 1 transid 6 >> /dev/mapper/client_prov scanned by >> > > mkfs.btrfs >> > > > (526) >> > > > [ 17.872699] BTRFS info (device dm-1): using free spac= e >> tree >> > > > [ 17.872771] BTRFS info (device dm-1): has skinny >> extents >> > > > [ 17.878114] BTRFS info (device dm-1): flagging fs wit= h >> big metadata feature >> > > > [ 17.894289] BTRFS info (device dm-1): enabling ssd >> optimizations >> > > > [ 17.895695] BTRFS info (device dm-1): checking UUID >> tree >> > > > >> > > > Setting domain 0 name, domid and JSON config... >> > > > Done setting up Dom0 >> > > > Starting xenconsoled... >> > > > Starting QEMU as disk backend for dom0 >> > > > Starting domain watchdog daemon: xenwatchdogd startup >> > > > >> > > > [ 18.408647] BTRFS: device fsid >> 5e08d5e9-bc2a-46b9-af6a-44c7087b8921 devid 1 transid 6 >> /dev/mapper/client_config scanned by >> > > mkfs.btrfs >> > > > (574) >> > > > [done] >> > > > [ 18.465552] BTRFS info (device dm-2): using free spac= e >> tree >> > > > [ 18.465629] BTRFS info (device dm-2): has skinny >> extents >> > > > [ 18.471002] BTRFS info (device dm-2): flagging fs wit= h >> big metadata feature >> > > > Starting crond: [ 18.482371] BTRFS info (device dm-2): >> enabling ssd optimizations >> > > > [ 18.486659] BTRFS info (device dm-2): checking UUID >> tree >> > > > OK >> > > > starting rsyslogd ... Log partition ready after 0 poll >> loops >> > > > done >> > > > rsyslogd: cannot connect to 172.18.0.1:514 < >> http://172.18.0.1:514>: Network is unreachable [v8.2208.0 try >> https://www.rsyslog.com/e/2027 ] >> > > > [ 18.670637] BTRFS: device fsid >> 39d7d9e1-967d-478e-94ae-690deb722095 devid 1 transid 608 /dev/dm-3 scann= ed >> by udevd (518) >> > > > >> > > > Please insert USB token and enter your role in login >> prompt. >> > > > >> > > > login: >> > > > >> > > > Regards, >> > > > O. >> > > > >> > > > >> > > > =D0=BF=D0=BD, 24 =D0=B0=D0=BF=D1=80. 2023=E2=80=AF=D0=B3= . =D0=B2 23:39, Stefano Stabellini < >> sstabellini@kernel.org >: >> > > > Hi Oleg, >> > > > >> > > > Here is the issue from your logs: >> > > > >> > > > SError Interrupt on CPU0, code 0xbe000000 -- SErro= r >> > > > >> > > > SErrors are special signals to notify software of >> serious hardware >> > > > errors. Something is going very wrong. Defective >> hardware is a >> > > > possibility. Another possibility if software >> accessing address ranges >> > > > that it is not supposed to, sometimes it causes >> SErrors. >> > > > >> > > > Cheers, >> > > > >> > > > Stefano >> > > > >> > > > >> > > > >> > > > On Mon, 24 Apr 2023, Oleg Nikitenko wrote: >> > > > >> > > > > Hello, >> > > > > >> > > > > Thanks guys. >> > > > > I found out where the problem was. >> > > > > Now dom0 booted more. But I have a new one. >> > > > > This is a kernel panic during Dom0 loading. >> > > > > Maybe someone is able to suggest something ? >> > > > > >> > > > > Regards, >> > > > > O. >> > > > > >> > > > > [ 3.771362] sfp_register_bus: upstream ops >> attach >> > > > > [ 3.776119] sfp_register_bus: Bus registered >> > > > > [ 3.780459] sfp_register_socket: register >> sfp_bus succeeded >> > > > > [ 3.789399] of_cfs_init >> > > > > [ 3.789499] of_cfs_init: OK >> > > > > [ 3.791685] clk: Not disabling unused clocks >> > > > > [ 11.010355] SError Interrupt on CPU0, code >> 0xbe000000 -- SError >> > > > > [ 11.010380] CPU: 0 PID: 9 Comm: kworker/u4:0 >> Not tainted 5.15.72-xilinx-v2022.1 #1 >> > > > > [ 11.010393] Workqueue: events_unbound >> async_run_entry_fn >> > > > > [ 11.010414] pstate: 60000005 (nZCv daif -PAN >> -UAO -TCO -DIT -SSBS BTYPE=3D--) >> > > > > [ 11.010422] pc : simple_write_end+0xd0/0x130 >> > > > > [ 11.010431] lr : >> generic_perform_write+0x118/0x1e0 >> > > > > [ 11.010438] sp : ffffffc00809b910 >> > > > > [ 11.010441] x29: ffffffc00809b910 x28: >> 0000000000000000 x27: ffffffef69ba88c0 >> > > > > [ 11.010451] x26: 0000000000003eec x25: >> ffffff807515db00 x24: 0000000000000000 >> > > > > [ 11.010459] x23: ffffffc00809ba90 x22: >> 0000000002aac000 x21: ffffff807315a260 >> > > > > [ 11.010472] x20: 0000000000001000 x19: >> fffffffe02000000 x18: 0000000000000000 >> > > > > [ 11.010481] x17: 00000000ffffffff x16: >> 0000000000008000 x15: 0000000000000000 >> > > > > [ 11.010490] x14: 0000000000000000 x13: >> 0000000000000000 x12: 0000000000000000 >> > > > > [ 11.010498] x11: 0000000000000000 x10: >> 0000000000000000 x9 : 0000000000000000 >> > > > > [ 11.010507] x8 : 0000000000000000 x7 : >> ffffffef693ba680 x6 : 000000002d89b700 >> > > > > [ 11.010515] x5 : fffffffe02000000 x4 : >> ffffff807315a3c8 x3 : 0000000000001000 >> > > > > [ 11.010524] x2 : 0000000002aab000 x1 : >> 0000000000000001 x0 : 0000000000000005 >> > > > > [ 11.010534] Kernel panic - not syncing: >> Asynchronous SError Interrupt >> > > > > [ 11.010539] CPU: 0 PID: 9 Comm: kworker/u4:0 >> Not tainted 5.15.72-xilinx-v2022.1 #1 >> > > > > [ 11.010545] Hardware name: D14 Viper Board - >> White Unit (DT) >> > > > > [ 11.010548] Workqueue: events_unbound >> async_run_entry_fn >> > > > > [ 11.010556] Call trace: >> > > > > [ 11.010558] dump_backtrace+0x0/0x1c4 >> > > > > [ 11.010567] show_stack+0x18/0x2c >> > > > > [ 11.010574] dump_stack_lvl+0x7c/0xa0 >> > > > > [ 11.010583] dump_stack+0x18/0x34 >> > > > > [ 11.010588] panic+0x14c/0x2f8 >> > > > > [ 11.010597] print_tainted+0x0/0xb0 >> > > > > [ 11.010606] arm64_serror_panic+0x6c/0x7c >> > > > > [ 11.010614] do_serror+0x28/0x60 >> > > > > [ 11.010621] el1h_64_error_handler+0x30/0x50 >> > > > > [ 11.010628] el1h_64_error+0x78/0x7c >> > > > > [ 11.010633] simple_write_end+0xd0/0x130 >> > > > > [ 11.010639] generic_perform_write+0x118/0x1e= 0 >> > > > > [ 11.010644] >> __generic_file_write_iter+0x138/0x1c4 >> > > > > [ 11.010650] generic_file_write_iter+0x78/0xd= 0 >> > > > > [ 11.010656] __kernel_write+0xfc/0x2ac >> > > > > [ 11.010665] kernel_write+0x88/0x160 >> > > > > [ 11.010673] xwrite+0x44/0x94 >> > > > > [ 11.010680] do_copy+0xa8/0x104 >> > > > > [ 11.010686] write_buffer+0x38/0x58 >> > > > > [ 11.010692] flush_buffer+0x4c/0xbc >> > > > > [ 11.010698] __gunzip+0x280/0x310 >> > > > > [ 11.010704] gunzip+0x1c/0x28 >> > > > > [ 11.010709] unpack_to_rootfs+0x170/0x2b0 >> > > > > [ 11.010715] do_populate_rootfs+0x80/0x164 >> > > > > [ 11.010722] async_run_entry_fn+0x48/0x164 >> > > > > [ 11.010728] process_one_work+0x1e4/0x3a0 >> > > > > [ 11.010736] worker_thread+0x7c/0x4c0 >> > > > > [ 11.010743] kthread+0x120/0x130 >> > > > > [ 11.010750] ret_from_fork+0x10/0x20 >> > > > > [ 11.010757] SMP: stopping secondary CPUs >> > > > > [ 11.010784] Kernel Offset: 0x2f61200000 from >> 0xffffffc008000000 >> > > > > [ 11.010788] PHYS_OFFSET: 0x0 >> > > > > [ 11.010790] CPU features: 0x00000401,00000842 >> > > > > [ 11.010795] Memory Limit: none >> > > > > [ 11.277509] ---[ end Kernel panic - not >> syncing: Asynchronous SError Interrupt ]--- >> > > > > >> > > > > =D0=BF=D1=82, 21 =D0=B0=D0=BF=D1=80. 2023=E2=80= =AF=D0=B3. =D0=B2 15:52, Michal Orzel < >> michal.orzel@amd.com >: >> > > > > Hi Oleg, >> > > > > >> > > > > On 21/04/2023 14:49, Oleg Nikitenko wrote: >> > > > > > >> > > > > > >> > > > > > >> > > > > > Hello Michal, >> > > > > > >> > > > > > I was not able to enable earlyprintk in >> the xen for now. >> > > > > > I decided to choose another way. >> > > > > > This is a xen's command line that I foun= d >> out completely. >> > > > > > >> > > > > > (XEN) $$$$ console=3Ddtuart dtuart=3Dser= ial0 >> dom0_mem=3D1600M dom0_max_vcpus=3D2 dom0_vcpus_pin bootscrub=3D0 >> > > vwfi=3Dnative >> > > > sched=3Dnull >> > > > > timer_slop=3D0 >> > > > > Yes, adding a printk() in Xen was also a >> good idea. >> > > > > >> > > > > > >> > > > > > So you are absolutely right about a >> command line. >> > > > > > Now I am going to find out why xen did >> not have the correct parameters from the device tree. >> > > > > Maybe you will find this document helpful: >> > > > > >> https://github.com/Xilinx/xen/blob/xlnx_rebase_4.16/docs/misc/arm/device= -tree/booting.txt >> < >> https://github.com/Xilinx/xen/blob/xlnx_rebase_4.16/docs/misc/arm/device= -tree/booting.txt >> > >> > > > > >> > > > > ~Michal >> > > > > >> > > > > > >> > > > > > Regards, >> > > > > > Oleg >> > > > > > >> > > > > > =D0=BF=D1=82, 21 =D0=B0=D0=BF=D1=80. 202= 3=E2=80=AF=D0=B3. =D0=B2 11:16, Michal Orzel >> > michal.orzel@amd.com >>: >> > > > > > >> > > > > > >> > > > > > On 21/04/2023 10:04, Oleg Nikitenko >> wrote: >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > Hello Michal, >> > > > > > > >> > > > > > > Yes, I use yocto. >> > > > > > > >> > > > > > > Yesterday all day long I tried to >> follow your suggestions. >> > > > > > > I faced a problem. >> > > > > > > Manually in the xen config build >> file I pasted the strings: >> > > > > > In the .config file or in some Yocto >> file (listing additional Kconfig options) added to SRC_URI? >> > > > > > You shouldn't really modify .config >> file but if you do, you should execute "make olddefconfig" >> > > afterwards. >> > > > > > >> > > > > > > >> > > > > > > CONFIG_EARLY_PRINTK >> > > > > > > CONFIG_EARLY_PRINTK_ZYNQMP >> > > > > > > CONFIG_EARLY_UART_CHOICE_CADENCE >> > > > > > I hope you added =3Dy to them. >> > > > > > >> > > > > > Anyway, you have at least the >> following solutions: >> > > > > > 1) Run bitbake xen -c menuconfig to >> properly set early printk >> > > > > > 2) Find out how you enable other >> Kconfig options in your project (e.g. CONFIG_COLORING=3Dy that is not >> > > enabled by >> > > > default) >> > > > > > 3) Append the following to >> "xen/arch/arm/configs/arm64_defconfig": >> > > > > > CONFIG_EARLY_PRINTK_ZYNQMP=3Dy >> > > > > > >> > > > > > ~Michal >> > > > > > >> > > > > > > >> > > > > > > Host hangs in build time. >> > > > > > > Maybe I did not set something in >> the config build file ? >> > > > > > > >> > > > > > > Regards, >> > > > > > > Oleg >> > > > > > > >> > > > > > > =D1=87=D1=82, 20 =D0=B0=D0=BF=D1= =80. 2023=E2=80=AF=D0=B3. =D0=B2 11:57, Oleg >> Nikitenko > oleshiiwood@gmail.com > >> > > > > > oleshiiwood@gmail.com> > oleshiiwood@gmail.com>>>>: >> > > > > > > >> > > > > > > Thanks Michal, >> > > > > > > >> > > > > > > You gave me an idea. >> > > > > > > I am going to try it today. >> > > > > > > >> > > > > > > Regards, >> > > > > > > O. >> > > > > > > >> > > > > > > =D1=87=D1=82, 20 =D0=B0=D0=BF= =D1=80. 2023=E2=80=AF=D0=B3. =D0=B2 11:56, >> Oleg Nikitenko >> > >> > > > > > oleshiiwood@gmail.com> > oleshiiwood@gmail.com>>>>: >> > > > > > > >> > > > > > > Thanks Stefano. >> > > > > > > >> > > > > > > I am going to do it today. >> > > > > > > >> > > > > > > Regards, >> > > > > > > O. >> > > > > > > >> > > > > > > =D1=81=D1=80, 19 =D0=B0=D0= =BF=D1=80. 2023=E2=80=AF=D0=B3. =D0=B2 >> 23:05, Stefano Stabellini > sstabellini@kernel.org> >> > > > sstabellini@kernel.org>> >> > > > > > sstabellini@kernel.org> > sstabellini@kernel.org>>>>: >> > > > > > > >> > > > > > > On Wed, 19 Apr 2023, >> Oleg Nikitenko wrote: >> > > > > > > > Hi Michal, >> > > > > > > > >> > > > > > > > I corrected xen's >> command line. >> > > > > > > > Now it is >> > > > > > > > xen,xen-bootargs =3D >> "console=3Ddtuart dtuart=3Dserial0 dom0_mem=3D1600M dom0_max_vcpus=3D2 >> > > dom0_vcpus_pin >> > > > > bootscrub=3D0 vwfi=3Dnative sched=3Dnull >> > > > > > > > timer_slop=3D0 >> way_size=3D65536 xen_colors=3D0-3 dom0_colors=3D4-7"; >> > > > > > > >> > > > > > > 4 colors is way too >> many for xen, just do xen_colors=3D0-0. There is no >> > > > > > > advantage in using mor= e >> than 1 color for Xen. >> > > > > > > >> > > > > > > 4 colors is too few fo= r >> dom0, if you are giving 1600M of memory to Dom0. >> > > > > > > Each color is 256M. Fo= r >> 1600M you should give at least 7 colors. Try: >> > > > > > > >> > > > > > > xen_colors=3D0-0 >> dom0_colors=3D1-8 >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > > Unfortunately the >> result was the same. >> > > > > > > > >> > > > > > > > (XEN) - Dom0 mode: >> Relaxed >> > > > > > > > (XEN) P2M: 40-bit IP= A >> with 40-bit PA and 8-bit VMID >> > > > > > > > (XEN) P2M: 3 levels >> with order-1 root, VTCR 0x0000000080023558 >> > > > > > > > (XEN) Scheduling >> granularity: cpu, 1 CPU per sched-resource >> > > > > > > > (XEN) Coloring >> general information >> > > > > > > > (XEN) Way size: 64kB >> > > > > > > > (XEN) Max. number of >> colors available: 16 >> > > > > > > > (XEN) Xen color(s): = [ >> 0 ] >> > > > > > > > (XEN) alternatives: >> Patching with alt table 00000000002cc690 -> 00000000002ccc0c >> > > > > > > > (XEN) Color array >> allocation failed for dom0 >> > > > > > > > (XEN) >> > > > > > > > (XEN) >> **************************************** >> > > > > > > > (XEN) Panic on CPU 0= : >> > > > > > > > (XEN) Error creating >> domain 0 >> > > > > > > > (XEN) >> **************************************** >> > > > > > > > (XEN) >> > > > > > > > (XEN) Reboot in five >> seconds... >> > > > > > > > >> > > > > > > > I am going to find >> out how command line arguments passed and parsed. >> > > > > > > > >> > > > > > > > Regards, >> > > > > > > > Oleg >> > > > > > > > >> > > > > > > > =D1=81=D1=80, 19 =D0= =B0=D0=BF=D1=80. 2023=E2=80=AF=D0=B3. =D0=B2 >> 11:25, Oleg Nikitenko > oleshiiwood@gmail.com> >> > > > >> >> > > > > > oleshiiwood@gmail.com> > oleshiiwood@gmail.com>>>>: >> > > > > > > > Hi Michal, >> > > > > > > > >> > > > > > > > You put my nose into >> the problem. Thank you. >> > > > > > > > I am going to use >> your point. >> > > > > > > > Let's see what >> happens. >> > > > > > > > >> > > > > > > > Regards, >> > > > > > > > Oleg >> > > > > > > > >> > > > > > > > >> > > > > > > > =D1=81=D1=80, 19 =D0= =B0=D0=BF=D1=80. 2023=E2=80=AF=D0=B3. =D0=B2 >> 10:37, Michal Orzel >> > > = > >> > > > > > michal.orzel@amd.com> > michal.orzel@amd.com>>>>: >> > > > > > > > Hi Oleg, >> > > > > > > > >> > > > > > > > On 19/04/2023 >> 09:03, Oleg Nikitenko wrote: >> > > > > > > > > >> > > > > > > > > >> > > > > > > > > >> > > > > > > > > Hello Stefan= o, >> > > > > > > > > >> > > > > > > > > Thanks for >> the clarification. >> > > > > > > > > My company >> uses yocto for image generation. >> > > > > > > > > What kind of >> information do you need to consult me in this case ? >> > > > > > > > > >> > > > > > > > > Maybe module= s >> sizes/addresses which were mentioned by @Julien Grall >> > > > >> > > > > > julien@xen.org>> > julien@xen.org >>> ? >> > > > > > > > >> > > > > > > > Sorry for >> jumping into discussion, but FWICS the Xen command line you provided >> > > seems to be >> > > > not the >> > > > > one >> > > > > > > > Xen booted >> with. The error you are observing most likely is due to dom0 colors >> > > > configuration not >> > > > > being >> > > > > > > > specified (i.e= . >> lack of dom0_colors=3D<> parameter). Although in the command line you >> > > > provided, this >> > > > > parameter >> > > > > > > > is set, I >> strongly doubt that this is the actual command line in use. >> > > > > > > > >> > > > > > > > You wrote: >> > > > > > > > >> xen,xen-bootargs =3D "console=3Ddtuart dtuart=3Dserial0 dom0_mem=3D1600= M >> dom0_max_vcpus=3D2 >> > > > dom0_vcpus_pin >> > > > > bootscrub=3D0 vwfi=3Dnative >> > > > > > > > sched=3Dnull >> timer_slop=3D0 way_szize=3D65536 xen_colors=3D0-3 dom0_colors=3D4-7"; >> > > > > > > > >> > > > > > > > but: >> > > > > > > > 1) way_szize >> has a typo >> > > > > > > > 2) you >> specified 4 colors (0-3) for Xen, but the boot log says that Xen has onl= y >> > > one: >> > > > > > > > (XEN) Xen >> color(s): [ 0 ] >> > > > > > > > >> > > > > > > > This makes me >> believe that no colors configuration actually end up in command line >> > > that Xen >> > > > booted >> > > > > with. >> > > > > > > > Single color >> for Xen is a "default if not specified" and way size was probably >> > > calculated >> > > > by asking >> > > > > HW. >> > > > > > > > >> > > > > > > > So I would >> suggest to first cross-check the command line in use. >> > > > > > > > >> > > > > > > > ~Michal >> > > > > > > > >> > > > > > > > >> > > > > > > > > >> > > > > > > > > Regards, >> > > > > > > > > Oleg >> > > > > > > > > >> > > > > > > > > =D0=B2=D1=82= , 18 =D0=B0=D0=BF=D1=80. >> 2023=E2=80=AF=D0=B3. =D0=B2 20:44, Stefano Stabellini > sstabellini@kernel.org> >> > > > > > sstabellini@kernel.org>> > sstabellini@kernel.org> > sstabellini@kernel.org>>> >> > > > > sstabellini@kernel.org> >> > > > > > sstabellini@kernel.org>> > sstabellini@kernel.org> > sstabellini@kernel.org>>>>>: >> > > > > > > > > >> > > > > > > > > On Tue, >> 18 Apr 2023, Oleg Nikitenko wrote: >> > > > > > > > > > Hi >> Julien, >> > > > > > > > > > >> > > > > > > > > > >> Thi= s >> feature has not been merged in Xen upstream yet >> > > > > > > > > > >> > > > > > > > > > > woul= d >> assume that upstream + the series on the ML [1] work >> > > > > > > > > > >> > > > > > > > > > Please >> clarify this point. >> > > > > > > > > > Becaus= e >> the two thoughts are controversial. >> > > > > > > > > >> > > > > > > > > Hi Oleg, >> > > > > > > > > >> > > > > > > > > As Julie= n >> wrote, there is nothing controversial. As you are aware, >> > > > > > > > > Xilinx >> maintains a separate Xen tree specific for Xilinx here: >> > > > > > > > > >> https://github.com/xilinx/xen < >> https://github.com/xilinx/xen > >> > > > > https://github.com/xilinx/xen> >> > > > > > https://github.com/xilinx/xen>>> > https://github.com/xilinx/xen> > https://github.com/xilinx/xen>> >> > > > > https://github.com/xilinx/xen> >> > > > > > https://github.com/xilinx/xen>>>> >> > > > > > > > > >> > > > > > > > > and the >> branch you are using (xlnx_rebase_4.16) comes from there. >> > > > > > > > > >> > > > > > > > > >> > > > > > > > > Instead, >> the upstream Xen tree lives here: >> > > > > > > > > >> https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary < >> https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary> >> > > > > < >> https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary < >> https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary>> < >> https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary < >> https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary> >> > > > > < >> https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary < >> https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary>>> < >> https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary < >> https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary> >> > > > > < >> https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary < >> https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary>> < >> https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary < >> https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary> >> > > > > < >> https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary < >> https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsummary>>>> >> > > > > > > > > >> > > > > > > > > >> > > > > > > > > The Cach= e >> Coloring feature that you are trying to configure is present >> > > > > > > > > in >> xlnx_rebase_4.16, but not yet present upstream (there is an >> > > > > > > > > >> outstanding patch series to add cache coloring to Xen upstream but it >> > > > > > > > > hasn't >> been merged yet.) >> > > > > > > > > >> > > > > > > > > >> > > > > > > > > Anyway, >> if you are using xlnx_rebase_4.16 it doesn't matter too much for >> > > > > > > > > you as >> you already have Cache Coloring as a feature there. >> > > > > > > > > >> > > > > > > > > >> > > > > > > > > I take >> you are using ImageBuilder to generate the boot configuration? If >> > > > > > > > > so, >> please post the ImageBuilder config file that you are using. >> > > > > > > > > >> > > > > > > > > But from >> the boot message, it looks like the colors configuration for >> > > > > > > > > Dom0 is >> incorrect. >> > > > > > > > > >> > > > > > > > >> > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > > >> > > > > >> > > > >> > > > >> > > > >> > > >> > > >> > > >> > >> > --000000000000f64c8c05fb3d35d5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: base64 PGRpdiBkaXI9Imx0ciI+PGRpdj5IZWxsbyBndXlzLDwvZGl2PjxkaXY+PGJyPjwvZGl2PjxkaXY+ SSBoYXZlIGEgY291cGxlIG9mIG1vcmUgcXVlc3Rpb25zLjwvZGl2PjxkaXY+SGF2ZSB5b3UgZXZl ciBydW4geGVuIHdpdGggdGhlIGNhY2hlIGNvbG9yaW5nIGF0IFp5bnEgVWx0cmFTY2FsZSsgTVBT b0MgemN1MTAyIHhjenUxNWVnID88L2Rpdj48ZGl2PldoZW4gZGlkIHlvdSBydW4geGVuIHdpdGgg dGhlIGNhY2hlIGNvbG9yaW5nIGxhc3QgdGltZSA/PC9kaXY+PGRpdj5XaGF0IGtlcm5lbCB2ZXJz aW9uIGRpZCB5b3UgdXNlIGZvciBEb20wIHdoZW4geW91IHJhbiB4ZW4gd2l0aCB0aGUgY2FjaGUg Y29sb3JpbmcgbGFzdCB0aW1lID88L2Rpdj48ZGl2Pjxicj48L2Rpdj48ZGl2PlJlZ2FyZHMsPC9k aXY+PGRpdj5PbGVnPGJyPjwvZGl2PjwvZGl2Pjxicj48ZGl2IGNsYXNzPSJnbWFpbF9xdW90ZSI+ PGRpdiBkaXI9Imx0ciIgY2xhc3M9ImdtYWlsX2F0dHIiPtC/0YIsIDUg0LzQsNGPIDIwMjPigK/Q sy4g0LIgMTE6NDgsIE9sZWcgTmlraXRlbmtvICZsdDs8YSBocmVmPSJtYWlsdG86b2xlc2hpaXdv b2RAZ21haWwuY29tIj5vbGVzaGlpd29vZEBnbWFpbC5jb208L2E+Jmd0Ozo8YnI+PC9kaXY+PGJs b2NrcXVvdGUgY2xhc3M9ImdtYWlsX3F1b3RlIiBzdHlsZT0ibWFyZ2luOjBweCAwcHggMHB4IDAu OGV4O2JvcmRlci1sZWZ0OjFweCBzb2xpZCByZ2IoMjA0LDIwNCwyMDQpO3BhZGRpbmctbGVmdDox ZXgiPjxkaXYgZGlyPSJsdHIiPjxkaXY+SGkgTWljaGFsLDwvZGl2PjxkaXY+PGJyPjwvZGl2Pjxk aXY+VGhhbmtzLjwvZGl2PjxkaXY+PC9kaXY+PGRpdj48YnI+PC9kaXY+PGRpdj5SZWdhcmRzLDwv ZGl2PjxkaXY+T2xlZzxicj48L2Rpdj48L2Rpdj48YnI+PGRpdiBjbGFzcz0iZ21haWxfcXVvdGUi PjxkaXYgZGlyPSJsdHIiIGNsYXNzPSJnbWFpbF9hdHRyIj7Qv9GCLCA1INC80LDRjyAyMDIz4oCv 0LMuINCyIDExOjM0LCBNaWNoYWwgT3J6ZWwgJmx0OzxhIGhyZWY9Im1haWx0bzptaWNoYWwub3J6 ZWxAYW1kLmNvbSIgdGFyZ2V0PSJfYmxhbmsiPm1pY2hhbC5vcnplbEBhbWQuY29tPC9hPiZndDs6 PGJyPjwvZGl2PjxibG9ja3F1b3RlIGNsYXNzPSJnbWFpbF9xdW90ZSIgc3R5bGU9Im1hcmdpbjow cHggMHB4IDBweCAwLjhleDtib3JkZXItbGVmdDoxcHggc29saWQgcmdiKDIwNCwyMDQsMjA0KTtw YWRkaW5nLWxlZnQ6MWV4Ij5IaSBPbGVnLDxicj4NCjxicj4NClJlcGx5aW5nLCBzbyB0aGF0IHlv dSBkbyBub3QgbmVlZCB0byB3YWl0IGZvciBTdGVmYW5vLjxicj4NCjxicj4NCk9uIDA1LzA1LzIw MjMgMTA6MjgsIE9sZWcgTmlraXRlbmtvIHdyb3RlOjxicj4NCiZndDvCoCDCoCDCoCDCoDxicj4N CiZndDsgPGJyPg0KJmd0OyA8YnI+DQomZ3Q7IEhlbGxvIFN0ZWZhbm8sPGJyPg0KJmd0OyA8YnI+ DQomZ3Q7IEkgd291bGQgbGlrZSB0byB0cnkgYSB4ZW4gY2FjaGUgY29sb3IgcHJvcGVydHkgZnJv bSB0aGlzIHJlcG/CoCA8YSBocmVmPSJodHRwczovL3hlbmJpdHMueGVuLm9yZy9naXQtaHR0cC94 ZW4uZ2l0IiByZWw9Im5vcmVmZXJyZXIiIHRhcmdldD0iX2JsYW5rIj5odHRwczovL3hlbmJpdHMu eGVuLm9yZy9naXQtaHR0cC94ZW4uZ2l0PC9hPiAmbHQ7PGEgaHJlZj0iaHR0cHM6Ly94ZW5iaXRz Lnhlbi5vcmcvZ2l0LWh0dHAveGVuLmdpdCIgcmVsPSJub3JlZmVycmVyIiB0YXJnZXQ9Il9ibGFu ayI+aHR0cHM6Ly94ZW5iaXRzLnhlbi5vcmcvZ2l0LWh0dHAveGVuLmdpdDwvYT4mZ3Q7PGJyPg0K Jmd0OyBDb3VsZCB5b3UgdGVsbCB3aG90IGJyYW5jaCBJIHNob3VsZCB1c2UgPzxicj4NCkNhY2hl IGNvbG9yaW5nIGZlYXR1cmUgaXMgbm90IHBhcnQgb2YgdGhlIHVwc3RyZWFtIHRyZWUgYW5kIGl0 IGlzIHN0aWxsIHVuZGVyIHJldmlldy48YnI+DQpZb3UgY2FuIG9ubHkgZmluZCBpdCBpbnRlZ3Jh dGVkIGluIHRoZSBYaWxpbnggWGVuIHRyZWUuPGJyPg0KPGJyPg0Kfk1pY2hhbDxicj4NCjxicj4N CiZndDsgPGJyPg0KJmd0OyBSZWdhcmRzLDxicj4NCiZndDsgT2xlZzxicj4NCiZndDsgPGJyPg0K Jmd0OyDQv9GCLCAyOCDQsNC/0YAuIDIwMjPigK/Qsy4g0LIgMDA6NTEsIFN0ZWZhbm8gU3RhYmVs bGluaSAmbHQ7PGEgaHJlZj0ibWFpbHRvOnNzdGFiZWxsaW5pQGtlcm5lbC5vcmciIHRhcmdldD0i X2JsYW5rIj5zc3RhYmVsbGluaUBrZXJuZWwub3JnPC9hPiAmbHQ7bWFpbHRvOjxhIGhyZWY9Im1h aWx0bzpzc3RhYmVsbGluaUBrZXJuZWwub3JnIiB0YXJnZXQ9Il9ibGFuayI+c3N0YWJlbGxpbmlA a2VybmVsLm9yZzwvYT4mZ3Q7Jmd0Ozo8YnI+DQomZ3Q7IDxicj4NCiZndDvCoCDCoCDCoEkgYW0g ZmFtaWxpYXIgd2l0aCB0aGUgemN1MTAyIGJ1dCBJIGRvbiYjMzk7dCBrbm93IGhvdyB5b3UgY291 bGQgcG9zc2libHk8YnI+DQomZ3Q7wqAgwqAgwqBnZW5lcmF0ZSBhIFNFcnJvci48YnI+DQomZ3Q7 IDxicj4NCiZndDvCoCDCoCDCoEkgc3VnZ2VzdCB0byB0cnkgdG8gdXNlIEltYWdlQnVpbGRlciBb MV0gdG8gZ2VuZXJhdGUgdGhlIGJvb3Q8YnI+DQomZ3Q7wqAgwqAgwqBjb25maWd1cmF0aW9uIGFz IGEgdGVzdCBiZWNhdXNlIHRoYXQgaXMga25vd24gdG8gd29yayB3ZWxsIGZvciB6Y3UxMDIuPGJy Pg0KJmd0OyA8YnI+DQomZ3Q7wqAgwqAgwqBbMV0gPGEgaHJlZj0iaHR0cHM6Ly9naXRsYWIuY29t L3hlbi1wcm9qZWN0L2ltYWdlYnVpbGRlciIgcmVsPSJub3JlZmVycmVyIiB0YXJnZXQ9Il9ibGFu ayI+aHR0cHM6Ly9naXRsYWIuY29tL3hlbi1wcm9qZWN0L2ltYWdlYnVpbGRlcjwvYT4gJmx0Ozxh IGhyZWY9Imh0dHBzOi8vZ2l0bGFiLmNvbS94ZW4tcHJvamVjdC9pbWFnZWJ1aWxkZXIiIHJlbD0i bm9yZWZlcnJlciIgdGFyZ2V0PSJfYmxhbmsiPmh0dHBzOi8vZ2l0bGFiLmNvbS94ZW4tcHJvamVj dC9pbWFnZWJ1aWxkZXI8L2E+Jmd0Ozxicj4NCiZndDsgPGJyPg0KJmd0OyA8YnI+DQomZ3Q7wqAg wqAgwqBPbiBUaHUsIDI3IEFwciAyMDIzLCBPbGVnIE5pa2l0ZW5rbyB3cm90ZTo8YnI+DQomZ3Q7 wqAgwqAgwqAmZ3Q7IEhlbGxvIFN0ZWZhbm8sPGJyPg0KJmd0O8KgIMKgIMKgJmd0Ozxicj4NCiZn dDvCoCDCoCDCoCZndDsgVGhhbmtzIGZvciBjbGFyaWZpY2F0aW9uLjxicj4NCiZndDvCoCDCoCDC oCZndDsgV2UgbmlnaHRlciB1c2UgSW1hZ2VCdWlsZGVyIG5vciB1Ym9vdCBib290IHNjcmlwdC48 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7IEEgbW9kZWwgaXMgemN1MTAyIGNvbXBhdGlibGUuPGJyPg0K Jmd0O8KgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDsgUmVnYXJkcyw8YnI+DQomZ3Q7 wqAgwqAgwqAmZ3Q7IE8uPGJyPg0KJmd0O8KgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZn dDsg0LLRgiwgMjUg0LDQv9GALiAyMDIz4oCv0LMuINCyIDIxOjIxLCBTdGVmYW5vIFN0YWJlbGxp bmkgJmx0OzxhIGhyZWY9Im1haWx0bzpzc3RhYmVsbGluaUBrZXJuZWwub3JnIiB0YXJnZXQ9Il9i bGFuayI+c3N0YWJlbGxpbmlAa2VybmVsLm9yZzwvYT4gJmx0O21haWx0bzo8YSBocmVmPSJtYWls dG86c3N0YWJlbGxpbmlAa2VybmVsLm9yZyIgdGFyZ2V0PSJfYmxhbmsiPnNzdGFiZWxsaW5pQGtl cm5lbC5vcmc8L2E+Jmd0OyZndDs6PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgVGhp cyBpcyBpbnRlcmVzdGluZy4gQXJlIHlvdSB1c2luZyBYaWxpbnggaGFyZHdhcmUgYnkgYW55IGNo YW5jZT8gSWYgc28sPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgd2hpY2ggYm9hcmQ/ PGJyPg0KJmd0O8KgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoEFy ZSB5b3UgdXNpbmcgSW1hZ2VCdWlsZGVyIHRvIGdlbmVyYXRlIHlvdXIgYm9vdC5zY3IgYm9vdCBz Y3JpcHQ/IElmIHNvLDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoGNvdWxkIHlvdSBw bGVhc2UgcG9zdCB5b3VyIEltYWdlQnVpbGRlciBjb25maWcgZmlsZT8gSWYgbm90LCBjYW4geW91 PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgcG9zdCB0aGUgc291cmNlIG9mIHlvdXIg dWJvb3QgYm9vdCBzY3JpcHQ/PGJyPg0KJmd0O8KgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoFNFcnJvcnMgYXJlIHN1cHBvc2VkIHRvIGJlIHJlbGF0ZWQgdG8gYSBo YXJkd2FyZSBmYWlsdXJlIG9mIHNvbWUga2luZC48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqBZb3UgYXJlIG5vdCBzdXBwb3NlZCB0byBiZSBhYmxlIHRvIHRyaWdnZXIgYW4gU0Vycm9y IGVhc2lseSBieTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZxdW90O21pc3Rha2Um cXVvdDsuIEkgaGF2ZSBub3Qgc2VlbiBTRXJyb3JzIGR1ZSB0byB3cm9uZyBjYWNoZSBjb2xvcmlu Zzxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoGNvbmZpZ3VyYXRpb25zIG9uIGFueSBY aWxpbnggYm9hcmQgYmVmb3JlLjxicj4NCiZndDvCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqBUaGUgZGlmZmVyZW5jZXMgYmV0d2VlbiBYZW4gd2l0aCBhbmQgd2l0 aG91dCBjYWNoZSBjb2xvcmluZyBmcm9tIGE8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqBoYXJkd2FyZSBwZXJzcGVjdGl2ZSBhcmU6PGJyPg0KJmd0O8KgIMKgIMKgJmd0Ozxicj4NCiZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoC0gV2l0aCBjYWNoZSBjb2xvcmluZywgdGhlIFNNTVUg aXMgZW5hYmxlZCBhbmQgZG9lcyBhZGRyZXNzIHRyYW5zbGF0aW9uczxicj4NCiZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoMKgIGV2ZW4gZm9yIGRvbTAuIFdpdGhvdXQgY2FjaGUgY29sb3Jpbmcg dGhlIFNNTVUgY291bGQgYmUgZGlzYWJsZWQsIGFuZDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoMKgIGlmIGVuYWJsZWQsIHRoZSBTTU1VIGRvZXNuJiMzOTt0IGRvIGFueSBhZGRyZXNz IHRyYW5zbGF0aW9ucyBmb3IgRG9tMC4gSWY8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqDCoCB0aGVyZSBpcyBhIGhhcmR3YXJlIGZhaWx1cmUgcmVsYXRlZCB0byBTTU1VIGFkZHJlc3Mg dHJhbnNsYXRpb24gaXQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqDCoCBjb3VsZCBv bmx5IHRyaWdnZXIgd2l0aCBjYWNoZSBjb2xvcmluZy4gVGhpcyB3b3VsZCBiZSBteSBub3JtYWw8 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqDCoCBzdWdnZXN0aW9uIGZvciB5b3UgdG8g ZXhwbG9yZSwgYnV0IHRoZSBmYWlsdXJlIGhhcHBlbnMgdG9vIGVhcmx5PGJyPg0KJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgwqAgYmVmb3JlIGFueSBETUEtY2FwYWJsZSBkZXZpY2UgaXMgcHJv Z3JhbW1lZC4gU28gSSBkb24mIzM5O3QgdGhpbmsgdGhpcyBjYW48YnI+DQomZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqDCoCBiZSB0aGUgaXNzdWUuPGJyPg0KJmd0O8KgIMKgIMKgJmd0Ozxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoC0gV2l0aCBjYWNoZSBjb2xvcmluZywgdGhlIG1l bW9yeSBhbGxvY2F0aW9uIGlzIHZlcnkgZGlmZmVyZW50IHNvIHlvdSYjMzk7bGw8YnI+DQomZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqDCoCBlbmQgdXAgdXNpbmcgZGlmZmVyZW50IEREUiByZWdp b25zIGZvciBEb20wLiBTbyBpZiB5b3VyIEREUiBpczxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoMKgIGRlZmVjdGl2ZSwgeW91IG1pZ2h0IG9ubHkgc2VlIGEgZmFpbHVyZSB3aXRoIGNh Y2hlIGNvbG9yaW5nIGVuYWJsZWQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqDCoCBi ZWNhdXNlIHlvdSBlbmQgdXAgdXNpbmcgZGlmZmVyZW50IHJlZ2lvbnMuPGJyPg0KJmd0O8KgIMKg IMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqBPbiBUdWUsIDI1IEFwciAyMDIzLCBPbGVnIE5pa2l0ZW5rbyB3cm90ZTo8YnI+DQomZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IEhpIFN0ZWZhbm8sPGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg VGhhbmsgeW91Ljxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgSWYgSSBidWls ZCB4ZW4gd2l0aG91dCBjb2xvcnMgc3VwcG9ydCB0aGVyZSBpcyBub3QgdGhpcyBlcnJvci48YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IEFsbCB0aGUgZG9tYWlucyBhcmUgYm9v dGVkIHdlbGwuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBIZW5zZSBpdCBj YW4gbm90IGJlIGEgaGFyZHdhcmUgaXNzdWUuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyBUaGlzIHBhbmljIGFycml2ZWQgZHVyaW5nIHVucGFja2luZyB0aGUgcm9vdGZzLjxi cj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgSGVyZSBJIGF0dGFjaGVkIHRoZSBi b290IGxvZyB4ZW4vRG9tMCB3aXRob3V0IGNvbG9yLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgQSBoaWdobGlnaHRlZCBzdHJpbmdzIHByaW50ZWQgZXhhY3RseSBhZnRlciB0 aGUgcGxhY2Ugd2hlcmUgMS1zdCB0aW1lIHBhbmljIGFycml2ZWQuPGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg wqBYZW4gNC4xNi4xLXByZTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhF TikgWGVuIHZlcnNpb24gNC4xNi4xLXByZSAobm9sZTIzOTBAKG5vbmUpKSAoYWFyY2g2NC1wb3J0 YWJsZS1saW51eC1nY2MgKEdDQykgMTEuMy4wKSBkZWJ1Zz15IDIwMjMtMDQtMjE8YnI+DQomZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIExhdGVzdCBDaGFuZ2VTZXQ6IFdlZCBB cHIgMTkgMTI6NTY6MTQgMjAyMyArMDMwMCBnaXQ6MzIxNjg3YjIzMS1kaXJ0eTxicj4NCiZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgYnVpbGQtaWQ6IGMxODQ3MjU4ZmRiMWI3 OTU2MmZjNzEwZGRhNDAwMDhmOTZjMGZkZTU8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7IChYRU4pIFByb2Nlc3NvcjogMDAwMDAwMDA0MTBmZDAzNDogJnF1b3Q7QVJNIExpbWl0 ZWQmcXVvdDssIHZhcmlhbnQ6IDB4MCwgcGFydCAweGQwMyxyZXYgMHg0PGJyPg0KJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSA2NC1iaXQgRXhlY3V0aW9uOjxicj4NCiZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgwqAgUHJvY2Vzc29yIEZlYXR1cmVzOiAw MDAwMDAwMDAwMDAyMjIyIDAwMDAwMDAwMDAwMDAwMDA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7IChYRU4pIMKgIMKgIEV4Y2VwdGlvbiBMZXZlbHM6IEVMMzo2NCszMiBFTDI6 NjQrMzIgRUwxOjY0KzMyIEVMMDo2NCszMjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgKFhFTikgwqAgwqAgRXh0ZW5zaW9uczogRmxvYXRpbmdQb2ludCBBZHZhbmNlZFNJTUQ8 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIMKgIERlYnVnIEZlYXR1 cmVzOiAwMDAwMDAwMDEwMzA1MTA2IDAwMDAwMDAwMDAwMDAwMDA8YnI+DQomZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIMKgIEF1eGlsaWFyeSBGZWF0dXJlczogMDAwMDAwMDAw MDAwMDAwMCAwMDAwMDAwMDAwMDAwMDAwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0OyAoWEVOKSDCoCBNZW1vcnkgTW9kZWwgRmVhdHVyZXM6IDAwMDAwMDAwMDAwMDExMjIgMDAw MDAwMDAwMDAwMDAwMDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikg wqAgSVNBIEZlYXR1cmVzOiDCoDAwMDAwMDAwMDAwMTExMjAgMDAwMDAwMDAwMDAwMDAwMDxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgMzItYml0IEV4ZWN1dGlvbjo8 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIMKgIFByb2Nlc3NvciBG ZWF0dXJlczogMDAwMDAwMDAwMDAwMDEzMTowMDAwMDAwMDAwMDExMDExPGJyPg0KJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSDCoCDCoCBJbnN0cnVjdGlvbiBTZXRzOiBBQXJj aDMyIEEzMiBUaHVtYiBUaHVtYi0yIEphemVsbGU8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7IChYRU4pIMKgIMKgIEV4dGVuc2lvbnM6IEdlbmVyaWNUaW1lciBTZWN1cml0eTxi cj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgwqAgRGVidWcgRmVhdHVy ZXM6IDAwMDAwMDAwMDMwMTAwNjY8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IChYRU4pIMKgIEF1eGlsaWFyeSBGZWF0dXJlczogMDAwMDAwMDAwMDAwMDAwMDxicj4NCiZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgwqAgTWVtb3J5IE1vZGVsIEZlYXR1cmVz OiAwMDAwMDAwMDEwMjAxMTA1IDAwMDAwMDAwNDAwMDAwMDA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgMDAwMDAwMDAwMTI2MDAwMCAwMDAwMDAwMDAyMTAyMjExPGJyPg0KJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSDCoCBJU0EgRmVhdHVyZXM6IDAwMDAwMDAwMDIxMDExMTAg MDAwMDAwMDAxMzExMjExMSAwMDAwMDAwMDIxMjMyMDQyPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0OyAoWEVOKSDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCAwMDAwMDAwMDAxMTEy MTMxIDAwMDAwMDAwMDAwMTExNDIgMDAwMDAwMDAwMDAxMTEyMTxicj4NCiZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDsgKFhFTikgVXNpbmcgU01DIENhbGxpbmcgQ29udmVudGlvbiB2MS4y PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBVc2luZyBQU0NJIHYx LjE8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIFNNUDogQWxsb3dp bmcgNCBDUFVzPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBHZW5l cmljIFRpbWVyIElSUTogcGh5cz0zMCBoeXA9MjYgdmlydD0yNyBGcmVxOiAxMDAwMDAgS0h6PGJy Pg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBHSUN2MiBpbml0aWFsaXph dGlvbjo8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIMKgIMKgIMKg IMKgIGdpY19kaXN0X2FkZHI9MDAwMDAwMDBmOTAxMDAwMDxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgKFhFTikgwqAgwqAgwqAgwqAgZ2ljX2NwdV9hZGRyPTAwMDAwMDAwZjkw MjAwMDA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIMKgIMKgIMKg IMKgIGdpY19oeXBfYWRkcj0wMDAwMDAwMGY5MDQwMDAwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0OyAoWEVOKSDCoCDCoCDCoCDCoCBnaWNfdmNwdV9hZGRyPTAwMDAwMDAwZjkw NjAwMDA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIMKgIMKgIMKg IMKgIGdpY19tYWludGVuYW5jZV9pcnE9MjU8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7IChYRU4pIEdJQ3YyOiBBZGp1c3RpbmcgQ1BVIGludGVyZmFjZSBiYXNlIHRvIDB4Zjkw MmYwMDA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIEdJQ3YyOiAx OTIgbGluZXMsIDQgY3B1cywgc2VjdXJlIChJSUQgMDIwMDE0M2IpLjxicj4NCiZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgVXNpbmcgc2NoZWR1bGVyOiBudWxsIFNjaGVkdWxl ciAobnVsbCk8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIEluaXRp YWxpemluZyBudWxsIHNjaGVkdWxlcjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgKFhFTikgV0FSTklORzogVGhpcyBpcyBleHBlcmltZW50YWwgc29mdHdhcmUgaW4gZGV2ZWxv cG1lbnQuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBVc2UgYXQg eW91ciBvd24gcmlzay48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4p IEFsbG9jYXRlZCBjb25zb2xlIHJpbmcgb2YgMzIgS2lCLjxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgKFhFTikgQ1BVMDogR3Vlc3QgYXRvbWljcyB3aWxsIHRyeSAxMiB0aW1l cyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyAoWEVOKSBCcmluZ2luZyB1cCBDUFUxPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyAoWEVOKSBDUFUxOiBHdWVzdCBhdG9taWNzIHdpbGwgdHJ5IDEzIHRpbWVzIGJl Zm9yZSBwYXVzaW5nIHRoZSBkb21haW48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IChYRU4pIENQVSAxIGJvb3RlZC48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IChYRU4pIEJyaW5naW5nIHVwIENQVTI8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7IChYRU4pIENQVTI6IEd1ZXN0IGF0b21pY3Mgd2lsbCB0cnkgMTMgdGltZXMgYmVmb3Jl IHBhdXNpbmcgdGhlIGRvbWFpbjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg KFhFTikgQ1BVIDIgYm9vdGVkLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg KFhFTikgQnJpbmdpbmcgdXAgQ1BVMzxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgKFhFTikgQ1BVMzogR3Vlc3QgYXRvbWljcyB3aWxsIHRyeSAxMyB0aW1lcyBiZWZvcmUgcGF1 c2luZyB0aGUgZG9tYWluPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVO KSBCcm91Z2h0IHVwIDQgQ1BVczxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg KFhFTikgQ1BVIDMgYm9vdGVkLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg KFhFTikgc21tdTogL2F4aS9zbW11QGZkODAwMDAwOiBwcm9iaW5nIGhhcmR3YXJlIGNvbmZpZ3Vy YXRpb24uLi48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIHNtbXU6 IC9heGkvc21tdUBmZDgwMDAwMDogU01NVXYyIHdpdGg6PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0OyAoWEVOKSBzbW11OiAvYXhpL3NtbXVAZmQ4MDAwMDA6IHN0YWdlIDIgdHJh bnNsYXRpb248YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIHNtbXU6 IC9heGkvc21tdUBmZDgwMDAwMDogc3RyZWFtIG1hdGNoaW5nIHdpdGggNDggcmVnaXN0ZXIgZ3Jv dXBzLCBtYXNrIDB4N2ZmZiZsdDsyJmd0O3NtbXU6IC9heGkvc21tdUBmZDgwMDAwMDogMTYgY29u dGV4dDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoGJhbmtzICgwPGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBzdGFnZS0yIG9ubHkpPGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBzbW11OiAvYXhpL3NtbXVAZmQ4MDAwMDA6IFN0YWdl LTI6IDQ4LWJpdCBJUEEgLSZndDsgNDgtYml0IFBBPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyAoWEVOKSBzbW11OiAvYXhpL3NtbXVAZmQ4MDAwMDA6IHJlZ2lzdGVyZWQgMjkg bWFzdGVyIGRldmljZXM8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4p IEkvTyB2aXJ0dWFsaXNhdGlvbiBlbmFibGVkPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyAoWEVOKSDCoC0gRG9tMCBtb2RlOiBSZWxheGVkPGJyPg0KJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBQMk06IDQwLWJpdCBJUEEgd2l0aCA0MC1iaXQgUEEgYW5k IDgtYml0IFZNSUQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIFAy TTogMyBsZXZlbHMgd2l0aCBvcmRlci0xIHJvb3QsIFZUQ1IgMHgwMDAwMDAwMDgwMDIzNTU4PGJy Pg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBTY2hlZHVsaW5nIGdyYW51 bGFyaXR5OiBjcHUsIDEgQ1BVIHBlciBzY2hlZC1yZXNvdXJjZTxicj4NCiZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDsgKFhFTikgYWx0ZXJuYXRpdmVzOiBQYXRjaGluZyB3aXRoIGFsdCB0 YWJsZSAwMDAwMDAwMDAwMmNjNWM4IC0mZ3Q7IDAwMDAwMDAwMDAyY2NiMmM8YnI+DQomZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pICoqKiBMT0FESU5HIERPTUFJTiAwICoqKjxi cj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgTG9hZGluZyBkMCBrZXJu ZWwgZnJvbSBib290IG1vZHVsZSBAIDAwMDAwMDAwMDEwMDAwMDA8YnI+DQomZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIExvYWRpbmcgcmFtZGlzayBmcm9tIGJvb3QgbW9kdWxl IEAgMDAwMDAwMDAwMjAwMDAwMDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg KFhFTikgQWxsb2NhdGluZyAxOjEgbWFwcGluZ3MgdG90YWxsaW5nIDE2MDBNQiBmb3IgZG9tMDo8 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIEJBTktbMF0gMHgwMDAw MDAxMDAwMDAwMC0weDAwMDAwMDIwMDAwMDAwICgyNTZNQik8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIEJBTktbMV0gMHgwMDAwMDAyNDAwMDAwMC0weDAwMDAwMDI4 MDAwMDAwICg2NE1CKTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikg QkFOS1syXSAweDAwMDAwMDMwMDAwMDAwLTB4MDAwMDAwODAwMDAwMDAgKDEyODBNQik8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIEdyYW50IHRhYmxlIHJhbmdlOiAw eDAwMDAwMDAwZTAwMDAwLTB4MDAwMDAwMDBlNDAwMDA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7IChYRU4pIHNtbXU6IC9heGkvc21tdUBmZDgwMDAwMDogZDA6IHAybWFkZHIg MHgwMDAwMDAwODdiZjk0MDAwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAo WEVOKSBBbGxvY2F0aW5nIFBQSSAxNiBmb3IgZXZlbnQgY2hhbm5lbCBpbnRlcnJ1cHQ8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIEV4dGVuZGVkIHJlZ2lvbiAwOiAw eDgxMjAwMDAwLSZndDsweGEwMDAwMDAwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0OyAoWEVOKSBFeHRlbmRlZCByZWdpb24gMTogMHhiMTIwMDAwMC0mZ3Q7MHhjMDAwMDAwMDxi cj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgRXh0ZW5kZWQgcmVnaW9u IDI6IDB4YzgwMDAwMDAtJmd0OzB4ZTAwMDAwMDA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7IChYRU4pIEV4dGVuZGVkIHJlZ2lvbiAzOiAweGYwMDAwMDAwLSZndDsweGY5MDAw MDAwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBFeHRlbmRlZCBy ZWdpb24gNDogMHgxMDAwMDAwMDAtJmd0OzB4NjAwMDAwMDAwPGJyPg0KJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBFeHRlbmRlZCByZWdpb24gNTogMHg4ODAwMDAwMDAtJmd0 OzB4ODAwMDAwMDAwMDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikg RXh0ZW5kZWQgcmVnaW9uIDY6IDB4ODAwMTAwMDAwMC0mZ3Q7MHgxMDAwMDAwMDAwMDxicj4NCiZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgTG9hZGluZyB6SW1hZ2UgZnJvbSAw MDAwMDAwMDAxMDAwMDAwIHRvIDAwMDAwMDAwMTAwMDAwMDAtMDAwMDAwMDAxMGU0MTAwODxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgTG9hZGluZyBkMCBpbml0cmQg ZnJvbSAwMDAwMDAwMDAyMDAwMDAwIHRvIDB4MDAwMDAwMDAxMzYwMDAwMC0weDAwMDAwMDAwMWZm M2E2MTc8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIExvYWRpbmcg ZDAgRFRCIHRvIDB4MDAwMDAwMDAxMzQwMDAwMC0weDAwMDAwMDAwMTM0MGNiZGM8YnI+DQomZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIEluaXRpYWwgbG93IG1lbW9yeSB2aXJx IHRocmVzaG9sZCBzZXQgYXQgMHg0MDAwIHBhZ2VzLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgKFhFTikgU3RkLiBMb2dsZXZlbDogQWxsPGJyPg0KJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBHdWVzdCBMb2dsZXZlbDogQWxsPGJyPg0KJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSAqKiogU2VyaWFsIGlucHV0IHRvIERPTTAgKHR5 cGUgJiMzOTtDVFJMLWEmIzM5OyB0aHJlZSB0aW1lcyB0byBzd2l0Y2ggaW5wdXQpPGJyPg0KJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBudWxsLmM6MzUzOiAwICZsdDstLSBk MHYwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBGcmVlZCAzNTZr QiBpbml0IG1lbW9yeS48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4p IGQwdjAgVW5oYW5kbGVkIFNNQy9IVkM6IDB4ODQwMDAwNTA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIGQwdjAgVW5oYW5kbGVkIFNNQy9IVkM6IDB4ODYwMGZmMDE8 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIGQwdjA6IHZHSUNEOiB1 bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjQ8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRs ZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjg8YnI+DQomZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IChYRU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQgd29y ZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjEyPGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSBkMHYwOiB2R0lDRDogdW5oYW5kbGVkIHdvcmQgd3Jp dGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVIxNjxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgKFhFTikgZDB2MDogdkdJQ0Q6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4 MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMjA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7IChYRU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAw MGZmZmZmZmZmIHRvIElDQUNUSVZFUjA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IFsgwqAgwqAwLjAwMDAwMF0gQm9vdGluZyBMaW51eCBvbiBwaHlzaWNhbCBDUFUgMHgwMDAw MDAwMDAwIFsweDQxMGZkMDM0XTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg WyDCoCDCoDAuMDAwMDAwXSBMaW51eCB2ZXJzaW9uIDUuMTUuNzIteGlsaW54LXYyMDIyLjEgKG9l LXVzZXJAb2UtaG9zdCkgKGFhcmNoNjQtcG9ydGFibGUtbGludXgtZ2NjIChHQ0MpIDExLjMuMCwg R05VIGxkIChHTlU8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBCaW51dGlscyk8YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IDIuMzguMjAyMjA3MDgpICMxIFNNUCBU dWUgRmViIDIxIDA1OjQ3OjU0IFVUQyAyMDIzPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBdIE1hY2hpbmUgbW9kZWw6IEQxNCBWaXBlciBCb2FyZCAt IFdoaXRlIFVuaXQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAw LjAwMDAwMF0gWGVuIDQuMTYgc3VwcG9ydCBmb3VuZDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgWyDCoCDCoDAuMDAwMDAwXSBab25lIHJhbmdlczo8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjAwMDAwMF0gwqAgRE1BIMKgIMKgIMKgW21l bSAweDAwMDAwMDAwMTAwMDAwMDAtMHgwMDAwMDAwMDdmZmZmZmZmXTxicj4NCiZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMDAwMDAwXSDCoCBETUEzMiDCoCDCoGVtcHR5 PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBdIMKg IE5vcm1hbCDCoCBlbXB0eTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDC oCDCoDAuMDAwMDAwXSBNb3ZhYmxlIHpvbmUgc3RhcnQgZm9yIGVhY2ggbm9kZTxicj4NCiZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMDAwMDAwXSBFYXJseSBtZW1vcnkg bm9kZSByYW5nZXM8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAw LjAwMDAwMF0gwqAgbm9kZSDCoCAwOiBbbWVtIDB4MDAwMDAwMDAxMDAwMDAwMC0weDAwMDAwMDAw MWZmZmZmZmZdPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4w MDAwMDBdIMKgIG5vZGUgwqAgMDogW21lbSAweDAwMDAwMDAwMjIwMDAwMDAtMHgwMDAwMDAwMDIy MTQ3ZmZmXTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMDAw MDAwXSDCoCBub2RlIMKgIDA6IFttZW0gMHgwMDAwMDAwMDIyMjAwMDAwLTB4MDAwMDAwMDAyMjM0 N2ZmZl08YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjAwMDAw MF0gwqAgbm9kZSDCoCAwOiBbbWVtIDB4MDAwMDAwMDAyNDAwMDAwMC0weDAwMDAwMDAwMjdmZmZm ZmZdPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBd IMKgIG5vZGUgwqAgMDogW21lbSAweDAwMDAwMDAwMzAwMDAwMDAtMHgwMDAwMDAwMDdmZmZmZmZm XTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMDAwMDAwXSBJ bml0bWVtIHNldHVwIG5vZGUgMCBbbWVtIDB4MDAwMDAwMDAxMDAwMDAwMC0weDAwMDAwMDAwN2Zm ZmZmZmZdPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAw MDBdIE9uIG5vZGUgMCwgem9uZSBETUE6IDgxOTIgcGFnZXMgaW4gdW5hdmFpbGFibGUgcmFuZ2Vz PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBdIE9u IG5vZGUgMCwgem9uZSBETUE6IDE4NCBwYWdlcyBpbiB1bmF2YWlsYWJsZSByYW5nZXM8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjAwMDAwMF0gT24gbm9kZSAw LCB6b25lIERNQTogNzM1MiBwYWdlcyBpbiB1bmF2YWlsYWJsZSByYW5nZXM8YnI+DQomZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjAwMDAwMF0gY21hOiBSZXNlcnZlZCAy NTYgTWlCIGF0IDB4MDAwMDAwMDA2ZTAwMDAwMDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDsgWyDCoCDCoDAuMDAwMDAwXSBwc2NpOiBwcm9iaW5nIGZvciBjb25kdWl0IG1ldGhv ZCBmcm9tIERULjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAu MDAwMDAwXSBwc2NpOiBQU0NJdjEuMSBkZXRlY3RlZCBpbiBmaXJtd2FyZS48YnI+DQomZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjAwMDAwMF0gcHNjaTogVXNpbmcgc3Rh bmRhcmQgUFNDSSB2MC4yIGZ1bmN0aW9uIElEczxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDsgWyDCoCDCoDAuMDAwMDAwXSBwc2NpOiBUcnVzdGVkIE9TIG1pZ3JhdGlvbiBub3Qg cmVxdWlyZWQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjAw MDAwMF0gcHNjaTogU01DIENhbGxpbmcgQ29udmVudGlvbiB2MS4xPGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBdIHBlcmNwdTogRW1iZWRkZWQgMTYg cGFnZXMvY3B1IHMzMjc5MiByMCBkMzI3NDQgdTY1NTM2PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBdIERldGVjdGVkIFZJUFQgSS1jYWNoZSBvbiBD UFUwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBd IENQVSBmZWF0dXJlczoga2VybmVsIHBhZ2UgdGFibGUgaXNvbGF0aW9uIGZvcmNlZCBPTiBieSBL QVNMUjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMDAwMDAw XSBDUFUgZmVhdHVyZXM6IGRldGVjdGVkOiBLZXJuZWwgcGFnZSB0YWJsZSBpc29sYXRpb24gKEtQ VEkpPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBd IEJ1aWx0IDEgem9uZWxpc3RzLCBtb2JpbGl0eSBncm91cGluZyBvbi7CoCBUb3RhbCBwYWdlczog NDAzODQ1PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAw MDBdIEtlcm5lbCBjb21tYW5kIGxpbmU6IGNvbnNvbGU9aHZjMCBlYXJseWNvbj14ZW4gZWFybHlw cmludGs9eGVuIGNsa19pZ25vcmVfdW51c2VkIGZpcHM9MSByb290PS9kZXYvcmFtMDxicj4NCiZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoG1heGNwdXM9Mjxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMDAwMDAwXSBVbmtub3duIGtlcm5lbCBjb21tYW5kIGxp bmUgcGFyYW1ldGVycyAmcXVvdDtlYXJseXByaW50az14ZW4gZmlwcz0xJnF1b3Q7LCB3aWxsIGJl IHBhc3NlZCB0byB1c2VyIHNwYWNlLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgWyDCoCDCoDAuMDAwMDAwXSBEZW50cnkgY2FjaGUgaGFzaCB0YWJsZSBlbnRyaWVzOiAyNjIx NDQgKG9yZGVyOiA5LCAyMDk3MTUyIGJ5dGVzLCBsaW5lYXIpPGJyPg0KJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBdIElub2RlLWNhY2hlIGhhc2ggdGFibGUg ZW50cmllczogMTMxMDcyIChvcmRlcjogOCwgMTA0ODU3NiBieXRlcywgbGluZWFyKTxicj4NCiZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMDAwMDAwXSBtZW0gYXV0by1p bml0OiBzdGFjazpvZmYsIGhlYXAgYWxsb2M6b24sIGhlYXAgZnJlZTpvbjxicj4NCiZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMDAwMDAwXSBtZW0gYXV0by1pbml0OiBj bGVhcmluZyBzeXN0ZW0gbWVtb3J5IG1heSB0YWtlIHNvbWUgdGltZS4uLjxicj4NCiZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMDAwMDAwXSBNZW1vcnk6IDExMjE5MzZL LzE2NDEwMjRLIGF2YWlsYWJsZSAoOTcyOEsga2VybmVsIGNvZGUsIDgzNksgcndkYXRhLCAyMzk2 SyByb2RhdGEsIDE1MzZLIGluaXQsIDI2MksgYnNzLDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoDI1Njk0NEsgcmVzZXJ2ZWQsPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0OyAyNjIxNDRLIGNtYS1yZXNlcnZlZCk8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7IFsgwqAgwqAwLjAwMDAwMF0gU0xVQjogSFdhbGlnbj02NCwgT3JkZXI9MC0zLCBNaW5P YmplY3RzPTAsIENQVXM9MiwgTm9kZXM9MTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgWyDCoCDCoDAuMDAwMDAwXSByY3U6IEhpZXJhcmNoaWNhbCBSQ1UgaW1wbGVtZW50YXRp b24uPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBd IHJjdTogUkNVIGV2ZW50IHRyYWNpbmcgaXMgZW5hYmxlZC48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjAwMDAwMF0gcmN1OiBSQ1UgcmVzdHJpY3RpbmcgQ1BV cyBmcm9tIE5SX0NQVVM9OCB0byBucl9jcHVfaWRzPTIuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBdIHJjdTogUkNVIGNhbGN1bGF0ZWQgdmFsdWUg b2Ygc2NoZWR1bGVyLWVubGlzdG1lbnQgZGVsYXkgaXMgMjUgamlmZmllcy48YnI+DQomZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjAwMDAwMF0gcmN1OiBBZGp1c3Rpbmcg Z2VvbWV0cnkgZm9yIHJjdV9mYW5vdXRfbGVhZj0xNiwgbnJfY3B1X2lkcz0yPGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBdIE5SX0lSUVM6IDY0LCBu cl9pcnFzOiA2NCwgcHJlYWxsb2NhdGVkIGlycXM6IDA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjAwMDAwMF0gUm9vdCBJUlEgaGFuZGxlcjogZ2ljX2hhbmRs ZV9pcnE8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjAwMDAw MF0gYXJjaF90aW1lcjogY3AxNSB0aW1lcihzKSBydW5uaW5nIGF0IDEwMC4wME1IeiAodmlydCku PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4wMDAwMDBdIGNs b2Nrc291cmNlOiBhcmNoX3N5c19jb3VudGVyOiBtYXNrOiAweGZmZmZmZmZmZmZmZmZmIG1heF9j eWNsZXM6IDB4MTcxMDI0ZTdlMCwgbWF4X2lkbGVfbnM6IDQ0MDc5NTIwNTMxNSBuczxicj4NCiZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMDAwMDAwXSBzY2hlZF9jbG9j azogNTYgYml0cyBhdCAxMDBNSHosIHJlc29sdXRpb24gMTBucywgd3JhcHMgZXZlcnkgNDM5ODA0 NjUxMTEwMG5zPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4w MDAyNThdIENvbnNvbGU6IGNvbG91ciBkdW1teSBkZXZpY2UgODB4MjU8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjMxMDIzMV0gcHJpbnRrOiBjb25zb2xlIFto dmMwXSBlbmFibGVkPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKg MC4zMTQ0MDNdIENhbGlicmF0aW5nIGRlbGF5IGxvb3AgKHNraXBwZWQpLCB2YWx1ZSBjYWxjdWxh dGVkIHVzaW5nIHRpbWVyIGZyZXF1ZW5jeS4uIDIwMC4wMCBCb2dvTUlQUyAobHBqPTQwMDAwMCk8 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjMyNDg1MV0gcGlk X21heDogZGVmYXVsdDogMzI3NjggbWluaW11bTogMzAxPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4zMjk3MDZdIExTTTogU2VjdXJpdHkgRnJhbWV3b3JrIGlu aXRpYWxpemluZzxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAu MzM0MjA0XSBZYW1hOiBiZWNvbWluZyBtaW5kZnVsLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgWyDCoCDCoDAuMzM3ODY1XSBNb3VudC1jYWNoZSBoYXNoIHRhYmxlIGVudHJp ZXM6IDQwOTYgKG9yZGVyOiAzLCAzMjc2OCBieXRlcywgbGluZWFyKTxicj4NCiZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMzQ1MTgwXSBNb3VudHBvaW50LWNhY2hlIGhh c2ggdGFibGUgZW50cmllczogNDA5NiAob3JkZXI6IDMsIDMyNzY4IGJ5dGVzLCBsaW5lYXIpPGJy Pg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC4zNTQ3NDNdIHhlbjpn cmFudF90YWJsZTogR3JhbnQgdGFibGVzIHVzaW5nIHZlcnNpb24gMSBsYXlvdXQ8YnI+DQomZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjM1OTEzMl0gR3JhbnQgdGFibGUg aW5pdGlhbGl6ZWQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAw LjM2MjY2NF0geGVuOmV2ZW50czogVXNpbmcgRklGTy1iYXNlZCBBQkk8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjM2Njk5M10gWGVuOiBpbml0aWFsaXppbmcg Y3B1MDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMzcwNTE1 XSByY3U6IEhpZXJhcmNoaWNhbCBTUkNVIGltcGxlbWVudGF0aW9uLjxicj4NCiZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMzc1OTMwXSBzbXA6IEJyaW5naW5nIHVwIHNl Y29uZGFyeSBDUFVzIC4uLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhF TikgbnVsbC5jOjM1MzogMSAmbHQ7LS0gZDB2MTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDsgKFhFTikgZDB2MTogdkdJQ0Q6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAw ZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgWyDCoCDCoDAuMzgyNTQ5XSBEZXRlY3RlZCBWSVBUIEktY2FjaGUgb24gQ1BVMTxicj4NCiZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuMzg4NzEyXSBYZW46IGluaXRp YWxpemluZyBjcHUxPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKg MC4zODg3NDNdIENQVTE6IEJvb3RlZCBzZWNvbmRhcnkgcHJvY2Vzc29yIDB4MDAwMDAwMDAwMSBb MHg0MTBmZDAzNF08YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAw LjM4ODgyOV0gc21wOiBCcm91Z2h0IHVwIDEgbm9kZSwgMiBDUFVzPGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC40MDY5NDFdIFNNUDogVG90YWwgb2YgMiBwcm9j ZXNzb3JzIGFjdGl2YXRlZC48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsg wqAgwqAwLjQxMTY5OF0gQ1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogMzItYml0IEVMMCBTdXBwb3J0 PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC40MTY4ODhdIENQ VSBmZWF0dXJlczogZGV0ZWN0ZWQ6IENSQzMyIGluc3RydWN0aW9uczxicj4NCiZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuNDIyMTIxXSBDUFU6IEFsbCBDUFUocykgc3Rh cnRlZCBhdCBFTDE8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAw LjQyNjI0OF0gYWx0ZXJuYXRpdmVzOiBwYXRjaGluZyBrZXJuZWwgY29kZTxicj4NCiZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuNDMxNDI0XSBkZXZ0bXBmczogaW5pdGlh bGl6ZWQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjQ0MTQ1 NF0gS0FTTFIgZW5hYmxlZDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDC oCDCoDAuNDQxNjAyXSBjbG9ja3NvdXJjZTogamlmZmllczogbWFzazogMHhmZmZmZmZmZiBtYXhf Y3ljbGVzOiAweGZmZmZmZmZmLCBtYXhfaWRsZV9uczogNzY0NTA0MTc4NTEwMDAwMCBuczxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuNDQ4MzIxXSBmdXRleCBo YXNoIHRhYmxlIGVudHJpZXM6IDUxMiAob3JkZXI6IDMsIDMyNzY4IGJ5dGVzLCBsaW5lYXIpPGJy Pg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC40OTYxODNdIE5FVDog UmVnaXN0ZXJlZCBQRl9ORVRMSU5LL1BGX1JPVVRFIHByb3RvY29sIGZhbWlseTxicj4NCiZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuNDk4Mjc3XSBETUE6IHByZWFsbG9j YXRlZCAyNTYgS2lCIEdGUF9LRVJORUwgcG9vbCBmb3IgYXRvbWljIGFsbG9jYXRpb25zPGJyPg0K Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC41MDM3NzJdIERNQTogcHJl YWxsb2NhdGVkIDI1NiBLaUIgR0ZQX0tFUk5FTHxHRlBfRE1BIHBvb2wgZm9yIGF0b21pYyBhbGxv Y2F0aW9uczxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuNTEx NjEwXSBETUE6IHByZWFsbG9jYXRlZCAyNTYgS2lCIEdGUF9LRVJORUx8R0ZQX0RNQTMyIHBvb2wg Zm9yIGF0b21pYyBhbGxvY2F0aW9uczxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgWyDCoCDCoDAuNTE5NDc4XSBhdWRpdDogaW5pdGlhbGl6aW5nIG5ldGxpbmsgc3Vic3lzIChk aXNhYmxlZCk8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjUy NDk4NV0gYXVkaXQ6IHR5cGU9MjAwMCBhdWRpdCgwLjMzNjoxKTogc3RhdGU9aW5pdGlhbGl6ZWQg YXVkaXRfZW5hYmxlZD0wIHJlcz0xPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 OyBbIMKgIMKgMC41MjkxNjldIHRoZXJtYWxfc3lzOiBSZWdpc3RlcmVkIHRoZXJtYWwgZ292ZXJu b3IgJiMzOTtzdGVwX3dpc2UmIzM5Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgWyDCoCDCoDAuNTMzMDIzXSBody1icmVha3BvaW50OiBmb3VuZCA2IGJyZWFrcG9pbnQgYW5k IDQgd2F0Y2hwb2ludCByZWdpc3RlcnMuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0OyBbIMKgIMKgMC41NDU2MDhdIEFTSUQgYWxsb2NhdG9yIGluaXRpYWxpc2VkIHdpdGggMzI3 NjggZW50cmllczxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAu NTUxMDMwXSB4ZW46c3dpb3RsYl94ZW46IFdhcm5pbmc6IG9ubHkgYWJsZSB0byBhbGxvY2F0ZSA0 IE1CIGZvciBzb2Z0d2FyZSBJTyBUTEI8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IFsgwqAgwqAwLjU1OTMzMl0gc29mdHdhcmUgSU8gVExCOiBtYXBwZWQgW21lbSAweDAwMDAw MDAwMTE4MDAwMDAtMHgwMDAwMDAwMDExYzAwMDAwXSAoNE1CKTxicj4NCiZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuNTgzNTY1XSBIdWdlVExCIHJlZ2lzdGVyZWQgMS4w MCBHaUIgcGFnZSBzaXplLCBwcmUtYWxsb2NhdGVkIDAgcGFnZXM8YnI+DQomZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjU4NDcyMV0gSHVnZVRMQiByZWdpc3RlcmVkIDMy LjAgTWlCIHBhZ2Ugc2l6ZSwgcHJlLWFsbG9jYXRlZCAwIHBhZ2VzPGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMC41OTE0NzhdIEh1Z2VUTEIgcmVnaXN0ZXJlZCAy LjAwIE1pQiBwYWdlIHNpemUsIHByZS1hbGxvY2F0ZWQgMCBwYWdlczxicj4NCiZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuNTk4MjI1XSBIdWdlVExCIHJlZ2lzdGVyZWQg NjQuMCBLaUIgcGFnZSBzaXplLCBwcmUtYWxsb2NhdGVkIDAgcGFnZXM8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjYzNjUyMF0gRFJCRzogQ29udGludWluZyB3 aXRob3V0IEppdHRlciBSTkc8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsg wqAgwqAwLjczNzE4N10gcmFpZDY6IG5lb254OCDCoCBnZW4oKSDCoDIxNDMgTUIvczxicj4NCiZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDAuODA1Mjk0XSByYWlkNjogbmVv bng4IMKgIHhvcigpIMKgMTU4OSBNQi9zPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0OyBbIMKgIMKgMC44NzM0MDZdIHJhaWQ2OiBuZW9ueDQgwqAgZ2VuKCkgwqAyMTc3IE1CL3M8 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAwLjk0MTQ5OV0gcmFp ZDY6IG5lb254NCDCoCB4b3IoKSDCoDE1NTYgTUIvczxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgWyDCoCDCoDEuMDA5NjEyXSByYWlkNjogbmVvbngyIMKgIGdlbigpIMKgMjA3 MiBNQi9zPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMS4wNzc3 MTVdIHJhaWQ2OiBuZW9ueDIgwqAgeG9yKCkgwqAxNDMwIE1CL3M8YnI+DQomZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjE0NTgzNF0gcmFpZDY6IG5lb254MSDCoCBnZW4o KSDCoDE3NjkgTUIvczxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDC oDEuMjEzOTM1XSByYWlkNjogbmVvbngxIMKgIHhvcigpIMKgMTIxNCBNQi9zPGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMS4yODIwNDZdIHJhaWQ2OiBpbnQ2NHg4 IMKgZ2VuKCkgwqAxMzY2IE1CL3M8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IFsgwqAgwqAxLjM1MDEzMl0gcmFpZDY6IGludDY0eDggwqB4b3IoKSDCoCA3NzMgTUIvczxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDEuNDE4MjU5XSByYWlkNjog aW50NjR4NCDCoGdlbigpIMKgMTYwMiBNQi9zPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyBbIMKgIMKgMS40ODYzNDldIHJhaWQ2OiBpbnQ2NHg0IMKgeG9yKCkgwqAgODUxIE1C L3M8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjU1NDQ2NF0g cmFpZDY6IGludDY0eDIgwqBnZW4oKSDCoDEzOTYgTUIvczxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgWyDCoCDCoDEuNjIyNTYxXSByYWlkNjogaW50NjR4MiDCoHhvcigpIMKg IDc0NCBNQi9zPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMS42 OTA2ODddIHJhaWQ2OiBpbnQ2NHgxIMKgZ2VuKCkgwqAxMDMzIE1CL3M8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjc1ODc3MF0gcmFpZDY6IGludDY0eDEgwqB4 b3IoKSDCoCA1MTcgTUIvczxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDC oCDCoDEuNzU4ODA5XSByYWlkNjogdXNpbmcgYWxnb3JpdGhtIG5lb254NCBnZW4oKSAyMTc3IE1C L3M8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjc2Mjk0MV0g cmFpZDY6IC4uLi4geG9yKCkgMTU1NiBNQi9zLCBybXcgZW5hYmxlZDxicj4NCiZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDEuNzY3OTU3XSByYWlkNjogdXNpbmcgbmVvbiBy ZWNvdmVyeSBhbGdvcml0aG08YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsg wqAgwqAxLjc3MjgyNF0geGVuOmJhbGxvb246IEluaXRpYWxpc2luZyBiYWxsb29uIGRyaXZlcjxi cj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDEuNzc4MDIxXSBpb21t dTogRGVmYXVsdCBkb21haW4gdHlwZTogVHJhbnNsYXRlZDxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgWyDCoCDCoDEuNzgyNTg0XSBpb21tdTogRE1BIGRvbWFpbiBUTEIgaW52 YWxpZGF0aW9uIHBvbGljeTogc3RyaWN0IG1vZGU8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7IFsgwqAgwqAxLjc4OTE0OV0gU0NTSSBzdWJzeXN0ZW0gaW5pdGlhbGl6ZWQ8YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjc5MjgyMF0gdXNiY29y ZTogcmVnaXN0ZXJlZCBuZXcgaW50ZXJmYWNlIGRyaXZlciB1c2Jmczxicj4NCiZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDEuNzk4MjU0XSB1c2Jjb3JlOiByZWdpc3RlcmVk IG5ldyBpbnRlcmZhY2UgZHJpdmVyIGh1Yjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgWyDCoCDCoDEuODAzNjI2XSB1c2Jjb3JlOiByZWdpc3RlcmVkIG5ldyBkZXZpY2UgZHJp dmVyIHVzYjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDEuODA4 NzYxXSBwcHNfY29yZTogTGludXhQUFMgQVBJIHZlci4gMSByZWdpc3RlcmVkPGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMS44MTM3MTZdIHBwc19jb3JlOiBTb2Z0 d2FyZSB2ZXIuIDUuMy42IC0gQ29weXJpZ2h0IDIwMDUtMjAwNyBSb2RvbGZvIEdpb21ldHRpICZs dDs8YSBocmVmPSJtYWlsdG86Z2lvbWV0dGlAbGludXguaXQiIHRhcmdldD0iX2JsYW5rIj5naW9t ZXR0aUBsaW51eC5pdDwvYT4gJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86Z2lvbWV0dGlAbGlu dXguaXQiIHRhcmdldD0iX2JsYW5rIj5naW9tZXR0aUBsaW51eC5pdDwvYT4mZ3Q7Jmd0Ozxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDEuODIyOTAzXSBQVFAgY2xv Y2sgc3VwcG9ydCByZWdpc3RlcmVkPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 OyBbIMKgIMKgMS44MjY4OTNdIEVEQUMgTUM6IFZlcjogMy4wLjA8YnI+DQomZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjgzMDM3NV0genlucW1wLWlwaS1tYm94IG1haWxi b3hAZmY5OTA0MDA6IFJlZ2lzdGVyZWQgWnlucU1QIElQSSBtYm94IHdpdGggVFgvUlggY2hhbm5l bHMuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMS44Mzg4NjNd IHp5bnFtcC1pcGktbWJveCBtYWlsYm94QGZmOTkwNjAwOiBSZWdpc3RlcmVkIFp5bnFNUCBJUEkg bWJveCB3aXRoIFRYL1JYIGNoYW5uZWxzLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgWyDCoCDCoDEuODQ3MzU2XSB6eW5xbXAtaXBpLW1ib3ggbWFpbGJveEBmZjk5MDgwMDog UmVnaXN0ZXJlZCBaeW5xTVAgSVBJIG1ib3ggd2l0aCBUWC9SWCBjaGFubmVscy48YnI+DQomZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjg1NTkwN10gRlBHQSBtYW5hZ2Vy IGZyYW1ld29yazxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDEu ODU5OTUyXSBjbG9ja3NvdXJjZTogU3dpdGNoZWQgdG8gY2xvY2tzb3VyY2UgYXJjaF9zeXNfY291 bnRlcjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDEuODcxNzEy XSBORVQ6IFJlZ2lzdGVyZWQgUEZfSU5FVCBwcm90b2NvbCBmYW1pbHk8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjg3MTgzOF0gSVAgaWRlbnRzIGhhc2ggdGFi bGUgZW50cmllczogMzI3NjggKG9yZGVyOiA2LCAyNjIxNDQgYnl0ZXMsIGxpbmVhcik8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjg3OTM5Ml0gdGNwX2xpc3Rl bl9wb3J0YWRkcl9oYXNoIGhhc2ggdGFibGUgZW50cmllczogMTAyNCAob3JkZXI6IDIsIDE2Mzg0 IGJ5dGVzLCBsaW5lYXIpPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKg IMKgMS44ODcwNzhdIFRhYmxlLXBlcnR1cmIgaGFzaCB0YWJsZSBlbnRyaWVzOiA2NTUzNiAob3Jk ZXI6IDYsIDI2MjE0NCBieXRlcywgbGluZWFyKTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDsgWyDCoCDCoDEuODk0ODQ2XSBUQ1AgZXN0YWJsaXNoZWQgaGFzaCB0YWJsZSBlbnRy aWVzOiAxNjM4NCAob3JkZXI6IDUsIDEzMTA3MiBieXRlcywgbGluZWFyKTxicj4NCiZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDEuOTAyOTAwXSBUQ1AgYmluZCBoYXNoIHRh YmxlIGVudHJpZXM6IDE2Mzg0IChvcmRlcjogNiwgMjYyMTQ0IGJ5dGVzLCBsaW5lYXIpPGJyPg0K Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMS45MTAzNTBdIFRDUDogSGFz aCB0YWJsZXMgY29uZmlndXJlZCAoZXN0YWJsaXNoZWQgMTYzODQgYmluZCAxNjM4NCk8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjkxNjc3OF0gVURQIGhhc2gg dGFibGUgZW50cmllczogMTAyNCAob3JkZXI6IDMsIDMyNzY4IGJ5dGVzLCBsaW5lYXIpPGJyPg0K Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMS45MjM1MDldIFVEUC1MaXRl IGhhc2ggdGFibGUgZW50cmllczogMTAyNCAob3JkZXI6IDMsIDMyNzY4IGJ5dGVzLCBsaW5lYXIp PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMS45MzA3NTldIE5F VDogUmVnaXN0ZXJlZCBQRl9VTklYL1BGX0xPQ0FMIHByb3RvY29sIGZhbWlseTxicj4NCiZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDEuOTM2ODM0XSBSUEM6IFJlZ2lzdGVy ZWQgbmFtZWQgVU5JWCBzb2NrZXQgdHJhbnNwb3J0IG1vZHVsZS48YnI+DQomZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjk0MjM0Ml0gUlBDOiBSZWdpc3RlcmVkIHVkcCB0 cmFuc3BvcnQgbW9kdWxlLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDC oCDCoDEuOTQ3MDg4XSBSUEM6IFJlZ2lzdGVyZWQgdGNwIHRyYW5zcG9ydCBtb2R1bGUuPGJyPg0K Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMS45NTE4NDNdIFJQQzogUmVn aXN0ZXJlZCB0Y3AgTkZTdjQuMSBiYWNrY2hhbm5lbCB0cmFuc3BvcnQgbW9kdWxlLjxicj4NCiZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDEuOTU4MzM0XSBQQ0k6IENMUyAw IGJ5dGVzLCBkZWZhdWx0IDY0PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBb IMKgIMKgMS45NjI3MDldIFRyeWluZyB0byB1bnBhY2sgcm9vdGZzIGltYWdlIGFzIGluaXRyYW1m cy4uLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDEuOTc3MDkw XSB3b3JraW5nc2V0OiB0aW1lc3RhbXBfYml0cz02MiBtYXhfb3JkZXI9MTkgYnVja2V0X29yZGVy PTA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAxLjk4Mjg2M10g SW5zdGFsbGluZyBrbmZzZCAoY29weXJpZ2h0IChDKSAxOTk2IDxhIGhyZWY9Im1haWx0bzpva2ly QG1vbmFkLnN3Yi5kZSIgdGFyZ2V0PSJfYmxhbmsiPm9raXJAbW9uYWQuc3diLmRlPC9hPiAmbHQ7 bWFpbHRvOjxhIGhyZWY9Im1haWx0bzpva2lyQG1vbmFkLnN3Yi5kZSIgdGFyZ2V0PSJfYmxhbmsi Pm9raXJAbW9uYWQuc3diLmRlPC9hPiZndDspLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDsgWyDCoCDCoDIuMDIxMDQ1XSBORVQ6IFJlZ2lzdGVyZWQgUEZfQUxHIHByb3RvY29s IGZhbWlseTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMDIx MTIyXSB4b3I6IG1lYXN1cmluZyBzb2Z0d2FyZSBjaGVja3N1bSBzcGVlZDxicj4NCiZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMDI5MzQ3XSDCoCDCoDhyZWdzIMKgIMKg IMKgIMKgIMKgIDogwqAyMzY2IE1CL3NlYzxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgWyDCoCDCoDIuMDMzMDgxXSDCoCDCoDMycmVncyDCoCDCoCDCoCDCoCDCoDogwqAyODAy IE1CL3NlYzxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMDM4 MjIzXSDCoCDCoGFybTY0X25lb24gwqAgwqAgwqA6IMKgMjMyMCBNQi9zZWM8YnI+DQomZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjAzODM4NV0geG9yOiB1c2luZyBmdW5j dGlvbjogMzJyZWdzICgyODAyIE1CL3NlYyk8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7IFsgwqAgwqAyLjA0MzYxNF0gQmxvY2sgbGF5ZXIgU0NTSSBnZW5lcmljIChic2cpIGRy aXZlciB2ZXJzaW9uIDAuNCBsb2FkZWQgKG1ham9yIDI0Nyk8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjA1MDk1OV0gaW8gc2NoZWR1bGVyIG1xLWRlYWRsaW5l IHJlZ2lzdGVyZWQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAy LjA1NTUyMV0gaW8gc2NoZWR1bGVyIGt5YmVyIHJlZ2lzdGVyZWQ8YnI+DQomZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjA2ODIyN10geGVuOnhlbl9ldnRjaG46IEV2ZW50 LWNoYW5uZWwgZGV2aWNlIGluc3RhbGxlZDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgWyDCoCDCoDIuMDY5MjgxXSBTZXJpYWw6IDgyNTAvMTY1NTAgZHJpdmVyLCA0IHBvcnRz LCBJUlEgc2hhcmluZyBkaXNhYmxlZDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgWyDCoCDCoDIuMDc2MTkwXSBjYWNoZWluZm86IFVuYWJsZSB0byBkZXRlY3QgY2FjaGUgaGll cmFyY2h5IGZvciBDUFUgMDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDC oCDCoDIuMDg1NTQ4XSBicmQ6IG1vZHVsZSBsb2FkZWQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjA4OTI5MF0gbG9vcDogbW9kdWxlIGxvYWRlZDxicj4NCiZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMDg5MzQxXSBJbnZhbGlkIG1h eF9xdWV1ZXMgKDQpLCB3aWxsIHVzZSBkZWZhdWx0IG1heDogMi48YnI+DQomZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjA5NDU2NV0gdHVuOiBVbml2ZXJzYWwgVFVOL1RB UCBkZXZpY2UgZHJpdmVyLCAxLjY8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IFsgwqAgwqAyLjA5ODY1NV0geGVuX25ldGZyb250OiBJbml0aWFsaXNpbmcgWGVuIHZpcnR1YWwg ZXRoZXJuZXQgZHJpdmVyPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKg IMKgMi4xMDQxNTZdIHVzYmNvcmU6IHJlZ2lzdGVyZWQgbmV3IGludGVyZmFjZSBkcml2ZXIgcnRs ODE1MDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMTA5ODEz XSB1c2Jjb3JlOiByZWdpc3RlcmVkIG5ldyBpbnRlcmZhY2UgZHJpdmVyIHI4MTUyPGJyPg0KJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi4xMTUzNjddIHVzYmNvcmU6IHJl Z2lzdGVyZWQgbmV3IGludGVyZmFjZSBkcml2ZXIgYXNpeDxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMTIwNzk0XSB1c2Jjb3JlOiByZWdpc3RlcmVkIG5ldyBp bnRlcmZhY2UgZHJpdmVyIGF4ODgxNzlfMTc4YTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDsgWyDCoCDCoDIuMTI2OTM0XSB1c2Jjb3JlOiByZWdpc3RlcmVkIG5ldyBpbnRlcmZh Y2UgZHJpdmVyIGNkY19ldGhlcjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg WyDCoCDCoDIuMTMyODE2XSB1c2Jjb3JlOiByZWdpc3RlcmVkIG5ldyBpbnRlcmZhY2UgZHJpdmVy IGNkY19lZW08YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjEz ODUyN10gdXNiY29yZTogcmVnaXN0ZXJlZCBuZXcgaW50ZXJmYWNlIGRyaXZlciBuZXQxMDgwPGJy Pg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi4xNDQyNTZdIHVzYmNv cmU6IHJlZ2lzdGVyZWQgbmV3IGludGVyZmFjZSBkcml2ZXIgY2RjX3N1YnNldDxicj4NCiZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMTUwMjA1XSB1c2Jjb3JlOiByZWdp c3RlcmVkIG5ldyBpbnRlcmZhY2UgZHJpdmVyIHphdXJ1czxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMTU1ODM3XSB1c2Jjb3JlOiByZWdpc3RlcmVkIG5ldyBp bnRlcmZhY2UgZHJpdmVyIGNkY19uY208YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IFsgwqAgwqAyLjE2MTU1MF0gdXNiY29yZTogcmVnaXN0ZXJlZCBuZXcgaW50ZXJmYWNlIGRy aXZlciByODE1M19lY208YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAg wqAyLjE2ODI0MF0gdXNiY29yZTogcmVnaXN0ZXJlZCBuZXcgaW50ZXJmYWNlIGRyaXZlciBjZGNf YWNtPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi4xNzMxMDld IGNkY19hY206IFVTQiBBYnN0cmFjdCBDb250cm9sIE1vZGVsIGRyaXZlciBmb3IgVVNCIG1vZGVt cyBhbmQgSVNETiBhZGFwdGVyczxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg WyDCoCDCoDIuMTgxMzU4XSB1c2Jjb3JlOiByZWdpc3RlcmVkIG5ldyBpbnRlcmZhY2UgZHJpdmVy IHVhczxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMTg2NTQ3 XSB1c2Jjb3JlOiByZWdpc3RlcmVkIG5ldyBpbnRlcmZhY2UgZHJpdmVyIHVzYi1zdG9yYWdlPGJy Pg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi4xOTI2NDNdIHVzYmNv cmU6IHJlZ2lzdGVyZWQgbmV3IGludGVyZmFjZSBkcml2ZXIgZnRkaV9zaW88YnI+DQomZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjE5ODM4NF0gdXNic2VyaWFsOiBVU0Ig U2VyaWFsIHN1cHBvcnQgcmVnaXN0ZXJlZCBmb3IgRlRESSBVU0IgU2VyaWFsIERldmljZTxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMjA2MTE4XSB1ZGMtY29y ZTogY291bGRuJiMzOTt0IGZpbmQgYW4gYXZhaWxhYmxlIFVEQyAtIGFkZGVkIFtnX21hc3Nfc3Rv cmFnZV0gdG8gbGlzdCBvZiBwZW5kaW5nIGRyaXZlcnM8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjIxNTMzMl0gaTJjX2RldjogaTJjIC9kZXYgZW50cmllcyBk cml2ZXI8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjIyMDQ2 N10geGVuX3dkdCB4ZW5fd2R0OiBpbml0aWFsaXplZCAodGltZW91dD02MHMsIG5vd2F5b3V0PTAp PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi4yMjU5MjNdIGRl dmljZS1tYXBwZXI6IHVldmVudDogdmVyc2lvbiAxLjAuMzxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMjMwNjY4XSBkZXZpY2UtbWFwcGVyOiBpb2N0bDogNC40 NS4wLWlvY3RsICgyMDIxLTAzLTIyKSBpbml0aWFsaXNlZDogPGEgaHJlZj0ibWFpbHRvOmRtLWRl dmVsQHJlZGhhdC5jb20iIHRhcmdldD0iX2JsYW5rIj5kbS1kZXZlbEByZWRoYXQuY29tPC9hPiAm bHQ7bWFpbHRvOjxhIGhyZWY9Im1haWx0bzpkbS1kZXZlbEByZWRoYXQuY29tIiB0YXJnZXQ9Il9i bGFuayI+ZG0tZGV2ZWxAcmVkaGF0LmNvbTwvYT4mZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0OyBbIMKgIMKgMi4yMzkzMTVdIEVEQUMgTUMwOiBHaXZpbmcgb3V0IGRldmlj ZSB0byBtb2R1bGUgMSBjb250cm9sbGVyIHN5bnBzX2Rkcl9jb250cm9sbGVyOiBERVYgc3lucHNf ZWRhYyAoSU5URVJSVVBUKTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDC oCDCoDIuMjQ5NDA1XSBFREFDIERFVklDRTA6IEdpdmluZyBvdXQgZGV2aWNlIHRvIG1vZHVsZSB6 eW5xbXAtb2NtLWVkYWMgY29udHJvbGxlciB6eW5xbXBfb2NtOiBERVY8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqBmZjk2MDAwMC5tZW1vcnktY29udHJvbGxlciAoSU5URVJSVVBUKTxi cj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMjYxNzE5XSBzZGhj aTogU2VjdXJlIERpZ2l0YWwgSG9zdCBDb250cm9sbGVyIEludGVyZmFjZSBkcml2ZXI8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjI2NzQ4N10gc2RoY2k6IENv cHlyaWdodChjKSBQaWVycmUgT3NzbWFuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0OyBbIMKgIMKgMi4yNzE4OTBdIHNkaGNpLXBsdGZtOiBTREhDSSBwbGF0Zm9ybSBhbmQgT0Yg ZHJpdmVyIGhlbHBlcjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDC oDIuMjc4MTU3XSBsZWR0cmlnLWNwdTogcmVnaXN0ZXJlZCB0byBpbmRpY2F0ZSBhY3Rpdml0eSBv biBDUFVzPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi4yODM4 MTZdIHp5bnFtcF9maXJtd2FyZV9wcm9iZSBQbGF0Zm9ybSBNYW5hZ2VtZW50IEFQSSB2MS4xPGJy Pg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi4yODk1NTRdIHp5bnFt cF9maXJtd2FyZV9wcm9iZSBUcnVzdHpvbmUgdmVyc2lvbiB2MS4wPGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi4zMjc4NzVdIHNlY3VyZWZ3IHNlY3VyZWZ3OiBz ZWN1cmVmdyBwcm9iZWQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAg wqAyLjMyODMyNF0gYWxnOiBObyB0ZXN0IGZvciB4aWxpbngtenlucW1wLWFlcyAoenlucW1wLWFl cyk8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjMzMjU2M10g enlucW1wX2FlcyBmaXJtd2FyZTp6eW5xbXAtZmlybXdhcmU6enlucW1wLWFlczogQUVTIFN1Y2Nl c3NmdWxseSBSZWdpc3RlcmVkPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBb IMKgIMKgMi4zNDExODNdIGFsZzogTm8gdGVzdCBmb3IgeGlsaW54LXp5bnFtcC1yc2EgKHp5bnFt cC1yc2EpPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi4zNDc2 NjddIHJlbW90ZXByb2MgcmVtb3RlcHJvYzA6IGZmOWEwMDAwLnJmNXNzOnI1Zl8wIGlzIGF2YWls YWJsZTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMzUzMDAz XSByZW1vdGVwcm9jIHJlbW90ZXByb2MxOiBmZjlhMDAwMC5yZjVzczpyNWZfMSBpcyBhdmFpbGFi bGU8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjM2MjYwNV0g ZnBnYV9tYW5hZ2VyIGZwZ2EwOiBYaWxpbnggWnlucU1QIEZQR0EgTWFuYWdlciByZWdpc3RlcmVk PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi4zNjY1NDBdIHZp cGVyLXhlbi1wcm94eSB2aXBlci14ZW4tcHJveHk6IFZpcGVyIFhlbiBQcm94eSByZWdpc3RlcmVk PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi4zNzI1MjVdIHZp cGVyLXZkcHAgYTQwMDAwMDAudmRwcDogRGV2aWNlIFRyZWUgUHJvYmluZzxicj4NCiZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuMzc3Nzc4XSB2aXBlci12ZHBwIGE0MDAw MDAwLnZkcHA6IFZEUFAgVmVyc2lvbjogMS4zLjkuMCBJbmZvOiAxLjUxMi4xNS4wIEtleUxlbjog MzI8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjM4NjQzMl0g dmlwZXItdmRwcCBhNDAwMDAwMC52ZHBwOiBVbmFibGUgdG8gcmVnaXN0ZXIgdGFtcGVyIGhhbmRs ZXIuIFJldHJ5aW5nLi4uPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKg IMKgMi4zOTQwOTRdIHZpcGVyLXZkcHAtbmV0IGE1MDAwMDAwLnZkcHBfbmV0OiBEZXZpY2UgVHJl ZSBQcm9iaW5nPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi4z OTk4NTRdIHZpcGVyLXZkcHAtbmV0IGE1MDAwMDAwLnZkcHBfbmV0OiBEZXZpY2UgcmVnaXN0ZXJl ZDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuNDA1OTMxXSB2 aXBlci12ZHBwLXN0YXQgYTgwMDAwMDAudmRwcF9zdGF0OiBEZXZpY2UgVHJlZSBQcm9iaW5nPGJy Pg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi40MTIwMzddIHZpcGVy LXZkcHAtc3RhdCBhODAwMDAwMC52ZHBwX3N0YXQ6IEJ1aWxkIHBhcmFtZXRlcnM6IFZUSSBDb3Vu dDogNTEyIEV2ZW50IENvdW50OiAzMjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgWyDCoCDCoDIuNDIwODU2XSBkZWZhdWx0IHByZXNldDxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuNDIzNzk3XSB2aXBlci12ZHBwLXN0YXQgYTgwMDAwMDAu dmRwcF9zdGF0OiBEZXZpY2UgcmVnaXN0ZXJlZDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDsgWyDCoCDCoDIuNDMwMDU0XSB2aXBlci12ZHBwLXJuZyBhYzAwMDAwMC52ZHBwX3Ju ZzogRGV2aWNlIFRyZWUgUHJvYmluZzxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgWyDCoCDCoDIuNDM1OTQ4XSB2aXBlci12ZHBwLXJuZyBhYzAwMDAwMC52ZHBwX3JuZzogRGV2 aWNlIHJlZ2lzdGVyZWQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAg wqAyLjQ0MTk3Nl0gdm1jdSBkcml2ZXIgaW5pdDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDsgWyDCoCDCoDIuNDQ0OTIyXSBWTUNVOiA6ICgyNDA6MCkgcmVnaXN0ZXJlZDxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuNDQ0OTU2XSBJbiBLODEg VXBkYXRlciBpbml0PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKg Mi40NDkwMDNdIHBrdGdlbjogUGFja2V0IEdlbmVyYXRvciBmb3IgcGFja2V0IHBlcmZvcm1hbmNl IHRlc3RpbmcuIFZlcnNpb246IDIuNzU8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IFsgwqAgwqAyLjQ2ODgzM10gSW5pdGlhbGl6aW5nIFhGUk0gbmV0bGluayBzb2NrZXQ8YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjQ2ODkwMl0gTkVUOiBS ZWdpc3RlcmVkIFBGX1BBQ0tFVCBwcm90b2NvbCBmYW1pbHk8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjQ3MjcyOV0gQnJpZGdlIGZpcmV3YWxsaW5nIHJlZ2lz dGVyZWQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjQ3Njc4 NV0gODAyMXE6IDgwMi4xUSBWTEFOIFN1cHBvcnQgdjEuODxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuNDgxMzQxXSByZWdpc3RlcmVkIHRhc2tzdGF0cyB2ZXJz aW9uIDE8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjQ4NjM5 NF0gQnRyZnMgbG9hZGVkLCBjcmMzMmM9Y3JjMzJjLWdlbmVyaWMsIHpvbmVkPW5vLCBmc3Zlcml0 eT1ubzxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuNTAzMTQ1 XSBmZjAxMDAwMC5zZXJpYWw6IHR0eVBTMSBhdCBNTUlPIDB4ZmYwMTAwMDAgKGlycSA9IDM2LCBi YXNlX2JhdWQgPSA2MjUwMDAwKSBpcyBhIHh1YXJ0cHM8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjUwNzEwM10gb2YtZnBnYS1yZWdpb24gZnBnYS1mdWxsOiBG UEdBIFJlZ2lvbiBwcm9iZWQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsg wqAgwqAyLjUxMjk4Nl0geGlsaW54LXp5bnFtcC1kbWEgZmQ1MDAwMDAuZG1hLWNvbnRyb2xsZXI6 IFp5bnFNUCBETUEgZHJpdmVyIFByb2JlIHN1Y2Nlc3M8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjUyMDI2N10geGlsaW54LXp5bnFtcC1kbWEgZmQ1MTAwMDAu ZG1hLWNvbnRyb2xsZXI6IFp5bnFNUCBETUEgZHJpdmVyIFByb2JlIHN1Y2Nlc3M8YnI+DQomZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjUyODIzOV0geGlsaW54LXp5bnFt cC1kbWEgZmQ1MjAwMDAuZG1hLWNvbnRyb2xsZXI6IFp5bnFNUCBETUEgZHJpdmVyIFByb2JlIHN1 Y2Nlc3M8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjUzNjE1 Ml0geGlsaW54LXp5bnFtcC1kbWEgZmQ1MzAwMDAuZG1hLWNvbnRyb2xsZXI6IFp5bnFNUCBETUEg ZHJpdmVyIFByb2JlIHN1Y2Nlc3M8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IFsgwqAgwqAyLjU0NDE1M10geGlsaW54LXp5bnFtcC1kbWEgZmQ1NDAwMDAuZG1hLWNvbnRyb2xs ZXI6IFp5bnFNUCBETUEgZHJpdmVyIFByb2JlIHN1Y2Nlc3M8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjU1MjEyN10geGlsaW54LXp5bnFtcC1kbWEgZmQ1NTAw MDAuZG1hLWNvbnRyb2xsZXI6IFp5bnFNUCBETUEgZHJpdmVyIFByb2JlIHN1Y2Nlc3M8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjU2MDE3OF0geGlsaW54LXp5 bnFtcC1kbWEgZmZhODAwMDAuZG1hLWNvbnRyb2xsZXI6IFp5bnFNUCBETUEgZHJpdmVyIFByb2Jl IHN1Y2Nlc3M8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjU2 Nzk4N10geGlsaW54LXp5bnFtcC1kbWEgZmZhOTAwMDAuZG1hLWNvbnRyb2xsZXI6IFp5bnFNUCBE TUEgZHJpdmVyIFByb2JlIHN1Y2Nlc3M8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IFsgwqAgwqAyLjU3NjAxOF0geGlsaW54LXp5bnFtcC1kbWEgZmZhYTAwMDAuZG1hLWNvbnRy b2xsZXI6IFp5bnFNUCBETUEgZHJpdmVyIFByb2JlIHN1Y2Nlc3M8YnI+DQomZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjU4Mzg4OV0geGlsaW54LXp5bnFtcC1kbWEgZmZh YjAwMDAuZG1hLWNvbnRyb2xsZXI6IFp5bnFNUCBETUEgZHJpdmVyIFByb2JlIHN1Y2Nlc3M8YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjk0NjM3OV0gc3BpLW5v ciBzcGkwLjA6IG10MjVxdTUxMmEgKDEzMTA3MiBLYnl0ZXMpPGJyPg0KJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMi45NDY0NjddIDIgZml4ZWQtcGFydGl0aW9ucyBwYXJ0 aXRpb25zIGZvdW5kIG9uIE1URCBkZXZpY2Ugc3BpMC4wPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0OyBbIMKgIMKgMi45NTIzOTNdIENyZWF0aW5nIDIgTVREIHBhcnRpdGlvbnMg b24gJnF1b3Q7c3BpMC4wJnF1b3Q7Ojxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgWyDCoCDCoDIuOTU3MjMxXSAweDAwMDAwNDAwMDAwMC0weDAwMDAwODAwMDAwMCA6ICZxdW90 O2JhbmsgQSZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDC oDIuOTYzMzMyXSAweDAwMDAwMDAwMDAwMC0weDAwMDAwNDAwMDAwMCA6ICZxdW90O2JhbmsgQiZx dW90Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuOTY4Njk0 XSBtYWNiIGZmMGIwMDAwLmV0aGVybmV0OiBOb3QgZW5hYmxpbmcgcGFydGlhbCBzdG9yZSBhbmQg Zm9yd2FyZDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDIuOTc1 MzMzXSBtYWNiIGZmMGIwMDAwLmV0aGVybmV0IGV0aDA6IENhZGVuY2UgR0VNIHJldiAweDUwMDcw MTA2IGF0IDB4ZmYwYjAwMDAgaXJxIDI1ICgxODo0MTpmZTowZjpmZjowMik8YnI+DQomZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjk4NDQ3Ml0gbWFjYiBmZjBjMDAwMC5l dGhlcm5ldDogTm90IGVuYWJsaW5nIHBhcnRpYWwgc3RvcmUgYW5kIGZvcndhcmQ8YnI+DQomZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAyLjk5MjE0NF0gbWFjYiBmZjBjMDAw MC5ldGhlcm5ldCBldGgxOiBDYWRlbmNlIEdFTSByZXYgMHg1MDA3MDEwNiBhdCAweGZmMGMwMDAw IGlycSAyNiAoMTg6NDE6ZmU6MGY6ZmY6MDMpPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyBbIMKgIMKgMy4wMDEwNDNdIHZpcGVyX2VuZXQgdmlwZXJfZW5ldDogVmlwZXIgcG93 ZXIgR1BJT3MgaW5pdGlhbGlzZWQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IFsgwqAgwqAzLjAwNzMxM10gdmlwZXJfZW5ldCB2aXBlcl9lbmV0IHZuZXQwICh1bmluaXRpYWxp emVkKTogVmFsaWRhdGUgaW50ZXJmYWNlIFFTR01JSTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgWyDCoCDCoDMuMDE0OTE0XSB2aXBlcl9lbmV0IHZpcGVyX2VuZXQgdm5ldDEg KHVuaW5pdGlhbGl6ZWQpOiBWYWxpZGF0ZSBpbnRlcmZhY2UgUVNHTUlJPGJyPg0KJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy4wMjIxMzhdIHZpcGVyX2VuZXQgdmlwZXJf ZW5ldCB2bmV0MSAodW5pbml0aWFsaXplZCk6IFZhbGlkYXRlIGludGVyZmFjZSB0eXBlIDE4PGJy Pg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy4wMzAyNzRdIHZpcGVy X2VuZXQgdmlwZXJfZW5ldCB2bmV0MiAodW5pbml0aWFsaXplZCk6IFZhbGlkYXRlIGludGVyZmFj ZSBRU0dNSUk8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjAz Nzc4NV0gdmlwZXJfZW5ldCB2aXBlcl9lbmV0IHZuZXQzICh1bmluaXRpYWxpemVkKTogVmFsaWRh dGUgaW50ZXJmYWNlIFFTR01JSTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg WyDCoCDCoDMuMDQ1MzAxXSB2aXBlcl9lbmV0IHZpcGVyX2VuZXQ6IFZpcGVyIGVuZXQgcmVnaXN0 ZXJlZDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuMDUwOTU4 XSB4aWxpbngtYXhpcG1vbiBmZmEwMDAwMC5wZXJmLW1vbml0b3I6IFByb2JlZCBYaWxpbnggQVBN PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy4wNTcxMzVdIHhp bGlueC1heGlwbW9uIGZkMGIwMDAwLnBlcmYtbW9uaXRvcjogUHJvYmVkIFhpbGlueCBBUE08YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjA2MzUzOF0geGlsaW54 LWF4aXBtb24gZmQ0OTAwMDAucGVyZi1tb25pdG9yOiBQcm9iZWQgWGlsaW54IEFQTTxicj4NCiZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuMDY5OTIwXSB4aWxpbngtYXhp cG1vbiBmZmExMDAwMC5wZXJmLW1vbml0b3I6IFByb2JlZCBYaWxpbnggQVBNPGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy4wOTc3MjldIHNpNzB4eDogcHJvYmUg b2YgMi0wMDQwIGZhaWxlZCB3aXRoIGVycm9yIC01PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyBbIMKgIMKgMy4wOTgwNDJdIGNkbnMtd2R0IGZkNGQwMDAwLndhdGNoZG9nOiBY aWxpbnggV2F0Y2hkb2cgVGltZXIgd2l0aCB0aW1lb3V0IDYwczxicj4NCiZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuMTA1MTExXSBjZG5zLXdkdCBmZjE1MDAwMC53YXRj aGRvZzogWGlsaW54IFdhdGNoZG9nIFRpbWVyIHdpdGggdGltZW91dCAxMHM8YnI+DQomZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjExMjQ1N10gdmlwZXItdGFtcGVyIHZp cGVyLXRhbXBlcjogRGV2aWNlIHJlZ2lzdGVyZWQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7IFsgwqAgwqAzLjExNzU5M10gYWN0aXZlX2JhbmsgYWN0aXZlX2Jhbms6IGJvb3Qg YmFuazogMTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuMTIy MTg0XSBhY3RpdmVfYmFuayBhY3RpdmVfYmFuazogYm9vdCBtb2RlOiAoMHgwMikgcXNwaTMyPGJy Pg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy4xMjgyNDddIHZpcGVy LXZkcHAgYTQwMDAwMDAudmRwcDogRGV2aWNlIFRyZWUgUHJvYmluZzxicj4NCiZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuMTMzNDM5XSB2aXBlci12ZHBwIGE0MDAwMDAw LnZkcHA6IFZEUFAgVmVyc2lvbjogMS4zLjkuMCBJbmZvOiAxLjUxMi4xNS4wIEtleUxlbjogMzI8 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjE0MjE1MV0gdmlw ZXItdmRwcCBhNDAwMDAwMC52ZHBwOiBUYW1wZXIgaGFuZGxlciByZWdpc3RlcmVkPGJyPg0KJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy4xNDc0MzhdIHZpcGVyLXZkcHAg YTQwMDAwMDAudmRwcDogRGV2aWNlIHJlZ2lzdGVyZWQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjE1MzAwN10gbHBjNTVfbDIgc3BpMS4wOiByZWdpc3RlcmVk IGhhbmRsZXIgZm9yIHByb3RvY29sIDA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IFsgwqAgwqAzLjE1ODU4Ml0gbHBjNTVfdXNlciBscGM1NV91c2VyOiBUaGUgbWFqb3IgbnVt YmVyIGZvciB5b3VyIGRldmljZSBpcyAyMzY8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7IFsgwqAgwqAzLjE2NTk3Nl0gbHBjNTVfbDIgc3BpMS4wOiByZWdpc3RlcmVkIGhhbmRs ZXIgZm9yIHByb3RvY29sIDE8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsg wqAgwqAzLjE4MTk5OV0gcnRjLWxwYzU1IHJ0Y19scGM1NTogbHBjNTVfcnRjX2dldF90aW1lOiBi YWQgcmVzdWx0OiAxPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKg My4xODI4NTZdIHJ0Yy1scGM1NSBydGNfbHBjNTU6IHJlZ2lzdGVyZWQgYXMgcnRjMDxicj4NCiZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuMTg4NjU2XSBscGM1NV9sMiBz cGkxLjA6ICgyKSBtY3Ugc3RpbGwgbm90IHJlYWR5Pzxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgWyDCoCDCoDMuMTkzNzQ0XSBscGM1NV9sMiBzcGkxLjA6ICgzKSBtY3Ugc3Rp bGwgbm90IHJlYWR5Pzxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDC oDMuMTk4ODQ4XSBscGM1NV9sMiBzcGkxLjA6ICg0KSBtY3Ugc3RpbGwgbm90IHJlYWR5Pzxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuMjAyOTMyXSBtbWMwOiBT REhDSSBjb250cm9sbGVyIG9uIGZmMTYwMDAwLm1tYyBbZmYxNjAwMDAubW1jXSB1c2luZyBBRE1B IDY0LWJpdDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuMjEw Njg5XSBscGM1NV9sMiBzcGkxLjA6ICg1KSBtY3Ugc3RpbGwgbm90IHJlYWR5Pzxicj4NCiZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuMjE1Njk0XSBscGM1NV9sMiBzcGkx LjA6IHJ4IGVycm9yOiAtMTEwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBb IMKgIMKgMy4yODQ0MzhdIG1tYzA6IG5ldyBIUzIwMCBNTUMgY2FyZCBhdCBhZGRyZXNzIDAwMDE8 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjI4NTE3OV0gbW1j YmxrMDogbW1jMDowMDAxIFNFTTE2RyAxNC42IEdpQjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgWyDCoCDCoDMuMjkxNzg0XSDCoG1tY2JsazA6IHAxIHAyIHAzIHA0IHA1IHA2 IHA3IHA4PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy4yOTM5 MTVdIG1tY2JsazBib290MDogbW1jMDowMDAxIFNFTTE2RyA0LjAwIE1pQjxicj4NCiZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuMjk5MDU0XSBtbWNibGswYm9vdDE6IG1t YzA6MDAwMSBTRU0xNkcgNC4wMCBNaUI8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IFsgwqAgwqAzLjMwMzkwNV0gbW1jYmxrMHJwbWI6IG1tYzA6MDAwMSBTRU0xNkcgNC4wMCBN aUIsIGNoYXJkZXYgKDI0NDowKTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg WyDCoCDCoDMuNTgyNjc2XSBydGMtbHBjNTUgcnRjX2xwYzU1OiBscGM1NV9ydGNfZ2V0X3RpbWU6 IGJhZCByZXN1bHQ6IDE8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAg wqAzLjU4MzMzMl0gcnRjLWxwYzU1IHJ0Y19scGM1NTogaGN0b3N5czogdW5hYmxlIHRvIHJlYWQg dGhlIGhhcmR3YXJlIGNsb2NrPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBb IMKgIMKgMy41OTEyNTJdIGNkbnMtaTJjIGZmMDIwMDAwLmkyYzogcmVjb3ZlcnkgaW5mb3JtYXRp b24gY29tcGxldGU8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAz LjU5NzA4NV0gYXQyNCAwLTAwNTA6IHN1cHBseSB2Y2Mgbm90IGZvdW5kLCB1c2luZyBkdW1teSBy ZWd1bGF0b3I8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjYw MzAxMV0gbHBjNTVfbDIgc3BpMS4wOiAoMikgbWN1IHN0aWxsIG5vdCByZWFkeT88YnI+DQomZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjYwODA5M10gYXQyNCAwLTAwNTA6 IDI1NiBieXRlIHNwZCBFRVBST00sIHJlYWQtb25seTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgWyDCoCDCoDMuNjEzNjIwXSBscGM1NV9sMiBzcGkxLjA6ICgzKSBtY3Ugc3Rp bGwgbm90IHJlYWR5Pzxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDC oDMuNjE5MzYyXSBscGM1NV9sMiBzcGkxLjA6ICg0KSBtY3Ugc3RpbGwgbm90IHJlYWR5Pzxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuNjI0MjI0XSBydGMtcnYz MDI4IDAtMDA1MjogcmVnaXN0ZXJlZCBhcyBydGMxPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyBbIMKgIMKgMy42MjgzNDNdIGxwYzU1X2wyIHNwaTEuMDogKDUpIG1jdSBzdGls bCBub3QgcmVhZHk/PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKg My42MzMyNTNdIGxwYzU1X2wyIHNwaTEuMDogcnggZXJyb3I6IC0xMTA8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjYzOTEwNF0gazgxX2Jvb3Rsb2FkZXIgMC0w MDEwOiBwcm9iZTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMu NjQxNjI4XSBWTUNVOiA6ICgyMzU6MCkgcmVnaXN0ZXJlZDxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuNjQxNjM1XSBrODFfYm9vdGxvYWRlciAwLTAwMTA6IHBy b2JlIGNvbXBsZXRlZDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDC oDMuNjY4MzQ2XSBjZG5zLWkyYyBmZjAyMDAwMC5pMmM6IDQwMCBrSHogbW1pbyBmZjAyMDAwMCBp cnEgMjg8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjY2OTE1 NF0gY2Rucy1pMmMgZmYwMzAwMDAuaTJjOiByZWNvdmVyeSBpbmZvcm1hdGlvbiBjb21wbGV0ZTxi cj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuNjc1NDEyXSBsbTc1 IDEtMDA0ODogc3VwcGx5IHZzIG5vdCBmb3VuZCwgdXNpbmcgZHVtbXkgcmVndWxhdG9yPGJyPg0K Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy42ODI5MjBdIGxtNzUgMS0w MDQ4OiBod21vbjE6IHNlbnNvciAmIzM5O3RtcDExMiYjMzk7PGJyPg0KJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy42ODY1NDhdIGkyYyBpMmMtMTogQWRkZWQgbXVsdGlw bGV4ZWQgaTJjIGJ1cyAzPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKg IMKgMy42OTA3OTVdIGkyYyBpMmMtMTogQWRkZWQgbXVsdGlwbGV4ZWQgaTJjIGJ1cyA0PGJyPg0K Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy42OTU2MjldIGkyYyBpMmMt MTogQWRkZWQgbXVsdGlwbGV4ZWQgaTJjIGJ1cyA1PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyBbIMKgIMKgMy43MDA0OTJdIGkyYyBpMmMtMTogQWRkZWQgbXVsdGlwbGV4ZWQg aTJjIGJ1cyA2PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy43 MDUxNTddIHBjYTk1NHggMS0wMDcwOiByZWdpc3RlcmVkIDQgbXVsdGlwbGV4ZWQgYnVzc2VzIGZv ciBJMkMgc3dpdGNoIHBjYTk1NDY8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IFsgwqAgwqAzLjcxMzA0OV0gYXQyNCAxLTAwNTQ6IHN1cHBseSB2Y2Mgbm90IGZvdW5kLCB1c2lu ZyBkdW1teSByZWd1bGF0b3I8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsg wqAgwqAzLjcyMDA2N10gYXQyNCAxLTAwNTQ6IDEwMjQgYnl0ZSAyNGMwOCBFRVBST00sIHJlYWQt b25seTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuNzI0NzYx XSBjZG5zLWkyYyBmZjAzMDAwMC5pMmM6IDEwMCBrSHogbW1pbyBmZjAzMDAwMCBpcnEgMjk8YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjczMTI3Ml0gc2ZwIHZp cGVyX2VuZXQ6c2ZwLWV0aDE6IEhvc3QgbWF4aW11bSBwb3dlciAyLjBXPGJyPg0KJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy43Mzc1NDldIHNmcF9yZWdpc3Rlcl9zb2Nr ZXQ6IGdvdCBzZnBfYnVzPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKg IMKgMy43NDA3MDldIHNmcF9yZWdpc3Rlcl9zb2NrZXQ6IHJlZ2lzdGVyIHNmcF9idXM8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjc0NTQ1OV0gc2ZwX3JlZ2lz dGVyX2J1czogb3BzIG9rITxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDC oCDCoDMuNzQ5MTc5XSBzZnBfcmVnaXN0ZXJfYnVzOiBUcnkgdG8gYXR0YWNoPGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy43NTM0MTldIHNmcF9yZWdpc3Rlcl9i dXM6IEF0dGFjaCBzdWNjZWVkZWQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IFsgwqAgwqAzLjc1NzkxNF0gc2ZwX3JlZ2lzdGVyX2J1czogdXBzdHJlYW0gb3BzIGF0dGFjaDxi cj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCDCoDMuNzYyNjc3XSBzZnBf cmVnaXN0ZXJfYnVzOiBCdXMgcmVnaXN0ZXJlZDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDsgWyDCoCDCoDMuNzY2OTk5XSBzZnBfcmVnaXN0ZXJfc29ja2V0OiByZWdpc3RlciBz ZnBfYnVzIHN1Y2NlZWRlZDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDC oCDCoDMuNzc1ODcwXSBvZl9jZnNfaW5pdDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgWyDCoCDCoDMuNzc2MDAwXSBvZl9jZnNfaW5pdDogT0s8YnI+DQomZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjc3ODIxMV0gY2xrOiBOb3QgZGlzYWJsaW5nIHVu dXNlZCBjbG9ja3M8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEu Mjc4NDc3XSBGcmVlaW5nIGluaXRyZCBtZW1vcnk6IDIwNjA1Nks8YnI+DQomZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMjc5NDA2XSBGcmVlaW5nIHVudXNlZCBrZXJuZWwg bWVtb3J5OiAxNTM2Szxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAx MS4zMTQwMDZdIENoZWNrZWQgVytYIG1hcHBpbmdzOiBwYXNzZWQsIG5vIFcrWCBwYWdlcyBmb3Vu ZDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxMS4zMTQxNDJdIFJ1 biAvaW5pdCBhcyBpbml0IHByb2Nlc3M8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IElOSVQ6IHZlcnNpb24gMy4wMSBib290aW5nPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyBmc2NrIChidXN5Ym94IDEuMzUuMCk8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7IC9kZXYvbW1jYmxrMHAxOiBjbGVhbiwgMTIvMTAyNDAwIGZpbGVzLCAyMzgx NjIvNDA5NjAwIGJsb2Nrczxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgL2Rl di9tbWNibGswcDI6IGNsZWFuLCAxMi8xMDI0MDAgZmlsZXMsIDE3MTk3Mi80MDk2MDAgYmxvY2tz PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAvZGV2L21tY2JsazBwMyB3YXMg bm90IGNsZWFubHkgdW5tb3VudGVkLCBjaGVjayBmb3JjZWQuPGJyPg0KJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0OyAvZGV2L21tY2JsazBwMzogMjAvNDA5NiBmaWxlcyAoMC4wJSBub24t Y29udGlndW91cyksIDY2My8xNjM4NCBibG9ja3M8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7IFsgwqAgMTEuNTUzMDczXSBFWFQ0LWZzIChtbWNibGswcDMpOiBtb3VudGVkIGZp bGVzeXN0ZW0gd2l0aG91dCBqb3VybmFsLiBPcHRzOiAobnVsbCkuIFF1b3RhIG1vZGU6IGRpc2Fi bGVkLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgU3RhcnRpbmcgcmFuZG9t IG51bWJlciBnZW5lcmF0b3IgZGFlbW9uLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgWyDCoCAxMS41ODA2NjJdIHJhbmRvbTogY3JuZyBpbml0IGRvbmU8YnI+DQomZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFN0YXJ0aW5nIHVkZXY8YnI+DQomZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuNjEzMTU5XSB1ZGV2ZFsxNDJdOiBzdGFydGluZyB2 ZXJzaW9uIDMuMi4xMDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAx MS42MjAzODVdIHVkZXZkWzE0M106IHN0YXJ0aW5nIGV1ZGV2LTMuMi4xMDxicj4NCiZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxMS43MDQ0ODFdIG1hY2IgZmYwYjAwMDAuZXRo ZXJuZXQgY29udHJvbF9yZWQ6IHJlbmFtZWQgZnJvbSBldGgwPGJyPg0KJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjcyMDI2NF0gbWFjYiBmZjBjMDAwMC5ldGhlcm5ldCBj b250cm9sX2JsYWNrOiByZW5hbWVkIGZyb20gZXRoMTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgWyDCoCAxMi4wNjMzOTZdIGlwX2xvY2FsX3BvcnRfcmFuZ2U6IHByZWZlciBk aWZmZXJlbnQgcGFyaXR5IGZvciBzdGFydC9lbmQgdmFsdWVzLjxicj4NCiZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxMi4wODQ4MDFdIHJ0Yy1scGM1NSBydGNfbHBjNTU6IGxw YzU1X3J0Y19nZXRfdGltZTogYmFkIHJlc3VsdDogMTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgaHdjbG9jazogUlRDX1JEX1RJTUU6IEludmFsaWQgZXhjaGFuZ2U8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IE1vbiBGZWIgMjcgMDg6NDA6NTMgVVRDIDIw MjM8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTIuMTE1MzA5XSBy dGMtbHBjNTUgcnRjX2xwYzU1OiBscGM1NV9ydGNfc2V0X3RpbWU6IGJhZCByZXN1bHQ8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IGh3Y2xvY2s6IFJUQ19TRVRfVElNRTogSW52 YWxpZCBleGNoYW5nZTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAx Mi4xMzEwMjddIHJ0Yy1scGM1NSBydGNfbHBjNTU6IGxwYzU1X3J0Y19nZXRfdGltZTogYmFkIHJl c3VsdDogMTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgU3RhcnRpbmcgbWN1 ZDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgSU5JVDogRW50ZXJpbmcgcnVu bGV2ZWw6IDU8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IENvbmZpZ3VyaW5n IG5ldHdvcmsgaW50ZXJmYWNlcy4uLiBkb25lLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDsgcmVzZXR0aW5nIG5ldHdvcmsgaW50ZXJmYWNlPGJyPg0KJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDEyLjcxODI5NV0gbWFjYiBmZjBiMDAwMC5ldGhlcm5ldCBj b250cm9sX3JlZDogUEhZIFtmZjBiMDAwMC5ldGhlcm5ldC1mZmZmZmZmZjowMl0gZHJpdmVyIFtY aWxpbnggUENTL1BNQSBQSFldIChpcnE9UE9MTCk8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7IFsgwqAgMTIuNzIzOTE5XSBtYWNiIGZmMGIwMDAwLmV0aGVybmV0IGNvbnRyb2xf cmVkOiBjb25maWd1cmluZyBmb3IgcGh5L2dtaWkgbGluayBtb2RlPGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDEyLjczMjE1MV0gcHBzIHBwczA6IG5ldyBQUFMgc291 cmNlIHB0cDA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTIuNzM1 NTYzXSBtYWNiIGZmMGIwMDAwLmV0aGVybmV0OiBnZW0tcHRwLXRpbWVyIHB0cCBjbG9jayByZWdp c3RlcmVkLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxMi43NDU3 MjRdIG1hY2IgZmYwYzAwMDAuZXRoZXJuZXQgY29udHJvbF9ibGFjazogUEhZIFtmZjBjMDAwMC5l dGhlcm5ldC1mZmZmZmZmZjowMV0gZHJpdmVyIFtYaWxpbnggUENTL1BNQSBQSFldPGJyPg0KJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgKGlycT1QT0xMKTxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgWyDCoCAxMi43NTM0NjldIG1hY2IgZmYwYzAwMDAuZXRoZXJuZXQgY29u dHJvbF9ibGFjazogY29uZmlndXJpbmcgZm9yIHBoeS9nbWlpIGxpbmsgbW9kZTxicj4NCiZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxMi43NjE4MDRdIHBwcyBwcHMxOiBuZXcg UFBTIHNvdXJjZSBwdHAxPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKg IDEyLjc2NTM5OF0gbWFjYiBmZjBjMDAwMC5ldGhlcm5ldDogZ2VtLXB0cC10aW1lciBwdHAgY2xv Y2sgcmVnaXN0ZXJlZC48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IEF1dG8t bmVnb3RpYXRpb246IG9mZjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgQXV0 by1uZWdvdGlhdGlvbjogb2ZmPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBb IMKgIDE2LjgyODE1MV0gbWFjYiBmZjBiMDAwMC5ldGhlcm5ldCBjb250cm9sX3JlZDogdW5hYmxl IHRvIGdlbmVyYXRlIHRhcmdldCBmcmVxdWVuY3k6IDEyNTAwMDAwMCBIejxicj4NCiZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxNi44MzQ1NTNdIG1hY2IgZmYwYjAwMDAuZXRo ZXJuZXQgY29udHJvbF9yZWQ6IExpbmsgaXMgVXAgLSAxR2Jwcy9GdWxsIC0gZmxvdyBjb250cm9s IG9mZjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxNi44NjA1NTJd IG1hY2IgZmYwYzAwMDAuZXRoZXJuZXQgY29udHJvbF9ibGFjazogdW5hYmxlIHRvIGdlbmVyYXRl IHRhcmdldCBmcmVxdWVuY3k6IDEyNTAwMDAwMCBIejxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgWyDCoCAxNi44NjcwNTJdIG1hY2IgZmYwYzAwMDAuZXRoZXJuZXQgY29udHJv bF9ibGFjazogTGluayBpcyBVcCAtIDFHYnBzL0Z1bGwgLSBmbG93IGNvbnRyb2wgb2ZmPGJyPg0K Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBTdGFydGluZyBGYWlsc2FmZSBTZWN1cmUg U2hlbGwgc2VydmVyIGluIHBvcnQgMjIyMjogc3NoZDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgZG9uZS48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFN0 YXJ0aW5nIHJwY2JpbmQgZGFlbW9uLi4uZG9uZS48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDE3LjA5 MzAxOV0gcnRjLWxwYzU1IHJ0Y19scGM1NTogbHBjNTVfcnRjX2dldF90aW1lOiBiYWQgcmVzdWx0 OiAxPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBod2Nsb2NrOiBSVENfUkRf VElNRTogSW52YWxpZCBleGNoYW5nZTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgU3RhcnRpbmcgU3RhdGUgTWFuYWdlciBTZXJ2aWNlPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0OyBTdGFydCBzdGF0ZS1tYW5hZ2VyIHJlc3RhcnRlci4uLjxicj4NCiZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgKFhFTikgZDB2MSBGb3J3YXJkaW5nIEFFUyBvcGVy YXRpb246IDMyNTQ3Nzk5NTE8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFN0 YXJ0aW5nIC91c3Ivc2Jpbi94ZW5zdG9yZWQuLi4uWyDCoCAxNy4yNjUyNTZdIEJUUkZTOiBkZXZp Y2UgZnNpZCA4MGVmYzIyNC1jMjAyLTRmOGUtYTk0OS00ZGFlN2YwNGEwYWEgZGV2aWQgMSB0cmFu c2lkIDc0NDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoC9kZXYvZG0tMDxicj4NCiZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgc2Nhbm5lZCBieSB1ZGV2ZCAoMzg1KTxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxNy4zNDk5MzNdIEJUUkZTIGlu Zm8gKGRldmljZSBkbS0wKTogZGlzayBzcGFjZSBjYWNoaW5nIGlzIGVuYWJsZWQ8YnI+DQomZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTcuMzUwNjcwXSBCVFJGUyBpbmZvIChk ZXZpY2UgZG0tMCk6IGhhcyBza2lubnkgZXh0ZW50czxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgWyDCoCAxNy4zNjQzODRdIEJUUkZTIGluZm8gKGRldmljZSBkbS0wKTogZW5h Ymxpbmcgc3NkIG9wdGltaXphdGlvbnM8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IFsgwqAgMTcuODMwNDYyXSBCVFJGUzogZGV2aWNlIGZzaWQgMjdmZjY2NmItZjRlNS00Zjkw LTkwNTQtYzIxMGRiNWIyZTJlIGRldmlkIDEgdHJhbnNpZCA2IC9kZXYvbWFwcGVyL2NsaWVudF9w cm92IHNjYW5uZWQgYnk8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBta2ZzLmJ0cmZz PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoNTI2KTxicj4NCiZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxNy44NzI2OTldIEJUUkZTIGluZm8gKGRldmlj ZSBkbS0xKTogdXNpbmcgZnJlZSBzcGFjZSB0cmVlPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyBbIMKgIDE3Ljg3Mjc3MV0gQlRSRlMgaW5mbyAoZGV2aWNlIGRtLTEpOiBoYXMg c2tpbm55IGV4dGVudHM8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAg MTcuODc4MTE0XSBCVFJGUyBpbmZvIChkZXZpY2UgZG0tMSk6IGZsYWdnaW5nIGZzIHdpdGggYmln IG1ldGFkYXRhIGZlYXR1cmU8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsg wqAgMTcuODk0Mjg5XSBCVFJGUyBpbmZvIChkZXZpY2UgZG0tMSk6IGVuYWJsaW5nIHNzZCBvcHRp bWl6YXRpb25zPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDE3Ljg5 NTY5NV0gQlRSRlMgaW5mbyAoZGV2aWNlIGRtLTEpOiBjaGVja2luZyBVVUlEIHRyZWU8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyBTZXR0aW5nIGRvbWFpbiAwIG5hbWUsIGRvbWlkIGFuZCBKU09OIGNvbmZpZy4u Ljxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgRG9uZSBzZXR0aW5nIHVwIERv bTA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFN0YXJ0aW5nIHhlbmNvbnNv bGVkLi4uPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBTdGFydGluZyBRRU1V IGFzIGRpc2sgYmFja2VuZCBmb3IgZG9tMDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgU3RhcnRpbmcgZG9tYWluIHdhdGNoZG9nIGRhZW1vbjogeGVud2F0Y2hkb2dkIHN0YXJ0 dXA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDE4LjQwODY0N10gQlRSRlM6IGRldmljZSBmc2lkIDVl MDhkNWU5LWJjMmEtNDZiOS1hZjZhLTQ0YzcwODdiODkyMSBkZXZpZCAxIHRyYW5zaWQgNiAvZGV2 L21hcHBlci9jbGllbnRfY29uZmlnIHNjYW5uZWQgYnk8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqBta2ZzLmJ0cmZzPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAo NTc0KTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgW2RvbmVdPGJyPg0KJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDE4LjQ2NTU1Ml0gQlRSRlMgaW5mbyAo ZGV2aWNlIGRtLTIpOiB1c2luZyBmcmVlIHNwYWNlIHRyZWU8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTguNDY1NjI5XSBCVFJGUyBpbmZvIChkZXZpY2UgZG0tMik6 IGhhcyBza2lubnkgZXh0ZW50czxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg WyDCoCAxOC40NzEwMDJdIEJUUkZTIGluZm8gKGRldmljZSBkbS0yKTogZmxhZ2dpbmcgZnMgd2l0 aCBiaWcgbWV0YWRhdGEgZmVhdHVyZTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgU3RhcnRpbmcgY3JvbmQ6IFsgwqAgMTguNDgyMzcxXSBCVFJGUyBpbmZvIChkZXZpY2UgZG0t Mik6IGVuYWJsaW5nIHNzZCBvcHRpbWl6YXRpb25zPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyBbIMKgIDE4LjQ4NjY1OV0gQlRSRlMgaW5mbyAoZGV2aWNlIGRtLTIpOiBjaGVj a2luZyBVVUlEIHRyZWU8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IE9LPGJy Pg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBzdGFydGluZyByc3lzbG9nZCAuLi4g TG9nIHBhcnRpdGlvbiByZWFkeSBhZnRlciAwIHBvbGwgbG9vcHM8YnI+DQomZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7IGRvbmU8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IHJzeXNsb2dkOiBjYW5ub3QgY29ubmVjdCB0byA8YSBocmVmPSJodHRwOi8vMTcyLjE4LjAu MTo1MTQiIHJlbD0ibm9yZWZlcnJlciIgdGFyZ2V0PSJfYmxhbmsiPjE3Mi4xOC4wLjE6NTE0PC9h PiAmbHQ7PGEgaHJlZj0iaHR0cDovLzE3Mi4xOC4wLjE6NTE0IiByZWw9Im5vcmVmZXJyZXIiIHRh cmdldD0iX2JsYW5rIj5odHRwOi8vMTcyLjE4LjAuMTo1MTQ8L2E+Jmd0OzogTmV0d29yayBpcyB1 bnJlYWNoYWJsZSBbdjguMjIwOC4wIHRyeSA8YSBocmVmPSJodHRwczovL3d3dy5yc3lzbG9nLmNv bS9lLzIwMjciIHJlbD0ibm9yZWZlcnJlciIgdGFyZ2V0PSJfYmxhbmsiPmh0dHBzOi8vd3d3LnJz eXNsb2cuY29tL2UvMjAyNzwvYT4gJmx0OzxhIGhyZWY9Imh0dHBzOi8vd3d3LnJzeXNsb2cuY29t L2UvMjAyNyIgcmVsPSJub3JlZmVycmVyIiB0YXJnZXQ9Il9ibGFuayI+aHR0cHM6Ly93d3cucnN5 c2xvZy5jb20vZS8yMDI3PC9hPiZndDsgXTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgWyDCoCAxOC42NzA2MzddIEJUUkZTOiBkZXZpY2UgZnNpZCAzOWQ3ZDllMS05NjdkLTQ3 OGUtOTRhZS02OTBkZWI3MjIwOTUgZGV2aWQgMSB0cmFuc2lkIDYwOCAvZGV2L2RtLTMgc2Nhbm5l ZCBieSB1ZGV2ZCAoNTE4KTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFBsZWFzZSBpbnNlcnQgVVNCIHRva2Vu IGFuZCBlbnRlciB5b3VyIHJvbGUgaW4gbG9naW4gcHJvbXB0Ljxicj4NCiZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IGxv Z2luOjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFJlZ2FyZHMsPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyBPLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyDQv9C9LCAyNCDQsNC/0YAuIDIwMjPigK/Qsy4g0LIgMjM6MzksIFN0ZWZhbm8g U3RhYmVsbGluaSAmbHQ7PGEgaHJlZj0ibWFpbHRvOnNzdGFiZWxsaW5pQGtlcm5lbC5vcmciIHRh cmdldD0iX2JsYW5rIj5zc3RhYmVsbGluaUBrZXJuZWwub3JnPC9hPiAmbHQ7bWFpbHRvOjxhIGhy ZWY9Im1haWx0bzpzc3RhYmVsbGluaUBrZXJuZWwub3JnIiB0YXJnZXQ9Il9ibGFuayI+c3N0YWJl bGxpbmlAa2VybmVsLm9yZzwvYT4mZ3Q7Jmd0Ozo8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqBIaSBPbGVnLDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBI ZXJlIGlzIHRoZSBpc3N1ZSBmcm9tIHlvdXIgbG9nczo8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgU0Vycm9yIEludGVycnVwdCBvbiBDUFUwLCBjb2RlIDB4YmUwMDAwMDAgLS0gU0Vycm9yPGJy Pg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoFNFcnJvcnMgYXJlIHNwZWNpYWwgc2lnbmFscyB0byBu b3RpZnkgc29mdHdhcmUgb2Ygc2VyaW91cyBoYXJkd2FyZTxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoGVycm9ycy7CoCBTb21ldGhpbmcgaXMgZ29pbmcgdmVy eSB3cm9uZy4gRGVmZWN0aXZlIGhhcmR3YXJlIGlzIGE8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBwb3NzaWJpbGl0eS7CoCBBbm90aGVyIHBvc3NpYmlsaXR5 IGlmIHNvZnR3YXJlIGFjY2Vzc2luZyBhZGRyZXNzIHJhbmdlczxicj4NCiZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoHRoYXQgaXQgaXMgbm90IHN1cHBvc2VkIHRvLCBz b21ldGltZXMgaXQgY2F1c2VzIFNFcnJvcnMuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoENo ZWVycyw8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgU3RlZmFubzxicj4NCiZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoE9uIE1vbiwgMjQgQXByIDIwMjMsIE9sZWcgTmlr aXRlbmtvIHdyb3RlOjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IEhlbGxvLDxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFRoYW5rcyBndXlzLjxi cj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgSSBmb3Vu ZCBvdXQgd2hlcmUgdGhlIHByb2JsZW0gd2FzLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDsgTm93IGRvbTAgYm9vdGVkIG1vcmUuIEJ1dCBJIGhhdmUg YSBuZXcgb25lLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgVGhpcyBpcyBhIGtlcm5lbCBwYW5pYyBkdXJpbmcgRG9tMCBsb2FkaW5nLjxicj4NCiZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgTWF5YmUgc29tZW9u ZSBpcyBhYmxlIHRvIHN1Z2dlc3Qgc29tZXRoaW5nID88YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBSZWdhcmRzLDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgTy48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIMKgMy43NzEzNjJdIHNmcF9yZWdpc3Rlcl9idXM6IHVw c3RyZWFtIG9wcyBhdHRhY2g8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjc3NjExOV0gc2ZwX3JlZ2lzdGVyX2J1czogQnVzIHJlZ2lz dGVyZWQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IFsgwqAgwqAzLjc4MDQ1OV0gc2ZwX3JlZ2lzdGVyX3NvY2tldDogcmVnaXN0ZXIgc2ZwX2J1cyBz dWNjZWVkZWQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IFsgwqAgwqAzLjc4OTM5OV0gb2ZfY2ZzX2luaXQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgwqAzLjc4OTQ5OV0gb2ZfY2ZzX2luaXQ6 IE9LPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBb IMKgIMKgMy43OTE2ODVdIGNsazogTm90IGRpc2FibGluZyB1bnVzZWQgY2xvY2tzPGJyPg0KJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDM1 NV0gU0Vycm9yIEludGVycnVwdCBvbiBDUFUwLCBjb2RlIDB4YmUwMDAwMDAgLS0gU0Vycm9yPGJy Pg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDEx LjAxMDM4MF0gQ1BVOiAwIFBJRDogOSBDb21tOiBrd29ya2VyL3U0OjAgTm90IHRhaW50ZWQgNS4x NS43Mi14aWxpbngtdjIwMjIuMSAjMTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxMS4wMTAzOTNdIFdvcmtxdWV1ZTogZXZlbnRzX3VuYm91 bmQgYXN5bmNfcnVuX2VudHJ5X2ZuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDQxNF0gcHN0YXRlOiA2MDAwMDAwNSAoblpDdiBk YWlmIC1QQU4gLVVBTyAtVENPIC1ESVQgLVNTQlMgQlRZUEU9LS0pPGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDQyMl0gcGMgOiBz aW1wbGVfd3JpdGVfZW5kKzB4ZDAvMHgxMzA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNDMxXSBsciA6IGdlbmVyaWNfcGVyZm9y bV93cml0ZSsweDExOC8weDFlMDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgWyDCoCAxMS4wMTA0MzhdIHNwIDogZmZmZmZmYzAwODA5YjkxMDxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxMS4w MTA0NDFdIHgyOTogZmZmZmZmYzAwODA5YjkxMCB4Mjg6IDAwMDAwMDAwMDAwMDAwMDAgeDI3OiBm ZmZmZmZlZjY5YmE4OGMwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyBbIMKgIDExLjAxMDQ1MV0geDI2OiAwMDAwMDAwMDAwMDAzZWVjIHgyNTogZmZm ZmZmODA3NTE1ZGIwMCB4MjQ6IDAwMDAwMDAwMDAwMDAwMDA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNDU5XSB4MjM6IGZmZmZm ZmMwMDgwOWJhOTAgeDIyOiAwMDAwMDAwMDAyYWFjMDAwIHgyMTogZmZmZmZmODA3MzE1YTI2MDxi cj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAx MS4wMTA0NzJdIHgyMDogMDAwMDAwMDAwMDAwMTAwMCB4MTk6IGZmZmZmZmZlMDIwMDAwMDAgeDE4 OiAwMDAwMDAwMDAwMDAwMDAwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDQ4MV0geDE3OiAwMDAwMDAwMGZmZmZmZmZmIHgxNjog MDAwMDAwMDAwMDAwODAwMCB4MTU6IDAwMDAwMDAwMDAwMDAwMDA8YnI+DQomZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNDkwXSB4MTQ6IDAw MDAwMDAwMDAwMDAwMDAgeDEzOiAwMDAwMDAwMDAwMDAwMDAwIHgxMjogMDAwMDAwMDAwMDAwMDAw MDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDC oCAxMS4wMTA0OThdIHgxMTogMDAwMDAwMDAwMDAwMDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAwMDAg eDkgOiAwMDAwMDAwMDAwMDAwMDAwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDUwN10geDggOiAwMDAwMDAwMDAwMDAwMDAwIHg3 IDogZmZmZmZmZWY2OTNiYTY4MCB4NiA6IDAwMDAwMDAwMmQ4OWI3MDA8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNTE1XSB4NSA6 IGZmZmZmZmZlMDIwMDAwMDAgeDQgOiBmZmZmZmY4MDczMTVhM2M4IHgzIDogMDAwMDAwMDAwMDAw MTAwMDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg WyDCoCAxMS4wMTA1MjRdIHgyIDogMDAwMDAwMDAwMmFhYjAwMCB4MSA6IDAwMDAwMDAwMDAwMDAw MDEgeDAgOiAwMDAwMDAwMDAwMDAwMDA1PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDUzNF0gS2VybmVsIHBhbmljIC0gbm90IHN5 bmNpbmc6IEFzeW5jaHJvbm91cyBTRXJyb3IgSW50ZXJydXB0PGJyPg0KJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDUzOV0gQ1BVOiAwIFBJ RDogOSBDb21tOiBrd29ya2VyL3U0OjAgTm90IHRhaW50ZWQgNS4xNS43Mi14aWxpbngtdjIwMjIu MSAjMTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg WyDCoCAxMS4wMTA1NDVdIEhhcmR3YXJlIG5hbWU6IEQxNCBWaXBlciBCb2FyZCAtIFdoaXRlIFVu aXQgKERUKTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgWyDCoCAxMS4wMTA1NDhdIFdvcmtxdWV1ZTogZXZlbnRzX3VuYm91bmQgYXN5bmNfcnVuX2Vu dHJ5X2ZuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 OyBbIMKgIDExLjAxMDU1Nl0gQ2FsbCB0cmFjZTo8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNTU4XSDCoGR1bXBfYmFja3RyYWNl KzB4MC8weDFjNDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgWyDCoCAxMS4wMTA1NjddIMKgc2hvd19zdGFjaysweDE4LzB4MmM8YnI+DQomZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNTc0XSDC oGR1bXBfc3RhY2tfbHZsKzB4N2MvMHhhMDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxMS4wMTA1ODNdIMKgZHVtcF9zdGFjaysweDE4LzB4 MzQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsg wqAgMTEuMDEwNTg4XSDCoHBhbmljKzB4MTRjLzB4MmY4PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDU5N10gwqBwcmludF90YWlu dGVkKzB4MC8weGIwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyBbIMKgIDExLjAxMDYwNl0gwqBhcm02NF9zZXJyb3JfcGFuaWMrMHg2Yy8weDdjPGJy Pg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDEx LjAxMDYxNF0gwqBkb19zZXJyb3IrMHgyOC8weDYwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDYyMV0gwqBlbDFoXzY0X2Vycm9y X2hhbmRsZXIrMHgzMC8weDUwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDYyOF0gwqBlbDFoXzY0X2Vycm9yKzB4NzgvMHg3Yzxi cj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAx MS4wMTA2MzNdIMKgc2ltcGxlX3dyaXRlX2VuZCsweGQwLzB4MTMwPGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDYzOV0gwqBnZW5l cmljX3BlcmZvcm1fd3JpdGUrMHgxMTgvMHgxZTA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNjQ0XSDCoF9fZ2VuZXJpY19maWxl X3dyaXRlX2l0ZXIrMHgxMzgvMHgxYzQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNjUwXSDCoGdlbmVyaWNfZmlsZV93cml0ZV9p dGVyKzB4NzgvMHhkMDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDsgWyDCoCAxMS4wMTA2NTZdIMKgX19rZXJuZWxfd3JpdGUrMHhmYy8weDJhYzxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxMS4w MTA2NjVdIMKga2VybmVsX3dyaXRlKzB4ODgvMHgxNjA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNjczXSDCoHh3cml0ZSsweDQ0 LzB4OTQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IFsgwqAgMTEuMDEwNjgwXSDCoGRvX2NvcHkrMHhhOC8weDEwNDxicj4NCiZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxMS4wMTA2ODZdIMKgd3JpdGVf YnVmZmVyKzB4MzgvMHg1ODxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgWyDCoCAxMS4wMTA2OTJdIMKgZmx1c2hfYnVmZmVyKzB4NGMvMHhiYzxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxMS4w MTA2OThdIMKgX19ndW56aXArMHgyODAvMHgzMTA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNzA0XSDCoGd1bnppcCsweDFjLzB4 Mjg8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsg wqAgMTEuMDEwNzA5XSDCoHVucGFja190b19yb290ZnMrMHgxNzAvMHgyYjA8YnI+DQomZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNzE1XSDC oGRvX3BvcHVsYXRlX3Jvb3RmcysweDgwLzB4MTY0PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDcyMl0gwqBhc3luY19ydW5fZW50 cnlfZm4rMHg0OC8weDE2NDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgWyDCoCAxMS4wMTA3MjhdIMKgcHJvY2Vzc19vbmVfd29yaysweDFlNC8weDNh MDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDC oCAxMS4wMTA3MzZdIMKgd29ya2VyX3RocmVhZCsweDdjLzB4NGMwPGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjAxMDc0M10gwqBrdGhy ZWFkKzB4MTIwLzB4MTMwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyBbIMKgIDExLjAxMDc1MF0gwqByZXRfZnJvbV9mb3JrKzB4MTAvMHgyMDxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoCAxMS4w MTA3NTddIFNNUDogc3RvcHBpbmcgc2Vjb25kYXJ5IENQVXM8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNzg0XSBLZXJuZWwgT2Zm c2V0OiAweDJmNjEyMDAwMDAgZnJvbSAweGZmZmZmZmMwMDgwMDAwMDA8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqAgMTEuMDEwNzg4XSBQSFlT X09GRlNFVDogMHgwPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyBbIMKgIDExLjAxMDc5MF0gQ1BVIGZlYXR1cmVzOiAweDAwMDAwNDAxLDAwMDAwODQy PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKg IDExLjAxMDc5NV0gTWVtb3J5IExpbWl0OiBub25lPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgIDExLjI3NzUwOV0gLS0tWyBlbmQgS2VybmVs IHBhbmljIC0gbm90IHN5bmNpbmc6IEFzeW5jaHJvbm91cyBTRXJyb3IgSW50ZXJydXB0IF0tLS08 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0K Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDQv9GCLCAyMSDQ sNC/0YAuIDIwMjPigK/Qsy4g0LIgMTU6NTIsIE1pY2hhbCBPcnplbCAmbHQ7PGEgaHJlZj0ibWFp bHRvOm1pY2hhbC5vcnplbEBhbWQuY29tIiB0YXJnZXQ9Il9ibGFuayI+bWljaGFsLm9yemVsQGFt ZC5jb208L2E+ICZsdDttYWlsdG86PGEgaHJlZj0ibWFpbHRvOm1pY2hhbC5vcnplbEBhbWQuY29t IiB0YXJnZXQ9Il9ibGFuayI+bWljaGFsLm9yemVsQGFtZC5jb208L2E+Jmd0OyZndDs6PGJyPg0K Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg SGkgT2xlZyw8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgT24gMjEvMDQvMjAyMyAxNDo0OSwgT2xlZyBOaWtpdGVua28gd3JvdGU6PGJyPg0K Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IEhlbGxvIE1pY2hh bCw8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBJIHdhcyBub3QgYWJsZSB0byBlbmFibGUgZWFybHlwcmlu dGsgaW4gdGhlIHhlbiBmb3Igbm93Ljxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgSSBkZWNpZGVkIHRvIGNob29zZSBhbm90 aGVyIHdheS48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7IFRoaXMgaXMgYSB4ZW4mIzM5O3MgY29tbWFuZCBsaW5lIHRoYXQg SSBmb3VuZCBvdXQgY29tcGxldGVseS48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAoWEVOKSAkJCQkIGNv bnNvbGU9ZHR1YXJ0IGR0dWFydD1zZXJpYWwwIGRvbTBfbWVtPTE2MDBNIGRvbTBfbWF4X3ZjcHVz PTIgZG9tMF92Y3B1c19waW4gYm9vdHNjcnViPTA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqB2d2ZpPW5hdGl2ZTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoHNjaGVkPW51bGw8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqB0aW1lcl9zbG9wPTA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBZZXMsIGFkZGluZyBhIHBy aW50aygpIGluIFhlbiB3YXMgYWxzbyBhIGdvb2QgaWRlYS48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgU28geW91 IGFyZSBhYnNvbHV0ZWx5IHJpZ2h0IGFib3V0IGEgY29tbWFuZCBsaW5lLjxicj4NCiZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgTm93 IEkgYW0gZ29pbmcgdG8gZmluZCBvdXQgd2h5IHhlbiBkaWQgbm90IGhhdmUgdGhlIGNvcnJlY3Qg cGFyYW1ldGVycyBmcm9tIHRoZSBkZXZpY2UgdHJlZS48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBNYXliZSB5b3Ugd2lsbCBmaW5k IHRoaXMgZG9jdW1lbnQgaGVscGZ1bDo8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqA8YSBocmVmPSJodHRwczovL2dpdGh1Yi5jb20v WGlsaW54L3hlbi9ibG9iL3hsbnhfcmViYXNlXzQuMTYvZG9jcy9taXNjL2FybS9kZXZpY2UtdHJl ZS9ib290aW5nLnR4dCIgcmVsPSJub3JlZmVycmVyIiB0YXJnZXQ9Il9ibGFuayI+aHR0cHM6Ly9n aXRodWIuY29tL1hpbGlueC94ZW4vYmxvYi94bG54X3JlYmFzZV80LjE2L2RvY3MvbWlzYy9hcm0v ZGV2aWNlLXRyZWUvYm9vdGluZy50eHQ8L2E+ICZsdDs8YSBocmVmPSJodHRwczovL2dpdGh1Yi5j b20vWGlsaW54L3hlbi9ibG9iL3hsbnhfcmViYXNlXzQuMTYvZG9jcy9taXNjL2FybS9kZXZpY2Ut dHJlZS9ib290aW5nLnR4dCIgcmVsPSJub3JlZmVycmVyIiB0YXJnZXQ9Il9ibGFuayI+aHR0cHM6 Ly9naXRodWIuY29tL1hpbGlueC94ZW4vYmxvYi94bG54X3JlYmFzZV80LjE2L2RvY3MvbWlzYy9h cm0vZGV2aWNlLXRyZWUvYm9vdGluZy50eHQ8L2E+Jmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqB+TWljaGFsPGJyPg0KJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IFJlZ2FyZHMsPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0OyBPbGVnPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg0L/RgiwgMjEg0LDQ v9GALiAyMDIz4oCv0LMuINCyIDExOjE2LCBNaWNoYWwgT3J6ZWwgJmx0OzxhIGhyZWY9Im1haWx0 bzptaWNoYWwub3J6ZWxAYW1kLmNvbSIgdGFyZ2V0PSJfYmxhbmsiPm1pY2hhbC5vcnplbEBhbWQu Y29tPC9hPiAmbHQ7bWFpbHRvOjxhIGhyZWY9Im1haWx0bzptaWNoYWwub3J6ZWxAYW1kLmNvbSIg dGFyZ2V0PSJfYmxhbmsiPm1pY2hhbC5vcnplbEBhbWQuY29tPC9hPiZndDsgJmx0O21haWx0bzo8 YSBocmVmPSJtYWlsdG86bWljaGFsLm9yemVsQGFtZC5jb20iIHRhcmdldD0iX2JsYW5rIj5taWNo YWwub3J6ZWxAYW1kLmNvbTwvYT4gJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86bWljaGFsLm9y emVsQGFtZC5jb20iIHRhcmdldD0iX2JsYW5rIj5taWNoYWwub3J6ZWxAYW1kLmNvbTwvYT4mZ3Q7 Jmd0OyZndDs6PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqBPbiAyMS8wNC8y MDIzIDEwOjA0LCBPbGVnIE5pa2l0ZW5rbyB3cm90ZTo8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0Ozxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCZndDsgSGVsbG8gTWljaGFsLDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDs8YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAmZ3Q7IFllcywgSSB1c2UgeW9jdG8uPGJyPg0KJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0 Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCZndDsgWWVzdGVyZGF5IGFsbCBkYXkgbG9uZyBJIHRyaWVkIHRv IGZvbGxvdyB5b3VyIHN1Z2dlc3Rpb25zLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDsgSSBmYWNlZCBh IHByb2JsZW0uPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0OyBNYW51YWxseSBpbiB0aGUgeGVuIGNvbmZp ZyBidWlsZCBmaWxlIEkgcGFzdGVkIHRoZSBzdHJpbmdzOjxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoEluIHRo ZSAuY29uZmlnIGZpbGUgb3IgaW4gc29tZSBZb2N0byBmaWxlIChsaXN0aW5nIGFkZGl0aW9uYWwg S2NvbmZpZyBvcHRpb25zKSBhZGRlZCB0byBTUkNfVVJJPzxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoFlvdSBz aG91bGRuJiMzOTt0IHJlYWxseSBtb2RpZnkgLmNvbmZpZyBmaWxlIGJ1dCBpZiB5b3UgZG8sIHlv dSBzaG91bGQgZXhlY3V0ZSAmcXVvdDttYWtlIG9sZGRlZmNvbmZpZyZxdW90Ozxicj4NCiZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoGFmdGVyd2FyZHMuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7IENPTkZJR19FQVJMWV9QUklOVEs8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAmZ3Q7IENPTkZJR19FQVJMWV9QUklOVEtfWllOUU1QPGJyPg0KJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgJmd0OyBDT05GSUdfRUFSTFlfVUFSVF9DSE9JQ0VfQ0FERU5DRTxicj4NCiZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oEkgaG9wZSB5b3UgYWRkZWQgPXkgdG8gdGhlbS48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg QW55d2F5LCB5b3UgaGF2ZSBhdCBsZWFzdCB0aGUgZm9sbG93aW5nIHNvbHV0aW9uczo8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAxKSBSdW4gYml0YmFrZSB4ZW4gLWMgbWVudWNvbmZpZyB0byBwcm9wZXJseSBz ZXQgZWFybHkgcHJpbnRrPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgMikgRmluZCBvdXQgaG93IHlvdSBlbmFi bGUgb3RoZXIgS2NvbmZpZyBvcHRpb25zIGluIHlvdXIgcHJvamVjdCAoZS5nLiBDT05GSUdfQ09M T1JJTkc9eSB0aGF0IGlzIG5vdDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoGVuYWJs ZWQgYnk8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBkZWZh dWx0KTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoDMpIEFwcGVuZCB0aGUgZm9sbG93aW5nIHRvICZxdW90O3hl bi9hcmNoL2FybS9jb25maWdzL2FybTY0X2RlZmNvbmZpZyZxdW90Ozo8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqBDT05GSUdfRUFSTFlfUFJJTlRLX1pZTlFNUD15PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oH5NaWNoYWw8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCZndDsgSG9zdCBoYW5ncyBpbiBidWlsZCB0aW1lLsKgPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0OyBN YXliZSBJIGRpZCBub3Qgc2V0IHNvbWV0aGluZyBpbiB0aGUgY29uZmlnIGJ1aWxkIGZpbGUgPzxi cj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7IFJlZ2FyZHMsPGJyPg0K Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgJmd0OyBPbGVnPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCZndDsg0YfRgiwgMjAg0LDQv9GALiAyMDIz4oCv0LMuINCyIDExOjU3LCBPbGVnIE5pa2l0 ZW5rbyAmbHQ7PGEgaHJlZj0ibWFpbHRvOm9sZXNoaWl3b29kQGdtYWlsLmNvbSIgdGFyZ2V0PSJf YmxhbmsiPm9sZXNoaWl3b29kQGdtYWlsLmNvbTwvYT4gJmx0O21haWx0bzo8YSBocmVmPSJtYWls dG86b2xlc2hpaXdvb2RAZ21haWwuY29tIiB0YXJnZXQ9Il9ibGFuayI+b2xlc2hpaXdvb2RAZ21h aWwuY29tPC9hPiZndDsgJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86b2xlc2hpaXdvb2RAZ21h aWwuY29tIiB0YXJnZXQ9Il9ibGFuayI+b2xlc2hpaXdvb2RAZ21haWwuY29tPC9hPiAmbHQ7bWFp bHRvOjxhIGhyZWY9Im1haWx0bzpvbGVzaGlpd29vZEBnbWFpbC5jb20iIHRhcmdldD0iX2JsYW5r Ij5vbGVzaGlpd29vZEBnbWFpbC5jb208L2E+Jmd0OyZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmbHQ7bWFpbHRvOjxhIGhy ZWY9Im1haWx0bzpvbGVzaGlpd29vZEBnbWFpbC5jb20iIHRhcmdldD0iX2JsYW5rIj5vbGVzaGlp d29vZEBnbWFpbC5jb208L2E+ICZsdDttYWlsdG86PGEgaHJlZj0ibWFpbHRvOm9sZXNoaWl3b29k QGdtYWlsLmNvbSIgdGFyZ2V0PSJfYmxhbmsiPm9sZXNoaWl3b29kQGdtYWlsLmNvbTwvYT4mZ3Q7 ICZsdDttYWlsdG86PGEgaHJlZj0ibWFpbHRvOm9sZXNoaWl3b29kQGdtYWlsLmNvbSIgdGFyZ2V0 PSJfYmxhbmsiPm9sZXNoaWl3b29kQGdtYWlsLmNvbTwvYT4gJmx0O21haWx0bzo8YSBocmVmPSJt YWlsdG86b2xlc2hpaXdvb2RAZ21haWwuY29tIiB0YXJnZXQ9Il9ibGFuayI+b2xlc2hpaXdvb2RA Z21haWwuY29tPC9hPiZndDsmZ3Q7Jmd0OyZndDs6PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0Ozxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoFRoYW5rcyBNaWNoYWwsPGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg Jmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoFlvdSBnYXZlIG1lIGFuIGlkZWEuPGJy Pg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgSSBhbSBnb2luZyB0byB0cnkgaXQgdG9kYXkuPGJy Pg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoFJlZ2FyZHMs PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgTy48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7PGJy Pg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg0YfRgiwgMjAg0LDQv9GALiAyMDIz4oCv0LMuINCy IDExOjU2LCBPbGVnIE5pa2l0ZW5rbyAmbHQ7PGEgaHJlZj0ibWFpbHRvOm9sZXNoaWl3b29kQGdt YWlsLmNvbSIgdGFyZ2V0PSJfYmxhbmsiPm9sZXNoaWl3b29kQGdtYWlsLmNvbTwvYT4gJmx0O21h aWx0bzo8YSBocmVmPSJtYWlsdG86b2xlc2hpaXdvb2RAZ21haWwuY29tIiB0YXJnZXQ9Il9ibGFu ayI+b2xlc2hpaXdvb2RAZ21haWwuY29tPC9hPiZndDsgJmx0O21haWx0bzo8YSBocmVmPSJtYWls dG86b2xlc2hpaXdvb2RAZ21haWwuY29tIiB0YXJnZXQ9Il9ibGFuayI+b2xlc2hpaXdvb2RAZ21h aWwuY29tPC9hPiAmbHQ7bWFpbHRvOjxhIGhyZWY9Im1haWx0bzpvbGVzaGlpd29vZEBnbWFpbC5j b20iIHRhcmdldD0iX2JsYW5rIj5vbGVzaGlpd29vZEBnbWFpbC5jb208L2E+Jmd0OyZndDs8YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmbHQ7bWFpbHRvOjxhIGhyZWY9Im1haWx0bzpvbGVzaGlpd29vZEBnbWFpbC5jb20iIHRhcmdl dD0iX2JsYW5rIj5vbGVzaGlpd29vZEBnbWFpbC5jb208L2E+ICZsdDttYWlsdG86PGEgaHJlZj0i bWFpbHRvOm9sZXNoaWl3b29kQGdtYWlsLmNvbSIgdGFyZ2V0PSJfYmxhbmsiPm9sZXNoaWl3b29k QGdtYWlsLmNvbTwvYT4mZ3Q7ICZsdDttYWlsdG86PGEgaHJlZj0ibWFpbHRvOm9sZXNoaWl3b29k QGdtYWlsLmNvbSIgdGFyZ2V0PSJfYmxhbmsiPm9sZXNoaWl3b29kQGdtYWlsLmNvbTwvYT4gJmx0 O21haWx0bzo8YSBocmVmPSJtYWlsdG86b2xlc2hpaXdvb2RAZ21haWwuY29tIiB0YXJnZXQ9Il9i bGFuayI+b2xlc2hpaXdvb2RAZ21haWwuY29tPC9hPiZndDsmZ3Q7Jmd0OyZndDs6PGJyPg0KJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoFRoYW5rcyBT dGVmYW5vLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAgwqBJIGFtIGdvaW5nIHRvIGRvIGl0IHRvZGF5Ljxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDs8 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqBSZWdhcmRzLDxicj4NCiZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCDCoE8uPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0Ozxicj4NCiZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoNGB0YAsIDE5INCw0L/RgC4gMjAyM+KAr9CzLiDQsiAy MzowNSwgU3RlZmFubyBTdGFiZWxsaW5pICZsdDs8YSBocmVmPSJtYWlsdG86c3N0YWJlbGxpbmlA a2VybmVsLm9yZyIgdGFyZ2V0PSJfYmxhbmsiPnNzdGFiZWxsaW5pQGtlcm5lbC5vcmc8L2E+ICZs dDttYWlsdG86PGEgaHJlZj0ibWFpbHRvOnNzdGFiZWxsaW5pQGtlcm5lbC5vcmciIHRhcmdldD0i X2JsYW5rIj5zc3RhYmVsbGluaUBrZXJuZWwub3JnPC9hPiZndDs8YnI+DQomZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmbHQ7bWFpbHRvOjxhIGhyZWY9Im1haWx0bzpzc3RhYmVsbGluaUBrZXJu ZWwub3JnIiB0YXJnZXQ9Il9ibGFuayI+c3N0YWJlbGxpbmlAa2VybmVsLm9yZzwvYT4gJmx0O21h aWx0bzo8YSBocmVmPSJtYWlsdG86c3N0YWJlbGxpbmlAa2VybmVsLm9yZyIgdGFyZ2V0PSJfYmxh bmsiPnNzdGFiZWxsaW5pQGtlcm5lbC5vcmc8L2E+Jmd0OyZndDs8YnI+DQomZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmbHQ7bWFpbHRvOjxh IGhyZWY9Im1haWx0bzpzc3RhYmVsbGluaUBrZXJuZWwub3JnIiB0YXJnZXQ9Il9ibGFuayI+c3N0 YWJlbGxpbmlAa2VybmVsLm9yZzwvYT4gJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86c3N0YWJl bGxpbmlAa2VybmVsLm9yZyIgdGFyZ2V0PSJfYmxhbmsiPnNzdGFiZWxsaW5pQGtlcm5lbC5vcmc8 L2E+Jmd0OyAmbHQ7bWFpbHRvOjxhIGhyZWY9Im1haWx0bzpzc3RhYmVsbGluaUBrZXJuZWwub3Jn IiB0YXJnZXQ9Il9ibGFuayI+c3N0YWJlbGxpbmlAa2VybmVsLm9yZzwvYT4gJmx0O21haWx0bzo8 YSBocmVmPSJtYWlsdG86c3N0YWJlbGxpbmlAa2VybmVsLm9yZyIgdGFyZ2V0PSJfYmxhbmsiPnNz dGFiZWxsaW5pQGtlcm5lbC5vcmc8L2E+Jmd0OyZndDsmZ3Q7Jmd0Ozo8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgT24gV2VkLCAx OSBBcHIgMjAyMywgT2xlZyBOaWtpdGVua28gd3JvdGU6PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgIMKgIMKgIMKgJmd0OyBIaSBNaWNoYWwsPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDC oCDCoCDCoCZndDsgSSBjb3JyZWN0ZWQgeGVuJiMzOTtzIGNvbW1hbmQgbGluZS48YnI+DQomZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7IE5vdyBpdCBpczxicj4NCiZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDsgeGVuLHhlbi1ib290YXJncyA9ICZx dW90O2NvbnNvbGU9ZHR1YXJ0IGR0dWFydD1zZXJpYWwwIGRvbTBfbWVtPTE2MDBNIGRvbTBfbWF4 X3ZjcHVzPTI8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBkb20wX3ZjcHVzX3Bpbjxi cj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoGJvb3RzY3J1Yj0wIHZ3Zmk9bmF0aXZlIHNjaGVkPW51bGw8YnI+DQomZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7IHRpbWVyX3Nsb3A9MCB3YXlfc2l6ZT02NTUzNiB4 ZW5fY29sb3JzPTAtMyBkb20wX2NvbG9ycz00LTcmcXVvdDs7PGJyPg0KJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0 Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoDQgY29sb3JzIGlzIHdh eSB0b28gbWFueSBmb3IgeGVuLCBqdXN0IGRvIHhlbl9jb2xvcnM9MC0wLiBUaGVyZSBpcyBubzxi cj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoGFkdmFudGFnZSBpbiB1c2lu ZyBtb3JlIHRoYW4gMSBjb2xvciBmb3IgWGVuLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDs8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqA0IGNvbG9ycyBpcyB0b28gZmV3IGZv ciBkb20wLCBpZiB5b3UgYXJlIGdpdmluZyAxNjAwTSBvZiBtZW1vcnkgdG8gRG9tMC48YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqBFYWNoIGNvbG9yIGlzIDI1Nk0uIEZv ciAxNjAwTSB5b3Ugc2hvdWxkIGdpdmUgYXQgbGVhc3QgNyBjb2xvcnMuIFRyeTo8YnI+DQomZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgeGVu X2NvbG9ycz0wLTAgZG9tMF9jb2xvcnM9MS04PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0Ozxicj4NCiZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0OyBVbmZvcnR1bmF0ZWx5IHRoZSByZXN1bHQgd2FzIHRo ZSBzYW1lLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDs8YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7IChYRU4pIMKgLSBEb20w IG1vZGU6IFJlbGF4ZWQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAm Z3Q7IChYRU4pIFAyTTogNDAtYml0IElQQSB3aXRoIDQwLWJpdCBQQSBhbmQgOC1iaXQgVk1JRDxi cj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDsgKFhFTikgUDJNOiAz IGxldmVscyB3aXRoIG9yZGVyLTEgcm9vdCwgVlRDUiAweDAwMDAwMDAwODAwMjM1NTg8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7IChYRU4pIFNjaGVkdWxpbmcg Z3JhbnVsYXJpdHk6IGNwdSwgMSBDUFUgcGVyIHNjaGVkLXJlc291cmNlPGJyPg0KJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0OyAoWEVOKSBDb2xvcmluZyBnZW5lcmFsIGlu Zm9ybWF0aW9uPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0OyAo WEVOKSBXYXkgc2l6ZTogNjRrQjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDC oCDCoCZndDsgKFhFTikgTWF4LiBudW1iZXIgb2YgY29sb3JzIGF2YWlsYWJsZTogMTY8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7IChYRU4pIFhlbiBjb2xvcihz KTogWyAwIF08YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7IChY RU4pIGFsdGVybmF0aXZlczogUGF0Y2hpbmcgd2l0aCBhbHQgdGFibGUgMDAwMDAwMDAwMDJjYzY5 MCAtJmd0OyAwMDAwMDAwMDAwMmNjYzBjPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKg IMKgIMKgIMKgJmd0OyAoWEVOKSBDb2xvciBhcnJheSBhbGxvY2F0aW9uIGZhaWxlZCBmb3IgZG9t MDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDsgKFhFTik8YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7IChYRU4pICoqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKio8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAgwqAgwqAgwqAmZ3Q7IChYRU4pIFBhbmljIG9uIENQVSAwOjxicj4NCiZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDsgKFhFTikgRXJyb3IgY3JlYXRpbmcgZG9t YWluIDA8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7IChYRU4p ICoqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKio8YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7IChYRU4pPGJyPg0KJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0OyAoWEVOKSBSZWJvb3QgaW4gZml2ZSBzZWNvbmRzLi4u PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDsgSSBhbSBnb2luZyB0byBmaW5kIG91 dCBob3cgY29tbWFuZCBsaW5lIGFyZ3VtZW50cyBwYXNzZWQgYW5kIHBhcnNlZC48YnI+DQomZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0OyBSZWdhcmRzLDxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCDCoCDCoCDCoCZndDsgT2xlZzxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAg wqAmZ3Q7INGB0YAsIDE5INCw0L/RgC4gMjAyM+KAr9CzLiDQsiAxMToyNSwgT2xlZyBOaWtpdGVu a28gJmx0OzxhIGhyZWY9Im1haWx0bzpvbGVzaGlpd29vZEBnbWFpbC5jb20iIHRhcmdldD0iX2Js YW5rIj5vbGVzaGlpd29vZEBnbWFpbC5jb208L2E+ICZsdDttYWlsdG86PGEgaHJlZj0ibWFpbHRv Om9sZXNoaWl3b29kQGdtYWlsLmNvbSIgdGFyZ2V0PSJfYmxhbmsiPm9sZXNoaWl3b29kQGdtYWls LmNvbTwvYT4mZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmx0O21haWx0bzo8 YSBocmVmPSJtYWlsdG86b2xlc2hpaXdvb2RAZ21haWwuY29tIiB0YXJnZXQ9Il9ibGFuayI+b2xl c2hpaXdvb2RAZ21haWwuY29tPC9hPiAmbHQ7bWFpbHRvOjxhIGhyZWY9Im1haWx0bzpvbGVzaGlp d29vZEBnbWFpbC5jb20iIHRhcmdldD0iX2JsYW5rIj5vbGVzaGlpd29vZEBnbWFpbC5jb208L2E+ Jmd0OyZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmbHQ7bWFpbHRvOjxhIGhyZWY9Im1haWx0bzpvbGVzaGlpd29vZEBnbWFp bC5jb20iIHRhcmdldD0iX2JsYW5rIj5vbGVzaGlpd29vZEBnbWFpbC5jb208L2E+ICZsdDttYWls dG86PGEgaHJlZj0ibWFpbHRvOm9sZXNoaWl3b29kQGdtYWlsLmNvbSIgdGFyZ2V0PSJfYmxhbmsi Pm9sZXNoaWl3b29kQGdtYWlsLmNvbTwvYT4mZ3Q7ICZsdDttYWlsdG86PGEgaHJlZj0ibWFpbHRv Om9sZXNoaWl3b29kQGdtYWlsLmNvbSIgdGFyZ2V0PSJfYmxhbmsiPm9sZXNoaWl3b29kQGdtYWls LmNvbTwvYT4gJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86b2xlc2hpaXdvb2RAZ21haWwuY29t IiB0YXJnZXQ9Il9ibGFuayI+b2xlc2hpaXdvb2RAZ21haWwuY29tPC9hPiZndDsmZ3Q7Jmd0OyZn dDs6PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgSGkgTWljaGFsLDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZn dDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7IFlvdSBwdXQg bXkgbm9zZSBpbnRvIHRoZSBwcm9ibGVtLiBUaGFuayB5b3UuPGJyPg0KJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0OyBJIGFtIGdvaW5nIHRvIHVzZSB5b3VyIHBvaW50Ljxi cj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDsgTGV0JiMzOTtzIHNl ZSB3aGF0IGhhcHBlbnMuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKg Jmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDsgUmVnYXJk cyw8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7IE9sZWc8YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCDCoCDCoCDCoCZndDsg0YHRgCwgMTkg0LDQv9GALiAyMDIz4oCv0LMuINCyIDEwOjM3 LCBNaWNoYWwgT3J6ZWwgJmx0OzxhIGhyZWY9Im1haWx0bzptaWNoYWwub3J6ZWxAYW1kLmNvbSIg dGFyZ2V0PSJfYmxhbmsiPm1pY2hhbC5vcnplbEBhbWQuY29tPC9hPiAmbHQ7bWFpbHRvOjxhIGhy ZWY9Im1haWx0bzptaWNoYWwub3J6ZWxAYW1kLmNvbSIgdGFyZ2V0PSJfYmxhbmsiPm1pY2hhbC5v cnplbEBhbWQuY29tPC9hPiZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmbHQ7 bWFpbHRvOjxhIGhyZWY9Im1haWx0bzptaWNoYWwub3J6ZWxAYW1kLmNvbSIgdGFyZ2V0PSJfYmxh bmsiPm1pY2hhbC5vcnplbEBhbWQuY29tPC9hPiAmbHQ7bWFpbHRvOjxhIGhyZWY9Im1haWx0bzpt aWNoYWwub3J6ZWxAYW1kLmNvbSIgdGFyZ2V0PSJfYmxhbmsiPm1pY2hhbC5vcnplbEBhbWQuY29t PC9hPiZndDsmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86bWljaGFsLm9yemVs QGFtZC5jb20iIHRhcmdldD0iX2JsYW5rIj5taWNoYWwub3J6ZWxAYW1kLmNvbTwvYT4gJmx0O21h aWx0bzo8YSBocmVmPSJtYWlsdG86bWljaGFsLm9yemVsQGFtZC5jb20iIHRhcmdldD0iX2JsYW5r Ij5taWNoYWwub3J6ZWxAYW1kLmNvbTwvYT4mZ3Q7ICZsdDttYWlsdG86PGEgaHJlZj0ibWFpbHRv Om1pY2hhbC5vcnplbEBhbWQuY29tIiB0YXJnZXQ9Il9ibGFuayI+bWljaGFsLm9yemVsQGFtZC5j b208L2E+ICZsdDttYWlsdG86PGEgaHJlZj0ibWFpbHRvOm1pY2hhbC5vcnplbEBhbWQuY29tIiB0 YXJnZXQ9Il9ibGFuayI+bWljaGFsLm9yemVsQGFtZC5jb208L2E+Jmd0OyZndDsmZ3Q7Jmd0Ozo8 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBI aSBPbGVnLDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDs8YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBPbiAx OS8wNC8yMDIzIDA5OjAzLCBPbGVnIE5pa2l0ZW5rbyB3cm90ZTo8YnI+DQomZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqA8YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDsgSGVsbG8gU3RlZmFubyw8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBUaGFua3MgZm9yIHRoZSBjbGFyaWZpY2F0 aW9uLjxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDsgTXkgY29tcGFueSB1c2VzIHlvY3RvIGZvciBpbWFnZSBnZW5lcmF0aW9uLjxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg V2hhdCBraW5kIG9mIGluZm9ybWF0aW9uIGRvIHlvdSBuZWVkIHRvIGNvbnN1bHQgbWUgaW4gdGhp cyBjYXNlID88YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0OyBNYXliZSBtb2R1bGVzIHNpemVzL2FkZHJlc3NlcyB3aGljaCB3ZXJl IG1lbnRpb25lZCBieSBASnVsaWVuIEdyYWxsPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86anVsaWVuQHhlbi5v cmciIHRhcmdldD0iX2JsYW5rIj5qdWxpZW5AeGVuLm9yZzwvYT4gJmx0O21haWx0bzo8YSBocmVm PSJtYWlsdG86anVsaWVuQHhlbi5vcmciIHRhcmdldD0iX2JsYW5rIj5qdWxpZW5AeGVuLm9yZzwv YT4mZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86anVsaWVuQHhlbi5vcmciIHRh cmdldD0iX2JsYW5rIj5qdWxpZW5AeGVuLm9yZzwvYT4gJmx0O21haWx0bzo8YSBocmVmPSJtYWls dG86anVsaWVuQHhlbi5vcmciIHRhcmdldD0iX2JsYW5rIj5qdWxpZW5AeGVuLm9yZzwvYT4mZ3Q7 Jmd0OyAmbHQ7bWFpbHRvOjxhIGhyZWY9Im1haWx0bzpqdWxpZW5AeGVuLm9yZyIgdGFyZ2V0PSJf YmxhbmsiPmp1bGllbkB4ZW4ub3JnPC9hPiAmbHQ7bWFpbHRvOjxhIGhyZWY9Im1haWx0bzpqdWxp ZW5AeGVuLm9yZyIgdGFyZ2V0PSJfYmxhbmsiPmp1bGllbkB4ZW4ub3JnPC9hPiZndDsgJmx0O21h aWx0bzo8YSBocmVmPSJtYWlsdG86anVsaWVuQHhlbi5vcmciIHRhcmdldD0iX2JsYW5rIj5qdWxp ZW5AeGVuLm9yZzwvYT4gJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86anVsaWVuQHhlbi5vcmci IHRhcmdldD0iX2JsYW5rIj5qdWxpZW5AeGVuLm9yZzwvYT4mZ3Q7Jmd0OyZndDsmZ3Q7ID88YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgU29ycnkgZm9yIGp1bXBp bmcgaW50byBkaXNjdXNzaW9uLCBidXQgRldJQ1MgdGhlIFhlbiBjb21tYW5kIGxpbmUgeW91IHBy b3ZpZGVkPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgc2VlbXMgdG8gYmU8YnI+DQom Z3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBub3QgdGhlPGJyPg0KJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgb25l PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg WGVuIGJvb3RlZCB3aXRoLiBUaGUgZXJyb3IgeW91IGFyZSBvYnNlcnZpbmcgbW9zdCBsaWtlbHkg aXMgZHVlIHRvIGRvbTAgY29sb3JzPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgY29uZmlndXJhdGlvbiBub3Q8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBiZWluZzxicj4NCiZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoHNwZWNpZmllZCAoaS5lLiBs YWNrIG9mIGRvbTBfY29sb3JzPSZsdDsmZ3Q7IHBhcmFtZXRlcikuIEFsdGhvdWdoIGluIHRoZSBj b21tYW5kIGxpbmUgeW91PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgcHJvdmlkZWQsIHRoaXM8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBwYXJhbWV0ZXI8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBpcyBzZXQsIEkgc3Ryb25nbHkgZG91 YnQgdGhhdCB0aGlzIGlzIHRoZSBhY3R1YWwgY29tbWFuZCBsaW5lIGluIHVzZS48YnI+DQomZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgWW91IHdyb3RlOjxicj4NCiZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoHhlbix4ZW4tYm9v dGFyZ3MgPSAmcXVvdDtjb25zb2xlPWR0dWFydCBkdHVhcnQ9c2VyaWFsMCBkb20wX21lbT0xNjAw TSBkb20wX21heF92Y3B1cz0yPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgZG9tMF92Y3B1c19waW48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBib290c2NydWI9MCB2d2ZpPW5hdGl2ZTxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoHNjaGVk PW51bGwgdGltZXJfc2xvcD0wIHdheV9zeml6ZT02NTUzNiB4ZW5fY29sb3JzPTAtMyBkb20wX2Nv bG9ycz00LTcmcXVvdDs7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKg Jmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoGJ1dDo8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAxKSB3YXlfc3ppemUgaGFzIGEgdHlwbzxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoDIpIHlvdSBzcGVjaWZpZWQgNCBjb2xvcnMg KDAtMykgZm9yIFhlbiwgYnV0IHRoZSBib290IGxvZyBzYXlzIHRoYXQgWGVuIGhhcyBvbmx5PGJy Pg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgb25lOjxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoChYRU4pIFhlbiBjb2xvcihzKTogWyAw IF08YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgVGhpcyBtYWtl cyBtZSBiZWxpZXZlIHRoYXQgbm8gY29sb3JzIGNvbmZpZ3VyYXRpb24gYWN0dWFsbHkgZW5kIHVw IGluIGNvbW1hbmQgbGluZTxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoHRoYXQgWGVu PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgYm9vdGVkPGJy Pg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgd2l0aC48YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqBTaW5nbGUgY29sb3IgZm9yIFhlbiBpcyBhICZxdW90O2RlZmF1bHQgaWYgbm90IHNw ZWNpZmllZCZxdW90OyBhbmQgd2F5IHNpemUgd2FzIHByb2JhYmx5PGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgY2FsY3VsYXRlZDxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoGJ5IGFza2luZzxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoEhXLjxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBTbyBJIHdvdWxkIHN1Z2dlc3QgdG8gZmlyc3QgY3Jvc3Mt Y2hlY2sgdGhlIGNvbW1hbmQgbGluZSBpbiB1c2UuPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoH5NaWNoYWw8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKg Jmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7IFJlZ2FyZHMsPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBPbGVnPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg0LLRgiwgMTgg0LDQv9GALiAy MDIz4oCv0LMuINCyIDIwOjQ0LCBTdGVmYW5vIFN0YWJlbGxpbmkgJmx0OzxhIGhyZWY9Im1haWx0 bzpzc3RhYmVsbGluaUBrZXJuZWwub3JnIiB0YXJnZXQ9Il9ibGFuayI+c3N0YWJlbGxpbmlAa2Vy bmVsLm9yZzwvYT4gJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86c3N0YWJlbGxpbmlAa2VybmVs Lm9yZyIgdGFyZ2V0PSJfYmxhbmsiPnNzdGFiZWxsaW5pQGtlcm5lbC5vcmc8L2E+Jmd0Ozxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZsdDttYWlsdG86PGEgaHJlZj0ibWFpbHRvOnNzdGFiZWxsaW5pQGtlcm5lbC5vcmciIHRhcmdl dD0iX2JsYW5rIj5zc3RhYmVsbGluaUBrZXJuZWwub3JnPC9hPiAmbHQ7bWFpbHRvOjxhIGhyZWY9 Im1haWx0bzpzc3RhYmVsbGluaUBrZXJuZWwub3JnIiB0YXJnZXQ9Il9ibGFuayI+c3N0YWJlbGxp bmlAa2VybmVsLm9yZzwvYT4mZ3Q7Jmd0OyAmbHQ7bWFpbHRvOjxhIGhyZWY9Im1haWx0bzpzc3Rh YmVsbGluaUBrZXJuZWwub3JnIiB0YXJnZXQ9Il9ibGFuayI+c3N0YWJlbGxpbmlAa2VybmVsLm9y ZzwvYT4gJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86c3N0YWJlbGxpbmlAa2VybmVsLm9yZyIg dGFyZ2V0PSJfYmxhbmsiPnNzdGFiZWxsaW5pQGtlcm5lbC5vcmc8L2E+Jmd0OyAmbHQ7bWFpbHRv OjxhIGhyZWY9Im1haWx0bzpzc3RhYmVsbGluaUBrZXJuZWwub3JnIiB0YXJnZXQ9Il9ibGFuayI+ c3N0YWJlbGxpbmlAa2VybmVsLm9yZzwvYT4gJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86c3N0 YWJlbGxpbmlAa2VybmVsLm9yZyIgdGFyZ2V0PSJfYmxhbmsiPnNzdGFiZWxsaW5pQGtlcm5lbC5v cmc8L2E+Jmd0OyZndDsmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86c3N0YWJlbGxpbmlAa2VybmVsLm9y ZyIgdGFyZ2V0PSJfYmxhbmsiPnNzdGFiZWxsaW5pQGtlcm5lbC5vcmc8L2E+ICZsdDttYWlsdG86 PGEgaHJlZj0ibWFpbHRvOnNzdGFiZWxsaW5pQGtlcm5lbC5vcmciIHRhcmdldD0iX2JsYW5rIj5z c3RhYmVsbGluaUBrZXJuZWwub3JnPC9hPiZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmbHQ7bWFpbHRvOjxhIGhyZWY9Im1h aWx0bzpzc3RhYmVsbGluaUBrZXJuZWwub3JnIiB0YXJnZXQ9Il9ibGFuayI+c3N0YWJlbGxpbmlA a2VybmVsLm9yZzwvYT4gJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86c3N0YWJlbGxpbmlAa2Vy bmVsLm9yZyIgdGFyZ2V0PSJfYmxhbmsiPnNzdGFiZWxsaW5pQGtlcm5lbC5vcmc8L2E+Jmd0OyZn dDsgJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86c3N0YWJlbGxpbmlAa2VybmVsLm9yZyIgdGFy Z2V0PSJfYmxhbmsiPnNzdGFiZWxsaW5pQGtlcm5lbC5vcmc8L2E+ICZsdDttYWlsdG86PGEgaHJl Zj0ibWFpbHRvOnNzdGFiZWxsaW5pQGtlcm5lbC5vcmciIHRhcmdldD0iX2JsYW5rIj5zc3RhYmVs bGluaUBrZXJuZWwub3JnPC9hPiZndDsgJmx0O21haWx0bzo8YSBocmVmPSJtYWlsdG86c3N0YWJl bGxpbmlAa2VybmVsLm9yZyIgdGFyZ2V0PSJfYmxhbmsiPnNzdGFiZWxsaW5pQGtlcm5lbC5vcmc8 L2E+ICZsdDttYWlsdG86PGEgaHJlZj0ibWFpbHRvOnNzdGFiZWxsaW5pQGtlcm5lbC5vcmciIHRh cmdldD0iX2JsYW5rIj5zc3RhYmVsbGluaUBrZXJuZWwub3JnPC9hPiZndDsmZ3Q7Jmd0OyZndDsm Z3Q7Ojxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqBPbiBUdWUsIDE4IEFwciAyMDIzLCBPbGVnIE5pa2l0ZW5rbyB3 cm90ZTo8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7IEhpIEp1bGllbiw8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7PGJyPg0KJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgJmd0OyAmZ3Q7Jmd0OyBUaGlzIGZlYXR1cmUgaGFzIG5vdCBiZWVuIG1lcmdlZCBpbiBYZW4g dXBzdHJlYW0geWV0PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDsgJmd0OyB3b3VsZCBh c3N1bWUgdGhhdCB1cHN0cmVhbSArIHRoZSBzZXJpZXMgb24gdGhlIE1MIFsxXSB3b3JrPGJyPg0K Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDsgUGxlYXNlIGNsYXJpZnkgdGhpcyBwb2ludC48YnI+ DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAmZ3Q7IEJlY2F1c2UgdGhlIHR3byB0aG91Z2h0cyBhcmUgY29udHJvdmVyc2lhbC48 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgSGkgT2xlZyw8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKg IMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgQXMgSnVsaWVuIHdyb3RlLCB0 aGVyZSBpcyBub3RoaW5nIGNvbnRyb3ZlcnNpYWwuIEFzIHlvdSBhcmUgYXdhcmUsPGJyPg0KJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgWGlsaW54IG1haW50YWlucyBhIHNlcGFyYXRlIFhlbiB0cmVlIHNwZWNpZmljIGZvciBYaWxp bnggaGVyZTo8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqA8YSBocmVmPSJodHRwczovL2dpdGh1Yi5jb20veGlsaW54L3hl biIgcmVsPSJub3JlZmVycmVyIiB0YXJnZXQ9Il9ibGFuayI+aHR0cHM6Ly9naXRodWIuY29tL3hp bGlueC94ZW48L2E+ICZsdDs8YSBocmVmPSJodHRwczovL2dpdGh1Yi5jb20veGlsaW54L3hlbiIg cmVsPSJub3JlZmVycmVyIiB0YXJnZXQ9Il9ibGFuayI+aHR0cHM6Ly9naXRodWIuY29tL3hpbGlu eC94ZW48L2E+Jmd0OyAmbHQ7PGEgaHJlZj0iaHR0cHM6Ly9naXRodWIuY29tL3hpbGlueC94ZW4i IHJlbD0ibm9yZWZlcnJlciIgdGFyZ2V0PSJfYmxhbmsiPmh0dHBzOi8vZ2l0aHViLmNvbS94aWxp bngveGVuPC9hPiAmbHQ7PGEgaHJlZj0iaHR0cHM6Ly9naXRodWIuY29tL3hpbGlueC94ZW4iIHJl bD0ibm9yZWZlcnJlciIgdGFyZ2V0PSJfYmxhbmsiPmh0dHBzOi8vZ2l0aHViLmNvbS94aWxpbngv eGVuPC9hPiZndDsmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmx0OzxhIGhyZWY9Imh0dHBzOi8vZ2l0aHViLmNvbS94aWxpbngveGVuIiByZWw9Im5v cmVmZXJyZXIiIHRhcmdldD0iX2JsYW5rIj5odHRwczovL2dpdGh1Yi5jb20veGlsaW54L3hlbjwv YT4gJmx0OzxhIGhyZWY9Imh0dHBzOi8vZ2l0aHViLmNvbS94aWxpbngveGVuIiByZWw9Im5vcmVm ZXJyZXIiIHRhcmdldD0iX2JsYW5rIj5odHRwczovL2dpdGh1Yi5jb20veGlsaW54L3hlbjwvYT4m Z3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmx0OzxhIGhyZWY9Imh0dHBzOi8vZ2l0aHViLmNvbS94aWxpbngveGVuIiByZWw9 Im5vcmVmZXJyZXIiIHRhcmdldD0iX2JsYW5rIj5odHRwczovL2dpdGh1Yi5jb20veGlsaW54L3hl bjwvYT4gJmx0OzxhIGhyZWY9Imh0dHBzOi8vZ2l0aHViLmNvbS94aWxpbngveGVuIiByZWw9Im5v cmVmZXJyZXIiIHRhcmdldD0iX2JsYW5rIj5odHRwczovL2dpdGh1Yi5jb20veGlsaW54L3hlbjwv YT4mZ3Q7Jmd0OyZndDsgJmx0OzxhIGhyZWY9Imh0dHBzOi8vZ2l0aHViLmNvbS94aWxpbngveGVu IiByZWw9Im5vcmVmZXJyZXIiIHRhcmdldD0iX2JsYW5rIj5odHRwczovL2dpdGh1Yi5jb20veGls aW54L3hlbjwvYT4gJmx0OzxhIGhyZWY9Imh0dHBzOi8vZ2l0aHViLmNvbS94aWxpbngveGVuIiBy ZWw9Im5vcmVmZXJyZXIiIHRhcmdldD0iX2JsYW5rIj5odHRwczovL2dpdGh1Yi5jb20veGlsaW54 L3hlbjwvYT4mZ3Q7ICZsdDs8YSBocmVmPSJodHRwczovL2dpdGh1Yi5jb20veGlsaW54L3hlbiIg cmVsPSJub3JlZmVycmVyIiB0YXJnZXQ9Il9ibGFuayI+aHR0cHM6Ly9naXRodWIuY29tL3hpbGlu eC94ZW48L2E+ICZsdDs8YSBocmVmPSJodHRwczovL2dpdGh1Yi5jb20veGlsaW54L3hlbiIgcmVs PSJub3JlZmVycmVyIiB0YXJnZXQ9Il9ibGFuayI+aHR0cHM6Ly9naXRodWIuY29tL3hpbGlueC94 ZW48L2E+Jmd0OyZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmbHQ7PGEgaHJlZj0iaHR0cHM6Ly9naXRodWIuY29tL3hpbGlueC94ZW4iIHJlbD0ibm9y ZWZlcnJlciIgdGFyZ2V0PSJfYmxhbmsiPmh0dHBzOi8vZ2l0aHViLmNvbS94aWxpbngveGVuPC9h PiAmbHQ7PGEgaHJlZj0iaHR0cHM6Ly9naXRodWIuY29tL3hpbGlueC94ZW4iIHJlbD0ibm9yZWZl cnJlciIgdGFyZ2V0PSJfYmxhbmsiPmh0dHBzOi8vZ2l0aHViLmNvbS94aWxpbngveGVuPC9hPiZn dDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmbHQ7PGEgaHJlZj0iaHR0cHM6Ly9naXRodWIuY29tL3hpbGlueC94ZW4iIHJlbD0i bm9yZWZlcnJlciIgdGFyZ2V0PSJfYmxhbmsiPmh0dHBzOi8vZ2l0aHViLmNvbS94aWxpbngveGVu PC9hPiAmbHQ7PGEgaHJlZj0iaHR0cHM6Ly9naXRodWIuY29tL3hpbGlueC94ZW4iIHJlbD0ibm9y ZWZlcnJlciIgdGFyZ2V0PSJfYmxhbmsiPmh0dHBzOi8vZ2l0aHViLmNvbS94aWxpbngveGVuPC9h PiZndDsmZ3Q7Jmd0OyZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgYW5kIHRoZSBicmFuY2ggeW91IGFyZSB1 c2luZyAoeGxueF9yZWJhc2VfNC4xNikgY29tZXMgZnJvbSB0aGVyZS48YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoEluc3RlYWQsIHRoZSB1cHN0cmVhbSBYZW4gdHJlZSBsaXZlcyBoZXJlOjxicj4NCiZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oDxhIGhyZWY9Imh0dHBzOi8veGVuYml0cy54ZW4ub3JnL2dpdHdlYi8/cD14ZW4uZ2l0O2E9c3Vt bWFyeSIgcmVsPSJub3JlZmVycmVyIiB0YXJnZXQ9Il9ibGFuayI+aHR0cHM6Ly94ZW5iaXRzLnhl bi5vcmcvZ2l0d2ViLz9wPXhlbi5naXQ7YT1zdW1tYXJ5PC9hPiAmbHQ7PGEgaHJlZj0iaHR0cHM6 Ly94ZW5iaXRzLnhlbi5vcmcvZ2l0d2ViLz9wPXhlbi5naXQ7YT1zdW1tYXJ5IiByZWw9Im5vcmVm ZXJyZXIiIHRhcmdldD0iX2JsYW5rIj5odHRwczovL3hlbmJpdHMueGVuLm9yZy9naXR3ZWIvP3A9 eGVuLmdpdDthPXN1bW1hcnk8L2E+Jmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZsdDs8YSBocmVmPSJodHRwczovL3hlbmJp dHMueGVuLm9yZy9naXR3ZWIvP3A9eGVuLmdpdDthPXN1bW1hcnkiIHJlbD0ibm9yZWZlcnJlciIg dGFyZ2V0PSJfYmxhbmsiPmh0dHBzOi8veGVuYml0cy54ZW4ub3JnL2dpdHdlYi8/cD14ZW4uZ2l0 O2E9c3VtbWFyeTwvYT4gJmx0OzxhIGhyZWY9Imh0dHBzOi8veGVuYml0cy54ZW4ub3JnL2dpdHdl Yi8/cD14ZW4uZ2l0O2E9c3VtbWFyeSIgcmVsPSJub3JlZmVycmVyIiB0YXJnZXQ9Il9ibGFuayI+ aHR0cHM6Ly94ZW5iaXRzLnhlbi5vcmcvZ2l0d2ViLz9wPXhlbi5naXQ7YT1zdW1tYXJ5PC9hPiZn dDsmZ3Q7ICZsdDs8YSBocmVmPSJodHRwczovL3hlbmJpdHMueGVuLm9yZy9naXR3ZWIvP3A9eGVu LmdpdDthPXN1bW1hcnkiIHJlbD0ibm9yZWZlcnJlciIgdGFyZ2V0PSJfYmxhbmsiPmh0dHBzOi8v eGVuYml0cy54ZW4ub3JnL2dpdHdlYi8/cD14ZW4uZ2l0O2E9c3VtbWFyeTwvYT4gJmx0OzxhIGhy ZWY9Imh0dHBzOi8veGVuYml0cy54ZW4ub3JnL2dpdHdlYi8/cD14ZW4uZ2l0O2E9c3VtbWFyeSIg cmVsPSJub3JlZmVycmVyIiB0YXJnZXQ9Il9ibGFuayI+aHR0cHM6Ly94ZW5iaXRzLnhlbi5vcmcv Z2l0d2ViLz9wPXhlbi5naXQ7YT1zdW1tYXJ5PC9hPiZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmbHQ7PGEgaHJlZj0iaHR0 cHM6Ly94ZW5iaXRzLnhlbi5vcmcvZ2l0d2ViLz9wPXhlbi5naXQ7YT1zdW1tYXJ5IiByZWw9Im5v cmVmZXJyZXIiIHRhcmdldD0iX2JsYW5rIj5odHRwczovL3hlbmJpdHMueGVuLm9yZy9naXR3ZWIv P3A9eGVuLmdpdDthPXN1bW1hcnk8L2E+ICZsdDs8YSBocmVmPSJodHRwczovL3hlbmJpdHMueGVu Lm9yZy9naXR3ZWIvP3A9eGVuLmdpdDthPXN1bW1hcnkiIHJlbD0ibm9yZWZlcnJlciIgdGFyZ2V0 PSJfYmxhbmsiPmh0dHBzOi8veGVuYml0cy54ZW4ub3JnL2dpdHdlYi8/cD14ZW4uZ2l0O2E9c3Vt bWFyeTwvYT4mZ3Q7Jmd0OyZndDsgJmx0OzxhIGhyZWY9Imh0dHBzOi8veGVuYml0cy54ZW4ub3Jn L2dpdHdlYi8/cD14ZW4uZ2l0O2E9c3VtbWFyeSIgcmVsPSJub3JlZmVycmVyIiB0YXJnZXQ9Il9i bGFuayI+aHR0cHM6Ly94ZW5iaXRzLnhlbi5vcmcvZ2l0d2ViLz9wPXhlbi5naXQ7YT1zdW1tYXJ5 PC9hPiAmbHQ7PGEgaHJlZj0iaHR0cHM6Ly94ZW5iaXRzLnhlbi5vcmcvZ2l0d2ViLz9wPXhlbi5n aXQ7YT1zdW1tYXJ5IiByZWw9Im5vcmVmZXJyZXIiIHRhcmdldD0iX2JsYW5rIj5odHRwczovL3hl bmJpdHMueGVuLm9yZy9naXR3ZWIvP3A9eGVuLmdpdDthPXN1bW1hcnk8L2E+Jmd0Ozxicj4NCiZn dDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZs dDs8YSBocmVmPSJodHRwczovL3hlbmJpdHMueGVuLm9yZy9naXR3ZWIvP3A9eGVuLmdpdDthPXN1 bW1hcnkiIHJlbD0ibm9yZWZlcnJlciIgdGFyZ2V0PSJfYmxhbmsiPmh0dHBzOi8veGVuYml0cy54 ZW4ub3JnL2dpdHdlYi8/cD14ZW4uZ2l0O2E9c3VtbWFyeTwvYT4gJmx0OzxhIGhyZWY9Imh0dHBz Oi8veGVuYml0cy54ZW4ub3JnL2dpdHdlYi8/cD14ZW4uZ2l0O2E9c3VtbWFyeSIgcmVsPSJub3Jl ZmVycmVyIiB0YXJnZXQ9Il9ibGFuayI+aHR0cHM6Ly94ZW5iaXRzLnhlbi5vcmcvZ2l0d2ViLz9w PXhlbi5naXQ7YT1zdW1tYXJ5PC9hPiZndDsmZ3Q7ICZsdDs8YSBocmVmPSJodHRwczovL3hlbmJp dHMueGVuLm9yZy9naXR3ZWIvP3A9eGVuLmdpdDthPXN1bW1hcnkiIHJlbD0ibm9yZWZlcnJlciIg dGFyZ2V0PSJfYmxhbmsiPmh0dHBzOi8veGVuYml0cy54ZW4ub3JnL2dpdHdlYi8/cD14ZW4uZ2l0 O2E9c3VtbWFyeTwvYT4gJmx0OzxhIGhyZWY9Imh0dHBzOi8veGVuYml0cy54ZW4ub3JnL2dpdHdl Yi8/cD14ZW4uZ2l0O2E9c3VtbWFyeSIgcmVsPSJub3JlZmVycmVyIiB0YXJnZXQ9Il9ibGFuayI+ aHR0cHM6Ly94ZW5iaXRzLnhlbi5vcmcvZ2l0d2ViLz9wPXhlbi5naXQ7YT1zdW1tYXJ5PC9hPiZn dDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmbHQ7PGEgaHJlZj0iaHR0cHM6Ly94ZW5iaXRzLnhlbi5vcmcvZ2l0d2ViLz9wPXhl bi5naXQ7YT1zdW1tYXJ5IiByZWw9Im5vcmVmZXJyZXIiIHRhcmdldD0iX2JsYW5rIj5odHRwczov L3hlbmJpdHMueGVuLm9yZy9naXR3ZWIvP3A9eGVuLmdpdDthPXN1bW1hcnk8L2E+ICZsdDs8YSBo cmVmPSJodHRwczovL3hlbmJpdHMueGVuLm9yZy9naXR3ZWIvP3A9eGVuLmdpdDthPXN1bW1hcnki IHJlbD0ibm9yZWZlcnJlciIgdGFyZ2V0PSJfYmxhbmsiPmh0dHBzOi8veGVuYml0cy54ZW4ub3Jn L2dpdHdlYi8/cD14ZW4uZ2l0O2E9c3VtbWFyeTwvYT4mZ3Q7Jmd0OyZndDsmZ3Q7PGJyPg0KJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqBUaGUgQ2FjaGUgQ29sb3JpbmcgZmVhdHVyZSB0aGF0IHlvdSBhcmUgdHJ5aW5n IHRvIGNvbmZpZ3VyZSBpcyBwcmVzZW50PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgaW4geGxueF9yZWJhc2VfNC4xNiwg YnV0IG5vdCB5ZXQgcHJlc2VudCB1cHN0cmVhbSAodGhlcmUgaXMgYW48YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqBvdXRz dGFuZGluZyBwYXRjaCBzZXJpZXMgdG8gYWRkIGNhY2hlIGNvbG9yaW5nIHRvIFhlbiB1cHN0cmVh bSBidXQgaXQ8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqBoYXNuJiMzOTt0IGJlZW4gbWVyZ2VkIHlldC4pPGJyPg0KJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4N CiZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8 YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqBBbnl3YXksIGlmIHlvdSBhcmUgdXNpbmcgeGxueF9yZWJhc2VfNC4xNiBpdCBk b2VzbiYjMzk7dCBtYXR0ZXIgdG9vIG11Y2ggZm9yPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKg IMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgeW91IGFzIHlvdSBhbHJl YWR5IGhhdmUgQ2FjaGUgQ29sb3JpbmcgYXMgYSBmZWF0dXJlIHRoZXJlLjxicj4NCiZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0K Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgSSB0YWtlIHlvdSBhcmUgdXNpbmcgSW1hZ2VCdWlsZGVyIHRvIGdlbmVyYXRlIHRoZSBi b290IGNvbmZpZ3VyYXRpb24/IElmPGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgc28sIHBsZWFzZSBwb3N0IHRoZSBJbWFn ZUJ1aWxkZXIgY29uZmlnIGZpbGUgdGhhdCB5b3UgYXJlIHVzaW5nLjxicj4NCiZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqBC dXQgZnJvbSB0aGUgYm9vdCBtZXNzYWdlLCBpdCBsb29rcyBsaWtlIHRoZSBjb2xvcnMgY29uZmln dXJhdGlvbiBmb3I8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqBEb20wIGlzIGluY29ycmVjdC48YnI+DQomZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAg wqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAmZ3Q7PGJyPg0KJmd0 O8KgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCZndDsgPGJyPg0KJmd0OyA8YnI+DQo8L2Js b2NrcXVvdGU+PC9kaXY+DQo8L2Jsb2NrcXVvdGU+PC9kaXY+DQo= --000000000000f64c8c05fb3d35d5-- From xen-devel-bounces@lists.xenproject.org Tue May 09 07:10:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 May 2023 07:10:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.531975.827963 (Exim 4.92) (envelope-from ) id 1pwHU8-0004Uc-Mm; Tue, 09 May 2023 07:10:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 531975.827963; Tue, 09 May 2023 07:10:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pwHU8-0004UV-K7; Tue, 09 May 2023 07:10:08 +0000 Received: by outflank-mailman (input) for mailman id 531975; Tue, 09 May 2023 07:10:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pwHU6-0004UP-MU for xen-devel@lists.xenproject.org; Tue, 09 May 2023 07:10:06 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 861745a1-ee38-11ed-b227-6b7b168915f2; Tue, 09 May 2023 09:10:05 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F31A01F45A; Tue, 9 May 2023 07:10:04 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C6005139B3; Tue, 9 May 2023 07:10:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id NsYJL8zxWWS3HAAAMHmgww (envelope-from ); Tue, 09 May 2023 07:10:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 861745a1-ee38-11ed-b227-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683616205; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Nr6sbJPcZ0amzdla/OGNm5kfmiUJwrr6bXmyCciMiNo=; b=sjpn9UqCABm+jh9+9zxNPf3OuvMIEsW+Qs4/ir3YUsk492Hml1iTd40ewLCoyO5hfKp7Hw tKNg2nDQVVhNVE5XZz28lrUcfAAOGc8w1xVEhhDRHAa86v96+BKYUei7yqVbNTJ4KYg8cD v1Xeifqsf3k6rOQmNndBOSs49LGEOK4= Message-ID: <0e7c1819-f611-1ba1-9f5a-3295eae7f95d@suse.com> Date: Tue, 9 May 2023 09:10:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v2] tools: convert bitfields to unsigned type Content-Language: en-US To: Olaf Hering , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD , George Dunlap References: <20230508164618.21496-1-olaf@aepfle.de> From: Juergen Gross In-Reply-To: <20230508164618.21496-1-olaf@aepfle.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------FijHca0A7NcSsaFZsH2RsFYv" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------FijHca0A7NcSsaFZsH2RsFYv Content-Type: multipart/mixed; boundary="------------myB8dc4MuSE18IXYazDCN9VE"; protected-headers="v1" From: Juergen Gross To: Olaf Hering , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD , George Dunlap Message-ID: <0e7c1819-f611-1ba1-9f5a-3295eae7f95d@suse.com> Subject: Re: [PATCH v2] tools: convert bitfields to unsigned type References: <20230508164618.21496-1-olaf@aepfle.de> In-Reply-To: <20230508164618.21496-1-olaf@aepfle.de> --------------myB8dc4MuSE18IXYazDCN9VE Content-Type: multipart/mixed; boundary="------------0P9cVVRs7fsnXncdrNUt2qh6" --------------0P9cVVRs7fsnXncdrNUt2qh6 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDguMDUuMjMgMTg6NDYsIE9sYWYgSGVyaW5nIHdyb3RlOg0KPiBjbGFuZyBjb21wbGFp bnMgYWJvdXQgdGhlIHNpZ25lZCB0eXBlOg0KPiANCj4gaW1wbGljaXQgdHJ1bmNhdGlvbiBm cm9tICdpbnQnIHRvIGEgb25lLWJpdCB3aWRlIGJpdC1maWVsZCBjaGFuZ2VzIHZhbHVlIGZy b20gMSB0byAtMSBbLVdzaW5nbGUtYml0LWJpdGZpZWxkLWNvbnN0YW50LWNvbnZlcnNpb25d DQo+IA0KPiBUaGUgcG90ZW50aWFsIEFCSSBjaGFuZ2UgaW4gbGlieGVudmNoYW4gaXMgY292 ZXJlZCBieSB0aGUgWGVuIHZlcnNpb24gYmFzZWQgU09OQU1FLg0KPiANCj4gU2lnbmVkLW9m Zi1ieTogT2xhZiBIZXJpbmcgPG9sYWZAYWVwZmxlLmRlPg0KDQpSZXZpZXdlZC1ieTogSnVl cmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KDQoNCkp1ZXJnZW4NCg0K --------------0P9cVVRs7fsnXncdrNUt2qh6 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------0P9cVVRs7fsnXncdrNUt2qh6-- --------------myB8dc4MuSE18IXYazDCN9VE-- --------------FijHca0A7NcSsaFZsH2RsFYv Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmRZ8cwFAwAAAAAACgkQsN6d1ii/Ey+B fgf/fOoGMrP46JTa1DIHq46O64fgzD+gBmIMnoZIjfG/HBQe5sgVULg1dZAfjV7fZqhWSB6otjk/ GS3gyXqISlQfN77bITjsVkECGbhp4VFbGcgtOApjA+PzLFNS3owXgqJ7ZFqfDUhHYsyliI+G8ffC Sfs91UPk1GR4AF5GgNqbQ3psULeclZJCT13WtK0m9/2eg16nB9vQeCdW9Kb7pV6kGG+IhJos3HVd ZtGWBOPTSZsXLsZoL6Lup8uKYsNo53j7v/GUzB+mnWxNqh6fBBRqSFBFk16UMO4/vutrkJPq/OEg ZdsXND9xmV283BtI/sSQ2ji5yvk2Qi+NGHtAJaaJkw== =uxQS -----END PGP SIGNATURE----- --------------FijHca0A7NcSsaFZsH2RsFYv-- From xen-devel-bounces@lists.xenproject.org Tue May 09 07:52:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 May 2023 07:52:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.532015.827991 (Exim 4.92) (envelope-from ) id 1pwI9E-0001ar-7B; Tue, 09 May 2023 07:52:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 532015.827991; Tue, 09 May 2023 07:52:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pwI9E-0001ak-3y; Tue, 09 May 2023 07:52:36 +0000 Received: by outflank-mailman (input) for mailman id 532015; Tue, 09 May 2023 07:52:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pwI9D-0001aa-9C; Tue, 09 May 2023 07:52:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pwI9D-0001RG-6h; Tue, 09 May 2023 07:52:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pwI9C-0008RY-R4; Tue, 09 May 2023 07:52:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pwI9C-0003kj-Qb; Tue, 09 May 2023 07:52:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Y999lLf6z/EDax7FraFGxLyzXuFPVTjcbg9bvTEq4AI=; b=ejLLwX0bqEAMgG9uKJeH6UgDY8 azON12q7828L7FhBh30AbiiDL+ce4U3XAB8jTf6tAm5viVTer3ZFY8SHeyKeggJVVvy7UulwiI/KW 8o/4kiq0jq6WZUTH6n501yq8kLmqVkX157A56rzMycCx1Kezeb7ShWfCZPWWZ7FE+NtE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 180582: regressions - FAIL X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=ba0ad6ed89fd5dada3b7b65ef2b08e95d449d4ab X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Tue, 09 May 2023 07:52:34 +0000 flight 180582 linux-linus real [real] flight 180585 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180582/ http://logs.test-lab.xenproject.org/osstest/logs/180585/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 180278 Tests which did not succeed, but are not blocking: test-armhf-armhf-examine 8 reboot fail like 180278 test-armhf-armhf-libvirt 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-raw 8 xen-boot fail like 180278 test-armhf-armhf-xl-rtds 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180278 test-armhf-armhf-xl 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180278 test-armhf-armhf-xl-multivcpu 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail like 180278 test-armhf-armhf-xl-credit2 8 xen-boot fail like 180278 test-armhf-armhf-xl-vhd 8 xen-boot fail like 180278 test-armhf-armhf-xl-arndale 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux ba0ad6ed89fd5dada3b7b65ef2b08e95d449d4ab baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 22 days Failing since 180281 2023-04-17 06:24:36 Z 22 days 40 attempts Testing same since 180582 2023-05-08 21:11:46 Z 0 days 1 attempts ------------------------------------------------------------ 2359 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 296937 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 09 08:50:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 May 2023 08:50:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.532037.828001 (Exim 4.92) (envelope-from ) id 1pwJ3J-0008US-Se; Tue, 09 May 2023 08:50:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 532037.828001; Tue, 09 May 2023 08:50:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pwJ3J-0008UL-Pm; Tue, 09 May 2023 08:50:33 +0000 Received: by outflank-mailman (input) for mailman id 532037; Tue, 09 May 2023 08:50:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pwJ3I-0008UF-E9 for xen-devel@lists.xenproject.org; Tue, 09 May 2023 08:50:32 +0000 Received: from mail145-2.atl61.mandrillapp.com (mail145-2.atl61.mandrillapp.com [198.2.145.2]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8cc6b881-ee46-11ed-b227-6b7b168915f2; Tue, 09 May 2023 10:50:30 +0200 (CEST) Received: from pmta06.mandrill.prod.atl01.rsglab.com (localhost [127.0.0.1]) by mail145-2.atl61.mandrillapp.com (Mailchimp) with ESMTP id 4QFsLY103BzQXhVH1 for ; Tue, 9 May 2023 08:50:29 +0000 (GMT) Received: from [37.26.189.201] by mandrillapp.com id 94f408e6aef34506a031dc1ad4551bf0; Tue, 09 May 2023 08:50:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8cc6b881-ee46-11ed-b227-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.fr; s=mandrill; t=1683622229; x=1683882729; i=yann.dirson@vates.fr; bh=XH6A9kRnaKfrtYq4xDKHmzCwIBK2FhX1ZqRruWUSQMc=; h=From:Subject:Message-Id:To:Cc:References:In-Reply-To:Feedback-ID: Date:MIME-Version:Content-Type:Content-Transfer-Encoding:CC:Date: Subject:From; b=OBtd2a3RMp3AR4Zbcl5JuEp474EoCJtS2oBwJYnJV14QHgWOfx1/lpnbPpyAB/g7w OK9qtfb5HbZ31RhyV+4Q3YhrzgMuDvv/Q+KwO7cN56P3vNSxpGzuo767q4HXPylLu2 iQuBm1q4AmkFj5REA+Es+Q+pIhfplbR8NRIpmNMI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; i=@mandrillapp.com; q=dns/txt; s=mandrill; t=1683622229; h=From : Subject : Message-Id : To : Cc : References : In-Reply-To : Date : MIME-Version : Content-Type : Content-Transfer-Encoding : From : Subject : Date : X-Mandrill-User : List-Unsubscribe; bh=XH6A9kRnaKfrtYq4xDKHmzCwIBK2FhX1ZqRruWUSQMc=; b=MbrYoUxC8pdOc6NtZhJ43fBb9aRZ/VORsu+B6wbw+XMV463zWpA0Vr7/MooIWjOMDKGEvY 4k8d+aCSJsc/xEbWVbRYEygdpSRfCIrW9yHNiAyMVqgF6fkf7D6MRPI1X300MLJuDBp7+GYD c6szoPfn3/w75oI4ipAeYDuwAn5jU= From: Yann Dirson Subject: =?utf-8?Q?Re:=20xenstored:=20EACCESS=20error=20accessing=20control/feature-balloon=201?= X-Bm-Disclaimer: Yes X-Bm-Milter-Handled: 9664e26d-c55d-4176-ac64-680cfb7c5564 X-Bm-Transport-Timestamp: 1683622225995 Message-Id: <9a5045b8-43f3-d418-9e77-418b6db91f71@vates.fr> To: zithro , xen-devel@lists.xenproject.org Cc: Juergen Gross , =?utf-8?Q?Edwin=20T=C3=B6r=C3=B6k?= , Julien Grall , Andrew Cooper References: <3065c524-07c7-6458-ff4c-ba68ff78c946@rabbit.lu> <474b531f-2067-a5d4-8b01-5b8ef1f7061d@citrix.com> <678df1ff-df18-b063-eda3-2a1aed6d40f8@vates.fr> <50bf6b82-965b-d17c-7c5a-49c703991504@rabbit.lu> In-Reply-To: X-Native-Encoded: 1 X-Report-Abuse: =?UTF-8?Q?Please=20forward=20a=20copy=20of=20this=20message,=20including=20all=20headers,=20to=20abuse@mandrill.com.=20You=20can=20also=20report=20abuse=20here:=20https://mandrillapp.com/contact/abuse=3Fid=3D30504962.94f408e6aef34506a031dc1ad4551bf0?= X-Mandrill-User: md_30504962 Feedback-ID: 30504962:30504962.20230509:md Date: Tue, 09 May 2023 08:50:29 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 5/4/23 20:04, zithro wrote: > On 04 May 2023 17:59, Yann Dirson wrote: >> >> On 5/4/23 15:58, zithro wrote: >>> Hi, >>> >>> [ snipped for brevity, report summary: >>> XAPI daemon in domU tries to write to a non-existent xenstore node in >>> a non-XAPI dom0 ] >>> >>> On 12 Apr 2023 18:41, Yann Dirson wrote: >>>> Is there anything besides XAPI using this node, or the other data >>>> published by xe-daemon? >>> >>> On my vanilla Xen (ie. non-XAPI), I have no node about "balloon"-ing >>> in xenstore (either dom0 or domU nodes, but I'm not using ballooning >>> in both). >>> >>>> Maybe the original issue is just that there is no reason to have >>>> xe-guest-utilities installed in this setup? >>> >>> That's what I thought as I'm not using XAPI, so maybe the problem >>> should only be addressed to the truenas team ? I posted on their forum >>> but got no answer. >>> I killed the 'xe-daemon' in both setups without loss of functionality. >>> >>> My wild guess is that 'xe-daemon', 'xe-update-guest-attrs' and all >>> 'xenstore* commands' are leftovers from when Xen was working as a dom0 >>> under FreeBSD (why would a *domU* have them ?). >> >> That would not be correct: xenstore* are useful in guests, should you >> want to read/write to the XenStore manually or from scripts; > > Didn't know that, can you give some use cases (or URLs) for which it > is useful, with or without XAPI ? > I've read xenstore* man pages and could not infer a use case. > Although I may already see some : updating ballooned memory values, or > as Julien Grall pointed out, updating "feature-s3/4" values ? You can get other examples in https://xenbits.xen.org/docs/unstable/misc/xenstore-paths.html#domain-controlled-paths > > PS: small mistake in "man/xenstore-write.1.html" (from at least 4.14, > and onward), the synopsis reads "xenstore-read" ieof "xenstore-read". Patch sent, thanks. > Also, the -s option disappeared from unstable, although it may be > expected. I don't know it's purpose either. See https://github.com/xen-project/xen/commit/c65687ed16d2289ec91036ec2862a4b4bd34ea4f Best regards, -- Yann Dirson | Vates Platform Developer XCP-ng & Xen Orchestra - Vates solutions w: vates.tech | xcp-ng.org | xen-orchestra.com Yann Dirson | Vates Platform Developer XCP-ng & Xen Orchestra - Vates solutions w: vates.fr | xcp-ng.org | xen-orchestra.com From xen-devel-bounces@lists.xenproject.org Tue May 09 09:01:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 May 2023 09:01:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.532043.828010 (Exim 4.92) (envelope-from ) id 1pwJE4-0001hl-Vr; Tue, 09 May 2023 09:01:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 532043.828010; Tue, 09 May 2023 09:01:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pwJE4-0001he-TI; Tue, 09 May 2023 09:01:40 +0000 Received: by outflank-mailman (input) for mailman id 532043; Tue, 09 May 2023 09:01:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pwJE3-0001hY-KP for xen-devel@lists.xenproject.org; Tue, 09 May 2023 09:01:39 +0000 Received: from mail179-5.suw41.mandrillapp.com (mail179-5.suw41.mandrillapp.com [198.2.179.5]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1a60effb-ee48-11ed-8611-37d641c3527e; Tue, 09 May 2023 11:01:37 +0200 (CEST) Received: from pmta12.mandrill.prod.suw01.rsglab.com (localhost [127.0.0.1]) by mail179-5.suw41.mandrillapp.com (Mailchimp) with ESMTP id 4QFsbN1GZszG0CBdJ for ; Tue, 9 May 2023 09:01:36 +0000 (GMT) Received: from [37.26.189.201] by mandrillapp.com id 623ad5ea264e45fbb42cd0bfa6510f2e; Tue, 09 May 2023 09:01:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1a60effb-ee48-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.fr; s=mandrill; t=1683622896; x=1683883396; i=yann.dirson@vates.fr; bh=8BqKJOEwx5qtlEBsdJyBSQKBsIITldio/65tB71HYkg=; h=From:Subject:To:Cc:Message-Id:Feedback-ID:Date:MIME-Version: Content-Type:Content-Transfer-Encoding:CC:Date:Subject:From; b=nEsvgiS4ZVzrK5gVS5VR5zSsuFKqphc4UzRE8FQjBGW+M/KeDbfQRuCux4jCERkRT 4c3KpxyyVrB/IHpXpLMV5p9rmUBSFjI7KMJMTpsMjBKCufZzPOHrXkHYNZD2dhQ0k5 vBoJYTXifJbmJp+uxePogjBPOH74I9z13Najcruc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; i=@mandrillapp.com; q=dns/txt; s=mandrill; t=1683622896; h=From : Subject : To : Cc : Message-Id : Date : MIME-Version : Content-Type : Content-Transfer-Encoding : From : Subject : Date : X-Mandrill-User : List-Unsubscribe; bh=8BqKJOEwx5qtlEBsdJyBSQKBsIITldio/65tB71HYkg=; b=YlyTa1mPIPqCxh9Eerffl1AkKLmo1rXKoqbRytSM6WSaM8+5+miHOdvMe4ATvCHCan4zt0 JDGgL7ZgReAfK6KpRhPtU0LRpM4yOLg0aCQVKvolpdfPOZhYn3slA3nHZLKXr8D+QX2J1qhH vLsQPe5oFwknyW9UvjMLwr/K87gw4= From: Yann Dirson Subject: =?utf-8?Q?[PATCH]=20docs/man:=20fix=20xenstore-write=20synopsis?= X-Mailer: git-send-email 2.30.2 X-Bm-Disclaimer: Yes X-Bm-Milter-Handled: 9664e26d-c55d-4176-ac64-680cfb7c5564 X-Bm-Transport-Timestamp: 1683622890131 To: xen-devel@lists.xenproject.org Cc: Yann Dirson , zithro Message-Id: <20230509090123.781644-1-yann.dirson@vates.fr> X-Native-Encoded: 1 X-Report-Abuse: =?UTF-8?Q?Please=20forward=20a=20copy=20of=20this=20message,=20including=20all=20headers,=20to=20abuse@mandrill.com.=20You=20can=20also=20report=20abuse=20here:=20https://mandrillapp.com/contact/abuse=3Fid=3D30504962.623ad5ea264e45fbb42cd0bfa6510f2e?= X-Mandrill-User: md_30504962 Feedback-ID: 30504962:30504962.20230509:md Date: Tue, 09 May 2023 09:01:36 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Reported-by: zithro Signed-off-by: Yann Dirson --- docs/man/xenstore-write.1.pod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/man/xenstore-write.1.pod b/docs/man/xenstore-write.1.pod index a0b1bca333..74f80f7b1b 100644 --- a/docs/man/xenstore-write.1.pod +++ b/docs/man/xenstore-write.1.pod @@ -4,7 +4,7 @@ xenstore-write - write Xenstore values =head1 SYNOPSIS -B [I