From xen-devel-bounces@lists.xenproject.org Sat Jul 01 00:31:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 00:31:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557671.871267 (Exim 4.92) (envelope-from ) id 1qFOWn-00016a-Bp; Sat, 01 Jul 2023 00:31:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557671.871267; Sat, 01 Jul 2023 00:31:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFOWn-000161-7S; Sat, 01 Jul 2023 00:31:53 +0000 Received: by outflank-mailman (input) for mailman id 557671; Sat, 01 Jul 2023 00:31:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFOWl-0007yB-9M for xen-devel@lists.xenproject.org; Sat, 01 Jul 2023 00:31:51 +0000 Received: from mail-oa1-x31.google.com (mail-oa1-x31.google.com [2001:4860:4864:20::31]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ab2fcc9f-17a6-11ee-b237-6b7b168915f2; Sat, 01 Jul 2023 02:31:50 +0200 (CEST) Received: by mail-oa1-x31.google.com with SMTP id 586e51a60fabf-1b0156a1c49so2153119fac.0 for ; Fri, 30 Jun 2023 17:31:50 -0700 (PDT) Received: from cog-dev.home ([70.103.208.83]) by smtp.gmail.com with ESMTPSA id s68-20020a632c47000000b0055b61cd99a1sm1824296pgs.81.2023.06.30.17.31.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jun 2023 17:31:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: ab2fcc9f-17a6-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688171508; x=1690763508; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=0U+LCev7aRUe6kzgwNY1PJd28KyRT3ussnezbfZRMiA=; b=WV+aJ1zVjq4nXbKPyve69zH6JoluUFgsXQ5zQkMXcB2gh0mkT3mMnKBgSwybZpyzla jz0D5iwm/fIfnp1y0vMlFyN2W64XDxHa8OCwuKwCSNZV9N22ACjvKBfz98txPImUb88z JYcqXFqcGCJM5LNpzRMBe1pSvD1kKEXulmDgIjnjCxwRV48RgP7CcQonF5yUB1MhPvZF EjQVnESOoVXDThQ9H148u0UULZB6DO37JfHnRgFkgbEbykyvqnnoxp5d9NIv6tuOZLnT VVr74xNXIplbDpbObtcZPEk/gCfqoRnuSwHRP5HG7tE8lBwxytN+STeILwOg9+UCeY9G WExg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688171508; x=1690763508; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0U+LCev7aRUe6kzgwNY1PJd28KyRT3ussnezbfZRMiA=; b=FpFC3LGawWmZMiPWcWoBen4PLZTgTLVeaMwnU1qnx4ZXJTKn1AvmgJF9wdyQ9GXDg9 kBVPX5AaiJDFQCfgVKXWFok859htOEe1zvIg2QNLMyEBaTmUTfiqSFlZdYHd/tvPx8sY wfcpn6xsozoyDzoaDxiUe5+0pWo5EWV7IWyoyrsKfQTL2fNky8RaghsEpTcNFi0/+jCi KRsM3ZYYS9INRL1rSK9vXuqCXwSsObRVRAtrDtXHew/O0AOBqyFpJSL1JdpUMVqmmWG3 qyWyyxuobhN+GiNWu5dzxYEwag7Y8PwGOI5fJdddc9EbuEM3TLPIgVhf7eSTlmM5aGUZ uCmA== X-Gm-Message-State: ABy/qLatbhEfMEIVUkEWREUZNSvJtzs0+qGhEeobA0vT3V3tztWodjYc ox0YsjrAhtVvOE/BwvJdi+SCtwYlvmk= X-Google-Smtp-Source: APBJJlF3sIquE7SEmuOVCL336/ZZA3DJYpw9wCSH58nhp6htUSRqmBAs9VrAM0wy0VnaimSdTk7oBw== X-Received: by 2002:a05:6870:ac26:b0:1ad:5634:750b with SMTP id kw38-20020a056870ac2600b001ad5634750bmr4621178oab.13.1688171508647; Fri, 30 Jun 2023 17:31:48 -0700 (PDT) Sender: Christopher Clark From: Christopher Clark To: xen-devel@lists.xenproject.org Cc: Daniel Smith , stefano.stabellini@amd.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Luca Fancellu , Volodymyr Babchuk , Rich Persaud Subject: [PATCH 07/11] x86 boot: define paddr_t and add macros for typedefing struct pointers Date: Fri, 30 Jun 2023 17:31:28 -0700 Message-Id: <20230701003132.2210306-8-christopher.w.clark@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230701003132.2210306-1-christopher.w.clark@gmail.com> References: <20230701003132.2210306-1-christopher.w.clark@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Pointer fields within structs need to be defined as fixed size types in the x86 boot build environment. Using a typedef for the field type rather than a struct pointer type enables the type definition to be changed in the 32-bit boot build and the main hypervisor build, allowing for a single common structure definition and a common header file. Introduces DEFINE_STRUCT_PTR_TYPE which will generate typedefs with a _ptr_t suffix for pointers to the specified struct. This is then used in The 32-bit behaviour is obtained by inclusion of "defs.h" first with a check for such an existing definition on the version. paddr_t is used in so a definition is added here to the x86 boot environment defs.h header. Signed-off-by: Christopher Clark Signed-off-by: Daniel P. Smith New in v2 of series --- xen/arch/x86/boot/defs.h | 5 +++++ xen/arch/x86/include/asm/bootinfo.h | 2 ++ xen/include/xen/bootinfo.h | 7 ++++--- xen/include/xen/types.h | 5 +++++ 4 files changed, 16 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/boot/defs.h b/xen/arch/x86/boot/defs.h index f9840044ec..867df6d18d 100644 --- a/xen/arch/x86/boot/defs.h +++ b/xen/arch/x86/boot/defs.h @@ -60,4 +60,9 @@ typedef u64 uint64_t; #define U16_MAX ((u16)(~0U)) #define UINT_MAX (~0U) +typedef unsigned long long paddr_t; + +#define DEFINE_STRUCT_PTR_TYPE(struct_name) \ + typedef uint64_t struct_name ## _ptr_t; + #endif /* __BOOT_DEFS_H__ */ diff --git a/xen/arch/x86/include/asm/bootinfo.h b/xen/arch/x86/include/asm/bootinfo.h index 30c27980e0..8d1261503d 100644 --- a/xen/arch/x86/include/asm/bootinfo.h +++ b/xen/arch/x86/include/asm/bootinfo.h @@ -6,6 +6,7 @@ struct arch_bootmodule { uint32_t flags; unsigned headroom; }; +DEFINE_STRUCT_PTR_TYPE(arch_bootmodule); struct arch_boot_info { uint32_t flags; @@ -19,6 +20,7 @@ struct arch_boot_info { uint32_t mmap_length; paddr_t mmap_addr; }; +DEFINE_STRUCT_PTR_TYPE(arch_boot_info); struct __packed mb_memmap { uint32_t size; diff --git a/xen/include/xen/bootinfo.h b/xen/include/xen/bootinfo.h index 2f4284a91f..8ee3ee36e9 100644 --- a/xen/include/xen/bootinfo.h +++ b/xen/include/xen/bootinfo.h @@ -35,17 +35,18 @@ struct boot_module { mfn_t mfn; size_t size; - struct arch_bootmodule *arch; + arch_bootmodule_ptr_t arch; struct boot_string string; }; +DEFINE_STRUCT_PTR_TYPE(boot_module); struct boot_info { char *cmdline; unsigned int nr_mods; - struct boot_module *mods; + boot_module_ptr_t mods; - struct arch_boot_info *arch; + arch_boot_info_ptr_t arch; }; #endif diff --git a/xen/include/xen/types.h b/xen/include/xen/types.h index 6aba80500a..78a2079619 100644 --- a/xen/include/xen/types.h +++ b/xen/include/xen/types.h @@ -71,4 +71,9 @@ typedef bool bool_t; #define test_and_set_bool(b) xchg(&(b), true) #define test_and_clear_bool(b) xchg(&(b), false) +#ifndef DEFINE_STRUCT_PTR_TYPE +#define DEFINE_STRUCT_PTR_TYPE(struct_name) \ + typedef struct struct_name * struct_name ## _ptr_t; +#endif + #endif /* __TYPES_H__ */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 01 00:31:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 00:31:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557667.871228 (Exim 4.92) (envelope-from ) id 1qFOWi-0008SK-KP; Sat, 01 Jul 2023 00:31:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557667.871228; Sat, 01 Jul 2023 00:31:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFOWi-0008SD-HG; Sat, 01 Jul 2023 00:31:48 +0000 Received: by outflank-mailman (input) for mailman id 557667; Sat, 01 Jul 2023 00:31:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFOWh-0007yM-JQ for xen-devel@lists.xenproject.org; Sat, 01 Jul 2023 00:31:47 +0000 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [2607:f8b0:4864:20::431]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a6965cda-17a6-11ee-8611-37d641c3527e; Sat, 01 Jul 2023 02:31:43 +0200 (CEST) Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-6686708c986so2016989b3a.0 for ; Fri, 30 Jun 2023 17:31:43 -0700 (PDT) Received: from cog-dev.home ([70.103.208.83]) by smtp.gmail.com with ESMTPSA id s68-20020a632c47000000b0055b61cd99a1sm1824296pgs.81.2023.06.30.17.31.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jun 2023 17:31:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: a6965cda-17a6-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688171501; x=1690763501; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=e69b5gTZ8xv/z3fBnKcGKtSZdG5ASDalrjgP59JhG/4=; b=Uc+bsWyiiVRS6/ak3e7nNWgvDsm07FG9aSfYXLG6IdDkmxgRSFs8uj9+KckytCzS6t 6cDUUVJnRV2B2uZpOKB8qCmEVxhmGYx0aZjVKSVjY4eRB204KAdIfUnuekcB5E/arvLv /R+PwTzfUoF7fsOw2xAR6DYwcPKA5LOxk9TjklR3PEEGvRChPatSxmuxUs5dCzCf5/X0 qc3MzRPX5q8WSOrLf6e0PkvnwGBP5EC2RADreBhEVPcI9SHFkaCCgXOJE1ievl9VWVY4 Cei44fivdtBK1Gc03Mm4fxWEIrO5kuUNHy95/FOobl6bJitol09+NoU/pYc6CDwJ8kd+ 0uVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688171501; x=1690763501; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=e69b5gTZ8xv/z3fBnKcGKtSZdG5ASDalrjgP59JhG/4=; b=Fxyh/4e5wzn2e2yLqb31MBsN1AyWcXfbuqDNyM3cKxAqbQQwX/P3u+vZ4l2c0Bzmle p34PT//Kf++n0AZnJ+z4LGwQ/bXI8c20qnCm9ImT14qwnXN9oHFYiZJZzwQKSYPAKJyr sJOM1B0WF1uaG3qH6nQDgR+ZAc5ec3h0xH6Wi4jhsYNGCCoPKWTZQJsjDdCUau1tGVFz XOlbmHjZPKD5qA8Rx3MF8A8ZBF44KChgeRZhJMCxD1rwezGRG+LgLCQAbZOIqYwLhGtr a9egVXR1eRn6EQEhflwqhgybAwHHSM+RWVlmhK0m/jOsKy7Kf0PQY6xFsgInAEJ6FpvS RxJw== X-Gm-Message-State: ABy/qLbPXKt5I9R9nydBlAtCaac/OdSa9+gfiEDjy4icqUJJXT6YePsl FUn/PDy+LCutjosmYALWB2HlF7fHZOA= X-Google-Smtp-Source: APBJJlGMtpigqkyzfp5YokZTkCRps/5vTqNDZCZQZ1cAwWcehJ1Acq2dvmwyA19KQ10YdU1J+7JULQ== X-Received: by 2002:a05:6a00:2488:b0:681:142f:e8e3 with SMTP id c8-20020a056a00248800b00681142fe8e3mr5518207pfv.14.1688171501037; Fri, 30 Jun 2023 17:31:41 -0700 (PDT) Sender: Christopher Clark From: Christopher Clark To: xen-devel@lists.xenproject.org Cc: Daniel Smith , stefano.stabellini@amd.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Luca Fancellu , Volodymyr Babchuk , Rich Persaud Subject: [PATCH 01/11] x86 setup: move x86 boot module counting into a new boot_info struct Date: Fri, 30 Jun 2023 17:31:22 -0700 Message-Id: <20230701003132.2210306-2-christopher.w.clark@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230701003132.2210306-1-christopher.w.clark@gmail.com> References: <20230701003132.2210306-1-christopher.w.clark@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit An initial step towards a non-multiboot internal representation of boot modules for common code, starting with x86 setup and converting the fields that are accessed for the startup calculations. Introduce a new header, , and populate it with a new boot_info structure initially containing a count of the number of boot modules. The naming of the header, structure and fields is derived from the boot structures on Arm -- see arm/include/asm/setup.h -- as part of work towards aligning common architecture-neutral boot logic and structures. No functional change intended. Signed-off-by: Christopher Clark Signed-off-by: Daniel P. Smith changes since v1: - patch is a subset of patches 2 and 3 --- xen/arch/x86/setup.c | 58 +++++++++++++++++++++++--------------- xen/include/xen/bootinfo.h | 20 +++++++++++++ 2 files changed, 55 insertions(+), 23 deletions(-) create mode 100644 xen/include/xen/bootinfo.h diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 74e3915a4d..708639b236 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -1,3 +1,4 @@ +#include #include #include #include @@ -268,7 +269,16 @@ static int __init cf_check parse_acpi_param(const char *s) custom_param("acpi", parse_acpi_param); static const module_t *__initdata initial_images; -static unsigned int __initdata nr_initial_images; +static struct boot_info __initdata *boot_info; + +static void __init multiboot_to_bootinfo(multiboot_info_t *mbi) +{ + static struct boot_info __initdata info; + + info.nr_mods = mbi->mods_count; + + boot_info = &info; +} unsigned long __init initial_images_nrpages(nodeid_t node) { @@ -277,7 +287,7 @@ unsigned long __init initial_images_nrpages(nodeid_t node) unsigned long nr; unsigned int i; - for ( nr = i = 0; i < nr_initial_images; ++i ) + for ( nr = i = 0; i < boot_info->nr_mods; ++i ) { unsigned long start = initial_images[i].mod_start; unsigned long end = start + PFN_UP(initial_images[i].mod_end); @@ -293,7 +303,7 @@ void __init discard_initial_images(void) { unsigned int i; - for ( i = 0; i < nr_initial_images; ++i ) + for ( i = 0; i < boot_info->nr_mods; ++i ) { uint64_t start = (uint64_t)initial_images[i].mod_start << PAGE_SHIFT; @@ -301,7 +311,7 @@ void __init discard_initial_images(void) start + PAGE_ALIGN(initial_images[i].mod_end)); } - nr_initial_images = 0; + boot_info->nr_mods = 0; initial_images = NULL; } @@ -1020,6 +1030,8 @@ void __init noreturn __start_xen(unsigned long mbi_p) mod = __va(mbi->mods_addr); } + multiboot_to_bootinfo(mbi); + loader = (mbi->flags & MBI_LOADERNAME) ? (char *)__va(mbi->boot_loader_name) : "unknown"; @@ -1127,18 +1139,18 @@ void __init noreturn __start_xen(unsigned long mbi_p) bootsym(boot_edd_info_nr)); /* Check that we have at least one Multiboot module. */ - if ( !(mbi->flags & MBI_MODULES) || (mbi->mods_count == 0) ) + if ( !(mbi->flags & MBI_MODULES) || (boot_info->nr_mods == 0) ) panic("dom0 kernel not specified. Check bootloader configuration\n"); /* Check that we don't have a silly number of modules. */ - if ( mbi->mods_count > sizeof(module_map) * 8 ) + if ( boot_info->nr_mods > sizeof(module_map) * 8 ) { - mbi->mods_count = sizeof(module_map) * 8; + boot_info->nr_mods = sizeof(module_map) * 8; printk("Excessive multiboot modules - using the first %u only\n", - mbi->mods_count); + boot_info->nr_mods); } - bitmap_fill(module_map, mbi->mods_count); + bitmap_fill(module_map, boot_info->nr_mods); __clear_bit(0, module_map); /* Dom0 kernel is always first */ if ( pvh_boot ) @@ -1311,9 +1323,9 @@ void __init noreturn __start_xen(unsigned long mbi_p) kexec_reserve_area(&boot_e820); initial_images = mod; - nr_initial_images = mbi->mods_count; + boot_info->nr_mods = boot_info->nr_mods; - for ( i = 0; !efi_enabled(EFI_LOADER) && i < mbi->mods_count; i++ ) + for ( i = 0; !efi_enabled(EFI_LOADER) && i < boot_info->nr_mods; i++ ) { if ( mod[i].mod_start & (PAGE_SIZE - 1) ) panic("Bootloader didn't honor module alignment request\n"); @@ -1337,8 +1349,8 @@ void __init noreturn __start_xen(unsigned long mbi_p) * respective reserve_e820_ram() invocation below. No need to * query efi_boot_mem_unused() here, though. */ - mod[mbi->mods_count].mod_start = virt_to_mfn(_stext); - mod[mbi->mods_count].mod_end = __2M_rwdata_end - _stext; + mod[boot_info->nr_mods].mod_start = virt_to_mfn(_stext); + mod[boot_info->nr_mods].mod_end = __2M_rwdata_end - _stext; } modules_headroom = bzimage_headroom(bootstrap_map(mod), mod->mod_end); @@ -1398,7 +1410,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) { /* Don't overlap with modules. */ end = consider_modules(s, e, reloc_size + mask, - mod, mbi->mods_count, -1); + mod, boot_info->nr_mods, -1); end &= ~mask; } else @@ -1419,7 +1431,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) } /* Is the region suitable for relocating the multiboot modules? */ - for ( j = mbi->mods_count - 1; j >= 0; j-- ) + for ( j = boot_info->nr_mods - 1; j >= 0; j-- ) { unsigned long headroom = j ? 0 : modules_headroom; unsigned long size = PAGE_ALIGN(headroom + mod[j].mod_end); @@ -1429,7 +1441,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) /* Don't overlap with other modules (or Xen itself). */ end = consider_modules(s, e, size, mod, - mbi->mods_count + relocated, j); + boot_info->nr_mods + relocated, j); if ( highmem_start && end > highmem_start ) continue; @@ -1456,7 +1468,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) { /* Don't overlap with modules (or Xen itself). */ e = consider_modules(s, e, PAGE_ALIGN(kexec_crash_area.size), mod, - mbi->mods_count + relocated, -1); + boot_info->nr_mods + relocated, -1); if ( s >= e ) break; if ( e > kexec_crash_area_limit ) @@ -1471,7 +1483,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) if ( modules_headroom && !mod->reserved ) panic("Not enough memory to relocate the dom0 kernel image\n"); - for ( i = 0; i < mbi->mods_count; ++i ) + for ( i = 0; i < boot_info->nr_mods; ++i ) { uint64_t s = (uint64_t)mod[i].mod_start << PAGE_SHIFT; @@ -1540,7 +1552,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) ASSERT(j); } map_e = boot_e820.map[j].addr + boot_e820.map[j].size; - for ( j = 0; j < mbi->mods_count; ++j ) + for ( j = 0; j < boot_info->nr_mods; ++j ) { uint64_t end = pfn_to_paddr(mod[j].mod_start) + mod[j].mod_end; @@ -1616,7 +1628,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) } } - for ( i = 0; i < mbi->mods_count; ++i ) + for ( i = 0; i < boot_info->nr_mods; ++i ) { set_pdx_range(mod[i].mod_start, mod[i].mod_start + PFN_UP(mod[i].mod_end)); @@ -1999,8 +2011,8 @@ void __init noreturn __start_xen(unsigned long mbi_p) cpu_has_nx ? XENLOG_INFO : XENLOG_WARNING "Warning: ", cpu_has_nx ? "" : "not "); - initrdidx = find_first_bit(module_map, mbi->mods_count); - if ( bitmap_weight(module_map, mbi->mods_count) > 1 ) + initrdidx = find_first_bit(module_map, boot_info->nr_mods); + if ( bitmap_weight(module_map, boot_info->nr_mods) > 1 ) printk(XENLOG_WARNING "Multiple initrd candidates, picking module #%u\n", initrdidx); @@ -2010,7 +2022,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) * above our heap. The second module, if present, is an initrd ramdisk. */ dom0 = create_dom0(mod, modules_headroom, - initrdidx < mbi->mods_count ? mod + initrdidx : NULL, + initrdidx < boot_info->nr_mods ? mod + initrdidx : NULL, kextra, loader); if ( !dom0 ) panic("Could not set up DOM0 guest OS\n"); diff --git a/xen/include/xen/bootinfo.h b/xen/include/xen/bootinfo.h new file mode 100644 index 0000000000..6a7d55d20e --- /dev/null +++ b/xen/include/xen/bootinfo.h @@ -0,0 +1,20 @@ +#ifndef __XEN_BOOTINFO_H__ +#define __XEN_BOOTINFO_H__ + +#include + +struct boot_info { + unsigned int nr_mods; +}; + +#endif + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 01 00:31:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 00:31:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557669.871248 (Exim 4.92) (envelope-from ) id 1qFOWk-0000X7-Dg; Sat, 01 Jul 2023 00:31:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557669.871248; Sat, 01 Jul 2023 00:31:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFOWk-0000Wj-A8; Sat, 01 Jul 2023 00:31:50 +0000 Received: by outflank-mailman (input) for mailman id 557669; Sat, 01 Jul 2023 00:31:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFOWj-0007yB-4e for xen-devel@lists.xenproject.org; Sat, 01 Jul 2023 00:31:49 +0000 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [2607:f8b0:4864:20::436]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a9c2fbe6-17a6-11ee-b237-6b7b168915f2; Sat, 01 Jul 2023 02:31:48 +0200 (CEST) Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-666ecf9a081so1885991b3a.2 for ; Fri, 30 Jun 2023 17:31:48 -0700 (PDT) Received: from cog-dev.home ([70.103.208.83]) by smtp.gmail.com with ESMTPSA id s68-20020a632c47000000b0055b61cd99a1sm1824296pgs.81.2023.06.30.17.31.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jun 2023 17:31:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: a9c2fbe6-17a6-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688171506; x=1690763506; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=/bZBd6eRTKkd5JZ++Hy2rgV0U3swA0RaaPb02+sFNEo=; b=MTxzrGAITsLT46i4OhAoywi7PDozDmK8q/T2F09c3zFbuT2Y6eKs24RxEJO8+Kay4q jzAoyn0OCFx9AzDmriIAAn1h7oGp8to6nRjh5QqLvOXlA6AxT9iukyh/tuGKczv/pOcB RSQpcQguU7OWMAB1w2lNbdBWlPfejpXiFctURmffmSFX1P4XbhBij44g0d9HLgafSgBs h1mVKbeQbjXDv8ABL2W7VKqtbspGQabdM+E4yJOCx/QM5RNaKMd8Wqg+Jg/v70fGASUg GPXdgxQeS8nud8TZGue1Z66u7qh+el26tdF24UEaRrr8g9yq/UchAr0Ilt7Cz2Nqbf0y gcAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688171506; x=1690763506; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/bZBd6eRTKkd5JZ++Hy2rgV0U3swA0RaaPb02+sFNEo=; b=NYhfJ/Zrx8ez3SXhyFF4S/kE1hf1GZ9GLtlBrKT8PYQqX8q4wL1nVYAqsAPifrfoD8 lYLTTLeGSDMTxaOCbMpMe6qQuC6Bhd4vHkLCyx9cuqUt2mraiGReZ+Txzy4XoT3uBU7B o8us4suwoe3U8hn4aKhnda0qydRdVCRMk1vt2Ms07rqseIc+EjJJjo8S4AZBypXNvTni N7HoclEWxojtlLiyyV12oSeNydzSZzEQyyjl4rV4DbDPxXKBb058YDGMi4lUxB6JMnEH ndi28fMuivx0gd+414bRzK2IuleSV+QzjvlDE3eTiXJanaDeONoVjDQSbo02HoL3mDT3 4SmA== X-Gm-Message-State: ABy/qLbyufxNuorruzQAws8xnK2Aq5qgzW68g53fEh+v+3duuRJnhZAB qYuekxw022N2TUD16DI5OXd1UfVjNew= X-Google-Smtp-Source: APBJJlFBq6b+oL8y3j9HKkjC37NmJlsGa0wteQeagNzkCv7VOsuYvWWt9UFRAHuwAgSrK9WgXeiGbA== X-Received: by 2002:a05:6a00:18a4:b0:680:40b2:5419 with SMTP id x36-20020a056a0018a400b0068040b25419mr6592110pfh.4.1688171506475; Fri, 30 Jun 2023 17:31:46 -0700 (PDT) Sender: Christopher Clark From: Christopher Clark To: xen-devel@lists.xenproject.org Cc: Daniel Smith , stefano.stabellini@amd.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Luca Fancellu , Volodymyr Babchuk , Rich Persaud Subject: [PATCH 05/11] xsm: switch XSM init to boot info structures Date: Fri, 30 Jun 2023 17:31:26 -0700 Message-Id: <20230701003132.2210306-6-christopher.w.clark@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230701003132.2210306-1-christopher.w.clark@gmail.com> References: <20230701003132.2210306-1-christopher.w.clark@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Change the XSM implementation to use the boot info structure instead of the multiboot module_map. Drops a dependency on CONFIG_MULTIBOOT, so boot module logic is now used whenever the DEVICE_TREE specific logic (for Arm) is not, with the bootinfo header conditionally included to ensure no change on Arm. Adds a multiboot header inclusion into guest/xen/pvh-boot.c since it is no longer provided via transitive inclusion and the source in that file uses multiboot structures. Signed-off-by: Christopher Clark Signed-off-by: Daniel P. Smith Changes since v1: - derived from patches 2 and 3 - added pvh-boot.c multiboot header inclusion - conditional inclusion of bootinfo.h to avoid breaking Arm --- xen/arch/x86/guest/xen/pvh-boot.c | 1 + xen/arch/x86/setup.c | 2 +- xen/include/xsm/xsm.h | 28 +++++++-------- xen/xsm/xsm_core.c | 47 +++++++++++++++--------- xen/xsm/xsm_policy.c | 59 ++++++++++++++++--------------- 5 files changed, 77 insertions(+), 60 deletions(-) diff --git a/xen/arch/x86/guest/xen/pvh-boot.c b/xen/arch/x86/guest/xen/pvh-boot.c index 9cbe87b61b..1ed04d035c 100644 --- a/xen/arch/x86/guest/xen/pvh-boot.c +++ b/xen/arch/x86/guest/xen/pvh-boot.c @@ -9,6 +9,7 @@ #include #include #include +#include #include #include diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index f9b04daebd..a616ccc0a8 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -1835,7 +1835,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) mmio_ro_ranges = rangeset_new(NULL, "r/o mmio ranges", RANGESETF_prettyprint_hex); - xsm_multiboot_init(module_map, mbi); + xsm_bootmodule_init(boot_info); /* * IOMMU-related ACPI table parsing may require some of the system domains diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h index 8dad03fd3d..d409c30be6 100644 --- a/xen/include/xsm/xsm.h +++ b/xen/include/xsm/xsm.h @@ -16,8 +16,10 @@ #define __XSM_H__ #include +#ifndef CONFIG_HAS_DEVICE_TREE +# include +#endif #include -#include /* policy magic number (defined by XSM_MAGIC) */ typedef uint32_t xsm_magic_t; @@ -776,15 +778,14 @@ static inline int xsm_argo_send(const struct domain *d, const struct domain *t) #endif /* XSM_NO_WRAPPERS */ -#ifdef CONFIG_MULTIBOOT -int xsm_multiboot_init( - unsigned long *module_map, const multiboot_info_t *mbi); -int xsm_multiboot_policy_init( - unsigned long *module_map, const multiboot_info_t *mbi, - void **policy_buffer, size_t *policy_size); -#endif +#ifndef CONFIG_HAS_DEVICE_TREE +int xsm_bootmodule_init(const struct boot_info *info); +int xsm_bootmodule_policy_init( + const struct boot_info *info, const unsigned char **policy_buffer, + size_t *policy_size); + +#else -#ifdef CONFIG_HAS_DEVICE_TREE /* * Initialize XSM * @@ -826,15 +827,14 @@ static const inline struct xsm_ops *silo_init(void) #include -#ifdef CONFIG_MULTIBOOT -static inline int xsm_multiboot_init ( - unsigned long *module_map, const multiboot_info_t *mbi) +#ifndef CONFIG_HAS_DEVICE_TREE +static inline int xsm_bootmodule_init(const struct boot_info *info) { return 0; } -#endif -#ifdef CONFIG_HAS_DEVICE_TREE +#else + static inline int xsm_dt_init(void) { return 0; diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c index eaa028109b..301ae4dc8b 100644 --- a/xen/xsm/xsm_core.c +++ b/xen/xsm/xsm_core.c @@ -10,8 +10,12 @@ * as published by the Free Software Foundation. */ -#include +#ifndef CONFIG_HAS_DEVICE_TREE +# include +#endif #include +#include +#include #include #include @@ -138,26 +142,35 @@ static int __init xsm_core_init(const void *policy_buffer, size_t policy_size) return 0; } -#ifdef CONFIG_MULTIBOOT -int __init xsm_multiboot_init( - unsigned long *module_map, const multiboot_info_t *mbi) +/* + * ifdef'ing this against multiboot is no longer valid as the boot module + * is agnostic and it will be possible to dropped the ifndef should Arm + * adopt boot info + */ +#ifndef CONFIG_HAS_DEVICE_TREE +int __init xsm_bootmodule_init(const struct boot_info *bootinfo) { int ret = 0; - void *policy_buffer = NULL; + const unsigned char *policy_buffer = NULL; size_t policy_size = 0; printk("XSM Framework v" XSM_FRAMEWORK_VERSION " initialized\n"); if ( XSM_MAGIC ) { - ret = xsm_multiboot_policy_init(module_map, mbi, &policy_buffer, - &policy_size); - if ( ret ) - { - bootstrap_map(NULL); - printk(XENLOG_ERR "Error %d initializing XSM policy\n", ret); - return -EINVAL; - } + int ret = xsm_bootmodule_policy_init(bootinfo, &policy_buffer, + &policy_size); + bootstrap_map(NULL); + + if ( ret == -ENOENT ) + /* + * The XSM module needs a policy file but one was not located. + * Report as a warning and continue as the XSM module may late + * load a policy file. + */ + printk(XENLOG_WARNING "xsm: starting without a policy loaded!\n"); + else if ( ret ) + panic("Error %d initializing XSM policy\n", ret); } ret = xsm_core_init(policy_buffer, policy_size); @@ -165,9 +178,9 @@ int __init xsm_multiboot_init( return 0; } -#endif -#ifdef CONFIG_HAS_DEVICE_TREE +#else + int __init xsm_dt_init(void) { int ret = 0; @@ -215,9 +228,9 @@ bool __init has_xsm_magic(paddr_t start) return false; } -#endif +#endif /* CONFIG_HAS_DEVICE_TREE */ -#endif +#endif /* CONFIG_XSM */ long do_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op) { diff --git a/xen/xsm/xsm_policy.c b/xen/xsm/xsm_policy.c index c6df8c6e06..f1970c8964 100644 --- a/xen/xsm/xsm_policy.c +++ b/xen/xsm/xsm_policy.c @@ -18,62 +18,65 @@ * */ -#include -#ifdef CONFIG_MULTIBOOT -#include -#include -#include -#endif #include +#ifndef CONFIG_HAS_DEVICE_TREE +# include +#endif +#include #ifdef CONFIG_HAS_DEVICE_TREE -# include # include +#else +#include #endif -#ifdef CONFIG_MULTIBOOT -int __init xsm_multiboot_policy_init( - unsigned long *module_map, const multiboot_info_t *mbi, - void **policy_buffer, size_t *policy_size) +#include + +#ifndef CONFIG_HAS_DEVICE_TREE +int __init xsm_bootmodule_policy_init( + const struct boot_info *bootinfo, const unsigned char **policy_buffer, + size_t *policy_size) { - int i; - module_t *mod = (module_t *)__va(mbi->mods_addr); - int rc = 0; + unsigned long i; + int rc = -ENOENT; u32 *_policy_start; unsigned long _policy_len; - /* - * Try all modules and see whichever could be the binary policy. - * Adjust module_map for the module that is the binary policy. - */ - for ( i = mbi->mods_count-1; i >= 1; i-- ) - { - if ( !test_bit(i, module_map) ) - continue; +#ifdef CONFIG_XSM_FLASK_POLICY + /* Initially set to builtin policy, overriden if boot module is found. */ + *policy_buffer = xsm_flask_init_policy; + *policy_size = xsm_flask_init_policy_size; + rc = 0; +#endif - _policy_start = bootstrap_map_multiboot(mod + i); - _policy_len = mod[i].mod_end; + i = bootmodule_index(bootinfo, BOOTMOD_UNKNOWN, 0); + while ( i < bootinfo->nr_mods ) + { + _policy_start = bootstrap_map(&bootinfo->mods[i]); + _policy_len = bootinfo->mods[i].size; if ( (xsm_magic_t)(*_policy_start) == XSM_MAGIC ) { - *policy_buffer = _policy_start; + *policy_buffer = (unsigned char *)_policy_start; *policy_size = _policy_len; printk("Policy len %#lx, start at %p.\n", _policy_len,_policy_start); - __clear_bit(i, module_map); + bootinfo->mods[i].bootmod_type = BOOTMOD_XSM; + rc = 0; break; } bootstrap_map(NULL); + i = bootmodule_index(bootinfo, BOOTMOD_UNKNOWN, ++i); } return rc; } -#endif -#ifdef CONFIG_HAS_DEVICE_TREE +#else + int __init xsm_dt_policy_init(void **policy_buffer, size_t *policy_size) { struct bootmodule *mod = boot_module_find_by_kind(BOOTMOD_XSM); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 01 00:31:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 00:31:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557672.871272 (Exim 4.92) (envelope-from ) id 1qFOWn-000193-Nt; Sat, 01 Jul 2023 00:31:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557672.871272; Sat, 01 Jul 2023 00:31:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFOWn-00017y-Gt; Sat, 01 Jul 2023 00:31:53 +0000 Received: by outflank-mailman (input) for mailman id 557672; Sat, 01 Jul 2023 00:31:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFOWl-0007yM-CS for xen-devel@lists.xenproject.org; Sat, 01 Jul 2023 00:31:51 +0000 Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [2607:f8b0:4864:20::731]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aa5d7fcc-17a6-11ee-8611-37d641c3527e; Sat, 01 Jul 2023 02:31:49 +0200 (CEST) Received: by mail-qk1-x731.google.com with SMTP id af79cd13be357-76728ae3162so224236785a.3 for ; Fri, 30 Jun 2023 17:31:49 -0700 (PDT) Received: from cog-dev.home ([70.103.208.83]) by smtp.gmail.com with ESMTPSA id s68-20020a632c47000000b0055b61cd99a1sm1824296pgs.81.2023.06.30.17.31.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jun 2023 17:31:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: aa5d7fcc-17a6-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688171507; x=1690763507; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=tNP8VdblK4Rt8e2FoRKT44HjkzeP53PPJ4jpSpNQaUw=; b=dZsj6vciSfnMLCMaU0cMPpVzsvTf2cA6H5rK4dqitVEHa7PIl9bqnNbVX3YCmArVSD IMEXc7JXp9i0n/PGdZX9qMeKuVaEdqi1JfQcIbGoD4A3Tg/fYHZ5qWS5LnG8xrnN8FH1 Qri/PoGiBRsUxe8lInpy/Y3tNDsK+N/06FDCG77bszgiEqbDDNt1ISOCF7hrbk0zEJZF u3xEDplqMMf5QyYIZXM+igxM68XL6fyrQU/HlA+q/V8iig/rjo8PHvxFVZnmdcg9lZsV 5KpUfri4831gj2h32ooplKW5XrDdfAHBoQV/NLL9yEaAH4ZJQQM+UxajHNgk+edO/lhN CM9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688171507; x=1690763507; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=tNP8VdblK4Rt8e2FoRKT44HjkzeP53PPJ4jpSpNQaUw=; b=OzBtmcktinPgWc4XhtkaIz/SXeaJ6nzCQuxZxTc2JMoAV2ZcCRLdjcX+gt+dJcGZKY A6IzBRT5MOmL5RBHqkdqyRD4PR4clvF+tD583EyrF+YdyOfAUuylU1Cg3BQEIi4g1SjI OvuG/96KKedmGW08c1W8twytVnn3Z4IZpNGIGldqXFu1T6hQHnrUL8gQZDRU6aAH+w1h uDrAevlVcDerI55VGHvTwEQ640xI9B1QjbD8QQoEVSJ/XhKgBFcr4RHmGZRggjQyyNA4 Y9f0KegaY0Pgq1kn560TCPt0rE2xrEWFotxKeIJf2QUS4dpbS74EmzR33hdzSKUHaHUP RpKg== X-Gm-Message-State: ABy/qLawIMHRzXLb3UaViZv69lx9jqBV9Ddkd89tCgnFNahEBlioCNmd uhRiyZjbQweGuNo9EAqK8cFOjEtlfxw= X-Google-Smtp-Source: APBJJlHXadhO0zI3fny7/VsDSq54jA5+/G/AaPurjt0vF6Vo+E7TEPOAcjmOGo6hXLaSNWVGV0iNyg== X-Received: by 2002:a05:620a:29d2:b0:767:3999:5277 with SMTP id s18-20020a05620a29d200b0076739995277mr5531547qkp.70.1688171507611; Fri, 30 Jun 2023 17:31:47 -0700 (PDT) Sender: Christopher Clark From: Christopher Clark To: xen-devel@lists.xenproject.org Cc: Daniel Smith , stefano.stabellini@amd.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Luca Fancellu , Volodymyr Babchuk , Rich Persaud Subject: [PATCH 06/11] x86 setup, microcode: switch to the new bootinfo structures Date: Fri, 30 Jun 2023 17:31:27 -0700 Message-Id: <20230701003132.2210306-7-christopher.w.clark@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230701003132.2210306-1-christopher.w.clark@gmail.com> References: <20230701003132.2210306-1-christopher.w.clark@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Next step in incremental work towards adding a non-multiboot internal representation of boot modules, converting the fields being accessed for the startup calculations. Move the per-module scan logic into a dedicated function from the iteration loop and set the BOOTMOD_UCODE module type when microcode is found. Completes the conversion from the module_map bitmap in x86 setup so it can be removed, along with the temporary bootstrap_map multiboot wrapper since the last code that uses it is removed in this change. Signed-off-by: Christopher Clark Signed-off-by: Daniel P. Smith changes since v1: - an incremental subset of patch 3 - added the drop of the temporary bootstrap map --- xen/arch/x86/cpu/microcode/core.c | 148 +++++++++++++++------------ xen/arch/x86/include/asm/boot.h | 13 --- xen/arch/x86/include/asm/microcode.h | 7 +- xen/arch/x86/setup.c | 8 +- 4 files changed, 89 insertions(+), 87 deletions(-) diff --git a/xen/arch/x86/cpu/microcode/core.c b/xen/arch/x86/cpu/microcode/core.c index e720a89167..c674ccf88c 100644 --- a/xen/arch/x86/cpu/microcode/core.c +++ b/xen/arch/x86/cpu/microcode/core.c @@ -22,12 +22,12 @@ */ #include +#include #include #include #include #include #include -#include #include #include #include @@ -57,7 +57,6 @@ */ #define MICROCODE_UPDATE_TIMEOUT_US 1000000 -static module_t __initdata ucode_mod; static signed int __initdata ucode_mod_idx; static bool_t __initdata ucode_mod_forced; static unsigned int nr_cores; @@ -150,75 +149,109 @@ static int __init cf_check parse_ucode(const char *s) } custom_param("ucode", parse_ucode); -void __init microcode_scan_module( - unsigned long *module_map, - const multiboot_info_t *mbi) +#define MICROCODE_MODULE_MATCH 1 +#define MICROCODE_MODULE_NONMATCH 0 + +static int __init microcode_check_module(struct boot_module *mod) { - module_t *mod = (module_t *)__va(mbi->mods_addr); uint64_t *_blob_start; unsigned long _blob_size; - struct cpio_data cd; + struct cpio_data cd = { NULL, 0 }; long offset; const char *p = NULL; - int i; - - ucode_blob.size = 0; - if ( !ucode_scan ) - return; if ( boot_cpu_data.x86_vendor == X86_VENDOR_AMD ) p = "kernel/x86/microcode/AuthenticAMD.bin"; else if ( boot_cpu_data.x86_vendor == X86_VENDOR_INTEL ) p = "kernel/x86/microcode/GenuineIntel.bin"; else + return -EFAULT; + + _blob_start = bootstrap_map(mod); + _blob_size = mod->size; + if ( !_blob_start ) + { + printk("Could not map multiboot module (0x%lx) (size: %ld)\n", + mod->start, _blob_size); + /* Non-fatal error, so just say no match */ + return MICROCODE_MODULE_NONMATCH; + } + + cd = find_cpio_data(p, _blob_start, _blob_size, &offset /* ignore */); + + if ( cd.data ) + { + ucode_blob.size = cd.size; + ucode_blob.data = cd.data; + + mod->bootmod_type = BOOTMOD_UCODE; + return MICROCODE_MODULE_MATCH; + } + + bootstrap_map(NULL); + + return MICROCODE_MODULE_NONMATCH; +} + +void __init microcode_scan_module(struct boot_info *bootinfo) +{ + int i; + + if ( !ucode_scan ) return; - /* - * Try all modules and see whichever could be the microcode blob. - */ - for ( i = 1 /* Ignore dom0 kernel */; i < mbi->mods_count; i++ ) + i = bootmodule_index(bootinfo, BOOTMOD_UNKNOWN, 0); + while ( i < bootinfo->nr_mods ) { - if ( !test_bit(i, module_map) ) - continue; + int ret = microcode_check_module(&bootinfo->mods[i]); - _blob_start = bootstrap_map_multiboot(&mod[i]); - _blob_size = mod[i].mod_end; - if ( !_blob_start ) + switch ( ret ) { - printk("Could not map multiboot module #%d (size: %ld)\n", - i, _blob_size); + case MICROCODE_MODULE_MATCH: + return; + case MICROCODE_MODULE_NONMATCH: + i = bootmodule_index(bootinfo, BOOTMOD_UNKNOWN, ++i); continue; + default: + printk("%s: (err: %d) unable to check microcode\n", + __func__, ret); + return; } - cd.data = NULL; - cd.size = 0; - cd = find_cpio_data(p, _blob_start, _blob_size, &offset /* ignore */); - if ( cd.data ) - { - ucode_blob.size = cd.size; - ucode_blob.data = cd.data; - break; - } - bootstrap_map(NULL); } } -static void __init microcode_grab_module( - unsigned long *module_map, - const multiboot_info_t *mbi) +static void __init microcode_grab_module(struct boot_info *bootinfo) { - module_t *mod = (module_t *)__va(mbi->mods_addr); + ucode_blob.size = 0; if ( ucode_mod_idx < 0 ) - ucode_mod_idx += mbi->mods_count; - if ( ucode_mod_idx <= 0 || ucode_mod_idx >= mbi->mods_count || - !__test_and_clear_bit(ucode_mod_idx, module_map) ) - goto scan; - ucode_mod = mod[ucode_mod_idx]; -scan: + ucode_mod_idx += bootinfo->nr_mods; + if ( ucode_mod_idx >= 0 && ucode_mod_idx <= bootinfo->nr_mods && + bootinfo->mods[ucode_mod_idx].bootmod_type == BOOTMOD_UNKNOWN ) + { + int ret = microcode_check_module(&bootinfo->mods[ucode_mod_idx]); + + switch ( ret ) + { + case MICROCODE_MODULE_MATCH: + return; + case MICROCODE_MODULE_NONMATCH: + break; + default: + printk("%s: (err: %d) unable to check microcode\n", + __func__, ret); + return; + } + } + if ( ucode_scan ) - microcode_scan_module(module_map, mbi); + microcode_scan_module(bootinfo); } +/* Undefining as they are not needed anymore */ +#undef MICROCODE_MODULE_MATCH +#undef MICROCODE_MODULE_NONMATCH + static struct microcode_ops __ro_after_init ucode_ops; static DEFINE_SPINLOCK(microcode_mutex); @@ -737,11 +770,6 @@ static int __init cf_check microcode_init(void) ucode_blob.size = 0; ucode_blob.data = NULL; } - else if ( ucode_mod.mod_end ) - { - bootstrap_map(NULL); - ucode_mod.mod_end = 0; - } return 0; } @@ -785,19 +813,15 @@ static int __init early_update_cache(const void *data, size_t len) return rc; } -int __init microcode_init_cache(unsigned long *module_map, - const struct multiboot_info *mbi) +int __init microcode_init_cache(struct boot_info *bootinfo) { int rc = 0; if ( ucode_scan ) /* Need to rescan the modules because they might have been relocated */ - microcode_scan_module(module_map, mbi); + microcode_scan_module(bootinfo); - if ( ucode_mod.mod_end ) - rc = early_update_cache(bootstrap_map_multiboot(&ucode_mod), - ucode_mod.mod_end); - else if ( ucode_blob.size ) + if ( ucode_blob.size ) rc = early_update_cache(ucode_blob.data, ucode_blob.size); return rc; @@ -815,11 +839,6 @@ static int __init early_microcode_update_cpu(void) len = ucode_blob.size; data = ucode_blob.data; } - else if ( ucode_mod.mod_end ) - { - len = ucode_mod.mod_end; - data = bootstrap_map_multiboot(&ucode_mod); - } if ( !data ) return -ENOMEM; @@ -838,8 +857,7 @@ static int __init early_microcode_update_cpu(void) return microcode_update_cpu(patch); } -int __init early_microcode_init(unsigned long *module_map, - const struct multiboot_info *mbi) +int __init early_microcode_init(struct boot_info *bootinfo) { const struct cpuinfo_x86 *c = &boot_cpu_data; int rc = 0; @@ -863,11 +881,11 @@ int __init early_microcode_init(unsigned long *module_map, return -ENODEV; } - microcode_grab_module(module_map, mbi); + microcode_grab_module(bootinfo); ucode_ops.collect_cpu_info(); - if ( ucode_mod.mod_end || ucode_blob.size ) + if ( ucode_blob.size ) rc = early_microcode_update_cpu(); return rc; diff --git a/xen/arch/x86/include/asm/boot.h b/xen/arch/x86/include/asm/boot.h index bcf4f2e2e3..e51fd32280 100644 --- a/xen/arch/x86/include/asm/boot.h +++ b/xen/arch/x86/include/asm/boot.h @@ -6,19 +6,6 @@ #include -static inline void *bootstrap_map_multiboot(const module_t *mod) -{ - struct boot_module bm; - - if ( !mod ) - return bootstrap_map(NULL); - - bm.start = mod->mod_start << PAGE_SHIFT; - bm.size = mod->mod_end; - - return bootstrap_map(&bm); -} - static inline unsigned long bootmodule_index( const struct boot_info *info, bootmod_type_t bootmod_type, unsigned long start) diff --git a/xen/arch/x86/include/asm/microcode.h b/xen/arch/x86/include/asm/microcode.h index 62ce3418f7..803fbbb270 100644 --- a/xen/arch/x86/include/asm/microcode.h +++ b/xen/arch/x86/include/asm/microcode.h @@ -1,6 +1,7 @@ #ifndef ASM_X86__MICROCODE_H #define ASM_X86__MICROCODE_H +#include #include #include @@ -23,10 +24,8 @@ DECLARE_PER_CPU(struct cpu_signature, cpu_sig); void microcode_set_module(unsigned int idx); int microcode_update(XEN_GUEST_HANDLE(const_void), unsigned long len); -int early_microcode_init(unsigned long *module_map, - const struct multiboot_info *mbi); -int microcode_init_cache(unsigned long *module_map, - const struct multiboot_info *mbi); +int early_microcode_init(struct boot_info *bootinfo); +int microcode_init_cache(struct boot_info *bootinfo); int microcode_update_one(void); #endif /* ASM_X86__MICROCODE_H */ diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index a616ccc0a8..50a1a124b0 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -1023,7 +1023,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) unsigned int initrdidx, num_parked = 0; multiboot_info_t *mbi; module_t *mod; - unsigned long nr_pages, raw_max_page, module_map[1]; + unsigned long nr_pages, raw_max_page; int i, j, e820_warn = 0, bytes = 0; unsigned long eb_start, eb_end; bool acpi_boot_table_init_done = false, relocated = false; @@ -1190,8 +1190,6 @@ void __init noreturn __start_xen(unsigned long mbi_p) } /* Dom0 kernel is the first boot module */ - bitmap_fill(module_map, mbi->mods_count); - __clear_bit(0, module_map); /* Dom0 kernel is always first */ boot_info->mods[0].bootmod_type = BOOTMOD_KERNEL; if ( pvh_boot ) @@ -1371,7 +1369,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) * TODO: load ucode earlier once multiboot modules become accessible * at an earlier stage. */ - early_microcode_init(module_map, mbi); + early_microcode_init(boot_info); if ( xen_phys_start ) { @@ -1906,7 +1904,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) timer_init(); - microcode_init_cache(module_map, mbi); /* Needs xmalloc() */ + microcode_init_cache(boot_info); /* Needs xmalloc() */ tsx_init(); /* Needs microcode. May change HLE/RTM feature bits. */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 01 00:31:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 00:31:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557670.871257 (Exim 4.92) (envelope-from ) id 1qFOWl-0000o5-Ow; Sat, 01 Jul 2023 00:31:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557670.871257; Sat, 01 Jul 2023 00:31:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFOWl-0000mP-L1; Sat, 01 Jul 2023 00:31:51 +0000 Received: by outflank-mailman (input) for mailman id 557670; Sat, 01 Jul 2023 00:31:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFOWk-0007yM-C9 for xen-devel@lists.xenproject.org; Sat, 01 Jul 2023 00:31:50 +0000 Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [2607:f8b0:4864:20::22c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a96729e1-17a6-11ee-8611-37d641c3527e; Sat, 01 Jul 2023 02:31:47 +0200 (CEST) Received: by mail-oi1-x22c.google.com with SMTP id 5614622812f47-3a1a47b33d8so1881850b6e.2 for ; Fri, 30 Jun 2023 17:31:47 -0700 (PDT) Received: from cog-dev.home ([70.103.208.83]) by smtp.gmail.com with ESMTPSA id s68-20020a632c47000000b0055b61cd99a1sm1824296pgs.81.2023.06.30.17.31.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jun 2023 17:31:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: a96729e1-17a6-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688171506; x=1690763506; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=y7s+a48s6nJcYJpi0CKsRE8Fk9vJ+e5NEZSgNSxP5/8=; b=W/Ori2UF5GdZ2XTZUYb7SeemZMmXHFyT5AmYNUYzZYR8m3DlTjhAIlYMyFrqeTXavn ApUJYnarY5VGN5Tu9EM1aQnNSUmAba1kJGAiVzVu3dYiGQFTOj1zZb4QCDP6qkUQsEg3 /AYkZJiTd10O0+u5oCZzM5XUQCWyDv9QPiVV5l/W1Z/gUunTNlDLSjsGwKU5MQhQLvo4 lNX1yE37dfgzMaBoCgFG+haXttyy7gTUaQmTx+F9FTcZarjT7WPvQSZQ+sEb1Aoyg+8H dYhW5gOEl7FHl4wZWB4IN/T+asWd+xews11MoYsBcLjnSnyg3ev+AM8/pT4J6RxDobpr BFRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688171506; x=1690763506; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=y7s+a48s6nJcYJpi0CKsRE8Fk9vJ+e5NEZSgNSxP5/8=; b=jJP5mWtb3jelZ0x3lMPFBTK8MhQK8vUlW1X3/xXhkRaQeAwEuptJ9LdOjc9As/2TxQ MvJ8jwe1LGpqR+1UoKM9Bkp1uwnXCO0ykMy0efGQaMSiIwgVmmt/QxMz7nw+Z9cQY9+B AU9JM3jJyBUdsjW6OHgrkZU7RjaTJCec6Kde5K8RDVly81bbdtUOITUJz23elL7jZVj6 Rd/QeUH/S/a6rKE2f19aw5VZmWlZny7KQOOv9ELSEOdVBRCfJPc0YBdMm7HfiqX+Mk4z oIsPRBAte+/77TBklb51FfqxeUZIN3baQNMwHue8QhjFYYesRfso6M/OZYcXn8AUHroE Y2Wg== X-Gm-Message-State: AC+VfDyd7EWNkgijy/lTGrHDAtTrE6a673a2r9dMw7tTtl4Co5tbjJcj vmITOnGYG8McfZP2Oe7eV2SeneZ2iH4= X-Google-Smtp-Source: ACHHUZ7Jdwgu9s3VF78UoKENhjUUxgTBZur8e6sBoFcYKPjtIKlqM0Dh2E7ma7w5eCQzKVE4ipK9gg== X-Received: by 2002:a05:6808:1b0c:b0:3a1:b309:a409 with SMTP id bx12-20020a0568081b0c00b003a1b309a409mr5339601oib.4.1688171505329; Fri, 30 Jun 2023 17:31:45 -0700 (PDT) Sender: Christopher Clark From: Christopher Clark To: xen-devel@lists.xenproject.org Cc: Daniel Smith , stefano.stabellini@amd.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Luca Fancellu , Volodymyr Babchuk , Rich Persaud Subject: [PATCH 04/11] x86 setup: porting dom0 construction logic to boot module structures Date: Fri, 30 Jun 2023 17:31:25 -0700 Message-Id: <20230701003132.2210306-5-christopher.w.clark@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230701003132.2210306-1-christopher.w.clark@gmail.com> References: <20230701003132.2210306-1-christopher.w.clark@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adjust the PV and PVH dom0 construction entry points to take boot module structures as parameters, and add further fields to the boot module structures to plumb the data needed to support this use. Populate these from the multiboot module data. This change removes multiboot from the PV and PVH dom0 construction logic. Introduce and use new inline accessor functions for navigating the boot module structures. The per-boot-module arrays are expanded from singletons to accommodate all modules, up to a static maximum of 64 modules including Xen that can be accepted from a bootloader to match the previous value from the module map check. The field that identifies the type of a boot module (kernel, ramdisk, etc) is introduced to the common boot module structure and declared as a non-enum integer type to allow the field to be of a known-size and so structure can be packed in a subsequent patch in the series, and it will then be reconciled with the equivalent Arm boot field type. The command line provided by multiboot for each boot module is added directly to the boot_module structure, which is appropriate for this logic just replacing multiboot. The maximum number of boot modules that a bootloader can provide in addition to the Xen hypervisor is preserved from prior logic with the module_map at 63. Signed-off-by: Christopher Clark Signed-off-by: Daniel P. Smith changes since v1: a subset of patch 3 - retains module_map for now as still used functions outside setup - move the static inline functions to a separate dedicated header - include mm-frame.h and compiler.h as simpler dependencies than mm.h --- xen/arch/x86/dom0_build.c | 10 +- xen/arch/x86/hvm/dom0_build.c | 43 +++--- xen/arch/x86/include/asm/boot.h | 36 +++++ xen/arch/x86/include/asm/bootinfo.h | 24 +++ xen/arch/x86/include/asm/dom0_build.h | 13 +- xen/arch/x86/include/asm/setup.h | 4 +- xen/arch/x86/pv/dom0_build.c | 32 ++-- xen/arch/x86/setup.c | 206 +++++++++++++++----------- xen/include/xen/bootinfo.h | 27 ++++ 9 files changed, 254 insertions(+), 141 deletions(-) diff --git a/xen/arch/x86/dom0_build.c b/xen/arch/x86/dom0_build.c index 79234f18ff..b38cd1550e 100644 --- a/xen/arch/x86/dom0_build.c +++ b/xen/arch/x86/dom0_build.c @@ -4,6 +4,7 @@ * Copyright (c) 2002-2005, K A Fraser */ +#include #include #include #include @@ -574,9 +575,8 @@ int __init dom0_setup_permissions(struct domain *d) return rc; } -int __init construct_dom0(struct domain *d, const module_t *image, - unsigned long image_headroom, module_t *initrd, - char *cmdline) +int __init construct_dom0(struct domain *d, const struct boot_module *image, + struct boot_module *initrd, char *cmdline) { int rc; @@ -588,9 +588,9 @@ int __init construct_dom0(struct domain *d, const module_t *image, process_pending_softirqs(); if ( is_hvm_domain(d) ) - rc = dom0_construct_pvh(d, image, image_headroom, initrd, cmdline); + rc = dom0_construct_pvh(d, image, initrd, cmdline); else if ( is_pv_domain(d) ) - rc = dom0_construct_pv(d, image, image_headroom, initrd, cmdline); + rc = dom0_construct_pv(d, image, initrd, cmdline); else panic("Cannot construct Dom0. No guest interface available\n"); diff --git a/xen/arch/x86/hvm/dom0_build.c b/xen/arch/x86/hvm/dom0_build.c index 56fe89632b..c094863bb8 100644 --- a/xen/arch/x86/hvm/dom0_build.c +++ b/xen/arch/x86/hvm/dom0_build.c @@ -8,9 +8,9 @@ */ #include +#include #include #include -#include #include #include @@ -530,14 +530,13 @@ static paddr_t __init find_memory( return INVALID_PADDR; } -static int __init pvh_load_kernel(struct domain *d, const module_t *image, - unsigned long image_headroom, - module_t *initrd, void *image_base, - char *cmdline, paddr_t *entry, - paddr_t *start_info_addr) +static int __init pvh_load_kernel( + struct domain *d, const struct boot_module *image, + struct boot_module *initrd, void *image_base, char *cmdline, paddr_t *entry, + paddr_t *start_info_addr) { - void *image_start = image_base + image_headroom; - unsigned long image_len = image->mod_end; + void *image_start = image_base + image->arch->headroom; + unsigned long image_len = image->size; struct elf_binary elf; struct elf_dom_parms parms; paddr_t last_addr; @@ -546,7 +545,7 @@ static int __init pvh_load_kernel(struct domain *d, const module_t *image, struct vcpu *v = d->vcpu[0]; int rc; - if ( (rc = bzimage_parse(image_base, &image_start, image_headroom, + if ( (rc = bzimage_parse(image_base, &image_start, image->arch->headroom, &image_len)) != 0 ) { printk("Error trying to detect bz compressed kernel\n"); @@ -594,7 +593,7 @@ static int __init pvh_load_kernel(struct domain *d, const module_t *image, * simplify it. */ last_addr = find_memory(d, &elf, sizeof(start_info) + - (initrd ? ROUNDUP(initrd->mod_end, PAGE_SIZE) + + (initrd ? ROUNDUP(initrd->size, PAGE_SIZE) + sizeof(mod) : 0) + (cmdline ? ROUNDUP(strlen(cmdline) + 1, @@ -608,8 +607,8 @@ static int __init pvh_load_kernel(struct domain *d, const module_t *image, if ( initrd != NULL ) { - rc = hvm_copy_to_guest_phys(last_addr, mfn_to_virt(initrd->mod_start), - initrd->mod_end, v); + rc = hvm_copy_to_guest_phys(last_addr, maddr_to_virt(initrd->start), + initrd->size, v); if ( rc ) { printk("Unable to copy initrd to guest\n"); @@ -617,11 +616,11 @@ static int __init pvh_load_kernel(struct domain *d, const module_t *image, } mod.paddr = last_addr; - mod.size = initrd->mod_end; - last_addr += ROUNDUP(initrd->mod_end, elf_64bit(&elf) ? 8 : 4); - if ( initrd->string ) + mod.size = initrd->size; + last_addr += ROUNDUP(initrd->size, elf_64bit(&elf) ? 8 : 4); + if ( initrd->string.len ) { - char *str = __va(initrd->string); + char *str = initrd->string.bytes; size_t len = strlen(str) + 1; rc = hvm_copy_to_guest_phys(last_addr, str, len, v); @@ -1176,10 +1175,9 @@ static void __hwdom_init pvh_setup_mmcfg(struct domain *d) } } -int __init dom0_construct_pvh(struct domain *d, const module_t *image, - unsigned long image_headroom, - module_t *initrd, - char *cmdline) +int __init dom0_construct_pvh( + struct domain *d, const struct boot_module *image, + struct boot_module *initrd, char *cmdline) { paddr_t entry, start_info; int rc; @@ -1209,9 +1207,8 @@ int __init dom0_construct_pvh(struct domain *d, const module_t *image, return rc; } - rc = pvh_load_kernel(d, image, image_headroom, initrd, - bootstrap_map_multiboot(image), - cmdline, &entry, &start_info); + rc = pvh_load_kernel(d, image, initrd, bootstrap_map(image), cmdline, + &entry, &start_info); if ( rc ) { printk("Failed to load Dom0 kernel\n"); diff --git a/xen/arch/x86/include/asm/boot.h b/xen/arch/x86/include/asm/boot.h index 10b17f12b2..bcf4f2e2e3 100644 --- a/xen/arch/x86/include/asm/boot.h +++ b/xen/arch/x86/include/asm/boot.h @@ -19,6 +19,42 @@ static inline void *bootstrap_map_multiboot(const module_t *mod) return bootstrap_map(&bm); } +static inline unsigned long bootmodule_index( + const struct boot_info *info, bootmod_type_t bootmod_type, + unsigned long start) +{ + for ( ; start < info->nr_mods; start++ ) + if ( info->mods[start].bootmod_type == bootmod_type ) + return start; + + return info->nr_mods + 1; +} + +static inline struct boot_module *bootmodule_next( + const struct boot_info *info, bootmod_type_t bootmod_type) +{ + unsigned long i; + + for ( i = 0; i < info->nr_mods; i++ ) + if ( info->mods[i].bootmod_type == bootmod_type ) + return &info->mods[i]; + + return NULL; +} + +static inline void bootmodule_update_start(struct boot_module *bm, + paddr_t new_start) +{ + bm->start = new_start; + bm->mfn = maddr_to_mfn(new_start); +} + +static inline void bootmodule_update_mfn(struct boot_module *bm, mfn_t new_mfn) +{ + bm->mfn = new_mfn; + bm->start = mfn_to_maddr(new_mfn); +} + #endif /* diff --git a/xen/arch/x86/include/asm/bootinfo.h b/xen/arch/x86/include/asm/bootinfo.h index a25054f372..30c27980e0 100644 --- a/xen/arch/x86/include/asm/bootinfo.h +++ b/xen/arch/x86/include/asm/bootinfo.h @@ -2,9 +2,33 @@ #define __ARCH_X86_BOOTINFO_H__ struct arch_bootmodule { +#define BOOTMOD_FLAG_X86_RELOCATED 1U << 0 + uint32_t flags; unsigned headroom; }; +struct arch_boot_info { + uint32_t flags; +#define BOOTINFO_FLAG_X86_CMDLINE 1U << 2 +#define BOOTINFO_FLAG_X86_MODULES 1U << 3 +#define BOOTINFO_FLAG_X86_MEMMAP 1U << 6 +#define BOOTINFO_FLAG_X86_LOADERNAME 1U << 9 + + char *boot_loader_name; + + uint32_t mmap_length; + paddr_t mmap_addr; +}; + +struct __packed mb_memmap { + uint32_t size; + uint32_t base_addr_low; + uint32_t base_addr_high; + uint32_t length_low; + uint32_t length_high; + uint32_t type; +}; + #endif /* diff --git a/xen/arch/x86/include/asm/dom0_build.h b/xen/arch/x86/include/asm/dom0_build.h index a5f8c9e67f..ca502269f2 100644 --- a/xen/arch/x86/include/asm/dom0_build.h +++ b/xen/arch/x86/include/asm/dom0_build.h @@ -1,6 +1,7 @@ #ifndef _DOM0_BUILD_H_ #define _DOM0_BUILD_H_ +#include #include #include @@ -13,15 +14,11 @@ unsigned long dom0_compute_nr_pages(struct domain *d, unsigned long initrd_len); int dom0_setup_permissions(struct domain *d); -int dom0_construct_pv(struct domain *d, const module_t *image, - unsigned long image_headroom, - module_t *initrd, - char *cmdline); +int dom0_construct_pv(struct domain *d, const struct boot_module *image, + struct boot_module *initrd, char *cmdline); -int dom0_construct_pvh(struct domain *d, const module_t *image, - unsigned long image_headroom, - module_t *initrd, - char *cmdline); +int dom0_construct_pvh(struct domain *d, const struct boot_module *image, + struct boot_module *initrd, char *cmdline); unsigned long dom0_paging_pages(const struct domain *d, unsigned long nr_pages); diff --git a/xen/arch/x86/include/asm/setup.h b/xen/arch/x86/include/asm/setup.h index 80d0bb2a21..2d620d04c7 100644 --- a/xen/arch/x86/include/asm/setup.h +++ b/xen/arch/x86/include/asm/setup.h @@ -34,8 +34,8 @@ static inline void vesa_init(void) {}; int construct_dom0( struct domain *d, - const module_t *kernel, unsigned long kernel_headroom, - module_t *initrd, + const struct boot_module *kernel, + struct boot_module *initrd, char *cmdline); void setup_io_bitmap(struct domain *d); diff --git a/xen/arch/x86/pv/dom0_build.c b/xen/arch/x86/pv/dom0_build.c index 4fe806b60d..bc0af7cf27 100644 --- a/xen/arch/x86/pv/dom0_build.c +++ b/xen/arch/x86/pv/dom0_build.c @@ -4,12 +4,12 @@ * Copyright (c) 2002-2005, K A Fraser */ +#include #include #include #include #include #include -#include #include #include #include @@ -356,9 +356,8 @@ static struct page_info * __init alloc_chunk(struct domain *d, } int __init dom0_construct_pv(struct domain *d, - const module_t *image, - unsigned long image_headroom, - module_t *initrd, + const struct boot_module *image, + struct boot_module *initrd, char *cmdline) { int i, rc, order, machine; @@ -375,10 +374,10 @@ int __init dom0_construct_pv(struct domain *d, unsigned int flush_flags = 0; start_info_t *si; struct vcpu *v = d->vcpu[0]; - void *image_base = bootstrap_map_multiboot(image); - unsigned long image_len = image->mod_end; - void *image_start = image_base + image_headroom; - unsigned long initrd_len = initrd ? initrd->mod_end : 0; + void *image_base = bootstrap_map(image); + unsigned long image_len = image->size; + void *image_start = image_base + image->arch->headroom; + unsigned long initrd_len = initrd ? initrd->size : 0; l4_pgentry_t *l4tab = NULL, *l4start = NULL; l3_pgentry_t *l3tab = NULL, *l3start = NULL; l2_pgentry_t *l2tab = NULL, *l2start = NULL; @@ -417,7 +416,7 @@ int __init dom0_construct_pv(struct domain *d, d->max_pages = ~0U; - if ( (rc = bzimage_parse(image_base, &image_start, image_headroom, + if ( (rc = bzimage_parse(image_base, &image_start, image->arch->headroom, &image_len)) != 0 ) return rc; @@ -612,7 +611,7 @@ int __init dom0_construct_pv(struct domain *d, initrd_pfn = vinitrd_start ? (vinitrd_start - v_start) >> PAGE_SHIFT : domain_tot_pages(d); - initrd_mfn = mfn = initrd->mod_start; + initrd_mfn = mfn = mfn_x(initrd->mfn); count = PFN_UP(initrd_len); if ( d->arch.physaddr_bitsize && ((mfn + count - 1) >> (d->arch.physaddr_bitsize - PAGE_SHIFT)) ) @@ -627,12 +626,13 @@ int __init dom0_construct_pv(struct domain *d, free_domheap_pages(page, order); page += 1UL << order; } - memcpy(page_to_virt(page), mfn_to_virt(initrd->mod_start), + memcpy(page_to_virt(page), maddr_to_virt(initrd->start), initrd_len); - mpt_alloc = (paddr_t)initrd->mod_start << PAGE_SHIFT; + mpt_alloc = (paddr_t)initrd->start; init_domheap_pages(mpt_alloc, mpt_alloc + PAGE_ALIGN(initrd_len)); - initrd->mod_start = initrd_mfn = mfn_x(page_to_mfn(page)); + bootmodule_update_mfn(initrd, page_to_mfn(page)); + initrd_mfn = mfn_x(initrd->mfn); } else { @@ -640,7 +640,7 @@ int __init dom0_construct_pv(struct domain *d, if ( assign_pages(mfn_to_page(_mfn(mfn++)), 1, d, 0) ) BUG(); } - initrd->mod_end = 0; + initrd->size = 0; iommu_memory_setup(d, "initrd", mfn_to_page(_mfn(initrd_mfn)), PFN_UP(initrd_len), &flush_flags); @@ -654,7 +654,7 @@ int __init dom0_construct_pv(struct domain *d, nr_pages - domain_tot_pages(d)); if ( initrd ) { - mpt_alloc = (paddr_t)initrd->mod_start << PAGE_SHIFT; + mpt_alloc = initrd->start; printk("\n Init. ramdisk: %"PRIpaddr"->%"PRIpaddr, mpt_alloc, mpt_alloc + initrd_len); } @@ -880,7 +880,7 @@ int __init dom0_construct_pv(struct domain *d, if ( pfn >= initrd_pfn ) { if ( pfn < initrd_pfn + PFN_UP(initrd_len) ) - mfn = initrd->mod_start + (pfn - initrd_pfn); + mfn = mfn_x(initrd->mfn) + (pfn - initrd_pfn); else mfn -= PFN_UP(initrd_len); } diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 3b623a4149..f9b04daebd 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -37,6 +37,7 @@ #include #include #include +#include #include #include #include @@ -59,6 +60,9 @@ #include #include +/* Max number of boot modules a bootloader can provide in addition to Xen */ +#define MAX_NR_BOOTMODS 63 + /* opt_nosmp: If true, secondary processors are ignored. */ static bool __initdata opt_nosmp; boolean_param("nosmp", opt_nosmp); @@ -269,20 +273,44 @@ static int __init cf_check parse_acpi_param(const char *s) } custom_param("acpi", parse_acpi_param); -static const module_t *__initdata initial_images; static struct boot_info __initdata *boot_info; -static void __init multiboot_to_bootinfo(multiboot_info_t *mbi) +static void __init multiboot_to_bootinfo(multiboot_info_t *mbi, module_t *mods) { static struct boot_info __initdata info; - static struct boot_module __initdata boot_mods[1]; - static struct arch_bootmodule __initdata arch_boot_mods[1]; + static struct arch_boot_info __initdata arch_info; + static struct boot_module __initdata boot_mods[MAX_NR_BOOTMODS + 1]; + static struct arch_bootmodule __initdata arch_boot_mods[ + MAX_NR_BOOTMODS + 1]; + int i; + + info.arch = &arch_info; info.mods = boot_mods; + info.cmdline = __va(mbi->cmdline); + + /* The BOOTINFO_FLAG_X86_* flags are a 1-1 map to MBI_* */ + arch_info.flags = mbi->flags; + arch_info.mmap_length = mbi->mmap_length; + arch_info.mmap_addr = mbi->mmap_addr; + arch_info.boot_loader_name = __va(mbi->boot_loader_name); + info.nr_mods = mbi->mods_count; + for ( i = 0; i <= MAX_NR_BOOTMODS; i++ ) + { + boot_mods[i].arch = &arch_boot_mods[i]; - boot_mods[0].arch = &arch_boot_mods[0]; + if ( i < info.nr_mods ) + { + bootmodule_update_start(&boot_mods[i], mods[i].mod_start); + boot_mods[i].size = mods[i].mod_end - mods[i].mod_start; + + boot_mods[i].string.len = strlcpy(boot_mods[i].string.bytes, + __va(mods[i].string), + BOOTMOD_STRING_MAX_LEN); + } + } boot_info = &info; } @@ -296,8 +324,8 @@ unsigned long __init initial_images_nrpages(nodeid_t node) for ( nr = i = 0; i < boot_info->nr_mods; ++i ) { - unsigned long start = initial_images[i].mod_start; - unsigned long end = start + PFN_UP(initial_images[i].mod_end); + unsigned long start = mfn_x(boot_info->mods[i].mfn); + unsigned long end = start + PFN_UP(boot_info->mods[i].size); if ( end > node_start && node_end > start ) nr += min(node_end, end) - max(node_start, start); @@ -312,14 +340,13 @@ void __init discard_initial_images(void) for ( i = 0; i < boot_info->nr_mods; ++i ) { - uint64_t start = (uint64_t)initial_images[i].mod_start << PAGE_SHIFT; + uint64_t start = boot_info->mods[i].start; init_domheap_pages(start, - start + PAGE_ALIGN(initial_images[i].mod_end)); + start + PAGE_ALIGN(boot_info->mods[i].size)); } boot_info->nr_mods = 0; - initial_images = NULL; } extern unsigned char __init_begin[], __init_end[]; @@ -450,26 +477,26 @@ static void __init move_memory( while ( size ) { - module_t mod; + struct boot_module mod; unsigned int soffs = src & mask; unsigned int doffs = dst & mask; unsigned int sz; void *d, *s; - mod.mod_start = (src - soffs) >> PAGE_SHIFT; - mod.mod_end = soffs + size; - if ( mod.mod_end > blksz ) - mod.mod_end = blksz; - sz = mod.mod_end - soffs; - s = bootstrap_map_multiboot(&mod); - - mod.mod_start = (dst - doffs) >> PAGE_SHIFT; - mod.mod_end = doffs + size; - if ( mod.mod_end > blksz ) - mod.mod_end = blksz; - if ( sz > mod.mod_end - doffs ) - sz = mod.mod_end - doffs; - d = bootstrap_map_multiboot(&mod); + mod.start = src - soffs; + mod.size = soffs + size; + if ( mod.size > blksz ) + mod.size = blksz; + sz = mod.size - soffs; + s = bootstrap_map(&mod); + + mod.start = dst - doffs; + mod.size = doffs + size; + if ( mod.size > blksz ) + mod.size = blksz; + if ( sz > mod.size - doffs ) + sz = mod.size - doffs; + d = bootstrap_map(&mod); memmove(d + doffs, s + soffs, sz); @@ -602,7 +629,7 @@ static void __init noinline move_xen(void) #undef BOOTSTRAP_MAP_LIMIT static uint64_t __init consider_modules( - uint64_t s, uint64_t e, uint32_t size, const module_t *mod, + uint64_t s, uint64_t e, uint32_t size, const struct boot_module *mod, unsigned int nr_mods, unsigned int this_mod) { unsigned int i; @@ -612,8 +639,8 @@ static uint64_t __init consider_modules( for ( i = 0; i < nr_mods ; ++i ) { - uint64_t start = (uint64_t)mod[i].mod_start << PAGE_SHIFT; - uint64_t end = start + PAGE_ALIGN(mod[i].mod_end); + uint64_t start = mod[i].start; + uint64_t end = start + PAGE_ALIGN(mod[i].size); if ( i == this_mod ) continue; @@ -883,9 +910,8 @@ static unsigned int __init copy_bios_e820(struct e820entry *map, unsigned int li return n; } -static struct domain *__init create_dom0(const module_t *image, - unsigned long headroom, - module_t *initrd, const char *kextra, +static struct domain *__init create_dom0(const struct boot_info *bootinfo, + const char *kextra, const char *loader) { struct xen_domctl_createdomain dom0_cfg = { @@ -899,9 +925,14 @@ static struct domain *__init create_dom0(const module_t *image, .misc_flags = opt_dom0_msr_relaxed ? XEN_X86_MSR_RELAXED : 0, }, }; + struct boot_module *image = bootmodule_next(bootinfo, BOOTMOD_KERNEL); + struct boot_module *initrd = bootmodule_next(bootinfo, BOOTMOD_RAMDISK); struct domain *d; char *cmdline; - domid_t domid; + domid_t domid = 0; + + if ( image == NULL ) + panic("Error creating d%uv0\n", domid); if ( opt_dom0_pvh ) { @@ -928,7 +959,7 @@ static struct domain *__init create_dom0(const module_t *image, panic("Error creating d%uv0\n", domid); /* Grab the DOM0 command line. */ - cmdline = image->string ? __va(image->string) : NULL; + cmdline = image->string.len ? image->string.bytes : NULL; if ( cmdline || kextra ) { static char __initdata dom0_cmdline[MAX_GUEST_CMDLINE]; @@ -968,8 +999,7 @@ static struct domain *__init create_dom0(const module_t *image, write_cr4(read_cr4() & ~X86_CR4_SMAP); } - if ( construct_dom0(d, image, boot_info->mods[0].arch->headroom, initrd, - cmdline) != 0 ) + if ( construct_dom0(d, image, initrd, cmdline) != 0 ) panic("Could not construct domain 0\n"); if ( cpu_has_smap ) @@ -1038,14 +1068,14 @@ void __init noreturn __start_xen(unsigned long mbi_p) mod = __va(mbi->mods_addr); } - multiboot_to_bootinfo(mbi); + multiboot_to_bootinfo(mbi, mod); - loader = (mbi->flags & MBI_LOADERNAME) - ? (char *)__va(mbi->boot_loader_name) : "unknown"; + loader = (boot_info->arch->flags & BOOTINFO_FLAG_X86_LOADERNAME) + ? boot_info->arch->boot_loader_name : "unknown"; /* Parse the command-line options. */ - cmdline = cmdline_cook((mbi->flags & MBI_CMDLINE) ? - __va(mbi->cmdline) : NULL, + cmdline = cmdline_cook((boot_info->arch->flags & BOOTINFO_FLAG_X86_CMDLINE) ? + boot_info->cmdline : NULL, loader); if ( (kextra = strstr(cmdline, " -- ")) != NULL ) { @@ -1147,19 +1177,22 @@ void __init noreturn __start_xen(unsigned long mbi_p) bootsym(boot_edd_info_nr)); /* Check that we have at least one Multiboot module. */ - if ( !(mbi->flags & MBI_MODULES) || (boot_info->nr_mods == 0) ) + if ( !(boot_info->arch->flags & BOOTINFO_FLAG_X86_MODULES) || + (boot_info->nr_mods == 0) ) panic("dom0 kernel not specified. Check bootloader configuration\n"); /* Check that we don't have a silly number of modules. */ - if ( boot_info->nr_mods > sizeof(module_map) * 8 ) + if ( boot_info->nr_mods > MAX_NR_BOOTMODS + 1 ) { - boot_info->nr_mods = sizeof(module_map) * 8; + boot_info->nr_mods = MAX_NR_BOOTMODS + 1; printk("Excessive multiboot modules - using the first %u only\n", boot_info->nr_mods); } - bitmap_fill(module_map, boot_info->nr_mods); + /* Dom0 kernel is the first boot module */ + bitmap_fill(module_map, mbi->mods_count); __clear_bit(0, module_map); /* Dom0 kernel is always first */ + boot_info->mods[0].bootmod_type = BOOTMOD_KERNEL; if ( pvh_boot ) { @@ -1189,13 +1222,13 @@ void __init noreturn __start_xen(unsigned long mbi_p) { memmap_type = "Xen-e820"; } - else if ( mbi->flags & MBI_MEMMAP ) + else if ( boot_info->arch->flags & BOOTINFO_FLAG_X86_MEMMAP ) { memmap_type = "Multiboot-e820"; - while ( bytes < mbi->mmap_length && + while ( bytes < boot_info->arch->mmap_length && e820_raw.nr_map < ARRAY_SIZE(e820_raw.map) ) { - memory_map_t *map = __va(mbi->mmap_addr + bytes); + struct mb_memmap *map = __va(boot_info->arch->mmap_addr + bytes); /* * This is a gross workaround for a BIOS bug. Some bootloaders do @@ -1330,17 +1363,9 @@ void __init noreturn __start_xen(unsigned long mbi_p) set_kexec_crash_area_size((u64)nr_pages << PAGE_SHIFT); kexec_reserve_area(&boot_e820); - initial_images = mod; - boot_info->nr_mods = boot_info->nr_mods; - for ( i = 0; !efi_enabled(EFI_LOADER) && i < boot_info->nr_mods; i++ ) - { - if ( mod[i].mod_start & (PAGE_SIZE - 1) ) + if ( boot_info->mods[i].start & (PAGE_SIZE - 1) ) panic("Bootloader didn't honor module alignment request\n"); - mod[i].mod_end -= mod[i].mod_start; - mod[i].mod_start >>= PAGE_SHIFT; - mod[i].reserved = 0; - } /* * TODO: load ucode earlier once multiboot modules become accessible @@ -1357,12 +1382,14 @@ void __init noreturn __start_xen(unsigned long mbi_p) * respective reserve_e820_ram() invocation below. No need to * query efi_boot_mem_unused() here, though. */ - mod[boot_info->nr_mods].mod_start = virt_to_mfn(_stext); - mod[boot_info->nr_mods].mod_end = __2M_rwdata_end - _stext; + bootmodule_update_start(&boot_info->mods[boot_info->nr_mods], + virt_to_maddr(_stext)); + boot_info->mods[boot_info->nr_mods].size = __2M_rwdata_end - _stext; } boot_info->mods[0].arch->headroom = - bzimage_headroom(bootstrap_map_multiboot(mod), mod->mod_end); + bzimage_headroom(bootstrap_map(&boot_info->mods[0]), + boot_info->mods[0].size); bootstrap_map(NULL); @@ -1420,7 +1447,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) { /* Don't overlap with modules. */ end = consider_modules(s, e, reloc_size + mask, - mod, boot_info->nr_mods, -1); + boot_info->mods, boot_info->nr_mods, -1); end &= ~mask; } else @@ -1443,15 +1470,15 @@ void __init noreturn __start_xen(unsigned long mbi_p) /* Is the region suitable for relocating the multiboot modules? */ for ( j = boot_info->nr_mods - 1; j >= 0; j-- ) { - struct boot_module *boot_mods = boot_info->mods; - unsigned long headroom = j ? 0 : boot_mods[0].arch->headroom; - unsigned long size = PAGE_ALIGN(headroom + mod[j].mod_end); + struct boot_module *boot_mod = boot_info->mods; + unsigned long headroom = j ? 0 : boot_mod[0].arch->headroom; + unsigned long size = PAGE_ALIGN(headroom + boot_mod[j].size); - if ( mod[j].reserved ) + if ( boot_mod[j].arch->flags & BOOTMOD_FLAG_X86_RELOCATED ) continue; /* Don't overlap with other modules (or Xen itself). */ - end = consider_modules(s, e, size, mod, + end = consider_modules(s, e, size, boot_info->mods, boot_info->nr_mods + relocated, j); if ( highmem_start && end > highmem_start ) @@ -1459,14 +1486,14 @@ void __init noreturn __start_xen(unsigned long mbi_p) if ( s < end && (headroom || - ((end - size) >> PAGE_SHIFT) > mod[j].mod_start) ) + ((end - size) >> PAGE_SHIFT) > mfn_x(boot_mod[j].mfn)) ) { move_memory(end - size + headroom, - (uint64_t)mod[j].mod_start << PAGE_SHIFT, - mod[j].mod_end); - mod[j].mod_start = (end - size) >> PAGE_SHIFT; - mod[j].mod_end += headroom; - mod[j].reserved = 1; + (uint64_t)boot_mod[j].start, + boot_mod[j].size); + bootmodule_update_start(&boot_mod[j], end - size); + boot_mod[j].size += headroom; + boot_mod[j].arch->flags |= BOOTMOD_FLAG_X86_RELOCATED; } } @@ -1478,7 +1505,8 @@ void __init noreturn __start_xen(unsigned long mbi_p) while ( !kexec_crash_area.start ) { /* Don't overlap with modules (or Xen itself). */ - e = consider_modules(s, e, PAGE_ALIGN(kexec_crash_area.size), mod, + e = consider_modules(s, e, PAGE_ALIGN(kexec_crash_area.size), + boot_info->mods, boot_info->nr_mods + relocated, -1); if ( s >= e ) break; @@ -1492,13 +1520,14 @@ void __init noreturn __start_xen(unsigned long mbi_p) #endif } - if ( boot_info->mods[0].arch->headroom && !mod->reserved ) + if ( boot_info->mods[0].arch->headroom && + !(boot_info->mods[0].arch->flags & BOOTMOD_FLAG_X86_RELOCATED) ) panic("Not enough memory to relocate the dom0 kernel image\n"); for ( i = 0; i < boot_info->nr_mods; ++i ) { - uint64_t s = (uint64_t)mod[i].mod_start << PAGE_SHIFT; + uint64_t s = (uint64_t)boot_info->mods[i].start; - reserve_e820_ram(&boot_e820, s, s + PAGE_ALIGN(mod[i].mod_end)); + reserve_e820_ram(&boot_e820, s, s + PAGE_ALIGN(boot_info->mods[i].size)); } if ( !xen_phys_start ) @@ -1565,8 +1594,8 @@ void __init noreturn __start_xen(unsigned long mbi_p) map_e = boot_e820.map[j].addr + boot_e820.map[j].size; for ( j = 0; j < boot_info->nr_mods; ++j ) { - uint64_t end = pfn_to_paddr(mod[j].mod_start) + - mod[j].mod_end; + uint64_t end = mfn_to_maddr(boot_info->mods[j].mfn) + + boot_info->mods[j].size; if ( map_e < end ) map_e = end; @@ -1641,11 +1670,12 @@ void __init noreturn __start_xen(unsigned long mbi_p) for ( i = 0; i < boot_info->nr_mods; ++i ) { - set_pdx_range(mod[i].mod_start, - mod[i].mod_start + PFN_UP(mod[i].mod_end)); - map_pages_to_xen((unsigned long)mfn_to_virt(mod[i].mod_start), - _mfn(mod[i].mod_start), - PFN_UP(mod[i].mod_end), PAGE_HYPERVISOR); + set_pdx_range(mfn_x(boot_info->mods[i].mfn), + mfn_x(boot_info->mods[i].mfn) + + PFN_UP(boot_info->mods[i].size)); + map_pages_to_xen((unsigned long)maddr_to_virt(boot_info->mods[i].start), + boot_info->mods[i].mfn, + PFN_UP(boot_info->mods[i].size), PAGE_HYPERVISOR); } #ifdef CONFIG_KEXEC @@ -2022,8 +2052,12 @@ void __init noreturn __start_xen(unsigned long mbi_p) cpu_has_nx ? XENLOG_INFO : XENLOG_WARNING "Warning: ", cpu_has_nx ? "" : "not "); - initrdidx = find_first_bit(module_map, boot_info->nr_mods); - if ( bitmap_weight(module_map, boot_info->nr_mods) > 1 ) + initrdidx = bootmodule_index(boot_info, BOOTMOD_UNKNOWN, 0); + if ( initrdidx < boot_info->nr_mods ) + boot_info->mods[initrdidx].bootmod_type = BOOTMOD_RAMDISK; + + if ( bootmodule_index(boot_info, BOOTMOD_UNKNOWN, 0) > + boot_info->nr_mods ) printk(XENLOG_WARNING "Multiple initrd candidates, picking module #%u\n", initrdidx); @@ -2032,9 +2066,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) * We're going to setup domain0 using the module(s) that we stashed safely * above our heap. The second module, if present, is an initrd ramdisk. */ - dom0 = create_dom0(mod, boot_info->mods[0].arch->headroom, - initrdidx < boot_info->nr_mods ? mod + initrdidx : NULL, - kextra, loader); + dom0 = create_dom0(boot_info, kextra, loader); if ( !dom0 ) panic("Could not set up DOM0 guest OS\n"); diff --git a/xen/include/xen/bootinfo.h b/xen/include/xen/bootinfo.h index eb93cc3439..2f4284a91f 100644 --- a/xen/include/xen/bootinfo.h +++ b/xen/include/xen/bootinfo.h @@ -2,23 +2,50 @@ #define __XEN_BOOTINFO_H__ #include +#include +#include #ifdef CONFIG_X86 #include #else struct arch_bootmodule { }; + struct arch_boot_info { }; #endif +/* Boot module binary type / purpose */ +#define BOOTMOD_UNKNOWN 0 +#define BOOTMOD_XEN 1 +#define BOOTMOD_FDT 2 +#define BOOTMOD_KERNEL 3 +#define BOOTMOD_RAMDISK 4 +#define BOOTMOD_XSM 5 +#define BOOTMOD_UCODE 6 +#define BOOTMOD_GUEST_DTB 7 +typedef unsigned int bootmod_type_t; + +#define BOOTMOD_STRING_MAX_LEN 1024 +struct boot_string { + char bytes[BOOTMOD_STRING_MAX_LEN]; + size_t len; +}; + struct boot_module { + bootmod_type_t bootmod_type; paddr_t start; + mfn_t mfn; size_t size; struct arch_bootmodule *arch; + struct boot_string string; }; struct boot_info { + char *cmdline; + unsigned int nr_mods; struct boot_module *mods; + + struct arch_boot_info *arch; }; #endif -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 01 00:31:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 00:31:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557668.871234 (Exim 4.92) (envelope-from ) id 1qFOWi-0008Vl-VE; Sat, 01 Jul 2023 00:31:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557668.871234; Sat, 01 Jul 2023 00:31:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFOWi-0008Vc-Pf; Sat, 01 Jul 2023 00:31:48 +0000 Received: by outflank-mailman (input) for mailman id 557668; Sat, 01 Jul 2023 00:31:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFOWh-0007yM-QK for xen-devel@lists.xenproject.org; Sat, 01 Jul 2023 00:31:47 +0000 Received: from mail-yw1-x112a.google.com (mail-yw1-x112a.google.com [2607:f8b0:4864:20::112a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a7cb92e4-17a6-11ee-8611-37d641c3527e; Sat, 01 Jul 2023 02:31:44 +0200 (CEST) Received: by mail-yw1-x112a.google.com with SMTP id 00721157ae682-5701e8f2b79so27334707b3.0 for ; Fri, 30 Jun 2023 17:31:44 -0700 (PDT) Received: from cog-dev.home ([70.103.208.83]) by smtp.gmail.com with ESMTPSA id s68-20020a632c47000000b0055b61cd99a1sm1824296pgs.81.2023.06.30.17.31.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jun 2023 17:31:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: a7cb92e4-17a6-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688171503; x=1690763503; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=sqQqqF0IyJ/PuKXVXwFAfGVp5jzTeAtO0YKlHbSfXAU=; b=d+tq/rbAfNr5yHLcrKURrSqr0rJdRYKlNsfHaEao/XBIfLlqSHBeZDOh6Co8fB7AdZ lUj+VBO5+5quL7CbuIRyuJOG5+akeVBPPcpaF/fItBEAOdlsGJ/j0yvO5SBKTGS/DrwT k/ZGa6qjJ1yABSQNwvhpdip4eF2079ZAJ5g5EpA5x3sw4EvMMV7JSxZ5ZhrAw1GPJWeu xFH9LrxE8SIjPMBeE4wDYtpzOsDrD1yY5JDc2rqoqcfcHmDhrztTG+cKFyacpwW0NDAT rPe2NjV6ePCwpCbYnrfg7Rxh/2EH2dA0G5DJM4YStZR20n7Vu4oVD9XZwPZ3jtH9tc6b WarA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688171503; x=1690763503; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=sqQqqF0IyJ/PuKXVXwFAfGVp5jzTeAtO0YKlHbSfXAU=; b=BeRPAKMC7NkuJh14+53YHyJRxcftOMh1U67mwx62IeCagdlroJQKwcYRgx5S/ov8Bd IbzWJAplB+qGjxz/Lvvq/ECzU4vlzlYjqIrCe/ziOSmWPuPJoeqBQF65lqkh8R4f24qg p6Xpd7H7sJkW3J6zRSjgQkV5zX0FY1OrAgOthRk28p05oeEf0fqNzhM2iLXeNc9ftnpE vB+dhrH0cbFkuOXxxFtEh7H94qHK9C39Jt1XOUR8Cz1qOrYe/BwI5VsJqHUzGtPd5eUJ AXyqn4A+7SGS6e6yTU/6WcwCERc21H/RQJjXVuBqZuV3t/HjVQHYCP4JeavU/FeDObg/ 7awA== X-Gm-Message-State: ABy/qLbH3/KLIHZw+ttmPzoyQVmgujsAf5ukPLWVqRJJ63koMZGse5/t oZuIwIogHBShvJ/jLyr8FJ6WXIq6f/4= X-Google-Smtp-Source: APBJJlGhQ1CFMj7J8a/Nqrkm+dSxRfTiP6kfcYG7qn5RNbcc78vyoNL6EmmGS4YOue+8pyYX/4D9jw== X-Received: by 2002:a81:de49:0:b0:56d:2981:e2e2 with SMTP id o9-20020a81de49000000b0056d2981e2e2mr3897669ywl.6.1688171503257; Fri, 30 Jun 2023 17:31:43 -0700 (PDT) Sender: Christopher Clark From: Christopher Clark To: xen-devel@lists.xenproject.org Cc: Daniel Smith , stefano.stabellini@amd.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Luca Fancellu , Volodymyr Babchuk , Rich Persaud Subject: [PATCH 03/11] x86 setup: change bootstrap map to accept new boot module structures Date: Fri, 30 Jun 2023 17:31:24 -0700 Message-Id: <20230701003132.2210306-4-christopher.w.clark@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230701003132.2210306-1-christopher.w.clark@gmail.com> References: <20230701003132.2210306-1-christopher.w.clark@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To convert the x86 boot logic from multiboot to boot module structures, change the bootstrap map function to accept a boot module parameter. To allow incremental change from multiboot to boot modules across all x86 setup logic, provide a temporary inline wrapper that still accepts a multiboot module parameter and use it where necessary. The wrapper is placed in a new arch/x86 header to avoid putting a static inline function into an existing header that has no such functions already. This new header will be expanded with additional functions in subsequent patches in this series. No functional change intended. Signed-off-by: Christopher Clark Signed-off-by: Daniel P. Smith changes since v1: - new patch so v1 patch 3 can be implemented via incremental series --- xen/arch/x86/cpu/microcode/core.c | 7 ++++--- xen/arch/x86/hvm/dom0_build.c | 4 +++- xen/arch/x86/include/asm/boot.h | 32 +++++++++++++++++++++++++++++++ xen/arch/x86/include/asm/setup.h | 3 ++- xen/arch/x86/pv/dom0_build.c | 3 ++- xen/arch/x86/setup.c | 18 +++++++++-------- xen/include/xen/bootinfo.h | 3 +++ xen/xsm/xsm_policy.c | 3 ++- 8 files changed, 58 insertions(+), 15 deletions(-) create mode 100644 xen/arch/x86/include/asm/boot.h diff --git a/xen/arch/x86/cpu/microcode/core.c b/xen/arch/x86/cpu/microcode/core.c index cd456c476f..e720a89167 100644 --- a/xen/arch/x86/cpu/microcode/core.c +++ b/xen/arch/x86/cpu/microcode/core.c @@ -34,6 +34,7 @@ #include #include +#include #include #include #include @@ -180,7 +181,7 @@ void __init microcode_scan_module( if ( !test_bit(i, module_map) ) continue; - _blob_start = bootstrap_map(&mod[i]); + _blob_start = bootstrap_map_multiboot(&mod[i]); _blob_size = mod[i].mod_end; if ( !_blob_start ) { @@ -794,7 +795,7 @@ int __init microcode_init_cache(unsigned long *module_map, microcode_scan_module(module_map, mbi); if ( ucode_mod.mod_end ) - rc = early_update_cache(bootstrap_map(&ucode_mod), + rc = early_update_cache(bootstrap_map_multiboot(&ucode_mod), ucode_mod.mod_end); else if ( ucode_blob.size ) rc = early_update_cache(ucode_blob.data, ucode_blob.size); @@ -817,7 +818,7 @@ static int __init early_microcode_update_cpu(void) else if ( ucode_mod.mod_end ) { len = ucode_mod.mod_end; - data = bootstrap_map(&ucode_mod); + data = bootstrap_map_multiboot(&ucode_mod); } if ( !data ) diff --git a/xen/arch/x86/hvm/dom0_build.c b/xen/arch/x86/hvm/dom0_build.c index bf08998862..56fe89632b 100644 --- a/xen/arch/x86/hvm/dom0_build.c +++ b/xen/arch/x86/hvm/dom0_build.c @@ -16,6 +16,7 @@ #include +#include #include #include #include @@ -1208,7 +1209,8 @@ int __init dom0_construct_pvh(struct domain *d, const module_t *image, return rc; } - rc = pvh_load_kernel(d, image, image_headroom, initrd, bootstrap_map(image), + rc = pvh_load_kernel(d, image, image_headroom, initrd, + bootstrap_map_multiboot(image), cmdline, &entry, &start_info); if ( rc ) { diff --git a/xen/arch/x86/include/asm/boot.h b/xen/arch/x86/include/asm/boot.h new file mode 100644 index 0000000000..10b17f12b2 --- /dev/null +++ b/xen/arch/x86/include/asm/boot.h @@ -0,0 +1,32 @@ +#ifndef __ASM_X86_BOOT_H__ +#define __ASM_X86_BOOT_H__ + +#include +#include + +#include + +static inline void *bootstrap_map_multiboot(const module_t *mod) +{ + struct boot_module bm; + + if ( !mod ) + return bootstrap_map(NULL); + + bm.start = mod->mod_start << PAGE_SHIFT; + bm.size = mod->mod_end; + + return bootstrap_map(&bm); +} + +#endif + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/x86/include/asm/setup.h b/xen/arch/x86/include/asm/setup.h index ae0dd3915a..80d0bb2a21 100644 --- a/xen/arch/x86/include/asm/setup.h +++ b/xen/arch/x86/include/asm/setup.h @@ -1,6 +1,7 @@ #ifndef __X86_SETUP_H_ #define __X86_SETUP_H_ +#include #include #include @@ -40,7 +41,7 @@ void setup_io_bitmap(struct domain *d); unsigned long initial_images_nrpages(nodeid_t node); void discard_initial_images(void); -void *bootstrap_map(const module_t *mod); +void *bootstrap_map(const struct boot_module *mod); int xen_in_range(unsigned long mfn); diff --git a/xen/arch/x86/pv/dom0_build.c b/xen/arch/x86/pv/dom0_build.c index 6ed9f8bbed..4fe806b60d 100644 --- a/xen/arch/x86/pv/dom0_build.c +++ b/xen/arch/x86/pv/dom0_build.c @@ -14,6 +14,7 @@ #include #include +#include #include #include #include @@ -374,7 +375,7 @@ int __init dom0_construct_pv(struct domain *d, unsigned int flush_flags = 0; start_info_t *si; struct vcpu *v = d->vcpu[0]; - void *image_base = bootstrap_map(image); + void *image_base = bootstrap_map_multiboot(image); unsigned long image_len = image->mod_end; void *image_start = image_base + image_headroom; unsigned long initrd_len = initrd ? initrd->mod_end : 0; diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index c0e8fc6ab7..3b623a4149 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -32,6 +32,7 @@ #include #endif #include +#include #include #include #include @@ -405,14 +406,14 @@ static void __init normalise_cpu_order(void) * Ensure a given physical memory range is present in the bootstrap mappings. * Use superpage mappings to ensure that pagetable memory needn't be allocated. */ -void *__init bootstrap_map(const module_t *mod) +void *__init bootstrap_map(const struct boot_module *mod) { static unsigned long __initdata map_cur = BOOTSTRAP_MAP_BASE; uint64_t start, end, mask = (1L << L2_PAGETABLE_SHIFT) - 1; void *ret; if ( system_state != SYS_STATE_early_boot ) - return mod ? mfn_to_virt(mod->mod_start) : NULL; + return mod ? maddr_to_virt(mod->start) : NULL; if ( !mod ) { @@ -421,8 +422,8 @@ void *__init bootstrap_map(const module_t *mod) return NULL; } - start = (uint64_t)mod->mod_start << PAGE_SHIFT; - end = start + mod->mod_end; + start = (uint64_t)mod->start; + end = start + mod->size; if ( start >= end ) return NULL; @@ -460,7 +461,7 @@ static void __init move_memory( if ( mod.mod_end > blksz ) mod.mod_end = blksz; sz = mod.mod_end - soffs; - s = bootstrap_map(&mod); + s = bootstrap_map_multiboot(&mod); mod.mod_start = (dst - doffs) >> PAGE_SHIFT; mod.mod_end = doffs + size; @@ -468,7 +469,7 @@ static void __init move_memory( mod.mod_end = blksz; if ( sz > mod.mod_end - doffs ) sz = mod.mod_end - doffs; - d = bootstrap_map(&mod); + d = bootstrap_map_multiboot(&mod); memmove(d + doffs, s + soffs, sz); @@ -1360,8 +1361,9 @@ void __init noreturn __start_xen(unsigned long mbi_p) mod[boot_info->nr_mods].mod_end = __2M_rwdata_end - _stext; } - boot_info->mods[0].arch->headroom = bzimage_headroom(bootstrap_map(mod), - mod->mod_end); + boot_info->mods[0].arch->headroom = + bzimage_headroom(bootstrap_map_multiboot(mod), mod->mod_end); + bootstrap_map(NULL); #ifndef highmem_start diff --git a/xen/include/xen/bootinfo.h b/xen/include/xen/bootinfo.h index b72ae31a66..eb93cc3439 100644 --- a/xen/include/xen/bootinfo.h +++ b/xen/include/xen/bootinfo.h @@ -10,6 +10,9 @@ #endif struct boot_module { + paddr_t start; + size_t size; + struct arch_bootmodule *arch; }; diff --git a/xen/xsm/xsm_policy.c b/xen/xsm/xsm_policy.c index 8dafbc9381..c6df8c6e06 100644 --- a/xen/xsm/xsm_policy.c +++ b/xen/xsm/xsm_policy.c @@ -20,6 +20,7 @@ #include #ifdef CONFIG_MULTIBOOT +#include #include #include #endif @@ -49,7 +50,7 @@ int __init xsm_multiboot_policy_init( if ( !test_bit(i, module_map) ) continue; - _policy_start = bootstrap_map(mod + i); + _policy_start = bootstrap_map_multiboot(mod + i); _policy_len = mod[i].mod_end; if ( (xsm_magic_t)(*_policy_start) == XSM_MAGIC ) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 01 00:31:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 00:31:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557666.871213 (Exim 4.92) (envelope-from ) id 1qFOWg-00081u-E1; Sat, 01 Jul 2023 00:31:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557666.871213; Sat, 01 Jul 2023 00:31:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFOWg-000815-8L; Sat, 01 Jul 2023 00:31:46 +0000 Received: by outflank-mailman (input) for mailman id 557666; Sat, 01 Jul 2023 00:31:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFOWe-0007yB-Re for xen-devel@lists.xenproject.org; Sat, 01 Jul 2023 00:31:44 +0000 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [2607:f8b0:4864:20::434]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a73357b3-17a6-11ee-b237-6b7b168915f2; Sat, 01 Jul 2023 02:31:44 +0200 (CEST) Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-668709767b1so1546245b3a.2 for ; Fri, 30 Jun 2023 17:31:44 -0700 (PDT) Received: from cog-dev.home ([70.103.208.83]) by smtp.gmail.com with ESMTPSA id s68-20020a632c47000000b0055b61cd99a1sm1824296pgs.81.2023.06.30.17.31.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jun 2023 17:31:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: a73357b3-17a6-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688171502; x=1690763502; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=LY4hOPffrE6QJlk2fTfa3K1ABHuOB1gwqTF+/zyLHhg=; b=pXHV6ClIgQKCL4P3Ydz6t6ZjxJjBbulbFY65VM8m+LoBbAV8zs1butDeeouPUo3kZd yLjXoQ5J7JD6Iys3hs7K/IYhEl3EpOWN/gze9swW/H85U8CB3ExCzs094wHslFX3QblV 4nUEoJ9h9cbnhDnjLiu6jworYv4Y9iQHAqjImZrI9VC10ChyhPhusYLWRdXw46IAuQXw NV8PJH9JSBggK3Y+Uk7g+D4QoEgtMekK8dt4mob37oegIx2bTLIEZ/MwhtKt+rEIFfGo CU/rs5rxRl69LxBBIiAMd8LntZ58QWSTM6fwVBbXp+tZGK4C3JPEf2VmFmoksAe5kOky dc6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688171502; x=1690763502; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=LY4hOPffrE6QJlk2fTfa3K1ABHuOB1gwqTF+/zyLHhg=; b=E/r2X9avrOz3IlhwhdLmu5ka7Aw2lBOeB3mOVE4VW5fbfATOss52LmvicptQvPlnvu xgzeyDeFn1j8e+ZCP8T9OW9mJI7RUKDaz4mJxbzhQR+BvKZ2iNrav48hXser7mEp+G7G muNqctHG848ppXzmDC2iYZBcZNZIGbQ32roJgADjTQ346OJDc1A1qSazjSTr9IGpY17b 1iIyXdypCBKthDZep/TbCuu7+GJqdRyT3jitArmxvardcpcv/924u8uw97kbda+FJbKa hX8Dj8QGvJTb/6mmVKo9FHB70VXjSDJc9XUeV0eVtsoWCKSLCdApyHoTmOSJcveQZBeu LZ/g== X-Gm-Message-State: ABy/qLZqc92QOtS8lp4hyRmNHAUrr5Qcb02tyi0G97ZidaCZSiX+tzoY vqHYfxrSijHXVqRNhC+mp53RELO+EH8= X-Google-Smtp-Source: APBJJlHv6bZX31TSR4MJuxlF3DUMJ4bn9ZYjcCQLZ2D5ZS486PyQXKZjkNmbioyxSSKZr5kp5fdsCA== X-Received: by 2002:a05:6a00:24d3:b0:675:8f71:28f1 with SMTP id d19-20020a056a0024d300b006758f7128f1mr4321858pfv.30.1688171502138; Fri, 30 Jun 2023 17:31:42 -0700 (PDT) Sender: Christopher Clark From: Christopher Clark To: xen-devel@lists.xenproject.org Cc: Daniel Smith , stefano.stabellini@amd.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Luca Fancellu , Volodymyr Babchuk , Rich Persaud Subject: [PATCH 02/11] x86 setup: per-arch bootmodule structure, headroom field Date: Fri, 30 Jun 2023 17:31:23 -0700 Message-Id: <20230701003132.2210306-3-christopher.w.clark@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230701003132.2210306-1-christopher.w.clark@gmail.com> References: <20230701003132.2210306-1-christopher.w.clark@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Next step in incremental work towards adding a non-multiboot internal representation of boot modules, converting the fields being accessed for the startup calculations. Add a new array of structs for per-boot-module state, though only allocate space for a single array entry in this change since that is all that is required for functionality modified in this patch: moving the headroom field for the image decompression calculation into a new per-arch boot module struct and then using it in x86 dom0 construction. Introduces a per-arch header for x86 for arch-specific boot module structures, and add a member to the common boot module structure for access to it. No functional change intended. Signed-off-by: Christopher Clark Signed-off-by: Daniel P. Smith changes since v1: - patch is a subset of v1 patches 2 and 3 --- xen/arch/x86/bzimage.c | 10 +++++----- xen/arch/x86/hvm/dom0_build.c | 3 ++- xen/arch/x86/include/asm/bootinfo.h | 18 ++++++++++++++++++ xen/arch/x86/include/asm/bzimage.h | 2 +- xen/arch/x86/pv/dom0_build.c | 3 ++- xen/arch/x86/setup.c | 23 ++++++++++++++++------- xen/include/xen/bootinfo.h | 11 +++++++++++ 7 files changed, 55 insertions(+), 15 deletions(-) create mode 100644 xen/arch/x86/include/asm/bootinfo.h diff --git a/xen/arch/x86/bzimage.c b/xen/arch/x86/bzimage.c index ac4fd428be..dac2399b89 100644 --- a/xen/arch/x86/bzimage.c +++ b/xen/arch/x86/bzimage.c @@ -69,8 +69,6 @@ static __init int bzimage_check(struct setup_header *hdr, unsigned long len) return 1; } -static unsigned long __initdata orig_image_len; - unsigned long __init bzimage_headroom(void *image_start, unsigned long image_length) { @@ -91,7 +89,6 @@ unsigned long __init bzimage_headroom(void *image_start, if ( elf_is_elfbinary(image_start, image_length) ) return 0; - orig_image_len = image_length; headroom = output_length(image_start, image_length); if (gzip_check(image_start, image_length)) { @@ -105,11 +102,14 @@ unsigned long __init bzimage_headroom(void *image_start, } int __init bzimage_parse(void *image_base, void **image_start, + unsigned int headroom, unsigned long *image_len) { struct setup_header *hdr = (struct setup_header *)(*image_start); int err = bzimage_check(hdr, *image_len); - unsigned long output_len; + unsigned long output_len, orig_image_len; + + orig_image_len = *image_len - headroom; if ( err < 0 ) return err; @@ -125,7 +125,7 @@ int __init bzimage_parse(void *image_base, void **image_start, BUG_ON(!(image_base < *image_start)); - output_len = output_length(*image_start, orig_image_len); + output_len = output_length(*image_start, *image_len); if ( (err = perform_gunzip(image_base, *image_start, orig_image_len)) > 0 ) err = decompress(*image_start, orig_image_len, image_base); diff --git a/xen/arch/x86/hvm/dom0_build.c b/xen/arch/x86/hvm/dom0_build.c index fd2cbf68bc..bf08998862 100644 --- a/xen/arch/x86/hvm/dom0_build.c +++ b/xen/arch/x86/hvm/dom0_build.c @@ -545,7 +545,8 @@ static int __init pvh_load_kernel(struct domain *d, const module_t *image, struct vcpu *v = d->vcpu[0]; int rc; - if ( (rc = bzimage_parse(image_base, &image_start, &image_len)) != 0 ) + if ( (rc = bzimage_parse(image_base, &image_start, image_headroom, + &image_len)) != 0 ) { printk("Error trying to detect bz compressed kernel\n"); return rc; diff --git a/xen/arch/x86/include/asm/bootinfo.h b/xen/arch/x86/include/asm/bootinfo.h new file mode 100644 index 0000000000..a25054f372 --- /dev/null +++ b/xen/arch/x86/include/asm/bootinfo.h @@ -0,0 +1,18 @@ +#ifndef __ARCH_X86_BOOTINFO_H__ +#define __ARCH_X86_BOOTINFO_H__ + +struct arch_bootmodule { + unsigned headroom; +}; + +#endif + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/x86/include/asm/bzimage.h b/xen/arch/x86/include/asm/bzimage.h index 7ed69d3910..dd784f32ef 100644 --- a/xen/arch/x86/include/asm/bzimage.h +++ b/xen/arch/x86/include/asm/bzimage.h @@ -5,7 +5,7 @@ unsigned long bzimage_headroom(void *image_start, unsigned long image_length); -int bzimage_parse(void *image_base, void **image_start, +int bzimage_parse(void *image_base, void **image_start, unsigned int headroom, unsigned long *image_len); #endif /* __X86_BZIMAGE_H__ */ diff --git a/xen/arch/x86/pv/dom0_build.c b/xen/arch/x86/pv/dom0_build.c index c99135a552..6ed9f8bbed 100644 --- a/xen/arch/x86/pv/dom0_build.c +++ b/xen/arch/x86/pv/dom0_build.c @@ -416,7 +416,8 @@ int __init dom0_construct_pv(struct domain *d, d->max_pages = ~0U; - if ( (rc = bzimage_parse(image_base, &image_start, &image_len)) != 0 ) + if ( (rc = bzimage_parse(image_base, &image_start, image_headroom, + &image_len)) != 0 ) return rc; if ( (rc = elf_init(&elf, image_start, image_len)) != 0 ) diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 708639b236..c0e8fc6ab7 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -273,10 +273,16 @@ static struct boot_info __initdata *boot_info; static void __init multiboot_to_bootinfo(multiboot_info_t *mbi) { - static struct boot_info __initdata info; + static struct boot_info __initdata info; + static struct boot_module __initdata boot_mods[1]; + static struct arch_bootmodule __initdata arch_boot_mods[1]; + + info.mods = boot_mods; info.nr_mods = mbi->mods_count; + boot_mods[0].arch = &arch_boot_mods[0]; + boot_info = &info; } @@ -961,7 +967,8 @@ static struct domain *__init create_dom0(const module_t *image, write_cr4(read_cr4() & ~X86_CR4_SMAP); } - if ( construct_dom0(d, image, headroom, initrd, cmdline) != 0 ) + if ( construct_dom0(d, image, boot_info->mods[0].arch->headroom, initrd, + cmdline) != 0 ) panic("Could not construct domain 0\n"); if ( cpu_has_smap ) @@ -985,7 +992,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) unsigned int initrdidx, num_parked = 0; multiboot_info_t *mbi; module_t *mod; - unsigned long nr_pages, raw_max_page, modules_headroom, module_map[1]; + unsigned long nr_pages, raw_max_page, module_map[1]; int i, j, e820_warn = 0, bytes = 0; unsigned long eb_start, eb_end; bool acpi_boot_table_init_done = false, relocated = false; @@ -1353,7 +1360,8 @@ void __init noreturn __start_xen(unsigned long mbi_p) mod[boot_info->nr_mods].mod_end = __2M_rwdata_end - _stext; } - modules_headroom = bzimage_headroom(bootstrap_map(mod), mod->mod_end); + boot_info->mods[0].arch->headroom = bzimage_headroom(bootstrap_map(mod), + mod->mod_end); bootstrap_map(NULL); #ifndef highmem_start @@ -1433,7 +1441,8 @@ void __init noreturn __start_xen(unsigned long mbi_p) /* Is the region suitable for relocating the multiboot modules? */ for ( j = boot_info->nr_mods - 1; j >= 0; j-- ) { - unsigned long headroom = j ? 0 : modules_headroom; + struct boot_module *boot_mods = boot_info->mods; + unsigned long headroom = j ? 0 : boot_mods[0].arch->headroom; unsigned long size = PAGE_ALIGN(headroom + mod[j].mod_end); if ( mod[j].reserved ) @@ -1481,7 +1490,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) #endif } - if ( modules_headroom && !mod->reserved ) + if ( boot_info->mods[0].arch->headroom && !mod->reserved ) panic("Not enough memory to relocate the dom0 kernel image\n"); for ( i = 0; i < boot_info->nr_mods; ++i ) { @@ -2021,7 +2030,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) * We're going to setup domain0 using the module(s) that we stashed safely * above our heap. The second module, if present, is an initrd ramdisk. */ - dom0 = create_dom0(mod, modules_headroom, + dom0 = create_dom0(mod, boot_info->mods[0].arch->headroom, initrdidx < boot_info->nr_mods ? mod + initrdidx : NULL, kextra, loader); if ( !dom0 ) diff --git a/xen/include/xen/bootinfo.h b/xen/include/xen/bootinfo.h index 6a7d55d20e..b72ae31a66 100644 --- a/xen/include/xen/bootinfo.h +++ b/xen/include/xen/bootinfo.h @@ -3,8 +3,19 @@ #include +#ifdef CONFIG_X86 +#include +#else + struct arch_bootmodule { }; +#endif + +struct boot_module { + struct arch_bootmodule *arch; +}; + struct boot_info { unsigned int nr_mods; + struct boot_module *mods; }; #endif -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 01 00:31:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 00:31:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557674.871288 (Exim 4.92) (envelope-from ) id 1qFOWp-0001aT-68; Sat, 01 Jul 2023 00:31:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557674.871288; Sat, 01 Jul 2023 00:31:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFOWo-0001Yr-RA; Sat, 01 Jul 2023 00:31:54 +0000 Received: by outflank-mailman (input) for mailman id 557674; Sat, 01 Jul 2023 00:31:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFOWn-0007yM-5t for xen-devel@lists.xenproject.org; Sat, 01 Jul 2023 00:31:53 +0000 Received: from mail-yb1-xb34.google.com (mail-yb1-xb34.google.com [2607:f8b0:4864:20::b34]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id abc9c57b-17a6-11ee-8611-37d641c3527e; Sat, 01 Jul 2023 02:31:51 +0200 (CEST) Received: by mail-yb1-xb34.google.com with SMTP id 3f1490d57ef6-c2cf4e61bc6so2479592276.3 for ; Fri, 30 Jun 2023 17:31:51 -0700 (PDT) Received: from cog-dev.home ([70.103.208.83]) by smtp.gmail.com with ESMTPSA id s68-20020a632c47000000b0055b61cd99a1sm1824296pgs.81.2023.06.30.17.31.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jun 2023 17:31:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: abc9c57b-17a6-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688171510; x=1690763510; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=goxmEkry0U1HLmMVQmvP8Gde9Okz3AzqGSy+FqLUKTI=; b=RlFU8aKTsmTkSL803ovUEfnOumnnC/JpNxk55d3A7YSbtFDeqvpjZ6/eL3TunyDqWh zaWgXHHrtXf8xX0sgRwwabeQE86Cm9/vsUzKHuqIQ/XbSMJRM2zm/aSRzGCL/Qz54s12 bkP/KZqdfw8A7X9ZEQyg6pf90WWkKh3x1f89t7X/jio6qN17ae7jXrFtJYnGzvaEgzut B9zrWTvWQYTmA8r23TnpcqdP7KjWBrVOAwyjMRDIw0XruQen8xsrU/HRQt2WoN2QN4/P zGdzzWbBLixZFiF19BmePZ3k55LeGaLKxtAr3d8EjmWqAPSZSIXnotYHZsgOc/94ocNl 1igg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688171510; x=1690763510; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=goxmEkry0U1HLmMVQmvP8Gde9Okz3AzqGSy+FqLUKTI=; b=VfHNBX/5Ahf/xpFhLFcUItScY4OaFWNI9I1W7tRaF7S9ugIAZvk1L7P36L0PridW9G XhOGxNrqwmev6pjJoiQTsrb0c7MvT1QLtprsDZqmbHEPfomevyJkvkObXy4QtZBZ7s6w qM7RC+3TDcSkzaTu3SuIDSzEiNxblgDu3Hfzsn7FdN4Dt4fS+ZCMxR4rUUA/hnV6k8Cq obRXYSwrlFo1C3CeXNpSnH+vHBQDcoA923KrTFovqr9lwHoxQpeODSkr+zm1jsfzFChG L1rMeiJd1+sTxIVnR5psQwu0j3xaMreRRdk+ojGLs8+YnnFvSYHPGO/eqLBplHAFmJ0H rNGQ== X-Gm-Message-State: ABy/qLYRi9b026y8iWCQPKiYlF7HgRoQH9miSGZwQQoEYQIMQRviKgW0 5VoI+iOWRbhvjW+XN9nthYDMJQuzyr8= X-Google-Smtp-Source: APBJJlEARNWgLjZpa74rQHLaxgPV1NZ3cvoIaJB/ZTsURcawLd8v/B1Kpv9K2P83VDZePWvxDNRJ0w== X-Received: by 2002:a25:cb4e:0:b0:c1e:a1b8:1667 with SMTP id b75-20020a25cb4e000000b00c1ea1b81667mr4227415ybg.22.1688171509994; Fri, 30 Jun 2023 17:31:49 -0700 (PDT) Sender: Christopher Clark From: Christopher Clark To: xen-devel@lists.xenproject.org Cc: Daniel Smith , stefano.stabellini@amd.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Luca Fancellu , Volodymyr Babchuk , Rich Persaud Subject: [PATCH 08/11] types, x86 boot: define DEFINE_PTR_TYPE and char_ptr_t Date: Fri, 30 Jun 2023 17:31:29 -0700 Message-Id: <20230701003132.2210306-9-christopher.w.clark@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230701003132.2210306-1-christopher.w.clark@gmail.com> References: <20230701003132.2210306-1-christopher.w.clark@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Pointer fields within structs need to be defined as fixed size types in the x86 boot build environment. Using a typedef for the field type enables the definition to be changed in the 32-bit boot build and the main hypervisor build, allowing for a single common structure definition and a common header file. Add a macro for defining pointer types for fields and use this macro for pointers to chars in and as preparation for using these headers in the x86 boot build. The 32-bit behaviour is obtained by inclusion of "defs.h" first with a check for such an existing definition on the version. Signed-off-by: Christopher Clark Signed-off-by: Daniel P. Smith New in v2 --- xen/arch/x86/boot/defs.h | 4 ++++ xen/arch/x86/include/asm/bootinfo.h | 2 +- xen/include/xen/bootinfo.h | 2 +- xen/include/xen/types.h | 6 ++++++ 4 files changed, 12 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/boot/defs.h b/xen/arch/x86/boot/defs.h index 867df6d18d..bc0f1b5cf8 100644 --- a/xen/arch/x86/boot/defs.h +++ b/xen/arch/x86/boot/defs.h @@ -65,4 +65,8 @@ typedef unsigned long long paddr_t; #define DEFINE_STRUCT_PTR_TYPE(struct_name) \ typedef uint64_t struct_name ## _ptr_t; +#define DEFINE_PTR_TYPE(type) \ + typedef uint64_t type ## _ptr_t; +DEFINE_PTR_TYPE(char); + #endif /* __BOOT_DEFS_H__ */ diff --git a/xen/arch/x86/include/asm/bootinfo.h b/xen/arch/x86/include/asm/bootinfo.h index 8d1261503d..989fb7a1da 100644 --- a/xen/arch/x86/include/asm/bootinfo.h +++ b/xen/arch/x86/include/asm/bootinfo.h @@ -15,7 +15,7 @@ struct arch_boot_info { #define BOOTINFO_FLAG_X86_MEMMAP 1U << 6 #define BOOTINFO_FLAG_X86_LOADERNAME 1U << 9 - char *boot_loader_name; + char_ptr_t boot_loader_name; uint32_t mmap_length; paddr_t mmap_addr; diff --git a/xen/include/xen/bootinfo.h b/xen/include/xen/bootinfo.h index 8ee3ee36e9..8389da4f72 100644 --- a/xen/include/xen/bootinfo.h +++ b/xen/include/xen/bootinfo.h @@ -41,7 +41,7 @@ struct boot_module { DEFINE_STRUCT_PTR_TYPE(boot_module); struct boot_info { - char *cmdline; + char_ptr_t cmdline; unsigned int nr_mods; boot_module_ptr_t mods; diff --git a/xen/include/xen/types.h b/xen/include/xen/types.h index 78a2079619..e807ffe255 100644 --- a/xen/include/xen/types.h +++ b/xen/include/xen/types.h @@ -76,4 +76,10 @@ typedef bool bool_t; typedef struct struct_name * struct_name ## _ptr_t; #endif +#ifndef DEFINE_PTR_TYPE +#define DEFINE_PTR_TYPE(type) \ + typedef type * type ## _ptr_t; +DEFINE_PTR_TYPE(char); +#endif + #endif /* __TYPES_H__ */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 01 00:31:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 00:31:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557665.871207 (Exim 4.92) (envelope-from ) id 1qFOWg-0007yU-4S; Sat, 01 Jul 2023 00:31:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557665.871207; Sat, 01 Jul 2023 00:31:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFOWg-0007yN-1s; Sat, 01 Jul 2023 00:31:46 +0000 Received: by outflank-mailman (input) for mailman id 557665; Sat, 01 Jul 2023 00:31:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFOWd-0007yB-Vc for xen-devel@lists.xenproject.org; Sat, 01 Jul 2023 00:31:44 +0000 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [2607:f8b0:4864:20::529]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a5e7dadd-17a6-11ee-b237-6b7b168915f2; Sat, 01 Jul 2023 02:31:42 +0200 (CEST) Received: by mail-pg1-x529.google.com with SMTP id 41be03b00d2f7-517ab9a4a13so1609285a12.1 for ; Fri, 30 Jun 2023 17:31:41 -0700 (PDT) Received: from cog-dev.home ([70.103.208.83]) by smtp.gmail.com with ESMTPSA id s68-20020a632c47000000b0055b61cd99a1sm1824296pgs.81.2023.06.30.17.31.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jun 2023 17:31:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: a5e7dadd-17a6-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688171500; x=1690763500; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=0KShfPa2MYNDYvy3QcwTC4m5i40zpzbfd6OhegXALTA=; b=SYVViW8Kq3XV7ttdG4YkvMDrD04h3WC6+r/LzrevHdjm7LO/JG32gqJcpagAraFkJf MAFA0kBDqNk7ySD9J5b6D+8K5Arg4F+ITABIIG9UTx3GK7/3sigm6NSW3Op8pHvMqGL1 vGG91YEVhXngmP57SYfov06GZn+BeE0C5aJOs1XuRaa6BWDI7ygOg6QFLBPkgWAH6xFe JpmTRkZ4ZkdoVjeMHXr8orfmloLFvMgD/UuoDuS+i/Pbw49mjmhIv2mMLFoY6P8XuIwG qzJLTHljPmyFsMRJ5l96K5YSVjUvfNTBszd/WAyds5XTOEcp+Y+kcVx7aid7aS7SQt8V dVrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688171500; x=1690763500; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0KShfPa2MYNDYvy3QcwTC4m5i40zpzbfd6OhegXALTA=; b=XTONTon8ZoQFAoP8iUlvmOmPJMWnvjESbdUoW3kH7FNdXtToU1EBqz8B1p5FSmL7Vk +q2GLrCa5A0FuA/IgognpW0lMXyxdHEQFVaY2S8bU6f6xjDAoRFCRkeCPYSCOH4g1xxR w867jlB4u0KSjYJm4QoBij6OErbqlJn0WgzVF3lsHttLW1QOecVxODQbSa1Wt4Wdv8AR 4sjxkw2USByEaeGdjtVbNFs4qivHic6fKq8rl3WEoRBWW9oPgC1Gca26hTjENH+kMGBJ M7Y8zD705qjWC9geg63taB7fqa6pyL8CiJwHu8vw1rBq7TavI1G5AoYQIRWoMqEGGAyS z34g== X-Gm-Message-State: AC+VfDzJH1Br7CW1fuh4QFuwDCD7jVfqqBP7FZ7BYPRWmYqKM8BapjDv yZHuk+8HZesMfy4lY3Ipg8hKDp61JHg= X-Google-Smtp-Source: ACHHUZ7Li8ezhJYAShh3/ZzQAdyQzMjFylf+La4WOAedx9NLRQbBjdH20CpyW9vn7ElsAgYNwzV3uA== X-Received: by 2002:a05:6a20:9719:b0:122:7e90:61c2 with SMTP id hr25-20020a056a20971900b001227e9061c2mr4071641pzc.9.1688171499907; Fri, 30 Jun 2023 17:31:39 -0700 (PDT) Sender: Christopher Clark From: Christopher Clark To: xen-devel@lists.xenproject.org Cc: Daniel Smith , stefano.stabellini@amd.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Luca Fancellu , Volodymyr Babchuk , Rich Persaud Subject: [PATCH 00/11] v2: Boot modules for Hyperlaunch Date: Fri, 30 Jun 2023 17:31:21 -0700 Message-Id: <20230701003132.2210306-1-christopher.w.clark@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is a v2 series of work for Hyperlaunch for the Xen hypervisor, implementing a subset of the v1 series and functionality, with changes made to address the community feedback provided on the patches in v1. The patches in this series are primarily derived from patches 2-4 of the v1 full series, in a series of smaller patches for ease of review. Thanks to AMD for supporting this work. Documentation on Hyperlaunch: https://wiki.xenproject.org/wiki/Hyperlaunch v1 Hyperlaunch patch series: https://lists.xenproject.org/archives/html/xen-devel/2022-07/msg00345.html thanks Christopher Christopher Clark (11): x86 setup: move x86 boot module counting into a new boot_info struct x86 setup: per-arch bootmodule structure, headroom field x86 setup: change bootstrap map to accept new boot module structures x86 setup: porting dom0 construction logic to boot module structures xsm: switch XSM init to boot info structures x86 setup, microcode: switch to the new bootinfo structures x86 boot: define paddr_t and add macros for typedefing struct pointers types, x86 boot: define DEFINE_PTR_TYPE and char_ptr_t x86, arm, riscv: add per-arch bootinfo headers to allow x86 boot include arm setup: include for bootmod defns, replacing enum x86 setup: refactor entrypoints to new boot info xen/arch/arm/efi/efi-boot.h | 6 + xen/arch/arm/include/asm/bootinfo.h | 20 ++ xen/arch/arm/include/asm/setup.h | 11 +- xen/arch/riscv/include/asm/bootinfo.h | 20 ++ xen/arch/x86/boot/defs.h | 10 + xen/arch/x86/boot/reloc.c | 192 ++++++++++++------ xen/arch/x86/bzimage.c | 10 +- xen/arch/x86/cpu/microcode/core.c | 149 ++++++++------ xen/arch/x86/dom0_build.c | 10 +- xen/arch/x86/efi/efi-boot.h | 95 +++++---- xen/arch/x86/guest/xen/pvh-boot.c | 65 ++++-- xen/arch/x86/hvm/dom0_build.c | 44 ++-- xen/arch/x86/include/asm/boot.h | 55 +++++ xen/arch/x86/include/asm/bootinfo.h | 47 +++++ xen/arch/x86/include/asm/bzimage.h | 2 +- xen/arch/x86/include/asm/dom0_build.h | 13 +- xen/arch/x86/include/asm/guest/pvh-boot.h | 6 +- xen/arch/x86/include/asm/microcode.h | 7 +- xen/arch/x86/include/asm/setup.h | 7 +- xen/arch/x86/pv/dom0_build.c | 32 +-- xen/arch/x86/setup.c | 232 ++++++++++++---------- xen/common/efi/boot.c | 4 +- xen/include/xen/bootinfo.h | 62 ++++++ xen/include/xen/types.h | 11 + xen/include/xsm/xsm.h | 28 +-- xen/xsm/xsm_core.c | 47 +++-- xen/xsm/xsm_policy.c | 58 +++--- 27 files changed, 821 insertions(+), 422 deletions(-) create mode 100644 xen/arch/arm/include/asm/bootinfo.h create mode 100644 xen/arch/riscv/include/asm/bootinfo.h create mode 100644 xen/arch/x86/include/asm/boot.h create mode 100644 xen/arch/x86/include/asm/bootinfo.h create mode 100644 xen/include/xen/bootinfo.h -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 01 00:31:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 00:31:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557675.871293 (Exim 4.92) (envelope-from ) id 1qFOWp-0001jL-QV; Sat, 01 Jul 2023 00:31:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557675.871293; Sat, 01 Jul 2023 00:31:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFOWp-0001hu-Kk; Sat, 01 Jul 2023 00:31:55 +0000 Received: by outflank-mailman (input) for mailman id 557675; Sat, 01 Jul 2023 00:31:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFOWo-0007yM-Lf for xen-devel@lists.xenproject.org; Sat, 01 Jul 2023 00:31:54 +0000 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [2607:f8b0:4864:20::1032]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ac76a5b0-17a6-11ee-8611-37d641c3527e; Sat, 01 Jul 2023 02:31:53 +0200 (CEST) Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-262e3c597b9so1620980a91.0 for ; Fri, 30 Jun 2023 17:31:52 -0700 (PDT) Received: from cog-dev.home ([70.103.208.83]) by smtp.gmail.com with ESMTPSA id s68-20020a632c47000000b0055b61cd99a1sm1824296pgs.81.2023.06.30.17.31.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jun 2023 17:31:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: ac76a5b0-17a6-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688171511; x=1690763511; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=CmW5UL4mCfeFM30iYwmo6ORQbNbEDrG26I97OFcvUzw=; b=mDKgu0N+J33pO8y0qR4pSU8R7axaOqaVgxvtdIbHJ/u5JctG4BQbpTI1b8p0w6bMxj vBWwRDK2eoOR5P9dkryVjt5TX0WBEPhbhga2jxGg5Vb61RbW9ZtEutPIhi/rZtxxBsR0 4F8CEALSdMAiVUH7yX86MmPiH0ejByPiN5EDvdXMaR1DMEimhq7JT6vRvgTqUsL0cKUA vqUeyprCLh7K6Op05ef3VP0rWttXdevLjPaXqhhpPmeeJcaiY+GPx1vML2mt3/G5IcyM jtiWQEJFHX+gk4Id3se+AhfCekKQavsgUuRccMqLcTFrqcPs4SUl7LvaQHGFOEZYe+o0 Xv7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688171511; x=1690763511; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CmW5UL4mCfeFM30iYwmo6ORQbNbEDrG26I97OFcvUzw=; b=dJYjYyFU1zKU79X4H1VUfv/78iWDGlpP22nyiB51VNVrLFGYb4OfB32ws7wAQpl1hF nH30KzAsEiM68Wy1G1O+gLcIBMMz+Pj9A2uVYyaTDZeRNSjvbONzRB0ecba0k24B8CH+ /94dJhr7QlSDaecJsfUcKlKLEWPno6FwhJC59ySfjahmuOecVUQ2YjtGs02Zbc91A1ti Rc2U3zHJITVTkMCe7sS2UqLJawagpqqegaZ9aKrbu3KDKjWyEjRBdAPncCspz+FGjugL gWhehBNQy2jK+Zaz31SZIodqxB0RoEuz9PvvQlSVM9S7lfCpo8anJrPxc5Loa1r9+ukN pZEA== X-Gm-Message-State: ABy/qLYG9wtwcn6sUvSNp3RnXiXciJQduXNhKU7nDwn0iXSkuyq4Qlma DRZP4zqn9xaV5TJoje/uu1SPpcn+1tg= X-Google-Smtp-Source: APBJJlGMLddV7br5bz18vAf2YOGfu1jHgiMmcg8DV5OkPbHOCTMCceaaVMmcoUwcBKrRC46JWnECog== X-Received: by 2002:a17:90a:f00c:b0:262:c9f4:141 with SMTP id bt12-20020a17090af00c00b00262c9f40141mr3264484pjb.42.1688171510911; Fri, 30 Jun 2023 17:31:50 -0700 (PDT) Sender: Christopher Clark From: Christopher Clark To: xen-devel@lists.xenproject.org Cc: Daniel Smith , stefano.stabellini@amd.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Luca Fancellu , Volodymyr Babchuk , Rich Persaud Subject: [PATCH 09/11] x86, arm, riscv: add per-arch bootinfo headers to allow x86 boot include Date: Fri, 30 Jun 2023 17:31:30 -0700 Message-Id: <20230701003132.2210306-10-christopher.w.clark@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230701003132.2210306-1-christopher.w.clark@gmail.com> References: <20230701003132.2210306-1-christopher.w.clark@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The header contains structures that will be used in efi logic prior to the main start of Xen, so will soon be included in Arm builds. This same header will also used in early x86 boot, where asm/* headers are not reachable and yet it contains a needed include of , so... Add initial per-arch headers to Arm and RISC-V so that inclusion of succeeds in each main arch build and then gate that inclusion from on CONFIG variables so that it does not take effect in the early x86 boot build where CONFIG_X86 is not defined to prevent build failure there. The early x86 boot logic can then directly include asm/bootinfo.h via a specified directory path to bring in the necessary definitions. Is this fantastic? No. Does it help? Yep. Signed-off-by: Christopher Clark Signed-off-by: Daniel P. Smith New for v2 series. --- xen/arch/arm/include/asm/bootinfo.h | 20 ++++++++++++++++++++ xen/arch/riscv/include/asm/bootinfo.h | 20 ++++++++++++++++++++ xen/include/xen/bootinfo.h | 7 ++----- 3 files changed, 42 insertions(+), 5 deletions(-) create mode 100644 xen/arch/arm/include/asm/bootinfo.h create mode 100644 xen/arch/riscv/include/asm/bootinfo.h diff --git a/xen/arch/arm/include/asm/bootinfo.h b/xen/arch/arm/include/asm/bootinfo.h new file mode 100644 index 0000000000..5316c87a3d --- /dev/null +++ b/xen/arch/arm/include/asm/bootinfo.h @@ -0,0 +1,20 @@ +#ifndef __ARCH_ARM_BOOTINFO_H__ +#define __ARCH_ARM_BOOTINFO_H__ + +struct __packed arch_bootmodule { }; +DEFINE_STRUCT_PTR_TYPE(arch_bootmodule); + +struct __packed arch_boot_info { }; +DEFINE_STRUCT_PTR_TYPE(arch_boot_info); + +#endif + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/include/asm/bootinfo.h b/xen/arch/riscv/include/asm/bootinfo.h new file mode 100644 index 0000000000..5316c87a3d --- /dev/null +++ b/xen/arch/riscv/include/asm/bootinfo.h @@ -0,0 +1,20 @@ +#ifndef __ARCH_ARM_BOOTINFO_H__ +#define __ARCH_ARM_BOOTINFO_H__ + +struct __packed arch_bootmodule { }; +DEFINE_STRUCT_PTR_TYPE(arch_bootmodule); + +struct __packed arch_boot_info { }; +DEFINE_STRUCT_PTR_TYPE(arch_boot_info); + +#endif + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/include/xen/bootinfo.h b/xen/include/xen/bootinfo.h index 8389da4f72..bf5586a76b 100644 --- a/xen/include/xen/bootinfo.h +++ b/xen/include/xen/bootinfo.h @@ -5,11 +5,8 @@ #include #include -#ifdef CONFIG_X86 -#include -#else - struct arch_bootmodule { }; - struct arch_boot_info { }; +#if defined CONFIG_X86 || CONFIG_ARM || CONFIG_RISCV +# include #endif /* Boot module binary type / purpose */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 01 00:31:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 00:31:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557676.871305 (Exim 4.92) (envelope-from ) id 1qFOWr-00029E-B3; Sat, 01 Jul 2023 00:31:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557676.871305; Sat, 01 Jul 2023 00:31:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFOWr-000285-2V; Sat, 01 Jul 2023 00:31:57 +0000 Received: by outflank-mailman (input) for mailman id 557676; Sat, 01 Jul 2023 00:31:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFOWp-0007yM-98 for xen-devel@lists.xenproject.org; Sat, 01 Jul 2023 00:31:55 +0000 Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [2607:f8b0:4864:20::32f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id acfe17ca-17a6-11ee-8611-37d641c3527e; Sat, 01 Jul 2023 02:31:53 +0200 (CEST) Received: by mail-ot1-x32f.google.com with SMTP id 46e09a7af769-6b886456f66so1790531a34.0 for ; Fri, 30 Jun 2023 17:31:53 -0700 (PDT) Received: from cog-dev.home ([70.103.208.83]) by smtp.gmail.com with ESMTPSA id s68-20020a632c47000000b0055b61cd99a1sm1824296pgs.81.2023.06.30.17.31.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jun 2023 17:31:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: acfe17ca-17a6-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688171512; x=1690763512; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=eobWsLudL6LP1s0XBewioDQ6KL/Td7X9osJXVUd2EmM=; b=pf3RZgrNX5scU+U3lhARSed2bh0CIo65idYmRx10QaH4gLLS1AJULsKiycGFXhiGfl NR2ogZiVsBDBGt3Al4XEWq65oaE/xBuon/T1vnxmR1vInlsO18XF1426wwxJRTyvC6vt wdE3IMbxClp05AKOlX+gLsnb7A713aLkJC9XmSVGbvXPTKXgerTwQunxPbT1rPpQ4uCI gf5iY0TjNrztpZ2Z0uATKtn9OOm+nvGbf4bF3r6a5aBLAt/a5plRrriYkQFO/Lyde2aE gEdgnFYryrGJuCLoDhzliHOQOeL0lt21t2AgiOHS1B7cc3hcZwsTWCzhTtZCG2RfXYba P8Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688171512; x=1690763512; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eobWsLudL6LP1s0XBewioDQ6KL/Td7X9osJXVUd2EmM=; b=cnwYgqDUuvFUBdbso+NhkQZ516fNARucsuZOJ0WsjMgo7Vqk7iRpS0cmbM4Uf3pA0i mvb9RN/zhVRFk42VRtvaF7MbjigCPBW4gTh1wx2Zx5z2n/AdTLfHfsx/yCPwymWsVTUa VfKmHj80saEV7tpnap13Y5XkXHc8Q8sf+fZAdGilCExZdhZ0m3cdBcJHuxn/axxTxecP JUQr5ziFy7EazWIdB3t4XSm8jltBv6qWGMBu4QyOnrL9KoRoGkQSYl6pys9WB6GVt0bQ Q6/zA7lRCrm6qbOcA4odpWyTDa3DKmNFw1f4Y+lL2vjEXDX5ujSfxNFDMZD3lTy6oa4E 9Cjg== X-Gm-Message-State: AC+VfDzYMHzhSPSSU1lM/6yIC8UtTGVGKRhpSwJ5QuJRwgv27aACBusr AhG7AgGHresco+B6e/kXXhFchdZA9/c= X-Google-Smtp-Source: ACHHUZ4Aj8NvkVJllvxkQKfVm9FJZ4c/6HPUItf+wawkjEKnebTGZb1aBVz7wrUVpJI/QgyMqF2BdQ== X-Received: by 2002:a05:6830:1104:b0:6b8:7db6:9ab5 with SMTP id w4-20020a056830110400b006b87db69ab5mr4305120otq.12.1688171512057; Fri, 30 Jun 2023 17:31:52 -0700 (PDT) Sender: Christopher Clark From: Christopher Clark To: xen-devel@lists.xenproject.org Cc: Daniel Smith , stefano.stabellini@amd.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Luca Fancellu , Volodymyr Babchuk , Rich Persaud Subject: [PATCH 10/11] arm setup: include for bootmod defns, replacing enum Date: Fri, 30 Jun 2023 17:31:31 -0700 Message-Id: <20230701003132.2210306-11-christopher.w.clark@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230701003132.2210306-1-christopher.w.clark@gmail.com> References: <20230701003132.2210306-1-christopher.w.clark@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This change enables and begins introducion of into Arm builds: it replace the enum definition of bootmodule_kind with bootmod_type_t which is a fixed size type as needed for packed structs, to be used in the boot structures in subsequent changes. Signed-off-by: Christopher Clark Signed-off-by: Daniel P. Smith New for v2 series. --- xen/arch/arm/include/asm/setup.h | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 38e2ce255f..ce3882ca67 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -3,6 +3,7 @@ #include #include +#include #include #define MIN_FDT_ALIGN 8 @@ -12,15 +13,7 @@ #define MAX_MODULES 32 /* Current maximum useful modules */ -typedef enum { - BOOTMOD_XEN, - BOOTMOD_FDT, - BOOTMOD_KERNEL, - BOOTMOD_RAMDISK, - BOOTMOD_XSM, - BOOTMOD_GUEST_DTB, - BOOTMOD_UNKNOWN -} bootmodule_kind; +typedef bootmod_type_t bootmodule_kind; enum membank_type { /* -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 01 00:31:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 00:31:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557678.871317 (Exim 4.92) (envelope-from ) id 1qFOWs-0002Wh-TI; Sat, 01 Jul 2023 00:31:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557678.871317; Sat, 01 Jul 2023 00:31:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFOWs-0002W6-LQ; Sat, 01 Jul 2023 00:31:58 +0000 Received: by outflank-mailman (input) for mailman id 557678; Sat, 01 Jul 2023 00:31:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFOWq-0007yB-PN for xen-devel@lists.xenproject.org; Sat, 01 Jul 2023 00:31:57 +0000 Received: from mail-oo1-xc32.google.com (mail-oo1-xc32.google.com [2607:f8b0:4864:20::c32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id adc67b96-17a6-11ee-b237-6b7b168915f2; Sat, 01 Jul 2023 02:31:55 +0200 (CEST) Received: by mail-oo1-xc32.google.com with SMTP id 006d021491bc7-5634db21a58so1666089eaf.0 for ; Fri, 30 Jun 2023 17:31:54 -0700 (PDT) Received: from cog-dev.home ([70.103.208.83]) by smtp.gmail.com with ESMTPSA id s68-20020a632c47000000b0055b61cd99a1sm1824296pgs.81.2023.06.30.17.31.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jun 2023 17:31:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: adc67b96-17a6-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688171513; x=1690763513; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=Lc4F58lZGArBW0YBbdm+a1mT2bCVXrWRmAPLEIHYE0U=; b=RH+jyvfx1XbiemxdH/8VzA6hoZYenfI0d8V09JZi98CP5PRtk4Vj1NX56nlOtabZaT ds0grTQkfIB/03q3iC4bW94Qs0s6wmIMtlAMJwi5fM2LXo6an55PnNKhb4DWSwooZ0ZQ ofDBUAhUGcW+xOowTswUKS7m88zIaqHBNnUnymOKXKXLxNltVRZ/2ftuGAZYIXseBtDx DyErGYzNb2pFb8jf5dwCQEXOsTw2UmyWsHJxA8grvlcXdTefUiNX49sIqiiZvs1OVSv7 ub6MDDCvnNS1XGFPLukt8UYbIR1bgceZEaf6L9piJyRry+EIY6S5pqoJml1lAXppVZFE PvfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688171513; x=1690763513; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Lc4F58lZGArBW0YBbdm+a1mT2bCVXrWRmAPLEIHYE0U=; b=GYVKRAQcw/kLcRIpcP2jNVeFfrz6XOhVycosOSLU9bI1k6eY2Mgtklj3m4e1KLvJDp CTKQN3sVAf5LSGyI5kFWO0pGtwoZUo6WJEsZh8AvIalRDE1vV1GsaJU6pHTbpGU0zAen xx84bmvVWy51tYJaR1FBUdVzc8CzkkeQ99oT5lpPo6GOshE9icc0DzAN717yFUny+Fa0 rNraGbdOQkXaMn+GEZnCY2D1ZY8WqxMm+/5F4p8o1M678IDkpXfNOdi1WYyzbrsV0Z7n xc2xjZzmRbpdabORdCb90+4+kRD7vVzIMLubluAp6dESgLi0lPBByn1Lnfk39XpqqMDn Yi0Q== X-Gm-Message-State: AC+VfDyw5nN9f/Z8Crs6ROMcQNnopdglpQJRexYIPD9JjDlD8H137y2v XudzlBenZ9/L5tIBxjBZgjvOsadmD04= X-Google-Smtp-Source: ACHHUZ4OyiOTJ7Y+BDtup3FLBUjhuwwXpv7JZBUCRgYkED6g1b1biZAa7cJMMUNZs36CyoB5weiuWw== X-Received: by 2002:a05:6808:8c8:b0:3a1:ead3:bf20 with SMTP id k8-20020a05680808c800b003a1ead3bf20mr3981522oij.33.1688171513115; Fri, 30 Jun 2023 17:31:53 -0700 (PDT) Sender: Christopher Clark From: Christopher Clark To: xen-devel@lists.xenproject.org Cc: Daniel Smith , stefano.stabellini@amd.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Luca Fancellu , Volodymyr Babchuk , Rich Persaud Subject: [PATCH 11/11] x86 setup: refactor entrypoints to new boot info Date: Fri, 30 Jun 2023 17:31:32 -0700 Message-Id: <20230701003132.2210306-12-christopher.w.clark@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230701003132.2210306-1-christopher.w.clark@gmail.com> References: <20230701003132.2210306-1-christopher.w.clark@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Previous commits added a transition point from multiboot v1 structures to the new boot info structures at the earliest common point for all the x86 entrypoints. The result is that each of the entrypoints would construct a multiboot v1 structure from the structures used by each entrypoint.  This meant that multiboot2, EFI, and PVH all converted their structures over to mutliboot v1 to only be converted again upon entering __start_xen(). This commit drops the translation function and moves the population of the new boot info structures down into the various entrypoints. Signed-off-by: Christopher Clark Signed-off-by: Daniel P. Smith changes since v1: - based on v1 series patch 4 - use main bootinfo headers in boot logic instead of adding a 32-bit version - apply packing to boot structures here rather than in earlier changes - use a defined maximum rather than Kconfig'd variable --- xen/arch/arm/efi/efi-boot.h | 6 + xen/arch/x86/boot/defs.h | 1 + xen/arch/x86/boot/reloc.c | 192 +++++++++++++++------- xen/arch/x86/efi/efi-boot.h | 95 ++++++----- xen/arch/x86/guest/xen/pvh-boot.c | 64 +++++--- xen/arch/x86/include/asm/bootinfo.h | 7 +- xen/arch/x86/include/asm/guest/pvh-boot.h | 6 +- xen/arch/x86/setup.c | 73 +++----- xen/common/efi/boot.c | 4 +- xen/include/xen/bootinfo.h | 9 +- 10 files changed, 278 insertions(+), 179 deletions(-) diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h index bb64925d70..d931fe06ed 100644 --- a/xen/arch/arm/efi/efi-boot.h +++ b/xen/arch/arm/efi/efi-boot.h @@ -1003,6 +1003,12 @@ static void __init efi_arch_flush_dcache_area(const void *vaddr, UINTN size) __flush_dcache_area(vaddr, size); } +static struct boot_info __init *efi_arch_bootinfo_init(void) +{ + /* boot modules not currently in use on Arm so no init required here */ + return NULL; +} + /* * Local variables: * mode: C diff --git a/xen/arch/x86/boot/defs.h b/xen/arch/x86/boot/defs.h index bc0f1b5cf8..519ca4dae6 100644 --- a/xen/arch/x86/boot/defs.h +++ b/xen/arch/x86/boot/defs.h @@ -44,6 +44,7 @@ _x > _y ? _x : _y; }) #define _p(val) ((void *)(unsigned long)(val)) +#define _addr(val) ((unsigned long)(void *)(val)) #define tolower(c) ((c) | 0x20) diff --git a/xen/arch/x86/boot/reloc.c b/xen/arch/x86/boot/reloc.c index e22bb974bf..8a48572d5f 100644 --- a/xen/arch/x86/boot/reloc.c +++ b/xen/arch/x86/boot/reloc.c @@ -27,6 +27,8 @@ asm ( ); #include "defs.h" +#include "../include/asm/bootinfo.h" +#include "../../../include/xen/bootinfo.h" #include "../../../include/xen/multiboot.h" #include "../../../include/xen/multiboot2.h" @@ -138,65 +140,116 @@ static struct hvm_start_info *pvh_info_reloc(u32 in) return out; } -static multiboot_info_t *mbi_reloc(u32 mbi_in) +static struct boot_info *mbi_reloc(u32 mbi_in) { + const multiboot_info_t *mbi = _p(mbi_in); + struct boot_info *binfo; + struct arch_boot_info *arch_binfo; int i; - multiboot_info_t *mbi_out; + uint32_t ptr; - mbi_out = _p(copy_mem(mbi_in, sizeof(*mbi_out))); + ptr = alloc_mem(sizeof(*binfo)); + zero_mem(ptr, sizeof(*binfo)); + binfo = _p(ptr); - if ( mbi_out->flags & MBI_CMDLINE ) - mbi_out->cmdline = copy_string(mbi_out->cmdline); + ptr = alloc_mem(sizeof(*arch_binfo)); + zero_mem(ptr, sizeof(*arch_binfo)); + binfo->arch = ptr; + arch_binfo = _p(ptr); - if ( mbi_out->flags & MBI_MODULES ) + if ( mbi->flags & MBI_CMDLINE ) + { + ptr = copy_string(mbi->cmdline); + binfo->cmdline = ptr; + arch_binfo->flags |= BOOTINFO_FLAG_X86_CMDLINE; + } + + if ( mbi->flags & MBI_MODULES ) { module_t *mods; + struct boot_module *bi_mods; + struct arch_bootmodule *arch_bi_mods; + + /* + * We have to allocate one more module slot here. At some point + * __start_xen() may put Xen image placement into it. + */ + ptr = alloc_mem((mbi->mods_count + 1) * sizeof(*bi_mods)); + binfo->nr_mods = mbi->mods_count; + binfo->mods = ptr; + bi_mods = _p(ptr); - mbi_out->mods_addr = copy_mem(mbi_out->mods_addr, - mbi_out->mods_count * sizeof(module_t)); + ptr = alloc_mem((mbi->mods_count + 1) * sizeof(*arch_bi_mods)); + arch_bi_mods = _p(ptr); - mods = _p(mbi_out->mods_addr); + /* map the +1 allocated for Xen image */ + bi_mods[mbi->mods_count].arch = _addr(&arch_bi_mods[mbi->mods_count]); - for ( i = 0; i < mbi_out->mods_count; i++ ) + arch_binfo->flags |= BOOTINFO_FLAG_X86_MODULES; + + mods = _p(mbi->mods_addr); + + for ( i = 0; i < mbi->mods_count; i++ ) { + bi_mods[i].start = mods[i].mod_start; + bi_mods[i].size = mods[i].mod_end - mods[i].mod_start; + if ( mods[i].string ) - mods[i].string = copy_string(mods[i].string); + { + int j; + char *c = _p(mods[i].string); + + for ( j = 0; *c != '\0'; j++, c++ ) + bi_mods[i].string.bytes[j] = *c; + + bi_mods[i].string.len = j + 1; + } + + bi_mods[i].arch = _addr(&arch_bi_mods[i]); } } - if ( mbi_out->flags & MBI_MEMMAP ) - mbi_out->mmap_addr = copy_mem(mbi_out->mmap_addr, mbi_out->mmap_length); - - if ( mbi_out->flags & MBI_LOADERNAME ) - mbi_out->boot_loader_name = copy_string(mbi_out->boot_loader_name); + if ( mbi->flags & MBI_MEMMAP ) + { + arch_binfo->mmap_addr = copy_mem(mbi->mmap_addr, mbi->mmap_length); + arch_binfo->mmap_length = mbi->mmap_length; + arch_binfo->flags |= BOOTINFO_FLAG_X86_MEMMAP; + } - /* Mask features we don't understand or don't relocate. */ - mbi_out->flags &= (MBI_MEMLIMITS | - MBI_CMDLINE | - MBI_MODULES | - MBI_MEMMAP | - MBI_LOADERNAME); + if ( mbi->flags & MBI_LOADERNAME ) + { + ptr = copy_string(mbi->boot_loader_name); + arch_binfo->boot_loader_name = ptr; + arch_binfo->flags |= BOOTINFO_FLAG_X86_LOADERNAME; + } - return mbi_out; + return binfo; } -static multiboot_info_t *mbi2_reloc(uint32_t mbi_in, uint32_t video_out) +static struct boot_info *mbi2_reloc(uint32_t mbi_in, uint32_t video_out) { const multiboot2_fixed_t *mbi_fix = _p(mbi_in); const multiboot2_memory_map_t *mmap_src; const multiboot2_tag_t *tag; - module_t *mbi_out_mods = NULL; memory_map_t *mmap_dst; - multiboot_info_t *mbi_out; + struct boot_info *binfo; + struct arch_boot_info *arch_binfo; + struct boot_module *bi_mods; + struct arch_bootmodule *arch_bi_mods; #ifdef CONFIG_VIDEO struct boot_video_info *video = NULL; #endif u32 ptr; unsigned int i, mod_idx = 0; - ptr = alloc_mem(sizeof(*mbi_out)); - mbi_out = _p(ptr); - zero_mem(ptr, sizeof(*mbi_out)); + ptr = alloc_mem(sizeof(*binfo)); + zero_mem(ptr, sizeof(*binfo)); + binfo = _p(ptr); + + ptr = alloc_mem(sizeof(*arch_binfo)); + zero_mem(ptr, sizeof(*arch_binfo)); + binfo->arch = ptr; + arch_binfo = _p(ptr); /* Skip Multiboot2 information fixed part. */ ptr = ALIGN_UP(mbi_in + sizeof(*mbi_fix), MULTIBOOT2_TAG_ALIGN); @@ -206,21 +259,28 @@ static multiboot_info_t *mbi2_reloc(uint32_t mbi_in, uint32_t video_out) tag = _p(ALIGN_UP((u32)tag + tag->size, MULTIBOOT2_TAG_ALIGN)) ) { if ( tag->type == MULTIBOOT2_TAG_TYPE_MODULE ) - ++mbi_out->mods_count; + ++binfo->nr_mods; else if ( tag->type == MULTIBOOT2_TAG_TYPE_END ) break; } - if ( mbi_out->mods_count ) + if ( binfo->nr_mods ) { - mbi_out->flags |= MBI_MODULES; /* * We have to allocate one more module slot here. At some point * __start_xen() may put Xen image placement into it. */ - mbi_out->mods_addr = alloc_mem((mbi_out->mods_count + 1) * - sizeof(*mbi_out_mods)); - mbi_out_mods = _p(mbi_out->mods_addr); + ptr = alloc_mem((binfo->nr_mods + 1) * sizeof(*bi_mods)); + binfo->mods = ptr; + bi_mods = _p(ptr); + + ptr = alloc_mem((binfo->nr_mods + 1) * sizeof(*arch_bi_mods)); + arch_bi_mods = _p(ptr); + + /* map the +1 allocated for Xen image */ + bi_mods[binfo->nr_mods].arch = _addr(&arch_bi_mods[binfo->nr_mods]); + + arch_binfo->flags |= BOOTINFO_FLAG_X86_MODULES; } /* Skip Multiboot2 information fixed part. */ @@ -232,39 +292,42 @@ static multiboot_info_t *mbi2_reloc(uint32_t mbi_in, uint32_t video_out) switch ( tag->type ) { case MULTIBOOT2_TAG_TYPE_BOOT_LOADER_NAME: - mbi_out->flags |= MBI_LOADERNAME; ptr = get_mb2_string(tag, string, string); - mbi_out->boot_loader_name = copy_string(ptr); + arch_binfo->boot_loader_name = copy_string(ptr); + arch_binfo->flags |= BOOTINFO_FLAG_X86_LOADERNAME; break; case MULTIBOOT2_TAG_TYPE_CMDLINE: - mbi_out->flags |= MBI_CMDLINE; ptr = get_mb2_string(tag, string, string); - mbi_out->cmdline = copy_string(ptr); + binfo->cmdline = copy_string(ptr); + arch_binfo->flags |= BOOTINFO_FLAG_X86_CMDLINE; break; case MULTIBOOT2_TAG_TYPE_BASIC_MEMINFO: - mbi_out->flags |= MBI_MEMLIMITS; - mbi_out->mem_lower = get_mb2_data(tag, basic_meminfo, mem_lower); - mbi_out->mem_upper = get_mb2_data(tag, basic_meminfo, mem_upper); + arch_binfo->mem_lower = get_mb2_data(tag, basic_meminfo, + mem_lower); + arch_binfo->mem_upper = get_mb2_data(tag, basic_meminfo, + mem_upper); break; case MULTIBOOT2_TAG_TYPE_MMAP: if ( get_mb2_data(tag, mmap, entry_size) < sizeof(*mmap_src) ) break; - mbi_out->flags |= MBI_MEMMAP; - mbi_out->mmap_length = get_mb2_data(tag, mmap, size); - mbi_out->mmap_length -= sizeof(multiboot2_tag_mmap_t); - mbi_out->mmap_length /= get_mb2_data(tag, mmap, entry_size); - mbi_out->mmap_length *= sizeof(*mmap_dst); + arch_binfo->mmap_length = get_mb2_data(tag, mmap, size); + arch_binfo->mmap_length -= sizeof(multiboot2_tag_mmap_t); + arch_binfo->mmap_length /= get_mb2_data(tag, mmap, entry_size); + arch_binfo->mmap_length *= sizeof(*mmap_dst); - mbi_out->mmap_addr = alloc_mem(mbi_out->mmap_length); + arch_binfo->mmap_addr = alloc_mem(arch_binfo->mmap_length); + arch_binfo->flags |= BOOTINFO_FLAG_X86_MEMMAP; mmap_src = get_mb2_data(tag, mmap, entries); - mmap_dst = _p(mbi_out->mmap_addr); + mmap_dst = _p(arch_binfo->mmap_addr); - for ( i = 0; i < mbi_out->mmap_length / sizeof(*mmap_dst); i++ ) + for ( i = 0; + i < arch_binfo->mmap_length / sizeof(*mmap_dst); + i++ ) { /* Init size member properly. */ mmap_dst[i].size = sizeof(*mmap_dst); @@ -280,14 +343,27 @@ static multiboot_info_t *mbi2_reloc(uint32_t mbi_in, uint32_t video_out) break; case MULTIBOOT2_TAG_TYPE_MODULE: - if ( mod_idx >= mbi_out->mods_count ) + if ( mod_idx >= binfo->nr_mods ) break; - mbi_out_mods[mod_idx].mod_start = get_mb2_data(tag, module, mod_start); - mbi_out_mods[mod_idx].mod_end = get_mb2_data(tag, module, mod_end); + bi_mods[mod_idx].start = get_mb2_data(tag, module, mod_start); + bi_mods[mod_idx].size = get_mb2_data(tag, module, mod_end) + - bi_mods[mod_idx].start; + ptr = get_mb2_string(tag, module, cmdline); - mbi_out_mods[mod_idx].string = copy_string(ptr); - mbi_out_mods[mod_idx].reserved = 0; + if ( ptr ) + { + int i; + char *c = _p(ptr); + + for ( i = 0; *c != '\0'; i++, c++ ) + bi_mods[mod_idx].string.bytes[i] = *c; + + bi_mods[mod_idx].string.len = i + 1; + } + + bi_mods[mod_idx].arch = _addr(&arch_bi_mods[mod_idx]); + ++mod_idx; break; @@ -344,11 +420,11 @@ static multiboot_info_t *mbi2_reloc(uint32_t mbi_in, uint32_t video_out) video->orig_video_isVGA = 0x23; #endif - return mbi_out; + return binfo; } -void *__stdcall reloc(uint32_t magic, uint32_t in, uint32_t trampoline, - uint32_t video_info) +void *__stdcall reloc( + uint32_t magic, uint32_t in, uint32_t trampoline, uint32_t video_info) { alloc = trampoline; diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h index c94e53d139..5f14065c9c 100644 --- a/xen/arch/x86/efi/efi-boot.h +++ b/xen/arch/x86/efi/efi-boot.h @@ -11,14 +11,17 @@ #include static struct file __initdata ucode; -static multiboot_info_t __initdata mbi = { - .flags = MBI_MODULES | MBI_LOADERNAME -}; + +static struct boot_info __initdata efi_bi; +static struct arch_boot_info __initdata efi_bi_arch; /* * The array size needs to be one larger than the number of modules we * support - see __start_xen(). */ -static module_t __initdata mb_modules[5]; +static struct boot_module __initdata efi_mods[MAX_NR_BOOTMODS + 1]; +static struct arch_bootmodule __initdata efi_arch_mods[MAX_NR_BOOTMODS + 1]; + +static const char *__initdata efi_loader = "PVH Directboot"; static void __init edd_put_string(u8 *dst, size_t n, const char *src) { @@ -271,20 +274,37 @@ static void __init noreturn efi_arch_post_exit_boot(void) : [cr3] "r" (idle_pg_table), [cs] "i" (__HYPERVISOR_CS), [ds] "r" (__HYPERVISOR_DS), - "D" (&mbi) + "D" (&efi_bi) : "memory" ); unreachable(); } -static void __init efi_arch_cfg_file_early(const EFI_LOADED_IMAGE *image, - EFI_FILE_HANDLE dir_handle, - const char *section) +static struct boot_info __init *efi_arch_bootinfo_init(void) { + int i; + + efi_bi.arch = &efi_bi_arch; + efi_bi.mods = efi_mods; + + for ( i=0; i <= MAX_NR_BOOTMODS; i++ ) + efi_bi.mods[i].arch = &efi_arch_mods[i]; + + efi_bi_arch.boot_loader_name = _p(efi_loader); + + efi_bi_arch.flags = BOOTINFO_FLAG_X86_MODULES | + BOOTINFO_FLAG_X86_LOADERNAME; + return &efi_bi; } -static void __init efi_arch_cfg_file_late(const EFI_LOADED_IMAGE *image, - EFI_FILE_HANDLE dir_handle, - const char *section) +static void __init efi_arch_cfg_file_early( + const EFI_LOADED_IMAGE *image, EFI_FILE_HANDLE dir_handle, + const char *section) +{ +} + +static void __init efi_arch_cfg_file_late( + const EFI_LOADED_IMAGE *image, EFI_FILE_HANDLE dir_handle, + const char *section) { union string name; @@ -296,16 +316,15 @@ static void __init efi_arch_cfg_file_late(const EFI_LOADED_IMAGE *image, name.s = get_value(&cfg, "global", "ucode"); if ( name.s ) { - microcode_set_module(mbi.mods_count); + microcode_set_module(efi_bi.nr_mods); split_string(name.s); read_file(dir_handle, s2w(&name), &ucode, NULL); efi_bs->FreePool(name.w); } } -static void __init efi_arch_handle_cmdline(CHAR16 *image_name, - CHAR16 *cmdline_options, - const char *cfgfile_options) +static void __init efi_arch_handle_cmdline( + CHAR16 *image_name, CHAR16 *cmdline_options, const char *cfgfile_options) { union string name; @@ -313,10 +332,10 @@ static void __init efi_arch_handle_cmdline(CHAR16 *image_name, { name.w = cmdline_options; w2s(&name); - place_string(&mbi.cmdline, name.s); + place_string((uint32_t *)efi_bi.cmdline, name.s); } if ( cfgfile_options ) - place_string(&mbi.cmdline, cfgfile_options); + place_string((uint32_t *)efi_bi.cmdline, cfgfile_options); /* Insert image name last, as it gets prefixed to the other options. */ if ( image_name ) { @@ -325,16 +344,10 @@ static void __init efi_arch_handle_cmdline(CHAR16 *image_name, } else name.s = "xen"; - place_string(&mbi.cmdline, name.s); + place_string((uint32_t *)efi_bi.cmdline, name.s); - if ( mbi.cmdline ) - mbi.flags |= MBI_CMDLINE; - /* - * These must not be initialized statically, since the value must - * not get relocated when processing base relocations later. - */ - mbi.boot_loader_name = (long)"EFI"; - mbi.mods_addr = (long)mb_modules; + if ( efi_bi.cmdline ) + efi_bi_arch.flags |= BOOTINFO_FLAG_X86_CMDLINE; } static void __init efi_arch_edd(void) @@ -704,9 +717,8 @@ static void __init efi_arch_memory_setup(void) #undef l2_4G_offset } -static void __init efi_arch_handle_module(const struct file *file, - const CHAR16 *name, - const char *options) +static void __init efi_arch_handle_module( + const struct file *file, const CHAR16 *name, const char *options) { union string local_name; void *ptr; @@ -724,17 +736,24 @@ static void __init efi_arch_handle_module(const struct file *file, w2s(&local_name); /* - * If options are provided, put them in - * mb_modules[mbi.mods_count].string after the filename, with a space - * separating them. place_string() prepends strings and adds separating - * spaces, so the call order is reversed. + * Set module string to filename and if options are provided, put them in + * after the filename, with a space separating them. */ + strlcpy(efi_bi.mods[efi_bi.nr_mods].string.bytes, local_name.s, + BOOTMOD_STRING_MAX_LEN); if ( options ) - place_string(&mb_modules[mbi.mods_count].string, options); - place_string(&mb_modules[mbi.mods_count].string, local_name.s); - mb_modules[mbi.mods_count].mod_start = file->addr >> PAGE_SHIFT; - mb_modules[mbi.mods_count].mod_end = file->size; - ++mbi.mods_count; + { + strlcat(efi_bi.mods[efi_bi.nr_mods].string.bytes, " ", + BOOTMOD_STRING_MAX_LEN); + strlcat(efi_bi.mods[efi_bi.nr_mods].string.bytes, options, + BOOTMOD_STRING_MAX_LEN); + } + + efi_bi.mods[efi_bi.nr_mods].start = file->addr; + efi_bi.mods[efi_bi.nr_mods].mfn = maddr_to_mfn(file->addr); + efi_bi.mods[efi_bi.nr_mods].size = file->size; + + ++efi_bi.nr_mods; efi_bs->FreePool(ptr); } diff --git a/xen/arch/x86/guest/xen/pvh-boot.c b/xen/arch/x86/guest/xen/pvh-boot.c index 1ed04d035c..dd10a358da 100644 --- a/xen/arch/x86/guest/xen/pvh-boot.c +++ b/xen/arch/x86/guest/xen/pvh-boot.c @@ -6,6 +6,7 @@ * * Copyright (c) 2017 Citrix Systems Ltd. */ +#include #include #include #include @@ -20,12 +21,28 @@ bool __initdata pvh_boot; uint32_t __initdata pvh_start_info_pa; -static multiboot_info_t __initdata pvh_mbi; -static module_t __initdata pvh_mbi_mods[8]; -static const char *__initdata pvh_loader = "PVH Directboot"; +static struct boot_info __initdata pvh_bi; +static struct arch_boot_info __initdata arch_pvh_bi; +static struct boot_module __initdata pvh_mods[MAX_NR_BOOTMODS + 1]; +static struct arch_bootmodule __initdata arch_pvh_mods[MAX_NR_BOOTMODS + 1]; +static char __initdata *pvh_loader = "PVH Directboot"; -static void __init convert_pvh_info(multiboot_info_t **mbi, - module_t **mod) +static struct boot_info __init *init_pvh_info(void) +{ + int i; + + pvh_bi.arch = &arch_pvh_bi; + pvh_bi.mods = pvh_mods; + + for ( i=0; i <= MAX_NR_BOOTMODS; i++ ) + pvh_bi.mods[i].arch = &arch_pvh_mods[i]; + + pvh_bi.arch->boot_loader_name = pvh_loader; + + return &pvh_bi; +} + +static void __init convert_pvh_info(struct boot_info *bi) { const struct hvm_start_info *pvh_info = __va(pvh_start_info_pa); const struct hvm_modlist_entry *entry; @@ -39,23 +56,22 @@ static void __init convert_pvh_info(multiboot_info_t **mbi, * required. The extra element is used to aid relocation. See * arch/x86/setup.c:__start_xen(). */ - if ( ARRAY_SIZE(pvh_mbi_mods) <= pvh_info->nr_modules ) + if ( ARRAY_SIZE(pvh_mods) <= pvh_info->nr_modules ) panic("The module array is too small, size %zu, requested %u\n", - ARRAY_SIZE(pvh_mbi_mods), pvh_info->nr_modules); + ARRAY_SIZE(pvh_mods), pvh_info->nr_modules); /* * Turn hvm_start_info into mbi. Luckily all modules are placed under 4GB * boundary on x86. */ - pvh_mbi.flags = MBI_CMDLINE | MBI_MODULES | MBI_LOADERNAME; + bi->arch->flags = BOOTINFO_FLAG_X86_CMDLINE | BOOTINFO_FLAG_X86_MODULES + | BOOTINFO_FLAG_X86_LOADERNAME; BUG_ON(pvh_info->cmdline_paddr >> 32); - pvh_mbi.cmdline = pvh_info->cmdline_paddr; - pvh_mbi.boot_loader_name = __pa(pvh_loader); + bi->cmdline = _p(__va(pvh_info->cmdline_paddr)); - BUG_ON(pvh_info->nr_modules >= ARRAY_SIZE(pvh_mbi_mods)); - pvh_mbi.mods_count = pvh_info->nr_modules; - pvh_mbi.mods_addr = __pa(pvh_mbi_mods); + BUG_ON(pvh_info->nr_modules >= ARRAY_SIZE(pvh_mods)); + bi->nr_mods = pvh_info->nr_modules; entry = __va(pvh_info->modlist_paddr); for ( i = 0; i < pvh_info->nr_modules; i++ ) @@ -63,15 +79,18 @@ static void __init convert_pvh_info(multiboot_info_t **mbi, BUG_ON(entry[i].paddr >> 32); BUG_ON(entry[i].cmdline_paddr >> 32); - pvh_mbi_mods[i].mod_start = entry[i].paddr; - pvh_mbi_mods[i].mod_end = entry[i].paddr + entry[i].size; - pvh_mbi_mods[i].string = entry[i].cmdline_paddr; + bi->mods[i].start = entry[i].paddr; + bi->mods[i].size = entry[i].size; + if ( entry[i].cmdline_paddr) + { + char *c = _p(__va(entry[i].cmdline_paddr)); + + safe_strcpy(bi->mods[i].string.bytes, c); + bi->mods[i].string.kind = BOOTSTR_CMDLINE; + } } rsdp_hint = pvh_info->rsdp_paddr; - - *mbi = &pvh_mbi; - *mod = pvh_mbi_mods; } static void __init get_memory_map(void) @@ -88,13 +107,16 @@ static void __init get_memory_map(void) sanitize_e820_map(e820_raw.map, &e820_raw.nr_map); } -void __init pvh_init(multiboot_info_t **mbi, module_t **mod) +void __init pvh_init(struct boot_info **bi) { - convert_pvh_info(mbi, mod); + *bi = init_pvh_info(); + convert_pvh_info(*bi); hypervisor_probe(); ASSERT(xen_guest); + (*bi)->arch->xen_guest = xen_guest; + get_memory_map(); } diff --git a/xen/arch/x86/include/asm/bootinfo.h b/xen/arch/x86/include/asm/bootinfo.h index 989fb7a1da..c1ed76fd3e 100644 --- a/xen/arch/x86/include/asm/bootinfo.h +++ b/xen/arch/x86/include/asm/bootinfo.h @@ -1,14 +1,14 @@ #ifndef __ARCH_X86_BOOTINFO_H__ #define __ARCH_X86_BOOTINFO_H__ -struct arch_bootmodule { +struct __packed arch_bootmodule { #define BOOTMOD_FLAG_X86_RELOCATED 1U << 0 uint32_t flags; unsigned headroom; }; DEFINE_STRUCT_PTR_TYPE(arch_bootmodule); -struct arch_boot_info { +struct __packed arch_boot_info { uint32_t flags; #define BOOTINFO_FLAG_X86_CMDLINE 1U << 2 #define BOOTINFO_FLAG_X86_MODULES 1U << 3 @@ -17,6 +17,9 @@ struct arch_boot_info { char_ptr_t boot_loader_name; + uint32_t mem_lower; + uint32_t mem_upper; + uint32_t mmap_length; paddr_t mmap_addr; }; diff --git a/xen/arch/x86/include/asm/guest/pvh-boot.h b/xen/arch/x86/include/asm/guest/pvh-boot.h index 247ba6899e..c820b0bf88 100644 --- a/xen/arch/x86/include/asm/guest/pvh-boot.h +++ b/xen/arch/x86/include/asm/guest/pvh-boot.h @@ -8,13 +8,13 @@ #ifndef __X86_PVH_BOOT_H__ #define __X86_PVH_BOOT_H__ -#include +#include #ifdef CONFIG_PVH_GUEST extern bool pvh_boot; -void pvh_init(multiboot_info_t **mbi, module_t **mod); +void __init pvh_init(struct boot_info **bi); void pvh_print_info(void); #else @@ -23,7 +23,7 @@ void pvh_print_info(void); #define pvh_boot 0 -static inline void pvh_init(multiboot_info_t **mbi, module_t **mod) +static inline void __init pvh_init(struct boot_info **bi) { ASSERT_UNREACHABLE(); } diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 50a1a124b0..05a76a5959 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -13,7 +13,6 @@ #include #include #include -#include #include #include #include @@ -60,9 +59,6 @@ #include #include -/* Max number of boot modules a bootloader can provide in addition to Xen */ -#define MAX_NR_BOOTMODS 63 - /* opt_nosmp: If true, secondary processors are ignored. */ static bool __initdata opt_nosmp; boolean_param("nosmp", opt_nosmp); @@ -275,46 +271,6 @@ custom_param("acpi", parse_acpi_param); static struct boot_info __initdata *boot_info; -static void __init multiboot_to_bootinfo(multiboot_info_t *mbi, module_t *mods) -{ - static struct boot_info __initdata info; - static struct arch_boot_info __initdata arch_info; - static struct boot_module __initdata boot_mods[MAX_NR_BOOTMODS + 1]; - static struct arch_bootmodule __initdata arch_boot_mods[ - MAX_NR_BOOTMODS + 1]; - - int i; - - info.arch = &arch_info; - info.mods = boot_mods; - - info.cmdline = __va(mbi->cmdline); - - /* The BOOTINFO_FLAG_X86_* flags are a 1-1 map to MBI_* */ - arch_info.flags = mbi->flags; - arch_info.mmap_length = mbi->mmap_length; - arch_info.mmap_addr = mbi->mmap_addr; - arch_info.boot_loader_name = __va(mbi->boot_loader_name); - - info.nr_mods = mbi->mods_count; - for ( i = 0; i <= MAX_NR_BOOTMODS; i++ ) - { - boot_mods[i].arch = &arch_boot_mods[i]; - - if ( i < info.nr_mods ) - { - bootmodule_update_start(&boot_mods[i], mods[i].mod_start); - boot_mods[i].size = mods[i].mod_end - mods[i].mod_start; - - boot_mods[i].string.len = strlcpy(boot_mods[i].string.bytes, - __va(mods[i].string), - BOOTMOD_STRING_MAX_LEN); - } - } - - boot_info = &info; -} - unsigned long __init initial_images_nrpages(nodeid_t node) { unsigned long node_start = node_start_pfn(node); @@ -1014,15 +970,13 @@ static struct domain *__init create_dom0(const struct boot_info *bootinfo, /* How much of the directmap is prebuilt at compile time. */ #define PREBUILT_MAP_LIMIT (1 << L2_PAGETABLE_SHIFT) -void __init noreturn __start_xen(unsigned long mbi_p) +void __init noreturn __start_xen(unsigned long bi_p) { char *memmap_type = NULL; char *cmdline, *kextra, *loader; void *bsp_stack; struct cpu_info *info = get_cpu_info(), *bsp_info; unsigned int initrdidx, num_parked = 0; - multiboot_info_t *mbi; - module_t *mod; unsigned long nr_pages, raw_max_page; int i, j, e820_warn = 0, bytes = 0; unsigned long eb_start, eb_end; @@ -1059,16 +1013,29 @@ void __init noreturn __start_xen(unsigned long mbi_p) if ( pvh_boot ) { - ASSERT(mbi_p == 0); - pvh_init(&mbi, &mod); + ASSERT(bi_p == 0); + pvh_init(&boot_info); } else { - mbi = __va(mbi_p); - mod = __va(mbi->mods_addr); - } + /* + * Since addresses were setup before virtual addressing was enabled, + * fixup pointers to virtual addresses for proper dereferencing. + */ + boot_info = __va(bi_p); + boot_info->cmdline = __va(boot_info->cmdline); + boot_info->mods = __va(boot_info->mods); + boot_info->arch = __va(boot_info->arch); + + boot_info->arch->boot_loader_name = + __va(boot_info->arch->boot_loader_name); - multiboot_to_bootinfo(mbi, mod); + for ( i = 0; i <= boot_info->nr_mods; i++ ) + { + boot_info->mods[i].mfn = maddr_to_mfn(boot_info->mods[i].start); + boot_info->mods[i].arch = __va(boot_info->mods[i].arch); + } + } loader = (boot_info->arch->flags & BOOTINFO_FLAG_X86_LOADERNAME) ? boot_info->arch->boot_loader_name : "unknown"; diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index c5850c26af..09b38b497c 100644 --- a/xen/common/efi/boot.c +++ b/xen/common/efi/boot.c @@ -3,6 +3,7 @@ #include #include #include +#include #include #include #include @@ -11,7 +12,6 @@ #include #include #include -#include #include #include #include @@ -1359,6 +1359,8 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable) efi_arch_relocate_image(0); + efi_arch_bootinfo_init(); + if ( use_cfg_file ) { EFI_FILE_HANDLE dir_handle; diff --git a/xen/include/xen/bootinfo.h b/xen/include/xen/bootinfo.h index bf5586a76b..6e09be6899 100644 --- a/xen/include/xen/bootinfo.h +++ b/xen/include/xen/bootinfo.h @@ -20,13 +20,16 @@ #define BOOTMOD_GUEST_DTB 7 typedef unsigned int bootmod_type_t; +/* Max number of boot modules a bootloader can provide in addition to Xen */ +#define MAX_NR_BOOTMODS 63 + #define BOOTMOD_STRING_MAX_LEN 1024 -struct boot_string { +struct __packed boot_string { char bytes[BOOTMOD_STRING_MAX_LEN]; size_t len; }; -struct boot_module { +struct __packed boot_module { bootmod_type_t bootmod_type; paddr_t start; mfn_t mfn; @@ -37,7 +40,7 @@ struct boot_module { }; DEFINE_STRUCT_PTR_TYPE(boot_module); -struct boot_info { +struct __packed boot_info { char_ptr_t cmdline; unsigned int nr_mods; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 01 01:41:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 01:41:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557721.871328 (Exim 4.92) (envelope-from ) id 1qFPbX-0003Qn-BL; Sat, 01 Jul 2023 01:40:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557721.871328; Sat, 01 Jul 2023 01:40:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFPbX-0003QY-5y; Sat, 01 Jul 2023 01:40:51 +0000 Received: by outflank-mailman (input) for mailman id 557721; Sat, 01 Jul 2023 01:40:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFPbV-0003QN-Nd for xen-devel@lists.xenproject.org; Sat, 01 Jul 2023 01:40:49 +0000 Received: from mail-yw1-x1131.google.com (mail-yw1-x1131.google.com [2607:f8b0:4864:20::1131]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4ae2aa5c-17b0-11ee-8611-37d641c3527e; Sat, 01 Jul 2023 03:40:44 +0200 (CEST) Received: by mail-yw1-x1131.google.com with SMTP id 00721157ae682-5774098f16eso16007677b3.0; Fri, 30 Jun 2023 18:40:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4ae2aa5c-17b0-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688175643; x=1690767643; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=SEcfA2Ww7HR2irnIpklXq/A9PNh1FXgpCio5YDgpl0U=; b=jmoC5J1PtFdizaR2gL+x54Pc91iCLqZ8hdq5oR6a0BMD4YBcqOaNGA6NpJDERb5ALb Rb9Inb1FabtHuAfAHQMZCVS8JbCo5Mbnq6OLVDB2oR470AN+BptAfa3jHkqE50ZDMUBm /f+hsTRgyfViphjjlmFOk04ZKWva+RhzsINsZpjXoTJUQSRQJZPbPCuealJJXgekH/Pu exiTwvUYAcSl7gVWl86WtSSgI+gbXOZhBocUYeEQ+vJJCDoO9roChlWvC/k4bUpWgIhq zIhUmGZutYzVTHFaXWDB6NWRm9CaG73UC8OgTeCpOKtdR6p/6Qq+l+uuXKekgEI7bR0N uYew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688175643; x=1690767643; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SEcfA2Ww7HR2irnIpklXq/A9PNh1FXgpCio5YDgpl0U=; b=ieL6Hiy/IeClq+oG2pspXDZGS7ADAhNSa1bxB5wiJbZMeto2olcZX1SlarfrVAyaaX lER0qw5CkDg/ZfSQS/l+6nkBGvySYrjrNMrTzuNy5o6mwo4gqqKow9iWkTZ8qC8kD9gv XQe2o5Qf8LZjqfHfhEjSMV3VVcsp9F1W0no8uQWILB87w6P7RpuoiXBasblOWCoj3781 fxiPjZ2I5H1Bx+Ax0x7Li+yOHEPVYZd8lfUW1DqvcYj1w8zMNmii+IQEwnTguCD83vxs CXj4pPLq7SPOMRJ6yJv/LThxzbUADOw0vShefBXUY8VYKWpAa8ZG8TWBzAntoxeOuODm Upxg== X-Gm-Message-State: ABy/qLaklvtHl131WEiQyk6LqIP4WypE334KBLVsxDZothD+VIUtYgRr LV+3AnsAqdPkwQMdpufvDIycMUBDGz9drYRXonjb1bX7064= X-Google-Smtp-Source: APBJJlHzZgRATzxdC7kGqhsaCy5jV5epnWTg0LUyCnbY/zCR2Fu7oouXEkzjgP2oVPJ5y25cl/JXVVnsrdtd2ycU4mM= X-Received: by 2002:a81:6646:0:b0:56d:8241:e067 with SMTP id a67-20020a816646000000b0056d8241e067mr3848423ywc.49.1688175642818; Fri, 30 Jun 2023 18:40:42 -0700 (PDT) MIME-Version: 1.0 References: <78899eac-9de8-3626-8f40-98f993984f95@xen.org> <1ef5a5a6-01ea-4f3f-c05f-7dfd204a1861@xen.org> <8bf66b4a-7f3b-22e0-6c09-c003ac972fe5@xen.org> In-Reply-To: <8bf66b4a-7f3b-22e0-6c09-c003ac972fe5@xen.org> From: Jiatong Shen Date: Sat, 1 Jul 2023 09:40:31 +0800 Message-ID: Subject: Re: Asking for help to debug xen efi on Kunpeng machine To: Julien Grall Cc: Stefano Stabellini , xen-users@lists.xenproject.org, xen-devel@lists.xenproject.org, bertrand.marquis@arm.com Content-Type: multipart/alternative; boundary="000000000000823df005ff6305e9" --000000000000823df005ff6305e9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Julien, Thank you for your answer. Do you have any advice on how to debug the issue? I have very little experience with xen so I think I still need debugging even if I can get MBI-gen's tech doc... Best regards, Jiatong Shen On Fri, Jun 30, 2023 at 5:42=E2=80=AFAM Julien Grall wrote= : > On 24/06/2023 15:54, Jiatong Shen wrote: > > Hello Julien, > > Hi, > > > Thank you very much for your reply. Can you teach me how to find th= e > > relationship between MBI-gen and devices? > > I am not sure how to find out the mbi-gen backed devices.. > > I am afraid I don't have any experience with the MBI-gen. I have also > looked at one Hisilicon Device-Tree but I don't know whether this is the > one for your board. > > My recommendation would be to check if there is any technical > documentation for your HW. > > Cheers, > > -- > Julien Grall > --=20 Best Regards, Jiatong Shen --000000000000823df005ff6305e9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Julien,

=C2=A0 =C2=A0Thank you= for your answer. Do you have any advice on how to debug the issue?
I have very little experience=C2=A0with xen so I think I still need debugg= ing=C2=A0even if I can
get MBI-gen's tech doc...
Best=C2=A0regards,
Jiatong Shen

On Fri, Jun 30,= 2023 at 5:42=E2=80=AFAM Julien Grall <julien@xen.org> wrote:
On 24/06/2023 15:54, Jiatong Shen wrote:
> Hello Julien,

Hi,

>=C2=A0 =C2=A0 =C2=A0Thank you very much for your reply. Can you teach m= e how to find the
> relationship between MBI-gen and devices?
> I am not sure how to find out the mbi-gen backed devices..

I am afraid I don't have any experience with the MBI-gen. I have also <= br> looked at one Hisilicon Device-Tree but I don't know whether this is th= e
one for your board.

My recommendation would be to check if there is any technical
documentation for your HW.

Cheers,

--
Julien Grall


--

Best Regards,

Jiatong Shen=
--000000000000823df005ff6305e9-- From xen-devel-bounces@lists.xenproject.org Sat Jul 01 03:14:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 03:14:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557751.871355 (Exim 4.92) (envelope-from ) id 1qFR3g-0005Ni-Gt; Sat, 01 Jul 2023 03:14:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557751.871355; Sat, 01 Jul 2023 03:14:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFR3g-0005Nb-Bw; Sat, 01 Jul 2023 03:14:00 +0000 Received: by outflank-mailman (input) for mailman id 557751; Sat, 01 Jul 2023 03:13:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFR3f-0005NR-Bl; Sat, 01 Jul 2023 03:13:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFR3f-0005Wf-45; Sat, 01 Jul 2023 03:13:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFR3e-0000Bf-P9; Sat, 01 Jul 2023 03:13:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qFR3e-0004nE-O0; Sat, 01 Jul 2023 03:13:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vY5qmLZUoyxIZ0Gstgj0u1AJVD/p7pvmZE4OJAUUtPk=; b=ORToBAYgVCK1OF0FYJsGx+04NN o+AgzihxlK+arhdUqztB+hUu3b55orEy8aV621I/NGbtOk6lhbVnnHodw8MaorgnNyPVE9tioPaBF lKRi9gY5ZnmNI3hRFyWrRUoR/JitsHC4LJuDXfjOrRUKlIdpLlrt76s7zqXu2CwIjXCE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 181657: regressions - FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-xsm:xen-install:fail:regression xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-libvirt:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=c81b287e00b1a21beb65637d9cfb812da3a0e5ce X-Osstest-Versions-That: xen=6aa0c18062609cb448d292668a81953a58ce1e95 From: osstest service owner Date: Sat, 01 Jul 2023 03:13:58 +0000 flight 181657 xen-unstable real [real] flight 181664 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/181657/ http://logs.test-lab.xenproject.org/osstest/logs/181664/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 181646 Tests which are failing intermittently (not blocking): test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail pass in 181664-retest test-amd64-i386-libvirt 7 xen-install fail pass in 181664-retest test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 181664-retest Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt 15 migrate-support-check fail in 181664 never pass test-armhf-armhf-libvirt 16 saverestore-support-check fail like 181646 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 181646 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 181646 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 181646 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 181646 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 181646 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 181646 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 181646 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 181646 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 181646 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 181646 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 181646 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen c81b287e00b1a21beb65637d9cfb812da3a0e5ce baseline version: xen 6aa0c18062609cb448d292668a81953a58ce1e95 Last test of basis 181646 2023-06-30 02:11:47 Z 1 days Testing same since 181657 2023-06-30 14:38:36 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD George Dunlap jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit c81b287e00b1a21beb65637d9cfb812da3a0e5ce Author: George Dunlap Date: Fri Jun 30 11:25:34 2023 +0100 xenalyze: Basic TRC_HVM_EMUL handling For now, mainly just do volume analysis and get rid of the warnings. Signed-off-by: George Dunlap Acked-by: Andrew Cooper Acked-by: Anthony PERARD commit aab4b38b5d77e3c65f44bacd56427a85b7392a11 Author: George Dunlap Date: Fri Jun 30 11:25:33 2023 +0100 xenalyze: Handle start-of-day ->RUNNING transitions A recent xentrace highlighted an unhandled corner case in the vcpu "start-of-day" logic, if the trace starts after the last running -> non-running transition, but before the first non-running -> running transition. Because start-of-day wasn't handled, vcpu_next_update() was expecting p->current to be NULL, and tripping out with the following error message when it wasn't: vcpu_next_update: FATAL: p->current not NULL! (d32768dv$p, runstate RUNSTATE_INIT) where 32768 is the DEFAULT_DOMAIN, and $p is the pcpu number. Instead of calling vcpu_start() piecemeal throughout sched_runstate_process(), call it at the top of the function if the vcpu in question is still in RUNSTATE_INIT, so that we can handle all the cases in one place. Sketch out at the top of the function all cases which we need to handle, and what to do in those cases. Some transitions tell us where v is running; some transitions tell us about what is (or is not) running on p; some transitions tell us neither. If a transition tells us where v is now running, update its state; otherwise leave it in INIT, in order to avoid having to deal with TSC skew on start-up. If a transition tells us what is or is not running on p, update p->current (either to v or NULL). Otherwise leave it alone. If neither, do nothing. Reifying those rules: - If we're continuing to run, set v to RUNNING, and use p->first_tsc as the runstate time. - If we're starting to run, set v to RUNNING, and use ri->tsc as the runstate time. - If v is being deschedled, leave v in the INIT state to avoid dealing with TSC skew; but set p->current to NULL so that whatever is scheduled next won't trigger the assert in vcpu_next_update(). - If a vcpu is waking up (switching from one non-runnable state to another non-runnable state), leave v in INIT, and p in whatever state it's in (which may be the default domain, or some other vcpu which has already run). While here, fix the comment above vcpu_start; it's called when the vcpu state is INIT, not when current is the default domain. Signed-off-by: George Dunlap Acked-by: Andrew Cooper Acked-by: Anthony PERARD (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Sat Jul 01 07:07:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 07:07:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557764.871380 (Exim 4.92) (envelope-from ) id 1qFUh0-0004oO-NE; Sat, 01 Jul 2023 07:06:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557764.871380; Sat, 01 Jul 2023 07:06:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFUh0-0004oH-Jq; Sat, 01 Jul 2023 07:06:50 +0000 Received: by outflank-mailman (input) for mailman id 557764; Sat, 01 Jul 2023 07:06:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFUh0-0004o7-3Y; Sat, 01 Jul 2023 07:06:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFUgz-0002yG-V6; Sat, 01 Jul 2023 07:06:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFUgz-0001qP-Ew; Sat, 01 Jul 2023 07:06:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qFUgz-0007hC-EQ; Sat, 01 Jul 2023 07:06:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=kv/ctAaDMTuN68uWg4eIc19VthvI8/12pft+lfhKVFo=; b=UQZSTNLEUYjUvKIqMRKfd7yRb0 budEi7xlJ4LG1q3DNRRO0jHWwCC8WcFiMLsfM1zCVb9+cwpXtORk9tyhpQ7pY+llUikPDwzRo+do2 1GCovQktGcWDALy9o5WCPPiyuRBfsv3pBBH9xHeNmej4g1SItkUIfjgC2emY3GLkmf08=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 181663: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-libvirt:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-credit2:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:debian-install:fail:regression linux-linus:test-amd64-amd64-xl:debian-install:fail:regression linux-linus:test-amd64-coresched-amd64-xl:debian-install:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:debian-di-install:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-vhd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:windows-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-examine:reboot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=6cdbb0907a3c562723455e351c940037bdec9b7a X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Sat, 01 Jul 2023 07:06:49 +0000 flight 181663 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/181663/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-credit1 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-libvirt 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-libvirt-qcow2 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-pvhv2-amd 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-ovmf-amd64 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-credit2 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-xsm 12 debian-install fail REGR. vs. 180278 test-amd64-amd64-xl 12 debian-install fail REGR. vs. 180278 test-amd64-coresched-amd64-xl 12 debian-install fail REGR. vs. 180278 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 180278 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 180278 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 180278 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 180278 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 180278 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-pygrub 12 debian-di-install fail REGR. vs. 180278 test-arm64-arm64-libvirt-raw 13 guest-start fail REGR. vs. 180278 test-arm64-arm64-xl-vhd 13 guest-start fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-ws16-amd64 12 windows-install fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 180278 test-amd64-amd64-examine 8 reboot fail REGR. vs. 180278 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 180278 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 180278 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-vhd 8 xen-boot fail like 180278 test-armhf-armhf-xl 8 xen-boot fail like 180278 test-armhf-armhf-xl-arndale 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-raw 8 xen-boot fail like 180278 test-armhf-armhf-xl-credit2 8 xen-boot fail like 180278 test-armhf-armhf-examine 8 reboot fail like 180278 test-armhf-armhf-libvirt 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail like 180278 test-armhf-armhf-xl-rtds 8 xen-boot fail like 180278 test-armhf-armhf-xl-multivcpu 8 xen-boot fail like 180278 test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: linux 6cdbb0907a3c562723455e351c940037bdec9b7a baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 75 days Failing since 180281 2023-04-17 06:24:36 Z 75 days 144 attempts Testing same since 181663 2023-06-30 21:43:24 Z 0 days 1 attempts ------------------------------------------------------------ 3501 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 559212 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jul 01 07:18:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 07:18:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557773.871420 (Exim 4.92) (envelope-from ) id 1qFUsj-00078X-La; Sat, 01 Jul 2023 07:18:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557773.871420; Sat, 01 Jul 2023 07:18:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFUsj-00077S-Go; Sat, 01 Jul 2023 07:18:57 +0000 Received: by outflank-mailman (input) for mailman id 557773; Sat, 01 Jul 2023 07:18:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFUsh-0006No-Hn for xen-devel@lists.xenproject.org; Sat, 01 Jul 2023 07:18:55 +0000 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [2607:f8b0:4864:20::435]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 885db715-17df-11ee-8611-37d641c3527e; Sat, 01 Jul 2023 09:18:53 +0200 (CEST) Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-666e6541c98so2162693b3a.2 for ; Sat, 01 Jul 2023 00:18:53 -0700 (PDT) Received: from cog-dev.home ([70.103.208.83]) by smtp.gmail.com with ESMTPSA id s19-20020aa78d53000000b00673e652985bsm4108866pfe.118.2023.07.01.00.18.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jul 2023 00:18:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 885db715-17df-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688195932; x=1690787932; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=VZN0HVDL3v266tIzCxp1Au3MTDvSJDRQFEKwXgYQOKg=; b=YpX7sawsKZYhNUkXDrP6r+4b0ejLipURz01felmUeInxxsFgxrRszTnLYke1My3tUF 07LH6tcTz2c2CX3LDds0yu7k5LeZO8mi3Xs1B8NEhbf5U8XuO713vF8UKegIVWbRGkPo tTagkO4t7k+a8h23i2OXydHe/qLeHvgvYpA+CqIkGzxMbpDy6e8B8DwvEyHV88NA+Nsj Q4BA1MovO51sb5uLAa5vKGi6o9qcZtZHNCDpjxPBBWlmzHA3R6NyeKfMwsWrzPEt/TJp j0nwnTCn+yOhFyHjujJ70n+JvuUyTED5o59t9ykYnNKsg0CxJZDewB8vVRxgmIuSnxjV s1pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688195932; x=1690787932; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VZN0HVDL3v266tIzCxp1Au3MTDvSJDRQFEKwXgYQOKg=; b=VubMhGoR5sLZvesgzl4NarPaQ/FN3m/9Ro3fsTcfH9VZIOAUaDfpAaTlMyzFdb4bUE jHTWLBJ+EglgrN+ywNYnHLZp/I1WUeeHwTaLPPQlE9qLZUBaeR7rPhnMptdQs5J9OP0I ctLwZP3wu4mNUj6XoieFG1OFBQKSypjbM1ATxcUMpPVmiqyWjQ0nfxzvH7HB0VHTA5ig lpjfJw07/b208Ihl+ooGo0RDN559iDHopA3OceklifHGVmdJN5e/Rn8DdczxfcUHZCrc 9gY7wQOTQp+4RWiEd66UzWXQ9i4ckRJZ2krAbS8RtiQ0VL0SGvsKvLP3VF5MWgi0gKcH V2Cw== X-Gm-Message-State: AC+VfDy+lc/itCuWmyEOHDFBaXpfU3u0BBxTctuPhW9LchB7LWG+ZGhv mHlWjBNg6/X+t4Tth3KTGWq2QnZYTaA= X-Google-Smtp-Source: ACHHUZ6n2a0BgJsHOuyBxhZoYcbAmTWwBgBp7Scj2tR+LuLllrO5p7qgwk+xteUe1+RZDeaLy+AScQ== X-Received: by 2002:a05:6a20:448:b0:126:a5e3:3938 with SMTP id b8-20020a056a20044800b00126a5e33938mr4329586pzb.19.1688195931673; Sat, 01 Jul 2023 00:18:51 -0700 (PDT) Sender: Christopher Clark From: Christopher Clark To: xen-devel@lists.xenproject.org Cc: Daniel Smith , stefano.stabellini@amd.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Luca Fancellu , Volodymyr Babchuk , Rich Persaud Subject: [PATCH 03/10] x86 setup: change bootstrap map to accept new boot module structures Date: Sat, 1 Jul 2023 00:18:28 -0700 Message-Id: <20230701071835.41599-4-christopher.w.clark@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230701071835.41599-1-christopher.w.clark@gmail.com> References: <20230701071835.41599-1-christopher.w.clark@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To convert the x86 boot logic from multiboot to boot module structures, change the bootstrap map function to accept a boot module parameter. To allow incremental change from multiboot to boot modules across all x86 setup logic, provide a temporary inline wrapper that still accepts a multiboot module parameter and use it where necessary. The wrapper is placed in a new arch/x86 header to avoid putting a static inline function into an existing header that has no such functions already. This new header will be expanded with additional functions in subsequent patches in this series. No functional change intended. Signed-off-by: Christopher Clark Signed-off-by: Daniel P. Smith --- A new patch so v1 series patch 3 can be implemented incrementally instead. xen/arch/x86/cpu/microcode/core.c | 7 ++++--- xen/arch/x86/hvm/dom0_build.c | 4 +++- xen/arch/x86/include/asm/boot.h | 32 +++++++++++++++++++++++++++++++ xen/arch/x86/include/asm/setup.h | 3 ++- xen/arch/x86/pv/dom0_build.c | 3 ++- xen/arch/x86/setup.c | 18 +++++++++-------- xen/include/xen/bootinfo.h | 3 +++ xen/xsm/xsm_policy.c | 3 ++- 8 files changed, 58 insertions(+), 15 deletions(-) create mode 100644 xen/arch/x86/include/asm/boot.h diff --git a/xen/arch/x86/cpu/microcode/core.c b/xen/arch/x86/cpu/microcode/core.c index c3fee62906..ce3c8042a2 100644 --- a/xen/arch/x86/cpu/microcode/core.c +++ b/xen/arch/x86/cpu/microcode/core.c @@ -34,6 +34,7 @@ #include #include +#include #include #include #include @@ -180,7 +181,7 @@ void __init microcode_scan_module( if ( !test_bit(i, module_map) ) continue; - _blob_start = bootstrap_map(&mod[i]); + _blob_start = bootstrap_map_multiboot(&mod[i]); _blob_size = mod[i].mod_end; if ( !_blob_start ) { @@ -798,7 +799,7 @@ int __init microcode_init_cache(unsigned long *module_map, microcode_scan_module(module_map, mbi); if ( ucode_mod.mod_end ) - rc = early_update_cache(bootstrap_map(&ucode_mod), + rc = early_update_cache(bootstrap_map_multiboot(&ucode_mod), ucode_mod.mod_end); else if ( ucode_blob.size ) rc = early_update_cache(ucode_blob.data, ucode_blob.size); @@ -821,7 +822,7 @@ static int __init early_microcode_update_cpu(void) else if ( ucode_mod.mod_end ) { len = ucode_mod.mod_end; - data = bootstrap_map(&ucode_mod); + data = bootstrap_map_multiboot(&ucode_mod); } if ( !data ) diff --git a/xen/arch/x86/hvm/dom0_build.c b/xen/arch/x86/hvm/dom0_build.c index bf08998862..56fe89632b 100644 --- a/xen/arch/x86/hvm/dom0_build.c +++ b/xen/arch/x86/hvm/dom0_build.c @@ -16,6 +16,7 @@ #include +#include #include #include #include @@ -1208,7 +1209,8 @@ int __init dom0_construct_pvh(struct domain *d, const module_t *image, return rc; } - rc = pvh_load_kernel(d, image, image_headroom, initrd, bootstrap_map(image), + rc = pvh_load_kernel(d, image, image_headroom, initrd, + bootstrap_map_multiboot(image), cmdline, &entry, &start_info); if ( rc ) { diff --git a/xen/arch/x86/include/asm/boot.h b/xen/arch/x86/include/asm/boot.h new file mode 100644 index 0000000000..10b17f12b2 --- /dev/null +++ b/xen/arch/x86/include/asm/boot.h @@ -0,0 +1,32 @@ +#ifndef __ASM_X86_BOOT_H__ +#define __ASM_X86_BOOT_H__ + +#include +#include + +#include + +static inline void *bootstrap_map_multiboot(const module_t *mod) +{ + struct boot_module bm; + + if ( !mod ) + return bootstrap_map(NULL); + + bm.start = mod->mod_start << PAGE_SHIFT; + bm.size = mod->mod_end; + + return bootstrap_map(&bm); +} + +#endif + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/x86/include/asm/setup.h b/xen/arch/x86/include/asm/setup.h index ae0dd3915a..80d0bb2a21 100644 --- a/xen/arch/x86/include/asm/setup.h +++ b/xen/arch/x86/include/asm/setup.h @@ -1,6 +1,7 @@ #ifndef __X86_SETUP_H_ #define __X86_SETUP_H_ +#include #include #include @@ -40,7 +41,7 @@ void setup_io_bitmap(struct domain *d); unsigned long initial_images_nrpages(nodeid_t node); void discard_initial_images(void); -void *bootstrap_map(const module_t *mod); +void *bootstrap_map(const struct boot_module *mod); int xen_in_range(unsigned long mfn); diff --git a/xen/arch/x86/pv/dom0_build.c b/xen/arch/x86/pv/dom0_build.c index 6ed9f8bbed..4fe806b60d 100644 --- a/xen/arch/x86/pv/dom0_build.c +++ b/xen/arch/x86/pv/dom0_build.c @@ -14,6 +14,7 @@ #include #include +#include #include #include #include @@ -374,7 +375,7 @@ int __init dom0_construct_pv(struct domain *d, unsigned int flush_flags = 0; start_info_t *si; struct vcpu *v = d->vcpu[0]; - void *image_base = bootstrap_map(image); + void *image_base = bootstrap_map_multiboot(image); unsigned long image_len = image->mod_end; void *image_start = image_base + image_headroom; unsigned long initrd_len = initrd ? initrd->mod_end : 0; diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index c0e8fc6ab7..3b623a4149 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -32,6 +32,7 @@ #include #endif #include +#include #include #include #include @@ -405,14 +406,14 @@ static void __init normalise_cpu_order(void) * Ensure a given physical memory range is present in the bootstrap mappings. * Use superpage mappings to ensure that pagetable memory needn't be allocated. */ -void *__init bootstrap_map(const module_t *mod) +void *__init bootstrap_map(const struct boot_module *mod) { static unsigned long __initdata map_cur = BOOTSTRAP_MAP_BASE; uint64_t start, end, mask = (1L << L2_PAGETABLE_SHIFT) - 1; void *ret; if ( system_state != SYS_STATE_early_boot ) - return mod ? mfn_to_virt(mod->mod_start) : NULL; + return mod ? maddr_to_virt(mod->start) : NULL; if ( !mod ) { @@ -421,8 +422,8 @@ void *__init bootstrap_map(const module_t *mod) return NULL; } - start = (uint64_t)mod->mod_start << PAGE_SHIFT; - end = start + mod->mod_end; + start = (uint64_t)mod->start; + end = start + mod->size; if ( start >= end ) return NULL; @@ -460,7 +461,7 @@ static void __init move_memory( if ( mod.mod_end > blksz ) mod.mod_end = blksz; sz = mod.mod_end - soffs; - s = bootstrap_map(&mod); + s = bootstrap_map_multiboot(&mod); mod.mod_start = (dst - doffs) >> PAGE_SHIFT; mod.mod_end = doffs + size; @@ -468,7 +469,7 @@ static void __init move_memory( mod.mod_end = blksz; if ( sz > mod.mod_end - doffs ) sz = mod.mod_end - doffs; - d = bootstrap_map(&mod); + d = bootstrap_map_multiboot(&mod); memmove(d + doffs, s + soffs, sz); @@ -1360,8 +1361,9 @@ void __init noreturn __start_xen(unsigned long mbi_p) mod[boot_info->nr_mods].mod_end = __2M_rwdata_end - _stext; } - boot_info->mods[0].arch->headroom = bzimage_headroom(bootstrap_map(mod), - mod->mod_end); + boot_info->mods[0].arch->headroom = + bzimage_headroom(bootstrap_map_multiboot(mod), mod->mod_end); + bootstrap_map(NULL); #ifndef highmem_start diff --git a/xen/include/xen/bootinfo.h b/xen/include/xen/bootinfo.h index b72ae31a66..eb93cc3439 100644 --- a/xen/include/xen/bootinfo.h +++ b/xen/include/xen/bootinfo.h @@ -10,6 +10,9 @@ #endif struct boot_module { + paddr_t start; + size_t size; + struct arch_bootmodule *arch; }; diff --git a/xen/xsm/xsm_policy.c b/xen/xsm/xsm_policy.c index 8dafbc9381..c6df8c6e06 100644 --- a/xen/xsm/xsm_policy.c +++ b/xen/xsm/xsm_policy.c @@ -20,6 +20,7 @@ #include #ifdef CONFIG_MULTIBOOT +#include #include #include #endif @@ -49,7 +50,7 @@ int __init xsm_multiboot_policy_init( if ( !test_bit(i, module_map) ) continue; - _policy_start = bootstrap_map(mod + i); + _policy_start = bootstrap_map_multiboot(mod + i); _policy_len = mod[i].mod_end; if ( (xsm_magic_t)(*_policy_start) == XSM_MAGIC ) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 01 07:18:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 07:18:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557770.871390 (Exim 4.92) (envelope-from ) id 1qFUsf-0006O8-Of; Sat, 01 Jul 2023 07:18:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557770.871390; Sat, 01 Jul 2023 07:18:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFUsf-0006O0-M3; Sat, 01 Jul 2023 07:18:53 +0000 Received: by outflank-mailman (input) for mailman id 557770; Sat, 01 Jul 2023 07:18:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFUse-0006No-R6 for xen-devel@lists.xenproject.org; Sat, 01 Jul 2023 07:18:52 +0000 Received: from mail-oo1-xc36.google.com (mail-oo1-xc36.google.com [2607:f8b0:4864:20::c36]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8623aaef-17df-11ee-8611-37d641c3527e; Sat, 01 Jul 2023 09:18:50 +0200 (CEST) Received: by mail-oo1-xc36.google.com with SMTP id 006d021491bc7-563531a3ad2so1819281eaf.3 for ; Sat, 01 Jul 2023 00:18:49 -0700 (PDT) Received: from cog-dev.home ([70.103.208.83]) by smtp.gmail.com with ESMTPSA id s19-20020aa78d53000000b00673e652985bsm4108866pfe.118.2023.07.01.00.18.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jul 2023 00:18:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 8623aaef-17df-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688195928; x=1690787928; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=ABSe8iUEZJrWKb2OGgC8wK/SkYDq99binlaKCeSYzIU=; b=lzDAWFNXAQOVO2xfQSt/4scS4ox7fLA2WYLopAAQyu/0x9yO3TMIKfYk1isEqBDxG+ zAZwPl4QnUrB5XT0dYkbbbSz+zED0N4B5iCihUu74p4q/XjU+aoHfhK850G7IB+idx5y ycwOGoGsq3FVMH2FD01k8IOjqq98IRDxRL1tHVPAAGPh1NSvERdyzwmbkouvbhA/iRfw hnXOITwbA9P9xf7wSZL8K4YRQAC+u+w/xzHF7C6SxOL9a9macuKeUxw94m6oBtkjjUpW XQNmpH5CeK7AVckC43dzWerbEmnvvmEUipEw26YuWX2ejnozPG48YDDmJA+Hi/qEpzmJ wyyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688195928; x=1690787928; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ABSe8iUEZJrWKb2OGgC8wK/SkYDq99binlaKCeSYzIU=; b=Rpx3z3PMqA3hp2gPh4zERRwV1plJGjSKzTWMKEhQ6iJoTJ0Yvis+7mQoh2Xr2BDx61 cjJbPIzwPWOKTxXuBkxvf0pyiYZluQ8PYozTBXuRktUZMrE55F3Zi4TL/EHgw9qQ1lNr YYwf1y06CUjK8LWbg8CKP+adqBGAQTsIUvDmUtVn5IvNh5KPnJI04xYhtSDxy3Qz/ZZB oPrXiu6RB7WFpqbtmCPwpqDku/gWvmKSWjfWv7Uy9HHni0Ol9PijYBJCnEEqwNuqnutr hqb0HlKf2wmgpq5P6CT+3yYoITwnpj9Rlb0yya2fgyxGFATMUNkU1y+DMi+yo0LzOIj6 L94w== X-Gm-Message-State: AC+VfDzCH0rM4vYNEVtgGXM2mWn+DRDlRqQpFc0nVTZb+ygZYOTU8zVI /P/K4/fv68qnc+FyXzp+RLZxWm6/X4s= X-Google-Smtp-Source: ACHHUZ7uNpUH3+0thdIcpaMcrhVT8/LT4Op1Q5q6vaj1qAHh+k3kW0aBcpmrEciR+eMfvZAes1MNNw== X-Received: by 2002:a05:6808:114d:b0:3a1:dfa0:7e18 with SMTP id u13-20020a056808114d00b003a1dfa07e18mr6835840oiu.25.1688195928151; Sat, 01 Jul 2023 00:18:48 -0700 (PDT) Sender: Christopher Clark From: Christopher Clark To: xen-devel@lists.xenproject.org Cc: Daniel Smith , stefano.stabellini@amd.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Luca Fancellu , Volodymyr Babchuk , Rich Persaud Subject: [PATCH 00/10] v3: Boot modules for Hyperlaunch Date: Sat, 1 Jul 2023 00:18:25 -0700 Message-Id: <20230701071835.41599-1-christopher.w.clark@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is a v3 series of work for Hyperlaunch for the Xen hypervisor, an update to v2 and implementing a subset of the v1 series and functionality, with changes made to address the community feedback provided on the patches. Changes since the earlier versions of the series are described below. The patches in this series are primarily derived from patches 2-4 of the v1 full series, in a series of smaller patches for ease of review. Thanks to AMD for supporting this work. Documentation on Hyperlaunch: https://wiki.xenproject.org/wiki/Hyperlaunch v1 Hyperlaunch patch series: https://lists.xenproject.org/archives/html/xen-devel/2022-07/msg00345.html thanks Christopher Changes since v2: - combined v2 patches 7 and 8 for common review - rebased the v2 series onto the current tip of staging (sorry) - fixed the placement of the patch changelogs - provided the changes description in the cover letter Changes since v1: - the v2 and v3 series implement functionality from v1 patches 2-4 - v2 series objective is to enable efficient patch review in support of merging the functionality into the hypervisor. It implements a subset of the v1 series, incorporating changes from community feedback. - the bootstrap map is made accessible early in the v2 series via both multiboot and boot module arguments until later in the series where multiboot use is retired. This allows for incremental conversion across several patches from multiboot to boot modules. - the 32-bit x86 boot environment header is removed, and changes are made to allow the new common bootinfo headers to be used instead. - Arm and RISC-V architecture bootinfo headers are added to ensure that builds on those architectures can complete correctly. - The KConfig patch to set the maximum number of boot modules allowed is not included in this series, replaced with a static maximum define. Christopher Clark (10): x86 setup: move x86 boot module counting into a new boot_info struct x86 setup: per-arch bootmodule structure, headroom field x86 setup: change bootstrap map to accept new boot module structures x86 setup: porting dom0 construction logic to boot module structures xsm: switch XSM init to boot info structures x86 setup, microcode: switch to the new bootinfo structures x86 boot: define paddr_t and add macros for typedefing struct pointers x86, arm, riscv: add per-arch bootinfo headers arm setup: use common integer-typed bootmod definition x86 setup: refactor efi, pvh and multiboot entrypoints to new boot info xen/arch/arm/efi/efi-boot.h | 6 + xen/arch/arm/include/asm/bootinfo.h | 20 ++ xen/arch/arm/include/asm/setup.h | 11 +- xen/arch/riscv/include/asm/bootinfo.h | 20 ++ xen/arch/x86/boot/defs.h | 10 + xen/arch/x86/boot/reloc.c | 192 ++++++++++++------ xen/arch/x86/bzimage.c | 10 +- xen/arch/x86/cpu/microcode/core.c | 149 ++++++++------ xen/arch/x86/dom0_build.c | 10 +- xen/arch/x86/efi/efi-boot.h | 95 +++++---- xen/arch/x86/guest/xen/pvh-boot.c | 65 ++++-- xen/arch/x86/hvm/dom0_build.c | 44 ++-- xen/arch/x86/include/asm/boot.h | 55 +++++ xen/arch/x86/include/asm/bootinfo.h | 47 +++++ xen/arch/x86/include/asm/bzimage.h | 2 +- xen/arch/x86/include/asm/dom0_build.h | 13 +- xen/arch/x86/include/asm/guest/pvh-boot.h | 6 +- xen/arch/x86/include/asm/microcode.h | 7 +- xen/arch/x86/include/asm/setup.h | 7 +- xen/arch/x86/pv/dom0_build.c | 32 +-- xen/arch/x86/setup.c | 232 ++++++++++++---------- xen/common/efi/boot.c | 4 +- xen/include/xen/bootinfo.h | 62 ++++++ xen/include/xen/types.h | 11 + xen/include/xsm/xsm.h | 28 +-- xen/xsm/xsm_core.c | 47 +++-- xen/xsm/xsm_policy.c | 58 +++--- 27 files changed, 821 insertions(+), 422 deletions(-) create mode 100644 xen/arch/arm/include/asm/bootinfo.h create mode 100644 xen/arch/riscv/include/asm/bootinfo.h create mode 100644 xen/arch/x86/include/asm/boot.h create mode 100644 xen/arch/x86/include/asm/bootinfo.h create mode 100644 xen/include/xen/bootinfo.h -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 01 07:18:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 07:18:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557771.871399 (Exim 4.92) (envelope-from ) id 1qFUsg-0006cx-Va; Sat, 01 Jul 2023 07:18:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557771.871399; Sat, 01 Jul 2023 07:18:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFUsg-0006cq-T3; Sat, 01 Jul 2023 07:18:54 +0000 Received: by outflank-mailman (input) for mailman id 557771; Sat, 01 Jul 2023 07:18:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFUsf-0006No-Gx for xen-devel@lists.xenproject.org; Sat, 01 Jul 2023 07:18:53 +0000 Received: from mail-oi1-x22e.google.com (mail-oi1-x22e.google.com [2607:f8b0:4864:20::22e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 86e20dce-17df-11ee-8611-37d641c3527e; Sat, 01 Jul 2023 09:18:51 +0200 (CEST) Received: by mail-oi1-x22e.google.com with SMTP id 5614622812f47-3a1d9b64837so2114109b6e.0 for ; Sat, 01 Jul 2023 00:18:51 -0700 (PDT) Received: from cog-dev.home ([70.103.208.83]) by smtp.gmail.com with ESMTPSA id s19-20020aa78d53000000b00673e652985bsm4108866pfe.118.2023.07.01.00.18.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jul 2023 00:18:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 86e20dce-17df-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688195929; x=1690787929; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=4c9WAF4kmb19tJcbTDjvohxu3kd3fgp5qdmTKmSCTJE=; b=CrY0CL1mRL0QPuwcnmaQkblnBE5P1R9sxQMKRcx7enujbSgBR6HAPycMDb2gS1AY4c GSMdg9Ho2X7dHe+o+SmkXoOa4APm8vLJjz8ed+7vxoyBsabHF/6zFJRtNNnBW4mZqgs0 /Kh9Zwyvg3GVC2GvbUXvWfC+Zl6imp1Dt83c7Gz7W64GM7H2PsLp9Qawd4CWiMdGbfJ+ 4ZpLlj4Ud3KBQNyr/lOBs7ci3hfKCUjakzYDIIoGJTg8cCPtn9eEPJMUhg1WXlHQsVCH 55FvRh0m8bfNjA2aTWhCErJlfX/ZnGxZaK4J45t8b1wnqNp9Gr9qRZ6PvA6RDY+LPK40 MFzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688195929; x=1690787929; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4c9WAF4kmb19tJcbTDjvohxu3kd3fgp5qdmTKmSCTJE=; b=SR70FPibjtK197iqGpuAocUm0X2cDizdg/b5smcuB/qjgWHuBK4bf5+aS2eY0Lylm+ tiJArrRTZpqAyauRqBFksKgcXP+gaI7OqOvuG5Gc7tqdP+utbVkifE3QwEuDA0ENiT9c 1sLdARp4psY5vz14g6eXO0L3YFG13DaQHt887/9OqaoFEZqbRQo80OgXw24onADATt7G Bx7eZjln+wMmetrJJ0ovP86NDofQ+2C8LG1JBqVthUBx7VPhiW6ZHuF4uS/QkVG9r95F qgO5o6RfCW4pNvMc5+iqN1E9zKj0dbGez4k5Upe5hoCB7aMjeyna7+qF1TCknygWHq2n pjJw== X-Gm-Message-State: AC+VfDyiX59a5d3b9UJhgPXVnpUgr2rMyZxbvCcIP9j1ob5yiDOH8HQ5 HFYikFMPxGKhnj1eONz4J7MPV9m1Cyc= X-Google-Smtp-Source: ACHHUZ5mpapv9SYTUsV6xBXMbudnVg/NReuMAxR+qtoCnfL+g9iPwcEvsPkpPiGylED5la1TTi9fsw== X-Received: by 2002:a05:6808:1b0c:b0:3a1:b309:a409 with SMTP id bx12-20020a0568081b0c00b003a1b309a409mr6482050oib.4.1688195929359; Sat, 01 Jul 2023 00:18:49 -0700 (PDT) Sender: Christopher Clark From: Christopher Clark To: xen-devel@lists.xenproject.org Cc: Daniel Smith , stefano.stabellini@amd.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Luca Fancellu , Volodymyr Babchuk , Rich Persaud Subject: [PATCH 01/10] x86 setup: move x86 boot module counting into a new boot_info struct Date: Sat, 1 Jul 2023 00:18:26 -0700 Message-Id: <20230701071835.41599-2-christopher.w.clark@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230701071835.41599-1-christopher.w.clark@gmail.com> References: <20230701071835.41599-1-christopher.w.clark@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit An initial step towards a non-multiboot internal representation of boot modules for common code, starting with x86 setup and converting the fields that are accessed for the startup calculations. Introduce a new header, , and populate it with a new boot_info structure initially containing a count of the number of boot modules. The naming of the header, structure and fields is intended to respect the boot structures on Arm -- see arm/include/asm/setup.h -- as part of work towards aligning common architecture-neutral boot logic and structures. No functional change intended. Signed-off-by: Christopher Clark Signed-off-by: Daniel P. Smith --- Changes since v1: patch is a subset of v1 series patches 2 and 3. xen/arch/x86/setup.c | 58 +++++++++++++++++++++++--------------- xen/include/xen/bootinfo.h | 20 +++++++++++++ 2 files changed, 55 insertions(+), 23 deletions(-) create mode 100644 xen/include/xen/bootinfo.h diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 74e3915a4d..708639b236 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -1,3 +1,4 @@ +#include #include #include #include @@ -268,7 +269,16 @@ static int __init cf_check parse_acpi_param(const char *s) custom_param("acpi", parse_acpi_param); static const module_t *__initdata initial_images; -static unsigned int __initdata nr_initial_images; +static struct boot_info __initdata *boot_info; + +static void __init multiboot_to_bootinfo(multiboot_info_t *mbi) +{ + static struct boot_info __initdata info; + + info.nr_mods = mbi->mods_count; + + boot_info = &info; +} unsigned long __init initial_images_nrpages(nodeid_t node) { @@ -277,7 +287,7 @@ unsigned long __init initial_images_nrpages(nodeid_t node) unsigned long nr; unsigned int i; - for ( nr = i = 0; i < nr_initial_images; ++i ) + for ( nr = i = 0; i < boot_info->nr_mods; ++i ) { unsigned long start = initial_images[i].mod_start; unsigned long end = start + PFN_UP(initial_images[i].mod_end); @@ -293,7 +303,7 @@ void __init discard_initial_images(void) { unsigned int i; - for ( i = 0; i < nr_initial_images; ++i ) + for ( i = 0; i < boot_info->nr_mods; ++i ) { uint64_t start = (uint64_t)initial_images[i].mod_start << PAGE_SHIFT; @@ -301,7 +311,7 @@ void __init discard_initial_images(void) start + PAGE_ALIGN(initial_images[i].mod_end)); } - nr_initial_images = 0; + boot_info->nr_mods = 0; initial_images = NULL; } @@ -1020,6 +1030,8 @@ void __init noreturn __start_xen(unsigned long mbi_p) mod = __va(mbi->mods_addr); } + multiboot_to_bootinfo(mbi); + loader = (mbi->flags & MBI_LOADERNAME) ? (char *)__va(mbi->boot_loader_name) : "unknown"; @@ -1127,18 +1139,18 @@ void __init noreturn __start_xen(unsigned long mbi_p) bootsym(boot_edd_info_nr)); /* Check that we have at least one Multiboot module. */ - if ( !(mbi->flags & MBI_MODULES) || (mbi->mods_count == 0) ) + if ( !(mbi->flags & MBI_MODULES) || (boot_info->nr_mods == 0) ) panic("dom0 kernel not specified. Check bootloader configuration\n"); /* Check that we don't have a silly number of modules. */ - if ( mbi->mods_count > sizeof(module_map) * 8 ) + if ( boot_info->nr_mods > sizeof(module_map) * 8 ) { - mbi->mods_count = sizeof(module_map) * 8; + boot_info->nr_mods = sizeof(module_map) * 8; printk("Excessive multiboot modules - using the first %u only\n", - mbi->mods_count); + boot_info->nr_mods); } - bitmap_fill(module_map, mbi->mods_count); + bitmap_fill(module_map, boot_info->nr_mods); __clear_bit(0, module_map); /* Dom0 kernel is always first */ if ( pvh_boot ) @@ -1311,9 +1323,9 @@ void __init noreturn __start_xen(unsigned long mbi_p) kexec_reserve_area(&boot_e820); initial_images = mod; - nr_initial_images = mbi->mods_count; + boot_info->nr_mods = boot_info->nr_mods; - for ( i = 0; !efi_enabled(EFI_LOADER) && i < mbi->mods_count; i++ ) + for ( i = 0; !efi_enabled(EFI_LOADER) && i < boot_info->nr_mods; i++ ) { if ( mod[i].mod_start & (PAGE_SIZE - 1) ) panic("Bootloader didn't honor module alignment request\n"); @@ -1337,8 +1349,8 @@ void __init noreturn __start_xen(unsigned long mbi_p) * respective reserve_e820_ram() invocation below. No need to * query efi_boot_mem_unused() here, though. */ - mod[mbi->mods_count].mod_start = virt_to_mfn(_stext); - mod[mbi->mods_count].mod_end = __2M_rwdata_end - _stext; + mod[boot_info->nr_mods].mod_start = virt_to_mfn(_stext); + mod[boot_info->nr_mods].mod_end = __2M_rwdata_end - _stext; } modules_headroom = bzimage_headroom(bootstrap_map(mod), mod->mod_end); @@ -1398,7 +1410,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) { /* Don't overlap with modules. */ end = consider_modules(s, e, reloc_size + mask, - mod, mbi->mods_count, -1); + mod, boot_info->nr_mods, -1); end &= ~mask; } else @@ -1419,7 +1431,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) } /* Is the region suitable for relocating the multiboot modules? */ - for ( j = mbi->mods_count - 1; j >= 0; j-- ) + for ( j = boot_info->nr_mods - 1; j >= 0; j-- ) { unsigned long headroom = j ? 0 : modules_headroom; unsigned long size = PAGE_ALIGN(headroom + mod[j].mod_end); @@ -1429,7 +1441,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) /* Don't overlap with other modules (or Xen itself). */ end = consider_modules(s, e, size, mod, - mbi->mods_count + relocated, j); + boot_info->nr_mods + relocated, j); if ( highmem_start && end > highmem_start ) continue; @@ -1456,7 +1468,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) { /* Don't overlap with modules (or Xen itself). */ e = consider_modules(s, e, PAGE_ALIGN(kexec_crash_area.size), mod, - mbi->mods_count + relocated, -1); + boot_info->nr_mods + relocated, -1); if ( s >= e ) break; if ( e > kexec_crash_area_limit ) @@ -1471,7 +1483,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) if ( modules_headroom && !mod->reserved ) panic("Not enough memory to relocate the dom0 kernel image\n"); - for ( i = 0; i < mbi->mods_count; ++i ) + for ( i = 0; i < boot_info->nr_mods; ++i ) { uint64_t s = (uint64_t)mod[i].mod_start << PAGE_SHIFT; @@ -1540,7 +1552,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) ASSERT(j); } map_e = boot_e820.map[j].addr + boot_e820.map[j].size; - for ( j = 0; j < mbi->mods_count; ++j ) + for ( j = 0; j < boot_info->nr_mods; ++j ) { uint64_t end = pfn_to_paddr(mod[j].mod_start) + mod[j].mod_end; @@ -1616,7 +1628,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) } } - for ( i = 0; i < mbi->mods_count; ++i ) + for ( i = 0; i < boot_info->nr_mods; ++i ) { set_pdx_range(mod[i].mod_start, mod[i].mod_start + PFN_UP(mod[i].mod_end)); @@ -1999,8 +2011,8 @@ void __init noreturn __start_xen(unsigned long mbi_p) cpu_has_nx ? XENLOG_INFO : XENLOG_WARNING "Warning: ", cpu_has_nx ? "" : "not "); - initrdidx = find_first_bit(module_map, mbi->mods_count); - if ( bitmap_weight(module_map, mbi->mods_count) > 1 ) + initrdidx = find_first_bit(module_map, boot_info->nr_mods); + if ( bitmap_weight(module_map, boot_info->nr_mods) > 1 ) printk(XENLOG_WARNING "Multiple initrd candidates, picking module #%u\n", initrdidx); @@ -2010,7 +2022,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) * above our heap. The second module, if present, is an initrd ramdisk. */ dom0 = create_dom0(mod, modules_headroom, - initrdidx < mbi->mods_count ? mod + initrdidx : NULL, + initrdidx < boot_info->nr_mods ? mod + initrdidx : NULL, kextra, loader); if ( !dom0 ) panic("Could not set up DOM0 guest OS\n"); diff --git a/xen/include/xen/bootinfo.h b/xen/include/xen/bootinfo.h new file mode 100644 index 0000000000..6a7d55d20e --- /dev/null +++ b/xen/include/xen/bootinfo.h @@ -0,0 +1,20 @@ +#ifndef __XEN_BOOTINFO_H__ +#define __XEN_BOOTINFO_H__ + +#include + +struct boot_info { + unsigned int nr_mods; +}; + +#endif + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 01 07:18:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 07:18:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557772.871410 (Exim 4.92) (envelope-from ) id 1qFUsi-0006sV-Cc; Sat, 01 Jul 2023 07:18:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557772.871410; Sat, 01 Jul 2023 07:18:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFUsi-0006sI-9F; Sat, 01 Jul 2023 07:18:56 +0000 Received: by outflank-mailman (input) for mailman id 557772; Sat, 01 Jul 2023 07:18:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFUsg-0006No-Gx for xen-devel@lists.xenproject.org; Sat, 01 Jul 2023 07:18:54 +0000 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [2607:f8b0:4864:20::434]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 87ad859c-17df-11ee-8611-37d641c3527e; Sat, 01 Jul 2023 09:18:52 +0200 (CEST) Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-6687446eaccso2060682b3a.3 for ; Sat, 01 Jul 2023 00:18:52 -0700 (PDT) Received: from cog-dev.home ([70.103.208.83]) by smtp.gmail.com with ESMTPSA id s19-20020aa78d53000000b00673e652985bsm4108866pfe.118.2023.07.01.00.18.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jul 2023 00:18:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 87ad859c-17df-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688195930; x=1690787930; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=Y6HSin/PPuTe3wUBWgklxdNFxDnMlcE+0e39paE0fXc=; b=rsJIkClYspba3EEC1R7kK3NAtOk5jq9qbQKs6V3a1+OyaOU9EdE4lyaLRwCxYjjR5y waqpW/joeTxkdrxBi10PoK/AZjaG5MFU0TAC4LNcWBKn/PdHFbpAAomjyxPEv6v8d6Wc My/L3c/7RcgdXVx8B4gdBlsXxc3Kyv5vQA3JMgm+XixOc9HLxFkHCAmkV/0cvQs3bmfF deiblMs2mJRWQ7elSOZskM4iJObW2t7Xd8DwX7/zQtYw3KUtyw9NnAup3AVYAzNlHXKQ eX9C1FZmaQKqFUMAAfRY08tDeXn8UUqcTPaQmf6U/vydMK1vxc+SUhlED09efS3rWVsM a/eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688195930; x=1690787930; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Y6HSin/PPuTe3wUBWgklxdNFxDnMlcE+0e39paE0fXc=; b=E/UuqHWhozUqX7eS/KnX0J7d5LjhTtQfG+MHTtD8xQpvICPYsOrN1EjbdotvgZFLyz frB2sMfEr5L896R7go33msGrw2Ge4XJuGZ18nC4f98Ft66gDNEEaSzS4+33ziKhRaeQd VOFonzS0pHphu3y8JY/LwKX8cOzMtBZnFR59HmVCLUCIZ2fydoGyjtOTkXuYe38K9KHS qco0w9MHe5vpG/KckdRI935qgkRXpCj+5IXCw3gGXAeki2SS5By/lSiMMqg/IlDWMFiI Rr9tp1YMgWZ4lYA9zQ37X+fChUb0jFWPOhxO9ZSqYUifEkmtyh5gjRxveh+/WvO01/cp MSVw== X-Gm-Message-State: ABy/qLaSAYxV1Qs7XMUcnRwz34tjvR57xcLzRBH1GF7b887T4SWpT/5K p6R4uNAq1WxwJi6vi6xuYmZm2seU060= X-Google-Smtp-Source: APBJJlGazLVsxb16uFiIRgEsb22Vr4uL3fUVX8OBI0LxxvRLHfsnva3PurQ+L5rtOrS/CANPnVhzgw== X-Received: by 2002:a05:6a00:24c9:b0:682:37be:c9fe with SMTP id d9-20020a056a0024c900b0068237bec9femr6300448pfv.10.1688195930443; Sat, 01 Jul 2023 00:18:50 -0700 (PDT) Sender: Christopher Clark From: Christopher Clark To: xen-devel@lists.xenproject.org Cc: Daniel Smith , stefano.stabellini@amd.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Luca Fancellu , Volodymyr Babchuk , Rich Persaud Subject: [PATCH 02/10] x86 setup: per-arch bootmodule structure, headroom field Date: Sat, 1 Jul 2023 00:18:27 -0700 Message-Id: <20230701071835.41599-3-christopher.w.clark@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230701071835.41599-1-christopher.w.clark@gmail.com> References: <20230701071835.41599-1-christopher.w.clark@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Next step in incremental work towards adding a non-multiboot internal representation of boot modules, converting the fields being accessed for the startup calculations. Add a new array of structs for per-boot-module state, though only allocate space for a single array entry in this change since that is all that is required for functionality modified in this patch: moving the headroom field for the image decompression calculation into a new per-arch boot module struct and then using it in x86 dom0 construction. Introduces a per-arch header for x86 for arch-specific boot module structures, and add a member to the common boot module structure for access to it. No functional change intended. Signed-off-by: Christopher Clark Signed-off-by: Daniel P. Smith --- Changes since v1: patch is a subset of v1 series patches 2 and 3. xen/arch/x86/bzimage.c | 10 +++++----- xen/arch/x86/hvm/dom0_build.c | 3 ++- xen/arch/x86/include/asm/bootinfo.h | 18 ++++++++++++++++++ xen/arch/x86/include/asm/bzimage.h | 2 +- xen/arch/x86/pv/dom0_build.c | 3 ++- xen/arch/x86/setup.c | 23 ++++++++++++++++------- xen/include/xen/bootinfo.h | 11 +++++++++++ 7 files changed, 55 insertions(+), 15 deletions(-) create mode 100644 xen/arch/x86/include/asm/bootinfo.h diff --git a/xen/arch/x86/bzimage.c b/xen/arch/x86/bzimage.c index ac4fd428be..dac2399b89 100644 --- a/xen/arch/x86/bzimage.c +++ b/xen/arch/x86/bzimage.c @@ -69,8 +69,6 @@ static __init int bzimage_check(struct setup_header *hdr, unsigned long len) return 1; } -static unsigned long __initdata orig_image_len; - unsigned long __init bzimage_headroom(void *image_start, unsigned long image_length) { @@ -91,7 +89,6 @@ unsigned long __init bzimage_headroom(void *image_start, if ( elf_is_elfbinary(image_start, image_length) ) return 0; - orig_image_len = image_length; headroom = output_length(image_start, image_length); if (gzip_check(image_start, image_length)) { @@ -105,11 +102,14 @@ unsigned long __init bzimage_headroom(void *image_start, } int __init bzimage_parse(void *image_base, void **image_start, + unsigned int headroom, unsigned long *image_len) { struct setup_header *hdr = (struct setup_header *)(*image_start); int err = bzimage_check(hdr, *image_len); - unsigned long output_len; + unsigned long output_len, orig_image_len; + + orig_image_len = *image_len - headroom; if ( err < 0 ) return err; @@ -125,7 +125,7 @@ int __init bzimage_parse(void *image_base, void **image_start, BUG_ON(!(image_base < *image_start)); - output_len = output_length(*image_start, orig_image_len); + output_len = output_length(*image_start, *image_len); if ( (err = perform_gunzip(image_base, *image_start, orig_image_len)) > 0 ) err = decompress(*image_start, orig_image_len, image_base); diff --git a/xen/arch/x86/hvm/dom0_build.c b/xen/arch/x86/hvm/dom0_build.c index fd2cbf68bc..bf08998862 100644 --- a/xen/arch/x86/hvm/dom0_build.c +++ b/xen/arch/x86/hvm/dom0_build.c @@ -545,7 +545,8 @@ static int __init pvh_load_kernel(struct domain *d, const module_t *image, struct vcpu *v = d->vcpu[0]; int rc; - if ( (rc = bzimage_parse(image_base, &image_start, &image_len)) != 0 ) + if ( (rc = bzimage_parse(image_base, &image_start, image_headroom, + &image_len)) != 0 ) { printk("Error trying to detect bz compressed kernel\n"); return rc; diff --git a/xen/arch/x86/include/asm/bootinfo.h b/xen/arch/x86/include/asm/bootinfo.h new file mode 100644 index 0000000000..a25054f372 --- /dev/null +++ b/xen/arch/x86/include/asm/bootinfo.h @@ -0,0 +1,18 @@ +#ifndef __ARCH_X86_BOOTINFO_H__ +#define __ARCH_X86_BOOTINFO_H__ + +struct arch_bootmodule { + unsigned headroom; +}; + +#endif + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/x86/include/asm/bzimage.h b/xen/arch/x86/include/asm/bzimage.h index 7ed69d3910..dd784f32ef 100644 --- a/xen/arch/x86/include/asm/bzimage.h +++ b/xen/arch/x86/include/asm/bzimage.h @@ -5,7 +5,7 @@ unsigned long bzimage_headroom(void *image_start, unsigned long image_length); -int bzimage_parse(void *image_base, void **image_start, +int bzimage_parse(void *image_base, void **image_start, unsigned int headroom, unsigned long *image_len); #endif /* __X86_BZIMAGE_H__ */ diff --git a/xen/arch/x86/pv/dom0_build.c b/xen/arch/x86/pv/dom0_build.c index c99135a552..6ed9f8bbed 100644 --- a/xen/arch/x86/pv/dom0_build.c +++ b/xen/arch/x86/pv/dom0_build.c @@ -416,7 +416,8 @@ int __init dom0_construct_pv(struct domain *d, d->max_pages = ~0U; - if ( (rc = bzimage_parse(image_base, &image_start, &image_len)) != 0 ) + if ( (rc = bzimage_parse(image_base, &image_start, image_headroom, + &image_len)) != 0 ) return rc; if ( (rc = elf_init(&elf, image_start, image_len)) != 0 ) diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 708639b236..c0e8fc6ab7 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -273,10 +273,16 @@ static struct boot_info __initdata *boot_info; static void __init multiboot_to_bootinfo(multiboot_info_t *mbi) { - static struct boot_info __initdata info; + static struct boot_info __initdata info; + static struct boot_module __initdata boot_mods[1]; + static struct arch_bootmodule __initdata arch_boot_mods[1]; + + info.mods = boot_mods; info.nr_mods = mbi->mods_count; + boot_mods[0].arch = &arch_boot_mods[0]; + boot_info = &info; } @@ -961,7 +967,8 @@ static struct domain *__init create_dom0(const module_t *image, write_cr4(read_cr4() & ~X86_CR4_SMAP); } - if ( construct_dom0(d, image, headroom, initrd, cmdline) != 0 ) + if ( construct_dom0(d, image, boot_info->mods[0].arch->headroom, initrd, + cmdline) != 0 ) panic("Could not construct domain 0\n"); if ( cpu_has_smap ) @@ -985,7 +992,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) unsigned int initrdidx, num_parked = 0; multiboot_info_t *mbi; module_t *mod; - unsigned long nr_pages, raw_max_page, modules_headroom, module_map[1]; + unsigned long nr_pages, raw_max_page, module_map[1]; int i, j, e820_warn = 0, bytes = 0; unsigned long eb_start, eb_end; bool acpi_boot_table_init_done = false, relocated = false; @@ -1353,7 +1360,8 @@ void __init noreturn __start_xen(unsigned long mbi_p) mod[boot_info->nr_mods].mod_end = __2M_rwdata_end - _stext; } - modules_headroom = bzimage_headroom(bootstrap_map(mod), mod->mod_end); + boot_info->mods[0].arch->headroom = bzimage_headroom(bootstrap_map(mod), + mod->mod_end); bootstrap_map(NULL); #ifndef highmem_start @@ -1433,7 +1441,8 @@ void __init noreturn __start_xen(unsigned long mbi_p) /* Is the region suitable for relocating the multiboot modules? */ for ( j = boot_info->nr_mods - 1; j >= 0; j-- ) { - unsigned long headroom = j ? 0 : modules_headroom; + struct boot_module *boot_mods = boot_info->mods; + unsigned long headroom = j ? 0 : boot_mods[0].arch->headroom; unsigned long size = PAGE_ALIGN(headroom + mod[j].mod_end); if ( mod[j].reserved ) @@ -1481,7 +1490,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) #endif } - if ( modules_headroom && !mod->reserved ) + if ( boot_info->mods[0].arch->headroom && !mod->reserved ) panic("Not enough memory to relocate the dom0 kernel image\n"); for ( i = 0; i < boot_info->nr_mods; ++i ) { @@ -2021,7 +2030,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) * We're going to setup domain0 using the module(s) that we stashed safely * above our heap. The second module, if present, is an initrd ramdisk. */ - dom0 = create_dom0(mod, modules_headroom, + dom0 = create_dom0(mod, boot_info->mods[0].arch->headroom, initrdidx < boot_info->nr_mods ? mod + initrdidx : NULL, kextra, loader); if ( !dom0 ) diff --git a/xen/include/xen/bootinfo.h b/xen/include/xen/bootinfo.h index 6a7d55d20e..b72ae31a66 100644 --- a/xen/include/xen/bootinfo.h +++ b/xen/include/xen/bootinfo.h @@ -3,8 +3,19 @@ #include +#ifdef CONFIG_X86 +#include +#else + struct arch_bootmodule { }; +#endif + +struct boot_module { + struct arch_bootmodule *arch; +}; + struct boot_info { unsigned int nr_mods; + struct boot_module *mods; }; #endif -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 01 07:19:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 07:19:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557774.871430 (Exim 4.92) (envelope-from ) id 1qFUsl-0007Re-Vg; Sat, 01 Jul 2023 07:18:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557774.871430; Sat, 01 Jul 2023 07:18:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFUsl-0007RH-Q2; Sat, 01 Jul 2023 07:18:59 +0000 Received: by outflank-mailman (input) for mailman id 557774; Sat, 01 Jul 2023 07:18:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFUsj-00074A-Ev for xen-devel@lists.xenproject.org; Sat, 01 Jul 2023 07:18:57 +0000 Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [2607:f8b0:4864:20::52e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 895951b8-17df-11ee-b237-6b7b168915f2; Sat, 01 Jul 2023 09:18:55 +0200 (CEST) Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-54290603887so1404339a12.1 for ; Sat, 01 Jul 2023 00:18:55 -0700 (PDT) Received: from cog-dev.home ([70.103.208.83]) by smtp.gmail.com with ESMTPSA id s19-20020aa78d53000000b00673e652985bsm4108866pfe.118.2023.07.01.00.18.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jul 2023 00:18:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 895951b8-17df-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688195933; x=1690787933; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=VdOYeE2v8wd7pgUEWtK6DPA0Re6RRRDIL0/eXfCMrB4=; b=M26WsnkTZSOxTGNSkakaGyhkyNClmHwRJrKRp1N75lO7bD5GT6kPQALOP7zlWX7gKm I3KG2qmBZpmrOKz8R14XWa+tidHoDNawk/qGcYhzw/FJi3lqHtuZVKeWo47H+jfSHn5E XdU1+g2puyG9SktPWFJmJjYeZNpGQ155oZWd3UghsHDEyUDDiankrfReLoBSsfG4D8a7 hFkpcBSo6jCP/SWCkH28CA4vtBSSpho+IqcadOHA8DkY5zXLdaiZUvOfGKu+ZChE+GIT TPcRE9N2VFQ+dq9Ou0ANf/E0ivSit7ow6HZv6spzaxuI/gregJW9UO5G9jpxRU7U1Oae IKeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688195933; x=1690787933; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VdOYeE2v8wd7pgUEWtK6DPA0Re6RRRDIL0/eXfCMrB4=; b=c/pwCAhKi7Nqn+jX5gS/jpyYfZC5hdtDKdZHPBp4jky+IllYOlgspCe7a9ypV8YLLg B4Y0A9Hm2bKX6Dz2YdVYl69LRMdAyDDsiKuwpzxU0GGpTTIGRFGHXdImi51dfbzPehpQ Wjv7hdrrIPFp3ihax1prkx4SprCvd2GlkTYZBCUKp6RzWBHyL1bXnHfOrVqf86GMaXrF aOGV0V/Y9hW5bzMeUlJ52QcZ8pu8Xz4ExMBMKbCp0572/wf9d8cB2K7ux5dh0au7z3ZS oTJ1GPuRZxqTuVkqJYI8mWK/tjI5WSevPivopuEOur+fjxCdhVmIiWes6rpgnxZkdf4e R1jw== X-Gm-Message-State: ABy/qLb53kvM6pA0WLqbPI4/8bTijooSvHshTWVDRU9OT4IQEzei2x7f IXn6Wr3KyZ6EGeQSEPED9uNfhiKZk1Q= X-Google-Smtp-Source: APBJJlF7jbiJpd/xcLRqHauN6U7/NRmIJP9XETRlf0zI9EMG4ip+NRTzFW0GrgaAnu8NEOSFJHXePg== X-Received: by 2002:a05:6a00:190c:b0:682:1319:a169 with SMTP id y12-20020a056a00190c00b006821319a169mr4904419pfi.31.1688195933125; Sat, 01 Jul 2023 00:18:53 -0700 (PDT) Sender: Christopher Clark From: Christopher Clark To: xen-devel@lists.xenproject.org Cc: Daniel Smith , stefano.stabellini@amd.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Luca Fancellu , Volodymyr Babchuk , Rich Persaud Subject: [PATCH 04/10] x86 setup: porting dom0 construction logic to boot module structures Date: Sat, 1 Jul 2023 00:18:29 -0700 Message-Id: <20230701071835.41599-5-christopher.w.clark@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230701071835.41599-1-christopher.w.clark@gmail.com> References: <20230701071835.41599-1-christopher.w.clark@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adjust the PV and PVH dom0 construction entry points to take boot module structures as parameters, and add further fields to the boot module structures to plumb the data needed to support this use. Populate these from the multiboot module data. This change removes multiboot from the PV and PVH dom0 construction logic. Introduce and use new inline accessor functions for navigating the boot module structures. The per-boot-module arrays are expanded from singletons to accommodate all modules, up to a static maximum of 64 modules including Xen that can be accepted from a bootloader to match the previous value from the module map check. The field that identifies the type of a boot module (kernel, ramdisk, etc) is introduced to the common boot module structure and declared as a non-enum integer type to allow the field to be of a known-size and so structure can be packed in a subsequent patch in the series, and it will then be reconciled with the equivalent Arm boot field type. The command line provided by multiboot for each boot module is added directly to the boot_module structure, which is appropriate for this logic just replacing multiboot. The maximum number of boot modules that a bootloader can provide in addition to the Xen hypervisor is preserved from prior logic with the module_map at 63. Signed-off-by: Christopher Clark Signed-off-by: Daniel P. Smith --- Changes since v1: patch is a subset of v1 series patches 2 and 3. - The module_map is kept for now since still in use. - Move the static inline functions into a separate dedicated header. - and replace prior inclusion of for simpler dependencies. xen/arch/x86/dom0_build.c | 10 +- xen/arch/x86/hvm/dom0_build.c | 43 +++--- xen/arch/x86/include/asm/boot.h | 36 +++++ xen/arch/x86/include/asm/bootinfo.h | 24 +++ xen/arch/x86/include/asm/dom0_build.h | 13 +- xen/arch/x86/include/asm/setup.h | 4 +- xen/arch/x86/pv/dom0_build.c | 32 ++-- xen/arch/x86/setup.c | 206 +++++++++++++++----------- xen/include/xen/bootinfo.h | 27 ++++ 9 files changed, 254 insertions(+), 141 deletions(-) diff --git a/xen/arch/x86/dom0_build.c b/xen/arch/x86/dom0_build.c index 9f5300a3ef..42310202a2 100644 --- a/xen/arch/x86/dom0_build.c +++ b/xen/arch/x86/dom0_build.c @@ -4,6 +4,7 @@ * Copyright (c) 2002-2005, K A Fraser */ +#include #include #include #include @@ -562,9 +563,8 @@ int __init dom0_setup_permissions(struct domain *d) return rc; } -int __init construct_dom0(struct domain *d, const module_t *image, - unsigned long image_headroom, module_t *initrd, - char *cmdline) +int __init construct_dom0(struct domain *d, const struct boot_module *image, + struct boot_module *initrd, char *cmdline) { int rc; @@ -576,9 +576,9 @@ int __init construct_dom0(struct domain *d, const module_t *image, process_pending_softirqs(); if ( is_hvm_domain(d) ) - rc = dom0_construct_pvh(d, image, image_headroom, initrd, cmdline); + rc = dom0_construct_pvh(d, image, initrd, cmdline); else if ( is_pv_domain(d) ) - rc = dom0_construct_pv(d, image, image_headroom, initrd, cmdline); + rc = dom0_construct_pv(d, image, initrd, cmdline); else panic("Cannot construct Dom0. No guest interface available\n"); diff --git a/xen/arch/x86/hvm/dom0_build.c b/xen/arch/x86/hvm/dom0_build.c index 56fe89632b..c094863bb8 100644 --- a/xen/arch/x86/hvm/dom0_build.c +++ b/xen/arch/x86/hvm/dom0_build.c @@ -8,9 +8,9 @@ */ #include +#include #include #include -#include #include #include @@ -530,14 +530,13 @@ static paddr_t __init find_memory( return INVALID_PADDR; } -static int __init pvh_load_kernel(struct domain *d, const module_t *image, - unsigned long image_headroom, - module_t *initrd, void *image_base, - char *cmdline, paddr_t *entry, - paddr_t *start_info_addr) +static int __init pvh_load_kernel( + struct domain *d, const struct boot_module *image, + struct boot_module *initrd, void *image_base, char *cmdline, paddr_t *entry, + paddr_t *start_info_addr) { - void *image_start = image_base + image_headroom; - unsigned long image_len = image->mod_end; + void *image_start = image_base + image->arch->headroom; + unsigned long image_len = image->size; struct elf_binary elf; struct elf_dom_parms parms; paddr_t last_addr; @@ -546,7 +545,7 @@ static int __init pvh_load_kernel(struct domain *d, const module_t *image, struct vcpu *v = d->vcpu[0]; int rc; - if ( (rc = bzimage_parse(image_base, &image_start, image_headroom, + if ( (rc = bzimage_parse(image_base, &image_start, image->arch->headroom, &image_len)) != 0 ) { printk("Error trying to detect bz compressed kernel\n"); @@ -594,7 +593,7 @@ static int __init pvh_load_kernel(struct domain *d, const module_t *image, * simplify it. */ last_addr = find_memory(d, &elf, sizeof(start_info) + - (initrd ? ROUNDUP(initrd->mod_end, PAGE_SIZE) + + (initrd ? ROUNDUP(initrd->size, PAGE_SIZE) + sizeof(mod) : 0) + (cmdline ? ROUNDUP(strlen(cmdline) + 1, @@ -608,8 +607,8 @@ static int __init pvh_load_kernel(struct domain *d, const module_t *image, if ( initrd != NULL ) { - rc = hvm_copy_to_guest_phys(last_addr, mfn_to_virt(initrd->mod_start), - initrd->mod_end, v); + rc = hvm_copy_to_guest_phys(last_addr, maddr_to_virt(initrd->start), + initrd->size, v); if ( rc ) { printk("Unable to copy initrd to guest\n"); @@ -617,11 +616,11 @@ static int __init pvh_load_kernel(struct domain *d, const module_t *image, } mod.paddr = last_addr; - mod.size = initrd->mod_end; - last_addr += ROUNDUP(initrd->mod_end, elf_64bit(&elf) ? 8 : 4); - if ( initrd->string ) + mod.size = initrd->size; + last_addr += ROUNDUP(initrd->size, elf_64bit(&elf) ? 8 : 4); + if ( initrd->string.len ) { - char *str = __va(initrd->string); + char *str = initrd->string.bytes; size_t len = strlen(str) + 1; rc = hvm_copy_to_guest_phys(last_addr, str, len, v); @@ -1176,10 +1175,9 @@ static void __hwdom_init pvh_setup_mmcfg(struct domain *d) } } -int __init dom0_construct_pvh(struct domain *d, const module_t *image, - unsigned long image_headroom, - module_t *initrd, - char *cmdline) +int __init dom0_construct_pvh( + struct domain *d, const struct boot_module *image, + struct boot_module *initrd, char *cmdline) { paddr_t entry, start_info; int rc; @@ -1209,9 +1207,8 @@ int __init dom0_construct_pvh(struct domain *d, const module_t *image, return rc; } - rc = pvh_load_kernel(d, image, image_headroom, initrd, - bootstrap_map_multiboot(image), - cmdline, &entry, &start_info); + rc = pvh_load_kernel(d, image, initrd, bootstrap_map(image), cmdline, + &entry, &start_info); if ( rc ) { printk("Failed to load Dom0 kernel\n"); diff --git a/xen/arch/x86/include/asm/boot.h b/xen/arch/x86/include/asm/boot.h index 10b17f12b2..bcf4f2e2e3 100644 --- a/xen/arch/x86/include/asm/boot.h +++ b/xen/arch/x86/include/asm/boot.h @@ -19,6 +19,42 @@ static inline void *bootstrap_map_multiboot(const module_t *mod) return bootstrap_map(&bm); } +static inline unsigned long bootmodule_index( + const struct boot_info *info, bootmod_type_t bootmod_type, + unsigned long start) +{ + for ( ; start < info->nr_mods; start++ ) + if ( info->mods[start].bootmod_type == bootmod_type ) + return start; + + return info->nr_mods + 1; +} + +static inline struct boot_module *bootmodule_next( + const struct boot_info *info, bootmod_type_t bootmod_type) +{ + unsigned long i; + + for ( i = 0; i < info->nr_mods; i++ ) + if ( info->mods[i].bootmod_type == bootmod_type ) + return &info->mods[i]; + + return NULL; +} + +static inline void bootmodule_update_start(struct boot_module *bm, + paddr_t new_start) +{ + bm->start = new_start; + bm->mfn = maddr_to_mfn(new_start); +} + +static inline void bootmodule_update_mfn(struct boot_module *bm, mfn_t new_mfn) +{ + bm->mfn = new_mfn; + bm->start = mfn_to_maddr(new_mfn); +} + #endif /* diff --git a/xen/arch/x86/include/asm/bootinfo.h b/xen/arch/x86/include/asm/bootinfo.h index a25054f372..30c27980e0 100644 --- a/xen/arch/x86/include/asm/bootinfo.h +++ b/xen/arch/x86/include/asm/bootinfo.h @@ -2,9 +2,33 @@ #define __ARCH_X86_BOOTINFO_H__ struct arch_bootmodule { +#define BOOTMOD_FLAG_X86_RELOCATED 1U << 0 + uint32_t flags; unsigned headroom; }; +struct arch_boot_info { + uint32_t flags; +#define BOOTINFO_FLAG_X86_CMDLINE 1U << 2 +#define BOOTINFO_FLAG_X86_MODULES 1U << 3 +#define BOOTINFO_FLAG_X86_MEMMAP 1U << 6 +#define BOOTINFO_FLAG_X86_LOADERNAME 1U << 9 + + char *boot_loader_name; + + uint32_t mmap_length; + paddr_t mmap_addr; +}; + +struct __packed mb_memmap { + uint32_t size; + uint32_t base_addr_low; + uint32_t base_addr_high; + uint32_t length_low; + uint32_t length_high; + uint32_t type; +}; + #endif /* diff --git a/xen/arch/x86/include/asm/dom0_build.h b/xen/arch/x86/include/asm/dom0_build.h index a5f8c9e67f..ca502269f2 100644 --- a/xen/arch/x86/include/asm/dom0_build.h +++ b/xen/arch/x86/include/asm/dom0_build.h @@ -1,6 +1,7 @@ #ifndef _DOM0_BUILD_H_ #define _DOM0_BUILD_H_ +#include #include #include @@ -13,15 +14,11 @@ unsigned long dom0_compute_nr_pages(struct domain *d, unsigned long initrd_len); int dom0_setup_permissions(struct domain *d); -int dom0_construct_pv(struct domain *d, const module_t *image, - unsigned long image_headroom, - module_t *initrd, - char *cmdline); +int dom0_construct_pv(struct domain *d, const struct boot_module *image, + struct boot_module *initrd, char *cmdline); -int dom0_construct_pvh(struct domain *d, const module_t *image, - unsigned long image_headroom, - module_t *initrd, - char *cmdline); +int dom0_construct_pvh(struct domain *d, const struct boot_module *image, + struct boot_module *initrd, char *cmdline); unsigned long dom0_paging_pages(const struct domain *d, unsigned long nr_pages); diff --git a/xen/arch/x86/include/asm/setup.h b/xen/arch/x86/include/asm/setup.h index 80d0bb2a21..2d620d04c7 100644 --- a/xen/arch/x86/include/asm/setup.h +++ b/xen/arch/x86/include/asm/setup.h @@ -34,8 +34,8 @@ static inline void vesa_init(void) {}; int construct_dom0( struct domain *d, - const module_t *kernel, unsigned long kernel_headroom, - module_t *initrd, + const struct boot_module *kernel, + struct boot_module *initrd, char *cmdline); void setup_io_bitmap(struct domain *d); diff --git a/xen/arch/x86/pv/dom0_build.c b/xen/arch/x86/pv/dom0_build.c index 4fe806b60d..bc0af7cf27 100644 --- a/xen/arch/x86/pv/dom0_build.c +++ b/xen/arch/x86/pv/dom0_build.c @@ -4,12 +4,12 @@ * Copyright (c) 2002-2005, K A Fraser */ +#include #include #include #include #include #include -#include #include #include #include @@ -356,9 +356,8 @@ static struct page_info * __init alloc_chunk(struct domain *d, } int __init dom0_construct_pv(struct domain *d, - const module_t *image, - unsigned long image_headroom, - module_t *initrd, + const struct boot_module *image, + struct boot_module *initrd, char *cmdline) { int i, rc, order, machine; @@ -375,10 +374,10 @@ int __init dom0_construct_pv(struct domain *d, unsigned int flush_flags = 0; start_info_t *si; struct vcpu *v = d->vcpu[0]; - void *image_base = bootstrap_map_multiboot(image); - unsigned long image_len = image->mod_end; - void *image_start = image_base + image_headroom; - unsigned long initrd_len = initrd ? initrd->mod_end : 0; + void *image_base = bootstrap_map(image); + unsigned long image_len = image->size; + void *image_start = image_base + image->arch->headroom; + unsigned long initrd_len = initrd ? initrd->size : 0; l4_pgentry_t *l4tab = NULL, *l4start = NULL; l3_pgentry_t *l3tab = NULL, *l3start = NULL; l2_pgentry_t *l2tab = NULL, *l2start = NULL; @@ -417,7 +416,7 @@ int __init dom0_construct_pv(struct domain *d, d->max_pages = ~0U; - if ( (rc = bzimage_parse(image_base, &image_start, image_headroom, + if ( (rc = bzimage_parse(image_base, &image_start, image->arch->headroom, &image_len)) != 0 ) return rc; @@ -612,7 +611,7 @@ int __init dom0_construct_pv(struct domain *d, initrd_pfn = vinitrd_start ? (vinitrd_start - v_start) >> PAGE_SHIFT : domain_tot_pages(d); - initrd_mfn = mfn = initrd->mod_start; + initrd_mfn = mfn = mfn_x(initrd->mfn); count = PFN_UP(initrd_len); if ( d->arch.physaddr_bitsize && ((mfn + count - 1) >> (d->arch.physaddr_bitsize - PAGE_SHIFT)) ) @@ -627,12 +626,13 @@ int __init dom0_construct_pv(struct domain *d, free_domheap_pages(page, order); page += 1UL << order; } - memcpy(page_to_virt(page), mfn_to_virt(initrd->mod_start), + memcpy(page_to_virt(page), maddr_to_virt(initrd->start), initrd_len); - mpt_alloc = (paddr_t)initrd->mod_start << PAGE_SHIFT; + mpt_alloc = (paddr_t)initrd->start; init_domheap_pages(mpt_alloc, mpt_alloc + PAGE_ALIGN(initrd_len)); - initrd->mod_start = initrd_mfn = mfn_x(page_to_mfn(page)); + bootmodule_update_mfn(initrd, page_to_mfn(page)); + initrd_mfn = mfn_x(initrd->mfn); } else { @@ -640,7 +640,7 @@ int __init dom0_construct_pv(struct domain *d, if ( assign_pages(mfn_to_page(_mfn(mfn++)), 1, d, 0) ) BUG(); } - initrd->mod_end = 0; + initrd->size = 0; iommu_memory_setup(d, "initrd", mfn_to_page(_mfn(initrd_mfn)), PFN_UP(initrd_len), &flush_flags); @@ -654,7 +654,7 @@ int __init dom0_construct_pv(struct domain *d, nr_pages - domain_tot_pages(d)); if ( initrd ) { - mpt_alloc = (paddr_t)initrd->mod_start << PAGE_SHIFT; + mpt_alloc = initrd->start; printk("\n Init. ramdisk: %"PRIpaddr"->%"PRIpaddr, mpt_alloc, mpt_alloc + initrd_len); } @@ -880,7 +880,7 @@ int __init dom0_construct_pv(struct domain *d, if ( pfn >= initrd_pfn ) { if ( pfn < initrd_pfn + PFN_UP(initrd_len) ) - mfn = initrd->mod_start + (pfn - initrd_pfn); + mfn = mfn_x(initrd->mfn) + (pfn - initrd_pfn); else mfn -= PFN_UP(initrd_len); } diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 3b623a4149..f9b04daebd 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -37,6 +37,7 @@ #include #include #include +#include #include #include #include @@ -59,6 +60,9 @@ #include #include +/* Max number of boot modules a bootloader can provide in addition to Xen */ +#define MAX_NR_BOOTMODS 63 + /* opt_nosmp: If true, secondary processors are ignored. */ static bool __initdata opt_nosmp; boolean_param("nosmp", opt_nosmp); @@ -269,20 +273,44 @@ static int __init cf_check parse_acpi_param(const char *s) } custom_param("acpi", parse_acpi_param); -static const module_t *__initdata initial_images; static struct boot_info __initdata *boot_info; -static void __init multiboot_to_bootinfo(multiboot_info_t *mbi) +static void __init multiboot_to_bootinfo(multiboot_info_t *mbi, module_t *mods) { static struct boot_info __initdata info; - static struct boot_module __initdata boot_mods[1]; - static struct arch_bootmodule __initdata arch_boot_mods[1]; + static struct arch_boot_info __initdata arch_info; + static struct boot_module __initdata boot_mods[MAX_NR_BOOTMODS + 1]; + static struct arch_bootmodule __initdata arch_boot_mods[ + MAX_NR_BOOTMODS + 1]; + int i; + + info.arch = &arch_info; info.mods = boot_mods; + info.cmdline = __va(mbi->cmdline); + + /* The BOOTINFO_FLAG_X86_* flags are a 1-1 map to MBI_* */ + arch_info.flags = mbi->flags; + arch_info.mmap_length = mbi->mmap_length; + arch_info.mmap_addr = mbi->mmap_addr; + arch_info.boot_loader_name = __va(mbi->boot_loader_name); + info.nr_mods = mbi->mods_count; + for ( i = 0; i <= MAX_NR_BOOTMODS; i++ ) + { + boot_mods[i].arch = &arch_boot_mods[i]; - boot_mods[0].arch = &arch_boot_mods[0]; + if ( i < info.nr_mods ) + { + bootmodule_update_start(&boot_mods[i], mods[i].mod_start); + boot_mods[i].size = mods[i].mod_end - mods[i].mod_start; + + boot_mods[i].string.len = strlcpy(boot_mods[i].string.bytes, + __va(mods[i].string), + BOOTMOD_STRING_MAX_LEN); + } + } boot_info = &info; } @@ -296,8 +324,8 @@ unsigned long __init initial_images_nrpages(nodeid_t node) for ( nr = i = 0; i < boot_info->nr_mods; ++i ) { - unsigned long start = initial_images[i].mod_start; - unsigned long end = start + PFN_UP(initial_images[i].mod_end); + unsigned long start = mfn_x(boot_info->mods[i].mfn); + unsigned long end = start + PFN_UP(boot_info->mods[i].size); if ( end > node_start && node_end > start ) nr += min(node_end, end) - max(node_start, start); @@ -312,14 +340,13 @@ void __init discard_initial_images(void) for ( i = 0; i < boot_info->nr_mods; ++i ) { - uint64_t start = (uint64_t)initial_images[i].mod_start << PAGE_SHIFT; + uint64_t start = boot_info->mods[i].start; init_domheap_pages(start, - start + PAGE_ALIGN(initial_images[i].mod_end)); + start + PAGE_ALIGN(boot_info->mods[i].size)); } boot_info->nr_mods = 0; - initial_images = NULL; } extern unsigned char __init_begin[], __init_end[]; @@ -450,26 +477,26 @@ static void __init move_memory( while ( size ) { - module_t mod; + struct boot_module mod; unsigned int soffs = src & mask; unsigned int doffs = dst & mask; unsigned int sz; void *d, *s; - mod.mod_start = (src - soffs) >> PAGE_SHIFT; - mod.mod_end = soffs + size; - if ( mod.mod_end > blksz ) - mod.mod_end = blksz; - sz = mod.mod_end - soffs; - s = bootstrap_map_multiboot(&mod); - - mod.mod_start = (dst - doffs) >> PAGE_SHIFT; - mod.mod_end = doffs + size; - if ( mod.mod_end > blksz ) - mod.mod_end = blksz; - if ( sz > mod.mod_end - doffs ) - sz = mod.mod_end - doffs; - d = bootstrap_map_multiboot(&mod); + mod.start = src - soffs; + mod.size = soffs + size; + if ( mod.size > blksz ) + mod.size = blksz; + sz = mod.size - soffs; + s = bootstrap_map(&mod); + + mod.start = dst - doffs; + mod.size = doffs + size; + if ( mod.size > blksz ) + mod.size = blksz; + if ( sz > mod.size - doffs ) + sz = mod.size - doffs; + d = bootstrap_map(&mod); memmove(d + doffs, s + soffs, sz); @@ -602,7 +629,7 @@ static void __init noinline move_xen(void) #undef BOOTSTRAP_MAP_LIMIT static uint64_t __init consider_modules( - uint64_t s, uint64_t e, uint32_t size, const module_t *mod, + uint64_t s, uint64_t e, uint32_t size, const struct boot_module *mod, unsigned int nr_mods, unsigned int this_mod) { unsigned int i; @@ -612,8 +639,8 @@ static uint64_t __init consider_modules( for ( i = 0; i < nr_mods ; ++i ) { - uint64_t start = (uint64_t)mod[i].mod_start << PAGE_SHIFT; - uint64_t end = start + PAGE_ALIGN(mod[i].mod_end); + uint64_t start = mod[i].start; + uint64_t end = start + PAGE_ALIGN(mod[i].size); if ( i == this_mod ) continue; @@ -883,9 +910,8 @@ static unsigned int __init copy_bios_e820(struct e820entry *map, unsigned int li return n; } -static struct domain *__init create_dom0(const module_t *image, - unsigned long headroom, - module_t *initrd, const char *kextra, +static struct domain *__init create_dom0(const struct boot_info *bootinfo, + const char *kextra, const char *loader) { struct xen_domctl_createdomain dom0_cfg = { @@ -899,9 +925,14 @@ static struct domain *__init create_dom0(const module_t *image, .misc_flags = opt_dom0_msr_relaxed ? XEN_X86_MSR_RELAXED : 0, }, }; + struct boot_module *image = bootmodule_next(bootinfo, BOOTMOD_KERNEL); + struct boot_module *initrd = bootmodule_next(bootinfo, BOOTMOD_RAMDISK); struct domain *d; char *cmdline; - domid_t domid; + domid_t domid = 0; + + if ( image == NULL ) + panic("Error creating d%uv0\n", domid); if ( opt_dom0_pvh ) { @@ -928,7 +959,7 @@ static struct domain *__init create_dom0(const module_t *image, panic("Error creating d%uv0\n", domid); /* Grab the DOM0 command line. */ - cmdline = image->string ? __va(image->string) : NULL; + cmdline = image->string.len ? image->string.bytes : NULL; if ( cmdline || kextra ) { static char __initdata dom0_cmdline[MAX_GUEST_CMDLINE]; @@ -968,8 +999,7 @@ static struct domain *__init create_dom0(const module_t *image, write_cr4(read_cr4() & ~X86_CR4_SMAP); } - if ( construct_dom0(d, image, boot_info->mods[0].arch->headroom, initrd, - cmdline) != 0 ) + if ( construct_dom0(d, image, initrd, cmdline) != 0 ) panic("Could not construct domain 0\n"); if ( cpu_has_smap ) @@ -1038,14 +1068,14 @@ void __init noreturn __start_xen(unsigned long mbi_p) mod = __va(mbi->mods_addr); } - multiboot_to_bootinfo(mbi); + multiboot_to_bootinfo(mbi, mod); - loader = (mbi->flags & MBI_LOADERNAME) - ? (char *)__va(mbi->boot_loader_name) : "unknown"; + loader = (boot_info->arch->flags & BOOTINFO_FLAG_X86_LOADERNAME) + ? boot_info->arch->boot_loader_name : "unknown"; /* Parse the command-line options. */ - cmdline = cmdline_cook((mbi->flags & MBI_CMDLINE) ? - __va(mbi->cmdline) : NULL, + cmdline = cmdline_cook((boot_info->arch->flags & BOOTINFO_FLAG_X86_CMDLINE) ? + boot_info->cmdline : NULL, loader); if ( (kextra = strstr(cmdline, " -- ")) != NULL ) { @@ -1147,19 +1177,22 @@ void __init noreturn __start_xen(unsigned long mbi_p) bootsym(boot_edd_info_nr)); /* Check that we have at least one Multiboot module. */ - if ( !(mbi->flags & MBI_MODULES) || (boot_info->nr_mods == 0) ) + if ( !(boot_info->arch->flags & BOOTINFO_FLAG_X86_MODULES) || + (boot_info->nr_mods == 0) ) panic("dom0 kernel not specified. Check bootloader configuration\n"); /* Check that we don't have a silly number of modules. */ - if ( boot_info->nr_mods > sizeof(module_map) * 8 ) + if ( boot_info->nr_mods > MAX_NR_BOOTMODS + 1 ) { - boot_info->nr_mods = sizeof(module_map) * 8; + boot_info->nr_mods = MAX_NR_BOOTMODS + 1; printk("Excessive multiboot modules - using the first %u only\n", boot_info->nr_mods); } - bitmap_fill(module_map, boot_info->nr_mods); + /* Dom0 kernel is the first boot module */ + bitmap_fill(module_map, mbi->mods_count); __clear_bit(0, module_map); /* Dom0 kernel is always first */ + boot_info->mods[0].bootmod_type = BOOTMOD_KERNEL; if ( pvh_boot ) { @@ -1189,13 +1222,13 @@ void __init noreturn __start_xen(unsigned long mbi_p) { memmap_type = "Xen-e820"; } - else if ( mbi->flags & MBI_MEMMAP ) + else if ( boot_info->arch->flags & BOOTINFO_FLAG_X86_MEMMAP ) { memmap_type = "Multiboot-e820"; - while ( bytes < mbi->mmap_length && + while ( bytes < boot_info->arch->mmap_length && e820_raw.nr_map < ARRAY_SIZE(e820_raw.map) ) { - memory_map_t *map = __va(mbi->mmap_addr + bytes); + struct mb_memmap *map = __va(boot_info->arch->mmap_addr + bytes); /* * This is a gross workaround for a BIOS bug. Some bootloaders do @@ -1330,17 +1363,9 @@ void __init noreturn __start_xen(unsigned long mbi_p) set_kexec_crash_area_size((u64)nr_pages << PAGE_SHIFT); kexec_reserve_area(&boot_e820); - initial_images = mod; - boot_info->nr_mods = boot_info->nr_mods; - for ( i = 0; !efi_enabled(EFI_LOADER) && i < boot_info->nr_mods; i++ ) - { - if ( mod[i].mod_start & (PAGE_SIZE - 1) ) + if ( boot_info->mods[i].start & (PAGE_SIZE - 1) ) panic("Bootloader didn't honor module alignment request\n"); - mod[i].mod_end -= mod[i].mod_start; - mod[i].mod_start >>= PAGE_SHIFT; - mod[i].reserved = 0; - } /* * TODO: load ucode earlier once multiboot modules become accessible @@ -1357,12 +1382,14 @@ void __init noreturn __start_xen(unsigned long mbi_p) * respective reserve_e820_ram() invocation below. No need to * query efi_boot_mem_unused() here, though. */ - mod[boot_info->nr_mods].mod_start = virt_to_mfn(_stext); - mod[boot_info->nr_mods].mod_end = __2M_rwdata_end - _stext; + bootmodule_update_start(&boot_info->mods[boot_info->nr_mods], + virt_to_maddr(_stext)); + boot_info->mods[boot_info->nr_mods].size = __2M_rwdata_end - _stext; } boot_info->mods[0].arch->headroom = - bzimage_headroom(bootstrap_map_multiboot(mod), mod->mod_end); + bzimage_headroom(bootstrap_map(&boot_info->mods[0]), + boot_info->mods[0].size); bootstrap_map(NULL); @@ -1420,7 +1447,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) { /* Don't overlap with modules. */ end = consider_modules(s, e, reloc_size + mask, - mod, boot_info->nr_mods, -1); + boot_info->mods, boot_info->nr_mods, -1); end &= ~mask; } else @@ -1443,15 +1470,15 @@ void __init noreturn __start_xen(unsigned long mbi_p) /* Is the region suitable for relocating the multiboot modules? */ for ( j = boot_info->nr_mods - 1; j >= 0; j-- ) { - struct boot_module *boot_mods = boot_info->mods; - unsigned long headroom = j ? 0 : boot_mods[0].arch->headroom; - unsigned long size = PAGE_ALIGN(headroom + mod[j].mod_end); + struct boot_module *boot_mod = boot_info->mods; + unsigned long headroom = j ? 0 : boot_mod[0].arch->headroom; + unsigned long size = PAGE_ALIGN(headroom + boot_mod[j].size); - if ( mod[j].reserved ) + if ( boot_mod[j].arch->flags & BOOTMOD_FLAG_X86_RELOCATED ) continue; /* Don't overlap with other modules (or Xen itself). */ - end = consider_modules(s, e, size, mod, + end = consider_modules(s, e, size, boot_info->mods, boot_info->nr_mods + relocated, j); if ( highmem_start && end > highmem_start ) @@ -1459,14 +1486,14 @@ void __init noreturn __start_xen(unsigned long mbi_p) if ( s < end && (headroom || - ((end - size) >> PAGE_SHIFT) > mod[j].mod_start) ) + ((end - size) >> PAGE_SHIFT) > mfn_x(boot_mod[j].mfn)) ) { move_memory(end - size + headroom, - (uint64_t)mod[j].mod_start << PAGE_SHIFT, - mod[j].mod_end); - mod[j].mod_start = (end - size) >> PAGE_SHIFT; - mod[j].mod_end += headroom; - mod[j].reserved = 1; + (uint64_t)boot_mod[j].start, + boot_mod[j].size); + bootmodule_update_start(&boot_mod[j], end - size); + boot_mod[j].size += headroom; + boot_mod[j].arch->flags |= BOOTMOD_FLAG_X86_RELOCATED; } } @@ -1478,7 +1505,8 @@ void __init noreturn __start_xen(unsigned long mbi_p) while ( !kexec_crash_area.start ) { /* Don't overlap with modules (or Xen itself). */ - e = consider_modules(s, e, PAGE_ALIGN(kexec_crash_area.size), mod, + e = consider_modules(s, e, PAGE_ALIGN(kexec_crash_area.size), + boot_info->mods, boot_info->nr_mods + relocated, -1); if ( s >= e ) break; @@ -1492,13 +1520,14 @@ void __init noreturn __start_xen(unsigned long mbi_p) #endif } - if ( boot_info->mods[0].arch->headroom && !mod->reserved ) + if ( boot_info->mods[0].arch->headroom && + !(boot_info->mods[0].arch->flags & BOOTMOD_FLAG_X86_RELOCATED) ) panic("Not enough memory to relocate the dom0 kernel image\n"); for ( i = 0; i < boot_info->nr_mods; ++i ) { - uint64_t s = (uint64_t)mod[i].mod_start << PAGE_SHIFT; + uint64_t s = (uint64_t)boot_info->mods[i].start; - reserve_e820_ram(&boot_e820, s, s + PAGE_ALIGN(mod[i].mod_end)); + reserve_e820_ram(&boot_e820, s, s + PAGE_ALIGN(boot_info->mods[i].size)); } if ( !xen_phys_start ) @@ -1565,8 +1594,8 @@ void __init noreturn __start_xen(unsigned long mbi_p) map_e = boot_e820.map[j].addr + boot_e820.map[j].size; for ( j = 0; j < boot_info->nr_mods; ++j ) { - uint64_t end = pfn_to_paddr(mod[j].mod_start) + - mod[j].mod_end; + uint64_t end = mfn_to_maddr(boot_info->mods[j].mfn) + + boot_info->mods[j].size; if ( map_e < end ) map_e = end; @@ -1641,11 +1670,12 @@ void __init noreturn __start_xen(unsigned long mbi_p) for ( i = 0; i < boot_info->nr_mods; ++i ) { - set_pdx_range(mod[i].mod_start, - mod[i].mod_start + PFN_UP(mod[i].mod_end)); - map_pages_to_xen((unsigned long)mfn_to_virt(mod[i].mod_start), - _mfn(mod[i].mod_start), - PFN_UP(mod[i].mod_end), PAGE_HYPERVISOR); + set_pdx_range(mfn_x(boot_info->mods[i].mfn), + mfn_x(boot_info->mods[i].mfn) + + PFN_UP(boot_info->mods[i].size)); + map_pages_to_xen((unsigned long)maddr_to_virt(boot_info->mods[i].start), + boot_info->mods[i].mfn, + PFN_UP(boot_info->mods[i].size), PAGE_HYPERVISOR); } #ifdef CONFIG_KEXEC @@ -2022,8 +2052,12 @@ void __init noreturn __start_xen(unsigned long mbi_p) cpu_has_nx ? XENLOG_INFO : XENLOG_WARNING "Warning: ", cpu_has_nx ? "" : "not "); - initrdidx = find_first_bit(module_map, boot_info->nr_mods); - if ( bitmap_weight(module_map, boot_info->nr_mods) > 1 ) + initrdidx = bootmodule_index(boot_info, BOOTMOD_UNKNOWN, 0); + if ( initrdidx < boot_info->nr_mods ) + boot_info->mods[initrdidx].bootmod_type = BOOTMOD_RAMDISK; + + if ( bootmodule_index(boot_info, BOOTMOD_UNKNOWN, 0) > + boot_info->nr_mods ) printk(XENLOG_WARNING "Multiple initrd candidates, picking module #%u\n", initrdidx); @@ -2032,9 +2066,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) * We're going to setup domain0 using the module(s) that we stashed safely * above our heap. The second module, if present, is an initrd ramdisk. */ - dom0 = create_dom0(mod, boot_info->mods[0].arch->headroom, - initrdidx < boot_info->nr_mods ? mod + initrdidx : NULL, - kextra, loader); + dom0 = create_dom0(boot_info, kextra, loader); if ( !dom0 ) panic("Could not set up DOM0 guest OS\n"); diff --git a/xen/include/xen/bootinfo.h b/xen/include/xen/bootinfo.h index eb93cc3439..2f4284a91f 100644 --- a/xen/include/xen/bootinfo.h +++ b/xen/include/xen/bootinfo.h @@ -2,23 +2,50 @@ #define __XEN_BOOTINFO_H__ #include +#include +#include #ifdef CONFIG_X86 #include #else struct arch_bootmodule { }; + struct arch_boot_info { }; #endif +/* Boot module binary type / purpose */ +#define BOOTMOD_UNKNOWN 0 +#define BOOTMOD_XEN 1 +#define BOOTMOD_FDT 2 +#define BOOTMOD_KERNEL 3 +#define BOOTMOD_RAMDISK 4 +#define BOOTMOD_XSM 5 +#define BOOTMOD_UCODE 6 +#define BOOTMOD_GUEST_DTB 7 +typedef unsigned int bootmod_type_t; + +#define BOOTMOD_STRING_MAX_LEN 1024 +struct boot_string { + char bytes[BOOTMOD_STRING_MAX_LEN]; + size_t len; +}; + struct boot_module { + bootmod_type_t bootmod_type; paddr_t start; + mfn_t mfn; size_t size; struct arch_bootmodule *arch; + struct boot_string string; }; struct boot_info { + char *cmdline; + unsigned int nr_mods; struct boot_module *mods; + + struct arch_boot_info *arch; }; #endif -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 01 07:19:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 07:19:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557775.871435 (Exim 4.92) (envelope-from ) id 1qFUsm-0007VE-Bn; Sat, 01 Jul 2023 07:19:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557775.871435; Sat, 01 Jul 2023 07:19:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFUsm-0007Tv-4v; Sat, 01 Jul 2023 07:19:00 +0000 Received: by outflank-mailman (input) for mailman id 557775; Sat, 01 Jul 2023 07:18:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFUsk-00074A-4S for xen-devel@lists.xenproject.org; Sat, 01 Jul 2023 07:18:58 +0000 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [2607:f8b0:4864:20::436]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8a442a66-17df-11ee-b237-6b7b168915f2; Sat, 01 Jul 2023 09:18:56 +0200 (CEST) Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-666e97fcc60so1887762b3a.3 for ; Sat, 01 Jul 2023 00:18:56 -0700 (PDT) Received: from cog-dev.home ([70.103.208.83]) by smtp.gmail.com with ESMTPSA id s19-20020aa78d53000000b00673e652985bsm4108866pfe.118.2023.07.01.00.18.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jul 2023 00:18:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 8a442a66-17df-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688195934; x=1690787934; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=2CCuYNE2IdEGJiRf9KcQxz9oSopCuIZzH05nVBt98V4=; b=L/C1FJaAKKXcrKwwbXfoXKbQbJyRAJdJNLqD8rSSdTsYDwF3QnFSP2qbAA042bSu5Z OFZIrW0J+Zhh+BmakoPWDH4ZzFTQsvVUEeVlHYaCl918lGW6Wh1jbVC1a924pKTMIMLT ixYBYRX9jRyGqkbarfkYRUMvVl5fs3x8ji0pYYcTxKG4Let565+Wt7m4ReGqVoGYWV/Q eZAegTnZa6qvgzw7JfcDFp7OBQWvL2j5oe7Y+LfTbHhysp/YtRNS3at1rUL4Y9/Ctk9C 0nM3B33hMsgll472cqdFo+kHWDEq4HWIonXRH9BcfTq55X2I9HyYK3UkD8bHLjcEwR6W CSSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688195934; x=1690787934; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2CCuYNE2IdEGJiRf9KcQxz9oSopCuIZzH05nVBt98V4=; b=BLwRZZzEoDJzHnnwu9u+6xKgS38426q7sDor8LUo5G9n1xX+eM9GItEq65nOWeUyZ9 DnWseHP9hzHpvh7FuwDsMogLViTUOEo5qGByRb6dSMrFMZkC9w93CSbdksJDCh1gSwYO QLTiXu8vVjsIgHAgDN4PJFCkC5YHDZmMXT/Cmu4LOISBJ5cp0Zo456YUM9LNnCUBWJfT GtvSqeAHVPTdzcH+XyaSR7mDpMT7/+k/nEsw2HsczTs5qNWPJJ98BWM+J8AXDZRuIHzV UpNTah1Qq6i+qRSYwepddB277+r+5vaWBy+FSDbhlkp3wbar3bkciF99bo+nfk7CLpZw j24g== X-Gm-Message-State: ABy/qLZ9tzvuTjkna5RzisUUdxkxoNud6/YggGePXYZ+Dz2xXuWoOVWN OYoRrxonIbDhan10ZXkD8WW8fWvo7zE= X-Google-Smtp-Source: APBJJlFwakyPH8XJc7p5VcZt6PmkVcFDYaVMV4ECD1CzygH3D1pud2JwVpwTI/RepQYB4r6d0mLbRQ== X-Received: by 2002:a05:6a00:1792:b0:64d:1c59:6767 with SMTP id s18-20020a056a00179200b0064d1c596767mr4767504pfg.24.1688195934527; Sat, 01 Jul 2023 00:18:54 -0700 (PDT) Sender: Christopher Clark From: Christopher Clark To: xen-devel@lists.xenproject.org Cc: Daniel Smith , stefano.stabellini@amd.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Luca Fancellu , Volodymyr Babchuk , Rich Persaud Subject: [PATCH 05/10] xsm: switch XSM init to boot info structures Date: Sat, 1 Jul 2023 00:18:30 -0700 Message-Id: <20230701071835.41599-6-christopher.w.clark@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230701071835.41599-1-christopher.w.clark@gmail.com> References: <20230701071835.41599-1-christopher.w.clark@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Change the XSM implementation to use the boot info structure instead of the multiboot module_map. Drops a dependency on CONFIG_MULTIBOOT, so boot module logic is now used whenever the DEVICE_TREE specific logic (for Arm) is not, with the bootinfo header conditionally included to ensure no change on Arm. Adds a multiboot header inclusion into guest/xen/pvh-boot.c since it is no longer provided via transitive inclusion and the source in that file uses multiboot structures. Signed-off-by: Christopher Clark Signed-off-by: Daniel P. Smith --- Changes since v1: patch is a subset of v1 series patches 2 and 3. - Added the inclusion to pvh-boot.c - Use conditional inclusion for xen/arch/x86/guest/xen/pvh-boot.c | 1 + xen/arch/x86/setup.c | 2 +- xen/include/xsm/xsm.h | 28 +++++++-------- xen/xsm/xsm_core.c | 47 +++++++++++++++--------- xen/xsm/xsm_policy.c | 59 ++++++++++++++++--------------- 5 files changed, 77 insertions(+), 60 deletions(-) diff --git a/xen/arch/x86/guest/xen/pvh-boot.c b/xen/arch/x86/guest/xen/pvh-boot.c index 9cbe87b61b..1ed04d035c 100644 --- a/xen/arch/x86/guest/xen/pvh-boot.c +++ b/xen/arch/x86/guest/xen/pvh-boot.c @@ -9,6 +9,7 @@ #include #include #include +#include #include #include diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index f9b04daebd..a616ccc0a8 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -1835,7 +1835,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) mmio_ro_ranges = rangeset_new(NULL, "r/o mmio ranges", RANGESETF_prettyprint_hex); - xsm_multiboot_init(module_map, mbi); + xsm_bootmodule_init(boot_info); /* * IOMMU-related ACPI table parsing may require some of the system domains diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h index 8dad03fd3d..d409c30be6 100644 --- a/xen/include/xsm/xsm.h +++ b/xen/include/xsm/xsm.h @@ -16,8 +16,10 @@ #define __XSM_H__ #include +#ifndef CONFIG_HAS_DEVICE_TREE +# include +#endif #include -#include /* policy magic number (defined by XSM_MAGIC) */ typedef uint32_t xsm_magic_t; @@ -776,15 +778,14 @@ static inline int xsm_argo_send(const struct domain *d, const struct domain *t) #endif /* XSM_NO_WRAPPERS */ -#ifdef CONFIG_MULTIBOOT -int xsm_multiboot_init( - unsigned long *module_map, const multiboot_info_t *mbi); -int xsm_multiboot_policy_init( - unsigned long *module_map, const multiboot_info_t *mbi, - void **policy_buffer, size_t *policy_size); -#endif +#ifndef CONFIG_HAS_DEVICE_TREE +int xsm_bootmodule_init(const struct boot_info *info); +int xsm_bootmodule_policy_init( + const struct boot_info *info, const unsigned char **policy_buffer, + size_t *policy_size); + +#else -#ifdef CONFIG_HAS_DEVICE_TREE /* * Initialize XSM * @@ -826,15 +827,14 @@ static const inline struct xsm_ops *silo_init(void) #include -#ifdef CONFIG_MULTIBOOT -static inline int xsm_multiboot_init ( - unsigned long *module_map, const multiboot_info_t *mbi) +#ifndef CONFIG_HAS_DEVICE_TREE +static inline int xsm_bootmodule_init(const struct boot_info *info) { return 0; } -#endif -#ifdef CONFIG_HAS_DEVICE_TREE +#else + static inline int xsm_dt_init(void) { return 0; diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c index eaa028109b..301ae4dc8b 100644 --- a/xen/xsm/xsm_core.c +++ b/xen/xsm/xsm_core.c @@ -10,8 +10,12 @@ * as published by the Free Software Foundation. */ -#include +#ifndef CONFIG_HAS_DEVICE_TREE +# include +#endif #include +#include +#include #include #include @@ -138,26 +142,35 @@ static int __init xsm_core_init(const void *policy_buffer, size_t policy_size) return 0; } -#ifdef CONFIG_MULTIBOOT -int __init xsm_multiboot_init( - unsigned long *module_map, const multiboot_info_t *mbi) +/* + * ifdef'ing this against multiboot is no longer valid as the boot module + * is agnostic and it will be possible to dropped the ifndef should Arm + * adopt boot info + */ +#ifndef CONFIG_HAS_DEVICE_TREE +int __init xsm_bootmodule_init(const struct boot_info *bootinfo) { int ret = 0; - void *policy_buffer = NULL; + const unsigned char *policy_buffer = NULL; size_t policy_size = 0; printk("XSM Framework v" XSM_FRAMEWORK_VERSION " initialized\n"); if ( XSM_MAGIC ) { - ret = xsm_multiboot_policy_init(module_map, mbi, &policy_buffer, - &policy_size); - if ( ret ) - { - bootstrap_map(NULL); - printk(XENLOG_ERR "Error %d initializing XSM policy\n", ret); - return -EINVAL; - } + int ret = xsm_bootmodule_policy_init(bootinfo, &policy_buffer, + &policy_size); + bootstrap_map(NULL); + + if ( ret == -ENOENT ) + /* + * The XSM module needs a policy file but one was not located. + * Report as a warning and continue as the XSM module may late + * load a policy file. + */ + printk(XENLOG_WARNING "xsm: starting without a policy loaded!\n"); + else if ( ret ) + panic("Error %d initializing XSM policy\n", ret); } ret = xsm_core_init(policy_buffer, policy_size); @@ -165,9 +178,9 @@ int __init xsm_multiboot_init( return 0; } -#endif -#ifdef CONFIG_HAS_DEVICE_TREE +#else + int __init xsm_dt_init(void) { int ret = 0; @@ -215,9 +228,9 @@ bool __init has_xsm_magic(paddr_t start) return false; } -#endif +#endif /* CONFIG_HAS_DEVICE_TREE */ -#endif +#endif /* CONFIG_XSM */ long do_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op) { diff --git a/xen/xsm/xsm_policy.c b/xen/xsm/xsm_policy.c index c6df8c6e06..f1970c8964 100644 --- a/xen/xsm/xsm_policy.c +++ b/xen/xsm/xsm_policy.c @@ -18,62 +18,65 @@ * */ -#include -#ifdef CONFIG_MULTIBOOT -#include -#include -#include -#endif #include +#ifndef CONFIG_HAS_DEVICE_TREE +# include +#endif +#include #ifdef CONFIG_HAS_DEVICE_TREE -# include # include +#else +#include #endif -#ifdef CONFIG_MULTIBOOT -int __init xsm_multiboot_policy_init( - unsigned long *module_map, const multiboot_info_t *mbi, - void **policy_buffer, size_t *policy_size) +#include + +#ifndef CONFIG_HAS_DEVICE_TREE +int __init xsm_bootmodule_policy_init( + const struct boot_info *bootinfo, const unsigned char **policy_buffer, + size_t *policy_size) { - int i; - module_t *mod = (module_t *)__va(mbi->mods_addr); - int rc = 0; + unsigned long i; + int rc = -ENOENT; u32 *_policy_start; unsigned long _policy_len; - /* - * Try all modules and see whichever could be the binary policy. - * Adjust module_map for the module that is the binary policy. - */ - for ( i = mbi->mods_count-1; i >= 1; i-- ) - { - if ( !test_bit(i, module_map) ) - continue; +#ifdef CONFIG_XSM_FLASK_POLICY + /* Initially set to builtin policy, overriden if boot module is found. */ + *policy_buffer = xsm_flask_init_policy; + *policy_size = xsm_flask_init_policy_size; + rc = 0; +#endif - _policy_start = bootstrap_map_multiboot(mod + i); - _policy_len = mod[i].mod_end; + i = bootmodule_index(bootinfo, BOOTMOD_UNKNOWN, 0); + while ( i < bootinfo->nr_mods ) + { + _policy_start = bootstrap_map(&bootinfo->mods[i]); + _policy_len = bootinfo->mods[i].size; if ( (xsm_magic_t)(*_policy_start) == XSM_MAGIC ) { - *policy_buffer = _policy_start; + *policy_buffer = (unsigned char *)_policy_start; *policy_size = _policy_len; printk("Policy len %#lx, start at %p.\n", _policy_len,_policy_start); - __clear_bit(i, module_map); + bootinfo->mods[i].bootmod_type = BOOTMOD_XSM; + rc = 0; break; } bootstrap_map(NULL); + i = bootmodule_index(bootinfo, BOOTMOD_UNKNOWN, ++i); } return rc; } -#endif -#ifdef CONFIG_HAS_DEVICE_TREE +#else + int __init xsm_dt_policy_init(void **policy_buffer, size_t *policy_size) { struct bootmodule *mod = boot_module_find_by_kind(BOOTMOD_XSM); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 01 07:19:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 07:19:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557776.871444 (Exim 4.92) (envelope-from ) id 1qFUsn-0007hy-BI; Sat, 01 Jul 2023 07:19:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557776.871444; Sat, 01 Jul 2023 07:19:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFUsm-0007fn-TN; Sat, 01 Jul 2023 07:19:00 +0000 Received: by outflank-mailman (input) for mailman id 557776; Sat, 01 Jul 2023 07:18:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFUsl-00074A-4k for xen-devel@lists.xenproject.org; Sat, 01 Jul 2023 07:18:59 +0000 Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [2607:f8b0:4864:20::733]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8ae6847b-17df-11ee-b237-6b7b168915f2; Sat, 01 Jul 2023 09:18:57 +0200 (CEST) Received: by mail-qk1-x733.google.com with SMTP id af79cd13be357-765a7768f1dso259805885a.0 for ; Sat, 01 Jul 2023 00:18:57 -0700 (PDT) Received: from cog-dev.home ([70.103.208.83]) by smtp.gmail.com with ESMTPSA id s19-20020aa78d53000000b00673e652985bsm4108866pfe.118.2023.07.01.00.18.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jul 2023 00:18:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 8ae6847b-17df-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688195936; x=1690787936; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=zZcp6XBY1YAC9oeotb5zJ/fGSdzt/Mx/a1Oe4w1mVBI=; b=ILmm9e/9lTp9GTg1saAsg7g1OS7yf4jCGZwg0akeM2mI0eRae5so14i3XdhUMh+qaa WvicC4epjfhJ1KgZeK/e5xz4jBIFr1AvNW1MB8zRZGTP3UqrTmEKUDwdJ7lYGNrL0kYo W7eJJCHmsS1p5VVGOTbmnt9B25qJIGISHnW/KS3zoRc6b0p5zTwjPDP1RlEkxvb9ai26 Ff3gpgsic09OIQkUbADqfAmHETGZJiy3Lm/8TvvJqr6fuh3R7hBi4Mqs8pY02gL+6K7m Q+oAco6AU+2LzNqpPKBAyn2krxQOaAyH+0px9DeXfCeULpV16sLShIA+hMsZgendVEpi DGjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688195936; x=1690787936; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zZcp6XBY1YAC9oeotb5zJ/fGSdzt/Mx/a1Oe4w1mVBI=; b=gMstzg2ZJq6aYPb2GEvCv8vqtB2zsXuRZIvehsreBf9UcaAXI5F3HvfgFGfrU6XGea G6+u38UvLdQDOfJecvHaFgDEFnOlXXsnparkLx3XXYQQTFAqzrzWPWf0jBhrJdJx2cYn gWbu/JPva7D6/oyTNHuBXbTJOU6/sFR2YWpYh7BYt5YT/VjJmJXcCcG1cY9An5ARexlQ xrtLWWcSk1PiTeL1dnZuhUQqnQKiJ8cvMoEO52T9up/psg3VrGvA/ba1E5DIZU2O/m4V y3gKZczkTL6bymO536zkmgvLZrnaDTHFnE19GcMuj/mfeat9A7NjxxIe3SeXw5+G+RW+ 4toQ== X-Gm-Message-State: AC+VfDzsuUMqzIcxBqUcyjhsOotH0TOLONiN8rttpgO2EFu0+vZZV8ez OWNB8X/AVzaR9h23vdp3gjxbnZqtBLI= X-Google-Smtp-Source: ACHHUZ6G4ziS9OlcacmAYXEWytMGOapbZ5lrvuY5UYngxSJMQYFoJYsz5UXL9WWUNXBnxHWZfGdaKA== X-Received: by 2002:a05:620a:450b:b0:767:2bb9:d187 with SMTP id t11-20020a05620a450b00b007672bb9d187mr6726381qkp.1.1688195936202; Sat, 01 Jul 2023 00:18:56 -0700 (PDT) Sender: Christopher Clark From: Christopher Clark To: xen-devel@lists.xenproject.org Cc: Daniel Smith , stefano.stabellini@amd.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Luca Fancellu , Volodymyr Babchuk , Rich Persaud Subject: [PATCH 06/10] x86 setup, microcode: switch to the new bootinfo structures Date: Sat, 1 Jul 2023 00:18:31 -0700 Message-Id: <20230701071835.41599-7-christopher.w.clark@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230701071835.41599-1-christopher.w.clark@gmail.com> References: <20230701071835.41599-1-christopher.w.clark@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Next step in incremental work towards adding a non-multiboot internal representation of boot modules, converting the fields being accessed for the startup calculations. Move the per-module scan logic into a dedicated function from the iteration loop and set the BOOTMOD_UCODE module type when microcode is found. Completes the conversion from the module_map bitmap in x86 setup so it can be removed, along with the temporary bootstrap_map multiboot wrapper since the last code that uses it is removed in this change. Signed-off-by: Christopher Clark Signed-off-by: Daniel P. Smith --- Changes since v1: patch is a subset of v1 series patches 2 and 3. - Added the removal of the temporary bootstrap map function xen/arch/x86/cpu/microcode/core.c | 148 +++++++++++++++------------ xen/arch/x86/include/asm/boot.h | 13 --- xen/arch/x86/include/asm/microcode.h | 7 +- xen/arch/x86/setup.c | 8 +- 4 files changed, 89 insertions(+), 87 deletions(-) diff --git a/xen/arch/x86/cpu/microcode/core.c b/xen/arch/x86/cpu/microcode/core.c index ce3c8042a2..d2cae9b6b4 100644 --- a/xen/arch/x86/cpu/microcode/core.c +++ b/xen/arch/x86/cpu/microcode/core.c @@ -22,12 +22,12 @@ */ #include +#include #include #include #include #include #include -#include #include #include #include @@ -57,7 +57,6 @@ */ #define MICROCODE_UPDATE_TIMEOUT_US 1000000 -static module_t __initdata ucode_mod; static signed int __initdata ucode_mod_idx; static bool_t __initdata ucode_mod_forced; static unsigned int nr_cores; @@ -150,75 +149,109 @@ static int __init cf_check parse_ucode(const char *s) } custom_param("ucode", parse_ucode); -void __init microcode_scan_module( - unsigned long *module_map, - const multiboot_info_t *mbi) +#define MICROCODE_MODULE_MATCH 1 +#define MICROCODE_MODULE_NONMATCH 0 + +static int __init microcode_check_module(struct boot_module *mod) { - module_t *mod = (module_t *)__va(mbi->mods_addr); uint64_t *_blob_start; unsigned long _blob_size; - struct cpio_data cd; + struct cpio_data cd = { NULL, 0 }; long offset; const char *p = NULL; - int i; - - ucode_blob.size = 0; - if ( !ucode_scan ) - return; if ( boot_cpu_data.x86_vendor == X86_VENDOR_AMD ) p = "kernel/x86/microcode/AuthenticAMD.bin"; else if ( boot_cpu_data.x86_vendor == X86_VENDOR_INTEL ) p = "kernel/x86/microcode/GenuineIntel.bin"; else + return -EFAULT; + + _blob_start = bootstrap_map(mod); + _blob_size = mod->size; + if ( !_blob_start ) + { + printk("Could not map multiboot module (0x%lx) (size: %ld)\n", + mod->start, _blob_size); + /* Non-fatal error, so just say no match */ + return MICROCODE_MODULE_NONMATCH; + } + + cd = find_cpio_data(p, _blob_start, _blob_size, &offset /* ignore */); + + if ( cd.data ) + { + ucode_blob.size = cd.size; + ucode_blob.data = cd.data; + + mod->bootmod_type = BOOTMOD_UCODE; + return MICROCODE_MODULE_MATCH; + } + + bootstrap_map(NULL); + + return MICROCODE_MODULE_NONMATCH; +} + +void __init microcode_scan_module(struct boot_info *bootinfo) +{ + int i; + + if ( !ucode_scan ) return; - /* - * Try all modules and see whichever could be the microcode blob. - */ - for ( i = 1 /* Ignore dom0 kernel */; i < mbi->mods_count; i++ ) + i = bootmodule_index(bootinfo, BOOTMOD_UNKNOWN, 0); + while ( i < bootinfo->nr_mods ) { - if ( !test_bit(i, module_map) ) - continue; + int ret = microcode_check_module(&bootinfo->mods[i]); - _blob_start = bootstrap_map_multiboot(&mod[i]); - _blob_size = mod[i].mod_end; - if ( !_blob_start ) + switch ( ret ) { - printk("Could not map multiboot module #%d (size: %ld)\n", - i, _blob_size); + case MICROCODE_MODULE_MATCH: + return; + case MICROCODE_MODULE_NONMATCH: + i = bootmodule_index(bootinfo, BOOTMOD_UNKNOWN, ++i); continue; + default: + printk("%s: (err: %d) unable to check microcode\n", + __func__, ret); + return; } - cd.data = NULL; - cd.size = 0; - cd = find_cpio_data(p, _blob_start, _blob_size, &offset /* ignore */); - if ( cd.data ) - { - ucode_blob.size = cd.size; - ucode_blob.data = cd.data; - break; - } - bootstrap_map(NULL); } } -static void __init microcode_grab_module( - unsigned long *module_map, - const multiboot_info_t *mbi) +static void __init microcode_grab_module(struct boot_info *bootinfo) { - module_t *mod = (module_t *)__va(mbi->mods_addr); + ucode_blob.size = 0; if ( ucode_mod_idx < 0 ) - ucode_mod_idx += mbi->mods_count; - if ( ucode_mod_idx <= 0 || ucode_mod_idx >= mbi->mods_count || - !__test_and_clear_bit(ucode_mod_idx, module_map) ) - goto scan; - ucode_mod = mod[ucode_mod_idx]; -scan: + ucode_mod_idx += bootinfo->nr_mods; + if ( ucode_mod_idx >= 0 && ucode_mod_idx <= bootinfo->nr_mods && + bootinfo->mods[ucode_mod_idx].bootmod_type == BOOTMOD_UNKNOWN ) + { + int ret = microcode_check_module(&bootinfo->mods[ucode_mod_idx]); + + switch ( ret ) + { + case MICROCODE_MODULE_MATCH: + return; + case MICROCODE_MODULE_NONMATCH: + break; + default: + printk("%s: (err: %d) unable to check microcode\n", + __func__, ret); + return; + } + } + if ( ucode_scan ) - microcode_scan_module(module_map, mbi); + microcode_scan_module(bootinfo); } +/* Undefining as they are not needed anymore */ +#undef MICROCODE_MODULE_MATCH +#undef MICROCODE_MODULE_NONMATCH + static struct microcode_ops __ro_after_init ucode_ops; static DEFINE_SPINLOCK(microcode_mutex); @@ -738,11 +771,6 @@ static int __init cf_check microcode_init(void) ucode_blob.size = 0; ucode_blob.data = NULL; } - else if ( ucode_mod.mod_end ) - { - bootstrap_map(NULL); - ucode_mod.mod_end = 0; - } return 0; } @@ -786,8 +814,7 @@ static int __init early_update_cache(const void *data, size_t len) return rc; } -int __init microcode_init_cache(unsigned long *module_map, - const struct multiboot_info *mbi) +int __init microcode_init_cache(struct boot_info *bootinfo) { int rc = 0; @@ -796,12 +823,9 @@ int __init microcode_init_cache(unsigned long *module_map, if ( ucode_scan ) /* Need to rescan the modules because they might have been relocated */ - microcode_scan_module(module_map, mbi); + microcode_scan_module(bootinfo); - if ( ucode_mod.mod_end ) - rc = early_update_cache(bootstrap_map_multiboot(&ucode_mod), - ucode_mod.mod_end); - else if ( ucode_blob.size ) + if ( ucode_blob.size ) rc = early_update_cache(ucode_blob.data, ucode_blob.size); return rc; @@ -819,11 +843,6 @@ static int __init early_microcode_update_cpu(void) len = ucode_blob.size; data = ucode_blob.data; } - else if ( ucode_mod.mod_end ) - { - len = ucode_mod.mod_end; - data = bootstrap_map_multiboot(&ucode_mod); - } if ( !data ) return -ENOMEM; @@ -842,8 +861,7 @@ static int __init early_microcode_update_cpu(void) return microcode_update_cpu(patch); } -int __init early_microcode_init(unsigned long *module_map, - const struct multiboot_info *mbi) +int __init early_microcode_init(struct boot_info *bootinfo) { const struct cpuinfo_x86 *c = &boot_cpu_data; int rc = 0; @@ -867,11 +885,11 @@ int __init early_microcode_init(unsigned long *module_map, return -ENODEV; } - microcode_grab_module(module_map, mbi); + microcode_grab_module(bootinfo); ucode_ops.collect_cpu_info(); - if ( ucode_mod.mod_end || ucode_blob.size ) + if ( ucode_blob.size ) rc = early_microcode_update_cpu(); return rc; diff --git a/xen/arch/x86/include/asm/boot.h b/xen/arch/x86/include/asm/boot.h index bcf4f2e2e3..e51fd32280 100644 --- a/xen/arch/x86/include/asm/boot.h +++ b/xen/arch/x86/include/asm/boot.h @@ -6,19 +6,6 @@ #include -static inline void *bootstrap_map_multiboot(const module_t *mod) -{ - struct boot_module bm; - - if ( !mod ) - return bootstrap_map(NULL); - - bm.start = mod->mod_start << PAGE_SHIFT; - bm.size = mod->mod_end; - - return bootstrap_map(&bm); -} - static inline unsigned long bootmodule_index( const struct boot_info *info, bootmod_type_t bootmod_type, unsigned long start) diff --git a/xen/arch/x86/include/asm/microcode.h b/xen/arch/x86/include/asm/microcode.h index 62ce3418f7..803fbbb270 100644 --- a/xen/arch/x86/include/asm/microcode.h +++ b/xen/arch/x86/include/asm/microcode.h @@ -1,6 +1,7 @@ #ifndef ASM_X86__MICROCODE_H #define ASM_X86__MICROCODE_H +#include #include #include @@ -23,10 +24,8 @@ DECLARE_PER_CPU(struct cpu_signature, cpu_sig); void microcode_set_module(unsigned int idx); int microcode_update(XEN_GUEST_HANDLE(const_void), unsigned long len); -int early_microcode_init(unsigned long *module_map, - const struct multiboot_info *mbi); -int microcode_init_cache(unsigned long *module_map, - const struct multiboot_info *mbi); +int early_microcode_init(struct boot_info *bootinfo); +int microcode_init_cache(struct boot_info *bootinfo); int microcode_update_one(void); #endif /* ASM_X86__MICROCODE_H */ diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index a616ccc0a8..50a1a124b0 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -1023,7 +1023,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) unsigned int initrdidx, num_parked = 0; multiboot_info_t *mbi; module_t *mod; - unsigned long nr_pages, raw_max_page, module_map[1]; + unsigned long nr_pages, raw_max_page; int i, j, e820_warn = 0, bytes = 0; unsigned long eb_start, eb_end; bool acpi_boot_table_init_done = false, relocated = false; @@ -1190,8 +1190,6 @@ void __init noreturn __start_xen(unsigned long mbi_p) } /* Dom0 kernel is the first boot module */ - bitmap_fill(module_map, mbi->mods_count); - __clear_bit(0, module_map); /* Dom0 kernel is always first */ boot_info->mods[0].bootmod_type = BOOTMOD_KERNEL; if ( pvh_boot ) @@ -1371,7 +1369,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) * TODO: load ucode earlier once multiboot modules become accessible * at an earlier stage. */ - early_microcode_init(module_map, mbi); + early_microcode_init(boot_info); if ( xen_phys_start ) { @@ -1906,7 +1904,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) timer_init(); - microcode_init_cache(module_map, mbi); /* Needs xmalloc() */ + microcode_init_cache(boot_info); /* Needs xmalloc() */ tsx_init(); /* Needs microcode. May change HLE/RTM feature bits. */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 01 07:19:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 07:19:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557778.871457 (Exim 4.92) (envelope-from ) id 1qFUso-00087N-JZ; Sat, 01 Jul 2023 07:19:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557778.871457; Sat, 01 Jul 2023 07:19:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFUso-00085r-A4; Sat, 01 Jul 2023 07:19:02 +0000 Received: by outflank-mailman (input) for mailman id 557778; Sat, 01 Jul 2023 07:19:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFUsm-0006No-Mf for xen-devel@lists.xenproject.org; Sat, 01 Jul 2023 07:19:00 +0000 Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [2607:f8b0:4864:20::22c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8b9c26ca-17df-11ee-8611-37d641c3527e; Sat, 01 Jul 2023 09:18:59 +0200 (CEST) Received: by mail-oi1-x22c.google.com with SMTP id 5614622812f47-3a3373211a1so1922940b6e.0 for ; Sat, 01 Jul 2023 00:18:58 -0700 (PDT) Received: from cog-dev.home ([70.103.208.83]) by smtp.gmail.com with ESMTPSA id s19-20020aa78d53000000b00673e652985bsm4108866pfe.118.2023.07.01.00.18.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jul 2023 00:18:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 8b9c26ca-17df-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688195937; x=1690787937; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=S6Cu78312/uyuTtWf3JY9jjpC+4RgagbuKLSP43QOoI=; b=UPbuVkZz1oAK/2LyG2d2Jw8INSlnXa/NlmFvB4kRqCC2gVqMidnQRphhgxR0TSHT+3 0s32mnwZ5C2MiyRI81PFiG2f3X7YsruBzmry+l2xRuxLJooDABjPUd+qXphVLrAW/B+y 6xxLai7iGBBcCRX9fk/IIKGyDalggyofNzF//yvHePzXSplMvL5ZaLhzY/JrPkWjxaqX D6SRMilMh4UjMDBVz35siAbBdhGqP/ThyZryTLkDquTjEDgVeLyQU2nu+7oabv4Fmg4k 02BmtpWmfzce0nwrfyeA5AltLslsexA90Qc7lLM01L0VCpHq2WUAfmBo/Jp4+3M2gjMV Vmjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688195937; x=1690787937; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=S6Cu78312/uyuTtWf3JY9jjpC+4RgagbuKLSP43QOoI=; b=RdSZPZBDpO2eSdqIUe7ETNoJ3aJ+B7n2f/NGW5SeC3KXHpcE/hC6pq6f92V+ZifejX ZiGjER0sfM9QcOuAZjlP0lGTGyGLh+uk3/VDk9o+KB4BL7qDl/mbpWVv+UYHkL23DSpv HWPtPmsDf9G9qKmj/CnrOiHUIG6qRBQ2zAEeI43J+DTj/T8J5x/zfGc76aYJYyHnxQpb WXqQB5D1Qn604Wf5+o+F0eo9xFaR4WfLtp0pPJvKLwdT5Hyzjfht7rFFjUaVWCTTILAH fRwYVSoOMIe3nbqfv4XgpSKkFP0O3gel7hpViWsq+IVfU4EVM1W+e8rRWMFIYupBJ4GY BODA== X-Gm-Message-State: AC+VfDw80XbqQGGoPB5ca8mtmc4/RHNjaWUeNCbB5xMoKJ/ADRIkMSb5 hJ8Gu2lhOLUkRVrrGiTiw4vtxwV2fqk= X-Google-Smtp-Source: ACHHUZ5bs2jo7O3BDp2NAaVYCHQcw/ounbIgX+But52KUkZXfA77A5ZAv/5/HHJcZPqmWMwDeEj4RQ== X-Received: by 2002:a05:6808:1917:b0:3a0:6949:c884 with SMTP id bf23-20020a056808191700b003a06949c884mr6924756oib.34.1688195937374; Sat, 01 Jul 2023 00:18:57 -0700 (PDT) Sender: Christopher Clark From: Christopher Clark To: xen-devel@lists.xenproject.org Cc: Daniel Smith , stefano.stabellini@amd.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Luca Fancellu , Volodymyr Babchuk , Rich Persaud Subject: [PATCH 07/10] x86 boot: define paddr_t and add macros for typedefing struct pointers Date: Sat, 1 Jul 2023 00:18:32 -0700 Message-Id: <20230701071835.41599-8-christopher.w.clark@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230701071835.41599-1-christopher.w.clark@gmail.com> References: <20230701071835.41599-1-christopher.w.clark@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Pointer fields within structs need to be defined as fixed size types in the x86 boot build environment. Using a typedef for the field type rather than a struct pointer type enables the type definition to be changed in the 32-bit boot build and the main hypervisor build, allowing for a single common structure definition and a common header file. Introduces DEFINE_STRUCT_PTR_TYPE and DEFINE_PTR_TYPE which will generate typedefs with a _ptr_t suffix for pointers to the specified type. This is then used in for pointers within structs as preparation for using these headers in the x86 boot build. The 32-bit behaviour is obtained by inclusion of "defs.h" first with a check for such an existing definition on the version. paddr_t is used in so a definition is added here to the x86 boot environment defs.h header. Signed-off-by: Christopher Clark Signed-off-by: Daniel P. Smith --- Changes since v2: This is two v2 patches merged into one for v3. Changes since v1: New in v2 of series. xen/arch/x86/boot/defs.h | 9 +++++++++ xen/arch/x86/include/asm/bootinfo.h | 4 +++- xen/include/xen/bootinfo.h | 9 +++++---- xen/include/xen/types.h | 11 +++++++++++ 4 files changed, 28 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/boot/defs.h b/xen/arch/x86/boot/defs.h index f9840044ec..bc0f1b5cf8 100644 --- a/xen/arch/x86/boot/defs.h +++ b/xen/arch/x86/boot/defs.h @@ -60,4 +60,13 @@ typedef u64 uint64_t; #define U16_MAX ((u16)(~0U)) #define UINT_MAX (~0U) +typedef unsigned long long paddr_t; + +#define DEFINE_STRUCT_PTR_TYPE(struct_name) \ + typedef uint64_t struct_name ## _ptr_t; + +#define DEFINE_PTR_TYPE(type) \ + typedef uint64_t type ## _ptr_t; +DEFINE_PTR_TYPE(char); + #endif /* __BOOT_DEFS_H__ */ diff --git a/xen/arch/x86/include/asm/bootinfo.h b/xen/arch/x86/include/asm/bootinfo.h index 30c27980e0..989fb7a1da 100644 --- a/xen/arch/x86/include/asm/bootinfo.h +++ b/xen/arch/x86/include/asm/bootinfo.h @@ -6,6 +6,7 @@ struct arch_bootmodule { uint32_t flags; unsigned headroom; }; +DEFINE_STRUCT_PTR_TYPE(arch_bootmodule); struct arch_boot_info { uint32_t flags; @@ -14,11 +15,12 @@ struct arch_boot_info { #define BOOTINFO_FLAG_X86_MEMMAP 1U << 6 #define BOOTINFO_FLAG_X86_LOADERNAME 1U << 9 - char *boot_loader_name; + char_ptr_t boot_loader_name; uint32_t mmap_length; paddr_t mmap_addr; }; +DEFINE_STRUCT_PTR_TYPE(arch_boot_info); struct __packed mb_memmap { uint32_t size; diff --git a/xen/include/xen/bootinfo.h b/xen/include/xen/bootinfo.h index 2f4284a91f..8389da4f72 100644 --- a/xen/include/xen/bootinfo.h +++ b/xen/include/xen/bootinfo.h @@ -35,17 +35,18 @@ struct boot_module { mfn_t mfn; size_t size; - struct arch_bootmodule *arch; + arch_bootmodule_ptr_t arch; struct boot_string string; }; +DEFINE_STRUCT_PTR_TYPE(boot_module); struct boot_info { - char *cmdline; + char_ptr_t cmdline; unsigned int nr_mods; - struct boot_module *mods; + boot_module_ptr_t mods; - struct arch_boot_info *arch; + arch_boot_info_ptr_t arch; }; #endif diff --git a/xen/include/xen/types.h b/xen/include/xen/types.h index 6aba80500a..e807ffe255 100644 --- a/xen/include/xen/types.h +++ b/xen/include/xen/types.h @@ -71,4 +71,15 @@ typedef bool bool_t; #define test_and_set_bool(b) xchg(&(b), true) #define test_and_clear_bool(b) xchg(&(b), false) +#ifndef DEFINE_STRUCT_PTR_TYPE +#define DEFINE_STRUCT_PTR_TYPE(struct_name) \ + typedef struct struct_name * struct_name ## _ptr_t; +#endif + +#ifndef DEFINE_PTR_TYPE +#define DEFINE_PTR_TYPE(type) \ + typedef type * type ## _ptr_t; +DEFINE_PTR_TYPE(char); +#endif + #endif /* __TYPES_H__ */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 01 07:19:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 07:19:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557779.871463 (Exim 4.92) (envelope-from ) id 1qFUsp-0008F6-6P; Sat, 01 Jul 2023 07:19:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557779.871463; Sat, 01 Jul 2023 07:19:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFUso-0008CO-Rw; Sat, 01 Jul 2023 07:19:02 +0000 Received: by outflank-mailman (input) for mailman id 557779; Sat, 01 Jul 2023 07:19:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFUsn-00074A-Me for xen-devel@lists.xenproject.org; Sat, 01 Jul 2023 07:19:01 +0000 Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [2607:f8b0:4864:20::22d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8cedc5e3-17df-11ee-b237-6b7b168915f2; Sat, 01 Jul 2023 09:19:01 +0200 (CEST) Received: by mail-oi1-x22d.google.com with SMTP id 5614622812f47-3a37909a64eso1780698b6e.1 for ; Sat, 01 Jul 2023 00:19:01 -0700 (PDT) Received: from cog-dev.home ([70.103.208.83]) by smtp.gmail.com with ESMTPSA id s19-20020aa78d53000000b00673e652985bsm4108866pfe.118.2023.07.01.00.18.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jul 2023 00:18:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 8cedc5e3-17df-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688195939; x=1690787939; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=RNpBclJ1QG7nOEKI0nkpyN963wBmUeNZP6vxgwU4hxE=; b=kkt/3rzfOezqwdUdfeP22+AXirxs+V7vl98qrWv4iiVvJsilE8IFJzXmBmEaX/PLUX lw/OLqRFNRDap66MC+0gdgpB/Ap2zXzSIBFEE0S+1g7Z5yE5mqysVH6CJTGwGKVvXCEv pcetQV5sppLEG8Tn/5o/JgQm7GVCRfWToQacCEtPstUhrfKSmOFvUkrebntKu44THLG8 GKi4rtOS+2hjrykz+X62a0+lZXAHzKPErnP1WmR5Zqpb7YJXCLmeOTih25cPXCfWOUld 15dFSnZ0YQrnqdx+nDhNAzqzmzceDG1UJXNK8uM7Q1G+2GSsRsRJ0BnjJL3igJL1Bmyt JXZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688195939; x=1690787939; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=RNpBclJ1QG7nOEKI0nkpyN963wBmUeNZP6vxgwU4hxE=; b=Vcml0c+Zwcyn1Hi3mZSxVUMiBbYKgXnlUcBF9h/Xj4YKuu4icXyQ9ZYH1VkBgVfANS D/xWXb03YoHyxtjEOH5z/1ABssV/LoOjG2nv0OAu41FcNMJmaLpa7EpqkUMUEjb45M6l oRqAD0ykz0nLNTCsAA3myN0Xw3IaH048xolTpPEbM27loL/7MUHA8nSGh+aKhxpFm+PR 2p1ag9q3J3ztQ3A2fpqzracsVipprANFhT7g3YufW7/UeTMWUXo/+kY9ua6ZVvmlw1Sg uCAuBJBRIkFl67d1XU+larkq7Zl4Nj2jnTyBWjh1I7Q1OAYMvgz4tmiY41AY4THypHpx LdKA== X-Gm-Message-State: AC+VfDznT4f16VH4NUrHOLSDSuy1UOU+Isd5cxug6CT9p7hw7iqjKnW2 S/el3BxJ77RRlSDhXmy06bXi+jBQpg0= X-Google-Smtp-Source: ACHHUZ5bYgzOgosZ6acapmMuq/fA7HvOVTh6FdoBs81Xwt7bcxLG96FryDU7aohNQTBeWJXvKMyaTg== X-Received: by 2002:a05:6808:140d:b0:3a1:aef1:bbf3 with SMTP id w13-20020a056808140d00b003a1aef1bbf3mr5761717oiv.23.1688195939678; Sat, 01 Jul 2023 00:18:59 -0700 (PDT) Sender: Christopher Clark From: Christopher Clark To: xen-devel@lists.xenproject.org Cc: Daniel Smith , stefano.stabellini@amd.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Luca Fancellu , Volodymyr Babchuk , Rich Persaud Subject: [PATCH 09/10] arm setup: use common integer-typed bootmod definition Date: Sat, 1 Jul 2023 00:18:34 -0700 Message-Id: <20230701071835.41599-10-christopher.w.clark@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230701071835.41599-1-christopher.w.clark@gmail.com> References: <20230701071835.41599-1-christopher.w.clark@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This change enables inclusion of in Arm builds, required for subsequent patches in this series. It replaces the enum definition of bootmodule_kind with bootmod_type_t as enums are not fixed size as needed for packed structs which are needed for boot structures in subsequent changes. Signed-off-by: Christopher Clark Signed-off-by: Daniel P. Smith --- New for v2 series. xen/arch/arm/include/asm/setup.h | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 19dc637d55..7e0598217a 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -3,6 +3,7 @@ #include #include +#include #include #define MIN_FDT_ALIGN 8 @@ -12,15 +13,7 @@ #define MAX_MODULES 32 /* Current maximum useful modules */ -typedef enum { - BOOTMOD_XEN, - BOOTMOD_FDT, - BOOTMOD_KERNEL, - BOOTMOD_RAMDISK, - BOOTMOD_XSM, - BOOTMOD_GUEST_DTB, - BOOTMOD_UNKNOWN -} bootmodule_kind; +typedef bootmod_type_t bootmodule_kind; enum membank_type { /* -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 01 07:19:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 07:19:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557780.871469 (Exim 4.92) (envelope-from ) id 1qFUsp-0008Pl-QP; Sat, 01 Jul 2023 07:19:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557780.871469; Sat, 01 Jul 2023 07:19:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFUsp-0008Mf-FC; Sat, 01 Jul 2023 07:19:03 +0000 Received: by outflank-mailman (input) for mailman id 557780; Sat, 01 Jul 2023 07:19:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFUsn-0006No-Mk for xen-devel@lists.xenproject.org; Sat, 01 Jul 2023 07:19:01 +0000 Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [2607:f8b0:4864:20::72d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8c2d35ba-17df-11ee-8611-37d641c3527e; Sat, 01 Jul 2023 09:18:59 +0200 (CEST) Received: by mail-qk1-x72d.google.com with SMTP id af79cd13be357-765a1690003so243658785a.0 for ; Sat, 01 Jul 2023 00:18:59 -0700 (PDT) Received: from cog-dev.home ([70.103.208.83]) by smtp.gmail.com with ESMTPSA id s19-20020aa78d53000000b00673e652985bsm4108866pfe.118.2023.07.01.00.18.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jul 2023 00:18:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 8c2d35ba-17df-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688195938; x=1690787938; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=+QhG22aQsFtoXwrbtiP3WpdRgLLL1OgLfVThRSuYPKs=; b=Xufe3eFixvp3WBnPziVs80DQh009NwLwQM6EmrmrWavtVCOa8YgwA9pfjao+cAXVas Kyh7NFdj2mutOKU6e/K9NmVnVRMHMvvsxAHM2H7s/wdfwNUJqty255GlKJlQCu5vQg96 yMvmF4cr8adBv12o8hV8+Gb6TT1qKi+BOtZsVa9JgUGb91VptVwDYhxigH7Plvht5kFk hQ/2poKjMCSRtoxMxmmCSgVCA1NxfbetFR38XRkeTHBaPjoW/7sJORRNsEHFsi/D9xsE bZgAsWrgM4RD3RrSSUWizUz9rFrt4Au3FDfBgUA6zCTlgR7lva9PPIsa/Ji9tGStjP2z jB/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688195938; x=1690787938; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+QhG22aQsFtoXwrbtiP3WpdRgLLL1OgLfVThRSuYPKs=; b=GSxg7PyvpWJqFMZpfXtx4qBks6uNAhGXozvuXZ2cZ1yfOOFu1QKtUHoMcvfqJJUt6r 4CORg7jPzuI8XbnNnt4uX3n46gBNqm+GtqQvIXgZVwrJsNJ1JFYldpCOVRmgvH9Tc1WL 7h7vRafMgsXrYxY1LH6GF66MDx+J7vgSADyiYd4qVscK+VT1G1degNTGXEt7nt557F2z Z+Qu3S8dGuQuv6lGiaRnHbKksNOSrHPtJEA71jo/tb35V9kWyeMslQw1uhMVHcku6ZOX Ij40XVFrHazidwcutEJgyvVDMa7gHCgt6yhU2kuY0JduptZXUEWy4guetiTBkd3mmmf3 3EYQ== X-Gm-Message-State: AC+VfDxSRZ4h6HhRklzePlI35OemwAa2XePstlp/6nqR88wmfhsIMGzZ LO3NDhPIfC0mEVC7O0ZkdojQ+PlZG2Q= X-Google-Smtp-Source: ACHHUZ6vQvz5edMFsBO0yDqxfBhGyFJGqYSD7CweucRlegb7fUq3Gfct1s2EEfK8Q/Zr5W+gSLpFLg== X-Received: by 2002:a05:620a:4010:b0:766:fa1f:4ea4 with SMTP id h16-20020a05620a401000b00766fa1f4ea4mr5546488qko.1.1688195938407; Sat, 01 Jul 2023 00:18:58 -0700 (PDT) Sender: Christopher Clark From: Christopher Clark To: xen-devel@lists.xenproject.org Cc: Daniel Smith , stefano.stabellini@amd.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Luca Fancellu , Volodymyr Babchuk , Rich Persaud Subject: [PATCH 08/10] x86, arm, riscv: add per-arch bootinfo headers Date: Sat, 1 Jul 2023 00:18:33 -0700 Message-Id: <20230701071835.41599-9-christopher.w.clark@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230701071835.41599-1-christopher.w.clark@gmail.com> References: <20230701071835.41599-1-christopher.w.clark@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Changes to ensure that inclusion of succeeds in each of the main archtecture builds and in the 32-bit early x86 boot build. The header contains structures that will be used in efi logic prior to the main start of Xen, so it needs to be suitable for inclusion in Arm source files. The same header will also be included in early x86 boot logic, where asm/* headers are not reachable, and so they cannot be transitively included, so a ifdef condition is needed to prevent an attempt to include from within in that case. The early x86 boot logic can then directly include via a specified directory path where it can be included successfully. Signed-off-by: Christopher Clark Signed-off-by: Daniel P. Smith --- New for v2 series. xen/arch/arm/include/asm/bootinfo.h | 20 ++++++++++++++++++++ xen/arch/riscv/include/asm/bootinfo.h | 20 ++++++++++++++++++++ xen/include/xen/bootinfo.h | 7 ++----- 3 files changed, 42 insertions(+), 5 deletions(-) create mode 100644 xen/arch/arm/include/asm/bootinfo.h create mode 100644 xen/arch/riscv/include/asm/bootinfo.h diff --git a/xen/arch/arm/include/asm/bootinfo.h b/xen/arch/arm/include/asm/bootinfo.h new file mode 100644 index 0000000000..5316c87a3d --- /dev/null +++ b/xen/arch/arm/include/asm/bootinfo.h @@ -0,0 +1,20 @@ +#ifndef __ARCH_ARM_BOOTINFO_H__ +#define __ARCH_ARM_BOOTINFO_H__ + +struct __packed arch_bootmodule { }; +DEFINE_STRUCT_PTR_TYPE(arch_bootmodule); + +struct __packed arch_boot_info { }; +DEFINE_STRUCT_PTR_TYPE(arch_boot_info); + +#endif + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/include/asm/bootinfo.h b/xen/arch/riscv/include/asm/bootinfo.h new file mode 100644 index 0000000000..5316c87a3d --- /dev/null +++ b/xen/arch/riscv/include/asm/bootinfo.h @@ -0,0 +1,20 @@ +#ifndef __ARCH_ARM_BOOTINFO_H__ +#define __ARCH_ARM_BOOTINFO_H__ + +struct __packed arch_bootmodule { }; +DEFINE_STRUCT_PTR_TYPE(arch_bootmodule); + +struct __packed arch_boot_info { }; +DEFINE_STRUCT_PTR_TYPE(arch_boot_info); + +#endif + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/include/xen/bootinfo.h b/xen/include/xen/bootinfo.h index 8389da4f72..bf5586a76b 100644 --- a/xen/include/xen/bootinfo.h +++ b/xen/include/xen/bootinfo.h @@ -5,11 +5,8 @@ #include #include -#ifdef CONFIG_X86 -#include -#else - struct arch_bootmodule { }; - struct arch_boot_info { }; +#if defined CONFIG_X86 || CONFIG_ARM || CONFIG_RISCV +# include #endif /* Boot module binary type / purpose */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 01 07:19:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 07:19:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557782.871489 (Exim 4.92) (envelope-from ) id 1qFUss-0000iV-He; Sat, 01 Jul 2023 07:19:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557782.871489; Sat, 01 Jul 2023 07:19:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFUss-0000hD-BG; Sat, 01 Jul 2023 07:19:06 +0000 Received: by outflank-mailman (input) for mailman id 557782; Sat, 01 Jul 2023 07:19:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFUsr-0006No-4Y for xen-devel@lists.xenproject.org; Sat, 01 Jul 2023 07:19:05 +0000 Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [2607:f8b0:4864:20::736]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8dd6c1a5-17df-11ee-8611-37d641c3527e; Sat, 01 Jul 2023 09:19:02 +0200 (CEST) Received: by mail-qk1-x736.google.com with SMTP id af79cd13be357-76243a787a7so258385885a.2 for ; Sat, 01 Jul 2023 00:19:02 -0700 (PDT) Received: from cog-dev.home ([70.103.208.83]) by smtp.gmail.com with ESMTPSA id s19-20020aa78d53000000b00673e652985bsm4108866pfe.118.2023.07.01.00.18.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jul 2023 00:19:00 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 8dd6c1a5-17df-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688195941; x=1690787941; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=kNW+AYrQKnLKNbbn3YFHqN8Eo0KMGaoZgm6SWc5V5+U=; b=qvF+gtJkoOs75NZJtm/YNXiKKQiLpYV8Y3dP7sx/ZVMfFQucgbJ4JPROG2R+wI/TQi a45pGXHMyaE0jPCw7+//2MUPsVP9KgAysnKEicYtp3WZovkZQQPlxCuA719HmyD74HO1 unyeo+6N4GSUUDY/sgkLbehx0YyLJ2o97ems715x8/oHTNjpivLHonYtCgMz+Q0f7+CG zAx4YUuqf3WfpkY1ZSzqlQWmphc6LSVZojpSYHpqBWmmCUsIMxlBuzfmJ2PJgkRqt/l5 7OJ6GJKmx+qSaaNCfsdhuOKIk2hhC33IzQkm6bAfGj9Zq+7GsSRBTlI48iWkpMGpNVIl +8iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688195941; x=1690787941; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kNW+AYrQKnLKNbbn3YFHqN8Eo0KMGaoZgm6SWc5V5+U=; b=LYMPLgOObjJDJQ9abW1bEqxVRVB0a0sJ6Q1OJ0TBjXzIU883r65zWgAxe0Dgj+9k+y ueKpRDY3oSJ3OlQFQKlp+Atnbfi/AJSLlRzFQemnaHpVsMvgaN/zJFJW1LMBC98caJ/3 pYcRNMlyZvolvTgHNXiVYAF6ZRggXbYC14lVOjQAkvD0J6ErTL7sMpiifq6LjwTfEI1H I7iLX/NG45aQpBSWKrV6NHxN14xom1ak/gyiYkCEqgsQCtcrF5NJvWqqWgNDqvRVAlor B8EGL/guAC5wEBgFpL7Jm0leR/pMXN8U6Es4q2ZHQcPwyg53ZUk7ixVE9zexQSMvRWqI Z3Cg== X-Gm-Message-State: AC+VfDw2h2rGKn68hsyPwWJY/EFLhzLRW1JQG+DcT7/BTS9HV6QKtL6g o94eiNEnQ+G9eAawjSpO7/uHLaFY3w0= X-Google-Smtp-Source: APBJJlFJOLvrQlTlbqeQdDwnW6s8Hbn/JAaopGLjUO8Ra0690Bt6OVuKd2cSZp766Vnno7X0T+4SJQ== X-Received: by 2002:a05:620a:2807:b0:767:382d:a203 with SMTP id f7-20020a05620a280700b00767382da203mr4959710qkp.36.1688195940769; Sat, 01 Jul 2023 00:19:00 -0700 (PDT) Sender: Christopher Clark From: Christopher Clark To: xen-devel@lists.xenproject.org Cc: Daniel Smith , stefano.stabellini@amd.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Luca Fancellu , Volodymyr Babchuk , Rich Persaud Subject: [PATCH 10/10] x86 setup: refactor efi, pvh and multiboot entrypoints to new boot info Date: Sat, 1 Jul 2023 00:18:35 -0700 Message-Id: <20230701071835.41599-11-christopher.w.clark@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230701071835.41599-1-christopher.w.clark@gmail.com> References: <20230701071835.41599-1-christopher.w.clark@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Previous commits added a transition point from multiboot v1 structures to the new boot info structures at the earliest common point for all the x86 entrypoints. The result is that each of the entrypoints would construct a multiboot v1 structure from the structures used by each entrypoint.  This meant that multiboot2, EFI, and PVH all converted their structures over to mutliboot v1 to only be converted again upon entering __start_xen(). This commit drops the translation function and moves the population of the new boot info structures down into the various entrypoints. This change increases the maximum number of boot modules accepted on the EFI entry path and the PVH entry path to the same fixed maximum number accepted via multiboot, making it common across all x86 entry points. Signed-off-by: Christopher Clark Signed-off-by: Daniel P. Smith --- Changes since v1: patch is based on v1 series patch 4. - use main bootinfo headers in boot logic instead of adding a 32-bit version - apply packing to boot structures here rather than in earlier changes - use a defined maximum number of boot modules rather than Kconfig'd variable xen/arch/arm/efi/efi-boot.h | 6 + xen/arch/x86/boot/defs.h | 1 + xen/arch/x86/boot/reloc.c | 192 +++++++++++++++------- xen/arch/x86/efi/efi-boot.h | 95 ++++++----- xen/arch/x86/guest/xen/pvh-boot.c | 64 +++++--- xen/arch/x86/include/asm/bootinfo.h | 7 +- xen/arch/x86/include/asm/guest/pvh-boot.h | 6 +- xen/arch/x86/setup.c | 73 +++----- xen/common/efi/boot.c | 4 +- xen/include/xen/bootinfo.h | 9 +- 10 files changed, 278 insertions(+), 179 deletions(-) diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h index bb64925d70..d931fe06ed 100644 --- a/xen/arch/arm/efi/efi-boot.h +++ b/xen/arch/arm/efi/efi-boot.h @@ -1003,6 +1003,12 @@ static void __init efi_arch_flush_dcache_area(const void *vaddr, UINTN size) __flush_dcache_area(vaddr, size); } +static struct boot_info __init *efi_arch_bootinfo_init(void) +{ + /* boot modules not currently in use on Arm so no init required here */ + return NULL; +} + /* * Local variables: * mode: C diff --git a/xen/arch/x86/boot/defs.h b/xen/arch/x86/boot/defs.h index bc0f1b5cf8..519ca4dae6 100644 --- a/xen/arch/x86/boot/defs.h +++ b/xen/arch/x86/boot/defs.h @@ -44,6 +44,7 @@ _x > _y ? _x : _y; }) #define _p(val) ((void *)(unsigned long)(val)) +#define _addr(val) ((unsigned long)(void *)(val)) #define tolower(c) ((c) | 0x20) diff --git a/xen/arch/x86/boot/reloc.c b/xen/arch/x86/boot/reloc.c index e22bb974bf..8a48572d5f 100644 --- a/xen/arch/x86/boot/reloc.c +++ b/xen/arch/x86/boot/reloc.c @@ -27,6 +27,8 @@ asm ( ); #include "defs.h" +#include "../include/asm/bootinfo.h" +#include "../../../include/xen/bootinfo.h" #include "../../../include/xen/multiboot.h" #include "../../../include/xen/multiboot2.h" @@ -138,65 +140,116 @@ static struct hvm_start_info *pvh_info_reloc(u32 in) return out; } -static multiboot_info_t *mbi_reloc(u32 mbi_in) +static struct boot_info *mbi_reloc(u32 mbi_in) { + const multiboot_info_t *mbi = _p(mbi_in); + struct boot_info *binfo; + struct arch_boot_info *arch_binfo; int i; - multiboot_info_t *mbi_out; + uint32_t ptr; - mbi_out = _p(copy_mem(mbi_in, sizeof(*mbi_out))); + ptr = alloc_mem(sizeof(*binfo)); + zero_mem(ptr, sizeof(*binfo)); + binfo = _p(ptr); - if ( mbi_out->flags & MBI_CMDLINE ) - mbi_out->cmdline = copy_string(mbi_out->cmdline); + ptr = alloc_mem(sizeof(*arch_binfo)); + zero_mem(ptr, sizeof(*arch_binfo)); + binfo->arch = ptr; + arch_binfo = _p(ptr); - if ( mbi_out->flags & MBI_MODULES ) + if ( mbi->flags & MBI_CMDLINE ) + { + ptr = copy_string(mbi->cmdline); + binfo->cmdline = ptr; + arch_binfo->flags |= BOOTINFO_FLAG_X86_CMDLINE; + } + + if ( mbi->flags & MBI_MODULES ) { module_t *mods; + struct boot_module *bi_mods; + struct arch_bootmodule *arch_bi_mods; + + /* + * We have to allocate one more module slot here. At some point + * __start_xen() may put Xen image placement into it. + */ + ptr = alloc_mem((mbi->mods_count + 1) * sizeof(*bi_mods)); + binfo->nr_mods = mbi->mods_count; + binfo->mods = ptr; + bi_mods = _p(ptr); - mbi_out->mods_addr = copy_mem(mbi_out->mods_addr, - mbi_out->mods_count * sizeof(module_t)); + ptr = alloc_mem((mbi->mods_count + 1) * sizeof(*arch_bi_mods)); + arch_bi_mods = _p(ptr); - mods = _p(mbi_out->mods_addr); + /* map the +1 allocated for Xen image */ + bi_mods[mbi->mods_count].arch = _addr(&arch_bi_mods[mbi->mods_count]); - for ( i = 0; i < mbi_out->mods_count; i++ ) + arch_binfo->flags |= BOOTINFO_FLAG_X86_MODULES; + + mods = _p(mbi->mods_addr); + + for ( i = 0; i < mbi->mods_count; i++ ) { + bi_mods[i].start = mods[i].mod_start; + bi_mods[i].size = mods[i].mod_end - mods[i].mod_start; + if ( mods[i].string ) - mods[i].string = copy_string(mods[i].string); + { + int j; + char *c = _p(mods[i].string); + + for ( j = 0; *c != '\0'; j++, c++ ) + bi_mods[i].string.bytes[j] = *c; + + bi_mods[i].string.len = j + 1; + } + + bi_mods[i].arch = _addr(&arch_bi_mods[i]); } } - if ( mbi_out->flags & MBI_MEMMAP ) - mbi_out->mmap_addr = copy_mem(mbi_out->mmap_addr, mbi_out->mmap_length); - - if ( mbi_out->flags & MBI_LOADERNAME ) - mbi_out->boot_loader_name = copy_string(mbi_out->boot_loader_name); + if ( mbi->flags & MBI_MEMMAP ) + { + arch_binfo->mmap_addr = copy_mem(mbi->mmap_addr, mbi->mmap_length); + arch_binfo->mmap_length = mbi->mmap_length; + arch_binfo->flags |= BOOTINFO_FLAG_X86_MEMMAP; + } - /* Mask features we don't understand or don't relocate. */ - mbi_out->flags &= (MBI_MEMLIMITS | - MBI_CMDLINE | - MBI_MODULES | - MBI_MEMMAP | - MBI_LOADERNAME); + if ( mbi->flags & MBI_LOADERNAME ) + { + ptr = copy_string(mbi->boot_loader_name); + arch_binfo->boot_loader_name = ptr; + arch_binfo->flags |= BOOTINFO_FLAG_X86_LOADERNAME; + } - return mbi_out; + return binfo; } -static multiboot_info_t *mbi2_reloc(uint32_t mbi_in, uint32_t video_out) +static struct boot_info *mbi2_reloc(uint32_t mbi_in, uint32_t video_out) { const multiboot2_fixed_t *mbi_fix = _p(mbi_in); const multiboot2_memory_map_t *mmap_src; const multiboot2_tag_t *tag; - module_t *mbi_out_mods = NULL; memory_map_t *mmap_dst; - multiboot_info_t *mbi_out; + struct boot_info *binfo; + struct arch_boot_info *arch_binfo; + struct boot_module *bi_mods; + struct arch_bootmodule *arch_bi_mods; #ifdef CONFIG_VIDEO struct boot_video_info *video = NULL; #endif u32 ptr; unsigned int i, mod_idx = 0; - ptr = alloc_mem(sizeof(*mbi_out)); - mbi_out = _p(ptr); - zero_mem(ptr, sizeof(*mbi_out)); + ptr = alloc_mem(sizeof(*binfo)); + zero_mem(ptr, sizeof(*binfo)); + binfo = _p(ptr); + + ptr = alloc_mem(sizeof(*arch_binfo)); + zero_mem(ptr, sizeof(*arch_binfo)); + binfo->arch = ptr; + arch_binfo = _p(ptr); /* Skip Multiboot2 information fixed part. */ ptr = ALIGN_UP(mbi_in + sizeof(*mbi_fix), MULTIBOOT2_TAG_ALIGN); @@ -206,21 +259,28 @@ static multiboot_info_t *mbi2_reloc(uint32_t mbi_in, uint32_t video_out) tag = _p(ALIGN_UP((u32)tag + tag->size, MULTIBOOT2_TAG_ALIGN)) ) { if ( tag->type == MULTIBOOT2_TAG_TYPE_MODULE ) - ++mbi_out->mods_count; + ++binfo->nr_mods; else if ( tag->type == MULTIBOOT2_TAG_TYPE_END ) break; } - if ( mbi_out->mods_count ) + if ( binfo->nr_mods ) { - mbi_out->flags |= MBI_MODULES; /* * We have to allocate one more module slot here. At some point * __start_xen() may put Xen image placement into it. */ - mbi_out->mods_addr = alloc_mem((mbi_out->mods_count + 1) * - sizeof(*mbi_out_mods)); - mbi_out_mods = _p(mbi_out->mods_addr); + ptr = alloc_mem((binfo->nr_mods + 1) * sizeof(*bi_mods)); + binfo->mods = ptr; + bi_mods = _p(ptr); + + ptr = alloc_mem((binfo->nr_mods + 1) * sizeof(*arch_bi_mods)); + arch_bi_mods = _p(ptr); + + /* map the +1 allocated for Xen image */ + bi_mods[binfo->nr_mods].arch = _addr(&arch_bi_mods[binfo->nr_mods]); + + arch_binfo->flags |= BOOTINFO_FLAG_X86_MODULES; } /* Skip Multiboot2 information fixed part. */ @@ -232,39 +292,42 @@ static multiboot_info_t *mbi2_reloc(uint32_t mbi_in, uint32_t video_out) switch ( tag->type ) { case MULTIBOOT2_TAG_TYPE_BOOT_LOADER_NAME: - mbi_out->flags |= MBI_LOADERNAME; ptr = get_mb2_string(tag, string, string); - mbi_out->boot_loader_name = copy_string(ptr); + arch_binfo->boot_loader_name = copy_string(ptr); + arch_binfo->flags |= BOOTINFO_FLAG_X86_LOADERNAME; break; case MULTIBOOT2_TAG_TYPE_CMDLINE: - mbi_out->flags |= MBI_CMDLINE; ptr = get_mb2_string(tag, string, string); - mbi_out->cmdline = copy_string(ptr); + binfo->cmdline = copy_string(ptr); + arch_binfo->flags |= BOOTINFO_FLAG_X86_CMDLINE; break; case MULTIBOOT2_TAG_TYPE_BASIC_MEMINFO: - mbi_out->flags |= MBI_MEMLIMITS; - mbi_out->mem_lower = get_mb2_data(tag, basic_meminfo, mem_lower); - mbi_out->mem_upper = get_mb2_data(tag, basic_meminfo, mem_upper); + arch_binfo->mem_lower = get_mb2_data(tag, basic_meminfo, + mem_lower); + arch_binfo->mem_upper = get_mb2_data(tag, basic_meminfo, + mem_upper); break; case MULTIBOOT2_TAG_TYPE_MMAP: if ( get_mb2_data(tag, mmap, entry_size) < sizeof(*mmap_src) ) break; - mbi_out->flags |= MBI_MEMMAP; - mbi_out->mmap_length = get_mb2_data(tag, mmap, size); - mbi_out->mmap_length -= sizeof(multiboot2_tag_mmap_t); - mbi_out->mmap_length /= get_mb2_data(tag, mmap, entry_size); - mbi_out->mmap_length *= sizeof(*mmap_dst); + arch_binfo->mmap_length = get_mb2_data(tag, mmap, size); + arch_binfo->mmap_length -= sizeof(multiboot2_tag_mmap_t); + arch_binfo->mmap_length /= get_mb2_data(tag, mmap, entry_size); + arch_binfo->mmap_length *= sizeof(*mmap_dst); - mbi_out->mmap_addr = alloc_mem(mbi_out->mmap_length); + arch_binfo->mmap_addr = alloc_mem(arch_binfo->mmap_length); + arch_binfo->flags |= BOOTINFO_FLAG_X86_MEMMAP; mmap_src = get_mb2_data(tag, mmap, entries); - mmap_dst = _p(mbi_out->mmap_addr); + mmap_dst = _p(arch_binfo->mmap_addr); - for ( i = 0; i < mbi_out->mmap_length / sizeof(*mmap_dst); i++ ) + for ( i = 0; + i < arch_binfo->mmap_length / sizeof(*mmap_dst); + i++ ) { /* Init size member properly. */ mmap_dst[i].size = sizeof(*mmap_dst); @@ -280,14 +343,27 @@ static multiboot_info_t *mbi2_reloc(uint32_t mbi_in, uint32_t video_out) break; case MULTIBOOT2_TAG_TYPE_MODULE: - if ( mod_idx >= mbi_out->mods_count ) + if ( mod_idx >= binfo->nr_mods ) break; - mbi_out_mods[mod_idx].mod_start = get_mb2_data(tag, module, mod_start); - mbi_out_mods[mod_idx].mod_end = get_mb2_data(tag, module, mod_end); + bi_mods[mod_idx].start = get_mb2_data(tag, module, mod_start); + bi_mods[mod_idx].size = get_mb2_data(tag, module, mod_end) + - bi_mods[mod_idx].start; + ptr = get_mb2_string(tag, module, cmdline); - mbi_out_mods[mod_idx].string = copy_string(ptr); - mbi_out_mods[mod_idx].reserved = 0; + if ( ptr ) + { + int i; + char *c = _p(ptr); + + for ( i = 0; *c != '\0'; i++, c++ ) + bi_mods[mod_idx].string.bytes[i] = *c; + + bi_mods[mod_idx].string.len = i + 1; + } + + bi_mods[mod_idx].arch = _addr(&arch_bi_mods[mod_idx]); + ++mod_idx; break; @@ -344,11 +420,11 @@ static multiboot_info_t *mbi2_reloc(uint32_t mbi_in, uint32_t video_out) video->orig_video_isVGA = 0x23; #endif - return mbi_out; + return binfo; } -void *__stdcall reloc(uint32_t magic, uint32_t in, uint32_t trampoline, - uint32_t video_info) +void *__stdcall reloc( + uint32_t magic, uint32_t in, uint32_t trampoline, uint32_t video_info) { alloc = trampoline; diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h index 64c1a02cf1..c05759b761 100644 --- a/xen/arch/x86/efi/efi-boot.h +++ b/xen/arch/x86/efi/efi-boot.h @@ -11,14 +11,17 @@ #include static struct file __initdata ucode; -static multiboot_info_t __initdata mbi = { - .flags = MBI_MODULES | MBI_LOADERNAME -}; + +static struct boot_info __initdata efi_bi; +static struct arch_boot_info __initdata efi_bi_arch; /* * The array size needs to be one larger than the number of modules we * support - see __start_xen(). */ -static module_t __initdata mb_modules[5]; +static struct boot_module __initdata efi_mods[MAX_NR_BOOTMODS + 1]; +static struct arch_bootmodule __initdata efi_arch_mods[MAX_NR_BOOTMODS + 1]; + +static const char *__initdata efi_loader = "PVH Directboot"; static void __init edd_put_string(u8 *dst, size_t n, const char *src) { @@ -271,20 +274,37 @@ static void __init noreturn efi_arch_post_exit_boot(void) : [cr3] "r" (idle_pg_table), [cs] "i" (__HYPERVISOR_CS), [ds] "r" (__HYPERVISOR_DS), - "D" (&mbi) + "D" (&efi_bi) : "memory" ); unreachable(); } -static void __init efi_arch_cfg_file_early(const EFI_LOADED_IMAGE *image, - EFI_FILE_HANDLE dir_handle, - const char *section) +static struct boot_info __init *efi_arch_bootinfo_init(void) { + int i; + + efi_bi.arch = &efi_bi_arch; + efi_bi.mods = efi_mods; + + for ( i=0; i <= MAX_NR_BOOTMODS; i++ ) + efi_bi.mods[i].arch = &efi_arch_mods[i]; + + efi_bi_arch.boot_loader_name = _p(efi_loader); + + efi_bi_arch.flags = BOOTINFO_FLAG_X86_MODULES | + BOOTINFO_FLAG_X86_LOADERNAME; + return &efi_bi; } -static void __init efi_arch_cfg_file_late(const EFI_LOADED_IMAGE *image, - EFI_FILE_HANDLE dir_handle, - const char *section) +static void __init efi_arch_cfg_file_early( + const EFI_LOADED_IMAGE *image, EFI_FILE_HANDLE dir_handle, + const char *section) +{ +} + +static void __init efi_arch_cfg_file_late( + const EFI_LOADED_IMAGE *image, EFI_FILE_HANDLE dir_handle, + const char *section) { union string name; @@ -296,16 +316,15 @@ static void __init efi_arch_cfg_file_late(const EFI_LOADED_IMAGE *image, name.s = get_value(&cfg, "global", "ucode"); if ( name.s ) { - microcode_set_module(mbi.mods_count); + microcode_set_module(efi_bi.nr_mods); split_string(name.s); read_file(dir_handle, s2w(&name), &ucode, NULL); efi_bs->FreePool(name.w); } } -static void __init efi_arch_handle_cmdline(CHAR16 *image_name, - CHAR16 *cmdline_options, - const char *cfgfile_options) +static void __init efi_arch_handle_cmdline( + CHAR16 *image_name, CHAR16 *cmdline_options, const char *cfgfile_options) { union string name; @@ -313,10 +332,10 @@ static void __init efi_arch_handle_cmdline(CHAR16 *image_name, { name.w = cmdline_options; w2s(&name); - place_string(&mbi.cmdline, name.s); + place_string((uint32_t *)efi_bi.cmdline, name.s); } if ( cfgfile_options ) - place_string(&mbi.cmdline, cfgfile_options); + place_string((uint32_t *)efi_bi.cmdline, cfgfile_options); /* Insert image name last, as it gets prefixed to the other options. */ if ( image_name ) { @@ -325,16 +344,10 @@ static void __init efi_arch_handle_cmdline(CHAR16 *image_name, } else name.s = "xen"; - place_string(&mbi.cmdline, name.s); + place_string((uint32_t *)efi_bi.cmdline, name.s); - if ( mbi.cmdline ) - mbi.flags |= MBI_CMDLINE; - /* - * These must not be initialized statically, since the value must - * not get relocated when processing base relocations later. - */ - mbi.boot_loader_name = (long)"EFI"; - mbi.mods_addr = (long)mb_modules; + if ( efi_bi.cmdline ) + efi_bi_arch.flags |= BOOTINFO_FLAG_X86_CMDLINE; } static void __init efi_arch_edd(void) @@ -704,9 +717,8 @@ static void __init efi_arch_memory_setup(void) #undef l2_4G_offset } -static void __init efi_arch_handle_module(const struct file *file, - const CHAR16 *name, - const char *options) +static void __init efi_arch_handle_module( + const struct file *file, const CHAR16 *name, const char *options) { union string local_name; void *ptr; @@ -724,17 +736,24 @@ static void __init efi_arch_handle_module(const struct file *file, w2s(&local_name); /* - * If options are provided, put them in - * mb_modules[mbi.mods_count].string after the filename, with a space - * separating them. place_string() prepends strings and adds separating - * spaces, so the call order is reversed. + * Set module string to filename and if options are provided, put them in + * after the filename, with a space separating them. */ + strlcpy(efi_bi.mods[efi_bi.nr_mods].string.bytes, local_name.s, + BOOTMOD_STRING_MAX_LEN); if ( options ) - place_string(&mb_modules[mbi.mods_count].string, options); - place_string(&mb_modules[mbi.mods_count].string, local_name.s); - mb_modules[mbi.mods_count].mod_start = file->addr >> PAGE_SHIFT; - mb_modules[mbi.mods_count].mod_end = file->size; - ++mbi.mods_count; + { + strlcat(efi_bi.mods[efi_bi.nr_mods].string.bytes, " ", + BOOTMOD_STRING_MAX_LEN); + strlcat(efi_bi.mods[efi_bi.nr_mods].string.bytes, options, + BOOTMOD_STRING_MAX_LEN); + } + + efi_bi.mods[efi_bi.nr_mods].start = file->addr; + efi_bi.mods[efi_bi.nr_mods].mfn = maddr_to_mfn(file->addr); + efi_bi.mods[efi_bi.nr_mods].size = file->size; + + ++efi_bi.nr_mods; efi_bs->FreePool(ptr); } diff --git a/xen/arch/x86/guest/xen/pvh-boot.c b/xen/arch/x86/guest/xen/pvh-boot.c index 1ed04d035c..dd10a358da 100644 --- a/xen/arch/x86/guest/xen/pvh-boot.c +++ b/xen/arch/x86/guest/xen/pvh-boot.c @@ -6,6 +6,7 @@ * * Copyright (c) 2017 Citrix Systems Ltd. */ +#include #include #include #include @@ -20,12 +21,28 @@ bool __initdata pvh_boot; uint32_t __initdata pvh_start_info_pa; -static multiboot_info_t __initdata pvh_mbi; -static module_t __initdata pvh_mbi_mods[8]; -static const char *__initdata pvh_loader = "PVH Directboot"; +static struct boot_info __initdata pvh_bi; +static struct arch_boot_info __initdata arch_pvh_bi; +static struct boot_module __initdata pvh_mods[MAX_NR_BOOTMODS + 1]; +static struct arch_bootmodule __initdata arch_pvh_mods[MAX_NR_BOOTMODS + 1]; +static char __initdata *pvh_loader = "PVH Directboot"; -static void __init convert_pvh_info(multiboot_info_t **mbi, - module_t **mod) +static struct boot_info __init *init_pvh_info(void) +{ + int i; + + pvh_bi.arch = &arch_pvh_bi; + pvh_bi.mods = pvh_mods; + + for ( i=0; i <= MAX_NR_BOOTMODS; i++ ) + pvh_bi.mods[i].arch = &arch_pvh_mods[i]; + + pvh_bi.arch->boot_loader_name = pvh_loader; + + return &pvh_bi; +} + +static void __init convert_pvh_info(struct boot_info *bi) { const struct hvm_start_info *pvh_info = __va(pvh_start_info_pa); const struct hvm_modlist_entry *entry; @@ -39,23 +56,22 @@ static void __init convert_pvh_info(multiboot_info_t **mbi, * required. The extra element is used to aid relocation. See * arch/x86/setup.c:__start_xen(). */ - if ( ARRAY_SIZE(pvh_mbi_mods) <= pvh_info->nr_modules ) + if ( ARRAY_SIZE(pvh_mods) <= pvh_info->nr_modules ) panic("The module array is too small, size %zu, requested %u\n", - ARRAY_SIZE(pvh_mbi_mods), pvh_info->nr_modules); + ARRAY_SIZE(pvh_mods), pvh_info->nr_modules); /* * Turn hvm_start_info into mbi. Luckily all modules are placed under 4GB * boundary on x86. */ - pvh_mbi.flags = MBI_CMDLINE | MBI_MODULES | MBI_LOADERNAME; + bi->arch->flags = BOOTINFO_FLAG_X86_CMDLINE | BOOTINFO_FLAG_X86_MODULES + | BOOTINFO_FLAG_X86_LOADERNAME; BUG_ON(pvh_info->cmdline_paddr >> 32); - pvh_mbi.cmdline = pvh_info->cmdline_paddr; - pvh_mbi.boot_loader_name = __pa(pvh_loader); + bi->cmdline = _p(__va(pvh_info->cmdline_paddr)); - BUG_ON(pvh_info->nr_modules >= ARRAY_SIZE(pvh_mbi_mods)); - pvh_mbi.mods_count = pvh_info->nr_modules; - pvh_mbi.mods_addr = __pa(pvh_mbi_mods); + BUG_ON(pvh_info->nr_modules >= ARRAY_SIZE(pvh_mods)); + bi->nr_mods = pvh_info->nr_modules; entry = __va(pvh_info->modlist_paddr); for ( i = 0; i < pvh_info->nr_modules; i++ ) @@ -63,15 +79,18 @@ static void __init convert_pvh_info(multiboot_info_t **mbi, BUG_ON(entry[i].paddr >> 32); BUG_ON(entry[i].cmdline_paddr >> 32); - pvh_mbi_mods[i].mod_start = entry[i].paddr; - pvh_mbi_mods[i].mod_end = entry[i].paddr + entry[i].size; - pvh_mbi_mods[i].string = entry[i].cmdline_paddr; + bi->mods[i].start = entry[i].paddr; + bi->mods[i].size = entry[i].size; + if ( entry[i].cmdline_paddr) + { + char *c = _p(__va(entry[i].cmdline_paddr)); + + safe_strcpy(bi->mods[i].string.bytes, c); + bi->mods[i].string.kind = BOOTSTR_CMDLINE; + } } rsdp_hint = pvh_info->rsdp_paddr; - - *mbi = &pvh_mbi; - *mod = pvh_mbi_mods; } static void __init get_memory_map(void) @@ -88,13 +107,16 @@ static void __init get_memory_map(void) sanitize_e820_map(e820_raw.map, &e820_raw.nr_map); } -void __init pvh_init(multiboot_info_t **mbi, module_t **mod) +void __init pvh_init(struct boot_info **bi) { - convert_pvh_info(mbi, mod); + *bi = init_pvh_info(); + convert_pvh_info(*bi); hypervisor_probe(); ASSERT(xen_guest); + (*bi)->arch->xen_guest = xen_guest; + get_memory_map(); } diff --git a/xen/arch/x86/include/asm/bootinfo.h b/xen/arch/x86/include/asm/bootinfo.h index 989fb7a1da..c1ed76fd3e 100644 --- a/xen/arch/x86/include/asm/bootinfo.h +++ b/xen/arch/x86/include/asm/bootinfo.h @@ -1,14 +1,14 @@ #ifndef __ARCH_X86_BOOTINFO_H__ #define __ARCH_X86_BOOTINFO_H__ -struct arch_bootmodule { +struct __packed arch_bootmodule { #define BOOTMOD_FLAG_X86_RELOCATED 1U << 0 uint32_t flags; unsigned headroom; }; DEFINE_STRUCT_PTR_TYPE(arch_bootmodule); -struct arch_boot_info { +struct __packed arch_boot_info { uint32_t flags; #define BOOTINFO_FLAG_X86_CMDLINE 1U << 2 #define BOOTINFO_FLAG_X86_MODULES 1U << 3 @@ -17,6 +17,9 @@ struct arch_boot_info { char_ptr_t boot_loader_name; + uint32_t mem_lower; + uint32_t mem_upper; + uint32_t mmap_length; paddr_t mmap_addr; }; diff --git a/xen/arch/x86/include/asm/guest/pvh-boot.h b/xen/arch/x86/include/asm/guest/pvh-boot.h index 247ba6899e..c820b0bf88 100644 --- a/xen/arch/x86/include/asm/guest/pvh-boot.h +++ b/xen/arch/x86/include/asm/guest/pvh-boot.h @@ -8,13 +8,13 @@ #ifndef __X86_PVH_BOOT_H__ #define __X86_PVH_BOOT_H__ -#include +#include #ifdef CONFIG_PVH_GUEST extern bool pvh_boot; -void pvh_init(multiboot_info_t **mbi, module_t **mod); +void __init pvh_init(struct boot_info **bi); void pvh_print_info(void); #else @@ -23,7 +23,7 @@ void pvh_print_info(void); #define pvh_boot 0 -static inline void pvh_init(multiboot_info_t **mbi, module_t **mod) +static inline void __init pvh_init(struct boot_info **bi) { ASSERT_UNREACHABLE(); } diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 50a1a124b0..05a76a5959 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -13,7 +13,6 @@ #include #include #include -#include #include #include #include @@ -60,9 +59,6 @@ #include #include -/* Max number of boot modules a bootloader can provide in addition to Xen */ -#define MAX_NR_BOOTMODS 63 - /* opt_nosmp: If true, secondary processors are ignored. */ static bool __initdata opt_nosmp; boolean_param("nosmp", opt_nosmp); @@ -275,46 +271,6 @@ custom_param("acpi", parse_acpi_param); static struct boot_info __initdata *boot_info; -static void __init multiboot_to_bootinfo(multiboot_info_t *mbi, module_t *mods) -{ - static struct boot_info __initdata info; - static struct arch_boot_info __initdata arch_info; - static struct boot_module __initdata boot_mods[MAX_NR_BOOTMODS + 1]; - static struct arch_bootmodule __initdata arch_boot_mods[ - MAX_NR_BOOTMODS + 1]; - - int i; - - info.arch = &arch_info; - info.mods = boot_mods; - - info.cmdline = __va(mbi->cmdline); - - /* The BOOTINFO_FLAG_X86_* flags are a 1-1 map to MBI_* */ - arch_info.flags = mbi->flags; - arch_info.mmap_length = mbi->mmap_length; - arch_info.mmap_addr = mbi->mmap_addr; - arch_info.boot_loader_name = __va(mbi->boot_loader_name); - - info.nr_mods = mbi->mods_count; - for ( i = 0; i <= MAX_NR_BOOTMODS; i++ ) - { - boot_mods[i].arch = &arch_boot_mods[i]; - - if ( i < info.nr_mods ) - { - bootmodule_update_start(&boot_mods[i], mods[i].mod_start); - boot_mods[i].size = mods[i].mod_end - mods[i].mod_start; - - boot_mods[i].string.len = strlcpy(boot_mods[i].string.bytes, - __va(mods[i].string), - BOOTMOD_STRING_MAX_LEN); - } - } - - boot_info = &info; -} - unsigned long __init initial_images_nrpages(nodeid_t node) { unsigned long node_start = node_start_pfn(node); @@ -1014,15 +970,13 @@ static struct domain *__init create_dom0(const struct boot_info *bootinfo, /* How much of the directmap is prebuilt at compile time. */ #define PREBUILT_MAP_LIMIT (1 << L2_PAGETABLE_SHIFT) -void __init noreturn __start_xen(unsigned long mbi_p) +void __init noreturn __start_xen(unsigned long bi_p) { char *memmap_type = NULL; char *cmdline, *kextra, *loader; void *bsp_stack; struct cpu_info *info = get_cpu_info(), *bsp_info; unsigned int initrdidx, num_parked = 0; - multiboot_info_t *mbi; - module_t *mod; unsigned long nr_pages, raw_max_page; int i, j, e820_warn = 0, bytes = 0; unsigned long eb_start, eb_end; @@ -1059,16 +1013,29 @@ void __init noreturn __start_xen(unsigned long mbi_p) if ( pvh_boot ) { - ASSERT(mbi_p == 0); - pvh_init(&mbi, &mod); + ASSERT(bi_p == 0); + pvh_init(&boot_info); } else { - mbi = __va(mbi_p); - mod = __va(mbi->mods_addr); - } + /* + * Since addresses were setup before virtual addressing was enabled, + * fixup pointers to virtual addresses for proper dereferencing. + */ + boot_info = __va(bi_p); + boot_info->cmdline = __va(boot_info->cmdline); + boot_info->mods = __va(boot_info->mods); + boot_info->arch = __va(boot_info->arch); + + boot_info->arch->boot_loader_name = + __va(boot_info->arch->boot_loader_name); - multiboot_to_bootinfo(mbi, mod); + for ( i = 0; i <= boot_info->nr_mods; i++ ) + { + boot_info->mods[i].mfn = maddr_to_mfn(boot_info->mods[i].start); + boot_info->mods[i].arch = __va(boot_info->mods[i].arch); + } + } loader = (boot_info->arch->flags & BOOTINFO_FLAG_X86_LOADERNAME) ? boot_info->arch->boot_loader_name : "unknown"; diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index c5850c26af..09b38b497c 100644 --- a/xen/common/efi/boot.c +++ b/xen/common/efi/boot.c @@ -3,6 +3,7 @@ #include #include #include +#include #include #include #include @@ -11,7 +12,6 @@ #include #include #include -#include #include #include #include @@ -1359,6 +1359,8 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable) efi_arch_relocate_image(0); + efi_arch_bootinfo_init(); + if ( use_cfg_file ) { EFI_FILE_HANDLE dir_handle; diff --git a/xen/include/xen/bootinfo.h b/xen/include/xen/bootinfo.h index bf5586a76b..6e09be6899 100644 --- a/xen/include/xen/bootinfo.h +++ b/xen/include/xen/bootinfo.h @@ -20,13 +20,16 @@ #define BOOTMOD_GUEST_DTB 7 typedef unsigned int bootmod_type_t; +/* Max number of boot modules a bootloader can provide in addition to Xen */ +#define MAX_NR_BOOTMODS 63 + #define BOOTMOD_STRING_MAX_LEN 1024 -struct boot_string { +struct __packed boot_string { char bytes[BOOTMOD_STRING_MAX_LEN]; size_t len; }; -struct boot_module { +struct __packed boot_module { bootmod_type_t bootmod_type; paddr_t start; mfn_t mfn; @@ -37,7 +40,7 @@ struct boot_module { }; DEFINE_STRUCT_PTR_TYPE(boot_module); -struct boot_info { +struct __packed boot_info { char_ptr_t cmdline; unsigned int nr_mods; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 01 07:53:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 07:53:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557822.871500 (Exim 4.92) (envelope-from ) id 1qFVQC-0008Ib-Ou; Sat, 01 Jul 2023 07:53:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557822.871500; Sat, 01 Jul 2023 07:53:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFVQC-0008IU-KP; Sat, 01 Jul 2023 07:53:32 +0000 Received: by outflank-mailman (input) for mailman id 557822; Sat, 01 Jul 2023 07:53:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFVQA-0008IO-Kh for xen-devel@lists.xenproject.org; Sat, 01 Jul 2023 07:53:30 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5c5acd9a-17e4-11ee-b237-6b7b168915f2; Sat, 01 Jul 2023 09:53:28 +0200 (CEST) Received: from mail-dm6nam12lp2177.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 01 Jul 2023 03:53:24 -0400 Received: from BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) by BN9PR03MB6025.namprd03.prod.outlook.com (2603:10b6:408:136::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Sat, 1 Jul 2023 07:53:21 +0000 Received: from BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::7ebd:898:4cb0:7514]) by BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::7ebd:898:4cb0:7514%5]) with mapi id 15.20.6544.024; Sat, 1 Jul 2023 07:53:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5c5acd9a-17e4-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1688198008; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=4lipXHd/Hd/oIj7zAyXeYQkzzuPBre6U7XzivX0UrBA=; b=S7amrrL9g17O4JBKCDiaI+e/VUqc62VJ9EcwNELsEs7GKOCir/XMJCeR WRGW+MaKApbt6c6YkdOUk5LiWEiUmCK08VYY6mwqFTSpcFJPbkJyimosC kFANABhUVlVYvEslE8245FH4AV274/o1heMLizYogNAyFOcD+lf6F+LNT Y=; X-IronPort-RemoteIP: 104.47.59.177 X-IronPort-MID: 115250894 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:HuesEKijBmDzlOfJHI4gIsV4X161UBAKZh0ujC45NGQN5FlHY01je htvWW3SbvmKMzf8eI0kO47goU5SsZ7RydFqQAFr+ys1Hi8b9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsx+qyr0N8klgZmP6sT4gSGzyJ94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQ6MhIDVxOn2djn+624auNXh+0THNH0adZ3VnFIlVk1DN4AaLWaGeDmwIEd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEgluGyb7I5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6TeTlrKMy0AzProAVIEJLWmKf5uegth6FV+lPA nwb/A0vjLdnoSRHSfG4BXVUukWsugMXUpxeGusx5QWJ14Ld+QPfDW8BJhZRZdpjuMIoSDgC0 l6Sg8ivFTFpqKeSS3+W6vGTtzzaETcYLCkJZSICZQIf5p/op4RbphDFQ8tnEaW1psboAjy2y DePxAA8mrESgMgjx6i9u1fdjFqEvYPVRwQ44gHWWGON7Q5jYoOhIYuy5jDz8vJoPIufCF6bs xAsu8WY9vFIMpiLmwSEWuBLF7asj96ONzjZnFhuA4hn8j2r8nGuZ6hA7TdmPkBrP80YPzjzb yf7sgpL6JheFHCjd6NwbsS6DMFC5aLtD8j/X/bYKN9HeIFsdRSv9TtrI0WX2gjFrk8olq0uP IaBRuylB30aFKdPwSK/QqEW1rpD7iwm3mbSWZDTxgyqy6aDf2WSTaoZMVyIdaYy66bsiA7V6 ddEK8ySyxhFFvK4aS3e6407IlUDLHx9Dpfzw/G7bcaGKwtiXW0kVfnYxOp7f5Q/xvsK0ODV4 nu6R0lUjkLlgmHKIhmLbXYlb67zWZF4rjQwOilE0UuU5kXPqL2HtM83H6bbt5F+nAC/5ZaYl 8U4Rvg= IronPort-HdrOrdr: A9a23:onjW660+nKX2NsRM46Y8aAqjBfdyeYIsimQD101hICG9E/bo4v xG+c5xuyMc5wxwZJheo6H9BEDtexLhHP1OkPos1MmZLWvbUQKTRekJ0WKI+UyCJ8SRzJ856U 9qG5IOd+EZZTJB4foTi2ODfOrJD7O8nZyAtKPm6zNIcCkvUqdn6m5Ce3Sm+o8dfng5OXL8fq DslvauYlCbCAUqh7+Adx04dtmGncTPiJXlJTYeHnccmXCzpALt0qf+Dx+bmjwDUzZDqI1SjF TtokjC/6C+tPP+7RfZ2wbonvNrseqk8MJHGMuPzu4KLTn24zzYArhJavm5pTUop+Pq0nYG+e O82ysIDoBI8nbMeWPwmxf3xAX69z4r5xbZuCSlqEqmm9X9WDU5T/VMnphYdByx0TtbgO1B X-Talos-CUID: 9a23:6xRHA20WSzUcprhVvB6p5LxfONoHfETe6CnqcnSnCkZjc7y8eW+I5/Yx X-Talos-MUID: =?us-ascii?q?9a23=3ARNSUbwxkYxqhMmGhSW6y9pQFsBiaqPvzB3kp1os?= =?us-ascii?q?fh5m/ORdgEgeSihO2Y5Byfw=3D=3D?= X-IronPort-AV: E=Sophos;i="6.01,172,1684814400"; d="scan'208";a="115250894" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FGe8FKiK0qy+2o7MVSi8bseoB30qN/S4Spvr7eFsUep1pgAv0XmXRIHS/9syBxAR9noaCjlayvQa9ENc2f+GpcWbZC9wYbygk4b231mnq80Hb33K/cDlDF2hzB9WHWxObkamfWfg1aZyv4q7tFzrrMKNUDsES3q9CtCTLeycT2Ts5FvrK4JUc3ExFqzH3HmRZspqnv6SirD336anhzA4Bni3Wkd6Xl3mpnoh8NWDbeGhkRr5l5yg+c6yntZt/tj5xZwisoAQs4RMuAFHh4nkJf8fzd+vV/b61Byn4k3OBU8IqnBR2hRqG+uIKf2ihBdsttiPUcBgIPc4/ci9GW2bww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4lipXHd/Hd/oIj7zAyXeYQkzzuPBre6U7XzivX0UrBA=; b=QrxX7X3bBzQeGYcCWpx12i6PEvp/VjhRTQkzz6S5LQxPy8YR+pn516S/xzil6bB5/Ice96YK+SX8f+UccyR3j8ReO2ImS1GjEQtdhJYOK7D0WhCj2OeCPHP4mKmm8l8KYpzZ3rpVlrECN+Fse6Iwj0T6el2auWyqgENpf6y91S7yIKPayBbZ4p9j8OL7xrcBkm2n51ciGn0026MmEeANk4TK/C7/SaM6t45e3JULS0b2OHrxTRExTWEnsAf5C5sLMJa8vPPlzMEj62cxmtRTyFqwbGPcs6mCejK/Xyl0+H8KiuLxmaVm92nzf3g16cUheVl0OrDZkrbkjykigz4KrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4lipXHd/Hd/oIj7zAyXeYQkzzuPBre6U7XzivX0UrBA=; b=d3u1tIZ9kd5EI5Jj+U7YcLzj8dQxyaylPrZjjXTyFrDgkdCR2w42Dcrvv7Ev3Ipi8tyWnZGAKkWwWitIgeLAX/RFsbjlCH1xGxdKvmenSJ65co6XdnkPFScZEICLYLRETtHymTL/XR72E6FXxHDhiBS4hJEaYBS2tO+bnam3I5w= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <6060dd00-5d9c-3804-4b9d-154b9b9dca49@citrix.com> Date: Sat, 1 Jul 2023 08:53:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 From: Andrew Cooper Subject: Re: [RFC PATCH] xen/arm: Rebranding dom0less feature To: Luca Fancellu , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Henry Wang , Community Manager , Doug Goldstein , Bertrand Marquis , Volodymyr Babchuk , Anthony PERARD , Daniel Smith , Christopher Clark References: <20230630091210.3742121-1-luca.fancellu@arm.com> Content-Language: en-GB In-Reply-To: <20230630091210.3742121-1-luca.fancellu@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0677.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:351::20) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN7PR03MB3618:EE_|BN9PR03MB6025:EE_ X-MS-Office365-Filtering-Correlation-Id: 9fc072ac-3163-4443-b9a8-08db7a083d0e X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BFadWxqV8exolj48bNnpWlAmbiRlZoB5Mquc6B/v0uL2SSAC744O9M6fIUX9xGKlPCVkt7HYhszhe81wOKVVDEy9oEXyUuBWr2xcYf1SlGRGmfvh1jPbYOwZhY1KTQ7Pm3708vhIIZp3QMkdNveOSRbRRyz4dWV249TpdWMrkAjgBu9uLkrRz1E0/UVh0tFPSPojPkeEcEQ0FZnkQgLF+wtZWt0hlnGhHo3cGvt6uqU9uRlg1tGN4XqU/iFEHj0yaXAqkiu/Pxz148f3C1mMweOBP3mp9ehWKDVBoN0vmx9J3I/2W/MSvf3Syfx9KhMs735eqd5aXyoKESdwtKwlc0Kc1E//ZT6P9HNbPkLoPJ+jn46e3zFHgkYCh5M5flErOMEZb4m3x6HEz5xUfRUAoE0f0Ua7e93+xX05n0WLUH5n5cNSz3JP+9GK4Ey1cuW/Z4FQVl8tztp72DF3ApkyNMP9PBzEWrh6+u++Neuu4AmbvdbZxdRUlzsret2vk8CfZYK7Y8DG790wWXSOlZQxRnBJeKUde7omjhCt2nPEkkf++opEmA+Dtlt6m5qx28uFLaOqH45mCR1V2VXmuP3ej0CVLqQdvh4/opap1+amA0OQ82QwYpQ0+z+Bm5j1TiKfdT3UTVMtG1re7drHd3vbhX2rorC2hySYTvoyvHYln5I= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(39860400002)(346002)(136003)(366004)(451199021)(6666004)(38100700002)(4744005)(2906002)(6486002)(8936002)(8676002)(54906003)(36756003)(41300700001)(5660300002)(7416002)(478600001)(31696002)(66946007)(66556008)(66476007)(86362001)(186003)(53546011)(26005)(6506007)(6512007)(4326008)(316002)(31686004)(2616005)(83380400001)(82960400001)(32563001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUhmMjA2bVllWDUzSGcrTCtxMUlScGFrZjh4Z1VvdHRRR2M3Ukp0bFhBaWFP?= =?utf-8?B?Qlp5K2p3SkR1ZCtSTzFqWTVRNG5YZkNnV2F2ZEpjODI0TXYzWGx1d3FBenhN?= =?utf-8?B?eGxzZjRyanQ4bVB4b3Arb3ZvcG5pTkhFMjlrTytFZjNMWWVFQkphQnZqSTdw?= =?utf-8?B?c3dpOXJDQVg3TUtjbzkrQ1NwaXJpV1YyRWlMUjlEWmFEdFVudWRIMUFwa1hk?= =?utf-8?B?YktURk1ZY0trL2FsenMxRlFTQnYvd1ZnZVBuWms2c2dvc1BKeHFYUFU5dW9q?= =?utf-8?B?V1ljRTBUQkVndS9PZ0dWYjliWVJOUlVER1dBNlp5a1lvckVkUWI2Y3hGSm16?= =?utf-8?B?M21zSDZ6ZTBGWEFkYklmaHR5TEhaUy9OQjE5OElORVdWNVRXSVdMNkhNT3Rs?= =?utf-8?B?YXlnYmRKZ3I1ZXhzZ3ZidTREbTQ1ZUJsQnVEc25DYjBad3NFVEk0cGFvbVFB?= =?utf-8?B?V01YZEFzOXMrdkxzVFBudWVuUkpnODRSUUI5eU82VUY1dW1sU25nVStld1JS?= =?utf-8?B?SkFWRk5YT2xWaEl1NDNlZ0dlV1Q0UXo1Tng5eVp2K0k5UE1jQU1MdThoeTlV?= =?utf-8?B?Y3hnU0tZV2UyQzF0aW9iNnJseCsrT1MrQVM4OGI1aHVmR3BVelM2UGxUdjJ3?= =?utf-8?B?NlhrZTNiS0Ircit3T3lOS1YwZElTQ0lLMFRsRUYzN0pKbC95OWhISDdBMVVz?= =?utf-8?B?Q08xTUowS1pHcThhY3BHdEovb3FHQWptS2w4dU0wZi9RMWtkVEVtZWpvNGlQ?= =?utf-8?B?WmE5TG5lNllIRy91SC9tNUNGRE8zUGczajhLa0RpYXBwWHhkOFROVnl3MUk2?= =?utf-8?B?VXBwQUpWNmFTeXNoMzNvMkdGZmJGOENua1lQZTlneFYwaEFuaGlPL2l2MlNk?= =?utf-8?B?S0wrSjkxY3IxUWJvcjdCdkZSeithWHhtd2ZzRjR1ZUhsNXBBU3pZK2sxYkpj?= =?utf-8?B?M2RjNk9aM1FEdE0veHBONkl6TzFYT2pmTmF0NjdJZ0dHMklMWjJwWWw4Q0J1?= =?utf-8?B?WjJxSlVINXgrb2lXWXk1S3hlekZSeWhzMXR3L2Rpa2VkNldpUkcvOWVKeDFI?= =?utf-8?B?RW8vY25iVXRTTUd5MlpQTEFqcENnc3pIYm1xTFl4WDJVc0JFTC8rTlhucDI0?= =?utf-8?B?MVh4aEE5STh5c1lndklsYXVETXRpN0EreGpSamJORkJ2dFJpY283alNRVFBX?= =?utf-8?B?MW0wRHZBVFRCdjJFdm5IQTlNMEFpSXhCalFiTWhXYTVCRmdLTE1za212dXd5?= =?utf-8?B?cUFNT0p3MlJoMElocVR5MkV4NSs1YW1hVlgvSjcwR21UYnh2NjhmRU1MY1Vp?= =?utf-8?B?emVRZnNoNTI1Q2M4VTlwbExKd283RUVSRGxpR0plSXlpZGgyaS91azd5MzAz?= =?utf-8?B?NmxRclUzWE5GMk1UZGYvUEdwamJoT3BsOEMwcU0rWXV0Z2xrQ0lzdGJJRDVy?= =?utf-8?B?Z3BEUHJEL2FkRnR3cFdybWFWbFlyNkZ6SXV1NDNnc01zaXdUQ2RIN24zYVZk?= =?utf-8?B?WUViVzN2cVlXdTI4VS8wUURhejNSOWhlOEMrakJ1QWJtN0lweWN3V29aRmdL?= =?utf-8?B?QWhBcmVjQ29tUUhjZGlIeTNzR2lWMXRpOEZKelJIdTdlQzdqMVZGSnZodFMz?= =?utf-8?B?Njgrb0M5K2ZablczVE14UkpKd3E5dUpkdTJWRmJSZ20xQTl3cVpTb1p0RDAx?= =?utf-8?B?eWU5NXIrSEhHNDI2TThUck9XcS9UVEQ3eERrWGlFQ3plbEZ5UGx4SlNMdWtr?= =?utf-8?B?MGRSSTRGNFRWYjhpcmtQZGVpNGlaTCtBYTlQTE5zbkNTcUoyVURDWk5UZlhv?= =?utf-8?B?THlOR2NVVmMvajlrZWgvdFEvSDdFUytsazVqOUp6RDY2UHc2bFYzT2E4L05j?= =?utf-8?B?cUpGaFN3NW1QS0lydmZwV2NYVUFGZjhKY09nY255RXJQSjVhaXRFYXJOaXNn?= =?utf-8?B?NGFTRENrMmNNTWNoRUYrSjUzZXhVb250WURZZ3FTd205K1hzbHg0THhPZjRI?= =?utf-8?B?WGo0ZDBLTnVNbVVCckU4bStKMkVjYjExZ2I0VUVqbDhOMk5xWTVxNkEwcTds?= =?utf-8?B?SkI5TzVyNmpxSFRPTWt1MG9NS3pIeTR4ZDRhUGhhRGV1WldldVI5d1R1aU9k?= =?utf-8?B?NmJEa1lOaWF3aEdTa3NwOFlRREhueTlPQVhnd3crdG5XbjBOc0YwWUM3Y2tq?= =?utf-8?B?Tmc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?R2lONldtRmFLYnhBblQ0Uk5wNXF5YnlxMC9YQ0dXUU5OMDNFWU8wSWROWllJ?= =?utf-8?B?ZG9DY0VxaVFVVVFYTzRuV2tjSm1WdDBhUE5oVWpMSGN3NmdQaGhUMnVIK1dF?= =?utf-8?B?K2xMWm9jdUtNZWgzYi9uWUJNRTZYYU4rejFXWmtreXZzVFZmRUJjYXl1L2FK?= =?utf-8?B?UitpNzJ0QXNPbmxtRUdzV3dtTnZyVm1ZUThIMmw5cEd2N3NZNGxxNU9hd3Ur?= =?utf-8?B?SmZSSUN1dFVRU0RTV0VPOHVLbzg2aFRYZzB6TFQyWEZ4TjlvZVN0LzNuUWxI?= =?utf-8?B?VVlIalIreW1HWTlUUkhLS2dZRDdaYW1WVC91ZlpUcXJpQUI5dFlsbkxKS2Y3?= =?utf-8?B?d3BILzJIZ2lEb3VIYStBNXRYZ3R6anptdVl1ZHkrYitXTzhZbUF2aDNaUU5j?= =?utf-8?B?eHF2Z2hndEZDclNoTktUODJIcHRlQ21VZDhzUG1mL0xlbEdoQmhWMEgzSENB?= =?utf-8?B?d25KOGFhZVdzWDBkM3pLcTcwcHZjckNFOFRueHVFODdOYTM5TzJ2SUF6ZGJr?= =?utf-8?B?YjV6WStBMk5PRVU2YUtTVFVJakphRDBuZTk5akRCVDZyWUlSZE8ydHdqSDg5?= =?utf-8?B?ZzdzSS9vcFJIYjhtdFo4bEZ4RnRSbnFnbWNKSWxqK2JuZkpoc3ZjMzErT1Jj?= =?utf-8?B?Q3NaTHc1SERSZjZ6VlhzT09LMU1YSmZzQUJQaVM3cDJ0SHlWNVN0eXdrS2xZ?= =?utf-8?B?cWlldE5wTVUrREV1aTBZL2l5WEdwVlBMeFpxWkh0NitvSVZ4MTMyd3VtK2JU?= =?utf-8?B?YmhpQnFRMVpJaUlVT1V5aWN3VXFaaVRrc0d5RTBiY09jUmRGbk8rN2lPN2JP?= =?utf-8?B?TFQvVlY4WmpwS2pzZm5IQ0h3MDVQazFLOE01L2h1Y2duZzlpUnBWWGpWNE1s?= =?utf-8?B?dWIzSWpZSzlEN0Mrb0dzMkNtUVpqOTl5V2RMTWpyd1hlaUhvUEVqUlBxN1F5?= =?utf-8?B?eVdUOVRuV1k0MUNxQ3B3cUNDM0JwV1dQMUkvVWVrbFlRaHdZRDZ4KzVyUjAx?= =?utf-8?B?dTdCUjlJdUF5STZlaHdkc2FYMU5oanhhV1NDaUtxTEpDOHpYWU1GZmZzSjJ5?= =?utf-8?B?enlZdWVYNUJXenFIQ0hkUnAzcWhOU0p1NkZ4N3ltUEpsRDBTRzZ6Mm5Ib2ov?= =?utf-8?B?MGxrZXZqSHBJVTNvNWJON0pPNy8rZ3dWMk9nVTdSSXUzalFOWkJ5ZEllZXJF?= =?utf-8?B?M09mMVVQcWZUTmc4U2dZb2lMdCszcGxuZ0k0VlRJUFFON29PR3ZsUi9MT1ZY?= =?utf-8?B?SHg1aURheWRwOFMxbGhLbDZ4Y3haSHhWczNTMEc0V0w3UmJubEJzNVpFT1ZV?= =?utf-8?B?QmhVeDJOeEl2OHR2QzBSbkRPTWpVKzdueVZ3cVV5Wm14MXl6clYra1NNLzlG?= =?utf-8?Q?rpVshJCJTTV+LuLwg4cnmnoUa7bebgeU=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9fc072ac-3163-4443-b9a8-08db7a083d0e X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2023 07:53:20.9067 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JllmYz8NkX8Mg1OsnIDoW9D+JxIuqfyX3gzioIupfKkOmRhzT1obNHR+DGuxGMtw/H1jhncoefhsQN8izObP5DwvH48bsuqGvffeLlYEF4c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6025 On 30/06/2023 10:12 am, Luca Fancellu wrote: > The "dom0less" feature was intended to be the feature where a domU > domain could be launched without the control domain (Dom0) > intervention, however the name seems to suggest that Dom0 cannot > be part of the configuration, while instead it's a possible use case. > > To avoid that, rename the "dom0less" configuration with the name > "hyperlaunch", that is less misleading. > > Signed-off-by: Luca Fancellu > --- > This is an RFC to get the feeling of the community about the name > change, for now it's everything in one patch just to see how it > will look like, if there is interest on proceeding into it, I can > split in more commit. Have you discussed this with Dan and Chris at all?  You haven't even CC'd them. While there is a lot of end-goal in common between the dom0less and hyperlaunch, and that the name dom0less is deeply misleading, hyperlaunch is specifically not this. ~Andrew From xen-devel-bounces@lists.xenproject.org Sat Jul 01 09:08:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 09:08:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557834.871515 (Exim 4.92) (envelope-from ) id 1qFWaE-0008Lv-J8; Sat, 01 Jul 2023 09:07:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557834.871515; Sat, 01 Jul 2023 09:07:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFWaE-0008Lo-GK; Sat, 01 Jul 2023 09:07:58 +0000 Received: by outflank-mailman (input) for mailman id 557834; Sat, 01 Jul 2023 09:07:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFWaC-0008Lg-TS for xen-devel@lists.xenproject.org; Sat, 01 Jul 2023 09:07:56 +0000 Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [2607:f8b0:4864:20::d31]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c35dc7f8-17ee-11ee-b237-6b7b168915f2; Sat, 01 Jul 2023 11:07:55 +0200 (CEST) Received: by mail-io1-xd31.google.com with SMTP id ca18e2360f4ac-7835c92c373so66351839f.0 for ; Sat, 01 Jul 2023 02:07:54 -0700 (PDT) Received: from smtpclient.apple ([87.249.134.26]) by smtp.gmail.com with ESMTPSA id eh4-20020a056638298400b00426eea9f398sm3190051jab.134.2023.07.01.02.07.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 01 Jul 2023 02:07:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c35dc7f8-17ee-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688202474; x=1690794474; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:from:to:cc:subject:date:message-id :reply-to; bh=2WIn68E2vval0WhdulTmqLoUBV2XXLtEL49qn7WzQQ8=; b=JAbxYHYQHSo7S0Eb/Qx26DGEoUP+NBx5aj9kcE2KCoXFHohUwcE93VxSn6lZaz5RRJ AyYqBngN59MeMUl625KQ00EmEZa7e4fp6sVUIvUAQnGd283Rw8QViLzZuzZYKG6maTuy XOVEJk8Fj+RJa4g1uOvXzCkBvl4CGhQSJk2LuK8DO74QporRbo9kfguBtUSRdtp6vvgW MIQsXJEI+kvAKcjgiWxliX8uzF1yYH/nZP2BGiF5gVCTITtri4XqR1nxa9bOwerMCMwO y01jMcAGad0jdcGVRcohEmWDNuYnIUU6+0z78xZk11SeuQo1GUy0ciQPahScbKQJt+Dz mO2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688202474; x=1690794474; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2WIn68E2vval0WhdulTmqLoUBV2XXLtEL49qn7WzQQ8=; b=Zn/+gm+/xVlvapzhPgex1Xo/9OW+4qH0sZJqAUnhrl/m7ATdKp8338PBLomKYT1fOZ PDBe/qVxbeGOakGMWyVZiGle4BCJRivt05cylxuupgIsAONS2uXK41UGPhThkm7sZQt9 v5d0eQT3JUFSlOqbGQmo2W/CMPNQ/bnPAVdt9VkRnqCEUbQropQKfoLAQLvvUJUWrEEY VGVIMcJKotvvmcs2xmVahYUcNgph1iILXgqAHwtFrMU14ctGv54W6h2hyQpLw1t2ODZX 0kZ8G7LtxI5NMtF5y1ZbzAOK44QSnOJnf5lT3C8zYEwiW9zpXrMZUMP6dViR79XbDQEA nqDw== X-Gm-Message-State: AC+VfDxKaVTS8YqlH6B74+fP0wGJzk3/DZI7auh6SqtB6/eqLtXZv/My vt94X6TX2CfN2Ou55oTe5ZA= X-Google-Smtp-Source: ACHHUZ6FgkLFVHEymiyx3HTQ1q+w+/eZPl3RiaL5/0E6R1BBXxADuY90PlZRMkDZXt18oLnCh+7eUw== X-Received: by 2002:a05:6e02:c68:b0:342:558c:d88e with SMTP id f8-20020a056e020c6800b00342558cd88emr6329062ilj.11.1688202473581; Sat, 01 Jul 2023 02:07:53 -0700 (PDT) Content-Type: multipart/alternative; boundary=Apple-Mail-1F9216F4-6F5A-4AFF-85F5-BE841D0E68EE Content-Transfer-Encoding: 7bit From: Rich Persaud Mime-Version: 1.0 (1.0) Subject: Re: [RFC PATCH] xen/arm: Rebranding dom0less feature Date: Sat, 1 Jul 2023 05:07:41 -0400 Message-Id: References: <20230630091210.3742121-1-luca.fancellu@arm.com> Cc: xen-devel@lists.xenproject.org, Wei.Chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Henry Wang , Community Manager , Doug Goldstein , Bertrand Marquis , Volodymyr Babchuk , Anthony PERARD , Christopher Clark , Daniel Smith , Daniel DeGraaf , openxt@googlegroups.com, =?utf-8?Q?Marek_Marczykowski-G=C3=B3recki?= , =?utf-8?Q?Piotr_Kr=C3=B3l?= In-Reply-To: <20230630091210.3742121-1-luca.fancellu@arm.com> To: Luca Fancellu X-Mailer: iPad Mail (20F75) --Apple-Mail-1F9216F4-6F5A-4AFF-85F5-BE841D0E68EE Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Luca, On Jun 30, 2023, at 05:12, Luca Fancellu wrote: >=20 > =EF=BB=BFThe "dom0less" feature was intended to be the feature where a dom= U > domain could be launched without the control domain (Dom0) > intervention, however the name seems to suggest that Dom0 cannot > be part of the configuration, while instead it's a possible use case. Thanks for your interest in Xen boot integrity. Please see the 2018 domB RFC= : https://lists.xenproject.org/archives/html/xen-devel/2018-06/msg01306.html At Xen Summit 2018 (Nanjing) and Xen Summit 2019 (Chicago), OpenXT contribut= ors made a case to Xen-on-Arm contributors for the architectural unification= of incumbent dom0less (Arm) and the domB (x86) proposal for improving Xen b= oot integrity. > To avoid that, rename the "dom0less" configuration with the name > "hyperlaunch", that is less misleading. 2018-2022 work on Xen launch integrity, thanks to Apertus and Star Lab:=20 https://wiki.xenproject.org/wiki/Hyperlaunch https://www.theregister.com/2022/12/16/xen_4_17_hyperlaunch/ 2023 Hyperlaunch design session last week, thanks to Apertus and AMD: https://lists.xenproject.org/archives/html/xen-devel/2023-06/msg01870.html > Signed-off-by: Luca Fancellu If Arm is now ready to invest engineering resources into new Xen launch inte= grity features for security and safety-critical use cases, that is exciting n= ews, 5 years into the on-again-off-again bootstrapped Hyperlaunch project! T= he roadmap would benefit from new funding. Would you like to attend the next Xen working group call for Hyperlaunch? Rich= --Apple-Mail-1F9216F4-6F5A-4AFF-85F5-BE841D0E68EE Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
Hi L= uca,

On Jun 30, 2023, at 05= :12, Luca Fancellu <luca.fancellu@arm.com> wrote:

=EF=BB=BFThe "dom0less" feature was intended to be t= he feature where a domU
domain could be launched without the= control domain (Dom0)
intervention, however the name seems t= o suggest that Dom0 cannot
be part of the configuration, whi= le instead it's a possible use case.

<= /div>
Thanks for your interest in Xen boot integrity. Please see the 201= 8 domB RFC:

At Xen Sum= mit 2018 (Nanjing) and Xen Summit 2019 (Chicago), OpenXT contributors made a= case to Xen-on-Arm contributors for the architectural unification of incumb= ent dom0less (Arm) and the domB (x86) proposal for improving Xen boot integr= ity.

To avoid that, rename the "dom0less" configuration with the= name
"hyperlaunch", that is less misleading.

2018-2022 work on Xen launch integrity, t= hanks to Apertus and Star Lab: 
https://www.theregister.com/2022/12/16/xen_4_17_hyperlaunch/

2023 Hyperlaunch design session last week, thanks to A= pertus and AMD:

Signed-off-by: Luca Fancellu &= lt;luca.fancellu@arm.com>

If A= rm is now ready to invest engineering resources into new Xen launch integrit= y features for security and safety-critical use cases, that is exciting news= , 5 years into the on-again-off-again bootstrapped Hyperlaunch project! The r= oadmap would benefit from new funding.

Would you like to a= ttend the next Xen working group call for Hyperlaunch?

Ri= ch
= --Apple-Mail-1F9216F4-6F5A-4AFF-85F5-BE841D0E68EE-- From xen-devel-bounces@lists.xenproject.org Sat Jul 01 09:53:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 09:53:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557838.871525 (Exim 4.92) (envelope-from ) id 1qFXIE-0005Xq-Rn; Sat, 01 Jul 2023 09:53:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557838.871525; Sat, 01 Jul 2023 09:53:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFXIE-0005Xj-Ol; Sat, 01 Jul 2023 09:53:26 +0000 Received: by outflank-mailman (input) for mailman id 557838; Sat, 01 Jul 2023 09:53:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFXID-0005Xd-NI for xen-devel@lists.xenproject.org; Sat, 01 Jul 2023 09:53:25 +0000 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [2a00:1450:4864:20::52c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1df6f974-17f5-11ee-8611-37d641c3527e; Sat, 01 Jul 2023 11:53:23 +0200 (CEST) Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-51d9bf5411aso2849494a12.2 for ; Sat, 01 Jul 2023 02:53:23 -0700 (PDT) Received: from [127.0.0.1] (dynamic-089-012-173-083.89.12.pool.telefonica.de. [89.12.173.83]) by smtp.gmail.com with ESMTPSA id v9-20020aa7cd49000000b005187a42b44fsm7606875edw.58.2023.07.01.02.53.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 01 Jul 2023 02:53:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1df6f974-17f5-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688205203; x=1690797203; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=U6qzh5zT5TRYd5Sip4g9abjelR/5v1OLZh8dWj8GBAE=; b=g1lntXpKHUXhdYIGb1g2NFGLAg9i2q1sGxEt/vbVZeLtWuht/fvm9vwV1MLjKUwjkU oBauakppnvcoYODDuxCIFDW27tsbkAmV97KExEJ+esKI9lF0NATFWtezMBCCNDDlwLLS uxWFI19OAoe8qiLMwJeTqSnkpi8JvTrAXTtN5Wez5YTPfIArk8mIm/F1S4SngQLnG2DU HBThsEgZCVfXdPnf00KvUAYFQG2kX0p/T5O+vC1t3jjiSjsDhLEKKZ4hFnwrUOhhaH8b O2AZns8c6R5KXJIvqnEfC5tTTupGkpy8hJ1iWkxzQ//Y/RuyaV+JheQxKwn+2WL1126u 9yoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688205203; x=1690797203; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U6qzh5zT5TRYd5Sip4g9abjelR/5v1OLZh8dWj8GBAE=; b=gd1T4CQcl18AHqR10qM0gtZHMrTN3pg1TXc01htETFenTp19OsL2Cc8yi6cT7AE4pX DpfUGfkrc//t4L56C32s9773q0MqEEXs1CJtwDcp1MVZjeDRPziY6ZOlsLeNGTnsN1ES 1d9O49ayIaDedUw2fybvWTE1qXk3S5GB4wap/osBiAl94BoQlgbgs/9LdUbO+xtG5vx0 kj06ghd+e4NKyXrMlO5sLrRuOzsxSeKH9LlPqohNRtxTqbyKp3XdCH407n8IhgEkB6OY poyBR2xPgRMC52fyCAzB4YTafSX22XZGAeCYH/yl2OeE2PDh3wcULXq5NmzSEn7LCg7A PKJQ== X-Gm-Message-State: AC+VfDyRcaHA7egay8FBkI0HmtHj+JY+SDvNY1EDSNjxeYoDn2tjcnaF zTRZFra/C3TIyvQ3AWq/FPMvqUBG71k= X-Google-Smtp-Source: APBJJlHaXRaHawJGh8EcQEbPNbdz3SpEWVXwBe9z3waKnvOCHY7coyJ32yStWcR97XEgIaTVX5NGgQ== X-Received: by 2002:a17:906:b7c8:b0:984:bd75:6a3 with SMTP id fy8-20020a170906b7c800b00984bd7506a3mr3527933ejb.58.1688205202474; Sat, 01 Jul 2023 02:53:22 -0700 (PDT) Date: Sat, 01 Jul 2023 09:53:12 +0000 From: Bernhard Beschow To: Paolo Bonzini CC: Olaf Hering , qemu-devel , John Snow , "open list:X86" , Stefano Stabellini Subject: Re: [PATCH v2] piix: fix regression during unplug in Xen HVM domUs In-Reply-To: References: <20210317070046.17860-1-olaf@aepfle.de> <4441d32f-bd52-9408-cabc-146b59f0e4dc@redhat.com> <20210325121219.7b5daf76.olaf@aepfle.de> <20230509225818.GA16290@aepfle.de> <20230626231901.5b5d11c1.olaf@aepfle.de> <5DB37FA5-41DF-4ED6-8C8A-CDDD6F276F42@gmail.com> <20230627140740.2736f6e8.olaf@aepfle.de> <4F5609FD-4A89-4450-89E2-3311CC5A9317@gmail.com> Message-ID: <3987B0DB-46F2-49F1-AEA5-B88BC61A633F@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 30=2E Juni 2023 08:48:02 UTC schrieb Paolo Bonzini : >Il mer 28 giu 2023, 13:28 Bernhard Beschow ha scrit= to: > >> >> >> Am 27=2E Juni 2023 12:07:40 UTC schrieb Olaf Hering : >> >Tue, 27 Jun 2023 10:12:50 +0000 Bernhard Beschow = : >> > >> >> The BAR is a 32 bit register whose default value is 0x00000001=2E I = think >> what's supposed to happen here is a pci_set_long() rather than a >> pci_set_byte()=2E >> > >> >Indeed, the u32 at that address changes from c121 to c101 with the >> current code=2E >> >> Neat! Would you mind sending a patch fixing the BMIBA register to be re= set >> as 32 bit? >> > >I think we should also check why writing the command register is not >disabling the BAR as well=2E So IIUC the BMIBA register is managed internally by QEMU's PCI code and we= shouldn't have to mess with the register at all=2E We should actually remo= ve the explicit reset of BMIBA, correct? I've tried debugging the PCI code when working on the VIA IDE controller t= o understand it better=2E But despite QEMU being compiled with --enable-deb= ug it seemd to be compiled with -O2 still, making debugging quite hard=2E I= 'm not sure if any compile flags leak into my build environment though=2E Best regards, Bernhard=20 > >Paolo > > >> Best regards, >> Bernhard >> > >> >Olaf >> >> From xen-devel-bounces@lists.xenproject.org Sat Jul 01 11:59:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 11:59:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557849.871550 (Exim 4.92) (envelope-from ) id 1qFZFz-0000yk-Qm; Sat, 01 Jul 2023 11:59:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557849.871550; Sat, 01 Jul 2023 11:59:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFZFz-0000yd-O8; Sat, 01 Jul 2023 11:59:15 +0000 Received: by outflank-mailman (input) for mailman id 557849; Sat, 01 Jul 2023 11:59:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFZFy-0000yX-7r for xen-devel@lists.xenproject.org; Sat, 01 Jul 2023 11:59:14 +0000 Received: from mail.ilande.co.uk (mail.ilande.co.uk [2001:41c9:1:41f::167]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b09240ed-1806-11ee-8611-37d641c3527e; Sat, 01 Jul 2023 13:59:11 +0200 (CEST) Received: from [2a00:23c4:8bad:df00:f732:dd76:7417:d15b] by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qFZFc-0005I2-Q0; Sat, 01 Jul 2023 12:58:56 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b09240ed-1806-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:MIME-Version:Date:Message-ID:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=HUvWWzeC6i10u0AquICUezzYl2yLIB0LMiRxiVfqyBk=; b=IOmQ7yGgID/KuDQlwtrlcQjPDM eWMWXQyTr62fuLjJqJQ9UN++wx1Ds4IlurVCjW4mSI6bLcOIb5ZxF7eBJi3Z04pRAlF5Q1cru7UMK jxe8qdkDMU1ydCeTJmFOiDWhZLnZcgdjYIZaUsIP0ucHwF4AHqnN+Ll3I86IEcYxjF1gkRjmCYjCC 5oE9M7qcTlfXwZKdiFLd3gC8WfgwKFtffJ3RaquYsvf6aLETE7RLiWsWbKbCJZ4z2Z+MvR4qz3hy6 z12ik1OC5MxQorqKWQwc3WselrMPoMM8NCphrUYqXd4HxhpanLriXtBWsbXCqSsFEelDirg5a85BS ZTnZZYSJ19/ghWtSTlNIYSe+BXFcFjesy1ob12n1N52j874sk42lkgXq9h+sM8ddANTtCBnqOWZzQ 3vKjmnU2dj1mB29rCR0MaVqPWdm3eVcgcbXyPSn+oiO+v6BlS9nj1fnXfFkX5QgHuFlWWmO3xBTG3 XOlclsW1vaXd6LMWbdfj2VER3mqf9cbIjmfOlsU3NfuBPgf+nrJlHgb4mwMO1jPyev8d0KMixbNP9 u7D80zH1olqYW9AB+04tXhCPDH8jeenM4l7uEh2nweyGdyZTehPMTOG+ZY+VzhOV5Fp/0DJMvbBZg dk0YCPgLCNoghK9WLBBck+lRnI8S5T++MrJ7Ngs4M=; Message-ID: Date: Sat, 1 Jul 2023 12:58:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 To: Bernhard Beschow , Paolo Bonzini Cc: Olaf Hering , qemu-devel , John Snow , "open list:X86" , Stefano Stabellini References: <20210317070046.17860-1-olaf@aepfle.de> <4441d32f-bd52-9408-cabc-146b59f0e4dc@redhat.com> <20210325121219.7b5daf76.olaf@aepfle.de> <20230509225818.GA16290@aepfle.de> <20230626231901.5b5d11c1.olaf@aepfle.de> <5DB37FA5-41DF-4ED6-8C8A-CDDD6F276F42@gmail.com> <20230627140740.2736f6e8.olaf@aepfle.de> <4F5609FD-4A89-4450-89E2-3311CC5A9317@gmail.com> <3987B0DB-46F2-49F1-AEA5-B88BC61A633F@gmail.com> Content-Language: en-US From: Mark Cave-Ayland In-Reply-To: <3987B0DB-46F2-49F1-AEA5-B88BC61A633F@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2a00:23c4:8bad:df00:f732:dd76:7417:d15b X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.default.ilande.bv.iomart.io X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED,URIBL_SBL_A autolearn=no autolearn_force=no version=3.4.2 Subject: Re: [PATCH v2] piix: fix regression during unplug in Xen HVM domUs X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) On 01/07/2023 10:53, Bernhard Beschow wrote: > Am 30. Juni 2023 08:48:02 UTC schrieb Paolo Bonzini : >> Il mer 28 giu 2023, 13:28 Bernhard Beschow ha scritto: >> >>> >>> >>> Am 27. Juni 2023 12:07:40 UTC schrieb Olaf Hering : >>>> Tue, 27 Jun 2023 10:12:50 +0000 Bernhard Beschow : >>>> >>>>> The BAR is a 32 bit register whose default value is 0x00000001. I think >>> what's supposed to happen here is a pci_set_long() rather than a >>> pci_set_byte(). >>>> >>>> Indeed, the u32 at that address changes from c121 to c101 with the >>> current code. >>> >>> Neat! Would you mind sending a patch fixing the BMIBA register to be reset >>> as 32 bit? >>> >> >> I think we should also check why writing the command register is not >> disabling the BAR as well. > > So IIUC the BMIBA register is managed internally by QEMU's PCI code and we shouldn't have to mess with the register at all. We should actually remove the explicit reset of BMIBA, correct? > > I've tried debugging the PCI code when working on the VIA IDE controller to understand it better. But despite QEMU being compiled with --enable-debug it seemd to be compiled with -O2 still, making debugging quite hard. I'm not sure if any compile flags leak into my build environment though. Certainly --enable-debug normally does the right thing when building QEMU. If you want to double-check the compiler flags in use to see if anything from CFLAGS/LDFLAGS is getting picked up, use "make V=1" after configure which outputs the full command being used during the build rather than just the summary. ATB, Mark. From xen-devel-bounces@lists.xenproject.org Sat Jul 01 14:30:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 14:30:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557869.871572 (Exim 4.92) (envelope-from ) id 1qFbbZ-00085Y-SW; Sat, 01 Jul 2023 14:29:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557869.871572; Sat, 01 Jul 2023 14:29:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFbbZ-00085R-Pt; Sat, 01 Jul 2023 14:29:41 +0000 Received: by outflank-mailman (input) for mailman id 557869; Sat, 01 Jul 2023 14:29:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFbbY-00085H-Mm; Sat, 01 Jul 2023 14:29:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFbbY-000530-E8; Sat, 01 Jul 2023 14:29:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFbbY-00078E-4T; Sat, 01 Jul 2023 14:29:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qFbbY-00053I-3y; Sat, 01 Jul 2023 14:29:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=lXWojDKIQPdBByfB+7Y+P3VxJnZ8J+dD/bRfhue01AY=; b=083IYC7KkPdL+5EShtRmmXbdx3 mA9NmZJvl26C/Rvi6aSlH6EWchJeyckgBOG1x4N9MPSR66TiO0ztMVNTX4Dfc6PXNNhWYqvxbovPV +faYNbujuzuCbQdoS3y9rboroI9nZsd+y0AADy8isCKNqc+Wxnn/pE6msLXVhpaS7ep0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 181665: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=f51e5d8eae8ece77a949571f39ee49904f3129aa X-Osstest-Versions-That: xen=6aa0c18062609cb448d292668a81953a58ce1e95 From: osstest service owner Date: Sat, 01 Jul 2023 14:29:40 +0000 flight 181665 xen-unstable real [real] flight 181676 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/181665/ http://logs.test-lab.xenproject.org/osstest/logs/181676/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt 7 xen-install fail pass in 181676-retest test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail pass in 181676-retest Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt 15 migrate-support-check fail in 181676 never pass test-armhf-armhf-libvirt 16 saverestore-support-check fail like 181646 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 181646 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 181646 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 181646 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 181646 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 181646 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 181646 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 181646 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 181646 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 181646 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 181646 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 181646 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen f51e5d8eae8ece77a949571f39ee49904f3129aa baseline version: xen 6aa0c18062609cb448d292668a81953a58ce1e95 Last test of basis 181646 2023-06-30 02:11:47 Z 1 days Failing since 181657 2023-06-30 14:38:36 Z 0 days 2 attempts Testing same since 181665 2023-07-01 03:16:15 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alejandro Vallejo Andrew Cooper Anthony PERARD Federico Serafini George Dunlap George Dunlap Julien Grall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 6aa0c18062..f51e5d8eae f51e5d8eae8ece77a949571f39ee49904f3129aa -> master From xen-devel-bounces@lists.xenproject.org Sat Jul 01 15:14:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 15:14:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557884.871619 (Exim 4.92) (envelope-from ) id 1qFcIE-0005Kn-Ba; Sat, 01 Jul 2023 15:13:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557884.871619; Sat, 01 Jul 2023 15:13:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFcIE-0005Kg-8V; Sat, 01 Jul 2023 15:13:46 +0000 Received: by outflank-mailman (input) for mailman id 557884; Sat, 01 Jul 2023 15:13:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFcIC-0005Ka-6A for xen-devel@lists.xenproject.org; Sat, 01 Jul 2023 15:13:44 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2062b.outbound.protection.outlook.com [2a01:111:f400:fe16::62b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dc24b68b-1821-11ee-b237-6b7b168915f2; Sat, 01 Jul 2023 17:13:40 +0200 (CEST) Received: from DB9PR01CA0021.eurprd01.prod.exchangelabs.com (2603:10a6:10:1d8::26) by DB9PR08MB6730.eurprd08.prod.outlook.com (2603:10a6:10:2a2::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Sat, 1 Jul 2023 15:13:36 +0000 Received: from DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1d8:cafe::7c) by DB9PR01CA0021.outlook.office365.com (2603:10a6:10:1d8::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.26 via Frontend Transport; Sat, 1 Jul 2023 15:13:35 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT010.mail.protection.outlook.com (100.127.142.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.13 via Frontend Transport; Sat, 1 Jul 2023 15:13:35 +0000 Received: ("Tessian outbound b11b8bb4dfe8:v142"); Sat, 01 Jul 2023 15:13:35 +0000 Received: from d111f6208b92.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 19E7EF3F-3875-4E56-87F6-2ACEA8F4D52B.1; Sat, 01 Jul 2023 15:13:24 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d111f6208b92.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sat, 01 Jul 2023 15:13:24 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by DU0PR08MB10326.eurprd08.prod.outlook.com (2603:10a6:10:472::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.19; Sat, 1 Jul 2023 15:13:21 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::ed0b:5730:a1f9:577b]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::ed0b:5730:a1f9:577b%5]) with mapi id 15.20.6544.024; Sat, 1 Jul 2023 15:13:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dc24b68b-1821-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tHtfN2x/SO7Axo2M+ZNtdVM/tYp6B5Arr7cPdYw8U6E=; b=t6TGzUYBlWz8pVe25lmbKA6pXpb3rHZLnWCjBZftkM02O1BvGRwcKSUKw9CrGNVAdlJS3stg7ddl3v/FpSAzwwRjCUsjMb8B7g36Oe/Bsfq7am6gX9o1xxs/9+yhZB7JxbuGg2kyOfb981gLtBLYQVrwN4bK5otf2MohBDWMkSg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 63308b8bed9dab6f X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gEh1GXaLM89YLjF5ULBez0uesW3LCFISLSaG2igjfVl995iXzUPpmabOOhtVCAdNV/O3E57wbErwzJOhpBaM5RxIT2VoUB30k+44o5ojr8J5dImkt+i4Runc+bCyx+F83euB8yWh1r8uLQXayBEeUZmNC+bGOX/HSDDbmd3B29jVhhTQlgd6p2fsSPBQM5KCFdjymDvjpiB8gd+O5bCdfdS+m1B5LEr6RYujTQTuFyw4x+AudAdw2kNn8WZX5KhcnoLRzhW+1x8aAXUSpbu0Kvjx9iJ6oNU6tgYz3N9xhzCQahciTbMxlNDoVwhM0ksZecyIi3vUaYEAa6nW8rWs2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tHtfN2x/SO7Axo2M+ZNtdVM/tYp6B5Arr7cPdYw8U6E=; b=hHvcF4GV4EEPgKrTPvScHu57P7b4Jacz4Lhd4Zd7hntwKOcGj3juBypvkpoIeUGG12smY8/Whdr9gxisl2tssVwXQlm38qCKYA0+NjfndskIn4EWQlT0NhZcNmWCNaLKjaMpuRiFGA4Kii4OMu6SmeEx7OMUsiXXT2yZ71d8jKkP8hb0N0L7oH0E1eLRgb47RUwW0fBZMHGmqHnigXlxAFQig6zdaYclB005Yo+VojD+0tNSIrnzhBFFx5KLTyQAWGwrdcNu3Rof51Hx7MOOSSw68RbX21NQt1D9N87qgWVvSe6X6b2pesnSYQvt125Vum+13zmWuKH5NRnF0O7vDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tHtfN2x/SO7Axo2M+ZNtdVM/tYp6B5Arr7cPdYw8U6E=; b=t6TGzUYBlWz8pVe25lmbKA6pXpb3rHZLnWCjBZftkM02O1BvGRwcKSUKw9CrGNVAdlJS3stg7ddl3v/FpSAzwwRjCUsjMb8B7g36Oe/Bsfq7am6gX9o1xxs/9+yhZB7JxbuGg2kyOfb981gLtBLYQVrwN4bK5otf2MohBDWMkSg= From: Luca Fancellu To: Andrew Cooper CC: Xen-devel , Wei Chen , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Henry Wang , Community Manager , Doug Goldstein , Bertrand Marquis , Volodymyr Babchuk , Anthony PERARD , Daniel Smith , Christopher Clark Subject: Re: [RFC PATCH] xen/arm: Rebranding dom0less feature Thread-Topic: [RFC PATCH] xen/arm: Rebranding dom0less feature Thread-Index: AQHZqzMUKP6yBnvUfEC1egkdxmuozK+ki8cAgAB66AA= Date: Sat, 1 Jul 2023 15:13:19 +0000 Message-ID: <31FE51E0-0336-4756-8B30-6FE77DE10932@arm.com> References: <20230630091210.3742121-1-luca.fancellu@arm.com> <6060dd00-5d9c-3804-4b9d-154b9b9dca49@citrix.com> In-Reply-To: <6060dd00-5d9c-3804-4b9d-154b9b9dca49@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.600.7) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|DU0PR08MB10326:EE_|DBAEUR03FT010:EE_|DB9PR08MB6730:EE_ X-MS-Office365-Filtering-Correlation-Id: 22a799ed-61ba-4f31-0788-08db7a45bd6e x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: eMhK5YSTi7b579QIjsGp+isnpiv2jacfHt9cbh352qfBxzpOBSAGMHTknB32lYMNEzh7pHOxhV/ylLYeSkQfLD6eaehhouZdlOuMTwtcoE87XXV9zqjI8l6YTK5HH3WeS130nvOlyJ+9up2eiZSA3RXuLmHoL19D9T7REkVBpKm1olgoxTiloKnPO1ATZiG3WkGtaonQi8w2kzywbjAwdjsrnNoqklJFFZBg/4G2sGDaIPJWOq+o8XHl2DiBl+XNSPM9cWzh9IBbKyS+X1LW1Lye/MBHkbmDMYlrPYqzsLcL1BCIyHtj9lCiB4XiQ5jDqzsLMhV1s7yAGvtjO8YtPCGAp976oYD36DkSEzGIAvefY+KMl9pZ+5EskGtYkzM4i8pS9IqlKuyzdODSjtrBL+ezlPntaVu0s3WmxMwQLH0iPLd7bCB6vVnYLAzgIH81tcY8Hms8NgaQS6Bgvf8VhlQk0pLjPJSudArOf2MEc5Zs64vpdcULRQoC/6suObV61nevjWUeR9/FYJwk8y5TPzb75XLItkibuEHiAtU2CkwsOZHUXSGMH3vYOatYBmaZRxfeMOjCHJ4VKi334NDBVHUJtc73TMrv6zRe7JqVlL4Al3j2h1H8l8xDFCcVUov/SIjvPnztp+fq64HgObC1n5oF9KFxVpoNQsVDNcKQTmQ= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(346002)(376002)(396003)(136003)(39860400002)(451199021)(6512007)(76116006)(54906003)(91956017)(66946007)(66556008)(66476007)(66446008)(122000001)(2906002)(7416002)(36756003)(478600001)(8936002)(316002)(38100700002)(6916009)(41300700001)(64756008)(4326008)(83380400001)(6486002)(71200400001)(5660300002)(86362001)(38070700005)(8676002)(33656002)(26005)(2616005)(186003)(6506007)(53546011)(32563001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <5CCE60224551D34B82A457B6E65DA1F6@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB10326 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d0439fbf-c97a-40ab-cfc5-08db7a45b3e3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KVaNP3xk02ENW3X6FfBQDTH89xKYg3goZH5VqIhc3qWioMPgDP4wGDq04tlwej08yD7sgAQn3p0G4TvxO1MqoOHxOFYlab+/7Tpa6QK0+5F2/NqdoIP0O3JyV8oCOFQ0gfshWCdKOV7L8IUrNBdgez7bKheYjtk/izGRJxOPVn/Gl+R8MSl1/NqFesxRfM5can7o4PRC9Jh4INIrwMHMRhvrS9stKgGgKxXwt1lSDBswUuBf/lLFXKEE6heqhJrjicLVPJwsg0W9oRO7huDcvhAD0WBoBSO9m803EhBSyj+H1lOh2JH2LbBOiQmypZRST2zmyMTPJnaBI45bCLHJpEUVBicFTIm7R1xkTp0j6IAWatZfkK45VbejY0wx1pfCvnLexTvzaLzyJZxJP0UWQFgf/dUAtf2dGc5KlKH0gIqsvgvoqpyB8PaNjw++GpApCerLjthe8Yo130NxpTBWg7UEPyJCoGTgqdYCOwk2AshZX5HUaVPduh2Jf6Hyfa5h4F0DjJALqikvp8IdoMElxSPs6qrlKCaKaKogeiCl198YcbnTq0YIqbNpz07rk0+aFYPmGvobGWGZBC6yREo4JAqWlcVIbmpk5+q+oypWAb5HbeGPIt2jW7oUMX0Om69L3e87fwwzq4D7JMlS5lCEV019huDtcDnbAGegakAm0fkYHj112e0OvhREU91+yga14hW3uadcoyFi7yW+uC486M5ZBGauqG61ZHoRwbJLO8bw2jFu7YRqL8JrATlZ2cTO26O6HC6XLLD73vQz2ryhpg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(136003)(346002)(376002)(451199021)(46966006)(36840700001)(40470700004)(36860700001)(107886003)(316002)(41300700001)(6512007)(6486002)(83380400001)(47076005)(53546011)(336012)(186003)(2616005)(6506007)(26005)(478600001)(40460700003)(54906003)(82740400003)(356005)(81166007)(70206006)(70586007)(4326008)(40480700001)(5660300002)(86362001)(33656002)(82310400005)(8936002)(8676002)(6862004)(2906002)(36756003)(32563001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2023 15:13:35.2337 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 22a799ed-61ba-4f31-0788-08db7a45bd6e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6730 DQoNCj4gT24gMSBKdWwgMjAyMywgYXQgMDg6NTMsIEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29w ZXIzQGNpdHJpeC5jb20+IHdyb3RlOg0KPiANCj4gT24gMzAvMDYvMjAyMyAxMDoxMiBhbSwgTHVj YSBGYW5jZWxsdSB3cm90ZToNCj4+IFRoZSAiZG9tMGxlc3MiIGZlYXR1cmUgd2FzIGludGVuZGVk IHRvIGJlIHRoZSBmZWF0dXJlIHdoZXJlIGEgZG9tVQ0KPj4gZG9tYWluIGNvdWxkIGJlIGxhdW5j aGVkIHdpdGhvdXQgdGhlIGNvbnRyb2wgZG9tYWluIChEb20wKQ0KPj4gaW50ZXJ2ZW50aW9uLCBo b3dldmVyIHRoZSBuYW1lIHNlZW1zIHRvIHN1Z2dlc3QgdGhhdCBEb20wIGNhbm5vdA0KPj4gYmUg cGFydCBvZiB0aGUgY29uZmlndXJhdGlvbiwgd2hpbGUgaW5zdGVhZCBpdCdzIGEgcG9zc2libGUg dXNlIGNhc2UuDQo+PiANCj4+IFRvIGF2b2lkIHRoYXQsIHJlbmFtZSB0aGUgImRvbTBsZXNzIiBj b25maWd1cmF0aW9uIHdpdGggdGhlIG5hbWUNCj4+ICJoeXBlcmxhdW5jaCIsIHRoYXQgaXMgbGVz cyBtaXNsZWFkaW5nLg0KPj4gDQo+PiBTaWduZWQtb2ZmLWJ5OiBMdWNhIEZhbmNlbGx1IDxsdWNh LmZhbmNlbGx1QGFybS5jb20+DQo+PiAtLS0NCj4+IFRoaXMgaXMgYW4gUkZDIHRvIGdldCB0aGUg ZmVlbGluZyBvZiB0aGUgY29tbXVuaXR5IGFib3V0IHRoZSBuYW1lDQo+PiBjaGFuZ2UsIGZvciBu b3cgaXQncyBldmVyeXRoaW5nIGluIG9uZSBwYXRjaCBqdXN0IHRvIHNlZSBob3cgaXQNCj4+IHdp bGwgbG9vayBsaWtlLCBpZiB0aGVyZSBpcyBpbnRlcmVzdCBvbiBwcm9jZWVkaW5nIGludG8gaXQs IEkgY2FuDQo+PiBzcGxpdCBpbiBtb3JlIGNvbW1pdC4NCj4gDQo+IEhhdmUgeW91IGRpc2N1c3Nl ZCB0aGlzIHdpdGggRGFuIGFuZCBDaHJpcyBhdCBhbGw/ICBZb3UgaGF2ZW4ndCBldmVuDQo+IEND J2QgdGhlbS4NCg0KTm8sIHRoaXMgcmVuYW1lIGlkZWEgc3RhcnRlZCBmcm9tIGEgY2hhdCBkdXJp bmcgdGhlIHN1bW1pdCwgYW55d2F5IEp1bGllbg0KcHJvbXB0bHkgYWRkIHRoZW0gdG8gdGhlIEND LCBiZWNhdXNlIEkgZm9yZ290Lg0KDQo+IA0KPiBXaGlsZSB0aGVyZSBpcyBhIGxvdCBvZiBlbmQt Z29hbCBpbiBjb21tb24gYmV0d2VlbiB0aGUgZG9tMGxlc3MgYW5kDQo+IGh5cGVybGF1bmNoLCBh bmQgdGhhdCB0aGUgbmFtZSBkb20wbGVzcyBpcyBkZWVwbHkgbWlzbGVhZGluZywNCj4gaHlwZXJs YXVuY2ggaXMgc3BlY2lmaWNhbGx5IG5vdCB0aGlzLg0KDQpZZXMgSHlwZXJsYXVuY2ggaXMgbW9y ZSB0aGFuIHRoaXMsIGhvd2V2ZXIgYXMgSSBzYWlkLCB3aXRoIHRoaXMgUkZDIEkgd291bGQgbGlr ZQ0KdG8gZWFyIG9waW5pb25zLCBARGFuaWVsIEBDaHJpc3RvcGhlciBjb3VsZCBpdCBiZSBhIHBy b3BlciBuYW1lIGZvciB0aGUgZG9tMGxlc3MNCmZlYXR1cmU/DQoNCklmIHRoaXMgcGF0Y2ggbWFr ZXMgdGhpbmdzIG1vcmUgZGlmZmljdWx0IGZvciB0aGUgSHlwZXJsdW5jaCBzZXJpZSwgSeKAmW0g b2sgdG8gZHJvcCBpdCwNCm15IG9ubHkgYWltIHdhcyBqdXN0IHRvIGZpbmQgYSBsZXNzIG1pc2xl YWRpbmcgbmFtZSBmb3IgdGhlIGZlYXR1cmUuIA0KDQpDaGVlcnMsDQpMdWNhDQoNCj4gDQo+IH5B bmRyZXcNCg0K From xen-devel-bounces@lists.xenproject.org Sat Jul 01 15:21:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 15:21:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557892.871630 (Exim 4.92) (envelope-from ) id 1qFcPs-0006sg-Bm; Sat, 01 Jul 2023 15:21:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557892.871630; Sat, 01 Jul 2023 15:21:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFcPs-0006sZ-78; Sat, 01 Jul 2023 15:21:40 +0000 Received: by outflank-mailman (input) for mailman id 557892; Sat, 01 Jul 2023 15:21:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFcPr-0006sP-Ji; Sat, 01 Jul 2023 15:21:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFcPr-00076y-Av; Sat, 01 Jul 2023 15:21:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFcPr-0008I1-1G; Sat, 01 Jul 2023 15:21:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qFcPr-0008Hz-0q; Sat, 01 Jul 2023 15:21:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GoS06dio/3juijAcPylZc04+oIZynAkh3YggLH3eqEg=; b=5ClYksE1RLJUQGtt/RV4xjrKV/ U21VJ+yCt2un8w0SRUOBEPpOvJH9H3D7WlCdEMf2X7l2n1a563tCCfJj4jUQqPISn5lcy1w/AoO3k lI4yoUOZSZRdPAbOT8yJYGAB6JT9lvYSDXhnSAEqe7NeqKHI3jGI8MhKN4yJzpZT8XlQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 181667: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=7f1562a7397b789f6d540f0010405d089426a5a4 X-Osstest-Versions-That: libvirt=d7fb8deb6aa862a8098d8d933dd32a79931cd4dc From: osstest service owner Date: Sat, 01 Jul 2023 15:21:39 +0000 flight 181667 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/181667/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 181635 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 181635 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 181635 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: libvirt 7f1562a7397b789f6d540f0010405d089426a5a4 baseline version: libvirt d7fb8deb6aa862a8098d8d933dd32a79931cd4dc Last test of basis 181635 2023-06-29 04:21:51 Z 2 days Failing since 181649 2023-06-30 04:18:54 Z 1 days 2 attempts Testing same since 181667 2023-07-01 04:18:48 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Han Han Michal Privoznik Peter Krempa Yuri Chornoivan ê¹€ì¸ìˆ˜ jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git d7fb8deb6a..7f1562a739 7f1562a7397b789f6d540f0010405d089426a5a4 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Jul 01 15:52:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 15:52:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557898.871639 (Exim 4.92) (envelope-from ) id 1qFctO-0001rU-L2; Sat, 01 Jul 2023 15:52:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557898.871639; Sat, 01 Jul 2023 15:52:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFctO-0001rN-Gz; Sat, 01 Jul 2023 15:52:10 +0000 Received: by outflank-mailman (input) for mailman id 557898; Sat, 01 Jul 2023 15:52:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFctN-0001rH-HD for xen-devel@lists.xenproject.org; Sat, 01 Jul 2023 15:52:10 +0000 Received: from out203-205-221-202.mail.qq.com (out203-205-221-202.mail.qq.com [203.205.221.202]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 37959b9b-1827-11ee-b237-6b7b168915f2; Sat, 01 Jul 2023 17:52:03 +0200 (CEST) Received: from localhost.localdomain ([116.132.239.178]) by newxmesmtplogicsvrsza12-0.qq.com (NewEsmtp) with SMTP id CEC3EC5C; Sat, 01 Jul 2023 23:51:44 +0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 37959b9b-1827-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1688226707; bh=Ou1vBhUK87QUl5Q7dSsJPlf9T8VgS2NFf1k7CSQDkDY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=InzfP/PjalXsy1+062ZbHDH7LNSpAlZb/OGrkFlT6ZDcVxJ4s6E21Y0Jh5QIZW12E 8Q6ikCFwk6a7xFshJF2ClUrLspmGWaAzCwUa7DR26CeBpg0R82CYdvizzsxYzyHwiD EroHbCc8jD++VaWGfM/AMg/i+2aX4+bzXi2cjbQE= X-QQ-mid: xmsmtpt1688226704te5jbpodh Message-ID: X-QQ-XMAILINFO: MBf0q8AysQnB9O7sZj5jgSNUnizJ7WyO6idPxUw5LGBRfADxCatimjS8frcO53 OYG4ZoWqWzofoy5ziRmfTupTo+9SoOjDeAa2XX9YKT/v6+RqbSpF9nfPC/dGXC4N5shyi5gUCwOT onoHlWGeP9TLE3B6807xVCxkhTgd3gCIDZMm2wgDX5qq7cBSJjjDTJD+DhgAIWj3ijzYA8OazRjZ hCcsv3ngIQWuWZ0JSLmHwZ0UTSQCQ+9gatNz0ByQexx5wiifL6/U5IQ7aBk3ePXUrbKuGItZ/hth J0HU4mV5UX8OkRfpsjypjuHOye9svDBiMghR4ItEpq2kZmcX/kuf80ic6deCMBP6ElKiIBP9ff1M 4lOyjJfPUA9x/gXw+ENR6TGd92i29BwXM/DgZkKAqY8DUCD/yZ3yW2123KA9L3yVAbe94o2uKMzD OMRE+Re8ojaYsncs3JXQn+bYECgh2lMahvq6+QCkbEuT7Xp8xqlQ5jQgmTO2RvZWIJaOSknu1Jnr 9zgUDCBhqd0kM0AVy2PG2RsWQYFXmpk/nTTyhbSMz0mcugnZurXaV+Zalva/b+Z1rWGRSlmaHFG5 Nt4yPNg2xE5TQM5F0EOzRFkYY3z/EX45mBDeOQOayUqoRYNAr1XMUUeLW/1K4uMQ5vyErjZktHTT W5/dU7km1Hhw9eV1NMOvr6ebUdby4tj5Cre0paw+bqbVT+FxVEZ10nqTEPGgnPFF7CU7dg6ldQ+N BSVtP0u4M1PgcSaSx9O3vGFeCPowRXKZFUVilSO/Kg+reSKEHWpHGSvM931iETynrTcFIgaMb5sV uNWHwK/TtGkrB72YjZYAaZ4s/r91k4vXQb4o3gxi1hfa9DP4mGcVtTTZHXL2ujyaM38vMmB8EbF9 Ys7lowKPVSCv27wAE8K5uFPml5MLKQ+1/R2VHsVSEI06yNT6ndWmX2YHu27XEtRV/qRxg7QRs8mF 29XvdMS3b9UjAGJ9Pz/mO2TCWkoQvKZvrnJAhicjk1Ja1cW6BfCg== X-QQ-XMRINFO: M/715EihBoGSf6IYSX1iLFg= From: Zhang Shurong To: Greg KH Cc: jgross@suse.com, xen-devel@lists.xenproject.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] xen: fix potential shift out-of-bounds in xenhcd_hub_control() Date: Sat, 01 Jul 2023 23:51:43 +0800 X-OQ-MSGID: <4825193.GXAFRqVoOG@localhost.localdomain> In-Reply-To: <2023062628-shame-ebook-56f2@gregkh> References: <1c8ff405-2bfe-37ff-42ba-aa4f81853475@suse.com> <2023062628-shame-ebook-56f2@gregkh> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" =E5=9C=A8 2023=E5=B9=B46=E6=9C=8826=E6=97=A5=E6=98=9F=E6=9C=9F=E4=B8=80 CST= =E4=B8=8B=E5=8D=881:52:02=EF=BC=8C=E6=82=A8=E5=86=99=E9=81=93=EF=BC=9A > On Mon, Jun 26, 2023 at 07:48:05AM +0200, Jan Beulich wrote: > > On 25.06.2023 18:42, Zhang Shurong wrote: > > > --- a/drivers/usb/host/xen-hcd.c > > > +++ b/drivers/usb/host/xen-hcd.c > > > @@ -456,6 +456,8 @@ static int xenhcd_hub_control(struct usb_hcd *hcd, > > > __u16 typeReq, __u16 wValue,> >=20 > > > info->ports[wIndex - 1].c_connection =3D=20 false; > > > fallthrough; > > > =09 > > > default: > > > + if (wValue >=3D 32) > > > + goto error; > > >=20 > > > info->ports[wIndex - 1].status &=3D ~(1=20 << wValue); > >=20 > > Even 31 is out of bounds (as in: UB) as long as it's 1 here rather > > than 1u. >=20 > Why isn't the caller fixed so this type of value could never be passed > to the hub_control callback? >=20 > thanks, >=20 > greg k-h Although I'm not knowledgeable about the USB subsystem, I've observed that = not=20 all driver code that implements hub_control callback performs a shift=20 operation on wValue, and not all shift operations among them cause problems= =2E=20 Therefore, I've decided to fix this issue within each driver itself. =46or example, in r8a66597_hub_control, it will first check whether wValue = is=20 valid (always < 31) before the shift operation. In case of an invalid numbe= r,=20 the code would execute the error branch instead of the shift operation. switch (wValue) { case USB_PORT_FEAT_ENABLE: rh->port &=3D ~USB_PORT_STAT_POWER; break; case USB_PORT_FEAT_SUSPEND: break; case USB_PORT_FEAT_POWER: r8a66597_port_power(r8a66597, port, 0); break; case USB_PORT_FEAT_C_ENABLE: case USB_PORT_FEAT_C_SUSPEND: case USB_PORT_FEAT_C_CONNECTION: case USB_PORT_FEAT_C_OVER_CURRENT: case USB_PORT_FEAT_C_RESET: break; default: goto error; } rh->port &=3D ~(1 << wValue); From xen-devel-bounces@lists.xenproject.org Sat Jul 01 18:48:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Jul 2023 18:48:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557928.871666 (Exim 4.92) (envelope-from ) id 1qFfdf-0003i1-1G; Sat, 01 Jul 2023 18:48:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557928.871666; Sat, 01 Jul 2023 18:48:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFfde-0003hu-UH; Sat, 01 Jul 2023 18:48:06 +0000 Received: by outflank-mailman (input) for mailman id 557928; Sat, 01 Jul 2023 18:48:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFfdd-0003hi-HY; Sat, 01 Jul 2023 18:48:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFfdd-0003zu-2i; Sat, 01 Jul 2023 18:48:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFfdc-0004XK-LP; Sat, 01 Jul 2023 18:48:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qFfdc-0002BG-Kw; Sat, 01 Jul 2023 18:48:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Qj0LN2knW0cGsYNJGeC2CrGgPU68rgVo9dnZX90nU6I=; b=JCqv9JjdK9n+NHYY50MhMBHovm FNxp57l9ZFhx4sqyuC2lCF10qWk3IUgCVuKxWpOTK248UZsJYpbRK2qr7+vyucSCd1axVwlhpg+2s hDbKFj4BwEzZrI2tIlr7LkPabGsOxd2Yl/yKljnK/mdpgL0bmF8Wx2DJW17cH0YNZL1g=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 181670: regressions - trouble: broken/fail/pass X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-pvshim::broken:regression linux-linus:test-amd64-amd64-xl-pvshim:host-install(5):broken:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-credit2:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-coresched-amd64-xl:debian-install:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:debian-di-install:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-vhd:guest-start:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-examine:reboot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=a507db1d8fdc39802415e4d2ef6d1aecd67927fa X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Sat, 01 Jul 2023 18:48:04 +0000 flight 181670 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/181670/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvshim broken test-amd64-amd64-xl-pvshim 5 host-install(5) broken REGR. vs. 180278 test-amd64-amd64-qemuu-nested-amd 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-pygrub 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-pvhv2-amd 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-ovmf-amd64 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-credit2 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-multivcpu 14 guest-start fail REGR. vs. 180278 test-amd64-coresched-amd64-xl 12 debian-install fail REGR. vs. 180278 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 180278 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 180278 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 12 debian-hvm-install fail REGR. vs. 180278 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 180278 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 180278 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-libvirt-qcow2 12 debian-di-install fail REGR. vs. 180278 test-arm64-arm64-libvirt-raw 13 guest-start fail REGR. vs. 180278 test-arm64-arm64-xl-vhd 13 guest-start fail REGR. vs. 180278 test-amd64-amd64-examine 8 reboot fail REGR. vs. 180278 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 180278 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 180278 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 180278 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-vhd 8 xen-boot fail like 180278 test-armhf-armhf-xl 8 xen-boot fail like 180278 test-armhf-armhf-xl-arndale 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-raw 8 xen-boot fail like 180278 test-armhf-armhf-xl-credit2 8 xen-boot fail like 180278 test-armhf-armhf-examine 8 reboot fail like 180278 test-armhf-armhf-libvirt 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail like 180278 test-armhf-armhf-xl-rtds 8 xen-boot fail like 180278 test-armhf-armhf-xl-multivcpu 8 xen-boot fail like 180278 test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: linux a507db1d8fdc39802415e4d2ef6d1aecd67927fa baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 75 days Failing since 180281 2023-04-17 06:24:36 Z 75 days 145 attempts Testing same since 181670 2023-07-01 07:09:15 Z 0 days 1 attempts ------------------------------------------------------------ 3548 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim broken test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-xl-pvshim broken broken-step test-amd64-amd64-xl-pvshim host-install(5) Not pushing. (No revision log; it would be 568500 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 02 01:59:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Jul 2023 01:59:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557936.871676 (Exim 4.92) (envelope-from ) id 1qFmMu-0005GO-JN; Sun, 02 Jul 2023 01:59:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557936.871676; Sun, 02 Jul 2023 01:59:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFmMu-0005GA-DX; Sun, 02 Jul 2023 01:59:16 +0000 Received: by outflank-mailman (input) for mailman id 557936; Sun, 02 Jul 2023 01:59:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFmMs-0005G0-Gy; Sun, 02 Jul 2023 01:59:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFmMs-0006Sx-AI; Sun, 02 Jul 2023 01:59:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFmMr-0005kz-Lc; Sun, 02 Jul 2023 01:59:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qFmMr-0002pp-L8; Sun, 02 Jul 2023 01:59:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dXmQ12fR0auaa3jORWkQc3ETgSbTCupjRuB24YdvBRw=; b=oQ86OhyRZzPIDB9pPcmaKbsE8k 5gxq7sYkujLNyo8dEn4JMrQDH5W8duzMA37+Yaumewfp66jol+enr2Zym+hcAdLbh4FOgheFwEBMf Cm52+0HSp7+YdixL1qvPdBu67MoG7qTl/ESLLvM9595XbS7MkIaZnt6oUAP7omNJkemU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 181677: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-qemuu-nested-amd:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-pygrub:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:debian-install:fail:regression linux-linus:test-amd64-amd64-xl-credit2:debian-install:fail:regression linux-linus:test-amd64-coresched-amd64-xl:debian-install:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-vhd:guest-start:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-rtds:leak-check/basis(11):fail:allowable linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-examine:reboot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=f8566aa4f1766bb0267b7a0ed89c1d2c4a82ee1a X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Sun, 02 Jul 2023 01:59:13 +0000 flight 181677 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/181677/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-amd 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-pygrub 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-credit1 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-debianhvm-amd64 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-pvhv2-amd 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-freebsd11-amd64 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-multivcpu 12 debian-install fail REGR. vs. 180278 test-amd64-amd64-xl-credit2 12 debian-install fail REGR. vs. 180278 test-amd64-coresched-amd64-xl 12 debian-install fail REGR. vs. 180278 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 180278 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 180278 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 180278 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 180278 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 180278 test-arm64-arm64-libvirt-raw 13 guest-start fail REGR. vs. 180278 test-arm64-arm64-xl-vhd 13 guest-start fail REGR. vs. 180278 test-amd64-amd64-examine 8 reboot fail REGR. vs. 180278 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 180278 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 180278 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 11 leak-check/basis(11) fail REGR. vs. 180278 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-vhd 8 xen-boot fail like 180278 test-armhf-armhf-xl 8 xen-boot fail like 180278 test-armhf-armhf-xl-arndale 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-raw 8 xen-boot fail like 180278 test-armhf-armhf-xl-credit2 8 xen-boot fail like 180278 test-armhf-armhf-examine 8 reboot fail like 180278 test-armhf-armhf-libvirt 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail like 180278 test-armhf-armhf-xl-rtds 8 xen-boot fail like 180278 test-armhf-armhf-xl-multivcpu 8 xen-boot fail like 180278 test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: linux f8566aa4f1766bb0267b7a0ed89c1d2c4a82ee1a baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 76 days Failing since 180281 2023-04-17 06:24:36 Z 75 days 146 attempts Testing same since 181677 2023-07-01 19:13:12 Z 0 days 1 attempts ------------------------------------------------------------ 3558 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 572370 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 02 09:20:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Jul 2023 09:20:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557948.871685 (Exim 4.92) (envelope-from ) id 1qFtFq-0000JT-33; Sun, 02 Jul 2023 09:20:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557948.871685; Sun, 02 Jul 2023 09:20:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFtFq-0000JM-0D; Sun, 02 Jul 2023 09:20:26 +0000 Received: by outflank-mailman (input) for mailman id 557948; Sun, 02 Jul 2023 09:20:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFtFo-0000JC-Jl; Sun, 02 Jul 2023 09:20:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFtFo-0000vG-7e; Sun, 02 Jul 2023 09:20:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFtFn-0006lS-Q1; Sun, 02 Jul 2023 09:20:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qFtFn-0004C6-P7; Sun, 02 Jul 2023 09:20:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=9bPHHh/bR1EQx6IcDXUMgddufuSR2ELKGLKLf9A6844=; b=f5pHkrLQsyxY/OmRINvUglc8EY TTOEBq5Uyb3OXcDRBnnLiqu+C1XgQctHx2h+HsqDxB5gm5t+luwkNtOBz7lt6LPWBsPBwXbs6BbFz HJgMLF2cIK75tlUi2DI0Rn/x1C3C9aAt3I3pXorK5XLm63JZkvGvA4qkPgfp/zJFbKyM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 181678: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-i386-freebsd10-i386:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-livepatch:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-libvirt:xen-install:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=f51e5d8eae8ece77a949571f39ee49904f3129aa X-Osstest-Versions-That: xen=f51e5d8eae8ece77a949571f39ee49904f3129aa From: osstest service owner Date: Sun, 02 Jul 2023 09:20:23 +0000 flight 181678 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/181678/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail in 181665 pass in 181678 test-amd64-i386-freebsd10-i386 7 xen-install fail pass in 181665 test-amd64-i386-livepatch 7 xen-install fail pass in 181665 Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt 7 xen-install fail like 181665 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 181665 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 181665 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 181665 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 181665 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 181665 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 181665 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 181665 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 181665 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 181665 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 181665 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 181665 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 181665 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen f51e5d8eae8ece77a949571f39ee49904f3129aa baseline version: xen f51e5d8eae8ece77a949571f39ee49904f3129aa Last test of basis 181678 2023-07-02 01:54:30 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-livepatch pass test-amd64-i386-livepatch fail test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun Jul 02 12:12:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Jul 2023 12:12:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557965.871695 (Exim 4.92) (envelope-from ) id 1qFvwU-0000uZ-KW; Sun, 02 Jul 2023 12:12:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557965.871695; Sun, 02 Jul 2023 12:12:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFvwU-0000uS-Ht; Sun, 02 Jul 2023 12:12:38 +0000 Received: by outflank-mailman (input) for mailman id 557965; Sun, 02 Jul 2023 12:12:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFvwT-0000tz-Nr; Sun, 02 Jul 2023 12:12:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFvwT-0004nC-A2; Sun, 02 Jul 2023 12:12:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFvwS-0002JB-OS; Sun, 02 Jul 2023 12:12:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qFvwS-0001VC-Nr; Sun, 02 Jul 2023 12:12:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Otod0N0YjCqYJ3E37N56L7RCgwrrZL5LaN8zUQItbVA=; b=hJrKH/sLcdTTI3SVyjHW287sOM llZbF70KEqtc64KqSDWxqaWXGIEG4TwdpduvuoyQH+CC7Pwp3REUvn1w3fzjNQKaNZ5csZe5x3rU/ eKiNrr6uLUyD2uDBVPDrHp7aDADbtlhWmzHKBP7EASUy0erJ/KsEV+YAzwLb2FnDAy5Q=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 181679: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-examine-bios:host-install:broken:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-credit2:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:debian-install:fail:regression linux-linus:test-amd64-amd64-xl-credit1:debian-install:fail:regression linux-linus:test-amd64-coresched-amd64-xl:debian-install:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-vhd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-localmigrate/x10:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-xl-rtds:debian-install:fail:allowable linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-examine:reboot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=dfab92f27c600fea3cadc6e2cb39f092024e1fef X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Sun, 02 Jul 2023 12:12:36 +0000 flight 181679 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/181679/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-examine-bios 5 host-install broken REGR. vs. 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-libvirt 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-xsm 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-pvhv2-amd 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-credit2 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-freebsd11-amd64 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-debianhvm-amd64 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-multivcpu 12 debian-install fail REGR. vs. 180278 test-amd64-amd64-xl-credit1 12 debian-install fail REGR. vs. 180278 test-amd64-coresched-amd64-xl 12 debian-install fail REGR. vs. 180278 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 180278 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 180278 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 180278 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 180278 test-amd64-amd64-libvirt-qcow2 12 debian-di-install fail REGR. vs. 180278 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 180278 test-arm64-arm64-libvirt-raw 13 guest-start fail REGR. vs. 180278 test-arm64-arm64-xl-vhd 13 guest-start fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 18 guest-localmigrate/x10 fail REGR. vs. 180278 test-amd64-amd64-examine 8 reboot fail REGR. vs. 180278 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 180278 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 12 debian-install fail REGR. vs. 180278 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-vhd 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-raw 8 xen-boot fail like 180278 test-armhf-armhf-xl 8 xen-boot fail like 180278 test-armhf-armhf-xl-arndale 8 xen-boot fail like 180278 test-armhf-armhf-examine 8 reboot fail like 180278 test-armhf-armhf-libvirt 8 xen-boot fail like 180278 test-armhf-armhf-xl-credit2 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail like 180278 test-armhf-armhf-xl-rtds 8 xen-boot fail like 180278 test-armhf-armhf-xl-multivcpu 8 xen-boot fail like 180278 test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: linux dfab92f27c600fea3cadc6e2cb39f092024e1fef baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 76 days Failing since 180281 2023-04-17 06:24:36 Z 76 days 147 attempts Testing same since 181679 2023-07-02 02:02:57 Z 0 days 1 attempts ------------------------------------------------------------ 3559 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-step test-amd64-amd64-examine-bios host-install Not pushing. (No revision log; it would be 572989 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 02 12:35:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Jul 2023 12:35:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557971.871706 (Exim 4.92) (envelope-from ) id 1qFwI6-0003OI-Ex; Sun, 02 Jul 2023 12:34:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557971.871706; Sun, 02 Jul 2023 12:34:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFwI6-0003OB-B3; Sun, 02 Jul 2023 12:34:58 +0000 Received: by outflank-mailman (input) for mailman id 557971; Sun, 02 Jul 2023 12:34:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFwI4-0003O1-OM; Sun, 02 Jul 2023 12:34:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFwI4-0005CK-E1; Sun, 02 Jul 2023 12:34:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qFwI3-0002sg-UL; Sun, 02 Jul 2023 12:34:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qFwI3-0007Tb-To; Sun, 02 Jul 2023 12:34:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ynqZEECCfEvPX2FnutKaC9TlrmAHQDTBXdKtCXABFzo=; b=uwinmXfXS76dQAT9MdSWjy/2Lu h5GLg9SzvfExGLXGapIS76CxRzvJDwr5mKMHhTOE1SaDQ1S+wjZ3g5DEBCCupYOEKY1q4PYL30XJ4 XdOAp/FXybSb9Va7DZwd9cQrXE2S+3v9QpZ/3emDWWUPkQ7nYj9zZFJZDaMMYqPSCTwc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 181680: all pass - PUSHED X-Osstest-Versions-This: ovmf=ad7d3ace1ad4d7350d1e1304fab86dffd0f3fd11 X-Osstest-Versions-That: ovmf=5a13f5c2fa5ada2eb2fcb961aa3745fd236620bd From: osstest service owner Date: Sun, 02 Jul 2023 12:34:55 +0000 flight 181680 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/181680/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf ad7d3ace1ad4d7350d1e1304fab86dffd0f3fd11 baseline version: ovmf 5a13f5c2fa5ada2eb2fcb961aa3745fd236620bd Last test of basis 181659 2023-06-30 16:42:33 Z 1 days Testing same since 181680 2023-07-02 10:43:52 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Tuan Phan jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 5a13f5c2fa..ad7d3ace1a ad7d3ace1ad4d7350d1e1304fab86dffd0f3fd11 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sun Jul 02 19:09:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Jul 2023 19:09:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557977.871715 (Exim 4.92) (envelope-from ) id 1qG2Rk-0008Rj-Bl; Sun, 02 Jul 2023 19:09:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557977.871715; Sun, 02 Jul 2023 19:09:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qG2Rk-0008Rc-9F; Sun, 02 Jul 2023 19:09:20 +0000 Received: by outflank-mailman (input) for mailman id 557977; Sun, 02 Jul 2023 19:09:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qG2Rj-0008RS-9T; Sun, 02 Jul 2023 19:09:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qG2Ri-0006kN-UM; Sun, 02 Jul 2023 19:09:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qG2Ri-0003KO-CU; Sun, 02 Jul 2023 19:09:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qG2Ri-0004tb-C5; Sun, 02 Jul 2023 19:09:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=WZYu1mwg4DR1ah1UE/6qoYqlf8zHWkNInmq0SGAkmkE=; b=kA+fy4apUP+e5YdWse9B3qaJn8 4GO1bt7+I6A7ZkYREvSZMOYU9gZ1rzjgYepgTIad2YokHQ1fkqV9s0qouxI5gWEg+DAb0LhOIf7dk XC37Sn2VUmTc/JYHcFj5IHoCC87iW7AQW1iCqcIGl3moQUrTzx80MISNT0ze1lYuDRQE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 181681: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-libvirt:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-credit2:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-coresched-amd64-xl:debian-install:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:debian-di-install:fail:regression linux-linus:test-arm64-arm64-xl-vhd:guest-start:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:guest-start:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-rtds:leak-check/basis(11):fail:allowable linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-examine:reboot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=995b406c7e972fab181a4bb57f3b95e59b8e5bf3 X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Sun, 02 Jul 2023 19:09:18 +0000 flight 181681 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/181681/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-credit1 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-libvirt 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-libvirt-qcow2 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-credit2 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-shadow 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-multivcpu 14 guest-start fail REGR. vs. 180278 test-amd64-coresched-amd64-xl 12 debian-install fail REGR. vs. 180278 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 180278 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 12 debian-hvm-install fail REGR. vs. 180278 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 180278 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 180278 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 180278 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-pygrub 12 debian-di-install fail REGR. vs. 180278 test-arm64-arm64-xl-vhd 13 guest-start fail REGR. vs. 180278 test-arm64-arm64-libvirt-raw 13 guest-start fail REGR. vs. 180278 test-amd64-amd64-examine 8 reboot fail REGR. vs. 180278 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 180278 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 180278 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 11 leak-check/basis(11) fail REGR. vs. 180278 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-vhd 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-raw 8 xen-boot fail like 180278 test-armhf-armhf-xl 8 xen-boot fail like 180278 test-armhf-armhf-xl-arndale 8 xen-boot fail like 180278 test-armhf-armhf-examine 8 reboot fail like 180278 test-armhf-armhf-libvirt 8 xen-boot fail like 180278 test-armhf-armhf-xl-credit2 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail like 180278 test-armhf-armhf-xl-rtds 8 xen-boot fail like 180278 test-armhf-armhf-xl-multivcpu 8 xen-boot fail like 180278 test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: linux 995b406c7e972fab181a4bb57f3b95e59b8e5bf3 baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 76 days Failing since 180281 2023-04-17 06:24:36 Z 76 days 148 attempts Testing same since 181681 2023-07-02 12:41:42 Z 0 days 1 attempts ------------------------------------------------------------ 3559 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 573018 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 02 22:26:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Jul 2023 22:26:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557985.871725 (Exim 4.92) (envelope-from ) id 1qG5W4-00030E-3s; Sun, 02 Jul 2023 22:26:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557985.871725; Sun, 02 Jul 2023 22:26:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qG5W4-000307-1G; Sun, 02 Jul 2023 22:26:00 +0000 Received: by outflank-mailman (input) for mailman id 557985; Sun, 02 Jul 2023 22:25:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qG5W2-0002zy-3G for xen-devel@lists.xenproject.org; Sun, 02 Jul 2023 22:25:58 +0000 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [2a00:1450:4864:20::32f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 67cdac44-1927-11ee-b237-6b7b168915f2; Mon, 03 Jul 2023 00:25:55 +0200 (CEST) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-3fbd33a57ddso11000085e9.1 for ; Sun, 02 Jul 2023 15:25:53 -0700 (PDT) Received: from [127.0.0.1] (dynamic-089-014-031-053.89.14.pool.telefonica.de. [89.14.31.53]) by smtp.gmail.com with ESMTPSA id d1-20020a5d6dc1000000b00304adbeeabbsm23974422wrz.99.2023.07.02.15.25.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Jul 2023 15:25:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 67cdac44-1927-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688336752; x=1690928752; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=brJ53WepNRWQm12rssTXlqHMNSqdSpQ3iotpQXlBldw=; b=oFqiyjgCuw2kW5i4vvmVZhxFlTsWp8F5rVJGhXKMmfgN63339ooPR9xS3m/kDP8SfX OLuDVL953iL23YmgupptKXaWSzl4RBQsMyAK3WJz5PKjjnmy4n2s+ljEtdKuSuzPwuFW IiKPjjm+JWazTicIUT+52zRkm237ipHDrqVC/hXxyJj6ZQbg2Vp79R0ZYIVtdhdrtOyR byn/DqsvsFuhpQIzNlpKDupg8y3fqzBMmtI2KyDlNXtfJf/UJzWmYDn7UlDEfOd4pQ0i zILn3nJMcFa/nRE6m6JCbc2a/wpYQSo2p4dW87txGhyY9C/2hCiK99ozy7xrdPUcLivU aoVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688336752; x=1690928752; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=brJ53WepNRWQm12rssTXlqHMNSqdSpQ3iotpQXlBldw=; b=PUUpzBQC5gc8HSONHTK+FUAKiIKd+ZJ5HHPO2jiSFk8KVyVxVZzvYcY3FUMx/5rY9P U3r6aKTHPcZfMAm9FT/ICEwYblVWFjsdyzs76b8vtlCQEJq+lhhJBixZfTK3mPsbbsan DrjvfjV7IaHp5Td/fTY8l+iQI3LycJvXsTU7jhW8kU0GHjYujIam4tDbrOANy4wYDRGv RTwMXX93mz7d+LxgfNhldGN6TVRM7qDHBZzXbK4WKPWpX2O13KEKMKe3i3UZdN6V6hpU w4T4Nuhcp10oGt0rk4uNBnZeh8gn+ViMMiVVcjE0fZF1NZCn/bklp6/9inGvGftIbnnJ 4Nnw== X-Gm-Message-State: AC+VfDxLLm0qalMdI95Rm0Iq5u73nxNZxTD/bJaMv8YC3WsTKwe6qgkm ijvFPYodN8vCYQrcCA10V3o= X-Google-Smtp-Source: ACHHUZ5rXCXbjGsIoh5YArs96eCY9/yS9S2QYFz0k3XpXbCvtiSaj9YvSmw1rVnMHxW1fJOK8nsAZA== X-Received: by 2002:a7b:c847:0:b0:3fa:9348:51a8 with SMTP id c7-20020a7bc847000000b003fa934851a8mr6265209wml.23.1688336752463; Sun, 02 Jul 2023 15:25:52 -0700 (PDT) Date: Sun, 02 Jul 2023 22:25:48 +0000 From: Bernhard Beschow To: Mark Cave-Ayland , Paolo Bonzini CC: Olaf Hering , qemu-devel , John Snow , "open list:X86" , Stefano Stabellini Subject: Re: [PATCH v2] piix: fix regression during unplug in Xen HVM domUs In-Reply-To: References: <20210317070046.17860-1-olaf@aepfle.de> <4441d32f-bd52-9408-cabc-146b59f0e4dc@redhat.com> <20210325121219.7b5daf76.olaf@aepfle.de> <20230509225818.GA16290@aepfle.de> <20230626231901.5b5d11c1.olaf@aepfle.de> <5DB37FA5-41DF-4ED6-8C8A-CDDD6F276F42@gmail.com> <20230627140740.2736f6e8.olaf@aepfle.de> <4F5609FD-4A89-4450-89E2-3311CC5A9317@gmail.com> <3987B0DB-46F2-49F1-AEA5-B88BC61A633F@gmail.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 1=2E Juli 2023 11:58:57 UTC schrieb Mark Cave-Ayland : >On 01/07/2023 10:53, Bernhard Beschow wrote: > >> Am 30=2E Juni 2023 08:48:02 UTC schrieb Paolo Bonzini : >>> Il mer 28 giu 2023, 13:28 Bernhard Beschow ha sc= ritto: >>>=20 >>>>=20 >>>>=20 >>>> Am 27=2E Juni 2023 12:07:40 UTC schrieb Olaf Hering : >>>>> Tue, 27 Jun 2023 10:12:50 +0000 Bernhard Beschow : >>>>>=20 >>>>>> The BAR is a 32 bit register whose default value is 0x00000001=2E I= think >>>> what's supposed to happen here is a pci_set_long() rather than a >>>> pci_set_byte()=2E >>>>>=20 >>>>> Indeed, the u32 at that address changes from c121 to c101 with the >>>> current code=2E >>>>=20 >>>> Neat! Would you mind sending a patch fixing the BMIBA register to be = reset >>>> as 32 bit? >>>>=20 >>>=20 >>> I think we should also check why writing the command register is not >>> disabling the BAR as well=2E >>=20 >> So IIUC the BMIBA register is managed internally by QEMU's PCI code and= we shouldn't have to mess with the register at all=2E We should actually r= emove the explicit reset of BMIBA, correct? >>=20 >> I've tried debugging the PCI code when working on the VIA IDE controlle= r to understand it better=2E But despite QEMU being compiled with --enable-= debug it seemd to be compiled with -O2 still, making debugging quite hard= =2E I'm not sure if any compile flags leak into my build environment though= =2E > >Certainly --enable-debug normally does the right thing when building QEMU= =2E If you want to double-check the compiler flags in use to see if anythin= g from CFLAGS/LDFLAGS is getting picked up, use "make V=3D1" after configur= e which outputs the full command being used during the build rather than ju= st the summary=2E --enable-debug does the right thing indeed=2E The error was on my side=2E = Solved! Thanks, Bernhard > > >ATB, > >Mark=2E > From xen-devel-bounces@lists.xenproject.org Mon Jul 03 02:11:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Jul 2023 02:11:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557990.871735 (Exim 4.92) (envelope-from ) id 1qG92G-000863-Ul; Mon, 03 Jul 2023 02:11:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557990.871735; Mon, 03 Jul 2023 02:11:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qG92G-00085w-Rt; Mon, 03 Jul 2023 02:11:28 +0000 Received: by outflank-mailman (input) for mailman id 557990; Mon, 03 Jul 2023 02:11:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qG92F-00085m-SZ; Mon, 03 Jul 2023 02:11:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qG92F-0007fF-FT; Mon, 03 Jul 2023 02:11:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qG92F-00048F-2W; Mon, 03 Jul 2023 02:11:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qG92F-0007do-21; Mon, 03 Jul 2023 02:11:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6McL7mdpwCXDRZC2fTA2njb0KLViejys6X52lqhknGs=; b=akU1Mz58BVREn01Gc6Oz9oCxjN S70coIg+uYG02fV+nJmv4oLc2qgE1/zPWuntWQsKsz71wz1Xal0Tk9Jz6AXbtvv+19nnVo2w4jp2B xbeo6vkjux72NYD1JgZ7WP3t9YpcbaV2qoYRciUsVnC9kzZv9NZ0yRpDBUzoosVlxtRA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 181682: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-qemuu-nested-amd:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-libvirt:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-credit2:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:debian-install:fail:regression linux-linus:test-amd64-amd64-xl-xsm:debian-install:fail:regression linux-linus:test-amd64-amd64-xl:debian-install:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:leak-check/basis/dst_host(19):fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:build-arm64-pvops:kernel-build:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-examine:reboot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:nonblocking X-Osstest-Versions-This: linux=a901a3568fd26ca9c4a82d8bc5ed5b3ed844d451 X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Mon, 03 Jul 2023 02:11:27 +0000 flight 181682 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/181682/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-amd 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-ws16-amd64 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-debianhvm-amd64 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-credit1 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-libvirt 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-libvirt-qcow2 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-pvhv2-amd 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-credit2 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-freebsd11-amd64 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-multivcpu 12 debian-install fail REGR. vs. 180278 test-amd64-amd64-xl-xsm 12 debian-install fail REGR. vs. 180278 test-amd64-amd64-xl 12 debian-install fail REGR. vs. 180278 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-libvirt-pair 19 leak-check/basis/dst_host(19) fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 180278 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 180278 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 180278 test-amd64-amd64-examine 8 reboot fail REGR. vs. 180278 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 180278 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 180278 build-arm64-pvops 6 kernel-build fail REGR. vs. 180278 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 180278 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl 8 xen-boot fail like 180278 test-armhf-armhf-xl-vhd 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-raw 8 xen-boot fail like 180278 test-armhf-armhf-xl-arndale 8 xen-boot fail like 180278 test-armhf-armhf-examine 8 reboot fail like 180278 test-armhf-armhf-libvirt 8 xen-boot fail like 180278 test-armhf-armhf-xl-multivcpu 8 xen-boot fail like 180278 test-armhf-armhf-xl-credit2 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail like 180278 test-armhf-armhf-xl-rtds 8 xen-boot fail like 180278 version targeted for testing: linux a901a3568fd26ca9c4a82d8bc5ed5b3ed844d451 baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 77 days Failing since 180281 2023-04-17 06:24:36 Z 76 days 149 attempts Testing same since 181682 2023-07-02 19:42:58 Z 0 days 1 attempts ------------------------------------------------------------ 3562 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine blocked test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 574059 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Jul 03 05:13:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Jul 2023 05:13:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.557996.871746 (Exim 4.92) (envelope-from ) id 1qGBs4-0001it-Al; Mon, 03 Jul 2023 05:13:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 557996.871746; Mon, 03 Jul 2023 05:13:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGBs4-0001im-7G; Mon, 03 Jul 2023 05:13:08 +0000 Received: by outflank-mailman (input) for mailman id 557996; Mon, 03 Jul 2023 05:13:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGBs2-0001id-NF for xen-devel@lists.xenproject.org; Mon, 03 Jul 2023 05:13:06 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on20625.outbound.protection.outlook.com [2a01:111:f400:fe1b::625]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 49340db7-1960-11ee-b237-6b7b168915f2; Mon, 03 Jul 2023 07:13:03 +0200 (CEST) Received: from AS9PR06CA0775.eurprd06.prod.outlook.com (2603:10a6:20b:484::30) by PA4PR08MB6111.eurprd08.prod.outlook.com (2603:10a6:102:e3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Mon, 3 Jul 2023 05:12:55 +0000 Received: from AM7EUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:484:cafe::c7) by AS9PR06CA0775.outlook.office365.com (2603:10a6:20b:484::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.26 via Frontend Transport; Mon, 3 Jul 2023 05:12:55 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT022.mail.protection.outlook.com (100.127.140.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.17 via Frontend Transport; Mon, 3 Jul 2023 05:12:55 +0000 Received: ("Tessian outbound e2424c13b707:v142"); Mon, 03 Jul 2023 05:12:54 +0000 Received: from 0ee6d2e92890.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4D577E4A-520E-4358-9E83-EDA5E301BCBF.1; Mon, 03 Jul 2023 05:12:48 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0ee6d2e92890.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 03 Jul 2023 05:12:48 +0000 Received: from AM0PR02CA0168.eurprd02.prod.outlook.com (2603:10a6:20b:28d::35) by PA4PR08MB7409.eurprd08.prod.outlook.com (2603:10a6:102:2a1::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Mon, 3 Jul 2023 05:12:44 +0000 Received: from AM7EUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:28d:cafe::dc) by AM0PR02CA0168.outlook.office365.com (2603:10a6:20b:28d::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.30 via Frontend Transport; Mon, 3 Jul 2023 05:12:44 +0000 Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT039.mail.protection.outlook.com (100.127.140.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6565.17 via Frontend Transport; Mon, 3 Jul 2023 05:12:43 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 3 Jul 2023 05:12:43 +0000 Received: from [10.169.188.49] (10.169.188.49) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 3 Jul 2023 05:12:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 49340db7-1960-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=axvEImVGxii6NhLjRL7WGbueaxr5sezn9TuDmMDurvc=; b=v0TnHkEOSXYPI0iGw1EZFq43Lk1gWtF6Bb86WreZErSx6AFd5udKFeaDcndf3jVHwEmlS0vATsR2k2jR7Yyzz5Gpy1rizAb0SBcPMesHvR69wMQhT1VSdRvqhLaCWFBfxRwJGQPOOkeLJi7dj7r68Gf4jvGNpzo9yLk5R8uk+EQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 27f3d11d83933588 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZM7sA2nkkPkd+ajtJxfezYOMnUWnT5c1QLd112bSzR7/iTx1xTYcEiywZ+kvSe0B8QyhMdrWNT90tkQcSbErcq7wuOV2mcycSjGZYKDrDBRcheAuYq1ZqEVcvYclnlJQFyY0Sekdux15sH98srguy85DTdXvWml8Cq0WHmnJEzOwEGP9ye1KgaByVifqYeCg2roGR2xcOpVw5Cx5yWTEVjXsL7YY0DgVbYZ6gne86mc4h2iHZtpwq++JO1YKAW3qIPe+Y60UvTjsM+TjdO0VHE61eyCTTZkvK9wZWpROTbiSlXjL4dzhzFYoPimUeyWOhxxugsklnpznnvkFvhaN7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=axvEImVGxii6NhLjRL7WGbueaxr5sezn9TuDmMDurvc=; b=kk7J9q0E1I2wM/NxlbiGZbAHYfciw9mrb/hZGvgaWaLkyNTQP1iG8lNGghnGqpMqwCKyEWo4WrJo/Xx9P3i2rmqk9ozdmfoQG3/vX01WZa83kkXSeLVcQVEBZA63PSXqAQcEBJJLPFrGfbg7n/zAlf7E6e2Rw8v4i+C6ihdrdkfFXuu6+F2BkLI62RterA4/zEKiG7CtXdwPAVMNcPmpqP+8yOVMw3G6+3ubhGcLgC9ixmV55K6lKdmifglNe1pAR5zqqfZPHX1L3EmUh9RBmiCemE2d307wPQsYtct3RawZOlqn35hbohKPAhRObbAQT9WwQWerpdEQv0aJ2QJOVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=xen.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=axvEImVGxii6NhLjRL7WGbueaxr5sezn9TuDmMDurvc=; b=v0TnHkEOSXYPI0iGw1EZFq43Lk1gWtF6Bb86WreZErSx6AFd5udKFeaDcndf3jVHwEmlS0vATsR2k2jR7Yyzz5Gpy1rizAb0SBcPMesHvR69wMQhT1VSdRvqhLaCWFBfxRwJGQPOOkeLJi7dj7r68Gf4jvGNpzo9yLk5R8uk+EQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C Message-ID: Date: Mon, 3 Jul 2023 13:12:39 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 31/52] xen/mpu: make early_fdt_map support in MPU systems Content-Language: en-US To: Julien Grall , Ayan Kumar Halder , CC: Stefano Stabellini , Bertrand Marquis , Wei Chen , "Volodymyr_Babchuk@epam.com" References: <20230626033443.2943270-1-Penny.Zheng@arm.com> <20230626033443.2943270-32-Penny.Zheng@arm.com> <9530f9f8-795b-783a-bc74-e30a3c5c2fd3@amd.com> From: Penny Zheng In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT039:EE_|PA4PR08MB7409:EE_|AM7EUR03FT022:EE_|PA4PR08MB6111:EE_ X-MS-Office365-Filtering-Correlation-Id: 95618774-3ce8-4307-f8af-08db7b8428ae x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 1JuUhXCYSyrJK0QL2s+J/rFLJabzub8bJyZLv6Bu0+ooAfuZa0Cxy6Pp40dPwn08/6IE6HP1QAXFNceNfSjmVKo+Zb/qVBtW9SLrwf6RFF2RbWQSG34wRygQ432L8a60nvJ2nG6YTxLYA81buXUGSs4U8DDaC//nsDUgbibiryf/EMJQ+J4Y1EbrCxloBfjCkVRSLo8wXV28Fkmq4uZUO3xtgEN/j/r1PLO9SPBYcSjz06TeoWAHzKqU6mnQb2zMp8xW22G8Xgyfi4WM4AR3exzm3aNqk/WNqaBJREHsbsJEMhReaesVD28wPttEaSRXkkZoouw6jm8DOd2lGpIIHPq/mPDkQlWP8tU77gWAvwdWq6auEvfXEz6oC4JzF/RX2mcoKllt6pl+dsnxAe7CY/vEa6QZ0XCc2G/XhJ/io1KCw4jYS70nXogF0O/xeR1dY8GOTwzZZU8yVoxsxDt1hYktW3G0tZzBs3U9SGaQZxF/gMsYRwTBaW74OCwnyGABFFIV9guRWqd4GvB/RvpTumtA404MRmyAbnA8NQmsJKKpGXo3Zx+rCqz9Vh/cqx24hss/12q0CMLnPCCN8zL7HWuUyOI8eAO/qN9Nqu50vmdt/aEIVi7cBsLkZEP4Ho/8srJ4CeC6UtVS6B1iBO26PbnbQELStoHvaFow7Tkb04OVcANgSDNEBMTRl2IIlko9ZN9RqgS5a4RhfbLGvgSASTOef/O5/B6dgaMxY0Pa3wGeVv6hgq8nkt6PfmlPpPByzA2TESJejeuux7NlnWSJrdwVpdcgnkV2v6qz9/Yx/9D7M4c/xpje+47e2/3EBAwoeOFDfCFMbs1VXMedQ2WlQ2VuZrgzV8JmHg0G1khTnAA= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(346002)(376002)(396003)(39860400002)(451199021)(40470700004)(46966006)(36840700001)(26005)(31686004)(478600001)(82740400003)(86362001)(31696002)(2616005)(186003)(36860700001)(81166007)(16576012)(54906003)(70586007)(4326008)(83380400001)(356005)(336012)(110136005)(426003)(53546011)(70206006)(316002)(47076005)(5660300002)(8676002)(8936002)(44832011)(40460700003)(41300700001)(2906002)(40480700001)(82310400005)(36756003)(21314003)(3940600001)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB7409 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c6671a5a-144d-43a8-5b8a-08db7b84220e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hmVKibyuUERV3nzI8/mNG6ZDI5Cdt+rCgTV+QBrkmOQ81CVm2N85Y2ZRDnJ8zgm1cOA1KsMI/wNxpsRlcEGABSqjLO55PauO/dqQNnlgGawBf+Gtoi96mJ+wwTHm5YwnKo1Gd3Dw6/zAIosSOPFQqpU9Z/RNYvHl4S25vGuaD01XY66a5FCM8PVxqWsmqKDPtGkeU3Tn0auYuylvrKKu1hoh003Q5bKPMRmj29uu8Xbbn0GwsWjOEYVwEqoVVWmbQwncWsjiFCluwUrqtCQBcwIhn0ou0CmLoaR4PxINktJY2TowI+cSohrPooS4dUJRFpyriYJB1a/fW9TlYXAxYBlRopCuun3UDoxdpxdZe0ArCeN8s7fja63zgS3jyctiq1wtC7DMROpS3T2V5kiK/7vR3t1NfkkFMC/o+9/L5dok9tk1yTG+hhKzXwFBOB/f9Gm6dv9JCPGyuDhP7lnSeQau+Wzy04BFGK2dNO8T+AfSFMN8/5yqi6QySmfg4oa9aNPZHFdu6yYAAHtgwBQ+6P2LO1adPqNk89/Sj5OPMNNgfoG3/BTcMwuXJljOpcE2bOrLuqQya29BermPTD3+Kmd9kwJxxjP747LeS41PdxuddQxOyWmZC0ezMTzq/gxj4Ldre54hrS8PytF/AqswEgQJVPeFYCbGwSw8WbJimPPjw18Mnuk3tIAUw9Bg3sOHUMxxAlWRTow2tyahP/tw7+ivqtrBNlYdUa0odZTX/gmqCeb5fG/SFKGNJ4lRPaOoA2oT0XBxUv/IrvEPVpBNM9hpAE1t6UPyppB05UIpc0As5bc50J9BGVrJN8uY1h0nw2NQjPALYQM+7SJXWGkD9A== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(346002)(136003)(376002)(451199021)(46966006)(40470700004)(36840700001)(54906003)(16576012)(26005)(44832011)(53546011)(186003)(8936002)(36756003)(31696002)(86362001)(8676002)(2906002)(110136005)(31686004)(5660300002)(40460700003)(41300700001)(478600001)(107886003)(81166007)(40480700001)(4326008)(70586007)(82740400003)(70206006)(47076005)(2616005)(336012)(82310400005)(83380400001)(316002)(36860700001)(426003)(21314003)(3940600001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2023 05:12:55.0730 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 95618774-3ce8-4307-f8af-08db7b8428ae X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6111 Hi, On 2023/6/30 23:02, Julien Grall wrote: > Hi, > > On 30/06/2023 15:42, Ayan Kumar Halder wrote: >> Hi Julien, >> >> On 30/06/2023 12:22, Julien Grall wrote: >>> >>> >>> On 30/06/2023 11:49, Ayan Kumar Halder wrote: >>>> >>>> On 30/06/2023 05:07, Penny Zheng wrote: >>>>> Hi, >>>> Hi Penny, >>>>> >>>>> >>>>> On 2023/6/30 01:22, Ayan Kumar Halder wrote: >>>>>> >>>>>> On 26/06/2023 04:34, Penny Zheng wrote: >>>>>>> CAUTION: This message has originated from an External Source. >>>>>>> Please use proper judgment and caution when opening attachments, >>>>>>> clicking links, or responding to this email. >>>>>>> >>>>>>> >>>>>>> In MPU system, MPU memory region is always mapped PAGE_ALIGN, so >>>>>>> in order to >>>>>>> not access unexpected memory area, dtb section in xen.lds.S >>>>>>> should be made >>>>>>> page-aligned too. >>>>>>> We add . = ALIGN(PAGE_SIZE); in the head of dtb section to make >>>>>>> it happen. >>>>>>> >>>>>>> In this commit, we map early FDT with a transient MPU memory >>>>>>> region, as >>>>>>> it will be relocated into heap and unmapped at the end of boot. >>>>>>> >>>>>>> Signed-off-by: Penny Zheng >>>>>>> Signed-off-by: Wei Chen >>>>>>> --- >>>>>>> v3: >>>>>>> - map the first 2MB. Check the size and then re-map with an extra >>>>>>> 2MB if needed >>>>>>> --- >>>>>>>   xen/arch/arm/include/asm/arm64/mpu.h |  3 ++- >>>>>>>   xen/arch/arm/include/asm/page.h      |  5 +++++ >>>>>>>   xen/arch/arm/mm.c                    | 26 >>>>>>> ++++++++++++++++++++------ >>>>>>>   xen/arch/arm/mpu/mm.c                |  1 + >>>>>>>   xen/arch/arm/xen.lds.S               |  5 ++++- >>>>>>>   5 files changed, 32 insertions(+), 8 deletions(-) >>>>>>> >>>>>>> diff --git a/xen/arch/arm/include/asm/arm64/mpu.h >>>>>>> b/xen/arch/arm/include/asm/arm64/mpu.h >>>>>>> index a6b07bab02..715ea69884 100644 >>>>>>> --- a/xen/arch/arm/include/asm/arm64/mpu.h >>>>>>> +++ b/xen/arch/arm/include/asm/arm64/mpu.h >>>>>>> @@ -72,7 +72,8 @@ typedef union { >>>>>>>           unsigned long ns:1;     /* Not-Secure */ >>>>>>>           unsigned long res:1;    /* Reserved 0 by hardware */ >>>>>>>           unsigned long limit:42; /* Limit Address */ >>>>>>> -        unsigned long pad:16; >>>>>>> +        unsigned long pad:15; >>>>>>> +        unsigned long tran:1;   /* Transient region */ >>>>>>>       } reg; >>>>>>>       uint64_t bits; >>>>>>>   } prlar_t; >>>>>>> diff --git a/xen/arch/arm/include/asm/page.h >>>>>>> b/xen/arch/arm/include/asm/page.h >>>>>>> index 85ecd5e4de..a434e2205a 100644 >>>>>>> --- a/xen/arch/arm/include/asm/page.h >>>>>>> +++ b/xen/arch/arm/include/asm/page.h >>>>>>> @@ -97,19 +97,24 @@ >>>>>>>    * [3:4] Execute Never >>>>>>>    * [5:6] Access Permission >>>>>>>    * [7]   Region Present >>>>>>> + * [8]   Transient Region, e.g. MPU memory region is temproraily >>>>>>> + *                              mapped for a short time >>>>>>>    */ >>>>>>>   #define _PAGE_AI_BIT            0 >>>>>>>   #define _PAGE_XN_BIT            3 >>>>>>>   #define _PAGE_AP_BIT            5 >>>>>>>   #define _PAGE_PRESENT_BIT       7 >>>>>>> +#define _PAGE_TRANSIENT_BIT     8 >>>>>> I don't think this is related to MPU. At least when I look at the >>>>>> bit representation of PRBAR_EL1/2, >>>>> >>>>> This set of _PAGE_xxx flags aren't compliant with PRBAR_EL1/2 >>>>> register map. >>>>> It is a flag passed to function map_pages_to_xen() to indicate memory >>>>> attributes and permission. >>>> >>>> But aren't you writing these flags to PRBAR_EL1/EL2 when you call >>>> xen_mpumap_update_entry(). >>>> >>>> In the below snippet of xen_mpumap_update_entry(), IIUC, you are >>>> writing these flags. >>>> >>>>          xen_mpumap[idx].prbar.reg.ap = PAGE_AP_MASK(flags); >>>>          xen_mpumap[idx].prbar.reg.xn = PAGE_XN_MASK(flags); >>>> >>>>          write_protection_region((const pr_t*)(&xen_mpumap[idx]), idx); >>>> >>>> Please clarify here. >>>> >>>> In this case, I don't prefer mixing hardware specific bits with >>>> software only representation for these reasons :- >>>> >>>> 1. It makes it confusing and hard to differentiate the hardware >>>> specific attrbutes from software only. >>> >>> Penny's approach matches what we are doing in the MMU code. We want >>> to have a way for the caller to pass just set of flags and let the >>> callee to decide what to do with them. >>> >>> This may be flags converted for HW fields or just used by the logic. >>> >>> If you disagree with this approach, then can you propose a different >>> way that we can discuss? Thanks ayan for pointing out that RES0 is not suitable for storing software-only flags, agreed. Then, maybe we should refine the existing "struct pr_t" to store these sw bits, like: ``` typedef union { struct { uint8_t tran:1; /* Transient region */ uint8_t p2m_type:4; /* Used to store p2m types.*/ }; uint8_t bits; } pr_flags; /* MPU Protection Region */ typedef struct { prbar_t prbar; prlar_t prlar; pr_flags flags; } pr_t; ``` The drawback is that, considering the padding, "struct pr_t" expands from 16 bytes to 24 bytes. Wdyt? >> >> In MMU, I could see "struct lpae_pt_t{ .avail }" is used for reference >> count. >> >> Something like this might look better (where the hardware specific >> bits are not reused for sw logic) >> >> struct { >> >>            struct __packed { >> >>                   ... /* the existing bits as they are */ >> >>            } lpae_pt_t; >> >>            unsigned int ref_count; >> >> } p2m_entry >>  > And use "p2m_entry.ref_count" for the reference counting. > > So where would you store 'ref_count'? In the existing approach, this is > store in the PTE and that's fine because the bits 58:55 are reserved for > software use. > > This is right in the middle of the PTE. So we have no other choice other > than describing right in the middle of lpae_pt_t. > > Cheers, > From xen-devel-bounces@lists.xenproject.org Mon Jul 03 05:35:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Jul 2023 05:35:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558002.871755 (Exim 4.92) (envelope-from ) id 1qGCDv-0004MB-7k; Mon, 03 Jul 2023 05:35:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558002.871755; Mon, 03 Jul 2023 05:35:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGCDv-0004M4-5C; Mon, 03 Jul 2023 05:35:43 +0000 Received: by outflank-mailman (input) for mailman id 558002; Mon, 03 Jul 2023 05:35:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGCDu-0004Lv-7K for xen-devel@lists.xenproject.org; Mon, 03 Jul 2023 05:35:42 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 721d0877-1963-11ee-b237-6b7b168915f2; Mon, 03 Jul 2023 07:35:40 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D06B81F8B2; Mon, 3 Jul 2023 05:35:39 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B62CE134B1; Mon, 3 Jul 2023 05:35:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id viL+KiteomSxIQAAMHmgww (envelope-from ); Mon, 03 Jul 2023 05:35:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 721d0877-1963-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1688362539; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SiYx+m5n+OwCValWNWeTAOs4l6Bi7NKlP3Poqq5vL+U=; b=jlvZ4uCFeuLjkeoDOXpK1BE+ffn3MH5uGccDB+mCcw1N1OK8u1L0VyNtYoXx8xGE20oFyz mDHvLYTeYmj1R23Z74vEQfkCNDP4lazf1MGn774pn/C2KI0TQl1PEe0klqm1OKoEfIiJTE zGxkjQBXgrOWO3hH/PNpiipfFo8wQR4= Message-ID: <6296a02e-863b-879d-6993-1a828e71fac2@suse.com> Date: Mon, 3 Jul 2023 07:35:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 To: osstest service owner , xen-devel@lists.xenproject.org References: Content-Language: en-US From: Juergen Gross Subject: Re: [linux-linus test] 181682: regressions - FAIL In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------E2UM0qlIlQvXqtouwG4lKIp0" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------E2UM0qlIlQvXqtouwG4lKIp0 Content-Type: multipart/mixed; boundary="------------2z695epUxBPhEf0Mexj6tp1v"; protected-headers="v1" From: Juergen Gross To: osstest service owner , xen-devel@lists.xenproject.org Message-ID: <6296a02e-863b-879d-6993-1a828e71fac2@suse.com> Subject: Re: [linux-linus test] 181682: regressions - FAIL References: In-Reply-To: --------------2z695epUxBPhEf0Mexj6tp1v Content-Type: multipart/mixed; boundary="------------4IoVn4EUPxNb0tLXEWTsVvKt" --------------4IoVn4EUPxNb0tLXEWTsVvKt Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMDcuMjMgMDQ6MTEsIG9zc3Rlc3Qgc2VydmljZSBvd25lciB3cm90ZToNCj4gZmxp Z2h0IDE4MTY4MiBsaW51eC1saW51cyByZWFsIFtyZWFsXQ0KPiBodHRwOi8vbG9ncy50ZXN0 LWxhYi54ZW5wcm9qZWN0Lm9yZy9vc3N0ZXN0L2xvZ3MvMTgxNjgyLw0KPiANCj4gUmVncmVz c2lvbnMgOi0oDQo+IA0KPiBUZXN0cyB3aGljaCBkaWQgbm90IHN1Y2NlZWQgYW5kIGFyZSBi bG9ja2luZywNCj4gaW5jbHVkaW5nIHRlc3RzIHdoaWNoIGNvdWxkIG5vdCBiZSBydW46DQoN Ci4uLg0KDQo+ICAgdGVzdC1hbWQ2NC1hbWQ2NC14bCAgICAgICAgICAxMiBkZWJpYW4taW5z dGFsbCAgICAgICAgICAgZmFpbCBSRUdSLiB2cy4gMTgwMjc4DQoNCkVycm9ycyBkdXJpbmcg aW5zdGFsbGF0aW9uIG9mIC5kZWIgZmlsZXMuIFdvcnJ5aW5nIG1lc3NhZ2VzIGluIHRoZSBz ZXJpYWwgbG9nDQphcmU6DQoNClsgICAgMi45NzcwOTFdIEJhZCBGUFUgc3RhdGUgZGV0ZWN0 ZWQgYXQgcmVzdG9yZV9mcHJlZ3NfZnJvbV9mcHN0YXRlKzB4NTIvMHhjMCwgDQpyZWluaXRp YWxpemluZyBGUFUgcmVnaXN0ZXJzLg0KDQp0cmFwczogZHBrZy1kZWJbMTQxM10gdHJhcCBp bnZhbGlkIG9wY29kZSBpcDo3ZjVjMGEwMTY5M2Ygc3A6N2ZmZTNkYWY1ZDk4IA0KZXJyb3I6 MCBpbiBsaWJjLTIuMjguc29bN2Y1YzA5ZWUwMDAwKzE0NzAwMF0NCg0KT2xhZiBoYXMgc2Vl biBzaW1pbGFyIGZhaWx1cmVzIGxhc3Qgd2Vlaywgc28gd2UgaGF2ZSBhIHJlcHJvZHVjZXIg YXQgaGFuZC4NCg0KLi4uDQoNCj4gICBidWlsZC1hcm02NC1wdm9wcyAgICAgICAgICAgICA2 IGtlcm5lbC1idWlsZCAgICAgICAgICAgICBmYWlsIFJFR1IuIHZzLiAxODAyNzgNCg0KVGhp cyBvbmUgZmFpbGVkIHdpdGggYSBjb21waWxlciBwcm9ibGVtIChzZWdtZW50YXRpb24gZmF1 bHQpLg0KDQpJIGRpZG4ndCBsb29rIGludG8gdGhlIG90aGVyIGVycm9ycyBpbiBkZXRhaWwu DQoNCg0KSnVlcmdlbg0K --------------4IoVn4EUPxNb0tLXEWTsVvKt Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------4IoVn4EUPxNb0tLXEWTsVvKt-- --------------2z695epUxBPhEf0Mexj6tp1v-- --------------E2UM0qlIlQvXqtouwG4lKIp0 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmSiXisFAwAAAAAACgkQsN6d1ii/Ey+i lAgAiSfapSHNoGVI4zxIzypsH57ugmQacZ7/w5DAtkeQwGZMm6qqxf8VJvY6iK/L9e1uF1ZTrMdf AY23ygzclUxfXnWjB9Vpc7TRNi+4qvb+Ky8diHUthid6gmXvyfCzfJBlvc8gG+v8AkIBVArxcQwP 4Iq14YU8cYapBd5FprRJIHhHIuewseEquQP9/C3V2nm3k1IyNh2PhxjFDQfcp0KZjrI5iAT8WTJq vxoi+oPKOXQwdYLxLASKWUHksqFBUt+arQQc5H+rdxPNlpS3y35/p8K2VcEDlA2hfIMMmHCXKCUd wo9TuQuTXdzc6A1sXuks7OeSzaplCdXoMhFcTRPQzA== =1il5 -----END PGP SIGNATURE----- --------------E2UM0qlIlQvXqtouwG4lKIp0-- From xen-devel-bounces@lists.xenproject.org Mon Jul 03 06:11:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Jul 2023 06:11:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558006.871766 (Exim 4.92) (envelope-from ) id 1qGClx-0000Np-T4; Mon, 03 Jul 2023 06:10:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558006.871766; Mon, 03 Jul 2023 06:10:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGClx-0000Ni-Ps; Mon, 03 Jul 2023 06:10:53 +0000 Received: by outflank-mailman (input) for mailman id 558006; Mon, 03 Jul 2023 06:10:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGClw-0000Nc-1t for xen-devel@lists.xenproject.org; Mon, 03 Jul 2023 06:10:52 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20602.outbound.protection.outlook.com [2a01:111:f400:fe1a::602]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5ad9e684-1968-11ee-8611-37d641c3527e; Mon, 03 Jul 2023 08:10:49 +0200 (CEST) Received: from DUZPR01CA0349.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b8::14) by AM0PR08MB5428.eurprd08.prod.outlook.com (2603:10a6:208:182::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Mon, 3 Jul 2023 06:10:45 +0000 Received: from DBAEUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4b8:cafe::8f) by DUZPR01CA0349.outlook.office365.com (2603:10a6:10:4b8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.30 via Frontend Transport; Mon, 3 Jul 2023 06:10:45 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT052.mail.protection.outlook.com (100.127.142.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.17 via Frontend Transport; Mon, 3 Jul 2023 06:10:45 +0000 Received: ("Tessian outbound d6c4ee3ba1eb:v142"); Mon, 03 Jul 2023 06:10:44 +0000 Received: from de3b029c99cd.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4DAE93B2-94F7-4F47-96A2-10DFF62EC42C.1; Mon, 03 Jul 2023 06:10:38 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id de3b029c99cd.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 03 Jul 2023 06:10:38 +0000 Received: from AS4P250CA0006.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:5df::8) by PAVPR08MB9794.eurprd08.prod.outlook.com (2603:10a6:102:31e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Mon, 3 Jul 2023 06:10:33 +0000 Received: from AM7EUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:5df:cafe::46) by AS4P250CA0006.outlook.office365.com (2603:10a6:20b:5df::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.30 via Frontend Transport; Mon, 3 Jul 2023 06:10:33 +0000 Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT030.mail.protection.outlook.com (100.127.140.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6565.17 via Frontend Transport; Mon, 3 Jul 2023 06:10:33 +0000 Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 3 Jul 2023 06:10:32 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 3 Jul 2023 06:10:31 +0000 Received: from [10.169.188.49] (10.169.188.49) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 3 Jul 2023 06:10:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5ad9e684-1968-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5ddtpptgBVErJpYyc7OJBm5OKLGxklqjneMQV/9ZNmc=; b=pNBCxvFim+SSCiorsnRFvq8c5vKRR49g9u1eNO9N70uzImE+aCzqCz3OdZxESw8WU1tPmC10mfOm/cKraLuEO2z1P4/HN3nrWClszixLvOShKYixhtcLvAqh+5QOHHltJVSqYuitKouIrAqIzCO9je1EfF+lzlY02KXusIaADoU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: cda4d3550265ad68 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KTyA86J/FX6FJqcXzTN8eWEC4r0nt17sys+ZT5fM/1VuIVQr1mL045mQ3zqMkuSr5oXzer3FEFyLgYFO4mztKXF/eJwKOT42fHANy2uwWokI0lw8EaKfYBy6pWRpenE6OmwqXFRm2pQMusSCXjh9MC71tqEv2vNd4WJzmfmOpWL7xL8Y5aF5rkhaPbv6lZ2V79tvb//4BdFBE6/2KZpJvE6fGLVK/pnO1JrO8zWzvkSM94Be4RVhDdk14GfBiV8ZqM/p7PZhEoAOX7dXBFTFwxqQb1vlIN8/Ago0nx6C3joAfksIzv0ZWeF3XsBNaqAiwmjbuebKXs3IeQQ89O/Ikg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5ddtpptgBVErJpYyc7OJBm5OKLGxklqjneMQV/9ZNmc=; b=M/ukbSpRiajz2vEIrsqCgLXP1Wzj8LRkT23vnN9e5VlihRRRWThN3q6Peq0A8adsNGdBDbMjQuKC09mmllUlZ8OBQLRk8b6vZgtPKJ61n22yFcAiSDGhbi8KrNwQ2HT2fZIbwtEGsiNYVdAwK1EgoiScqdAgHdhbaR5fCYy8SpQsAYjJPkCjFTfKTC3urNeNWcvogDdnP0op17NODQUAzsrWU1clSP6TtGqZUaIMK/8qrGOlad5Kr+r4OIHyf7tccKflNUd1W4SlybDL8B02NDiqjXONVThxpCgBBmLC7FGaqcH8FvV5VBb2auFay48XrgXTjPOEMx8UcQ2EsKzFBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=amd.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5ddtpptgBVErJpYyc7OJBm5OKLGxklqjneMQV/9ZNmc=; b=pNBCxvFim+SSCiorsnRFvq8c5vKRR49g9u1eNO9N70uzImE+aCzqCz3OdZxESw8WU1tPmC10mfOm/cKraLuEO2z1P4/HN3nrWClszixLvOShKYixhtcLvAqh+5QOHHltJVSqYuitKouIrAqIzCO9je1EfF+lzlY02KXusIaADoU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C Message-ID: Date: Mon, 3 Jul 2023 14:10:27 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 33/52] xen/mpu: initialize frametable in MPU system Content-Language: en-US To: Ayan Kumar Halder , CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , "Volodymyr Babchuk" , Wei Chen References: <20230626033443.2943270-1-Penny.Zheng@arm.com> <20230626033443.2943270-34-Penny.Zheng@arm.com> From: Penny Zheng In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT030:EE_|PAVPR08MB9794:EE_|DBAEUR03FT052:EE_|AM0PR08MB5428:EE_ X-MS-Office365-Filtering-Correlation-Id: 620ba86c-7b40-4578-5170-08db7b8c3cec x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 9aSGM2pI99lv6gTqc/HpxKf7+RMe+ugoSO7vITA8I/HZxxaEycGSNwVSY2Y70q0C1HMgnde2d33gnUDjn8BKYpv5RHeQPCyK+XfSToJplXf8ah6zzHwg5KEHAwxOArahlzoTZ/i/cJ6H5i1Tfh3OZkFZzhYaAIywTzsB/4jZGnCWhMUDf9PMciRwMqnWa1e0PmCmw9Q4Fdxi8UdWpJ99dJ5v49aoylES5voFowdgkvKkkpp58fLWCBnXEoJ8h2mDNpUYyxmcfXLG6/HmAhn8R2uer8a119qfdH2S4ffChoe9/FdBXKc7PzjxOmWigL2ZBDajNJ7ZcVMPj67j+YJJWYTQ2PJ5h4rMyZmhUO1SSQc6pOUX2+syAmO4itztnJZnXddUqnU5fjGDatcgXDEapN1tWwFWEZcfYW7NRFdYy/0qyfsp2XQN6Su+sEp/1FXjzTnmgT7jCdbTx+nGbPjmiqwRSmqQ9XdcxD3e2UarHu/TKqH0dWUaCc1fWUZhTvlREbQulYGe+tFhe4wQBzwSEQzmDmyaKlqA7TwFc8AWnfppQXi6zcyyFn9g8dUEh7IQltgMVuvFDQfqxNkzZZxPwiQCq7UFe3bCnrwqZovsZknEBMV0Xr2rvuIX8eeN0UUYq0lsKUuD0AJ1Kz8iVi3I8md7xP3CRtyV1EApG0R7CvLesrzVaKwLXgIknh9wWsrgfrY/ngHMjhyL1niLThnJc8ESsqVZasos1p/rIII/rCk1kRI9k8fib0LgoG1rZ4N/DLbm7N9PpxBnMzfged8XWWf59b+gnVPIXsVeDbreY4MeInSGtU7YA/7PfaHbWAX/3sbNdWxU4L8TRmgNa5B4dQ== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(346002)(376002)(396003)(39860400002)(451199021)(40470700004)(46966006)(36840700001)(26005)(31686004)(478600001)(82740400003)(86362001)(31696002)(2616005)(186003)(36860700001)(81166007)(16576012)(54906003)(70586007)(4326008)(83380400001)(356005)(336012)(110136005)(426003)(53546011)(70206006)(316002)(47076005)(5660300002)(8676002)(8936002)(44832011)(40460700003)(41300700001)(2906002)(40480700001)(82310400005)(36756003)(3940600001)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9794 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5d8a6176-5f70-4d7f-8025-08db7b8c35c9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: t3U7Btl2goS0gYCbWpR7Qt3+g6Vu6MyVFIXpZdU1bPEvH/wxtUHM1CigWH0I1XRrp3siunfSnkRbtW9QY0HcKlr2bhRDjRYY/ofjVogH7IKdEtnvB5eQUnucSq1yU5+bS5yOfP4qZi7yRAkME012wi5sjpzefQp5aCoqjvhtaVP6QksPWRP32/T+BpIkDA+B2nZQmfh3yRulPZSEyBkjOauCLL/p7EqbtWDcWpy2iEbEgzJXXx6AAbpKwITavifDtNiXcLQ5j/szALfLJBRKjL7+Gyrulss+keXpFKdC44zNp4za22hQA/Xq1Ss3qCt/eTJXzWTxHwf66kKTIRhL9vZ7G5e0T9P0ybLUYSg0IzAOi8Rr3TbytdsbsYJvWcpFzwLhJ7bJOvklixSWcbY1q1SsTxfMZWWkcFjRMeNakMTUOpqOabX51HxIveCMn956miOYWtJtTCYDdZVSGGVFMBKXbm8p6iIUkUfdgixj+MWazc99+iZBzaVcI06+fNqWC1Pv3jSkFlSUQYAfSdtSloV7N0mOS1Z7TNLavnLxlnHXx0lBICtkvCgQR5jNbz+X6gDHyJMznvMaVpwD1CgZUQjizb+63sWAPBaw1avsVSyFVcBguZp+Kdj9ctvnVAYvNRDSNSY0DN433tOjeSL+NVL9E70WWqA+YQFa58tTATOS9u8b6hD1ijwJcV2ZfSxA/kjsMUmYVlVR3G14CcyC7rMsSzsEZSozvKN70WSVDRWzTGip+S1Bw3lqEm9f16HAMTBjCn/Kyy6UvaEwM3Cs3vA4S/7nJfH2EjSIuDcPUmgvOCYMZ1WCZhNheMqKO4Ss X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(376002)(39860400002)(396003)(451199021)(40470700004)(46966006)(36840700001)(40460700003)(2906002)(41300700001)(5660300002)(44832011)(8936002)(8676002)(82310400005)(36756003)(40480700001)(86362001)(31696002)(478600001)(83380400001)(47076005)(426003)(336012)(36860700001)(186003)(26005)(53546011)(31686004)(2616005)(54906003)(110136005)(16576012)(82740400003)(4326008)(70206006)(70586007)(81166007)(316002)(3940600001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2023 06:10:45.0659 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 620ba86c-7b40-4578-5170-08db7b8c3cec X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5428 Hi Ayan On 2023/6/30 23:19, Ayan Kumar Halder wrote: > Hi Penny, > > On 26/06/2023 04:34, Penny Zheng wrote: >> CAUTION: This message has originated from an External Source. Please >> use proper judgment and caution when opening attachments, clicking >> links, or responding to this email. >> >> >> Xen is using page as the smallest granularity for memory managment. >> And we want to follow the same concept in MPU system. >> That is, structure page_info and the frametable which is used for storing >> and managing the smallest memory managment unit is also required in >> MPU system. >> >> In MPU system, since we can not use a fixed VA >> address(FRAMETABLE_VIRT_START) >> to map frametable like MMU system does and everything is 1:1 mapping, we >> instead define a variable "struct page_info *frame_table" as frametable >> pointer, and ask boot allocator to allocate appropriate memory for >> frametable. >> >> As frametable is successfully initialized, the convertion between >> machine frame >> number/machine address/"virtual address" and page-info structure is >> ready too, like mfn_to_page/maddr_to_page/virt_to_page, etc >> >> Signed-off-by: Penny Zheng >> Signed-off-by: Wei Chen >> --- >> v3: >> - add ASSERT() to confirm the MFN you pass is covered by the frametable. >> --- >>   xen/arch/arm/include/asm/mm.h     | 14 ++++++++++++++ >>   xen/arch/arm/include/asm/mpu/mm.h |  3 +++ >>   xen/arch/arm/mpu/mm.c             | 27 +++++++++++++++++++++++++++ >>   3 files changed, 44 insertions(+) >> >> diff --git a/xen/arch/arm/include/asm/mm.h >> b/xen/arch/arm/include/asm/mm.h >> index daa6329505..66d98b9a29 100644 >> --- a/xen/arch/arm/include/asm/mm.h >> +++ b/xen/arch/arm/include/asm/mm.h >> @@ -341,6 +341,19 @@ static inline uint64_t gvirt_to_maddr(vaddr_t va, >> paddr_t *pa, >>   #define virt_to_mfn(va)     __virt_to_mfn(va) >>   #define mfn_to_virt(mfn)    __mfn_to_virt(mfn) >> >> +#ifdef CONFIG_HAS_MPU >> +/* Convert between virtual address to page-info structure. */ >> +static inline struct page_info *virt_to_page(const void *v) >> +{ >> +    unsigned long pdx; >> + >> +    pdx = paddr_to_pdx(virt_to_maddr(v)); >> +    ASSERT(pdx >= frametable_base_pdx); >> +    ASSERT(pdx < frametable_pdx_end); >> + >> +    return frame_table + pdx - frametable_base_pdx; >> +} > This should go in xen/arch/arm/include/asm/mpu/mm.h. Then you don't need > ifdef >> +#else >>   /* Convert between Xen-heap virtual addresses and page-info >> structures. */ >>   static inline struct page_info *virt_to_page(const void *v) >>   { >> @@ -354,6 +367,7 @@ static inline struct page_info *virt_to_page(const >> void *v) >>       pdx += mfn_to_pdx(directmap_mfn_start); >>       return frame_table + pdx - frametable_base_pdx; >>   } > Consequently, this should be in xen/arch/arm/include/asm/mmu/mm.h The reason why I don't put virt_to_page()/page_to_virt() in specific header is that we are using some helpers, which are defined just a few lines before, like mfn_to_virt(), etc. If you are moving mfn_to_virt() to specific header too, that will result in a lot dulplication. >> +#endif >> >>   static inline void *page_to_virt(const struct page_info *pg) >>   { >> diff --git a/xen/arch/arm/include/asm/mpu/mm.h >> b/xen/arch/arm/include/asm/mpu/mm.h >> index e26bd4f975..98f6df65b8 100644 >> --- a/xen/arch/arm/include/asm/mpu/mm.h >> +++ b/xen/arch/arm/include/asm/mpu/mm.h >> @@ -2,6 +2,9 @@ >>   #ifndef __ARCH_ARM_MM_MPU__ >>   #define __ARCH_ARM_MM_MPU__ >> >> +extern struct page_info *frame_table; > If you define frame_table in xen/arch/arm/include/asm/mm.h , then you > don't need the above declaration. It is a variable only in MPU. In MMU, it is a fixed value. "#define frame_table ((struct page_info *)FRAMETABLE_VIRT_START)" >> +extern unsigned long frametable_pdx_end; > Also you don't need extern as this is only used by xen/arch/arm/mpu/mm.c. sure. >> + >>   extern int xen_mpumap_update(paddr_t base, paddr_t limit, unsigned >> int flags); > > You don't need extern here as it should be used only in > xen/arch/arm/mpu/mm.c > > Currently, I see the following in xen/arch/arm/mm.c, > > int map_pages_to_xen(unsigned long virt, >                      mfn_t mfn, >                      unsigned long nr_mfns, >                      unsigned int flags) > { > #ifndef CONFIG_HAS_MPU >     return xen_pt_update(virt, mfn, nr_mfns, flags); > #else >     return xen_mpumap_update(mfn_to_maddr(mfn), >                              mfn_to_maddr(mfn_add(mfn, nr_mfns)), flags); > #endif > } > > int destroy_xen_mappings(unsigned long s, unsigned long e) > { >     ASSERT(IS_ALIGNED(s, PAGE_SIZE)); >     ASSERT(IS_ALIGNED(e, PAGE_SIZE)); >     ASSERT(s <= e); > #ifndef CONFIG_HAS_MPU >     return xen_pt_update(s, INVALID_MFN, (e - s) >> PAGE_SHIFT, 0); > #else >     return xen_mpumap_update(virt_to_maddr((void *)s), >                              virt_to_maddr((void *)e), 0); > #endif > } > > int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int > flags) > { >     ASSERT(IS_ALIGNED(s, PAGE_SIZE)); >     ASSERT(IS_ALIGNED(e, PAGE_SIZE)); >     ASSERT(s <= e); > #ifndef CONFIG_HAS_MPU >     return xen_pt_update(s, INVALID_MFN, (e - s) >> PAGE_SHIFT, flags); > #else >     return xen_mpumap_update(virt_to_maddr((void *)s), >                              virt_to_maddr((void *)e), flags); > #endif > } > > It would be better to have 2 implementations for map_pages_to_xen(), > destroy_xen_mappings() and modify_xen_mappings() in > xen/arch/arm/mpu/mm.c and xen/arch/arm/mmu/mm.c. > I prefer them staying in the common file, using #ifdef to go to the different path. Since if not and when anyone wants to update map_pages_to_xen(), destroy_xen_mappings() and modify_xen_mappings() in the future, it is possible for them to leave changes in only one file. >>   extern void setup_staticheap_mappings(void); >> >> diff --git a/xen/arch/arm/mpu/mm.c b/xen/arch/arm/mpu/mm.c >> index 7bd5609102..0a65b58dc4 100644 >> --- a/xen/arch/arm/mpu/mm.c >> +++ b/xen/arch/arm/mpu/mm.c >> @@ -27,6 +27,10 @@ >>   #include >>   #include >> >> +/* Override macros from asm/mm.h to make them work with mfn_t */ >> +#undef mfn_to_virt > Why do we have to do this ? >> +#define mfn_to_virt(mfn) __mfn_to_virt(mfn_x(mfn)) >> + >>   #ifdef NDEBUG >>   static inline void __attribute__ ((__format__ (__printf__, 1, 2))) >>   region_printk(const char *fmt, ...) {} >> @@ -58,6 +62,9 @@ static DEFINE_SPINLOCK(xen_mpumap_lock); >> >>   static DEFINE_SPINLOCK(xen_mpumap_alloc_lock); >> >> +struct page_info *frame_table; >> +unsigned long frametable_pdx_end __read_mostly; >> + >>   /* Write a MPU protection region */ >>   #define WRITE_PROTECTION_REGION(pr, prbar_el2, prlar_el2) ({    \ >>       const pr_t *_pr = pr;                                       \ >> @@ -513,6 +520,26 @@ void __init setup_staticheap_mappings(void) >>       } >>   } >> >> +/* Map a frame table to cover physical addresses ps through pe */ >> +void __init setup_frametable_mappings(paddr_t ps, paddr_t pe) >> +{ >> +    mfn_t base_mfn; >> +    unsigned long nr_pdxs = mfn_to_pdx(mfn_add(maddr_to_mfn(pe), -1)) - >> +                            mfn_to_pdx(maddr_to_mfn(ps)) + 1; >> +    unsigned long frametable_size = nr_pdxs * sizeof(struct page_info); >> + >> +    frametable_base_pdx = paddr_to_pdx(ps); >> +    frametable_size = ROUNDUP(frametable_size, PAGE_SIZE); >> +    frametable_pdx_end = frametable_base_pdx + nr_pdxs; >> + >> +    base_mfn = alloc_boot_pages(frametable_size >> PAGE_SHIFT, 1); >> +    frame_table = (struct page_info *)mfn_to_virt(base_mfn); >> + >> +    memset(&frame_table[0], 0, nr_pdxs * sizeof(struct page_info)); >> +    memset(&frame_table[nr_pdxs], -1, >> +           frametable_size - (nr_pdxs * sizeof(struct page_info))); >> +} >> + >>   /* >>    * Local variables: >>    * mode: C >> -- >> 2.25.1 > - Ayan From xen-devel-bounces@lists.xenproject.org Mon Jul 03 06:51:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Jul 2023 06:51:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558013.871776 (Exim 4.92) (envelope-from ) id 1qGDPM-0004oO-Tq; Mon, 03 Jul 2023 06:51:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558013.871776; Mon, 03 Jul 2023 06:51:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGDPM-0004oH-Qu; Mon, 03 Jul 2023 06:51:36 +0000 Received: by outflank-mailman (input) for mailman id 558013; Mon, 03 Jul 2023 06:51:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGDPK-0004o4-LY; Mon, 03 Jul 2023 06:51:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGDPK-0006jn-EZ; Mon, 03 Jul 2023 06:51:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGDPJ-0000I7-U9; Mon, 03 Jul 2023 06:51:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qGDPJ-0006hm-Tl; Mon, 03 Jul 2023 06:51:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=uXgqzOWOUXav1qQOQlyGqXC/+8GT0k+4BTlEKadg8MQ=; b=2ebaBhn6+FoaDOoHlk5+cNlFdX 5Dd+vUH/fKQTTKiRnOGj0t6Mkju8IPPr9Vly8nXHIu44y89eGpIHXzp6XuD8gEIXnRwSPoZCzoSIk 5mOhha6IBM9vsXCXX0jZGuhRRieVo9Rwv/ENLPOVteHGTmlwZQQut7kKeYlTE0d641zQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 181685: all pass - PUSHED X-Osstest-Versions-This: ovmf=f2188fe5d1553ad1896e27b2514d2f8d0308da8a X-Osstest-Versions-That: ovmf=ad7d3ace1ad4d7350d1e1304fab86dffd0f3fd11 From: osstest service owner Date: Mon, 03 Jul 2023 06:51:33 +0000 flight 181685 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/181685/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf f2188fe5d1553ad1896e27b2514d2f8d0308da8a baseline version: ovmf ad7d3ace1ad4d7350d1e1304fab86dffd0f3fd11 Last test of basis 181680 2023-07-02 10:43:52 Z 0 days Testing same since 181685 2023-07-03 03:12:31 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar Jiewen Yao jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git ad7d3ace1a..f2188fe5d1 f2188fe5d1553ad1896e27b2514d2f8d0308da8a -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon Jul 03 07:09:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Jul 2023 07:09:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558019.871785 (Exim 4.92) (envelope-from ) id 1qGDgJ-0006Rc-2z; Mon, 03 Jul 2023 07:09:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558019.871785; Mon, 03 Jul 2023 07:09:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGDgJ-0006RV-0J; Mon, 03 Jul 2023 07:09:07 +0000 Received: by outflank-mailman (input) for mailman id 558019; Mon, 03 Jul 2023 07:09:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGDgH-0006RP-1d for xen-devel@lists.xenproject.org; Mon, 03 Jul 2023 07:09:05 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0603.outbound.protection.outlook.com [2a01:111:f400:fe0c::603]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7d085809-1970-11ee-b237-6b7b168915f2; Mon, 03 Jul 2023 09:09:02 +0200 (CEST) Received: from DU2PR04CA0003.eurprd04.prod.outlook.com (2603:10a6:10:3b::8) by GVXPR08MB7749.eurprd08.prod.outlook.com (2603:10a6:150:69::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Mon, 3 Jul 2023 07:08:56 +0000 Received: from DBAEUR03FT053.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:3b:cafe::59) by DU2PR04CA0003.outlook.office365.com (2603:10a6:10:3b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.30 via Frontend Transport; Mon, 3 Jul 2023 07:08:56 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT053.mail.protection.outlook.com (100.127.142.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.17 via Frontend Transport; Mon, 3 Jul 2023 07:08:55 +0000 Received: ("Tessian outbound e2424c13b707:v142"); Mon, 03 Jul 2023 07:08:55 +0000 Received: from 826c2dc06566.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 87614CE8-B39B-41D8-81C4-B5F4773FCF38.1; Mon, 03 Jul 2023 07:08:49 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 826c2dc06566.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 03 Jul 2023 07:08:49 +0000 Received: from AM6P191CA0041.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:7f::18) by AM9PR08MB6131.eurprd08.prod.outlook.com (2603:10a6:20b:2de::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Mon, 3 Jul 2023 07:08:47 +0000 Received: from AM7EUR03FT041.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:7f:cafe::a3) by AM6P191CA0041.outlook.office365.com (2603:10a6:209:7f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.30 via Frontend Transport; Mon, 3 Jul 2023 07:08:47 +0000 Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT041.mail.protection.outlook.com (100.127.140.233) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6565.17 via Frontend Transport; Mon, 3 Jul 2023 07:08:47 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 3 Jul 2023 07:08:46 +0000 Received: from [10.169.172.87] (10.169.172.87) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 3 Jul 2023 07:08:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d085809-1970-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Uj/cDl03UCXZVJBoV0kYatgjVvUdCe940CYqzl1ONTc=; b=ojEddXJiyXrQgXZRZE6u40Re29YC4HySOslswUEK+lquKVC5dHVyF5Kh/ljEE4eKGsos0smRZk9AMNWLUdztcdB7CaahRw3yXo1KCEbpKbROngKciz9Wk7WZb2UJ5RCPTZ8u1RXAZEP4vS8p8JqqViA4c3QngWkwPupPHP6PGcE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 682245e51d43774b X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SfUzYA30LaFQqnxlyohNaWI11It6WRwUxWU88ksfqhX2wNdXLVrMzFqa9abCzC52WeeGPhzWdJ/H/wMqeDcdKuffRjKeGsWucyrdKFFCnmCNy6556tigc8/P647u+7mtGOSSexzipj9pfGtSeE23E3jppkKCGi1NEWI7LiP0L65cgyXsHtHqErIan3XST006bjEjCnJ++sTn+vkGYKgRW2CV1U8X6Jn6pdKyFX6jf8LN3528SVeTkAb5/6Q3tZZ3XPADcf5MHyk425ke7GfvlcOA7WLxYsz12qBFcQZlGT9cbgaVa/10a7vX+6nm/EAzHxW1sGDPCkoeW8xB8536lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Uj/cDl03UCXZVJBoV0kYatgjVvUdCe940CYqzl1ONTc=; b=BJskarfGdW2RKr8VyGTQh1q/BpvRq44vhD3LL+kjOTwR1U2DAfceLeJJUD60fsqQxjvN/NZkA3eqUIovfZXjNBIuNJ1t41LIMyFS3yLBjFoEIjzspL5nh7O4B1GL4E4bUyZ5iAelobTbYs25JCip6EsxRo6EN17L9YKf2PkyJ5rCPdkPgutAXUE3triiUGoUsl9uMls1dBEt9B3T+tBAaJibHnYctQ8gV89RnnTPrB9CuKrTz1x99rKC5Yswm0hA7TUBfoKH4G4ix4XCoxW+prwtx/FtwWU03F4CrKlsCu5KUuzYVMN4HNTEBhvNJY8bo9Uzy+dGkGvMonHB8dhf2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=amd.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Uj/cDl03UCXZVJBoV0kYatgjVvUdCe940CYqzl1ONTc=; b=ojEddXJiyXrQgXZRZE6u40Re29YC4HySOslswUEK+lquKVC5dHVyF5Kh/ljEE4eKGsos0smRZk9AMNWLUdztcdB7CaahRw3yXo1KCEbpKbROngKciz9Wk7WZb2UJ5RCPTZ8u1RXAZEP4vS8p8JqqViA4c3QngWkwPupPHP6PGcE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C Message-ID: <70007941-cb74-1fc8-61fd-326b66cde84b@arm.com> Date: Mon, 3 Jul 2023 15:08:41 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 34/52] xen/mpu: destroy an existing entry in Xen MPU memory mapping table Content-Language: en-US To: Ayan Kumar Halder , CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , "Volodymyr Babchuk" , Wei Chen References: <20230626033443.2943270-1-Penny.Zheng@arm.com> <20230626033443.2943270-35-Penny.Zheng@arm.com> <87564d07-391b-7dfa-e28f-e13d73e67811@amd.com> From: Penny Zheng In-Reply-To: <87564d07-391b-7dfa-e28f-e13d73e67811@amd.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT041:EE_|AM9PR08MB6131:EE_|DBAEUR03FT053:EE_|GVXPR08MB7749:EE_ X-MS-Office365-Filtering-Correlation-Id: 5a10ac97-75ee-43a1-6fbf-08db7b945da9 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: MANqSPb7NxUsVDSAXWrF7uu+zh2QE6aCOjjMUPegJpw66j0LAudXMReD7CENYtwD5F+j4B+mvS2v8V9/pUplnQDhqpBBPcaGW6zB0QguxWTmAFUSsGn6dRNpmNb6MS8Zmdk+2ouGmKEjs4u0Ipbt9CRqLEtH5TplrOM7J5W6Nq23GY65hkLmy9Y2qO/aZul6EStuXkxjW3FGdLcut7CoOWN8MzSSMK5SsJpm6vAKiZPU2TWtSPLv8bCJRlgBWMndfEDHJ7gtMPu0cj5Dh/dBXZySWQKlIdjsnKi5ihUJnMEAvYMR3/blD954BmKryNZex3vo+92cm00EhMTeRxxWhLIZUEAOL5BZS6V5mNQ0w671aDKoti5G+9HfG0BwIqG/8bsafhWbn6i0r5EINKyVr9g/C9VGshB/O7k0B7/lTXjdf2spbJ79yKY8/7nbGF0tw2EUFe+7dsOy8TjYvbrxcUGZPPwKkHIpaSNd8zkgaIllxrPHp21mp35B0laR2K8Du9b/LfVLq0IYo+btThdJ0vPKPT0xB9zGl96mf/AdG9Ocu0SjU2OaPgB2FgAFpIQicSfAz0JJ9wZnzsXXG9914pImUUOV0MB62zy5Li0aZ5W1Ep0uaSDTvngRHvwH/sfmAKN25/M/IVLF+q9akxCaRXMfpVmKZN5mQU6XDLXr4syjXhnV7TLQyqQQ03OTBjLOnwLliKC83jr1oOpBK9ilOefi9AjJC33TIMau+KRjVAAosDNj/lKiC6uM1zOLN4LYT7XwwtIjYfcwUkZfA6hBSZ4v3DruhrWG/XhqxJXPeAcpG0SsG3OxB15tPIWvDJ77bDT8opRs4azFctJh3k4eHg== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(39860400002)(396003)(376002)(136003)(451199021)(36840700001)(46966006)(40470700004)(26005)(31686004)(478600001)(82740400003)(31696002)(86362001)(2616005)(186003)(36860700001)(16576012)(54906003)(70586007)(4326008)(81166007)(83380400001)(356005)(336012)(110136005)(426003)(53546011)(316002)(70206006)(47076005)(5660300002)(8936002)(8676002)(44832011)(40460700003)(41300700001)(2906002)(40480700001)(82310400005)(36756003)(3940600001)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6131 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1f1e4ff8-5a92-42c0-562c-08db7b9458a6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HSQbROiKa/SSfec908gUAO38KKdrZiPpUhHYvLm1AnKwgRZbf02/piRKwyG50iBgTBSOh/OekmIDkVSFIG2405BeOhd0INHWglNbBzRF5rWDMSUJ3kodFJvNpp0Iy9I96QyrN8/isznXxQyujzoK/tvSkGP5jyfmOsIn7Uke44E7IjeosEAp8d7oD2Ydyk9A0jyP351LFKCj2y0ucXn6esZLVmE0RrMTpJpQ/0XVq+4SEgN7t2vHZq5BK4HVRqiVJIU1JSkCLgcCPuNJQMa6CzUf28WuKzTY5bEL98NrFalxHeQG+cchjesRuDkdOFGhJ1QqSU2uIawROmzV/+bN2AlQ5mbb47sx2AFml9QRmUfBuwT854fHmR72TvEhLA8dW4lbaC2wbFM4tepHxzqkKNYdJiuOZCH42Yhk32ZlLWcQHlqYs7u/zRMwRoE61a1aQuW7/61AEHcjdr0cUlcIUL5/DcHY3B2b4onIyDCkYDK6H6+e1BB+Nlz3iD1A/yWnPBCvIgO5Uz2A/3uhEd2JypDLROjA1W7onTiOtPAR0npySwVUIM+G7dnLiKy0AmP57+LXWS3aaVZ+yGo/upzR0OFyteMrQ2BIIF9w7/7J0tddJaWikvn7UH3fbCh3LQ2+4/7I37dQwEiB0ceXgyScP7nVrjdoefSgawg3WbQplPGheyJhLHkoChbcYJcvoESfOZ0QcBbBEKwpsocl5BIf2I3f/tULF600UK/GgMltjsF5702NaAeMMHzRXCgUWAiDg2c5VprUpqsTpb94zyt7NjCTD6sq/l+KRfs1nGCpoksJO4FrjJubXz4RedSFp4wV X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(346002)(136003)(39860400002)(451199021)(36840700001)(46966006)(40470700004)(2906002)(82310400005)(8936002)(54906003)(16576012)(110136005)(40480700001)(8676002)(36756003)(41300700001)(40460700003)(336012)(426003)(44832011)(36860700001)(5660300002)(478600001)(31696002)(70206006)(70586007)(186003)(86362001)(53546011)(26005)(4326008)(316002)(31686004)(47076005)(81166007)(2616005)(83380400001)(82740400003)(3940600001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2023 07:08:55.9662 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5a10ac97-75ee-43a1-6fbf-08db7b945da9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB7749 Hi Ayan On 2023/7/1 00:17, Ayan Kumar Halder wrote: > > On 26/06/2023 04:34, Penny Zheng wrote: >> CAUTION: This message has originated from an External Source. Please >> use proper judgment and caution when opening attachments, clicking >> links, or responding to this email. >> >> >> This commit expands xen_mpumap_update/xen_mpumap_update_entry to include >> destroying an existing entry. >> >> We define a new helper "control_xen_mpumap_region_from_index" to >> enable/disable >> the MPU region based on index. If region is within [0, 31], we could >> quickly >> disable the MPU region through PRENR_EL2 which provides direct access >> to the >> PRLAR_EL2.EN bits of EL2 MPU regions. >> >> Rignt now, we only support destroying a *WHOLE* MPU memory region, >> part-region removing is not supported, as in worst case, it will >> leave two fragments behind. >> >> Signed-off-by: Penny Zheng >> Signed-off-by: Wei Chen >> --- >> v3: >> - make pr_get_base()/pr_get_limit() static inline >> - need an isb to ensure register write visible before zeroing the entry >> --- >>   xen/arch/arm/include/asm/arm64/mpu.h     |  2 + >>   xen/arch/arm/include/asm/arm64/sysregs.h |  3 + >>   xen/arch/arm/mm.c                        |  5 ++ >>   xen/arch/arm/mpu/mm.c                    | 74 ++++++++++++++++++++++++ >>   4 files changed, 84 insertions(+) >> >> diff --git a/xen/arch/arm/include/asm/arm64/mpu.h >> b/xen/arch/arm/include/asm/arm64/mpu.h >> index 715ea69884..aee7947223 100644 >> --- a/xen/arch/arm/include/asm/arm64/mpu.h >> +++ b/xen/arch/arm/include/asm/arm64/mpu.h >> @@ -25,6 +25,8 @@ >>   #define REGION_UART_SEL            0x07 >>   #define MPUIR_REGION_MASK          ((_AC(1, UL) << 8) - 1) >> >> +#define MPU_PRENR_BITS             32 > > This is common to R52 and R82. > > Thus, you can put it in the common file (may be > xen/arch/arm/include/asm/mpu/mm.h) > Will do. >> + >>   /* Access permission attributes. */ >>   /* Read/Write at EL2, No Access at EL1/EL0. */ >>   #define AP_RW_EL2 0x0 >> diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h >> b/xen/arch/arm/include/asm/arm64/sysregs.h >> index c8a679afdd..96c025053b 100644 >> --- a/xen/arch/arm/include/asm/arm64/sysregs.h >> +++ b/xen/arch/arm/include/asm/arm64/sysregs.h >> @@ -509,6 +509,9 @@ >>   /* MPU Type registers encode */ >>   #define MPUIR_EL2   S3_4_C0_C0_4 >> >> +/* MPU Protection Region Enable Register encode */ >> +#define PRENR_EL2   S3_4_C6_C1_1 >> + >>   #endif >> >>   /* Access to system registers */ >> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c >> index 8625066256..247d17cfa1 100644 >> --- a/xen/arch/arm/mm.c >> +++ b/xen/arch/arm/mm.c >> @@ -164,7 +164,12 @@ int destroy_xen_mappings(unsigned long s, >> unsigned long e) >>       ASSERT(IS_ALIGNED(s, PAGE_SIZE)); >>       ASSERT(IS_ALIGNED(e, PAGE_SIZE)); >>       ASSERT(s <= e); >> +#ifndef CONFIG_HAS_MPU >>       return xen_pt_update(s, INVALID_MFN, (e - s) >> PAGE_SHIFT, 0); >> +#else >> +    return xen_mpumap_update(virt_to_maddr((void *)s), >> +                             virt_to_maddr((void *)e), 0); >> +#endif >>   } > > Refer my comment in previous patch. > > You can have two implementations of this function 1) > xen/arch/arm/mmu/mm.c 2) xen/arch/arm/mpu/mm.h > Refer my comment in previous patch. I prefer #ifdef in destroy_xen_mappings() >> >>   int modify_xen_mappings(unsigned long s, unsigned long e, unsigned >> int flags) >> diff --git a/xen/arch/arm/mpu/mm.c b/xen/arch/arm/mpu/mm.c >> index 0a65b58dc4..a40055ae5e 100644 >> --- a/xen/arch/arm/mpu/mm.c >> +++ b/xen/arch/arm/mpu/mm.c >> @@ -425,6 +425,59 @@ static int mpumap_contain_region(pr_t *table, >> uint8_t nr_regions, >>       return MPUMAP_REGION_FAILED; >>   } >> >> +/* Disable or enable EL2 MPU memory region at index #index */ >> +static void control_mpu_region_from_index(uint8_t index, bool enable) >> +{ >> +    pr_t region; >> + >> +    read_protection_region(®ion, index); >> +    if ( !region_is_valid(®ion) ^ enable ) >> +    { >> +        printk(XENLOG_WARNING >> +               "mpu: MPU memory region[%u] is already %s\n", index, >> +               enable ? "enabled" : "disabled"); >> +        return; >> +    } >> + >> +    /* >> +     * ARM64v8R provides PRENR_EL2 to have direct access to the >> +     * PRLAR_EL2.EN bits of EL2 MPU regions from 0 to 31. >> +     */ >> +    if ( index < MPU_PRENR_BITS ) >> +    { >> +        uint64_t orig, after; >> + >> +        orig = READ_SYSREG(PRENR_EL2); >> +        if ( enable ) >> +            /* Set respective bit */ >> +            after = orig | (1UL << index); >> +        else >> +            /* Clear respective bit */ >> +            after = orig & (~(1UL << index)); >> +        WRITE_SYSREG(after, PRENR_EL2); >> +    } >> +    else >> +    { >> +        region.prlar.reg.en = enable ? 1 : 0; >> +        write_protection_region((const pr_t*)®ion, index); >> +    } >> +    /* Ensure the write before zeroing the entry */ > dsb(); /* to ensure write completes */ >> +    isb(); >> + >> +    /* Update according bitfield in xen_mpumap_mask */ >> +    spin_lock(&xen_mpumap_alloc_lock); >> + >> +    if ( enable ) >> +        set_bit(index, xen_mpumap_mask); >> +    else >> +    { >> +        clear_bit(index, xen_mpumap_mask); >> +        memset(&xen_mpumap[index], 0, sizeof(pr_t)); >> +    } >> + >> +    spin_unlock(&xen_mpumap_alloc_lock); >> +} >> + >>   /* >>    * Update an entry in Xen MPU memory region mapping >> table(xen_mpumap) at >>    * the index @idx. >> @@ -461,6 +514,27 @@ static int xen_mpumap_update_entry(paddr_t base, >> paddr_t limit, >> >>           write_protection_region((const pr_t*)(&xen_mpumap[idx]), idx); >>       } >> +    else >> +    { >> +        /* >> +         * Currently, we only support destroying a *WHOLE* MPU memory >> region, >> +         * part-region removing is not supported, as in worst case, >> it will >> +         * leave two fragments behind. >> +         * part-region removing will be introduced only when actual >> usage >> +         * comes. >> +         */ >> +        if ( rc == MPUMAP_REGION_INCLUSIVE ) >> +        { >> +            region_printk("mpu: part-region removing is not >> supported\n"); >> +            return -EINVAL; >> +        } >> + >> +        /* We are removing the region */ >> +        if ( rc != MPUMAP_REGION_FOUND ) >> +            return -EINVAL; >> + >> +        control_mpu_region_from_index(idx, false); >> +    } >> >>       return 0; >>   } >> -- >> 2.25.1 >> >> > - Ayan From xen-devel-bounces@lists.xenproject.org Mon Jul 03 08:16:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Jul 2023 08:16:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558031.871795 (Exim 4.92) (envelope-from ) id 1qGEjA-0005rB-B2; Mon, 03 Jul 2023 08:16:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558031.871795; Mon, 03 Jul 2023 08:16:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGEjA-0005r4-8M; Mon, 03 Jul 2023 08:16:08 +0000 Received: by outflank-mailman (input) for mailman id 558031; Mon, 03 Jul 2023 08:16:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGEj8-0005qw-TK for xen-devel@lists.xenproject.org; Mon, 03 Jul 2023 08:16:07 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20625.outbound.protection.outlook.com [2a01:111:f400:7e1a::625]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id da408494-1979-11ee-b237-6b7b168915f2; Mon, 03 Jul 2023 10:16:04 +0200 (CEST) Received: from AS9PR05CA0245.eurprd05.prod.outlook.com (2603:10a6:20b:493::22) by PAVPR08MB8941.eurprd08.prod.outlook.com (2603:10a6:102:328::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Mon, 3 Jul 2023 08:16:00 +0000 Received: from AM7EUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:493:cafe::b1) by AS9PR05CA0245.outlook.office365.com (2603:10a6:20b:493::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.30 via Frontend Transport; Mon, 3 Jul 2023 08:15:59 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT022.mail.protection.outlook.com (100.127.140.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.17 via Frontend Transport; Mon, 3 Jul 2023 08:15:59 +0000 Received: ("Tessian outbound c08fa2e31830:v142"); Mon, 03 Jul 2023 08:15:58 +0000 Received: from 7315607ad8e1.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8863286A-F5D9-49AE-8CDD-1C1AF73EC2BC.1; Mon, 03 Jul 2023 08:15:52 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7315607ad8e1.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 03 Jul 2023 08:15:52 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by PA4PR08MB5981.eurprd08.prod.outlook.com (2603:10a6:102:e2::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Mon, 3 Jul 2023 08:15:48 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::ed0b:5730:a1f9:577b]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::ed0b:5730:a1f9:577b%5]) with mapi id 15.20.6544.024; Mon, 3 Jul 2023 08:15:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: da408494-1979-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OQGw7rf6uFTnPj1oTS9nWq0sXkAP5wIfN0+eV5YWRJc=; b=m91PnriyNBTQiPg1sDRsBh4A3Iza0uyfo076aq6HcniInd6X1J+lr4q8V3NVsWzO1U8Txq5brEEwDgQ7F9r4gAGCypXyJMx48Uba7AO+ioCT4jdWinuWPMODgYB6De0Gmc1GPOZ7N1ynTVoNX16EYXr3ty++GIjUPcaZtjf1e2s= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 1dee57a5134de968 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iHkog/xOZi7+D7XW0uFg3V0ooJvBWVY+hW+reHS6t5O0Q3BaxLvVNB3i0ZUNn8TLnkIae4HGFXIcS14AtYxgnvaOa7819sD88jPlvYYPMhs+JS9q7mhBiwTFNWN3n4Kvxa7JFp0lZZx9rqQ4h+i1GW11y0qWUq5Hbeq+FkDusifQeiqdMVfq28RkZL4/JkIY/127wwQu72s/4yXS5PvMju3ovle0dIweDQ/dT+s3Udjwz2/U1O6PO0a+RH3K1JSQP2AuA/uaKkUU5sBU6m/VsNPLBWZ2xcoa1b7cKmOY/Qr5lUae+EckQnV9K23WTdrePGnT8PGPcYoUtoneH6Te5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OQGw7rf6uFTnPj1oTS9nWq0sXkAP5wIfN0+eV5YWRJc=; b=QKft5aUhpq3NuO6DIZBv8UjEBqOPjdmYCxk0n1LZUfmmtaz+xQVEV6X6i02z2LYlHNQUNq6PWzluItPKJEy107zXNE5/bRxQuwK5kZdQAVVcBizO9J+TDFPG+gHt/R0BLvMSd46jjoXxLq2PVv4uK3k7N9WsqEo1+JaEod1u7wRfLufQSuSh66nGit2MNanmoIuy3j6/TLJs8uINnjfTlpT+XsLREjWNP+UltAthmlmF1HOAF86Dg+H5dHn5WD5yh0Is9kTg99i0HnLWPlAilWPPkyuADclZo3aMTIo23FX+h/2791eFIQHE9IcyK0Q9X8VFnrgGLMqj8jrVSjLu2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OQGw7rf6uFTnPj1oTS9nWq0sXkAP5wIfN0+eV5YWRJc=; b=m91PnriyNBTQiPg1sDRsBh4A3Iza0uyfo076aq6HcniInd6X1J+lr4q8V3NVsWzO1U8Txq5brEEwDgQ7F9r4gAGCypXyJMx48Uba7AO+ioCT4jdWinuWPMODgYB6De0Gmc1GPOZ7N1ynTVoNX16EYXr3ty++GIjUPcaZtjf1e2s= From: Luca Fancellu To: Rich Persaud CC: Xen-devel , Wei Chen , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Henry Wang , Community Manager , Doug Goldstein , Bertrand Marquis , Volodymyr Babchuk , Anthony PERARD , Christopher Clark , Daniel Smith , Daniel DeGraaf , "openxt@googlegroups.com" , =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?= , =?utf-8?B?UGlvdHIgS3LDs2w=?= Subject: Re: [RFC PATCH] xen/arm: Rebranding dom0less feature Thread-Topic: [RFC PATCH] xen/arm: Rebranding dom0less feature Thread-Index: AQHZqzMUKP6yBnvUfEC1egkdxmuozK+koJSAgAMWHYA= Date: Mon, 3 Jul 2023 08:15:48 +0000 Message-ID: References: <20230630091210.3742121-1-luca.fancellu@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.600.7) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|PA4PR08MB5981:EE_|AM7EUR03FT022:EE_|PAVPR08MB8941:EE_ X-MS-Office365-Filtering-Correlation-Id: 4684282c-3199-49ce-5d76-08db7b9dbbaa x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 0rHn1lfTxPV8DQCttSSAGBrzz68luYyOJRi5GDNsWDZfyWJIEbeTEuJzsfx5iJCeN6lQWku3lSk+kkaV5L1wZPYGKlyUOLb+BI1WJCxFYEh0ZbCXI6ArLp01g7bZ5XUj9v7IpW3he7LxqGnXSYsfax2o8g221rphG1q/HWi3U4pat5dAY+WBUTRpvDYlsPTVSukoZPXQA/eP3mQiNyybvuKz5IFetMElkisdpLVOZWhg+6o0ksmVhZhMWAe2a/fUUYB+KiXECtEYNeJMnYqbN9dUPRkgW4/oO43KtaxYomGM+CCsKFt38eT+L15R4jZmm44n8ufU+mjPn+fwUwbwd727R8L1+Xgavq8JWSXejspwqbD4ZBmQi+bKU06dsQGgzHDNkQW8pho/jbskoiDvZlCd8AevnvovL+HwLuPCU+ceLPcU5yeynWy3bmQu/m4gWI4K2gI93iDAqS35crltFhVA3Ej+hjB2/PBxC4fxexg8/i5tMNrLeSbycVVKVmIzsJtsznoTcydMz1AixnBqHy+fjMb9LfPT9O5yXvuO4EryT/bMkwnij7lweDmaz9Y32ER4HMOAwDwA146nj8xeuZzkI8MFtXO99S7MUJPMM22PTQetg0fyTntgXMGaXHzak+tonpZnmekAaQqGfI90beErOE5F4FLa1mNJoi21wMg= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(39860400002)(366004)(376002)(136003)(396003)(451199021)(6512007)(91956017)(6506007)(53546011)(316002)(66556008)(38070700005)(76116006)(66476007)(66446008)(64756008)(6916009)(66946007)(4326008)(38100700002)(122000001)(2616005)(83380400001)(186003)(26005)(478600001)(54906003)(8936002)(8676002)(2906002)(5660300002)(966005)(6486002)(71200400001)(7416002)(86362001)(41300700001)(36756003)(33656002)(32563001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB5981 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a329b11b-64cf-4ea1-2c7b-08db7b9db519 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2zQVZ4kCwcUCUTDoGX/po7b7qYe4VKWey/yQ1C1IiSGfOQuyRbTjVnkaMsf8ZqU+j5lA4sPvP60SWnSbCYlLUoFAXMH+WPe2oQkG4ow0mQSKsZ6XjkfIVF4f/iQOb2rTMADSms42vLktclBXQtxlqkyWGDDxoY5cnzPa94jOm3kzJ5s0q2vxpdYfMkjDG5s6cWkXlFFTGwhbbWk0S92qUTOGhrUEqAstWAhnL3jifsRs+blNVy3lSjfRiVUPRRml10UF6NaQfKvlYNx3NpgzsZJvggd6Ms2V/fWJWUAnrWqmruOLDBo0WfVbuswWiUru7yoHr4JrR4R2nxdE3J187Ppyqon3MrGLOwUHOcdQDbcBEQ+NODeyPqrdhQZIY3vD/xHaeW693KnatTGwUqMlTsziAkOHtB3hfzrW3G1YzonKjVS2FBskPdRD3yZQeYOkC8MI+GFXQQcFd2vUVJdNfuRQE5lAj2lWHXIPnOvlsyGLiTbMimZ/ajD+Ynn+WWq/u4saE3jiNh8mIOLMU8VK6+LtfYTjrLYLNTWC9cvTYVyhz0Rs7b7b6dxSyPcpslL/i+DXvmb7YpOErZiFhP5dirgxKttHNeADk6RYooVO6RCtP66f3zy1j2ryzDPjB4DBhuQ8WiYn5LL9xA3N7NTN5ecgEaLzamnNw4mPOs0L6rKkQ2p47YO8k7e2yVXE+njc1sgRVtUNM2GKM4p/gmBf0JbLLqRqS0DN5r8uT4cCpVNHf7x5RGuCZ5kke/FHzWjq X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(346002)(136003)(376002)(451199021)(46966006)(40470700004)(36840700001)(54906003)(6862004)(26005)(6512007)(966005)(53546011)(186003)(33656002)(8936002)(36756003)(86362001)(8676002)(2906002)(6486002)(5660300002)(41300700001)(40460700003)(478600001)(107886003)(6506007)(81166007)(40480700001)(70586007)(356005)(82740400003)(4326008)(70206006)(47076005)(2616005)(336012)(82310400005)(83380400001)(316002)(36860700001)(32563001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2023 08:15:59.1018 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4684282c-3199-49ce-5d76-08db7b9dbbaa X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB8941 DQoNCj4gT24gMSBKdWwgMjAyMywgYXQgMTA6MDcsIFJpY2ggUGVyc2F1ZCA8cGVyc2F1ckBnbWFp bC5jb20+IHdyb3RlOg0KPiANCj4gSGkgTHVjYSwNCj4gDQo+IE9uIEp1biAzMCwgMjAyMywgYXQg MDU6MTIsIEx1Y2EgRmFuY2VsbHUgPGx1Y2EuZmFuY2VsbHVAYXJtLmNvbT4gd3JvdGU6DQo+PiAN Cj4+IA0KPj4gDQo+PiDvu79UaGUgImRvbTBsZXNzIiBmZWF0dXJlIHdhcyBpbnRlbmRlZCB0byBi ZSB0aGUgZmVhdHVyZSB3aGVyZSBhIGRvbVUNCj4+IGRvbWFpbiBjb3VsZCBiZSBsYXVuY2hlZCB3 aXRob3V0IHRoZSBjb250cm9sIGRvbWFpbiAoRG9tMCkNCj4+IGludGVydmVudGlvbiwgaG93ZXZl ciB0aGUgbmFtZSBzZWVtcyB0byBzdWdnZXN0IHRoYXQgRG9tMCBjYW5ub3QNCj4+IGJlIHBhcnQg b2YgdGhlIGNvbmZpZ3VyYXRpb24sIHdoaWxlIGluc3RlYWQgaXQncyBhIHBvc3NpYmxlIHVzZSBj YXNlLg0KDQpIaSBSaWNoLA0KDQo+IA0KPiBUaGFua3MgZm9yIHlvdXIgaW50ZXJlc3QgaW4gWGVu IGJvb3QgaW50ZWdyaXR5LiBQbGVhc2Ugc2VlIHRoZSAyMDE4IGRvbUIgUkZDOg0KPiBodHRwczov L2xpc3RzLnhlbnByb2plY3Qub3JnL2FyY2hpdmVzL2h0bWwveGVuLWRldmVsLzIwMTgtMDYvbXNn MDEzMDYuaHRtbA0KPiANCj4gQXQgWGVuIFN1bW1pdCAyMDE4IChOYW5qaW5nKSBhbmQgWGVuIFN1 bW1pdCAyMDE5IChDaGljYWdvKSwgT3BlblhUIGNvbnRyaWJ1dG9ycyBtYWRlIGEgY2FzZSB0byBY ZW4tb24tQXJtIGNvbnRyaWJ1dG9ycyBmb3IgdGhlIGFyY2hpdGVjdHVyYWwgdW5pZmljYXRpb24g b2YgaW5jdW1iZW50IGRvbTBsZXNzIChBcm0pIGFuZCB0aGUgZG9tQiAoeDg2KSBwcm9wb3NhbCBm b3IgaW1wcm92aW5nIFhlbiBib290IGludGVncml0eS4NCj4gDQo+PiBUbyBhdm9pZCB0aGF0LCBy ZW5hbWUgdGhlICJkb20wbGVzcyIgY29uZmlndXJhdGlvbiB3aXRoIHRoZSBuYW1lDQo+PiAiaHlw ZXJsYXVuY2giLCB0aGF0IGlzIGxlc3MgbWlzbGVhZGluZy4NCj4gDQo+IDIwMTgtMjAyMiB3b3Jr IG9uIFhlbiBsYXVuY2ggaW50ZWdyaXR5LCB0aGFua3MgdG8gQXBlcnR1cyBhbmQgU3RhciBMYWI6 IA0KPiBodHRwczovL3dpa2kueGVucHJvamVjdC5vcmcvd2lraS9IeXBlcmxhdW5jaA0KPiBodHRw czovL3d3dy50aGVyZWdpc3Rlci5jb20vMjAyMi8xMi8xNi94ZW5fNF8xN19oeXBlcmxhdW5jaC8N Cj4gDQo+IDIwMjMgSHlwZXJsYXVuY2ggZGVzaWduIHNlc3Npb24gbGFzdCB3ZWVrLCB0aGFua3Mg dG8gQXBlcnR1cyBhbmQgQU1EOg0KPiBodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL2FyY2hp dmVzL2h0bWwveGVuLWRldmVsLzIwMjMtMDYvbXNnMDE4NzAuaHRtbA0KDQpUaGFuayB5b3UgZm9y IHBvaW50aW5nIG91dCB0aGUgaGlzdG9yeSBvZiB0aGlzIGh1Z2Ugd29yaywgaXQgaXMgdmVyeSBp bnRlcmVzdGluZw0KDQo+IA0KPj4gU2lnbmVkLW9mZi1ieTogTHVjYSBGYW5jZWxsdSA8bHVjYS5m YW5jZWxsdUBhcm0uY29tPg0KPiANCj4gSWYgQXJtIGlzIG5vdyByZWFkeSB0byBpbnZlc3QgZW5n aW5lZXJpbmcgcmVzb3VyY2VzIGludG8gbmV3IFhlbiBsYXVuY2ggaW50ZWdyaXR5IGZlYXR1cmVz IGZvciBzZWN1cml0eSBhbmQgc2FmZXR5LWNyaXRpY2FsIHVzZSBjYXNlcywgdGhhdCBpcyBleGNp dGluZyBuZXdzLCA1IHllYXJzIGludG8gdGhlIG9uLWFnYWluLW9mZi1hZ2FpbiBib290c3RyYXBw ZWQgSHlwZXJsYXVuY2ggcHJvamVjdCEgVGhlIHJvYWRtYXAgd291bGQgYmVuZWZpdCBmcm9tIG5l dyBmdW5kaW5nLg0KDQpJ4oCZbSBhZnJhaWQgdGhhdCB0aGlzIHBhdGNoIGlzIG5vdCBhIGNvbW1p dG1lbnQgZnJvbSBBcm0gaW50byB0aGF0LCB0aGF0IGdvZXMgYWJvdmUgbXkgbGV2ZWwgSeKAmW0g YWZyYWlkLCBidXQgYXMgcGFydCBvZiBvdXIgY29tbXVuaXR5IHdvcmsgd2UgbG9vayBjbG9zZWx5 IHRvIHRoYXQgYW5kIEnigJltIHBlcnNvbmFsbHkgaW50ZXJlc3RlZCBvbiB0aGUgcGF0aA0KdGFr ZW4gYnkgdGhpcyBwcm9qZWN0Lg0KDQo+IA0KPiBXb3VsZCB5b3UgbGlrZSB0byBhdHRlbmQgdGhl IG5leHQgWGVuIHdvcmtpbmcgZ3JvdXAgY2FsbCBmb3IgSHlwZXJsYXVuY2g/DQoNCkkgdGhpbmsg QmVydHJhbmQgaXMgYWxyZWFkeSBpbnZvbHZlZCBpbnRvIGl0LCBldmVuIGlmIHVuZm9ydHVuYXRl bHkgc29tZSBoaWdoIHByaW9yaXR5IHdvcmsgc29tZSB0aW1lcyB0YWtlIHByZWNlZGVuY2UuDQoN Ck9uIG15IHNpZGUgSSBmb2xsb3cgdGhlIHdvcmsgb24gdGhlIE1MLCBzcGVjaWZpY2FsbHkgdGhl IG9uZSByZWxhdGVkIHRvIHRoZSBBcm0gc2lkZS4NCg0KQ2hlZXJzLA0KTHVjYQ0KDQo+IA0KPiBS aWNoDQoNCg0K From xen-devel-bounces@lists.xenproject.org Mon Jul 03 09:21:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Jul 2023 09:21:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558037.871805 (Exim 4.92) (envelope-from ) id 1qGFjh-0004qX-2f; Mon, 03 Jul 2023 09:20:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558037.871805; Mon, 03 Jul 2023 09:20:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGFjg-0004qQ-W3; Mon, 03 Jul 2023 09:20:44 +0000 Received: by outflank-mailman (input) for mailman id 558037; Mon, 03 Jul 2023 09:20:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGFjf-0004qK-EF for xen-devel@lists.xenproject.org; Mon, 03 Jul 2023 09:20:43 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGFje-0002EW-SM; Mon, 03 Jul 2023 09:20:42 +0000 Received: from [54.239.6.190] (helo=[192.168.12.110]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qGFje-0002nT-LZ; Mon, 03 Jul 2023 09:20:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=bI6eNNRIQh8mHy+gr8uKo01TWCKhmqAEWoqtPPEdrhc=; b=Xx4cduB1J3GBhibYHLIxDFyGrJ mVUWdIQ6KcqfmSddwCO95lOzaDt9j1TuGj+A2BVRF2h3vhkJtMQNrIJAXtCw/npjRt8EtG3UxWqMC v4EHVGZckjCb40VPk/oYrsfY5j5OQ8NlnXGhu9tsVFcLc/vxbwoyQPjB/NtQFxfg3k3Y=; Message-ID: <93e0e360-d7f2-1987-a0a6-73420c55afcd@xen.org> Date: Mon, 3 Jul 2023 10:20:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 31/52] xen/mpu: make early_fdt_map support in MPU systems Content-Language: en-US To: Penny Zheng , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Wei Chen , "Volodymyr_Babchuk@epam.com" References: <20230626033443.2943270-1-Penny.Zheng@arm.com> <20230626033443.2943270-32-Penny.Zheng@arm.com> <9530f9f8-795b-783a-bc74-e30a3c5c2fd3@amd.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 03/07/2023 06:12, Penny Zheng wrote: > Hi, > > > On 2023/6/30 23:02, Julien Grall wrote: >> Hi, >> >> On 30/06/2023 15:42, Ayan Kumar Halder wrote: >>> Hi Julien, >>> >>> On 30/06/2023 12:22, Julien Grall wrote: >>>> >>>> >>>> On 30/06/2023 11:49, Ayan Kumar Halder wrote: >>>>> >>>>> On 30/06/2023 05:07, Penny Zheng wrote: >>>>>> Hi, >>>>> Hi Penny, >>>>>> >>>>>> >>>>>> On 2023/6/30 01:22, Ayan Kumar Halder wrote: >>>>>>> >>>>>>> On 26/06/2023 04:34, Penny Zheng wrote: >>>>>>>> CAUTION: This message has originated from an External Source. >>>>>>>> Please use proper judgment and caution when opening attachments, >>>>>>>> clicking links, or responding to this email. >>>>>>>> >>>>>>>> >>>>>>>> In MPU system, MPU memory region is always mapped PAGE_ALIGN, so >>>>>>>> in order to >>>>>>>> not access unexpected memory area, dtb section in xen.lds.S >>>>>>>> should be made >>>>>>>> page-aligned too. >>>>>>>> We add . = ALIGN(PAGE_SIZE); in the head of dtb section to make >>>>>>>> it happen. >>>>>>>> >>>>>>>> In this commit, we map early FDT with a transient MPU memory >>>>>>>> region, as >>>>>>>> it will be relocated into heap and unmapped at the end of boot. >>>>>>>> >>>>>>>> Signed-off-by: Penny Zheng >>>>>>>> Signed-off-by: Wei Chen >>>>>>>> --- >>>>>>>> v3: >>>>>>>> - map the first 2MB. Check the size and then re-map with an >>>>>>>> extra 2MB if needed >>>>>>>> --- >>>>>>>>   xen/arch/arm/include/asm/arm64/mpu.h |  3 ++- >>>>>>>>   xen/arch/arm/include/asm/page.h      |  5 +++++ >>>>>>>>   xen/arch/arm/mm.c                    | 26 >>>>>>>> ++++++++++++++++++++------ >>>>>>>>   xen/arch/arm/mpu/mm.c                |  1 + >>>>>>>>   xen/arch/arm/xen.lds.S               |  5 ++++- >>>>>>>>   5 files changed, 32 insertions(+), 8 deletions(-) >>>>>>>> >>>>>>>> diff --git a/xen/arch/arm/include/asm/arm64/mpu.h >>>>>>>> b/xen/arch/arm/include/asm/arm64/mpu.h >>>>>>>> index a6b07bab02..715ea69884 100644 >>>>>>>> --- a/xen/arch/arm/include/asm/arm64/mpu.h >>>>>>>> +++ b/xen/arch/arm/include/asm/arm64/mpu.h >>>>>>>> @@ -72,7 +72,8 @@ typedef union { >>>>>>>>           unsigned long ns:1;     /* Not-Secure */ >>>>>>>>           unsigned long res:1;    /* Reserved 0 by hardware */ >>>>>>>>           unsigned long limit:42; /* Limit Address */ >>>>>>>> -        unsigned long pad:16; >>>>>>>> +        unsigned long pad:15; >>>>>>>> +        unsigned long tran:1;   /* Transient region */ >>>>>>>>       } reg; >>>>>>>>       uint64_t bits; >>>>>>>>   } prlar_t; >>>>>>>> diff --git a/xen/arch/arm/include/asm/page.h >>>>>>>> b/xen/arch/arm/include/asm/page.h >>>>>>>> index 85ecd5e4de..a434e2205a 100644 >>>>>>>> --- a/xen/arch/arm/include/asm/page.h >>>>>>>> +++ b/xen/arch/arm/include/asm/page.h >>>>>>>> @@ -97,19 +97,24 @@ >>>>>>>>    * [3:4] Execute Never >>>>>>>>    * [5:6] Access Permission >>>>>>>>    * [7]   Region Present >>>>>>>> + * [8]   Transient Region, e.g. MPU memory region is temproraily >>>>>>>> + *                              mapped for a short time >>>>>>>>    */ >>>>>>>>   #define _PAGE_AI_BIT            0 >>>>>>>>   #define _PAGE_XN_BIT            3 >>>>>>>>   #define _PAGE_AP_BIT            5 >>>>>>>>   #define _PAGE_PRESENT_BIT       7 >>>>>>>> +#define _PAGE_TRANSIENT_BIT     8 >>>>>>> I don't think this is related to MPU. At least when I look at the >>>>>>> bit representation of PRBAR_EL1/2, >>>>>> >>>>>> This set of _PAGE_xxx flags aren't compliant with PRBAR_EL1/2 >>>>>> register map. >>>>>> It is a flag passed to function map_pages_to_xen() to indicate memory >>>>>> attributes and permission. >>>>> >>>>> But aren't you writing these flags to PRBAR_EL1/EL2 when you call >>>>> xen_mpumap_update_entry(). >>>>> >>>>> In the below snippet of xen_mpumap_update_entry(), IIUC, you are >>>>> writing these flags. >>>>> >>>>>          xen_mpumap[idx].prbar.reg.ap = PAGE_AP_MASK(flags); >>>>>          xen_mpumap[idx].prbar.reg.xn = PAGE_XN_MASK(flags); >>>>> >>>>>          write_protection_region((const pr_t*)(&xen_mpumap[idx]), >>>>> idx); >>>>> >>>>> Please clarify here. >>>>> >>>>> In this case, I don't prefer mixing hardware specific bits with >>>>> software only representation for these reasons :- >>>>> >>>>> 1. It makes it confusing and hard to differentiate the hardware >>>>> specific attrbutes from software only. >>>> >>>> Penny's approach matches what we are doing in the MMU code. We want >>>> to have a way for the caller to pass just set of flags and let the >>>> callee to decide what to do with them. >>>> >>>> This may be flags converted for HW fields or just used by the logic. >>>> >>>> If you disagree with this approach, then can you propose a different >>>> way that we can discuss? > > Thanks ayan for pointing out that RES0 is not suitable for storing > software-only flags, agreed. > > Then, maybe we should refine the existing "struct pr_t" to store these > sw bits, like: > ``` > typedef union { >     struct { >        uint8_t tran:1; /* Transient region */ >        uint8_t p2m_type:4; /* Used to store p2m types.*/ Why do you need the p2m_type? >     }; >     uint8_t bits; > } pr_flags; > > /* MPU Protection Region */ > typedef struct { >         prbar_t prbar; >         prlar_t prlar; >     pr_flags flags; > } pr_t; > ``` > The drawback is that, considering the padding, "struct pr_t" expands > from 16 bytes to 24 bytes. For clarifications, pr_t is going to be used to create an array in Xen, right? If so, what's the expected size of the array? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Jul 03 09:28:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Jul 2023 09:28:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558041.871815 (Exim 4.92) (envelope-from ) id 1qGFrV-0005TM-RC; Mon, 03 Jul 2023 09:28:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558041.871815; Mon, 03 Jul 2023 09:28:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGFrV-0005TF-Oe; Mon, 03 Jul 2023 09:28:49 +0000 Received: by outflank-mailman (input) for mailman id 558041; Mon, 03 Jul 2023 09:28:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGFrU-0005T9-1a for xen-devel@lists.xenproject.org; Mon, 03 Jul 2023 09:28:48 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 007227dc-1984-11ee-b237-6b7b168915f2; Mon, 03 Jul 2023 11:28:44 +0200 (CEST) Received: from mail-mw2nam04lp2171.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 Jul 2023 05:28:41 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by SN7PR03MB7257.namprd03.prod.outlook.com (2603:10b6:806:2ee::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Mon, 3 Jul 2023 09:28:38 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::1c83:1877:a68b:8902]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::1c83:1877:a68b:8902%7]) with mapi id 15.20.6544.024; Mon, 3 Jul 2023 09:28:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 007227dc-1984-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1688376524; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=yXG4lmvoiM4rScTtfKniDJqcjh7RsCVbVHYcfuBUC04=; b=bDRTKFaJz60DuaoZgjXXUNanzhYr/oo0Ad325W3dMTQ8jf0uh0eZ8Ecn sIRZaa660y6ndPB+Bm3gN8vL8fCxyuDPixRgReUIFMHg20I2mhj5jcoz7 baGWOiG6lhYwpNzr9jyAbPc3LHPpJhHsgjrsW5hyyoo103tgSVLIpK8dy 4=; X-IronPort-RemoteIP: 104.47.73.171 X-IronPort-MID: 114852342 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:jI79Mq67sAi+C6c+5ZcJywxRtPbGchMFZxGqfqrLsTDasY5as4F+v mZMCmuHb67fMWb3f9xyaovi8UgAsZ+Az4IyQAprpS0yHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9lU35ZwehBtC5gZlPa8T5geE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m1 fkhCg1VREu6oPPn8bO3ZblBuv4KBZy+VG8fkikIITDxK98DGcyGZpqQoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6Ml0ooj+GF3Nn9I7RmQe1PmUmVv CTe9nnRCRAGLt2PjzGC9xpAg8eWxH+rBdhJSOfQGvhC0QWO2EYXKicscgGVp6O6j36jZ/EcJ BlBksYphe1onKCxdfHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpQN4sudIyRDcq/ kSUhN6vDjtq2JWKTVqN+7HSqim9UQAXMGsDaCksXQYDpd75r+kblQnTR9xuFKq0iNzdGjzqx T2O6i8kiN0uYdUj0qy6+RXCnGiqr52REgotvFyIBySi8x9zY5Oja8qw81/H4P1cLYGfCF6co HwDnMvY5+cLZX2QqBGwrCw2NOnBz5643Pf02DaDw7FJG+yRxkOe IronPort-HdrOrdr: A9a23:o/wo4KmO3FlL3fhdnn1GbipWA4DpDfLo3DAbv31ZSRFFG/Fw9/ rCoB17726QtN91YhsdcL+7V5VoLUmzyXcX2/hyAV7BZmnbUQKTRekP0WKL+Vbd8kbFh41gPM lbEpSXCLfLfCJHZcSR2njELz73quP3jJxBho3lvghQpRkBUdAF0+/gYDzranGfQmN9dP0EPa vZ3OVrjRy6d08aa8yqb0N1JNQq97Xw5fTbiQdtPW9f1DWz X-Talos-CUID: 9a23:xDZ9Em6b4dCwhFkXUNss1EstOP19WCbk62aBEk60JjZEdIe8YArF X-Talos-MUID: =?us-ascii?q?9a23=3AbsQ6pQ7NFoLZmQyKsom0SPUExow5u7mwIkQvq68?= =?us-ascii?q?h4eeCby91Cyqhr3e4F9o=3D?= X-IronPort-AV: E=Sophos;i="6.01,177,1684814400"; d="scan'208";a="114852342" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eFlFbuCbvjBD2ywW/gITMlAZkKXM7/mip5Z6R4k3w98CaKaRcq9im5J/3xEGn1HAZdH8F4WSnbNhfhMkM6PDvR46csewyylpFMoA5RxSXyyKgZlcFNyfHekb2siDL1seKqdzDZykikw6RcroRmz1Ii0yLIW5/a5xclSWmB7R/MfbtEbxlXZYLBR0L3Cv+J5RasNmWRYJMUYsUZz4bs6YxvvdtUOgF1VDsIyw0/g7Ew//peiu6LY9mZy0UdjMAdnD5dtNJZQDicnbkVlCekJO0K+W7UhxREXOaNPlG3Ty+gxwjJSE+A1gwLHO0vwPgDlE6bla6a8cHrfEraBeGIXtVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CLP1TraNndqjN77FTbv4iykyD/Gr/u0nmg9JO9jv7ac=; b=jihuNKG2+0eELS5HZK6v1k4A3wPZGmrTRaMfcYv1F5m6E0aE+pK0wA0C8SeOuL2wNKctEJv/I3l1kdcKUoS8m0fp35cXO03CVbCsiYtlkVArxs26byFzkuwabvIvTd4OSbuM7ZCPHXIkD0r993UuNGsLD/kzKGOo3uuwI8nDAe4zMGOKjTp+Q4COMpEZUmAkiwJpDiMgBTZmofFtWO9qsJ4Zpb/IkVdFhIrTMYAnC3ZuhmJMPvBA2YCP6/Jo57l3GWVrH7AeTrHPmE7OJjfpwCj5SBVze0fmfZx1MpnWuysIiCrEQK9Ya/3N08zv+ZUSNfnimXtd1nghDHi8GLRSxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CLP1TraNndqjN77FTbv4iykyD/Gr/u0nmg9JO9jv7ac=; b=iAeUVVLBlKTVENMEMpVVhZcHvUlG43kTS0AG9WPssu8QdrmKcMs8eCM8eeN2YenKwXXoywhFU5ve3zYpDGzNQfhXqZc62AaX27groxOgJnZJ6bg/MSpUYouaT5a7o6oZTWExa7Yvf2egRaQpqDrjCKHKsNUaBUFs0janqYXYOHs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 3 Jul 2023 11:28:31 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: xen-devel@lists.xenproject.org, Jan Beulich , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: Re: [PATCH v2] amd: disable C6 after 1000 days on Zen2 Message-ID: References: <20230630131820.29323-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P302CA0030.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:2c1::16) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|SN7PR03MB7257:EE_ X-MS-Office365-Filtering-Correlation-Id: 26aedba8-6dd3-4721-5972-08db7ba7e1a9 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: slzp9kfDHhWzUExUl31oaPx5WXvwNFYJUZiNknOMO7rKzUE5vFzTDlRe12M9s/NBg/R6nYwqqRYfEJEMYIa5lnBFWGCItNbWsFZnHjy7bPOCVAOFj9BjcayVW+eipDoVVsR3I46QhCjTGRp1VyxDPQL84bJfXCrmB+xI4GZW02kYDuEv7htuZwVfcFJgmRyhu7hh6+BbT1a2i2NwtPicmHTXWGEK3nZb+dpARPDK39StCqEwFAJ+Y53OCExJJcqM2M9qvlZfiZukD0jr4FCQIX917hrXuMplNJk/PYXHJQ6a0cbex3da9DWlc7lzbIYkzXmB2r/TiaifZE9H4UWxv0+XC1CzWvoIBNmBIQhrSfkvA8Jg/UO/1YB5QE3EmEP3OvPK/FWNE87RqE/fjfisgrAyxS1+XjaUrD5f3jcSZ9xhuJYfXa9T7EMpeSE6dLFmT5PKKMTmgUFYVOIJ+h1qNxzn1mzvYWuHh0Diu/xNWfATjCwmSWGHfJU8e2SGOeNCOCxN+0i+XDczUc5gTsjfW5qTYotb7N+SPo0aexK7++renW/6NiTrH4QKE+/ytBSFZMxRE8VewGyk2ZtwGqzI5+KYQYgpsJFCogF5Z4MfAlYxtiXYLVFzyKEv5jaQSjfN X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(396003)(366004)(136003)(39860400002)(346002)(451199021)(2906002)(41300700001)(6862004)(5660300002)(8936002)(8676002)(85182001)(86362001)(186003)(82960400001)(478600001)(26005)(6512007)(6506007)(9686003)(6666004)(53546011)(6486002)(316002)(6636002)(4326008)(66476007)(66556008)(66946007)(38100700002)(54906003)(83380400001)(221023011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZW9BL3lMRmtDeWVwNWp3bnl1WHBWUjVSYVp3SE9uM0dYWVZjSUFoZzVCQlVh?= =?utf-8?B?aWFJcC9RVFdtVXYzNXdzMzhpbk5LRk9LRkM1NlZBVkhPbTdPeFE3NUREZVZs?= =?utf-8?B?eFN0SVBGWThlUDJnSnMvQ005ZUFnV2RCYjFERklIYmZGODJZb0V2S2FQdmIr?= =?utf-8?B?dkl3U3NwN0RYR1FUVlRZUDRjQTdKbTl2VjlSSkF0VkZMTktsb1lYRDBWL1Rn?= =?utf-8?B?OE5DR0w2U2VobjJsMVdPS3lxZTQrQUxxUkRiVC9yanNIeVlEYUprODY3UTJB?= =?utf-8?B?ZTNhc3RXM2FMdEYxcWhIQXRXM1dJL2JDcnZGalM4SG5Dd3N4MTJ0NUhEVkI5?= =?utf-8?B?dmJvNFVrWG1oWjJENHZiclRoNmtqMUlsSGhIK0ZjS1pzTE9vU3hMRXJBZ1JI?= =?utf-8?B?YkJtSTJ4QjhDYU84eWJhYVNrcmhER1FTdnRRdDNydmh1dWJQK2g4dzgzZ1J0?= =?utf-8?B?NmZ2eUlQWEJ4amxhNkt1U0ZIaUZOd2ZUS2o2ajAyMVl3ZFVTYmtLL3BnaGlm?= =?utf-8?B?MHBPdk9RYjVKdDBSRDVRTzNHaXo3aTB2ckRRWjV0dklXdGI2N2VhR3Jnb0M0?= =?utf-8?B?YjIvKzdBOENoNGpibDRkVHBVYXNyS1dwWWlreWUycEhZQkNnYWxmdmQzblBZ?= =?utf-8?B?dS83WElHVm8vNXBYVTh6NVFFS2dabXBMS3A4WmQvUTFBVno4cnkxeGNnblpq?= =?utf-8?B?QlFQVDVBdkhOWlZUSkg0bmYvaTRuZ0t6OFplTmxwQjYwM2RaaW5JZnhwTkhO?= =?utf-8?B?UzhQcDlpTG5NckhwNVJZU0NUUit5dGFZUWtnNVRyOHNUWDRwYjI1Nk1FbEF0?= =?utf-8?B?WmZ4U2h5M09SbjE1WWFtQTJLSDVIR3FpMzFTTU04QmkzeWRNTmg2SzFQT0ZE?= =?utf-8?B?U3Flczh3NGo3MW5KMU9SK2k2SWtSWDc0bTdJOGVtd3NsOWh3RWlrUDFZU2FB?= =?utf-8?B?RHg0WUtSZEVGcFhkTzdPZFR1bXk5RGl0Ry9DV3RmYm9RZXZZc0ZmekNlVjJu?= =?utf-8?B?UFhkOWNxY3JpeFRiMHdNaDVJNlcrK1NZUksvWDhMZ2xQSGdwSk5WQ2lIQVpQ?= =?utf-8?B?cFA3ZWxoTlFDdWl5NUhaM2ZZK216Wk81MklmdDk3UDJEV0c4dW1OK05RRzdj?= =?utf-8?B?bDRTVnMxNlRac05LKzBOdzZGNkZjNTZrak5VUVpLMGRXd2pMelNJUk9vU3dC?= =?utf-8?B?SHhCRENOVzhhWHBVbFFKU1JWV0JhWStvWWxRNzZDZGJtVXJWREovUDQwN0x0?= =?utf-8?B?bFRkREVMQ045cjM0VFcvaG1qUWp2Ryt5WG1HOVdZVVk2dExLTnJwakM2b3lX?= =?utf-8?B?R1RwVHRvd1A1ZnlaNDc2NnVTeGZlZUhubExuSHp0OUJNYit3TW9DbDl4cVlK?= =?utf-8?B?c0VEelo1ZHJDOW11alFoRUJOVFRQNHZnM2Q3cVdxck5Gby9KbnpnM3FiMlY1?= =?utf-8?B?KzJ3MUU1aDVnOW9ydEZUUmFaeGhHL0xSUXNuc3Z0OU0wMi9XY2JEL0lkWHl5?= =?utf-8?B?WGxNNGFaYk83QlNhcUFpYmE0YmgzcGxIbFV0dHhYMi9SQlZRMlpXZmxaVGdH?= =?utf-8?B?ZWJIVlQ3S3N4c1ZiMHJvWjVpODVXMkdsUm12MlBsMkcxK3QrYUZmSWE0K3ox?= =?utf-8?B?N2tjZFFjV3A3cHF6aStMa0NIcm9CYjFQdzNUWVp0Ukk0ZE5uSldxa1p0R3Yx?= =?utf-8?B?TkErR2E3cGJvQ3ZzMjZsdjUraVRPWXhjQ1ZQWG1IKzEvU2NlSXJpNlhxVGJH?= =?utf-8?B?ajRMc2hSdE1aTWpwM3R3eDRZVFhTdXVFWTkrWW41ejRzOStwZjF3T2JFWDgw?= =?utf-8?B?VklSR3JpS3dDUFZGUTNUeXBZbktnWGV1REtPaFQ2NllTMkJaZ3ZxUC82My9I?= =?utf-8?B?RjRsRmlPbGVWc25Pa2Jram9xTlpUZWRVVTFmby94SnBwKzV5Lytyd0U2Szh1?= =?utf-8?B?RWptZW5TNGN0cURoMk0xanZtSGxXTVlZemZGdDJ3NmZBNlFXZU1VaDFUY2hH?= =?utf-8?B?aDltTjNFZHVvbXRwNzhzUGMvV2hwQW41SmM5b3FkYW1HcWhmQzIzVVhCSGhW?= =?utf-8?B?S2RzMXA2SkNMT09iNytzTjBERXBDb05LV1lRTzk1WFBudXlUaFlCalFsY0xI?= =?utf-8?Q?ogYxg2ZNdD4kvhgOnYx0v4oJA?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: UayZq3vraZuMSBw2d7np8DPttTHtMbKeZiKIVVJmu2GLpCKLOeKUvzyviiPACjcKIlY5E5hku8dj4pLa4PT3JUTihGjhpUWEX5nuAriT/td7tdgAYhAIDAkAcVzfr++pXJazpDUEx2M0E4HNdPFPr+I1Q36MiAI+qTnTqszj4fzt1a0urE6NrTKIQQ+kU9Oa+SUmRm2oCoYwMgoCCeiDm2Hh6gSmBu09GqTbS9AAbLUYZM+VFxFBV/kMf1+NPdNwybi0ZRK0t6SM1zwYMXLegXK452SWemqeFoCVF/KZ/aOFMIAKgV3xOCA2fG8Q3PGPiykJWCQQ1992NiRjH0snPxSaiBMpL8Xou4YICkYxJHAxQ+8nPkZYA15iS8QygUI2Ndu7tMLquBprQvJKfPswOrPzlTg9qntZFPAi16pARxL3e6qS1uR24e03X0ycMvYkQjnxxnYPcTDP6iJp9EzUm/r16A4n2T1FSRAg0ubIMt3ljuXS6vW+6uMg1570TLmlWe0z/7vvIpnglyggY8+ksmsb2H/gOt2aLCpTX+fPhjt6xivKphUY5KKsP92cCWW7Pv6cUcVs0xhxBL5PIwU3dP8BgI8QMiQVwBEqYYT9X7IxFG6kEU5Hn6zgDhB7xVLAlXEoP7/h21LU8frqBsJPQqtXwECYvwMkcK8J7s271xkwr6SBH2PfCQzb/QwhfMF4u7hMyv2Q5w8tKS7f5Abw2VCX0+CgOavGexn/ERsnVgmQqKBwMhiXG35/13+q8JcaNOseQBX0LCstRM2kgEcEdMQjZngKk30n24tXpMdVc88OOosCzzuUuROSfjkgPFtmxB7mPpLTUvoqq+JXPT2OMLx0ffyHPQpQHdSvG9CePlw= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 26aedba8-6dd3-4721-5972-08db7ba7e1a9 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2023 09:28:38.0654 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HACn/XnNDaIgTuXTNGV3EGjRDNk+fzEOpWjLQroT8NPajQhCkUiEqGFv+KH8ZDfEwYhv00QimcH2x/b0t0YGQg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR03MB7257 On Fri, Jun 30, 2023 at 06:10:10PM +0100, Andrew Cooper wrote: > On 30/06/2023 2:18 pm, Roger Pau Monne wrote: > > diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c > > index 0eaef82e5145..bdf45f8387e8 100644 > > --- a/xen/arch/x86/cpu/amd.c > > +++ b/xen/arch/x86/cpu/amd.c > > @@ -51,6 +51,8 @@ bool __read_mostly amd_acpi_c1e_quirk; > > bool __ro_after_init amd_legacy_ssbd; > > bool __initdata amd_virt_spec_ctrl; > > > > +static bool __read_mostly c6_disabled; > > + > > static inline int rdmsr_amd_safe(unsigned int msr, unsigned int *lo, > > unsigned int *hi) > > { > > @@ -905,6 +907,31 @@ void __init detect_zen2_null_seg_behaviour(void) > > > > } > > > > +static void cf_check disable_c6(void *arg) > > +{ > > + uint64_t val; > > + > > + if (!c6_disabled) { > > + printk(XENLOG_WARNING > > + "Disabling C6 after 1000 days apparent uptime due to AMD errata 1474\n"); > > + c6_disabled = true; > > + smp_call_function(disable_c6, NULL, 0); > > + } > > + > > + /* Update the MSR to disable C6, done on all threads. */ > > + if (rdmsr_safe(MSR_AMD_CSTATE_CFG, val)) { > > +error: > > + printk_once(XENLOG_ERR > > + "Unable to disable C6 on AMD system affected by errata 1474\n" > > + "Reboot recommended, otherwise system might hang\n"); > > + return; > > + } > > + val &= ~(CSTATE_CFG_CCR0_CC6EN | CSTATE_CFG_CCR1_CC6EN | > > + CSTATE_CFG_CCR2_CC6EN); > > + if (wrmsr_safe(MSR_AMD_CSTATE_CFG, val)) > > + goto error; > > These MSRs don't fault, and we already excluded hypervisors previously, > so the safe() doesn't really help.  The only way you'd spot a failure is > by reading back and noticing that the update didn't take effect. I was worried about people explicitly clearing the hypervisor flag in CPUID and then Xen crashing on boot, so better safe than sorry. I don't see much value in crashing here if the MSR is somehow unavailable. > Independently, this really really makes me want to dust off my > msr_{set,clear}_bits() helpers to reduce the boilerplate required for > logic like this. > > > +} > > + > > static void cf_check init_amd(struct cpuinfo_x86 *c) > > { > > u32 l, h; > > @@ -1171,6 +1198,9 @@ static void cf_check init_amd(struct cpuinfo_x86 *c) > > if ((smp_processor_id() == 1) && !cpu_has(c, X86_FEATURE_ITSC)) > > disable_c1_ramping(); > > > > + if (c6_disabled) > > + disable_c6(NULL); > > + > > check_syscfg_dram_mod_en(); > > > > amd_log_freq(c); > > @@ -1180,3 +1210,43 @@ const struct cpu_dev amd_cpu_dev = { > > .c_early_init = early_init_amd, > > .c_init = init_amd, > > }; > > + > > +static int __init cf_check c6_errata_check(void) > > +{ > > + /* > > + * Errata #1474: A Core May Hang After About 1044 Days > > + * Set up a timer to disable C6 after 1000 days uptime. > > + */ > > + s_time_t delta; > > + > > + /* > > + * Apply to all Zen2 models. According to AMD revision guides at least > > + * Rome, Castle Peak, Renoir, Lucienne and Matisse are affected. > > You probably want to replicate the spectral chicken comment about how > identifying Zen2 is actually very hard. > > That said, I don't see anything which limits this logic to Fam17h. Oh, right, will add the missing fam17h check. > > + */ > > + if (cpu_has_hypervisor || !boot_cpu_has(X86_FEATURE_AMD_STIBP)) > > + return 0; > > + > > + /* > > + * Deduct current TSC value, this would be relevant if kexec'ed for > > + * example. Might not be accurate, but worst case we end up disabling > > + * C6 before strictly required, which would still be safe. > > + * > > + * NB: all affected models (Zen2) have invariant TSC and TSC adjust > > + * MSR, so early_time_init() will have already cleared any TSC offset. > > + */ > > + delta = DAYS(1000) - tsc_ticks2ns(rdtsc()); > > + if (delta > 0) { > > + static struct timer errata_c6; > > + > > + init_timer(&errata_c6, disable_c6, NULL, 0); > > + set_timer(&errata_c6, NOW() + delta); > > + } else > > + disable_c6(NULL); > > I doubt the smp_call_function() is going to be happy at presmp time. I did take a look and forced it by setting delta = 0, AFAICT it works fine, cpu_online_map will be zeroed, so on_selected_cpus() is just a noop. Interrupts are enabled by that point, so I don't see a problem with this approach. > Do we really care if we're already beyond the timeout? I would expect that C6 will already be disabled in that case, but I don't see an issue with Xen also setting those bits. > > + > > + return 0; > > +} > > +/* > > + * Must be executed after early_time_init() for tsc_ticks2ns() to have been > > + * calibrated. That prevents us doing the check in init_amd(). > > + */ > > +presmp_initcall(c6_errata_check); > > diff --git a/xen/arch/x86/include/asm/msr-index.h b/xen/arch/x86/include/asm/msr-index.h > > index 2749e433d2a7..5df090fba791 100644 > > --- a/xen/arch/x86/include/asm/msr-index.h > > +++ b/xen/arch/x86/include/asm/msr-index.h > > @@ -211,6 +211,11 @@ > > > > #define MSR_VIRT_SPEC_CTRL 0xc001011f /* Layout matches MSR_SPEC_CTRL */ > > > > +#define MSR_AMD_CSTATE_CFG 0xc0010296 > > +#define CSTATE_CFG_CCR0_CC6EN (_AC(1, ULL) << 6) > > +#define CSTATE_CFG_CCR1_CC6EN (_AC(1, ULL) << 14) > > +#define CSTATE_CFG_CCR2_CC6EN (_AC(1, ULL) << 22) > > While MSR_AMD_CSTATE_CFG is liable to stay stable, the CC6EN bits are > uarch specific and not applicable to others. > > I'd suggest keeping them local to c6_errata_check(), which probably > ought to gain a zen2 somewhere in the name. > > They definitely can't say in a global header with names that don't tie > them to Zen2 specifically. That MSR and bit definitions are also available on family 19h model 11h and model 70h (with even more bits added to the MSR), so it feels weird to name them Zen2 specifically (as it seems AMD is attempting to keep the current bits stable across families). I can move the defines to inside the function, but I'm not convinced those are uarch specific. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Jul 03 09:31:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Jul 2023 09:31:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558046.871825 (Exim 4.92) (envelope-from ) id 1qGFu9-0006tC-9T; Mon, 03 Jul 2023 09:31:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558046.871825; Mon, 03 Jul 2023 09:31:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGFu9-0006t5-6S; Mon, 03 Jul 2023 09:31:33 +0000 Received: by outflank-mailman (input) for mailman id 558046; Mon, 03 Jul 2023 09:31:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGFu7-0006sz-J0 for xen-devel@lists.xenproject.org; Mon, 03 Jul 2023 09:31:31 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGFu7-0002S7-2C; Mon, 03 Jul 2023 09:31:31 +0000 Received: from [54.239.6.190] (helo=[192.168.12.110]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qGFu6-0003B2-Rx; Mon, 03 Jul 2023 09:31:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=/J1Ygkk6TXdimnrb8R+3iOtnEaTdzS5kxReB1Rk3SQc=; b=aA90aqdXAMLH7UlIFdqKFTl1JH Blb7eQrYadtb5yQ8Qh/5McqFaiwzzkW0XM5rt+pfy7SZ+iB5cqVT/fU+jit5XdJ7uC7OcFFomrTJW 915nFXiJWhsR3HRfQMxtG7jjrzrLcwjv1dWpn5huEppn/MRy3yZay708gljGScp2oc9Q=; Message-ID: <15791f2e-b4cf-aa60-3f67-d9e74877e54b@xen.org> Date: Mon, 3 Jul 2023 10:31:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 33/52] xen/mpu: initialize frametable in MPU system Content-Language: en-US To: Penny Zheng , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Wei Chen References: <20230626033443.2943270-1-Penny.Zheng@arm.com> <20230626033443.2943270-34-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 03/07/2023 07:10, Penny Zheng wrote: > On 2023/6/30 23:19, Ayan Kumar Halder wrote: >> Hi Penny, >> >> On 26/06/2023 04:34, Penny Zheng wrote: >>> CAUTION: This message has originated from an External Source. Please >>> use proper judgment and caution when opening attachments, clicking >>> links, or responding to this email. >>> >>> >>> Xen is using page as the smallest granularity for memory managment. >>> And we want to follow the same concept in MPU system. >>> That is, structure page_info and the frametable which is used for >>> storing >>> and managing the smallest memory managment unit is also required in >>> MPU system. >>> >>> In MPU system, since we can not use a fixed VA >>> address(FRAMETABLE_VIRT_START) >>> to map frametable like MMU system does and everything is 1:1 mapping, we >>> instead define a variable "struct page_info *frame_table" as frametable >>> pointer, and ask boot allocator to allocate appropriate memory for >>> frametable. >>> >>> As frametable is successfully initialized, the convertion between >>> machine frame >>> number/machine address/"virtual address" and page-info structure is >>> ready too, like mfn_to_page/maddr_to_page/virt_to_page, etc >>> >>> Signed-off-by: Penny Zheng >>> Signed-off-by: Wei Chen >>> --- >>> v3: >>> - add ASSERT() to confirm the MFN you pass is covered by the frametable. >>> --- >>>   xen/arch/arm/include/asm/mm.h     | 14 ++++++++++++++ >>>   xen/arch/arm/include/asm/mpu/mm.h |  3 +++ >>>   xen/arch/arm/mpu/mm.c             | 27 +++++++++++++++++++++++++++ >>>   3 files changed, 44 insertions(+) >>> >>> diff --git a/xen/arch/arm/include/asm/mm.h >>> b/xen/arch/arm/include/asm/mm.h >>> index daa6329505..66d98b9a29 100644 >>> --- a/xen/arch/arm/include/asm/mm.h >>> +++ b/xen/arch/arm/include/asm/mm.h >>> @@ -341,6 +341,19 @@ static inline uint64_t gvirt_to_maddr(vaddr_t >>> va, paddr_t *pa, >>>   #define virt_to_mfn(va)     __virt_to_mfn(va) >>>   #define mfn_to_virt(mfn)    __mfn_to_virt(mfn) >>> >>> +#ifdef CONFIG_HAS_MPU >>> +/* Convert between virtual address to page-info structure. */ >>> +static inline struct page_info *virt_to_page(const void *v) >>> +{ >>> +    unsigned long pdx; >>> + >>> +    pdx = paddr_to_pdx(virt_to_maddr(v)); >>> +    ASSERT(pdx >= frametable_base_pdx); >>> +    ASSERT(pdx < frametable_pdx_end); >>> + >>> +    return frame_table + pdx - frametable_base_pdx; >>> +} >> This should go in xen/arch/arm/include/asm/mpu/mm.h. Then you don't >> need ifdef >>> +#else >>>   /* Convert between Xen-heap virtual addresses and page-info >>> structures. */ >>>   static inline struct page_info *virt_to_page(const void *v) >>>   { >>> @@ -354,6 +367,7 @@ static inline struct page_info >>> *virt_to_page(const void *v) >>>       pdx += mfn_to_pdx(directmap_mfn_start); >>>       return frame_table + pdx - frametable_base_pdx; >>>   } >> Consequently, this should be in xen/arch/arm/include/asm/mmu/mm.h > > The reason why I don't put virt_to_page()/page_to_virt() in specific > header is that we are using some helpers, which are defined just > a few lines before, like mfn_to_virt(), etc. > If you are moving mfn_to_virt() to specific header too, that will > result in a lot dulplication. > >>> +#endif >>> >>>   static inline void *page_to_virt(const struct page_info *pg) >>>   { >>> diff --git a/xen/arch/arm/include/asm/mpu/mm.h >>> b/xen/arch/arm/include/asm/mpu/mm.h >>> index e26bd4f975..98f6df65b8 100644 >>> --- a/xen/arch/arm/include/asm/mpu/mm.h >>> +++ b/xen/arch/arm/include/asm/mpu/mm.h >>> @@ -2,6 +2,9 @@ >>>   #ifndef __ARCH_ARM_MM_MPU__ >>>   #define __ARCH_ARM_MM_MPU__ >>> >>> +extern struct page_info *frame_table; >> If you define frame_table in xen/arch/arm/include/asm/mm.h , then you >> don't need the above declaration. > > It is a variable only in MPU. In MMU, it is a fixed value. > "#define frame_table ((struct page_info *)FRAMETABLE_VIRT_START)" > >>> +extern unsigned long frametable_pdx_end; >> Also you don't need extern as this is only used by xen/arch/arm/mpu/mm.c. > > sure. > >>> + >>>   extern int xen_mpumap_update(paddr_t base, paddr_t limit, unsigned >>> int flags); >> >> You don't need extern here as it should be used only in >> xen/arch/arm/mpu/mm.c >> >> Currently, I see the following in xen/arch/arm/mm.c, >> >> int map_pages_to_xen(unsigned long virt, >>                       mfn_t mfn, >>                       unsigned long nr_mfns, >>                       unsigned int flags) >> { >> #ifndef CONFIG_HAS_MPU >>      return xen_pt_update(virt, mfn, nr_mfns, flags); >> #else >>      return xen_mpumap_update(mfn_to_maddr(mfn), >>                               mfn_to_maddr(mfn_add(mfn, nr_mfns)), You are ignoring 'virt' here. Shouldn't you at least check that 'virt == mfn_to_maddr(mfn)'? >> flags); >> #endif >> } >> >> int destroy_xen_mappings(unsigned long s, unsigned long e) >> { >>      ASSERT(IS_ALIGNED(s, PAGE_SIZE)); >>      ASSERT(IS_ALIGNED(e, PAGE_SIZE)); >>      ASSERT(s <= e); >> #ifndef CONFIG_HAS_MPU >>      return xen_pt_update(s, INVALID_MFN, (e - s) >> PAGE_SHIFT, 0); >> #else >>      return xen_mpumap_update(virt_to_maddr((void *)s), >>                               virt_to_maddr((void *)e), 0); >> #endif >> } >> >> int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int >> flags) >> { >>      ASSERT(IS_ALIGNED(s, PAGE_SIZE)); >>      ASSERT(IS_ALIGNED(e, PAGE_SIZE)); >>      ASSERT(s <= e); >> #ifndef CONFIG_HAS_MPU >>      return xen_pt_update(s, INVALID_MFN, (e - s) >> PAGE_SHIFT, flags); >> #else >>      return xen_mpumap_update(virt_to_maddr((void *)s), >>                               virt_to_maddr((void *)e), flags); >> #endif >> } >> >> It would be better to have 2 implementations for map_pages_to_xen(), >> destroy_xen_mappings() and modify_xen_mappings() in >> xen/arch/arm/mpu/mm.c and xen/arch/arm/mmu/mm.c. >> > > I prefer them staying in the common file, using #ifdef to go to the > different path. I don't like the #ifdef solution in this situation. You are only doing it for the benefits of the ASSERT(). But they don't seem to have any value for xen_mpumap_update() (you are still passing an address rather than a frame). > Since if not and when anyone wants to update map_pages_to_xen(), > destroy_xen_mappings() and modify_xen_mappings() in the future, it is > possible for them to leave changes in only one file. The helpers are just wrappers. I doubt they will change in the future. So I think it would be OK to duplicate. The alternative would to have a common prototype for xen_pt_update() and xen_mpumap_update() and avoid any #ifdery. That said, this is not my preference at least if they are not static inline. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Jul 03 09:35:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Jul 2023 09:35:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558052.871835 (Exim 4.92) (envelope-from ) id 1qGFxP-0007Wt-Ra; Mon, 03 Jul 2023 09:34:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558052.871835; Mon, 03 Jul 2023 09:34:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGFxP-0007Wm-Oq; Mon, 03 Jul 2023 09:34:55 +0000 Received: by outflank-mailman (input) for mailman id 558052; Mon, 03 Jul 2023 09:34:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGFxP-0007Wa-2D; Mon, 03 Jul 2023 09:34:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGFxO-0002Vb-Vy; Mon, 03 Jul 2023 09:34:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGFxO-00057x-IP; Mon, 03 Jul 2023 09:34:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qGFxO-0004cW-Ht; Mon, 03 Jul 2023 09:34:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=PQRB39JTuq/xZRteyC9BizfwWn9FErfVxc3N5VNxU9w=; b=F5CJNPmtjx7Es96Vu2J9x6LsPN vzT3lTtwHhg2VVpqlzFw/Q8qOVWi1Px17WqIdQNNq18HMqiULo/NStQRHM/ByT73xIPI/lA/1ZyWx xAApEuZ6TF8y32ikudWKmf+3LFE40zhNu4Py/X5umKH1WsRDWT5CJQ9aqvN673bGtC8E=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 181683: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-freebsd10-i386:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-livepatch:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-i386-libvirt:xen-install:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=f51e5d8eae8ece77a949571f39ee49904f3129aa X-Osstest-Versions-That: xen=f51e5d8eae8ece77a949571f39ee49904f3129aa From: osstest service owner Date: Mon, 03 Jul 2023 09:34:54 +0000 flight 181683 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/181683/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-freebsd10-i386 7 xen-install fail in 181678 pass in 181683 test-amd64-i386-livepatch 7 xen-install fail in 181678 pass in 181683 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 181678 Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt 7 xen-install fail in 181678 like 181665 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 181678 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 181678 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 181678 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 181678 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 181678 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 181678 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 181678 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 181678 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 181678 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 181678 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 181678 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 181678 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen f51e5d8eae8ece77a949571f39ee49904f3129aa baseline version: xen f51e5d8eae8ece77a949571f39ee49904f3129aa Last test of basis 181683 2023-07-03 01:52:04 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon Jul 03 11:12:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Jul 2023 11:12:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558059.871846 (Exim 4.92) (envelope-from ) id 1qGHTQ-0000p0-Np; Mon, 03 Jul 2023 11:12:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558059.871846; Mon, 03 Jul 2023 11:12:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGHTQ-0000ot-KS; Mon, 03 Jul 2023 11:12:04 +0000 Received: by outflank-mailman (input) for mailman id 558059; Mon, 03 Jul 2023 11:12:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGHTQ-0000on-6H for xen-devel@lists.xenproject.org; Mon, 03 Jul 2023 11:12:04 +0000 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [2a00:1450:4864:20::12d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6f521574-1992-11ee-b237-6b7b168915f2; Mon, 03 Jul 2023 13:12:02 +0200 (CEST) Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-4f122ff663eso6605566e87.2 for ; Mon, 03 Jul 2023 04:12:01 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f521574-1992-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1688382721; x=1690974721; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=kYzErPWsWB3rFD0aCATtIB3A7HZS3HS2AIf3vRIPPHU=; b=YaHrG+9poWqIVAbsOQlNpvzDzimTGVOf3LGw9wMZsHMJavZVUCfu9hghGvCJLCDsQi SMMEVo5i/cuKgiWRz0fP5VYkr+4GDmQWXEkGPoOk/bGa+w+RWUxHsErog7AymnyRG+Tc cj/ktu6+Mw5UFCyZyX3eypeMEIGPRj7H9NjX8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688382721; x=1690974721; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kYzErPWsWB3rFD0aCATtIB3A7HZS3HS2AIf3vRIPPHU=; b=fVyPmAhh8Zzj2+pMth28pfFIuQgYkHf1CC9eKetEKShgBtMjpWePge3JojDubxOlMM ub2NbV1JgXM45pAv5eLdLY6ZE3ZMkgzQKsDbu4cMhFtyHJBaL4qsD6GWzjoGpoHmEFrh tMltOoj3ILgCkoWiYhrhnH2qmeb3AmPO/QAgKDtb2n8H9AQCJv1f9kIdsEViNLEKII/8 dwy1LsdoEZkJAUea1QaXD87yKdn9AZsQuZdkez6QFdGsPJWRbrD/aX0MsjQx2bhJY/9f LL6JAIIWkoEOxECsNuEailJB14+txspZ/XwFlexkFpOQ6MPyafXG+ggrt+VGYToM33fv 3S3A== X-Gm-Message-State: ABy/qLbipsktl8iQHb9hW/UZB3yyvmNRWkFgcZsfTs5FQawpj6LOqj/o veWiZ1jSSX6cOjMPHfBsgfvNvePYsABGSA+WzDxexA== X-Google-Smtp-Source: APBJJlFnlgcjfesbo8EDfakDCEAhVckvXZTelqyppGLrbNvWACDOC5sxpfqvTIfIPpi+leRliRuZTJehLFbIZ3OEJQ4= X-Received: by 2002:a05:6512:693:b0:4f8:7513:8cb0 with SMTP id t19-20020a056512069300b004f875138cb0mr7147082lfe.2.1688382721362; Mon, 03 Jul 2023 04:12:01 -0700 (PDT) MIME-Version: 1.0 References: <20230630113756.672607-1-george.dunlap@cloud.com> <84197474-9ea0-d42a-b591-13821325cf89@xen.org> In-Reply-To: <84197474-9ea0-d42a-b591-13821325cf89@xen.org> From: George Dunlap Date: Mon, 3 Jul 2023 12:11:50 +0100 Message-ID: Subject: Re: [PATCH 1/2] credit: Limit load balancing to once per millisecond To: Julien Grall Cc: xen-devel@lists.xenproject.org, Dario Faggioli , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu Content-Type: multipart/alternative; boundary="0000000000005a240605ff933c7d" --0000000000005a240605ff933c7d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Jun 30, 2023 at 6:49=E2=80=AFPM Julien Grall wrote= : > Hi, > > The subject stay "1/2" but I don't see any "2/2" nor cover letter. Where > can I find the rest of the series? > I didn't make a cover letter, but the mail archive seems to have both messages: https://lists.xenproject.org/archives/html/xen-devel/2023-06/msg02298.html -George --0000000000005a240605ff933c7d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Fri, Jun 30, 2023 at 6:49=E2=80=AF= PM Julien Grall <julien@xen.org>= ; wrote:
Hi,

The subject stay "1/2" but I don't see any "2/2" no= r cover letter. Where
can I find the rest of the series?

I di= dn't make a cover letter, but the mail archive seems to have both messa= ges:

=C2=A0
= =C2=A0-George
--0000000000005a240605ff933c7d-- From xen-devel-bounces@lists.xenproject.org Mon Jul 03 11:40:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Jul 2023 11:40:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558063.871856 (Exim 4.92) (envelope-from ) id 1qGHuU-0003eV-Uc; Mon, 03 Jul 2023 11:40:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558063.871856; Mon, 03 Jul 2023 11:40:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGHuU-0003dn-Qn; Mon, 03 Jul 2023 11:40:02 +0000 Received: by outflank-mailman (input) for mailman id 558063; Mon, 03 Jul 2023 11:40:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGHuT-0003Ml-Jz for xen-devel@lists.xenproject.org; Mon, 03 Jul 2023 11:40:01 +0000 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [2a00:1450:4864:20::133]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 56d65f0b-1996-11ee-8611-37d641c3527e; Mon, 03 Jul 2023 13:39:58 +0200 (CEST) Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-4f95bf5c493so6460803e87.3 for ; Mon, 03 Jul 2023 04:39:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 56d65f0b-1996-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1688384398; x=1690976398; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=TaTthgEGqQq8CQcmAUHWGWYwkOxiznWgrpiEPOH7chE=; b=EhDDhJOBpdxVKCGdk4YRvkujlGjbvTUd/WpQk0gmbQlBRDCWp4Pr0Z5bOrOUvkEZa0 UwwMFf2mrWpjGIu/YIJwAeo3g/zRFqY9sXaNewK+GVhczVInKU9ZH2SKcRDyyR94w0qL I4FYUt2jbrI/20eGzaAl9x6P643MqoYRV6Vmg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688384398; x=1690976398; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TaTthgEGqQq8CQcmAUHWGWYwkOxiznWgrpiEPOH7chE=; b=NLOM+pUKYgYwMYTG/HKLjPi+74dX1M3LfTCYVfHgzpBu9ci7c+wmu6a4KxMoVnMeie mHR6lvyrKXSyFBmF3OXfZN38lOAV7Ft2JDukBMHiZ9+DTcJ3u6jmQPgpwLmiZa0dwY2W RCLxg018r1pry4w8K9FN62UNJYzGv6movYcCO7unvCycA/3KTOc99moqvDpy0Fg8txZs s3KB7ihfm2Q5nUSaBp3eFGRNrtUF5PK2SXxbzwstYtPTtJYPk++InA4vNOonBm36i5PM Tf5tjQfwvvnBxwUgOvx7aDJhdKOyMa8gqOc7m3VlKxIV30EpKasO4bFz9Mgplmh4bhei PeWQ== X-Gm-Message-State: ABy/qLZsVdFcNT0yzXtf5h6Ie0TqbitV4lsEaAW4hpE4os+FRLRgPBCX yyMaU19GrNtNKjqOqaxKt2uLz9VmuRj5OSh/pCMiCw== X-Google-Smtp-Source: APBJJlEizCxNim1c+KNIlGWUnM/Ni6hYyaMt0ttcO19uFhl3/fFEiKYrKwDwm3Xsa9B7PZY+L1qyuWg6OSr9zxUcJKo= X-Received: by 2002:a05:6512:3612:b0:4f8:70f8:d424 with SMTP id f18-20020a056512361200b004f870f8d424mr5795647lfs.65.1688384398270; Mon, 03 Jul 2023 04:39:58 -0700 (PDT) MIME-Version: 1.0 References: <20230630113756.672607-1-george.dunlap@cloud.com> <42d6cf5e-03ab-a55b-a4d5-54bd063f793d@xen.org> In-Reply-To: <42d6cf5e-03ab-a55b-a4d5-54bd063f793d@xen.org> From: George Dunlap Date: Mon, 3 Jul 2023 12:39:47 +0100 Message-ID: Subject: Re: [PATCH 1/2] credit: Limit load balancing to once per millisecond To: Julien Grall Cc: xen-devel@lists.xenproject.org, Dario Faggioli , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu Content-Type: multipart/alternative; boundary="0000000000004db69f05ff93a0c7" --0000000000004db69f05ff93a0c7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Jun 30, 2023 at 6:48=E2=80=AFPM Julien Grall wrote= : > Hi George, > > On 30/06/2023 12:37, George Dunlap wrote: > > The credit scheduler tries as hard as it can to ensure that it always > > runs scheduling units with positive credit (PRI_TS_UNDER) before > > running those with negative credit (PRI_TS_OVER). If the next > > runnable scheduling unit is of priority OVER, it will always run the > > load balancer, which will scour the system looking for another > > scheduling unit of the UNDER priority. > > > > Unfortunately, as the number of cores on a system has grown, the cost > > of the work-stealing algorithm has dramatically increased; a recent > > trace on a system with 128 cores showed this taking over 50 > > microseconds. > > > > Add a parameter, load_balance_ratelimit, to limit the frequency of > > load balance operations on a given pcpu. Default this to 1 > > millisecond. > > > > Invert the load balancing conditional to make it more clear, and line > > up more closely with the comment above it. > > > > Overall it might be cleaner to have the last_load_balance checking > > happen inside csched_load_balance(), but that would require either > > passing both now and spc into the function, or looking them up again; > > both of which seemed to be worse than simply checking and setting the > > values before calling it. > > > > Without this patch, on a system with a vcpu:pcpu ratio of 2:1, running > > Windows guests (which will end up calling YIELD during spinlock > > contention), this patch increased performance significantly. > > I don't understand this sentence. Did you intende to write > > "Without this patch, ..., the performance are significantly worse"? > Hmm, yes this was bad editing. The first clause was written when I was expecting to include actual numbers; but when I looked at the internal numbers I had available, they weren't easy to summarize. The revised sentence should have simply been: "On a system with a vcpu:pcpu ratio of 2:1, running Windows guests (which will end up calling YIELD during spinlock contention), this patch increased performance significantly." > > --- a/docs/misc/xen-command-line.pandoc > > +++ b/docs/misc/xen-command-line.pandoc > > @@ -1856,6 +1856,12 @@ By default, Xen will use the INVPCID instruction > for TLB management if > > it is available. This option can be used to cause Xen to fall back t= o > > older mechanisms, which are generally slower. > > > > +### load-balance-ratelimit > > +> `=3D ` > > + > > +The minimum interval between load balancing events on a given pcpu. > > +At the moment only credit honors this parameter. > > I would suggest to mention the default value. So a reader don't have to > look up in the code to find out. > > Also, AFAICT, there is max value. I would mention it here too. > Ack > > +/* > > + * Minimum delay, in microseconds, between load balance operations. > > + * This prevents spending too much time doing load balancing, > particularly > > + * when the system has a high number of YIELDs due to spinlock priorit= y > inversion. > > + */ > > +static unsigned int __read_mostly load_balance_ratelimit_us =3D > CSCHED_DEFAULT_LOAD_BALANCE_RATELIMIT_US; > > AFAICT, load_balance_ratelimit_us is not updated after boot. So > shouldn't the attribute be __ro_after_init? > Ack > +#define XEN_SYSCTL_CSCHED_LB_RATE_MAX_US (1000000) > > + uint32_t load_balance_ratelimit_us; > > Shouldn't this change bump the sysctl interface version? > Er, yes. v2 on its way. -George --0000000000004db69f05ff93a0c7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Fri, Jun 30, 2023 at 6:48=E2=80=AF= PM Julien Grall <jul= ien@xen.org> wrote:
Hi George,

On 30/06/2023 12:37, George Dunlap wrote:
> The credit scheduler tries as hard as it can to ensure that it always<= br> > runs scheduling units with positive credit (PRI_TS_UNDER) before
> running those with negative credit (PRI_TS_OVER).=C2=A0 If the next > runnable scheduling unit is of priority OVER, it will always run the > load balancer, which will scour the system looking for another
> scheduling unit of the UNDER priority.
>
> Unfortunately, as the number of cores on a system has grown, the cost<= br> > of the work-stealing algorithm has dramatically increased; a recent > trace on a system with 128 cores showed this taking over 50
> microseconds.
>
> Add a parameter, load_balance_ratelimit, to limit the frequency of
> load balance operations on a given pcpu.=C2=A0 Default this to 1
> millisecond.
>
> Invert the load balancing conditional to make it more clear, and line<= br> > up more closely with the comment above it.
>
> Overall it might be cleaner to have the last_load_balance checking
> happen inside csched_load_balance(), but that would require either
> passing both now and spc into the function, or looking them up again;<= br> > both of which seemed to be worse than simply checking and setting the<= br> > values before calling it.
>
> Without this patch, on a system with a vcpu:pcpu ratio of 2:1, running=
> Windows guests (which will end up calling YIELD during spinlock
> contention), this patch increased performance significantly.

I don't understand this sentence. Did you intende to write

"Without this patch, ..., the performance are significantly worse"= ;?

Hmm, yes this was bad editing.=C2=A0= The first clause was written when I was expecting to include actual number= s; but when I looked at the internal numbers I had available, they weren= 9;t easy to summarize.=C2=A0 The revised sentence should have simply been:<= /div>

"On a system with a vcpu:pcpu ratio of 2:1, r= unning Windows guests (which will end up calling YIELD during spinlock cont= ention), this patch increased performance significantly."
=C2=A0
> --- a/docs/misc/xen-command-line.pandoc
> +++ b/docs/misc/xen-command-line.pandoc
> @@ -1856,6 +1856,12 @@ By default, Xen will use the INVPCID instructio= n for TLB management if
>=C2=A0 =C2=A0it is available.=C2=A0 This option can be used to cause Xe= n to fall back to
>=C2=A0 =C2=A0older mechanisms, which are generally slower.
>=C2=A0 =C2=A0
> +### load-balance-ratelimit
> +> `=3D <integer>`
> +
> +The minimum interval between load balancing events on a given pcpu. > +At the moment only credit honors this parameter.

I would suggest to mention the default value. So a reader don't have to=
look up in the code to find out.

Also, AFAICT, there is max value. I would mention it here too.

Ack
=C2=A0
> +/*
> + * Minimum delay, in microseconds, between load balance operations. > + * This prevents spending too much time doing load balancing, particu= larly
> + * when the system has a high number of YIELDs due to spinlock priori= ty inversion.
> + */
> +static unsigned int __read_mostly load_balance_ratelimit_us =3D CSCHE= D_DEFAULT_LOAD_BALANCE_RATELIMIT_US;

AFAICT, load_balance_ratelimit_us is not updated after boot. So
shouldn't the attribute be __ro_after_init?

Ack


> +#define XEN_SYSCTL_CSCHED_LB_RATE_MAX_US (1000000)
> +=C2=A0 =C2=A0 uint32_t load_balance_ratelimit_us;

Shouldn't this change bump the sysctl interface version?

Er, yes.

v2 on its way.

=C2=A0-George
--0000000000004db69f05ff93a0c7-- From xen-devel-bounces@lists.xenproject.org Mon Jul 03 11:40:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Jul 2023 11:40:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558069.871866 (Exim 4.92) (envelope-from ) id 1qGHvB-0004li-9K; Mon, 03 Jul 2023 11:40:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558069.871866; Mon, 03 Jul 2023 11:40:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGHvB-0004lb-6X; Mon, 03 Jul 2023 11:40:45 +0000 Received: by outflank-mailman (input) for mailman id 558069; Mon, 03 Jul 2023 11:40:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGHv9-0003Ml-4t for xen-devel@lists.xenproject.org; Mon, 03 Jul 2023 11:40:43 +0000 Received: from sender3-of-o59.zoho.com (sender3-of-o59.zoho.com [136.143.184.59]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6f5ad728-1996-11ee-8611-37d641c3527e; Mon, 03 Jul 2023 13:40:41 +0200 (CEST) Received: from [10.10.1.94] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1688384419951877.2414136011109; Mon, 3 Jul 2023 04:40:19 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f5ad728-1996-11ee-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1688384421; cv=none; d=zohomail.com; s=zohoarc; b=cFwMk09dzT0vneG+8ZDsuOP5KlklzW8WBklDCPI9LDe9pmEO0rnzSYoVc898fazVnVeZ+CzJpFLPGg7e0dTKhKkEUTjjYRWesITp1lr+kHQzEQXbx+WHJVYrcESiPJMZJgHDglkxMRXHbx6+c+yeZyG8TTeOdT2OIPN1ftLKYaI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1688384421; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=DTgl9jwz2fepBYFxfxTiktRfHIC/YIshbjxQzz/ZFwI=; b=W9bHqGrTmPXFERq5RL7GA50MY/wWilHzQadzyqos5hpAeoJKivzzP0pOMrpyKOirvqUqRInEXRd5rEd8p9x64WFy2hrDvZOybIHzuoijC7mU7s2LpPz0I9Ce+mV0+gbTqpbNyRTPwS42GEuCPy9Prnjqx9EqfJ6T0U3EJ4YDTYI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1688384421; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=DTgl9jwz2fepBYFxfxTiktRfHIC/YIshbjxQzz/ZFwI=; b=c/pyy6Jry6KoSOCX2t4w/VsxJRTT5+RPvTt76HB56mg3QyfCCX8Z+ClqJXcBvjuq 2LPwEnA0g1askOAiNLAyNYqKOMnzeGR2hsOUeKiHxcB/NxszM/azFAUUpZ1VAJ+MUgp XwibBRYpTmEeNJk6IZwl8NiJe1TZcXk7t02yQ/G8= Message-ID: <0c113f33-4410-aa75-84b7-c3ca860688f9@apertussolutions.com> Date: Mon, 3 Jul 2023 07:40:17 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [RFC PATCH] xen/arm: Rebranding dom0less feature Content-Language: en-US To: Luca Fancellu , Andrew Cooper Cc: Xen-devel , Wei Chen , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Henry Wang , Community Manager , Doug Goldstein , Bertrand Marquis , Volodymyr Babchuk , Anthony PERARD , Christopher Clark References: <20230630091210.3742121-1-luca.fancellu@arm.com> <6060dd00-5d9c-3804-4b9d-154b9b9dca49@citrix.com> <31FE51E0-0336-4756-8B30-6FE77DE10932@arm.com> From: "Daniel P. Smith" In-Reply-To: <31FE51E0-0336-4756-8B30-6FE77DE10932@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 7/1/23 11:13, Luca Fancellu wrote: > > >> On 1 Jul 2023, at 08:53, Andrew Cooper wrote: >> >> On 30/06/2023 10:12 am, Luca Fancellu wrote: >>> The "dom0less" feature was intended to be the feature where a domU >>> domain could be launched without the control domain (Dom0) >>> intervention, however the name seems to suggest that Dom0 cannot >>> be part of the configuration, while instead it's a possible use case. >>> >>> To avoid that, rename the "dom0less" configuration with the name >>> "hyperlaunch", that is less misleading. >>> >>> Signed-off-by: Luca Fancellu >>> --- >>> This is an RFC to get the feeling of the community about the name >>> change, for now it's everything in one patch just to see how it >>> will look like, if there is interest on proceeding into it, I can >>> split in more commit. >> >> Have you discussed this with Dan and Chris at all? You haven't even >> CC'd them. > > No, this rename idea started from a chat during the summit, anyway Julien > promptly add them to the CC, because I forgot. No worries and thank you for considering and taking the time to do this RFC. It is greatly appreciated that there is a strong willingness to have dom0less and hyperlaunch merged. >> >> While there is a lot of end-goal in common between the dom0less and >> hyperlaunch, and that the name dom0less is deeply misleading, >> hyperlaunch is specifically not this. > > Yes Hyperlaunch is more than this, however as I said, with this RFC I would like > to ear opinions, @Daniel @Christopher could it be a proper name for the dom0less > feature? As Andy has alluded, hyperlaunch is meant to provide a flexible means to handle domain construction at boot to meet a wide range of possible use cases. One of those use cases is dom0less, so yes, ultimately what dom0less does today will be achievable under hyperlaunch. Our intended approach to align the two implementations is one that is meant to be minimally disruptive, since dom0less is considered a supported (SUPPORT.md) capability. As mentioned, we are greatly appreciative to the openness to adopt the name, but a big concern I personally have is the confusion it could cause a general user. A blanket rename would end up with two documents in the docs tree that provide two different explanations of hyperlaunch and two different device tree definitions. So I think a more measured approach should be considered here. > If this patch makes things more difficult for the Hyperlunch serie, I’m ok to drop it, > my only aim was just to find a less misleading name for the feature. What I would like to suggest as a good first step would be an update to the dom0less document. Provide a note at the beginning that points to the hyperlaunch design doc as a more general approach that will eventually subsume dom0less. This would provide a gentler transition for exist users of dom0less. If it is not too much, I would also ask, please have a look at the design for boot modules in the series Christopher just posted. The design pulls from the work done by dom0less and expanded upon it. I major step into merging the two capabilities will be to have a common set of structures. Once those are in place, we can move to a common device tree representation, and at that point we would be fairly close, if not at the point of a formal merger of between the two. Thank you and please let me know what you think! v/r, dps > Cheers, > Luca > >> >> ~Andrew > From xen-devel-bounces@lists.xenproject.org Mon Jul 03 11:50:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Jul 2023 11:50:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558073.871876 (Exim 4.92) (envelope-from ) id 1qGI49-0005Tc-4Z; Mon, 03 Jul 2023 11:50:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558073.871876; Mon, 03 Jul 2023 11:50:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGI49-0005TV-0x; Mon, 03 Jul 2023 11:50:01 +0000 Received: by outflank-mailman (input) for mailman id 558073; Mon, 03 Jul 2023 11:49:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGI47-0005TP-Hd for xen-devel@lists.xenproject.org; Mon, 03 Jul 2023 11:49:59 +0000 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [2a00:1450:4864:20::229]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bb79e598-1997-11ee-8611-37d641c3527e; Mon, 03 Jul 2023 13:49:57 +0200 (CEST) Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2b6994a8ce3so63601671fa.1 for ; Mon, 03 Jul 2023 04:49:57 -0700 (PDT) Received: from [192.168.201.189] ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id v10-20020a2e7a0a000000b002b6d87ee4a4sm2001316ljc.38.2023.07.03.04.49.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 04:49:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bb79e598-1997-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688384996; x=1690976996; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=Ho534hFMM5oGf4sAHPgs8xtfIsDaUKrevbKZ0uWK43g=; b=UEe15vAcFKBoEhSxZkZN65TRYW2dI2IQ6imQ4nXqLMCmJ+++B1mWk0VpkiH+TiI1nI u/sn+iVTJAy/oUXCutlZhIH+CeIYQYoEE+jef4CUElJ1cP02PwouNO8F2TVT1S5SealS eq+eWRA0S2myzH2w1UdjSrKnxoXeTR7aSLvI/FvTo6LMTkD2NbOUOx8FLLBiF+NMOAP3 NOzkx9Mxtqwvbviv9Pc7lkJ/yOxV1Ve13VAILJeKQjBnYD7Im2I5Il3QygSIv8elj6PP HEO6IP/KVsKUaByq4oBo6Ir5deEsyta6oDZRL0I6djxgiYvQXaFG4scmZiaCjtkSFSSf 7Dlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688384996; x=1690976996; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Ho534hFMM5oGf4sAHPgs8xtfIsDaUKrevbKZ0uWK43g=; b=FE7Cbh2LR2pmocBEKLR/xRBXoN7DJvY1rW7s+LYy046mkKFQr//C8vj4pvgMvK2AbI diEkMDsxe1vlSb4gpP4kzugxm2dDh5t6AEueHVLf1IReXzkvl59A5k/6shRgaNLv49kR 0435xnA2rkE6LRXnsVc407TDIJ2tcghhwsY6LtRRHIIdPxVZhFnJ4WZOb/f/9w749uWM W8iZcTgwSxJMgwTUqa4yoIxVWocbFAk1NIVobqpj8aAA5yGzjyUcUU6Du65YlN0cj+Ab MjQNyMCW7oH+WHhVAOcjvbEPu4ntnz4ONDNSdWpGGxgFYdO0/UR+hLzTVOYCO5gL+j+z dIpA== X-Gm-Message-State: ABy/qLbJq2Co4Jvq/0b7MDmUZZDqRAcAztU43H+unAjCTQO86mjJ0zjL B0vOL/jgz1HeAy6BXM9oclfF7bkW5xUHLw== X-Google-Smtp-Source: APBJJlGm+Ls1vUP8SW9A3kvABZ7pCJi93/IHyZKlPrRodZvYdWTkfLT5emxAeboF/gjBZiyye6ooSw== X-Received: by 2002:a2e:b60d:0:b0:2b6:c4f3:de with SMTP id r13-20020a2eb60d000000b002b6c4f300demr6549845ljn.24.1688384996085; Mon, 03 Jul 2023 04:49:56 -0700 (PDT) Message-ID: <422f0fbfdb444feb2c1f190ee6e45f7a44c7b4f3.camel@gmail.com> Subject: Re: [PATCH v2 0/6] xen/riscv: introduce identity mapping From: Oleksii To: xen-devel@lists.xenproject.org, Bob Eshleman , Alistair Francis Cc: Jan Beulich , Andrew Cooper , Connor Davis Date: Mon, 03 Jul 2023 14:49:55 +0300 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.3 (3.48.3-1.fc38) MIME-Version: 1.0 Hello Bobby and Alistair, Some patches of the current patch series were merged, but some still require your Ack-by/Reviewed-by. Could you please look at the following patches: 1. [PATCH v2 3/6] xen/riscv: introduce function for physical offset calculation 2. [PATCH v2 4/6] xen/riscv: introduce identity mapping Thank you so much for your attention and participation. ~ Oleksii On Mon, 2023-06-19 at 16:34 +0300, Oleksii Kurochko wrote: > The patch series introduces things necessary to implement identity > mapping: > =C2=A0 1. Make identity mapping for the entire Xen. > =C2=A0 2. Enable MMU. > =C2=A0 3. Jump to the virtual address world > =C2=A0 4. Remove identity mapping. >=20 > Also current patch series introduces the calculation of physical > offset before > MMU is enabled as access to physical offset will be calculated wrong > after > MMU will be enabled because access to phys_off variable is PC- > relative and > in the case when linker address !=3D load address, it will cause MMU > fault. >=20 > One more thing that was done is: > =C2=A0 * Added SPDX tags. > =C2=A0 * move extern of cpu0_boot_stack to a header. >=20 > The reason for this patch series can be found here: > https://lore.kernel.org/xen-devel/4e336121-fc0c-b007-bf7b-430352563d55@ci= trix.com/ >=20 > --- > Changes in V2: > =C2=A0- update the patch series message. > =C2=A0- drop patches from the previous version of the patch series: > =C2=A0=C2=A0 * xen/riscv: add __ASSEMBLY__ guards". ( merged ) > =C2=A0=C2=A0 * xen/riscv: make sure that identity mapping isn't bigger th= en > page size > =C2=A0=C2=A0=C2=A0=C2=A0 ( entire Xen is 1:1 mapped so there is no need f= or the checks > from the patch ) > =C2=A0- add .sbss.* and put it befor .bss* . > =C2=A0- move out reset_stack() to .text section. > =C2=A0- add '__ro_after_init' for phys_offset variable. > =C2=A0- add '__init' for calc_phys_offset(). > =C2=A0- declaring variable phys_off as non static as it will be used in > head.S. > =C2=A0- update definition of PGTBL_INITIAL_COUNT and the comment above. > =C2=A0- code style fixes. > =C2=A0- remove id_addrs array becase entire Xen is mapped. > =C2=A0- reverse condition for cycle inside remove_identity_mapping(). > =C2=A0- fix page table walk in remove_identity_mapping(). > =C2=A0- save hart_id and dtb_addr before call MMU related C functions > =C2=A0- use phys_offset variable instead of doing calcultations to get > phys offset > =C2=A0=C2=A0 in head.S file. ( it can be easily done as entire Xen is 1:1 > mapped now ) > =C2=A0- declare enable_muu() as __init. > =C2=A0- Update SPDX tags. > =C2=A0- Add Review-By/Suggested-By for some patches. > =C2=A0- code style fixes. >=20 > Oleksii Kurochko (6): > =C2=A0 xen/riscv: add .sbss section to .bss > =C2=A0 xen/riscv: introduce reset_stack() function > =C2=A0 xen/riscv: introduce function for physical offset calculation > =C2=A0 xen/riscv: introduce identity mapping > =C2=A0 xen/riscv: add SPDX tags > =C2=A0 xen/riscv: move extern of cpu0_boot_stack to header >=20 > =C2=A0xen/arch/riscv/include/asm/config.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 |=C2=A0=C2=A0 2 + > =C2=A0xen/arch/riscv/include/asm/current.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = |=C2=A0=C2=A0 2 + > =C2=A0xen/arch/riscv/include/asm/early_printk.h |=C2=A0=C2=A0 2 + > =C2=A0xen/arch/riscv/include/asm/mm.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 9 +- > =C2=A0xen/arch/riscv/include/asm/page-bits.h=C2=A0=C2=A0=C2=A0 |=C2=A0=C2= =A0 2 + > =C2=A0xen/arch/riscv/include/asm/page.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 |=C2=A0=C2=A0 2 + > =C2=A0xen/arch/riscv/include/asm/traps.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 |=C2=A0=C2=A0 2 + > =C2=A0xen/arch/riscv/include/asm/types.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 |=C2=A0=C2=A0 2 + > =C2=A0xen/arch/riscv/mm.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 | 104 +++++++++++++------- > -- > =C2=A0xen/arch/riscv/riscv64/head.S=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 46 +++++++++- > =C2=A0xen/arch/riscv/setup.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2= =A0 16 +--- > =C2=A0xen/arch/riscv/xen.lds.S=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 = 2 +- > =C2=A012 files changed, 136 insertions(+), 55 deletions(-) >=20 From xen-devel-bounces@lists.xenproject.org Mon Jul 03 12:14:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Jul 2023 12:14:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558079.871885 (Exim 4.92) (envelope-from ) id 1qGIRi-0000Sa-2Y; Mon, 03 Jul 2023 12:14:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558079.871885; Mon, 03 Jul 2023 12:14:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGIRh-0000ST-W2; Mon, 03 Jul 2023 12:14:21 +0000 Received: by outflank-mailman (input) for mailman id 558079; Mon, 03 Jul 2023 12:14:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGIRh-0000SJ-1r; Mon, 03 Jul 2023 12:14:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGIRg-0006Z8-Tq; Mon, 03 Jul 2023 12:14:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGIRg-0000FL-Ik; Mon, 03 Jul 2023 12:14:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qGIRg-0002JS-IE; Mon, 03 Jul 2023 12:14:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=RJPHCwgsbLjuA4wE7bBtDuxGQsOVwSyjhMFrwVWRFxY=; b=wJNXcacuczMMxkjrK+xmEbu37J bPVJdGz1pAYKJ+l4ePdFAB6JwhWGWWK3DfTYfSu+jWn1RSfSR7t/fqaO172558yl6bBmH+M3wPtGz p7vEp8m2wCskIdCTcoiYAfZp4ZfsSpN3wx7hl6UxE+IFyag+OACicfyVhqJQklQ0RoPo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 181684: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:freebsd-install:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:debian-install:fail:regression linux-linus:test-amd64-amd64-xl-xsm:debian-install:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:debian-install:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit2:debian-install:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:debian-di-install:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:guest-start:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:windows-install:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl:debian-install:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:leak-check/basis/dst_host(19):fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:build-arm64-pvops:kernel-build:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:leak-check/basis(11):fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:heisenbug linux-linus:test-amd64-amd64-libvirt:leak-check/basis(11):fail:heisenbug linux-linus:test-amd64-amd64-libvirt-qcow2:leak-check/basis(11):fail:heisenbug linux-linus:test-amd64-amd64-xl-pvhv2-amd:leak-check/basis(11):fail:heisenbug linux-linus:test-amd64-amd64-xl-credit2:leak-check/basis(11):fail:heisenbug linux-linus:test-amd64-amd64-freebsd11-amd64:leak-check/basis(11):fail:heisenbug linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:heisenbug linux-linus:test-amd64-amd64-xl-multivcpu:debian-install:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:heisenbug linux-linus:test-amd64-amd64-xl:leak-check/basis(11):fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:heisenbug linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:heisenbug linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:heisenbug linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:heisenbug linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-examine:reboot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=a901a3568fd26ca9c4a82d8bc5ed5b3ed844d451 X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Mon, 03 Jul 2023 12:14:20 +0000 flight 181684 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/181684/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-credit1 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-freebsd11-amd64 12 freebsd-install fail REGR. vs. 180278 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-libvirt 12 debian-install fail REGR. vs. 180278 test-amd64-amd64-xl-xsm 12 debian-install fail REGR. vs. 180278 test-amd64-amd64-xl-pvhv2-amd 12 debian-install fail REGR. vs. 180278 test-amd64-amd64-xl-multivcpu 14 guest-start fail REGR. vs. 180278 test-amd64-amd64-xl-credit2 12 debian-install fail REGR. vs. 180278 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 180278 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 180278 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 180278 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 180278 test-amd64-amd64-libvirt-qcow2 12 debian-di-install fail REGR. vs. 180278 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 180278 test-arm64-arm64-xl-vhd 13 guest-start fail REGR. vs. 180278 test-arm64-arm64-libvirt-raw 13 guest-start fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-ws16-amd64 12 windows-install fail REGR. vs. 180278 test-amd64-amd64-examine 8 reboot fail REGR. vs. 180278 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 180278 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 180278 test-amd64-amd64-qemuu-nested-amd 11 leak-check/basis(11) fail in 181682 REGR. vs. 180278 test-amd64-amd64-xl-qemuu-debianhvm-amd64 11 leak-check/basis(11) fail in 181682 REGR. vs. 180278 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 11 leak-check/basis(11) fail in 181682 REGR. vs. 180278 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 11 leak-check/basis(11) fail in 181682 REGR. vs. 180278 test-amd64-amd64-xl 12 debian-install fail in 181682 REGR. vs. 180278 test-amd64-amd64-libvirt-pair 19 leak-check/basis/dst_host(19) fail in 181682 REGR. vs. 180278 test-amd64-amd64-xl-qemut-debianhvm-amd64 12 debian-hvm-install fail in 181682 REGR. vs. 180278 build-arm64-pvops 6 kernel-build fail in 181682 REGR. vs. 180278 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-ws16-amd64 11 leak-check/basis(11) fail in 181682 pass in 181684 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail in 181682 pass in 181684 test-amd64-amd64-libvirt 11 leak-check/basis(11) fail in 181682 pass in 181684 test-amd64-amd64-libvirt-qcow2 11 leak-check/basis(11) fail in 181682 pass in 181684 test-amd64-amd64-xl-pvhv2-amd 11 leak-check/basis(11) fail in 181682 pass in 181684 test-amd64-amd64-xl-credit2 11 leak-check/basis(11) fail in 181682 pass in 181684 test-amd64-amd64-freebsd11-amd64 11 leak-check/basis(11) fail in 181682 pass in 181684 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail in 181682 pass in 181684 test-amd64-amd64-xl-multivcpu 12 debian-install fail in 181682 pass in 181684 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail pass in 181682 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail pass in 181682 test-amd64-amd64-xl 11 leak-check/basis(11) fail pass in 181682 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail pass in 181682 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail pass in 181682 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail pass in 181682 test-amd64-coresched-amd64-xl 8 xen-boot fail pass in 181682 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail pass in 181682 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 180278 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked in 181682 n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked in 181682 n/a test-arm64-arm64-examine 1 build-check(1) blocked in 181682 n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked in 181682 n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked in 181682 n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked in 181682 n/a test-arm64-arm64-xl 1 build-check(1) blocked in 181682 n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked in 181682 n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked in 181682 n/a test-armhf-armhf-xl 8 xen-boot fail like 180278 test-armhf-armhf-xl-vhd 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-raw 8 xen-boot fail like 180278 test-armhf-armhf-xl-arndale 8 xen-boot fail like 180278 test-armhf-armhf-examine 8 reboot fail like 180278 test-armhf-armhf-libvirt 8 xen-boot fail like 180278 test-armhf-armhf-xl-multivcpu 8 xen-boot fail like 180278 test-armhf-armhf-xl-credit2 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail like 180278 test-armhf-armhf-xl-rtds 8 xen-boot fail like 180278 test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: linux a901a3568fd26ca9c4a82d8bc5ed5b3ed844d451 baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 77 days Failing since 180281 2023-04-17 06:24:36 Z 77 days 150 attempts Testing same since 181682 2023-07-02 19:42:58 Z 0 days 2 attempts ------------------------------------------------------------ 3562 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 574059 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Jul 03 13:00:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Jul 2023 13:00:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558085.871897 (Exim 4.92) (envelope-from ) id 1qGJAU-0005mz-Kw; Mon, 03 Jul 2023 13:00:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558085.871897; Mon, 03 Jul 2023 13:00:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGJAU-0005ms-Gd; Mon, 03 Jul 2023 13:00:38 +0000 Received: by outflank-mailman (input) for mailman id 558085; Mon, 03 Jul 2023 13:00:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGJAT-0005ml-Ks for xen-devel@lists.xenproject.org; Mon, 03 Jul 2023 13:00:37 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9997a690-19a1-11ee-8611-37d641c3527e; Mon, 03 Jul 2023 15:00:35 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E3FD2218F3; Mon, 3 Jul 2023 13:00:34 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9A656138FC; Mon, 3 Jul 2023 13:00:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2xVZJHLGomSYCgAAMHmgww (envelope-from ); Mon, 03 Jul 2023 13:00:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9997a690-19a1-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1688389234; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=g/qfo8Cb33qUzg9p/sYx93BIkx/lh9MH46SOSdnmyf8=; b=E0ValWnb8323NYs3nZ1reUyn9xcW6UnT/WjrnwfuddpLUbUcW8umrJK2eBg3GMgbEVZlc5 e7Op8WL+1NzVEDBRQL2foLY3SM64CFvRMXs5yP/7PJD1wYpI7+kCyTD72S180Jsu1OyMFY Lwnv8tdJ/g8zVtBTGNEHkHjIPCjEI1g= From: Juergen Gross To: linux-kernel@vger.kernel.org, x86@kernel.org Cc: Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , xen-devel@lists.xenproject.org Subject: [PATCH] x86/xen: fix secondary processor fpu initialization Date: Mon, 3 Jul 2023 15:00:32 +0200 Message-Id: <20230703130032.22916-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Moving the call of fpu__init_cpu() from cpu_init() to start_secondary() broke Xen PV guests, as those don't call start_secondary() for APs. Fix that by adding the call of fpu__init_cpu() to cpu_bringup(), which is the Xen PV replacement of start_secondary(). Fixes: b81fac906a8f ("x86/fpu: Move FPU initialization into arch_cpu_finalize_init()") Signed-off-by: Juergen Gross --- arch/x86/xen/smp_pv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/xen/smp_pv.c b/arch/x86/xen/smp_pv.c index d5ae5de2daa2..cef78b8c89f4 100644 --- a/arch/x86/xen/smp_pv.c +++ b/arch/x86/xen/smp_pv.c @@ -63,6 +63,7 @@ static void cpu_bringup(void) cr4_init(); cpuhp_ap_sync_alive(); cpu_init(); + fpu__init_cpu(); touch_softlockup_watchdog(); /* PVH runs in ring 0 and allows us to do native syscalls. Yay! */ -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Jul 03 13:42:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Jul 2023 13:42:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558089.871905 (Exim 4.92) (envelope-from ) id 1qGJog-0001vm-NK; Mon, 03 Jul 2023 13:42:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558089.871905; Mon, 03 Jul 2023 13:42:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGJog-0001vf-Kk; Mon, 03 Jul 2023 13:42:10 +0000 Received: by outflank-mailman (input) for mailman id 558089; Mon, 03 Jul 2023 13:42:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGJof-0001vZ-P6 for xen-devel@lists.xenproject.org; Mon, 03 Jul 2023 13:42:09 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 671e4e33-19a7-11ee-b237-6b7b168915f2; Mon, 03 Jul 2023 15:42:08 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 509DB219BE; Mon, 3 Jul 2023 13:42:07 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 35FCC13276; Mon, 3 Jul 2023 13:42:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id sLqlCy/QomR7IwAAMHmgww (envelope-from ); Mon, 03 Jul 2023 13:42:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 671e4e33-19a7-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1688391727; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KDhh5FG/dyHuQMTe3c5cc2HhGzLW1okef93kXWumym4=; b=hShXidb6slpC+iPSdqDppTJh1duohh/9cHaUDsGHAtbzOrTi3XF70ihwC87fd24c+t4uHE X4lry0n6KiOsyghf7vPzmdfGzRAEgbRyR1YS1mzlXz52uzCiz44UrkosNJMVvq/00WMhXr yk5QPUdY0+VM12TKFFGCBNnIWES8VAE= Message-ID: <46d4253c-551e-4d7a-2a60-7ce57594d85b@suse.com> Date: Mon, 3 Jul 2023 15:42:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [linux-linus test] 181682: regressions - FAIL Content-Language: en-US From: Juergen Gross To: osstest service owner , xen-devel@lists.xenproject.org References: <6296a02e-863b-879d-6993-1a828e71fac2@suse.com> In-Reply-To: <6296a02e-863b-879d-6993-1a828e71fac2@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------I5wJgGrsWv0vqWJgEprOeGPF" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------I5wJgGrsWv0vqWJgEprOeGPF Content-Type: multipart/mixed; boundary="------------FSp5redWEW0SrnLwSkM0a3lN"; protected-headers="v1" From: Juergen Gross To: osstest service owner , xen-devel@lists.xenproject.org Message-ID: <46d4253c-551e-4d7a-2a60-7ce57594d85b@suse.com> Subject: Re: [linux-linus test] 181682: regressions - FAIL References: <6296a02e-863b-879d-6993-1a828e71fac2@suse.com> In-Reply-To: <6296a02e-863b-879d-6993-1a828e71fac2@suse.com> --------------FSp5redWEW0SrnLwSkM0a3lN Content-Type: multipart/mixed; boundary="------------7oTm0v08JYx0X0fEtSAsmLeG" --------------7oTm0v08JYx0X0fEtSAsmLeG Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMDcuMjMgMDc6MzUsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IE9uIDAzLjA3LjIz IDA0OjExLCBvc3N0ZXN0IHNlcnZpY2Ugb3duZXIgd3JvdGU6DQo+PiBmbGlnaHQgMTgxNjgy IGxpbnV4LWxpbnVzIHJlYWwgW3JlYWxdDQo+PiBodHRwOi8vbG9ncy50ZXN0LWxhYi54ZW5w cm9qZWN0Lm9yZy9vc3N0ZXN0L2xvZ3MvMTgxNjgyLw0KPj4NCj4+IFJlZ3Jlc3Npb25zIDot KA0KPj4NCj4+IFRlc3RzIHdoaWNoIGRpZCBub3Qgc3VjY2VlZCBhbmQgYXJlIGJsb2NraW5n LA0KPj4gaW5jbHVkaW5nIHRlc3RzIHdoaWNoIGNvdWxkIG5vdCBiZSBydW46DQo+IA0KPiAu Li4NCj4gDQo+PiDCoCB0ZXN0LWFtZDY0LWFtZDY0LXhswqDCoMKgwqDCoMKgwqDCoMKgIDEy IGRlYmlhbi1pbnN0YWxswqDCoMKgwqDCoMKgwqDCoMKgwqAgZmFpbCBSRUdSLiB2cy4gMTgw Mjc4DQo+IA0KPiBFcnJvcnMgZHVyaW5nIGluc3RhbGxhdGlvbiBvZiAuZGViIGZpbGVzLiBX b3JyeWluZyBtZXNzYWdlcyBpbiB0aGUgc2VyaWFsIGxvZw0KPiBhcmU6DQo+IA0KPiBbwqDC oMKgIDIuOTc3MDkxXSBCYWQgRlBVIHN0YXRlIGRldGVjdGVkIGF0IHJlc3RvcmVfZnByZWdz X2Zyb21fZnBzdGF0ZSsweDUyLzB4YzAsIA0KPiByZWluaXRpYWxpemluZyBGUFUgcmVnaXN0 ZXJzLg0KPiANCj4gdHJhcHM6IGRwa2ctZGViWzE0MTNdIHRyYXAgaW52YWxpZCBvcGNvZGUg aXA6N2Y1YzBhMDE2OTNmIHNwOjdmZmUzZGFmNWQ5OCANCj4gZXJyb3I6MCBpbiBsaWJjLTIu Mjguc29bN2Y1YzA5ZWUwMDAwKzE0NzAwMF0NCj4gDQo+IE9sYWYgaGFzIHNlZW4gc2ltaWxh ciBmYWlsdXJlcyBsYXN0IHdlZWssIHNvIHdlIGhhdmUgYSByZXByb2R1Y2VyIGF0IGhhbmQu DQoNClBhdGNoIHNlbnQgdG8gTEtNTDoNCg0KaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGtt bC8yMDIzMDcwMzEzMDAzMi4yMjkxNi0xLWpncm9zc0BzdXNlLmNvbS9ULyN1DQoNCg0KSnVl cmdlbg0K --------------7oTm0v08JYx0X0fEtSAsmLeG Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------7oTm0v08JYx0X0fEtSAsmLeG-- --------------FSp5redWEW0SrnLwSkM0a3lN-- --------------I5wJgGrsWv0vqWJgEprOeGPF Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmSi0C4FAwAAAAAACgkQsN6d1ii/Ey8G Swf/Qi50VAeedSnWe8Aem1e8p8sglU9NGCbZ0nAhUORhs2iH98FFMk/j8jAuF2g7N1mcSfGZHj1P l6U6C4d71AnlV62uorM8iQLzoAdtBfE9ybYENQ0jpkkwqFKO+Jgeq+u+pnCV7ZNpdMT9E5iWp/cu zjK5yI08284CV/eM/0YKQtaHTh6Ipln694/YhDn4iWszLZadgqLPKizhy18KKm8hMd4Ys3qGVFL9 3sZrBokucNPW2JK3OjJNvh7WDcU5WA+zTgITN4hY1oTCwI/0gQIEljhbTIpywJeRbbMsKmc1q+NE KoMpMf/f29QzRHjnzTlMYYi9ez/ORsAZWXuFyMOhtQ== =IWY4 -----END PGP SIGNATURE----- --------------I5wJgGrsWv0vqWJgEprOeGPF-- From xen-devel-bounces@lists.xenproject.org Mon Jul 03 14:06:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Jul 2023 14:06:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558095.871915 (Exim 4.92) (envelope-from ) id 1qGKCB-0004cY-QH; Mon, 03 Jul 2023 14:06:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558095.871915; Mon, 03 Jul 2023 14:06:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGKCB-0004cR-NV; Mon, 03 Jul 2023 14:06:27 +0000 Received: by outflank-mailman (input) for mailman id 558095; Mon, 03 Jul 2023 14:06:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGKC9-0004cH-Pa for xen-devel@lists.xenproject.org; Mon, 03 Jul 2023 14:06:26 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c9480b38-19aa-11ee-8611-37d641c3527e; Mon, 03 Jul 2023 16:06:22 +0200 (CEST) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 Jul 2023 10:06:12 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by SN7PR03MB7208.namprd03.prod.outlook.com (2603:10b6:806:2ef::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Mon, 3 Jul 2023 14:06:08 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::1c83:1877:a68b:8902]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::1c83:1877:a68b:8902%7]) with mapi id 15.20.6544.024; Mon, 3 Jul 2023 14:06:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c9480b38-19aa-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1688393182; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=8SDCemCy0Ha/MMvfjru/0aucOrQNCKVjha9IMn2BbpA=; b=RzacABmE9Hda+9yoJSsER7w1j/CwzqF9lKEv9LlFEBeE2VCBlRLIEyaf 7ZBs+3glUGTnu8bb11LvC7I3m4P4EU2SV+yN3a3WmGTnqBEWKe9K7oU8z M5PZJ71Wk6AEswGqJjRdKqWcPPswDH+8wxh/JuPXSxmcZDOr4D05k9v1x s=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 114302879 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:cD5Rha5Kf08gw8gc2JcTLwxRtPbGchMFZxGqfqrLsTDasY5as4F+v mcfWmmObqvfZzP8eYwnbo2yoUwH6pPVzoBhTFZt+y41Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9lU35ZwehBtC5gZlPa8T5weH/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m7 8NDCW8fNyK4rcGcnqOpDcJcheEnI5y+VG8fkikIITDxK98DGMmGaYOaoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OnEoojumF3Nn9I7RmQe1PmUmVv CTe9nnRCRAGLt2PjzGC9xpAg8eWxH+gANhCS+zQGvhC2EOUmTU0ITcqTkK3qOiGgHy3B8h4A hlBksYphe1onKCxdfHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpQN4sudIyRDcq/ kSUhN6vDjtq2JWKTVqN+7HSqim9UQAXMGsDaCksXQYDpd75r+kblQnTR9xuFKq0iNzdGjzqx T2O6i8kiN0uYdUj0qy6+RXNhWKqr52QFwotvFyJDySi8x9zY5Oja8qw81/H4P1cLYGfCF6co HwDnMvY5+cLZX2QqBGwrCw2NOnBz5643Pf02DaDw7FJG+yRxkOe IronPort-HdrOrdr: A9a23:rRbk3apYQGMCfPzQ3JhrjT8aV5oGeYIsimQD101hICG9Ffbo7f xG/c5rriMc7Qx7ZJhNo6HmBECrewK/yXcN2+Us1MmZLWrbURqTXeRfBOLZqlWOJ8SUzJ846U 4PSchD4G6cNykDsS4piDPYLz70qOPozEjh7d21858mJTsGV0kvhD0JbHfjLnFL X-Talos-CUID: 9a23:c21NsG/KgxvWMowCTPWVv1QrQeF6YCTv913zCRGpGyFCeL6wTVDFrQ== X-Talos-MUID: 9a23:sO4QWgVZ1GO3bwjq/Gfyg247E+5C37+3BEkcrp80spWeEgUlbg== X-IronPort-AV: E=Sophos;i="6.01,178,1684814400"; d="scan'208";a="114302879" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V88kPAH84qXFaYIBwibslUnhFk+B9SYBYlZ/gvWhp9YcQS6WewnbTD7Bq5jrDXLdeAlas2rmisF9j+8n0mo1PV3EfTMgIdRM1rHXBpidn6Tdkyu+lW9Bb82735pJ0J4s/HDVd01Cj/1zUaD5tBdrEoFDERlllPjD5wcLY9RLdOoHiCEjl4RiA5F+x+oG9To1MMqvjCz6eBSz05svD4HsDiYO2BgXvvTmk/a6k7P624t59FXn6EPJuCXEMPUsHmA20T8LDMU8WR0sVgsKGrkZDWIET/gMiN3SPFmyTYne6GYfRa8iSeyxTl2sYePgRW/P752i07Cn6MY8ifWkV3SaEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xDQU3W5cX687L1WQosDpVw5bcXd4QsSkW2708q0Pimg=; b=lrpmT7H8KruKIPzL2qlyXrshbq1dpA0ZP6IIQ1+kOPOHkQIApbz6qh4RxhW9lYxhepo1TnLsaZHLQVlWuulC8SwHLUXQA/6/NeMWvw2lFAYN8on5ofNFNv/aXfRfj47VFxvWeuQEToCHXRFEnPWU/hjlzjUnTWIBx97CZplRwelaJmKNJH2y4yItVF7VRQiSy7rUiBw1LHYmAkxG58VNzuviLkUaRXNcV9VwEPdLx+cDTtn0I43lNlqXs6zTdJ+yTkDlHuDf9VmILeoiZfV2hMabduanxcaXaiPUohG2lorVPtZ1mreMkyIuf6MDG3FJV0NDzEn/WDknNjcqviN8Tw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xDQU3W5cX687L1WQosDpVw5bcXd4QsSkW2708q0Pimg=; b=XEaSSYtGMm0HpUjIrwagRiDPik3Q4UcLpcV9KmlEuProqltjFRyG03pOEHIsCVhIX6hZ/eZvhe/tMC5W3Cw56QE6xXOrFWm7L2njc1KilVoG5kwc040koEMiD9LZH05mf/1kgvnmc/61qYZTn62OgJpskHQp9hMGmVQXGWMjrTs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 3 Jul 2023 16:06:01 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: Re: [PATCH v2] amd: disable C6 after 1000 days on Zen2 Message-ID: References: <20230630131820.29323-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230630131820.29323-1-roger.pau@citrix.com> X-ClientProxiedBy: LO4P123CA0199.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::6) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|SN7PR03MB7208:EE_ X-MS-Office365-Filtering-Correlation-Id: 2a8838a4-32d9-4803-816a-08db7bcea582 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GCQ60Dct4YsxXAEvoTQUe6cBYb5ITGOCD/GCqnFjop5FLc2jbqyaypyna3T/P+EkdOC9qnuTZgU6qFIfpEUdkuibOdCHvHE/ehW34PiWK92i6yYlbGIoSZsYJahq3ZSqoTIVX8/G2RySmIPEWcID8uqeHZsQ21Fha/yB+yxfF3avE/vy2saSTT/vmROUEoF+sfQ0zqklyUNZ9q/3ZsUmg366IcJRIKE6Befhxfa0e2Tqcrh2hIUXGJ+X3GMPElr3WQ+7uW1FdhXc675nNKeVSKZ/o97w5ClL+2VYKkqfz8dx6DHFZ+mHG5xaKMLce2aa6FsVvdNrVRXi7hFnmGh3iP7Om5Y3KgiW181xsWKkNcDQ5Ogz2hkfN76Xybzc/2FJ5zZcdcTSCTNm9DOd+kz8SZQCqKf6tOk9eOtHimrP3AzVB3R/P9+2KjUDrvGCopARsMZ1XWPXCvYbqZtyEoU8Yo0GoieTVVOsLpTOOLHAK+7FeIjeXZDiHBD/G72bOdQPJZbO+7Cm9SadtBe/Cln1PaiB2orzNICMYkRrae0rk5XiLeaVBHmBtvuqCtPOPp/zqTCvmzFTKYPH7kT7pHKfFt2O24L8a2YSRgnqRzHpSP7KcuKWgwpikhLfKxGcHmTu X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(366004)(346002)(39860400002)(376002)(451199021)(6916009)(4326008)(66476007)(66946007)(66556008)(316002)(2906002)(478600001)(85182001)(8936002)(8676002)(5660300002)(41300700001)(9686003)(6512007)(54906003)(86362001)(6666004)(6486002)(38100700002)(6506007)(26005)(186003)(82960400001)(83380400001)(221023011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Sml2ZWRnQUJlKzBqTm8wenJDMVJ1T0R5MXNCK0VxeHRtRm5PVGViQUtNcGc1?= =?utf-8?B?b1o2bGFudXRCb05HUjROazk1N1N6LzIyblZ3K1FOWGNxVStqYTI0T09KY1lp?= =?utf-8?B?Q1RmdjY3aWIzRG1IanlzNnlQQitrSVBUM1FGUUQ4QU5OYWxHMGZlL09jMG1P?= =?utf-8?B?endVMlBIeGpLcFBmTGx1ejZ1dE93S24rcFNEOFhvdUZuRlUwUWdnbXlPWTZS?= =?utf-8?B?NjJodmhNYTI0cG1XeHVlQzhLelRtN0ZrL1Zzcmwza05jdjF4MUJZS3pVeEVw?= =?utf-8?B?SWNIdncrclAwUGN2TkY3S2h6V2NCeWwxS3JvR0NEZFF1Q3IrbjQ1cDNmMlpR?= =?utf-8?B?amZlNlJzUXhlUDVoTThxSGVvalpSN0FhS3FrZU9lVm9wYlgvMlJMaHhzY3dM?= =?utf-8?B?UUlJR2tkK25BbS9tU1pTRUVGeExTRGI4MVZhdzZuZ0lhNlNDdXhRWVlTTlFY?= =?utf-8?B?USsvaXF0c3FIeUx2dkJocnVoUVZvWWx2RTRqL3pqNzlHbWZhVVZsRE4yNzBI?= =?utf-8?B?K29qcjhTQWd4Y3ptWE55U2NKQlArbW0rT2RWUVdoc3hrR1VDL21jMTRnMXpu?= =?utf-8?B?TkQwMXBrK0kxZS9ZSU1yZjZ3Wjl0K3NGQzNwVFpNdEF6OVZTaTJCNVN4UzVw?= =?utf-8?B?cm5nVU5LODdyQmNLU2twU2tLaUY3OFlJclE1enozVFdoSUdlaTZNV091RzQr?= =?utf-8?B?d29ocWZaL2RuTlpyQ25wNTZqZlRYMnVwdGJOYUZ1RURaMFpnenBsSGZWRFpD?= =?utf-8?B?ZWVjbFZmS2lyRjgzQ2FhK1J4bTVEekpIUCtTOGZJTlIxR0UydldQN0NuNnZs?= =?utf-8?B?Q25OWm5ZYVVZZHB3VE94cVVpZ05FMlRNNmRmTkVaeXhFYlhzVU8zN2t3MjhI?= =?utf-8?B?bXhIQzR3R3hlQlBzbTFkZVhtSXpRbzNmNU1oMVRRbmR3MTNWZkJUbHV3bjhy?= =?utf-8?B?N0Q3YWpZZUhGR0F1bVh4VWVpQWRiUGdiUGlSZ2pDRW1NblFSdGJmSG1tZVpt?= =?utf-8?B?VlN1Nkpvdll3RCt0dGZQQU5MWGY2NXNhRTFwWXF5Z1NObTNxNWVrakw3MTVl?= =?utf-8?B?R0tlaC90N2ZXVFg1NFoyTFlxdStMdFNwWTJKUTRRTWFvNEs1ZDl5RGROU1Bw?= =?utf-8?B?ZWVPbG5ZSXd3YXUwR2lrT3Qxb3hTenhTVWp4VjNqQnpwNXlZQ3JvUTFuekQ4?= =?utf-8?B?ZjUrcUxoMGhZNjVnTUY1MU1TYXQzL2dhbzBwVGJzaURGc3pUMGxxekd1UlNG?= =?utf-8?B?eGp3S3hpdmpnZlA3dnNZOWc0Y3dBVk03K3Bsc21OWGdTMXh2WmRHekgxektl?= =?utf-8?B?TVZjS0FqVFY4NndqamFmWlI5ZktPSDBoZFFVRkNuL25vZVcxVlB4MEUwTk93?= =?utf-8?B?YnBtbTNidXRXeDBwMDhvS3ducDNwNUZtNHpUQURzT204ZnQ1aGVJUXVrQUN4?= =?utf-8?B?QS9JUFNoVWUwNkhHRWwrQW41NzhqOEtEK3JpaCtQVCtHNHdnVjE1cDdxN2Fh?= =?utf-8?B?RXU5WU5kWjNkWTZIeVl1RzgwZUJYS2VCVFNXYWFMVzBqVjZaL1JlaU10RDhu?= =?utf-8?B?N0RYRjRKZGlYc2lRbjFIVUN1ZkNhT1NIQVhjTGVENVFiM3lQcEJvTmVNSDA4?= =?utf-8?B?Vlo4MGVOaE9FeTlidDZ2M0gycTB1Nk9wWHNjRkp4ZE9tTmdLelhuR0J0MlJJ?= =?utf-8?B?NWViSytIcnoyMEhFczhoM2NHSXU4SUNHSzhDS3Q4RjZLYWFCcVhHOFZWODFX?= =?utf-8?B?STVIYW90aDMxWi9zNDgzTDM1a3Nqb3hLRkpNM1dlV2Zqb1YwM09sZ2NUNlEw?= =?utf-8?B?Z2Y2QWdqMGNhcFFaMHJWcnpPVkZsdVREQVNzRGxuNGk5ZkNjQWFrTkFSVkRk?= =?utf-8?B?VHFUb2lTclU0ZWVKL0RtbmIrT1U1OVE3MEVTU3lSb2FFd2paY01XbmVFbUhN?= =?utf-8?B?cDk2Y1J1N2J2OEo5aXpjWnVoa2Y2Vk1OYUtRb3FXWXl2YkFweVVIbk9vVXBm?= =?utf-8?B?WFoxNUwxVlNTcFFxcWRDRURrK1ZMbWxHK1VlNXlEZ3ZGcGZRODZuQWlMQ3V5?= =?utf-8?B?WjFHbk5BNzhnenJPamd4VXBVTkE3eHNGRzQ5TVBnTlV0LzJpVUpObjF5Rng0?= =?utf-8?Q?k6W562pjuzNGWXNxT6zJeZxap?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: pK4eYPq9nCZfQS5DaQs71ogg+DGGDHV5CMKDGw9RNScNwxZRFayi2Bx0VA+2Dya8hKUknikQr/DaPBDVNdShdtf0AyskowehgXFF65XXLs5mFV/wI2bO2g60LPa8Zhlqt1dE2njH2lvB4GNqgmvJGJ/bzmfnz+fPw0zIyI8ii0x8iHD3ZnuW/394EOkYfJu7nZvdBekmXeFd7cMW3GKzv6rTYL8DeN2Y2tdYD1ZlXDuU6lU0/qs3DWW8g8sD/glv71UNy3gTDEX5c27NXCTzNFPGsmmg/KgAOfl96wZTtlNon8HWCPxX6qa8agIDn89IpMK586PSUlQufc+wV2HwjmSipJvMzA3PlOM+xgQ4Xsz9UDT3eFTq2bdIlTZA2n0hxax27+CXaxHFPkQLyU5DIIh1e7N7783MWxOSMcooGwtBdBPuzcLHC8OpQjfoseclBt5GQeY5f6fnAnSXiTC6CAplaNsZ8bc2/jDzsv3qLJZQNuHk4oWQAsElW6swgigsmjQC5iLEIVo9f8u67/pEwVcHgZQRhaBibwZCzssFB4fRUJ8EMTrD7X86SX9i7h01vScv3gu1dxZ6ObrYD5eNBXwVoegFk3yLxT/QDMnCUIdlg3lO1BBSZkZ+9xHgJuO67k7Yg7RipJL1nHylwjtfiLxMta0aIy1mdCTecCHB+491jbJWDdv9EzNJtj2a/CaPKeVVFYCKUsLUgqP9BugMkD/gBelVOb0IOLNE+/rloe1uv3efkk9ZOXf1ZUMEHSB36TF/dT3Rvnym4guLdUpUTzSOmmKoqKjGGwaaOozzdskV8dIB0JmJGYR9P2FlsnpVu9KjmFOjxXkGReolK6OZdzO4+IpEalCSkAXUHEzGPfk= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a8838a4-32d9-4803-816a-08db7bcea582 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2023 14:06:07.5256 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CqFPICpDOA5/TVYTg2eq7hR6qyPtyCWdEFBKegZ9Hmbd2I+XBxQqaOHfHvRz5GA+Ii8fpc8pOGVkekQVhOcOQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR03MB7208 On Fri, Jun 30, 2023 at 03:18:20PM +0200, Roger Pau Monne wrote: > As specified on Errata 1474: > > "A core will fail to exit CC6 after about 1044 days after the last > system reset. The time of failure may vary depending on the spread > spectrum and REFCLK frequency." > > Detect when running on AMD Zen2 (family 17h models 30-3fh, 60-6fh or > 70-7fh) and setup a timer to prevent entering C6 after 1000 days of > uptime. Take into account the TSC value at boot in order to account > for any time elapsed before Xen has been booted. Worst case we end > up disabling C6 before strictly necessary, but that would still be > safe, and it's better than not taking the TSC value into account and > hanging. > > Disable C6 by updating the MSR listed in the revision guide, this > avoids applying workarounds in the CPU idle drivers, as the processor > won't be allowed to enter C6 by the hardware itself. > > Print a message once C6 is disabled in order to let the user know. > > Signed-off-by: Roger Pau Monné > --- > The current Revision Guide for Fam17h model 60-6Fh (Lucienne and > Renoir) hasn't been updated to reflect the MSR workaround, but the PPR > for those models lists the MSR and the bits as having the expected > meaning, so I assume it's safe to apply the same workaround there. > > For all accounts this seems to affect all Zen2 models, and hence the > workaround should be the same. Might also affect Hygon, albeit I > think Hygon is strictly limited to Zen1. > --- > Changes since v1: > - Apply the workaround listed by AMD: toggle some MSR bits. > - Do not apply the workaround if virtualized. > - Check for STIBP feature instead of listing specific models. > - Implement the DAYS macro based on SECONDS. > --- > xen/arch/x86/cpu/amd.c | 70 ++++++++++++++++++++++++++++ > xen/arch/x86/include/asm/msr-index.h | 5 ++ > xen/include/xen/time.h | 1 + > 3 files changed, 76 insertions(+) > > diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c > index 0eaef82e5145..bdf45f8387e8 100644 > --- a/xen/arch/x86/cpu/amd.c > +++ b/xen/arch/x86/cpu/amd.c > @@ -51,6 +51,8 @@ bool __read_mostly amd_acpi_c1e_quirk; > bool __ro_after_init amd_legacy_ssbd; > bool __initdata amd_virt_spec_ctrl; > > +static bool __read_mostly c6_disabled; > + > static inline int rdmsr_amd_safe(unsigned int msr, unsigned int *lo, > unsigned int *hi) > { > @@ -905,6 +907,31 @@ void __init detect_zen2_null_seg_behaviour(void) > > } > > +static void cf_check disable_c6(void *arg) > +{ > + uint64_t val; > + > + if (!c6_disabled) { > + printk(XENLOG_WARNING > + "Disabling C6 after 1000 days apparent uptime due to AMD errata 1474\n"); > + c6_disabled = true; > + smp_call_function(disable_c6, NULL, 0); I've realized this is racy with CPU hotplug, so I will need to inhibit CPU hotplug around the call to smp_call_function() in order to prevent CPUs being hotplugged and not seeing c6_disabled while set and also not being set in cpu_online_map when the call to smp_call_function happens. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Jul 03 16:52:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Jul 2023 16:52:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558108.871929 (Exim 4.92) (envelope-from ) id 1qGMmN-0005cN-DO; Mon, 03 Jul 2023 16:51:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558108.871929; Mon, 03 Jul 2023 16:51:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGMmN-0005cG-Ae; Mon, 03 Jul 2023 16:51:59 +0000 Received: by outflank-mailman (input) for mailman id 558108; Mon, 03 Jul 2023 16:51:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGMmM-0005c6-17; Mon, 03 Jul 2023 16:51:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGMmL-0005Sj-PE; Mon, 03 Jul 2023 16:51:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGMmL-0006ZN-H1; Mon, 03 Jul 2023 16:51:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qGMmL-0004Ip-GP; Mon, 03 Jul 2023 16:51:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=KAac5I6jp3jYwJPvR518QZO6JDKeojORPLGjiqD+qls=; b=3CsY3B6G2d3c0gb9i2GEI7SgMv 7QHpu6mSaCK5VR+x8RUl3PbGiS5PZYqJez84ioENvHhI5um+vibEYwGQVfSoQkRGVG79foZKRnW6c /kdMP+H/QkIJjkUxpgy10joc9YH9vLt1L3nGJ1iZuViJs10hFtkwLkGYSlpzU+LztIpY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 181687: all pass - PUSHED X-Osstest-Versions-This: ovmf=6c744465b6970080dadb1f297db024284153c912 X-Osstest-Versions-That: ovmf=f2188fe5d1553ad1896e27b2514d2f8d0308da8a From: osstest service owner Date: Mon, 03 Jul 2023 16:51:57 +0000 flight 181687 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/181687/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 6c744465b6970080dadb1f297db024284153c912 baseline version: ovmf f2188fe5d1553ad1896e27b2514d2f8d0308da8a Last test of basis 181685 2023-07-03 03:12:31 Z 0 days Testing same since 181687 2023-07-03 14:42:16 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Taylor Beebe Taylor Beebe jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git f2188fe5d1..6c744465b6 6c744465b6970080dadb1f297db024284153c912 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon Jul 03 17:48:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Jul 2023 17:48:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558122.871944 (Exim 4.92) (envelope-from ) id 1qGNfH-0002py-Gr; Mon, 03 Jul 2023 17:48:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558122.871944; Mon, 03 Jul 2023 17:48:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGNfH-0002pr-DX; Mon, 03 Jul 2023 17:48:43 +0000 Received: by outflank-mailman (input) for mailman id 558122; Mon, 03 Jul 2023 17:48:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGNfG-0002pl-TW for xen-devel@lists.xenproject.org; Mon, 03 Jul 2023 17:48:42 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d70ca3a1-19c9-11ee-8611-37d641c3527e; Mon, 03 Jul 2023 19:48:39 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B4D9460FF0; Mon, 3 Jul 2023 17:48:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AAD89C433CA; Mon, 3 Jul 2023 17:48:34 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d70ca3a1-19c9-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688406517; bh=tvAAoxxAUVfK9XbIn+RB9Iavrk7EaGPwzNsEzSZhIVI=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=DgQV3jTer36elNMcnfFGcgLqbFgIsn6079opFGC/NTNGJFP4UdjiYg5WcdCvU5isq gpdvTyY71kkBcYCsNJDKjgUWt596f6n9NM/lPg0aMKjqv05ZOrGXXR2kiC+UtKqjAh CQBuO0jn8eyfSfi4jZg7Ekg9ixs0li3JGaekpSyksG0XLU0E5K2bWELhdhy9URXr7N Jr27KLmrjA+UctthtSw7EMH4jb57h8Hc4w5HxKkmgzjxwQpeucv8hcElU6Xx5hssvb 87ZvUpz7qz5QsOmSg9nM4jtIJ22kfRPTnFQTmHJKPR1TdQQ9llLGi2+b9+WBo4dqiP ht2jwDxKcVJUQ== Date: Mon, 3 Jul 2023 10:48:30 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: "Daniel P. Smith" cc: Luca Fancellu , Andrew Cooper , Xen-devel , Wei Chen , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Henry Wang , Community Manager , Doug Goldstein , Bertrand Marquis , Volodymyr Babchuk , Anthony PERARD , Christopher Clark Subject: Re: [RFC PATCH] xen/arm: Rebranding dom0less feature In-Reply-To: <0c113f33-4410-aa75-84b7-c3ca860688f9@apertussolutions.com> Message-ID: References: <20230630091210.3742121-1-luca.fancellu@arm.com> <6060dd00-5d9c-3804-4b9d-154b9b9dca49@citrix.com> <31FE51E0-0336-4756-8B30-6FE77DE10932@arm.com> <0c113f33-4410-aa75-84b7-c3ca860688f9@apertussolutions.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-457683244-1688403545=:246273" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-457683244-1688403545=:246273 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Mon, 3 Jul 2023, Daniel P. Smith wrote: > On 7/1/23 11:13, Luca Fancellu wrote: > > > On 1 Jul 2023, at 08:53, Andrew Cooper wrote: > > > > > > On 30/06/2023 10:12 am, Luca Fancellu wrote: > > > > The "dom0less" feature was intended to be the feature where a domU > > > > domain could be launched without the control domain (Dom0) > > > > intervention, however the name seems to suggest that Dom0 cannot > > > > be part of the configuration, while instead it's a possible use case. > > > > > > > > To avoid that, rename the "dom0less" configuration with the name > > > > "hyperlaunch", that is less misleading. > > > > > > > > Signed-off-by: Luca Fancellu > > > > --- > > > > This is an RFC to get the feeling of the community about the name > > > > change, for now it's everything in one patch just to see how it > > > > will look like, if there is interest on proceeding into it, I can > > > > split in more commit. > > > > > > Have you discussed this with Dan and Chris at all? You haven't even > > > CC'd them. > > > > No, this rename idea started from a chat during the summit, anyway Julien > > promptly add them to the CC, because I forgot. > > No worries and thank you for considering and taking the time to do this RFC. > It is greatly appreciated that there is a strong willingness to have dom0less > and hyperlaunch merged. > > > > > > > While there is a lot of end-goal in common between the dom0less and > > > hyperlaunch, and that the name dom0less is deeply misleading, > > > hyperlaunch is specifically not this. > > > > Yes Hyperlaunch is more than this, however as I said, with this RFC I would > > like > > to ear opinions, @Daniel @Christopher could it be a proper name for the > > dom0less > > feature? > > As Andy has alluded, hyperlaunch is meant to provide a flexible means to > handle domain construction at boot to meet a wide range of possible use cases. > One of those use cases is dom0less, so yes, ultimately what dom0less does > today will be achievable under hyperlaunch. Our intended approach to align the > two implementations is one that is meant to be minimally disruptive, since > dom0less is considered a supported (SUPPORT.md) capability. As mentioned, we > are greatly appreciative to the openness to adopt the name, Thanks Daniel! > but a big concern > I personally have is the confusion it could cause a general user. A blanket > rename would end up with two documents in the docs tree that provide two > different explanations of hyperlaunch and two different device tree > definitions. So I think a more measured approach should be considered here. > > > If this patch makes things more difficult for the Hyperlunch serie, I’m ok > > to drop it, > > my only aim was just to find a less misleading name for the feature. > > What I would like to suggest as a good first step would be an update to the > dom0less document. Provide a note at the beginning that points to the > hyperlaunch design doc as a more general approach that will eventually subsume > dom0less. This would provide a gentler transition for exist users of dom0less. > > If it is not too much, I would also ask, please have a look at the design for > boot modules in the series Christopher just posted. The design pulls from the > work done by dom0less and expanded upon it. I major step into merging the two > capabilities will be to have a common set of structures. Once those are in > place, we can move to a common device tree representation, and at that point > we would be fairly close, if not at the point of a formal merger of between > the two. At the moment we have a concrete problem with explaining dom0less and hyperlaunch to potential new users. Using two different names for a similar feature on arm and x86 causes confusion. It is hurting Xen as a solution. Personally I already had to switch to use the word "hyperlaunch" for everything in my users-facing presentations. At the summit, we discussed that it would be a good idea to use a single name to refer to both features on arm and x86. Given that "dom0less" causes additional issues because it makes people think that there is no Dom0, the suggestion was to use "hyperlaunch" to refer to both features. We don't need to 100% align the two implementations and data structures. This is not for engineers that are going to look at the specifications and improve them. This is for users/customers of Xen that are trying to understand what the hypervisor enables them to do. We need to be able to show users architecture slides with the same name and explanation on both ARM and x86. I am sure that Daniel and Christopher remember, but for the others on this email thread, the name "hyperlaunch" was born exactly to be that: the one name to cover both features on ARM and x86 even if they have a different implementation. Appended an old email for reference. Also I agree with Daniel that we need to be careful about the two docs under docs/. I think he is right we need to add a paragraph explaining the history and a pointer to the other document. Something like: "Dom0less is the name that was used when initially introducing the feature on ARM. Then, the "dom0less" name was retired in favor of "hyperlaunch" to avoid confusion (a Dom0 might still be present) and to align with x86 (where a similar feature was called hyperlaunch from the start)." --- Subject: [RFP] Overarching name for dom0less and DomB Greetings, At the DeviceTree/DomB meeting it was proposed that a new, larger overarching name under which DomB and dom0less would be covered. There was a general openness to the idea. As such, since Christopher and myself are in the midst of finalizing the design document for DomB we felt it might be better to see if a name could be selected which we could use in the design doc in lieu of DomB. As always naming things is hard, but after some brainstorming we believe we have arrived at a decent name, μLaunch (micro-Launch or uLaunch). --- μLaunch became hyperlaunch few days after, and the rest was history :-) --8323329-457683244-1688403545=:246273-- From xen-devel-bounces@lists.xenproject.org Mon Jul 03 17:52:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Jul 2023 17:52:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558128.871954 (Exim 4.92) (envelope-from ) id 1qGNin-0004Mp-4C; Mon, 03 Jul 2023 17:52:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558128.871954; Mon, 03 Jul 2023 17:52:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGNim-0004Mi-WE; Mon, 03 Jul 2023 17:52:21 +0000 Received: by outflank-mailman (input) for mailman id 558128; Mon, 03 Jul 2023 17:52:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGNil-0004Ma-5c for xen-devel@lists.xenproject.org; Mon, 03 Jul 2023 17:52:19 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 58eb6c18-19ca-11ee-b237-6b7b168915f2; Mon, 03 Jul 2023 19:52:17 +0200 (CEST) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 363G8E5O026238; Mon, 3 Jul 2023 17:52:06 GMT Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3rjajdb7ma-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 03 Jul 2023 17:52:06 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 363HY3B4004200; Mon, 3 Jul 2023 17:52:05 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2169.outbound.protection.outlook.com [104.47.58.169]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3rjak3v2uc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 03 Jul 2023 17:52:05 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by CO1PR10MB4785.namprd10.prod.outlook.com (2603:10b6:303:95::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Mon, 3 Jul 2023 17:52:03 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::2bb9:5d2e:a65b:e731]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::2bb9:5d2e:a65b:e731%7]) with mapi id 15.20.6544.026; Mon, 3 Jul 2023 17:52:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 58eb6c18-19ca-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-03-30; bh=28yXbymEz3ANKb2ikl9to739c0KzjJQ3hnl6I4urb7k=; b=o6QZNOWZlK4fsAiUHM99/qlpjjfUNWFidwwTGkUKITHFJ0eP9VGe6Tb/gFkNBc6knDF3 lhvDcb6ZOObn8F7dk7Q6IDKIGRuZjFcSWd9zLkbvnJUc+/mA1Xl+t3LbcSyO9Q8Jr4iq beuMT//KprwybII7tmwnCuD76WGSYvlDmeJY51y7CWVnuxAdr5YmLS1uEL7A3lUAmpuo ZzHlsbzFU4NOIT7elSw7JbesFNxzq4IvNCwJTzogYrWb+6SiPfBq7qOwxMTz+dLkOiuD 6U2X2Mji1hAVqEyfZR1tKn2e3kQeNSCrFAGgY0GqK6X7lby5tkusliod5CMJoUhvcW1/ 8Q== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zg+ZPCLiM0B217EJNgtAvpOVtTxAqRq+5ZX90KTBw5ZmLuTFB4+Jau7pXbTLRQMFHm9h2BpnFGDvf8iOI4lH2qUZu1sRiwzzereG5g4xxigNPr7m6DTc/4OChzUlsvz1WO1JTtYsNkTNztCKXLE1sbBN6A4dlGAEOJmSuRrMATvakGErXCTnDhhhdGYyp4yWsxAmdzlKohxZK0EsWnJqT7kPfvVyulgjfv4IUVhd0IuWc9WiXyS/+uqWiXUZVI5Pz2DfV1OjmFjDcLGQqUERfy3xYzfuFwY/NGXX9bBVx2c3s6qwxRdburn/zf7ZH6Ho1ngtstreSWyFSapL++/uFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=28yXbymEz3ANKb2ikl9to739c0KzjJQ3hnl6I4urb7k=; b=jzG5h95DKLqBuT3UFMQiX3CCZB0e3uXPRRa9/680J2M0L4wZiHr6iwcD7TRtlUlsMwh4tqZ5ipJG+bW8I7L8Bn6Xg3SssqR8MyVsd3sbvvqWEbTJWJCMLMfP+FnWzxn4K1CloHr07zZJ9YzXZbaXaZ8vxbl8tIoMt/M345z4ZyWW4WraglzJMxNLV/7F3pgp1+7v3q9Brs1LSNIJSXEOhfzBsv7r7cgm/6vFvGmjNqKWQ0X9ucAjxMjVygh75esSE+zvmMQ5rHssUHKt5wgkklcRGThs1EdvQ/1LVq3QSSxVR1yFHddgQctjU3+vGptOCwNoxtfC+sNUC50w8ytCVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=28yXbymEz3ANKb2ikl9to739c0KzjJQ3hnl6I4urb7k=; b=Hl9ICGe0g32ozp3bgND+VvyeiZkv4jKEx9DcjMvQWcvv/kx0moYoIbNhcnrTa3QrmtCh+UpPliJZY3wQ/Y7ruX/PbE9SHeik63+MLEoNHzXL6uZPLV3CpJclgHDbYHtAwJDdiDL2WLgRvFd6g3Empt1eesVQEhORLI9QCqKiWV4= Message-ID: <573ce7fa-d64f-7351-b64d-01692fc87512@oracle.com> Date: Mon, 3 Jul 2023 13:51:57 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] x86/xen: fix secondary processor fpu initialization Content-Language: en-US To: Juergen Gross , linux-kernel@vger.kernel.org, x86@kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , xen-devel@lists.xenproject.org References: <20230703130032.22916-1-jgross@suse.com> From: Boris Ostrovsky In-Reply-To: <20230703130032.22916-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BY5PR17CA0056.namprd17.prod.outlook.com (2603:10b6:a03:167::33) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BLAPR10MB5009:EE_|CO1PR10MB4785:EE_ X-MS-Office365-Filtering-Correlation-Id: 7702ce34-46f3-4e5a-22a8-08db7bee352d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: m11cW2g0hc0kCBB5yhI5xbY1nkPLFA9qxCfam4damnt/1sm581Z7lesRwEDLp7qUgFcIhrONmLgQUfyHIR0FvVwPJP82Y+M7Pifw/UgwCLIWn+1UhR4EQY3Bl9jWtmwyNV8dQHIXA92BV+baAzn/VJab+/4UudIy81ILkdp1nDNL1I0YEP3b0R/S4sF5UBx0dWtrQazLYFNmSDXjLB9Jd7I0Dl48quTpCeYRni5PlcULJR94nLitViHBax04QLH6hT6+8Q/7DgJAJ0VCwKfHuUICBtYJWC+LlqP+89cSRHVhP9u1pMZFFEpmw/Sy615FthK64jtsJRxG3mxWNVFRQ+3QDwM8VrU4bB96gpa4Zn7YOup6gT0x1FS1V2W9J8Rgiybb0wvH/ylbeyWNmLrkzn42Xs/Ybr9b8eAHSoZQ8gprsF792Q+vqHvyJunb8BeBi2sTrHEhzaNi/O1BSvUXF7Wrssq4yPMT3C2xmmDsHQjxtCIWy3VhltR7lwN+ISOvuNt5u9850SlQDXfrn0M+WGtmgcyqjn1hRpITR+c46b4s8w9+sR3ZG38ykR5EJXg0p+6sVJ6UsJMK+FtFIHUBrdJkZjM1Ug2CxoRyZErGic7cMCxJ4NFhFO50hfmaI+M+QtdFGMO6SbdPSHyCAPZEsw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(39860400002)(396003)(376002)(136003)(346002)(451199021)(4744005)(2906002)(41300700001)(5660300002)(8676002)(8936002)(44832011)(36756003)(86362001)(31696002)(186003)(2616005)(31686004)(478600001)(26005)(6512007)(6506007)(6666004)(53546011)(6486002)(316002)(4326008)(66556008)(66946007)(38100700002)(54906003)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXN6VzF5bVVwcVhpYktoZ042bEpkWWhvNlFCOStuWnNJRmZ2QUJsVUVnMExu?= =?utf-8?B?dmRJRFdldy9KY0VzTncybmtkMTdocFgwSkJlOU1ON2dJb0txZzNwVWRYSG9h?= =?utf-8?B?MXBkaVFuTWtOd0ZjeVo4L1lnd0xPWmFhMk5xRVFGek5yYXpCVHYySGhwS3Y1?= =?utf-8?B?dEtzL0VDSlhpVzRtY21TZjF3SWxuK2FUM1hFS2ZKVkd0MTZLZ3RwY3FmT1pB?= =?utf-8?B?L2RxMGJYTEtJQlU2c2N4T0xvK0d5UUFDK2huMlhaVnQ2R2Rtb0ZWd081UEFw?= =?utf-8?B?aUN2WllNaG81dUdLVkNRb2tHY2g5NVkrekNIOThOSTJkNmdKUmhuNGF5TTZ3?= =?utf-8?B?aThMWU1hYjBWajV1aWRGWDQrdmxIcVJOZ0pueDVReU1JWHlsaXRsNzhOVm9T?= =?utf-8?B?S080RVYwZHNJWjZtMEVBelNRTmNHbDc0SFpKdnpTa3RXWTFIOFVBdHVLMktD?= =?utf-8?B?Q1p3NnVSeUJmV1lrM2F4VGZVeDZYL3A4YmpzWFZtRXhURk9Sb1V6THRiUXg4?= =?utf-8?B?ZG9mQ1ljVFRvU1FXalRBbndTOGpPUGhQOVQ0WE43OUl4cE1zWWY4aHdVdXpW?= =?utf-8?B?YmY2dzdLRzZ2eUd6WjNESnNoQ3poOXdCVkVNdGMvaTlvUkJVaUlITHI0OHF2?= =?utf-8?B?UlFCKzFhRnNUazgyb2g3bnpJRGVScUxMVkE3dVpCWkdsalU1dzc0ZnlOMjVV?= =?utf-8?B?RU5hZEp6N1c3bmM1MEJMZElCTEFYcHY4ZkxaSFdndUVuWkRVbG9YaEtIREgw?= =?utf-8?B?dDRVN25EWFdNVnlCMmUrZm5zdzZ3OWdSY0h4c1VHTXNEYkJFTUFwNFovbkRP?= =?utf-8?B?ek0zRmZtQS8xajJaeTRMV0JEMXhvdktONVlyb2Z3SkxZb0p1ZEVLQ0FxOTdq?= =?utf-8?B?a20wcnF0L0syUlhBZ3Q4b2ZUZWRYamFhTzZYb2p3LzQ1Ym8xWTU0MFAxKzJt?= =?utf-8?B?bG1veWgzcGxKTGhSUmZ2NGNmTmtGaHpkbVFvQWlpL0h1V21HK0FEMDdESTVi?= =?utf-8?B?eVZ1NDhXYzdHOU11Y1BtOGdwTHFrM2lsdUkrM3VIcXpwbGc5ZW1EZmptUTIr?= =?utf-8?B?cEF6aThzK3lRYlc2cEZCNjc2MmY5TTQyUkN2K2pBQk9qZ25RcVc1Z0VPeng2?= =?utf-8?B?a0dkZDhIalVHNHR0MmNiOTFWR1dFUktXNkcyWUl1NjlIU1lzUS84TzZ3OGFP?= =?utf-8?B?UGt4b25KOE81cGhTNTlhVXhHR1lEL2srUDdBRWMzb01oNHU1YU1LLzBrbDV5?= =?utf-8?B?enNIM1JVeXVmc0p4Y2szamM0ck9vazI2RTMrNHVDbEt3T09OY3dKNVRJYUg5?= =?utf-8?B?N0NzNVpIR0sxRzV6WWxxY2FmQWZkQTVobENaN01uL2pNZk92K2ZoQ2JsU2pS?= =?utf-8?B?U3kvVGdwdmZ4Q3hnREtKWStpRHl0aTdtcGhPcnl4Uy82Q3d5ZVRJTEpSS04w?= =?utf-8?B?UHNFR29nLzc2MUFPVmRmM0RxaW5WWmE3Q0tBSVF5RFlBMFlnRFVJQnZiczFF?= =?utf-8?B?dW5iSU1GWUQ1c1VoYTFUR3c2M3llYThyN2N3VjdoZThjV2JnU0Fia2VORW9P?= =?utf-8?B?RHhld1N2SzRjOWMzd0FTZ0Q0NGoweTRoKzRuWWRhTy9YbUlOcEU2OS9oWTIw?= =?utf-8?B?YWRrMTE0VjF2NUhubkJIYy9mU1lxMXJTUGhzWk5lc0U5S0U5M0ZUUmppZFRE?= =?utf-8?B?OHFOQWFxNXBYZ01ONU9OTC9rUlZpUjlKZHZKTzZkYkxhU2JXYVZlL2lOMjNo?= =?utf-8?B?TzB1SVdLZ1F6d0N6d1pqeW51cktReElKdkdLZEg2UklyNnVoUHNnVnZGVG03?= =?utf-8?B?dVNjK1NmM2dQeWx1U3BXdFViT0EyRmUrbmNPS2tGSGhxR2pHU2l3RGYvY1E2?= =?utf-8?B?bFkyRUVZMmFKSzA1UGUxQU9WM2NQQUgwVFpyN0RFVnJ2OVJFQTVCU0k3ZFNm?= =?utf-8?B?d2RmeHRjUERMYUZ2RFlqWHdVb3Q4aDhXL1JzS2JvUll6KzhHZjErSUxZZXF2?= =?utf-8?B?bkNaZjI1dFh4N3hVcTd4a3BJYitITms3V1ZpbnVFVGlBbnZqYlM3MDU1THhW?= =?utf-8?B?eVNvTTNvbVJyNHk1UWVOTmpqZE8zOVh1c0dDenhyLzVCbzZCYWRaT2dNMk9i?= =?utf-8?B?VklOZlRkV2lXTGYrZlg4VkM1Z0V0QzlORzZDUFJzbGI2K1lCek5rbGtFOFFw?= =?utf-8?B?OVE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?OXpIdkFmNnpPTm9XeFc4VTNrb0EzVTdFSjd0eHh3TzJ2WHQwOE1SaytJUG04?= =?utf-8?B?NVFDNG1vYmtWeWRpODhyazI1UndUWmJqSHN1TnFIK2szRnR0QWJ1WTZ6VGJQ?= =?utf-8?B?NnlsQkdGc2xJb0Y2NENFdE9iUTMxWXlMMFU2VGFlQ0R0SWVhWWZQc0RTd1Jn?= =?utf-8?B?UU51a05haTFjcDhrb0Z2TmprVk9VbDFyRllQZTRGbW5KQUpoZjFBUE9MUWNv?= =?utf-8?B?MHhxbnpDbHBtdWdtSGpNN2M1QVZocDdXd01LYkV3MGJPK29XbHhxRWhoV3lo?= =?utf-8?B?eEYraC80MzZuT0M4L2d6TTVCbXkxQ295SXY5anNzeWdObXArVGxDSmFMWGZk?= =?utf-8?B?VE42cmQrb045US9uelM1c2RYaXdWbTVTRktJa2RBK29kcXc5L1ZxSkI5OTQr?= =?utf-8?B?dllIcFdOSnJ1TUdYNzZ5UVBsVmpubXFFendRWnZaRjdRdmxmZDFiQmVHZzRN?= =?utf-8?B?M1BBYldCRE05K1JZRmRvS3oyeXIzM1VlbFhVc2xYRFFKQnlkU3JNdU5NQlpu?= =?utf-8?B?OE5VVzRzZXFKWlNXendVdyt1OUFBQ0xvZ1E2dmU5Nm9rQnhIREZrV1BMbXZL?= =?utf-8?B?ZWRDcndSUWN2M1IrbmJOaGlyODA1N0lLUTViM2dsR1BOZVl5ODc4dmt3QzVS?= =?utf-8?B?bTdjNEVPY01RUm1Mb01ENUV3SktSRmI1cWhCNWZyQWw0WU1hQWQ4VGVCV1dk?= =?utf-8?B?VkxhQnJhZ1RtWWREeHZQdGJ4bHA1THF0NmFVS2xOOWE3dEdPd2pUODFydll0?= =?utf-8?B?bE1weEl5T01xVHJPS3hCV1BJSEFUQ3F3OStkTHV5dnpubmQwajhWNUhMakUr?= =?utf-8?B?ZmkwQ1pZVUpTZHVzdWhFOENaM29ZRG9rcXNncjJ4YUwwVk9GUEVzRXFCblJB?= =?utf-8?B?N2lseXBOejVGRUJvZiswZEduZ1ovV1ZpcEM4ZTl0WlZWZjhWLzFiM29LUm4y?= =?utf-8?B?cms1ZW90ei9nMHRXZWVtZWdCOCt4akVuZnBaQ2Fwa0F0NHJZdTRIYUZjQjRs?= =?utf-8?B?ZEw3bzROWTQwM2FnZ0ZGejhYOGU4YlRGbm1BZC9xWkNaRkJGTmw3TU51OFpu?= =?utf-8?B?K2VaSFVMc2gyakN0YWRzb2dSK2ltZkZDdWtNZUlCOW1sSTJsOEQ3VjJ5N3pt?= =?utf-8?B?aXpDUDAycm1XUW05aEd6aWhLUWttRHhRR3VuaTVNQ2d0bFpaVkc5SlBQQmI3?= =?utf-8?B?QXdSbkFJWTNVTTNOYnhYc1F2aS93N21Rb0lNb0xTaDFRaFJ5TjRhd3pjOEpH?= =?utf-8?B?YUdkVVdzdnhLaDlGdjFoREFNU25NRjJJUHplUmhGVEdDU1ltcUFiTGRob3J5?= =?utf-8?B?aU9NdzdablRzRXFpVGFZbU8vcDhnNlFKekErRlpqU3Q2ZVJORUVXNTU3cnpI?= =?utf-8?B?ckYzZ0J6eC9SYWc9PQ==?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7702ce34-46f3-4e5a-22a8-08db7bee352d X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2023 17:52:03.0184 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fYaZgw6LY/VcF9JsLQb8fhp+fjwPHJhG0KPihy5ChJWHzZenyHBC5SSTfCxlK8CpbpWYy0rNmmhSbeig9UDQkm11FZfSrMlRYs8UXjXcYII= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4785 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-03_13,2023-06-30_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 spamscore=0 bulkscore=0 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2307030161 X-Proofpoint-ORIG-GUID: vFqCnZoahiG2G0JeDYtrxbPHv_hRygQU X-Proofpoint-GUID: vFqCnZoahiG2G0JeDYtrxbPHv_hRygQU On 7/3/23 9:00 AM, Juergen Gross wrote: > Moving the call of fpu__init_cpu() from cpu_init() to start_secondary() > broke Xen PV guests, as those don't call start_secondary() for APs. > > Fix that by adding the call of fpu__init_cpu() to cpu_bringup(), which > is the Xen PV replacement of start_secondary(). > > Fixes: b81fac906a8f ("x86/fpu: Move FPU initialization into arch_cpu_finalize_init()") > Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky From xen-devel-bounces@lists.xenproject.org Mon Jul 03 19:44:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Jul 2023 19:44:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558133.871965 (Exim 4.92) (envelope-from ) id 1qGPTU-0007IL-20; Mon, 03 Jul 2023 19:44:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558133.871965; Mon, 03 Jul 2023 19:44:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGPTT-0007IE-TA; Mon, 03 Jul 2023 19:44:39 +0000 Received: by outflank-mailman (input) for mailman id 558133; Mon, 03 Jul 2023 19:44:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGPTS-0007I4-5Q for xen-devel@lists.xenproject.org; Mon, 03 Jul 2023 19:44:38 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0626.outbound.protection.outlook.com [2a01:111:f400:fe0c::626]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 09f01297-19da-11ee-b237-6b7b168915f2; Mon, 03 Jul 2023 21:44:36 +0200 (CEST) Received: from DUZPR01CA0261.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b9::19) by DB4PR08MB9312.eurprd08.prod.outlook.com (2603:10a6:10:3f4::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Mon, 3 Jul 2023 19:44:24 +0000 Received: from DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4b9:cafe::16) by DUZPR01CA0261.outlook.office365.com (2603:10a6:10:4b9::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.30 via Frontend Transport; Mon, 3 Jul 2023 19:44:24 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT040.mail.protection.outlook.com (100.127.142.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.18 via Frontend Transport; Mon, 3 Jul 2023 19:44:23 +0000 Received: ("Tessian outbound d6c4ee3ba1eb:v142"); Mon, 03 Jul 2023 19:44:23 +0000 Received: from f4023ad8879f.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DA4C7E9A-C4CC-45B9-97E9-5F68945FFD08.1; Mon, 03 Jul 2023 19:44:12 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f4023ad8879f.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 03 Jul 2023 19:44:12 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by DB9PR08MB7535.eurprd08.prod.outlook.com (2603:10a6:10:303::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Mon, 3 Jul 2023 19:44:08 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::ed0b:5730:a1f9:577b]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::ed0b:5730:a1f9:577b%5]) with mapi id 15.20.6544.024; Mon, 3 Jul 2023 19:44:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 09f01297-19da-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2kN++LO+K4u/TdNZ2jhD0vy7Ly0CMWt4p0+Myzk0pQ0=; b=GvzXsqooMjVW+qvWPQGAMCmwKgjHme2NJdavyM4fpU/sNXYotqfoVBeGFjyKvBcIhFXQUm6jPptFdGEDQbl+aFEOzpTS8hwVYdP7lNkBFHbdRXh1sednJB93n9LNXwDNHLAux6N0OSZJoERShK0JifTcSkL7S7LISY8yoAll+r0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: e63f5242fc9ae38b X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gy0ZlVONJIOefrpCJOMyeUhvuDIsGz94s5vYj4DoC4wcAkkJgNURulcMYWQNE0AWCcTLYMjV/ukKpNNXWjhMifnCadNvcadDx7gbvNP2aP1joXzOY6rvnrs4v02ioMQSDn+V27x7uedn4jeK3BvtVHmJWf/D0YN0yD3NkZn1VXocD92VbHK92+90WATudHaY7dXZRjxavY+WuoiNZ7ta3mstkNjSzo/I0V05qVoQ2FvgJrizaxzUyUytADYLX6jzjIXg75vXY2VIyXJDUF8jjS0mGQojR2adqZK0He1s18cyJsGOeIiENMj0bpEF8tvTZhxzNow4WVNWg49sPFX45w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2kN++LO+K4u/TdNZ2jhD0vy7Ly0CMWt4p0+Myzk0pQ0=; b=Nz1z/giKFIRF8NyIeURwPy0NQpxXi/36QuptBuo3oLNF4afhAWalg5Tp+ykQV08gjGEBsVKkPrs/G+bJU8YUHgJhbdeuAMewt6uXGUqSvl700TqaNmV1ESdsaEm1boyGM6R851nIN7SorCVcETIovIORR5sltKASTECzI4m6FIX0iy4CPooizoCR+YFC3do/W/JHIeYNNvFrFB6/+EfzooS1PJN+7x55EBeSiXXXtdUGuhEIYULsEIsIQBoACmIlvj6ws8PXiNtk99GAf1yiv0PW4ma12JN6Q/tpL1EI82Ex0ft+v/6PVH7v6gvZNK4UBI/CNqwhxqnZBM4P7PPsIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2kN++LO+K4u/TdNZ2jhD0vy7Ly0CMWt4p0+Myzk0pQ0=; b=GvzXsqooMjVW+qvWPQGAMCmwKgjHme2NJdavyM4fpU/sNXYotqfoVBeGFjyKvBcIhFXQUm6jPptFdGEDQbl+aFEOzpTS8hwVYdP7lNkBFHbdRXh1sednJB93n9LNXwDNHLAux6N0OSZJoERShK0JifTcSkL7S7LISY8yoAll+r0= From: Luca Fancellu To: Stefano Stabellini , "Daniel P. Smith" , Christopher Clark CC: Andrew Cooper , Xen-devel , Wei Chen , George Dunlap , Jan Beulich , Julien Grall , Wei Liu , Henry Wang , Community Manager , Doug Goldstein , Bertrand Marquis , Volodymyr Babchuk , Anthony PERARD Subject: Re: [RFC PATCH] xen/arm: Rebranding dom0less feature Thread-Topic: [RFC PATCH] xen/arm: Rebranding dom0less feature Thread-Index: AQHZqzMUKP6yBnvUfEC1egkdxmuozK+ki8cAgAB66ACAAukxgIAAZuEAgAAgQQA= Date: Mon, 3 Jul 2023 19:44:08 +0000 Message-ID: <8601CDD7-87F7-4FD0-A6E6-BAEAB12E7956@arm.com> References: <20230630091210.3742121-1-luca.fancellu@arm.com> <6060dd00-5d9c-3804-4b9d-154b9b9dca49@citrix.com> <31FE51E0-0336-4756-8B30-6FE77DE10932@arm.com> <0c113f33-4410-aa75-84b7-c3ca860688f9@apertussolutions.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.600.7) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|DB9PR08MB7535:EE_|DBAEUR03FT040:EE_|DB4PR08MB9312:EE_ X-MS-Office365-Filtering-Correlation-Id: 776d9609-8886-4fd0-0ea5-08db7bfde736 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: cG3RHMLqcfso/ZE1G/WIk+a+xRYleGvi+FChHiUJ9KNHa79A1PNcvPM/sAEzYiUKgKsiZJ9u8NZDrz1u99PTtQGWY9/Ufl3B4PQFeoB9vlUadUJLvdbCVmgIr6rOZ5tObM1U5PntOrwtJYXgvIwBkqEI3s5i0+FV3/ImNYpX9o2YPfrr6NFz1d9Xva+Mr19R1w+Lf0e2PunWHOVkAwuYZnkg4O1LKM9p8JlgRa5ojPN87pk31IWHF9QzP65ncmURE+LmE/RlWKIn5s7YBes0GH2J1rGPBXlxfBsnRWPpSOecEuC6zjdHML8bUb1+S/gl0fX8OSr7abxb0gNyord4n/+oaqjWO1+HIkpG4MBphpaYqfEeLwGYevGAEb4olpeUbX8ixnd9h89Q3Jlzkf7MtcMhlyYuODKQNgvxgpEE3dZoNqeSf1kXzu606ARwwf+trPmesv1/mO6j9Wyx5KH1qGJreUrJOA95ylVpcQLXy84r6iaBuaQ1A653WNIB1i9h7BT0wAMG3lu2nME/lpl2JNKInZF/Qlbvv/gphYyU94bsR1Pnqxsw0wvxxicEXmqwPwxnMljzN2UDEaF/haWJDSIl/jeo6Z3kuIC+KZxUav8pBv7bKk6A1RGmx2QrJiuGrMG3WCkAHkX8IHLWG0s7NhyMeIaHzklJULUUDfk4+KI= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(396003)(39860400002)(366004)(376002)(451199021)(26005)(478600001)(71200400001)(6506007)(6512007)(86362001)(2616005)(186003)(38100700002)(54906003)(4326008)(66946007)(66446008)(66556008)(66476007)(64756008)(83380400001)(110136005)(6486002)(53546011)(91956017)(76116006)(316002)(122000001)(5660300002)(8936002)(8676002)(7416002)(38070700005)(41300700001)(2906002)(33656002)(36756003)(32563001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7535 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0f7da99a-2d8d-4180-3fb2-08db7bfdde2e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i2030VVVvPvD8neoq6Ef6HaLwIzKlQ2SWJWeSwoYxMZ1mXvvLeorO1HRk1zptthMpP7HeJWo+fSTD1H3xonxWY4Kpn9lMLhh3St01y3GEJICgedyWzGCtGRWsBVDZIUsiNw24fYRWjHEmfLS1D0Vz8vs9usx/VgXLYujumlSdWuiloszKYXV/Mge10cvwuVYkvBJUCX+2Pe7/Dik53X8FxTrmFBtQbnUzz/m9SudGGAz/18Dtwbpr8tmyRupvct4a3XGMMrS/UmhUAAaRVDqSMk9DTk2H6hAiuge3JrbWpgVASyn2JhqCnIQEME5Kcz2RJAJYwkusx9Zi4DhU+iUgH/v6xGl9PDF/O9GM5p14yvxruDTJ9CLGnPUhySzaOJOJDqY6zefaG3V4R06IRDPOdp9aYtbvV7d86wRXCIjo49mp7dUZlmwjo6C66NfXjcJvD2mhJ3g+/Oi7xSpz76oCFsax5F06aSm0wVciK6G+mPkRytXR89HE1ih7td9km1wG6nt+A7QiDBco6KDrTyyJtv3NWvKk1IvXfPhmFZDR+VKtG53UX7akfQSBcjAFZR3xVZSxXZIifFbc7ID1pljkTbzLnk/6IjMRGiH5vLd3LiSNdW1TleoBskFAbwRO6CqvwMEDiJpoxYNy/N0CD3XVBWtK/gNStZUx2/ETpOtvhV/hhSKhNeL2xihZONWgMT7DP5oUMyIOIlrKFFB4rN8E9KZWWDiAccTw8jTmOiNwlVGAeU9mjoaOnVEbVizd7Ee50rDzA9naGn08ey5ipCgcw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(346002)(136003)(376002)(451199021)(36840700001)(40470700004)(46966006)(54906003)(26005)(6512007)(186003)(53546011)(33656002)(86362001)(8676002)(36756003)(2906002)(110136005)(8936002)(6486002)(5660300002)(40460700003)(41300700001)(478600001)(107886003)(6506007)(81166007)(40480700001)(4326008)(70586007)(356005)(70206006)(82740400003)(47076005)(2616005)(83380400001)(336012)(82310400005)(316002)(36860700001)(32563001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2023 19:44:23.8922 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 776d9609-8886-4fd0-0ea5-08db7bfde736 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB9312 DQoNCj4gT24gMyBKdWwgMjAyMywgYXQgMTg6NDgsIFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJl bGxpbmlAa2VybmVsLm9yZz4gd3JvdGU6DQo+IA0KPiBPbiBNb24sIDMgSnVsIDIwMjMsIERhbmll bCBQLiBTbWl0aCB3cm90ZToNCj4+IE9uIDcvMS8yMyAxMToxMywgTHVjYSBGYW5jZWxsdSB3cm90 ZToNCj4+Pj4gT24gMSBKdWwgMjAyMywgYXQgMDg6NTMsIEFuZHJldyBDb29wZXIgPGFuZHJldy5j b29wZXIzQGNpdHJpeC5jb20+IHdyb3RlOg0KPj4+PiANCj4+Pj4gT24gMzAvMDYvMjAyMyAxMDox MiBhbSwgTHVjYSBGYW5jZWxsdSB3cm90ZToNCj4+Pj4+IFRoZSAiZG9tMGxlc3MiIGZlYXR1cmUg d2FzIGludGVuZGVkIHRvIGJlIHRoZSBmZWF0dXJlIHdoZXJlIGEgZG9tVQ0KPj4+Pj4gZG9tYWlu IGNvdWxkIGJlIGxhdW5jaGVkIHdpdGhvdXQgdGhlIGNvbnRyb2wgZG9tYWluIChEb20wKQ0KPj4+ Pj4gaW50ZXJ2ZW50aW9uLCBob3dldmVyIHRoZSBuYW1lIHNlZW1zIHRvIHN1Z2dlc3QgdGhhdCBE b20wIGNhbm5vdA0KPj4+Pj4gYmUgcGFydCBvZiB0aGUgY29uZmlndXJhdGlvbiwgd2hpbGUgaW5z dGVhZCBpdCdzIGEgcG9zc2libGUgdXNlIGNhc2UuDQo+Pj4+PiANCj4+Pj4+IFRvIGF2b2lkIHRo YXQsIHJlbmFtZSB0aGUgImRvbTBsZXNzIiBjb25maWd1cmF0aW9uIHdpdGggdGhlIG5hbWUNCj4+ Pj4+ICJoeXBlcmxhdW5jaCIsIHRoYXQgaXMgbGVzcyBtaXNsZWFkaW5nLg0KPj4+Pj4gDQo+Pj4+ PiBTaWduZWQtb2ZmLWJ5OiBMdWNhIEZhbmNlbGx1IDxsdWNhLmZhbmNlbGx1QGFybS5jb20+DQo+ Pj4+PiAtLS0NCj4+Pj4+IFRoaXMgaXMgYW4gUkZDIHRvIGdldCB0aGUgZmVlbGluZyBvZiB0aGUg Y29tbXVuaXR5IGFib3V0IHRoZSBuYW1lDQo+Pj4+PiBjaGFuZ2UsIGZvciBub3cgaXQncyBldmVy eXRoaW5nIGluIG9uZSBwYXRjaCBqdXN0IHRvIHNlZSBob3cgaXQNCj4+Pj4+IHdpbGwgbG9vayBs aWtlLCBpZiB0aGVyZSBpcyBpbnRlcmVzdCBvbiBwcm9jZWVkaW5nIGludG8gaXQsIEkgY2FuDQo+ Pj4+PiBzcGxpdCBpbiBtb3JlIGNvbW1pdC4NCj4+Pj4gDQo+Pj4+IEhhdmUgeW91IGRpc2N1c3Nl ZCB0aGlzIHdpdGggRGFuIGFuZCBDaHJpcyBhdCBhbGw/ICBZb3UgaGF2ZW4ndCBldmVuDQo+Pj4+ IENDJ2QgdGhlbS4NCj4+PiANCj4+PiBObywgdGhpcyByZW5hbWUgaWRlYSBzdGFydGVkIGZyb20g YSBjaGF0IGR1cmluZyB0aGUgc3VtbWl0LCBhbnl3YXkgSnVsaWVuDQo+Pj4gcHJvbXB0bHkgYWRk IHRoZW0gdG8gdGhlIENDLCBiZWNhdXNlIEkgZm9yZ290Lg0KPj4gDQo+PiBObyB3b3JyaWVzIGFu ZCB0aGFuayB5b3UgZm9yIGNvbnNpZGVyaW5nIGFuZCB0YWtpbmcgdGhlIHRpbWUgdG8gZG8gdGhp cyBSRkMuDQo+PiBJdCBpcyBncmVhdGx5IGFwcHJlY2lhdGVkIHRoYXQgdGhlcmUgaXMgYSBzdHJv bmcgd2lsbGluZ25lc3MgdG8gaGF2ZSBkb20wbGVzcw0KPj4gYW5kIGh5cGVybGF1bmNoIG1lcmdl ZC4NCj4+IA0KPj4+PiANCj4+Pj4gV2hpbGUgdGhlcmUgaXMgYSBsb3Qgb2YgZW5kLWdvYWwgaW4g Y29tbW9uIGJldHdlZW4gdGhlIGRvbTBsZXNzIGFuZA0KPj4+PiBoeXBlcmxhdW5jaCwgYW5kIHRo YXQgdGhlIG5hbWUgZG9tMGxlc3MgaXMgZGVlcGx5IG1pc2xlYWRpbmcsDQo+Pj4+IGh5cGVybGF1 bmNoIGlzIHNwZWNpZmljYWxseSBub3QgdGhpcy4NCj4+PiANCj4+PiBZZXMgSHlwZXJsYXVuY2gg aXMgbW9yZSB0aGFuIHRoaXMsIGhvd2V2ZXIgYXMgSSBzYWlkLCB3aXRoIHRoaXMgUkZDIEkgd291 bGQNCj4+PiBsaWtlDQo+Pj4gdG8gZWFyIG9waW5pb25zLCBARGFuaWVsIEBDaHJpc3RvcGhlciBj b3VsZCBpdCBiZSBhIHByb3BlciBuYW1lIGZvciB0aGUNCj4+PiBkb20wbGVzcw0KPj4+IGZlYXR1 cmU/DQo+PiANCj4+IEFzIEFuZHkgaGFzIGFsbHVkZWQsIGh5cGVybGF1bmNoIGlzIG1lYW50IHRv IHByb3ZpZGUgYSBmbGV4aWJsZSBtZWFucyB0bw0KPj4gaGFuZGxlIGRvbWFpbiBjb25zdHJ1Y3Rp b24gYXQgYm9vdCB0byBtZWV0IGEgd2lkZSByYW5nZSBvZiBwb3NzaWJsZSB1c2UgY2FzZXMuDQo+ PiBPbmUgb2YgdGhvc2UgdXNlIGNhc2VzIGlzIGRvbTBsZXNzLCBzbyB5ZXMsIHVsdGltYXRlbHkg d2hhdCBkb20wbGVzcyBkb2VzDQo+PiB0b2RheSB3aWxsIGJlIGFjaGlldmFibGUgdW5kZXIgaHlw ZXJsYXVuY2guIE91ciBpbnRlbmRlZCBhcHByb2FjaCB0byBhbGlnbiB0aGUNCj4+IHR3byBpbXBs ZW1lbnRhdGlvbnMgaXMgb25lIHRoYXQgaXMgbWVhbnQgdG8gYmUgbWluaW1hbGx5IGRpc3J1cHRp dmUsIHNpbmNlDQo+PiBkb20wbGVzcyBpcyBjb25zaWRlcmVkIGEgc3VwcG9ydGVkIChTVVBQT1JU Lm1kKSBjYXBhYmlsaXR5LiBBcyBtZW50aW9uZWQsIHdlDQo+PiBhcmUgZ3JlYXRseSBhcHByZWNp YXRpdmUgdG8gdGhlIG9wZW5uZXNzIHRvIGFkb3B0IHRoZSBuYW1lLA0KPiANCj4gVGhhbmtzIERh bmllbCENCj4gDQo+IA0KPj4gYnV0IGEgYmlnIGNvbmNlcm4NCj4+IEkgcGVyc29uYWxseSBoYXZl IGlzIHRoZSBjb25mdXNpb24gaXQgY291bGQgY2F1c2UgYSBnZW5lcmFsIHVzZXIuIEEgYmxhbmtl dA0KPj4gcmVuYW1lIHdvdWxkIGVuZCB1cCB3aXRoIHR3byBkb2N1bWVudHMgaW4gdGhlIGRvY3Mg dHJlZSB0aGF0IHByb3ZpZGUgdHdvDQo+PiBkaWZmZXJlbnQgZXhwbGFuYXRpb25zIG9mIGh5cGVy bGF1bmNoIGFuZCB0d28gZGlmZmVyZW50IGRldmljZSB0cmVlDQo+PiBkZWZpbml0aW9ucy4gU28g SSB0aGluayBhIG1vcmUgbWVhc3VyZWQgYXBwcm9hY2ggc2hvdWxkIGJlIGNvbnNpZGVyZWQgaGVy ZS4NCj4+IA0KPj4+IElmIHRoaXMgcGF0Y2ggbWFrZXMgdGhpbmdzIG1vcmUgZGlmZmljdWx0IGZv ciB0aGUgSHlwZXJsdW5jaCBzZXJpZSwgSeKAmW0gb2sNCj4+PiB0byBkcm9wIGl0LA0KPj4+IG15 IG9ubHkgYWltIHdhcyBqdXN0IHRvIGZpbmQgYSBsZXNzIG1pc2xlYWRpbmcgbmFtZSBmb3IgdGhl IGZlYXR1cmUuDQo+PiANCj4+IFdoYXQgSSB3b3VsZCBsaWtlIHRvIHN1Z2dlc3QgYXMgYSBnb29k IGZpcnN0IHN0ZXAgd291bGQgYmUgYW4gdXBkYXRlIHRvIHRoZQ0KPj4gZG9tMGxlc3MgZG9jdW1l bnQuIFByb3ZpZGUgYSBub3RlIGF0IHRoZSBiZWdpbm5pbmcgdGhhdCBwb2ludHMgdG8gdGhlDQo+ PiBoeXBlcmxhdW5jaCBkZXNpZ24gZG9jIGFzIGEgbW9yZSBnZW5lcmFsIGFwcHJvYWNoIHRoYXQg d2lsbCBldmVudHVhbGx5IHN1YnN1bWUNCj4+IGRvbTBsZXNzLiBUaGlzIHdvdWxkIHByb3ZpZGUg YSBnZW50bGVyIHRyYW5zaXRpb24gZm9yIGV4aXN0IHVzZXJzIG9mIGRvbTBsZXNzLg0KPj4gDQo+ PiBJZiBpdCBpcyBub3QgdG9vIG11Y2gsIEkgd291bGQgYWxzbyBhc2ssIHBsZWFzZSBoYXZlIGEg bG9vayBhdCB0aGUgZGVzaWduIGZvcg0KPj4gYm9vdCBtb2R1bGVzIGluIHRoZSBzZXJpZXMgQ2hy aXN0b3BoZXIganVzdCBwb3N0ZWQuIFRoZSBkZXNpZ24gcHVsbHMgZnJvbSB0aGUNCj4+IHdvcmsg ZG9uZSBieSBkb20wbGVzcyBhbmQgZXhwYW5kZWQgdXBvbiBpdC4gSSBtYWpvciBzdGVwIGludG8g bWVyZ2luZyB0aGUgdHdvDQo+PiBjYXBhYmlsaXRpZXMgd2lsbCBiZSB0byBoYXZlIGEgY29tbW9u IHNldCBvZiBzdHJ1Y3R1cmVzLiBPbmNlIHRob3NlIGFyZSBpbg0KPj4gcGxhY2UsIHdlIGNhbiBt b3ZlIHRvIGEgY29tbW9uIGRldmljZSB0cmVlIHJlcHJlc2VudGF0aW9uLCBhbmQgYXQgdGhhdCBw b2ludA0KPj4gd2Ugd291bGQgYmUgZmFpcmx5IGNsb3NlLCBpZiBub3QgYXQgdGhlIHBvaW50IG9m IGEgZm9ybWFsIG1lcmdlciBvZiBiZXR3ZWVuDQo+PiB0aGUgdHdvLg0KPiANCj4gQXQgdGhlIG1v bWVudCB3ZSBoYXZlIGEgY29uY3JldGUgcHJvYmxlbSB3aXRoIGV4cGxhaW5pbmcgZG9tMGxlc3Mg YW5kDQo+IGh5cGVybGF1bmNoIHRvIHBvdGVudGlhbCBuZXcgdXNlcnMuIFVzaW5nIHR3byBkaWZm ZXJlbnQgbmFtZXMgZm9yIGENCj4gc2ltaWxhciBmZWF0dXJlIG9uIGFybSBhbmQgeDg2IGNhdXNl cyBjb25mdXNpb24uIEl0IGlzIGh1cnRpbmcgWGVuIGFzIGENCj4gc29sdXRpb24uIFBlcnNvbmFs bHkgSSBhbHJlYWR5IGhhZCB0byBzd2l0Y2ggdG8gdXNlIHRoZSB3b3JkDQo+ICJoeXBlcmxhdW5j aCIgZm9yIGV2ZXJ5dGhpbmcgaW4gbXkgdXNlcnMtZmFjaW5nIHByZXNlbnRhdGlvbnMuDQo+IA0K PiBBdCB0aGUgc3VtbWl0LCB3ZSBkaXNjdXNzZWQgdGhhdCBpdCB3b3VsZCBiZSBhIGdvb2QgaWRl YSB0byB1c2UgYSBzaW5nbGUNCj4gbmFtZSB0byByZWZlciB0byBib3RoIGZlYXR1cmVzIG9uIGFy bSBhbmQgeDg2LiBHaXZlbiB0aGF0ICJkb20wbGVzcyINCj4gY2F1c2VzIGFkZGl0aW9uYWwgaXNz dWVzIGJlY2F1c2UgaXQgbWFrZXMgcGVvcGxlIHRoaW5rIHRoYXQgdGhlcmUgaXMgbm8NCj4gRG9t MCwgdGhlIHN1Z2dlc3Rpb24gd2FzIHRvIHVzZSAiaHlwZXJsYXVuY2giIHRvIHJlZmVyIHRvIGJv dGggZmVhdHVyZXMuDQo+IA0KPiBXZSBkb24ndCBuZWVkIHRvIDEwMCUgYWxpZ24gdGhlIHR3byBp bXBsZW1lbnRhdGlvbnMgYW5kIGRhdGEgc3RydWN0dXJlcy4NCj4gVGhpcyBpcyBub3QgZm9yIGVu Z2luZWVycyB0aGF0IGFyZSBnb2luZyB0byBsb29rIGF0IHRoZSBzcGVjaWZpY2F0aW9ucw0KPiBh bmQgaW1wcm92ZSB0aGVtLiBUaGlzIGlzIGZvciB1c2Vycy9jdXN0b21lcnMgb2YgWGVuIHRoYXQg YXJlIHRyeWluZyB0bw0KPiB1bmRlcnN0YW5kIHdoYXQgdGhlIGh5cGVydmlzb3IgZW5hYmxlcyB0 aGVtIHRvIGRvLiBXZSBuZWVkIHRvIGJlIGFibGUgdG8NCj4gc2hvdyB1c2VycyBhcmNoaXRlY3R1 cmUgc2xpZGVzIHdpdGggdGhlIHNhbWUgbmFtZSBhbmQgZXhwbGFuYXRpb24gb24NCj4gYm90aCBB Uk0gYW5kIHg4Ni4NCj4gDQo+IEkgYW0gc3VyZSB0aGF0IERhbmllbCBhbmQgQ2hyaXN0b3BoZXIg cmVtZW1iZXIsIGJ1dCBmb3IgdGhlIG90aGVycyBvbg0KPiB0aGlzIGVtYWlsIHRocmVhZCwgdGhl IG5hbWUgImh5cGVybGF1bmNoIiB3YXMgYm9ybiBleGFjdGx5IHRvIGJlIHRoYXQ6DQo+IHRoZSBv bmUgbmFtZSB0byBjb3ZlciBib3RoIGZlYXR1cmVzIG9uIEFSTSBhbmQgeDg2IGV2ZW4gaWYgdGhl eSBoYXZlIGENCj4gZGlmZmVyZW50IGltcGxlbWVudGF0aW9uLiBBcHBlbmRlZCBhbiBvbGQgZW1h aWwgZm9yIHJlZmVyZW5jZS4NCj4gDQo+IEFsc28gSSBhZ3JlZSB3aXRoIERhbmllbCB0aGF0IHdl IG5lZWQgdG8gYmUgY2FyZWZ1bCBhYm91dCB0aGUgdHdvIGRvY3MNCj4gdW5kZXIgZG9jcy8uIEkg dGhpbmsgaGUgaXMgcmlnaHQgd2UgbmVlZCB0byBhZGQgYSBwYXJhZ3JhcGggZXhwbGFpbmluZw0K PiB0aGUgaGlzdG9yeSBhbmQgYSBwb2ludGVyIHRvIHRoZSBvdGhlciBkb2N1bWVudC4gU29tZXRo aW5nIGxpa2U6DQo+IA0KPiAiRG9tMGxlc3MgaXMgdGhlIG5hbWUgdGhhdCB3YXMgdXNlZCB3aGVu IGluaXRpYWxseSBpbnRyb2R1Y2luZyB0aGUNCj4gZmVhdHVyZSBvbiBBUk0uIFRoZW4sIHRoZSAi ZG9tMGxlc3MiIG5hbWUgd2FzIHJldGlyZWQgaW4gZmF2b3Igb2YNCj4gImh5cGVybGF1bmNoIiB0 byBhdm9pZCBjb25mdXNpb24gKGEgRG9tMCBtaWdodCBzdGlsbCBiZSBwcmVzZW50KSBhbmQgdG8N Cj4gYWxpZ24gd2l0aCB4ODYgKHdoZXJlIGEgc2ltaWxhciBmZWF0dXJlIHdhcyBjYWxsZWQgaHlw ZXJsYXVuY2ggZnJvbSB0aGUNCj4gc3RhcnQpLiINCg0KSeKAmW0gZnVsbHkgb2sgdG8gYWRkIGEg c2VjdGlvbiBsaWtlIHRoaXMgcG9pbnRpbmcgdG8gdGhlIEh5cGVybGF1bmNoIGRlc2lnbi4NCg0K QERhbmllbCBhbmQgQENocmlzdG9waGVyIHdvdWxkIGl0IGJlIG9rIGZvciB5b3Ugb3IgdGhlIGNo YW5nZXMgaW4gdGhlIHNlcmllDQphcmUgZ29pbmcgdG8gYmUgcHJvYmxlbWF0aWMgZm9yIHlvdXIg ZnV0dXJlIHdvcms/IEluIHRoZSBlbmQgaXTigJlzIGp1c3QgYSBtZWNoYW5pY2FsDQpyZW5hbWUs IHNvIEkgZ3Vlc3Mgd2UganVzdCBuZWVkIHRvIGFncmVlIG9uIG5hbWluZyBjb252ZW50aW9ucy4N Cg0KQ2hlZXJzLA0KTHVjYQ0KDQo+IA0KPiANCj4gLS0tDQo+IA0KPiBTdWJqZWN0OiBbUkZQXSBP dmVyYXJjaGluZyBuYW1lIGZvciBkb20wbGVzcyBhbmQgRG9tQg0KPiANCj4gR3JlZXRpbmdzLA0K PiANCj4gQXQgdGhlIERldmljZVRyZWUvRG9tQiBtZWV0aW5nIGl0IHdhcyBwcm9wb3NlZCB0aGF0 IGEgbmV3LCBsYXJnZXINCj4gb3ZlcmFyY2hpbmcgbmFtZSB1bmRlciB3aGljaCBEb21CIGFuZCBk b20wbGVzcyB3b3VsZCBiZSBjb3ZlcmVkLiBUaGVyZQ0KPiB3YXMgYSBnZW5lcmFsIG9wZW5uZXNz IHRvIHRoZSBpZGVhLiBBcyBzdWNoLCBzaW5jZSBDaHJpc3RvcGhlciBhbmQNCj4gbXlzZWxmIGFy ZSBpbiB0aGUgbWlkc3Qgb2YgZmluYWxpemluZyB0aGUgZGVzaWduIGRvY3VtZW50IGZvciBEb21C IHdlDQo+IGZlbHQgaXQgbWlnaHQgYmUgYmV0dGVyIHRvIHNlZSBpZiBhIG5hbWUgY291bGQgYmUg c2VsZWN0ZWQgd2hpY2ggd2UNCj4gY291bGQgdXNlIGluIHRoZSBkZXNpZ24gZG9jIGluIGxpZXUg b2YgRG9tQi4gQXMgYWx3YXlzIG5hbWluZyB0aGluZ3MgaXMNCj4gaGFyZCwgYnV0IGFmdGVyIHNv bWUgYnJhaW5zdG9ybWluZyB3ZSBiZWxpZXZlIHdlIGhhdmUgYXJyaXZlZCBhdCBhDQo+IGRlY2Vu dCBuYW1lLCDOvExhdW5jaCAobWljcm8tTGF1bmNoIG9yIHVMYXVuY2gpLg0KPiANCj4gLS0tDQo+ IA0KPiDOvExhdW5jaCBiZWNhbWUgaHlwZXJsYXVuY2ggZmV3IGRheXMgYWZ0ZXIsIGFuZCB0aGUg cmVzdCB3YXMgaGlzdG9yeSA6LSkNCg0KDQo= From xen-devel-bounces@lists.xenproject.org Mon Jul 03 19:49:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Jul 2023 19:49:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558139.871974 (Exim 4.92) (envelope-from ) id 1qGPY8-0007z4-MK; Mon, 03 Jul 2023 19:49:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558139.871974; Mon, 03 Jul 2023 19:49:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGPY8-0007yx-Iz; Mon, 03 Jul 2023 19:49:28 +0000 Received: by outflank-mailman (input) for mailman id 558139; Mon, 03 Jul 2023 19:49:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGPY7-0007yn-3s; Mon, 03 Jul 2023 19:49:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGPY6-0001Ek-R2; Mon, 03 Jul 2023 19:49:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGPY6-00026V-B3; Mon, 03 Jul 2023 19:49:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qGPY6-00082S-Ac; Mon, 03 Jul 2023 19:49:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=a8bNWrKle78e0CaxbzGMEe30rcVSRUzBE6715Gz368Q=; b=JTiidgByLArD8yjrk4HKShdpBk cMHvlKEI2f7wV44aP9bbh+qXq6DrpfLVPvwiKSjoMiJmtI4jT4C1asOLIuZHwl4pH760C8Zkt99vd Os0i/bquQnAdntxNAgExFS/BDReeewfbShcbHQH1LKyM64LMqyLwgsm56VM0ME6nALAs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 181686: regressions - trouble: broken/fail/pass X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-vhd::broken:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:debian-install:fail:regression linux-linus:test-amd64-amd64-xl-credit1:debian-install:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:guest-start:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:guest-start:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl:debian-install:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:leak-check/basis/dst_host(19):fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:build-arm64-pvops:kernel-build:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:freebsd-install:fail:regression linux-linus:test-amd64-amd64-xl-xsm:debian-install:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:debian-install:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit2:debian-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:windows-install:fail:regression linux-linus:test-amd64-amd64-xl-vhd:host-install(5):broken:heisenbug linux-linus:test-amd64-amd64-libvirt-qcow2:leak-check/basis(11):fail:heisenbug linux-linus:test-amd64-amd64-xl-pvhv2-amd:leak-check/basis(11):fail:heisenbug linux-linus:test-amd64-amd64-xl-credit2:leak-check/basis(11):fail:heisenbug linux-linus:test-amd64-amd64-libvirt:leak-check/basis(11):fail:heisenbug linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:leak-check/basis(11):fail:heisenbug linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:heisenbug linux-linus:test-amd64-amd64-xl-credit1:leak-check/basis(11):fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:heisenbug linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:heisenbug linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:heisenbug linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:heisenbug linux-linus:test-amd64-amd64-xl:leak-check/basis(11):fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:leak-check/basis(11):fail:heisenbug linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:leak-check/basis(11):fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:heisenbug linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:heisenbug linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:heisenbug linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:heisenbug linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:leak-check/basis(11):fail:heisenbug linux-linus:test-amd64-amd64-freebsd11-amd64:leak-check/basis(11):fail:heisenbug linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:heisenbug linux-linus:test-amd64-amd64-xl-multivcpu:debian-install:fail:heisenbug linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:heisenbug linux-linus:test-amd64-amd64-xl-rtds:debian-install:fail:allowable linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-examine:reboot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=a901a3568fd26ca9c4a82d8bc5ed5b3ed844d451 X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Mon, 03 Jul 2023 19:49:26 +0000 flight 181686 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/181686/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-vhd broken test-amd64-amd64-qemuu-nested-amd 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-debianhvm-amd64 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-pygrub 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-libvirt 12 debian-install fail REGR. vs. 180278 test-amd64-amd64-xl-credit1 12 debian-install fail REGR. vs. 180278 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 12 debian-hvm-install fail REGR. vs. 180278 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 180278 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 180278 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 180278 test-arm64-arm64-xl-vhd 13 guest-start fail REGR. vs. 180278 test-arm64-arm64-libvirt-raw 13 guest-start fail REGR. vs. 180278 test-amd64-amd64-examine 8 reboot fail REGR. vs. 180278 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 180278 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 11 leak-check/basis(11) fail in 181682 REGR. vs. 180278 test-amd64-amd64-xl 12 debian-install fail in 181682 REGR. vs. 180278 test-amd64-amd64-libvirt-pair 19 leak-check/basis/dst_host(19) fail in 181682 REGR. vs. 180278 test-amd64-amd64-xl-qemut-debianhvm-amd64 12 debian-hvm-install fail in 181682 REGR. vs. 180278 build-arm64-pvops 6 kernel-build fail in 181682 REGR. vs. 180278 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 11 leak-check/basis(11) fail in 181684 REGR. vs. 180278 test-amd64-amd64-freebsd11-amd64 12 freebsd-install fail in 181684 REGR. vs. 180278 test-amd64-amd64-xl-xsm 12 debian-install fail in 181684 REGR. vs. 180278 test-amd64-amd64-xl-pvhv2-amd 12 debian-install fail in 181684 REGR. vs. 180278 test-amd64-amd64-xl-multivcpu 14 guest-start fail in 181684 REGR. vs. 180278 test-amd64-amd64-xl-credit2 12 debian-install fail in 181684 REGR. vs. 180278 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail in 181684 REGR. vs. 180278 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail in 181684 REGR. vs. 180278 test-amd64-amd64-xl-vhd 8 xen-boot fail in 181684 REGR. vs. 180278 test-amd64-amd64-libvirt-qcow2 12 debian-di-install fail in 181684 REGR. vs. 180278 test-amd64-amd64-xl-qemut-ws16-amd64 12 windows-install fail in 181684 REGR. vs. 180278 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-vhd 5 host-install(5) broken pass in 181684 test-amd64-amd64-libvirt-qcow2 11 leak-check/basis(11) fail in 181682 pass in 181684 test-amd64-amd64-xl-pvhv2-amd 11 leak-check/basis(11) fail in 181682 pass in 181684 test-amd64-amd64-xl-credit2 11 leak-check/basis(11) fail in 181682 pass in 181684 test-amd64-amd64-libvirt 11 leak-check/basis(11) fail in 181682 pass in 181686 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 11 leak-check/basis(11) fail in 181682 pass in 181686 test-amd64-amd64-pygrub 8 xen-boot fail in 181684 pass in 181686 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail in 181684 pass in 181686 test-amd64-amd64-xl-credit1 11 leak-check/basis(11) fail in 181684 pass in 181686 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail in 181684 pass in 181686 test-amd64-amd64-xl-rtds 8 xen-boot fail in 181684 pass in 181686 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail in 181684 pass in 181686 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail in 181684 pass in 181686 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail in 181684 pass in 181686 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail pass in 181682 test-amd64-amd64-xl 11 leak-check/basis(11) fail pass in 181682 test-amd64-amd64-xl-qemut-debianhvm-amd64 11 leak-check/basis(11) fail pass in 181682 test-amd64-coresched-amd64-xl 8 xen-boot fail pass in 181682 test-amd64-amd64-xl-qemut-ws16-amd64 11 leak-check/basis(11) fail pass in 181684 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail pass in 181684 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail pass in 181684 test-amd64-amd64-xl-xsm 8 xen-boot fail pass in 181684 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail pass in 181684 test-amd64-amd64-xl-credit2 8 xen-boot fail pass in 181684 test-amd64-amd64-xl-qemuu-ovmf-amd64 11 leak-check/basis(11) fail pass in 181684 test-amd64-amd64-freebsd11-amd64 11 leak-check/basis(11) fail pass in 181684 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail pass in 181684 test-amd64-amd64-xl-multivcpu 12 debian-install fail pass in 181684 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail pass in 181684 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 12 debian-install fail REGR. vs. 180278 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 1 build-check(1) blocked in 181682 n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked in 181682 n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked in 181682 n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked in 181682 n/a test-arm64-arm64-xl 1 build-check(1) blocked in 181682 n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked in 181682 n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked in 181682 n/a test-arm64-arm64-examine 1 build-check(1) blocked in 181682 n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked in 181682 n/a test-armhf-armhf-xl 8 xen-boot fail like 180278 test-armhf-armhf-xl-vhd 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-raw 8 xen-boot fail like 180278 test-armhf-armhf-xl-arndale 8 xen-boot fail like 180278 test-armhf-armhf-examine 8 reboot fail like 180278 test-armhf-armhf-libvirt 8 xen-boot fail like 180278 test-armhf-armhf-xl-multivcpu 8 xen-boot fail like 180278 test-armhf-armhf-xl-credit2 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail like 180278 test-armhf-armhf-xl-rtds 8 xen-boot fail like 180278 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass version targeted for testing: linux a901a3568fd26ca9c4a82d8bc5ed5b3ed844d451 baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 78 days Failing since 180281 2023-04-17 06:24:36 Z 77 days 151 attempts Testing same since 181682 2023-07-02 19:42:58 Z 1 days 3 attempts ------------------------------------------------------------ 3562 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd broken test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-xl-vhd broken broken-step test-amd64-amd64-xl-vhd host-install(5) Not pushing. (No revision log; it would be 574059 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Jul 03 20:55:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Jul 2023 20:55:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558145.871984 (Exim 4.92) (envelope-from ) id 1qGQZY-0006q9-Cs; Mon, 03 Jul 2023 20:55:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558145.871984; Mon, 03 Jul 2023 20:55:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGQZY-0006q2-9X; Mon, 03 Jul 2023 20:55:00 +0000 Received: by outflank-mailman (input) for mailman id 558145; Mon, 03 Jul 2023 20:54:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGQZW-0006pd-Mp for xen-devel@lists.xenproject.org; Mon, 03 Jul 2023 20:54:58 +0000 Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [2607:f8b0:4864:20::233]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dc140d6f-19e3-11ee-8611-37d641c3527e; Mon, 03 Jul 2023 22:54:54 +0200 (CEST) Received: by mail-oi1-x233.google.com with SMTP id 5614622812f47-3a04e5baffcso3751235b6e.3 for ; Mon, 03 Jul 2023 13:54:54 -0700 (PDT) Received: from smtpclient.apple ([37.19.200.149]) by smtp.gmail.com with ESMTPSA id bi5-20020a056808188500b003a1ae2d2638sm4219671oib.7.2023.07.03.13.54.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Jul 2023 13:54:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dc140d6f-19e3-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688417693; x=1691009693; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:from:to:cc:subject:date:message-id :reply-to; bh=RCbYV9OYll7/BSeuQPWCb5VB0AODorr/L/dKrHXMxBo=; b=KvyiQaJGJuxei8mlgbVL3xmpT/3hB51D4Biveo8Y2ILXzYXE4sMB/IejdFnEbskoVq T0xFsB45yq2dAfCCAE9IvC2NC28XsyYw19YDRaj9poC9bQv59LIN3FJxXaOakmyy7A4g 0G1h935BB64aCrTUiNJq0jATI+WTO0NcIC/eHaN2tqNzC0h8Czjxk87cDINcX7//rfbE kwQmyaF6e/cPDkbbDvkCpcJWJQzRYtotNJOmlva5eA5J29Te9m7PFBRJ4c/exzblsh4i OlGKGadvTjYVCcwjvOTim3n+TtQPfBC+S7A2II/ylpRpC7xKy3yj3FJyuomq8025RbKW gV+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688417693; x=1691009693; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RCbYV9OYll7/BSeuQPWCb5VB0AODorr/L/dKrHXMxBo=; b=HgL06hh4GXZ88Q8hHzvVUU91jvh4gynBKuPRpN7HTa5BRHeAeo+OAV5t6CZ9d/oZqF a5Kh7wjbW/yQf+MqOkIvbZD3oZGvi6EAltwGeqUDzOaYSFM97J12ZkPkSGHJZkIE5dra tQ8p1YQVMetFeJGhAHsRfiU7z4ZLd3834LWyQ2dguj1ROCXWUXeXd/ZToHXzKAHvgaLh duBIciMKBAalHskT8EnDkZ6FmHtbxwLr0rQUDF/nmPJMpQ04v0PW0W83SBCgHe9mCP0H pPrDlk6Y04lXnuQ33//SaWagJBV+SS5xO3bxb4UJCea8z/jwLjGfGZB27hpg6g/MvKpM 1B/Q== X-Gm-Message-State: AC+VfDwIvZnmur4WHa7JRTEDRs/J5iu7XK5GCGURkoj3GZlMNnFtvxZt p5gpYZwX67ppRUq5O5yj/KY= X-Google-Smtp-Source: ACHHUZ4TYuQerqjI+UQq0Oy5ny1hAlVQJoSkzLtwefRxwRQcHOV6O/WXlhGjet9++7yben+jyawQVw== X-Received: by 2002:a54:4414:0:b0:3a3:6f53:e0f6 with SMTP id k20-20020a544414000000b003a36f53e0f6mr10055795oiw.45.1688417692977; Mon, 03 Jul 2023 13:54:52 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: P S Mime-Version: 1.0 (1.0) Subject: Re: [RFC PATCH] xen/arm: Rebranding dom0less feature Date: Mon, 3 Jul 2023 16:54:40 -0400 Message-Id: <234199F8-DBB1-42B6-9A4C-8800EEF60997@gmail.com> References: <8601CDD7-87F7-4FD0-A6E6-BAEAB12E7956@arm.com> Cc: Stefano Stabellini , "Daniel P. Smith" , Christopher Clark , Andrew Cooper , Xen-devel , Wei Chen , George Dunlap , Jan Beulich , Julien Grall , Wei Liu , Henry Wang , Community Manager , Doug Goldstein , Bertrand Marquis , Volodymyr Babchuk , Anthony PERARD In-Reply-To: <8601CDD7-87F7-4FD0-A6E6-BAEAB12E7956@arm.com> To: Luca Fancellu X-Mailer: iPad Mail (20F75) > On Jul 3, 2023, at 15:45, Luca Fancellu wrote: >=20 > =EF=BB=BF >=20 >> On 3 Jul 2023, at 18:48, Stefano Stabellini wrot= e: >>=20 >>> On Mon, 3 Jul 2023, Daniel P. Smith wrote: >>> On 7/1/23 11:13, Luca Fancellu wrote: >>>>> On 1 Jul 2023, at 08:53, Andrew Cooper wro= te: >>>>>=20 >>>>> On 30/06/2023 10:12 am, Luca Fancellu wrote: >>>>>> The "dom0less" feature was intended to be the feature where a domU >>>>>> domain could be launched without the control domain (Dom0) >>>>>> intervention, however the name seems to suggest that Dom0 cannot >>>>>> be part of the configuration, while instead it's a possible use case.= >>>>>>=20 >>>>>> To avoid that, rename the "dom0less" configuration with the name >>>>>> "hyperlaunch", that is less misleading. >>>>>>=20 >>>>>> Signed-off-by: Luca Fancellu >>>>>> --- >>>>>> This is an RFC to get the feeling of the community about the name >>>>>> change, for now it's everything in one patch just to see how it >>>>>> will look like, if there is interest on proceeding into it, I can >>>>>> split in more commit. >>>>>=20 >>>>> Have you discussed this with Dan and Chris at all? You haven't even >>>>> CC'd them. >>>>=20 >>>> No, this rename idea started from a chat during the summit, anyway Juli= en >>>> promptly add them to the CC, because I forgot. >>>=20 >>> No worries and thank you for considering and taking the time to do this R= FC. >>> It is greatly appreciated that there is a strong willingness to have dom= 0less >>> and hyperlaunch merged. >>>=20 >>>>>=20 >>>>> While there is a lot of end-goal in common between the dom0less and >>>>> hyperlaunch, and that the name dom0less is deeply misleading, >>>>> hyperlaunch is specifically not this. >>>>=20 >>>> Yes Hyperlaunch is more than this, however as I said, with this RFC I w= ould >>>> like >>>> to ear opinions, @Daniel @Christopher could it be a proper name for the= >>>> dom0less >>>> feature? >>>=20 >>> As Andy has alluded, hyperlaunch is meant to provide a flexible means to= >>> handle domain construction at boot to meet a wide range of possible use c= ases. >>> One of those use cases is dom0less, so yes, ultimately what dom0less doe= s >>> today will be achievable under hyperlaunch. Our intended approach to ali= gn the >>> two implementations is one that is meant to be minimally disruptive, sin= ce >>> dom0less is considered a supported (SUPPORT.md) capability. As mentioned= , we >>> are greatly appreciative to the openness to adopt the name, >>=20 >> Thanks Daniel! >>=20 >>=20 >>> but a big concern >>> I personally have is the confusion it could cause a general user. A blan= ket >>> rename would end up with two documents in the docs tree that provide two= >>> different explanations of hyperlaunch and two different device tree >>> definitions. So I think a more measured approach should be considered he= re. >>>=20 >>>> If this patch makes things more difficult for the Hyperlunch serie, I=E2= =80=99m ok >>>> to drop it, >>>> my only aim was just to find a less misleading name for the feature. >>>=20 >>> What I would like to suggest as a good first step would be an update to t= he >>> dom0less document. Provide a note at the beginning that points to the >>> hyperlaunch design doc as a more general approach that will eventually s= ubsume >>> dom0less. This would provide a gentler transition for exist users of dom= 0less. >>>=20 >>> If it is not too much, I would also ask, please have a look at the desig= n for >>> boot modules in the series Christopher just posted. The design pulls fro= m the >>> work done by dom0less and expanded upon it. I major step into merging th= e two >>> capabilities will be to have a common set of structures. Once those are i= n >>> place, we can move to a common device tree representation, and at that p= oint >>> we would be fairly close, if not at the point of a formal merger of betw= een >>> the two. >>=20 >> At the moment we have a concrete problem with explaining dom0less and >> hyperlaunch to potential new users. Using two different names for a >> similar feature on arm and x86 causes confusion. It is hurting Xen as a >> solution. Personally I already had to switch to use the word >> "hyperlaunch" for everything in my users-facing presentations. >>=20 >> At the summit, we discussed that it would be a good idea to use a single >> name to refer to both features on arm and x86. Given that "dom0less" >> causes additional issues because it makes people think that there is no >> Dom0, the suggestion was to use "hyperlaunch" to refer to both features. >>=20 >> We don't need to 100% align the two implementations and data structures. >> This is not for engineers that are going to look at the specifications >> and improve them. This is for users/customers of Xen that are trying to >> understand what the hypervisor enables them to do. We need to be able to >> show users architecture slides with the same name and explanation on >> both ARM and x86. >>=20 >> I am sure that Daniel and Christopher remember, but for the others on >> this email thread, the name "hyperlaunch" was born exactly to be that: >> the one name to cover both features on ARM and x86 even if they have a >> different implementation. Appended an old email for reference. >>=20 >> Also I agree with Daniel that we need to be careful about the two docs >> under docs/. I think he is right we need to add a paragraph explaining >> the history and a pointer to the other document. Something like: >>=20 >> "Dom0less is the name that was used when initially introducing the >> feature on ARM. Then, the "dom0less" name was retired in favor of >> "hyperlaunch" to avoid confusion (a Dom0 might still be present) and to >> align with x86 (where a similar feature was called hyperlaunch from the >> start)." >=20 > I=E2=80=99m fully ok to add a section like this pointing to the Hyperlaunc= h design. _If_ this text is added, please include links/references to the Hyperlaunch w= iki page and Hyperlaunch design docs. > @Daniel and @Christopher would it be ok for you or the changes in the seri= e > are going to be problematic for your future work? In the end it=E2=80=99s j= ust a mechanical > rename, so I guess we just need to agree on naming conventions. Please see the history of trademark litigation about the use of symbolic nam= es to reference similar-but-different artifacts. It is much easier to use t= he same name to refer to entirely different objects. Historically, confusion= arises when a name is used in similar contexts. There is also versioning. Could we refer to dom0less as "Hyperlaunch Versio= n -1"?=20 How about renaming dom0less to "Hyperlaunch Lite"? Rich > Cheers, > Luca >=20 >>=20 >>=20 >> --- >>=20 >> Subject: [RFP] Overarching name for dom0less and DomB >>=20 >> Greetings, >>=20 >> At the DeviceTree/DomB meeting it was proposed that a new, larger >> overarching name under which DomB and dom0less would be covered. There >> was a general openness to the idea. As such, since Christopher and >> myself are in the midst of finalizing the design document for DomB we >> felt it might be better to see if a name could be selected which we >> could use in the design doc in lieu of DomB. As always naming things is >> hard, but after some brainstorming we believe we have arrived at a >> decent name, =CE=BCLaunch (micro-Launch or uLaunch). >>=20 >> --- >>=20 >> =CE=BCLaunch became hyperlaunch few days after, and the rest was history := -) >=20 >=20 From xen-devel-bounces@lists.xenproject.org Mon Jul 03 21:35:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Jul 2023 21:35:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558151.871994 (Exim 4.92) (envelope-from ) id 1qGRCS-0002u2-GM; Mon, 03 Jul 2023 21:35:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558151.871994; Mon, 03 Jul 2023 21:35:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGRCS-0002tv-D7; Mon, 03 Jul 2023 21:35:12 +0000 Received: by outflank-mailman (input) for mailman id 558151; Mon, 03 Jul 2023 21:35:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGRCQ-0002tO-WE for xen-devel@lists.xenproject.org; Mon, 03 Jul 2023 21:35:11 +0000 Received: from GBR01-CWL-obe.outbound.protection.outlook.com (mail-cwlgbr01on0704.outbound.protection.outlook.com [2a01:111:f400:fe14::704]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7b3beade-19e9-11ee-8611-37d641c3527e; Mon, 03 Jul 2023 23:35:08 +0200 (CEST) Received: from LO4P265MB6510.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2e3::9) by CWLP265MB6049.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:1d2::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.28; Mon, 3 Jul 2023 21:35:06 +0000 Received: from LO4P265MB6510.GBRP265.PROD.OUTLOOK.COM ([fe80::4194:3a0a:fe99:688b]) by LO4P265MB6510.GBRP265.PROD.OUTLOOK.COM ([fe80::4194:3a0a:fe99:688b%5]) with mapi id 15.20.6544.024; Mon, 3 Jul 2023 21:35:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7b3beade-19e9-11ee-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XQnY/7lZAsxwxYwJD0CNwOIdatVrHBaNJyNTQfXOxXvOBOnHEGnPrkQjcdMiH7mMkBuknubkqkJQux2qfp27yMmKGxYWqSEfJvzjTW/r6XkeZ91mKkQHlUNnTsosB0kqQXIOWA+DdJVtPaw+PDTiKV/7whlO4EFe7rnlIrP0NfevM5DgIzulmSHKiKSEtxRamcN9TkNE/nerDbmVX/JKza4RIVsSbhH2F0mfjcH7QwxILZMwEWuSCat8W1SSzSKKKDCZK09h87iesU5eCyZBTaj2AEhEUcac5HoqkUQt5hlWQXVOh4Kh7GDW/eUsf0UI4UdvsBBlLw783TjhqhM6MQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ErmgjoGgjac2N22Sjh2+rFJmPgFzQoO2T9EDJXceqgY=; b=Eb4wTEasYBjQR+MfWmrThUqV5/l96Pgp+nRVxgzO+ZkXsf0tN+WeENo+kzCewr7h9TnuYOAhAEfNl6yQNr06O3Lz1BHmdcAHXADTNcu6MAfU+dugXlEP+kIl5IRaC5pG6+BiMnoAV3Yw4UMToidQgE+TIfkr3FP8GWEjmHlhQFVBub1GLucacaPLkkkdyzEalx8CK4DyJi4DDu31BJPwQouB/9fRsZ4ytSZLaiDFeRDSqjdRa5qEx8mi5xRJ8CSI+/I8zBnjsSoojYkABVgsB1FuTsKrcC3RWeguEXPmW3jRNHtoNJq4ge3MM6R9La/UpDWjO9hX2CKuFwUpc8DayA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=durham.ac.uk; dmarc=pass action=none header.from=durham.ac.uk; dkim=pass header.d=durham.ac.uk; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=durhamuniversity.onmicrosoft.com; s=selector2-durhamuniversity-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ErmgjoGgjac2N22Sjh2+rFJmPgFzQoO2T9EDJXceqgY=; b=TA0Sbku1e/fCKP7m2u4D4bM932LJwWZ2wxFnx46q7sZqvQDGbHwj4EU5Dl/Nae5kUMbG3t7H21d/Ojc8H4Uy/6SO0089Usng+eKcZon2YMYUIDXbT6IrAwld1TU9l4PKNLJuDx0xWTDXT3yOsx3jbpPoGCofDSiYgE4wNnBhWnk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=durham.ac.uk; Date: Mon, 3 Jul 2023 22:35:04 +0100 (BST) From: Michael Young To: Christopher Clark cc: xen-devel@lists.xenproject.org, Daniel Smith , stefano.stabellini@amd.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Luca Fancellu , Volodymyr Babchuk , Rich Persaud Subject: Re: [PATCH 10/10] x86 setup: refactor efi, pvh and multiboot entrypoints to new boot info In-Reply-To: <20230701071835.41599-11-christopher.w.clark@gmail.com> Message-ID: <1cc9dc44-e8ce-1a87-b5b8-12e9b4beea35@durham.ac.uk> References: <20230701071835.41599-1-christopher.w.clark@gmail.com> <20230701071835.41599-11-christopher.w.clark@gmail.com> Content-Type: text/plain; format=flowed; charset=US-ASCII X-ClientProxiedBy: LO0P265CA0005.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:355::10) To LO4P265MB6510.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2e3::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LO4P265MB6510:EE_|CWLP265MB6049:EE_ X-MS-Office365-Filtering-Correlation-Id: 3912cf9b-2c34-4294-030d-08db7c0d5df7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NuSjRQkIJwFnZsHHeHCuB5OBvVdD4i4WEwHWsA1hOTx8wrHbpVHu9pBoksC1Phr5OC8WMUBBB/4ChWsFuQCZsyrZs6P5OeBznJ7Rp5JxbFGooMKHnJfA4lvD3Or5Y6/8sDWU8G8NDX77uE4Xu/k2ulQiJp+1WFQeWjHB1TegqQ1tad6mssvsE6K8Ikxsh6f08GZVyKhLKXODl5WXBjZnUba5TOpoxNaIJpzn92nCY3KJDqpjXOFnKcFzQOG+yLzivHAJde6NhNeBAA6VpwB2+GpmPpZHQ4aYUFBWrrz6kSa+jdCJ7btfncRw8P0gnwlzQ5Px/J7MEJ8ALIKMJslEShE7O3Y09ZTZF3ERaiZwjXOqnHhz2jxQEqICZRuM6VpX2jVn+VeSB/mpzKo1zxcV8AWuoEHP/6+A7AWlh1A0DPzu3gbMdJkdVSPQI4f09Ooljh0x9gfvDy45B5SY8gKjiXFzQwQRpOpe56dOYT4crUxc1RzwD3S8voIXXJQ+LbY1S7eRVdJ8XvEAxXpfT17/srrdGdoQPEFr3lok9uBvSW/jNyNuf5cqjgNefH9UTcCmVsMGWD1cwHI98JB8PKg0vZkGpqQ9bdHCx8AZ9GWzsyvk8+AJa+qrHYTRLGW8tiXu X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LO4P265MB6510.GBRP265.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(39860400002)(396003)(376002)(136003)(346002)(451199021)(2906002)(41300700001)(5660300002)(8676002)(8936002)(7416002)(36756003)(86362001)(31696002)(186003)(2616005)(478600001)(6512007)(6506007)(31686004)(6486002)(316002)(786003)(4326008)(6916009)(66476007)(66556008)(66946007)(38100700002)(54906003)(83380400001)(45980500001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KXSxlpXpFLMcgs4RyBHYNKYiRV5vBF0VUde0XeeDC8aVNii7riqonC3hLYHI?= =?us-ascii?Q?uo8AjgYaodm3BQqojoT5wU9rBhcf2u316paooAr00PR5JeHMEejttx2+nocj?= =?us-ascii?Q?1Lzyx68liaR9HM9v7KCFozM0p9RqSlBX3gxmVxj+W/PVN85vtj/MwtIKPTJN?= =?us-ascii?Q?cOIsxxVier3T6LqWLeti0hz8oBG/SFUl5e3dn1PFBHOwMmVgajSXew7PebCD?= =?us-ascii?Q?x5foDdLzxHJP/pci1k5BZKSGoAjALX/PSR6r03eVqqIG8BKFSAKs8VbQK3h0?= =?us-ascii?Q?IvqwJ6Cuitqc8pkiuqEsG0Gj936kF1CP54wX+IoNKXuwYks8AGWqLLV+AO3f?= =?us-ascii?Q?QcHcuRhyuPcea68o9i1ZU2Z/JU8cYG4Ruvpxnzb+8yIa38BIzODktTah65lq?= =?us-ascii?Q?ZiNymwkzlZD5sE68UaKdDLpjO+W0CpMuxtMkPZUfUPkPZ52WGGCnPnqWM4ZP?= =?us-ascii?Q?Y0Su9KHSicalBK3O6TIVZRUmQMD5a5lCD6FhMsSye4cyHBS7tqG++GG6QUzF?= =?us-ascii?Q?VboQsjzQuhDekdP26tnvknx6s5g6vv1RHoU2xR+PEJsm7S+rsSwFgoQuB+Y6?= =?us-ascii?Q?09IIXC0PTD3klZBPMunekqxALcbmF9tXQabegw66OimnQsetr5Cuxrd78Wb0?= =?us-ascii?Q?+du9ep/6+roSvAq0n7P7UuKBNavoyiDa1Mhaelhk5mW9rHNXApOFB3wJV/Fr?= =?us-ascii?Q?lceCRZ5Is4oOCy3hYaSt2DAxI2nxQLWDxlVg5JVyAl1PZPqYkimSUFTibDCC?= =?us-ascii?Q?eSJuwoKDygIvj/pj0UHEYfp8G0gnZ7NHJGarbn57DHhpKaKxFKbsAYJ8YkhV?= =?us-ascii?Q?mOPiD1k2y0olefDxWVBkELNCidh/U49f7U/6nltBWexev2aIIpW3+ZFr9Ep2?= =?us-ascii?Q?qpsi0QaEYPbSWqXhUZ4RGJ2fY+UO3M77EcGUyFiNME6wYGmFgKn+EII6kLpZ?= =?us-ascii?Q?YSqzfmoM6uitqsrNe3ZO0L3VtbRfEbxA/evfofkkn8AzjlTL2xSk0hDG1UmJ?= =?us-ascii?Q?u2/VPUzKKkXHVWzuYBcX5UvCgoXHAMkuPPsrvdO8Mj+kbelZr/6Y9H1DWFYD?= =?us-ascii?Q?uF+BC72XBfOgKGds7l9aOfIAC6QDhRuzydrZSojOK1swVEr67y2HeyGRmszU?= =?us-ascii?Q?pSty5p/Rdsg5m2aeTZly5nH7EwiHxysEuuMLBjhts+RuX/6R8UEbPQVHVD01?= =?us-ascii?Q?+DQcopmqrW67p5UIb3wMvl9M0qh2ZdINQ2yLj402TMakOtGXd3ffhJzhOTyU?= =?us-ascii?Q?Lu7EBhv2KOaDdFHmbr2haeLo8fdTpzPDd2VXcdst3KvRCR81ZVTQd14ENzV9?= =?us-ascii?Q?4oncVdTl887inJJRY9NfU3UqIl7z00S4ElO4ZWokC4p2VLBRHTA2uIy9HO+w?= =?us-ascii?Q?+9SZtX4kSo8IWQXAKTnLAwtIDponhB+R0RSYU5+zQ04AUT5bTBHlZeuC5Gu0?= =?us-ascii?Q?yV63rUvJrHgBZYY2hTrePSr/x4Gu1F7Nnfu6QYaQ/xa6OmJ2+mzCjzJod7Em?= =?us-ascii?Q?DyGUZ7bWx2qqJENQVOtTV2z+SAmI0xVYyqx8/HqgJ+En+YJ555tzmKYp16+w?= =?us-ascii?Q?cJ92MGJS7WmrRijY1waSR9pD4tqzpu4HmIrMXVzMFotDDRrI5rPxvWXIHs0R?= =?us-ascii?Q?/zbythgnEb+yzUooMR0XszTrRVKLD2+jZ3ibLISXgy8q?= X-OriginatorOrg: durham.ac.uk X-MS-Exchange-CrossTenant-Network-Message-Id: 3912cf9b-2c34-4294-030d-08db7c0d5df7 X-MS-Exchange-CrossTenant-AuthSource: LO4P265MB6510.GBRP265.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2023 21:35:05.8629 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7250d88b-4b68-4529-be44-d59a2d8a6f94 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WWEa2DK1ekTvtgraYBtkaP/+BPGK4zuBBGY+Vj23oANIKwUZpWVMivqlpC+9hBHHw1XEUGzK5u+Yk5E9kYXNLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWLP265MB6049 I was trying a test build with these patches and got the following error In function 'mbi2_reloc', inlined from 'reloc' at arch/x86/boot/reloc.c:437:16: arch/x86/boot/reloc.c:349:20: error: 'bi_mods' may be used uninitialized [-Werror=maybe-uninitialized] 349 | bi_mods[mod_idx].start = get_mb2_data(tag, module, mod_start); | ^ arch/x86/boot/reloc.c: In function 'reloc': arch/x86/boot/reloc.c:237:25: note: 'bi_mods' was declared here 237 | struct boot_module *bi_mods; | ^~~~~~~ In file included from arch/x86/boot/reloc.c:29: In function 'mbi2_reloc', inlined from 'reloc' at arch/x86/boot/reloc.c:437:16: arch/x86/boot/reloc.c:365:43: error: 'arch_bi_mods' may be used uninitialized [-Werror=maybe-uninitialized] 365 | bi_mods[mod_idx].arch = _addr(&arch_bi_mods[mod_idx]); arch/x86/boot/defs.h:47:46: note: in definition of macro '_addr' 47 | #define _addr(val) ((unsigned long)(void *)(val)) | ^~~ arch/x86/boot/reloc.c: In function 'reloc': arch/x86/boot/reloc.c:238:29: note: 'arch_bi_mods' was declared here 238 | struct arch_bootmodule *arch_bi_mods; | ^~~~~~~~~~~~ cc1: all warnings being treated as errors Is there a problem in the code? Michael Young From xen-devel-bounces@lists.xenproject.org Tue Jul 04 03:04:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 03:04:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558157.872004 (Exim 4.92) (envelope-from ) id 1qGWKv-0001NB-KP; Tue, 04 Jul 2023 03:04:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558157.872004; Tue, 04 Jul 2023 03:04:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGWKv-0001N2-Ec; Tue, 04 Jul 2023 03:04:17 +0000 Received: by outflank-mailman (input) for mailman id 558157; Tue, 04 Jul 2023 03:04:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGWKu-0001Mq-VX; Tue, 04 Jul 2023 03:04:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGWKu-00023Z-KZ; Tue, 04 Jul 2023 03:04:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGWKu-0003Px-3U; Tue, 04 Jul 2023 03:04:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qGWKu-0007bs-34; Tue, 04 Jul 2023 03:04:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=xjP1LhyxfOy9nOP/noGwZ5mSzoj5B6DxHMaJMaIpwVI=; b=g3bwm01K5gGhEpHMiYgOqJ+8sg J35AagJ9AgwkvvxKCrWJP9RzDi4kWAQHqb54djQTnHt5v0XEZpRQXskbq3krB+HfvGD3IqPjbk7R1 8JDVnaxP7/xeNJPmL9E8uowaX2KI44e2+VN9sp0WZD6ChLbc0kDr8aXK5F9pcCoLwpJU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 181688: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:leak-check/basis(11):fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit2:debian-install:fail:regression linux-linus:test-amd64-amd64-xl:debian-install:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:guest-start:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:guest-start:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-rtds:debian-install:fail:allowable linux-linus:test-armhf-armhf-xl:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-examine:reboot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=0a8d6c9c7128a93689fba384cdd7f72b0ce19abd X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Tue, 04 Jul 2023 03:04:16 +0000 flight 181688 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/181688/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-qemuu-nested-amd 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-ws16-amd64 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-debianhvm-amd64 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-pvhv2-amd 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-ovmf-amd64 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-freebsd11-amd64 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-debianhvm-amd64 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-multivcpu 14 guest-start fail REGR. vs. 180278 test-amd64-amd64-xl-credit2 12 debian-install fail REGR. vs. 180278 test-amd64-amd64-xl 12 debian-install fail REGR. vs. 180278 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 180278 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 180278 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 180278 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 180278 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 180278 test-arm64-arm64-xl-vhd 13 guest-start fail REGR. vs. 180278 test-arm64-arm64-libvirt-raw 13 guest-start fail REGR. vs. 180278 test-amd64-amd64-examine 8 reboot fail REGR. vs. 180278 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 180278 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 180278 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 12 debian-install fail REGR. vs. 180278 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl 8 xen-boot fail like 180278 test-armhf-armhf-xl-vhd 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-raw 8 xen-boot fail like 180278 test-armhf-armhf-xl-arndale 8 xen-boot fail like 180278 test-armhf-armhf-examine 8 reboot fail like 180278 test-armhf-armhf-libvirt 8 xen-boot fail like 180278 test-armhf-armhf-xl-multivcpu 8 xen-boot fail like 180278 test-armhf-armhf-xl-credit2 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail like 180278 test-armhf-armhf-xl-rtds 8 xen-boot fail like 180278 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass version targeted for testing: linux 0a8d6c9c7128a93689fba384cdd7f72b0ce19abd baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 78 days Failing since 180281 2023-04-17 06:24:36 Z 77 days 152 attempts Testing same since 181688 2023-07-03 20:11:28 Z 0 days 1 attempts ------------------------------------------------------------ 3573 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 576994 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Jul 04 05:43:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 05:43:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558163.872013 (Exim 4.92) (envelope-from ) id 1qGYoX-00018y-35; Tue, 04 Jul 2023 05:43:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558163.872013; Tue, 04 Jul 2023 05:43:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGYoX-00018r-0H; Tue, 04 Jul 2023 05:43:01 +0000 Received: by outflank-mailman (input) for mailman id 558163; Tue, 04 Jul 2023 05:43:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGYoW-00018l-Bi for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 05:43:00 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a17b73e6-1a2d-11ee-b237-6b7b168915f2; Tue, 04 Jul 2023 07:42:58 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A50972033E; Tue, 4 Jul 2023 05:42:57 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5787D1377F; Tue, 4 Jul 2023 05:42:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cT3kE2Gxo2QyXgAAMHmgww (envelope-from ); Tue, 04 Jul 2023 05:42:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a17b73e6-1a2d-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1688449377; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5NwuPs6s1tLTrj/NTRQSBFohPKNsbBrgq7cDUM/Uak0=; b=m9Km9mZhS2F9ZjGxYlpibsKVONF/cnBP+sjkMfAJ1EF0wct5Cz22mHvDxsOAAF2EOQFTig VZOgVXGochqhf/kAbmgJTk8fMerLOt+bz17uGVN0a62wupZoIpWnwcxitnOn7QVay+atXM IJ3FAxa9mbd/8sl9PAq/eWAXnRkMOi0= Message-ID: <58f3bf1b-c5dd-7ac1-e765-7fa7eb0ba51b@suse.com> Date: Tue, 4 Jul 2023 07:42:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] x86/xen: fix secondary processor fpu initialization Content-Language: en-US To: linux-kernel@vger.kernel.org, x86@kernel.org, Borislav Petkov , Thomas Gleixner , Dave Hansen , Ingo Molnar Cc: "H. Peter Anvin" , xen-devel@lists.xenproject.org, Boris Ostrovsky References: <20230703130032.22916-1-jgross@suse.com> <573ce7fa-d64f-7351-b64d-01692fc87512@oracle.com> From: Juergen Gross In-Reply-To: <573ce7fa-d64f-7351-b64d-01692fc87512@oracle.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------Gw70l1b7G08YSUIj0nFX09au" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------Gw70l1b7G08YSUIj0nFX09au Content-Type: multipart/mixed; boundary="------------vAlMdTjTE2SXGQIzESyPAfiN"; protected-headers="v1" From: Juergen Gross To: linux-kernel@vger.kernel.org, x86@kernel.org, Borislav Petkov , Thomas Gleixner , Dave Hansen , Ingo Molnar Cc: "H. Peter Anvin" , xen-devel@lists.xenproject.org, Boris Ostrovsky Message-ID: <58f3bf1b-c5dd-7ac1-e765-7fa7eb0ba51b@suse.com> Subject: Re: [PATCH] x86/xen: fix secondary processor fpu initialization References: <20230703130032.22916-1-jgross@suse.com> <573ce7fa-d64f-7351-b64d-01692fc87512@oracle.com> In-Reply-To: <573ce7fa-d64f-7351-b64d-01692fc87512@oracle.com> --------------vAlMdTjTE2SXGQIzESyPAfiN Content-Type: multipart/mixed; boundary="------------z39WHiKNaxFZC80ifpMOBC5K" --------------z39WHiKNaxFZC80ifpMOBC5K Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMDcuMjMgMTk6NTEsIEJvcmlzIE9zdHJvdnNreSB3cm90ZToNCj4gDQo+IA0KPiBP biA3LzMvMjMgOTowMCBBTSwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4+IE1vdmluZyB0aGUg Y2FsbCBvZiBmcHVfX2luaXRfY3B1KCkgZnJvbSBjcHVfaW5pdCgpIHRvIHN0YXJ0X3NlY29u ZGFyeSgpDQo+PiBicm9rZSBYZW4gUFYgZ3Vlc3RzLCBhcyB0aG9zZSBkb24ndCBjYWxsIHN0 YXJ0X3NlY29uZGFyeSgpIGZvciBBUHMuDQo+Pg0KPj4gRml4IHRoYXQgYnkgYWRkaW5nIHRo ZSBjYWxsIG9mIGZwdV9faW5pdF9jcHUoKSB0byBjcHVfYnJpbmd1cCgpLCB3aGljaA0KPj4g aXMgdGhlIFhlbiBQViByZXBsYWNlbWVudCBvZiBzdGFydF9zZWNvbmRhcnkoKS4NCj4+DQo+ PiBGaXhlczogYjgxZmFjOTA2YThmICgieDg2L2ZwdTogTW92ZSBGUFUgaW5pdGlhbGl6YXRp b24gaW50byANCj4+IGFyY2hfY3B1X2ZpbmFsaXplX2luaXQoKSIpDQo+PiBTaWduZWQtb2Zm LWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+IA0KPiANCj4gUmV2aWV3 ZWQtYnk6IEJvcmlzIE9zdHJvdnNreSA8Ym9yaXMub3N0cm92c2t5QG9yYWNsZS5jb20+DQo+ IA0KDQp4ODYgbWFpbnRhaW5lcnMsIGNvdWxkIHRoaXMgcGxlYXNlIGdvIHRocm91Z2ggdGhl IHRpcCB0cmVlPyBUaGUgcGF0Y2ggaXMNCmRlcGVuZGluZyBvbiBvdGhlciA2LjUgcGF0Y2hl cyB3aGljaCB3ZW50IGluIHZpYSB0aXAuDQoNCg0KSnVlcmdlbg0K --------------z39WHiKNaxFZC80ifpMOBC5K Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------z39WHiKNaxFZC80ifpMOBC5K-- --------------vAlMdTjTE2SXGQIzESyPAfiN-- --------------Gw70l1b7G08YSUIj0nFX09au Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmSjsWAFAwAAAAAACgkQsN6d1ii/Ey96 owf/X5ApjLsFhOrNfLewRK+1nkdEKFhRd1kjNymIMz3R4KAfY4jJehV269qXMFoND6JqxGjsCn1z a85JSXBG7Hs4Z9bW00eNObpWeLrCJfUio/s5SSaASN0F6yoJ6RRBDIH0kg67VbuNR/5MEWCjJEy5 ed9aOJS7mrgRkPAUu/KdhgTAkrGvWpembXDm3DDSIgv8YnEtzBw8Js9x0hHUdgQNq3jr5uhO1fV+ Lf0O8M5khNujTiaw9yBP9JRRENzvWIIVx1JfqHo+fhfMEuXxOLB048ytLkQbZHjCBuZb9/9PdoU8 q5aB0zhlLT0b9KZbOESIJoTMWQRkLNE9RwHiJitWBw== =4DAt -----END PGP SIGNATURE----- --------------Gw70l1b7G08YSUIj0nFX09au-- From xen-devel-bounces@lists.xenproject.org Tue Jul 04 06:25:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 06:25:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558169.872024 (Exim 4.92) (envelope-from ) id 1qGZTb-0005gz-CV; Tue, 04 Jul 2023 06:25:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558169.872024; Tue, 04 Jul 2023 06:25:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGZTb-0005gs-9c; Tue, 04 Jul 2023 06:25:27 +0000 Received: by outflank-mailman (input) for mailman id 558169; Tue, 04 Jul 2023 06:25:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGZTZ-0005gm-NJ for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 06:25:25 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8e3c3018-1a33-11ee-8611-37d641c3527e; Tue, 04 Jul 2023 08:25:23 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 655C221FD5; Tue, 4 Jul 2023 06:25:22 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 28502133F7; Tue, 4 Jul 2023 06:25:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id yFN3CFK7o2QlcAAAMHmgww (envelope-from ); Tue, 04 Jul 2023 06:25:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e3c3018-1a33-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1688451922; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1qYP92va/e11rKWSltIXYM3dlSes1GmTJGZ6wryoMX4=; b=TUuaMWBGxuvaoFRIBs1rAuNC8sx6v8cuJ3oM8sRtjwBNbry8qnD9ictWPeYmIojVFOS9me qpslKGAZ6lP0/BNw48rLaQHOPkwLJvO1U+XfYLee0tZl/GVEI2oZp/ANxhSETwA1FP/sul mcfX8BV0HpCPVBvor6l7bcrlrgeTVHg= Message-ID: <319b9f51-c833-49ef-f0e3-1fc5ddb8ae47@suse.com> Date: Tue, 4 Jul 2023 08:25:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 2/2] xen/virtio: Avoid use of the dom0 backend in dom0 Content-Language: en-US To: Stefano Stabellini , Oleksandr Tyshchenko Cc: Petr Pavlu , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" , vikram.garhwal@amd.com References: <20230621131214.9398-1-petr.pavlu@suse.com> <20230621131214.9398-3-petr.pavlu@suse.com> <15e31609-6c45-7372-76ee-0adf7a64fe88@epam.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------90RvH73Xi3vYjwiAKZs06GnN" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------90RvH73Xi3vYjwiAKZs06GnN Content-Type: multipart/mixed; boundary="------------STn05AdcU5bge70lDfUXtYfY"; protected-headers="v1" From: Juergen Gross To: Stefano Stabellini , Oleksandr Tyshchenko Cc: Petr Pavlu , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" , vikram.garhwal@amd.com Message-ID: <319b9f51-c833-49ef-f0e3-1fc5ddb8ae47@suse.com> Subject: Re: [PATCH 2/2] xen/virtio: Avoid use of the dom0 backend in dom0 References: <20230621131214.9398-1-petr.pavlu@suse.com> <20230621131214.9398-3-petr.pavlu@suse.com> <15e31609-6c45-7372-76ee-0adf7a64fe88@epam.com> In-Reply-To: --------------STn05AdcU5bge70lDfUXtYfY Content-Type: multipart/mixed; boundary="------------W7OmSDerYdL9ey1DQ9qTYn1B" --------------W7OmSDerYdL9ey1DQ9qTYn1B Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMzAuMDYuMjMgMDA6NDQsIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToNCj4gT24gVGh1 LCAyOSBKdW4gMjAyMywgT2xla3NhbmRyIFR5c2hjaGVua28gd3JvdGU6DQo+PiBPbiAyOS4w Ni4yMyAwNDowMCwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KPj4NCj4+IEhlbGxvIFN0 ZWZhbm8NCj4+DQo+Pj4gT24gV2VkLCAyMSBKdW4gMjAyMywgT2xla3NhbmRyIFR5c2hjaGVu a28gd3JvdGU6DQo+Pj4+IE9uIDIxLjA2LjIzIDE2OjEyLCBQZXRyIFBhdmx1IHdyb3RlOg0K Pj4+Pg0KPj4+Pg0KPj4+PiBIZWxsbyBQZXRyDQo+Pj4+DQo+Pj4+DQo+Pj4+PiBXaGVuIGF0 dGVtcHRpbmcgdG8gcnVuIFhlbiBvbiBhIFFFTVUvS1ZNIHZpcnR1YWwgbWFjaGluZSB3aXRo IHZpcnRpbw0KPj4+Pj4gZGV2aWNlcyAoYWxsIHg4Nl82NCksIGRvbTAgdHJpZXMgdG8gZXN0 YWJsaXNoIGEgZ3JhbnQgZm9yIGl0c2VsZiB3aGljaA0KPj4+Pj4gZXZlbnR1YWxseSByZXN1 bHRzIGluIGEgaGFuZyBkdXJpbmcgdGhlIGJvb3QuDQo+Pj4+Pg0KPj4+Pj4gVGhlIGJhY2t0 cmFjZSBsb29rcyBhcyBmb2xsb3dzLCB0aGUgd2hpbGUgbG9vcCBpbiBfX3NlbmRfY29udHJv bF9tc2coKQ0KPj4+Pj4gbWFrZXMgbm8gcHJvZ3Jlc3M6DQo+Pj4+Pg0KPj4+Pj4gICAgICAj MCAgdmlydHF1ZXVlX2dldF9idWZfY3R4IChfdnE9X3ZxQGVudHJ5PTB4ZmZmZjg4ODAwNzRh ODQwMCwgbGVuPWxlbkBlbnRyeT0weGZmZmZjOTAwMDA0MTNjOTQsIGN0eD1jdHhAZW50cnk9 MHgwIDxmaXhlZF9wZXJjcHVfZGF0YT4pIGF0IC4uL2RyaXZlcnMvdmlydGlvL3ZpcnRpb19y aW5nLmM6MjMyNg0KPj4+Pj4gICAgICAjMSAgMHhmZmZmZmZmZjgxNzA4NmI3IGluIHZpcnRx dWV1ZV9nZXRfYnVmIChfdnE9X3ZxQGVudHJ5PTB4ZmZmZjg4ODAwNzRhODQwMCwgbGVuPWxl bkBlbnRyeT0weGZmZmZjOTAwMDA0MTNjOTQpIGF0IC4uL2RyaXZlcnMvdmlydGlvL3ZpcnRp b19yaW5nLmM6MjMzMw0KPj4+Pj4gICAgICAjMiAgMHhmZmZmZmZmZjgxNzVmNmIyIGluIF9f c2VuZF9jb250cm9sX21zZyAocG9ydGRldj08b3B0aW1pemVkIG91dD4sIHBvcnRfaWQ9MHhm ZmZmZmZmZiwgZXZlbnQ9MHgwLCB2YWx1ZT0weDEpIGF0IC4uL2RyaXZlcnMvY2hhci92aXJ0 aW9fY29uc29sZS5jOjU2Mg0KPj4+Pj4gICAgICAjMyAgMHhmZmZmZmZmZjgxNzVmNmVlIGlu IF9fc2VuZF9jb250cm9sX21zZyAocG9ydGRldj08b3B0aW1pemVkIG91dD4sIHBvcnRfaWQ9 PG9wdGltaXplZCBvdXQ+LCBldmVudD08b3B0aW1pemVkIG91dD4sIHZhbHVlPTxvcHRpbWl6 ZWQgb3V0PikgYXQgLi4vZHJpdmVycy9jaGFyL3ZpcnRpb19jb25zb2xlLmM6NTY5DQo+Pj4+ PiAgICAgICM0ICAweGZmZmZmZmZmODE3NjE4YjEgaW4gdmlydGNvbnNfcHJvYmUgKHZkZXY9 MHhmZmZmODg4MDA1ODVlODAwKSBhdCAuLi9kcml2ZXJzL2NoYXIvdmlydGlvX2NvbnNvbGUu YzoyMDk4DQo+Pj4+PiAgICAgICM1ICAweGZmZmZmZmZmODE3MDcxMTcgaW4gdmlydGlvX2Rl dl9wcm9iZSAoX2Q9MHhmZmZmODg4MDA1ODVlODEwKSBhdCAuLi9kcml2ZXJzL3ZpcnRpby92 aXJ0aW8uYzozMDUNCj4+Pj4+ICAgICAgIzYgIDB4ZmZmZmZmZmY4MTk4ZTM0OCBpbiBjYWxs X2RyaXZlcl9wcm9iZSAoZHJ2PTB4ZmZmZmZmZmY4MmJlNDBjMCA8dmlydGlvX2NvbnNvbGU+ LCBkcnY9MHhmZmZmZmZmZjgyYmU0MGMwIDx2aXJ0aW9fY29uc29sZT4sIGRldj0weGZmZmY4 ODgwMDU4NWU4MTApIGF0IC4uL2RyaXZlcnMvYmFzZS9kZC5jOjU3OQ0KPj4+Pj4gICAgICAj NyAgcmVhbGx5X3Byb2JlIChkZXY9ZGV2QGVudHJ5PTB4ZmZmZjg4ODAwNTg1ZTgxMCwgZHJ2 PWRydkBlbnRyeT0weGZmZmZmZmZmODJiZTQwYzAgPHZpcnRpb19jb25zb2xlPikgYXQgLi4v ZHJpdmVycy9iYXNlL2RkLmM6NjU4DQo+Pj4+PiAgICAgICM4ICAweGZmZmZmZmZmODE5OGU1 OGYgaW4gX19kcml2ZXJfcHJvYmVfZGV2aWNlIChkcnY9ZHJ2QGVudHJ5PTB4ZmZmZmZmZmY4 MmJlNDBjMCA8dmlydGlvX2NvbnNvbGU+LCBkZXY9ZGV2QGVudHJ5PTB4ZmZmZjg4ODAwNTg1 ZTgxMCkgYXQgLi4vZHJpdmVycy9iYXNlL2RkLmM6ODAwDQo+Pj4+PiAgICAgICM5ICAweGZm ZmZmZmZmODE5OGU2NWEgaW4gZHJpdmVyX3Byb2JlX2RldmljZSAoZHJ2PWRydkBlbnRyeT0w eGZmZmZmZmZmODJiZTQwYzAgPHZpcnRpb19jb25zb2xlPiwgZGV2PWRldkBlbnRyeT0weGZm ZmY4ODgwMDU4NWU4MTApIGF0IC4uL2RyaXZlcnMvYmFzZS9kZC5jOjgzMA0KPj4+Pj4gICAg ICAjMTAgMHhmZmZmZmZmZjgxOThlODMyIGluIF9fZHJpdmVyX2F0dGFjaCAoZGV2PTB4ZmZm Zjg4ODAwNTg1ZTgxMCwgZGF0YT0weGZmZmZmZmZmODJiZTQwYzAgPHZpcnRpb19jb25zb2xl PikgYXQgLi4vZHJpdmVycy9iYXNlL2RkLmM6MTIxNg0KPj4+Pj4gICAgICAjMTEgMHhmZmZm ZmZmZjgxOThiZmIyIGluIGJ1c19mb3JfZWFjaF9kZXYgKGJ1cz08b3B0aW1pemVkIG91dD4s IHN0YXJ0PXN0YXJ0QGVudHJ5PTB4MCA8Zml4ZWRfcGVyY3B1X2RhdGE+LCBkYXRhPWRhdGFA ZW50cnk9MHhmZmZmZmZmZjgyYmU0MGMwIDx2aXJ0aW9fY29uc29sZT4sDQo+Pj4+PiAgICAg ICAgICBmbj1mbkBlbnRyeT0weGZmZmZmZmZmODE5OGU3YjAgPF9fZHJpdmVyX2F0dGFjaD4p IGF0IC4uL2RyaXZlcnMvYmFzZS9idXMuYzozNjgNCj4+Pj4+ICAgICAgIzEyIDB4ZmZmZmZm ZmY4MTk4ZGI2NSBpbiBkcml2ZXJfYXR0YWNoIChkcnY9ZHJ2QGVudHJ5PTB4ZmZmZmZmZmY4 MmJlNDBjMCA8dmlydGlvX2NvbnNvbGU+KSBhdCAuLi9kcml2ZXJzL2Jhc2UvZGQuYzoxMjMz DQo+Pj4+PiAgICAgICMxMyAweGZmZmZmZmZmODE5OGQyMDcgaW4gYnVzX2FkZF9kcml2ZXIg KGRydj1kcnZAZW50cnk9MHhmZmZmZmZmZjgyYmU0MGMwIDx2aXJ0aW9fY29uc29sZT4pIGF0 IC4uL2RyaXZlcnMvYmFzZS9idXMuYzo2NzMNCj4+Pj4+ICAgICAgIzE0IDB4ZmZmZmZmZmY4 MTk4ZjU1MCBpbiBkcml2ZXJfcmVnaXN0ZXIgKGRydj1kcnZAZW50cnk9MHhmZmZmZmZmZjgy YmU0MGMwIDx2aXJ0aW9fY29uc29sZT4pIGF0IC4uL2RyaXZlcnMvYmFzZS9kcml2ZXIuYzoy NDYNCj4+Pj4+ICAgICAgIzE1IDB4ZmZmZmZmZmY4MTcwNmI0NyBpbiByZWdpc3Rlcl92aXJ0 aW9fZHJpdmVyIChkcml2ZXI9ZHJpdmVyQGVudHJ5PTB4ZmZmZmZmZmY4MmJlNDBjMCA8dmly dGlvX2NvbnNvbGU+KSBhdCAuLi9kcml2ZXJzL3ZpcnRpby92aXJ0aW8uYzozNTcNCj4+Pj4+ ICAgICAgIzE2IDB4ZmZmZmZmZmY4MzJjZDM0YiBpbiB2aXJ0aW9fY29uc29sZV9pbml0ICgp IGF0IC4uL2RyaXZlcnMvY2hhci92aXJ0aW9fY29uc29sZS5jOjIyNTgNCj4+Pj4+ICAgICAg IzE3IDB4ZmZmZmZmZmY4MTAwMTA1YyBpbiBkb19vbmVfaW5pdGNhbGwgKGZuPTB4ZmZmZmZm ZmY4MzJjZDJlMCA8dmlydGlvX2NvbnNvbGVfaW5pdD4pIGF0IC4uL2luaXQvbWFpbi5jOjEy NDYNCj4+Pj4+ICAgICAgIzE4IDB4ZmZmZmZmZmY4MzI3NzI5MyBpbiBkb19pbml0Y2FsbF9s ZXZlbCAoY29tbWFuZF9saW5lPTB4ZmZmZjg4ODAwM2UyZjkwMCAicm9vdCIsIGxldmVsPTB4 NikgYXQgLi4vaW5pdC9tYWluLmM6MTMxOQ0KPj4+Pj4gICAgICAjMTkgZG9faW5pdGNhbGxz ICgpIGF0IC4uL2luaXQvbWFpbi5jOjEzMzUNCj4+Pj4+ICAgICAgIzIwIGRvX2Jhc2ljX3Nl dHVwICgpIGF0IC4uL2luaXQvbWFpbi5jOjEzNTQNCj4+Pj4+ICAgICAgIzIxIGtlcm5lbF9p bml0X2ZyZWVhYmxlICgpIGF0IC4uL2luaXQvbWFpbi5jOjE1NzENCj4+Pj4+ICAgICAgIzIy IDB4ZmZmZmZmZmY4MWY2NGJlMSBpbiBrZXJuZWxfaW5pdCAodW51c2VkPTxvcHRpbWl6ZWQg b3V0PikgYXQgLi4vaW5pdC9tYWluLmM6MTQ2Mg0KPj4+Pj4gICAgICAjMjMgMHhmZmZmZmZm ZjgxMDAxZjQ5IGluIHJldF9mcm9tX2ZvcmsgKCkgYXQgLi4vYXJjaC94ODYvZW50cnkvZW50 cnlfNjQuUzozMDgNCj4+Pj4+ICAgICAgIzI0IDB4MDAwMDAwMDAwMDAwMDAwMCBpbiA/PyAo KQ0KPj4+Pj4NCj4+Pj4+IEZpeCB0aGUgcHJvYmxlbSBieSBwcmV2ZW50aW5nIHhlbl9ncmFu dF9pbml0X2JhY2tlbmRfZG9taWQoKSBmcm9tDQo+Pj4+PiBzZXR0aW5nIGRvbTAgYXMgYSBi YWNrZW5kIHdoZW4gcnVubmluZyBpbiBkb20wLg0KPj4+Pj4NCj4+Pj4+IEZpeGVzOiAwMzVl M2E0MzIxZjcgKCJ4ZW4vdmlydGlvOiBPcHRpbWl6ZSB0aGUgc2V0dXAgb2YgInhlbi1ncmFu dC1kbWEiIGRldmljZXMiKQ0KPj4+Pg0KPj4+Pg0KPj4+PiBJIGFtIG5vdCAxMDAlIHN1cmUg d2hldGhlciB0aGUgRml4ZXMgdGFnIHBvaW50cyB0byBwcmVjaXNlIGNvbW1pdC4gSWYgSQ0K Pj4+PiBhbSBub3QgbWlzdGFrZW4sIHRoZSBzYWlkIGNvbW1pdCBqdXN0IG1vdmVzIHRoZSBj b2RlIGluIHRoZSBjb250ZXh0DQo+Pj4+IHdpdGhvdXQgY2hhbmdpbmcgdGhlIGxvZ2ljIG9m IENPTkZJR19YRU5fVklSVElPX0ZPUkNFX0dSQU5ULCB0aGlzIHdhcw0KPj4+PiBpbnRyb2R1 Y2VkIGJlZm9yZS4NCj4+Pj4NCj4+Pj4NCj4+Pj4+IFNpZ25lZC1vZmYtYnk6IFBldHIgUGF2 bHUgPHBldHIucGF2bHVAc3VzZS5jb20+DQo+Pj4+PiAtLS0NCj4+Pj4+ICAgICBkcml2ZXJz L3hlbi9ncmFudC1kbWEtb3BzLmMgfCA0ICsrKy0NCj4+Pj4+ICAgICAxIGZpbGUgY2hhbmdl ZCwgMyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pDQo+Pj4+Pg0KPj4+Pj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMveGVuL2dyYW50LWRtYS1vcHMuYyBiL2RyaXZlcnMveGVuL2dyYW50 LWRtYS1vcHMuYw0KPj4+Pj4gaW5kZXggNzZmNmYyNjI2NWEzLi4yOWVkMjdhYzQ1MGUgMTAw NjQ0DQo+Pj4+PiAtLS0gYS9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmMNCj4+Pj4+ICsr KyBiL2RyaXZlcnMveGVuL2dyYW50LWRtYS1vcHMuYw0KPj4+Pj4gQEAgLTM2Miw3ICszNjIs OSBAQCBzdGF0aWMgaW50IHhlbl9ncmFudF9pbml0X2JhY2tlbmRfZG9taWQoc3RydWN0IGRl dmljZSAqZGV2LA0KPj4+Pj4gICAgIAlpZiAobnApIHsNCj4+Pj4+ICAgICAJCXJldCA9IHhl bl9kdF9ncmFudF9pbml0X2JhY2tlbmRfZG9taWQoZGV2LCBucCwgYmFja2VuZF9kb21pZCk7 DQo+Pj4+PiAgICAgCQlvZl9ub2RlX3B1dChucCk7DQo+Pj4+PiAtCX0gZWxzZSBpZiAoSVNf RU5BQkxFRChDT05GSUdfWEVOX1ZJUlRJT19GT1JDRV9HUkFOVCkgfHwgeGVuX3B2X2RvbWFp bigpKSB7DQo+Pj4+PiArCX0gZWxzZSBpZiAoKElTX0VOQUJMRUQoQ09ORklHX1hFTl9WSVJU SU9fRk9SQ0VfR1JBTlQpIHx8DQo+Pj4+PiArCQkgICAgeGVuX3B2X2RvbWFpbigpKSAmJg0K Pj4+Pj4gKwkJICAgIXhlbl9pbml0aWFsX2RvbWFpbigpKSB7DQo+Pj4+DQo+Pj4+IFRoZSBj b21taXQgbGd0bSwganVzdCBvbmUgbm90ZToNCj4+Pj4NCj4+Pj4NCj4+Pj4gSSB3b3VsZCBl dmVuIGJhaWwgb3V0IGVhcmx5IGluIHhlbl92aXJ0aW9fcmVzdHJpY3RlZF9tZW1fYWNjKCkg aW5zdGVhZCwNCj4+Pj4gYXMgSSBhc3N1bWUgdGhlIHNhbWUgaXNzdWUgY291bGQgaGFwcGVu IG9uIEFybSB3aXRoIERUIChhbHRob3VnaCB0aGVyZQ0KPj4+PiB3ZSBkb24ndCBndWVzcyB0 aGUgYmFja2VuZCdzIGRvbWlkLCB3ZSByZWFkIGl0IGZyb20gRFQgYW5kIHF1aXRlDQo+Pj4+ IHVubGlrZWx5IHdlIGdldCBEb20wIGJlaW5nIGluIERvbTAgd2l0aCBjb3JyZWN0IERUKS4N Cj4+Pj4NCj4+Pj4gU29tZXRoaW5nIGxpa2U6DQo+Pj4+DQo+Pj4+IEBAIC00MTYsNiArNDIx LDEwIEBAIGJvb2wgeGVuX3ZpcnRpb19yZXN0cmljdGVkX21lbV9hY2Moc3RydWN0DQo+Pj4+ IHZpcnRpb19kZXZpY2UgKmRldikNCj4+Pj4gICAgIHsNCj4+Pj4gICAgICAgICAgICBkb21p ZF90IGJhY2tlbmRfZG9taWQ7DQo+Pj4+DQo+Pj4+ICsgICAgICAgLyogWGVuIGdyYW50IERN QSBvcHMgYXJlIG5vdCB1c2VkIHdoZW4gcnVubmluZyBhcyBpbml0aWFsIGRvbWFpbiAqLw0K Pj4+PiArICAgICAgIGlmICh4ZW5faW5pdGlhbF9kb21haW4oKSkNCj4+Pj4gKyAgICAgICAg ICAgICAgIHJldHVybiBmYWxzZTsNCj4+Pj4gKw0KPj4+PiAgICAgICAgICAgIGlmICgheGVu X2dyYW50X2luaXRfYmFja2VuZF9kb21pZChkZXYtPmRldi5wYXJlbnQsDQo+Pj4+ICZiYWNr ZW5kX2RvbWlkKSkgew0KPj4+PiAgICAgICAgICAgICAgICAgICAgeGVuX2dyYW50X3NldHVw X2RtYV9vcHMoZGV2LT5kZXYucGFyZW50LCBiYWNrZW5kX2RvbWlkKTsNCj4+Pj4gICAgICAg ICAgICAgICAgICAgIHJldHVybiB0cnVlOw0KPj4+PiAoRU5EKQ0KPj4+Pg0KPj4+Pg0KPj4+ Pg0KPj4+PiBJZiBzbywgdGhhdCBjb21taXQgc3ViamVjdCB3b3VsZCBuZWVkIHRvIGJlIHVw ZGF0ZWQgYWNjb3JkaW5nbHkuDQo+Pj4+DQo+Pj4+IExldCdzIHNlZSB3aGF0IG90aGVyIHJl dmlld2VycyB3aWxsIHNheS4NCj4+Pg0KPj4+IFRoaXMgZG9lc24ndCB3b3JrIGluIGFsbCBj YXNlcy4gSW1hZ2luZSB1c2luZyBQQ0kgUGFzc3Rocm91Z2ggdG8gYXNzaWduDQo+Pj4gYSAi cGh5c2ljYWwiIHZpcnRpbyBkZXZpY2UgdG8gYSBkb21VLiBUaGUgZG9tVSB3aWxsIHJ1biBp bnRvIHRoZSBzYW1lDQo+Pj4gZXJyb3IsIHJpZ2h0Pw0KPj4+DQo+Pj4gVGhlIHByb2JsZW0g aXMgdGhhdCB3ZSBuZWVkIGEgd2F5IGZvciB0aGUgdmlydGlvIGJhY2tlbmQgdG8gYWR2ZXJ0 aXNlDQo+Pj4gaXRzIGFiaWxpdHkgb2YgaGFuZGxpbmcgZ3JhbnRzLiBSaWdodCBub3cgd2Ug b25seSBoYXZlIGEgd2F5IHRvIGRvIHdpdGgNCj4+PiB0aGF0IHdpdGggZGV2aWNlIHRyZWUg b24gQVJNLiBPbiB4ODYsIHdlIG9ubHkgaGF2ZQ0KPj4+IENPTkZJR19YRU5fVklSVElPX0ZP UkNFX0dSQU5ULCBhbmQgaWYgd2UgdGFrZQ0KPj4+IENPTkZJR19YRU5fVklSVElPX0ZPUkNF X0dSQU5UIGF0IGZhY2UgdmFsdWUsIGl0IGFsc28gZW5hYmxlcyBncmFudHMgZm9yDQo+Pj4g InBoeXNpY2FsIiB2aXJ0aW8gZGV2aWNlcy4gTm90ZSB0aGF0IGluIHRoaXMgY2FzZSB3ZSBh cmUgZml4aW5nIGENCj4+PiBuZXN0ZWQtdmlydHVhbGl6YXRpb24gYnVnLCBidXQgdGhlcmUg YXJlIGFjdHVhbGx5IHBoeXNpY2FsDQo+Pj4gdmlydGlvLWNvbXBhdGlibGUgZGV2aWNlcyBv dXQgdGhlcmUuIENPTkZJR19YRU5fVklSVElPX0ZPUkNFX0dSQU5UIHdpbGwNCj4+PiBicmVh ayB0aG9zZSB0b28uDQo+Pg0KPj4NCj4+IElmIHRoZXNlICJwaHlzaWNhbCIgdmlydGlvIGRl dmljZXMgYXJlIGFsc28gc3Bhd25lZCBieQ0KPj4gZHJpdmVycy92aXJ0aW8vdmlydGlvLmM6 dmlydGlvX2Rldl9wcm9iZSgpLCB0aGVuIHllcywgb3RoZXJ3aXNlIEkgZG9uJ3QNCj4+IHNl ZSBob3cgdGhpcyBjb3VsZCBldmVuIGJlIHBvc3NpYmxlLCBidXQgSSBtaWdodCBtaXNzIHNv bWV0aGluZyBoZXJlLg0KPiANCj4gWWVzLCBJIHdvdWxkIGltYWdpbmUgdmlydGlvX2Rldl9w cm9iZSgpIHdvdWxkIGJlIGNhbGxlZCBmb3IgdGhlbSB0b28NCj4gDQo+IA0KPiANCj4+IHhl bl92aXJ0aW9fcmVzdHJpY3RlZF9tZW1fYWNjKCkgZ2V0cyBjYWxsZWQgaW5kaXJlY3RseSBm cm9tDQo+PiB2aXJ0aW9fZGV2X3Byb2JlKCktPnZpcnRpb19mZWF0dXJlc19vaygpLT4NCj4+ IHZpcnRpb19jaGVja19tZW1fYWNjX2NiKCkuIFNvIHRoZSBYZW4gZ3JhbnQgRE1BIG9wcyBh cmUgb25seSBpbnN0YWxsZWQNCj4+IGZvciB0aG9zZS4NCj4+DQo+Pg0KPj4+DQo+Pj4gSSB0 aGluayB3ZSBuZWVkIHRvIGFkZCBhIHNlY29uZCB3YXk/IEl0IGNvdWxkIGJlIGFueXRoaW5n IHRoYXQgY2FuIGhlbHANCj4+PiB1cyBkaXN0aW5ndWlzaCBiZXR3ZWVuIGEgbm9uLWdyYW50 cy1jYXBhYmxlIHZpcnRpbyBiYWNrZW5kIGFuZCBhDQo+Pj4gZ3JhbnRzLWNhcGFibGUgdmly dGlvIGJhY2tlbmQsIHN1Y2ggYXM6DQo+Pj4gLSBhIHN0cmluZyBvbiB4ZW5zdG9yZQ0KPj4+ IC0gYSB4ZW4gcGFyYW0NCj4+PiAtIGEgc3BlY2lhbCBQQ0kgY29uZmlndXJhdGlvbiByZWdp c3RlciB2YWx1ZQ0KPj4+IC0gc29tZXRoaW5nIGluIHRoZSBBQ1BJIHRhYmxlcw0KPj4+IC0g dGhlIFFFTVUgbWFjaGluZSB0eXBlDQo+Pg0KPj4NCj4+IFllcywgSSByZW1lbWJlciB0aGVy ZSB3YXMgYSBkaXNjdXNzaW9uIHJlZ2FyZGluZyB0aGF0LiBUaGUgcG9pbnQgaXMgdG8NCj4+ IGNob29zZSBhIHNvbHV0aW9uIHRvIGJlIGZ1bmN0aW9uYWwgZm9yIGJvdGggUFYgYW5kIEhW TSAqYW5kKiB0byBiZSBhYmxlDQo+PiB0byBzdXBwb3J0IGEgaG90cGx1Zy4gSUlSQywgdGhl IHhlbnN0b3JlIGNvdWxkIGJlIGEgcG9zc2libGUgY2FuZGlkYXRlLg0KPiANCj4geGVuc3Rv cmUgd291bGQgYmUgYW1vbmcgdGhlIGVhc2llc3QgdG8gbWFrZSB3b3JrLiBUaGUgb25seSBk b3duc2lkZSBpcw0KPiB0aGUgZGVwZW5kZW5jeSBvbiB4ZW5zdG9yZSB3aGljaCBvdGhlcndp c2UgdmlydGlvK2dyYW50cyBkb2Vzbid0IGhhdmUuDQoNCkknbSBpbiBmYXZvciBvZiB1c2lu ZyB4ZW5zdG9yZS4gRXNwZWNpYWxseSB0aGUgaG90cGx1ZyBzdXBwb3J0IHdvdWxkIGJlDQpt dWNoIGVhc2llciB1c2luZyB4ZW5zdG9yZSAodGhlIGFsdGVybmF0aXZlIHdvdWxkIGJlIEFD UEksIHdoaWNoIEkgZG9uJ3QNCnRoaW5rIHdlIHdhbnQgZm9yIFBWIGd1ZXN0cyBvciBtYW55 IEFybSBjb25maWd1cmF0aW9ucykuDQoNCg0KSnVlcmdlbg0K --------------W7OmSDerYdL9ey1DQ9qTYn1B Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------W7OmSDerYdL9ey1DQ9qTYn1B-- --------------STn05AdcU5bge70lDfUXtYfY-- --------------90RvH73Xi3vYjwiAKZs06GnN Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmSju1EFAwAAAAAACgkQsN6d1ii/Ey9Z 8gf8CZDmIy6ODm7xebD8YeeabCWV1Hcc9/xof/0/fUBQFOJaRi7b2LJXFqQuWchw63v3gRHsPZqj RrdOup2UxFtYLC2ZQDsjBqvFW1tf/NXlaFC00KBfHQd4tez/zpTlt4Y0AEEt98vCdd4DTcibnn1i VL2bzyABH8huZTbdkn8n2vOJJzdHTR87gJrUod886ppM6b/3IPom6Kxq0xjmM712s2/7lMv7Cwg7 NM62DVpOCfbFcgHMWaCAC9XI3ccwvicTV/rXWbhhjebPCJCT5GC8l3H2hYfYRWLxKng42GOyAzOv gsazPRmy6/PwFe3aERrrxmirz2BerfA2uZ5uDLergA== =rBab -----END PGP SIGNATURE----- --------------90RvH73Xi3vYjwiAKZs06GnN-- From xen-devel-bounces@lists.xenproject.org Tue Jul 04 07:02:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 07:02:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558173.872034 (Exim 4.92) (envelope-from ) id 1qGa3R-0001cx-4X; Tue, 04 Jul 2023 07:02:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558173.872034; Tue, 04 Jul 2023 07:02:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGa3R-0001cq-19; Tue, 04 Jul 2023 07:02:29 +0000 Received: by outflank-mailman (input) for mailman id 558173; Tue, 04 Jul 2023 07:02:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGa3P-0001ck-Jq for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 07:02:27 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ba19e9a9-1a38-11ee-8611-37d641c3527e; Tue, 04 Jul 2023 09:02:24 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5E92B224C5; Tue, 4 Jul 2023 07:02:23 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1C182133F7; Tue, 4 Jul 2023 07:02:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4NFmBf/Do2TKAQAAMHmgww (envelope-from ); Tue, 04 Jul 2023 07:02:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ba19e9a9-1a38-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1688454143; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I2wmCXpl436Dp8ZP2JM7afvCQOhr1hfCC2vxh1ZCMho=; b=bn443TypRb0QJOcKUIKKDBJ9iTJpFltDCrtc+5qGKaxTKetUK7xwPl8YdC5TXKW5atUxYM XF89NTrHY0zxyeqHS0SZElzSum7Qx+ZiM1PDIgHWs5N+H51231BYHgHnCHrTiz7UOp3QSL WY6oBYdrHUb3H3DRJkYT5WX38FvyP94= Message-ID: <0a05588e-68d3-1550-4c21-e282f4d66060@suse.com> Date: Tue, 4 Jul 2023 09:02:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: Demi Marie Obenour , Stefano Stabellini , Oleksandr Tyshchenko , Jan Beulich , Konrad Rzeszutek Wilk Cc: Xen developer discussion , Linux Kernel Mailing List , stable@vger.kernel.org References: <20230627172216.1359-1-demi@invisiblethingslab.com> From: Juergen Gross Subject: Re: [PATCH v3] xen: speed up grant-table reclaim In-Reply-To: <20230627172216.1359-1-demi@invisiblethingslab.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------MNrRNEu0Gn5vUM6zQYoVYHAv" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------MNrRNEu0Gn5vUM6zQYoVYHAv Content-Type: multipart/mixed; boundary="------------B37XGpMk5E2SqDCYefhE8oq7"; protected-headers="v1" From: Juergen Gross To: Demi Marie Obenour , Stefano Stabellini , Oleksandr Tyshchenko , Jan Beulich , Konrad Rzeszutek Wilk Cc: Xen developer discussion , Linux Kernel Mailing List , stable@vger.kernel.org Message-ID: <0a05588e-68d3-1550-4c21-e282f4d66060@suse.com> Subject: Re: [PATCH v3] xen: speed up grant-table reclaim References: <20230627172216.1359-1-demi@invisiblethingslab.com> In-Reply-To: <20230627172216.1359-1-demi@invisiblethingslab.com> --------------B37XGpMk5E2SqDCYefhE8oq7 Content-Type: multipart/mixed; boundary="------------xtWTFltP0EaZv0PU6Wx3Xf2W" --------------xtWTFltP0EaZv0PU6Wx3Xf2W Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjcuMDYuMjMgMTk6MjIsIERlbWkgTWFyaWUgT2Jlbm91ciB3cm90ZToNCj4gV2hlbiBh IGdyYW50IGVudHJ5IGlzIHN0aWxsIGluIHVzZSBieSB0aGUgcmVtb3RlIGRvbWFpbiwgTGlu dXggbXVzdCBwdXQNCj4gaXQgb24gYSBkZWZlcnJlZCBsaXN0LiAgTm9ybWFsbHksIHRoaXMg bGlzdCBpcyB2ZXJ5IHNob3J0LCBiZWNhdXNlDQo+IHRoZSBQViBuZXR3b3JrIGFuZCBibG9j ayBwcm90b2NvbHMgZXhwZWN0IHRoZSBiYWNrZW5kIHRvIHVubWFwIHRoZSBncmFudA0KPiBm aXJzdC4gIEhvd2V2ZXIsIFF1YmVzIE9TJ3MgR1VJIHByb3RvY29sIGlzIHN1YmplY3QgdG8g dGhlIGNvbnN0cmFpbnRzDQo+IG9mIHRoZSBYIFdpbmRvdyBTeXN0ZW0sIGFuZCBhcyBzdWNo IHdpbmRzIHVwIHdpdGggdGhlIGZyb250ZW5kIHVubWFwcGluZw0KPiB0aGUgd2luZG93IGZp cnN0LiAgQXMgYSByZXN1bHQsIHRoZSBsaXN0IGNhbiBncm93IHZlcnkgbGFyZ2UsIHJlc3Vs dGluZw0KPiBpbiBhIG1hc3NpdmUgbWVtb3J5IGxlYWsgYW5kIGV2ZW50dWFsIFZNIGZyZWV6 ZS4NCj4gDQo+IFRvIHBhcnRpYWxseSBzb2x2ZSB0aGlzIHByb2JsZW0sIG1ha2UgdGhlIG51 bWJlciBvZiBlbnRyaWVzIHRoYXQgdGhlIFZNDQo+IHdpbGwgYXR0ZW1wdCB0byBmcmVlIGF0 IGVhY2ggaXRlcmF0aW9uIHR1bmFibGUuICBUaGUgZGVmYXVsdCBpcyBzdGlsbA0KPiAxMCwg YnV0IGl0IGNhbiBiZSBvdmVycmlkZGVuIGF0IGNvbXBpbGUtdGltZSAodmlhIEtjb25maWcp LCBib290LXRpbWUNCj4gKHZpYSBhIGtlcm5lbCBjb21tYW5kLWxpbmUgb3B0aW9uKSwgb3Ig cnVudGltZSAodmlhIHN5c2ZzKS4NCg0KWW91IGFyZSBzdGlsbCBtZW50aW9uaW5nIEtjb25m aWcuDQoNCkZvciB0aGUgc3lzZnMgZW50cnkgeW91IHNob3VsZCBhZGQgc29tZXRoaW5nIHVu ZGVyIERvY3VtZW50YXRpb24vQUJJLiBTb3JyeQ0KSSBkaWRuJ3Qgc3BvdCB0aGlzIG9taXNz aW9uIHByZXZpb3VzbHkuDQoNCg0KSnVlcmdlbg0K --------------xtWTFltP0EaZv0PU6Wx3Xf2W Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------xtWTFltP0EaZv0PU6Wx3Xf2W-- --------------B37XGpMk5E2SqDCYefhE8oq7-- --------------MNrRNEu0Gn5vUM6zQYoVYHAv Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmSjw/4FAwAAAAAACgkQsN6d1ii/Ey86 +Qf7BVc79+MQbLa9SjzT0G9ygKhf8N61XHUt58BIVHzXuBPyl08NthIgPjR1XAkwDhjb9gk1TFTR thYepMpEXviC9KuSUeNiVJ0Z64VobeQ2cCuyQ7r6MHWJSLZLtjXjH3/bXnEwXe03k0pZ3Qt0HM+1 aObCnEc26vVpbkc4tmU3W0OlZDq7w9QkVZG21qm8c+GSx3UYTQkfBE5/4s6gisF1+tDinDY0cif7 Nynh+/Ga+5bkhQ5EPHL3CXNZNtmRvzzA/SEWXAlHKEdH7JpQpwUskbzQqoBCWnk58U1np22t7VWt qKPso3z45GZxSU6UYw8i6hMOjgi0SkEmiIVTXXvI4g== =3vJC -----END PGP SIGNATURE----- --------------MNrRNEu0Gn5vUM6zQYoVYHAv-- From xen-devel-bounces@lists.xenproject.org Tue Jul 04 07:49:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 07:49:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558179.872044 (Exim 4.92) (envelope-from ) id 1qGamg-0006As-Of; Tue, 04 Jul 2023 07:49:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558179.872044; Tue, 04 Jul 2023 07:49:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGamg-0006Al-KS; Tue, 04 Jul 2023 07:49:14 +0000 Received: by outflank-mailman (input) for mailman id 558179; Tue, 04 Jul 2023 07:49:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGame-0006Af-W5 for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 07:49:13 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 41b22d16-1a3f-11ee-8611-37d641c3527e; Tue, 04 Jul 2023 09:49:10 +0200 (CEST) Received: from mail-mw2nam10lp2103.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.103]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Jul 2023 03:49:02 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by PH0PR03MB6590.namprd03.prod.outlook.com (2603:10b6:510:bd::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 07:49:00 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::1c83:1877:a68b:8902]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::1c83:1877:a68b:8902%7]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 07:49:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 41b22d16-1a3f-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1688456949; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=WxKuljUVJZ+NeCazNlKEO+PnHvhTo0CW79MzopQi7mM=; b=FuU8ByiMPRrXYdYJdem+ZQF1vvqJPLlCqseJ2o28HFguuJU1USJZ5H8Z vTkss9OnzYr85s87q4YzpUdTBj3yt6AZTDM+OARTcWANMnPjytsrLDUk4 bc54rO8133pcA8fdbWuE1ythexgN2/LVWMkCU/GTzaPpl9mYbOH1T1eaa I=; X-IronPort-RemoteIP: 104.47.55.103 X-IronPort-MID: 114385826 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:lj+2NasM3pi0McIvwrKA+V1hZ+fnVMRfMUV32f8akzHdYApBsoF/q tZmKTjTO/iCamD2e4txPYjnpB8H68Pcx4RiQVdsqyg1EH4U+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4rKq4Vv0gnRkPaoQ5ACGyyFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwKDsKfjaEvseMkaOBEq5jgu4Bc+u2BdZK0p1g5Wmx4fcOZ7nmGv2PwOACmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osjf60aIG9lt+iHK25mm6Co W3L5SLhCwwyP92D0zuVtHmrg4cjmAuiAd5JRODorKACbFu71mhNIQw5anKBv+SGmFPhacoPL BU49X97xUQ13AnxJjXnZDWju2KNtBMYX9tWEsU55RuLx66S5ByWbkAjSjNCc9UguNUBeS0x1 lSJktXqAhRiqLSQD3ma89+8tT6uI24NJHEGeAcfUBAIpdLkpekbnh/JC9puDqOxptn0Ai3rh SCHqjAkgLcehtJN0L+0lXjDgjSxtt3KQxQz6wH/QG2o9EV6aZSjaoju7kLUhd5CI5yeVUKpp 2Uflo6V6+VmJY+MlzaERaMCFaup+P+BGDTZjRhkGJxJyti203uqfIQV5S4kIk5sa54AYWWwO BSVvh5N7phOOnfsdbVwf4+6F8Uty+7nCMjhUffXKNFJZ/CdaTO6wc2nXmbIt0iFraTmufhX1 UuzGSp0MUsnNA== IronPort-HdrOrdr: A9a23:GbkrGaB4LG68f0XlHenP55DYdb4zR+YMi2TDtnoQdfUxSKelfq +V8cjzuSWftN9zYhAdcK67V5VoKEm0naKdirN8AV7NZmfbhFc= X-Talos-CUID: =?us-ascii?q?9a23=3Aguv1EWkgD0+17tbxUQrb/4PDgH7XOX3Wy2f2JHa?= =?us-ascii?q?dMzd4cuXSRlu62vxGzvM7zg=3D=3D?= X-Talos-MUID: 9a23:rv/wGwbH5Mxtz+BTpzuyrSBNC+5S/bmRGl1So41WvJCoOnkl X-IronPort-AV: E=Sophos;i="6.01,180,1684814400"; d="scan'208";a="114385826" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=noPbFuZq2gBGRC6Kwlu74kZYUK6JMkcvfl4XZlikXNlpbL+tMFhEy1tiQuTCIj/ZJhAFwxfEY7zqE5hVN/KHHtcIDfWWbdCnhfhi3nbr0lcbjRLcbnKEDWJ9bhNvIVdL3xQNmQ/Snam26G0Bx9avzd949kv0KP1+jJyPlX3oprx8eUJCUDVYRUYBShcLl98xlX/NNFbBtbsr6RJ2RgWQLl5NhqZN3kUITZhapA04zxKfSfnUgUqoaSWTR3uxU2D4jh157PGvYQEhVZ6vxDdyT/piOZnKAUA1IpyXPl8gKS8i3rab6kSOJpCke3i6swZSnH9qN2+Py0Aet6wvODhAFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rVM7JbmkIJt65OkIbFHrsl4m6lh9mPKw/yEp9eXztFk=; b=AB0QPEZOIOoitfUMG51E3o99wMRWIdODrQYEiE8jaOL2KccFefkurpviTs9Xv1rfTJr4RvKGTwNPrZZW3+yPlsc3a+CYJ33zLDOBz4dq0jamQKQgxQDfV4uHxbx3fImonMJqZ+5NzuJhHoPTpLLgfvZYMumnLi6D7hNfTYrhXa3ZGFnAKQeiVW2r3mQvqhCRC9txLDrCMd0x4CvPrlg21mbtCuACAHFthJsOl/LgzUWV8GUVovvXtrYqPajikUMQJ5lhnKcT/sJjMs9bB2SPDTR+mJp25OVyA5nqX4oDKFSZeYeLgVRPUeDo4g0rCTp6vd04+R37KY/FDgsvb7JcZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rVM7JbmkIJt65OkIbFHrsl4m6lh9mPKw/yEp9eXztFk=; b=Uldcv0RvLtbmYo823umlDPlQt5mjNxJxjssp+zhwI3yo7tCTnzBiLn7hWkysl2O5Cu0b/ixR0HKkWbKyXeYrw6MKqyI3/l1YIAwzIpIVaV8YKA32+hRDTpq2PmiL1QEz7hsIrcqSrLuZa48EKB3MlYfsiU1srD/SoQj3KVwR1IU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 4 Jul 2023 09:48:53 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Stefano Stabellini Cc: Oleksandr Tyshchenko , Petr Pavlu , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" , "jgross@suse.com" , vikram.garhwal@amd.com Subject: Re: [PATCH 2/2] xen/virtio: Avoid use of the dom0 backend in dom0 Message-ID: References: <20230621131214.9398-1-petr.pavlu@suse.com> <20230621131214.9398-3-petr.pavlu@suse.com> <15e31609-6c45-7372-76ee-0adf7a64fe88@epam.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO2P265CA0279.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::27) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|PH0PR03MB6590:EE_ X-MS-Office365-Filtering-Correlation-Id: 7b2e5bb6-27a8-4058-fb47-08db7c6320ce X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XPPMGRWwpxg19TNdXgrqP82zwiN3uB3xyd6xF72A3RoObCNVCJSS1l4z058NmJO2m1LeBdW171nX3I45M6MAQu6RNPmclEQ2OKBvdLgdCHJ76jJLTtHXEzYSsJVVuRk9+eeVGk/PGA3c/qLiP2QINABEdX0rcJiRvemwBs5urjruaer3caW10OWJtNOcRPFLbEZlLwYODGOS/Jl99uUnbBBJyp6CP9oEIlTi8NfVtzVOSh6OX8LlNOlg2xsF9Su/XYF74TIDF2XtSFIdjWwnvN8SkMJkuiS5KqvrEVP1jsY0EGjn1oQjlaSvNa2JE9xsycOPJqjUmpeJ5Bvfq2IMdz9KJ99ucovk3uuSq6vnUNpkq229OmUkjLZhPHQzium8eZfYLK7Sjy6xGIOu/S0e/gVVrqmHx5zmzh7RniOjkrCrGXXJboAG+zIWgpHRvwnwdpHkRLgyrfxVMquPYFDEsqkwMlfhlRAp3QYH/gmNG1PJNlqokYz3BEEkRLPi3/HHNR2x9SNs8YopslXjX9wj+0htX8Y/pA/932l+CgS8q7GFo8i7YoR5AEKh513KXOgu X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(396003)(136003)(39860400002)(346002)(376002)(451199021)(2906002)(41300700001)(8936002)(8676002)(85182001)(5660300002)(86362001)(186003)(478600001)(26005)(6506007)(6512007)(9686003)(6666004)(82960400001)(53546011)(6486002)(316002)(6916009)(66556008)(4326008)(66946007)(38100700002)(54906003)(66476007)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3k2cEdYTGExdmE3R0Y1enBNakY1WHhTRW9vdDlzSCtnNU1SbGovZnBEb1pi?= =?utf-8?B?Y2FpVzF5N1FiL3RaMDFrRWx3U002dXpqK0NpNkw2U05mWkpPRmlEcXNtVHZw?= =?utf-8?B?VVVyQ0lIM1JYZ1VVRHdhcEpwcGRWdDNrSlREdXFwaExUb3Fodm9EN0YyUVFz?= =?utf-8?B?VWI2MGtVZm11cUYzVEtnd2JSUlNYYnY5RGovQnZWQ0xRNjZlYm95Nmt4d25V?= =?utf-8?B?Z0c2MTQrSXRjWXhlblh0dkVaajc1bndIaU12Z1l6bm14SXZwRVdBQmdINlpm?= =?utf-8?B?cWdRODBUSE85dStZeHpzWW5yNDJrRjJCcytGN1N4T1F4bjJsaDVvckFLK0Jt?= =?utf-8?B?eWxOZW5PZ2RXYTkwclJVTTNVV1VyaU0yVkZJNVdoVTJKY0l1aW01eUtlN25P?= =?utf-8?B?RW04bGRJWHhxZzhRaXQrOGtkOHhRYnNaV012cHJRQXFvdXNndlhJaDhCZGI4?= =?utf-8?B?TG9YQjF0RmJNblI2cm1hemJ3ejU1dW9ERTYvMStNZm1kbVY5MmV2NW5EdXVU?= =?utf-8?B?bVNUR1MxS3pQRHdDZGkvQk5Uc292cUljY2tFcTBNOHdNcWtpNTJzRTNGWFZK?= =?utf-8?B?NE1lZERPUWNNNzJtYzRSdXgzd2g5eGNZUWNpRzk2MXpET0I1RFYxMXFUTjJV?= =?utf-8?B?d3BRNDJtNjVlTDNmVmtSNmRGdlBOM056QStyVERrOXdjUzY4U016cmVmbmk2?= =?utf-8?B?QW9xc2ljaXNNU2toNC8rSHRXSU5JUlA2TVlrY2RkZGd0NHlmdDRHeXRLeHBQ?= =?utf-8?B?ZzZWeWowVG0wcm9mT0VKMUZCR2FERzJjTzRBWmFaMytvL29wOHdrVlVacWNK?= =?utf-8?B?TzJBRkVHNFk1RnE0Vlo1ekdqUS9ZWC93SFdZM0pjbCtQSExvQTBxeFI4cXJ6?= =?utf-8?B?N2ZZWFNnbFJraFprN0VyYmNNY0loRUp2MXY3WFdadjZseDkxMjRaVDNPZUsr?= =?utf-8?B?emlzVzRkTVNsOUZNZ0owZmpXRWthakpVdUhNNVJxOFF5UU56WnliQkNTVHZ1?= =?utf-8?B?MVRmMHNDU3A3WG9KUHF2MWZFRXpDcWVtSlI0NEg3M3NvWEdoSjMyc2FyaERW?= =?utf-8?B?ZWRtRzBuNmlwZGVNR2ovUE44cmp6WGF3U1U2WGVWTHkxMG1INXpkdTlPZDU1?= =?utf-8?B?NVlEQTQzRHk5UVlEbEtISDlaME81aU9FNkxIczNlUE1GNHFsaVdtK3NHSzNq?= =?utf-8?B?dzFMSUpwMVRhOE5pMHhOVFZaS3RVeU9sbnpQaXdKOHUvN1BHK3FqYzVWOUlU?= =?utf-8?B?N2JkSDUzS2NyajlmSThmZ3VmVVl5L3YvVTRUWlphcldzWitmSXJxM2xTUFF4?= =?utf-8?B?RzFBUUxaQlRTNkV5YUxXNTZRMjB0dkE0Q3dxaXRteWxCVDdpRHlkZTIzeHVp?= =?utf-8?B?V3F1MUVFK20vR1RRajNGaURHbWdwZTRzSDloV1FDQmdRVHpObUI4MnNFV2hW?= =?utf-8?B?bXM3T0ZCeG9mZkcyMDhvM242YnBhVyszY3RLcnVTSXVKSncrdjdxdEJyUG4v?= =?utf-8?B?ZEVjQ3ZCcUsyYUZWWHlYWFJENTdYcWhwK1VUZDVzZDlMOVFMKzgrWDVKZWpm?= =?utf-8?B?cFlhdE1GVmIrZExkTTF0TS9Obi9IQlhvUDJMSU5GZ1JVVWljWVlTZUVsMXla?= =?utf-8?B?djljT0pjWGFyVm5CSHk5Z005SmNLUnJiQU9hWTVyU3VxK0NmVXQ4TUJVcktk?= =?utf-8?B?OStjT3VHSyt2RzQ0Nlp6RExEMzdibk03K3Zobk01eGk0NC9xNCswR0g4SWlr?= =?utf-8?B?NFpnN1k0a3J4TGJxZFpTajdOSXBTSFJYNEZ6OUVDdEluNEwwS2lkSXNOUjdJ?= =?utf-8?B?WkRKOXJCTWZkemxSODl1ZHRTRmFWZTVyMitaMUhCMzVRUFUrSnhKNUEwL2RY?= =?utf-8?B?UWV1M2NkaWxKT1FjQ1hOcXUxTzRra2pwNUkybjU0aXRndlBwQnZLb2EyZzRJ?= =?utf-8?B?SFRNOXdsK3FQNjQ3eStVZURjaXNNSkNKazlWTHBSQXN2RWVNZzJTczMvQzFs?= =?utf-8?B?dHVhWHhNU29ZZ1A4YzdtbDRVY1Mvb2wra3RpK1JXRmpDQXp0c0wwR1lycE4x?= =?utf-8?B?Z05KUXlhUEZwWldFOTh6SVVtNXBQS1pORWtjeWVaajVTb3BjL3NLZ01RSWJM?= =?utf-8?Q?DDjsh9gtnIrMKZ6UhhDgdxPbq?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: jTcxuEXcNjkNjNiQLxMzGf/RZCikpJlwQ115HQZ677f+Edp8TIVAMpyZNfaGuTHbzF1NnTWtyjEfPxC4Xrs33mcetDlbqHxkJCwf+K+S/uiKk7QIXBJYLSIMXdIJFrBtP1XaWqGskcu8wmG6oZ5J6xY0CJ1RJWjfRVwS3416yrszDngyGtBc9PJQoI44gQ+NKMDmp2iFWEqyXcW64jHvTBS86Nd+koqBWs9UE9MFagpbYBR76OdYwVEob031wV7+DUkx8ocAA7QG2HjcNf9YDs4KGGoC7Po1iidaSGNBwdPYKI3QuFUvCsZD7ScLNXQTyeNCBwQ+xBf/H3uK4cdutATNRq5ZBI+CAElsfKGnIbN48PfHqVUgHi2pRU1xSW+ozwrs2S5AHedRkst3OOKf5iqGXjgtr4zwgxbCyhOL8e5WrIDOdiAMdPmQ0FrTyzLBkkxmzR8xAQvZKR5Wfhw2EUajrxQWBXPA7ccQiNFYibIZ+wS27bi26b4qVJS5jjI+IUtazTUWrA2oqDiPnG44dVZ/cR1ZWWzHedttR+apXfjIUsWDEDzbBcFjWYpa6ZOo7JcpST4GXYY0ABkLrN30bnjlqaqgKkaabROHCjVHp38NzXZ+ZJhJGOUeATAW83Jcg60VG59gXJ3wkzEqWT9qqsfNx2xF4dV9gfTLz+DJQsljMnMNE2Rnw66M3JSL1IQCbhSHWwVMkHTLkdzPGKGbho7pqmo94YmonokpPmADQO5hcdMkCPAUjf7JUJGsRlUsyznRWnkKvj2nMuBFwLaTe3FyvHUiS+jcMDZWN3OLQolhKqVf1tdYnuEFv80vIiESb2ZDDa5UuOMHIIdiq/cQdFR1v3HqqNy4TbSW1OpbZemOVrzJljB7TknyHGKP+ObvlGfqBEId1GWXcS+HwEnwTBuUjumVYa/SuJHH/9DRI0I= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b2e5bb6-27a8-4058-fb47-08db7c6320ce X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 07:49:00.0683 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /tL/1gYU9NmIv1ItM1+6V9i3uMXtQZHkb5cQhsUh1MqwsJhdncuSe+jGbez7ze6XRYybNBlrSbksd0sL+pS/lw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6590 On Thu, Jun 29, 2023 at 03:44:04PM -0700, Stefano Stabellini wrote: > On Thu, 29 Jun 2023, Oleksandr Tyshchenko wrote: > > On 29.06.23 04:00, Stefano Stabellini wrote: > > > I think we need to add a second way? It could be anything that can help > > > us distinguish between a non-grants-capable virtio backend and a > > > grants-capable virtio backend, such as: > > > - a string on xenstore > > > - a xen param > > > - a special PCI configuration register value > > > - something in the ACPI tables > > > - the QEMU machine type > > > > > > Yes, I remember there was a discussion regarding that. The point is to > > choose a solution to be functional for both PV and HVM *and* to be able > > to support a hotplug. IIRC, the xenstore could be a possible candidate. > > xenstore would be among the easiest to make work. The only downside is > the dependency on xenstore which otherwise virtio+grants doesn't have. I would avoid introducing a dependency on xenstore, if nothing else we know it's a performance bottleneck. We would also need to map the virtio device topology into xenstore, so that we can pass different options for each device. > Vikram is working on virtio with grants support in QEMU as we speak. > Maybe we could find a way to add a flag in QEMU so that we can detect at > runtime if a given virtio device support grants or not. Isn't there a way for the device to expose capabilities already? For example how does a virtio-blk backend expose support for indirect descriptors? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Jul 04 09:29:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 09:29:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558189.872054 (Exim 4.92) (envelope-from ) id 1qGcLd-0000HZ-4a; Tue, 04 Jul 2023 09:29:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558189.872054; Tue, 04 Jul 2023 09:29:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGcLd-0000HS-1G; Tue, 04 Jul 2023 09:29:25 +0000 Received: by outflank-mailman (input) for mailman id 558189; Tue, 04 Jul 2023 09:29:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGcLc-0000Gl-Bk for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 09:29:24 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 409f4fbf-1a4d-11ee-8611-37d641c3527e; Tue, 04 Jul 2023 11:29:20 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 409f4fbf-1a4d-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1688462960; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ecB0iOwB6Af2HwnYBz9C/QeRWz5MlTffw9iyZWO+Nps=; b=S3W5qaS/OxruHi/jR99ZIjKdydGX7Tt88HMSzRPKXNway+rgIuFpssqq O0GXdPYmkFLDuId5WgT4rZVEjMRv0M9Ye4ela9XQOvsi9JzpeJQQzdlHE 0bF091M1JQITelA7UKFh92XeNs2+Mu1TZr+Vv91253RnDqo+ISF2Mgmc8 c=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 117657058 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:9ecr0qynbHgdTSVdkZJ6t+dNxirEfRIJ4+MujC+fZmUNrF6WrkUHz GodCmGBPauIZGWgftp+Pdywp0oE7JLczdZjSFdr+yAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw/zF8EoHUMja4mtC5QRhPawT5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KWJC6 cEVAypWUjegptO2/o2lV/But+12eaEHPKtH0p1h5TTQDPJgSpHfWaTao9Rf2V/chOgXQ6yYP ZBAL2MyMlKZOUYn1lQ/UfrSmM+BgHXlfiIeg1WSvactuEDYzRBr0airO93QEjCPbZwMwRjF+ TqbrwwVBDlFLIODxQOHyEmHl/XrxgnbfZ4LBIG3o6sCbFq7mTVIVUx+uUGAiem0jAuyVsxSL 2QQ+zEytu4i+UqzVN7/Uhak5nmesXY0efBdDuk74wGl0bfP7kCSAW1sZiFFQMwrsokxXzNC6 7OSt4q3X3o16uTTEC/DsO7O9lteJBT5M0cBaTM5QCAfuOXEg6ACjizwUMt6Ep+c24id9S7L/ 9yakMQvr+xN3Z5XifzmrACvbyGE/caQEFNsjunDdif8t14iOtb4D2C9wQKDhcusOrp1WbVoU JIsv8GFpN4DApiW/MBmaLVcRer5jxpp3dC1vLKOI3XC3273k5JbVdoMiAyS3W8wWir+RRfnY VXIpSRa74JJMX2hYMdfOtzhW5hynPK5S4i5B5g4i+aihbAoJWe6ENxGPxbMjwgBbmBx+U3AB XtrWZn1VitLYUiW5DG3W/0cwdcWKtMWnAvuqWTA503/i9K2PSfFIYrpxXPSNojVGovY+lSKm zueXuPWoyhivBrWOXaHqdJKdQ9WdhDWx/ne8qRqSwJKGSI+cElJNhMb6elJl1BN90iNqtr1w w== IronPort-HdrOrdr: A9a23:KUMiE6G8N667OOz1pLqEU8eALOsnbusQ8zAXPo5KKCC9Ffbo8f xG/c5rsiMc7Qx6ZJhOo7290cW7LU80sKQFgrX409+ZLXXbUSiTXfxfBbKL+UyeJ8SGzJ8i6U 4DSchD4azLfDxHZJ3BkXCF+r8bqbHtzEnrv5a9854Kd25XgspbnmJE42igfHGebTM2dKYRJd 6z5tdnuzHlQngedMK9b0N1JdTrlpnklI/GfRVDPBIs6BCPgTS0gYSKaCSw71MxUy5v3bxnym TOkxX46qK/99m3xwTRzXW71eUnpPLRjvVCGe2RgYwuJjLghh3AXvUYZ4G/ X-Talos-CUID: 9a23:t9UWiW1elbo3D2Z3OhY2A7xfGcw5T3D21izsBGyZOGZXd6OIUF2h0fYx X-Talos-MUID: 9a23:lx/+yQvPwams6IWb9s2n2yk9KMtR4Z6VI1EXtc4sm+yYLDxMNGLI X-IronPort-AV: E=Sophos;i="6.01,180,1684814400"; d="scan'208";a="117657058" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2] xen: Correct comments after renaming xen_{dom,sys}ctl_cpu_policy fields Date: Tue, 4 Jul 2023 10:29:09 +0100 Message-ID: <20230704092909.3635899-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230629102600.61262-1-andrew.cooper3@citrix.com> References: <20230629102600.61262-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Fixes: 21e3ef57e040 ("x86: Rename {domctl,sysctl}.cpu_policy.{cpuid,msr}_policy fields") Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu v2: * Fix domctl too. --- xen/include/public/domctl.h | 6 ++---- xen/include/public/sysctl.h | 10 ++++------ 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h index e2e22cb534d6..a33f9ec32b08 100644 --- a/xen/include/public/domctl.h +++ b/xen/include/public/domctl.h @@ -679,10 +679,8 @@ struct xen_domctl_set_target { * Query or set the CPUID and MSR policies for a specific domain. */ struct xen_domctl_cpu_policy { - uint32_t nr_leaves; /* IN/OUT: Number of leaves in/written to - * 'cpuid_policy'. */ - uint32_t nr_msrs; /* IN/OUT: Number of MSRs in/written to - * 'msr_policy' */ + uint32_t nr_leaves; /* IN/OUT: Number of leaves in/written to 'leaves' */ + uint32_t nr_msrs; /* IN/OUT: Number of MSRs in/written to 'msrs' */ XEN_GUEST_HANDLE_64(xen_cpuid_leaf_t) leaves; /* IN/OUT */ XEN_GUEST_HANDLE_64(xen_msr_entry_t) msrs; /* IN/OUT */ diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h index 9d06e92d0f6a..33e86ace5140 100644 --- a/xen/include/public/sysctl.h +++ b/xen/include/public/sysctl.h @@ -1047,12 +1047,10 @@ struct xen_sysctl_cpu_policy { #define XEN_SYSCTL_cpu_policy_pv_default 4 #define XEN_SYSCTL_cpu_policy_hvm_default 5 uint32_t index; /* IN: Which policy to query? */ - uint32_t nr_leaves; /* IN/OUT: Number of leaves in/written to - * 'cpuid_policy', or the maximum number of leaves - * if the guest handle is NULL. */ - uint32_t nr_msrs; /* IN/OUT: Number of MSRs in/written to - * 'msr_policy', or the maximum number of MSRs if - * the guest handle is NULL. */ + uint32_t nr_leaves; /* IN/OUT: Number of leaves in/written to 'leaves', + * or the max number if 'leaves' is NULL. */ + uint32_t nr_msrs; /* IN/OUT: Number of MSRs in/written to 'msrs', or + * the max number of if 'msrs' is NULL. */ uint32_t _rsvd; /* Must be zero. */ XEN_GUEST_HANDLE_64(xen_cpuid_leaf_t) leaves; /* OUT */ XEN_GUEST_HANDLE_64(xen_msr_entry_t) msrs; /* OUT */ -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue Jul 04 09:35:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 09:35:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558194.872063 (Exim 4.92) (envelope-from ) id 1qGcRQ-0001lu-Oj; Tue, 04 Jul 2023 09:35:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558194.872063; Tue, 04 Jul 2023 09:35:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGcRQ-0001ln-Kz; Tue, 04 Jul 2023 09:35:24 +0000 Received: by outflank-mailman (input) for mailman id 558194; Tue, 04 Jul 2023 09:35:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGcRP-0001lf-Lg for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 09:35:23 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGcRO-0003Fv-8L; Tue, 04 Jul 2023 09:35:22 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qGcRO-0003v9-0j; Tue, 04 Jul 2023 09:35:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=RysJKHX805si3y8duGvxE6FJG8/oDUeDZbBQ5KU+Eyg=; b=vptPXrl9TfUUghBuv8/BcgVsmJ G9h+D3vrjZ1yD0CuBQ3rqAdKZgUvmS8iH5acZtqpCieBYkvcbpp0qBcQBhibFURj+U+FFvZ8Agizs 5aX/uhpC1QULMNxmRGJapIURMGj/kNpEPytrYi9/swQ0ASVC4LbsFS12a5RFeeYmG8+w=; Message-ID: <855fd25d-07bb-0b08-4c25-75e652c142a6@xen.org> Date: Tue, 4 Jul 2023 10:35:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v4 4/7] iommu/arm: Introduce iommu_add_dt_pci_sideband_ids API Content-Language: en-US To: Stewart Hildebrand , xen-devel@lists.xenproject.org Cc: Oleksandr Tyshchenko , Stefano Stabellini , Jan Beulich , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Rahul Singh , Bertrand Marquis References: <20230607030220.22698-1-stewart.hildebrand@amd.com> <20230607030220.22698-5-stewart.hildebrand@amd.com> From: Julien Grall In-Reply-To: <20230607030220.22698-5-stewart.hildebrand@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 07/06/2023 04:02, Stewart Hildebrand wrote: > From: Oleksandr Tyshchenko > > The main purpose of this patch is to add a way to register PCI device > (which is behind the IOMMU) using the generic PCI-IOMMU DT bindings [1] > before assigning that device to a domain. > > This behaves similarly to the existing iommu_add_dt_device API, except it > handles PCI devices, and it is to be invoked from the add_device hook in the > SMMU driver. > > The function of_map_id to translate an ID through a downstream mapping You called the function dt_map_id in Xen. > (which is also suitable for mapping Requester ID) was borrowed from Linux > (v5.10-rc6) and updated according to the Xen code base. > > [1] https://www.kernel.org/doc/Documentation/devicetree/bindings/pci/pci-iommu.txt > > Signed-off-by: Oleksandr Tyshchenko > Signed-off-by: Stewart Hildebrand > --- > v3->v4: > * wrap #include and if ( acpi_disabled ) in #ifdef CONFIG_ACPI > * fix Michal's remarks about style, parenthesis, and print formats > * remove !ops->dt_xlate check since it is already in iommu_dt_xlate helper > * rename s/iommu_dt_pci_map_id/dt_map_id/ because it is generic, not specific > to iommu > * update commit description > > v2->v3: > * new patch title (was: iommu/arm: Introduce iommu_add_dt_pci_device API) > * renamed function > from: iommu_add_dt_pci_device > to: iommu_add_dt_pci_sideband_ids > * removed stale ops->add_device check > * iommu.h: add empty stub iommu_add_dt_pci_sideband_ids for !HAS_DEVICE_TREE > * iommu.h: add iommu_add_pci_sideband_ids helper > * iommu.h: don't wrap prototype in #ifdef CONFIG_HAS_PCI > * s/iommu_fwspec_free(pci_to_dev(pdev))/iommu_fwspec_free(dev)/ > > v1->v2: > * remove extra devfn parameter since pdev fully describes the device > * remove ops->add_device() call from iommu_add_dt_pci_device(). Instead, rely on > the existing iommu call in iommu_add_device(). > * move the ops->add_device and ops->dt_xlate checks earlier > > downstream->v1: > * rebase > * add const qualifier to struct dt_device_node *np arg in dt_map_id() > * add const qualifier to struct dt_device_node *np declaration in iommu_add_pci_device() > * use stdint.h types instead of u8/u32/etc... > * rename functions: > s/dt_iommu_xlate/iommu_dt_xlate/ > s/dt_map_id/iommu_dt_pci_map_id/ > s/iommu_add_pci_device/iommu_add_dt_pci_device/ > * add device_is_protected check in iommu_add_dt_pci_device > * wrap prototypes in CONFIG_HAS_PCI > > (cherry picked from commit 734e3bf6ee77e7947667ab8fa96c25b349c2e1da from > the downstream branch poc/pci-passthrough from > https://gitlab.com/xen-project/people/bmarquis/xen-arm-poc.git) > --- > xen/drivers/passthrough/device_tree.c | 134 ++++++++++++++++++++++++++ > xen/include/xen/device_tree.h | 25 +++++ > xen/include/xen/iommu.h | 22 ++++- > 3 files changed, 180 insertions(+), 1 deletion(-) > > diff --git a/xen/drivers/passthrough/device_tree.c b/xen/drivers/passthrough/device_tree.c > index ff9e66ebf92a..bd0aed5df651 100644 > --- a/xen/drivers/passthrough/device_tree.c > +++ b/xen/drivers/passthrough/device_tree.c > @@ -154,6 +154,140 @@ static int iommu_dt_xlate(struct device *dev, > return ops->dt_xlate(dev, iommu_spec); > } > > +#ifdef CONFIG_HAS_PCI The code below doesn't seem to be specific to PCI. > +int dt_map_id(const struct dt_device_node *np, uint32_t id, > + const char *map_name, const char *map_mask_name, > + struct dt_device_node **target, uint32_t *id_out) AFAICT, this function can also be used outside of the IOMMU code. So shouldn't this be implemented in common/device_tree.c? > +{ > + uint32_t map_mask, masked_id, map_len; > + const __be32 *map = NULL; > + > + if ( !np || !map_name || (!target && !id_out) ) > + return -EINVAL; > + > + map = dt_get_property(np, map_name, &map_len); > + if ( !map ) > + { > + if ( target ) > + return -ENODEV; > + > + /* Otherwise, no map implies no translation */ > + *id_out = id; > + return 0; > + } > + > + if ( !map_len || (map_len % (4 * sizeof(*map))) ) > + { > + printk(XENLOG_ERR "%s: Error: Bad %s length: %u\n", np->full_name, > + map_name, map_len); I think it would be helpful if you add the function name in the error message. > + return -EINVAL; > + } > + > + /* The default is to select all bits. */ > + map_mask = 0xffffffff; Please add a U. That said, I would switch to GENMASK(31, 0) so it is easier to check the value. > + > + /* > + * Can be overridden by "{iommu,msi}-map-mask" property. > + * If df_property_read_u32() fails, the default is used. s/df/dt/ > + */ > + if ( map_mask_name ) > + dt_property_read_u32(np, map_mask_name, &map_mask); > + > + masked_id = map_mask & id; > + for ( ; (int)map_len > 0; map_len -= 4 * sizeof(*map), map += 4 ) Why do you cast map_len to 'int'? > + { > + struct dt_device_node *phandle_node; > + uint32_t id_base = be32_to_cpup(map + 0); > + uint32_t phandle = be32_to_cpup(map + 1); > + uint32_t out_base = be32_to_cpup(map + 2); > + uint32_t id_len = be32_to_cpup(map + 3); > + > + if ( id_base & ~map_mask ) > + { > + printk(XENLOG_ERR "%s: Invalid %s translation - %s-mask (0x%"PRIx32") ignores id-base (0x%"PRIx32")\n", > + np->full_name, map_name, map_name, map_mask, id_base); Same here about adding the function name. > + return -EFAULT; > + } > + > + if ( (masked_id < id_base) || (masked_id >= (id_base + id_len)) ) > + continue; > + > + phandle_node = dt_find_node_by_phandle(phandle); > + if ( !phandle_node ) > + return -ENODEV; > + > + if ( target ) > + { > + if ( !*target ) > + *target = phandle_node; > + > + if ( *target != phandle_node ) > + continue; > + } > + > + if ( id_out ) > + *id_out = masked_id - id_base + out_base; > + > + printk(XENLOG_DEBUG "%s: %s, using mask %08"PRIx32", id-base: %08"PRIx32", out-base: %08"PRIx32", length: %08"PRIx32", id: %08"PRIx32" -> %08"PRIx32"\n", How about using dprintk()? > + np->full_name, map_name, map_mask, id_base, out_base, id_len, id, > + masked_id - id_base + out_base); > + return 0; > + } > + > + printk(XENLOG_ERR "%s: no %s translation for id 0x%"PRIx32" on %s\n", > + np->full_name, map_name, id, (target && *target) ? (*target)->full_name : NULL); Same here about adding the function name. > + > + /* > + * NOTE: Linux bypasses translation without returning an error here, > + * but should we behave in the same way on Xen? Restrict for now. > + */ Can you outline why we would want to bypass the translation? > + return -EFAULT; > +} > + > +int iommu_add_dt_pci_sideband_ids(struct pci_dev *pdev) > +{ > + const struct iommu_ops *ops = iommu_get_ops(); > + struct dt_phandle_args iommu_spec = { .args_count = 1 }; > + struct device *dev = pci_to_dev(pdev); > + const struct dt_device_node *np; > + int rc = NO_IOMMU; AFAICT, the initial value will never be read. So is it necessary? > + > + if ( !iommu_enabled ) > + return NO_IOMMU; > + > + if ( !ops ) > + return -EINVAL; > + > + if ( device_is_protected(dev) ) > + return 0; These two lines are a bit odd to read because you would think that if the device is protected, then you want to continue translation. So can you add a comment explaining what this check means? > + > + if ( dev_iommu_fwspec_get(dev) ) > + return -EEXIST; > + > + np = pci_find_host_bridge_node(pdev); > + if ( !np ) > + return -ENODEV; > + > + /* > + * According to the Documentation/devicetree/bindings/pci/pci-iommu.txt > + * from Linux. > + */ > + rc = dt_map_id(np, PCI_BDF(pdev->bus, pdev->devfn), "iommu-map", > + "iommu-map-mask", &iommu_spec.np, iommu_spec.args); > + if ( rc ) > + return (rc == -ENODEV) ? NO_IOMMU : rc; > + > + rc = iommu_dt_xlate(dev, &iommu_spec); > + if ( rc < 0 ) > + { > + iommu_fwspec_free(dev); > + return -EINVAL; > + } > + > + return rc; > +} > +#endif /* CONFIG_HAS_PCI */ > + > int iommu_add_dt_device(struct dt_device_node *np) > { > const struct iommu_ops *ops = iommu_get_ops(); > diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h > index c2f315140560..8385cd538a58 100644 > --- a/xen/include/xen/device_tree.h > +++ b/xen/include/xen/device_tree.h > @@ -892,6 +892,31 @@ int dt_count_phandle_with_args(const struct dt_device_node *np, > */ > int dt_get_pci_domain_nr(struct dt_device_node *node); > > +#ifdef CONFIG_HAS_PCI In Xen, we don't usually add #ifdef for prototype only. > +/** > + * dt_map_id - Translate an ID through a downstream mapping. > + * @np: root complex device node. > + * @id: device ID to map. > + * @map_name: property name of the map to use. > + * @map_mask_name: optional property name of the mask to use. > + * @target: optional pointer to a target device node. > + * @id_out: optional pointer to receive the translated ID. > + * > + * Given a device ID, look up the appropriate implementation-defined > + * platform ID and/or the target device which receives transactions on that > + * ID, as per the "iommu-map" and "msi-map" bindings. Either of @target or > + * @id_out may be NULL if only the other is required. If @target points to > + * a non-NULL device node pointer, only entries targeting that node will be > + * matched; if it points to a NULL value, it will receive the device node of > + * the first matching target phandle, with a reference held. > + * > + * Return: 0 on success or a standard error code on failure. > + */ > +int dt_map_id(const struct dt_device_node *np, uint32_t id, > + const char *map_name, const char *map_mask_name, > + struct dt_device_node **target, uint32_t *id_out); > +#endif /* CONFIG_HAS_PCI */ > + > struct dt_device_node *dt_find_node_by_phandle(dt_phandle handle); > > #ifdef CONFIG_DEVICE_TREE_DEBUG > diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h > index 405db59971c5..3cac177840f7 100644 > --- a/xen/include/xen/iommu.h > +++ b/xen/include/xen/iommu.h > @@ -26,6 +26,9 @@ > #include > #include > #include > +#ifdef CONFIG_ACPI > +#include > +#endif > #include > > TYPE_SAFE(uint64_t, dfn); > @@ -219,7 +222,8 @@ int iommu_dt_domain_init(struct domain *d); > int iommu_release_dt_devices(struct domain *d); > > /* > - * Helper to add master device to the IOMMU using generic IOMMU DT bindings. > + * Helpers to add master device to the IOMMU using generic (PCI-)IOMMU > + * DT bindings. > * > * Return values: > * 0 : device is protected by an IOMMU > @@ -228,12 +232,28 @@ int iommu_release_dt_devices(struct domain *d); > * (IOMMU is not enabled/present or device is not connected to it). > */ > int iommu_add_dt_device(struct dt_device_node *np); > +int iommu_add_dt_pci_sideband_ids(struct pci_dev *pdev); > > int iommu_do_dt_domctl(struct xen_domctl *, struct domain *, > XEN_GUEST_HANDLE_PARAM(xen_domctl_t)); > > +#else /* !HAS_DEVICE_TREE */ > +static inline int iommu_add_dt_pci_sideband_ids(struct pci_dev *pdev) > +{ > + return 0; Shouldn't this return an error because we wouldn't be able to add the Device? > +} > #endif /* HAS_DEVICE_TREE */ > > +static inline int iommu_add_pci_sideband_ids(struct pci_dev *pdev) > +{ > + int ret = 0; Same here. > +#ifdef CONFIG_ACPI > + if ( acpi_disabled ) > +#endif > + ret = iommu_add_dt_pci_sideband_ids(pdev); > + return ret; > +} > + > struct page_info; > > /* Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jul 04 09:37:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 09:37:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558200.872074 (Exim 4.92) (envelope-from ) id 1qGcTk-0002NT-9Q; Tue, 04 Jul 2023 09:37:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558200.872074; Tue, 04 Jul 2023 09:37:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGcTk-0002NM-6S; Tue, 04 Jul 2023 09:37:48 +0000 Received: by outflank-mailman (input) for mailman id 558200; Tue, 04 Jul 2023 09:37:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGcTi-0002NG-ND for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 09:37:46 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6cafa7d8-1a4e-11ee-b237-6b7b168915f2; Tue, 04 Jul 2023 11:37:44 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6cafa7d8-1a4e-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1688463464; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=/0yM5i/MfkpAusvz4raS8zb7nUWfMXgPEhK7n7D3RcY=; b=AHPO4DecT9oG/gaTwaYXtu40/XH2+2s9ddnW8SJVWG05Et/LZflvZ8RJ K8mGRpStnImHM0tG0ISTTY/XA9+pTXTD1UenMu7oi5XYxKoU85R1EVEhW 2lklnSveEoIfnLmsfrAzFik5rxsems7xVd+Ob6pmErItZoSKOIkmlDSpG w=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 115110777 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:eV13K6rt8pNipSmBiEi2M4foXN9eBmIAZRIvgKrLsJaIsI4StFCzt garIBnTOqyCMTDyfYp1PoXi8BkD65HcyoAwTgI4rSo3HiwU9ZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKq04GpwUmAWP6gR5weBzyVNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAC4qcg/biO2M+auEFONc2sY/dfKoYLpK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFOUslWcOSA3xETdxVRrk6VoqwmpXDe1gVr3JDmMcbPe8zMTsJQ9qqdj jufoj2gWk5Fa7RzzxK7132Tq7+VkxnVAr4fD6Wo+KNRoQyckzl75Bo+CgLg/KjRZlSFc9BVJ lEQ+yEuhbMv70HtRd74NzWhrXuZ+xIRRddUO+s97g6L1+zT+QnxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+8pCu/IyEPIUceZCUPSk0O5NyLnW0opkuRFJA5Svfz14CrX2iqm FhmsRTSmZ0NqtIUj6q0x2nevGymlsTLUlcOpVnuCzfNAhxCWGK1W2C5wQGFvaYcct/EHwnpU GsswJbHsr1XZX2ZvGnUGbhWQun0jxqQGGeE6WODCaXN4NhEF5SLWYlLqA9zK05yWirvUW+4O RSD0e+9CXI6AZdLUUOUS9jrYyjS5fK8fekJr9iNBja0XrB/dRWc4AZlblOK0mbmnSAEyP9va cvDIJz1UypGWMyLKQZaoM9EgNcWKt0WnzuPFfgXMTz6uVZhWJJlYehcawbfBgzIxKiFvB/U4 75i2ziikn1ivBnFSnCPq+Y7dAlaRUXX8Liq86S7gMbfeFs5cIzgYteNqY4cl3tNxPsFzruRp i7hASe1CjPX3BX6FOlDUVg7AJuHYHq1hStT0fAEVbpw50UeXA== IronPort-HdrOrdr: A9a23:TwgqKaj8SvSygiAvUawlSS/6C3BQXtwji2hC6mlwRA09TySZ// rBoB0+726RtN93YgBGpTngAtjkfZqyz/NICOUqUYtKGTOW3ldAT7sSj7cKoQeBJ8SWzIc0vs 1dmupFeb7N5DBB/L/HCWKDcurIruPpzJyV X-Talos-CUID: 9a23:jOj4Om+dqaFWS7ed3quVv1AzBt99fXLn9W7vfUWIVWR1EYbWFWbFrQ== X-Talos-MUID: 9a23:yNPueQaJ6zCK0eBTiRrjuxwybslSzf6SBVsVgZtbgOjVOnkl X-IronPort-AV: E=Sophos;i="6.01,180,1684814400"; d="scan'208";a="115110777" Date: Tue, 4 Jul 2023 10:37:38 +0100 From: Anthony PERARD To: Roger Pau =?iso-8859-1?Q?Monn=E9?= CC: Jan Beulich , , Subject: Re: QEMU assert (was: [xen-unstable test] 181558: regressions - FAIL) Message-ID: <947da45d-f336-4034-bf51-fb190420506b@perard> References: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Jun 28, 2023 at 02:31:39PM +0200, Roger Pau Monné wrote: > On Fri, Jun 23, 2023 at 03:04:21PM +0000, osstest service owner wrote: > > flight 181558 xen-unstable real [real] > > http://logs.test-lab.xenproject.org/osstest/logs/181558/ > > > > Regressions :-( > > > > Tests which did not succeed and are blocking, > > including tests which could not be run: > > test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 181545 > > The test failing here is hitting the assert in qemu_cond_signal() as > called by worker_thread(): > > #0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50 > #1 0x00007ffff740b535 in __GI_abort () at abort.c:79 > #2 0x00007ffff740b40f in __assert_fail_base (fmt=0x7ffff756cef0 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=0x55555614abcb "cond->initialized", > file=0x55555614ab88 "../qemu-xen-dir-remote/util/qemu-thread-posix.c", line=198, function=) at assert.c:92 > #3 0x00007ffff74191a2 in __GI___assert_fail (assertion=0x55555614abcb "cond->initialized", file=0x55555614ab88 "../qemu-xen-dir-remote/util/qemu-thread-posix.c", line=198, > function=0x55555614ad80 <__PRETTY_FUNCTION__.17104> "qemu_cond_signal") at assert.c:101 > #4 0x0000555555f1c8d2 in qemu_cond_signal (cond=0x7fffb800db30) at ../qemu-xen-dir-remote/util/qemu-thread-posix.c:198 > #5 0x0000555555f36973 in worker_thread (opaque=0x7fffb800dab0) at ../qemu-xen-dir-remote/util/thread-pool.c:129 > #6 0x0000555555f1d1d2 in qemu_thread_start (args=0x7fffb8000b20) at ../qemu-xen-dir-remote/util/qemu-thread-posix.c:505 > #7 0x00007ffff75b0fa3 in start_thread (arg=) at pthread_create.c:486 > #8 0x00007ffff74e206f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95 > > I've been trying to figure out how it can get in such state, but so > far I had no luck. I'm not a QEMU expert, so it's probably better if > someone else could handle this. > > In the failures I've seen, and the reproduction I have, the assert > triggers in the QEMU dom0 instance responsible for locally-attaching > the disk to dom0 in order to run pygrub. > > This is also with QEMU 7.2, as testing with upstream QEMU is blocked > ATM, so there's a chance it has already been fixed upstream. > > Thanks, Roger. So, I've run a test with the latest QEMU and I can still reproduce the issue. The test also fails with QEMU 7.1.0. But, QEMU 7.0 seems to pass the test, even with a start-stop loop of 200 iteration. So I'll try to find out if something change in that range. Or try to find out why would the thread pool be not initialised properly. Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Jul 04 09:42:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 09:42:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558205.872084 (Exim 4.92) (envelope-from ) id 1qGcY5-0003qy-PO; Tue, 04 Jul 2023 09:42:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558205.872084; Tue, 04 Jul 2023 09:42:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGcY5-0003qr-MI; Tue, 04 Jul 2023 09:42:17 +0000 Received: by outflank-mailman (input) for mailman id 558205; Tue, 04 Jul 2023 09:42:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGcY4-0003ql-FH for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 09:42:16 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0e589583-1a4f-11ee-b237-6b7b168915f2; Tue, 04 Jul 2023 11:42:15 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0e589583-1a4f-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1688463735; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=TuXXQxQ7oFrhPAA9ILwXiKoQM74Duw62d1G9RVUZ7ks=; b=Mz/XOjr89FtNTvoh8jbOrHKzn0pZJIGDZoEuGpTu3NdbtRqsC9T7ktfP /L+podZRoJSVvCSHeLJHWLCifnm6Mm4VxN2PvmGMAxXUz2PJ+PW/q1GFY 3N5n7Sa9PAtDAe7m9Zou5WALP30txCtQvNbX9vyT4CqWMGcl9MBSoC1fF Y=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 113809652 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:WC4F664FWwvwp4jd8NsNQQxRtN7HchMFZxGqfqrLsTDasY5as4F+v jcfWz/Xbq6MZWL2ftxzPdng/B8C6MXdyNVqSQU9ris8Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9lU35ZwehBtC5gZlPa8T4AeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m7 bsWDCkVNgC/vuPpwKqQZuZpt5UiFZy+VG8fkikIITDxCP8nRdbIQrnQ5M8e1zA17ixMNa+AP YxDM2MpNUmeJUQVYT/7C7pn9AusrnD5bz1frkPTvact6nLf5AdwzKLsIJzefdniqcB9xx/D9 jqXoTmjav0cHOShlwie9Sz8v9/ewgTlVoQ8Poyy3dc/1TV/wURMUUZLBDNXu8KRjlO1UpRRI kof9y4qsIA77kntRd74NzWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOnMU7XyAw3 1mF2dbgHyVysaa9QGiYsLyTqFuaJiUUa2QCaCksRBEApdLkpekbkRbnXttlVqmvgbXdHDjqx jmQoSsWhrMNjNUK3aG24VDGhT23opHDCAUy423/V3qo9ApjaKa5Zoaj7h7Q6vMoEWqCZgDf5 j5ewZHYtb1QS8jXz0RhXdnhApmxoPihKSWEkWJWHsYh7x+B9HuSLIFptWQWyFhSDioURdP4S BaN6VMNusYObSvCgbxfONzoVZlzpUT0PZG8D62PMIITCnRkXFXflByCc3J8yIwEfKIEtagkc amWfs+3ZZrxIfQ2lWHmLwvxPFJC+8zf+Y8wbcqhp/hf+eDCDEN5sJ9cWLd0Usg37bmfvCLe+ MtFOs2Bxn13CbOuMnWPoNRKcwxWfBDX4KwaTOQOJ4a+zvdOQjl9W5c9P5t8E2Cao0ilvriRp SzsMqOp4FH+mWfGOW23hoNLMdvSsWJEhStjZ0QEZA/4s0XPlK7ztM/zgbNrJ+h4nAGipNYoJ 8Q4lzKoWasfEmieo2tBNvEQbuVKLXyWuO5HBAL9CBBXQnKqb1ahFgPMFuc3yBQzMw== IronPort-HdrOrdr: A9a23:aLdbkaxhqF2IroRHEj12KrPwFr1zdoMgy1knxilNoEpuA6ulfq eV7ZcmPH7P6Ar5N0tKpTntAsO9qBDnlKKdg7N/AV74ZniDhILAFugL0WKF+VDd8kbFmNK1u5 0NT0DQYueAa2STIazBkWuF+3dL+qjjzJyV X-Talos-CUID: =?us-ascii?q?9a23=3A2PLarWsyZ1MGvxtx1DHsGsna6Is9NXP51W+IM3O?= =?us-ascii?q?BCDlpUJa5RlqhqaJdxp8=3D?= X-Talos-MUID: 9a23:t0bRdgRi+dngMd5kRXTUum9QL8A2s52eGR8qj5sAleO1PwdZbmI= X-IronPort-AV: E=Sophos;i="6.01,180,1684814400"; d="scan'208";a="113809652" Date: Tue, 4 Jul 2023 10:42:01 +0100 From: Anthony PERARD To: Luca Fancellu CC: , , , Wei Liu , Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= , Andrew Cooper Subject: Re: [PATCH 1/2] tools: Fix ifdef for aarch64 that should include also arm Message-ID: <66c3d183-460d-4f34-a331-01ac4d65fc9d@perard> References: <20230608135913.560413-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230608135913.560413-1-luca.fancellu@arm.com> On Thu, Jun 08, 2023 at 02:59:12PM +0100, Luca Fancellu wrote: > Commit 56a7aaa16bfe introduced some SVE related code that is protected by > '#if defined(__aarch64__)', the issue is that this doesn't take into > consideration when the toolstack is compiled for an arm32 Dom0 running on > an arm64 platform, it should be able to create SVE enabled guests but with > the current code it's not. > > So fix the issue by compiling the code when the toolstack is compiled for > both arm32 and arm64. > > Fixes: 56a7aaa16bfe ("tools: add physinfo arch_capabilities handling for Arm") > Signed-off-by: Luca Fancellu > Reported-by: Andrew Cooper Acked-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Jul 04 09:44:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 09:44:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558210.872095 (Exim 4.92) (envelope-from ) id 1qGcaP-0004Po-7O; Tue, 04 Jul 2023 09:44:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558210.872095; Tue, 04 Jul 2023 09:44:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGcaP-0004Ph-1j; Tue, 04 Jul 2023 09:44:41 +0000 Received: by outflank-mailman (input) for mailman id 558210; Tue, 04 Jul 2023 09:44:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGcaM-0004PU-UB for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 09:44:38 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6344a856-1a4f-11ee-b237-6b7b168915f2; Tue, 04 Jul 2023 11:44:37 +0200 (CEST) Received: from mail-bn8nam04lp2049.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.49]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Jul 2023 05:44:35 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by DM4PR03MB6064.namprd03.prod.outlook.com (2603:10b6:5:393::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 09:44:33 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::1c83:1877:a68b:8902]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::1c83:1877:a68b:8902%7]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 09:44:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6344a856-1a4f-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1688463877; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=0/Jl8PUvPYhpGd5cqwpfcRbUSXepwc56e8D1WmpqbhY=; b=K5TnTCmxUFbljTv6bQSm7UCH18lP4iWFfeUNNJ2sCk2Y7ShXnUzBEPnm BdtItXItBKVyXGIRJdqB+g+wGfcSRjaGRqvhkl3dXrR61/lid3PP/aStN is469kkSssthWOkPh4hhF5jaRL8QvO1t85uDG6gl7UyxzMQX42diMxaVM o=; X-IronPort-RemoteIP: 104.47.74.49 X-IronPort-MID: 113809947 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:/3t2AKNv0pnlmbTvrR2ClsFynXyQoLVcMsEvi/4bfWQNrUpx1jJSy WBMCzvTbK7YMGfxc9olbtyz/EhQscXcndFrSwto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGjxSs/vrRC9H5qyo42tH5gBmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0uN1LFF+r sMdEj4UcgCRisef2a+eRfY506zPLOGzVG8ekldJ6GmFSNwAEdXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+vZxvzm7IA9ZidABNPLPfdOHX4NNl1uwr WPa5WXpRBodMbRzzBLcqyn83r6ewXyTtIQ6LqX/6/pPu32qmG0vJRlLfwOh+Pi5sxvrMz5YA wlOksY0loAi+UruQtTjUhmQpH+fogVaS9dWC/c96gyG1uzT+QnxLkouQyNFadcmnNQrXjFs3 ViM9/v2ARR/vbvTTmiSnop4thu3MCkRaGUENSkNSFNZ58G5+N1iyBXSUtxkDai5yMXvHi39y CyLqy54gKgPickM1OOw+lWvby+Qm6UlhzUdvm3/Nl9JJCsgDGJ5T+REMWTm0Ms= IronPort-HdrOrdr: A9a23:o7xVFKhaqH71vX1LzSOO+opdQnBQXh4ji2hC6mlwRA09TyX5ra 2TdZUgpHrJYVMqMk3I9uruBEDtex3hHP1OkOss1NWZPDUO0VHARO1fBOPZqAEIcBeOldK1u5 0AT0B/YueAd2STj6zBkXSF+wBL+qj6zEiq792usEuEVWtRGsVdB58SMHfiLqVxLjM2YqYRJd 6nyedsgSGvQngTZtTTPAh/YwCSz+e78q4PeHQ9dmca1DU= X-Talos-CUID: 9a23:pf5WK2xVyXCq87QuchQABgURGO0VQibiyU3eOlOoG2tMYaSIbFCPrfY= X-Talos-MUID: =?us-ascii?q?9a23=3ASyruBQyLlHMPUgISPk16P6zmM/uaqJ62T10JtK4?= =?us-ascii?q?mgpeFCQF0Zh3Flm22QrZyfw=3D=3D?= X-IronPort-AV: E=Sophos;i="6.01,180,1684814400"; d="scan'208";a="113809947" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UAMnyv4yOAKgh4KuMmbPmEJahIqDnVDi/QIHBmGIg64cKiDBfFjunJmS8VpnGWjReYGM79QC6a+L4mMWvQ8zcqrYpkonaqsSoQIaZJYVwuFBRexU/5/DuLXkIhAQQQxDfYQjBR9N7jnIONqOVIJc3+ADti8UihKVobMwY5V3C7m8ZrSS0JS8RSxcYgmMXM3yEDmhuL+LIQlEs/VEPS41qgptMcCMkHT3uqgs+rxCiVEUOCyCqU5QhsF73vvQ4euxcF4mwRcedFJ7MfBSD5T0GSn/nlYHSqrXrqvpsYRr23AePTsXfGkwlRoWptq2K6rm7fKYbUiydOFsyjvlBvKVjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0/Jl8PUvPYhpGd5cqwpfcRbUSXepwc56e8D1WmpqbhY=; b=ThXUF6cRCzFeiT1cmoGxGBPyxZCHHAOw0os/xF7TLoI1wOOk6HVVqpIkYhmfj64Wqb6Q2RAY2P1ai/4a3zQVNHlTNElBnxerE4kObejyb+OzDlOdbfIOk8qC0Iq0CPHnfooI3JzggZZTwifewFYk4XGQZQNjEeodFoam0dUFm5PvZ6wVQiItuW2UPmSQ+jPdRGQBAHDh1pBnlP05XP8iRVYZd6ePtGnSZmcbsslHrcnm4rF0I+ezlROt2qx1rSDqmUUwv/HzqrF6uJskT+yZL4Z+G+EbsQYQRZIePmkBA14kkDzQptJSWLXcMmGCDBdAi1WHoQ4pEwFGCTztzodV1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0/Jl8PUvPYhpGd5cqwpfcRbUSXepwc56e8D1WmpqbhY=; b=f6MpxYyixuOZatTMKaxfuXONd+462EsTZaa06pV0SGRVrde+sLTxNoW/VVTO1FV2GF0+OH3xBeLe2qtrfnF5RfQCdFjl1RqH+A0W5j+dbW5+wxcK05tD9MlsSW36UWVLEldcCC2Pa3t5zELopUb7CFehGBeQo3jfJ33mIqwuAHA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 4 Jul 2023 11:44:28 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: Xen-devel , Jan Beulich , Wei Liu Subject: Re: [PATCH v2] xen: Correct comments after renaming xen_{dom,sys}ctl_cpu_policy fields Message-ID: References: <20230629102600.61262-1-andrew.cooper3@citrix.com> <20230704092909.3635899-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230704092909.3635899-1-andrew.cooper3@citrix.com> X-ClientProxiedBy: LNXP265CA0055.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5d::19) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|DM4PR03MB6064:EE_ X-MS-Office365-Filtering-Correlation-Id: 15153357-4689-4d9b-96a4-08db7c73458e X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZJNTSSIFYi9r4ebSjixuauS1yMDulJRd4ARJnpM8zrjt94gTGAxzpzbjI9593dMsgO/+BNw8GV/O0hIKOJnoKwKuF7xNaEs0lBpzZ3BCHXszuysZ80X24XDZwPOZQA4wSS9WOUDd+vhq9N+769qdvGbWl43snYQyq7mDKkAjGRdUuKRqeAyHlwmZmCPtzeAufcel9NqCUWOwfEHvtDxUu24QDbZoXB84rZuG1X8LVBP8yVcKSCQoIxUPzu6knHnu+n/bHb+WjlucrTfyv9/zM+dEDevBaa7ONt+fyXg8AQ5tP6nCKULc7VegsyEOwcak28KFhVH/TOP/uvAa4fZzPgDaEFEUR/MdFTzisifuKAHdHUiNE8TKu/5mvobez2ozf3Q6RZ2q4iD00nrwTFfPI2n+DlodnGrqwjUh5Q42tsrFhLNpnQbzxN1L61nP+ZVeTcLBd+1K1bCUNOMMJRxJ6vaTjpbuoJkQ2sJXQlYtkgtluj7Rc0IpXLkZyZR2wDBode2L7t0pmOTMZzHEk6nIWL5ivM9cpV/xRpUk9H2Hv/x+qwmeY8usZjtpxdk/oeY4 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(366004)(346002)(376002)(136003)(451199021)(2906002)(41300700001)(6862004)(5660300002)(8676002)(8936002)(558084003)(85182001)(86362001)(186003)(82960400001)(478600001)(26005)(6512007)(6506007)(6666004)(9686003)(6486002)(316002)(6636002)(4326008)(66476007)(66946007)(66556008)(54906003)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QU1nWldIZktUVUNCNzluNlZhcVUwMU9reHRoNmZlU3VneVY1QkNQK28rdEVG?= =?utf-8?B?N3J4KzJjQ3pWZERESC8rekVxY2I2YnFTSmdHL3ZCWUR0N0xSekdYQ1cwaWtN?= =?utf-8?B?Wi84SjlmdEdoY2dzcWxKamowVzBaY2NwRWdhNUpMZ3ZhdG1USG4yK2VLbEhH?= =?utf-8?B?VHNTQXZZeFFwQ3BLMG1sM1JKV0NhL1dFY2xtL05mT3VMeExKUllId1dPNVVQ?= =?utf-8?B?N1lUT0xXMjdkMVRUaDBCaC9nMzJVbXRYblIxdXMvTi9qNXRZMjZ0N1R4RUFT?= =?utf-8?B?RzZvZk1wdHZoMlZVNmRGZGpQczB5aTBRY3k3UTJWc1ROdzZTc3MwaFhXbmFS?= =?utf-8?B?SHdSWndjNjVZb0dQS3R0bmt2b2hHaEVmUHpKSC9hcVdYbFprWkpteVdtbXhF?= =?utf-8?B?Um1PekZLTG1jQU4yTHBYNDhqK3FHZGxHejQ3dU1mam9kSERocXNzT1lGdVQ3?= =?utf-8?B?bm0rMjZGS1JFYXFkMklaSDdYbjdQSzBmNFJZS1dEQmcvMUxaTXJ3eFYxcG8x?= =?utf-8?B?TmJDQWt5N3VncE9kOG5RUnpXWHhwZHNGQ01BQlFWMkc5aTFBSE9HcTEwVzFp?= =?utf-8?B?MkVtb1VkYnNEenkwa2s4ZFhGZW96US9ndU9xbFhyT3FGRnNEbitMcEZEeHNo?= =?utf-8?B?YUx6Zks2WGFuV1Fta25pWGw4RGh5TVVQWmpJSWpxczVIbVZrbXNGZ0VsLzd4?= =?utf-8?B?aS9lcjBYOEt2QndJWWhORzUzK0dwZ0VPRG11WFQ5dm55WWxIN3ppM0ZJdGJo?= =?utf-8?B?NGNYQXlPTDFPRllJVVlvWnVIZ2YzbDN0SCtqbUVlTVRzZnEzcU04dzVRc2Jl?= =?utf-8?B?T29pR0xDT3k5STQ5WUh5cDR0U0RRVHZTbCtucWltRC8wbS9NRVNDNnFBalp3?= =?utf-8?B?MlppL0pvZnJKbFVvNFMwRWtzYmZTRGFUOElCUkl3Vk1jN2lrQS96Q1JqdEYv?= =?utf-8?B?WGtkYUtJYTE5TDRPbXlRVzEvcEtITC8vVlRpTnRHOUhKTWE3NncrY0dDWXM1?= =?utf-8?B?TVpKSi9sNHJhN2ZqWXkvUFBrRm5vRWROSE9LMFhOTGZtUWY2VXhTdG1Gd0xh?= =?utf-8?B?Wmh4d1VxbmNoT1hzNWNMd2ZTZ1ZOK2tnNk1jc1Q4WnFKQkdESG9EdStEWnlJ?= =?utf-8?B?bTBubjNVYThGWnpRcDc1UDgybDRjcXkvUmxMcmNWMGNqNHZPcGdNSldNR2Mr?= =?utf-8?B?WUFTTlNuZ1RJdDRpbmZrZFBGY0lKd3J5NW84NTJhQVdXblBMN1NWOFZ4YWNZ?= =?utf-8?B?WWxSbDZ6MVI5TStFOU15bXVpOWRxbFhQV3IrK0NnLzUrOWxBTDdHeGIxY2tE?= =?utf-8?B?U0NaWkFVZmM2RVB0YzI0a2VrT2VBd2xLMHF4RHRVTXBxU2w5SEVPMFVRV2FX?= =?utf-8?B?ZXFuRFdEbmVlMGFBeW5WQU50RGY1aXhDVytVWmo5b2RCT1cyZGdKaG1wamha?= =?utf-8?B?TnRRUE1UQ1BTdmNKZFZVTndqbzV5NS9oK0RUNHdIZnV6bGNFNDcwNDhDSGI1?= =?utf-8?B?TzMxZjdPdVlvMkpaZkI2U0pJbFdNYnVIRnZ0bmlPNFF1Ky9XSmd0S1BwVkVu?= =?utf-8?B?aWVGTy9YMGRHWXV0clpoMGZEL2JpV1RtSmZlQXcvRW9qcDMyd3VmN0krVXhB?= =?utf-8?B?VStWMkJoOSsreXZYOTFVNWw2by9KTkdpNUFCbXlpZkVkZU1yejQ1V3R2RzM1?= =?utf-8?B?WGpjNHZsRm5QVVRITkxkR0RHR1BVQllMOHh3SFV2a0tpVDRBeUZBRkpTcThh?= =?utf-8?B?Uzl1MzBvWm1GOFFRYzcvK2FPMVhZd0RsUDNMMFZQdjcwQ1hqdnhhalFXWC9u?= =?utf-8?B?bDhqRDRrWXBFNU45cDB3ZmFWbVF6OGVBaXFqRUh6c0ZraXQ1cjZsZzF3Qnpr?= =?utf-8?B?aWZTOCs5N1pTM0x0bFJwVStoaHFrdk12bkFqUGhvdHR4cUVGYUhseUsrV3Bz?= =?utf-8?B?c29Pazcva1AwWmVQai9oVVFodzZQUGpFSU90aDhSakNnRUk1WU0remc3dDNi?= =?utf-8?B?U3JtUnE3WmR2bTIzQ0xlRi9XTkhianhYcWFyTXAzQkdvdW43aUxUbys0UUsw?= =?utf-8?B?cjBMWExqNVZrN1ZjVVNXVkZodkRhZkdjeWxFTjFSWU80RytzY1NyMGpCRG5w?= =?utf-8?Q?kBZDHi53dGUw2na1cYJzTtd0A?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: g+1pVZcr+9DOxH7H0K6Ab8nuyJitSWN4LYs4IuCc3Wen1PUDKJKGuwvvUlFKl4JNLkhGvJRc28klcoeAXUDLZSota/J9F4AGSnGQd3/HqbnBtqKMdK8PHzla11OWCcT3jqH765dBWj5mTt43X6c78JsLSCOSfboL9wr7dDo2WTJU5JQ3/nGxdwqAsNMzEivGrRxWxQ48iL5aH0fgN76Jv2cBA7qSZ7gwBHiCdJk6iWKEO4EceKzJfDDcgExwO5N7caa92HI3yxSnzoN22royYV67sftFdsXSQl65Biz7gpItoe3X7o5vRyKvks3pndWIDrG3g2Bc/Gq72m4q8PbnOto+mi0sf+y1pSTca/kqqdkCUtJKhs54iYI9GuiGvhZi4eJy2iSJNEDnhAtujYFOQir7Vy6pGRlYErUGxfT1W2x0Fr5uFrRanrAN3FQ16rsGBhwemXQCGhAu4DYb56HYJak0YWxTcyawOZsp/tV3MPKrG7tPGz8bcgzz/BZKI8T3a/r0R0SI3S4d9GZKrgbg0oaCNflit7FXKPa/TQ13iqBkjmErMF6CheanM14f6pV2ZUEmXz20GXokMLg44Em5202Qs7NaGrjGXhptsy/WKlZVq7WesJfJPvwIuk/9kbTAbswvUk8nmoOQqTmavaCXQF+Q6R7GgJzprg/O+DQuMfRNrDBWxEkc9UrL89Xs/YFEIrsu4VlpmkSwfgcANlM5sFZznbJc7zuZy4Q3dU/BqpZLbPAb+Nqkpv5C73b2hdhJXbl+fvVQudYFWOt+9WcBcfZxhpTInIqUHyEPbTYUrPLqFvr/rBw408WB/0FZ3yvj X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 15153357-4689-4d9b-96a4-08db7c73458e X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 09:44:33.4628 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: T7/xoWfvKUgF1s1aD42TFOV4z3hl7d/HJu0vYteuQoWj1wPm4zYYgQiwapnOmEVIWFzbuGi2pnkj2fKZzJ7YpA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6064 On Tue, Jul 04, 2023 at 10:29:09AM +0100, Andrew Cooper wrote: > Fixes: 21e3ef57e040 ("x86: Rename {domctl,sysctl}.cpu_policy.{cpuid,msr}_policy fields") > Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Jul 04 09:57:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 09:57:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558215.872104 (Exim 4.92) (envelope-from ) id 1qGcmR-0005yZ-7p; Tue, 04 Jul 2023 09:57:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558215.872104; Tue, 04 Jul 2023 09:57:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGcmR-0005yS-4F; Tue, 04 Jul 2023 09:57:07 +0000 Received: by outflank-mailman (input) for mailman id 558215; Tue, 04 Jul 2023 09:57:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGcmQ-0005yM-In for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 09:57:06 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 204443a4-1a51-11ee-b237-6b7b168915f2; Tue, 04 Jul 2023 11:57:04 +0200 (CEST) Received: from mail-mw2nam12lp2049.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.49]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Jul 2023 05:57:02 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by SJ2PR03MB7525.namprd03.prod.outlook.com (2603:10b6:a03:566::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 09:57:00 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::1c83:1877:a68b:8902]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::1c83:1877:a68b:8902%7]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 09:56:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 204443a4-1a51-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1688464624; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=U8ZjVsaGXtSV+cvAFoZC7DnUTy09AzEfXrMVBYtc9vU=; b=IdTBIo9pPpMv5n9uSwycHsDe6APqvvMFEfmkyqSvD15GWnUjCExh5VQi 5vT8vTuJVBsVhotY+fDZxdL24OroppGEmoJj93NNZ2/jSRYt6T/JWFoD0 k9iB4mVPEw90BfTIksUFqwuZSy353Ip3QzYgzzo67JIJxhtNlR7rbsRuj s=; X-IronPort-RemoteIP: 104.47.66.49 X-IronPort-MID: 113811165 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:DzLbqqkZJMRESW3PjKG0g+no5gypJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xJKCD+Fbq2Pa2vyL91yPY2woR8G7JPcyoJiQAZr/C40QiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE0p5K2aVA8w5ARkPqgU5AOGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 dsfGBsiMhKdvd6Vm4OqcdVwmeZ/a9a+aevzulk4pd3YJdAPZMmZBoD1v5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVklI3jOmF3Nn9I7RmQe1PmUmVv CTe9nnRCRAGLt2PjzGC9xpAg8eWxHirAdtLSuDQGvhCuECr2mUfGhsqcUK4j8norGisBY1fN BlBksYphe1onKCxdfH/VRClpH+PvjYHRsFdVeY97Wml06fR/kOVC3YJShZHb9opstJwQiYlv neZktWsCTFxvbm9TXOG6qzSvT60ITISL2IJeWkDVwRt3jX4iIQ6jxaKS8k5Fqew14fxAWuon 2HMqzUijbIOi8JNz7+84V3MnzOroN7OUxIx4QLUGGmi62uVebKYWmBh0nCDhd4oEWpTZgDpU KQs8yRG0N0zMA== IronPort-HdrOrdr: A9a23:EDRZOqnKqXOUqnHR06aTy4DCkAzpDfI93DAbv31ZSRFFG/Fw9v rPoB1/73SftN9/YgBCpTn+AtjjfZqxz/NICOoqXItKPjOIhILAFugL0WKI+VPd8kPFmtK13J 0QFpRDNA== X-Talos-CUID: 9a23:0YcFem/sicwiwxsniLmVv2kTKusKLn/D9kvzeH6pMlp1V5/JDkDFrQ== X-Talos-MUID: =?us-ascii?q?9a23=3ALmFsgQ84JUZxpTmG0MjmDxOQf/9127inBFILrbE?= =?us-ascii?q?fuOe0ZApWKWnCjCviFw=3D=3D?= X-IronPort-AV: E=Sophos;i="6.01,180,1684814400"; d="scan'208";a="113811165" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dPReMC9TC8rTNAQPjWq/BMGOzqor6SYsGqPYu6IdJHK8KOzHKNZyUX5flBa2+W15RmTrl9PikuuRf7w0S3zI7dwfdLZ0f6UhKXX2CeJW2sKqtWax1OFjkHsAcTrw+mYVitfWpftNh/Ywy8KWSaWV9nt5j9abdce5uwJYOXciJkTlRSLIjt3IbiXT2+qxeFPpcLUXyh9XXOL3Xg864h2iEqPSbPVnlsvdtkgULjsl6hp9A+uNLw29TFYEABPM2br7+Tu1B4P8nKNT0LoEzRI3TdSG8vwVfrNLrqLISEp2orwLEOthgPKvxYfJbBIhlRXf76/0lOF2NzdCg7gSE+AqnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=73s0z9K7VLPa8Uyp+Lbp6tEDaXxy79OKqbEz+XfK2UQ=; b=kGbmrfpV+FKPAGgFapQYyWHOtxdKvAOXpsLa5E43pgi9i9FflI+hk8XVFvS9qvYOyNnvSrZ9fFwnMGWwE6I8ElNickv80WXoklv61G6+LL9upAriCCimJzKTajm1kAaWxEb/f4vNGQgNyAHaas13sgTLTfLRRns13/ujHlu6ew4llaqeveppAbgzz6+mR6hUQGVZQ8xzS0Ly/vEXwZDqNCr8AUuq7/YM4Kg7aqT8JXUBD2mpl+dd8HooAAOWu2muIX0ZUMgqzOmwd060Xeu2d0yiUsNq/rOwQ842CcprgazMPYs6r+xZzVtdm7w0eFFYH8V1beBdO54QmzoX/gYSRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=73s0z9K7VLPa8Uyp+Lbp6tEDaXxy79OKqbEz+XfK2UQ=; b=vR362JJfIaKw6GvEPCMc6LAzJzYfmhR8WfydISz3SMm4UTmiDOSQsjXi/VLPdlQcTGHuRKsNFrOxQKu3lT4jSFUEAZfFQf+JDKHPHJPAmlPQiEwp0pXMcg6odeBqWMjcUmB5YvDsMj1XnN29MqDjy2puvmM+/McGMDz6QflTurs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 4 Jul 2023 11:56:54 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Anthony PERARD Cc: Jan Beulich , qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: Re: QEMU assert (was: [xen-unstable test] 181558: regressions - FAIL) Message-ID: References: <947da45d-f336-4034-bf51-fb190420506b@perard> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <947da45d-f336-4034-bf51-fb190420506b@perard> X-ClientProxiedBy: LO4P265CA0192.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:311::20) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|SJ2PR03MB7525:EE_ X-MS-Office365-Filtering-Correlation-Id: 9b866fd3-80ff-448c-4539-08db7c750257 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o+8Yr2RnKx1Tl7rf89PtPgTR6qNqQf22rOgs/+hR0JgdJTJTNcqBP65LSFShg9em7w9ag88JKQh43LDmSbNg96BYjSzB5y6TnTfgJg3KnryUh1QfrlpENCl691FSfMvdEBiNVol37K0uqAvh4/ojMUo+edjMpRUr2Iirhw7oxEBIUTvEfrD3AnyOGlP90NR227eevB5CC3gBWajUwcfW1uQkwjSEUbJYEytubxoZSMZp/L+eQB+CUgnI7JoIyY0F6j15GNmmYec9Shz2kBek7jj3tvINglB67MNPiOMW9hsjSBFA5pLymZZyG0p4pka6jdtlRTA/YYzmI6DS8cj7Pb9f88P1ITRfhrBPkiPLK5Tf0JGvYnoDAfqzL4cjHrjD1d5hoOiJWPfdi5hdwNHdDh7H0NXEuRBxCgLMqvJQkQtXNxfTnCsS67A47kHBATpeqx+asK2FM2UoDe1yPxNed3Zj1IohRabrCKo9FQ5dcfoO88qIdFavrzjq0MHz2dHReHEcz04rXOdISsQPyIsQe4fYjvMOc2P1gEvWP0sI4z4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(366004)(39860400002)(376002)(396003)(136003)(451199021)(41300700001)(6486002)(6666004)(38100700002)(26005)(82960400001)(83380400001)(186003)(6506007)(9686003)(966005)(6512007)(86362001)(478600001)(85182001)(2906002)(316002)(66476007)(4326008)(66946007)(66556008)(8936002)(8676002)(6636002)(6862004)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V2VaaXJYbEZlQ2ExTVdleVZOTFNOSmltNW8rWXVmRmNIaXhUUmcvN0NjYmdQ?= =?utf-8?B?MU40YzBtL2ZiVWYyVU9JMS9qS1dSb0NiZlE2MTVXaTV6V3dMNGxnaStpbDBi?= =?utf-8?B?M3NmaWc1L3EyM0tqTTI5TkU4Z1ZOcVM0dE0yVkJBc1hoQkZidkJwMzVsS1NJ?= =?utf-8?B?QXloYk0zL3J5RWxBVG5QRk11UVozMkpiZzFpYmIrT3U4UUxRMElhME9SSGUx?= =?utf-8?B?dWR2Q2dRVmJyK3lvL1BiUHlhUVdTRVpJWFJHbzlFeE14L2ZXZk9UZk5wSWRs?= =?utf-8?B?Mk51bmQ5cHIyVExkMitaTU03L3g4SjlnQlpwQTh2R2FuYTdzQ2tFeEtwdE9q?= =?utf-8?B?azZHS3NTeFlnWm1SZWFZY3p4T1pIMW13QXpvS2RDQXkrTTRFL1dEaCs3eDE2?= =?utf-8?B?T1RMbU1naUxCSkczUUIxajVPMzQvbXJuMW9uaDhoZlBaU0QzYjF4U29xZk5P?= =?utf-8?B?MlBQb2dJa2FCVDAwZnFwZmdRMk5Ockw3SjZJbXpmY1ZDOS9hcmRiMVdoTUhr?= =?utf-8?B?R3lJL25BTlZ5aTBLUjNoQ0pRT0x0aGRnOUpPeVRNSUsvN0x4MHVrenhHQlp1?= =?utf-8?B?YXlYcEgzekZoRElsTWt4TTVlYU1Ld0psY1FyV1o3ZWRydGNTM2tDRlhVRmRI?= =?utf-8?B?Y3Z4dGQxTzNZTmlTRTUybjVibE9LSnZrSW5Ba21sYW5XcEZUUURzSUl1Mzli?= =?utf-8?B?MXVkK21jMkxucnpEa3FBdk1YdWxMYWh2QS9sUE9QMXRFSUVqeGY2aHdYczNz?= =?utf-8?B?a3g4cnZaU0Y4NDY2MUFVeUxnZnc5R1RkclRjVzRSSmRVcVpvTzk3QkloUW45?= =?utf-8?B?elVqV3R3ZHoycFNaYjMvYWJVTmRROTFzSWlmcnRZTnZYOUlXNFRsVVN1NnBz?= =?utf-8?B?bnRhcGpZQ0hLU3prdzhiSG1xUURmWUhOcUw5MnhiQ1Z3VlUxNEVsZGVKTmow?= =?utf-8?B?bDRIODFtdCtxY1ZsVjF6OGlNbUVLeE1KMCtlODBDNDN5MnZaWWJiOWtBRVln?= =?utf-8?B?dDczZ1p3K1RGVHFYM1U4Y3lNay9La2VpcWpOc0xZQTF2K2NXdmxJcjhSbXpK?= =?utf-8?B?Z3o0V2lPY3dZWTA0b0oxRFdKcFcwMkZ1d25YYjc3QzlvMU0rSmJYYkR1TTlV?= =?utf-8?B?bWZLZjhEV0ZvV0FWTDN4RjVFQjZuZUtDK2ZpZitDS1ArazZSUE4rQk56ekxo?= =?utf-8?B?S2hzYnpTb1ROTHF1V3gxRDJkZ3MrelQ3YjMvQjZHVHZ2U2FWbVBkRGdRYmpi?= =?utf-8?B?MjhjaWhwKzc1N0VMUmRJd3FPdW5xNmlocHZqZVBVM3RiRzFlNGdhejk3TUta?= =?utf-8?B?RlE1T1RwaVdrdFB3MENXU3hpb1djdUY4NWlXS2QrcElubzVhMlkybnBHYWtu?= =?utf-8?B?VEZPemZCcE1NN3RrNWlHcncvNWNDNGlDajFaTUQxMENWLzF6T0xGWGZiS0VS?= =?utf-8?B?c0VjcjQ1RXBwaWlONkdadFpmbGwwTERBbGtVRCtFZUp3eXVHMklnSjVRaGU2?= =?utf-8?B?OHJZQytTckE5cE9CdkUvNjBpbzJJaHNmN2hIMWZ0d1phOFZSTExTWDhteTJx?= =?utf-8?B?MmMvc1ZPdXlBY0FscEpTY1c4a0JoT051eWVKY2grckE0MCtZUUxyNEdVb0Yw?= =?utf-8?B?c2pLNmVwUDNHdTNSNy84OThoKzE5dVJoaG4wdEpKWGVkNldlME9aemp1ZDJT?= =?utf-8?B?RVdhTGZaR3VWU0U3NURiSzN4bS9kckJneitSdzJWVnhTdmxCQUFPY0QxNklI?= =?utf-8?B?T0tjbTJYU2p1bEhrcUVvL3VqUWc1T3gxSUU0bFdlQWFLK0xqRGFpMHZUZ3Mv?= =?utf-8?B?eUFyUWs5VzE5VVZ0Y1dVMlhrODNPQ3BPV2M2SVhjOHRzSXI5MlpvY3R1c1FV?= =?utf-8?B?YytEQkxvR3RoSWFTeVYyaHRkN09wNHZjQ1hmSVVUaFdNd3JNeDVHdTNIOEQ0?= =?utf-8?B?TXR5cko1WkVZbml5MXQwVnE1Mm9LeGpTLzV3NFZzeVVNSmVPd1J2eS9LNHp2?= =?utf-8?B?d1VvWjdMZXFnSVVRTXFOSGpJZEJZZy9aK0RsVlBweTM4ekhwUm5ma2tQc3F2?= =?utf-8?B?Z3ZPZW0xZTlSK0ZjTUdmMWp1UHdCeEIvQ2lYRjZKT3RpWXMxeEtEa01ETjJM?= =?utf-8?Q?VMIzYEaurlhfhl/3J7uRWTHBl?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: dC0ip8Q94KcRwFOMbeM0myalosUHLYKONxmy3Oib5oyLk3ePj8qWvDq+eOsoXs0xYLJIJ8A3vJ48nnGCbiwhWDFEFOp9Ex0+8t9KRwIzfrSIW942azZaHxCZfc4QJE9zL9anhGzIKIIiLpoQ4v3uHXbpiKuR7/ZybDQlEU7pvkMz3Q5Q2yaLZ4bGVv+diiSf8gB0YqiKeJiTaGMG6M4rut/eQHVtxa8s0e+DBQe4nmYarXa/02iVj6/AAhVdCvg5v9G0rV+QVDWStUtIH6b5ZyijAqEdDjp3pLpqllMcmNtRgNKR6JhlUxjqjKod3VH0qT+C6liCs2CEW2G88tVbF2khhTL9rx6zkQ5AIcgGvATqBAmPs7V1GUxOKQJa2q41tLKFIVXBk2O8hYfsR5J406QTbScdAoA4MHEFbe51KJZAAQGmWMflRcIfjf8lcol88d57/hSCR0b7fIjunMKDPc+dRLNrok8kH+wWxrJ6aiZlBn/6ZGJm2+QuyvPpRDhvQxgMMdL54YVVW0q+OWaZAI05tJOSO8QxnLrWkw5DwPRSeMAno8T2Lu1TjeuIO2CqUmp6pSIJwyJ3UOcT7hgLUd50wTEqnIwWNKliL7jJbvvPSNOt1VuQMQ716qL3zvh7hcCSPfECD2+uvRxxhaGuhsqYA0nWPS+CuPJrowC5kOq+AkIWUJ+6uF4QsVXqASDuYCarUs9CEmm6eWxclgDASl3xEZ9mo2CmkevXe5dOpKzAdXdPVIgDdLEMhL9eiKoXNVRuCx15QaM2t8Yc6qAed3smv3qEqYXHi/QqdleY2Fk6mGIwhxDkLKPzZ3Y+oeB8uhC0jszW9aLnOlgOcsDLCA== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9b866fd3-80ff-448c-4539-08db7c750257 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 09:56:59.6823 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pB8n+i5z6//g6H1OailAKN7JNo+XO9XdqcZHznzIcn3YqKoOEchWrXSbMHmYS7SX442x7HDqNZconzzFyab3mQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR03MB7525 On Tue, Jul 04, 2023 at 10:37:38AM +0100, Anthony PERARD wrote: > On Wed, Jun 28, 2023 at 02:31:39PM +0200, Roger Pau Monné wrote: > > On Fri, Jun 23, 2023 at 03:04:21PM +0000, osstest service owner wrote: > > > flight 181558 xen-unstable real [real] > > > http://logs.test-lab.xenproject.org/osstest/logs/181558/ > > > > > > Regressions :-( > > > > > > Tests which did not succeed and are blocking, > > > including tests which could not be run: > > > test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 181545 > > > > The test failing here is hitting the assert in qemu_cond_signal() as > > called by worker_thread(): > > > > #0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50 > > #1 0x00007ffff740b535 in __GI_abort () at abort.c:79 > > #2 0x00007ffff740b40f in __assert_fail_base (fmt=0x7ffff756cef0 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=0x55555614abcb "cond->initialized", > > file=0x55555614ab88 "../qemu-xen-dir-remote/util/qemu-thread-posix.c", line=198, function=) at assert.c:92 > > #3 0x00007ffff74191a2 in __GI___assert_fail (assertion=0x55555614abcb "cond->initialized", file=0x55555614ab88 "../qemu-xen-dir-remote/util/qemu-thread-posix.c", line=198, > > function=0x55555614ad80 <__PRETTY_FUNCTION__.17104> "qemu_cond_signal") at assert.c:101 > > #4 0x0000555555f1c8d2 in qemu_cond_signal (cond=0x7fffb800db30) at ../qemu-xen-dir-remote/util/qemu-thread-posix.c:198 > > #5 0x0000555555f36973 in worker_thread (opaque=0x7fffb800dab0) at ../qemu-xen-dir-remote/util/thread-pool.c:129 > > #6 0x0000555555f1d1d2 in qemu_thread_start (args=0x7fffb8000b20) at ../qemu-xen-dir-remote/util/qemu-thread-posix.c:505 > > #7 0x00007ffff75b0fa3 in start_thread (arg=) at pthread_create.c:486 > > #8 0x00007ffff74e206f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95 > > > > I've been trying to figure out how it can get in such state, but so > > far I had no luck. I'm not a QEMU expert, so it's probably better if > > someone else could handle this. > > > > In the failures I've seen, and the reproduction I have, the assert > > triggers in the QEMU dom0 instance responsible for locally-attaching > > the disk to dom0 in order to run pygrub. > > > > This is also with QEMU 7.2, as testing with upstream QEMU is blocked > > ATM, so there's a chance it has already been fixed upstream. > > > > Thanks, Roger. > > So, I've run a test with the latest QEMU and I can still reproduce the > issue. The test also fails with QEMU 7.1.0. > > But, QEMU 7.0 seems to pass the test, even with a start-stop loop of 200 > iteration. So I'll try to find out if something change in that range. > Or try to find out why would the thread pool be not initialised > properly. Thanks for looking into this. There are a set of changes from Paolo Bonzini: 232e9255478f thread-pool: remove stopping variable 900fa208f506 thread-pool: replace semaphore with condition variable 3c7b72ddca9c thread-pool: optimize scheduling of completion bottom half That landed in 7.1 that seem like possible candidates. Roger. From xen-devel-bounces@lists.xenproject.org Tue Jul 04 09:57:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 09:57:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558221.872113 (Exim 4.92) (envelope-from ) id 1qGcn7-0006X3-KF; Tue, 04 Jul 2023 09:57:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558221.872113; Tue, 04 Jul 2023 09:57:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGcn7-0006Ww-HY; Tue, 04 Jul 2023 09:57:49 +0000 Received: by outflank-mailman (input) for mailman id 558221; Tue, 04 Jul 2023 09:57:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGcn5-0006Ui-Pl for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 09:57:48 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on20608.outbound.protection.outlook.com [2a01:111:f400:fe16::608]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 398c1112-1a51-11ee-8611-37d641c3527e; Tue, 04 Jul 2023 11:57:45 +0200 (CEST) Received: from DB9PR05CA0022.eurprd05.prod.outlook.com (2603:10a6:10:1da::27) by GV2PR08MB10355.eurprd08.prod.outlook.com (2603:10a6:150:de::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 09:57:38 +0000 Received: from DBAEUR03FT007.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1da:cafe::ca) by DB9PR05CA0022.outlook.office365.com (2603:10a6:10:1da::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.30 via Frontend Transport; Tue, 4 Jul 2023 09:57:38 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT007.mail.protection.outlook.com (100.127.142.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.18 via Frontend Transport; Tue, 4 Jul 2023 09:57:37 +0000 Received: ("Tessian outbound c63645f235c1:v142"); Tue, 04 Jul 2023 09:57:37 +0000 Received: from 3d7faca57838.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id AB5D6D7C-F7B5-4301-B875-DD30A0CEAEA4.1; Tue, 04 Jul 2023 09:57:27 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3d7faca57838.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 04 Jul 2023 09:57:27 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by AM9PR08MB6114.eurprd08.prod.outlook.com (2603:10a6:20b:287::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 09:57:25 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::ed0b:5730:a1f9:577b]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::ed0b:5730:a1f9:577b%5]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 09:57:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 398c1112-1a51-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mpShW9uqqSM9P2gZGRUtZ9yTX/59FwNAyOOHoafKpTs=; b=W1nV1w8yePTIeiCurvbc1UGIJ8Y5NE/wj5yNHW3A8zrGwnYVh7hXNrOhH2pFJiYXZ+jaf9Hk5J4tNDSuEBr2SM5dS6LPPtp/n4s8t/XxbIuXQeQQPZZkZXoqTqz3jLswTbI47ejXFrGLMsliYzFGKb7Hr1Y8T9xsX/jkxxd5De0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 5664a9e3cd9d4085 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VYyHTopk82rBfY/7UoI0bP3o7KiGcUMn1vNiNmrOlVB6N31ksVoGtSxIy6y9Be64ApYfKuFQR9C8uOWZIcGkzn53yaFFR0UqfIW3KdPPhTnxRuPOSQcJvWE+yA1SWKTjyj1pbzzYeiL0CNiecDxoP7pLkBz3eRIOZZYJNYzbd/ie6KKNAhTWDsk28Jbki0Tj1rKzrT3l+WQNi5cdDr8QBlkGyu7wFDmjysZCkawpDE2e2qbSLxgc+p7aPRsjlk6R5sAiflZsXySgMANv4TvbOALsLZRZuXMxXEtT7w3aO3tuBiE69YMb6nF/HrT48Zw2Ye/6sZ6Kl4PLtL8Avm6OqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mpShW9uqqSM9P2gZGRUtZ9yTX/59FwNAyOOHoafKpTs=; b=kG9rsHN9pp79uzrdlYylnL320a7vWe2LQFq80Bgm5dTrAl0xekFNBgJmF48MgN3rTR5kgwrjiz7ToVog/mxTUfa4lT2/QiR8s0sNxUDhG5ZBo1yrsyAjF593t9qgfwmrSZrcOq48//AiKmfF1vjopmCKphtj2aG/p6+9yUWsg0bXg1TgNydAZ5z1LC8JJ/ykpjvwn801khsJR1BuH81dot8FyozqfxZO5elbJVwisLLYYdwy0DrzGuPxe8U5FHY52tJYcnaK/AguR7jHAnvKWqCOV6y44tnZ8HrEGHJ1ke6BEVfhu4zlHrhI2yj/s57qMNXYO7HQ4XeaMrRCgGgkwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mpShW9uqqSM9P2gZGRUtZ9yTX/59FwNAyOOHoafKpTs=; b=W1nV1w8yePTIeiCurvbc1UGIJ8Y5NE/wj5yNHW3A8zrGwnYVh7hXNrOhH2pFJiYXZ+jaf9Hk5J4tNDSuEBr2SM5dS6LPPtp/n4s8t/XxbIuXQeQQPZZkZXoqTqz3jLswTbI47ejXFrGLMsliYzFGKb7Hr1Y8T9xsX/jkxxd5De0= From: Luca Fancellu To: P S CC: Stefano Stabellini , "Daniel P. Smith" , Christopher Clark , Andrew Cooper , Xen-devel , Wei Chen , George Dunlap , Jan Beulich , Julien Grall , Wei Liu , Henry Wang , Community Manager , Doug Goldstein , Bertrand Marquis , Volodymyr Babchuk , Anthony PERARD Subject: Re: [RFC PATCH] xen/arm: Rebranding dom0less feature Thread-Topic: [RFC PATCH] xen/arm: Rebranding dom0less feature Thread-Index: AQHZqzMUKP6yBnvUfEC1egkdxmuozK+ki8cAgAB66ACAAukxgIAAZuEAgAAgQQCAABPDAIAA2qUA Date: Tue, 4 Jul 2023 09:57:24 +0000 Message-ID: <5C1EE299-1779-4FA4-BE22-392E819A496F@arm.com> References: <8601CDD7-87F7-4FD0-A6E6-BAEAB12E7956@arm.com> <234199F8-DBB1-42B6-9A4C-8800EEF60997@gmail.com> In-Reply-To: <234199F8-DBB1-42B6-9A4C-8800EEF60997@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.600.7) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|AM9PR08MB6114:EE_|DBAEUR03FT007:EE_|GV2PR08MB10355:EE_ X-MS-Office365-Filtering-Correlation-Id: 97e77884-49a0-45f2-00a4-08db7c751930 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: rEaC5Ztop0saiuGs+yn22a1CFYIorES3L+JRbzN2J4ym1liU+rHNwRTFbvaadrpBMKRD7hNCSGtZkSRwpzkGO+ShkHkPp5MJvKDl5OBRFNn2kRRqSZKFZS0XP9BUkMVSi1SXVwey5QuT21Q4V1hkF/ZXtnbenwRT3dgramR82GnA4GkEXbQLFFiVdNNDexQaQZYLlZqRl7l5ZkaExDwdH1NoUEvXRw+RSd1gH8XwkA+7Ju1d/Hd6C/pTxwYM4galMoj/GNhq7uV2no6TFd2fxaRhqmajMA+toKnIpYi1oat2Ao/pqonS+Hx5WqbqgFC5KS2GM59Z5tckLIKJhXzgB2aN6W/BSMIvQ0l4u0IMT9lupGreAbBXrStyOA5LJkopZGcTcg+7VCQJYYtLZ+unXUevvYTyBAljg6gVX5K6mYWHY7cktWmkp8WKYEwDZMK66KWRxGzfxFSfj7TxjPYUs3CrvXdozFZjDlTe4WTz3vb8J/GTaHyeCJGgiq7hHUVmxzdNiCLkjG4PsWgT8psiUnmDPNDRiUnS9IlniCT6Pu7Euu3eeBfMf3WBEMp1yp50n9ZjolzpTTfSeKI1Ri4bZJSHiEKrVro3foWTgwgGQgpUtuTqH9mu+KwtPFpYfFOrZDkPy0RwqoYVCpmvk1e44O3bSZn4h1iwHXysAdSyito= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(376002)(136003)(346002)(39860400002)(396003)(451199021)(478600001)(83380400001)(6512007)(86362001)(6486002)(6506007)(66946007)(38100700002)(76116006)(316002)(71200400001)(53546011)(186003)(122000001)(26005)(66556008)(66476007)(64756008)(4326008)(66446008)(91956017)(6916009)(54906003)(2616005)(7416002)(5660300002)(8936002)(8676002)(38070700005)(2906002)(41300700001)(33656002)(36756003)(32563001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <1278735821AFD448BAF561E66435101D@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6114 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f6fe61f1-9be8-40c1-197f-08db7c75114c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mu/uqxk7pvTVknmVBBJX9MgOCpGKIK+cVl9VIDOMN4zv1VuzirDu35kL9hNS0Oo4vUcjvp7wppIdOFiBmunaOoS3E944y+uXWDOeIluvsz19pxZrZbaR20qMuaGopKxSL4ZS31BjgAId3t6HwfqaSP3REQQhs752VhqhQJT8BSPuB2u1XzFc+J9r7ZBqG058rpHqgY4OtGv98Xl1sX/EcK8ZX3dwRV4GCyNVMk+/erRmtRoJR2SrMcLtrZiYWq+HyixKn364BbGxKsFi9ufW43t/HbC8xisvGaHQjlPHPbTylUitnzXtaZZLQj+HQswtz8+frPeXvJ9R4zLiTaBs2MUZakgHWJLWucDSzIitTuQxaF+3uP45sZHSYA15I7c8i7lqVW2JXhq34BWZoft0MQs6kU5Vi6h7YFrmxvcuWIHJOW3mo+L12jZ6qRlwfLniw9vPAU1gz+UKSvmruVWPUGdfHsNpW56KI50p0mhRYcRV15fdS+NxP9iirN2R+UU8Tsu7NYBfgNDC/yOKNco2WgWHSkiMdkLLZ/CQPbBvSKUoUl5JVfHY6Ff76q6aKb7IYppEK3qt+3mkWKlTCeZEi60NqJHi59Qdc3ImVlktRode2zIkRLlZrG/lmSgnnbprpPlZ7+C0LJj+s668Dni/btZfOhrM+3mCr6hDjcl8lO5iUtW1kzLAXYURlNqazP72Rb///ggyZzsb9kT/BhAml6JiV/vsoYLzBrltwauK4iyN532o5THnKoOPZtBoPawxSranOxmrVJGee1z3edQ8iA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(376002)(136003)(396003)(346002)(39860400002)(451199021)(36840700001)(46966006)(40470700004)(478600001)(336012)(36860700001)(83380400001)(47076005)(6512007)(6486002)(86362001)(107886003)(356005)(81166007)(70206006)(316002)(26005)(53546011)(186003)(82740400003)(54906003)(6506007)(4326008)(70586007)(2616005)(6862004)(5660300002)(8936002)(2906002)(40460700003)(8676002)(41300700001)(40480700001)(33656002)(82310400005)(36756003)(32563001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 09:57:37.8495 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 97e77884-49a0-45f2-00a4-08db7c751930 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB10355 DQoNCj4gT24gMyBKdWwgMjAyMywgYXQgMjE6NTQsIFAgUyA8cGFpcnNwYWNlQGdtYWlsLmNvbT4g d3JvdGU6DQo+IA0KPiANCj4gDQo+PiBPbiBKdWwgMywgMjAyMywgYXQgMTU6NDUsIEx1Y2EgRmFu Y2VsbHUgPGx1Y2EuZmFuY2VsbHVAYXJtLmNvbT4gd3JvdGU6DQo+PiANCj4+IO+7vw0KPj4gDQo+ Pj4gT24gMyBKdWwgMjAyMywgYXQgMTg6NDgsIFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxp bmlAa2VybmVsLm9yZz4gd3JvdGU6DQo+Pj4gDQo+Pj4+IE9uIE1vbiwgMyBKdWwgMjAyMywgRGFu aWVsIFAuIFNtaXRoIHdyb3RlOg0KPj4+PiBPbiA3LzEvMjMgMTE6MTMsIEx1Y2EgRmFuY2VsbHUg d3JvdGU6DQo+Pj4+Pj4gT24gMSBKdWwgMjAyMywgYXQgMDg6NTMsIEFuZHJldyBDb29wZXIgPGFu ZHJldy5jb29wZXIzQGNpdHJpeC5jb20+IHdyb3RlOg0KPj4+Pj4+IA0KPj4+Pj4+IE9uIDMwLzA2 LzIwMjMgMTA6MTIgYW0sIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+Pj4+Pj4+IFRoZSAiZG9tMGxl c3MiIGZlYXR1cmUgd2FzIGludGVuZGVkIHRvIGJlIHRoZSBmZWF0dXJlIHdoZXJlIGEgZG9tVQ0K Pj4+Pj4+PiBkb21haW4gY291bGQgYmUgbGF1bmNoZWQgd2l0aG91dCB0aGUgY29udHJvbCBkb21h aW4gKERvbTApDQo+Pj4+Pj4+IGludGVydmVudGlvbiwgaG93ZXZlciB0aGUgbmFtZSBzZWVtcyB0 byBzdWdnZXN0IHRoYXQgRG9tMCBjYW5ub3QNCj4+Pj4+Pj4gYmUgcGFydCBvZiB0aGUgY29uZmln dXJhdGlvbiwgd2hpbGUgaW5zdGVhZCBpdCdzIGEgcG9zc2libGUgdXNlIGNhc2UuDQo+Pj4+Pj4+ IA0KPj4+Pj4+PiBUbyBhdm9pZCB0aGF0LCByZW5hbWUgdGhlICJkb20wbGVzcyIgY29uZmlndXJh dGlvbiB3aXRoIHRoZSBuYW1lDQo+Pj4+Pj4+ICJoeXBlcmxhdW5jaCIsIHRoYXQgaXMgbGVzcyBt aXNsZWFkaW5nLg0KPj4+Pj4+PiANCj4+Pj4+Pj4gU2lnbmVkLW9mZi1ieTogTHVjYSBGYW5jZWxs dSA8bHVjYS5mYW5jZWxsdUBhcm0uY29tPg0KPj4+Pj4+PiAtLS0NCj4+Pj4+Pj4gVGhpcyBpcyBh biBSRkMgdG8gZ2V0IHRoZSBmZWVsaW5nIG9mIHRoZSBjb21tdW5pdHkgYWJvdXQgdGhlIG5hbWUN Cj4+Pj4+Pj4gY2hhbmdlLCBmb3Igbm93IGl0J3MgZXZlcnl0aGluZyBpbiBvbmUgcGF0Y2gganVz dCB0byBzZWUgaG93IGl0DQo+Pj4+Pj4+IHdpbGwgbG9vayBsaWtlLCBpZiB0aGVyZSBpcyBpbnRl cmVzdCBvbiBwcm9jZWVkaW5nIGludG8gaXQsIEkgY2FuDQo+Pj4+Pj4+IHNwbGl0IGluIG1vcmUg Y29tbWl0Lg0KPj4+Pj4+IA0KPj4+Pj4+IEhhdmUgeW91IGRpc2N1c3NlZCB0aGlzIHdpdGggRGFu IGFuZCBDaHJpcyBhdCBhbGw/ICBZb3UgaGF2ZW4ndCBldmVuDQo+Pj4+Pj4gQ0MnZCB0aGVtLg0K Pj4+Pj4gDQo+Pj4+PiBObywgdGhpcyByZW5hbWUgaWRlYSBzdGFydGVkIGZyb20gYSBjaGF0IGR1 cmluZyB0aGUgc3VtbWl0LCBhbnl3YXkgSnVsaWVuDQo+Pj4+PiBwcm9tcHRseSBhZGQgdGhlbSB0 byB0aGUgQ0MsIGJlY2F1c2UgSSBmb3Jnb3QuDQo+Pj4+IA0KPj4+PiBObyB3b3JyaWVzIGFuZCB0 aGFuayB5b3UgZm9yIGNvbnNpZGVyaW5nIGFuZCB0YWtpbmcgdGhlIHRpbWUgdG8gZG8gdGhpcyBS RkMuDQo+Pj4+IEl0IGlzIGdyZWF0bHkgYXBwcmVjaWF0ZWQgdGhhdCB0aGVyZSBpcyBhIHN0cm9u ZyB3aWxsaW5nbmVzcyB0byBoYXZlIGRvbTBsZXNzDQo+Pj4+IGFuZCBoeXBlcmxhdW5jaCBtZXJn ZWQuDQo+Pj4+IA0KPj4+Pj4+IA0KPj4+Pj4+IFdoaWxlIHRoZXJlIGlzIGEgbG90IG9mIGVuZC1n b2FsIGluIGNvbW1vbiBiZXR3ZWVuIHRoZSBkb20wbGVzcyBhbmQNCj4+Pj4+PiBoeXBlcmxhdW5j aCwgYW5kIHRoYXQgdGhlIG5hbWUgZG9tMGxlc3MgaXMgZGVlcGx5IG1pc2xlYWRpbmcsDQo+Pj4+ Pj4gaHlwZXJsYXVuY2ggaXMgc3BlY2lmaWNhbGx5IG5vdCB0aGlzLg0KPj4+Pj4gDQo+Pj4+PiBZ ZXMgSHlwZXJsYXVuY2ggaXMgbW9yZSB0aGFuIHRoaXMsIGhvd2V2ZXIgYXMgSSBzYWlkLCB3aXRo IHRoaXMgUkZDIEkgd291bGQNCj4+Pj4+IGxpa2UNCj4+Pj4+IHRvIGVhciBvcGluaW9ucywgQERh bmllbCBAQ2hyaXN0b3BoZXIgY291bGQgaXQgYmUgYSBwcm9wZXIgbmFtZSBmb3IgdGhlDQo+Pj4+ PiBkb20wbGVzcw0KPj4+Pj4gZmVhdHVyZT8NCj4+Pj4gDQo+Pj4+IEFzIEFuZHkgaGFzIGFsbHVk ZWQsIGh5cGVybGF1bmNoIGlzIG1lYW50IHRvIHByb3ZpZGUgYSBmbGV4aWJsZSBtZWFucyB0bw0K Pj4+PiBoYW5kbGUgZG9tYWluIGNvbnN0cnVjdGlvbiBhdCBib290IHRvIG1lZXQgYSB3aWRlIHJh bmdlIG9mIHBvc3NpYmxlIHVzZSBjYXNlcy4NCj4+Pj4gT25lIG9mIHRob3NlIHVzZSBjYXNlcyBp cyBkb20wbGVzcywgc28geWVzLCB1bHRpbWF0ZWx5IHdoYXQgZG9tMGxlc3MgZG9lcw0KPj4+PiB0 b2RheSB3aWxsIGJlIGFjaGlldmFibGUgdW5kZXIgaHlwZXJsYXVuY2guIE91ciBpbnRlbmRlZCBh cHByb2FjaCB0byBhbGlnbiB0aGUNCj4+Pj4gdHdvIGltcGxlbWVudGF0aW9ucyBpcyBvbmUgdGhh dCBpcyBtZWFudCB0byBiZSBtaW5pbWFsbHkgZGlzcnVwdGl2ZSwgc2luY2UNCj4+Pj4gZG9tMGxl c3MgaXMgY29uc2lkZXJlZCBhIHN1cHBvcnRlZCAoU1VQUE9SVC5tZCkgY2FwYWJpbGl0eS4gQXMg bWVudGlvbmVkLCB3ZQ0KPj4+PiBhcmUgZ3JlYXRseSBhcHByZWNpYXRpdmUgdG8gdGhlIG9wZW5u ZXNzIHRvIGFkb3B0IHRoZSBuYW1lLA0KPj4+IA0KPj4+IFRoYW5rcyBEYW5pZWwhDQo+Pj4gDQo+ Pj4gDQo+Pj4+IGJ1dCBhIGJpZyBjb25jZXJuDQo+Pj4+IEkgcGVyc29uYWxseSBoYXZlIGlzIHRo ZSBjb25mdXNpb24gaXQgY291bGQgY2F1c2UgYSBnZW5lcmFsIHVzZXIuIEEgYmxhbmtldA0KPj4+ PiByZW5hbWUgd291bGQgZW5kIHVwIHdpdGggdHdvIGRvY3VtZW50cyBpbiB0aGUgZG9jcyB0cmVl IHRoYXQgcHJvdmlkZSB0d28NCj4+Pj4gZGlmZmVyZW50IGV4cGxhbmF0aW9ucyBvZiBoeXBlcmxh dW5jaCBhbmQgdHdvIGRpZmZlcmVudCBkZXZpY2UgdHJlZQ0KPj4+PiBkZWZpbml0aW9ucy4gU28g SSB0aGluayBhIG1vcmUgbWVhc3VyZWQgYXBwcm9hY2ggc2hvdWxkIGJlIGNvbnNpZGVyZWQgaGVy ZS4NCj4+Pj4gDQo+Pj4+PiBJZiB0aGlzIHBhdGNoIG1ha2VzIHRoaW5ncyBtb3JlIGRpZmZpY3Vs dCBmb3IgdGhlIEh5cGVybHVuY2ggc2VyaWUsIEnigJltIG9rDQo+Pj4+PiB0byBkcm9wIGl0LA0K Pj4+Pj4gbXkgb25seSBhaW0gd2FzIGp1c3QgdG8gZmluZCBhIGxlc3MgbWlzbGVhZGluZyBuYW1l IGZvciB0aGUgZmVhdHVyZS4NCj4+Pj4gDQo+Pj4+IFdoYXQgSSB3b3VsZCBsaWtlIHRvIHN1Z2dl c3QgYXMgYSBnb29kIGZpcnN0IHN0ZXAgd291bGQgYmUgYW4gdXBkYXRlIHRvIHRoZQ0KPj4+PiBk b20wbGVzcyBkb2N1bWVudC4gUHJvdmlkZSBhIG5vdGUgYXQgdGhlIGJlZ2lubmluZyB0aGF0IHBv aW50cyB0byB0aGUNCj4+Pj4gaHlwZXJsYXVuY2ggZGVzaWduIGRvYyBhcyBhIG1vcmUgZ2VuZXJh bCBhcHByb2FjaCB0aGF0IHdpbGwgZXZlbnR1YWxseSBzdWJzdW1lDQo+Pj4+IGRvbTBsZXNzLiBU aGlzIHdvdWxkIHByb3ZpZGUgYSBnZW50bGVyIHRyYW5zaXRpb24gZm9yIGV4aXN0IHVzZXJzIG9m IGRvbTBsZXNzLg0KPj4+PiANCj4+Pj4gSWYgaXQgaXMgbm90IHRvbyBtdWNoLCBJIHdvdWxkIGFs c28gYXNrLCBwbGVhc2UgaGF2ZSBhIGxvb2sgYXQgdGhlIGRlc2lnbiBmb3INCj4+Pj4gYm9vdCBt b2R1bGVzIGluIHRoZSBzZXJpZXMgQ2hyaXN0b3BoZXIganVzdCBwb3N0ZWQuIFRoZSBkZXNpZ24g cHVsbHMgZnJvbSB0aGUNCj4+Pj4gd29yayBkb25lIGJ5IGRvbTBsZXNzIGFuZCBleHBhbmRlZCB1 cG9uIGl0LiBJIG1ham9yIHN0ZXAgaW50byBtZXJnaW5nIHRoZSB0d28NCj4+Pj4gY2FwYWJpbGl0 aWVzIHdpbGwgYmUgdG8gaGF2ZSBhIGNvbW1vbiBzZXQgb2Ygc3RydWN0dXJlcy4gT25jZSB0aG9z ZSBhcmUgaW4NCj4+Pj4gcGxhY2UsIHdlIGNhbiBtb3ZlIHRvIGEgY29tbW9uIGRldmljZSB0cmVl IHJlcHJlc2VudGF0aW9uLCBhbmQgYXQgdGhhdCBwb2ludA0KPj4+PiB3ZSB3b3VsZCBiZSBmYWly bHkgY2xvc2UsIGlmIG5vdCBhdCB0aGUgcG9pbnQgb2YgYSBmb3JtYWwgbWVyZ2VyIG9mIGJldHdl ZW4NCj4+Pj4gdGhlIHR3by4NCj4+PiANCj4+PiBBdCB0aGUgbW9tZW50IHdlIGhhdmUgYSBjb25j cmV0ZSBwcm9ibGVtIHdpdGggZXhwbGFpbmluZyBkb20wbGVzcyBhbmQNCj4+PiBoeXBlcmxhdW5j aCB0byBwb3RlbnRpYWwgbmV3IHVzZXJzLiBVc2luZyB0d28gZGlmZmVyZW50IG5hbWVzIGZvciBh DQo+Pj4gc2ltaWxhciBmZWF0dXJlIG9uIGFybSBhbmQgeDg2IGNhdXNlcyBjb25mdXNpb24uIEl0 IGlzIGh1cnRpbmcgWGVuIGFzIGENCj4+PiBzb2x1dGlvbi4gUGVyc29uYWxseSBJIGFscmVhZHkg aGFkIHRvIHN3aXRjaCB0byB1c2UgdGhlIHdvcmQNCj4+PiAiaHlwZXJsYXVuY2giIGZvciBldmVy eXRoaW5nIGluIG15IHVzZXJzLWZhY2luZyBwcmVzZW50YXRpb25zLg0KPj4+IA0KPj4+IEF0IHRo ZSBzdW1taXQsIHdlIGRpc2N1c3NlZCB0aGF0IGl0IHdvdWxkIGJlIGEgZ29vZCBpZGVhIHRvIHVz ZSBhIHNpbmdsZQ0KPj4+IG5hbWUgdG8gcmVmZXIgdG8gYm90aCBmZWF0dXJlcyBvbiBhcm0gYW5k IHg4Ni4gR2l2ZW4gdGhhdCAiZG9tMGxlc3MiDQo+Pj4gY2F1c2VzIGFkZGl0aW9uYWwgaXNzdWVz IGJlY2F1c2UgaXQgbWFrZXMgcGVvcGxlIHRoaW5rIHRoYXQgdGhlcmUgaXMgbm8NCj4+PiBEb20w LCB0aGUgc3VnZ2VzdGlvbiB3YXMgdG8gdXNlICJoeXBlcmxhdW5jaCIgdG8gcmVmZXIgdG8gYm90 aCBmZWF0dXJlcy4NCj4+PiANCj4+PiBXZSBkb24ndCBuZWVkIHRvIDEwMCUgYWxpZ24gdGhlIHR3 byBpbXBsZW1lbnRhdGlvbnMgYW5kIGRhdGEgc3RydWN0dXJlcy4NCj4+PiBUaGlzIGlzIG5vdCBm b3IgZW5naW5lZXJzIHRoYXQgYXJlIGdvaW5nIHRvIGxvb2sgYXQgdGhlIHNwZWNpZmljYXRpb25z DQo+Pj4gYW5kIGltcHJvdmUgdGhlbS4gVGhpcyBpcyBmb3IgdXNlcnMvY3VzdG9tZXJzIG9mIFhl biB0aGF0IGFyZSB0cnlpbmcgdG8NCj4+PiB1bmRlcnN0YW5kIHdoYXQgdGhlIGh5cGVydmlzb3Ig ZW5hYmxlcyB0aGVtIHRvIGRvLiBXZSBuZWVkIHRvIGJlIGFibGUgdG8NCj4+PiBzaG93IHVzZXJz IGFyY2hpdGVjdHVyZSBzbGlkZXMgd2l0aCB0aGUgc2FtZSBuYW1lIGFuZCBleHBsYW5hdGlvbiBv bg0KPj4+IGJvdGggQVJNIGFuZCB4ODYuDQo+Pj4gDQo+Pj4gSSBhbSBzdXJlIHRoYXQgRGFuaWVs IGFuZCBDaHJpc3RvcGhlciByZW1lbWJlciwgYnV0IGZvciB0aGUgb3RoZXJzIG9uDQo+Pj4gdGhp cyBlbWFpbCB0aHJlYWQsIHRoZSBuYW1lICJoeXBlcmxhdW5jaCIgd2FzIGJvcm4gZXhhY3RseSB0 byBiZSB0aGF0Og0KPj4+IHRoZSBvbmUgbmFtZSB0byBjb3ZlciBib3RoIGZlYXR1cmVzIG9uIEFS TSBhbmQgeDg2IGV2ZW4gaWYgdGhleSBoYXZlIGENCj4+PiBkaWZmZXJlbnQgaW1wbGVtZW50YXRp b24uIEFwcGVuZGVkIGFuIG9sZCBlbWFpbCBmb3IgcmVmZXJlbmNlLg0KPj4+IA0KPj4+IEFsc28g SSBhZ3JlZSB3aXRoIERhbmllbCB0aGF0IHdlIG5lZWQgdG8gYmUgY2FyZWZ1bCBhYm91dCB0aGUg dHdvIGRvY3MNCj4+PiB1bmRlciBkb2NzLy4gSSB0aGluayBoZSBpcyByaWdodCB3ZSBuZWVkIHRv IGFkZCBhIHBhcmFncmFwaCBleHBsYWluaW5nDQo+Pj4gdGhlIGhpc3RvcnkgYW5kIGEgcG9pbnRl ciB0byB0aGUgb3RoZXIgZG9jdW1lbnQuIFNvbWV0aGluZyBsaWtlOg0KPj4+IA0KPj4+ICJEb20w bGVzcyBpcyB0aGUgbmFtZSB0aGF0IHdhcyB1c2VkIHdoZW4gaW5pdGlhbGx5IGludHJvZHVjaW5n IHRoZQ0KPj4+IGZlYXR1cmUgb24gQVJNLiBUaGVuLCB0aGUgImRvbTBsZXNzIiBuYW1lIHdhcyBy ZXRpcmVkIGluIGZhdm9yIG9mDQo+Pj4gImh5cGVybGF1bmNoIiB0byBhdm9pZCBjb25mdXNpb24g KGEgRG9tMCBtaWdodCBzdGlsbCBiZSBwcmVzZW50KSBhbmQgdG8NCj4+PiBhbGlnbiB3aXRoIHg4 NiAod2hlcmUgYSBzaW1pbGFyIGZlYXR1cmUgd2FzIGNhbGxlZCBoeXBlcmxhdW5jaCBmcm9tIHRo ZQ0KPj4+IHN0YXJ0KS4iDQo+PiANCj4+IEnigJltIGZ1bGx5IG9rIHRvIGFkZCBhIHNlY3Rpb24g bGlrZSB0aGlzIHBvaW50aW5nIHRvIHRoZSBIeXBlcmxhdW5jaCBkZXNpZ24uDQo+IA0KPiBfSWZf IHRoaXMgdGV4dCBpcyBhZGRlZCwgcGxlYXNlIGluY2x1ZGUgbGlua3MvcmVmZXJlbmNlcyB0byB0 aGUgSHlwZXJsYXVuY2ggd2lraSBwYWdlIGFuZCBIeXBlcmxhdW5jaCBkZXNpZ24gZG9jcy4NCj4g DQo+PiBARGFuaWVsIGFuZCBAQ2hyaXN0b3BoZXIgd291bGQgaXQgYmUgb2sgZm9yIHlvdSBvciB0 aGUgY2hhbmdlcyBpbiB0aGUgc2VyaWUNCj4+IGFyZSBnb2luZyB0byBiZSBwcm9ibGVtYXRpYyBm b3IgeW91ciBmdXR1cmUgd29yaz8gSW4gdGhlIGVuZCBpdOKAmXMganVzdCBhIG1lY2hhbmljYWwN Cj4+IHJlbmFtZSwgc28gSSBndWVzcyB3ZSBqdXN0IG5lZWQgdG8gYWdyZWUgb24gbmFtaW5nIGNv bnZlbnRpb25zLg0KPiANCj4gUGxlYXNlIHNlZSB0aGUgaGlzdG9yeSBvZiB0cmFkZW1hcmsgbGl0 aWdhdGlvbiBhYm91dCB0aGUgdXNlIG9mIHN5bWJvbGljIG5hbWVzIHRvIHJlZmVyZW5jZSBzaW1p bGFyLWJ1dC1kaWZmZXJlbnQgYXJ0aWZhY3RzLiAgSXQgaXMgbXVjaCBlYXNpZXIgdG8gdXNlIHRo ZSBzYW1lIG5hbWUgdG8gcmVmZXIgdG8gZW50aXJlbHkgZGlmZmVyZW50IG9iamVjdHMuIEhpc3Rv cmljYWxseSwgY29uZnVzaW9uIGFyaXNlcyB3aGVuIGEgbmFtZSBpcyB1c2VkIGluIHNpbWlsYXIg Y29udGV4dHMuDQo+IA0KPiBUaGVyZSBpcyBhbHNvIHZlcnNpb25pbmcuICBDb3VsZCB3ZSByZWZl ciB0byBkb20wbGVzcyBhcyAiSHlwZXJsYXVuY2ggVmVyc2lvbiAtMSI/IA0KPiANCj4gSG93IGFi b3V0IHJlbmFtaW5nIGRvbTBsZXNzIHRvICJIeXBlcmxhdW5jaCBMaXRlIj8NCg0KSeKAmW0gb2sg YXMgbG9uZyBhcyB0aGUgQXJtIG1haW50YWluZXIgYXJlIGhhcHB5IHdpdGggaXQNCg0KPiANCj4g UmljaA0KPiANCj4+IENoZWVycywNCj4+IEx1Y2ENCj4+IA0KPj4+IA0KPj4+IA0KPj4+IC0tLQ0K Pj4+IA0KPj4+IFN1YmplY3Q6IFtSRlBdIE92ZXJhcmNoaW5nIG5hbWUgZm9yIGRvbTBsZXNzIGFu ZCBEb21CDQo+Pj4gDQo+Pj4gR3JlZXRpbmdzLA0KPj4+IA0KPj4+IEF0IHRoZSBEZXZpY2VUcmVl L0RvbUIgbWVldGluZyBpdCB3YXMgcHJvcG9zZWQgdGhhdCBhIG5ldywgbGFyZ2VyDQo+Pj4gb3Zl cmFyY2hpbmcgbmFtZSB1bmRlciB3aGljaCBEb21CIGFuZCBkb20wbGVzcyB3b3VsZCBiZSBjb3Zl cmVkLiBUaGVyZQ0KPj4+IHdhcyBhIGdlbmVyYWwgb3Blbm5lc3MgdG8gdGhlIGlkZWEuIEFzIHN1 Y2gsIHNpbmNlIENocmlzdG9waGVyIGFuZA0KPj4+IG15c2VsZiBhcmUgaW4gdGhlIG1pZHN0IG9m IGZpbmFsaXppbmcgdGhlIGRlc2lnbiBkb2N1bWVudCBmb3IgRG9tQiB3ZQ0KPj4+IGZlbHQgaXQg bWlnaHQgYmUgYmV0dGVyIHRvIHNlZSBpZiBhIG5hbWUgY291bGQgYmUgc2VsZWN0ZWQgd2hpY2gg d2UNCj4+PiBjb3VsZCB1c2UgaW4gdGhlIGRlc2lnbiBkb2MgaW4gbGlldSBvZiBEb21CLiBBcyBh bHdheXMgbmFtaW5nIHRoaW5ncyBpcw0KPj4+IGhhcmQsIGJ1dCBhZnRlciBzb21lIGJyYWluc3Rv cm1pbmcgd2UgYmVsaWV2ZSB3ZSBoYXZlIGFycml2ZWQgYXQgYQ0KPj4+IGRlY2VudCBuYW1lLCDO vExhdW5jaCAobWljcm8tTGF1bmNoIG9yIHVMYXVuY2gpLg0KPj4+IA0KPj4+IC0tLQ0KPj4+IA0K Pj4+IM68TGF1bmNoIGJlY2FtZSBoeXBlcmxhdW5jaCBmZXcgZGF5cyBhZnRlciwgYW5kIHRoZSBy ZXN0IHdhcyBoaXN0b3J5IDotKQ0KPj4gDQo+PiANCg0K From xen-devel-bounces@lists.xenproject.org Tue Jul 04 10:10:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 10:10:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558226.872124 (Exim 4.92) (envelope-from ) id 1qGcyu-0008D6-MJ; Tue, 04 Jul 2023 10:10:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558226.872124; Tue, 04 Jul 2023 10:10:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGcyu-0008Cz-Jd; Tue, 04 Jul 2023 10:10:00 +0000 Received: by outflank-mailman (input) for mailman id 558226; Tue, 04 Jul 2023 10:09:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGcyt-0008Cp-DB; Tue, 04 Jul 2023 10:09:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGcys-00045z-TK; Tue, 04 Jul 2023 10:09:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGcys-0004Kj-9P; Tue, 04 Jul 2023 10:09:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qGcys-0003Ko-8e; Tue, 04 Jul 2023 10:09:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=iFavC+EK0FWsP1lHjixVXV0AnCfurkX9T1P4MvyFKVA=; b=AH287s9x/45tGmaMPbrnaDPe7w TWLgjIU8tuMgJaIbOFsfpGsbGdDQxjxeJy8NQTEOTjDRoVaM8LqIdaKg5c7v2+98pk0Q5zT1pVmbF vJzQQXwwKE3Zl8j9fTTjvmFsGFcHuTj0OAhp/PNom2suYlo4fYWO+43geXVvAa2dzjfo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 181689: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-i386-xl:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=f51e5d8eae8ece77a949571f39ee49904f3129aa X-Osstest-Versions-That: xen=f51e5d8eae8ece77a949571f39ee49904f3129aa From: osstest service owner Date: Tue, 04 Jul 2023 10:09:58 +0000 flight 181689 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/181689/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail in 181683 pass in 181689 test-amd64-i386-xl 7 xen-install fail pass in 181683 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail pass in 181683 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 181683 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 181683 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 181683 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 181683 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 181683 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 181683 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 181683 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 181683 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 181683 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 181683 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 181683 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 181683 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 181683 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen f51e5d8eae8ece77a949571f39ee49904f3129aa baseline version: xen f51e5d8eae8ece77a949571f39ee49904f3129aa Last test of basis 181689 2023-07-04 01:53:28 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Tue Jul 04 10:23:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 10:23:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558234.872134 (Exim 4.92) (envelope-from ) id 1qGdBs-0002ED-V2; Tue, 04 Jul 2023 10:23:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558234.872134; Tue, 04 Jul 2023 10:23:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGdBs-0002E6-SG; Tue, 04 Jul 2023 10:23:24 +0000 Received: by outflank-mailman (input) for mailman id 558234; Tue, 04 Jul 2023 10:23:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGdBr-0002E0-6O for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 10:23:23 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cc7e85a5-1a54-11ee-b237-6b7b168915f2; Tue, 04 Jul 2023 12:23:21 +0200 (CEST) Received: from Dell.bugseng.com (unknown [37.160.75.228]) by support.bugseng.com (Postfix) with ESMTPSA id 23B094EE0738; Tue, 4 Jul 2023 12:23:17 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc7e85a5-1a54-11ee-b237-6b7b168915f2 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Paul Durrant , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Jun Nakajima , Kevin Tian , Stefano Stabellini , Michal Orzel , Xenia Ragiadakou , Ayan Kumar Halder Subject: [XEN PATCH v2] x86: make function declarations consistent with definitions Date: Tue, 4 Jul 2023 12:23:03 +0200 Message-Id: <1b2d5be30c0e4f335e59dce6e7c001cb0805d702.1688465215.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Change mechanically the parameter names and types of function declarations to be consistent with the ones used in the corresponding definitions so as to fix violations of MISRA C:2012 Rule 8.3 ("All declarations of an object or function shall use the same names and type qualifiers") and MISRA C:2012 Rule 8.2 ("Function types shall be in prototype form with named parameters"). Signed-off-by: Federico Serafini --- Changes in v2: - fixed violations of Rule 8.2; - fixed violations of Rule 8.3 not only for parameter names but also for types. --- xen/arch/x86/cpu/mcheck/mce.h | 2 +- xen/arch/x86/cpu/mcheck/x86_mca.h | 2 +- xen/arch/x86/hvm/rtc.c | 2 +- xen/arch/x86/hvm/svm/nestedhvm.h | 2 +- xen/arch/x86/hvm/vioapic.c | 2 +- xen/arch/x86/include/asm/genapic.h | 2 +- xen/arch/x86/include/asm/guest_pt.h | 2 +- xen/arch/x86/include/asm/hap.h | 2 +- xen/arch/x86/include/asm/hvm/io.h | 2 +- xen/arch/x86/include/asm/hvm/monitor.h | 2 +- xen/arch/x86/include/asm/hvm/svm/vmcb.h | 2 +- xen/arch/x86/include/asm/hvm/vmx/vmcs.h | 4 ++-- xen/arch/x86/include/asm/hvm/vmx/vvmx.h | 16 +++++++------- xen/arch/x86/include/asm/io_apic.h | 2 +- xen/arch/x86/include/asm/irq.h | 6 ++--- xen/arch/x86/include/asm/mem_access.h | 2 +- xen/arch/x86/include/asm/mpspec.h | 2 +- xen/arch/x86/include/asm/msi.h | 4 ++-- xen/arch/x86/include/asm/p2m.h | 8 +++---- xen/arch/x86/include/asm/paging.h | 2 +- xen/arch/x86/include/asm/psr.h | 2 +- xen/arch/x86/include/asm/setup.h | 2 +- xen/arch/x86/include/asm/uaccess.h | 6 ++--- xen/arch/x86/include/asm/xstate.h | 2 +- xen/include/xen/lib/x86/cpu-policy.h | 29 +++++++++++++------------ 25 files changed, 55 insertions(+), 54 deletions(-) diff --git a/xen/arch/x86/cpu/mcheck/mce.h b/xen/arch/x86/cpu/mcheck/mce.h index bea08bdc74..72d8dbc471 100644 --- a/xen/arch/x86/cpu/mcheck/mce.h +++ b/xen/arch/x86/cpu/mcheck/mce.h @@ -44,7 +44,7 @@ extern uint8_t cmci_apic_vector; extern bool lmce_support; /* Init functions */ -enum mcheck_type amd_mcheck_init(struct cpuinfo_x86 *c); +enum mcheck_type amd_mcheck_init(struct cpuinfo_x86 *ci); enum mcheck_type intel_mcheck_init(struct cpuinfo_x86 *c, bool bsp); void amd_nonfatal_mcheck_init(struct cpuinfo_x86 *c); diff --git a/xen/arch/x86/cpu/mcheck/x86_mca.h b/xen/arch/x86/cpu/mcheck/x86_mca.h index 18116737af..36b6127a37 100644 --- a/xen/arch/x86/cpu/mcheck/x86_mca.h +++ b/xen/arch/x86/cpu/mcheck/x86_mca.h @@ -113,7 +113,7 @@ static inline int mcabanks_test(int bit, struct mca_banks* banks) return test_bit(bit, banks->bank_map); } -struct mca_banks *mcabanks_alloc(unsigned int nr); +struct mca_banks *mcabanks_alloc(unsigned int nr_mce_banks); void mcabanks_free(struct mca_banks *banks); extern struct mca_banks *mca_allbanks; diff --git a/xen/arch/x86/hvm/rtc.c b/xen/arch/x86/hvm/rtc.c index c1ab6c7d58..ebb259586a 100644 --- a/xen/arch/x86/hvm/rtc.c +++ b/xen/arch/x86/hvm/rtc.c @@ -59,7 +59,7 @@ enum rtc_mode { static void rtc_copy_date(RTCState *s); static void rtc_set_time(RTCState *s); static inline int from_bcd(RTCState *s, int a); -static inline int convert_hour(RTCState *s, int hour); +static inline int convert_hour(RTCState *s, int raw); static void rtc_update_irq(RTCState *s) { diff --git a/xen/arch/x86/hvm/svm/nestedhvm.h b/xen/arch/x86/hvm/svm/nestedhvm.h index 43245e13de..eb9c416307 100644 --- a/xen/arch/x86/hvm/svm/nestedhvm.h +++ b/xen/arch/x86/hvm/svm/nestedhvm.h @@ -42,7 +42,7 @@ int cf_check nsvm_vcpu_initialise(struct vcpu *v); int cf_check nsvm_vcpu_reset(struct vcpu *v); int nsvm_vcpu_vmrun(struct vcpu *v, struct cpu_user_regs *regs); int cf_check nsvm_vcpu_vmexit_event(struct vcpu *v, - const struct x86_event *event); + const struct x86_event *trap); uint64_t cf_check nsvm_vcpu_hostcr3(struct vcpu *v); bool cf_check nsvm_vmcb_guest_intercepts_event( struct vcpu *v, unsigned int vector, int errcode); diff --git a/xen/arch/x86/hvm/vioapic.c b/xen/arch/x86/hvm/vioapic.c index 41e3c4d5e4..4e40d3609a 100644 --- a/xen/arch/x86/hvm/vioapic.c +++ b/xen/arch/x86/hvm/vioapic.c @@ -43,7 +43,7 @@ /* HACK: Route IRQ0 only to VCPU0 to prevent time jumps. */ #define IRQ0_SPECIAL_ROUTING 1 -static void vioapic_deliver(struct hvm_vioapic *vioapic, unsigned int irq); +static void vioapic_deliver(struct hvm_vioapic *vioapic, unsigned int pin); static struct hvm_vioapic *addr_vioapic(const struct domain *d, unsigned long addr) diff --git a/xen/arch/x86/include/asm/genapic.h b/xen/arch/x86/include/asm/genapic.h index beeaddf19d..970df8ffe0 100644 --- a/xen/arch/x86/include/asm/genapic.h +++ b/xen/arch/x86/include/asm/genapic.h @@ -43,7 +43,7 @@ void cf_check send_IPI_self_legacy(uint8_t vector); void cf_check init_apic_ldr_flat(void); unsigned int cf_check cpu_mask_to_apicid_flat(const cpumask_t *cpumask); -void cf_check send_IPI_mask_flat(const cpumask_t *mask, int vector); +void cf_check send_IPI_mask_flat(const cpumask_t *cpumask, int vector); const cpumask_t *cf_check vector_allocation_cpumask_flat(int cpu); #define GENAPIC_FLAT \ .int_delivery_mode = dest_LowestPrio, \ diff --git a/xen/arch/x86/include/asm/guest_pt.h b/xen/arch/x86/include/asm/guest_pt.h index bde7588342..f616357107 100644 --- a/xen/arch/x86/include/asm/guest_pt.h +++ b/xen/arch/x86/include/asm/guest_pt.h @@ -422,7 +422,7 @@ static inline unsigned int guest_walk_to_page_order(const walk_t *gw) bool guest_walk_tables(const struct vcpu *v, struct p2m_domain *p2m, - unsigned long va, walk_t *gw, uint32_t pfec, + unsigned long va, walk_t *gw, uint32_t walk, gfn_t top_gfn, mfn_t top_mfn, void *top_map); /* Pretty-print the contents of a guest-walk */ diff --git a/xen/arch/x86/include/asm/hap.h b/xen/arch/x86/include/asm/hap.h index 9d12327b12..05e124ad57 100644 --- a/xen/arch/x86/include/asm/hap.h +++ b/xen/arch/x86/include/asm/hap.h @@ -30,7 +30,7 @@ void hap_vcpu_init(struct vcpu *v); int hap_track_dirty_vram(struct domain *d, unsigned long begin_pfn, unsigned int nr_frames, - XEN_GUEST_HANDLE(void) dirty_bitmap); + XEN_GUEST_HANDLE(void) guest_dirty_bitmap); extern const struct paging_mode *hap_paging_get_mode(struct vcpu *); int hap_set_allocation(struct domain *d, unsigned int pages, bool *preempted); diff --git a/xen/arch/x86/include/asm/hvm/io.h b/xen/arch/x86/include/asm/hvm/io.h index 8df33eb6cc..cad082f020 100644 --- a/xen/arch/x86/include/asm/hvm/io.h +++ b/xen/arch/x86/include/asm/hvm/io.h @@ -90,7 +90,7 @@ bool handle_mmio_with_translation(unsigned long gla, unsigned long gpfn, struct npfec); bool handle_pio(uint16_t port, unsigned int size, int dir); void hvm_interrupt_post(struct vcpu *v, int vector, int type); -void hvm_dpci_eoi(struct domain *d, unsigned int guest_irq); +void hvm_dpci_eoi(struct domain *d, unsigned int guest_gsi); void msix_write_completion(struct vcpu *); #ifdef CONFIG_HVM diff --git a/xen/arch/x86/include/asm/hvm/monitor.h b/xen/arch/x86/include/asm/hvm/monitor.h index 5276b0af08..02021be47b 100644 --- a/xen/arch/x86/include/asm/hvm/monitor.h +++ b/xen/arch/x86/include/asm/hvm/monitor.h @@ -25,7 +25,7 @@ bool hvm_monitor_cr(unsigned int index, unsigned long value, unsigned long old); #define hvm_monitor_crX(cr, new, old) \ hvm_monitor_cr(VM_EVENT_X86_##cr, new, old) -bool hvm_monitor_msr(unsigned int msr, uint64_t value, uint64_t old_value); +bool hvm_monitor_msr(unsigned int msr, uint64_t new_value, uint64_t old_value); void hvm_monitor_descriptor_access(uint64_t exit_info, uint64_t vmx_exit_qualification, uint8_t descriptor, bool is_write); diff --git a/xen/arch/x86/include/asm/hvm/svm/vmcb.h b/xen/arch/x86/include/asm/hvm/svm/vmcb.h index a1a8a7fd25..91221ff4e2 100644 --- a/xen/arch/x86/include/asm/hvm/svm/vmcb.h +++ b/xen/arch/x86/include/asm/hvm/svm/vmcb.h @@ -607,7 +607,7 @@ void setup_vmcb_dump(void); #define MSR_INTERCEPT_READ 1 #define MSR_INTERCEPT_WRITE 2 #define MSR_INTERCEPT_RW (MSR_INTERCEPT_WRITE | MSR_INTERCEPT_READ) -void svm_intercept_msr(struct vcpu *v, uint32_t msr, int enable); +void svm_intercept_msr(struct vcpu *v, uint32_t msr, int flags); #define svm_disable_intercept_for_msr(v, msr) svm_intercept_msr((v), (msr), MSR_INTERCEPT_NONE) #define svm_enable_intercept_for_msr(v, msr) svm_intercept_msr((v), (msr), MSR_INTERCEPT_RW) diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h index d07fcb2bc9..20ef8e3137 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h @@ -656,10 +656,10 @@ bool vmx_msr_is_intercepted(struct vmx_msr_bitmap *msr_bitmap, unsigned int msr, bool is_write) __nonnull(1); void virtual_vmcs_enter(const struct vcpu *); void virtual_vmcs_exit(const struct vcpu *); -u64 virtual_vmcs_vmread(const struct vcpu *, u32 encoding); +u64 virtual_vmcs_vmread(const struct vcpu *v, u32 vmcs_encoding); enum vmx_insn_errno virtual_vmcs_vmread_safe(const struct vcpu *v, u32 vmcs_encoding, u64 *val); -void virtual_vmcs_vmwrite(const struct vcpu *, u32 encoding, u64 val); +void virtual_vmcs_vmwrite(const struct vcpu *v, u32 vmcs_encoding, u64 val); enum vmx_insn_errno virtual_vmcs_vmwrite_safe(const struct vcpu *v, u32 vmcs_encoding, u64 val); diff --git a/xen/arch/x86/include/asm/hvm/vmx/vvmx.h b/xen/arch/x86/include/asm/hvm/vmx/vvmx.h index dc9db69258..715e509bc2 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vvmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vvmx.h @@ -144,15 +144,15 @@ enum vvmcs_encoding_type { VVMCS_TYPE_HSTATE, }; -u64 get_vvmcs_virtual(void *vvmcs, u32 encoding); -u64 get_vvmcs_real(const struct vcpu *, u32 encoding); -void set_vvmcs_virtual(void *vvmcs, u32 encoding, u64 val); -void set_vvmcs_real(const struct vcpu *, u32 encoding, u64 val); +uint64_t get_vvmcs_virtual(void *vvmcs, uint32_t vmcs_encoding); +u64 get_vvmcs_real(const struct vcpu *v, u32 encoding); +void set_vvmcs_virtual(void *vvmcs, uint32_t vmcs_encoding, uint64_t val); +void set_vvmcs_real(const struct vcpu *v, u32 encoding, u64 val); enum vmx_insn_errno get_vvmcs_virtual_safe(void *vvmcs, u32 encoding, u64 *val); -enum vmx_insn_errno get_vvmcs_real_safe(const struct vcpu *, u32 encoding, +enum vmx_insn_errno get_vvmcs_real_safe(const struct vcpu *v, u32 encoding, u64 *val); enum vmx_insn_errno set_vvmcs_virtual_safe(void *vvmcs, u32 encoding, u64 val); -enum vmx_insn_errno set_vvmcs_real_safe(const struct vcpu *, u32 encoding, +enum vmx_insn_errno set_vvmcs_real_safe(const struct vcpu *v, u32 encoding, u64 val); #define get_vvmcs(vcpu, encoding) \ @@ -180,9 +180,9 @@ int nvmx_handle_vmx_insn(struct cpu_user_regs *regs, unsigned int exit_reason); int nvmx_msr_read_intercept(unsigned int msr, u64 *msr_content); -void nvmx_update_exec_control(struct vcpu *v, u32 value); +void nvmx_update_exec_control(struct vcpu *v, u32 host_cntrl); void nvmx_update_secondary_exec_control(struct vcpu *v, - unsigned long value); + unsigned long host_cntrl); void nvmx_update_exception_bitmap(struct vcpu *v, unsigned long value); void nvmx_switch_guest(void); void nvmx_idtv_handling(void); diff --git a/xen/arch/x86/include/asm/io_apic.h b/xen/arch/x86/include/asm/io_apic.h index ef0878b09e..9b22448ef0 100644 --- a/xen/arch/x86/include/asm/io_apic.h +++ b/xen/arch/x86/include/asm/io_apic.h @@ -207,6 +207,6 @@ extern int restore_IO_APIC_setup(struct IO_APIC_route_entry **ioapic_entries, unsigned highest_gsi(void); int ioapic_guest_read( unsigned long physbase, unsigned int reg, u32 *pval); -int ioapic_guest_write(unsigned long physbase, unsigned int reg, u32 pval); +int ioapic_guest_write(unsigned long physbase, unsigned int reg, u32 val); #endif diff --git a/xen/arch/x86/include/asm/irq.h b/xen/arch/x86/include/asm/irq.h index 424b0e1af8..f49388a47f 100644 --- a/xen/arch/x86/include/asm/irq.h +++ b/xen/arch/x86/include/asm/irq.h @@ -112,7 +112,7 @@ void cf_check enable_8259A_irq(struct irq_desc *); int i8259A_irq_pending(unsigned int irq); void mask_8259A(void); void unmask_8259A(void); -void init_8259A(int aeoi); +void init_8259A(int auto_eoi); void make_8259A_irq(unsigned int irq); bool bogus_8259A_irq(unsigned int irq); int i8259A_suspend(void); @@ -141,7 +141,7 @@ struct arch_pirq { #define pirq_dpci(pirq) ((pirq) ? &(pirq)->arch.hvm.dpci : NULL) #define dpci_pirq(pd) container_of(pd, struct pirq, arch.hvm.dpci) -int pirq_shared(struct domain *d , int irq); +int pirq_shared(struct domain *d , int pirq); int map_domain_pirq(struct domain *d, int pirq, int irq, int type, void *data); @@ -149,7 +149,7 @@ int unmap_domain_pirq(struct domain *d, int pirq); int get_free_pirq(struct domain *d, int type); int get_free_pirqs(struct domain *, unsigned int nr); void free_domain_pirqs(struct domain *d); -int map_domain_emuirq_pirq(struct domain *d, int pirq, int irq); +int map_domain_emuirq_pirq(struct domain *d, int pirq, int emuirq); int unmap_domain_pirq_emuirq(struct domain *d, int pirq); /* Reset irq affinities to match the given CPU mask. */ diff --git a/xen/arch/x86/include/asm/mem_access.h b/xen/arch/x86/include/asm/mem_access.h index 8957e1181c..1a52a10322 100644 --- a/xen/arch/x86/include/asm/mem_access.h +++ b/xen/arch/x86/include/asm/mem_access.h @@ -39,7 +39,7 @@ int p2m_set_suppress_ve(struct domain *d, gfn_t gfn, bool suppress_ve, struct xen_hvm_altp2m_suppress_ve_multi; int p2m_set_suppress_ve_multi(struct domain *d, - struct xen_hvm_altp2m_suppress_ve_multi *suppress_ve); + struct xen_hvm_altp2m_suppress_ve_multi *sve); int p2m_get_suppress_ve(struct domain *d, gfn_t gfn, bool *suppress_ve, unsigned int altp2m_idx); diff --git a/xen/arch/x86/include/asm/mpspec.h b/xen/arch/x86/include/asm/mpspec.h index 1246eece0b..cf8b360259 100644 --- a/xen/arch/x86/include/asm/mpspec.h +++ b/xen/arch/x86/include/asm/mpspec.h @@ -26,7 +26,7 @@ extern void mp_register_lapic_address (u64 address); extern void mp_register_ioapic (u8 id, u32 address, u32 gsi_base); extern void mp_override_legacy_irq (u8 bus_irq, u8 polarity, u8 trigger, u32 gsi); extern void mp_config_acpi_legacy_irqs (void); -extern int mp_register_gsi (u32 gsi, int edge_level, int active_high_low); +extern int mp_register_gsi (u32 gsi, int triggering, int polarity); #endif /* CONFIG_ACPI */ #define PHYSID_ARRAY_SIZE BITS_TO_LONGS(MAX_APICS) diff --git a/xen/arch/x86/include/asm/msi.h b/xen/arch/x86/include/asm/msi.h index a53ade95c9..687df5942a 100644 --- a/xen/arch/x86/include/asm/msi.h +++ b/xen/arch/x86/include/asm/msi.h @@ -82,7 +82,7 @@ struct hw_interrupt_type; struct msi_desc; /* Helper functions */ extern int pci_enable_msi(struct msi_info *msi, struct msi_desc **desc); -extern void pci_disable_msi(struct msi_desc *desc); +extern void pci_disable_msi(struct msi_desc *msi_desc); extern int pci_prepare_msix(u16 seg, u8 bus, u8 devfn, bool off); extern void pci_cleanup_msi(struct pci_dev *pdev); extern int setup_msi_irq(struct irq_desc *, struct msi_desc *); @@ -220,7 +220,7 @@ struct arch_msix { }; void early_msi_init(void); -void msi_compose_msg(unsigned vector, const cpumask_t *mask, +void msi_compose_msg(unsigned vector, const cpumask_t *cpu_mask, struct msi_msg *msg); void __msi_set_enable(u16 seg, u8 bus, u8 slot, u8 func, int pos, int enable); void cf_check mask_msi_irq(struct irq_desc *); diff --git a/xen/arch/x86/include/asm/p2m.h b/xen/arch/x86/include/asm/p2m.h index 40545f5fa8..67bd3201bc 100644 --- a/xen/arch/x86/include/asm/p2m.h +++ b/xen/arch/x86/include/asm/p2m.h @@ -632,7 +632,7 @@ void p2m_change_type_range(struct domain *d, p2m_type_t ot, p2m_type_t nt); /* Compare-exchange the type of a single p2m entry */ -int p2m_change_type_one(struct domain *d, unsigned long gfn, +int p2m_change_type_one(struct domain *d, unsigned long gfn_l, p2m_type_t ot, p2m_type_t nt); /* Synchronously change the p2m type for a range of gfns */ @@ -661,9 +661,9 @@ int set_identity_p2m_entry(struct domain *d, unsigned long gfn, p2m_access_t p2ma, unsigned int flag); int clear_identity_p2m_entry(struct domain *d, unsigned long gfn); /* HVM-only callers can use these directly: */ -int p2m_add_identity_entry(struct domain *d, unsigned long gfn, +int p2m_add_identity_entry(struct domain *d, unsigned long gfn_l, p2m_access_t p2ma, unsigned int flag); -int p2m_remove_identity_entry(struct domain *d, unsigned long gfn); +int p2m_remove_identity_entry(struct domain *d, unsigned long gfn_l); /* * Populate-on-demand @@ -924,7 +924,7 @@ int p2m_altp2m_propagate_change(struct domain *d, gfn_t gfn, p2m_type_t p2mt, p2m_access_t p2ma); /* Set a specific p2m view visibility */ -int p2m_set_altp2m_view_visibility(struct domain *d, unsigned int idx, +int p2m_set_altp2m_view_visibility(struct domain *d, unsigned int altp2m_idx, uint8_t visible); #else /* !CONFIG_HVM */ struct p2m_domain *p2m_get_altp2m(struct vcpu *v); diff --git a/xen/arch/x86/include/asm/paging.h b/xen/arch/x86/include/asm/paging.h index 403243bfbd..a72a8d63ce 100644 --- a/xen/arch/x86/include/asm/paging.h +++ b/xen/arch/x86/include/asm/paging.h @@ -246,7 +246,7 @@ paging_fault(unsigned long va, struct cpu_user_regs *regs) } /* Handle invlpg requests on vcpus. */ -void paging_invlpg(struct vcpu *v, unsigned long va); +void paging_invlpg(struct vcpu *v, unsigned long linear); /* * Translate a guest virtual address to the frame number that the diff --git a/xen/arch/x86/include/asm/psr.h b/xen/arch/x86/include/asm/psr.h index c2257da7fc..8ecb7a0eea 100644 --- a/xen/arch/x86/include/asm/psr.h +++ b/xen/arch/x86/include/asm/psr.h @@ -81,7 +81,7 @@ int psr_get_info(unsigned int socket, enum psr_type type, int psr_get_val(struct domain *d, unsigned int socket, uint32_t *val, enum psr_type type); int psr_set_val(struct domain *d, unsigned int socket, - uint64_t val, enum psr_type type); + uint64_t new_val, enum psr_type type); void psr_domain_init(struct domain *d); void psr_domain_free(struct domain *d); diff --git a/xen/arch/x86/include/asm/setup.h b/xen/arch/x86/include/asm/setup.h index ae0dd3915a..29ccacfd7f 100644 --- a/xen/arch/x86/include/asm/setup.h +++ b/xen/arch/x86/include/asm/setup.h @@ -33,7 +33,7 @@ static inline void vesa_init(void) {}; int construct_dom0( struct domain *d, - const module_t *kernel, unsigned long kernel_headroom, + const module_t *image, unsigned long image_headroom, module_t *initrd, char *cmdline); void setup_io_bitmap(struct domain *d); diff --git a/xen/arch/x86/include/asm/uaccess.h b/xen/arch/x86/include/asm/uaccess.h index 684fccd95c..7443519d5b 100644 --- a/xen/arch/x86/include/asm/uaccess.h +++ b/xen/arch/x86/include/asm/uaccess.h @@ -10,10 +10,10 @@ #include unsigned int copy_to_guest_pv(void __user *to, const void *from, - unsigned int len); -unsigned int clear_guest_pv(void __user *to, unsigned int len); + unsigned int n); +unsigned int clear_guest_pv(void __user *to, unsigned int n); unsigned int copy_from_guest_pv(void *to, const void __user *from, - unsigned int len); + unsigned int n); /* Handles exceptions in both to and from, but doesn't do access_ok */ unsigned int copy_to_guest_ll(void __user*to, const void *from, unsigned int n); diff --git a/xen/arch/x86/include/asm/xstate.h b/xen/arch/x86/include/asm/xstate.h index 7ab0bdde89..4fb4312192 100644 --- a/xen/arch/x86/include/asm/xstate.h +++ b/xen/arch/x86/include/asm/xstate.h @@ -87,7 +87,7 @@ struct xstate_bndcsr { }; /* extended state operations */ -bool __must_check set_xcr0(u64 xfeatures); +bool __must_check set_xcr0(u64 val); uint64_t get_xcr0(void); void set_msr_xss(u64 xss); uint64_t get_msr_xss(void); diff --git a/xen/include/xen/lib/x86/cpu-policy.h b/xen/include/xen/lib/x86/cpu-policy.h index 6d5e9edd26..bab3eecda6 100644 --- a/xen/include/xen/lib/x86/cpu-policy.h +++ b/xen/include/xen/lib/x86/cpu-policy.h @@ -451,23 +451,24 @@ typedef xen_msr_entry_t msr_entry_buffer_t[]; * Serialise the CPUID leaves of a cpu_policy object into an array of cpuid * leaves. * - * @param policy The cpu_policy to serialise. - * @param leaves The array of leaves to serialise into. - * @param nr_entries The number of entries in 'leaves'. + * @param p The cpu_policy to serialise. + * @param leaves The array of leaves to serialise into. + * @param nr_entries_p The number of entries in 'leaves'. * @returns -errno * * Writes at most CPUID_MAX_SERIALISED_LEAVES. May fail with -ENOBUFS if the * leaves array is too short. On success, nr_entries is updated with the * actual number of leaves written. */ -int x86_cpuid_copy_to_buffer(const struct cpu_policy *policy, - cpuid_leaf_buffer_t leaves, uint32_t *nr_entries); +int x86_cpuid_copy_to_buffer(const struct cpu_policy *p, + cpuid_leaf_buffer_t leaves, + uint32_t *nr_entries_p); /** * Unserialise the CPUID leaves of a cpu_policy object into an array of cpuid * leaves. * - * @param policy The cpu_policy to unserialise into. + * @param p The cpu_policy to unserialise into. * @param leaves The array of leaves to unserialise from. * @param nr_entries The number of entries in 'leaves'. * @param err_leaf Optional hint for error diagnostics. @@ -481,7 +482,7 @@ int x86_cpuid_copy_to_buffer(const struct cpu_policy *policy, * No content validation of in-range leaves is performed. Synthesised data is * recalculated. */ -int x86_cpuid_copy_from_buffer(struct cpu_policy *policy, +int x86_cpuid_copy_from_buffer(struct cpu_policy *p, const cpuid_leaf_buffer_t leaves, uint32_t nr_entries, uint32_t *err_leaf, uint32_t *err_subleaf); @@ -489,22 +490,22 @@ int x86_cpuid_copy_from_buffer(struct cpu_policy *policy, /** * Serialise the MSRs of a cpu_policy object into an array. * - * @param policy The cpu_policy to serialise. - * @param msrs The array of msrs to serialise into. - * @param nr_entries The number of entries in 'msrs'. + * @param p The cpu_policy to serialise. + * @param msrs The array of msrs to serialise into. + * @param nr_entries_p The number of entries in 'msrs'. * @returns -errno * * Writes at most MSR_MAX_SERIALISED_ENTRIES. May fail with -ENOBUFS if the * buffer array is too short. On success, nr_entries is updated with the * actual number of msrs written. */ -int x86_msr_copy_to_buffer(const struct cpu_policy *policy, - msr_entry_buffer_t msrs, uint32_t *nr_entries); +int x86_msr_copy_to_buffer(const struct cpu_policy *p, + msr_entry_buffer_t msrs, uint32_t *nr_entries_p); /** * Unserialise the MSRs of a cpu_policy object from an array of msrs. * - * @param policy The cpu_policy object to unserialise into. + * @param p The cpu_policy object to unserialise into. * @param msrs The array of msrs to unserialise from. * @param nr_entries The number of entries in 'msrs'. * @param err_msr Optional hint for error diagnostics. @@ -518,7 +519,7 @@ int x86_msr_copy_to_buffer(const struct cpu_policy *policy, * * No content validation is performed on the data stored in the policy object. */ -int x86_msr_copy_from_buffer(struct cpu_policy *policy, +int x86_msr_copy_from_buffer(struct cpu_policy *p, const msr_entry_buffer_t msrs, uint32_t nr_entries, uint32_t *err_msr); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 04 10:37:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 10:37:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558240.872143 (Exim 4.92) (envelope-from ) id 1qGdPA-0003o3-0s; Tue, 04 Jul 2023 10:37:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558240.872143; Tue, 04 Jul 2023 10:37:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGdP9-0003nw-UR; Tue, 04 Jul 2023 10:37:07 +0000 Received: by outflank-mailman (input) for mailman id 558240; Tue, 04 Jul 2023 10:37:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGdP8-0003nq-1r for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 10:37:06 +0000 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on20602.outbound.protection.outlook.com [2a01:111:f400:7e8d::602]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b61b1842-1a56-11ee-8611-37d641c3527e; Tue, 04 Jul 2023 12:37:03 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by PH7PR12MB8015.namprd12.prod.outlook.com (2603:10b6:510:26a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 10:36:57 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::8018:78f7:1b08:7a54]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::8018:78f7:1b08:7a54%2]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 10:36:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b61b1842-1a56-11ee-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YV/ULC8jdRav2Z/oiP2bCUuzmVFplGVxOLROBKw880zctX5NjsbUou/j+9gml0E0hCK4fjQdt51PcLoaXrrwK13iFgADQWDWLeaUTsM9X1KzyAJHzIMFWHSTmN3W6ZLPaMyR72jJYE5wTGliiI/gfuN+xGJ0TqZGRrzwoQ7SiyZQKrBogqGWnTk9ejXDca0vy/lX4Ids27r4h3VLV/IpQ+DYNF0Tr62MkoDQn87akI0yt/ql6D4BVmOCdKUpdEGDa0er7zYHzWGlriOAdEIl+p7h4lG2eChciptSFL6H6MGuPYC6DZZfsNuDHE5T3IsmBVQtE4TUCqOelk9HdfNnEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PJUjuyEd1TRdKKm1b4FR9xxd+vZ5JueFE4Et58xUmqs=; b=KO2EHMN4+p6ou6ixrO/7ShOmkHKmk83tlC9uUz6gJKdaLiWCD/21hK7rGYU+CjX6z18pFQQledpWOg8eYeSYUUS40smowrKwwS76AEvGL9aaiGWleL81+QxXmnUVY6WPZ/aG9O6H+rPiZHMO798Rrd0t3Bgj6i4dvQNLWttHnc4d1bfeaLJdYxg061EC/kG+eIGbTDlizIAY6TeGck2PiF51PyCiDHwbIFt6FVg+HGFVbgzyDFOW/QtyHm2XC2a2KowYMbEWEHum/TVyQiT0XIzRqR6ZH3cdp3d9e7YEOZ8V6j+/Z17FCa1oARUgY8IbUArx3YUSP6miXwkYNsMwkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PJUjuyEd1TRdKKm1b4FR9xxd+vZ5JueFE4Et58xUmqs=; b=ECTbz6dR+/qsrqBThMeoivFiUnKwHyrFp867EqfPRPYO2jkVuS+5tO34EL4N8UfJjKutmLAQaIY5c/kTSYvllCN4ZXSC3g2H+RMIOIfIepD5I7RMP/ri1RxuW4iBwRkjXotR7y+lYa2W1AvcEQEiX0XPwmxmUwVOBbK3dt7Oa24= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: Date: Tue, 4 Jul 2023 11:36:51 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 03/52] xen/arm: add an option to define Xen start address for Armv8-R To: Penny Zheng , xen-devel@lists.xenproject.org Cc: Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk References: <20230626033443.2943270-1-Penny.Zheng@arm.com> <20230626033443.2943270-4-Penny.Zheng@arm.com> From: Ayan Kumar Halder In-Reply-To: <20230626033443.2943270-4-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0191.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:311::19) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|PH7PR12MB8015:EE_ X-MS-Office365-Filtering-Correlation-Id: 5a612fa2-c3dc-44ad-4725-08db7c7a9737 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UH+QxOw97lKT1oXpCfTK+NosbhFF0Ms+e90DeSrSt3DqJJO2WCDATTJEnuS9RdHsG8ngC7IxIy2wSSB41JUbdWv5suBpf0gG+5oZWFfaVL9/NVGjcdfbXZx1CwlarP3go4eIpbI0OkUH0b1Z3oIkIOv3t9pQNMbxwZok1SnY5O5H5HVsi0m5mJcalEqtcIwTa9NeXWwV9R76UGJCn/+jMxwFOFocGScnC/1Jdq8mE7pqT1B+oLY0CT4QHHKG9z0NhO1/26KsAYoQp8GQpXlmBemfBuCh7WwKMxlZrdHmz202hXBzwxYzw49wz3JmAGMl3ZIfcW+UfNSvj99w8GWAw69gFtrXAyX+nbIgujLzhk46CT1U9iorx4jmKrph0ESs0BoN9Fd6ecWndNb5DRintrlLHWN6grTqMvvWfy4txxNaKtpzFm/obugt8wvbd8R3A6MKWmlxhErXpH/Uug1kTOFn1FVqJMBa9kjvOEFj3F7Kk0KN5n5QbuQEXjr4Ldlr18ldpFdcgHoMzlqAOz6XztyAagSidKC9de7HPVe/RJY2JGpl0xa5f4IZKNeBlrwALD7u+XoYfN2JSTpuzf7NjmURW6YNVSjjsgUZ7WLCLRUd3h4L97i3VhNMQ/M5i/4+DtelwgaFYumrxn0JdzSASA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(136003)(346002)(39860400002)(366004)(451199021)(6666004)(38100700002)(2906002)(6486002)(54906003)(8936002)(8676002)(36756003)(41300700001)(5660300002)(478600001)(31696002)(66946007)(66556008)(66476007)(53546011)(186003)(6506007)(26005)(6512007)(4326008)(316002)(31686004)(2616005)(966005)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RDVlTzFRc1BjcHhrenhpaDFVa2tFRURsdVh1Y1hoL3NnVEpWNjVnOTBxUjR0?= =?utf-8?B?ZENMcmEzbUh6bDAyR2lkWG9Rc0wrelNzaUZWZDlmckJrd2U2VkJabVQ3ZWFt?= =?utf-8?B?Wkh6RU9oWTdJakxXVFdzTktjb0toNjE0Mi9sREtEdkVFRFZobURDYzg0cS9j?= =?utf-8?B?aXVMbm1RRTNtaUhEREdURDd1NXFJd09kcjNML0c5bG1IVTVPdzQ3SXVJN1dF?= =?utf-8?B?TWh6OXcydmM4Z3VndGI4djZ3dW1VVmwvQ2w2dEpMQkN2UGNOOGVabDdpSDBt?= =?utf-8?B?SU5JemtqQ1V5aU5JL3FZQUJHNjNPOVRGanYzME05K2VmMXQrMHFoR1AwRVNC?= =?utf-8?B?TGdBNXBYV0hqOS81TTN6K21kWDhWZFo4Q092OHBuY3lGV0FOREo1VmdUcFYr?= =?utf-8?B?QnFRUUIvSG1hdUp5bFk4TXpOM3VCcTYwTCtUSzlMRFZORENOV1QvNG1JK2p0?= =?utf-8?B?NU9sRk1nN21NUlU0V1d6WGJaZ3BtUW0vL3dHb3ZDN0pxazV3bVpjVytEMUZF?= =?utf-8?B?djg5emJvZmx0SGJlYnpIRWtFTHA4QTdqWEx5ZERkTDVrTkVUMWZmS2lCZGxq?= =?utf-8?B?bGQveUFWaWx1ZUNvVVRUV0FEOCtTOW9EZ2lXd20xeUg4b1VzQjZNYjJDU016?= =?utf-8?B?b3dlQytIZWV0T2tPRGRsNk9VR3dxWVRVeWg0N3kxOWh5YjRzSEZOa0RZb3hu?= =?utf-8?B?KzIvaGtKN01KbThUWFZBaXpiL0FSU3lwUHI2Q2RiN1dTUFNZeFZpaUppRzM5?= =?utf-8?B?UDhRZDBQTUdRN1k5WmFvaFZMczJKYnFodkl4TUFreTVpUnNrbCtVSlc1eWpC?= =?utf-8?B?cG9zUWQzUDlGRTNrclcvcnZXRjllWFhob2tJZnRNSU8vT2dyRG1pOWoxNVhU?= =?utf-8?B?YTVUL1IvZUZ3RU55UWZPRkNNWXhId1o3a015OHRxU3YwdXdNcTFvSGQxdks5?= =?utf-8?B?Qnh4eXg4UFM3ajNibGVGOHF2Q3hpVUNRR3ZMR2pMdUNKdFZkWS9IYXhHWG1Q?= =?utf-8?B?aWYyaDBZcTBldDdTM2xxMjVPNDE5cG9kRGladmw0dE5pSVlZak01RlBVSGJS?= =?utf-8?B?dFQzc0NnMTRjNU5DdkV2Z2V3em9zeGZ3S2pFSDBxYjdjV0VHcTZLKzQxV2x5?= =?utf-8?B?eHlJYWtSb2ZYaEhkdGlBUTdZRmw2aTJmYWZqaVdIUWVMS2dRTEVJK2hnNWJZ?= =?utf-8?B?aEkwMjkvVHNIZVUrOWppMCsxYjZmaUhIL3hzRVcyUmxYSzhFVFlTaGFLNWl6?= =?utf-8?B?c01NM1Ztc0lCS3ppVkdmY1Rnc3NHZzd2UUg1ejBBNlBieDZwNEVZVGpydGRU?= =?utf-8?B?Y21LdFhhQVRMNzR1SmZiSXZvaGpJVkZaMC9TZ2x4OWJqV1JtTk1IZFdxRlpP?= =?utf-8?B?dWxkRG8vMDhFQVd1bE5zOVdhRUtWTldQdkU1WUtzK3lxdTdXMzJqM2pjUGN2?= =?utf-8?B?cFFvMS9Sc2tDZFFCYXZrVGtudGh1SThFQzgvcHYvRURwc0V0TEhpVjU4T2Vu?= =?utf-8?B?SmVKc2hkSzFoVWU2TnNwck85bGk0MGJKeWNCcWV6b05Fd0dBUSs1WjRYZG1x?= =?utf-8?B?R0lxMnZBMFphMGFvU2ZQRlh0TmdFSmlGM0Q0VytSNlQ5ZXFBdnZuaUhEaGhB?= =?utf-8?B?QUw2UzZxbFEyZFZTemxJOXFlY2tNdDNneFpnWUFScXVEc24rd01senVlV2xV?= =?utf-8?B?NTFNQ0xEMlN6ODNZcUFoNWxDZVB5TWJNK1hmcFhpOENjVGtRbm9BU1B3eW1X?= =?utf-8?B?SUswbDFlblZxRCt4bHB0SlJzZzlyb2RPRDhRWGZhVElXODRxaUg5d3pvaWw5?= =?utf-8?B?R3pRVTMzY283OXB6UXRkT1NsUEM0WitkWTYveE80elk3ekYydHhXUE5oYUpI?= =?utf-8?B?eVU0UEZuM29jaGRQUFZNdm9seGw2V0NjT1JEUThzOEYvVjB4SzN1TGFtMGNl?= =?utf-8?B?OHBWVHJPVDV5QWE0bTJLSllqVmRPcXUrU1BvTmFodkY2OEx5cWwvUmJYZlpW?= =?utf-8?B?c24wa2YxYjdrS011d05Zd2FySGJ6ZU5pM28wQ0RaS1Y1ckVhNlVjNHIwMi9J?= =?utf-8?B?eU5MTS9mNGVHUmNpOUR0bGd4MCtSZGUrc3ZwWnYrZ3RYQUJvWFp1SXZadWZ5?= =?utf-8?Q?0fcnfQrs5wX/XS4yUirmPRamp?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5a612fa2-c3dc-44ad-4725-08db7c7a9737 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 10:36:56.9204 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OnTkVpegT3v/8yG1SZ34GxwAKvBqXcTV0aaPLcUe170xX/4rRzVkipoemdQxp5ZbFQqhj2H8mCLiRcL9hmV5Mg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8015 Hi Penny, On 26/06/2023 04:33, Penny Zheng wrote: > CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. > > > From: Wei Chen > > On Armv8-A, Xen has a fixed virtual start address (link address > too) for all Armv8-A platforms. In an MMU based system, Xen can > map its loaded address to this virtual start address. So, on > Armv8-A platforms, the Xen start address does not need to be > configurable. But on Armv8-R platforms, there is no MMU to map > loaded address to a fixed virtual address and different platforms > will have very different address space layout. So Xen cannot use > a fixed physical address on MPU based system and need to have it > configurable. > > In this patch we introduce one Kconfig option for users to define > the default Xen start address for Armv8-R. Users can enter the > address in config time, or select the tailored platform config > file from arch/arm/configs. > > And as we introduced Armv8-R to Xen, that means the existed Arm64 > MMU based platforms should not be listed in Armv8-R platform > list, so we add !HAS_MPU dependency for these platforms. > > Signed-off-by: Wei Chen > Signed-off-by: Penny Zheng > --- > v1 -> v2: > 1. Remove the platform header fvp_baser.h. > 2. Remove the default start address for fvp_baser64. > 3. Remove the description of default address from commit log. > 4. Change HAS_MPU to ARM_V8R for Xen start address dependency. > No matter Arm-v8r board has MPU or not, it always need to > specify the start address. > --- > v3: > 1. Remove unrelated change of "CONFIG_FVP_BASER" > 2. Change ARM_V8R to HAS_MPU for Xen start address dependency > --- > xen/arch/arm/Kconfig | 8 ++++++++ > xen/arch/arm/platforms/Kconfig | 8 +++++--- > 2 files changed, 13 insertions(+), 3 deletions(-) > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index 70fdc2ba63..ff17345cdb 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -181,6 +181,14 @@ config TEE > This option enables generic TEE mediators support. It allows guests > to access real TEE via one of TEE mediators implemented in XEN. > > +config XEN_START_ADDRESS > + hex "Xen start address: keep default to use platform defined address" > + default 0 > + depends on HAS_MPU > + help > + This option allows to set the customized address at which Xen will be > + linked on MPU systems. This address must be aligned to a page size. > + > source "arch/arm/tee/Kconfig" > > config STATIC_SHM > diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig > index c93a6b2756..75af48b5f9 100644 > --- a/xen/arch/arm/platforms/Kconfig > +++ b/xen/arch/arm/platforms/Kconfig > @@ -1,6 +1,7 @@ > choice > prompt "Platform Support" > default ALL_PLAT > + default NO_PLAT if HAS_MPU I am a bit concerned about this as we will be introducing R52 specific platform in xen/arch/arm/platforms/ (For eg https://github.com/Xilinx/xen/blob/xlnx_rebase_4.17/xen/arch/arm_mpu/platforms/amd-versal-net.c ) Thus, we will have to remove this line at that time. Can you remove this line, please if it does not cause any issue ? - Ayan > ---help--- > Choose which hardware platform to enable in Xen. > > @@ -8,13 +9,14 @@ choice > > config ALL_PLAT > bool "All Platforms" > + depends on !HAS_MPU > ---help--- > Enable support for all available hardware platforms. It doesn't > automatically select any of the related drivers. > > config QEMU > bool "QEMU aarch virt machine support" > - depends on ARM_64 > + depends on ARM_64 && !HAS_MPU > select GICV3 > select HAS_PL011 > ---help--- > @@ -23,7 +25,7 @@ config QEMU > > config RCAR3 > bool "Renesas RCar3 support" > - depends on ARM_64 > + depends on ARM_64 && !HAS_MPU > select HAS_SCIF > select IPMMU_VMSA > ---help--- > @@ -31,7 +33,7 @@ config RCAR3 > > config MPSOC > bool "Xilinx Ultrascale+ MPSoC support" > - depends on ARM_64 > + depends on ARM_64 && !HAS_MPU > select HAS_CADENCE_UART > select ARM_SMMU > ---help--- > -- > 2.25.1 > > From xen-devel-bounces@lists.xenproject.org Tue Jul 04 10:39:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 10:39:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558246.872153 (Exim 4.92) (envelope-from ) id 1qGdRf-0004Qu-HA; Tue, 04 Jul 2023 10:39:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558246.872153; Tue, 04 Jul 2023 10:39:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGdRf-0004Qn-Ec; Tue, 04 Jul 2023 10:39:43 +0000 Received: by outflank-mailman (input) for mailman id 558246; Tue, 04 Jul 2023 10:39:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGdRe-0004Qh-Up for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 10:39:42 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 154b7789-1a57-11ee-b237-6b7b168915f2; Tue, 04 Jul 2023 12:39:41 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6402B204D8; Tue, 4 Jul 2023 10:39:41 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2B0541346D; Tue, 4 Jul 2023 10:39:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id jF/6CO32o2QEdQAAMHmgww (envelope-from ); Tue, 04 Jul 2023 10:39:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 154b7789-1a57-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1688467181; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ufUyszN3FOTy1keSsZFTm+VxsQdbtQ8iR1hztEdTO+U=; b=pA9V4VHpYj7BS1DxBVycwdaAXi++0qHtjb0hgEmEQotmgbu0x7nT0crDnrltGWSWHHWbGe 6f/CEBJ1Vkq2Q9UghaMYK5MylCKZpKUGPQjwn+9t+LBm7ceWUGs/5eT7MtsZ1Xt7/gQd3A nCmjQnCt6xATm+NwX0RuhLGnLIlw/rA= Message-ID: Date: Tue, 4 Jul 2023 12:39:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Stefano Stabellini Cc: Oleksandr Tyshchenko , Petr Pavlu , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" , vikram.garhwal@amd.com References: <20230621131214.9398-1-petr.pavlu@suse.com> <20230621131214.9398-3-petr.pavlu@suse.com> <15e31609-6c45-7372-76ee-0adf7a64fe88@epam.com> From: Juergen Gross Subject: Re: [PATCH 2/2] xen/virtio: Avoid use of the dom0 backend in dom0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------xX4qTw8UY8621tTesaaATWaa" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------xX4qTw8UY8621tTesaaATWaa Content-Type: multipart/mixed; boundary="------------gidE6FoEsgf7uP6gzz4RP2TS"; protected-headers="v1" From: Juergen Gross To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Stefano Stabellini Cc: Oleksandr Tyshchenko , Petr Pavlu , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" , vikram.garhwal@amd.com Message-ID: Subject: Re: [PATCH 2/2] xen/virtio: Avoid use of the dom0 backend in dom0 References: <20230621131214.9398-1-petr.pavlu@suse.com> <20230621131214.9398-3-petr.pavlu@suse.com> <15e31609-6c45-7372-76ee-0adf7a64fe88@epam.com> In-Reply-To: --------------gidE6FoEsgf7uP6gzz4RP2TS Content-Type: multipart/mixed; boundary="------------L2wHyOVyIZUNYvNlG5ywcrPl" --------------L2wHyOVyIZUNYvNlG5ywcrPl Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDQuMDcuMjMgMDk6NDgsIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6DQo+IE9uIFRodSwg SnVuIDI5LCAyMDIzIGF0IDAzOjQ0OjA0UE0gLTA3MDAsIFN0ZWZhbm8gU3RhYmVsbGluaSB3 cm90ZToNCj4+IE9uIFRodSwgMjkgSnVuIDIwMjMsIE9sZWtzYW5kciBUeXNoY2hlbmtvIHdy b3RlOg0KPj4+IE9uIDI5LjA2LjIzIDA0OjAwLCBTdGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6 DQo+Pj4+IEkgdGhpbmsgd2UgbmVlZCB0byBhZGQgYSBzZWNvbmQgd2F5PyBJdCBjb3VsZCBi ZSBhbnl0aGluZyB0aGF0IGNhbiBoZWxwDQo+Pj4+IHVzIGRpc3Rpbmd1aXNoIGJldHdlZW4g YSBub24tZ3JhbnRzLWNhcGFibGUgdmlydGlvIGJhY2tlbmQgYW5kIGENCj4+Pj4gZ3JhbnRz LWNhcGFibGUgdmlydGlvIGJhY2tlbmQsIHN1Y2ggYXM6DQo+Pj4+IC0gYSBzdHJpbmcgb24g eGVuc3RvcmUNCj4+Pj4gLSBhIHhlbiBwYXJhbQ0KPj4+PiAtIGEgc3BlY2lhbCBQQ0kgY29u ZmlndXJhdGlvbiByZWdpc3RlciB2YWx1ZQ0KPj4+PiAtIHNvbWV0aGluZyBpbiB0aGUgQUNQ SSB0YWJsZXMNCj4+Pj4gLSB0aGUgUUVNVSBtYWNoaW5lIHR5cGUNCj4+Pg0KPj4+DQo+Pj4g WWVzLCBJIHJlbWVtYmVyIHRoZXJlIHdhcyBhIGRpc2N1c3Npb24gcmVnYXJkaW5nIHRoYXQu IFRoZSBwb2ludCBpcyB0bw0KPj4+IGNob29zZSBhIHNvbHV0aW9uIHRvIGJlIGZ1bmN0aW9u YWwgZm9yIGJvdGggUFYgYW5kIEhWTSAqYW5kKiB0byBiZSBhYmxlDQo+Pj4gdG8gc3VwcG9y dCBhIGhvdHBsdWcuIElJUkMsIHRoZSB4ZW5zdG9yZSBjb3VsZCBiZSBhIHBvc3NpYmxlIGNh bmRpZGF0ZS4NCj4+DQo+PiB4ZW5zdG9yZSB3b3VsZCBiZSBhbW9uZyB0aGUgZWFzaWVzdCB0 byBtYWtlIHdvcmsuIFRoZSBvbmx5IGRvd25zaWRlIGlzDQo+PiB0aGUgZGVwZW5kZW5jeSBv biB4ZW5zdG9yZSB3aGljaCBvdGhlcndpc2UgdmlydGlvK2dyYW50cyBkb2Vzbid0IGhhdmUu DQo+IA0KPiBJIHdvdWxkIGF2b2lkIGludHJvZHVjaW5nIGEgZGVwZW5kZW5jeSBvbiB4ZW5z dG9yZSwgaWYgbm90aGluZyBlbHNlIHdlDQo+IGtub3cgaXQncyBhIHBlcmZvcm1hbmNlIGJv dHRsZW5lY2suDQo+IA0KPiBXZSB3b3VsZCBhbHNvIG5lZWQgdG8gbWFwIHRoZSB2aXJ0aW8g ZGV2aWNlIHRvcG9sb2d5IGludG8geGVuc3RvcmUsIHNvDQo+IHRoYXQgd2UgY2FuIHBhc3Mg ZGlmZmVyZW50IG9wdGlvbnMgZm9yIGVhY2ggZGV2aWNlLg0KDQpUaGlzIGFzcGVjdCAoZGlm ZmVyZW50IG9wdGlvbnMpIGlzIGltcG9ydGFudC4gSG93IGRvIHlvdSB3YW50IHRvIHBhc3Mg dmlydGlvDQpkZXZpY2UgY29uZmlndXJhdGlvbiBwYXJhbWV0ZXJzIGZyb20gZG9tMCB0byB0 aGUgdmlydGlvIGJhY2tlbmQgZG9tYWluPyBZb3UNCnByb2JhYmx5IG5lZWQgc29tZXRoaW5n IGxpa2UgWGVuc3RvcmUgKGEgdmlydGlvIGJhc2VkIGFsdGVybmF0aXZlIGxpa2UgdmlydGlv ZnMNCndvdWxkIHdvcmssIHRvbykgZm9yIHRoYXQgcHVycG9zZS4NCg0KTWFwcGluZyB0aGUg dG9wb2xvZ3kgc2hvdWxkIGJlIHJhdGhlciBlYXN5IHZpYSB0aGUgUENJLUlkLCBlLmcuOg0K DQovbG9jYWwvZG9tYWluLzQyL2RldmljZS92aXJ0aW8vMDAwMDowMDoxYy4wL2JhY2tlbmQN Cg0KPiANCj4+IFZpa3JhbSBpcyB3b3JraW5nIG9uIHZpcnRpbyB3aXRoIGdyYW50cyBzdXBw b3J0IGluIFFFTVUgYXMgd2Ugc3BlYWsuDQo+PiBNYXliZSB3ZSBjb3VsZCBmaW5kIGEgd2F5 IHRvIGFkZCBhIGZsYWcgaW4gUUVNVSBzbyB0aGF0IHdlIGNhbiBkZXRlY3QgYXQNCj4+IHJ1 bnRpbWUgaWYgYSBnaXZlbiB2aXJ0aW8gZGV2aWNlIHN1cHBvcnQgZ3JhbnRzIG9yIG5vdC4N Cj4gDQo+IElzbid0IHRoZXJlIGEgd2F5IGZvciB0aGUgZGV2aWNlIHRvIGV4cG9zZSBjYXBh YmlsaXRpZXMgYWxyZWFkeT8gIEZvcg0KPiBleGFtcGxlIGhvdyBkb2VzIGEgdmlydGlvLWJs ayBiYWNrZW5kIGV4cG9zZSBzdXBwb3J0IGZvciBpbmRpcmVjdA0KPiBkZXNjcmlwdG9ycz8N Cg0KVGhvc2UgY2FwYWJpbGl0aWVzIGFyZSBkZWZpbmVkIGluIHRoZSB2aXJ0aW8gc3BlYyBb MV0uIEFkZGluZyB0aGUgYmFja2VuZA0KZG9taWQgd291bGQgYmUgcG9zc2libGUsIGJ1dCBp dCBwcm9iYWJseSB3b3VsZG4ndCBiZSB0aGF0IGVhc3kgKHJlcXVpcmVzDQpjaGFuZ2luZyB0 aGUgdmlydGlvIHNwZWMgYnkgZWl0aGVyIGV4cGFuZGluZyBhbiBleGlzdGluZyBjb25maWcg YXJlYSBvciBieQ0KYWRkaW5nIGEgbmV3IG9uZSkuIEknbSBub3Qgc3VyZSBoYW5kbGluZyBp biB0aGUgc3BlY2lmaWMgZnJvbnRlbmRzIGlzDQpnZW5lcmljIGVub3VnaCBmb3IgYmVpbmcg YWJsZSB0byBoYXZlIGEgY2VudHJhbCBwbGFjZSB3aGVyZSB0aGUgYmFja2VuZA0KZG9taWQg Y291bGQgYmUgcmV0cmlldmVkLCB3aXRob3V0IHJlcXVpcmluZyBhbnkgY2hhbmdlIG9mIHRo ZSBmcm9udGVuZHMuDQoNCg0KSnVlcmdlbg0KDQpbMV06IGh0dHA6Ly9kb2NzLm9hc2lzLW9w ZW4ub3JnL3ZpcnRpby92aXJ0aW8vdjEuMi92aXJ0aW8tdjEuMi5odG1sDQo= --------------L2wHyOVyIZUNYvNlG5ywcrPl Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------L2wHyOVyIZUNYvNlG5ywcrPl-- --------------gidE6FoEsgf7uP6gzz4RP2TS-- --------------xX4qTw8UY8621tTesaaATWaa Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmSj9uwFAwAAAAAACgkQsN6d1ii/Ey+9 yggAm/nnfzU+zzUQjNzpq4jgN4FPFkr5ki16LnPe/evdn7hmqs8k/+VXrXCW+2xyXD+VoDibBl9Q pckoziwZFXP4jomvW+oR17HpmibmQ96nXtiRGJvH5oRB1Pul82aEy2PbbkeM357nts2i6IYtR86W xJalTzeCBRept1bMjYgxyPZmdbGAskeYquTug5wOG2wr9TJRZ3YZohauH3kfKQfnuuqdhbgHYQiu wexNRngYZHoIH9uHcb2cQnlP4z3Tfhr4ClcIcabczqxKv4qLTD3lrUmRhIUHAVdJjWJQhLoIr/py A9prgAkJHf5ibJvV4HLe5bNAlri8zB+8gHqmtZibxQ== =ZF9q -----END PGP SIGNATURE----- --------------xX4qTw8UY8621tTesaaATWaa-- From xen-devel-bounces@lists.xenproject.org Tue Jul 04 10:55:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 10:55:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558250.872163 (Exim 4.92) (envelope-from ) id 1qGdgc-0006qs-Q2; Tue, 04 Jul 2023 10:55:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558250.872163; Tue, 04 Jul 2023 10:55:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGdgc-0006ql-N1; Tue, 04 Jul 2023 10:55:10 +0000 Received: by outflank-mailman (input) for mailman id 558250; Tue, 04 Jul 2023 10:55:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGdgb-0006qf-MX for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 10:55:09 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3ce40c5d-1a59-11ee-b237-6b7b168915f2; Tue, 04 Jul 2023 12:55:08 +0200 (CEST) Received: from mail-mw2nam10lp2101.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.101]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Jul 2023 06:54:58 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by SJ0PR03MB6240.namprd03.prod.outlook.com (2603:10b6:a03:3ae::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 10:54:56 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::1c83:1877:a68b:8902]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::1c83:1877:a68b:8902%7]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 10:54:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ce40c5d-1a59-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1688468108; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=U3xep052cZDrscjGs+i6jbExtS2iISvL1OSaYUtxwoo=; b=QW5Qb5U1xhAjf+sOaS6rX0V3a7WrdBULC388MFQdF/l9b+gL5edCdwKz v/NtVMl3CIRd2lV0SuBM+9cUegjy/wZQwCvXRVcdtYjzZL75J1mC2TBEL TgvX9MA03DEj5o3faiCR8kSJae4Xinb9qK4cLrGiGkHu6lmeOvHJA5VdO A=; X-IronPort-RemoteIP: 104.47.55.101 X-IronPort-MID: 117666314 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:LUe3MKIdrVsrgb+oFE+R95QlxSXFcZb7ZxGr2PjKsXjdYENS32YHm DcdWzjSPPmONDTyL4wjPY2ypBkBu5HRnIA3TQtlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpKrfrawP9TlK6q4mhA4QRiPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5nWFNq/ N4/CwwgSTqEg+y/nY2qePBV05FLwMnDZOvzu1lG5BSAVbMDfsqGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dqpTGLlWSd05C0WDbRUsaNSshP2F6Ru 0rN/njjAwFcP9uaodaA2iv12bGRw3iiBOr+EpWCxvM0vQaty1UdUho0BEeG/Pzjo0iHDoc3x 0s8v3BGQbIJ3E6hQ8T5Xha4iGWZpRNaUN1Ve8Ul7Cmdx6yS5ByWbkAUQzgEZNE4ucseQT0xy kTPj97vHSZosrCeVTSa7Lj8kN+pES0cLGtHYDBeSwIAuoHnuNtq1kuJSct/GqmoiNGzASv33 z2BsCk5gfMUkNIP0KK4u1vAhlpAu6T0c+L83S2PNkrN0++zTNfNi1CAgbQD0ct9EQ== IronPort-HdrOrdr: A9a23:Maai6KuI6hdekNV6MBOJ126t7skDU9V00zEX/kB9WHVpm62j9/ xG+c5x6faaslgssR0b6LW90cq7Lk80l6QV3WB5B97LNmSLhILPFvAa0WKL+UyGJ8TQzJ8+6U 4KSdkbNDSfNykBse/KpCW+DtY80J2m3cmT9JrjJzwEd3ANV0ga1XYbNu9DKDwPeOCRP+tDKK ah X-Talos-CUID: 9a23:H7Ch5GOls35a9+5DSHBV0Ec2PeMZX1r3y3PeKhKHGFRwcejA X-Talos-MUID: 9a23:Rj/ICgptzlAXmEJHsVoezwtSOZlVuJqjMU5XlrdXp/TZMHZZPQ7I2Q== X-IronPort-AV: E=Sophos;i="6.01,180,1684814400"; d="scan'208";a="117666314" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mx4AP+2zc3UQKuNfSc0ietpH/xLeLDUBatiVZT4EHWaiFlaPvxC37jQ+GaCYB5z27GcN/bABe7Z7JFGI8NMaJzT7X1ogThzZFcejFEFEX1mesEFbHqmbHlJhMeQUDBbe6zg1N86e7Q/Fzj6i3NGTAlSjf/9Op4eYt9/zdaXB4Mk2ilRR8OV0F/2D51Vx1LkictGW4AgmUdhNuVGaPdY33M8WLuhSpUofqjat8QLsfGGfjeWinYcZYeCLugaudGpxlICQgXej/CrHHQzpwXKuuylq/b76MUpZnfkXXSYoxwB0fEV5ypjDq5CzsKSx0kIOP+Rv7IWowSNh8gV2xzatMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wfCVpSC+fn+ZuRimJA0iZdnw9KK8inwYWaNoCTxnk80=; b=PAjP/CEMiqIXFc4jX6L3FkEqTNXoaZPBAxaKc2JolOaaC6K2LYg7+kXnqI9dlNAoQ085/X/ONBt6H3zCuYLI+eV8S4xT0tTNckYaorAnXeTVun7einGHTSipF1A48mjygY8cQZ2FDqiq+s9kU7WxLTppeDq/1UBil8/a4wjHy76IvrCvfnYQXXWG3OhCBVYJqqnrYp2Lja6pU8Z8ZE7mxnYrqoaWOEQpsuuLKMHoR8vR6UXc5ov8p2Y8I/Kzof7o8dD2hlobkZDLnkN+NX6Rcbjc5cvocbiIx5gT6//KnSQceCGvcJHYfSHkQLL+TaYl8UCivNkiIUES1yddMg3GMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wfCVpSC+fn+ZuRimJA0iZdnw9KK8inwYWaNoCTxnk80=; b=w1bxkR3gkhrG89D+gmJN3LmKjZFN77j0sCx5/hbYwwUaXOT12MWSeE5E7hq1ElKNV4iPjzcDvsszH/SbFyS5My9V3X1oR27nAdogehuBy4Ak56xjJLjC7eRMkWodjSkpF2H6Kq2qX87DJKK4sCN0IsIQ+vk3ilHtaF+Fg05qx3w= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 4 Jul 2023 12:54:50 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH v3 1/3] multiboot2: parse vga= option when setting GOP mode Message-ID: References: <20230601130518.48874-1-roger.pau@citrix.com> <20230601130518.48874-2-roger.pau@citrix.com> <2e194ebe-f8e8-128a-0ad6-227f8a9be976@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <2e194ebe-f8e8-128a-0ad6-227f8a9be976@suse.com> X-ClientProxiedBy: LO4P123CA0007.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:150::12) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|SJ0PR03MB6240:EE_ X-MS-Office365-Filtering-Correlation-Id: 178f528a-a823-4da1-3c92-08db7c7d19fd X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mn9RMSpY+VQ/H79LePtqX3XQ9a61oq6X1LzzxN6V5uQK/bAbSga9Fna8guSkmvkT8CKCB057jU4GnW6dE0ts8DAHAp69tCVjH0WV4P1vCj90y8ZFE6B6a1VZkWKN/UVJRLT9vzJfK7zPzdVuyi5Q34ENEMzVJLQmugccyuckV7Srpmd59jB3qoTjxv8+7SrzWdHpSDSr7zppJ9RjqK7c94QGnZHtN0KcO84QJAQAaEmSPJmChIk/PI6yjgkhUaZJT9xdxQbz9UQuXDFmyD9Jta5qIiSydqaxqX5e4LGkPzSIcZQwEfcLfaYXMXRo7R2yZ+ltJiu8YKK/RGpdmh8azVDxdhk9LRJMzx9OIRYDyWQwLD8WJq0HMfbu17fUpMbiYg4q2AgiaDahwN0KgzYat2IJgO8VW50pUCERaY8RKc/SpvuCKl2N8U+pg1NPWwUo9gkUk+fwVDDTuDKY/A4z+a2JZa/HaPBNg1cKzgJp9j0y7VkK3l05V6fPwFe3Aj2Ei/e7dTu69egVeUPDLvj3cEeTh7dLpjRV9OSqxj6ZTkrEA0KrZ6HX+riqfA861QgM X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(396003)(136003)(39860400002)(346002)(376002)(451199021)(2906002)(41300700001)(5660300002)(8676002)(8936002)(85182001)(86362001)(186003)(478600001)(82960400001)(26005)(6506007)(6512007)(9686003)(6666004)(53546011)(6486002)(316002)(6916009)(4326008)(66556008)(66946007)(38100700002)(54906003)(66476007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a0MrczV6NDdFZHNqSG42dmZlWC9HY3kzWldlai9Oend0RWRTa3hlWSt5L0dC?= =?utf-8?B?M2tFTzA5bE9KWWFvdDZ1Nld0MWRyeVJBSzhzL2tCMWtSODFWbnVvb2c0bHJV?= =?utf-8?B?R081b0J2SmZFTWd2UTNOM3FCTm5SZXF0QVNUWjhxbGxzVzVJUzJzZTBSZHVo?= =?utf-8?B?ZGlOamtSWUljUUw0WlV5dkFJQ1R6d0VJZUVER0RmT3Vic3RpZ2xnd0hhNVJD?= =?utf-8?B?TFdZWEtxRjRMenFFWGtKZ1o0UjVjWnJMeEpOcTkxRDJzbkRkRjMzckMwQVJG?= =?utf-8?B?cW9KTGJBdEhHbmlZaWYzQWNvaFlQWUNSOEpVM3NnVkVGVzUzZ1RMb09nVWJx?= =?utf-8?B?T1drcis1WEVPRHN6T1BTRjNjd3c0bGU2NEhMUlN2WjUrODdVTm9qSmt2VFpy?= =?utf-8?B?eTVsb3o2bWtJMW4wZW1pN0ozNFowM1lBMXcyVzZOMTZmaFJqTzNxQ0R6RjJY?= =?utf-8?B?c25GM3Z2TnE2UWY0amxGWVFhM2w5YUtocVRmWVIreS9MeVdGcit0b3dVUzZh?= =?utf-8?B?dXpHelg2d3daUlA1VFl2cFk2T1dpK2lJWVZrMUtIaXRmVS81QlB2aHlHVmlJ?= =?utf-8?B?em0xZzU1aVd2bFJ2UHRmclBUalgyZncvdWhjRk9xTzBPTUtSOEFHUW5QV2Mz?= =?utf-8?B?M0RWZENpeFc4TXBTMHVDQmVsNmdnaDhJZGtwR2RSMng2UlJsSUlMOWtVS1hD?= =?utf-8?B?WjEwQTFDWEJYZVVLYzhSTDlUZFdWeTFXeWJBT1BKVGpMNlBhdWVGT0JicFhV?= =?utf-8?B?ankvNkh4eWdQVUFaTDlUSjd5YkMxZFc4ckM1U0hQbDR2VkZGZ015QkJUdWNS?= =?utf-8?B?MkhBSVRZR2tqTDYxd09FYlZSR09vVDRiTjFOL0VRTjZOei9vODVEeU90eW5X?= =?utf-8?B?Um1raDNKbkpVYWh0cHlVNVB2SWozcGhKSEpuaEE0eFBLTlAvT2JWZ1kzVzJW?= =?utf-8?B?T01jWWVSQVRiWlV4Y090bldEa2RlOVAvTnFaaTZBdUlMMlNTMXNRSXVWM2xi?= =?utf-8?B?eHIwNkNRUUpHYkN1WXVodHlHMzJ3ZzNHRXVsS0ZMemptSGRnRkJBTGlwdGxk?= =?utf-8?B?KzFKcVd5T2l1UWVuVkFuY0pWNWFqYTJGd1JCZUYrOHdRR0pWb0RmS0pidlVY?= =?utf-8?B?UDRuL0FiekhRamhjSzVsOVRLeU40cWFhMmVJUGNZUTN4RGFvTTdhZ3N6R2Zq?= =?utf-8?B?eGF0MnMyRTJNYjRDSkVmN25EaEEwWi83SXJ6ci8vYU9XOW41Nkt1b1QyZUpt?= =?utf-8?B?QkMrSlJPam5hc3BCRFh4b2JCczN1OXk0eHZpMXNKUWVDbVFsWHM4YitFQlFO?= =?utf-8?B?bVl1MElvUHAyNllrdFBic1d1am9lUjZDRDBEbGpuRmtQdW1ZWTFCN3ZSU2M3?= =?utf-8?B?bWpkUWRpQlhKMjh1WmxnUFZvSWZ5Q05RekhRMjNSb3FPNjhKN0hFUE5SSWhm?= =?utf-8?B?SEx4SWx4d1lVcnMrcG5VTUlpSGNYdzR2VXp5WWpoMXBab2tzNEZYK0x2R0hI?= =?utf-8?B?MnlKa1BsY0lQZDYzZDlaRlVId2doYmo2bFFwYWswcDlicFlBOHNXYzREMjJG?= =?utf-8?B?bjNXc3VBdGdMTnZoSEhoVUx3M2hLelMyZ0VDWDR0TmJ6UlZLR0I3Ny9YR01Y?= =?utf-8?B?K0dYR0R4cFRLWU91TXNZejU4M3gzSkxNdTZPa2NWV1dHZmljZUlXbVBsbjR2?= =?utf-8?B?QitjY2dxeXZ3NHc3TTcvVFBNTGZBNkVFN2FnbklaTGx5WTgzdnNtN0tBdE9s?= =?utf-8?B?WHdwbU8ra1JqZ1M4Y3VOd3pId2JKMGdFU0ZCWDNjOCsrTjk3Z1hWLzFicFl5?= =?utf-8?B?b25lZm51YndEMDVmVUJDMUg0V25YMHM2bVV5WGdxZkc1cUl0aytNSy8vWGE1?= =?utf-8?B?TzJrR0I5NTcrZVFuQmh0cVE4cHcvQ0ZxK0h2blJlTVNMc3YraDk1bml4NGw5?= =?utf-8?B?cWxkY2JJZzdxU3lQSGxuaHVKb0pCK1pXS1ZMaDh4REh3cXVrTVdWRU9CZ3FW?= =?utf-8?B?VGxJR20wMjNpUk9yalBoY3I3VjA1amJzWWhQVDhMM0s0TS9aU3JUV2ljcTA0?= =?utf-8?B?ZTZMbHFhbGduOXVWM0JHcUM0b1ozdEtLWnZvYmxpS2NaUlYyM2tWZCtmeUdH?= =?utf-8?B?ckcxT2JpbEJOcTdPZXdXMHorWjB2ZmU3a2dOa2YrQitLNmxvV2tiZm4vbitr?= =?utf-8?B?Mnc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 2YCXD2Zc4gBQoR0px0R0iTEJYTgzaqf2hY2sqxomQjK1d0zwH8hlLU59cnUPjsBv4roFfyR5vSF7eqanlTOLC6JmXa+uH3s9A1Ka+7NE0i0cD/kJfjaPi0O7Eht4GD5UYcFMNB4oC90WsX7VmUEj/ewQMVZUq6r+ca97RksFAULb5lW1cgChuksLWrFRB2NNHrASq2FcnzRXLkCcbwVykNIHY2qSTZgKWp7+ijCryWf3RK/280At6omQuuDPTlkzWnNG5m0rbajks3zXNXJUn1InozqAHFel2CwVXmyGapho+KHTrg3KMj/yI5ssoBdWtZGFfZUciql3zJcKCmCW9c6OoYD/Lf1SmJPGRWrHce+TEsVGGbWNe9n7rftERsQz70hVVUnjGMeCSModxIzvOR4aqP7gyPkcUbRmbMhg8zoWCfLLvxTyVVCtQrYjvP0RqZsNwQynO99zKIAVqC7cjkYuIOiThYR6lJcfX6QKrcmY4tMRf+q8qfVvZjdHzHicUkdBWpqrDfhuRNuBv19ZTg9p3kfOKkA6uUUWjd8yen+jGndz0HsVANbU7riIsTKYehXsolq5KQdK7qmyfMYkP3XH5Pw1OVw/5XUy7g1nlhV1z4vIYpzH2dVOKM9kJk8fsKK2KoGTIRyOVvqHgwoa9k0GBxqeewAbprqrObr38Qv2tVv5JD5unsXna6oMbFUxFx29QBSsXyE4JdwaTLq6X3ufmI6y9vlHyjDLmvb9oqc5xy1mXUTDNufkGme42jIGMHfHkD9O2nSllfp/zsX7LlghNMX9lcp+2KFphTstUASnkvZRrzBlkP59QlNuNxLK X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 178f528a-a823-4da1-3c92-08db7c7d19fd X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 10:54:56.0071 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gtZ9kn0uL8Dq+s0905QXG2HjLS7nGgRqJyeAbqL99p3fEDZxAdyCcDKGq626cestfKJVnYZUrHGGDDTIF5nPRA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6240 On Wed, Jun 07, 2023 at 11:41:24AM +0200, Jan Beulich wrote: > On 01.06.2023 15:05, Roger Pau Monne wrote: > > --- a/xen/arch/x86/boot/head.S > > +++ b/xen/arch/x86/boot/head.S > > @@ -329,7 +337,8 @@ __efi64_mb2_start: > > > > /* > > * efi_multiboot2() is called according to System V AMD64 ABI: > > - * - IN: %rdi - EFI ImageHandle, %rsi - EFI SystemTable. > > + * - IN: %rdi - EFI ImageHandle, %rsi - EFI SystemTable, > > + * %rdx - MB2 cmdline > > */ > > call efi_multiboot2 > > All you obtain is a pointer to the string, which is fine from what I > was able to establish, but that's not entirely obvious: The MBI > structure used has a size field, so it could have been that the > string isn't nul-terminated, and hence the size would also need > passing. May I ask that this be mentioned at least in the description? Sure. The multiboot2 specification already states that the string must be zero terminated. It's my understanding the size field is part of all the tags, so that a parser can find the next tag even if it doesn't know how to parse the current one. > > --- a/xen/arch/x86/efi/efi-boot.h > > +++ b/xen/arch/x86/efi/efi-boot.h > > @@ -786,7 +786,30 @@ static bool __init efi_arch_use_config_file(EFI_SYSTEM_TABLE *SystemTable) > > > > static void __init efi_arch_flush_dcache_area(const void *vaddr, UINTN size) { } > > > > -void __init efi_multiboot2(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable) > > +/* Return the first occurrence of opt in cmd. */ > > +static const char __init *get_option(const char *cmd, const char *opt) > > +{ > > + const char *s = cmd, *o = NULL; > > + > > + if ( !cmd || !opt ) > > + return NULL; > > + > > + while ( (s = strstr(s, opt)) != NULL ) > > + { > > + if ( s == cmd || *(s - 1) == ' ' ) > > Iirc I had asked before: Not allowing for at least tab? (See > cmdline.c:delim_chars_comma[] for what the non-EFI parsing permits, > which in turn might be going a little too far especially with > permitting comma as well.) I've fixed this when parsing the gfx- option but not here, sorry. > > > + { > > + o = s + strlen(opt); > > I don't think the comment ahead of the function describes this > behavior, i.e. in particular the adding of the length of the > option. I've changed the comment to: Return a pointer to the character after the first occurrence of opt in cmd. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Jul 04 10:58:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 10:58:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558255.872173 (Exim 4.92) (envelope-from ) id 1qGdjP-0007PO-8K; Tue, 04 Jul 2023 10:58:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558255.872173; Tue, 04 Jul 2023 10:58:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGdjP-0007PH-5b; Tue, 04 Jul 2023 10:58:03 +0000 Received: by outflank-mailman (input) for mailman id 558255; Tue, 04 Jul 2023 10:58:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGdjN-0007Oy-Ef for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 10:58:01 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a271461a-1a59-11ee-8611-37d641c3527e; Tue, 04 Jul 2023 12:57:59 +0200 (CEST) Received: from mail-dm6nam10lp2105.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.105]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Jul 2023 06:57:56 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by SA1PR03MB7056.namprd03.prod.outlook.com (2603:10b6:806:325::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Tue, 4 Jul 2023 10:57:53 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::1c83:1877:a68b:8902]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::1c83:1877:a68b:8902%7]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 10:57:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a271461a-1a59-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1688468279; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=S0/E6lgGJI26RaFbNiuUvRUXMJ1nPFFf8EETafKROBo=; b=cfs7ndo3Xq/+ss8ifs+A8gjX6pCSBXqzCl2MuVYjeM3b3WZ+WcBFuwlc rTJbbGMCYKmEEniudZpncle1+iqGgXkPl8j6qQqhpJ/YWRXfHBqkY3ZdT 0lpMETXDOtPWsU4LiyNuQIhAUgVywEhbPb6BLJyg+Ktvh90LWzzm84l5G I=; X-IronPort-RemoteIP: 104.47.58.105 X-IronPort-MID: 115118969 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:iMvzO6p/gvhneDEfjriSJk03CIJeBmI+ZBIvgKrLsJaIsI4StFCzt garIBmFbKqPajCjKNBzaoq2oU4F6J/TnYJhGwRpq3o1F3tH9puZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKq04GpwUmAWP6gR5weBzyVNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXADMzPx2RmMTx+5uycdBPoeg6cOrsLKpK7xmMzRmBZRonabbqZvySoPN9gnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeiraYKIEjCJbZw9ckKwv GXJ8n6/GhgHHNee1SCE4jSngeqncSbTAdtPTeTop6A76LGV7jQ4L0MmVHSXmPK0p2WTBIhgJ 2tO/AN7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yxmdLngJSHhGctNOnN87Q3km2 0GEm/vtBCdzq/uFRHSF7LCWoDiufy8PIgc/iTQsSAIE55zvpd81hxeWFtJ7Svft05vyBC36x C2MoG4mnbIPgMUX1qK9u1fanzaroZuPRQkwjunKYl+YAspCTNbNT+SVBZLzsZ6s8K7xooG9g UU5 IronPort-HdrOrdr: A9a23:4vwpk64rJf72rU9s9wPXwamCI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc6Ax/ZJjvo6HkBEClewKlyXcV2/hpAV7GZmXbUQSTTL2KgbGSoAEIXheOjdK1tp 0QD5SWaueAamSS5PySiGfYLz9j+qjgzEnBv5ai854Hd3APV0gP1XYaNu7NeXcGPjWuSKBJYq Z1oaF81kqdUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpixBiSgSiu4LvaFQHd+hsFSTtAzZor7G CAymXCl++emsD+7iWZ+37Y7pxQltek4txfBPaUgsxQBiTwhh2ubIFBXaTHmDwuuumg5Hsjjd GJiRY9OMZY7W/XYwiO0FDQ8jil9Axrx27pyFeej3emicvlRAgiA84EoY5CaBPW52cpodk5ic twriqknqsSKSmFsDX25tDOWR0vvk2ooUA6mepWq3BES4MRZJJYsIRa1kJIF5UrGj789ekcYa BTJfCZwMwTXUKRbnjfsGUq6NuwXk4rFhPDeUQGstz96UkioFlJi28jgOAPlHYJ85wwD7Ne4f 7fD6hunLZSCucLcKNUHo46MIWKI12IZSiJHHOZIFzhGq1CEWnKsYTL7LI84/zvUIAUzaE1hI /KXDpjxCEPknrVeI2zNaBwg1PwqD3XZ0Wu9ige3ek0hlTEfsurDcXZI2pe1vdJoJ0kc7/msr iISdZr6sTYXBrT8LZyrnLDsqZpWAcjue0uy6IGsgG107X2A7yvkNDnW9DuA5eoOQoYewrEcw g+tX7IVYh90nw= X-Talos-CUID: =?us-ascii?q?9a23=3AVHGQVWsgsphaf9dX7bcrpLRN6IsmTCzQ3mj2ZHS?= =?us-ascii?q?RAF1Qa5q5UAOz/7NNxp8=3D?= X-Talos-MUID: =?us-ascii?q?9a23=3A1hl4uA0eRV/U6xhod3tmvTfL0zUju4+JVnAMvrk?= =?us-ascii?q?/sMSpHgEvYQiRq26xa9py?= X-IronPort-AV: E=Sophos;i="6.01,180,1684814400"; d="scan'208";a="115118969" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dcnqmzJti7XUz5H2g53I/yQSung+rI5GgfEghGw28MKX6iLYW/R04MAvazLDnkpL4fJDhGGrExH2qi3dXYDquz3j3Ni1/QBrM5eoN/IOcjQRC7md4JF0u4TZxndgKKlzf/pGLhNHW57NgqdQYw4qoCDAJqi6uGTAwmxC5ESbeeQn6VdrdN0iVChU2Nrn65n75sZ4fHqPl77pkj4YtGXErBKGjcEuOSrTsAoYo4/baN1x9DVt2AjTJsfnE0tOZL7sGIR/4uSGn3DdqxqIfKiMMo7CMtcCwBH8QegUuef12cRJ1/Z2e8H3epyUaDOBoEOP+KzGuP58pl6X2/UKucY27Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+iq6Px3XuOK7jou86nQAx7Hx9wTtRpzX0xayRfgmwls=; b=P/NlHWJ4wdpPFNQGSDF81HNzgDwztxG+1OuqFzG+PI1H3gkZSMq1twfKT2vpkB7kt1wGE08XGtizvhJWmhplI7DBeJ1lVOEQw1Mm644HFLLmx6D70wACEh2pcRlfebdWYXcH5heMIkj/ZyVSseN07WPyQR/FJly1l34QOI4+gBFYNLYtEBDy1n2qMys2P2z+eK/qs/TiLC6bny5GgJKNyh5eSzk5jVubTFj7WoAG65xiS/qJaRbx4tOjNwQmr4/l+EIvDMmQHpT9Ymulxk8wO33o8QDj/fgjvgLemrAWl4txDMwR7eg0VUF8mh5ExrsB/c6SFJqCO2v4+XY/5Uk4jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+iq6Px3XuOK7jou86nQAx7Hx9wTtRpzX0xayRfgmwls=; b=UyOAtMBln/HP+Ub8xyr2lmTkFoLO8bCCJcC7IgiR7A7QmJf6BYfp5yxt9FRqa4cdOxVLuhBRGQW0L9HNLxEEUGNi135BWfc8HeGPagRi9KxsRfvowFWCtMLje3qJFn6q5IY3f7K0yL3+pigUq+qzrppzVVNjMAhuv6Qi/qyP7WY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 4 Jul 2023 12:57:46 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH v3 1/3] multiboot2: parse vga= option when setting GOP mode Message-ID: References: <20230601130518.48874-1-roger.pau@citrix.com> <20230601130518.48874-2-roger.pau@citrix.com> <7453fd92-0dcc-c278-df57-f119240bae65@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <7453fd92-0dcc-c278-df57-f119240bae65@suse.com> X-ClientProxiedBy: LO2P265CA0288.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::36) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|SA1PR03MB7056:EE_ X-MS-Office365-Filtering-Correlation-Id: a7d25573-1963-4338-1d0b-08db7c7d83da X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dHlLMd9alJwyD1hLxb+Sr0YQ8uy5VGtnbJWZUTe7l6UPvl077ppX/2fLquTSwiqsed/ErhbmISB8NmVznzbTYknxNsInjeRQPFHUbIGWTTS2k6W8hbbZLgjpq1zUsqR9eQBFUaaZuGVhp58zD89CYSe6Tt+EqKeXK0Y0gMtGr4o0kL6Cs3HoqtQPKMhANSuDDnCqqJc+41VUcbj8zEGeiytcWm32VjF8A3KY71nVQlNAVkAss0wh2tmtEZVPdsAwABz6gX9iQ4DRvM22M8CpIVuQE2SLJZFoB1QE9HH+XRT/P9e7hs10ke+BZZLPdWMb+vWZiOwbysLNY2bngTaYqzp+lsjn1vyaVk/jM6dDXym5LgU/6mn+RDaW0A2bqZtbS6uEHzWiCwnhT6FxgC003cDTimnTFwfRk52wbUUENrsynBAo3P2pxF3EqE9W2oOI6UsDjIjjJcfQnFlX1irT8l7YENvvzoaRgcUxMxjMtUBqiTs6feB3heC5lBGq+U6eDXeDyLqXzUyvoEKGoRV3uEFbOyQDfRfOU/KgmmywnDQUYE87emi+OwYpksiymEZX X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(136003)(346002)(396003)(39860400002)(366004)(451199021)(26005)(6512007)(9686003)(2906002)(86362001)(6666004)(53546011)(38100700002)(186003)(6486002)(82960400001)(54906003)(41300700001)(478600001)(4326008)(85182001)(66556008)(66946007)(316002)(66476007)(6916009)(5660300002)(8936002)(8676002)(6506007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UTV1K2lmT3JkeFZSS25QeEtZeVBMSUl6d2lad2M0YjBtQ05LQ2xGYnA0TFZo?= =?utf-8?B?eG9OV1RvcE41TTY1L1JMUHA2cHpONlFvaldCYmRXbDhkUTdScE9GR1VYQkVN?= =?utf-8?B?K3FWZWtPNm16S0hWakZkeGo0a3FSWXpHcEdneUtaL2RGaW43M0ZBb2FFVGtk?= =?utf-8?B?MU01TEFzRGZoS3hTVXhXRlQzMVVDRFk0V2ZtUnFrdThpS1ZIRXlFNUdHUUZE?= =?utf-8?B?Vm5TMzQ1U0dVeElEWjkrdmdoYWFvVE1jb0JTaG9uNzBIVGlOWTh3aVVWQ0dm?= =?utf-8?B?aVBnYkk2MWVockxIclIvMTJpc015Rk01VnIyOW50SE8vYmdwUWUvdCtUYkNC?= =?utf-8?B?eGR4ZlZRcVJoYXdNRTlaN0R6clY1aUY4VkxkUHA4MVExamU0NWUrV0gzcW5U?= =?utf-8?B?ZmFZVWNQcEt6cWc0Sis4Y0NjVTBZN3RHUkxvd2ZFU2RwVW9aRUVHQklJVjNi?= =?utf-8?B?ODVjRWhyN1E3OWg0MzR3amhBT2ZPb0ZvbHpPVnZ5SlBUcHd5ZzVsV3o4cjNM?= =?utf-8?B?ekF4TWs1MUxPelZreUZscFRkdENZVklNeStCc05rdHF3djkrQW5qa0RBQ2hR?= =?utf-8?B?ZEFyZVJDbXJwNTArWXZzT3J0VVdMZEFsZzlIaHF3aElVOGxvdkg1S0NWMTRm?= =?utf-8?B?NitYaElqNmlOc2lQbGxqVFJCNWZmdkNEV2xxWkdHd0pVc2VIeWNOTDJQeXA2?= =?utf-8?B?c3BNNmVaSndUZWgwTnRFOTFzUFN0clZOcmovSlVyd09FMWFxZFlPWTU1TFlN?= =?utf-8?B?T0VNR1p0R0ZUTGhzOHpucHVsaGZ3ekpqVXZKL1RpTDg3ZXdXd3AwKzVpVHJI?= =?utf-8?B?MjZxK0dvZ0tucmZhcklGd2E0VnJYWUFyb3hiU1htVWhmMGF2K1Y5TW0zYTEv?= =?utf-8?B?MTBUVkhMbHJ2VHBqWkp5eUNKRzdCeW5vMVRJb2VlOE9IMWZYd0MxZmF6Rm5T?= =?utf-8?B?RHhqUnEwMklDTkRsN1FLMWtUOW02RmdvMWZMcjB4Ykh5aTk4SkMvamh4UDlp?= =?utf-8?B?VHhFZnBia3VOOE1VNzJqTW5jRy9SMkVkcEtLcDRCWVBzN28rUU9tNzk5RWZh?= =?utf-8?B?OTlMTWNEbWpMUFYreDN0NzgzUldBSGtKbzNTeU05VFRFVk84MTcxL1dWUExQ?= =?utf-8?B?b0JheDRFLy9pTlo0M3h4VXI3SWpTRVZyQUNIS2dZMXh6YVpwZ0Z4WjkwUXBT?= =?utf-8?B?SVFPWDdZQVRqTmFsVXZ5VDZVNytUU3dkTzlYTWNwL090QmkxYUZFcDVneGxV?= =?utf-8?B?ZUxhMy9kK1dSZHBPcjFWRzRxQVNXUThnWDJNQzhPYUpnRHFuVTdlZW5CdklT?= =?utf-8?B?TjRrVjVlSXhrZUw0b3grR0JyS0ZyVkZwMkZwVlFYaStJV2ZFK0pWMFJpU1Fo?= =?utf-8?B?aEExcHNndWhxNU90TGJkc0xoVUpEME40bkZxYXp2d2h0UjFzWXB4aXIrYnNq?= =?utf-8?B?UGNTczRUblp4ZDBGYUYyZ0NQSHVhd3NONzRzZi9SdnpqV3FaQll4STNaMzB3?= =?utf-8?B?Q1dLdUQzNW9TSXN3TTNWVXVoZ29xWm91aTlib0JmaWsvTGtqYW9idGlVRGVU?= =?utf-8?B?R3FIUmJjMERxRUlQM1ZaaTZOYUNILzd6RjZOL21tRkQrNHlmdzlxeWRtdW5Z?= =?utf-8?B?RW5yL1hCS21pbEVSY05sckNTNmhEdGlSd2NINE92MGp4bzVndEhvSUZUckow?= =?utf-8?B?RUxOYzJMOTlubXRscTdNeWdxNEp1VHlCR0ladEt0T2FjbWtyVXFrd2NyUHpm?= =?utf-8?B?a3VTYXZ3L1NLbnFlZzU3d1JGSnBlVHFjOTBHa1FJYlQwWHkvODJsMG15QVEv?= =?utf-8?B?STFoWlkrSHFUVkdpK1B2S2xIYTk1NzZ1VlBxOHR6OXI1WjhZS0t5Rit6d21m?= =?utf-8?B?TW1nWENrVFlTRVNUb2kwdmNaTXlFNVJ3bWtEaWRJWVdjM1d0SWVhQjZ0MmVu?= =?utf-8?B?bm42anVVai9pdlhiZkwvR1B3UjAvaE0rRVE1aE8wRmxFL0hUZU9YN3l0cnRv?= =?utf-8?B?SFA1eHFFUW01ZFBMTGdvT0pickR3Z3hXOGJVS2VwaGJZcTc5RFZ0NGtsYW5E?= =?utf-8?B?cUlyenZtdVkvMHUvdndlNU10NzJDKzU2YWRmOXQrVkYvS1ZhakxmK1FERzQ1?= =?utf-8?B?VWhzd2FJeUhSaVM3aG5DMGhiWnFNa2svckdLWlZVNnFOeEorQy9pZGdIWmhx?= =?utf-8?B?MUE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: uXIRyCe28mEVom+drVtGA2t7WaMBRxunBskRPWDKSfkJZQ3fx7BpTRnSNOh9S22VqyLYc9YG/flWARd+4gSNsANpnmejRZJVxZITwwzFNur77dNsANczC7YNmBSovKpEGKD3oLDGlCq8J9OPXk5IFNx6rEJGZi1ZvphOTQY5O2RwixMkq9nveBrqHmuFYJTUEHeWUEM+tV/iq/bKh/gtpfnxX+rZS7l0dp0VRIztfgLaf0FWRnNOHZZcK5yJ/c9m7nyQQsgUZUIagNcSo/quRoFx1/VOTMpc7K3iBMfwsg/PvZ5glq4ttkq1yO0/D2lKYZosrZb/xNeXDcdjuxZX27NV4xyFNsIfI6fap5WaL2SR8AniHPNAlMbKAALrt8PJc1upow5B1dfjijxSJsUHhD5l0XsW65lETWLKiw6qdwx4PxCoiLEXeKDH6BiBif0hiCJkG584Xw1KewjjurbsBZl/CYa12PbnSQiGLR1rC/wpxXevkkKTimfLlhWmyIMAeei/4SncRspwgi31b0j2uKo/THuke5HcpyxzdoWFEFyFZN1DI8kh89RjcW4SLIZAludc5XHbT7ToAvqJ3/Z+cNmD7SkKd8NuBBFAJ3k4K6zcqwIDV2npzII4lPFT0Cpbdb5Xqf41PLi4jLaTljINqwYfqWdfahdfQr2MoxMBvD29yilHzFhH0fQFiD9K0AmhrNT+vX4DzvlyQyeqBdqWLGAYmPG6rgZovv+WEa9p8MLd+S2uYD0V6CSusW5W8uX/vo7pjZqw72cZ5JGutdcKH11YOGu1Dyku7c9OxYHj3f0W3NdbBOFKcBks5qh8+OAK X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: a7d25573-1963-4338-1d0b-08db7c7d83da X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 10:57:53.0632 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sE3Wrmgs4axKLzDy1lnVCp9Sakx9paxdTdUECrUdRi2Iq0TvSdjD6zBYwmvsn7u1f6gkNpStrwIUg9guXt1A7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB7056 On Wed, Jun 07, 2023 at 12:10:28PM +0200, Jan Beulich wrote: > On 01.06.2023 15:05, Roger Pau Monne wrote: > > @@ -807,7 +830,41 @@ void __init efi_multiboot2(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable > > > > if ( gop ) > > { > > - gop_mode = efi_find_gop_mode(gop, 0, 0, 0); > > + const char *last = cmdline; > > + unsigned int width = 0, height = 0, depth = 0; > > + bool keep_current = false; > > + > > + while ( (last = get_option(last, "vga=")) != NULL ) > > + { > > + if ( !strncmp(last, "gfx-", 4) ) > > + { > > + width = simple_strtoul(last + 4, &last, 10); > > + if ( *last == 'x' ) > > + height = simple_strtoul(last + 1, &last, 10); > > + if ( *last == 'x' ) > > + depth = simple_strtoul(last + 1, &last, 10); > > + if ( *last != ' ' && *last != '\t' && *last != '\0' && > > + *last != ',' ) > > You check for an appropriate terminator here. > > > + width = height = depth = 0; > > + keep_current = false; > > + } > > + else if ( !strncmp(last, "current", 7) ) > > Don't you also need to do so here, and maybe even ... > > > + keep_current = true; > > + else if ( !strncmp(last, "keep", 4) ) > > + { > > + /* Ignore. */ > > ... here? Hm, quite possibly for correctness. I felt it was relevant in gfx- as to avoid things like: gfx-1024x786x32x64 being handled, but the same could apply to passing on option like current-bar. Will try to generalize the terminator parsing so it applies to all options. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Jul 04 11:07:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 11:07:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558263.872184 (Exim 4.92) (envelope-from ) id 1qGdsj-0000ah-AV; Tue, 04 Jul 2023 11:07:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558263.872184; Tue, 04 Jul 2023 11:07:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGdsj-0000aa-62; Tue, 04 Jul 2023 11:07:41 +0000 Received: by outflank-mailman (input) for mailman id 558263; Tue, 04 Jul 2023 11:07:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGdsh-0000aS-6W for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 11:07:39 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on20611.outbound.protection.outlook.com [2a01:111:f400:7eab::611]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fa932702-1a5a-11ee-8611-37d641c3527e; Tue, 04 Jul 2023 13:07:36 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by SA1PR12MB8920.namprd12.prod.outlook.com (2603:10b6:806:38e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 11:07:32 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::8018:78f7:1b08:7a54]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::8018:78f7:1b08:7a54%2]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 11:07:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa932702-1a5a-11ee-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F+XthAginLip73YFN46LqnsDbKC/cmYvz5kdx6cdD227qXDZgh1gFowlgMw2wBqAZ0YZM9//UWZl8LtYEIhj564Aodt0Ij3r4YkAqJsLOhgtv4p5XeGtAdNHA/SbwtDcRJ+OEX5IO3o+u/qpW+V+YNqCRx5i8mhH/klp3B289LlwDtRXjZ8A9WQmKU3YBZjQeZHodtasVnNrHybStE1TRjkdo78abK8036RhVtcAcl5zcUJ5VqVuCvwzu2/mOeJ3Dh2+jBAVedXYL08TZ12TO7tw+bpXBh3bFfsIHFFC7v06pBgLIY9hYVt1CFC89VAt2rUF+cPoNiAVmvYAG9wXLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ABLD5CfrQ/CoGwmoWpyJYZ3oFewgB4NwBVvtre4khZE=; b=Q+xvc4naTqeMeWF2x98Zmzq1y/HNeEIA8xCG+BxtXR2QQV36a9c193Ra2a2uX5i1BwM1BUx5XhtDhhzxpj3JhZQI42URsBiGLaJe2eB7B3ja1PtEw0tBn9O0JRLeQiLQVP1l4ST79ViirQn0Q1T6bdasLA37YOgKe46Fhld4/Hm493NBkQdKQPxSsxtvCGu4iKhSxw9Pg8CzoFtT2IyJy/jRRFeQwxI1Yn4v+8ALpSvd5l3nHBodda9ANr1Oo77dBhN3p+OQCzh9h7geGg8pk0rnigU8L4GhomDDzUjPCjaUYG86DaD5YDxzQiT/vrTMGjGFGUKQDEIAta/QYDFVfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ABLD5CfrQ/CoGwmoWpyJYZ3oFewgB4NwBVvtre4khZE=; b=YntzZdQ6YH4dgut0JTYh+8jKQprnQU8LpPpDYMnmlI8t+qRiFTVmg2tB44zLyDg7vBGsexgJ5AEWMlYPEPi3c0DJIFklnPqmxD1rFSJ0B137yiRnjabkHZ7cm/iBWgqf8hLt4kR3Kyl+/hhIzVOzJ7m51fnGkXQnHGT5lzIQ13w= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <2d39d60d-f06d-50fc-6b9a-e3df227e80c0@amd.com> Date: Tue, 4 Jul 2023 12:07:25 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 05/52] xen/arm64: head: Introduce enable_boot_mmu and enable_runtime_mmu To: Penny Zheng , xen-devel@lists.xenproject.org Cc: Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk References: <20230626033443.2943270-1-Penny.Zheng@arm.com> <20230626033443.2943270-6-Penny.Zheng@arm.com> From: Ayan Kumar Halder In-Reply-To: <20230626033443.2943270-6-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0113.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:192::10) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|SA1PR12MB8920:EE_ X-MS-Office365-Filtering-Correlation-Id: 4d4c7d0a-6f80-443f-ecf5-08db7c7edcf2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Dd0IHo+AzDZZ+ehSCssLUZKkRmxoL1ohn0sKVDiT38zYH31vQNz/29p6o3ygg16gH8PnVDvkwXOw0JVbfb3MRGyCpocEtVaGtbgDIJBoTtCRsOfRVahhgX+KBWJqIaOSmVj01P+UqO7WeDbas6uSk1gGAqZg9u9Jid1OxnKCi0HDo4A014E8jYKFcM1fQJZne1GzXFaexj1Jg3OhE9e9duo09LQY0/ZMzlo9Y51LeDphwMnbw0dcVLXAbpZOtimumejAGl28Iz1DmJJzI4MHYoSoMhsoHkYGaBllvRknKKKmOeJuHy0oc/USYB2Zqgzvn5FZmQN9YYERoFgJPAIzwh4h8feNiOQ2q9gyHZIkQphj9i9d0FJvbQISyQow3tQiVRd+ihXe/wMxn/qZ6cSuOQbHgOCiDP6Ml9/y27gDerfeWlEYf6Nvh9z77IANBfdJozYbGpK+W2Pfxu8X2XJf3k5Vco8fFon8cdu+8sL/khgI83UmmkpaKonsMBI690ubgJDMt229m4W/gA4eslf4e+1yuQR8Jdl2B09AIS17kCgvK+fKrq1TR1hWdmTDwhvJEdFUCiCL4wD6R3qsIgMC9LPLoECrDIkOAEZpWd+xZ7RWXgC/vibXdSFsQJyKfRZ0CEY8q/QuWSnZk9pjfj3kpg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(396003)(136003)(39860400002)(346002)(376002)(451199021)(2906002)(41300700001)(5660300002)(8676002)(8936002)(36756003)(31696002)(186003)(2616005)(478600001)(26005)(6506007)(6512007)(6666004)(31686004)(53546011)(6486002)(316002)(4326008)(66556008)(66946007)(38100700002)(54906003)(66476007)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N3l0QVBnNDU2ZE9vWFhjR2F1bzZ6aGtKL3hrbUNvS2JPNURFT2FGSDJWYkVN?= =?utf-8?B?SWE2T1kvVzY4bldGelArL1U3dkM3c1V5aDc4SEVCQzZ0RFIzalpVS3pHajYr?= =?utf-8?B?VVNmNk02UmNIaEpmMHlJRnpZd04wZlQxdzlNb0wxZUhxTHhxRjUyWS85NVNm?= =?utf-8?B?WllXQ2JVOEdEK0ZybXY4RE90d0c4WmZsckxXb3ZIV1N1NHpxUzhFWitEdDh2?= =?utf-8?B?eWlFM29sT1Y0a3NWTnhOMSsvbmhVTmpHbTdrb3RKNm1kNC9lQXdmT25EZU1K?= =?utf-8?B?QXIyeDZsUlpFeDBoc3F1L3daQ0FEbTZ0YkM3bXVvK2p6ZEZYbG9XeXo4Rlcx?= =?utf-8?B?cnVXcXpabml5d1BPODlESmU5MWxOd3JaS3NwejA4ckt0UVd2QUhwT2N0MDZh?= =?utf-8?B?cXU0SVhVSUxnOTF5WVRkU0IyVlRHQ0t1OEJMVDlSQ281K25OdVRkbFkvYWp0?= =?utf-8?B?dG55T0ppZHd2ZmVaU0FZRFoyUjNlRjlaVUdzaEFYdUd1bm5aNld3aTZSWGJH?= =?utf-8?B?OWZyM2lVWjdSTlQzNW5mVVI4VDlKRzBmdWJraWRKaWJpeU1XMERpSTFYR3M2?= =?utf-8?B?akxsWHp4azhobmROWW1nSnBOWEE2S3VnRVBucVZwaDR5MkRlN1puYVUzUENn?= =?utf-8?B?TTNrb2p5SnpaeXIvUzdZTVUzOGdSRERGc255Q1pWSVFvdXA5VWE4U014RUZs?= =?utf-8?B?UzR5aGxacmk0dkpVeFV2VjF0QjUwUFRtVHg0M0NPNWJ6MzFUUUE1RERIKzF2?= =?utf-8?B?b1hMdktRYVB6UmVRbXYwa0p1UndRNFJXTHZpZFIxbUxVcVQyeHA1R2ZOZVNa?= =?utf-8?B?Y3psZmpyRkZ5Z25MUlNMUWRDYitRZ3huZ0p6Y2RKK0NxaHFHZ3ZZcm85SEpB?= =?utf-8?B?STI2bmtTYW5RWGtaMnhVRXg4OWRKL00rVmxWWnBvWWFDaVRKWFZoTWNNeXU4?= =?utf-8?B?QTZxeHl2M3BEOFpVZk84Z3pCeXlQRzM4TEF6SGZBMVVoNFhNTVpqaU05QTJx?= =?utf-8?B?bWdkbGdPMnZrelVabGhhTEphNHk5SHVjRm9Kczh1NTBtaS84T0IwYk9nWFNB?= =?utf-8?B?Mm9NMlNHd3EraXl5eFVWd2dPWHVLRGtkZjVYckwyOTRxNUpGTHJXa2dQNGFx?= =?utf-8?B?dVRHMk9aWWw3eUFCQ2ZKaVM3VG9idkZSTWhiUUU0NU1jRGlQM3Z1SmZTVnFn?= =?utf-8?B?R2cwcitYVk9FU3dNT3dubXpjUGQzaFR6bTIycG5yQUM3YlNXVEJKcnBLOEl6?= =?utf-8?B?ck9pMDZTVHJlUnExRE15TTZiQkVHcVo5MWk0K2pzYmMvenVmOU0weU85WGxr?= =?utf-8?B?Q2hrcTFnQlNUcnJSRXlaV292T1k3bHlCVndvWEFxcFU0MjJLR3FlWExFTnpP?= =?utf-8?B?bGNYblV5UWYvYW9JVVpJb0VoTEI1QWxIWmFqcjJYZ1QwcVdlV3d5Y0JZaTNy?= =?utf-8?B?SGlPL2pnZ0tuYnAxMkJicm45WUZqMmtxbVlFZHUxa2VGck9QQ2tkK1BnUFVp?= =?utf-8?B?TVJlQ041Ymw2ZUJ2NHFhSjd3Q0NBUm1XY0VLY29kd1hsMitGWHc0eWlKWWU0?= =?utf-8?B?TVNld2N6MHNXR1hBMUVIaXltOTMvUW1UYTNXVTVDQzczT3I5S3BuaG14Vmhq?= =?utf-8?B?djkvcXdyR1FObm5lWFkwMnl1Nk9MeUZwK1FwQU92Rkd3UldMZko2U1NBemND?= =?utf-8?B?UGRRUS90aUt6QzVlY0hzWjVpMHZRYUpoVndHWjVQQ3NpaExHNG05aUNWTXpM?= =?utf-8?B?ZXJtNFBzNnFtNDFTYmdsL0kxOVZCMEJxQkh6OVVlbHBiUnFNQ1djRHJPS2Fu?= =?utf-8?B?MnhEZmE1dGlCWk4vTXlOU25xMDlGMWJINFcvSTRpUHpCUXpwY01Xd3V1RHFH?= =?utf-8?B?Z0lNUzJIZllpdkJVVW5lNVR6MWZielc2ZTV1RmI3R0U3U0pYZ1M2ZUlMN3Jq?= =?utf-8?B?bXA2b29LK09ud2VEOGRyN0YwZGpjdUs2SGlvRGJIREUrZFl3clJVNmZiM1M3?= =?utf-8?B?WVNBRERTOW1EOTRMdEVUbUxjd24xNnRIZVlpZFphWVQrWUx4UnVSUk45cCs2?= =?utf-8?B?S0Y4cUxJVWJUS2t4L2wvcDBkckZOckZYS2pJUEtRdEd3NFJQb291ZWt0c2x2?= =?utf-8?Q?rgfJ9A5/WSXFJsi4NFJgITYf0?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d4c7d0a-6f80-443f-ecf5-08db7c7edcf2 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 11:07:31.9045 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8Eh3tqLJVCVyeFVNmJSvS7DRvDmQrT3StaX8HEn2M0YFeV9d6n2m3YHeYBjqjnfgQwMyl4wMRRRTDiDUUDCAug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8920 Hi Penny, On 26/06/2023 04:33, Penny Zheng wrote: > CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. > > > From: Wei Chen > > At the moment, on MMU system, enable_mmu() will return to an > address in the 1:1 mapping, then each path is responsible to > switch to virtual runtime mapping. Then remove_identity_mapping() > is called to remove all 1:1 mapping. > > Since remove_identity_mapping() is not necessary on Non-MMU system, > and we also avoid creating empty function for Non-MMU system, trying > to keep only one codeflow in arm64/head.S, we move path switch and > remove_identity_mapping() in enable_mmu() on MMU system. > > As the remove_identity_mapping should only be called for the boot > CPU only, so we introduce enable_boot_mmu for boot CPU and > enable_runtime_mmu for secondary CPUs in this patch. > > Signed-off-by: Wei Chen > Signed-off-by: Penny Zheng > --- > v3: > - new patch > --- > xen/arch/arm/arm64/head.S | 87 +++++++++++++++++++++++++++++++-------- > 1 file changed, 70 insertions(+), 17 deletions(-) > > diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S > index 10a07db428..4dfbe0bc6f 100644 > --- a/xen/arch/arm/arm64/head.S > +++ b/xen/arch/arm/arm64/head.S > @@ -314,21 +314,12 @@ real_start_efi: > > bl check_cpu_mode > bl cpu_init > - bl create_page_tables > - load_paddr x0, boot_pgtable > - bl enable_mmu > > /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */ > - ldr x0, =primary_switched > - br x0 > + ldr lr, =primary_switched > + b enable_boot_mmu > + > primary_switched: > - /* > - * The 1:1 map may clash with other parts of the Xen virtual memory > - * layout. As it is not used anymore, remove it completely to > - * avoid having to worry about replacing existing mapping > - * afterwards. > - */ > - bl remove_identity_mapping > bl setup_fixmap > #ifdef CONFIG_EARLY_PRINTK > /* Use a virtual address to access the UART. */ > @@ -373,13 +364,11 @@ GLOBAL(init_secondary) > #endif > bl check_cpu_mode > bl cpu_init > - load_paddr x0, init_ttbr > - ldr x0, [x0] > - bl enable_mmu > > /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */ > - ldr x0, =secondary_switched > - br x0 > + ldr lr, =secondary_switched > + b enable_runtime_mmu > + > secondary_switched: > #ifdef CONFIG_EARLY_PRINTK > /* Use a virtual address to access the UART. */ > @@ -694,6 +683,70 @@ enable_mmu: > ret > ENDPROC(enable_mmu) > > +/* > + * Turn on the Data Cache and the MMU. The function will return > + * to the virtual address provided in LR (e.g. the runtime mapping). > + * > + * Inputs: > + * lr : Virtual address to return to. > + * > + * Clobbers x0 - x5 > + */ > +enable_runtime_mmu: > + mov x5, lr > + > + load_paddr x0, init_ttbr > + ldr x0, [x0] > + > + bl enable_mmu > + mov lr, x5 > + > + /* return to secondary_switched */ > + ret > +ENDPROC(enable_runtime_mmu) You are renaming this in 08/52. > + > +/* > + * Turn on the Data Cache and the MMU. The function will return > + * to the virtual address provided in LR (e.g. the runtime mapping). > + * > + * Inputs: > + * lr : Virtual address to return to. > + * > + * Clobbers x0 - x5 > + */ > +enable_boot_mmu: > + mov x5, lr > + > + bl create_page_tables > + load_paddr x0, boot_pgtable > + > + bl enable_mmu > + mov lr, x5 > + > + /* > + * The MMU is turned on and we are in the 1:1 mapping. Switch > + * to the runtime mapping. > + */ > + ldr x0, =1f > + br x0 Where are you switching to ? > +1: > + /* > + * The 1:1 map may clash with other parts of the Xen virtual memory > + * layout. As it is not used anymore, remove it completely to > + * avoid having to worry about replacing existing mapping > + * afterwards. Function will return to primary_switched. > + */ > + b remove_identity_mapping > + > + /* > + * Here might not be reached, as "ret" in remove_identity_mapping > + * will use the return address in LR in advance. But keep ret here > + * might be more safe if "ret" in remove_identity_mapping is removed > + * in future. > + */ > + ret > +ENDPROC(enable_boot_mmu) You are renaming this function in 08/52. May be you should rename and move the fuctions to the correct place, in this patch itself. - Ayan > + > /* > * Remove the 1:1 map from the page-tables. It is not easy to keep track > * where the 1:1 map was mapped, so we will look for the top-level entry > -- > 2.25.1 > > From xen-devel-bounces@lists.xenproject.org Tue Jul 04 11:15:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 11:15:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558267.872194 (Exim 4.92) (envelope-from ) id 1qGe00-00025q-15; Tue, 04 Jul 2023 11:15:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558267.872194; Tue, 04 Jul 2023 11:15:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGdzz-00025j-U8; Tue, 04 Jul 2023 11:15:11 +0000 Received: by outflank-mailman (input) for mailman id 558267; Tue, 04 Jul 2023 11:15:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGdzz-00025d-CU for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 11:15:11 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2060a.outbound.protection.outlook.com [2a01:111:f400:7e8a::60a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 090bd87a-1a5c-11ee-b237-6b7b168915f2; Tue, 04 Jul 2023 13:15:09 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by DS0PR12MB7778.namprd12.prod.outlook.com (2603:10b6:8:151::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.17; Tue, 4 Jul 2023 11:15:04 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::8018:78f7:1b08:7a54]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::8018:78f7:1b08:7a54%2]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 11:15:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 090bd87a-1a5c-11ee-b237-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b1qjbqt1h5BVOF9bs5EaQ0vT3FIa5ekaPZkAmJ+UDByOb0SkDjIGNXMGMx5HrMGEBjXPFeaxH0s32qhOoxAMBkq3Y4CaJcJjy6SQvQkF1c5PIwe3fozP21Xo+VVd29J4r4ONJs1h/mhPm90BKTaTKDwcKESAYelA1SvkoXUZ+xFjhhA6WpYztsHzLSUvbmjoBeRfDysNCMoSmYS4xSwXSYWo120R1l6/80lbfjfvTmtE0C7L9BxduOY5CFL6TqTNM37ROguqAtpZTkJydblzL7qR76QB76q04i6zTsCkzDjgIpdLtCqZQAcv6m+hVFTkqcXcvOQg/o8AscK6b2sPyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fAI8Ye1hiMiM5bokZODWSS1ZmLb9C8JWqzXtgxkAowk=; b=Xm39IlFVxPayxiCV9mYhnT9w3PQOc8Z4Th3seoBs5GMsMNlfmF8E5GTaDadjqY8Rx1WIvMNIIIJ3HmDlwkWZ0HE2n6nlGlFIrbjNwUoDqAGQpjS+eYs2h+jvQioNkwLqma8aq75hPtWCGQKAWovKOcpkdsOQ0JBF8wP9D+xxs78HG00VeBos+qSPyz/llkOjqJTLZqTIFTJwGAa/V+wmqmY41VrBk41DGbQ/xX4FK0lTHciMkYAZyNG6eJEEBpi95zijSB0qBamVuTgv6M2yGqXAW7FHiae7/oTgiflg4cllgOEL5ePQL6lbEQG0Yo997Pr0Q8kL04RQ5kIzi2lshQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fAI8Ye1hiMiM5bokZODWSS1ZmLb9C8JWqzXtgxkAowk=; b=PaEFIfo2JwvdWnOVc3ygVzK7l/rqIPuVvsoiO3zOM2Z+sxPHKVfa5Wo29vfyweJxDiDoG7D9kWPF8B2x/gKeQoF66HnFB96ejE+uWUcFpW0DWj1c57MKcPHXgozm05jvOXt0vB4hF4pnEG7LOX90YVqKqQy8JajF+5ncDkrWQQU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <4303bf0e-a987-1ee4-9524-c83756789322@amd.com> Date: Tue, 4 Jul 2023 12:14:58 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 06/52] xen/arm: introduce CONFIG_HAS_MMU To: Penny Zheng , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Wei Chen References: <20230626033443.2943270-1-Penny.Zheng@arm.com> <20230626033443.2943270-7-Penny.Zheng@arm.com> From: Ayan Kumar Halder In-Reply-To: <20230626033443.2943270-7-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0197.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:318::13) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|DS0PR12MB7778:EE_ X-MS-Office365-Filtering-Correlation-Id: c0ea7405-330d-4687-adb2-08db7c7fea82 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2K7ZJzf9uyDygERV9Xolzz8s+O6RgAIMCtB2BaSVft9Y3s73TCikS3Z2JxXk4bkNXEPi2ibKT6POEivQNJzvtmYphqioYLb4G7ue0khOYfigE3241uAnaLibBxyAH9Usv4DoshqwnGhezBve4OVqreoFlnPtVtxyERVLdcXdULxWVWGFPtNPkKEFblrBwDEjB8SaxKm+XeUtbmaA4EBz5bIBGEMiB2Zv5AgTPcKuYvAV7WBVcCseYF0Vlv8taDwDU6zKfCkRMna6drHHiVUbSfqYoqrb9O+AEnLl0MbZiQTnNnNFX+x37Tl/ZZD3arLL48sxyvsVjL+MRZtZ/CHH5kFdGmv+X/dW6Dz68NSdu0RpZPijl69W6b4+JXBo374hA21clx5xdVmRWfaGrWRPotSAUu61i1UPoINPV8+cCSlfuibnIHJa9tcvoTuWVFyCTnDW3FatyPJE5IXAF7DUM8CYIpZ2QkePuogfAgmm+ZGFjHnJZXn7QKeEqJDI4UFRuT2i0sWZusDSkun4OCXQtyrlnCq8qPXnuuhDTeSm7AzpN+LSmRrXD5a9abpEbFN8M+Eq5SY/4nqPcVylo1LTVMHKQaQVQXA7HTrr3+sEW0krfxoQj+rBXLFr+a0rdT7TVXLKRnYa+QZm1lm6qezWfw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(396003)(366004)(346002)(39860400002)(451199021)(2616005)(2906002)(83380400001)(38100700002)(36756003)(31696002)(6666004)(53546011)(31686004)(6506007)(5660300002)(41300700001)(6486002)(4326008)(8936002)(8676002)(316002)(66476007)(66556008)(66946007)(6512007)(478600001)(54906003)(186003)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QjQwMVZkVmhuanBaUlJ3Z1JEMGppLzE5Wm0yeVozQ3hlVWhBSk5VWmY3bDF6?= =?utf-8?B?enhNN0tuUHFyUVFKVjl6RUs5UU1SM2kzYlBQTm9sbHEyRzNLYXp2R3RSK1hF?= =?utf-8?B?aGh5eG9kSDgwUEcvRnZaRWFPUGNPNHJWd1N3WHo2aDMxRy9oTzhhL0dsRE05?= =?utf-8?B?c0xUcERPRE1CUnNQbEFQRnNWeEZoZVdna1BmbkxKT29VTGx0SU95Vkw5ejNN?= =?utf-8?B?VjZWcVZOVTdwRThoUzV1V25jZy9EUTl2WDhxdG01dWg2aWVEYkhpR1Z2TENY?= =?utf-8?B?eFZHdXpBdlYvM0VVcklhRXEvbVBCbHE4Z1hGMnd1bGhQR3AvaUh1cFdiaUow?= =?utf-8?B?OUxYWDVScEpYUDlORFhyY2hPa0NWeTBoQmtidGtGeWxiSVZVN1J2YnhlRzE2?= =?utf-8?B?L0dTK2hzdGVvdG0xQWl0T0EzRzI3eGRKNWdHSkFqRTBXdk9yZjhyWmRpRmxq?= =?utf-8?B?VTFkQXYzb0FiRHpGVFF6eVlxaWdNczJGTU41UGFiMlRud1d4dlFNN21TQkdT?= =?utf-8?B?N0tqcjRKeFJZSnRzNTlyODFhdmNCRjVjcEdXMCtEREJPQUVLdGJmbUJEclpp?= =?utf-8?B?SU5tZ1NKY0owYVZDSVFvdnBpM3NBYWZRZlVXTkVLU1FzbnhZTXRXZkNnN05F?= =?utf-8?B?WVBwcDhmL28xbW9xNmNmWUhZRUhuaUV4TndaYXd2aUI3WlVuNzJnSjgxNGk3?= =?utf-8?B?YU1RWVdGMG1Bck15VHdSRUNkM0kvaWQ2bFF1SjBXOFJCY0lWWGIwTlZsRmRD?= =?utf-8?B?WW94WDN0cTA1c3VxNitoZjZMSUUyWTFqTmxqaW1lVkM1RDkyRE1kQmVpT3ZL?= =?utf-8?B?Z0pUUi9HMW84Nk5nVUdEMG51bUpSRzFVZThEMHdJSHdaSWZxYnVxdXpsTWRn?= =?utf-8?B?bzNTNWxFeUJROVFtaEhYbFJPZTFBQWY2cnNRbmczTDFIZXpqOS9UcllUczlN?= =?utf-8?B?cWZQTlYvNllLaTVQQjlJdjBxV2F6UXp3SjNDZmNHVm5rRHdWWHVSYkhURE5L?= =?utf-8?B?V0JSZm0zaDVQMk40c3pVWWJBazV5VFpGb2F0UVFwdEJEWnRvMGNGc1ZXK09r?= =?utf-8?B?NDZwNFJTcGhFYmJTbFRKVDhXQ0J3ZUxsZUhVUzB0a3JYRkZ6TkJ5YVdsSzB5?= =?utf-8?B?cmVCbU10RG9Oenczd2g4RGNXOGtqL2VxMmZ2UTBHZ2tsRnNKVUNzZzlPMHJp?= =?utf-8?B?WnRYYlpJMGtmbEN5SjRYVEUrR1dtNGppcFRTSS9nVmdzWEIxUmNOU1hWM3lM?= =?utf-8?B?OXlsYTBzSHBjL1Jkek1adFlyUnB0cGtMVVNqN09XSHN6QWc4aW5RMm41aFBS?= =?utf-8?B?R3VFS2J1ZlZOaUpta2FvSWhEWmNHL0xXZFNReTRaak1hOXNVSWxlODFhTE5k?= =?utf-8?B?czU1Z2dUS0djb1EzcFZqYkJzYzhlWWYyTnZ5bDRHeGFWSjBiTHFyTzN2QmZi?= =?utf-8?B?ZWxvSUxkZE5DU1B3MkkvMTJGbzZTamx4UEdzaVAyUklTeGhJOEFqNjJPRUpC?= =?utf-8?B?aDdqRDJxc2tPZ1FsNGhYamhSYm9NVEFQMVUvUUZRTTJSUEtpN1pQQURZWTc4?= =?utf-8?B?OXFHNUw0L0tLQlU3bVhnMlh1T1VYYnBCcm10Q2k3WUZFTG0wWmxnT3NZN1RY?= =?utf-8?B?Yk0xWkFMcndpYm5OQ1lnOWQvbEt6VFBwQ1N4ckJPOXBublFUTHJZSFVldHBX?= =?utf-8?B?V2I0NDAzcFRoZk5naUViWlRRRW10K2htOUs0czZ2TSs4YSs0MDJIRkM3a2Uy?= =?utf-8?B?cVpmdjNOR2YxdGN3WXRBaUtwbEUwVTczR0M1RlZjckFYaVoyUE9WdyttczAy?= =?utf-8?B?ZGRQSWdmdTY5VnVrZ3ZYaUhRdWs0U01OR05tMUFvcnA4U1FrTmYrV3lzTHo1?= =?utf-8?B?bmJCenZPRzAxb05ONnZFKzVHRHVVZXYwQ3Zxby95R1ExNDg1U1dCTThPVWJp?= =?utf-8?B?MTNKcDRjOWx3WDB3NmdTVnEyYmdTVGt5RjR3MTYzZU1VMGhOU2tsRDg0c2VJ?= =?utf-8?B?NmlQeTFrZGJCSUQ1RTVlLzlOWHJ4Vi95Q2ZualNwV25XVWZPS2xzRHl1d2ZD?= =?utf-8?B?Y003ejVIQTVsL21LQ2Q2QzJJZFFqaERGT0xjOUk4UDZjV3BUWEk2SG9GY3pR?= =?utf-8?Q?HV7wNpFSf43o1fiKgnONoySB/?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c0ea7405-330d-4687-adb2-08db7c7fea82 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 11:15:04.2139 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: M4ziEqqUbz9xgBHsE5MGjfK1UwB/KJz9Y0Rx1d3j/k2+fldzvQVkxfuVmC+xYntr7pkLVD88F6RlTGUQME5iIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7778 Hi Penny, On 26/06/2023 04:33, Penny Zheng wrote: > CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. > > > This commit wants to introduce a new Kconfig CONFIG_HAS_MMU to guard > MMU-related codes, to tell two different memory management architecture: > VMAS and PMSA. > > In a VMSA system, a Memory Management Unit (MMU) provides fine-grained > control of a memory system through a set of virtual to physical address > mappings and associated memory properties held in memory-mapped tables > known as translation tables. > > Signed-off-by: Penny Zheng > Signed-off-by: Wei Chen > --- > v3: > - new patch > --- > xen/arch/arm/Kconfig | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index ff17345cdb..fb77392b82 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -60,6 +60,14 @@ config PADDR_BITS > > source "arch/Kconfig" > > +config HAS_MMU > + bool "Memory Management Unit support in a VMSA system" > + default y > + help > + In a VMSA system, a Memory Management Unit (MMU) provides fine-grained control of > + a memory system through a set of virtual to physical address mappings and associated memory > + properties held in memory-mapped tables known as translation tables. > + > config ACPI > bool "ACPI (Advanced Configuration and Power Interface) Support (UNSUPPORTED)" if UNSUPPORTED > depends on ARM_64 I don't think you need this option. In patch 52 ("xen/arm: add Kconfig option CONFIG_HAS_MPU to enable MPU system support"), you have introduced "HAS_MPU" option. May be you can introduce "HAS_MPU" option a bit earlier, so that "!HAS_MPU" is "HAS_MMU". So, you will not need this new option. Let me know if this makes sense. - Ayan > -- > 2.25.1 > > From xen-devel-bounces@lists.xenproject.org Tue Jul 04 11:44:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 11:44:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558271.872203 (Exim 4.92) (envelope-from ) id 1qGeRt-0005TF-1h; Tue, 04 Jul 2023 11:44:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558271.872203; Tue, 04 Jul 2023 11:44:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGeRs-0005T8-VL; Tue, 04 Jul 2023 11:44:00 +0000 Received: by outflank-mailman (input) for mailman id 558271; Tue, 04 Jul 2023 11:43:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGeRr-0005T2-Cc for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 11:43:59 +0000 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0d19233a-1a60-11ee-8611-37d641c3527e; Tue, 04 Jul 2023 13:43:55 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 4BCDB3200A5D; Tue, 4 Jul 2023 07:43:51 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 04 Jul 2023 07:43:52 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 4 Jul 2023 07:43:49 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0d19233a-1a60-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1688471030; x=1688557430; bh=DXvLHS+0i7KcpP91tmBqUwtDBGkK3GQmg1d L9ga2TME=; b=tCAVBdS90txzFAY/kbvh0fqlDpF54OjKwYSWGZXBvpmjlN60j/N ZxBE4ZebnUhndB1F376MCXu80BXumESmISrYvSjincFvsy+GT/BsKhy/xaLr29EJ sHHDqcqUId9mTks0hfL7pZC31e87WVA1uYtEb23l/pUxDSFtSQuMC/QWOM3QgQ61 VHuO+rT1bEo8xRxcSsASkTl7jOJpQFz6Qy8gcKWoFFl/jdOmu58fBmra9LU2Mj0a Obp7OaVD7TXceIr4zirkdJlp0ffgPaoOoNYNyqJr1i+KOz1LdK7FZCQesg8fs9Mw AUejzM/dsYowgIsu3SeqlxkJn8ggBMXIJtQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1688471030; x=1688557430; bh=DXvLHS+0i7Kcp P91tmBqUwtDBGkK3GQmg1dL9ga2TME=; b=Q88FLDWj9kdQwqhgo7RWJg/1w2ncw bkXNzTgHQTui4qr91NZmc/YT+FMOFOMGHsU35rGQvEPOrtaFmqkr7qCehqm3MwVF HAG3vK/30B0yjlUfedtsdZnrZFpM+6QKkkV/XrszRq3cFuwUztmdd98zncwrO7VR du6hl+t2XmNmcEsIYNECs3FSlLe3tJR+8bxI7Q5IS9BRAGa1rWEjRZ9QMqo4rlP7 lT9tTyOUhiD4jNLe/oy2JwbpN0zTkIdhzuwCwJjdZAcQEZCju2wrbpNgFTMC2GpD W2IC9VZd4RI0gfdoh8nkWU5jTyBur6blENG5p5Le4A5/exLr6Z1frgXDw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudeggdeggecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeeiheff iefgteetveeviefhhfelleevgfevvefgtdetteejheeigefhtedvtdevieenucffohhmrg hinhepohgrshhishdqohhpvghnrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhih hnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Tue, 4 Jul 2023 13:43:46 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Juergen Gross Cc: Roger Pau =?utf-8?B?TW9ubsOp?= , Stefano Stabellini , Oleksandr Tyshchenko , Petr Pavlu , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" , vikram.garhwal@amd.com Subject: Re: [PATCH 2/2] xen/virtio: Avoid use of the dom0 backend in dom0 Message-ID: References: <20230621131214.9398-1-petr.pavlu@suse.com> <20230621131214.9398-3-petr.pavlu@suse.com> <15e31609-6c45-7372-76ee-0adf7a64fe88@epam.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bKEul5l8IcOXfCYH" Content-Disposition: inline In-Reply-To: --bKEul5l8IcOXfCYH Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Tue, 4 Jul 2023 13:43:46 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Juergen Gross Cc: Roger Pau =?utf-8?B?TW9ubsOp?= , Stefano Stabellini , Oleksandr Tyshchenko , Petr Pavlu , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" , vikram.garhwal@amd.com Subject: Re: [PATCH 2/2] xen/virtio: Avoid use of the dom0 backend in dom0 Hi, FWIW, I have ran into this issue some time ago too. I run Xen on top of KVM and then passthrough some of the virtio devices (network one specifically) into a (PV) guest. So, I hit both cases, the dom0 one and domU one. As a temporary workaround I needed to disable CONFIG_XEN_VIRTIO completely (just disabling CONFIG_XEN_VIRTIO_FORCE_GRANT was not enough to fix it). With that context in place, the actual response below. On Tue, Jul 04, 2023 at 12:39:40PM +0200, Juergen Gross wrote: > On 04.07.23 09:48, Roger Pau Monn=C3=A9 wrote: > > On Thu, Jun 29, 2023 at 03:44:04PM -0700, Stefano Stabellini wrote: > > > On Thu, 29 Jun 2023, Oleksandr Tyshchenko wrote: > > > > On 29.06.23 04:00, Stefano Stabellini wrote: > > > > > I think we need to add a second way? It could be anything that ca= n help > > > > > us distinguish between a non-grants-capable virtio backend and a > > > > > grants-capable virtio backend, such as: > > > > > - a string on xenstore > > > > > - a xen param > > > > > - a special PCI configuration register value > > > > > - something in the ACPI tables > > > > > - the QEMU machine type > > > >=20 > > > >=20 > > > > Yes, I remember there was a discussion regarding that. The point is= to > > > > choose a solution to be functional for both PV and HVM *and* to be = able > > > > to support a hotplug. IIRC, the xenstore could be a possible candid= ate. > > >=20 > > > xenstore would be among the easiest to make work. The only downside is > > > the dependency on xenstore which otherwise virtio+grants doesn't have. > >=20 > > I would avoid introducing a dependency on xenstore, if nothing else we > > know it's a performance bottleneck. > >=20 > > We would also need to map the virtio device topology into xenstore, so > > that we can pass different options for each device. >=20 > This aspect (different options) is important. How do you want to pass vir= tio > device configuration parameters from dom0 to the virtio backend domain? Y= ou > probably need something like Xenstore (a virtio based alternative like vi= rtiofs > would work, too) for that purpose. >=20 > Mapping the topology should be rather easy via the PCI-Id, e.g.: >=20 > /local/domain/42/device/virtio/0000:00:1c.0/backend While I agree this would probably be the simplest to implement, I don't like introducing xenstore dependency into virtio frontend either. Toolstack -> backend communication is probably easier to solve, as it's much more flexible (could use qemu cmdline, QMP, other similar mechanisms for non-qemu backends etc). > > > Vikram is working on virtio with grants support in QEMU as we speak. > > > Maybe we could find a way to add a flag in QEMU so that we can detect= at > > > runtime if a given virtio device support grants or not. > >=20 > > Isn't there a way for the device to expose capabilities already? For > > example how does a virtio-blk backend expose support for indirect > > descriptors? >=20 > Those capabilities are defined in the virtio spec [1]. Adding the backend > domid would be possible, but it probably wouldn't be that easy (requires > changing the virtio spec by either expanding an existing config area or by > adding a new one). I'm not sure handling in the specific frontends is > generic enough for being able to have a central place where the backend > domid could be retrieved, without requiring any change of the frontends. IMHO the proper solution is to extend the spec. I don't have much experience with virtio code, but reading the spec it looks like new config area will be better for compatibility/uniform handling in a frontent-agnostic way. Since it will definitely take time, some transitional solution (maybe even xenstore...) might be warranted. > Juergen >=20 > [1]: http://docs.oasis-open.org/virtio/virtio/v1.2/virtio-v1.2.html --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --bKEul5l8IcOXfCYH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmSkBfIACgkQ24/THMrX 1yyXUgf+N/PLUJAoNhlNjh4kow5XxRzM4Afaw1bwhZYI6546o2bL/yRgGWcBqNue nNZzUUmNMsNvEi0zy/1rWQppCaDZKPhgtb33Ty9oC9iSBeziB9LQk8A8yOMiQ0st hazKZOfD2GBRpfULOfUCOj6+9AQWadmnHAbKT0gJMSARp3shkfN7kZoL4xczD9tn 2JKsIIBERXc/MpMh7gQwM0F6EBf00Zqi6Qvss8/IKtNuUSI9u7xQLOWrxscUXKCc OoDe7b4jhgRpRR3BZoiON6khBEKBt59UcZR+mQll0h9XeTH7n0MyaZO5SASVdD3m L1RNV4X+MQ8fUplS1LMJtKBg3j9pBA== =CQd8 -----END PGP SIGNATURE----- --bKEul5l8IcOXfCYH-- From xen-devel-bounces@lists.xenproject.org Tue Jul 04 11:44:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 11:44:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558279.872213 (Exim 4.92) (envelope-from ) id 1qGeSm-00061l-Dm; Tue, 04 Jul 2023 11:44:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558279.872213; Tue, 04 Jul 2023 11:44:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGeSm-00061e-B7; Tue, 04 Jul 2023 11:44:56 +0000 Received: by outflank-mailman (input) for mailman id 558279; Tue, 04 Jul 2023 11:44:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGeSl-00061U-9m for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 11:44:55 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGeSk-0006Pi-Gj; Tue, 04 Jul 2023 11:44:54 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qGeSk-00018m-A2; Tue, 04 Jul 2023 11:44:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=FNRxPPITnRQS+7Jl7qtJ4CP52HqUX7u+GL8GLOzKqwQ=; b=6C0d+H+roX0CS+5MFV2gJnRkeM TCj6d9BWLKFqvh7XDl+QT6pZcs5WTpRJEnHjwpG7BpmmIE91BnHq8DXEStXb7t7ELrTh3m0Qyx6zd lI3cdQloEOG03Por3+J6rl93EkeA/iKeO1eQy9gwmk0bk53AH8h4UUWKcH2WB3n3o86k=; Message-ID: <1cbf44ae-2500-1428-5dd2-893e846faf1e@xen.org> Date: Tue, 4 Jul 2023 12:44:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 06/52] xen/arm: introduce CONFIG_HAS_MMU Content-Language: en-US To: Ayan Kumar Halder , Penny Zheng , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Wei Chen References: <20230626033443.2943270-1-Penny.Zheng@arm.com> <20230626033443.2943270-7-Penny.Zheng@arm.com> <4303bf0e-a987-1ee4-9524-c83756789322@amd.com> From: Julien Grall In-Reply-To: <4303bf0e-a987-1ee4-9524-c83756789322@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 04/07/2023 12:14, Ayan Kumar Halder wrote: > On 26/06/2023 04:33, Penny Zheng wrote: >> CAUTION: This message has originated from an External Source. Please >> use proper judgment and caution when opening attachments, clicking >> links, or responding to this email. >> >> >> This commit wants to introduce a new Kconfig CONFIG_HAS_MMU to guard >> MMU-related codes, to tell two different memory management architecture: >> VMAS and PMSA. >> >> In a VMSA system, a Memory Management Unit (MMU) provides fine-grained >> control of a memory system through a set of virtual to physical address >> mappings and associated memory properties held in memory-mapped tables >> known as translation tables. >> >> Signed-off-by: Penny Zheng >> Signed-off-by: Wei Chen >> --- >> v3: >> - new patch >> --- >>   xen/arch/arm/Kconfig | 8 ++++++++ >>   1 file changed, 8 insertions(+) >> >> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig >> index ff17345cdb..fb77392b82 100644 >> --- a/xen/arch/arm/Kconfig >> +++ b/xen/arch/arm/Kconfig >> @@ -60,6 +60,14 @@ config PADDR_BITS >> >>   source "arch/Kconfig" >> >> +config HAS_MMU >> +       bool "Memory Management Unit support in a VMSA system" >> +       default y I don't think you can disable HAS_MMU right now. So you want to drop the description to prevent a user to select it. This could then be combined to "def_bool y". >> +       help >> +         In a VMSA system, a Memory Management Unit (MMU) provides >> fine-grained control of >> +         a memory system through a set of virtual to physical address >> mappings and associated memory >> +         properties held in memory-mapped tables known as translation >> tables. >> + >>   config ACPI >>          bool "ACPI (Advanced Configuration and Power Interface) >> Support (UNSUPPORTED)" if UNSUPPORTED >>          depends on ARM_64 > > I don't think you need this option. I think we want to introduce a 'choice' where the user can select either the MPU or MMU. But not both. This would be similar to how we select the Physical address space size. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jul 04 11:47:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 11:47:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558283.872224 (Exim 4.92) (envelope-from ) id 1qGeUv-0006eR-Pc; Tue, 04 Jul 2023 11:47:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558283.872224; Tue, 04 Jul 2023 11:47:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGeUv-0006eK-MP; Tue, 04 Jul 2023 11:47:09 +0000 Received: by outflank-mailman (input) for mailman id 558283; Tue, 04 Jul 2023 11:47:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGeUu-0006dv-4n for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 11:47:08 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGeUt-0006To-Sx; Tue, 04 Jul 2023 11:47:07 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qGeUt-0001CP-OA; Tue, 04 Jul 2023 11:47:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=5rAYeeMjuJjW2JpxVAZvepcyLjRUGMz17l6NWz50Mso=; b=6BGFFTvBt1UZLr/oKmn7YJb87o mdnGC8yWwxpIHCLiXYQYXT86HWg/cDMzYKctIZX6mmSC2TZpc5fEk0NGo0+nppQoR2IdLdc1nPmdz Ajf5flZE2+WI00pjsBCKOXQa85udpn70TFTUBPk3wkiNVIIu1M6yHgz2b5qzRb1klNSc=; Message-ID: <77c64929-514a-ea67-cf8b-176c895ff971@xen.org> Date: Tue, 4 Jul 2023 12:47:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 03/52] xen/arm: add an option to define Xen start address for Armv8-R Content-Language: en-US To: Ayan Kumar Halder , Penny Zheng , xen-devel@lists.xenproject.org Cc: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230626033443.2943270-1-Penny.Zheng@arm.com> <20230626033443.2943270-4-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 04/07/2023 11:36, Ayan Kumar Halder wrote: > Hi Penny, Hi Ayan, > On 26/06/2023 04:33, Penny Zheng wrote: >> CAUTION: This message has originated from an External Source. Please >> use proper judgment and caution when opening attachments, clicking >> links, or responding to this email. >> >> >> From: Wei Chen >> >> On Armv8-A, Xen has a fixed virtual start address (link address >> too) for all Armv8-A platforms. In an MMU based system, Xen can >> map its loaded address to this virtual start address. So, on >> Armv8-A platforms, the Xen start address does not need to be >> configurable. But on Armv8-R platforms, there is no MMU to map >> loaded address to a fixed virtual address and different platforms >> will have very different address space layout. So Xen cannot use >> a fixed physical address on MPU based system and need to have it >> configurable. >> >> In this patch we introduce one Kconfig option for users to define >> the default Xen start address for Armv8-R. Users can enter the >> address in config time, or select the tailored platform config >> file from arch/arm/configs. >> >> And as we introduced Armv8-R to Xen, that means the existed Arm64 >> MMU based platforms should not be listed in Armv8-R platform >> list, so we add !HAS_MPU dependency for these platforms. >> >> Signed-off-by: Wei Chen >> Signed-off-by: Penny Zheng >> --- >> v1 -> v2: >> 1. Remove the platform header fvp_baser.h. >> 2. Remove the default start address for fvp_baser64. >> 3. Remove the description of default address from commit log. >> 4. Change HAS_MPU to ARM_V8R for Xen start address dependency. >>     No matter Arm-v8r board has MPU or not, it always need to >>     specify the start address. >> --- >> v3: >> 1. Remove unrelated change of "CONFIG_FVP_BASER" >> 2. Change ARM_V8R to HAS_MPU for Xen start address dependency >> --- >>   xen/arch/arm/Kconfig           | 8 ++++++++ >>   xen/arch/arm/platforms/Kconfig | 8 +++++--- >>   2 files changed, 13 insertions(+), 3 deletions(-) >> >> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig >> index 70fdc2ba63..ff17345cdb 100644 >> --- a/xen/arch/arm/Kconfig >> +++ b/xen/arch/arm/Kconfig >> @@ -181,6 +181,14 @@ config TEE >>            This option enables generic TEE mediators support. It >> allows guests >>            to access real TEE via one of TEE mediators implemented in >> XEN. >> >> +config XEN_START_ADDRESS >> +       hex "Xen start address: keep default to use platform defined >> address" >> +       default 0 >> +       depends on HAS_MPU >> +       help >> +         This option allows to set the customized address at which >> Xen will be >> +         linked on MPU systems. This address must be aligned to a >> page size. >> + >>   source "arch/arm/tee/Kconfig" >> >>   config STATIC_SHM >> diff --git a/xen/arch/arm/platforms/Kconfig >> b/xen/arch/arm/platforms/Kconfig >> index c93a6b2756..75af48b5f9 100644 >> --- a/xen/arch/arm/platforms/Kconfig >> +++ b/xen/arch/arm/platforms/Kconfig >> @@ -1,6 +1,7 @@ >>   choice >>          prompt "Platform Support" >>          default ALL_PLAT >> +       default NO_PLAT if HAS_MPU > > I am a bit concerned about this as we will be introducing R52 specific > platform in xen/arch/arm/platforms/ > > (For eg > https://github.com/Xilinx/xen/blob/xlnx_rebase_4.17/xen/arch/arm_mpu/platforms/amd-versal-net.c ) > > Thus, we will have to remove this line at that time. > > Can you remove this line, please if it does not cause any issue ? From my understanding of the discussion at Xen Summit, most of the platform specific code would be moved to something similar to bootwrapper. So do you still actually need to have code in Xen for setting up the timer? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jul 04 11:51:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 11:51:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558287.872234 (Exim 4.92) (envelope-from ) id 1qGeYw-00087O-9z; Tue, 04 Jul 2023 11:51:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558287.872234; Tue, 04 Jul 2023 11:51:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGeYw-00087H-7D; Tue, 04 Jul 2023 11:51:18 +0000 Received: by outflank-mailman (input) for mailman id 558287; Tue, 04 Jul 2023 11:51:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGeYu-00087B-90 for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 11:51:16 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2061d.outbound.protection.outlook.com [2a01:111:f400:7e88::61d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 12d06a30-1a61-11ee-8611-37d641c3527e; Tue, 04 Jul 2023 13:51:12 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by IA0PR12MB7553.namprd12.prod.outlook.com (2603:10b6:208:43f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 11:51:07 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::8018:78f7:1b08:7a54]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::8018:78f7:1b08:7a54%2]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 11:51:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 12d06a30-1a61-11ee-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g05puPOLYeV0Hl5HOlyI37OhNG1W3yCFtTQ3SsGe55Mk0KAGX6kV4P8kssacRRC9262fvOrfuHqgKWRfzll7z6QcT20tO0lACNO1qN/i+MtVw2pK22inep6y2XFByIHyN1C/KcPBN2g0tgvNEXT8m7xd3pplQEqRbcqu9bBW6voM05lfTX0yOMkR2BwACZLQC6gzgpFcUgTz4nyyvGy29s4QQjs0XEk1hvXuKUNZhokUs+TJwUyRbNjkynI0EkWX2Su17LuC9rZ2dMSo2VBlxj2jnIcI5vm/U5SrQ8wzX5vboIkyZ422Ii+bIPJFPDwOvC2I2xEG7SsogeIH3uX+Cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f3ANhmqLxdvka1UwAGjja914oZsDBwyaZbAbS5VTPug=; b=KL+HTjkRgrPZFjnVuu86MV1TNnAl8wrwWGmHonNMoywCMj1TfAmyjH1HinDMh4Dgh1f7rxROLlbOzPBFa4jnDOurB/guqSqmNXYmDYh8minwl/A3WXvycKVXHNA7sK+CIOaMiA0ZHl3XM7DFqlqpenzdyX6gsqnA3B87uecXYPHHyLb2elnJ6mhwcPm6absiAm2Qvw2/UPPk5XlkUvxvq9hSiEaLo3qKOM/DGEi3SfmZ+fPv9cYEQK4nJnbJVs7rvqItiBhQB6DtCgua/D0r3LUZLujN9AJLsryK4kR7MlvrXvXLdZu2/xzUBlJJUfrryotidnn1IsD4O1aeflpyCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f3ANhmqLxdvka1UwAGjja914oZsDBwyaZbAbS5VTPug=; b=cNVvrzmNbxniWqXRtegRn4WJj8rUH5o76tKJwcmW0f2TAKjP1oH5ZiHjj/JSgE4Wh4Oc29tAAORx9J/s0re3dhfOE1+PuhXetKmKYXIjWrM9SCkfs6viG8M8jVTBnJvliKfqU+AsV9Pw9UqLEkv91KUqOE+L+TDJjqbKIhor8iE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <5f3781d8-2f22-d6ab-dfe8-4a3d721a0459@amd.com> Date: Tue, 4 Jul 2023 12:51:00 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 08/52] xen/arm64: move MMU related code from head.S to mmu/head.S To: Penny Zheng , xen-devel@lists.xenproject.org Cc: Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk References: <20230626033443.2943270-1-Penny.Zheng@arm.com> <20230626033443.2943270-9-Penny.Zheng@arm.com> From: Ayan Kumar Halder In-Reply-To: <20230626033443.2943270-9-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0148.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::9) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|IA0PR12MB7553:EE_ X-MS-Office365-Filtering-Correlation-Id: e3ac331a-b7ff-4426-f9ad-08db7c84f37f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Feic9l5MM7U4MsTiu2rza66mCn+PH0XFbGxMWXvsBli8TT44l9PnpJVV7qam3YaEejwDff6OApo2p7NNgAcjXh7capjFg9y9OQCjHeEikTC8TkHH5G/mxCWHq+aK4XQLsiWsxrVehwXfcCgvJ6ywyUJ3Ml6FaZ2pb4snjARMSBICmULY3z6ZgM6F3jN0zn3e97ykui9bIov5s0jSqKFhf7h2INS6w8u28lCaZtZOHW7SGtp7VtB98fIXf0pHzcKl2aGguiTXiJYToAlyk8PWDYFD1x4r9B/NlFoy9wAqzN43t3XPOKyVYJ9bJhVLtzyAF4ABOQyknFXALYKXz/0/tLn9iR0/i1Ek0dFlIlvNnrRleycFP8rAKRe3lE7f/2I5ZasTNA9mkBqNPMzyXh/Gp8HW1b0eNWxqH1VpcDiZUMyjgnPczDVFXD7pXwExmFG9Ax9SuRwfMqGoEnZ7ssl1U4aWcdB1/Vd361z0lnlQD17mgzbmjMitrsAHDGYwNuM8+aiXaNcSCY+lYggWMZQF4W8x8qStPLXvuBmEg7C+xBH66v7PQFok033DKpzM5GNjL9AX7N1nPaF1NgyGebh3eccEtNBLIbhTORlX2TOd1QIef62LFJSEtTetA/o16S7QNVWJgAADQIpjFXyLntvFsCIrNEyNjQuWG9HWGHYnRUw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(136003)(39860400002)(396003)(366004)(451199021)(26005)(31686004)(478600001)(6666004)(6512007)(6506007)(31696002)(2616005)(186003)(53546011)(38100700002)(54906003)(66476007)(66556008)(4326008)(66946007)(83380400001)(6486002)(316002)(8676002)(8936002)(30864003)(41300700001)(2906002)(5660300002)(36756003)(2004002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?emd0VGQ1UEpnZnZvS0h3TTRjSHdoVkUzYkNJd1NrbGc0L256MVdUaVArZGp6?= =?utf-8?B?aSsyemxEdW1SbzdqUkYzTUQ4SWxCRlNSUVJXdWZpMmZMVEJHby92Vnp4Zzgw?= =?utf-8?B?cndGL3RzWmJkUmNSNU5GZGJxV0V2VnAwcC9UdUJSenhyRktJY21FSWFueDZD?= =?utf-8?B?RDhmaHdzQWFxbm5TNjhzOFV3eGhvTDZOQnIxU3hhYWdQaGU4YU9DUGpvSVc4?= =?utf-8?B?MXI3blVVanU1TkxZZmRLTHNqT3NhUTQ0aHBQdk5FUlVjN2ZpUS9CWFJHZWNY?= =?utf-8?B?NkQ1QVNUaUVzRUIzZXpBOG5IMTdJNy9YVDhxZUkrREFseldpYjFuVDR3bm1n?= =?utf-8?B?VERQMWVaNWp3YkR4am9YbHdzemF3OU1UcFdweGZXU1U4dEt1OTE4MFdsQ0Rj?= =?utf-8?B?eUVwbFo2YzgzdmZRNm44WWxOaWRjSWNWWmRHeE1SSlpRbk1VWnZzK1JKdDB2?= =?utf-8?B?aysvdnZjOTE1LzQxNWt3M1BXUzkwUXJSY3ZSRHVGRVBRanNuREhoeGVRV3Iz?= =?utf-8?B?VUFKcFNqZ2VFUU44dkw5SFhwRkdCSUM2S3ppL0dhVklxYm9CSDBueFNSUUIz?= =?utf-8?B?eDRhMHR0cGo4VEQ2YXRXUnZxVHZrWU5hMzZQRVFtUlRqNzZxMHdQU3VVL203?= =?utf-8?B?NEdLSnZGWFBmSTUwTlNrL3Z6cGNGbzNkWjhWdFNHdE5XcjZLSStYWUM1anRM?= =?utf-8?B?Yk9rUnFabUtwUWY4Vm1BMzZKN0Era1g5eUhkdWxsRU55bGt2ZUNBa0d4dHNX?= =?utf-8?B?OWVObzF3UGM2UXJ1b2pJdy9zS1hVVnE1cERyOThQRGR2V1orZkxoa2RTQlli?= =?utf-8?B?SFkwTVR2SVp1ZHp2Q2ZzbmtxUXNCSitHOEhRSEdXRjhlZlhNZEUzSk9pcUFw?= =?utf-8?B?bnBQQmI0WE1SL0tuSjBMRURoSXlpUGNkL3pqN1plVHRrRVo0Vkc5WDFZOERt?= =?utf-8?B?SW1XR2drdytZR0pNeVNqSFc5K2FrejNWOS9yaG0ycmNadWRRMTI5VXhtZnJS?= =?utf-8?B?TkdybCtUVnc0dXpNdzV0bGhuVldoVG51Vi9TZ2pWbTdnRGQ4SEt0TnpPNXl5?= =?utf-8?B?Zm5ZdWtTNE5pSWZFVjk4NmZsb3JLYUQ5U09tNHg0MnpzcUUxZXdYUk5zbTZT?= =?utf-8?B?SG52WWhnWUhwKzY0MTVoTGN3UXpIdzVRUjFINzFVK0l3bVk2TC9vNWhTUDdZ?= =?utf-8?B?ZGdmU2lOc0w5enhQZFpsNDBGdHJGM0FvNTdiWUs0MzRZNTdYS3EzYUFzMkVT?= =?utf-8?B?SHhQTHA1VWJZK2l1RlhsMko5NzR0UFY4T1BEcFRIMERkUlk2b3ZwazI0YUEy?= =?utf-8?B?cTVxRzExYVhVSUVVcnNLSkpEUENrTGNXYndjM1JjeEx3ZStLWDVuUjNYcHF4?= =?utf-8?B?SGptRS95cTR6c3UyV3pQOEtDWEpialhIa0llNExaK1BEeE1DN3dtZGNkbG9J?= =?utf-8?B?bnd1TElZUHhidUM5TW9VS1R5dXk4Z1BsSmhZNWd6NU5VSVBxZFhSdVJMYVVN?= =?utf-8?B?SEJBNUJwZVJ3bkNVbFQvZklBODhPN3h3QmQycFovN2M0QTlzeGkxMldPQzVM?= =?utf-8?B?QXhaN2tuVWJXbG9QempjRU92ZXZ2MTQ4NnEwVXk0SVRqd2hpN1VzeEhnMndB?= =?utf-8?B?RnF1d1prMmRueVpsTG5tbkJCSXhzY01zWS9HemZCVTVGYWw2MDdQeVZBTWlP?= =?utf-8?B?dnlZUVVsQjd6VXZTMXIxam4zOUpxTkRXaENoSml3SUZGaXlkSVI1aGZDTzVy?= =?utf-8?B?N3RzZkdQQTNMUXRLUnE5c0RVYmc3VTYrcWQ5ZW9tTEFVS3JTOExsVDFPK0R3?= =?utf-8?B?OGhISEtUb3kvNkpUcHhkb1B5NEZpOGY0dkdDZWNQVzI5clI4WFRKWjcxVSta?= =?utf-8?B?U0h2OHRQRGhuQTNCRStkWW11NXVnK1NtWXZSMFBCaUlkRGRTVjB4Vkw4Vmkz?= =?utf-8?B?OXVTenBWR0huRk5tWm96b29HRGRsMmVBQTcvYzM0dGo3VWtDdnUxOTdHbHU5?= =?utf-8?B?U1JyN1hNUlp4YVUrMWtHWit0SjNsWW04QjRGOFozUUFPQS8rR1h2NFZFQ01u?= =?utf-8?B?SUxITkFzZFZiaVRFUW9UZ2FDNXZwdmRkM2RCRFEyUWx2cFVpclh4RmNqdWRP?= =?utf-8?Q?PEENc28cUmBswLBna4FPujItk?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: e3ac331a-b7ff-4426-f9ad-08db7c84f37f X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 11:51:06.8165 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lJ+VqZ2HobmVFL9VH8J4khvLZlTRr62FnGP87Js0N53TAs93seUCOgEbt12CCuXXZ7nKlK10vfheKkocH8sLxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7553 On 26/06/2023 04:33, Penny Zheng wrote: > CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. > > > From: Wei Chen > > There are lots of MMU specific code in head.S. This code will not > be used in MPU systems. If we use #ifdef to gate them, the code > will become messy and hard to maintain. So we move MMU related > code to mmu/head.S, and keep common code still in head.S. We also > add .text.idmap in mmu/head.S to make all code in this new file > are still in identity map page but will be linked after head.S. > > As "fail" in head.S is very simple and this name is too easy to > be conflicted, so duplicate it in mmu/head.S instead of exporting > it. > > And some assembly macros that will be shared by MMU and MPU later, > we move them to macros.h. > > Rename enable_boot_mmu()/enable_runtime_mmu() to a more generic name > enable_boot_mm()/enable_runtime_mm(), in order to make them common interfaces > to be used for both MMU and later MPU system. > > Signed-off-by: Wei Chen > Signed-off-by: Penny Zheng > --- > v1 -> v2: > 1. Move macros to macros.h > 2. Remove the indention modification > 3. Duplicate "fail" instead of exporting it. > --- > v3: > - Rename enable_boot_mmu()/enable_runtime_mmu() to a more generic name > enable_boot_mm()/enable_runtime_mm() > --- > xen/arch/arm/arm64/Makefile | 3 + > xen/arch/arm/arm64/head.S | 469 +----------------------- > xen/arch/arm/arm64/mmu/head.S | 453 +++++++++++++++++++++++ > xen/arch/arm/include/asm/arm64/macros.h | 51 +++ > 4 files changed, 509 insertions(+), 467 deletions(-) > create mode 100644 xen/arch/arm/arm64/mmu/head.S > > diff --git a/xen/arch/arm/arm64/Makefile b/xen/arch/arm/arm64/Makefile > index 54ad55c75c..0c4b177be9 100644 > --- a/xen/arch/arm/arm64/Makefile > +++ b/xen/arch/arm/arm64/Makefile > @@ -8,6 +8,9 @@ obj-y += domctl.o > obj-y += domain.o > obj-y += entry.o > obj-y += head.o > +ifeq ($(CONFIG_HAS_MMU),y) > +obj-y += mmu/head.o > +endif > obj-y += insn.o > obj-$(CONFIG_LIVEPATCH) += livepatch.o > obj-y += mm.o > diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S > index 66347eedcc..e63886b037 100644 > --- a/xen/arch/arm/arm64/head.S > +++ b/xen/arch/arm/arm64/head.S > @@ -28,17 +28,6 @@ > #include > #endif > > -#define PT_PT 0xf7f /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=1 P=1 */ > -#define PT_MEM 0xf7d /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=0 P=1 */ > -#define PT_MEM_L3 0xf7f /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=1 P=1 */ > -#define PT_DEV 0xe71 /* nG=1 AF=1 SH=10 AP=01 NS=1 ATTR=100 T=0 P=1 */ > -#define PT_DEV_L3 0xe73 /* nG=1 AF=1 SH=10 AP=01 NS=1 ATTR=100 T=1 P=1 */ > - > -/* Convenience defines to get slot used by Xen mapping. */ > -#define XEN_ZEROETH_SLOT zeroeth_table_offset(XEN_VIRT_START) > -#define XEN_FIRST_SLOT first_table_offset(XEN_VIRT_START) > -#define XEN_SECOND_SLOT second_table_offset(XEN_VIRT_START) > - > #define __HEAD_FLAG_PAGE_SIZE ((PAGE_SHIFT - 10) / 2) > > #define __HEAD_FLAG_PHYS_BASE 1 > @@ -85,57 +74,6 @@ > * x30 - lr > */ > > -#ifdef CONFIG_EARLY_PRINTK > -/* > - * Macro to print a string to the UART, if there is one. > - * > - * Clobbers x0 - x3 > - */ > -#define PRINT(_s) \ > - mov x3, lr ; \ > - adr x0, 98f ; \ > - bl asm_puts ; \ > - mov lr, x3 ; \ > - RODATA_STR(98, _s) > - > -/* > - * Macro to print the value of register \xb > - * > - * Clobbers x0 - x4 > - */ > -.macro print_reg xb > - mov x0, \xb > - mov x4, lr > - bl putn > - mov lr, x4 > -.endm > - > -#else /* CONFIG_EARLY_PRINTK */ > -#define PRINT(s) > - > -.macro print_reg xb > -.endm > - > -#endif /* !CONFIG_EARLY_PRINTK */ > - > -/* > - * Pseudo-op for PC relative adr , where is > - * within the range +/- 4GB of the PC. > - * > - * @dst: destination register (64 bit wide) > - * @sym: name of the symbol > - */ > -.macro adr_l, dst, sym > - adrp \dst, \sym > - add \dst, \dst, :lo12:\sym > -.endm > - > -/* Load the physical address of a symbol into xb */ > -.macro load_paddr xb, sym > - ldr \xb, =\sym > - add \xb, \xb, x20 > -.endm > - > .section .text.header, "ax", %progbits > /*.aarch64*/ > > @@ -317,7 +255,7 @@ real_start_efi: > > /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */ > ldr lr, =primary_switched > - b enable_boot_mmu > + b enable_boot_mm > > primary_switched: > bl setup_fixmap > @@ -367,7 +305,7 @@ GLOBAL(init_secondary) > > /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */ > ldr lr, =secondary_switched > - b enable_runtime_mmu > + b enable_runtime_mm > > secondary_switched: > #ifdef CONFIG_EARLY_PRINTK > @@ -475,364 +413,6 @@ cpu_init: > ret > ENDPROC(cpu_init) > > -/* > - * Macro to find the slot number at a given page-table level > - * > - * slot: slot computed > - * virt: virtual address > - * lvl: page-table level > - */ > -.macro get_table_slot, slot, virt, lvl > - ubfx \slot, \virt, #XEN_PT_LEVEL_SHIFT(\lvl), #XEN_PT_LPAE_SHIFT > -.endm > - > -/* > - * Macro to create a page table entry in \ptbl to \tbl > - * > - * ptbl: table symbol where the entry will be created > - * tbl: table symbol to point to > - * virt: virtual address > - * lvl: page-table level > - * tmp1: scratch register > - * tmp2: scratch register > - * tmp3: scratch register > - * > - * Preserves \virt > - * Clobbers \tmp1, \tmp2, \tmp3 > - * > - * Also use x20 for the phys offset. > - * > - * Note that all parameters using registers should be distinct. > - */ > -.macro create_table_entry, ptbl, tbl, virt, lvl, tmp1, tmp2, tmp3 > - get_table_slot \tmp1, \virt, \lvl /* \tmp1 := slot in \tlb */ > - > - load_paddr \tmp2, \tbl > - mov \tmp3, #PT_PT /* \tmp3 := right for linear PT */ > - orr \tmp3, \tmp3, \tmp2 /* + \tlb paddr */ > - > - adr_l \tmp2, \ptbl > - > - str \tmp3, [\tmp2, \tmp1, lsl #3] > -.endm > - > -/* > - * Macro to create a mapping entry in \tbl to \phys. Only mapping in 3rd > - * level table (i.e page granularity) is supported. > - * > - * ptbl: table symbol where the entry will be created > - * virt: virtual address > - * phys: physical address (should be page aligned) > - * tmp1: scratch register > - * tmp2: scratch register > - * tmp3: scratch register > - * type: mapping type. If not specified it will be normal memory (PT_MEM_L3) > - * > - * Preserves \virt, \phys > - * Clobbers \tmp1, \tmp2, \tmp3 > - * > - * Note that all parameters using registers should be distinct. > - */ > -.macro create_mapping_entry, ptbl, virt, phys, tmp1, tmp2, tmp3, type=PT_MEM_L3 > - and \tmp3, \phys, #THIRD_MASK /* \tmp3 := PAGE_ALIGNED(phys) */ > - > - get_table_slot \tmp1, \virt, 3 /* \tmp1 := slot in \tlb */ > - > - mov \tmp2, #\type /* \tmp2 := right for section PT */ > - orr \tmp2, \tmp2, \tmp3 /* + PAGE_ALIGNED(phys) */ > - > - adr_l \tmp3, \ptbl > - > - str \tmp2, [\tmp3, \tmp1, lsl #3] > -.endm > - > -/* > - * Rebuild the boot pagetable's first-level entries. The structure > - * is described in mm.c. > - * > - * After the CPU enables paging it will add the fixmap mapping > - * to these page tables, however this may clash with the 1:1 > - * mapping. So each CPU must rebuild the page tables here with > - * the 1:1 in place. > - * > - * Inputs: > - * x19: paddr(start) > - * x20: phys offset > - * > - * Clobbers x0 - x4 > - */ > -create_page_tables: > - /* Prepare the page-tables for mapping Xen */ > - ldr x0, =XEN_VIRT_START > - create_table_entry boot_pgtable, boot_first, x0, 0, x1, x2, x3 > - create_table_entry boot_first, boot_second, x0, 1, x1, x2, x3 > - create_table_entry boot_second, boot_third, x0, 2, x1, x2, x3 > - > - /* Map Xen */ > - adr_l x4, boot_third > - > - lsr x2, x19, #THIRD_SHIFT /* Base address for 4K mapping */ > - lsl x2, x2, #THIRD_SHIFT > - mov x3, #PT_MEM_L3 /* x2 := Section map */ > - orr x2, x2, x3 > - > - /* ... map of vaddr(start) in boot_third */ > - mov x1, xzr > -1: str x2, [x4, x1] /* Map vaddr(start) */ > - add x2, x2, #PAGE_SIZE /* Next page */ > - add x1, x1, #8 /* Next slot */ > - cmp x1, #(XEN_PT_LPAE_ENTRIES<<3) /* 512 entries per page */ > - b.lt 1b > - > - /* > - * If Xen is loaded at exactly XEN_VIRT_START then we don't > - * need an additional 1:1 mapping, the virtual mapping will > - * suffice. > - */ > - ldr x0, =XEN_VIRT_START > - cmp x19, x0 > - bne 1f > - ret > -1: > - /* > - * Setup the 1:1 mapping so we can turn the MMU on. Note that > - * only the first page of Xen will be part of the 1:1 mapping. > - */ > - > - /* > - * Find the zeroeth slot used. If the slot is not > - * XEN_ZEROETH_SLOT, then the 1:1 mapping will use its own set of > - * page-tables from the first level. > - */ > - get_table_slot x0, x19, 0 /* x0 := zeroeth slot */ > - cmp x0, #XEN_ZEROETH_SLOT > - beq 1f > - create_table_entry boot_pgtable, boot_first_id, x19, 0, x0, x1, x2 > - b link_from_first_id > - > -1: > - /* > - * Find the first slot used. If the slot is not XEN_FIRST_SLOT, > - * then the 1:1 mapping will use its own set of page-tables from > - * the second level. > - */ > - get_table_slot x0, x19, 1 /* x0 := first slot */ > - cmp x0, #XEN_FIRST_SLOT > - beq 1f > - create_table_entry boot_first, boot_second_id, x19, 1, x0, x1, x2 > - b link_from_second_id > - > -1: > - /* > - * Find the second slot used. If the slot is XEN_SECOND_SLOT, then the > - * 1:1 mapping will use its own set of page-tables from the > - * third level. For slot XEN_SECOND_SLOT, Xen is not yet able to handle > - * it. > - */ > - get_table_slot x0, x19, 2 /* x0 := second slot */ > - cmp x0, #XEN_SECOND_SLOT > - beq virtphys_clash > - create_table_entry boot_second, boot_third_id, x19, 2, x0, x1, x2 > - b link_from_third_id > - > -link_from_first_id: > - create_table_entry boot_first_id, boot_second_id, x19, 1, x0, x1, x2 > -link_from_second_id: > - create_table_entry boot_second_id, boot_third_id, x19, 2, x0, x1, x2 > -link_from_third_id: > - create_mapping_entry boot_third_id, x19, x19, x0, x1, x2 > - ret > - > -virtphys_clash: > - /* Identity map clashes with boot_third, which we cannot handle yet */ > - PRINT("- Unable to build boot page tables - virt and phys addresses clash. -\r\n") > - b fail > -ENDPROC(create_page_tables) > - > -/* > - * Turn on the Data Cache and the MMU. The function will return on the 1:1 > - * mapping. In other word, the caller is responsible to switch to the runtime > - * mapping. > - * > - * Inputs: > - * x0 : Physical address of the page tables. > - * > - * Clobbers x0 - x4 > - */ > -enable_mmu: > - mov x4, x0 > - PRINT("- Turning on paging -\r\n") > - > - /* > - * The state of the TLBs is unknown before turning on the MMU. > - * Flush them to avoid stale one. > - */ > - tlbi alle2 /* Flush hypervisor TLBs */ > - dsb nsh > - > - /* Write Xen's PT's paddr into TTBR0_EL2 */ > - msr TTBR0_EL2, x4 > - isb > - > - mrs x0, SCTLR_EL2 > - orr x0, x0, #SCTLR_Axx_ELx_M /* Enable MMU */ > - orr x0, x0, #SCTLR_Axx_ELx_C /* Enable D-cache */ > - dsb sy /* Flush PTE writes and finish reads */ > - msr SCTLR_EL2, x0 /* now paging is enabled */ > - isb /* Now, flush the icache */ > - ret > -ENDPROC(enable_mmu) > - > -/* > - * Turn on the Data Cache and the MMU. The function will return > - * to the virtual address provided in LR (e.g. the runtime mapping). > - * > - * Inputs: > - * lr : Virtual address to return to. > - * > - * Clobbers x0 - x5 > - */ > -enable_runtime_mmu: > - mov x5, lr > - > - load_paddr x0, init_ttbr > - ldr x0, [x0] > - > - bl enable_mmu > - mov lr, x5 > - > - /* return to secondary_switched */ > - ret > -ENDPROC(enable_runtime_mmu) > - > -/* > - * Turn on the Data Cache and the MMU. The function will return > - * to the virtual address provided in LR (e.g. the runtime mapping). > - * > - * Inputs: > - * lr : Virtual address to return to. > - * > - * Clobbers x0 - x5 > - */ > -enable_boot_mmu: > - mov x5, lr > - > - bl create_page_tables > - load_paddr x0, boot_pgtable > - > - bl enable_mmu > - mov lr, x5 > - > - /* > - * The MMU is turned on and we are in the 1:1 mapping. Switch > - * to the runtime mapping. > - */ > - ldr x0, =1f > - br x0 > -1: > - /* > - * The 1:1 map may clash with other parts of the Xen virtual memory > - * layout. As it is not used anymore, remove it completely to > - * avoid having to worry about replacing existing mapping > - * afterwards. Function will return to primary_switched. > - */ > - b remove_identity_mapping > - > - /* > - * Here might not be reached, as "ret" in remove_identity_mapping > - * will use the return address in LR in advance. But keep ret here > - * might be more safe if "ret" in remove_identity_mapping is removed > - * in future. > - */ > - ret > -ENDPROC(enable_boot_mmu) > - > -/* > - * Remove the 1:1 map from the page-tables. It is not easy to keep track > - * where the 1:1 map was mapped, so we will look for the top-level entry > - * exclusive to the 1:1 map and remove it. > - * > - * Inputs: > - * x19: paddr(start) > - * > - * Clobbers x0 - x1 > - */ > -remove_identity_mapping: > - /* > - * Find the zeroeth slot used. Remove the entry from zeroeth > - * table if the slot is not XEN_ZEROETH_SLOT. > - */ > - get_table_slot x1, x19, 0 /* x1 := zeroeth slot */ > - cmp x1, #XEN_ZEROETH_SLOT > - beq 1f > - /* It is not in slot XEN_ZEROETH_SLOT, remove the entry. */ > - ldr x0, =boot_pgtable /* x0 := root table */ > - str xzr, [x0, x1, lsl #3] > - b identity_mapping_removed > - > -1: > - /* > - * Find the first slot used. Remove the entry for the first > - * table if the slot is not XEN_FIRST_SLOT. > - */ > - get_table_slot x1, x19, 1 /* x1 := first slot */ > - cmp x1, #XEN_FIRST_SLOT > - beq 1f > - /* It is not in slot XEN_FIRST_SLOT, remove the entry. */ > - ldr x0, =boot_first /* x0 := first table */ > - str xzr, [x0, x1, lsl #3] > - b identity_mapping_removed > - > -1: > - /* > - * Find the second slot used. Remove the entry for the first > - * table if the slot is not XEN_SECOND_SLOT. > - */ > - get_table_slot x1, x19, 2 /* x1 := second slot */ > - cmp x1, #XEN_SECOND_SLOT > - beq identity_mapping_removed > - /* It is not in slot 1, remove the entry */ > - ldr x0, =boot_second /* x0 := second table */ > - str xzr, [x0, x1, lsl #3] > - > -identity_mapping_removed: > - /* See asm/arm64/flushtlb.h for the explanation of the sequence. */ > - dsb nshst > - tlbi alle2 > - dsb nsh > - isb > - > - ret > -ENDPROC(remove_identity_mapping) > - > -/* > - * Map the UART in the fixmap (when earlyprintk is used) and hook the > - * fixmap table in the page tables. > - * > - * The fixmap cannot be mapped in create_page_tables because it may > - * clash with the 1:1 mapping. > - * > - * Inputs: > - * x20: Physical offset > - * x23: Early UART base physical address > - * > - * Clobbers x0 - x3 > - */ > -setup_fixmap: > -#ifdef CONFIG_EARLY_PRINTK > - /* Add UART to the fixmap table */ > - ldr x0, =EARLY_UART_VIRTUAL_ADDRESS > - create_mapping_entry xen_fixmap, x0, x23, x1, x2, x3, type=PT_DEV_L3 > -#endif > - /* Map fixmap into boot_second */ > - ldr x0, =FIXMAP_ADDR(0) > - create_table_entry boot_second, xen_fixmap, x0, 2, x1, x2, x3 > - /* Ensure any page table updates made above have occurred. */ > - dsb nshst > - > - ret > -ENDPROC(setup_fixmap) > - > /* > * Setup the initial stack and jump to the C world > * > @@ -861,51 +441,6 @@ fail: PRINT("- Boot failed -\r\n") > b 1b > ENDPROC(fail) > > -/* > - * Switch TTBR > - * > - * x0 ttbr > - */ > -ENTRY(switch_ttbr_id) > - /* 1) Ensure any previous read/write have completed */ > - dsb ish > - isb > - > - /* 2) Turn off MMU */ > - mrs x1, SCTLR_EL2 > - bic x1, x1, #SCTLR_Axx_ELx_M > - msr SCTLR_EL2, x1 > - isb > - > - /* > - * 3) Flush the TLBs. > - * See asm/arm64/flushtlb.h for the explanation of the sequence. > - */ > - dsb nshst > - tlbi alle2 > - dsb nsh > - isb > - > - /* 4) Update the TTBR */ > - msr TTBR0_EL2, x0 > - isb > - > - /* > - * 5) Flush I-cache > - * This should not be necessary but it is kept for safety. > - */ > - ic iallu > - isb > - > - /* 6) Turn on the MMU */ > - mrs x1, SCTLR_EL2 > - orr x1, x1, #SCTLR_Axx_ELx_M /* Enable MMU */ > - msr SCTLR_EL2, x1 > - isb > - > - ret > -ENDPROC(switch_ttbr_id) > - > #ifdef CONFIG_EARLY_PRINTK > /* > * Initialize the UART. Should only be called on the boot CPU. > diff --git a/xen/arch/arm/arm64/mmu/head.S b/xen/arch/arm/arm64/mmu/head.S > new file mode 100644 > index 0000000000..2b209fc3ce > --- /dev/null > +++ b/xen/arch/arm/arm64/mmu/head.S > @@ -0,0 +1,453 @@ > +/* > + * xen/arch/arm/mmu/head.S > + * > + * Start-of-day code for an ARMv8. > + * > + * Ian Campbell > + * Copyright (c) 2012 Citrix Systems. > + * > + * Based on ARMv7-A head.S by > + * Tim Deegan > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ > + > +#include > +#include > + > +#define PT_PT 0xf7f /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=1 P=1 */ > +#define PT_MEM 0xf7d /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=0 P=1 */ > +#define PT_MEM_L3 0xf7f /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=1 P=1 */ > +#define PT_DEV 0xe71 /* nG=1 AF=1 SH=10 AP=01 NS=1 ATTR=100 T=0 P=1 */ > +#define PT_DEV_L3 0xe73 /* nG=1 AF=1 SH=10 AP=01 NS=1 ATTR=100 T=1 P=1 */ > + > +/* Convenience defines to get slot used by Xen mapping. */ > +#define XEN_ZEROETH_SLOT zeroeth_table_offset(XEN_VIRT_START) > +#define XEN_FIRST_SLOT first_table_offset(XEN_VIRT_START) > +#define XEN_SECOND_SLOT second_table_offset(XEN_VIRT_START) > + > +/* > + * Macro to find the slot number at a given page-table level > + * > + * slot: slot computed > + * virt: virtual address > + * lvl: page-table level > + */ > +.macro get_table_slot, slot, virt, lvl > + ubfx \slot, \virt, #XEN_PT_LEVEL_SHIFT(\lvl), #XEN_PT_LPAE_SHIFT > +.endm > + > +/* > + * Macro to create a page table entry in \ptbl to \tbl > + * > + * ptbl: table symbol where the entry will be created > + * tbl: table symbol to point to > + * virt: virtual address > + * lvl: page-table level > + * tmp1: scratch register > + * tmp2: scratch register > + * tmp3: scratch register > + * > + * Preserves \virt > + * Clobbers \tmp1, \tmp2, \tmp3 > + * > + * Also use x20 for the phys offset. > + * > + * Note that all parameters using registers should be distinct. > + */ > +.macro create_table_entry, ptbl, tbl, virt, lvl, tmp1, tmp2, tmp3 > + get_table_slot \tmp1, \virt, \lvl /* \tmp1 := slot in \tlb */ > + > + load_paddr \tmp2, \tbl > + mov \tmp3, #PT_PT /* \tmp3 := right for linear PT */ > + orr \tmp3, \tmp3, \tmp2 /* + \tlb paddr */ > + > + adr_l \tmp2, \ptbl > + > + str \tmp3, [\tmp2, \tmp1, lsl #3] > +.endm > + > +/* > + * Macro to create a mapping entry in \tbl to \phys. Only mapping in 3rd > + * level table (i.e page granularity) is supported. > + * > + * ptbl: table symbol where the entry will be created > + * virt: virtual address > + * phys: physical address (should be page aligned) > + * tmp1: scratch register > + * tmp2: scratch register > + * tmp3: scratch register > + * type: mapping type. If not specified it will be normal memory (PT_MEM_L3) > + * > + * Preserves \virt, \phys > + * Clobbers \tmp1, \tmp2, \tmp3 > + * > + * Note that all parameters using registers should be distinct. > + */ > +.macro create_mapping_entry, ptbl, virt, phys, tmp1, tmp2, tmp3, type=PT_MEM_L3 > + and \tmp3, \phys, #THIRD_MASK /* \tmp3 := PAGE_ALIGNED(phys) */ > + > + get_table_slot \tmp1, \virt, 3 /* \tmp1 := slot in \tlb */ > + > + mov \tmp2, #\type /* \tmp2 := right for section PT */ > + orr \tmp2, \tmp2, \tmp3 /* + PAGE_ALIGNED(phys) */ > + > + adr_l \tmp3, \ptbl > + > + str \tmp2, [\tmp3, \tmp1, lsl #3] > +.endm > + > +.section .text.idmap, "ax", %progbits > + > +/* > + * Rebuild the boot pagetable's first-level entries. The structure > + * is described in mm.c. > + * > + * After the CPU enables paging it will add the fixmap mapping > + * to these page tables, however this may clash with the 1:1 > + * mapping. So each CPU must rebuild the page tables here with > + * the 1:1 in place. > + * > + * Inputs: > + * x19: paddr(start) > + * x20: phys offset > + * > + * Clobbers x0 - x4 > + */ > +create_page_tables: > + /* Prepare the page-tables for mapping Xen */ > + ldr x0, =XEN_VIRT_START > + create_table_entry boot_pgtable, boot_first, x0, 0, x1, x2, x3 > + create_table_entry boot_first, boot_second, x0, 1, x1, x2, x3 > + create_table_entry boot_second, boot_third, x0, 2, x1, x2, x3 > + > + /* Map Xen */ > + adr_l x4, boot_third > + > + lsr x2, x19, #THIRD_SHIFT /* Base address for 4K mapping */ > + lsl x2, x2, #THIRD_SHIFT > + mov x3, #PT_MEM_L3 /* x2 := Section map */ > + orr x2, x2, x3 > + > + /* ... map of vaddr(start) in boot_third */ > + mov x1, xzr > +1: str x2, [x4, x1] /* Map vaddr(start) */ > + add x2, x2, #PAGE_SIZE /* Next page */ > + add x1, x1, #8 /* Next slot */ > + cmp x1, #(XEN_PT_LPAE_ENTRIES<<3) /* 512 entries per page */ > + b.lt 1b > + > + /* > + * If Xen is loaded at exactly XEN_VIRT_START then we don't > + * need an additional 1:1 mapping, the virtual mapping will > + * suffice. > + */ > + ldr x0, =XEN_VIRT_START > + cmp x19, x0 > + bne 1f > + ret > +1: > + /* > + * Setup the 1:1 mapping so we can turn the MMU on. Note that > + * only the first page of Xen will be part of the 1:1 mapping. > + */ > + > + /* > + * Find the zeroeth slot used. If the slot is not > + * XEN_ZEROETH_SLOT, then the 1:1 mapping will use its own set of > + * page-tables from the first level. > + */ > + get_table_slot x0, x19, 0 /* x0 := zeroeth slot */ > + cmp x0, #XEN_ZEROETH_SLOT > + beq 1f > + create_table_entry boot_pgtable, boot_first_id, x19, 0, x0, x1, x2 > + b link_from_first_id > + > +1: > + /* > + * Find the first slot used. If the slot is not XEN_FIRST_SLOT, > + * then the 1:1 mapping will use its own set of page-tables from > + * the second level. > + */ > + get_table_slot x0, x19, 1 /* x0 := first slot */ > + cmp x0, #XEN_FIRST_SLOT > + beq 1f > + create_table_entry boot_first, boot_second_id, x19, 1, x0, x1, x2 > + b link_from_second_id > + > +1: > + /* > + * Find the second slot used. If the slot is XEN_SECOND_SLOT, then the > + * 1:1 mapping will use its own set of page-tables from the > + * third level. For slot XEN_SECOND_SLOT, Xen is not yet able to handle > + * it. > + */ > + get_table_slot x0, x19, 2 /* x0 := second slot */ > + cmp x0, #XEN_SECOND_SLOT > + beq virtphys_clash > + create_table_entry boot_second, boot_third_id, x19, 2, x0, x1, x2 > + b link_from_third_id > + > +link_from_first_id: > + create_table_entry boot_first_id, boot_second_id, x19, 1, x0, x1, x2 > +link_from_second_id: > + create_table_entry boot_second_id, boot_third_id, x19, 2, x0, x1, x2 > +link_from_third_id: > + create_mapping_entry boot_third_id, x19, x19, x0, x1, x2 > + ret > + > +virtphys_clash: > + /* Identity map clashes with boot_third, which we cannot handle yet */ > + PRINT("- Unable to build boot page tables - virt and phys addresses clash. -\r\n") > + b fail > +ENDPROC(create_page_tables) > + > +/* > + * Turn on the Data Cache and the MMU. The function will return on the 1:1 > + * mapping. In other word, the caller is responsible to switch to the runtime > + * mapping. > + * > + * Inputs: > + * x0 : Physical address of the page tables. > + * > + * Clobbers x0 - x4 > + */ > +enable_mmu: > + mov x4, x0 > + PRINT("- Turning on paging -\r\n") > + > + /* > + * The state of the TLBs is unknown before turning on the MMU. > + * Flush them to avoid stale one. > + */ > + tlbi alle2 /* Flush hypervisor TLBs */ > + dsb nsh > + > + /* Write Xen's PT's paddr into TTBR0_EL2 */ > + msr TTBR0_EL2, x4 > + isb > + > + mrs x0, SCTLR_EL2 > + orr x0, x0, #SCTLR_Axx_ELx_M /* Enable MMU */ > + orr x0, x0, #SCTLR_Axx_ELx_C /* Enable D-cache */ > + dsb sy /* Flush PTE writes and finish reads */ > + msr SCTLR_EL2, x0 /* now paging is enabled */ > + isb /* Now, flush the icache */ > + ret > +ENDPROC(enable_mmu) > + > +/* > + * Turn on the Data Cache and the MMU. The function will return > + * to the virtual address provided in LR (e.g. the runtime mapping). > + * > + * Inputs: > + * lr : Virtual address to return to. > + * > + * Clobbers x0 - x5 > + */ > +ENTRY(enable_runtime_mm) > + /* save return address */ > + mov x5, lr > + > + load_paddr x0, init_ttbr > + ldr x0, [x0] A newline here as was present in the original code. > + bl enable_mmu > + mov lr, x5 > + > + /* return to secondary_switched */ > + ret > +ENDPROC(enable_runtime_mm) > + > +/* > + * Turn on the Data Cache and the MMU. The function will return > + * to the virtual address provided in LR (e.g. the runtime mapping). > + * > + * Inputs: > + * lr : Virtual address to return to. > + * > + * Clobbers x0 - x5 > + */ > +ENTRY(enable_boot_mm) > + /* save return address */ > + mov x5, lr > + > + bl create_page_tables > + load_paddr x0, boot_pgtable A newline here as was present in the original code. > + bl enable_mmu > + mov lr, x5 > + > + /* > + * The MMU is turned on and we are in the 1:1 mapping. Switch > + * to the runtime mapping. > + */ > + ldr x0, =1f > + br x0 > +1: > + /* > + * The 1:1 map may clash with other parts of the Xen virtual memory > + * layout. As it is not used anymore, remove it completely to > + * avoid having to worry about replacing existing mapping > + * afterwards. Function will return to primary_switched. > + */ > + b remove_identity_mapping > + > + /* > + * Here might not be reached, as "ret" in remove_identity_mapping > + * will use the return address in LR in advance. But keep ret here > + * might be more safe if "ret" in remove_identity_mapping is removed > + * in future. > + */ > + ret > +ENDPROC(enable_boot_mm) > + > +/* > + * Remove the 1:1 map from the page-tables. It is not easy to keep track > + * where the 1:1 map was mapped, so we will look for the top-level entry > + * exclusive to the 1:1 map and remove it. > + * > + * Inputs: > + * x19: paddr(start) > + * > + * Clobbers x0 - x1 > + */ > +remove_identity_mapping: > + /* > + * Find the zeroeth slot used. Remove the entry from zeroeth > + * table if the slot is not XEN_ZEROETH_SLOT. > + */ > + get_table_slot x1, x19, 0 /* x1 := zeroeth slot */ > + cmp x1, #XEN_ZEROETH_SLOT > + beq 1f > + /* It is not in slot XEN_ZEROETH_SLOT, remove the entry. */ > + ldr x0, =boot_pgtable /* x0 := root table */ > + str xzr, [x0, x1, lsl #3] > + b identity_mapping_removed > + > +1: > + /* > + * Find the first slot used. Remove the entry for the first > + * table if the slot is not XEN_FIRST_SLOT. > + */ > + get_table_slot x1, x19, 1 /* x1 := first slot */ > + cmp x1, #XEN_FIRST_SLOT > + beq 1f > + /* It is not in slot XEN_FIRST_SLOT, remove the entry. */ > + ldr x0, =boot_first /* x0 := first table */ > + str xzr, [x0, x1, lsl #3] > + b identity_mapping_removed > + > +1: > + /* > + * Find the second slot used. Remove the entry for the first > + * table if the slot is not XEN_SECOND_SLOT. > + */ > + get_table_slot x1, x19, 2 /* x1 := second slot */ > + cmp x1, #XEN_SECOND_SLOT > + beq identity_mapping_removed > + /* It is not in slot 1, remove the entry */ > + ldr x0, =boot_second /* x0 := second table */ > + str xzr, [x0, x1, lsl #3] > + > +identity_mapping_removed: > + /* See asm/arm64/flushtlb.h for the explanation of the sequence. */ > + dsb nshst > + tlbi alle2 > + dsb nsh > + isb > + > + ret > +ENDPROC(remove_identity_mapping) > + > +/* > + * Map the UART in the fixmap (when earlyprintk is used) and hook the > + * fixmap table in the page tables. > + * > + * The fixmap cannot be mapped in create_page_tables because it may > + * clash with the 1:1 mapping. > + * > + * Inputs: > + * x20: Physical offset > + * x23: Early UART base physical address > + * > + * Clobbers x0 - x3 > + */ > +ENTRY(setup_fixmap) > +#ifdef CONFIG_EARLY_PRINTK > + /* Add UART to the fixmap table */ > + ldr x0, =EARLY_UART_VIRTUAL_ADDRESS > + create_mapping_entry xen_fixmap, x0, x23, x1, x2, x3, type=PT_DEV_L3 > +#endif > + /* Map fixmap into boot_second */ > + ldr x0, =FIXMAP_ADDR(0) > + create_table_entry boot_second, xen_fixmap, x0, 2, x1, x2, x3 > + /* Ensure any page table updates made above have occurred. */ > + dsb nshst > + > + ret > +ENDPROC(setup_fixmap) > + Why do we need the below snippet ? It wasn't a part of the original code. > +/* Fail-stop */ > +fail: PRINT("- Boot failed -\r\n") > +1: wfe > + b 1b > +ENDPROC(fail) > + > +/* > + * Switch TTBR > + * > + * x0 ttbr > + */ > +ENTRY(switch_ttbr_id) > + /* 1) Ensure any previous read/write have completed */ > + dsb ish > + isb > + > + /* 2) Turn off MMU */ > + mrs x1, SCTLR_EL2 > + bic x1, x1, #SCTLR_Axx_ELx_M > + msr SCTLR_EL2, x1 > + isb > + > + /* > + * 3) Flush the TLBs. > + * See asm/arm64/flushtlb.h for the explanation of the sequence. > + */ > + dsb nshst > + tlbi alle2 > + dsb nsh > + isb > + > + /* 4) Update the TTBR */ > + msr TTBR0_EL2, x0 > + isb > + > + /* > + * 5) Flush I-cache > + * This should not be necessary but it is kept for safety. > + */ > + ic iallu > + isb > + > + /* 6) Turn on the MMU */ > + mrs x1, SCTLR_EL2 > + orr x1, x1, #SCTLR_Axx_ELx_M /* Enable MMU */ > + msr SCTLR_EL2, x1 > + isb > + > + ret > +ENDPROC(switch_ttbr_id) > + > +/* > + * Local variables: > + * mode: ASM > + * indent-tabs-mode: nil > + * End: > + */ > diff --git a/xen/arch/arm/include/asm/arm64/macros.h b/xen/arch/arm/include/asm/arm64/macros.h > index 140e223b4c..2116e48b7c 100644 > --- a/xen/arch/arm/include/asm/arm64/macros.h > +++ b/xen/arch/arm/include/asm/arm64/macros.h > @@ -32,6 +32,57 @@ > hint #22 > .endm > > +#ifdef CONFIG_EARLY_PRINTK > +/* > + * Macro to print a string to the UART, if there is one. > + * > + * Clobbers x0 - x3 > + */ > +#define PRINT(_s) \ > + mov x3, lr ; \ > + adr x0, 98f ; \ > + bl asm_puts ; \ > + mov lr, x3 ; \ > + RODATA_STR(98, _s) > + > +/* > + * Macro to print the value of register \xb > + * > + * Clobbers x0 - x4 > + */ > +.macro print_reg xb > + mov x0, \xb > + mov x4, lr > + bl putn > + mov lr, x4 > +.endm > + > +#else /* CONFIG_EARLY_PRINTK */ > +#define PRINT(s) > + > +.macro print_reg xb > +.endm > + > +#endif /* !CONFIG_EARLY_PRINTK */ > + > +/* > + * Pseudo-op for PC relative adr , where is > + * within the range +/- 4GB of the PC. > + * > + * @dst: destination register (64 bit wide) > + * @sym: name of the symbol > + */ > +.macro adr_l, dst, sym > + adrp \dst, \sym > + add \dst, \dst, :lo12:\sym > +.endm > + > +/* Load the physical address of a symbol into xb */ > +.macro load_paddr xb, sym > + ldr \xb, =\sym > + add \xb, \xb, x20 > +.endm > + > /* > * Register aliases. > */ > -- > 2.25.1 > > - Ayan From xen-devel-bounces@lists.xenproject.org Tue Jul 04 12:02:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 12:02:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558295.872243 (Exim 4.92) (envelope-from ) id 1qGejc-0001Iw-Fm; Tue, 04 Jul 2023 12:02:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558295.872243; Tue, 04 Jul 2023 12:02:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGejc-0001Ip-DE; Tue, 04 Jul 2023 12:02:20 +0000 Received: by outflank-mailman (input) for mailman id 558295; Tue, 04 Jul 2023 12:02:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGejb-0001Ij-Iy for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 12:02:19 +0000 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on20625.outbound.protection.outlook.com [2a01:111:f400:7ea9::625]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9e5d9f8f-1a62-11ee-8611-37d641c3527e; Tue, 04 Jul 2023 14:02:17 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by CH0PR12MB5387.namprd12.prod.outlook.com (2603:10b6:610:d6::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 12:02:13 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::8018:78f7:1b08:7a54]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::8018:78f7:1b08:7a54%2]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 12:02:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9e5d9f8f-1a62-11ee-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cGapxe+CO/Kfftf7VWxL3CdTSEndXG9G5UA1KYinWRzecHX4AjKumsVXKflgMFyc6ftRGl80Uivz6H4LeEtDbWasICcINPD3Y2iFNeDyCLmf3gG7xqFtxNfG35budMUdiWADaxJ2QkJ1J5spclPcm9P+xeeXtFn5fA+VevDM4EPmsC2EKksjiRzcgakv/R7s+d8rcqjGIuSilZAKhtBP3VjiUshMr1KEIaeoOrLG9JGJGQhnbjBXh5iZiu6ZZGyq9nY8otjIcE8ZNWU0DcbXqi+mPL7mLLYOTyTY3JXVKsVyM/vhtKO6OmBgVXANRa0CNaMELAJuWhFtEP3L4kB/2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jt+agSvOonh8mMnbln3QX+xOm8kA9R3IxbLKvceeA7M=; b=jAkGT+Trfgjn9OLbDk/5/tze/3YjILYDi8GU2WB/ExvlJCBINeAA7xgZUrFfyvR3nvGmgXPKJRq4D14gvZWdSoQok/57Jb1e04FdBzLG9inrR3jndavyWTal4OO89Pn4cl4TGtrumdtn5+KI3J+uaEUixe6iLgiY1qcVaZogNOBcA0obTUZ7cGzG4UEucASquYKZ8VhFoT5Y+9aISp1yH5YZicCIaqmWE7647zfMOTMLXbdP6EDay20vZ3jAxtnECNt8U4mzV5HDFX6o4LZMSpaxbOD39wUqZcur7gC4A+7a1d6xFKXtl8afII+SwwVEGQ0uem3i9LmR4Y9OAB7Aww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jt+agSvOonh8mMnbln3QX+xOm8kA9R3IxbLKvceeA7M=; b=k7BQp/Da4GGXcq5/3KlQsG3AU2uV3FPY/JScOVXkYhrTZpNfOpwYtQ/9JgqTynncnphYA1AWL8mOluFZt4ZPVpXE4MVxD1A/VDGlgEUbK7qYTDfYSB8Su9r5FUb8zvwEMtP4rYCLZjp39MkI0v+Hd593De+0u9jI4/arZkQVhuE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <682fdfab-b755-e580-7688-3dc0c0e3779e@amd.com> Date: Tue, 4 Jul 2023 13:02:08 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 03/52] xen/arm: add an option to define Xen start address for Armv8-R To: Julien Grall , Penny Zheng , xen-devel@lists.xenproject.org Cc: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230626033443.2943270-1-Penny.Zheng@arm.com> <20230626033443.2943270-4-Penny.Zheng@arm.com> <77c64929-514a-ea67-cf8b-176c895ff971@xen.org> From: Ayan Kumar Halder In-Reply-To: <77c64929-514a-ea67-cf8b-176c895ff971@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0485.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::10) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|CH0PR12MB5387:EE_ X-MS-Office365-Filtering-Correlation-Id: 4ca65eec-d225-4998-0420-08db7c8680bf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ms4YYq8DdLb63WUx7brLgGWpQ224KPpmz7XyWADpAO0B+Q7VRkmcB8eHUI+hTaUiCVS4eVm019NAigPZwhyBjQXAAstdFMD9LDnrV8YFBWDjmCoAQWlf3GjXzfkVS7vIBkiqvP9endfdJz9bUuKxr9DsQAyGRGW1t0JadSht9Eg/OJT3wV3VlS5BCA09oBPj+X0i+Z1YQiDl98KARX1u1xUAdsgEFtCStRBprSxarQGa2DEAJeXyRGH3q4Q4jEWgAcUNEvLTrPcWw2kTksgPEwsRPvOpuZqALYd0oEU3QXXYCN15w64gxaRj5UKY6bmsB9gFn+KGy3Rge0kY7iT5m8kDu1Y8+5Cu1AYG4W1PIzfly0ZivzMIrw2R0bXCkHY46Tmi3pm/LL6JH3LY36HsT0a/uWv+byFu6ssYBvYrIQvyhddJGeAKHT8I0DyO+HqfGQsImT/zjpCwTHd2RLHXKFEvXemUzjlLHfixjysrLwrhX3lt7t/SievoCkndDLb76pVt1i+l2TDWdpiPGH97ITuI6RRlqRixo76yysFC3xFzSY1Sh9eXtfZokxmMT4G4JBftpRNynLKQpP4ST3yQQ0vM+14jXBTmosbsJdoa+Vu4kgyGD2uO/IYUx5iwe2a+xqV1cap/9ocm72M4K3jOWnVOPu9pRG5Bujm1UsmFmN4sdkLBH6XVCv90LeK8Q10R X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(136003)(346002)(376002)(39860400002)(396003)(451199021)(6506007)(6512007)(53546011)(66476007)(316002)(66556008)(38100700002)(66946007)(4326008)(2616005)(83380400001)(186003)(26005)(478600001)(54906003)(110136005)(2906002)(31686004)(8676002)(8936002)(36756003)(31696002)(5660300002)(6486002)(966005)(41300700001)(6666004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWJxMTZLU2RXMmRoWHFBY3dGOGZTdjlMV2E1cDVadDlSWWN4MXQ4MHJsL0ZY?= =?utf-8?B?d1FGZTZrQ3VHd3ZwcG41QVBPNVRJWWdDamVjUjkxL2lhTWJqU3ozWG55bVVK?= =?utf-8?B?eU9mTHVjVFNwV3ZPdlVqN2JlNGc0UEJXZFVHRTZLbXJXVU9FQ2g1czJkTHo5?= =?utf-8?B?WnNuRnhXK2h5SkJLbmZQV1U3MzJDcExnWWdDeDdFWUREdElGN2w5MG1XNGcv?= =?utf-8?B?T20rY0ZOaFNueWYvbWkxZmR5c0hxaDNDdDJZZUZPYldaWnF3VldTRjRQLy9u?= =?utf-8?B?WUcwNTJRbFFCRkNEYXFmNHRud2xtNFZsL2FOajU0R2wycEtZcHc2R2w1bkxH?= =?utf-8?B?c3o5NDlSYXN4ZnYrT2cyYUhBWk1LcllCbk8wakdRZEdJeEhxVTZVQlRNUjhs?= =?utf-8?B?Z0paSkV2a1lmQUdWUWVUWkF6bCtwQ3RNa2psWmZPam5TZWVpL3Jxbjl2bzFH?= =?utf-8?B?YkVFZ2luUEtRM3AzcFc4MGc2Q0VFdisxaEtmYThsWGliQnMwMVc0M3hsSUw1?= =?utf-8?B?L1pTc0RnbmkrRERTK2pLbk4rRVhteWFKYkppaEFtWCtDRkU5SExuRzNnMHBE?= =?utf-8?B?T2g2eFpvZGcxdEdDRVE2bzR1Y1g4Rks2NENvU3VJZ3lJVWJueCtLTnJRbkJS?= =?utf-8?B?UFcxNGphVnBHeDhYYlY1czF3K09uekwxVlVGUDNnS2JJVkhxNVZ5NHhzNG92?= =?utf-8?B?NDhpL2lYak5ZbVNXRTFwYnZSTENXNVJwTit5UndmVFphZDdLSnNoTzY5L1Z4?= =?utf-8?B?N1ZNUElyWVdtVWRuaHlvUW8waHlDTXhkSFpwdGlSVE1nZGR4MEh4eDB0bE1t?= =?utf-8?B?Y0RRanZIbUx5V3lSeXIyTFMyNnRlZHZFK2x3aE5sNWZlTGlmckFoOW95TTM1?= =?utf-8?B?eldXNDk0bmRkamU5SDJoTTYydUFoVEFrRkdDK2d1OS8zTW5sRWMwanZSekVy?= =?utf-8?B?Z01tem1DL0ErOEVEOUhnZWVqMnJ4Q2NzQnoxUUgzM05BblYwQUZEam5uTEVQ?= =?utf-8?B?NWhYUVNSSVQxQjAyMkFhM1NDRW1TQVBsY1B1RU1oWnBndXNaa1RwNnpVUGJj?= =?utf-8?B?dEZBNVJPKzBueml6S1MvcmVxa1lwQTBXelNFVnBFQktCQnU2V2p0QllDMTVC?= =?utf-8?B?NTJOaVdnY0FhMjRvSE1hZXAzQVhmWUxMYXk0N0hnWGNpQUMvT0hIQ0lRSHRL?= =?utf-8?B?U2tVNVFQUVVmRWpvMm1yK0xndkdTckFFTU9VZjVtOXNidkk5eTZoeEs0TzZk?= =?utf-8?B?T1pyVG1ud1hINHM4NC8vdzliWjRGTjhnVFNvSklhZllCTU9MOGVLV0pNQVBa?= =?utf-8?B?Z1BmaTBhTlNKQnFJdFJ3QjBaZDJubzVweU5ScCtwSWJmYk9henVwQ2lCWlM4?= =?utf-8?B?MlF1eCttc1JQMXA0eGx5MGNENGFKSUNoaWlZQ2xQdjI3VnJUQTJTQW54L2dn?= =?utf-8?B?aU9iRHdvTUtmQkw5VWM1d2UwelJzMmJzL2JyZ1A3SG5xRnhJMmpCNTAwM3Nj?= =?utf-8?B?NXhFaXRGczJVQ1hoaXZnYW5FVVZrVlhwbk5VaXY2L3JVSUwwRjVueGkwRFJl?= =?utf-8?B?MEJSM0xGYTRsRjRSdit6NUV1NFVoQWtqcWZIeWJTdG53bk1HZlVuMHJWUGl6?= =?utf-8?B?alNvVlZWT2J1OUNVd1ZhM2M5RHdzZW92Z1BPMFdTcXMzd3lpMHpURi9zbXJ3?= =?utf-8?B?NWVITmpDR1lnaXlCb2grZ2RNNllmdnk2c0kyZk9OaDZrQmIvb2wyUlAvbUdx?= =?utf-8?B?VWx3Uk9ZMHNuYzBTbk5XWjlhS25YWHZiZXJnVk9GdnBSYlZ5QWpHcTRQN2Qv?= =?utf-8?B?SkI5ZnJsdHoyM21Kdk9pTlJqOU5IUURxSCthRlVwelc1K1JxdU5uZW15T3VK?= =?utf-8?B?S2FOVHdJc1JzaFBWSDI3VDZtZWtiSkJNQzhUOTk4V1AwQVh6VWVTcVdUdi9h?= =?utf-8?B?NTMrZHZkWCtHTTc2ZWRsRGhjbHdCYjJrdmpleUhJa0c1RWVlMVB6blVkaGFM?= =?utf-8?B?Sm1mME5Ba0ZxNjB4RklUUUFsc1NJQlpKaXNNbm4rMWd6SFJ0enRtdFpaNXVZ?= =?utf-8?B?TTZlQlJuUmkzUUxRaVEwV2g3eWhSLzlTU3hjYjRpSlRvQTRTaU14VjgvR0wr?= =?utf-8?Q?2MDHa8VOmqbcUSTOTt/j+iDkF?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ca65eec-d225-4998-0420-08db7c8680bf X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 12:02:13.2517 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: en5PWDRw2Jp1xouxjhetM12t511DZkSj5ZH+dZd+zMBHn4vCeqI3wa8Nq92MmY5KZ7wSaLUN14UaSVfQoat3bQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5387 On 04/07/2023 12:47, Julien Grall wrote: > > > On 04/07/2023 11:36, Ayan Kumar Halder wrote: >> Hi Penny, > > Hi Ayan, Hi Julien, > >> On 26/06/2023 04:33, Penny Zheng wrote: >>> CAUTION: This message has originated from an External Source. Please >>> use proper judgment and caution when opening attachments, clicking >>> links, or responding to this email. >>> >>> >>> From: Wei Chen >>> >>> On Armv8-A, Xen has a fixed virtual start address (link address >>> too) for all Armv8-A platforms. In an MMU based system, Xen can >>> map its loaded address to this virtual start address. So, on >>> Armv8-A platforms, the Xen start address does not need to be >>> configurable. But on Armv8-R platforms, there is no MMU to map >>> loaded address to a fixed virtual address and different platforms >>> will have very different address space layout. So Xen cannot use >>> a fixed physical address on MPU based system and need to have it >>> configurable. >>> >>> In this patch we introduce one Kconfig option for users to define >>> the default Xen start address for Armv8-R. Users can enter the >>> address in config time, or select the tailored platform config >>> file from arch/arm/configs. >>> >>> And as we introduced Armv8-R to Xen, that means the existed Arm64 >>> MMU based platforms should not be listed in Armv8-R platform >>> list, so we add !HAS_MPU dependency for these platforms. >>> >>> Signed-off-by: Wei Chen >>> Signed-off-by: Penny Zheng >>> --- >>> v1 -> v2: >>> 1. Remove the platform header fvp_baser.h. >>> 2. Remove the default start address for fvp_baser64. >>> 3. Remove the description of default address from commit log. >>> 4. Change HAS_MPU to ARM_V8R for Xen start address dependency. >>>     No matter Arm-v8r board has MPU or not, it always need to >>>     specify the start address. >>> --- >>> v3: >>> 1. Remove unrelated change of "CONFIG_FVP_BASER" >>> 2. Change ARM_V8R to HAS_MPU for Xen start address dependency >>> --- >>>   xen/arch/arm/Kconfig           | 8 ++++++++ >>>   xen/arch/arm/platforms/Kconfig | 8 +++++--- >>>   2 files changed, 13 insertions(+), 3 deletions(-) >>> >>> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig >>> index 70fdc2ba63..ff17345cdb 100644 >>> --- a/xen/arch/arm/Kconfig >>> +++ b/xen/arch/arm/Kconfig >>> @@ -181,6 +181,14 @@ config TEE >>>            This option enables generic TEE mediators support. It >>> allows guests >>>            to access real TEE via one of TEE mediators implemented >>> in XEN. >>> >>> +config XEN_START_ADDRESS >>> +       hex "Xen start address: keep default to use platform defined >>> address" >>> +       default 0 >>> +       depends on HAS_MPU >>> +       help >>> +         This option allows to set the customized address at which >>> Xen will be >>> +         linked on MPU systems. This address must be aligned to a >>> page size. >>> + >>>   source "arch/arm/tee/Kconfig" >>> >>>   config STATIC_SHM >>> diff --git a/xen/arch/arm/platforms/Kconfig >>> b/xen/arch/arm/platforms/Kconfig >>> index c93a6b2756..75af48b5f9 100644 >>> --- a/xen/arch/arm/platforms/Kconfig >>> +++ b/xen/arch/arm/platforms/Kconfig >>> @@ -1,6 +1,7 @@ >>>   choice >>>          prompt "Platform Support" >>>          default ALL_PLAT >>> +       default NO_PLAT if HAS_MPU >> >> I am a bit concerned about this as we will be introducing R52 >> specific platform in xen/arch/arm/platforms/ >> >> (For eg >> https://github.com/Xilinx/xen/blob/xlnx_rebase_4.17/xen/arch/arm_mpu/platforms/amd-versal-net.c >> ) >> >> Thus, we will have to remove this line at that time. >> >> Can you remove this line, please if it does not cause any issue ? > > From my understanding of the discussion at Xen Summit, most of the > platform specific code would be moved to something similar to > bootwrapper. Yes, but I think bootwrappers are now deprecated. At least git://git.kernel.org/pub/scm/linux/kernel/git/cmarinas/boot-wrapper-aarch64.git does not seem to be active and https://github.com/artagnon/boot-wrapper-aarch64 looks archived. > > So do you still actually need to have code in Xen for setting up the > timer? I think we can ignore it for now. Just for information, we are using the platform specific code to achieve the following :- 1. Set up the timer and CNTFRQ 2. Set up the secondary boot address and start the secondary cores. - Ayan > > Cheers, > From xen-devel-bounces@lists.xenproject.org Tue Jul 04 12:04:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 12:04:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558299.872254 (Exim 4.92) (envelope-from ) id 1qGelh-0001qb-T9; Tue, 04 Jul 2023 12:04:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558299.872254; Tue, 04 Jul 2023 12:04:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGelh-0001qU-Q3; Tue, 04 Jul 2023 12:04:29 +0000 Received: by outflank-mailman (input) for mailman id 558299; Tue, 04 Jul 2023 12:04:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGelg-0001qO-JB for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 12:04:28 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2062c.outbound.protection.outlook.com [2a01:111:f400:7e89::62c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eb30bd84-1a62-11ee-8611-37d641c3527e; Tue, 04 Jul 2023 14:04:26 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by CH3PR12MB7761.namprd12.prod.outlook.com (2603:10b6:610:14e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.17; Tue, 4 Jul 2023 12:04:20 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::8018:78f7:1b08:7a54]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::8018:78f7:1b08:7a54%2]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 12:04:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb30bd84-1a62-11ee-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MHLeh5oAMew7CpQ+EQv8SScb8/ODd/SerzYGlfz4TLcwfM/St1QY/jDTzb6ICZcsdwl6epRTBS5EDBSbMz/7i89TtS3FZWitoKF8fUvwSk1aH8f9z1T4Dtyb2dqqvT/yizjjknKuwgkvtLlpX4oaAfhpWUU9jFJhnE3zoX57lnfsh/rvkky1O0ZODt620AEC2/jloyEIKxZcggSYwjskMwHJRRgB+h168Ipa54nliY3glq+HT6ZKcPrj2YVqCnzUXm2fGOWIM4XYp1xRs8vmZ/B9p6f1SbASBMKeR3t98qYWDQU6S982Z2btOKEu7r30oYfSyq8E6nzOu4s7F4YG6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F29/bsQLsktz/PeCjS6khkJbLs7Y9CkTHYNCa6igSYY=; b=LuQ+ShI4imysBEH/4Bh7L6jphb4+QGufQNbdVBo8f5WHr302GeuFmwdumH2/ISZhmZLMUZauR4vxwzB6B1kt8NyaRMFzPUIH098y4vGdypgxlRAxAJUnDBRHJiVDKroO/I8NiK76wC9jC5BTQq4QOJ61GZw5yTNa5Jjx54w7DXmxRfAqaCX8+NWLjz6gD4VH8ah6GiamvChcQjcTnh5DDt514CtNeFWtQidJ4+yqnxRSpY/VaVD09BKyzHJAnQ/x9kHuijjD6j+1CrPXxpV32uIoiU0XTHZ6fEFz5CYCmBgXl1G5GeK7700Fc4A27Yf3XtQmk8n4x6JvkqWvKIxXEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F29/bsQLsktz/PeCjS6khkJbLs7Y9CkTHYNCa6igSYY=; b=aP/TPTsx7iNBJo7h0rmsRRvm/0BoJl8BOEY96lDVdYfQDgVVWyjiFT/JxFPCkP567gLJlvo/YBhN+aLX3wULW2EyBbD2PWat0bCdJKVzwMYlPEk9mRlpk778MbBzH5ba/rtkAJ2ERidlmzzu/QjkqQDhzcWigJA5/U2JJiYW4rs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <1cc8eaa4-6fcc-21bb-c590-bffa87e14177@amd.com> Date: Tue, 4 Jul 2023 13:04:14 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 06/52] xen/arm: introduce CONFIG_HAS_MMU To: Julien Grall , Penny Zheng , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Wei Chen References: <20230626033443.2943270-1-Penny.Zheng@arm.com> <20230626033443.2943270-7-Penny.Zheng@arm.com> <4303bf0e-a987-1ee4-9524-c83756789322@amd.com> <1cbf44ae-2500-1428-5dd2-893e846faf1e@xen.org> From: Ayan Kumar Halder In-Reply-To: <1cbf44ae-2500-1428-5dd2-893e846faf1e@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0292.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a5::16) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|CH3PR12MB7761:EE_ X-MS-Office365-Filtering-Correlation-Id: 0f6b0c32-7ad6-4974-a7b7-08db7c86cc5f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /uU+ApQBoW2DflehSSW6DDjFdCWx1RdmiZFwoHPfAysUsrbY8EyMoPqpADTflAc5u6XUyLCPm7yzC59WHf6T+KdJfQCvEkxYC/b2hMz8jtTSQDYYFkGH5nnYz509sFpBFfII98r/RUgMQRzZTiJg6MZMU2566raxgKLuZHwYM1YBQbsoeupmUbpUF0Oq6RLHkiKIxPFLSulau1Ia+eg5rnOK8l+EJCR77rxBhsOAECq+RAQgdxrv8dtSaXhGQtVZ51/Q/qFmP6Ah+fseeImhHIYqf84dTM9v75jb3Bxm4AIkL59xW+cR5/1CngUahRo55jtj1CaoXOcNGOAsFX4z02aWlj4nRjXdVyut72AUdU5BIXr1qqYOCTgQGaslutwGHC/qi+KzS0wGZyd5oW8K6QqIPhg3LVldtnOsJ/kgCntrZnS97Y5hQSqM0gLxve0xVoUXYUBeMn6PMTtgnsHqLKACzJs5dvWzg0O3OLFIG5aw2/DCcG++pJt5bmCcw5AZoOoW5W7MYl9TxXUWHGj4HFo8xftlIuOP2+FBO5+/ia5XkMtGbbp7dyEFU7Yl41UrwIIZWbddtjnrHhWHkRBV5WSrm6zsVDNme77j3aSbayX9yukVGEhaf0b85lvgG3ng0LQOY2rxY8fLKQijkEbcTQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(376002)(346002)(136003)(396003)(39860400002)(451199021)(31686004)(2616005)(186003)(38100700002)(6666004)(31696002)(66946007)(6512007)(6486002)(2906002)(36756003)(66556008)(110136005)(66476007)(316002)(4326008)(478600001)(54906003)(26005)(53546011)(6506007)(83380400001)(41300700001)(5660300002)(8676002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b20xMzBtWjFnQWVwZGhpbHkxYlAyZkNwRUpiZGN2ZU95aXdGQURjNzBDQjR2?= =?utf-8?B?R3Zyb1RNVjN4ZndGM2FaaDdjMWZzU0RPREwyRVgyUWtma0M5RmlKWU5ZVVYz?= =?utf-8?B?NUpCUlM3Q2xiRXF3eGdnZ3hUaGdreXVzVDRVU1FXWGZBSlY1ajBCcUVXTDdh?= =?utf-8?B?Y1lISytWMEIrZVkvcDRiTGNyNWVPVldSYmJCV0Z1WVZCN29qSTN5RzM3aXhJ?= =?utf-8?B?RkJMYWNYQlF1OUxLUGJDRHNsZW9JZHNUOHg5NXphNXZya1RYY0R1anR0dENh?= =?utf-8?B?aGd0MUx4TXZnWjROZWpQV1RLNlA2c1FZODlRK2M4ZXZaTVVQQzFLcHN1dzN3?= =?utf-8?B?dldZMU8zZ2VXdGQ1UTdXZlhMYW1WNXJrV1BIMmozYnp4M2dxc1I4eXdJVmto?= =?utf-8?B?Z1pRcGlkaHdRUzBueS8wQVoycXpIYkV4MThkVDZhREU1c3NQV2x5RDhjbURv?= =?utf-8?B?akFXNFZjaE1ETmpqbDhGTlFzZnF3aEo4RDExMFdMREl2S3RqMFhPa2RnVE90?= =?utf-8?B?c3VhUE9uaG1qcEZEVE1UOHg1VG9WYUc4S2RFeE13MWk2cUREZWtwUUZLNXBo?= =?utf-8?B?dmJxS2xDOWRIcjZZWXNEWjRvbGVPN0RSaVp1MUJKanlyVXQxeC84ZnNLdngv?= =?utf-8?B?eHMyVVl6NFhubWpFNUdUSlJHWEV4b0w0RnZtQVJJYlk0cFpnQUpjSHpDUUVY?= =?utf-8?B?c1NjUVdsZTVpQ3B2dUo2K3ZGc21laThDWGw2WUc3NGhJdW5RY3VPd0hPN2NC?= =?utf-8?B?Nk1LdjlDdVJFS1dNZzU0c25mNkJFV0Z0dEJQd2N3VVU2L3NRUVhCd3hodm8x?= =?utf-8?B?dFZqenRhOHJYVXRHYkNFNUx4WFNGSWJaVGtUcWFhbytVbXF4MGdDOC8wMDRh?= =?utf-8?B?NEt2d0s1ZzB0QWVjYnhUQUppMkJJOTA2N3lhOThuc1lWbWRVaGUrU1J4Vko4?= =?utf-8?B?TjRmVk1oQWNNOVFSazZOTnZqb2R3UHdOQlBYZjBuN2hpbXE2aWk2UkxES0RO?= =?utf-8?B?aVh6Vk40QUtEbzg3Q21TZlBMUGZBK0llN3Vmb1BETHkybHhQTVN2WldYL2Zz?= =?utf-8?B?QlVLd0lvSG5FNDRHUWwvRk44cnRMMTRGalgxR0U0cHVYQnl5dXlOeVRjK3d4?= =?utf-8?B?WkJ5TGF1dVhHSGVib054SEw5MHc2MVNpaGVGL2ZLaEcvaXorTThmcVJwd0Vr?= =?utf-8?B?cWNrRnUyRU82SkhkTGZhR0tUZUxJNXdZaVdaTXFSc25hUmRweDJudFJNR1RQ?= =?utf-8?B?T3hqUmJaNUlBTFdOYmN6MklTMi9vdHp6NFRpTDAzeVZ6d0poU2ZoZmw5dEdx?= =?utf-8?B?a0lzQUw0cmdUU3k0UDFENTZnZC94NEtNcjJCUXlwcU5DMEJJYjV1Mm1iM2t0?= =?utf-8?B?U3RmMGY5SnRmWGpjUC9BUHhEK1FoRFdFdVNpU0JENXdVVzRvRHlsdUZRNDJx?= =?utf-8?B?U2lwdm5GU3pUeWhOMGNNYllqOUZlVnA0aWJwMlcyMUNMK2xBNW4zelp4WnJQ?= =?utf-8?B?dys0ajRCTjRJdHNnaDBtTTJ6dnBhd2M1c1E1OStGYXhmTTJEaE1YZzdXUnF4?= =?utf-8?B?TFQ2ZUpZajhpR3hodGxiL1RPSmZJWXVsbytacVdZSDNXWUF5TDBhYkQ1R3NJ?= =?utf-8?B?YkdpTDdCcDVHcEtnRGJwNTZ6Wk1FNDZ2bHA2eTVVUitCZ0tZOUoraXE3Slcr?= =?utf-8?B?eXJjdXRuTkpWTUNBZTJwR0FaeE8rWDJlaWJmR2Myclc5Y1dRR21hZVJJcTE0?= =?utf-8?B?UTZJNjdRL05YdVUreUQweDRiekR6YkN5dEU5MnlHbjR5c1FHWkFLbWVBenky?= =?utf-8?B?NHU1UDQxd0xqUXhTSHE5VktyZUg1V2xFNXNENS8rY01HNXhqKzFxSGE1SGFO?= =?utf-8?B?NUovSVBuSnlDR1BKQXZlZUhYbThyWFNpd0UzUDJieU9Ua2xIVWtRNCtnVzhn?= =?utf-8?B?d2xPN1JkQWFmMTduNVZxcEd3QWNjek5nMit2amF1d2RPWVVtd0R1QzBDV05h?= =?utf-8?B?aWNJSG12bm9RQ3ZlcXZsU0FnSEtLUjlVMkZIc3VGcmY2bFpvbHpVcmg3aG1U?= =?utf-8?B?MVMxWWZlcER5S3BSUEtTMnpMOXp6UU4wZFdEa0pBUWQrbVc4dStpV3I0V0dw?= =?utf-8?Q?68ImuHx1tKgOKoF3/45pfPP1O?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f6b0c32-7ad6-4974-a7b7-08db7c86cc5f X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 12:04:20.1089 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /cYd3zJBufoRYSs3ag1c3790TYbfO9SaeEFzxYU5W2Sv7j9D1S8T78OB/AwSjcBsP7myd26ZY3ObZYDW/KcFEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7761 On 04/07/2023 12:44, Julien Grall wrote: > Hi, > > On 04/07/2023 12:14, Ayan Kumar Halder wrote: >> On 26/06/2023 04:33, Penny Zheng wrote: >>> CAUTION: This message has originated from an External Source. Please >>> use proper judgment and caution when opening attachments, clicking >>> links, or responding to this email. >>> >>> >>> This commit wants to introduce a new Kconfig CONFIG_HAS_MMU to guard >>> MMU-related codes, to tell two different memory management >>> architecture: >>> VMAS and PMSA. >>> >>> In a VMSA system, a Memory Management Unit (MMU) provides fine-grained >>> control of a memory system through a set of virtual to physical address >>> mappings and associated memory properties held in memory-mapped tables >>> known as translation tables. >>> >>> Signed-off-by: Penny Zheng >>> Signed-off-by: Wei Chen >>> --- >>> v3: >>> - new patch >>> --- >>>   xen/arch/arm/Kconfig | 8 ++++++++ >>>   1 file changed, 8 insertions(+) >>> >>> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig >>> index ff17345cdb..fb77392b82 100644 >>> --- a/xen/arch/arm/Kconfig >>> +++ b/xen/arch/arm/Kconfig >>> @@ -60,6 +60,14 @@ config PADDR_BITS >>> >>>   source "arch/Kconfig" >>> >>> +config HAS_MMU >>> +       bool "Memory Management Unit support in a VMSA system" >>> +       default y > > I don't think you can disable HAS_MMU right now. So you want to drop > the description to prevent a user to select it. This could then be > combined to > > "def_bool y". > >>> +       help >>> +         In a VMSA system, a Memory Management Unit (MMU) provides >>> fine-grained control of >>> +         a memory system through a set of virtual to physical >>> address mappings and associated memory >>> +         properties held in memory-mapped tables known as >>> translation tables. >>> + >>>   config ACPI >>>          bool "ACPI (Advanced Configuration and Power Interface) >>> Support (UNSUPPORTED)" if UNSUPPORTED >>>          depends on ARM_64 >> >> I don't think you need this option. > > I think we want to introduce a 'choice' where the user can select > either the MPU or MMU. But not both. +1 (I like this approach). > > This would be similar to how we select the Physical address space size. > > Cheers, > From xen-devel-bounces@lists.xenproject.org Tue Jul 04 12:07:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 12:07:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558303.872264 (Exim 4.92) (envelope-from ) id 1qGeot-0002Sa-Bi; Tue, 04 Jul 2023 12:07:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558303.872264; Tue, 04 Jul 2023 12:07:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGeot-0002ST-85; Tue, 04 Jul 2023 12:07:47 +0000 Received: by outflank-mailman (input) for mailman id 558303; Tue, 04 Jul 2023 12:07:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGeos-0002SN-6a for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 12:07:46 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0612.outbound.protection.outlook.com [2a01:111:f400:fe0c::612]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6165f03a-1a63-11ee-b237-6b7b168915f2; Tue, 04 Jul 2023 14:07:43 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS8PR04MB9125.eurprd04.prod.outlook.com (2603:10a6:20b:448::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 12:07:41 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::9bd3:48c9:ff58:9880]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::9bd3:48c9:ff58:9880%4]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 12:07:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6165f03a-1a63-11ee-b237-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZrrvMp8y5SpqvHziuIW8e9ZrRLRoPHom9s4xk/YBEWs5km3UcyJl2+ATa3wHMDcFTZAITQUN/Puk2Hym1myA47RkbI1qlJeQl5JajTLr1K32LTwIy2lMkIhrnU8X8hHBzmnnTVPRJAWEH1WSLYnF803m29ypzYRkJKHZuxy7iEP609mVXGuFStLUIlOmrYv1gdaDHuvI1tCuySB3vpNAOOlqT8VkJMu0vhZJkXPvUgy2V1oHRPKzbpo/IpfT6dTIZl3kKmv0/wLg2WOPqe7bZPIvKwO9cuj5vU7X4bz48n3z7Lwfcg6GeZe43jpdy0N6LSfCT0uX9WI1OwnAeO9DhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0qz0Ee1j86xIJGrzBSV/HnDcjBMkJZpToooyiz0wtQo=; b=DVngeMZbVrKSyMViuzQnRx9P74YGDgVoD0e4WyFZ+SHHjgXUGaPUwM2CjwdsIxMFmnJ+9OcqJ1qMlexrripPSeWhhIj4RfEf4D0mZ/wEf1mgRJWTtyb5vPqdYDqOY9NqJ4F2SNKhcEg56veqYxL1txGSU06xm9wN3EKY8Wrlgvh6PAyyqiyxfEFO9HZCRSOlR9QygWiNgoxfjtk8LQx6ymf6PDd+ELU1dsumgsoBjR1ybBceJt/RL7LcVIoaCGWDjhCSAd0WrP7nXZmYTGJTuUyyobkh6emU9rM0+TchMZIOmp1GuWpIzqHm57+j/vzOFvlkCrFn6ntToZWsuFE3yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0qz0Ee1j86xIJGrzBSV/HnDcjBMkJZpToooyiz0wtQo=; b=YxbPP+LdQ6/ON3uSNCIdxSwVFbnHjyTo3+bVqgHQlmyqnxDwLYzQIjmIqadeW8DywPvHysSC4lhWGtTII/+6fN/VhjG0FgLwg/Iypka1hooYi/18+jWQJfYYWdE/ttWY90lQVMaIICIyx6htYLdjLyhHt/rqJ0QHH4fISIh82mRgg/wkHAOv6Yx5drlzTH/nLAfld07ngETiAtNkZqEEhBQW6VDj76HgNIJiwFvS1tqEgsGPFEnmO8sDmz9lk7tl2Hghm4Kn9AHeVmmaRTRPfTa9hDvQHGBwRd6ihSysSymga43ca+VQUHynRl7JyGxqWsxnINcizoQeUfLi62zIwQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 4 Jul 2023 14:07:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3] xen: speed up grant-table reclaim Content-Language: en-US To: Demi Marie Obenour Cc: Xen developer discussion , Linux Kernel Mailing List , stable@vger.kernel.org, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Konrad Rzeszutek Wilk References: <20230627172216.1359-1-demi@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <20230627172216.1359-1-demi@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0201.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ad::10) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS8PR04MB9125:EE_ X-MS-Office365-Filtering-Correlation-Id: 82306e69-13bf-497c-52ee-08db7c874448 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NJzCE91NMvGnE5tj1xskNk7hGUDCCs9Lj5Mgcts+SYrLABUIs92x9ouBMI+Vcg2y/ePSlzCZPjW+xAloFEbhvj17+51o77JvjlXIwLYLIUGnWgx2RmQHiVzO+S+VvtUCblF0XhhZbbYjN/t/53IRPnAHG9hOPT4Cujv+gMrf83Kes9bPU21en6LAt7oEr1DwWEL/PeWbVv3iMpBL2f9VtpF+JTR4CEHZRCMeqg0N8cSySgl6TBapCyA4qkoevkGG9m4SbR0PUM9LNsZyfb15wbvXxy3i50iXDNfuzBo32YK2qsW2boi+jjBJhybMWAtOmM2akdY2K8ltYnD7foZ/HZM2qalQKz3ykyhW2z8D3wUpbaFnuZ1sqy4qHtXs0rC9NGUq/p3UFPAZIlyqyX0ecn7eBluaYbIuA4twGDfcC2sLH4yyuLU+caCm94q9fu/Z8jxfv+QFRgdwvaZBV+GoAqyrrhKjxcU5YXRTZzf9cK0Pum/JqDKDvA2/tzYe24zB3kItgrA5DjWcXvltEJdPM37vzeDsgGBW1gJ9sLeXisx8Nzl4jXr+sjs7eC1seq37KbhZflPUIvUUk0p9Uy005Fa89xujH0JRWbUnw4LZOTchxBVTgdRlL57ZA1iInKqliRS8qBlm7NmDhJDvKaSwQQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(39860400002)(396003)(376002)(136003)(346002)(451199021)(2906002)(41300700001)(8676002)(5660300002)(8936002)(36756003)(31696002)(86362001)(186003)(2616005)(26005)(478600001)(6512007)(6506007)(31686004)(6486002)(53546011)(316002)(66476007)(6916009)(4326008)(66556008)(66946007)(54906003)(38100700002)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVF3ZTdQcFdmb2JhQWRpRmtSVWx2ejA3aDZCUWZhVjdIeEorZWU1WEs0cEhX?= =?utf-8?B?K09seGc1NjNIdFFyL3FjZFZPeEE2dHNac2VJODBWV2dYaEZqeC9DMkk1UDI0?= =?utf-8?B?UjJycnE3U0xhOWJyTWVtWkVSdnlON0ZIVHBDWi94YWY1WVU2cFYwUkdjcXp4?= =?utf-8?B?SWQ0WGZnSXpzaEZwMlJoVlB1YTVuWmtRS0x5bVZDSnlsbWh4UzFqOVRqVk5N?= =?utf-8?B?VHRQWHVZeExoWDNzSkNqd1hkYS8yNnFOR2lkSXRhN1JzYWliVWxrTVpzOWVw?= =?utf-8?B?TjZBcFQrWjhYbUNZLzcxUDk2NTRmRERlNER2N3BzOGI5YnFpdFlNTFJCYkZY?= =?utf-8?B?KzdLTXVQR0NONzI3RjdzeDNDNkI3Uks0S3ROdVRlWU5saHc1aFNmSDRvbnJv?= =?utf-8?B?QjBlRENrVTBCUDBhZW04QlFHT09zSlVkdllSU2tidlpMVzRCN1M5SzhmTEsy?= =?utf-8?B?dUo1bk5JVkRqVHJyQnZhSjhlZnRrRW94bHJxYkREOHlXY1EyNW1XQnNDU3Qv?= =?utf-8?B?OFFuNHBhYmdCRW9oM2QvZGtJRHErdEVuQVQzeWNqbkNFWkNaZGl0Z1FzeFo1?= =?utf-8?B?OUpYdEQrZEhoWjF3VGcrZ2JRWFUwSVlnRXdKRnQrY3F0NGo1NWNIOEcvMlN0?= =?utf-8?B?VmpFcGp1dDByM1BXbkpSc1hKVlFHMldtSWlqa2xTTzVWQWJwNUR1ZXpwT3Zk?= =?utf-8?B?ZFRNUFhTa0hNTGl1cXFLMDREOW1yTDRQQkV3RjR0MUl5Y0paeUV3YmNHZkVU?= =?utf-8?B?ejEvTE1NV0h5U3YrQlUyUjR3RjFZWTRmeGxpUm9LazNWWGZYRHdPTFlsWUY0?= =?utf-8?B?T3h3SUZlMTJSaUZFN2RpYUpXVmRGcEdubksxVlE2c2tiY3drRXYrdXQvZzNn?= =?utf-8?B?L1dEWTFJc2dDVThZTmRycWdsayt2Yno1Zkh1UGwrZzQ1VnY5RnBsZDVhaDcr?= =?utf-8?B?VzE1TUxJRUNadDhJSVorRlYxeldwYzUrRXljRkJPRFlDT0FReEcweFVkeFNP?= =?utf-8?B?bW5KRmNSc1E4S2RhektSUnpXeW1QWWtQcFBGeTNEbWg5OVV2anFvSjFGcmVL?= =?utf-8?B?Z3k4K3cxYlFOREd2SGVoSmF5NjZPaUgvelJVK0Qxemc0NnJ0OG53aS8xSm83?= =?utf-8?B?SFRLZFZ5TUlVVXc3NzdDTzVOcXdLT3B6dVBKNWJMYXFyNk0wMlJVK0VNb244?= =?utf-8?B?anV4b1pZcmw1UmlsQ0dCZ0xyRkloWmFGeGE2QVFnRHBRL1A1cEExSjgvRWNS?= =?utf-8?B?QUlkaWo5V1pVTG9CNFVzM05Oa2swaVNaQ3BzRmN2RFBocDRvZ0Rtak9PZFpR?= =?utf-8?B?bmxQRHVkb29YMWJFTkhlQW9iYytYdHNaNE9SR0xFRUcwYmM4dEdMaGFpK3hH?= =?utf-8?B?c21BaWV5M1JhR2xOdlFWNktscmpMZXdTcHZRTmdQVXhaazBLcnh2Ym1CMFBC?= =?utf-8?B?ck44bHJGTFRpTFUzRXpTeStQZEZOTWdZTzdxeVdOVCtOeDh1VTh1dnBzRXZu?= =?utf-8?B?Yk1PcHc4d3FPL1RwMkE0YTdScWpKY3RyWm1wd3lBSDlvMmFrOXk0cUwrYTFM?= =?utf-8?B?bUpCNWV0KzlhdEpSTmoxMURrZlhzdHNDd3dMZkMvRkhUZHRMMmxDenlFSjg5?= =?utf-8?B?MmZnZzBrZXordGpwTTlxWEZBSWtmSTI5WG9UYWI4WU5iaklCQS9VUUhKQzVK?= =?utf-8?B?YmVKai9QcmVaYlZHZHZEdmJEOUY4aU5iZWlUM0ZpRnZQdlRna2pQZks2MXF2?= =?utf-8?B?M0tYcnVqZk1BYm9GRjFIelNhaVdRcFluYnpHUUpXN0lBMWxnUElnTTdYcHdu?= =?utf-8?B?dDBlcE1WVHMzTkk5VkZpRm5IWGRKUk5iNnFpei9YU205QUY2NkxHT0lHV0xD?= =?utf-8?B?eEE3Y0dqdWdMQUlSMTJQbmdUdllKeklQdldIU0EvbkhCbFpQTzhzUklmRUVC?= =?utf-8?B?ckdxeEtJUWorMngwTTIzajNncGVKSExLd3ZZekxRaUpUZGc5ejRIKzFtdFdy?= =?utf-8?B?VWE2ZnRlcHRqOUdiYkJFUFAwMHdQOVcwU2VEYVVERkU2b3Q1WmtGMkdCSzJj?= =?utf-8?B?V211anlKVUh6VFdERGNOK2x6ZHZkUU1lbTZLUERZakRzY0VMMmZKL2doWGFm?= =?utf-8?Q?Y4UDppws+b2EZdIeiDXu2l4ez?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82306e69-13bf-497c-52ee-08db7c874448 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 12:07:41.2205 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xJV62KrS4qg4GuebwqjRxegd+w56YZImDg1btei5ax5owMe51Z0IbOm899TNSXfnfl4jHauTs/W9VdIc0x2ebw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9125 On 27.06.2023 19:22, Demi Marie Obenour wrote: > When a grant entry is still in use by the remote domain, Linux must put > it on a deferred list. Normally, this list is very short, because > the PV network and block protocols expect the backend to unmap the grant > first. However, Qubes OS's GUI protocol is subject to the constraints > of the X Window System, and as such winds up with the frontend unmapping > the window first. As a result, the list can grow very large, resulting > in a massive memory leak and eventual VM freeze. > > To partially solve this problem, make the number of entries that the VM > will attempt to free at each iteration tunable. The default is still > 10, but it can be overridden at compile-time (via Kconfig), boot-time > (via a kernel command-line option), or runtime (via sysfs). > > This is Cc: stable because (when combined with appropriate userspace > changes) it fixes a severe performance and stability problem for Qubes > OS users. > > Cc: stable@vger.kernel.org > Signed-off-by: Demi Marie Obenour Why am I _still_ - after two earlier private questions to the same effect - on the To: list of this submission? Please can you respect other people's time and interests and properly follow patch submission rules, applying common sense when (like has been the case in the past for Linux) those rules result in overly broad sets of people. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 04 12:11:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 12:11:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558309.872274 (Exim 4.92) (envelope-from ) id 1qGerz-0003xJ-Sf; Tue, 04 Jul 2023 12:10:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558309.872274; Tue, 04 Jul 2023 12:10:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGerz-0003xC-PX; Tue, 04 Jul 2023 12:10:59 +0000 Received: by outflank-mailman (input) for mailman id 558309; Tue, 04 Jul 2023 12:10:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGery-0003x3-0j for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 12:10:58 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGerx-000753-KF; Tue, 04 Jul 2023 12:10:57 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qGerx-0002Fd-EX; Tue, 04 Jul 2023 12:10:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=0+NlS8i1p9v08aRSXry7rnarwsmM8IY/lH+nDOMKUf4=; b=B2AMI7eXQ3/t0m2C78bS0eOo5y z+Uhmlftz8XGYQeyRvIN2hJit8x3qYxTcti/d3QB5iyQ3wyYTf2jzZfIMMT6kXsVKqV6WUNdpsPSz oUwlDK7ugaWc9NaSAMbTqYmBom0YwDeGY6xmD39KHxVADDTRPTv3HzbvowpL/wzfJZiw=; Message-ID: Date: Tue, 4 Jul 2023 13:10:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 03/52] xen/arm: add an option to define Xen start address for Armv8-R Content-Language: en-US To: Ayan Kumar Halder , Penny Zheng , xen-devel@lists.xenproject.org Cc: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230626033443.2943270-1-Penny.Zheng@arm.com> <20230626033443.2943270-4-Penny.Zheng@arm.com> <77c64929-514a-ea67-cf8b-176c895ff971@xen.org> <682fdfab-b755-e580-7688-3dc0c0e3779e@amd.com> From: Julien Grall In-Reply-To: <682fdfab-b755-e580-7688-3dc0c0e3779e@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 04/07/2023 13:02, Ayan Kumar Halder wrote: > > On 04/07/2023 12:47, Julien Grall wrote: >> >> >> On 04/07/2023 11:36, Ayan Kumar Halder wrote: >>> Hi Penny, >> >> Hi Ayan, > Hi Julien, >> >>> On 26/06/2023 04:33, Penny Zheng wrote: >>>> CAUTION: This message has originated from an External Source. Please >>>> use proper judgment and caution when opening attachments, clicking >>>> links, or responding to this email. >>>> >>>> >>>> From: Wei Chen >>>> >>>> On Armv8-A, Xen has a fixed virtual start address (link address >>>> too) for all Armv8-A platforms. In an MMU based system, Xen can >>>> map its loaded address to this virtual start address. So, on >>>> Armv8-A platforms, the Xen start address does not need to be >>>> configurable. But on Armv8-R platforms, there is no MMU to map >>>> loaded address to a fixed virtual address and different platforms >>>> will have very different address space layout. So Xen cannot use >>>> a fixed physical address on MPU based system and need to have it >>>> configurable. >>>> >>>> In this patch we introduce one Kconfig option for users to define >>>> the default Xen start address for Armv8-R. Users can enter the >>>> address in config time, or select the tailored platform config >>>> file from arch/arm/configs. >>>> >>>> And as we introduced Armv8-R to Xen, that means the existed Arm64 >>>> MMU based platforms should not be listed in Armv8-R platform >>>> list, so we add !HAS_MPU dependency for these platforms. >>>> >>>> Signed-off-by: Wei Chen >>>> Signed-off-by: Penny Zheng >>>> --- >>>> v1 -> v2: >>>> 1. Remove the platform header fvp_baser.h. >>>> 2. Remove the default start address for fvp_baser64. >>>> 3. Remove the description of default address from commit log. >>>> 4. Change HAS_MPU to ARM_V8R for Xen start address dependency. >>>>     No matter Arm-v8r board has MPU or not, it always need to >>>>     specify the start address. >>>> --- >>>> v3: >>>> 1. Remove unrelated change of "CONFIG_FVP_BASER" >>>> 2. Change ARM_V8R to HAS_MPU for Xen start address dependency >>>> --- >>>>   xen/arch/arm/Kconfig           | 8 ++++++++ >>>>   xen/arch/arm/platforms/Kconfig | 8 +++++--- >>>>   2 files changed, 13 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig >>>> index 70fdc2ba63..ff17345cdb 100644 >>>> --- a/xen/arch/arm/Kconfig >>>> +++ b/xen/arch/arm/Kconfig >>>> @@ -181,6 +181,14 @@ config TEE >>>>            This option enables generic TEE mediators support. It >>>> allows guests >>>>            to access real TEE via one of TEE mediators implemented >>>> in XEN. >>>> >>>> +config XEN_START_ADDRESS >>>> +       hex "Xen start address: keep default to use platform defined >>>> address" >>>> +       default 0 >>>> +       depends on HAS_MPU >>>> +       help >>>> +         This option allows to set the customized address at which >>>> Xen will be >>>> +         linked on MPU systems. This address must be aligned to a >>>> page size. >>>> + >>>>   source "arch/arm/tee/Kconfig" >>>> >>>>   config STATIC_SHM >>>> diff --git a/xen/arch/arm/platforms/Kconfig >>>> b/xen/arch/arm/platforms/Kconfig >>>> index c93a6b2756..75af48b5f9 100644 >>>> --- a/xen/arch/arm/platforms/Kconfig >>>> +++ b/xen/arch/arm/platforms/Kconfig >>>> @@ -1,6 +1,7 @@ >>>>   choice >>>>          prompt "Platform Support" >>>>          default ALL_PLAT >>>> +       default NO_PLAT if HAS_MPU >>> >>> I am a bit concerned about this as we will be introducing R52 >>> specific platform in xen/arch/arm/platforms/ >>> >>> (For eg >>> https://github.com/Xilinx/xen/blob/xlnx_rebase_4.17/xen/arch/arm_mpu/platforms/amd-versal-net.c ) >>> >>> Thus, we will have to remove this line at that time. >>> >>> Can you remove this line, please if it does not cause any issue ? >> >> From my understanding of the discussion at Xen Summit, most of the >> platform specific code would be moved to something similar to >> bootwrapper. > > Yes, but I think bootwrappers are now deprecated. They are still used on FVP to boot without UEFI/U-boot. > > At least > git://git.kernel.org/pub/scm/linux/kernel/git/cmarinas/boot-wrapper-aarch64.git does not seem to be active and https://github.com/artagnon/boot-wrapper-aarch64 looks archived. I expect bootwrappers to be fairly stable. So I am not entirely surprised that it is not "active". > >> >> So do you still actually need to have code in Xen for setting up the >> timer? > > I think we can ignore it for now. > > Just for information, we are using the platform specific code to achieve > the following :- > > 1. Set up the timer and CNTFRQ > > 2. Set up the secondary boot address and start the secondary cores. This sounds like code that could be added in bootwrapper (or similar). So Xen (or any other OS/kernel) can share the logic and can rely on spin-table/PSCI for SMP bring-up. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jul 04 12:22:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 12:22:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558313.872283 (Exim 4.92) (envelope-from ) id 1qGf2W-0005SR-QC; Tue, 04 Jul 2023 12:21:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558313.872283; Tue, 04 Jul 2023 12:21:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGf2W-0005SK-NN; Tue, 04 Jul 2023 12:21:52 +0000 Received: by outflank-mailman (input) for mailman id 558313; Tue, 04 Jul 2023 12:21:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGf2V-0005SE-0Q for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 12:21:51 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2049.outbound.protection.outlook.com [40.107.7.49]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 58e10ffa-1a65-11ee-8611-37d641c3527e; Tue, 04 Jul 2023 14:21:48 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM9PR04MB7492.eurprd04.prod.outlook.com (2603:10a6:20b:282::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 12:21:19 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::9bd3:48c9:ff58:9880]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::9bd3:48c9:ff58:9880%4]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 12:21:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 58e10ffa-1a65-11ee-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JwfyPA0xH4/RImmUbV8WNHnstvAahL3LRXp/ePTA7FVAWFM96ZYC0mUqJYVG3qwKToFRAqQnVTHik6wDD2ogsoYoomFy5Wzpsf9HvQVGCcWzQA+lG3Oi1WF7ha35Xq0ztysMC28QfhQ109bqBOP0g/3x78E5VbMzulKzTBIEcVnPfb5/UEObOEZW4KqEW0QsojD66oyDAJmKKT/Fhxgkvi4WGjecP/M8Yaa+BHbLFdaQlVT3sBMDv07XHTCiJ6zlYykeh1wdpANmvZXT2dPmrqUlIcHqAuqo2jMUaF+H/8ixQFs5NOzNhEzuTsi839VEkLeRh2U0xCnNVwoREB1fig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=In3WCiwidXW2LkHXdFTMrEoGDNfe1stpI+BHStJM4dc=; b=hSI1tGrZLaCssm6CKsUnVQz2+c+H8ndio3Mg6dm2yXUfQH2D6e7625C5wMkphtD6dklpPfSGqh56xCwWMNX9Y87aYBjYrPn7xuRRBsugXyxew9CKgVFWjnpNmBw7b6975fWEtP6ZWm5zaSHGAmXYOX/5PllVaFfc2Sulrxvv83phypPUqA/fMwxmVnegngO7AxIG0TlOiYPbsAQKwM0QB3dG93f/scqvG8uo5gCWDmuuyrBmb77e0pQGT4fxOoctqPJFjUdzBNqBShcLbqC7R//o/UDyGwKRien8FujiF4fNEtuf2UEHB+tKeRsqIp1P+dER3daaVerShhzQIasbSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=In3WCiwidXW2LkHXdFTMrEoGDNfe1stpI+BHStJM4dc=; b=FW90UHpa88v7rilaCaloLiqgHmMVltpCN3snF2FrzURX6cWKFrfkjP12f6J8+M2+JiUSfDhgLLzvcAG3k97/ywcDrRwhppLx+gc81eKegLeVuYb3NGEZdVlQkzcRL1im/Pn5/gYmHAMLpi6tHnCimM3DWYFrJCYLOXkzjEJ6iVDSi5eKMR1+iXgAkd9Sdvucj/pnUZ3R+t/ePjjJ6LuUaIQBEsq2pMFtGiPCjdARXJ7+86tmc0kjsAE8fbjVgaQP8MpxTVmcylr1ihdMoJKZXiQi/NXmMyXq7qhpwHSrfwNrbALzwK0eBxY5er0E3aitiUkFYQ9RRIc3odx7cAwHjg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1bc81320-7bc2-3392-528e-8434d6a44ccc@suse.com> Date: Tue, 4 Jul 2023 14:21:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 15/52] xen: make VMAP only support in MMU system Content-Language: en-US To: Penny Zheng Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Chen , xen-devel@lists.xenproject.org References: <20230626033443.2943270-1-Penny.Zheng@arm.com> <20230626033443.2943270-16-Penny.Zheng@arm.com> <654c9925-565a-80d4-5e93-129f6f0f691a@suse.com> <7d3ff868-60a4-1eab-0b9b-f6ca649cfdeb@arm.com> From: Jan Beulich In-Reply-To: <7d3ff868-60a4-1eab-0b9b-f6ca649cfdeb@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0159.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b3::15) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM9PR04MB7492:EE_ X-MS-Office365-Filtering-Correlation-Id: 9ecf48db-ba5e-43db-64d4-08db7c892bbb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A9Qs7AAoyN6NPJZvriH5q2znsuWGbo1gHq+uoRnbMFmqS+qMNlTqyBIikzAtP3mDSDpXFEmswq/4AKr1h+cmiYBJQdKyhIuWohuy2uf3JYNK4AjZDAuxpBYVeCz76xrf2OEnCyevHUpR9x+Y3/WPFPaLXl0t7KDbFrpiRlScVXqskooj43fK48MShRN4mzfAclIBbXNfkC5fUkgyRJ7N9eKXFCBajPcANQZCFapLEgT/Ysrm5XaFIM52jowoSnwMmHVbqJGnBupiSafMi7DZ15a5Y8Z/O94xWCRrA2yOxyx0rAs/rUN1uHdUrGf7ua4Wkcp690euzUoHnkOtzGDiGlAphUB7H+09K0gF2wSOLsHI/u2Cro8QevbWZ2qYR1UPOPb4fUqiWkiAGCqpHimeY3xtd8oBNWXI5Uh0RiO3mZyCqgE9PRNHTYuNg+RYBPXRhEvut+fjfQkD2Xi6t9a96oZk2jU0h0hbALu/ol9OoQ1FxWXVPbyLBB2qWemj9qkeCc71x+sfMz6DABzF0ZBEJt5Mpb/L7pOsJYkCvJZnmE97i7g1nMHxbvMfH77xdGCFD+jB0h1JulMelUN2Y+1zIIP6fZqY2VXzV4PixLZQMAztk8qHY/ly1XBDiDH0zMImVcApDe03mns5jgpozltdwMdygFpthCnnqXhxXRip2oc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(136003)(39860400002)(346002)(396003)(366004)(451199021)(2906002)(41300700001)(5660300002)(7416002)(8676002)(36756003)(8936002)(31696002)(86362001)(6512007)(6486002)(478600001)(6666004)(83380400001)(186003)(53546011)(31686004)(66476007)(26005)(2616005)(66556008)(4326008)(6916009)(54906003)(66946007)(6506007)(316002)(38100700002)(21314003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dG82WVJmRm9ubkJxNDZTcWl2Y0JrY1diQnY5L3p5cVBDN1Bsb1dyZWtCcEVQ?= =?utf-8?B?UDIxS09FQlVIWDhDenZWMUhPYk9uaEJzWFpkeFlncG5tY3VkRG5pbHhmS1N2?= =?utf-8?B?ZEFDWS9QT3l4Q0FTSmhrZm41S2xtVlN1Q2lKNU1DS1k4OHBwaDNBSjRiWDFQ?= =?utf-8?B?L1RpUWMzQy9HaldWb0d3ekhIUHNGMmlEdi9vTkEwMEVjNGJjbmI2enJtMTBy?= =?utf-8?B?YkZ0STh5ZGExdVJiNDM1QmQvOHpienVPeTNNUUd4cStSajBZb0tFd0c2U0Ja?= =?utf-8?B?L05GenNsclJ3eVVST3Y2MjVXbmFabU9PWWpUa2Y3UnZrNkM1MU5STUttQTQ1?= =?utf-8?B?WmJWekZZV0VSYllwbXo2WkFBS2ZWeXRUTTNjcWVDOVZRVzE0eXRFLzdYZW5T?= =?utf-8?B?WkhEOHlMY2hvRFhldnFGMGtpbHVYNnNhY0R4WmhwcXk3bEZmbU1GNVl5L05i?= =?utf-8?B?L2xLZm9pdjFxK2NiWVZzMU9BSnVkVFpSalR3dnZkY0NRLzVvRGFoeERTVlhv?= =?utf-8?B?SnppSDFPQ0hSeThCOXJ1T0M4MDF2cmFZM3l0VTZ2NytKRGNyMWE4M0NzNUFz?= =?utf-8?B?TWtXSU5JSXc5aWtwZ1JWWFJFSEV6REZscFdZZ0hDaUR2aVAvTWFJL25YWkQ5?= =?utf-8?B?WDNacEtEdENkT1lIVHJiY2FHVFYzTjhYR25KNnphalJHQXVzMnpFdUZrblBn?= =?utf-8?B?NDVWUkh0YlErZEdwUnovckxMbnpKQVBvdkVoMG53WUlmQTVmZTZrNWRtWVhn?= =?utf-8?B?cFZjN0Z1bG5qbDNSenNYRDdHS1NuQ1JiaERHTUpucFh2clByQXRUTjZrSXRt?= =?utf-8?B?aTlTVlFZbU1wQjJydllaUkpVcmp0a0xpUXJDQ1duZHFObGZTdVJTdktwRzUv?= =?utf-8?B?c2syYUoyQVgrVGpnTUtaQms3alNISVdDVkZDSW8wK3A4M2ZuZk4xM1kwKzNj?= =?utf-8?B?VCtscS9LZFp6Y1dQZnBtdkp0d01mdmNCWFMzMlpmNmtBVUxVcWJSOS9Qb2NM?= =?utf-8?B?b0l2dVhnR29rOHRUTmhxemxRMEhmcDN4T1BNMStFN0lVVnhpU1BwZElMcXFw?= =?utf-8?B?YkJ4TWcwckNGYy9JSTJFVS9jU00yTlJGaW9ya2V1ejA2OGdpTlN6a25lM2tD?= =?utf-8?B?SWExQlpzNWFDRzJMRkliMWxsS0NRS2JneU1oNFc3OE1xNFZrdDd3YVc1REs1?= =?utf-8?B?MkgrbERaTGtGL3U2anNJZ2xmRFR0OEZEZjhQbnpKMHFpZG5yZ3p2UmJuT09P?= =?utf-8?B?ckRsc2tTY1Y5dE11S1U2aU1WTTh6OTdGSmVEQlhQeVRSUm0vUG81VEkyT2wy?= =?utf-8?B?cjRlaEJLbUR4ckFhKzVnUEVJdExKQUJBUDdDell4bm9RT0ZxNzVpMlZpSTVl?= =?utf-8?B?TEFrSnVFV1dyZ2g2cS9iNzdFSHpHcEJUcVlSa2ZZNUZ2NjU0TC9rUmdyZytt?= =?utf-8?B?eGtSSWREdXo0MnFBM0w5RTBiay80MFNWSXppRmw0amV1SVVSdUdXbG1vZU9J?= =?utf-8?B?U0E1K09EY1BPOVZUWGxhcFNxekJ5Y1pXQjBpd1lKTDlTNTFVdDdBUGMwemlY?= =?utf-8?B?NjlTQ3YxYXRrZkV2WXVIdCtRYmpmdDdDZkZvZmtqZGJCdFEyM2plbThsM0xW?= =?utf-8?B?dHFHM1h2SlVKMzZDYlcxNWRKc25KaHRMaE5BMUtQV3VLM2dmeEdTV3cvQTAy?= =?utf-8?B?UFlqaGNocnlhVXJLaXIvMWc4SEhQanhOM21xOUsyT25KNnRweFNvV002VmJw?= =?utf-8?B?VlFUM29VTm9RbWNGZFV2dGxFYUlDTVV3NUl1TnBlWFRUbk5OalpsRUZ2eHcz?= =?utf-8?B?bGd6UW1ZT0xNckxJWko4UlRIcFhjTGdtYzQ2NHNmZU5lajJjMkRVWTFpV2RQ?= =?utf-8?B?elh4WENLQ2YrWTVZRmQybFJEZVc0eW85UnFoQ2FYbkhtWWFROHZGZHpHTG9S?= =?utf-8?B?NDFhQWU5bTd1NzROb3N4VE9CTnRkOCs3bVhCTzJaaDJwdiswbWs1L2p1V3Jx?= =?utf-8?B?K05xQjJ0NXN3K1NEdFNUQWhCS3VRQU8wR1dOWCtkR2R2aVNEeno0aGRucEk2?= =?utf-8?B?YWxzVzc1YTcxb2c1aWVWa003NFhEM2E1eU00L2tsc050elhHRGsxSFB1SUVW?= =?utf-8?Q?k3xasOgrDsz524XfZItH322rs?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ecf48db-ba5e-43db-64d4-08db7c892bbb X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 12:21:19.0399 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: snqGxa1317f6C0YeOJ4Y/OtIovCH/l8Y17VrgTPIAM2QLaIHegwGkoM/P9IwMFOQdUJQkhUXksd6tnbAN5oruQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7492 On 28.06.2023 07:38, Penny Zheng wrote: > On 2023/6/26 14:00, Jan Beulich wrote: >> On 26.06.2023 05:34, Penny Zheng wrote: >>> --- a/xen/arch/x86/Kconfig >>> +++ b/xen/arch/x86/Kconfig >>> @@ -27,6 +27,7 @@ config X86 >>> select HAS_PDX >>> select HAS_SCHED_GRANULARITY >>> select HAS_UBSAN >>> + select HAS_VMAP >> >> With this being unconditional, ... >> >>> --- a/xen/arch/x86/setup.c >>> +++ b/xen/arch/x86/setup.c >>> @@ -1750,12 +1750,14 @@ void __init noreturn __start_xen(unsigned long mbi_p) >>> end_boot_allocator(); >>> >>> system_state = SYS_STATE_boot; >>> +#ifdef CONFIG_HAS_VMAP >>> /* >>> * No calls involving ACPI code should go between the setting of >>> * SYS_STATE_boot and vm_init() (or else acpi_os_{,un}map_memory() >>> * will break). >>> */ >>> vm_init(); >>> +#endif >> >> ... there's no need to make this code less readable by adding #ifdef. >> Even for the Arm side I question the #ifdef-ary - it likely would be >> better to have an empty stub in the header for that case. >> > > I may misunderstand what you said in last serie and thought #ifdef-ary > is preferred compared with inline stubs, referring here to recall > ''' > Do you really need this and all other inline stubs? Imo the goal ought > to be to have as few of them as possible: The one above won't be > referenced if you further make LIVEPATCH depend on HAS_VMAP (which I > think you need to do anyway), and the only other call to the function > is visible in context above (i.e. won't be used either when !HAS_VMAP). > In other cases merely having a declaration (but no definition) may be > sufficient, as the compiler may be able to eliminate calls. > ''' > So maybe the preferring order is "declaration > empty inline stubs > > #ifdef-ary" ? Indeed. > As having a declaration is not enough for vm_init()(when > !HAS_VMAP), we provide static inline empty stub here. Really you change the existing vm_init() to an empty stub already; no need to have a 2nd one (if that was a consideration). >>> --- a/xen/common/Kconfig >>> +++ b/xen/common/Kconfig >>> @@ -15,6 +15,7 @@ config CORE_PARKING >>> config GRANT_TABLE >>> bool "Grant table support" if EXPERT >>> default y >>> + depends on HAS_VMAP >> >> Looking back at the commit which added use of vmap.h there, I can't >> seem to be bale to spot why it did. Where's the dependency there? > > vzalloc() is used in grant_table_init() in xen/common/grantable.c:2023 You'll need vzalloc() to fall back to xzalloc() anyway when !HAS_VMAP, I suppose. >> And even if there is one, I think you don't want to unconditionally >> turn off a core, guest-visible feature. Instead you would want to >> identify a way to continue to support the feature in perhaps >> slightly less efficient a way. > > We have discussed in MPU design, normally, xen guest in MPU system > will be a linux guest with no pv(with CONFIG_XEN=n), so advanced > features like grant table is in no use there. Is this design decision written down anywhere? It looks pretty limiting to me ... >>> --- a/xen/common/vmap.c >>> +++ b/xen/common/vmap.c >>> @@ -331,4 +331,11 @@ void vfree(void *va) >>> while ( (pg = page_list_remove_head(&pg_list)) != NULL ) >>> free_domheap_page(pg); >>> } >>> + >>> +void iounmap(void __iomem *va) >>> +{ >>> + unsigned long addr = (unsigned long)(void __force *)va; >>> + >>> + vunmap((void *)(addr & PAGE_MASK)); >>> +} >> >> Why does this move here? > > ioremap/iounmap is using vmap, at least in ARM. So for this more > generic interface, I was intending to implement it on MPU system. > In commit "[PATCH v3 19/52] xen/arm: switch to use ioremap_xxx in common > file", I'm trying to replace all direct vmap interface with ioremap_xxx > in common files. > Then I, in commit "[PATCH v3 36/52] xen/mpu: implememt ioremap_xxx in > MPU", will implement MPU version of ioremap_xxx. Which suggests that the movement _may_ be needed, but doing it here is likely premature. >>> --- a/xen/include/xen/vmap.h >>> +++ b/xen/include/xen/vmap.h >>> @@ -1,4 +1,4 @@ >>> -#if !defined(__XEN_VMAP_H__) && defined(VMAP_VIRT_START) >>> +#if !defined(__XEN_VMAP_H__) && (defined(VMAP_VIRT_START) || !defined(CONFIG_HAS_VMAP)) >>> #define __XEN_VMAP_H__ >>> >>> #include >>> @@ -25,17 +25,14 @@ void vfree(void *va); >>> >>> void __iomem *ioremap(paddr_t, size_t); >>> >>> -static inline void iounmap(void __iomem *va) >>> -{ >>> - unsigned long addr = (unsigned long)(void __force *)va; >>> - >>> - vunmap((void *)(addr & PAGE_MASK)); >>> -} >>> +void iounmap(void __iomem *va); >>> >>> void *arch_vmap_virt_end(void); >>> static inline void vm_init(void) >>> { >>> +#if defined(VMAP_VIRT_START) >>> vm_init_type(VMAP_DEFAULT, (void *)VMAP_VIRT_START, arch_vmap_virt_end()); >>> +#endif >>> } >> >> Why the (seemingly unrelated) #ifdef-ary here? You've eliminated >> the problematic caller already. Didn't you mean to add wider scope >> #ifdef CONFIG_HAS_VMAP to this header? >> > > plz correct me if I'm wrong, in MPU system with !HAS_VMAP, if we don't > #ifdef-ary here, we will have the following compilation error, I guess > it's because that vm_init() is a static inline stub: > ``` > ./include/xen/vmap.h: In function ‘vm_init’: > ./include/xen/vmap.h:33:40: error: ‘VMAP_VIRT_START’ undeclared (first > use in this function); did you mean ‘XEN_VIRT_START’? > 33 | vm_init_type(VMAP_DEFAULT, (void *)VMAP_VIRT_START, > arch_vmap_virt_end()); > | ^~~~~~~~~~~~~~~ > | XEN_VIRT_START > ``` Perhaps, but that doesn't mean the #ifdef-ary here is the only solution. I'm afraid the approach so far doesn't really make clear in what overall direction you want to move. Possibly it may help if you split the patch ... Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 04 12:22:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 12:22:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558315.872294 (Exim 4.92) (envelope-from ) id 1qGf36-0005tu-2G; Tue, 04 Jul 2023 12:22:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558315.872294; Tue, 04 Jul 2023 12:22:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGf35-0005tl-VY; Tue, 04 Jul 2023 12:22:27 +0000 Received: by outflank-mailman (input) for mailman id 558315; Tue, 04 Jul 2023 12:22:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGf35-0005t9-9N for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 12:22:27 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6f9381a9-1a65-11ee-b237-6b7b168915f2; Tue, 04 Jul 2023 14:22:26 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CDD3B2286C; Tue, 4 Jul 2023 12:22:25 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BEE0C1346D; Tue, 4 Jul 2023 12:22:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id oTSYLgEPpGQiMAAAMHmgww (envelope-from ); Tue, 04 Jul 2023 12:22:25 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id BE7FCA076A; Tue, 4 Jul 2023 14:22:24 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f9381a9-1a65-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1688473345; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hgWYBTc++URz0W+hLmtIO2nNo8AlYvCPUKETELAc3VA=; b=Qb8anpmyKDSQIxGdg521F20mvfMC85y7fzDTXZrkbM4kzYIjv6aKCn3+xbBD3uMQAajUVZ ugyze9xSihFwzhyBjK9gTL4nkTBbHLDd8zhmdp+o//HY5cZXbMyHPJYuKF4t+E7uXZXBWk bzG6bgm1wZDOefw3O4jnuwhDQ54k2TQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1688473345; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hgWYBTc++URz0W+hLmtIO2nNo8AlYvCPUKETELAc3VA=; b=ZR980NIdJUvOgrooVYbDv5bR5vhnyt3H0wWgJQoutm98q8+Ipj1LRpoze+6fCWg9Vd/n9b ryyZ0+WIjeGdC1DQ== From: Jan Kara To: Cc: , Jens Axboe , Christoph Hellwig , Jan Kara , xen-devel@lists.xenproject.org Subject: [PATCH 08/32] xen/blkback: Convert to blkdev_get_handle_by_dev() Date: Tue, 4 Jul 2023 14:21:35 +0200 Message-Id: <20230704122224.16257-8-jack@suse.cz> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230629165206.383-1-jack@suse.cz> References: <20230629165206.383-1-jack@suse.cz> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=6173; i=jack@suse.cz; h=from:subject; bh=3hrSb/NISdZPkfHN0I6heP9od+4nmfsdU94X3qv9uDU=; b=owEBbQGS/pANAwAIAZydqgc/ZEDZAcsmYgBkpA7RR4iuVgQ5/lWBtD1QxcWJDsuRZvmWrM/HrPO3 7WExI7GJATMEAAEIAB0WIQSrWdEr1p4yirVVKBycnaoHP2RA2QUCZKQO0QAKCRCcnaoHP2RA2cvGCA Dwim+pDfkemEhFzpm2L4wLqfBTx4bmS+KKKMfrEk8oI7WpFaN4BNg9wKzjIx9e7dom5/NTl2rlRRoq Fu5ZAdFMNskCr8HqswKb/EBn9jfGiRc0tKl9WgB5yrt1FB/Yg17cND+9wPa6KRNCcRXGqJtiw1tF32 o2xKYjfzwE4IJ2S2LNsMQgNEYShri/W2cmEZJTvP4ruTzu2fxFV4NxMshZXFRXm7S30+SKJAEIjjka HnJyzn3ca/m/XDuod5OlVaKPrQbAVvSpY2PaPTEBQcbeuhCcYet6PUb3lg/8ztrJ2754ftD7v9nQF7 U3W2HOS6k97KWMr3RtNouYeHsPNIj8 X-Developer-Key: i=jack@suse.cz; a=openpgp; fpr=93C6099A142276A28BBE35D815BC833443038D8C Content-Transfer-Encoding: 8bit Convert xen/blkback to use blkdev_get_handle_by_dev() and pass the handle around. CC: xen-devel@lists.xenproject.org Signed-off-by: Jan Kara --- drivers/block/xen-blkback/blkback.c | 4 +-- drivers/block/xen-blkback/common.h | 4 +-- drivers/block/xen-blkback/xenbus.c | 40 +++++++++++++++-------------- 3 files changed, 25 insertions(+), 23 deletions(-) diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c index c362f4ad80ab..4defd7f387c7 100644 --- a/drivers/block/xen-blkback/blkback.c +++ b/drivers/block/xen-blkback/blkback.c @@ -465,7 +465,7 @@ static int xen_vbd_translate(struct phys_req *req, struct xen_blkif *blkif, } req->dev = vbd->pdevice; - req->bdev = vbd->bdev; + req->bdev = vbd->bdev_handle->bdev; rc = 0; out: @@ -969,7 +969,7 @@ static int dispatch_discard_io(struct xen_blkif_ring *ring, int err = 0; int status = BLKIF_RSP_OKAY; struct xen_blkif *blkif = ring->blkif; - struct block_device *bdev = blkif->vbd.bdev; + struct block_device *bdev = blkif->vbd.bdev_handle->bdev; struct phys_req preq; xen_blkif_get(blkif); diff --git a/drivers/block/xen-blkback/common.h b/drivers/block/xen-blkback/common.h index 40f67bfc052d..5ff50e76cee5 100644 --- a/drivers/block/xen-blkback/common.h +++ b/drivers/block/xen-blkback/common.h @@ -221,7 +221,7 @@ struct xen_vbd { unsigned char type; /* phys device that this vbd maps to. */ u32 pdevice; - struct block_device *bdev; + struct bdev_handle *bdev_handle; /* Cached size parameter. */ sector_t size; unsigned int flush_support:1; @@ -360,7 +360,7 @@ struct pending_req { }; -#define vbd_sz(_v) bdev_nr_sectors((_v)->bdev) +#define vbd_sz(_v) bdev_nr_sectors((_v)->bdev_handle->bdev) #define xen_blkif_get(_b) (atomic_inc(&(_b)->refcnt)) #define xen_blkif_put(_b) \ diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c index bb66178c432b..b67d28584c72 100644 --- a/drivers/block/xen-blkback/xenbus.c +++ b/drivers/block/xen-blkback/xenbus.c @@ -81,7 +81,7 @@ static void xen_update_blkif_status(struct xen_blkif *blkif) int i; /* Not ready to connect? */ - if (!blkif->rings || !blkif->rings[0].irq || !blkif->vbd.bdev) + if (!blkif->rings || !blkif->rings[0].irq || !blkif->vbd.bdev_handle) return; /* Already connected? */ @@ -99,12 +99,13 @@ static void xen_update_blkif_status(struct xen_blkif *blkif) return; } - err = sync_blockdev(blkif->vbd.bdev); + err = sync_blockdev(blkif->vbd.bdev_handle->bdev); if (err) { xenbus_dev_error(blkif->be->dev, err, "block flush"); return; } - invalidate_inode_pages2(blkif->vbd.bdev->bd_inode->i_mapping); + invalidate_inode_pages2( + blkif->vbd.bdev_handle->bdev->bd_inode->i_mapping); for (i = 0; i < blkif->nr_rings; i++) { ring = &blkif->rings[i]; @@ -472,9 +473,9 @@ static void xenvbd_sysfs_delif(struct xenbus_device *dev) static void xen_vbd_free(struct xen_vbd *vbd) { - if (vbd->bdev) - blkdev_put(vbd->bdev, NULL); - vbd->bdev = NULL; + if (vbd->bdev_handle) + blkdev_handle_put(vbd->bdev_handle); + vbd->bdev_handle = NULL; } static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle, @@ -482,7 +483,7 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle, int cdrom) { struct xen_vbd *vbd; - struct block_device *bdev; + struct bdev_handle *bdev_handle; vbd = &blkif->vbd; vbd->handle = handle; @@ -491,17 +492,17 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle, vbd->pdevice = MKDEV(major, minor); - bdev = blkdev_get_by_dev(vbd->pdevice, vbd->readonly ? + bdev_handle = blkdev_get_handle_by_dev(vbd->pdevice, vbd->readonly ? BLK_OPEN_READ : BLK_OPEN_WRITE, NULL, NULL); - if (IS_ERR(bdev)) { + if (IS_ERR(bdev_handle)) { pr_warn("xen_vbd_create: device %08x could not be opened\n", vbd->pdevice); return -ENOENT; } - vbd->bdev = bdev; - if (vbd->bdev->bd_disk == NULL) { + vbd->bdev_handle = bdev_handle; + if (vbd->bdev_handle->bdev->bd_disk == NULL) { pr_warn("xen_vbd_create: device %08x doesn't exist\n", vbd->pdevice); xen_vbd_free(vbd); @@ -509,14 +510,14 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle, } vbd->size = vbd_sz(vbd); - if (cdrom || disk_to_cdi(vbd->bdev->bd_disk)) + if (cdrom || disk_to_cdi(vbd->bdev_handle->bdev->bd_disk)) vbd->type |= VDISK_CDROM; - if (vbd->bdev->bd_disk->flags & GENHD_FL_REMOVABLE) + if (vbd->bdev_handle->bdev->bd_disk->flags & GENHD_FL_REMOVABLE) vbd->type |= VDISK_REMOVABLE; - if (bdev_write_cache(bdev)) + if (bdev_write_cache(bdev_handle->bdev)) vbd->flush_support = true; - if (bdev_max_secure_erase_sectors(bdev)) + if (bdev_max_secure_erase_sectors(bdev_handle->bdev)) vbd->discard_secure = true; pr_debug("Successful creation of handle=%04x (dom=%u)\n", @@ -569,7 +570,7 @@ static void xen_blkbk_discard(struct xenbus_transaction xbt, struct backend_info struct xen_blkif *blkif = be->blkif; int err; int state = 0; - struct block_device *bdev = be->blkif->vbd.bdev; + struct block_device *bdev = be->blkif->vbd.bdev_handle->bdev; if (!xenbus_read_unsigned(dev->nodename, "discard-enable", 1)) return; @@ -930,15 +931,16 @@ static void connect(struct backend_info *be) goto abort; } err = xenbus_printf(xbt, dev->nodename, "sector-size", "%lu", - (unsigned long) - bdev_logical_block_size(be->blkif->vbd.bdev)); + (unsigned long)bdev_logical_block_size( + be->blkif->vbd.bdev_handle->bdev)); if (err) { xenbus_dev_fatal(dev, err, "writing %s/sector-size", dev->nodename); goto abort; } err = xenbus_printf(xbt, dev->nodename, "physical-sector-size", "%u", - bdev_physical_block_size(be->blkif->vbd.bdev)); + bdev_physical_block_size( + be->blkif->vbd.bdev_handle->bdev)); if (err) xenbus_dev_error(dev, err, "writing %s/physical-sector-size", dev->nodename); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Jul 04 12:22:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 12:22:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558316.872304 (Exim 4.92) (envelope-from ) id 1qGf37-00069V-D9; Tue, 04 Jul 2023 12:22:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558316.872304; Tue, 04 Jul 2023 12:22:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGf37-00069K-A8; Tue, 04 Jul 2023 12:22:29 +0000 Received: by outflank-mailman (input) for mailman id 558316; Tue, 04 Jul 2023 12:22:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGf36-0005tk-5R for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 12:22:28 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6f3d5dd0-1a65-11ee-8611-37d641c3527e; Tue, 04 Jul 2023 14:22:25 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 37C1422864; Tue, 4 Jul 2023 12:22:25 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1D4941346D; Tue, 4 Jul 2023 12:22:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id j8gfBwEPpGQFMAAAMHmgww (envelope-from ); Tue, 04 Jul 2023 12:22:25 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 915DAA0722; Tue, 4 Jul 2023 14:22:24 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f3d5dd0-1a65-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1688473345; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=fmLTdco5SVuopuSHDbZ7fgiCJT9fmPtnstwBD5O0cVs=; b=LYS1cAt6t7JDeaXCZA2GfkFsvePsCKrBv683wLJKbeQdnB0RB5kex3lpjPlaO0WNrRIj/p OKov+tjGtn08tmzrJU88unG7OZdlwokmKgdGkl+OG4epxE3GA77hqhJZhG3Z0dN3YI1cPw 0UrvrW8qrgzkAVKwdQJPDUFGAz/meEU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1688473345; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=fmLTdco5SVuopuSHDbZ7fgiCJT9fmPtnstwBD5O0cVs=; b=Dse69eRRr1j+O/QtQVzrTyIAnqxKgXzcDp3QAv4KDKTfaZG4HjcsXtXKNaEGDfzmeYyIxx WQrcOQN123NhV6Dg== From: Jan Kara To: Cc: , Jens Axboe , Christoph Hellwig , Jan Kara , Alasdair Kergon , Andrew Morton , Anna Schumaker , Chao Yu , Christian Borntraeger , "Darrick J. Wong" , Dave Kleikamp , David Sterba , dm-devel@redhat.com, drbd-dev@lists.linbit.com, Gao Xiang , Jack Wang , Jaegeuk Kim , jfs-discussion@lists.sourceforge.net, Joern Engel , Joseph Qi , Kent Overstreet , linux-bcache@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-nvme@lists.infradead.org, linux-pm@vger.kernel.org, linux-raid@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-xfs@vger.kernel.org, "Md. Haris Iqbal" , Mike Snitzer , Minchan Kim , ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, Sergey Senozhatsky , Song Liu , Sven Schnelle , target-devel@vger.kernel.org, Ted Tso , Trond Myklebust , xen-devel@lists.xenproject.org Subject: [PATCH RFC 0/32] block: Make blkdev_get_by_*() return handle Date: Tue, 4 Jul 2023 14:21:27 +0200 Message-Id: <20230629165206.383-1-jack@suse.cz> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2471; i=jack@suse.cz; h=from:subject:message-id; bh=ceZQTtdZjpsFiBb9Fva7YX0lOa2i6Zx53n9hl/3+KQM=; b=owEBbQGS/pANAwAIAZydqgc/ZEDZAcsmYgBkpA7DYrlV/5vfqjK0juEsCaKDoUZ39z4YDWexB9PO aQyP7ZaJATMEAAEIAB0WIQSrWdEr1p4yirVVKBycnaoHP2RA2QUCZKQOwwAKCRCcnaoHP2RA2S48B/ 476l3pggtn8igKmRoHswxXv63Ks68g/08HDzIZqCtDPA84BSKd93Nq0m/Wn76G+ubHQpfg8PMw5+DG uV+DOTR+NEYKAToQQ8YzmS6RAGasKKWUg3k1pr7jK23l+wcq16ImmBXmWM3nr2j85QcDZeB+vpUKHh bdQJQsBOqKsA+qlImgVwvMS+V4UTLQcIYQo2bDBl0TIbJB0UiXYMYHcvrEkwNZWybXBs+wfERrXuF1 XlXO6rWvLyW94kkpvaZTvPY+yZd7tOLd+W8gsz2uBFG9QJg57aDkZxf6NA+Qxf2O8uwfWiyb1XXBN8 I1wYA/sSduibCw4tF4sYb/wERvIAO+ X-Developer-Key: i=jack@suse.cz; a=openpgp; fpr=93C6099A142276A28BBE35D815BC833443038D8C Content-Transfer-Encoding: 8bit Hello, this patch series implements the idea of blkdev_get_by_*() calls returning bdev_handle which is then passed to blkdev_put() [1]. This makes the get and put calls for bdevs more obviously matching and allows us to propagate context from get to put without having to modify all the users (again!). In particular I need to propagate used open flags to blkdev_put() to be able count writeable opens and add support for blocking writes to mounted block devices. I'll send that series separately. The series is based on Linus' tree as of yesterday + two bcache fixes which are in the block tree. Patches have passed some basic testing, I plan to test more users once we agree this is the right way to go. Honza [1] https://lore.kernel.org/all/ZJGNsVDhZx0Xgs2H@infradead.org CC: Alasdair Kergon CC: Andrew Morton CC: Anna Schumaker CC: Chao Yu CC: Christian Borntraeger CC: Coly Li CC: Dave Kleikamp CC: David Sterba CC: dm-devel@redhat.com CC: drbd-dev@lists.linbit.com CC: Gao Xiang CC: Jack Wang CC: Jaegeuk Kim CC: jfs-discussion@lists.sourceforge.net CC: Joern Engel CC: Joseph Qi CC: Kent Overstreet CC: linux-bcache@vger.kernel.org CC: linux-btrfs@vger.kernel.org CC: linux-erofs@lists.ozlabs.org CC: CC: linux-f2fs-devel@lists.sourceforge.net CC: linux-mm@kvack.org CC: linux-mtd@lists.infradead.org CC: linux-nfs@vger.kernel.org CC: linux-nilfs@vger.kernel.org CC: linux-nvme@lists.infradead.org CC: linux-pm@vger.kernel.org CC: linux-raid@vger.kernel.org CC: linux-s390@vger.kernel.org CC: linux-scsi@vger.kernel.org CC: linux-xfs@vger.kernel.org CC: "Md. Haris Iqbal" CC: Mike Snitzer CC: Minchan Kim CC: ocfs2-devel@oss.oracle.com CC: reiserfs-devel@vger.kernel.org CC: Sergey Senozhatsky CC: Song Liu CC: Sven Schnelle CC: target-devel@vger.kernel.org CC: Ted Tso CC: Trond Myklebust CC: xen-devel@lists.xenproject.org From xen-devel-bounces@lists.xenproject.org Tue Jul 04 12:22:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 12:22:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558317.872314 (Exim 4.92) (envelope-from ) id 1qGf38-0006Pc-MD; Tue, 04 Jul 2023 12:22:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558317.872314; Tue, 04 Jul 2023 12:22:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGf38-0006PR-Ig; Tue, 04 Jul 2023 12:22:30 +0000 Received: by outflank-mailman (input) for mailman id 558317; Tue, 04 Jul 2023 12:22:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGf36-0005tk-Ro for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 12:22:28 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6f7fed8e-1a65-11ee-8611-37d641c3527e; Tue, 04 Jul 2023 14:22:26 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5D9E422868; Tue, 4 Jul 2023 12:22:25 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 433C713A97; Tue, 4 Jul 2023 12:22:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id fiTSDwEPpGQQMAAAMHmgww (envelope-from ); Tue, 04 Jul 2023 12:22:25 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 97B9EA0763; Tue, 4 Jul 2023 14:22:24 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f7fed8e-1a65-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1688473345; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y5Z0PpLwK7LWiMwHAJV3g58wt4Pu7/r/oCMflfsspxI=; b=Yfx9ztWkVatt0fVfNPxdamFDjV837Nu56ImHpS3yWvwdcdXXyeJ1ONnOd+6RA+xJckyxi2 Fr1h4BOlDMHKk2yJxxmlop9vtybjvkzPRI8sOxjaR75gWlVSNQjeXkVo/sHlsqPbUV+LJG uG3Fi84JhxR4KPvRm9XoLJxwd0lLAD0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1688473345; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y5Z0PpLwK7LWiMwHAJV3g58wt4Pu7/r/oCMflfsspxI=; b=vF6CF3OlMOzmEcsCihpnKLEsv6y6u4duYbSxFgbJ4TrA9OaJnML/9G2T1z6YHtiVQ3zwq6 zVCIM6qtTQOYAOBg== From: Jan Kara To: Cc: , Jens Axboe , Christoph Hellwig , Jan Kara , Alasdair Kergon , Andrew Morton , Anna Schumaker , Chao Yu , Christian Borntraeger , "Darrick J. Wong" , Dave Kleikamp , David Sterba , dm-devel@redhat.com, drbd-dev@lists.linbit.com, Gao Xiang , Jack Wang , Jaegeuk Kim , jfs-discussion@lists.sourceforge.net, Joern Engel , Joseph Qi , Kent Overstreet , linux-bcache@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-nvme@lists.infradead.org, linux-pm@vger.kernel.org, linux-raid@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-xfs@vger.kernel.org, "Md. Haris Iqbal" , Mike Snitzer , Minchan Kim , ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, Sergey Senozhatsky , Song Liu , Sven Schnelle , target-devel@vger.kernel.org, Ted Tso , Trond Myklebust , xen-devel@lists.xenproject.org Subject: [PATCH 01/32] block: Provide blkdev_get_handle_* functions Date: Tue, 4 Jul 2023 14:21:28 +0200 Message-Id: <20230704122224.16257-1-jack@suse.cz> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230629165206.383-1-jack@suse.cz> References: <20230629165206.383-1-jack@suse.cz> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=5599; i=jack@suse.cz; h=from:subject; bh=repJSb0/C5PfG8Cx5q/n/kNJZOabhc2tYWxiICNNTtg=; b=owGbwMvMwME4Z+4qdvsUh5uMp9WSGFKW8J3uuK2gorZt+knOzhX81snTGX/57phWXzfXM3w+50Xl rfb7OxmNWRgYORhkxRRZVkde1L42z6hra6iGDMwgViaQKQxcnAIwERsLDobphetsJoi99quKYIut26 wgv/K+lUS+secym02t85epsOp8rtu3acJMN1WFRiX1irKCnSu+LXh+rVyp65RAEGttl+XcP32mOR0n ZJYFm7orF8YFnhVftYzZjm2Rva3I0oqXdap/bUJr8qNjVVfHnBRiFEv0Ocgpck1jlTHfEWUu71NrKu 8EXrbnsfD7wm1qKHDqnnnD21y1n9OFHn8/7qJz4O19panPLvMxrOrNn970IcH6rnhQsq0ZS1v6JUfN RS5ah5XMXNI/c14+vVlVkPVI9n2HQNZlEfdsO13VFx17Z7f0vKnN9UZZ3Zii6WbsWS81/qefFs1Ljl +dK1sZIpSRdXfx+jksz9T4il4AAA== X-Developer-Key: i=jack@suse.cz; a=openpgp; fpr=93C6099A142276A28BBE35D815BC833443038D8C Content-Transfer-Encoding: 8bit Create struct bdev_handle that contains all parameters that need to be passed to blkdev_put() and provide blkdev_get_handle_* functions that return this structure instead of plain bdev pointer. This will eventually allow us to pass one more argument to blkdev_put() without too much hassle. CC: Alasdair Kergon CC: Andrew Morton CC: Anna Schumaker CC: Chao Yu CC: Christian Borntraeger CC: Coly Li CC: Dave Kleikamp CC: David Sterba CC: dm-devel@redhat.com CC: drbd-dev@lists.linbit.com CC: Gao Xiang CC: Jack Wang CC: Jaegeuk Kim CC: jfs-discussion@lists.sourceforge.net CC: Joern Engel CC: Joseph Qi CC: Kent Overstreet CC: linux-bcache@vger.kernel.org CC: linux-btrfs@vger.kernel.org CC: linux-erofs@lists.ozlabs.org CC: CC: linux-f2fs-devel@lists.sourceforge.net CC: linux-mm@kvack.org CC: linux-mtd@lists.infradead.org CC: linux-nfs@vger.kernel.org CC: linux-nilfs@vger.kernel.org CC: linux-nvme@lists.infradead.org CC: linux-pm@vger.kernel.org CC: linux-raid@vger.kernel.org CC: linux-s390@vger.kernel.org CC: linux-scsi@vger.kernel.org CC: linux-xfs@vger.kernel.org CC: "Md. Haris Iqbal" CC: Mike Snitzer CC: Minchan Kim CC: ocfs2-devel@oss.oracle.com CC: reiserfs-devel@vger.kernel.org CC: Sergey Senozhatsky CC: Song Liu CC: Sven Schnelle CC: target-devel@vger.kernel.org CC: Ted Tso CC: Trond Myklebust CC: xen-devel@lists.xenproject.org Signed-off-by: Jan Kara --- block/bdev.c | 47 ++++++++++++++++++++++++++++++++++++++++++ include/linux/blkdev.h | 10 +++++++++ 2 files changed, 57 insertions(+) diff --git a/block/bdev.c b/block/bdev.c index 979e28a46b98..c75de5cac2bc 100644 --- a/block/bdev.c +++ b/block/bdev.c @@ -846,6 +846,24 @@ struct block_device *blkdev_get_by_dev(dev_t dev, blk_mode_t mode, void *holder, } EXPORT_SYMBOL(blkdev_get_by_dev); +struct bdev_handle *blkdev_get_handle_by_dev(dev_t dev, blk_mode_t mode, + void *holder, const struct blk_holder_ops *hops) +{ + struct bdev_handle *handle = kmalloc(sizeof(struct bdev_handle), + GFP_KERNEL); + struct block_device *bdev; + + if (!handle) + return ERR_PTR(-ENOMEM); + bdev = blkdev_get_by_dev(dev, mode, holder, hops); + if (IS_ERR(bdev)) + return ERR_CAST(bdev); + handle->bdev = bdev; + handle->holder = holder; + return handle; +} +EXPORT_SYMBOL(blkdev_get_handle_by_dev); + /** * blkdev_get_by_path - open a block device by name * @path: path to the block device to open @@ -884,6 +902,28 @@ struct block_device *blkdev_get_by_path(const char *path, blk_mode_t mode, } EXPORT_SYMBOL(blkdev_get_by_path); +struct bdev_handle *blkdev_get_handle_by_path(const char *path, blk_mode_t mode, + void *holder, const struct blk_holder_ops *hops) +{ + struct bdev_handle *handle; + dev_t dev; + int error; + + error = lookup_bdev(path, &dev); + if (error) + return ERR_PTR(error); + + handle = blkdev_get_handle_by_dev(dev, mode, holder, hops); + if (!IS_ERR(handle) && (mode & BLK_OPEN_WRITE) && + bdev_read_only(handle->bdev)) { + blkdev_handle_put(handle); + return ERR_PTR(-EACCES); + } + + return handle; +} +EXPORT_SYMBOL(blkdev_get_handle_by_path); + void blkdev_put(struct block_device *bdev, void *holder) { struct gendisk *disk = bdev->bd_disk; @@ -920,6 +960,13 @@ void blkdev_put(struct block_device *bdev, void *holder) } EXPORT_SYMBOL(blkdev_put); +void blkdev_handle_put(struct bdev_handle *handle) +{ + blkdev_put(handle->bdev, handle->holder); + kfree(handle); +} +EXPORT_SYMBOL(blkdev_handle_put); + /** * lookup_bdev() - Look up a struct block_device by name. * @pathname: Name of the block device in the filesystem. diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index ed44a997f629..a910e9997ddd 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -1471,14 +1471,24 @@ struct blk_holder_ops { #define sb_open_mode(flags) \ (BLK_OPEN_READ | (((flags) & SB_RDONLY) ? 0 : BLK_OPEN_WRITE)) +struct bdev_handle { + struct block_device *bdev; + void *holder; +}; + struct block_device *blkdev_get_by_dev(dev_t dev, blk_mode_t mode, void *holder, const struct blk_holder_ops *hops); struct block_device *blkdev_get_by_path(const char *path, blk_mode_t mode, void *holder, const struct blk_holder_ops *hops); +struct bdev_handle *blkdev_get_handle_by_dev(dev_t dev, blk_mode_t mode, + void *holder, const struct blk_holder_ops *hops); +struct bdev_handle *blkdev_get_handle_by_path(const char *path, blk_mode_t mode, + void *holder, const struct blk_holder_ops *hops); int bd_prepare_to_claim(struct block_device *bdev, void *holder, const struct blk_holder_ops *hops); void bd_abort_claiming(struct block_device *bdev, void *holder); void blkdev_put(struct block_device *bdev, void *holder); +void blkdev_handle_put(struct bdev_handle *handle); /* just for blk-cgroup, don't use elsewhere */ struct block_device *blkdev_get_no_open(dev_t dev); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Jul 04 12:22:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 12:22:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558318.872324 (Exim 4.92) (envelope-from ) id 1qGf3A-0006iQ-Vj; Tue, 04 Jul 2023 12:22:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558318.872324; Tue, 04 Jul 2023 12:22:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGf3A-0006iF-Rc; Tue, 04 Jul 2023 12:22:32 +0000 Received: by outflank-mailman (input) for mailman id 558318; Tue, 04 Jul 2023 12:22:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGf38-0005tk-Oc for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 12:22:31 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 704f3b1d-1a65-11ee-8611-37d641c3527e; Tue, 04 Jul 2023 14:22:27 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0DABB20572; Tue, 4 Jul 2023 12:22:27 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id ABAF1139ED; Tue, 4 Jul 2023 12:22:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KsLiKQIPpGRjMAAAMHmgww (envelope-from ); Tue, 04 Jul 2023 12:22:26 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 59701A078D; Tue, 4 Jul 2023 14:22:25 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 704f3b1d-1a65-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1688473347; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mjuMHjhognYm/jp+4laDSDXEVfZVsA6D5XD84KVXIlM=; b=IfhkJf/r3YX79abK//kvxzsfxO8GBec3aFCgZUqKe4njAdibvh5nuXvRT9veRG5W0AjJWZ xkZTl1aaAGPgSVyAjWvo8s6nnqwhJ0ZaLpuEG69dT5keFHsUoEFpqPkzUx9qP0BhNBbooO p9QUcEDucrmYuqaoHoaI7BQaQFfMU7A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1688473347; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mjuMHjhognYm/jp+4laDSDXEVfZVsA6D5XD84KVXIlM=; b=L7ND2oVd/Fq2jDo7ljy5nF8o5bZWHZeR62gf2Xk9TE6mFJugTr7RIk/BG29uxhMgM00XlI Bt3Mp4tdxZ9r7HCg== From: Jan Kara To: Cc: , Jens Axboe , Christoph Hellwig , Jan Kara , Alasdair Kergon , Andrew Morton , Anna Schumaker , Chao Yu , Christian Borntraeger , "Darrick J. Wong" , Dave Kleikamp , David Sterba , dm-devel@redhat.com, drbd-dev@lists.linbit.com, Gao Xiang , Jack Wang , Jaegeuk Kim , jfs-discussion@lists.sourceforge.net, Joern Engel , Joseph Qi , Kent Overstreet , linux-bcache@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-nvme@lists.infradead.org, linux-pm@vger.kernel.org, linux-raid@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-xfs@vger.kernel.org, "Md. Haris Iqbal" , Mike Snitzer , Minchan Kim , ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, Sergey Senozhatsky , Song Liu , Sven Schnelle , target-devel@vger.kernel.org, Ted Tso , Trond Myklebust , xen-devel@lists.xenproject.org Subject: [PATCH 32/32] block: Rename blkdev_get_handle_by_*() and blkdev_handle_put() Date: Tue, 4 Jul 2023 14:21:59 +0200 Message-Id: <20230704122224.16257-32-jack@suse.cz> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230629165206.383-1-jack@suse.cz> References: <20230629165206.383-1-jack@suse.cz> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=52534; i=jack@suse.cz; h=from:subject; bh=V4VQzqtLPzebd9elTihpjhZGahpeEhAZnI7QsWZdPe4=; b=owEBbQGS/pANAwAIAZydqgc/ZEDZAcsmYgBkpA7mNc8ek6WBAiDfxElNQMWOHzv9hYYvjHN3eTqG Gc6z8KeJATMEAAEIAB0WIQSrWdEr1p4yirVVKBycnaoHP2RA2QUCZKQO5gAKCRCcnaoHP2RA2TWdB/ 4/tliM0M2A91liOZmHDiXajUGkW4GFvo5u3EtWLBTnoITi1cexbp98BuZsmF37Cwcua38PpwNGdNvC LjevVeWqas0lSaFPJpuEMGUAzkFn4nUF9yXneLyjoILCiV1OdKQNkZRO/tJaC8ntEgkrITOiw/+Z+s 7BqpGpN/dsEGe2ND8MR1y/Zxq99oQJfHMdrtpkdg6JooqUQ7d8jiMehC0ZRkkIrhmi/l6R533RJqXL o2pkFrxgsYDkpHv/Pc7FZA3/rq2WoCPTsRqLDPl1um222jRi2sYUcgPbtMy/oAC1WeVRFT1RFUEA3V nUZ6UiuuDjVfhIUnPyhZWutX8t6+Xs X-Developer-Key: i=jack@suse.cz; a=openpgp; fpr=93C6099A142276A28BBE35D815BC833443038D8C Content-Transfer-Encoding: 8bit Now that everybody is converted, we can rename blkdev_get_handle_by_*() and blkdev_handle_put() back to their original names. No functional change. Done by Coccinelle patch: @@ expression dev, mode, holder, hops; @@ - blkdev_get_handle_by_dev(dev, mode, holder, hops) + blkdev_get_by_dev(dev, mode, holder, hops) @@ expression path, mode, holder, hops; @@ - blkdev_get_handle_by_path(path, mode, holder, hops) + blkdev_get_by_path(path, mode, holder, hops) @@ expression handle; @@ - blkdev_handle_put(handle) + blkdev_put(handle) plus manual updates of comments, strings, and function declarations itself. CC: Alasdair Kergon CC: Andrew Morton CC: Anna Schumaker CC: Chao Yu CC: Christian Borntraeger CC: Coly Li CC: Dave Kleikamp CC: David Sterba CC: dm-devel@redhat.com CC: drbd-dev@lists.linbit.com CC: Gao Xiang CC: Jack Wang CC: Jaegeuk Kim CC: jfs-discussion@lists.sourceforge.net CC: Joern Engel CC: Joseph Qi CC: Kent Overstreet CC: linux-bcache@vger.kernel.org CC: linux-btrfs@vger.kernel.org CC: linux-erofs@lists.ozlabs.org CC: CC: linux-f2fs-devel@lists.sourceforge.net CC: linux-mm@kvack.org CC: linux-mtd@lists.infradead.org CC: linux-nfs@vger.kernel.org CC: linux-nilfs@vger.kernel.org CC: linux-nvme@lists.infradead.org CC: linux-pm@vger.kernel.org CC: linux-raid@vger.kernel.org CC: linux-s390@vger.kernel.org CC: linux-scsi@vger.kernel.org CC: linux-xfs@vger.kernel.org CC: "Md. Haris Iqbal" CC: Mike Snitzer CC: Minchan Kim CC: ocfs2-devel@oss.oracle.com CC: reiserfs-devel@vger.kernel.org CC: Sergey Senozhatsky CC: Song Liu CC: Sven Schnelle CC: target-devel@vger.kernel.org CC: Ted Tso CC: Trond Myklebust CC: xen-devel@lists.xenproject.org Signed-off-by: Jan Kara --- block/bdev.c | 24 +++++++++--------- block/fops.c | 6 ++--- block/genhd.c | 6 ++--- block/ioctl.c | 4 +-- drivers/block/drbd/drbd_nl.c | 10 ++++---- drivers/block/pktcdvd.c | 18 +++++++------- drivers/block/rnbd/rnbd-srv.c | 7 +++--- drivers/block/xen-blkback/xenbus.c | 7 +++--- drivers/block/zram/zram_drv.c | 9 ++++--- drivers/md/bcache/super.c | 23 ++++++++--------- drivers/md/dm.c | 6 ++--- drivers/md/md.c | 11 +++++---- drivers/mtd/devices/block2mtd.c | 7 +++--- drivers/nvme/target/io-cmd-bdev.c | 7 +++--- drivers/s390/block/dasd_genhd.c | 20 +++++++-------- drivers/target/target_core_iblock.c | 8 +++--- drivers/target/target_core_pscsi.c | 11 +++++---- fs/btrfs/dev-replace.c | 6 ++--- fs/btrfs/ioctl.c | 4 +-- fs/btrfs/volumes.c | 31 ++++++++++++----------- fs/erofs/super.c | 6 ++--- fs/ext4/super.c | 8 +++--- fs/f2fs/super.c | 15 +++++++----- fs/jfs/jfs_logmgr.c | 9 ++++--- fs/nfs/blocklayout/dev.c | 13 +++++----- fs/nilfs2/super.c | 8 +++--- fs/ocfs2/cluster/heartbeat.c | 10 ++++---- fs/reiserfs/journal.c | 10 ++++---- fs/super.c | 38 ++++++++++++++--------------- fs/xfs/xfs_super.c | 6 ++--- include/linux/blkdev.h | 8 +++--- kernel/power/swap.c | 15 ++++++------ mm/swapfile.c | 9 ++++--- 33 files changed, 194 insertions(+), 186 deletions(-) diff --git a/block/bdev.c b/block/bdev.c index 0423495fe5ac..523ea7289834 100644 --- a/block/bdev.c +++ b/block/bdev.c @@ -746,7 +746,7 @@ void blkdev_put_no_open(struct block_device *bdev) } /** - * blkdev_get_handle_by_dev - open a block device by device number + * blkdev_get_by_dev - open a block device by device number * @dev: device number of block device to open * @mode: open mode (BLK_OPEN_*) * @holder: exclusive holder identifier @@ -758,7 +758,7 @@ void blkdev_put_no_open(struct block_device *bdev) * * Use this interface ONLY if you really do not have anything better - i.e. when * you are behind a truly sucky interface and all you are given is a device - * number. Everything else should use blkdev_get_handle_by_path(). + * number. Everything else should use blkdev_get_by_path(). * * CONTEXT: * Might sleep. @@ -767,8 +767,8 @@ void blkdev_put_no_open(struct block_device *bdev) * Handle with a reference to the block_device on success, ERR_PTR(-errno) on * failure. */ -struct bdev_handle *blkdev_get_handle_by_dev(dev_t dev, blk_mode_t mode, - void *holder, const struct blk_holder_ops *hops) +struct bdev_handle *blkdev_get_by_dev(dev_t dev, blk_mode_t mode, void *holder, + const struct blk_holder_ops *hops) { struct bdev_handle *handle = kmalloc(sizeof(struct bdev_handle), GFP_KERNEL); @@ -856,10 +856,10 @@ struct bdev_handle *blkdev_get_handle_by_dev(dev_t dev, blk_mode_t mode, kfree(handle); return ERR_PTR(ret); } -EXPORT_SYMBOL(blkdev_get_handle_by_dev); +EXPORT_SYMBOL(blkdev_get_by_dev); /** - * blkdev_get_handle_by_path - open a block device by name + * blkdev_get_by_path - open a block device by name * @path: path to the block device to open * @mode: open mode (BLK_OPEN_*) * @holder: exclusive holder identifier @@ -876,7 +876,7 @@ EXPORT_SYMBOL(blkdev_get_handle_by_dev); * Handle with a reference to the block_device on success, ERR_PTR(-errno) on * failure. */ -struct bdev_handle *blkdev_get_handle_by_path(const char *path, blk_mode_t mode, +struct bdev_handle *blkdev_get_by_path(const char *path, blk_mode_t mode, void *holder, const struct blk_holder_ops *hops) { struct bdev_handle *handle; @@ -887,18 +887,18 @@ struct bdev_handle *blkdev_get_handle_by_path(const char *path, blk_mode_t mode, if (error) return ERR_PTR(error); - handle = blkdev_get_handle_by_dev(dev, mode, holder, hops); + handle = blkdev_get_by_dev(dev, mode, holder, hops); if (!IS_ERR(handle) && (mode & BLK_OPEN_WRITE) && bdev_read_only(handle->bdev)) { - blkdev_handle_put(handle); + blkdev_put(handle); return ERR_PTR(-EACCES); } return handle; } -EXPORT_SYMBOL(blkdev_get_handle_by_path); +EXPORT_SYMBOL(blkdev_get_by_path); -void blkdev_handle_put(struct bdev_handle *handle) +void blkdev_put(struct bdev_handle *handle) { struct block_device *bdev = handle->bdev; struct gendisk *disk = bdev->bd_disk; @@ -934,7 +934,7 @@ void blkdev_handle_put(struct bdev_handle *handle) blkdev_put_no_open(bdev); kfree(handle); } -EXPORT_SYMBOL(blkdev_handle_put); +EXPORT_SYMBOL(blkdev_put); /** * lookup_bdev() - Look up a struct block_device by name. diff --git a/block/fops.c b/block/fops.c index d7f3b6e67a2f..ba928b0edeb0 100644 --- a/block/fops.c +++ b/block/fops.c @@ -509,8 +509,8 @@ static int blkdev_open(struct inode *inode, struct file *filp) filp->f_mode |= FMODE_BUF_RASYNC; mode = file_to_blk_mode(filp); - handle = blkdev_get_handle_by_dev(inode->i_rdev, mode, - mode & BLK_OPEN_EXCL ? filp : NULL, NULL); + handle = blkdev_get_by_dev(inode->i_rdev, mode, + mode & BLK_OPEN_EXCL ? filp : NULL, NULL); if (IS_ERR(handle)) return PTR_ERR(handle); @@ -527,7 +527,7 @@ static int blkdev_open(struct inode *inode, struct file *filp) static int blkdev_release(struct inode *inode, struct file *filp) { - blkdev_handle_put(filp->private_data); + blkdev_put(filp->private_data); return 0; } diff --git a/block/genhd.c b/block/genhd.c index d363ddb8d93a..a09fca0af308 100644 --- a/block/genhd.c +++ b/block/genhd.c @@ -366,12 +366,12 @@ int disk_scan_partitions(struct gendisk *disk, blk_mode_t mode) } set_bit(GD_NEED_PART_SCAN, &disk->state); - handle = blkdev_get_handle_by_dev(disk_devt(disk), - mode & ~BLK_OPEN_EXCL, NULL, NULL); + handle = blkdev_get_by_dev(disk_devt(disk), mode & ~BLK_OPEN_EXCL, NULL, + NULL); if (IS_ERR(handle)) ret = PTR_ERR(handle); else - blkdev_handle_put(handle); + blkdev_put(handle); /* * If blkdev_get_by_dev() failed early, GD_NEED_PART_SCAN is still set, diff --git a/block/ioctl.c b/block/ioctl.c index 940a7b9284c4..96922830f908 100644 --- a/block/ioctl.c +++ b/block/ioctl.c @@ -470,11 +470,11 @@ static int blkdev_bszset(struct block_device *bdev, blk_mode_t mode, if (mode & BLK_OPEN_EXCL) return set_blocksize(bdev, n); - handle = blkdev_get_handle_by_dev(bdev->bd_dev, mode, &bdev, NULL); + handle = blkdev_get_by_dev(bdev->bd_dev, mode, &bdev, NULL); if (IS_ERR(handle)) return -EBUSY; ret = set_blocksize(bdev, n); - blkdev_handle_put(handle); + blkdev_put(handle); return ret; } diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c index 4a436a428e12..1f8b53468f0e 100644 --- a/drivers/block/drbd/drbd_nl.c +++ b/drivers/block/drbd/drbd_nl.c @@ -82,7 +82,7 @@ static atomic_t notify_genl_seq = ATOMIC_INIT(2); /* two. */ DEFINE_MUTEX(notification_mutex); -/* used blkdev_get_handle_by_path, to claim our meta data device(s) */ +/* used blkdev_get_by_path, to claim our meta data device(s) */ static char *drbd_m_holder = "Hands off! this is DRBD's meta data device."; static void drbd_adm_send_reply(struct sk_buff *skb, struct genl_info *info) @@ -1640,8 +1640,8 @@ static struct bdev_handle *open_backing_dev(struct drbd_device *device, struct bdev_handle *handle; int err = 0; - handle = blkdev_get_handle_by_path(bdev_path, - BLK_OPEN_READ | BLK_OPEN_WRITE, claim_ptr, NULL); + handle = blkdev_get_by_path(bdev_path, BLK_OPEN_READ | BLK_OPEN_WRITE, + claim_ptr, NULL); if (IS_ERR(handle)) { drbd_err(device, "open(\"%s\") failed with %ld\n", bdev_path, PTR_ERR(handle)); @@ -1653,7 +1653,7 @@ static struct bdev_handle *open_backing_dev(struct drbd_device *device, err = bd_link_disk_holder(handle->bdev, device->vdisk); if (err) { - blkdev_handle_put(handle); + blkdev_put(handle); drbd_err(device, "bd_link_disk_holder(\"%s\", ...) failed with %d\n", bdev_path, err); handle = ERR_PTR(err); @@ -1704,7 +1704,7 @@ static void close_backing_dev(struct drbd_device *device, return; if (do_bd_unlink) bd_unlink_disk_holder(handle->bdev, device->vdisk); - blkdev_handle_put(handle); + blkdev_put(handle); } void drbd_backing_dev_free(struct drbd_device *device, struct drbd_backing_dev *ldev) diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c index c50333ea9c75..924557408ed0 100644 --- a/drivers/block/pktcdvd.c +++ b/drivers/block/pktcdvd.c @@ -2169,8 +2169,8 @@ static int pkt_open_dev(struct pktcdvd_device *pd, bool write) * to read/write from/to it. It is already opened in O_NONBLOCK mode * so open should not fail. */ - bdev_handle = blkdev_get_handle_by_dev(pd->bdev_handle->bdev->bd_dev, - BLK_OPEN_READ, pd, NULL); + bdev_handle = blkdev_get_by_dev(pd->bdev_handle->bdev->bd_dev, + BLK_OPEN_READ, pd, NULL); if (IS_ERR(bdev_handle)) { ret = PTR_ERR(bdev_handle); goto out; @@ -2218,7 +2218,7 @@ static int pkt_open_dev(struct pktcdvd_device *pd, bool write) return 0; out_putdev: - blkdev_handle_put(bdev_handle); + blkdev_put(bdev_handle); out: return ret; } @@ -2237,7 +2237,7 @@ static void pkt_release_dev(struct pktcdvd_device *pd, int flush) pkt_lock_door(pd, 0); pkt_set_speed(pd, MAX_SPEED, MAX_SPEED); - blkdev_handle_put(pd->open_bdev_handle); + blkdev_put(pd->open_bdev_handle); pd->open_bdev_handle = NULL; pkt_shrink_pktlist(pd); @@ -2519,13 +2519,13 @@ static int pkt_new_dev(struct pktcdvd_device *pd, dev_t dev) } } - bdev_handle = blkdev_get_handle_by_dev(dev, - BLK_OPEN_READ | BLK_OPEN_NDELAY, NULL, NULL); + bdev_handle = blkdev_get_by_dev(dev, BLK_OPEN_READ | BLK_OPEN_NDELAY, + NULL, NULL); if (IS_ERR(bdev_handle)) return PTR_ERR(bdev_handle); sdev = scsi_device_from_queue(bdev_handle->bdev->bd_disk->queue); if (!sdev) { - blkdev_handle_put(bdev_handle); + blkdev_put(bdev_handle); return -EINVAL; } put_device(&sdev->sdev_gendev); @@ -2550,7 +2550,7 @@ static int pkt_new_dev(struct pktcdvd_device *pd, dev_t dev) return 0; out_mem: - blkdev_handle_put(bdev_handle); + blkdev_put(bdev_handle); /* This is safe: open() is still holding a reference. */ module_put(THIS_MODULE); return -ENOMEM; @@ -2757,7 +2757,7 @@ static int pkt_remove_dev(dev_t pkt_dev) pkt_debugfs_dev_remove(pd); pkt_sysfs_dev_remove(pd); - blkdev_handle_put(pd->bdev_handle); + blkdev_put(pd->bdev_handle); remove_proc_entry(pd->disk->disk_name, pkt_proc); dev_notice(ddev, "writer unmapped\n"); diff --git a/drivers/block/rnbd/rnbd-srv.c b/drivers/block/rnbd/rnbd-srv.c index 606db77c1238..d462d6dac297 100644 --- a/drivers/block/rnbd/rnbd-srv.c +++ b/drivers/block/rnbd/rnbd-srv.c @@ -219,7 +219,7 @@ void rnbd_destroy_sess_dev(struct rnbd_srv_sess_dev *sess_dev, bool keep_id) rnbd_put_sess_dev(sess_dev); wait_for_completion(&dc); /* wait for inflights to drop to zero */ - blkdev_handle_put(sess_dev->bdev_handle); + blkdev_put(sess_dev->bdev_handle); mutex_lock(&sess_dev->dev->lock); list_del(&sess_dev->dev_list); if (!sess_dev->readonly) @@ -714,8 +714,7 @@ static int process_msg_open(struct rnbd_srv_session *srv_sess, goto reject; } - bdev_handle = blkdev_get_handle_by_path(full_path, open_flags, NULL, - NULL); + bdev_handle = blkdev_get_by_path(full_path, open_flags, NULL, NULL); if (IS_ERR(bdev_handle)) { ret = PTR_ERR(bdev_handle); pr_err("Opening device '%s' on session %s failed, failed to open the block device, err: %d\n", @@ -792,7 +791,7 @@ static int process_msg_open(struct rnbd_srv_session *srv_sess, } rnbd_put_srv_dev(srv_dev); blkdev_put: - blkdev_handle_put(bdev_handle); + blkdev_put(bdev_handle); free_path: kfree(full_path); reject: diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c index b67d28584c72..c28b31872e5a 100644 --- a/drivers/block/xen-blkback/xenbus.c +++ b/drivers/block/xen-blkback/xenbus.c @@ -474,7 +474,7 @@ static void xenvbd_sysfs_delif(struct xenbus_device *dev) static void xen_vbd_free(struct xen_vbd *vbd) { if (vbd->bdev_handle) - blkdev_handle_put(vbd->bdev_handle); + blkdev_put(vbd->bdev_handle); vbd->bdev_handle = NULL; } @@ -492,8 +492,9 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle, vbd->pdevice = MKDEV(major, minor); - bdev_handle = blkdev_get_handle_by_dev(vbd->pdevice, vbd->readonly ? - BLK_OPEN_READ : BLK_OPEN_WRITE, NULL, NULL); + bdev_handle = blkdev_get_by_dev(vbd->pdevice, + vbd->readonly ? BLK_OPEN_READ : BLK_OPEN_WRITE, + NULL, NULL); if (IS_ERR(bdev_handle)) { pr_warn("xen_vbd_create: device %08x could not be opened\n", diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index 987e4885956e..284f433bf5e9 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -417,7 +417,7 @@ static void reset_bdev(struct zram *zram) if (!zram->backing_dev) return; - blkdev_handle_put(zram->bdev_handle); + blkdev_put(zram->bdev_handle); /* hope filp_close flush all of IO */ filp_close(zram->backing_dev, NULL); zram->backing_dev = NULL; @@ -504,8 +504,9 @@ static ssize_t backing_dev_store(struct device *dev, goto out; } - bdev_handle = blkdev_get_handle_by_dev(inode->i_rdev, - BLK_OPEN_READ | BLK_OPEN_WRITE, zram, NULL); + bdev_handle = blkdev_get_by_dev(inode->i_rdev, + BLK_OPEN_READ | BLK_OPEN_WRITE, zram, + NULL); if (IS_ERR(bdev_handle)) { err = PTR_ERR(bdev_handle); bdev_handle = NULL; @@ -536,7 +537,7 @@ static ssize_t backing_dev_store(struct device *dev, kvfree(bitmap); if (bdev_handle) - blkdev_handle_put(bdev_handle); + blkdev_put(bdev_handle); if (backing_dev) filp_close(backing_dev, NULL); diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index 2b3f35fd7477..c6b6b140f3e8 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -1369,7 +1369,7 @@ static void cached_dev_free(struct closure *cl) put_page(virt_to_page(dc->sb_disk)); if (dc->bdev_handle) - blkdev_handle_put(dc->bdev_handle); + blkdev_put(dc->bdev_handle); wake_up(&unregister_wait); @@ -2218,7 +2218,7 @@ void bch_cache_release(struct kobject *kobj) put_page(virt_to_page(ca->sb_disk)); if (ca->bdev_handle) - blkdev_handle_put(ca->bdev_handle); + blkdev_put(ca->bdev_handle); kfree(ca); module_put(THIS_MODULE); @@ -2357,10 +2357,10 @@ static int register_cache(struct cache_sb *sb, struct cache_sb_disk *sb_disk, /* * If we failed here, it means ca->kobj is not initialized yet, * kobject_put() won't be called and there is no chance to - * call blkdev_handle_put() to bdev in bch_cache_release(). So - * we explicitly call blkdev_handle_put() here. + * call blkdev_put() to bdev in bch_cache_release(). So we + * explicitly call blkdev_put() here. */ - blkdev_handle_put(bdev_handle); + blkdev_put(bdev_handle); if (ret == -ENOMEM) err = "cache_alloc(): -ENOMEM"; else if (ret == -EPERM) @@ -2551,8 +2551,8 @@ static ssize_t register_bcache(struct kobject *k, struct kobj_attribute *attr, ret = -EINVAL; err = "failed to open device"; - bdev_handle = blkdev_get_handle_by_path(strim(path), BLK_OPEN_READ, - NULL, NULL); + bdev_handle = blkdev_get_by_path(strim(path), BLK_OPEN_READ, NULL, + NULL); if (IS_ERR(bdev_handle)) goto out_free_sb; @@ -2572,9 +2572,10 @@ static ssize_t register_bcache(struct kobject *k, struct kobj_attribute *attr, } /* Now reopen in exclusive mode with proper holder */ - bdev_handle2 = blkdev_get_handle_by_dev(bdev_handle->bdev->bd_dev, - BLK_OPEN_READ | BLK_OPEN_WRITE, holder, NULL); - blkdev_handle_put(bdev_handle); + bdev_handle2 = blkdev_get_by_dev(bdev_handle->bdev->bd_dev, + BLK_OPEN_READ | BLK_OPEN_WRITE, + holder, NULL); + blkdev_put(bdev_handle); bdev_handle = bdev_handle2; if (IS_ERR(bdev_handle)) { ret = PTR_ERR(bdev_handle); @@ -2646,7 +2647,7 @@ static ssize_t register_bcache(struct kobject *k, struct kobj_attribute *attr, put_page(virt_to_page(sb_disk)); out_blkdev_put: if (bdev_handle) - blkdev_handle_put(bdev_handle); + blkdev_put(bdev_handle); out_free_sb: kfree(sb); out_free_path: diff --git a/drivers/md/dm.c b/drivers/md/dm.c index d73905149bef..018ae5802efb 100644 --- a/drivers/md/dm.c +++ b/drivers/md/dm.c @@ -751,7 +751,7 @@ static struct table_device *open_table_device(struct mapped_device *md, return ERR_PTR(-ENOMEM); refcount_set(&td->count, 1); - bdev_handle = blkdev_get_handle_by_dev(dev, mode, _dm_claim_ptr, NULL); + bdev_handle = blkdev_get_by_dev(dev, mode, _dm_claim_ptr, NULL); if (IS_ERR(bdev_handle)) { r = PTR_ERR(bdev_handle); goto out_free_td; @@ -778,7 +778,7 @@ static struct table_device *open_table_device(struct mapped_device *md, return td; out_blkdev_put: - blkdev_handle_put(bdev_handle); + blkdev_put(bdev_handle); out_free_td: kfree(td); return ERR_PTR(r); @@ -791,7 +791,7 @@ static void close_table_device(struct table_device *td, struct mapped_device *md { if (md->disk->slave_dir) bd_unlink_disk_holder(td->dm_dev.bdev, md->disk); - blkdev_handle_put(td->dm_dev.bdev_handle); + blkdev_put(td->dm_dev.bdev_handle); put_dax(td->dm_dev.dax_dev); list_del(&td->list); kfree(td); diff --git a/drivers/md/md.c b/drivers/md/md.c index bed142ee6f1f..595aeb6cc766 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -2458,7 +2458,7 @@ static void export_rdev(struct md_rdev *rdev, struct mddev *mddev) if (test_bit(AutoDetected, &rdev->flags)) md_autodetect_dev(rdev->bdev->bd_dev); #endif - blkdev_handle_put(rdev->bdev_handle); + blkdev_put(rdev->bdev_handle); rdev->bdev = NULL; kobject_put(&rdev->kobj); } @@ -3654,9 +3654,10 @@ static struct md_rdev *md_import_device(dev_t newdev, int super_format, int supe if (err) goto out_clear_rdev; - rdev->bdev_handle = blkdev_get_handle_by_dev(newdev, - BLK_OPEN_READ | BLK_OPEN_WRITE, - super_format == -2 ? &claim_rdev : rdev, NULL); + rdev->bdev_handle = blkdev_get_by_dev(newdev, + BLK_OPEN_READ | BLK_OPEN_WRITE, + super_format == -2 ? &claim_rdev : rdev, + NULL); if (IS_ERR(rdev->bdev_handle)) { pr_warn("md: could not open device unknown-block(%u,%u).\n", MAJOR(newdev), MINOR(newdev)); @@ -3694,7 +3695,7 @@ static struct md_rdev *md_import_device(dev_t newdev, int super_format, int supe return rdev; out_blkdev_put: - blkdev_handle_put(rdev->bdev_handle); + blkdev_put(rdev->bdev_handle); out_clear_rdev: md_rdev_clear(rdev); out_free_rdev: diff --git a/drivers/mtd/devices/block2mtd.c b/drivers/mtd/devices/block2mtd.c index 1614459297d2..385d34096031 100644 --- a/drivers/mtd/devices/block2mtd.c +++ b/drivers/mtd/devices/block2mtd.c @@ -213,7 +213,7 @@ static void block2mtd_free_device(struct block2mtd_dev *dev) if (dev->bdev_handle) { invalidate_mapping_pages( dev->bdev_handle->bdev->bd_inode->i_mapping, 0, -1); - blkdev_handle_put(dev->bdev_handle); + blkdev_put(dev->bdev_handle); } kfree(dev); @@ -253,8 +253,7 @@ static struct bdev_handle __ref *mdtblock_early_get_bdev(const char *devname, wait_for_device_probe(); if (!early_lookup_bdev(devname, &devt)) { - bdev_handle = blkdev_get_handle_by_dev(devt, mode, dev, - NULL); + bdev_handle = blkdev_get_by_dev(devt, mode, dev, NULL); if (!IS_ERR(bdev_handle)) break; } @@ -280,7 +279,7 @@ static struct block2mtd_dev *add_device(char *devname, int erase_size, return NULL; /* Get a handle on the device */ - bdev_handle = blkdev_get_handle_by_path(devname, mode, dev, NULL); + bdev_handle = blkdev_get_by_path(devname, mode, dev, NULL); if (IS_ERR(bdev_handle)) bdev_handle = mdtblock_early_get_bdev(devname, mode, timeout, dev); diff --git a/drivers/nvme/target/io-cmd-bdev.c b/drivers/nvme/target/io-cmd-bdev.c index 0f177a7e3b37..3f600dad7cbb 100644 --- a/drivers/nvme/target/io-cmd-bdev.c +++ b/drivers/nvme/target/io-cmd-bdev.c @@ -51,7 +51,7 @@ void nvmet_bdev_set_limits(struct block_device *bdev, struct nvme_id_ns *id) void nvmet_bdev_ns_disable(struct nvmet_ns *ns) { if (ns->bdev_handle) { - blkdev_handle_put(ns->bdev_handle); + blkdev_put(ns->bdev_handle); ns->bdev = NULL; ns->bdev_handle = NULL; } @@ -85,8 +85,9 @@ int nvmet_bdev_ns_enable(struct nvmet_ns *ns) if (ns->buffered_io) return -ENOTBLK; - ns->bdev_handle = blkdev_get_handle_by_path(ns->device_path, - BLK_OPEN_READ | BLK_OPEN_WRITE, NULL, NULL); + ns->bdev_handle = blkdev_get_by_path(ns->device_path, + BLK_OPEN_READ | BLK_OPEN_WRITE, + NULL, NULL); if (IS_ERR(ns->bdev_handle)) { ret = PTR_ERR(ns->bdev_handle); if (ret != -ENOTBLK) { diff --git a/drivers/s390/block/dasd_genhd.c b/drivers/s390/block/dasd_genhd.c index 1c22a5ee2ce7..13af36180372 100644 --- a/drivers/s390/block/dasd_genhd.c +++ b/drivers/s390/block/dasd_genhd.c @@ -130,8 +130,8 @@ int dasd_scan_partitions(struct dasd_block *block) struct bdev_handle *bdev_handle; int rc; - bdev_handle = blkdev_get_handle_by_dev(disk_devt(block->gdp), - BLK_OPEN_READ, NULL, NULL); + bdev_handle = blkdev_get_by_dev(disk_devt(block->gdp), BLK_OPEN_READ, + NULL, NULL); if (IS_ERR(bdev_handle)) { DBF_DEV_EVENT(DBF_ERR, block->base, "scan partitions error, blkdev_get returned %ld", @@ -147,13 +147,13 @@ int dasd_scan_partitions(struct dasd_block *block) "scan partitions error, rc %d", rc); /* - * Since the matching blkdev_handle_put() call to the - * blkdev_get_handle_by_path() in this function is not called before - * dasd_destroy_partitions the offline open_count limit needs to be - * increased from 0 to 1. This is done by setting device->bdev_handle - * (see dasd_generic_set_offline). As long as the partition detection - * is running no offline should be allowed. That is why the assignment - * to block->bdev_handle is done AFTER the BLKRRPART ioctl. + * Since the matching blkdev_put() call to the blkdev_get_by_path() in + * this function is not called before dasd_destroy_partitions the + * offline open_count limit needs to be increased from 0 to 1. This is + * done by setting device->bdev_handle (see dasd_generic_set_offline). + * As long as the partition detection is running no offline should be + * allowed. That is why the assignment to block->bdev_handle is done + * AFTER the BLKRRPART ioctl. */ block->bdev_handle = bdev_handle; return 0; @@ -179,7 +179,7 @@ void dasd_destroy_partitions(struct dasd_block *block) mutex_unlock(&bdev_handle->bdev->bd_disk->open_mutex); /* Matching blkdev_put to the blkdev_get in dasd_scan_partitions. */ - blkdev_handle_put(bdev_handle); + blkdev_put(bdev_handle); } int dasd_gendisk_init(void) diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c index 979b0cfbea4a..d271a536d66f 100644 --- a/drivers/target/target_core_iblock.c +++ b/drivers/target/target_core_iblock.c @@ -117,8 +117,8 @@ static int iblock_configure_device(struct se_device *dev) else dev->dev_flags |= DF_READ_ONLY; - bdev_handle = blkdev_get_handle_by_path(ib_dev->ibd_udev_path, mode, - ib_dev, NULL); + bdev_handle = blkdev_get_by_path(ib_dev->ibd_udev_path, mode, ib_dev, + NULL); if (IS_ERR(bdev_handle)) { ret = PTR_ERR(bdev_handle); goto out_free_bioset; @@ -180,7 +180,7 @@ static int iblock_configure_device(struct se_device *dev) return 0; out_blkdev_put: - blkdev_handle_put(ib_dev->ibd_bdev_handle); + blkdev_put(ib_dev->ibd_bdev_handle); out_free_bioset: bioset_exit(&ib_dev->ibd_bio_set); out: @@ -206,7 +206,7 @@ static void iblock_destroy_device(struct se_device *dev) struct iblock_dev *ib_dev = IBLOCK_DEV(dev); if (ib_dev->ibd_bdev_handle) - blkdev_handle_put(ib_dev->ibd_bdev_handle); + blkdev_put(ib_dev->ibd_bdev_handle); bioset_exit(&ib_dev->ibd_bio_set); } diff --git a/drivers/target/target_core_pscsi.c b/drivers/target/target_core_pscsi.c index 9ea2b29e95bf..38416426707f 100644 --- a/drivers/target/target_core_pscsi.c +++ b/drivers/target/target_core_pscsi.c @@ -366,10 +366,11 @@ static int pscsi_create_type_disk(struct se_device *dev, struct scsi_device *sd) * Claim exclusive struct block_device access to struct scsi_device * for TYPE_DISK and TYPE_ZBC using supplied udev_path */ - bdev_handle = blkdev_get_handle_by_path(dev->udev_path, - BLK_OPEN_WRITE | BLK_OPEN_READ, pdv, NULL); + bdev_handle = blkdev_get_by_path(dev->udev_path, + BLK_OPEN_WRITE | BLK_OPEN_READ, pdv, + NULL); if (IS_ERR(bdev_handle)) { - pr_err("pSCSI: blkdev_get_handle_by_path() failed\n"); + pr_err("pSCSI: blkdev_get_by_path() failed\n"); scsi_device_put(sd); return PTR_ERR(bdev_handle); } @@ -377,7 +378,7 @@ static int pscsi_create_type_disk(struct se_device *dev, struct scsi_device *sd) ret = pscsi_add_device_to_list(dev, sd); if (ret) { - blkdev_handle_put(bdev_handle); + blkdev_put(bdev_handle); scsi_device_put(sd); return ret; } @@ -565,7 +566,7 @@ static void pscsi_destroy_device(struct se_device *dev) */ if ((sd->type == TYPE_DISK || sd->type == TYPE_ZBC) && pdv->pdv_bdev_handle) { - blkdev_handle_put(pdv->pdv_bdev_handle); + blkdev_put(pdv->pdv_bdev_handle); pdv->pdv_bdev_handle = NULL; } /* diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c index 639eaecf1036..9842d777db76 100644 --- a/fs/btrfs/dev-replace.c +++ b/fs/btrfs/dev-replace.c @@ -258,8 +258,8 @@ static int btrfs_init_dev_replace_tgtdev(struct btrfs_fs_info *fs_info, return -EINVAL; } - bdev_handle = blkdev_get_handle_by_path(device_path, BLK_OPEN_WRITE, - fs_info->bdev_holder, NULL); + bdev_handle = blkdev_get_by_path(device_path, BLK_OPEN_WRITE, + fs_info->bdev_holder, NULL); if (IS_ERR(bdev_handle)) { btrfs_err(fs_info, "target device %s is invalid!", device_path); return PTR_ERR(bdev_handle); @@ -336,7 +336,7 @@ static int btrfs_init_dev_replace_tgtdev(struct btrfs_fs_info *fs_info, return 0; error: - blkdev_handle_put(bdev_handle); + blkdev_put(bdev_handle); return ret; } diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index 7d8f5625ad70..92aaba3e6948 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -2722,7 +2722,7 @@ static long btrfs_ioctl_rm_dev_v2(struct file *file, void __user *arg) err_drop: mnt_drop_write_file(file); if (bdev_handle) - blkdev_handle_put(bdev_handle); + blkdev_put(bdev_handle); out: btrfs_put_dev_args_from_path(&args); kfree(vol_args); @@ -2770,7 +2770,7 @@ static long btrfs_ioctl_rm_dev(struct file *file, void __user *arg) mnt_drop_write_file(file); if (bdev_handle) - blkdev_handle_put(bdev_handle); + blkdev_put(bdev_handle); out: btrfs_put_dev_args_from_path(&args); kfree(vol_args); diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index db63b0be5405..fb7082426498 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -517,8 +517,7 @@ btrfs_get_bdev_and_sb(const char *device_path, blk_mode_t flags, void *holder, struct block_device *bdev; int ret; - *bdev_handle = blkdev_get_handle_by_path(device_path, flags, holder, - NULL); + *bdev_handle = blkdev_get_by_path(device_path, flags, holder, NULL); if (IS_ERR(*bdev_handle)) { ret = PTR_ERR(*bdev_handle); @@ -530,14 +529,14 @@ btrfs_get_bdev_and_sb(const char *device_path, blk_mode_t flags, void *holder, sync_blockdev(bdev); ret = set_blocksize(bdev, BTRFS_BDEV_BLOCKSIZE); if (ret) { - blkdev_handle_put(*bdev_handle); + blkdev_put(*bdev_handle); goto error; } invalidate_bdev(bdev); *disk_super = btrfs_read_dev_super(bdev); if (IS_ERR(*disk_super)) { ret = PTR_ERR(*disk_super); - blkdev_handle_put(*bdev_handle); + blkdev_put(*bdev_handle); goto error; } @@ -679,7 +678,7 @@ static int btrfs_open_one_device(struct btrfs_fs_devices *fs_devices, error_free_page: btrfs_release_disk_super(disk_super); - blkdev_handle_put(bdev_handle); + blkdev_put(bdev_handle); return -EINVAL; } @@ -1070,7 +1069,7 @@ static void __btrfs_free_extra_devids(struct btrfs_fs_devices *fs_devices, continue; if (device->bdev_handle) { - blkdev_handle_put(device->bdev_handle); + blkdev_put(device->bdev_handle); device->bdev = NULL; device->bdev_handle = NULL; fs_devices->open_devices--; @@ -1117,7 +1116,7 @@ static void btrfs_close_bdev(struct btrfs_device *device) invalidate_bdev(device->bdev); } - blkdev_handle_put(device->bdev_handle); + blkdev_put(device->bdev_handle); } static void btrfs_close_one_device(struct btrfs_device *device) @@ -1388,7 +1387,7 @@ struct btrfs_device *btrfs_scan_one_device(const char *path, blk_mode_t flags) * values temporarily, as the device paths of the fsid are the only * required information for assembling the volume. */ - bdev_handle = blkdev_get_handle_by_path(path, flags, NULL, NULL); + bdev_handle = blkdev_get_by_path(path, flags, NULL, NULL); if (IS_ERR(bdev_handle)) return ERR_CAST(bdev_handle); @@ -1413,7 +1412,7 @@ struct btrfs_device *btrfs_scan_one_device(const char *path, blk_mode_t flags) btrfs_release_disk_super(disk_super); error_bdev_put: - blkdev_handle_put(bdev_handle); + blkdev_put(bdev_handle); return device; } @@ -2225,9 +2224,9 @@ int btrfs_rm_device(struct btrfs_fs_info *fs_info, * free the device. * * We cannot call btrfs_close_bdev() here because we're holding the sb - * write lock, and blkdev_handle_put() will pull in the ->open_mutex on - * the block device and it's dependencies. Instead just flush the - * device and let the caller do the final blkdev_handle_put. + * write lock, and blkdev_put() will pull in the ->open_mutex on the + * block device and it's dependencies. Instead just flush the device + * and let the caller do the final blkdev_put. */ if (test_bit(BTRFS_DEV_STATE_WRITEABLE, &device->dev_state)) { btrfs_scratch_superblocks(fs_info, device->bdev, @@ -2406,7 +2405,7 @@ int btrfs_get_dev_args_from_path(struct btrfs_fs_info *fs_info, else memcpy(args->fsid, disk_super->fsid, BTRFS_FSID_SIZE); btrfs_release_disk_super(disk_super); - blkdev_handle_put(bdev_handle); + blkdev_put(bdev_handle); return 0; } @@ -2639,8 +2638,8 @@ int btrfs_init_new_device(struct btrfs_fs_info *fs_info, const char *device_path if (sb_rdonly(sb) && !fs_devices->seeding) return -EROFS; - bdev_handle = blkdev_get_handle_by_path(device_path, BLK_OPEN_WRITE, - fs_info->bdev_holder, NULL); + bdev_handle = blkdev_get_by_path(device_path, BLK_OPEN_WRITE, + fs_info->bdev_holder, NULL); if (IS_ERR(bdev_handle)) return PTR_ERR(bdev_handle); @@ -2860,7 +2859,7 @@ int btrfs_init_new_device(struct btrfs_fs_info *fs_info, const char *device_path error_free_device: btrfs_free_device(device); error: - blkdev_handle_put(bdev_handle); + blkdev_put(bdev_handle); if (locked) { mutex_unlock(&uuid_mutex); up_write(&sb->s_umount); diff --git a/fs/erofs/super.c b/fs/erofs/super.c index a4742cc05f95..60d6b43ae5e3 100644 --- a/fs/erofs/super.c +++ b/fs/erofs/super.c @@ -254,8 +254,8 @@ static int erofs_init_device(struct erofs_buf *buf, struct super_block *sb, return PTR_ERR(fscache); dif->fscache = fscache; } else if (!sbi->devs->flatdev) { - bdev_handle = blkdev_get_handle_by_path(dif->path, - BLK_OPEN_READ, sb->s_type, NULL); + bdev_handle = blkdev_get_by_path(dif->path, BLK_OPEN_READ, + sb->s_type, NULL); if (IS_ERR(bdev_handle)) return PTR_ERR(bdev_handle); dif->bdev_handle = bdev_handle; @@ -816,7 +816,7 @@ static int erofs_release_device_info(int id, void *ptr, void *data) fs_put_dax(dif->dax_dev, NULL); if (dif->bdev_handle) - blkdev_handle_put(dif->bdev_handle); + blkdev_put(dif->bdev_handle); erofs_fscache_unregister_cookie(dif->fscache); dif->fscache = NULL; kfree(dif->path); diff --git a/fs/ext4/super.c b/fs/ext4/super.c index a3b982d6abf1..cbeb8a555fe3 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -1112,8 +1112,8 @@ static struct bdev_handle *ext4_blkdev_get(dev_t dev, struct super_block *sb) { struct bdev_handle *handle; - handle = blkdev_get_handle_by_dev(dev, BLK_OPEN_READ | BLK_OPEN_WRITE, - sb, &ext4_holder_ops); + handle = blkdev_get_by_dev(dev, BLK_OPEN_READ | BLK_OPEN_WRITE, sb, + &ext4_holder_ops); if (IS_ERR(handle)) goto fail; return handle; @@ -1137,7 +1137,7 @@ static void ext4_blkdev_remove(struct ext4_sb_info *sbi) * hotswapped, and it breaks the `ro-after' testing code. */ invalidate_bdev(sbi->s_journal_bdev_handle->bdev); - blkdev_handle_put(sbi->s_journal_bdev_handle); + blkdev_put(sbi->s_journal_bdev_handle); sbi->s_journal_bdev_handle = NULL; } } @@ -5928,7 +5928,7 @@ static journal_t *ext4_get_dev_journal(struct super_block *sb, out_journal: jbd2_journal_destroy(journal); out_bdev: - blkdev_handle_put(bdev_handle); + blkdev_put(bdev_handle); return NULL; } diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index 570364954578..2823f3eb36c7 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -1538,7 +1538,7 @@ static void destroy_device_list(struct f2fs_sb_info *sbi) int i; for (i = 0; i < sbi->s_ndevs; i++) { - blkdev_handle_put(FDEV(i).bdev_handle); + blkdev_put(FDEV(i).bdev_handle); #ifdef CONFIG_BLK_DEV_ZONED kvfree(FDEV(i).blkz_seq); #endif @@ -4024,9 +4024,10 @@ static int f2fs_scan_devices(struct f2fs_sb_info *sbi) if (max_devices == 1) { /* Single zoned block device mount */ - FDEV(0).bdev_handle = blkdev_get_handle_by_dev( - sbi->sb->s_bdev->bd_dev, - mode, sbi->sb->s_type, NULL); + FDEV(0).bdev_handle = blkdev_get_by_dev(sbi->sb->s_bdev->bd_dev, + mode, + sbi->sb->s_type, + NULL); } else { /* Multi-device mount */ memcpy(FDEV(i).path, RDEV(i).path, MAX_PATH_LEN); @@ -4044,8 +4045,10 @@ static int f2fs_scan_devices(struct f2fs_sb_info *sbi) (FDEV(i).total_segments << sbi->log_blocks_per_seg) - 1; } - FDEV(i).bdev_handle = blkdev_get_handle_by_path( - FDEV(i).path, mode, sbi->sb->s_type, NULL); + FDEV(i).bdev_handle = blkdev_get_by_path(FDEV(i).path, + mode, + sbi->sb->s_type, + NULL); } if (IS_ERR(FDEV(i).bdev_handle)) return PTR_ERR(FDEV(i).bdev_handle); diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c index 9d06323261e6..4f5171f24191 100644 --- a/fs/jfs/jfs_logmgr.c +++ b/fs/jfs/jfs_logmgr.c @@ -1100,8 +1100,9 @@ int lmLogOpen(struct super_block *sb) * file systems to log may have n-to-1 relationship; */ - bdev_handle = blkdev_get_handle_by_dev(sbi->logdev, - BLK_OPEN_READ | BLK_OPEN_WRITE, log, NULL); + bdev_handle = blkdev_get_by_dev(sbi->logdev, + BLK_OPEN_READ | BLK_OPEN_WRITE, log, + NULL); if (IS_ERR(bdev_handle)) { rc = PTR_ERR(bdev_handle); goto free; @@ -1141,7 +1142,7 @@ int lmLogOpen(struct super_block *sb) lbmLogShutdown(log); close: /* close external log device */ - blkdev_handle_put(bdev_handle); + blkdev_put(bdev_handle); free: /* free log descriptor */ mutex_unlock(&jfs_log_mutex); @@ -1485,7 +1486,7 @@ int lmLogClose(struct super_block *sb) bdev_handle = log->bdev_handle; rc = lmLogShutdown(log); - blkdev_handle_put(bdev_handle); + blkdev_put(bdev_handle); kfree(log); diff --git a/fs/nfs/blocklayout/dev.c b/fs/nfs/blocklayout/dev.c index 549de8600beb..26d22802a6f6 100644 --- a/fs/nfs/blocklayout/dev.c +++ b/fs/nfs/blocklayout/dev.c @@ -35,7 +35,7 @@ bl_free_device(struct pnfs_block_dev *dev) } if (dev->bdev_handle) - blkdev_handle_put(dev->bdev_handle); + blkdev_put(dev->bdev_handle); } } @@ -243,8 +243,8 @@ bl_parse_simple(struct nfs_server *server, struct pnfs_block_dev *d, if (!dev) return -EIO; - bdev_handle = blkdev_get_handle_by_dev(dev, - BLK_OPEN_READ | BLK_OPEN_WRITE, NULL, NULL); + bdev_handle = blkdev_get_by_dev(dev, BLK_OPEN_READ | BLK_OPEN_WRITE, + NULL, NULL); if (IS_ERR(bdev_handle)) { printk(KERN_WARNING "pNFS: failed to open device %d:%d (%ld)\n", MAJOR(dev), MINOR(dev), PTR_ERR(bdev_handle)); @@ -311,8 +311,9 @@ bl_open_path(struct pnfs_block_volume *v, const char *prefix) if (!devname) return ERR_PTR(-ENOMEM); - bdev_handle = blkdev_get_handle_by_path(devname, - BLK_OPEN_READ | BLK_OPEN_WRITE, NULL, NULL); + bdev_handle = blkdev_get_by_path(devname, + BLK_OPEN_READ | BLK_OPEN_WRITE, NULL, + NULL); if (IS_ERR(bdev_handle)) { pr_warn("pNFS: failed to open device %s (%ld)\n", devname, PTR_ERR(bdev_handle)); @@ -373,7 +374,7 @@ bl_parse_scsi(struct nfs_server *server, struct pnfs_block_dev *d, return 0; out_blkdev_put: - blkdev_handle_put(d->bdev_handle); + blkdev_put(d->bdev_handle); return error; } diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c index 0aba0daa06d2..310ebbcc324d 100644 --- a/fs/nilfs2/super.c +++ b/fs/nilfs2/super.c @@ -1304,8 +1304,8 @@ nilfs_mount(struct file_system_type *fs_type, int flags, struct dentry *root_dentry; int err, s_new = false; - bdev_handle = blkdev_get_handle_by_path(dev_name, sb_open_mode(flags), - fs_type, NULL); + bdev_handle = blkdev_get_by_path(dev_name, sb_open_mode(flags), + fs_type, NULL); if (IS_ERR(bdev_handle)) return ERR_CAST(bdev_handle); @@ -1377,7 +1377,7 @@ nilfs_mount(struct file_system_type *fs_type, int flags, } if (!s_new) - blkdev_handle_put(bdev_handle); + blkdev_put(bdev_handle); return root_dentry; @@ -1386,7 +1386,7 @@ nilfs_mount(struct file_system_type *fs_type, int flags, failed: if (!s_new) - blkdev_handle_put(bdev_handle); + blkdev_put(bdev_handle); return ERR_PTR(err); } diff --git a/fs/ocfs2/cluster/heartbeat.c b/fs/ocfs2/cluster/heartbeat.c index 5509e7fb98db..c9f76d6cd796 100644 --- a/fs/ocfs2/cluster/heartbeat.c +++ b/fs/ocfs2/cluster/heartbeat.c @@ -1510,7 +1510,7 @@ static void o2hb_region_release(struct config_item *item) } if (reg->hr_bdev_handle) - blkdev_handle_put(reg->hr_bdev_handle); + blkdev_put(reg->hr_bdev_handle); kfree(reg->hr_slots); @@ -1795,9 +1795,9 @@ static ssize_t o2hb_region_dev_store(struct config_item *item, if (!S_ISBLK(f.file->f_mapping->host->i_mode)) goto out2; - reg->hr_bdev_handle = blkdev_get_handle_by_dev( - f.file->f_mapping->host->i_rdev, - BLK_OPEN_WRITE | BLK_OPEN_READ, NULL, NULL); + reg->hr_bdev_handle = blkdev_get_by_dev(f.file->f_mapping->host->i_rdev, + BLK_OPEN_WRITE | BLK_OPEN_READ, + NULL, NULL); if (IS_ERR(reg->hr_bdev_handle)) { ret = PTR_ERR(reg->hr_bdev_handle); reg->hr_bdev_handle = NULL; @@ -1904,7 +1904,7 @@ static ssize_t o2hb_region_dev_store(struct config_item *item, out3: if (ret < 0) { - blkdev_handle_put(reg->hr_bdev_handle); + blkdev_put(reg->hr_bdev_handle); reg->hr_bdev_handle = NULL; } out2: diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c index 9518ff7865f0..3eaff21947a0 100644 --- a/fs/reiserfs/journal.c +++ b/fs/reiserfs/journal.c @@ -2587,7 +2587,7 @@ static void journal_list_init(struct super_block *sb) static void release_journal_dev(struct reiserfs_journal *journal) { if (journal->j_bdev_handle) { - blkdev_handle_put(journal->j_bdev_handle); + blkdev_put(journal->j_bdev_handle); journal->j_bdev_handle = NULL; } } @@ -2614,8 +2614,8 @@ static int journal_init_dev(struct super_block *super, if ((!jdev_name || !jdev_name[0])) { if (jdev == super->s_dev) holder = NULL; - journal->j_bdev_handle = blkdev_get_handle_by_dev(jdev, - blkdev_mode, holder, NULL); + journal->j_bdev_handle = blkdev_get_by_dev(jdev, blkdev_mode, + holder, NULL); if (IS_ERR(journal->j_bdev_handle)) { result = PTR_ERR(journal->j_bdev_handle); journal->j_bdev_handle = NULL; @@ -2630,8 +2630,8 @@ static int journal_init_dev(struct super_block *super, return 0; } - journal->j_bdev_handle = blkdev_get_handle_by_path(jdev_name, - blkdev_mode, holder, NULL); + journal->j_bdev_handle = blkdev_get_by_path(jdev_name, blkdev_mode, + holder, NULL); if (IS_ERR(journal->j_bdev_handle)) { result = PTR_ERR(journal->j_bdev_handle); journal->j_bdev_handle = NULL; diff --git a/fs/super.c b/fs/super.c index d35545364c5d..ea135fece772 100644 --- a/fs/super.c +++ b/fs/super.c @@ -1266,9 +1266,9 @@ int get_tree_bdev(struct fs_context *fc, if (!fc->source) return invalf(fc, "No source specified"); - bdev_handle = blkdev_get_handle_by_path(fc->source, - sb_open_mode(fc->sb_flags), fc->fs_type, - &fs_holder_ops); + bdev_handle = blkdev_get_by_path(fc->source, + sb_open_mode(fc->sb_flags), + fc->fs_type, &fs_holder_ops); if (IS_ERR(bdev_handle)) { errorf(fc, "%s: Can't open blockdev", fc->source); return PTR_ERR(bdev_handle); @@ -1283,7 +1283,7 @@ int get_tree_bdev(struct fs_context *fc, if (bdev->bd_fsfreeze_count > 0) { mutex_unlock(&bdev->bd_fsfreeze_mutex); warnf(fc, "%pg: Can't mount, blockdev is frozen", bdev); - blkdev_handle_put(bdev_handle); + blkdev_put(bdev_handle); return -EBUSY; } @@ -1292,7 +1292,7 @@ int get_tree_bdev(struct fs_context *fc, s = sget_fc(fc, test_bdev_super_fc, set_bdev_super_fc); mutex_unlock(&bdev->bd_fsfreeze_mutex); if (IS_ERR(s)) { - blkdev_handle_put(bdev_handle); + blkdev_put(bdev_handle); return PTR_ERR(s); } @@ -1301,19 +1301,18 @@ int get_tree_bdev(struct fs_context *fc, if ((fc->sb_flags ^ s->s_flags) & SB_RDONLY) { warnf(fc, "%pg: Can't mount, would change RO state", bdev); deactivate_locked_super(s); - blkdev_handle_put(bdev_handle); + blkdev_put(bdev_handle); return -EBUSY; } /* * s_umount nests inside open_mutex during - * __invalidate_device(). blkdev_handle_put() acquires - * open_mutex and can't be called under s_umount. Drop - * s_umount temporarily. This is safe as we're - * holding an active reference. + * __invalidate_device(). blkdev_put() acquires open_mutex and + * can't be called under s_umount. Drop s_umount temporarily. + * This is safe as we're holding an active reference. */ up_write(&s->s_umount); - blkdev_handle_put(bdev_handle); + blkdev_put(bdev_handle); down_write(&s->s_umount); } else { snprintf(s->s_id, sizeof(s->s_id), "%pg", bdev); @@ -1351,8 +1350,8 @@ struct dentry *mount_bdev(struct file_system_type *fs_type, struct super_block *s; int error = 0; - bdev_handle = blkdev_get_handle_by_path(dev_name, sb_open_mode(flags), - fs_type, &fs_holder_ops); + bdev_handle = blkdev_get_by_path(dev_name, sb_open_mode(flags), + fs_type, &fs_holder_ops); if (IS_ERR(bdev_handle)) return ERR_CAST(bdev_handle); bdev = bdev_handle->bdev; @@ -1383,13 +1382,12 @@ struct dentry *mount_bdev(struct file_system_type *fs_type, /* * s_umount nests inside open_mutex during - * __invalidate_device(). blkdev_handle_put() acquires - * open_mutex and can't be called under s_umount. Drop - * s_umount temporarily. This is safe as we're - * holding an active reference. + * __invalidate_device(). blkdev_put() acquires open_mutex and + * can't be called under s_umount. Drop s_umount temporarily. + * This is safe as we're holding an active reference. */ up_write(&s->s_umount); - blkdev_handle_put(bdev_handle); + blkdev_put(bdev_handle); down_write(&s->s_umount); } else { snprintf(s->s_id, sizeof(s->s_id), "%pg", bdev); @@ -1411,7 +1409,7 @@ struct dentry *mount_bdev(struct file_system_type *fs_type, error_s: error = PTR_ERR(s); error_bdev: - blkdev_handle_put(bdev_handle); + blkdev_put(bdev_handle); error: return ERR_PTR(error); } @@ -1424,7 +1422,7 @@ void kill_block_super(struct super_block *sb) bdev->bd_super = NULL; generic_shutdown_super(sb); sync_blockdev(bdev); - blkdev_handle_put(sb->s_bdev_handle); + blkdev_put(sb->s_bdev_handle); } EXPORT_SYMBOL(kill_block_super); diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c index 5a958ae3a3ae..b0fbf8ea7846 100644 --- a/fs/xfs/xfs_super.c +++ b/fs/xfs/xfs_super.c @@ -396,8 +396,8 @@ xfs_blkdev_get( { int error = 0; - *handlep = blkdev_get_handle_by_path(name, - BLK_OPEN_READ | BLK_OPEN_WRITE, mp, &xfs_holder_ops); + *handlep = blkdev_get_by_path(name, BLK_OPEN_READ | BLK_OPEN_WRITE, + mp, &xfs_holder_ops); if (IS_ERR(*handlep)) { error = PTR_ERR(*handlep); xfs_warn(mp, "Invalid device [%s], error=%d", name, error); @@ -411,7 +411,7 @@ xfs_blkdev_put( struct bdev_handle *handle) { if (handle) - blkdev_handle_put(handle); + blkdev_put(handle); } STATIC void diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 134dfd1162e2..4ae3647a0322 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -1476,14 +1476,14 @@ struct bdev_handle { void *holder; }; -struct bdev_handle *blkdev_get_handle_by_dev(dev_t dev, blk_mode_t mode, - void *holder, const struct blk_holder_ops *hops); -struct bdev_handle *blkdev_get_handle_by_path(const char *path, blk_mode_t mode, +struct bdev_handle *blkdev_get_by_dev(dev_t dev, blk_mode_t mode, void *holder, + const struct blk_holder_ops *hops); +struct bdev_handle *blkdev_get_by_path(const char *path, blk_mode_t mode, void *holder, const struct blk_holder_ops *hops); int bd_prepare_to_claim(struct block_device *bdev, void *holder, const struct blk_holder_ops *hops); void bd_abort_claiming(struct block_device *bdev, void *holder); -void blkdev_handle_put(struct bdev_handle *handle); +void blkdev_put(struct bdev_handle *handle); /* just for blk-cgroup, don't use elsewhere */ struct block_device *blkdev_get_no_open(dev_t dev); diff --git a/kernel/power/swap.c b/kernel/power/swap.c index 9ebac878497f..25f06d92944c 100644 --- a/kernel/power/swap.c +++ b/kernel/power/swap.c @@ -357,14 +357,14 @@ static int swsusp_swap_check(void) return res; root_swap = res; - hib_resume_bdev_handle = blkdev_get_handle_by_dev(swsusp_resume_device, - BLK_OPEN_WRITE, NULL, NULL); + hib_resume_bdev_handle = blkdev_get_by_dev(swsusp_resume_device, + BLK_OPEN_WRITE, NULL, NULL); if (IS_ERR(hib_resume_bdev_handle)) return PTR_ERR(hib_resume_bdev_handle); res = set_blocksize(hib_resume_bdev_handle->bdev, PAGE_SIZE); if (res < 0) - blkdev_handle_put(hib_resume_bdev_handle); + blkdev_put(hib_resume_bdev_handle); return res; } @@ -1522,8 +1522,9 @@ int swsusp_check(bool snapshot_test) void *holder = snapshot_test ? &swsusp_holder : NULL; int error; - hib_resume_bdev_handle = blkdev_get_handle_by_dev(swsusp_resume_device, - BLK_OPEN_READ, holder, NULL); + hib_resume_bdev_handle = blkdev_get_by_dev(swsusp_resume_device, + BLK_OPEN_READ, holder, + NULL); if (!IS_ERR(hib_resume_bdev_handle)) { set_blocksize(hib_resume_bdev_handle->bdev, PAGE_SIZE); clear_page(swsusp_header); @@ -1550,7 +1551,7 @@ int swsusp_check(bool snapshot_test) put: if (error) - blkdev_handle_put(hib_resume_bdev_handle); + blkdev_put(hib_resume_bdev_handle); else pr_debug("Image signature found, resuming\n"); } else { @@ -1574,7 +1575,7 @@ void swsusp_close(void) return; } - blkdev_handle_put(hib_resume_bdev_handle); + blkdev_put(hib_resume_bdev_handle); } /** diff --git a/mm/swapfile.c b/mm/swapfile.c index dbd37aa4724d..921fdb7e5e09 100644 --- a/mm/swapfile.c +++ b/mm/swapfile.c @@ -2528,7 +2528,7 @@ SYSCALL_DEFINE1(swapoff, const char __user *, specialfile) inode = mapping->host; if (p->bdev_handle) { set_blocksize(p->bdev, old_block_size); - blkdev_handle_put(p->bdev_handle); + blkdev_put(p->bdev_handle); } inode_lock(inode); @@ -2758,8 +2758,9 @@ static int claim_swapfile(struct swap_info_struct *p, struct inode *inode) int error; if (S_ISBLK(inode->i_mode)) { - p->bdev_handle = blkdev_get_handle_by_dev(inode->i_rdev, - BLK_OPEN_READ | BLK_OPEN_WRITE, p, NULL); + p->bdev_handle = blkdev_get_by_dev(inode->i_rdev, + BLK_OPEN_READ | BLK_OPEN_WRITE, + p, NULL); if (IS_ERR(p->bdev_handle)) { error = PTR_ERR(p->bdev_handle); p->bdev_handle = NULL; @@ -3211,7 +3212,7 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags) p->cluster_next_cpu = NULL; if (p->bdev_handle) { set_blocksize(p->bdev, p->old_block_size); - blkdev_handle_put(p->bdev_handle); + blkdev_put(p->bdev_handle); } inode = NULL; destroy_swap_extents(p); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Jul 04 12:45:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 12:45:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558338.872334 (Exim 4.92) (envelope-from ) id 1qGfOn-0001pb-VW; Tue, 04 Jul 2023 12:44:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558338.872334; Tue, 04 Jul 2023 12:44:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGfOn-0001pU-RY; Tue, 04 Jul 2023 12:44:53 +0000 Received: by outflank-mailman (input) for mailman id 558338; Tue, 04 Jul 2023 12:44:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGfOm-0001pM-Dh for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 12:44:53 +0000 Received: from casper.infradead.org (casper.infradead.org [2001:8b0:10b:1236::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8d9d0c47-1a68-11ee-8611-37d641c3527e; Tue, 04 Jul 2023 14:44:47 +0200 (CEST) Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qGfNn-0099Sz-9Z; Tue, 04 Jul 2023 12:43:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d9d0c47-1a68-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MTt8zrAicdNCIRJKdOYeAgLwlWREbjuubDrB9LDLoHk=; b=FQ7AVaBk1GiVkQjqboSqkOGPBq D5twh1rJ7Iuli9ASCg3UlAH0AvBtBUwBmFvGFlq65Bob5lYyyxVWcYsI1kpmfheq88Wy3j6xoPYkH Yr8SWDhirVenxTbYcufP9aI7qtE9tPtw2HdVYrOWl8KhXSL1///8tHp1coXORoa2/ua7NUKFkm8+i dZTW2mGKIGBkD8nw9XAEiECk0hIGw3K+rH1tSbKt2yF6JFa6PpHTgJc3LTGgE/JGwL7FWrIxLj7Op grzKnmKKjadKIKnXmQRg0cnlXA7KWmhAcv93Lftb6rhIWGVuVJI8IrHKh1M51oSxQqR7AKzuvj0MI qnUduz9Q==; Date: Tue, 4 Jul 2023 13:43:51 +0100 From: Matthew Wilcox To: Jan Kara Cc: linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jens Axboe , Christoph Hellwig , Alasdair Kergon , Andrew Morton , Anna Schumaker , Chao Yu , Christian Borntraeger , "Darrick J. Wong" , Dave Kleikamp , David Sterba , dm-devel@redhat.com, drbd-dev@lists.linbit.com, Gao Xiang , Jack Wang , Jaegeuk Kim , jfs-discussion@lists.sourceforge.net, Joern Engel , Joseph Qi , Kent Overstreet , linux-bcache@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-nvme@lists.infradead.org, linux-pm@vger.kernel.org, linux-raid@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-xfs@vger.kernel.org, "Md. Haris Iqbal" , Mike Snitzer , Minchan Kim , ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, Sergey Senozhatsky , Song Liu , Sven Schnelle , target-devel@vger.kernel.org, Ted Tso , Trond Myklebust , xen-devel@lists.xenproject.org Subject: Re: [PATCH 01/32] block: Provide blkdev_get_handle_* functions Message-ID: References: <20230629165206.383-1-jack@suse.cz> <20230704122224.16257-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230704122224.16257-1-jack@suse.cz> On Tue, Jul 04, 2023 at 02:21:28PM +0200, Jan Kara wrote: > +struct bdev_handle *blkdev_get_handle_by_dev(dev_t dev, blk_mode_t mode, > + void *holder, const struct blk_holder_ops *hops) > +{ > + struct bdev_handle *handle = kmalloc(sizeof(struct bdev_handle), > + GFP_KERNEL); > + struct block_device *bdev; > + > + if (!handle) > + return ERR_PTR(-ENOMEM); > + bdev = blkdev_get_by_dev(dev, mode, holder, hops); > + if (IS_ERR(bdev)) > + return ERR_CAST(bdev); Would we be better off with a handle->error (and a NULL return from this function means "we couldn't allocate a handle")? I have no objection to what you've done here, just wondering if it might end up nicer for the users. From xen-devel-bounces@lists.xenproject.org Tue Jul 04 13:04:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 13:04:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558343.872344 (Exim 4.92) (envelope-from ) id 1qGfhI-0004Kk-EL; Tue, 04 Jul 2023 13:04:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558343.872344; Tue, 04 Jul 2023 13:04:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGfhI-0004Kd-BK; Tue, 04 Jul 2023 13:04:00 +0000 Received: by outflank-mailman (input) for mailman id 558343; Tue, 04 Jul 2023 13:03:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGfhH-0004KR-A7 for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 13:03:59 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3cb022d0-1a6b-11ee-b237-6b7b168915f2; Tue, 04 Jul 2023 15:03:58 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F0F5F20573; Tue, 4 Jul 2023 13:03:56 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DC3001346D; Tue, 4 Jul 2023 13:03:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id kueeNbwYpGTARwAAMHmgww (envelope-from ); Tue, 04 Jul 2023 13:03:56 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 6B4A7A0722; Tue, 4 Jul 2023 15:03:56 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3cb022d0-1a6b-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1688475837; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rY6MxLY5e9SVa1+4BCCd7ntNwV9Px5uEGT5nvi2Xw9M=; b=ejRwbAIwZQbMrOxksN9aG/ZDDESpKoHA5R/d85WHYyhF32Si43PFRfl6mcCR9WYB3Qv5Xb bFzVFYQ3692eypLdUzJN5qIXY9S2kweTJplS9sF53SAyJ7HvtNyhlweUs2wFtrS+zKSTOj TegqbmWrWk4Vs0DZGSAEKRmheCwdTpE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1688475837; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rY6MxLY5e9SVa1+4BCCd7ntNwV9Px5uEGT5nvi2Xw9M=; b=T7VmytPRSDJUviPwV6lejrGCKn7KjlWBXNR5Weqcyul/51HqsbD9tiSRFlJo/bbQX+dGnV 08LOGAmrpvM1ddAQ== Date: Tue, 4 Jul 2023 15:03:56 +0200 From: Jan Kara To: Matthew Wilcox Cc: Jan Kara , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jens Axboe , Christoph Hellwig , Alasdair Kergon , Andrew Morton , Anna Schumaker , Chao Yu , Christian Borntraeger , "Darrick J. Wong" , Dave Kleikamp , David Sterba , dm-devel@redhat.com, drbd-dev@lists.linbit.com, Gao Xiang , Jack Wang , Jaegeuk Kim , jfs-discussion@lists.sourceforge.net, Joern Engel , Joseph Qi , Kent Overstreet , linux-bcache@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-nvme@lists.infradead.org, linux-pm@vger.kernel.org, linux-raid@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-xfs@vger.kernel.org, "Md. Haris Iqbal" , Mike Snitzer , Minchan Kim , ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, Sergey Senozhatsky , Song Liu , Sven Schnelle , target-devel@vger.kernel.org, Ted Tso , Trond Myklebust , xen-devel@lists.xenproject.org Subject: Re: [PATCH 01/32] block: Provide blkdev_get_handle_* functions Message-ID: <20230704130356.xwdlxvgvi4l6sruc@quack3> References: <20230629165206.383-1-jack@suse.cz> <20230704122224.16257-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue 04-07-23 13:43:51, Matthew Wilcox wrote: > On Tue, Jul 04, 2023 at 02:21:28PM +0200, Jan Kara wrote: > > +struct bdev_handle *blkdev_get_handle_by_dev(dev_t dev, blk_mode_t mode, > > + void *holder, const struct blk_holder_ops *hops) > > +{ > > + struct bdev_handle *handle = kmalloc(sizeof(struct bdev_handle), > > + GFP_KERNEL); > > + struct block_device *bdev; > > + > > + if (!handle) > > + return ERR_PTR(-ENOMEM); > > + bdev = blkdev_get_by_dev(dev, mode, holder, hops); > > + if (IS_ERR(bdev)) > > + return ERR_CAST(bdev); > > Would we be better off with a handle->error (and a NULL return from this > function means "we couldn't allocate a handle")? I have no objection > to what you've done here, just wondering if it might end up nicer for > the users. Hum, I've checked a couple of users and it seems it would be more complicated for the users to handle this convention than the one I've chosen. And that one is also pretty standard so I think by the principle of least surprise it is also better. Honza > -- Jan Kara SUSE Labs, CR From xen-devel-bounces@lists.xenproject.org Tue Jul 04 13:26:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 13:26:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558347.872353 (Exim 4.92) (envelope-from ) id 1qGg36-0006qa-3w; Tue, 04 Jul 2023 13:26:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558347.872353; Tue, 04 Jul 2023 13:26:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGg36-0006qT-14; Tue, 04 Jul 2023 13:26:32 +0000 Received: by outflank-mailman (input) for mailman id 558347; Tue, 04 Jul 2023 13:26:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGg35-0006qJ-7h; Tue, 04 Jul 2023 13:26:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGg34-0000DZ-Sj; Tue, 04 Jul 2023 13:26:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGg34-0001Cc-IY; Tue, 04 Jul 2023 13:26:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qGg34-0006Zz-I4; Tue, 04 Jul 2023 13:26:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=BruUovCD31WgGj21RPHbVYpgyImBf9nbx8FXNQ9VSY4=; b=io+y8IdUdQKf0eK+flTSvpCpzF 6SRGgwgt/xpQdXnql1h3mBiJXQ43UJeDQ2gZ+/UwZu7S15SBrYbbq3UJWYSDvkAYYlhFOVk6WplpK edgzAwvWabjY8l/NZsI9co/JcBlbdZozrvropoSzA1+6WiXKhyDTIWd81xVvCnjxKH+g=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 181694: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=6e06d229d538ea51b92dc189546c522f5e903511 X-Osstest-Versions-That: xen=f51e5d8eae8ece77a949571f39ee49904f3129aa From: osstest service owner Date: Tue, 04 Jul 2023 13:26:30 +0000 flight 181694 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181694/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass version targeted for testing: xen 6e06d229d538ea51b92dc189546c522f5e903511 baseline version: xen f51e5d8eae8ece77a949571f39ee49904f3129aa Last test of basis 181661 2023-06-30 18:00:29 Z 3 days Testing same since 181694 2023-07-04 11:03:36 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git f51e5d8eae..6e06d229d5 6e06d229d538ea51b92dc189546c522f5e903511 -> smoke From xen-devel-bounces@lists.xenproject.org Tue Jul 04 13:31:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 13:31:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558353.872363 (Exim 4.92) (envelope-from ) id 1qGg7P-0008Hm-LO; Tue, 04 Jul 2023 13:30:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558353.872363; Tue, 04 Jul 2023 13:30:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGg7P-0008He-IR; Tue, 04 Jul 2023 13:30:59 +0000 Received: by outflank-mailman (input) for mailman id 558353; Tue, 04 Jul 2023 13:30:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGg7N-0008HV-W4 for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 13:30:58 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0033ef6c-1a6f-11ee-b237-6b7b168915f2; Tue, 04 Jul 2023 15:30:55 +0200 (CEST) Received: from mail-co1nam11lp2175.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Jul 2023 09:30:48 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by BY5PR03MB4951.namprd03.prod.outlook.com (2603:10b6:a03:1ef::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 13:30:46 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::1c83:1877:a68b:8902]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::1c83:1877:a68b:8902%7]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 13:30:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0033ef6c-1a6f-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1688477455; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=WCgkf5IFFnMzkXfG6LshJCt1hfuF+SCIXkc0CgQ4kdQ=; b=UuwfAXrDrMyo+sXgTShmEjCqhMvaMkp6hc/GEiLWusIKHzsu+aOWbL3m +bUNvsoZ/+y0ZTJCgSaBy60UKg1ZWQv3/USeyOUvkKfkzFis6nQxyW5vU Mn6S6krDXXGOYOcYnRiEJoinKyx+5lpJb5Iw26/0PkK2O/6bSiyld14nq s=; X-IronPort-RemoteIP: 104.47.56.175 X-IronPort-MID: 113831609 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:m6WjQKtJ/VtJsj1vUp0GeEqQ9efnVJhfMUV32f8akzHdYApBsoF/q tZmKW7VOffeZWX3eognOY6wo0gB65PTn9M2SlZprig3Enwa+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4rKq4Vv0gnRkPaoQ5ACGyyFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwAgsqQjSe1r2N5Z2EG9h9pdY+LMDkI9ZK0p1g5Wmx4fcOZ7nmGvyPzvgBmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osjv60b4e9lt+iHK25mm6Co W3L5SLhCwwyP92D0zuVtHmrg4cjmAuiAdlCT+Tmrq8CbFu7wlITFR5KbEaAkeSD1US6fc1ZK xYm9X97xUQ13AnxJjXnZDW6qnOZuh8XW/JLDvY3rgqKz8L84RudB2UCZi5MbpohrsBebScxy laDktftBDpumL6YU3SQ8vGTtzzaETcRBX8PY2kDVwRty8nupsQ/gwzCSv5nEbWplZvlFDfo2 TeIoSMiwbIJgqY2O76T+FnGh3enocHPRwtsvwHPBDv6s0V+eZKvYJGu5R7D9/FcIY2FT16H+ n8Zh8yZ6+NIBpaI/MCQfNgw8HiSz67tGFXhbZRHRvHNKxzFF6afQL1t IronPort-HdrOrdr: A9a23:YjBl2Kt0e3H/UgdydKJSDhnu7skDhtV00zEX/kB9WHVpm6yj+v xG/c5rsSMc7Qx6ZJhOo7+90cW7L080lqQFhLX5X43SPzUO0VHARO1fBO3ZogEIcxeUygc379 YDT0ERMr3N5CNB/KHHCAnTKadd/DGEmprY+ts3GR1WPH9Xg6IL1XYJNu6CeHcGIjWvnfACZe ChDswsnUvYRV0nKv6VK1MiROb5q9jChPvdEGM7705O0nj3sduwgoSKaCSl4g== X-Talos-CUID: 9a23:TFOyf28dMXTq7fmI3fSVv2QvPewBbyyC91L/HB6JGEV7Vb2cRkDFrQ== X-Talos-MUID: =?us-ascii?q?9a23=3A80wbhw2cCaB2ZmLhqwjnUEJTpzUj55quFUNRqIg?= =?us-ascii?q?9i9S+aiZ0HSibjG6FTdpy?= X-IronPort-AV: E=Sophos;i="6.01,180,1684814400"; d="scan'208";a="113831609" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W5feD0iZ0EwZsz89Vx2tXQ47rGmSgceff73kmk3VxgBToI6+1j2q/oMB7a/bZ5WFAw7hkxOQC33jbf1Rz9IqBoSovEW6fJ4JjG5NC2rA4VyQzJSpVFzYNGyhXc6dWrT6QBcZUxUbwG3229Sz3LQAULUFnXU+f+7CeONUOPyi1FEv4uwW/S6JjTGK9oiZ5/fxD8stagQ1WFELMcRChvLbZClElXUsiSM6KU0XXy6izBkom3ctZ1suz2aQqDqbL6ffTQf9wXBepVwKmbGM132T25Kje9r+RMxUGnJ5YbmgWsclDCCCVJA37r0DtNAuAUmpoC9h97NI0SU7DPHl7Drfcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EZxWrJPo11d4CXK2s+cv8367KL6szoxU2f/YBDm96Yc=; b=TWy7k+oBykGIOmOPmrFlpviO1Z/RZhIzAKMBO1RkZKIAi9hJR79FC21o97OHs+9SGm56Ka20foJPdI25bsVIhXVPuWwhBA+H4ftiquDeADCU+qhMtvQMm2EY7Ehnvr8okaXE2VWo8NWrn1ixo/+dWUju6n3TgJYOHm6ijNN5LPrcLl65JrtdFMxNlTKgIFn3YawXKQTtt2PyoLT6viwWz5TdMGMEo8JNKHRFR993KoAKgpvubft2cvjzt0Wts1IFoXsIXTlU0fKdxircaIMGozBhNNCQcArs4rsi/1jB353JugmMxTRUi4BELIIWppN8imiARi4rfCDuaD1sZcqEgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EZxWrJPo11d4CXK2s+cv8367KL6szoxU2f/YBDm96Yc=; b=CNZRwUJ+eTJbWw4JMEpFXdS/IF+wRIgrtIS1/w2TBt3+0c+CXcLqOxlo6vxSEbmOoprQK8QaZgsGtFLxVG3ix73ENOCNKOCm3PCnyxxl/rnurqZhdGxRqceDYIcHY+ldvImgcWkJJ0Qs+pHnx6kFMY1FHl1aRx3aehT80iWHwrE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 4 Jul 2023 15:30:40 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH v3 3/3] cmdline: parse multiple instances of the vga option Message-ID: References: <20230601130518.48874-1-roger.pau@citrix.com> <20230601130518.48874-4-roger.pau@citrix.com> <0a0671ea-9209-37fc-1d9f-1c38aff45bba@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <0a0671ea-9209-37fc-1d9f-1c38aff45bba@suse.com> X-ClientProxiedBy: LO4P123CA0558.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:33b::14) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|BY5PR03MB4951:EE_ X-MS-Office365-Filtering-Correlation-Id: 78ee22db-5eb5-4013-e1b6-08db7c92df33 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +X/J0xgXdr7wya8YtfXCBnJC3GzjfgpztNvt/E6NzAcOfwM3HJU26bTvRO752mex7NY71z5wVaAj2KhwYZtiy7dTaZkQNbJdx0NXy+IOxnAJ23qgV8DCVG2AV29ISrZIJIvrHEJz4X2gdATOt28hPMSHZrGs4dCK2cHCghoJsFV9cBD9RAOhxCySsXFA9gQQo4yrKkNomAvzs2+Z8dGlSmKLp1OTRd2KLzKW1yjqW8P/o+MqfMljGGeGleH20DFEvc+iOkFMJo6zPq6V+K6KMKu5i2ZLcIrtFO0RayYYppWygm5ZDThsu7xhNhfTpKmGLA3pP2jP5ABTYtKP/LlohqOGC1MPjA4jjXSKBoyEC6LhCaO3fw1Y1Z0NoxP9bSHOG+rN+MhQTswGyne9ouo3caIEeziLrEC6LP31OgCaoFf5arRJ3mt36RCDIeSgosmfXDiGoZzyBnmpOTN4Fk3SUu5bbR74H9E0mfmTZJvO7rGssleP5W52EN0huGKvceUXX0ehD29u2/MzV5I9oQ8oZEmVI1XQxvvMubdoEkxqwKDTuAiiaR1nzXYAqsTgjOSJ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(366004)(346002)(376002)(136003)(451199021)(2906002)(41300700001)(5660300002)(8676002)(8936002)(85182001)(86362001)(186003)(82960400001)(478600001)(26005)(6512007)(6506007)(6666004)(9686003)(6486002)(316002)(6916009)(4326008)(66476007)(66946007)(66556008)(53546011)(54906003)(38100700002)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N09QcVgvRFZmTitYTUt4OFRaK2p3Y01wWGpnQzNpeE9vakVMYTYyMHpSUjZa?= =?utf-8?B?QmRiTkpHTCtaeTBLT3VRVUpGMXlDQnYwQmNyQ3B1MTBRK2Y2OXgrL1dnRi90?= =?utf-8?B?OXZzS003d0puZmIrME1KQ3RLNDl1ZnBmbHRheFJ2WlVCSWZWTnBBWTVQM0RK?= =?utf-8?B?U1A0dlZDWDBVUVlWWGdxaTVMOHFrS0ROOTluUXFEd1BuYTZiMTY5Y0hSaDFK?= =?utf-8?B?ejZoKzlwRGVzZTlsYkp3SFRCWTNwbklqNHQybUFwT3VTeWRpQ2JDTHU1S3VZ?= =?utf-8?B?RHJzR25MWGxWYU0xdUJxZjIzdlhwVVRpRGRGVTB2VEs2RXpvY3VaT2wvei9t?= =?utf-8?B?UUN2cVFmRjltNWFtNFdYaWsrVVBKNjhOYTlZOTJzOEg3bXh0ampORHdlSU5p?= =?utf-8?B?NE1zaTFsWE9XMm56Q1ZFYUJBRE1iL1pTdDkxSUNDRHdSSEphamRGcW1CMURZ?= =?utf-8?B?OWwvRFkrZ3FkU3MwWElnVkQzTnRCQzhFVy9pSDFaRENjeXdJbkNLYUZMUFVM?= =?utf-8?B?T1UyUzRWV3RwSERSZ0lRalE2cExjcURZVjZTQ2lOZ0pVTWhsWkwyMXpkVzZh?= =?utf-8?B?dG1GMzJKbzVnR0RKV1dDWmlEcldYNUovTU5CSjV4TTVhcUVWTFZpc1QycWEv?= =?utf-8?B?VGIxQm5WUFMxQk9tQUN5UGdUeTM5NGhnTzJ6RnFXY2N6R3NkL3pFNWxZc1gr?= =?utf-8?B?M2FNUnB0aytSSmRMaTUzeUxIVjg2VHdDeEJNZk9tYzQxVEQzTzNNL3FvZGFt?= =?utf-8?B?eDNKZmx3QmdXbElWZHpyV2J1cHIzV3U1NW12N1hJTHJvcm4vZkdpdFhBK3Iz?= =?utf-8?B?UGhicmdtVlZ6RHVXWmZ4dDJsa0RlVVZGQjJSM0p4THJQYjRJdkR2bDczYzJz?= =?utf-8?B?blNzdEdVWXpqZlNSamZKaWlCdkk2d3loQXlRbVpqMXNyQWI1Ky92NkZyUmc2?= =?utf-8?B?Q0h0ellEbHZJdktrS0JhZVhOQlJrRDVXRXkzREpsQnZYUXdoREF1SHBMd01i?= =?utf-8?B?V09WUjd3UVZET1NWRFNqOWltQVVVTzJBMzFoUFc5WlpoY3A0eEJNUzJiWVZI?= =?utf-8?B?OWVqZkdjS2xZNno2ZmoxS1RPMFVQQ1R5cS9PR3p4aktBQlVXQ2ZwSmlKTHZp?= =?utf-8?B?UE8wSExja1FJVUNnMnUrbE10ZEZTL2xnRzh4b3NHVVVOak5SNmtoWVJmd01S?= =?utf-8?B?LzFDZjFTSFFidHVTVWR2SHZhTVcxaUc0NUEyQlF6NHk4d1lTOEMxVzdNZ3dY?= =?utf-8?B?NjdsTDlxY3R4K1B3M1lhNkxBODcwYlRMMEIxbndYaHRraFN4b2Rsa3E4SUNt?= =?utf-8?B?WUdIZmRIUE1CblE5cDYvVEJKNXpici9QdzNYK2lWb2FqOXFMbU84U0lDMzl1?= =?utf-8?B?VmEycGwraVVzUjdUV3QvK2Q3MWxWYmVqLzcvSERVOFdwbVB1bFM3TDVQY2R5?= =?utf-8?B?STJDUm9naVZFQnBqTGl4QlJhV1BERHFKSzUyMllsa29BbmQrUDZvUjUzdC9B?= =?utf-8?B?cUVwd00vZnlWRHhVQ2VxQjJYTHQrZWhJczE3bW90OGYrajVkUjhZcEE0U3ZT?= =?utf-8?B?TEdIdnkzWU55bXhaMXBOUS9TR25EVjdnOExBWkR5eFJhVGpWcE5icnRpaisy?= =?utf-8?B?blhhQVQ5SlZmMjJFZHl5dWQvNTJmMlF0ZHhIcGVWb3I1K09Ka0tjTEY2YllX?= =?utf-8?B?QmZ3WThBMWFUTFk5OXhPSUtBSUlDVElJU1oxOTZBTzJMdUhOM0U0Zks2dlhY?= =?utf-8?B?WTIxQ3Y0TDR5L2VRS1J4QjRsMzZXd0VTK1kwZXFDcVVqNnNPQVA1Z1ppSmp1?= =?utf-8?B?TElSTXhrM3NWR1BuRXhSZUQ3dWVYdU8zdVFoM2ZZamJjVkg5RGxNNi9VenRG?= =?utf-8?B?clkvUHF3UE43aFR2UUNneHo4bmJJdzJLVVdrVGlnNmMyTTdQWkVBbDFEQWRX?= =?utf-8?B?RWpwUjYxYWlnaHBCT0dLWUtiYmdZcHNlcTFnK1ZXRFpoK050Kzh3di9BbDQr?= =?utf-8?B?TGFlSzZaOFBQVmxTeUtGQVp5YUdpWVFEeDRHcnZZUnBGOVNvMUM2ZTlvMUpK?= =?utf-8?B?bnQ3VmxjSGo2Qjh6aVFJMTYzRUQ1cUFjNkVTQVBzNHNzU3ZkT0FzM2F0dEs5?= =?utf-8?Q?SVPw8QNOjTux33irSzpgHNdVw?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: EbHfehsf/k1fDtUG1J/UoTAIcHl/qxTgAX0qXB917zRXskeBVospvMqRUquEv+wICNXrkmbKnV+Ieg/xgwkLlkTx33UNMFrluL0jViPyCM7TiOIvg3KmD5j0v4cnGwVgdJkiziAvtFoDy4t/2Ayq2xy5lPvL4QcoMn7MfkZajbw9L7EWWca1ew4jUOl1L0jdQSrUZzugDw9YL4I/wk6sPLii4EWYRXQ8pvqvPGsxfSQ27HyoxGo8Av2uO1Hu2igqEqpIBqe+Ucfg36dRdnOXLdV+gIOSPeVAcg6zA63u5H/7+5DGuDAfhDetlxuv1tpznHqym8txQuPCStjmKKyBPqNVEOBTG2xcGQDQAMXIqOuFM9WBFd0mTOivCtFvSoDfMi+PuMakrTRUefMg3n6/7+lLeZ0hqyKx/cBaAPwqQVLf3wK39PoSfl87PS1yrFirrHBkkksCG63yTbYK4/6r1aqR8kSaWGJ2mEud+sCGhvKgPxubuVHM4wySNbvPRYMNhdkLedpBWz3EZtnCXQT7cbccyuzPMe/EqS5DRD9K3tpN3Vck79QAHd8mHhrVGaies5h4PSuwXi7fHeyHLnAriaDyZC+9hIE9AqislO2u4U6tuQdvcX3a1mrGkfpD3HqrtzsnXfQFXp1xagFB7vvIPZ9NE6SJnuCa2FS0+oAvWtMaH9Kbl9fNamdYPQihZbS9s7vTmDNZAazBZ4zyU+dPTyITSad2QSMjs9aF4Lvc6oKG0NwJ/pntII7cZX7molRMILTdHLlH41g+x1fPpLIBW5eQwhQHRAGaND6TiNePI3VUiLAZnJTFE0NwAzrmAkm8BZcBAUgbIvNTxfHoz528Bqs5tMGo3OymxbeI3gqtPgA= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 78ee22db-5eb5-4013-e1b6-08db7c92df33 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 13:30:45.7618 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: C7KVbj2cthHtbxOWpQAy3zULDXrC9Mamz3wmzCS/lUKN/NG4/F7p0aVvXc23KrOx5f/Ut03jvtwJ5GWbPqtpkg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB4951 On Wed, Jun 07, 2023 at 12:07:54PM +0200, Jan Beulich wrote: > On 01.06.2023 15:05, Roger Pau Monne wrote: > > --- a/docs/misc/xen-command-line.pandoc > > +++ b/docs/misc/xen-command-line.pandoc > > @@ -2628,6 +2628,9 @@ with the specified width, height and depth. > > `ask` option. (N.B menu modes are displayed in hex, so `` > > should be a hexadecimal number) > > > > +Note that all the occurrences of the vga option in the command line are parsed, > > +and hence later occurrences can overwrite selections done by prior ones. > > I'm not a native speaker, but is it perhaps more "override" that you > mean? TBH I always get confused with overwrite vs override. I will remove the line as requested by Andrew. > > --- a/xen/arch/x86/boot/cmdline.c > > +++ b/xen/arch/x86/boot/cmdline.c > > @@ -277,59 +277,58 @@ static u16 rows2vmode(unsigned int rows) > > > > static void vga_parse(const char *cmdline, early_boot_opts_t *ebo) > > { > > - const char *c; > > - unsigned int tmp, vesa_depth, vesa_height, vesa_width; > > - > > - c = find_opt(cmdline, "vga=", true); > > - > > - if ( !c ) > > - return; > > + const char *c = cmdline; > > > > - ebo->boot_vid_mode = ASK_VGA; > > I think this needs to stay here along with the addition of the related > "else if" below. Otherwise I expect behavior for e.g. a sole "vga=keep" > on the command line would change (in no longer prompting for the mode > to use). Done. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Jul 04 13:39:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 13:39:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558360.872374 (Exim 4.92) (envelope-from ) id 1qGgFq-0000Ym-KH; Tue, 04 Jul 2023 13:39:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558360.872374; Tue, 04 Jul 2023 13:39:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGgFq-0000Yf-H7; Tue, 04 Jul 2023 13:39:42 +0000 Received: by outflank-mailman (input) for mailman id 558360; Tue, 04 Jul 2023 13:39:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGgFo-0000YZ-Rv for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 13:39:40 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20601.outbound.protection.outlook.com [2a01:111:f400:fe1a::601]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 38646085-1a70-11ee-8611-37d641c3527e; Tue, 04 Jul 2023 15:39:38 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS8PR04MB8215.eurprd04.prod.outlook.com (2603:10a6:20b:3b3::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 13:39:36 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::9bd3:48c9:ff58:9880]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::9bd3:48c9:ff58:9880%4]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 13:39:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 38646085-1a70-11ee-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l61Y8kkue908wus6N9YdSUQoJ4bADhLt4ftLCHbb9OWwi1mQFjyNj4YqbOJZr2zWutmNp43J3GiWq0NqjMefmX+MeX59wSfxtIOajI9kk9fnNK1k5GeaalqAQVoB6d87R9qoAPsaNovs9W5schgkH/lxn2sqPvrc6OEaEDu8prMO1I8AgaS01aE67upmYiIPb1KihOPXyeRmQhqppT1fpdq0yk/yZ2xHXIuJxVRaIPC4b94+hY63hegWzyv8v6gO8xnvJYgAbcgrmX9llrLhqjuHQSiL61mHQk0iY6V+0k2wxRHXHTNMQLevFVJ0JnAYDPzhrQ75SXZre7moxdgzyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=134+lnW6M8o5uUgaYmeEKgQrOjOjiI5sdQXc8ZqDUTs=; b=KlXho/ymW1jkwDC1ltH7pF0H0rtCM8IHjsq/IQ2+isGcbRsit3ZwLFAhDBFtckmZJuebQIVY4Wo0ABMB+vECN80UbzG3D7JJ+5J0xU4wFCNWqkCyaExoS183q8m8/j2sp9Yc5DPHKLJwyLB41aUhoW7pXxHc3rmB8S9uSH2KJCdR4C6dz6x4me+kkFETECcpgvyvhTugk5N4OYnD9svylrj8+/ytJbSqebL4vgVA0UiWsZvFf9RsSZoA9NQQ5piTzsHBXd/8v5YHksexZ66ATZbIG5ir00ISotWOEWreb4i540tB5YT33kBm+TxAEsqmr0Hau8EQOUdOpFhw6pBEyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=134+lnW6M8o5uUgaYmeEKgQrOjOjiI5sdQXc8ZqDUTs=; b=LMXmkm44OGkhtEOoVQa8Q5PCPHrx8/0XIDXgOR1dE9E/d2OqDBqZSsus7JE8uuyT6xIL9IiugmOAbgCzzeA6uABdJZS5u4lFhhS3L9SP7tS6zxawTpEGgNouu4t0CsNL5c/khyUX7XKwfO56p86U/ZcYvUr76+pweudluLHLhgucYAjcMoq5NHv27JRyWLzUCcRwlUosPDz70TswYepCBSP/HGPuNCLc7496LKkNCn+gefmOh1vBzo2/BJFS9p2k3ZJyrsHS+wdCif5tTYztOc1/LHaBkYgqKSQ+Etu2QqptqhJj4Dt7d6pwVPrFhbdmCmNrSPAnWmCs/5Zj75lTAA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4cd67316-4347-a3b6-0f4c-1864ce08ad5c@suse.com> Date: Tue, 4 Jul 2023 15:39:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: XenSummit: Empty per-arch files Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bobby Eshleman , Alistair Francis , Connor Davis , Oleksii Kurochko , Shawn Anastasio , Timothy Pearson , xen-devel References: <2aabfb63-1a2f-bb02-488a-ea79136bc6c0@citrix.com> From: Jan Beulich In-Reply-To: <2aabfb63-1a2f-bb02-488a-ea79136bc6c0@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0193.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::6) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS8PR04MB8215:EE_ X-MS-Office365-Filtering-Correlation-Id: 920c3806-19b9-44ad-2da5-08db7c941b92 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YHpTc6hKpmGrUlg3bCjIDWawluBEccKcDmLoSBXXpbSpQNcwSt3FX+OT0MQPoKdBf1Ge0kC43TabqobLZMfIwbVCob7B2jpnI241+NoiNFEEUgleUniUkpki5kVyHDOXkrHnFzwuhXkSjbv/Ep1wmoAit3bT3jqrmx0h7uK0lP0lDPYMw9xPcq812/5OaK/hjMjqo3fYK2h2aydMPZLKsEYJkYe/c4YSpSYZJVlYJkfXcMmeIgRne8GuGkosBpPqq/FDn9MO5lRAChSJQQ/MTOtL0RafOAegOduitE6MfQw8vHsZMzqYmkGrLdiV+vbbT6fV78JAtz9GtSiYRHcCJxvKMYap9klVNM4Am6wKLMIh7KCTeG46+acZ1B09honm+XYxvJG4glcWnxDWzrGn/TB2hwFpCizeB/mC3lUlfLdG72PfkVJLCHpFYPFUy94Ix1ttKj6fbG7yTjEa4vZVRquYSPAcmhVZUdIzHqHhuEid342yEy3eg9sdBA1SiHcpjnBsTQ5Wg6jc61zL7BTzE5lO+O7hnALgo6Zmr2SouolNxlAk7kEC5xp5c6DRahaC7Mgnp44T1IQF20Zx2sz4/mgPS98n4yW1hzRzWHkiMyH/v3H/13S8e0JcYIyR5QxZcS2wOty/V9OJjBOgLMDMYQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(346002)(39850400004)(366004)(396003)(376002)(451199021)(6512007)(6506007)(53546011)(66476007)(316002)(38100700002)(4326008)(66946007)(66556008)(6916009)(2616005)(66899021)(186003)(26005)(478600001)(54906003)(2906002)(8936002)(31686004)(8676002)(36756003)(31696002)(5660300002)(7416002)(86362001)(6486002)(41300700001)(6666004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aUtNTnljbC9iVlBGb1dWNExVU3JaeGFBeHZ0Y2hDbk9EUEZNbGcweXozcTFS?= =?utf-8?B?NDFTWkhBNks2ZGlBcitGNENwQ2JnQU04eUZGeUxYNHhBMG9kc3QrZnppVXlZ?= =?utf-8?B?K1k0Y0ZxTWloTDFRYlBGaEdMUWVhamd6V2pmdElINlM0SWp6VVBRZ0xLU1VD?= =?utf-8?B?ZzZPSzVJTE9OZ1VvbXdJblgvb005YmhDRzkyTE9nazg2WmU1WmNyZHhaV3NP?= =?utf-8?B?ZUJmZTA2ZXI5VzBrV0w0Rkh6VGl6enQxdUs5TDhialV1YjVXUHBvKytTN0Rq?= =?utf-8?B?TnpramQrdlI5WXhGUWFyT3JudmVUM2pCUkRjeW5oS252eGF0MEczdy9YbFh3?= =?utf-8?B?QVRHMVdINzBaRUZQK3liU1dTa2V4cTJoZkp0UnE3RE4xZVRzeFgyd3NqUWY2?= =?utf-8?B?cEF4UVBIQXZYcUhsYXZyaHNPSnhHS3A4eGZYV2p4WldqajZpQmVOWmd1RUgr?= =?utf-8?B?bi9sVnUvTHZ0eXA1TW93RUZOei9lU3dUNjZXS1lDeERqWUd4YzFpMkRoR2FU?= =?utf-8?B?V1hBQU1mZUFJSkxEMGdXYlBSeHM2QXV5ZUFyaXFSVC9reUxhUC84UkFCOWpt?= =?utf-8?B?Z1MrdWE1clRJWHVwemRPU3FzL1hWQ2lHM1BRcFpwNk1oTlloUlVXd09TN09a?= =?utf-8?B?ajIyMVlkS1hDMXpYODl5MVduL29ZWFZJcnZhaUpweDJRcGJBUkZ5Y3FFSzhY?= =?utf-8?B?OE12d1doT2ZKaFBvT1VxRDFYeGhzb1Z4YnNkSlY2R21HQ0tTaW9ROTZ3MW1a?= =?utf-8?B?R2lKMWRkZHdIbzdWV2JHdUx2RU90N2NCVkgzUEF4K2VzQWFSdnRPWVo4eDN4?= =?utf-8?B?VTJpVFZYL0JYeE1iU3Z2TG8vS1k5MzlvanArc25KcnFOQ3NRSjFLY3VSQmFF?= =?utf-8?B?UHFGQzJmT1RZS2hHYVIvUG44VFpYVUVxb3psLzl2cnVGa1JmNkRmaTZqUHF2?= =?utf-8?B?VTJONEpIbFNOMlpjWWQ5NGF2bjBEN1hHcktxU21xU2ozVmRhNHhOQytYdVp2?= =?utf-8?B?eVIrRUFoQWxqbFB3bW1KNERXWUl0anFwRlRBbnNQUG95NVhZNnJ0RE1mS1dR?= =?utf-8?B?dHl1d0pVQ0FLN2ZSMHNhNGFPYXVzUWVrM2k1MkpUa0M1NVRTdXdsRVBmME5p?= =?utf-8?B?OWU5aWs2dDE1QzFkSVVUbzVZL0NIdVlJYUEwclcwLzBwUzYwVks2cVFtV2ls?= =?utf-8?B?RlM0YjBXczlBZUtMU1lXNWhjb2FtZG1QUjJnbEpxc05SKzZLUVUrYTF4RkRO?= =?utf-8?B?OGFVK1RVeG41Ym0yU0crdXRpL20vNTBXNkpaNncwdlBFU2RVQmp1YjBDVmNV?= =?utf-8?B?emtWYlJQdFZNT3FhMytxR0xDOXkrdUt3dXg5czVLeUdleUpJeDBKZ1VWUVly?= =?utf-8?B?c1g4NTdlaXNRQ2RnN1E4WkpjeDY4OHFzRjF4RFBRcnp0R3R1K1BpNzhITjdp?= =?utf-8?B?VWNWSlkyWGJDWEFMU0VENU9IbmlCRExWblBzd0JIVlp6dWtpT2ZEWmJrV254?= =?utf-8?B?MnBEdDg0WFU4citsL0w3Y1FYQXZ0L0UwQ2VnVXF5Z2F1cUZoalhHekJKU1Yw?= =?utf-8?B?ejFxTTM0ejVobmtqeC96S1ZvWWpVcDhtdzhzbkxzbG9xUGF0aUdkQ1BINlNZ?= =?utf-8?B?ei9DWVd1eGVQYjFIT2ViUEhZenBVcEV2RDVMam84WVV3T3FpTHRtZDRNb2Jr?= =?utf-8?B?Q0hRcEg0TWMzZWhHUm9Ja2NSa0x0RGlIY29JZjJEamZ6eWp4OHhpN2txOEZX?= =?utf-8?B?QkhWWG1mMjR2dnp3K1ZWbEVSdytidWRJajZuN1BORjNieVpXTDdtaFFpNllz?= =?utf-8?B?TEc4eU9QMjZPaWkvVUEwb0ZRL2Y2NTYwTWdta21oWDdwUVZydEkxZUxRMjJs?= =?utf-8?B?QXRocTZKZkpYYTlaVzNGR0xvR0c3RXhqejdTS0NONlRORVNpOTd1WnIwZlda?= =?utf-8?B?eit5bzNRZ0NINzQySlA0bWt3ZS9iQ085OTJIOGd2SlJRZXlEMFV2NXc1NGpV?= =?utf-8?B?RmlkYUNNNmUydXhRVEFvQ1pKVmhlNmlwS1lGWTJnY05iWjZwMm5BRFp2QmZi?= =?utf-8?B?cklQUCs2ZVcvNElDWWVKKzQ1WlZPSDNHZmVaNnJwMzBpNUdPOWUzRW1xbW5q?= =?utf-8?Q?lZle47huvORstflK/oUnhINJo?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 920c3806-19b9-44ad-2da5-08db7c941b92 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 13:39:36.4287 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vVaIAMskdRQH7nI0dHZlUb4wBaSFZTqYvJ5XCUa3jF/M95E4QTiGlqyDsQ6GPy9u9u4lGmwW6+uJKFEEbQyTqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8215 On 28.06.2023 13:32, Andrew Cooper wrote: > Hello, > > This wasn't a formal discussion point at XenSummit, but Oleksii pointed > out that it was still a problem, hence this thread. > > As we take on more architectures, it becomes more and more important for > things to be handled in a mostly-common way.  With that comes quite a > lot of including , and the arch one being a stub > in simple cases. > > It would be nice to get rid of the stub files; they're irritating to > deal with, both when refactoring and simply for the file bloat they create. > > There are two options which come to mind. > > 1) Use __has_include().  This would be ideal, but would require us > bumping the minimum GCC version to 4.9.2 as a prerequisite.  I'm not > aware of any way to emulate the necessary behaviour on older toolchains. > > 2) Have a stub "architecture" which is always last on the include path.  > This would reduce the number of stub files from one set per arch, to > only one set. I'd be in favor of 2, which iirc is also how Linux does it (in certain cases, iirc; or maybe things have changed yet again there). They call it asm-generic/, which I think is slightly better than anything with "stub" in its name. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 04 13:54:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 13:54:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558364.872383 (Exim 4.92) (envelope-from ) id 1qGgTU-0002wa-Q2; Tue, 04 Jul 2023 13:53:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558364.872383; Tue, 04 Jul 2023 13:53:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGgTU-0002wT-NA; Tue, 04 Jul 2023 13:53:48 +0000 Received: by outflank-mailman (input) for mailman id 558364; Tue, 04 Jul 2023 13:53:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGgTT-0002wN-DH for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 13:53:47 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20608.outbound.protection.outlook.com [2a01:111:f400:7e1b::608]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 31d7aeba-1a72-11ee-b237-6b7b168915f2; Tue, 04 Jul 2023 15:53:46 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB9PR04MB9867.eurprd04.prod.outlook.com (2603:10a6:10:4c0::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 13:53:44 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::9bd3:48c9:ff58:9880]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::9bd3:48c9:ff58:9880%4]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 13:53:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 31d7aeba-1a72-11ee-b237-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NvkVe/SVmonf06KVTBVQjOQu9eFhIfznAt4LpPyusr3Y8hc1JLBkivivkcxrvwk1ZTUw1uufEy2iZXS5viSCOSSuqiXIRAGNJr2VvDuzpaaQc9sCrIJnRgMoY06exgJXEbyC/v2thlCrUxeOg50qHH3jP3N3zHaDrQhvTbBuG1fS4qaYrMZgfEP7BVaW3rutIoZZuRuDMYWQ3wYWjNycKBCGo+txeK+3xtheo2/DLErqgiAUh0vYXPSLDEUp7KBaIXdKM3JjnKLbav9FDOpcAVp73ZveKDHiK06Bzq0B4yBtJ/2nsyGsQMMdhiaCAHkk/Wpe6Q/mbwt/NtiC8jcNSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kd5boOvS+q5rVVsOKW3C9SGZ7jvv4HJO+PM0gqNKnl4=; b=GsUKpYjO5BvYsbFDTWz7YzsAZG4so9wRCgvlxxT06zTUBD6l5X5uqhYAt1kMCabMGyai0Cb/Bp1JHZaq+HZOzUf5v1hGAkBM173id0nB7fGsQpZLGVTWssSw0DCjnpWs8/g0EFKNy7HoSSa3wUlV8IgpzuF81t24deJLq4jksjH2zuOG8ZaGhxyn+n9/WQAm/CCR2CVrBUVlw2K5vTlksank+dgM8NjkDnI6Gqhpd7dO3xLrkz9Fq0xka4BiuSANAhNc6C7iOZpLY3DjHb9jIALS6cSOCSktrTW9EiFdgNOAMv2LMz4zGkyTPygtalov2Ri71o8OaZegB+3Ra1sX3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kd5boOvS+q5rVVsOKW3C9SGZ7jvv4HJO+PM0gqNKnl4=; b=BJlaXcAK/ynTnuUQfTUlOT7epSd1VhMqnWLflzmXucz1ZMpSiuFzzjlaY3CUrKcImgFs3pqA9ZkJrNO0LZXdPnAiYGfYooEX5Xe5mdj63vIbTq/KLy4ahqoKC7VA+NJRtVeQJUTglDB6xlEiVCBgVFDJDF6btxaB4UgLMChfKeedQGmSbjYqMVfshVFJ+AE98M6nRrOiLnX93bXzxmLZFtUx88xDKFf7JUEMGv+uTQ1rUrEoDfyKv/77Pwyq4DlySrVQflVAU0ui2Ka4lGRovkjVpRCbYfKqi9h48Zl8ohUsDOTo8ByaOR6KiF160FLbdw6vNfsbIf6Ag0ZLwHUg2Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7c7d23ec-5961-3370-b774-b547f1316066@suse.com> Date: Tue, 4 Jul 2023 15:53:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [XEN PATCH 2/5] x86: change parameter names of nestedhvm_vcpu_iomap_get() definition Content-Language: en-US To: Federico Serafini Cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Michal Orzel , Xenia Ragiadakou , Ayan Kumar Halder , Stefano Stabellini References: <7392b1adc50c77855bec846f1a14e30f6a8ae1d6.1688049495.git.federico.serafini@bugseng.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0049.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::22) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB9PR04MB9867:EE_ X-MS-Office365-Filtering-Correlation-Id: 98858728-3020-4f80-12a9-08db7c961505 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HoJF3DZWyvW4E2fysxjh5thJm5n03bF1xfs6FjA58EYUa56oi+Q2Gz014dlxdGTjqoxLn1C2E89WnsDLMGC6A8IyuY0CzVkU1TTCCIpiOS5I0knCKSR4TQaRcA5JQNIBDf1ArNPNoQ5UHuSwr3G2Q0n6QGQp+INYgB4D50yOn4aagwQ2MfmTFflXBKvJpNjOpCm6FkeGBdhZx2EeiogilVqzpONoU06dzvkQjHb4HiepvyYPuBiObPbGd0suRmtUAAOTe+Mlb/Cyt/szLjZGH6EomqPpEfzWIAWGRCAUUIhotPLxtCbKX9JiSZLXW7FR0gpzvUWhwRnSvyke8NWPsR4u5nVVynShVbFFuQfq8NUgHUkGic2TKfragl2oivhvQZmwFcHPfxBj3VEjeIMUtfoWCY7enN5/gj6NmCD52Eo9eV/XdljeJ85ZTrd4oNcVaTufABnOPudcIszTikFyN3QR/3bQ6BsuA5r4UbliRWKew2k6m6I7/XOY4705jlYC+3jGSmG9tbj0C++6SOV6YmhZeJHkvUQY5ZeCWrPziudm1KX83U8mvBxlm7bIDDH6qx0iHiE2RPU9GbwiiO1kMc3ucCgVmiiRYOfpxpDPjVRvVI5NjC4X6UxqxZXbmG3n8AmADI3myC1xSGIRtXV7vA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(366004)(376002)(346002)(396003)(39860400002)(451199021)(6506007)(66556008)(66476007)(6916009)(4326008)(66946007)(38100700002)(478600001)(41300700001)(316002)(2616005)(83380400001)(186003)(53546011)(26005)(6512007)(54906003)(2906002)(7416002)(8936002)(5660300002)(6486002)(31686004)(86362001)(31696002)(36756003)(6666004)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Zyt3dzRHajRTdW1nL1Z0V3FkUkpyUG92VmJEVjlDekcwM2h2TkNwckZDN04x?= =?utf-8?B?cWtQbTlEK1p2ZjA3U0VNQW9rVnBSOUtHcDZBT3UyTGQ4R0ZRZFE4UktoNEFG?= =?utf-8?B?Uk5hM0c3VHNjR0M1NVVyYzBWaE9uVzkyUmhrdFVPb21rQWQ4ajBlWkR4Mno3?= =?utf-8?B?L0lKSEk0SzB4N2IyU1BScWU2QmNGcnpBaDFFR3hUSTlQTzJYb0F2YVh1Sy92?= =?utf-8?B?dUY1UG9zWkZGbW1IVGRLeE8velhONVUzTTdMUW5YWVRIY0NRK3duV084NUtX?= =?utf-8?B?OTU5T3lIbmVIb3ZTVWh5UW9tTnNiM1h6REJwWno5OHFnSng1d0RKR0JEejBi?= =?utf-8?B?T0daMVBZNzhyVkQwcEN0S2k2VUNMcDNTdUdkNlpPRlBNalNIazl6QVdhb3pT?= =?utf-8?B?c2xPRWxRaHBmRnRma0xieEJmT0NLMWhTQXh2a3VyaGNXc3BVaVI5L3FheTk1?= =?utf-8?B?ZXRXQ3FFV2U5bG9OSXdFK3BhSnRHUzErTTRxdGZoUnpYOGtHd0FuZld3Tnlm?= =?utf-8?B?dTdab3QvZlJ3dlR1RVRVMmRpK2FLUzVoZFJ3clhpQlNjeUhPNWkyY2VQODZB?= =?utf-8?B?eFNDRFpVTXpvMUNTTUgySFJGRW1YMDA5ZUthM1VNbG5KQVpyU0V0dWRkaWli?= =?utf-8?B?S3I0MXV0OW04ZXBPVXNSaFJtVUN0U2c1SUEvbU1MTVFVbnYzcDc2RVdHMFpI?= =?utf-8?B?RUh1OW1HTzdMWWRXbWtEdHNLVWxaVEpkWi9pRUh4TTg4NnRCQ1BtQnhBdHJj?= =?utf-8?B?MUZZRFJCcDlWalVQTnJRL3ZPdklIa3FHTUs4MG5aSVdmelJxMHJwUXEvZzFG?= =?utf-8?B?OFVtLzVIenR3UFhkUkFDcDFmdFRLQmt4S2sreC9LNm02SW51VFpWTDFoMW5U?= =?utf-8?B?UitnN0dwNVhZUUFkRm9tUURINVRtS3RHcVhidUNtYW1jMVVDOHdsSHp5Zy9K?= =?utf-8?B?d3dYRFJidkFCTVFpR1hGVUpET2RZcDhSVXVQL29XNUFjS3RkUWxudmRhSjZC?= =?utf-8?B?TmlRY29UQUtmL0M5ZW9LT1V5Z09zUC9jQzdwRnVUS2hrOFc2c0xqM0l0OUNE?= =?utf-8?B?RHJUTTlmeEF5R3E5YVZsVm5xbnlNZHZKRWQrTmJGRVM1M21yWnU5UjRkSzhL?= =?utf-8?B?cEdYUmp1QlBzVTF1VWNHSzdBejUvdTZIV2ZMaFIyZXc2RGwxOVEwVGYrQjJi?= =?utf-8?B?MXhVY3U5NERBeHRTQmk4ZFFaeHl1ajg4VlhxZm1zcUxGZ2RRT0VaY2RrOE5r?= =?utf-8?B?RW1tTVJRdk9EQWFMQlByV3BoaEpaWldVZFdkNzNZbUN3ZnhrK29oL0lOR2p4?= =?utf-8?B?cWVVT3lVdjJVcVFEK3BZVlFRUkRvZnJVcGNjZ1hpdjBIbW5hNncxdE9OMXRq?= =?utf-8?B?d05abU9WbXdYcm16dDJ3VFdDOW9ac2M0blF4YzRQNVZUUHR4UTMvRHhsZHpJ?= =?utf-8?B?MjhkYmk5bnN1VitnbEQ4dm1CV0RxaG9hWmFVT0txU1NyeStjL0RLMEhqbThX?= =?utf-8?B?b3d1UHNEb3Y2MDVVd1M1Y09wWW5HbFNaOTd0U3BpU0k1MHppcTRxd2h6ZlRE?= =?utf-8?B?SUFraXZJbS9NeE0vbklUSDNaYWs0eDBSbzc0WWREZnFZSzhtdzNjWDdwRm9h?= =?utf-8?B?Mjg4Yk5VczFINU1BbmVIM2FWMVR2UElmK1diMTZhdlg3TFJYbmFzRkRLcGNr?= =?utf-8?B?QlluUzFIYlJQS3RZQjBsV3pPV3J4T2xGQVM1VmU3SzJvOTBpMnNNU3dTMXYv?= =?utf-8?B?VDJoR0JBYjdYbnRUMVVoVXd3SzRvcnc1cHVKS21Xd25ac3FydVVtdjdia2Jz?= =?utf-8?B?dTBaQURza1ZlZ3FVQVc4NTdwcHBxUDdFT2dSazU1UnFwQ3p2dmdyamFST0ha?= =?utf-8?B?ajV2UEdsUlFIQkg1eFd6MWhUdVZUOEdTcVdoRFhPbnBYQUxqQjIzcmVTZXRM?= =?utf-8?B?Mi9zdEVST0Q2TlhpWFdQdFNJSEg1U0M1KzBwQVcvYjdpWGgxeEJjUjk4MlpH?= =?utf-8?B?ZkRCVnZVa002ZVM2RGtOR2FrdWluWDBEUEhmc05iYXJvMkNLM2pOaGZHeHBP?= =?utf-8?B?TnBCMFZpMDVmZTFndzdOcm5TQzJCVXZmWnU0WHQ0WmsrSktPeUJVOStFZzZu?= =?utf-8?Q?3z7/3KPJzMlDzP0v8oZNPKykB?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 98858728-3020-4f80-12a9-08db7c961505 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 13:53:44.3632 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bUXeJrozc0jJ2gzS+OwXSW/5b/+6K0wbTzTfE/dNCUayyaECm3mQnFkTkisl1XdpSZSCGVrfzVG745DOUf/0TA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9867 On 29.06.2023 21:25, Stefano Stabellini wrote: > On Thu, 29 Jun 2023, Federico Serafini wrote: >> Change parameter names of nestedhvm_vcpu_iomap_get() definition to >> those used in the function declaration in order to: >> 1) improve readability; I see this was committed already, so ftaod no request to revert or what not, but I disagree with this: Longer names are generally hampering readability. What would have helped readability is if coding style was fixed at least for all the line which were touched anyway. Jan >> 2) fix violations of MISRA C:2012 Rule 8.3. >> >> Signed-off-by: Federico Serafini > > Reviewed-by: Stefano Stabellini > > The title would be better as: > x86/nestedhvm: change parameter names of nestedhvm_vcpu_iomap_get() definition > > could be done on commit > > >> --- >> xen/arch/x86/hvm/nestedhvm.c | 10 +++++----- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/xen/arch/x86/hvm/nestedhvm.c b/xen/arch/x86/hvm/nestedhvm.c >> index ec68551127..64d7eec9a1 100644 >> --- a/xen/arch/x86/hvm/nestedhvm.c >> +++ b/xen/arch/x86/hvm/nestedhvm.c >> @@ -155,19 +155,19 @@ static int __init cf_check nestedhvm_setup(void) >> __initcall(nestedhvm_setup); >> >> unsigned long * >> -nestedhvm_vcpu_iomap_get(bool_t port_80, bool_t port_ed) >> +nestedhvm_vcpu_iomap_get(bool_t ioport_80, bool_t ioport_ed) >> { >> int i; >> >> if (!hvm_port80_allowed) >> - port_80 = 1; >> + ioport_80 = 1; >> >> - if (port_80 == 0) { >> - if (port_ed == 0) >> + if (ioport_80 == 0) { >> + if (ioport_ed == 0) >> return hvm_io_bitmap; >> i = 0; >> } else { >> - if (port_ed == 0) >> + if (ioport_ed == 0) >> i = 1; >> else >> i = 2; >> -- >> 2.34.1 >> From xen-devel-bounces@lists.xenproject.org Tue Jul 04 13:57:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 13:57:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558368.872394 (Exim 4.92) (envelope-from ) id 1qGgXD-0003Xn-95; Tue, 04 Jul 2023 13:57:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558368.872394; Tue, 04 Jul 2023 13:57:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGgXD-0003Xg-64; Tue, 04 Jul 2023 13:57:39 +0000 Received: by outflank-mailman (input) for mailman id 558368; Tue, 04 Jul 2023 13:57:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGgXB-0003XW-Px for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 13:57:37 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on062d.outbound.protection.outlook.com [2a01:111:f400:fe0e::62d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bb3b867d-1a72-11ee-b237-6b7b168915f2; Tue, 04 Jul 2023 15:57:36 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB9471.eurprd04.prod.outlook.com (2603:10a6:102:2b2::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 13:57:33 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::9bd3:48c9:ff58:9880]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::9bd3:48c9:ff58:9880%4]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 13:57:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bb3b867d-1a72-11ee-b237-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SlYME6nsKhCsEUXXuLCgfFkqTUJkVDcYuYqyZEPp+uY6acogP1iMPN88ER5CLvCEE508rhU3V8CU2SBoaEQErDzqXDWCbQWH9ZbQbI+whlJB8NZe0tTZD9bJs3EJlC1E1pnqiL06ONr4lTqdTYdHwCdy5xYUUa/E7Q30zj66XygyjD7wABPraZI1FhXtxJjpoaarDl+vFgSfOXY7XTi1qHe1grwtbUf0qSkMyoz7THMNxGPR8mK19u2INntrI5NtzSyUx4DVG3Xtb8jC8nWSGBYGShz6NfWIEtzf/yx6+3/gO3/0PEdNzOJfuJ+hHj1Ylu6H/7t3O83GhhTpBhk/8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MMuiqdglR/yPIudSk30KF3EwEAcpwXt/Lg63G9vNeGc=; b=e4PwJwn2JqQlUthLSaceqKYkEyPViknhEYLSz3TPlED9vqmFoAbKkTdgrZkqldgSEt7Ujl6NpE6TwUAp5M+gK3/UHyiTUpsYiPTt+5fxHXQ6MjAQHur17UDEXda0NwyYH6I3X6muVr7JWX6avSpw6vV6jgkDyBvtpAvaIVs5TgNGPHPpzbtA9E8MqFLE1DoEJVLVHNyxU8PtQj1j1ojt9M6BVE8P6kUFSaJYIPVi9Z/uV8vergM+ESTvbfjo6Mw8ZGVys0t6+xIHUmll2uvBAtMnRb7fhYZM2J8mJAUbIudbYZAtJyLopZZwMvOzY6lcURbx5Y5W6Ml1ZCU/qDMCSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MMuiqdglR/yPIudSk30KF3EwEAcpwXt/Lg63G9vNeGc=; b=WIE4TekLfjBEu4xhhQXwNQ9E8ccAK5MMAYW4pGAKj2cHeVBcO3tRfdXGWy9vex4He6jjfijlUGxllcfZbtDMu/6JADURrnmU8K9BJmyZKY1Cfw+jNzaWXPH43Urpz1L4xfsgF6BMUMVB/yAnzBcWYp7iL1xaZTO6nzi23Sx39pIbXnDc0ZCJ/43AjQnZ3nLGxaJ5ZbQx//J/AQ8C3/qyAaGFLNnOVy72AuqtyU3jnwfe+tMMcRz2lOn6ecrCCVi3JZud6TyFkUW5Uv4LkchUwAq0PBT9mbjzwpLMbIOY+ihzalOgu5sQryVZFehzGFKXY4ZAOrSiJmPQyOwBml/9pw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 4 Jul 2023 15:57:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [XEN PATCH 4/5] x86/x86_emulate: change parameter name from 's' to 'state' Content-Language: en-US To: Stefano Stabellini , Federico Serafini Cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Michal Orzel , Xenia Ragiadakou , Ayan Kumar Halder References: <8c8bc96b96a1111a4651f970f506d304809ea40d.1688049495.git.federico.serafini@bugseng.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0109.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::9) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB9471:EE_ X-MS-Office365-Filtering-Correlation-Id: bb96433c-44e3-42ec-7f95-08db7c969d84 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9zRgTQhQVyOwVn0EpU/QMmP5OOFlTl2Ga7CLZmXHp4HKy/h8UDkPIs6zqFyuiTpgD12A87X8p97P6fa0+S4VliLUo4TuCBc6/je7RftJ3U3AtKZrqWwWgKOWtC6OJwrSqMqdTqEftr9fMPSrnTaa8SOQd3v85fDTuc7zmBMXLDQPL/nddOekevqBu6UphMjd/SkKGCA4Kqg3Ncp21wtx1sfD1zhZ1s+YsXPXRaDdsBMylHndwFTMafu2b2vOXdMSUW8SKlbqGtL6eFS9LYTvOdKL3GcCO08GDf5JTd3c0HNfaR71uyjRar/jb1f5haqRAdiVuEg80BD9xkFr+ANYJEEyOVmP+phJPFmaxLUrqDWD2gB4vz/Ehp7w0vqoSlmkzBKb7rtHKRg5QAYTZ4iyUPV6ZlQPNLRmNEyhfJuZCEDvov/Z6Rmh+tiGKthY6QhdevEh94NJKAm9itWg5Kk3C2lOgrLs3kA5uxvOKUe7VMQkzf18Ki5YzZlPr36AhPiQMWMF2pgS0rFhW/iPdyqpNBIrj23yWhOlTO0TrqDwB5gfUC69yxibaMOZtY2nxjcLcZWYyVwZjFdqKqgXmL53NMMK0CCpWb57/4qfd/jPBknzpZW15kGmhNV+DhE+/Dfpn0J7hvF1MtCLq4GIpmvrbQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(346002)(136003)(39860400002)(396003)(366004)(451199021)(26005)(31686004)(478600001)(6666004)(6512007)(6506007)(31696002)(86362001)(2616005)(186003)(53546011)(38100700002)(54906003)(66476007)(66556008)(4326008)(66946007)(110136005)(83380400001)(6486002)(316002)(8676002)(8936002)(7416002)(4744005)(41300700001)(2906002)(5660300002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WkY2VXlxSVFmanRKV0VNeUROMHVVelc5ang1VnNGQkxFWVRoejM1U1RTK2dW?= =?utf-8?B?RlhvemdPei82K2h6a3YrSTNsNDFMTWE1c080RVZjMnV5UHVlMHBnMWNyTHZP?= =?utf-8?B?VFB3YlNkYmRsakxYL2dEdFNMT3RhZkx0d3lMWE11ZWpObmNIcnBmcWVpSUR4?= =?utf-8?B?emNlL3VJVkZUbFVyU2QycUNzZnVmU1FtWVFiMDlVQUhmV3g0ejBWcDZjSG8z?= =?utf-8?B?RFg0cEtNanF1TTFXaGg0eit1VXZuZlF3RHJZSWpJbzFDNUxnK2NPZ2JiOVpq?= =?utf-8?B?MWFlUkcvMk1XRWRLWndmSHQ1NUJuZ3Npazd6NWMyK0RyL2tmVnVwQWQ1R3FK?= =?utf-8?B?ck9GbW5BVEllL3F0ekR2ckY4SkRsWnpsaHZoRTYzcjNrbVR6SVpDd0VTUVkx?= =?utf-8?B?bmZpQjIyRlgvTHh4RFRHcHlwRGx1cDRyVWxaajhURXVHM0lLWnVKejFwNW5C?= =?utf-8?B?Z1pnR3V1YWgwMnBCV1lMTSs4UHVIcGZmbGtVNlJIMGdNZDRQUGdXUVZ4MHAx?= =?utf-8?B?aGJhSzl6OVQ1ZzNMQWhTMWd4KzgrZyt5ZllYVzdMRkI1R1VURVhRVTlOanA3?= =?utf-8?B?d2dGU1RadCs3aHQ1TFRVdGxpNGE3dElRUGRmUXM4ZnBRbjFlZG52cWJkTWV4?= =?utf-8?B?TEQzK1ovY3NhSHVzUTR0bjBYNFNEVWNWM1FUVVNYakxMbGVFU2kydnY1Zzdt?= =?utf-8?B?OXhGd0xQRHU0QlZmQTJ5c1dibjM4RXZkVjlVdTlCV01ybHZtbTFIM3BPN3V1?= =?utf-8?B?VWtPNE1wY0xNdzVkdGFrRDBZb05zOGFvZDJHa0pKdWxaaXZRNnhLZnB0Ujc3?= =?utf-8?B?SjNDYTR5VmxHeUtkZWpJVjNLenlnMER4RTh2aEI4dHV0RHBkTUdUZ0RrczJB?= =?utf-8?B?K3RmNE44NTJENDZCS05qRVp0MHR5TEVKM1JxSm5neWFJMThPMTNJaVZQb3Vj?= =?utf-8?B?Y1R1NFBYa0pzdzg1RmpLV2RRSHFMUllCN3FNV2Y0Qm0wNmlta290ZVc5U1dy?= =?utf-8?B?Q2gxQ1B0MzFTRWlKZENmMi8rUEQ2VzNzWDJDMGg5V1dTWjBCcVJJWU9PZ0Fm?= =?utf-8?B?OThLRE1paVBtN2J5cUlPOWdrZDhBckdIOVNpeXhFZkNuZHVqMUExUUU5U200?= =?utf-8?B?Qy9JQ1ZpNnNIYXdObHJOemlLcUM2LzNRcDlrU1B0UHhHdlN2a01WMmFpWmpY?= =?utf-8?B?Wjc4dkZQNG1BQmJQQ282NjJZTDRQeFZLNEJ2blgwR1hBUDN3dGhBLzlnR1FY?= =?utf-8?B?bTRNby8rK3gwVXE4dHlFWnRjZ3ZxcmFoMG85elJJa0gyeHYyR0lFakVBU0hG?= =?utf-8?B?RHhxNEkzRW8vT0hlMlJFY2s0RDBzNHZKSjFDZWg2VEJhMXhpTEVicHhCM3dY?= =?utf-8?B?Tmw1Ukt5cThISlpsczBSVG5rRXlVT0pOT203RitibDgrOVpJejZmdVptUlZu?= =?utf-8?B?LzJBTFhOc3o0NjljQ09mNWlZTzExbzErNytFdGpjTFRZdDZWRGcvSUZZcUZj?= =?utf-8?B?bm9ramNmSFZtRE01VGR4OC9kcjJVUXBNSEEzWitmbGlIMEdJcHhISEg1bTV0?= =?utf-8?B?b24zTXV6SVQ5TitZYm5BOFVCZUM0bFZxNlRmb2IyUk9QRzV0Vi9paHR2MUcv?= =?utf-8?B?YTdMQXVuenc3aUtPSXgrellXbUY2amU4WHM1U3FKcFVxSHBlV0hvdDJrTURL?= =?utf-8?B?d2ZFVFdBMHVqcjZWeUE2VDgwMXhZL0FVdHpSMC8xdGt2S1puaVNUMlpVZlpp?= =?utf-8?B?S3dGeVhsWWxtMkR1cmhwaEZVNjZlMUJCUnV0dnliV2sya29hcHd4aUI4RGlD?= =?utf-8?B?eGo0NEpZSHBMT21lemoxamViSFFjd1h0UUl6YzdQNGgzcVR6WWxPdDIwM0Iz?= =?utf-8?B?SWlyRGlScVZ6eUZieVdhRU5aN3hxWUxYdDY2ZWFrUE5VWURTYTlZeUpVYmlL?= =?utf-8?B?WkJCS3ZHbEs4S3RCMzBnWUs3Y1FwYy9rc0NSTERiZmRYL2ZtTStNV3lVWUYr?= =?utf-8?B?MEdYeTlIQkRZWktONEFTNHp2UFVsYUozSmhJekRROUxNdHlTZ1FMRCt1TlZC?= =?utf-8?B?QXFrWjEzM2dqenhONldGTC9HMEdvSVBOOFRIMkZJNWVRVGNUczhJT0tnUk14?= =?utf-8?Q?yzoIWvjI12a3FyY3XhAwb7Zes?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bb96433c-44e3-42ec-7f95-08db7c969d84 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 13:57:33.3777 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Vkok9Vuv7L6bPj664W/+PtpiHpll7ueIseg75ROr8lEgceZ3xjvNItvt8iTblEU1hetj23T9fwEIKtEURKu0VQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9471 On 29.06.2023 21:31, Stefano Stabellini wrote: > On Thu, 29 Jun 2023, Federico Serafini wrote: >> Change parameter name from 's' to 'state' in function definitions in >> order to: >> 1) keep consistency with the parameter names used in the corresponding >> declarations; >> 2) keep consistency with parameter names used within x86_emulate.h; >> 3) fix violations of MISRA C:2012 Rule 8.3. >> >> Signed-off-by: Federico Serafini > > You could use x86emul: as tag in the title. I'll let Jan choose the tag > he prefers. x86emul: or x86/emul: is what we commonly use. That said, I don't like this change. The files touched are pretty new, and it was deliberate that I used s, not state, for the names. This is shorthand much like (globally) we use v (instead of vcpu) and d (instead of domain). Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 04 14:01:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 14:01:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558374.872404 (Exim 4.92) (envelope-from ) id 1qGgaL-00056p-Q1; Tue, 04 Jul 2023 14:00:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558374.872404; Tue, 04 Jul 2023 14:00:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGgaL-00056i-N3; Tue, 04 Jul 2023 14:00:53 +0000 Received: by outflank-mailman (input) for mailman id 558374; Tue, 04 Jul 2023 14:00:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGgaK-00056c-BI for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 14:00:52 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2060d.outbound.protection.outlook.com [2a01:111:f400:7e1a::60d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2f2d3c74-1a73-11ee-b237-6b7b168915f2; Tue, 04 Jul 2023 16:00:51 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB9138.eurprd04.prod.outlook.com (2603:10a6:102:22d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 14:00:48 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::9bd3:48c9:ff58:9880]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::9bd3:48c9:ff58:9880%4]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 14:00:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2f2d3c74-1a73-11ee-b237-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kZlPC3vMUIxxH/RE7HuKeAiAVKN33yHhf5QhD62F0YR6GSkaHf+ffVIWzOTAEPMNHEbT9BrdHqMExUaWaPviYOGhNa9KnPBlAu/XlZ2GzJBIQONEnOfKUHgT5B2n1sk6/qJ3/iOv0kkS1hYn5uYgsti/ScKkXNr/zNrYqPHWQvue9El53vGlGozghNBBOYYydBoyeB8SXpJeXjUXh24pPDHiAFfrXcPHYfexNYZzYR6t9MWI2espUJaa4iGq1JveaHovMRdh3mf9Ut35hT3dVcnFNKSXY8K18HtmGbvnuKHbcVccL8ac06EEmbQp2Tg4poa962Wc3h7Bf1vj1+dO+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gll7WaYdb8WKnaoDfTPkTUK3k2BeCemleAxdO6F4qNo=; b=Z67RlhSK8qtURFLls64BTlKpIefvZjrU16mo5coMSg6O5Px6hVx1Mj0e8W3CB3jIZCmUmu3Qx5oBwMGUprwL4CkEo5hP47o4egLK49Cz3aGLKX98YkaYBy+/mBAqHABtuTI8FJoIG5uUB4cdhpN4ljBQMHUXoWxYVm8bErxRSwdDel3q8/l7Xte8WNxFMOicTmaSZqqaJKOczBoYGgolX+F0zhSt5wPFbTG3jbbQQaCvm3TWAeD6L8w4HE4p7qaiiwCjWTnaozYetCw/pmsR5XoQubQ2shNHF25h/nwjwNwGnaDQK4szcX+9z29VyY2XjUqjPEippPBMHP17JXdXEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gll7WaYdb8WKnaoDfTPkTUK3k2BeCemleAxdO6F4qNo=; b=WC9q8KFPcjULEPffrLyUBJ/zYk/M5fKBq1mn3vKFuXq/33x1okQ+yjHHO8C0I4IIRmsY9Tq0mxh/5L50IpNfmJkTUOoRxBgCtkkmUGQLZ/fSqLYpD9+jiHaoNrnNVOGTHteMOE/CmZlr/W2sEmIQYValeJyOSw+Hw0ADnN676NrZ4lTVdn9Eu7dGZBdlgFLmGECYjaL3k67S2KylCiiZJIPfGSD6F3utjBoFcoHfsUpRssHMHAYNrYFh2y1/TITT6jLIKWlViZ8ES0Gt2A48S+Bbx4vSPXXA+Oc0XoG2cuSAOFRK9t4Arkw2oM9eDNrRcCBWkOmWF4pFkoaKAJz2Jw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0076f2d6-03b7-0a1c-c423-1f55b7195407@suse.com> Date: Tue, 4 Jul 2023 16:00:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [XEN PATCH 5/5] x86: make parameter names of function declarations consistent Content-Language: en-US To: Federico Serafini Cc: consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Jun Nakajima , Kevin Tian , Stefano Stabellini , Michal Orzel , Xenia Ragiadakou , Ayan Kumar Halder , xen-devel@lists.xenproject.org References: <5ee57d7bcd79daa0314f182ecb73e1eb6d8ecc03.1688049495.git.federico.serafini@bugseng.com> From: Jan Beulich In-Reply-To: <5ee57d7bcd79daa0314f182ecb73e1eb6d8ecc03.1688049495.git.federico.serafini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0061.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::9) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB9138:EE_ X-MS-Office365-Filtering-Correlation-Id: 98abebdb-395e-437a-4d38-08db7c97118c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uP7e0A8XKaVLiYTL7EqaerIX3d/IfDwpU2F0YlJ3SBveLcNGTGZQbwoyZbol0MPIWJSpRXiNLuZFBAiZ0sXzzF3Yh9bCnGJc7w/HbZgBPB65IVSJzghw5LUaztO3xjXkF19SP2TGOzR69TYWd9HwGHu2fqEaz7tD8eIKr/p0qYnm06rRl9dX4F4IslRKJh8No93sztqv89WWHxJD5pu1oIa1fU5HCo3byPH+oej9hoscRQB5vP1d1PhF6mEk5XReg56kdq125sFXS9xzSKHv3oIBMXfBVVR1KNOQre3htqDhJWjyfNwKdTj6hTHM0Q1sOTGiePlTuYdi5w0VohKrn199X6nb+tv4tcPoK3EnOSKiFgiu6LVPYpKORTzCjjEmns38D72+WQvHZT9VLlwu8t4KEsgA5/doohkZjCiL3MCgsLEIJM5wcLtvaMqopS8N/uasCcYpoz73F8pUKa6tnzrCRV+B+p7IVj+fg1y4TYloEZHpuefMgoRZjpJFZJniDK7UZOD6RQguMT6Tl7JOL9ikr7szlROOW2ctWZ8z/n25My8qVVQHk5ldUO1Apaf6mkGygVrpnNvZJ0Fnu4ZNCWLV+uRRWvaXIw55YpgncUNpDEJmR2oGpxuedzFr0Q9ZPtQ+qYH+I7JfBAJ5fRsDOQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(376002)(366004)(346002)(396003)(39860400002)(451199021)(6666004)(478600001)(6512007)(86362001)(31696002)(6486002)(38100700002)(316002)(66946007)(26005)(53546011)(186003)(66476007)(2616005)(66556008)(6506007)(4326008)(54906003)(6916009)(31686004)(5660300002)(7416002)(8676002)(2906002)(4744005)(41300700001)(8936002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2F6YmN0c2lMU3IzdkdGb3ZxUUV3Tk5OQ2k1Yk8rb2xtR010KzdEcDdoLzFt?= =?utf-8?B?M1REM0VmcUp1M3JPc0JaN1lVRkNqZ0dGYmptbVRIc1V4R05HYWNya2MwR25Z?= =?utf-8?B?WmxpZlhwYkNNNEcwTnpMc2V2N09Rd2pRWTd0dEF6SlZkaVN5SERuREVVR0dH?= =?utf-8?B?RVRnZUNqUi9rb3Q3dUhHVUx6VGpITjhNWWpSQ29uREhVK3ZwclZnRlhDbFdz?= =?utf-8?B?czc1MHVsWlE3a0tTaFpndlRFZ3lGdGQzdVBGV0lVdC9oUko1MUtPMkpEa1RS?= =?utf-8?B?TnQwNDBoVTNhN3BiL2lWamMvNHVZNDdNQWovSjFEdUpmSksxME5IYkU5WklP?= =?utf-8?B?NVkyUzE3eUs5TzJyTWJJUHN6cTdEUFVyNEpZRWFMREt3ZHl6cHM2UkdERy9P?= =?utf-8?B?c25OSmRUZTdOUVFlcGpVc0lwYy9iS3RoSDlIaWJqa1QyNC9MQXczVWF2TCtn?= =?utf-8?B?UmZFYUtDM29raUVUazdmL29HZnBjdStrd2RBTkdtdmExZlVVNkk2OWg2djRp?= =?utf-8?B?Ym02cnFXc3JwOUJEK0pVejZ1T0NmbzBYMXc4dlFUd0JFd04wbUhUZjhHS1Fz?= =?utf-8?B?S0JNekJ3cllQa3Z1cUdSMFhITVNZZ2tFTGJMYkhGUkVUdGZCV21JOC95dUdF?= =?utf-8?B?cURqRFJ4bEEvVXJhdFFIWnhJYTQ5MWJycE4zejhUSmFLWTByNVZuRXJDTWtL?= =?utf-8?B?RkRDQ3VRTTJRb2lucVphYWdmNnExN3M2M1R6SVEvMUJSRGhEVWVnL1lqdnEx?= =?utf-8?B?L2VJaUdOS3ppcVcxTXI4dm00WDdwMEU3TXRjUTd1MENFbEY5VE1NQStiaCtw?= =?utf-8?B?bkczMmJiVE1YOVM2T3Fnc3lTOGtCekRYSkNwYkhMQjUrcU9VTGxsYkxqam51?= =?utf-8?B?K3pnaVVabmdvNlROMFI4VDU2b1VTZ2Fwc3R6NDl5Umk5WW93eVd5TWIxQVpi?= =?utf-8?B?MW95Sk5vVUtRYzdGM1hYSjZ5Y0xFZTZwbnV3QVg5MmZzVFpkcU1LTHlQT1Fm?= =?utf-8?B?dE1Yemh1MEEvSkZjb1Z6ZDZDQ2tRL1ZiVDI2OG9HVmhSV042aGpUZDJoS3JP?= =?utf-8?B?UXpSL2FId3ZyalU1TTVYbDRCVUZwbmNmU21Sa0d5ZXBBZmQ3MWJ0Vm9tOXJy?= =?utf-8?B?SU5oQXkwdTZYL0JqeDB2S3RwdnRyY3UzeW9wTmVWN09qb29HSnVGVjd4Mm1R?= =?utf-8?B?RVl6RjJ1NUo1d3ZaQXZydUQzbHUrMnVFYnAxOGF1cUllSnVVNjNIejljY29s?= =?utf-8?B?d1g3MmNaejVZNm9NeSt3VkkrelF4TzhzWXd5bU5uT2hDNkR6Tm1mN0pqUjNF?= =?utf-8?B?V24yNWYyMzI0Q1pmeEN0eWQ3QU5FOUNpN2I4aC9qQlVISEV4eUVZZXc3M2xV?= =?utf-8?B?MXphLzV5NytTSFc2R2kvQy9IbExJelMxeUpxNmErOG9yKzVxYWZ6a3FyQllK?= =?utf-8?B?TXduTnRTWjVrU1MxWjFtTU05ODJnclp4WGtxL2dXeGZGeXRyOUNNNXZPVUVt?= =?utf-8?B?MDNyK0pUYUJwM3U4em1yZkZPTlZqRGZHY2pKNlMrU2lDS3UwQWNuVURYR1FB?= =?utf-8?B?Q3djcWNqd0dac3M0SzNQL1ArYkkzYXlSVXNmVTltOHhldDZmMWNFVm1BeTBK?= =?utf-8?B?WHdia3g1cDJQYVFWM2M4d29HZUM1UTVCN1I0SzJVbHQ0OStqOHRFQ3RjOVBn?= =?utf-8?B?bll1MmhTdUttU1YvVG9oRS8wWjJ5S1R3aEMzYWw5N1orMmxTTm9GdGZDVita?= =?utf-8?B?bWpxYkZiZndUcFRrU2c5YWhMcVlxOEVxMDlyR2RGelVnejc0Z1VEUFhHbWFC?= =?utf-8?B?eDIwSEZwWk1jNnBLUytlTUhTYW1IRjhFT0xIUUgycW9ONEVvTnl1ajY5YndN?= =?utf-8?B?UHhsOGxJa0lSNEUvdnJ4QkYxc0lCUTRrMjRjUWRzN2ZwbGV2N0hxby9Pa0Ez?= =?utf-8?B?eEFJUFZWL3dYSDMwRUc3WDl1Y1dSaTZWaEJ6LzVFMDFGTFlQSXNLaHZ4OFJE?= =?utf-8?B?UWkyNTBUWGhxNXcvUGNPWUhiQzc2NTdPMUVYQ3J5Q0NkV2JER2lzMTBHa000?= =?utf-8?B?MVMvT2h1QitPYVkzc0MzaXVjeGtCUG9FMnZrdWlOQlZWZkNQei9hWXp2YXFn?= =?utf-8?Q?g378puj0a1nEokpNE6Vs97erl?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 98abebdb-395e-437a-4d38-08db7c97118c X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 14:00:48.0461 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KWZ462A6jg7p91S/JGVrZC3YkkYwP9Kg1a68hFs9EikVQ7gcXJRpJ5gXWgI8xfDBsUaiMeDS23Etqu0jnxXcUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9138 On 29.06.2023 17:55, Federico Serafini wrote: > --- a/xen/arch/x86/cpu/mcheck/mce.h > +++ b/xen/arch/x86/cpu/mcheck/mce.h > @@ -44,7 +44,7 @@ extern uint8_t cmci_apic_vector; > extern bool lmce_support; > > /* Init functions */ > -enum mcheck_type amd_mcheck_init(struct cpuinfo_x86 *c); > +enum mcheck_type amd_mcheck_init(struct cpuinfo_x86 *ci); Supported even by ... > enum mcheck_type intel_mcheck_init(struct cpuinfo_x86 *c, bool bsp); ... immediate context, c is the name we use for parameters of this type. You want to change the definition in such cases instead of the declaration. I also think this patch could do with splitting, not the least to reduce the Cc list(s) needed. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 04 14:06:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 14:06:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558378.872414 (Exim 4.92) (envelope-from ) id 1qGgfq-0005iq-FA; Tue, 04 Jul 2023 14:06:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558378.872414; Tue, 04 Jul 2023 14:06:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGgfq-0005ij-BC; Tue, 04 Jul 2023 14:06:34 +0000 Received: by outflank-mailman (input) for mailman id 558378; Tue, 04 Jul 2023 14:06:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGgfp-0005id-Jv for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 14:06:33 +0000 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f98b8bce-1a73-11ee-8611-37d641c3527e; Tue, 04 Jul 2023 16:06:31 +0200 (CEST) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1b89bda02ebso13665035ad.0 for ; Tue, 04 Jul 2023 07:06:31 -0700 (PDT) Received: from [192.168.50.14] ([98.51.102.78]) by smtp.gmail.com with ESMTPSA id jk4-20020a170903330400b001b672af624esm13083569plb.164.2023.07.04.07.06.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jul 2023 07:06:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f98b8bce-1a73-11ee-8611-37d641c3527e X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688479590; x=1691071590; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JV2SCOEdB9t0w6tigDexjJMYhGF54ZwsLlYmJ1gE7wU=; b=STgVxKubhKFXFR/0SG2VGwjeMGvGTPSKgdHelGhM7R1cmxEng5CwxQ+949RTd1LW8g YFOBs5rBQp3aEo0XvF7MPAT7XXCneN+XVpxX5Snuz8mpBpEQdyJaceEODGA1bt4SFVaV nGP76XHESoWY2esDLySFBNSf5Zttuc4Qr3d7H2RYOGylFgXG+8gq/Fa5Ajhf9oG7LSLT 1bLb2Nhr6eRceNvJ73j17fCmf7aUMHXDO07H7ZYV69eSwl9Z8xITMCylmnFSENncBvSN /XKBkgaRap0A/u0+JcyKdMVrT/yUXr1qu1JlNFuXzSiMjkeboGWIGJMfwNsBknaOJ8qL T5xA== X-Gm-Message-State: ABy/qLYm/THb2FhcUrz/8oHkswrynCHJ7Q2Lr1AnuvlxGAKs6+SNgTUB kTlFZEZ3birMFJu3prYW0ec= X-Google-Smtp-Source: APBJJlEESj5502hCCjnCrW5aNdhMviGxH5NXIz8SFwBF+614aVB6e0+1hJtWMTw8TJzZNuQy8olTNg== X-Received: by 2002:a17:903:447:b0:1b8:a31b:ac85 with SMTP id iw7-20020a170903044700b001b8a31bac85mr2719760plb.41.1688479589749; Tue, 04 Jul 2023 07:06:29 -0700 (PDT) Message-ID: Date: Tue, 4 Jul 2023 07:06:26 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 01/32] block: Provide blkdev_get_handle_* functions Content-Language: en-US To: Jan Kara , linux-block@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, Jens Axboe , Christoph Hellwig , Alasdair Kergon , Andrew Morton , Anna Schumaker , Chao Yu , Christian Borntraeger , "Darrick J. Wong" , Dave Kleikamp , David Sterba , dm-devel@redhat.com, drbd-dev@lists.linbit.com, Gao Xiang , Jack Wang , Jaegeuk Kim , jfs-discussion@lists.sourceforge.net, Joern Engel , Joseph Qi , Kent Overstreet , linux-bcache@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-nvme@lists.infradead.org, linux-pm@vger.kernel.org, linux-raid@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-xfs@vger.kernel.org, "Md. Haris Iqbal" , Mike Snitzer , Minchan Kim , ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, Sergey Senozhatsky , Song Liu , Sven Schnelle , target-devel@vger.kernel.org, Ted Tso , Trond Myklebust , xen-devel@lists.xenproject.org References: <20230629165206.383-1-jack@suse.cz> <20230704122224.16257-1-jack@suse.cz> From: Bart Van Assche In-Reply-To: <20230704122224.16257-1-jack@suse.cz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/4/23 05:21, Jan Kara wrote: > +struct bdev_handle { > + struct block_device *bdev; > + void *holder; > +}; Please explain in the patch description why a holder pointer is introduced in struct bdev_handle and how it relates to the bd_holder pointer in struct block_device. Is one of the purposes of this patch series perhaps to add support for multiple holders per block device? Thanks, Bart. From xen-devel-bounces@lists.xenproject.org Tue Jul 04 14:09:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 14:09:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558383.872423 (Exim 4.92) (envelope-from ) id 1qGgiX-0006Hi-SF; Tue, 04 Jul 2023 14:09:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558383.872423; Tue, 04 Jul 2023 14:09:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGgiX-0006Hb-PY; Tue, 04 Jul 2023 14:09:21 +0000 Received: by outflank-mailman (input) for mailman id 558383; Tue, 04 Jul 2023 14:09:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGgiW-0006HV-Fr for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 14:09:20 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2061f.outbound.protection.outlook.com [2a01:111:f400:fe12::61f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5d62fe3a-1a74-11ee-b237-6b7b168915f2; Tue, 04 Jul 2023 16:09:18 +0200 (CEST) Received: from DB7PR03CA0086.eurprd03.prod.outlook.com (2603:10a6:10:72::27) by PAXPR08MB6541.eurprd08.prod.outlook.com (2603:10a6:102:15a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 14:09:15 +0000 Received: from DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:72:cafe::17) by DB7PR03CA0086.outlook.office365.com (2603:10a6:10:72::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.31 via Frontend Transport; Tue, 4 Jul 2023 14:09:15 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT014.mail.protection.outlook.com (100.127.143.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.18 via Frontend Transport; Tue, 4 Jul 2023 14:09:15 +0000 Received: ("Tessian outbound c63645f235c1:v142"); Tue, 04 Jul 2023 14:09:15 +0000 Received: from 441c65287bbb.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 94BABC68-05E5-4F02-AD7E-E6870F9783E5.1; Tue, 04 Jul 2023 14:09:08 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 441c65287bbb.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 04 Jul 2023 14:09:08 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AS2PR08MB10055.eurprd08.prod.outlook.com (2603:10a6:20b:645::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 14:09:06 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::5e17:39a6:eec7:c482]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::5e17:39a6:eec7:c482%4]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 14:09:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d62fe3a-1a74-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EogklM6MvVYcQsFwT0exf4GD0ezono7El60mI0r+JDE=; b=CVo3SoaHAnHVwho4wobM24lursZHaYC+k/9lzCbg9UZBwCnQnsCxDjK1WVjzOJlhxSshxSPamk3Z/MWBNnE0Gf7etBwU0upMFgTz+/T6yX7vJahb91oVHn8OYhD8bmxndgDSYrJxIfUQqiS22LFSelcw9q8pG3mbyDv9dnIn3bE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 887afb4d922a0d88 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T12WbI7oLNSnLx176fcj1mfQyoGBFMgxKus+GNwhyarZ7TYm/6Qc+WOEDwQeTXri9W173dpMvHT98l1GudmDg6JhHXak2Cdfd/rM9xvS62D//MLJZ5Z0HW5CEk7F3gqmAYWJ5j6Vh9w87nWlYCvl4HPjxuxHFu+7x/COK9bvbRWyAnxVzTjKH4Cg1ocBErrkqXL1xJFxqq4UNWP9CqHy+vP3rxO9IQpHimhbc5TAOFG5/4g9VXxLmTULexQ43qBaeldGbIgLeBaQbF2aEVc9dEORr6qnnUgZLk19hfk+pEBXdu8pQTpZVQIG+dJ8PMmasoLPTx9TgqD5ZfpvT+mbsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EogklM6MvVYcQsFwT0exf4GD0ezono7El60mI0r+JDE=; b=MJ+eNXG0BfuR3zGgPcq2z1Y9BfrzT6fWT3Q11HMo5udYRGAi0sCBfXPlW1+TFvNu30bg/YHSarv2PMwlt0ypdfsC1H56kpQlWr9x1FZoHTFJQd+knIq4rTiOoLJfmS6OPggbT6y+CsVCxzqcBt9TIU60gmY+1pkkhqKtOyXM0UQgN0SityBYn0DI5YeN7bz5yDaVMbGD90U3UKQM0aqTTTueF3pa5eWaPPHzpqMvD/mr0OeFJlfy6/NE3tN1N+L6C//yjPTiA8SvrARN0jSa9fkHp+ach+teJS4aydPFrtV9Lgd0mVipmDNxG8ABtjosIaUGZgCGPVgkwDsveR+s8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EogklM6MvVYcQsFwT0exf4GD0ezono7El60mI0r+JDE=; b=CVo3SoaHAnHVwho4wobM24lursZHaYC+k/9lzCbg9UZBwCnQnsCxDjK1WVjzOJlhxSshxSPamk3Z/MWBNnE0Gf7etBwU0upMFgTz+/T6yX7vJahb91oVHn8OYhD8bmxndgDSYrJxIfUQqiS22LFSelcw9q8pG3mbyDv9dnIn3bE= From: Bertrand Marquis To: Julien Grall CC: Xen-devel , Luca Fancellu , "michal.orzel@amd.com" , Henry Wang , Julien Grall Subject: Re: [v2 1/4] xen/arm64: head: Don't map too much in boot_third Thread-Topic: [v2 1/4] xen/arm64: head: Don't map too much in boot_third Thread-Index: AQHZqsX4yAVem92w702jqx8j/I6WWK+prJaA Date: Tue, 4 Jul 2023 14:09:06 +0000 Message-ID: References: <20230629201129.12934-1-julien@xen.org> <20230629201129.12934-2-julien@xen.org> In-Reply-To: <20230629201129.12934-2-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.600.7) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|AS2PR08MB10055:EE_|DBAEUR03FT014:EE_|PAXPR08MB6541:EE_ X-MS-Office365-Filtering-Correlation-Id: f7ac2673-8720-43e6-572f-08db7c983ff4 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: XhK7c/2GakBFAns5fb7LagEOvZE+EAGuUqkbc3pCbUAWbdMEIV1WdhbKN0wGitoqAyjiTC/F5klQzUTfPUJa4I6LNwnSYhg/F+bydka+TvAO0jf+F9YUXOQj4Q6hQFrA6/NqzIcZEMThrGQKgQS5YaeERszTUSJSgFVIRBs8C3iVLJD4wORe69u+mj/nFYXiiATIAH01Ql+4i/anDs78/dY4xQ0+YgRvfxf7Jlv1YgsodomsJa0gYA7wj+p14+dT8zeIz6TFE9BUkUYBfngvUo8Z8jeMF2eJ8rW4Zx4ImuWyjAawJpjdsBxsJDaCdS3QcoHPsijxx9TAkhR061k7YKafSjFJhR76sFNYWyvQTlr+534Zz7lNgCYAC3HU2y7Y1XoCkfYyyvC2A3W8w8Ia/eirFf1Vsqn1SSBTZ6TWjq2aU4YFbvlCej2zg7dmk1zQ7Swynu+0tfD2OhTSSt2zVGNVNtUniB5oQ3TtvzE4IhJAuFRPUyey0D706xP9Xhf4/CJO/F45ryUZVd3evxMwJ7ic79QjUZsPVyB+oRy/ddMIwVjGdqPHIRqo7t+1I6RzCN6uomts2z/tbDyBs6v7URqEq6D7jIe0lAAX41SXTKv6mGYrrcelAdkWNKyp0mV+c+HvMvKs10DoaoDXpNrCBQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(366004)(136003)(346002)(39860400002)(451199021)(38100700002)(71200400001)(33656002)(2906002)(6486002)(8936002)(38070700005)(8676002)(54906003)(36756003)(41300700001)(5660300002)(478600001)(76116006)(6916009)(66946007)(66556008)(66476007)(64756008)(53546011)(91956017)(66446008)(6512007)(186003)(6506007)(86362001)(4326008)(316002)(2616005)(122000001)(83380400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <4F6D1ADFA272554C9156A2EE915821AE@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB10055 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: dc52b7bf-81d5-46b6-b984-08db7c983a7a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1bTwQCYWdD2iIFL37zCpbHFn0r/Pj1HGv98PgwX2TV09S/AtwgQi+MVTg0Bbp9JfZLp9/R13KVLv997IfQ8Jx2/zQZIl4Fb+5q1yMIOV3nEhzm7KyCtJqIvfI3hsNHDQTV8xd6b0ieDJA9astB04cusRPcrqxPbl0NDUNAjvV6dN7P/BD/ppTKZ+4vJcSm/l5ou010Owh2kLk/KOFIzmvgpfS9soHhZrpTz4IbdtnYbaW2i5zfooIY5svFOGkw3EaaRN6QeWxBx1n2CpkL/X1NtRDmLewlQy5ibNXUIuF8pubWt6GiIxb2bz2c0zERTLaAxebC2dd9oQOd8RSyN83PMU0k77Ov4x3TU2AxTmrzaRr44Kf7HWCnx0Jr5IO4NrEWOeDKKDUzm04vSH1NfldLu6JCoB9T1Eb9wGAjRVQXM8swpPmz6IWJn6vXxXaSape2lRL/4D+kcbQ3ZhXkQVsKw7/EAJ9Gho83P54/zXQN+QF4yus0VF7kFKAqsnSPJhQT8QS2iupT8Wl4GEdWitPlnEqxHNCO87e6CzRBQPk70WZLeEmz7KgJdBja4HI0qKV9P5PaNdFN1PoTxDshZvoDuK/hZXmNIvVW6S6dg33XIkFrcqrF4YeCuJ4iDYuSxABocDoiFkJclgnIkBgIduQFTzC7mBYp5tU7uaJ7zUr03t0QIlwMy8oQ38gH0zN3Okkelb75ENj22NiZBfAzbz4qktoxFTlNpwsSnfJADW4ryEUMJ6AewjrNXHWFGMU69r X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(346002)(396003)(39860400002)(451199021)(40470700004)(36840700001)(46966006)(107886003)(26005)(478600001)(6506007)(82740400003)(6512007)(86362001)(2616005)(186003)(53546011)(81166007)(54906003)(4326008)(70586007)(36860700001)(83380400001)(356005)(336012)(6486002)(316002)(70206006)(47076005)(8676002)(8936002)(6862004)(40460700003)(41300700001)(2906002)(40480700001)(5660300002)(33656002)(82310400005)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 14:09:15.2751 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f7ac2673-8720-43e6-572f-08db7c983ff4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6541 Hi Julien, > On 29 Jun 2023, at 22:11, Julien Grall wrote: >=20 > From: Julien Grall >=20 > At the moment, we are mapping the size of the reserved area for Xen > (i.e. 2MB) even if the binary is smaller. We don't exactly know what's > after Xen, so it is not a good idea to map more than necessary for a > couple of reasons: > * We would need to use break-before-make if the extra PTE needs to > be updated to point to another region > * The extra area mapped may be mapped again by Xen with different > memory attribute. This would result to attribute mismatch. >=20 > Therefore, rework the logic in create_page_tables() to map only what's > necessary. To simplify the logic, we also want to make sure _end > is page-aligned. So align the symbol in the linker and add an assert > to catch any change. >=20 > Lastly, take the opportunity to confirm that _start is equal to > XEN_VIRT_START as the assembly is using both interchangeably. >=20 > Signed-off-by: Julien Grall Reviewed-by: Bertrand Marquis Cheers Bertrand >=20 > --- >=20 > Changes in v2: > - Fix typo and coding style > - Check _start =3D=3D XEN_VIRT_START > --- > xen/arch/arm/arm64/head.S | 15 ++++++++++++++- > xen/arch/arm/xen.lds.S | 9 +++++++++ > 2 files changed, 23 insertions(+), 1 deletion(-) >=20 > diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S > index c0e03755bb10..5e9562a22240 100644 > --- a/xen/arch/arm/arm64/head.S > +++ b/xen/arch/arm/arm64/head.S > @@ -572,6 +572,19 @@ create_page_tables: > create_table_entry boot_first, boot_second, x0, 1, x1, x2, x3 > create_table_entry boot_second, boot_third, x0, 2, x1, x2, x3 >=20 > + /* > + * Find the size of Xen in pages and multiply by the size of a > + * PTE. This will then be compared in the mapping loop below. > + * > + * Note the multiplication is just to avoid using an extra > + * register/instruction per iteration. > + */ > + ldr x0, =3D_start /* x0 :=3D vaddr(_start) */ > + ldr x1, =3D_end /* x1 :=3D vaddr(_end) */ > + sub x0, x1, x0 /* x0 :=3D effective size of Xen */ > + lsr x0, x0, #PAGE_SHIFT /* x0 :=3D Number of pages for Xen = */ > + lsl x0, x0, #3 /* x0 :=3D Number of pages * PTE si= ze */ > + > /* Map Xen */ > adr_l x4, boot_third >=20 > @@ -585,7 +598,7 @@ create_page_tables: > 1: str x2, [x4, x1] /* Map vaddr(start) */ > add x2, x2, #PAGE_SIZE /* Next page */ > add x1, x1, #8 /* Next slot */ > - cmp x1, #(XEN_PT_LPAE_ENTRIES<<3) /* 512 entries per page */ > + cmp x1, x0 /* Loop until we map all of Xen */ > b.lt 1b >=20 > /* > diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S > index d36b67708ab1..a3c90ca82316 100644 > --- a/xen/arch/arm/xen.lds.S > +++ b/xen/arch/arm/xen.lds.S > @@ -212,6 +212,7 @@ SECTIONS > . =3D ALIGN(POINTER_ALIGN); > __bss_end =3D .; > } :text > + . =3D ALIGN(PAGE_SIZE); > _end =3D . ; >=20 > /* Section for the device tree blob (if any). */ > @@ -226,6 +227,12 @@ SECTIONS > ELF_DETAILS_SECTIONS > } >=20 > +/* > + * The assembly code use _start and XEN_VIRT_START interchangeably to > + * match the context. > + */ > +ASSERT(_start =3D=3D XEN_VIRT_START, "_start !=3D XEN_VIRT_START") > + > /* > * We require that Xen is loaded at a page boundary, so this ensures that= any > * code running on the identity map cannot cross a section boundary. > @@ -241,4 +248,6 @@ ASSERT(IS_ALIGNED(__init_begin, 4), "__init_begin= is misaligned") > ASSERT(IS_ALIGNED(__init_end, 4), "__init_end is misaligned") > ASSERT(IS_ALIGNED(__bss_start, POINTER_ALIGN), "__bss_start is misal= igned") > ASSERT(IS_ALIGNED(__bss_end, POINTER_ALIGN), "__bss_end is misalig= ned") > +/* To simplify the logic in head.S, we want to _end to be page aligned *= / > +ASSERT(IS_ALIGNED(_end, PAGE_SIZE), "_end is not page aligne= d") > ASSERT((_end - _start) <=3D XEN_VIRT_SIZE, "Xen is too big") > --=20 > 2.40.1 >=20 >=20 From xen-devel-bounces@lists.xenproject.org Tue Jul 04 14:13:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 14:13:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558389.872433 (Exim 4.92) (envelope-from ) id 1qGgmT-0007mz-GA; Tue, 04 Jul 2023 14:13:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558389.872433; Tue, 04 Jul 2023 14:13:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGgmT-0007ms-DP; Tue, 04 Jul 2023 14:13:25 +0000 Received: by outflank-mailman (input) for mailman id 558389; Tue, 04 Jul 2023 14:13:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGgmR-0007mm-Nk for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 14:13:23 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2054.outbound.protection.outlook.com [40.107.7.54]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ee77fe87-1a74-11ee-8611-37d641c3527e; Tue, 04 Jul 2023 16:13:21 +0200 (CEST) Received: from AS9PR06CA0612.eurprd06.prod.outlook.com (2603:10a6:20b:46e::19) by AS8PR08MB8490.eurprd08.prod.outlook.com (2603:10a6:20b:567::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 14:12:52 +0000 Received: from AM7EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46e:cafe::4f) by AS9PR06CA0612.outlook.office365.com (2603:10a6:20b:46e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.31 via Frontend Transport; Tue, 4 Jul 2023 14:12:51 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT055.mail.protection.outlook.com (100.127.141.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.18 via Frontend Transport; Tue, 4 Jul 2023 14:12:51 +0000 Received: ("Tessian outbound b11b8bb4dfe8:v142"); Tue, 04 Jul 2023 14:12:51 +0000 Received: from 8ad9a455646d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 83C93626-230B-4196-887B-5DE607006AE6.1; Tue, 04 Jul 2023 14:12:40 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8ad9a455646d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 04 Jul 2023 14:12:40 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AS2PR08MB10055.eurprd08.prod.outlook.com (2603:10a6:20b:645::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 14:12:38 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::5e17:39a6:eec7:c482]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::5e17:39a6:eec7:c482%4]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 14:12:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ee77fe87-1a74-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IEE8KzgJlSHeDg/R+ZsjJ/WFXESyQ2awb5p+KmS80/4=; b=uLnIWMwTeXgU2rI3r1b6y1mUNF4NYYJtvTbW4OU7z3HiEWd8fp1h3uh/5Zs3TzAp1+UWm+czHfRbkc9XXVn3p9IpUXtz214ujTCnHcUeesfwpKQmPE4Oxo8WEvJb3oghsXCnoPjpOWox3yDl3NkBqdwMsjx+lzLIpJWoc/0TXJY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: bc67a2cc176925e3 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QMXZxLY1tkKhEZ3mhtS12VF0i8KxFvQOfNNRclrNZFUNs/eScF2ppk3y86tVRKYoJq9enNEhYIu+ZAWQ/ytT5U91Nitm8K1d2cRAsY1J9C3lV/VzBj6bKDeiZdyJMx0qyeQrSqzq/A7ckBXFWRBBoX8fo6eejuag4oo1c2uxbG2sWDJdNvF3IlPuEudnv8WTZznAo6WsYOE+VdXY8o/IbTLuo3inOn+/rvPI5ORUh3DuRBn14zzgmnKioHO4u6f1JjIduI8/J35hS5wd/+tNpkQgG4CB6UemFdIYSrSIFQsGO9FJN2RatYOBMfxW84pe0e8B2g8+oWyhKnZPcOBNCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IEE8KzgJlSHeDg/R+ZsjJ/WFXESyQ2awb5p+KmS80/4=; b=mBBGZgz4fLXBCedR4hjQ0TRFMSvUDiVejSEbCh0nXDiMcgKEdq2Sx7dvU5vOmoGjuz+MPDbVE80eQRIl9r5WdnBDKmlhA/NM/kxT/3DI8pEw45xUOKGs9YSUCAApCLQEPGrWGwft0lNHpjycL2nZweowF+I5g54DS3OpeXdALWBruh7dUGPNqaOuc+bxc66YOmoZHv3LupdiGilNVD4cmbIMBjI5fr3nfBUBo9W9Mwh5F615BobJ4QPvG1VQvNzV5GA4hpgLI32uw9Soe2vz3MgxrXPwBnC0WtPBuPArYs5MctJStk9D+gwVyKQeeyX5lKYvXsu3YPgNJ3jV2X1cjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IEE8KzgJlSHeDg/R+ZsjJ/WFXESyQ2awb5p+KmS80/4=; b=uLnIWMwTeXgU2rI3r1b6y1mUNF4NYYJtvTbW4OU7z3HiEWd8fp1h3uh/5Zs3TzAp1+UWm+czHfRbkc9XXVn3p9IpUXtz214ujTCnHcUeesfwpKQmPE4Oxo8WEvJb3oghsXCnoPjpOWox3yDl3NkBqdwMsjx+lzLIpJWoc/0TXJY= From: Bertrand Marquis To: Julien Grall CC: Xen-devel , Luca Fancellu , "michal.orzel@amd.com" , Henry Wang , Julien Grall Subject: Re: [v2 2/4] xen/arm32: head: Don't map too much in boot_third Thread-Topic: [v2 2/4] xen/arm32: head: Don't map too much in boot_third Thread-Index: AQHZqsXz4VnOLQ2i/U6Z6/jlIuCSGK+prZQA Date: Tue, 4 Jul 2023 14:12:38 +0000 Message-ID: References: <20230629201129.12934-1-julien@xen.org> <20230629201129.12934-3-julien@xen.org> In-Reply-To: <20230629201129.12934-3-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.600.7) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|AS2PR08MB10055:EE_|AM7EUR03FT055:EE_|AS8PR08MB8490:EE_ X-MS-Office365-Filtering-Correlation-Id: 63bd1ef2-fda8-47d7-7a67-08db7c98c0e9 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 1+e09frmHXiQweB3W+FBMHcjqkZYfHxxuOPEOxMN4NTRexyy/yKXidlQXikXWsEGM1uX5DftTCAf1VBQfEvm5VSMHJBM4V9UY+kdgxWNxn83BAs04xK+rYwOyA+BBX1O2koheCUAUkNFuD4qzJJ4QKyrq97E4oQElbQgqD2QjTTnyP8tCQxlpDanwUwK84rL7tMdPsWMjOsDWPPSbf8lzkyRm1PQrUV1YZo+uerlg8fuU0177kpiBTJVaD5ijFmr96YbsgmML6G2KwV0O4A9Rkwq1SMBswFJ0zpsd4siXMJCSTFirMSvgSGvXJrT1voAaESFTnUOSh84zvNDrB0Tu5UxMTu8X71RWrXzSZLDtbUzBJe/vn4NIzyM4peRxKwukDzDZsURGTYtPuCTka3llPbo0FdhA0+wvEReoKEwHQoXg+Tqg+HUYdzf/FzMjPesS9YytzD03OnQfqeccym0mMei6xlqWcvXXqma+cBxlwsOnu0kODuUnHqO/wOZFSUcFjJZjBGRkvMdAndfnSIqrwQB5bRtzUTtB3RSftaY2cpIj1OPCQ9TihL7/X3FOdhmZUxFDN1XI+A0koyZ4BCiS9SKtC7drD2DdqT6GQQYPSs+aFIiNHAadCJOKv6UVHlsVQGn9lr4tVht/BWyjOS2Mw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(366004)(136003)(346002)(39860400002)(451199021)(38100700002)(71200400001)(33656002)(2906002)(6486002)(8936002)(38070700005)(8676002)(54906003)(36756003)(41300700001)(5660300002)(478600001)(76116006)(6916009)(66946007)(66556008)(66476007)(64756008)(53546011)(91956017)(66446008)(6512007)(186003)(6506007)(86362001)(4326008)(316002)(2616005)(122000001)(83380400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB10055 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b867d68a-a0bd-4c33-db23-08db7c98b91f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: T8WQrfGY15rnX5DnFwho78mzR0tV326B1lOXSbEJWx3SemNG+y8YeE6fpQ7bL9hlTWqRgr0IJfx8td/Qb27J2ADVMve+KsJRU8cyiMw9yQSgI3Fv6ikK+4VoJSE/QGtZ1j0cHcCmtE6pKDvEMx/8w5yCqtx1STeA1JSaStDCm70Y+b+W3jrvMxLcg/LXa7hVWzhxymf+GIMOtj+rWuKnbaVhkUt2gzXofKKkObu5/xkwVpQoWGvrqY27JPAsPFKUMBdHODIwoX4968HGHVhmAsIQYlI9E6wQwnJM4pPL0yAgb1zkIDiFQ44hZMAnjGKDAMcwAGCyCDD2Sx7nYqCNimWCrhJ70x4nmbMGdIlnNVI/Onubsxe6RySED8fDW/Cx2FL/dpSbZVIY/x2ZTHYxld8qzbiaEvNFBuK8oykU1liToCH3kxDRpcoU10eX2+RgrtHvzuum8Q9OP5Vycg2rb9CuRdD9hPDLQ2cI/EBnpceXO3RT5JdSGsR2/7QIgnavvonChxso+HWdNAprihkh+46mKz8naudjhB5cmV0YyqdU3A6+JKq+ug/JAxutxHVAa+wvV7uloceKyRSGvV51Fs7mQ+ukCXP4MN8sxMZ7w+xdcURCGOncMKiwg422cE1rgP+k9jyXoMTaDL+Twysg+T2BOgh655pJv6YKG3Fie5QeYZhj4HFGxpUVNVYmW18s/uKK7oQaMCAcvoOqcNz7N6BZzNhalOuooe4BoDBflNUzNeKYOSF2P4bioD+jsVTf X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(346002)(396003)(39860400002)(451199021)(40470700004)(36840700001)(46966006)(107886003)(26005)(478600001)(6506007)(82740400003)(6512007)(86362001)(2616005)(186003)(53546011)(81166007)(54906003)(4326008)(70586007)(36860700001)(83380400001)(356005)(336012)(6486002)(316002)(70206006)(47076005)(8676002)(8936002)(6862004)(40460700003)(41300700001)(2906002)(40480700001)(5660300002)(33656002)(82310400005)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 14:12:51.5832 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 63bd1ef2-fda8-47d7-7a67-08db7c98c0e9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8490 Hi Julien, > On 29 Jun 2023, at 22:11, Julien Grall wrote: >=20 > From: Julien Grall >=20 > At the moment, we are mapping the size of the reserved area for Xen > (i.e. 2MB) even if the binary is smaller. We don't exactly know what's > after Xen, so it is not a good idea to map more than necessary for a > couple of reasons: > * We would need to use break-before-make if the extra PTE needs to > be updated to point to another region > * The extra area mapped may be mapped again by Xen with different > memory attribute. This would result to attribute mismatch. >=20 > Therefore, rework the logic in create_page_tables() to map only what's > necessary. To simplify the logic, we also want to make sure _end > is page-aligned. So align the symbol in the linker and add an assert > to catch any change. The last 2 sentences actually belongs to patch 1 and have been copied here. Please remove them on commit as alignment of _end is not in this patch. >=20 > Signed-off-by: Julien Grall > Reviewed-by: Michal Orzel >=20 With commit message fixed on commit: Reviewed-by: Bertrand Marquis Cheers Bertrand > --- >=20 > Changes in v2: > - Fix typo > - Add Michal's reviewed-by tag > --- > xen/arch/arm/arm32/head.S | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) >=20 > diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S > index 1ad981b67460..5e3692eb3abf 100644 > --- a/xen/arch/arm/arm32/head.S > +++ b/xen/arch/arm/arm32/head.S > @@ -459,6 +459,19 @@ create_page_tables: > create_table_entry boot_pgtable, boot_second, r0, 1 > create_table_entry boot_second, boot_third, r0, 2 >=20 > + /* > + * Find the size of Xen in pages and multiply by the size of a > + * PTE. This will then be compared in the mapping loop below. > + * > + * Note the multiplication is just to avoid using an extra > + * register/instruction per iteration. > + */ > + mov_w r0, _start /* r0 :=3D vaddr(_start) */ > + mov_w r1, _end /* r1 :=3D vaddr(_end) */ > + sub r0, r1, r0 /* r0 :=3D effective size of Xen */ > + lsr r0, r0, #PAGE_SHIFT /* r0 :=3D Number of pages for Xen *= / > + lsl r0, r0, #3 /* r0 :=3D Number of pages * PTE siz= e */ > + > /* Setup boot_third: */ > adr_l r4, boot_third >=20 > @@ -473,7 +486,7 @@ create_page_tables: > 1: strd r2, r3, [r4, r1] /* Map vaddr(start) */ > add r2, r2, #PAGE_SIZE /* Next page */ > add r1, r1, #8 /* Next slot */ > - cmp r1, #(XEN_PT_LPAE_ENTRIES<<3) /* 512*8-byte entries per pa= ge */ > + cmp r1, r0 /* Loop until we map all of Xen */ > blo 1b >=20 > /* > --=20 > 2.40.1 >=20 >=20 From xen-devel-bounces@lists.xenproject.org Tue Jul 04 14:15:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 14:15:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558393.872443 (Exim 4.92) (envelope-from ) id 1qGgnx-0008KE-R0; Tue, 04 Jul 2023 14:14:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558393.872443; Tue, 04 Jul 2023 14:14:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGgnx-0008K7-OS; Tue, 04 Jul 2023 14:14:57 +0000 Received: by outflank-mailman (input) for mailman id 558393; Tue, 04 Jul 2023 14:14:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGgnw-0008K1-Gn for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 14:14:56 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20616.outbound.protection.outlook.com [2a01:111:f400:fe1a::616]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 25b750e8-1a75-11ee-8611-37d641c3527e; Tue, 04 Jul 2023 16:14:54 +0200 (CEST) Received: from AM0PR02CA0015.eurprd02.prod.outlook.com (2603:10a6:208:3e::28) by AM7PR08MB5366.eurprd08.prod.outlook.com (2603:10a6:20b:10b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 14:14:52 +0000 Received: from AM7EUR03FT004.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:3e:cafe::ef) by AM0PR02CA0015.outlook.office365.com (2603:10a6:208:3e::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.30 via Frontend Transport; Tue, 4 Jul 2023 14:14:52 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT004.mail.protection.outlook.com (100.127.140.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.22 via Frontend Transport; Tue, 4 Jul 2023 14:14:51 +0000 Received: ("Tessian outbound 546d04a74417:v142"); Tue, 04 Jul 2023 14:14:51 +0000 Received: from b98e52ff82e0.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id EA13D457-3978-4FC5-850C-D6A586231AB0.1; Tue, 04 Jul 2023 14:14:45 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b98e52ff82e0.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 04 Jul 2023 14:14:45 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AS2PR08MB8694.eurprd08.prod.outlook.com (2603:10a6:20b:55d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 14:14:43 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::5e17:39a6:eec7:c482]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::5e17:39a6:eec7:c482%4]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 14:14:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 25b750e8-1a75-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eiVGKPFwbIjAlKAFWLXTaQK/I0D0UDw/eEEWsAhzXPg=; b=UNgw0JYu8wa3TwGbAukXqDDlwHrby01gtpIL+bw3RDK3OdYPvn9gkOhMGKbzOtXOe0BjJV5Iigc9TmPAN99o2JzknX4ogJiQYd9A6Ab4GaHXtG3BlGuIbkasQIOJCtenjDcdIlwyLHKhvnVGX2HXBaNZlDtKt/pMdVy22ugyBTE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: c4e1208e2f18b545 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X5fWVKIqI+eAYhkEfon6JNNZsU4+vmmK8eSEqVy4X0AdaXPUIS1LEDXay1XZ0ONXhBdOvyWZ58WTzBWeE1SR2sVbEBkyBvOjEA6UMYbcCn0G5nC+7T1WpofKSUdKD6t3gouHZumaSSLBYoy+JIdsTKeYW0qmB6aHxQtyd9gL1eVylG7J8r4RuJF9yoK+4kYRVdt4lPIuuk85L4ZVsjM6SaSQu0EbxjaPNP08e3pKCQRwT8Gti5qOwcfePLkcS9Ht92TBBXl1ZeeskM8DwDgpGO0i08bTxtbQejsz5J4CFFbVSp3yVBmCjhZOGzVal/b7oCjyKDXL2S2gBXZqE36O1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eiVGKPFwbIjAlKAFWLXTaQK/I0D0UDw/eEEWsAhzXPg=; b=LdpYJ11XL1Dmc4o9uuvOTrlUnBDk7YWvuX+yy28epW5W3dU2aFo0QSz2xFN2TaYBiI7h5T8myw+43OVECEZ21gSZPYb7hBiUP6yiLGjMG3ZhKbMIQHrqrBkkd7bMYN5xijTADcxgo5UuOYL+Nos4ytxo/OUKkStcqthiDxc7n01d4HiAVV2QZKwCFvAhkhzZzUnK99IcxjA9l8Lg4gfLS8rH64eZVxriQjea7MS9ehuxbmKASKcdDm1dtoeU94OjnE5Ak5UqimENB6lWhfQguBVbCQswxh8rVpeSjeF8YrSxjuh0Nutl3Ud03QWVtZXPUt9Ju4kLG/KWOE/tmnd48g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eiVGKPFwbIjAlKAFWLXTaQK/I0D0UDw/eEEWsAhzXPg=; b=UNgw0JYu8wa3TwGbAukXqDDlwHrby01gtpIL+bw3RDK3OdYPvn9gkOhMGKbzOtXOe0BjJV5Iigc9TmPAN99o2JzknX4ogJiQYd9A6Ab4GaHXtG3BlGuIbkasQIOJCtenjDcdIlwyLHKhvnVGX2HXBaNZlDtKt/pMdVy22ugyBTE= From: Bertrand Marquis To: Julien Grall CC: Xen-devel , Luca Fancellu , "michal.orzel@amd.com" , Henry Wang , Julien Grall Subject: Re: [v2 4/4] xen/arm: Allow the user to build Xen with UBSAN Thread-Topic: [v2 4/4] xen/arm: Allow the user to build Xen with UBSAN Thread-Index: AQHZqsX05lUuU4F5z0qXrKvpd1a/f6+prigA Date: Tue, 4 Jul 2023 14:14:42 +0000 Message-ID: <6BC60C8C-745E-459F-91E3-FCFB5DDB9F76@arm.com> References: <20230629201129.12934-1-julien@xen.org> <20230629201129.12934-5-julien@xen.org> In-Reply-To: <20230629201129.12934-5-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.600.7) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|AS2PR08MB8694:EE_|AM7EUR03FT004:EE_|AM7PR08MB5366:EE_ X-MS-Office365-Filtering-Correlation-Id: 72a7f30c-d7bb-4346-66ae-08db7c990877 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 6ciRGoJqmLtnabO/DcrJpfZ4cTHdlB1q6mXCtQIIsveAncXIOgDlnrRSdwpw1c9RL0q4Ph8wJh+6Hok0Ck66YBjb3ja7SNqfc7XgHxIGVRaa4feOt8mcSQm/DrTqnzPdcwGALugLeVmKr654+DP0irujmdjsVTFs4DHPFcXSgQhnk+CVgfz23krgpcwcvRqiHeT6BY/499fWflTvF4FoLu7YHrx22/bkZUuc4RmBnxPTC/N3UirczRSty2QNwl0CIdmXfeukNq50qE7jXEZHPNC1gkL5FN4oMZxW6Zwp0dIyH/CEoHKEsIOtC7sXvs6CQ5rAmAK6/57Ma3+2p1C5RXE/pbxihq/N+4io0lzcG64qA1lTgLcsrnUDcPrXjKp74vhlU1Tqv/qJHuGEohuFnEP6p1ipUM6Ec0p963uQSthcMCp6mObccjZDNVozs5qJUIlTCy2dkrbtxqQlP8SPzNHlYx3ukdHuI7afrCI53HIMoq48eT+fpDXQKffHyqxMoictfM/hqhsOvcQHha3718dWnCDUeihqeE6blzqumuT8ATrxRT93iPA+rGeaqbB2t2H+hexKY0QjZW98nIBc6ruYQe0prxDl3dFOQwHAYOzz40ZCcbDlp8OVFbTbNjDYPAzPQVl3RO8qzYJ8x87v8w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(346002)(366004)(396003)(39860400002)(451199021)(478600001)(6506007)(71200400001)(6512007)(86362001)(2616005)(186003)(38100700002)(53546011)(54906003)(4326008)(6916009)(66946007)(66446008)(66476007)(66556008)(83380400001)(64756008)(6486002)(91956017)(76116006)(316002)(122000001)(8676002)(8936002)(38070700005)(41300700001)(2906002)(5660300002)(33656002)(36756003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <07C1C1DEA003DC4C812C6418AB903CB2@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8694 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5b7eeb52-f06d-4a56-6170-08db7c99033c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FA58q3xECwUUPkRCu6xhnvnGUGr+ro1d8FmccKRKjlLLe94dLEiq2GgFNh3hpr65nFJZEe0Zdd1S6uuhuEUwd1GidbV8PNNVeLRtI9ub7ioiOXkLltml6tjC8KLjmscQosOtqWAHpArFf6Rvmxz6PA36mU48NUWbSVhcM6dX5Sl5QWZ+BEqzX6iG80X+nlxf9Zb0qoU+zqfYfc1DzoRgYWsAuSn5MsO0z1havFElPqplDFP7xuyptE9lpwcLcZVZsrk+u+OWCE9nboFa4RBfGkDKDa0LmYEfWN6WSKCGxuPBQ3cjvO3B3vKu34H0JNLj6D7uL69UTqf6HGgqpfnBkOkydRDDlED6ha2UvIbeQHNag70OfjKasMVxAdhNHDv+sYMbvlynmExwohps+YDr8lV7cRpbyHjrgdjh3KAel721NpXjwmwpjwgMByTWVOx053juKIq0KN3IYUJFtAaUQg5WtGugK42wm5tUZTSCpywoVmSslTXmUi5BJbwoSl8kqdZ6d3g30nZ5OlTKOuFb9RuMRZ7UP2WFEI8QMoWJ+Gk3/ZYz595am3gSf/d8H8EKVYKopcMAghvuXkmAoF9ckqNuZbxrposkJWoHOIDV8yDzDcdsGmZbQ+314R23wF2xgh2Vbj8fJ5cYoPyFif8h1se9aODGQxtQUh2t30ks4a2igNM6Nzklpj64UYG5eOrexxXlmCqRkyh/1/v/l3nFgg9hXmp+ANwK29+8yFZ2iHulhtxjLIyLb09HXH8oZ4AN X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(346002)(376002)(136003)(451199021)(46966006)(40470700004)(36840700001)(40460700003)(2906002)(41300700001)(6862004)(5660300002)(8676002)(8936002)(82310400005)(33656002)(36756003)(40480700001)(86362001)(186003)(2616005)(478600001)(26005)(6512007)(6506007)(82740400003)(6486002)(70206006)(47076005)(316002)(70586007)(4326008)(36860700001)(107886003)(53546011)(81166007)(54906003)(336012)(83380400001)(356005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 14:14:51.6315 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 72a7f30c-d7bb-4346-66ae-08db7c990877 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5366 Hi Julien, > On 29 Jun 2023, at 22:11, Julien Grall wrote: >=20 > From: Julien Grall >=20 > UBSAN has been enabled a few years ago on x86 but was never > enabled on Arm because the final binary is bigger than 2MB ( > the maximum we can currently handled). >=20 > With the recent rework, it is now possible to grow Xen over 2MB. > So there is no more roadblock to enable Xen other than increasing > the reserved area. >=20 > On my setup, for arm32, the final binaray was very close to 4MB. > Furthermore, one may want to enable UBSAN and GCOV which would put > the binary well-over 4MB (both features require for some space). > Therefore, increase the size to 8MB which should us some margin. >=20 > Signed-off-by: Julien Grall I am ok with the drawback. Reviewed-by: Bertrand Marquis Cheers Bertrand >=20 > --- >=20 > The drawback with this approach is that we are adding 6 new > page-table (3 for boot and 3 for runtime) that are statically > allocated. So the final Xen binary will be 24KB bigger when > neither UBSAN nor GCOV. >=20 > If this is not considered acceptable, then we could make the > size of configurable in the Kconfig and decide it based on the > features enabled. >=20 > Changes in v2: > - Fix typoes > - Add Michal's reviewed-by tag > - Add Henry's reviewed-by tag > - Add a comment regarding the reserved size for Xen > --- > xen/arch/arm/Kconfig | 1 + > xen/arch/arm/include/asm/config.h | 22 +++++++++++++--------- > 2 files changed, 14 insertions(+), 9 deletions(-) >=20 > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index 61e581b8c2b0..06b5ff755c95 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -17,6 +17,7 @@ config ARM > select HAS_PASSTHROUGH > select HAS_PDX > select HAS_PMAP > + select HAS_UBSAN > select IOMMU_FORCE_PT_SHARE >=20 > config ARCH_DEFCONFIG > diff --git a/xen/arch/arm/include/asm/config.h b/xen/arch/arm/include/asm= /config.h > index 6d246ab23c48..cc32802ad0e9 100644 > --- a/xen/arch/arm/include/asm/config.h > +++ b/xen/arch/arm/include/asm/config.h > @@ -74,10 +74,10 @@ > /* > * ARM32 layout: > * 0 - 2M Unmapped > - * 2M - 4M Xen text, data, bss > - * 4M - 6M Fixmap: special-purpose 4K mapping slots > - * 6M - 10M Early boot mapping of FDT > - * 10M - 12M Livepatch vmap (if compiled in) > + * 2M - 10M Xen text, data, bss > + * 10M - 12M Fixmap: special-purpose 4K mapping slots > + * 12M - 16M Early boot mapping of FDT > + * 16M - 18M Livepatch vmap (if compiled in) > * > * 32M - 128M Frametable: 32 bytes per page for 12GB of RAM > * 256M - 1G VMAP: ioremap and early_ioremap use this virtual address > @@ -94,10 +94,10 @@ > * 0x0000020000000000 - 0x0000027fffffffff (512GB, L0 slot [4]) > * (Relative offsets) > * 0 - 2M Unmapped > - * 2M - 4M Xen text, data, bss > - * 4M - 6M Fixmap: special-purpose 4K mapping slots > - * 6M - 10M Early boot mapping of FDT > - * 10M - 12M Livepatch vmap (if compiled in) > + * 2M - 10M Xen text, data, bss > + * 10M - 12M Fixmap: special-purpose 4K mapping slots > + * 12M - 16M Early boot mapping of FDT > + * 16M - 18M Livepatch vmap (if compiled in) > * > * 1G - 2G VMAP: ioremap and early_ioremap > * > @@ -124,7 +124,11 @@ > #define XEN_VIRT_START (SLOT0(4) + _AT(vaddr_t, MB(2))) > #endif >=20 > -#define XEN_VIRT_SIZE _AT(vaddr_t, MB(2)) > +/* > + * Reserve enough space so both UBSAN and GCOV can be enabled together > + * plus some slack for future growth. > + */ > +#define XEN_VIRT_SIZE _AT(vaddr_t, MB(8)) > #define XEN_NR_ENTRIES(lvl) (XEN_VIRT_SIZE / XEN_PT_LEVEL_SIZE(lvl)) >=20 > #define FIXMAP_VIRT_START (XEN_VIRT_START + XEN_VIRT_SIZE) > --=20 > 2.40.1 >=20 >=20 From xen-devel-bounces@lists.xenproject.org Tue Jul 04 14:17:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 14:17:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558397.872454 (Exim 4.92) (envelope-from ) id 1qGgqJ-0000V1-7h; Tue, 04 Jul 2023 14:17:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558397.872454; Tue, 04 Jul 2023 14:17:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGgqJ-0000Uu-4b; Tue, 04 Jul 2023 14:17:23 +0000 Received: by outflank-mailman (input) for mailman id 558397; Tue, 04 Jul 2023 14:17:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGgqI-0000Uo-4U for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 14:17:22 +0000 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on20630.outbound.protection.outlook.com [2a01:111:f400:7e8b::630]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7b83863a-1a75-11ee-8611-37d641c3527e; Tue, 04 Jul 2023 16:17:19 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by MN2PR12MB4176.namprd12.prod.outlook.com (2603:10b6:208:1d5::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 14:17:14 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::8018:78f7:1b08:7a54]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::8018:78f7:1b08:7a54%2]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 14:17:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7b83863a-1a75-11ee-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=enSzB7C+LshLhSkdk39NI2sA19LfKuFPkImqUsLN0MquQT9bJPI1JF9CyxUrcI2dS5EmXX8gQEIuPN3vxUT0KTH2ZpxUnUSxGAt8vtnbRkgKMm9BRgOMYSLzs2nKOyjVdVjnxYChCkyDXIa7uAJWgEjiJq+DUQXpuwhtajZ2D3hwjsZWlYxbL/kMdWjhIMxuurC3fUwI4tKa59/h5V6BoJ67FxVjZe7MBTJVyiwN+TZbKFQeywoHHR+KMp9DeRsnWsHSoAnCKjuTPLuEC9RXm2svBkKRkCYAjKiBfVEjG28UjSEkqaMWMtfC8LH/NyWGcSQqlIdtKyiQnlz+mImt0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NC0QtpFwKtnzvqPqYL1Q9UUuDbyf8nbwSb4gLzA1xhw=; b=ELIBtYU0gAzeJ9tO8UiJuUuS6wCuluuuLgStxosTt3Hj2ZF68JDME1vmVKqZTfUFkzLDaLjEjIuCj5iZrKZ27c5ll350XjNorCrue1y4sWFhUUkZwRM13YSLLORr9FBAyRFlUu7o5OsGgFvtcFBA1tIU4iCJk/DFP2ZvHcFQVA77HAHaQ7ylllqSIrlZYrx87+JTlWwAmSBO2/S6KHcEvCJK6mTizYnzrnS3+phknZQcYLEKk1Ekz774VTXhQED0AxoenO5TDOw2m/51+5/GuaFnxtHNxcVw2V0TA62IHc9O6T4cJBFDWA9NWHWGAMa8T3P3U43TwKR7pGXsk+lhkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NC0QtpFwKtnzvqPqYL1Q9UUuDbyf8nbwSb4gLzA1xhw=; b=xi4xNXrOdqHFrLALjsIloxc6hpLope8UrCS2lOPnGXOu2gU8xmvAOZy4pAI0/5G5jr7cSBs1eMaU+PDqwG2oaHK7Th/i6PAQxLDxaZcEImZaVHWDFp/K/yNVp5cjUuXLKc+TgGhvz3Y3om5qFxcXW1bIF8tbVWhOiC2VrcVQ7A8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: Date: Tue, 4 Jul 2023 15:17:06 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 00/52] xen/arm: Add Armv8-R64 MPU support to Xen - Part#1 To: Penny Zheng , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Paul Durrant References: <20230626033443.2943270-1-Penny.Zheng@arm.com> From: Ayan Kumar Halder In-Reply-To: <20230626033443.2943270-1-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0173.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18a::16) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|MN2PR12MB4176:EE_ X-MS-Office365-Filtering-Correlation-Id: 0e41b734-22a8-4c7b-e1f6-08db7c995d21 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: I+yAbGhXr6e/FDg5irm3UpsphngIHqVzH0TAdaW3YkMGdFhbeY8e6CZ/lOQcOYFtnrRWTGiDkzmGsWb/pmRYPL2dV2194monfdlt/t8wQY8i+9XLh8XWiz2IxQN47Xl5JzZigunFj5ztO+jXokSABZERlfQWlQhm9Rm4BOgYvEoQA5KgWI9QhlJhnynDXoboMa1y6fzU7VWWEwo5Z8umoAU5Ow2nLYxZs+qAeYFf6ksFNroSpuu++Pe6UUR/nNtJCBGorqD6DCjb+qwHSajbeSOUq0HqbW3Emj5cyRpPnuz+IZ1dwynaclHPOVq5kdw1A9sjf2eeXiOc/xulGcrnI4dK/IXVK9EW9nsHuGTEkwnPAne00lMEUA3AagDC1sEhczkcnl04qUA3up0XLyafCadTJcKfYfQTIIJ8S2/qfszX6vv4ToXv/Z4uPN33ubB4Urpqnd6HvK41yxaGlDy/b/hAwIqFGuznUFGZ7l7M8fZs9BcG8xyCuGw4Y/XJjW3EKb1jRO0xEf9kStJlESpY7X7GzmwWpO+nxVFVLI1caUg0knN3KFW/MzYGn5jWB1p1GpNtmNlkiPJcJHDmeydCR9XrwTniaf5ogt5ytwh8EAd41TClvw68/DwecoppcTcsqoff8CUvgxaWKU5VplekJkdGfUEzL5sLLKOGXxYhRoDnui12JT2GxU+BtowX7StcCdKPvoXi0SKHwUwCBBDzQeVNq1W8cLoP5JuJ+lkos+s= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(346002)(366004)(39860400002)(396003)(376002)(451199021)(316002)(54906003)(66556008)(66476007)(8676002)(41300700001)(4326008)(8936002)(66946007)(38100700002)(53546011)(6506007)(478600001)(31686004)(5660300002)(6512007)(7416002)(26005)(186003)(966005)(6486002)(6666004)(31696002)(83380400001)(36756003)(2616005)(2906002)(17413003)(21314003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bThnL1NsZ09tTWU2UDJnNGhRSDV0Qk1KVUkyOXM1QWYvelJvWkJ1UHp4Y1Yw?= =?utf-8?B?S2RXQ25heGprN2VaWGV3ZUZaVmlwbHlQNGZ1SDBmUnoycmt1cVlDTFIzRWtZ?= =?utf-8?B?NG9vZmRLTS9jWDNIRUVWQ0h0NEcxY1p2VWgvOVR1aEpNZzkwbmFHMmVwNXVX?= =?utf-8?B?UWdGQkh3bzB6SmhWakdST3BvYkw5aEwzMXhnZURPSmFOemVCOTNncGYvSGNG?= =?utf-8?B?clpCNEs1eDlDUWN6RWllaTZNL2pPS2J3YktRcVU1VVJWMnJwSENCU3ZCbUxj?= =?utf-8?B?WXlCZFVzbmVHZDhPSmdyeHJIbEZxb0JxMlZ2cVRWYWFpTDBmcDQ2YXhCdHNI?= =?utf-8?B?K095aUw3NHJBYjkvY2lreGxQRHU0OEZmTkJURlBUNk53WUMvZk9SdjE2T3B1?= =?utf-8?B?SG84QUFhUHNiRGljRG9VTmdXeUtpS1ZiMkdvcEJGWmtFMXZobXpmelM2VEVC?= =?utf-8?B?c2U5NXBjeVQzOEZKWndxZ0FYcXdPcTlCaW9TV0NJaGRUanFuQ2dxNEVORDY2?= =?utf-8?B?aDlTYTFORm5GaEt1YWtsK1JRdmJ4aWYva05mZ3J5a3BVNHBpc05TcisrWDkv?= =?utf-8?B?SVhNM3ZTM0s0blNVWWptNG1EdTdWNW96NUxwalJydGw1dzRkZkgwVGgxYisr?= =?utf-8?B?UG92QUU2amFWbGcrdWhMQW9oUzU2d2l1NFVSalhyaUdJVlR3OGZaMDk5SFdy?= =?utf-8?B?WE41dGJncEdvYkkwTUZtMFNXclNXc0pJNFExUzR1RU1uMXkrOVJwVDdGRHB3?= =?utf-8?B?TDdaYW1CS054VEVBb0pJWE83c0FkS2t5WW5QZGJRUDZVKzJ1OFN6RFBiMUpj?= =?utf-8?B?b2FRRUdlNTRlckxHRXVoQXZzWkloSjk5aVVFMk5DVmErZlR4MzlOYlRyV1pM?= =?utf-8?B?Y05zd3duVndxS3JjbW82YmlZTThoNEhmdWQrSEduWVJEOXN3VmZzSU1KY1Zx?= =?utf-8?B?cVNkUHBDV3VMV242aXVldWNFVFVUSkdSWXN5L21STzhJaEtTN2RqQ0VrazJT?= =?utf-8?B?ZHI0T1RTYlQ2Q2pLTVo5ZlJuR3dibUIyYzlqekNyWGRBN2l4SkZoZU5MZHl3?= =?utf-8?B?cGRUYlFyK3llTVM3a3VyMDBDQlZUdXd4R2Yyczh3RzN0cDk5SjZlQU9oczFx?= =?utf-8?B?NmpvNUUzK2dRMTRrV1ptWjh6eXF0eVJNcWpMNXhLWU53bkVyWTNGN0Zkb2tW?= =?utf-8?B?cGJ4VTV3RFRTcGR5cEx1ZWd6RW5vYnUzZGlwTW9RWVR1QWp5OTlvc3dFRGhG?= =?utf-8?B?TVhtSWNia0l3ZU10TzhaQ1ZtZ0x5QjRqbEZ1YW16TkxoMkRiblFvZllocTJt?= =?utf-8?B?WnF2SGU3YmJ0TC9HVm1STk8vd1dEYnd3VFJrZ2RZS0NjamZvUkVNWVRqSk5j?= =?utf-8?B?Tk5vcVJVMlE3NU5BRVIxc3czMld1UmhVYjBjckpEQ0x1VzVvUEU3UEdzUU9z?= =?utf-8?B?M0ZUUXdPemVnS2NGV0JhVDlncTRySENyUVdGNUxodndTVnBSZk45cS9MZEVh?= =?utf-8?B?ZEVEM2xOeXNsWks2QjhkR1M2NUZIKzF1Tlloa0ZxQUViWkxMa293aFdGQWFa?= =?utf-8?B?SjlpQVFrUnZmYUh5bzRnVmJyQ05ORGd2Y3V0R1BFYzM3aW5Sc2FOUzlkZ3M4?= =?utf-8?B?RXZVZm9QM3hTV2RTT0IwdmxidlVXSEswc0d1UEhFMnU3bXloVW1JelpCRUl2?= =?utf-8?B?bVF0QUNONE1lUWVSOFZhTG43TkpPNHJTQWFFWkh2eVlTWHBockY3TmthVUVp?= =?utf-8?B?bVN3K3VudXF4QkFLTGcrbDBhU3R3cXluZDU0ZzlKMnF5R0lRS1lZSEZTNEpw?= =?utf-8?B?cHJlbDQ5S0tPVEVKc21pMGlBZWljcmlCamZXWUFjMUw4RmNrV1ZQN0h3cFV6?= =?utf-8?B?N0xTUUIvNWM3dWhuL2VnN0hnK1VXd2tERmZIWUdBODc2MDRVZTBOQll0Z0Fv?= =?utf-8?B?SG9nNlYxb2FUM3JkMCtxc0VidzhVRjQ2TjB6ZkRmTFJ5QUNGVWN6aGRoUXFt?= =?utf-8?B?em5lSVpHT2hzK0ZiUS9Cei9OS05GM2ZOWDRkY2h5MEdHcDhtQm03dVRDTG5q?= =?utf-8?B?R3ZqWmdFYlJrc3NWa0p5azdWOWJTcFRadWdsdTBLTE12T1NWb3ZRdTZSYmds?= =?utf-8?Q?wcqCsE8cN9HCDswlFHLnWg46Z?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e41b734-22a8-4c7b-e1f6-08db7c995d21 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 14:17:14.0184 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CqaBowDdGqburKS9+ulQt0re3OBefZ3x+c/dGHyWfVVQbeKi8E69HZtlIkozpSQBU1d55pDM9t305nvO/7IYHg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4176 On 26/06/2023 04:33, Penny Zheng wrote: > CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. > > > So sorry for the long long wait before v3 serie, since I got sidetracked to > a new high priority internal project for quite a time. > > The Armv8-R architecture profile was designed to support use cases > that have a high sensitivity to deterministic execution. (e.g. > Fuel Injection, Brake control, Drive trains, Motor control etc) > > Arm announced Armv8-R in 2013, it is the latest generation Arm > architecture targeted at the Real-time profile. It introduces > virtualization at the highest security level while retaining the > Protected Memory System Architecture (PMSA) based on a Memory > Protection Unit (MPU). In 2020, Arm announced Cortex-R82, > which is the first Arm 64-bit Cortex-R processor based on Armv8-R64. > The latest Armv8-R64 document can be found [1]. And the features of > Armv8-R64 architecture: > - An exception model that is compatible with the Armv8-A model > - Virtualization with support for guest operating systems > - PMSA virtualization using MPUs In EL2. > - Adds support for the 64-bit A64 instruction set. > - Supports up to 48-bit physical addressing. > - Supports three Exception Levels (ELs) > - Secure EL2 - The Highest Privilege > - Secure EL1 - RichOS (MMU) or RTOS (MPU) > - Secure EL0 - Application Workloads > - Supports only a single Security state - Secure. > - MPU in EL1 & EL2 is configurable, MMU in EL1 is configurable. > > These patch series are implementing the Armv8-R64 MPU support > for Xen, which are based on the discussion of > "Proposal for Porting Xen to Armv8-R64 - DraftC" [2]. > > We will implement the Armv8-R64 and MPU support in three stages: > 1. Support to boot MMU domains on Armv8-R64 Xen. > 2. Support to boot MPU domains on Armv8-R64 Xen. > 3. SMP and other advanced features of Xen support on Armv8-R64. > > For having a overall undestanding for reviewers about MPU framework on Xen, > we have introduced a large patch serie here, including 52 commits. At this > stage, we could successfully boot a linux guest on FVP_BaseR_AEMv8R > model[3]. > > We will split these patches to several parts, this series is the > part#1, v1 is in [4], the full PoC can be found in [5]. More software for > Armv8-R64 can be found in [6]; > > [1] https://developer.arm.com/documentation/ddi0600/latest > [2] https://lists.xenproject.org/archives/html/xen-devel/2022-05/msg00643.html > [3] https://developer.arm.com/tools-and-software/simulation-models/fixed-virtual-platforms/arm-ecosystem-models > [4] https://lists.xenproject.org/archives/html/xen-devel/2022-11/msg00289.html > [5] https://gitlab.com/xen-project/people/weic/xen/-/tree/integration/mpu_v3 > [6] https://armv8r64-refstack.docs.arm.com/en/v5.0/ > > Penny Zheng (41): > xen/arm: introduce CONFIG_HAS_MMU > xen/arm: mmu: fold FIXMAP into MMU system > xen/mmu: extract early uart mapping from setup_fixmap > xen/mmu: move MMU-specific setup_mm to mmu/setup.c > xen: make VMAP only support in MMU system > xen/mmu: relocate copy_from_paddr into setup.c > xen/arm: do not give memory back to static heap > xen/arm: only map the init text section RW in free_init_memory > xen/arm: switch to use ioremap_xxx in common file > xen/mmu: move MMU specific P2M code to mmu/p2m.c and mmu/p2m.h > xen: introduce CONFIG_HAS_PAGING_MEMPOOL > xen/mmu: enable SMMU subsystem only in MMU > xen/mpu: build up start-of-day Xen MPU memory region map > xen/mpu: introduce helpers for MPU enablement > xen/mpu: map early uart when earlyprintk on > xen/mpu: introduce setup_mm_mappings > xen/mpu: plump virt/maddr conversion in MPU system > xen/mpu: introduce a pair helper > read_protection_region()/write_protection_region() > xen/mpu: populate a new region in Xen MPU mapping table > xen/mpu: make early_fdt_map support in MPU systems > xen/mpu: implement MPU version of setup_mm in mpu/setup.c > xen/mpu: initialize frametable in MPU system > xen/mpu: destroy an existing entry in Xen MPU memory mapping table > xen/arm: map static memory on demand > xen/mpu: implememt ioremap_xxx in MPU > xen/mpu: implement MPU version of copy_from_paddr > xen/mpu: map domain page in MPU system > xen/mpu: support free_init_memory in MPU system > xen/mpu: implement remove_early_mappings in MPU system > xen/mpu: Use secure hypervisor timer in MPU system > xen/mpu: implement setup_virt_paging for MPU system > xen/mpu: configure VSTCR_EL2 in MPU system > xen/mpu: P2M initialization in MPU system > xen/mpu: insert an new entry into guest physmap in MPU system > xen/mpu: look up entry in p2m table > xen/mpu: support vcpu context switch in MPU system > xen/mpu: enable MMIO region trap in MPU system > xen/mpu: enable device passthrough in MPU system > xen/mpu: dump debug message in MPU system > xen/mpu: create stubs of function/variables for UNSUPPORTED features > xen/arm: add Kconfig option CONFIG_HAS_MPU to enable MPU system > support > > Wei Chen (11): > xen/arm: remove xen_phys_start and xenheap_phys_end from config.h > xen/arm: make ARM_EFI selectable for Arm64 > xen/arm: add an option to define Xen start address for Armv8-R > xen/arm: add .text.idmap in ld script for Xen identity map sections > xen/arm64: head: Introduce enable_boot_mmu and enable_runtime_mmu > xen/arm64: prepare for moving MMU related code from head.S > xen/arm64: move MMU related code from head.S to mmu/head.S > xen/arm: use PA == VA for EARLY_UART_VIRTUAL_ADDRESS on MPU systems > xen/arm: Move MMU related definitions from config.h to mmu/layout.h > xen/mmu: extract mmu-specific codes from mm.c/mm.h > xen/arm: create mpu/layout.h for MPU related address definitions Hi All, I had a look at the first 22 patches (which touch the MMU code) and I did not find anything which will impact the R52 work directly. - Ayan > > xen/arch/arm/Kconfig | 52 +- > xen/arch/arm/Kconfig.debug | 7 + > xen/arch/arm/Makefile | 15 +- > xen/arch/arm/arm32/head.S | 2 +- > xen/arch/arm/arm64/Makefile | 7 +- > xen/arch/arm/arm64/head.S | 472 +----- > xen/arch/arm/arm64/mmu/head.S | 463 ++++++ > xen/arch/arm/arm64/{ => mmu}/mm.c | 7 +- > xen/arch/arm/arm64/mpu/head.S | 255 ++++ > xen/arch/arm/arm64/smpboot.c | 6 +- > xen/arch/arm/bootfdt.c | 2 +- > xen/arch/arm/domain.c | 2 + > xen/arch/arm/domain_build.c | 2 + > xen/arch/arm/include/asm/arm64/macros.h | 51 + > xen/arch/arm/include/asm/arm64/mm.h | 7 +- > xen/arch/arm/include/asm/arm64/mpu.h | 140 ++ > xen/arch/arm/include/asm/arm64/sysregs.h | 76 + > xen/arch/arm/include/asm/config.h | 129 +- > xen/arch/arm/include/asm/cpufeature.h | 7 + > xen/arch/arm/include/asm/early_printk.h | 20 + > xen/arch/arm/include/asm/fixmap.h | 31 +- > xen/arch/arm/include/asm/mm.h | 79 +- > xen/arch/arm/include/asm/mmu/layout.h | 141 ++ > xen/arch/arm/include/asm/mmu/mm.h | 54 + > xen/arch/arm/include/asm/mmu/p2m.h | 18 + > xen/arch/arm/include/asm/mpu/layout.h | 32 + > xen/arch/arm/include/asm/mpu/mm.h | 36 + > xen/arch/arm/include/asm/mpu/p2m.h | 18 + > xen/arch/arm/include/asm/p2m.h | 48 +- > xen/arch/arm/include/asm/page.h | 46 +- > xen/arch/arm/include/asm/processor.h | 14 + > xen/arch/arm/include/asm/setup.h | 16 +- > xen/arch/arm/kernel.c | 42 +- > xen/arch/arm/mm.c | 1160 +------------- > xen/arch/arm/mmu/mm.c | 1133 ++++++++++++++ > xen/arch/arm/mmu/p2m.c | 1612 +++++++++++++++++++ > xen/arch/arm/mmu/setup.c | 379 +++++ > xen/arch/arm/mpu/domain_page.c | 68 + > xen/arch/arm/mpu/mm.c | 959 ++++++++++++ > xen/arch/arm/mpu/p2m.c | 518 +++++++ > xen/arch/arm/mpu/setup.c | 102 ++ > xen/arch/arm/p2m.c | 1782 ++-------------------- > xen/arch/arm/platforms/Kconfig | 8 +- > xen/arch/arm/setup.c | 388 +---- > xen/arch/arm/smpboot.c | 6 +- > xen/arch/arm/traps.c | 97 +- > xen/arch/arm/xen.lds.S | 6 +- > xen/arch/x86/Kconfig | 2 + > xen/arch/x86/setup.c | 2 + > xen/common/Kconfig | 8 + > xen/common/Makefile | 2 +- > xen/common/domctl.c | 2 + > xen/common/vmap.c | 7 + > xen/drivers/passthrough/Kconfig | 3 +- > xen/include/xen/vmap.h | 11 +- > 55 files changed, 6730 insertions(+), 3822 deletions(-) > create mode 100644 xen/arch/arm/arm64/mmu/head.S > rename xen/arch/arm/arm64/{ => mmu}/mm.c (97%) > create mode 100644 xen/arch/arm/arm64/mpu/head.S > create mode 100644 xen/arch/arm/include/asm/arm64/mpu.h > create mode 100644 xen/arch/arm/include/asm/mmu/layout.h > create mode 100644 xen/arch/arm/include/asm/mmu/mm.h > create mode 100644 xen/arch/arm/include/asm/mmu/p2m.h > create mode 100644 xen/arch/arm/include/asm/mpu/layout.h > create mode 100644 xen/arch/arm/include/asm/mpu/mm.h > create mode 100644 xen/arch/arm/include/asm/mpu/p2m.h > create mode 100644 xen/arch/arm/mmu/mm.c > create mode 100644 xen/arch/arm/mmu/p2m.c > create mode 100644 xen/arch/arm/mmu/setup.c > create mode 100644 xen/arch/arm/mpu/domain_page.c > create mode 100644 xen/arch/arm/mpu/mm.c > create mode 100644 xen/arch/arm/mpu/p2m.c > create mode 100644 xen/arch/arm/mpu/setup.c > > -- > 2.25.1 > > From xen-devel-bounces@lists.xenproject.org Tue Jul 04 14:23:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 14:23:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558403.872463 (Exim 4.92) (envelope-from ) id 1qGgwH-00021u-Uq; Tue, 04 Jul 2023 14:23:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558403.872463; Tue, 04 Jul 2023 14:23:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGgwH-00021n-Rk; Tue, 04 Jul 2023 14:23:33 +0000 Received: by outflank-mailman (input) for mailman id 558403; Tue, 04 Jul 2023 14:23:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGgwG-00021h-Gh for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 14:23:32 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2061c.outbound.protection.outlook.com [2a01:111:f400:7d00::61c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 59c65b0a-1a76-11ee-b237-6b7b168915f2; Tue, 04 Jul 2023 16:23:31 +0200 (CEST) Received: from AS4P189CA0013.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:5d7::16) by DBBPR08MB5931.eurprd08.prod.outlook.com (2603:10a6:10:1f7::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 14:23:28 +0000 Received: from AM7EUR03FT062.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:5d7:cafe::31) by AS4P189CA0013.outlook.office365.com (2603:10a6:20b:5d7::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.30 via Frontend Transport; Tue, 4 Jul 2023 14:23:28 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT062.mail.protection.outlook.com (100.127.140.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.18 via Frontend Transport; Tue, 4 Jul 2023 14:23:27 +0000 Received: ("Tessian outbound d6c4ee3ba1eb:v142"); Tue, 04 Jul 2023 14:23:27 +0000 Received: from 6f96fb54ab16.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 713A28D3-DA81-406F-97B6-1709F1932EA7.1; Tue, 04 Jul 2023 14:23:21 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6f96fb54ab16.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 04 Jul 2023 14:23:21 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB9PR08MB7509.eurprd08.prod.outlook.com (2603:10a6:10:300::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 14:23:18 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::5e17:39a6:eec7:c482]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::5e17:39a6:eec7:c482%4]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 14:23:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 59c65b0a-1a76-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BWnLRr1NKLouYw/5csM4wai4v6vtQWe/sZa1dgMZm8M=; b=fLVSye1KFkpmvtcjfradE2pnWT8AzBBKItU/8jeHxx3BuOvf/0O/6PKzJsq67QgrAHMuRjxTRAb79No21t6Ouw9JiUmW9/SjMZrMdFAEEqzEn08NtViJeun/X2IVuNSOqL/Nec1DFe/Mwa3q+Gkl3ekF/p0hKQ1g82bqTDdunT8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 8f1ccdb6a8d3a409 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Co5dAPKg0NnlPR7zqHRL8MQSxolO2ECn92y6N2RksEAdxjNB9fRImPj8nkRaZcBjS+jE5cDgq8cwKWcaNOkUBhwvqcph8Q+imczSZ4duzxxqQ+NtyELwJ45TiREb5esq9L1noS285Atr4N3ooSVluPomD96E1nrtAQwJ/M31gW9PiGQy/7LyDRG0jSdr9eHf+eW3SK/wwaeAS6xJnAgHSvm7N9qENey4qJtYKs2M60a6zCBXi/X1OkX9uKWRr56ugvTzBvjlyNJyh5tZZQ2nU4bG/fy6h7yfHJ99sZ1As+645NTSDEyO0ckvNNQuFhGYSpMuYf1u1YC5wLlCtItbDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BWnLRr1NKLouYw/5csM4wai4v6vtQWe/sZa1dgMZm8M=; b=KoFBEuwtceoM9E0hCJkF9PRUW7Iy5kNjKp6oA06Czid9XXlcvvla415KmbtCoibCNdjt30Y1xFqmkToj4fhxAZd6mZ91wFuewhgz27hiKOCBgHMny285yT1x8HNbYJ09S6emMPQS4b3TNUZSdGaZ3zv8+Ls39td65Q0ary9hPooLM450Zr7Jot5urq/hb+I0RHq34nvHVoxqZN8Ec/TVivB8OmqkC1K7H4HNAPJpghyTt51U7L8arW7/MRS4VoGQtWQpx2CLX9fGcY+3fZ/n+Unszc7cohVO2zDoTnAPNe490eLJdVCxkjAYMQy7NIGUshZWEyWmkZUg55OVFi82HA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BWnLRr1NKLouYw/5csM4wai4v6vtQWe/sZa1dgMZm8M=; b=fLVSye1KFkpmvtcjfradE2pnWT8AzBBKItU/8jeHxx3BuOvf/0O/6PKzJsq67QgrAHMuRjxTRAb79No21t6Ouw9JiUmW9/SjMZrMdFAEEqzEn08NtViJeun/X2IVuNSOqL/Nec1DFe/Mwa3q+Gkl3ekF/p0hKQ1g82bqTDdunT8= From: Bertrand Marquis To: Julien Grall CC: Xen-devel , Luca Fancellu , "michal.orzel@amd.com" , Henry Wang , Julien Grall Subject: Re: [v2 3/4] xen/arm: Rework the code mapping Xen to avoid relying on the size of Xen Thread-Topic: [v2 3/4] xen/arm: Rework the code mapping Xen to avoid relying on the size of Xen Thread-Index: AQHZqsX1dQvVUjA1m0mu4FJvosJOiq+psI6A Date: Tue, 4 Jul 2023 14:23:18 +0000 Message-ID: <7FE33D49-1D61-4F4F-BB29-3621119ACFFE@arm.com> References: <20230629201129.12934-1-julien@xen.org> <20230629201129.12934-4-julien@xen.org> In-Reply-To: <20230629201129.12934-4-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.600.7) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|DB9PR08MB7509:EE_|AM7EUR03FT062:EE_|DBBPR08MB5931:EE_ X-MS-Office365-Filtering-Correlation-Id: ee58045e-8a51-4744-19da-08db7c9a3c17 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: LGH8sQh7VXySQCbrj/HUJOWdIbNukCUfrRB5JqiBQhHyYL7fCM5PVYqsp1nRqCjG0L6uNdyiE4jbGJze5j6nt2G7iUEpsO9JQ8clWj815zVyam+eklFpM00MAVsddHfJ3RroUXkXniH/1NHaW7SAxXpkTMAYU6gbzOpexQ8ZOA095jk4oaiFLHo7109SKOyy5P3BZy6CsaT7mslmWkrP6Qpm2H3GEdMz4vhpGXadoaqldNIE95OWMdYLcr97MIj9qSDx9c2IQQAJR7dKY93HUeuIG+AAaXhPyj59DIeY7bSNFsYCGA6rVFnuiNR9XaBYgcwub+RFCdlju6MUFzDfkhwmICw0VOWHn2vIWSxd/OywFzdfEy1SbOy59BXqB8dsK1+JE7gb8yTP0iVHSH9a4p3sOfeLoKoe/2lKEKr7oFWEri+Xvpf7lDCdcJSJ01ACjNcwoTDWxsSCJWhDdqiHWN+xsl10u47D4RVRrkHtjbj7BsqHBeRBWj+pd7hO4P+vCMjqe6OIiXo2uFbXAqCrg4XLihLCGYeevnCUk9+yYTWC7/Nuuh7ffTAIkNt0mk5rZg9TV4xSUVFPPhLISC4ZkOxNPK+cbalYUH1qQ0Vlot1XWBk96HfePjNp8ZLw/UZAEQr0CA8imzJjUTFYeLWhFg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(346002)(366004)(39860400002)(396003)(451199021)(38100700002)(71200400001)(30864003)(33656002)(2906002)(6486002)(8936002)(8676002)(38070700005)(54906003)(36756003)(41300700001)(478600001)(5660300002)(76116006)(66946007)(66446008)(91956017)(86362001)(64756008)(186003)(6916009)(4326008)(6506007)(6512007)(66476007)(53546011)(66556008)(316002)(122000001)(2616005)(83380400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <2984BCA479B90D4BBC07C58329D67766@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7509 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 48ad3f5f-5d65-4d19-b58e-08db7c9a366d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RqSH0c2g9Zls+h37TcnP1L8mNWTJNVqreFonv3UdD8gGCpzyCSXkXP7Ro9ng5jzjhyIabc2eEcRfLXazBz+RV9UYJMJWn6L7NDjGTM0+036nfTZCLYlj+7iJ05+r4sRgydpv1qiyB0tL85TxY66ZJ8kuMhYNXRF9QpezYzeP6XsO0yzwqgXojcv8QTruGxesU4ko+Pu7yekvjplaA18kCfbeXt/GZPjqeAOS1c8hAOHy7s2Aeqipzn3arGHYZyksqrLz5wmcIFPPv+fC5bn7iQIOlxwcymqaDYKH2RXJzS5pmsw0l5uufnrTbvxcHgmjd3KJxJjX/u4fZfBBCBZWwnukg+gAnZHItIL2I4Ep2p+zkYFqsTjR6dTj0mPsRIF8rdNxoHPJdmHG7AA1mDOz8Nkc4pP5mUEFENVx3umCZSMSQLwPgUP7Mio0rOl/uVKH9AV+HLh0sFe1e/dfe+Ci2K1qWQkp6GaErNU9Uag4kwh2mPxaguJtEzmAJ/Wdt2X7pSJT9M3faqDFim365AY9Fr0SS5TALVFGOKKolnGaeqM3IKZDjVtYOX+GbyRE5At4sZTKkinwiAQSqKApSYPC7Z3iI9b/pDetr/smoYNsnMaXo+P7qwj2lWt3LrNGakqpaSKm0/Sh0pvUZc7tkQuQOiC5gjppRMeaEgnz/XNmGqrMFMDnFwj3evqLFdQbpSBo8HVssxOhp8LlcLZ0H/TBm3Ofof+xiFkSFmp1bdwlOsfYkdkUB59hG/Wx7nLrApuB X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(39860400002)(376002)(396003)(136003)(451199021)(40470700004)(46966006)(36840700001)(336012)(40460700003)(41300700001)(6486002)(30864003)(82310400005)(26005)(356005)(82740400003)(83380400001)(107886003)(81166007)(2616005)(53546011)(186003)(6506007)(47076005)(40480700001)(6512007)(36860700001)(54906003)(86362001)(478600001)(36756003)(2906002)(316002)(4326008)(70206006)(70586007)(8936002)(8676002)(33656002)(6862004)(5660300002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 14:23:27.7230 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ee58045e-8a51-4744-19da-08db7c9a3c17 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5931 > On 29 Jun 2023, at 22:11, Julien Grall wrote: >=20 > From: Julien Grall >=20 > At the moment, the maximum size of Xen binary we can support is 2MB. > This is what we reserved in the virtual address but also what all > the code in Xen relies on as we only allocate one L3 page-table. >=20 > When feature like UBSAN (will be enabled in a follow-up patch) and GCOV > are enabled, the binary will be way over 2MB. >=20 > The code is now reworked so it doesn't rely on a specific size but > will instead look at the reversed size and compute the number of > page-table to allocate/map. >=20 > While at it, replace any reference to 4KB mappings with a more > generic word because the page-size may change in the future. >=20 > Also fix the typo s/tlb/tbl/ in code move in arm32/head.S >=20 > Signed-off-by: Julien Grall >=20 With the commit message fixed as stated by Michal: Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > Changes in v2: > - Fix typoes > - Remove comments that don't apply > - Reword the explanation for DEFINE_BOOT_PAGE_TABLE{,S} > - Be more consistent with the way to from the virtual address to > map in mm.c > --- > xen/arch/arm/arm32/head.S | 64 +++++++++++++++++++++++-------- > xen/arch/arm/arm64/head.S | 54 ++++++++++++++++++++------ > xen/arch/arm/include/asm/config.h | 1 + > xen/arch/arm/include/asm/lpae.h | 10 +++-- > xen/arch/arm/mm.c | 24 +++++++----- > 5 files changed, 110 insertions(+), 43 deletions(-) >=20 > diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S > index 5e3692eb3abf..cfc542b55973 100644 > --- a/xen/arch/arm/arm32/head.S > +++ b/xen/arch/arm/arm32/head.S > @@ -141,8 +141,7 @@ > /* > * This must be the very first address in the loaded image. > * It should be linked at XEN_VIRT_START, and loaded at any > - * 4K-aligned address. All of text+data+bss must fit in 2MB, > - * or the initial pagetable code below will need adjustment. > + * 4K-aligned address. > */ > GLOBAL(start) > /* > @@ -373,7 +372,35 @@ ENDPROC(cpu_init) > .endm >=20 > /* > - * Macro to create a page table entry in \ptbl to \tbl > + * Macro to create a page table entry in \ptbl to \tbl (physical > + * address) > + * > + * ptbl: table symbol where the entry will be created > + * tbl: physical address of the table to point to > + * virt: virtual address > + * lvl: page-table level > + * > + * Preserves \virt > + * Clobbers \tbl, r1 - r3 > + * > + * Note that \tbl and \virt should be in a register other than r1 - r3 > + */ > +.macro create_table_entry_from_paddr, ptbl, tbl, virt, lvl > + get_table_slot r1, \virt, \lvl /* r1 :=3D slot in \tbl */ > + lsl r1, r1, #3 /* r1 :=3D slot offset in \tbl *= / > + > + movw r2, #PT_PT /* r2:r3 :=3D right for linear PT *= / > + orr r2, r2, \tbl /* + \tbl paddr */ > + mov r3, #0 > + > + adr_l \tbl, \ptbl /* \tbl :=3D (v,p)addr of \ptbl */ > + > + strd r2, r3, [\tbl, r1] > +.endm > + > + > +/* > + * Macro to create a page table entry in \ptbl to \tbl (symbol) > * > * ptbl: table symbol where the entry will be created > * tbl: table symbol to point to > @@ -388,19 +415,9 @@ ENDPROC(cpu_init) > * Note that \virt should be in a register other than r1 - r4 > */ > .macro create_table_entry, ptbl, tbl, virt, lvl > - get_table_slot r1, \virt, \lvl /* r1 :=3D slot in \tlb */ > - lsl r1, r1, #3 /* r1 :=3D slot offset in \tlb *= / > - > load_paddr r4, \tbl > - > - movw r2, #PT_PT /* r2:r3 :=3D right for linear PT *= / > - orr r2, r2, r4 /* + \tlb paddr */ > - mov r3, #0 > - > - adr_l r4, \ptbl > - > - strd r2, r3, [r4, r1] > -.endm > + create_table_entry_from_paddr \ptbl, r4, \virt, \lvl > + .endm >=20 > /* > * Macro to create a mapping entry in \tbl to \paddr. Only mapping in 3rd > @@ -451,13 +468,26 @@ ENDPROC(cpu_init) > * Output: > * r12: Was a temporary mapping created? > * > - * Clobbers r0 - r4 > + * Clobbers r0 - r5 > */ > create_page_tables: > /* Prepare the page-tables for mapping Xen */ > mov_w r0, XEN_VIRT_START > create_table_entry boot_pgtable, boot_second, r0, 1 > - create_table_entry boot_second, boot_third, r0, 2 > + > + /* > + * We need to use a stash register because > + * create_table_entry_paddr() will clobber the register storing > + * the physical address of the table to point to. > + */ > + load_paddr r5, boot_third > + mov_w r4, XEN_VIRT_START > +.rept XEN_NR_ENTRIES(2) > + mov r0, r5 /* r0 :=3D paddr(l3 table) *= / > + create_table_entry_from_paddr boot_second, r0, r4, 2 > + add r4, r4, #XEN_PT_LEVEL_SIZE(2) /* r4 :=3D Next vaddr */ > + add r5, r5, #PAGE_SIZE /* r5 :=3D Next table */ > +.endr >=20 > /* > * Find the size of Xen in pages and multiply by the size of a > diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S > index 5e9562a22240..ad9e0ba87a29 100644 > --- a/xen/arch/arm/arm64/head.S > +++ b/xen/arch/arm/arm64/head.S > @@ -146,8 +146,7 @@ > * > * This must be the very first address in the loaded image. > * It should be linked at XEN_VIRT_START, and loaded at any > - * 4K-aligned address. All of text+data+bss must fit in 2MB, > - * or the initial pagetable code below will need adjustment. > + * 4K-aligned address. > */ >=20 > GLOBAL(start) > @@ -490,6 +489,31 @@ ENDPROC(cpu_init) > ubfx \slot, \virt, #XEN_PT_LEVEL_SHIFT(\lvl), #XEN_PT_LPAE_SHIFT > .endm >=20 > +/* > + * Macro to create a page table entry in \ptbl to \tbl > + * ptbl: table symbol where the entry will be created > + * tbl: physical address of the table to point to > + * virt: virtual address > + * lvl: page-table level > + * tmp1: scratch register > + * tmp2: scratch register > + * > + * Preserves \virt > + * Clobbers \tbl, \tmp1, \tmp2 > + * > + * Note that all parameters using registers should be distinct. > + */ > +.macro create_table_entry_from_paddr, ptbl, tbl, virt, lvl, tmp1, tmp2 > + get_table_slot \tmp1, \virt, \lvl /* \tmp1 :=3D slot in \tbl *= / > + > + mov \tmp2, #PT_PT /* \tmp2 :=3D right for line= ar PT */ > + orr \tmp2, \tmp2, \tbl /* + \tbl */ > + > + adr_l \tbl, \ptbl /* \tbl :=3D address(\ptbl) = */ > + > + str \tmp2, [\tbl, \tmp1, lsl #3] > +.endm > + > /* > * Macro to create a page table entry in \ptbl to \tbl > * > @@ -509,15 +533,8 @@ ENDPROC(cpu_init) > * Note that all parameters using registers should be distinct. > */ > .macro create_table_entry, ptbl, tbl, virt, lvl, tmp1, tmp2, tmp3 > - get_table_slot \tmp1, \virt, \lvl /* \tmp1 :=3D slot in \tlb *= / > - > - load_paddr \tmp2, \tbl > - mov \tmp3, #PT_PT /* \tmp3 :=3D right for line= ar PT */ > - orr \tmp3, \tmp3, \tmp2 /* + \tlb paddr */ > - > - adr_l \tmp2, \ptbl > - > - str \tmp3, [\tmp2, \tmp1, lsl #3] > + load_paddr \tmp1, \tbl > + create_table_entry_from_paddr \ptbl, \tmp1, \virt, \lvl, \tmp2, = \tmp3 > .endm >=20 > /* > @@ -570,7 +587,20 @@ create_page_tables: > ldr x0, =3DXEN_VIRT_START > create_table_entry boot_pgtable, boot_first, x0, 0, x1, x2, x3 > create_table_entry boot_first, boot_second, x0, 1, x1, x2, x3 > - create_table_entry boot_second, boot_third, x0, 2, x1, x2, x3 > + > + /* > + * We need to use a stash register because > + * create_table_entry_paddr() will clobber the register storing > + * the physical address of the table to point to. > + */ > + load_paddr x4, boot_third > + ldr x1, =3DXEN_VIRT_START > +.rept XEN_NR_ENTRIES(2) > + mov x0, x4 /* x0 :=3D paddr(l3 tabl= e) */ > + create_table_entry_from_paddr boot_second, x0, x1, 2, x2, x3 > + add x1, x1, #XEN_PT_LEVEL_SIZE(2) /* x1 :=3D Next vaddr */ > + add x4, x4, #PAGE_SIZE /* x4 :=3D Next table */ > +.endr >=20 > /* > * Find the size of Xen in pages and multiply by the size of a > diff --git a/xen/arch/arm/include/asm/config.h b/xen/arch/arm/include/asm= /config.h > index c969e6da589d..6d246ab23c48 100644 > --- a/xen/arch/arm/include/asm/config.h > +++ b/xen/arch/arm/include/asm/config.h > @@ -125,6 +125,7 @@ > #endif >=20 > #define XEN_VIRT_SIZE _AT(vaddr_t, MB(2)) > +#define XEN_NR_ENTRIES(lvl) (XEN_VIRT_SIZE / XEN_PT_LEVEL_SIZE(lvl)) >=20 > #define FIXMAP_VIRT_START (XEN_VIRT_START + XEN_VIRT_SIZE) > #define FIXMAP_VIRT_SIZE _AT(vaddr_t, MB(2)) > diff --git a/xen/arch/arm/include/asm/lpae.h b/xen/arch/arm/include/asm/l= pae.h > index 7d2f6fd1bd5a..4a1679cb3334 100644 > --- a/xen/arch/arm/include/asm/lpae.h > +++ b/xen/arch/arm/include/asm/lpae.h > @@ -267,15 +267,17 @@ lpae_t mfn_to_xen_entry(mfn_t mfn, unsigned int att= r); >=20 > /* > * Macros to define page-tables: > - * - DEFINE_BOOT_PAGE_TABLE is used to define page-table that are used > - * in assembly code before BSS is zeroed. > + * - DEFINE_BOOT_PAGE_TABLE{,S} are used to define one or multiple > + * page-table that are used in assembly code before BSS is zeroed. > * - DEFINE_PAGE_TABLE{,S} are used to define one or multiple > * page-tables to be used after BSS is zeroed (typically they are only u= sed > * in C). > */ > -#define DEFINE_BOOT_PAGE_TABLE(name) = \ > +#define DEFINE_BOOT_PAGE_TABLES(name, nr) = \ > lpae_t __aligned(PAGE_SIZE) __section(".data.page_aligned") = \ > - name[XEN_PT_LPAE_ENTRIES] > + name[XEN_PT_LPAE_ENTRIES * (nr)] > + > +#define DEFINE_BOOT_PAGE_TABLE(name) DEFINE_BOOT_PAGE_TABLES(name, 1) >=20 > #define DEFINE_PAGE_TABLES(name, nr) \ > lpae_t __aligned(PAGE_SIZE) name[XEN_PT_LPAE_ENTRIES * (nr)] > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c > index 0a3e1f3b64b6..fff6d7a4d37a 100644 > --- a/xen/arch/arm/mm.c > +++ b/xen/arch/arm/mm.c > @@ -53,8 +53,8 @@ mm_printk(const char *fmt, ...) {} > * to the CPUs own pagetables. > * > * These pagetables have a very simple structure. They include: > - * - 2MB worth of 4K mappings of xen at XEN_VIRT_START, boot_first and > - * boot_second are used to populate the tables down to boot_third > + * - XEN_VIRT_SIZE worth of L3 mappings of xen at XEN_VIRT_START, boot_= first > + * and boot_second are used to populate the tables down to boot_third > * which contains the actual mapping. > * - a 1:1 mapping of xen at its current physical address. This uses a > * section mapping at whichever of boot_{pgtable,first,second} > @@ -79,7 +79,7 @@ DEFINE_BOOT_PAGE_TABLE(boot_first_id); > DEFINE_BOOT_PAGE_TABLE(boot_second_id); > DEFINE_BOOT_PAGE_TABLE(boot_third_id); > DEFINE_BOOT_PAGE_TABLE(boot_second); > -DEFINE_BOOT_PAGE_TABLE(boot_third); > +DEFINE_BOOT_PAGE_TABLES(boot_third, XEN_NR_ENTRIES(2)); >=20 > /* Main runtime page tables */ >=20 > @@ -115,7 +115,7 @@ DEFINE_BOOT_PAGE_TABLE(xen_fixmap); > * Third level page table used to map Xen itself with the XN bit set > * as appropriate. > */ > -static DEFINE_PAGE_TABLE(xen_xenmap); > +static DEFINE_PAGE_TABLES(xen_xenmap, XEN_NR_ENTRIES(2)); >=20 > /* Non-boot CPUs use this to find the correct pagetables. */ > uint64_t init_ttbr; > @@ -518,15 +518,15 @@ void __init setup_pagetables(unsigned long boot_phy= s_offset) > p[0].pt.table =3D 1; > p[0].pt.xn =3D 0; >=20 > - /* Break up the Xen mapping into 4k pages and protect them separatel= y. */ > - for ( i =3D 0; i < XEN_PT_LPAE_ENTRIES; i++ ) > + /* Break up the Xen mapping into pages and protect them separately. = */ > + for ( i =3D 0; i < XEN_NR_ENTRIES(3); i++ ) > { > vaddr_t va =3D XEN_VIRT_START + (i << PAGE_SHIFT); >=20 > if ( !is_kernel(va) ) > break; > pte =3D pte_of_xenaddr(va); > - pte.pt.table =3D 1; /* 4k mappings always have this bit set */ > + pte.pt.table =3D 1; /* third level mappings always have this bit= set */ > if ( is_kernel_text(va) || is_kernel_inittext(va) ) > { > pte.pt.xn =3D 0; > @@ -539,10 +539,14 @@ void __init setup_pagetables(unsigned long boot_phy= s_offset) >=20 > /* Initialise xen second level entries ... */ > /* ... Xen's text etc */ > + for ( i =3D 0; i < XEN_NR_ENTRIES(2); i++ ) > + { > + vaddr_t va =3D XEN_VIRT_START + (i << XEN_PT_LEVEL_SHIFT(2)); >=20 > - pte =3D pte_of_xenaddr((vaddr_t)xen_xenmap); > - pte.pt.table =3D 1; > - xen_second[second_table_offset(XEN_VIRT_START)] =3D pte; > + pte =3D pte_of_xenaddr((vaddr_t)(xen_xenmap + i * XEN_PT_LPAE_EN= TRIES)); > + pte.pt.table =3D 1; > + xen_second[second_table_offset(va)] =3D pte; > + } >=20 > /* ... Fixmap */ > pte =3D pte_of_xenaddr((vaddr_t)xen_fixmap); > --=20 > 2.40.1 >=20 >=20 From xen-devel-bounces@lists.xenproject.org Tue Jul 04 14:25:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 14:25:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558407.872474 (Exim 4.92) (envelope-from ) id 1qGgxc-0002Ys-8b; Tue, 04 Jul 2023 14:24:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558407.872474; Tue, 04 Jul 2023 14:24:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGgxc-0002Yl-5v; Tue, 04 Jul 2023 14:24:56 +0000 Received: by outflank-mailman (input) for mailman id 558407; Tue, 04 Jul 2023 14:24:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGgxa-0002YX-TG for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 14:24:54 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on20608.outbound.protection.outlook.com [2a01:111:f400:fe13::608]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8ac9f626-1a76-11ee-b237-6b7b168915f2; Tue, 04 Jul 2023 16:24:53 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM9PR04MB8067.eurprd04.prod.outlook.com (2603:10a6:20b:3e5::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 14:24:51 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::9bd3:48c9:ff58:9880]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::9bd3:48c9:ff58:9880%4]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 14:24:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8ac9f626-1a76-11ee-b237-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l50cU5Bx04b/1Gu+l9ZnNbAo8ndlMOMVvE3c7UIqmm2ghsd43qCsTdrmGv5N8MiSqgeWUmuIA2lBqNCVIt9zqoWUqfhiUEsY+bMaTqmQi/sdFhUvv7jKc3JL9fNV1EOZpKFSd9e6AS2sxoNFKgBFNzmMhmxxShFFGfS20z2k26JBXbF7DybS4/c2T/pezjQZxYeqS6qVNHWcrHjzmw8fGFIGZLPjf/kfvyoTXNvT6sE9cXVfy3c6IrRhUTF+AWcDT3abkEG8PaBsqcbQYoY8sS6HZHnvpFFTsqx6H9ElBl9WKCloz9RlDZUtrYR6PY/DQZzl00F/PucNtbBFajptxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bfp/sOB1eMVA5o4DqiLd457KZuGKzZ1y3xs5SL2BAFo=; b=lKSM/fa+Sd1ibqpJgfSMER7W+8z0AR1PpS+hjQ9pFGf13cMsPfSOAxSH01KfgqcXOCsXdqQPxWXKslabVXFjNSJn0ArBOXn4aXkpv1h2Dz0Dlgg1rv1HtG9gnkir3rAh3ucgDpkfA9KpK5ZZQJnmZzijPeI/xRAnJQVyks7/Lnf3V7EWOKzAUrlWll3n6H8VXTmOPdGtnQpnHkNoedw/Rhj5tDgXQyXLSq++qRyJygo6tqRiWe63xZS/SsRPA4rTsdH+BFovTijv9Dkw4FkNY26ArTZmWdFmOvNlrKNoi4NXRX35pNyu6K5ZkFUh12icAuREvfpI/yLeAjw33j2ofQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bfp/sOB1eMVA5o4DqiLd457KZuGKzZ1y3xs5SL2BAFo=; b=2hgaSbgH719zx96cXoezPD05sPG1jakLJXBjJK0agBfR7IjHkt1zkoCJeCRBboHABccsU4GzocnbSOVeGAJ+LcYZWbGtg1pTMNLGia4iYpqd+C9Bx94kbtWtgx+qnnXKLE0A4ZvuS1W5cizJNfJ+BCk1br/5Og6TJJun8uYc3+o4rZhgSTk536JzO3myn2j0a3RgmSLKHZyN04mzlYlslYkVCi6ySKl5tGf6cmdyQOds6KB83s7D+TulSfB3Lp08yY64C39o6oWH7gJ82jGWRlg94i7m209usJixAExM02zI7HM2EEudmHEznqvqWB3mgI5XDz7vgxr2VMBv16dvYg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 4 Jul 2023 16:24:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [XEN PATCH v6] xen/include: avoid using a compiler extension for BUILD_BUG_ON_ZERO Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, andrew.cooper3@citrix.com, roger.pau@citrix.com, bertrand.marquis@arm.com, julien@xen.org, George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <0b0d9a5614daac653b3bfbcfaa29a9b4c11286bb.1687793572.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: <0b0d9a5614daac653b3bfbcfaa29a9b4c11286bb.1687793572.git.nicola.vetrini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0127.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::15) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM9PR04MB8067:EE_ X-MS-Office365-Filtering-Correlation-Id: 3335b553-235f-45d0-3179-08db7c9a6dec X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WqttBExMSPfvZibV3X18ivCeo5jMoMnNoBXTe70SFMDfQogrT/IuJIAMJgSRnmh2W0YoiNG7u0klfNzI2EDpYVBO73faBqJXnekeIYNhWvZMVVgTb44sWv9xm/p8hu0qa6UHZHKlG0meRmLNBPcZT3kVljAF71NZ0dwkZGNnMffnqBdnWDAle/6puutyPTZyrlYl9Pb4uJCS17D4pCN2P0UvovehbktKmhuCSRGVq1rrh3WPq+Kz5ow1naZwnPiK5hIJGkn/hWSyFRHWKBFrMi9aSYfBbUvLDvs9uVEj/TGUYUOOBNtHG+qeb+M5aJTSluk4EdEyHNef44wvMKtnDWsYiuL+/iHXkG6jf6LXXNp3P5LiuLChgFNpISEvvzRNXrYZ9rCyD2hjVYqOHWrVeavdJtqOvSixF+NeDDgkCS1p1xQZL3c1fe3T02z6N+qLu8feGEFL4a2mTxTuDP2pEkvYJgKmDAFZn6+A5lz/DahY4d1JpJrZ5/7YF/SXxKfxMq0MaQxT6SK3YKLKCVAsToSiWjbVzNrizAVyBbdzPhxWGY1GLRbkADDjS1T3dxhkSMZCQBnRNoxVh0ObUohQKtx969lf7cg44YILp3ZGpy/Aa//C1kmpkn7I76d/TLIAeapwjLCeTsVAClZnqDBslw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(346002)(396003)(376002)(366004)(39860400002)(451199021)(2906002)(41300700001)(5660300002)(7416002)(8936002)(8676002)(36756003)(86362001)(31696002)(6512007)(6486002)(478600001)(83380400001)(186003)(31686004)(53546011)(54906003)(2616005)(66476007)(26005)(66556008)(6916009)(4326008)(66946007)(6506007)(316002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TFUzd1Nod1hTREJBMktlNHJ6d1hYUGFONVpHVkZscm00bW4ybFJaRjRQWkdl?= =?utf-8?B?N1lDck1oamN5b3pMZTFKSk9udmtDRnFBOGF0dnFyWDNTNXVuQlVydHQwa2Vk?= =?utf-8?B?T295ZmgrS1BVVUpCa1Y4dTBUTHFvbENONHFvV21yMTFqQlM1ZDhpaHRqQTVv?= =?utf-8?B?aXZveEYxekQxRVYrcGwyVHE2dGZKOHNYQ2x0TWtPdDZKNUlPM1UvbHIzcHhn?= =?utf-8?B?K0grMFNOUDlhY2lMVTJ1emc0eThUSThaWEd0TW9Fd0hZRzV4TEpXTUZDU2Zz?= =?utf-8?B?VlVVcS9PMzM4S0cwYVdFQ1VSZ0d0cnB2TzkydWh2TzR2QURiOE9jbnY2eU9C?= =?utf-8?B?MnpsVTAwWi9nRHMxU2l5ZDhnZENXRlk4cHNQRitsMWpKUUNqazBlQVVxMjRE?= =?utf-8?B?Q01kalNLMmlreTlqRTRwaVhDYU9jQzdsaHZZblM4dmx4RHZWVDdpRlBtSzNl?= =?utf-8?B?ZThHaHFNdHpZbzNwZmoveEx2Y3NMUWUwR0FqYWIvdXA2anVRWW5mUDA2SnBK?= =?utf-8?B?S2RGYmY4T1MzUGxZQ1c4ODVkSjdzY1EwTFF4UnZNQldldVk0a1k3WkpZb2dL?= =?utf-8?B?VzFqc2p3VElld3JWWXR4Nit6QjkwaituSGhtU0VYUEdGSFYrdEJ6bTR1Rk5n?= =?utf-8?B?MHZlNEVqUm5nRmNoYUZ0M2hhdzF0TmJXbmJFeHVqZXdDc2lqUC9CbTFMU2xD?= =?utf-8?B?SDE2d3JBV0psa0lJRVR6UmR5aTQ4a2ZpaVdqMVl1ZnFxdTdPSDB3RVFNRVc0?= =?utf-8?B?VGNqeU94bU9Jd2ZIQkh4UFJQY1BVVUozcWs0djlQVWpzTmZOTkhMMU5DOEJX?= =?utf-8?B?NFh1R2g0WUJFM0tLamljYTVmN1dxNitVRUtISjZBdlFUVHkva0NqU2lkck5U?= =?utf-8?B?cE5Ud0drcjZxYlJYcTJFcElpbXQ1ZlFjSXF3QVpMQ1pTRDd5d1BXcWdIL2I2?= =?utf-8?B?K1FjUThQaHU5d2ZsUnlabUVyc1pZU3pqTHk4Ujc3TW12bEZmL2VDQWFNKy9U?= =?utf-8?B?ci9uS1BTcndhb1YvUklveEhBWlZwU05UaytvU1JydllnWFZOSEJpNTYyaE9x?= =?utf-8?B?NG0yc1NJeER6WXZMMC84VDB3SjZENTcxQkwvYW1EbG1kcnhzN0VFSFdsTnFl?= =?utf-8?B?bHk3a1lyRFpla09wTDRhWGo0UmpuTkZKSk52eExDZTRpbVEvRHZmOHdXL0FS?= =?utf-8?B?YW5aV3hMbk1raG1jRmdjVDlSakdwdzQvUzhDQS9ReVNzVEgrYXJtY1E2THNN?= =?utf-8?B?ekoxQ2ppTzNFNCtZR2dqaFNYMDZqTlVQZE9RaURCdHJTWnllMmRlbUg4TVZU?= =?utf-8?B?NzhyaWVtT05FbHgzTTVDUEpnOTJXMEsrZjNBazFtbjRlYXlKaFJhc2kvekNt?= =?utf-8?B?dUxXYW9ySXorYzZRTEFqUlFFNmxpQWZrdWZTWjFFZGU1Ykw3UTBlMEpxb1lm?= =?utf-8?B?WTg0ZFJ1SXVFSWduNTdFZ0liUXZnbXlqNHBFaXlSMWUyNS95c0Q2RHRTQWNL?= =?utf-8?B?NUwyQ0E2amRZT3ZYSWh2Y2lwVDkrRXQyV0lVVkh3d1kzdFlXbGQvcjJ1eWlu?= =?utf-8?B?dHhpUVpOZFFQMVNFQitVVStCYlNkR0QvVjUxZVpwTCtjQVAxOXlveS9WaHlG?= =?utf-8?B?cDNhSU1oWjJNVWZRU0N4TkRWTlVWa0ZLeFNKODdJU3ZXMTZmT3FBUVN1WHJE?= =?utf-8?B?bUgxK2lBbG1hREVwRFhzZndVSzNCakNDVWZnM25IK0ZVTG1MMm9waEI0cWtG?= =?utf-8?B?ZnJpbHV4UmltV2x1RlZDNUlCNitPc3l5WmNodnM3Nm5PU3FYWmhyNmVXZTl2?= =?utf-8?B?NE1zbkMvUGgyZ3VBUVB1bVdnWFFYa3pvYlA3VzhNZ3JuR1BFTHhHTVhzT3Z2?= =?utf-8?B?cVVVRklqVDRpQU55dmlrYkdYVVdOSWZWQXRWZzlUVTZKOHlVcDV1UkxSbzN2?= =?utf-8?B?T2RWS3RhRG8wTXM5UHVDeVhDS2NYdEYzR2FGZ1JCZnAxR3Q0cUR4bmhTdUVP?= =?utf-8?B?RUEwckc4b0EyWlF1VXJCb3M3eWs5QWljeHdKcFlHc2JTTUZNZllyQU9wVEpC?= =?utf-8?B?RWhsOGVGTklSbm5UemxHNmsrOWl1MmdCa3BTRDQ1czBYUFRKMlUvd0UrOVh2?= =?utf-8?Q?ps/DBWxmwDS3FWEb43W+Vj3zi?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3335b553-235f-45d0-3179-08db7c9a6dec X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 14:24:51.4947 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: weVR/5Co9X1teVguQ+Umfr2C1hLtiWC4+XmBOJKcfk1CoSgz+h4eb2o8Q5ZypxSItdiGNscrlCt4SP372K6oBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8067 On 26.06.2023 17:37, Nicola Vetrini wrote: > Redefine BUILD_BUG_ON_ZERO to avoid using a compiler extension > that gives an acceptable semantics to C99 undefined behavior 58 > ("A structure or union is defined as containing no named members > (6.7.2.1)"). > > The first definition includes an additional named field of type > char. > > The chosen ill-formed construct for the second definition is a struct > with a named bitfield of width 0 when the condition is true, > which prevents the UB without using the compiler extension while keeping > the semantic of the construct. > > The choice of the bitwise AND operation to bring the result to 0 > when cond is false boils down to possibly better portability. > > Signed-off-by: Nicola Vetrini The code change looks okay to me now, but I'd like to double check towards the testing you did with this change: While it is clear that you will have checked that the tree builds with the adjustments, I expect that would have been with a compiler supporting _Static_assert. Did you also check with an older compiler, using the alternative implementation? Plus did you also check both constructs for actually triggering when the supplied condition turns out to be true? Jan > --- a/xen/include/xen/lib.h > +++ b/xen/include/xen/lib.h > @@ -51,9 +51,10 @@ > e.g. in a structure initializer (or where-ever else comma expressions > aren't permitted). */ > #define BUILD_BUG_ON_ZERO(cond) \ > - sizeof(struct { _Static_assert(!(cond), "!(" #cond ")"); }) > + (sizeof(struct { char c; _Static_assert(!(cond), "!(" #cond ")"); }) & 0) > #else > -#define BUILD_BUG_ON_ZERO(cond) sizeof(struct { int:-!!(cond); }) > +#define BUILD_BUG_ON_ZERO(cond) \ > + (sizeof(struct { unsigned u : !(cond); }) & 0) > #define BUILD_BUG_ON(cond) ((void)BUILD_BUG_ON_ZERO(cond)) > #endif > From xen-devel-bounces@lists.xenproject.org Tue Jul 04 14:30:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 14:30:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558413.872484 (Exim 4.92) (envelope-from ) id 1qGh2U-0003J4-0o; Tue, 04 Jul 2023 14:29:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558413.872484; Tue, 04 Jul 2023 14:29:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGh2T-0003Ix-Tu; Tue, 04 Jul 2023 14:29:57 +0000 Received: by outflank-mailman (input) for mailman id 558413; Tue, 04 Jul 2023 14:29:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGh2S-0003Ir-Rd for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 14:29:56 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0620.outbound.protection.outlook.com [2a01:111:f400:fe0c::620]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3e3eb0ed-1a77-11ee-8611-37d641c3527e; Tue, 04 Jul 2023 16:29:54 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DU0PR04MB9299.eurprd04.prod.outlook.com (2603:10a6:10:356::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 14:29:53 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::9bd3:48c9:ff58:9880]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::9bd3:48c9:ff58:9880%4]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 14:29:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e3eb0ed-1a77-11ee-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nLORJO8KQhFzUMU6iyoUEt+duBdecNw6+ExxS1fylfUnoBqQB2ldQ3CD6PnEApRbuDUwT5rnlGsh2cBN7ujLivgaSksh9a4bWVVUkQGIU514n1F9bkMVC9EoWFVQdRCUYVbWtl8Ox3OX5LAdr1YlXlX9l+sanKlHFJPaIX64ku1qyBEDBTBjCO49zFl/Gw/jLhHq9+5AiX5AcZpdVXZdSXAeqW0vPZnvVZ/l7DcvAdDCL/4pltlCMEhEScLfuiRXwDOHyKf2Lulk1QxV7y/SkKyANEkpLnhh083R6GWY+gmmPfuEpGbBYLpFEQVYx5F1HKsKP3jK91Fiklsw6VQpgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qUo9VbqK1E0QofwcLeUuuaBC3c3sbvfQKGI0IvuYq8o=; b=Ipo7NSUySHIhs5FK0Av7vGAppBDsHSclIq8VSlEhf55YvC3TBiB7rAuYvFHcN5MKyCoITXUeo01nGro1IXeTa4RYeDa99ejaMZbsy+Ecv6WHxChOaBGF/FWyif3E3jg8IW5WuI/V7SeJohCJJk/PSskalZUHBQI6i6gg84it+s0IqkicFuzkQ/4VwLIy9O3di+sJ1QlEkpuPdNtR2BksdSEMFJWizrFFUCbh4+ttkrP/Pj5BMO68DNoiUpGIaNVCQi01ducFnh2VKQsWuMUSS8kGldLhAIwCUqZqjdu/M/f0TiNMQ0S/HRolJxVt+kDTmuwEs2BAMDWLs07SuxRurQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qUo9VbqK1E0QofwcLeUuuaBC3c3sbvfQKGI0IvuYq8o=; b=gCnhK+loOeY6iByxOiZCghwIYpmxSMcxvXarUAQ58TEML9MJKNVDCSbVVbmrhEXrdhU9C5OJOorecdVbLHtqaNWDGoTJUJeZUe5c3+iuG7hc/ESTltDyIDgP4wF7QR4O5KMvIIbA9YN9Kng8wZ6BfhRskLtvlfEfy8cRyKJTx8qjdqx84HvEYlPGyCMMVrtRZM1JqIQ3hgtrVrpyMlTdAyN23OdSxwf5TH10Qz+vADlZq/J/CadAgU06irkwAOYkdhbx7AV2C4gHgVnjnr90ml0CZvbTw5CYd3oS9ZDZiWZfCwW6L+C7rgbIkOsmJcTDZ6vwtPdm/iR9U848r4h59A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 4 Jul 2023 16:29:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] x86/asm: Introduce a tailcall pseduo-op Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230630152057.2944373-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230630152057.2944373-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0206.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::10) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DU0PR04MB9299:EE_ X-MS-Office365-Filtering-Correlation-Id: a92b2d95-9150-4494-faa5-08db7c9b21a4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Pg6Ej38RxcLjEQUbqMgOzF+NxhsOiUfn2zLGSGpZMNps2ENLcIJkM8bCepCbzDGbEzuMOCDMmP54t7h9hlKS436DjFFJqvLjt9sL8wz6t0LIwGH6H3ByjLwk2h1Cf5buZ20AVob45Kicn207dub1oh559jpgr8/Qgmeq2v+a17YS9Qjm16agRltu3w4JEHY3MOPncwZVSFBLrmogiTg/LVK8b2u01zGrcTdtCW615gGLOesWZ+gkbP8g0P8VGcn5fpodbKbWcXGAlDwapygdmIHarUZ2e5mLqk04/THYlKg3NZ+0PeEu60AjFTkuVyGNl/zGTKizZpqwe3dqKijFVlz3zMqcbtQcobWfTvjm4mLqJQpppSb4rRnjxyhZk3xIVCxpelGJ0g5ZkoqzB1kuOZ6+Lm31qnEhNcTX2UZCggwHWzxryTRRDVFZyyQN+BA8j6bRnInElRbBVLqEwW7MwaAaVC2vszkCxHpZZFdR+lNKnwm7jRPwYNG1WFndMLI2lnpuHmbDNCQt2LCSi5wfzPnvDDXHXXZftwvUmSuW+q3gj7lamhRCyASS88Hje5aGD1F10go9OcO3dXYyhDEP+9ShwdXK+zPiwdFodGF1uil3RBp0TeY84DmDqF3PKHoFT0YvFAwwpuPPdwNFKfhA/A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(376002)(346002)(396003)(136003)(366004)(451199021)(31696002)(41300700001)(86362001)(38100700002)(4744005)(6486002)(2616005)(186003)(6506007)(53546011)(26005)(6512007)(54906003)(2906002)(478600001)(36756003)(316002)(66476007)(6916009)(4326008)(66556008)(66946007)(8936002)(8676002)(31686004)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V0VXaDc2TkplajVRSHJwYlp4T2F3VUNzWnFkTWdyTnordkJrVk5oT2pJYW5V?= =?utf-8?B?aGtYeGpCWnUvSEVoSmIxYnRsdE9qZUhRcUw2MHF6bkpxUDVFUW9yRWxMRnBH?= =?utf-8?B?SFI0R2t2UVFXTHJwZ2VHallYZm9CUkdKNFFOVDlPbzVIaUV0dEFRRGJRdHpL?= =?utf-8?B?SnhoMWhJUkl6QUpLQTVMSDFCMm9KTlRlb2lPOFdZRFZqS0drRHVVaXZYV01v?= =?utf-8?B?TmwxSUpTWE9veFJZakV0enhBWWgzaTJHV3YzN3IvdnE4SWF6aUJyT0owd2Rn?= =?utf-8?B?b3RCZVQ3RzJRTnJ5dk5jSmdXYkVGKzlEM0hxM2wySEJHWUFFSnhxeFlPV2M1?= =?utf-8?B?T05mMEZpdTZPWWM1V1NVOEl4UGhGekszRk4zTkZYUnpKRUhqa3VtdmhkQnFH?= =?utf-8?B?bzd4TlRyN2dFTlhtYmd4YTE1NEFoUCtqZnlrbDBxc3dNOVRZQWhLSzducTYy?= =?utf-8?B?M1NsUk02UlVWRDBVNHg5MnN0ZW1Ccml4UjcybXhxMVFCTjA1SlFqZTM1NFVz?= =?utf-8?B?RHpmQnVVZ1Vvdjlydm5JRkNsMWdIQ25zM25jQ0Z4TlNESzZCNTRlS0ZuMndJ?= =?utf-8?B?NW14VHgyRHZ5TkdQMVdKTW9LSGZkSDdxbU5IOVREMERzaGtSeFlZTzBmaDcy?= =?utf-8?B?dVNNbVowYzVtaDdUQmpJK2dPOC9pdThwZER0amxrMkR6QUwzWkdoS1B1VmR0?= =?utf-8?B?cnFIeTBwM3BQZFZUQXRpeWl4NnNpeWNHY2NkZG1ON2k1azJSWmx4eS9qUXdM?= =?utf-8?B?VVY1b01JK1BoZjIwc1BDR2FBZmFySEludDlMZjk2ckZMMWo4L3dQamVMRXFW?= =?utf-8?B?ZHVLaFZrS1RIRGRkamllYVJBZDg3bE9oWm1zVm9ObmlMR0Y0c1dGTklleXp6?= =?utf-8?B?RUpvc3RnbnMvekpmMGRxRVpvTnBzWERsYmNVMDR2eFVTTjNXRmpJcEtKWWFj?= =?utf-8?B?N3BrVG44UGx6VG9NMkhRZVhtQmp1K1F0czVXbVRMQ3JiTjRNa3RGTFFsczVj?= =?utf-8?B?UlR4eTh5T0o0Rml0UGozNXZ2UmdRWC95UklyZlp1WEpVbUFYKzB0am5vL05G?= =?utf-8?B?K1FZRUZ1ZXZZbGx5T3NGekF5cXQ4WFo1U1FKaG9wUm96ay9YU0R2VFl3V1V6?= =?utf-8?B?c2xsa2kraUdmaHY5N0kyYmlnejE3RXorWGp6VnlNTDFDYlIxVTZMZ2RHazFh?= =?utf-8?B?RG1pbnlzZFRCS0htR3oxRisrZ3FPYWcvT1RPWE9ENlo4RXAyenM3cURJYU5L?= =?utf-8?B?QVRLU3d0RmlyQlMyeWtvQ3AxU0R1TmZ6SDNpUGlEa1l1a3I0SVZER0h6Qm1O?= =?utf-8?B?eXdlejByaDlwbENOODBKUGh4VGtXaHhOOTF3eTBtVDFNa2M5SEZwcmRsLy9l?= =?utf-8?B?MlJFV1B6SGVjaGhsSjdYR24xZ2xLb3NWUDZxOWhsREJMTGdSdmpuTkk3WGlN?= =?utf-8?B?ZkZXeEtBWWpPeFV0Umx5YUIwK1hkOFNBU293eGd4Y3RCOStOakFNemQwaTBX?= =?utf-8?B?cTg4VGhyWTFyRGlIbW9sK1FDdUJPOTFaMWtoazZReVM1MnFRQjhlMWh0aDRN?= =?utf-8?B?Nk80YVVxMVNZeURFSEVtY3FOaDBHUWo1UVk3VVNWMjN3dk9vZnNoV0Yyam4x?= =?utf-8?B?S2I0VkdTYThtZHlPOSs3eHhhelJYdDRJTmhZOEtEdmE2a1pLMHlrbnlWRUEv?= =?utf-8?B?bEFEbTZzaUltRE9EbHhzOE1TYkhlRTREcXZ5dndKOWF2dHA3akw2VE1PQWxO?= =?utf-8?B?YkNEM3lzRmZpVS9jblprU0RNVWdjYUpmcHhCMUtCTDl6OWpMdndUbW16cTlJ?= =?utf-8?B?bjZWTHNTa2U4MitZb3hNTTlabDRXcGZ2S3hqRU5CY1FBQ2xveWcwZm1ja0xi?= =?utf-8?B?YkQxMXg1UFFRbTkwMzlVVVJwTDBhWGFFdXB2UTdldkVyTmcxeGRQVUZxOVVU?= =?utf-8?B?bmtncUJ0bkNqNVlwOEJ3endHakF0Qjc1ckx6aG1zK0VUWkNvV3A5WDZkMWtt?= =?utf-8?B?SlJRazl3aDhHdHV4anoxV2pPSGwrcFMrV2xaTnBhaklVR0RaTGdnd215QjJW?= =?utf-8?B?T0FvMDlmRjY4MG5ZQlpPNjVuVjZId2lncFF1NUxVdDFvdzNpbVNFU3M4ZXN6?= =?utf-8?Q?5M106qqXZJapn1bSRY+m3avdp?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a92b2d95-9150-4494-faa5-08db7c9b21a4 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 14:29:53.0155 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8I1iGq/27FE3U4PtDMbH+EBs57VUZwGbqYAgEjsEvFsgOqEUD4KzyRxU37XiUkFiA27wyCUva4ifIyIZdZzcxQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9299 On 30.06.2023 17:20, Andrew Cooper wrote: > It was previously noted that CALL/BUG is a weird combination, but there is > good reason to use this pattern. > > Introduce an explicit tailcall macro make it clearer in context. > > No functional change. > > Reported-by: Jan Beulich Did I? Must have been a long time back, as I don't think I remember us talking about this. > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Wei Liu > > It would be nicer if tailcall was shorter, but that loses clarity. RISC-V has > 'tail' as an alias for 'b', but that looses the call aspect, and tcall isn't > sufficiently recognisable as tailcall IMO. I agree with all aspects you mention here. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 04 14:32:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 14:32:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558417.872494 (Exim 4.92) (envelope-from ) id 1qGh4o-0004hn-C8; Tue, 04 Jul 2023 14:32:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558417.872494; Tue, 04 Jul 2023 14:32:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGh4o-0004hg-9R; Tue, 04 Jul 2023 14:32:22 +0000 Received: by outflank-mailman (input) for mailman id 558417; Tue, 04 Jul 2023 14:32:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGh4n-0004hY-Pv for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 14:32:21 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on20630.outbound.protection.outlook.com [2a01:111:f400:fe16::630]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 94d4f2b7-1a77-11ee-8611-37d641c3527e; Tue, 04 Jul 2023 16:32:19 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB8095.eurprd04.prod.outlook.com (2603:10a6:102:1c6::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 14:32:16 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::9bd3:48c9:ff58:9880]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::9bd3:48c9:ff58:9880%4]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 14:32:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 94d4f2b7-1a77-11ee-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CSabIi0JxtP7hRvSFggeMB/TalYEP691ncwfDyN19F+aGw73NmRYwnZl+ueVA4sCZOHl+Wj05HrfywNTckCg0QZFxmJs+BBjYvjZF2GhHH8r57jz0U5O2a9c6OqYfQSZrN8KhlkhzFi7d5w+9zlfxjIfogK0i42Krmdtq+xXYoJiHGTJq8yHwdA0rlA39k0IbLeYlEDbR+ad6DlsXEcFcCC6eGaYDvaMpoGpit3FYGs6etLtf8q1uRnesmLThyxwgM3IMJNTT0Ja9fKnyHd+t6qYNIPKMMRKac8LUHBh7bXh14VrnnzYq0XIwKucgnXrE5LC/U9B30u3HY81oL5B0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gFGoua6aKvlEbN069IhmsjpuFn9TqK52MFlJOSz11Pk=; b=IoFGn1WVIwACyBKzJpsiRmFDKYe9FtLjEG0LgG7OOt0ZCiQkIOF2H4I8csugKoH9xvyeC/njgBoBPekTahaHlf9KWGtIOpQ8OeHx1386m+LzXCj/67B1BghiqJy3apBZ6lvt6dMmc89C5nHER2J75oKlBy6uDGGZjW1l1LfF9trSk0h8Z111PPQC/9VE5ABnP1zeb1O42ppmy5Mdm8WkR45LbNqmcMIe++whXoRvsuddmbYyin8anpbvOHh7duYIc73KLop0ScVRsMbymXhHdaLS9PrkJ6zPdp8+BFtnpkkUfts6iRYkJzuArnzgPfPItdPnYijeO8H2ZrCS8iRUJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gFGoua6aKvlEbN069IhmsjpuFn9TqK52MFlJOSz11Pk=; b=tRG8htXCldXYmEOR6fo3F0m4MnqcnWJD6V/ZmyPP1JAupjORLpWudbjanum0UmGyNhd9c/Z5wVf2gKmFCEdHLnychhtSEdBbgvwYibpTiLUsSwLjCc+51Qp5DGhrl3NDkf4R6QC+5kIYM7m1axOWOPavqcnrZBhQcsTdeTYnY7YIVum90ArrrBuSXUQmKh1GBdqr/fZ+3yxWQfKw2kYl56Jy6++ww81zcXJZL1Uc+7q19SV1mND5mmam5NnKLF7xa5aeo67gcR1DduJPOsjJCJWyvPEZa9SjC0BBFSK5SawzqYnaTS434fpuejC2tJmytF3IuC4N744Ff3Qq4f1MtQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4194337c-9c21-1a72-bb37-93aa3a0aac31@suse.com> Date: Tue, 4 Jul 2023 16:32:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 2/3] treewide: Avoid including asm/types.h Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Bob Eshleman , Alistair Francis , Connor Davis , Oleksii Kurochko , Shawn Anastasio , Timothy Pearson , Xen-devel References: <20230627075618.1180248-1-andrew.cooper3@citrix.com> <20230627075618.1180248-3-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230627075618.1180248-3-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FRYP281CA0001.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::11) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB8095:EE_ X-MS-Office365-Filtering-Correlation-Id: b6ce9ae3-fb0e-4327-d37c-08db7c9b771f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oMk2k2vzCob81zu9b3pLZpXLJv/JRe6Q2gXk0SXAHWj0/+5E5vvGvE5+2DpBsw70NcMo+a10M21lL/tyk2XuxyO72DqQmuO6I7ZRP6UmvnQbDv/HufViq3G9hSRjHF7RcJh68vrg8WbF2DD20Ao8Oh8QzuyzBi1tcOPBIwQu5i4iEZSKfGxIIrMzsdvbq7+0awC2mUsKDJSqo0qCCNNWXZdEjMsUO29edlcBmxPIPPPi/V1ld/qOWHyIbhRNUwNxCmJjNVRGlj+mESJgV3f5r1qeryghal6QjKBYJdPkN4CIu9NMaiZaUbgUkn0vlVTz8uXuR9dSbp4emc6MoBE2Vv7mPY0dWSUuunGI2eubAwy54Z13KZO6/pTx2cxuNM/nUUD8lhK4OKztOYcD+6F9macqV76OApOtlwP5LgTPApI2iRPVDiiSp6RM6P3AEiECqr9KxGCGV+MaHytMKbRQXTMw22KZ77uJ7pS+05M9RLJKPMYKHoesv3JfA0xLzH7mh45nVdHEEBIBP0O5Xl2aklQ1FYxIxZh1LgWROXT1OGPclBNaTu/u854/IKAPy2QRq084TYlQS4R0vKWvdhn/OFNTp4TyiAkBAMtiyf3LLiLQhe/NgsUyfYKa6ymo2BiOHbJ5lDQfu6wLHbB77NNdZw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(39860400002)(376002)(346002)(136003)(451199021)(316002)(41300700001)(6512007)(6486002)(26005)(53546011)(31686004)(6506007)(2616005)(186003)(478600001)(6666004)(54906003)(38100700002)(66556008)(66476007)(4326008)(6916009)(66946007)(5660300002)(7416002)(4744005)(86362001)(31696002)(36756003)(8936002)(2906002)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b0ZzaFJOcjdVdlk3WXVudXpZSFVhZTRaK3Qzd2ZXTmRuMXBoRU4rN2tQUzlW?= =?utf-8?B?TjlSNy9KRnJVYkIxRTZkVFYxQTBJQnVuSGp1YUxiUzdyaWJpNEVzdkE3ZEZT?= =?utf-8?B?UEtMSnQ3amZiOHlCdFB2UU5taU94T1A0S2dVYmJMTWwrejJkemduTDNieUVO?= =?utf-8?B?aHFGajJqZzdEVUpZTTZVWkJaMnpBQUJxVUxQOEY0ZER6MHZILzlEeEdWRnJZ?= =?utf-8?B?bzdjRnp3VklQNXBSbDQ2QXR1WjRyUEpTbVk2K2l4eGdKYkgvVmNqRzhPMmFp?= =?utf-8?B?TWZJaW44Y0JHUE8rN3JYazg1d28wYW92RHNxK0xWSlpyRnhncUpDRWRiOFJ0?= =?utf-8?B?V2JNZjcySEwrVDJrUTduSWRYYk1pNk9DN1F2MmRZdVpPbWFtazBUcU1VcFpu?= =?utf-8?B?TUVKYWJqeWgya3N2WVpuV256cVN0NEpFRXhKMFg5WXpqZDJqNVNaZGJMeVJZ?= =?utf-8?B?encxem05ZWNtUmpiY2svRTd6SktvWGYram81VWt4SzdUemtTeHl1VmUyMHVZ?= =?utf-8?B?WkExUjJ0NjJ5YUhOTm5iRWxtTmZKdW5GTWVJQ0JtVXRNMUxtWXFNV214U3lN?= =?utf-8?B?YUIxLzhQeXNRSFJGdjJMaHRMbEM3cVpXOWZYRDJkalErQmRnZ2prd0lCU2Nu?= =?utf-8?B?VDRXTVNGazIwak1pU2ZodHZoUXZwWGc1aFVCbkQrQlU1Zmc2T0tBZTRMTU5R?= =?utf-8?B?WXQvNVZacXU0b2Q1S3hQN0gxNFNTcDNwRnNvdDloSitNalErVE5kOXRlS3Uz?= =?utf-8?B?aDdRTnRQSHVST1R5cHdaQ091d0hhT0lPTHh4c2FrcmE3WTk1TkxXTDdLQ1p2?= =?utf-8?B?LzRhQ3Z6K3dJZXZpTVY0NEpmd05TekY0bnBNcEhPYmx0VE9USzMwNmpaQnFq?= =?utf-8?B?eFpDMmVWbFJ0amI3Rm9GcmZvZWVqNk16ZkhBenFzaFhiVVJMRXhZQk1jd29y?= =?utf-8?B?NDFNRjI3REcralUwOUhOS2YvT2VYLzRaNWd3WjRDQjJzZGc4akhMTW14Qm9D?= =?utf-8?B?QlFqOUNqQ3pEdDcyRjR0bmJ4MFpMMTJGYWprZmVYWk1QclF0NTdnLzRSc0dh?= =?utf-8?B?cEh0bTNIUVoyRGdkWlUwTStWSVhGQzNUdmJUZnI1N2xzbU5RT3E5VlBHMkZR?= =?utf-8?B?Yis2ZkJKYzJCMUxHb1psanZUY0VTSFhnbEsrYXJLSXI1TG1qbEVVa1NXajFh?= =?utf-8?B?L2pQOStQaU8zUnJRZExnTXZ6NkRkVFNlS1VzcVNHVFdsdjEyQ1JLem5PR3lh?= =?utf-8?B?U01STk9RS3lNRzFQNTR2c2FMU3lHQ0xIamVWcDI4aUdBYWZSMFJtRHpWM1U2?= =?utf-8?B?OXVadENNVkFTRHZxWFdQczhjOGsybTlMT0hDbGh3VVVnV0c3RkdqTERmd0M3?= =?utf-8?B?NmgrQlhLdUNuZjM4Z2xTQjBZVk9TVURmTURiYlRoV0NXMHB6VHM4dElZeFBq?= =?utf-8?B?UEE4RFU2KzA0ZjdralNLb1NOU1dmOVp2TTRnSk92TjVNTVdORDA0TlhDclZ4?= =?utf-8?B?NVorUGtJQktNejJJdFVkUlBmejVGYzlFbUVtc2VocEIxNWZjM28wSUxzcDUz?= =?utf-8?B?ejRlL1hRN25FNzhmbkhmZENNcUkxdUNFMGgvMWpGN2FkSUZKRjhKckZvUm90?= =?utf-8?B?RmlUT0lZb3pOSGo1N3hseXplTUdDSG9Va1VpdkxTV0lFT01yK0lKeWR2V2JN?= =?utf-8?B?SGRKa3d4OXpZM2sxUUxDaEU1TnJPQ2pqWklzblc2T3ZCTG5jd0d0V1JKRE9y?= =?utf-8?B?cHJLSDNURzBXWkxzeWtDcUpUbkpJVERoMTNsWmEwb2g5bzNDM3lBYWtGKzJp?= =?utf-8?B?SkQ5cTNzdjRmRHFLR3lYSDA5WXV2QkpRYnRFVVNEL3dCdDQyeW82RWhqb3VP?= =?utf-8?B?Y29XOXYvaDRFeTZqdjhQWWYzWGM0b2ZQdTdUS0NHV05HS2ROZXRhMHpXd2c3?= =?utf-8?B?aklRV2RiUllSNnd5TjQvMXMwTVZER3dhMnlLeFVldFdwTTRLWGpJbzNiL3N1?= =?utf-8?B?aE1QWEEvN3VOQzV5VC9tbnU5aklYaXBqdzB2c1kxZEFFZ281c1g5a3NvRzN6?= =?utf-8?B?aG8rd010MG1xVmN4V1F1TTRPNEdJcDJpclFSWHpNNjNHVlVBYWxOd0JZeVhG?= =?utf-8?Q?5uxSsQaItpRqmEPefTSQ6djGE?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b6ce9ae3-fb0e-4327-d37c-08db7c9b771f X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 14:32:16.4394 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4YjkDHDAYwDf94OSSibmM8mAK3dhllrwLi0fWTnYRVctNVYlqp4JwK13GNJfdI1OrGz+IJc9tuXMRCNQem21Lg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8095 On 27.06.2023 09:56, Andrew Cooper wrote: > We're about to rearrange the common and arch types.h split. While most > users already include , a few do not and some files fail to > compile as a result. > > Almost all logic is going to have types very early in the include chain. Drop > the include entirely from C files, and swap to the common types.h in headers. > > No functional change. > > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue Jul 04 14:35:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 14:35:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558421.872504 (Exim 4.92) (envelope-from ) id 1qGh80-0005JT-Rh; Tue, 04 Jul 2023 14:35:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558421.872504; Tue, 04 Jul 2023 14:35:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGh80-0005JM-OH; Tue, 04 Jul 2023 14:35:40 +0000 Received: by outflank-mailman (input) for mailman id 558421; Tue, 04 Jul 2023 14:35:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGh7z-0005JF-DF for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 14:35:39 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0604.outbound.protection.outlook.com [2a01:111:f400:fe02::604]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0b0b32e9-1a78-11ee-b237-6b7b168915f2; Tue, 04 Jul 2023 16:35:38 +0200 (CEST) Received: from DU2PR04CA0188.eurprd04.prod.outlook.com (2603:10a6:10:28d::13) by DB8PR08MB5354.eurprd08.prod.outlook.com (2603:10a6:10:114::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 14:35:31 +0000 Received: from DBAEUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28d:cafe::bb) by DU2PR04CA0188.outlook.office365.com (2603:10a6:10:28d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.31 via Frontend Transport; Tue, 4 Jul 2023 14:35:31 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT030.mail.protection.outlook.com (100.127.142.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.18 via Frontend Transport; Tue, 4 Jul 2023 14:35:31 +0000 Received: ("Tessian outbound e2424c13b707:v142"); Tue, 04 Jul 2023 14:35:31 +0000 Received: from 168dc085fa6f.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D9F33600-BDBD-4DC7-AF68-52DBD044B484.1; Tue, 04 Jul 2023 14:35:19 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 168dc085fa6f.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 04 Jul 2023 14:35:19 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by GV1PR08MB8237.eurprd08.prod.outlook.com (2603:10a6:150:5d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 14:35:16 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::5e17:39a6:eec7:c482]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::5e17:39a6:eec7:c482%4]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 14:35:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0b0b32e9-1a78-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K+rZJlQ1eC64c5Kq4Za0wz2FbOXczQGH8R/vTXItowE=; b=GKzTp23tT0MeMfOovpic2ejI7wFQiV1IGrPf2wBpE2dpLFsQ5Vks2yGoiEE1y+BMOomT0TmPEAnxbjjwG9zJMMP/NbzxJZVESMnpFfLfJAUlTMlkzC0CXWr4VytnTzy1UwvFRswqqfYLcQVOGoKLr9jJ42o/EJa24ttALUXTuPc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: a9dc3cd63b91531d X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LiHJFWjoU5D7777zsFdh4woyjFaqO6Xk8Ut1phuBYKXejExyteshgG0UFCyctKdo0cFM2TuWqJgC1FrKV9BjEcwcUp9qn591jY5Li8fYk2DwkUK9U7dChsDnEmutJQ9n17EXKMv5OYFNFw7qEt3nArOzJNiYT342at9wYXf28WXPS9C2q8E0KOKxf6zh6Qoc1fRxGTE3GjZJ9QC461l9hrFlMHkunbjRppfPST00YwVbG3dtBi742Uh2jXrsrpSeWEsD01CP/YizmD0cTU6eJZqDkf5jb4aZtBMDNjJdZfiF+9oa3+yCzi6Lb2ktD79hntkRSYvooAWK4EG6ZKdw7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K+rZJlQ1eC64c5Kq4Za0wz2FbOXczQGH8R/vTXItowE=; b=YmbUzQOcaBnrO6MtF1pbM/lqlcYBS2GhN7tB+NKasTt5duAcSw952btUq8vETlX9chxvh8lIrHngWVjnSzmYK69vGPuWc/MYukuI3CbF3vz2cjy7bmnrPCFjVJxp79p4it0WiMKVu0cJGuKo4XyqXAX0i6Ff46jLqaQZhuUt4DP9x+GdqkHmwyiBwtavdUVs2ZeKZeGC4ywr+O8CTeBh7SSqcmDLQN8VOx4Z4d9L5MRzm7OS14d+Pj448E47PZJnLikzBCyr4+2DDfypRboD/Dvq9ywbRrn56mxhdhyznxp+0cWz9rnGMpNJcdKDe+/dt0TMEJWlvVZZDbiIcpOHJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K+rZJlQ1eC64c5Kq4Za0wz2FbOXczQGH8R/vTXItowE=; b=GKzTp23tT0MeMfOovpic2ejI7wFQiV1IGrPf2wBpE2dpLFsQ5Vks2yGoiEE1y+BMOomT0TmPEAnxbjjwG9zJMMP/NbzxJZVESMnpFfLfJAUlTMlkzC0CXWr4VytnTzy1UwvFRswqqfYLcQVOGoKLr9jJ42o/EJa24ttALUXTuPc= From: Bertrand Marquis To: Julien Grall CC: Xen-devel , Luca Fancellu , "michal.orzel@amd.com" , Henry Wang , Julien Grall , "federico.serafini@bugseng.com" Subject: Re: [PATCH] xen/arm: grant-table: Correct the prototype of the arch helpers Thread-Topic: [PATCH] xen/arm: grant-table: Correct the prototype of the arch helpers Thread-Index: AQHZqs0B2zzuMPxesEq0PvPe7uOM1q+ps9kA Date: Tue, 4 Jul 2023 14:35:16 +0000 Message-ID: References: <20230629210150.69525-1-julien@xen.org> In-Reply-To: <20230629210150.69525-1-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.600.7) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|GV1PR08MB8237:EE_|DBAEUR03FT030:EE_|DB8PR08MB5354:EE_ X-MS-Office365-Filtering-Correlation-Id: 0abe300b-2588-4ec1-dbb5-08db7c9beb42 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: HtaIxZGEC+7II/iIThVIuQCgfEMckEvA9BGYjIbuivv459s7J3/R6f4mRutpbHfBbSSJjFrs+XvxOTL8qjdJ8EEvwjob8+/mZjs/LO9vCOd3/NK5bADrchOKBa+AaS6JIsvNi4WJ47c9hE129rpT9cxMMYbDWEeZmsyI0SzP18UDXeMz023YKxNNMWeWxD2SAPTbZ3H1Gm0Gsk4WFVYcENEH7qkJrXExxxEwlzTkW43wQZhnpuTm+Ooq9UYNksMxy4KMDOiQNIsPDpI86oqySzG/0z2nWau587VNfAaFEPzMNlsi/+qATAMbpZSbUuUYMvG9Z1SUGSjOE8VcitDC7dENlKq0+g24bMkEGXvXqD6DtU/6JbwB5WX15++tPLuIDu+FjcyLW2HCkVuj37Z1OqyrtZCs+AuaHvpyhgALVhfGQHQc0wdP6d9GJIHyCNuDEzG9daYCQpYcnigV6sQE8tSnAa5ybLmWQce4KC0VqrvMQrbiv+Q+4RV5mcjiNT+dZfSo7oeXTDWPbT1l7EvIOdMtVMXjsQQFlvsSL9VHovrkLrqGw3RAI9LpNMur15yxhWjKlLc0LN/LVN//tPPe9R08P0PXpnZBiMm0iABsGEb6Yhc9bhgy2ZydlXhwGSmmuuw1nnXyKkLIlaDCaeHg9Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(136003)(39860400002)(396003)(366004)(451199021)(478600001)(71200400001)(6512007)(6506007)(86362001)(2616005)(186003)(53546011)(38100700002)(54906003)(66476007)(64756008)(6916009)(66556008)(4326008)(66946007)(66446008)(83380400001)(91956017)(76116006)(6486002)(316002)(122000001)(8676002)(8936002)(38070700005)(41300700001)(2906002)(5660300002)(33656002)(36756003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <3319E8BA585A3F4A8DC57110E7B9EE0D@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8237 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 42c3eb7d-cf38-4296-e288-08db7c9be295 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o8/7ZzrB7Q010kYpZm/vqto8AztIQ5kqp1lULcX9pSRLTf+Z5dmYrwpRjsgJbcV6zMeNkOHSXobmyEoivz2IbyfV34PnZHa2PyTbgvNnB+HglqwoVxb8A+hKDHytsr35TWay68dqTwtzB0qsK1gcWbClOXGfcZRECxNEP06H4QR8aS5Tih2BtG1pXIyIfpjQcF5hJMKoC52Or0bNvlGztqpzA82GGwCLPN5cdNIjsSzEz1jq6A41unzZqKDEPjz/A0c914+aLGm7IrREBPpXX7Ix5HMl+jaPuVg6O5U2lSluAisvi3sWFbsfAdpgUUDl1mRJIAfhyKQWMLkuSoDRQMc5qmIesc0F4jxP6l7qchYFZrAqwY1+SKKd6bMTyfFJfv+5mt4N8UxLR0bfw3MFkRL68bccRe4lQdj9bClASN5S7OsyDeJl4gOONkqDr7xnBLigSBO7Cin55a9l6L9n+cVI9UjSgVVfAXs9bP5KLsytfRnx69Bv5/uulTg/VF1SnX7RCiBWrF5IC8NBU1rmgGAyDdC2KxhH6Y2QAxCDurrySD1EXBC81gR0IUsWh+8JdcC8vuBjlRcMpaQyWkPldzsPkcX1HGmUZd8x8gL4bA/xPtnuBOAR1DKqCcMn9Pv4KbtW9lqUbtGCsHvHCvxPnZZO4Fpu6oyC9WMdGmKQAclatZfoODP+GnZCkt0sIIMAi+RhQqGraC+t2TqvUMes6QkbOae72dzhcbzko8kM172ladQBplkl25uzxPFOgXi5 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(346002)(376002)(136003)(451199021)(46966006)(40470700004)(36840700001)(40460700003)(2906002)(41300700001)(6862004)(5660300002)(8676002)(8936002)(82310400005)(33656002)(36756003)(40480700001)(86362001)(186003)(2616005)(478600001)(26005)(6512007)(6506007)(82740400003)(6486002)(70206006)(47076005)(316002)(70586007)(4326008)(36860700001)(107886003)(53546011)(81166007)(54906003)(336012)(83380400001)(356005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 14:35:31.1859 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0abe300b-2588-4ec1-dbb5-08db7c9beb42 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5354 Hi Julien, > On 29 Jun 2023, at 23:01, Julien Grall wrote: >=20 > From: Julien Grall >=20 > Both the stub and the x86 prototypes for replace_grant_host_mapping() > and create_grant_host_mapping() will define the first parameter (and > third for the former) as uint64_t. Yet Arm will define it as > 'unsigned long'. >=20 > While there are no differences for 64-bit, for 32-bit it means > that the address should be truncated as 32-bit guest could support > up to 40-bit addresses. >=20 > So replace 'unsigned long' with 'uint64_t' for the first parameter > (and third parameter for replace_grant_host_mapping()). >=20 > Signed-off-by: Julien Grall Reviewed-by: Bertrand Marquis Cheers Bertrand > --- >=20 > Cc: federico.serafini@bugseng.com > --- > xen/arch/arm/include/asm/grant_table.h | 6 +++--- > xen/arch/arm/mm.c | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/xen/arch/arm/include/asm/grant_table.h b/xen/arch/arm/includ= e/asm/grant_table.h > index f2d115b97d8b..d3c518a926b9 100644 > --- a/xen/arch/arm/include/asm/grant_table.h > +++ b/xen/arch/arm/include/asm/grant_table.h > @@ -36,10 +36,10 @@ static inline bool gnttab_release_host_mappings(const= struct domain *d) > return true; > } >=20 > -int create_grant_host_mapping(unsigned long gpaddr, mfn_t frame, > +int create_grant_host_mapping(uint64_t gpaddr, mfn_t frame, > unsigned int flags, unsigned int cache_flag= s); > -int replace_grant_host_mapping(unsigned long gpaddr, mfn_t frame, > - unsigned long new_gpaddr, unsigned int fl= ags); > +int replace_grant_host_mapping(uint64_t gpaddr, mfn_t frame, > + uint64_t new_gpaddr, unsigned int flags); >=20 > /* > * The region used by Xen on the memory will never be mapped in DOM0 > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c > index 0a3e1f3b64b6..53773368d036 100644 > --- a/xen/arch/arm/mm.c > +++ b/xen/arch/arm/mm.c > @@ -1579,7 +1579,7 @@ void put_page_type(struct page_info *page) > return; > } >=20 > -int create_grant_host_mapping(unsigned long gpaddr, mfn_t frame, > +int create_grant_host_mapping(uint64_t gpaddr, mfn_t frame, > unsigned int flags, unsigned int cache_flag= s) > { > int rc; > @@ -1600,8 +1600,8 @@ int create_grant_host_mapping(unsigned long gpaddr,= mfn_t frame, > return GNTST_okay; > } >=20 > -int replace_grant_host_mapping(unsigned long gpaddr, mfn_t frame, > - unsigned long new_gpaddr, unsigned int fl= ags) > +int replace_grant_host_mapping(uint64_t gpaddr, mfn_t frame, > + uint64_t new_gpaddr, unsigned int flags) > { > gfn_t gfn =3D gaddr_to_gfn(gpaddr); > struct domain *d =3D current->domain; > --=20 > 2.40.1 >=20 >=20 From xen-devel-bounces@lists.xenproject.org Tue Jul 04 14:38:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 14:38:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558427.872515 (Exim 4.92) (envelope-from ) id 1qGhAu-0005wH-E6; Tue, 04 Jul 2023 14:38:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558427.872515; Tue, 04 Jul 2023 14:38:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGhAu-0005wA-8h; Tue, 04 Jul 2023 14:38:40 +0000 Received: by outflank-mailman (input) for mailman id 558427; Tue, 04 Jul 2023 14:38:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGhAt-0005w0-Am for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 14:38:39 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20608.outbound.protection.outlook.com [2a01:111:f400:7e1b::608]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7676027a-1a78-11ee-b237-6b7b168915f2; Tue, 04 Jul 2023 16:38:38 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS8PR04MB8136.eurprd04.prod.outlook.com (2603:10a6:20b:3f7::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 14:38:36 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::9bd3:48c9:ff58:9880]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::9bd3:48c9:ff58:9880%4]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 14:38:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7676027a-1a78-11ee-b237-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gi8KVF04OZO9TAcimykRTgGSb1XdqstfXsNZeN2w/ZhdN84RjD4n/UBDO5yG4nRgpd2rWnEwBUGstJBVKgdd+zKIfaHHqEnP7tyZRUhfL5LhmltJUdxZTlyroe0rVHGc3cvgTMx7R2yQJGXEoQ/6+MC+6MCGcL6TXtIPCbt4ERSYR2DjB4cExkChWOsnXYwtaYkYOtZqxmPUyQAYXQVqzv7wqw/kZNmbNKvGBWF890osvZpj8f1aXxutiDunjXQdPrj6Ch9EMrMraoEKPdfDIjuKQyGXoXEUG7voK4tWPjJHqtKLWV/JDDhE4ED1TfiV+7IxUe2fAlyk3Uxxj6V8WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MuNhuMAqFMs1w6BxdSHXBrN+n65LvlYXXmD1XSEsnTA=; b=HVyjcapa7uK3PhrFUZfxTqOcv6igAfIeQdzQ+T5CzK/qVAlD28IHGNLSopgQLDcprlVTWXk2hv/ooG097wrXm9fN1qrkNmCbFTSwdHtHz1lsoDCpy1EGKks05Sr5U/gzhdiUrK9/e8gDBkNs/13/ZEMIG6oW+jCyM3WSwutXXdTxwkq93oYYF6CfICTrDwumHVpqE0vXWZp4fXVIgSeJrbNREplowwkTS6stsqaa+gZev+8Qzf/VY8po58a/E9c9gtVCAmv/K9aS/vg8KLu/AGRxeLOIkKdh1y1NTlcsXW5pjtP/j2iH89z/JHDfRvLFxC4H6BPDhxCIzDcYmHiQ3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MuNhuMAqFMs1w6BxdSHXBrN+n65LvlYXXmD1XSEsnTA=; b=yoGZd9G36JzGuPZSm/OEDBSMYlcx6ECcPBAo1HlcmxpDD9JflaDw7ENH/QSPKbTMcRQPO/bVL3vL1q90eZ2NbPv+GE/TU4yNIt+wzEYBYShn2V5bZTYLYngHlg9DPwUvIDnUMJb/S/Dzl+/QzKIIYb7LB9OkoxzYD30dFL0JsmHpG2QQiys8aqHNdRz85Qw+s6Yd8AJHwIb8MPMF628LUpR4+Ang93gRNiMxneQLC/3XIKujkJHarOk0DB4lclE5Tqq5zG90nyzOe66Z5L+TExIiF4NAz1P9PYxvpwhoKip4sM2XtOAUT8M0uSvkN5Rwca0MNlCWfTYUGOz2QT3FDw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 4 Jul 2023 16:38:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2.5 3/3] xen/types: Rework stdint vs __{u,s}$N types Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Bob Eshleman , Alistair Francis , Connor Davis , Oleksii Kurochko , Shawn Anastasio , Timothy Pearson , Roberto Bagnara , Xen-devel References: <20230627075618.1180248-4-andrew.cooper3@citrix.com> <20230628145403.3630-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230628145403.3630-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0138.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::7) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS8PR04MB8136:EE_ X-MS-Office365-Filtering-Correlation-Id: 0d5e8731-c181-4e5a-40dd-08db7c9c59bd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VgWVImoYrfpryuJGuUmCRBTu1rhQYuL9lyJA1xouNAY52AMftRfeLz5UdKS4hjbMb49lMgwAKbDqtgXy465G4SC7un48skZxtJsYWckc7jCGLQ16UCCMF5Ta9QsmlESkt8Q3Qp3dCr7TfoV4guWqkD9K/6wg/xNZmDrqcyxdLd3FCxMcAuoGZmv/dSXykrq650vruxkEtp5wh4w0c8LvvF/pYPWUsOBj7U2x65xq0SnZtgHkqvBC+6EyrA6JBq+UP9qofb1ZtBX/qnpzFsgWqjvJg0LOV9B8hOoL5sZrBEO4UlM2NGy6OpP9VXVC5i9m0Ww61Jh8SdnsyLeZZ4C5qPRtFsrEau7mFBCrR9IVGJc3oEe7EZnRV4nqrxtEAaG6iaxISNNk4t0sNa8od1Mw/FK4epaT6uM02fZgPC0mlE/UAj2tqw3CmLB19xodL3ri1lqGQrbjvYL11z/w5eP2Bp0+dB1NYsGjAldIBmhCxyC7pMxAsv2M5je7cxSblqb3KBfkhbJVeSgzYkIvVZwCy8p7EKev7t7i0wieVouPDdj8MriMamxiIEac0TTFwpcWVqe04TC7WlNEVDiJG3UolyGRwlyq94eocV95+BVXalhDQHX+BoSlPr+JplqySl7klZYCaHkk3yBEnqvOiJwSwg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(346002)(39860400002)(396003)(136003)(376002)(451199021)(316002)(8936002)(83380400001)(8676002)(54906003)(38100700002)(41300700001)(66556008)(4326008)(6916009)(66946007)(66476007)(36756003)(966005)(26005)(186003)(6512007)(7416002)(86362001)(6486002)(31696002)(5660300002)(478600001)(6506007)(2906002)(53546011)(31686004)(2616005)(6666004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NzZ5eStGQlVXU2hLdnFtOHdmL3JtKzE3RklMZmVQRFoyNk9pcGxuVDNybTRo?= =?utf-8?B?WTl3eDUrS2pwUkFFQ3BHV3ZvbzYvbmRKRnVwV2w4VGJTVlVmYmlDcWFpOXlx?= =?utf-8?B?Ykc3bWdMMmFWOCtLeUxESUdHbVI3bUJ4NGpKUG9Va3dBSlhlcW1Fbkw5NVNJ?= =?utf-8?B?QVdsY0xFUDh5TGNocFVUTHhGOHZPUkN6YzFpZFFhWmdBdjV6c1hNNitiNDE5?= =?utf-8?B?eHNKNGZPVXkvRUZDT2VQTHdiVGpnUGhUSlpWZUhzWDlObFkzdlV5ZllxaE8z?= =?utf-8?B?QkNQTUZlNkFvczFITjBWdU1BTTdUT1V2RTRsSWdVVXlRa09QbVNCY2JjVkhy?= =?utf-8?B?WjNwS2hkN1Q5R09tZi83ZzBtTGRTcGdaNmFFS1RHSm1hVWlkQXVjY3hMYW9k?= =?utf-8?B?V1dKUm9vQzg5K2NSQlRqd2lHblJuL2ZuWTlSRlVjZHlKMURMMUEzcEZDNE1H?= =?utf-8?B?MlVHMFRDdEZob2dLdHRBaGduQnBoQ3Qrbi8xT29PM0Nrb254Ri94RWJRYXNw?= =?utf-8?B?L0hmR3M4bXE4ajlvUG05NXRsbXVMN2RDMTJUZVZVOUhQdU8ySzlkRUMxUW5M?= =?utf-8?B?WUQ1UndDMmx6ek1PM2R4OW9ITHVKekhqb3U5UTMveWxtcCsyb3BycUcrcmRm?= =?utf-8?B?anVQajVlL1NrV1JjSERGcllUQ3lhR3YwTktrekhSTkhpUWpJTmkya0xNcEpF?= =?utf-8?B?UDE3TUp2dUlSc29LQ1RRZ3RTY2VURE04K1R0aW1GRTBYenptK08wZDBkS01T?= =?utf-8?B?Q040UXRNSHFheHBLZG54cFdRMWJUbkF5UFNXRjVhSWw2NjVtN1Y4aFZRb1Y0?= =?utf-8?B?RmNBaktBbVpBcFdlUUFXNmpZVzA1SmY2R1hlR0pFSHMybTU2RXBNWDQ2WGVm?= =?utf-8?B?REZ6cU5KQWs1dUFiRVZqU0JxMnE2RDQwbW9jN05Nb25Td3V5eHdOZmJQenBi?= =?utf-8?B?M3haR2Q2V1kzZXkyc3dKbUVNV05ieDVqVlhYWUxyQjZncWJwZGdQUDZ0M21W?= =?utf-8?B?d2I0QlViOTlERzFKMTFZeXFqekVmM2dlQmN4ZVpyZTJUTUNSc2NhNWJVMmFJ?= =?utf-8?B?RE8wVDF0WFV1R3lJaEFTWWtwdHhud0QrWW9IMTdOWWxTVU56RnZGR2tvNU5H?= =?utf-8?B?aHFrdU5uWDZ4Q2F6Sk9wdWdhSS9PcnEydUUxZkp6c3J3dHNseTBNbGFUSEJz?= =?utf-8?B?aUc3cC9sMkR0Y0paQ2Z2MUNZcnBGTXpYK1E4bGRramlESzlDVDNSc2lBKzNh?= =?utf-8?B?ZzNGbVkrUEhraWptVVBuQ285d0F0N3d4Tmt6S0U3MUtod3JnOWd0T01uUkpy?= =?utf-8?B?T1M1UGo1VWFzbUYvbmxaUnh0RTlOV1kweFh5RkQ0WEVBZ1BsdGpSTVpkaHNa?= =?utf-8?B?NUFJeW9SOGwzNEtYYnI4OVZqdk1nOWJvN3lNVDZXNDg3NUJHQzZ2Y01FQmdn?= =?utf-8?B?UnNKNy9TbG9VaTZ5VVhPY3BKN2liVFlTRk5UOUI5WGhOOUVGbnREVVJXWU9S?= =?utf-8?B?NVIrcVBSeVJEQithdEtZUlB5UDBSTk9IelRWUlNIeVBVVzE2RmFpYWFKbm05?= =?utf-8?B?VG0wZ0hoQVQ3aTR2ZFdERUY3a2lXVWdFMlduVEhZU1diQm9DbzFBNFYzT3Z5?= =?utf-8?B?d1RrN3JseUxMellHQllEYXFac2xhbEdxSGQyZ2gzU0lOWlRDMG82dng2UjVz?= =?utf-8?B?V3htTzNUeVpiWmxTblNZT3pKVmI3bWdwbkw5NFd0aWJMc3dUODIyU21GcXp1?= =?utf-8?B?Qi9Sbms2VEZVV0p1ZnhqWTIyS3FGZEJ3MG9qUE9mWjlIRnFodEJnSVhtRlNF?= =?utf-8?B?NHBTR1BSNmlEVjRRWDVHUzdzNEhFMFRNc1FtTm4yOVFPRGlSOXlIcTViUW5U?= =?utf-8?B?SXpheC90eVllRk9oYlZkM0pvTXdaMFIzYklwTVdqQXRvWUVlWStyMFJ1OS8x?= =?utf-8?B?ZXQxSjBFUG5OQ3V6ZE4rSG1kVWNpQTB3eHdhQzA0SE00T1VZbXNTRXVidjRU?= =?utf-8?B?RnJkb1NaVk1TMkY4ZHNWTlJmKzNoSkdWQzdLQmNoR0c1NjliSzduUTZvKzdk?= =?utf-8?B?TmhycjA3UVUrM20zOFlhU2FGUjBoanhrYVlUVTB5Y1JyR0xSNEZaam1ZMHd2?= =?utf-8?Q?OYW2wSX8kNg64uZeDFxW0IxCI?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0d5e8731-c181-4e5a-40dd-08db7c9c59bd X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 14:38:36.6149 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bmiH54OYEezYoKJTu5JCUKL8whwsZNC0BeC52dCwZ+yk3U4mwFAZSD/N34+CzIhcidMs5f12JiDvrJwFd5py4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8136 On 28.06.2023 16:54, Andrew Cooper wrote: > Xen uses the stdint types. Rearrange the types headers to define the > compatibility __{u,s}$N types in terms of the stdint types, not the other way > around. > > All supported compilers on architectures other than x86 support the stdint > __*_TYPE__ macros. Move these into a new xen/stdint.h to avoid them being > duplicated in each architecture. For the very old x86 compilers, synthesize > suitable types using GCC internals. > > This cleanup has the side effect of removing all use of the undocumented > __signed__ GCC keyword. This is a vestigial remnant of `gcc -traditional` > mode for dialetcs of C prior to the introduction of the signed keyword. > > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich with one further remark: > --- /dev/null > +++ b/xen/include/xen/stdint.h > @@ -0,0 +1,33 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +#ifndef __XEN_STDINT_H__ > +#define __XEN_STDINT_H__ > + > +#ifndef __INT8_TYPE__ /* GCC <= 4.4 */ > + > +/* > + * Define the types using GCC internal notation. Clang understands this too. > + * https://gcc.gnu.org/onlinedocs/gcc/Common-Variable-Attributes.html > + */ > +typedef signed __attribute__((__mode__(QI))) int8_t; > +typedef unsigned __attribute__((__mode__(QI))) uint8_t; > +typedef signed __attribute__((__mode__(HI))) int16_t; > +typedef unsigned __attribute__((__mode__(HI))) uint16_t; > +typedef signed __attribute__((__mode__(SI))) int32_t; > +typedef unsigned __attribute__((__mode__(SI))) uint32_t; > +typedef signed __attribute__((__mode__(DI))) int64_t; > +typedef unsigned __attribute__((__mode__(DI))) uint64_t; Much like you avoid "mode" potentially being the name of a visible macro, the mode identifiers themselves could in principle be, too. Being upper case names, perhaps there the risk is even slightly higher. Hence I'd prefer if you/we could use __QI__ and alike. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 04 14:39:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 14:39:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558431.872523 (Exim 4.92) (envelope-from ) id 1qGhBf-0006SP-Ky; Tue, 04 Jul 2023 14:39:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558431.872523; Tue, 04 Jul 2023 14:39:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGhBf-0006SI-IQ; Tue, 04 Jul 2023 14:39:27 +0000 Received: by outflank-mailman (input) for mailman id 558431; Tue, 04 Jul 2023 14:39:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGhBe-0006S0-6y; Tue, 04 Jul 2023 14:39:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGhBe-0001pS-0r; Tue, 04 Jul 2023 14:39:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGhBd-00036p-IY; Tue, 04 Jul 2023 14:39:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qGhBd-0007xe-Hg; Tue, 04 Jul 2023 14:39:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jVv2++cePzNrhDTGex7YR+p5YW53+51H0vUOpRhgdOI=; b=r8F1qNt9O2jQRNp248e59fd87B tNkM2luM8UZVXrcD/rc43ZWED6HO185MAkYvCsE1APuwQP/8D2S187njqJXJflCy1sEdst2Xrfxc6 4WZVoYCH416JCLxiyryWzuqET1zzXGPVkmb6RG7zZ3llwGgyLrUTQ9Z1F9zbkSU1jgnI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 181690: regressions - trouble: broken/fail/pass X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-vhd::broken:regression linux-linus:test-amd64-amd64-xl-vhd:host-install(5):broken:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-credit2:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:debian-fixup:fail:regression linux-linus:test-amd64-amd64-libvirt:debian-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:leak-check/basis/dst_host(19):fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:guest-start:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:guest-start:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-xl:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-examine:reboot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=24be4d0b46bb0c3c1dc7bacd30957d6144a70dfc X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Tue, 04 Jul 2023 14:39:25 +0000 flight 181690 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/181690/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-vhd broken test-amd64-amd64-xl-vhd 5 host-install(5) broken REGR. vs. 180278 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-qemuu-nested-amd 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-credit1 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-credit2 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemut-debianhvm-amd64 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 leak-check/basis(11) fail REGR. vs. 180278 test-amd64-amd64-xl-multivcpu 13 debian-fixup fail REGR. vs. 180278 test-amd64-amd64-libvirt 12 debian-install fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 180278 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-libvirt-pair 19 leak-check/basis/dst_host(19) fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 180278 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 180278 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 180278 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 180278 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 180278 test-arm64-arm64-xl-vhd 13 guest-start fail REGR. vs. 180278 test-arm64-arm64-libvirt-raw 13 guest-start fail REGR. vs. 180278 test-amd64-amd64-examine 8 reboot fail REGR. vs. 180278 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 180278 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 180278 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 180278 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl 8 xen-boot fail like 180278 test-armhf-armhf-xl-vhd 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-raw 8 xen-boot fail like 180278 test-armhf-armhf-xl-arndale 8 xen-boot fail like 180278 test-armhf-armhf-examine 8 reboot fail like 180278 test-armhf-armhf-libvirt 8 xen-boot fail like 180278 test-armhf-armhf-xl-multivcpu 8 xen-boot fail like 180278 test-armhf-armhf-xl-credit2 8 xen-boot fail like 180278 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail like 180278 test-armhf-armhf-xl-rtds 8 xen-boot fail like 180278 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass version targeted for testing: linux 24be4d0b46bb0c3c1dc7bacd30957d6144a70dfc baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 78 days Failing since 180281 2023-04-17 06:24:36 Z 78 days 153 attempts Testing same since 181690 2023-07-04 03:09:39 Z 0 days 1 attempts ------------------------------------------------------------ 3652 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd broken test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-xl-vhd broken broken-step test-amd64-amd64-xl-vhd host-install(5) Not pushing. (No revision log; it would be 596361 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Jul 04 14:49:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 14:49:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558439.872533 (Exim 4.92) (envelope-from ) id 1qGhKf-00084z-M9; Tue, 04 Jul 2023 14:48:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558439.872533; Tue, 04 Jul 2023 14:48:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGhKf-00084s-JU; Tue, 04 Jul 2023 14:48:45 +0000 Received: by outflank-mailman (input) for mailman id 558439; Tue, 04 Jul 2023 14:48:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGhKe-00084m-Nc for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 14:48:44 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20610.outbound.protection.outlook.com [2a01:111:f400:fe12::610]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dee2ea4e-1a79-11ee-b237-6b7b168915f2; Tue, 04 Jul 2023 16:48:43 +0200 (CEST) Received: from DBBPR09CA0004.eurprd09.prod.outlook.com (2603:10a6:10:c0::16) by GV2PR08MB9302.eurprd08.prod.outlook.com (2603:10a6:150:d4::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 14:48:37 +0000 Received: from DBAEUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:c0:cafe::89) by DBBPR09CA0004.outlook.office365.com (2603:10a6:10:c0::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.31 via Frontend Transport; Tue, 4 Jul 2023 14:48:37 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT024.mail.protection.outlook.com (100.127.142.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.18 via Frontend Transport; Tue, 4 Jul 2023 14:48:37 +0000 Received: ("Tessian outbound c08fa2e31830:v142"); Tue, 04 Jul 2023 14:48:37 +0000 Received: from fbc562dba8b9.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8CBB86CB-9F31-4BCB-A7C1-1E8A27324675.1; Tue, 04 Jul 2023 14:48:30 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fbc562dba8b9.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 04 Jul 2023 14:48:30 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AS2PR08MB10155.eurprd08.prod.outlook.com (2603:10a6:20b:62d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 14:48:29 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::5e17:39a6:eec7:c482]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::5e17:39a6:eec7:c482%4]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 14:48:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dee2ea4e-1a79-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yLnOFhqSItkLt5xxwjGEwhD+ES50PHx4ePZo0o7xazo=; b=otqziaZeKDKuijmbzvL0ueVzCYh3SPLWqfHg7N5rDlK+oglkXcPzojr09wfGV2HV0AnIY3ZVP/WCqe4KmT+XQhjuWrVsYfNqLZPm+igK5ZPCP8deQe8dK/66LbPQL62LnhjaTn/1T/r6c36mNMJQutAaxlvBXYsxTErTyRDm4XA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 06850714c190bafc X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ahAEHsXj0wZ2ShNu2SvMcoaTb9+edd2GpMVjn7NtdHmPmzHqD8oNMzA0s38MLXaCTxKPZmUNPZvoVNES9FN9fiYP1JOfV+r5KAozLnkPr8fJ36qaoNlb2NQqQI4COUU8anMr1HcYn/i6tsmELaG1z+gpB2ptujQ1CZHB27VNKG8yICLzOq8nBac0d4rhjE27ea6zmJhY0M7tOWfNs6/7e8ILvKXa8wKQc5gBTbSwRUW9XDzlO+auYMTAQC4BJkFizIUvo0CfYuZ6muQeId7DqFo5GrKN6WwuZ1mPkMiS3zMibDROePeySWjID/aCYn4K5fXkwBnc+mexy4U1m4QbEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yLnOFhqSItkLt5xxwjGEwhD+ES50PHx4ePZo0o7xazo=; b=fuc5xgZQMjkwiB6rEakDKUDPxW5XB8Sz9Y5zXJZ7HR5i4Akr36D8O1/GTJqEh14DRyNL+E4t0jXpnoIGS1LvJoN+PHJdEjD4K/zJ3N+1GM+pYa8rrcJF2anuCcp7pbCjOmDLr/LJH0qLzfaNn7sEdD4eqHssX++H8zham/yKrn6OtoO8IVeU2PsQJ/sP3Cz1PU3YhVWRLOmTFYpyfFZkJLZw97H0okDm+ZDR3G5yf+NpeOi9jYaihCth+e1FgyuBMeKYb7wpovOpqBKDW/a8cUFAzF/Xx2Uki4ZpewLuJ8Pq+UBoGNsOcIxmO/6pxCuC+eBbZ/9/HYAep7BPaUGmdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yLnOFhqSItkLt5xxwjGEwhD+ES50PHx4ePZo0o7xazo=; b=otqziaZeKDKuijmbzvL0ueVzCYh3SPLWqfHg7N5rDlK+oglkXcPzojr09wfGV2HV0AnIY3ZVP/WCqe4KmT+XQhjuWrVsYfNqLZPm+igK5ZPCP8deQe8dK/66LbPQL62LnhjaTn/1T/r6c36mNMJQutAaxlvBXYsxTErTyRDm4XA= From: Bertrand Marquis To: Julien Grall CC: Xen-devel , Luca Fancellu , "michal.orzel@amd.com" , Henry Wang , Julien Grall , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH 3/7] xen/arm64: head: Add missing isb in setup_fixmap() Thread-Topic: [PATCH 3/7] xen/arm64: head: Add missing isb in setup_fixmap() Thread-Index: AQHZos+3AfbUxPj7/Uqgb3LGizDPV6+px4QA Date: Tue, 4 Jul 2023 14:48:28 +0000 Message-ID: References: <20230619170115.81398-1-julien@xen.org> <20230619170115.81398-4-julien@xen.org> In-Reply-To: <20230619170115.81398-4-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.600.7) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|AS2PR08MB10155:EE_|DBAEUR03FT024:EE_|GV2PR08MB9302:EE_ X-MS-Office365-Filtering-Correlation-Id: 8e5b482b-4b62-4c63-c118-08db7c9dbfc5 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: qSEa4yZ58G/OCH1UOxrg9fbKIVOGAteSjOYd8wUd3QstLXtKbuZonpVS4mCxA/85uFokkdv3b/V6Uu7hAKtpX+nT7CSnS8hWLT9yrqxntltjUtivsZ1UGeuXDejIsY5Ifr2p1aByhfzttVrkFVcLHzRcHlNUo3/88iVpvdJYs3TlB1epddVisBa6ICb89+UZQQ8d5BsvN/nRJehhZEuMHn7rTqGTj0LBOQ+ynb4GJRblSJwnzmQPqnq31Yxasru/NkpA9xoqcnW6b4UqRK+30KnShJOSuq1/jv9mDJqxSY5kPrVbAPlDJM04nScnFStAOgNh7Q64Q/0jqNc7BS+aK1bq6mGJ1rL1xHOwdLMo7GJZUuCg9A960EFNv8yfyFDiN/Vn4Mcc68195yNxFq/9nHQf55JZmoE6e/9w3UhLYnAZMW5vjp1dKuvhSKO8qIvBG2V2gRit56qwZ4eWsifqb8/Y3lTpaako6CbWN2Rvp62D6fjRzSK1im0ID5fr12VTkvAAnZXVjehe/OanijC/W1gxmjzoN4g/52HvClccNoYqYrrPXERfjXmuH+kSwixaAHGR3YDRLaYtZOAPWzGF764P17cAa1msCp1rA+6XQd4PszIxbZwZi9D5MhYAZgg+mw3QfmEvF/vVtbevWci7Ow== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(366004)(136003)(396003)(346002)(39860400002)(451199021)(186003)(478600001)(6512007)(53546011)(6506007)(38100700002)(86362001)(71200400001)(2616005)(91956017)(6916009)(54906003)(4326008)(66446008)(76116006)(66476007)(64756008)(66946007)(66556008)(83380400001)(316002)(122000001)(6486002)(5660300002)(41300700001)(38070700005)(2906002)(36756003)(8936002)(33656002)(8676002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <06A96F0C47109640A34971FAE6F24ADB@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB10155 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a1f1fbdb-4ddd-4059-3d8f-08db7c9dbac1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: R0UvdW56YYpz/kSOBwJNMy1WQLOlKzSQf5wj9oAWHR5mSvqo7y/29PWHFAUWkAvuTmahC9VCFywfKZ3X1K/dy+zuxIlPCSobM2VAb4/mnEIAhPR4JV1HtuEGdFEslD8BfyF1Dg2jKDO37LxGD88N3JzOs5Uc6shzBc+E72e1Q6epsRBbfadoc5vJrNxjue6EAApUaV3IXZQMmf/r4THBJTEIkYfT19DgushVoTTkG1qz7ZoHxF0Qd7+8ow+vaBv31L5xxJ8bzxrLoTiB+fkFkM8uEz6y/RQw66FkUtOd9kMiiB678YLn2FRy8nncNp/7niu3bMFYuXefSAsg/tMAUGpbdjWDsVQSjDumR0XbiKa5GudJZpXi9990wnTvzyZLbzcVYiZzwnhVWwaApkeFrtQxjylEckZ0AuVly/mMAv9TDwg4UmygJAXk+tWwabJlCoCDDcVmd3p1gA/AAmKB//a09jR5ViYDyU4ZouAIlI4CFtZsXR8RgBgZy8rVia6RDlDvNxoA/tH0MDJ40qu/gbOjXmNeL1xpQKpLj7Cv4/Q89YFL4Db597JJfhfQTfDW58tVaQKVYj8jJJnWypOUflVcsJZ7rB70Jjx1JsSy4UzoH3WM7y7bHs8VNPPwVms8XN3x7XODAwOb4O92Tt8Iy6I1PWnWnnS7d9HiRGoqTr9X2Sk1tjt3xCoRW00G4QdK3Mq+EAlqCuaHX/yWNvjx8ocT/p23ODkG7kfNcrnhMVRNvpmr6IRw5r7GFtmvxWHV X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(346002)(396003)(39860400002)(451199021)(40470700004)(36840700001)(46966006)(107886003)(26005)(478600001)(6506007)(82740400003)(6512007)(86362001)(2616005)(186003)(53546011)(81166007)(54906003)(4326008)(70586007)(36860700001)(83380400001)(356005)(336012)(6486002)(316002)(70206006)(47076005)(8676002)(8936002)(6862004)(40460700003)(41300700001)(2906002)(40480700001)(5660300002)(33656002)(82310400005)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 14:48:37.2175 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8e5b482b-4b62-4c63-c118-08db7c9dbfc5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9302 Hi Julien, > On 19 Jun 2023, at 19:01, Julien Grall wrote: >=20 > From: Julien Grall >=20 > On older version of the Arm Arm (ARM DDI 0487E.a, B2-125) there were > the following paragraph: >=20 > "DMB and DSB instructions affect reads and writes to the memory system > generated by Load/Store instructions and data or unified cache > maintenance instructions being executed by the PE. Instruction fetches > or accesses caused by a hardware translation table access are not > explicit accesses." >=20 > Newer revision (e.g. ARM DDI 0487J.a) doesn't have the second sentence > (it might be somewhere else in the Arm Arm). But the interpretation is > not much different. >=20 > In setup_fixmap(), we write the fixmap area and may be used soon after, > for instance, to write to the UART. IOW, there could be hardware > translation table access. So we need to ensure the 'dsb' has completed > before continuing. Therefore add an 'isb'. >=20 > Fixes: 2b11c3646105 ("xen/arm64: head: Remove 1:1 mapping as soon as it i= s not used") > Signed-off-by: Julien Grall Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > xen/arch/arm/arm64/head.S | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S > index f37133cf7ccd..4ea64e70997b 100644 > --- a/xen/arch/arm/arm64/head.S > +++ b/xen/arch/arm/arm64/head.S > @@ -769,6 +769,11 @@ setup_fixmap: > create_table_entry boot_second, xen_fixmap, x0, 2, x1, x2, x3 > /* Ensure any page table updates made above have occurred. */ > dsb nshst > + /* > + * The fixmap area will be used soon after. So ensure no hardwar= e > + * translation happens before the dsb completes. > + */ > + isb >=20 > ret > ENDPROC(setup_fixmap) > --=20 > 2.40.1 >=20 From xen-devel-bounces@lists.xenproject.org Tue Jul 04 14:49:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 14:49:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558442.872544 (Exim 4.92) (envelope-from ) id 1qGhLJ-00007m-VU; Tue, 04 Jul 2023 14:49:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558442.872544; Tue, 04 Jul 2023 14:49:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGhLJ-00007f-SK; Tue, 04 Jul 2023 14:49:25 +0000 Received: by outflank-mailman (input) for mailman id 558442; Tue, 04 Jul 2023 14:49:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGhLJ-0008VY-41 for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 14:49:25 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f57acfe9-1a79-11ee-8611-37d641c3527e; Tue, 04 Jul 2023 16:49:22 +0200 (CEST) Received: from mail-co1nam11lp2169.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Jul 2023 10:49:16 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by BLAPR03MB5442.namprd03.prod.outlook.com (2603:10b6:208:291::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 14:49:13 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::1c83:1877:a68b:8902]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::1c83:1877:a68b:8902%7]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 14:49:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f57acfe9-1a79-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1688482162; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=GoQLM3ePx+7KPZBJVGBcUQYU/brh23m+rtZYoh7Wv9Q=; b=ZsXJNCXanrIXZX8xmfRLu343v90P9gUYzi1G5eaQjaPcCnBxnl3NqgR+ xbilnQSqTO6QkpXNNyMn/G0eAMXxLB4DYL+2AVs2w+Sk+/9UReIM6qMOz CDnsvVxsbK3NmTzGNSonZl+9zkb0NDBW6YuU2Ob/3iH8mMyOHpDIPLhek w=; X-IronPort-RemoteIP: 104.47.56.169 X-IronPort-MID: 117690903 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:IS6XAakZPWgM1nE/fIl/0pvo5gw8J0RdPkR7XQ2eYbSJt1+Wr1Gzt xIfC2COPPrYMGDyeItyYYTn/BsP78TdnN83HQE++HszFCMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE0p5K2aVA8w5ARkPqgU5AOGzBH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 cwYdj81TwGju8mZh7+WSNJImsI9COC+aevzulk4pd3YJdAPZMmaBo7tvJpf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVI3iea8WDbWUoXiqcF9hEGXq 3iA523kKhobKMae2XyO9XfEaurnxHqkBtNKReXjnhJsqB6i7DMCK0QdbH+QhaGkk1+xfPR+C VNBr0LCqoB3riRHVOLVWhSipXeesx00WtxOEvY74gWA1qrV5QmCAmEOCDVGbbQOtsAsQicx/ kSUhN6vDjtq2JWOUm6U/LqQqTK0OAAWIHUEaCtCShEKi/HEpIwwlRvJQsxULL+ujtb1FDfzx BiHtCE7wb4UiKYjz6in5xbfiiyou7DSUxU4oA7QWwqN/g5/IYKoeYGswVza9upbapaUSEGbu 3oJkNTY6/oBZbmJlSqQUKAOEauv6vKtLjLRmxhsEoMn+jDr/GSsFahO4TJkLUIvPc8eeSDgZ GfavA8X75hWVEZGdodyaoO1Ts8tlK7pEI28UuiON4QfJJ9saAWA4SdiI1aK2Hzgm1Qtlqd5P oqHdcGrDjARDqEPICeKetrxGIQDnkgWrV4/j7ihp/h7+dJyvEKodIo= IronPort-HdrOrdr: A9a23:kLd+o6iHlir4lMlBqYnMvVTwOXBQXhsji2hC6mlwRA09TyVXrb HVoB17726ItN91Yh4dcL+7Sc+9qB/nhPlICMwqTNOftUrdyRqVxeJZnOnfKl/balTDH7VmpN ldmsFFYbWaZzUXsS+52njcLz9K+qj+zEnHv5ak856vd2BXgmNbgTuRxjz6LmRGAC1PBZ84E5 TZw8pculObCAQqhw2Adxo4tvD41qL2fYzdEGI7OyI= X-Talos-CUID: 9a23:ZdfZlG3eVEyBItfuCrZpALxfKsB7fUX83VfsCGD/BEtrc5mJT0G00fYx X-Talos-MUID: =?us-ascii?q?9a23=3ArPpL2A5EN1ix0xF8xpudeZxIxowr0o7xGWNUmqw?= =?us-ascii?q?ikO3cKDVhNBC7rRaoF9o=3D?= X-IronPort-AV: E=Sophos;i="6.01,181,1684814400"; d="scan'208";a="117690903" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SfU9qXoZ1t2w1SiIiIaERUNHq5a4Oo/ukxRCKVBz41hTPPeZ9PUUJroeiV//KstA2A2o0HkJI0qUJmEqrCZmdg+sEmulVLkjghuGd+bJMhHjmmq1y0M3kGqvB8yNZjS8fE5tWjoDkuagzI+c+imHDwYOrjzFJgaNatp7UlXjtyMJhcKhIcoZQ1r0Dd3OcyhOseC4Val0wIciJOsW4nlZv6PBPmklWhTLMDU1FgpNazDuSGwCFsj2q2Z3gxH608MgWnpfPh0hgDXD2w2aJCW5XRzvXScAbE40s8/PbfYiShPKHK1qrlYsah4ZHQOjyTdtYwmQOW7pOIKvQsJ/ZfR7ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1a3Wu7ZwpKUye8yTK3Oda4WTS140fzit/X7bwpStt90=; b=bTcGDdINW5wAC0QUYz/DEnP0G5pR+nM+ROx4N/SypXQKadnPt11gntNWTmzyGH9er3eNvX3XKFng0LSovuZK/adY4/s4ew2qf+ZnCoE5EWJ4V9oPTV9F38XcJ9XXZMIuUrN2lhjzVWrjss9i9A+fk/s5xNaVEYShFk5Bz2niKwj+rWfEhRa8ZgxXTmyGlMbpa8j73J4jUBXFGiv9kSoD/pkB8o+/TNBtKI7mkeg2SOweB1vO5YmvvGUJb1tvZcsPGygCvRSwwTOdlXTizNNsBBF7KdggmBhNloOhUchDChaLuTcjrS0y/s+HOSbdiDGlTD7ADvC7GkYFs4xKA/i+lg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1a3Wu7ZwpKUye8yTK3Oda4WTS140fzit/X7bwpStt90=; b=eNLPQqjV8GSnI/RPruiQbP5kCS/brN1A7Vu03hvj+K+WqsF5440gozuyQ7dELifMY9kq5BqQ0/jkM1PRvu81DwkWcKhj2MJcDu7/TgvbUQpC+23gY1ohj1jMtyE+a9DJY6OYkhZffwLmV2uBGoc1LkgVKowNYCvJ0vh5PGzskUw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 4 Jul 2023 16:49:09 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Petr Pavlu , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" , vikram.garhwal@amd.com Subject: Re: [PATCH 2/2] xen/virtio: Avoid use of the dom0 backend in dom0 Message-ID: References: <20230621131214.9398-1-petr.pavlu@suse.com> <20230621131214.9398-3-petr.pavlu@suse.com> <15e31609-6c45-7372-76ee-0adf7a64fe88@epam.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P265CA0032.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ae::18) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|BLAPR03MB5442:EE_ X-MS-Office365-Filtering-Correlation-Id: 2319758f-86bd-4375-76c2-08db7c9dd558 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l1T3d5TdZ1hP/eSJAJWBDKimtMUic5TzDT15/brgwHraVfYM+D3ZfJC8Eyj409+MQ0lexfbGimqH9om5Vog5Z8mYiiNNGQlnApHul7/itdZp/MzY1pgL0FhMovcj2XH7nDFbQVvh0fN+0ENeVg3afO6IgYOARqNybMLc+RbcjDzzwWT3j6/CF2N0HcNYTDGDTc+jiwqmUb4P9VRb0wyzkrWPEPvKr/iXuET69dIAp1GCip8Sfa9jJwt4zpYYAWs2wQoCjiyrgCq5GjpF5ThqjeM0xGuUWD9iFcRe/plegRqNo7u9BBv6hm6Ak/gr1hkiO2VwXew9arVVepQcb06CU03fyvIw067Wwn5vCbrUQtey1yoVENHry9j7KqrL8bxdBdjD+Xf6fBfs4NgK9FCVXw9hj1MFqdA9xHLAWcNelnTZva/YsoL1NacknCnynIvk1YFEM6Dh79dpRdSab4OJwYw6Agovcqd6j0cvIg5GJQP6vJ8PT8Swb0i6Ducr12l8mMd9sbiRN/Uh53w8UBWIww5j8R9nkU7OwyGoB0mF/xv6WMiT6hEd4cEEGF75naaO X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(376002)(39860400002)(136003)(396003)(346002)(451199021)(186003)(82960400001)(478600001)(6512007)(9686003)(26005)(6506007)(53546011)(86362001)(6666004)(38100700002)(6916009)(4326008)(316002)(66556008)(66946007)(66476007)(66574015)(54906003)(83380400001)(6486002)(5660300002)(41300700001)(2906002)(8676002)(8936002)(85182001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?akVqZjFIOXZyTW9iaWx1VWgyS2ZBQW1qTmE5Q0J0OUxtNExqbmN2UW1XRmtH?= =?utf-8?B?ZHNMaE1ReXU4aVpkeDB5QlNlWFAzRDU2dXBGZzIxU0JZa2l2TmpuVWJwSGRF?= =?utf-8?B?VXgzU2Vld2h2N3FCazlMTjBZYWNrclB6Q2JRR05idTU3SDhFWWhEWXdDelNk?= =?utf-8?B?NHNTWGZKT0tMUkNheGxzemZoNk5wWXU5bEg5ZkVENElSUHR1TERKb1ZkYVlx?= =?utf-8?B?cGtRU0x6bmNwaTVuYWtzdkFkMUlWTU42cnJFUitjcmM0MUxKclBZNWxmVlR2?= =?utf-8?B?K3lwQjkzTVVtbGxQZXVMSm92QnMyNFlOL2Z0SHJuUkNFeUlVRStSTUlZbm1v?= =?utf-8?B?dkhIRnpEOHh6b0VnMTA4cFJ5Z2JSQWh4TTZ1NTJPU0RQak9KNjhXa2NudDIv?= =?utf-8?B?Y0Z2dGhuT2RtdkFDSmM4YXpEbjFPaHNIWEIzNjN6aDhYQ0kzNWVaWmM3Zms4?= =?utf-8?B?MDlvOEtKY1d1OHZ0bXR2cW1ubFJZUmZEN0hxUGN1clg3Y2YyajBDcStIUW4y?= =?utf-8?B?L2pvK1hSVkFkQ0NTb25pMDdWaDFPZjdCd0hONXNLSWR1TU5BTy9laGNwTjRt?= =?utf-8?B?MUR6OVA1T2VVelVSMGErZ1laTy95dWptekhVSnZBN2IybGZDdmpjbmwybkZa?= =?utf-8?B?Tklyb3VJYStvZHlIcWl1RmtyVm8rNnJrWEhidU9QMG90RW9mdkNPTjQvWHV6?= =?utf-8?B?NmI5RTlPQVFBT3ZWTnF1MVFRRUdYRkhqVzJRUWlUQnFGVkE1VWVVT0ZtZjlV?= =?utf-8?B?U0FPTXFTYkdNSU1wbzdwaks5RUJsb0Z4WDhwaHZTK1lqcU1iVmErMHpqYmt5?= =?utf-8?B?RFhEWUFvYlJHaVBpQW1kYUJIYlZVRHh5M1BKdUZXM05vck8vZys1N0U3TnRu?= =?utf-8?B?NEdCQWVJNTVXUVZ5MHppM0ZQdkZ6ekdTbE5BaGNsTGRVQmdwOU5pTFJLQnZp?= =?utf-8?B?RHhJUExDNEpHbmczTzg5UkNnNHN1YUphU2wrRGdiMkZhdXMxVGJNM2QwdHg5?= =?utf-8?B?M2ZJTHlHRElGYkJCd2ZNYTZIanZDKytQMXoycXBJUTBINnVtbDlEMjRaWTVJ?= =?utf-8?B?NjNzUHh3a3QwNVdqU1dvZEhoa2xWQ1l4N2V5RUJERnJwY09YTDdwTDcrZXBh?= =?utf-8?B?bHgrSDhtTnJYangrMFhyUmd5ZW4zaDZnb2JQb3QrMGF6ak9ZeWViVlJ1QjN2?= =?utf-8?B?MmsyYU0rNWVJVlloc1orUjRlNXNtaFVVSjBERjRaYllLeTgzUmdnQmJJMlZ4?= =?utf-8?B?cERqdVpwZjNGWmE3T1l5b3daekRscENNTVM2WExPSHNWaFpWZURSWVVoZlc0?= =?utf-8?B?dlpCV3dGYUltNk9DYkU4WVoyRVJKWkt4Q3FHeDcxaDdTTXYrMWh6bkp3Unk1?= =?utf-8?B?bCswY3dlVlluRTVZcGhBRS9yblMycXVSMmZsMjJxZGJFV1FYNFJlTGExenVi?= =?utf-8?B?TExSckFrV3VkL2h5REhwdHZaZHJDTlhETTJZK3kyVFlrbzZya2QwZ3laOUp4?= =?utf-8?B?TkV2ZW9ocThJMFljUXhBR1ZPK2YrbWpsOHhXNndkSmtaQW4zbEhFRGpVTi8z?= =?utf-8?B?OVBlVE1qTTJPNDhPMGE0UkFNZzdmaE1Ob1BreTNrM0M0Mzhud3AxM2V6Lytw?= =?utf-8?B?OGFVemRjNlhvTTNmZkhFM3dEcU9ERmFqNmlUenRGTFdFYndYTTdJa2Z6TDVl?= =?utf-8?B?SlV6dkx0cVVCRGRqeWh6VnBxaGVORkhicDJreDdOd25BYkpNRmczRGFnQ05C?= =?utf-8?B?MElWd2xMUmgrb3JBa0hZekZNM0lhOE9oK1FGSXRvSDJxaUE1Ry8wNndFTDJm?= =?utf-8?B?b3hYUDRabWJwQXVHdW1EaGxRWDYzR24vQ1M3czBQSTFTaUhNOFZxbmp1QU45?= =?utf-8?B?TDFZTGVBTlBkWktncHFBYjBEc2FxWjcxem9rUnM2dXJXT0syN1pJUndaTEFz?= =?utf-8?B?M0dzMTUyN0Q0RXhpaDVJTjlmb1VZVnFIMm5LOUhmcndidmMrSG5LRVVTK2Fp?= =?utf-8?B?dVNlWXZFK1lUNFRWViswVjRIcEFPcFdhdEk3R2xJOFJVSnVnWWc5N2pBL1I4?= =?utf-8?B?cStxdGYvQlpMbXNuaFJoUzlIazI0RFZTdG53N29PVW44VmtEL1czTFg2Z2xq?= =?utf-8?Q?8mvithw/sRremeoOTtlETnCbl?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?bHRIL3hGbEdIZFdueDdRRTlYK1BNdmVrWmt1SGoxMUNGRkE4MXR1UlFjbm1D?= =?utf-8?B?SVEwUGw0T1BMd1BDMXR4RUhlZVVnRUYrZngyZDRiOUFDSzVlamcreHdseVJo?= =?utf-8?B?VU51T2ZVOWRlZEhrdkJsczNPeVAxSDJRUEVjN1RKaDJNNnBoenJUdTk0MDA2?= =?utf-8?B?blVTU1dIYjJBT2VGSFg0OGxOSHJXQW1wR0V1YjRmcEZRSE03bVJ1Q3plREJp?= =?utf-8?B?Q3NYWktWM09pd043b2dZTE8rUEtQNnZTN0xzazUvRDlaV3BmZ2IvbWxRZERO?= =?utf-8?B?TUlMRWtSbVo1cUFGaTArV1hCcVVBME10c2hTOG5tSDYvN2pMRXhGUUxtQ1Ex?= =?utf-8?B?ZDlOQXByOEQxajNVQVBwWmRNcys1UURNWHEzeGpHci9aeTI2aEMwYzNmc2lD?= =?utf-8?B?NS9TZDF1Mk13RnFkWm5PaUVDL3prRm9DYjRUaktsb2xDTTVlQW9CMmtnK3ZB?= =?utf-8?B?c3ltcXZWS2RTTTdRTlRSaGI5ei92a3lidEFhNkQ3Nm5sMXVMallrRGlwK3gv?= =?utf-8?B?Z0I4ZFcrZVg2SE1qSXFxY2JieVRCcFRldFk0VWJKQzhMLy9lSTE2WU10aFgw?= =?utf-8?B?YU5MMllCZGJTTjVlQ1FVSzZieVg1aXRyTW95OXFqdERvZVQwYW55dFI4bWFo?= =?utf-8?B?VWUydjhKZy84dlBjZ3lEcCtFYm9kVEtHMHJtZmlGY0JMK3ZLT1A0dkVlbzBy?= =?utf-8?B?OG0zQll0NGk5NFpoLzBSdXdvU1NuZjh6WmQrSWNSbmNQTVpaTFg0OXVwdHlN?= =?utf-8?B?aWNsK1ZiTkZTR2ZWSmwwRHNrRTNuVVNVclVhd09SSEUweEdERlpQTzRJSWk0?= =?utf-8?B?UUxMTnQzdU1Pb3B0SmVLUW5GK3F3cFd2dFNjWXpVQUtTSTdZK0JHY3dWZEhB?= =?utf-8?B?NmVnRTcvQ1pKWnFMOGEvTDc4akZRYm9rbVFBYnNjcDRpZ0JqWkZyWnFPSzRE?= =?utf-8?B?VEVnOElWU2JiM3pMVmozOG1tT25pQkZwZGxYNTdrQUsrMU4yNFdoZDI3TzZJ?= =?utf-8?B?aHMzandtazlNTVNUbXVRbEdyeDhvYXlSUS9xMUZ1aXUrOFVsWGVKVHpXemdW?= =?utf-8?B?MXlTV3l2bFhJNmhxZkVXVWtXRmlweVBTRGtiOWlnN1E3YlNzV1Z2SWZmd0JR?= =?utf-8?B?eVN6TVVPSlhTRGRlaGlsSmYzTC9GeXpYcHF3K3JpY0hEd1RYT3FBL2hDdGtL?= =?utf-8?B?d0JDZ1FzMFRIYkRWVWdZcGdvTUtkMzFZb2RHZ0tDYTQ5azhOOEU0WTlKWnJ2?= =?utf-8?B?S2QvbHIvSk51VVhmOFg1aHREV1cycjZXWXd5bktySmVFRkJoaS8zY0dzd0RK?= =?utf-8?Q?E0ypvvWOLXGG0=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2319758f-86bd-4375-76c2-08db7c9dd558 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 14:49:13.6667 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gWg7fDdByVOuDbp3hhj0/McEWYMLvZkju/Ti54ttU9y7JqR5iqPRmJ0fJ89+dihhYgjaqGOVVqr0kDV9LZy4Kg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5442 On Tue, Jul 04, 2023 at 01:43:46PM +0200, Marek Marczykowski-Górecki wrote: > Hi, > > FWIW, I have ran into this issue some time ago too. I run Xen on top of > KVM and then passthrough some of the virtio devices (network one > specifically) into a (PV) guest. So, I hit both cases, the dom0 one and > domU one. As a temporary workaround I needed to disable > CONFIG_XEN_VIRTIO completely (just disabling > CONFIG_XEN_VIRTIO_FORCE_GRANT was not enough to fix it). > With that context in place, the actual response below. > > On Tue, Jul 04, 2023 at 12:39:40PM +0200, Juergen Gross wrote: > > On 04.07.23 09:48, Roger Pau Monné wrote: > > > On Thu, Jun 29, 2023 at 03:44:04PM -0700, Stefano Stabellini wrote: > > > > On Thu, 29 Jun 2023, Oleksandr Tyshchenko wrote: > > > > > On 29.06.23 04:00, Stefano Stabellini wrote: > > > > > > I think we need to add a second way? It could be anything that can help > > > > > > us distinguish between a non-grants-capable virtio backend and a > > > > > > grants-capable virtio backend, such as: > > > > > > - a string on xenstore > > > > > > - a xen param > > > > > > - a special PCI configuration register value > > > > > > - something in the ACPI tables > > > > > > - the QEMU machine type > > > > > > > > > > > > > > > Yes, I remember there was a discussion regarding that. The point is to > > > > > choose a solution to be functional for both PV and HVM *and* to be able > > > > > to support a hotplug. IIRC, the xenstore could be a possible candidate. > > > > > > > > xenstore would be among the easiest to make work. The only downside is > > > > the dependency on xenstore which otherwise virtio+grants doesn't have. > > > > > > I would avoid introducing a dependency on xenstore, if nothing else we > > > know it's a performance bottleneck. > > > > > > We would also need to map the virtio device topology into xenstore, so > > > that we can pass different options for each device. > > > > This aspect (different options) is important. How do you want to pass virtio > > device configuration parameters from dom0 to the virtio backend domain? You > > probably need something like Xenstore (a virtio based alternative like virtiofs > > would work, too) for that purpose. > > > > Mapping the topology should be rather easy via the PCI-Id, e.g.: > > > > /local/domain/42/device/virtio/0000:00:1c.0/backend > > While I agree this would probably be the simplest to implement, I don't > like introducing xenstore dependency into virtio frontend either. > Toolstack -> backend communication is probably easier to solve, as it's > much more flexible (could use qemu cmdline, QMP, other similar > mechanisms for non-qemu backends etc). I also think features should be exposed uniformly for devices, it's at least weird to have certain features exposed in the PCI config space while other features exposed in xenstore. For virtio-mmio this might get a bit confusing, are we going to add xenstore entries based on the position of the device config mmio region? I think on Arm PCI enumeration is not (usually?) done by the firmware, at which point the SBDF expected by the tools/backend might be different than the value assigned by the guest OS. I think there are two slightly different issues, one is how to pass information to virtio backends, I think doing this initially based on xenstore is not that bad, because it's an internal detail of the backend implementation. However passing information to virtio frontends using xenstore is IMO a bad idea, there's already a way to negotiate features between virtio frontends and backends, and Xen should just expand and use that. > > > > Vikram is working on virtio with grants support in QEMU as we speak. > > > > Maybe we could find a way to add a flag in QEMU so that we can detect at > > > > runtime if a given virtio device support grants or not. > > > > > > Isn't there a way for the device to expose capabilities already? For > > > example how does a virtio-blk backend expose support for indirect > > > descriptors? > > > > Those capabilities are defined in the virtio spec [1]. Adding the backend > > domid would be possible, but it probably wouldn't be that easy (requires > > changing the virtio spec by either expanding an existing config area or by > > adding a new one). I'm not sure handling in the specific frontends is > > generic enough for being able to have a central place where the backend > > domid could be retrieved, without requiring any change of the frontends. > > IMHO the proper solution is to extend the spec. I don't have much > experience with virtio code, but reading the spec it looks like new > config area will be better for compatibility/uniform handling in a > frontent-agnostic way. Since it will definitely take time, some > transitional solution (maybe even xenstore...) might be warranted. My fear is that such 'transitional' solutions end up being definitive ones, as people move to other stuff once things work. Might be better to implement a transitional approach based on a future virtio specification change rather than something out of band based on a completely different communication channel. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Jul 04 14:51:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 14:51:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558449.872554 (Exim 4.92) (envelope-from ) id 1qGhNI-0001fj-Fy; Tue, 04 Jul 2023 14:51:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558449.872554; Tue, 04 Jul 2023 14:51:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGhNI-0001fc-CG; Tue, 04 Jul 2023 14:51:28 +0000 Received: by outflank-mailman (input) for mailman id 558449; Tue, 04 Jul 2023 14:51:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGhNH-0001fU-Fh for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 14:51:27 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0624.outbound.protection.outlook.com [2a01:111:f400:fe0e::624]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3f4e0f88-1a7a-11ee-8611-37d641c3527e; Tue, 04 Jul 2023 16:51:25 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS1PR04MB9480.eurprd04.prod.outlook.com (2603:10a6:20b:4d6::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 14:51:22 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::9bd3:48c9:ff58:9880]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::9bd3:48c9:ff58:9880%4]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 14:51:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f4e0f88-1a7a-11ee-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Il4K1W5z5m2wnACDNvA8VtdnXBhb2E5LExQ4ULQ1Z4NNr8lPvmM+RzYum5eHhywN6uuOshNkwi4n1Lkd1f9mQmTsIzt3WvnkOPEl493NBaT+rjsXX4z94u9KNaWKKhTMiYLRDuIUG2PoPp6DpVNqUSw4Q3pD8QzzQ/NAfKHKbNk40TPO5WqA5ieo4y3I+MaI5CPxZkgSP3Sf2e926C1d/yF/SMOYrZa3ZGHqHvkLxrdqRj7SFEAMQuJ+Ox35fV2J++zCopoj/Ce5REhruH0E1Vbg4aDFj8J/jZybsFgXRlhJ2yUr3u5m69A8c/5F4b/pSJFrXmGhOURy54IOtcpPiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SswWW9gD5iARnNAjAfHOFpcjojY/wWZgVT6gCXPAXBY=; b=hwX1xQXMqNKM1MPjZYfpG7e8pfga5nw/HMBcirw696skvSvTs6/PjFmOcm51iSNWciFVV8ZDkpiPrUcYuMKwbovAcqgZSx7JoT+jTlfa67M6UoGYPVuoGK31DBVqV/XbweiPdMzTR4t6L1MEjcgSCnyo8tHL9wYpEakjo0jPjuORhVrODP1aEVfA4160cDoHdKqlSVtyDjOpy/uGJjsKhmJ3ZypRPs1UldfjS7xLIOjqbdHEi77xC8Kvo3M4GJHJhJoOZqHodf6Qe7PsqNfEyWWMLhPnuNNJPdvP8auVtDd0zEvAlEUwczT63ymeN5tfFag+atdTCuopniXef0RtQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SswWW9gD5iARnNAjAfHOFpcjojY/wWZgVT6gCXPAXBY=; b=hNekEtoIPvfgyCcAb0dNgVRXEVo9AWWaAtnBKQthNDY7QX5m8khqthNZCnVAAALzA6EERizwy1nChcWNNH1dblDd67PmvP56HgCalwzi0mnIsS8H+3q4fgRCIK0By90E0JtHFLA5W/Ohs+hMUAnVDWkG4++utT7xCuMrnFjkkSqdb0VQTrcGil9p9p9X2w3AB5ehkGqaLsUVP0hrHaHmtFSy0o/X2aV/sPQgWXB692ouiiQX/qlXI6WSOw4M8FlTl4ARb+oPUfsCHbEF/085EJ2Cr206aq7VTVKXeVGhHzrWRDUuIC/EsB2QnJ7vcGY7a+jNsL52QkUNih1H6WUyKg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 4 Jul 2023 16:51:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [XEN PATCH v2] x86: make function declarations consistent with definitions Content-Language: en-US To: Federico Serafini Cc: consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Jun Nakajima , Kevin Tian , Stefano Stabellini , Michal Orzel , Xenia Ragiadakou , Ayan Kumar Halder , xen-devel@lists.xenproject.org References: <1b2d5be30c0e4f335e59dce6e7c001cb0805d702.1688465215.git.federico.serafini@bugseng.com> From: Jan Beulich In-Reply-To: <1b2d5be30c0e4f335e59dce6e7c001cb0805d702.1688465215.git.federico.serafini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0205.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ad::19) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS1PR04MB9480:EE_ X-MS-Office365-Filtering-Correlation-Id: a29a7cc7-7a3a-43c7-81b1-08db7c9e222e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HypP/JykcTBghYmpIjB2zjeZf/BnxwYTfjm+5qc3D9aJOcD8hdxGSkGMuIyPBpHreH1vQ7R5GF3Q+CzPVAHSzShR+6XwcbrnsXsCTl3UqM3b7ZFb4uoKiwDf7h9aeAYX/IE21k7kdsnjElN+t5Cr2xDfFLEzKiVVt7vCQ2A+dkptpsRhhiTfFh9e53MnlHEFaUqBTsApkDDA7L4wAjV5kkbdP4sohHtwxnjgjKPGP2qN8Bj3EGZt4oQiFLE5kdRNdxLg1ge3tCbPX4bj7ZWzWs0LrWoJFN6IZEFTsjgq00Xj5BzA98PJN+mLignuTmQI77/U9MQ52Leql2CBRwY/4ZWnHTICQXbdNEl30h2hkLXlsHULXxS1sG7CnSfHMuYMGnJ41fEUKxg+o1tTMoF5iF5ixJ8ilIhaEcLzW46WirsJOuJ9wNOKO9d+6zUGcNzvXx8RqX63jdz6zCgKt+Uk6Mx8NiAA0HIvTJdl16O0v6nUkyFe6M5JBvKsS1mZZk26rWtgbqgzwzhRG9DXURB7b3CulZ4EQwyVcmAFUXtC710woJ5TLn02PyispcwJJ6XCQ4h9Kj/yasKvZW+FffG+P78zZm+HpJ/XPhicADRPi2vbsyx0Mx69oBJTfRKahQcXQq48KsEy3aMV/Y+PiMylFw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(346002)(136003)(366004)(376002)(396003)(451199021)(2616005)(83380400001)(54906003)(86362001)(36756003)(31696002)(41300700001)(31686004)(8676002)(2906002)(8936002)(5660300002)(7416002)(316002)(66946007)(66556008)(66476007)(6916009)(6486002)(478600001)(38100700002)(4326008)(53546011)(6506007)(26005)(6512007)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bXR4M1lXSXg5NlcxZUc5M2YwUDQzRVNBTTJmRUxzZVFKVk9McTM5d0s2WXcx?= =?utf-8?B?OHFmNFFvWVR4N0F1c3FCL3BkdURCci9lcEl4c05sTTFsVXFNWGJzbTE3OWpy?= =?utf-8?B?YUg0QXFpTVVqSGtDN0l1WkhKdEkvVmdWaTM0eUpXVVl4ditxN3B0anFzWkJo?= =?utf-8?B?Y3k4UGU2R2o2d1MxcVJ1cDU0MnVnV1ptR2w4ZzMzSkgrQXR2WHVzd2ZtaGNm?= =?utf-8?B?aGpqYVhrSWJlbHhOUG1jb0VlVXIwaGptNjN6anMxOUkvMzMxRlZ2NHgwNVoy?= =?utf-8?B?TWw1eWlDZ2swMEd6SGsxamtjSCttaEtQdzRnOWk0YmZPcC96R2RwZ0hJQzlk?= =?utf-8?B?RGhhVWoxNURycHR5M1A4TURIbmQ1cXVONU5aQVY1clg0bWVsSzBSL3dDUnJR?= =?utf-8?B?RHBIZUdhTFdVTlg2M3RZUC9YbU1ITG5od25xR055Z1NmbDB1L0NkRzJDTTlV?= =?utf-8?B?UG1xbk41TExJTk9lSzJ4YjBWc1hmbFdoRjNkNU5ackFzNmMwU2hNS1BsQlNO?= =?utf-8?B?VkRndTl4REppY3lEQXZ1WFEvVlpiZ3ZZWlNqcUtrVlRHY2JTaGpVOW1sOXlG?= =?utf-8?B?dVN0NDY2TXgwTGZwWWRxWURhSG1KTXF1RWgwdmtxUjJzOG5JcitnSGVCNkRL?= =?utf-8?B?RThWeEd3ZnNSM3FMT0Nqbmd4cTBVZkc5ZHJNR21vYTJwK21veTM3Y0l6VGIz?= =?utf-8?B?QmZFR0kwQVl5cEhXRHpneVBRa3laQ1c0Q3pwVHlxcjF2NVV6TThCWHBGRUlZ?= =?utf-8?B?SEx2RXV2Tm5tczFrRUxaczlsOXNtQkFEb0lXa1BaQ1A2SkRTMnRVb0JKSFFM?= =?utf-8?B?cEVWSVRWRUlQa2NieG15MTE2Sm1MSFJZd1cwa1ZlTUlVcjhkWFk0UE0rZzBv?= =?utf-8?B?Wkk4dDhhYUlOdXd6bzdpYzVyUHMxdEZReXJhMXBHVWZNRFdmdGxJVW5ISlJG?= =?utf-8?B?R1cvZkZXdzhYVU81YjdRb0Uyb2NlQlVhSmNBZEppV3J6TXM0NXU2cHAwa3kx?= =?utf-8?B?dGM2OW9PNnFCaHBVRE5lL1lXZ1BBeEZkc3lYNVE0R2NWdWU5WENZMEJxWXVq?= =?utf-8?B?SnFCVU40OFUzczJVUFhsMWJHcVAwS2FudVgvQ2JRWnJtbnpkT3FNRzlXZjJR?= =?utf-8?B?Yy9vdnB2N2FPR05jTzVjR3BrcjRvdFNIOXVOYVptTjR4UjhGVUhIUGV5SkJT?= =?utf-8?B?MXF2eS9pT1VMZFFnQ1NUL3dKYlljcUZ5UUxyc0w5VUN5bUNRd0ZPT1YyUlRk?= =?utf-8?B?S2RGRjlJVURzbE1QWnE2ZnkxU0QwQ1kvcURpTG11Y0dOM3FvYlMyMStrazgv?= =?utf-8?B?NG1wKzlaQXdnVUsrTm1aVk5uUjdXRytEL21DSlJLb3ZXODdGSTFGRDVOMUw2?= =?utf-8?B?ZHFCRG5id2krRzBKekd1RDYzTFNiTmtOSnhNbDdPTDRFWVdiZm1wYm5JcHFp?= =?utf-8?B?SWs2TU82TUVVTUZYZDZsQXVLb1p0QUc4Uy9VNmdXWWxmakswOTlRRGlobTFy?= =?utf-8?B?ZlNSRFBCQWUwOEplZEZhZlRjdmp5cENHVVRFN1dWSE4vMm9uNkdMSmRIc0NK?= =?utf-8?B?a3dUYkJDeU1MbmdRb0wwdDJMS25sUnZjRGRwdGVNQ0djRjk1RXVOOGN0UjZS?= =?utf-8?B?UlBqdStSQ2lOb1k0VXZzRmJZb21EOXpBVWR4NlJYQUxWQ28zd3ExQXlCZ2sz?= =?utf-8?B?RCtBczhjcVYwWlhaQTdvTDRRKy9STDJPQTY4a0xpK0RWWlRxZzNaSVZWNUwy?= =?utf-8?B?NjV2M3lyNzBUZVFMcU1BOVBQK2tlWHBHcUJQMjdJN0d0TllSbVZ0NnA1U1RX?= =?utf-8?B?MFlMbkhIWWVVOXhud3dYc2lYY0YwWXU5KzBvcngrYkJUazJUSVMzVnhWOFBO?= =?utf-8?B?QndrLzJ3QjFHbE5WN212ZlBiVnRsdWZVemhvS2J4QURKa0dML2tjNXVuZzBD?= =?utf-8?B?VTlGYWFCaXNCNFAyd3M4WUhQRHBTVUFBcnJPUDdBb0RVZFAxMTNkckRVSStv?= =?utf-8?B?YXBSMHhNcVJaem9xZzc4dGNMUEpJdkxWczFtdjk3SzZDTTE0OGlNeFJ0VGtQ?= =?utf-8?B?cy82NnF1eEx3RmxqZGdCNE1aSGIvWWcvdjNxeDAyZ2NCbCt3V2ptUnZ5eER6?= =?utf-8?Q?pSVeUhIeewe03RCeBIiBX8JdR?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a29a7cc7-7a3a-43c7-81b1-08db7c9e222e X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 14:51:22.4173 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Bz8JZ9cOOkG7yordjBc4/I1MyUbUKgtRjjaF83USXsUw6opzaHLAAm9YthLFafeerF4W35VLLTDcikWV6DRDww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9480 On 04.07.2023 12:23, Federico Serafini wrote: > Change mechanically the parameter names and types of function > declarations to be consistent with the ones used in the corresponding > definitions so as to fix violations of MISRA C:2012 Rule 8.3 ("All > declarations of an object or function shall use the same names and type > qualifiers") and MISRA C:2012 Rule 8.2 ("Function types shall be in > prototype form with named parameters"). > > Signed-off-by: Federico Serafini On top of my earlier remark (when this was part of a series): > --- a/xen/arch/x86/cpu/mcheck/x86_mca.h > +++ b/xen/arch/x86/cpu/mcheck/x86_mca.h > @@ -113,7 +113,7 @@ static inline int mcabanks_test(int bit, struct mca_banks* banks) > return test_bit(bit, banks->bank_map); > } > > -struct mca_banks *mcabanks_alloc(unsigned int nr); > +struct mca_banks *mcabanks_alloc(unsigned int nr_mce_banks); I'm not convinced here. > --- a/xen/arch/x86/hvm/rtc.c > +++ b/xen/arch/x86/hvm/rtc.c > @@ -59,7 +59,7 @@ enum rtc_mode { > static void rtc_copy_date(RTCState *s); > static void rtc_set_time(RTCState *s); > static inline int from_bcd(RTCState *s, int a); > -static inline int convert_hour(RTCState *s, int hour); > +static inline int convert_hour(RTCState *s, int raw); Nor here. > --- a/xen/arch/x86/include/asm/guest_pt.h > +++ b/xen/arch/x86/include/asm/guest_pt.h > @@ -422,7 +422,7 @@ static inline unsigned int guest_walk_to_page_order(const walk_t *gw) > > bool > guest_walk_tables(const struct vcpu *v, struct p2m_domain *p2m, > - unsigned long va, walk_t *gw, uint32_t pfec, > + unsigned long va, walk_t *gw, uint32_t walk, > gfn_t top_gfn, mfn_t top_mfn, void *top_map); While the definition's use of "walk" makes clear why the variable is named the way it is despite being used with PFEC_* constants, not naming it "pfec" here will add confusion, as the connection to those constants will be lost. One will then be forced to go look at the definition, when looking at the declaration ought to be sufficient. I'm not going to look further, but instead repeat my suggestion to split this patch. Besides reducing the Cc list(s), that'll also help getting in parts which are uncontroversial (like e.g. the change to xen/arch/x86/hvm/vioapic.c). Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 04 14:52:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 14:52:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558454.872564 (Exim 4.92) (envelope-from ) id 1qGhO7-0002DE-Of; Tue, 04 Jul 2023 14:52:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558454.872564; Tue, 04 Jul 2023 14:52:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGhO7-0002D7-LY; Tue, 04 Jul 2023 14:52:19 +0000 Received: by outflank-mailman (input) for mailman id 558454; Tue, 04 Jul 2023 14:52:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGhO5-0001fU-PL for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 14:52:17 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0600.outbound.protection.outlook.com [2a01:111:f400:fe02::600]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5dca2be9-1a7a-11ee-8611-37d641c3527e; Tue, 04 Jul 2023 16:52:16 +0200 (CEST) Received: from DB6PR0301CA0067.eurprd03.prod.outlook.com (2603:10a6:6:30::14) by AM8PR08MB6498.eurprd08.prod.outlook.com (2603:10a6:20b:364::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 14:52:14 +0000 Received: from DBAEUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:30:cafe::8c) by DB6PR0301CA0067.outlook.office365.com (2603:10a6:6:30::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.30 via Frontend Transport; Tue, 4 Jul 2023 14:52:14 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT061.mail.protection.outlook.com (100.127.143.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.17 via Frontend Transport; Tue, 4 Jul 2023 14:52:13 +0000 Received: ("Tessian outbound 546d04a74417:v142"); Tue, 04 Jul 2023 14:52:13 +0000 Received: from f509a4f0b285.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C6053224-CF54-4E13-8901-698587C4F315.1; Tue, 04 Jul 2023 14:52:07 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f509a4f0b285.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 04 Jul 2023 14:52:07 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AS2PR08MB10155.eurprd08.prod.outlook.com (2603:10a6:20b:62d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 14:52:03 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::5e17:39a6:eec7:c482]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::5e17:39a6:eec7:c482%4]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 14:52:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5dca2be9-1a7a-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8Mw5zgDD5rJ+Dxf4QZVM1g1KXBfXUpQaXzRUtGGCiUk=; b=mF+4OjHj4CwSwbUGPNAfmxNv8r8Bx4d8ZMqHuh6Yhj41nCH9N5Qroiws5ToJWoAEE78xfnS808hZ/jSamfeGiz29vOjuX2aYeJ+x8sbouD7btSZnbn3mmnMWtMX5SUrjgldqVJPcRbY0tErfilOPhWWrD6cPOvXvBWannUaEg6E= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 3cffa5dd4ad0ebea X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JSOe5x25NyjqX7tghhCkfatI1FdhS5X6vK3Pm+2Uet9zlaJHxXOx9V5OHu9KnTdMfPHunnb7HPtGcULbPbVri7CZOiXgz11jhQK9rxoPL0rCbUEYPZS+CZPRKDiNvZoIb6aXxCXSRnyh+RsyNQZ4Flh0+7ciBck5CZ6dXDyD2wA6Z4M2WhXh6RitQya1RVsMvwUFazL8mOtTpVCLIPB1zMPz1PFAK6cU8wLgIBBwTxYz+0Vi1IEnVyXJLwIs1mhx4E1eBP0puHaqMFTLuKjfQ7cbRA1Xywsk6s/GR7Qz/XawywTNndLCFVayPqi0sCZ4CsOvcGlUNluXNPbRgL2zdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8Mw5zgDD5rJ+Dxf4QZVM1g1KXBfXUpQaXzRUtGGCiUk=; b=bZFFZoXxOrFzEAeqKnD+cZ4/plULC2yADeYXgkdR0c4BEC55WR1NZh77UwtFfO9DSOvtvmuUgIbU/GGZABX2NnZUUFdpPOm2rz7IQgLPkFivRaz++Cuml03iCifFgosXIIBe1kzn3tqnc+pcQTw2negEFshK8K82lRlAtipAtFlFRnOu0pDDZcK9Xcltd6pxz6FrJAHtmmdo4A5yVlOZzGZ0gVsuXItCSvMac9yrNkSfZHB40tIFA9EAVu8419EbEjWHprELYyyvRfOxA8q99TEUxrOxsrfI2yI978WPaLUbn6ScQVC6CkQHCP8ilgXnryyGygbPS/9SSuLbHkq9Qw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8Mw5zgDD5rJ+Dxf4QZVM1g1KXBfXUpQaXzRUtGGCiUk=; b=mF+4OjHj4CwSwbUGPNAfmxNv8r8Bx4d8ZMqHuh6Yhj41nCH9N5Qroiws5ToJWoAEE78xfnS808hZ/jSamfeGiz29vOjuX2aYeJ+x8sbouD7btSZnbn3mmnMWtMX5SUrjgldqVJPcRbY0tErfilOPhWWrD6cPOvXvBWannUaEg6E= From: Bertrand Marquis To: Julien Grall CC: Xen-devel , Luca Fancellu , "michal.orzel@amd.com" , Henry Wang , Julien Grall , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH 2/7] xen/arm32: head: Add mising isb in switch_to_runtime_mapping() Thread-Topic: [PATCH 2/7] xen/arm32: head: Add mising isb in switch_to_runtime_mapping() Thread-Index: AQHZos+1DMO9eCrkWkO1W1uZVBjVB6+pyIMA Date: Tue, 4 Jul 2023 14:52:03 +0000 Message-ID: References: <20230619170115.81398-1-julien@xen.org> <20230619170115.81398-3-julien@xen.org> In-Reply-To: <20230619170115.81398-3-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.600.7) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|AS2PR08MB10155:EE_|DBAEUR03FT061:EE_|AM8PR08MB6498:EE_ X-MS-Office365-Filtering-Correlation-Id: 14eb60a6-628b-4d75-26c2-08db7c9e40ef x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: MVhNHnaGpjG50AH0bU34qVBnLhtm6oJPKbbHmounJN0NXdyJv8zVFzRukBlzn8pv2dh0SUvaASsFqD2W4A6Rlwm6/FsDuKByLXEyufkm/RkGEWB0yHzBOlx49J9atzuSrBRjOD7crS2Hy6HsMSpVWZhQih7YAo5rF+8BHGtmQ6dsr3nOGejTd3BYFvZV8gS+/Jt81ACe1up0SHFg5Vk+9emB1BEJFV9R02JPETHvOtdZ/JYVPN9KuXGCQojyg5YZ7shGClNdiZ5cvS/vrNqHQLDncsqUC8vtb3K9PAYNVlBu8YJ8Pb0g+/w8motnlLL+MpuQqiDcIgiDT3s5XhSfhmIsJQ/oUCaQl5TmO0XLoQKHEE6LWQwtD70MyQB5JjB/q16suVWjFOD9wFig4ArtnSDcWNRfPsJ2fiAKvL+byD0d8wLRtBHHuPuyI5HKYc/Wy5Vw+p2MD5vO4VH7PCEt2MLl9X9VImOw0mOFnEGgE7OzNP20w6bg3NLe4nv5w4Cu7tkm0MToYJ2ejRYCEgcwGA5T2EtslXFE7dPccqIjy/+jwENBBl+R2YW2WDoSE2NwDyt3khi4V50I6MnB5dVXUyCX7h6vyFyYLz22oCthcFc/zDvR3KVvNB2sHfqjEgClxGufeCfnhoUgc1iw51Vp7Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(366004)(136003)(396003)(346002)(39860400002)(451199021)(186003)(478600001)(6512007)(53546011)(6506007)(38100700002)(86362001)(71200400001)(2616005)(91956017)(6916009)(54906003)(4326008)(66446008)(76116006)(66476007)(64756008)(66946007)(66556008)(83380400001)(316002)(122000001)(6486002)(5660300002)(41300700001)(38070700005)(2906002)(36756003)(8936002)(33656002)(8676002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <3F3EDBF9439185469C9B040B867E2B59@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB10155 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 93d41ff5-83d4-43f1-9d64-08db7c9e3a8b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DwD8eB2t93uz3kmQ0od+sOM1Dqs70hCS62GqWDd5JKJInQ+jKhVjU01xwdwoSuthUzB6392arHawJvZheQ1THHcv+yXKbn1FHs4h/1AddsZRIrH5fUWeTzZ0rH8MJ+ydECQ6KT2YdooHqX0m6Pv/5hnMkPDNsdcCMDP1ABHso0XDZ9wIh1AMKD48hRlom5sSNHSHb24evcShlc2a4V4c0kXbEMqUN9Ez5C29KodTMTte41Meb4HAsrUMO/tTZchGVQ/5BhS1hp40+HxjrPZDX94L1c6g693hC+ICYvKk71sMnyihBHLhDZqGlGaj+Qm6eUqZcfU1Gjdow9Y3safJjRFSNlEa/upSNEbCtRgbphrUTdFD9at5oYgj/uX+hUavm8ZbaBnqQBf174LeqIgJFDPxM6RnTjCcRvt8ohIdaL00YRKY7263oNeAi38mRbbBJPqThyXIXi2B+JqDjCgkOJue+/SglCquYQ8HPJKaHYqQrrFYyacExlBNmoiUYT4UZ3qaZBGJe8yigBeOJel1sLh+9HaKL71m4ckxs7IBSoWwlyn6PSC+fA5T3Mi01ghvvP1B6w6G451IrLz+4XlEtbs3s4mId/ano6GBrwX9qeifpO5e1g7Dz3S9twnjM0RoVlj7zl9QQYjmPhawTaNnHdNlRhnUS7ggLecJMWqp1T8DDN04XFHSQvOjenff+YN1o/FuNRdEuA9woX6KQBlllKDvH499v0NqWyvxTDcTC+197get3kkauxpXpPgWim9D X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(346002)(396003)(376002)(39860400002)(451199021)(40470700004)(46966006)(36840700001)(40460700003)(2906002)(41300700001)(5660300002)(6862004)(8936002)(8676002)(82310400005)(33656002)(36756003)(40480700001)(86362001)(6512007)(6486002)(107886003)(478600001)(83380400001)(47076005)(36860700001)(336012)(186003)(53546011)(54906003)(2616005)(26005)(4326008)(82740400003)(70586007)(81166007)(356005)(6506007)(70206006)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 14:52:13.8836 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 14eb60a6-628b-4d75-26c2-08db7c9e40ef X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6498 Hi Julien, > On 19 Jun 2023, at 19:01, Julien Grall wrote: >=20 > From: Julien Grall >=20 > Per the Arm Arm (ARM DDI 0406C.d A3.8.3): >=20 > "The DMB and DSB memory barriers affect reads and writes to the memory > system generated by load/store instructions and data or unified cache > maintenance operations being executed by the processor. Instruction > fetches or accesses caused by a hardware translation table access are > not explicit accesses." >=20 > The function switch_to_runtime_mapping() is responsible to map the > Xen at its runtime address if we were using the temporary area before > jumping returning using a runtime address. So we need to ensure the > 'dsb' has completed before continuing. Therefore add an 'isb'. >=20 > Fixes: fbd9b5fb4c26 ("xen/arm32: head: Remove restriction where to load X= en") > Signed-off-by: Julien Grall Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > xen/arch/arm/arm32/head.S | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S > index 6ca3329138e3..b942e7e54d08 100644 > --- a/xen/arch/arm/arm32/head.S > +++ b/xen/arch/arm/arm32/head.S > @@ -656,6 +656,11 @@ switch_to_runtime_mapping: >=20 > /* Ensure any page table updates are visible before continuing */ > dsb nsh > + /* > + * The function will return on the runtime mapping. So we want > + * to prevent instruction fetch before the dsb completes. > + */ > + isb >=20 > ready_to_switch: > mov pc, lr > --=20 > 2.40.1 >=20 From xen-devel-bounces@lists.xenproject.org Tue Jul 04 14:53:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 14:53:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558458.872574 (Exim 4.92) (envelope-from ) id 1qGhPD-0002mK-3k; Tue, 04 Jul 2023 14:53:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558458.872574; Tue, 04 Jul 2023 14:53:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGhPD-0002mD-03; Tue, 04 Jul 2023 14:53:27 +0000 Received: by outflank-mailman (input) for mailman id 558458; Tue, 04 Jul 2023 14:53:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGhPB-0002m3-LF for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 14:53:25 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2060e.outbound.protection.outlook.com [2a01:111:f400:fe12::60e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 86cd72e6-1a7a-11ee-b237-6b7b168915f2; Tue, 04 Jul 2023 16:53:24 +0200 (CEST) Received: from FR3P281CA0167.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::6) by PR3PR08MB5754.eurprd08.prod.outlook.com (2603:10a6:102:91::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 14:53:22 +0000 Received: from VI1EUR03FT016.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a0:cafe::1d) by FR3P281CA0167.outlook.office365.com (2603:10a6:d10:a0::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.18 via Frontend Transport; Tue, 4 Jul 2023 14:53:20 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT016.mail.protection.outlook.com (100.127.144.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.18 via Frontend Transport; Tue, 4 Jul 2023 14:53:20 +0000 Received: ("Tessian outbound d6c4ee3ba1eb:v142"); Tue, 04 Jul 2023 14:53:19 +0000 Received: from 9e57fe66d626.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DFBF878B-4C3D-4B10-AB23-C6721D1F26B8.1; Tue, 04 Jul 2023 14:53:08 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9e57fe66d626.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 04 Jul 2023 14:53:08 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by GV1PR08MB8452.eurprd08.prod.outlook.com (2603:10a6:150:84::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 14:53:04 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::5e17:39a6:eec7:c482]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::5e17:39a6:eec7:c482%4]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 14:53:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 86cd72e6-1a7a-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XkwcAseB8LlqXiCLqvgL6pdB6Q9BOj6gCp39v1t9gqU=; b=Lt0kzWLKdXwDzaaAgBFqKIkosO7FG9yQbj20UJk99OpTfyTsiRsaOim86P+llrD0c0kkgyCsYy053LpuD1NP37gWpiX/C0R0T/QA928I24G0Njhx28skbW0pryJETuU6+UolMRO4zYsNEWg13iYCefHvitGYY7Rf5E1ACnueiSI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 989a7c2b5bfc43d2 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WwmexbrW8eszM0U1dYuUntJJecs7QUXi92gf91XrzNMORoYxIgS2hPme4pk615XEapl5Ri8lZ7Dp20PfMd23FqvW/ljae8+RMnFYOsvJ8c9dh728gKjH6tYsszu0v2F1u3W+E9w4Ass8BUA/pwwkcyhdojfD8KbOy/k+0lXSVqC8KxlfS9Ki9QJUf04CQ+iJAbuujGdv5MwEmxOHMMUYdJ/8U932c4NpzYvyDMMSObDKx4Cfo7h/Bh4OJPIWxqQpGyOBYfyvvW0agohfYoG8e+3szLPPu+mJRE0ZITFHtk29W7na2lKG3+q19VVpecBo7MlneEq9G8a62zwDl0uq3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XkwcAseB8LlqXiCLqvgL6pdB6Q9BOj6gCp39v1t9gqU=; b=kUm3vtzVUNMXhF38uD99uR0hXk54yS6gQ0pGVtnU3DbnFGKnd/7HA2rJR1p7fawMfJSC63+NqMLZADKWAsuO4AuTuA/XZ0NsuwlZ68Wiw4/C2C8k0B6E5OyQHBBtYoK1X8CKGusTO+Smj5SHIOqDwRf9fohcpNVOx3r0nzJaDHa7VM5tjJWN56Q4IYIOv3Wma+9xD9pVekBra2wK13D6nHRfNHbBD2S++n4SsWyOdndZQcQ2OiUivSmEbv+kvCiP9eA7Raxbk8AcJ9Y0S/th17I/SoeYHDoIpge/PoYkPLmvLq0ZUu1XpR/7yWQt+NoM2fvqLEHWxaioU/43syaqdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XkwcAseB8LlqXiCLqvgL6pdB6Q9BOj6gCp39v1t9gqU=; b=Lt0kzWLKdXwDzaaAgBFqKIkosO7FG9yQbj20UJk99OpTfyTsiRsaOim86P+llrD0c0kkgyCsYy053LpuD1NP37gWpiX/C0R0T/QA928I24G0Njhx28skbW0pryJETuU6+UolMRO4zYsNEWg13iYCefHvitGYY7Rf5E1ACnueiSI= From: Bertrand Marquis To: Julien Grall CC: Xen-devel , Luca Fancellu , "michal.orzel@amd.com" , Henry Wang , Julien Grall , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH 1/7] xen/arm32: head: Add missing isb in setup_fixmap() Thread-Topic: [PATCH 1/7] xen/arm32: head: Add missing isb in setup_fixmap() Thread-Index: AQHZos+47vv7EKE9Uk66+3hYHIyzLa+pyM0A Date: Tue, 4 Jul 2023 14:53:04 +0000 Message-ID: <821C567C-5A15-4FE0-BB7E-50F95A61EDAD@arm.com> References: <20230619170115.81398-1-julien@xen.org> <20230619170115.81398-2-julien@xen.org> In-Reply-To: <20230619170115.81398-2-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.600.7) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|GV1PR08MB8452:EE_|VI1EUR03FT016:EE_|PR3PR08MB5754:EE_ X-MS-Office365-Filtering-Correlation-Id: d4e9183d-04da-4395-357f-08db7c9e687a x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: olPZkW0q9FZbL0V549kpI71l9uLiZDI9mmNMAXHLYUm9XP7/3coT1cRrSm3l2vcf2KJNq8iieypXalMTcrxy4eY2fYVEA+hzus/wZQyfuk2diKpmNzDSKAicnG5rlc0GDfPqPBYBO8glvVB0Ed0QmL386RGI3DRvvPgmpnPAfuTwCMvfw3BXXEOTTAIh7Lt/yrbgqcvO9aqpHC9WsEPDSgO7mJh4zx5C4peINtY+OfPPXRVBqu6vMiNc9X0pLxIqqflciPo07sRgMhJYGTkyhu1/x/HiG7APL0TSQKGypnuWs5HUnhp0Tn3L2n9Ew93Y2VD4B/CjBV7o93aX729onCwxap1I+jHJW9If1z91IgTBzO3v6Tqa1YDFcXc/QTJCrIlQ9eWcKx1/Q332rDpZj4TEWooZuSWi6EWu2dHQh4AcbdAgoVQHfsl05Q6U4iubPao0cUIWb8F7dL6F4Tsy4ADHSk6zSLSVjH5vNP2ZD7o63X/b+nikKVwhs9CL8AHGZ9mkQ6AlR9AUbEx8vwSspeNbXTjfpfk9fB39NacV/uv6vvBuv+1YdCdevoebbKlLQ+akAqtVkruQOlRC+7ae/9obj9TTOck0+OLkQ752DO2d//WUzfr1UE/a7Rc/5YNyaBof5TrSamNoVXGfDl2m9w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(366004)(39860400002)(376002)(396003)(451199021)(4326008)(316002)(66946007)(64756008)(66556008)(86362001)(91956017)(186003)(6916009)(76116006)(66446008)(6512007)(66476007)(6506007)(53546011)(83380400001)(122000001)(2616005)(2906002)(6486002)(38100700002)(33656002)(71200400001)(5660300002)(478600001)(8676002)(54906003)(38070700005)(8936002)(41300700001)(36756003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <7059F9B6D7D0CC4DA5789884CAE70013@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8452 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 65febac4-2b6a-4291-6f23-08db7c9e5f46 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: npFEcwkgv42ZxZkUsh4ruU7eDkKc5t5Qk6Wjpx/pe5bLks8Lu+1Y+/KqHdui8YiSBmL9BvCLlItLM9mgJikakTaqfjABP4CAw2P3s+Sg/tK3qNQXFxxP7ZdLEbGM7mzWz0FVZMIgveGYpsKMBo2AA4nv+FLEGahM0ZlgZ+XWiwRI1fI9hpqvVb917V3aD626RJR8DfqD3qK9+Ob3UR5rJG0+GC0wV+yI2zQcJqYupJz7lR05G/nLtmm/lW2N8cwdvfsicabir7pVFEXZKADApJ9K42SzpQXsm7oESHqsLva8r8tvpB05fRtAzgAjz+wIsalhuA6KtDz1xTMzrsjOLiZKit9ofT9xbqjeB5NDKGkWQ+wY4KOe//nvY95AjuVRnufUC8WAo9RbuamRv1z3BMdcIR5sD3bAQ2BJexpqYZnyfKj2PI9xVkU3Ei1YQvVHiziTibKE9bTFZSMNELADAFDcdT8ot4c5b0rOa8i5h4bk9Kckq0kd8PvXHOXyxn7tIvspCcvKwxnDkqA7V8WngIlfs1TUxepHlq2kzsMQ6tgzPMwDaA977H0sPdv2YHusluPIeVxqo7QSO894fHyhqNwtW3F9FtSHQ1QI7sUcMhkIYNYouSt7wwiF6X0TChimeQmGaDrglm8ya/OFxxzLYLhv6H2kASKF+2UNHx2j8gV3NfIloEaY1tmvoLcXAGEM/tUy+Nzp5W1F2M3sO9pJF2VOMpBC5iQ8d2eOkXyR3IJLvgD2riHOfRo41e3D0+I+ X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(376002)(346002)(396003)(451199021)(36840700001)(40470700004)(46966006)(8676002)(8936002)(54906003)(6862004)(478600001)(26005)(41300700001)(33656002)(36756003)(6486002)(2906002)(5660300002)(86362001)(316002)(40460700003)(70586007)(4326008)(70206006)(6512007)(53546011)(82740400003)(6506007)(356005)(40480700001)(81166007)(2616005)(186003)(83380400001)(336012)(82310400005)(107886003)(47076005)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 14:53:20.1480 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d4e9183d-04da-4395-357f-08db7c9e687a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5754 Hi Julien, > On 19 Jun 2023, at 19:01, Julien Grall wrote: >=20 > From: Julien Grall >=20 > Per the Arm Arm (ARM DDI 0406C.d A3.8.3): >=20 > "The DMB and DSB memory barriers affect reads and writes to the memory > system generated by load/store instructions and data or unified cache > maintenance operations being executed by the processor. Instruction > fetches or accesses caused by a hardware translation table access are > not explicit accesses." >=20 > In setup_fixmap(), we write the fixmap area and may be used soon after, > for instance, to write to the UART. IOW, there could be hardware > translation table access. So we need to ensure the 'dsb' has completed > before continuing. Therefore add an 'isb'. >=20 > Fixes: e79999e587d7 ("xen/arm32: head: Remove 1:1 mapping as soon as it i= s not used") > Signed-off-by: Julien Grall Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > xen/arch/arm/arm32/head.S | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S > index f9f7be9588b1..6ca3329138e3 100644 > --- a/xen/arch/arm/arm32/head.S > +++ b/xen/arch/arm/arm32/head.S > @@ -751,6 +751,11 @@ setup_fixmap: > create_table_entry boot_second, xen_fixmap, r0, 2 > /* Ensure any page table updates made above have occurred. */ > dsb nshst > + /* > + * The fixmap area will be used soon after. So ensure no hardwar= e > + * translation happens before the dsb completes. > + */ > + isb >=20 > mov pc, lr > ENDPROC(setup_fixmap) > --=20 > 2.40.1 >=20 From xen-devel-bounces@lists.xenproject.org Tue Jul 04 14:54:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 14:54:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558464.872584 (Exim 4.92) (envelope-from ) id 1qGhPo-0003MS-En; Tue, 04 Jul 2023 14:54:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558464.872584; Tue, 04 Jul 2023 14:54:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGhPo-0003MJ-CJ; Tue, 04 Jul 2023 14:54:04 +0000 Received: by outflank-mailman (input) for mailman id 558464; Tue, 04 Jul 2023 14:54:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGhPn-0003AZ-NQ for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 14:54:03 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9cc564cb-1a7a-11ee-8611-37d641c3527e; Tue, 04 Jul 2023 16:54:01 +0200 (CEST) Received: from [192.168.1.198] (unknown [151.37.153.202]) by support.bugseng.com (Postfix) with ESMTPSA id 678D24EE0739; Tue, 4 Jul 2023 16:53:58 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9cc564cb-1a7a-11ee-8611-37d641c3527e Message-ID: Date: Tue, 4 Jul 2023 16:53:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [XEN PATCH v6] xen/include: avoid using a compiler extension for BUILD_BUG_ON_ZERO Content-Language: en-US To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, andrew.cooper3@citrix.com, roger.pau@citrix.com, bertrand.marquis@arm.com, julien@xen.org, George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <0b0d9a5614daac653b3bfbcfaa29a9b4c11286bb.1687793572.git.nicola.vetrini@bugseng.com> From: Nicola Vetrini In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 04/07/23 16:24, Jan Beulich wrote: > On 26.06.2023 17:37, Nicola Vetrini wrote: >> Redefine BUILD_BUG_ON_ZERO to avoid using a compiler extension >> that gives an acceptable semantics to C99 undefined behavior 58 >> ("A structure or union is defined as containing no named members >> (6.7.2.1)"). >> >> The first definition includes an additional named field of type >> char. >> >> The chosen ill-formed construct for the second definition is a struct >> with a named bitfield of width 0 when the condition is true, >> which prevents the UB without using the compiler extension while keeping >> the semantic of the construct. >> >> The choice of the bitwise AND operation to bring the result to 0 >> when cond is false boils down to possibly better portability. >> >> Signed-off-by: Nicola Vetrini > > The code change looks okay to me now, but I'd like to double check > towards the testing you did with this change: While it is clear that > you will have checked that the tree builds with the adjustments, I > expect that would have been with a compiler supporting _Static_assert. > Did you also check with an older compiler, using the alternative > implementation? Plus did you also check both constructs for actually > triggering when the supplied condition turns out to be true? > > Jan > Besides using the build pipelines in gitlab, I checked just the macro on Compiler Explorer using gcc 4.4.7 and clang 16 (https://godbolt.org/z/1d6vznxcW) and the construct is behaving as expected. Regards, -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Tue Jul 04 14:55:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 14:55:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558470.872593 (Exim 4.92) (envelope-from ) id 1qGhQv-0003y0-O7; Tue, 04 Jul 2023 14:55:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558470.872593; Tue, 04 Jul 2023 14:55:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGhQv-0003xt-LW; Tue, 04 Jul 2023 14:55:13 +0000 Received: by outflank-mailman (input) for mailman id 558470; Tue, 04 Jul 2023 14:55:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGhQu-0003xn-3E for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 14:55:12 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on061d.outbound.protection.outlook.com [2a01:111:f400:fe1f::61d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c65b6626-1a7a-11ee-b237-6b7b168915f2; Tue, 04 Jul 2023 16:55:11 +0200 (CEST) Received: from AM6P193CA0122.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:85::27) by AS8PR08MB8609.eurprd08.prod.outlook.com (2603:10a6:20b:565::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 14:55:06 +0000 Received: from AM7EUR03FT004.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:85:cafe::d5) by AM6P193CA0122.outlook.office365.com (2603:10a6:209:85::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.31 via Frontend Transport; Tue, 4 Jul 2023 14:55:06 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT004.mail.protection.outlook.com (100.127.140.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.22 via Frontend Transport; Tue, 4 Jul 2023 14:55:05 +0000 Received: ("Tessian outbound 52217515e112:v142"); Tue, 04 Jul 2023 14:55:05 +0000 Received: from c0b47bfc8967.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8AC3ED19-EBC6-420F-B2D8-DE639A925F2F.1; Tue, 04 Jul 2023 14:54:59 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c0b47bfc8967.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 04 Jul 2023 14:54:59 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by GV1PR08MB8452.eurprd08.prod.outlook.com (2603:10a6:150:84::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 14:54:57 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::5e17:39a6:eec7:c482]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::5e17:39a6:eec7:c482%4]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 14:54:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c65b6626-1a7a-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uHPLYVWf3D08zYkdIrDgBPEq07v8K351XpAC2djDhZI=; b=W5u+z2opk/RYO7357EUKwfyTA4TZ2aw0optdcLgbaWarInYm+ZPEfboQfPHeuG0j16v98rn7Sl7uVtpWefDgOrQgG9pEkFsyZGzMX4Iw3b+3Dg+vSTPhjzdzRGvRzYJ5EZqa95iKSfisWgIwlN/XJjwo4+ujopcLvuuHbVZ2tL8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 49c299a67b90dc96 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BsdgMlRJ1B6LEewGfqLgbjXo9jwEEstaDw7DM+T9IrSo8YANPL6DaMp1ILLnmRrsDNaKhpqsK76Dv/eCdxtlaKBal5iFn7u6WeH9An5xNrcPKD51m7ShdF8OdkQ3eJ4IVJHmWDz/9RDVm8X/F/4riHoan4f9989vzSS4a9/4hm4eI9Nai6EGcBi+m7OKpYodjaXEdm4G3S+YXvAmBQZYPO3XA4kab0N9VynZd8id+G4hcNzLIlhcO73xQh/WoEn7Gca3i9s5p2re13SgGIjx6i87J94ehVK7FsAtW40LyAeRKupJ5aEDtC8vQxOE7sxQLFlIk7I6MMthku7brblU0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uHPLYVWf3D08zYkdIrDgBPEq07v8K351XpAC2djDhZI=; b=LhC+7YqZ4hBUZ3+cNI6BjaBEpigVbX8FPjup+MBy2H7BsCXmw0gaAEYzbAbnkPSXrOBPjk8bJhrdNMs7e9c1x+Bvs+u95xkg4wIdgkj1AzGOGacwiycpHkGuXQZikFqTonwC85NCBPSDFTrLiSnqBWXxg9nwz/M0Zgd22FZ+FrWnPSm/frZoLNreVrvbGYlCQgz7P8ja5I54EfjCzXljrglfd1sfFdYocZmoPIj9Nvk5XdUXnExKPnH2SCHltwJ4L8tSOLIn7JyRgZ31YZhWfhxVIFjvYU68YmXfY8jwazf2vM3HmB6VpxjDo8kpuFeQtUWbKXB/g16vZEqrs5GrlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uHPLYVWf3D08zYkdIrDgBPEq07v8K351XpAC2djDhZI=; b=W5u+z2opk/RYO7357EUKwfyTA4TZ2aw0optdcLgbaWarInYm+ZPEfboQfPHeuG0j16v98rn7Sl7uVtpWefDgOrQgG9pEkFsyZGzMX4Iw3b+3Dg+vSTPhjzdzRGvRzYJ5EZqa95iKSfisWgIwlN/XJjwo4+ujopcLvuuHbVZ2tL8= From: Bertrand Marquis To: Julien Grall CC: Xen-devel , Luca Fancellu , "michal.orzel@amd.com" , Henry Wang , Julien Grall , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH 6/7] xen/arm: mm: Add missing ISB in xen_pt_update() Thread-Topic: [PATCH 6/7] xen/arm: mm: Add missing ISB in xen_pt_update() Thread-Index: AQHZos+28SuZIXCU302ZL5lufQv4QK+pyVIA Date: Tue, 4 Jul 2023 14:54:56 +0000 Message-ID: <3BF9CBE5-8EA6-42C4-AE7D-147AB94F3E58@arm.com> References: <20230619170115.81398-1-julien@xen.org> <20230619170115.81398-7-julien@xen.org> In-Reply-To: <20230619170115.81398-7-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.600.7) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|GV1PR08MB8452:EE_|AM7EUR03FT004:EE_|AS8PR08MB8609:EE_ X-MS-Office365-Filtering-Correlation-Id: 55c9ab90-7e79-4249-ab22-08db7c9ea773 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: jhn24/rLu4V3rEulqJYn+yXLpqUVb7NeblU7EN23Ms89QQv2M6DJHOOlAiSE98Y6gzlQDAmfguHSRK4j/FCcaRHdT0ZGGEAGyDPTf6gJ6vOFHZhJjsBSH3H5NeG+ivZRZz6Roj/Cf46Sk+FyhYIufmoNVaET5ZB67qv9dcQk8xM5c2z6KHip8zN9eBI0vRzlIRfQrQsTJALF1N8kelYb0bdwsgSfJSge51KLoBB40+40P/zmfM5pDCI7KQjcC+9j0WnZY+F/jL7JakpaLawqVyu2pAxE8BnqS2LZiS6cSYptXii0K5puiGTMwLVh43yo91BKZyQ1fo9JWzfXBBzRmAZPgO+sLnqtYaktJBBQN8i7S1Ewhp0qd4L9Bm0ZtBt2XufVbsTRJ1Ii+rz3uXU7pdkTqZe/Q+hG6zzPP1+s9aTeQmJbfL3b9MVw842zK8LCELNbkEq+0/Nw/Y6CGTcM//yWiVR/fqd4h9N9mVuXAEby9iYghLK1xWZ1kVMTpL6vZV72Yi5k2DgB60/ROyEE+MhBMIPHsG/dq+YOwDV81mMsYMUNubeyeiX2WV6IJOe/kXRv9IdqHM7qfHdP304P3Sbbz2Q4jtuPqwLMoLjp2fdG+dlgr40srjvGligN7yO9opG9mt+X8tPrpza/kZNmWA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(366004)(39860400002)(376002)(396003)(451199021)(4326008)(316002)(66946007)(64756008)(66556008)(86362001)(91956017)(186003)(6916009)(76116006)(66446008)(6512007)(66476007)(6506007)(53546011)(83380400001)(122000001)(2616005)(2906002)(6486002)(38100700002)(33656002)(71200400001)(5660300002)(478600001)(8676002)(54906003)(38070700005)(8936002)(41300700001)(36756003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8452 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 40929aa7-05e4-4f4c-ea53-08db7c9ea228 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MZSkjVF4SdQWRnk/lcIPyPa3Q32ieJYSh0oe0LZfeaLw/hlPb7MAS79k6kbpe/sYiY+bhf4cQkorZzoH3EgAmbrUq+qv2ZUjl9o3t+31Pkodz4Nsw12I7WQUqV0lMLPTewNumPfNaTUhTkCShAPfpqTWmPgXXJbmJl8LQf+HmJ7Eq0GgdnYvOflNmw/l2qGHMcPJNbHFIawgG6YpiqvfjFq7AtNdS4caPI06wF4/ST4FW/K6lU1eYj2x+zR960H+u1EFuTpA/JpkovaLHe5j3mD57WaQsvh9hnNr+D3m+ip8Le23PY0K0CJ+3Mj6UYPDfnMniNRDcTR/j+JnI9WTIgaPRJirfBpzg1pgcDX259wzm+754rqHQ+VBLm3XzJns5Q1RSVc1RgxJ3fwsOyu1NUYC6oT/zugG94bnmKoZwg0xKMavw15/UkWsXDZ3JmtWKjIiTkl5DRhzWhn59E47aIWNZDBgKyK/wl/waCKqWhGEh7HQ/gtOs3fD/rGZbPvsfhEDrgOnzCliJi2aZIBjUIfr9zllX0nrqE/UFhsg0mSkh5YQYyad06CSJDN6vrUS89K5ffhHZyonKkIq1e0LGwCmuLtvHcYH4IyNTKwlI4b2Ff2SJUyfPWaRmRrzPqyz3NFsU8QRPV7yfzOYD0WhSln0ptNwl+F7Q+QHm10pvCOGk7SCmZz0aumnB5kIkDY2rA0DXQznhdglBDfGAesWBK1MGn8Mu/3o2W9Sw4zZevU4HXC8g/Z/hOenTWrUTPQ5 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(376002)(346002)(136003)(451199021)(40470700004)(46966006)(36840700001)(36860700001)(107886003)(316002)(41300700001)(6512007)(6486002)(26005)(53546011)(47076005)(83380400001)(336012)(6506007)(2616005)(186003)(478600001)(40460700003)(82740400003)(54906003)(356005)(81166007)(70206006)(4326008)(40480700001)(70586007)(5660300002)(33656002)(86362001)(82310400005)(36756003)(6862004)(8936002)(2906002)(8676002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 14:55:05.8640 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 55c9ab90-7e79-4249-ab22-08db7c9ea773 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8609 Hi Julien, > On 19 Jun 2023, at 19:01, Julien Grall wrote: >=20 > From: Julien Grall >=20 > Per the Arm Arm, (Armv7 DDI406C.d A3.8.3 and Armv8 DDI 0487J.a B2.3.12): >=20 > "The DMB and DSB memory barriers affect reads and writes to the memory > system generated by load/store instructions and data or unified cache > maintenance operations being executed by the processor. Instruction > fetches or accesses caused by a hardware translation table access are > not explicit accesses." >=20 > Note that second sentence is not part of the newer Armv8 spec. But the > interpretation is not much different. >=20 > The updated entry will not be used until xen_pt_update() completes. > So rather than adding the ISB after write_pte() in create_xen_table() > and xen_pt-update_entry(), add it in xen_pt_update(). >=20 > Also document the reasoning of the deferral after each write_pte() calls. >=20 > Fixes: 07d11f63d03e ("xen/arm: mm: Avoid flushing the TLBs when mapping a= re inserted") > Signed-off-by: Julien Grall Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > xen/arch/arm/mm.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) >=20 > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c > index e460249736c3..84e652799dd2 100644 > --- a/xen/arch/arm/mm.c > +++ b/xen/arch/arm/mm.c > @@ -779,6 +779,11 @@ static int create_xen_table(lpae_t *entry) > pte =3D mfn_to_xen_entry(mfn, MT_NORMAL); > pte.pt.table =3D 1; > write_pte(entry, pte); > + /* > + * No ISB here. It is deferred to xen_pt_update() as the new table > + * will not be used for hardware translation table access as part of > + * the mapping update. > + */ >=20 > return 0; > } > @@ -1017,6 +1022,10 @@ static int xen_pt_update_entry(mfn_t root, unsigne= d long virt, > } >=20 > write_pte(entry, pte); > + /* > + * No ISB or TLB flush here. They are deferred to xen_pt_update() > + * as the entry will not be used as part of the mapping update. > + */ >=20 > rc =3D 0; >=20 > @@ -1196,6 +1205,9 @@ static int xen_pt_update(unsigned long virt, > /* > * The TLBs flush can be safely skipped when a mapping is inserted > * as we don't allow mapping replacement (see xen_pt_check_entry()). > + * Although we still need an ISB to ensure any DSB in > + * write_pte() will complete because the mapping may be used soon > + * after. > * > * For all the other cases, the TLBs will be flushed unconditionally > * even if the mapping has failed. This is because we may have > @@ -1204,6 +1216,8 @@ static int xen_pt_update(unsigned long virt, > */ > if ( !((flags & _PAGE_PRESENT) && !mfn_eq(mfn, INVALID_MFN)) ) > flush_xen_tlb_range_va(virt, PAGE_SIZE * nr_mfns); > + else > + isb(); >=20 > spin_unlock(&xen_pt_lock); >=20 > --=20 > 2.40.1 >=20 From xen-devel-bounces@lists.xenproject.org Tue Jul 04 14:57:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 14:57:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558474.872604 (Exim 4.92) (envelope-from ) id 1qGhSy-0004Z7-5I; Tue, 04 Jul 2023 14:57:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558474.872604; Tue, 04 Jul 2023 14:57:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGhSy-0004Z0-1x; Tue, 04 Jul 2023 14:57:20 +0000 Received: by outflank-mailman (input) for mailman id 558474; Tue, 04 Jul 2023 14:57:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGhSw-0004Ys-8D for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 14:57:18 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0621.outbound.protection.outlook.com [2a01:111:f400:fe0e::621]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1174e8e7-1a7b-11ee-b237-6b7b168915f2; Tue, 04 Jul 2023 16:57:17 +0200 (CEST) Received: from DB8PR06CA0042.eurprd06.prod.outlook.com (2603:10a6:10:120::16) by PAXPR08MB6480.eurprd08.prod.outlook.com (2603:10a6:102:155::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 14:57:12 +0000 Received: from DBAEUR03FT032.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:120:cafe::1a) by DB8PR06CA0042.outlook.office365.com (2603:10a6:10:120::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.31 via Frontend Transport; Tue, 4 Jul 2023 14:57:12 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT032.mail.protection.outlook.com (100.127.142.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.18 via Frontend Transport; Tue, 4 Jul 2023 14:57:12 +0000 Received: ("Tessian outbound c63645f235c1:v142"); Tue, 04 Jul 2023 14:57:12 +0000 Received: from c98421ae3202.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5A874FAA-909A-4BAE-A394-3CD879AC7C5A.1; Tue, 04 Jul 2023 14:57:01 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c98421ae3202.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 04 Jul 2023 14:57:01 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by GV1PR08MB8452.eurprd08.prod.outlook.com (2603:10a6:150:84::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 14:56:59 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::5e17:39a6:eec7:c482]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::5e17:39a6:eec7:c482%4]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 14:56:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1174e8e7-1a7b-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G3zMTeCLUtM1cEkUBaoYNInhOtFMlJXgNjM4UM4FfTk=; b=Nj2sroJzc8K6gysG1kLxwg4ezx6aAaSC2ieRefuiBhJBwO4WgDzBuZkc+iR7Dqvr/b9X+c5H/7h2R5/pu2Ydqc+fm9Pe4ZoXtCJu7yzNr9jzztLpio/zmLTtRoW/ut6ryr6rjUzz+Ql8m0Ye/mbs+hy8ZIHMnOLBksABhRcyPgI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 0b81cce9aab55068 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LsQWswdpaTupvJYAxEHhIbDSgVfQBhlbaMZ+D7QI+kMhNTQ+4wqNrPzWTphtiprJqpYBG+0ZvPIf1GyQuaeXYwrnzCC/sYd/+SMJ39DiEMcsZW5UUu6nhv0UNyV2df8uACzKCYVPzYiWtQPJdWTroDeOqOwZT85Wx9ZZuCjTklwYw/+pak2rVrJOpeOdiwfOAJ96aU654hFKU9BqjdbYzMgCwZ8LHitv5J6EsqVeX4oKMWkqm4iCv5pFLvRGEX0NyEOv0Tv9RhzelMj/1l3vglCajfpo0p9u7K7LkTw7jFnKvVV7X4b3Mg4icJBkBHwEf/rX2y9hr0EYt6+6qqvQUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G3zMTeCLUtM1cEkUBaoYNInhOtFMlJXgNjM4UM4FfTk=; b=odFkFRYK56ovLcJlI8qE9TuDFsmi8d8OC4P4I9SMrzWqYlf9i3jA8Giszpw+1Ejl51ouZZAxVPGDJ3mRggFjgUVJZCJ5T6nCxYRiJhCEONBegg8+Em2B/Gq6nN5NrmhO1tgcc/YQmRcJEA0Wfnkg9LXmFv60bUHyh9N4HwKoqEwj+Ujqr9nrxCjIY3dTTYNT2OVvc+ikvPo9GdWWKGP5MXJZscHnsQcqNv5Z/s2kPLg3gxLYGDgqKeOIfaGjLnRcJ7T32PuZN+3IBt74EG4B37daVgai5ZL1MWoPBccp70KPjOIFvztsvahs5Cy/an/hBLEKzobB7UGIJdAwJM+l+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G3zMTeCLUtM1cEkUBaoYNInhOtFMlJXgNjM4UM4FfTk=; b=Nj2sroJzc8K6gysG1kLxwg4ezx6aAaSC2ieRefuiBhJBwO4WgDzBuZkc+iR7Dqvr/b9X+c5H/7h2R5/pu2Ydqc+fm9Pe4ZoXtCJu7yzNr9jzztLpio/zmLTtRoW/ut6ryr6rjUzz+Ql8m0Ye/mbs+hy8ZIHMnOLBksABhRcyPgI= From: Bertrand Marquis To: Julien Grall CC: Xen-devel , Luca Fancellu , Michal Orzel , Henry Wang , Julien Grall , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH 5/7] xen/arm: pmap: Add missing ISB in arch_pmap_map() Thread-Topic: [PATCH 5/7] xen/arm: pmap: Add missing ISB in arch_pmap_map() Thread-Index: AQHZos+1XQowzy5c7k+9HVrcbAjL6K+pyeQA Date: Tue, 4 Jul 2023 14:56:59 +0000 Message-ID: <860295F2-1737-4D99-BFAC-C981ADA9AEB7@arm.com> References: <20230619170115.81398-1-julien@xen.org> <20230619170115.81398-6-julien@xen.org> In-Reply-To: <20230619170115.81398-6-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.600.7) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|GV1PR08MB8452:EE_|DBAEUR03FT032:EE_|PAXPR08MB6480:EE_ X-MS-Office365-Filtering-Correlation-Id: 1b9b2757-6f0f-4aec-24f4-08db7c9ef2be x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: +kkvgpOSEn2tkTJGOMrhssg1Fh5qJ4h9lw+OO5JB/7+mN76Eihd6CnsNh5mCQMZxumOQjPMWZqkydwk42o77pw+bv6Zoqq7JddLEGh6SrQmmZiA6xpgNLIuOmuSntd2uWW+sRycABl1GnUXIUofhzFpI6UZ1Wkd8ptn+RxA0T24WkR1RHwrGbkCXix9JM2at/RCW5s4qM0nZA8z3F2f5xoYfXd7g0mwusEfCKvJbfwlvwgcI+XX3CqZhPFkXbv0K9O2CYWvTUd0+4S/0Qj8docWm6ROw2D1+IgrQ+vXhNs0kDERfJiu1QXLevKT6wwA5r7iGgUszJ4q3QGjJm2u2VZaVb1ci7rhrYz0Df7adbijgIijVNQgQZVwGpCOtiP7+JQv1XCb3YxKx95V9hmHXI9tfYdiIRvR8a6UbqNHnXkEgnjd4WutJJaAz5B//hJYfNJXzkHx8pYVRTf3Vjn1esYH23adGdk6kCEObOXHGGNTI9Ns1zkNrQhiBZpdJ7GzRp2CIPLhwx+aIPYwPjpmpMCs5Ju/yHPWuHb8pkdHfBOWy9wU+WQLIFmXqTZOGJHCiOsdOtME1yNv6smnVeZO17LsDmP3rShmAhJ+eV7Tn/U+B4ccwzdN0rW55L/7YtsB5++AuDdCnTDeMS3uzsK97kA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(366004)(39860400002)(376002)(396003)(451199021)(4326008)(316002)(66946007)(64756008)(66556008)(86362001)(91956017)(186003)(6916009)(76116006)(66446008)(6512007)(66476007)(6506007)(53546011)(83380400001)(122000001)(2616005)(2906002)(6486002)(38100700002)(33656002)(71200400001)(5660300002)(478600001)(8676002)(54906003)(38070700005)(8936002)(41300700001)(36756003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <0DC7FE4CADB7DF40BFE413748AD632F9@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8452 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b711e9e1-8ab6-4519-e661-08db7c9eeaf2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o/xxChuR594HJEBm/Mwn30qpR7wMvDodaTCpuDXz8tdH42YQrm3auEA2OmyHFeiQ7qbkkTP5REw2dcqSktFZER4ZeJQoeJOTSDhhvGBC5GQTPMfNQdX1myeQsQZeCWbEHO+pMRPwZhdSbUcgrfk00lM7ZARzMNToAXz95vU1u3rQWZ506Qv1r+4/7ejaf0KxHgTo5/mxqoRElKJ9/06+6OKHA9b6mmzcznSqKfZMyI2DCDrohwbED3x1e5EKlL06uOjRefwaym2cRMAi0klKG3DqHPgKGu6FsUcCUz+opPlz20XhtUnnW3+hJbX6KhM3OMRl+erIcK2aS7BAfZ87TRxuUk0I4gWFAIjLGh6Auk7tEe9IRhKy8iVhZQ+gskLJLbwP4LHVoVjF6Hp10nlhhmKUb5hS1w7w1P59DxdDBTeypKswVTVUKI/AnEnfKN+G7Yr79k/sPCcngZp93hPrENFyf2GqCMMlnFuLgTFXrQBC44PDPLegEOjz9SzhZNkrpH3YpbhLwBOdVgjuFaaJGug5sBlRNK/3aUxeMBuRx5lj5z/9q8SLAc2aID49rLE0DF1HIv2H6SpzVxdJwuPoC1oIzDZAGgtazgossXmHiUZhpvdPJLS86VihCTi5oxLoT/7CT36N+oeWYO2IiWCBk37zRd2PGBjN3lG1eGVmnIRdRkbifle9eyOPSeNnq5lCCpBBZlh/B256deIHZPfRG+84R5xMFHRgeO2Qmf8njRnlxn1ZBgc/K9IIpkT5gSR+ X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(346002)(376002)(136003)(451199021)(46966006)(40470700004)(36840700001)(40460700003)(2906002)(41300700001)(6862004)(5660300002)(8676002)(8936002)(82310400005)(33656002)(36756003)(40480700001)(86362001)(186003)(2616005)(478600001)(26005)(6512007)(6506007)(82740400003)(6486002)(70206006)(47076005)(316002)(70586007)(4326008)(36860700001)(107886003)(53546011)(81166007)(54906003)(336012)(83380400001)(356005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 14:57:12.1969 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1b9b2757-6f0f-4aec-24f4-08db7c9ef2be X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6480 Hi Julien, > On 19 Jun 2023, at 19:01, Julien Grall wrote: >=20 > From: Julien Grall >=20 > Per the Arm Arm, (Armv7 DDI406C.d A3.8.3 and Armv8 DDI 0487J.a B2.3.12): >=20 > "The DMB and DSB memory barriers affect reads and writes to the memory > system generated by load/store instructions and data or unified cache > maintenance operations being executed by the processor. Instruction > fetches or accesses caused by a hardware translation table access are > not explicit accesses." >=20 > Note that second sentence is not part of the newer Armv8 spec. But the > interpretation is not much different. >=20 > As the entry created by arch_pmap_map() will be used soon after > pmap_map() returns, we want to ensure the DSB in write_pte() has > completed. So add an ISB. >=20 > Fixes: 4f17357b52f6 ("xen/arm: add Persistent Map (PMAP) infrastructure") > Signed-off-by: Julien Grall Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > xen/arch/arm/include/asm/pmap.h | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/xen/arch/arm/include/asm/pmap.h b/xen/arch/arm/include/asm/p= map.h > index e094d13dd282..bca3381796f3 100644 > --- a/xen/arch/arm/include/asm/pmap.h > +++ b/xen/arch/arm/include/asm/pmap.h > @@ -15,6 +15,11 @@ static inline void arch_pmap_map(unsigned int slot, mf= n_t mfn) > pte =3D mfn_to_xen_entry(mfn, PAGE_HYPERVISOR_RW); > pte.pt.table =3D 1; > write_pte(entry, pte); > + /* > + * The new entry will be used very soon after arch_pmap_map() return= s. > + * So ensure the DSB in write_pte() has completed before continuing. > + */ > + isb(); > } >=20 > static inline void arch_pmap_unmap(unsigned int slot) > --=20 > 2.40.1 >=20 From xen-devel-bounces@lists.xenproject.org Tue Jul 04 14:58:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 14:58:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558480.872613 (Exim 4.92) (envelope-from ) id 1qGhU8-0005Az-Hg; Tue, 04 Jul 2023 14:58:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558480.872613; Tue, 04 Jul 2023 14:58:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGhU8-0005As-F6; Tue, 04 Jul 2023 14:58:32 +0000 Received: by outflank-mailman (input) for mailman id 558480; Tue, 04 Jul 2023 14:58:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGhU7-0005Am-2f for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 14:58:31 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20627.outbound.protection.outlook.com [2a01:111:f400:7d00::627]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3cd5b9c0-1a7b-11ee-b237-6b7b168915f2; Tue, 04 Jul 2023 16:58:30 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DBAPR04MB7287.eurprd04.prod.outlook.com (2603:10a6:10:1a4::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 14:58:27 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::9bd3:48c9:ff58:9880]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::9bd3:48c9:ff58:9880%4]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 14:58:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3cd5b9c0-1a7b-11ee-b237-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lpW7+gYYXnrZQmFckHZzpUKZzKl01gGtmaFdFelErASWJbLHX1+4L3iU2K/iMCt6v+6p1YC8JumRj64hJsRzf1WcwNnalA9pgK8hvu3UufKm5j5E2GE24TGgskhZ+rSu+AZJ1qfLfMW4RP5ZXGWpdTOaa0jJwgKC+C/tOxdg9f1yZSZ8yXB+XwsewTjI+KeCJPGMwHqYIFnGibBtwrWphvPjSFJ1g5CUxGOfwK6t/gg41nW19Sm2lXgOqf6etJxL4ZYQLAfX2XMFjakNAQuvgiE22587k7AGgfBg3ZchxxL4BTBcEfrTHW+tUTi3NR456Fl+gx5r76mxNdjDJ7WxuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G9jJ7pFCGUg0kAolaJLhlV6C5YYLvflxrUyGM+T3uJU=; b=GLAAjucG6y7Yl4YbRoP5o5p7eUauxGI0GzFUplb96IqwEjp1eUaHM5S1nnsv6OxGv1MnzW5q9q3T1QTNlb4DFuY+yYOAz5+VXIR46tcyTuBab6eJDnvZuF7LF2vM1HUSZ9l1l+c7p9mf8wwvt/MLwi6LMXiMLitA3orZo3eKS90ano2JvaljWXNt0NjaLhluDgvs5w/zY4yP+u9QN0eFRe2UsCATOzp/G8xnQtRVXEHt/eOOfhxdTtILcQVr0J7KHa0W9fHJwm4Q30Fii+9Gmm5c2JHqVdWK9q5eugq2g3dd8iGrCrBRLNT6p23cj8SKZx0j2InkbGn+ido5KtGWTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G9jJ7pFCGUg0kAolaJLhlV6C5YYLvflxrUyGM+T3uJU=; b=uCFiIxssNsOyP2V2vt7ruVuOjV86n6z2J9qPkt+kDKaxmqiCbOtF13o42Gz1Re0tks7+5s5d61yVKJ3+aMZe9VX/DdzCnaftESTlE8O1xRoWC325FDFmII1VDwPAxejDWrhpQo6hlq9CYRdaVTVww29Z42afGRlSrtuLaY9mEA+jTdEvw2sRozs1EMaQJaG9fu6TnrreahW+AEL+YnpljkzQOf7XsFYSekMOpAyfPIY4oxcIK44S47TRFPQflHJzxmSlw9qJVLeCNPxSBu+9BeoRO5V+W0q9KJcTMeUSBC3T5MAUdQLx7wI+j6s1HIe0GXbApO7XBfOxzxMuavP3BA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <27e570a7-f247-0de1-9289-c604db442c9b@suse.com> Date: Tue, 4 Jul 2023 16:58:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [XEN PATCH v6] xen/include: avoid using a compiler extension for BUILD_BUG_ON_ZERO Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, andrew.cooper3@citrix.com, roger.pau@citrix.com, bertrand.marquis@arm.com, julien@xen.org, George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <0b0d9a5614daac653b3bfbcfaa29a9b4c11286bb.1687793572.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0185.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9f::18) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DBAPR04MB7287:EE_ X-MS-Office365-Filtering-Correlation-Id: e306d0d7-d3a6-435a-d295-08db7c9f1f7b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: R6T0CCUgI/BSTjlIS0nWQzdmEOeTutaG6DA4OArL36V4U5SRICD3CBEtoTvy0pH57V5pyWBXd/He2nU/GE0VytkkzsYz6hiMcwUM+Bs+z0A/DueDza22EBG8UQhhv9tta0MxY9yLt2bSOv1i1xVCI5bJSpSzwuI9NP4f/mT1yZ17fKKgdjF2Y8K45jFCRHSOVQkJO144RnV93nwTsKHJ6JHMP5LoWkdYzSD/dv2FiFdSrTSF8stICGJz1WLxZC/twmdEVLthhi9jnASUjTy/GOGkqoUDM9aESl9xr/JfEi+fC8XeUr3fdXrtZMiXBr7hdhvTVPM5lzlJqBNplXGojFEZQRabI82D+ZzkYVVCgmUDlCyL/+IbxBEvN621LxH3hpyl8piFJhs/dCsCn3TKZdu681WV4KcsV8+ZCyBdWIufS63yQkUKHcJO29vEyYmJqRyzT94gpxckxsUtHtPY8oj6ZUgsyHCdw7tR8ivmCCzYesGNbOaG3Rnf0yqUG/7/vnUpdmaIv4jQqUwBmYRHwS0ZPLyG8pZvD+15PUWfGELnlFU4cCkFHRYSuwUuNAkpDUAPz17wCtSv0afR2rSsRPK3fjJjB3zmIu8MUxeGbWRPXP6QNS5hz377ceQksLTU X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(396003)(39850400004)(136003)(376002)(366004)(451199021)(2906002)(41300700001)(7416002)(5660300002)(8676002)(8936002)(36756003)(86362001)(31696002)(6512007)(6666004)(6486002)(478600001)(83380400001)(26005)(186003)(53546011)(2616005)(4326008)(31686004)(66556008)(54906003)(6916009)(66476007)(6506007)(66946007)(316002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WUhyUjN3bHJLRFVoOHc4NUEvdE9YTWRlclZPRzVjaThRREZkRDAxQmRWVUlj?= =?utf-8?B?czQxS0FqU1hpY2FnRXJkZEpmTkJrS0dQU2NlMkN5WHVmRWVlSlpMUGpkTXBt?= =?utf-8?B?aDRXUTNTQ21LTWFlNkpKS05LZnlXUExERUFUYlRXMmZJbTRCM3BiUUJoRXBn?= =?utf-8?B?a2lQRytOUXZsOU9IMEs4ZldZeDU2VTJYK0U0dW5JTXdudkFFRjhJU20xRUtZ?= =?utf-8?B?LzNPVHBVU0x0allqK01RTmg3QmprVzVWelcyQWJyNGFGZ2ZyL0NCZkR6aDcv?= =?utf-8?B?eWhPRUxuRUh4Y1dkNHFuNFJVY2NkS2hEWHNyem81eUlqVmVySjJXajl5THkw?= =?utf-8?B?cnJqQmNzRFkxUDRJNUpxN0VDSTc0REpic3hmSXQyRUFOaUR3MXBvNEFJekRJ?= =?utf-8?B?azNaczhwMnkxZUIzZDRDWm5Ua2lTWEpWRWtpTzB6SmpIUExkdVBvc2tTRXJT?= =?utf-8?B?VnBjUEQraUsva0Y0UldQVXZyYWgrMG5zWFgvWlBKajJubk95WXJUaWdZK3VJ?= =?utf-8?B?SlUxSGFmUzB1TW5oZ21JRzg4OVVqQ29KUG5qL3kxV3VLa0FFUVNTcVlaWENK?= =?utf-8?B?cDdZSzhMQlhHS1VIYjVyMUxYWkRUMVMybkJiQWlTUnVkWFg3U29Rek95ckxt?= =?utf-8?B?MjR0V3VEeERoQytZVzA1MFFqSHlvZGdnTWVaN1ZKdnZUYlZxeExybUQvSXA5?= =?utf-8?B?bFdvU1dGRTYyTHBmeWcyVlQ5ZzgreDdFMmo0eVlZRGpOSXlaZzlKb1VicmVw?= =?utf-8?B?MXY3eEoyTnUxSlg2OUo1YktpTFdjWjQxbzByK1JHOFNjdXZxNmF3dmdnTkZy?= =?utf-8?B?T20xSVhMSFcwMzJMd3BVdGVjeUROb3luYzNLWjM0dElla1NydEoxb3hYZWRB?= =?utf-8?B?RnJYNzBGWi9ZbVlHbWpLYisxeE9vNFBJbE00b1JlNmVZUnJLNmN4KzJuZWNn?= =?utf-8?B?TzZPellRM0dmWkpwNFhpRkhaeUo2OFJsb1NYNTZ3Y2V4WUlZZkphK1YySHN4?= =?utf-8?B?N2c2T3pWdUlVbGpIQlpKZURZVjA5QUgrT0p0NkVsQmhSRjM4VXc4MnBxTlR0?= =?utf-8?B?VlBLZjBSdjdiaUhkMmcwSmVxN2haL0Y0TWJPYkgyL2JIamRIYnJaTU40dWJa?= =?utf-8?B?ZGpTeWpjOUJpUDEzT1RldVpsZzJMWmJYbGpJb3l5a0xZSURDSHRFbnQzQmxw?= =?utf-8?B?WUc4SlRYUUZTS3VhS1kyOXhpVUZ6cytpUHlrTmQwSEZRSlR1WEgxODg3blhh?= =?utf-8?B?cFVueUZBTTB3L0FTcWo3YTVKQTRLOExHTHE3VDMyMS9CejZITW9lQmV4aWt4?= =?utf-8?B?dlJNUmVIcTNRV09EVnZUUTNUQTZCSlBQODBoWTdxOTVqZEI4bTlkUGVOY0FS?= =?utf-8?B?U040d0hvTEhiTDRyWDU5dmU2SGpnY0R0SnQyWUJua3FINzRQUmVvYUJJem45?= =?utf-8?B?eExJaEdMbTFNT3NBTTVwQTlvNU1LT1BlVXRZY2ZzMXIzdXdDcFliSUVnVXYy?= =?utf-8?B?aXlNMkthcGc0U1pIUVpvREx2VzFTaFdEcU9HSk9Tc25zUDlBMmY5L2NvdElG?= =?utf-8?B?QnNJMEV2dDk2UkNaUXZVRkIzeWQvcFdpNmxhRW03VXpRVnRyenY4czZWNGpO?= =?utf-8?B?MG95c3ZPZk53UjVnNVBQKzJpdytxcy9senFjKzN6elVZVVJKb0hmdGZuOFdJ?= =?utf-8?B?NXEvS1dPNGVlcVppNzV3cDBzRUM4ZjRuUWJjWHp0MVhIa1lwL1pab2dtOUNt?= =?utf-8?B?ZHdxckF2bXdMUFUyQmErdWxnNlk2bW9QcXZ4eFFTeVVtZUsvYVArV2hoaWRu?= =?utf-8?B?ZFZhM2ZpdGFTRmFBOGVqNnV6b0V1aDYvM0FKU0JCc1Rwb3JvQ0gwSmhJeXc3?= =?utf-8?B?WmUyZzA0aUg5cDdEYmlVMmh0ZXovRXd0REdUUU51RDdPcEVaamZRcTRBbm1w?= =?utf-8?B?bGloYVA3WGFod1laZ21XbnJ2TFNoLytQM1BhdHRLT2dIb1kyUWluRWpmSDg3?= =?utf-8?B?cC9jOUdGS3Mzbm0vejRKWnFweTRVdmp0R0pQWm9TcHlRaW9vWDd5MjlMOC9i?= =?utf-8?B?N1N6NFZSb2dvY0tqQmlSSUhMUFh6ODc1VjFsc0syRjkzOVkyMzBoN1VSWjRE?= =?utf-8?Q?4XdzH0Z2yQ4xrJNXvHOEqRHcq?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e306d0d7-d3a6-435a-d295-08db7c9f1f7b X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 14:58:27.4040 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: f3xt7dDpOyLCYyD3yQE+4RSMQrHMdwggb7hpeNOzSDI2OX/wts7lL3ysDXLd4ROm0ZN64gMJEKzlocnJQhUHjw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7287 On 04.07.2023 16:53, Nicola Vetrini wrote: > > > On 04/07/23 16:24, Jan Beulich wrote: >> On 26.06.2023 17:37, Nicola Vetrini wrote: >>> Redefine BUILD_BUG_ON_ZERO to avoid using a compiler extension >>> that gives an acceptable semantics to C99 undefined behavior 58 >>> ("A structure or union is defined as containing no named members >>> (6.7.2.1)"). >>> >>> The first definition includes an additional named field of type >>> char. >>> >>> The chosen ill-formed construct for the second definition is a struct >>> with a named bitfield of width 0 when the condition is true, >>> which prevents the UB without using the compiler extension while keeping >>> the semantic of the construct. >>> >>> The choice of the bitwise AND operation to bring the result to 0 >>> when cond is false boils down to possibly better portability. >>> >>> Signed-off-by: Nicola Vetrini >> >> The code change looks okay to me now, but I'd like to double check >> towards the testing you did with this change: While it is clear that >> you will have checked that the tree builds with the adjustments, I >> expect that would have been with a compiler supporting _Static_assert. >> Did you also check with an older compiler, using the alternative >> implementation? Plus did you also check both constructs for actually >> triggering when the supplied condition turns out to be true? > > Besides using the build pipelines in gitlab, I checked just the macro on > Compiler Explorer using gcc 4.4.7 and clang 16 > (https://godbolt.org/z/1d6vznxcW) and the construct is behaving as expected. Great, thanks for confirming. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 04 15:07:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 15:07:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558484.872623 (Exim 4.92) (envelope-from ) id 1qGhc8-0006id-Bo; Tue, 04 Jul 2023 15:06:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558484.872623; Tue, 04 Jul 2023 15:06:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGhc8-0006iW-96; Tue, 04 Jul 2023 15:06:48 +0000 Received: by outflank-mailman (input) for mailman id 558484; Tue, 04 Jul 2023 15:06:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGhc7-0006iQ-Hb for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 15:06:47 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20627.outbound.protection.outlook.com [2a01:111:f400:7e1b::627]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 64613b99-1a7c-11ee-b237-6b7b168915f2; Tue, 04 Jul 2023 17:06:45 +0200 (CEST) Received: from AM6PR01CA0064.eurprd01.prod.exchangelabs.com (2603:10a6:20b:e0::41) by PAXPR08MB7335.eurprd08.prod.outlook.com (2603:10a6:102:220::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 15:06:38 +0000 Received: from AM7EUR03FT048.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:e0:cafe::c9) by AM6PR01CA0064.outlook.office365.com (2603:10a6:20b:e0::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.30 via Frontend Transport; Tue, 4 Jul 2023 15:06:36 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT048.mail.protection.outlook.com (100.127.140.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.18 via Frontend Transport; Tue, 4 Jul 2023 15:06:35 +0000 Received: ("Tessian outbound d6c4ee3ba1eb:v142"); Tue, 04 Jul 2023 15:06:35 +0000 Received: from c17341142ecd.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 06E7BC79-D510-41C9-8947-F1EAE4B343A8.1; Tue, 04 Jul 2023 15:06:29 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c17341142ecd.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 04 Jul 2023 15:06:29 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DBBPR08MB5961.eurprd08.prod.outlook.com (2603:10a6:10:203::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 15:06:25 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::5e17:39a6:eec7:c482]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::5e17:39a6:eec7:c482%4]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 15:06:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 64613b99-1a7c-11ee-b237-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FU32I2cFGzf+P1C8PpjK9M/cr0oKEjt/SRWxHv1gNHI=; b=cBb/LtmpyO1l9kXjNxIUAnX+QiDXsRB3xNOvmvaf9LdMymGCmj0J78ghFhrMGUCj9I0OpiJFfXzcLXnOaKtN+YqRBxpbOZiaYMqM/P/LLtetCbWyiDba92Aj097j74xcwOzQDOBJ7CyNN4kQnfn4S4jh3tvriIwEF9EtrYR50M8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 70e0c79b1e6a516f X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bs6QHnMoLAGCEJgczTAZpxoMwNBi4QraMjQUFNff4a4ba7GyTSUhH/AsWDQaKpaRRiROjMt2Sqjp5rw7JZ4GIlxKVgAlf4jHqbivtXoP6csegLsam8BAtz6NKHXQxGGmXGX4cLgX9X20UReqC96Ne49fPcuVtKdv+dpgHHhprG1/g1Si3Ndz0E8iUfVygU3+6auM3mVUQOYQG8xKg8dNCjKGXIN2WN+Zx6O92CkC+s0eSUZittfjyKgmUp/WPo1J9sQNMVF2pIsMU2URt8sCXS0n/VHw+pASqtl4M1ag3DTQvA+wlEtfS8Vcnm068h1FikN+qwsY9ch2srjXCDEhhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FU32I2cFGzf+P1C8PpjK9M/cr0oKEjt/SRWxHv1gNHI=; b=WB5Wayxadwfl/yZHtwhePJV6HRyg8NL/iUEFl3OaK8ZwXrIz+Ij78Xf8mHjo06sQ0hquldGiW34dWqQy70JpL+LN2S8ANO5fTJ92fxW/LyShlw3XuZJfJWyTY0YfQ7y/QmTDy0zTvF7wS9IfX4CmGWUtQqNdW7hulfFgps7JoqVm1PEefDW+bD6ABx6es+IeCh2CA7dahI1LSBG6yLR9Y1C8XjuYXAQ4Px2b8CwTytdiIK8lXWiVer6gNjHHJhoR7A5fiZntWWr498CzZ4bNGtPye6e1Z3WY3B9VE6X0LUu97DICikFTI2VcSnptmS0q3j29Zlfhn0xIDLJxWlQxMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FU32I2cFGzf+P1C8PpjK9M/cr0oKEjt/SRWxHv1gNHI=; b=cBb/LtmpyO1l9kXjNxIUAnX+QiDXsRB3xNOvmvaf9LdMymGCmj0J78ghFhrMGUCj9I0OpiJFfXzcLXnOaKtN+YqRBxpbOZiaYMqM/P/LLtetCbWyiDba92Aj097j74xcwOzQDOBJ7CyNN4kQnfn4S4jh3tvriIwEF9EtrYR50M8= From: Bertrand Marquis To: Julien Grall CC: Xen-devel , Luca Fancellu , Michal Orzel , Henry Wang , Julien Grall , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH 4/7] xen/arm: page: Consolidate write_pte() and clarify the documentation Thread-Topic: [PATCH 4/7] xen/arm: page: Consolidate write_pte() and clarify the documentation Thread-Index: AQHZos+4vw3nnvONG0uaFwZBq/1j9K+pzIYA Date: Tue, 4 Jul 2023 15:06:24 +0000 Message-ID: <49DB9A64-FB34-4EAB-9E6D-3C445B1790E4@arm.com> References: <20230619170115.81398-1-julien@xen.org> <20230619170115.81398-5-julien@xen.org> In-Reply-To: <20230619170115.81398-5-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.600.7) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|DBBPR08MB5961:EE_|AM7EUR03FT048:EE_|PAXPR08MB7335:EE_ X-MS-Office365-Filtering-Correlation-Id: 52c9ca3d-468e-4831-b9b2-08db7ca042ba x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: SP8Q72wI619PZqFV6foA1kqRtkC2B4KoRmS2c66OW6D+KI8mD7RAHLDjjfBfQw9ENcrs91z8jHwEWVCUiu4XNt4s6PY9POZtzbmquC9guEdXLPpd44k0Tb4fL7dmU3Magn58k1nh1qE9hwxNYQtbqveTH+QxrhUQEMChNWNYqG0FJW4Lqnwyerw9lwHKUrZTtjQzeOECsPCyJHTuQqJQW0AqQu2ULHTSsEThFu01r2ggfS7C+obBHM815x9SIfr5/BU5gljuBiD1RwSZLNGKfHKj47EShCeaP0oD1uDOm/H4vjRnZNVuPazEbaesnEaSZmlPPvfAwekavTrY9DflZsfjdcRmmjGLrT5P1ZkSpmNblsrff4b4yYI1Ki4H/X9qRtRbCefKEIhQhr6EdKZOD1H2gX8BlyBVBNoHgaPiC7xCyRi0Wql7gYQgZcZdmMlybqRRKnt1g1GRWg2mMGDNun2/tFuBCC5OXKUbX5TTuaWwf2h5W7XPZDnr4qGN3jCDijyIz5gFRiUfMqWansm4MYKGtSOnCHYi1Yq60ieRNFfoAEQcF9ie1VjWtrGISKiY7qyB2P6TJONAtJAKqOxwRCIiKrbDjw9z+7F+TwyhZTkZ4vMmHVfQeZXLuqPNas49LKwNvD4bpmMA39I3TGIUTg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(396003)(346002)(366004)(136003)(451199021)(38100700002)(33656002)(2906002)(71200400001)(6486002)(8936002)(38070700005)(8676002)(54906003)(36756003)(41300700001)(5660300002)(478600001)(76116006)(6916009)(66946007)(66556008)(66476007)(64756008)(53546011)(91956017)(66446008)(6512007)(186003)(6506007)(86362001)(4326008)(316002)(2616005)(122000001)(83380400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5961 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5429e24f-18a2-4d7a-16ed-08db7ca03c34 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9y+fj45XcbaR58tqI+IfxeBRARnGhfgc5wNBiLuNcpgnbd/O129mn4k1+uh9EeFd2JiIkxrMi5tJ1P5BR0aV8mJm31duABdIjiwJyT0btNoUL9wYQMUysaKczpSQ5zFywnig48o7JEv31qIYSkAfPKmEctzgdAlspbnmvYHN2WIQcq2dMHsVLgVxKUcNY/ESruD9v9YJ7RPNb22pXXX54EolOcnZwuHRASirsnq5WCOksQxE1cq85iEv6sPId/j1cvuwWsgkCahOvyPIBfg8ik+J+uqEtMQaHlsyDla0X7mCB+RhjXWrVn+vNsX4H23snkfWudzlxQUorRPRbpWx9pBW5TgoZ6RlEsBHrfj7/aRcmMK+96znHNVJ2PKj++mJhfGztSFsaM7Ntj1xrDrWtfe//oclqSlmU82o+FyRf2j2bTFyzhpVmSvKuMgFIvtPeyNPtitbk84G2EHhEgVd2ovJjInTA+iNmHDSNNxA+RYl9Z2mqNowy678KY0cuM/C14gHkEyHdAvxe3aVVLlvB+Ims9n5vENs5wq0KMiJYxSkZGZwHctPxu4SqReanDccRhuO8XXoHuF8SSaHghW8fsC629QtvtdJR9SpBePbAR+Xn6yGW5e4n28BFizJwukcS1JfIqTsBi4XWtD7pD+67TMIPQ179FgOm5iglZMUq//1xDqVH6WV7MExGbtHegOUjDNfNcvtjKs3Fu/SXxNQW+iYNtFn2inLQ0xW+T6uCpUIP2K/w9YAlFGghyiADNOX X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(376002)(396003)(39860400002)(136003)(346002)(451199021)(40470700004)(36840700001)(46966006)(54906003)(2906002)(478600001)(26005)(41300700001)(86362001)(6486002)(33656002)(6862004)(8936002)(8676002)(5660300002)(36756003)(316002)(40460700003)(70586007)(70206006)(4326008)(6512007)(53546011)(6506007)(82740400003)(356005)(40480700001)(81166007)(2616005)(186003)(83380400001)(82310400005)(336012)(107886003)(47076005)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 15:06:35.8421 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 52c9ca3d-468e-4831-b9b2-08db7ca042ba X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7335 Hi Julien, > On 19 Jun 2023, at 19:01, Julien Grall wrote: >=20 > From: Julien Grall >=20 > The implementation of write_pte() is pretty much the same on arm32 > and arm64. So it would be good to consolidate it as this would help > to clarify the requirements when using the helper. >=20 > Take the opportunity to switch from assembly to call macros. Note there > is a difference on arm32 because the option was not specified. But this > meant 'sy' (system wide). >=20 > Futhermore, the requirements for the ISB is incomplete. Per the Arm Arm, > (Armv7 DDI406C.d A3.8.3 and Armv8 DDI 0487J.a B2.3.12), DSB will only > affect explicit accesses. So an ISB is necessary after DSB to ensure > the completion. Having an ISB after each update to the page-tables is > probably too much, so let the caller add the instruction when it is > convenient. >=20 > Lastly, the barrier in write_pte() may be too restrictive but I haven't > yet find the proper section(s) in the Arm Arm. I do not think we will find any proper section for that in the Arm Arm as i= t depends on use cases. In ours we might have the page table shared among cores so I think system is the way to go. >=20 > Signed-off-by: Julien Grall Reviewed-by: Bertrand Marquis Cheers Bertrand > ---- >=20 > I am a bit split on whether we should add an ISB in write_pte(). It > would make easier for the developper, but would likely force a pipeline > flush too often. >=20 > It might also be possible to drop the ISB (and even DSB) when updating > stage-2 PTE (Linux already does it, see 120798d2e7d1). But I am not sure > this is worth it in Xen. > --- > xen/arch/arm/include/asm/arm32/page.h | 16 ---------------- > xen/arch/arm/include/asm/arm64/page.h | 11 ----------- > xen/arch/arm/include/asm/page.h | 17 +++++++++++++++++ > 3 files changed, 17 insertions(+), 27 deletions(-) >=20 > diff --git a/xen/arch/arm/include/asm/arm32/page.h b/xen/arch/arm/include= /asm/arm32/page.h > index 715a9e4fef48..6d1ff0636ce3 100644 > --- a/xen/arch/arm/include/asm/arm32/page.h > +++ b/xen/arch/arm/include/asm/arm32/page.h > @@ -3,22 +3,6 @@ >=20 > #ifndef __ASSEMBLY__ >=20 > -/* Write a pagetable entry. > - * > - * If the table entry is changing a text mapping, it is responsibility > - * of the caller to issue an ISB after write_pte. > - */ > -static inline void write_pte(lpae_t *p, lpae_t pte) > -{ > - asm volatile ( > - /* Ensure any writes have completed with the old mappings. */ > - "dsb;" > - /* Safely write the entry (STRD is atomic on CPUs that support L= PAE) */ > - "strd %0, %H0, [%1];" > - "dsb;" > - : : "r" (pte.bits), "r" (p) : "memory"); > -} > - > /* Inline ASM to invalidate dcache on register R (may be an inline asm op= erand) */ > #define __invalidate_dcache_one(R) STORE_CP32(R, DCIMVAC) >=20 > diff --git a/xen/arch/arm/include/asm/arm64/page.h b/xen/arch/arm/include= /asm/arm64/page.h > index 0cba2663733b..4f58c0382adc 100644 > --- a/xen/arch/arm/include/asm/arm64/page.h > +++ b/xen/arch/arm/include/asm/arm64/page.h > @@ -5,17 +5,6 @@ >=20 > #include >=20 > -/* Write a pagetable entry */ > -static inline void write_pte(lpae_t *p, lpae_t pte) > -{ > - asm volatile ( > - /* Ensure any writes have completed with the old mappings. */ > - "dsb sy;" > - "str %0, [%1];" /* Write the entry */ > - "dsb sy;" > - : : "r" (pte.bits), "r" (p) : "memory"); > -} > - > /* Inline ASM to invalidate dcache on register R (may be an inline asm op= erand) */ > #define __invalidate_dcache_one(R) "dc ivac, %" #R ";" >=20 > diff --git a/xen/arch/arm/include/asm/page.h b/xen/arch/arm/include/asm/p= age.h > index e7cd62190c7f..ea96983ab976 100644 > --- a/xen/arch/arm/include/asm/page.h > +++ b/xen/arch/arm/include/asm/page.h > @@ -126,6 +126,7 @@ > #include > #include > #include > +#include > #include >=20 > #if defined(CONFIG_ARM_32) > @@ -237,6 +238,22 @@ static inline int clean_and_invalidate_dcache_va_ran= ge > : : "r" (_p), "m" (*_p)); \ > } while (0) >=20 > +/* > + * Write a pagetable entry. > + * > + * It is the responsibility of the caller to issue an ISB (if a new entr= y) > + * or a TLB flush (if modified or removed) after write_pte(). > + */ > +static inline void write_pte(lpae_t *p, lpae_t pte) > +{ > + /* Ensure any writes have completed with the old mappings. */ > + dsb(sy); > + /* Safely write the entry. This should always be an atomic write. */ > + write_atomic(p, pte); > + dsb(sy); > +} > + > + > /* Flush the dcache for an entire page. */ > void flush_page_to_ram(unsigned long mfn, bool sync_icache); >=20 > --=20 > 2.40.1 >=20 From xen-devel-bounces@lists.xenproject.org Tue Jul 04 15:08:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Jul 2023 15:08:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.558488.872634 (Exim 4.92) (envelope-from ) id 1qGhdA-0007EK-MH; Tue, 04 Jul 2023 15:07:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 558488.872634; Tue, 04 Jul 2023 15:07:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGhdA-0007ED-IX; Tue, 04 Jul 2023 15:07:52 +0000 Received: by outflank-mailman (input) for mailman id 558488; Tue, 04 Jul 2023 15:07:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qGhd9-0007Dw-Bc for xen-devel@lists.xenproject.org; Tue, 04 Jul 2023 15:07:51 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on061e.outbound.protection.outlook.com [2a01:111:f400:fe1f::61e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 89633b69-1a7c-11ee-8611-37d641c3527e; Tue, 04 Jul 2023 17:07:48 +0200 (CEST) Received: from DUZPR01CA0054.eurprd01.prod.exchangelabs.com (2603:10a6:10:469::10) by DU0PR08MB9418.eurprd08.prod.outlook.com (2603:10a6:10:421::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 15:07:44 +0000 Received: from DBAEUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:469:cafe::b2) by DUZPR01CA0054.outlook.office365.com (2603:10a6:10:469::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.30 via Frontend Transport; Tue, 4 Jul 2023 15:07:44 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT059.mail.protection.outlook.com (100.127.142.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.18 via Frontend Transport; Tue, 4 Jul 2023 15:07:43 +0000 Received: ("Tessian outbound e2424c13b707:v142"); Tue, 04 Jul 2023 15:07:43 +0000 Received: from c0e9f1f422c8.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 003ECCB4-2662-4C60-9CE2-388EF62B9B1E.1; Tue, 04 Jul 2023 15:07:37 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c0e9f1f422c8.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 04 Jul 2023 15:07:37 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DBBPR08MB5961.eurprd08.prod.outlook.com (2603:10a6:10:203::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 15:07:35 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::5e17:39a6:eec7:c482]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::5e17:39a6:eec7:c482%4]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 15:07:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 89633b69-1a7c-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kZ9n2SLEFfFbZqCFLUdAAKLUSzQfFzQj04NveNWSbto=; b=NvzxOigJrrQr8WLdECho050ezlCmrEk0TpZSikGLaFzIJSGCTItZUOs4EpPAx26ny8/yv5pQ7t186cypenXvfsYvoCqkfn4VEpoHbEqOuaf5BGsliKb8WAOM5YGF/aBU6wLVWo7CDzuNDKBVFlTMnobAuSwyF014yDM/UtOCwN8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: b3f8b296c4d158d3 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QEn3F3jeMgIoZ8f41tXbsYpr2X0ec2PnnIe+MM2+Q1xg+QTnwN7TppoRL6024d/NeHojfkX78NukNgAf6LsSYMp+2q6Lg1kgmgtD8hc/HdAJoRn3kb0HBrPeUCylwXmCFUxEvAGW49bGq9c+ji/PTHFZrty1gJz9trA7wQkuCMJjfZwvq7gAntUeW2+TZzV40KBI3wxPY5Aubp59UIe+Q7M4yeOSQhkZTUr7y9eoXql2OZba4a996KUI/2KEoant/ibWjG/aOqtNEWcfh3H6cL/M2f92yzqbXEIwltILLpUtNtrSCJIIGXKnhl+OwJ7TGmPySvTajT0y3uB7G0Kv0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kZ9n2SLEFfFbZqCFLUdAAKLUSzQfFzQj04NveNWSbto=; b=X/s8aN9GRgLbWQyD1Nh9r51lbHJ2zeLnbImWbl6O9EUFPu+bH0Fnien4LMdO8CCiDsajPUbMhrVSU3tvWmOkl1oujvTHizmayVPouvk0AlEmrh0mBy2EwNEDw7pxeneQjwQmPcPzNBjd5JuOJV8yvjiNqRooS4fyPMqz/K2HsMO2fC9kfQKSQn4UtgO7cjX/ani8cMH3WuYZ9ifG8A64js/k00nqmNhWI1qqFp0vi22B8Ch0K84gkmaey6RUaoCIVgcm8XiIm+ZnLhfZxbheVQxrymRyQvVmcdaYNTp52K2myKP7jCl8H9vvT4GoxBLEN9LmeE7HfepzWWlAFm//Rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kZ9n2SLEFfFbZqCFLUdAAKLUSzQfFzQj04NveNWSbto=; b=NvzxOigJrrQr8WLdECho050ezlCmrEk0TpZSikGLaFzIJSGCTItZUOs4EpPAx26ny8/yv5pQ7t186cypenXvfsYvoCqkfn4VEpoHbEqOuaf5BGsliKb8WAOM5YGF/aBU6wLVWo7CDzuNDKBVFlTMnobAuSwyF014yDM/UtOCwN8= From: Bertrand Marquis To: Julien Grall CC: Xen-devel , Luca Fancellu , Michal Orzel , Henry Wang , Julien Grall , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH 7/7] xen/arm32: head: Widen the use of the temporary mapping Thread-Topic: [PATCH 7/7] xen/arm32: head: Widen the use of the temporary mapping Thread-Index: AQHZos+8ihLpFUQE50qML8qllPzK9a+pzNoA Date: Tue, 4 Jul 2023 15:07:34 +0000 Message-ID: <47AF0004-BA7D-4C7B-B5F5-DBD7E53D3CC0@arm.com> References: <20230619170115.81398-1-julien@xen.org> <20230619170115.81398-8-julien@xen.org> In-Reply-To: <20230619170115.81398-8-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.600.7) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|DBBPR08MB5961:EE_|DBAEUR03FT059:EE_|DU0PR08MB9418:EE_ X-MS-Office365-Filtering-Correlation-Id: 29c48eed-a753-45a9-af26-08db7ca06b4c x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: LT350dYF4wv4BQQq8N77g8LCc2Nk4GuX+yXSyR2ZSpGdiV21XF730MIx7DxuFE24CsC424tAXYpAyuR+v7DyAebd+Cn8Ai3M9oVwegoDQljZ/e+EhyVBx0+ClVRFlhIHyL3HAP2KuVtD+xA31khW8xCZK6RyCZeenHRur6M+mf1BLI+6XAwsM9LQ8pmj0gpmrPUYRblzE7pOT/JSWyXO9RqlwXHWkzV7kMx1fqyxwvSE/3ocR4XQXvuiFQ7JwT1Zy8hdcIm1M7GV8SnFld9TwLqf2G8dlHM0LsR0IfRVA3rZUFmKHY0sKHOXkiI41spm5emNgStmPkKKlYqUSmqtIbQoqg65m9ijRyx4uUZ7SRdrJBGtfJCd7/+Tn6Tc+pCTF5UnfCRw6ILPSScZw1h14bII6FKjg25R/Day4UNZulTyq4hXuQWkPnvqnuuEgzPaiUIyLgOV/z1eaRW6rvAvTnrga9y0R1pCftQX2h04W+ElvZHC/mmIMr9hbvn2nyShjWCNzQXpvRUO8mfdEy2Y/wFR94cjRHV/CLO/RZ+wRm0QFOeL2pUvJCEulFCovwHL3/OCSXzq0UE/+n9qbi8EApTDtrmgXq/9e7K63E9vuCPnqhJuezbggqfgmWxC36jfvGSP2bCrGYT96weBERiwdA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(396003)(346002)(366004)(136003)(451199021)(38100700002)(33656002)(2906002)(71200400001)(6486002)(8936002)(38070700005)(8676002)(54906003)(36756003)(41300700001)(5660300002)(478600001)(76116006)(6916009)(66946007)(66556008)(66476007)(64756008)(53546011)(91956017)(66446008)(6512007)(186003)(6506007)(86362001)(4326008)(316002)(966005)(2616005)(122000001)(83380400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <219EF33B08E60242B906872E177C0963@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5961 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 888ac3f6-07cc-44e2-3e58-08db7ca065e3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RFqTeaKI9lHQT/9kllU+UquY9rRHERqASyuhI0N6HolC7UsfpzR3xh5aDZ6x9uAPZg1mMV44+/OF9QVPmrhMo8gIKJWJyHZ6L3R2wQstUpSihmTDmNzrGC5YMKbSWbMEc1oQruPAZXqIhU0jloGxPwEiPXZsTEihXVuYX0RL1ub63POyAoL/9j5H12TEjKRKZehH3/9YoPMr991RcYWacFowa3EYUcEw02ooxQaR/FNvFnvLlKui6FUO2UBP1XaYbUjw0Jv6DVSOoH9ZW47q16ow4DJA3B2dI9xB8EtpzSCVSfrySSkia4ZSpAFHrQfBo6xl9cGpN5b0k+ww11QyEwWs3H9tnIuI0g2swGa9z7xz5g1OSBjPcIWJB1E6h2sjG0E+isH1bWtFBS7LyAizLAxiLRWXejsk7LbGkI9yBZGcDURB84i4zcWAbKKbmWMXtQQRSQwrX2PsvC2nmrmS4GU3s1p2vdSsLPX0zbCA96lJxblClFGlIMeCtSLTGtXmqZJ841XKnMI8G+s0RLSU1dVwidTG2DH/2JRd0G+pcATg/N/3WMS+dUTYlo2LjW7tOf7UgXYMuVHCgYqlEEDUu7fUqp4AhpdI2KaGv5HRxKBG9RV3nfSzB0xFw8+vwrLWFmbNKWpEqB0Fkb4T8PRyCeYQ1nDD1zfZIqd4FKDCgkO5WTzCYkqG4WQpvucDB0vreiq69kHb4jSzs/7lM+sMZcPTOeawz5vRrXbfVLgBpAU= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(376002)(396003)(39860400002)(451199021)(36840700001)(46966006)(40470700004)(4326008)(316002)(86362001)(186003)(70206006)(70586007)(26005)(6512007)(47076005)(6506007)(53546011)(107886003)(82740400003)(83380400001)(81166007)(966005)(2616005)(356005)(2906002)(6486002)(33656002)(36860700001)(5660300002)(336012)(478600001)(6862004)(8676002)(54906003)(40480700001)(40460700003)(82310400005)(8936002)(41300700001)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 15:07:43.9700 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 29c48eed-a753-45a9-af26-08db7ca06b4c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9418 Hi Julien, > On 19 Jun 2023, at 19:01, Julien Grall wrote: >=20 > From: Julien Grall >=20 > At the moment, the temporary mapping is only used when the virtual > runtime region of Xen is clashing with the physical region. >=20 > In follow-up patches, we will rework how secondary CPU bring-up works > and it will be convenient to use the fixmap area for accessing > the root page-table (it is per-cpu). >=20 > Rework the code to use temporary mapping when the Xen physical address > is not overlapping with the temporary mapping. >=20 > This also has the advantage to simplify the logic to identity map > Xen. >=20 > Signed-off-by: Julien Grall > Reviewed-by: Henry Wang > Reviewed-by: Michal Orzel Acked-by: Bertrand Marquis Cheers Bertrand >=20 > ---- >=20 > This patch was originally part of [1] but it was reverted due to > Xen not booting on the Arndale. The first patch of this series > is fixing it (confirmed by booting on the Arndale). So I am including > this patch. Also all the tags but the tested-by have been kept > because the code has not changed. Happy to drop any if there are > any concerns. >=20 > [1] https://lore.kernel.org/xen-devel/20230416143211.72227-1-julien@xen.o= rg/ >=20 > Changelog from the previous series: >=20 > Changes in v6: > - Add Henry's reviewed-by and tested-by tag > - Add Michal's reviewed-by > - Add newline in remove_identity_mapping for clarity >=20 > Changes in v5: > - Fix typo in a comment > - No need to link boot_{second, third}_id again if we need to > create a temporary area. >=20 > Changes in v3: > - Resolve conflicts after switching from "ldr rX,
--000000000000cf1dc906004a5728-- From xen-devel-bounces@lists.xenproject.org Wed Jul 12 13:43:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Jul 2023 13:43:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.562512.879221 (Exim 4.92) (envelope-from ) id 1qJa7q-0006y2-Oz; Wed, 12 Jul 2023 13:43:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 562512.879221; Wed, 12 Jul 2023 13:43:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qJa7q-0006xJ-Jr; Wed, 12 Jul 2023 13:43:26 +0000 Received: by outflank-mailman (input) for mailman id 562512; Wed, 12 Jul 2023 13:40:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qJa4x-0006si-BE for xen-devel@lists.xenproject.org; Wed, 12 Jul 2023 13:40:27 +0000 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [2001:67c:670:201:290:27ff:fe1d:cc33]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a71556b8-20b9-11ee-8611-37d641c3527e; Wed, 12 Jul 2023 15:40:25 +0200 (CEST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJa31-0003SA-EH; Wed, 12 Jul 2023 15:38:27 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1qJa2f-00DtzU-Hf; Wed, 12 Jul 2023 15:38:05 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qJa2e-004JeB-NH; Wed, 12 Jul 2023 15:38:04 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a71556b8-20b9-11ee-8611-37d641c3527e Date: Wed, 12 Jul 2023 15:38:03 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Maxime Ripard Cc: Heiko =?utf-8?Q?St=C3=BCbner?= , Geert Uytterhoeven , Xinliang Liu , Linus Walleij , Tomi Valkeinen , Alexey Kodanev , dri-devel@lists.freedesktop.org, Vandita Kulkarni , Alim Akhtar , Anitha Chrisanthus , Marijn Suijten , Jonathan Hunter , Arun R Murthy , Jerome Brunet , Liu Shixin , linux-samsung-soc@vger.kernel.org, Samuel Holland , Matt Roper , Wenjing Liu , Javier Martinez Canillas , Stanislav Lisovskiy , Danilo Krummrich , NXP Linux Team , spice-devel@lists.freedesktop.org, Niranjana Vishwanathapura , linux-sunxi@lists.linux.dev, Stylon Wang , Tim Huang , Suraj Kandpal , =?utf-8?B?QW5kcsOp?= Almeida , Andi Shyti , Yifan Zhang , Jani Nikula , Sascha Hauer , Lucas De Marchi , Inki Dae , Hersen Wu , Jessica Zhang , Kamlesh Gurudasani , Bhawanpreet Lakha , =?utf-8?Q?=C5=81ukasz?= Bartosik , Radhakrishna Sripada , Andrew Jeffery , Seung-Woo Kim , Noralf =?utf-8?Q?Tr=C3=B8nnes?= , kernel@pengutronix.de, Alex Deucher , freedreno@lists.freedesktop.org, Claudiu Beznea , Zack Rusin , Gerd Hoffmann , Alexandre Belloni , linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, Mitul Golani , =?utf-8?B?Sm9zw6k=?= Roberto de Souza , virtualization@lists.linux-foundation.org, Thierry Reding , Yongqin Liu , Mario Limonciello , Fei Yang , Ville =?utf-8?B?U3lyasOkbMOk?= , David Lechner , Julia Lawall , Juha-Pekka Heikkila , "Jiri Slaby (SUSE)" , David Francis , Aaron Liu , Patrik Jakobsson , Vinod Polimera , linux-rockchip@lists.infradead.org, Fangzhi Zuo , Aurabindo Pillai , VMware Graphics Reviewers , Ben Skeggs , Jouni =?utf-8?B?SMO2Z2FuZGVy?= , Dave Airlie , linux-mips@vger.kernel.org, Maxime Coquelin , Gurchetan Singh , Martin Blumenstingl , linux-arm-msm@vger.kernel.org, Animesh Manna , linux-renesas-soc@vger.kernel.org, Jani Nikula , Chaitanya Kumar Borah , Biju Das , linux-amlogic@lists.infradead.org, Evan Quan , Michal Simek , linux-arm-kernel@lists.infradead.org, Sean Paul , Neil Armstrong , Kai Vehmanen , Boris Brezillon , Chunyan Zhang , Qingqing Zhuo , Sandy Huang , Swati Sharma , John Stultz , Paul Kocialkowski , Kyungmin Park , Drew Davenport , Kevin Hilman , Hawking Zhang , Haneen Mohammed , Anusha Srivatsa , Dan Carpenter , Karol Herbst , Joonas Lahtinen , linux-hyperv@vger.kernel.org, Stefan Agner , Melissa Wen , =?utf-8?B?TWHDrXJh?= Canal , Luca Coelho , Laurent Pinchart , Andrzej Hajda , Likun Gao , Sam Ravnborg , Alain Volmat , Xinwei Kong , Jernej Skrabec , Deepak Rawat , Chen-Yu Tsai , Joel Stanley , Philipp Zabel , Ankit Nautiyal , Harry Wentland , Sumit Semwal , Alan Liu , Philip Yang , Lyude Paul , intel-gfx@lists.freedesktop.org, Alison Wang , Wolfram Sang , Abhinav Kumar , Gustavo Sousa , Baolin Wang , Rodrigo Vivi , Mikko Perttunen , Tvrtko Ursulin , Rodrigo Siqueira , Tomi Valkeinen , Deepak R Varma , "Pan, Xinhui" , Chia-I Wu , Konrad Dybcio , Kieran Bingham , Tian Tao , Shawn Guo , Christian =?utf-8?B?S8O2bmln?= , Khaled Almahallawy , linux-stm32@st-md-mailman.stormreply.com, Emma Anholt , Chun-Kuang Hu , Imre Deak , Liviu Dudau , Alexandre Torgue , Roman Li , Paul Cercueil , Rob Clark , Hamza Mahfooz , David Airlie , Marek Vasut , Jiapeng Chong , xen-devel@lists.xenproject.org, Guchun Chen , Oleksandr Andrushchenko , Raphael Gallais-Pou , Rodrigo Siqueira , Russell King , Leo Li , Uma Shankar , Mika Kahola , Jiasheng Jiang , Srinivasan Shanmugam , Thomas Zimmermann , Vinod Govindapillai , linux-tegra@vger.kernel.org, Marek =?utf-8?B?T2zFocOhaw==?= , Maarten Lankhorst , =?utf-8?Q?Joaqu=C3=ADn_Ignacio_Aramend=C3=ADa?= , Melissa Wen , Hans de Goede , linux-mediatek@lists.infradead.org, Fabio Estevam , Laurentiu Palcu , Matthias Brugger , David Tadokoro , AngeloGioacchino Del Regno , Orson Zhai , amd-gfx@lists.freedesktop.org, Jyri Sarha , Yannick Fertre , Nicolas Ferre , Krzysztof Kozlowski , Philippe Cornu , Daniel Vetter , Wayne Lin , Dmitry Baryshkov , Nirmoy Das , Lang Yu , Lucas Stach Subject: Re: [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev Message-ID: <20230712133803.rf26cbg5wz7wsmgl@pengutronix.de> References: <20230712094702.1770121-1-u.kleine-koenig@pengutronix.de> <94eb6e4d-9384-152f-351b-ebb217411da9@amd.com> <20230712110253.paoyrmcbvlhpfxbf@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="aip3kulofrfujcj7" Content-Disposition: inline In-Reply-To: X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: xen-devel@lists.xenproject.org --aip3kulofrfujcj7 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Maxime, On Wed, Jul 12, 2023 at 02:52:38PM +0200, Maxime Ripard wrote: > On Wed, Jul 12, 2023 at 01:02:53PM +0200, Uwe Kleine-K=F6nig wrote: > > > Background is that this makes merge conflicts easier to handle and de= tect. > >=20 > > Really? >=20 > FWIW, I agree with Christian here. >=20 > > Each file (apart from include/drm/drm_crtc.h) is only touched once. So > > unless I'm missing something you don't get less or easier conflicts by > > doing it all in a single patch. But you gain the freedom to drop a > > patch for one driver without having to drop the rest with it. >=20 > Not really, because the last patch removed the union anyway. So you have > to revert both the last patch, plus that driver one. And then you need > to add a TODO to remove that union eventually. Yes, with a single patch you have only one revert (but 194 files changed, 1264 insertions(+), 1296 deletions(-)) instead of two (one of them: 1 file changed, 9 insertions(+), 1 deletion(-); the other maybe a bit bigger). (And maybe you get away with just reverting the last patch.) With a single patch the TODO after a revert is "redo it all again (and prepare for a different set of conflicts)" while with the split series it's only "fix that one driver that was forgotten/borked" + reapply that 10 line patch. As the one who gets that TODO, I prefer the latter. So in sum: If your metric is "small count of reverted commits", you're right. If however your metric is: Better get 95% of this series' change in than maybe 0%, the split series is the way to do it. With me having spend ~3h on this series' changes, it's maybe understandable that I did it the way I did. FTR: This series was created on top of v6.5-rc1. If you apply it to drm-misc-next you get a (trivial) conflict in patch #2. If I consider to be the responsible maintainer who applies this series, I like being able to just do git am --skip then.=20 FTR#2: In drm-misc-next is a new driver (drivers/gpu/drm/loongson/lsdc_crtc.c) so skipping the last patch for now might indeed be a good idea. > > So I still like the split version better, but I'm open to a more > > verbose reasoning from your side. >=20 > You're doing only one thing here, really: you change the name of a > structure field. If it was shared between multiple maintainers, then > sure, splitting that up is easier for everyone, but this will go through > drm-misc, so I can't see the benefit it brings. I see your argument, but I think mine weights more. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --aip3kulofrfujcj7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmSurLsACgkQj4D7WH0S /k4sEwf/UuiwqpRpFkDoh5EhwtXKdh8XLT/EutMDLIG+CdmIF7NPxvR+ZXgiD5e9 BaYtiZNivy0cfbUas4l0w7WekMbHw5MsVttULAGgUP4sLLJ8c2njon3k5JWJA8z4 W3AKDPJ/uwAYPmFY0mElfTsvDoy/x4EdJqeF7fbHlwdk5NHXWh/7Csw6b4jJBLC2 ucmM2LxhSR6awQqbXnd/MXgkIap0fsy40En7wKq6B/B3pECguPZg8cChiztq8mVa /8DEhoDQWgJ2YzBcMhE+nW+4G/hc51psOIylkBMhZFrvmXZMwMFv+g7UDIJ4jp/N 4A1ksamP+GbxqozqipxuHSgGp3+6dQ== =UcVQ -----END PGP SIGNATURE----- --aip3kulofrfujcj7-- From xen-devel-bounces@lists.xenproject.org Wed Jul 12 13:52:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Jul 2023 13:52:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.562526.879235 (Exim 4.92) (envelope-from ) id 1qJaGl-0000cN-OR; Wed, 12 Jul 2023 13:52:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 562526.879235; Wed, 12 Jul 2023 13:52:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qJaGl-0000cG-Ln; Wed, 12 Jul 2023 13:52:39 +0000 Received: by outflank-mailman (input) for mailman id 562526; Wed, 12 Jul 2023 13:52:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qJaGj-0000c8-Ng for xen-devel@lists.xenproject.org; Wed, 12 Jul 2023 13:52:37 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on20620.outbound.protection.outlook.com [2a01:111:f400:7eab::620]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5a7619a3-20bb-11ee-b239-6b7b168915f2; Wed, 12 Jul 2023 15:52:35 +0200 (CEST) Received: from DS7PR03CA0108.namprd03.prod.outlook.com (2603:10b6:5:3b7::23) by DM3PR12MB9288.namprd12.prod.outlook.com (2603:10b6:0:4a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.31; Wed, 12 Jul 2023 13:52:31 +0000 Received: from DM6NAM11FT075.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b7:cafe::6f) by DS7PR03CA0108.outlook.office365.com (2603:10b6:5:3b7::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.22 via Frontend Transport; Wed, 12 Jul 2023 13:52:30 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT075.mail.protection.outlook.com (10.13.173.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6588.22 via Frontend Transport; Wed, 12 Jul 2023 13:52:30 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 12 Jul 2023 08:52:29 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 12 Jul 2023 08:52:29 -0500 Received: from ubuntu.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.23 via Frontend Transport; Wed, 12 Jul 2023 08:52:27 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a7619a3-20bb-11ee-b239-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lnXw4M11PL8zadG8PaiPgh4k09kVjzgt+3UUF/CmMVpPkuLUQy1OJ9UfJAzC+K3atqx7JxjH5txa4BwmMW6t+41OVuO1OPK0QDkVX0zGqveBnCOSvh/HhVq91qZ0NqQmfTU5kvUI6uXcpOZjOu919TbPrWlmz1cL9HCyPN2/uwxuMllZ7AOmgJCCDca6d/cpuvjZhIJf8sEktiipFNfJqBsEkvH+T+4YOXEXshsBGxyyreihmR12qsyO3J+3otSHA0wXeWC08Qvok577q4unEClhNAWD6VzZKKgfJIwNhl/lX0nx8NuH/9v220bKsrmIqhzQlaiAnfoxNn+xL/4JLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qq36jgKCRrcIt4jf2b+WTJ8T8S9NB90WpaGx93hStms=; b=Wyb7wNscKOgaeMfpi/yJsTIDur8M1tWOvTKvnh3u+RzcnBy5iunXVAON2lPQkZ3/mqyBs+H7ek7saVXSxgBu0vHFemp9rUFBM6H41vwFHqXkJgxm/xoB6DU+Zy2ihh9EhIk02+hERuydDMZcZTax5CzCmW3f/E9dFzOVOsF8ZenHKYKF7DtGzMcTSJq6wjEDkeoHpv0+2MT1dFjJi4FfAs9DWEu59uEqBNn9gphnX9bj1jxH5ZZ0No1TIXBBt9G1jubGgZRfq5pUAgvrO6ep//9nYRo/zhXYe52xw2V3DkqWwu7sS+pGn3kqmV8/XknYX1kdeybn1xh2ITrWzF7+kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qq36jgKCRrcIt4jf2b+WTJ8T8S9NB90WpaGx93hStms=; b=X3PWyxCgNodNpxMFFVOXrgyDGJI5gD13sxreH+VQuRrKxLq4y5FAnnbV3z35N5tqRKhy0TW8edxaeEEeud+sYxkBigA4Uloha8Y1P27T7FIh6eXuBmHDhS9OzfLzlH72uSKJjhPRrCmlF4CIc7zDIPZhLa1Jv2V+kqR8YkSJhwI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Stewart Hildebrand To: CC: Stewart Hildebrand , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Rahul Singh , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v3] xen/arm: pci: fix check in pci_check_bar() Date: Wed, 12 Jul 2023 09:52:21 -0400 Message-ID: <20230712135226.747472-1-stewart.hildebrand@amd.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT075:EE_|DM3PR12MB9288:EE_ X-MS-Office365-Filtering-Correlation-Id: f1aea321-8392-459e-28d9-08db82df3c59 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JpNQohC8DzYwVsCqLd4o/KuuTLOqa3WzLAfDelsws91pcBPdJBYxqYIC4AUPbnI8NFvOWN1hyiZYOCyMv3CWadTuuwzbQgPXlybZZTzTfUeH0pWUI09F+TYeNItc/xBHq2T1JKcZuNP8HYRTghf/T2wwGRW89X7k41Tb7pnzV6hpK9woh6DbmINUxcDBYfVjtQclaGvH1iMJdFZ62RygUmMAGRAKbO8yRUdiuEEjz7q4BR89T2sIkHOzfV2zHeFvrHImraFG4l+FjL3/Hfo2dTdk+o9uSnBRrgg9VAHeUvoadSw/PDMwqH3Gc1mTXHUoJjmRvjlJGOGyI0Tj1GlG4msj3lzKiI8VuaeYn0Ub3mZbqUlbEBlKB+sVM6m2A7hVP3NL5L5xA6lNxu8+XvFIYBAyQ6fz/rDT8SroFjB1dusgO2+0cl0wGor/Hagsrfb/SVORap5J0DygAX4acOi5nEg5lRYEnqc8KjfmcSxvsdcA7s7fIDJ6O6JDqGOCMUdh6VZ48K61WbhJ+RcoEbUMv8XTq2P1dD/FO5eUzMssTTbFjDl59/gjJGfms7ItYKeVLPppLnMGYxQ5Y3T4qk6684/A70fLmK5AdULaTU+6ZOd0yYIxAUGtGG4j/z0tzscWoQAzXFLUt9OEnC1+dZwDm9YWuGNu634iaTLTdnu67qog0caQsI4b8A4Nv9Wh7gbOxVhgaxGCROIXy2YvBwg7/Y6iaKiEG8PuPWGlZxzDXi7yhuiAO30limox7TteONjVMx/nhhI5J2Y/p5ofiD9ljA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(376002)(39860400002)(396003)(451199021)(40470700004)(46966006)(36840700001)(82740400003)(356005)(81166007)(83380400001)(186003)(2616005)(1076003)(426003)(336012)(26005)(40480700001)(47076005)(36860700001)(44832011)(2906002)(5660300002)(36756003)(478600001)(6666004)(316002)(54906003)(8676002)(6916009)(86362001)(70206006)(8936002)(70586007)(4326008)(41300700001)(40460700003)(82310400005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 13:52:30.4069 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f1aea321-8392-459e-28d9-08db82df3c59 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT075.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR12MB9288 When mapping BARs for vPCI, it's valid for a BAR mfn_t start to equal the BAR mfn_t end (i.e. start == end) since end is inclusive. However, pci_check_bar() currently returns false in this case, which results in Xen not mapping the BAR in the guest 2nd stage page tables. In this example boot log, Linux has mapped the BARs in the 1st stage, but since Xen did not map them in the 2nd stage, Linux encounters a data abort and panics: [ 2.593300] pci 0000:00:00.0: BAR 0: assigned [mem 0x50008000-0x50008fff] [ 2.593682] pci 0000:00:00.0: BAR 2: assigned [mem 0x50009000-0x50009fff] [ 2.594066] pci 0000:00:00.0: BAR 4: assigned [mem 0x5000a000-0x5000afff] ... [ 2.810502] virtio-pci 0000:00:00.0: enabling device (0000 -> 0002) (XEN) 0000:00:00.0: not mapping BAR [50008, 50008] invalid position (XEN) 0000:00:00.0: not mapping BAR [50009, 50009] invalid position (XEN) 0000:00:00.0: not mapping BAR [5000a, 5000a] invalid position [ 2.817502] virtio-pci 0000:00:00.0: virtio_pci: leaving for legacy driver [ 2.817853] virtio-pci 0000:00:00.0: enabling bus mastering (XEN) arch/arm/traps.c:1992:d0v0 HSR=0x00000093010045 pc=0xffff8000089507d4 gva=0xffff80000c46d012 gpa=0x00000050008012 [ 2.818397] Unable to handle kernel ttbr address size fault at virtual address ffff80000c46d012 ... Adjust the end physical address e to account for the full page when converting from mfn, at which point s and e cannot be equal, so drop the equality check in the condition. Note that adjusting e to account for the full page also increases the accuracy of the subsequent is_bar_valid check. Fixes: cc80e2bab0d0 ("xen/pci: replace call to is_memory_hole to pci_check_bar") Signed-off-by: Stewart Hildebrand Reviewed-by: Roger Pau Monné --- v2->v3: * re-word commit message slightly * add Roger's R-b v1->v2: * adjust e to include full page (e is still inclusive) * add comment at the top of the function to document that end is inclusive --- xen/arch/arm/pci/pci-host-common.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c index 7cdfc89e5211..c0faf0f43675 100644 --- a/xen/arch/arm/pci/pci-host-common.c +++ b/xen/arch/arm/pci/pci-host-common.c @@ -393,20 +393,24 @@ static int is_bar_valid(const struct dt_device_node *dev, return 0; } -/* TODO: Revisit this function when ACPI PCI passthrough support is added. */ +/* + * The MFN range [start, end] is inclusive. + * + * TODO: Revisit this function when ACPI PCI passthrough support is added. + */ bool pci_check_bar(const struct pci_dev *pdev, mfn_t start, mfn_t end) { int ret; const struct dt_device_node *dt_node; paddr_t s = mfn_to_maddr(start); - paddr_t e = mfn_to_maddr(end); + paddr_t e = mfn_to_maddr(mfn_add(end, 1)) - 1; /* inclusive */ struct pdev_bar_check bar_data = { .start = s, .end = e, .is_valid = false }; - if ( s >= e ) + if ( s > e ) return false; dt_node = pci_find_host_bridge_node(pdev); base-commit: 0a834e953b01ec25c412369d7a5b8b57d340ac60 -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Wed Jul 12 13:54:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Jul 2023 13:54:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.562532.879246 (Exim 4.92) (envelope-from ) id 1qJaIL-0001Ah-7q; Wed, 12 Jul 2023 13:54:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 562532.879246; Wed, 12 Jul 2023 13:54:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qJaIL-0001Aa-4E; Wed, 12 Jul 2023 13:54:17 +0000 Received: by outflank-mailman (input) for mailman id 562532; Wed, 12 Jul 2023 13:54:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qJaIJ-0001AU-Ro for xen-devel@lists.xenproject.org; Wed, 12 Jul 2023 13:54:16 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 94adb952-20bb-11ee-8611-37d641c3527e; Wed, 12 Jul 2023 15:54:13 +0200 (CEST) Received: from mail-mw2nam12lp2040.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.40]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 12 Jul 2023 09:54:05 -0400 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) by DM4PR03MB5999.namprd03.prod.outlook.com (2603:10b6:5:38a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.20; Wed, 12 Jul 2023 13:54:00 +0000 Received: from SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::fb95:b992:be69:7fa2]) by SJ0PR03MB6423.namprd03.prod.outlook.com ([fe80::fb95:b992:be69:7fa2%5]) with mapi id 15.20.6565.028; Wed, 12 Jul 2023 13:54:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 94adb952-20bb-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1689170053; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=vCdrEdqrufE4zBgy5pmd7cjq7Z6h7Nt5UN56pxCJ8MY=; b=fU+9Q0j3+KZZIFkqTchnW9JkQMCkiDWKdl/h+i0KjVWcqEnuyk+xHkDn VNpecqbe9jMzWP3Oi8QRilohEjNWrLrai/fcZynK4zRdtMN/0B9kf24Vk AVz146DEA6cVETFVXLK+xjMhZ5t3n/Qx5yWLOsLCU7WivnI90RwNWDRsF g=; X-IronPort-RemoteIP: 104.47.66.40 X-IronPort-MID: 114683009 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Gk3fpqip1lEgwsxT5xB3Zaf3X161RxEKZh0ujC45NGQN5FlHY01je htvDziPO/ncNmagKI9zadvi/R4EusLXzYdnGgRt+CwwES0b9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsx+qyr0N8klgZmP6sT4waEzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQSESJcQEqi3tmt/++GYe13tp5zCo70adZ3VnFIlVk1DN4AaLWaGeDv2oUd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilIvluS1WDbWUoXiqcF9hEGXq 3iA523kKhobKMae2XyO9XfEaurnxHqnBtJJTOXpnhJsqHu19mMUNDhKbwL4qtOdpkq/adJbc 2VBr0LCqoB3riRHVOLVXRe1vXqFtR40QMdLHqsx7wTl4rXQyxaUAC4DVDEpQMwrsoo6SCIn0 neNnsj1Hnp/vbuNU3Wf+7yI6zSoNkAowXQqYCYFSU4A/IPlqYRq1BbXFI4/SOiyk8H/Hiz2z 3aSti8iir4PjMkNkaKm4VTAhDHqrZ/MJuIo2jjqsquexlsRTOaYi0aAsDA3Md4owF6lc2S8 IronPort-HdrOrdr: A9a23:6HVvkKtMF2iUxA/SnBOBLISI7skDWtV00zEX/kB9WHVpm6uj+v xG/c526faQslwssR4b+OxoVJPwJk80lqQU3WByB9mftWDd0QOVxedZnPLfKlbbak/DH4Bmup uII5IUNDSJNykdsS7HijPIcOrJ/7O8gcSVrPabxX9oVAlrZaYl7woRMHf/LnFL X-Talos-CUID: 9a23:YPeRDmDpfC/Ab+/6EyNe5h86QOF8SWbikUr7J1SIUzZPD6LAHA== X-Talos-MUID: 9a23:GVHK+ATEmDKIiexsRXTKogFtM/tNv573S0sntbkCuvuEMXRZbmI= X-IronPort-AV: E=Sophos;i="6.01,199,1684814400"; d="scan'208";a="114683009" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BokNYzyCHaeJApe/xvdhvpjQdl8kwyhpqmBEwUmnIimatjxAaa8Zikt/hQ3iXJ4M1Ca5+i40QBcvyuXs/7ZWf/BSeFSUGiCXhBZX7GvJe7Vx1ZdkW4+vtdy+hoD/Fln71P44CNclHRQqO+wtgarCYrtGsaYaC2H93Unje735vsaQvQIps9cJCqrSazYBAurSw0IrF4mOpimBsIEU5SY18KLEaWCgt8yBIXjVr0HXL5iXiZN6iSCZB9DPdofnQbmJwW3uLkJAlUnp8iGSVntfNs5IYhNt75DAdQr4O5M6qXVx7GWVjo634qrX/ctQjJEVy+MH/r9rbMFSsVCe6SfGWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m/vQOwoWy4tF03DCtwjLc3AtsQSOcYWmuL0vQhZhTms=; b=LIuYEkFs8hYAGa12vV9hbTO/9U4ti6wK32gs7KPL62opTIloiBXT7Tk417QT+/TESJNx5p7PxWW0Cos6bV4m581CLTAeH/MQy/m7s318q3pu55eEtDFiGK1ij5S/RyOh/TeZURQdvE95wgSC8Oj0/ryyDqE+s378/vZFsX+lRqmKEGtEhGFN9sGYWWiM19+0C5h8LYIE8GWhju0IVMus0S9F21bzAmdmHVqKNkuOf671cZ+uV7AuYSCz5DHRU5N+UUoSVKIF9JJlZ2l4cqarGVbQkJLWrzlViVre4Hstc8ydWoVexPS7k5I7OJBySgWH62eybFaoSDwrQPBOryPmvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m/vQOwoWy4tF03DCtwjLc3AtsQSOcYWmuL0vQhZhTms=; b=tB8Xcv6+NCfJI3S2GnTOV8la7IowLwmmG+As+4d4Iu1v3oq8pmiBOAn8gL7CgUJgc6y8nltDaEV1QR2FveRDzzBZxl8QfxaGi5X8tvh9ZRjZwrdQD/8C8LflZYFe24rC8q/1ucVF42tl+hw2GGnankYaI11Q9YEkUmlAyDwQDAc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 12 Jul 2023 15:53:54 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH] x86/ioapic: sanitize IO-APIC pins before enabling the local APIC Message-ID: References: <20230707095338.44244-1-roger.pau@citrix.com> <92d16012-ff9f-693b-07c6-d45fe07a00a0@suse.com> <1f79491a-46f5-5293-e92f-0e2b0b3efb62@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P302CA0018.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:2c1::14) To SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6423:EE_|DM4PR03MB5999:EE_ X-MS-Office365-Filtering-Correlation-Id: fab9ef08-7ef7-48ef-69aa-08db82df717d X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: R5UKSr7vn0ASD2FkZPFgXJpiYdT1NeKenfL3ITZYx7nvjNGuv0Xx2IhdFs0Np+zPMlBEONdeODET+8sxAX7yuL/k+ED29tH6CnKro7Ffyt5CbXXZPogUZ1qmGAEZ7e/7eDL5vYFbuwub/KKHjLo3UT0vOadCXYoU7+tvMe7MtI6lH/zpIvu7H14+FA5RiYDpcxd358S6XNOhAx6OsuMfI1KGHb/TXYA1/+uNYm1B89GnQGgk/Y0Tsf7JWBPxnwkHeoyfLdrF5C7I4QbzQ1Unmpfgn4uAasE9Posehm5INUEF7mSA7374mFWaCLtsBjmOSK8b159Tnsm/h2Hzv85WKppvSzV+50r+xE2Y2C7Q1z9iZ8T4zgbw3jo17k665JYlYImAwCH6UodEmKcs52g1GeZcaKi3JFQoQP5gpmtEW39ozg3gNriUINVKSxwt1mXPFejSQQXVihpajyeHsso8iUAKmCD26Ut09Nr+XpDSWwr+l6i6IGyF8MXfXvMFGSwd6WoChhq2RVVEMI42irj8sMWyaEz8XzLvcq21dPytCSpqeeVe/xsaDkkhTtiQ8pqy X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6423.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(136003)(396003)(39860400002)(346002)(366004)(451199021)(6486002)(186003)(82960400001)(54906003)(86362001)(6666004)(478600001)(53546011)(6506007)(26005)(9686003)(316002)(8936002)(8676002)(85182001)(41300700001)(5660300002)(6512007)(66476007)(66556008)(66946007)(6916009)(4326008)(38100700002)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d0N2RjhGK0JFNzZCYzVHQXlmQnFMNVNMNEFMMFNmc2xGWUR2UDZxeGswbmhZ?= =?utf-8?B?SDVhQnZXVkxkelVJdGhkYzU4ekZRQU9ROHcrbDl0Wi91M3ZiM0V4Z29FNG9x?= =?utf-8?B?aTR5cjZPRVUwWFJkdzUrWUw0ZzErdU1EMkRJZXVJeEd2Zy9RYTR3VktVdzlO?= =?utf-8?B?K0lqb0k3VjRHYkdCOUNjcnNFcXQ4K05sRWl6eFNDazUxejlSU25uamF2RFNP?= =?utf-8?B?MktJaDk2bVFsMzUvUlBlcHM5TG1SOE9SaVBtK3crVklPQTUzbG5wUE9XVEdL?= =?utf-8?B?VXJxRVNMWGh5b3FzU3cvL3ltdis2d2psNFptMXlyUmxHUUtta2o3YTZDY21q?= =?utf-8?B?UDBYaFY3RUdDMEdaSDR0Q3V4ZUpQem1tNi9jb0Z3NEFZdFF2bGE1SFkySmlz?= =?utf-8?B?V0xWTzRYYVMzUFluc0xNSkZleGIySDBtdUU2V2JrbldTSDBPZjZCRlFXeUto?= =?utf-8?B?aGx6K2pvdXJpUnZucTR0Wjl4UzRjUHhQUERHVXVYOWs5MHkyZFVPdmg3MXR4?= =?utf-8?B?VE16ckdJMDJlU0daZkxMdXhtNG1aZ01SSjJSWnliditpOTFZNDY3NW5NWUhz?= =?utf-8?B?OGtscmdKaFUvZXFBVElsTERlM1VLYjlpMENvUDd1U2s2bWgvZUFoRG9LQnFZ?= =?utf-8?B?ZUo3bVJlQWh1V2Jkd29aR0dzcWNtMDYzWFlycHI1d3dXQlViNlNoZmFtRzVH?= =?utf-8?B?NUtaRnU2WGJ1N2l4cXpSOUJVMGJUOWxkTUJRQytTVG1SZUhFYS9HTkZESEdL?= =?utf-8?B?QUM5RUx5ZWFlRGpiSzd4M1dIelhWc243SXJleUhEU3R5bWtNRFVQdnNScTF3?= =?utf-8?B?bUNYWWdIQ0d2amlPZFBRamZWVWd6VEJ3dmFwZERZbmMvUG55YisxalNOMXVz?= =?utf-8?B?S2M3eW83RHlUU1RjSUNGMDg1dVc0cnhCSlRqOVhDQ2o4YXlYcjVEUHpsOUhH?= =?utf-8?B?bzV2Z2VjV09adUZzVitENmRnNC94Z0U1MEw1RGQ2Y1lXeVFsVFBHd3pNS2RF?= =?utf-8?B?YmJ3elhRMDhlS085NDJ2ZHdQeDM0OEhXamozL0k1alBFUEJyMFZaeDdTSUtX?= =?utf-8?B?RlZUNjRkWTZCeUhlZEdJdkRCMGlWc1habkVCUWE4LzRpaU5SWVNmb1pJNkRo?= =?utf-8?B?MmhQWU5hNWxKeG1pNTluV0FROVpnUVJXRFFpc2EwSEFSNWhkSzQ3bm5WckNa?= =?utf-8?B?Q0hwQkFmbW14L3hibEtpMFRPTElFWVA1dHpYM2hFTDNySGlLWkNJS0Qrb1B3?= =?utf-8?B?VWxmZklxWFlScjRENEhiLytlR0F1R0JDQjlaK2QveVdzaVQ4T1F5eU9qUEM2?= =?utf-8?B?eFQrdlFrdnVmMFZzb0d0L1dOdmkwL0dGcVBlS2QrVzY5VGxLeUhKMG9kZUgv?= =?utf-8?B?dlNxU21lME5HLzZZMFpSN3dwYnpKWGllaVMzZTdPMHpBQklySHI2QU54R0w4?= =?utf-8?B?VDlrdDRCWTZBZFprSy9zby82QjlTZktCamQvMGMvdkJDeGhESk5hQkFaY1ZP?= =?utf-8?B?a2tRb0NKclVocENoWlQ5SU1PeGhpUzFpZXlsMEZXbzFDdzAxUC85Y2prOGs5?= =?utf-8?B?T1dTaTROVkw3dG9ZM3M2Q1gxMDlZS240RFJUcW5hM0prcEJNcTBGcGxNb3A4?= =?utf-8?B?VENqenFMRGZBSEJCR0gva1BPVmQ4blFFYTNBNGdncWs5Y1UxdFowM3RHQzZP?= =?utf-8?B?Mk5nNkZqbmkrcnlrUVp5V1paZ2ZpVHRsWVd4VGRRSWt6N21hVHFURjhsR3BZ?= =?utf-8?B?ZUJuR3R4d2Y1TUJHMWlYZ1VIY2pYTWFqb29hT2t1aHd0MTJxSFROS282Q1Bs?= =?utf-8?B?SDR3Q3RoMVdXYUhNNzJmSjdWTFluWTdHNzEzcVlvazhMN2F6NnoweVZ0cDV0?= =?utf-8?B?U2FHWmVhalcvZXQzMUZGZlJTWEFza2xKWjMwS1J2dnBqSGpVNnQ3bVUzTi81?= =?utf-8?B?RElVVUo2TmtUdVFTVmY1SHdpRGg2WUlQeXR4Ui9zYlMrdGV4QWlSSkVBS2o4?= =?utf-8?B?OEtvaFdwNzdlV2VLME5hTXNHR1NiTk1XZC9YTWpCaVdPM0JNZzVrZnBaQVN2?= =?utf-8?B?a3F1R2NNak5EcmxhM0F1QmxLVjg5NnlVVGpML01LQVN0S3AydXcwUERzMDVq?= =?utf-8?B?NnNHZElGOVlBcjF3TUR3cjRxS1gxK2t4T2J2UWcvYy9ZYmtmczFrN01nU0Vz?= =?utf-8?B?eWc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: IQ7ZsoN75F7ibhuAtca09+92sBNXHuhYAxpYYhv2pts+ibTJIm+NGrmnBF1aYSTb6+zO0xKGvWyxSSytvvNFeHdbvbyZSd33qnSmfwgmD15gXXeMYbP3NIgnmtI2tGte4o4yo7xHfowdtOh5q8acsHMcrM/jWWZSKRFlo5REjIKvPtMTHBKCOKNkW5H0uX8sbwykJUgHCA5WduHdtwqrOkw/sH6qHdArn8wBR5MGAJjCJYAVtvhLWe58xuwO+NWfZIhvGg2RQKJ6F3fRTp8Omium6mLDnPOMVnP//L7Nno1UWgukbuahZO/zfGmhMxmcggw/pBcf2SNmfJ2tLxmnyxPFj/JGu4Cu6DTTT3GJ89kYt7crurTx+96okmwfQZpGHreNODF8PWf/zgWxawYyG61nk4+o2ccMvahG+aJsc84d+7czGR8khLHFw9o5ISFUe5PPF2HPTzJW7nRkAH3cgyWa0kX0jclbaQgAG72BHMTAPJLU7FA+L8ygM0h/4OaR9C+lui8eQWpnrCMedD3F4/MU5Ui0+ocjtd+SzEEFjWToB32anSRBWLhApKvoDpvkWyP3qr5Nu+EyaGIQWtw2v0KQlh7+B+3hMBvrvn1kHcItBUlgUdBmJIOu9UvG9xJT3gHKn+8CX0q5TYVzLGVNkNFaufRNYDrjk9oBkmuthYPyCsfDGtQg2SDNDeXE7E/c+NDQRZxEwX6f1QTet2JesrUGA8wsglRTX8EajTjwIY/YXWjB1+AJJbE5mIUVdyI4jDhFUyh8Gy/dwh0Bpvoq9cg9ZOOcJuFy8DW2DjaPQJpHJrU9SOeiV+I5l6o4CJq8 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: fab9ef08-7ef7-48ef-69aa-08db82df717d X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6423.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 13:53:59.9772 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: h4+Ekyyrfd8d556iZa4Np3Ehk/iR0oCsFYyqptYy70rYrhEWcNVnxAeeeybKP/qsQxE4JPp37rOKqKFhpQnb4A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB5999 On Wed, Jul 12, 2023 at 12:07:43PM +0200, Jan Beulich wrote: > On 11.07.2023 15:02, Roger Pau Monné wrote: > > On Tue, Jul 11, 2023 at 12:53:31PM +0200, Jan Beulich wrote: > >> On 10.07.2023 16:43, Roger Pau Monné wrote: > >>> On Mon, Jul 10, 2023 at 12:56:27PM +0200, Jan Beulich wrote: > >>>> On 07.07.2023 11:53, Roger Pau Monne wrote: > >>>>> The current logic to init the local APIC and the IO-APIC does init the > >>>>> former first before doing any kind of sanitation on the IO-APIC pin > >>>>> configuration. It's already noted on enable_IO_APIC() that Xen > >>>>> shouldn't trust the IO-APIC being empty at bootup. > >>>>> > >>>>> At XenServer we have a system where the IO-APIC 0 is handed to Xen > >>>>> with pin 0 unmasked, set to Fixed delivery mode, edge triggered and > >>>>> with a vector of 0 (all fields of the RTE are zeroed). Once the local > >>>>> APIC is enabled periodic injections from such pin cause a storm of > >>>>> errors: > >>>>> > >>>>> APIC error on CPU0: 00(40), Received illegal vector > >>>>> APIC error on CPU0: 40(40), Received illegal vector > >>>>> APIC error on CPU0: 40(40), Received illegal vector > >>>>> APIC error on CPU0: 40(40), Received illegal vector > >>>>> APIC error on CPU0: 40(40), Received illegal vector > >>>>> APIC error on CPU0: 40(40), Received illegal vector > >>>>> > >>>>> That prevents Xen from booting. > >>>> > >>>> And I expect no RTE is in ExtInt mode, so one might conclude that > >>>> firmware meant to set up RTE 0 that way. Mainly as a remark, albeit > >>>> of course there's then the question whether to change the RTE > >>>> rather than masking it. What do ACPI tables say? > >>> > >>> There's one relevant override: > >>> > >>> [668h 1640 1] Subtable Type : 02 [Interrupt Source Override] > >>> [669h 1641 1] Length : 0A > >>> [66Ah 1642 1] Bus : 00 > >>> [66Bh 1643 1] Source : 00 > >>> [66Ch 1644 4] Interrupt : 00000002 > >>> [670h 1648 2] Flags (decoded below) : 0000 > >>> Polarity : 0 > >>> Trigger Mode : 0 > >>> > >>> So IRQ 0 -> GSI 2, so it's likely pin 0 is the one the i8259 is > >>> connected to. > >> > >> Then wouldn't we be better off converting that RTE to ExtInt? That > >> would allow PIC IRQs (not likely to exist, but still) to work > >> (without undue other side effects afaics), whereas masking this RTE > >> would not. > > > > I'm kind of worry of trying to automate this logic. Should we always > > convert pin 0 to ExtInt if it's found unmasked, with and invalid > > vector and there's a source override entry for the IRQ? > > > > It seems weird to infer this just from the fact that pin 0 is all > > zeroed out. > > As you say in the earlier paragraph, it wouldn't be just that. It's > unmasked + bad vector + present source override (indicating that > nothing except perhaps a PIC is connected to the pin). I can do this as a separate patch, but not really here IMO. The purpose of this patch is strictly to perform the IO-APIC sanitation ahead of enabling the local APIC. I will add a followup patch to the series, albeit I'm unconvinced we want to infer IO-APIC pin configuration based on firmware miss configurations. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Jul 12 13:57:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Jul 2023 13:57:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.562533.879261 (Exim 4.92) (envelope-from ) id 1qJaL2-0001rS-VS; Wed, 12 Jul 2023 13:57:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 562533.879261; Wed, 12 Jul 2023 13:57:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qJaL2-0001qf-Ql; Wed, 12 Jul 2023 13:57:04 +0000 Received: by outflank-mailman (input) for mailman id 562533; Wed, 12 Jul 2023 13:54:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qJaIM-0001Kh-2j for xen-devel@lists.xenproject.org; Wed, 12 Jul 2023 13:54:18 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2060d.outbound.protection.outlook.com [2a01:111:f400:7eab::60d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 96ad5705-20bb-11ee-b239-6b7b168915f2; Wed, 12 Jul 2023 15:54:16 +0200 (CEST) Received: from BN8PR12MB3587.namprd12.prod.outlook.com (2603:10b6:408:43::13) by SN7PR12MB8004.namprd12.prod.outlook.com (2603:10b6:806:341::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.30; Wed, 12 Jul 2023 13:54:11 +0000 Received: from BN8PR12MB3587.namprd12.prod.outlook.com ([fe80::669f:5dca:d38a:9921]) by BN8PR12MB3587.namprd12.prod.outlook.com ([fe80::669f:5dca:d38a:9921%4]) with mapi id 15.20.6588.017; Wed, 12 Jul 2023 13:54:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 96ad5705-20bb-11ee-b239-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lg/wJHH/ZFJfBXf0dR+HzSa8gUzcCNvgEVvSP267D7MPQK3c5Exm7efzcpBuo/uHQ9WOvoGqGIVxG40Rc82ll6k2VkBtY1yuAaYceR/K//D14Gm0caoArWB3nfjKis14Vskkl0gSEIzUbyz8mqAk0gEsHi+duohyuMOg2sGtjJab7KWtg4+aigLjIevXMT9EMyH4/8k/rcdxC8VEE1KEbQateFBjVetDl1pvJneGzw3czwTtBQciw04ZgfocQhHIfF9cClYcvKS59o75Obf7g7CcFeutjC4KZIDbPZC2MrPgdhHt9VK7C82QtwlM63cm1vipNSn0EqwbJk05JoZkOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XgHMqA6NR6xwi31+5UQb02kpONt6s3GFuikZRULOVgI=; b=XcpEFbGo4dujwilE05EBLxUAB4zsdSGoZgIAg7JhFWRakc8T6Z5SxWzlFR5OPi0yEBzVwcBJVx21N6zDlJrw88liyEa3Qb3q1tRUxUvgCgu23cpv2gVXUPTy5SdiEVvy/MP/iWQAFMSC9E1HkUKoUWYyz4UCwrODoIGzQR7Stf1uViO9Mo0aFUcTck0fYCVUyXWgjyrJscV3vgmjbnlWa3cUf2F+tLcmQYpMJH+oddSKYKdJNiM/NmBHSoYjjUCDePj/XpsawdOanzetUfInWzoimAoLBVt45F9UDG0yd1mG3gf7G8OwxPWh/RL7pIZwKiGJvxdfLrhBI+roBotxUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XgHMqA6NR6xwi31+5UQb02kpONt6s3GFuikZRULOVgI=; b=VsTwGxlovAH+46yi04iJt6VNhWVApnJMd0mPZ5sw1AqorHxPRvBJGBkrD52FaJ9tbEji7+v0jusEoLcCNJqN5huTd57Zq9u6F31SQth6QTv2sU53YqkDgGQDd2Lj2tG/LZx4c+pqyQW2Di8ZFFsObxdpo62OpsNeTEiAtUV1kqo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <603f0b69-71d3-ad8f-4b5e-53b63a6fd521@amd.com> Date: Wed, 12 Jul 2023 15:53:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev Content-Language: en-US To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Maxime Ripard Cc: =?UTF-8?Q?Heiko_St=c3=bcbner?= , Geert Uytterhoeven , Xinliang Liu , Linus Walleij , Tomi Valkeinen , Alexey Kodanev , dri-devel@lists.freedesktop.org, Vandita Kulkarni , Alim Akhtar , Anitha Chrisanthus , Marijn Suijten , Jonathan Hunter , Arun R Murthy , Jerome Brunet , Liu Shixin , linux-samsung-soc@vger.kernel.org, Samuel Holland , Matt Roper , Wenjing Liu , Javier Martinez Canillas , Stanislav Lisovskiy , Danilo Krummrich , NXP Linux Team , spice-devel@lists.freedesktop.org, Niranjana Vishwanathapura , linux-sunxi@lists.linux.dev, Stylon Wang , Tim Huang , Suraj Kandpal , =?UTF-8?Q?Andr=c3=a9_Almeida?= , Andi Shyti , Yifan Zhang , Jani Nikula , Sascha Hauer , Lucas De Marchi , Inki Dae , Hersen Wu , Jessica Zhang , Kamlesh Gurudasani , Bhawanpreet Lakha , =?UTF-8?Q?=c5=81ukasz_Bartosik?= , Radhakrishna Sripada , Andrew Jeffery , Seung-Woo Kim , =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= , kernel@pengutronix.de, Alex Deucher , freedreno@lists.freedesktop.org, Claudiu Beznea , Zack Rusin , Gerd Hoffmann , Alexandre Belloni , linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, Mitul Golani , =?UTF-8?Q?Jos=c3=a9_Roberto_de_Souza?= , virtualization@lists.linux-foundation.org, Thierry Reding , Yongqin Liu , Mario Limonciello , Fei Yang , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , David Lechner , Julia Lawall , Juha-Pekka Heikkila , "Jiri Slaby (SUSE)" , David Francis , Aaron Liu , Patrik Jakobsson , Vinod Polimera , linux-rockchip@lists.infradead.org, Fangzhi Zuo , Aurabindo Pillai , VMware Graphics Reviewers , Ben Skeggs , =?UTF-8?Q?Jouni_H=c3=b6gander?= , Dave Airlie , linux-mips@vger.kernel.org, Maxime Coquelin , Gurchetan Singh , Martin Blumenstingl , linux-arm-msm@vger.kernel.org, Animesh Manna , linux-renesas-soc@vger.kernel.org, Jani Nikula , Chaitanya Kumar Borah , Biju Das , linux-amlogic@lists.infradead.org, Evan Quan , Michal Simek , linux-arm-kernel@lists.infradead.org, Sean Paul , Neil Armstrong , Kai Vehmanen , Boris Brezillon , Chunyan Zhang , Qingqing Zhuo , Sandy Huang , Swati Sharma , John Stultz , Paul Kocialkowski , Kyungmin Park , Drew Davenport , Kevin Hilman , Hawking Zhang , Haneen Mohammed , Anusha Srivatsa , Dan Carpenter , Karol Herbst , Joonas Lahtinen , linux-hyperv@vger.kernel.org, Stefan Agner , Melissa Wen , =?UTF-8?Q?Ma=c3=adra_Canal?= , Luca Coelho , Laurent Pinchart , Andrzej Hajda , Likun Gao , Sam Ravnborg , Alain Volmat , Xinwei Kong , Jernej Skrabec , Deepak Rawat , Chen-Yu Tsai , Joel Stanley , Philipp Zabel , Ankit Nautiyal , Harry Wentland , Sumit Semwal , Alan Liu , Philip Yang , Lyude Paul , intel-gfx@lists.freedesktop.org, Alison Wang , Wolfram Sang , Abhinav Kumar , Gustavo Sousa , Baolin Wang , Rodrigo Vivi , Mikko Perttunen , Tvrtko Ursulin , Rodrigo Siqueira , Tomi Valkeinen , Deepak R Varma , "Pan, Xinhui" , Chia-I Wu , Konrad Dybcio , Kieran Bingham , Tian Tao , Shawn Guo , Khaled Almahallawy , linux-stm32@st-md-mailman.stormreply.com, Emma Anholt , Chun-Kuang Hu , Imre Deak , Liviu Dudau , Alexandre Torgue , Roman Li , Paul Cercueil , Rob Clark , Hamza Mahfooz , David Airlie , Marek Vasut , Jiapeng Chong , xen-devel@lists.xenproject.org, Guchun Chen , Oleksandr Andrushchenko , Raphael Gallais-Pou , Rodrigo Siqueira , Russell King , Leo Li , Uma Shankar , Mika Kahola , Jiasheng Jiang , Srinivasan Shanmugam , Thomas Zimmermann , Vinod Govindapillai , linux-tegra@vger.kernel.org, =?UTF-8?B?TWFyZWsgT2zFocOhaw==?= , Maarten Lankhorst , =?UTF-8?Q?Joaqu=c3=adn_Ignacio_Aramend=c3=ada?= , Melissa Wen , Hans de Goede , linux-mediatek@lists.infradead.org, Fabio Estevam , Laurentiu Palcu , Matthias Brugger , David Tadokoro , AngeloGioacchino Del Regno , Orson Zhai , amd-gfx@lists.freedesktop.org, Jyri Sarha , Yannick Fertre , Nicolas Ferre , Krzysztof Kozlowski , Philippe Cornu , Daniel Vetter , Wayne Lin , Dmitry Baryshkov , Nirmoy Das , Lang Yu , Lucas Stach References: <20230712094702.1770121-1-u.kleine-koenig@pengutronix.de> <94eb6e4d-9384-152f-351b-ebb217411da9@amd.com> <20230712110253.paoyrmcbvlhpfxbf@pengutronix.de> <20230712133803.rf26cbg5wz7wsmgl@pengutronix.de> From: =?UTF-8?Q?Christian_K=c3=b6nig?= In-Reply-To: <20230712133803.rf26cbg5wz7wsmgl@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0182.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::17) To BN8PR12MB3587.namprd12.prod.outlook.com (2603:10b6:408:43::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8PR12MB3587:EE_|SN7PR12MB8004:EE_ X-MS-Office365-Filtering-Correlation-Id: 671d3312-9a10-4462-11d9-08db82df77d0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Q+CjsHYjoEoIKYhGUtD4L6IdokqTfF3/rDoqE4aTyfCbPLgsxxuVuGUsuYCA35P4DktoBo4NaYU33T1d8TbAYeptCtWe1B55Dc7oLzVxiycliZfDBnEm8XarwPg0ryzzSJwJvhapixHLvylLlitF0v/N12hzY0tfsoDFfKqumWSnLuk5x9Kn4zL6bJWU91FmrGKdnYdHX5drfEhP8xT5CwqxgEcEcA6YmR3c+YE5hsNLi/9CstC4LyCaAp5+lOrfLNlEjbdWekywxde7dpFY5E5s2/endwHQUHrz1bB9ykbxzYdRfCd0i9JW7/R6RC1xHH6+RRBRUIVRg1hDT66tr9wgyeCj9kKh/5b2fvBgeIJAefMeQ4DQGX2ABfSJY1ODzvBXYMRjaaJvv2MH5lBW1Wdn+4LhArrIoqD0ox+pZbg4DAYjKVelomflcL76YONd3m/Nm+A7Hl4KYkmN3O9uoF8v3kUa4pH8JvdeVkcLPt6rn2HtEznZol9p06p+UQwoRqyFsHPi7xBhaQmHP/1s/M/8/S29cNU3SALPZIHU7nlxbjBCA4vScSL+4SOd+JOPhDgQZTqOQ2+2X3KoAk0XpNvhaWjTc9kOmWYNTsNJP8BQ2Q3Gk9OICAtK/ERCMFrWI2Rxa4J2jJ36saRcsxOVNQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR12MB3587.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(366004)(396003)(39860400002)(136003)(451199021)(8676002)(8936002)(7336002)(83380400001)(2906002)(66574015)(2616005)(36756003)(38100700002)(31696002)(86362001)(7406005)(7416002)(7366002)(7276002)(5660300002)(6506007)(186003)(31686004)(6666004)(66556008)(66476007)(4326008)(6486002)(110136005)(54906003)(66946007)(41300700001)(6512007)(316002)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cWZnOXNSRjdOTkRMN2twRmhhNlZKUU04WHhCY2Z0bUFVMmd0ZzMzZldoayts?= =?utf-8?B?elhFTXRKeWVNRUpHQ01yaTVaa1Ztakt4R216MWlHODdMUmhQYjdhMWRWUk9K?= =?utf-8?B?OFRpNCtPWlhuR003dy83ZXZySTlIcExnU1c0aHFEaWlya2hyRDliSjlkYlg1?= =?utf-8?B?bDNlV3I3b3VsWXN6VStIZDhhd1hzcW5OblM5Z0ZwWmp2b0FTMTVpdE5zTC9J?= =?utf-8?B?SGFRSm5PVmVhSjJSWnd6V2dYcE9RenYzbEg0UEpZTGRvbFQzUVFWQUZERjRu?= =?utf-8?B?bE5ncmc4N0xPZkZEbURQTjIwYlpYSFNzUC91TUxYZVZ2bHgvQmNNak5aNHp2?= =?utf-8?B?SG5kdnIvdmliUitLc2lYbnVpdjJOOHJLYkhMK3doOFdIZGtlckJSRmt1WHZ5?= =?utf-8?B?VTM4QldNT0JwV29jQXF4SzVaMzhpRmhCcmlJOVJTVFp0VzE0RGtUYmIrb3dJ?= =?utf-8?B?MnQvb0tRaFpVWlBjVE5OdE9heDVyYjNkUExTN3BxaWNCOE1WVTFoQkh6R3V6?= =?utf-8?B?eHhYS0FMVURYRFp0VXA5ZFBUNmV2QU5tMzVxK2FERFc5aFFObEkzKyt6ekpX?= =?utf-8?B?YlM4VElnWStHaVNhY2dsdWdDSGh4TkNEZnpveVk1c3I4RCtIOHJJTTNIbTF2?= =?utf-8?B?U3NtaTF5OWZ6Z0FpSFRLcHdBVFlpcEpoTVU1TjJnZ1J4YW9qVmlUSHViNlVL?= =?utf-8?B?emNONXFSYzhSM04xc0xkNmFidGw3cWNrbEs1OHVOTENPamFlRzB5SzVWNFlN?= =?utf-8?B?T0tIQWc0T0JNT2VxR25wKzFjSE00NVg3cWxMNGxtOC9ubHRlOTN1QXllQkhZ?= =?utf-8?B?a2RJVjF1RjhleWdlMzZkcDVMTForNU13UllNVUdBYldTYXJnTXdEVjBIZlVZ?= =?utf-8?B?R1lNOUM4VGhGV2NYMDExWU1tNG1VTUlEMzQrQjI3S0JvTjQ3aStLdlUrU2xn?= =?utf-8?B?MkdRdFR0eXl3VEtWL2p2WWRNb1pIMFNERHVxdm1tSHVyRkN6elVOcjBDVUw0?= =?utf-8?B?cGRVdlpCdVJFb1dHYk03VlVUZzl3NE8vVlN6bksrZGd3SEx0d1QwNmVKeVBT?= =?utf-8?B?ZHVkWXRCMjIvem9VOTl1ZnJQVEVCbUtuWElLY0ZTRWxnM3VPVFh6V1MvZnJO?= =?utf-8?B?ZG9zQ3VaQnFLUjZ1OXdGNEFMS1JWOS9BSTRYQkxPMHVxckYzaGFxcmtlcXgz?= =?utf-8?B?VXhrcE9CT2twUXYwQVYxSHk4UEJsdlVwMnF0YmxkUmh6cUMrdlI3SE9GUDVU?= =?utf-8?B?MzVxUUpHQXNOL1Z1REY2dTc0cEQwUGlHZVdqUmlzbHd6Nk1jdExTMjZDMXlQ?= =?utf-8?B?elJxMDZOWEhibURhenV4RHNwdUdXWDhxNXMwcVVucHBGOUI0WndLeXRmLzVz?= =?utf-8?B?UUxGUVhLaHEwK1NOd0pHYk9Lb2dnSGhqNU9LN3NWTlhxKzBXd3UxOUlWaEtI?= =?utf-8?B?UmIxeHUzOXdvNmtOM0hXbVJIYW5tWUFGMi94ck5Yb0VHUitCeFc1SlphVXJZ?= =?utf-8?B?cm1xaW1nL1NjQmdLQUd3dXUyQ2wyblJZMWZ0RGxGSXN3T296N1Y3dDk4dUhN?= =?utf-8?B?TVpGYWllcmdvYXFhUVdlanB1V3F5RzM2Zm9RSjZpNk5wSWZpWmhiYzNSVS9r?= =?utf-8?B?SDY5U1BHQlVrWTgvd1M1Y0tCUkFMK0RHNnBxUjQ5ZnQ5dU8yKzdvSC9JWXRP?= =?utf-8?B?V0pLTytkVTlEUkNWOTgyZ3QyL1BnOEpwNzB0YjMvUEVzazhiY2owVGg2RWdq?= =?utf-8?B?Mmh4R2JINXdPK3B0QnVxQjNJaTBTeUtzSE5oYlNtQjBvMnZCb2hleEc4RkJm?= =?utf-8?B?Q3lzZ3J6MjU4a1pLaDFnalFBT0FvTFZtYkZHckExSFRtU3NHbHY1Sjd0NFB3?= =?utf-8?B?WDg2MU1PaC93VE9vYVFZdmZ4dmh1R0RzYlRtcmdTUTh1MjZoR2NVUVErZVRy?= =?utf-8?B?aCtjeWp2dk1IWWg2anFrZDQ2WWMzSGtWY0xBT3FPZXJBMXY0U2xGNkY0eFZ3?= =?utf-8?B?QnpHWjJ2WXBGdjBBRTUvcXVkeC8yYkdXSWRJMDZIOUNSOHdsR2JhYWVNMkU5?= =?utf-8?B?T1FQQk9YVVFTL2RLcllWZXhWdGt0YWxxc2JJYVpwYlRRc3AxZGpLYTdLaXU4?= =?utf-8?B?K0hSNmJqS3BVUG04aWhWdlBvM2lBSTZQZU9kaDBwT2tJRkozSjdRZVNZSmkr?= =?utf-8?Q?wZiHYk+qO2DJStqXYi3DikavUdxGeplCKcXkmFW5lXc7?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 671d3312-9a10-4462-11d9-08db82df77d0 X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 13:54:10.5983 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ISzr+3rCUPYNUMLw1tOBcCfws4G9gt0O8QB3ANwU8gXg/6JBx2yCDaCKDG7kwoD8 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8004 Am 12.07.23 um 15:38 schrieb Uwe Kleine-König: > Hello Maxime, > > On Wed, Jul 12, 2023 at 02:52:38PM +0200, Maxime Ripard wrote: >> On Wed, Jul 12, 2023 at 01:02:53PM +0200, Uwe Kleine-König wrote: >>>> Background is that this makes merge conflicts easier to handle and detect. >>> Really? >> FWIW, I agree with Christian here. >> >>> Each file (apart from include/drm/drm_crtc.h) is only touched once. So >>> unless I'm missing something you don't get less or easier conflicts by >>> doing it all in a single patch. But you gain the freedom to drop a >>> patch for one driver without having to drop the rest with it. >> Not really, because the last patch removed the union anyway. So you have >> to revert both the last patch, plus that driver one. And then you need >> to add a TODO to remove that union eventually. > Yes, with a single patch you have only one revert (but 194 files changed, > 1264 insertions(+), 1296 deletions(-)) instead of two (one of them: 1 > file changed, 9 insertions(+), 1 deletion(-); the other maybe a bit > bigger). (And maybe you get away with just reverting the last patch.) > > With a single patch the TODO after a revert is "redo it all again (and > prepare for a different set of conflicts)" while with the split series > it's only "fix that one driver that was forgotten/borked" + reapply that > 10 line patch. Yeah, but for a maintainer the size of the patches doesn't matter. That's only interesting if you need to manually review the patch, which you hopefully doesn't do in case of something auto-generated. In other words if the patch is auto-generated re-applying it completely is less work than fixing things up individually. > As the one who gets that TODO, I prefer the latter. Yeah, but your personal preferences are not a technical relevant argument to a maintainer. At the end of the day Dave or Daniel need to decide, because they need to live with it. Regards, Christian. > > So in sum: If your metric is "small count of reverted commits", you're > right. If however your metric is: Better get 95% of this series' change > in than maybe 0%, the split series is the way to do it. > > With me having spend ~3h on this series' changes, it's maybe > understandable that I did it the way I did. > > FTR: This series was created on top of v6.5-rc1. If you apply it to > drm-misc-next you get a (trivial) conflict in patch #2. If I consider to > be the responsible maintainer who applies this series, I like being able > to just do git am --skip then. > > FTR#2: In drm-misc-next is a new driver > (drivers/gpu/drm/loongson/lsdc_crtc.c) so skipping the last patch for > now might indeed be a good idea. > >>> So I still like the split version better, but I'm open to a more >>> verbose reasoning from your side. >> You're doing only one thing here, really: you change the name of a >> structure field. If it was shared between multiple maintainers, then >> sure, splitting that up is easier for everyone, but this will go through >> drm-misc, so I can't see the benefit it brings. > I see your argument, but I think mine weights more. > > Best regards > Uwe > From xen-devel-bounces@lists.xenproject.org Wed Jul 12 13:57:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Jul 2023 13:57:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.562530.879256 (Exim 4.92) (envelope-from ) id 1qJaL2-0001o9-Md; Wed, 12 Jul 2023 13:57:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 562530.879256; Wed, 12 Jul 2023 13:57:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qJaL2-0001o2-Jy; Wed, 12 Jul 2023 13:57:04 +0000 Received: by outflank-mailman (input) for mailman id 562530; Wed, 12 Jul 2023 13:53:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qJaHE-00015o-E0 for xen-devel@lists.xenproject.org; Wed, 12 Jul 2023 13:53:08 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6cf2c5de-20bb-11ee-8611-37d641c3527e; Wed, 12 Jul 2023 15:53:06 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B9C64617D6; Wed, 12 Jul 2023 13:53:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A345AC433C7; Wed, 12 Jul 2023 13:53:02 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6cf2c5de-20bb-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689169984; bh=0sbyIiczIJDnx26Ch8e9l+qxXeZZ0rwKcMQ0zWjPG2E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hjUTKto8Ioz8iKBRqNaRabBf11Oc7eHOlmTK9M/ZTt8ltDoWCX6CFOzjIGxRlGFY3 Gx5jqcVwy1TF/krIPVc4UMyuHZxNLbDekq6CNc/YFW9XZuZPgy9H7AxolbKkWLgnAi r9fpm9kzzSwMYN6Psfg7TVfTW8n0B+mvlh2FTRcCYAZ0ciN3u0JY7dyza48kXnOA9n WMci9hbcuhVOWKEEdS8SZtYhWg6pK+ZLR69YBjxKaOmTAGDWdtxl6Adlqjo21243Qn XbsKfbvDJLN7WkAM0aaNNMoLWVYfSKf0LdY3uyS6mKtDCMS2NYJoRkpPzq+x8hypZP ozEduvqpUbjZw== Date: Wed, 12 Jul 2023 15:53:00 +0200 From: Maxime Ripard To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Heiko =?utf-8?Q?St=C3=BCbner?= , Geert Uytterhoeven , Xinliang Liu , Linus Walleij , Tomi Valkeinen , Alexey Kodanev , dri-devel@lists.freedesktop.org, Vandita Kulkarni , Alim Akhtar , Anitha Chrisanthus , Marijn Suijten , Jonathan Hunter , Arun R Murthy , Jerome Brunet , Liu Shixin , linux-samsung-soc@vger.kernel.org, Samuel Holland , Matt Roper , Wenjing Liu , Javier Martinez Canillas , Stanislav Lisovskiy , Danilo Krummrich , NXP Linux Team , spice-devel@lists.freedesktop.org, Niranjana Vishwanathapura , linux-sunxi@lists.linux.dev, Stylon Wang , Tim Huang , Suraj Kandpal , =?utf-8?B?QW5kcsOp?= Almeida , Andi Shyti , Yifan Zhang , Jani Nikula , Sascha Hauer , Lucas De Marchi , Inki Dae , Hersen Wu , Jessica Zhang , Kamlesh Gurudasani , Bhawanpreet Lakha , =?utf-8?Q?=C5=81ukasz?= Bartosik , Radhakrishna Sripada , Andrew Jeffery , Seung-Woo Kim , Noralf =?utf-8?Q?Tr=C3=B8nnes?= , kernel@pengutronix.de, Alex Deucher , freedreno@lists.freedesktop.org, Claudiu Beznea , Zack Rusin , Gerd Hoffmann , Alexandre Belloni , linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, Mitul Golani , =?utf-8?B?Sm9zw6k=?= Roberto de Souza , virtualization@lists.linux-foundation.org, Thierry Reding , Yongqin Liu , Mario Limonciello , Fei Yang , Ville =?utf-8?B?U3lyasOkbMOk?= , David Lechner , Julia Lawall , Juha-Pekka Heikkila , "Jiri Slaby (SUSE)" , David Francis , Aaron Liu , Patrik Jakobsson , Vinod Polimera , linux-rockchip@lists.infradead.org, Fangzhi Zuo , Aurabindo Pillai , VMware Graphics Reviewers , Ben Skeggs , Jouni =?utf-8?B?SMO2Z2FuZGVy?= , Dave Airlie , linux-mips@vger.kernel.org, Maxime Coquelin , Gurchetan Singh , Martin Blumenstingl , linux-arm-msm@vger.kernel.org, Animesh Manna , linux-renesas-soc@vger.kernel.org, Jani Nikula , Chaitanya Kumar Borah , Biju Das , linux-amlogic@lists.infradead.org, Evan Quan , Michal Simek , linux-arm-kernel@lists.infradead.org, Sean Paul , Neil Armstrong , Kai Vehmanen , Boris Brezillon , Chunyan Zhang , Qingqing Zhuo , Sandy Huang , Swati Sharma , John Stultz , Paul Kocialkowski , Kyungmin Park , Drew Davenport , Kevin Hilman , Hawking Zhang , Haneen Mohammed , Anusha Srivatsa , Dan Carpenter , Karol Herbst , Joonas Lahtinen , linux-hyperv@vger.kernel.org, Stefan Agner , Melissa Wen , =?utf-8?B?TWHDrXJh?= Canal , Luca Coelho , Laurent Pinchart , Andrzej Hajda , Likun Gao , Sam Ravnborg , Alain Volmat , Xinwei Kong , Jernej Skrabec , Deepak Rawat , Chen-Yu Tsai , Joel Stanley , Philipp Zabel , Ankit Nautiyal , Harry Wentland , Sumit Semwal , Alan Liu , Philip Yang , Lyude Paul , intel-gfx@lists.freedesktop.org, Alison Wang , Wolfram Sang , Abhinav Kumar , Gustavo Sousa , Baolin Wang , Rodrigo Vivi , Mikko Perttunen , Tvrtko Ursulin , Rodrigo Siqueira , Tomi Valkeinen , Deepak R Varma , "Pan, Xinhui" , Chia-I Wu , Konrad Dybcio , Kieran Bingham , Tian Tao , Shawn Guo , Christian =?utf-8?B?S8O2bmln?= , Khaled Almahallawy , linux-stm32@st-md-mailman.stormreply.com, Emma Anholt , Chun-Kuang Hu , Imre Deak , Liviu Dudau , Alexandre Torgue , Roman Li , Paul Cercueil , Rob Clark , Hamza Mahfooz , David Airlie , Marek Vasut , Jiapeng Chong , xen-devel@lists.xenproject.org, Guchun Chen , Oleksandr Andrushchenko , Raphael Gallais-Pou , Rodrigo Siqueira , Russell King , Leo Li , Uma Shankar , Mika Kahola , Jiasheng Jiang , Srinivasan Shanmugam , Thomas Zimmermann , Vinod Govindapillai , linux-tegra@vger.kernel.org, Marek =?utf-8?B?T2zFocOhaw==?= , Maarten Lankhorst , =?utf-8?Q?Joaqu=C3=ADn_Ignacio_Aramend=C3=ADa?= , Melissa Wen , Hans de Goede , linux-mediatek@lists.infradead.org, Fabio Estevam , Laurentiu Palcu , Matthias Brugger , David Tadokoro , AngeloGioacchino Del Regno , Orson Zhai , amd-gfx@lists.freedesktop.org, Jyri Sarha , Yannick Fertre , Nicolas Ferre , Krzysztof Kozlowski , Philippe Cornu , Daniel Vetter , Wayne Lin , Dmitry Baryshkov , Nirmoy Das , Lang Yu , Lucas Stach Subject: Re: [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev Message-ID: References: <20230712094702.1770121-1-u.kleine-koenig@pengutronix.de> <94eb6e4d-9384-152f-351b-ebb217411da9@amd.com> <20230712110253.paoyrmcbvlhpfxbf@pengutronix.de> <20230712133803.rf26cbg5wz7wsmgl@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jyn7gwdek3zlokhs" Content-Disposition: inline In-Reply-To: <20230712133803.rf26cbg5wz7wsmgl@pengutronix.de> --jyn7gwdek3zlokhs Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 12, 2023 at 03:38:03PM +0200, Uwe Kleine-K=F6nig wrote: > Hello Maxime, >=20 > On Wed, Jul 12, 2023 at 02:52:38PM +0200, Maxime Ripard wrote: > > On Wed, Jul 12, 2023 at 01:02:53PM +0200, Uwe Kleine-K=F6nig wrote: > > > > Background is that this makes merge conflicts easier to handle and = detect. > > >=20 > > > Really? > >=20 > > FWIW, I agree with Christian here. > >=20 > > > Each file (apart from include/drm/drm_crtc.h) is only touched once. So > > > unless I'm missing something you don't get less or easier conflicts by > > > doing it all in a single patch. But you gain the freedom to drop a > > > patch for one driver without having to drop the rest with it. > >=20 > > Not really, because the last patch removed the union anyway. So you have > > to revert both the last patch, plus that driver one. And then you need > > to add a TODO to remove that union eventually. >=20 > Yes, with a single patch you have only one revert (but 194 files changed, > 1264 insertions(+), 1296 deletions(-)) instead of two (one of them: 1 > file changed, 9 insertions(+), 1 deletion(-); the other maybe a bit > bigger). (And maybe you get away with just reverting the last patch.) >=20 > With a single patch the TODO after a revert is "redo it all again (and > prepare for a different set of conflicts)" while with the split series > it's only "fix that one driver that was forgotten/borked" + reapply that > 10 line patch. As the one who gets that TODO, I prefer the latter. >=20 > So in sum: If your metric is "small count of reverted commits", you're > right. If however your metric is: Better get 95% of this series' change > in than maybe 0%, the split series is the way to do it. I guess that's where we disagree: I don't see the point of having 95% of it, either 0 or 100. > With me having spend ~3h on this series' changes, it's maybe > understandable that I did it the way I did. I'm sorry, but that's never been an argument? I'm sure you and I both have had series that took much longer dropped because it wasn't the right approach. > FTR: This series was created on top of v6.5-rc1. If you apply it to > drm-misc-next you get a (trivial) conflict in patch #2. If I consider to > be the responsible maintainer who applies this series, I like being able > to just do git am --skip then.=20 Or we can ask that the driver is based on drm-misc-next ... > FTR#2: In drm-misc-next is a new driver > (drivers/gpu/drm/loongson/lsdc_crtc.c) so skipping the last patch for > now might indeed be a good idea. =2E.. which is going to fix that one too. Maxime --jyn7gwdek3zlokhs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZK6wPAAKCRDj7w1vZxhR xY/cAP9MfcZQUQhgCUm7SZclTdLuVOlNrClVj1izsCv4zrFrtQD+JUUX9b9K3JdO tDqchM2qQCmIMTRzt6ZwyV0l4KQkjgM= =G8dy -----END PGP SIGNATURE----- --jyn7gwdek3zlokhs-- From xen-devel-bounces@lists.xenproject.org Wed Jul 12 14:23:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Jul 2023 14:23:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.562553.879276 (Exim 4.92) (envelope-from ) id 1qJakc-0005sn-4a; Wed, 12 Jul 2023 14:23:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 562553.879276; Wed, 12 Jul 2023 14:23:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qJakc-0005sg-1F; Wed, 12 Jul 2023 14:23:30 +0000 Received: by outflank-mailman (input) for mailman id 562553; Wed, 12 Jul 2023 14:23:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qJaka-0005sa-KY for xen-devel@lists.xenproject.org; Wed, 12 Jul 2023 14:23:28 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20611.outbound.protection.outlook.com [2a01:111:f400:7e1a::611]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a9f8d62e-20bf-11ee-8611-37d641c3527e; Wed, 12 Jul 2023 16:23:26 +0200 (CEST) Received: from AS8PR04MB8788.eurprd04.prod.outlook.com (2603:10a6:20b:42f::21) by PR3PR04MB7212.eurprd04.prod.outlook.com (2603:10a6:102:8c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.20; Wed, 12 Jul 2023 14:23:24 +0000 Received: from AS8PR04MB8788.eurprd04.prod.outlook.com ([fe80::cbc0:69aa:c9a2:198e]) by AS8PR04MB8788.eurprd04.prod.outlook.com ([fe80::cbc0:69aa:c9a2:198e%7]) with mapi id 15.20.6565.016; Wed, 12 Jul 2023 14:23:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9f8d62e-20bf-11ee-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gEog0XhmmjXJwf1bmTbVETiyZPVUb4JvbySmxk0jxodeMnrhpqk3DyuPEVbaSr8NecrSxOoEMOJMrNJ976txdW6Fc/ldqmYN2V6/avfGBwtJC/3jOGb9M6lQetpeehF1U19/kh98xFPQ0AGsAKRSJxWa3iuaK45+52GY40OxkCLtnXdXrMCzSES+MAnFRsyopKWJv/1Fo7DA36YVHHzJZadiaYyXYFY1HIUtZobQjVSmbV7iGbyusIQUNR4DwaKf6x6J9RTcNsTFLKo2lJBUmsYymtCv1Y2Ylvhqc967ULydWy0eJ/yoVu8+DPIwLezPd4C2LPrY9K9PqGWFnEjxHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K7CXn2W39dnnk5PdOufiMOKJrY1668M2OesQaA2XClM=; b=b2ZLc9NeT7/CYP6CSNjts20wQdWG+ItES21NB5GukIqrHr+EBEbsQhgE9r81CEscEjrjX8rzurg5j6foxM4e41lT+cLJOLXdy9EH5pSXZb27kvX05ViIcPI3hp3R9X824mp1yfNtDYKoK27gBcfyIcIfqCaiJcU5XLuNdoShLaD/ANOKYuIi+U8Ko+lMzb8pTdP9D3/809/EUT13BsNJxc5FnONwM0atcaNdpKcMw6Z8kZWgDzO4hr3rHg3rOsx/VZgjIko9fd0LMpWRC2JnTfO1ykxSdWQDcJF/3SYaYd5mUUQ5YCUR2bFYIGIVLxZqdrnFgqIb++hoc2JNZTC7Mw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K7CXn2W39dnnk5PdOufiMOKJrY1668M2OesQaA2XClM=; b=KBNgtflVb2Nzyi2j3Y5PXB/SIt0eDF5/Css79fsaLPCaBGezZkzy3QjD2uSauEdY7o1C9qUN3UfmoZ8wgvyLKGxC5LEbp4m4dP7EaLqlkllZS6ZOkA9o7B4U6DSiS3WICE2sB1O4gzKexbjiN2EYnT5aw1Qby3cWm5qD9kvqmrD/pRpvg8d90qWyphql/DROsx1whNbgR3MwMouB/oqZ3MayiXOMg77n1UEGuuL6qX/U8lwun5IONKMAuMOy6OAJbcLMUS7VSu9rsRwSMHk/L5KshoJD/pW/dMxS6LcgPD8tia7bKqLpdqFP9yxV+ARyM3xIeZ22seF9jLHoirzLkA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 12 Jul 2023 16:23:22 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Anthony Perard From: Jan Beulich Subject: [PATCH] build: correct gas --noexecstack check Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0209.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::8) To AS8PR04MB8788.eurprd04.prod.outlook.com (2603:10a6:20b:42f::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8788:EE_|PR3PR04MB7212:EE_ X-MS-Office365-Filtering-Correlation-Id: 217ab0bd-6cd9-4e24-162a-08db82e38d0c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uXjHehHLwvw/s5zEcdUpShm+ZYFX6ZHV16YvAsQwBmx7YTWonoh4xkVHPP+bvvbLp46JXxbEg5PfvpPzJ6tsqCkA63Tw/S7hFpksycD2DPZkt8HoiGzdJr2EjN3t7STpvSKb78ANI4BLXG2YIB9Z4GapAzWIYtp5O2mWR5ZMU7Cju8H/AjXnp8jVgZ/ZiUxeekmQj9Hh3ibFG5VZEGQR9YLQVaXeS2qjfC6A9X10/ki5ZrdfAmyzHlWdQ0zEgEakm6oggYkmR+YffRzNFtGb6PnE1z+1gTeF3nGAM8IujoY76F22AnF8+Kf9ZMZIRYJZ9SlAr2JUpDyI10hdAC/eXCuKrq4i3SYY8IEtQuLq1L8oq6Yb9mKxLGLHjczfsblFP9UWqoG1xBftsMOYOpm+IVIycSNmbBtTv2dnkqLIAVhtzJAg2925u5RJBUpyufml4peJisAh+6VmTVjLEPLNbo42GbUmwHQYSj4TXjSG8HtoWRn1tg3zsfJnBFEfMnLix5DeL36tSBAIlZVqM6gF89tF10X+NjZarLlJt1V4ky5KeVx8jNCifDRkeo29E0wAdBIkWLf5BeF97qobNtMDF16Dc6aMe6YdonezfRsxUoBIbmLbkZr9H97gylxisLIia9pyTq0QBj3hyazxa9ZdTA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8788.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(39860400002)(376002)(366004)(136003)(346002)(451199021)(8936002)(8676002)(38100700002)(2616005)(41300700001)(2906002)(316002)(5660300002)(4744005)(31686004)(6916009)(66476007)(4326008)(66946007)(66556008)(6486002)(6512007)(83380400001)(478600001)(36756003)(54906003)(86362001)(6506007)(31696002)(186003)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UDR2bkU2cTMydS9HMW1uT29PNXBDaEZKcnVXUU9GL0FWZmZ1b3d6SzNmbHhY?= =?utf-8?B?NXBNU3JiUElzalp1UHFjNTlYSGJiZHA2a2VManBQTTJuQ1Jpd01nVUExdUFy?= =?utf-8?B?RXFQY0loVExEYkZ5RGZYaEF5SHlScEJJakhWM0tKWTJydmFrbGQ1T0RvUmFo?= =?utf-8?B?V1RkMGNjWThSQkpDUmZuTG5DbTNaRjQrQ2FuaU9uTVBsOEFIWDNaSTY4aUEz?= =?utf-8?B?YkdGcTMvaTlFRlpEK1h5YnpTUXJaYmgrZExCd3gwUVl6ZGxlbGdMazB5QU5n?= =?utf-8?B?akxRWGsrZHJkNTZ3T21XRFdCeG9BdWNxZldPMU1wbDl1aCs0YjFSWkZZM21y?= =?utf-8?B?dUhhbjhwK0hVT09kTjU4Tzl4RFdtQU9kNzIxdXBoc0IzcXoxaERud01Ga1h3?= =?utf-8?B?cUM1dllFRkRWNEJxakgxUk0rWlppMkZ3bVJlSVJQRmFraHprZStjTE1TMjlH?= =?utf-8?B?Tnd2T3V0dE93YjEvMEZBeVdLSStxZTJwZS9TbWU2QUNVLy9zZEZyMjRuZlVu?= =?utf-8?B?a25TbC83dEdxZktTTlB3cUdLb0toazVJdEQ2TkxZWjIycVhFNUdsd3lCUVBB?= =?utf-8?B?bHk0a1JNUGFnNmtmeTFnZHp0cEhRZXV1aVhsQS82bFRYWUdXUlVYekNEZm1H?= =?utf-8?B?eWh0L1hsSVZwTmtjeGUvU0FwUHJlL0hLMS9Xb3kwNkJNSkUwR1RKY2lpRlhj?= =?utf-8?B?cTF3amQrUnpYK0lyb1FWTlk1cjZ1aGwxVTZTdnExVmhJNzNjcUFiWFU1MTlh?= =?utf-8?B?d2xqMnJETUpkbzQ0UDdTa0JjS0RiVENQNThRUm1Cei9xL0VGQ2xYaDZyWEt6?= =?utf-8?B?cFZwd25EbzVGTTBuQTVrdU5UN3Q3UnQ0cXJ3bFVISGMxZ1JBeXNXcE9HdUhQ?= =?utf-8?B?OTdneUxrMTRRR2Y1alpiWk5sZXJkVEtUWTlKYlZLc1NrSlAxODIzUDNvVVNT?= =?utf-8?B?WWR1UHEzalU1MDcxeDBkMlRDaUJFUE9NaEdkOFR0a3FJMDRVaUswa2dDdG5U?= =?utf-8?B?N1ZGME44WTFiZWpOcnl3ZUZRZk9NYklvRGNuTlJXeVlaZFIwRUxIMmp0QWQy?= =?utf-8?B?cTJHUzBUam90WVdUK0FnRkltcER0WTVhSkJIeXM2c3diTm1OT2g2Um5YTHJH?= =?utf-8?B?RHVJRDZsZHpBSmxhR0lseUc3WnhCdmdRdVNiUHkrOTR4ZGdmZ1JlTm1lUTRr?= =?utf-8?B?ZGN4S0RxZ2lnZVpJeHVqM0loMXk2VG5tRS9yUlZibGdGZ1VzRlVKc0c3Rnlo?= =?utf-8?B?ZlpBa2xrSUJOVVUwaW9NMFZNTDR5YzBFanplZlA0NEszUytzdlY2aWpxUW1k?= =?utf-8?B?a0FSRGFOR1RqbWVISFlhMks5RmZYRFNRNlBRelUrTlNOcnhqMTFkTU5GMHhL?= =?utf-8?B?Smtpb1I0dElPbWFYaFR0azluZkJoaXF0QzFod01GY0xLR2pVV3BEanBGa2lO?= =?utf-8?B?Z1RCaldmU1hRdTlyeWlZL09XVVY1R1hwVCtTS3p3M2ljWVM2QVJ5VE5wcFVG?= =?utf-8?B?OEwzaHhvQStlclM1MGFtNnBDY1IwVW8yY2JCVDBJZHNtTkxhaU1kcHFFaEF5?= =?utf-8?B?Qk9UV0VGYktvOENLUG83MXV3empYS1g1RHEwWWJoUTk4MzNGWE8rS04xcDU2?= =?utf-8?B?RnE4eWJGY09taEh0TmVaSmFvamlaVkhHY2s4Ny9yZVU4TExyN0l1SjhkV3pj?= =?utf-8?B?U1FKc3l5SkhrWVkya2VYWGtZR1NzdDlRTUdSN3RKakVBUXhjNTc3RGUwM1Zz?= =?utf-8?B?ZlU4UG4rL0VDMm1KdE1FS1BiYmpEcE0welBETTdXZ3JIdVMrdDRpQnNrejh6?= =?utf-8?B?ZDlLdE0yT1NoM0QyZ3dMaGxvWHBVUEZkZTdBZ2l1L2tnc2VXZlp3dU95Z3k5?= =?utf-8?B?Wm5kMVZFRXRjZXZSMnRsSW01K3NMUVFKc3JOOE16MHNtcngrMnVlRE9mdER0?= =?utf-8?B?SFZqRWtlU2k5Q2IvRzZQU016Ty9uY3ZoamUvZTRTYjBuVGRzRkZTQ2tReTh1?= =?utf-8?B?aTFhWDdTUWZpcXlOdkZHbzUwTDJWSGpBVzJqa2REK3ZKNnNmZkVxTmZMT3Ji?= =?utf-8?B?ZytxNHl4a1pZK2V4eVZWSzBESmJlU1c4MDhtdzlPa3FIMWVjei9JTUJDcXRo?= =?utf-8?Q?7WVE6n/+z09Ae0LIPf2WiFhYo?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 217ab0bd-6cd9-4e24-162a-08db82e38d0c X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8788.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 14:23:24.0059 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RRC+sTLpiOsBv7ytiD+GYv72abV/KSWWlRkAwcRQzURd8wZO96p6QlSWLKEOebWhQccwurQWKoKTMnTx1BhaEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7212 The check was missing an escape for the inner $, thus breaking things in the unlikely event that the underlying assembler doesn't support this option. Fixes: 62d22296a95d ("build: silence GNU ld warning about executable stacks") Signed-off-by: Jan Beulich --- a/xen/Makefile +++ b/xen/Makefile @@ -397,7 +397,7 @@ endif AFLAGS += -D__ASSEMBLY__ -$(call cc-option-add,AFLAGS,CC,-Wa$(comma)--noexecstack) +$(call cc-option-add,AFLAGS,CC,-Wa$$(comma)--noexecstack) LDFLAGS-$(call ld-option,--warn-rwx-segments) += --no-warn-rwx-segments From xen-devel-bounces@lists.xenproject.org Wed Jul 12 14:25:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Jul 2023 14:25:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.562559.879286 (Exim 4.92) (envelope-from ) id 1qJaly-0006Tu-Ho; Wed, 12 Jul 2023 14:24:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 562559.879286; Wed, 12 Jul 2023 14:24:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qJaly-0006Tn-EL; Wed, 12 Jul 2023 14:24:54 +0000 Received: by outflank-mailman (input) for mailman id 562559; Wed, 12 Jul 2023 14:24:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qJalw-0006TZ-OH; Wed, 12 Jul 2023 14:24:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qJalw-0001hT-NN; Wed, 12 Jul 2023 14:24:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qJalw-0005Us-FB; Wed, 12 Jul 2023 14:24:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qJalw-00054S-Ej; Wed, 12 Jul 2023 14:24:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=tqTxoUeYnGe9Y6zIyCrqXerG71dbHS6Uf/xyMSHaiOo=; b=ONQtsaKF2MS+/+wR8w/wMV2AS+ Po+eURtz+lJkE7+p1C8jv0Yo4uP8wtPZDD7ymILJ5yu5Ob6yIjvqT2Bpgw0kp11FYMcIc/RG0sAbq jn0ttPrXThi9rTGhELksoIFRGxOi1RnlrjUA18gfXXFADULw+0rcjEDZXInnF75rXM/s=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 181773: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=0a834e953b01ec25c412369d7a5b8b57d340ac60 X-Osstest-Versions-That: xen=3c911be55f1c4e0063e690fb61223df21511b5bb From: osstest service owner Date: Wed, 12 Jul 2023 14:24:52 +0000 flight 181773 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181773/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 0a834e953b01ec25c412369d7a5b8b57d340ac60 baseline version: xen 3c911be55f1c4e0063e690fb61223df21511b5bb Last test of basis 181766 2023-07-11 21:02:08 Z 0 days Testing same since 181773 2023-07-12 12:02:02 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Gianluca Luparini Jan Beulich Roger Pau Monné Simone Ballarin Tamas K Lengyel jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 3c911be55f..0a834e953b 0a834e953b01ec25c412369d7a5b8b57d340ac60 -> smoke From xen-devel-bounces@lists.xenproject.org Wed Jul 12 14:25:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 12 Jul 2023 14:25:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.562564.879296 (Exim 4.92) (envelope-from ) id 1qJamY-00070Z-Qp; Wed, 12 Jul 2023 14:25:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 562564.879296; Wed, 12 Jul 2023 14:25:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qJamY-00070S-Nz; Wed, 12 Jul 2023 14:25:30 +0000 Received: by outflank-mailman (input) for mailman id 562564; Wed, 12 Jul 2023 14:25:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qJamX-00070C-9W for xen-devel@lists.xenproject.org; Wed, 12 Jul 2023 14:25:29 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2062a.outbound.protection.outlook.com [2a01:111:f400:7e1a::62a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f2685bff-20bf-11ee-b239-6b7b168915f2; Wed, 12 Jul 2023 16:25:28 +0200 (CEST) Received: from AS8PR04MB8788.eurprd04.prod.outlook.com (2603:10a6:20b:42f::21) by PR3PR04MB7212.eurprd04.prod.outlook.com (2603:10a6:102:8c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.20; Wed, 12 Jul 2023 14:25:26 +0000 Received: from AS8PR04MB8788.eurprd04.prod.outlook.com ([fe80::cbc0:69aa:c9a2:198e]) by AS8PR04MB8788.eurprd04.prod.outlook.com ([fe80::cbc0:69aa:c9a2:198e%7]) with mapi id 15.20.6565.016; Wed, 12 Jul 2023 14:25:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f2685bff-20bf-11ee-b239-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N+Whk3ZjwvGog9jqyDMsK572DTqQn41KB7pG6skssYZR3hiZ2sXBiqEu21yd+zSZ1s2uhWK8CxDeN36mjk4jBLzrf8ladfBFuf+lEPy7ZptyCJcmRFMssMRsm/a8tBv+T8SvEBpOazkMiOEouRXqZl//N3OEotm+qWyJO78mK7doAyTvtuwxaZ4+FKSJkIuR8xPnxkxBy3L1HpfAesW2d9UobTxcH1aWhxRP92ft2XKOtQwy6aLMcwaPk94QwxMU73/lLvh2suH4h5mie40MZ02/hpqQw/U703ujwJwmmuUWx5LQzVVCbJmbjQBP/qHdC2LmzdUrsExxmDhESG8oug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=actnbxdtcI+RA2YJzPiZ0LnEyvRXEVw+dZc506y8HFE=; b=jqg4Np3Se3XGomdJYKG1saVYBVQuN0ZdkkPAvsRISF82ZKojbCsQnFwByQUjGLp+yLXdhVj4Yw30/GvQ4gyXkO+H3LLBdCDUwiZTwWkylU3LCyDeiq3xmmNGTBXyHAA79EsU8Nt08cjVnorstlCiwRM3Vcvv6VS3CDlIlsHuhXAI0amD/oVCnIN1xowKjQhO/KMi9VweAeZsZSu7LGT8NV+ej8rxC2tIOKSLri7moyCVq0i4uDfen9rUukVyefe+TT2p6PWa9EpGT3mqidTwlOuQG0ypm7dPw8jqYFoZoIVE/nEpsnolRAhq48du0ZIWYhTYLvFv+F2RjBUa1erc5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=actnbxdtcI+RA2YJzPiZ0LnEyvRXEVw+dZc506y8HFE=; b=TOFD1KCdTxW5HNkL+PfKBC2R3cyCvkNrwAWpdqMBsfd+IHkfNrTFZk4J41Qn3Iun2oX5evhdh+t/WNBqwn7gJfGG8okOzKWw2yQFEf6/KK5ojktxvJt5OMD8XZ9GAOwvRf7OCtw1X8Bl8GMj+jsQ1M+RX90WHhvV0Dh/5g7YouRi2mp/1fEhUeO+I2ZLazgfyFRzjg40hh5yLllsiwXDvKK26DBM69LoucSfB4wSrOsVGPmSizluXeSmeFsviCQ9OqjmyjHD+5hWDymAPPd++D5VkcglGzAm9s6o7whuUeB7YSVuHFOTUa8AvUwGv+9hfNU2TBdCIVWfK39QNEn3gg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 12 Jul 2023 16:25:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: [PATCH 0.5/3] build: make cc-option properly deal with unrecognized sub-options Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <0b45bc88-fe5f-77f1-9f9c-37d9ea1ec73c@suse.com> In-Reply-To: <0b45bc88-fe5f-77f1-9f9c-37d9ea1ec73c@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0177.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::14) To AS8PR04MB8788.eurprd04.prod.outlook.com (2603:10a6:20b:42f::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8788:EE_|PR3PR04MB7212:EE_ X-MS-Office365-Filtering-Correlation-Id: e7a27805-536d-4f20-c776-08db82e3d5c2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zQ89SBAsJWKrqc6EOnSRfEtmu1C4evK4HYZhy+z30ZzcbuStHJBQ7EYQnfL/Vo0jZhRV9aFGNVMQSTqDnhbVAhZX4JTgOd7caOM97CCpdHc9IaZglriqaqI9gJG1Rxt166erkI8YGhkijk+8WLO/+IAKuOsoiivaCT7s/7i29w4/KkBDeg6+kTKj3uWT4TPFEwJQH3ObilwT8GYHddOU4Kxd1orL0tfguNXtrj7NZqSAXFUERC4hVODLZlBx8jm1ddMId8g6xqgFQ5u9bahyKxLHUR5u2O8PX6Jk/naZIPGgfh8I63TCpIcKgvA6MEIy2X2WQB3mfQDBgegYMhjecY5WV5kBBdXMbxyXcKoYUQObRvdFN/mH9qGPwoSm2PmVe5dO1WF0fhtAeHEQ7X/xDCuwWxsDvpbZdA9PyzdL+cUQ3ou7Uk9NiQxNkrLtVghI2u7223SN8jmGDDTOdQpv4ObUqBt86kt+WhwjEo7UolFHe5/VWIVpEh9BfT+pFvDoQ4w1QAf51VHlXc32GP0KtpimV04BO8q/KzWqC68YP0IFrDnNP7BngZbUionjTGTJKHocrhnQ6iV/6UpIYGJPO+m62jzGDQOlWZGXA8gVVhQaaSRLyrXwwrh8E4dUNngjKz9kUlHHj8xhy/evhWwcyA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8788.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(39860400002)(376002)(366004)(136003)(346002)(451199021)(8936002)(8676002)(38100700002)(2616005)(41300700001)(2906002)(316002)(5660300002)(31686004)(6916009)(66476007)(4326008)(66946007)(66556008)(6486002)(6512007)(83380400001)(478600001)(36756003)(54906003)(86362001)(6506007)(31696002)(186003)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZmJTTmNRV0lXd2g0dmUwN1BjZTJPMm5Qc1MwVGRJS3RUb0lLT1c2eE5Wd3R2?= =?utf-8?B?SUVDd2EzdkQ3Mm9lWnJJbVF4NHhoYW4vaWdnTHl1cTJjTFpGZ29Qc3JURzll?= =?utf-8?B?NW52MUg0MFNrbjByN1FIc1dibWFSOGJXRTJhN2lveWNzRWc0YXQ4WXoyall0?= =?utf-8?B?ZTdTYlBVc3NnUUhFZUN2Z2NQNDAzYmFPUDhTczV4V2VoTWRZVWtZeUNiSmRZ?= =?utf-8?B?b1JaWWw4aVo2RHpPTlVWMEM2d0V3UXN2bFVnLzB1d08rN0Z4dXUwdEg5TjVx?= =?utf-8?B?NGtRRFoxME9SeWNvUzFkc1RWUHFaWU02dHh0c2lCaytHUjB1SER0bjc0WmI0?= =?utf-8?B?NExMdWZ4Ny94aE9Jc1QrMzY2ZWh5ZDRQRVdTcVp2eHFCa0lEZDNZTVZOMllv?= =?utf-8?B?bWJPcTFKdU5VV1lWNVpvNVpoZ2JzTmxjek03YTJUaDJOM3AxNHpnSC9QcTU2?= =?utf-8?B?dUtmZ1NEKzlDWVloOExZZTAzMUdyVXRJRkZ1cWltSy9kTEt2N3oxWjlZa2hl?= =?utf-8?B?TWJTaE0raVJ1emgxS21ncGJzY1doM2FuRkwwZFVxcU1uVS9Tc1JxeU9DWXI2?= =?utf-8?B?bHloTEtneGcxMHhRUC9WcGxnMjlTYlh1SXFMNXVCT0FNd1J2dEpSNGJKWk9N?= =?utf-8?B?QmZ4MkljMUNkeUZUNnFGaFVteTVSbEFBVFFYdW5OQjNaVHlXVEVHbXRXSDhx?= =?utf-8?B?aXJIZUhIdHI3OCt4TkhBekRvVzRYbG9zZFI5V1lhVG85NlREWjN1MXE0QzlK?= =?utf-8?B?YnlUNEdQMDkzbjJMQmlMblVYOTRqQmVGTnQ2QThLVmsyQkNaNTljeDhDZEJ3?= =?utf-8?B?dVBycVpibVBkbkRxeFRnU1VhRWZjNEtjK2NJT2VIazVPdXkvQXJNS2Q4UXU3?= =?utf-8?B?R2JDL2ZtR2x2WE1DNE4rWFc1R2NlMjZiYUdQL0diR2Y5NE5DOXorUFI3MnJV?= =?utf-8?B?Q2MrOWNUZDBSK3kyV1BzVnpwTDFRYk02T0NrdmdEU3R1MTA4MlowUWx5VzhS?= =?utf-8?B?c05XYkZ4WlVwb09sR0xYVGlGSE56WWYxelFiQjd0blFWWklsdTBCcCtIM25U?= =?utf-8?B?czdOSy92Sy9ta3pDOHM3TjZEWWt6bEVlSkVvb1pILzVpYnlzV0doandpeHRE?= =?utf-8?B?YjhTUzIySkxuMUltVGxXc0laVko4QXJDRFNMZjNVWjB6a0pvbmIvMTRVWm5N?= =?utf-8?B?SDhzdERPQzZGL3lORWRza1lncTVRRFI3L3lOODRoTFNZem5vTHkrRXA3eW1G?= =?utf-8?B?eHFGQTZCMlpweVp2KzVhK0piaE9URE1vbCtUUGEvMVlUSGZNeldFUW9yZ01G?= =?utf-8?B?YVhuZ0tqSys4SXdrajVwWHpTalVraTJiL2lLcyt2eHZ5Nk1CdUJBTGFrMjhR?= =?utf-8?B?djg0bHBZS05mcDdOeThYY3FFUjFDM2tqNEgzaitYQ1lzWUtxLytrMUxEeW5G?= =?utf-8?B?VThTYXhQSzM2M2wrL3R4Nm1MY0R6Y3lRNUhyODNvZkd0NkdaWHRrd25DZFVY?= =?utf-8?B?SDd1cGlQcFJsTjdGWEtLMHI1RlRaZTNHK2JiR2VYOUprQmt0TnYwMmVEaEUx?= =?utf-8?B?WFR6VkcyTG5yRlRKMktQYUthbzlnOU0xenR1Sk5ZKzA0NG5uWkRwSzhLbVRK?= =?utf-8?B?S1NWSlVST2F2L3oxNDdqUTQwWFNCeDU1WlJ2VERWL2Q3N25uRlpaY2hIbHlu?= =?utf-8?B?djkyTkVxK0JNbWxtMGs3WTFISnhnQW11aU1hWnZLL3h0Sy9CeTRrM2U3SUJY?= =?utf-8?B?WWVuMTRubHI5NGs1OVlibktIWGIzK2ZvdmFiMXNGcngvUm45MDBGN3JuMUwr?= =?utf-8?B?RmVnWCtGSCtxWTRoYzV6S0VIZWp0OU9sMG5BclpyRFJsOUhNbVVydDdiZnUw?= =?utf-8?B?VmdYVDd0MWZwVlp3ZXdDSjdUZVd2MitDczY4ZG95My8xY0czZWRXQ3N3YnJV?= =?utf-8?B?eFZlZ2dTSU04bnd4VldMOTN5eVBSR093TDJLSSt2OU1NN0w2RlpXVnNjb2RZ?= =?utf-8?B?OXd0eEVJVlZyNC8zb1VwdkdWS1RvMWM1ZlNNMjNxTjR1VzN1bEUzT2xEUlBG?= =?utf-8?B?ZHVJajljR1FvQThGdDdscUNQSUQyeDlESkI3T1ZRcFpxeCtwb0UxWlpNbmZ1?= =?utf-8?Q?y6gaLJhc6KnedrDyFVvxbgqYw?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e7a27805-536d-4f20-c776-08db82e3d5c2 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8788.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 14:25:25.9443 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TpDTHKU9raqA7dirJ34iAXwKoKANbxRWY+wiIqSTMunBLj7n4Y6rcL+ryUqH011DHRFYC/Uc2sEt4BxyeKUw4Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7212 In options like -march=, it may be only the sub-option which is unrecognized by the compiler. In such an event the error message often splits option and argument, typically saying something like "bad value '' for '